WebCore/ChangeLog

   1 2011-01-04  Brady Eidson  <beidson@apple.com>
   2
   3         Reviewed by a spell checker.
   4
   5         * storage/StorageMap.h: mesured?  Really?
   6
   7 2011-01-04  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
   8
   9         Reviewed by Xan Lopez.
  10
  11         [GTK] Port stock icon painting to GtkStyleContext
  12         https://bugs.webkit.org/show_bug.cgi?id=51764
  13
  14         Port stock icon painting for media and search input elements to
  15         GtkStyleContext. Also create the initial machinery for accessing
  16         style contexts for all GTK+ 3.x based widgets.
  17
  18         No new tests. This should not change functionality.
  19
  20         * platform/gtk/RenderThemeGtk.cpp:
  21         (WebCore::paintGdkPixbuf):
  22         (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
  23         (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
  24         (WebCore::RenderThemeGtk::paintMediaButton):
  25         * platform/gtk/RenderThemeGtk.h:
  26         * platform/gtk/RenderThemeGtk2.cpp:
  27         (WebCore::RenderThemeGtk::getStockIcon):
  28         * platform/gtk/RenderThemeGtk3.cpp:
  29         (WebCore::gtkStyleChangedCallback):
  30         (WebCore::styleContextMap):
  31         (WebCore::getStyleContext):
  32         (WebCore::RenderThemeGtk::paintMenuList):
  33
  34 2010-12-31  Antti Koivisto  <antti@apple.com>
  35
  36         Reviewed by Dave Hyatt.
  37
  38         Scripts should not be executed before preceding stylesheets are loaded
  39         https://bugs.webkit.org/show_bug.cgi?id=8852
  40
  41         Block inline script execution on pending stylesheet loads. This matches
  42         other browsers and HTML5.
  43
  44         Tests: fast/tokenizer/inline-script-stylesheet-write.html
  45                fast/tokenizer/inline-script-stylesheet.html
  46
  47         * dom/PendingScript.cpp:
  48         (WebCore::PendingScript::releaseElementAndClear):
  49         * dom/PendingScript.h:
  50         (WebCore::PendingScript::PendingScript):
  51         (WebCore::PendingScript::operator=):
  52         (WebCore::PendingScript::startingPosition):
  53         (WebCore::PendingScript::setStartingPosition):
  54         * html/HTMLLinkElement.cpp:
  55         (WebCore::HTMLLinkElement::process):
  56
  57         This fixes an unrelated bug with beforeload events that was exposed by the other
  58         changes (fast/dom/beforeload/remove-link-in-beforeload-listener.html).
  59
  60         * html/parser/HTMLScriptRunner.cpp:
  61         (WebCore::HTMLScriptRunner::sourceFromPendingScript):
  62         (WebCore::HTMLScriptRunner::runScript):
  63
  64 2011-01-04  Xianzhu Wang  <wangxianzhu@google.com>
  65
  66         Reviewed by Darin Adler.
  67
  68         Let DataView.getInt8() and DataView.setInt8() use int8_t instead of
  69         ambiguous 'char' to fix fast/canvas/webgl/data-view-test.html failure
  70         on ARM.
  71         https://bugs.webkit.org/show_bug.cgi?id=51861
  72
  73         By the way, changed other getIntXX() and setIntXX() methods to use
  74         more precise integer types.
  75
  76         * bindings/js/JSDataViewCustom.cpp:
  77         (WebCore::setDataViewMember):
  78         * bindings/v8/custom/V8DataViewCustom.cpp:
  79         (WebCore::V8DataView::getInt8Callback):
  80         (WebCore::V8DataView::setInt8Callback):
  81         * html/canvas/DataView.cpp:
  82         (WebCore::DataView::getInt8):
  83         (WebCore::DataView::setInt8):
  84         * html/canvas/DataView.h:
  85         * html/canvas/DataView.idl:
  86
  87 2011-01-04  Yong Li  <yoli@rim.com>
  88
  89         Reviewed by Adam Barth.
  90
  91         Suspend HTMLParserScheduler when page load is deferred to
  92         avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
  93         from an external script or by events, and is blocked by a modal dialog,
  94         WebKit can parse more HTML source and also start another JS execution.
  95
  96         https://bugs.webkit.org/show_bug.cgi?id=48077
  97
  98         Test case: WebCore/manual-tests/bugzilla-48077.html.
  99
 100         * dom/DocumentParser.cpp:
 101         (WebCore::DocumentParser::suspendScheduledTasks):
 102         (WebCore::DocumentParser::resumeScheduledTasks):
 103         * dom/DocumentParser.h:
 104         * html/parser/HTMLDocumentParser.cpp:
 105         (WebCore::HTMLDocumentParser::suspendScheduledTasks):
 106         (WebCore::HTMLDocumentParser::resumeScheduledTasks):
 107         * html/parser/HTMLParserScheduler.cpp:
 108         (WebCore::HTMLParserScheduler::HTMLParserScheduler):
 109         (WebCore::HTMLParserScheduler::suspend):
 110         (WebCore::HTMLParserScheduler::resume):
 111         * html/parser/HTMLParserScheduler.h:
 112         (WebCore::HTMLParserScheduler::isScheduledForResume):
 113         * page/PageGroupLoadDeferrer.cpp:
 114         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
 115         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
 116
 117 2011-01-04  Tony Gentilcore  <tonyg@chromium.org>
 118
 119         Unreviewed build fix.
 120
 121         Include glib-object.h for GObject
 122         https://bugs.webkit.org/show_bug.cgi?id=51876
 123
 124         * bindings/gobject/DOMObjectCache.cpp:
 125
 126 2011-01-04  Ryosuke Niwa  <rniwa@webkit.org>
 127
 128         Reviewed by Dan Bernstein.
 129
 130         Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
 131         https://bugs.webkit.org/show_bug.cgi?id=50992
 132
 133         Fixed the bug by interchanging the offset when the direction of inline text box and the containing block
 134         does not match. Reused the code added by http://trac.webkit.org/changeset/73553.
 135
 136         Test: editing/selection/caret-bidi-first-and-last-letters.html
 137
 138         * rendering/InlineTextBox.cpp:
 139         (WebCore::InlineTextBox::offsetForPosition):
 140
 141 2010-12-29  Tony Gentilcore  <tonyg@chromium.org>
 142
 143         Reviewed by Darin Adler.
 144
 145         Remove 2 unnecessary includes from Document.h
 146         https://bugs.webkit.org/show_bug.cgi?id=51727
 147
 148         No new tests because no changed functionality.
 149
 150         * dom/Document.cpp:
 151         * dom/Document.h:
 152         * editing/Editor.cpp:
 153         * editing/SpellChecker.h:
 154         * editing/SplitTextNodeCommand.cpp:
 155         * editing/TextCheckingHelper.cpp:
 156         * page/FrameView.cpp:
 157         * page/Page.cpp:
 158         * rendering/HitTestResult.cpp:
 159         * rendering/InlineTextBox.cpp:
 160         * rendering/InlineTextBox.h:
 161         * rendering/svg/SVGInlineFlowBox.cpp:
 162
 163 2011-01-04  Patrick Gansterer  <paroga@webkit.org>
 164
 165         Unreviewed WinCE build fix.
 166
 167         * CMakeListsWinCE.txt: Added missing include directories, files and libraries.
 168
 169 2011-01-04  Yi Shen  <yi.4.shen@nokia.com>
 170
 171         Reviewed by Simon Hausmann.
 172
 173         Provide an interface to require using fullscreen mediaplayer
 174         https://bugs.webkit.org/show_bug.cgi?id=51133
 175
 176         Only video should be displayed in fullscreen when
 177         requiresFullscreenForVideoPlayback is specified.
 178
 179         No new tests because no client implements requiresFullscreenForVideoPlayback yet.
 180
 181         * html/HTMLMediaElement.cpp:
 182         (WebCore::HTMLMediaElement::updatePlayState):
 183
 184 2011-01-04  Benjamin Poulain  <benjamin.poulain@nokia.com>
 185
 186         Reviewed by Kenneth Rohde Christiansen.
 187
 188         [Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
 189         https://bugs.webkit.org/show_bug.cgi?id=51825
 190
 191         Implement contextMenuItemVector() for Qt, this method is used in WebKit 2 to get the
 192         platform independent menu informations.
 193
 194         * platform/qt/ContextMenuQt.cpp:
 195         (WebCore::contextMenuItemVector):
 196
 197 2011-01-04  Sheriff Bot  <webkit.review.bot@gmail.com>
 198
 199         Unreviewed, rolling out r74960.
 200         http://trac.webkit.org/changeset/74960
 201         https://bugs.webkit.org/show_bug.cgi?id=51868
 202
 203         Rollout since we hit an assert after this patch. (Requested by
 204         krit on #webkit).
 205
 206         * svg/SVGUseElement.cpp:
 207         (WebCore::SVGUseElement::buildInstanceTree):
 208
 209 2011-01-04  Sheriff Bot  <webkit.review.bot@gmail.com>
 210
 211         Unreviewed, rolling out r74961.
 212         http://trac.webkit.org/changeset/74961
 213         https://bugs.webkit.org/show_bug.cgi?id=51867
 214
 215         breaks 32/64-bits debug bots build (Requested by philn-tp on
 216         #webkit).
 217
 218         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
 219         (WebCore::GStreamerGWorld::setWindowOverlay):
 220
 221 2011-01-03  Philippe Normand  <pnormand@igalia.com>
 222
 223         Rubber-stamped by Eric Seidel.
 224
 225         [GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
 226         https://bugs.webkit.org/show_bug.cgi?id=51810
 227
 228         Based on a patch by Mart Raudsepp.
 229
 230         No new tests, build fix only.
 231
 232         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
 233         (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay
 234         API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was
 235         introduced in same version as the xoverlay API change.
 236
 237 2011-01-04  Leo Yang  <leo.yang@torchmobile.com.cn>
 238
 239         Reviewed by Dirk Schulze.
 240
 241         Malformed SVG causes crash in updateContainerOffset
 242         https://bugs.webkit.org/show_bug.cgi?id=44610
 243
 244         We should check recursive <use> at the begining of
 245         WebCore::SVGUseElement::buildInstanceTree instead
 246         of at the end of it because the target element's
 247         children may cause infinite recursive <use>.
 248
 249         Test: svg/custom/recursive-use.svg
 250
 251         * svg/SVGUseElement.cpp:
 252         (WebCore::SVGUseElement::buildInstanceTree):
 253
 254 2011-01-04  Kent Tamura  <tkent@chromium.org>
 255
 256         Unreviewed, build fix.
 257
 258         Try to fix Clang build.
 259
 260         * css/CSSParser.cpp:
 261         (WebCore::valueFromSideKeyword):
 262         (WebCore::CSSParser::parseLinearGradient):
 263
 264 2011-01-03  Julie-Jeongeun-Kim  <Jeongeun.Kim@obigo.com>
 265
 266         Reviewed by Darin Adler.
 267
 268         HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
 269         https://bugs.webkit.org/show_bug.cgi?id=48596
 270
 271         border attribute was not parsed in HTMLObjectElement.
 272         I added code for it as HTMLImageElement handled.
 273
 274         new test:fast/html/object-border.html
 275
 276         * html/HTMLObjectElement.cpp:
 277         (WebCore::HTMLObjectElement::parseMappedAttribute):
 278
 279 2011-01-03  Darin Adler  <darin@apple.com>
 280
 281         Try to fix Chromium build.
 282
 283         * history/HistoryItem.cpp:
 284         (WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here.
 285         Not sure this ever will be used with V8.
 286         (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
 287
 288 2011-01-03  Darin Adler  <darin@apple.com>
 289
 290         Try to fix Leopard build.
 291
 292         * history/HistoryItem.cpp: Use a consistent type, uint64_t, for the
 293         size variable.
 294
 295 2011-01-03  Abhishek Arya  <inferno@chromium.org>
 296
 297         Reviewed by Darin Adler.
 298
 299         Fixes before child calculation when adding anonymous childs to table parts.
 300         https://bugs.webkit.org/show_bug.cgi?id=50932
 301
 302         Fix in r74364 was incomplete. When before child is equal to the table part(to
 303         which the new child is getting added), it confuses the table part to add it
 304         incorrectly as an after child. The patch fixes by passing the before child as
 305         the table part's first child.
 306
 307         Tests: fast/css-generated-content/table-before-after-child-add.html
 308                fast/css-generated-content/table-cell-before-after-child-add.html
 309                fast/css-generated-content/table-row-before-after-child-add.html
 310                fast/css-generated-content/table-row-before-after-child-add.html
 311
 312         * rendering/RenderTable.cpp:
 313         (WebCore::RenderTable::addChild):
 314         * rendering/RenderTableRow.cpp:
 315         (WebCore::RenderTableRow::addChild):
 316         * rendering/RenderTableSection.cpp:
 317         (WebCore::RenderTableSection::addChild):
 318
 319 2011-01-03  Dan Bernstein  <mitz@apple.com>
 320
 321         Reviewed by Simon Fraser.
 322
 323         Shrink HTMLTableCellElement
 324         https://bugs.webkit.org/show_bug.cgi?id=51858
 325
 326         * html/HTMLTableCellElement.cpp:
 327         (WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
 328         m_col.
 329         * html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.
 330
 331 2011-01-03  Darin Adler  <darin@apple.com>
 332
 333         Fix build.
 334
 335         * platform/network/FormData.cpp:
 336         (WebCore::FormData::create): Roll back uint8_t change.
 337         (WebCore::FormData::flatten): Ditto.
 338         (WebCore::FormData::flattenToString): Ditto.
 339         (WebCore::encode): Ditto.
 340         (WebCore::decode): Ditto.
 341         (WebCore::FormData::encodeForBackForward):
 342         * platform/network/FormData.h: Ditto.
 343         * platform/network/mac/FormDataStreamMac.mm:
 344         (WebCore::advanceCurrentStream): Ditto.
 345
 346 2011-01-03  Darin Adler  <darin@apple.com>
 347
 348         Reviewed by Brady Eidson.
 349
 350         Add code to encode/decode the back/forward tree
 351         https://bugs.webkit.org/show_bug.cgi?id=51853
 352
 353         * history/HistoryItem.cpp:
 354         (WebCore::HistoryItem::encodeBackForwardTree): Added.
 355         (WebCore::HistoryItem::encodeBackForwardTreeNode): Added.
 356         (WebCore::HistoryItem::decodeBackForwardTree): Added.
 357         * history/HistoryItem.h: Added functions above.
 358
 359         * platform/network/FormData.cpp:
 360         (WebCore::FormData::create): Changed type to Vector<uint8_t> instead of
 361         Vector<char>. This type is used in our newer code for vectors of bytes.
 362         (WebCore::FormData::flatten): Ditto.
 363         (WebCore::FormData::flattenToString): Ditto. Had to add a cast here.
 364         (WebCore::FormData::encodeForBackForward): Added.
 365         (WebCore::FormData::decodeForBackForward): Added.
 366         * platform/network/FormData.h: Changed type to Vector<uint8_t> instead of
 367         Vector<char>. Also made some single-argument constructors explicit.
 368         Also added the new functions.
 369
 370         * platform/network/mac/FormDataStreamMac.mm:
 371         (WebCore::advanceCurrentStream): Changed to use uint8_t to match above.
 372
 373 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
 374
 375         Attempt to fix GTK build.
 376
 377         * platform/graphics/gtk/FontGtk.cpp:
 378         (WebCore::drawGlyphsShadow):
 379
 380 2011-01-03  Helder Correia  <helder@sencha.com>
 381
 382         Reviewed by Simon Fraser.
 383
 384         ContextShadow can avoid code duplication for getting the CTM
 385         https://bugs.webkit.org/show_bug.cgi?id=51799
 386
 387         ContextShadow defines its own getTransformationMatrixFromContext()
 388         which does exactly the same as GraphicsContext::getCTM().
 389
 390         Existing tests: fast/canvas/canvas*shadow*html
 391
 392         * platform/graphics/ContextShadow.cpp:
 393         (WebCore::ContextShadow::mustUseContextShadow):
 394         (WebCore::ContextShadow::adjustBlurDistance):
 395         (WebCore::ContextShadow::calculateLayerBoundingRect):
 396         * platform/graphics/ContextShadow.h:
 397         * platform/graphics/cairo/ContextShadowCairo.cpp:
 398         (WebCore::ContextShadow::beginShadowLayer):
 399         (WebCore::ContextShadow::endShadowLayer):
 400         (WebCore::ContextShadow::drawRectShadowWithoutTiling):
 401         * platform/graphics/cairo/FontCairo.cpp:
 402         (WebCore::drawGlyphsShadow):
 403         * platform/graphics/cairo/GraphicsContextCairo.cpp:
 404         (WebCore::drawPathShadow):
 405         * platform/graphics/cairo/ImageCairo.cpp:
 406         (WebCore::BitmapImage::draw):
 407         * platform/graphics/gtk/FontGtk.cpp:
 408         (WebCore::drawGlyphsShadow):
 409         * platform/graphics/qt/ContextShadowQt.cpp:
 410         (WebCore::ContextShadow::beginShadowLayer):
 411         (WebCore::ContextShadow::endShadowLayer):
 412         * platform/graphics/qt/FontQt.cpp:
 413         (WebCore::drawTextCommon):
 414         * platform/graphics/qt/GraphicsContextQt.cpp:
 415         (WebCore::GraphicsContext::fillPath):
 416         (WebCore::GraphicsContext::strokePath):
 417         (WebCore::GraphicsContext::fillRect):
 418         (WebCore::GraphicsContext::fillRoundedRect):
 419         * platform/graphics/qt/ImageQt.cpp:
 420         (WebCore::BitmapImage::draw):
 421         * platform/graphics/qt/StillImageQt.cpp:
 422         (WebCore::StillImage::draw):
 423
 424 2011-01-03  Darin Adler  <darin@apple.com>
 425
 426         Reviewed by Dan Bernstein.
 427
 428         InsertTextCommand::m_charactersAdded is unused
 429         https://bugs.webkit.org/show_bug.cgi?id=51849
 430
 431         * editing/InsertTextCommand.cpp:
 432         (WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded.
 433         (WebCore::InsertTextCommand::input): Don't update m_charactersAdded.
 434         * editing/InsertTextCommand.h: Removed charactersAdded function and
 435         m_charactersAdded data member.
 436
 437 2011-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 438
 439         Reviewed by Martin Robinson.
 440
 441         [GTK] Move paintMenuListButton() to RenderThemeGtk.cpp
 442         https://bugs.webkit.org/show_bug.cgi?id=51832
 443
 444         Method paintMenuListButton() contains code common to both gtk 2
 445         and 3, so it can be moved to RenderThemeGtk.cpp instead of
 446         duplicating it.
 447
 448         * platform/gtk/RenderThemeGtk.cpp:
 449         (WebCore::RenderThemeGtk::paintMenuListButton):
 450         * platform/gtk/RenderThemeGtk2.cpp:
 451         * platform/gtk/RenderThemeGtk3.cpp:
 452
 453 2011-01-03  Pratik Solanki  <psolanki@apple.com>
 454
 455         Reviewed by Darin Adler.
 456
 457         https://bugs.webkit.org/show_bug.cgi?id=51850
 458         Put CFNetwork loader code inside USE(CFNETWORK)
 459
 460         Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
 461         files to the WebCore Xcode project.
 462
 463         * WebCore.xcodeproj/project.pbxproj:
 464         * loader/cf/ResourceLoaderCFNet.cpp:
 465         * loader/mac/ResourceLoaderMac.mm:
 466         * platform/network/cf/AuthenticationCF.cpp:
 467         * platform/network/cf/AuthenticationCF.h:
 468         * platform/network/cf/CookieJarCFNet.cpp:
 469         * platform/network/cf/CookieStorageCFNet.cpp:
 470         * platform/network/cf/CookieStorageCFNet.h:
 471         * platform/network/cf/CredentialStorageCFNet.cpp:
 472         * platform/network/cf/FormDataStreamCFNet.cpp:
 473         * platform/network/cf/FormDataStreamCFNet.h:
 474         * platform/network/cf/LoaderRunLoopCF.cpp:
 475         * platform/network/cf/LoaderRunLoopCF.h:
 476         * platform/network/cf/ResourceError.h:
 477         * platform/network/cf/ResourceHandleCFNet.cpp:
 478         * platform/network/cf/ResourceRequest.h:
 479         * platform/network/cf/ResourceRequestCFNet.cpp:
 480         * platform/network/cf/ResourceRequestCFNet.h:
 481         * platform/network/cf/ResourceResponse.h:
 482         * platform/network/cf/ResourceResponseCFNet.cpp:
 483         * platform/network/mac/AuthenticationMac.h:
 484         * platform/network/mac/AuthenticationMac.mm:
 485         * platform/network/mac/FormDataStreamMac.h:
 486         * platform/network/mac/FormDataStreamMac.mm:
 487         * platform/network/mac/ResourceError.h:
 488         * platform/network/mac/ResourceHandleMac.mm:
 489         * platform/network/mac/ResourceRequest.h:
 490         * platform/network/mac/ResourceRequestMac.mm:
 491         * platform/network/mac/ResourceResponse.h:
 492         * platform/network/mac/ResourceResponseMac.mm:
 493
 494 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
 495
 496         Reviewed by Adam Barth.
 497
 498         [Qt] Add SelectAll option to the context menu for the editor
 499         https://bugs.webkit.org/show_bug.cgi?id=50049
 500
 501         Enable SelectAll for the Qt context menu.
 502
 503         * page/ContextMenuController.cpp:
 504         (WebCore::ContextMenuController::populate):
 505         * platform/ContextMenuItem.h:
 506         * platform/LocalizationStrategy.h:
 507         * platform/LocalizedStrings.cpp:
 508         (WebCore::contextMenuItemTagSelectAll):
 509         * platform/LocalizedStrings.h:
 510
 511 2011-01-03  Dan Bernstein  <mitz@apple.com>
 512
 513         Reviewed by Darin Adler.
 514
 515         Shrink RootInlineBox
 516         https://bugs.webkit.org/show_bug.cgi?id=51847
 517
 518         * rendering/RootInlineBox.cpp:
 519         (WebCore::RootInlineBox::alignBoxesInBlockDirection): Changed to use the baselineType()
 520         accessor.
 521         * rendering/RootInlineBox.h: Rolled m_baselineType into a bitfield. Changed its type to
 522         unsigned because otherwise MSVC treats it as signed.
 523         (WebCore::RootInlineBox::baselineType): Added a cast.
 524
 525 2011-01-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 526
 527         Reviewed by Martin Robinson.
 528
 529         [GTK] Split webkitprivate.{cpp,h} in more manageable chunks
 530         https://bugs.webkit.org/show_bug.cgi?id=50698
 531
 532         Fix DOM bindings generation to no longer include the now-gone
 533         webkitprivate.h header, including the appropriate replacements
 534         instead.
 535
 536         * bindings/scripts/CodeGeneratorGObject.pm:
 537
 538 2011-01-03  Brady Eidson  <beidson@apple.com>
 539
 540         Reviewed by Darin Adler.
 541
 542         Add Encode/Decode machinery Darin and I plan to work with for back/forward stuff in WebKit2.
 543
 544         * ForwardingHeaders/wtf/Decoder.h: Added.
 545         * ForwardingHeaders/wtf/Encoder.h: Added.
 546
 547 2011-01-03  Chris Fleizach  <cfleizach@apple.com>
 548
 549         Reviewed by Darin Adler.
 550
 551         AX: Regression: WebKit no longer auto-scrolls with VoiceOver navigation
 552         https://bugs.webkit.org/show_bug.cgi?id=51833
 553
 554         Make sure the web area returns the contentsSize, not the same size as what is displayed.
 555
 556         Test: platform/mac/accessibility/webarea-size-equals-content-size.html
 557
 558         * accessibility/AccessibilityRenderObject.cpp:
 559         (WebCore::AccessibilityRenderObject::boundingBoxRect):
 560
 561 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
 562
 563         Fix warning in 32-bit builds.
 564
 565         * css/CSSGradientValue.cpp:
 566         (WebCore::CSSLinearGradientValue::createGradient):
 567
 568 2011-01-03  Benjamin C Meyer  <bmeyer@rim.com>
 569
 570         Reviewed by Daniel Bates.
 571
 572         In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.
 573         https://bugs.webkit.org/show_bug.cgi?id=51827
 574
 575         * CMakeLists.txt:
 576
 577 2011-01-03  Dan Bernstein  <mitz@apple.com>
 578
 579         Reviewed by Simon Fraser.
 580
 581         Remove the unused RenderTableCell::m_percentageHeight
 582         https://bugs.webkit.org/show_bug.cgi?id=51837
 583
 584         * rendering/RenderTableCell.cpp:
 585         (WebCore::RenderTableCell::RenderTableCell): Removed initialization of m_percentageHeight.
 586         * rendering/RenderTableCell.h: Removed m_percentageHeight.
 587
 588 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
 589
 590         Reviewed by David Hyatt.
 591
 592         Implement -webkit-linear-gradient and -webkit-radial-gradient
 593         https://bugs.webkit.org/show_bug.cgi?id=28152
 594
 595         Add support for -webkit-radial-gradients.
 596
 597         Tests: fast/gradients/css3-radial-gradients.html
 598                fast/gradients/css3-radial-gradients2.html
 599
 600         * css/CSSGradientValue.cpp:
 601         (WebCore::blend): Used to blend colors, which is necessary when truncating
 602         the start of radial gradients.
 603         (WebCore::GradientStop): Small struct to aid gradient stop processing.
 604         (WebCore::CSSGradientValue::addStops): Rename 'positions' to 'stops', and store
 605         the color so that we can blend it when truncating radial gradients. Changed
 606         to handle both linear and radial gradients.
 607         (WebCore::CSSRadialGradientValue::cssText): Update to follow the spec.
 608         (WebCore::CSSRadialGradientValue::resolveRadius): Stylistic change.
 609         (WebCore::distanceToClosestCorner): New utility method.
 610         (WebCore::distanceToFarthestCorner): Ditto.
 611         (WebCore::CSSRadialGradientValue::createGradient): New logic to deal with shape and
 612         fill rules.
 613
 614         * css/CSSGradientValue.h:
 615         (WebCore::CSSGradientValue::isLinearGradient): Color-stop processing needs to know what
 616         kind of gradient it's dealing with, so add new isFooGradient methods.
 617         (WebCore::CSSGradientValue::isRadialGradient): Ditto.
 618         (WebCore::CSSLinearGradientValue::isLinearGradient):
 619         (WebCore::CSSRadialGradientValue::setShape): New setters for shape, size etc.
 620         (WebCore::CSSRadialGradientValue::setSizingBehavior):
 621         (WebCore::CSSRadialGradientValue::setEndHorizontalSize):
 622         (WebCore::CSSRadialGradientValue::setEndVerticalSize):
 623         (WebCore::CSSRadialGradientValue::isRadialGradient):
 624
 625         * css/CSSParser.h:
 626         * css/CSSParser.h: Pass a CSSParserValueList* into parseFillPositionXY() and parseFillPosition()
 627         so we can use parseFillPosition() when parsing a gradient function.
 628         * css/CSSParser.cpp:
 629         (WebCore::CSSParser::parseFillPositionXY): Pass in a CSSParserValueList*
 630         (WebCore::CSSParser::parseFillPosition): Ditto
 631         (WebCore::CSSParser::parseFillProperty): Pass m_valueList to parseFillPosition.
 632         (WebCore::CSSParser::parseTransformOriginShorthand): Ditto
 633         (WebCore::CSSParser::parseRadialGradient): Flesh out radial gradient parsing.
 634         (WebCore::CSSParser::parseTransformOrigin): Pass m_valueList to parseFillPosition.
 635         (WebCore::CSSParser::parsePerspectiveOrigin): Ditto
 636
 637         * css/CSSValueKeywords.in: New keywords for radial gradient shape and fill behaviors.
 638
 639         * platform/graphics/Gradient.cpp:
 640         (WebCore::Gradient::Gradient): Pass aspect ratio for elliptical gradients.
 641         * platform/graphics/Gradient.h: Add aspect ratio for elliptical gradients.
 642         (WebCore::Gradient::create):
 643         (WebCore::Gradient::startRadius): Expose radii.
 644         (WebCore::Gradient::endRadius):
 645         (WebCore::Gradient::setStartRadius): Setters are required for when we need to scale color stops.
 646         (WebCore::Gradient::setEndRadius):
 647         (WebCore::Gradient::aspectRatio):
 648         * platform/graphics/cg/GradientCG.cpp:
 649         (WebCore::Gradient::paint): For elliptical gradients, scale the CTM.
 650         * platform/graphics/wince/GraphicsContextWinCE.cpp:
 651         (WebCore::GraphicsContext::fillRect): Use start/endRadius() rather than r0() and r1().
 652
 653 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
 654
 655         Reviewed by David Hyatt.
 656
 657         Implement -webkit-linear-gradient and -webkit-radial-gradient
 658         https://bugs.webkit.org/show_bug.cgi?id=28152
 659
 660         Add support for the parsing and rendering of non-repeating CSS3 linear gradients,
 661         according to <http://dev.w3.org/csswg/css3-images/#linear-gradients>.
 662
 663         Tests: fast/gradients/css3-color-stop-units.html
 664                fast/gradients/css3-color-stops.html
 665                fast/gradients/css3-gradient-parsing.html
 666                fast/gradients/css3-linear-angle-gradients.html
 667
 668         * css/CSSGradientValue.h:
 669         Add subclasses of CSSGradientValue for linear and radial gradients.
 670
 671         * css/CSSGradientValue.cpp:
 672         (WebCore::CSSGradientValue::image): Add FIXME comment about why we can't cache
 673         the gradient sometimes.
 674         (WebCore::compareStops): positions are CSSValues now.
 675         (WebCore::CSSGradientValue::sortStopsIfNeeded): Add assertion that this is only called
 676         for old-style gradients.
 677         (WebCore::CSSGradientValue::addStops): New method that handles the spec rules about
 678         missing positions, ensuring that stop position is ordered, and spacing out stops
 679         without positions. Also normalize gradients which use stops outside the 0-1 range
 680         so that platforms can render them correctly.
 681         (WebCore::positionFromValue): Determin the position on the gradient line for percentage,
 682         number and length values.
 683         (WebCore::CSSGradientValue::computeEndPoint):
 684         (WebCore::CSSLinearGradientValue::cssText):
 685         (WebCore::endPointsFromAngle): Compute endpoints for a gradient which covers the rectangle
 686         given an angle.
 687         (WebCore::CSSLinearGradientValue::createGradient):
 688         (WebCore::CSSRadialGradientValue::cssText):
 689         (WebCore::CSSRadialGradientValue::resolveRadius):
 690         (WebCore::CSSRadialGradientValue::createGradient):
 691
 692         * css/CSSParser.cpp:
 693         (WebCore::CSSParser::parseValue): Style fix.
 694         (WebCore::CSSParser::parseContent): Use isGeneratedImageValue() and parseGeneratedImage()
 695         (WebCore::CSSParser::parseFillImage): Use isGeneratedImageValue() and parseGeneratedImage()
 696         (WebCore::CSSParser::parseBorderImage): Use isGeneratedImageValue() and parseGeneratedImage()
 697         (WebCore::parseDeprecatedGradientPoint): Renamed to indicate that it's only used for -webkit-gradient.
 698         (WebCore::parseDeprecatedGradientColorStop): Renamed to indicate that it's only used for -webkit-gradient,
 699         and fixed to store CSSValues for the stop position.
 700         (WebCore::CSSParser::parseDeprecatedGradient): Renamed to indicate that it's only used for -webkit-gradient,
 701         and create CSSLinearGradientValue and CSSRadialGradientValue as appropriate.
 702         (WebCore::valueFromSideKeyword):
 703         (WebCore::parseGradientColorOrKeyword): Color parsing utility.
 704         (WebCore::CSSParser::parseLinearGradient): New method to parse linear gradients.
 705         (WebCore::CSSParser::parseRadialGradient): Stub for new method to parse radial gradients.
 706         (WebCore::CSSParser::isGeneratedImageValue): Detect gradients and CSS canvas.
 707         (WebCore::CSSParser::parseGeneratedImage): Parser for generated images like gradients
 708         and CSS canvas.
 709         * css/CSSParser.h:
 710         * platform/graphics/Gradient.h:
 711         (WebCore::Gradient::setP0): We need to be able to change the points when normalizing gradients.
 712         (WebCore::Gradient::setP1): Ditto.
 713
 714 2011-01-03  Noam Rosenthal  <noam.rosenthal@nokia.com>
 715
 716         Reviewed by Andreas Kling.
 717
 718         [Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
 719         https://bugs.webkit.org/show_bug.cgi?id=51464
 720
 721         Added a way to bind any QObject created as a plugin to JavaScript,
 722         by adding a custom member (qtObject) to WebCore::Widget.
 723         Added a test to tst_qwebpage to make sure plugins created
 724         as QGraphicsWidget are accessible through JavaScript.
 725
 726         * bindings/js/ScriptControllerQt.cpp:
 727         (WebCore::ScriptController::createScriptInstanceForWidget):
 728         * platform/Widget.h:
 729         * platform/qt/WidgetQt.cpp:
 730         (WebCore::Widget::Widget):
 731         (WebCore::Widget::setBindingObject):
 732         (WebCore::Widget::bindingObject):
 733
 734 2011-01-03  David Hyatt  <hyatt@apple.com>
 735
 736         Reviewed by Simon Fraser.
 737
 738         https://bugs.webkit.org/show_bug.cgi?id=51328
 739
 740         Printing on a page with body { height: 100% } clips out the overflow contents.  This happened
 741         because the computePageRects function was never correct.  It was using the layer's width and height
 742         for the document's width and height, and the layer no longer includes overflow in its width and
 743         height.  It was also incorrectly assuming the first page would begin at (0,0), and this is an invalid
 744         assumption in RTL or vertical text environments.
 745
 746         Added printing/page-count-percentage-height.html
 747
 748         * page/PrintContext.cpp:
 749         (WebCore::PrintContext::computePageRects):
 750         (WebCore::PrintContext::computePageRectsWithPageSizeInternal):
 751
 752 2011-01-03  Csaba Osztrogonác  <ossy@webkit.org>
 753
 754         [Qt] Unreviewed buildfix for --minimal build after r74895.
 755
 756         * html/InputType.cpp: Missing include added.
 757         * html/NumberInputType.cpp: Missing include added.
 758
 759 2011-01-02  Darin Adler  <darin@apple.com>
 760
 761         Reviewed by Kent Tamura.
 762
 763         Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
 764         https://bugs.webkit.org/show_bug.cgi?id=51791
 765
 766         * dom/InputElement.h: Make sanitizeValueForTextField public so it can
 767         be called by InputType.
 768
 769         * html/BaseButtonInputType.cpp:
 770         (WebCore::BaseButtonInputType::accessKeyAction): Added.
 771         (WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added.
 772         * html/BaseButtonInputType.h: Ditto.
 773
 774         * html/BaseCheckableInputType.cpp:
 775         (WebCore::BaseCheckableInputType::canSetStringValue): Added.
 776         (WebCore::BaseCheckableInputType::accessKeyAction): Added.
 777         (WebCore::BaseCheckableInputType::fallbackValue): Added.
 778         (WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added.
 779         (WebCore::BaseCheckableInputType::isCheckable): Added.
 780         * html/BaseCheckableInputType.h: Ditto.
 781
 782         * html/BaseDateAndTimeInputType.cpp:
 783         (WebCore::BaseDateAndTimeInputType::hasSpinButton): Added.
 784         * html/BaseDateAndTimeInputType.h: Ditto.
 785
 786         * html/BaseTextInputType.h: Made more functions private.
 787
 788         * html/ButtonInputType.cpp:
 789         (WebCore::ButtonInputType::isTextButton): Added.
 790         * html/ButtonInputType.h: Ditto.
 791
 792         * html/CheckboxInputType.cpp:
 793         (WebCore::CheckboxInputType::willDispatchClick): Added.
 794         (WebCore::CheckboxInputType::didDispatchClick): Added.
 795         (WebCore::CheckboxInputType::isCheckbox): Added.
 796         * html/CheckboxInputType.h: Ditto.
 797
 798         * html/DateTimeInputType.cpp:
 799         (WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed
 800         typo in name of this function.
 801         * html/DateTimeInputType.h: Ditto.
 802         * html/DateTimeLocalInputType.cpp:
 803         (WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto.
 804         * html/DateTimeLocalInputType.h: Ditto.
 805
 806         * html/EmailInputType.cpp:
 807         (WebCore::EmailInputType::isEmailField): Added.
 808         * html/EmailInputType.h: Ditto.
 809
 810         * html/FileInputType.cpp:
 811         (WebCore::FileInputType::FileInputType): Added.
 812         (WebCore::FileInputType::canSetStringValue): Added.
 813         (WebCore::FileInputType::canChangeFromAnotherType): Added.
 814         (WebCore::FileInputType::files): Added.
 815         (WebCore::FileInputType::canSetValue): Added.
 816         (WebCore::FileInputType::getTypeSpecificValue): Added.
 817         (WebCore::FileInputType::storesValueSeparateFromAttribute): Added.
 818         (WebCore::FileInputType::setFileList): Added.
 819         (WebCore::FileInputType::isFileUpload): Added.
 820         * html/FileInputType.h: Ditto.
 821
 822         * html/HTMLInputElement.cpp:
 823         (WebCore::HTMLInputElement::HTMLInputElement): Updated for data member
 824         renaming and removal.
 825         (WebCore::HTMLInputElement::isValidValue): Call canSetStringValue
 826         instead of checking specific type numbers.
 827         (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces):
 828         Use fastGetAttribute and fixed typo in the name of the
 829         scaledStepValueShouldBeInteger function.
 830         (WebCore::HTMLInputElement::isKeyboardFocusable): Call
 831         InputType::isKeyboardFocusable; moved most of the type-specific
 832         logic there.
 833         (WebCore::HTMLInputElement::shouldUseInputMethod): Call
 834         InputType::shouldUseInputMethod; moved the type-specific logic there.
 835         (WebCore::HTMLInputElement::handleBlurEvent): Call
 836         InputType::handleBlurEvent; moved the type-specific logic there.
 837         (WebCore::HTMLInputElement::setType): Tweak the names and types
 838         in this function.
 839         (WebCore::HTMLInputElement::updateType): Removed the code that
 840         set m_deprecatedTypeNumber. Compare types by comparing the value
 841         from formControlType. Removed file-specific logic and instead call
 842         InputType::canChangeFromAnotherType. Streamlined the logic for
 843         activation callbacks.
 844         (WebCore::HTMLInputElement::accessKeyAction): Call
 845         InputType::accessKeyAction; moved the type-specific logic there.
 846         (WebCore::HTMLInputElement::mapToEntry): Call
 847         InputType::shouldRespectHeightAndWidthAttributes and
 848         InputType::shouldRespectAlignAttribute.
 849         (WebCore::HTMLInputElement::parseMappedAttribute): Updated
 850         for name changes and the removal of m_defaultChecked. Changed the
 851         alt attribute logic to be based on the class of the renderer.
 852         Call InputType::srcAttributeChanged and moved the type-specific
 853         logic there. Call shouldRespectAlignAttribute and
 854         shouldRespectHeightAndWidthAttributes rather than having
 855         type-specific logic here. Call minOrMaxAttributeChanged.
 856         (WebCore::HTMLInputElement::rendererIsNeeded): Call
 857         InputType::rendererIsNeeded; moved the type-specific logic there.
 858         (WebCore::HTMLInputElement::attach): Removed the unneeded m_inited
 859         flag, which was redundant with the m_haveType flag. Call
 860         InputType::attach; moved the type-specific logic there.
 861         (WebCore::HTMLInputElement::altText): Use fastGetAttribute.
 862         (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call
 863         InputType::canBeSuccessfulSubmitButton; moved the type-specific
 864         logic there.
 865         (WebCore::HTMLInputElement::isActivatedSubmit): Updated for
 866         name changes.
 867         (WebCore::HTMLInputElement::setActivatedSubmit): Ditto.
 868         (WebCore::HTMLInputElement::reset): Updated to use
 869         InputType::storesValueSeparateFromAttribute. Also use
 870         hasAttribute(checkedAttr) rather than m_defaultChecked,
 871         since both are the same. Also updated for name change.
 872         (WebCore::HTMLInputElement::setChecked): Updated for name
 873         changes. Also added call to
 874         InputType::shouldSendChangeEventAfterCheckedChanged and
 875         moved the type-specific logic there.
 876         (WebCore::HTMLInputElement::setIndeterminate): Call
 877         isCheckable to see if indeterminate is allowed.
 878         Also updated for name changes.
 879         (WebCore::HTMLInputElement::copyNonAttributeProperties):
 880         Updated for name changes and removed data members.
 881         (WebCore::HTMLInputElement::value): Call
 882         InputType::getTypeSpecificValue and InputType::fallbackValue.
 883         Moved the type-specific logic there.
 884         (WebCore::HTMLInputElement::valueWithDefault): Call
 885         InputType::defaultValue. Moved the type-specific logic there.
 886         (WebCore::HTMLInputElement::setSuggestedValue): Call
 887         InputType::canSetSuggestedValue. Moved the type-specific logic
 888         there.
 889         (WebCore::HTMLInputElement::setValue): Call
 890         InputType::canSetValue. Moved the type-specific logic there.
 891         Clear the file list if it exists rather than checking the
 892         type explicitly. We could probably do that a more elegant way.
 893         (WebCore::HTMLInputElement::placeholder): Use fastGetAttribute.
 894         (WebCore::HTMLInputElement::setValueFromRenderer): Use the
 895         isFileUpload function in the assertion.
 896         (WebCore::HTMLInputElement::setFileListFromRenderer): Put most
 897         of the code from this function into FileInputType::setFileList.
 898         (WebCore::HTMLInputElement::preDispatchEventHandler): Changed
 899         to call InputType::willDispatchClick, which does the type-specific
 900         work. Still need to use a single struct for all types, because
 901         the type of the element could change during the event handling.
 902         (WebCore::HTMLInputElement::postDispatchEventHandler): Changed
 903         to call InputType::didDispatchClick.
 904         (WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute.
 905         (WebCore::HTMLInputElement::accept): Use fastGetAttribute.
 906         (WebCore::HTMLInputElement::alt): Use fastGetAttribute.
 907         (WebCore::HTMLInputElement::src): Use fastGetAttribute.
 908         (WebCore::HTMLInputElement::setAutofilled): Updated for name
 909         changes.
 910         (WebCore::HTMLInputElement::files): Use InputType::files.
 911         (WebCore::HTMLInputElement::isAcceptableValue): Use
 912         InputType::isAcceptableValue.
 913         (WebCore::HTMLInputElement::sanitizeValue): Use
 914         InputType::sanitizeValue.
 915         (WebCore::HTMLInputElement::hasUnacceptableValue): Use
 916         InputType::hasUnacceptableValue.
 917         (WebCore::HTMLInputElement::needsActivationCallback): Use
 918         InputType::shouldResetOnDocumentActivation.
 919         (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use
 920         InputType::willMoveToNewOwnerDocument.
 921         (WebCore::HTMLInputElement::dataList): Use
 922         InputType::shouldRespectListAttribute.
 923         (WebCore::HTMLInputElement::selectedOption): Tweaked logic
 924         and naming a bit.
 925         (WebCore::HTMLInputElement::stepUpFromRenderer): Use
 926         fastGetAttribute.
 927         (WebCore::HTMLInputElement::isSpeechEnabled): Use
 928         InputType::shouldRespectSpeechAttribute.
 929         (WebCore::HTMLInputElement::isTextButton): No longer inline.
 930         Calls through to InputType.
 931         (WebCore::HTMLInputElement::isRadioButton): Ditto.
 932         (WebCore::HTMLInputElement::isSearchField): Ditto.
 933         (WebCore::HTMLInputElement::isInputTypeHidden): Ditto.
 934         (WebCore::HTMLInputElement::isPasswordField): Ditto.
 935         (WebCore::HTMLInputElement::isCheckbox): Ditto.
 936         (WebCore::HTMLInputElement::isText): Ditto.
 937         (WebCore::HTMLInputElement::isEmailField): Ditto.
 938         (WebCore::HTMLInputElement::isFileUpload): Ditto.
 939         (WebCore::HTMLInputElement::isImageButton): Ditto.
 940         (WebCore::HTMLInputElement::isNumberField): Ditto.
 941         (WebCore::HTMLInputElement::isSubmitButton): Ditto.
 942         (WebCore::HTMLInputElement::isTelephoneField): Ditto.
 943         (WebCore::HTMLInputElement::isURLField): Ditto.
 944         (WebCore::HTMLInputElement::isEnumeratable): Ditto.
 945         (WebCore::HTMLInputElement::isChecked): No longer inline.
 946         Calls InputType::isCheckable.
 947         (WebCore::HTMLInputElement::hasSpinButton): No longer inline.
 948         Calls through to InputType.
 949         (WebCore::HTMLInputElement::supportsPlaceholder): No longer
 950         inline. Calls isTextType as before, but with no special case
 951         for ISINDEX. That special case was unneeded since it returns
 952         true from isTextType.
 953         (WebCore::HTMLInputElement::checkedRadioButtons): No longer
 954         inline.
 955         (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
 956         No longer inline.
 957
 958         * html/HTMLInputElement.h: Removed multiple unneeded includes.
 959         The big one is probably InputType.h, but also HTMLFormElement.h.
 960         Removed unneeded forward declarations. Made many functions
 961         no longer inline since they now need to make virtual function
 962         dispatches. Removed the unneeded defaultChecked and
 963         webkitdirectory functions. Both are handled by HTML attribute
 964         reflection for DOM bindings, and the callers instead can get
 965         at the attribute. Made updateCheckedRadioButtons public so it
 966         can be called by an InputType class. Removed
 967         DeprecatedInputType, InputTypeMap, createTypeMap,
 968         deprecatedInputType, allowsIndeterminate,
 969         respectHeightAndWidthAttrs, storesValueSeparateFromAttribute,
 970         m_imageLoader, m_fileList, m_deprecatedTypeNumber,
 971         m_defaultChecked, and m_inited. Renamed m_checked to
 972         m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute,
 973         m_indeterminate tom_isIndeterminate, m_haveType to m_hasType,
 974         m_activeSubmit to m_isActivatedSubmit, and m_autofilled to
 975         m_isAutofilled.
 976
 977         * html/HiddenInputType.cpp:
 978         (WebCore::HiddenInputType::accessKeyAction): Added.
 979         (WebCore::HiddenInputType::rendererIsNeeded) Added.:
 980         (WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added.
 981         (WebCore::HiddenInputType::isHiddenType): Added.
 982         (WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added.
 983         * html/HiddenInputType.h: Ditto.
 984
 985         * html/ImageInputType.cpp:
 986         (WebCore::ImageInputType::ImageInputType): Moved out of the header file.
 987         (WebCore::ImageInputType::srcAttributeChanged): Added.
 988         (WebCore::ImageInputType::attach): Added.
 989         (WebCore::ImageInputType::willMoveToNewOwnerDocument): Added.
 990         (WebCore::ImageInputType::shouldRespectAlignAttribute): Added.
 991         (WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added.
 992         (WebCore::ImageInputType::isImageButton): Added.
 993         (WebCore::ImageInputType::isEnumeratable): Added.
 994         (WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added.
 995         * html/ImageInputType.h: Ditto.
 996
 997         * html/InputType.cpp:
 998         (WebCore::InputType::create): Changed argument type to String. There
 999         is no value in taking an AtomicString here.
1000         (WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in
1001         this function name.
1002         (WebCore::InputType::canSetStringValue): Added.
1003         (WebCore::InputType::isKeyboardFocusable): Added.
1004         (WebCore::InputType::shouldUseInputMethod): Added.
1005         (WebCore::InputType::handleBlurEvent): Added.
1006         (WebCore::InputType::accessKeyAction): Added.
1007         (WebCore::InputType::attach): Added.
1008         (WebCore::InputType::srcAttributeChanged): Added.
1009         (WebCore::InputType::willMoveToNewOwnerDocument): Added.
1010         (WebCore::InputType::shouldRespectAlignAttribute): Added.
1011         (WebCore::InputType::canChangeFromAnotherType): Added.
1012         (WebCore::InputType::minOrMaxAttributeChanged): Added.
1013         (WebCore::InputType::canBeSuccessfulSubmitButton): Added.
1014         (WebCore::InputType::rendererIsNeeded): Added.
1015         (WebCore::InputType::files): Added.
1016         (WebCore::InputType::getTypeSpecificValue): Added.
1017         (WebCore::InputType::fallbackValue): Added.
1018         (WebCore::InputType::defaultValue): Added.
1019         (WebCore::InputType::canSetSuggestedValue): Added.
1020         (WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added.
1021         (WebCore::InputType::storesValueSeparateFromAttribute): Added.
1022         (WebCore::InputType::canSetValue): Added.
1023         (WebCore::InputType::willDispatchClick): Added.
1024         (WebCore::InputType::didDispatchClick): Added.
1025         (WebCore::InputType::isAcceptableValue): Added.
1026         (WebCore::InputType::sanitizeValue): Added.
1027         (WebCore::InputType::hasUnacceptableValue): Added.
1028         (WebCore::InputType::setFileList): Added.
1029         (WebCore::InputType::shouldResetOnDocumentActivation): Added.
1030         (WebCore::InputType::shouldRespectListAttribute): Added.
1031         (WebCore::InputType::shouldRespectSpeechAttribute): Added.
1032         (WebCore::InputType::isTextButton): Added.
1033         (WebCore::InputType::isRadioButton): Added.
1034         (WebCore::InputType::isSearchField): Added.
1035         (WebCore::InputType::isHiddenType): Added.
1036         (WebCore::InputType::isPasswordField): Added.
1037         (WebCore::InputType::isCheckbox): Added.
1038         (WebCore::InputType::isEmailField): Added.
1039         (WebCore::InputType::isFileUpload): Added.
1040         (WebCore::InputType::isImageButton): Added.
1041         (WebCore::InputType::isNumberField): Added.
1042         (WebCore::InputType::isSubmitButton): Added.
1043         (WebCore::InputType::isTelephoneField): Added.
1044         (WebCore::InputType::isURLField): Added.
1045         (WebCore::InputType::isEnumeratable): Added.
1046         (WebCore::InputType::isCheckable): Added.
1047         (WebCore::InputType::hasSpinButton): Added.
1048         (WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added.
1049
1050         * html/InputType.h: Removed unneeded ExceptionCode.h include and
1051         used a typedef instead as we do when we want for forward declare it.
1052         Added includes and forward declarations needed for new functions.
1053         Added ClickHandlingState structure. Changed the argument to create
1054         to a String rather than AtomicString. Added many virtual functions.
1055
1056         * html/IsIndexInputType.cpp:
1057         (WebCore::IsIndexInputType::shouldRespectListAttribute): Added.
1058         * html/IsIndexInputType.h: Ditto.
1059
1060         * html/NumberInputType.cpp:
1061         (WebCore::NumberInputType::handleBlurEvent): Added.
1062         (WebCore::NumberInputType::isAcceptableValue): Added.
1063         (WebCore::NumberInputType::sanitizeValue): Added.
1064         (WebCore::NumberInputType::hasUnacceptableValue): Added.
1065         (WebCore::NumberInputType::shouldRespectSpeechAttribute): Added.
1066         (WebCore::NumberInputType::isNumberField): Added.
1067         (WebCore::NumberInputType::hasSpinButton): Added.
1068         * html/NumberInputType.h: Ditto.
1069
1070         * html/PasswordInputType.cpp:
1071         (WebCore::PasswordInputType::shouldUseInputMethod): Added.
1072         (WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added.
1073         (WebCore::PasswordInputType::shouldRespectListAttribute): Added.
1074         (WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added.
1075         (WebCore::PasswordInputType::isPasswordField): Added.
1076         * html/PasswordInputType.h: Ditto.
1077
1078         * html/RadioInputType.cpp:
1079         (WebCore::RadioInputType::isKeyboardFocusable): Added.
1080         (WebCore::RadioInputType::attach): Added.
1081         (WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added.
1082         (WebCore::RadioInputType::willDispatchClick): Added.
1083         (WebCore::RadioInputType::didDispatchClick): Added.
1084         (WebCore::RadioInputType::isRadioButton): Added.
1085         * html/RadioInputType.h: Ditto.
1086
1087         * html/RangeInputType.cpp:
1088         (WebCore::RangeInputType::accessKeyAction): Added.
1089         (WebCore::RangeInputType::minOrMaxAttributeChanged): Added.
1090         (WebCore::RangeInputType::fallbackValue): Added.
1091         (WebCore::RangeInputType::sanitizeValue): Added.
1092         (WebCore::RangeInputType::shouldRespectListAttribute): Added.
1093         * html/RangeInputType.h: Ditto.
1094
1095         * html/ResetInputType.cpp:
1096         (WebCore::ResetInputType::defaultValue): Added.
1097         (WebCore::ResetInputType::isTextButton): Added.
1098         * html/ResetInputType.h: Ditto.
1099
1100         * html/SearchInputType.cpp:
1101         (WebCore::SearchInputType::shouldRespectSpeechAttribute): Added.
1102         (WebCore::SearchInputType::isSearchField): Added.
1103         * html/SearchInputType.h: Ditto.
1104
1105         * html/SubmitInputType.cpp:
1106         (WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added.
1107         (WebCore::SubmitInputType::defaultValue): Added.
1108         (WebCore::SubmitInputType::isSubmitButton): Added.
1109         (WebCore::SubmitInputType::isTextButton): Added.
1110         * html/SubmitInputType.h: Ditto.
1111
1112         * html/TelephoneInputType.cpp:
1113         (WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added.
1114         (WebCore::TelephoneInputType::isTelephoneField): Added.
1115         * html/TelephoneInputType.h: Ditto.
1116
1117         * html/TextFieldInputType.cpp:
1118         (WebCore::TextFieldInputType::shouldUseInputMethod): Added.
1119         (WebCore::TextFieldInputType::sanitizeValue): Added.
1120         (WebCore::TextFieldInputType::shouldRespectListAttribute): Added.
1121         * html/TextFieldInputType.h: Ditto.
1122
1123         * html/TextInputType.cpp:
1124         (WebCore::TextInputType::canSetSuggestedValue): Added.
1125         (WebCore::TextInputType::shouldRespectSpeechAttribute): Added.
1126         * html/TextInputType.h: Ditto.
1127
1128         * html/TimeInputType.cpp:
1129         (WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed
1130         typo in the name of this function.
1131         * html/TimeInputType.h: Ditto.
1132
1133         * html/URLInputType.cpp:
1134         (WebCore::URLInputType::isURLField): Added.
1135         * html/URLInputType.h: Ditto.
1136
1137 2011-01-03  Mihai Parparita  <mihaip@chromium.org>
1138
1139         Unreviewed.
1140
1141         NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
1142         https://bugs.webkit.org/show_bug.cgi?id=51151
1143
1144         Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
1145         so that it can match Safari's (and thus use the same baselines).
1146
1147         No new tests, should be covered by layout tests (which will need
1148         expectation changes)
1149
1150         * platform/chromium/ScrollbarThemeChromiumMac.mm:
1151
1152 2011-01-03  Antonio Gomes  <agomes@rim.com>
1153
1154         Unreviewed build fix for WebKit/Gtk+.
1155
1156         RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be
1157         guarded by ENABLE(VIDEO), as it is in its header.
1158
1159         No new tests.
1160
1161         * platform/gtk/RenderThemeGtk2.cpp:
1162
1163 2011-01-02  Dan Bernstein  <mitz@apple.com>
1164
1165         Rubber-stamped by Simon Fraser.
1166
1167         <rdar://problem/8812159> Update copyright strings
1168
1169         * Info.plist:
1170
1171 2011-01-02  Dan Bernstein  <mitz@apple.com>
1172
1173         Reviewed by Sam Weinig.
1174
1175         <rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field
1176         https://bugs.webkit.org/show_bug.cgi?id=51623
1177
1178         * editing/Editor.cpp:
1179         (WebCore::Editor::countMatchesForText): Actually remember the original search range end
1180         container and offset and restore them when needed, instead of using two references to the
1181         same Range.
1182         * manual-tests/find-count-matches-after-text-control.html: Added.
1183
1184 2011-01-02  Benjamin Poulain  <benjamin.poulain@nokia.com>
1185
1186         Reviewed by Csaba Osztrogonác.
1187
1188         WebKit 2 does not build on 64bits with a recent GCC
1189         https://bugs.webkit.org/show_bug.cgi?id=51754
1190
1191         Use explicitely 64 bits types for the attributes of DatabaseDetails.
1192
1193         * storage/DatabaseDetails.h:
1194         (WebCore::DatabaseDetails::expectedUsage):
1195         (WebCore::DatabaseDetails::currentUsage):
1196
1197 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1198
1199         Unreviewed WinCE build fix for r74868.
1200
1201         * platform/graphics/wince/ImageBufferWinCE.cpp:
1202         (WebCore::getImageData):
1203
1204 2011-01-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1205
1206         Unreviewed, rolling out r74847.
1207         http://trac.webkit.org/changeset/74847
1208         https://bugs.webkit.org/show_bug.cgi?id=51803
1209
1210         "Preprocessor guards should be in header files" (Requested by
1211         ap on #webkit).
1212
1213         * bindings/js/JSDOMWindowBase.cpp:
1214         * dom/Document.cpp:
1215         (WebCore::Document::recalcStyle):
1216         * html/HTMLDocument.cpp:
1217         * loader/FrameLoader.cpp:
1218         * loader/ResourceLoadNotifier.cpp:
1219         * page/Chrome.cpp:
1220         * page/Console.cpp:
1221         * page/ContextMenuController.cpp:
1222         * page/DOMWindow.cpp:
1223         (WebCore::DOMWindow::dispatchEvent):
1224         * page/EventHandler.cpp:
1225         * page/Page.cpp:
1226         * storage/Database.cpp:
1227         * workers/AbstractWorker.cpp:
1228         * workers/DefaultSharedWorkerRepository.cpp:
1229         * workers/SharedWorker.cpp:
1230         * workers/Worker.cpp:
1231         * workers/WorkerContext.cpp:
1232         * workers/WorkerMessagingProxy.cpp:
1233         * xml/XMLHttpRequest.cpp:
1234         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
1235
1236 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1237
1238         [CMake] Unreviewed build fix.
1239
1240         * CMakeLists.txt:
1241
1242 2011-01-02  Dirk Schulze  <krit@webkit.org>
1243
1244         Reviewed by Simon Fraser.
1245
1246         Clarify ImageBuffer and ImageData relationship
1247         https://bugs.webkit.org/show_bug.cgi?id=51297
1248
1249         Remove references to ImageData and CanvasPixelArray from ImageBuffer and SVG filter/masker code,
1250         since this was a layering violation, and replaced it by ByteArray.
1251
1252         No change of functionality, so no new test added.
1253
1254         * html/ImageData.cpp:
1255         (WebCore::ImageData::create):
1256         (WebCore::ImageData::ImageData):
1257         * html/ImageData.h: Added new constructor with ByteArray input.
1258         (WebCore::ImageData::width):
1259         (WebCore::ImageData::height):
1260         (WebCore::ImageData::data):
1261         * html/canvas/CanvasPixelArray.cpp:
1262         (WebCore::CanvasPixelArray::create):
1263         (WebCore::CanvasPixelArray::CanvasPixelArray):
1264         * html/canvas/CanvasPixelArray.h: New conctructor with ByteArray input, used by HTML Canvas.
1265         (WebCore::CanvasPixelArray::data):
1266         (WebCore::CanvasPixelArray::length):
1267         (WebCore::CanvasPixelArray::set):
1268         (WebCore::CanvasPixelArray::get):
1269         * html/canvas/CanvasRenderingContext2D.cpp:
1270         (WebCore::CanvasRenderingContext2D::getImageData):
1271         (WebCore::CanvasRenderingContext2D::putImageData):
1272         * platform/graphics/ImageBuffer.h:
1273         * platform/graphics/cairo/ImageBufferCairo.cpp:
1274         (WebCore::getImageData):
1275         (WebCore::ImageBuffer::getUnmultipliedImageData):
1276         (WebCore::ImageBuffer::getPremultipliedImageData):
1277         (WebCore::putImageData):
1278         (WebCore::ImageBuffer::putUnmultipliedImageData):
1279         (WebCore::ImageBuffer::putPremultipliedImageData):
1280         * platform/graphics/cg/ImageBufferCG.cpp:
1281         (WebCore::getImageData):
1282         (WebCore::ImageBuffer::getUnmultipliedImageData):
1283         (WebCore::ImageBuffer::getPremultipliedImageData):
1284         (WebCore::putImageData):
1285         (WebCore::ImageBuffer::putUnmultipliedImageData):
1286         (WebCore::ImageBuffer::putPremultipliedImageData):
1287         * platform/graphics/filters/FEBlend.cpp:
1288         (WebCore::FEBlend::apply):
1289         * platform/graphics/filters/FEColorMatrix.cpp:
1290         (WebCore::FEColorMatrix::apply):
1291         * platform/graphics/filters/FEComponentTransfer.cpp:
1292         (WebCore::FEComponentTransfer::apply):
1293         * platform/graphics/filters/FEComposite.cpp:
1294         (WebCore::FEComposite::apply):
1295         * platform/graphics/filters/FEConvolveMatrix.cpp:
1296         (WebCore::setDestinationPixels):
1297         (WebCore::FEConvolveMatrix::apply):
1298         * platform/graphics/filters/FEConvolveMatrix.h:
1299         * platform/graphics/filters/FEDisplacementMap.cpp:
1300         (WebCore::FEDisplacementMap::apply):
1301         * platform/graphics/filters/FEGaussianBlur.cpp:
1302         (WebCore::FEGaussianBlur::apply):
1303         * platform/graphics/filters/FELighting.cpp:
1304         (WebCore::FELighting::apply):
1305         * platform/graphics/filters/FEMorphology.cpp:
1306         (WebCore::FEMorphology::apply):
1307         * platform/graphics/filters/FETurbulence.cpp:
1308         (WebCore::FETurbulence::apply):
1309         * platform/graphics/filters/FilterEffect.cpp:
1310         (WebCore::FilterEffect::asImageBuffer):
1311         (WebCore::FilterEffect::asUnmultipliedImage):
1312         (WebCore::FilterEffect::asPremultipliedImage):
1313         (WebCore::FilterEffect::copyImageBytes):
1314         (WebCore::FilterEffect::copyUnmultipliedImage):
1315         (WebCore::FilterEffect::copyPremultipliedImage):
1316         (WebCore::FilterEffect::createUnmultipliedImageResult):
1317         (WebCore::FilterEffect::createPremultipliedImageResult):
1318         * platform/graphics/filters/FilterEffect.h:
1319         * platform/graphics/qt/ImageBufferQt.cpp:
1320         (WebCore::getImageData):
1321         (WebCore::ImageBuffer::getUnmultipliedImageData):
1322         (WebCore::ImageBuffer::getPremultipliedImageData):
1323         (WebCore::putImageData):
1324         (WebCore::ImageBuffer::putUnmultipliedImageData):
1325         (WebCore::ImageBuffer::putPremultipliedImageData):
1326         * platform/graphics/skia/ImageBufferSkia.cpp:
1327         (WebCore::getImageData):
1328         (WebCore::ImageBuffer::getUnmultipliedImageData):
1329         (WebCore::ImageBuffer::getPremultipliedImageData):
1330         (WebCore::putImageData):
1331         (WebCore::ImageBuffer::putUnmultipliedImageData):
1332         (WebCore::ImageBuffer::putPremultipliedImageData):
1333         * platform/graphics/wince/ImageBufferWinCE.cpp:
1334         (WebCore::getImageData):
1335         (WebCore::ImageBuffer::getUnmultipliedImageData):
1336         (WebCore::ImageBuffer::getPremultipliedImageData):
1337         (WebCore::putImageData):
1338         (WebCore::ImageBuffer::putUnmultipliedImageData):
1339         (WebCore::ImageBuffer::putPremultipliedImageData):
1340         * platform/graphics/wx/ImageBufferWx.cpp:
1341         (WebCore::ImageBuffer::getUnmultipliedImageData):
1342         (WebCore::ImageBuffer::getPremultipliedImageData):
1343         (WebCore::ImageBuffer::putUnmultipliedImageData):
1344         (WebCore::ImageBuffer::putPremultipliedImageData):
1345         * rendering/RenderSVGResourceMasker.cpp:
1346         (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
1347
1348 2011-01-01  Adam Barth  <abarth@webkit.org>
1349
1350         Reviewed by Eric Seidel.
1351
1352         Move JavaScriptCore to Source
1353         https://bugs.webkit.org/show_bug.cgi?id=51604
1354
1355         Update references to JavaScriptCore.
1356
1357         * Android.derived.jscbindings.mk:
1358         * Android.v8bindings.mk:
1359         * CMakeLists.txt:
1360         * WebCore.gyp/WebCore.gyp:
1361         * WebCore.pro:
1362           - These changes are subtle and might not be 100% correct.
1363         * move-js-headers.sh:
1364
1365 2011-01-01  Adam Barth  <abarth@webkit.org>
1366
1367         Reviewed by Eric Seidel.
1368
1369         forbid sandboxed frames to call top.close() when allow-same-origin is not setted
1370         https://bugs.webkit.org/show_bug.cgi?id=38340
1371
1372         We now pass the ScriptExecutionContext to window.close so it can find
1373         the Frame and check whether navigation is allowed.  This check will
1374         almost always pass because you can only close top-level frames, but the
1375         check will fail when the calling script is sandboxed.
1376
1377         Tests: fast/frames/sandboxed-iframe-close-top-noclose.html
1378                fast/frames/sandboxed-iframe-close-top.html
1379
1380         * page/DOMWindow.cpp:
1381         (WebCore::DOMWindow::close):
1382         * page/DOMWindow.h:
1383         * page/DOMWindow.idl:
1384
1385 2011-01-01  Adam Barth  <abarth@webkit.org>
1386
1387         Reviewed by Eric Seidel.
1388
1389         sandbox iframes have access to top.history methods
1390         https://bugs.webkit.org/show_bug.cgi?id=38152
1391
1392         To enforce the sandbox restrictions on History, we need to pass the
1393         ScriptExecutionContext to WebCore.  This patch leaves the original
1394         History methods in place because they are used directly by folks who
1395         don't care about security checks.
1396
1397         Test: fast/frames/sandboxed-iframe-history-denied.html
1398
1399         * page/History.cpp:
1400         (WebCore::History::back):
1401         (WebCore::History::forward):
1402         (WebCore::History::go):
1403         * page/History.h:
1404         * page/History.idl:
1405
1406 2011-01-01  Adam Barth  <abarth@webkit.org>
1407
1408         Remove empty file.
1409
1410         * Android.mk:
1411         * CMakeLists.txt:
1412         * GNUmakefile.am:
1413         * WebCore.gypi:
1414         * WebCore.pro:
1415         * WebCore.vcproj/WebCore.vcproj:
1416         * WebCore.xcodeproj/project.pbxproj:
1417         * dom/DOMAllInOne.cpp:
1418         * dom/Entity.cpp: Removed.
1419
1420 2011-01-01  Adam Barth  <abarth@webkit.org>
1421
1422         Remove empty file.
1423
1424         * CMakeLists.txt:
1425         * GNUmakefile.am:
1426         * WebCore.pro:
1427         * WebCore.vcproj/WebCore.vcproj:
1428         * WebCore.xcodeproj/project.pbxproj:
1429         * bindings/js/JSBindingsAllInOne.cpp:
1430         * bindings/js/JSPopStateEventCustom.cpp: Removed.
1431
1432 2011-01-01  Adam Barth  <abarth@webkit.org>
1433
1434         Remove empty files.
1435
1436         * GNUmakefile.am:
1437         * WebCore.gypi:
1438         * WebCore.vcproj/WebCore.vcproj:
1439         * WebCore.xcodeproj/project.pbxproj:
1440         * bindings/generic/BindingFrame.h: Removed.
1441         * bindings/generic/BindingLocation.h: Removed.
1442
1443 2011-01-01  Konstantin Tokarev  <annulen@yandex.ru>
1444
1445         Reviewed by Darin Adler.
1446
1447         Don't include Inspector headers when Inspector is disabled
1448         https://bugs.webkit.org/show_bug.cgi?id=51789
1449
1450         * bindings/js/JSDOMWindowBase.cpp: Include Inspector headers when
1451         Inspector is enabled
1452         * dom/Document.cpp: Include Inspector headers when
1453         Inspector is enabled
1454         (WebCore::Document::recalcStyle): Disabled InspectorInstrumentationCookie
1455         handling
1456         * html/HTMLDocument.cpp: Include Inspector headers when
1457         Inspector is enabled
1458         * loader/FrameLoader.cpp: Include Inspector headers when
1459         Inspector is enabled
1460         * loader/ResourceLoadNotifier.cpp: Include Inspector headers when
1461         Inspector is enabled
1462         * page/Chrome.cpp: Include Inspector headers when
1463         Inspector is enabled
1464         * page/Console.cpp: Include Inspector headers when
1465         Inspector is enabled
1466         * page/ContextMenuController.cpp: Include Inspector headers when
1467         Inspector is enabled
1468         * page/DOMWindow.cpp: Include Inspector headers when
1469         Inspector is enabled
1470         (WebCore::DOMWindow::dispatchEvent): Disabled InspectorInstrumentationCookie
1471         handling
1472         * page/EventHandler.cpp: Include Inspector headers when
1473         Inspector is enabled
1474         * page/Page.cpp: Include Inspector headers when
1475         Inspector is enabled
1476         * storage/Database.cpp: Include Inspector headers when
1477         Inspector is enabled
1478         * workers/AbstractWorker.cpp: Include Inspector headers when
1479         Inspector is enabled
1480         * workers/DefaultSharedWorkerRepository.cpp: Include Inspector headers when
1481         Inspector is enabled
1482         * workers/SharedWorker.cpp: Include Inspector headers when
1483         Inspector is enabled
1484         * workers/Worker.cpp: Include Inspector headers when
1485         Inspector is enabled
1486         * workers/WorkerContext.cpp: Include Inspector headers when
1487         Inspector is enabled
1488         * workers/WorkerMessagingProxy.cpp: Include Inspector headers when
1489         Inspector is enabled
1490         * xml/XMLHttpRequest.cpp: Include Inspector headers when
1491         Inspector is enabled
1492         (WebCore::XMLHttpRequest::callReadyStateChangeListener): Disabled
1493         InspectorInstrumentationCookie handling
1494
1495 2010-12-31  Adam Barth  <abarth@webkit.org>
1496
1497         Reviewed by Darin Adler.
1498
1499         fast/loader/about-blank-hash-change.html fails on Chromium
1500         https://bugs.webkit.org/show_bug.cgi?id=51788
1501
1502         I'm unable to reproduce the failure locally, so this patch is slightly
1503         speculative.  We need to be slighly more careful how we compare the
1504         fragment identifiers for Chromium because Chromium uses a URL parser
1505         that is more agressive about canonicalization.
1506
1507         * page/Location.cpp:
1508         (WebCore::Location::setHash):
1509
1510 2010-12-31  Martin Robinson  <mrobinson@igalia.com>
1511
1512         Reviewed by Xan Lopez.
1513
1514         [GTK] Use GLib/GIO API for FileSystemGtk implementation
1515         https://bugs.webkit.org/show_bug.cgi?id=51617
1516
1517         Complete implementation of FileSystem platform code for GLib. This
1518         converts remaining API points using POSIX calls to platform-independent
1519         GLib calls and fixes other compilation errors.
1520
1521         No new tests. This code will be tested when an implementation
1522         of beginDragWithFiles is complete.
1523
1524         (WebCore::JSDirectoryEntry::getFile):
1525         (WebCore::JSDirectoryEntry::getDirectory):
1526         * platform/FileSystem.h: Added forward declarations for GLib types to
1527         avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
1528         * platform/gtk/FileSystemGtk.cpp:
1529         (WebCore::openTemporaryFile): Reimplement using only GLib calls.
1530         (WebCore::openFile): Ditto.
1531         (WebCore::closeFile): Ditto.
1532         (WebCore::seekFile): Added implementation.
1533         (WebCore::writeToFile): Reimplement using only GLib calls.
1534         (WebCore::readFromFile): Ditto.
1535
1536 2010-12-31  Darin Adler  <darin@apple.com>
1537
1538         Reviewed by Dan Bernstein.
1539
1540         Some renaming and refactoring of form element code
1541         https://bugs.webkit.org/show_bug.cgi?id=51784
1542
1543         * bindings/js/JSHTMLSelectElementCustom.cpp:
1544         (WebCore::JSHTMLSelectElement::remove): Call new overload of remove
1545         for option elements instead of putting the logic in the binding.
1546
1547         * html/HTMLButtonElement.cpp:
1548         (WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes.
1549         (WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to
1550         "event" instead of "evt". Also updated for name changes.
1551         (WebCore::HTMLButtonElement::isActivatedSubmit): Ditto.
1552         (WebCore::HTMLButtonElement::setActivatedSubmit): Ditto.
1553         (WebCore::HTMLButtonElement::appendFormData): Ditto.
1554         * html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit
1555         to match the getter function name. The name still doesn't seem great.
1556
1557         * html/HTMLFormElement.cpp:
1558         (WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes.
1559         (WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function
1560         instead of m_autocomplete data member.
1561         (WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member
1562         instead of otherwise-unused isDemoted function.
1563         (WebCore::HTMLFormElement::submitImplicitly): Updated for name changes.
1564         (WebCore::HTMLFormElement::validateInteractively): Removed code to clear
1565         m_insubmit. This is now handled by the caller, prepareForSubmission.
1566         (WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for
1567         name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission
1568         here from validateInteractively. Removed unneeded check of m_doingsubmit
1569         boolean before setting it.
1570         (WebCore::HTMLFormElement::submit): Factored this function into two.
1571         One for JavaScript and one for non-JavaScript. Neither function needs a frame
1572         argument, because the question being asked, anyPageIsProcessingUserGesture,
1573         is a question asked of an entire page group, not a specific frame or page,
1574         so it's not important which is the active frame.
1575         (WebCore::HTMLFormElement::submitFromJavaScript): Ditto.
1576         (WebCore::HTMLFormElement::reset): Updated for name changes.
1577         (WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse
1578         acceptAttr and got rid of code to set m_autocomplete.
1579         (WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw
1580         pointer.
1581         (WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer
1582         and the vector find function. Added a FIXME about the comment.
1583         (WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete
1584         function instead of m_autocomplete data member.
1585         (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto.
1586         (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
1587         (WebCore::HTMLFormElement::autoComplete): Ditto.
1588         * html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete
1589         function. Renamed prepareSubmit to prepareForSubmission. Got rid of the
1590         frame argument from the submit function and added a new submitFromJavaScript
1591         variant. Removed the unneeded isDemoted function. Changed the return type
1592         of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed
1593         m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to
1594         m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed,
1595         m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
1596
1597         * html/HTMLFormElement.idl: Use the function named submitFromJavaScript
1598         instead of using CallWith=DynamicFrame because we don't need to know
1599         what frame is calling. If we did, it's not clear that the "dynamic"
1600         frame would be the right one anyway.
1601
1602         * html/HTMLSelectElement.cpp:
1603         (WebCore::HTMLSelectElement::remove): Added an overload that takes an option
1604         element, since the JavaScript binding supports this.
1605         * html/HTMLSelectElement.h: Ditto.
1606
1607         * html/ImageInputType.cpp:
1608         (WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
1609         * html/ImageInputType.h: Ditto.
1610         * html/SubmitInputType.cpp:
1611         (WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
1612
1613 2010-12-31  Daniel Bates  <dbates@rim.com>
1614
1615         Reviewed by Darin Adler.
1616
1617         Pass style for <area> instead of associated <img> when querying whether
1618         the theme draws the focus ring for an <area>
1619         https://bugs.webkit.org/show_bug.cgi?id=51632
1620
1621         Fixes an issue where the style for the associated <img> of an <area>
1622         was passed when considering whether the theme should draw a focus ring
1623         for the <area>. Instead, we should pass the theme the style for the <area>.
1624
1625         It's not possible to test this at this time since there are no themes
1626         that override focus ring drawing for <area>s.
1627
1628         * rendering/RenderImage.cpp:
1629         (WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing()
1630         such that it's called with respect to the focused <area>.
1631
1632 2010-12-31  Darin Adler  <darin@apple.com>
1633
1634         * WebCore.xcodeproj/project.pbxproj: Added back the language.
1635         Developers should be using Xcode 3.2.5 or newer.
1636
1637 2010-12-31  Adam Barth  <abarth@webkit.org>
1638
1639         Reviewed by Eric Seidel.
1640
1641         Move V8 to WebCore Location implementation
1642         https://bugs.webkit.org/show_bug.cgi?id=51768
1643
1644         * bindings/generic/BindingFrame.h:
1645         * bindings/generic/BindingLocation.h:
1646         * bindings/v8/V8Binding.h:
1647         * bindings/v8/V8DOMWindowShell.cpp:
1648         (WebCore::V8DOMWindowShell::setLocation):
1649         * bindings/v8/V8Utilities.cpp:
1650         * bindings/v8/V8Utilities.h:
1651         * bindings/v8/custom/V8LocationCustom.cpp:
1652         (WebCore::V8Location::hashAccessorSetter):
1653         (WebCore::V8Location::hostAccessorSetter):
1654         (WebCore::V8Location::hostnameAccessorSetter):
1655         (WebCore::V8Location::hrefAccessorSetter):
1656         (WebCore::V8Location::pathnameAccessorSetter):
1657         (WebCore::V8Location::portAccessorSetter):
1658         (WebCore::V8Location::protocolAccessorSetter):
1659         (WebCore::V8Location::searchAccessorSetter):
1660         (WebCore::V8Location::reloadCallback):
1661         (WebCore::V8Location::replaceCallback):
1662         (WebCore::V8Location::assignCallback):
1663
1664 2010-12-31  Yi Shen  <yi.4.shen@nokia.com>
1665
1666         Reviewed by Eric Seidel.
1667
1668         Make retrieving extraMediaControlsStyleSheet be page dependent.
1669         https://bugs.webkit.org/show_bug.cgi?id=51752
1670
1671         Use themeForPage to retrieve extraMediaControlsStyleSheet for media
1672         controls.
1673
1674         No new tests because no platform-specific theme implementation uses
1675         the passed page pointer yet.
1676
1677         * css/CSSStyleSelector.cpp:
1678         (WebCore::CSSStyleSelector::styleForElement):
1679
1680 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1681
1682         Reviewed by Pavel Feldman.
1683
1684         Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.
1685
1686         https://bugs.webkit.org/show_bug.cgi?id=51709
1687
1688         * inspector/front-end/ResourcesPanel.js:
1689         (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
1690
1691 2010-12-31  Patrick Gansterer  <paroga@webkit.org>
1692
1693         Unreviewed build fix after r74800.
1694
1695         * bindings/js/JSDOMWindowCustom.cpp: Add missing header.
1696         * bindings/js/JSLocationCustom.cpp: Ditto.
1697
1698 2010-12-31  Adam Barth  <abarth@webkit.org>
1699
1700         Rubber-stamped by Eric Seidel.
1701
1702         Move HTML and XML parser benchmarks into PerformanceTests/Parser
1703         https://bugs.webkit.org/show_bug.cgi?id=51772
1704
1705         Remove the benchmarks folder now that it's empty.  Future benchmarks
1706         should go in the PerformanceTests directory.
1707
1708         * benchmarks: Removed.
1709         * benchmarks/parser: Removed.
1710         * benchmarks/parser/html-parser.html: Removed.
1711         * benchmarks/parser/resources: Removed.
1712         * benchmarks/parser/resources/html5.html: Removed.
1713         * benchmarks/parser/resources/runner.js: Removed.
1714         * benchmarks/parser/xml-parser.html: Removed.
1715
1716 2010-12-31  Patrick Gansterer  <paroga@webkit.org>
1717
1718         Reviewed by Adam Barth.
1719
1720         Add XML parser benchmark
1721         https://bugs.webkit.org/show_bug.cgi?id=51612
1722
1723         Move the JavaScript code of html parser into a separate file to share it with xml parser.
1724
1725         * benchmarks/parser/html-parser.html:
1726         * benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html.
1727         (runFunction):
1728         (run):
1729         (start):
1730         * benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
1731
1732 2010-12-29  Zhenyao Mo  <zmo@google.com>
1733
1734         Reviewed by Kenneth Russell.
1735
1736         Update validation of stencil mask and ref values
1737         https://bugs.webkit.org/show_bug.cgi?id=50716
1738
1739         * html/canvas/WebGLRenderingContext.cpp:
1740         (WebCore::WebGLRenderingContext::initializeNewContext): Initialize cached stencil settings.
1741         (WebCore::WebGLRenderingContext::drawArrays): Validate stencil settings.
1742         (WebCore::WebGLRenderingContext::drawElements): Ditto.
1743         (WebCore::WebGLRenderingContext::stencilFunc): Cache stencil settings, but generate no error.
1744         (WebCore::WebGLRenderingContext::stencilFuncSeparate): Ditto.
1745         (WebCore::WebGLRenderingContext::stencilMask): Ditto.
1746         (WebCore::WebGLRenderingContext::stencilMaskSeparate): Ditto.
1747         (WebCore::WebGLRenderingContext::validateStencilSettings): Helper function to validate stencil settings.
1748         * html/canvas/WebGLRenderingContext.h: Declare stencil setting members.
1749
1750 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1751
1752         Reviewed by Xan Lopez.
1753
1754         [GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3
1755         https://bugs.webkit.org/show_bug.cgi?id=51755
1756
1757         Split out pieces of RenderThemeGtk into RenderThemeGtk2 and RenderThemeGtk3
1758         if they are going to differ between GTK+ 2.x and GTK+ 3.x. This is the preliminary
1759         step to landing support for the new GTK+ 3.x theming API.
1760
1761         No new tests. This should not change functionality.
1762
1763         * GNUmakefile.am: Add RenderThemeGtk2 and RenderThemeGtk3 to the sources list.
1764         * platform/gtk/RenderThemeGtk.cpp:
1765         (WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the setTextInputBorders static method.
1766         (WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto.
1767         (WebCore::RenderThemeGtk::paintMediaButton): Ditto.
1768         (WebCore::RenderThemeGtk::adjustProgressBarStyle): ditto.
1769         * platform/gtk/RenderThemeGtk.h: Make setTextInputBorders a method, so that
1770         it can be exist in RenderThemeGtk{2,3} and be called from RenderThemeGtk.
1771         * platform/gtk/RenderThemeGtk2.cpp: Added. A fork of the bits of RenderThemeGtk
1772         that will eventually be platform-dependent.
1773         * platform/gtk/RenderThemeGtk3.cpp: Added. Ditto.
1774
1775 2010-12-30  Justin Schuh  <jschuh@chromium.org>
1776
1777         Reviewed by James Robinson.
1778
1779         Reverting r74292 because it introduced a crash with ruby text.
1780         https://bugs.webkit.org/show_bug.cgi?id=51637
1781
1782         Test: fast/css/counters/counter-ruby-text-cleared.html
1783
1784         * rendering/RenderCounter.cpp:
1785         (WebCore::findPlaceForCounter):
1786         * rendering/RenderObject.cpp:
1787         (WebCore::RenderObject::addChild):
1788         * rendering/RenderObjectChildList.cpp:
1789         (WebCore::RenderObjectChildList::appendChildNode):
1790         (WebCore::RenderObjectChildList::insertChildNode):
1791
1792 2010-12-30  Darin Adler  <darin@apple.com>
1793
1794         Reviewed by David Kilzer.
1795
1796         Remove unused JSBinding source files
1797         https://bugs.webkit.org/show_bug.cgi?id=51762
1798
1799         * bindings/js/JSBinding.h: Removed.
1800         * bindings/js/specialization: Removed.
1801         * bindings/js/specialization/JSBindingState.cpp: Removed.
1802         * bindings/js/specialization/JSBindingState.h: Removed.
1803
1804         * CMakeLists.txt: Removed references to files.
1805         * GNUmakefile.am: Ditto.
1806         * WebCore.gypi: Ditto.
1807         * WebCore.pro: Ditto.
1808         * WebCore.vcproj/WebCore.vcproj: Ditto.
1809         * bindings/js/JSBindingsAllInOne.cpp: Ditto.
1810
1811 2010-12-30  Tony Gentilcore  <tonyg@chromium.org>
1812
1813         Reviewed by Darin Adler.
1814
1815         Remove Document.h include from some headers where it isn't necessary
1816         https://bugs.webkit.org/show_bug.cgi?id=51730
1817
1818         No new tests because no new functionality.
1819
1820         * editing/EditingStyle.cpp:
1821         * editing/EditingStyle.h:
1822         * editing/SelectionController.h:
1823         * editing/visible_units.h:
1824         * html/HTMLAudioElement.h:
1825         * html/HTMLBodyElement.h:
1826         * inspector/InspectorCSSAgent.h:
1827         * inspector/InspectorDOMAgent.h:
1828         * inspector/InspectorInstrumentation.h:
1829         * xml/DOMParser.cpp:
1830         * xml/DOMParser.h:
1831         (WebCore::DOMParser::create):
1832         (WebCore::DOMParser::DOMParser):
1833
1834 2010-12-30  Benjamin C Meyer  <bmeyer@rim.com>
1835
1836         Reviewed by Darin Adler.
1837
1838         bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
1839         which is required when NOTIFICATIONS is enabled.
1840
1841         https://bugs.webkit.org/show_bug.cgi?id=51761
1842
1843         * CMakeLists.txt:
1844
1845 2010-12-30  Antti Koivisto  <antti@apple.com>
1846
1847         Not reviewed.
1848
1849         Revert accidental project file change.
1850
1851         * WebCore.xcodeproj/project.pbxproj:
1852
1853 2010-12-30  Antti Koivisto  <antti@apple.com>
1854
1855         Reviewed by Darin Adler.
1856
1857         https://bugs.webkit.org/show_bug.cgi?id=51134
1858         Move loading related code from MemoryCache to CachedResourceLoader
1859
1860         - Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
1861         - Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
1862         - Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
1863         - Add MemoryCache::add
1864         - Refactor the decision on whether to reload, revalidate or use the existing resource to
1865           a single function, CachedResourceLoader::determineRevalidationPolicy
1866
1867         * css/CSSImageValue.cpp:
1868         (WebCore::CSSImageValue::cachedImage):
1869
1870             Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
1871             if ever taken (since it passes null CachedResourceLoader pointer).
1872
1873         * loader/ImageLoader.cpp:
1874         (WebCore::ImageLoader::updateFromElement):
1875         * loader/cache/CachedImage.cpp:
1876         * loader/cache/CachedResource.cpp:
1877         (WebCore::CachedResource::CachedResource):
1878         (WebCore::CachedResource::~CachedResource):
1879         (WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
1880
1881             Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.
1882
1883         (WebCore::CachedResource::setLoadPriority):
1884
1885             Check for Unresolved value before setting.
1886
1887         * loader/cache/CachedResource.h:
1888         (WebCore::CachedResource::setOwningCachedResourceLoader):
1889
1890             Rename to be bit less mysterious.
1891
1892         * loader/cache/CachedResourceLoader.cpp:
1893         (WebCore::createResource):
1894
1895             This was moved from MemoryCache.
1896
1897         (WebCore::CachedResourceLoader::~CachedResourceLoader):
1898         (WebCore::CachedResourceLoader::determineRevalidationPolicy):
1899         (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
1900
1901             This was moved/merged from MemoryCache.
1902
1903         (WebCore::CachedResourceLoader::canRequest):
1904         (WebCore::CachedResourceLoader::requestResource):
1905
1906             This combines MemoryCache::requestResource and the existing method.
1907
1908         (WebCore::CachedResourceLoader::revalidateResource):
1909
1910             This was moved from MemoryCache.
1911
1912         (WebCore::CachedResourceLoader::loadResource):
1913
1914             New method for initiating loading.
1915
1916         (WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):
1917
1918             Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus
1919
1920         * loader/cache/CachedResourceLoader.h:
1921         * loader/cache/MemoryCache.cpp:
1922         (WebCore::MemoryCache::add):
1923         * loader/cache/MemoryCache.h:
1924         (WebCore::MemoryCache::remove):
1925
1926 2010-12-30  Steve Block  <steveblock@google.com>
1927
1928         Reviewed by Gavin Barraclough.
1929
1930         Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
1931         https://bugs.webkit.org/show_bug.cgi?id=51740
1932
1933         This is a policy decision for Android.
1934
1935         No new tests, simply enabling existing, tested code on Android.
1936
1937         * bindings/js/JSDOMWindowBase.cpp:
1938         (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
1939
1940 2010-12-30  Yael Aharon  <yael.aharon@nokia.com>
1941
1942         Reviewed by Adam Barth.
1943
1944         REGRESSION: fast/dom/cssTarget-crash.html fails
1945         https://bugs.webkit.org/show_bug.cgi?id=20342
1946
1947         Do not reload the page when submitting a form, using "GET" method, and the
1948         form action url matches the location url, except for the fragment.
1949
1950         Test: fast/forms/submit-change-fragment.html
1951
1952         * loader/FrameLoader.cpp:
1953         (WebCore::FrameLoader::loadURL):
1954         (WebCore::FrameLoader::loadWithDocumentLoader):
1955         (WebCore::FrameLoader::shouldScrollToAnchor):
1956         * loader/FrameLoader.h:
1957
1958 2010-12-30  Darin Adler  <darin@apple.com>
1959
1960         Reviewed by Adam Barth.
1961
1962         Move security logic out of the JavaScript binding for location into the DOM class
1963         https://bugs.webkit.org/show_bug.cgi?id=51714
1964
1965         * WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h,
1966         and JSBinding.h. Later, we'll remove them from other project files and delete
1967         the source files.
1968
1969         * bindings/js/JSBinding.h: Emptied out, marked for later deletion.
1970
1971         * bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull
1972         function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL
1973         function, unused toLexicalFrame function, unused completeURL function, unused
1974         getCachedDOMStructure and cacheDOMStructure overloads, and unused
1975         getCachedDOMConstructor and cacheDOMConstruction functions.
1976         (WebCore::activeDOMWindow): Added.
1977         (WebCore::firstDOMWindow): Added.
1978         (WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through
1979         JSBindingState, since the latter is an unneeded abstraction.
1980         (WebCore::processingUserGesture): Changed to call ScriptController's function
1981         rather than calling through JSBindingState, which is an unneeded abstraction
1982
1983         * bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added
1984         activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly
1985         named allowsAccessFromFrame functions, which answer the question of whether
1986         script is allowed access *to* a frame.
1987
1988         * bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes.
1989         (WebCore::JSDOMWindow::setLocation): Streamlined by using the new
1990         activeDOMWindow and firstDOMWindow functions.
1991         (WebCore::JSDOMWindow::open): Ditto.
1992         (WebCore::JSDOMWindow::showModalDialog): Ditto.
1993         (WebCore::JSDOMWindow::postMessage): Ditto.
1994
1995         * bindings/js/JSLocationCustom.cpp:
1996         (WebCore::JSLocation::setHref): Changed to pass the active and first windows through
1997         to the Location::setHref function, with it doing the rest of the work. This moves
1998         work out of the DOM binding that belongs in the DOM itself. Eventually such functions
1999         could even be automatically generated by the bindings script.
2000         (WebCore::JSLocation::setProtocol): Ditto.
2001         (WebCore::JSLocation::setHost): Ditto.
2002         (WebCore::JSLocation::setHostname): Ditto.
2003         (WebCore::JSLocation::setPort): Ditto.
2004         (WebCore::JSLocation::setPathname): Ditto.
2005         (WebCore::JSLocation::setSearch): Ditto.
2006         (WebCore::JSLocation::setHash): Ditto.
2007         (WebCore::JSLocation::replace): Ditto.
2008         (WebCore::JSLocation::reload): Ditto.
2009         (WebCore::JSLocation::assign): Ditto.
2010
2011         * bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
2012         * bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
2013
2014         * page/DOMWindow.cpp:
2015         (WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us
2016         to use this function for Location::replace, which is the same as setLocation except that
2017         it locks both history and the back/forward list.
2018         * page/DOMWindow.h: Ditto.
2019
2020         * page/Location.cpp:
2021         (WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security
2022         logic there does not have to be repeated or even refactored.
2023         (WebCore::Location::setProtocol): Ditto.
2024         (WebCore::Location::setHost): Ditto.
2025         (WebCore::Location::setHostname): Ditto.
2026         (WebCore::Location::setPort): Ditto.
2027         (WebCore::Location::setPathname): Ditto.
2028         (WebCore::Location::setSearch): Ditto.
2029         (WebCore::Location::setHash): Ditto.
2030         (WebCore::Location::assign): Ditto.
2031         (WebCore::Location::replace): Ditto.
2032         (WebCore::Location::reload): Added. Security logic was refactored from the code in
2033         JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems
2034         possibly unneeded.
2035
2036         * page/Location.h: Fixed indentation on the whole file. Added the new functions above.
2037         (WebCore::Location::create):
2038         (WebCore::Location::frame):
2039
2040 2010-12-30  Alexander Pavlov  <apavlov@chromium.org>
2041
2042         Reviewed by Pavel Feldman.
2043
2044         Web Inspector: Pasting a style property with value should automatically split it into prop/value
2045         https://bugs.webkit.org/show_bug.cgi?id=51581
2046
2047         The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
2048         of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
2049         and the edit focus is transferred to the value field.
2050
2051         * inspector/front-end/StylesSidebarPane.js:
2052         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
2053         (WebInspector.StylePropertyTreeElement.prototype):
2054         * inspector/front-end/inspector.js:
2055         (WebInspector.completeURL): Drive-by: return full URLs as-is.
2056         (WebInspector.startEditing.cleanUpAfterEditing):
2057         (WebInspector.startEditing):
2058         (WebInspector.startEditing.pasteEventListener):
2059         (WebInspector.startEditing.keyDownEventListener):
2060
2061 2010-12-30  Pavel Podivilov  <podivilov@chromium.org>
2062
2063         Reviewed by Pavel Feldman.
2064
2065         Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
2066         https://bugs.webkit.org/show_bug.cgi?id=51745
2067
2068         * inspector/front-end/Breakpoint.js:
2069         (WebInspector.Breakpoint.prototype.set enabled):
2070
2071 2010-12-30  Pavel Podivilov  <podivilov@chromium.org>
2072
2073         Reviewed by Pavel Feldman.
2074
2075         Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
2076         https://bugs.webkit.org/show_bug.cgi?id=51748
2077
2078         * inspector/front-end/CallStackSidebarPane.js:
2079         (WebInspector.CallStackSidebarPane.prototype.update):
2080         (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
2081         (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
2082         (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
2083
2084 2010-12-30  Mikhail Naganov  <mnaganov@chromium.org>
2085
2086         Reviewed by Pavel Feldman.
2087
2088         Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).
2089
2090         https://bugs.webkit.org/show_bug.cgi?id=51713
2091
2092         * WebCore.gypi:
2093         * WebCore.pro:
2094         * bindings/v8/custom/V8ConsoleCustom.cpp:
2095         (WebCore::V8Console::memoryAccessorGetter):
2096         * bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp.
2097         (WebCore::V8Performance::memoryAccessorGetter):
2098         * page/Console.idl:
2099         * page/Performance.idl:
2100
2101 2010-12-30  Steve Block  <steveblock@google.com>
2102
2103         Reviewed by Sam Weinig.
2104
2105         Visiting macnn.com often causes SQL spew via geolocation database
2106         https://bugs.webkit.org/show_bug.cgi?id=51557
2107
2108         If the Geolocation position cache database path has not been set, early-out
2109         rather than using an empty path and thus failing to open the database.
2110         This avoids SQL log spew.
2111
2112         Also, avoid starting the database thread until the path has been set, and
2113         shorten the thread name to avoid warnings due to exceeding 30 characters.
2114
2115         No new tests, implementation clean-up only.
2116
2117         * page/GeolocationPositionCache.cpp:
2118         (WebCore::GeolocationPositionCache::addUser):
2119         (WebCore::GeolocationPositionCache::removeUser):
2120         (WebCore::GeolocationPositionCache::setDatabasePath):
2121         (WebCore::GeolocationPositionCache::startBackgroundThread):
2122
2123 2010-12-29  Philippe Normand  <pnormand@igalia.com>
2124
2125         Reviewed by Martin Robinson.
2126
2127         [GTK] minimal build fails at link time due to missing sqlite3 symbols
2128         https://bugs.webkit.org/show_bug.cgi?id=51327
2129
2130         Guard the code calling sqlite3 with the ENABLE(DATABASE) check.
2131
2132         No new tests, build fix only.
2133
2134         * platform/sql/SQLiteAuthorizer.cpp:
2135         * platform/sql/SQLiteDatabase.cpp:
2136         * platform/sql/SQLiteFileSystem.cpp:
2137         * platform/sql/SQLiteStatement.cpp:
2138         * platform/sql/SQLiteTransaction.cpp:
2139
2140 2010-12-30  Justin Schuh  <jschuh@chromium.org>
2141
2142         Reviewed by Dirk Schulze.
2143
2144         Prevent stringToLengthType() from skipping past end-of-string on invalid length unit.
2145         https://bugs.webkit.org/show_bug.cgi?id=51692
2146
2147         * svg/SVGLength.cpp:
2148         (WebCore::stringToLengthType):
2149         (WebCore::SVGLength::setValueAsString):
2150
2151 2010-12-30  Abhishek Arya  <inferno@chromium.org>
2152
2153         Reviewed by Eric Seidel.
2154
2155         Create a helper function for finding descendent video elements for a node.
2156         https://bugs.webkit.org/show_bug.cgi?id=51696
2157
2158         Test: media/video-element-other-namespace-crash.html
2159
2160         * html/MediaDocument.cpp:
2161         (WebCore::descendentVideoElement): helper function.
2162         (WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions.
2163         (WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.
2164
2165 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
2166
2167         Reviewed by Yury Semikhatsky.
2168
2169         Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
2170         https://bugs.webkit.org/show_bug.cgi?id=51707
2171
2172         This change brushes up storage agents + removes redundant InspectorBackend class.
2173
2174         * CMakeLists.txt:
2175         * GNUmakefile.am:
2176         * WebCore.gypi:
2177         * WebCore.pro:
2178         * WebCore.vcproj/WebCore.vcproj:
2179         * WebCore.xcodeproj/project.pbxproj:
2180         * inspector/CodeGeneratorInspector.pm:
2181         * inspector/InjectedScriptHost.cpp:
2182         (WebCore::InjectedScriptHost::databaseForId):
2183         (WebCore::InjectedScriptHost::selectDatabase):
2184         (WebCore::InjectedScriptHost::selectDOMStorage):
2185         (WebCore::InjectedScriptHost::inspectorDOMAgent):
2186         * inspector/Inspector.idl:
2187         * inspector/InspectorBackend.cpp: Removed.
2188         * inspector/InspectorBackend.h: Removed.
2189         * inspector/InspectorController.cpp:
2190         (WebCore::InspectorController::InspectorController):
2191         (WebCore::InspectorController::~InspectorController):
2192         (WebCore::InspectorController::connectFrontend):
2193         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
2194         (WebCore::InspectorController::didUseDOMStorage):
2195         (WebCore::InspectorController::setInjectedScriptSource):
2196         (WebCore::InspectorController::dispatchOnInjectedScript):
2197         (WebCore::InspectorController::releaseWrapperObjectGroup):
2198         * inspector/InspectorController.h:
2199         * inspector/InspectorDOMStorageAgent.cpp: Added.
2200         (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
2201         (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
2202         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
2203         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
2204         (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
2205         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2206         (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
2207         * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
2208         (WebCore::InspectorDOMStorageAgent::create):
2209         (WebCore::InspectorDOMStorageAgent::frontend):
2210         * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
2211         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
2212         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
2213         (WebCore::InspectorDatabaseAgent::executeSQL):
2214         (WebCore::InspectorDatabaseAgent::databaseForId):
2215         (WebCore::InspectorDatabaseAgent::selectDatabase):
2216         (WebCore::InspectorDatabaseAgent::clearFrontend):
2217         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
2218         * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
2219         (WebCore::InspectorDatabaseAgent::create):
2220         (WebCore::InspectorDatabaseAgent::frontend):
2221         * inspector/front-end/ScriptsPanel.js:
2222         (WebInspector.ScriptsPanel.prototype.show):
2223         (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
2224         (WebInspector.ScriptsPanel.prototype._toggleDebugging):
2225
2226 2010-12-29  Dirk Schulze  <krit@webkit.org>
2227
2228         Reviewed by Darin Adler.
2229
2230         Cleanup SVG code according to the webkit style rules 3
2231         https://bugs.webkit.org/show_bug.cgi?id=51490
2232
2233         Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
2234         Just one file can't be fixed for check-webkit-style.
2235         * SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning
2236
2237         No changes of functionality, so no new tests.
2238
2239         * svg/SVGAllInOne.cpp:
2240         * svg/SVGImage.cpp:
2241         * svg/SVGLength.cpp:
2242         (WebCore::SVGLength::setValue):
2243         * svg/SVGPolygonElement.h:
2244         * svg/SVGPolylineElement.h:
2245         * svg/SVGPreserveAspectRatio.cpp:
2246         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
2247         (WebCore::SVGPreserveAspectRatio::transformRect):
2248         * svg/SVGSVGElement.cpp:
2249         (WebCore::SVGSVGElement::viewport):
2250         * svg/SVGSetElement.h:
2251         * svg/SVGStylable.h:
2252         (WebCore::SVGStylable::~SVGStylable):
2253         * svg/SVGStyledLocatableElement.h:
2254         (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
2255         (WebCore::SVGStyledLocatableElement::isStyledLocatable):
2256         * svg/SVGStyledTransformableElement.cpp:
2257         (WebCore::SVGStyledTransformableElement::isKnownAttribute):
2258         * svg/SVGSwitchElement.cpp:
2259         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
2260         * svg/SVGTests.cpp:
2261         (WebCore::SVGTests::parseMappedAttribute):
2262         * svg/SVGTextContentElement.cpp:
2263         (WebCore::SVGTextContentElement::isKnownAttribute):
2264         * svg/SVGTextPathElement.cpp:
2265         * svg/SVGTextPathElement.h:
2266         * svg/SVGTitleElement.h:
2267         (WebCore::SVGTitleElement::rendererIsNeeded):
2268         * svg/SVGTransformDistance.cpp:
2269         (WebCore::SVGTransformDistance::SVGTransformDistance):
2270         (WebCore::SVGTransformDistance::scaledDistance):
2271         (WebCore::SVGTransformDistance::addSVGTransforms):
2272         (WebCore::SVGTransformDistance::addSVGTransform):
2273         (WebCore::SVGTransformDistance::addToSVGTransform):
2274         (WebCore::SVGTransformDistance::isZero):
2275         * svg/SVGTransformList.cpp:
2276         * svg/SVGURIReference.cpp:
2277         (WebCore::SVGURIReference::getTarget):
2278         * svg/SVGVKernElement.h:
2279         * svg/SVGViewSpec.cpp:
2280         (WebCore::SVGViewSpec::parseViewSpec):
2281         * svg/SVGZoomAndPan.h:
2282         (WebCore::SVGZoomAndPan::SVGZoomAndPan):
2283         (WebCore::SVGZoomAndPan::~SVGZoomAndPan):
2284         (WebCore::SVGZoomAndPan::zoomAndPan):
2285         * svg/SVGZoomEvent.h:
2286         (WebCore::SVGZoomEvent::create):
2287         * svg/animation/SMILTime.cpp:
2288         (WebCore::operator*):
2289         * svg/animation/SMILTime.h:
2290         (WebCore::SMILTime::SMILTime):
2291         (WebCore::SMILTime::unresolved):
2292         (WebCore::SMILTime::indefinite):
2293         (WebCore::SMILTime::operator=):
2294         (WebCore::SMILTime::value):
2295         (WebCore::SMILTime::isFinite):
2296         (WebCore::SMILTime::isIndefinite):
2297         (WebCore::SMILTime::isUnresolved):
2298         (WebCore::operator==):
2299         (WebCore::operator!): new operator checks for 0 or infinite values.
2300         (WebCore::operator!=):
2301         (WebCore::operator>):
2302         (WebCore::operator<):
2303         (WebCore::operator>=):
2304         (WebCore::operator<=):
2305         * svg/animation/SMILTimeContainer.h:
2306         (WebCore::SMILTimeContainer::create):
2307         (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
2308         * svg/animation/SVGSMILElement.cpp:
2309         (WebCore::ConditionEventListener::operator==):
2310         (WebCore::SVGSMILElement::repeatingDuration):
2311         (WebCore::SVGSMILElement::resolveInterval):
2312         (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
2313         * svg/animation/SVGSMILElement.h:
2314         (WebCore::SVGSMILElement::timeContainer):
2315         (WebCore::SVGSMILElement::intervalBegin):
2316         (WebCore::SVGSMILElement::intervalEnd):
2317         (WebCore::SVGSMILElement::previousIntervalBegin):
2318         (WebCore::SVGSMILElement::documentOrderIndex):
2319         (WebCore::SVGSMILElement::setDocumentOrderIndex):
2320         * svg/graphics/SVGImage.h:
2321         (WebCore::SVGImage::create):
2322         (WebCore::SVGImage::destroyDecodedData):
2323         (WebCore::SVGImage::decodedSize):
2324         (WebCore::SVGImage::frameAtIndex):
2325         * svg/graphics/filters/SVGFilterBuilder.h:
2326         (WebCore::SVGFilterBuilder::create):
2327         (WebCore::SVGFilterBuilder::lastEffect):
2328         (WebCore::SVGFilterBuilder::getEffectReferences):
2329         (WebCore::SVGFilterBuilder::addBuiltinEffects):
2330
2331 2010-12-29  Abhishek Arya  <inferno@chromium.org>
2332
2333         Reviewed by Darin Adler.
2334
2335         ASSERT(oldchild->parent() == owner) fails.
2336         https://bugs.webkit.org/show_bug.cgi?id=50480
2337
2338         In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
2339         is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
2340         assertion failure when removeChildNode executes on the child(equal to prev or next).
2341         Fix a typo in canMergeContiguousAnonymousBlocks.
2342
2343         Test: fast/multicol/span/double-merge-anonymous-block-crash.html
2344
2345         * rendering/RenderBlock.cpp:
2346         (WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next.
2347         (WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.
2348
2349 2010-12-29  Justin Schuh  <jschuh@chromium.org>
2350
2351         Reviewed by Darin Adler.
2352
2353         Check SVG element type in FrameView::scrollToAnchor
2354         https://bugs.webkit.org/show_bug.cgi?id=51718
2355
2356         Test: svg/custom/scroll-to-anchor-in-symbol.svg
2357
2358         * page/FrameView.cpp:
2359         (WebCore::FrameView::scrollToAnchor):
2360
2361 2010-12-29  Anton Muhin  <antonm@chromium.org>
2362
2363         Reviewed by Eric Seidel.
2364
2365         [v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
2366         https://bugs.webkit.org/show_bug.cgi?id=51704
2367
2368         * bindings/v8/V8DOMWindowShell.cpp:
2369         * bindings/v8/V8DOMWindowShell.h:
2370
2371 2010-12-29  Kenichi Ishibashi  <bashi@google.com>
2372
2373         Reviewed by Darin Adler.
2374
2375         Use a HashMap for m_continuation to save memory
2376         https://bugs.webkit.org/show_bug.cgi?id=43716
2377
2378         Saving memory consumption by applying a HashMap convention to
2379         continuation pointers of RenderInline and RenderBlock classes.
2380
2381         * rendering/RenderBlock.cpp: Removed m_continuation.
2382         (WebCore::RenderBlock::RenderBlock):
2383         (WebCore::RenderBlock::destroy):
2384         (WebCore::RenderBlock::inlineElementContinuation):
2385         (WebCore::RenderBlock::blockElementContinuation):
2386         * rendering/RenderBlock.h: Removed m_continuation.
2387         * rendering/RenderBoxModelObject.cpp: Added a hash map for continuations.
2388         (WebCore::RenderBoxModelObject::destroy): Added an assertion.
2389         (WebCore::RenderBoxModelObject::continuation): Added.
2390         (WebCore::RenderBoxModelObject::setContinuation): Added.
2391         * rendering/RenderBoxModelObject.h:
2392         * rendering/RenderInline.cpp: Removed m_continuation.
2393         (WebCore::RenderInline::RenderInline):
2394         (WebCore::RenderInline::destroy):
2395         (WebCore::RenderInline::inlineElementContinuation):
2396         * rendering/RenderInline.h: Removed m_continuation.
2397
2398 2010-12-27  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2399
2400         Reviewed by Martin Robinson.
2401
2402         [GTK] Enable building whatever already exists of WebKit2
2403         https://bugs.webkit.org/show_bug.cgi?id=37369
2404
2405         No new functionality added or deleted. Only makefile change. Hence, no tests added.
2406
2407         * GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and
2408         added them to WebKit/gtk/GNUmakefile.am
2409         * platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h>
2410         and declare WEBKIT_API directly
2411
2412 2010-12-29  Eric Seidel  <eric@webkit.org>
2413
2414         Unreviewed.
2415
2416         Simplify make-hash-tools.pl
2417         https://bugs.webkit.org/show_bug.cgi?id=49922
2418
2419         Added HashTools.h to the project file now that its not autogenerated.
2420         I also sorted the project file using sort-xcode-project-file
2421
2422         * WebCore.xcodeproj/project.pbxproj:
2423
2424 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
2425
2426         Not reviewed: revert r74755 and 74757.
2427
2428 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2429
2430         Reviewed by Sam Weinig.
2431
2432         JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
2433         https://bugs.webkit.org/show_bug.cgi?id=51722
2434
2435         Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
2436         methods the fastcall calling convention, which leads to runtime errors when they are
2437         called from C++. Also remove a bit of unnecessary code duplication.
2438
2439         No new tests. This is covered by fast/canvas/webgl/data-view-test.html.
2440
2441         * bindings/js/JSDataViewCustom.cpp:
2442         (WebCore::getDataViewMember): Remove duplicated code.
2443         (WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL.
2444         (WebCore::JSDataView::getUint8): Ditto.
2445         (WebCore::JSDataView::getFloat32): Ditto.
2446         (WebCore::JSDataView::getFloat64): Ditto.
2447         (WebCore::setDataViewMember): Remove duplicated code.
2448         (WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL.
2449         (WebCore::JSDataView::setUint8): Ditto.
2450
2451 2010-12-29  Dan Bernstein  <mitz@apple.com>
2452
2453         Reviewed by Kenneth Russel.
2454
2455         A more robust fix for https://bugs.webkit.org/show_bug.cgi?id=51681
2456
2457         * html/HTMLCanvasElement.cpp:
2458         (WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
2459         CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
2460         attach-type style recalc.
2461         * html/HTMLCanvasElement.h:
2462         * html/canvas/CanvasRenderingContext2D.cpp:
2463         (WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
2464         r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
2465         (WebCore::CanvasRenderingContext2D::accessFont): Added a call to
2466         Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
2467         and update the font if it is invalid.
2468         * platform/graphics/Font.h:
2469         (WebCore::Font::loadingCustomFonts): Made this private.
2470
2471 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
2472
2473         Not reviewed: Qt build fix.
2474
2475         * inspector/InspectorController.cpp:
2476
2477 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
2478
2479         Reviewed by Yury Semikhatsky.
2480
2481         Web Inspector: extract Database & DOM Storage
2482         agents; remove InspectorBackend.
2483         https://bugs.webkit.org/show_bug.cgi?id=51707
2484
2485         This change brushes up storage agents + removes redundant
2486         InspectorBackend class.
2487
2488         * CMakeLists.txt:
2489         * GNUmakefile.am:
2490         * WebCore.gypi:
2491         * WebCore.pro:
2492         * WebCore.vcproj/WebCore.vcproj:
2493         * WebCore.xcodeproj/project.pbxproj:
2494         * inspector/CodeGeneratorInspector.pm:
2495         * inspector/InjectedScriptHost.cpp:
2496         (WebCore::InjectedScriptHost::databaseForId):
2497         (WebCore::InjectedScriptHost::selectDatabase):
2498         (WebCore::InjectedScriptHost::selectDOMStorage):
2499         (WebCore::InjectedScriptHost::inspectorDOMAgent):
2500         * inspector/Inspector.idl:
2501         * inspector/InspectorBackend.cpp: Removed.
2502         * inspector/InspectorBackend.h: Removed.
2503         * inspector/InspectorController.cpp:
2504         (WebCore::InspectorController::InspectorController):
2505         (WebCore::InspectorController::~InspectorController):
2506         (WebCore::InspectorController::connectFrontend):
2507         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
2508         (WebCore::InspectorController::didUseDOMStorage):
2509         (WebCore::InspectorController::setInjectedScriptSource):
2510         (WebCore::InspectorController::dispatchOnInjectedScript):
2511         (WebCore::InspectorController::releaseWrapperObjectGroup):
2512         * inspector/InspectorController.h:
2513         * inspector/InspectorDOMStorageAgent.cpp: Added.
2514         (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
2515         (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
2516         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
2517         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
2518         (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
2519         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2520         (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
2521         * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
2522         (WebCore::InspectorDOMStorageAgent::create):
2523         (WebCore::InspectorDOMStorageAgent::frontend):
2524         * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
2525         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
2526         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
2527         (WebCore::InspectorDatabaseAgent::executeSQL):
2528         (WebCore::InspectorDatabaseAgent::databaseForId):
2529         (WebCore::InspectorDatabaseAgent::selectDatabase):
2530         (WebCore::InspectorDatabaseAgent::clearFrontend):
2531         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
2532         * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
2533         (WebCore::InspectorDatabaseAgent::create):
2534         (WebCore::InspectorDatabaseAgent::frontend):
2535         * inspector/InspectorFrontendClientLocal.cpp:
2536         * inspector/InspectorFrontendClientLocal.h:
2537         * inspector/front-end/ScriptsPanel.js:
2538         (WebInspector.ScriptsPanel.prototype.show):
2539
2540 2010-12-29  Tony Gentilcore  <tonyg@chromium.org>
2541
2542         Reviewed by Eric Seidel.
2543
2544         Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
2545         https://bugs.webkit.org/show_bug.cgi?id=51067
2546
2547         Typically when a script element is removed from the document, the cached script
2548         client is removed. However, during the before load event, the cached script client
2549         hasn't been created yet so it can't be removed.
2550
2551         This patch handles that case by explicitly checking if the script element was
2552         removed during the beforeload event. Also, it avoids caching the Document references
2553         over the arbitrary script execution in the before load event.
2554
2555         Test: fast/dom/HTMLScriptElement/move-in-beforeload.html
2556               fast/dom/HTMLScriptElement/remove-in-beforeload.html
2557
2558         * dom/ScriptElement.cpp:
2559         (WebCore::ScriptElement::requestScript):
2560
2561 2010-12-29  Alexander Pavlov  <apavlov@chromium.org>
2562
2563         Reviewed by Yury Semikhatsky.
2564
2565         Web Inspector: Element highlight tooltip displays wrong element size when zoomed in
2566         https://bugs.webkit.org/show_bug.cgi?id=51703
2567
2568         * inspector/InspectorController.cpp:
2569         (WebCore::InspectorController::drawElementTitle):
2570
2571 2010-12-29  Yael Aharon  <yael.aharon@nokia.com>
2572
2573         Reviewed by Kent Tamura.
2574
2575         [HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
2576         https://bugs.webkit.org/show_bug.cgi?id=29071
2577
2578         Use InputType::rangeUnderflow() and InputType::rangeOverflow()
2579         to determine if a control is in-range or out-of-range.
2580
2581         Tests: fast/css/pseudo-in-range-invalid-value.html
2582                fast/css/pseudo-in-range.html
2583                fast/css/pseudo-out-of-range.html
2584
2585         * css/CSSSelector.cpp:
2586         (WebCore::CSSSelector::pseudoId):
2587         (WebCore::nameToPseudoTypeMap):
2588         (WebCore::CSSSelector::extractPseudoType):
2589         * css/CSSSelector.h:
2590         * css/CSSStyleSelector.cpp:
2591         (WebCore::CSSStyleSelector::canShareStyleWithElement):
2592         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
2593         * dom/Element.h:
2594         (WebCore::Element::isInRange):
2595         (WebCore::Element::isOutOfRange):
2596         * html/BaseDateAndTimeInputType.cpp:
2597         (WebCore::BaseDateAndTimeInputType::supportsRangeLimitation):
2598         * html/BaseDateAndTimeInputType.h:
2599         * html/HTMLInputElement.cpp:
2600         (WebCore::HTMLInputElement::isInRange):
2601         (WebCore::HTMLInputElement::isOutOfRange):
2602         * html/HTMLInputElement.h:
2603         * html/InputType.cpp:
2604         (WebCore::InputType::supportsRangeLimitation):
2605         * html/InputType.h:
2606         * html/NumberInputType.cpp:
2607         (WebCore::NumberInputType::supportsRangeLimitation):
2608         * html/NumberInputType.h:
2609         * html/RangeInputType.cpp:
2610         (WebCore::RangeInputType::supportsRangeLimitation):
2611         * html/RangeInputType.h:
2612
2613 2010-12-29  Abhishek Arya  <inferno@chromium.org>
2614
2615         Reviewed by Eric Seidel.
2616
2617         When cloning an anonymous block, make sure to set the childrenInline flag based
2618         on the state of the block to be cloned.
2619         https://bugs.webkit.org/show_bug.cgi?id=51489
2620
2621         Test: fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html
2622
2623         * rendering/RenderBlock.cpp:
2624         (WebCore::RenderBlock::clone): add code to handle cloning of anonymous blocks.
2625         (WebCore::RenderBlock::splitBlocks): remove anonymous block creation calls since it is now handled by clone().
2626
2627 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2628
2629         Unreviewed build fix for WinCE after r73802.
2630
2631         Reapply parts from r72585:
2632         Port ContextMenuWin.cpp to WinCE
2633         https://bugs.webkit.org/show_bug.cgi?id=48408
2634
2635         * CMakeLists.txt:
2636         * platform/ContextMenu.h:
2637         * platform/win/ContextMenuWin.cpp:
2638         (WebCore::ContextMenu::getContextMenuItems):
2639         (WebCore::ContextMenu::createNativeMenuFromItems):
2640
2641 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2642
2643         Reviewed by Simon Hausmann.
2644
2645         [Qt] Fix compilation with Qt in namespace
2646         https://bugs.webkit.org/show_bug.cgi?id=51701
2647
2648         * platform/graphics/ContextShadow.h:
2649         * platform/graphics/GraphicsContext3D.h:
2650         * platform/network/NetworkingContext.h:
2651         * platform/network/qt/QtNAMThreadSafeProxy.h:
2652         * plugins/PluginView.h:
2653
2654 2010-12-28  Alexander Pavlov  <apavlov@chromium.org>
2655
2656         Reviewed by Pavel Feldman.
2657
2658         Web Inspector: A disabled style property should get enabled when edited
2659         https://bugs.webkit.org/show_bug.cgi?id=51679
2660
2661         Test: inspector/styles-disable-then-change.html
2662
2663         * inspector/front-end/CSSStyleModel.js:
2664         (WebInspector.CSSProperty.prototype.setText):
2665         (WebInspector.CSSProperty.prototype.setText.callback):
2666
2667 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2668
2669         Reviewed by Andreas Kling.
2670
2671         [CMake] Remove WebKitGenerators
2672         https://bugs.webkit.org/show_bug.cgi?id=50445
2673
2674         * CMakeLists.txt: Pass preprocessor to generate-bindings.pl.
2675
2676 2010-12-28  Pratik Solanki  <psolanki@apple.com>
2677
2678         Reviewed by Eric Seidel.
2679
2680         https://bugs.webkit.org/show_bug.cgi?id=51522
2681         Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()
2682
2683         * page/win/FrameCGWin.cpp:
2684         (WebCore::imageFromRect):
2685         * platform/graphics/cg/GradientCG.cpp:
2686         (WebCore::Gradient::platformGradient):
2687         * platform/graphics/cg/GraphicsContext3DCG.cpp:
2688         (WebCore::GraphicsContext3D::paintToCanvas):
2689         * platform/graphics/cg/ImageCG.cpp:
2690         (WebCore::BitmapImage::checkForSolidColor):
2691         * platform/graphics/gstreamer/ImageGStreamerCG.mm:
2692         (ImageGStreamer::ImageGStreamer):
2693         * platform/graphics/win/GraphicsContextCGWin.cpp:
2694         (WebCore::CGContextWithHDC):
2695         (WebCore::GraphicsContext::releaseWindowsContext):
2696         (WebCore::GraphicsContext::drawWindowsBitmap):
2697         * platform/graphics/win/ImageCGWin.cpp:
2698         (WebCore::BitmapImage::create):
2699         (WebCore::BitmapImage::getHBITMAPOfSize):
2700         * platform/image-decoders/cg/ImageDecoderCG.cpp:
2701         (WebCore::createColorSpace):
2702         * platform/win/DragImageCGWin.cpp:
2703         (WebCore::allocImage):
2704         (WebCore::createCgContextFromBitmap):
2705         * rendering/RenderThemeMac.mm:
2706         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
2707         (WebCore::RenderThemeMac::paintSliderTrack):
2708         * rendering/RenderThemeSafari.cpp:
2709         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
2710         (WebCore::RenderThemeSafari::paintSliderTrack):
2711
2712 2010-12-28  Daniel Bates  <dbates@rim.com>
2713
2714         Reviewed by Sam Weinig.
2715
2716         Substitute // MARK: for compiler-specific #pragma mark
2717         https://bugs.webkit.org/show_bug.cgi?id=51657
2718
2719         Fix compilation warnings about "#pragma mark" on GTK+ bots by
2720         substituting  "// MARK:" for "#pragma mark", which provides
2721         analogous code-bookmarking functionality under Xcode.
2722
2723         * platform/graphics/cg/PathCG.cpp:
2724         * platform/graphics/mac/WebLayer.mm:
2725
2726 2010-12-28  Jan Erik Hanssen  <jhanssen@sencha.com>
2727
2728         Reviewed by Eric Seidel.
2729
2730         [Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
2731         https://bugs.webkit.org/show_bug.cgi?id=51687
2732
2733         Use a const reference instead of a copy of QPainter::combinedTransform()
2734         in GraphicsContext::getCTM()
2735
2736         * platform/graphics/qt/GraphicsContextQt.cpp:
2737         (WebCore::GraphicsContext::getCTM):
2738
2739 2010-12-28  Takashi Toyoshima  <toyoshim@google.com>
2740
2741         Reviewed by Eric Seidel.
2742
2743         gcc detected 'control reaches end of non-void function' with
2744         -finstrument-functions option.
2745         https://bugs.webkit.org/show_bug.cgi?id=51669
2746
2747         No new tests. These fixes are trivial.
2748
2749         * dom/Element.cpp:
2750         (WebCore::Element::childTypeAllowed):
2751         * inspector/InspectorResourceAgent.cpp:
2752         (WebCore::cachedResourceTypeString):
2753
2754 2010-12-28  Tony Gentilcore  <tonyg@chromium.org>
2755
2756         Reviewed by Eric Seidel.
2757
2758         Remove unused member of PendingScript
2759         https://bugs.webkit.org/show_bug.cgi?id=51684
2760
2761         This was used when HTMLScriptRunner::runScript created a PendingScript
2762         for inline scripts. But now it just calls executeScript() directly.
2763         External scripts always have the minimum starting line number.
2764
2765         No new tests because no changed functionality.
2766
2767         * dom/PendingScript.cpp:
2768         (WebCore::PendingScript::releaseElementAndClear):
2769         * dom/PendingScript.h:
2770         (WebCore::PendingScript::PendingScript):
2771         (WebCore::PendingScript::operator=):
2772         * html/parser/HTMLScriptRunner.cpp:
2773         (WebCore::HTMLScriptRunner::sourceFromPendingScript):
2774
2775 2010-12-20  Antonio Gomes  <agomes@rim.com>
2776
2777         Reviewed by Daniel Bates.
2778
2779         Spatial Navigation: code clean up (Part VI)
2780         https://bugs.webkit.org/show_bug.cgi?id=50666
2781
2782         No new tests needed.
2783
2784         * page/FocusController.cpp:
2785         (WebCore::updatFocusCandidateIfNeeded): Assert renderer() and
2786         isElementNode() now that we are bailing out earlier in both the
2787         FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
2788         * page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection
2789         and virtualRectForAreaElementAndDirection functions.
2790         (WebCore::FocusController::findFocusCandidateInContainer):
2791         (WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted callsites
2792         of canScrollInDirection(), and added an early return if !isElementNode().
2793         (WebCore::FocusController::advanceFocusDirectionally): Adjusted callsite of
2794         virtualRectForAreaElementAndDirection();
2795         * page/SpatialNavigation.cpp:
2796         (WebCore::FocusCandidate::FocusCandidate): Assert if node is not a element node;
2797         (WebCore::isScrollableNode): Renamed from isScrollableContainerNode;
2798         (WebCore::scrollInDirection): Adjusted callsite after function name change;
2799         (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is
2800         a documentNode.
2801         (WebCore::canScrollInDirection): Signature changed.
2802         (WebCore::canBeScrolledIntoView): Ditto.
2803         (WebCore::virtualRectForAreaElementAndDirection): Ditto.
2804
2805 2010-12-28  Adrienne Walker  <enne@google.com>
2806
2807         Reviewed by Kenneth Russell.
2808
2809         [chromium] Fix tiled compositor assertion after GPU process recovery.
2810         https://bugs.webkit.org/show_bug.cgi?id=51682
2811
2812         After the GPU process recovers, the layer size is set to IntSize(),
2813         but IntRect::unite() has a special case for empty rects.  This
2814         behavior was causing the layer size to be too small, causing an
2815         out-of-bounds array access elsewhere.
2816
2817         No new tests.
2818
2819         * platform/graphics/chromium/LayerTilerChromium.cpp:
2820         (WebCore::LayerTilerChromium::growLayerToContain):
2821
2822 2010-12-23  Zhenyao Mo  <zmo@google.com>
2823
2824         Reviewed by Kenneth Russell.
2825
2826         Initialize to 0 for undefined values in CopyTexImage2D
2827         https://bugs.webkit.org/show_bug.cgi?id=51421
2828
2829         * html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer.
2830         (WebCore::WebGLFramebuffer::WebGLFramebuffer):
2831         (WebCore::WebGLFramebuffer::setAttachment):
2832         (WebCore::WebGLFramebuffer::getWidth):
2833         (WebCore::WebGLFramebuffer::getHeight):
2834         (WebCore::WebGLFramebuffer::getColorBufferFormat):
2835         * html/canvas/WebGLFramebuffer.h:
2836         * html/canvas/WebGLRenderingContext.cpp:
2837         (WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0.
2838         (WebCore::WebGLRenderingContext::copyTexSubImage2D):
2839         (WebCore::WebGLRenderingContext::framebufferTexture2D):
2840         (WebCore::WebGLRenderingContext::renderbufferStorage):
2841         (WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
2842         (WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
2843         * html/canvas/WebGLRenderingContext.h:
2844         * html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level.
2845         (WebCore::WebGLTexture::getInternalFormat):
2846         (WebCore::WebGLTexture::getWidth):
2847         (WebCore::WebGLTexture::getHeight):
2848         (WebCore::WebGLTexture::mapTargetToIndex):
2849         (WebCore::WebGLTexture::getLevelInfo):
2850         * html/canvas/WebGLTexture.h:
2851         (WebCore::WebGLTexture::isTexture):
2852         * platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
2853         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
2854         (WebCore::GraphicsContext3D::getInternalFramebufferSize):
2855         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2856         (WebCore::GraphicsContext3D::getInternalFramebufferSize):
2857
2858 2010-12-23  Zhenyao Mo  <zmo@google.com>
2859
2860         Reviewed by Kenneth Russell.
2861
2862         Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
2863         https://bugs.webkit.org/show_bug.cgi?id=39855
2864
2865         * html/canvas/WebGLRenderingContext.cpp:
2866         (WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long.
2867         (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
2868         (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
2869         (WebCore::WebGLRenderingContext::scissor): Ditto.
2870         (WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
2871         (WebCore::WebGLRenderingContext::texImage2D): Ditto.
2872         (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto.
2873         (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
2874         (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
2875         (WebCore::WebGLRenderingContext::viewport): Ditto.
2876         (WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
2877         * html/canvas/WebGLRenderingContext.h:
2878         * html/canvas/WebGLRenderingContext.idl:
2879
2880 2010-12-28  Abhishek Arya  <inferno@chromium.org>
2881
2882         Reviewed by Kenneth Russell.
2883
2884         Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
2885         process of loading.
2886         https://bugs.webkit.org/show_bug.cgi?id=51681
2887
2888         Test: canvas/philip/tests/2d.text-custom-font-load-crash.html
2889
2890         * html/canvas/CanvasRenderingContext2D.cpp:
2891         (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
2892         * platform/graphics/Font.cpp:
2893         (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts()
2894         (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts()
2895         (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
2896         * platform/graphics/Font.h:
2897         (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.
2898
2899 2010-12-28  Dimitri Glazkov  <dglazkov@chromium.org>
2900
2901         Reviewed by Eric Seidel.
2902
2903         Combine setShadowRoot and clearShadowRoot into a simpler API
2904         https://bugs.webkit.org/show_bug.cgi?id=50971
2905
2906         No change in behavior, and API is not used yet.
2907
2908         * dom/Element.cpp:
2909         (WebCore::Element::setShadowRoot): Combined clearing and setting of
2910             the shadowRoot, also hooked up with setting and clearing of the
2911             corresponding shadowHost values.
2912         * dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it
2913             private.
2914         * dom/Node.h: Made shadow host-related functions public so that
2915             Element::setShadowRoot can access setShadowHost. It seems logical
2916             to make shadowHost public as well to keep the defs together.
2917
2918 2010-12-28  Andrey Kosyakov  <caseq@chromium.org>
2919
2920         Reviewed by Pavel Feldman.
2921
2922         Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
2923         Do not request content for resources with non-numeric identifiers.
2924         https://bugs.webkit.org/show_bug.cgi?id=49727
2925
2926         Test: http/tests/inspector/extensions-resources-redirect.html
2927
2928         * inspector/front-end/NetworkManager.js:
2929         (WebInspector.NetworkManager.prototype._appendRedirect):
2930
2931 2010-12-28  Ilya Tikhonovsky  <loislo@chromium.org>
2932
2933         Unreviewed build fix for Qt.
2934
2935         ResourceTreeModel.js was added.
2936
2937         * inspector/front-end/WebKit.qrc:
2938
2939 2010-12-28  Mikhail Naganov  <mnaganov@chromium.org>
2940
2941         Reviewed by Pavel Feldman.
2942
2943         [Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.
2944
2945         https://bugs.webkit.org/show_bug.cgi?id=51680
2946
2947         * inspector/front-end/ProfilesPanel.js:
2948         (WebInspector.ProfilesPanel.prototype._reset):
2949
2950 2010-12-28  Alexander Pavlov  <apavlov@chromium.org>
2951
2952         Reviewed by Pavel Feldman.
2953
2954         Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
2955         https://bugs.webkit.org/show_bug.cgi?id=51663
2956
2957         The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
2958         optional quotes/apostrophes and spaces are now allowed inside uri(...).
2959
2960         Test: inspector/styles-url-linkify.html
2961
2962         * inspector/front-end/StylesSidebarPane.js:
2963         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
2964         (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
2965
2966 2010-12-21  Ilya Tikhonovsky  <loislo@chromium.org>
2967
2968         Reviewed by Pavel Feldman.
2969
2970         Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.
2971
2972         Domain was changed for Resources, FileSystem etc. related methods.
2973         ResourcesManager was renamed to NetworkManager.
2974         ResourceTreeModel was extracted as separate file.
2975         FileSystem, Database, DOMStorage and ApplicationCache methods were
2976         removed from NetworkManager and added to corresponding classes.
2977
2978         https://bugs.webkit.org/show_bug.cgi?id=51334
2979
2980         * WebCore.gypi:
2981         * WebCore.vcproj/WebCore.vcproj:
2982         * inspector/CodeGeneratorInspector.pm:
2983         * inspector/Inspector.idl:
2984         * inspector/front-end/AuditRules.js:
2985         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
2986         * inspector/front-end/CSSStyleModel.js:
2987         (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
2988         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
2989         * inspector/front-end/ConsoleView.js:
2990         (WebInspector.ConsoleView.prototype.addMessage):
2991         (WebInspector.ConsoleView.prototype.clearMessages):
2992         * inspector/front-end/DOMAgent.js:
2993         (WebInspector.ApplicationCache.updateApplicationCacheStatus):
2994         (WebInspector.ApplicationCache.updateNetworkState):
2995         * inspector/front-end/DOMStorage.js:
2996         (WebInspector.DOMStorage.addDOMStorage):
2997         (WebInspector.DOMStorage.selectDOMStorage):
2998         (WebInspector.DOMStorage.updateDOMStorage):
2999         * inspector/front-end/Database.js:
3000         (WebInspector.Database.prototype.executeSql):
3001         (WebInspector.Database.addDatabase):
3002         (WebInspector.Database.selectDatabase):
3003         (WebInspector.Database.sqlTransactionSucceeded):
3004         (WebInspector.Database.sqlTransactionFailed):
3005         * inspector/front-end/FileSystemView.js:
3006         (WebInspector.FileSystem.didGetFileSystemPath):
3007         (WebInspector.FileSystem.didGetFileSystemError):
3008         (WebInspector.FileSystem.didGetFileSystemDisabled):
3009         * inspector/front-end/NetworkItemView.js:
3010         (WebInspector.NetworkItemView):
3011         * inspector/front-end/NetworkManager.js: Added.
3012         (WebInspector.NetworkManager):
3013         (WebInspector.NetworkManager.prototype._createResource):
3014         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
3015         (WebInspector.NetworkManager.prototype.willSendRequest):
3016         (WebInspector.NetworkManager.prototype._updateResourceWithRequest):
3017         (WebInspector.NetworkManager.prototype._appendRedirect):
3018         (WebInspector.NetworkManager.prototype.markResourceAsCached):
3019         (WebInspector.NetworkManager.prototype.didReceiveResponse):
3020         (WebInspector.NetworkManager.prototype._updateResourceWithResponse):
3021         (WebInspector.NetworkManager.prototype.didReceiveContentLength):
3022         (WebInspector.NetworkManager.prototype.didFinishLoading):
3023         (WebInspector.NetworkManager.prototype.didFailLoading):
3024         (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
3025         (WebInspector.NetworkManager.prototype._updateResourceWithCachedResource):
3026         (WebInspector.NetworkManager.prototype.setInitialContent):
3027         (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
3028         (WebInspector.NetworkManager.prototype.frameDetachedFromParent):
3029         (WebInspector.NetworkManager.prototype.didCreateWebSocket):
3030         (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
3031         (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
3032         (WebInspector.NetworkManager.prototype.didCloseWebSocket):
3033         (WebInspector.NetworkManager.prototype._processCachedResources):
3034         (WebInspector.NetworkManager.prototype._addFramesRecursively):
3035         (WebInspector.NetworkManager.requestContent):
3036         * inspector/front-end/NetworkPanel.js:
3037         (WebInspector.NetworkPanel.prototype.refreshResource):
3038         * inspector/front-end/Resource.js:
3039         (WebInspector.Resource.prototype._innerRequestContent):
3040         * inspector/front-end/ResourceManager.js: Removed.
3041         * inspector/front-end/ResourceTreeModel.js: Added.
3042         (WebInspector.ResourceTreeModel):
3043         (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
3044         (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
3045         (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent):
3046         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
3047         (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
3048         (WebInspector.ResourceTreeModel.prototype._clearResources):
3049         (WebInspector.ResourceTreeModel.prototype.forAllResources):
3050         (WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
3051         (WebInspector.ResourceTreeModel.prototype.clearConsoleMessages):
3052         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
3053         (WebInspector.ResourceTreeModel.prototype.resourceForURL):
3054         (WebInspector.ResourceTreeModel.prototype.bindResourceURL):
3055         (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
3056         (WebInspector.ResourceTreeModel.createResource):
3057         * inspector/front-end/ResourceView.js:
3058         (WebInspector.ResourceView.createResourceView):
3059         (WebInspector.ResourceView.resourceViewTypeMatchesResource):
3060         (WebInspector.ResourceView.resourceViewForResource):
3061         (WebInspector.ResourceView.recreateResourceView):
3062         (WebInspector.ResourceView.existingResourceViewForResource):
3063         * inspector/front-end/ResourcesPanel.js:
3064         (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
3065         (WebInspector.ResourcesPanel.prototype.showSourceLine):
3066         (WebInspector.ResourcesPanel.prototype.showResource):
3067         (WebInspector.ResourcesPanel.prototype.get searchableViews.callback):
3068         (WebInspector.ResourcesPanel.prototype.get searchableViews):
3069         (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
3070         (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
3071         * inspector/front-end/ScriptsPanel.js:
3072         (WebInspector.ScriptsPanel.prototype._addScript):
3073         (WebInspector.ScriptsPanel.prototype.reset):
3074         (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
3075         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
3076         * inspector/front-end/WebKit.qrc:
3077         * inspector/front-end/inspector.html:
3078         * inspector/front-end/inspector.js:
3079         (WebInspector.forAllResources):
3080         (WebInspector.resourceForURL):
3081
3082 2010-12-27  Helder Correia  <helder@sencha.com>
3083
3084         Reviewed by Ariya Hidayat.
3085
3086         ContextShadow should use AffineTransform instead of TransformationMatrix
3087         https://bugs.webkit.org/show_bug.cgi?id=51661
3088
3089         ContextShadow needs the CTM to make sure shadows are not affected by
3090         transformations when drawing on a canvas. AffineTransform is sufficient
3091         in this case.
3092
3093         Existing tests: fast/canvas/canvas*shadow*html
3094
3095         * platform/graphics/ContextShadow.cpp:
3096         (WebCore::ContextShadow::mustUseContextShadow):
3097         (WebCore::ContextShadow::adjustBlurDistance):
3098         (WebCore::ContextShadow::calculateLayerBoundingRect):
3099         * platform/graphics/ContextShadow.h:
3100         * platform/graphics/cairo/ContextShadowCairo.cpp:
3101         (WebCore::ContextShadow::getTransformationMatrixFromContext):
3102         * platform/graphics/qt/ContextShadowQt.cpp:
3103         (WebCore::ContextShadow::getTransformationMatrixFromContext):
3104
3105 2010-12-27  Daniel Bates  <dbates@rim.com>
3106
3107         Reviewed by Antonio Gomes.
3108
3109         Clean up: Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
3110         https://bugs.webkit.org/show_bug.cgi?id=51634
3111
3112         Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
3113         to HTMLFrameElementBase::marginWidth() and HTMLFrameElementBase::marginHeight(), respectively.
3114         This will make the names of these getters consistent with the naming convention we use for
3115         getters.
3116
3117         * html/HTMLBodyElement.cpp:
3118         (WebCore::HTMLBodyElement::insertedIntoDocument):
3119         * html/HTMLFrameElementBase.h:
3120         (WebCore::HTMLFrameElementBase::marginWidth): Renamed; Formerly getMarginWidth().
3121         (WebCore::HTMLFrameElementBase::marginHeight): Renamed; Formerly getMarginHeight().
3122         * loader/SubframeLoader.cpp:
3123         (WebCore::SubframeLoader::loadSubframe):
3124         * page/FrameView.cpp:
3125         (WebCore::FrameView::init):
3126         * rendering/RenderEmbeddedObject.cpp:
3127         (WebCore::RenderEmbeddedObject::viewCleared): Also renamed variables marginw and marginh
3128         to marginWidth and marginHeight, respectively. This makes the names of these variables
3129         consistent with the names of similar variables in SubframeLoader::loadSubframe() and FrameView::init().
3130         * rendering/RenderFrame.cpp:
3131         (WebCore::RenderFrame::viewCleared): Ditto.
3132
3133 2010-12-27  Martin Robinson  <mrobinson@igalia.com>
3134
3135         Reviewed by Daniel Bates.
3136
3137         [GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
3138         https://bugs.webkit.org/show_bug.cgi?id=51654
3139
3140         Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
3141         on some debug configurations.
3142
3143         No new tests. This is already covered by current slider tests. It isn't crashing on
3144         the bots, but it does crash locally.
3145
3146         * platform/gtk/RenderThemeGtk.cpp:
3147         (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
3148
3149 2010-12-27  Anton Muhin  <antonm@chromium.org>
3150
3151         Reviewed by David Levin.
3152
3153         [v8] Remove unused methods to protect/unprotect wrappers during garbage collection
3154         https://bugs.webkit.org/show_bug.cgi?id=51648
3155
3156         * bindings/v8/ScriptController.cpp:
3157         * bindings/v8/ScriptController.h:
3158         * bindings/v8/V8GCController.cpp:
3159         (WebCore::V8GCController::gcEpilogue):
3160         * bindings/v8/V8GCController.h:
3161
3162 2010-12-27  Yury Semikhatsky  <yurys@chromium.org>
3163
3164         Unreviewed. Removed trailing spaces from a localized
3165         string to make it the same as the one used in the code.
3166
3167         * English.lproj/localizedStrings.js:
3168
3169 2010-12-27  Yael Aharon  <yael.aharon@nokia.com>
3170
3171         Reviewed by Eric Seidel.
3172
3173         Browser is failing 16 baseline test from Selector API Test Suite
3174         https://bugs.webkit.org/show_bug.cgi?id=42968
3175
3176         Throw an exception if there is no argument to querySelector or
3177         querySelectorAll. This replaces the current behavior of passing the string
3178         "undefined" as the argument.
3179
3180         No new tests, just updating the existing results for
3181         fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.
3182
3183         * dom/Document.idl:
3184         * dom/DocumentFragment.idl:
3185         * dom/Element.idl:
3186
3187 2010-12-26  MORITA Hajime  <morrita@google.com>
3188
3189         Reviewed by Dan Bernstein.
3190
3191         For box-shadow, non-primary shadows should have specified radii.
3192         https://bugs.webkit.org/show_bug.cgi?id=51386
3193
3194         On paintBoxShadow(), the spread value accidentally accumulated accidentally
3195         during the loop, which should be applied individually for radius of each shadow.
3196         This change makes the radii for rects computed for each shadow.
3197
3198         Test: fast/box-shadow/spread-multiple-normal.html
3199
3200         * rendering/RenderBoxModelObject.cpp:
3201         (WebCore::RenderBoxModelObject::paintBoxShadow):
3202
3203 2010-12-26  Patrick Gansterer  <paroga@webkit.org>
3204
3205         Reviewed by Eric Seidel.
3206
3207         Improve output of HTML parser benchmark
3208         https://bugs.webkit.org/show_bug.cgi?id=51611
3209
3210         Calculate and show median, min and max values.
3211
3212         * benchmarks/parser/html-parser.html:
3213
3214 2010-12-26  Abhishek Arya  <inferno@chromium.org>
3215
3216         Reviewed by Simon Fraser.
3217
3218         Remove the bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer.
3219         https://bugs.webkit.org/show_bug.cgi?id=48772
3220
3221         Test: fast/multicol/renderer-positioned-assert-crash.html
3222
3223         * rendering/RenderLayer.cpp:
3224         (WebCore::RenderLayer::paintPaginatedChildLayer):
3225         (WebCore::RenderLayer::hitTestPaginatedChildLayer):
3226
3227 2010-12-25  Peter Rybin  <peter.rybin@gmail.com>
3228
3229         Reviewed by Adam Barth.
3230
3231         Adds currentColumn (and currentLine) to SegmentedString. Switches
3232         HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
3233         needs position for a <script> tag.
3234
3235         SegmentedString should provide column position
3236         https://bugs.webkit.org/show_bug.cgi?id=51311
3237
3238         * html/parser/HTMLDocumentParser.cpp:
3239         (WebCore::HTMLDocumentParser::HTMLDocumentParser):
3240         (WebCore::HTMLDocumentParser::textPosition):
3241         * html/parser/HTMLInputStream.h:
3242         (WebCore::HTMLInputStream::current):
3243         (WebCore::InsertionPointRecord::InsertionPointRecord):
3244         (WebCore::InsertionPointRecord::~InsertionPointRecord):
3245         * html/parser/HTMLTreeBuilder.cpp:
3246         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
3247         (WebCore::HTMLTreeBuilder::processScriptStartTag):
3248         * html/parser/HTMLTreeBuilder.h:
3249         (WebCore::HTMLTreeBuilder::create):
3250         * platform/text/SegmentedString.cpp:
3251         (WebCore::SegmentedString::operator=):
3252         (WebCore::SegmentedString::numberOfCharactersConsumedSlow):
3253         (WebCore::SegmentedString::advanceSlowCase):
3254         (WebCore::SegmentedString::currentLine):
3255         (WebCore::SegmentedString::currentColumn):
3256         (WebCore::SegmentedString::setCurrentPosition):
3257         * platform/text/SegmentedString.h:
3258         (WebCore::SegmentedString::SegmentedString):
3259         (WebCore::SegmentedString::advancePastNewline):
3260         (WebCore::SegmentedString::advance):
3261         (WebCore::SegmentedString::numberOfCharactersConsumed):
3262
3263 2010-12-25  Andreas Kling  <kling@webkit.org>
3264
3265         Reviewed by Kenneth Rohde Christiansen.
3266
3267         GraphicsContext: Don't pass StrokeStyle (enum) as const reference
3268         https://bugs.webkit.org/show_bug.cgi?id=51608
3269
3270         * platform/graphics/GraphicsContext.cpp:
3271         (WebCore::GraphicsContext::setStrokeStyle):
3272         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3273         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
3274         * platform/graphics/GraphicsContext.h:
3275         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3276         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3277         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
3278         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3279         * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
3280         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3281         * platform/graphics/openvg/PainterOpenVG.cpp:
3282         (WebCore::PainterOpenVG::setStrokeStyle):
3283         * platform/graphics/openvg/PainterOpenVG.h:
3284         * platform/graphics/qt/GraphicsContextQt.cpp:
3285         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3286         * platform/graphics/skia/GraphicsContextSkia.cpp:
3287         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3288
3289 2010-12-24  Dan Bernstein  <mitz@apple.com>
3290
3291         Reviewed by Alexey Proskuryakov.
3292
3293         REGRESSION (r74648): XHR layout test failures
3294         https://bugs.webkit.org/show_bug.cgi?id=51603
3295
3296         Reverted r74648.
3297
3298         * WebCore.exp.in:
3299
3300 2010-12-24  Dan Bernstein  <mitz@apple.com>
3301
3302         Try to fix the Qt build after r74648.
3303
3304         * WebCore.gypi:
3305         * WebCore.pro:
3306         * platform/network/qt/CredentialStorageQt.cpp: Added.
3307         (WebCore::CredentialStorage::getFromPersistentStorage):
3308
3309 2010-12-24  Simon Fraser  <simon.fraser@apple.com>
3310
3311         Reviewed by Dan Bernstein.
3312
3313         CSSStyleSelector cleanup
3314         https://bugs.webkit.org/show_bug.cgi?id=51597
3315
3316         Make some methods const. Add assertion to checkOneSelector, with the
3317         intention of later removing the if (!e) check (this is hot code).
3318
3319         * css/CSSStyleSelector.cpp:
3320         (WebCore::CSSStyleSelector::locateCousinList):
3321         (WebCore::CSSStyleSelector::canShareStyleWithElement):
3322         (WebCore::CSSStyleSelector::locateSharedStyle):
3323         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
3324         (WebCore::CSSStyleSelector::mmLength):
3325         (WebCore::CSSStyleSelector::inchLength):
3326         (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
3327         (WebCore::CSSStyleSelector::hasSelectorForAttribute):
3328         * css/CSSStyleSelector.h:
3329         (WebCore::CSSStyleSelector::fontSelector):
3330
3331 2010-12-24  Dan Bernstein  <mitz@apple.com>
3332
3333         Reviewed by Anders Carlsson.
3334
3335         <rdar://problem/8758386> The web process uses its own credential storage
3336         https://bugs.webkit.org/show_bug.cgi?id=51599
3337
3338         * WebCore.exp.in: Export CredentialStorage::getFromPersistentStorage(), Credential::hasPassword(),
3339         and Credential::isEmpty().
3340
3341 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
3342
3343         Reviewed by Darin Adler.
3344
3345         [V8] Rename V8CustomEventListener.{h,cpp} to V8EventListener.{h,cpp}
3346         https://bugs.webkit.org/show_bug.cgi?id=51595
3347
3348         * WebCore.gypi:
3349         * bindings/v8/V8DOMWrapper.cpp:
3350         * bindings/v8/V8EventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.cpp.
3351         (WebCore::V8EventListener::V8EventListener):
3352         (WebCore::V8EventListener::getListenerFunction):
3353         (WebCore::V8EventListener::callListenerFunction):
3354         * bindings/v8/V8EventListener.h: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.h.
3355         (WebCore::V8EventListener::create):
3356         * bindings/v8/V8EventListenerList.h:
3357         * bindings/v8/V8WorkerContextEventListener.h:
3358         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3359         * bindings/v8/custom/V8LocationCustom.cpp:
3360         * bindings/v8/custom/V8NodeCustom.cpp:
3361         * bindings/v8/custom/V8NotificationCenterCustom.cpp:
3362
3363 2010-12-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3364
3365         Reviewed by Xan Lopez.
3366
3367         [GTK] Show current time / total in media player
3368         https://bugs.webkit.org/show_bug.cgi?id=51535
3369
3370         * css/mediaControlsGtk.css:
3371         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
3372         * platform/gtk/RenderThemeGtk.cpp:
3373         (WebCore::RenderThemeGtk::formatMediaControlsCurrentTime):
3374         (WebCore::RenderThemeGtk::paintMediaCurrentTime):
3375         * platform/gtk/RenderThemeGtk.h:
3376
3377 2010-12-24  Jan Erik Hanssen  <jhanssen@sencha.com>
3378
3379         Reviewed by Eric Seidel.
3380
3381         Clean up CSSRuleData in CSSStyleSelector.h
3382         https://bugs.webkit.org/show_bug.cgi?id=27753
3383
3384         Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.
3385
3386         * css/CSSStyleSelector.cpp:
3387         (WebCore::CSSRuleData::CSSRuleData):
3388         (WebCore::CSSRuleData::~CSSRuleData):
3389         (WebCore::CSSRuleData::position):
3390         (WebCore::CSSRuleData::rule):
3391         (WebCore::CSSRuleData::selector):
3392         (WebCore::CSSRuleData::next):
3393         (WebCore::CSSRuleDataList::CSSRuleDataList):
3394         (WebCore::CSSRuleDataList::~CSSRuleDataList):
3395         (WebCore::CSSRuleDataList::first):
3396         (WebCore::CSSRuleDataList::last):
3397         (WebCore::CSSRuleDataList::append):
3398         * css/CSSStyleSelector.h:
3399
3400 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
3401
3402         Unreviewed. Fix compilation on Windows.
3403
3404         * inspector/InspectorStyleSheet.cpp:
3405         (WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
3406         * inspector/InspectorStyleSheet.h:
3407
3408 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
3409
3410         Reviewed by Darin Adler.
3411
3412         inspector/debugger-step-out.html crashing intermittently in the bots
3413         https://bugs.webkit.org/show_bug.cgi?id=50868
3414
3415         Use RefPtr rather instead of raw pointers when keeping references
3416         to refcounted objects.
3417
3418         * inspector/InspectorCSSAgent.cpp:
3419         (WebCore::InspectorCSSAgent::getStylesForNode2):
3420         (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
3421         * inspector/InspectorStyleSheet.cpp:
3422         (WebCore::InspectorStyle::create):
3423         (WebCore::InspectorStyle::InspectorStyle):
3424         (WebCore::InspectorStyle::buildObjectForStyle):
3425         (WebCore::InspectorStyle::setPropertyText):
3426         (WebCore::InspectorStyle::toggleProperty):
3427         (WebCore::InspectorStyle::styleText):
3428         (WebCore::InspectorStyle::populateAllProperties):
3429         (WebCore::InspectorStyle::replacePropertyInStyleText):
3430         (WebCore::InspectorStyleSheet::create):
3431         (WebCore::InspectorStyleSheet::InspectorStyleSheet):
3432         (WebCore::InspectorStyleSheetForInlineStyle::create):
3433         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
3434         (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
3435         * inspector/InspectorStyleSheet.h:
3436         (WebCore::InspectorStyle::cssStyle):
3437         (WebCore::InspectorStyleSheet::pageStyleSheet):
3438
3439 2010-12-24  Justin Schuh  <jschuh@chromium.org>
3440
3441         Reviewed by Nikolas Zimmermann.
3442
3443         SVGElementInstance::m_useElement should be cleared when use element is removed from document
3444         https://bugs.webkit.org/show_bug.cgi?id=51486
3445
3446         Test: svg/custom/use-instanceRoot-with-use-removed.svg
3447
3448         * svg/SVGElementInstance.cpp:
3449         (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
3450         * svg/SVGElementInstance.h:
3451         (WebCore::SVGElementInstance::clearUseElement):
3452         * svg/SVGUseElement.cpp:
3453         (WebCore::SVGUseElement::removedFromDocument):
3454         (WebCore::ShadowTreeUpdateBlocker::if):
3455         (WebCore::SVGUseElement::detachInstance):
3456         (WebCore::SVGUseElement::detach):
3457         * svg/SVGUseElement.h:
3458
3459 2010-12-23  Joseph Pecoraro  <joepeck@webkit.org>
3460
3461         Reviewed by Yury Semikhatsky.
3462
3463         Web Inspector: Missing Localized Strings
3464         https://bugs.webkit.org/show_bug.cgi?id=51542
3465
3466         Added missing strings: "WebSocket",  "Frames", "Text", "Transfer",
3467         "Preserve Log upon Navigation", and "Go to Line".
3468
3469         * English.lproj/localizedStrings.js:
3470
3471 2010-12-24  Alexander Pavlov  <apavlov@chromium.org>
3472
3473         Reviewed by Yury Semikhatsky.
3474
3475         Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
3476         https://bugs.webkit.org/show_bug.cgi?id=51478
3477
3478         Now the element attribute modifications (including "style") are tracked, which results in the
3479         source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
3480         on the "style" attribute modification through the Elements tree. Also, it appears that
3481         a complete "style" attribute removal destroys the inline style declaration
3482         (StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).
3483
3484         Test: inspector/elements-delete-inline-style.html
3485
3486         * inspector/InspectorCSSAgent.cpp:
3487         (WebCore::InspectorCSSAgent::didModifyDOMAttr):
3488         * inspector/InspectorCSSAgent.h:
3489         * inspector/InspectorDOMAgent.cpp:
3490         (WebCore::InspectorDOMAgent::didModifyDOMAttr):
3491         * inspector/InspectorDOMAgent.h:
3492         * inspector/InspectorStyleSheet.cpp:
3493         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
3494         (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
3495         (WebCore::InspectorStyleSheetForInlineStyle::text):
3496         (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
3497         (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
3498         * inspector/InspectorStyleSheet.h:
3499         * inspector/front-end/ElementsTreeOutline.js:
3500         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
3501
3502 2010-12-24  Noel Gordon  <noel.gordon@gmail.com>
3503
3504         Reviewed by Andreas Kling.
3505
3506         [chromium] Fix a style nit in the JPEG encoder
3507         https://bugs.webkit.org/show_bug.cgi?id=51574
3508
3509         * platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.
3510
3511 2010-12-23  Alexander Pavlov  <apavlov@chromium.org>
3512
3513         Reviewed by Maciej Stachowiak.
3514
3515         Web Inspector: CSS shorthand properties expand unnecessarily
3516         https://bugs.webkit.org/show_bug.cgi?id=36304
3517
3518         "border-radius" is a shorthand property that has a "non-standard" format and longhands, see
3519         http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
3520         standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
3521         This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
3522         appropriately when adding implicit longhands, thus they were added as normal properties
3523         found in the CSS (neither implicit, nor longhands). This is now fixed.
3524
3525         * css/CSSParser.cpp:
3526         (WebCore::CSSParser::parseBorderRadius):
3527
3528 2010-12-24  Justin Schuh  <jschuh@chromium.org>
3529
3530         Reviewed by Darin Adler.
3531
3532         setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
3533         https://bugs.webkit.org/show_bug.cgi?id=51576
3534
3535         Disallowed elements may be pruned from the shadow tree, leaving a null
3536         shadowTreeElement. We should check for that before setting attributes.
3537
3538         Test: svg/custom/animate-disallowed-use-element.svg
3539
3540         * svg/SVGAnimationElement.cpp:
3541         (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
3542
3543 2010-12-24  Evan Martin  <evan@chromium.org>
3544
3545         Reviewed by Darin Adler.
3546
3547         TextMetrics::width is an integer, but the member is a float
3548         https://bugs.webkit.org/show_bug.cgi?id=51566
3549
3550         Change the return type to a float.
3551
3552         No tests, fixing a compiler warning.
3553         (I was unable to produce a difference in the values exposed to pages
3554         with a float versus the previous conversion to an integer.)
3555
3556         * html/TextMetrics.h:
3557         (WebCore::TextMetrics::width):
3558
3559 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3560
3561         Reviewed by Kenneth Rohde Christiansen.
3562
3563         [EFL] Add option to enable Touch Events.
3564         https://bugs.webkit.org/show_bug.cgi?id=49125
3565
3566         Add files for EFL to support TOUCH_EVENTS.
3567
3568         * CMakeLists.txt:
3569         * CMakeListsEfl.txt:
3570     &nb