2006-10-12 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2
3         Reviewed by Maciej.
4
5         Update Gdk\Linux build for recent changes, based on Qt code
6
7         * platform/gdk/FrameGdk.cpp:
8         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
9         (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault):
10         (WebCore::FrameGdkClientDefault::setFrame):
11         (WebCore::FrameGdkClientDefault::openURL):
12         (WebCore::FrameGdkClientDefault::submitForm):
13         (WebCore::FrameGdkClientDefault::receivedResponse):
14         (WebCore::FrameGdkClientDefault::receivedData):
15         (WebCore::FrameGdkClientDefault::receivedAllData):
16         (WebCore::FrameGdk::FrameGdk):
17         (WebCore::FrameGdk::openURL):
18         (WebCore::FrameGdk::submitForm):
19         (WebCore::FrameGdk::urlSelected):
20         * platform/gdk/FrameGdk.h:
21         * platform/gdk/TemporaryLinkStubs.cpp:
22         (FrameGdk::createJavaAppletWidget):
23         (FileChooser::create):
24
25 2006-10-12  Dave Hyatt  <hyatt@apple.com>
26
27         Patch to add more clipping retrieval functionality for widgets.
28        
29         Reviewed by mjs
30
31         * page/Frame.h:
32         Remove windowResizerRect.  This is in the wrong place.
33         
34         * page/FrameView.cpp:
35         (WebCore::FrameView::windowClipRect):
36         (WebCore::FrameView::windowClipRectForLayer):
37         Break out windowClipRect into helper functions that can be called separately (to make
38         it easier for scrollbars in overflow sections and list boxes to get to an enclosing
39         layer and get the right clip.
40         
41         * page/FrameView.h:
42         Add the new windowClipRect helper methods.
43         
44         * platform/ScrollBar.h:
45         Add a new interface to ScrollbarClient so that scrollbars can hand back proper
46         clip rects for themselves depending on how they are used.
47         
48         * platform/ScrollView.h:
49         Stub out methods for talking to a double buffer backing store on Win32.
50         
51         * platform/Widget.h:
52         Add the ability to query for invalidation suppression.
53         
54         * rendering/RenderLayer.cpp:
55         (WebCore::RenderLayer::windowClipRect):
56         (WebCore::RenderLayer::paintOverflowControls):
57         (WebCore::RenderLayer::calculateRects):
58         (WebCore::RenderLayer::childrenClipRect):
59         (WebCore::RenderLayer::selfClipRect):
60         * rendering/RenderLayer.h:
61         Enhance layers so that they can return either their foreground or background
62         document clip rects.  Make sure a layer scrollbar can return a proper clip.
63         
64         * rendering/RenderListBox.cpp:
65         (WebCore::RenderListBox::windowClipRect):
66         * rendering/RenderListBox.h:
67         Make sure a list box scrollbar can return a proper clip.
68         
69         * rendering/RenderObject.cpp:
70         (WebCore::RenderObject::enclosingLayer):
71         * rendering/RenderObject.h:
72         Make enclosingLayer const.
73         
74 2006-10-11  Darin Adler  <darin@apple.com>
75
76         Reviewed by John.
77
78         - some changes to prepare for converting more code to C++
79
80         * bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is
81         self-sufficient.
82
83         * bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class.
84         Needed since the class is used in this header (for some work I have not landed yet).
85
86         * loader/mac/LoaderNSURLExtras.h:
87         * loader/mac/WebFormDataStream.h:
88         Added extern "C" so this code can be used from C++.
89
90         * loader/mac/LoaderNSURLExtras.m:
91         * loader/mac/WebDataProtocol.mm:
92         * loader/mac/WebDocumentLoader.mm:
93         * loader/mac/WebFormDataStream.m:
94         * loader/mac/WebLoader.mm:
95         * loader/mac/WebMainResourceLoader.mm:
96         * loader/mac/WebNetscapePlugInStreamLoader.mm:
97         * loader/mac/WebPolicyDecider.mm:
98         * loader/mac/WebSubresourceLoader.mm:
99         Added missing includes of config.h.
100
101 2006-10-11  John Sullivan  <sullivan@apple.com>
102         
103         Darin wrote this code; we tested it; I give it the thumbs up.
104         
105         - fixed regression from svn revision 16982 that was generating the wrong Obj-C classes
106
107         The hash table to look up an element class given a QualifiedName was
108         not working at all.
109
110         * dom/QualifiedName.h:
111         (WebCore::QualifiedName::impl):
112         Added. This new accessor method for impl is needed if we want to use
113         a QualifiedName as a hash table key without doing the kind of specialization
114         we do for String. Maybe later we can do the String thing.
115
116         * bindings/objc/DOM.mm:
117         (WebCore::addElementClass):
118         Use QualifiedName.impl instead of the QualifiedName pointer itself.
119         The QualifiedName pointer is *not* unique so almost nothing would be found
120         in this hash table!
121         (WebCore::elementClass):
122         ditto
123         
124 2006-10-11  Adam Roben  <aroben@apple.com>
125
126         Rubberstamped by Anders.
127
128         Clean up FileChooser::create and Icon::newIconForFile.
129
130         * WebCore.xcodeproj/project.pbxproj:
131         * platform/mac/FileChooserMac.mm:
132         (WebCore::FileChooser::create):
133         * platform/mac/IconMac.mm:
134         (WebCore::Icon::newIconForFile):
135
136 2006-10-11  Oliver Hunt  <oliver@apple.com>
137
138         Reviewed by Adam.
139
140         Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
141         Corrects canvas tag to not throw JS exception when drawing
142         zero sized rects, arcs, etc
143
144         * html/CanvasRenderingContext2D.cpp:
145         (WebCore::CanvasRenderingContext2D::arcTo):
146         (WebCore::CanvasRenderingContext2D::arc):
147         (WebCore::CanvasRenderingContext2D::rect):
148         (WebCore::CanvasRenderingContext2D::clearRect):
149         (WebCore::CanvasRenderingContext2D::fillRect):
150         (WebCore::CanvasRenderingContext2D::strokeRect):
151
152 2006-10-11  Rob Buis  <buis@kde.org>
153
154         Reviewed by Mitz.
155
156         http://bugs.webkit.org/show_bug.cgi?id=11221
157         REGRESSION: iExploder crash due to style="cursor: url()"
158
159         Take better care of empty cursor lists.
160
161         Test: fast/css/invalid-cursor-property-crash.html
162
163         * css/cssparser.cpp:
164         (WebCore::CSSParser::parseValue):
165
166 2006-10-11  Adam Roben  <aroben@apple.com>
167
168         Fixing Windows for real this time.
169
170         * platform/win/TemporaryLinkStubs.cpp:
171         (FileChooser::create):
172
173 2006-10-11  Adam Roben  <aroben@apple.com>
174
175         Fix Windows build.
176
177         * platform/win/TemporaryLinkStubs.cpp:
178         (FileChooser::create):
179
180 2006-10-11  Antti Koivisto  <koivisto@iki.fi>
181
182         Reviewed by Hyatt.
183         
184         http://bugs.webkit.org/show_bug.cgi?id=4377
185         
186         Respect css visibility semantics for layers too
187
188         * rendering/RenderContainer.cpp:
189         (WebCore::RenderContainer::removeChildNode):
190         (WebCore::RenderContainer::appendChildNode):
191         (WebCore::RenderContainer::insertChildNode):
192         * rendering/RenderLayer.cpp:
193         (WebCore::RenderLayer::RenderLayer):
194         (WebCore::RenderLayer::updateLayerPositions):
195         (WebCore::RenderLayer::setHasVisibleContent):
196         (WebCore::RenderLayer::dirtyVisibleContentStatus):
197         (WebCore::RenderLayer::childVisibilityChanged):
198         (WebCore::RenderLayer::dirtyVisibleDescendantStatus):
199         (WebCore::RenderLayer::updateVisibilityStatus):
200         (WebCore::RenderLayer::addChild):
201         (WebCore::RenderLayer::removeChild):
202         (WebCore::RenderLayer::updateZOrderLists):
203         (WebCore::RenderLayer::collectLayers):
204         * rendering/RenderLayer.h:
205         (WebCore::RenderLayer::hasVisibleContent):
206         * rendering/RenderObject.cpp:
207         (WebCore::RenderObject::setStyle):
208
209 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
210
211         Reviewed by Oliver.
212
213         - added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
214
215         * WebCore.xcodeproj/project.pbxproj:
216         * platform/cf/RetainPtr.h: Added.
217         (WTF::):
218         (WTF::RetainPtr::RetainPtr):
219         (WTF::RetainPtr::~RetainPtr):
220         (WTF::RetainPtr::get):
221         (WTF::RetainPtr::operator*):
222         (WTF::RetainPtr::operator->):
223         (WTF::RetainPtr::operator!):
224         (WTF::RetainPtr::operator UnspecifiedBoolType):
225         (WTF::::operator):
226         (WTF::::swap):
227         (WTF::swap):
228         (WTF::operator==):
229         (WTF::operator!=):
230         (WTF::static_pointer_cast):
231         (WTF::const_pointer_cast):
232         (WTF::getPtr):
233         
234         - use it in WidgetMac so it gets tested in at least one place
235         
236         * platform/mac/WidgetMac.mm:
237         (WebCore::Widget::Widget):
238         (WebCore::Widget::~Widget):
239         (WebCore::Widget::setEnabled):
240         (WebCore::Widget::isEnabled):
241         (WebCore::Widget::setCursor):
242         (WebCore::Widget::getView):
243         (WebCore::Widget::setView):
244         (WebCore::Widget::getOuterView):
245
246 2006-10-10  Brady Eidson  <beidson@apple.com>
247
248         Reviewed by Maciej.
249
250         Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge
251
252         * bridge/mac/WebCoreFrameBridge.h:
253         * bridge/mac/WebCoreFrameBridge.mm:
254         (-[WebCoreFrameBridge initMainFrameWithPage:]):
255         (-[WebCoreFrameBridge initSubframeWithOwnerElement:]):
256         (-[WebCoreFrameBridge dealloc]):
257         (-[WebCoreFrameBridge close]):
258         (-[WebCoreFrameBridge setFrameLoaderClient:]):
259         (-[WebCoreFrameBridge frameLoader]):
260         * loader/mac/WebFrameLoader.h:
261         * loader/mac/WebFrameLoader.mm:
262         (-[WebFrameLoader initWithFrameBridge:]):
263         (-[WebFrameLoader setFrameLoaderClient:]):
264
265 2006-10-10  Adam Roben  <aroben@apple.com>
266
267         Reviewed by Oliver.
268
269         Make FileChooser ref-counted.
270
271         * platform/FileChooser.h:
272         * platform/mac/FileChooserMac.mm:
273         (WebCore::FileChooser::create):
274         * rendering/RenderFileUploadControl.cpp:
275         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
276         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
277         * rendering/RenderFileUploadControl.h:
278
279 2006-10-10  Sam Weinig  <sam.weinig@gmail.com>
280
281         Reviewed by Tim H.
282
283         Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
284         Even More auto-generated Objective-C DOM bindings changes
285
286         - Auto-generate DOMSVGPathElement.
287
288         - Auto-generate the internal interfaces even for classes that have
289           custom internal implementations.  Change IDL property from ObjCNoInternal
290           to ObjCCustomInternalImpl to indicate the change.
291
292         - Add SVG classes to DOMNode and DOMEvent internal interfaces.
293
294         - Add isSVGZoomEvent() method to Event class to match other Event subclasses
295           and make DOM binding possible.
296
297         - Assorted cleanups.
298
299         * DerivedSources.make:
300         * WebCore.xcodeproj/project.pbxproj:
301         * bindings/objc/DOM.mm:
302         (WebCore::addElementClass):
303         (WebCore::createElementClassMap):
304         (WebCore::elementClass):
305         (-[DOMNode description]):
306         (+[DOMNode _nodeWith:WebCore::]):
307         (-[DOMNode addEventListener:listener:useCapture:]):
308         (-[DOMNode removeEventListener:listener:useCapture:]):
309         (-[DOMElement _NPObject]):
310         (WebCore::ObjCEventListener::handleEvent):
311         * bindings/objc/DOMEvents.mm:
312         (+[DOMEvent _eventWith:WebCore::]):
313         * bindings/objc/DOMInternal.h:
314         * bindings/objc/DOMRGBColor.mm:
315         (-[DOMRGBColor WebCore::]):
316         * bindings/objc/DOMSVGPathSegInternal.h: Removed.
317         * bindings/scripts/CodeGeneratorObjC.pm:
318         * css/CSSRule.idl:
319         * css/CSSValue.idl:
320         * css/StyleSheet.idl:
321         * dom/Event.cpp:
322         (WebCore::Event::isSVGZoomEvent):
323         * dom/Event.h:
324         * dom/Event.idl:
325         * dom/Node.idl:
326         * ksvg2/events/SVGZoomEvent.cpp:
327         (WebCore::SVGZoomEvent::isSVGZoomEvent):
328         * ksvg2/events/SVGZoomEvent.h:
329         * ksvg2/svg/SVGAnimatedAngle.idl:
330         * ksvg2/svg/SVGCircleElement.idl:
331         * ksvg2/svg/SVGClipPathElement.idl:
332         * ksvg2/svg/SVGPathElement.idl:
333         * ksvg2/svg/SVGPathSeg.idl:
334
335 2006-10-10  Oliver Hunt  <oliver@apple.com>
336
337         rubber stamped by Anders.
338
339         More buildbot bustage
340
341         * kcanvas/SVGInlineFlowBox.cpp:
342         (WebCore::placeBoxesVerticallyWithAbsBaseline):
343
344 2006-10-10  Oliver Hunt  <oliver@apple.com>
345
346         Reviewed by Anders 
347
348         Unbreak build bots
349
350         * dom/Text.cpp:
351         * kcanvas/RenderSVGText.cpp:
352         (WebCore::RenderSVGText::layout):
353         * kcanvas/SVGInlineFlowBox.cpp:
354         (WebCore::placePositionedBoxesHorizontally):
355         (WebCore::placeBoxesVerticallyWithAbsBaseline):
356
357 2006-10-10  Oliver Hunt  <oliver@apple.com>
358
359         Reviewed by hyatt.
360
361         Fixes bugs #6423, #6559, #10380 and #10839 
362
363         * WebCore.xcodeproj/project.pbxproj:
364         * css/svg.css:
365         * dom/Text.cpp:
366         (WebCore::Text::createRenderer):
367         * kcanvas/RenderSVGInline.cpp: Added.
368         (WebCore::RenderSVGInline::RenderSVGInline):
369         (WebCore::RenderSVGInline::createInlineBox):
370         * kcanvas/RenderSVGInline.h: Added.
371         (WebCore::RenderSVGInline::renderName):
372         (WebCore::RenderSVGInline::requiresLayer):
373         * kcanvas/RenderSVGInlineText.cpp: Added.
374         (WebCore::RenderSVGInlineText::RenderSVGInlineText):
375         (WebCore::RenderSVGInlineText::absoluteRects):
376         (WebCore::RenderSVGInlineText::selectionRect):
377         * kcanvas/RenderSVGInlineText.h: Added.
378         (WebCore::RenderSVGInlineText::renderName):
379         (WebCore::RenderSVGInlineText::requiresLayer):
380         * kcanvas/RenderSVGTSpan.cpp: Added.
381         (WebCore::RenderSVGTSpan::RenderSVGTSpan):
382         (WebCore::RenderSVGTSpan::absoluteRects):
383         * kcanvas/RenderSVGTSpan.h: Added.
384         (WebCore::RenderSVGTSpan::renderName):
385         * kcanvas/RenderSVGText.cpp:
386         (WebCore::RenderSVGText::RenderSVGText):
387         (WebCore::RenderSVGText::computeAbsoluteRepaintRect):
388         (WebCore::RenderSVGText::layout):
389         (WebCore::RenderSVGText::createInlineBox):
390         (WebCore::RenderSVGText::nodeAtPoint):
391         (WebCore::RenderSVGText::absoluteRects):
392         (WebCore::RenderSVGText::paint):
393         (WebCore::RenderSVGText::relativeBBox):
394         * kcanvas/RenderSVGText.h:
395         (WebCore::RenderSVGText::renderName):
396         * kcanvas/SVGInlineFlowBox.cpp: Added.
397         (WebCore::SVGInlineFlowBox::paint):
398         (WebCore::SVGInlineFlowBox::placeBoxesHorizontally):
399         (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
400         (WebCore::paintSVGInlineFlow):
401         (WebCore::translateBox):
402         (WebCore::placePositionedBoxesHorizontally):
403         (WebCore::placeSVGFlowHorizontally):
404         (WebCore::placeBoxesVerticallyWithAbsBaseline):
405         (WebCore::placeSVGFlowVertically):
406         * kcanvas/SVGInlineFlowBox.h: Added.
407         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
408         * kcanvas/SVGRootInlineBox.cpp: Added.
409         (WebCore::SVGRootInlineBox::paint):
410         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
411         (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
412         * kcanvas/SVGRootInlineBox.h: Added.
413         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
414         * ksvg2/svg/SVGTRefElement.cpp:
415         (SVGTRefElement::createRenderer):
416         * ksvg2/svg/SVGTSpanElement.cpp:
417         (SVGTSpanElement::createRenderer):
418         * rendering/InlineFlowBox.h:
419
420 2006-10-10  Adam Roben  <aroben@apple.com>
421
422         Reviewed by Adele.
423
424         Improve popup menu behavior.
425
426         * html/HTMLSelectElement.cpp:
427         (WebCore::HTMLSelectElement::HTMLSelectElement): Cache
428         m_lastOnChangeIndex so we know when to fire onChange.
429         (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to
430         specify whether we should fire onChange.
431         (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur.
432         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire
433         onChange when using the Enter key to change the selection.
434         * html/HTMLSelectElement.h:
435         * rendering/RenderMenuList.cpp:
436         (WebCore::RenderMenuList::updateFromElement): Extract setText logic
437         into its own method.
438         (WebCore::RenderMenuList::setTextFromOption): New method.
439         (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call
440         onChange instead of calling it directly here.
441         * rendering/RenderMenuList.h:
442
443 2006-10-10  Adele Peterson  <adele@apple.com>
444
445         Reviewed by Beth. 
446
447
448         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text>
449           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
450
451         Moved autoscroll code to the Frame class
452
453         * bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
454         * bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags.  Moved autoscroll code to Frame::handleMouseMoveEvent.
455         (WebCore::FrameMac::FrameMac):
456         (WebCore::FrameMac::handleMousePressEvent):
457         (WebCore::FrameMac::eventMayStartDrag):
458         (WebCore::FrameMac::handleMouseMoveEvent):
459         (WebCore::FrameMac::mouseDown):
460
461         * bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us.
462         Now we scroll our views in WebCore.
463
464         * page/Frame.cpp:
465         (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag.
466         (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate.  Moved from FrameMac.
467         (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too.
468         (WebCore::Frame::mouseDownMayStartAutoscroll): Added.
469         (WebCore::Frame::setMouseDownMayStartAutoscroll): Added.
470         (WebCore::Frame::mouseDownMayStartDrag): Added.
471         (WebCore::Frame::setMouseDownMayStartDrag): Added.
472         (WebCore::Frame::autoscrollRenderer): Added
473         (WebCore::Frame::setAutoscrollRenderer): Added.
474         (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter.
475         (WebCore::Frame::autoscrollTimerFired): ditto.
476         (WebCore::Frame::stopAutoscrollTimer): ditto. 
477         * page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.
478
479         * page/FramePrivate.h:
480         (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags.  Moved from FrameMac.
481
482         * page/FrameView.cpp: Store the current mouse position in window coordinates.  The callers can convert to their own coordinate space.
483         (WebCore::FrameView::handleMousePressEvent):
484         (WebCore::FrameView::handleMouseDoubleClickEvent):
485         (WebCore::FrameView::handleMouseMoveEvent):
486         (WebCore::FrameView::handleMouseReleaseEvent):
487
488         * rendering/RenderLayer.cpp:
489         (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection).  
490          We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.
491
492         * rendering/RenderListBox.cpp:
493         (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.
494
495         * rendering/RenderObject.cpp:
496         (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too)
497         (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.
498
499 2006-10-10  Darin Adler  <darin@apple.com>
500
501         Rubber stamped by Maciej.
502
503         - convert many of the loader source files to Objective-C++ to prepare
504           to convert some of them to C++
505
506         * WebCore.xcodeproj/project.pbxproj:
507         * loader/mac/WebDataProtocol.m: Removed.
508         * loader/mac/WebDocumentLoader.m: Removed.
509         * loader/mac/WebFormState.m: Removed.
510         * loader/mac/WebFrameLoader.m: Removed.
511         * loader/mac/WebLoader.m: Removed.
512         * loader/mac/WebMainResourceLoader.m: Removed.
513         * loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
514         * loader/mac/WebPolicyDecider.m: Removed.
515         * loader/mac/WebSubresourceLoader.m: Removed.
516         * loader/mac/WebDataProtocol.mm: Added.
517         * loader/mac/WebDocumentLoader.mm: Added.
518         * loader/mac/WebFormState.mm: Added.
519         * loader/mac/WebFrameLoader.mm: Added.
520         * loader/mac/WebLoader.mm: Added.
521         * loader/mac/WebMainResourceLoader.mm: Added.
522         * loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
523         * loader/mac/WebPolicyDecider.mm: Added.
524         * loader/mac/WebSubresourceLoader.mm: Added.
525
526 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
527
528         Reviewed by Mitz.
529
530         - fixed REGRESSION (r16960): crash on navigating to site
531         http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE
532         
533         * loader/mac/WebFrameLoader.m:
534         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
535         Add back a mistakenly removed retain.
536
537 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
538
539         Not reviewed, build fix.
540
541         - fixed release build
542
543         * WebCore.xcodeproj/project.pbxproj:
544
545 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
546
547         Rubber stamped by Eric.
548
549         - moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile
550
551         * WebCore.exp:
552         * WebCore.xcodeproj/project.pbxproj:
553         * loader/mac/LoaderNSURLExtras.m: Added.
554         * loader/mac/WebDataProtocol.m: Added.
555         * loader/mac/WebDocumentLoader.m: Added.
556         * loader/mac/WebFormDataStream.m: Added.
557         * loader/mac/WebFrameLoader.m: Added.
558         * loader/mac/WebLoader.m: Added.
559         (-[NSURLProtocol didReceiveResponse:]):
560         (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
561         * loader/mac/WebMainResourceLoader.m: Added.
562         (-[WebMainResourceLoader didReceiveResponse:]):
563         * loader/mac/WebPolicyDecider.m: Added.
564         * loader/mac/WebSubresourceLoader.h: Added.
565         * loader/mac/WebSubresourceLoader.m: Added.
566
567 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
568
569         Reviewed by Oliver (sort of?)
570
571         - WebCore part of moving down NSURL extras
572
573         * WebCore.exp:
574         * platform/mac/WebCoreSystemInterface.h:
575         * platform/mac/WebCoreSystemInterface.mm:
576
577 2006-10-09  Rob Buis  <buis@kde.org>
578
579         Reviewed by Mitz.
580
581         http://bugs.webkit.org/show_bug.cgi?id=11217
582         Cleanup svg coding style
583
584         Cleanup coding style in svg animation classes.
585
586         * ksvg2/svg/SVGAnimateColorElement.cpp:
587         (WebCore::SVGAnimateColorElement::handleTimerEvent):
588         * ksvg2/svg/SVGAnimateElement.cpp:
589         (WebCore::SVGAnimateElement::SVGAnimateElement):
590         (WebCore::SVGAnimateElement::handleTimerEvent):
591         * ksvg2/svg/SVGAnimateTransformElement.cpp:
592         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
593         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
594         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
595         (WebCore::SVGAnimateTransformElement::parseTransformValue):
596         (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):
597         (WebCore::SVGAnimateTransformElement::initialMatrix):
598         (WebCore::SVGAnimateTransformElement::transformMatrix):
599         * ksvg2/svg/SVGAnimateTransformElement.h:
600         * ksvg2/svg/SVGAnimatedPathData.cpp:
601         * ksvg2/svg/SVGAnimatedPathData.h:
602         * ksvg2/svg/SVGAnimatedPoints.cpp:
603         * ksvg2/svg/SVGAnimatedPoints.h:
604         * ksvg2/svg/SVGAnimationElement.cpp:
605         (WebCore::SVGAnimationElement::targetElement):
606
607 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
608
609         Reviewed by Oliver.
610
611         - added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion
612
613         * bridge/mac/WebCoreFrameBridge.h:
614         * bridge/mac/WebCoreFrameBridge.mm:
615         (-[WebCoreFrameBridge isMainFrame]):
616
617 2006-10-09  Adam Roben  <aroben@apple.com>
618
619         Backing out accidental commit.
620
621         * page/Frame.cpp:
622         (WebCore::Frame::finishedParsing):
623
624 2006-10-09  Adam Roben  <aroben@apple.com>
625
626         Reviewed by Darin.
627
628         Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
629         this could cause recursive calls to the destructor. RefPtr now also
630         inherits from Noncopyable.
631
632         * dom/NodeFilter.h:
633         * dom/Traversal.h:
634         * page/DOMWindow.h:
635         * page/Frame.cpp:
636         (WebCore::Frame::finishedParsing):
637         * page/Frame.h:
638         * page/Plugin.h:
639         * platform/FontFallbackList.h:
640         * platform/Icon.h:
641         * platform/Shared.h:
642         (WebCore::Shared::Shared):
643         (WebCore::Shared::ref):
644         (WebCore::Shared::deref):
645         (WebCore::Shared::hasOneRef):
646         (WebCore::Shared::refCount):
647         * platform/StringImpl.h:
648
649 2006-10-09  Oliver Hunt <ohunt@apple.com>
650
651         Reviewed by Anders.
652
653         Correcting ifdef's
654
655         * html/CanvasGradient.cpp:
656         (WebCore::CanvasGradient::CanvasGradient):
657         (WebCore::CanvasGradient::~CanvasGradient):
658         (WebCore::CanvasGradient::addColorStop):
659         * html/CanvasGradient.h:
660         * html/CanvasPattern.cpp:
661         (WebCore::CanvasPattern::CanvasPattern):
662         (WebCore::CanvasPattern::~CanvasPattern):
663         * html/CanvasPattern.h:
664         * html/CanvasRenderingContext2D.cpp:
665         (WebCore::CanvasRenderingContext2D::fill):
666         (WebCore::CanvasRenderingContext2D::stroke):
667         (WebCore::CanvasRenderingContext2D::fillRect):
668         (WebCore::CanvasRenderingContext2D::setShadow):
669         (WebCore::CanvasRenderingContext2D::applyShadow):
670         (WebCore::CanvasRenderingContext2D::drawImage):
671         (WebCore::CanvasRenderingContext2D::createPattern):
672         (WebCore::CanvasRenderingContext2D::applyStrokePattern):
673         (WebCore::CanvasRenderingContext2D::applyFillPattern):
674         * html/CanvasRenderingContext2D.h:
675         * html/CanvasStyle.cpp:
676         (WebCore::CanvasStyle::applyStrokeColor):
677         (WebCore::CanvasStyle::applyFillColor):
678         * html/HTMLCanvasElement.cpp:
679         (WebCore::HTMLCanvasElement::paint):
680         (WebCore::HTMLCanvasElement::createDrawingContext):
681         * html/HTMLCanvasElement.h:
682
683 2006-10-09  Adam Roben  <aroben@apple.com>
684
685         Reviewed by Maciej.
686
687         Fix a possible recursive destructor call.
688
689         * page/Frame.cpp:
690         (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor.
691         (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if
692         we're already being destroyed.
693
694 2006-10-09  Sam Weinig  <sam.weinig@gmail.com>
695
696         Reviewed by Tim H.
697
698         Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
699         Assorted Objective-C bindings changes
700
701         - Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, 
702           DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, 
703           DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, 
704           DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, 
705           DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, 
706           DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, 
707           DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, 
708           DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, 
709           DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.
710
711         - Auto-generate absoluteImageURL method for DOMHTMLInputElement and
712           DOMHTMLObjectElement.
713
714         - Auto-generate the internal methods for classes with ivars (notably 
715           DOMNodeIterator and DOMTreeWalker)
716
717         - Put more methods in the WebCore namespace and factor out the  
718           displayString method into DOMInternal.h as done by Darin in his 
719           patch for http://bugs.webkit.org/show_bug.cgi?id=11219.
720
721         * DerivedSources.make:
722         * WebCore.xcodeproj/project.pbxproj:
723         * bindings/objc/DOM.mm:
724         (-[DOMNode _initWithNode:WebCore::]):
725         (+[DOMNode _nodeWith:WebCore::]):
726         (-[DOMNode addEventListener:listener:useCapture:]):
727         (-[DOMNode removeEventListener:listener:useCapture:]):
728         (-[DOMNode dispatchEvent:]):
729         (-[DOMElement _imageTIFFRepresentation]):
730         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
731         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
732         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
733         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
734         * bindings/objc/DOMCSS.mm:
735         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
736         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
737         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
738         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
739         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
740         (+[DOMCSSValue _CSSValueWith:WebCore::]):
741         * bindings/objc/DOMEvents.mm:
742         (-[DOMEvent _initWithEvent:WebCore::]):
743         (+[DOMEvent _eventWith:WebCore::]):
744         * bindings/objc/DOMExtensions.h:
745         * bindings/objc/DOMHTML.mm:
746         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
747         * bindings/objc/DOMInternal.h:
748         (-[DOMNodeFilter WebCore::]):
749         * bindings/objc/DOMInternal.mm:
750         (-[WebScriptObject _init]):
751         (-[WebScriptObject _initializeScriptDOMNodeImp]):
752         (WebCore::displayString):
753         * bindings/objc/DOMObject.mm:
754         (-[DOMObject dealloc]):
755         (-[DOMObject finalize]):
756         * bindings/objc/DOMRGBColor.mm:
757         (-[DOMRGBColor dealloc]):
758         (-[DOMRGBColor finalize]):
759         (-[DOMRGBColor color]):
760         (-[DOMRGBColor _initWithRGB:WebCore::]):
761         (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
762         * bindings/objc/DOMSVG.h:
763         * bindings/objc/DOMSVGPathSegInternal.h: Added.
764         * bindings/objc/DOMSVGPathSegInternal.mm: Added.
765         (-[DOMSVGPathSeg WebCore::]):
766         (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]):
767         (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
768         * bindings/objc/DOMXPath.mm:
769         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
770         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
771         * bindings/objc/PublicDOMInterfaces.h:
772         * bindings/scripts/CodeGeneratorObjC.pm:
773         * dom/NodeIterator.idl:
774         * dom/TreeWalker.idl:
775         * html/HTMLInputElement.idl:
776         * html/HTMLObjectElement.idl:
777         * ksvg2/svg/SVGDocument.idl:
778         * ksvg2/svg/SVGElement.idl:
779         * ksvg2/svg/SVGPathSeg.idl:
780         * ksvg2/svg/SVGPathSegArcAbs.idl:
781         * ksvg2/svg/SVGPathSegArcRel.idl:
782         * ksvg2/svg/SVGPathSegClosePath.idl:
783         * ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
784         * ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
785         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
786         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
787         * ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
788         * ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
789         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
790         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
791         * ksvg2/svg/SVGPathSegLinetoAbs.idl:
792         * ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
793         * ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
794         * ksvg2/svg/SVGPathSegLinetoRel.idl:
795         * ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
796         * ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
797         * ksvg2/svg/SVGPathSegMovetoAbs.idl:
798         * ksvg2/svg/SVGPathSegMovetoRel.idl:
799
800 2006-10-09  Don Gibson  <dgibson77@gmail.com>
801
802         Unreviewed build fix.
803
804         Fix windows build bustage.
805
806         * platform/win/TemporaryLinkStubs.cpp:
807
808 2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
809
810         Reviewed by Geoff.
811
812         Fix memory leaks discovered via valgrind. Gdk build fixes.
813
814         * Projects/gdk/webcore-gdk.bkl:
815         * make-generated-sources.sh:
816         * platform/cairo/ImageCairo.cpp:
817         (WebCore::Image::draw):
818         * platform/gdk/FrameGdk.cpp:
819         (WebCore::FrameGdk::handleGdkEvent):
820         * platform/gdk/FrameGdk.h:
821         * platform/gdk/PlatformScrollBar.h:
822         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
823         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
824
825 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
826
827         Reviewed by Beth.
828
829         Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.
830
831         * platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly
832         (WebCore::GlyphMap::fillPage):
833
834 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
835
836         Unreviewed build fix.
837
838         Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.
839
840         * platform/qt/FrameQt.cpp:
841         (WebCore::FrameQt::createJavaAppletWidget):
842         * platform/qt/FrameQt.h:
843         * platform/qt/TemporaryLinkStubs.cpp:
844
845 2006-10-09  Brady Eidson  <beidson@apple.com>
846
847         Reviewed by Maciej
848
849         Tiny changes to help reorganize WebFrameLoader code in WebKit
850
851         * bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
852         * bridge/mac/WebCoreIconDatabaseBridge.mm:
853         (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side
854
855 2006-10-09  Adam Roben  <aroben@apple.com>
856
857         Reviewed by Adele.
858
859         Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
860         already called frome ~FrameMac.
861
862         * page/Frame.cpp:
863         (WebCore::Frame::~Frame):
864
865 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
866
867         * bridge/win/FrameWin.h:
868         Add function declaration.
869         
870 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
871
872         * platform/win/TemporaryLinkStubs.cpp:
873         (FrameWin::createJavaAppletWidget):
874         Try fixing the Win32 build.
875
876 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
877
878         Reviewed by Adam.
879
880         Move applet widget creation to Frame and get rid of JavaAppletWidget.
881         * WebCore.xcodeproj/project.pbxproj:
882         * bridge/JavaAppletWidget.h: Removed.
883         * bridge/mac/FrameMac.h:
884         * bridge/mac/FrameMac.mm:
885         (WebCore::FrameMac::createJavaAppletWidget):
886         * bridge/mac/JavaAppletWidget.mm: Removed.
887         * page/Frame.h:
888         * rendering/RenderApplet.cpp:
889         (WebCore::RenderApplet::createWidgetIfNecessary):
890
891 2006-10-09  Mitz Pettel  <mitz@webkit.org>
892
893         Reviewed by Darin.
894
895         - http://bugs.webkit.org/show_bug.cgi?id=11220
896           Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276
897
898         Subversion does not support resource forks and HFS metadata, so
899         the resources for this test need to be on a disk image.
900
901         * manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
902         * manual-tests/resources/plain-text-paste.dmg: Added.
903         * manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
904         * manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
905         * manual-tests/resources/plain-text-paste/._4.txt: Removed.
906         * manual-tests/resources/plain-text-paste/._5.webloc: Removed.
907         * manual-tests/resources/plain-text-paste/1.textClipping: Removed.
908         * manual-tests/resources/plain-text-paste/2.textClipping: Removed.
909         * manual-tests/resources/plain-text-paste/3.gif: Removed.
910         * manual-tests/resources/plain-text-paste/4.txt: Removed.
911         * manual-tests/resources/plain-text-paste/5.webloc: Removed.
912
913 2006-10-09  Rob Buis  <buis@kde.org>
914
915         Reviewed by Darin.
916
917         http://bugs.webkit.org/show_bug.cgi?id=11217
918         Cleanup svg coding style
919
920         Cleanup coding style in filter classes.
921
922         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
923         (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
924         (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
925         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
926         * ksvg2/svg/SVGFEBlendElement.cpp:
927         (WebCore::SVGFEBlendElement::SVGFEBlendElement):
928         (WebCore::SVGFEBlendElement::parseMappedAttribute):
929         (WebCore::SVGFEBlendElement::filterEffect):
930         * ksvg2/svg/SVGFEBlendElement.h:
931         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
932         (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
933         (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
934         (WebCore::SVGFEColorMatrixElement::filterEffect):
935         * ksvg2/svg/SVGFEColorMatrixElement.h:
936         * ksvg2/svg/SVGFECompositeElement.cpp:
937         (WebCore::SVGFECompositeElement::parseMappedAttribute):
938         * ksvg2/svg/SVGFECompositeElement.h:
939         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
940         (WebCore::SVGFEDisplacementMapElement::stringToChannel):
941         * ksvg2/svg/SVGFEDisplacementMapElement.h:
942         * ksvg2/svg/SVGFEFloodElement.cpp:
943         (WebCore::SVGFEFloodElement::filterEffect):
944         * ksvg2/svg/SVGFEFuncAElement.cpp:
945         (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
946         * ksvg2/svg/SVGFEFuncBElement.cpp:
947         (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
948         * ksvg2/svg/SVGFEFuncGElement.cpp:
949         (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
950         * ksvg2/svg/SVGFEFuncRElement.cpp:
951         (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
952         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
953         (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
954         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
955         (WebCore::SVGFEGaussianBlurElement::filterEffect):
956         * ksvg2/svg/SVGFEGaussianBlurElement.h:
957         * ksvg2/svg/SVGFELightElement.cpp:
958         (WebCore::SVGFELightElement::SVGFELightElement):
959         (WebCore::SVGFELightElement::parseMappedAttribute):
960         * ksvg2/svg/SVGFELightElement.h:
961         * ksvg2/svg/SVGFEMergeElement.cpp:
962         (WebCore::SVGFEMergeElement::SVGFEMergeElement):
963
964 2006-10-09  Rob Buis  <buis@kde.org>
965
966         Reviewed by olliej.
967
968         http://bugs.webkit.org/show_bug.cgi?id=11217
969         Cleanup svg coding style
970
971         Cleanup coding style in SVGPath* classes.
972
973         * ksvg2/svg/SVGPathElement.cpp:
974         (WebCore::SVGPathElement::SVGPathElement):
975         (WebCore::SVGPathElement::getPointAtLength):
976         (WebCore::SVGPathElement::createSVGPathSegClosePath):
977         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
978         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
979         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
980         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
981         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
982         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
983         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
984         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
985         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
986         (WebCore::SVGPathElement::createSVGPathSegArcRel):
987         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
988         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
989         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
990         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
991         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
992         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
993         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
994         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
995         (WebCore::SVGPathElement::svgMoveTo):
996         (WebCore::SVGPathElement::svgLineTo):
997         (WebCore::SVGPathElement::svgLineToHorizontal):
998         (WebCore::SVGPathElement::svgLineToVertical):
999         (WebCore::SVGPathElement::svgCurveToCubic):
1000         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
1001         (WebCore::SVGPathElement::svgCurveToQuadratic):
1002         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
1003         (WebCore::SVGPathElement::svgArcTo):
1004         (WebCore::SVGPathElement::parseMappedAttribute):
1005         (WebCore::SVGPathElement::pathSegList):
1006         (WebCore::SVGPathElement::normalizedPathSegList):
1007         (WebCore::SVGPathElement::animatedPathSegList):
1008         (WebCore::SVGPathElement::animatedNormalizedPathSegList):
1009         (WebCore::SVGPathElement::toPathData):
1010         * ksvg2/svg/SVGPathElement.h:
1011         (WebCore::SVGPathElement::rendererIsNeeded):
1012         * ksvg2/svg/SVGPathSeg.h:
1013         * ksvg2/svg/SVGPathSegArc.cpp:
1014
1015 2006-10-09  Rob Buis  <buis@kde.org>
1016
1017         Reviewed by aroben.
1018
1019         http://bugs.webkit.org/show_bug.cgi?id=11217
1020         Cleanup svg coding style
1021
1022         Cleanup coding style in svg shape classes.
1023
1024         * ksvg2/svg/SVGCircleElement.cpp:
1025         (WebCore::SVGCircleElement::SVGCircleElement):
1026         (WebCore::SVGCircleElement::parseMappedAttribute):
1027         (WebCore::SVGCircleElement::pushAttributeContext):
1028         * ksvg2/svg/SVGCircleElement.h:
1029         (WebCore::SVGCircleElement::rendererIsNeeded):
1030         * ksvg2/svg/SVGEllipseElement.cpp:
1031         * ksvg2/svg/SVGEllipseElement.h:
1032         (WebCore::SVGEllipseElement::rendererIsNeeded):
1033         * ksvg2/svg/SVGLineElement.cpp:
1034         (WebCore::SVGLineElement::parseMappedAttribute):
1035         (WebCore::SVGLineElement::pushAttributeContext):
1036         * ksvg2/svg/SVGLineElement.h:
1037         (WebCore::SVGLineElement::rendererIsNeeded):
1038         * ksvg2/svg/SVGPolyElement.cpp:
1039         (WebCore::SVGPolyElement::SVGPolyElement):
1040         (WebCore::SVGPolyElement::points):
1041         (WebCore::SVGPolyElement::animatedPoints):
1042         (WebCore::SVGPolyElement::parseMappedAttribute):
1043         (WebCore::SVGPolyElement::notifyAttributeChange):
1044         * ksvg2/svg/SVGPolyElement.h:
1045         (WebCore::SVGPolyElement::rendererIsNeeded):
1046         * ksvg2/svg/SVGPolygonElement.cpp:
1047         (WebCore::SVGPolygonElement::SVGPolygonElement):
1048         (WebCore::SVGPolygonElement::toPathData):
1049         * ksvg2/svg/SVGPolygonElement.h:
1050         * ksvg2/svg/SVGPolylineElement.cpp:
1051         (WebCore::SVGPolylineElement::SVGPolylineElement):
1052         (WebCore::SVGPolylineElement::toPathData):
1053         * ksvg2/svg/SVGPolylineElement.h:
1054         * ksvg2/svg/SVGRectElement.cpp:
1055         (WebCore::SVGRectElement::parseMappedAttribute):
1056         (WebCore::SVGRectElement::pushAttributeContext):
1057         * ksvg2/svg/SVGRectElement.h:
1058         (WebCore::SVGRectElement::rendererIsNeeded):
1059
1060 2006-10-08  Darin Adler  <darin@apple.com>
1061
1062         Reviewed by Maciej.
1063
1064         - added a bit more WebCoreSystemInterface
1065
1066             wkGetNSURLResponseCalculatedExpiration
1067             wkGetNSURLResponseLastModifiedDate
1068             wkGetNSURLResponseMustRevalidate
1069
1070         * WebCore.exp: Added the new symbols.
1071         * platform/mac/WebCoreSystemInterface.h: Ditto.
1072         * platform/mac/WebCoreSystemInterface.mm: Ditto.
1073
1074         - quiet down the code generation script
1075
1076         * bindings/scripts/CodeGenerator.pm:
1077
1078 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
1079
1080         Reviewed by Darin.
1081
1082         - more code laundering - add wkSupportsMultipartXMixedReplace
1083
1084         * WebCore.exp:
1085         * platform/mac/WebCoreSystemInterface.h:
1086         * platform/mac/WebCoreSystemInterface.mm:
1087
1088 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
1089
1090         Reviewed by Darin and Oliver.
1091
1092         Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.
1093
1094         * platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage.
1095         (WebCore::GraphicsContext::drawConvexPolygon):
1096
1097 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
1098
1099         Reviewed by Darin.
1100
1101         * page/Frame.cpp:
1102         (WebCore::Frame::submitForm):
1103         No need to use latin1() here.
1104
1105 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
1106
1107         Reviewed by Darin.
1108
1109         Kill warnings when generating IDL files on Qt/Linux, as the
1110         SOURCE_ROOT environment variable is not defined (and not needed) for us.
1111
1112         * bindings/scripts/CodeGenerator.pm:
1113
1114 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
1115
1116         Reviewed by Darin.
1117
1118         - split didNotOpenURL: into general and page-cache-specific parts
1119
1120         * bridge/mac/WebCoreFrameBridge.h:
1121         * bridge/mac/WebCoreFrameBridge.mm:
1122         (-[WebCoreFrameBridge didNotOpenURL:]):
1123         (-[WebCoreFrameBridge invalidatePageCache:]):
1124
1125 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
1126
1127         Reviewed by Darin.
1128
1129         * loader/loader.cpp:
1130         Remove DeprecatedStringList.h include.
1131         
1132         * page/Frame.cpp:
1133         (WebCore::Frame::submitForm):
1134         Don't remove "attach" from mailto URLs, we don't do it anywhere else.
1135
1136 2006-10-08  Sam Weinig  <sam.weinig@gmail.com>
1137
1138         Reviewed by Darin.
1139
1140         Patch for http://bugs.webkit.org/show_bug.cgi?id=11215
1141         Yet another round of Objective-C SVG DOM bindings auto-generation
1142
1143         - Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement, 
1144           DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent,
1145           DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement, 
1146           DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement, 
1147           DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement, 
1148           DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement, 
1149           DOMSVGZoomAndPan and DOMSVGZoomEvent.
1150
1151         - Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement
1152           using the new [ConvertFromString] property.
1153
1154         - Add forward declarations for NS* types to auto-generated classes.
1155
1156         * DerivedSources.make:
1157         * WebCore.xcodeproj/project.pbxproj:
1158         * bindings/objc/DOMHTMLAppletElement.mm: Removed.
1159         * bindings/objc/DOMHTMLEmbedElement.mm: Removed.
1160         * bindings/objc/DOMInternal.h:
1161         * bindings/objc/DOMSVG.h:
1162         * bindings/scripts/CodeGeneratorObjC.pm:
1163         * html/HTMLAppletElement.idl:
1164         * html/HTMLEmbedElement.idl:
1165         * ksvg2/svg/SVGPatternElement.idl:
1166         * ksvg2/svg/SVGPolygonElement.idl:
1167         * ksvg2/svg/SVGPolylineElement.idl:
1168         * ksvg2/svg/SVGRadialGradientElement.idl:
1169         * ksvg2/svg/SVGRenderingIntent.idl:
1170         * ksvg2/svg/SVGScriptElement.idl:
1171         * ksvg2/svg/SVGSetElement.idl:
1172         * ksvg2/svg/SVGStopElement.idl:
1173         * ksvg2/svg/SVGSwitchElement.idl:
1174         * ksvg2/svg/SVGSymbolElement.idl:
1175         * ksvg2/svg/SVGTRefElement.idl:
1176         * ksvg2/svg/SVGTSpanElement.idl:
1177         * ksvg2/svg/SVGTextContentElement.idl:
1178         * ksvg2/svg/SVGTextElement.idl:
1179         * ksvg2/svg/SVGTextPositioningElement.idl:
1180         * ksvg2/svg/SVGTitleElement.idl:
1181         * ksvg2/svg/SVGUseElement.idl:
1182         * ksvg2/svg/SVGViewElement.idl:
1183         * ksvg2/svg/SVGZoomEvent.idl:
1184
1185 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
1186
1187         Reviewed by Maciej.
1188
1189         Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.        
1190         * loader/loader.cpp:
1191         (WebCore::Loader::servePendingRequests):
1192         
1193 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
1194
1195         Reviewed by Darin.
1196
1197         Convert a bunch of RefPtr<StringImpl> to String.
1198         
1199         * bridge/mac/FrameMac.h:
1200         * bridge/mac/FrameMac.mm:
1201         (WebCore::FrameMac::didTellBridgeAboutLoad):
1202         (WebCore::FrameMac::haveToldBridgeAboutLoad):
1203         * dom/BeforeUnloadEvent.cpp:
1204         (WebCore::BeforeUnloadEvent::storeResult):
1205         * dom/BeforeUnloadEvent.h:
1206         (WebCore::BeforeUnloadEvent::result):
1207         * dom/Document.cpp:
1208         (WebCore::Document::createEntityReference):
1209         * dom/Entity.cpp:
1210         (WebCore::Entity::Entity):
1211         (WebCore::Entity::nodeName):
1212         (WebCore::Entity::toString):
1213         * dom/Entity.h:
1214         (WebCore::Entity::publicId):
1215         (WebCore::Entity::systemId):
1216         (WebCore::Entity::notationName):
1217         * dom/EntityReference.cpp:
1218         (WebCore::EntityReference::EntityReference):
1219         (WebCore::EntityReference::nodeName):
1220         (WebCore::EntityReference::cloneNode):
1221         (WebCore::EntityReference::toString):
1222         * dom/EntityReference.h:
1223         * dom/KeyboardEvent.cpp:
1224         (WebCore::KeyboardEvent::KeyboardEvent):
1225         (WebCore::KeyboardEvent::initKeyboardEvent):
1226         * dom/KeyboardEvent.h:
1227         (WebCore::KeyboardEvent::keyIdentifier):
1228         * dom/MutationEvent.cpp:
1229         (WebCore::MutationEvent::MutationEvent):
1230         (WebCore::MutationEvent::initMutationEvent):
1231         * dom/MutationEvent.h:
1232         (WebCore::MutationEvent::prevValue):
1233         (WebCore::MutationEvent::newValue):
1234         (WebCore::MutationEvent::attrName):
1235         * dom/Notation.cpp:
1236         (WebCore::Notation::Notation):
1237         (WebCore::Notation::nodeName):
1238         * dom/Notation.h:
1239         (WebCore::Notation::publicId):
1240         (WebCore::Notation::systemId):
1241         * dom/ProcessingInstruction.cpp:
1242         (WebCore::ProcessingInstruction::ProcessingInstruction):
1243         (WebCore::ProcessingInstruction::setData):
1244         (WebCore::ProcessingInstruction::nodeName):
1245         (WebCore::ProcessingInstruction::nodeValue):
1246         (WebCore::ProcessingInstruction::cloneNode):
1247         (WebCore::ProcessingInstruction::checkStyleSheet):
1248         (WebCore::ProcessingInstruction::toString):
1249         * dom/ProcessingInstruction.h:
1250         (WebCore::ProcessingInstruction::target):
1251         (WebCore::ProcessingInstruction::data):
1252         (WebCore::ProcessingInstruction::localHref):
1253
1254 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
1255
1256         Reviewed by Tim H.
1257
1258         Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
1259         10 more SVG Objective-C auto-generated bindings
1260
1261         - Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, 
1262           DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement,
1263           DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, 
1264           DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
1265
1266         - Auto-generate the text method for DOMRange.
1267
1268         * DerivedSources.make:
1269         * WebCore.xcodeproj/project.pbxproj:
1270         * bindings/objc/DOM.mm:
1271         * bindings/objc/DOMExtensions.h:
1272         * bindings/objc/DOMInternal.h:
1273         * bindings/objc/DOMPrivate.h:
1274         * bindings/objc/DOMRGBColor.mm:
1275         * bindings/objc/DOMSVG.h:
1276         * bindings/objc/PublicDOMInterfaces.h:
1277         * bindings/scripts/CodeGeneratorObjC.pm:
1278         * dom/Range.idl:
1279         * ksvg2/svg/SVGFilterElement.cpp:
1280         * ksvg2/svg/SVGFilterElement.h:
1281         * ksvg2/svg/SVGFilterElement.idl:
1282         * ksvg2/svg/SVGForeignObjectElement.idl:
1283         * ksvg2/svg/SVGGElement.idl:
1284         * ksvg2/svg/SVGGradientElement.idl:
1285         * ksvg2/svg/SVGImageElement.idl:
1286         * ksvg2/svg/SVGLineElement.idl:
1287         * ksvg2/svg/SVGLinearGradientElement.idl:
1288         * ksvg2/svg/SVGMarkerElement.idl:
1289         * ksvg2/svg/SVGMaskElement.idl:
1290         * ksvg2/svg/SVGPaint.idl:
1291
1292 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
1293
1294         Reviewed by Tim H.
1295
1296         Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
1297         Auto-generate a few more Objective-C DOM interfaces
1298
1299         - Fully auto-generate DOMAbstractView and DOMRange.
1300
1301         - Auto-generate just the interface for DOMRGBColor.
1302
1303         - Add DOMRanges.h as the new top level file for Ranges
1304           module.
1305
1306         - Add DOMRanges.h and DOMXPath.h to DOM.mm
1307
1308         * DerivedSources.make:
1309         * WebCore.xcodeproj/project.pbxproj:
1310         * bindings/objc/DOM.h:
1311         * bindings/objc/DOM.mm:
1312         * bindings/objc/DOMAbstractView.h: Removed.
1313         * bindings/objc/DOMAbstractView.mm: Removed.
1314         * bindings/objc/DOMInternal.h:
1315         * bindings/objc/DOMPrivate.h:
1316         * bindings/objc/DOMRGBColor.h: Removed.
1317         * bindings/objc/DOMRGBColor.mm:
1318         * bindings/objc/DOMRange.h: Removed.
1319         * bindings/objc/DOMRanges.h: Added.
1320         * bindings/objc/PublicDOMInterfaces.h:
1321         * bindings/scripts/CodeGeneratorObjC.pm:
1322         * css/RGBColor.idl:
1323         * dom/Range.idl:
1324         * page/AbstractView.idl: Added.
1325
1326 2006-10-07  Andrew Wellington  <proton@wiretapped.net>
1327
1328         Reviewed by Eric.
1329
1330         Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
1331         http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
1332
1333         Return null when there is no frame. This matches Firefox.
1334
1335         * bindings/js/kjs_html.cpp:
1336         (KJS::JSHTMLDocument::getValueProperty):
1337
1338 2006-10-07  David Hyatt  <hyatt@apple.com>
1339
1340         Implement scroll corner painting (a white rect fill) for overflow areas to cover up
1341         scrollbar joins properly.
1342
1343         Refactor painting of scrollbars and resizers into common functions.  Eliminate the
1344         extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
1345
1346         Reviewed by mitz
1347
1348         * page/FrameView.cpp:
1349         (WebCore::selectCursor):
1350         (WebCore::FrameView::handleMouseMoveEvent):
1351         * platform/mac/PlatformScrollBar.h:
1352         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
1353         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
1354         * rendering/RenderLayer.cpp:
1355         (WebCore::RenderLayer::RenderLayer):
1356         (WebCore::RenderLayer::~RenderLayer):
1357         (WebCore::RenderLayer::updateLayerPositions):
1358         (WebCore::scrollCornerRect):
1359         (WebCore::RenderLayer::positionOverflowControls):
1360         (WebCore::RenderLayer::paintOverflowControls):
1361         (WebCore::RenderLayer::isPointInResizeControl):
1362         (WebCore::RenderLayer::paintLayer):
1363         * rendering/RenderLayer.h:
1364
1365 2006-10-07  Mark Rowe  <bdash@webkit.org>
1366
1367         Reviewed by Mitz.
1368
1369         Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
1370         matching recent ResourceLoader changes.
1371
1372         * platform/gdk/FrameGdk.cpp:
1373         (WebCore::FrameGdk::openURL):
1374         (WebCore::FrameGdk::urlSelected):
1375         * platform/gdk/PlatformScrollBar.h:
1376         * platform/gdk/ResourceLoaderCurl.cpp:
1377         (WebCore::ResourceLoader::start):
1378         * platform/gdk/ScrollViewGdk.cpp:
1379         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
1380         (WebCore::ScrollView::resizeContents):
1381         (WebCore::ScrollView::scrollBy):
1382         (WebCore::ScrollView::hScrollbarMode):
1383         (WebCore::ScrollView::vScrollbarMode):
1384         (WebCore::ScrollView::suppressScrollbars):
1385         (WebCore::ScrollView::setHScrollbarMode):
1386         (WebCore::ScrollView::setVScrollbarMode):
1387         (WebCore::ScrollView::setScrollbarsMode):
1388         * platform/gdk/TemporaryLinkStubs.cpp:
1389         (FrameView::passMousePressEventToScrollbar):
1390         (Widget::removeFromParent):
1391         (ScrollView::addChild):
1392         (ScrollView::updateScrollbars):
1393         (ScrollView::scrollbarUnderMouse):
1394         (PlatformScrollbar::PlatformScrollbar):
1395         (PlatformScrollbar::~PlatformScrollbar):
1396         (PlatformScrollbar::width):
1397         (PlatformScrollbar::height):
1398         (PlatformScrollbar::setEnabled):
1399         (PlatformScrollbar::paint):
1400         (PlatformScrollbar::updateThumbPosition):
1401         (PlatformScrollbar::updateThumbProportion):
1402         (PlatformScrollbar::setRect):
1403         (Scrollbar::Scrollbar):
1404         (Scrollbar::setSteps):
1405         (Scrollbar::scroll):
1406         (Scrollbar::setValue):
1407         (Scrollbar::setProportion):
1408
1409 2006-10-06  Dave Hyatt  <hyatt@apple.com>
1410
1411         Implement a new method for obtaining accurate clip rectangles that can be used by plugins to properly clip.
1412
1413         * page/FrameView.cpp:
1414         (WebCore::FrameView::windowClipRect):
1415         * page/FrameView.h:
1416         * platform/ScrollView.h:
1417         * platform/Widget.cpp:
1418         (WebCore::Widget::windowClipRect):
1419         * platform/Widget.h:
1420         (WebCore::Widget::geometryChanged):
1421         (WebCore::Widget::handleMouseMoveEvent):
1422         (WebCore::Widget::handleMouseReleaseEvent):
1423         * platform/mac/ScrollViewMac.mm:
1424         (WebCore::ScrollView::addChild):
1425         * rendering/RenderLayer.cpp:
1426         (WebCore::RenderLayer::documentClipRect):
1427         * rendering/RenderLayer.h:
1428
1429 2006-10-06  Steve Falkenburg  <sfalken@apple.com>
1430
1431         Reviewed by Adam.
1432
1433         Add another method we'll need for scrollbar dodging
1434
1435         * platform/ScrollView.h:
1436         * platform/win/TemporaryLinkStubs.cpp:
1437         (ScrollView::resizerOverlapsContent):
1438
1439 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
1440
1441         Reviewed by Tim H.
1442
1443         Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
1444         Auto-generate the interfaces even for Objective-C DOM 
1445         bindings that need custom implementations
1446
1447         - Fully auto-generate DOMEventTarget, DOMNodeFilter and 
1448           DOMHTMLOptionElement.
1449
1450         - Auto-generate just the interface for DOMHTMLAppletElement,
1451           DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect
1452           using the new IDL property ObjCCustomImplementation.
1453
1454         * DerivedSources.make:
1455         * WebCore.xcodeproj/project.pbxproj:
1456         * bindings/objc/DOMEventTarget.h: Removed.
1457         * bindings/objc/DOMHTMLAppletElement.h: Removed.
1458         * bindings/objc/DOMHTMLEmbedElement.h: Removed.
1459         * bindings/objc/DOMHTMLOptionElement.h: Removed.
1460         * bindings/objc/DOMHTMLOptionElement.mm: Removed.
1461         * bindings/objc/DOMInternal.h:
1462         * bindings/objc/DOMNodeFilter.h: Removed.
1463         * bindings/objc/DOMSVGNumber.h: Removed.
1464         * bindings/objc/DOMSVGPoint.h: Removed.
1465         * bindings/objc/DOMSVGPoint.mm:
1466         (-[DOMSVGPoint matrixTransform:]):
1467         * bindings/objc/DOMSVGRect.h: Removed.
1468         * bindings/objc/PublicDOMInterfaces.h:
1469         * bindings/scripts/CodeGeneratorObjC.pm:
1470         * dom/EventTarget.idl:
1471         * html/HTMLAppletElement.idl:
1472         * html/HTMLEmbedElement.idl:
1473         * html/HTMLOptionElement.idl:
1474         * ksvg2/svg/SVGNumber.idl:
1475         * ksvg2/svg/SVGPoint.idl:
1476         * ksvg2/svg/SVGRect.idl:
1477
1478 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
1479
1480         Reviewed by Tim H.
1481
1482         Make Qt/Linux compile again completly.
1483
1484         * platform/qt/WidgetQt.cpp:
1485         (WebCore::Widget::removeFromParent):
1486
1487 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
1488
1489         Reviewed by Tim H.
1490
1491         Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.
1492
1493         * platform/qt/PlatformScrollBar.h:
1494         * platform/qt/ScrollViewQt.cpp:
1495         (WebCore::ScrollView::hScrollbarMode):
1496         (WebCore::ScrollView::vScrollbarMode):
1497         (WebCore::ScrollView::suppressScrollbars):
1498         (WebCore::ScrollView::setHScrollbarMode):
1499         (WebCore::ScrollView::setVScrollbarMode):
1500         (WebCore::ScrollView::setScrollbarsMode):
1501         (WebCore::ScrollView::scrollbarUnderMouse):
1502         * platform/qt/TemporaryLinkStubs.cpp:
1503         (WebCore::Scrollbar::Scrollbar):
1504         (WebCore::Scrollbar::setSteps):
1505         (WebCore::Scrollbar::scroll):
1506         (WebCore::Scrollbar::setValue):
1507         (WebCore::Scrollbar::setProportion):
1508         (WebCore::PlatformScrollbar::PlatformScrollbar):
1509         (WebCore::PlatformScrollbar::~PlatformScrollbar):
1510         (WebCore::PlatformScrollbar::width):
1511         (WebCore::PlatformScrollbar::height):
1512         (WebCore::PlatformScrollbar::setEnabled):
1513         (WebCore::PlatformScrollbar::paint):
1514         (WebCore::PlatformScrollbar::updateThumbPosition):
1515         (WebCore::PlatformScrollbar::updateThumbProportion):
1516         (WebCore::PlatformScrollbar::setRect):
1517         (FrameView::passMousePressEventToScrollbar):
1518
1519 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
1520
1521         Reviewed by Tim H.
1522
1523         Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
1524         Another round of Objective-C SVG DOM bindings auto-generation
1525
1526         - Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect, 
1527           DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement, 
1528           DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement, 
1529           DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement,
1530           DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement, 
1531           DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement, 
1532           DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement, 
1533           DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement, 
1534           DOMSVGFEOffsetElement, DOMSVGFEPointLightElement, 
1535           DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement, 
1536           DOMSVGFETileElement, DOMSVGFETurbulenceElement, 
1537           DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList. 
1538
1539         - Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint
1540           and DOMSVGRect.
1541
1542         - IDL clean up.
1543
1544         - Make numOctaves in SVGFETurbulenceElement use a long instead of an int
1545           in it's macro declaration and definition.
1546
1547         * DerivedSources.make:
1548         * WebCore.xcodeproj/project.pbxproj:
1549         * bindings/objc/DOMCSS.mm:
1550         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1551         * bindings/objc/DOMInternal.h:
1552         * bindings/objc/DOMSVG.h:
1553         * bindings/objc/DOMSVGNumber.h: Added.
1554         * bindings/objc/DOMSVGNumber.mm: Added.
1555         (-[DOMSVGNumber dealloc]):
1556         (-[DOMSVGNumber finalize]):
1557         (-[DOMSVGNumber value]):
1558         (-[DOMSVGNumber setValue:]):
1559         (-[DOMSVGNumber _SVGNumber]):
1560         (-[DOMSVGNumber _initWithFloat:]):
1561         (+[DOMSVGNumber _SVGNumberWith:]):
1562         * bindings/objc/DOMSVGPoint.h: Added.
1563         * bindings/objc/DOMSVGPoint.mm: Added.
1564         (-[DOMSVGPoint dealloc]):
1565         (-[DOMSVGPoint finalize]):
1566         (-[DOMSVGPoint x]):
1567         (-[DOMSVGPoint setX:]):
1568         (-[DOMSVGPoint y]):
1569         (-[DOMSVGPoint setY:]):
1570         (-[DOMSVGPoint WebCore::]):
1571         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
1572         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
1573         * bindings/objc/DOMSVGRect.h: Added.
1574         * bindings/objc/DOMSVGRect.mm: Added.
1575         (-[DOMSVGRect dealloc]):
1576         (-[DOMSVGRect finalize]):
1577         (-[DOMSVGRect x]):
1578         (-[DOMSVGRect setX:]):
1579         (-[DOMSVGRect y]):
1580         (-[DOMSVGRect setY:]):
1581         (-[DOMSVGRect width]):
1582         (-[DOMSVGRect setWidth:]):
1583         (-[DOMSVGRect height]):
1584         (-[DOMSVGRect setHeight:]):
1585         (-[DOMSVGRect WebCore::]):
1586         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
1587         (+[DOMSVGRect _SVGRectWith:WebCore::]):
1588         * bindings/scripts/CodeGeneratorObjC.pm:
1589         * ksvg2/svg/SVGAnimatedNumberList.idl:
1590         * ksvg2/svg/SVGAnimatedRect.idl:
1591         * ksvg2/svg/SVGComponentTransferFunctionElement.idl:
1592         * ksvg2/svg/SVGCursorElement.idl:
1593         * ksvg2/svg/SVGFEBlendElement.idl:
1594         * ksvg2/svg/SVGFEColorMatrixElement.idl:
1595         * ksvg2/svg/SVGFEComponentTransferElement.idl:
1596         * ksvg2/svg/SVGFECompositeElement.idl:
1597         * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
1598         * ksvg2/svg/SVGFEDisplacementMapElement.idl:
1599         * ksvg2/svg/SVGFEDistantLightElement.idl:
1600         * ksvg2/svg/SVGFEFloodElement.idl:
1601         * ksvg2/svg/SVGFEFuncAElement.idl:
1602         * ksvg2/svg/SVGFEFuncBElement.idl:
1603         * ksvg2/svg/SVGFEFuncGElement.idl:
1604         * ksvg2/svg/SVGFEFuncRElement.idl:
1605         * ksvg2/svg/SVGFEGaussianBlurElement.idl:
1606         * ksvg2/svg/SVGFEImageElement.idl:
1607         * ksvg2/svg/SVGFEMergeElement.idl:
1608         * ksvg2/svg/SVGFEMergeNodeElement.idl:
1609         * ksvg2/svg/SVGFEOffsetElement.idl:
1610         * ksvg2/svg/SVGFEPointLightElement.idl:
1611         * ksvg2/svg/SVGFESpecularLightingElement.idl:
1612         * ksvg2/svg/SVGFESpotLightElement.idl:
1613         * ksvg2/svg/SVGFETileElement.idl:
1614         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1615         * ksvg2/svg/SVGFETurbulenceElement.h:
1616         * ksvg2/svg/SVGFETurbulenceElement.idl:
1617         * ksvg2/svg/SVGNumberList.idl:
1618
1619 2006-10-06  Adam Roben  <aroben@apple.com>
1620
1621         Backing out my previous change.
1622
1623         * WebCore.xcodeproj/project.pbxproj:
1624         * page/FrameView.cpp:
1625         (WebCore::FrameView::adjustViewSize):
1626
1627 2006-10-06  Adam Roben  <aroben@apple.com>
1628
1629         Build fix.
1630
1631         * WebCore.xcodeproj/project.pbxproj:
1632         * page/FrameView.cpp:
1633         (WebCore::FrameView::windowResizerRect):
1634
1635 2006-10-06  Adam Roben  <aroben@apple.com>
1636
1637         Reviewed by Maciej.
1638
1639         More loader tweaks.
1640
1641         * platform/ResourceLoader.h:
1642         * platform/ResourceLoaderInternal.h:
1643         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1644         * platform/win/TemporaryLinkStubs.cpp:
1645         (WebCore::ResourceLoader::newHTTPRequest):
1646
1647 2006-10-05  Steve Falkenburg  <sfalken@apple.com>
1648
1649         Reviewed by aroben.
1650
1651         Stub out some methods that we'll be able to use to dodge a window resizer.
1652
1653         * bridge/win/FrameWin.h:
1654         * page/Frame.h:
1655         (WebCore::Frame::windowResizerRect):
1656         * page/FrameView.h:
1657         * platform/ScrollView.h:
1658         (WebCore::ScrollView::windowResizerRect):
1659         * platform/Widget.h:
1660         * platform/win/TemporaryLinkStubs.cpp:
1661         (FrameView::windowResizerRect):
1662         (Widget::setParent):
1663         (Widget::parent):
1664         (FrameWin::windowResizerRect):
1665
1666 2006-10-05  Dave Hyatt  <hyatt@apple.com>
1667
1668         Stub out setFrameGeometry.
1669         
1670         * platform/ScrollView.h:
1671
1672 2006-10-05  Adele Peterson  <adele@apple.com>
1673
1674         Reverting autoscroll fix.  I need to rework this a little.
1675
1676         * page/Frame.cpp:
1677         (WebCore::Frame::handleAutoscroll):
1678         (WebCore::Frame::autoscrollTimerFired):
1679         (WebCore::Frame::stopAutoscrollTimer):
1680         * page/Frame.h:
1681         * rendering/RenderLayer.cpp:
1682         (WebCore::RenderLayer::~RenderLayer):
1683         * rendering/RenderListBox.cpp:
1684         (WebCore::RenderListBox::~RenderListBox):
1685
1686 2006-10-05  Alice  <alice.liu@apple.com>
1687
1688         Reviewed by Adam.
1689
1690         Fixed <rdar://problem/4731778>
1691
1692         * editing/CommandByName.cpp:
1693         (WebCore::Frame::Command::):
1694         was calling the wrong enabledFn for arrow selection and navigation
1695
1696 2006-10-05  Adele Peterson  <adele@apple.com>
1697
1698         Reviewed by Maciej.
1699
1700         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text">
1701           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
1702
1703         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
1704         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
1705
1706         * page/Frame.cpp: Added getter and setter for the renderer being autoscrolled.
1707         (WebCore::Frame::handleAutoscroll):
1708         (WebCore::Frame::autoscrollTimerFired):
1709         (WebCore::Frame::autoscrollRenderer):
1710         (WebCore::Frame::setAutoscrollRenderer):
1711         (WebCore::Frame::stopAutoscrollTimer):
1712         * page/Frame.h:
1713
1714 2006-10-05  Don Gibson  <dgibson77@gmail.com>
1715
1716         Reviewed by Eric.
1717
1718         Fix win32 build bustage after ggaren's Scrollbar renaming changes.
1719         Properly include PlatformScrollBar.h in WbCore.vcproj.
1720         Clean up WidgetWin.cpp a bit.
1721
1722         * WebCore.vcproj/WebCore/WebCore.vcproj:
1723         * platform/Widget.h:
1724         * platform/win/PlatformScrollBar.h:
1725         * platform/win/ScrollViewWin.cpp:
1726         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
1727         (WebCore::ScrollView::resizeContents):
1728         (WebCore::ScrollView::scrollBy):
1729         (WebCore::ScrollView::hScrollbarMode):
1730         (WebCore::ScrollView::vScrollbarMode):
1731         (WebCore::ScrollView::suppressScrollbars):
1732         (WebCore::ScrollView::setHScrollbarMode):
1733         (WebCore::ScrollView::setVScrollbarMode):
1734         (WebCore::ScrollView::setScrollbarsMode):
1735         (WebCore::ScrollView::updateScrollbars):
1736         * platform/win/TemporaryLinkStubs.cpp:
1737         (FrameView::passMousePressEventToScrollbar):
1738         (Widget::removeFromParent):
1739         (ScrollView::scrollbarUnderMouse):
1740         (PlatformScrollbar::PlatformScrollbar):
1741         (PlatformScrollbar::~PlatformScrollbar):
1742         (PlatformScrollbar::width):
1743         (PlatformScrollbar::height):
1744         (PlatformScrollbar::setEnabled):
1745         (PlatformScrollbar::paint):
1746         (PlatformScrollbar::updateThumbPosition):
1747         (PlatformScrollbar::updateThumbProportion):
1748         (PlatformScrollbar::setRect):
1749         (Scrollbar::Scrollbar):
1750         (Scrollbar::setSteps):
1751         (Scrollbar::scroll):
1752         (Scrollbar::setValue):
1753         (Scrollbar::setProportion):
1754         * platform/win/WidgetWin.cpp:
1755         (WebCore::WidgetPrivate::WidgetPrivate):
1756         (WebCore::Widget::Widget):
1757         (WebCore::Widget::setContainingWindow):
1758         (WebCore::Widget::containingWindow):
1759
1760 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
1761
1762         build fix.
1763         
1764         * WebCore.xcodeproj/project.pbxproj:
1765         * bridge/mac/BrowserExtensionMac.mm:
1766         (WebCore::BrowserExtensionMac::createNewWindow):
1767         * bridge/mac/FrameMac.mm:
1768         (WebCore::FrameMac::createFrame):
1769         * bridge/mac/FrameViewMac.mm:
1770         (WebCore::FrameView::passMousePressEventToScrollbar):
1771         * bridge/mac/WebCoreFrameBridge.mm:
1772         (-[WebCoreFrameBridge installInFrame:]):
1773         * bridge/mac/WebCoreFrameView.h:
1774         * platform/ScrollBar.cpp:
1775         * platform/Widget.h:
1776         * platform/mac/PlatformScrollBar.h:
1777         * platform/mac/PlatformScrollBarMac.mm:
1778         (NSControlSizeForScrollBarControlSize):
1779         (-[WebCoreScrollBar initWithPlatformScrollbar:]):
1780         (-[WebCoreScrollBar detachPlatformScrollbar]):
1781         (-[WebCoreScrollBar scroll:]):
1782         (-[WebCoreScrollBar widget]):
1783         (WebCore::PlatformScrollbar::PlatformScrollbar):
1784         (WebCore::PlatformScrollbar::~PlatformScrollbar):
1785         (WebCore::PlatformScrollbar::updateThumbPosition):
1786         (WebCore::PlatformScrollbar::updateThumbProportion):
1787         (WebCore::PlatformScrollbar::scrollbarHit):
1788         (WebCore::PlatformScrollbar::width):
1789         (WebCore::PlatformScrollbar::height):
1790         (WebCore::PlatformScrollbar::setRect):
1791         (WebCore::PlatformScrollbar::setEnabled):
1792         (WebCore::PlatformScrollbar::paint):
1793         * platform/mac/ScrollViewMac.mm:
1794         (WebCore::ScrollView::setVScrollbarMode):
1795         (WebCore::ScrollView::setHScrollbarMode):
1796         (WebCore::ScrollView::setScrollbarsMode):
1797         (WebCore::ScrollView::vScrollbarMode):
1798         (WebCore::ScrollView::hScrollbarMode):
1799         (WebCore::ScrollView::suppressScrollbars):
1800         (WebCore::ScrollView::scrollbarUnderMouse):
1801         * platform/mac/WidgetMac.mm:
1802         (WebCore::Widget::removeFromParent):
1803         * rendering/RenderLayer.cpp:
1804         (WebCore::RenderLayer::destroyScrollbar):
1805
1806 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
1807
1808         build fix.
1809         
1810         * platform/Widget.h:
1811         * rendering/RenderLayer.cpp:
1812         (WebCore::RenderLayer::destroyScrollbar):
1813
1814 2006-10-06  Mitz Pettel  <mitz@webkit.org>
1815
1816         http://bugs.webkit.org/show_bug.cgi?id=8276
1817         Fix broken manual test added back in r13990.
1818
1819         Add resource forks for test resources.
1820
1821         * manual-tests/resources/plain-text-paste/._1.textClipping: Added.
1822         * manual-tests/resources/plain-text-paste/._2.textClipping: Added.
1823         * manual-tests/resources/plain-text-paste/._4.txt: Added.
1824         * manual-tests/resources/plain-text-paste/._5.webloc: Added.
1825
1826 2006-10-05  David Hyatt  <hyatt@apple.com>
1827
1828         Rename addClip to clip.
1829
1830         Reviewed by darin
1831
1832         * kcanvas/RenderForeignObject.cpp:
1833         (WebCore::RenderForeignObject::paint):
1834         * kcanvas/RenderSVGContainer.cpp:
1835         (WebCore::RenderSVGContainer::paint):
1836         * kcanvas/RenderSVGImage.cpp:
1837         (WebCore::RenderSVGImage::paint):
1838         * platform/GraphicsContext.h:
1839         * platform/cairo/GraphicsContextCairo.cpp:
1840         (WebCore::GraphicsContext::clip):
1841         * platform/cg/GraphicsContextCG.cpp:
1842         (WebCore::GraphicsContext::savePlatformState):
1843         (WebCore::GraphicsContext::restorePlatformState):
1844         (WebCore::GraphicsContext::clip):
1845         (WebCore::GraphicsContext::addRoundedRectClip):
1846         (WebCore::GraphicsContext::addInnerRoundedRectClip):
1847         (WebCore::GraphicsContext::scale):
1848         (WebCore::GraphicsContext::rotate):
1849         (WebCore::GraphicsContext::translate):
1850         (WebCore::GraphicsContext::concatCTM):
1851         * platform/cg/GraphicsContextPlatformPrivate.h:
1852         (WebCore::GraphicsContextPlatformPrivate::save):
1853         (WebCore::GraphicsContextPlatformPrivate::restore):
1854         (WebCore::GraphicsContextPlatformPrivate::clip):
1855         (WebCore::GraphicsContextPlatformPrivate::scale):
1856         (WebCore::GraphicsContextPlatformPrivate::rotate):
1857         (WebCore::GraphicsContextPlatformPrivate::translate):
1858         (WebCore::GraphicsContextPlatformPrivate::concatCTM):
1859         * platform/qt/GraphicsContextQt.cpp:
1860         (WebCore::GraphicsContext::clip):
1861         (WebCore::GraphicsContext::addInnerRoundedRectClip):
1862         (WebCore::GraphicsContext::addRoundedRectClip):
1863         * rendering/InlineFlowBox.cpp:
1864         (WebCore::InlineFlowBox::paintBackground):
1865         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
1866         * rendering/InlineTextBox.cpp:
1867         (WebCore::InlineTextBox::paintSelection):
1868         (WebCore::InlineTextBox::paintTextMatchMarker):
1869         * rendering/RenderBox.cpp:
1870         (WebCore::RenderBox::paintBackgroundExtended):
1871         * rendering/RenderButton.cpp:
1872         (WebCore::RenderButton::paintObject):
1873         * rendering/RenderFileUploadControl.cpp:
1874         (WebCore::RenderFileUploadControl::paintObject):
1875         * rendering/RenderLayer.cpp:
1876         (WebCore::RenderLayer::beginTransparencyLayers):
1877         (WebCore::setClip):
1878         * rendering/RenderListBox.cpp:
1879         (WebCore::RenderListBox::paintObject):
1880         * rendering/RenderMenuList.cpp:
1881         (WebCore::RenderMenuList::paintObject):
1882         * rendering/RenderTableCell.cpp:
1883         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
1884
1885 2006-10-05  Mitz Pettel  <mitz@webkit.org>
1886
1887         Reviewed by Darin.
1888
1889         - http://bugs.webkit.org/show_bug.cgi?id=10386
1890           Delete RenderImageButton.* and remove references from .vcproj and .bkl files
1891
1892         * CMakeLists.txt:
1893         * WebCore.vcproj/WebCore/WebCore.vcproj:
1894         * WebCoreSources.bkl:
1895         * rendering/RenderImageButton.cpp: Removed.
1896         * rendering/RenderImageButton.h: Removed.
1897
1898 2006-10-05  Mitz Pettel  <opendarwin.org@mitzpettel.com>
1899
1900         Reviewed by Darin.
1901
1902         - http://bugs.webkit.org/show_bug.cgi?id=11067
1903           manual-tests/scrollbar-hittest2.html is invalid
1904
1905         * manual-tests/scrollbar-hittest2.html:
1906
1907 2006-10-05  David Carson  <dacarson@gmail.com>
1908
1909         Reviewed by Darin.
1910
1911         http://bugs.webkit.org/show_bug.cgi?id=11152
1912         Adjust the tokenizer chunk size to be smaller for
1913         mobile devices, and also decrease the yield timer
1914         for the tokenizer so that it can resume earlier.
1915
1916         * html/HTMLTokenizer.cpp:
1917         * config.h:
1918
1919 2006-10-05  Adam Roben  <aroben@apple.com>
1920
1921         Removing accidentally-checked-in do-nothing code.
1922
1923         * html/HTMLInputElement.cpp:
1924         (WebCore::HTMLInputElement::defaultEventHandler):
1925
1926 2006-10-05  David Carson  <dacarson@gmail.com>
1927
1928         Reviewed by Mitz.
1929
1930         http://bugs.webkit.org/show_bug.cgi?id=11158
1931         Initialize class variables
1932
1933         * rendering/RenderLayer.cpp:
1934         (WebCore::RenderLayer::RenderLayer):
1935
1936 2006-10-05  Don Gibson  <dgibson77@gmail.com>
1937
1938         Reviewed by Darin, landed by Adam.
1939
1940         http://bugs.webkit.org/show_bug.cgi?id=11176
1941         Fix win32 build, adapt to Maciej's ResourceLoader changes.
1942
1943         * platform/win/ResourceLoaderWin.cpp:
1944         (WebCore::ResourceLoader::start):
1945
1946 2006-10-05  Marvin Decker  <marv.decker@gmail.com>
1947
1948         Reviewed by Darin.
1949
1950         http://bugs.webkit.org/show_bug.cgi?id=10989
1951         Provide a way for embedders to implement BrowserExtensionWin
1952
1953         * WebCore.vcproj/WebCore/WebCore.vcproj:
1954         * bridge/win/BrowserExtensionWin.cpp: Added.
1955         (BrowserExtensionWin::BrowserExtensionWin):
1956         (BrowserExtensionWin::setTypedIconURL):
1957         (BrowserExtensionWin::setIconURL):
1958         (BrowserExtensionWin::getHistoryLength):
1959         (BrowserExtensionWin::canRunModal):
1960         (BrowserExtensionWin::createNewWindow):
1961         (BrowserExtensionWin::canRunModalNow):
1962         (BrowserExtensionWin::runModal):
1963         (BrowserExtensionWin::goBackOrForward):
1964         (BrowserExtensionWin::historyURL):
1965         * bridge/win/BrowserExtensionWin.h:
1966         * bridge/win/FrameWin.cpp:
1967         (WebCore::FrameWin::createNewWindow):
1968         * bridge/win/FrameWin.h:
1969         * platform/win/TemporaryLinkStubs.cpp:
1970
1971 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
1972
1973         Reviewed by Darin.
1974         
1975         Fixed <rdar://problem/4766987>
1976         
1977         - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
1978         except for file names.
1979         
1980         - fixed RenderLayer to properly tear down scrollbars, removing them from
1981         their parents.
1982
1983         * bindings/js/kjs_window.cpp:
1984         (KJS::showModalDialog):
1985         (KJS::setWindowFeature):
1986         (KJS::parseWindowFeatures):
1987         * bridge/BrowserExtension.h:
1988         * dom/Document.cpp:
1989         (WebCore::Document::setInPageCache):
1990         * html/HTMLFrameElement.cpp:
1991         (WebCore::HTMLFrameElement::init):
1992         (WebCore::HTMLFrameElement::parseMappedAttribute):
1993         * html/HTMLFrameElement.h:
1994         (WebCore::HTMLFrameElement::scrollingMode):
1995         * page/Frame.cpp:
1996         (WebCore::Frame::finishedParsing):
1997         (WebCore::Frame::scrollbarsVisible):
1998         * page/FrameView.cpp:
1999         (WebCore::FrameViewPrivate::FrameViewPrivate):
2000         (WebCore::FrameViewPrivate::reset):
2001         (WebCore::FrameView::~FrameView):
2002         (WebCore::FrameView::resetScrollbars):
2003         (WebCore::FrameView::clear):
2004         (WebCore::FrameView::initScrollbars):
2005         (WebCore::FrameView::applyOverflowToViewport):
2006         (WebCore::FrameView::layout):
2007         (WebCore::FrameView::handleMousePressEvent):
2008         (WebCore::selectCursor):
2009         (WebCore::FrameView::handleMouseMoveEvent):
2010         (WebCore::FrameView::setScrollbarsMode):
2011         (WebCore::FrameView::setVScrollbarMode):
2012         (WebCore::FrameView::setHScrollbarMode):
2013         (WebCore::FrameView::restoreScrollbar):
2014         (WebCore::FrameView::dispatchMouseEvent):
2015         (WebCore::FrameView::scrollbarMoved):
2016         * page/FrameView.h:
2017         * page/MouseEventWithHitTestResults.cpp:
2018         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2019         * page/MouseEventWithHitTestResults.h:
2020         (WebCore::MouseEventWithHitTestResults::scrollbar):
2021         * platform/ScrollBar.cpp:
2022         (WebCore::Scrollbar::Scrollbar):
2023         (WebCore::Scrollbar::setValue):
2024         (WebCore::Scrollbar::setProportion):
2025         (WebCore::Scrollbar::setSteps):
2026         (WebCore::Scrollbar::scroll):
2027         * platform/ScrollBar.h:
2028         (WebCore::):
2029         (WebCore::ScrollbarClient::~ScrollbarClient):
2030         (WebCore::Scrollbar::~Scrollbar):
2031         (WebCore::Scrollbar::orientation):
2032         (WebCore::Scrollbar::controlSize):
2033         (WebCore::Scrollbar::hasPlatformScrollbars):
2034         (WebCore::Scrollbar::client):
2035         * platform/ScrollBarMode.h:
2036         (WebCore::):
2037         * platform/ScrollView.h:
2038         * rendering/RenderBlock.cpp:
2039         (WebCore::RenderBlock::isPointInScrollbar):
2040         * rendering/RenderLayer.cpp:
2041         (WebCore::RenderLayer::RenderLayer):
2042         (WebCore::RenderLayer::~RenderLayer):
2043         (WebCore::RenderLayer::scrollToOffset):
2044         (WebCore::RenderLayer::horizontaScrollbarWidget):
2045         (WebCore::RenderLayer::verticalScrollbarWidget):
2046         (WebCore::RenderLayer::valueChanged):
2047         (WebCore::RenderLayer::createScrollbar):
2048         (WebCore::RenderLayer::destroyScrollbar):
2049         (WebCore::RenderLayer::setHasHorizontalScrollbar):
2050         (WebCore::RenderLayer::setHasVerticalScrollbar):
2051         (WebCore::RenderLayer::verticalScrollbarWidth):
2052         (WebCore::RenderLayer::horizontalScrollbarHeight):
2053         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
2054         * rendering/RenderLayer.h:
2055         (WebCore::RenderLayer::horizontalScrollbar):
2056         (WebCore::RenderLayer::verticalScrollbar):
2057         * rendering/RenderListBox.cpp:
2058         (WebCore::RenderListBox::~RenderListBox):
2059         (WebCore::RenderListBox::calcMinMaxWidth):
2060         (WebCore::RenderListBox::isPointInScrollbar):
2061         (WebCore::RenderListBox::optionAtPoint):
2062         (WebCore::RenderListBox::valueChanged):
2063         * rendering/RenderListBox.h:
2064         * rendering/RenderObject.h:
2065         (WebCore::RenderObject::NodeInfo::scrollbar):
2066         (WebCore::RenderObject::NodeInfo::setScrollbar):
2067
2068 2006-10-05  Don Gibson  <dgibson77@gmail.com>
2069
2070         Reviewed by Adam.
2071
2072         http://bugs.webkit.org/show_bug.cgi?id=11138
2073         Incorrect mouse event generation on Windows
2074
2075         * platform/win/MouseEventWin.cpp:
2076         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2077         (1) Set mouse button even for non-click-related messages.
2078         (2) Track clicks correctly for all buttons, not just the left button.
2079
2080 2006-10-05  Nikolas Zimmermann  <zimmermann@kde.org>
2081
2082         Reviewed and landed by ap.
2083
2084         Fix Qt/Linux build, adapt to Eric's quartz changes and to Maciej's ResourceLoader changes.
2085
2086         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
2087         (WebCore::KRenderingPaintServerLinearGradientQt::renderPath):
2088         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
2089         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
2090         (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
2091         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
2092         (WebCore::KRenderingPaintServerPatternQt::renderPath):
2093         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
2094         (WebCore::KRenderingPaintServerQt::setPenProperties):
2095         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
2096         (WebCore::KRenderingPaintServerSolidQt::setup):
2097         (WebCore::KRenderingPaintServerSolidQt::renderPath):
2098         * kcanvas/device/qt/RenderPathQt.cpp:
2099         (WebCore::getPathStroke):
2100
2101 2006-10-05  Alexey Proskuryakov  <ap@nypop.com>
2102
2103         Reviewed by Darin.
2104
2105         http://bugs.webkit.org/show_bug.cgi?id=11054
2106         REGRESSION: Traditional Chinese encoding in login authentication
2107
2108         1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
2109         2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding
2110         for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
2111
2112         * platform/StreamingTextDecoderICU.cpp:
2113         (WebCore::TextCodecICU::registerEncodingNames):
2114
2115 2006-10-05  Eric Seidel  <eric@eseidel.com>
2116
2117         Reviewed by mjs.
2118
2119         Removed dead code.
2120         Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
2121
2122         * WebCore.xcodeproj/project.pbxproj:
2123         * ksvg2/ecma/GlobalObject.cpp: Removed.
2124         * ksvg2/ecma/GlobalObject.h: Removed.
2125
2126 2006-10-05  Adam Roben  <aroben@apple.com>
2127
2128         Reviewed by Maciej.
2129
2130         Small ResourceLoaderInternal tweak.
2131
2132         * platform/ResourceLoaderInternal.h:
2133         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2134
2135 2006-10-05  Eric Seidel  <eric@eseidel.com>
2136
2137         Reviewed by mjs.
2138
2139         More incremental KCanvas cleanup and optimization.
2140         Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
2141         Optimized dash array usage to not malloc.
2142         Also removed un-needed KSVGRenderingStyle includes.
2143
2144         * kcanvas/KCanvasTreeDebug.cpp:
2145         (WebCore::operator<<):
2146         * kcanvas/RenderPath.cpp:
2147         (WebCore::RenderPath::nodeAtPoint):
2148         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
2149         (WebCore::RenderPath::strokeBBox):
2150         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2151         (WebCore::KRenderingPaintServerGradientQuartz::setup):
2152         (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
2153         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
2154         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2155         (WebCore::KRenderingPaintServerSolidQuartz::setup):
2156         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
2157         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2158         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
2159         * kcanvas/device/quartz/QuartzSupport.mm:
2160         (WebCore::applyStrokeStyleToContext):
2161         * ksvg2/css/SVGRenderStyle.h:
2162         (WebCore::SVGRenderStyle::hasStroke):
2163         (WebCore::SVGRenderStyle::hasFill):
2164         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2165         (WebCore::KSVGPainterFactory::fillPaintServer):
2166         (WebCore::KSVGPainterFactory::strokePaintServer):
2167         * ksvg2/misc/KCanvasRenderingStyle.h:
2168
2169 2006-10-05  Maciej Stachowiak  <mjs@apple.com>
2170
2171         Reviewed by Adam.
2172
2173         - changed ResourceLoader to be refcounted
2174
2175         It keeps a ref on itself while loading as well. This makes
2176         for a much saner memory management model than the previous.
2177
2178         * bridge/mac/WebCoreResourceLoaderImp.mm:
2179         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
2180         * dom/XMLTokenizer.cpp:
2181         (WebCore::openFunc):
2182         * loader/icon/IconLoader.cpp:
2183         (IconLoader::IconLoader):
2184         (IconLoader::~IconLoader):
2185         (IconLoader::startLoading):
2186         (IconLoader::stopLoading):
2187         (IconLoader::receivedData):
2188         * loader/icon/IconLoader.h:
2189         * loader/loader.cpp:
2190         (WebCore::Loader::servePendingRequests):
2191         * platform/ResourceLoader.cpp:
2192         (WebCore::ResourceLoader::create):
2193         (WebCore::ResourceLoader::kill):
2194         * platform/ResourceLoader.h:
2195         * platform/ResourceLoaderInternal.h:
2196         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2197         * platform/mac/ResourceLoaderMac.mm:
2198         (WebCore::ResourceLoader::start):
2199         * xml/XSLTProcessor.cpp:
2200         (WebCore::docLoaderFunc):
2201         * xml/xmlhttprequest.cpp:
2202         (WebCore::XMLHttpRequest::send):
2203         * xml/xmlhttprequest.h:
2204
2205 2006-10-05  Eric Seidel  <eric@eseidel.com>
2206
2207         Reviewed by mjs.
2208
2209         Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
2210         http://bugs.webkit.org/show_bug.cgi?id=11163
2211         
2212         No SVG performance tests yet.
2213
2214         * kcanvas/RenderForeignObject.cpp:
2215         (WebCore::RenderForeignObject::paint):
2216         * kcanvas/RenderSVGContainer.cpp:
2217         (WebCore::RenderSVGContainer::paint):
2218         * kcanvas/RenderSVGImage.cpp:
2219         (WebCore::RenderSVGImage::paint):
2220         * kcanvas/RenderSVGText.cpp:
2221         (WebCore::RenderSVGText::paint):
2222
2223 2006-10-05  Dave Hyatt  <hyatt@apple.com>
2224
2225         Stub out some stuff for widget focusability.
2226
2227         Reviewed by maciej
2228  
2229         * page/FrameView.cpp:
2230         (WebCore::FrameView::dispatchMouseEvent):
2231         * platform/ScrollView.h:
2232         * platform/Widget.h:
2233
2234 2006-10-05  Adam Roben  <aroben@apple.com>
2235
2236         Reviewed by Maciej and Tim H.
2237
2238         Copy some WebKit frame lifetime logic into WebCore -- just a step
2239         along the path to frame lifetime being handled completely in WebCore.
2240
2241         * bridge/mac/FrameMac.mm:
2242         (WebCore::FrameMac::setView): Move platform-independent parts of this
2243         method into Frame.
2244         * page/Frame.cpp:
2245         (WebCore::Frame::setView): Adding platform-independent parts of
2246         FrameMac::setView
2247         (WebCore::Frame::detachChildren): New method to accomplish what
2248         -[WebFrameBridge _detachChildren] currently does.
2249         (WebCore::Frame::clear): Call detachChildren
2250         * page/Frame.h: Add declaration for detachChildren
2251
2252 2006-10-04  Alice Liu  <alice.liu@apple.com>
2253
2254         Reviewed by Darin.
2255
2256         Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query
2257
2258         * xml/xmlhttprequest.cpp:
2259         (WebCore::XMLHttpRequest::setRequestHeader):
2260         removed exception set when the request is not open yet
2261
2262 2006-10-04  Anders Carlsson  <acarlsson@apple.com>
2263
2264         Reviewed by John Sullivan.
2265
2266         <rdar://problem/4654328>
2267         Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
2268         
2269         * loader/PluginDocument.cpp:
2270         (WebCore::PluginTokenizer::writeRawData):
2271         Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
2272
2273 2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
2274
2275         Reviewed by Tim H.
2276
2277         http://bugs.webkit.org/show_bug.cgi?id=11130
2278         Convert "undefined" to AE missing value
2279
2280         * bridge/mac/WebCoreFrameBridge.mm:
2281         (aeDescFromJSValue): return missing value for UndefinedType.
2282
2283 2006-10-03  Dave Hyatt  <hyatt@apple.com>
2284
2285         Scrolling work.  Eliminate convertTo/FromContainingWindow as cross-platform functions.  Add back in
2286         the windowToContents/contentsToWindow functions.
2287         
2288         Reviewed by anders
2289
2290         * bridge/mac/FrameMac.mm:
2291         (WebCore::FrameMac::eventMayStartDrag):
2292         (WebCore::FrameMac::dragHysteresisExceeded):
2293         (WebCore::FrameMac::mouseDown):
2294         (WebCore::FrameMac::shouldDragAutoNode):
2295         (WebCore::FrameMac::sendContextMenuEvent):
2296         * bridge/mac/FrameViewMac.mm:
2297         (WebCore::FrameView::passMousePressEventToScrollbar):
2298         * bridge/mac/WebCoreFrameBridge.mm:
2299         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
2300         * dom/EventTargetNode.cpp:
2301         (WebCore::EventTargetNode::dispatchMouseEvent):
2302         (WebCore::EventTargetNode::dispatchWheelEvent):
2303         * page/Frame.cpp:
2304         (WebCore::Frame::selectClosestWordFromMouseEvent):
2305         (WebCore::Frame::handleMousePressEventTripleClick):
2306         (WebCore::Frame::handleMousePressEventSingleClick):
2307         (WebCore::Frame::handleMouseMoveEvent):
2308         (WebCore::Frame::handleMouseReleaseEvent):
2309         * page/FrameView.cpp:
2310         (WebCore::FrameView::handleMousePressEvent):
2311         (WebCore::FrameView::handleMouseDoubleClickEvent):
2312         (WebCore::selectCursor):
2313         (WebCore::FrameView::handleMouseMoveEvent):
2314         (WebCore::FrameView::handleMouseReleaseEvent):
2315         (WebCore::FrameView::dispatchDragEvent):
2316         (WebCore::FrameView::prepareMouseEvent):
2317         (WebCore::FrameView::handleWheelEvent):
2318         * page/FrameView.h:
2319         * platform/ScrollBar.cpp:
2320         (WebCore::ScrollBar::setValue):
2321         * platform/ScrollView.h:
2322         * platform/Widget.h:
2323         (WebCore::Widget::scrolled):
2324         * platform/mac/ScrollViewMac.mm:
2325         (WebCore::ScrollView::contentsToWindow):
2326         (WebCore::ScrollView::windowToContents):
2327         (WebCore::ScrollView::scrollbarUnderMouse):
2328         * platform/mac/WidgetMac.mm:
2329         * rendering/RenderLayer.cpp:
2330         (WebCore::RenderLayer::resize):
2331         (WebCore::RenderLayer::positionScrollbars):
2332         * rendering/RenderReplaced.cpp:
2333         (WebCore::RenderReplaced::shouldPaint):
2334         * rendering/RenderView.cpp:
2335         * rendering/RenderView.h:
2336         * rendering/RenderWidget.cpp:
2337         (WebCore::RenderWidget::setWidget):
2338
2339 2006-09-26  David Smith  <catfish.man@gmail.com>
2340
2341         Reviewed by Timothy.
2342
2343         http://bugs.webkit.org/show_bug.cgi?id=3723
2344         Add -scrollDOMRangeToVisible:
2345
2346         No automated tests are possible as this code path isn't reachable from JavaScript.
2347
2348         * bridge/mac/WebCoreFrameBridge.h:
2349         * bridge/mac/WebCoreFrameBridge.mm:
2350         (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
2351
2352 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
2353
2354         Reviewed by Timothy.
2355
2356         <http://bugs.webkit.org/show_bug.cgi?id=10338>
2357         When contentEditable, cursor doesn't change to hand
2358         
2359         Allow the behaviour of editable links to be specified by a WebPreference
2360         The preference WebKitEditableLinkBehavior has four options:
2361          - AlwaysLive: Safari 2.0 behaviour
2362          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
2363          - LiveWhenNotFocused: Editable links are live only when their editable block is not
2364              focused, or when the shift key is pressed
2365          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
2366          
2367         No layout tests, just a modification of a manual-test as it isn't possible to test
2368         this automatically.
2369
2370         * bridge/mac/WebCoreSettings.h:
2371         * bridge/mac/WebCoreSettings.mm:
2372         (-[WebCoreSettings setEditableLinkBehavior:]):
2373         (-[WebCoreSettings editableLinkBehavior]):
2374         * html/HTMLAnchorElement.cpp:
2375         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
2376         (WebCore::HTMLAnchorElement::defaultEventHandler):
2377         (WebCore::HTMLAnchorElement::setActive):
2378         * html/HTMLAnchorElement.h:
2379         * manual-tests/contenteditable-link.html:
2380         * page/FrameView.cpp:
2381         (WebCore::nodeIsNotBeingEdited):
2382         (WebCore::selectCursor):
2383         * page/Settings.h:
2384         (WebCore::Settings::):
2385         (WebCore::Settings::Settings):
2386         (WebCore::Settings::editableLinkBehavior):
2387         (WebCore::Settings::setEditableLinkBehavior):
2388
2389 2006-10-03  Beth Dakin  <bdakin@apple.com>
2390
2391         Reviewed Darin.
2392
2393         No test cases needed.
2394
2395         Implemented a version of StringImpl::append that takes a UChar* and 
2396         a length.
2397
2398         * platform/StringImpl.cpp:
2399         (WebCore::StringImpl::append):
2400         (WebCore::StringImpl::insert): Call new append instead of making a 
2401         new StringImpl.
2402         * platform/StringImpl.h:
2403
2404 2006-10-03  MorganL  <morganl.webkit@yahoo.com>
2405
2406         Reviewed by Darin.
2407
2408         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
2409         HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
2410
2411         * platform/win/ResourceLoaderWin.cpp:
2412         (WebCore::ResourceLoader::onHandleCreated):
2413
2414 2006-10-02  Geoffrey Garen  <ggaren@apple.com>
2415
2416         Feared, loathed, reviewed by Darin.
2417
2418         More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach 
2419         into FRAME, plus other cleanup.
2420         
2421         No new behavior, so no new test. Layout tests pass. Basic browsing and
2422         Mail editing seem to work.
2423         
2424         * dom/Node.cpp:
2425         (WebCore::Node::detach): Removed random commented-out code.
2426         * html/HTMLFrameElement.cpp:
2427         (WebCore::HTMLFrameElement::isURLAllowed): 
2428         (1) Removed reference to FrameView, to dissociate frame loading from rendering.
2429         (2) Renamed newURL to completeURL because the difference between newURL
2430         and URLString is that newURL is a KURL that is the complete version of URLString,
2431         not that it is new.
2432         (WebCore::HTMLFrameElement::willRemove): 
2433         (1) Removed close() call and moved close() code into willRemove(), also removing 
2434         close() call from detach(), since willRemove is the well-defined place 
2435         from DOM tear-down, not detach().
2436         (2) Removed manual renderer detach code because the DOM is not responsible
2437         for managing the render tree. I confirmed that this change not
2438         regress <rdar://problem/4132581>.
2439         (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
2440         lost their content frames after being removed from the DOM. That's our 
2441         current behavior, but it's going to change in future rounds of refactoring.
2442         This also fixes <rdar://problem/4750835>.
2443         (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
2444         attach/detach, because the render tree should not be in charge of deciding
2445         when to load.
2446         * html/HTMLFrameElement.h:
2447         * html/HTMLIFrameElement.cpp:
2448         (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
2449         because the renderer is a renderPartObject, not a renderPart.
2450         * html/HTMLIFrameElement.h:
2451
2452 2006-10-03  Mark Rowe  <bdash@webkit.org>
2453
2454         Reviewed by Mitz.
2455
2456         http://bugs.webkit.org/show_bug.cgi?id=11137
2457         Bug 11137: GdkLauncher dies with "pure virtual method called" if
2458         window is closed while page still loading
2459
2460         * platform/gdk/FrameGdk.cpp:
2461         (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
2462         methods to be called before the FrameGdk portion of "this" is torn down.
2463
2464 2006-10-03  Adam Roben  <aroben@apple.com>
2465
2466         Reviewed by Darin.
2467
2468         Handle tab key presses in the DOM.
2469
2470         * dom/EventTargetNode.cpp:
2471         (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
2472         * page/FrameView.cpp:
2473         (WebCore::FrameView::advanceFocus): Rename and reimplement
2474         focusNextPrevNode. Now we just call Element::focus().
2475         * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
2476         it public.
2477
2478 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
2479
2480         Reviewed by mjs
2481         
2482         <rdar://problem/4760612>
2483         TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
2484         
2485         No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
2486         
2487         * dom/Range.cpp:
2488         (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming 
2489         positions are non-null since most of it's callers would be in a bad state if the positions 
2490         were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.  
2491         Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it 
2492         from entering compareBoundaryPoints and hitting the assert.
2493
2494 2006-10-03  Adele Peterson  <adele@apple.com>
2495
2496         Reviewed by Geoff.
2497
2498         Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
2499
2500         * html/HTMLSelectElement.cpp:
2501         (WebCore::HTMLSelectElement::recalcStyle):
2502         (WebCore::HTMLSelectElement::isKeyboardFocusable):
2503         (WebCore::HTMLSelectElement::isMouseFocusable):
2504         (WebCore::HTMLSelectElement::createRenderer):
2505         (WebCore::HTMLSelectElement::setRecalcListItems):
2506         (WebCore::HTMLSelectElement::notifyOptionSelected):
2507         (WebCore::HTMLSelectElement::defaultEventHandler):
2508
2509 2006-10-04  Darin Adler  <darin@apple.com>
2510
2511         Reviewed by Geoff.
2512
2513         - fix http://bugs.webkit.org/show_bug.cgi?id=11132
2514           Caret disappears when you're typing
2515
2516         * editing/SelectionController.cpp:
2517         (WebCore::SelectionController::setSelection): Remove unnecessary call to
2518         clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
2519         (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
2520         to false so we can get the old caret repaint rect. Later we need to change the
2521         design so getting the rect doesn't have a side effect of causing a layout without
2522         invalidation.
2523
2524 2006-10-03  David Harrison  <harrison@apple.com>
2525
2526         Reviewed by Maciej.
2527
2528         <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
2529
2530         Updated test:
2531         * fast/text/justified-text-rect.html
2532
2533         * bridge/mac/WebCoreFrameBridge.mm:
2534         (-[WebCoreFrameBridge convertToNSRange:]):
2535         (-[WebCoreFrameBridge convertToDOMRange:]):
2536         Make the selection's root editable element (or the document itself) be
2537         the basis for NSRange conversions. This supports "shadow DOM" like
2538         that for text fields and text areas.
2539         
2540         * editing/CompositeEditCommand.cpp:
2541         (WebCore::CompositeEditCommand::moveParagraphs):
2542         Pass the document element as the scope.
2543         
2544         * editing/TextIterator.cpp:
2545         (WebCore::TextIterator::rangeFromLocationAndLength):
2546         Make the first parameter the scope.
2547         
2548         * editing/TextIterator.h:
2549         Make the first parameter of rangeFromLocationAndLength() the scope.
2550
2551 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
2552
2553         Reviewed by Eric.
2554
2555         Fix Qt/Linux build.
2556
2557         * CMakeLists.txt: Add counter related files.
2558
2559 2006-10-03  Mark Rowe  <bdash@webkit.org>
2560
2561         Reviewed by Eric.
2562
2563         http://bugs.webkit.org/show_bug.cgi?id=10981
2564         Linux/GDK build fixes
2565
2566         Based on a patch by Krzysztof Kowalczyk.
2567
2568         * WebCoreSources.bkl:
2569         * platform/gdk/FrameGdk.cpp:
2570         (WebCore::doScroll):
2571         (WebCore::FrameGdk::handleGdkEvent):
2572         * platform/gdk/PlatformScrollBar.h: Added.
2573         (WebCore::PlatformScrollBar::isWidget):
2574         * platform/gdk/ScrollViewGdk.cpp:
2575         * platform/gdk/TemporaryLinkStubs.cpp:
2576         (FrameView::passMousePressEventToScrollbar):
2577         (FrameView::passMousePressEventToSubframe):
2578         (FrameView::passMouseReleaseEventToSubframe):
2579         (FrameView::passMouseMoveEventToSubframe):
2580         (FrameView::passWheelEventToSubframe):
2581         (Cursor::Cursor):
2582         (Widget::invalidate):
2583         (Widget::invalidateRect):
2584         (ScrollView::wheelEvent):
2585         (ScrollView::convertToContainingWindow):
2586         (ScrollView::convertFromContainingWindow):
2587         (GraphicsContext::clip):
2588         (PlatformScrollBar::PlatformScrollBar):
2589         (PlatformScrollBar::updateThumbPosition):
2590         (PlatformScrollBar::updateThumbProportion):
2591         (ScrollBar::ScrollBar):
2592         (ScrollBar::setProportion):
2593         (WebCore::supportedKeySizes):
2594         (WebCore::signedPublicKeyAndChallengeString):
2595         * platform/gdk/WheelEventGdk.cpp:
2596         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2597         * platform/gdk/WidgetGdk.cpp:
2598         (WebCore::Widget::convertToContainingWindow):
2599         (WebCore::Widget::convertFromContainingWindow):
2600
2601 2006-10-02  Adam Roben  <aroben@apple.com>
2602
2603         Reviewed by Maciej.
2604
2605         Let Windows determine which mouse button is pressed.
2606
2607         * platform/PlatformMouseEvent.h: Add message parameter to constructor.
2608         * platform/win/MouseEventWin.cpp:
2609         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
2610         parameter to determine which mouse button is pressed.
2611
2612 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
2613
2614         Reviewed by anders
2615         
2616         Build fix
2617         
2618         * editing/SelectionController.cpp:
2619         (WebCore::SelectionController::empty):
2620         * editing/SelectionController.h:
2621
2622 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
2623
2624         Reviewed by john
2625         
2626         <rdar://problem/4755287>
2627         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
2628
2629         * editing/markup.cpp:
2630         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced 
2631         elements).  Don't skip blocks that aren't containers (like horizontal rules).
2632
2633 2006-10-03  Darin Adler  <darin@apple.com>
2634
2635         Reviewed by Justin Garcia.
2636
2637         - correct mistaken code that would restart blinking every
2638           time "invalidateSelection" is called even if the caret
2639           has not moved
2640
2641         * editing/SelectionController.h:
2642         * editing/SelectionController.cpp:
2643         (WebCore::SelectionController::setSelection): Update for name change.
2644         (WebCore::SelectionController::recomputeCaretRect): New function.
2645         Computes caret rect and does any necessary invalidation if the rect
2646         changes.
2647         (WebCore::SelectionController::invalidateCaretRect): Renamed from
2648         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
2649         calls recomputeCaretRect as a side effect.
2650
2651         * page/Frame.cpp:
2652         (WebCore::Frame::invalidateSelection): Remove unneeded call to
2653         clearCaretRectIfNeeded.
2654         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
2655         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
2656         recomputeCaretRect function and not restart blinking if caret has
2657         not changed position.
2658         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
2659         are not needed since selectionLayoutChanged already checks these.
2660
2661         * page/FramePrivate.h: Removed unused m_blinkCaret.
2662
2663 2006-10-02  Beth Dakin  <bdakin@apple.com>
2664
2665         Reviewed by Adam.
2666
2667         Build fix. Add counters to vcproj.
2668
2669         * WebCore.vcproj/WebCore/WebCore.vcproj:
2670
2671 2006-10-02  Brady Eidson  <beidson@apple.com>
2672
2673         Reviewed by Adele
2674
2675         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
2676         icon data out because we don't correctly check SQL error conditions.
2677
2678         * loader/icon/IconDataCache.cpp:
2679         (WebCore::IconDataCache::writeToDatabase):
2680
2681 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
2682
2683         Reviewed by Hyatt.
2684
2685         Added method to find out whether a layout has occurred.
2686
2687         * page/FrameView.cpp:
2688         (WebCore::FrameView::didFirstLayout):
2689         * page/FrameView.h:
2690
2691 2006-10-02  Beth Dakin  <bdakin@apple.com>
2692
2693         Reviewed by Darin.
2694
2695         Initial implementation of CSS2 counters. See http://
2696         bugs.webkit.org/show_bug.cgi?id=4980 for more details.
2697
2698         * WebCore.xcodeproj/project.pbxproj:
2699         * css/CSSComputedStyleDeclaration.cpp: 
2700         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 
2701         the increment/reset list now that this is implemented.
2702         * css/CSSPrimitiveValue.cpp:
2703         (WebCore::CSSPrimitiveValue::cssText): 
2704         * css/Counter.h:
2705         (WebCore::Counter::Counter):
2706         (WebCore::Counter::~Counter):
2707         (WebCore::Counter::identifier):
2708         (WebCore::Counter::listStyle):
2709         (WebCore::Counter::separator):
2710         (WebCore::Counter::listStyleNumber):
2711         (WebCore::Counter::setIdentifier):
2712         (WebCore::Counter::setListStyle):
2713         (WebCore::Counter::setSeparator):
2714         * css/cssparser.cpp:
2715         (WebCore::CSSParser::addProperty): Take care of reset/increment
2716         (WebCore::CSSParser::parseValue):
2717         (WebCore::CSSParser::parseContent): content can now take counters
2718         (WebCore::CSSParser::parseCounterContent): Parse counter() and 
2719         counters()
2720         (WebCore::CSSParser::parseCounter): Parse counter-reset and 
2721         counter-increment
2722         * css/cssparser.h:
2723         * css/cssstyleselector.cpp:
2724         (WebCore::CSSStyleSelector::matchUARules):
2725         (WebCore::CSSStyleSelector::applyProperty):
2726         * platform/PlatformString.h:
2727         * platform/String.cpp:
2728         (WebCore::String::insert): Implemented a version of insert that 
2729         accepts a UChar* and a length.
2730         * platform/StringImpl.cpp:
2731         (WebCore::StringImpl::insert): Same as above.
2732         * platform/StringImpl.h:
2733         * rendering/CounterListItem.h: Added.
2734         * rendering/CounterNode.cpp: Added.
2735         (WebCore::CounterNode::CounterNode):
2736         (WebCore::CounterNode::insertAfter):
2737         (WebCore::CounterNode::removeChild):
2738         (WebCore::CounterNode::remove):
2739         (WebCore::CounterNode::setUsesSeparator):
2740         (WebCore::CounterNode::recountAndGetNext):
2741         (WebCore::CounterNode::recountTree):
2742         (WebCore::CounterNode::setSelfDirty):
2743         (WebCore::CounterNode::setParentDirty):
2744         * rendering/CounterNode.h: Added.
2745         (WebCore::CounterNode::~CounterNode):
2746         (WebCore::CounterNode::parent):
2747         (WebCore::CounterNode::previousSibling):
2748         (WebCore::CounterNode::nextSibling):
2749         (WebCore::CounterNode::firstChild):
2750         (WebCore::CounterNode::lastChild):
2751         (WebCore::CounterNode::value):
2752         (WebCore::CounterNode::setValue):
2753         (WebCore::CounterNode::count):
2754         (WebCore::CounterNode::setCount):
2755         (WebCore::CounterNode::setHasSeparator):
2756         (WebCore::CounterNode::isReset):
2757         (WebCore::CounterNode::hasSeparator):
2758         (WebCore::CounterNode::willNeedLayout):
2759         (WebCore::CounterNode::setWillNeedLayout):
2760         (WebCore::CounterNode::isRoot):
2761         (WebCore::CounterNode::setRenderer):
2762         (WebCore::CounterNode::renderer):
2763         * rendering/CounterResetNode.cpp: Added.
2764         (WebCore::CounterResetNode::CounterResetNode):
2765         (WebCore::CounterResetNode::insertAfter):
2766         (WebCore::CounterResetNode::removeChild):
2767         (WebCore::CounterResetNode::recountAndGetNext):
2768         (WebCore::CounterResetNode::setParentDirty):
2769         (WebCore::CounterResetNode::updateTotal):
2770         * rendering/CounterResetNode.h: Added.
2771         (WebCore::CounterResetNode::firstChild):
2772         (WebCore::CounterResetNode::lastChild):
2773         (WebCore::CounterResetNode::isReset):
2774         (WebCore::CounterResetNode::total):
2775         * rendering/RenderContainer.cpp:
2776         (WebCore::RenderContainer::updatePseudoChildForObject): Account for 
2777         counter content.
2778         * rendering/RenderCounter.cpp: Added.
2779         (WebCore::RenderCounter::RenderCounter):
2780         (WebCore::RenderCounter::layout):
2781         (WebCore::toRoman):
2782         (WebCore::toLetterString):
2783         (WebCore::toHebrew):
2784         (WebCore::RenderCounter::convertValueToType):
2785         (WebCore::RenderCounter::calcMinMaxWidth):
2786         * rendering/RenderCounter.h: Added.
2787         (WebCore::RenderCounter::renderName):
2788         (WebCore::RenderCounter::isCounter):
2789         * rendering/RenderObject.cpp:
2790         (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to 
2791         maps of CounterNodes
2792         (WebCore::RenderObject::RenderObject):
2793         (WebCore::RenderObject::destroy): Destroy the maps.
2794         (WebCore::RenderObject::findCounter): Finds/creates counters.
2795         * rendering/RenderObject.h:
2796         (WebCore::RenderObject::isCounter):
2797         * rendering/RenderStyle.cpp:
2798         (WebCore::StyleVisualData::StyleVisualData):
2799         (WebCore::RenderStyle::arenaDelete):
2800         (WebCore::RenderStyle::RenderStyle):
2801         (WebCore::RenderStyle::diff):
2802         (WebCore::RenderStyle::setContent):
2803         (WebCore::ContentData::clearContent):
2804         (WebCore::RenderStyle::counterDataEquivalent):
2805         (WebCore::hasCounter):
2806         (WebCore::RenderStyle::hasCounterReset):
2807         (WebCore::RenderStyle::hasCounterIncrement):
2808         (WebCore::readCounter):
2809         (WebCore::RenderStyle::counterReset):
2810         (WebCore::RenderStyle::counterIncrement):
2811         * rendering/RenderStyle.h:
2812         (WebCore::StyleVisualData::operator==):
2813         (WebCore::CounterData::CounterData):
2814         (WebCore::CounterData::identifier):
2815         (WebCore::CounterData::listStyle):
2816         (WebCore::CounterData::separator):
2817         (WebCore::ContentData::contentCounter):
2818         (WebCore::ContentData::):
2819         (WebCore::RenderStyle::counterIncrement):
2820         (WebCore::RenderStyle::counterReset):
2821         (WebCore::RenderStyle::setCounterIncrement):
2822         (WebCore::RenderStyle::setCounterReset):
2823         (WebCore::RenderStyle::setCounterResetList):
2824         (WebCore::RenderStyle::setCounterIncrementList):
2825         (WebCore::RenderStyle::counterResetValueList):
2826         (WebCore::RenderStyle::counterIncrementValueList):
2827
2828 2006-10-02  Adele Peterson  <adele@apple.com>
2829
2830         Reviewed by Adam.
2831
2832         - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
2833
2834         There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
2835         by using "-webkit-appearance:none".
2836
2837         * css/html4.css:
2838
2839 2006-10-02  David Harrison  <harrison@apple.com>
2840
2841         Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
2842         addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
2843         Left the layout test.
2844         
2845         * rendering/bidi.cpp:
2846         (WebCore::checkMidpoints):
2847
2848 2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>
2849
2850         Reviewed by eseidel.  Landed by eseidel.
2851
2852         Fix Qt/Linux build.
2853
2854         * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
2855         (WebCore::supportedKeySizes):
2856
2857 2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>
2858
2859         Reviewed by eseidel & mjs.  Landed by eseidel.
2860
2861         Fix Qt/Linux build with older gcc 3.3.4.
2862         http://bugs.webkit.org/show_bug.cgi?id=11116
2863
2864         As discussed with Maciej, the GCC_ROOT_NS_HACK
2865         can be completely removed, as well as the friendship
2866         between cacheGlobalObject & the JS* objects.
2867
2868         * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
2869         * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
2870         (png_read_filter_row_mmx_avg):
2871         * platform/image-decoders/png/pngvcrd.c: Ditto.
2872         (png_mmx_support):
2873         (png_read_filter_row_mmx_avg):
2874
2875 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
2876
2877         Rubber stamped by Alexey.
2878
2879         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes
2880
2881         * css/CSSGrammar.y:
2882
2883 2006-10-01  Eric Seidel  <eric@webkit.org>
2884
2885         Reviewed by mjs.
2886
2887         Eliminate a few more hotspots in SVG drawing code.
2888         
2889         No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)
2890
2891         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2892         (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
2893         * platform/mac/ColorMac.mm:
2894         (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance
2895
2896 2006-10-01  Geoffrey Garen  <ggaren@apple.com>
2897
2898         Reviewed by Maciej.
2899         
2900         More frame/iframe merging.
2901         
2902         - Removed needWidgetUpdate and related code. needWidgetUpdate is always
2903         false, so this was dead code.
2904         - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
2905         than attach(), is the correct place for setInViewSourceMode, because
2906         openURL() is the function that creates our frame.
2907         - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
2908         code that did the same thing in other places.
2909         - Made FRAME's attach() method suffuciently generic so that IFRAME could
2910         call up to it, rather than skipping its superclass and calling up directly 
2911         to ELEMENT.
2912         - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
2913         - Replaced ad hoc frame loading code in FRAME::attach() with call to
2914         openURL(), the designated frame loading function.
2915
2916         Layout tests pass. I added a layout test for viewsource mode, since I
2917         broke it in the course of writing this patch.
2918
2919 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
2920
2921         Reviewed by Geoff.
2922
2923         * dom/Document.cpp:
2924         (WebCore::Document::recalcStyleSelector):
2925         * dom/Document.h:
2926         Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
2927         
2928         * dom/Node.h:
2929         Remove DeprecatedStringList class forward declaration.
2930         
2931         * editing/markup.cpp:
2932         Include DeprecatedStringList.h here since it's not included by Document.h anymore.
2933         
2934         * kcanvas/KCanvasTreeDebug.cpp:
2935         * kcanvas/KCanvasTreeDebug.h:
2936         Remove unused functions.
2937         
2938         * loader/loader.cpp:
2939         * page/Frame.cpp:
2940         * page/Frame.h:
2941         * page/FrameView.h:
2942         Fixup DeprecatedStringList.h includes.
2943
2944 2006-09-30  David Harrison  <harrison@apple.com>
2945
2946         Reviewed by John Sullivan.
2947
2948         <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
2949
2950         Problem was that the decision to trim was based only on whether the character
2951         is a soft hyphen, which caused pretty much any Japanese character to go.
2952         Changed to decide based on whether the character is ignorable whitespace.
2953         
2954         Test:
2955         * fast/text/international/wrap-CJK-001.html
2956
2957         * rendering/bidi.cpp:
2958         (WebCore::isTrimmableChar):
2959         New. Checks whether character is whitespace that can be ignored
2960         according to the text node's style.
2961         trimmed from the end of wrapped line.
2962         (WebCore::checkMidpoints):
2963         Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
2964
2965 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
2966
2967         Reviewed by Mitz Pettel.
2968
2969         Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
2970
2971         * ksvg2/svg/SVGColor.cpp:
2972         (WebCore::SVGColor::setRGBColor):
2973         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2974         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2975         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
2976         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2977         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
2978         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
2979         (SVGFESpecularLightingElement::parseMappedAttribute):
2980         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2981         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
2982         * ksvg2/svg/SVGLengthList.cpp:
2983         * ksvg2/svg/SVGNumberList.cpp:
2984         (SVGNumberList::parse):
2985         * ksvg2/svg/SVGNumberList.h:
2986         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
2987         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
2988         * ksvg2/svg/SVGStringList.cpp:
2989         (WebCore::SVGStringList::reset):
2990         * ksvg2/svg/SVGStringList.h:
2991         * ksvg2/svg/SVGTransformable.cpp:
2992         (SVGTransformable::parseTransformAttribute):
2993
2994 2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>
2995
2996         Reviewed by Eric, tweaked and landed by ap.
2997
2998         Fix Qt/Linux build.
2999
3000         * CMakeLists.txt:
3001         * platform/qt/PlatformScrollBar.h:
3002         * platform/qt/TemporaryLinkStubs.cpp:
3003         (WebCore::ScrollBar::ScrollBar):
3004         (WebCore::PlatformScrollBar::PlatformScrollBar):
3005         (FrameView::passMousePressEventToSubframe):
3006         (FrameView::passMouseMoveEventToSubframe):
3007         (FrameView::passMouseReleaseEventToSubframe):
3008         (FrameView::passWheelEventToSubframe):
3009         (FrameView::passMousePressEventToScrollbar):
3010         * ksvg2/svg/SVGDocument.h:
3011
3012 2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3013
3014         Reviewed by Darin.
3015
3016         Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
3017         REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
3018
3019         No test case added (probably requires new DumpRenderTree functionality)
3020
3021         * rendering/RenderImage.cpp:
3022         (WebCore::RenderImage::imageChanged): Added early return if the document is
3023         being destroyed.
3024
3025 2006-10-01  Graham Dennis  <graham.dennis@gmail.com>
3026
3027         Reviewed by Hyatt.
3028
3029         Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
3030         REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
3031         
3032         Make sure we only break after a space (and not any other valid line-break) if
3033         the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
3034         I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
3035         twice in quick succession.
3036
3037         * rendering/bidi.cpp:
3038         (WebCore::RenderBlock::findNextLineBreak): 
3039
3040 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
3041
3042         Reviewed by Maciej and Darin.
3043
3044         http://bugs.webkit.org/show_bug.cgi?id=4372
3045         JavaScript document.write page form does not submit in Safari
3046
3047         Test: fast/forms/document-write.html
3048
3049         * page/Frame.cpp:
3050         (WebCore::Frame::submitForm): Don't check for parsing().
3051
3052 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
3053
3054         Build fix.
3055
3056         * bridge/mac/FrameViewMac.mm: Add missing #imports.
3057
3058 2006-10-01  Dave Hyatt  <hyatt@apple.com>
3059
3060         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
3061        
3062         Reviewed by mitz
3063
3064         * bridge/mac/FrameMac.mm:
3065         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
3066         * bridge/mac/FrameViewMac.mm:
3067         (WebCore::FrameView::passMousePressEventToScrollbar):
3068         * page/FrameView.cpp:
3069         (WebCore::FrameView::handleMousePressEvent):
3070         (WebCore::FrameView::setMousePressed):
3071         * page/FrameView.h:
3072         * platform/win/TemporaryLinkStubs.cpp:
3073         (FrameView::passMousePressEventToScrollbar):
3074
3075 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
3076
3077         Reviewed by Darin.
3078
3079         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
3080         Add more SVG Objective-C DOM bindings
3081
3082         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
3083           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
3084           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
3085           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
3086           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument, 
3087           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
3088
3089         * DerivedSources.make:
3090         * WebCore.xcodeproj/project.pbxproj:
3091         * bindings/objc/DOMInternal.h:
3092         * bindings/objc/DOMSVG.h:
3093         * bindings/scripts/CodeGeneratorObjC.pm:
3094         * ksvg2/svg/SVGAElement.idl:
3095         * ksvg2/svg/SVGAnimateColorElement.idl:
3096         * ksvg2/svg/SVGAnimateElement.idl:
3097         * ksvg2/svg/SVGAnimateTransformElement.idl:
3098         * ksvg2/svg/SVGAnimatedPathData.idl:
3099         * ksvg2/svg/SVGAnimatedPoints.idl:
3100         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
3101         * ksvg2/svg/SVGAnimationElement.idl:
3102         * ksvg2/svg/SVGCircleElement.idl:
3103         * ksvg2/svg/SVGClipPathElement.idl:
3104         * ksvg2/svg/SVGColor.idl:
3105         * ksvg2/svg/SVGCursorElement.idl:
3106         * ksvg2/svg/SVGDefsElement.idl:
3107         * ksvg2/svg/SVGDescElement.idl:
3108         * ksvg2/svg/SVGDocument.idl:
3109         * ksvg2/svg/SVGEllipseElement.idl:
3110         * ksvg2/svg/SVGPointList.idl:
3111         * ksvg2/svg/SVGPreserveAspectRatio.idl:
3112         * ksvg2/svg/SVGRect.idl:
3113         * ksvg2/svg/SVGSVGElement.idl:
3114
3115 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
3116
3117         Reviewed by Adele.
3118
3119         - fix build
3120
3121         * platform/FloatRect.h:
3122         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
3123         but more appropriate for path-type stuff.
3124         * platform/cg/PathCG.cpp:
3125         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
3126
3127 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
3128
3129         Reviewed by Darin.
3130
3131         http://bugs.webkit.org/show_bug.cgi?id=11011
3132         External CSS is parsed as iso-8859-1 even though the main document is utf-8
3133
3134         Test: fast/encoding/css-charset-default.xhtml
3135
3136         * loader/CachedResourceClient.h:
3137         (WebCore::CachedResourceClient::setCSSStyleSheet):
3138         (WebCore::CachedResourceClient::setXSLStyleSheet):
3139         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
3140         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
3141
3142         * css/CSSImportRule.cpp:
3143         (WebCore::CSSImportRule::setCSSStyleSheet):
3144         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
3145         * css/CSSImportRule.h:
3146
3147         * css/CSSStyleSheet.cpp:
3148         (WebCore::CSSStyleSheet::CSSStyleSheet):
3149         * css/CSSStyleSheet.h:
3150         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
3151         member. Changed some String parameters to const String&.
3152
3153         * css/StyleSheet.cpp:
3154         (WebCore::StyleSheet::StyleSheet):
3155         * css/StyleSheet.h:
3156         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
3157
3158         * css/StyleSheetList.cpp:
3159         (WebCore::StyleSheetList::length):
3160         (WebCore::StyleSheetList::item):
3161         * css/StyleSheetList.h:
3162         Special-casing implicit stylesheets seemed to be dead code, removed.
3163
3164         * dom/Document.cpp:
3165         (WebCore::Document::setCSSStyleSheet):
3166         (WebCore::Document::recalcStyleSelector):
3167         * dom/Document.h:
3168         Renamed setStyleSheet() to setCSSStyleSheet().
3169
3170         * dom/ProcessingInstruction.cpp:
3171         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
3172         (WebCore::ProcessingInstruction::setCSSStyleSheet):
3173         (WebCore::ProcessingInstruction::setXSLStyleSheet):
3174         (WebCore::ProcessingInstruction::parseStyleSheet):
3175         * dom/ProcessingInstruction.h:
3176
3177         * html/HTMLLinkElement.cpp:
3178         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute 
3179         is not specified.
3180         (WebCore::HTMLLinkElement::setCSSStyleSheet):
3181         * html/HTMLLinkElement.h:
3182
3183         * html/HTMLStyleElement.cpp:
3184         (WebCore::HTMLStyleElement::childrenChanged):
3185         * ksvg2/svg/SVGStyleElement.cpp:
3186         (WebCore::SVGStyleElement::childrenChanged):
3187         Inherit URL and charset from the document.
3188
3189         * loader/Cache.cpp:
3190         (WebCore::Cache::requestCSSStyleSheet):
3191         * loader/Cache.h:
3192         Adjust for setStyleSheet() renaming.
3193
3194         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
3195         * loader/CachedCSSStyleSheet.cpp:
3196         (WebCore::CachedCSSStyleSheet::ref):
3197         (WebCore::CachedCSSStyleSheet::deref):
3198         (WebCore::CachedCSSStyleSheet::checkNotify):
3199         Pass the encoding to setCSSStyleSheet().
3200
3201         * loader/CachedXSLStyleSheet.cpp:
3202         (WebCore::CachedXSLStyleSheet::ref):
3203         (WebCore::CachedXSLStyleSheet::checkNotify):
3204         * loader/DocLoader.cpp:
3205         (WebCore::DocLoader::requestCSSStyleSheet):
3206         * loader/DocLoader.h:
3207         * page/Frame.cpp:
3208         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
3209         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
3210         * xml/XSLImportRule.cpp:
3211         (WebCore::XSLImportRule::setXSLStyleSheet):
3212         (WebCore::XSLImportRule::loadSheet):
3213         * xml/XSLImportRule.h:
3214         Adjust for setStyleSheet() renaming.
3215
3216 2006-09-30  Rob Buis  <buis@kde.org>
3217
3218         Reviewed by eseidel.
3219
3220         http://bugs.webkit.org/show_bug.cgi?id=11096
3221         Hit testing for polylines fails
3222
3223         Fix Path::contains so it handles filled, non-closed paths too.
3224
3225         * platform/cg/PathCG.cpp:
3226         (WebCore::Path::contains):
3227
3228 2006-09-30  Dave Hyatt  <hyatt@apple.com>
3229
3230         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
3231         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
3232         subframes while the mouse is down.
3233       
3234         Reviewed by mitzpettel
3235
3236         * bridge/mac/FrameMac.h:
3237         * bridge/mac/FrameMac.mm:
3238         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
3239         (WebCore::FrameMac::passWheelEventToWidget):
3240         * bridge/mac/FrameViewMac.mm:
3241         (WebCore::FrameView::passMousePressEventToSubframe):
3242         (WebCore::FrameView::passMouseMoveEventToSubframe):
3243         (WebCore::FrameView::passMouseReleaseEventToSubframe):
3244         (WebCore::FrameView::passWheelEventToSubframe):
3245         * page/Frame.cpp:
3246         * page/Frame.h:
3247         * page/FrameView.cpp:
3248         (WebCore::subframeForTargetNode):
3249         (WebCore::FrameView::handleMousePressEvent):
3250         (WebCore::FrameView::handleMouseDoubleClickEvent):
3251         (WebCore::FrameView::handleMouseMoveEvent):
3252         (WebCore::FrameView::handleMouseReleaseEvent):
3253         (WebCore::FrameView::handleWheelEvent):
3254         * page/FrameView.h:
3255         * platform/ScrollBar.h:
3256         (WebCore::ScrollBar::handleMouseMoveEvent):
3257         (WebCore::ScrollBar::handleMouseOutEvent):
3258         * platform/Widget.h:
3259         (WebCore::Widget::handleMouseMoveEvent):
3260         (WebCore::Widget::handleMouseReleaseEvent):
3261         * platform/win/TemporaryLinkStubs.cpp:
3262         (FrameView::passMousePressEventToSubframe):
3263         (FrameView::passMouseMoveEventToSubframe):
3264         (FrameView::passMouseReleaseEventToSubframe):
3265         (FrameView::passWheelEventToSubframe):
3266         (Widget::capturingMouse):
3267         (Widget::setCapturingMouse):
3268         (Widget::capturingTarget):
3269         (Widget::capturingChild):
3270         (Widget::setCapturingChild):
3271         * rendering/RenderView.cpp:
3272         (WebCore::RenderView::paintBoxDecorations):
3273
3274 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
3275
3276         Reviewed by Adele.
3277
3278         Fixes windows bustage:
3279         http://bugs.webkit.org/show_bug.cgi?id=11093
3280
3281         * platform/win/PlatformScrollBar.h:
3282         * platform/win/TemporaryLinkStubs.cpp:
3283         (PlatformScrollBar::PlatformScrollBar):
3284         (ScrollBar::ScrollBar):
3285
3286 2006-09-29  David Hyatt  <hyatt@apple.com>
3287
3288         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
3289         in RenderObject::NodeInfo (and then propagating that Widget to
3290         MouseEventWithHitTestResults).
3291
3292         This allows RenderListBox and RenderBlock to do the same thing when the
3293         mouse is over the scrollbar.
3294
3295         Also land fix to support font-size: 0.
3296
3297         Reviewed by mjs (scrollbar), eric (font-size)
3298
3299         * dom/Document.cpp:
3300         (WebCore::Document::prepareMouseEvent):
3301         * page/Frame.cpp:
3302         (WebCore::Frame::passWidgetMouseDownEventToWidget):
3303         * page/FrameView.cpp:
3304         (WebCore::selectCursor):
3305         (WebCore::FrameView::handleMouseMoveEvent):
3306         (WebCore::FrameView::dispatchMouseEvent):
3307         * page/MouseEventWithHitTestResults.cpp:
3308         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
3309         * page/MouseEventWithHitTestResults.h:
3310         (WebCore::MouseEventWithHitTestResults::scrollbar):
3311         * rendering/RenderBlock.cpp:
3312         (WebCore::RenderBlock::isPointInScrollbar):
3313         (WebCore::RenderBlock::nodeAtPoint):
3314         * rendering/RenderBlock.h:
3315         * rendering/RenderLayer.cpp:
3316         (WebCore::RenderLayer::hitTest):
3317         * rendering/RenderLayer.h:
3318         (WebCore::RenderLayer::getHiddenBehavior):
3319         * rendering/RenderListBox.cpp:
3320         (WebCore::RenderListBox::RenderListBox):
3321         (WebCore::RenderListBox::~RenderListBox):
3322         (WebCore::RenderListBox::isPointInScrollbar):
3323         * rendering/RenderListBox.h:
3324         * rendering/RenderObject.h:
3325         (WebCore::RenderObject::NodeInfo::NodeInfo):
3326         (WebCore::RenderObject::NodeInfo::scrollbar):
3327         (WebCore::RenderObject::NodeInfo::setScrollbar):
3328
3329 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
3330
3331         Reviewed by Adele.
3332
3333         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
3334
3335         * platform/win/ScrollViewWin.cpp:
3336         (WebCore::ScrollView::convertToContainingWindow):
3337         (WebCore::ScrollView::convertFromContainingWindow):
3338         * platform/win/WidgetWin.cpp:
3339         (WebCore::Widget::convertToContainingWindow):
3340         (WebCore::Widget::convertFromContainingWindow):
3341
3342 2006-09-29  Adele Peterson  <adele@apple.com>
3343
3344         Updated with new argument for PlatformScrollBar.
3345
3346         * platform/win/TemporaryLinkStubs.cpp:
3347         (PlatformScrollBar::PlatformScrollBar):
3348
3349 2006-09-29  Adele Peterson  <adele@apple.com>
3350
3351         Reviewed by Hyatt.
3352
3353         Fixing build bustage with cast to int.
3354
3355         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
3356
3357 2006-09-29  Adele Peterson  <adele@apple.com>
3358
3359         Fixing accidental include.
3360
3361         * rendering/RenderListBox.cpp:
3362
3363 2006-09-29  Adele Peterson  <adele@apple.com>
3364
3365         Adding RenderListBox files.
3366
3367         * WebCore.vcproj/WebCore/WebCore.vcproj:
3368
3369 2006-09-29  Adele Peterson  <adele@apple.com>
3370
3371         Reviewed by Adam.
3372
3373         Initial implementation of engine-based list box control.
3374
3375         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
3376
3377         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
3378         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
3379         (WebCore::FrameMac::FrameMac):
3380         (WebCore::FrameMac::handleMousePressEvent):
3381         (WebCore::FrameMac::handleMouseMoveEvent):
3382         (WebCore::FrameMac::mouseDown):
3383
3384         * page/Frame.cpp:
3385         (WebCore::Frame::handleMouseMoveEvent):
3386         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
3387         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
3388         (WebCore::Frame::autoscrollTimerFired): ditto.
3389         (WebCore::Frame::stopAutoscrollTimer): ditto.
3390         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
3391         * page/Frame.h:
3392         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
3393
3394         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
3395         (WebCore::FrameViewPrivate::reset):
3396         (WebCore::FrameView::currentMousePosition):
3397         (WebCore::FrameView::handleMousePressEvent):
3398         (WebCore::FrameView::handleMouseDoubleClickEvent):
3399         (WebCore::selectCursor):
3400         (WebCore::FrameView::handleMouseMoveEvent):
3401         (WebCore::FrameView::handleMouseReleaseEvent):
3402         * page/FrameView.h:
3403
3404         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
3405         * platform/ScrollBar.h:
3406         (WebCore::):
3407         (WebCore::ScrollBar::controlSize):
3408         * platform/mac/PlatformScrollBar.h:
3409         * platform/mac/PlatformScrollBarMac.mm:
3410         (NSControlSizeForScrollBarControlSize):
3411         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
3412         (WebCore::PlatformScrollBar::PlatformScrollBar):
3413
3414         * rendering/RenderBlock.h:
3415         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
3416         * rendering/RenderLayer.h:
3417         * rendering/RenderObject.cpp:
3418         (WebCore::RenderObject::shouldAutoscroll):
3419         (WebCore::RenderObject::autoscroll):
3420         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
3421
3422         * css/html4.css: Added properties for new list boxes.
3423
3424         * html/HTMLOptionElement.cpp:
3425         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
3426         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
3427         * html/HTMLOptionElement.h: Added disabled method.
3428
3429         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
3430         (WebCore::HTMLSelectElement::recalcStyle):
3431         (WebCore::HTMLSelectElement::lastSelectedListIndex):
3432         (WebCore::HTMLSelectElement::deselectItems):
3433         (WebCore::HTMLSelectElement::setSelectedIndex):
3434         (WebCore::HTMLSelectElement::isKeyboardFocusable):
3435         (WebCore::HTMLSelectElement::isMouseFocusable):
3436         (WebCore::HTMLSelectElement::createRenderer):
3437         (WebCore::HTMLSelectElement::recalcListItems):
3438         (WebCore::HTMLSelectElement::setRecalcListItems):
3439         (WebCore::HTMLSelectElement::reset):
3440         (WebCore::HTMLSelectElement::notifyOptionSelected):
3441         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
3442         (WebCore::HTMLSelectElement::nextSelectableListIndex):
3443         (WebCore::HTMLSelectElement::previousSelectableListIndex):
3444         * html/HTMLSelectElement.h:
3445
3446         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
3447         (WebCore::RenderTheme::paint):
3448         (WebCore::RenderTheme::paintBorderOnly):
3449         (WebCore::RenderTheme::paintDecorations):
3450         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
3451         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
3452         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
3453         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
3454         (WebCore::RenderTheme::isControlStyled):
3455         (WebCore::RenderTheme::supportsFocusRing):
3456         * rendering/RenderTheme.h:
3457         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
3458
3459         * rendering/RenderListBox.cpp: Added.
3460         (WebCore::RenderListBox::RenderListBox):
3461         (WebCore::RenderListBox::~RenderListBox):
3462         (WebCore::RenderListBox::setStyle):
3463         (WebCore::RenderListBox::updateFromElement):
3464         (WebCore::RenderListBox::calcMinMaxWidth):
3465         (WebCore::RenderListBox::size):
3466         (WebCore::RenderListBox::numItems):
3467         (WebCore::RenderListBox::calcHeight):
3468         (WebCore::RenderListBox::baselinePosition):
3469         (WebCore::RenderListBox::itemBoundingBoxRect):
3470         (WebCore::RenderListBox::paintObject):
3471         (WebCore::RenderListBox::paintScrollbar):
3472         (WebCore::RenderListBox::paintItemForeground):
3473         (WebCore::RenderListBox::paintItemBackground):
3474         (WebCore::RenderListBox::scrollBarTarget):
3475         (WebCore::RenderListBox::isPointInScrollbar):
3476         (WebCore::RenderListBox::optionAtPoint):
3477         (WebCore::RenderListBox::autoscroll):
3478         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
3479         (WebCore::RenderListBox::scroll):
3480         (WebCore::RenderListBox::valueChanged):
3481         * rendering/RenderListBox.h: Added.
3482         (WebCore::RenderListBox::isListBox):
3483         (WebCore::RenderListBox::selectionChanged):
3484         (WebCore::RenderListBox::setSelectionChanged):
3485         (WebCore::RenderListBox::canHaveChildren):
3486         (WebCore::RenderListBox::renderName):
3487         (WebCore::RenderListBox::setOptionsChanged):
3488         (WebCore::RenderListBox::shouldAutoscroll):
3489         (WebCore::RenderListBox::listIndexIsVisible):
3490
3491 2006-09-29  Beth Dakin  <bdakin@apple.com>
3492
3493         Reviewed by Darin.
3494
3495         We had a bug where html4.css was ignoring Media Queries. In the end 
3496         the problem was that we were trying to send a char* to the 
3497         MediaQueryEvaluator constructor that expects a String, but the 
3498         char* got interpreted as a bool, the wrong constructor was called, 
3499         and the media type was never set.
3500
3501         No test case possible since this only affects html4.css
3502
3503         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a 
3504         char*
3505         (WebCore::MediaQueryEvaluator):
3506         * css/MediaQueryEvaluator.h: Same.
3507
3508 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
3509
3510         Reviewed by John, Maciej.
3511         
3512         Integrated some frame and iframe code. I'm trying to fix up frame ownership
3513         and loading. Reducing the number of different code paths involved
3514         seemed like a good first step.
3515         
3516         As a side effect, I fixed a bug where FRAME elements would report their
3517         src attributes as relative, rather than compelete, URLs. (IFRAME elements
3518         had the correct complete URL behavior.)
3519
3520         * html/HTMLFrameElement.cpp:
3521         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
3522         (WebCore::HTMLFrameElement::openURL):
3523             (1) Removed checks that requestFrame does for us
3524             (2) Added isURLAllowed check, to have one clear bottleneck for it
3525             (3) Added viewsource check, to have one clear bottleneck for it
3526         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
3527         method, instead of finding our content frame in our own unique way.
3528         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
3529         since openURL does this for us now.
3530         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
3531         This is what FF does, and it made no sense to have different behaviors
3532         for FRAME and IFRAME elements.
3533         * html/HTMLIFrameElement.cpp:
3534         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
3535         code.
3536         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
3537         HTMLFrameElement now does everything we need.
3538
3539 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
3540
3541         Reviewed by Hyatt.
3542
3543         Fix Qt/Linux build.
3544
3545         * CMakeLists.txt:
3546         * platform/qt/ScrollViewQt.cpp:
3547         (WebCore::ScrollView::convertToContainingWindow):
3548         (WebCore::ScrollView::convertFromContainingWindow):
3549         * platform/qt/TemporaryLinkStubs.cpp:
3550         (WebCore::signedPublicKeyAndChallengeString):
3551         * platform/qt/WidgetQt.cpp:
3552         (WebCore::Widget::convertToContainingWindow):
3553         (WebCore::Widget::convertFromContainingWindow):
3554
3555 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
3556
3557         Reviewed by Tim H.
3558
3559         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
3560         Simplify Internal methods for the auto-generated Objective-C DOM code
3561
3562         - Auto-generate the internal methods for more Objective-C classes.
3563
3564         * WebCore.xcodeproj/project.pbxproj:
3565         * bindings/objc/DOM.mm:
3566         * bindings/objc/DOMCSS.mm:
3567         (-[DOMStyleSheet WebCore::]):
3568         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
3569         (-[DOMCSSRule WebCore::]):
3570         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
3571         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
3572         (-[DOMCSSValue WebCore::]):
3573         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
3574         (+[DOMCSSValue _CSSValueWith:WebCore::]):
3575         * bindings/objc/DOMHTMLAppletElement.mm:
3576         (-[DOMHTMLAppletElement WebCore::]):
3577         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
3578         * bindings/objc/DOMHTMLEmbedElement.mm:
3579         (-[DOMHTMLEmbedElement WebCore::]):
3580         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
3581         * bindings/objc/DOMInternal.h:
3582         * bindings/objc/DOMInternal.mm:
3583         * bindings/scripts/CodeGeneratorObjC.pm:
3584         * css/CSSCharsetRule.idl:
3585         * css/CSSFontFaceRule.idl:
3586         * css/CSSImportRule.idl:
3587         * css/CSSMediaRule.idl:
3588         * css/CSSPageRule.idl:
3589         * css/CSSPrimitiveValue.idl:
3590         * css/CSSStyleRule.idl:
3591         * css/CSSStyleSheet.idl:
3592         * css/CSSUnknownRule.idl:
3593         * css/CSSValueList.idl:
3594         * dom/KeyboardEvent.idl:
3595         * dom/MouseEvent.idl:
3596         * dom/MutationEvent.idl:
3597         * dom/NodeIterator.idl:
3598         * dom/OverflowEvent.idl:
3599         * dom/UIEvent.idl:
3600         * dom/WheelEvent.idl:
3601
3602 2006-09-29  David Harrison  <harrison@apple.com>
3603
3604         Reviewed by John Sullivan.
3605
3606         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
3607         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
3608
3609         Test added
3610         * fast/text/attributed-substring-from-range-001.html
3611
3612         * bridge/mac/FrameMac.mm:
3613         (WebCore::FrameMac::attributedString):
3614         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
3615         Also, add validation of the range.
3616
3617 2006-09-29  Rob Buis  <buis@kde.org>
3618
3619         Reviewed by Maciej.
3620
3621        &nb