d72300872ad6a364109aac6d88bbc488df9a413a
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-14  Greg Jackson  <gjspanner@gmail.com>
2
3         Reviewed by Darin.
4
5         Preserves any pre-existing value for WEBCORE_NAVIGATOR_PLATFORM
6         rather than overriding it based on platform detection.
7
8         * bindings/js/kjs_navigator.cpp:
9
10 2006-11-13  Brady Eidson  <beidson@apple.com>
11
12         Reviewed by Maciej
13
14         Made FormData Shared, and pass it around as such.
15
16         * WebCore.xcodeproj/project.pbxproj: Reordered some items
17         * html/HTMLFormElement.cpp:
18         (WebCore::HTMLFormElement::formData):
19         (WebCore::HTMLFormElement::submit):
20         * html/HTMLFormElement.h:
21         * loader/FrameLoader.cpp:
22         (WebCore::FormSubmission::FormSubmission):
23         (WebCore::FrameLoader::submitForm):
24         * loader/FrameLoader.h:
25         * loader/mac/FrameLoaderMac.mm:
26         (WebCore::FrameLoader::post):
27         (WebCore::FrameLoader::loadResourceSynchronously):
28         * loader/mac/SubresourceLoaderMac.mm:
29         (WebCore::SubresourceLoader::create):
30         * platform/network/FormData.h: Made FormData shared
31         * platform/network/ResourceHandle.h:
32         * platform/network/ResourceHandle.cpp:
33         (WebCore::ResourceHandle::postData): 
34         * platform/network/ResourceRequest.h:
35         (WebCore::ResourceRequest::httpBody):
36         (WebCore::ResourceRequest::setHTTPBody): 
37         * platform/network/mac/ResourceRequestMac.mm:
38         (WebCore::getResourceRequest):
39         (WebCore::nsURLRequest): 
40
41         * platform/network/mac/FormDataStreamMac.h:
42         * platform/network/mac/FormDataStreamMac.mm:
43         (WebCore::getStreamFormDatas): Hash Streams to RefPtr<FormData>s
44         (WebCore::formCreate):
45         (WebCore::formFinalize):
46         (WebCore::setHTTPBody):
47         (WebCore::httpBodyFromStream):
48
49         * xml/xmlhttprequest.cpp:
50         (WebCore::XMLHttpRequest::send):
51
52 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
53
54         Reviewed by harrison
55         
56         <rdar://problem/4828264>
57         In Mail, a crash occurs at WebCore::Selection::toRange() when selecting this web content (http://www.cnet.com/)
58         
59         The start of the selection is in an editable area, and the end is in an 
60         input field inside that editable area.  The code that should pull the end
61         of such a selection outside the input field didn't escape shadow nodes,
62         it would leave a dangling end, causing the crash in toRange.
63         
64         * editing/Selection.cpp:
65         (WebCore::Selection::adjustForEditableContent):  Added an ASSERT and a fixup
66         to prevent crashes like this in future Release builds.
67         * editing/htmlediting.cpp:
68         (WebCore::firstEditablePositionAfterPositionInRoot): Let this function 
69         escape shadow nodes.  We might eventually push this code down into 
70         next/previous{VisuallyDistinct}Canditate.
71         (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
72
73 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
74
75         Reviewed by darin
76         
77         * editing/DeleteSelectionCommand.cpp:
78         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
79         * editing/Editor.cpp:
80         (WebCore::Editor::appliedEditing):
81         * editing/Editor.h:
82         (WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.
83
84 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
85
86         Reviewed by Oliver
87         
88         <rdar://problem/4820026>
89         copy/paste of news.google.com yields text from hidden select element options
90
91         We were adding descendants of unrendered select elements. 
92
93         * editing/markup.cpp:
94         (WebCore::createMarkup): Don't traverse into nodes without renderers, unless 
95         they are grandfathered in by a rendered select element.
96         
97 2006-11-12  Simon Hausmann  <hausmann@kde.org>
98
99         Reviewed by Sam Weinig.
100
101         Fix Qt build. Missing AbstractShared implementation.
102         http://bugs.webkit.org/show_bug.cgi?id=11581
103
104         * loader/qt/FrameLoaderClientQt.cpp:
105         (WebCore::FrameLoaderClientQt::ref):
106         (WebCore::FrameLoaderClientQt::deref):
107         * loader/qt/FrameLoaderClientQt.h:
108         * platform/qt/ChromeClientQt.cpp:
109         (WebCore::ChromeClientQt::ref):
110         (WebCore::ChromeClientQt::deref):
111         * platform/qt/ChromeClientQt.h:
112         * platform/qt/EditorClientQt.cpp:
113         (WebCore::EditorClientQt::ref):
114         (WebCore::EditorClientQt::deref):
115         * platform/qt/EditorClientQt.h:
116
117 2006-11-13  Mark Rowe  <bdash@webkit.org>
118
119         Reviewed by Mitz.
120
121         Fix some Linux/Gdk build issues noted by Alp Toker.
122
123         * Projects/gdk/webcore-gdk.bkl:
124         * WebCoreSources.bkl:
125         * platform/graphics/gdk/ImageGdk.cpp:
126         (WebCore::Image::loadPlatformResource):
127
128 2006-11-12  Brady Eidson <beidson@apple.com>
129
130         Reviewed by Anders
131
132         Logging channel plumbing for future work
133
134         * platform/Logging.cpp:
135         (WebCore::):
136         * platform/Logging.h:
137         * platform/mac/LoggingMac.mm:
138         (WebCore::InitializeLoggingChannelsIfNecessary):
139
140 2006-11-12  Mark Rowe  <bdash@webkit.org>
141
142         Reviewed by Mitz.
143
144         Linux/Gdk compilation fixes, and bakefile cleanups.  Based on patches by
145         Alp Toker.
146
147         * Projects/gdk/webcore-gdk.bkl:
148         * WebCoreSources.bkl:
149         * page/PageState.cpp:
150         * platform/gdk/ChromeClientGdk.h:
151         (WebCore::ChromeClientGdk::ref):
152         (WebCore::ChromeClientGdk::deref):
153         * platform/gdk/FrameGdk.cpp:
154         (WebCore::FrameGdkClientDefault::openURL):
155         (WebCore::FrameGdkClientDefault::didReceiveData):
156         (WebCore::FrameGdkClientDefault::receivedAllData):
157         (WebCore::FrameGdk::FrameGdk):
158         (WebCore::FrameGdk::~FrameGdk):
159         * platform/gdk/FrameGdk.h:
160         * platform/gdk/KeyEventGdk.cpp:
161         (WebCore::keyIdentifierForGdkKeyCode):
162         * platform/gdk/ScreenClientGdk.h: Removed.
163         * platform/gdk/TemporaryLinkStubs.cpp:
164         (FrameGdk::canPaste):
165         (FrameGdk::originalRequestURL):
166         (TextField::TextField):
167         * platform/network/gdk/ResourceHandleManager.cpp:
168         (WebCore::ResourceHandleManager::downloadTimerCallback):
169         (WebCore::ResourceHandleManager::add):
170         (WebCore::ResourceHandleManager::cancel):
171         * webcore-base.bkl:
172
173 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
174
175         Reviewed by Maciej Stachowiak.
176         
177         - Fixed loader crash by clarifying ownership of WebKit client objects. 
178         WebCore objects own their WebKit clients, and ref and deref through 
179         virtual methods, leaving WebKit free to use whatever client / reference-counting 
180         implementation it likes.
181         
182         * WebCore.exp:
183         * WebCore.xcodeproj/project.pbxproj:
184         * bridge/EditorClient.h: Fixed up function prototypes for style.
185         * loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose
186         was to implement an alternative ownership model.
187         (WebCore::FrameLoader::~FrameLoader): Removed empty destructor.
188         (WebCore::FrameLoader::setClient): This function now takes ownership
189         (WebCore::FrameLoader::client):
190         * loader/FrameLoader.h:
191         * loader/FrameLoaderClient.h:
192         * page/ChromeClient.h:
193         * platform/AbstractShared.h: Added. This is the virtual function-based refcounting
194         complement to Shared.
195         (WebCore::AbstractShared::~AbstractShared):
196
197 2006-11-11  George Staikos  <staikos@kde.org>
198
199         Reviewed by Maciej.
200
201         Fix uninitialized variable.
202
203         * rendering/RenderStyle.h:
204
205 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
206
207         Reviewed/landed by Adam.
208
209         Complete cleanup of the CMakeLists.txt.
210         Now all files to be built are sorted in alphabetic order.
211
212         General style cleanup, remove all tabs etc.
213
214         * CMakeLists.txt:
215
216 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
217
218         Reviewed by Maciej Stachowiak.
219         
220         Added missing initializer to ResourceRequest -- fixes some loader crashes
221         due to assuming a request always has a non-null httpMethod.
222
223         * platform/network/ResourceRequest.h:
224         (WebCore::ResourceRequest::ResourceRequest):
225
226 2006-11-11  Brady Eidson <beidson@apple.com>
227
228         Reviewed by Maciej
229
230         Fixed header guard
231
232         * loader/FrameLoaderClient.h:
233
234 2006-11-11  Darin Adler  <darin@apple.com>
235
236         - attempt to fix Qt build
237
238         * platform/qt/CursorQt.cpp:
239         (WebCore::verticalTextCursor): Added. Just returns pointer cursor.
240         (WebCore::cellCursor): Ditto.
241         (WebCore::contextMenuCursor): Ditto.
242
243 2006-11-11  Rob Buis  <buis@kde.org>
244
245         Reviewed by hyatt.
246
247         http://bugs.webkit.org/show_bug.cgi?id=10893
248         InsertRule can not handle @import statements
249
250         Allow @import as part of a css rule.
251
252         * css/CSSGrammar.y:
253         * css/CSSImportRule.cpp:
254         (WebCore::CSSImportRule::insertedIntoParent):
255         * css/CSSStyleSheet.cpp:
256         (WebCore::CSSStyleSheet::CSSStyleSheet):
257         (WebCore::CSSStyleSheet::checkLoaded):
258         * css/CSSStyleSheet.h:
259         (WebCore::CSSStyleSheet::loadCompleted):
260
261 2006-11-11  Alexey Proskuryakov  <ap@webkit.org>
262
263         Attempt to fix Qt build.
264
265         * CMakeLists.txt: PathQt.cpp is in graphics/qt now.
266
267 2006-11-11  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
268
269         Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)
270
271         [CSS 3] support for vertical-text, cell and context-menu cursors
272         http://bugs.webkit.org/show_bug.cgi?id=11494
273
274         * Resources/cellCursor.png: Added.
275         * Resources/contextMenuCursor.png: Added.
276         * Resources/verticalTextCursor.png: Added.
277         * WebCore.xcodeproj/project.pbxproj:
278         * css/CSSComputedStyleDeclaration.cpp:
279         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
280         * css/CSSValueKeywords.in:
281         * manual-tests/cursor.html:
282         * page/FrameView.cpp:
283         (WebCore::selectCursor):
284         * platform/Cursor.h:
285         * platform/mac/CursorMac.mm:
286         (WebCore::verticalTextCursor):
287         (WebCore::cellCursor):
288         (WebCore::contextMenuCursor):
289         * rendering/RenderStyle.h:
290         (WebCore::):
291
292 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
293
294         Reviewed by aroben and ap, landed by ap.
295
296         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468
297
298         Group graphics related files in platform/graphics.
299         Move certain files from certain subdirectories
300         into platform/graphics/{win,mac,cg,gdk,qt}
301
302         * CMakeLists.txt:
303         * WebCore.xcodeproj/project.pbxproj:
304         * platform/AffineTransform.cpp: Removed.
305         * platform/AffineTransform.h: Removed.
306         * platform/Color.cpp: Removed.
307         * platform/Color.h: Removed.
308         * platform/FloatPoint.cpp: Removed.
309         * platform/FloatPoint.h: Removed.
310         * platform/FloatRect.cpp: Removed.
311         * platform/FloatRect.h: Removed.
312         * platform/FloatSize.cpp: Removed.
313         * platform/FloatSize.h: Removed.
314         * platform/Icon.h: Removed.
315         * platform/Image.cpp: Removed.
316         * platform/Image.h: Removed.
317         * platform/ImageSource.h: Removed.
318         * platform/IntPoint.h: Removed.
319         * platform/IntRect.cpp: Removed.
320         * platform/IntRect.h: Removed.
321         * platform/IntSize.h: Removed.
322         * platform/IntSizeHash.h: Removed.
323         * platform/Path.cpp: Removed.
324         * platform/Path.h: Removed.
325         * platform/Pen.cpp: Removed.
326         * platform/Pen.h: Removed.
327         * platform/cairo/AffineTransformCairo.cpp: Removed.
328         * platform/cairo/GraphicsContextCairo.cpp: Removed.
329         * platform/cairo/ImageCairo.cpp: Removed.
330         * platform/cairo/ImageSourceCairo.cpp: Removed.
331         * platform/cairo/cairo/AUTHORS: Removed.
332         * platform/cairo/cairo/COPYING: Removed.
333         * platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
334         * platform/cairo/cairo/COPYING-MPL-1.1: Removed.
335         * platform/cairo/cairo/INSTALL: Removed.
336         * platform/cairo/cairo/NEWS: Removed.
337         * platform/cairo/cairo/README: Removed.
338         * platform/cairo/cairo/TODO: Removed.
339         * platform/cairo/cairo/src/Makefile.in: Removed.
340         * platform/cairo/cairo/src/cairo-arc-private.h: Removed.
341         * platform/cairo/cairo/src/cairo-arc.c: Removed.
342         * platform/cairo/cairo/src/cairo-array.c: Removed.
343         * platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
344         * platform/cairo/cairo/src/cairo-atsui.h: Removed.
345         * platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
346         * platform/cairo/cairo/src/cairo-beos.h: Removed.
347         * platform/cairo/cairo/src/cairo-cache-private.h: Removed.
348         * platform/cairo/cairo/src/cairo-cache.c: Removed.
349         * platform/cairo/cairo/src/cairo-clip-private.h: Removed.
350         * platform/cairo/cairo/src/cairo-clip.c: Removed.
351         * platform/cairo/cairo/src/cairo-color.c: Removed.
352         * platform/cairo/cairo/src/cairo-debug.c: Removed.
353         * platform/cairo/cairo/src/cairo-debug.h: Removed.
354         * platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
355         * platform/cairo/cairo/src/cairo-directfb.h: Removed.
356         * platform/cairo/cairo/src/cairo-features.h: Removed.
357         * platform/cairo/cairo/src/cairo-features.h.in: Removed.
358         * platform/cairo/cairo/src/cairo-fixed.c: Removed.
359         * platform/cairo/cairo/src/cairo-font-options.c: Removed.
360         * platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
361         * platform/cairo/cairo/src/cairo-font-subset.c: Removed.
362         * platform/cairo/cairo/src/cairo-font.c: Removed.
363         * platform/cairo/cairo/src/cairo-ft-font.c: Removed.
364         * platform/cairo/cairo/src/cairo-ft-private.h: Removed.
365         * platform/cairo/cairo/src/cairo-ft.h: Removed.
366         * platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
367         * platform/cairo/cairo/src/cairo-glitz.h: Removed.
368         * platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
369         * platform/cairo/cairo/src/cairo-gstate.c: Removed.
370         * platform/cairo/cairo/src/cairo-hash-private.h: Removed.
371         * platform/cairo/cairo/src/cairo-hash.c: Removed.
372         * platform/cairo/cairo/src/cairo-hull.c: Removed.
373         * platform/cairo/cairo/src/cairo-image-surface.c: Removed.
374         * platform/cairo/cairo/src/cairo-matrix.c: Removed.
375         * platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
376         * platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
377         * platform/cairo/cairo/src/cairo-output-stream.c: Removed.
378         * platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
379         * platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
380         * platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
381         * platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
382         * platform/cairo/cairo/src/cairo-path-data.c: Removed.
383         * platform/cairo/cairo/src/cairo-path-fill.c: Removed.
384         * platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
385         * platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
386         * platform/cairo/cairo/src/cairo-path.c: Removed.
387         * platform/cairo/cairo/src/cairo-pattern.c: Removed.
388         * platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
389         * platform/cairo/cairo/src/cairo-pdf.h: Removed.
390         * platform/cairo/cairo/src/cairo-pen.c: Removed.
391         * platform/cairo/cairo/src/cairo-platform.h: Removed.
392         * platform/cairo/cairo/src/cairo-png.c: Removed.
393         * platform/cairo/cairo/src/cairo-polygon.c: Removed.
394         * platform/cairo/cairo/src/cairo-private.h: Removed.
395         * platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
396         * platform/cairo/cairo/src/cairo-ps.h: Removed.
397         * platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
398         * platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
399         * platform/cairo/cairo/src/cairo-quartz.h: Removed.
400         * platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
401         * platform/cairo/cairo/src/cairo-quartz2.h: Removed.
402         * platform/cairo/cairo/src/cairo-region.c: Removed.
403         * platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
404         * platform/cairo/cairo/src/cairo-slope.c: Removed.
405         * platform/cairo/cairo/src/cairo-spline.c: Removed.
406         * platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
407         * platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
408         * platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
409         * platform/cairo/cairo/src/cairo-surface.c: Removed.
410         * platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
411         * platform/cairo/cairo/src/cairo-svg.h: Removed.
412         * platform/cairo/cairo/src/cairo-traps.c: Removed.
413         * platform/cairo/cairo/src/cairo-unicode.c: Removed.
414         * platform/cairo/cairo/src/cairo-wideint.c: Removed.
415         * platform/cairo/cairo/src/cairo-wideint.h: Removed.
416         * platform/cairo/cairo/src/cairo-win32-font.c: Removed.
417         * platform/cairo/cairo/src/cairo-win32-private.h: Removed.
418         * platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
419         * platform/cairo/cairo/src/cairo-win32.h: Removed.
420         * platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
421         * platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
422         * platform/cairo/cairo/src/cairo-xcb.h: Removed.
423         * platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
424         * platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
425         * platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
426         * platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
427         * platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
428         * platform/cairo/cairo/src/cairo-xlib.h: Removed.
429         * platform/cairo/cairo/src/cairo.c: Removed.
430         * platform/cairo/cairo/src/cairo.h: Removed.
431         * platform/cairo/cairo/src/cairoint.h: Removed.
432         * platform/cairo/cairo/src/test-fallback-surface.c: Removed.
433         * platform/cairo/cairo/src/test-fallback-surface.h: Removed.
434         * platform/cairo/cairo/src/test-meta-surface.c: Removed.
435         * platform/cairo/cairo/src/test-meta-surface.h: Removed.
436         * platform/cairo/cairo/src/test-paginated-surface.c: Removed.
437         * platform/cairo/cairo/src/test-paginated-surface.h: Removed.
438         * platform/cairo/pixman/AUTHORS: Removed.
439         * platform/cairo/pixman/COPYING: Removed.
440         * platform/cairo/pixman/README: Removed.
441         * platform/cairo/pixman/src/Makefile.in: Removed.
442         * platform/cairo/pixman/src/fbcompose.c: Removed.
443         * platform/cairo/pixman/src/fbedge.c: Removed.
444         * platform/cairo/pixman/src/fbedgeimp.h: Removed.
445         * platform/cairo/pixman/src/fbmmx.c: Removed.
446         * platform/cairo/pixman/src/fbmmx.h: Removed.
447         * platform/cairo/pixman/src/fbpict.c: Removed.
448         * platform/cairo/pixman/src/fbpict.h: Removed.
449         * platform/cairo/pixman/src/fbtrap.c: Removed.
450         * platform/cairo/pixman/src/icblt.c: Removed.
451         * platform/cairo/pixman/src/icbltone.c: Removed.
452         * platform/cairo/pixman/src/iccolor.c: Removed.
453         * platform/cairo/pixman/src/icformat.c: Removed.
454         * platform/cairo/pixman/src/icimage.c: Removed.
455         * platform/cairo/pixman/src/icimage.h: Removed.
456         * platform/cairo/pixman/src/icint.h: Removed.
457         * platform/cairo/pixman/src/icpixels.c: Removed.
458         * platform/cairo/pixman/src/icrect.c: Removed.
459         * platform/cairo/pixman/src/icrop.h: Removed.
460         * platform/cairo/pixman/src/icstipple.c: Removed.
461         * platform/cairo/pixman/src/ictransform.c: Removed.
462         * platform/cairo/pixman/src/ictrap.c: Removed.
463         * platform/cairo/pixman/src/ictri.c: Removed.
464         * platform/cairo/pixman/src/icutil.c: Removed.
465         * platform/cairo/pixman/src/pixman-remap.h: Removed.
466         * platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
467         * platform/cairo/pixman/src/pixman.h: Removed.
468         * platform/cairo/pixman/src/pixregion.c: Removed.
469         * platform/cairo/pixman/src/pixregionint.h: Removed.
470         * platform/cairo/pixman/src/renderedge.c: Removed.
471         * platform/cairo/pixman/src/renderedge.h: Removed.
472         * platform/cairo/pixman/src/slim_internal.h: Removed.
473         * platform/cairo/rgb24-hacks.txt: Removed.
474         * platform/cairo/scale-removal.txt: Removed.
475         * platform/cg/AffineTransformCG.cpp: Removed.
476         * platform/cg/FloatPointCG.cpp: Removed.
477         * platform/cg/FloatRectCG.cpp: Removed.
478         * platform/cg/FloatSizeCG.cpp: Removed.
479         * platform/cg/GraphicsContextCG.cpp: Removed.
480         * platform/cg/GraphicsContextPlatformPrivate.h: Removed.
481         * platform/cg/ImageCG.cpp: Removed.
482         * platform/cg/ImageSourceCG.cpp: Removed.
483         * platform/cg/IntPointCG.cpp: Removed.
484         * platform/cg/IntRectCG.cpp: Removed.
485         * platform/cg/IntSizeCG.cpp: Removed.
486         * platform/cg/PDFDocumentImage.cpp: Removed.
487         * platform/cg/PDFDocumentImage.h: Removed.
488         * platform/cg/PathCG.cpp: Removed.
489         * platform/gdk/ImageGdk.cpp: Removed.
490         * platform/mac/ColorMac.mm: Removed.
491         * platform/mac/FloatPointMac.mm: Removed.
492         * platform/mac/FloatRectMac.mm: Removed.
493         * platform/mac/FloatSizeMac.mm: Removed.
494         * platform/mac/GraphicsContextMac.mm:
495         * platform/mac/IconMac.mm: Removed.
496         * platform/mac/ImageMac.mm: Removed.
497         * platform/mac/IntPointMac.mm: Removed.
498         * platform/mac/IntRectMac.mm: Removed.
499         * platform/mac/IntSizeMac.mm: Removed.
500         * platform/qt/AffineTransformQt.cpp: Removed.
501         * platform/qt/ColorQt.cpp: Removed.
502         * platform/qt/FloatPointQt.cpp: Removed.
503         * platform/qt/FloatRectQt.cpp: Removed.
504         * platform/qt/IconQt.cpp: Removed.
505         * platform/qt/ImageQt.cpp: Removed.
506         * platform/qt/ImageSourceQt.cpp: Removed.
507         * platform/qt/IntPointQt.cpp: Removed.
508         * platform/qt/IntRectQt.cpp: Removed.
509         * platform/qt/IntSizeQt.cpp: Removed.
510         * platform/qt/PathQt.cpp: Removed.
511         * platform/win/ImageWin.cpp: Removed.
512         * platform/win/IntPointWin.cpp: Removed.
513         * platform/win/IntRectWin.cpp: Removed.
514         * platform/win/IntSizeWin.cpp: Removed.
515
516 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
517
518         Reviewed by hyatt.
519
520         A layout test was added when this bug was fixed, so none needed now.
521         
522         Cleanup after:
523         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
524         http://bugs.webkit.org/show_bug.cgi?id=11570
525         
526         * rendering/RenderStyle.h:
527         (WebCore::RenderStyle::isSpace): Removed.
528         * rendering/RenderText.cpp:
529         (WebCore::isSpace): Added.
530         (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
531
532 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
533
534         Reviewed by mitz.
535         
536         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
537         http://bugs.webkit.org/show_bug.cgi?id=11570
538
539         * rendering/RenderStyle.h:
540         (WebCore::RenderStyle::isSpace): Added.
541         * rendering/RenderText.cpp:
542         (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, 
543         treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'
544
545 2006-11-10  Zalan Bujtas <zalan.bujtas@nokia.com>
546
547         Reviewed by Maciej.
548
549         Added basic types for symbian platform.
550         http://bugs.webkit.org/show_bug.cgi?id=11540
551
552         * config.h:
553         * platform/AtomicString.h:
554         (WebCore::AtomicString::AtomicString):
555         (WebCore::AtomicString::operator TPtrC):
556         * platform/DeprecatedString.cpp:
557         (WebCore::initializeHandleNodeBlock):
558         * platform/DeprecatedString.h: char _internalBuffer has to be in front of
559           the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with
560           bitfields and breaks byte aligment
561         * platform/FloatPoint.h:
562         * platform/FloatRect.h:
563         * platform/IntPoint.h:
564         * platform/IntRect.h:
565         * platform/IntSize.h:
566         * platform/PlatformString.h:
567         (WebCore::String::operator TPtrC):
568         (WebCore::String::des):
569         * platform/StringImpl.h:
570         * platform/symbian/DeprecatedStringSymbian.cpp: Added.
571         (WebCore::DeprecatedString::setBufferFromDes):
572         (WebCore::DeprecatedString::fromDes):
573         (WebCore::DeprecatedString::des):
574         (WebCore::DeprecatedString::des8):
575         * platform/symbian/FloatPointSymbian.cpp: Added.
576         (WebCore::FloatPoint::FloatPoint):
577         (WebCore::FloatPoint::operator TPoint):
578         * platform/symbian/FloatRectSymbian.cpp: Added.
579         (WebCore::FloatRect::FloatRect):
580         (WebCore::FloatRect::operator TRect):
581         (WebCore::FloatRect::rect):
582         * platform/symbian/IntPointSymbian.cpp: Added.
583         (WebCore::IntPoint::IntPoint):
584         (WebCore::IntPoint::operator TPoint):
585         * platform/symbian/IntRectSymbian.cpp: Added.
586         (WebCore::IntRect::IntRect):
587         (WebCore::IntRect::operator TRect):
588         (WebCore::IntRect::Rect):
589         * platform/symbian/IntSizeSymbian.cpp: Added.
590         (WebCore::IntSize::IntSize):
591         (WebCore::IntSize::operator TSize):
592         * platform/symbian/StringImplSymbian.cpp: Added.
593         (WebCore::StringImpl::StringImpl):
594         (WebCore::StringImpl::des):
595         * platform/symbian/StringSymbian.cpp: Added.
596         (WebCore::String::String):
597
598 2006-11-10  Zack Rusin  <zack@kde.org>
599
600         Reviewed by Anders.
601
602         Adjust to the changes Brady made in the Qt code.
603
604         * loader/qt/FrameLoaderClientQt.cpp:
605         (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
606         * loader/qt/FrameLoaderClientQt.h:
607
608 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
609
610         Reviewed by harrison
611         
612         <rdar://problem/4069359>
613         Deleting hyperlink text, then typing uses link typing style but loses the link itself
614         
615         The removed anchor element needs to stick around temporarily, in the same way
616         that the typing style hangs off the caret until the user moves it.  Also text
617         insertion around anchors didn't match TextEdit.
618
619         * editing/DeleteSelectionCommand.cpp:
620         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added.
621         (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
622         * editing/DeleteSelectionCommand.h:
623         * editing/EditCommand.cpp:
624         (WebCore::EditCommand::apply): Clear the removed anchor after any top level
625         editing command that doesn't preserve the typing style (matches TextEdit).
626         * editing/Editor.cpp:
627         (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call 
628         setSelection with a message telling it to clear the typing style 
629         (and the saved anchor) here.  Save/restore the saved anchor because of this.
630         * editing/Editor.h:
631         (WebCore::Editor::removedAnchor): Getter.
632         (WebCore::Editor::setRemovedAnchor): Setter.
633         * editing/InsertTextCommand.cpp:
634         (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor
635         if one exists.
636         * editing/SelectionController.cpp:
637         (WebCore::SelectionController::setSelection): Clear the removed anchor whenever
638         we make a selection change that clears the typing style.
639         (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
640         * editing/htmlediting.cpp:
641         (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and
642         made some changes to match TextEdit's behavior.  First, insert content
643         inside the anchor when the caret is after it, unless the caret is at the
644         end of the document, or if the caret is before it and at the start of a 
645         paragraph.
646
647 === Safari-521.30 ===
648
649 2006-11-10  Timothy Hatcher  <timothy@apple.com>
650
651         Reviewed by Hyatt.
652
653         Check for BHIDDEN in isVisible() also.
654
655         * rendering/RenderStyle.h:
656         (WebCore::BorderValue::isVisible):
657
658 2006-11-10  Timothy Hatcher  <timothy@apple.com>
659
660         Reviewed by Adam.
661
662         <rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
663
664         Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
665
666         * editing/DeleteButtonController.cpp:
667         (WebCore::isDeletableElement):
668         * rendering/RenderStyle.h:
669         (WebCore::BorderValue::isVisible):
670
671 2006-11-10  Adam Roben  <aroben@apple.com>
672
673         Rubberstamped by Anders.
674
675         Back out some accidentally-committed changes from r17711.
676
677         * page/Frame.cpp:
678         (WebCore::Frame::command):
679         (WebCore::FramePrivate::FramePrivate):
680         * page/Frame.h:
681         * page/FramePrivate.h:
682
683 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
684
685         Reviewed by Geoff.
686
687         Add more commands, make toggleBold and toggleItalic executable commands.
688
689         * WebCore.exp:
690         * editing/Editor.cpp:
691         (WebCore::execCopy):
692         (WebCore::execCut):
693         (WebCore::execDelete):
694         (WebCore::execForwardDelete):
695         (WebCore::execPaste):
696         (WebCore::execSelectAll):
697         (WebCore::execToggleBold):
698         (WebCore::execToggleItalic):
699         (WebCore::enabled):
700         (WebCore::canPaste):
701         (WebCore::hasEditableSelection):
702         (WebCore::hasEditableRangeSelection):
703         (WebCore::hasRangeSelection):
704         (WebCore::hasRichlyEditableSelection):
705         (WebCore::CommandEntry::):
706         * editing/Editor.h:
707
708 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
709
710         Reviewed by Maciej, Geoff.
711
712         Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
713         the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.
714
715         * WebCore.exp:
716         * bridge/mac/WebCoreFrameBridge.h:
717         * bridge/mac/WebCoreFrameBridge.mm:
718         * editing/Editor.cpp:
719         (WebCore::execMoveBackward):
720         (WebCore::execMoveBackwardAndModifySelection):
721         (WebCore::execMoveDown):
722         (WebCore::execMoveDownAndModifySelection):
723         (WebCore::execMoveForward):
724         (WebCore::execMoveForwardAndModifySelection):
725         (WebCore::execMoveLeft):
726         (WebCore::execMoveLeftAndModifySelection):
727         (WebCore::execMoveRight):
728         (WebCore::execMoveRightAndModifySelection):
729         (WebCore::execMoveToBeginningOfDocument):
730         (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
731         (WebCore::execMoveToBeginningOfSentence):
732         (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
733         (WebCore::execMoveToBeginningOfLine):
734         (WebCore::execMoveToBeginningOfLineAndModifySelection):
735         (WebCore::execMoveToBeginningOfParagraph):
736         (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
737         (WebCore::execMoveToEndOfDocument):
738         (WebCore::execMoveToEndOfDocumentAndModifySelection):
739         (WebCore::execMoveToEndOfSentence):
740         (WebCore::execMoveToEndOfSentenceAndModifySelection):
741         (WebCore::execMoveToEndOfLine):
742         (WebCore::execMoveToEndOfLineAndModifySelection):
743         (WebCore::execMoveToEndOfParagraph):
744         (WebCore::execMoveToEndOfParagraphAndModifySelection):
745         (WebCore::execMoveParagraphBackwardAndModifySelection):
746         (WebCore::execMoveParagraphForwardAndModifySelection):
747         (WebCore::execMoveUp):
748         (WebCore::execMoveUpAndModifySelection):
749         (WebCore::execMoveWordBackward):
750         (WebCore::execMoveWordBackwardAndModifySelection):
751         (WebCore::execMoveWordForward):
752         (WebCore::execMoveWordForwardAndModifySelection):
753         (WebCore::execMoveWordLeft):
754         (WebCore::execMoveWordLeftAndModifySelection):
755         (WebCore::execMoveWordRight):
756         (WebCore::execMoveWordRightAndModifySelection):
757         (WebCore::enabledAnySelection):
758         (WebCore::createCommandMap):
759         (WebCore::CommandEntry::):
760         (WebCore::Editor::execCommand):
761         * editing/Editor.h:
762
763 2006-11-10  Brady Eidson  <beidson@apple.com>
764
765         Reviewed by Darin
766
767         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
768
769         * WebCore.exp:
770         * WebCore.xcodeproj/project.pbxproj:
771         * bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
772         * bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
773         * loader/FrameLoaderClient.h:
774         * loader/icon/IconDatabase.cpp:
775         (WebCore::IconDatabase::sharedIconDatabase):
776         (WebCore::IconDatabase::~IconDatabase):
777         * loader/icon/IconDatabase.h:
778         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
779         (WebCore::IconDatabase::enabled):
780         * loader/icon/IconLoader.cpp:
781         (WebCore::IconLoader::finishLoading):
782         * loader/mac/FrameLoaderMac.mm:
783
784 2006-11-10  Zack Rusin  <zack@kde.org>
785
786         Reviewed and landed by Anders.
787
788         Adjust platform Qt/KDE code to the recent loader
789         changes. 
790
791         * CMakeLists.txt:
792         * loader/DocumentLoader.h:
793         * loader/FrameLoader.cpp:
794         (WebCore::FrameLoader::createEmptyDocument):
795         * loader/FrameLoader.h:
796         * loader/FrameLoaderClient.h:
797         * loader/qt/DocumentLoaderQt.cpp: Added.
798         (WebCore::canonicalizedTitle):
799         (WebCore::DocumentLoader::DocumentLoader):
800         (WebCore::DocumentLoader::frameLoader):
801         (WebCore::DocumentLoader::~DocumentLoader):
802         (WebCore::DocumentLoader::URL):
803         (WebCore::DocumentLoader::unreachableURL):
804         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
805         (WebCore::DocumentLoader::isStopping):
806         (WebCore::DocumentLoader::clearErrors):
807         (WebCore::DocumentLoader::stopLoading):
808         (WebCore::DocumentLoader::setupForReplace):
809         (WebCore::DocumentLoader::commitIfReady):
810         (WebCore::DocumentLoader::finishedLoading):
811         (WebCore::DocumentLoader::setCommitted):
812         (WebCore::DocumentLoader::isCommitted):
813         (WebCore::DocumentLoader::setLoading):
814         (WebCore::DocumentLoader::isLoading):
815         (WebCore::DocumentLoader::doesProgressiveLoad):
816         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
817         (WebCore::DocumentLoader::updateLoading):
818         (WebCore::DocumentLoader::setFrame):
819         (WebCore::DocumentLoader::attachToFrame):
820         (WebCore::DocumentLoader::detachFromFrame):
821         (WebCore::DocumentLoader::prepareForLoadStart):
822         (WebCore::DocumentLoader::loadingStartedTime):
823         (WebCore::DocumentLoader::setIsClientRedirect):
824         (WebCore::DocumentLoader::isClientRedirect):
825         (WebCore::DocumentLoader::setPrimaryLoadComplete):
826         (WebCore::DocumentLoader::isLoadingInAPISense):
827         (WebCore::DocumentLoader::stopRecordingResponses):
828         (WebCore::DocumentLoader::title):
829         (WebCore::DocumentLoader::triggeringAction):
830         (WebCore::DocumentLoader::setTriggeringAction):
831         (WebCore::DocumentLoader::setOverrideEncoding):
832         (WebCore::DocumentLoader::overrideEncoding):
833         (WebCore::DocumentLoader::setTitle):
834         (WebCore::DocumentLoader::URLForHistory):
835         * loader/qt/FrameLoaderClientQt.cpp: Added.
836         (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
837         (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt):
838         (WebCore::FrameLoaderClientQt::detachFrameLoader):
839         (WebCore::FrameLoaderClientQt::hasWebView):
840         (WebCore::FrameLoaderClientQt::hasFrameView):
841         (WebCore::FrameLoaderClientQt::hasBackForwardList):
842         (WebCore::FrameLoaderClientQt::resetBackForwardList):
843         (WebCore::FrameLoaderClientQt::provisionalItemIsTarget):
844         (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache):
845         (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache):
846         (WebCore::FrameLoaderClientQt::privateBrowsingEnabled):
847         (WebCore::FrameLoaderClientQt::makeDocumentView):
848         (WebCore::FrameLoaderClientQt::makeRepresentation):
849         (WebCore::FrameLoaderClientQt::forceLayout):
850         (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML):
851         (WebCore::FrameLoaderClientQt::updateHistoryForCommit):
852         (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation):
853         (WebCore::FrameLoaderClientQt::updateHistoryForReload):
854         (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad):
855         (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad):
856         (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect):
857         (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
858         (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset):
859         (WebCore::FrameLoaderClientQt::resetAfterLoadError):
860         (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError):
861         (WebCore::FrameLoaderClientQt::willCloseDocument):
862         (WebCore::FrameLoaderClientQt::detachedFromParent1):
863         (WebCore::FrameLoaderClientQt::detachedFromParent2):
864         (WebCore::FrameLoaderClientQt::detachedFromParent3):
865         (WebCore::FrameLoaderClientQt::detachedFromParent4):
866         (WebCore::FrameLoaderClientQt::loadedFromPageCache):
867         (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
868         (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad):
869         (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect):
870         (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
871         (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
872         (WebCore::FrameLoaderClientQt::dispatchWillClose):
873         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
874         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
875         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
876         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
877         (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
878         (WebCore::FrameLoaderClientQt::dispatchShow):
879         (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
880         (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
881         (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource):
882         (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache):
883         (WebCore::FrameLoaderClientQt::isLoadingFromPageCache):
884         (WebCore::FrameLoaderClientQt::revertToProvisionalState):
885         (WebCore::FrameLoaderClientQt::clearUnarchivingState):
886         (WebCore::FrameLoaderClientQt::progressStarted):
887         (WebCore::FrameLoaderClientQt::progressCompleted):
888         (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
889         (WebCore::FrameLoaderClientQt::willChangeTitle):
890         (WebCore::FrameLoaderClientQt::didChangeTitle):
891         (WebCore::FrameLoaderClientQt::finishedLoading):
892         (WebCore::FrameLoaderClientQt::finalSetupForReplace):
893         (WebCore::FrameLoaderClientQt::setDefersLoading):
894         (WebCore::FrameLoaderClientQt::isArchiveLoadPending):
895         (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad):
896         (WebCore::FrameLoaderClientQt::clearArchivedResources):
897         (WebCore::FrameLoaderClientQt::canShowMIMEType):
898         (WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
899         (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
900         (WebCore::FrameLoaderClientQt::frameLoadCompleted):
901         (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState):
902         (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
903         (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent):
904         (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll):
905         (WebCore::FrameLoaderClientQt::didFinishLoad):
906         (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
907         (WebCore::FrameLoaderClientQt::setTitle):
908         (WebCore::FrameLoaderClientQt::userAgent):
909         * loader/qt/FrameLoaderClientQt.h: Added.
910         * loader/qt/FrameLoaderQt.cpp:
911         (WebCore::FrameLoader::submitForm):
912         (WebCore::FrameLoader::overrideMediaType):
913         (WebCore::FrameLoader::getHistoryLength):
914         (WebCore::FrameLoader::referrer):
915         (WebCore::FrameLoader::detachFromParent):
916         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
917         (WebCore::FrameLoader::goBackOrForward):
918         (WebCore::FrameLoader::historyURL):
919         (WebCore::FrameLoader::didFirstLayout):
920         (WebCore::FrameLoader::canGoBackOrForward):
921         (WebCore::FrameLoader::partClearedInBegin):
922         (WebCore::FrameLoader::saveDocumentState):
923         (WebCore::FrameLoader::restoreDocumentState):
924         (WebCore::FrameLoader::didChangeTitle):
925         (WebCore::FrameLoader::redirectDataToPlugin):
926         (WebCore::PolicyCheck::PolicyCheck):
927         (WebCore::PolicyCheck::clear):
928         (WebCore::PolicyCheck::set):
929         (WebCore::PolicyCheck::call):
930         (WebCore::PolicyCheck::clearRequest):
931         * loader/qt/NavigationActionQt.cpp: Added.
932         (WebCore::navigationType):
933         (WebCore::NavigationAction::NavigationAction):
934         * loader/qt/ResourceLoaderQt.cpp: Added.
935         (WebCore::ResourceLoader::ResourceLoader):
936         (WebCore::ResourceLoader::~ResourceLoader):
937         (WebCore::ResourceLoader::setDefersLoading):
938         (WebCore::ResourceLoader::cancel):
939         (WebCore::ResourceLoader::loadsBlocked):
940         * platform/MimeTypeRegistry.cpp:
941         (WebCore::initialiseSupportedImageMIMETypes):
942         * platform/network/qt/ResourceHandleManager.cpp:
943         (WebCore::ResourceHandleManager::slotResult):
944         (WebCore::ResourceHandleManager::cancel):
945         * platform/qt/ChromeClientQt.cpp: Added.
946         (WebCore::rootWindowForFrame):
947         (WebCore::ChromeClientQt::ChromeClientQt):
948         (WebCore::ChromeClientQt::~ChromeClientQt):
949         (WebCore::ChromeClientQt::setWindowRect):
950         (WebCore::ChromeClientQt::windowRect):
951         (WebCore::ChromeClientQt::pageRect):
952         (WebCore::ChromeClientQt::scaleFactor):
953         (WebCore::ChromeClientQt::focus):
954         (WebCore::ChromeClientQt::unfocus):
955         (WebCore::ChromeClientQt::createWindow):
956         (WebCore::ChromeClientQt::createModalDialog):
957         (WebCore::ChromeClientQt::show):
958         (WebCore::ChromeClientQt::canRunModal):
959         (WebCore::ChromeClientQt::runModal):
960         (WebCore::ChromeClientQt::setToolbarsVisible):
961         (WebCore::ChromeClientQt::toolbarsVisible):
962         (WebCore::ChromeClientQt::setStatusbarVisible):
963         (WebCore::ChromeClientQt::statusbarVisible):
964         (WebCore::ChromeClientQt::setScrollbarsVisible):
965         (WebCore::ChromeClientQt::scrollbarsVisible):
966         (WebCore::ChromeClientQt::setMenubarVisible):
967         (WebCore::ChromeClientQt::menubarVisible):
968         (WebCore::ChromeClientQt::setResizable):
969         * platform/qt/ChromeClientQt.h: Added.
970         * platform/qt/EditorClientQt.cpp:
971         (WebCore::EditorClientQt::shouldBeginEditing):
972         (WebCore::EditorClientQt::shouldEndEditing):
973         (WebCore::EditorClientQt::shouldApplyStyle):
974         (WebCore::EditorClientQt::didBeginEditing):
975         (WebCore::EditorClientQt::respondToChangedContents):
976         (WebCore::EditorClientQt::didEndEditing):
977         * platform/qt/EditorClientQt.h:
978         * platform/qt/FrameQt.cpp:
979         (WebCore::FrameQt::FrameQt):
980         (WebCore::FrameQt::~FrameQt):
981         (WebCore::FrameQt::keyEvent):
982         * platform/qt/FrameQt.h:
983         * platform/qt/FrameQtClient.cpp:
984         (WebCore::FrameQtClientDefault::openURL):
985         (WebCore::FrameQtClientDefault::didReceiveData):
986         (WebCore::FrameQtClientDefault::receivedAllData):
987         * platform/qt/ImageQt.cpp:
988         * platform/qt/MimeTypeRegistryQt.cpp: Added.
989         (WebCore::getMIMETypeForUTI):
990         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
991         * platform/qt/PageQt.cpp:
992         * platform/qt/PlatformKeyboardEventQt.cpp:
993         (WebCore::keyIdentifierForQtKeyCode):
994         * platform/qt/ScreenQt.cpp:
995         * platform/qt/TemporaryLinkStubs.cpp:
996         (WebCore::TextField::TextField):
997         (WebCore::screenDepth):
998         (WebCore::screenDepthPerComponent):
999         (WebCore::screenIsMonochrome):
1000         (WebCore::screenRect):
1001         (WebCore::screenAvailableRect):
1002
1003 2006-11-10  Brady Eidson <beidson@apple.com>
1004
1005         Reviewed by Mitz
1006
1007         http://bugs.webkit.org/show_bug.cgi?id=11554
1008         Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
1009         in case the icon load fails after some data has been received. 
1010
1011         * loader/icon/IconLoader.cpp:
1012         (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB
1013         on error.  Also, as a loader re-factoring sanity check, added an assertion
1014         (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon 
1015         is already committed to the DB.  Skip doing that step twice.
1016
1017 2006-11-09  Oliver Hunt  <oliver@apple.com>
1018
1019         Reviewed by Brady.
1020
1021         Pulled MIME type handling out of WebFrameBridge and added
1022         a general C++ class to store/query MIME info
1023         Added an Obj-C bridge to provide WebKit with access to the
1024         MimeTypeRegistry for non-Obj-C++ classes.
1025         
1026         * WebCore.exp:
1027         * WebCore.xcodeproj/project.pbxproj:
1028         * bridge/mac/WebCoreFrameBridge.h:
1029         * bridge/mac/WebCoreFrameBridge.mm:
1030         * bridge/mac/WebMimeTypeRegistryBridge.h: Added.
1031         * bridge/mac/WebMimeTypeRegistryBridge.mm: Added.
1032         (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]):
1033         (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]):
1034         (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]):
1035         (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]):
1036         (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
1037         * platform/Image.cpp:
1038         (WebCore::Image::supportsType):
1039         * platform/Image.h:
1040         * platform/MimeTypeRegistry.cpp: Added.
1041         (WebCore::initialiseSupportedImageMIMETypes):
1042         (WebCore::initialiseSupportedNonImageMimeTypes):
1043         (WebCore::initialiseMimeTypeRegistry):
1044         (WebCore::MimeTypeRegistry::isSupportedImageMIMEType):
1045         (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType):
1046         (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType):
1047         (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes):
1048         (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes):
1049         (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
1050         * platform/MimeTypeRegistry.h: Added.
1051         * platform/mac/ImageMac.mm:
1052         * platform/mac/MimeTypeRegistryMac.mm: Added.
1053         (WebCore::getMIMETypeForUTI):
1054         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
1055
1056 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
1057
1058         Reviewed by Oliver.
1059
1060         - rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search
1061         for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size
1062         for you and use vsnprintf.
1063
1064         * bindings/js/kjs_window.cpp:
1065         (KJS::Window::isSafeScript):
1066         * css/cssparser.cpp:
1067         (WebCore::CSSParser::parseColorFromValue):
1068         * dom/StyledElement.cpp:
1069         (WebCore::StyledElement::addCSSColor):
1070         * dom/XMLTokenizer.cpp:
1071         (WebCore::XMLTokenizer::handleError):
1072         * ksvg2/css/SVGCSSParser.cpp:
1073         (WebCore::CSSParser::parseSVGPaint):
1074         (WebCore::CSSParser::parseSVGColor):
1075         * ksvg2/svg/SVGPathSegArc.h:
1076         (WebCore::SVGPathSegArcAbs::toString):
1077         (WebCore::SVGPathSegArcRel::toString):
1078         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
1079         (WebCore::SVGPathSegCurvetoCubicAbs::toString):
1080         (WebCore::SVGPathSegCurvetoCubicRel::toString):
1081         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
1082         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
1083         (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
1084         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
1085         (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
1086         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
1087         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
1088         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
1089         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
1090         * ksvg2/svg/SVGPathSegLineto.h:
1091         (WebCore::SVGPathSegLinetoAbs::toString):
1092         (WebCore::SVGPathSegLinetoRel::toString):
1093         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
1094         (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
1095         (WebCore::SVGPathSegLinetoHorizontalRel::toString):
1096         * ksvg2/svg/SVGPathSegLinetoVertical.h:
1097         (WebCore::SVGPathSegLinetoVerticalAbs::toString):
1098         (WebCore::SVGPathSegLinetoVerticalRel::toString):
1099         * ksvg2/svg/SVGPathSegMoveto.h:
1100         (WebCore::SVGPathSegMovetoAbs::toString):
1101         (WebCore::SVGPathSegMovetoRel::toString):
1102         * ksvg2/svg/SVGPolyElement.cpp:
1103         (WebCore::SVGPolyElement::notifyAttributeChange):
1104         * ksvg2/svg/SVGUseElement.cpp:
1105         (WebCore::SVGUseElement::closeRenderer):
1106         * loader/icon/IconDatabase.cpp:
1107         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
1108         * loader/icon/SQLDatabase.cpp:
1109         (WebCore::SQLDatabase::setSynchronous):
1110         * platform/Color.cpp:
1111         (WebCore::Color::name):
1112         * platform/DeprecatedString.cpp:
1113         (WebCore::DeprecatedString::setNum):
1114         (WebCore::DeprecatedString::format):
1115         * platform/DeprecatedString.h:
1116         * platform/PlatformString.h:
1117         * platform/String.cpp:
1118         (WebCore::String::format):
1119         (WebCore::String::number):
1120         * platform/mac/KeyEventMac.mm:
1121         (WebCore::keyIdentifierForKeyEvent):
1122         * platform/win/KeyEventWin.cpp:
1123         (WebCore::keyIdentifierForWindowsKeyCode):
1124         * rendering/RenderListMarker.cpp:
1125         (WebCore::RenderListMarker::calcMinMaxWidth):
1126
1127 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
1128
1129         Reviewed by Anders.
1130
1131         - fixed "Regression: Can't log into gmail.com"
1132         - fixed "iBench doesn't report results - tests run but no number is recorded"
1133         
1134         * platform/network/cf/FormDataStreamCFNet.cpp:
1135         (WebCore::setHTTPBody): Removed extra ! character.
1136
1137 2006-11-09  Beth Dakin  <bdakin@apple.com>
1138
1139         Reviewed by Hyatt.
1140
1141         Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in 
1142         WebCore::RenderBlock::skipWhitespace
1143
1144         Note that this will still crash on Debug builds because it will hit 
1145         an assertion failure in editing. (One of the reasons there is no 
1146         layout test along with this fix.) There is definitely some editing 
1147         wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
1148         id=10144 for updates on the assertion failure bug.
1149
1150         * rendering/RootInlineBox.cpp:
1151         (WebCore::RootInlineBox::childRemoved): It is possible for a 
1152         prevRootBox and its prevRootBox to share a lineBreakObj. So instead 
1153         of just clearing the lineBreakObj of the prevRootBox, cycle through 
1154         all prevRootBoxs with the same lineBreakObj. 
1155
1156 2006-11-09  Adam Roben  <aroben@apple.com>
1157
1158         Reviewed by Geoff.
1159
1160         Fix the change in behavior I caused in r17680 with my build fix.
1161
1162         * rendering/RenderObject.cpp:
1163         (WebCore::RenderObject::maxTopMargin):
1164         (WebCore::RenderObject::maxBottomMargin):
1165
1166 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
1167
1168         Reviewed by Adam, Oliver.
1169
1170         Move more functions to Editor.
1171
1172         * bridge/EditorClient.h:
1173         * bridge/mac/FrameMac.h:
1174         * bridge/mac/FrameMac.mm:
1175         * bridge/mac/WebCoreFrameBridge.h:
1176         * editing/EditCommand.cpp:
1177         (WebCore::EditCommand::apply):
1178         (WebCore::EditCommand::unapply):
1179         (WebCore::EditCommand::reapply):
1180         * editing/Editor.cpp:
1181         (WebCore::Editor::respondToChangedContents):
1182         (WebCore::dispatchEditableContentChangedEvents):
1183         (WebCore::Editor::appliedEditing):
1184         (WebCore::Editor::unappliedEditing):
1185         (WebCore::Editor::reappliedEditing):
1186         * editing/Editor.h:
1187         * editing/TypingCommand.cpp:
1188         (WebCore::TypingCommand::typingAddedToOpenCommand):
1189         * page/Frame.cpp:
1190         * page/Frame.h:
1191
1192 2006-11-09  Darin Adler  <darin@apple.com>
1193
1194         * rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
1195
1196 2006-11-09  Alice Liu  <alice.liu@apple.com>
1197
1198         Reviewed by Beth Dakin.
1199
1200         Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
1201         All existing layout tests pass
1202
1203         * html/HTMLTableElement.cpp:
1204         (WebCore::HTMLTableElement::deleteRow):
1205         check lastSection before deleting row
1206
1207 2006-11-09  Darin Adler  <darin@apple.com>
1208
1209         - improved version of last night's build fix (should not do using namespace in a header)
1210
1211         * rendering/RenderObject.h:
1212         * rendering/RenderObject.cpp:
1213         (WebCore::RenderObject::maxTopMargin):
1214         (WebCore::RenderObject::maxBottomMargin):
1215
1216 2006-11-08  Maciej Stachowiak  <mjs@apple.com>
1217
1218         Reviewed by Geoff.
1219         
1220         - added ResourceError class and didFailWithError client method
1221
1222         * WebCore.xcodeproj/project.pbxproj:
1223         * loader/icon/IconLoader.cpp:
1224         (WebCore::IconLoader::didFailWithError):
1225         (WebCore::IconLoader::didFinishLoading):
1226         * loader/icon/IconLoader.h:
1227         * loader/loader.cpp:
1228         (WebCore::Loader::receivedAllData):
1229         (WebCore::Loader::didFailWithError):
1230         * loader/loader.h:
1231         * loader/mac/SubresourceLoaderMac.mm:
1232         (WebCore::SubresourceLoader::didFail):
1233         (WebCore::SubresourceLoader::didCancel):
1234         * platform/cf/RetainPtr.h:
1235         (WebCore::):
1236         (WebCore::adoptCFReference):
1237         (WebCore::RetainPtr::RetainPtr):
1238         (WebCore::::adopt):
1239         * platform/network/ResourceError.cpp: Added.
1240         * platform/network/ResourceError.h: Added.
1241         (WebCore::ResourceError::ResourceError):
1242         (WebCore::ResourceError::domain):
1243         (WebCore::ResourceError::errorCode):
1244         (WebCore::ResourceError::failingURL):
1245         (WebCore::ResourceError::localizedDescription):
1246         (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
1247         * platform/network/ResourceHandle.cpp:
1248         * platform/network/ResourceHandle.h:
1249         * platform/network/ResourceHandleClient.h:
1250         (WebCore::ResourceHandleClient::didFailWithError):
1251         * platform/network/cf/ResourceHandleCFNet.cpp:
1252         (WebCore::didFail):
1253         (WebCore::ResourceHandle::cancel):
1254         * platform/network/mac/ResourceErrorMac.mm: Added.
1255         (-[NSError WebCore]):
1256         * platform/network/mac/ResourceHandleMac.mm:
1257         (WebCore::ResourceHandle::reportError):
1258         * xml/xmlhttprequest.cpp:
1259         (WebCore::XMLHttpRequest::didFailWithError):
1260         (WebCore::XMLHttpRequest::didFinishLoading):
1261         * xml/xmlhttprequest.h:
1262
1263 2006-11-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1264
1265         Reviewed by Maciej.
1266
1267         Linux\Gdk fixes.
1268
1269         * platform/gdk/ChromeClientGdk.h:
1270         (WebCore::ChromeClientGdk::~ChromeClientGdk):
1271         * platform/gdk/CursorGdk.cpp:
1272         (WebCore::Cursor::Cursor):
1273         (WebCore::moveCursor):
1274         * platform/gdk/FrameGdk.cpp:
1275         (WebCore::FrameGdk::FrameGdk):
1276         (WebCore::FrameGdk::submitForm):
1277         (WebCore::FrameGdk::urlSelected):
1278         * platform/gdk/PageGdk.cpp:
1279         * platform/gdk/ScreenClientGdk.h: Added.
1280         (WebCore::ScreenClientGdk::~ScreenClientGdk):
1281         * platform/gdk/ScreenGdk.cpp:
1282         (WebCore::ScreenClientGdk::depth):
1283         (WebCore::ScreenClientGdk::depthPerComponent):
1284         (WebCore::ScreenClientGdk::isMonochrome):
1285         (WebCore::ScreenClientGdk::rect):
1286         (WebCore::ScreenClientGdk::usableRect):
1287         * platform/gdk/TemporaryLinkStubs.cpp:
1288         (FrameGdk::historyURL):
1289         (ChromeClientGdk::windowRect):
1290         (ChromeClientGdk::setWindowRect):
1291         (ChromeClientGdk::pageRect):
1292         (ChromeClientGdk::scaleFactor):
1293         (ChromeClientGdk::focus):
1294         (ChromeClientGdk::unfocus):
1295         (ChromeClientGdk::createWindow):
1296         (ChromeClientGdk::createModalDialog):
1297         (ChromeClientGdk::show):
1298         (ChromeClientGdk::canRunModal):
1299         (ChromeClientGdk::runModal):
1300         (ChromeClientGdk::setToolbarsVisible):
1301         (ChromeClientGdk::toolbarsVisible):
1302         (ChromeClientGdk::setStatusbarVisible):
1303         (ChromeClientGdk::statusbarVisible):
1304         (ChromeClientGdk::setScrollbarsVisible):
1305         (ChromeClientGdk::scrollbarsVisible):
1306         (ChromeClientGdk::setMenubarVisible):
1307         (ChromeClientGdk::menubarVisible):
1308         (ChromeClientGdk::setResizable):
1309         * platform/network/ResourceHandleInternal.h:
1310         (WebCore::ResourceHandleInternal::client):
1311         * platform/network/gdk/ResourceHandleManager.cpp:
1312         (WebCore::writeCallback):
1313         (WebCore::ResourceHandleManager::downloadTimerCallback):
1314         (WebCore::ResourceHandleManager::remove):
1315
1316 2006-11-08  Adam Roben  <aroben@apple.com>
1317
1318         Build fix.
1319
1320         * rendering/RenderObject.h:
1321         (WebCore::RenderObject::maxTopMargin):
1322         (WebCore::RenderObject::maxBottomMargin):
1323
1324 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1325
1326         Reviewed by Anders Carlsson.
1327
1328         Made Screen a good platform citizen by removing its reference to Page. This
1329         made a class unnecessary, so all screen fuctions are stand-alone now.
1330
1331         * bindings/js/kjs_window.cpp: Removed unnecessary subtractions
1332         when computing the screen's available dimensions.
1333
1334 2006-11-08  Sam Weinig  <sam.weinig@gmail.com>
1335
1336         Reviewed by Mitz.
1337
1338         Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
1339         Cleanup RenderObject
1340
1341         * rendering/RenderObject.cpp:
1342         (WebCore::RenderObject::operator delete):
1343         (WebCore::RenderObject::createObject):
1344         (WebCore::RenderObjectCounter::~RenderObjectCounter):
1345         (WebCore::RenderObject::RenderObject):
1346         (WebCore::RenderObject::isDescendantOf):
1347         (WebCore::RenderObject::isRoot):
1348         (WebCore::RenderObject::addChild):
1349         (WebCore::RenderObject::removeChildNode):
1350         (WebCore::RenderObject::removeChild):
1351         (WebCore::RenderObject::appendChildNode):
1352         (WebCore::RenderObject::insertChildNode):
1353         (WebCore::RenderObject::nextInPreOrder):
1354         (WebCore::RenderObject::nextInPreOrderAfterChildren):
1355         (WebCore::RenderObject::previousInPreOrder):
1356         (WebCore::RenderObject::isEditable):
1357         (WebCore::RenderObject::nextEditable):
1358         (WebCore::RenderObject::previousEditable):
1359         (WebCore::RenderObject::firstLeafChild):
1360         (WebCore::RenderObject::lastLeafChild):
1361         (WebCore::RenderObject::addLayers):
1362         (WebCore::RenderObject::removeLayers):
1363         (WebCore::RenderObject::moveLayers):
1364         (WebCore::RenderObject::findNextLayer):
1365         (WebCore::RenderObject::enclosingLayer):
1366         (WebCore::RenderObject::updateFirstLetter):
1367         (WebCore::RenderObject::offsetParent):
1368         (WebCore::RenderObject::scroll):
1369         (WebCore::RenderObject::hasStaticX):
1370         (WebCore::RenderObject::setNeedsLayout):
1371         (WebCore::RenderObject::setChildNeedsLayout):
1372         (WebCore::RenderObject::markContainingBlocksForLayout):
1373         (WebCore::RenderObject::containingBlock):
1374         (WebCore::RenderObject::containingBlockWidth):
1375         (WebCore::RenderObject::containingBlockHeight):
1376         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
1377         (WebCore::RenderObject::drawBorderArc):
1378         (WebCore::RenderObject::drawBorder):
1379         (WebCore::RenderObject::paintBorderImage):
1380         (WebCore::RenderObject::paintBorder):
1381         (WebCore::RenderObject::absoluteRects):
1382         (WebCore::RenderObject::addPDFURLRect):
1383         (WebCore::RenderObject::addFocusRingRects):
1384         (WebCore::RenderObject::paintOutline):
1385         (WebCore::RenderObject::repaint):
1386         (WebCore::RenderObject::repaintRectangle):
1387         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
1388         (WebCore::RenderObject::repaintObjectsBeforeLayout):
1389         (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
1390         (WebCore::RenderObject::information):
1391         (WebCore::RenderObject::dump):
1392         (WebCore::selectStartNode):
1393         (WebCore::RenderObject::shouldSelect):
1394         (WebCore::RenderObject::draggableNode):
1395         (WebCore::RenderObject::createAnonymousBlock):
1396         (WebCore::RenderObject::handleDynamicFloatPositionChange):
1397         (WebCore::RenderObject::setStyle):
1398         (WebCore::RenderObject::setStyleInternal):
1399         (WebCore::RenderObject::updateBackgroundImages):
1400         (WebCore::RenderObject::absolutePosition):
1401         (WebCore::RenderObject::caretRect):
1402         (WebCore::RenderObject::paddingTop):
1403         (WebCore::RenderObject::paddingBottom):
1404         (WebCore::RenderObject::paddingLeft):
1405         (WebCore::RenderObject::paddingRight):
1406         (WebCore::RenderObject::tabWidth):
1407         (WebCore::RenderObject::container):
1408         (WebCore::RenderObject::removeFromObjectLists):
1409         (WebCore::RenderObject::destroy):
1410         (WebCore::RenderObject::arenaDelete):
1411         (WebCore::RenderObject::hitTest):
1412         (WebCore::RenderObject::setInnerNode):
1413         (WebCore::RenderObject::nodeAtPoint):
1414         (WebCore::RenderObject::verticalPositionHint):
1415         (WebCore::RenderObject::getVerticalPosition):
1416         (WebCore::RenderObject::lineHeight):
1417         (WebCore::RenderObject::invalidateVerticalPositions):
1418         (WebCore::RenderObject::recalcMinMaxWidths):
1419         (WebCore::RenderObject::scheduleRelayout):
1420         (WebCore::RenderObject::setInlineBoxWrapper):
1421         (WebCore::RenderObject::firstLineStyle):
1422         (WebCore::RenderObject::getPseudoStyle):
1423         (WebCore::RenderObject::getTextDecorationColors):
1424         (WebCore::RenderObject::addDashboardRegions):
1425         (WebCore::RenderObject::collectDashboardRegions):
1426         (WebCore::RenderObject::avoidsFloats):
1427         (WebCore::RenderObject::findCounter):
1428         (WebCore::RenderObject::backslashAsCurrencySymbol):
1429         (WebCore::RenderObject::imageChanged):
1430         (WebCore::RenderObject::previousOffset):
1431         (WebCore::RenderObject::nextOffset):
1432         (WebCore::RenderObject::inlineBox):
1433         * rendering/RenderObject.h:
1434         (WebCore::):
1435         (WebCore::RenderObject::renderName):
1436         (WebCore::RenderObject::parent):
1437         (WebCore::RenderObject::previousSibling):
1438         (WebCore::RenderObject::nextSibling):
1439         (WebCore::RenderObject::firstChild):
1440         (WebCore::RenderObject::lastChild):
1441         (WebCore::RenderObject::getOverflowClipRect):
1442         (WebCore::RenderObject::getClipRect):
1443         (WebCore::RenderObject::getBaselineOfFirstLineBox):
1444         (WebCore::RenderObject::setEdited):
1445         (WebCore::RenderObject::setStaticX):
1446         (WebCore::RenderObject::setStaticY):
1447         (WebCore::RenderObject::setPreviousSibling):
1448         (WebCore::RenderObject::setNextSibling):
1449         (WebCore::RenderObject::setParent):
1450         (WebCore::RenderObject::isInlineBlockOrInlineTable):
1451         (WebCore::RenderObject::isRenderView):
1452         (WebCore::RenderObject::childrenInline):
1453         (WebCore::RenderObject::setChildrenInline):
1454         (WebCore::RenderObject::isAnonymousBlock):
1455         (WebCore::RenderObject::isDragging):
1456         (WebCore::RenderObject::needsLayout):
1457         (WebCore::RenderObject::setMinMaxKnown):
1458         (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
1459         (WebCore::RenderObject::setPositioned):
1460         (WebCore::RenderObject::setRelPositioned):
1461         (WebCore::RenderObject::setFloating):
1462         (WebCore::RenderObject::setInline):
1463         (WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
1464         (WebCore::RenderObject::setReplaced):
1465         (WebCore::RenderObject::PaintInfo::PaintInfo):
1466         (WebCore::RenderObject::paintBackgroundExtended):
1467         (WebCore::RenderObject::calcWidth):
1468         (WebCore::RenderObject::updateFromElement):
1469         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
1470         (WebCore::RenderObject::setOverrideSize):
1471         (WebCore::RenderObject::setPos):
1472         (WebCore::RenderObject::setWidth):
1473         (WebCore::RenderObject::setHeight):
1474         (WebCore::RenderObject::absolutePositionForContent):
1475         (WebCore::RenderObject::overflowHeight):
1476         (WebCore::RenderObject::overflowWidth):
1477         (WebCore::RenderObject::setOverflowHeight):
1478         (WebCore::RenderObject::setOverflowWidth):
1479         (WebCore::RenderObject::overflowLeft):
1480         (WebCore::RenderObject::overflowTop):
1481         (WebCore::RenderObject::overflowRect):
1482         (WebCore::RenderObject::stopAutoscroll):
1483         (WebCore::RenderObject::collapsedMarginTop):
1484         (WebCore::RenderObject::collapsedMarginBottom):
1485         (WebCore::RenderObject::maxTopMargin):
1486         (WebCore::RenderObject::maxBottomMargin):
1487         (WebCore::RenderObject::):
1488         (WebCore::RenderObject::setTable):
1489         (WebCore::RenderObject::isFloatingOrPositioned):
1490         (WebCore::RenderObject::containsFloat):
1491         (WebCore::RenderObject::setSelectionState):
1492         (WebCore::RenderObject::SelectionInfo::SelectionInfo):
1493         (WebCore::RenderObject::lowestPosition):
1494         (WebCore::RenderObject::rightmostPosition):
1495         (WebCore::RenderObject::leftmostPosition):
1496         (WebCore::RenderObject::calcVerticalMargins):
1497         (WebCore::RenderObject::font):
1498
1499 2006-11-08  Darin Adler  <darin@apple.com>
1500
1501         Reviewed by Anders.
1502
1503         - added event parameters to focus-related functions so we can
1504           implement the "option-tab to all links" behavior without relying
1505           on a global "current event" -- also makes it work with DOM events
1506
1507         * page/Frame.h: Removed unneeded includes. Moved some functions
1508         that were misplaced into the appropriate sections.
1509         * page/Frame.cpp:
1510         (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
1511         PlatformKeyboardEvent to the DOM keyboard event class.
1512         (WebCore::Frame::tabsToLinks): Added event parameter.
1513         (WebCore::Frame::tabsToAllControls): Ditto.
1514         (WebCore::scanForForm): Fixed code that incorrectly assumes
1515         that an iframe is an HTMLFrameElement (no longer true since Geoff
1516         changed the class hierarchy a bit).
1517         (WebCore::Frame::hitTestResultAtPoint): Ditto.
1518
1519         * bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
1520         that were misplaced into the appropriate sections.
1521         * bridge/mac/FrameMac.mm:
1522         (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
1523         a PlatformKeyboardEvent.
1524         (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
1525         and pass event into next/previousFocusNode.
1526         (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
1527         the AppKit current event, if it's a keyboard event. Really just a hack that's
1528         needed to preserve some code we can remove once we deal with the last NSView-
1529         based form control.
1530         (WebCore::isKeyboardOptionTab): Added.
1531         (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
1532         option (alt) key is down.
1533         (WebCore::FrameMac::tabsToAllControls): Ditto.
1534         (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
1535         call resetMultipleFormSubmissionProtection() explicitly instead.
1536         (WebCore::FrameMac::mouseDown): Ditto.
1537
1538         * bridge/mac/WebCoreAXObject.mm:
1539         (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
1540         assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
1541         changed the class hierarchy a bit).
1542         (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
1543         prepareForUserAction() to call resetMultipleFormSubmissionProtection()
1544         explicitly instead.
1545
1546         * page/FrameView.h:
1547         * page/FrameView.cpp:
1548         (WebCore::FrameView::advanceFocus): Changed function to take an
1549         event parameter, and decide the direction based on the shift key
1550         modifier instead of a passed-in boolean.
1551
1552         * dom/Document.h:
1553         * dom/Document.cpp:
1554         (WebCore::Document::nextFocusNode): Added event parameter.
1555         (WebCore::Document::previousFocusNode): Ditto.
1556         * dom/Node.h:
1557         * dom/Node.cpp:
1558         (WebCore::Node::isKeyboardFocusable): Ditto.
1559         * html/HTMLAnchorElement.h:
1560         * html/HTMLAnchorElement.cpp:
1561         (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
1562         * html/HTMLGenericFormElement.h:
1563         * html/HTMLGenericFormElement.cpp:
1564         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
1565         * html/HTMLInputElement.h:
1566         * html/HTMLInputElement.cpp:
1567         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
1568         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
1569         * html/HTMLSelectElement.h:
1570         * html/HTMLSelectElement.cpp:
1571         (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
1572         * html/HTMLTextAreaElement.h:
1573         * html/HTMLTextAreaElement.cpp:
1574         (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
1575
1576         * dom/EventTargetNode.cpp:
1577         (WebCore::EventTargetNode::defaultEventHandler): Pass event to the
1578         advanceFocus function.
1579
1580         * platform/TextField.h:
1581         * platform/mac/TextFieldMac.mm: Removed the non-search field code.
1582
1583         * platform/mac/WebCoreTextField.h:
1584         * platform/mac/WebCoreTextField.mm: Removed the non-search field code.
1585         (-[WebCoreTextFieldController controlTextDidChange:]): Removed the
1586         call to FrameMac::handleKeyboardOptionTabInView, which is no longer
1587         needed since the default handler in HTMLInputElement takes care of
1588         option-tab.
1589
1590         * platform/mac/SliderMac.mm:
1591         (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
1592         and pass event into tabsToAllControls.
1593         (Slider::focusPolicy): Ditto.
1594
1595         * rendering/RenderLineEdit.cpp:
1596         (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
1597         (WebCore::RenderLineEdit::updateFromElement): Ditto.
1598
1599 2006-11-08  Brady Eidson  <beidson@apple.com>
1600
1601         Reviewed by Dave Harrison, Oliver, and Darin 
1602         (oh my!  where was superkevin on this one?)
1603
1604         <rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
1605
1606         More "free nil checking" we lost in the transition from ObjC to C++
1607
1608         * loader/mac/FrameLoaderMac.mm:
1609         (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
1610         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
1611
1612 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1613
1614         Reviewed by Adam.
1615
1616         Move more code into editor.
1617         
1618         * WebCore.exp:
1619         * bridge/EditorClient.h:
1620         * bridge/mac/FrameMac.h:
1621         * bridge/mac/FrameMac.mm:
1622         * bridge/mac/WebCoreFrameBridge.h:
1623         * dom/Document.cpp:
1624         (WebCore::Document::relinquishesEditingFocus):
1625         (WebCore::Document::acceptsEditingFocus):
1626         (WebCore::Document::didBeginEditing):
1627         (WebCore::Document::didEndEditing):
1628         * editing/Editor.cpp:
1629         (WebCore::Editor::indent):
1630         (WebCore::Editor::outdent):
1631         * editing/Editor.h:
1632         * page/Frame.cpp:
1633         * page/Frame.h:
1634
1635 2006-11-08  Beth Dakin  <bdakin@apple.com>
1636
1637         Reviewed by Adam.
1638
1639         Add ability to HitTestResult to ask if the inner non-shared node is 
1640         content editable.
1641
1642         * WebCore.exp: Export HitTestResult::isContentEditable()
1643         * rendering/HitTestResult.cpp:
1644         (WebCore::HitTestResult::isContentEditable):
1645         * rendering/HitTestResult.h:
1646
1647 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1648
1649         Build fix.
1650         
1651         * WebCore.xcodeproj/project.pbxproj:
1652         Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
1653
1654 2006-11-08  Timothy Hatcher  <timothy@apple.com>
1655
1656         Reviewed by Darin.
1657
1658         <rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
1659         <rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
1660
1661         Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
1662
1663         * bindings/objc/DOM.mm:
1664         (WebCore::kit):
1665         (-[DOMNode lineBoxRects]):
1666         (-[DOMRange boundingBox]):
1667         (-[DOMRange lineBoxRects]):
1668         * bindings/objc/DOMPrivate.h:
1669         * dom/Range.cpp:
1670         (WebCore::Range::boundingBox):
1671         (WebCore::Range::addLineBoxRects):
1672         * dom/Range.h:
1673         * rendering/RenderContainer.cpp:
1674         (WebCore::RenderContainer::addLineBoxRects):
1675         * rendering/RenderContainer.h:
1676         * rendering/RenderObject.cpp:
1677         (WebCore::RenderObject::addLineBoxRects):
1678         * rendering/RenderObject.h:
1679         * rendering/RenderText.cpp:
1680         (WebCore::RenderText::addLineBoxRects):
1681         * rendering/RenderText.h:
1682
1683 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1684
1685         Reviewed by Oliver.
1686         
1687         Move methods from the bridge and frame into editor.
1688         
1689         * WebCore.exp:
1690         * bridge/EditorClient.h:
1691         * bridge/mac/WebCoreFrameBridge.h:
1692         * bridge/mac/WebCoreFrameBridge.mm:
1693         * editing/Editor.cpp:
1694         (WebCore::Editor::removeFormattingAndStyle):
1695         (WebCore::Editor::applyStyle):
1696         (WebCore::Editor::applyParagraphStyle):
1697         (WebCore::Editor::applyStyleToSelection):
1698         (WebCore::Editor::applyParagraphStyleToSelection):
1699         (WebCore::Editor::toggleBold):
1700         (WebCore::Editor::toggleItalic):
1701         (WebCore::Editor::selectionStartHasStyle):
1702         * editing/Editor.h:
1703         * editing/JSEditor.cpp:
1704         * page/Frame.cpp:
1705         * page/Frame.h:
1706
1707 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1708
1709         Reviewed by Beth.
1710         
1711         Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
1712         be able to dispatch user events even when off-screen, so we have to support
1713         off-screen windows when handling mouse events.
1714
1715         * platform/Screen.h:
1716         * platform/mac/PlatformMouseEventMac.mm:
1717         (WebCore::globalPoint): Grab the best screen instead of the screen you're
1718         on, since you might be off-screen.
1719         * platform/mac/ScreenMac.mm:
1720         (WebCore::screenForWindow):
1721
1722 2006-11-08  Darin Adler  <darin@apple.com>
1723
1724         - fix bug caused by last-minute change to my check-in last night
1725           that is causing layout tests to hang
1726
1727         * dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
1728         * loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn
1729         a null string into an empty string before calling completeURL.
1730
1731 2006-11-08  Brady Eidson <beidson@apple.com>
1732
1733         Reviewed by Maciej
1734
1735         If the request has already been aborted, bail out of didFinishLoading()
1736         immediately.  This prevents state change notifications that aren't
1737         needed.
1738
1739         * xml/xmlhttprequest.cpp:
1740         (WebCore::XMLHttpRequest::didFinishLoading):
1741
1742 2006-11-08  Darin Adler  <darin@apple.com>
1743
1744         - another attempt to fix Qt build
1745
1746         * loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
1747
1748 2006-11-08  Darin Adler  <darin@apple.com>
1749
1750         Reviewed by Geoff.
1751
1752         - stray bits of my FrameLoader patch that I left out by accident
1753
1754         * loader/FrameLoader.cpp:
1755         (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer()
1756         inside the FrameLoader class.
1757         (WebCore::FrameLoader::requestFrame): Use less DeprecatedString.
1758         (WebCore::FrameLoader::clear): Stop the redirection timer.
1759         (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the
1760         entire function in an if statement. Use less DeprecatedString.
1761         (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator.
1762         (WebCore::FrameLoader::scheduleRefresh): Ditto.
1763         (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer()
1764         inside the FrameLoader class.
1765         * loader/mac/FrameLoaderMac.mm:
1766         (WebCore::FrameLoader::load): Ditto.
1767         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
1768
1769 2006-11-07  Beth Dakin  <bdakin@apple.com>
1770
1771         Reviewed by Hyatt.
1772
1773         Another go at fix for <rdar://problem/4820814> A crash occurs at 
1774         WebCore::HitTestResult::spellingToolTip() when mousing down on 
1775         iframe at www.macsurfer.com
1776
1777         The fix from yesterday caused a layout test regression which 
1778         exposed an existing bug. The existing bug was that we allowed text 
1779         nodes to stay in the head tag, but other browsers move them to the 
1780         body. The previous fix also caused a performance regression, which 
1781         was seemingly easy to fix by moving the new clause in 
1782         HTMLParser::handleError() to be below the HTMLElement case.
1783
1784         * html/HTMLDocument.cpp:
1785         (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to 
1786         be the child of the document.
1787         * html/HTMLHeadElement.cpp:
1788         (WebCore::HTMLHeadElement::childAllowed): Do not allow non-
1789         whitespace text nodes to be children of the head.
1790         * html/HTMLHeadElement.h:
1791         * html/HTMLParser.cpp:
1792         (WebCore::HTMLParser::handleError): Error case for comment nodes.
1793         * page/FrameView.cpp:
1794         (WebCore::FrameView::handleMousePressEvent): Safety-net null check 
1795         for the original crash. 
1796
1797 2006-11-07  Darin Adler  <darin@apple.com>
1798
1799         - another attempt to fix Qt build
1800
1801         * loader/icon/IconLoader.h: Added missing include.
1802
1803 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1804
1805         Reviewed by Tim Hatcher.
1806         
1807         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
1808         
1809         None of Screen's responsibilities require up-calls to WebKit or delegates, 
1810         so WebCore can handle it all.
1811         
1812         Moved Screen back from page/ to platform/ because it's a platform
1813         abstraction again.
1814
1815         Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
1816         since the two were always used together.
1817         
1818         Changed pixel depth queries to query the deepest screen. Darin mentioned
1819         that it might have been a feature, not a bug, to use the main/menubar screen
1820         regardless of the screen you were on. For scaling and flipping that's not
1821         the case, but for querying pixel depth I think it is. You want to know
1822         about the highest pixel depth your content may display on.
1823         
1824         Tests still pass.
1825
1826         * WebCore.exp:
1827         * WebCore.xcodeproj/project.pbxproj:
1828         * page/Page.cpp:
1829         (WebCore::Page::Page):
1830         * page/Page.h:
1831         * page/Screen.cpp: Removed.
1832         * page/Screen.h: Removed.
1833         * page/ScreenClient.h: Removed.
1834         * platform/mac/PlatformMouseEventMac.mm:
1835         (WebCore::globalPoint):
1836         * platform/mac/ScreenMac.mm:
1837         (WebCore::window):
1838         (WebCore::bestScreen):
1839         (WebCore::Screen::depth):
1840         (WebCore::Screen::depthPerComponent):
1841         (WebCore::Screen::isMonochrome):
1842         (WebCore::Screen::rect):
1843         (WebCore::Screen::usableRect):
1844         (WebCore::toUserSpace):
1845         (WebCore::toDeviceSpace):
1846
1847 2006-11-07  Darin Adler  <darin@apple.com>
1848
1849         - try to fix Qt build
1850
1851         * CMakeLists.txt: Updated for some file changes.
1852         * WebCoreSources.bkl: Ditto.
1853
1854 2006-11-07  Darin Adler  <darin@apple.com>
1855
1856         Reviewed by Geoff.
1857
1858         - moved loader code from Frame/FrameMac to FrameLoader
1859
1860         * WebCore.exp:
1861         * WebCore.xcodeproj/project.pbxproj:
1862         * bindings/js/JSXSLTProcessor.h:
1863         * bindings/js/kjs_events.cpp:
1864         (KJS::JSLazyEventListener::parseCode):
1865         * bindings/js/kjs_html.cpp:
1866         (KJS::JSHTMLDocument::putValueProperty):
1867         * bindings/js/kjs_navigator.cpp:
1868         (KJS::Navigator::getValueProperty):
1869         * bindings/js/kjs_proxy.cpp:
1870         (WebCore::KJSProxy::initScriptIfNeeded):
1871         * bindings/js/kjs_window.cpp:
1872         (KJS::Screen::Screen):
1873         (KJS::createNewWindow):
1874         (KJS::Window::getValueProperty):
1875         (KJS::Window::put):
1876         (KJS::Window::isSafeScript):
1877         (KJS::WindowFunc::callAsFunction):
1878         (KJS::ScheduledAction::execute):
1879         (KJS::Location::getValueProperty):
1880         (KJS::Location::put):
1881         (KJS::Location::toString):
1882         (KJS::LocationFunc::callAsFunction):
1883         (KJS::History::getValueProperty):
1884         (KJS::HistoryFunc::callAsFunction):
1885         * bindings/objc/DOM.mm:
1886         (+[DOMNode _nodeWith:WebCore::]):
1887         * bridge/mac/FrameMac.h:
1888         * bridge/mac/FrameMac.mm:
1889         (WebCore::FrameMac::~FrameMac):
1890         (WebCore::FrameMac::setView):
1891         (WebCore::FrameMac::setStatusBarText):
1892         * bridge/mac/WebCoreFrameBridge.h:
1893         * bridge/mac/WebCoreFrameBridge.mm:
1894         (-[WebCoreFrameBridge close]):
1895         (-[WebCoreFrameBridge addData:]):
1896         (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
1897         (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
1898         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1899         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1900         (-[WebCoreFrameBridge baseURL]):
1901         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
1902         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
1903         (-[WebCoreFrameBridge canProvideDocumentSource]):
1904         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
1905         * css/cssparser.cpp:
1906         (WebCore::CSSParser::parseContent):
1907         * dom/DOMImplementation.cpp:
1908         (WebCore::DOMImplementation::createDocument):
1909         (WebCore::DOMImplementation::createHTMLDocument):
1910         * dom/DOMImplementation.h:
1911         * dom/Document.cpp:
1912         (WebCore::Document::readyState):
1913         (WebCore::Document::updateTitle):
1914         (WebCore::Document::open):
1915         (WebCore::Document::close):
1916         (WebCore::Document::implicitClose):
1917         (WebCore::Document::processHttpEquiv):
1918         (WebCore::Document::referrer):
1919         (WebCore::Document::finishedParsing):
1920         * dom/ProcessingInstruction.cpp:
1921         (WebCore::ProcessingInstruction::checkStyleSheet):
1922         * dom/XMLTokenizer.cpp:
1923         (WebCore::XMLTokenizer::endElementNs):
1924         (WebCore::ignorableWhitespaceHandler):
1925         (WebCore::XMLTokenizer::notifyFinished):
1926         * editing/TextIterator.cpp:
1927         (WebCore::TextIterator::rangeFromLocationAndLength):
1928         * html/HTMLAnchorElement.cpp:
1929         (WebCore::HTMLAnchorElement::defaultEventHandler):
1930         * html/HTMLBaseElement.cpp:
1931         (WebCore::HTMLBaseElement::process):
1932         * html/HTMLDocument.cpp:
1933         (WebCore::HTMLDocument::lastModified):
1934         * html/HTMLFormElement.cpp:
1935         (WebCore::HTMLFormElement::formData):
1936         (WebCore::HTMLFormElement::submit):
1937         * html/HTMLFrameElementBase.cpp:
1938         (WebCore::HTMLFrameElementBase::isURLAllowed):
1939         (WebCore::HTMLFrameElementBase::openURL):
1940         (WebCore::HTMLFrameElementBase::willRemove):
1941         * html/HTMLInputElement.cpp:
1942         (WebCore::HTMLInputElement::setValueFromRenderer):
1943         * html/HTMLLinkElement.cpp:
1944         (WebCore::HTMLLinkElement::process):
1945         * html/HTMLParser.cpp:
1946         (WebCore::HTMLParser::handleError):
1947         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
1948         * html/HTMLPreElement.idl:
1949         * html/HTMLScriptElement.cpp:
1950         (WebCore::HTMLScriptElement::parseMappedAttribute):
1951         (WebCore::HTMLScriptElement::insertedIntoDocument):
1952         * html/HTMLTokenizer.cpp:
1953         (WebCore::HTMLTokenizer::scriptExecution):
1954         (WebCore::HTMLTokenizer::parseTag):
1955         (WebCore::HTMLTokenizer::write):
1956         (WebCore::HTMLTokenizer::stopParsing):
1957         (WebCore::HTMLTokenizer::timerFired):
1958         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1959         (WebCore::KCanvasFilterQuartz::prepareFilter):
1960         * ksvg2/svg/SVGAElement.cpp:
1961         (WebCore::SVGAElement::defaultEventHandler):
1962         * ksvg2/svg/SVGElement.cpp:
1963         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
1964         * loader/DocLoader.cpp:
1965         (WebCore::DocLoader::setLoadInProgress):
1966         * loader/FrameLoader.cpp:
1967         (WebCore::FormSubmission::FormSubmission):
1968         (WebCore::ScheduledRedirection::):
1969         (WebCore::ScheduledRedirection::ScheduledRedirection):
1970         (WebCore::cancelAll):
1971         (WebCore::getString):
1972         (WebCore::isBackForwardLoadType):
1973         (WebCore::numRequests):
1974         (WebCore::FrameLoader::FrameLoader):
1975         (WebCore::FrameLoader::~FrameLoader):
1976         (WebCore::FrameLoader::createWindow):
1977         (WebCore::FrameLoader::changeLocation):
1978         (WebCore::FrameLoader::urlSelected):
1979         (WebCore::FrameLoader::requestFrame):
1980         (WebCore::FrameLoader::loadSubframe):
1981         (WebCore::FrameLoader::submitFormAgain):
1982         (WebCore::FrameLoader::submitForm):
1983         (WebCore::FrameLoader::stopLoading):
1984         (WebCore::FrameLoader::stop):
1985         (WebCore::FrameLoader::closeURL):
1986         (WebCore::FrameLoader::cancelRedirection):
1987         (WebCore::FrameLoader::iconURL):
1988         (WebCore::FrameLoader::didOpenURL):
1989         (WebCore::FrameLoader::didExplicitOpen):
1990         (WebCore::FrameLoader::replaceContentsWithScriptResult):
1991         (WebCore::FrameLoader::executeScript):
1992         (WebCore::FrameLoader::cancelAndClear):
1993         (WebCore::FrameLoader::clear):
1994         (WebCore::FrameLoader::receivedFirstData):
1995         (WebCore::FrameLoader::responseMIMEType):
1996         (WebCore::FrameLoader::setResponseMIMEType):
1997         (WebCore::FrameLoader::begin):
1998         (WebCore::FrameLoader::write):
1999         (WebCore::FrameLoader::end):
2000         (WebCore::FrameLoader::endIfNotLoading):
2001         (WebCore::FrameLoader::startIconLoader):
2002         (WebCore::FrameLoader::commitIconURLToIconDatabase):
2003         (WebCore::FrameLoader::gotoAnchor):
2004         (WebCore::FrameLoader::finishedParsing):
2005         (WebCore::FrameLoader::loadDone):
2006         (WebCore::FrameLoader::checkCompleted):
2007         (WebCore::FrameLoader::checkEmitLoadEvent):
2008         (WebCore::FrameLoader::baseURL):
2009         (WebCore::FrameLoader::baseTarget):
2010         (WebCore::FrameLoader::completeURL):
2011         (WebCore::FrameLoader::scheduleRedirection):
2012         (WebCore::FrameLoader::scheduleLocationChange):
2013         (WebCore::FrameLoader::scheduleRefresh):
2014         (WebCore::FrameLoader::isScheduledLocationChangePending):
2015         (WebCore::FrameLoader::scheduleHistoryNavigation):
2016         (WebCore::FrameLoader::redirectionTimerFired):
2017         (WebCore::FrameLoader::encoding):
2018         (WebCore::FrameLoader::requestObject):
2019         (WebCore::FrameLoader::shouldUsePlugin):
2020         (WebCore::FrameLoader::loadPlugin):
2021         (WebCore::FrameLoader::clearRecordedFormValues):
2022         (WebCore::FrameLoader::recordFormValue):
2023         (WebCore::FrameLoader::parentCompleted):
2024         (WebCore::FrameLoader::outgoingReferrer):
2025         (WebCore::FrameLoader::lastModified):
2026         (WebCore::FrameLoader::opener):
2027         (WebCore::FrameLoader::setOpener):
2028         (WebCore::FrameLoader::openedByJavaScript):
2029         (WebCore::FrameLoader::setOpenedByJavaScript):
2030         (WebCore::FrameLoader::handleFallbackContent):
2031         (WebCore::FrameLoader::provisionalLoadStarted):
2032         (WebCore::FrameLoader::userGestureHint):
2033         (WebCore::FrameLoader::didNotOpenURL):
2034         (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
2035         (WebCore::FrameLoader::setEncoding):
2036         (WebCore::FrameLoader::addData):
2037         (WebCore::FrameLoader::canCachePage):
2038         (WebCore::FrameLoader::updatePolicyBaseURL):
2039         (WebCore::FrameLoader::setPolicyBaseURL):
2040         (WebCore::FrameLoader::scrollToAnchor):
2041         (WebCore::FrameLoader::isComplete):
2042         (WebCore::FrameLoader::isLoadingMainResource):
2043         (WebCore::FrameLoader::url):
2044         (WebCore::FrameLoader::startRedirectionTimer):
2045         (WebCore::FrameLoader::stopRedirectionTimer):
2046         (WebCore::FrameLoader::updateBaseURLForEmptyDocument):
2047         (WebCore::FrameLoader::completed):
2048         (WebCore::FrameLoader::started):
2049         (WebCore::FrameLoader::containsPlugins):
2050         (WebCore::FrameLoader::prepareForLoadStart):
2051         (WebCore::FrameLoader::setupForReplace):
2052         (WebCore::FrameLoader::setupForReplaceByMIMEType):
2053         (WebCore::FrameLoader::finalSetupForReplace):
2054         (WebCore::FrameLoader::load):
2055         (WebCore::FrameLoader::canTarget):
2056         (WebCore::FrameLoader::stopLoadingPlugIns):
2057         (WebCore::FrameLoader::stopLoadingSubresources):
2058         (WebCore::FrameLoader::stopLoadingSubframes):
2059         (WebCore::FrameLoader::stopAllLoaders):
2060         (WebCore::FrameLoader::cancelMainResourceLoad):
2061         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2062         (WebCore::FrameLoader::activeDocumentLoader):
2063         (WebCore::FrameLoader::addPlugInStreamLoader):
2064         (WebCore::FrameLoader::removePlugInStreamLoader):
2065         (WebCore::FrameLoader::hasMainResourceLoader):
2066         (WebCore::FrameLoader::isLoadingSubresources):
2067         (WebCore::FrameLoader::isLoadingPlugIns):
2068         (WebCore::FrameLoader::isLoading):
2069         (WebCore::FrameLoader::addSubresourceLoader):
2070         (WebCore::FrameLoader::removeSubresourceLoader):
2071         (WebCore::FrameLoader::releaseMainResourceLoader):
2072         (WebCore::FrameLoader::setDocumentLoader):
2073         (WebCore::FrameLoader::documentLoader):
2074         (WebCore::FrameLoader::setPolicyDocumentLoader):
2075         (WebCore::FrameLoader::provisionalDocumentLoader):
2076         (WebCore::FrameLoader::setProvisionalDocumentLoader):
2077         (WebCore::FrameLoader::state):
2078         (WebCore::FrameLoader::timeOfLastCompletedLoad):
2079         (WebCore::FrameLoader::setState):
2080         (WebCore::FrameLoader::clearProvisionalLoad):
2081         (WebCore::FrameLoader::markLoadComplete):
2082         (WebCore::FrameLoader::commitProvisionalLoad):
2083         (WebCore::FrameLoader::privateBrowsingEnabled):
2084         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
2085         (WebCore::FrameLoader::clientRedirected):
2086         (WebCore::FrameLoader::shouldReload):
2087         (WebCore::FrameLoader::closeOldDataSources):
2088         (WebCore::FrameLoader::open):
2089         (WebCore::FrameLoader::isStopping):
2090         (WebCore::FrameLoader::finishedLoading):
2091         (WebCore::FrameLoader::URL):
2092         (WebCore::FrameLoader::isArchiveLoadPending):
2093         (WebCore::FrameLoader::isHostedByObjectElement):
2094         (WebCore::FrameLoader::isLoadingMainFrame):
2095         (WebCore::FrameLoader::canShowMIMEType):
2096         (WebCore::FrameLoader::representationExistsForURLScheme):
2097         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
2098         (WebCore::FrameLoader::cancelContentPolicyCheck):
2099         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
2100         (WebCore::FrameLoader::finishedLoadingDocument):
2101         (WebCore::FrameLoader::isReplacing):
2102         (WebCore::FrameLoader::setReplacing):
2103         (WebCore::FrameLoader::revertToProvisional):
2104         (WebCore::FrameLoader::subframeIsLoading):
2105         (WebCore::FrameLoader::willChangeTitle):
2106         (WebCore::FrameLoader::loadType):
2107         (WebCore::FrameLoader::stopPolicyCheck):
2108         (WebCore::FrameLoader::continueAfterContentPolicy):
2109         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2110         (WebCore::FrameLoader::didFirstLayout):
2111         (WebCore::FrameLoader::frameLoadCompleted):
2112         (WebCore::FrameLoader::firstLayoutDone):
2113         (WebCore::FrameLoader::isQuickRedirectComing):
2114         (WebCore::FrameLoader::closeDocument):
2115         (WebCore::FrameLoader::detachChildren):
2116         (WebCore::FrameLoader::checkLoadComplete):
2117         (WebCore::FrameLoader::numPendingOrLoadingRequests):
2118         (WebCore::FrameLoader::setClient):
2119         (WebCore::FrameLoader::client):
2120         (WebCore::FrameLoader::userAgent):
2121         (WebCore::FrameLoader::createEmptyDocument):
2122         (WebCore::FrameLoader::tokenizerProcessedData):
2123         (WebCore::FrameLoader::didTellBridgeAboutLoad):
2124         (WebCore::FrameLoader::haveToldBridgeAboutLoad):
2125         (WebCore::FrameLoader::handledOnloadEvents):
2126         (WebCore::FrameLoader::frameDetached):
2127         (WebCore::FrameLoader::setTitle):
2128         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2129         * loader/FrameLoader.h:
2130         (WebCore::):
2131         * loader/FrameLoaderClient.h:
2132         * loader/PluginDocument.cpp:
2133         (WebCore::PluginTokenizer::createDocumentStructure):
2134         (WebCore::PluginTokenizer::writeRawData):
2135         * loader/ResourceLoader.h:
2136         * loader/TextResourceDecoder.cpp:
2137         (WebCore::TextResourceDecoder::checkForHeadCharset):
2138         * loader/icon/IconLoader.cpp:
2139         (WebCore::IconLoader::startLoading):
2140         (WebCore::IconLoader::finishLoading):
2141         * loader/loader.cpp:
2142         (WebCore::Loader::didReceiveResponse):
2143         * loader/mac/DocumentLoaderMac.mm:
2144         (WebCore::DocumentLoader::~DocumentLoader):
2145         (WebCore::DocumentLoader::stopLoading):
2146         (WebCore::DocumentLoader::finishedLoading):
2147         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
2148         (WebCore::DocumentLoader::setPrimaryLoadComplete):
2149         * loader/mac/FrameLoaderMac.mm:
2150         (WebCore::FrameLoader::load):
2151         (WebCore::FrameLoader::startLoading):
2152         (WebCore::FrameLoader::cancelMainResourceLoad):
2153         (WebCore::FrameLoader::receivedMainResourceError):
2154         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
2155         (WebCore::FrameLoader::commitProvisionalLoad):
2156         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2157         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2158         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2159         (WebCore::FrameLoader::detachFromParent):
2160         (WebCore::FrameLoader::addExtraFieldsToRequest):
2161         (WebCore::FrameLoader::loadResourceSynchronously):
2162         (WebCore::FrameLoader::createFrame):
2163         (WebCore::FrameLoader::objectContentType):
2164         (WebCore::nsArray):
2165         (WebCore::FrameLoader::createPlugin):
2166         (WebCore::FrameLoader::redirectDataToPlugin):
2167         (WebCore::FrameLoader::createJavaAppletWidget):
2168         (WebCore::FrameLoader::partClearedInBegin):
2169         (WebCore::FrameLoader::saveDocumentState):
2170         (WebCore::FrameLoader::restoreDocumentState):
2171         (WebCore::FrameLoader::overrideMediaType):
2172         (WebCore::FrameLoader::mainResourceData):
2173         (WebCore::FrameLoader::canGoBackOrForward):
2174         (WebCore::FrameLoader::originalRequestURL):
2175         (WebCore::FrameLoader::getHistoryLength):
2176         (WebCore::FrameLoader::goBackOrForward):
2177         (WebCore::FrameLoader::historyURL):
2178         (WebCore::FrameLoader::didFinishLoad):
2179         * loader/mac/LoaderFunctionsMac.mm:
2180         (WebCore::ServeSynchronousRequest):
2181         (WebCore::CheckCacheObjectStatus):
2182         * loader/mac/ResourceLoaderMac.mm:
2183         (WebCore::ResourceLoader::cancel):
2184         * loader/mac/SubresourceLoaderMac.mm:
2185         (WebCore::SubresourceLoader::create):
2186         * loader/qt/FrameLoaderQt.cpp: Added.
2187         (WebCore::FrameLoader::submitForm):
2188         (WebCore::FrameLoader::urlSelected):
2189         (WebCore::FrameLoader::setTitle):
2190         (WebCore::FrameLoader::createFrame):
2191         (WebCore::FrameLoader::objectContentType):
2192         (WebCore::FrameLoader::createPlugin):
2193         (WebCore::FrameLoader::createJavaAppletWidget):
2194         (WebCore::FrameLoader::originalRequestURL):
2195         * page/DOMWindow.cpp:
2196         (WebCore::DOMWindow::document):
2197         * page/Frame.cpp:
2198         (WebCore::Frame::~Frame):
2199         (WebCore::Frame::reparseConfiguration):
2200         (WebCore::Frame::shouldDragAutoNode):
2201         (WebCore::Frame::prepareForUserAction):
2202         (WebCore::FramePrivate::FramePrivate):
2203         (WebCore::FramePrivate::~FramePrivate):
2204         * page/Frame.h:
2205         * page/FramePrivate.h:
2206         * page/FrameView.cpp:
2207         (WebCore::FrameView::layout):
2208         (WebCore::FrameView::mediaType):
2209         * page/FrameView.h:
2210         * page/PageState.cpp:
2211         (WebCore::PageState::PageState):
2212         (WebCore::PageState::restoreJavaScriptState):
2213         * platform/mac/CookieJar.mm:
2214         (WebCore::setCookies):
2215         * platform/mac/TextCodecMac.cpp:
2216         * platform/mac/WebFontCache.mm:
2217         (+[WebFontCache fontWithFamily:traits:size:]):
2218         * platform/network/cf/ResourceHandleCFNet.cpp:
2219         (WebCore::ResourceHandle::start):
2220         * platform/network/mac/ResourceHandleMac.mm:
2221         (WebCore::ResourceHandle::start):
2222         * platform/qt/FrameQt.cpp:
2223         * platform/qt/FrameQt.h:
2224         * rendering/RenderApplet.cpp:
2225         (WebCore::RenderApplet::createWidgetIfNecessary):
2226         * rendering/RenderBlock.h:
2227         * rendering/RenderPartObject.cpp:
2228         (WebCore::isURLAllowed):
2229         (WebCore::RenderPartObject::updateWidget):
2230         * xml/DOMParser.cpp:
2231         (WebCore::DOMParser::parseFromString):
2232         * xml/XSLTProcessor.cpp:
2233         (WebCore::XSLTProcessor::createDocumentFromSource):
2234         * xml/xmlhttprequest.cpp:
2235         (WebCore::XMLHttpRequest::getResponseXML):
2236
2237 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
2238
2239         Reviewed by Geoff.
2240
2241         Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.
2242         
2243         * bridge/mac/FrameMac.mm:
2244         (WebCore::FrameMac::registerCommandForUndoOrRedo):
2245         * bridge/mac/WebCoreFrameBridge.h:
2246         * bridge/mac/WebCoreFrameBridge.mm:
2247         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2248         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2249         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]):
2250         (-[WebCoreFrameBridge selectionGranularity]):
2251         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
2252         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
2253         (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
2254         (-[WebCoreFrameBridge applyStyle:withUndoAction:]):
2255         (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
2256         * editing/SelectionController.cpp:
2257         (WebCore::SelectionController::setModifyBias):
2258         (WebCore::SelectionController::modify):
2259         * editing/SelectionController.h:
2260         (WebCore::SelectionController::):
2261         * editing/TextGranularity.h:
2262
2263 2006-11-07  Brady Eidson  <beidson@apple.com>
2264
2265         Reviewed by Maciej
2266
2267         Changed the check for "top level frame" to something much more valid
2268
2269         * page/Frame.cpp:
2270         (WebCore::Frame::endIfNotLoading):
2271
2272 2006-11-07  Beth Dakin  <bdakin@apple.com>
2273
2274         Reviewed by Hyatt (yesterday).
2275
2276         Here is part of my patch from yesterday that is safe to roll back 
2277         in. It will make the BuildBot happy.
2278
2279         * rendering/HitTestResult.cpp:
2280         (WebCore::HitTestResult::spellingToolTip): Null-check 
2281         m_innerNonSharedNode.
2282
2283 2006-11-07  Darin Adler  <darin@apple.com>
2284
2285         * loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse):
2286         Comment grammar fix.
2287
2288 2006-11-07  Darin Adler  <darin@apple.com>
2289
2290         Rolled out change for <rdar://problem/4820814>.
2291
2292         Beth's planning on landing a new change for it soon, but in the mean time
2293         we need layout tests succeeding again.
2294
2295 2006-11-07  Darin Adler  <darin@apple.com>
2296
2297         Reviewed by Brady.
2298
2299         - fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher
2300           crashes on launch in WebCore::ResourceLoader::start
2301
2302         No layout test, because this depends on cached icons, although there's
2303         perhaps a way to write a test for it with some further ingenuity.
2304
2305         * loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable
2306         to make explicit the fact that it can't be successfully copied.
2307         Remove notifyIconChanged function and put the contents in the caller.
2308         This eliminates the need for IconLoaderMac.mm. Added finishedLoading
2309         and clearLoadingState functions to share code. Removed m_url, since the
2310         resource handle already stores the URL. Renamed m_resourceLoader to
2311         m_handle to reflect the class's name change. Removed the 4096-byte
2312         inline buffer from m_data, since the malloc savings is not sufficient
2313         to offset the additional memory use. Removed m_httpStatusCode because
2314         we can instead cancel the load when we get a status code that reflects
2315         failure. Added m_loadIsInProgress boolean because we need to detect
2316         loads that complete during the ResourceHandle::create function call.
2317
2318         * loader/icon/IconLoader.cpp:
2319         (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress.
2320         Don't initialize m_httpStatusCode.
2321         (WebCore::IconLoader::~IconLoader): Updated for name change.
2322         (WebCore::IconLoader::startLoading): Added code to use the
2323         m_loadIsInProgress flag to detect if the load completed while inside
2324         the ResourceHandle::create function. Removed code to set m_url.
2325         (WebCore::IconLoader::stopLoading): Call clearLoadingState to share
2326         more code.
2327         (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle
2328         and finish loading if the HTTP status code indicates failure.
2329         (WebCore::IconLoader::didReceiveData): Removed assertion that checks
2330         the ResourceHandle, since we can't do that any more.
2331         (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading
2332         so we can share code with the new didReceiveResponse code path.
2333         (WebCore::IconLoader::finishLoading): Moved code here from the
2334         didFinishLoading callback. Pass a URL when calling
2335         commitIconURLToIconDatabase. Call notifyIconChanged directly here
2336         instead of using a separate function. Call clearLoadingState to
2337         share more code with stopLoading.
2338         (WebCore::IconLoader::clearLoadingState): Added.
2339
2340         * loader/mac/IconLoaderMac.mm: Removed.
2341         * WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
2342
2343 2006-11-06  David Harrison  <harrison@apple.com>
2344
2345         Reviewed by Darin.
2346
2347         <rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
2348
2349         * editing/pasteboard/3976872-expected.txt:
2350         * editing/pasteboard/4076267-2-expected.txt:
2351         * editing/pasteboard/4076267-3-expected.txt:
2352         * editing/pasteboard/4076267-expected.txt:
2353         * editing/pasteboard/8145-1-expected.txt:
2354         * editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
2355         * editing/pasteboard/paste-match-style-001-expected.txt:
2356         * editing/pasteboard/paste-match-style-002-expected.txt:
2357         * editing/pasteboard/paste-text-019-expected.txt:
2358         * editing/pasteboard/pasting-tabs-expected.txt:
2359         Updated because pasting text with no newlines does not use intermediate div.
2360         
2361         * editing/markup.cpp:
2362         (WebCore::fillContainerFromString):
2363         First parameter is now a Container so a fragment can be passed.
2364         
2365         (WebCore::createFragmentFromText):
2366         A string with no newlines gets added inline, rather than being put into a paragraph.
2367
2368 2006-11-06  Beth Dakin  <bdakin@apple.com>
2369
2370         Reviewed by Hyatt.
2371
2372         Fix for <rdar://problem/4820814> A crash occurs at 
2373         WebCore::HitTestResult::spellingToolTip() when mousing down on 
2374         iframe at www.macsurfer.com
2375
2376         The bug here is that the source of the iframe is only a comment, 
2377         and we were not properly constructing the frame because it was 
2378         sort-of empty but not.
2379
2380         * html/HTMLDocument.cpp:
2381         (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if 
2382         it is a comment node.
2383         * html/HTMLParser.cpp:
2384         (WebCore::HTMLParser::handleError): if n is a comment node and 
2385         there is no head, we create a head, insert in the document, and add 
2386         the comment node as a child. This is what Firefox does too. 
2387         * page/FrameView.cpp:
2388         (WebCore::FrameView::handleMousePressEvent): Safe-guard for the 
2389         fix. It is possible to get a mouse event without a target node, so 
2390         we null check it. (Of course, in the case of this bug, it should 
2391         not have been null, but it is a good thing to check for anyway.
2392         * rendering/HitTestResult.cpp:
2393         (WebCore::HitTestResult::spellingToolTip): Null-check 
2394         m_innerNonSharedNode.
2395
2396 2006-11-06  Justin Garcia  <justin.garcia@apple.com>
2397
2398         Reviewed by harrison
2399         
2400         <rdar://problem/4641880>
2401         Setting bullets to existing text grabs subsequent paragraph
2402         
2403         When a selection ends at the start of a paragraph, we rarely paint 
2404         the selection gap before that paragraph, because there often is no gap.  
2405         In a case like this, it's not obvious to the user that the selection 
2406         ends "inside" that paragraph, so it would be confusing if 
2407         InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.
2408         
2409         * editing/FormatBlockCommand.cpp:
2410         (WebCore::FormatBlockCommand::doApply): Moved the check for editability of
2411         the selection to a more appropriate place.  Change the endingSelection
2412         if it ends at the start of a paragraph.
2413         * editing/IndentOutdentCommand.cpp:
2414         (WebCore::IndentOutdentCommand::doApply): Ditto.
2415         * editing/InsertListCommand.cpp:
2416         (WebCore::InsertListCommand::doApply): Ditto.
2417
2418 2006-11-06  Brady Eidson  <beidson@apple.com>
2419
2420         Reviewed by Sarge
2421
2422         <rdar://problem/4822911> - ASSERTION was a little overzealous.  
2423         Toned it down a bit.
2424
2425         * xml/xmlhttprequest.cpp:
2426         (WebCore::XMLHttpRequest::didFinishLoading):  Toned down assertion
2427
2428 2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2429
2430         Reviewed by Maciej.
2431
2432         Linux\Gdk build fixes.
2433
2434         * loader/icon/IconDatabase.cpp:
2435         * loader/icon/SQLStatement.h:
2436         * platform/gdk/ChromeClientGdk.h: Added.
2437         (WebCore::ChromeClientGdk::~ChromeClientGdk):
2438         * platform/gdk/CursorGdk.cpp:
2439         (WebCore::pointerCursor):
2440         * platform/gdk/FrameGdk.cpp:
2441         (WebCore::doScroll):
2442         (WebCore::FrameGdk::FrameGdk):
2443         (WebCore::FrameGdk::submitForm):
2444         (WebCore::FrameGdk::urlSelected):
2445         (WebCore::FrameGdk::openURL):
2446         (WebCore::FrameGdk::handleGdkEvent):
2447         * platform/gdk/FrameGdk.h:
2448         (WebCore::FrameGdk::client):
2449         * platform/gdk/RenderPopupMenuGdk.cpp:
2450         (WebCore::PopupMenu::updateFromElement):
2451         * platform/gdk/ScreenGdk.cpp:
2452         * platform/gdk/TemporaryLinkStubs.cpp:
2453         (Slider::focusPolicy):
2454         (WebCore::ServeSynchronousRequest):
2455         (FrameGdk::goBackOrForward):
2456         (FrameGdk::getHistoryLength):
2457         (FrameGdk::historyURL):
2458         (ChromeClientGdk::canRunModal):
2459         (ChromeClientGdk::runModal):
2460         (WebCore::systemBeep):
2461         (WebCore::CachedResource::setPlatformResponse):
2462         (Path::transform):
2463         (ResourceLoader::loadsBlocked):
2464         (IconLoader::notifyIconChanged):
2465         * platform/network/gdk/ResourceHandleManager.cpp:
2466         (WebCore::writeCallback):
2467         (WebCore::ResourceHandleManager::downloadTimerCallback):
2468         (WebCore::ResourceHandleManager::remove):
2469         (WebCore::ResourceHandleManager::add):
2470
2471 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
2472
2473         build fix.
2474         
2475         * WebCore.xcodeproj/project.pbxproj:
2476
2477 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
2478
2479         Reviewed by Maciej, Anders, Darin.
2480
2481         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
2482         Fixed a minor where WebCore would always assume it was displayed on the 
2483         monitor containing the menubar. window.open and window.showModalDialog 
2484         are now cross-platform. 
2485         
2486         Layout tests, manual-tests/show-modal-dialog, and manual-tests/
2487         window-open-features-parsing all pass. I verified the new screen functionality
2488         by running in DRT, and checking whether WebCore knew it was off-screen.
2489         
2490         Some refactoring remains, as all were not pleased by this design. I see
2491         in my future another patch.
2492
2493         * bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
2494         client, to encapsulate asking the platform questions about the screen occupied by
2495         the page. (Previously, we always assumed we were on screen 0, which was a bug.)
2496         * bridge/mac/WebCoreFrameBridge.mm:
2497         (createMouseEventFromDraggingInfo): Reversed argument order, to match other
2498         functions.
2499         (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
2500         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
2501         * bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
2502         * bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
2503         * bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
2504         * bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
2505         * manual-tests/window-open-features-parsing.html: Updated for accuracy.
2506         (In this case, neither size nor position is specified, so you should
2507         get the default window size and position.)
2508         * page/Screen.cpp: Added. Includes screen-related helper functions used
2509         in WebCore and WebKit.
2510         * platform/PlatformMouseEvent.h: Exported common code so it doesn't have
2511         to be duplicated. Renamed "position" to "point" since both were used,
2512         and "point" seemed clearer.
2513         * platform/Screen.h: Removed. Dead Code.
2514         * platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
2515         initialization.
2516
2517 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
2518
2519         Reviewed by Tim Hatcher.
2520
2521         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
2522         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
2523         
2524         No layout tests added as this must be tested manually by the test
2525         WebCore/manual-tests/contenteditable-link.html
2526
2527         * WebCore.exp: Exported HitTestResult::isLiveLink().
2528         * html/HTMLAnchorElement.cpp:
2529         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
2530         (WebCore::HTMLAnchorElement::defaultEventHandler):
2531         (WebCore::HTMLAnchorElement::isLiveLink):
2532         * html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
2533         to track shift key status.
2534         * manual-tests/contenteditable-link.html: Added description about link
2535         dragging behaviour.
2536         * rendering/HitTestResult.cpp:
2537         (WebCore::HitTestResult::isLiveLink): Added.
2538         * rendering/HitTestResult.h:
2539
2540 2006-11-06  Brady Eidson  <beidson@apple.com>
2541
2542         Reviewed by Oliver
2543
2544         Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
2545         For now, we have to not load favicons when we have no Document - linking directly 
2546         to PDFs being the common case
2547
2548         * loader/icon/IconLoader.cpp:
2549         (WebCore::IconLoader::startLoading): Check for the document and return if none
2550
2551 2006-11-06  Brady Eidson  <beidson@apple.com>
2552
2553         Reviewed by Dave Harrison
2554
2555         <rdar://problem/4801066>
2556         Added a critical null frameLoader() check
2557
2558         * loader/mac/MainResourceLoaderMac.mm:
2559         (WebCore::MainResourceLoader::loadNow):
2560
2561 2006-11-06  David Harrison  <harrison@apple.com>
2562
2563         Reviewed by Darin.
2564
2565         <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
2566
2567         Test:
2568         * editing/deleting/delete-br-012.html
2569         
2570         * editing/DeleteSelectionCommand.cpp:
2571         (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
2572         Update m_endingPosition when preventing merge.
2573         Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
2574
2575 2006-11-06  Mark Rowe  <bdash@webkit.org>
2576
2577         Reviewed by Maciej.
2578
2579         http://bugs.webkit.org/show_bug.cgi?id=11526
2580         Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
2581
2582         Update DOMNode::toString to always use className rather than preferring nodeName.
2583
2584         * bindings/js/kjs_dom.cpp:
2585         (KJS::DOMNode::toString): Match the format returned by valueOf.
2586
2587 2006-11-06  Oliver Hunt  <oliver@apple.com>
2588
2589         Reviewed by Maciej.
2590
2591         Fix RTL text in SVG to have correct positioning
2592
2593         * rendering/SVGRootInlineBox.cpp:
2594         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
2595
2596 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
2597
2598         Reviewed by Maciej.
2599
2600         http://bugs.webkit.org/show_bug.cgi?id=11517
2601         REGRESSION: Flash clicks/interactivity not working properly
2602
2603         * bridge/mac/FrameMac.mm:
2604         (WebCore::FrameMac::handleMouseMoveEvent):
2605         (WebCore::FrameMac::handleMouseReleaseEvent):
2606         Restore parts of event dispatching that were removed when fixing
2607         bug 7323 - just bypass those for subframes.
2608
2609 2006-11-05  Darin Adler  <darin@apple.com>
2610
2611         - quick attempt to fix the no-SVG build
2612
2613         * platform/graphics/svg/SVGResource.cpp:
2614         * platform/graphics/svg/SVGResource.h:
2615         * platform/graphics/svg/SVGResourceClipper.cpp:
2616         * platform/graphics/svg/SVGResourceClipper.h:
2617         * platform/graphics/svg/SVGResourceImage.h:
2618         * platform/graphics/svg/SVGResourceMarker.cpp:
2619         * platform/graphics/svg/SVGResourceMarker.h:
2620         * platform/graphics/svg/SVGResourceMasker.cpp:
2621         * platform/graphics/svg/SVGResourceMasker.h:
2622         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
2623         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
2624         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
2625         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
2626         Added #ifdef SVG_SUPPORT to these files.
2627
2628 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
2629
2630         Reviewed & landed by Maciej.
2631
2632         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
2633
2634         * platform/win/ResourceLoaderWin.cpp:
2635         (WebCore::transferJobStatusCallback):
2636         (WebCore::ResourceLoader::start):
2637
2638 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
2639
2640         Reviewed by Oliver.
2641
2642         - moved FormData and FormDataStream to platform/network directory
2643
2644         * WebCore.xcodeproj/project.pbxproj:
2645         * bridge/mac/WebCoreFrameBridge.mm:
2646         * loader/FormData.cpp: Removed.
2647         * loader/FormData.h: Removed.
2648         * loader/mac/FormDataStream.h: Removed.
2649         * loader/mac/FormDataStream.m: Removed.
2650         * loader/mac/FrameLoaderMac.mm:
2651         * loader/mac/SubresourceLoaderMac.mm:
2652         * platform/network/mac/FormDataStreamMac.h: Added.
2653         * platform/network/mac/FormDataStreamMac.mm: Added.
2654         * platform/network/mac/ResourceRequestMac.mm:
2655
2656 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
2657
2658         Fix build breaks
2659
2660         * loader/DocumentLoader.h:
2661         * platform/win/ScreenWin.cpp:
2662
2663 2006-11-05  Darin Adler  <darin@apple.com>
2664
2665         Reviewed by Geoff.
2666
2667         - more preparation for splitting up Frame into sub-pieces
2668         - removed unnecessary includes from Frame.h
2669
2670         * page/Frame.h: Removed unneeded includes and forward declarations.
2671         Added additional forward declarations. Removed the constant
2672         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
2673         Created sections of functions to be moved into Chrome, Editor,
2674         EventHandler, FrameLoader, SelectionController, and the Platform
2675         directory, as well as marking one function for deletion.
2676
2677         * page/FramePrivate.h: Removed the definition of the constructor and
2678         destructor and removed unnecessary includes.
2679
2680         * page/FrameView.h: Removed unneeded forward declarations and friend
2681         declarations. Created a section of functions and data to be moved into
2682         EventHandler.
2683
2684         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
2685         Created sections of functions and data to be moved into Chrome,
2686         Editor, EventHandler, FrameLoader, and the Platform directory.
2687
2688         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
2689         Removed unused methods areScrollbarsVisible,
2690         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
2691
2692         * page/Frame.cpp:
2693         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
2694         to include KURL.h just for the KURL default constructor.
2695         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
2696         (WebCore::FramePrivate::~FramePrivate): Ditto.
2697
2698         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
2699         booleans, scrollbarMoved and cleared funcitons.
2700         (WebCore::FrameView::clear): Moved the code from the cleared
2701         function in here.
2702         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
2703
2704         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
2705         for changes to header.
2706
2707         * editing/SelectionController.cpp:
2708         (WebCore::SelectionController::setSelection):
2709         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
2710         Moved NoXPosForVerticalArrowNavigation into this file.
2711
2712         * bindings/js/kjs_events.cpp:
2713         * bindings/js/kjs_html.cpp:
2714         * bindings/js/kjs_window.cpp:
2715         * bridge/mac/WebCoreAXObject.mm:
2716         * bridge/mac/WebCoreFrameBridge.mm:
2717         * css/cssstyleselector.cpp:
2718         * dom/Document.cpp:
2719         * dom/Element.cpp:
2720         * dom/EventTargetNode.cpp:
2721         * dom/MouseRelatedEvent.cpp:
2722         * dom/XMLTokenizer.cpp:
2723         * html/HTMLBaseElement.cpp:
2724         * html/HTMLDocument.cpp:
2725         * html/HTMLEmbedElement.cpp:
2726         * html/HTMLFrameElementBase.cpp:
2727         * html/HTMLGenericFormElement.cpp:
2728         * html/HTMLObjectElement.cpp:
2729         * html/HTMLTokenizer.cpp:
2730         * loader/mac/FrameLoaderMac.mm:
2731         * page/PageState.cpp:
2732         * rendering/RenderApplet.cpp:
2733         * rendering/RenderBlock.cpp:
2734         * rendering/RenderLayer.cpp:
2735         * rendering/RenderObject.cpp:
2736         * rendering/RenderPartObject.cpp:
2737         * rendering/RenderTreeAsText.cpp:
2738         * xml/XSLTProcessor.cpp:
2739         Added includes as needed to keep compiling, since there are fewer
2740         includes in Frame.h.
2741
2742 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
2743
2744         Reviewed by Dave Harrison.
2745
2746         http://bugs.webkit.org/show_bug.cgi?id=11402
2747         REGRESSION: onChange does not work anymore for 1st item in popup
2748
2749         * html/HTMLSelectElement.cpp:
2750         (WebCore::HTMLSelectElement::HTMLSelectElement):
2751         (WebCore::HTMLSelectElement::reset):
2752         Set m_lastOnChangeIndex to -1.
2753
2754 2006-11-04  Darin Adler  <darin@apple.com>
2755
2756         Reviewed by Anders.
2757
2758         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
2759           REGRESSION: Status bar always shows cancelled opening the page
2760
2761         * platform/network/mac/ResourceHandleMac.mm:
2762         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
2763         Since the subresource owns the resource handle, there's no need to cancel.
2764         This arrangement is only temporary, anyway, since Maciej will soon change
2765         things so that the subresource loader uses the resource handle and the
2766         resource handle doesn't know anything about the subresource loader.
2767
2768 2006-11-04  Darin Adler  <darin@apple.com>
2769
2770         Reviewed by Maciej.
2771
2772         - converted more of the loader machinery to work with cross-platform
2773           data structures instead of Macintosh-specific ones
2774
2775           converted most uses of NSURL to KURL and NSEvent to DOM Event in
2776           loader classes
2777
2778           moved download function out of FrameLoader.h to avoid reference to
2779           NSURLConnection
2780
2781           added DOM Event parameters to various functions so that the handlers
2782           can use the DOM Event instead of the global "current NSEvent";
2783           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
2784           HTMLFormElement::submit, FrameLoader::load
2785
2786           moved the setMainFrame call that hands ownership to the Page
2787           into one of the Frame constructors, and removed it from all
2788           the clients
2789
2790           removed const from Event parameter to the urlSelected function
2791           (we rarely use const with DOM elements)
2792
2793           removed some redundant includes and declarations from various
2794           header files
2795
2796           removed NSURL parameter from userAgent function -- if we need it we
2797           can add it back, but converting from NSURL to KURL and back is
2798           inefficient enough that it's best to have it out for now (since it's
2799           been unused for years) -- if we add it back, we can choose an
2800           appropriate parameter type that's always inexpensive to pass
2801
2802           did some basic cleanup in the IconLoader class, including removing
2803           an unnecessary loop that added icon data a byte at a time
2804
2805           renamed safeLoad to load, since it's no different from the other
2806           FrameLoader load functions, safety-wise
2807
2808           fixed some code that was trying to distinguish null frame name from
2809           empty string frame name -- both should be handled the same, but callers
2810           were doing it by checking for empty and turning it into null (in a way
2811           that was causing extra round trips between NSString and WebCore::String)
2812
2813           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
2814           and got rid of case-insensitive compares of methods
2815
2816         * WebCore.exp:
2817         * WebCore.xcodeproj/project.pbxproj:
2818         * bindings/js/kjs_navigator.cpp:
2819         (KJS::Navigator::getValueProperty):
2820         * bridge/mac/FrameMac.h:
2821         * bridge/mac/FrameMac.mm:
2822         (WebCore::FrameMac::submitForm):
2823         (WebCore::FrameMac::urlSelected):
2824         (WebCore::FrameMac::userAgent):
2825         * bridge/mac/FrameViewMac.mm:
2826         * bridge/mac/WebCoreAXObject.mm:
2827         (-[WebCoreAXObject rendererForView:]):
2828         * bridge/mac/WebCorePageBridge.h:
2829         * bridge/mac/WebCorePageBridge.mm:
2830         * bridge/mac/WebCoreSettings.mm:
2831         * bridge/win/FrameWin.cpp:
2832         (WebCore::FrameWin::urlSelected):
2833         (WebCore::FrameWin::submitForm):
2834         * bridge/win/FrameWin.h:
2835         * dom/MouseRelatedEvent.cpp:
2836         * dom/MouseRelatedEvent.h:
2837         * dom/UIEvent.cpp:
2838         (WebCore::UIEvent::~UIEvent):
2839         * dom/UIEvent.h:
2840         * dom/UIEventWithKeyState.h:
2841         * dom/XMLTokenizer.cpp:
2842         (WebCore::openFunc):
2843         * html/HTMLAnchorElement.cpp:
2844         (WebCore::HTMLAnchorElement::defaultEventHandler):
2845         * html/HTMLButtonElement.cpp:
2846         (WebCore::HTMLButtonElement::defaultEventHandler):
2847         * html/HTMLFormElement.cpp:
2848         (WebCore::HTMLFormElement::submitClick):
2849         (WebCore::HTMLFormElement::prepareSubmit):
2850         (WebCore::HTMLFormElement::submit):
2851         * html/HTMLFormElement.h:
2852         * html/HTMLInputElement.cpp:
2853         (WebCore::HTMLInputElement::defaultEventHandler):
2854         * html/HTMLSelectElement.cpp:
2855         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
2856         * loader/DocumentLoader.h:
2857         * loader/FrameLoader.h:
2858         * loader/FrameLoaderClient.h:
2859         * loader/NavigationAction.h:
2860         (WebCore::NavigationAction::event):
2861         * loader/icon/IconLoader.cpp:
2862         (WebCore::IconLoader::create):
2863         (WebCore::IconLoader::startLoading):
2864         (WebCore::IconLoader::didReceiveData):
2865         (WebCore::IconLoader::didFinishLoading):
2866         * loader/icon/IconLoader.h:
2867         * loader/loader.cpp:
2868         * loader/mac/DocumentLoaderMac.mm:
2869         (WebCore::DocumentLoader::URL):
2870         (WebCore::DocumentLoader::unreachableURL):
2871         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
2872         (WebCore::DocumentLoader::URLForHistory):
2873         * loader/mac/FrameLoaderMac.mm:
2874         (WebCore::FrameLoader::load):
2875         (WebCore::FrameLoader::willSendRequest):
2876         (WebCore::FrameLoader::clientRedirected):
2877         (WebCore::FrameLoader::shouldReload):
2878         (WebCore::FrameLoader::notifyIconChanged):
2879         (WebCore::FrameLoader::URL):
2880         (WebCore::FrameLoader::reloadAllowingStaleData):
2881         (WebCore::FrameLoader::reload):
2882         (WebCore::FrameLoader::didChangeTitle):
2883         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2884         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2885         (WebCore::FrameLoader::post):
2886         (WebCore::FrameLoader::addExtraFieldsToRequest):
2887         (WebCore::FrameLoader::loadResourceSynchronously):
2888         * loader/mac/IconLoaderMac.mm:
2889         (WebCore::IconLoader::notifyIconChanged):
2890         * loader/mac/LoaderFunctionsMac.mm:
2891         * loader/mac/MainResourceLoaderMac.mm:
2892         (WebCore::shouldLoadAsEmptyDocument):
2893         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2894         * loader/mac/NavigationActionMac.mm:
2895         (WebCore::navigationType):
2896         (WebCore::NavigationAction::NavigationAction):
2897         * loader/mac/ResourceLoaderMac.mm:
2898         * loader/mac/SubresourceLoaderMac.mm:
2899         * page/Frame.cpp:
2900         (WebCore::Frame::Frame):
2901         (WebCore::Frame::urlSelected):
2902         (WebCore::Frame::submitFormAgain):
2903         (WebCore::Frame::submitForm):
2904         (WebCore::Frame::endIfNotLoading):
2905         (WebCore::Frame::hitTestResultAtPoint):
2906         * page/Frame.h:
2907         * page/FramePrivate.h:
2908         * platform/gdk/FrameGdk.cpp:
2909         (WebCore::FrameGdk::FrameGdk):
2910         (WebCore::FrameGdk::submitForm):
2911         (WebCore::FrameGdk::urlSelected):
2912         * platform/gdk/FrameGdk.h:
2913         * platform/mac/TextFieldMac.mm:
2914         * platform/network/HTTPHeaderMap.h:
2915         * platform/network/ResourceHandle.h:
2916         * platform/network/ResourceHandleClient.h:
2917         * platform/network/ResourceHandleInternal.h:
2918         * platform/network/mac/ResourceHandleMac.mm:
2919         * platform/network/mac/ResourceResponseMac.h:
2920         * platform/network/mac/ResourceResponseMac.mm:
2921         (-[NSURLResponse WebCore]):
2922         * platform/network/win/ResourceHandleWin.cpp:
2923         * platform/qt/FrameQt.cpp:
2924         (WebCore::FrameQt::submitForm):
2925         (WebCore::FrameQt::urlSelected):
2926         * platform/qt/FrameQt.h:
2927         * rendering/RenderLineEdit.cpp:
2928         (WebCore::RenderLineEdit::returnPressed):
2929         * xml/XSLTProcessor.cpp:
2930         (WebCore::docLoaderFunc):
2931         * xml/xmlhttprequest.cpp:
2932
2933 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2934
2935         Reviewed by Adele.
2936
2937         - replaced receivedRedirect with new willSendRequest delegate
2938         - removed most mac-specific loader functions
2939         - use ResourceResponse more in loader code
2940
2941         * WebCore.xcodeproj/project.pbxproj: Add new files.
2942         * bridge/mac/WebCoreFrameBridge.mm:
2943         (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
2944         for CachedResource method renames.
2945         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2946         Ditto.
2947         * loader/CachedCSSStyleSheet.cpp:
2948         (WebCore::CachedCSSStyleSheet::checkNotify): simplified
2949         based on ResourceResponse
2950         * loader/CachedImage.cpp:
2951         (WebCore::CachedImage::createImage): adapt for ResourceResponse
2952         * loader/CachedResource.cpp:
2953         (WebCore::CachedResource::CachedResource): store a ResourceResponse;
2954         platform response is now called platformResponse and expiration date
2955         is removed.
2956         (WebCore::CachedResource::~CachedResource): ditto
2957         (WebCore::CachedResource::isExpired): ditto
2958         * loader/CachedResource.h:
2959         (WebCore::CachedResource::platformResponse): ditto
2960         (WebCore::CachedResource::setResponse): ditto
2961         (WebCore::CachedResource::canDelete): ditto
2962         * loader/LoaderFunctions.h:
2963         * loader/loader.cpp:
2964         (WebCore::Loader::receivedResponse): Adjusted for renames.
2965         (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
2966         in the CachedResource.
2967         * loader/loader.h:
2968         * loader/mac/FormDataStream.h:
2969         * loader/mac/FormDataStream.m:
2970         (WebCore::getStreamFormDatas): Rearranged things so it's
2971         possible to get a FormData back out of a form data stream.
2972         (WebCore::formCreate): ditto
2973         (WebCore::formFinalize): ditto
2974         (WebCore::httpBodyFromStream): ditto
2975         * loader/mac/ImageDocumentMac.mm:
2976         (WebCore::finishImageLoad): s/response/platformResponse/
2977         * loader/mac/LoaderFunctionsMac.mm:
2978         (WebCore::CheckCacheObjectStatus): ditto
2979         (WebCore::CachedResource::setPlatformResponse): ditto
2980         * loader/mac/SubresourceLoaderMac.mm:
2981         (WebCore::SubresourceLoader::willSendRequest): send redirect
2982         to client appropriately
2983         * platform/network/ResourceHandle.h:
2984         * platform/network/ResourceHandleClient.h:
2985         (WebCore::ResourceHandleClient::willSendRequest): new entry
2986         point for SubresourceLoader, dispatch to client.
2987         * platform/network/ResourceRequest.h:
2988         (WebCore::ResourceRequest::allowHTTPCookies): implemented
2989         (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
2990         * platform/network/ResourceResponse.h:
2991         (WebCore::ResourceResponse::ResourceResponse): initialize expiration
2992         date(!)
2993         * platform/network/cf/FormDataStreamCFNet.cpp: Added.
2994         (WebCore::getStreamFormDatas): Added this, ported from NSURL version.
2995         (WebCore::openNextStream): ditto
2996         (WebCore::formCreate): ditto
2997         (WebCore::formFinalize): ditto
2998         (WebCore::formCanRead): ditto
2999         (WebCore::formEventCallback): ditto
3000         (WebCore::setHTTPBody): ditto
3001         (WebCore::httpBodyFromStream): ditto
3002         * platform/network/cf/FormDataStreamCFNet.h: Added.
3003         * platform/network/cf/ResourceHandleCFNet.cpp:
3004         (WebCore::willSendRequest): implemented
3005         (WebCore::ResourceHandle::start): use new ResourceRequest stuff
3006         * platform/network/cf/ResourceResponseCFNet.cpp:
3007         (WebCore::getResourceResponse): do nothing for a null response
3008         * platform/network/mac/ResourceHandleMac.mm:
3009         (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
3010         * platform/network/mac/ResourceRequestMac.h: Added.
3011         * platform/network/mac/ResourceRequestMac.mm: Added.
3012         (WebCore::getResourceRequest): Added way to convert an NSURLRequest
3013         to a ResourceRequest.
3014         (WebCore::nsURLRequest): Opposite of the above.
3015         * platform/network/cf/ResourceRequestCFNet.h: Added.
3016         * platform/network/cf/ResourceRequestCFNet.cpp: Added.
3017         (WebCore::getResourceRequest): Added way to convert an CFURLRequest
3018         to a ResourceRequest.
3019         (WebCore::cfURLRequest): Opposite of the above.
3020         * xml/xmlhttprequest.cpp:
3021         (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
3022         adjusted.
3023         * xml/xmlhttprequest.h:
3024
3025 2006-11-04  Darin Adler  <darin@apple.com>
3026
3027         Change suggested by Mitz.
3028
3029         - fix http://bugs.webkit.org/show_bug.cgi?id=11514
3030           REGRESSION (r17438): Repro crash when opening a web archive
3031
3032         * bridge/mac/WebCorePageState.mm:
3033         (-[WebCorePageState dealloc]): Add null check.
3034         (-[WebCorePageState finalize]): Ditto.
3035
3036 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
3037
3038         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
3039
3040         http://bugs.webkit.org/show_bug.cgi?id=11433
3041         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
3042
3043         * WebCore.vcproj/WebCore/WebCore.vcproj:
3044         Added platform/graphics platform/network and platform/network/win to headers search paths
3045         Created platform/graphics and platform/network filters in hierarchy
3046         Moved GraphicsContext and GraphicsTypes to their respective filters
3047         Added EditorClient.h
3048         Added FrameLoader* files in loader/
3049         Added HitTest* files in rendering/
3050         Added Editor.* files in editing/
3051         Added DeleteButton.* and DeleteButtonController.* in editing/
3052
3053         * bridge/win/ChromeClientWin.h: Added.
3054         (WebCore::ChromeClientWin::~ChromeClientWin):
3055         * bridge/win/EditorClientWin.h: Added.
3056         (WebCore::EditorClientWin::~EditorClientWin):
3057
3058         * bridge/win/FrameWin.cpp:
3059         (WebCore::FrameWin::FrameWin):
3060         (WebCore::FrameWin::urlSelected):
3061         (WebCore::FrameWin::submitForm):
3062         (WebCore::FrameWin::createNewWindow):
3063         * bridge/win/FrameWin.h:
3064         Added EditorClient parameter to constructor
3065         Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
3066         Removed openURL() and openURLRequest from class definition
3067
3068         * bridge/win/PageWin.cpp:
3069         * platform/AffineTransform.h:
3070         * platform/cairo/AffineTransformCairo.cpp: Added.
3071         (WebCore::AffineTransform::AffineTransform):
3072         (WebCore::AffineTransform::setMatrix):
3073         (WebCore::AffineTransform::map):
3074         (WebCore::AffineTransform::mapRect):
3075         (WebCore::AffineTransform::isIdentity):
3076         (WebCore::AffineTransform::m11):
3077         (WebCore::AffineTransform::m12):
3078         (WebCore::AffineTransform::m21):
3079         (WebCore::AffineTransform::m22):
3080         (WebCore::AffineTransform::dx):
3081         (WebCore::AffineTransform::dy):
3082         (WebCore::AffineTransform::reset):
3083         (WebCore::AffineTransform::scale):
3084         (WebCore::AffineTransform::rotate):
3085         (WebCore::AffineTransform::translate):
3086         (WebCore::AffineTransform::shear):
3087         (WebCore::AffineTransform::det):
3088         (WebCore::AffineTransform::invert):
3089         (WebCore::AffineTransform::operator cairo_matrix_t):
3090         (WebCore::AffineTransform::operator== ):
3091         (WebCore::AffineTransform::operator*= ):
3092         (WebCore::AffineTransform::operator* ):
3093         * platform/cairo/GraphicsContextCairo.cpp:
3094         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3095         * platform/network/win/ResourceHandleWin.cpp:
3096         (WebCore::ResourceHandle::onHandleCreated):
3097         (WebCore::ResourceHandle::start):
3098         (WebCore::ResourceHandle::fileLoadTimer):
3099         (WebCore::ResourceHandle::cancel):
3100         * platform/win/TemporaryLinkStubs.cpp:
3101         (WebCore::FrameWin::goBackOrForward):
3102         (WebCore::FrameWin::getHistoryLength):
3103         (WebCore::FrameWin::historyURL):
3104         (WebCore::ServeSynchronousRequest):
3105         (WebCore::ChromeClientWin::canRunModal):
3106         (WebCore::ChromeClientWin::runModal):
3107         (WebCore::EditorClientWin::shouldDeleteRange):
3108         (WebCore::EditorClientWin::shouldShowDeleteInterface):
3109         (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
3110         (WebCore::EditorClientWin::isGrammarCheckingEnabled):
3111         (WebCore::EditorClientWin::spellCheckerDocumentTag):
3112         (WebCore::Path::transform):
3113         (WebCore::PopupMenu::updateFromElement):
3114         (WebCore::ResourceLoader::loadsBlocked):
3115         (WebCore::systemBeep):
3116         * rendering/RenderThemeWin.cpp:
3117         (WebCore::RenderThemeWin::paintButton):
3118         (WebCore::RenderThemeWin::paintTextField):
3119
3120 2006-11-04  Alexey Proskuryakov  <ap@nypop.com>
3121
3122         Reviewed by Maciej.
3123
3124         http://bugs.webkit.org/show_bug.cgi?id=11448
3125         &lang; and &rang; entities are mapped to the incorrect Unicode codepoint
3126
3127         * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
3128
3129 2006-11-03  Mark Rowe  <bdash@webkit.org>
3130
3131         Reviewed by Oliver.
3132
3133         Update Windows and Qt project files for file removals in r17585.
3134
3135         * CMakeLists.txt:
3136         * WebCore.vcproj/WebCore/WebCore.vcproj:
3137
3138 2006-11-03  Zack Rusin  <zack@kde.org>
3139
3140         Reviewed by Maciej.
3141
3142         The patch fixes text field drawing on the Qt platform.
3143
3144         * platform/qt/RenderThemeQt.cpp:
3145         (WebCore::RenderThemeQt::paintTextField): Use the style to correctly
3146         render the text field
3147
3148 2006-11-03  Oliver Hunt  <oliver@apple.com>
3149
3150         Reviewed by Tim.
3151
3152         Correct incorrect call to SetCursor
3153
3154         * rendering/RenderFrameSet.cpp:
3155         (WebCore::RenderFrameSet::userResize):
3156
3157 2006-11-03  Adele Peterson  <adele@apple.com>
3158
3159         Reviewed by Oliver.
3160
3161         Removed DeprecatedRenderSelect and ListBox classes.
3162
3163         * WebCore.xcodeproj/project.pbxproj:
3164         * css/html4.css:
3165         * html/HTMLOptionElement.h:
3166         * html/HTMLSelectElement.cpp:
3167         (WebCore::HTMLSelectElement::recalcStyle):
3168         (WebCore::HTMLSelectElement::isKeyboardFocusable):
3169         (WebCore::HTMLSelectElement::isMouseFocusable):
3170         (WebCore::HTMLSelectElement::createRenderer):
3171         (WebCore::HTMLSelectElement::setRecalcListItems):
3172         (WebCore::HTMLSelectElement::notifyOptionSelected):
3173         (WebCore::HTMLSelectElement::defaultEventHandler):
3174         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
3175         (WebCore::HTMLSelectElement::updateListBoxSelection):
3176         * html/HTMLSelectElement.h:
3177         * platform/ListBox.h: Removed.
3178         * platform/mac/FontCacheMac.mm:
3179         * platform/mac/ListBoxMac.mm: Removed.
3180         * platform/win/TemporaryLinkStubs.cpp:
3181         * rendering/DeprecatedRenderSelect.cpp: Removed.
3182         * rendering/DeprecatedRenderSelect.h: Removed.
3183
3184 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
3185
3186         Not reviewed, fix for accidental commit.
3187
3188         - rolled back more of the accidentall commit that I forgot.
3189
3190         * platform/network/mac/ResourceRequestMac.h: Removed.
3191         * platform/network/mac/ResourceRequestMac.mm: Removed.
3192
3193 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
3194
3195         Not reviewed, fix for accidental commit.
3196
3197         - roll back some network changes accidentally committed with a previous patch.
3198
3199         * WebCore.xcodeproj/project.pbxproj:
3200         * bridge/mac/WebCoreFrameBridge.mm:
3201         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
3202         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
3203         * loader/CachedCSSStyleSheet.cpp:
3204         (WebCore::CachedCSSStyleSheet::checkNotify):
3205         * loader/CachedImage.cpp:
3206         (WebCore::CachedImage::createImage):
3207         * loader/CachedResource.cpp:
3208         (WebCore::CachedResource::CachedResource):
3209         (WebCore::CachedResource::~CachedResource):
3210         (WebCore::CachedResource::setExpireDate):
3211         (WebCore::CachedResource::isExpired):
3212         * loader/CachedResource.h:
3213         (WebCore::CachedResource::response):
3214         * loader/LoaderFunctions.h:
3215         * loader/loader.cpp:
3216         (WebCore::Loader::receivedResponse):
3217         (WebCore::Loader::didReceivedResponse):
3218         * loader/loader.h:
3219         * loader/mac/FormDataStream.h:
3220         * loader/mac/FormDataStream.m:
3221         (WebCore::formCreate):
3222         (WebCore::formFinalize):
3223         * loader/mac/ImageDocumentMac.mm:
3224         (WebCore::finishImageLoad):
3225         * loader/mac/LoaderFunctionsMac.mm:
3226         (WebCore::CheckCacheObjectStatus):
3227         (WebCore::CachedResource::setResponse):
3228         * loader/mac/SubresourceLoaderMac.mm:
3229         (WebCore::SubresourceLoader::willSendRequest):
3230         * platform/network/ResourceHandle.h:
3231         * platform/network/ResourceHandleClient.h:
3232         (WebCore::ResourceHandleClient::receivedRedirect):
3233         * platform/network/ResourceRequest.h:
3234         * platform/network/ResourceResponse.h:
3235         (WebCore::ResourceResponse::ResourceResponse):
3236         * platform/network/mac/ResourceHandleMac.mm:
3237         (WebCore::ResourceHandle::redirectedToURL):
3238         * xml/xmlhttprequest.cpp:
3239         (WebCore::XMLHttpRequest::receivedRedirect):
3240         * xml/xmlhttprequest.h:
3241
3242 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
3243
3244         Rubber-stamped by Oliver.
3245
3246         Remove these, they have been merged with SVGRenderTreeAsText.
3247         
3248         * rendering/SVGRenderAsText.cpp: Removed.
3249         * rendering/SVGRenderAsText.h: Removed.
3250
3251 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
3252
3253         Build fix.
3254         
3255         * platform/network/cf/ResourceHandleCFNet.cpp:
3256         (WebCore::willSendRequest):
3257
3258 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
3259
3260         Reviewed by Darin, Beth.
3261         
3262         First cut at factoring Page's UIDelegate-related functions into Chrome
3263         and ChromeClient.
3264
3265         Layout tests pass.
3266         
3267         * bridge/mac/PageMac.mm: Removed platform-specific constructor, added
3268         setBridge method to replace it.
3269         (WebCore::Page::setBridge):
3270
3271         * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact
3272         that WebCorePageBridge.h doesn't need to be included by ObjC-only files,
3273         and, now that it uses PassRefPtr, can't be.
3274         
3275         * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
3276
3277         * page/Page.h:
3278         (WebCore::Page::dragCaretController): Made this function non-const so that
3279         m_dragCaretController doesn't have to be mutable.
3280
3281 2006-11-03  Alexey Proskuryakov  <ap@nypop.com>
3282
3283         Reviewed by Adele.
3284
3285         http://bugs.webkit.org/show_bug.cgi?id=7323
3286         REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
3287
3288         * bridge/mac/FrameMac.h: Moved drag source information to a static variable
3289         in FrameMac.mm. There can be only one drag active at any moment, and having 
3290         this information here was making sharing this information between 
3291         subframes hard.
3292
3293         * bridge/mac/FrameMac.mm:
3294         (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo.
3295         (WebCore::FrameMac::freeClipboard):
3296         (WebCore::FrameMac::dragHysteresisExceeded):
3297         (WebCore::FrameMac::handleMouseMoveEvent):
3298         (WebCore::FrameMac::handleMouseReleaseEvent):
3299         (WebCore::FrameMac::mouseDown):
3300         (WebCore::FrameMac::dragSourceMovedTo):
3301         (WebCore::FrameMac::dragSourceEndedAt):
3302         (WebCore::FrameMac::dispatchDragSrcEvent):
3303         Access drag source info via sharedDragInfo - this fixes drag source even dispatching.
3304         Also removed some old code that was forwarding mouse events to subviews to make 
3305         HTML editing work in subframes.
3306
3307         * page/FrameView.cpp:
3308         (WebCore::FrameView::updateDragAndDrop):
3309         (WebCore::FrameView::cancelDragAndDrop):
3310         (WebCore::FrameView::performDragAndDrop):
3311         Forward events to subframes for dispatching - this fixes drag target events.
3312
3313 2006-11-03  Zack Rusin  <zack@kde.org>
3314
3315         Reviewed by Tim.
3316
3317         Fixing compile.
3318
3319         * platform/qt/LoaderFunctionsQt.cpp:
3320         (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
3321
3322 2006-11-01  Zack Rusin  <zack@kde.org>
3323
3324         Reviewed by Maciej.
3325
3326         Moving the word/sentence seperators into a file of their own
3327         and implementing findWordBoundary.
3328
3329         * CMakeLists.txt:
3330         * platform/qt/TemporaryLinkStubs.cpp:
3331         * platform/qt/TextBoundaries.cpp: Added.
3332         (WebCore::findNextSentenceFromIndex):
3333         (WebCore::findSentenceBoundary):
3334         (WebCore::findNextWordFromIndex):
3335         (WebCore::findWordBoundary):
3336
3337 2006-11-03  Zack Rusin  <zack@kde.org>
3338
3339         Reviewed by Maciej.
3340
3341         Compile on both KDE and Qt platforms
3342
3343         * CMakeLists.txt: add zlib explicitly
3344         * platform/network/qt/ResourceHandleManager.cpp:
3345         (WebCore::ResourceHandleManager::self):
3346         (WebCore::QtJob::QtJob):
3347         (WebCore::QtJob::timerEvent): Integrate both implementations
3348         so that moc can parse it
3349         (WebCore::ResourceHandleManager::deliverJobData):
3350         (WebCore::ResourceHandleManager::remove):
3351         * platform/network/qt/ResourceHandleManager.h:
3352
3353 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
3354
3355         No review, suggested by Mitz.
3356
3357         - fix a #if to be #ifdef
3358
3359         * platform/graphics/svg/cg/SVGResourceImageCg.cpp:
3360
3361 2006-11-03  Zack Rusin  <zack@kde.org>
3362
3363         Reviewed and landed by Maciej.
3364         
3365         Compile on the Qt platform.
3366
3367         * ksvg2/misc/KCanvasRenderingStyle.h:
3368         * platform/qt/RenderThemeQt.cpp:
3369         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
3370
3371 2006-11-03  Zack Rusin  <zack@kde.org>
3372
3373         Reviewed by Hyatt. Landed by Maciej.
3374
3375         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
3376         to graphics context to be able to set consistant state
3377         on the platform specific painter without having to change
3378         fill/stroke/font on every operation. This fixes color/stroke/fill
3379         and font handling in the Qt port.
3380
3381         * platform/graphics/GraphicsContext.cpp:
3382         (WebCore::GraphicsContext::setFont):
3383         (WebCore::GraphicsContext::setPen):
3384         (WebCore::GraphicsContext::setFillColor):
3385         (WebCore::GraphicsContext::setPlatformPen):
3386         (WebCore::GraphicsContext::setPlatformFillColor):
3387         (WebCore::GraphicsContext::setPlatformFont):
3388         * platform/graphics/GraphicsContext.h:
3389         * platform/qt/GraphicsContextQt.cpp:
3390         (WebCore::toQtCompositionMode):
3391         (WebCore::toQtLineCap):
3392         (WebCore::toQtLineJoin):
3393         (WebCore::toQPenStyle):
3394         (WebCore::penToQPen):
3395         (WebCore::TransparencyLayer::TransparencyLayer):
3396         (WebCore::GraphicsContext::addRoundedRectClip):
3397         (WebCore::GraphicsContext::setPlatformFont):
3398         (WebCore::GraphicsContext::setPlatformPen):
3399         (WebCore::GraphicsContext::setPlatformFillColor):
3400         * platform/qt/ScrollViewCanvasQt.cpp:
3401         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
3402         (WebCore::ScrollViewCanvasQt::paintEvent):
3403         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
3404         * platform/qt/ScrollViewCanvasQt.h:
3405
3406 2006-11-02  Adele Peterson  <adele@apple.com>
3407
3408         Reviewed by Anders.
3409
3410         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
3411         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
3412
3413         Test: fast/forms/textarea-no-scroll-on-blur.html
3414
3415         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
3416           On blur, only scroll back to the start for text fields.
3417
3418 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3419
3420         Another build fix.
3421         
3422         * rendering/RenderFileUploadControl.cpp:
3423         (WebCore::RenderFileUploadControl::paintObject):
3424
3425 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3426
3427         Build fix.
3428         
3429         * page/FramePrivate.h:
3430         (WebCore::FramePrivate::FramePrivate):
3431
3432 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
3433
3434         Reviewed by Geoff, landed by Anders.
3435         
3436         Fix dependency problems caused when running move-js-headers.sh
3437         
3438         * move-js-headers.sh:
3439         Use cp -p instead of just cp so that the modification time
3440         of the original files are used.
3441
3442 2006-11-02  Adam Roben  <aroben@apple.com>
3443
3444         Reviewed by Tim H, landed by Anders.
3445
3446         Fixes http://bugs.webkit.org/show_bug.cgi?id=10840
3447         REGRESSION: Shadow of file upload button is clipped
3448
3449         * rendering/RenderFileUploadControl.cpp:
3450         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
3451         height to keep from clipping in the shadow
3452
3453 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
3454
3455         Reviewed by Maciej, landed by Anders.
3456
3457         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
3458         content and window. ScrollViewQt already receives correct content
3459         coordinates from QScrollArea.
3460         (WebCore::ScrollView::contentsToWindow):
3461         (WebCore::ScrollView::windowToContents):
3462
3463 2006-11-02  Simon Hausmann  <hausmann@kde.org>
3464
3465         Reviewed by Maciej, landed by Anders
3466
3467         * CMakeLists.txt: Make linkage against KDE libraries conditional
3468         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
3469           Qt base resource handler that supports only requests to the
3470           local filesystem. Used when compiling without KDE support.
3471           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
3472           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
3473         (WebCore::QtJob::QtJob):
3474         (WebCore::QtJob::timerEvent):
3475         (WebCore::ResourceHandleManager::ResourceHandleManager):
3476         (WebCore::ResourceHandleManager::~ResourceHandleManager):
3477         (WebCore::ResourceHandleManager::self):
3478         (WebCore::ResourceHandleManager::remove):
3479         (WebCore::ResourceHandleManager::add):
3480         (WebCore::ResourceHandleManager::cancel):
3481         (WebCore::ResourceHandleManager::deliverJobData):
3482         * platform/network/qt/ResourceHandleManager.h:
3483         * platform/qt/FrameQtClient.cpp:
3484         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
3485         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
3486         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
3487         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
3488           input dialog functions when compiling without KDE support
3489         (WebCore::ServeSynchronousRequest):
3490
3491 2006-11-02  David Carson  <dacarson@gmail.com>
3492
3493         Reviewed by Geoff, landed by Anders.
3494
3495         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
3496         Initializing variable in constructor.
3497
3498         * page/FramePrivate.h:
3499         (WebCore::FramePrivate::FramePrivate):
3500
3501 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3502
3503         Reviewed by Geoff.
3504
3505         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
3506         
3507         * platform/network/cf/ResourceHandleCFNet.cpp:
3508         (WebCore::addHeadersFromHashMap):
3509         Don't set all headers at once since that clears any previous headers set.
3510         
3511         (WebCore::ResourceHandle::start):
3512
3513 2006-11-02  Adele Peterson  <adele@apple.com>
3514
3515         Reviewed by Mitz and Geoff.
3516
3517         - Fix for:
3518         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
3519         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
3520         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
3521
3522         Test: fast/forms/textarea-scrollbar.html
3523
3524         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
3525         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
3526
3527         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
3528         * rendering/RenderTextControl.cpp: 
3529         (WebCore::RenderTextControl::RenderTextControl):
3530         (WebCore::RenderTextControl::setStyle):
3531         (WebCore::RenderTextControl::createDivStyle):
3532         (WebCore::RenderTextControl::updateFromElement):
3533         (WebCore::RenderTextControl::calcHeight):
3534         (WebCore::RenderTextControl::baselinePosition):
3535         (WebCore::RenderTextControl::nodeAtPoint):
3536         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
3537         (WebCore::RenderTextControl::scrollWidth):
3538         (WebCore::RenderTextControl::scrollHeight):
3539         (WebCore::RenderTextControl::scrollLeft):
3540         (WebCore::RenderTextControl::scrollTop):
3541
3542         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
3543
3544 2006-11-02  John Sullivan  <sullivan@apple.com>
3545
3546         Reviewed by Geoff Garen
3547
3548         * editing/Selection.cpp:
3549         (WebCore::Selection::showTreeForThis):
3550         this debugging method now displays start offset and end offset, at Darin's suggestion
3551
3552 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
3553
3554         Reviewed by darin
3555
3556         <rdar://problem/4062865>
3557         Copy/paste of a select element fails to include the options
3558         
3559         * editing/SelectionController.cpp:
3560         (WebCore::SelectionController::modify): Added paragraphBoundary.
3561         * editing/htmlediting.cpp:
3562         (WebCore::canHaveChildrenForEditing): Added checks for input elements
3563         and textareas.  Insertion operations would fail when performed just 
3564         before/after one of these elements b/c the content would be put inside 
3565         the element.
3566         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
3567         editable content, and made the code to stop at an root faster (don't check
3568         isDescendantOf on every iteration).
3569         (WebCore::enclosingNodeOfType): Ditto.
3570         (WebCore::enclosingList): Ditto.
3571         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
3572         inappropriately named.
3573         * editing/markup.cpp:
3574         (WebCore::startMarkup): Use the text node's value instead of its rendered
3575         content for text nodes inside select elements.  One might also turn off
3576         annotation when createMarkup enters a select element, but createMarkup
3577         is iterative, not recursive, so doing so would be complicated.
3578         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
3579         descendants of a select element.
3580         * editing/visible_units.cpp:
3581         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
3582         where various replaced elements can't be copied when they are the only
3583         thing selected.
3584         (WebCore::endOfParagraph): Ditto.
3585
3586 2006-11-01  Oliver Hunt  <oliver@apple.com>
3587
3588         Reviewed by Adam.
3589
3590         Converting more or kcanvas/quartz from Obj-C to C++
3591         Minor SVG updates
3592         compatibility fixes
3593
3594         * WebCore.xcodeproj/project.pbxproj:
3595         * kcanvas/device/KRenderingPaintServer.h:
3596         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
3597         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
3598         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
3599         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
3600         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
3601         * kcanvas/device/quartz/QuartzSupport.h:
3602         * ksvg2/css/SVGCSSStyleSelector.cpp:
3603         * ksvg2/misc/KCanvasRenderingStyle.h:
3604         * ksvg2/scripts/cssmakeprops:
3605         * ksvg2/scripts/cssmakevalues:
3606         * ksvg2/scripts/make_names.pl:
3607         * ksvg2/svg/SVGAnimateColorElement.cpp:
3608         * ksvg2/svg/SVGAnimateTransformElement.cpp:
3609         * ksvg2/svg/SVGAnimationElement.cpp:
3610         * ksvg2/svg/SVGMaskElement.cpp:
3611         * ksvg2/svg/SVGPatternElement.cpp:
3612         * ksvg2/svg/svgpathparser.cpp:
3613         * platform/Path.cpp:
3614         * platform/graphics/svg/SVGResourceImage.h:
3615         * rendering/RenderPath.cpp:
3616         * rendering/SVGRenderAsText.cpp:
3617
3618 2006-11-02  Mitz Pettel  <mitz@webkit.org>
3619
3620         Reviewed by Adele.
3621
3622         - Fix a regression from r17521: painting of and crash caused by tables
3623           with collapsed borders
3624
3625         * rendering/RenderTable.cpp:
3626         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
3627         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
3628         and 'paintInfo' is the parameter, which we were accidently modifying.
3629
3630 2006-11-01  Adele Peterson  <adele@apple.com>
3631
3632         Reviewed by Mitz.
3633
3634         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
3635         REGRESSION: Incomplete repaint of overflow areas when deleting
3636
3637         Restrict the repaint rect for overflow blocks after the height has been fully computed.
3638         Also, adjust the repaint rect coordinates for the scroll offset.
3639
3640         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
3641         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
3642
3643 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
3644
3645         Reviewed by Mitz.
3646
3647         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
3648         Rename the "p" member variable of the PaintInfo struct to "context"
3649
3650         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
3651           'context' and 'rect' respectively.
3652
3653         - Assorted surrounding cleanups.
3654
3655         * rendering/EllipsisBox.cpp:
3656         (WebCore::EllipsisBox::paint):
3657         * rendering/EllipsisBox.h:
3658         * rendering/InlineBox.cpp:
3659         (WebCore::InlineBox::paint):
3660         * rendering/InlineFlowBox.cpp:
3661         (WebCore::InlineFlowBox::paint):
3662         (WebCore::InlineFlowBox::paintBackground):
3663         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
3664         (WebCore::InlineFlowBox::paintDecorations):
3665         * rendering/InlineFlowBox.h:
3666         * rendering/InlineRunBox.h:
3667         * rendering/InlineTextBox.cpp:
3668         (WebCore::InlineTextBox::paint):
3669         * rendering/InlineTextBox.h:
3670         * rendering/RenderBlock.cpp:
3671         (WebCore::RenderBlock::paint):
3672         (WebCore::RenderBlock::paintChildren):
3673         (WebCore::RenderBlock::paintCaret):
3674         (WebCore::RenderBlock::paintObject):
3675         (WebCore::RenderBlock::paintFloats):
3676         (WebCore::RenderBlock::paintEllipsisBoxes):
3677         (WebCore::RenderBlock::paintSelection):
3678         (WebCore::RenderBlock::fillSelectionGaps):
3679         (WebCore::RenderBlock::fillInlineSelectionGaps):
3680         (WebCore::RenderBlock::fillBlockSelectionGaps):
3681         (WebCore::RenderBlock::fillHorizontalSelectionGap):
3682         (WebCore::RenderBlock::fillVerticalSelectionGap):
3683         (WebCore::RenderBlock::fillLeftSelectionGap):
3684         (WebCore::RenderBlock::fillRightSelectionGap):
3685         * rendering/RenderBox.cpp:
3686         (WebCore::RenderBox::paint):
3687         (WebCore::RenderBox::paintRootBoxDecorations):
3688         (WebCore::RenderBox::paintBoxDecorations):
3689         * rendering/RenderBox.h:
3690         * rendering/RenderButton.cpp:
3691         (WebCore::RenderButton::paintObject):
3692         * rendering/RenderFieldset.cpp:
3693         (WebCore::RenderFieldset::paintBoxDecorations):
3694         * rendering/RenderFileUploadControl.cpp:
3695         (WebCore::RenderFileUploadControl::paintObject):
3696         * rendering/RenderFlow.cpp:
3697         (WebCore::RenderFlow::continuationBefore):
3698         (WebCore::RenderFlow::addChildWithContinuation):
3699         (WebCore::RenderFlow::addChild):
3700         (WebCore::RenderFlow::attachLineBox):
3701         (WebCore::RenderFlow::destroy):
3702         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
3703         (WebCore::RenderFlow::dirtyLineBoxes):
3704         (WebCore::RenderFlow::createInlineBox):
3705         (WebCore::RenderFlow::paintLines):
3706         (WebCore::RenderFlow::getAbsoluteRepaintRect):
3707         (WebCore::RenderFlow::lowestPosition):
3708         (WebCore::RenderFlow::rightmostPosition):
3709         (WebCore::RenderFlow::leftmostPosition):
3710         (WebCore::RenderFlow::caretRect):
3711         (WebCore::RenderFlow::addFocusRingRects):
3712         (WebCore::RenderFlow::paintOutline):
3713         (WebCore::RenderFlow::paintOutlineForLine):
3714         * rendering/RenderForeignObject.cpp:
3715         (WebCore::RenderForeignObject::paint):
3716         * rendering/RenderHTMLCanvas.cpp:
3717         (WebCore::RenderHTMLCanvas::paint):
3718         * rendering/RenderImage.cpp:
3719         (WebCore::RenderImage::paint):
3720         * rendering/RenderLayer.cpp:
3721         (WebCore::RenderLayer::paintLayer):
3722         * rendering/RenderListBox.cpp:
3723         (WebCore::RenderListBox::paintObject):
3724         (WebCore::RenderListBox::paintScrollbar):
3725         (WebCore::RenderListBox::paintItemForeground):
3726         (WebCore::RenderListBox::paintItemBackground):
3727         * rendering/RenderListMarker.cpp:
3728         (WebCore::RenderListMarker::paint):
3729         * rendering/RenderMenuList.cpp:
3730         (WebCore::RenderMenuList::paintObject):
3731         * rendering/RenderObject.cpp:
3732         (WebCore::RenderObject::paint):
3733         * rendering/RenderObject.h:
3734         (WebCore::RenderObject::PaintInfo::PaintInfo):
3735         (WebCore::RenderObject::paintBoxDecorations):
3736         (WebCore::RenderObject::paintingRootForChildren):
3737         (WebCore::RenderObject::shouldPaintWithinRoot):
3738         (WebCore::RenderObject::printBoxDecorations):
3739         * rendering/RenderPath.cpp:
3740         (WebCore::RenderPath::paint):
3741         * rendering/RenderReplaced.cpp:
3742         (WebCore::RenderReplaced::shouldPaint):
3743         * rendering/RenderSVGContainer.cpp:
3744         (WebCore::RenderSVGContainer::paint):
3745         * rendering/RenderSVGContainer.h:
3746         * rendering/RenderSVGImage.cpp:
3747         (WebCore::RenderSVGImage::paint):
3748         * rendering/RenderSVGText.cpp:
3749         (WebCore::RenderSVGText::paint):
3750         * rendering/RenderSVGText.h:
3751         (WebCore::RenderSVGText::renderName):
3752         * rendering/RenderTable.cpp:
3753         (WebCore::RenderTable::paint):
3754         (WebCore::RenderTable::paintBoxDecorations):
3755         * rendering/RenderTable.h:
3756         * rendering/RenderTableCell.cpp:
3757         (WebCore::RenderTableCell::paint):
3758         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
3759         (WebCore::RenderTableCell::paintBoxDecorations):
3760         * rendering/RenderTableCell.h:
3761         * rendering/RenderTableRow.cpp:
3762         (WebCore::RenderTableRow::paint):
3763         * rendering/RenderTableRow.h:
3764         * rendering/RenderTableSection.cpp:
3765         (WebCore::RenderTableSection::paint):
3766         * rendering/RenderTableSection.h:
3767         (WebCore::RenderTableSection::getBaseline):
3768         (WebCore::RenderTableSection::setNeedCellRecalc):
3769         * rendering/RenderText.h:
3770         (WebCore::RenderText::renderName):
3771         (WebCore::RenderText::paint):
3772         (WebCore::RenderText::element):
3773         * rendering/RenderTheme.cpp:
3774         (WebCore::RenderTheme::paint):
3775         (WebCore::RenderTheme::paintBorderOnly):
3776         (WebCore::RenderTheme::paintDecorations):
3777         * rendering/RenderTheme.h:
3778         (WebCore::RenderTheme::RenderTheme):
3779         (WebCore::RenderTheme::~RenderTheme):
3780         (WebCore::RenderTheme::controlSupportsTints):
3781         (WebCore::RenderTheme::adjustRepaintRect):
3782         (WebCore::RenderTheme::themeChanged):
3783         (WebCore::RenderTheme::supportsHover):
3784         (WebCore::RenderTheme::paintCheckbox):
3785         (WebCore::RenderTheme::setCheckboxSize):
3786         (WebCore::RenderTheme::paintRadio):
3787         (WebCore::RenderTheme::setRadioSize):
3788         (WebCore::RenderTheme::paintButton):
3789         (WebCore::RenderTheme::setButtonSize):
3790         (WebCore::RenderTheme::paintTextField):
3791         (WebCore::RenderTheme::paintTextArea):
3792         (WebCore::RenderTheme::paintMenuList):
3793         (WebCore::RenderTheme::paintMenuListButton):
3794         * rendering/RenderThemeMac.mm:
3795         (WebCore::RenderThemeMac::paintCheckbox):
3796         (WebCore::RenderThemeMac::paintRadio):
3797         (WebCore::RenderThemeMac::paintButton):
3798         (WebCore::RenderThemeMac::paintTextField):
3799         (WebCore::RenderThemeMac::paintTextArea):
3800         (WebCore::RenderThemeMac::paintMenuList):
3801         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
3802         (WebCore::RenderThemeMac::paintMenuListButton):
3803         * rendering/RenderView.cpp:
3804         (WebCore::RenderView::paint):
3805         (WebCore::RenderView::paintBoxDecorations):
3806         * rendering/RenderView.h:
3807         * rendering/RenderWidget.cpp:
3808         (WebCore::RenderWidget::paint):
3809         * rendering/RenderWidget.h:
3810         (WebCore::RenderWidget::isWidget):
3811         * rendering/RootInlineBox.cpp:
3812         (WebCore::RootInlineBox::paintEllipsisBox):
3813         (WebCore::RootInlineBox::paintCustomHighlight):
3814         (WebCore::RootInlineBox::paint):
3815         (WebCore::RootInlineBox::fillLineSelectionGap):
3816         * rendering/RootInlineBox.h:
3817         * rendering/SVGInlineFlowBox.cpp:
3818         (WebCore::paintSVGInlineFlow):
3819
3820 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
3821
3822         Reviewed by Oliver, Brady.
3823
3824         * platform/network/ResourceResponse.h:
3825         (WebCore::ResourceResponse::setLastModifiedDate):
3826         (WebCore::ResourceResponse::lastModifiedDate):
3827         Add getters and setters for last modified dadte.
3828         
3829         * platform/network/cf/ResourceResponseCFNet.cpp:
3830         (WebCore::getResourceResponse):
3831         Fetch the last modified date. Add correct offset to expired date.
3832
3833 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
3834
3835         Reviewed by Mitz.
3836
3837         Added missing "break;" statement in switch statement from r17493.
3838
3839         Bug 11442: [CSS 3] support for cursor: all-scroll
3840         http://bugs.webkit.org/show_bug.cgi?id=11442
3841
3842         * css/CSSComputedStyleDeclaration.cpp:
3843         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3844
3845 2006-10-31  Mitz Pettel  <mitz@webkit.org>
3846
3847         Reviewed by Maciej.
3848
3849         - fix image dragging
3850
3851         This is covered by editing/selection/drag-to-contenteditable-iframe.html
3852
3853         * rendering/HitTestResult.cpp:
3854         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
3855         HTML IMG elements.
3856         (WebCore::HitTestResult::absoluteImageURL): Ditto.
3857
3858 2006-10-31  Beth Dakin  <bdakin@apple.com>
3859
3860         Reviewed by Maciej.
3861
3862         This adds the back-end of the remaining WebElementDictionary 
3863         functions into HitTestResult.
3864
3865         * WebCore.exp:
3866         * rendering/HitTestResult.cpp:
3867         (WebCore::HitTestResult::title):
3868         (WebCore::displayString): This is nearly identical to the 
3869         displayString() defined in DOMInternal.mm except that it returns a 
3870         String instead of an NSString. The old code path used the 
3871         DOMInternal method, so I made a new one here for the new code path.
3872         (WebCore::HitTestResult::altDisplayString):
3873         (WebCore::HitTestResult::image):
3874         (WebCore::HitTestResult::absoluteImageURL):
3875         (WebCore::HitTestResult::absoluteLinkURL):
3876         (WebCore::HitTestResult::titleDisplayString):
3877         (WebCore::HitTestResult::textContent):
3878         * rendering/HitTestResult.h:
3879
3880 2006-10-31  John Sullivan  <sullivan@apple.com>
3881
3882         * bridge/mac/FrameMac.mm:
3883         (WebCore::FrameMac::markMisspellings):
3884         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
3885
3886 2006-10-31  John Sullivan  <sullivan@apple.com>
3887
3888         Reviewed by Maciej
3889         
3890         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
3891         
3892         The foundation of this was in my last checkin. This checkin is all about displaying
3893         the correct string in the toolTip.
3894
3895         * dom/DocumentMarker.h:
3896         New description field in this struct.
3897
3898         * bridge/mac/FrameMac.mm:
3899         (WebCore::FrameMac::advanceToNextMisspelling):
3900         When adding a grammar marker, supply the appropriate description. Also, added a comment
3901         about the remaining work to make grammar checking return sensible answers.
3902         (WebCore::FrameMac::markMisspellings):
3903         ditto (yes, still needs some refactoring to minimize duplicated code)
3904         
3905         * dom/Document.h:
3906         * dom/Document.cpp:
3907         (WebCore::Document::addMarker):
3908         Now takes an optional description string
3909         (WebCore::Document::markerContainingPoint):
3910         New function, returns a pointer to the (first) marker of the specified type whose rect 
3911         contains the specified point, or 0 if none.
3912         
3913         * rendering/HitTestResult.cpp:
3914         (WebCore::HitTestResult::spellingToolTip):
3915         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
3916         and gets the description from the marker.
3917
3918 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
3919
3920         Reviewed by Maciej.
3921         
3922         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
3923
3924         * loader/mac/FrameLoaderMac.mm:
3925         (WebCore::FrameLoader::createWindow):
3926         * manual-tests/window-open-features-parsing.html: Updated for clarity.
3927
3928 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
3929
3930         Reviewed by Alice.
3931
3932         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
3933         to WebCore::Editor.
3934         
3935         Layout tests pass.
3936         
3937         Renamed "may*" to "can*" because "can" is more accurate (these functions
3938         aren't just about permission) and it matches WebKit.
3939
3940         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
3941         password field. Now that WebCore fully implements canCopy(), it doesn't just
3942         mean "the selection is not in a password field" anymore.
3943         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
3944         The fact that it's not called anymore may represent a security issue, but I
3945         don't see how commented-out code will help reveal the issue, and the
3946         bridge is going away, anyway.
3947         * editing/SelectionController.h: Changed selection() calls to references
3948         to m_sel, to match the rest of the file.
3949
3950 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
3951
3952         Reviewed by harrison
3953         
3954         <rdar://problem/4711063>
3955         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
3956
3957         * editing/ReplaceSelectionCommand.cpp:
3958         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
3959         insertion and plain text string creation unless we need the string
3960         for a BeforeTextInserted event handler or for a plain text only region.
3961         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
3962         code here from ReplacementFragment's constructor.
3963         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
3964         FIXME.
3965         * editing/ReplaceSelectionCommand.h:
3966
3967 2006-10-31  Ada Chan  <adachan@apple.com>
3968
3969         Reviewed by Adam
3970
3971         Correct forward declarations of the HitTestRequest struct.
3972
3973         * rendering/EllipsisBox.h:
3974         * rendering/InlineBox.h:
3975         * rendering/InlineFlowBox.h:
3976         * rendering/RenderLayer.h:
3977         * rendering/RenderObject.h:
3978
3979 2006-10-31  John Sullivan  <sullivan@apple.com>
3980
3981         Reviewed by Beth and Adam
3982
3983         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
3984         next I'll make it use a string that's relevant for a specific grammar error.
3985
3986         * WebCore.exp:
3987         export symbol for spellingToolTip function
3988         
3989         * rendering/HitTestResult.h:
3990         * rendering/HitTestResult.cpp:
3991         (WebCore::HitTestResult::spellingToolTip):
3992         new function, returns the string to be used in a tool tip that describes the questionable grammar
3993         
3994         * rendering/InlineTextBox.h:
3995         * rendering/InlineTextBox.cpp:
3996         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
3997         now takes a style and font, needed to compute the rect representing the range containing
3998         questionable grammar. Computes the rect and associates it with the marker.
3999         (WebCore::InlineTextBox::paintDocumentMarkers):
4000         Pass in the style and font now needed by paintSpellingOrGrammarMarker
4001
4002 2006-10-31  Adele Peterson  <adele@apple.com>
4003
4004         Removed commented out variable from last checkin.
4005
4006         * html/HTMLSelectElement.cpp:
4007         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
4008
4009 2006-10-31  Brady Eidson  <beidson@apple.com>
4010
4011         Build fix (unused variable in release builds)
4012
4013         * html/HTMLSelectElement.cpp:
4014         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
4015
4016 2006-10-31  Adele Peterson  <adele@apple.com>
4017
4018         Reviewed by Adam.
4019
4020         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
4021         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
4022         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
4023
4024         Tests: 
4025         * LayoutTests/fast/forms/listbox-selection.html
4026         * LayoutTests/fast/forms/listbox-onchange.html
4027
4028         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
4029           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
4030           And one for onChange, that is updated after onChange is fired.
4031           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
4032  
4033         * html/HTMLSelectElement.cpp:
4034         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
4035         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
4036         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
4037         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
4038         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
4039         (WebCore::HTMLSelectElement::setExtent): Added.
4040         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
4041         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
4042
4043         * rendering/RenderListBox.cpp:
4044         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
4045         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
4046         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
4047         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
4048          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
4049          notify the select element from here.
4050         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
4051         (WebCore::RenderListBox::listIndexIsVisible): Added.
4052         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
4053
4054         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
4055         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
4056         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
4057         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
4058         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
4059
4060 2006-10-31  Beth Dakin  <bdakin@apple.com>
4061
4062         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
4063
4064         * rendering/HitTestRequest.h: Added.
4065         (WebCore::HitTestRequest::HitTestRequest):
4066
4067 2006-10-31  Beth Dakin  <bdakin@apple.com>
4068
4069         Reviewed by Maciej.
4070
4071         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
4072         should be split into HitTestRequest and HitTestResult
4073
4074         This patch creates a new struct called HitTestRequest that holds 
4075         the three boolean values (readonly, active, and mouseMove) that 
4076         were formerly a part of HitTestResult. All hitTest() and 
4077         nodeAtPoint() functions now take a HitTestRequest in addition to 
4078         the HitTestResult.
4079
4080         * WebCore.exp:
4081         * WebCore.xcodeproj/project.pbxproj:
4082         * bridge/mac/FrameMac.mm:
4083         (WebCore::FrameMac::eventMayStartDrag):
4084         (WebCore::FrameMac::handleMouseMoveEvent):
4085         * bridge/mac/WebCoreAXObject.mm:
4086         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
4087         (-[WebCoreAXObject accessibilityHitTest:]):
4088         * dom/Document.cpp:
4089         (WebCore::Document::elementFromPoint):
4090         (WebCore::Document::prepareMouseEvent):
4091         * editing/SelectionController.cpp:
4092         (WebCore::SelectionController::contains):
4093         * page/Frame.cpp:
4094         (WebCore::Frame::hitTestResultAtPoint):
4095         * page/FrameView.cpp:
4096         (WebCore::FrameView::handleWheelEvent):
4097         * rendering/EllipsisBox.cpp:
4098         (WebCore::EllipsisBox::nodeAtPoint):
4099         * rendering/EllipsisBox.h:
4100         * rendering/HitTestResult.cpp:
4101         (WebCore::HitTestResult::HitTestResult):
4102         (WebCore::HitTestResult::operator=):
4103         * rendering/HitTestResult.h:
4104         * rendering/InlineBox.cpp:
4105         (WebCore::InlineBox::nodeAtPoint):
4106         * rendering/InlineBox.h:
4107         * rendering/InlineFlowBox.cpp:
4108         (WebCore::InlineFlowBox::nodeAtPoint):
4109         * rendering/InlineFlowBox.h:
4110         * rendering/InlineTextBox.cpp:
4111         (WebCore::InlineTextBox::nodeAtPoint):
4112         * rendering/InlineTextBox.h:
4113         * rendering/RenderBlock.cpp:
4114         (WebCore::RenderBlock::nodeAtPoint):
4115         * rendering/RenderBlock.h:
4116         * rendering/RenderBox.cpp:
4117         (WebCore::RenderBox::nodeAtPoint):
4118         * rendering/RenderBox.h:
4119         * rendering/RenderFlow.cpp:
4120         (WebCore::RenderFlow::hitTestLines):
4121         * rendering/RenderFlow.h:
4122         * rendering/RenderForeignObject.cpp:
4123         (WebCore::RenderForeignObject::nodeAtPoint):
4124         * rendering/RenderForeignObject.h:
4125         * rendering/RenderFrameSet.cpp:
4126         (WebCore::RenderFrameSet::nodeAtPoint):
4127         * rendering/RenderFrameSet.h:
4128         * rendering/RenderImage.cpp:
4129         (WebCore::RenderImage::nodeAtPoint):
4130         * rendering/RenderImage.h:
4131         * rendering/RenderInline.cpp:
4132         (WebCore::RenderInline::nodeAtPoint):
4133         * rendering/RenderInline.h:
4134         * rendering/RenderLayer.cpp:
4135         (WebCore::RenderLayer::autoscroll):
4136         (WebCore::RenderLayer::hitTest):
4137         (WebCore::RenderLayer::hitTestLayer):
4138         (WebCore::RenderLayer::updateHoverActiveState):
4139         * rendering/RenderLayer.h:
4140         * rendering/RenderObject.cpp:
4141         (WebCore::RenderObject::hitTest):
4142         (WebCore::RenderObject::nodeAtPoint):
4143         * rendering/RenderObject.h:
4144         * rendering/RenderPath.cpp:
4145         (WebCore::RenderPath::nodeAtPoint):
4146         * rendering/RenderPath.h:
4147         * rendering/RenderSVGImage.cpp:
4148         (WebCore::RenderSVGImage::nodeAtPoint):
4149         * rendering/RenderSVGImage.h:
4150         * rendering/RenderSVGText.cpp:
4151         (WebCore::RenderSVGText::nodeAtPoint):
4152         * rendering/RenderSVGText.h:
4153         * rendering/RenderTableRow.cpp:
4154         (WebCore::RenderTableRow::nodeAtPoint):
4155         * rendering/RenderTableRow.h:
4156         * rendering/RenderTableSection.cpp:
4157         (WebCore::RenderTableSection::nodeAtPoint):
4158         * rendering/RenderTableSection.h:
4159         * rendering/RenderText.h:
4160         (WebCore::RenderText::nodeAtPoint):
4161         * rendering/RenderTextControl.cpp:
4162         (WebCore::RenderTextControl::nodeAtPoint):
4163         * rendering/RenderTextControl.h:
4164         * rendering/RootInlineBox.cpp:
4165         (WebCore::RootInlineBox::nodeAtPoint):
4166         * rendering/RootInlineBox.h:
4167
4168 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
4169
4170         Reviewed by Maciej.
4171
4172</