WebCore/ChangeLog

   1 2006-09-28  David Hyatt  <hyatt@apple.com>
   2
   3         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
   4
   5         * bridge/mac/FrameMac.mm:
   6         (WebCore::FrameMac::eventMayStartDrag):
   7         (WebCore::FrameMac::dragHysteresisExceeded):
   8         (WebCore::FrameMac::mouseDown):
   9         (WebCore::FrameMac::shouldDragAutoNode):
  10         (WebCore::FrameMac::sendContextMenuEvent):
  11         * bridge/mac/WebCoreFrameBridge.mm:
  12         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
  13
  14 2006-09-28  Dave Hyatt  <hyatt@apple.com>
  15
  16         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
  17         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
  18         view.
  19
  20         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
  21         the patch after review, once I realized that these new functions essentially do the same thing.)
  22
  23         * dom/EventTargetNode.cpp:
  24         (WebCore::EventTargetNode::dispatchMouseEvent):
  25         (WebCore::EventTargetNode::dispatchWheelEvent):
  26         * page/Frame.cpp:
  27         (WebCore::Frame::selectClosestWordFromMouseEvent):
  28         (WebCore::Frame::handleMousePressEventTripleClick):
  29         (WebCore::Frame::handleMousePressEventSingleClick):
  30         (WebCore::Frame::handleMouseMoveEvent):
  31         (WebCore::Frame::handleMouseReleaseEvent):
  32         * page/FrameView.cpp:
  33         (WebCore::FrameView::handleMousePressEvent):
  34         (WebCore::selectCursor):
  35         (WebCore::FrameView::dispatchDragEvent):
  36         (WebCore::FrameView::prepareMouseEvent):
  37         (WebCore::FrameView::handleWheelEvent):
  38         * platform/ScrollView.h:
  39         * platform/Widget.cpp:
  40         (WebCore::Widget::convertToContainingWindow):
  41         * platform/Widget.h:
  42         * platform/mac/ScrollViewMac.mm:
  43         (WebCore::ScrollView::convertToContainingWindow):
  44         (WebCore::ScrollView::convertFromContainingWindow):
  45         * platform/mac/WidgetMac.mm:
  46         (WebCore::Widget::convertToContainingWindow):
  47         (WebCore::Widget::convertFromContainingWindow):
  48         * platform/win/ScrollViewWin.cpp:
  49         (WebCore::ScrollView::convertToContainingWindow):
  50         (WebCore::ScrollView::convertFromContainingWindow):
  51         * rendering/RenderLayer.cpp:
  52         (WebCore::RenderLayer::resize):
  53
  54 2006-09-28  Alice Liu  <alice.liu@apple.com>
  55
  56         Build fix by adding missing files for CommandByName
  57
  58         * WebCore.xcodeproj/project.pbxproj:
  59
  60 2006-09-28  Alice Liu  <alice.liu@apple.com>
  61
  62         Adding CommandByName files to the vcproj
  63
  64         * WebCore.vcproj/WebCore/WebCore.vcproj:
  65
  66 2006-09-28  Alice Liu  <alice.liu@apple.com>
  67
  68         Reviewed by Adam Roben.
  69
  70         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc.
  71         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
  72         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
  73
  74         * editing/CommandByName.cpp: Added.
  75         Added a command class that hangs off the frame so the frame can call commands more easily.
  76         (WebCore::Frame::commandImp):
  77         (WebCore::Frame::execCopy):
  78         (WebCore::Frame::execCut):
  79         (WebCore::Frame::execDelete):
  80         (WebCore::Frame::execForwardDelete):
  81         (WebCore::Frame::execPaste):
  82         (WebCore::Frame::execMoveLeft):
  83         (WebCore::Frame::execMoveRight):
  84         (WebCore::Frame::execMoveUp):
  85         (WebCore::Frame::execMoveDown):
  86         (WebCore::Frame::execSelectAll):
  87         (WebCore::Frame::execSelectLeft):
  88         (WebCore::Frame::execSelectRight):
  89         (WebCore::Frame::execSelectUp):
  90         (WebCore::Frame::execSelectDown):
  91         (WebCore::Frame::enabled):
  92         (WebCore::Frame::enabledAnySelection):
  93         (WebCore::Frame::enabledAnyEditableSelection):
  94         (WebCore::Frame::enabledPaste):
  95         (WebCore::Frame::enabledAnyRangeSelection):
  96         (WebCore::Frame::enabledAnyEditableRangeSelection):
  97         (WebCore::Frame::createCommandDictionary):
  98         (WebCore::Frame::Command::):
  99         (WebCore:::m_frame):
 100         (WebCore::CommandByName::execCommand):
 101         * editing/CommandByName.h: Added.
 102         * page/Frame.cpp:
 103         Added implementation of accessor for CommandByName member
 104         (WebCore::Frame::command):
 105         * page/Frame.h:
 106         Added accessor for CommandByName member
 107         * page/FramePrivate.h:
 108         Added a CommandByName member
 109         (WebCore::FramePrivate::FramePrivate):
 110         * platform/PlatformMouseEvent.h:
 111         Changed constructor prototype
 112         * platform/StringImpl.cpp:
 113         Exposing getWordBreakIterator to be used elsewhere
 114         (WebCore::getWordBreakIterator):
 115         * platform/StringImpl.h:
 116         Exposing getWordBreakIterator to be used elsewhere
 117         * platform/win/MouseEventWin.cpp:
 118         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
 119         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
 120
 121 2006-09-28  Adam Roben  <aroben@apple.com>
 122
 123         Reviewed by Adele.
 124
 125         Remove no-longer-used PopUpButton.
 126
 127         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
 128         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
 129         PopUpButtonMac.mm
 130         * platform/PopUpButton.h: Removed.
 131         * platform/mac/PopUpButtonMac.mm: Removed.
 132         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
 133         * rendering/DeprecatedRenderSelect.cpp: Change #include of
 134         PopUpButton.h to ListBox.h
 135
 136 2006-09-28  Darin Adler  <darin@apple.com>
 137
 138         Reviewed by Alice.
 139
 140         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
 141           10% perf. regression (copying strings while decoding)
 142
 143         Use Vector<UChar> instead of String when building up the decoded string in
 144         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
 145         String grows the buffer every single time that append is called. Using
 146         Vector::append instead of String::append also avoids constructing a string
 147         each time just to append and a questionable copy that is done inside the
 148         String::append function which also contributed to the slowness.
 149
 150         * platform/PlatformString.h:
 151         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
 152         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
 153         allocation.
 154         * platform/StringImpl.h:
 155         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
 156
 157         * platform/StreamingTextDecoder.h:
 158         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
 159         Change to use a Vector<UChar> instead of a String, since vectors have better
 160         resizing performance (they store a separate capacity).
 161
 162         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
 163         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
 164         Change to use Vector<UChar> instead of String and then create a string at
 165         the end of the process using the new adopt function.
 166
 167 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
 168
 169         Reviewed by Tim H.
 170
 171         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11057
 172         Auto-generate more SVG Objective-C bindings
 173
 174         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean,
 175           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
 176           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
 177           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
 178           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
 179           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests,
 180           and DOMSVGTransformable.
 181
 182         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
 183           parent interfaces and the SVG animated classes.
 184
 185         - Corrects CodeGenerator.pm to only skip the first parent for the main
 186           interface.
 187
 188         * DerivedSources.make:
 189         * WebCore.xcodeproj/project.pbxproj:
 190         * bindings/objc/DOMInternal.h:
 191         * bindings/objc/DOMSVG.h:
 192         * bindings/scripts/CodeGenerator.pm:
 193         * bindings/scripts/CodeGeneratorObjC.pm:
 194         * ksvg2/svg/SVGAnimatedAngle.idl:
 195         * ksvg2/svg/SVGAnimatedBoolean.idl:
 196         * ksvg2/svg/SVGAnimatedEnumeration.idl:
 197         * ksvg2/svg/SVGAnimatedInteger.idl:
 198         * ksvg2/svg/SVGAnimatedLength.idl:
 199         * ksvg2/svg/SVGAnimatedLengthList.idl:
 200         * ksvg2/svg/SVGAnimatedNumber.idl:
 201         * ksvg2/svg/SVGAnimatedPathData.idl:
 202         * ksvg2/svg/SVGAnimatedString.idl:
 203         * ksvg2/svg/SVGAnimatedTransformList.idl:
 204         * ksvg2/svg/SVGExternalResourcesRequired.idl:
 205         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
 206         * ksvg2/svg/SVGFitToViewBox.idl:
 207         * ksvg2/svg/SVGLangSpace.idl:
 208         * ksvg2/svg/SVGLocatable.idl:
 209         * ksvg2/svg/SVGMetadataElement.idl:
 210         * ksvg2/svg/SVGStringList.idl:
 211         * ksvg2/svg/SVGStylable.idl:
 212         * ksvg2/svg/SVGStyleElement.idl:
 213         * ksvg2/svg/SVGTests.idl:
 214         * ksvg2/svg/SVGTransformable.idl:
 215         * ksvg2/svg/SVGURIReference.idl:
 216         * ksvg2/svg/SVGUnitTypes.idl:
 217         * ksvg2/svg/SVGZoomAndPan.idl:
 218
 219 2006-09-28  Brady Eidson  <beidson@apple.com>
 220
 221         Reviewed by Mitz Pettel!!!
 222
 223         Change the error code check for common functions from SQLResultOk to SQLResultDone
 224
 225         * loader/icon/IconDatabase.cpp:
 226         (WebCore::IconDatabase::forgetPageURLQuery):
 227         (WebCore::IconDatabase::setIconIDForPageURLQuery):
 228         (WebCore::IconDatabase::addIconForIconURLQuery):
 229
 230 2006-09-28  Dave Hyatt  <hyatt@apple.com>
 231
 232         Just eliminate MapWindowPoints usage and use the HWND as
 233         the viewport.
 234
 235         * platform/win/MouseEventWin.cpp:
 236         (WebCore::positionForEvent):
 237         * platform/win/ScrollViewWin.cpp:
 238         (WebCore::ScrollView::viewportToContents):
 239         (WebCore::ScrollView::contentsToViewport):
 240
 241 2006-09-27  David Hyatt  <hyatt@apple.com>
 242
 243         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
 244         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
 245         scrollbars to provide hover feedback if needed.
 246
 247         Reviewed by Eric
 248
 249         * page/FrameView.cpp:
 250         (WebCore::selectCursor):
 251         (WebCore::FrameView::handleMouseMoveEvent):
 252         * platform/ScrollBar.h:
 253         (WebCore::ScrollBar::mouseMoved):
 254
 255 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
 256
 257         Reviewed by Maciej and Adam, landed by Adam
 258
 259         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=11072
 260         Windows build is busted
 261
 262         * platform/win/TemporaryLinkStubs.cpp:
 263         (ScrollView::paint):
 264         (ScrollView::themeChanged):
 265
 266 2006-09-27  Eric Seidel  <eric@eseidel.com>
 267
 268         Reviewed by mitz.
 269
 270         paths with no fill specified default to black but do not recieve paint-related mouse events
 271         http://bugzilla.opendarwin.org/show_bug.cgi?id=11069
 272         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
 273
 274         Test: svg/custom/hover-default-fill.svg
 275
 276         * kcanvas/RenderPath.cpp:
 277         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
 278         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
 279         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 280         (WebCore::KSVGPainterFactory::isFilled): remove null check
 281         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
 282         (WebCore::KSVGPainterFactory::isStroked): remove null check
 283         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
 284         * ksvg2/svg/SVGPaint.cpp:
 285         (WebCore::SVGPaint::defaultFill): added.
 286         (WebCore::SVGPaint::defaultStroke): added.
 287         * ksvg2/svg/SVGPaint.h:
 288
 289 2006-09-27  Rob Buis  <buis@kde.org>
 290
 291         Reviewed by eseidel.
 292
 293         http://bugzilla.opendarwin.org/show_bug.cgi?id=11015
 294         SVG handles em units incorrectly
 295
 296         Calculate viewport coordinates at layout time, since
 297         at this point the font size is known and lengths depending
 298         on font sizes can be calculated correctly.
 299
 300         * kcanvas/RenderSVGContainer.cpp:
 301         (WebCore::RenderSVGContainer::layout):
 302         (WebCore::RenderSVGContainer::viewport):
 303         (WebCore::RenderSVGContainer::calcViewport):
 304         * kcanvas/RenderSVGContainer.h:
 305         * ksvg2/svg/SVGLength.cpp:
 306         (WebCore::SVGLength::updateValue):
 307         * ksvg2/svg/SVGMarkerElement.cpp:
 308         (WebCore::SVGMarkerElement::createRenderer):
 309         * ksvg2/svg/SVGSVGElement.cpp:
 310         (WebCore::SVGSVGElement::createRenderer):
 311         (WebCore::SVGSVGElement::attributeChanged):
 312         * ksvg2/svg/SVGSVGElement.h:
 313
 314 2006-09-27  Eric Seidel  <eric@eseidel.com>
 315
 316         Reviewed by darin.
 317
 318         Change our invalid-fill error behavior to match Opera (and soon Firefox)
 319         http://bugzilla.opendarwin.org/show_bug.cgi?id=11017
 320
 321         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 322         (WebCore::KSVGPainterFactory::isFilled):
 323         (WebCore::KSVGPainterFactory::fillPaintServer):
 324         (WebCore::KSVGPainterFactory::isStroked):
 325         (WebCore::KSVGPainterFactory::strokePaintServer):
 326
 327 2006-09-27  Brady Eidson  <beidson@apple.com>
 328
 329         Build fix
 330
 331         * loader/icon/IconDatabase.cpp:
 332         (WebCore::readySQLStatement):
 333
 334 2006-09-27  Brady Eidson  <beidson@apple.com>
 335
 336         Reviewed by Adam
 337
 338         In very specific circumstances, prepared SQLStatements can become invalid without
 339         any warning.  This checks for that state and re-prepares the statement and also
 340         adds more aggressive error-checking everywhere these statements are used.
 341
 342         * loader/icon/IconDatabase.cpp:
 343         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
 344         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
 345         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
 346         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
 347         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
 348         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
 349         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
 350         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
 351         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
 352         * loader/icon/SQLStatement.cpp:
 353         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
 354         * loader/icon/SQLStatement.h:
 355
 356 2006-09-26  Darin Adler  <darin@apple.com>
 357
 358         Reviewed by Steve.
 359
 360         - clean up options for font code path
 361
 362         * platform/Font.h:
 363         * platform/Font.cpp:
 364         (WebCore::Font::setCodePath): Added. Replaces boolean version.
 365         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
 366
 367         * platform/mac/WebCoreTextRenderer.mm:
 368         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
 369
 370 2006-09-26  John Sullivan  <sullivan@apple.com>
 371
 372         Reviewed by Darin
 373
 374         * bridge/mac/WebCoreFrameBridge.h:
 375         * bridge/mac/WebCoreFrameBridge.mm:
 376         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
 377         Added limit parameter, passed down to Frame
 378
 379         * page/Frame.h:
 380         * page/Frame.cpp:
 381         (WebCore::Frame::markAllMatchesForText):
 382         Added limit parameter. Stop the search if it hits limit.
 383
 384 2006-09-26  Sean Gies  <seangies@apple.com>
 385
 386         Reviewed by Brady Eidson.
 387
 388         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
 389
 390 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
 391
 392         Reviewed by john
 393
 394         <rdar://problem/4747695>
 395         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
 396
 397         * editing/DeleteSelectionCommand.cpp:
 398         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
 399         to select special elements that are fully selected after expansion
 400         moves to positions that are visually distinct from the originals.
 401         * editing/InsertListCommand.cpp:
 402         (WebCore::InsertListCommand::doApply): If the content of the list
 403         item will be moved into another list, put it in a list item.
 404
 405 2006-09-26  Geoffrey Garen <ggaren@apple.com>
 406
 407         Reviewed by Darin.
 408
 409         Temporary work-around for frame lifetime issue.
 410
 411         * page/Frame.cpp:
 412         (WebCore::Frame::clear):
 413         (WebCore::Frame::disconnectOwnerElement):
 414
 415 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
 416
 417         Reviewed by Tim H.
 418
 419         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11038
 420         Auto-generate DOMSVGElement for the Objective-C bindings
 421
 422         - Auto-generates DOMSVGElement.
 423
 424         - Make SVGExceptions work like all the other ExceptionCode
 425           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
 426           and SVGExceptionMax.
 427
 428         * DerivedSources.make:
 429         * WebCore.xcodeproj/project.pbxproj:
 430         * bindings/js/kjs_binding.cpp:
 431         (KJS::):
 432         (KJS::setDOMException):
 433         * bindings/objc/DOMInternal.h:
 434         * bindings/objc/DOMInternal.mm:
 435         (raiseDOMException):
 436         * bindings/objc/DOMSVG.h:
 437         * bindings/objc/DOMSVGExecption.h: Added.
 438         * ksvg2/ksvg.h:
 439         * ksvg2/svg/SVGElement.cpp:
 440         (WebCore::SVGElement::setId):
 441         (WebCore::SVGElement::setXmlbase):
 442         * ksvg2/svg/SVGElement.h:
 443         * ksvg2/svg/SVGElement.idl:
 444         * ksvg2/svg/SVGException.h: Added.
 445         (WebCore::):
 446
 447 2006-09-26  Eric Seidel  <eric@eseidel.com>
 448
 449         Reviewed by Tim H.
 450
 451         viewbox parser does not allow <tab> as a delimiter
 452         http://bugzilla.opendarwin.org/show_bug.cgi?id=11014
 453
 454         Test: svg/hixie/viewbox/003.xml
 455
 456         * ksvg2/svg/svgpathparser.cpp:
 457         (WebCore::isWhitespace): new function
 458         (WebCore::skipOptionalSpaces):
 459         (WebCore::skipOptionalSpacesOrComma):
 460
 461 2006-09-26  Eric Seidel  <eric@eseidel.com>
 462
 463         Reviewed by Tim H.
 464
 465         SVGDocument::createElement does not create elements in the SVG namespace
 466         http://bugzilla.opendarwin.org/show_bug.cgi?id=10932
 467
 468         Test: svg/custom/createelement.svg
 469
 470         * ksvg2/svg/SVGDocument.cpp:
 471         (WebCore::SVGDocument::createElement):
 472         * ksvg2/svg/SVGDocument.h:
 473
 474 2006-09-26  Eric Seidel  <eric@eseidel.com>
 475
 476         Reviewed by Tim H.
 477
 478         RenderPath::nodeAtPoint does not respect stroke width
 479         http://bugzilla.opendarwin.org/show_bug.cgi?id=10829
 480
 481         Test: svg/custom/stroke-width-click.svg
 482
 483         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
 484         (WebCore::RenderPath::strokeContains):
 485         * kcanvas/device/quartz/QuartzSupport.h:
 486         * kcanvas/device/quartz/QuartzSupport.mm:
 487
 488 2006-09-26  Eric Seidel  <eric@eseidel.com>
 489
 490         Reviewed by mitz.
 491
 492         Bring animation back to life
 493         http://bugzilla.opendarwin.org/show_bug.cgi?id=11021
 494
 495         Register/unregister SVGSVGElements as time containers on insertion/removal.
 496         Replace uses of DeprecatedString with String in SVGAnimationElement
 497         Various whitespace clean-up.
 498
 499         * ksvg2/misc/KSVGTimeScheduler.cpp:
 500         (WebCore::SVGTimer::notifyAll):
 501         * ksvg2/misc/SVGDocumentExtensions.cpp:
 502         (WebCore::SVGDocumentExtensions::startAnimations):
 503         (WebCore::SVGDocumentExtensions::pauseAnimations):
 504         (WebCore::SVGDocumentExtensions::unpauseAnimations):
 505         * ksvg2/svg/SVGAnimateTransformElement.cpp:
 506         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
 507         (WebCore::SVGAnimateTransformElement::parseTransformValue):
 508         * ksvg2/svg/SVGAnimateTransformElement.h:
 509         * ksvg2/svg/SVGAnimationElement.cpp:
 510         (WebCore::SVGAnimationElement::SVGAnimationElement):
 511         (WebCore::SVGAnimationElement::parseMappedAttribute):
 512         (WebCore::SVGAnimationElement::parseClockValue):
 513         (WebCore::SVGAnimationElement::targetAttribute):
 514         (WebCore::SVGAnimationElement::setTargetAttribute):
 515         (WebCore::SVGAnimationElement::attributeName):
 516         * ksvg2/svg/SVGAnimationElement.h:
 517         (WebCore::SVGAnimationElement::rendererIsNeeded):
 518         * ksvg2/svg/SVGSVGElement.cpp:
 519         (WebCore::SVGSVGElement::getScreenCTM):
 520         (WebCore::SVGSVGElement::createRenderer):
 521         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
 522         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
 523         * ksvg2/svg/SVGSVGElement.h:
 524         * ksvg2/svg/SVGSetElement.cpp:
 525         (WebCore::SVGSetElement::handleTimerEvent):
 526         * ksvg2/svg/SVGURIReference.cpp:
 527         (WebCore::SVGURIReference::getTarget):
 528         * ksvg2/svg/SVGURIReference.h:
 529
 530 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
 531
 532         Reviewed by mitzpettel.
 533
 534         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=11020
 535         No-SVG build broken since r16549
 536
 537         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
 538
 539         * css/cssparser.cpp:
 540         (WebCore::CSSParser::parseValue):
 541         * css/cssstyleselector.cpp:
 542         (WebCore::CSSStyleSelector::applyProperty):
 543         * page/FrameView.cpp:
 544         (WebCore::selectCursor):
 545         * platform/qt/GraphicsContextQt.cpp:
 546
 547 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
 548
 549         Reviewed by Maciej.
 550
 551         http://bugzilla.opendarwin.org/show_bug.cgi?id=10820
 552         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
 553
 554         (Originally written by Eric Seidel).
 555
 556         * bindings/js/kjs_window.cpp:
 557         (KJS::floatFeature):
 558         * ksvg2/svg/SVGAngle.cpp:
 559         (SVGAngle::setValueAsString):
 560         * ksvg2/svg/SVGAnimationElement.cpp:
 561         (SVGAnimationElement::parseMappedAttribute):
 562         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
 563         (SVGComponentTransferFunctionElement::parseMappedAttribute):
 564         * ksvg2/svg/SVGFECompositeElement.cpp:
 565         (WebCore::SVGFECompositeElement::parseMappedAttribute):
 566         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
 567         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
 568         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
 569         (SVGFEDisplacementMapElement::parseMappedAttribute):
 570         * ksvg2/svg/SVGFELightElement.cpp:
 571         (SVGFELightElement::parseMappedAttribute):
 572         * ksvg2/svg/SVGFEOffsetElement.cpp:
 573         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
 574         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
 575         (SVGFESpecularLightingElement::parseMappedAttribute):
 576         * ksvg2/svg/SVGFETurbulenceElement.cpp:
 577         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
 578         * ksvg2/svg/SVGStopElement.cpp:
 579         (SVGStopElement::parseMappedAttribute):
 580         * platform/AtomicString.h:
 581         (WebCore::AtomicString::toDouble):
 582         * platform/PlatformString.h:
 583         * platform/String.cpp:
 584         (WebCore::String::toDouble):
 585         * platform/StringImpl.cpp:
 586         (WebCore::StringImpl::toDouble):
 587         * platform/StringImpl.h:
 588         * rendering/DeprecatedSlider.cpp:
 589         (WebCore::DeprecatedSlider::updateFromElement):
 590         * xml/XPathGrammar.y:
 591
 592 2006-09-25  David Harrison  <harrison@apple.com>
 593
 594         Reviewed by Tim Omernick and Tim Hatcher.
 595
 596         <rdar://problem/4717965> Text Field text parameterized attributes should work
 597         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
 598
 599         * bridge/mac/WebCoreAXObject.mm:
 600         (-[WebCoreAXObject accessibilityAttributeValue:]):
 601         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
 602
 603         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
 604         Cleaned up. Added text field and text area parameterzed attributes.
 605
 606         (-[WebCoreAXObject doAXLineForTextMarker:]):
 607         Fixed to be zero-based and to deal with the first position properly.
 608
 609         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
 610         Minor formatting.
 611
 612         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
 613         (-[WebCoreAXObject indexForTextMarker:]):
 614         (-[WebCoreAXObject textMarkerRangeForRange:]):
 615         (-[WebCoreAXObject rangeForTextMarkerRange:]):
 616         New utility methods.
 617
 618         (-[WebCoreAXObject doAXLineForIndex:]):
 619         (-[WebCoreAXObject doAXRangeForLine:]):
 620         (-[WebCoreAXObject doAXStringForRange:]):
 621         (-[WebCoreAXObject doAXRangeForPosition:]):
 622         (-[WebCoreAXObject doAXRangeForIndex:]):
 623         (-[WebCoreAXObject doAXBoundsForRange:]):
 624         (-[WebCoreAXObject doAXAttributedStringForRange:]):
 625         (-[WebCoreAXObject doAXRTFForRange:]):
 626         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
 627         Implement text field and text area parameterized attributes.
 628
 629         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
 630         Added text field and text area parameterzed attributes.
 631
 632         * rendering/RenderTextControl.h:
 633         Made indexForVisiblePosition() and visiblePositionForIndex() public.
 634
 635 2006-09-25  Adam Roben  <aroben@apple.com>
 636
 637         Reviewed by Brady.
 638
 639         Build fixes.
 640
 641         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
 642         * platform/ResourceLoader.h: Store whether a particular job
 643         has received a response within the ResourceLoader object itself, since
 644         it's possible that we will enter the InternetReadFileExA while loop
 645         twice for the same job.
 646         * platform/ResourceLoaderInternal.h: Add private instance variable to
 647         store whether we've received a response.
 648         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
 649         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
 650         directives.
 651         * platform/win/ResourceLoaderWin.cpp:
 652         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
 653         whether it has received a response instead of assuming it hasn't.
 654         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
 655         (WebCore::ResourceLoader::hasReceivedResponse): Added.
 656         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
 657         setProportion
 658         (ScrollBar::setProportion):
 659
 660 2006-09-25  Brady Eidson  <beidson@apple.com>
 661
 662         Requested by ggaren
 663
 664         Disabled IconDatabase logging by default
 665
 666         * platform/Logging.cpp:
 667         (WebCore::):
 668
 669 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
 670
 671         Build fix
 672
 673         * platform/cf/ResourceLoaderCFNet.cpp:
 674         (WebCore::willCacheResponse):
 675
 676 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
 677
 678         Reviewed by john
 679
 680         <http://bugzilla.opendarwin.org/show_bug.cgi?id=11002>
 681         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
 682
 683         * editing/IndentOutdentCommand.cpp:
 684         (WebCore::IndentOutdentCommand::indentRegion): Special case
 685         an empty root editable element.
 686
 687 2006-09-25  Brady Eidson  <beidson@apple.com>
 688
 689         Reviewed by Steve
 690
 691         Math error in SystemTimeWin
 692
 693         * platform/win/SystemTimeWin.cpp:
 694         (WebCore::currentTime):
 695
 696 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
 697
 698         Reviewed by Eric.
 699
 700         Whitespace cleanup; rename *job variables to *loader.
 701
 702         * bindings/js/JSXMLHttpRequest.cpp:
 703         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
 704         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
 705         (KJS::JSXMLHttpRequestConstructorImp::construct):
 706         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
 707         (KJS::JSXMLHttpRequest::getValueProperty):
 708         (KJS::JSXMLHttpRequest::put):
 709         (KJS::JSXMLHttpRequest::putValueProperty):
 710         (KJS::JSXMLHttpRequest::mark):
 711         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
 712         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
 713         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
 714         * bindings/js/JSXMLHttpRequest.h:
 715         (KJS::JSXMLHttpRequest::toBoolean):
 716         * xml/xmlhttprequest.cpp:
 717         (WebCore::XMLHttpRequest::XMLHttpRequest):
 718         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
 719         (WebCore::XMLHttpRequest::send):
 720         (WebCore::XMLHttpRequest::abort):
 721         (WebCore::XMLHttpRequest::receivedAllData):
 722         (WebCore::XMLHttpRequest::receivedData):
 723         * xml/xmlhttprequest.h:
 724         (WebCore::):
 725
 726 2006-09-25  Timothy Hatcher  <timothy@apple.com>
 727
 728         Reviewed by Brady.
 729
 730         - Deprecate the rest of the old-style methods that are not generated.
 731         - Add @property syntax to DOMRange.
 732
 733         * WebCore.xcodeproj/project.pbxproj:
 734         * bindings/objc/DOM.mm:
 735         (-[DOMRange setStart:offset:]):
 736         (-[DOMRange setEnd:offset:]):
 737         (-[DOMRange compareBoundaryPoints:sourceRange:]):
 738         (-[DOMRange setStart::]):
 739         (-[DOMRange setEnd::]):
 740         (-[DOMRange compareBoundaryPoints::]):
 741         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
 742         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
 743         (-[DOMDocument createNodeIterator::::]):
 744         (-[DOMDocument createTreeWalker::::]):
 745         * bindings/objc/DOMCSS.h:
 746         * bindings/objc/DOMCSS.mm:
 747         (-[DOMDocument getComputedStyle:pseudoElement:]):
 748         (-[DOMDocument getComputedStyle::]):
 749         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
 750         * bindings/objc/DOMExtensions.h:
 751         * bindings/objc/DOMHTML.h:
 752         * bindings/objc/DOMRange.h:
 753         * bindings/objc/DOMTraversal.h:
 754
 755 2006-09-25  Eric Seidel  <eric@eseidel.com>
 756
 757         Reviewed by mjs.
 758
 759         Outermost <svg> element should clip to viewport
 760         http://bugzilla.opendarwin.org/show_bug.cgi?id=11007
 761
 762         Test: svg/custom/viewport-clip.svg
 763
 764         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
 765
 766 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
 767
 768         Reviewed by Maciej.
 769
 770         * css/MediaList.cpp:
 771         Remove unused header.
 772
 773         * dom/Document.cpp:
 774         (WebCore::Document::clear):
 775         Use clear instead of iterating through the list of event listeners, removing each one.
 776         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
 777
 778         * html/HTMLKeygenElement.cpp:
 779         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
 780         (WebCore::HTMLKeygenElement::appendFormData):
 781         Update due to changes in the SSL key generator.
 782
 783         * ksvg2/svg/SVGAngle.cpp:
 784         Remove unused header.
 785
 786         * ksvg2/svg/SVGAnimationElement.cpp:
 787         (SVGAnimationElement::parseMappedAttribute):
 788         Rename methods and pass Strings instead of DeprecatedStrings to
 789         parseSeparatedList.
 790
 791         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
 792         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
 793         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
 794         * ksvg2/svg/SVGFEMergeElement.cpp:
 795         * ksvg2/svg/SVGFEOffsetElement.cpp:
 796         Remove unused headers.
 797
 798         * ksvg2/svg/SVGHelper.cpp:
 799         (WebCore::SVGHelper::parseSeparatedList):
 800         * ksvg2/svg/SVGHelper.h:
 801         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
 802         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
 803
 804         * ksvg2/svg/SVGLengthList.cpp:
 805         (WebCore::SVGLengthList::parse):
 806         * ksvg2/svg/SVGLengthList.h:
 807         Use Vector<String> instead of DeprecatedStringList.
 808
 809         * loader/Cache.cpp:
 810         (WebCore::Cache::requestImage):
 811         (WebCore::Cache::requestStyleSheet):
 812         (WebCore::Cache::requestScript):
 813         (WebCore::Cache::requestXSLStyleSheet):
 814         (WebCore::Cache::requestXBLDocument):
 815         (WebCore::Cache::remove):
 816         (WebCore::Cache::get):
 817         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
 818
 819         * loader/DocLoader.cpp:
 820         (WebCore::DocLoader::needReload):
 821         * loader/DocLoader.h:
 822         Use a HashSet instead of DeprecatedStringList.
 823
 824         * page/FrameView.h:
 825         Remove declarations that have no functions.
 826
 827         * platform/SSLKeyGenerator.h:
 828         * platform/mac/SSLKeyGeneratorMac.mm:
 829         (WebCore::supportedKeySizes):
 830         (WebCore::signedPublicKeyAndChallengeString):
 831         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
 832         DeprecatedString.
 833
 834 2006-09-25  Dave Hyatt  <hyatt@apple.com>
 835
 836         Shunt the RenderTheme world transform adoption between
 837         Cairo and Windows into getWindowsContext and move the method
 838         out of GraphicsContextCairo and into GraphicsContextWin.
 839
 840         * ChangeLog:
 841         * WebCore.vcproj/WebCore/WebCore.vcproj:
 842         * platform/cairo/GraphicsContextCairo.cpp:
 843         * platform/win/GraphicsContextWin.cpp: Added.
 844         (WebCore::GraphicsContext::getWindowsContext):
 845         (WebCore::GraphicsContext::releaseWindowsContext):
 846         * rendering/RenderThemeWin.cpp:
 847         (WebCore::prepareForDrawing):
 848
 849 2006-09-24  Eric Seidel  <eric@eseidel.com>
 850
 851         Reviewed by hyatt.
 852
 853         <svg:a> cannot be styled with a:hover
 854         http://bugzilla.opendarwin.org/show_bug.cgi?id=11005
 855
 856         Test: svg/hixie/cascade/002.xml
 857
 858         * css/cssstyleselector.cpp:
 859         (WebCore::checkPseudoState):
 860
 861 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
 862
 863         Reviewed by Tim H.
 864
 865         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10882
 866         SVG needs Obj-C DOM bindings
 867
 868         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
 869           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
 870           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
 871           DOMSVGTransformList.
 872
 873         * DerivedSources.make:
 874         * WebCore.xcodeproj/project.pbxproj:
 875         * bindings/objc/DOMInternal.h:
 876         * bindings/objc/DOMSVG.h: Added.
 877         * ksvg2/svg/SVGAngle.idl:
 878         * ksvg2/svg/SVGLength.idl:
 879         * ksvg2/svg/SVGLengthList.idl:
 880         * ksvg2/svg/SVGMatrix.idl:
 881         * ksvg2/svg/SVGPathSeg.idl:
 882         * ksvg2/svg/SVGPathSegList.idl:
 883         * ksvg2/svg/SVGTransform.idl:
 884         * ksvg2/svg/SVGTransformList.idl:
 885
 886 2006-09-24  Rob Buis  <buis@kde.org>
 887
 888         Reviewed by eseidel.
 889
 890         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6001
 891         WebKit does not handle fallback custom cursors
 892         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6002
 893         WebKit does not properly handle SVG <cursor> element
 894
 895         Add support for svg cursor images. Also make sure hotspot
 896         settings are handled correctly. Add tests for handling of css3
 897         cursor syntax with hotspots in strict and quirks mode. Finally
 898         implement fallback.
 899
 900         * WebCore.xcodeproj/project.pbxproj:
 901         * css/CSSComputedStyleDeclaration.cpp:
 902         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
 903         * css/CSSCursorImageValue.cpp: Added.
 904         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
 905         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
 906         * css/CSSCursorImageValue.h: Added.
 907         (WebCore::CSSCursorImageValue::hotspot):
 908         * css/cssparser.cpp:
 909         (WebCore::CSSParser::parseValue):
 910         * css/cssstyleselector.cpp:
 911         (WebCore::CSSStyleSelector::applyProperty):
 912         * ksvg2/svg/SVGCursorElement.cpp:
 913         * manual-tests/css3-cursor-fallback-quirks.html: Added.
 914         * manual-tests/css3-cursor-fallback-strict.html: Added.
 915         * manual-tests/cursorfallback.xml: Added.
 916         * page/FrameView.cpp:
 917         (WebCore::selectCursor):
 918         * platform/Cursor.h:
 919         * platform/mac/CursorMac.mm:
 920         (WebCore::createCustomCursor):
 921         (WebCore::Cursor::Cursor):
 922         * platform/qt/CursorQt.cpp:
 923         (WebCore::Cursor::Cursor):
 924         * rendering/RenderStyle.cpp:
 925         (WebCore::StyleInheritedData::StyleInheritedData):
 926         (WebCore::StyleInheritedData::operator==):
 927         (WebCore::RenderStyle::diff):
 928         (WebCore::RenderStyle::addCursor):
 929         (WebCore::RenderStyle::addSVGCursor):
 930         (WebCore::RenderStyle::setCursorList):
 931         (WebCore::RenderStyle::clearCursorList):
 932         * rendering/RenderStyle.h:
 933         (WebCore::CursorData::CursorData):
 934         (WebCore::CursorList::operator[]):
 935         (WebCore::CursorList::size):
 936         (WebCore::CursorList::append):
 937         (WebCore::RenderStyle::cursors):
 938
 939 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
 940
 941         Reviewed by Tim H.
 942
 943         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11009
 944         Auto-generate the internal methods interfaces for the Objective-C bindings
 945
 946         - Auto-generate the internal method declarations into their own files
 947           named in the form DOMFooBarInternal.h for class DOMFooBar.
 948
 949         - Remove all use of DOM_cast from code.
 950
 951         - Assorted cleanups.
 952
 953         * WebCore.xcodeproj/project.pbxproj:
 954         * bindings/objc/DOM.mm:
 955         (-[DOMNode _initWithNode:WebCore::]):
 956         (-[DOMNode WebCore::]):
 957         (-[DOMRange dealloc]):
 958         (-[DOMRange finalize]):
 959         (-[DOMRange _initWithRange:WebCore::]):
 960         (-[DOMRange WebCore::]):
 961         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
 962         (-[DOMNodeFilter WebCore::]):
 963         (-[DOMNodeFilter dealloc]):
 964         (-[DOMNodeFilter finalize]):
 965         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
 966         (-[DOMNodeIterator WebCore::]):
 967         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
 968         (-[DOMTreeWalker WebCore::]):
 969         * bindings/objc/DOMAbstractView.mm:
 970         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
 971         * bindings/objc/DOMCSS.mm:
 972         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
 973         (-[DOMCSSRule _initWithRule:WebCore::]):
 974         (-[DOMCSSValue _initWithValue:WebCore::]):
 975         * bindings/objc/DOMEvents.mm:
 976         (-[DOMEvent _initWithEvent:WebCore::]):
 977         * bindings/objc/DOMHTMLAppletElement.mm:
 978         (-[DOMHTMLAppletElement align]):
 979         (-[DOMHTMLAppletElement setAlign:]):
 980         (-[DOMHTMLAppletElement alt]):
 981         (-[DOMHTMLAppletElement setAlt:]):
 982         (-[DOMHTMLAppletElement archive]):
 983         (-[DOMHTMLAppletElement setArchive:]):
 984         (-[DOMHTMLAppletElement code]):
 985         (-[DOMHTMLAppletElement setCode:]):
 986         (-[DOMHTMLAppletElement codeBase]):
 987         (-[DOMHTMLAppletElement setCodeBase:]):
 988         (-[DOMHTMLAppletElement height]):
 989         (-[DOMHTMLAppletElement setHeight:]):
 990         (-[DOMHTMLAppletElement hspace]):
 991         (-[DOMHTMLAppletElement setHspace:]):
 992         (-[DOMHTMLAppletElement name]):
 993         (-[DOMHTMLAppletElement setName:]):
 994         (-[DOMHTMLAppletElement object]):
 995         (-[DOMHTMLAppletElement setObject:]):
 996         (-[DOMHTMLAppletElement vspace]):
 997         (-[DOMHTMLAppletElement setVspace:]):
 998         (-[DOMHTMLAppletElement width]):
 999         (-[DOMHTMLAppletElement setWidth:]):
1000         * bindings/objc/DOMInternal.h:
1001         (getDOMWrapper):
1002         (addDOMWrapper):
1003         (raiseOnDOMError):
1004         * bindings/objc/DOMXPath.mm:
1005         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
1006         * bindings/scripts/CodeGeneratorObjC.pm:
1007
1008 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1009
1010         Reviewed by eseidel.
1011
1012         Fix Qt/Linux build after Dave's Scrollbar changes.
1013
1014         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
1015         * platform/qt/TemporaryLinkStubs.cpp:
1016         (WebCore::ScrollBar::setProportion):
1017         (WebCore::PlatformScrollBar::updateThumbPosition):
1018         (WebCore::PlatformScrollBar::updateThumbProportion):
1019
1020 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1021
1022         Reviewed by eseidel.
1023
1024         Qt/Linux build system changes: enable xpath/xslt by default.
1025         Offer possibility to change all of these using 'ccmake'.
1026
1027         * CMakeLists.txt:
1028
1029 2006-09-24  Dave Hyatt  <hyatt@apple.com>
1030
1031         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
1032         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
1033         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
1034
1035         * platform/ScrollBar.cpp:
1036         (WebCore::ScrollBar::setValue):
1037         (WebCore::ScrollBar::setProportion):
1038         * platform/ScrollBar.h:
1039         (WebCore::ScrollBar::value):
1040         * platform/mac/PlatformScrollBar.h:
1041         * platform/mac/PlatformScrollBarMac.mm:
1042         (WebCore::PlatformScrollBar::updateThumbPosition):
1043         (WebCore::PlatformScrollBar::updateThumbProportion):
1044         * platform/win/PlatformScrollBar.h:
1045         * platform/win/TemporaryLinkStubs.cpp:
1046         (PlatformScrollBar::updateThumbPosition):
1047         (PlatformScrollBar::updateThumbProportion):
1048         * rendering/RenderLayer.cpp:
1049         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
1050
1051 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
1052
1053         Reviewed by Eric.
1054
1055         http://bugzilla.opendarwin.org/show_bug.cgi?id=4872
1056         XMLHttpRequest fails to throw an exception when there is a security violation
1057         (mismatching domains)
1058
1059         Raise an exception if there is a security violation, and also in cases required by
1060         the current draft of XHR specification.
1061
1062         * bindings/js/JSXMLHttpRequest.cpp:
1063         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
1064         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
1065         reports one, and also if there were too few arguments passed.
1066
1067         * bindings/js/kjs_binding.cpp:
1068         (KJS::setDOMException): Added support for custom XHR exceptions.
1069
1070         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
1071         exception code range for XHR exceptions.
1072
1073         * xml/xmlhttprequest.cpp:
1074         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
1075         (WebCore::XMLHttpRequest::send):
1076         (WebCore::XMLHttpRequest::setRequestHeader):
1077         (WebCore::XMLHttpRequest::getStatus):
1078         (WebCore::XMLHttpRequest::getStatusText):
1079         (WebCore::XMLHttpRequest::processSyncLoadResults):
1080         (WebCore::XMLHttpRequest::receivedAllData):
1081         (WebCore::XMLHttpRequest::receivedData):
1082
1083 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
1084
1085         Reviewed by Jeff Jenkins.
1086
1087         Tweak CF types.
1088
1089         * platform/cf/ResourceLoaderCFNet.cpp:
1090         (WebCore::willCacheResponse):
1091
1092 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
1093
1094         Reviewed by darin
1095
1096         <http://bugzilla.opendarwin.org/show_bug.cgi?id=8029>
1097         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
1098
1099         * dom/Document.cpp:
1100         (WebCore::Document::clearSelectionIfNeeded):
1101         * dom/Element.cpp:
1102         (WebCore::Element::contains):
1103         * dom/Node.cpp:
1104         (WebCore::Node::traverseNextNode):
1105         (WebCore::Node::traverseNextSibling):
1106         (WebCore::Node::traversePreviousNodePostOrder):
1107         (WebCore::Node::checkAddChild):
1108         (WebCore::Node::isDescendantOf):
1109         * dom/Node.h:
1110         * dom/NodeIterator.cpp:
1111         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
1112         * editing/ApplyStyleCommand.cpp:
1113         (WebCore::ApplyStyleCommand::applyBlockStyle):
1114         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
1115         (WebCore::ApplyStyleCommand::applyInlineStyle):
1116         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
1117         * editing/CompositeEditCommand.cpp:
1118         (WebCore::CompositeEditCommand::mergeIdenticalElements):
1119         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
1120         * editing/DeleteSelectionCommand.cpp:
1121         (WebCore::updatePositionForNodeRemoval):
1122         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
1123         (WebCore::DeleteSelectionCommand::mergeParagraphs):
1124         * editing/FormatBlockCommand.cpp:
1125         (WebCore::FormatBlockCommand::doApply):
1126         * editing/IndentOutdentCommand.cpp:
1127         (WebCore::enclosingListOrBlockquote):
1128         * editing/Selection.cpp:
1129         (WebCore::Selection::validate):
1130         * editing/SelectionController.cpp:
1131         (WebCore::SelectionController::nodeWillBeRemoved):
1132         * editing/TextIterator.cpp:
1133         (WebCore::SimplifiedBackwardsTextIterator::advance):
1134         * editing/VisiblePosition.cpp:
1135         (WebCore::VisiblePosition::next):
1136         (WebCore::VisiblePosition::previous):
1137         (WebCore::VisiblePosition::canonicalPosition):
1138         (WebCore::isFirstVisiblePositionInNode):
1139         (WebCore::isLastVisiblePositionInNode):
1140         * editing/htmlediting.cpp:
1141         (WebCore::firstEditablePositionAfterPositionInRoot):
1142         (WebCore::lastEditablePositionBeforePositionInRoot):
1143         (WebCore::enclosingNodeWithTag):
1144         (WebCore::enclosingList):
1145         (WebCore::enclosingListChild):
1146         * editing/markup.cpp:
1147         (WebCore::createMarkup):
1148
1149 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1150
1151         Reviewed by Darin.
1152
1153         - Added @property syntax to non-generated headers
1154           inside #ifndef BUILDING_ON_TIGER.
1155         - Changed the DOMEventTarget protocol to have have new versions
1156           of addEventListener and removeEventListener with named parameters.
1157           These old style methods can be removed once Mail changes to use
1158           the new methods <rdar://problem/4746649>.
1159
1160         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
1161         * bindings/objc/DOM.mm:
1162         (-[DOMNode addEventListener:listener:useCapture:]):
1163         (-[DOMNode addEventListener:::]): call the new method
1164         (-[DOMNode removeEventListener:listener:useCapture:]):
1165         (-[DOMNode removeEventListener:::]): call the new method
1166         * bindings/objc/DOMAbstractView.h:
1167         * bindings/objc/DOMEventTarget.h:
1168         * bindings/objc/DOMHTMLAppletElement.h:
1169         * bindings/objc/DOMHTMLEmbedElement.h:
1170         * bindings/objc/DOMHTMLOptionElement.h:
1171         * bindings/objc/DOMObject.h:
1172         * bindings/objc/DOMRGBColor.h:
1173
1174 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
1175
1176         Reviewed by Eric.
1177
1178         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
1179
1180         * platform/qt/FrameQt.cpp:
1181         * platform/qt/GraphicsContextQt.cpp:
1182         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
1183         (WebCore::GraphicsContext::origin):
1184         * platform/qt/PlatformScrollBar.h: Added.
1185         (WebCore::PlatformScrollBar::isWidget):
1186         * platform/qt/WidgetQt.cpp:
1187         (WebCore::Widget::invalidate):
1188         (WebCore::Widget::invalidateRect):
1189
1190 2006-09-22  Dave Hyatt <hyatt@apple.com>
1191
1192         Super-minor tweaks to the systemFont function on Mac.
1193         Set the generic family to None rather than to Serif, and
1194         don't waste time setting the computed size, since that is
1195         set from the specified size over in CSSStyleSelector anyway.
1196
1197         * rendering/RenderThemeMac.mm:
1198         (WebCore::RenderThemeMac::systemFont):
1199
1200 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1201
1202         Reviewed by Brady.
1203
1204         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
1205         take floats. There was already an implicit conversion to float/double
1206         when calling CGContextTranslateCTM or cairo_translate.
1207
1208         * platform/GraphicsContext.h:
1209         * platform/cairo/GraphicsContextCairo.cpp:
1210         (WebCore::GraphicsContext::translate):
1211         * platform/cg/GraphicsContextCG.cpp:
1212         (WebCore::GraphicsContext::translate):
1213
1214 2006-09-22  Brady Eidson  <beidson@apple.com>
1215
1216         Reviewed by Sfalken
1217
1218         Add redirect and other cleanup to ResourceLoaderWin.cpp
1219         Fixes bug http://bugzilla.opendarwin.org/show_bug.cgi?id=10927
1220         Fixes bug http://bugzilla.opendarwin.org/show_bug.cgi?id=10744
1221
1222         * WebCore.xcodeproj/project.pbxproj:
1223         * platform/ResourceLoader.h:
1224         * platform/win/ResourceLoaderWin.cpp:
1225         (WebCore::ResourceLoaderWndProc):
1226         (WebCore::initializeOffScreenResourceLoaderWindow):
1227         (WebCore::ResourceLoader::onHandleCreated):
1228         (WebCore::ResourceLoader::onRequestRedirected):
1229         (WebCore::ResourceLoader::onRequestComplete):
1230         (WebCore::transferJobStatusCallback):
1231
1232 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
1233
1234         Reviewed by Geoff.
1235
1236         http://bugzilla.opendarwin.org/show_bug.cgi?id=10803
1237         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
1238
1239         * page/FrameView.cpp:
1240         (WebCore::FrameView::hoverTimerFired): Use the current event.
1241
1242 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
1243
1244         Reviewed by Anders.
1245
1246         Fix (last) svg memory leak.
1247
1248         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
1249         (SVGTransformable::parseTransformAttribute):
1250
1251 2006-09-22  Eric Seidel  <eric@eseidel.com>
1252
1253         No review necessary, just removing a dead file.
1254
1255         Remove unused file (added previously by mistake) to make room for real implementation.
1256
1257         * platform/mac/BitmapImageMac.mm: Removed.
1258
1259 2006-09-22  Dave Hyatt <hyatt@apple.com>
1260
1261         Move PlatformScrollBar.h down into the platforms.
1262
1263         Reviewed by andersca
1264
1265         * platform/PlatformScrollBar.h: Removed.
1266         * platform/win/PlatformScrollBar.h: Added.
1267         * platform/mac/PlatformScrollBar.h: Added.
1268
1269 2006-09-22   Dave Hyatt  <hyatt@apple.com>
1270
1271         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
1272         any widget subsystems that don't have any underlying native objects backing the widgets.
1273
1274         Reviewed by anders
1275
1276         * platform/Widget.h:
1277         * platform/mac/WidgetMac.mm:
1278         (WebCore::Widget::invalidate):
1279         (WebCore::Widget::invalidateRect):
1280         * platform/win/TemporaryLinkStubs.cpp:
1281         (Widget::invalidate):
1282         (Widget::invalidateRect):
1283
1284 2006-09-22  Rob Buis  <buis@kd.org>
1285
1286         Reviewed by eseidel.
1287
1288         http://bugzilla.opendarwin.org/show_bug.cgi?id=10901
1289         Merge build fixes from unity
1290
1291         * CMakeLists.txt:
1292
1293 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1294
1295         Reviewed by eseidel.
1296
1297         http://bugzilla.opendarwin.org/show_bug.cgi?id=10977
1298         SVGDocument does not expose 'rootElement' property
1299
1300         Enable 'rootElement' property.
1301
1302         * ksvg2/svg/SVGDocument.idl:
1303
1304 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
1305
1306         Tweak includes.
1307
1308         * platform/ResourceLoaderInternal.h:
1309
1310 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
1311
1312         build fixed. band happy.
1313
1314         * platform/cg/GraphicsContextCG.cpp:
1315         (WebCore::GraphicsContext::translate):
1316         * platform/mac/WidgetMac.mm:
1317
1318 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
1319
1320         Reviewed by Maciej.
1321
1322         Some Widget refactoring.
1323
1324         * WebCore.vcproj/WebCore/WebCore.vcproj:
1325         * bridge/mac/FrameMac.mm:
1326         * bridge/win/FrameWin.cpp:
1327         (WebCore::FrameWin::runJavaScriptAlert):
1328         (WebCore::FrameWin::runJavaScriptConfirm):
1329         * bridge/win/PageWin.cpp:
1330         (WebCore::Page::Page):
1331         (WebCore::rootWindowForFrame):
1332         * html/CanvasRenderingContext2D.cpp:
1333         (WebCore::CanvasRenderingContext2D::translate):
1334         * page/FrameView.cpp:
1335         (WebCore::FrameView::isFrameView):
1336         * page/Page.h:
1337         (WebCore::Page::setInstanceHandle):
1338         (WebCore::Page::instanceHandle):
1339         * platform/GraphicsContext.h:
1340         * platform/ScrollView.h:
1341         * platform/Widget.h:
1342         * platform/cairo/GraphicsContextCairo.cpp:
1343         (WebCore::GraphicsContext::translate):
1344         (WebCore::GraphicsContext::origin):
1345         * platform/mac/WidgetMac.mm:
1346         (WebCore::Widget::clearFocus):
1347         * platform/win/ResourceLoaderWin.cpp:
1348         (WebCore::initializeOffScreenResourceLoaderWindow):
1349         * platform/win/ScreenWin.cpp:
1350         (WebCore::monitorInfo):
1351         * platform/win/ScrollViewWin.cpp:
1352         (WebCore::ScrollView::updateContents):
1353         (WebCore::ScrollView::visibleWidth):
1354         (WebCore::ScrollView::visibleHeight):
1355         (WebCore::ScrollView::visibleContentRect):
1356         (WebCore::ScrollView::viewportToContents):
1357         (WebCore::ScrollView::contentsToViewport):
1358         (WebCore::ScrollView::scrollBy):
1359         (WebCore::ScrollView::updateScrollInfo):
1360         (WebCore::ScrollView::updateScrollBars):
1361         * platform/win/SharedTimerWin.cpp:
1362         (WebCore::initializeOffScreenTimerWindow):
1363         * platform/win/TemporaryLinkStubs.cpp:
1364         (FrameView::updateBorder):
1365         (ScrollView::paint):
1366         (GraphicsContext::clip):
1367         * platform/win/WidgetWin.cpp:
1368         (WebCore::Widget::Widget):
1369         (WebCore::Widget::parentWindow):
1370         (WebCore::Widget::setParentWindow):
1371         (WebCore::Widget::frameGeometry):
1372         (WebCore::Widget::hasFocus):
1373         (WebCore::Widget::setFocus):
1374         (WebCore::Widget::show):
1375         (WebCore::Widget::hide):
1376         (WebCore::Widget::setFrameGeometry):
1377
1378 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
1379
1380         Reviewed by Tim H.
1381
1382         * platform/TextEncoding.cpp:
1383         (WebCore::TextEncoding::backslashAsCurrencySymbol):
1384         Add comment clarifying why backslashAsCurrencySymbol is needed.
1385
1386 2006-09-21  Sean Gies  <seangies@apple.com>
1387
1388         Reviewed by Adam Roben.
1389
1390         Add utility functions to get and release HDC from GraphicsContext.
1391
1392         * platform/GraphicsContext.h: Add utilities to get and release HDC.
1393         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
1394         * rendering/RenderThemeWin.cpp: Switch to new utilities.
1395
1396 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
1397
1398         Reviewed by anders
1399
1400         <rdar://problem/4426622>
1401         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
1402
1403         * editing/htmlediting.cpp:
1404         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
1405         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
1406         Got rid of uses of DepricatedString.
1407
1408 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1409
1410         Reviewed by eseidel.
1411
1412         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
1413
1414         * page/Frame.cpp:
1415         (WebCore::Frame::endIfNotLoading):
1416
1417 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1418
1419         Reviewed by eseidel.
1420
1421         Fix Qt/Linux build.
1422
1423         * CMakeLists.txt:
1424         * kcanvas/device/qt/KCanvasClipperQt.h:
1425         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1426         * platform/qt/FrameQt.cpp:
1427         (WebCore::FrameQt::isLoadTypeReload):
1428         (WebCore::FrameQt::originalRequestURL):
1429         * platform/qt/FrameQt.h:
1430         * platform/qt/GraphicsContextQt.cpp:
1431         (WebCore::GraphicsContext::concatCTM):
1432         * platform/qt/ScrollViewQt.cpp:
1433         (WebCore::ScrollView::wheelEvent):
1434         * platform/qt/TemporaryLinkStubs.cpp:
1435         (WebCore::IconDatabase::setIconURLForPageURL):
1436
1437 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
1438
1439         Reviewed by john
1440
1441         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
1442         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
1443
1444         * editing/MoveSelectionCommand.cpp:
1445         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
1446         to the position-to-move-to's document, not the fragment's document.  The
1447         fragment's document is the document used to create the fragment and is irrelavant.
1448
1449 === Safari-521.27 ===
1450
1451 2006-09-21  Brady Eidson  <beidson@apple.com>
1452
1453         Reviewed by Anders
1454
1455         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
1456         This fixes Spinneret so it won't crash on its first load!
1457
1458         * page/Frame.cpp:
1459         (WebCore::Frame::endIfNotLoading):
1460
1461 2006-09-21  Brady Eidson  <beidson@apple.com>
1462
1463         Build fix
1464
1465         * platform/win/TemporaryLinkStubs.cpp:
1466         (ScrollView::wheelEvent):
1467
1468 2006-09-20  Rob Buis  <buis@kde.org>
1469
1470         Reviewed by eseidel.
1471
1472         http://bugzilla.opendarwin.org/show_bug.cgi?id=10946
1473         new marker code draws end-marker in wrong place
1474
1475         Keep track of the start of the subpath so we can handle
1476         closeTo/moveTo correctly.
1477
1478         * kcanvas/RenderPath.cpp:
1479         (WebCore::DrawMarkersData::DrawMarkersData):
1480         (WebCore::updateMarkerDataForElement):
1481
1482 2006-09-21  David Hyatt <hyatt@apple.com>
1483
1484         Wheel scrolling prep for Win32.
1485
1486         WARNING: NO TEST CASES ADDED OR CHANGED
1487
1488         * platform/PlatformWheelEvent.h:
1489         * platform/ScrollBar.h:
1490         * platform/ScrollView.h:
1491         * platform/mac/ScrollViewMac.mm:
1492         (WebCore::ScrollView::wheelEvent):
1493         * rendering/RenderLayer.cpp:
1494
1495 2006-09-20  Timothy Hatcher  <timothy@apple.com>
1496
1497         Reviewed by Hyatt.
1498
1499         Bug 10917: REGRESSION (r16027): iFrame transparency broken
1500         http://bugzilla.opendarwin.org/show_bug.cgi?id=10917
1501
1502         Don't paint the base background color if we transparent.
1503
1504         * rendering/RenderBox.cpp:
1505         (WebCore::RenderBox::paintBackgroundExtended):
1506
1507 2006-09-20  Adam Roben  <aroben@apple.com>
1508
1509         Reviewed by andersca.
1510
1511         * platform/FileChooser.h: Remove no-longer-necessary namespace std
1512
1513 2006-09-20  Eric Seidel  <eric@eseidel.com>
1514
1515         Reviewed by beth.
1516
1517         Cleanup style in KCanvas.
1518         Remove extra white-space, unneeded arguments, etc.
1519
1520         * WebCore.xcodeproj/project.pbxproj:
1521         * kcanvas/KCanvasClipper.cpp:
1522         (WebCore::operator<<):
1523         (WebCore::KCanvasClipper::externalRepresentation):
1524         * kcanvas/KCanvasClipper.h:
1525         * kcanvas/KCanvasFilters.cpp:
1526         (WebCore::KCanvasFilter::externalRepresentation):
1527         (WebCore::operator<<):
1528         (WebCore::KCanvasFilterEffect::externalRepresentation):
1529         (WebCore::KCPointLightSource::externalRepresentation):
1530         (WebCore::KCSpotLightSource::externalRepresentation):
1531         (WebCore::KCDistantLightSource::externalRepresentation):
1532         (WebCore::KCanvasFEBlend::externalRepresentation):
1533         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
1534         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
1535         (WebCore::KCanvasFEComposite::externalRepresentation):
1536         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
1537         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
1538         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
1539         (WebCore::KCanvasFEFlood::externalRepresentation):
1540         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
1541         (WebCore::KCanvasFEImage::externalRepresentation):
1542         (WebCore::KCanvasFEMerge::externalRepresentation):
1543         (WebCore::KCanvasFEMorphology::externalRepresentation):
1544         (WebCore::KCanvasFEOffset::externalRepresentation):
1545         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
1546         (WebCore::KCanvasFETile::externalRepresentation):
1547         (WebCore::KCanvasFETurbulence::externalRepresentation):
1548         * kcanvas/KCanvasFilters.h:
1549         (WebCore::KCanvasFEDiffuseLighting::lightSource):
1550         (WebCore::KCanvasFESpecularLighting::lightSource):
1551         * kcanvas/KCanvasImage.h:
1552         * kcanvas/KCanvasMarker.cpp:
1553         (WebCore::KCanvasMarker::externalRepresentation):
1554         * kcanvas/KCanvasMarker.h:
1555         * kcanvas/KCanvasResource.cpp:
1556         (WebCore::operator<<):
1557         * kcanvas/KCanvasResource.h:
1558         * kcanvas/KCanvasTreeDebug.cpp:
1559         (WebCore::operator<<):
1560         (WebCore::writeIndent):
1561         (WebCore::writeStyle):
1562         (WebCore::write):
1563         (WebCore::writeRenderResources):
1564         * kcanvas/KCanvasTreeDebug.h:
1565         (WebCore::operator<<):
1566         * kcanvas/RenderForeignObject.cpp:
1567         (WebCore::RenderForeignObject::paint):
1568         * kcanvas/RenderPath.cpp:
1569         (WebCore::RenderPath::paint):
1570         (WebCore::drawStartAndMidMarkers):
1571         * kcanvas/RenderSVGContainer.cpp:
1572         (WebCore::RenderSVGContainer::paint):
1573         * kcanvas/RenderSVGImage.cpp:
1574         (WebCore::RenderSVGImage::translateForAttributes):
1575         * kcanvas/RenderSVGImage.h:
1576         * kcanvas/device/KRenderingDevice.cpp:
1577         (WebCore::KRenderingDevice::currentContext):
1578         (WebCore::KRenderingDevice::popContext):
1579         (WebCore::KRenderingDevice::pushContext):
1580         * kcanvas/device/KRenderingDevice.h:
1581         * kcanvas/device/KRenderingFillPainter.h:
1582         * kcanvas/device/KRenderingPaintServer.h:
1583         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1584         (WebCore::KRenderingPaintServer::activeClient):
1585         (WebCore::KRenderingPaintServer::setActiveClient):
1586         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1587         (WebCore::operator<<):
1588         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
1589         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
1590         (WebCore::KRenderingPaintServerGradient::listener):
1591         (WebCore::KRenderingPaintServerGradient::setListener):
1592         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
1593         * kcanvas/device/KRenderingPaintServerGradient.h:
1594         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1595         (WebCore::KRenderingPaintServerPattern::tile):
1596         (WebCore::KRenderingPaintServerPattern::setTile):
1597         (WebCore::KRenderingPaintServerPattern::listener):
1598         (WebCore::KRenderingPaintServerPattern::setListener):
1599         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
1600         * kcanvas/device/KRenderingPaintServerPattern.h:
1601         * kcanvas/device/KRenderingPaintServerSolid.cpp:
1602         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
1603         * kcanvas/device/KRenderingPaintServerSolid.h:
1604         * kcanvas/device/KRenderingStrokePainter.cpp:
1605         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
1606         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
1607         * kcanvas/device/KRenderingStrokePainter.h:
1608         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
1609         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1610         (WebCore::KCanvasFilterQuartz::prepareFilter):
1611         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
1612         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1613         (WebCore::KCanvasMaskerQuartz::applyMask):
1614         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1615         (WebCore::KCanvasImageQuartz::init):
1616         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1617         (WebCore::KCanvasClipperQuartz::applyClip):
1618         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1619         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1620         (WebCore::KRenderingDeviceQuartz::quartzContext):
1621         (WebCore::KRenderingDeviceQuartz::contextForImage):
1622         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1623         (WebCore::KRenderingDeviceQuartz::createResource):
1624         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
1625         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1626         (WebCore::CGShadingRefForLinearGradient):
1627         (WebCore::CGShadingRefForRadialGradient):
1628         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
1629         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1630         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1631         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1632         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
1633         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
1634         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
1635         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
1636         (WebCore::KRenderingPaintServerSolidQuartz::draw):
1637         (WebCore::KRenderingPaintServerSolidQuartz::setup):
1638         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
1639         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1640         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
1641         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
1642         * kcanvas/device/quartz/QuartzSupport.h:
1643         * kcanvas/device/quartz/QuartzSupport.mm:
1644         (WebCore::applyStrokeStyleToContext):
1645
1646 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1647
1648         Reviewed by Dave Hyatt.
1649
1650         * dom/WheelEvent.cpp:
1651         (WebCore::WheelEvent::WheelEvent):
1652         Use lroundf instead of lround since deltas are floats.
1653
1654 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
1655
1656         Reviewed by eseidel.  Landed by eseidel.
1657
1658         Test: svg/custom/pattern-y-offset.svg
1659
1660         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1661         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1662
1663 2006-09-20  David Hyatt  <hyatt@apple.com>
1664
1665         Add a new wheelEvent method to ScrollView.  Platforms that wish
1666         to handle the wheel event for the scroll view themselves can then
1667         do so there.  (Mac lets the underlying NSScrollView do it for now.)
1668
1669         * page/FrameView.cpp:
1670         (WebCore::FrameView::handleWheelEvent):
1671         * platform/ScrollView.h:
1672         (WebCore::ScrollView::wheelEvent):
1673
1674 2006-09-20  Brady Eidson  <beidson@apple.com>
1675
1676         Reviewed by Tim Omernick
1677
1678         Part of fixing a crash Tim O showed me that I missed in a release build.
1679         WebKit should be able to call through the bridge to WebCore no matter what -
1680         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
1681
1682         * bridge/mac/WebCoreIconDatabaseBridge.h:
1683         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1684         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
1685         (-[WebCoreIconDatabaseBridge isOpen]):
1686         (-[WebCoreIconDatabaseBridge removeAllIcons]):
1687         (-[WebCoreIconDatabaseBridge _isEmpty]):
1688         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
1689         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
1690         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
1691         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
1692         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
1693         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
1694         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
1695         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
1696         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
1697         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
1698         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
1699         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
1700         (-[WebCoreIconDatabaseBridge _setEnabled:]):
1701         (-[WebCoreIconDatabaseBridge _isEnabled]):
1702
1703 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1704
1705         Reviewed by Darin.
1706
1707         Add String::split which returns a Vector of Strings and use it instead of
1708         DeprecatedStringList.
1709
1710         * bindings/js/kjs_events.cpp:
1711         (KJS::Clipboard::getValueProperty):
1712         * bindings/js/kjs_window.cpp:
1713         (KJS::parseModalDialogFeatures):
1714         * css/MediaList.cpp:
1715         (WebCore::MediaList::setMediaText):
1716         * dom/Clipboard.h:
1717         * html/HTMLFormElement.cpp:
1718         (WebCore::HTMLFormElement::formData):
1719         * html/HTMLLinkElement.cpp:
1720         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
1721         * platform/PlatformString.h:
1722         * platform/String.cpp:
1723         (WebCore::String::split):
1724         * platform/StringImpl.cpp:
1725         * platform/StringImpl.h:
1726         * platform/mac/ClipboardMac.h:
1727         * platform/mac/ClipboardMac.mm:
1728         (WebCore::ClipboardMac::types):
1729
1730 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
1731
1732         Reviewed by harrison
1733
1734         * css/cssstyleselector.cpp:
1735         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
1736         HTMLElement::isContentEditable just to check the Frame's editability, since
1737         it calls updateRenderering, which can get us into infinite recursion.
1738
1739 2006-09-20  Brady Eidson  <beidson@apple.com>
1740
1741         Reviewed by Darin
1742
1743         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
1744
1745         * loader/icon/IconDatabase.cpp:
1746         (WebCore::IconDatabase::IconDatabase): Disabled by default
1747         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
1748         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
1749         (WebCore::IconDatabase::iconForPageURL): Ditto
1750         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
1751         (WebCore::IconDatabase::iconURLForPageURL): Ditto
1752         (WebCore::IconDatabase::retainIconForPageURL): Ditto
1753         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
1754         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
1755         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
1756         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
1757         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
1758
1759 2006-09-20  Adam Roben  <aroben@apple.com>
1760
1761         Reviewed by Adele.
1762
1763         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
1764         REGRESSION: file upload control with direction:rtl or text-align:right
1765         draws button on top of filename/icon
1766
1767         * rendering/RenderFileUploadControl.cpp:
1768         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
1769         match direction
1770         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
1771         the filename and icon in RTL
1772
1773 2006-09-20  Alice Liu  <alice.liu@apple.com>
1774
1775         Reviewed by Adam Roben.
1776
1777         fixed windows build
1778
1779         * dom/WheelEvent.cpp:
1780         (WebCore::WheelEvent::WheelEvent):
1781         changed lrint to lround
1782
1783 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
1784
1785         Build Fix.  Adds isHorizontal attribute back to WheelEvent
1786         for the Objective-C bindings.  If it is found that isHorizontal
1787         is not used, we should remove it again but also remove it's
1788         declaration from PublicDOMInterfaces.h
1789
1790         * dom/WheelEvent.h:
1791         (WebCore::WheelEvent::isHorizontal):
1792         * dom/WheelEvent.idl:
1793
1794 2006-09-20  David Hyatt  <hyatt@apple.com>
1795
1796         Fix for 10945, WheelEvent should support two dimensions at once, since
1797         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
1798         to allow for diagonal scrolling.
1799
1800         Reviewed by Eric
1801
1802         * dom/EventTargetNode.cpp:
1803         (WebCore::EventTargetNode::dispatchWheelEvent):
1804         * dom/WheelEvent.cpp:
1805         (WebCore::WheelEvent::WheelEvent):
1806         (WebCore::WheelEvent::initWheelEvent):
1807         * dom/WheelEvent.h:
1808         (WebCore::WheelEvent::wheelDelta):
1809         (WebCore::WheelEvent::wheelDeltaX):
1810         (WebCore::WheelEvent::wheelDeltaY):
1811         * dom/WheelEvent.idl:
1812         * page/FrameView.cpp:
1813         (WebCore::FrameView::handleWheelEvent):
1814         * platform/PlatformWheelEvent.h:
1815         (WebCore::PlatformWheelEvent::deltaX):
1816         (WebCore::PlatformWheelEvent::deltaY):
1817         (WebCore::PlatformWheelEvent::normalize):
1818         * platform/mac/WheelEventMac.mm:
1819         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1820
1821 2006-09-19  Eric Seidel  <eric@eseidel.com>
1822
1823         Reviewed by hyatt.
1824
1825         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
1826
1827         No tests were harmed in the making of this patch.
1828
1829         * WebCore.xcodeproj/project.pbxproj:
1830         * kcanvas/KCanvasClipper.cpp: Added.
1831         (WebCore::operator<<):
1832         * kcanvas/KCanvasClipper.h: Added.
1833         * kcanvas/KCanvasFilters.h:
1834         * kcanvas/KCanvasImage.h:
1835         * kcanvas/KCanvasMarker.cpp: Added.
1836         * kcanvas/KCanvasMarker.h: Added.
1837         * kcanvas/KCanvasMasker.cpp: Added.
1838         (WebCore::KCanvasMasker::KCanvasMasker):
1839         (WebCore::KCanvasMasker::setMask):
1840         (WebCore::KCanvasMasker::externalRepresentation):
1841         (WebCore::getMaskerById):
1842         * kcanvas/KCanvasMasker.h: Added.
1843         * kcanvas/KCanvasResource.cpp: Added.
1844         (WebCore::KCanvasResource::invalidate):
1845         (WebCore::KCanvasResource::externalRepresentation):
1846         (WebCore::getResourceById):
1847         (WebCore::getPaintServerById):
1848         * kcanvas/KCanvasResource.h: Added.
1849         * kcanvas/KCanvasResources.cpp: Removed.
1850         * kcanvas/KCanvasResources.h: Removed.
1851         * kcanvas/RenderPath.cpp:
1852         * kcanvas/RenderSVGContainer.cpp:
1853         * kcanvas/RenderSVGImage.cpp:
1854         * kcanvas/RenderSVGText.cpp:
1855         * kcanvas/device/KRenderingPaintServer.h:
1856         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1857         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1858         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1859         * ksvg2/svg/SVGClipPathElement.h:
1860         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1861         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
1862         * ksvg2/svg/SVGFECompositeElement.cpp:
1863         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1864         * ksvg2/svg/SVGFELightElement.cpp:
1865         * ksvg2/svg/SVGFEOffsetElement.cpp:
1866         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1867         * ksvg2/svg/SVGFilterElement.cpp:
1868         * ksvg2/svg/SVGLinearGradientElement.cpp:
1869         * ksvg2/svg/SVGMarkerElement.h:
1870         * ksvg2/svg/SVGMaskElement.h:
1871
1872 2006-09-19  Brady Eidson <beidson@apple.com>
1873
1874         Reviewed by Sarge Decker
1875
1876         <rdar://problem/4739892> and <rdar://problem/4729797>
1877         - WebCore::IconDatabase needs to have and respect an enabled() flag
1878         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
1879
1880         * bridge/mac/WebCoreIconDatabaseBridge.h:
1881         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1882         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
1883         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
1884         * loader/icon/IconDatabase.cpp:
1885         (WebCore::IconDatabase::IconDatabase):
1886         (WebCore::IconDatabase::open): Don't open if disabled
1887         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
1888         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
1889         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
1890         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
1891         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
1892         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
1893         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
1894         (WebCore::IconDatabase::releaseIconURL):
1895         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
1896         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
1897         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
1898         (WebCore::IconDatabase::setEnabled): Added
1899         * loader/icon/IconDatabase.h:
1900         (WebCore::IconDatabase::enabled): Added
1901         * page/Frame.cpp:
1902         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
1903         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
1904
1905 2006-09-20  David Hyatt  <hyatt@apple.com>
1906
1907         Massage mouse wheel handling so that it is more cross-platform.  Make
1908         all the work happen in handleWheelEvent on the FrameView.
1909
1910         Reviewed by bradee-oh
1911
1912         * bridge/mac/FrameMac.mm:
1913         (WebCore::FrameMac::wheelEvent):
1914         * page/FrameView.cpp:
1915         (WebCore::FrameView::handleWheelEvent):
1916         * platform/PlatformWheelEvent.h:
1917         (WebCore::PlatformWheelEvent::platformDelta):
1918         (WebCore::PlatformWheelEvent::delta):
1919         * platform/mac/WheelEventMac.mm:
1920         (WebCore::platformDeltaForEvent):
1921         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1922         * rendering/RenderLayer.cpp:
1923         (WebCore::RenderLayer::scroll):
1924         * rendering/RenderObject.cpp:
1925         (WebCore::RenderObject::scroll):
1926
1927 2006-09-19  Eric Seidel  <eric@eseidel.com>
1928
1929         Reviewed by adele.
1930
1931         Improve test output for filters with bounding-box relative sizes.
1932         http://bugzilla.opendarwin.org/show_bug.cgi?id=8585
1933
1934         Many test results updated.
1935
1936         * kcanvas/KCanvasFilters.cpp:
1937         (WebCore::KCanvasFilter::externalRepresentation):
1938
1939 2006-09-19  Eric Seidel  <eric@eseidel.com>
1940
1941         Reviewed by adele.
1942
1943         Markers should clip to their viewport.
1944         http://bugzilla.opendarwin.org/show_bug.cgi?id=5967
1945
1946         Test: svg/custom/marker-overflow-clip.svg
1947
1948         * kcanvas/KCanvasResources.cpp:
1949         (WebCore::KCanvasMarker::KCanvasMarker):
1950         (WebCore::KCanvasMarker::setMarker):
1951         (WebCore::KCanvasMarker::draw):
1952         * kcanvas/KCanvasResources.h:
1953         (WebCore::KCanvasMasker::mask):
1954         * ksvg2/svg/SVGMarkerElement.cpp:
1955         (WebCore::SVGMarkerElement::SVGMarkerElement):
1956         (WebCore::SVGMarkerElement::parseMappedAttribute):
1957         (WebCore::SVGMarkerElement::canvasResource):
1958         (WebCore::SVGMarkerElement::createRenderer):
1959
1960 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1961
1962         Reviewed by eseidel
1963
1964         Backing out my recent change.
1965
1966         * css/cssstyleselector.cpp:
1967         (WebCore::CSSStyleSelector::adjustRenderStyle):
1968
1969 2006-09-19  Brady Eidson  <beidson@apple.com>
1970
1971         Reviewed by Kevin McCullough
1972
1973         http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
1974         Opening a PDF in a new tab/window creates a documentless-frame
1975         and we deref the document without checking its validity
1976
1977         * page/Frame.cpp:
1978         (WebCore::Frame::iconURL):
1979
1980 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1981
1982         Reviewed by harrison
1983
1984         <rdar://problem/4735272>
1985         Can not click into link in programmatically editable content
1986
1987         * css/cssstyleselector.cpp:
1988         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
1989         userModify to implement document wide editability.
1990
1991 2006-09-19  MorganL  <morlmor@yahoo.com>
1992
1993         Reviewed by Darin and landed by Brady
1994
1995         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10939
1996         Build broken when SVG is not enabled.
1997
1998         * dom/XMLTokenizer.cpp:
1999         (WebCore::XMLTokenizer::startElementNs):
2000
2001 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2002
2003         Reviewed by harrison
2004
2005         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
2006
2007         Pasting plain text results in a match style paste, and the insertion
2008         position is whitespace normal, which clobbers the whitespace:pre on
2009         tab spans.  Skip changes to the whitespace mode when computing a style
2010         change for tab spans or the text nodes inside tab spans.
2011
2012         * editing/ApplyStyleCommand.cpp:
2013         (WebCore::StyleChange::init): Don't change the whitespace mode inside
2014         tab spans.
2015
2016 2006-09-19  David Hyatt  <hyatt@apple.com>
2017
2018         Fix for bug 5298, shape=default not supported for image maps.  Implement
2019         support for it.
2020
2021         Reviewed by timo
2022
2023         * html/HTMLAreaElement.cpp:
2024         (WebCore::HTMLAreaElement::getRegion):
2025         * html/HTMLMapElement.cpp:
2026         (WebCore::HTMLMapElement::mapMouseEvent):
2027
2028 2006-09-19  Adam Roben  <aroben@apple.com>
2029
2030         Reviewed by Adele.
2031
2032         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10824
2033         "no file selected" placeholder text missing from file upload control
2034
2035         * WebCore.xcodeproj/project.pbxproj:
2036         * rendering/RenderFileUploadControl.cpp: Remove class
2037         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
2038         defaultWidthNumChars
2039         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
2040         RenderBlock constructor instead of RenderFlexibleBox,
2041         (WebCore::RenderFileUploadControl::setStyle): Remove references to
2042         m_fileBox.
2043         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
2044         instead of updateIconAndFileName() (which has been removed)
2045         (WebCore::RenderFileUploadControl::updateFromElement): Remove
2046         references to m_fileBox, don't call updateIconAndFilename()
2047         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
2048         without using m_fileBox
2049         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
2050         now-unnecessary display:box rule.
2051         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
2052         to paintingDisabled() now that Icon::paint() does it, and add code to
2053         paint the filename directly.
2054         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
2055         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
2056         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
2057         subclass of RenderBlock instead of RenderFlexibleBox, remove
2058         updateIconAndFilename() method, remove m_fileBox instance variable.
2059
2060 2006-09-19  Eric Seidel  <eric@eseidel.com>
2061
2062         Reviewed by hyatt.
2063
2064         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
2065         http://bugzilla.opendarwin.org/show_bug.cgi?id=10846
2066
2067         No automated test case possible until http://bugzilla.opendarwin.org/show_bug.cgi?id=10905 is resolved.
2068
2069         * dom/XMLTokenizer.cpp:
2070         (WebCore::XMLTokenizer::XMLTokenizer):
2071         (WebCore::XMLTokenizer::startElementNs):
2072         (WebCore::XMLTokenizer::endElementNs):
2073
2074 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
2075
2076         Reviewed by eseidel.  Landed by eseidel.
2077
2078         Build fix only, no tests affected.
2079
2080         * platform/gdk/FontPlatformDataGdk.cpp:
2081         (WebCore::FontPlatformData::FontPlatformData):
2082         (WebCore::FontPlatformData::~FontPlatformData):
2083         * platform/gdk/FrameGdk.h:
2084         * platform/gdk/TemporaryLinkStubs.cpp:
2085         (FrameGdk::isLoadTypeReload):
2086         (FrameGdk::originalRequestURL):
2087         (IconDatabase::setIconURLForPageURL):
2088
2089 2006-09-19  David Hyatt  <hyatt@apple.com>
2090
2091         Refine the fix for 9805 to really get all the complex cases right.
2092
2093         Reviewed by Eric
2094
2095         * rendering/RenderBlock.cpp:
2096         (WebCore::RenderBlock::clearFloatsIfNeeded):
2097         (WebCore::RenderBlock::handleBottomOfBlock):
2098
2099 2006-09-18  David Hyatt  <hyatt@apple.com>
2100
2101         Fix for 9805, <hr> not positioned properly following a previous empty sibling
2102         that had clear:both set on it.  Update self-collapsing block clearance
2103         behavior to match what is specified in the latest draft of CSS2.1.
2104
2105         Reviewed by Eric
2106
2107         Added fast/block/margin-collapse/empty-clear-blocks.html
2108
2109         * rendering/RenderBlock.cpp:
2110         (WebCore::RenderBlock::clearFloatsIfNeeded):
2111         (WebCore::RenderBlock::handleBottomOfBlock):
2112
2113 2006-09-18  MorganL  <morlmor@yahoo.com>
2114
2115         Reviewed by Brady, landed by Brady
2116
2117         Send receivedResponse callback to ResourceLoaderClient when loading
2118         file URLs.
2119
2120         See http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
2121
2122         * platform/win/ResourceLoaderWin.cpp:
2123         (WebCore::ResourceLoader::fileLoadTimer):
2124
2125 2006-09-18  Brady Eidson  <beidson@apple.com>
2126
2127         Reviewed by Anders
2128
2129         <rdar://problem/3028061> - WebKit never updates favicon
2130         The WebKit enforced expiration date for icons has worked for some time, but the
2131         move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
2132         functionality.  This patch fixes that up, along with some other architectural improvements,
2133         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
2134
2135         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
2136         * bridge/mac/FrameMac.mm:
2137         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
2138         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
2139         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
2140         * dom/Document.h: Added m_iconURL
2141         (WebCore::Document::iconURL): Added
2142         (WebCore::Document::setIconURL): Ditto
2143         * html/HTMLLinkElement.cpp:
2144         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
2145         * page/Frame.cpp:
2146         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
2147         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
2148         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
2149         * page/FramePrivate.h: Nuked IconURL
2150         * platform/win/TemporaryLinkStubs.cpp:
2151         (FrameWin::isLoadTypeReload):
2152
2153 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2154
2155         Reviewed by Tim H.
2156
2157         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
2158           it is it turns out that AppKit uses it.
2159
2160         * bindings/objc/DOMPrivate.h:
2161         * bindings/objc/DOMRGBColor.mm:
2162         (-[DOMRGBColor _color]):
2163
2164 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2165
2166         Reviewed by Tim H.
2167
2168         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
2169         Yet Another Objective-C Bindings Patch
2170
2171         - Whitespace cleanup for IDLParser.pm
2172
2173         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
2174           and DOMAbstractView into their own files.
2175
2176         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
2177           it is not used and a public method is available now.
2178
2179         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
2180           as it not used.
2181
2182         - Auto-generate method isContentEditable for DOMNode.
2183
2184         - General cleanup of bindings code including removing unneeded #imports
2185           and whitespace cleanup
2186
2187         * WebCore.xcodeproj/project.pbxproj:
2188         * bindings/objc/DOM.mm:
2189         (addElementClass):
2190         (elementClass):
2191         (-[DOMNode _initWithNode:WebCore::]):
2192         (+[DOMNode _nodeWith:WebCore::]):
2193         (-[DOMNode WebCore::]):
2194         (-[DOMNode KJS::Bindings::]):
2195         (-[DOMNode addEventListener:::]):
2196         (-[DOMNode removeEventListener:::]):
2197         (-[DOMNode dispatchEvent:]):
2198         (-[DOMElement image]):
2199         (-[DOMElement _font]):
2200         (-[DOMElement _imageTIFFRepresentation]):
2201         (-[DOMElement _getURLAttribute:]):
2202         (-[DOMElement _NPObject]):
2203         (-[DOMElement isFocused]):
2204         (-[DOMRange dealloc]):
2205         (-[DOMRange finalize]):
2206         (-[DOMRange description]):
2207         (-[DOMRange startContainer]):
2208         (-[DOMRange startOffset]):
2209         (-[DOMRange endContainer]):
2210         (-[DOMRange endOffset]):
2211         (-[DOMRange collapsed]):
2212         (-[DOMRange commonAncestorContainer]):
2213         (-[DOMRange setStart::]):
2214         (-[DOMRange setEnd::]):
2215         (-[DOMRange setStartBefore:]):
2216         (-[DOMRange setStartAfter:]):
2217         (-[DOMRange setEndBefore:]):
2218         (-[DOMRange setEndAfter:]):
2219         (-[DOMRange collapse:]):
2220         (-[DOMRange selectNode:]):
2221         (-[DOMRange selectNodeContents:]):
2222         (-[DOMRange compareBoundaryPoints::]):
2223         (-[DOMRange deleteContents]):
2224         (-[DOMRange extractContents]):
2225         (-[DOMRange cloneContents]):
2226         (-[DOMRange insertNode:]):
2227         (-[DOMRange surroundContents:]):
2228         (-[DOMRange cloneRange]):
2229         (-[DOMRange toString]):
2230         (-[DOMRange detach]):
2231         (-[DOMRange _initWithRange:WebCore::]):
2232         (+[DOMRange _rangeWith:WebCore::]):
2233         (-[DOMRange WebCore::]):
2234         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
2235         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
2236         (-[DOMNodeFilter WebCore::]):
2237         (-[DOMNodeFilter dealloc]):
2238         (-[DOMNodeFilter finalize]):
2239         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
2240         (-[DOMNodeIterator WebCore::]):
2241         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
2242         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
2243         (-[DOMTreeWalker WebCore::]):
2244         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
2245         (ObjCNodeFilterCondition::acceptNode):
2246         (-[DOMDocument createNodeIterator::::]):
2247         (-[DOMDocument createTreeWalker::::]):
2248         (ObjCEventListener::find):
2249         (ObjCEventListener::create):
2250         (ObjCEventListener::handleEvent):
2251         * bindings/objc/DOMAbstractView.h: Added.
2252         * bindings/objc/DOMAbstractView.mm: Added.
2253         (-[DOMAbstractView document]):
2254         (-[DOMAbstractView WebCore::]):
2255         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
2256         (+[DOMAbstractView _abstractViewWith:WebCore::]):
2257         * bindings/objc/DOMCSS.mm:
2258         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2259         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
2260         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
2261         (-[DOMCSSRule _initWithRule:WebCore::]):
2262         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
2263         (-[DOMCSSValue _initWithValue:WebCore::]):
2264         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2265         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
2266         (-[DOMDocument getComputedStyle::]):
2267         (-[DOMDocument getMatchedCSSRules::]):
2268         * bindings/objc/DOMCore.h:
2269         * bindings/objc/DOMEventException.h: Added.
2270         * bindings/objc/DOMEvents.h:
2271         * bindings/objc/DOMEvents.mm:
2272         * bindings/objc/DOMException.h: Added.
2273         * bindings/objc/DOMHTML.mm:
2274         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
2275         (viewForElement):
2276         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
2277         (-[DOMHTMLInputElement _selectedRange]):
2278         (-[DOMHTMLInputElement _setAutofilled:]):
2279         * bindings/objc/DOMInternal.h:
2280         * bindings/objc/DOMObject.h:
2281         * bindings/objc/DOMPrivate.h:
2282         * bindings/objc/DOMRange.h:
2283         * bindings/objc/DOMRangeException.h: Added.
2284         * bindings/objc/DOMViews.h:
2285         * bindings/objc/DOMViews.mm: Removed.
2286         * bindings/objc/DOMXPath.h:
2287         * bindings/objc/DOMXPathException.h: Added.
2288         * bindings/scripts/IDLParser.pm:
2289         * dom/Node.idl:
2290
2291 2006-09-18  Brady Eidson  <beidson@apple.com>
2292
2293         Windows build fix
2294
2295         * platform/win/TemporaryLinkStubs.cpp:
2296         (IconDatabase::setIconURLForPageURL):
2297
2298 2006-09-18  David Hyatt  <hyatt@apple.com>
2299
2300         Fix for bug 3969, hr width doesn't update when it clears a float.  This
2301         was also a problem with tables and overflow sections.
2302
2303         Reviewed by Eric
2304
2305         Added fast/block/float/width-update-after-clear.html
2306
2307         * rendering/RenderBlock.cpp:
2308         (WebCore::RenderBlock::collapseMargins):
2309         (WebCore::RenderBlock::clearFloatsIfNeeded):
2310
2311 2006-09-18  Brady Eidson  <beidson@apple.com>
2312
2313         Reviewed by John
2314
2315         http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
2316         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
2317
2318         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
2319         * bridge/win/FrameWin.h: Added originalRequestURL()
2320         * loader/icon/IconLoader.cpp:
2321         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
2322         * page/Frame.cpp:
2323         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
2324         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
2325         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
2326         * page/Frame.h: Added pure virtual originalRequestURL()
2327         * platform/win/TemporaryLinkStubs.cpp:
2328         (FrameWin::originalRequestURL): Added
2329
2330 2006-09-18  Rob Buis  <buis@kde.org>
2331
2332         Reviewed by Maciej.
2333
2334         http://bugzilla.opendarwin.org/show_bug.cgi?id=10807
2335         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
2336
2337         Make sure the paint method is not exited without popping
2338         context and transparency layer.
2339
2340         WARNING: NO TEST CASES ADDED OR CHANGED
2341
2342         * kcanvas/RenderSVGImage.cpp:
2343         (WebCore::RenderSVGImage::paint):
2344
2345 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
2346
2347         Reviewed by Eric.
2348
2349         - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10896
2350         REGRESSION: WebKit can't be built with SVG disabled
2351
2352         * bindings/scripts/CodeGeneratorObjC.pm:
2353         For each file generated add a #ifdef <something>_SUPPORT / #endif
2354         pair if the idl file has a Conditional extended attribute
2355
2356 2006-09-17  Eric Seidel  <eric@eseidel.com>
2357
2358         Reviewed by ap.
2359
2360         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
2361         http://bugzilla.opendarwin.org/show_bug.cgi?id=10813
2362
2363         * bridge/mac/WebCoreFrameBridge.mm:
2364         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
2365
2366 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
2367
2368         Reviewed by Hyatt.
2369
2370         http://bugzilla.opendarwin.org/show_bug.cgi?id=10779
2371         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
2372
2373         No test possible.
2374
2375         * platform/Image.cpp:
2376         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
2377         maybe the rest just hasn't been loaded yet.
2378         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
2379         to start animating before we get at least two frames.
2380
2381 2006-09-17  Brady Eidson <beidson@apple.com>
2382
2383         Reviewed by Sarge
2384
2385         IconLoader now gracefully handles the condition where there's no document in the frame
2386         (ie. PDFs)
2387
2388         * loader/icon/IconLoader.cpp:
2389         (IconLoader::startLoading):
2390
2391 2006-09-17  David Hyatt  <hyatt@apple.com>
2392
2393         Fix for bug 10899, rework how CSS keywords work to be smarter about
2394         using the correct size when generic families change (e.g., monospace to
2395         serif and vice versa).
2396
2397         Reviewed by aroben
2398
2399         Added fast/text/basic/generic-family-changes.html
2400
2401         * css/cssstyleselector.cpp:
2402         (WebCore::CSSStyleSelector::applyProperty):
2403         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
2404         (WebCore::CSSStyleSelector::fontSizeForKeyword):
2405         * css/cssstyleselector.h:
2406         * dom/Document.cpp:
2407         (WebCore::Document::recalcStyle):
2408         * platform/FontDescription.h:
2409         (WebCore::FontDescription::FontDescription):
2410         (WebCore::FontDescription::keywordSize):
2411         (WebCore::FontDescription::setKeywordSize):
2412         (WebCore::FontDescription::operator==):
2413
2414 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
2415
2416         Reviewed by Brady.
2417
2418         http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
2419         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
2420
2421         Test: http/tests/xmlhttprequest/xhr-onunload.html
2422
2423         * xml/xmlhttprequest.cpp:
2424         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
2425
2426         * loader/icon/IconLoader.cpp:
2427         (IconLoader::startLoading): Fix a similar latent bug here.
2428
2429 2006-09-17  Adam Roben  <aroben@apple.com>
2430
2431         Build fix.
2432
2433         * loader/icon/IconDatabase.cpp:
2434
2435 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
2436
2437         Reviewed by Brady.
2438
2439         Add simplifyWhiteSpace and stripWhiteSpace to the String class.
2440         Change the XSLT Parameter Map to use Strings instead of StringImpls.
2441         General cleanup.
2442
2443         * bindings/js/JSXSLTProcessor.cpp:
2444         (KJS::XSLTProcessorProtoFunc::callAsFunction):
2445         * bindings/js/kjs_events.cpp:
2446         (KJS::JSAbstractEventListener::handleEvent):
2447         * bindings/js/kjs_window.cpp:
2448         (KJS::ScheduledAction::execute):
2449         * css/MediaList.cpp:
2450         (WebCore::MediaList::setMediaText):
2451         * dom/Document.cpp:
2452         (WebCore::Document::processHttpEquiv):
2453         * editing/ApplyStyleCommand.cpp:
2454         (WebCore::StyleChange::init):
2455         * html/HTMLDocument.cpp:
2456         (WebCore::parseDocTypeDeclaration):
2457         * html/HTMLLinkElement.cpp:
2458         (WebCore::HTMLLinkElement::parseMappedAttribute):
2459         * html/HTMLObjectElement.cpp:
2460         (WebCore::HTMLObjectElement::HTMLObjectElement):
2461         (WebCore::HTMLObjectElement::parseMappedAttribute):
2462         (WebCore::HTMLObjectElement::attach):
2463         (WebCore::HTMLObjectElement::setComplete):
2464         (WebCore::HTMLObjectElement::detach):
2465         (WebCore::HTMLObjectElement::recalcStyle):
2466         (WebCore::HTMLObjectElement::childrenChanged):
2467         (WebCore::HTMLObjectElement::isImageType):
2468         * html/HTMLObjectElement.h:
2469         * html/HTMLOptionElement.cpp:
2470         (WebCore::HTMLOptionElement::value):
2471         * html/HTMLSelectElement.cpp:
2472         (WebCore::HTMLSelectElement::appendFormData):
2473         * html/HTMLTokenizer.cpp:
2474         (WebCore::HTMLTokenizer::parseTag):
2475         * ksvg2/svg/SVGColor.cpp:
2476         (WebCore::SVGColor::setRGBColor):
2477         * ksvg2/svg/SVGDescElement.cpp:
2478         (WebCore::SVGDescElement::description):
2479         * platform/PlatformString.h:
2480         * platform/String.cpp:
2481         (WebCore::String::stripWhiteSpace):
2482         (WebCore::String::simplifyWhiteSpace):
2483         * platform/StringImpl.cpp:
2484         (WebCore::isSpace):
2485         (WebCore::parseLength):
2486         (WebCore::StringImpl::stripWhiteSpace):
2487         (WebCore::StringImpl::simplifyWhiteSpace):
2488         (WebCore::StringImpl::toInt):
2489         * platform/StringImpl.h:
2490         * platform/mac/ClipboardMac.mm:
2491         (WebCore::cocoaTypeFromMIMEType):
2492         * rendering/RenderPartObject.cpp:
2493         (WebCore::RenderPartObject::updateWidget):
2494         * xml/XPathFunctions.cpp:
2495         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
2496         * xml/XPathGrammar.y:
2497         * xml/XPathStep.cpp:
2498         (WebCore::XPath::Step::nodeTestMatches):
2499         * xml/XSLStyleSheet.cpp:
2500         (WebCore::XSLStyleSheet::loadChildSheets):
2501         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
2502         * xml/XSLTProcessor.cpp:
2503         (WebCore::xsltParamArrayFromParameterMap):
2504         (WebCore::XSLTProcessor::setParameter):
2505         (WebCore::XSLTProcessor::getParameter):
2506         (WebCore::XSLTProcessor::removeParameter):
2507         * xml/XSLTProcessor.h:
2508         * xml/xmlhttprequest.cpp:
2509         (WebCore::XMLHttpRequest::getStatusText):
2510
2511 2006-09-17  David Hyatt  <hyatt@apple.com>
2512
2513         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
2514         are declared right before the fieldsets.  It turns out fieldsets in other
2515         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
2516         adding that behavior to fieldset fixes the bug.
2517
2518         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
2519         and fieldsets all subclass.
2520
2521         Reviewed by anders
2522
2523         Added fast/forms/float-before-fieldset.html
2524
2525         * rendering/RenderFieldset.h:
2526         (WebCore::RenderFieldset::avoidsFloats):
2527         * rendering/RenderFlexibleBox.h:
2528         (WebCore::RenderFlexibleBox::avoidsFloats):
2529         * rendering/RenderObject.cpp:
2530         (WebCore::RenderObject::avoidsFloats):
2531         * rendering/RenderObject.h:
2532         * rendering/RenderTable.h:
2533         (WebCore::RenderTable::avoidsFloats):
2534
2535 2006-09-17  David Hyatt  <hyatt@apple.com>
2536
2537         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
2538         "rules" attributes on tables.
2539
2540         Reviewed by bradee-oh
2541
2542         Well-covered by existing layout tests.
2543
2544         * html/HTMLTableCellElement.cpp:
2545         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
2546         * html/HTMLTableColElement.cpp:
2547         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
2548         * html/HTMLTableColElement.h:
2549         * html/HTMLTableElement.cpp:
2550         (WebCore::HTMLTableElement::HTMLTableElement):
2551         (WebCore::HTMLTableElement::~HTMLTableElement):
2552         (WebCore::HTMLTableElement::setCaption):
2553         (WebCore::HTMLTableElement::setTHead):
2554         (WebCore::HTMLTableElement::setTFoot):
2555         (WebCore::HTMLTableElement::setTBody):
2556         (WebCore::HTMLTableElement::createTHead):
2557         (WebCore::HTMLTableElement::deleteTHead):
2558         (WebCore::HTMLTableElement::createTFoot):
2559         (WebCore::HTMLTableElement::deleteTFoot):
2560         (WebCore::HTMLTableElement::createCaption):
2561         (WebCore::HTMLTableElement::deleteCaption):
2562         (WebCore::HTMLTableElement::insertRow):
2563         (WebCore::HTMLTableElement::deleteRow):
2564         (WebCore::HTMLTableElement::addChild):
2565         (WebCore::HTMLTableElement::childrenChanged):
2566         (WebCore::HTMLTableElement::mapToEntry):
2567         (WebCore::HTMLTableElement::parseMappedAttribute):
2568         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
2569         (WebCore::HTMLTableElement::getSharedCellDecl):
2570         (WebCore::HTMLTableElement::getSharedGroupDecl):
2571         (WebCore::HTMLTableElement::attach):
2572         * html/HTMLTableElement.h:
2573         (WebCore::HTMLTableElement::caption):
2574         (WebCore::HTMLTableElement::tHead):
2575         (WebCore::HTMLTableElement::tFoot):
2576         (WebCore::HTMLTableElement::):
2577         * html/HTMLTableRowElement.h:
2578         * html/HTMLTableSectionElement.cpp:
2579         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
2580         * html/HTMLTableSectionElement.h:
2581
2582 2006-09-17  David Hyatt  <hyatt@apple.com>
2583
2584         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
2585         specify their own new font-family list.  Make sure to always
2586         reset the generic family along with the family list when mapping in
2587         new font-family values.
2588
2589         Reviewed by bradee-oh
2590
2591         fast/text/basic/generic-family-reset.html
2592
2593         * css/cssstyleselector.cpp:
2594         (WebCore::CSSStyleSelector::applyProperty):
2595
2596 2006-09-16  Brady Eidson <beidson@apple.com>
2597
2598         Reviewed by Hyatt
2599
2600         Pruning code relating to WebKit's icon loader
2601
2602         * bridge/mac/WebCoreIconDatabaseBridge.h:
2603         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2604         * loader/icon/IconDatabase.h:
2605         * page/Frame.cpp:
2606         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to
2607         its new home
2608
2609 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
2610
2611         Reviewed by Tim H.
2612
2613         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10885
2614         Auto-generate DOMHTMLDocument for the Objective-C bindings
2615
2616         * DerivedSources.make:
2617         * WebCore.xcodeproj/project.pbxproj:
2618         * bindings/objc/DOMExtensions.h:
2619         * bindings/objc/DOMHTML.mm:
2620         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
2621         * bindings/objc/DOMHTMLDocument.h: Removed.
2622         * bindings/objc/DOMHTMLDocument.mm: Removed.
2623         * bindings/objc/PublicDOMInterfaces.h:
2624         * bindings/scripts/CodeGeneratorObjC.pm:
2625         * html/HTMLDocument.idl:
2626         * platform/DeprecatedString.h:
2627         (WebCore::DeprecatedString::operator NSString*):
2628
2629 2006-09-16  Rob Buis  <buis@kde.org>
2630
2631         Reviewed by Eric.
2632
2633         http://bugzilla.opendarwin.org/show_bug.cgi?id=10866
2634         Code in kcanvas/ should not use Private
2635
2636         Remove Private classes and tweak coding style.
2637
2638         WARNING: NO TEST CASES ADDED OR CHANGED
2639
2640         * kcanvas/RenderPath.cpp:
2641         (WebCore::RenderPath::RenderPath):
2642         (WebCore::RenderPath::~RenderPath):
2643         (WebCore::RenderPath::localTransform):
2644         (WebCore::RenderPath::setLocalTransform):
2645         (WebCore::RenderPath::fillContains):
2646         (WebCore::RenderPath::relativeBBox):
2647         (WebCore::RenderPath::setPath):
2648         (WebCore::RenderPath::path):
2649         (WebCore::RenderPath::layout):
2650         * kcanvas/RenderPath.h:
2651         * kcanvas/RenderSVGContainer.cpp:
2652         (WebCore::RenderSVGContainer::RenderSVGContainer):
2653         (WebCore::RenderSVGContainer::~RenderSVGContainer):
2654         (WebCore::RenderSVGContainer::drawsContents):
2655         (WebCore::RenderSVGContainer::setDrawsContents):
2656         (WebCore::RenderSVGContainer::localTransform):
2657         (WebCore::RenderSVGContainer::setLocalTransform):
2658         (WebCore::RenderSVGContainer::layout):
2659         (WebCore::RenderSVGContainer::paint):
2660         (WebCore::RenderSVGContainer::setViewport):
2661         (WebCore::RenderSVGContainer::viewport):
2662         (WebCore::RenderSVGContainer::setViewBox):
2663         (WebCore::RenderSVGContainer::viewBox):
2664         (WebCore::RenderSVGContainer::setAlign):
2665         (WebCore::RenderSVGContainer::align):
2666         (WebCore::RenderSVGContainer::fillContains):
2667         (WebCore::RenderSVGContainer::strokeContains):
2668         (WebCore::RenderSVGContainer::setSlice):
2669         (WebCore::RenderSVGContainer::slice):
2670         * kcanvas/RenderSVGContainer.h:
2671         * kcanvas/device/KRenderingFillPainter.cpp:
2672         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
2673         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
2674         (WebCore::KRenderingFillPainter::fillRule):
2675         (WebCore::KRenderingFillPainter::setFillRule):
2676         (WebCore::KRenderingFillPainter::opacity):
2677         (WebCore::KRenderingFillPainter::setOpacity):
2678         * kcanvas/device/KRenderingFillPainter.h:
2679         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2680         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
2681         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
2682         (WebCore::KRenderingPaintServerGradient::gradientStops):
2683         (WebCore::KRenderingPaintServerGradient::setGradientStops):
2684         (WebCore::KRenderingPaintServerGradient::spreadMethod):
2685         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
2686         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
2687         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
2688         (WebCore::KRenderingPaintServerGradient::gradientTransform):
2689         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
2690         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
2691         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
2692         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
2693         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
2694         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
2695         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
2696         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
2697         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
2698         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
2699         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
2700         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
2701         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
2702         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
2703         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
2704         (WebCore::KRenderingPaintServerGradient::listener):
2705         (WebCore::KRenderingPaintServerGradient::setListener):
2706         * kcanvas/device/KRenderingPaintServerGradient.h:
2707         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2708         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
2709         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
2710         (WebCore::KRenderingPaintServerPattern::setBbox):
2711         (WebCore::KRenderingPaintServerPattern::bbox):
2712         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
2713         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
2714         (WebCore::KRenderingPaintServerPattern::tile):
2715         (WebCore::KRenderingPaintServerPattern::setTile):
2716         (WebCore::KRenderingPaintServerPattern::patternTransform):
2717         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
2718         (WebCore::KRenderingPaintServerPattern::listener):
2719         (WebCore::KRenderingPaintServerPattern::setListener):
2720         * kcanvas/device/KRenderingPaintServerPattern.h:
2721         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2722         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
2723         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
2724         (WebCore::KRenderingPaintServerSolid::color):
2725         (WebCore::KRenderingPaintServerSolid::setColor):
2726         * kcanvas/device/KRenderingPaintServerSolid.h:
2727         * kcanvas/device/KRenderingStrokePainter.cpp:
2728         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
2729         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
2730         (WebCore::KRenderingStrokePainter::strokeWidth):
2731         (WebCore::KRenderingStrokePainter::setStrokeWidth):
2732         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2733         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2734         (WebCore::KRenderingStrokePainter::strokeCapStyle):
2735         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
2736         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
2737         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
2738         (WebCore::KRenderingStrokePainter::dashOffset):
2739         (WebCore::KRenderingStrokePainter::setDashOffset):
2740         (WebCore::KRenderingStrokePainter::dashArray):
2741         (WebCore::KRenderingStrokePainter::setDashArray):
2742         (WebCore::KRenderingStrokePainter::opacity):
2743         (WebCore::KRenderingStrokePainter::setOpacity):
2744         (WebCore::KRenderingStrokePainter::dirty):
2745         (WebCore::KRenderingStrokePainter::setDirty):
2746         * kcanvas/device/KRenderingStrokePainter.h:
2747
2748 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
2749
2750         Reviewed by Anders.
2751
2752         http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
2753         Fix build error
2754
2755         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
2756
2757 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
2758
2759         Reviewed by Anders.
2760
2761         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10886
2762         REGRESSION (r16387): Reproducible crash when mousing over HTML document
2763
2764         - Special case method [DOMNode ownerDocument] to call document() instead
2765           or ownerDocument() to return to the old behavior.
2766
2767         * WebCore.xcodeproj/project.pbxproj:
2768         * bindings/scripts/CodeGeneratorObjC.pm:
2769
2770 2006-09-15  Brady Eidson  <beidson@apple.com>
2771
2772         Reviewed by Tim Hatcher
2773
2774         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
2775         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
2776
2777         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
2778         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
2779         (WebCore::IconDatabase::open): Make sure the directory exists
2780
2781 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2782
2783         Reviewed by Brady.
2784
2785         Make new style ObjC methods public API.
2786
2787         * WebCore.xcodeproj/project.pbxproj:
2788         * bindings/objc/DOMPrivate.h:
2789         * bindings/objc/PublicDOMInterfaces.h:
2790
2791 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
2792
2793         Reviewed by Tim H.
2794
2795         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
2796         Auto-generate DOMNode for the Objective-C bindings
2797
2798         * DerivedSources.make:
2799         * WebCore.xcodeproj/project.pbxproj:
2800         * bindings/objc/DOM.mm:
2801         (-[DOMNode boundingBox]):
2802         (-[DOMNode lineBoxRects]):
2803         * bindings/objc/DOMEvents.h:
2804         * bindings/objc/DOMExtensions.h:
2805         * bindings/objc/DOMNode.h: Removed.
2806         * bindings/objc/DOMNode.mm: Removed.
2807         * bindings/objc/PublicDOMInterfaces.h:
2808         * bindings/scripts/CodeGeneratorObjC.pm:
2809         * dom/Node.idl:
2810
2811 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2812
2813         Reviewed by Justin.
2814
2815         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
2816
2817         * bridge/mac/WebCoreFrameBridge.h:
2818         * bridge/mac/WebCoreFrameBridge.mm:
2819         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
2820         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
2821         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
2822         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
2823         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
2824         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
2825         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2826         (-[WebCoreFrameBridge increaseSelectionListLevel]):
2827         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
2828         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
2829         (-[WebCoreFrameBridge decreaseSelectionListLevel]):
2830         (-[WebCoreFrameBridge insertLineBreak]):
2831         (-[WebCoreFrameBridge insertParagraphSeparator]):
2832         (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
2833         (-[WebCoreFrameBridge insertText:selectInsertedText:]):
2834         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
2835         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
2836         (createMouseEventFromDraggingInfo):
2837         * editing/SelectionController.cpp:
2838         (WebCore::SelectionController::moveTo):
2839         (WebCore::SelectionController::setSelection):
2840         (WebCore::SelectionController::modify):
2841         (WebCore::SelectionController::setBase):
2842         (WebCore::SelectionController::setExtent):
2843         * editing/SelectionController.h:
2844         * page/Frame.cpp:
2845         (WebCore::Frame::revealSelection):
2846         (WebCore::Frame::revealCaret):
2847         * page/Frame.h:
2848
2849 2006-09-15  Brady Eidson  <beidson@apple.com>
2850
2851         Reviewed by Anders
2852
2853         Added the ability to get a mutable char* from a CString, which will copy the internal
2854         buffer if the ref count is greater than 1 so your mutable char* won't affect any other
2855         referrer of that buffer.
2856
2857         * platform/CString.cpp:
2858         (WebCore::CString::mutableData):
2859         (WebCore::CString::copyBufferIfNeeded):
2860         * platform/CString.h:
2861
2862 2006-09-15  Justin Garcia  <justin.garcia@apple.com>
2863
2864         Reviewed by harrison
2865
2866         <rdar://problem/4674869>
2867         REGRESSION: selecting text to write over results in cursor jumping to middle of next line
2868
2869         * editing/SelectionController.cpp:
2870         (WebCore::SelectionController::modify): Added lineBoundary to test fix.
2871         * editing/visible_units.cpp:
2872         (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
2873         position before it, not after it.
2874
2875 2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2876
2877         Reviewed by Adam.
2878
2879         http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
2880         Bug 10864: Linux\GDK build fixes
2881
2882         * Projects/gdk/webcore-gdk.bkl:
2883         * WebCoreSources.bkl:
2884         * platform/gdk/FontCacheGdk.cpp:
2885         * platform/gdk/FontDataGdk.cpp:
2886         (WebCore::FontData::platformInit):
2887         * platform/gdk/FontGdk.cpp:
2888         (WebCore::Font::drawGlyphs):
2889         * platform/gdk/FrameGdk.cpp:
2890         (WebCore::FrameGdk::handleGdkEvent):
2891         * platform/gdk/FrameGdk.h:
2892         * platform/gdk/ImageGdk.cpp: Added.
2893         (WebCore::Image::initPlatformData):
2894         (WebCore::Image::invalidatePlatformData):
2895         (WebCore::Image::loadPlatformResource):
2896         (WebCore::Image::supportsType):
2897         * platform/gdk/RenderPopupMenuGdk.cpp:
2898         (WebCore::RenderPopupMenuGdk::hidePopup):
2899         * platform/gdk/RenderPopupMenuGdk.h:
2900         * platform/gdk/ScreenGdk.cpp:
2901         (WebCore::drawableForPage):
2902         (WebCore::screenRect):
2903         (WebCore::screenDepth):
2904         (WebCore::usableScreenRect):
2905         (WebCore::scaleFactor):
2906         * platform/gdk/SystemTimeLinux.cpp:
2907         (WebCore::currentTime):
2908         * platform/gdk/TemporaryLinkStubs.cpp:
2909         (FrameGdk::bindingRootObject):
2910         (FrameGdk::markMisspellings):
2911         (WebCore::screenDepthPerComponent):
2912         (WebCore::screenIsMonochrome):
2913         (WebCore::fileButtonChooseFileLabel):
2914         (WebCore::fileButtonNoFileSelectedLabel):
2915         (FrameGdk::shouldChangeSelection):
2916         (FrameGdk::respondToChangedSelection):
2917         (FrameGdk::respondToChangedContents):
2918         (Path::contains):
2919         (PlatformScrollBar::PlatformScrollBar):
2920         (PlatformScrollBar::~PlatformScrollBar):
2921         (PlatformScrollBar::width):
2922         (PlatformScrollBar::height):
2923         (PlatformScrollBar::setEnabled):
2924         (PlatformScrollBar::paint):
2925         (PlatformScrollBar::setScrollBarValue):
2926         (PlatformScrollBar::setKnobProportion):
2927         (PlatformScrollBar::setRect):
2928         (ScrollBar::ScrollBar):
2929         (FileChooser::FileChooser):
2930         (FileChooser::~FileChooser):
2931         (FileChooser::openFileChooser):
2932         (FileChooser::basenameForWidth):
2933         (FileChooser::uploadControlDetaching):
2934         (FileChooser::chooseFile):
2935         (Icon::Icon):
2936         (Icon::~Icon):
2937         (Icon::newIconForFile):
2938         (Icon::paint):
2939         (IconLoader::stopLoading):
2940         (IconLoader::startLoading):
2941         (IconLoader::createForFrame):
2942         (IconDatabase::isIconExpiredForIconURL):
2943         (IconDatabase::hasEntryForIconURL):
2944         (IconDatabase::sharedIconDatabase):
2945         * platform/gdk/WidgetGdk.cpp:
2946         * webcore-base.bkl:
2947
2948 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
2949
2950         Reviewed by Eric.
2951
2952         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
2953         Fix svg memory leaks.
2954
2955         Reworked SVGList to deal with RefPtr's for ptr types
2956         which makes manual refcounting unnecessary, and is much safer.
2957
2958         Removing all virtual functions (nullItem) from SVGList, and
2959         also remove SVGListBase. Switch to a similar concept like
2960         Vector/VectorTraits (see new file SVGListTraits.h).
2961
2962         Credits go to Eric/Maciej for the inspiration.
2963
2964         * CMakeLists.txt: Add SVGListTraits.cpp to build
2965         * WebCore.xcodeproj/project.pbxproj: Ditto.
2966         * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
2967         * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
2968         (WebCore::RenderSVGText::translationForAttributes):
2969         * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
2970         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2971         * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
2972         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
2973         * ksvg2/svg/SVGElementInstanceList.h:
2974         * ksvg2/svg/SVGLengthList.cpp: Ditto.
2975         (WebCore::SVGLengthList::SVGLengthList):
2976         * ksvg2/svg/SVGLengthList.h: Ditto.
2977         * ksvg2/svg/SVGList.h: Rewrote, as described above.
2978         (WebCore::SVGListTypeOperations::nullItem):
2979         (WebCore::SVGList::SVGList):
2980         (WebCore::SVGList::~SVGList):
2981         (WebCore::SVGList::clear):
2982         (WebCore::SVGList::getFirst):
2983         (WebCore::SVGList::getLast):
2984         (WebCore::SVGList::getItem):
2985         (WebCore::SVGList::replaceItem):
2986         (WebCore::SVGList::removeItem):
2987         * ksvg2/svg/SVGListTraits.cpp: Added.
2988         * ksvg2/svg/SVGListTraits.h: Added.
2989         (WebCore::):
2990         * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
2991         (WebCore::SVGPathElement::toPathData):
2992         * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
2993         (WebCore::SVGPathSegList::SVGPathSegList):
2994         * ksvg2/svg/SVGPathSegList.h: Ditto.
2995         * ksvg2/svg/SVGTransform.cpp: Style cleanup.
2996         (SVGTransform::SVGTransform):
2997         * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
2998         (SVGTransformList::SVGTransformList):
2999         (SVGTransformList::createSVGTransformFromMatrix):
3000         (SVGTransformList::consolidate):
3001         * ksvg2/svg/SVGTransformList.h: Ditto.
3002         * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
3003         (SVGTransformable::parseTransformAttribute):
3004
3005 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
3006
3007         Reviewed by eseidel.  Landed by eseidel.
3008
3009         Fix build on Qt/Linux and implement Frame::addMessageToConsole to
3010         be able to see javascript errors for instance.
3011
3012         * CMakeLists.txt:
3013         * platform/qt/FrameQt.h:
3014         * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
3015         (WebCore::FrameQt::bindingRootObject):
3016         * platform/qt/TemporaryLinkStubs.cp
3017         (WebCore::IconDatabase::hasEntryForIconURL):
3018         (WebCore::IconDatabase::sharedIconDatabase):
3019
3020 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
3021
3022         Reviewed by Tim H.
3023
3024         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10869
3025         Auto-generate the internal methods for the Objective-C bindings
3026
3027         - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
3028           implementations where standard.  For cases where a custom implementation was
3029           needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
3030
3031         - Some general cleanup of some of the non-generated bindings, to bring them in-
3032           line with what the generated bindings look like.
3033
3034         * bindings/objc/DOM.mm:
3035         (-[DOMNode description]):
3036         * bindings/objc/DOMCSS.mm:
3037         (-[DOMCSSPrimitiveValue WebCore::]):
3038         (-[DOMDocument getComputedStyle::]):
3039         (-[DOMDocument getMatchedCSSRules::]):
3040         * bindings/objc/DOMEvents.mm:
3041         (-[DOMEvent WebCore::]):
3042         * bindings/objc/DOMHTML.mm:
3043         * bindings/objc/DOMHTMLDocument.mm:
3044         (-[DOMHTMLDocument title]):
3045         (-[DOMHTMLDocument setTitle:]):
3046         (-[DOMHTMLDocument referrer]):
3047         (-[DOMHTMLDocument domain]):
3048         (-[DOMHTMLDocument URL]):
3049         (-[DOMHTMLDocument body]):
3050         (-[DOMHTMLDocument setBody:]):
3051         (-[DOMHTMLDocument images]):
3052         (-[DOMHTMLDocument applets]):
3053         (-[DOMHTMLDocument links]):
3054         (-[DOMHTMLDocument forms]):
3055         (-[DOMHTMLDocument anchors]):
3056         (-[DOMHTMLDocument cookie]):
3057         (-[DOMHTMLDocument setCookie:]):
3058         (-[DOMHTMLDocument open]):
3059         (-[DOMHTMLDocument close]):
3060         (-[DOMHTMLDocument write:]):
3061         (-[DOMHTMLDocument writeln:]):
3062         (-[DOMHTMLDocument getElementById:]):
3063         (-[DOMHTMLDocument getElementsByName:]):
3064         (-[DOMHTMLDocument WebCore::]):
3065         (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
3066         * bindings/objc/DOMHTMLOptionElement.mm:
3067         (-[DOMHTMLOptionElement form]):
3068         (-[DOMHTMLOptionElement defaultSelected]):
3069         (-[DOMHTMLOptionElement setDefaultSelected:]):
3070         (-[DOMHTMLOptionElement text]):
3071         (-[DOMHTMLOptionElement index]):
3072         (-[DOMHTMLOptionElement disabled]):
3073         (-[DOMHTMLOptionElement setDisabled:]):
3074         (-[DOMHTMLOptionElement label]):
3075         (-[DOMHTMLOptionElement setLabel:]):
3076         (-[DOMHTMLOptionElement selected]):
3077         (-[DOMHTMLOptionElement setSelected:]):
3078         (-[DOMHTMLOptionElement value]):
3079         (-[DOMHTMLOptionElement setValue:]):
3080         (-[DOMHTMLOptionElement WebCore::]):
3081         (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
3082         * bindings/objc/DOMInternal.h:
3083         * bindings/objc/DOMNode.mm:
3084         (-[DOMNode dealloc]):
3085         (-[DOMNode finalize]):
3086         (-[DOMNode nodeName]):
3087         (-[DOMNode nodeValue]):
3088         (-[DOMNode setNodeValue:]):
3089         (-[DOMNode nodeType]):
3090         (-[DOMNode parentNode]):
3091         (-[DOMNode childNodes]):
3092         (-[DOMNode firstChild]):
3093         (-[DOMNode lastChild]):
3094         (-[DOMNode previousSibling]):
3095         (-[DOMNode nextSibling]):
3096         (-[DOMNode attributes]):
3097         (-[DOMNode ownerDocument]):
3098         (-[DOMNode insertBefore::]):
3099         (-[DOMNode replaceChild::]):
3100         (-[DOMNode removeChild:]):
3101         (-[DOMNode appendChild:]):
3102         (-[DOMNode hasChildNodes]):
3103         (-[DOMNode cloneNode:]):
3104         (-[DOMNode normalize]):
3105         (-[DOMNode isSupported::]):
3106         (-[DOMNode namespaceURI]):
3107         (-[DOMNode prefix]):
3108         (-[DOMNode setPrefix:]):
3109         (-[DOMNode localName]):
3110         (-[DOMNode hasAttributes]):
3111         (-[DOMNode isSameNode:]):
3112         (-[DOMNode isEqualNode:]):
3113         (-[DOMNode isDefaultNamespace:]):
3114         (-[DOMNode lookupPrefix:]):
3115         (-[DOMNode lookupNamespaceURI:]):
3116         (-[DOMNode textContent]):
3117         (-[DOMNode setTextContent:]):
3118         (-[DOMNode boundingBox]):
3119         (-[DOMNode lineBoxRects]):
3120         * bindings/objc/DOMObject.mm:
3121         (-[DOMObject _init]):
3122         * bindings/objc/DOMXPath.mm:
3123         (-[DOMNativeXPathNSResolver dealloc]):
3124         (-[DOMNativeXPathNSResolver finalize]):
3125         (-[DOMNativeXPathNSResolver WebCore::]):
3126         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
3127         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
3128         (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
3129         * bindings/scripts/CodeGeneratorObjC.pm:
3130         * bridge/mac/WebCoreFrameBridge.mm:
3131         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3132         (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
3133         * css/CSSCharsetRule.idl:
3134         * css/CSSFontFaceRule.idl:
3135         * css/CSSImportRule.idl:
3136         * css/CSSMediaRule.idl:
3137         * css/CSSPageRule.idl:
3138         * css/CSSPrimitiveValue.idl:
3139         * css/CSSRule.idl:
3140         * css/CSSStyleRule.idl:
3141         * css/CSSStyleSheet.idl:
3142         * css/CSSUnknownRule.idl:
3143         * css/CSSValue.idl:
3144         * css/CSSValueList.idl:
3145         * css/StyleSheet.idl:
3146         * dom/Event.idl:
3147         * dom/KeyboardEvent.idl:
3148         * dom/MouseEvent.idl:
3149         * dom/MutationEvent.idl:
3150         * dom/NodeIterator.idl:
3151         * dom/OverflowEvent.idl:
3152         * dom/TreeWalker.idl:
3153         * dom/UIEvent.idl:
3154         * dom/WheelEvent.idl:
3155
3156 2006-09-15  Adam Roben  <aroben@apple.com>
3157
3158         Reviewed by timothy.
3159
3160         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
3161         New file upload control should match the width of the old one
3162
3163         Make width of new file upload control match the old one as closely as
3164         possible.
3165
3166         * rendering/RenderFileUploadControl.cpp:
3167
3168 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3169
3170         Reviewed by Eric.
3171
3172         Remove the SVG IDL files from the Copy Resources phase.
3173
3174         * WebCore.xcodeproj/project.pbxproj:
3175
3176 2006-09-15  Brady Eidson  <beidson@apple.com>
3177
3178         Reviewed by Eric Siedel
3179
3180         Dumped the use of CGColorRef and directly use the floating point data from
3181         WebCore::Color
3182
3183         This fixes the performance regression found between 16285 and 16286
3184
3185         * platform/mac/FontMac.mm:
3186         (WebCore::Font::drawComplexText):
3187         (WebCore::Font::drawGlyphs):
3188
3189 2006-09-14  Mark Rowe  <opendarwin.org@bdash.net.nz>
3190
3191         Reviewed by Adam.
3192
3193         http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
3194         Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate
3195
3196         FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
3197         Frame::cleanupPluginObjects method is called from Frame's destructor, which results
3198         in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.
3199
3200         * bridge/mac/FrameMac.mm:
3201         (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
3202         will be called from Frame::clear
3203         * page/Frame.cpp:
3204         (WebCore::Frame::~Frame): Use cancelAndClear.
3205         (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
3206         FrameMac can use.
3207         * page/Frame.h:
3208
3209 2006-09-14  Brady Eidson  <beidson@apple.com>
3210
3211         Reviewed by Maciej's rubber stamp
3212
3213         Exact same fix I just made, but in the other method I horked up
3214         Also added a reference to the bugzilla in comments
3215
3216         * page/Frame.cpp:
3217         (WebCore::Frame::endIfNotLoading):
3218         (WebCore::Frame::stop):
3219
3220 2006-09-14  Brady Eidson  <beidson@apple.com>
3221
3222         Reviewed by Maciej
3223
3224         Fixed a bad iFrame crash, resolving some of the layout test badness
3225
3226         * page/Frame.cpp:
3227         (WebCore::Frame::endIfNotLoading):
3228         - Added a RefPtr to protect the frame itself to prevent its destruction during this method
3229
3230 2006-09-14  Justin Garcia  <justin.garcia@apple.com>
3231
3232         Reviewed by harrison
3233
3234         <rdar://problem/4655880> Up/Down arrows skip over To Do
3235
3236         * bridge/mac/WebCoreFrameBridge.mm:
3237         (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
3238         * dom/Node.cpp: Removed the unused inSameRootEditableElement.
3239         * dom/Node.h:
3240         * editing/SelectionController.cpp:
3241         (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
3242         * editing/visible_units.cpp:
3243         (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
3244         editable content into editable content that's embedded in non-editable content.
3245         (WebCore::nextLinePosition): Ditto.
3246         (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
3247         This is the behavior that callers desire.  This fixes Command + Up/Down.
3248         (WebCore::endOfEditableContent): Ditto.
3249         * editing/visible_units.h:
3250
3251 2006-09-14  Karthik Kumar  <karthikkumar@gmail.com>
3252
3253         Reviewed by timothy. Landed by aroben.
3254
3255         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
3256         Windows build fixes after r16360
3257
3258         * WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to
3259         AdditionalIncludeDirectories
3260         * platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader,
3261         IconDatabase
3262         (IconLoader::stopLoading):
3263         (IconLoader::startLoading):
3264         (IconLoader::createForFrame):
3265         (IconDatabase::isIconExpiredForIconURL):
3266         (IconDatabase::hasEntryForIconURL):
3267         (IconDatabase::sharedIconDatabase):
3268
3269 2006-09-14  Brady Eidson  <beidson@apple.com>
3270
3271         Part of a build fix for Windows - rest will be working out a mess of temporary link stubs
3272
3273         * loader/icon/IconLoader.cpp:
3274         (IconLoader::receivedAllData):
3275         * page/Frame.cpp:
3276         * page/FramePrivate.h:
3277
3278 2006-09-14  Graham Dennis  <graham.dennis@gmail.com>
3279
3280         Reviewed by Justin Garcia.
3281
3282         - http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
3283           Crash in ApplyStyleCommand::applyRelativeFontStyleChange
3284
3285         * editing/ApplyStyleCommand.cpp:
3286         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by
3287         makeing sure that the 'beyondEnd' node is after the start node.
3288
3289 2006-09-14  MorganL  <morlmor@yahoo.com>
3290
3291         Reviewed by Brady.
3292
3293         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
3294         Various bugs/crashes in ResourceLoaderWin with local files.
3295
3296         * platform/ResourceLoaderInternal.h:
3297         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3298         * platform/win/ResourceLoaderWin.cpp:
3299         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
3300         (WebCore::ResourceLoader::fileLoadTimer):
3301
3302 2006-09-13  Brady Eidson <beidson@apple.com>
3303
3304         Reviewed by Maciej
3305
3306         Icon loads now take place in WebCore
3307
3308         * WebCore.xcodeproj/project.pbxproj:
3309         * bridge/BrowserExtension.h:
3310         * bridge/mac/BrowserExtensionMac.h:
3311         * bridge/mac/BrowserExtensionMac.mm:
3312         - Moved enforcement of a Mozilla Favicon extension elsewhere
3313
3314         * bridge/mac/FrameMac.h:
3315         * bridge/mac/FrameMac.mm:
3316         (WebCore::FrameMac::originalRequestURL):
3317         - Added accessor to "original request URL"
3318
3319         * bridge/mac/WebCoreFrameBridge.h:
3320         - Removed methods to set the iconURL as all loading is now done in WebCore
3321         - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL
3322
3323         * html/HTMLLinkElement.cpp:
3324         (WebCore::HTMLLinkElement::process):
3325         - Moved enforcement of a Mozilla Favicon extension elsewhere
3326
3327         * loader/icon/IconDatabase.cpp:
3328         (WebCore::IconDatabase::setIconURLForPageURL):
3329         - Changed an ASSERT to correctly handle a sketchy (invalid) situation
3330
3331         * loader/icon/IconLoader.h: Added.
3332         * loader/icon/IconLoader.cpp: Added.
3333         (IconLoader::IconLoader):
3334         (IconLoader::createForFrame):
3335         - Static factory method with a private constructor to enforce
3336           "you MUST have a Frame to create an IconLoader" semantics
3337         (IconLoader::~IconLoader):
3338         (IconLoader::startLoading):
3339         (IconLoader::stopLoading):
3340         (IconLoader::receivedData):
3341         - ResourceLoaderClient delegate
3342         (IconLoader::receivedAllData):
3343         - Ditto
3344
3345         * loader/mac/IconLoaderMac.mm: Added.
3346         (IconLoader::receivedResponse):
3347         (IconLoader::notifyIconChanged):
3348         - For now, these are platform specific methods
3349         - One to get the HTTP response code of an icon load
3350         - The other to call through to the app when the icon has changed (loaded)
3351
3352         * page/Frame.h:
3353         * page/Frame.cpp:
3354         (WebCore::Frame::iconURL):
3355         (WebCore::Frame::setIconURL):
3356         - Frame objects now have an inherent icon URL and a way to calculate/access it
3357         (WebCore::Frame::endIfNotLoading):
3358         - This is where we actually kick off the IconLoader
3359         (WebCore::Frame::stop):
3360         - Added call to stop loading the icon
3361
3362         * page/FramePrivate.h:
3363         (WebCore::FramePrivate::FramePrivate):
3364         (WebCore::FramePrivate::~FramePrivate):
3365         - Added the icon URL as a private member
3366         - Added the IconLoader as a private member, and clean it up on deletion
3367
3368         * platform/mac/ResourceLoaderMac.mm:
3369         (WebCore::ResourceLoader::start):  Added a valuable ASSERT
3370
3371 2006-09-13  David Hyatt  <hyatt@apple.com>
3372
3373         Fix for 10841, unable to check checkboxes inside labels.
3374
3375         Reviewed by xenon, bradee-oh
3376
3377         * css/html4.css:
3378         * dom/Element.cpp:
3379         (WebCore::Element::contains):
3380         * dom/Element.h:
3381         * html/HTMLLabelElement.cpp:
3382         (WebCore::HTMLLabelElement::defaultEventHandler):
3383
3384 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
3385
3386         Reviewed by Adam.
3387
3388         http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
3389         Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller
3390
3391         * platform/mac/FileChooserMac.mm:
3392         (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
3393
3394 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
3395
3396         Reviewed by Eric.
3397
3398         http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
3399         Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef
3400
3401         * platform/mac/FontMac.mm:
3402         (WebCore::Font::drawComplexText): Release CGColorRef after use.
3403         (WebCore::Font::drawGlyphs): Ditto.
3404
3405 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
3406
3407         Try fixing the Win32 build.
3408
3409         * bridge/win/FrameWin.h:
3410         * platform/win/TemporaryLinkStubs.cpp:
3411         (FrameWin::bindingRootObject):
3412
3413 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
3414
3415         Reviewed by Tim O.
3416
3417         Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.
3418
3419         * bindings/js/kjs_binding.cpp:
3420         (KJS::ScriptInterpreter::createLanguageInstanceForValue):
3421         * bindings/js/kjs_dom.cpp:
3422         (KJS::getRuntimeObject):
3423         * bridge/mac/FrameMac.h:
3424         * config.h:
3425         * html/HTMLAppletElement.cpp:
3426         (WebCore::HTMLAppletElement::~HTMLAppletElement):
3427         (WebCore::HTMLAppletElement::detach):
3428         * html/HTMLAppletElement.h:
3429         * html/HTMLEmbedElement.cpp:
3430         (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
3431         (WebCore::HTMLEmbedElement::detach):
3432         * html/HTMLEmbedElement.h:
3433         * html/HTMLObjectElement.cpp:
3434         (WebCore::HTMLObjectElement::~HTMLObjectElement):
3435         (WebCore::HTMLObjectElement::detach):
3436         * html/HTMLObjectElement.h:
3437         * html/HTMLPlugInElement.cpp:
3438         (WebCore::HTMLPlugInElement::HTMLPlugInElement):
3439         (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
3440         (WebCore::HTMLPlugInElement::createNPObject):
3441         * html/HTMLPlugInElement.h:
3442         * page/Frame.h:
3443
3444 2006-09-13  David Hyatt  <hyatt@apple.com>
3445
3446         Clean up the XBL and XSLT ifdefs to be consistent with the SVG
3447         and XPath ifdefs.  KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
3448         KHTML_XSLT is now XSLT_SUPPORT.
3449
3450         * WebCore.xcodeproj/project.pbxproj:
3451         * bindings/js/JSXSLTProcessor.cpp:
3452         * bindings/js/JSXSLTProcessor.h:
3453         * bindings/js/kjs_window.cpp:
3454         (KJS::Window::getValueProperty):
3455         * config.h:
3456         * css/CSSComputedStyleDeclaration.cpp:
3457         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3458         * css/cssparser.cpp:
3459         (WebCore::CSSParser::parseValue):
3460         * css/cssstyleselector.cpp:
3461         (WebCore::CSSStyleSelector::applyProperty):
3462         * dom/Document.cpp:
3463         (WebCore::Document::Document):
3464         (WebCore::Document::~Document):
3465         (WebCore::Document::recalcStyleSelector):
3466         * dom/Document.h:
3467         (WebCore::Document::bindingManager):
3468         * dom/Node.cpp:
3469         (WebCore::Node::createRendererIfNeeded):
3470         * dom/ProcessingInstruction.cpp:
3471         (WebCore::ProcessingInstruction::ProcessingInstruction):
3472         (WebCore::ProcessingInstruction::checkStyleSheet):
3473         (WebCore::ProcessingInstruction::setStyleSheet):
3474         * dom/ProcessingInstruction.h:
3475         * dom/XMLTokenizer.cpp:
3476         (WebCore::XMLTokenizer::processingInstruction):
3477         (WebCore::XMLTokenizer::insertErrorMessageBlock):
3478         * dom/XMLTokenizer.h:
3479         * loader/Cache.cpp:
3480         (WebCore::Cache::getStatistics):
3481         * loader/Cache.h:
3482         * loader/CachedResource.h:
3483         (WebCore::CachedResource::):
3484         * loader/CachedResourceClient.h:
3485         * loader/CachedXBLDocument.cpp:
3486         * loader/CachedXBLDocument.h:
3487         * loader/CachedXSLStyleSheet.cpp:
3488         * loader/CachedXSLStyleSheet.h:
3489         * loader/DocLoader.cpp:
3490         * loader/DocLoader.h:
3491         * rendering/RenderStyle.cpp:
3492         (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
3493         (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData):
3494         (WebCore::StyleCSS3NonInheritedData::operator==):
3495         * rendering/RenderStyle.h:
3496         * xml/XSLImportRule.cpp:
3497         * xml/XSLImportRule.h:
3498         * xml/XSLStyleSheet.cpp:
3499         * xml/XSLStyleSheet.h:
3500         * xml/XSLTProcessor.cpp:
3501         * xml/XSLTProcessor.h:
3502
3503 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
3504
3505         Reviewed by eseidel.  Landed by eseidel.
3506
3507         Fix newly introduced memory leaks in SVG.
3508         http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
3509
3510         * ksvg2/svg/SVGList.h:
3511         (WebCore::SVGListBase::~SVGListBase):
3512         (WebCore::SVGListBase::clearVector):
3513         (WebCore::SVGListBase::clear):
3514         (WebCore::SVGList::clearVector):
3515         (WebCore::):
3516         * ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that!
3517         (SVGNumberList::SVGNumberList):
3518         * ksvg2/svg/SVGNumberList.h: Ditto.
3519
3520 2006-09-13  MorganL  <morlmor@yahoo.com>
3521
3522         Reviewed/landed by aroben.
3523
3524         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
3525         Windows build needs fixed after move to engine-rendered file upload widget
3526
3527         * WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files,
3528         remove RenderFileButton files
3529         * platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon
3530         (FileChooser::FileChooser):
3531         (FileChooser::~FileChooser):
3532         (FileChooser::openFileChooser):
3533         (FileChooser::basenameForWidth):
3534         (FileChooser::uploadControlDetaching):
3535         (FileChooser::chooseFile):
3536         (WebCore::fileButtonChooseFileLabel):
3537         (WebCore::fileButtonNoFileSelectedLabel):
3538         (Icon::Icon):
3539         (Icon::~Icon):
3540         (Icon::newIconForFile):
3541         (Icon::paint):
3542
3543 2006-09-13  MorganL  <morlmor@yahoo.com>
3544
3545         Reviewed/landed by aroben.
3546
3547         Fixes http://bugzilla.opendarwin.org/attachment.cgi?id=10537
3548         Webkit WebCore build fails on Windows
3549
3550         * WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT
3551         variable
3552
3553 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
3554
3555         Reviewed by Tim H.
3556
3557         Fix Qt/Linux build.
3558
3559         * CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
3560         * platform/Icon.h: Add wtf/Platform.h include
3561         * platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though.
3562         (WebCore::FileChooser::FileChooser):
3563         (WebCore::FileChooser::~FileChooser):
3564         (WebCore::FileChooser::openFileChooser):
3565         (WebCore::FileChooser::basenameForWidth):
3566         (WebCore::FileChooser::uploadControlDetaching):
3567         (WebCore::FileChooser::chooseFile):
3568         * platform/qt/IconQt.cpp: Added as stub.
3569         (WebCore::Icon::Icon):
3570         (WebCore::Icon::~Icon):
3571         (WebCore::Icon::newIconForFile):
3572         (WebCore::Icon::paint):
3573         * platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed
3574         (searchableIndexIntroduction):
3575         (fileButtonChooseFileLabel):
3576         (fileButtonNoFileSelectedLabel):
3577
3578 2006-09-12  Adam Roben  <aroben@apple.com>
3579
3580         Reviewed by eseidel.
3581
3582         Switch back to passing relative paths to generate-bindings.pl when
3583         generating JS bindings.
3584
3585         * DerivedSources.make: Pass in relative paths to generate-bindings.pl
3586         * bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call
3587         chdir and always construct absolute paths instead.
3588
3589 2006-09-12  David Hyatt  <hyatt@apple.com>
3590
3591         Fix for bug 3244, implement html4 label support.
3592
3593         Reviewed by mjs, aroben
3594
3595         Added fast/events/label-focus.html
3596
3597         * css/html4.css:
3598         * html/HTMLLabelElement.cpp:
3599         (WebCore::HTMLLabelElement::formElement):
3600         (WebCore::HTMLLabelElement::setActive):
3601         (WebCore::HTMLLabelElement::setHovered):
3602         (WebCore::HTMLLabelElement::defaultEventHandler):
3603         * html/HTMLLabelElement.h:
3604
3605 2006-09-12  Julien Palmas  <julien.palmas@gmail.com>
3606
3607         Reviewed by darin.  Landed by eseidel.
3608
3609         * ksvg2/svg/svgpathparser.cpp:
3610         (WebCore::SVGPolyParser::parsePoints):
3611
3612 2006-09-11  Kevin McCullough  <KMcCullough@apple.com>
3613
3614         Reviewed by Andersca, Maciej, Brady.
3615
3616         - Implemented intersectsNode in the Range Class
3617           to be compliant with Mozilla standard
3618
3619         * dom/Range.cpp:
3620         (WebCore::Range::intersectsNode):
3621         * dom/Range.h:
3622         * dom/Range.idl:
3623
3624 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>