d61217d058e0b39421c4d1d4642e7c09d0b0364e
[WebKit-https.git] / WebCore / ChangeLog
1 2007-07-01  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Oliver.
4
5         Third round of implicit 64-32 bit conversion errors fixes.
6         <rdar://problem/5292262>
7
8         - Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()
9           methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
10
11         * css/CSSPrimitiveValue.cpp:
12         (WebCore::CSSPrimitiveValue::computeLengthInt):
13         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
14         (WebCore::CSSPrimitiveValue::computeLengthShort):
15         (WebCore::CSSPrimitiveValue::computeLengthFloat):
16         (WebCore::CSSPrimitiveValue::computeLengthDouble):
17         (WebCore::CSSPrimitiveValue::getDoubleValue):
18         * css/CSSPrimitiveValue.h:
19         (WebCore::CSSPrimitiveValue::getDoubleValue):
20         (WebCore::CSSPrimitiveValue::getFloatValue):
21         (WebCore::CSSPrimitiveValue::getIntValue):
22         * css/Counter.h:
23         (WebCore::Counter::listStyleNumber):
24         * css/MediaQueryEvaluator.cpp:
25         (WebCore::parseAspectRatio):
26         * css/cssparser.cpp:
27         (WebCore::BorderImageParseContext::commitBorderImage):
28         * css/cssstyleselector.cpp:
29         (WebCore::convertToLength):
30         (WebCore::applyCounterList):
31         (WebCore::CSSStyleSelector::applyProperty):
32         (WebCore::CSSStyleSelector::mapBackgroundSize):
33         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
34         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
35         * html/HTMLTableElement.cpp:
36         (WebCore::HTMLTableElement::parseMappedAttribute):
37         * ksvg2/css/SVGCSSStyleSelector.cpp:
38         (WebCore::CSSStyleSelector::applySVGProperty):
39         * ksvg2/misc/KCanvasRenderingStyle.cpp:
40         (WebCore::KSVGPainterFactory::cssPrimitiveToLength):
41         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
42
43 2007-07-01  Pamela Greene  <pamg.bugs@gmail.com>
44
45         Reviewed by Darin.
46
47         Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
48         Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
49         <rdar://problem/5290084>
50
51         Use std::stable_sort() instead of qsort() to sort gradient stops.
52         Adjust the comparison function accordingly.
53
54         * html/CanvasGradient.cpp:
55         (WebCore::compareStops):
56         (WebCore::CanvasGradient::findStop):
57
58 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
59
60         Reviewed by Darin.
61
62         m_usesPageCache was not initialized. As the b/f cache is only
63         implemented in the Mac port and WebView.mm is taking care of calling
64         Settings::setUsesPageCache I decided to make it false by default.
65
66         * page/Settings.cpp:
67         (WebCore::Settings::Settings): m_usesPageCache was not initialized
68
69 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
70
71         Reviewed by Darin.
72
73         Inherited- and NonInheritedFlags is a bit field. But for comparsion
74         the other part of the union _iflags/_niflags is used for comparions.
75         This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
76         Make sure the unused bits have a specified value.
77
78         * ksvg2/css/SVGRenderStyle.h:
79         (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits
80         have a value as well.
81
82 2007-06-30  Adam Roben  <aroben@apple.com>
83
84         Compile WebCore with /W4 on Windows
85
86         Some more warnings were disabled globally, including assignment within
87         a conditional, unused variable, and various warnings related to
88         inability to instantiate opaque structs.
89
90         In addition, the "unreachable code" warning was turned off for
91         CSSGrammar.cpp and XPathGrammar.cpp.
92
93         Reviewed by Oliver.
94
95         * WebCore.vcproj/WebCore.vcproj:
96
97 2007-06-29  Adam Roben  <aroben@apple.com>
98
99         Give CString an equality operator to fix a bug in HTMLFormElement::formData
100
101         The bug was spotted by MSVC /W4. The problem was that we were comparing
102         a CString to a char* using ==, but CString had no equality operator.
103         The result was that the CString was being cast to a const char* and a
104         pointer comparison was being done, which would (essentially) always
105         return false.
106
107         There are two parts to the fix: get rid of CString's const char*
108         casting operator, and add an equality operator. Previous uses of the
109         casting operator have been changed to use CString::data().
110
111         Test: http/misc/isindex-formdata.html
112
113         Reviewed by Oliver.
114
115         * dom/XMLTokenizer.cpp:
116         (WebCore::parseXMLDocumentFragment):
117         * html/HTMLDocument.cpp:
118         (WebCore::HTMLDocument::determineParseMode):
119         * html/HTMLFormElement.cpp:
120         (WebCore::HTMLFormElement::formData):
121         * loader/TextResourceDecoder.cpp:
122         (WebCore::TextResourceDecoder::checkForCSSCharset):
123         * platform/CString.cpp:
124         (WebCore::operator==):
125         * platform/CString.h:
126         * platform/KURL.cpp:
127         (WebCore::encodeRelativeString):
128         * platform/StringImpl.cpp:
129         (WebCore::StringImpl::toDouble):
130         * platform/network/cf/FormDataStreamCFNet.cpp:
131         (WebCore::setHTTPBody):
132         * platform/network/mac/FormDataStreamMac.mm:
133         (WebCore::setHTTPBody):
134         * platform/win/ClipboardUtilitiesWin.cpp:
135         (WebCore::markupToCF_HTML):
136         * plugins/win/PluginPackageWin.cpp:
137         (WebCore::splitString):
138         * plugins/win/PluginStreamWin.cpp:
139         (WebCore::PluginStreamWin::startStream):
140         (WebCore::PluginStreamWin::destroyStream):
141         (WebCore::PluginStreamWin::sendJavaScriptStream):
142         (WebCore::PluginStreamWin::didFinishLoading):
143         * plugins/win/PluginViewWin.cpp:
144         (WebCore::PluginViewWin::start):
145         (WebCore::createUTF8String):
146         (WebCore::PluginViewWin::userAgent):
147         * xml/XSLStyleSheet.cpp:
148         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
149         * xml/XSLTProcessor.cpp:
150         (WebCore::xsltParamArrayFromParameterMap):
151
152 2007-06-29  Adam Roben  <aroben@apple.com>
153
154         Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
155
156         Reviewed by John.
157
158         * editing/Editor.cpp:
159         (WebCore::Editor::advanceToNextMisspelling):
160         * html/HTMLParser.cpp:
161
162 2007-06-29  Adam Roben  <aroben@apple.com>
163
164         Fix some possibly unitialized variables found by MSVC /W4
165
166         Reviewed by John.
167
168         * rendering/bidi.cpp:
169         (WebCore::RenderBlock::layoutInlineChildren):
170
171 2007-06-29  Adam Roben  <aroben@apple.com>
172
173         Remove bogus cast found by MSVC /W4
174
175         Reviewed by John and Oliver.
176
177         * ksvg2/css/SVGCSSParser.cpp:
178         (WebCore::CSSParser::parseSVGValue):
179
180 2007-06-29  Adam Roben  <aroben@apple.com>
181
182         Remove unused local functions uncovered by MSVC /W4
183
184         Reviewed by John and Oliver.
185
186         * platform/win/SearchPopupMenuWin.cpp:
187         * rendering/RenderText.cpp:
188
189 2007-06-29  Adam Roben  <aroben@apple.com>
190
191         Don't take the address of temporary values to appease MSVC /W4
192
193         Reviewed by Oliver.
194
195         No regression test possible.
196
197         * platform/win/PopupMenuWin.cpp:
198         (WebCore::PopupMenu::invalidateItem):
199         (WebCore::PopupMenu::valueChanged):
200         (WebCore::PopupWndProc):
201         * platform/win/ScrollViewWin.cpp:
202         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
203         * platform/win/UniscribeController.cpp:
204         (WebCore::UniscribeController::shapeAndPlaceItem):
205         * platform/win/WidgetWin.cpp:
206         (WebCore::Widget::invalidateRect):
207
208 2007-06-29  Adam Roben  <aroben@apple.com>
209
210         Make an int -> UINT conversion explicit that MSVC /W4 complains about
211
212         Reviewed by John and Oliver.
213
214         No regression test possible.
215
216         * platform/win/SoundWin.cpp:
217
218 2007-06-29  Adam Roben  <aroben@apple.com>
219
220         Remove unreachable code uncovered by MSVC /W4
221
222         Reviewed by Oliver.
223
224         No regression test possible.
225
226         * html/CanvasRenderingContext2D.cpp:
227         (WebCore::CanvasRenderingContext2D::createPattern):
228         * html/HTMLAnchorElement.cpp:
229         (WebCore::HTMLAnchorElement::isLiveLink):
230         * html/HTMLElement.cpp:
231         (WebCore::HTMLElement::contentEditable):
232         * platform/DeprecatedString.cpp:
233         (WebCore::allocateHandle):
234         (WebCore::freeHandle):
235         * plugins/win/npapi.cpp:
236         (pluginViewForInstance):
237         * rendering/RenderImage.cpp:
238         (WebCore::RenderImage::isWidthSpecified):
239         (WebCore::RenderImage::isHeightSpecified):
240         * rendering/RenderTheme.cpp:
241         (WebCore::RenderTheme::isControlStyled):
242
243 2007-06-29  John Sullivan  <sullivan@apple.com>
244
245         Reviewed by Oliver Hunt.
246         
247         - WebCore support for accessing the set of rectangles that encompass the selected text
248         
249         * page/Frame.h:
250         * page/Frame.cpp:
251         (WebCore::Frame::selectionTextRects):
252         new function, fills in a passed Vector with the line box rects that represent the selected range
253
254         * rendering/RenderText.cpp:
255         (WebCore::RenderText::addLineBoxRects):
256         fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
257
258         * WebCore.exp:
259         exported symbol for this new function
260
261 2007-06-29  Justin Garcia  <justin.garcia@apple.com>
262
263         Reviewed by Harrison.
264         
265         <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
266         
267         Rolled out a change made in r23787.
268         
269         * editing/DeleteSelectionCommand.cpp:
270         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
271
272 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
273
274         Reviewed by Darin Adler, Anders Carlsson.
275         
276         Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML 
277         returns NULL if response MIME type is not XML -- breaks Wikipedia widget
278         
279         The spec says that responseXML must return null for any HTTP response
280         with a non-XML MIME type. Technically, that leaves non-HTTP responses
281         free to do whatever they want.
282
283         * xml/xmlhttprequest.cpp:
284         (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
285         MIME types if the response was HTTP.
286
287 2007-06-29  Sam Weinig  <sam@webkit.org>
288
289         Reviewed by Darin.
290
291         Second pass at fixing implicit 64-32 bit conversion errors.
292         <rdar://problem/5292262>
293
294         - Use new JSValue::toFloat() method instead of toNumber() where
295           appropriate.
296
297         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
298         (WebCore::JSCanvasRenderingContext2D::setFillColor):
299         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
300         (WebCore::JSCanvasRenderingContext2D::strokeRect):
301         (WebCore::JSCanvasRenderingContext2D::drawImage):
302         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
303         (WebCore::JSCanvasRenderingContext2D::setShadow):
304         * bindings/js/JSHTMLSelectElementCustom.cpp:
305         (WebCore::JSHTMLSelectElement::remove):
306         * bindings/js/JSSVGMatrixCustom.cpp:
307         (WebCore::JSSVGMatrix::rotateFromVector):
308         * bindings/js/kjs_events.cpp:
309         (KJS::JSClipboardPrototypeFunction::callAsFunction):
310         * bindings/scripts/CodeGeneratorJS.pm:
311         * ksvg2/svg/SVGScriptElement.cpp:
312         (WebCore::SVGScriptElement::executeScript):
313
314 2007-06-29  Adele Peterson  <adele@apple.com>
315
316         Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
317
318         * html/HTMLInputElement.h:
319         * html/HTMLTextAreaElement.h:
320
321 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
322
323         Reviewed by Oliver Hunt.
324
325         Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing 
326         local file throws exception -- breaks Wikipedia widget
327
328         * WebCore.xcodeproj/project.pbxproj:
329         * xml/xmlhttprequest.cpp:
330         (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
331
332 2007-06-29  Ada Chan  <adachan@apple.com>
333
334         Reviewed by Adam.
335
336         Fixed a previous fix to a signed/unsigned mismatch.
337
338         * plugins/win/PluginPackageWin.cpp:
339         (WebCore::splitString):
340
341 2007-06-29  Adele Peterson  <adele@apple.com>
342
343         Reviewed by Ada and Kevin McCullough.
344
345         Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
346
347         Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
348
349         Tests:
350         fast/forms/input-readonly-select-all.html
351         fast/forms/textarea-readonly-select-all.html
352
353         * html/HTMLInputElement.h:
354         (WebCore::HTMLInputElement::canSelectAll):
355         (WebCore::HTMLInputElement::selectAll):
356         * html/HTMLTextAreaElement.h:
357         (WebCore::HTMLTextAreaElement::canSelectAll):
358         (WebCore::HTMLTextAreaElement::selectAll):
359
360 2007-06-29  Adam Roben  <aroben@apple.com>
361
362         Build fix
363
364         This is what happens when you test your patch on two OSs and then
365         commit from the wrong one.
366
367         * rendering/RenderTextControl.cpp:
368         (WebCore::RenderTextControl::valueChanged):
369         (WebCore::RenderTextControl::itemText):
370         (WebCore::RenderTextControl::itemIsSeparator):
371
372 2007-06-29  Adam Roben  <aroben@apple.com>
373
374         Start compiling WebCore with /W3 under MSVC
375
376         One warning was globally disabled: implicit conversion of int to bool.
377
378         Reviewed by Darin.
379
380         * WebCore.vcproj/WebCore.vcproj:
381
382 2007-06-29  Adam Roben  <aroben@apple.com>
383
384         Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
385
386         DeprecatedStringData now has no public copy constructor. The single
387         call to the old one has been replaced with a call to the new
388         DeprecatedStringData::createAndAdopt static method.
389
390         Reviewed by Darin.
391
392         All regression tests pass.
393
394         * platform/DeprecatedString.cpp:
395         (WebCore::DeprecatedStringData::createAndAdopt):
396         (WebCore::DeprecatedStringData::adopt):
397         (WebCore::DeprecatedString::detachIfInternal):
398         * platform/DeprecatedString.h:
399
400 2007-06-29  Adam Roben  <aroben@apple.com>
401
402         Fix more signed/unsigned mismatches uncovered by MSVC /W3
403
404         Reviewed by John.
405
406         No regression tests possible.
407
408         * platform/network/cf/ResourceResponseCFNet.cpp:
409         (WebCore::filenameHasSaneExtension):
410         * platform/win/FontDataWin.cpp:
411         (WebCore::FontData::containsCharacters):
412         * platform/win/PlatformScrollBarSafari.cpp:
413         (WebCore::):
414         * platform/win/UniscribeController.cpp:
415         (WebCore::UniscribeController::advance):
416         (WebCore::UniscribeController::shapeAndPlaceItem):
417         * platform/win/WebCoreTextRenderer.cpp:
418         (WebCore::doDrawTextAtPoint):
419         * plugins/win/PluginDatabaseWin.cpp:
420         (WebCore::parseVersionString):
421         * plugins/win/PluginPackageWin.cpp:
422         (WebCore::splitString):
423         * plugins/win/PluginViewWin.cpp:
424         (WebCore::freeStringArray):
425         (WebCore::PluginViewWin::invalidateTimerFired):
426
427 2007-06-29  Adam Roben  <aroben@apple.com>
428
429         Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
430
431         Reviewed by John.
432
433         No regression test possible.
434
435         * html/HTMLSelectElement.cpp:
436         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
437         * platform/PopupMenuClient.h:
438         * platform/win/PopupMenuWin.cpp:
439         (WebCore::PopupMenu::calculatePositionAndSize):
440         (WebCore::PopupMenu::focusFirst):
441         (WebCore::PopupMenu::focusLast):
442         (WebCore::PopupMenu::down):
443         (WebCore::PopupMenu::up):
444         (WebCore::PopupMenu::paint):
445         * rendering/RenderMenuList.cpp:
446         * rendering/RenderMenuList.h:
447         * rendering/RenderTextControl.cpp:
448         * rendering/RenderTextControl.h:
449
450 2007-06-29  Adam Roben  <aroben@apple.com>
451
452         Fix two typos spotted by MSVC /W3
453
454         Both typos were a semicolon following the condition of an if. This
455         would cause the intended body of the if to always execute.
456
457         Unfortunately neither of these fixes are testable.
458         BackForwardList::goForward is only called from WebBackForwardList, and
459         the createDragImageFromImage bug would only manifest itself when
460         CreateCompatibleDC failed.
461
462         Reviewed by Mark.
463
464         * history/BackForwardList.cpp:
465         (WebCore::BackForwardList::goForward):
466         * platform/win/DragImageWin.cpp:
467         (WebCore::createDragImageFromImage):
468
469 2007-06-29  Adam Treat  <adam@staikos.net>
470
471         Reviewed by george Staikos.
472
473         Support horizontal and vertical scroll, and set the right units.
474
475         * platform/qt/WheelEventQt.cpp:
476         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
477
478 2007-06-28  Adam Roben  <aroben@apple.com>
479
480         Get WebCore compiling with /W2 on Windows
481
482         Reviewed by Steve.
483
484         No regression tests affected.
485
486         * WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
487         disable two warnings: implicit int <=> float conversion, and class vs.
488         struct inconsistency.
489         * dom/CharacterData.cpp:
490         (WebCore::CharacterData::deleteData): Cast to int before negating.
491         * loader/Cache.cpp:
492         (WebCore::Cache::remove): Ditto.
493         * platform/graphics/Path.cpp:
494         (WebCore::pathLengthApplierFunction): Consistently use floats.
495         * platform/graphics/cg/GraphicsContextCG.cpp:
496         (WebCore::GraphicsContext::drawEllipse): Ditto.
497         * platform/win/GraphicsContextWin.cpp:
498         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
499
500 2007-06-28  Geoffrey Garen  <ggaren@apple.com>
501
502         Reviewed by Maciej Stachowiak.
503         
504         Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease 
505         pool => pathologically high high water mark
506         
507         I couldn't measure any performance problems with iBench HTML or PLT.
508
509         * WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
510         * platform/mac/SharedTimerMac.cpp:
511         (WebCore::timerFired): Added autorelease pool.
512
513 2007-06-28  Mitz Pettel  <mitz@webkit.org>
514
515         Reviewed by Beth.
516
517         - fix http://bugs.webkit.org/show_bug.cgi?id=14118
518           ASSERTION FAILED: !needsLayout() seen again
519
520         Test: fast/dynamic/recursive-layout.html
521
522         * page/FrameView.cpp:
523         (WebCore::FrameView::layout): Removed the midLayout guards around
524         the calls to invalidateSelection() and updateWidgetPositions(). Those
525         calls may dirty the layout, but in that case they also update it, so
526         they should be allowed to do it. Added an ASSERT to make sure that when
527         they return, the root is not marked for layout.
528
529 2007-06-28  Sam Weinig  <sam@webkit.org>
530
531         Rubberstamped by Adam Roben.
532
533         Roll out r23861.  It caused the buildbot to fail on intel.
534
535         * page/Page.cpp:
536         (WebCore::Page::goToItem):
537
538 2007-06-26  Maxime Britto  <mbritto@pleyo.com>
539
540         Reviewed by Geoff.
541
542         Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
543         ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
544
545         Modification of an ASSERT on goToItem related to go back/forward in
546         history.Don't need to check the frameset if the target is _blank.
547
548          * page/Page.cpp:
549          (WebCore::Page::goToItem):
550
551 2007-06-28  Anders Carlsson  <andersca@apple.com>
552
553         Reviewed by Oliver.
554
555         <rdar://problem/5234139>
556         <object> with PNG src rendered as image document.
557         
558         Complete the URL before passing it to the frame loader client.
559         
560         * html/HTMLObjectElement.cpp:
561         (WebCore::HTMLObjectElement::isImageType):
562
563 2007-06-28  Rob Buis  <buis@kde.org>
564
565         Reviewed by Maciej.
566
567         http://bugs.webkit.org/show_bug.cgi?id=14373
568         CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
569
570         Make sure the id selector validates against the CSS2.1 identfier
571         definition, not the hexcolor/HASH definition.
572
573         * css/CSSGrammar.y:
574         * css/cssparser.cpp:
575         (WebCore::CSSParser::lex):
576         (WebCore::CSSParser::text):
577         * css/tokenizer.flex:
578
579 2007-06-28  Simon Hausmann  <hausmann@kde.org>
580
581         Reviewed by Zack.
582
583         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
584
585         * platform/qt/PasteboardQt.cpp:
586         (WebCore::Pasteboard::writeSelection):
587
588 2007-06-28  Antti Koivisto  <antti@apple.com>
589
590         Reviewed by Mitz.
591         
592         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
593         Bug 14332: REGRESSION (r21145): <td> width ignored
594         <rdar://problem/5290123>
595         
596         Cells in table with non-zero cellpadding are not considered empty.
597
598         * rendering/AutoTableLayout.cpp:
599         (WebCore::AutoTableLayout::recalcColumn):
600
601 2007-06-28  Adam Roben  <aroben@apple.com>
602
603         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
604
605         Reviewed by Hyatt.
606
607         No layout test possible, as this bug didn't have any effect since
608         "bool & bool" has the same value as "bool && bool"
609
610         * rendering/RenderBlock.cpp:
611         (WebCore::RenderBlock::paintObject): Changed & to &&.
612
613 2007-06-28  Adam Roben  <aroben@apple.com>
614
615         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
616
617         The bug was caused by two typos found by prefast.
618
619         Reviewed by Hyatt.
620
621         * css/cssparser.cpp:
622         (WebCore::CSSParser::parseValue): Fixed typos.
623
624 2007-06-20  Matt Perry  <mpComplete@gmail.com>
625
626         Reviewed by Adam.
627
628         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
629           onchange handler for select controls doesn't fire when changing via keyboard
630
631         * html/HTMLSelectElement.cpp:
632         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
633         a call to saveLastSelection in the "Enter" key handler for select
634         controls that was preventing onchange from firing.
635
636 2007-06-27  Sam Weinig  <sam@webkit.org>
637
638         Fix Gdk, Qt, and Win32 builds.
639
640         * WebCore.pro:
641         * WebCore.vcproj/WebCore.vcproj:
642
643 2007-06-27  Sam Weinig  <sam@webkit.org>
644
645         Reviewed by Geoff.
646
647         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
648         Move the Selection object out of the JS bindings
649
650         - Renames JS Object Selection to DOMSelection to avoid a name
651           conflict.
652
653         * DerivedSources.make:
654         * WebCore.xcodeproj/project.pbxproj:
655         * bindings/js/kjs_window.cpp:
656         (KJS::WindowPrivate::WindowPrivate):
657         (KJS::Window::mark):
658         (KJS::Window::clearHelperObjectProperties):
659         (KJS::WindowFunc::callAsFunction):
660         (KJS::Window::disconnectFrame):
661         * bindings/js/kjs_window.h:
662         (KJS::Window::):
663         * page/DOMSelection.cpp: Added.
664         (WebCore::DOMSelection::DOMSelection):
665         (WebCore::DOMSelection::frame):
666         (WebCore::DOMSelection::disconnectFrame):
667         (WebCore::DOMSelection::anchorNode):
668         (WebCore::DOMSelection::baseNode):
669         (WebCore::DOMSelection::anchorOffset):
670         (WebCore::DOMSelection::baseOffset):
671         (WebCore::DOMSelection::focusNode):
672         (WebCore::DOMSelection::extentNode):
673         (WebCore::DOMSelection::focusOffset):
674         (WebCore::DOMSelection::extentOffset):
675         (WebCore::DOMSelection::isCollapsed):
676         (WebCore::DOMSelection::type):
677         (WebCore::DOMSelection::rangeCount):
678         (WebCore::DOMSelection::collapse):
679         (WebCore::DOMSelection::collapseToEnd):
680         (WebCore::DOMSelection::collapseToStart):
681         (WebCore::DOMSelection::empty):
682         (WebCore::DOMSelection::setBaseAndExtent):
683         (WebCore::DOMSelection::setPosition):
684         (WebCore::DOMSelection::modify):
685         (WebCore::DOMSelection::getRangeAt):
686         (WebCore::DOMSelection::removeAllRanges):
687         (WebCore::DOMSelection::addRange):
688         (WebCore::DOMSelection::toString):
689         * page/DOMSelection.h: Added.
690         * page/DOMSelection.idl: Added.
691         * page/DOMWindow.cpp:
692         (WebCore::DOMWindow::disconnectFrame):
693         (WebCore::DOMWindow::getSelection):
694         * page/DOMWindow.h:
695         * page/DOMWindow.idl:
696
697 2007-06-27  Sam Weinig  <sam@webkit.org>
698
699         Reviewed by Maciej.
700
701         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
702         Autogenerate Event JS binding
703
704         - Cleanup kjs_events
705
706         * bindings/js/kjs_events.cpp:
707         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
708         (WebCore::JSAbstractEventListener::handleEvent):
709         (WebCore::JSAbstractEventListener::isHTMLEventListener):
710         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
711         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
712         (WebCore::JSUnprotectedEventListener::listenerObj):
713         (WebCore::JSUnprotectedEventListener::windowObj):
714         (WebCore::JSUnprotectedEventListener::clearWindowObj):
715         (WebCore::JSUnprotectedEventListener::mark):
716         (WebCore::JSEventListener::JSEventListener):
717         (WebCore::JSEventListener::~JSEventListener):
718         (WebCore::JSEventListener::listenerObj):
719         (WebCore::JSEventListener::windowObj):
720         (WebCore::JSEventListener::clearWindowObj):
721         (WebCore::JSLazyEventListener::JSLazyEventListener):
722         (WebCore::JSLazyEventListener::listenerObj):
723         (WebCore::JSLazyEventListener::parseCode):
724         (WebCore::getNodeEventListener):
725         (WebCore::JSClipboard::JSClipboard):
726         (WebCore::JSClipboard::getValueProperty):
727         (WebCore::JSClipboard::putValueProperty):
728         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
729         (WebCore::toJS):
730         (WebCore::toClipboard):
731         * bindings/js/kjs_events.h:
732         (WebCore::JSClipboard::classInfo):
733         (WebCore::JSClipboard::impl):
734         * bindings/js/kjs_window.h:
735         * ksvg2/events/JSSVGLazyEventListener.h:
736
737 2007-06-27  Sam Weinig  <sam@webkit.org>
738
739         Reviewed by Adam Roben.
740
741         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
742         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
743         <rdar://problem/5286670>
744
745         Test: fast/forms/thumbslider-no-parent-slider.html
746         Test: fast/forms/thumbslider-crash.html
747
748         * rendering/RenderObject.h:
749         (WebCore::RenderObject::isSlider):
750         * rendering/RenderSlider.h:
751         (WebCore::RenderSlider::isSlider):
752         * rendering/RenderTheme.cpp:
753         (WebCore::RenderTheme::paint): Only paint thumbslider
754         if the parent renderer is a RenderSlider.
755         * rendering/RenderThemeMac.mm:
756         (WebCore::RenderThemeMac::paintSliderThumb):
757         * rendering/RenderThemeSafari.cpp:
758         (WebCore::RenderThemeSafari::paintSliderThumb):
759
760 2007-06-27  George Staikos  <staikos@kde.org>
761
762         Make Qt builds link when XSLT is turned off.
763
764         * WebCore.pro:
765
766 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
767
768         Turn on static code analysis (Windows only).
769
770         Affects only folks that have Visual Studio Team Suite installed,
771         or who have replaced their compiler with the version shipping in the
772         Vista SDK.
773         
774         Reviewed by Oliver.
775
776         * WebCore.vcproj/WebCore.vcproj:
777
778 2007-06-27  George Staikos  <staikos@kde.org>
779
780         Remove old commented out files that no-longer exist.
781
782         * WebCore.pro:
783
784 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
785
786         Reviewed by John.
787
788         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
789         
790         Pasting with a trailing interchange newline doesn't work when pasting
791         into an empty line.  Code that handles removing brs at the insertion
792         position tries to also handle trailing interchange newlines by re-using
793         those brs and fails.  Removed that code and handle all interchange
794         newlines with code later in doApply().
795
796         * editing/ReplaceSelectionCommand.cpp:
797         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
798         endBR when there's a trailing interchange newline.
799         
800 2007-06-27  Anders Carlsson  <andersca@apple.com>
801
802         Reviewed by Oliver.
803
804         <rdar://problem/5253950>
805         When Shockwave plugin has been loaded, exiting crashes Safari
806         
807         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
808         
809         * plugins/win/PluginPackageWin.cpp:
810         (WebCore::PluginPackageWin::PluginPackageWin):
811         (WebCore::PluginPackageWin::load):
812         (WebCore::PluginPackageWin::unload):
813         (WebCore::PluginPackageWin::unloadWithoutShutdown):
814         * plugins/win/PluginPackageWin.h:
815         
816         * plugins/win/PluginViewWin.cpp:
817         (WebCore::PluginViewWin::~PluginViewWin):
818         Make sure to unload the plugin package and clear any references to plugin script objects.
819
820 2007-06-27  George Staikos  <staikos@kde.org>
821
822         This was succeeding compile by luck.  Setup dependencies properly.
823
824         * WebCore.pro:
825
826 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
827
828         Reviewed by John.
829
830         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
831         
832         When a quoted numbered list is broken in half, it's cloned
833         to make the second list. That second list needs its start attribute
834         set so that the numbers of the list items in it will be preserved.
835
836         * editing/BreakBlockquoteCommand.cpp:
837         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
838         of a cloned list to be the original number of the first list item in it.
839
840 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
841
842         Reviewed by Geoff.
843
844         http://bugs.webkit.org/show_bug.cgi?id=14413
845         GIF animation throttling is different from MSIE
846
847         * platform/graphics/cg/ImageSourceCG.cpp:
848         (WebCore::ImageSource::frameDurationAtIndex):
849         Change the cut-off value to 50ms to match MSIE.
850
851 2007-06-27  Sam Weinig  <sam@webkit.org>
852
853         Reviewed by Darin.
854
855         First pass at fixing implicit 64-32 bit conversion errors.
856         <rdar://problem/5292262>
857
858         - Add 'f' suffix where necessary.
859
860         * bridge/mac/WebCoreAXObject.mm:
861         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
862         * css/csshelper.h:
863         * css/cssstyleselector.cpp:
864         (WebCore::):
865         (WebCore::CSSStyleSelector::largerFontSize):
866         (WebCore::CSSStyleSelector::smallerFontSize):
867         * html/CanvasGradient.cpp:
868         (WebCore::CanvasGradient::addColorStop):
869         * html/CanvasPattern.cpp:
870         (WebCore::CanvasPattern::createPattern):
871         * ksvg2/css/SVGCSSStyleSelector.cpp:
872         (WebCore::CSSStyleSelector::applySVGProperty):
873         * ksvg2/css/SVGRenderStyle.h:
874         * ksvg2/events/SVGZoomEvent.cpp:
875         (WebCore::SVGZoomEvent::SVGZoomEvent):
876         * ksvg2/svg/SVGLength.cpp:
877         (WebCore::SVGLength::SVGLength):
878         (WebCore::SVGLength::value):
879         (WebCore::SVGLength::setValue):
880         (WebCore::SVGLength::valueAsPercentage):
881         (WebCore::SVGLength::PercentageOfViewport):
882         * ksvg2/svg/SVGSVGElement.cpp:
883         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
884         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
885         (WebCore::SVGSVGElement::getScreenCTM):
886         * ksvg2/svg/SVGTextContentElement.cpp:
887         (WebCore::SVGTextContentElement::getComputedTextLength):
888         (WebCore::SVGTextContentElement::getSubStringLength):
889         (WebCore::SVGTextContentElement::getRotationOfChar):
890         * ksvg2/svg/SVGTransformDistance.cpp:
891         (WebCore::SVGTransformDistance::SVGTransformDistance):
892         (WebCore::SVGTransformDistance::distance):
893         * page/InspectorController.cpp:
894         (WebCore::InspectorResource::InspectorResource):
895         * platform/graphics/FloatPoint3D.cpp:
896         (WebCore::FloatPoint3D::normalize):
897         * platform/graphics/Path.cpp:
898         (WebCore::pathLengthApplierFunction):
899         (WebCore::Path::createRoundedRectangle):
900         * platform/graphics/cg/GraphicsContextCG.cpp:
901         (WebCore::GraphicsContext::drawLine):
902         (WebCore::GraphicsContext::strokeArc):
903         * platform/graphics/cg/ImageCG.cpp:
904         (WebCore::FrameData::clear):
905         * platform/graphics/cg/ImageSourceCG.cpp:
906         (WebCore::ImageSource::frameDurationAtIndex):
907         * platform/graphics/cg/PDFDocumentImage.cpp:
908         (WebCore::PDFDocumentImage::setCurrentPage):
909         * platform/graphics/svg/SVGPaintServerPattern.cpp:
910         (WebCore::SVGPaintServerPattern::externalRepresentation):
911         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
912         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
913         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
914         (WebCore::cgGradientCallback):
915         (WebCore::CGShadingRefForRadialGradient):
916         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
917         * platform/mac/FontDataMac.mm:
918         (WebCore::webFallbackFontFamily):
919         * platform/mac/PopupMenuMac.mm:
920         (WebCore::PopupMenu::show):
921         * rendering/InlineFlowBox.cpp:
922         (WebCore::InlineFlowBox::placeBoxesHorizontally):
923         * rendering/RenderSlider.cpp:
924         (WebCore::RenderSlider::setValueForPosition):
925         (WebCore::RenderSlider::setPositionFromValue):
926
927 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
928
929         Reviewed by Geoff.
930
931         http://bugs.webkit.org/show_bug.cgi?id=14288
932         XMLHttpRequest doesn't use a correct content type for file:// URLs
933
934         Test: fast/dom/xmlhttprequest-html-response-encoding.html
935
936         * xml/xmlhttprequest.cpp:
937         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
938         the network layer, since it provides it even for non-HTTP responses.
939
940 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
941
942         Reviewed by Sam Weinig.
943
944         http://bugs.webkit.org/show_bug.cgi?id=14061
945         Implement more of FrameLoaderClientGdk
946
947         Make FrameLoaderClientGdk work properly when the MIME type is set.
948
949         * loader/gdk/FrameLoaderClientGdk.cpp:
950         (WebCore::FrameLoaderClientGdk::objectContentType):
951         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
952
953 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
954
955         Reviewed by Maciej.
956
957         http://bugs.webkit.org/show_bug.cgi?id=14058
958         Gdk font backend cleanup
959
960         * platform/FontData.h: Remove obsolete function.
961         * platform/gdk/FontDataGdk.cpp:
962         (WebCore::FontData::containsCharacters): Lock/unlock only once.
963         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
964         * platform/gdk/FontPlatformData.h: Remove obsolete function.
965         * platform/gdk/FontPlatformDataGdk.cpp:
966         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
967         not the pixel size.
968         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
969         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
970         (WebCore::GlyphPage::fill): Lock/unlock only once.
971
972 2007-06-26  Mitz Pettel  <mitz@webkit.org>
973
974         Reviewed by Hyatt.
975
976         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
977           <colgroup>'s borders are ignored when it has <col> children
978
979         Covered by existing tests.
980
981         * rendering/RenderTableCell.cpp:
982         (WebCore::RenderTableCell::collapsedLeftBorder):
983         (WebCore::RenderTableCell::collapsedRightBorder):
984         (WebCore::RenderTableCell::collapsedTopBorder):
985         (WebCore::RenderTableCell::collapsedBottomBorder):
986
987 2007-06-26  Mitz Pettel  <mitz@webkit.org>
988
989         Reviewed by Oliver.
990
991         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
992           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
993
994         Test: fast/repaint/text-selection-rect-in-overflow-2.html
995
996         * rendering/RenderObject.cpp:
997         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
998         for overflow scroll and columns.
999         * rendering/RenderText.cpp:
1000         (WebCore::RenderText::selectionRect): Adjust for columns only in the
1001         non-clipped case, since RenderObject::absolutePosition() does not.
1002
1003 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1004
1005         Reviewed by Sam.
1006
1007         - http://bugs.webkit.org/show_bug.cgi?id=14415
1008           Remove the unused method RenderObject::setTable()
1009
1010         * rendering/RenderObject.h:
1011
1012 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
1013
1014         Reviewed by Maciej.
1015
1016         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
1017         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
1018
1019         This change moves the bulk of ResourceRequest into a base class named
1020         ResourceRequestBase with all platform-specific bits pushed into
1021         ResourceRequest.  This allows ports to easily add new members to a
1022         ResourceRequest without having to #ifdef the code that is shared
1023         between ports.
1024
1025         * WebCore.exp:
1026         * WebCore.pro:
1027         * WebCore.vcproj/WebCore.vcproj:
1028         * WebCore.xcodeproj/project.pbxproj:
1029         * platform/network/ResourceRequest.cpp: Removed.
1030         * platform/network/ResourceRequest.h: Removed.
1031         * platform/network/ResourceRequestBase.cpp: Added.
1032         (WebCore::ResourceRequestBase::asResourceRequest):
1033         (WebCore::ResourceRequestBase::isEmpty):
1034         (WebCore::ResourceRequestBase::isNull):
1035         (WebCore::ResourceRequestBase::url):
1036         (WebCore::ResourceRequestBase::setURL):
1037         (WebCore::ResourceRequestBase::cachePolicy):
1038         (WebCore::ResourceRequestBase::setCachePolicy):
1039         (WebCore::ResourceRequestBase::timeoutInterval):
1040         (WebCore::ResourceRequestBase::setTimeoutInterval):
1041         (WebCore::ResourceRequestBase::mainDocumentURL):
1042         (WebCore::ResourceRequestBase::setMainDocumentURL):
1043         (WebCore::ResourceRequestBase::httpMethod):
1044         (WebCore::ResourceRequestBase::setHTTPMethod):
1045         (WebCore::ResourceRequestBase::httpHeaderFields):
1046         (WebCore::ResourceRequestBase::httpHeaderField):
1047         (WebCore::ResourceRequestBase::setHTTPHeaderField):
1048         (WebCore::ResourceRequestBase::httpBody):
1049         (WebCore::ResourceRequestBase::setHTTPBody):
1050         (WebCore::ResourceRequestBase::allowHTTPCookies):
1051         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
1052         (WebCore::ResourceRequestBase::addHTTPHeaderField):
1053         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
1054         (WebCore::operator==):
1055         (WebCore::ResourceRequestBase::isConditional):
1056         (WebCore::ResourceRequestBase::updatePlatformRequest):
1057         (WebCore::ResourceRequestBase::updateResourceRequest):
1058         * platform/network/ResourceRequestBase.h: Added.
1059         (WebCore::):
1060         (WebCore::ResourceRequestBase::httpContentType):
1061         (WebCore::ResourceRequestBase::setHTTPContentType):
1062         (WebCore::ResourceRequestBase::httpReferrer):
1063         (WebCore::ResourceRequestBase::setHTTPReferrer):
1064         (WebCore::ResourceRequestBase::clearHTTPReferrer):
1065         (WebCore::ResourceRequestBase::httpUserAgent):
1066         (WebCore::ResourceRequestBase::setHTTPUserAgent):
1067         (WebCore::ResourceRequestBase::httpAccept):
1068         (WebCore::ResourceRequestBase::setHTTPAccept):
1069         (WebCore::ResourceRequestBase::ResourceRequestBase):
1070         (WebCore::operator!=):
1071         * platform/network/cf/ResourceRequest.h: Added.
1072         (WebCore::ResourceRequest::ResourceRequest):
1073         * platform/network/curl/ResourceRequest.h: Added.
1074         (WebCore::ResourceRequest::ResourceRequest):
1075         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1076         (WebCore::ResourceRequest::doUpdateResourceRequest):
1077         * platform/network/mac/ResourceRequest.h: Added.
1078         (WebCore::ResourceRequest::ResourceRequest):
1079         * platform/network/qt/ResourceRequest.h: Added.
1080         (WebCore::ResourceRequest::ResourceRequest):
1081         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1082         (WebCore::ResourceRequest::doUpdateResourceRequest):
1083
1084 2007-06-26  Adam Roben  <aroben@apple.com>
1085
1086         Add ChangeLog entries from the Windows merge.
1087
1088         Reviewed by Maciej.
1089
1090         * ChangeLog:
1091
1092 2007-06-26  Sam Weinig  <sam@webkit.org>
1093
1094         Reviewed by Maciej.
1095
1096         Make sure not to enumerate the toString() function.
1097         <rdar://problem/5297118>
1098
1099         * bindings/js/kjs_window.cpp:
1100         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
1101         * html/HTMLAnchorElement.idl:
1102
1103 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1104
1105         Reviewed by Mitz, landed by Anders.
1106
1107         http://bugs.webkit.org/show_bug.cgi?id=14421
1108         Implement GraphicsContext::clearRect()
1109
1110         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1111         (WebCore::GraphicsContext::clearRect):
1112
1113 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1114
1115         Reviewed and landed by Anders.
1116
1117         http://bugs.webkit.org/show_bug.cgi?id=14416
1118         Content does not render fully in some cases
1119
1120         Fix mismatched calls to cairo_save/restore due to an early method return.
1121
1122         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1123         (WebCore::GraphicsContext::drawLine):
1124
1125 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
1126
1127         Reviewed by John Sullivan.
1128
1129         Added two accessor functions for <rdar://problem/4119138>
1130
1131         * bindings/objc/DOMHTML.mm:
1132         (-[DOMHTMLInputElement _isEdited]):
1133         (-[DOMHTMLTextAreaElement _isEdited]):
1134         Added an accessor to the isEdited value of a DOM node's render object
1135
1136         * bindings/objc/DOMPrivate.h:
1137         Added header definitions for _isEdited
1138
1139 2007-06-26  Sam Weinig  <sam@webkit.org>
1140
1141         Fix Win32 build.
1142
1143         * WebCore.vcproj/WebCore.vcproj:
1144
1145 2007-06-26  Sam Weinig  <sam@webkit.org>
1146
1147         Fix Qt and Gdk builds.
1148
1149         * WebCore.pro:
1150
1151 2007-06-26  Sam Weinig  <sam@webkit.org>
1152
1153         Reviewed by Geoff.
1154
1155         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
1156         Autogenerate Event JS binding
1157
1158         - Moves the dataTransfer method into MouseEvent where it should be.
1159
1160         * WebCore.xcodeproj/project.pbxproj:
1161         * bindings/js/JSEventCustom.cpp: Added.
1162         (WebCore::JSEvent::clipboardData):
1163         (WebCore::toJS):
1164         * bindings/js/JSEventTargetNode.cpp:
1165         * bindings/js/JSXMLHttpRequest.cpp:
1166         * bindings/js/kjs_events.cpp:
1167         * bindings/js/kjs_events.h:
1168         * bindings/objc/DOMUtility.mm:
1169         (KJS::createDOMWrapper):
1170         * bindings/scripts/CodeGeneratorJS.pm:
1171         * dom/Event.h:
1172         (WebCore::Event::returnValue):
1173         (WebCore::Event::setReturnValue):
1174         (WebCore::Event::clipboardData):
1175         * dom/Event.idl:
1176         * dom/MouseEvent.h:
1177         (WebCore::MouseEvent::dataTransfer):
1178         * dom/MouseEvent.idl:
1179
1180 2007-06-26  Timothy Hatcher  <timothy@apple.com>
1181
1182         Reviewed by Mark Rowe.
1183
1184         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1185         http://bugs.webkit.org/show_bug.cgi?id=14385
1186
1187         Correctly remember the "Show implicit properties" setting as you switch nodes.
1188
1189         * page/inspector/ResourcePanel.js:
1190
1191 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
1192
1193         Reviewed by John.
1194
1195         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
1196         
1197         Editing removed a node that was part of a search field's internal
1198         structure that should not be removed.
1199
1200         * editing/DeleteSelectionCommand.cpp:
1201         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
1202         selection to delete ends at [container, x], where x is the number
1203         of children in container, don't remove container.  Special case
1204         code elsewhere in this function will remove it if necessary.
1205
1206 2007-06-25  Sam Weinig  <sam@webkit.org>
1207
1208         Reviewed by Maciej.
1209
1210         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
1211         Mutating document.constructor.prototype mutates Object.prototype
1212
1213         Test: fast/js/constructor.html
1214
1215         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
1216         classes with constructors.  It is an non-enumeratable, non-deletable,
1217         readonly attribute.
1218
1219 2007-06-26  George Staikos  <staikos@kde.org>
1220
1221         Repair the OS X build.
1222
1223         * WebCore.exp:
1224
1225 2007-06-26  Adam Treat  <adam@staikos.net>
1226
1227         Reviewed by Adam Roben.
1228
1229         Make the SQLite icon database optional.
1230
1231         * loader/icon/IconDatabase.cpp:
1232         (WebCore::IconDatabase::isOpen):
1233         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
1234         (WebCore::IconDatabase::enabled):
1235         * loader/icon/IconDatabase.h:
1236
1237 2007-06-25  Sam Weinig  <sam@webkit.org>
1238
1239         Reviewed by Adam Roben.
1240
1241         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
1242         HTML syntax highlighting colors and DOM tree colors should be the same
1243
1244         * css/view-source.css:
1245         * page/inspector/ResourcePanel.js:
1246         * page/inspector/inspector.css:
1247         * page/inspector/inspector.js:
1248         * page/inspector/utilities.js:
1249
1250 2007-06-25  Adam Roben  <aroben@apple.com>
1251
1252         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
1253         http://bugs.webkit.org/show_bug.cgi?id=14402
1254
1255         The solution was to make KURL::lastPathComponent ignore trailing
1256         slashes, which is what -[NSURL lastPathComponent] does, too.
1257
1258         Reviewed by Oliver.
1259
1260         * platform/KURL.cpp:
1261         (WebCore::KURL::lastPathComponent):
1262
1263 2007-06-25  Sam Weinig  <sam@webkit.org>
1264
1265         Reviewed by Adam Roben.
1266
1267         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
1268         Web Inspector lists favicon.ico as "other" instead of "image"
1269
1270         * page/InspectorController.cpp:
1271         (WebCore::InspectorResource::type):
1272
1273 2007-06-25  Adele Peterson  <adele@apple.com>
1274
1275         Reviewed by Hyatt.
1276
1277         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
1278         http://bugs.webkit.org/show_bug.cgi?id=14297
1279
1280         Test: fast/overflow/hidden-scrollbar-resize.html
1281
1282         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
1283         Updated our shouldPaint check to consider visibility.
1284
1285 2007-06-25  Oliver Hunt  <oliver@apple.com>
1286
1287         Reviewed by Darin.
1288
1289         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
1290
1291         Fixing logic error in DragController
1292
1293         * manual-tests/drop-text-acquires-style.html: Added.
1294         * page/DragController.cpp:
1295         (WebCore::documentFragmentFromDragData):
1296
1297 2007-06-25  Sam Weinig  <sam@webkit.org>
1298
1299         Reviewed by Adam Roben.
1300
1301         Annotate prototypes by adding "Prototype" subtitle.
1302
1303         * page/inspector/ResourcePanel.js:
1304
1305 2007-06-25  George Staikos  <staikos@kde.org>
1306
1307         Reviewed by Zack.
1308
1309         Start to add proxy and SSL support to WebKitQt.  Proxying works.
1310
1311         * platform/network/ResourceHandleInternal.h:
1312         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1313         * platform/network/qt/ResourceHandleQt.cpp:
1314         (WebCore::ResourceHandle::start):
1315
1316 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1317
1318         Reviewed by Adam Roben.
1319
1320         http://bugs.webkit.org/show_bug.cgi?id=14386
1321         Gdk build fix
1322
1323         * WebCore.pro: Fix gtk/gdk typo.
1324
1325 2007-06-25  Timothy Hatcher  <timothy@apple.com>
1326
1327         Reviewed by Anders.
1328
1329         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1330         http://bugs.webkit.org/show_bug.cgi?id=14385
1331
1332         Add a toggle to show implict computed properties.
1333
1334         * page/inspector/ResourcePanel.js:
1335         * page/inspector/inspector.css:
1336         * page/inspector/inspector.js:
1337
1338 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1339
1340         Reviewed by Mark.
1341
1342         http://bugs.webkit.org/show_bug.cgi?id=13975
1343         Use system-provided libjpeg and libpng
1344
1345         * WebCore.pro: Remove bundled libjpeg and libpng sources.
1346         * platform/image-decoders/jpeg: Remove sources.
1347         * platform/image-decoders/png: Remove sources.
1348
1349 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1350
1351         Reviewed by Darin.
1352
1353         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
1354           Table caption renders too narrow sometimes
1355
1356         Test: fast/table/caption-relayout.html
1357
1358         * rendering/RenderTable.cpp:
1359         (WebCore::RenderTable::layout): Mark the caption for layout if the table
1360         width changed.
1361
1362 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1363
1364         Reviewed by Darin.
1365
1366         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
1367           Underline painted under <br>, not repainted properly
1368
1369         Test: fast/inline/br-text-decoration.html
1370
1371         * platform/graphics/cg/GraphicsContextCG.cpp:
1372         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
1373         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
1374         than their thickness paint correctly.
1375
1376 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1377
1378         Reviewed by Maciej.
1379
1380         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
1381           rules="none" ignored in certain cases
1382
1383         Covered by existing tests.
1384
1385         * html/HTMLTableElement.cpp:
1386         (WebCore::HTMLTableElement::getSharedCellDecl):
1387
1388 2007-06-24  Sam Weinig  <sam@webkit.org>
1389
1390         Reviewed by Mitz.
1391
1392         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
1393         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
1394
1395         * page/inspector/ResourcePanel.js: make sure not to call an overriden
1396         toString() by using Object.prototype.toString.call().
1397
1398 2007-06-24  Adam Roben  <aroben@apple.com>
1399
1400         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
1401         Bug 14374: Computed Style section should be expanded by default
1402
1403         Reviewed by Sam.
1404
1405         No regression test possible.
1406
1407         * page/inspector/ResourcePanel.js: Expand all style sections.
1408
1409 2007-06-24  Adam Roben  <aroben@apple.com>
1410
1411         Unify the style of enums in the Inspector JS
1412
1413         All our enums are now represented by an object with a property for
1414         each enum value.
1415
1416         Reviewed by Sam.
1417
1418         No regression test possible.
1419
1420         * page/inspector/ConsolePanel.js:
1421         * page/inspector/Resource.js:
1422         * page/inspector/ResourcePanel.js:
1423         * page/inspector/inspector.js:
1424
1425 2007-06-23  Sam Weinig  <sam@webkit.org>
1426
1427         Reviewed by Mitz.
1428
1429         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
1430         getComputedStyle(...).zIndex returns string "normal"
1431
1432         Test: fast/css/getComputedStyle-zIndex-auto.html
1433
1434         * css/CSSComputedStyleDeclaration.cpp:
1435         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
1436
1437 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
1438
1439         Reviewed by Tim Hatcher.
1440
1441         Bug 14265: Cannot resize columns in webinspector
1442         http://bugs.webkit.org/show_bug.cgi?id=14265
1443
1444         * page/inspector/inspector.css:
1445         * page/inspector/inspector.html:
1446         * page/inspector/inspector.js:
1447
1448 2007-06-23  Adam Roben  <aroben@apple.com>
1449
1450         Silence a build warning about not finding `num-cpus`
1451
1452         Reviewed by Mark Rowe.
1453
1454         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
1455         location.
1456
1457 2007-06-22  Anders Carlsson  <andersca@apple.com>
1458
1459         Reviewed by Darin.
1460
1461         * plugins/win/PluginStreamWin.cpp:
1462         (WebCore::PluginStreamWin::didFinishLoading):
1463         No need to fetch the size from resourceData.
1464
1465 2007-06-22  Anders Carlsson  <andersca@apple.com>
1466
1467         Reviewed by Darin.
1468
1469         <rdar://problem/5288617>
1470         Crash playing a very large QuickTime movie inside Safari.
1471
1472         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
1473         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
1474         
1475         * plugins/win/PluginStreamWin.cpp:
1476         (WebCore::PluginStreamWin::PluginStreamWin):
1477         (WebCore::PluginStreamWin::~PluginStreamWin):
1478         (WebCore::PluginStreamWin::didReceiveData):
1479         (WebCore::PluginStreamWin::didFinishLoading):
1480         * plugins/win/PluginStreamWin.h:
1481
1482 2007-06-22  Beth Dakin  <bdakin@apple.com>
1483
1484         Reviewed by Oliver and Darin.
1485
1486         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
1487         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
1488
1489         We already have code that tries to prevent allocating too-large 
1490         rowspans. The rowspan in this test, however, was small enough that 
1491         we thought it was okay in that code, even though clearly it was 
1492         still too large. I did a bunch of testing in Firefox, and it seems 
1493         that they set a hard limit on the maximum rowspan right in the DOM 
1494         -- 8k. So that is what this patch implements. 
1495
1496         * html/HTMLTableCellElement.cpp:
1497         (WebCore::HTMLTableCellElement::parseMappedAttribute):
1498
1499 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
1500
1501         Reviewed by Darin.
1502         
1503         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
1504         
1505         Deletion inserts a placeholder after it removes full paragraphs if
1506         one doesn't already exist.  The code that looked for a pre-existing
1507         placeholder didn't work because of a bug in enclosingNodeOfType.
1508
1509         * editing/htmlediting.cpp:
1510         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
1511         but don't go above an editing root.
1512
1513 2007-06-22  Anders Carlsson  <andersca@apple.com>
1514
1515         Reviewed by Maciej and Geoff.
1516
1517         <rdar://problem/5244734>
1518         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
1519         
1520         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
1521         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
1522         argument to a bunch of classes).
1523         
1524         * loader/Cache.cpp:
1525         (WebCore::createResource):
1526         (WebCore::Cache::requestResource):
1527         * loader/Cache.h:
1528         * loader/CachedCSSStyleSheet.cpp:
1529         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1530         * loader/CachedCSSStyleSheet.h:
1531         * loader/CachedResource.cpp:
1532         (WebCore::CachedResource::CachedResource):
1533         * loader/CachedResource.h:
1534         (WebCore::CachedResource::sendResourceLoadCallbacks):
1535         * loader/DocLoader.cpp:
1536         (WebCore::DocLoader::requestCSSStyleSheet):
1537         (WebCore::DocLoader::requestResource):
1538         (WebCore::DocLoader::checkCacheObjectStatus):
1539         * loader/DocLoader.h:
1540         * loader/MainResourceLoader.cpp:
1541         (WebCore::MainResourceLoader::MainResourceLoader):
1542         * loader/Request.cpp:
1543         (WebCore::Request::Request):
1544         * loader/Request.h:
1545         (WebCore::Request::sendResourceLoadCallbacks):
1546         * loader/ResourceLoader.cpp:
1547         (WebCore::ResourceLoader::ResourceLoader):
1548         (WebCore::ResourceLoader::willSendRequest):
1549         (WebCore::ResourceLoader::didReceiveResponse):
1550         (WebCore::ResourceLoader::didReceiveData):
1551         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1552         (WebCore::ResourceLoader::didFail):
1553         (WebCore::ResourceLoader::didCancel):
1554         * loader/ResourceLoader.h:
1555         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
1556         * loader/SubresourceLoader.cpp:
1557         (WebCore::SubresourceLoader::SubresourceLoader):
1558         (WebCore::SubresourceLoader::create):
1559         * loader/SubresourceLoader.h:
1560         * loader/loader.cpp:
1561         (WebCore::Loader::load):
1562         (WebCore::Loader::servePendingRequests):
1563         * loader/loader.h:
1564         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1565         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1566
1567 2007-06-21  Richard Connamacher  <rich@indieimage.com>
1568
1569         Reviewed by Tim Hatcher.
1570
1571         Bug 14305: Web Inspector marks local files with server-side compression tip
1572         http://bugs.webkit.org/show_bug.cgi?id=14305
1573
1574         * page/inspector/Resource.js:
1575         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
1576         from being given to local files
1577
1578 2007-06-21  Mark Rowe  <mrowe@apple.com>
1579
1580         Reviewed by Darin.
1581
1582         Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
1583
1584         * platform/StringImpl.cpp:
1585         (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
1586         a length of zero when the string is collapsed to empty by whitespace simplification.
1587
1588 2007-06-21  Dave Hyatt  <hyatt@apple.com>
1589
1590         Fix for <rdar://problem/5286978>, large font sizes crash Windows.
1591         
1592         Limit the maximum font size to 1,000,000 to avoid crashes and issues with platforms that
1593         start failing to do anything useful if the font size is too big.
1594         
1595         Reviewed by olliej
1596
1597         * css/cssstyleselector.cpp:
1598         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
1599         
1600 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1601
1602         Reviewed by Timothy.
1603
1604         Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
1605
1606         * page/inspector/inspector.css: Set body margin to 0
1607
1608 2007-06-21  Adam Treat  <adam@staikos.net>
1609
1610         Reviewed by George Staikos.
1611
1612         Implement the default resources on Qt.
1613
1614         * platform/graphics/BitmapImage.h:
1615         * platform/graphics/Image.h:
1616         * platform/graphics/qt/ImageQt.cpp:
1617         (WebCore::Image::loadPlatformResource):
1618         (WebCore::BitmapImage::BitmapImage):
1619         (WebCore::BitmapImage::initPlatformData):
1620         (WebCore::BitmapImage::invalidatePlatformData):
1621         (WebCore::BitmapImage::getPixmap):
1622         * platform/qt/TemporaryLinkStubs.cpp:
1623
1624 2007-06-21  Oliver Hunt  <oliver@apple.com>
1625
1626         Reviewed by Darin.
1627
1628         Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
1629         and makes reference handling simpler in advance of IME refactoring.
1630
1631         * WebCore.xcodeproj/project.pbxproj:
1632         * page/mac/EventHandlerMac.mm:
1633         (WebCore::currentEvent):
1634         (WebCore::EventHandler::currentNSEvent):
1635         (WebCore::EventHandler::wheelEvent):
1636         (WebCore::EventHandler::keyEvent):
1637         (WebCore::lastEventIsMouseUp):
1638         (WebCore::EventHandler::passMouseDownEventToWidget):
1639         (WebCore::EventHandler::eventLoopHandleMouseDragged):
1640         (WebCore::EventHandler::eventLoopHandleMouseUp):
1641         (WebCore::EventHandler::passSubframeEventToSubframe):
1642         (WebCore::EventHandler::passWheelEventToWidget):
1643         (WebCore::EventHandler::mouseDown):
1644         (WebCore::EventHandler::mouseDragged):
1645         (WebCore::EventHandler::mouseUp):
1646         (WebCore::EventHandler::mouseMoved):
1647
1648 2007-06-21  George Staikos  <staikos@kde.org>
1649
1650         Reviewed by George & Marius.
1651
1652         Patch by me, revision by Marius, minor rev by me.  Adds rendered
1653         and stylable scrollbars.
1654
1655         * page/qt/EventHandlerQt.cpp:
1656         (WebCore::EventHandler::passMousePressEventToScrollbar):
1657         * platform/Widget.h:
1658         * platform/qt/PlatformScrollBar.h:
1659         (WebCore::PlatformScrollbar::isWidget):
1660         * platform/qt/PlatformScrollBarQt.cpp:
1661         (WebCore::PlatformScrollbar::PlatformScrollbar):
1662         (WebCore::PlatformScrollbar::~PlatformScrollbar):
1663         (WebCore::PlatformScrollbar::updateThumbPosition):
1664         (WebCore::PlatformScrollbar::updateThumbProportion):
1665         (WebCore::PlatformScrollbar::width):
1666         (WebCore::PlatformScrollbar::height):
1667         (WebCore::PlatformScrollbar::setRect):
1668         (WebCore::PlatformScrollbar::isEnabled):
1669         (WebCore::PlatformScrollbar::setEnabled):
1670         (WebCore::PlatformScrollbar::paint):
1671         (WebCore::PlatformScrollbar::thumbPosition):
1672         (WebCore::PlatformScrollbar::thumbLength):
1673         (WebCore::PlatformScrollbar::trackLength):
1674         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
1675         (WebCore::PlatformScrollbar::handleMouseOutEvent):
1676         (WebCore::PlatformScrollbar::handleMousePressEvent):
1677         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
1678         (WebCore::PlatformScrollbar::startTimerIfNeeded):
1679         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
1680         (WebCore::PlatformScrollbar::autoscrollPressedPart):
1681         (WebCore::PlatformScrollbar::autoscrollTimerFired):
1682         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
1683         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
1684         (WebCore::PlatformScrollbar::thumbUnderMouse):
1685         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
1686         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
1687         (WebCore::PlatformScrollbar::windowClipRect):
1688         * platform/qt/ScrollViewQt.cpp:
1689         (WebCore::ScrollView::addChild):
1690         (WebCore::ScrollView::removeChild):
1691         * platform/qt/WidgetQt.cpp:
1692         (WebCore::WidgetPrivate::WidgetPrivate):
1693         (WebCore::Widget::setQWidget):
1694         (WebCore::Widget::invalidate):
1695         (WebCore::Widget::invalidateRect):
1696         (WebCore::Widget::setParent):
1697         (WebCore::Widget::parent):
1698
1699 2007-06-21  Geoffrey Garen  <ggaren@apple.com>
1700
1701         Reviewed by Dave Hyatt.
1702         
1703         Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
1704         REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML 
1705         effects when clicking on its links (12646)
1706         
1707         I'm rolling our r7703 for these reasons:
1708
1709         1. It broke RapidWeaver.
1710         
1711         2. WebKit is now orders of magnitude faster when handling deep nesting
1712         (5 seconds vs 3 minutes on my MBP in this particular case).
1713
1714         3. Firefox, IE, and HTML5 all allow nested heading tags.
1715         
1716         4. Hyatt said so.
1717
1718         * html/HTMLParser.cpp:
1719         (WebCore::HTMLParser::parseToken):
1720
1721 2007-06-21  Sam Weinig  <sam@webkit.org>
1722
1723         Reviewed by Tim Hatcher.
1724
1725         http://bugs.webkit.org/show_bug.cgi?id=14260
1726         ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page
1727
1728         Remove assert for now as it is causing the back button to not
1729         work in debug builds.
1730
1731         * page/InspectorController.cpp:
1732         (WebCore::InspectorController::didCommitLoad):
1733
1734 2007-06-21  Lars Knoll <lars@trolltech.com>
1735
1736         Remove some debug output.
1737
1738         * platform/qt/FontQt.cpp:
1739         (WebCore::generateComponents):
1740         (WebCore::Font::width):
1741
1742 2007-06-21  George Staikos  <staikos@kde.org>
1743
1744         Repair Qt/Mac OS X build.
1745
1746         * WebCore.pro:
1747
1748 2007-06-21  Alexey Proskuryakov  <ap@webkit.org>
1749
1750         Reviewed by Anders.
1751
1752         http://bugs.webkit.org/show_bug.cgi?id=13905
1753         REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
1754
1755         Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
1756         (regardless of the actual response MIME type). This was corrected a while ago to match other 
1757         browsers and the draft XHR spec.
1758
1759         Now restoring this functionality for "text/html", with spec editor's blessing.
1760
1761         * xml/xmlhttprequest.cpp:
1762         (WebCore::XMLHttpRequest::responseMIMEType):
1763         (WebCore::XMLHttpRequest::responseIsXML):
1764         (WebCore::XMLHttpRequest::didReceiveData):
1765         * xml/xmlhttprequest.h:
1766
1767 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1768
1769         Mac build fix.
1770
1771         * platform/Font.h:
1772
1773 2007-06-21  Lars Knoll  <lars@trolltech.com>
1774
1775         Reviewed by Simon.
1776
1777         another small fix for letter spacing
1778
1779         * platform/qt/FontQt.cpp:
1780         (WebCore::generateComponents):
1781
1782 2007-06-21  Lars Knoll  <lars@trolltech.com>
1783
1784         Reviewed by Simon.
1785
1786         fix word-spacing
1787
1788         * platform/qt/FontQt.cpp:
1789         (WebCore::generateComponents):
1790         (WebCore::Font::width):
1791
1792 2007-06-21  Lars Knoll  <lars@trolltech.com>
1793
1794         Reviewed by Simon.
1795
1796         fix letterspacing and small caps.
1797
1798         * platform/Font.h:
1799         * platform/graphics/qt/GraphicsContextQt.cpp:
1800         (WebCore::GraphicsContext::setPlatformFont):
1801         * platform/qt/FileChooserQt.cpp:
1802         * platform/qt/FontQt.cpp:
1803         (WebCore::TextRunComponent::TextRunComponent):
1804         (WebCore::Font::Font):
1805         (WebCore::Font::operator=):
1806         (WebCore::Font::update):
1807         (WebCore::generateComponents):
1808         (WebCore::Font::selectionRectForText):
1809         * platform/qt/RenderThemeQt.cpp:
1810
1811 2007-06-21  Lars Knoll  <lars@trolltech.com>
1812
1813         Reviewed by Simon.
1814
1815         store the metrics and space width in the Font object
1816
1817         * platform/Font.h:
1818         * platform/qt/FontQt.cpp:
1819         (WebCore::Font::Font):
1820         (WebCore::Font::drawText):
1821         (WebCore::Font::width):
1822         (WebCore::Font::isFixedPitch):
1823         (WebCore::Font::ascent):
1824         (WebCore::Font::descent):
1825         (WebCore::Font::lineSpacing):
1826
1827 2007-06-21  Lars Knoll  <lars@trolltech.com>
1828
1829         Reviewed by Simon.
1830
1831         simplify some codepaths
1832
1833         * platform/qt/FontQt.cpp:
1834         (WebCore::Font::drawText):
1835         (WebCore::Font::width):
1836
1837 2007-06-21  Lars Knoll  <lars@trolltech.com>
1838
1839         Reviewed by Simon.
1840
1841         fix copyright header
1842
1843         * platform/qt/FontQt.cpp:
1844
1845 2007-06-21  Lars Knoll  <lars@trolltech.com>
1846
1847         Reviewed by Simon.
1848
1849         correctly load fonts when a list of font families is given
1850
1851         * platform/qt/FontQt.cpp:
1852         (WebCore::Font::Font):
1853
1854 2007-06-21  Lars Knoll  <lars@trolltech.com>
1855
1856         Reviewed by Simon.
1857
1858         fix some more of the font support
1859
1860         * platform/qt/FontQt.cpp:
1861         (WebCore::Font::drawText):
1862         (WebCore::Font::width):
1863
1864 2007-06-21  Lars Knoll  <lars@trolltech.com>
1865
1866         Reviewed by Simon.
1867
1868         Compile fixes
1869
1870         * platform/Font.h:
1871         (WebCore::Font::isRoundingHackCharacter):
1872         * platform/qt/FontQt.cpp:
1873         (WebCore::Font::drawText):
1874
1875 2007-06-21  Lars Knoll  <lars@trolltech.com>
1876
1877         Reviewed by Simon.
1878
1879         Some more work on the implementation of FontQt.
1880
1881         * platform/qt/FontQt.cpp:
1882         (WebCore::Font::Font):
1883         (WebCore::Font::~Font):
1884         (WebCore::Font::operator=):
1885
1886 2007-06-21  Lars Knoll  <lars@trolltech.com>
1887
1888         Reviewed by Simon.
1889
1890         Started work on the new font infrastructure for the Qt port.
1891
1892         * WebCore.pro:
1893         * editing/Editor.cpp:
1894         (WebCore::Editor::fontForSelection):
1895         * platform/Font.h:
1896         (WebCore::Font::treatAsSpace):
1897         (WebCore::Font::treatAsZeroWidthSpace):
1898         (WebCore::Font::isRoundingHackCharacter):
1899         * platform/qt/FontQt.cpp:
1900         (WebCore::Font::operator QFont):
1901         * platform/qt/TemporaryLinkStubs.cpp:
1902
1903 2007-06-21  Adam Roben  <aroben@apple.com>
1904
1905         More Gdk build fixes.
1906
1907         * page/gdk/ContextMenuClientGdk.cpp:
1908         (WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
1909         * page/gdk/ContextMenuClientGdk.h:
1910         * platform/gdk/TemporaryLinkStubs.cpp:
1911
1912 2007-06-21  Adam Roben  <aroben@apple.com>
1913
1914         Speculative Gdk build fix.
1915
1916         * page/InspectorController.h: Only include the JS headers we really
1917         need to avoid pulling in ones like JSStringRefCF.h.
1918
1919 2007-06-20  Adam Roben  <aroben@apple.com>
1920
1921         Speculative Gdk build fix.
1922
1923         * WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
1924
1925 2007-06-20  Adam Roben  <aroben@apple.com>
1926
1927         Windows build fix.
1928
1929         * WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
1930         everything but $WebKitLibrariesDir so that we will pick up
1931         JavaScriptCore headers directly.
1932
1933 2007-06-15  George Staikos  <staikos@kde.org>
1934
1935         Add missing symbol.
1936
1937         * platform/qt/TemporaryLinkStubs.cpp:
1938         (WebCore::contextMenuItemTagInspectElement):
1939
1940 2007-06-20  Steve Falkenburg  <sfalken@apple.com>
1941
1942         Reviewed by Maciej, Anders.
1943         
1944         <rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/
1945
1946         Keep a reference to the Page (via the main frame) for the
1947         load deferred pages.
1948         
1949         Reference is held via the frame since Page isn't refcounted.
1950
1951         * page/Chrome.cpp:
1952         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1953         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1954
1955 2007-06-15  Adam Treat <adam@staikos.net>
1956
1957         Reviewed by George Staikos.
1958
1959         Add ICO support to the Qt build.
1960
1961         * WebCore.pro:
1962         * platform/graphics/qt/ImageDecoderQt.cpp:
1963         (Q_IMPORT_PLUGIN):
1964
1965 2007-06-15  George Staikos  <staikos@kde.org>
1966
1967         Fixing Qt build.
1968
1969         * ForwardingHeaders/JavaScriptCore/APICast.h: Added.
1970         * WebCore.pro:
1971         * page/InspectorController.h:
1972
1973 2007-06-20  Adam Roben  <aroben@apple.com>
1974
1975         More speculative Qt/Gdk build fixes.
1976
1977         * WebCore.pro: Add new files.
1978
1979 2007-06-20  Adam Roben  <aroben@apple.com>
1980
1981         Speculative Qt/Gdk build fix.
1982
1983         Added forwarding headers for JavaScriptCore. We may eventually move
1984         InspectorController off of the JSC API, but for now this is the
1985         quickest way to a working build.
1986
1987         * ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
1988         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
1989         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
1990         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
1991         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
1992         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
1993         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
1994
1995 2007-06-20  Sam Weinig  <sam@webkit.org>
1996
1997         Rubber stamped by Adam Roben.
1998
1999         Add licenses.
2000
2001         * page/inspector/ConsolePanel.js:
2002         * page/inspector/NetworkPanel.js:
2003         * page/inspector/Resource.js:
2004         * page/inspector/ResourceCategory.js:
2005         * page/inspector/ResourcePanel.js:
2006
2007 2007-06-20  Mark Rowe  <mrowe@apple.com>
2008
2009         Reviewed by Adam.
2010
2011         * WebCore.exp: Export InspectorController::inspect so WebKit can see it.
2012
2013 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
2014
2015         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
2016
2017         Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
2018         Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
2019         returning nil instead of "")
2020
2021         I'm basically rolling out the change for <rdar://problem/4782422> because
2022         my testing shows that it was backwards.
2023         
2024         * html/HTMLElement.cpp:
2025         (dumpInnerHTML): New debug-only function to work around gdb being 
2026         perpetually suck-tastic.
2027
2028         * page/mac/WebCoreFrameBridge.mm:
2029         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2030         
2031         Return "", not nil. This function never used to return nil, so let's not
2032         start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
2033
2034 2007-06-20  Adam Roben  <aroben@apple.com>
2035
2036         Addressed some of Geoff's comments.
2037
2038         * page/ContextMenuController.cpp:
2039         (WebCore::ContextMenuController::handleContextMenuEvent): Added a
2040         FIXME.
2041         * platform/ContextMenu.cpp:
2042         (WebCore::ContextMenu::addInspectElementItem): Null-check
2043         frame->page().
2044
2045 2007-06-20  Adam Roben  <aroben@apple.com>
2046
2047         Fix crash in fast/dom/dir-no-body.html
2048
2049         Reviewed by Mark.
2050
2051         * html/HTMLDocument.cpp:
2052         (WebCore::HTMLDocument::createTokenizer): Don't assume we have a
2053         Frame, since we won't if someone creates an HTMLDocument from JS.
2054
2055 2007-06-20  Adam Roben  <aroben@apple.com>
2056
2057         Land the new Inspector.
2058
2059         Co-written with Tim Hatcher.
2060
2061         Reviewed by Anders, Adele, Hyatt, and Sam.
2062
2063         No regression tests possible.
2064
2065         Add a new InspectorController that is in charge of the Inspector. It
2066         has an InspectorClient that controls the Inspector's window and node
2067         highlight.
2068
2069         * page/InspectorClient.h: Added.
2070         (WebCore::InspectorClient::~InspectorClient):
2071         * page/InspectorController.cpp: Added.
2072         (WebCore::ConsoleMessage::ConsoleMessage):
2073         (WebCore::InspectorResource::): Represents a single resource that the
2074         Inspector knows about.
2075         (WebCore::InspectorResource::InspectorResource):
2076         (WebCore::InspectorResource::~InspectorResource):
2077         (WebCore::InspectorResource::type):
2078         (WebCore::InspectorResource::setScriptObject):
2079         (WebCore::addSourceToFrame): Callback available from JS.
2080         (WebCore::getResourceDocumentNode): Ditto.
2081         (WebCore::highlightDOMNode): Ditto.
2082         (WebCore::hideDOMNodeHighlight): Ditto.
2083         (WebCore::loaded): Ditto.
2084         (WebCore::unloading): Ditto.
2085         (WebCore::attach): Ditto.
2086         (WebCore::detach): Ditto.
2087         (WebCore::log): Ditto.
2088         (WebCore::search): Ditto.
2089         (WebCore::inspectedWindow): Ditto.
2090         (WebCore::InspectorController::InspectorController):
2091         (WebCore::InspectorController::~InspectorController):
2092         (WebCore::InspectorController::inspect): Called by
2093         ContextMenuController to inspect a node.
2094         (WebCore::InspectorController::focusNode):
2095         (WebCore::InspectorController::highlight):
2096         (WebCore::InspectorController::hideHighlight):
2097         (WebCore::InspectorController::windowVisible):
2098         (WebCore::InspectorController::setWindowVisible):
2099         (WebCore::InspectorController::addMessageToConsole):
2100         (WebCore::InspectorController::attachWindow):
2101         (WebCore::InspectorController::detachWindow):
2102         (WebCore::InspectorController::windowScriptObjectAvailable):
2103         (WebCore::InspectorController::scriptObjectReady):
2104         (WebCore::InspectorController::windowUnloading):
2105         (WebCore::addHeaders): Static helper function.
2106         (WebCore::objectForRequest): Ditto.
2107         (WebCore::objectForResponse): Ditto.
2108         (WebCore::InspectorController::addScriptResource):
2109         (WebCore::InspectorController::addAndUpdateScriptResource):
2110         (WebCore::InspectorController::removeScriptResource):
2111         (WebCore::InspectorController::updateScriptResource):
2112         (WebCore::InspectorController::populateScriptResources):
2113         (WebCore::InspectorController::addScriptConsoleMessage):
2114         (WebCore::callClearFunction): Static helper function.
2115         (WebCore::InspectorController::clearScriptResources):
2116         (WebCore::InspectorController::clearScriptConsoleMessages):
2117         (WebCore::InspectorController::clearNetworkTimeline):
2118         (WebCore::InspectorController::pruneResources):
2119         (WebCore::InspectorController::didCommitLoad): Callback from
2120         FrameLoader.
2121         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
2122         (WebCore::InspectorController::addResource): Ditto.
2123         (WebCore::InspectorController::removeResource): Ditto.
2124         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
2125         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
2126         (WebCore::InspectorController::willSendRequest): Ditto.
2127         (WebCore::InspectorController::didReceiveResponse): Ditto.
2128         (WebCore::InspectorController::didReceiveContentLength): Ditto.
2129         (WebCore::InspectorController::didFinishLoading): Ditto.
2130         (WebCore::InspectorController::didFailLoading): Ditto.
2131         * page/InspectorController.h: Added.
2132         (WebCore::InspectorController::inspectedPage):
2133         (WebCore::InspectorController::scriptContext):
2134         (WebCore::InspectorController::setScriptContext):
2135         (WebCore::InspectorController::resources):
2136         (WebCore::InspectorController::removeAllResources):
2137
2138         Add the JavaScript that defines most of the behavior of the Inspector.
2139         
2140         * page/inspector/ConsolePanel.js: Added.
2141         * page/inspector/NetworkPanel.js: Added.
2142         * page/inspector/Resource.js: Added.
2143         * page/inspector/ResourceCategory.js: Added.
2144         * page/inspector/ResourcePanel.js: Added.
2145         * page/inspector/inspector.js: Added.
2146         * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
2147         * page/inspector/utilities.js: Added.
2148
2149         Add the Inspector's CSS and HTML.
2150
2151         * page/inspector/inspector.css: Added.
2152         * page/inspector/inspector.html: Added.
2153
2154         Hang the InspectorController off of Page. We only create an
2155         InspectorController if an InspectorClient is given to the Page.
2156
2157         * page/Page.cpp:
2158         (WebCore::Page::Page):
2159         * page/Page.h:
2160         (WebCore::Page::inspectorController):
2161
2162         Use FrameLoader to notify the InspectorController of resource loads.
2163
2164         * loader/FrameLoader.cpp:
2165         (WebCore::FrameLoader::begin):
2166         (WebCore::FrameLoader::transitionToCommitted):
2167         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
2168         (WebCore::FrameLoader::detachFromParent):
2169         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
2170         (WebCore::FrameLoader::willSendRequest):
2171         (WebCore::FrameLoader::didReceiveResponse):
2172         (WebCore::FrameLoader::didReceiveData):
2173         (WebCore::FrameLoader::sendRemainingDelegateMessages):
2174         (WebCore::FrameLoader::requestFromDelegate):
2175         (WebCore::FrameLoader::didFinishLoad):
2176         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
2177         (WebCore::FrameLoader::dispatchDidCommitLoad):
2178         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
2179         (WebCore::FrameLoader::dispatchWillSendRequest):
2180         (WebCore::FrameLoader::dispatchDidReceiveResponse):
2181         (WebCore::FrameLoader::dispatchDidReceiveContentLength):
2182         (WebCore::FrameLoader::dispatchDidFinishLoading):
2183         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
2184         * loader/FrameLoader.h:
2185
2186         Send console messages to the InspectorController.
2187
2188         * page/Chrome.cpp:
2189         (WebCore::Chrome::addMessageToConsole): Send all console messages to
2190         the InspectorController.
2191         * page/Chrome.h: Add a new MessageLevel and MessageSource that are
2192         used in the Inspector JS.
2193
2194         Report HTML errors when the Inspector window is open.
2195         We don't report errors when the window is closed because we don't want
2196         to slow down the HTMLTokenizer.
2197
2198         * html/HTMLDocument.cpp:
2199         (WebCore::HTMLDocument::createTokenizer):
2200         * html/HTMLParser.cpp:
2201         (WebCore::HTMLParser::HTMLParser):
2202         * html/HTMLParser.h:
2203         * html/HTMLTokenizer.cpp:
2204         (WebCore::HTMLTokenizer::HTMLTokenizer):
2205         * html/HTMLTokenizer.h:
2206
2207         Append the "Inspect Element" context menu item after passing the
2208         context menu to the ContextMenuClient. This work used to be done in
2209         WebKit.
2210
2211         * page/ContextMenuClient.h:
2212         * page/ContextMenuController.cpp:
2213         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
2214         "Inspect Element" item.
2215         (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
2216         "Inspect Element" item.
2217         * platform/ContextMenu.cpp:
2218         (WebCore::ContextMenu::addInspectElementItem):
2219         (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
2220         Element" item.
2221         * platform/ContextMenu.h:
2222         * platform/ContextMenuItem.h:
2223         (WebCore::): Add ContextMenuItemTagInspectElement.
2224         * platform/graphics/svg/SVGImageEmptyClients.h:
2225         * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
2226         string.
2227         * platform/LocalizedStrings.h: Ditto.
2228         * platform/mac/LocalizedStringsMac.mm:
2229         (WebCore::contextMenuItemTagInspectElement): Ditto.
2230
2231         Miscellaneous changes:
2232
2233         * css/view-source.css: Add message bubble styles.
2234         * loader/DocumentLoader.h: Add a frame getter.
2235         * platform/win/ScrollViewWin.cpp:
2236         (WebCore::ScrollView::updateScrollbars): Respect
2237         Frame::prohibitsScrolling.
2238
2239         Add new images needed for the Inspector.
2240
2241         * page/inspector/Images/attachedShadow.png: Added.
2242         * page/inspector/Images/bottomShadow.png: Added.
2243         * page/inspector/Images/breadcrumbBackground.png: Added.
2244         * page/inspector/Images/checker.png: Added.
2245         * page/inspector/Images/console.png: Added.
2246         * page/inspector/Images/darkShadow.png: Added.
2247         * page/inspector/Images/disclosureDownPressed.png: Added.
2248         * page/inspector/Images/disclosureRightDown.png: Added.
2249         * page/inspector/Images/disclosureRightPressed.png: Added.
2250         * page/inspector/Images/document.png: Added.
2251         * page/inspector/Images/domViewButton.png: Added.
2252         * page/inspector/Images/domViewButtonSelected.png: Added.
2253         * page/inspector/Images/downTriangle.png: Added.
2254         * page/inspector/Images/errorIcon.png: Added.
2255         * page/inspector/Images/errorMediumIcon.png: Added.
2256         * page/inspector/Images/folder.png: Added.
2257         * page/inspector/Images/goArrow.png: Added.
2258         * page/inspector/Images/gradient.png: Added.
2259         * page/inspector/Images/gradientHighlight.png: Added.
2260         * page/inspector/Images/gradientHighlightBottom.png: Added.
2261         * page/inspector/Images/hideStatusWidget.png: Added.
2262         * page/inspector/Images/hideStatusWidgetPressed.png: Added.
2263         * page/inspector/Images/network.png: Added.
2264         * page/inspector/Images/paneBottomGrow.png: Added.
2265         * page/inspector/Images/paneBottomGrowActive.png: Added.
2266         * page/inspector/Images/paneGrowHandleLine.png: Added.
2267         * page/inspector/Images/paneHeader.png: Added.
2268         * page/inspector/Images/paneHeaderActive.png: Added.
2269         * page/inspector/Images/plainDocument.png: Added.
2270         * page/inspector/Images/popupArrows.png: Added.
2271         * page/inspector/Images/rightTriangle.png: Added.
2272         * page/inspector/Images/segment.png: Added.
2273         * page/inspector/Images/segmentEnd.png: Added.
2274         * page/inspector/Images/segmentHover.png: Added.
2275         * page/inspector/Images/segmentHoverEnd.png: Added.
2276         * page/inspector/Images/segmentSelected.png: Added.
2277         * page/inspector/Images/segmentSelectedEnd.png: Added.
2278         * page/inspector/Images/showStatusWidget.png: Added.
2279         * page/inspector/Images/showStatusWidgetPressed.png: Added.
2280         * page/inspector/Images/sidbarItemBackground.png: Added.
2281         * page/inspector/Images/sidebarActionWidget.png: Added.
2282         * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
2283         * page/inspector/Images/sidebarAttachWidget.png: Added.
2284         * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
2285         * page/inspector/Images/sidebarDetachWidget.png: Added.
2286         * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
2287         * page/inspector/Images/sidebarResizeWidget.png: Added.
2288         * page/inspector/Images/sidebarSelection.png: Added.
2289         * page/inspector/Images/sidebarSelectionBlurred.png: Added.
2290         * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
2291         * page/inspector/Images/sidebarSelectionGray.png: Added.
2292         * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
2293         * page/inspector/Images/sidebarSelectionTall.png: Added.
2294         * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
2295         * page/inspector/Images/sourceViewButton.png: Added.
2296         * page/inspector/Images/sourceViewButtonSelected.png: Added.
2297         * page/inspector/Images/splitviewDimple.png: Added.
2298         * page/inspector/Images/splitviewDividerBackground.png: Added.
2299         * page/inspector/Images/tab.png: Added.
2300         * page/inspector/Images/tabSelected.png: Added.
2301         * page/inspector/Images/timelinePillBlue.png: Added.
2302         * page/inspector/Images/timelinePillGray.png: Added.
2303         * page/inspector/Images/timelinePillGreen.png: Added.
2304         * page/inspector/Images/timelinePillOrange.png: Added.
2305         * page/inspector/Images/timelinePillPurple.png: Added.
2306         * page/inspector/Images/timelinePillRed.png: Added.
2307         * page/inspector/Images/timelinePillYellow.png: Added.
2308         * page/inspector/Images/tipBalloon.png: Added.
2309         * page/inspector/Images/tipBalloonBottom.png: Added.
2310         * page/inspector/Images/tipIcon.png: Added.
2311         * page/inspector/Images/tipIconPressed.png: Added.
2312         * page/inspector/Images/toggleDown.png: Added.
2313         * page/inspector/Images/toggleUp.png: Added.
2314         * page/inspector/Images/toolbarBackground.png: Added.
2315         * page/inspector/Images/toolbarBackgroundInactive.png: Added.
2316         * page/inspector/Images/toolbarButton.png: Added.
2317         * page/inspector/Images/toolbarButtonInactive.png: Added.
2318         * page/inspector/Images/toolbarButtonPressed.png: Added.
2319         * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
2320         * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
2321         * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
2322         * page/inspector/Images/treeDownTriangleBlack.png: Added.
2323         * page/inspector/Images/treeDownTriangleWhite.png: Added.
2324         * page/inspector/Images/treeLeftTriangleBlack.png: Added.
2325         * page/inspector/Images/treeRightTriangleBlack.png: Added.
2326         * page/inspector/Images/treeRightTriangleWhite.png: Added.
2327         * page/inspector/Images/warningIcon.png: Added.
2328         * page/inspector/Images/warningMediumIcon.png: Added.
2329         * page/inspector/Images/warningsErrors.png: Added.
2330
2331         Build-fu:
2332
2333         * WebCore.exp: Added new symbols.
2334         * WebCore.xcodeproj/project.pbxproj: Added new source files and
2335         resources.
2336         * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
2337         $WebKitOutputDir.
2338
2339         Windows build fixes:
2340
2341         * history/HistoryItem.h: ResourceRequest is a struct.
2342         * loader/FrameLoaderClient.h: Ditto.
2343
2344 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2345
2346         Reviewed by Beth.
2347
2348         - fix http://bugs.webkit.org/show_bug.cgi?id=14056
2349           REGRESSION (r21113-21143): TR background not repainted via style class change
2350
2351         Test: fast/repaint/table-row.html
2352
2353         * rendering/RenderTableRow.cpp:
2354         (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
2355         table row also needs layout, so it doesn't get a repaint in setStyle().
2356
2357 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2358
2359         Reviewed by Adele.
2360
2361         - fix http://bugs.webkit.org/show_bug.cgi?id=14040
2362           Top and bottom border images flipped when using -webkit-border-image when border end up tiled
2363
2364         Test: fast/borders/border-image-01.html
2365
2366         Correctly account for the fact that "pattern space" is flipped.
2367
2368         * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
2369         * platform/graphics/cg/ImageCG.cpp:
2370         (WebCore::Image::drawPatternCallback):
2371         (WebCore::Image::drawPattern):
2372
2373 2007-06-20  Anders Carlsson  <andersca@apple.com>
2374
2375         Reviewed by Darin.
2376
2377         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
2378         
2379         Check for either '\r' or '\n' in the header value.
2380         
2381         * xml/xmlhttprequest.cpp:
2382         (WebCore::isValidHeaderValue):
2383
2384 2007-06-20  Patti Hoa  <patti@apple.com>
2385
2386         Reviewed by Geoffrey Garen.
2387
2388         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2389         Add additional change from review
2390         
2391         * bridge/mac/WebCoreAXObject.mm:
2392         (-[WebCoreAXObject accessibilityAttributeValue:]):
2393         Check if the element has imgTag before asking for its url
2394         
2395 2007-06-20  Patti Hoa  <patti@apple.com>
2396
2397         Reviewed by Tristan O'Tierney.
2398
2399         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2400         
2401         * bridge/mac/WebCoreAXObject.mm:
2402         (-[WebCoreAXObject accessibilityAttributeNames]):
2403         (-[WebCoreAXObject accessibilityAttributeValue:]):
2404         Return the url of images.
2405
2406 2007-06-19  Anders Carlsson  <andersca@apple.com>
2407
2408         Reviewed by Kevin Decker.
2409
2410         <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
2411         
2412         Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
2413         
2414         * loader/DocumentLoader.cpp:
2415         (WebCore::DocumentLoader::DocumentLoader):
2416         * loader/DocumentLoader.h:
2417         (WebCore::DocumentLoader::deferMainResourceDataLoad):
2418         * loader/MainResourceLoader.cpp:
2419         (WebCore::MainResourceLoader::handleDataLoadSoon):
2420         (WebCore::MainResourceLoader::loadNow):
2421         (WebCore::MainResourceLoader::setDefersLoading):
2422
2423 2007-06-19  Patti Hoa <patti@apple.com>
2424
2425         Reviewed by Justin Garcia.
2426         
2427         <rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
2428         
2429         * editing/visible_units.cpp:
2430         (WebCore::startPositionForLine):
2431         (WebCore::startOfLine):
2432         (WebCore::endPositionForLine):
2433         (WebCore::endOfLine):
2434         Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
2435         An example would be when lineStart/lineEnd at different line than the input position.
2436         This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
2437         specifically a line without webkit-line-break:after-white-space style.
2438
2439 2007-06-19  Patti Hoa  <patti@apple.com>
2440
2441         Reviewed by Justin Garcia.
2442         
2443         <rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap
2444         
2445         * bridge/mac/WebCoreAXObject.mm:
2446         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
2447         Improve the accuracy of the bounds for a given range
2448         
2449 2007-06-19  Anders Carlsson  <andersca@apple.com>
2450
2451         Reviewed by Darin.
2452
2453         <rdar://problem/5130630>
2454         XPath fails LayoutTests on Windows
2455         
2456         * xml/XPathPredicate.cpp:
2457         Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
2458         
2459         * xml/XPathValue.cpp:
2460         (WebCore::XPath::Value::toNumber):
2461         Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
2462         
2463 2007-06-19  Geoffrey Garen  <ggaren@apple.com>
2464
2465         Reviewed by Darin Adler.
2466
2467         Fixed cross-frame access. <rdar://problem/5251309>. 
2468
2469         * bindings/js/kjs_window.cpp:
2470         (KJS::Window::getValueProperty):
2471         * bindings/scripts/CodeGeneratorJS.pm:
2472         * page/DOMWindow.idl:
2473
2474 2007-06-19  Anders Carlsson  <andersca@apple.com>
2475
2476         Build fix.
2477         
2478         * platform/win/PopupMenuWin.cpp:
2479
2480 2007-06-19  Lars Knoll <lars@trolltech.com>
2481
2482         Reviewed by Zack
2483
2484         Implement these methods correctly.
2485
2486         * platform/qt/PlatformScreenQt.cpp:
2487         (WebCore::screenRect):
2488         (WebCore::screenAvailableRect):
2489
2490 2007-06-19  Sam Weinig  <sam@webkit.org>
2491
2492         Reviewed by Geoff.
2493
2494         Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
2495         Move the History object out of the JS bindings
2496
2497         - Autogenerate JSHistory.
2498
2499         * DerivedSources.make:
2500         * WebCore.pro:
2501         * WebCore.vcproj/WebCore.vcproj:
2502         * WebCore.xcodeproj/project.pbxproj:
2503         * bindings/js/kjs_window.cpp:
2504         (KJS::WindowPrivate::WindowPrivate):
2505         (KJS::Window::mark):
2506         (KJS::Window::getValueProperty):
2507         (KJS::Window::clearHelperObjectProperties):
2508         (KJS::Window::disconnectFrame):
2509         * bindings/js/kjs_window.h:
2510         (KJS::Window::):
2511         * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
2512         * bridge/History.h: Removed.
2513         * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
2514         * bridge/mac/HistoryMac.mm: Removed.
2515         * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
2516         * bridge/win/HistoryWin.cpp: Removed.
2517         * css/cssstyleselector.cpp:
2518         * page/DOMWindow.cpp:
2519         (WebCore::DOMWindow::disconnectFrame):
2520         (WebCore::DOMWindow::history):
2521         * page/DOMWindow.h:
2522         * page/DOMWindow.idl:
2523         * page/History.cpp: Added.
2524         (WebCore::History::History):
2525         (WebCore::History::frame):
2526         (WebCore::History::disconnectFrame):
2527         (WebCore::History::length):
2528         (WebCore::History::back):
2529         (WebCore::History::forward):
2530         (WebCore::History::go):
2531         * page/History.h: Added.
2532         * page/History.idl: Added.
2533         * platform/gdk/TemporaryLinkStubs.cpp:
2534         * platform/qt/TemporaryLinkStubs.cpp:
2535         * platform/wx/TemporaryLinkStubs.cpp:
2536
2537 2007-06-18  Sam Weinig  <sam@webkit.org>
2538
2539         Qt build fix.
2540
2541         * platform/qt/PlatformScreenQt.cpp:
2542         (WebCore::screenDepth):
2543         (WebCore::screenDepthPerComponent):
2544         (WebCore::screenIsMonochrome):
2545         (WebCore::screenRect):
2546         (WebCore::screenAvailableRect):
2547
2548 2007-06-18  Sam Weinig  <sam@webkit.org>
2549
2550         Reviewed by Beth.
2551
2552         Fix build and update licenses. 
2553
2554         * WebCore.xcodeproj/project.pbxproj:
2555         * page/BarInfo.cpp:
2556         * page/BarInfo.h:
2557         * page/BarInfo.idl:
2558         * page/Screen.cpp:
2559         (WebCore::Screen::height):
2560         (WebCore::Screen::width):
2561         (WebCore::Screen::colorDepth):
2562         (WebCore::Screen::pixelDepth):
2563         (WebCore::Screen::availLeft):
2564         (WebCore::Screen::availTop):
2565         (WebCore::Screen::availHeight):
2566         (WebCore::Screen::availWidth):
2567         * page/Screen.h:
2568         * page/Screen.idl:
2569
2570 2007-06-18  Anders Carlsson  <andersca@apple.com>
2571
2572         Reviewed by John Sullivan.
2573
2574         <rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]
2575         
2576         Don't send any frame load callbacks if the document load hasn't been
2577         committed for real.
2578         
2579         * loader/FrameLoader.cpp:
2580         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2581
2582 2007-06-18  Sam Weinig  <sam@webkit.org>
2583
2584         Reviewed by Geoff.
2585
2586         Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
2587         Move the Screen object out of the JS bindings
2588
2589         - Renames Screen.h to PlatformScreen.h to accommodate new class.
2590         - Autogenerates JSScreen.
2591
2592         * DerivedSources.make:
2593         * WebCore.pro:
2594         * WebCore.vcproj/WebCore.vcproj:
2595         * WebCore.xcodeproj/project.pbxproj:
2596         * bindings/js/kjs_window.cpp:
2597         (KJS::WindowPrivate::WindowPrivate):
2598         (KJS::Window::mark):
2599         (KJS::Window::getValueProperty):
2600         (KJS::Window::clearHelperObjectProperties):
2601         * bindings/js/kjs_window.h:
2602         (KJS::Window::):
2603         * css/MediaQueryEvaluator.cpp:
2604         * page/DOMWindow.cpp:
2605         (WebCore::DOMWindow::DOMWindow):
2606         (WebCore::DOMWindow::~DOMWindow):
2607         (WebCore::DOMWindow::frame):
2608         (WebCore::DOMWindow::disconnectFrame):
2609         (WebCore::DOMWindow::screen):
2610         * page/DOMWindow.h:
2611         * page/DOMWindow.idl:
2612         * page/Screen.cpp: Added.
2613         (WebCore::Screen::Screen):
2614         (WebCore::Screen::disconnectFrame):
2615         (WebCore::Screen::height):
2616         (WebCore::Screen::width):
2617         (WebCore::Screen::colorDepth):
2618         (WebCore::Screen::pixelDepth):
2619         (WebCore::Screen::availLeft):
2620         (WebCore::Screen::availTop):
2621         (WebCore::Screen::availHeight):
2622         (WebCore::Screen::availWidth):
2623         * page/Screen.h: Added.
2624         * page/Screen.idl: Added.
2625         * page/mac/WebCoreFrameBridge.mm:
2626         * platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
2627         * platform/Screen.h: Removed.
2628         * platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
2629         * platform/gdk/ScreenGdk.cpp: Removed.
2630         * platform/mac/PlatformMouseEventMac.mm:
2631         * platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
2632         * platform/mac/ScreenMac.mm: Removed.
2633         * platform/qt/PlatformScreenQt.cpp: Added.
2634         (WebCore::WebCore::screenDepth):
2635         (WebCore::WebCore::screenDepthPerComponent):
2636         (WebCore::WebCore::screenIsMonochrome):
2637         (WebCore::WebCore::screenRect):
2638         (WebCore::WebCore::screenAvailableRect):
2639         * platform/qt/TemporaryLinkStubs.cpp:
2640         * platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
2641         * platform/win/ScreenWin.cpp: Removed.
2642         * rendering/RenderObject.cpp:
2643
2644 2007-06-18  Sam Weinig  <sam@webkit.org>
2645
2646         Reviewed by Geoff.
2647
2648         Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
2649         Move the BarInfo object out of the JS bindings
2650
2651         * DerivedSources.make:
2652         * WebCore.pro:
2653         * WebCore.vcproj/WebCore.vcproj:
2654         * WebCore.xcodeproj/project.pbxproj:
2655         * bindings/js/kjs_window.cpp:
2656         (KJS::WindowPrivate::WindowPrivate):
2657         (KJS::Window::mark):
2658         (KJS::Window::getValueProperty):
2659         (KJS::Window::clearHelperObjectProperties):
2660         (KJS::Window::disconnectFrame):
2661         * bindings/js/kjs_window.h:
2662         (KJS::Window::):
2663         * page/BarInfo.cpp: Added.
2664         (WebCore::BarInfo::BarInfo):
2665         (WebCore::BarInfo::disconnectFrame):
2666         (WebCore::BarInfo::visible):
2667         * page/BarInfo.h: Added.
2668         (WebCore::BarInfo::):
2669         * page/BarInfo.idl: Added.
2670         * page/DOMWindow.cpp:
2671         (WebCore::DOMWindow::~DOMWindow):
2672         (WebCore::DOMWindow::disconnectFrame):
2673         (WebCore::DOMWindow::locationbar):
2674         (WebCore::DOMWindow::menubar):
2675         (WebCore::DOMWindow::personalbar):
2676         (WebCore::DOMWindow::scrollbars):
2677         (WebCore::DOMWindow::statusbar):
2678         (WebCore::DOMWindow::toolbar):
2679         * page/DOMWindow.h:
2680         * page/DOMWindow.idl:
2681
2682 2007-06-18  Sam Weinig  <sam@webkit.org>
2683
2684         Reviewed by Darin.
2685
2686         Remove the FrameArray class and instead make window.frames another
2687         self-reference for window (like window.window, window.self, etc).
2688         This is what Firefox and what the HTML5 dictates.
2689
2690         * bindings/js/kjs_window.cpp:
2691         (KJS::WindowPrivate::WindowPrivate):
2692         (KJS::Window::mark):
2693         (KJS::Window::getValueProperty):
2694         (KJS::Window::clearHelperObjectProperties):
2695         (KJS::Window::disconnectFrame):
2696         * bindings/js/kjs_window.h:
2697
2698 2007-06-18  Mitz Pettel  <mitz@webkit.org>
2699
2700         Reviewed by Adele.
2701
2702         - fix http://bugs.webkit.org/show_bug.cgi?id=13413
2703           Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
2704
2705         Test: fast/forms/input-zero-height-focus.html
2706
2707         * rendering/RenderTextControl.cpp:
2708         (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
2709         selection in a zero-height text control.
2710
2711 2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>
2712
2713         Reviewed by Sam Weinig.
2714
2715         http://bugs.webkit.org/show_bug.cgi?id=14052
2716         Implement SoundGdk
2717
2718         * WebCore.pro:
2719         * platform/gdk/SoundGdk.cpp: Added.
2720         (WebCore::systemBeep):
2721         * platform/gdk/TemporaryLinkStubs.cpp:
2722         (WebCore::systemBeep):
2723
2724 2007-06-18  Dave Hyatt  <hyatt@apple.com>
2725
2726         Add support for horizontal mouse wheeling on Windows.
2727         
2728         Reviewed by aroben
2729
2730         * platform/PlatformWheelEvent.h:
2731         * platform/win/WheelEventWin.cpp:
2732         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2733
2734 2007-06-17  Sam Weinig  <sam@webkit.org>
2735
2736         Win32 build fix.
2737
2738         * WebCore.vcproj/WebCore.vcproj:
2739
2740 2007-06-15  David Hyatt  <hyatt@apple.com>
2741
2742         Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
2743         because of a botched 'round' support removal.  Also update for a change in
2744         the spec that has the second stretch/round/repeat keyword match the first
2745         if omitted.
2746         
2747         Reviewed by olliej
2748
2749         * css/cssparser.cpp:
2750         (WebCore::BorderImageParseContext::commitBorderImage):
2751         * platform/graphics/Image.cpp:
2752         (WebCore::Image::drawTiled):
2753         * platform/graphics/Image.h:
2754         (WebCore::Image::):
2755
2756 2007-06-15  Sam Weinig  <sam@webkit.org>
2757
2758         Reviewed by Darin.
2759
2760         Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
2761         Autogenerate JS binding for Rect
2762
2763         - Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList 
2764           and DOMRGBColor to JSRGBColor
2765         - Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
2766
2767         * DerivedSources.make:
2768         * WebCore.pro:
2769         * WebCore.xcodeproj/project.pbxproj:
2770         * bindings/js/kjs_css.cpp:
2771         (WebCore::):
2772         (WebCore::JSStyleSheetList::JSStyleSheetList):
2773         (WebCore::JSStyleSheetList::~JSStyleSheetList):
2774         (WebCore::JSStyleSheetList::getValueProperty):
2775         (WebCore::JSStyleSheetList::indexGetter):
2776         (WebCore::JSStyleSheetList::nameGetter):
2777         (WebCore::JSStyleSheetList::getOwnPropertySlot):
2778         (WebCore::toJS):
2779         (WebCore::JSStyleSheetListFunc::callAsFunction):
2780         (WebCore::JSRGBColor::JSRGBColor):
2781         (WebCore::JSRGBColor::~JSRGBColor):
2782         (WebCore::JSRGBColor::getOwnPropertySlot):
2783         (WebCore::JSRGBColor::getValueProperty):
2784         (WebCore::getJSRGBColor):
2785         * bindings/js/kjs_css.h:
2786         (WebCore::JSStyleSheetList::classInfo):
2787         (WebCore::JSStyleSheetList::):
2788         (WebCore::JSStyleSheetList::impl):
2789         (WebCore::JSRGBColor::classInfo):
2790         (WebCore::JSRGBColor::):
2791         (WebCore::JSRGBColor::impl):
2792         * bindings/objc/DOMUtility.mm:
2793         (KJS::createDOMWrapper):
2794         * bindings/scripts/CodeGeneratorJS.pm:
2795         * bindings/scripts/CodeGeneratorObjC.pm:
2796         * css/CSSBorderImageValue.cpp:
2797         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
2798         * css/CSSBorderImageValue.h:
2799         * css/CSSPrimitiveValue.cpp:
2800         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2801         (WebCore::CSSPrimitiveValue::cssText):
2802         * css/CSSPrimitiveValue.h:
2803         (WebCore::CSSPrimitiveValue::getRectValue):
2804         (WebCore::CSSPrimitiveValue::):
2805         * css/DashboardRegion.h:
2806         * css/Rect.h: Copied from css/RectImpl.h.
2807         (WebCore::Rect::~Rect):
2808         (WebCore::Rect::top):
2809         (WebCore::Rect::right):
2810         (WebCore::Rect::bottom):
2811         (WebCore::Rect::left):
2812         (WebCore::Rect::setTop):
2813         (WebCore::Rect::setRight):
2814         (WebCore::Rect::setBottom):
2815         (WebCore::Rect::setLeft):
2816         * css/Rect.idl:
2817         * css/RectImpl.h: Removed.
2818         * css/cssparser.cpp:
2819         (WebCore::CSSParser::parseShape):
2820         (WebCore::BorderImageParseContext::commitBorderImage):
2821         * css/cssstyleselector.cpp:
2822         (WebCore::CSSStyleSelector::applyProperty):
2823         * page/DOMWindow.idl:
2824
2825 2007-06-14  George Staikos  <staikos@kde.org>
2826
2827         Reviewed by Lars.
2828
2829         Implement missing tab support and a slight refactor.
2830
2831         * platform/qt/PlatformKeyboardEventQt.cpp:
2832         (WebCore::keyIdentifierForQtKeyCode):
2833         (WebCore::windowsKeyCodeForKeyEvent):
2834         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2835
2836 2007-06-14  Dave Hyatt  <hyatt@apple.com>
2837
2838         Fix for Bugzilla bug 14806, missing text for bold/italic fonts in non-English Windows installs.
2839         
2840         This patch adds an additional step after the lookup by full name fails.  It will then look up
2841         a PostScript name in a (localized full name) -> (PostScript name) cache.  If the name is not
2842         found, then the font's name table is obtained and searched for a PostScript name (and the
2843         result is cached).
2844         
2845         If lookup on PostScript name fails too, then we now properly fall back to the next font in the
2846         list (so text should never be missing).
2847
2848         Reviewed by Darin (thoroughly reviewed, super reviewed even)
2849
2850         * platform/win/FontCacheWin.cpp:
2851         * platform/win/FontPlatformDataWin.cpp:
2852
2853 2007-06-14  Anders Carlsson  <andersca@apple.com>
2854
2855         Reviewed by Geoff.
2856
2857         Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
2858         for a given plug-in.
2859
2860         * WebCore.exp:
2861         * page/Frame.cpp:
2862         (WebCore::Frame::cleanupScriptObjectsForPlugin):
2863         * page/Frame.h:
2864
2865 2007-06-14  Anders Carlsson  <andersca@apple.com>
2866
2867         Reviewed by Geoff.
2868
2869         <rdar://problem/5211677>
2870         -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
2871         
2872         * loader/FrameLoader.cpp:
2873         (WebCore::FrameLoader::requestObject):
2874         If the object is a Java MIME type and Java is disabled, don't load the plug-in.
2875         
2876         * platform/MimeTypeRegistry.cpp:
2877         (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
2878         Clean this up and add another applet MIME type.
2879
2880 2007-06-14  George Staikos  <staikos@kde.org>
2881
2882         Reviewed by Lars.
2883
2884         Implement the file chooser for Qt.
2885
2886         * platform/qt/FileChooserQt.cpp:
2887         (WebCore::FileChooser::openFileChooser):
2888         (WebCore::FileChooser::basenameForWidth):
2889
2890 2007-06-14  George Staikos  <staikos@kde.org>
2891
2892         Reviewed by Lars.
2893
2894         Add missing initialization of pointer.
2895
2896         * platform/qt/ContextMenuQt.cpp:
2897         (WebCore::ContextMenu::ContextMenu):
2898
2899 2007-06-14  Anders Carlsson  <andersca@apple.com>
2900
2901         Reviewed by Mitz.
2902
2903         <rdar://problem/5244948>
2904         Safari keeps on complaining about slow script playing NBC TV video (14133)
2905
2906         http://bugs.webkit.org/show_bug.cgi?id=14133
2907         Runaway JavaScript timer fires when spinning around in Google Maps street view
2908
2909         Make sure to start and stop the timeout checker around calls to JS.
2910
2911         * bindings/objc/WebScriptObject.mm:
2912         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2913         (-[WebScriptObject evaluateWebScript:]):
2914
2915 2007-06-14  George Staikos  <staikos@kde.org>
2916
2917         Reviewed by Maciej.
2918
2919         Keypress causes typeahead crash on empty selects due to modulo 0.
2920
2921         * html/HTMLSelectElement.cpp:
2922         (WebCore::HTMLSelectElement::typeAheadFind):
2923
2924 2007-06-13  George Staikos  <staikos@kde.org>
2925
2926         Reviewed by Lars.
2927
2928         Compile without self-linking.
2929
2930         * WebCore.pro:
2931
2932 2007-06-13  Darin Adler  <darin@apple.com>
2933
2934         Reviewed by Kevin Decker.
2935
2936         - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
2937           +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
2938
2939         * platform/mac/WebFontCache.mm:
2940         (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
2941         Took out the auto-activation code.
2942         (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
2943         then calls NSFont to trigger activation if that returned nil, then calls
2944         internalFontWithFamily again.
2945
2946 2007-06-13  Anders Carlsson  <andersca@apple.com>
2947
2948         Reviewed by Geoff.
2949
2950         Pass the root object to methods that end up creating new ObjcInstance objects.
2951         
2952         * bindings/objc/WebScriptObject.mm:
2953         (listFromNSArray):
2954         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2955         (-[WebScriptObject evaluateWebScript:]):
2956         (-[WebScriptObject setValue:forKey:]):
2957         (-[WebScriptObject valueForKey:]):
2958         (-[WebScriptObject removeWebScriptKey:]):
2959         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
2960
2961 2007-06-13  Anders Carlsson  <andersca@apple.com>
2962
2963         Reviewed by Darin.
2964
2965         <rdar://problem/5267992>
2966         Make sure an alert doesn't allow loading to continue inside a script.
2967         
2968         Make sure to defer all loads where it's possible for a second main loop to be running.
2969         
2970         * page/Chrome.cpp:
2971         (WebCore::Chrome::runModal):
2972         (WebCore::Chrome::runBeforeUnloadConfirmPanel):
2973         (WebCore::Chrome::runJavaScriptAlert):
2974         (WebCore::Chrome::runJavaScriptConfirm):
2975         (WebCore::Chrome::runJavaScriptPrompt):
2976         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2977         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2978         
2979         * platform/network/cf/ResourceHandleCFNet.cpp:
2980         (WebCore::ResourceHandle::setDefersLoading):
2981         Implement this.
2982
2983 2007-06-13  Alp Toker  <alp.toker@collabora.co.uk>
2984
2985         Reviewed by Rob.
2986
2987         http://bugs.webkit.org/show_bug.cgi?id=14060
2988         Cairo SVG support
2989
2990         * WebCore.pro: Add new files to the build.
2991         * platform/graphics/svg/SVGPaintServerPattern.h:
2992         * platform/graphics/svg/SVGPaintServerSolid.h:
2993         * platform/graphics/svg/cairo: Added.
2994         * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
2995         (WebCore::RenderPath::strokeContains):
2996         (WebCore::RenderPath::strokeBBox):
2997         * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
2998         (WebCore::SVGPaintServer::draw):
2999         (WebCore::SVGPaintServer::teardown):
3000         (WebCore::SVGPaintServer::renderPath):
3001         * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
3002         (WebCore::SVGPaintServerGradient::setup):
3003         * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
3004         (WebCore::SVGPaintServerPattern::setup):
3005         * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
3006         (WebCore::SVGPaintServerSolid::setup):
3007         * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
3008         (WebCore::SVGResourceClipper::applyClip):
3009         * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
3010         (WebCore::SVGResourceMasker::applyMask):
3011
3012 2007-06-13  Simon Hausmann  <hausmann@kde.org>
3013
3014         Reviewed by Lars.
3015
3016         Added a make install target that installs the Qt port and renamed
3017         WebKitQt to QtWebKit
3018
3019         * WebCore.pro:
3020
3021 2007-06-13  Adam Roben  <aroben@apple.com>
3022
3023         Fix one more BITMAPINFO/BITMAPINFOHEADER typo.
3024
3025         Rubberstamped by Oliver.
3026
3027         * platform/win/DragImageWin.cpp:
3028         (WebCore::allocImage):
3029
3030 2007-06-12  Oliver Hunt  <oliver@apple.com>
3031
3032         Reviewed by Darin.
3033
3034         Use correct size for BITMAPINFOHEADER -- whoops.
3035
3036         * platform/win/CursorWin.cpp:
3037         (WebCore::Cursor::Cursor):
3038         * platform/win/PasteboardWin.cpp:
3039         (WebCore::Pasteboard::writeImage):
3040
3041 2007-06-12  Sam Weinig  <sam@webkit.org>
3042
3043         Reviewed by Oliver.
3044
3045         Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
3046         Cleanup JSEvent and JSClipboard in preperation for autogeneration
3047
3048         * bindings/js/kjs_events.cpp:
3049         (KJS::DOMEvent::DOMEvent):
3050         (KJS::DOMEvent::getValueProperty):
3051         (KJS::DOMEvent::put):
3052         (KJS::DOMEvent::putValueProperty):
3053         (KJS::DOMEventPrototypeFunction::callAsFunction):
3054         (KJS::toJS):
3055         (KJS::toEvent):
3056         (KJS::):
3057         (KJS::JSClipboard::JSClipboard):
3058         (KJS::JSClipboard::~JSClipboard):
3059         (KJS::JSClipboard::getOwnPropertySlot):
3060         (KJS::JSClipboard::getValueProperty):
3061         (KJS::JSClipboard::put):
3062         (KJS::JSClipboard::putValueProperty):
3063         (KJS::JSClipboardPrototypeFunction::callAsFunction):
3064         (KJS::toClipboard):
3065         * bindings/js/kjs_events.h:
3066         (KJS::DOMEvent::):
3067         (KJS::DOMEvent::impl):
3068         (KJS::JSClipboard::impl):
3069         * dom/ClipboardEvent.h:
3070         * dom/Event.h:
3071         (WebCore::Event::srcElement):
3072         (WebCore::Event::returnValue):
3073         (WebCore::Event::clipboardData):
3074         (WebCore::Event::dataTransfer):
3075         (WebCore::Event::clipboard):
3076         * dom/MouseEvent.h:
3077
3078 2007-06-13  Lars Knoll <lars@trolltech.com>
3079
3080         Reviewed by Niko.
3081
3082         Small cleanup
3083
3084         * platform/qt/PlugInInfoStoreQt.cpp:
3085         (WebCore::PlugInInfoStore::supportsMIMEType):
3086
3087 2007-06-13  Lars Knoll <lars@trolltech.com>
3088
3089         Reviewed by Niko
3090
3091         Implement the parts required for the JS bridge
3092         to know about the plugins.
3093
3094         * WebCore.pro:
3095         * platform/qt/PlugInInfoStoreQt.cpp: Added.
3096         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
3097         (WebCore::PlugInInfoStore::pluginCount):
3098         (WebCore::PlugInInfoStore::supportsMIMEType):
3099         (WebCore::refreshPlugins):
3100         * platform/qt/TemporaryLinkStubs.cpp:
3101
3102 === Merged the following changes from branches/WindowsMerge ===
3103
3104 2007-06-09  Sam Weinig  <sam@webkit.org>
3105
3106         Build fix.
3107
3108         * WebCore.vcproj/WebCore.vcproj:
3109
3110 2007-06-08  Anders Carlsson  <andersca@apple.com>
3111
3112         Reviewed by Adam.
3113
3114         If both the old and new WMP plugins are present, remove the old one
3115         so we won't end up choosing it.
3116         
3117         * plugins/win/PluginDatabaseWin.cpp:
3118         (WebCore::PluginDatabaseWin::getPluginsInPaths):
3119
3120 2007-06-08  David Hyatt  <hyatt@apple.com>
3121
3122         Update licenses/copyrights for WebCoreWin.
3123
3124         Reviewed by mccullough
3125
3126         * WebCorePrefix.cpp:
3127         * bridge/win/FrameWin.cpp:
3128         * bridge/win/FrameWin.h:
3129         * bridge/win/HistoryWin.cpp:
3130         * bridge/win/PageWin.cpp:
3131         * page/win/EventHandlerWin.cpp:
3132         * platform/graphics/cg/ColorCG.cpp:
3133         * platform/graphics/cg/GraphicsContextPlatformPrivate.h:
3134         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3135         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3136         * platform/graphics/win/IconWin.cpp:
3137         * platform/graphics/win/ImageWin.cpp:
3138         * platform/network/cf/FormDataStreamCFNet.cpp:
3139         * platform/network/cf/FormDataStreamCFNet.h:
3140         * platform/network/cf/ResourceHandleCFNet.cpp:
3141         * platform/network/cf/ResourceRequestCFNet.cpp:
3142         * platform/network/cf/ResourceResponseCFNet.cpp:
3143         * platform/network/win/CookieJarWin.cpp:
3144         * platform/network/win/ResourceHandleWin.cpp:
3145         * platform/network/win/ResourceHandleWin.h:
3146         * platform/win/BString.cpp:
3147         * platform/win/BString.h:
3148         * platform/win/ClipboardWin.h:
3149         * platform/win/ContextMenuWin.cpp:
3150         * platform/win/CursorWin.cpp:
3151         * platform/win/EditorWin.cpp:
3152         * platform/win/FontCacheWin.cpp:
3153         * platform/win/FontDataWin.cpp:
3154         * platform/win/FontPlatformData.h:
3155         * platform/win/FontPlatformDataWin.cpp:
3156         * platform/win/FontWin.cpp:
3157         * platform/win/GlyphPageTreeNodeWin.cpp:
3158         * platform/win/GraphicsContextWin.cpp:
3159         * platform/win/KeyEventWin.cpp:
3160         * platform/win/MimeTypeRegistryWin.cpp:
3161         * platform/win/NotImplemented.h:
3162         * platform/win/PlatformMouseEventWin.cpp:
3163         * platform/win/PlatformScrollBar.h:
3164         * platform/win/PlatformScrollBarWin.cpp:
3165         * platform/win/PopupMenuWin.cpp:
3166         * platform/win/ScreenWin.cpp:
3167         * platform/win/ScrollViewWin.cpp:
3168         * platform/win/SearchPopupMenuWin.cpp:
3169         * platform/win/SoundWin.cpp:
3170         * platform/win/TemporaryLinkStubs.cpp:
3171         * platform/win/TextBoundariesWin.cpp:
3172         * platform/win/WebCoreHistory.cpp:
3173         * platform/win/WebCoreHistory.h:
3174         * platform/win/WebCoreSystemInterface.cpp:
3175         * platform/win/WebCoreSystemInterface.h:
3176         * platform/win/WheelEventWin.cpp:
3177         * platform/win/WidgetWin.cpp:
3178         * plugins/win/PlugInInfoStoreWin.cpp:
3179         * plugins/win/PluginDatabaseWin.cpp:
3180         * plugins/win/PluginDatabaseWin.h:
3181         * plugins/win/PluginDebug.h:
3182         * plugins/win/PluginPackageWin.cpp:
3183         * plugins/win/PluginPackageWin.h:
3184         * plugins/win/PluginStreamWin.cpp:
3185         * plugins/win/PluginStreamWin.h:
3186         * plugins/win/PluginViewWin.cpp:
3187         * plugins/win/PluginViewWin.h:
3188         * plugins/win/npapi.cpp:
3189         * plugins/win/npfunctions.h:
3190         * rendering/RenderThemeSafari.cpp:
3191         * rendering/RenderThemeSafari.h:
3192         * rendering/RenderThemeWin.h:
3193
3194 2007-06-07  Sam Weinig  <sam@webkit.org>
3195
3196         Fix build.
3197
3198         * WebCore.vcproj/WebCore.vcproj:
3199
3200 2007-06-07  Anders Carlsson  <andersca@apple.com>
3201
3202         Reviewed by Steve.
3203
3204         <rdar://problem/5252902>
3205         Shockwave plug-in content crashes.
3206         
3207         Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
3208         and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
3209         a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave 
3210         does not use CallWndProc but instead treats the WNDPROC as a function.
3211         
3212         * plugins/win/PluginViewWin.cpp:
3213         (WebCore::PluginViewWndProc):
3214         (WebCore::PluginViewWin::determineQuirks):
3215         (WebCore::PluginViewWin::init):
3216         * plugins/win/PluginViewWin.h:
3217         (WebCore::):
3218         (WebCore::PluginViewWin::quirks):
3219
3220 2007-06-07  Sam Weinig  <sam@webkit.org>
3221
3222         Build fix for the build fix.
3223
3224         * WebCore.vcproj/WebCore.vcproj:
3225
3226 2007-06-07  Sam Weinig  <sam@webkit.org>
3227
3228         Build fix.
3229
3230         * WebCore.vcproj/WebCore.vcproj:
3231
3232 2007-06-06  Sam Weinig  <sam@webkit.org>
3233
3234         Build fix.
3235
3236         * WebCore.vcproj/WebCore.vcproj:
3237
3238 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3239
3240         Reviewed by Oliver.
3241
3242         Update to last fix.
3243         Invalidate a list of rects rather than unioning them.
3244
3245         * plugins/win/PluginViewWin.cpp:
3246         (WebCore::PluginViewWin::invalidateTimerFired):
3247         (WebCore::PluginViewWin::invalidateRect):
3248         * plugins/win/PluginViewWin.h:
3249
3250 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3251
3252         Reviewed by Oliver.
3253
3254         <rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com
3255         
3256         Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
3257         starving other HWNDs.
3258         
3259         This code defers the invalidate through a WebCore::Timer.  We could have used a Windows ::SetTimer
3260         to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
3261         performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.
3262
3263         * plugins/win/PluginViewWin.cpp:
3264         (WebCore::PluginViewWin::invalidateTimerFired): Added.
3265         (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash.
3266         (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
3267         * plugins/win/PluginViewWin.h:
3268
3269 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3270
3271         Reviewed by Adam.
3272
3273         Update last fix to use startsWith instead of strcmpi.
3274
3275         * plugins/win/PluginStreamWin.cpp:
3276         (WebCore::PluginStreamWin::startStream):
3277         * plugins/win/PluginViewWin.cpp:
3278         (WebCore::scriptStringIfJavaScriptURL):
3279
3280 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3281
3282         Reviewed by gramps.
3283
3284         Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
3285         Make "javascript" URL scheme string compare case insensitive.
3286
3287         * plugins/win/PluginStreamWin.cpp:
3288         (WebCore::PluginStreamWin::startStream): Use strcmpi.
3289         * plugins/win/PluginViewWin.cpp:
3290         (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.
3291
3292 2007-06-01  Anders Carlsson  <andersca@apple.com>
3293
3294         Reviewed by Steve.
3295
3296         If the value exists but is empty, return an empty String.
3297         
3298         * plugins/win/PluginPackageWin.cpp:
3299         (WebCore::getVersionInfo):
3300
3301 2007-06-01  Anders Carlsson  <andersca@apple.com>
3302
3303         Reviewed by Steve.
3304
3305         Add the default path for the new WMP Firefox plugin.
3306
3307         * plugins/win/PluginDatabaseWin.cpp:
3308         (WebCore::addWindowsMediaPlayerPluginPath):
3309
3310 2007-05-31  Sam Weinig  <sam@webkit.org>
3311
3312         Fixed build.
3313
3314         * WebCore.vcproj/WebCore.vcproj:
3315
3316 2007-05-31  Sam Weinig  <sam@webkit.org>
3317
3318         Fixed build.
3319
3320         * WebCore.vcproj/WebCore.vcproj:
3321
3322 2007-05-30  Ada Chan  <adachan@apple.com>
3323
3324         Reviewed by Adam.
3325
3326         Fixed build.
3327
3328         * platform/win/PopupMenuWin.cpp:
3329         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
3330
3331 2007-05-30  Sam Weinig  <sam@webkit.org>
3332
3333         Build Fix.
3334
3335         * WebCore.vcproj/WebCore.vcproj:
3336
3337 2007-05-29  Sam Weinig  <sam@webkit.org>
3338
3339         Fix the build.
3340
3341         * WebCore.vcproj/WebCore.vcproj:
3342
3343 2007-05-29  Anders Carlsson  <andersca@apple.com>
3344
3345         Reviewed by Adam.
3346
3347         <rdar://4782915> plugin is not in the right place at jumble.com/play.html
3348
3349         Pass the plugin window coordinates for windowed plugins too.
3350         
3351         * plugins/win/PluginViewWin.cpp:
3352         (WebCore::PluginViewWin::setNPWindowRect):
3353
3354 2007-05-29  Anders Carlsson  <andersca@apple.com>
3355
3356         Reviewed by Adam.
3357
3358         <rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
3359         <rdar://problem/5131528> play button on Flash in ESPN front page does not start movie
3360         
3361         Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
3362         the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a 
3363         quirk for that.
3364         
3365         * plugins/win/PluginViewWin.cpp:
3366         (WebCore::PluginViewWin::determineQuirks):
3367         (WebCore::PluginViewWin::init):
3368         * plugins/win/PluginViewWin.h:
3369         (WebCore::):
3370
3371 2007-05-29  Sam Weinig  <sam@webkit.org>
3372
3373         Reviewed by Adam Roben.
3374
3375         - Removes platform/win/NotImplemented.h because we have consolidated
3376           the notImplemented() for all platforms in platform/NotImplemented.h
3377         - Fixes remaining uses of old macro to use the new notImplemented() one.
3378
3379         * WebCore.vcproj/WebCore.vcproj:
3380         * page/win/EventHandlerWin.cpp:
3381         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
3382         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3383         (WebCore::SVGResourceFilter::prepareFilter):
3384         (WebCore::SVGResourceFilter::applyFilter):
3385         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3386         (WebCore::SVGResourceMasker::applyMask):
3387         * platform/win/GraphicsContextWin.cpp:
3388         (WebCore::contextForImage):
3389         * platform/win/NotImplemented.h: Removed.
3390         * platform/win/SearchPopupMenuWin.cpp:
3391         (WebCore::SearchPopupMenu::saveRecentSearches):
3392         (WebCore::SearchPopupMenu::loadRecentSearches):
3393         * platform/win/TemporaryLinkStubs.cpp:
3394         (Frame::print):
3395         (Frame::issueTransposeCommand):
3396         (GraphicsContextPlatformPrivate::clip):
3397         (WebCore::FrameView::updateBorder):
3398         (Widget::setIsSelected):
3399         (ScrollView::inWindow):
3400         (WebCore::focusRingColor):
3401         (WebCore::setFocusRingColorChangeFunction):
3402         (Frame::setNeedsReapplyStyles):
3403         (FrameLoader::overrideMediaType):
3404         (DocumentLoader::getResponseModifiedHeader):
3405         (ResourceHandle::willLoadFromCache):
3406         (WebCore::userIdleTime):
3407         (CachedPage::close):
3408         (WebCore::supportedKeySizes):
3409         (WebCore::signedPublicKeyAndChallengeString):
3410         * plugins/win/PluginViewWin.cpp:
3411         (WebCore::PluginViewWin::newStream):
3412         (WebCore::PluginViewWin::write):
3413         (WebCore::PluginViewWin::setValue):
3414
3415 2007-05-29  Anders Carlsson  <andersca@apple.com>
3416
3417         Build fix.
3418         
3419         * rendering/RenderThemeSafari.cpp:
3420         (WebCore::RenderThemeSafari::adjustSliderThumbStyle):
3421
3422 2007-05-29  Anders Carlsson  <andersca@apple.com>
3423
3424         Reviewed by Adam.
3425
3426         Port code from open source changeset 21808, fixing
3427         http://bugs.webkit.org/show_bug.cgi?id=13871 
3428         
3429         * rendering/RenderThemeSafari.cpp:
3430         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
3431         * rendering/RenderThemeSafari.h:
3432
3433 2007-05-29  Ada Chan  <adachan@apple.com>
3434
3435         Build fix.
3436         - Added "$(ProjectDir)..\platform\win" to include paths
3437         - Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project
3438
3439         * WebCore.vcproj/WebCore.vcproj:
3440
3441 2007-05-28  Sam Weinig  <sam@webkit.org>
3442
3443         Build fix.
3444
3445         * WebCore.vcproj/WebCore.vcproj:
3446
3447 2007-05-27  Sam Weinig  <sam@webkit.org>
3448
3449         Build fix.
3450
3451         * WebCore.vcproj/WebCore.vcproj:
3452
3453 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
3454
3455         Reviewed by Darin Adler.
3456
3457         Fixed a bug with Settings where a number of different objects held bare 
3458         Settings* data members, even though the Page owns the Settings object and 
3459         deletes it upon destruction.
3460
3461         Added NULL checks since the Page can be deleted before the frame/document.
3462
3463         * plugins/win/PluginViewWin.cpp:
3464         (WebCore::PluginViewWin::load):
3465
3466 2007-05-24  Sam Weinig  <sam@webkit.org>
3467
3468         Reviewed by NOBODY.
3469
3470         Build fix.
3471
3472         * WebCore.vcproj/WebCore.vcproj:
3473
3474 2007-05-24  Anders Carlsson  <andersca@apple.com>
3475
3476         Reviewed by Adam.
3477
3478         <rdar://5211882>
3479         Need to relaunch Boomer to recognize newly installed QT plug-in
3480         
3481         <rdar://5061867>
3482         After installing Flash, Safari would still not display pages that needed it
3483         
3484         * plugins/win/PluginDatabaseWin.cpp:
3485         (WebCore::PluginDatabaseWin::refresh):
3486         Return whether the plugin database changed or not.
3487         
3488         (WebCore::PluginDatabaseWin::findPlugin):
3489         New function that tries to find a plug-in given its url and MIME type.
3490         
3491         (WebCore::PluginDatabaseWin::createPluginView):
3492         If no plugin is found, refresh the database and search for the plugin again if the database changed.
3493         
3494 2007-05-24  Adele Peterson  <adele@apple.com>
3495
3496         - fix http://bugs.webkit.org/show_bug.cgi?id=13837
3497           Separator in new <select> widget disappears when block element with border is in document.
3498
3499         * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButton):
3500          Added calls to set the stroke style and thickness when painting the arrows and the separator.
3501
3502 2007-05-24  Sam Weinig  <sam@webkit.org>
3503
3504         Build fix.
3505
3506         * WebCore.vcproj/WebCore.vcproj:
3507
3508 2007-05-23  Sam Weinig  <sam@webkit.org>
3509
3510         Build fix.
3511
3512         * WebCore.vcproj/WebCore.vcproj:
3513
3514 2007-05-23  Anders Carlsson  <andersca@apple.com>
3515
3516         Fix build.
3517         
3518         * platform/win/CursorWin.cpp:
3519         (WebCore::zoomInCursor):
3520         (WebCore::zoomOutCursor):
3521
3522 2007-05-22  Ada Chan  <adachan@apple.com>
3523
3524         Fix build.
3525
3526         * plugins/win/PluginViewWin.cpp:
3527         (WebCore::PluginViewWin::handleMouseEvent):
3528
3529 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
3530
3531         Reviewed by oliver
3532
3533         Build fix.
3534
3535         * plugins/win/PluginViewWin.cpp:
3536         (WebCore::PluginViewWin::handleMouseEvent): 
3537
3538 2007-05-21  Sam Weinig  <sam@webkit.org>
3539
3540         Reviewed by Oliver.
3541
3542         Build fix.
3543
3544         * WebCore.vcproj/WebCore.vcproj:
3545
3546 2007-05-21  Sam Weinig  <sam@webkit.org>
3547
3548         Reviewed by Adam.
3549
3550         Build fix.
3551
3552         * WebCore.vcproj/WebCore.vcproj:
3553
3554 2007-05-17  Steve Falkenburg  <sfalken@apple.com>
3555
3556         Reviewed by Geoff, Adam.
3557
3558         Use precompiled headers (via WebCorePrefix.h) to speed up WebCoreWin builds.
3559         This improved WebCore debug rebuild time from 40 minutes to 25 for me.
3560         
3561         A few files needed to be excluded, since they didn't build properly with
3562         the prefix file: ColorData.c, CSSGrammar.cpp, HTMLEntityNames.c, XPathGrammar.cpp, XPathParser.cpp.
3563
3564         * WebCore.vcproj/WebCore.vcproj: Turn on precompiled header, force includes flags.
3565         * WebCorePrefix.cpp: Added.
3566         * WebCorePrefix.h: Added.
3567         * config.h: Modified to be compatible with WebCorePrefix.h.
3568
3569 2007-05-18  Sam Weinig  <sam@webkit.org>
3570
3571         Reviewed by Adam.
3572
3573         Fixing the vcproj paths.
3574
3575         * WebCore.vcproj/WebCore.vcproj:
3576
3577 2007-05-18  Sam Weinig  <sam@webkit.org>
3578
3579         Reviewed by Geoff.
3580
3581         Build fix after r21577.
3582
3583         * WebCore.vcproj/WebCore.vcproj:
3584
3585 2007-05-18  Adam Roben  <aroben@apple.com>
3586
3587         Build fix after r21562.
3588
3589         * platform/win/TemporaryLinkStubs.cpp:
3590         * platform/win/WidgetWin.cpp:
3591         * plugins/win/PluginViewWin.cpp:
3592         * plugins/win/PluginViewWin.h:
3593
3594 2007-05-18  Anders Carlsson  <andersca@apple.com>
3595
3596         Reviewed by Geoff.
3597         
3598         <rdar://problem/4914940> Some plugins won't redraw correctly when scrolling
3599         
3600         This patch does two things:
3601         
3602         1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent
3603         the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.
3604         
3605         2. It lets Windows handle its invalid region when moving the window and setting its new window region.
3606         
3607         * plugins/win/PluginViewWin.cpp:
3608         (WebCore::PluginViewWin::updateWindow):
3609
3610 2007-05-18  Adam Roben  <aroben@apple.com>
3611
3612         Build fix after r21555.
3613
3614         * page/win/EventHandlerWin.cpp:
3615         (WebCore::EventHandler::passMouseMoveEventToSubframe):
3616
3617 2007-05-17  Sam Weinig  <sam@webkit.org>
3618
3619         Reviewed by Adam.
3620
3621         Build Fix after <rdar://problem/5201423>
3622
3623         * WebCore.vcproj/WebCore.vcproj:
3624
3625 2007-05-17  Adele Peterson  <adele@apple.com>
3626
3627         Reviewed by Hyatt.
3628
3629         Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3630
3631         * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
3632           Use the clientStyle to determine how to handle bidi text.  For popup buttons, which we restrict to LTR,
3633           we will match the button text.
3634
3635 2007-05-17  Anders Carlsson  <andersca@apple.com>
3636
3637         Reviewed by Darin.
3638
3639         <rdar://problem/5210600> New WMP plugin doesn't show any contents
3640
3641         Call NPP_SetWindow after the window's size has been updated.
3642         
3643         * plugins/win/PluginViewWin.cpp:
3644         (WebCore::PluginViewWin::setFrameGeometry):
3645
3646 2007-05-17  Anders Carlsson  <andersca@apple.com>
3647
3648         Reviewed by John.
3649
3650         <rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension
3651         
3652         Return null if the extension is null.
3653         
3654         * platform/win/MimeTypeRegistryWin.cpp:
3655         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
3656
3657 2007-05-16  Adele Peterson  <adele@apple.com>
3658
3659         Reviewed by Hyatt.
3660
3661         Fix for:
3662             <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3663             <rdar://problem/5205654> Select popup menus should always be ltr to match the mac
3664
3665         * platform/win/PopupMenuWin.cpp:
3666         (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align.
3667         (WebCore::PopupMenu::calculatePositionAndSize): ditto.
3668         (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.
3669
3670 2007-05-14  Oliver Hunt  <oliver@apple.com>
3671
3672         Reviewed by Sam.
3673
3674         Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.
3675
3676         If the image does not already have a title, fall back to the 
3677         name suggested by Content-Disposition.
3678
3679         * platform/win/ClipboardWin.cpp:
3680         (WebCore::createGlobalImageFileDescriptor):
3681
3682 2007-05-14  Oliver Hunt  <oliver@apple.com>
3683
3684         Reviewed by Sam.
3685
3686         Fix for <rdar://problem/5202805> Null dereference in createGlobalData(CString str)
3687         
3688         Null terminate manually to prevent us from dereferencing null.
3689
3690         * platform/win/ClipboardUtilitiesWin.cpp:
3691         (WebCore::createGlobalData):
3692
3693 2007-05-14  Oliver Hunt  <oliver@apple.com>
3694
3695         Reviewed by Geoff.
3696
3697         Windows side of fix for
3698         <rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">
3699
3700         * platform/win/ClipboardUtilitiesWin.cpp:
3701         (WebCore::cfHDropFormat):
3702           Need to be able to access externally
3703           
3704         * platform/win/ClipboardUtilitiesWin.h:
3705           Declare cfHDropFormat
3706           
3707         * platform/win/DragDataWin.cpp:
3708         (WebCore::DragData::containsFiles):
3709         (WebCore::DragData::asFilenames):
3710           Add implementation of containsFiles and asFilenames
3711
3712 2007-05-14  Geoffrey Garen  <ggaren@apple.com>
3713
3714         Build fix.
3715
3716         * WebCore.vcproj/WebCore.vcproj:
3717
3718 2007-05-14  Anders Carlsson  <andersca@apple.com>
3719
3720         Reviewed by Geoff.
3721
3722         <rdar://problem/5176940> Seed10: MS Silverlight 1.0 beta plug-in is not supported
3723         
3724         * plugins/win/PluginDatabaseWin.cpp:
3725         (WebCore::addPluginsFromRegistry):
3726         New function that adds plugins from the registry from HKEY_LOCAL_MACHINE/MozillaPlugins.
3727
3728         * plugins/win/PluginViewWin.cpp:
3729         (WebCore::PluginViewWin::invalidateRect):
3730         (WebCore::PluginViewWin::forceRedraw):
3731         Make these work with windowed plugins.
3732         
3733 2007-05-13  Darin Adler  <darin@apple.com>
3734
3735         Requested by Hyatt.
3736
3737         - internal part of http://bugs.webkit.org/show_bug.cgi?id=13529
3738           DOM3 keyIdentifier text is incorrect
3739
3740         * platform/win/KeyEventWin.cpp:
3741         (WebCore::keyIdentifierForWindowsKeyCode): Use 4 digits for "U+" stuff.
3742
3743 2007-05-12  Oliver Hunt  <oliver@apple.com>
3744
3745         rs=hyatt.
3746
3747         Stubs to prevent build bustage
3748
3749         * platform/win/DragDataWin.cpp:
3750         (WebCore::DragData::containsFiles):
3751         (WebCore::DragData::asFilenames):
3752
3753 2007-05-11  Darin Adler  <darin@apple.com>
3754
3755         * WebCore.vcproj/WebCore.vcproj: Added new RenderWordBreak.cpp/h files.
3756
3757 2007-05-10  Adele Peterson  <adele@apple.com>
3758
3759         Reviewed by Hyatt.
3760
3761         * bridge/win/FrameWin.cpp:
3762         (WebCore::imageFromSelection): Updated to use selectionRect instead of visibleSelectionRect
3763         
3764 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3765
3766         Rubber-stamped by Geoff.
3767
3768         Moved shared EditorWin code to Editor.cpp in open source.
3769
3770         * platform/win/EditorWin.cpp: Deleted (moved) most of this file.
3771
3772 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3773
3774         Reviewed by Darin, Oliver.
3775
3776         Removed localized string stubs.
3777
3778         * platform/win/TemporaryLinkStubs.cpp:
3779
3780 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3781
3782         Reviewed by Ada.
3783
3784         Updated for new editor interface.
3785
3786         * platform/win/EditorWin.cpp:
3787         (WebCore::Editor::advanceToNextMisspelling):
3788         (WebCore::isRangeUngrammatical):
3789
3790 2007-05-07  Alice Liu  <alice.liu@apple.com>
3791
3792         Reviewed by Oliver.
3793
3794         Fixed <rdar://5087119> Paste fidelity isn't as good as it is on the mac
3795         and <rdar://5087118> Plain text copy/paste yields bad line endings on Boomer
3796         and re-organized standalone functions in DragDataWin.cpp and PasteboardWin.cpp
3797         into ClipboardUtilitiesWin.h/cpp.
3798
3799         * WebCore.vcproj/WebCore.vcproj:
3800         * platform/win/ClipboardUtilitiesWin.cpp: Added.
3801         (WebCore::cfHDropFormat):
3802         (WebCore::getWebLocData):
3803         (WebCore::extractURL):
3804         (WebCore::texthtmlFormat):
3805         (WebCore::createGlobalData):
3806         (WebCore::markupToCF_HTML):
3807         (WebCore::urlToMarkup):
3808         (WebCore::replaceNewlinesWithWindowsStyleNewlines):
3809         (WebCore::replaceNBSPWithSpace):
3810         (WebCore::urlWFormat):
3811         (WebCore::urlFormat):
3812         (WebCore::plainTextFormat):
3813         (WebCore::plainTextWFormat):
3814         (WebCore::filenameWFormat):
3815         (WebCore::filenameFormat):
3816         (WebCore::htmlFormat):
3817         (WebCore::getURL):
3818         (WebCore::getPlainText):
3819         (WebCore::fragmentFromFilenames):
3820         (WebCore::containsFilenames):
3821         (WebCore::fragmentFromCF_HTML):
3822         (WebCore::fragmentFromHTML):
3823         (WebCore::containsHTML):
3824         * platform/win/ClipboardUtilitiesWin.h: Added.
3825         * platform/win/ClipboardWin.cpp:
3826         (WebCore::ClipboardWin::writeRange):
3827         * platform/win/DragDataWin.cpp:
3828         * platform/win/PasteboardWin.cpp:
3829         (WebCore::Pasteboard::writeSelection):
3830         (WebCore::Pasteboard::documentFragment):
3831
3832 2007-05-04  Steve Falkenburg  <sfalken@apple.com>
3833
3834         Reviewed by Darin.
3835
3836         Fix crash when using "check spelling while typing".
3837
3838         * WebCore.vcproj/WebCore.vcproj: Added TextBreakIteratorInternalICUWin.cpp
3839         * platform/win/TemporaryLinkStubs.cpp: Removed findSentenceBoundary, findNextSentenceFromIndex.
3840
3841 2007-05-04  Alice Liu  <alice.liu@apple.com>
3842
3843         Reviewed by Darin.
3844
3845         changed use of DeprecatedString::fromUTF8 to UTF8Encoding().decode()
3846
3847         * platform/win/DragDataWin.cpp:
3848         (WebCore::fragmentFromHTML):
3849         * platform/win/PasteboardWin.cpp:
3850         (WebCore::Pasteboard::documentFragment):
3851
3852 2007-05-03  Steve Falkenburg  <sfalken@apple.com>
3853
3854         Reviewed by Ada, Oliver.
3855
3856         Checkpoint:
3857         <rdar://problem/4602372> Spelling
3858         <rdar://problem/4769763> Spell checking engine support
3859
3860         * platform/win/EditorWin.cpp:
3861         (WebCore::findFirstBadGrammarInRange): Account for start offset when reporting bad grammar range (fixed my porting mistake).
3862         (WebCore::Editor::advanceToNextMisspelling): Include user description with spelling error.
3863         (WebCore::isRangeUngrammatical): Include user description with spelling error.
3864
3865 2007-05-03  Alice Liu  <alice.liu@apple.com>
3866
3867         Reviewed by Oliver.
3868
3869         Fixed <rdar://5181466> HTML formatted clipboard data is not converted from UTF8 when pasted
3870
3871         * platform/win/DragDataWin.cpp:
3872         (WebCore::fragmentFromHTML):
3873         * platform/win/PasteboardWin.cpp:
3874         (WebCore::fragmentFromCF_HTML):
3875         (WebCore::Pasteboard::documentFragment):
3876
3877 2007-05-03  Oliver Hunt  <oliver@apple.com>
3878
3879         Reviewed by Steve
3880
3881         Fix misuse of GlobalLock.
3882
3883         * platform/win/PasteboardWin.cpp:
3884         (WebCore::createGlobalData):
3885
3886 2007-05-03  Oliver Hunt  <oliver@apple.com>
3887
3888         Reviewed by Steve.
3889
3890         Add logic to draw underlines for grammar and spelling errors.
3891         (rdar://problem/4769832)
3892
3893         * platform/win/GraphicsContextWin.cpp:
3894         (WebCore::spellingPatternColor):
3895         (WebCore::grammarPatternColor):
3896           Can't define global const with constructor so use function scoped globals instead.
3897         (WebCore::setCGStrokeColor):
3898           Utility function pulled over from GraphicsContextCG          
3899         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3900         
3901         * platform/win/TemporaryLinkStubs.cpp:
3902           Remove old drawLineForMisspellingOrBadGrammar stub
3903
3904 2007-05-01  Steve Falkenburg  <sfalken@apple.com>
3905
3906         Reviewed by Oliver.
3907
3908         Fix crash when retrieving title of context menu after it has been selected.
3909         Necessary to get spelling corrections code working.
3910
3911         * platform/win/ContextMenuWin.cpp:
3912         (WebCore::ContextMenu::itemWithAction): menu item info fType is a set of flags, MFT_STRING is 0, so we need to or off flags before comparing.
3913
3914 2007-04-29  Adam Roben  <aroben@apple.com>
3915
3916         Build fix after r21183.
3917
3918         * WebCore.vcproj/WebCore.vcproj: Added LayoutState.(h|cpp).
3919
3920 2007-04-29  Oliver Hunt  <oliver@apple.com>
3921
3922         Reviewed by Steve.
3923
3924         Fix for <rdar://problem/5126393> REGRESSION (r19672-19697): Safari drag image drags at original size (13261)
3925  
3926         Prevent build bustage from opensource changes, correct scaling
3927
3928         * platform/win/DragImageWin.cpp:
3929         (WebCore::scaleDragImage):
3930
3931 2007-04-24  Steve Falkenburg  <sfalken@apple.com>
3932
3933         Reviewed by Darin, Oliver.
3934
3935         Checkpoint:
3936         <rdar://problem/4602372> Spelling
3937         <rdar://problem/4769763> Spell checking engine support
3938         
3939         Ported code from EditorMac.mm into EditorWin.cpp.
3940         Once this works, I'll move this code into Editor.cpp and remove it
3941         form EditorMac.mm.
3942
3943         * platform/win/EditorWin.cpp:
3944         (WebCore::Editor::ignoreSpelling):
3945         (WebCore::Editor::learnSpelling):
3946         (WebCore::findFirstMisspellingInRange):
3947         (WebCore::paragraphAlignedRangeForRange):
3948         (WebCore::findFirstGrammarDetailInRange):
3949         (WebCore::findFirstBadGrammarInRange):
3950         (WebCore::Editor::advanceToNextMisspelling):
3951         (WebCore::Editor::isSelectionMisspelled):
3952         (WebCore::isRangeUngrammatical):
3953         (WebCore::Editor::isSelectionUngrammatical):
3954         (WebCore::Editor::guessesForUngrammaticalSelection):
3955         (WebCore::Editor::guessesForMisspelledSelection):
3956         (WebCore::Editor::showSpellingGuessPanel):
3957         (WebCore::Editor::spellingPanelIsShowing):
3958         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
3959         (WebCore::markAllMisspellingsInRange):
3960         (WebCore::markAllBadGrammarInRange):
3961         (WebCore::markMisspellingsOrBadGrammar):
3962         (WebCore::Editor::markMisspellings):
3963         (WebCore::Editor::markBadGrammar):
3964         * platform/win/TemporaryLinkStubs.cpp:
3965
3966 2007-04-23  Anders Carlsson  <andersca@apple.com>
3967
3968         Reviewed by Ada.
3969
3970         <rdar://problem/5061022>
3971         REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)
3972         
3973         * page/win/EventHandlerWin.cpp:
3974         (WebCore::EventHandler::passWheelEventToWidget):
3975         Get rid of passWheelEventToSubframe and pass wheel events to all widgets.
3976
3977 2007-04-23  Adam Roben  <aroben@apple.com>
3978
3979         Build fix.
3980
3981         * page/win/EventHandlerWin.cpp: Removed passWheelEventToSubframe.
3982
3983 2007-04-20  Beth Dakin  <bdakin@apple.com>
3984
3985         Reviewed by Adam.
3986
3987         Fix for <rdar://problem/5089822> Boomer does not send scroll events
3988
3989         * platform/win/ScrollViewWin.cpp:
3990         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
3991
3992 2007-04-19  Adam Roben  <aroben@apple.com>
3993
3994         * WebCore.vcproj/WebCore.vcproj: Removed empty filter.
3995
3996 2007-04-19  Adam Roben  <aroben@apple.com>
3997
3998         * WebCore.vcproj/WebCore.vcproj: Removed unused files.
3999
4000 2007-04-18  Adam Roben  <aroben@apple.com>
4001
4002         Reviewed by Oliver.
4003
4004         Added an equality operator to COMPtr.
4005
4006         * platform/win/COMPtr.h:
4007         (operator==):
4008         (operator!=):
4009
4010 2007-04-18  Oliver Hunt  <oliver@apple.com>
4011
4012         Reviewed by Geoff.
4013
4014         Allow images to be dragged from page and dropped as files.
4015         This is the remainder of the fix for <rdar://problem/5035948> 
4016           -- Dragging image or link from boomer doesn't create webloc 
4017              or image file.
4018
4019         * platform/win/ClipboardWin.cpp:
4020         (WebCore::filesystemPathFromUrlOrTitle):
4021           Make name generation nicer, and better match Firefox
4022         
4023         (WebCore::createGlobalURLContent):
4024           rename function
4025         
4026         (WebCore::createGlobalImageFileContent):
4027           Copies image data into global store
4028         
4029         (WebCore::createGlobalUrlFileDescriptor):
4030           Rename function
4031           Updated for parameter change on filesystemPathFromUrlOrTitle
4032         
4033         (WebCore::createGlobalImageFileDescriptor):
4034           Set up file descriptor for image drag
4035         
4036         (WebCore::getCachedImage):
4037           Helper function
4038         
4039         (WebCore::writeImageToDataObject):
4040           Attempts to build and insert data for image->file drag
4041         
4042         (WebCore::ClipboardWin::declareAndWriteDragImage):
4043           Attempts to build and insert data for image->file drag
4044         
4045         (WebCore::ClipboardWin::writeURL):
4046           Add call to imageDataToDataObject
4047
4048 2007-04-17  Adam Roben  <aroben@apple.com>
4049
4050         Rubberstamped by Oliver.
4051
4052         * platform/network/cf/ResourceHandleCFNet.cpp: Removed an unnecessary
4053         include.
4054
4055 2007-04-17  Oliver Hunt  <oliver@apple.com>
4056
4057         Whoops, had code commented out from manual failure test.
4058         Also fixed date of previous changelog entry
4059
4060         * platform/win/ClipboardWin.cpp:
4061         (WebCore::writeFileToDataObject):
4062
4063 2007-04-17  Oliver Hunt  <oliver@apple.com>
4064
4065         Reviewed by Ada.
4066
4067         Partial fix for <rdar://problem/5035948> -- Dragging image 
4068         or link from boomer doesn't create webloc or image file.
4069         
4070         Add all the ground work to set up FileDescriptors and FileContent
4071         for allowing files to be created from drag and drop actions,
4072         and hook up logic for links to create WebLoc data for drag and drop.
4073
4074         * platform/win/ClipboardWin.cpp:
4075         (WebCore::fileDescriptorFormat):
4076         (WebCore::fileContentFormat):
4077           Clipboard formats 
4078           
4079         (WebCore::pathRemoveBadFSCharacters):
4080         (WebCore::filesystemPathFromUrlOrTitle):
4081           Helper functions for create filenames
4082           
4083         (WebCore::createGlobalDataForURLContent):
4084           Create the WebLoc content
4085           
4086         (WebCore::createGlobalDataForUrlFileDescriptor):
4087           Create a file descriptor for the WebLoc data
4088           
4089         (WebCore::writeFileToDataObject):
4090           Basic helper function to push generated file info
4091           into the target DataObject
4092           
4093         (WebCore::ClipboardWin::writeURL):
4094           Now puts WebLoc file onto the Clipboard
4095
4096 2007-04-16  Adam Roben  <aroben@apple.com>
4097
4098         Reviewed by Adele.
4099
4100         Fix <rdar://problem/5002577> Focus ring SPI in GraphicsContextWin.cpp
4101         needs to move to WebKitSystemInterface
4102
4103         * platform/win/GraphicsContextWin.cpp:
4104         (WebCore::GraphicsContext::drawFocusRing): Use wkDrawFocusRing.
4105
4106 2007-04-14  Adam Roben  <aroben@apple.com>
4107
4108         * WebCore.vcproj/WebCore.submit.sln: Use the Debug_Internal
4109         configuration.
4110
4111 2007-04-14  Adam Roben  <aroben@apple.com>
4112
4113         Small correctness fix that is needed for building OpenSource.
4114
4115         * platform/win/PopupMenuWin.cpp: Use RenderTheme instead of RenderThemeWin.
4116
4117 2007-04-13  Adam Roben  <aroben@apple.com>
4118
4119         Reviewed by Tim.
4120
4121         Sync our config.h with the OpenSource version so we can merge ours in
4122         later.
4123
4124         * config.h: Added #defines from the OpenSource version, moved
4125         Windows-specific defines inside #if PLATFORM(WIN[_OS]), and got rid
4126         of assert.h
4127         * platform/win/CursorWin.cpp:
4128         (WebCore::Cursor::Cursor): Use ASSERT instead of assert.
4129
4130 2007-04-13  Adam Roben  <aroben@apple.com>
4131
4132         Rubberstamped by Tim.
4133
4134         Removed the loader/win directory since it only contains empty files.
4135
4136         * WebCore.vcproj/WebCore.vcproj: Removed empty files.
4137         * loader/win/FrameLoaderWin.cpp: Removed.
4138         * loader/win/ResourceLoaderWin.cpp: Removed.
4139
4140 2007-04-12  Adam Roben  <aroben@apple.com>
4141
4142         Rubberstamped by Steve.
4143
4144         Removed unused file.
4145
4146         * WebCore.vcproj/WebCore.sln: Removed.
4147
4148 2007-04-12  Adam Roben  <aroben@apple.com>
4149
4150         Didn't mean to commit this.
4151
4152         * WebCore.vcproj/WebCore.vcproj:
4153
4154 2007-04-12  Adam Roben  <aroben@apple.com>
4155
4156         Reviewed by Steve.
4157
4158         <rdar://problem/5131565> Need to be able to use debug WebKit with
4159         release Safari.
4160
4161         * WebCore.vcproj/WebCore.vcproj:
4162         * WebCore.vcproj/debug.vsprops:
4163         * WebCore.vcproj/debug_internal.vsprops: Added.
4164         * WebCore.vcproj/release.vsprops:
4165
4166 2007-04-11  Adam Roben  <aroben@apple.com>
4167
4168         Reviewed by Tim.
4169
4170         Get rid of FrameViewWin.cpp, since it's empty.
4171
4172         * WebCore.vcproj/WebCore.vcproj:
4173         * bridge/win/FrameViewWin.cpp: Removed.
4174
4175 2007-04-11  Adam Roben  <aroben@apple.com>
4176
4177         Reviewed by Anders.
4178
4179         Update for changes to Pasteboard.
4180
4181         * platform/win/PasteboardWin.cpp:
4182         (WebCore::Pasteboard::writeImage):
4183
4184 2007-04-10  Brady Eidson  <beidson@apple.com>
4185
4186         Reviewed by Darin
4187
4188         <rdar://problem/4887095> - PageCache and PageState should be combined
4189
4190         Changed a TemporaryLinkStub and updated the project file
4191
4192         * WebCore.vcproj/WebCore.vcproj:
4193         * platform/win/TemporaryLinkStubs.cpp:
4194         (CachedPage::close):
4195
4196 2007-04-10  John Sullivan  <sullivan@apple.com>
4197
4198         * platform/win/TemporaryLinkStubs.cpp:
4199         (WebCore::Editor::markBadGrammar):
4200         Keep build going: added stub for this new method
4201
4202 2007-04-10  Anders Carlsson  <andersca@apple.com>
4203
4204         Reviewed by Adam.
4205
4206         <rdar://problem/5056988>
4207         Can not open player on http://radioalice.com
4208
4209         Fix scriptStringIfJavaScriptURL to not use the path of the URL. This would ignore any characters past 
4210         a '?' character because that would be parsed as the query part of the URL.
4211         
4212         * plugins/win/PluginViewWin.cpp:
4213         (WebCore::scriptStringIfJavaScriptURL):
4214         Make this be more like the mac, chopping off the first 12 characters ("javascript:") 
4215         and then decoding the remaining characters.
4216
4217 2007-04-10  Anders Carlsson  <acarlsson@apple.com>
4218
4219         * plugins/win/PluginViewWin.cpp:
4220         (WebCore::PluginViewWin::PluginViewWin):
4221         Initialize m_status.
4222
4223 2007-04-09  Anders Carlsson  <acarlsson@apple.com>
4224
4225         Reviewed by Adam.
4226
4227         <rdar://problem/5062624>
4228         No prompt to install QT for pages with uninstalled QT plug-in.
4229         
4230         Add a status() accessor to PluginViewWin. This can be used by WebKit to find out if the plug-in
4231         loaded successfully or not.
4232         
4233         * plugins/win/PluginViewWin.cpp:
4234         (WebCore::PluginViewWin::PluginViewWin):
4235         (WebCore::PluginViewWin::init):
4236         * plugins/win/PluginViewWin.h:
4237         (WebCore::):
4238         (WebCore::PluginViewWin::status):
4239
4240 2007-04-09  Brady Eidson  <beidson@apple.com>
4241
4242         Build fix
4243
4244         * plugins/win/PluginViewWin.cpp:
4245         (WebCore::PluginViewWin::performRequest): assume userGesture is true
4246
4247 2007-04-09  Adam Roben  <aroben@apple.com>
4248
4249         Build fix.
4250
4251         * platform/win/PasteboardWin.cpp:
4252         (WebCore::Pasteboard::writeImage):
4253
4254 2007-04-08  Adam Roben  <aroben@apple.com>
4255
4256         Reviewed by Oliver.
4257
4258         Stubbed out Frame::dashboardRegionsChanged now that it's not
4259         Mac-specific.
4260
4261         * bridge/win/FrameWin.cpp:
4262         (WebCore::Frame::dashboardRegionsChanged):
4263
4264 2007-04-06  Oliver Hunt  <oliver@apple.com>
4265
4266         Reviewed by Adam.
4267
4268         Fix for rdar://problem/5097227 Can't drag Flash-based 
4269         scrollbar on mtv.com
4270         
4271         The problem was when creating a mouse move event for the 
4272         plugin we weren't passing on the mouse button state.  
4273         
4274         The opensource side of this patch adds logic that allows 
4275         us to distinguish between a MouseEvent with NoButton and
4276         a MouseEvent with LeftButton, so we can then provide the 
4277         correct information to the plugin.
4278
4279         * plugins/win/PluginViewWin.cpp:
4280         (WebCore::PluginViewWin::handleMouseEvent):
4281
4282 2007-04-06  Dave Hyatt  <hyatt@apple.com>
4283
4284         Internal side of fix for bug 13274.
4285
4286         Reviewed by olliej
4287
4288         * page/win/EventHandlerWin.cpp:
4289         (WebCore::EventHandler::passMousePressEventToSubframe):
4290         * platform/win/PlatformScrollBarSafari.cpp:
4291         (WebCore::PlatformScrollbar::handleMousePressEvent):
4292         * platform/win/PopupMenuWin.cpp:
4293         (WebCore::PopupMenu::PopupMenu):
4294         (WebCore::PopupWndProc):
4295         * platform/win/ScrollViewWin.cpp:
4296         (WebCore::ScrollView::removeChild):
4297         * platform/win/WidgetWin.cpp:
4298
4299 2007-04-07  Mark Rowe  <mrowe@apple.com>
4300
4301         Internal build fox after opensource r20753.
4302
4303         * platform/win/PlatformMouseEventWin.cpp:
4304         * platform/win/TemporaryLinkStubs.cpp:
4305
4306 2007-04-03  Oliver Hunt  <oliver@apple.com>
4307
4308         Buildfix
4309
4310         * platform/network/cf/ResourceResponseCFNet.cpp:
4311         (WebCore::ResourceResponse::doUpdateResourceResponse):
4312            Adding .get() calls
4313
4314 2007-04-03  Maciej Stachowiak  <mjs@apple.com>
4315
4316         Reviewed by Alice.
4317
4318         - fixed <rdar://problem/5107069> WebCore leaks a copy of the CFHTTPMessage CFDictionary (from CFHTTPMessageCopyAllHeaderFields)
4319
4320         * platform/network/cf/ResourceResponseCFNet.cpp:
4321         (WebCore::ResourceResponse::doUpdateResourceResponse): Use RetainPtr (once to avoid a leak and once
4322         just as style cleanup).
4323
4324 2007-04-02  Anders Carlsson  <andersca@apple.com>
4325
4326         Reviewed by Adam.
4327
4328         Fix crashes seen when running the plugin layout tests.
4329         
4330         * plugins/win/PluginPackageWin.cpp:
4331         (WebCore::PluginPackageWin::load):
4332         Fill in the enumerate pointer, not the evaluate pointer (it's already been filled in).
4333         
4334         * plugins/win/PluginStreamWin.cpp:
4335         (WebCore::PluginStreamWin::didFinishLoading):
4336         Handle the case where there was no plugin stream data at all.
4337
4338 2007-04-02  Anders Carlsson  <andersca@apple.com>
4339
4340         Reviewed by Darin.
4341
4342         Check that NPStream pointers passed to NPN_DestroyStream are valid.
4343         
4344         * plugins/win/PluginStreamWin.cpp:
4345         (WebCore::streams):
4346         (WebCore::PluginStreamWin::PluginStreamWin):
4347         (WebCore::PluginStreamWin::~PluginStreamWin):
4348         (WebCore::PluginStreamWin::ownerForStream):
4349         * plugins/win/PluginStreamWin.h:
4350         * plugins/win/PluginViewWin.cpp:
4351         (WebCore::PluginViewWin::destroyStream):
4352
4353 2007-04-02  Anders Carlsson  <andersca@apple.com>
4354
4355         Reviewed by Darin.
4356
4357         <rdar://problem/5095582>
4358         PluginViewWin doesn't implement NPN_DestroyStream.
4359
4360         * plugins/win/PluginStreamWin.cpp:
4361         (WebCore::PluginStreamWin::startStream):
4362         Handle the case where NPN_DestroyStream is called from the newstream handler.
4363         
4364         * plugins/win/PluginViewWin.cpp:
4365         (WebCore::PluginViewWin::destroyStream):
4366         Implement this.
4367
4368 2007-04-02  Anders Carlsson  <andersca@apple.com>
4369
4370         Reviewed by Dave Hyatt.
4371
4372         <rdar://problem/5097225> 
4373         Mouse cursors don't work with windowless plugins
4374         
4375         * platform/win/WidgetWin.cpp:
4376         (WebCore::Widget::setCursor):
4377         Add an "ignoreNextSetCursor" boolean and don't call SetCursor if it's true.
4378         
4379         * plugins/win/PluginViewWin.cpp:
4380         (WebCore::PluginViewWin::handleMouseEvent):
4381         Store away the current cursor and make sure that it won't be reset.
4382
4383 2007-04-02  Anders Carlsson  <andersca@apple.com>
4384
4385         Reviewed by Adam.
4386
4387         Fix logic in windowless paint functions.
4388         
4389         * plugins/win/PluginViewWin.cpp:
4390         (WebCore::PluginViewWin::invalidateRect):
4391         (WebCore::PluginViewWin::invalidateRegion):
4392         (WebCore::PluginViewWin::forceRedraw):
4393
4394 2007-03-31  Dave Hyatt  <hyatt@apple.com>
4395
4396         Internal side of 13234.   Open source side was reviewed by
4397         Mitz.  Layout of justified text was broken when dragged or
4398         when a ::selection style was in effect.
4399
4400         * platform/win/FontWin.cpp:
4401         (WebCore::Font::selectionRectForComplexText):
4402         (WebCore::Font::drawComplexText):