2009-01-14 Jeremy Moskovich <jeremy@chromium.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-01-14  Jeremy Moskovich  <jeremy@chromium.org>
2
3         Reviewed by Eric Seidel.
4
5         <https://bugs.webkit.org/show_bug.cgi?id=16829>
6         Implement NPN_SetException()
7
8         This mirrors the implementation in the obj-c bindings.
9
10         Test: plugins/netscape-throw-exception.html
11
12         * bridge/NP_jsobject.cpp:
13         (_NPN_SetException):
14         * bridge/c/c_instance.cpp:
15         (JSC::Bindings::getExceptionString):
16         (JSC::Bindings::CInstance::setGlobalException):
17         (JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
18         (JSC::Bindings::CInstance::invokeMethod):
19         (JSC::Bindings::CInstance::invokeDefaultMethod):
20         (JSC::Bindings::CInstance::invokeConstruct):
21         (JSC::Bindings::CInstance::getPropertyNames):
22         * bridge/c/c_instance.h:
23
24 2009-01-14  Pierre-Olivier Latour  <pol@apple.com>
25
26         Fixed build warning when LIBXML_VERSION >= 20627.
27
28         * dom/XMLTokenizerLibxml2.cpp:
29         (WebCore::hackAroundLibXMLEntityBug):
30
31 2009-01-14  Alexey Proskuryakov  <ap@webkit.org>
32
33         Reviewed by Anders Carlsson.
34
35         https://bugs.webkit.org/show_bug.cgi?id=23326
36         Resources are never deleted from application cache disk database
37
38         * loader/appcache/ApplicationCacheStorage.cpp:
39         (WebCore::ApplicationCacheStorage::openDatabase): Create a trigger that deletes resources when
40         a cache is deleted. Note that this change doesn't require bumping schema version. We should
41         consider switching to foreign keys and cascade delete instead of triggers in the future.
42         (WebCore::ApplicationCacheStorage::remove): Added a comment explaining why it's sufficient
43         to only remove the cache itself.
44         (WebCore::ApplicationCacheStorage::empty): Don't delete from CacheResources, now that this
45         is done automatically when a cache is deleted.
46
47 2009-01-14  David Kilzer  <ddkilzer@apple.com>
48
49         Bug 22795: favicons should be saved to webarchives
50
51         <https://bugs.webkit.org/show_bug.cgi?id=22795>
52
53         Reviewed by Darin Adler.
54
55         Test: webarchive/test-link-rel-icon.html
56
57         * html/HTMLLinkElement.cpp:
58         (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Do not add
59         favicon URLs to the list since no ArchiveResource or CachedResource
60         is ever created for them.
61         * loader/archive/cf/LegacyWebArchive.cpp:
62         (WebCore::LegacyWebArchive::create): Handle favicons as a special
63         case for all main resources.
64         * loader/icon/IconDatabase.cpp:
65         (WebCore::IconDatabase::close): Actually close the SQLite database
66         so that isOpen() returns false when called.  Added an ASSERT() for
67         good measure.
68
69 2009-01-14  Dimitri Glazkov  <dglazkov@chromium.org>
70
71         Reviewed by Eric Seidel.
72         
73         https://bugs.webkit.org/show_bug.cgi?id=23321
74         Upstream more bits of graphics/chromium.
75         
76         * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: Added.
77         (WebCore::FontPlatformData::FontPlatformData):
78         (WebCore::FontPlatformData::operator=):
79         (WebCore::FontPlatformData::~FontPlatformData):
80         (WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):
81         (WebCore::FontPlatformData::hashTableDeletedFontValue):
82         (WebCore::FontPlatformData::scriptFontProperties):
83         * platform/graphics/chromium/FontPlatformDataChromiumWin.h: Added.
84         (WebCore::FontPlatformData::isHashTableDeletedValue):
85         (WebCore::FontPlatformData::hfont):
86         (WebCore::FontPlatformData::size):
87         (WebCore::FontPlatformData::hash):
88         (WebCore::FontPlatformData::operator==):
89         (WebCore::FontPlatformData::scriptCache):
90         (WebCore::FontPlatformData::RefCountedHFONT::create):
91         (WebCore::FontPlatformData::RefCountedHFONT::hfont):
92         (WebCore::FontPlatformData::RefCountedHFONT::hash):
93         (WebCore::FontPlatformData::RefCountedHFONT::operator==):
94         (WebCore::FontPlatformData::RefCountedHFONT::RefCountedHFONT):
95         * platform/graphics/chromium/FontPlatformDataLinux.cpp: Added.
96         (WebCore::FontPlatformData::FontPlatformData):
97         (WebCore::FontPlatformData::~FontPlatformData):
98         (WebCore::FontPlatformData::operator=):
99         (WebCore::FontPlatformData::setupPaint):
100         (WebCore::FontPlatformData::operator==):
101         (WebCore::FontPlatformData::hash):
102         (WebCore::FontPlatformData::isFixedPitch):
103         * platform/graphics/chromium/FontPlatformDataLinux.h: Added.
104         (WebCore::FontPlatformData::FontPlatformData):
105         (WebCore::FontPlatformData::size):
106         (WebCore::FontPlatformData::isHashTableDeletedValue):
107         (WebCore::FontPlatformData::hashTableDeletedFontValue):
108         * platform/graphics/chromium/FontUtilsChromiumWin.cpp: Added.
109         (WebCore::):
110         (WebCore::FontMap::getAscent):
111         (WebCore::FontMap::FontData::FontData):
112         (WebCore::getFontFamilyForScript):
113         (WebCore::getFallbackFamily):
114         (WebCore::getDerivedFontData):
115         (WebCore::getStyleFromLogfont):
116         * platform/graphics/chromium/FontUtilsChromiumWin.h: Added.
117         (WebCore::):
118
119 2009-01-14  Dimitri Glazkov  <dglazkov@chromium.org>
120
121         Reviewed by Eric Seidel.
122
123         https://bugs.webkit.org/show_bug.cgi?id=23325
124         Upstream even more graphics/chromium bits.
125
126         * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: Added.
127         (WebCore::fillEmptyGlyphs):
128         (WebCore::initSpaceGlyph):
129         (WebCore::fillBMPGlyphs):
130         (WebCore::fillNonBMPGlyphs):
131         (WebCore::GlyphPage::fill):
132         * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Added.
133         (WebCore::GlyphPage::fill):
134         * platform/graphics/chromium/IconChromiumLinux.cpp: Added.
135         (WebCore::Icon::Icon):
136         (WebCore::Icon::~Icon):
137         (WebCore::Icon::createIconForFile):
138         (WebCore::Icon::createIconForFiles):
139         (WebCore::Icon::paint):
140         * platform/graphics/chromium/IconChromiumMac.cpp: Added.
141         (WebCore::Icon::createIconForFile):
142         (WebCore::Icon::createIconForFiles):
143         (WebCore::Icon::~Icon):
144         (WebCore::Icon::paint):
145         * platform/graphics/chromium/IconChromiumWin.cpp: Added.
146         (WebCore::Icon::Icon):
147         (WebCore::Icon::~Icon):
148         (WebCore::Icon::createIconForFile):
149         (WebCore::Icon::createIconForFiles):
150         (WebCore::Icon::paint):
151         * platform/graphics/chromium/ImageBufferData.h: Added.
152         * platform/graphics/chromium/ImageChromiumMac.mm: Added.
153         (WebCore::Image::loadPlatformResource):
154         (WebCore::BitmapImage::initPlatformData):
155         (WebCore::BitmapImage::invalidatePlatformData):
156         * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Added.
157         * platform/graphics/chromium/PlatformIcon.h: Added.
158
159 2009-01-14  Darin Fisher  <darin@chromium.org>
160
161         Reviewed by Eric Seidel.
162
163         https://bugs.webkit.org/show_bug.cgi?id=23328
164         Upstream remaining files from platform/chromium/
165
166         * platform/chromium/CursorChromium.cpp:
167         (WebCore::pointerCursor):
168         (WebCore::crossCursor):
169         (WebCore::handCursor):
170         (WebCore::iBeamCursor):
171         (WebCore::waitCursor):
172         (WebCore::helpCursor):
173         (WebCore::eastResizeCursor):
174         (WebCore::northResizeCursor):
175         (WebCore::northEastResizeCursor):
176         (WebCore::northWestResizeCursor):
177         (WebCore::southResizeCursor):
178         (WebCore::southEastResizeCursor):
179         (WebCore::southWestResizeCursor):
180         (WebCore::westResizeCursor):
181         (WebCore::northSouthResizeCursor):
182         (WebCore::eastWestResizeCursor):
183         (WebCore::northEastSouthWestResizeCursor):
184         (WebCore::northWestSouthEastResizeCursor):
185         (WebCore::columnResizeCursor):
186         (WebCore::rowResizeCursor):
187         (WebCore::middlePanningCursor):
188         (WebCore::eastPanningCursor):
189         (WebCore::northPanningCursor):
190         (WebCore::northEastPanningCursor):
191         (WebCore::northWestPanningCursor):
192         (WebCore::southPanningCursor):
193         (WebCore::southEastPanningCursor):
194         (WebCore::southWestPanningCursor):
195         (WebCore::westPanningCursor):
196         (WebCore::moveCursor):
197         (WebCore::verticalTextCursor):
198         (WebCore::cellCursor):
199         (WebCore::contextMenuCursor):
200         (WebCore::aliasCursor):
201         (WebCore::progressCursor):
202         (WebCore::noDropCursor):
203         (WebCore::copyCursor):
204         (WebCore::noneCursor):
205         (WebCore::notAllowedCursor):
206         (WebCore::zoomInCursor):
207         (WebCore::zoomOutCursor):
208         * platform/chromium/DragDataRef.h: Added.
209         * platform/chromium/DragImageChromium.cpp: Added.
210         (WebCore::dragImageSize):
211         (WebCore::deleteDragImage):
212         (WebCore::scaleDragImage):
213         (WebCore::dissolveDragImageToFraction):
214         (WebCore::createDragImageFromImage):
215         (WebCore::createDragImageIconForCachedImage):
216         * platform/chromium/DragImageRef.h:
217         * platform/chromium/KeyCodeConversion.h: Added.
218         * platform/chromium/KeyCodeConversionGtk.cpp: Added.
219         (WebCore::windowsKeyCodeForKeyEvent):
220         * platform/chromium/KeyboardCodes.h: Added.
221         * platform/chromium/KeyboardCodesPosix.h: Added.
222         (WebCore::):
223         * platform/chromium/KeyboardCodesWin.h: Added.
224         (WebCore::):
225         * platform/chromium/Language.cpp: Added.
226         (WebCore::defaultLanguage):
227         * platform/chromium/LinkHashChromium.cpp: Added.
228         (WebCore::visitedLinkHash):
229         * platform/chromium/MimeTypeRegistryChromium.cpp: Added.
230         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
231         (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
232         (WebCore::MIMETypeRegistry::getMIMETypeForPath):
233         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
234         (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
235         (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
236         (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
237         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
238         (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType):
239         (WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
240         (WebCore::dummyHashSet):
241         (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
242         (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
243         (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding):
244         (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
245         (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
246         * platform/chromium/PasteboardChromium.cpp: Added.
247         (WebCore::Pasteboard::generalPasteboard):
248         (WebCore::Pasteboard::Pasteboard):
249         (WebCore::Pasteboard::clear):
250         (WebCore::Pasteboard::writeSelection):
251         (WebCore::Pasteboard::writeURL):
252         (WebCore::Pasteboard::writeImage):
253         (WebCore::Pasteboard::canSmartReplace):
254         (WebCore::Pasteboard::plainText):
255         (WebCore::Pasteboard::documentFragment):
256         * platform/chromium/PasteboardPrivate.h:
257         * platform/chromium/PlatformCursor.h: Added.
258         (WebCore::PlatformCursor::):
259         (WebCore::PlatformCursor::PlatformCursor):
260         (WebCore::PlatformCursor::customImage):
261         (WebCore::PlatformCursor::hotSpot):
262         (WebCore::PlatformCursor::type):
263         * platform/chromium/PlatformKeyboardEventChromium.cpp: Added.
264         (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
265         (WebCore::PlatformKeyboardEvent::currentCapsLockState):
266         * platform/chromium/PlatformScreenChromium.cpp: Added.
267         (WebCore::screenDepth):
268         (WebCore::screenDepthPerComponent):
269         (WebCore::screenIsMonochrome):
270         (WebCore::screenRect):
271         (WebCore::screenAvailableRect):
272         * platform/chromium/PlatformWidget.h:
273         * platform/chromium/PopupMenuChromium.cpp: Added.
274         (WebCore::PopupListBox::selectedIndex):
275         (WebCore::PopupListBox::numItems):
276         (WebCore::PopupListBox::setBaseWidth):
277         (WebCore::PopupListBox::setTextOnIndexChange):
278         (WebCore::PopupListBox::setAcceptOnAbandon):
279         (WebCore::PopupListBox::):
280         (WebCore::PopupListBox::ListItem::ListItem):
281         (WebCore::PopupListBox::PopupListBox):
282         (WebCore::PopupListBox::~PopupListBox):
283         (WebCore::PopupListBox::disconnectClient):
284         (WebCore::PopupListBox::scrollToRevealSelection):
285         (WebCore::constructRelativeMouseEvent):
286         (WebCore::constructRelativeWheelEvent):
287         (WebCore::PopupContainer::create):
288         (WebCore::PopupContainer::PopupContainer):
289         (WebCore::PopupContainer::~PopupContainer):
290         (WebCore::PopupContainer::showPopup):
291         (WebCore::PopupContainer::hidePopup):
292         (WebCore::PopupContainer::layout):
293         (WebCore::PopupContainer::handleMouseDownEvent):
294         (WebCore::PopupContainer::handleMouseMoveEvent):
295         (WebCore::PopupContainer::handleMouseReleaseEvent):
296         (WebCore::PopupContainer::handleWheelEvent):
297         (WebCore::PopupContainer::handleKeyEvent):
298         (WebCore::PopupContainer::hide):
299         (WebCore::PopupContainer::paint):
300         (WebCore::PopupContainer::paintBorder):
301         (WebCore::PopupContainer::isInterestedInEventForKey):
302         (WebCore::PopupContainer::show):
303         (WebCore::PopupContainer::setTextOnIndexChange):
304         (WebCore::PopupContainer::setAcceptOnAbandon):
305         (WebCore::PopupContainer::refresh):
306         (WebCore::PopupListBox::handleMouseDownEvent):
307         (WebCore::PopupListBox::handleMouseMoveEvent):
308         (WebCore::PopupListBox::handleMouseReleaseEvent):
309         (WebCore::PopupListBox::handleWheelEvent):
310         (WebCore::PopupListBox::isInterestedInEventForKey):
311         (WebCore::PopupListBox::handleKeyEvent):
312         (WebCore::PopupListBox::hostWindow):
313         (WebCore::PopupListBox::invalidateRect):
314         (WebCore::stripLeadingWhiteSpace):
315         (WebCore::PopupListBox::typeAheadFind):
316         (WebCore::PopupListBox::paint):
317         (WebCore::PopupListBox::paintRow):
318         (WebCore::PopupListBox::getRowFont):
319         (WebCore::PopupListBox::abandon):
320         (WebCore::PopupListBox::pointToRowIndex):
321         (WebCore::PopupListBox::acceptIndex):
322         (WebCore::PopupListBox::selectIndex):
323         (WebCore::PopupListBox::setOriginalIndex):
324         (WebCore::PopupListBox::getRowHeight):
325         (WebCore::PopupListBox::getRowBounds):
326         (WebCore::PopupListBox::invalidateRow):
327         (WebCore::PopupListBox::scrollToRevealRow):
328         (WebCore::PopupListBox::isSelectableItem):
329         (WebCore::PopupListBox::adjustSelectedIndex):
330         (WebCore::PopupListBox::updateFromElement):
331         (WebCore::PopupListBox::layout):
332         (WebCore::PopupListBox::clear):
333         (WebCore::PopupListBox::isPointInBounds):
334         (WebCore::PopupMenu::PopupMenu):
335         (WebCore::PopupMenu::~PopupMenu):
336         (WebCore::PopupMenu::show):
337         (WebCore::PopupMenu::hide):
338         (WebCore::PopupMenu::updateFromElement):
339         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
340         * platform/chromium/PopupMenuChromium.h: Added.
341         (WebCore::PopupContainer::listBox):
342         * platform/chromium/PopupMenuPrivate.h: Added.
343         * platform/chromium/SSLKeyGeneratorChromium.cpp: Added.
344         (WebCore::supportedKeySizes):
345         * platform/chromium/ScrollbarThemeChromium.cpp: Added.
346         (WebCore::ScrollbarTheme::nativeTheme):
347         (WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
348         (WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
349         (WebCore::ScrollbarThemeChromium::themeChanged):
350         (WebCore::ScrollbarThemeChromium::hasThumb):
351         (WebCore::ScrollbarThemeChromium::backButtonRect):
352         (WebCore::ScrollbarThemeChromium::forwardButtonRect):
353         (WebCore::ScrollbarThemeChromium::trackRect):
354         (WebCore::ScrollbarThemeChromium::paintTrackBackground):
355         (WebCore::ScrollbarThemeChromium::paintTickmarks):
356         (WebCore::ScrollbarThemeChromium::paintScrollCorner):
357         (WebCore::ScrollbarThemeChromium::shouldCenterOnThumb):
358         (WebCore::ScrollbarThemeChromium::buttonSize):
359         * platform/chromium/ScrollbarThemeChromium.h: Added.
360         (WebCore::ScrollbarThemeChromium::hasButtons):
361         * platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added.
362         (WebCore::ScrollbarThemeChromium::scrollbarThickness):
363         (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
364         (WebCore::initMozState):
365         (WebCore::paintScrollbarWidget):
366         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
367         (WebCore::ScrollbarThemeChromium::paintButton):
368         (WebCore::ScrollbarThemeChromium::paintThumb):
369         * platform/chromium/ScrollbarThemeChromiumWin.cpp:
370         * platform/chromium/SearchPopupMenuChromium.cpp: Added.
371         (WebCore::SearchPopupMenu::SearchPopupMenu):
372         (WebCore::SearchPopupMenu::enabled):
373         (WebCore::SearchPopupMenu::saveRecentSearches):
374         (WebCore::SearchPopupMenu::loadRecentSearches):
375         * platform/chromium/SharedTimerChromium.cpp: Added.
376         (WebCore::setSharedTimerFiredFunction):
377         (WebCore::setSharedTimerFireTime):
378         (WebCore::stopSharedTimer):
379         * platform/chromium/TemporaryLinkStubs.cpp: Added.
380         (WebCore::signedPublicKeyAndChallengeString):
381         (WebCore::getSupportedKeySizes):
382         (WebCore::KURL::fileSystemPath):
383         (WebCore::SharedBuffer::createWithContentsOfFile):
384         (WTF::scheduleDispatchFunctionsOnMainThread):
385
386 2009-01-14  Darin Fisher  <darin@chromium.org>
387
388         Reviewed by Eric Seidel.
389
390         https://bugs.webkit.org/show_bug.cgi?id=23323
391         Upstream platform/text/chromium/
392
393         * platform/text/chromium: Added.
394         * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: Added.
395         (WebCore::currentTextBreakLocaleID):
396
397 2009-01-14  Steve Falkenburg  <sfalken@apple.com>
398
399         Update copyright year in version resources.
400
401         Reviewed by Adam Roben.
402
403         * WebCore.vcproj/QTMovieWin.rc:
404
405 2009-01-14  Darin Fisher  <darin@chromium.org>
406
407         Reviewed by Darin Adler.
408
409         https://bugs.webkit.org/show_bug.cgi?id=23324
410         Move platform/chromium/EditorChromium.cpp into editing/chromium/
411
412         * editing/chromium: Added.
413         * editing/chromium/EditorChromium.cpp: Copied from platform/chromium/EditorChromium.cpp.
414         * platform/chromium/EditorChromium.cpp: Removed.
415
416 2009-01-14  Darin Fisher  <darin@chromium.org>
417
418         Reviewed by Darin Adler.
419
420         https://bugs.webkit.org/show_bug.cgi?id=23320
421         Make it possible to use notImplemented outside of the WebCore namespace
422
423         * platform/NotImplemented.h:
424
425 2009-01-14  Nigel Tao  <nigel.tao.gnome@gmail.com>
426
427         Reviewed by Darin Adler.
428
429         - fix https://bugs.webkit.org/show_bug.cgi?id=22476
430         Check that the document's SecurityOrigin canLoadLocalResources,
431         when pages try to put NSFilenamesPboardtype data on the clipboard,
432         by calling event.dataTransfer.setData('URL', 'file:///foo/bar');
433
434         Tests: http/tests/security/dataTransfer-set-data-file-url.html
435                platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html
436
437         * platform/mac/ClipboardMac.mm:
438         (WebCore::ClipboardMac::setData):
439
440 2009-01-14  Dan Bernstein  <mitz@apple.com>
441
442         Reviewed by John Sullivan.
443
444         - update copyright
445
446         * Info.plist:
447
448 2009-01-14  Alexey Proskuryakov  <ap@webkit.org>
449
450         Reviewed by Darin Adler.
451
452         https://bugs.webkit.org/show_bug.cgi?id=23316
453         Application cache updating always fails with an assertion
454
455         Test: http/tests/appcache/update-cache.html
456
457         * loader/appcache/ApplicationCacheGroup.cpp:
458         (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Correctly handle the case where
459         multiple caches survive the last DocumentLoader destruction, preventing a crash in release
460         builds.
461         (WebCore::ApplicationCacheGroup::setNewestCache): Removed a bogus assertion.
462
463 2009-01-14  Alexey Proskuryakov  <ap@webkit.org>
464
465         Release build fix.
466
467         * loader/appcache/ApplicationCacheStorage.cpp:
468         (WebCore::ApplicationCacheStorage::storeUpdatedType): Use ASSERT_UNUSED.
469
470 2009-01-13  Alexey Proskuryakov  <ap@webkit.org>
471
472         Reviewed by Anders Carlsson.
473
474         Test: http/tests/appcache/xhr-foreign-resource.html
475
476         https://bugs.webkit.org/show_bug.cgi?id=23256
477         Implement application cache foreign entries
478
479         * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
480         Removed a misplaced check for foreign resources that prevented them from being loaded altogether.
481
482         * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
483         If a document that was loaded from appcache should be associated with a different cache,
484         mark the resource as foreign in the original cache and start over.
485
486         * loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::addType):
487         This function can now be called after a cache is stored, so it no longer asserts the opposite.
488
489         * loader/appcache/ApplicationCacheStorage.cpp:
490         (WebCore::ApplicationCacheStorage::cacheGroupForURL): Fix database pass to correctly ignore
491         in-memory caches that were already rejected.
492         (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
493         (WebCore::ApplicationCacheStorage::storeUpdatedType): Added a function that updates type of
494         an already stored cached resource.
495
496         * loader/appcache/ApplicationCacheStorage.h: Added storeUpdatedType().
497
498 2009-01-13  Mark Rowe  <mrowe@apple.com>
499
500         Fix the Tiger WebCore build after r39880.
501
502         * editing/Editor.cpp:
503         (WebCore::Editor::markBadGrammar):
504         * loader/mac/DocumentLoaderMac.cpp:
505         (WebCore::DocumentLoader::schedule):
506         (WebCore::DocumentLoader::unschedule):
507         * platform/mac/PasteboardMac.mm:
508         (WebCore::Pasteboard::writeSelection):
509         * platform/mac/WebCoreObjCExtras.mm:
510         (WebCoreObjCFinalizeOnMainThread):
511         * platform/network/mac/ResourceHandleMac.mm:
512         (WebCore::ResourceHandle::schedule):
513         (WebCore::ResourceHandle::unschedule):
514
515 2009-01-13  Darin Adler  <darin@apple.com>
516
517         Reviewed by Sam Weinig.
518
519         Bug 23102: turn on unused parameter warnings in WebCore
520         https://bugs.webkit.org/show_bug.cgi?id=23102
521
522         Last step: Turn on the warning and fix the last few instances.
523
524         * Configurations/Base.xcconfig: Removed -Wno-unused-parameter from
525         WARNING_CFLAGS_BASE, so the unused parameter warning will fire.
526
527         * bindings/js/JSDOMWindowBase.cpp:
528         (jsDOMWindowBaseMessageChannel): Separate the version for use when
529         CHANNEL_MESSAGING is turned off, so we can omit the argument names.
530         It would be better to not even have this property in that case,
531         rather than having the function return undefined, but I don't know
532         how to do that with the bindings script.
533
534         * bindings/scripts/CodeGeneratorJS.pm: Leave out argument names in
535         functions where they're not used (the SVG context, and the property
536         name in the index getter). Use UNUSED_PARAM where arguments are
537         sometimes not used.
538
539         * bridge/runtime_object.cpp:
540         (JSC::RuntimeObjectImp::put): Use UNUSED_PARAM for non-QT.
541
542         * css/MediaQueryEvaluator.cpp:
543         (WebCore::animationMediaFeatureEval): Omit argument names for style and frame.
544         (WebCore::transitionMediaFeatureEval): Ditto.
545         (WebCore::transform_2dMediaFeatureEval): Ditto.
546         (WebCore::transform_3dMediaFeatureEval): Ditto.
547
548         * dom/make_names.pl: Leave out the createdByParser property name in
549         cases where it's not used.
550
551         * inspector/JavaScriptDebugServer.cpp:
552         (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Separate the
553         version for the Mac platform so we can omit the argument names.
554
555         * loader/EmptyClients.h:
556         (WebCore::EmptyChromeClient::contentsSizeChanged): Removed argument name.
557
558         * loader/FrameLoaderClient.h:
559         (WebCore::FrameLoaderClient::shouldUsePluginDocument): Commented out
560         argument name.
561
562         * loader/icon/IconFetcher.cpp:
563         (WebCore::IconFetcher::didReceiveResponse): Use ASSERT_UNUSED.
564         (WebCore::IconFetcher::didReceiveData): Ditto.
565         (WebCore::IconFetcher::didFinishLoading): Ditto.
566         (WebCore::IconFetcher::didFail): Ditto.
567
568         * platform/KURL.cpp:
569         (WebCore::assertProtocolIsGood): Separate out the NDEBUG version so
570         we can omit the argument names.
571
572         * platform/Timer.cpp:
573         (WebCore::TimerHeapIterator::checkConsistency): Use ASSERT_UNUSED.
574
575         * platform/graphics/GlyphBuffer.h:
576         (WebCore::GlyphBuffer::offsetAt): Use UNUSED_PARAM in the non-WIN case.
577         (WebCore::GlyphBuffer::add): Use UNUSED_PARAM in the non-CAIRO case.
578
579         * platform/graphics/cg/ImageSourceCG.cpp:
580         (WebCore::ImageSource::clear): Removed argument name.
581
582         * rendering/SVGRenderSupport.cpp:
583         (WebCore::prepareToRenderSVGContent): Use UNUSED_PARAM when SVG_FILTERS
584         is not enabled.
585         (WebCore::finishRenderSVGContent): Ditto.
586
587 2009-01-13  Chris Marrin  <cmarrin@apple.com>
588
589         Reviewed by Darin Adler.
590
591         Implemented https://bugs.webkit.org/show_bug.cgi?id=23298
592         Simple fix to convertToLength to catch style==null cases
593
594         * css/CSSStyleSelector.cpp:
595         (WebCore::convertToLength):
596
597 2009-01-13  Eric Seidel  <eric@webkit.org>
598
599         Reviewed by Mark Rowe.
600
601         Speculative fix for an Uninitialized Memory Read (UMR)
602         seen by purify in chormium's equivalent V8 file.
603
604         * bindings/js/JSSVGPODTypeWrapper.h:
605         (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo):
606
607 2009-01-13  Dimitri Glazkov  <dglazkov@chromium.org>
608
609         Reviewed by Eric Seidel.
610
611         Land portions of platform/graphics/chromium.
612         https://bugs.webkit.org/show_bug.cgi?id=23297
613
614         * platform/graphics/chromium/FontCustomPlatformData.cpp: Added.
615         (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
616         (WebCore::FontCustomPlatformData::fontPlatformData):
617         (WebCore::EOTStream::EOTStream):
618         (WebCore::EOTStream::read):
619         (WebCore::readEmbedProc):
620         (WebCore::createUniqueFontName):
621         (WebCore::createFontCustomPlatformData):
622         * platform/graphics/chromium/FontCustomPlatformData.h: Added.
623         (WebCore::FontCustomPlatformData::FontCustomPlatformData):
624         * platform/graphics/chromium/FontLinux.cpp: Added.
625         (WebCore::Font::drawGlyphs):
626         (WebCore::Font::drawComplexText):
627         (WebCore::Font::floatWidthForComplexText):
628         (WebCore::Font::offsetForPositionForComplexText):
629         (WebCore::Font::selectionRectForComplexText):
630         * platform/graphics/chromium/FontPlatformData.h: Added.
631
632 2009-01-13  Mark Rowe  <mrowe@apple.com>
633
634         Rubber-stamped by Oliver Hunt.
635
636         Don't copy DOMStringList.idl into the framework bundle.
637
638         * WebCore.xcodeproj/project.pbxproj:
639
640 2009-01-13  Christian Dywan  <christian@twotoasts.de>
641
642         Build fix, StorageEvent is only defined if we have DOM_STORAGE
643
644         * dom/Document.cpp:
645         (WebCore::Document::createEvent): Conditionalize StorageEvent
646
647 2009-01-13  Darin Adler  <darin@apple.com>
648
649         Reviewed by Adele Peterson.
650
651         Bug 23277: space bar scrolls the page when typed in any text field
652         https://bugs.webkit.org/show_bug.cgi?id=23277
653         rdar://problem/6490249
654
655         There's already a regression test for this, since bug 16421 was the same problem, but on
656         Mac. The regression test is fast/events/space-scroll-event.html, so I won't write a new one.
657
658         This bug doesn't affect Mac because the canEdit check in -[WebHTMLView insertText:] prevents
659         a text input event from being generated at all. That difference may in itself be a bug, but
660         the only symptom is that you get text input events in more cases on platforms other than Mac.
661
662         * page/EventHandler.cpp:
663         (WebCore::EventHandler::handleTextInputEvent): Return whether the event's default was
664         handled, not the result of the dispatchEvent function, which indicates only whether the
665         default behavior was prevented, not if the default behavior did some insertion. This fix
666         makes it so the keyboard event handler can detect that no space was inserted and know that
667         the space bar keypress event can be treated as a scrolling command.
668         (WebCore::EventHandler::defaultKeyboardEventHandler): Handle the keypress event, not the
669         keydown event. Without the change above, making this change would have restored the old
670         behavior, reintroducing bug 22913 where the space bar doesn't scroll at all on Windows.
671
672 2009-01-13  Darin Fisher  <darin@chromium.org>
673
674         Reviewed by Eric Seidel.
675
676         Landing portions of platform/chromium/, taken from here:
677         http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/
678
679         * platform/chromium/ChromiumBridge.h: Added.
680         * platform/chromium/ChromiumDataObject.cpp: Added.
681         (WebCore::ChromiumDataObject::clear):
682         (WebCore::ChromiumDataObject::hasData):
683         * platform/chromium/ChromiumDataObject.h: Added.
684         (WebCore::ChromiumDataObject::create):
685         (WebCore::ChromiumDataObject::ChromiumDataObject):
686         * platform/chromium/ClipboardChromium.cpp: Added.
687         (WebCore::):
688         (WebCore::clipboardTypeFromMIMEType):
689         (WebCore::ClipboardChromium::ClipboardChromium):
690         (WebCore::ClipboardChromium::create):
691         (WebCore::ClipboardChromium::clearData):
692         (WebCore::ClipboardChromium::clearAllData):
693         (WebCore::ClipboardChromium::getData):
694         (WebCore::ClipboardChromium::setData):
695         (WebCore::ClipboardChromium::types):
696         (WebCore::ClipboardChromium::setDragImage):
697         (WebCore::ClipboardChromium::setDragImageElement):
698         (WebCore::ClipboardChromium::createDragImage):
699         (WebCore::imageToMarkup):
700         (WebCore::getCachedImage):
701         (WebCore::writeImageToDataObject):
702         (WebCore::ClipboardChromium::declareAndWriteDragImage):
703         (WebCore::ClipboardChromium::writeURL):
704         (WebCore::ClipboardChromium::writeRange):
705         (WebCore::ClipboardChromium::hasData):
706         * platform/chromium/ClipboardChromium.h: Added.
707         (WebCore::ClipboardChromium::~ClipboardChromium):
708         (WebCore::ClipboardChromium::dataObject):
709         * platform/chromium/ClipboardUtilitiesChromium.cpp: Added.
710         (WebCore::replaceNewlinesWithWindowsStyleNewlines):
711         (WebCore::replaceNBSPWithSpace):
712         (WebCore::urlToMarkup):
713         * platform/chromium/ClipboardUtilitiesChromium.h: Added.
714         * platform/chromium/ContextMenuChromium.cpp: Added.
715         (WebCore::ContextMenu::ContextMenu):
716         (WebCore::ContextMenu::~ContextMenu):
717         (WebCore::ContextMenu::itemCount):
718         (WebCore::ContextMenu::insertItem):
719         (WebCore::ContextMenu::appendItem):
720         (WebCore::ContextMenu::itemWithAction):
721         (WebCore::ContextMenu::itemAtIndex):
722         (WebCore::ContextMenu::setPlatformDescription):
723         (WebCore::ContextMenu::platformDescription):
724         (WebCore::ContextMenu::releasePlatformDescription):
725         * platform/chromium/ContextMenuItemChromium.cpp: Added.
726         (WebCore::ContextMenuItem::ContextMenuItem):
727         (WebCore::ContextMenuItem::~ContextMenuItem):
728         (WebCore::ContextMenuItem::releasePlatformDescription):
729         (WebCore::ContextMenuItem::type):
730         (WebCore::ContextMenuItem::action):
731         (WebCore::ContextMenuItem::title):
732         (WebCore::ContextMenuItem::platformSubMenu):
733         (WebCore::ContextMenuItem::setType):
734         (WebCore::ContextMenuItem::setAction):
735         (WebCore::ContextMenuItem::setTitle):
736         (WebCore::ContextMenuItem::setSubMenu):
737         (WebCore::ContextMenuItem::setChecked):
738         (WebCore::ContextMenuItem::setEnabled):
739         (WebCore::ContextMenuItem::enabled):
740         * platform/chromium/CursorChromium.cpp: Added.
741         (WebCore::Cursor::Cursor):
742         (WebCore::Cursor::~Cursor):
743         (WebCore::Cursor::operator=):
744         (WebCore::pointerCursor):
745         (WebCore::crossCursor):
746         (WebCore::handCursor):
747         (WebCore::iBeamCursor):
748         (WebCore::waitCursor):
749         (WebCore::helpCursor):
750         (WebCore::eastResizeCursor):
751         (WebCore::northResizeCursor):
752         (WebCore::northEastResizeCursor):
753         (WebCore::northWestResizeCursor):
754         (WebCore::southResizeCursor):
755         (WebCore::southEastResizeCursor):
756         (WebCore::southWestResizeCursor):
757         (WebCore::westResizeCursor):
758         (WebCore::northSouthResizeCursor):
759         (WebCore::eastWestResizeCursor):
760         (WebCore::northEastSouthWestResizeCursor):
761         (WebCore::northWestSouthEastResizeCursor):
762         (WebCore::columnResizeCursor):
763         (WebCore::rowResizeCursor):
764         (WebCore::middlePanningCursor):
765         (WebCore::eastPanningCursor):
766         (WebCore::northPanningCursor):
767         (WebCore::northEastPanningCursor):
768         (WebCore::northWestPanningCursor):
769         (WebCore::southPanningCursor):
770         (WebCore::southEastPanningCursor):
771         (WebCore::southWestPanningCursor):
772         (WebCore::westPanningCursor):
773         (WebCore::moveCursor):
774         (WebCore::verticalTextCursor):
775         (WebCore::cellCursor):
776         (WebCore::contextMenuCursor):
777         (WebCore::aliasCursor):
778         (WebCore::progressCursor):
779         (WebCore::noDropCursor):
780         (WebCore::copyCursor):
781         (WebCore::noneCursor):
782         (WebCore::notAllowedCursor):
783         (WebCore::zoomInCursor):
784         (WebCore::zoomOutCursor):
785         (WebCore::grabCursor):
786         (WebCore::grabbingCursor):
787         * platform/chromium/DragDataChromium.cpp: Added.
788         (WebCore::containsHTML):
789         (WebCore::DragData::createClipboard):
790         (WebCore::DragData::containsURL):
791         (WebCore::DragData::asURL):
792         (WebCore::DragData::containsFiles):
793         (WebCore::DragData::asFilenames):
794         (WebCore::DragData::containsPlainText):
795         (WebCore::DragData::asPlainText):
796         (WebCore::DragData::containsColor):
797         (WebCore::DragData::canSmartReplace):
798         (WebCore::DragData::containsCompatibleContent):
799         (WebCore::DragData::asFragment):
800         (WebCore::DragData::asColor):
801         * platform/chromium/EditorChromium.cpp: Added.
802         (WebCore::Editor::newGeneralClipboard):
803         * platform/chromium/FileChooserChromium.cpp: Added.
804         (WebCore::FileChooser::basenameForWidth):
805         * platform/chromium/FileSystemChromium.cpp: Added.
806         (WebCore::deleteFile):
807         (WebCore::deleteEmptyDirectory):
808         (WebCore::getFileSize):
809         (WebCore::getFileModificationTime):
810         (WebCore::directoryName):
811         (WebCore::pathByAppendingComponent):
812         (WebCore::makeAllDirectories):
813         (WebCore::fileExists):
814         * platform/chromium/FileSystemChromiumLinux.cpp: Added.
815         (WebCore::pathGetFileName):
816         * platform/chromium/FileSystemChromiumMac.mm: Added.
817         (WebCore::pathGetFileName):
818         * platform/chromium/FileSystemChromiumWin.cpp: Added.
819         (WebCore::pathGetFileName):
820         * platform/chromium/FramelessScrollView.cpp: Added.
821         (WebCore::FramelessScrollView::~FramelessScrollView):
822         (WebCore::FramelessScrollView::invalidateScrollbarRect):
823         (WebCore::FramelessScrollView::isActive):
824         (WebCore::FramelessScrollView::invalidateRect):
825         (WebCore::FramelessScrollView::hostWindow):
826         (WebCore::FramelessScrollView::windowClipRect):
827         (WebCore::FramelessScrollView::paintContents):
828         (WebCore::FramelessScrollView::contentsResized):
829         (WebCore::FramelessScrollView::visibleContentsResized):
830         * platform/chromium/FramelessScrollView.h: Added.
831         (WebCore::FramelessScrollView::FramelessScrollView):
832         (WebCore::FramelessScrollView::client):
833         (WebCore::FramelessScrollView::setClient):
834         * platform/chromium/FramelessScrollViewClient.h: Added.
835         * platform/chromium/ScrollbarThemeChromiumWin.cpp: Added.
836         (WebCore::):
837         (WebCore::ScrollbarThemeChromium::scrollbarThickness):
838         (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
839         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
840         (WebCore::ScrollbarThemeChromium::paintButton):
841         (WebCore::ScrollbarThemeChromium::paintThumb):
842         (WebCore::ScrollbarThemeChromium::getThemeState):
843         (WebCore::ScrollbarThemeChromium::getThemeArrowState):
844         (WebCore::ScrollbarThemeChromium::getClassicThemeState):
845         * platform/chromium/SoundChromiumPosix.cpp: Added.
846         (WebCore::systemBeep):
847         * platform/chromium/SoundChromiumWin.cpp: Added.
848         (WebCore::systemBeep):
849         * platform/chromium/SystemTimeChromium.cpp: Added.
850         (WebCore::currentTime):
851         (WebCore::userIdleTime):
852         * platform/chromium/WidgetChromium.cpp: Added.
853         (WebCore::Widget::Widget):
854         (WebCore::Widget::~Widget):
855         (WebCore::Widget::show):
856         (WebCore::Widget::hide):
857         (WebCore::Widget::setCursor):
858         (WebCore::Widget::paint):
859         (WebCore::Widget::setFocus):
860         (WebCore::Widget::setIsSelected):
861         (WebCore::Widget::frameRect):
862         (WebCore::Widget::setFrameRect):
863         * platform/chromium/WindowsVersion.cpp: Added.
864         (WebCore::isVistaOrNewer):
865         * platform/chromium/WindowsVersion.h: Added.
866
867 2009-01-13  Tor Arne Vestbø  <tavestbo@trolltech.com>
868
869         Reviewed by Simon Hausmann.
870
871         [Qt] Make sure media elements dispatch the 'loaded' event
872         
873         We assume that when Phonon goes into paused state that we have the
874         complete media file. Once we do media loading ourselves we can
875         distinguish between loading the first frame and the complete media.
876
877         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
878         (WebCore::MediaPlayerPrivate::updateStates):
879
880 2009-01-13  Tor Arne Vestbø  <tavestbo@trolltech.com>
881
882         Reviewed by Simon Hausmann.
883
884         [Qt] Add more verbose error output when loading NPAPI plugins
885
886         * plugins/qt/PluginPackageQt.cpp:
887         (WebCore::PluginPackage::load):
888
889 2009-01-13  Simon Hausmann  <simon.hausmann@nokia.com>
890
891         Reviewed by Tor Arne Vestbø.
892
893         Fix crash in the Qt port when deleting a popup from within a
894         JavaScript onchange handler.
895
896         * platform/qt/QWebPopup.cpp:
897         (WebCore::QWebPopup::QWebPopup): Perform the activation of the
898         combobox item (i.e. the call to the JS handler) from a different
899         call stack by using a queued connection.
900
901 2009-01-12  Holger Hans Peter Freyther  <zecke@selfish.org>
902
903         Reviewed by Tor Arne Vestbø.
904
905         [GIO] Make sure to untef the GFile and the GInputStream on destruction
906
907         Make sure to call cleanupGioOperation from the ResourceHandleInternal
908         d'tor. Change the signature of cleanupGioOperation so we can do the
909         cleanup of GIO next to the cleanup of SOUP.
910
911         This is happening with many tests from dom/html/level2/html e.g.
912         LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
913
914         * platform/network/soup/ResourceHandleSoup.cpp:
915         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
916         (WebCore::cleanupGioOperation):
917         (WebCore::closeCallback):
918         (WebCore::readCallback):
919         (WebCore::openCallback):
920         (WebCore::queryInfoCallback):
921
922 2009-01-12  Holger Hans Peter Freyther  <zecke@selfish.org>
923
924         Reviewed by Tor Arne Vestbø.
925
926         [GIO] Attach the ResourceHandle to the GObject and get it from the GObject
927
928         https://bugs.webkit.org/show_bug.cgi?id=23116 discussed with Benjamin Otte
929
930         Sometimes it is not possible to cancel a pending GIO operation and the
931         callback might be invoked with a pointer to an already destructed
932         ResourceHandle. To avoid this issue we will attach the ResourceHandle
933         to the GObject* and in the callback attempt to get the ResourceHandle
934         from the GObject*. If no ResourceHandle is attached we silently fail
935         as the cleanup has been already done.
936
937         This is happening with many tests from dom/html/level2/html e.g.
938         LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
939
940         * platform/network/soup/ResourceHandleSoup.cpp:
941         (WebCore::cleanupGioOperation):
942         (WebCore::closeCallback):
943         (WebCore::readCallback):
944         (WebCore::openCallback):
945         (WebCore::queryInfoCallback):
946         (WebCore::ResourceHandle::startGio):
947
948 2009-01-12  Holger Hans Peter Freyther  <zecke@selfish.org>
949
950         Reviewed by Tor Arne Vestbø.
951
952         [GIO] Invoke cleanupGioOperation before calling didFail to avoid crashes
953
954         https://bugs.webkit.org/show_bug.cgi?id=23116
955
956         The ResourceHandle becomes invalid (e.g. got destructed) from within
957         the invocation of didFail. Avoid this by cleaning up everything before
958         calling didFail and simply return afterwards.
959
960         This is happening with many tests from dom/html/level2/html e.g.
961         LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
962
963         * platform/network/soup/ResourceHandleSoup.cpp:
964         (WebCore::readCallback):
965         (WebCore::openCallback):
966         (WebCore::queryInfoCallback):
967
968 2009-01-13  Tor Arne Vestbø  <tavestbo@trolltech.com>
969
970         Reviewed by Simon Hausmann.
971
972         Change how themes adjust mediaControls.css to match html4/quicks.css
973         
974         Instead of providing the full style sheet, the themes provide extra
975         overrides to the default style defined in UserAgentStyleSheetsData.
976         
977         https://bugs.webkit.org/show_bug.cgi?id=23210
978         
979         Also, merge WebKitResources.qrc and WebCoreResources.qrc to speed up
980         build time for the Qt port.
981
982         * Resources/WebKitResources.qrc: Removed. Merged into WebCore.qrc
983         * WebCore.pro:
984         * WebCore.qrc: Added.
985         * css/CSSStyleSelector.cpp:
986         (WebCore::CSSStyleSelector::styleForElement):
987         * css/qt/mediaControls-extras.css: Rename from html4-adjustments-qt.css
988         * platform/qt/RenderThemeQt.cpp:
989         (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
990         * platform/qt/RenderThemeQt.h:
991         * platform/qt/WebCoreResources.qrc: Removed.
992         * platform/qt/html4-adjustments-qt.css: Rename to mediaControls-extras.css
993         * rendering/RenderTheme.cpp:
994         * rendering/RenderTheme.h:
995         (WebCore::RenderTheme::extraMediaControlsStyleSheet):
996
997 2009-01-12  Gavin Barraclough  <barraclough@apple.com>
998
999         Reviewed by Oliver Hunt.
1000
1001         Deprecate JSValuePtr::getNumber() - two ways to get a number should  be enough.
1002
1003         * bindings/js/JSSQLTransactionCustom.cpp:
1004         (WebCore::JSSQLTransaction::executeSql):
1005         * bindings/objc/WebScriptObject.mm:
1006         (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
1007
1008 2009-01-12  Chris Marrin  <cmarrin@apple.com>
1009
1010         Reviewed by Dan Bernstein.
1011
1012         Fixed https://bugs.webkit.org/show_bug.cgi?id=22919
1013
1014         I added a common getElapsedTime() function to AnimationBase which uses a combination of
1015         the techniques from KeyframeAnimation and AnimationBase to compute elapsedTime in all
1016         states.
1017
1018         * page/animation/AnimationBase.cpp:
1019         (WebCore::AnimationBase::progress):
1020         (WebCore::AnimationBase::getElapsedTime):
1021         * page/animation/AnimationBase.h:
1022         * page/animation/KeyframeAnimation.cpp:
1023         (WebCore::KeyframeAnimation::animate):
1024
1025 2009-01-12  Robert Blaut  <webkit@blaut.biz>
1026
1027         Reviewed by Darin Adler
1028
1029         Fix for <https://bugs.webkit.org/show_bug.cgi?id=22096>
1030         Bug 22096: REGRESSION (r35879) scrolldelay is counted in seconds 
1031         instead of miliseconds
1032
1033         Test: fast/css/webkit-marquee-speed-unit-in-quirksmode.html
1034
1035         * css/CSSParser.cpp:
1036         (WebCore::CSSParser::validUnit): treat unitless values in quirks mode 
1037         as miliseconds instead of seconds.
1038
1039 2009-01-12  David Hyatt  <hyatt@apple.com>
1040
1041         Apply the same idea as the previous fix but for matched declarations.
1042
1043         Reviewed by Dan Bernstein
1044
1045         * css/CSSStyleSelector.h:
1046
1047 2009-01-12  Brady Eidson  <beidson@apple.com>
1048
1049         Reviewed by Darin Adler
1050
1051         <rdar://problem/6468274> - Track Non-get requests in global history
1052
1053         * WebCore.base.exp:
1054
1055         * history/HistoryItem.cpp:
1056         (WebCore::HistoryItem::HistoryItem):
1057         * history/HistoryItem.h:
1058         (WebCore::HistoryItem::lastVisitWasHTTPNonGet):
1059         (WebCore::HistoryItem::setLastVisitWasHTTPNonGet):
1060
1061 2009-01-12  Kevin Ollivier  <kevino@theolliviers.com>
1062
1063         !ENABLE(SVG_FONTS) build fix. Move defaultUnitsPerEm into a non-SVG header
1064         so it can be used by all builds.
1065         
1066         * platform/graphics/Font.h:
1067         * platform/graphics/SimpleFontData.cpp:
1068         * svg/SVGFontFaceElement.cpp:
1069         * svg/SVGFontFaceElement.h:
1070
1071 2009-01-12  Kevin Ollivier  <kevino@theolliviers.com>
1072
1073         wx build typo fix.
1074
1075         * platform/graphics/wx/TransformationMatrixWx.cpp:
1076         (WebCore::TransformationMatrix::TransformationMatrix):
1077
1078 2009-01-12  David Hyatt  <hyatt@apple.com>
1079
1080         Make sure the set of matched rules has a reserved capacity of 32.  This prevents remalloc thrash as
1081         elements are matched, since the Vector is shrinking and growing over and over.  1% PLT speedup.
1082
1083         Reviewed by Oliver Hunt
1084
1085         * css/CSSStyleSelector.h:
1086
1087 2009-01-12  David Hyatt  <hyatt@apple.com>
1088
1089         Optimize Element::attributeChanged to just check if accessibility is enabled up front before looking at the
1090         two accessibility-related attributes.  This avoids the rest of the code for all attributes on the PLT.
1091         Tiny speedup.
1092
1093         Reviewed by Oliver Hunt
1094
1095         * dom/Element.cpp:
1096         (WebCore::Element::attributeChanged):
1097
1098 2009-01-12  David Hyatt  <hyatt@apple.com>
1099
1100         Optimize the retrieval of line height.  If the document is not using any first-line rules, just immediately
1101         default to the normal case.  Tiny speedup on PLT.
1102
1103         Reviewed by Oliver Hunt
1104
1105         * rendering/RenderFlow.cpp:
1106         (WebCore::RenderFlow::lineHeight):
1107
1108 2009-01-12  David Hyatt  <hyatt@apple.com>
1109
1110         Fix 0.6% regression in PLT.  Make sure not to waste time updating NSScrollView's can blit on scroll state
1111         in the ScrollView constructor, since this is always going to be properly updated by FrameView anyway.
1112
1113         Reviewed by Oliver Hunt
1114
1115         * platform/ScrollView.cpp:
1116         (WebCore::ScrollView::ScrollView):
1117
1118 2009-01-12  Simon Fraser  <simon.fraser@apple.com>
1119
1120         Reviewed by Dan Bernstein
1121
1122         https://bugs.webkit.org/show_bug.cgi?id=23273
1123
1124         In RenderBox::repaintLayerRectsForImage(), the repaint rect does not have
1125         to be computed in absolute coordintes. Instead, we compute a repaintRect
1126         relative to the RenderObject, which can repaint itself.
1127         
1128         * rendering/RenderBox.cpp:
1129         (WebCore::RenderBox::repaintLayerRectsForImage):
1130
1131 2009-01-12  Simon Fraser  <simon.fraser@apple.com>
1132
1133         Reviewed by Dan Bernstein
1134
1135         https://bugs.webkit.org/show_bug.cgi?id=23220
1136
1137         Merge layoutDelta into LayoutState. This requires that we
1138         push even when layoutState is disabled, so that layoutDelta
1139         can still be stored.
1140
1141         * rendering/LayoutState.cpp:
1142         (WebCore::LayoutState::LayoutState):
1143         * rendering/LayoutState.h:
1144         (WebCore::LayoutState::LayoutState):
1145         * rendering/RenderBlock.cpp:
1146         (WebCore::RenderBlock::layoutBlock):
1147         (WebCore::RenderBlock::layoutBlockChildren):
1148         (WebCore::RenderBlock::layoutOnlyPositionedObjects):
1149         * rendering/RenderBox.cpp:
1150         (WebCore::RenderBox::localToAbsolute):
1151         (WebCore::RenderBox::absoluteToLocal):
1152         (WebCore::RenderBox::computeAbsoluteRepaintRect):
1153         * rendering/RenderFlexibleBox.cpp:
1154         (WebCore::RenderFlexibleBox::layoutBlock):
1155         * rendering/RenderFlow.cpp:
1156         (WebCore::RenderFlow::absoluteClippedOverflowRect):
1157         * rendering/RenderLayer.cpp:
1158         (WebCore::RenderLayer::updateLayerPositions):
1159         * rendering/RenderTableCell.cpp:
1160         (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
1161         (WebCore::RenderTableCell::localToAbsolute):
1162         * rendering/RenderView.cpp:
1163         (WebCore::RenderView::pushLayoutState):
1164         * rendering/RenderView.h:
1165         (WebCore::RenderView::layoutDelta):
1166         (WebCore::RenderView::addLayoutDelta):
1167         (WebCore::RenderView::doingFullRepaint):
1168         (WebCore::RenderView::pushLayoutState):
1169         (WebCore::RenderView::popLayoutState):
1170         (WebCore::RenderView::layoutStateEnabled):
1171         (WebCore::RenderView::layoutState):
1172         (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
1173         (WebCore::LayoutStateMaintainer::push):
1174         (WebCore::LayoutStateMaintainer::pop):
1175         * rendering/bidi.cpp:
1176         (WebCore::RenderBlock::layoutInlineChildren):
1177
1178 2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>
1179
1180         Reviewed by Holger Freyther.
1181
1182         [Qt] Build fix after turning the fontCache to a singleton
1183         https://bugs.webkit.org/show_bug.cgi?id=23253
1184
1185         Add a stub implementation for WebCore::fontCache() and FontCache::FontCache().
1186
1187         * platform/graphics/qt/FontCacheQt.cpp:
1188         (WebCore::fontCache):
1189         (WebCore::FontCache::FontCache):
1190
1191 2009-01-12  Eric Roman  <eroman@chromium.org>
1192  
1193         Reviewed by Darin Adler.
1194  
1195         Fix some bugs with Selection::appendTrailingWhitespace().
1196         https://bugs.webkit.org/show_bug.cgi?id=23232
1197  
1198         Test: editing/selection/doubleclick-whitespace-crash.html
1199  
1200         * editing/Selection.cpp:
1201         (WebCore::makeSearchRange):
1202         (WebCore::Selection::appendTrailingWhitespace):
1203
1204 2009-01-12  Dimitri Glazkov  <dglazkov@chromium.org>
1205
1206         Reviewed by Eric Seidel.
1207
1208         Add the first pieces of platform/graphics/chromium
1209         https://bugs.webkit.org/show_bug.cgi?id=23257
1210
1211         * platform/graphics/chromium/ColorChromium.cpp: Added.
1212         (WebCore::focusRingColor):
1213         * platform/graphics/chromium/FontCacheChromiumWin.cpp: Added.
1214         (WebCore::FontCache::platformInit):
1215         (WebCore::isStringASCII):
1216         (WebCore::LookupAltName):
1217         (WebCore::FontCodepage::):
1218         (WebCore::FontCodepage::if):
1219         (WebCore::createFontIndirectAndGetWinName):
1220         (WebCore::fontContainsCharacter):
1221         (WebCore::FontCache::getFontDataForCharacters):
1222         (WebCore::FontCache::alternateFamilyName):
1223         (WebCore::FontCache::getSimilarFontPlatformData):
1224         (WebCore::FontCache::getLastResortFallbackFont):
1225         (WebCore::toGDIFontWeight):
1226         (WebCore::FontCache::getGenericFontForScript):
1227         (WebCore::FillLogFont):
1228         (WebCore::FontCache::fontExists):
1229         (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData):
1230         (WebCore::traitsInFamilyEnumProc):
1231         (WebCore::FontCache::getTraitsInFamily):
1232         (WebCore::FontCache::createFontPlatformData):
1233         * platform/graphics/chromium/FontCacheLinux.cpp: Added.
1234         (WebCore::FontCache::platformInit):
1235         (WebCore::FontCache::getFontDataForCharacters):
1236         (WebCore::FontCache::alternateFamilyName):
1237         (WebCore::FontCache::getSimilarFontPlatformData):
1238         (WebCore::FontCache::getLastResortFallbackFont):
1239         (WebCore::FontCache::getTraitsInFamily):
1240         (WebCore::FontCache::createFontPlatformData):
1241         (WebCore::FontCache::getGenericFontForScript):
1242         * platform/graphics/chromium/FontChromiumWin.cpp: Added.
1243         (WebCore::windowsCanHandleTextDrawing):
1244         (WebCore::skiaDrawText):
1245         (WebCore::PaintSkiaText):
1246         (WebCore::Font::drawGlyphs):
1247         (WebCore::Font::selectionRectForComplexText):
1248         (WebCore::Font::drawComplexText):
1249         (WebCore::Font::floatWidthForComplexText):
1250         (WebCore::Font::offsetForPositionForComplexText):
1251
1252 2009-01-12  Darin Fisher  <darin@chromium.org>
1253
1254         Reviewed by Eric Seidel.
1255
1256         https://bugs.webkit.org/show_bug.cgi?id=23254
1257         Upstream page/chromium/
1258
1259         * page/chromium/AXObjectCacheChromium.cpp: Added.
1260         (WebCore::AXObjectCache::detachWrapper):
1261         (WebCore::AXObjectCache::attachWrapper):
1262         (WebCore::AXObjectCache::postNotification):
1263         (WebCore::AXObjectCache::postNotificationToElement):
1264         (WebCore::AXObjectCache::handleFocusedUIElementChanged):
1265         * page/chromium/AccessibilityObjectChromium.cpp:
1266         * page/chromium/AccessibilityObjectWrapper.h:
1267         * page/chromium/ChromeClientChromium.h: Added.
1268         * page/chromium/DragControllerChromium.cpp: Added.
1269         (WebCore::DragController::dragOperation):
1270         (WebCore::DragController::isCopyKeyDown):
1271         (WebCore::DragController::maxDragImageSize):
1272         (WebCore::DragController::cleanupAfterSystemDrag):
1273         * page/chromium/EventHandlerChromium.cpp: Added.
1274         (WebCore::EventHandler::passMousePressEventToSubframe):
1275         (WebCore::EventHandler::passMouseMoveEventToSubframe):
1276         (WebCore::EventHandler::passMouseReleaseEventToSubframe):
1277         (WebCore::EventHandler::passWheelEventToWidget):
1278         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
1279         (WebCore::EventHandler::passMouseDownEventToWidget):
1280         (WebCore::EventHandler::tabsToAllControls):
1281         (WebCore::EventHandler::eventActivatedView):
1282         (WebCore::EventHandler::createDraggingClipboard):
1283         (WebCore::EventHandler::focusDocumentView):
1284         (WebCore::EventHandler::accessKeyModifiers):
1285         * page/chromium/FrameChromium.cpp: Added.
1286         (WebCore::computePageRectsForFrame):
1287         (WebCore::Frame::dragImageForSelection):
1288         * page/chromium/FrameChromium.h: Added.
1289
1290 2009-01-12  Dimitri Glazkov  <dglazkov@chromium.org>
1291
1292         Reviewed by Darin Adler.
1293
1294         https://bugs.webkit.org/show_bug.cgi?id=22936
1295         Fix uninitialized memory read error, reported by Purify.
1296
1297         * platform/graphics/SimpleFontData.cpp:
1298         (WebCore::SimpleFontData::SimpleFontData): Added initializer for
1299             m_unitsPerEm using cDefaultUnitsPerEm constant.
1300         * svg/SVGFontFaceElement.cpp:
1301         (WebCore::SVGFontFaceElement::unitsPerEm): Replaced literal value with
1302             the constant.
1303         * svg/SVGFontFaceElement.h: Added cDefaultUnitsPerEm constant.
1304
1305 2009-01-12  Adam Treat  <adam.treat@torchmobile.com>
1306
1307         Reviewed by George Staikos.
1308
1309         Do not set fixedLayoutSize for anything other than the mainframe during
1310         the transition as this is a page level state like the viewportSize.
1311
1312         * loader/FrameLoaderClient.cpp:
1313         (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
1314
1315 2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>
1316
1317         Reviewed by Darin Adler.
1318
1319         Bug 22861: Turn the FontCache into a singleton
1320         https://bugs.webkit.org/show_bug.cgi?id=22861
1321
1322         - Added fontCache() to get the global FontCache.
1323
1324         - Made all the methods in FontCache instance method.
1325
1326         - Changed FontCache:: to fontCache()-> in WebCore.
1327
1328         * WebCore.base.exp: Now export fontCache().
1329         * css/CSSFontFaceSource.cpp:
1330         (WebCore::CSSFontFaceSource::getFontData):
1331         * css/CSSFontSelector.cpp:
1332         (WebCore::CSSFontSelector::CSSFontSelector):
1333         (WebCore::CSSFontSelector::~CSSFontSelector):
1334         (WebCore::CSSFontSelector::addFontFaceRule):
1335         (WebCore::fontDataForGenericFamily):
1336         * platform/graphics/Font.cpp:
1337         (WebCore::Font::glyphDataForCharacter):
1338         * platform/graphics/FontCache.cpp:
1339         (WebCore::fontCache):
1340         (WebCore::FontCache::FontCache):
1341         * platform/graphics/FontCache.h:
1342         * platform/graphics/FontFallbackList.cpp:
1343         (WebCore::FontFallbackList::FontFallbackList):
1344         (WebCore::FontFallbackList::invalidate):
1345         (WebCore::FontFallbackList::releaseFontData):
1346         (WebCore::FontFallbackList::fontDataAt):
1347         (WebCore::FontFallbackList::fontDataForCharacters):
1348         (WebCore::FontFallbackList::setPlatformFont):
1349         * platform/graphics/SimpleFontData.cpp:
1350         (WebCore::SimpleFontData::~SimpleFontData):
1351         * platform/graphics/mac/FontCacheMac.mm:
1352         (WebCore::fontCacheATSNotificationCallback):
1353         * platform/graphics/mac/SimpleFontDataMac.mm:
1354         (WebCore::SimpleFontData::smallCapsFontData):
1355         * platform/graphics/win/FontCacheWin.cpp:
1356         (WebCore::getCJKCodePageMasks):
1357         * platform/graphics/win/SimpleFontDataWin.cpp:
1358         (WebCore::SimpleFontData::containsCharacters):
1359
1360 2009-01-11  Darin Adler  <darin@apple.com>
1361
1362         Reviewed by Dan Bernstein.
1363
1364         Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
1365         https://bugs.webkit.org/show_bug.cgi?id=23247
1366
1367         Also fix problems where partially parsed paths will still have an effect
1368         rather than failing parsing and being ignored.
1369
1370         Test: dom/path-segments.html
1371
1372         * platform/graphics/Path.h:
1373         (WebCore::Path::swap): Added.
1374
1375         * svg/SVGParserUtilities.cpp:
1376         (WebCore::SVGPathParser::parseSVG): Removed unneeded special case for empty string.
1377         (WebCore::PathBuilder::build): Changed to not modify the path if parsing fails.
1378         (WebCore::SVGPathSegListBuilder::build): Changed to not modify the segment list if
1379         parsing fails.
1380         (WebCore::SVGPathSegListBuilder::svgMoveTo): Put the path element into the vector,
1381         not directly into the segment list.
1382         (WebCore::SVGPathSegListBuilder::svgLineTo): Ditto.
1383         (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): Ditto.
1384         (WebCore::SVGPathSegListBuilder::svgLineToVertical): Ditto.
1385         (WebCore::SVGPathSegListBuilder::svgCurveToCubic): Ditto.
1386         (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): Ditto.
1387         (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): Ditto.
1388         (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): Ditto.
1389         (WebCore::SVGPathSegListBuilder::svgArcTo): Ditto.
1390         (WebCore::SVGPathSegListBuilder::svgClosePath): Ditto.
1391
1392         * svg/SVGPathSegCurvetoCubicSmooth.h:
1393         (WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth):
1394         Set y2 to y2, not to y.
1395
1396 2009-01-11  Darin Adler  <darin@apple.com>
1397
1398         Reviewed by Oliver Hunt.
1399
1400         Bug 23102: turn on unused parameter warnings in WebCore
1401         https://bugs.webkit.org/show_bug.cgi?id=23102
1402
1403         Fourth step: Remove arguments entirely in the many cases where they are not
1404         needed at all. This step is a little less mechanical than the earlier ones.
1405
1406         * dom/DOMImplementation.cpp:
1407         (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating
1408         the regular expression, since we already specify a-zA-Z in our expression.
1409
1410         * dom/Document.cpp:
1411         (WebCore::Document::databaseThread): Don't pass in the document when creating
1412         a DatabaseThread.
1413
1414         * dom/Element.cpp:
1415         (WebCore::Element::createRareData): Don't pass the element when creating an
1416         ElementRareData.
1417         (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle.
1418         (WebCore::Element::recalcStyle): Ditto.
1419
1420         * dom/ElementRareData.h: Remove the unused Element* from the constructor and
1421         the resetComputedStyle function.
1422
1423         * dom/EventTargetNode.cpp:
1424         (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent.
1425         (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument.
1426         (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
1427         * dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.
1428
1429         * editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function.
1430         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused
1431         start and end arguments.
1432         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start
1433         and end to pushDownTextDecorationStyleAroundNode.
1434
1435         * editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the
1436         unused start and end arguments from pushDownTextDecorationStyleAroundNode.
1437
1438         * editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.
1439
1440         * html/HTMLTokenizer.cpp:
1441         (WebCore::Token::addAttribute): Removed unused Document* argument.
1442         (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.
1443
1444         * html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.
1445
1446         * page/DOMWindow.cpp:
1447         (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.
1448
1449         * page/DragController.cpp:
1450         (WebCore::DragController::dragIsMove): Removed unused DragData argument.
1451         (WebCore::DragController::performDrag): Call concludeEditDrag rather than
1452         concludeDrag.
1453         (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove.
1454         (WebCore::DragController::concludeEditDrag): Renamed to make it clear this
1455         should only be called for edit drags. Removed the action mask argument. Also
1456         changed dragIsMove call sites to not pass dragData.
1457
1458         * page/DragController.h: Updated for above changes and tweaked comment format.
1459
1460         * page/Frame.cpp:
1461         (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
1462         when creating regular expressions for clarity. Call match instead of search,
1463         since both do the same thing except for with negative start offsets, and none
1464         used here are negative.
1465         (WebCore::Frame::matchLabelsAgainstElement): Ditto.
1466
1467         * page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.
1468
1469         * page/mac/AccessibilityObjectWrapper.mm:
1470         (AXAttributeStringSetHeadingLevel): Removed unused object argument.
1471         (AXAttributedStringAppendText): Ditto.
1472         (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.
1473
1474         * page/mac/FrameMac.mm:
1475         (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
1476         when creating regular expressions for clarity. Call match instead of search,
1477         since both do the same thing except for with negative start offsets, and none
1478         used here are negative.
1479         (WebCore::Frame::matchLabelsAgainstElement): Ditto.
1480
1481         * platform/graphics/SegmentedFontData.cpp:
1482         (WebCore::SegmentedFontData::containsCharacter): Added.
1483         (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters
1484         instead of just the first one, using containsCharacter.
1485
1486         * platform/graphics/SegmentedFontData.h: Made more members private.
1487         Added containsCharacter function member.
1488
1489         * platform/mac/DragImageMac.mm:
1490         (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of
1491         DragImageRef for clarity, since this is platform-specific code.
1492         (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused
1493         variable warning.
1494         (WebCore::scaleDragImage): Ditto.
1495         (WebCore::dissolveDragImageToFraction): Ditto.
1496         (WebCore::createDragImageFromImage): Ditto.
1497         (WebCore::createDragImageIconForCachedImage): Ditto.
1498
1499         * platform/mac/WebFontCache.mm:
1500         (acceptableChoice): Removed the unused weight-related arguments.
1501         (betterChoice): Ditto.
1502         (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.
1503
1504         * platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory
1505         because we'd rather get a link error rather than a runtime error if we use it
1506         for anything, and right now it's not used.
1507
1508         * platform/text/RegularExpression.cpp: Removed unused private data,
1509         including pattern, lastMatchString, lastMatchOffsets, lastMatchCount,
1510         and lastMatchPos. Made the RegularExpression::Private::regex be private
1511         and use an accessor function to get at it.
1512         (WebCore::RegularExpression::RegularExpression): Removed the const char* version
1513         of the constructor because it's not any more efficient. Changed the boolean
1514         constructor argument to use TextCaseSensitivity instead to make it less likely
1515         we'll use it wrong.
1516         (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr,
1517         just use plain old assignment on it. The only reason we do this instead of using
1518         the compiler generated assignment operator is that we want the Private structure
1519         to be internal to the .cpp file.
1520         (WebCore::RegularExpression::match): Added a null check so we won't crash if
1521         we fail to compile the regular expression. Removed the code to handle multiple
1522         match strings, since that was unused.
1523
1524         * platform/text/RegularExpression.h: Changed the case sensitivity argument to use
1525         TextCaseSensitivity and not have a default value. Removed the default constructor,
1526         and the pattern, match, and pos functions.
1527
1528         * platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from
1529         Page.h, because we should eventually use it in all the places where we have
1530         an argument to control case sensitivity, starting with the functions in this
1531         class.
1532
1533         * platform/text/mac/ShapeArabic.c:
1534         (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though
1535         this is code borrowed from ICU, this seems like a simple safe change to make.
1536         (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.
1537
1538         * rendering/RenderPath.cpp:
1539         (WebCore::RenderPath::RenderPath): Removed the unused style argument.
1540         Also removed the type check. The argument already has the correct type,
1541         so it's not helpful to upcast it and then check its type again, unless
1542         we have some reason to believe the type is not reliable. And we don't.
1543
1544         * rendering/RenderPath.h: Removed the RenderStyle* argument to the
1545         constructor. Also removed the explicit declaration of the destructor.
1546         It's not helpful or needed.
1547
1548         * rendering/RenderSVGInlineText.cpp:
1549         (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to
1550         make it clear that just returning an empty rect is not a good implementation.
1551         Removed the argument names to get rid of the warning.
1552
1553         * rendering/RenderTreeAsText.cpp:
1554         (WebCore::printBorderStyle): Removed the unused RenderObject argument.
1555         (WebCore::operator<<): Updated for the change to printBorderStyle function.
1556
1557         * storage/DatabaseThread.cpp:
1558         (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
1559         * storage/DatabaseThread.h: Ditto.
1560
1561         * storage/LocalStorage.cpp:
1562         (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
1563         * storage/LocalStorage.h: Ditto.
1564
1565         * svg/SVGElement.cpp:
1566         (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception
1567         code location to dispatchGenericEvent.
1568         * svg/SVGElementInstance.cpp:
1569         (WebCore::SVGElementInstance::dispatchEvent): Ditto.
1570
1571         * svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h.
1572         (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to
1573         the RenderPath constructor.
1574
1575         * svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.
1576
1577         * xml/XSLTProcessor.cpp:
1578         (WebCore::createFragmentFromSource): Removed unused sourceNode argument.
1579         (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.
1580
1581 2009-01-11  Alexey Proskuryakov  <ap@webkit.org>
1582
1583         Reviewed by Darin Adler.
1584
1585         https://bugs.webkit.org/show_bug.cgi?id=23165
1586         Disable application cache dynamic entries support.
1587
1588         * bindings/js/JSDOMApplicationCacheCustom.cpp:
1589         * loader/appcache/DOMApplicationCache.idl:
1590
1591 2009-01-11  Adam Treat  <adam.treat@torchmobile.com>
1592
1593         Reviewed by Darin Adler.
1594
1595         Correct coordinate transformation for deeply nested frames on resizing.  This
1596         fixes https://bugs.webkit.org/show_bug.cgi?id=20766.
1597
1598         Test: fast/frames/frame-deep-nested-resize.html
1599
1600         * rendering/RenderFrameSet.cpp:
1601         (WebCore::RenderFrameSet::userResize):
1602
1603 2009-01-11  Mark Rowe  <mrowe@apple.com>
1604
1605         Tiger build fix.  The connection parameter is still used on Tiger in this method.
1606
1607         * platform/network/mac/ResourceHandleMac.mm:
1608         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
1609
1610 2009-01-11  Darin Adler  <darin@apple.com>
1611
1612         Reviewed by Dan Bernstein.
1613
1614         Bug 23102: turn on unused parameter warnings in WebCore
1615         https://bugs.webkit.org/show_bug.cgi?id=23102
1616
1617         Third step: Deal with cases of arguments used only in assertions.
1618
1619         * dom/MessagePort.cpp:
1620         (WebCore::MessagePortCloseEventTask::performTask): Use ASSERT_UNUSED.
1621         * dom/Worker.cpp:
1622         (WebCore::Worker::notifyFinished): Ditto.
1623         * dom/XMLTokenizer.cpp:
1624         (WebCore::XMLTokenizer::notifyFinished): Ditto.
1625         * loader/appcache/ApplicationCacheGroup.cpp:
1626         (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
1627         * loader/appcache/ApplicationCacheStorage.cpp:
1628         (WebCore::ApplicationCacheStorage::verifySchemaVersion): Ditto.
1629         * loader/icon/IconLoader.cpp:
1630         (WebCore::IconLoader::didReceiveData): Since loader and size are only
1631         used when logging, use UNUSED_PARAM when logging is disabled.
1632         * platform/mac/WidgetMac.mm:
1633         (WebCore::Widget::beforeMouseDown): Use ASSERT_UNUSED.
1634         * platform/network/mac/ResourceHandleMac.mm:
1635         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Use the
1636         argument since it's probably a tiny bit more efficient and gets rid
1637         of the unused argument warning.
1638         * rendering/RenderListMarker.cpp:
1639         (WebCore::RenderListMarker::createInlineBox): Use ASSERT_UNUSED.
1640         * rendering/RenderObject.cpp:
1641         (WebCore::RenderObject::createInlineBox): Ditto.
1642         * rendering/RenderSVGInline.cpp:
1643         (WebCore::RenderSVGInline::createInlineBox): Use UNUSED_PARAM.
1644         I couldn't use ASSERT_UNUSED because it's a single assertion, but it's
1645         the only use for two different arguments.
1646         * rendering/RenderText.cpp:
1647         (WebCore::RenderText::createInlineBox): Use ASSERT_UNUSED.
1648         * rendering/RenderThemeMac.mm:
1649         (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): Ditto.
1650
1651 2009-01-11  Simon Fraser  <simon.fraser@apple.com>
1652
1653         Reviewed by Oliver Hunt
1654
1655         https://bugs.webkit.org/show_bug.cgi?id=23242
1656         
1657         Fix CanvasRenderingContext2D::transform to do a pre-multiply,
1658         rather than a post-multiply into m_transform. This bug did not affect
1659         drawing, but did cause m_transform to be incorrect, which impacted
1660         willDraw(), and isPointInPath.
1661         
1662         Test: fast/canvas/canvas-incremental-repaint-2.html
1663
1664         * html/CanvasRenderingContext2D.cpp:
1665         (WebCore::CanvasRenderingContext2D::transform):
1666
1667 2009-01-11  Darin Adler  <darin@apple.com>
1668
1669         Reviewed by Dan Bernstein.
1670
1671         Bug 23102: turn on unused parameter warnings in WebCore
1672         https://bugs.webkit.org/show_bug.cgi?id=23102
1673
1674         Second step: Fix simple Objective-C cases where we need to use UNUSED_PARAM.
1675         That's because you can't omit an argument name in Objective-C methods.
1676
1677         * bindings/objc/DOMObject.mm:
1678         (-[DOMObject copyWithZone:]): Use UNUSED_PARAM. Also rename argument to include
1679         the word "unused" so we don't just start using it without removing the macro.
1680         * bindings/objc/WebScriptObject.mm:
1681         (+[WebUndefined allocWithZone:]): Ditto.
1682         (-[WebUndefined initWithCoder:]): Ditto.
1683         (-[WebUndefined encodeWithCoder:]): Ditto.
1684         (-[WebUndefined copyWithZone:]): Ditto.
1685         * page/mac/WebDashboardRegion.m:
1686         (-[WebDashboardRegion copyWithZone:]): Ditto.
1687         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1688         (WebCore::mainThreadSetNeedsDisplay): Omit argument name.
1689         (-[WebCoreMovieObserver loadStateChanged:]): Use UNUSED_PARAM as above.
1690         (-[WebCoreMovieObserver rateChanged:]): Ditto.
1691         (-[WebCoreMovieObserver sizeChanged:]): Ditto.
1692         (-[WebCoreMovieObserver timeChanged:]): Ditto.
1693         (-[WebCoreMovieObserver didEnd:]): Ditto.
1694         (-[WebCoreMovieObserver newImageAvailable:]): Ditto.
1695         * platform/mac/ScrollbarThemeMac.mm:
1696         (+[ScrollbarPrefsObserver appearancePrefsChanged:]): Ditto.
1697         (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): Ditto.
1698         * platform/mac/SharedTimerMac.mm:
1699         (-[WebCorePowerNotifier didWake:]): Ditto.
1700         * platform/mac/WebCoreKeyGenerator.m:
1701         (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): Ditto.
1702         * platform/network/mac/ResourceHandleMac.mm:
1703         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Ditto.
1704         (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): Ditto.
1705         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Ditto.
1706         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Ditto.
1707         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto.
1708         (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Ditto.
1709         (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): Ditto.
1710         (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): Ditto.
1711         (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto.
1712         (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto.
1713         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Ditto.
1714         (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Ditto.
1715         (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
1716         (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
1717         (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
1718         (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
1719         (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
1720
1721 2009-01-11  Dirk Schulze  <krit@webkit.org>
1722
1723         Reviewed by Darin Adler.
1724
1725         Move platform dependent strokeContains back to RenderPath, Path and delete
1726         unneeded Code in svg.
1727
1728         RenderPath clean-up for strokeContains
1729         [https://bugs.webkit.org/show_bug.cgi?id=22957]
1730
1731         * GNUmakefile.am:
1732         * WebCore.pro:
1733         * WebCore.vcproj/WebCore.vcproj:
1734         * WebCore.xcodeproj/project.pbxproj:
1735         * platform/graphics/Path.h:
1736         * platform/graphics/cairo/PathCairo.cpp:
1737         (WebCore::Path::strokeContains):
1738         * platform/graphics/cg/PathCG.cpp:
1739         (WebCore::Path::strokeContains):
1740         * platform/graphics/qt/PathQt.cpp:
1741         (WebCore::Path::strokeContains):
1742         * rendering/RenderPath.cpp:
1743         (WebCore::RenderPath::strokeContains):
1744         * svg/graphics/cairo/RenderPathCairo.cpp: Removed.
1745         * svg/graphics/cg/CgSupport.cpp: Removed.
1746         * svg/graphics/cg/CgSupport.h: Removed.
1747         * svg/graphics/cg/RenderPathCg.cpp: Removed.
1748         * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
1749         * svg/graphics/cg/SVGResourceMaskerCg.mm:
1750         * svg/graphics/qt/RenderPathQt.cpp: Removed.
1751
1752 2009-01-11  Holger Hans Peter Freyther  <zecke@selfish.org>
1753
1754         Reviewed by Anders Carlsson.
1755
1756         [GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase.lut.h
1757
1758         make distcheck pass by adding JSWorkerContextBase.lut.h to the
1759         CLEANFILES that will be cleaned on a make distclean.
1760
1761         * GNUmakefile.am:
1762
1763 2009-01-11  Zalan Bujtas  <zbujtas@gmail.com>
1764
1765         Reviewed by Alexey Proskuryakov.
1766
1767         https://bugs.webkit.org/show_bug.cgi?id=23235
1768         Build fix for non-VIDEO builds.
1769
1770         * rendering/RenderTheme.cpp:
1771         * rendering/RenderTheme.h:
1772
1773 2009-01-11  Gabriella Toth  <gtoth@inf.u-szeged.hu>
1774
1775         Reviewed by Darin Adler.
1776
1777         https://bugs.webkit.org/show_bug.cgi?id=19287
1778         return value of malloc() is not checked in npruntime.cpp
1779
1780         Checking whether malloc can allocate memory or not. If it can't, CRASH macro is invoked
1781         (like in fastMalloc).
1782    
1783         * bridge/npruntime.cpp:
1784         (_NPN_GetStringIdentifier):
1785         (_NPN_GetIntIdentifier):
1786         (NPN_InitializeVariantWithStringCopy):
1787         (_NPN_CreateObject):
1788
1789 2009-01-11  Glenn Wilson  <gwilson@google.com>
1790
1791         Reviewed by Darin Adler.
1792
1793         Changes radio buttons so they can be 'checked' even if they
1794         don't have the name attribute set.
1795
1796         See https://bugs.webkit.org/show_bug.cgi?id=21534
1797
1798         Test: fast/html/select-unnamed-radio.html
1799
1800         * html/HTMLInputElement.cpp:
1801         (WebCore::HTMLInputElement::preDispatchEventHandler):
1802
1803 2009-01-11  Bernhard Rosenkraenzer <bero@arklinux.ch>
1804
1805         Reviewed by Darin Adler.
1806
1807         https://bugs.webkit.org/show_bug.cgi?id=22205
1808         Fix compatibility with bison 2.4, partially based on older patch by
1809         Priit Laes <amd@store20.com>
1810
1811         * WebCore/css/CSSGrammar.y: Made compatible with bison 2.4
1812
1813 2009-01-11  Jeremy Moskovich  <jeremy@chromium.org>
1814
1815         Reviewed by Darin Adler.
1816
1817         https://bugs.webkit.org/show_bug.cgi?id=16001
1818         Incorrect assumption that selection is always contiguous LTR.
1819
1820         Test: editing/selection/extend-selection-bidi.html
1821
1822         * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::fillLineSelectionGap):
1823         Make this function  not assume a contiguous visual LTR selection range. 
1824
1825 2009-01-11  Dmitry Titov  <dimich@chromium.org>
1826
1827         Reviewed by Darin Adler.
1828
1829         https://bugs.webkit.org/show_bug.cgi?id=23207
1830         Moved currentTime() to from WebCore to WTF.
1831
1832         Most of these files only have a different header file included.
1833         Various build files reflect removal of SystemTimeGtk, Wx, Qt and Linux
1834         which were removed since they only implemented currentTime().
1835
1836         * ForwardingHeaders/wtf/CurrentTime.h: Added.
1837         * GNUmakefile.am:
1838         * WebCore.base.exp:
1839         * WebCore.pro:
1840         * dom/ContainerNode.cpp:
1841         * dom/Document.cpp:
1842         * dom/Event.cpp:
1843         * history/CachedPage.cpp:
1844         * history/PageCache.cpp:
1845         * html/HTMLMediaElement.cpp:
1846         (WebCore::HTMLMediaElement::load):
1847         (WebCore::HTMLMediaElement::progressEventTimerFired):
1848         * html/HTMLTokenizer.cpp:
1849         * html/PreloadScanner.cpp:
1850         * inspector/InspectorController.cpp:
1851         * loader/Cache.cpp:
1852         (WebCore::Cache::pruneLiveResources):
1853         * loader/CachedImage.cpp:
1854         * loader/CachedResource.cpp:
1855         * loader/FrameLoader.cpp:
1856         * loader/ProgressTracker.cpp:
1857         * loader/icon/IconDatabase.cpp:
1858         * loader/icon/IconRecord.cpp:
1859         * page/DragController.cpp:
1860         * page/Frame.cpp:
1861         * page/FrameView.cpp:
1862         * page/animation/AnimationBase.cpp:
1863         * page/animation/AnimationController.cpp:
1864         * page/animation/KeyframeAnimation.cpp:
1865         * platform/SystemTime.h:
1866         * platform/Timer.cpp:
1867         * platform/graphics/BitmapImage.cpp:
1868         * platform/gtk/MouseEventGtk.cpp:
1869         * platform/gtk/SharedTimerGtk.cpp:
1870         * platform/gtk/SystemTimeGtk.cpp: Removed.
1871         * platform/gtk/SystemTimeLinux.cpp: Removed.
1872         * platform/mac/SystemTimeMac.cpp:
1873         * platform/qt/PlatformMouseEventQt.cpp:
1874         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1875         * platform/qt/SharedTimerQt.cpp:
1876         * platform/qt/SharedTimerQt.h:
1877         * platform/qt/SystemTimeQt.cpp: Removed.
1878         * platform/win/SharedTimerWin.cpp:
1879         * platform/win/SystemTimeWin.cpp:
1880         * platform/wx/MouseEventWx.cpp:
1881         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1882         * platform/wx/SharedTimerWx.cpp:
1883         * platform/wx/SystemTimeWx.cpp: Removed.
1884         * rendering/RenderImage.cpp:
1885         * rendering/RenderMedia.cpp:
1886         * svg/animation/SMILTimeContainer.cpp:
1887         * webcore-wx.bkl:
1888         * xml/XMLHttpRequest.cpp:
1889
1890 2009-01-11  Dmitry Titov  <dimich@chromium.org>
1891
1892         Reviewed by Darin Adler.
1893
1894         Make ScheduledAction (Timeout callback) able to execute the callback under WorkerContext.
1895         Part of 'Timers in Workers' work.
1896         https://bugs.webkit.org/show_bug.cgi?id=23223
1897
1898         * bindings/js/ScheduledAction.cpp:
1899         (WebCore::ScheduledAction::execute): new method that takes WorkerContext.
1900         (WebCore::ScheduledAction::executeFunctionInContext): Executes a JSFunction in proper context with 'this' object.
1901         * bindings/js/ScheduledAction.h:
1902
1903 2009-01-10  Eric Carlson  <eric.carlson@apple.com>
1904
1905         Reviewed by Eric Seidel.
1906
1907         https://bugs.webkit.org/show_bug.cgi?id=23210
1908         Make it easier for ports to define custom UI for media controls
1909
1910         * css/CSSStyleSelector.cpp:
1911         (WebCore::CSSStyleSelector::styleForElement): call theme()->styleSheetForMediaControls to
1912         get the media controller style sheet 
1913
1914         * rendering/MediaControlElements.cpp:
1915         (WebCore::MediaControlInputElement::hitTest): Added
1916         * rendering/MediaControlElements.h: Updated
1917
1918         * rendering/RenderMedia.cpp:
1919         (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
1920         so control elements don't necessarily have to be rectangular
1921
1922         * rendering/RenderTheme.cpp:
1923         (WebCore::RenderTheme::styleSheetForMediaControls):  Added
1924         (WebCore::RenderTheme::hitTestMediaControlPart):  Added
1925         * rendering/RenderTheme.h: Updated
1926
1927 2009-01-10  Simon Fraser  <simon.fraser@apple.com>
1928
1929         Reviewed by Dan Bernstein
1930
1931         https://bugs.webkit.org/show_bug.cgi?id=23222
1932         
1933         We need to disable LayoutState when an object has transforms,
1934         because LayoutState is not transform-aware and therefore
1935         repaint rects can be computed incorrectly.
1936         
1937         Test: fast/repaint/transform-disable-layoutstate.html
1938
1939         * rendering/RenderBlock.cpp:
1940         (WebCore::RenderBlock::layoutBlock):
1941         (WebCore::RenderBlock::layoutOnlyPositionedObjects):
1942         * rendering/RenderFlexibleBox.cpp:
1943         (WebCore::RenderFlexibleBox::layoutBlock):
1944
1945 2009-01-09  Holger Hans Peter Freyther  <zecke@selfish.org>
1946
1947         Reviewed by Simon Hausmann.
1948
1949         [QT] Make SharedTimer use QBasicTimer
1950
1951         Kill the SharedTimerQt.h and the usage of signal and slots
1952         by using QBasicTimer.
1953
1954         * WebCore.pro:
1955         * platform/qt/SharedTimerQt.cpp:
1956         (WebCore::SharedTimerQt::SharedTimerQt):
1957         (WebCore::SharedTimerQt::inst):
1958         (WebCore::SharedTimerQt::start):
1959         (WebCore::SharedTimerQt::stop):
1960         (WebCore::SharedTimerQt::timerEvent):
1961         (WebCore::setSharedTimerFiredFunction):
1962         (WebCore::setSharedTimerFireTime):
1963         (WebCore::stopSharedTimer):
1964         * platform/qt/SharedTimerQt.h: Removed.
1965
1966 2009-01-09  Adam Bergkvist <adam.bergkvist@ericsson.com>
1967
1968         Reviewed by Holger Freyther.
1969
1970         [CURL] POST without body becomes GET
1971         https://bugs.webkit.org/show_bug.cgi?id=23182
1972
1973         Make sure that method is always set to POST even when the body is
1974         empty. Cleaned up httpBody null check.
1975
1976         * platform/network/curl/ResourceHandleManager.cpp:
1977         (WebCore::ResourceHandleManager::setupPOST):
1978
1979 2009-01-09  Adam Treat  <adam.treat@torchmobile.com>
1980
1981         Build fix.
1982
1983         * plugins/PluginView.cpp:
1984
1985 2009-01-09  Adele Peterson  <adele@apple.com>
1986
1987         Reviewed by Darin Adler.
1988
1989         Fix infinite recursion in clientPaddingLeft and clientPaddingRight.  This changes the code back to
1990         how it was before RenderTextControlSingleLine was split out from RenderTextControl.
1991         
1992         No test added since this code is only exercised when trying to place a search field's recent searches popup menu.
1993
1994         * rendering/RenderTextControlSingleLine.cpp:
1995         (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
1996         (WebCore::RenderTextControlSingleLine::clientPaddingRight):
1997
1998 2009-01-09  Darin Adler  <darin@apple.com>
1999
2000         Reviewed by Jon Honeycutt.
2001
2002         Bug 22913: REGRESSION: Space bar doesn't scroll on windows
2003         https://bugs.webkit.org/show_bug.cgi?id=22913
2004         rdar://problem/6479834
2005
2006         * page/EventHandler.cpp:
2007         (WebCore::EventHandler::defaultKeyboardEventHandler): Added code to call
2008         defaultSpaceEventHandler.
2009         (WebCore::EventHandler::defaultSpaceEventHandler): Added. Scrolls down or up based
2010         on the shift key.
2011         * page/EventHandler.h: Added defaultSpaceEventHandler.
2012
2013         * platform/mac/ScrollViewMac.mm:
2014         (WebCore::ScrollView::platformScroll): Return false, because this function does
2015         not scroll. In an earlier version of this patch, I used this to prevent the
2016         patch from affecting the Mac, but I decided to use #if instead.
2017
2018 2009-01-09  Gavin Barraclough  <barraclough@apple.com>
2019
2020         Reviewed by Oliver Hunt.
2021
2022         Delete references to JSValue, removing this class.
2023
2024         * bindings/js/JSWorkerContextCustom.cpp:
2025         (WebCore::JSWorkerContext::self):
2026         * bindings/js/ScriptCallStack.h:
2027
2028 2009-01-09  Dimitri Glazkov  <dglazkov@chromium.org>
2029
2030         Reviewed by Eric Seidel.
2031
2032         Add svg/graphics/skia files.
2033         https://bugs.webkit.org/show_bug.cgi?id=23147
2034
2035         * svg/graphics/skia/RenderPathSkia.cpp: Added.
2036         (WebCore::RenderPath::strokeContains):
2037         * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Added.
2038         (WebCore::SVGPaintServerPattern::setup):
2039         * svg/graphics/skia/SVGPaintServerSkia.cpp: Added.
2040         (WebCore::SVGPaintServer::draw):
2041         (WebCore::SVGPaintServer::teardown):
2042         (WebCore::SVGPaintServer::renderPath):
2043         * svg/graphics/skia/SVGResourceFilterSkia.cpp: Added.
2044         (WebCore::SVGResourceFilter::createPlatformData):
2045         (WebCore::SVGResourceFilter::prepareFilter):
2046         (WebCore::SVGResourceFilter::applyFilter):
2047         * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Added.
2048         (WebCore::SVGResourceMasker::applyMask):
2049
2050 2009-01-09  Dimitri Glazkov  <dglazkov@chromium.org>
2051
2052         Reviewed by Eric Seidel.
2053
2054         Add SkiaFontWin to platform/graphics/chromium
2055         https://bugs.webkit.org/show_bug.cgi?id=23215
2056
2057         * platform/graphics/skia/SkiaFontWin.cpp: Added.
2058         (WebCore::CachedOutlineKey::CachedOutlineKey):
2059         (WebCore::operator==):
2060         (WebCore::CachedOutlineKeyHash::hash):
2061         (WebCore::CachedOutlineKeyHash::equal):
2062         (WebCore::FIXEDToSkScalar):
2063         (WebCore::deleteOutline):
2064         (WebCore::addPolyCurveToPath):
2065         (WebCore::getPathForGlyph):
2066         (WebCore::SkiaWinOutlineCache::lookupOrCreatePathForGlyph):
2067         (WebCore::SkiaWinOutlineCache::removePathsForFont):
2068         * platform/graphics/skia/SkiaFontWin.h: Added.
2069
2070 2009-01-09  Anders Carlsson  <andersca@apple.com>
2071
2072         Fix build.
2073         
2074         * WebCore.LP64.exp:
2075
2076 2009-01-09  Dimitri Glazkov  <dglazkov@chromium.org>
2077
2078         Reviewed by Eric Seidel.
2079
2080         Add PlatformContextSkia and PlatformGraphics.h to platform/graphics/skia
2081         https://bugs.webkit.org/show_bug.cgi?id=23215
2082
2083         * platform/graphics/skia/PlatformContextSkia.cpp: Added.
2084         (PlatformContextSkia::State::State):
2085         (PlatformContextSkia::State::~State):
2086         (PlatformContextSkia::State::applyAlpha):
2087         (PlatformContextSkia::PlatformContextSkia):
2088         (PlatformContextSkia::~PlatformContextSkia):
2089         (PlatformContextSkia::setCanvas):
2090         (PlatformContextSkia::save):
2091         (PlatformContextSkia::restore):
2092         (PlatformContextSkia::drawRect):
2093         (PlatformContextSkia::setupPaintCommon):
2094         (PlatformContextSkia::setupPaintForFilling):
2095         (PlatformContextSkia::setupPaintForStroking):
2096         (PlatformContextSkia::setDrawLooper):
2097         (PlatformContextSkia::setMiterLimit):
2098         (PlatformContextSkia::setAlpha):
2099         (PlatformContextSkia::setLineCap):
2100         (PlatformContextSkia::setLineJoin):
2101         (PlatformContextSkia::setPorterDuffMode):
2102         (PlatformContextSkia::setFillColor):
2103         (PlatformContextSkia::getDrawLooper):
2104         (PlatformContextSkia::getStrokeStyle):
2105         (PlatformContextSkia::setStrokeStyle):
2106         (PlatformContextSkia::setStrokeColor):
2107         (PlatformContextSkia::getStrokeThickness):
2108         (PlatformContextSkia::setStrokeThickness):
2109         (PlatformContextSkia::getTextDrawingMode):
2110         (PlatformContextSkia::setTextDrawingMode):
2111         (PlatformContextSkia::setUseAntialiasing):
2112         (PlatformContextSkia::fillColor):
2113         (PlatformContextSkia::beginPath):
2114         (PlatformContextSkia::addPath):
2115         (PlatformContextSkia::setFillRule):
2116         (PlatformContextSkia::setGradient):
2117         (PlatformContextSkia::setPattern):
2118         (PlatformContextSkia::setDashPathEffect):
2119         (PlatformContextSkia::paintSkPaint):
2120         (PlatformContextSkia::bitmap):
2121         (PlatformContextSkia::isPrinting):
2122         * platform/graphics/skia/PlatformContextSkia.h: Added.
2123         (PlatformContextSkia::currentPath):
2124         (PlatformContextSkia::canvas):
2125         (PlatformContextSkia::gdk_skia):
2126         * platform/graphics/skia/PlatformGraphics.h: Added.
2127
2128 2009-01-09  Dimitri Glazkov  <dglazkov@chromium.org>
2129
2130         Reviewed by Eric Seidel.
2131
2132         Add TransformationMatrixSkia to platform/graphics/skia
2133         https://bugs.webkit.org/show_bug.cgi?id=23215
2134
2135         * platform/graphics/skia/TransformationMatrixSkia.cpp: Added.
2136         (WebCore::TransformationMatrix::TransformationMatrix):
2137         (WebCore::TransformationMatrix::setMatrix):
2138         (WebCore::TransformationMatrix::map):
2139         (WebCore::TransformationMatrix::mapRect):
2140         (WebCore::TransformationMatrix::isIdentity):
2141         (WebCore::TransformationMatrix::reset):
2142         (WebCore::TransformationMatrix::scale):
2143         (WebCore::TransformationMatrix::rotate):
2144         (WebCore::TransformationMatrix::translate):
2145         (WebCore::TransformationMatrix::shear):
2146         (WebCore::TransformationMatrix::det):
2147         (WebCore::TransformationMatrix::inverse):
2148         (WebCore::TransformationMatrix::operator SkMatrix):
2149         (WebCore::TransformationMatrix::operator==):
2150         (WebCore::TransformationMatrix::operator*=):
2151         (WebCore::TransformationMatrix::operator*):
2152         (WebCore::TransformationMatrix::a):
2153         (WebCore::TransformationMatrix::setA):
2154         (WebCore::TransformationMatrix::b):
2155         (WebCore::TransformationMatrix::setB):
2156         (WebCore::TransformationMatrix::c):
2157         (WebCore::TransformationMatrix::setC):
2158         (WebCore::TransformationMatrix::d):
2159         (WebCore::TransformationMatrix::setD):
2160         (WebCore::TransformationMatrix::e):
2161         (WebCore::TransformationMatrix::setE):
2162         (WebCore::TransformationMatrix::f):
2163         (WebCore::TransformationMatrix::setF):
2164
2165 2009-01-09  Alexey Proskuryakov  <ap@webkit.org>
2166
2167         Reviewed by Darin Adler.
2168
2169         <rdar://problem/6477502> Repro crash reloading page using HTML5 AppCache on Windows
2170
2171         Test: http/tests/appcache/reload.html
2172
2173         On Windows, reloading resulted in the following sequence of events:
2174         1) A new main resource loader was created and associated with the cache. Its document loader
2175         was not associated with the cache yet.
2176         2) The old document loader was destroyed, and since it was the last one, ApplicationCacheGroup
2177         teardown started, with newestCache being zeroed out.
2178         3) The new document loader was associated with the cache group, and cache update started.
2179         4) Since newestCache was null, this caused many problems.
2180
2181         * loader/appcache/ApplicationCacheGroup.cpp:
2182         (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Improve comments and assertions,
2183         no functional changes.
2184         (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the cache group
2185         if its newest cache pointer is already saved for teardown. Note that the cache pointer
2186         validity is ensured by MainResourceLoader that holds a reference to it.
2187
2188 2009-01-09  Darin Fisher  <darin@chromium.org>
2189
2190         Reviewed by Eric Seidel.
2191
2192         https://bugs.webkit.org/show_bug.cgi?id=23214
2193         Upstream platform/network/chromium/
2194
2195         * platform/network/chromium/AuthenticationChallenge.h: Added.
2196         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
2197         (WebCore::AuthenticationChallenge::sourceHandle):
2198         * platform/network/chromium/AuthenticationChallengeChromium.cpp: Added.
2199         (WebCore::AuthenticationChallenge::platformCompare):
2200         * platform/network/chromium/CookieJarChromium.cpp: Added.
2201         (WebCore::setCookies):
2202         (WebCore::cookies):
2203         (WebCore::cookiesEnabled):
2204         * platform/network/chromium/DNSChromium.cpp: Added.
2205         (WebCore::prefetchDNS):
2206         * platform/network/chromium/NetworkStateNotifierChromium.cpp: Added.
2207         (WebCore::NetworkStateNotifier::updateState):
2208         (WebCore::NetworkStateNotifier::NetworkStateNotifier):
2209         * platform/network/chromium/NetworkStateNotifierPrivate.h: Added.
2210         * platform/network/chromium/ResourceError.h: Added.
2211         (WebCore::ResourceError::ResourceError):
2212         * platform/network/chromium/ResourceRequest.h: Added.
2213         (WebCore::ResourceRequest::):
2214         (WebCore::ResourceRequest::ResourceRequest):
2215         (WebCore::ResourceRequest::frame):
2216         (WebCore::ResourceRequest::setFrame):
2217         (WebCore::ResourceRequest::setTargetType):
2218         (WebCore::ResourceRequest::targetType):
2219         (WebCore::ResourceRequest::originPid):
2220         (WebCore::ResourceRequest::setOriginPid):
2221         (WebCore::ResourceRequest::securityInfo):
2222         (WebCore::ResourceRequest::setSecurityInfo):
2223         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2224         (WebCore::ResourceRequest::doUpdateResourceRequest):
2225         * platform/network/chromium/ResourceResponse.h:
2226         (WebCore::ResourceResponse::ResourceResponse):
2227         (WebCore::ResourceResponse::getSecurityInfo):
2228         (WebCore::ResourceResponse::setSecurityInfo):
2229         (WebCore::ResourceResponse::isContentFiltered):
2230         (WebCore::ResourceResponse::setIsContentFiltered):
2231         (WebCore::ResourceResponse::doUpdateResourceResponse):
2232
2233 2009-01-09  Peter Kasting  <pkasting@google.com>
2234
2235         Reviewed by David Hyatt.
2236
2237         https://bugs.webkit.org/show_bug.cgi?id=22995
2238         Fix flaky image animation by resetting the metadata for a frame when
2239         we get new data for that frame.  This fixes animations that halted
2240         when the next frame of the animation wasn't complete by the time the
2241         current frame's duration expired.
2242
2243         * platform/graphics/BitmapImage.cpp:
2244         (WebCore::BitmapImage::destroyDecodedData):
2245         (WebCore::BitmapImage::dataChanged):
2246         * platform/graphics/BitmapImage.h:
2247         (WebCore::FrameData::~FrameData):
2248         * platform/graphics/cairo/ImageCairo.cpp:
2249         (WebCore::FrameData::clear):
2250         * platform/graphics/cg/ImageCG.cpp:
2251         (WebCore::FrameData::clear):
2252         * platform/graphics/qt/ImageQt.cpp:
2253         (WebCore::FrameData::clear):
2254         * platform/graphics/wx/ImageWx.cpp:
2255         (WebCore::FrameData::clear):
2256
2257 2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>
2258
2259         Rubber-stamped by Tor Arne Vestbø.
2260
2261         Swap the .h and the .cpp output in the Qt build for the
2262         UserAgentStyleSheetData files, to put the definition in the .cpp file
2263         and the declaration in the header file.
2264
2265         * WebCore.pro:
2266
2267 2009-01-09  David Levin  <levin@chromium.org>
2268
2269         Reviewed by Oliver Hunt.
2270
2271         https://bugs.webkit.org/show_bug.cgi?id=23175
2272
2273         Added forwarding header.
2274
2275         * ForwardingHeaders/wtf/PtrAndFlags.h: Added.
2276
2277 2009-01-09  Tor Arne Vestbø  <tavestbo@trolltech.com>
2278
2279         Reviewed by Simon Hausmann.
2280
2281         Prevent qmake from generating duplicate rules for embedded stylesheets
2282         
2283         The STYLESHEETS_EMBED variable used to contain only one file name, but
2284         now that it is a list of files we need to change it to be a dependency
2285         for the stylesheet generator instead of the input.
2286
2287         * WebCore.pro:
2288
2289 2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>
2290
2291         Reviewed by Tor Arne Vestbø.
2292
2293         Fix qmake warning about missing test function, a contains() call was
2294         missing.
2295
2296         * WebCore.pro:
2297
2298 2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>
2299
2300         Rubber-stamped by Tor Arne Vestbø.
2301
2302         Add the Qt API headers to HEADERS, too, for improved completion in IDEs.
2303
2304         * WebCore.pro:
2305
2306 2009-01-09  David Levin  <levin@chromium.org>
2307
2308         Reviewed by Alexey Proskuryakov.
2309
2310         https://bugs.webkit.org/show_bug.cgi?id=23199
2311
2312         Fix deref's of string happening on two different threads.
2313
2314         No observable change in behavior, so no test.  However, there are asserts
2315         being added for https://bugs.webkit.org/show_bug.cgi?id=23175 which
2316         will detect this issue while running the normal worker tests.
2317
2318         * dom/WorkerThread.cpp:
2319         (WebCore::WorkerThreadStartupData::create):
2320         (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
2321         (WebCore::WorkerThread::WorkerThread):
2322         (WebCore::WorkerThread::workerThread):
2323         * dom/WorkerThread.h:
2324
2325 2009-01-08  Dan Bernstein  <mitz@apple.com>
2326
2327         Reviewed by Adam Roben.
2328
2329         - use native glyph support in Core Graphics when available
2330
2331         * platform/graphics/win/FontCGWin.cpp:
2332         (WebCore::Font::drawGlyphs): Changed to use drawGDIGlyphs() only if
2333         native glyph support is not available or stroking is required. Changed
2334         to pass the font's useGDI() flag to wkSetCGContextFontRenderingStyle to
2335         request the use of native glyphs.
2336         * platform/graphics/win/FontCustomPlatformData.cpp:
2337         (WebCore::FontCustomPlatformData::fontPlatformData): Added a call to
2338         wkSetFontPlatformInfo to attach the LOGFONT to the CGFont.
2339         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2340         (WebCore::FontPlatformData::platformDataInit): Ditto.
2341
2342 2009-01-08  Peter Kasting  <pkasting@google.com>
2343
2344         Reviewed by Sam Weinig.
2345
2346         https://bugs.webkit.org/show_bug.cgi?id=22929
2347         Fix memory regression when decoding large animated GIFs.
2348
2349         * platform/graphics/cg/ImageSourceCG.cpp:
2350         (WebCore::ImageSource::clear):
2351
2352 2009-01-08  Scott Violet  <sky@chromium.org>
2353
2354         Reviewed by Eric Seidel (and Adam Barth).
2355
2356         Fix Images to return their file extension
2357         http://code.google.com/p/chromium/issues/detail?id=5827
2358
2359         * platform/graphics/skia/ImageSourceSkia.cpp:
2360         (WebCore::ImageSource::filenameExtension):
2361
2362 2009-01-08  Dimitri Glazkov  <dglazkov@chromium.org>
2363
2364         Reviewed by Eric Seidel.
2365
2366         Add PathSkia and PatternSkia implementations to WebCore
2367         https://bugs.webkit.org/show_bug.cgi?id=23200
2368
2369         * platform/graphics/skia/PathSkia.cpp: Added.
2370         (WebCore::Path::Path):
2371         (WebCore::Path::~Path):
2372         (WebCore::Path::operator=):
2373         (WebCore::Path::isEmpty):
2374         (WebCore::Path::contains):
2375         (WebCore::Path::translate):
2376         (WebCore::Path::boundingRect):
2377         (WebCore::Path::moveTo):
2378         (WebCore::Path::addLineTo):
2379         (WebCore::Path::addQuadCurveTo):
2380         (WebCore::Path::addBezierCurveTo):
2381         (WebCore::Path::addArcTo):
2382         (WebCore::Path::closeSubpath):
2383         (WebCore::Path::addArc):
2384         (WebCore::Path::addRect):
2385         (WebCore::Path::addEllipse):
2386         (WebCore::Path::clear):
2387         (WebCore::convertPathPoints):
2388         (WebCore::Path::apply):
2389         (WebCore::Path::transform):
2390         (WebCore::Path::debugString):
2391         (WebCore::boundingBoxForCurrentStroke):
2392         (WebCore::Path::strokeBoundingRect):
2393         * platform/graphics/skia/PatternSkia.cpp: Added.
2394         (WebCore::shaderRule):
2395         (WebCore::Pattern::createPlatformPattern):
2396
2397 2009-01-08  Dimitri Glazkov  <dglazkov@chromium.org>
2398
2399         Reviewed by Eric Seidel.
2400
2401         Add ImageSourceSkia to platform/graphics/skia
2402         https://bugs.webkit.org/show_bug.cgi?id=23200
2403         
2404         ImageSourceSkia is mostly a hack to support our
2405         ICO decoder model.  See ImageSourceSkia.h for more
2406         explanation.  Eventually we'd like to make our ICO
2407         decoder lazy.
2408
2409         * platform/graphics/ImageSource.h: mark m_decoder as protected
2410         * platform/graphics/skia/ImageSourceSkia.cpp: Added.
2411         (WebCore::createDecoder):
2412         (WebCore::ImageSource::ImageSource):
2413         (WebCore::ImageSource::~ImageSource):
2414         (WebCore::ImageSource::clear):
2415         (WebCore::ImageSource::initialized):
2416         (WebCore::ImageSource::setData):
2417         (WebCore::ImageSource::isSizeAvailable):
2418         (WebCore::ImageSource::size):
2419         (WebCore::ImageSource::frameSizeAtIndex):
2420         (WebCore::ImageSource::repetitionCount):
2421         (WebCore::ImageSource::frameCount):
2422         (WebCore::ImageSource::createFrameAtIndex):
2423         (WebCore::ImageSource::frameIsCompleteAtIndex):
2424         (WebCore::ImageSource::frameDurationAtIndex):
2425         (WebCore::ImageSource::frameHasAlphaAtIndex):
2426         (WebCore::ImageSourceSkia::setData):
2427         (WebCore::ImageSource::filenameExtension):
2428         * platform/graphics/skia/ImageSourceSkia.h: Added.
2429
2430 2009-01-08  Dimitri Glazkov  <dglazkov@chromium.org>
2431
2432         Reviewed by Eric Seidel.
2433
2434         Add NativeImageSkia (PlatformImagePtr) to platform/graphics/skia
2435         https://bugs.webkit.org/show_bug.cgi?id=23200
2436
2437         * platform/graphics/skia/NativeImageSkia.cpp: Added.
2438         (NativeImageSkia::NativeImageSkia):
2439         (NativeImageSkia::decodedSize):
2440         (NativeImageSkia::hasResizedBitmap):
2441         (NativeImageSkia::resizedBitmap):
2442         (NativeImageSkia::shouldCacheResampling):
2443         * platform/graphics/skia/NativeImageSkia.h: Added.
2444         (NativeImageSkia::setDataComplete):
2445         (NativeImageSkia::isDataComplete):
2446
2447 2009-01-08  Dimitri Glazkov  <dglazkov@chromium.org>
2448
2449         Reviewed by Eric Seidel.
2450
2451         Add ImageBufferSkia and ImageSkia files.
2452         https://bugs.webkit.org/show_bug.cgi?id=23200
2453         For now we've left BitmapImage and BitmapImageSingleFrameSkia
2454         implementations in the ImageSkia file (like ImageCG has), but
2455         we intend to break them out into their own files.
2456
2457         * platform/graphics/skia/ImageBufferSkia.cpp: Added.
2458         (WebCore::ImageBufferData::ImageBufferData):
2459         (WebCore::ImageBuffer::ImageBuffer):
2460         (WebCore::ImageBuffer::~ImageBuffer):
2461         (WebCore::ImageBuffer::context):
2462         (WebCore::ImageBuffer::image):
2463         (WebCore::ImageBuffer::getImageData):
2464         (WebCore::ImageBuffer::putImageData):
2465         (WebCore::ImageBuffer::toDataURL):
2466         * platform/graphics/skia/ImageSkia.cpp: Added.
2467         (WebCore::):
2468         (WebCore::FrameData::clear):
2469         (WebCore::Image::loadPlatformResource):
2470         (WebCore::Image::drawPattern):
2471         (WebCore::BitmapImage::initPlatformData):
2472         (WebCore::BitmapImage::invalidatePlatformData):
2473         (WebCore::BitmapImage::checkForSolidColor):
2474         (WebCore::BitmapImage::draw):
2475         (WebCore::BitmapImageSingleFrameSkia::draw):
2476         (WebCore::BitmapImageSingleFrameSkia::create):
2477
2478 2009-01-08  James Robinson  <jamesr@google.com>
2479
2480         Reviewed by Mark Rowe.
2481         Landed by Pamela Greene.
2482
2483         WebCore::Event::timeStamp() is a simple accessor and should be const
2484
2485         https://bugs.webkit.org/show_bug.cgi?id=23176
2486
2487         * dom/Event.h:
2488         (WebCore::Event::timeStamp):
2489
2490 2009-01-08  Antti Koivisto  <antti@apple.com>
2491
2492         Reviewed by Oliver Hunt.
2493
2494         Fix <rdar://problem/6467206> 
2495         Resources loaded from the memory cache do not get correctly inserted into the DocLoader resource map (22994)
2496         
2497         Use CachedResourceHandle in document resource map so resources get updated correctly when using
2498         using cache validation conditionals.
2499
2500         * loader/Cache.cpp:
2501         (WebCore::Cache::evict):
2502         * loader/DocLoader.cpp:
2503         (WebCore::DocLoader::~DocLoader):
2504         (WebCore::DocLoader::requestResource):
2505         (WebCore::DocLoader::setAutoLoadImages):
2506         (WebCore::DocLoader::removeCachedResource):
2507         * loader/DocLoader.h:
2508         (WebCore::DocLoader::cachedResource):
2509         (WebCore::DocLoader::allCachedResources):
2510         * loader/DocumentLoader.cpp:
2511         (WebCore::DocumentLoader::getSubresources):
2512         * loader/ImageLoader.cpp:
2513         (WebCore::ImageLoader::updateFromElement):
2514
2515 2009-01-08  Dimitri Glazkov  <dglazkov@chromium.org>
2516
2517         Reviewed by Eric Seidel.
2518
2519         Add a cleaned-up GraphicsContextSkia implementation to WebKit.
2520         https://bugs.webkit.org/show_bug.cgi?id=23191
2521
2522         * platform/graphics/skia/GraphicsContextSkia.cpp: Added.
2523         (WebCore::):
2524         (WebCore::GraphicsContext::GraphicsContext):
2525         (WebCore::GraphicsContext::~GraphicsContext):
2526         (WebCore::GraphicsContext::platformContext):
2527         (WebCore::GraphicsContext::savePlatformState):
2528         (WebCore::GraphicsContext::restorePlatformState):
2529         (WebCore::GraphicsContext::beginTransparencyLayer):
2530         (WebCore::GraphicsContext::endTransparencyLayer):
2531         (WebCore::GraphicsContext::addInnerRoundedRectClip):
2532         (WebCore::GraphicsContext::addPath):
2533         (WebCore::GraphicsContext::beginPath):
2534         (WebCore::GraphicsContext::clearPlatformShadow):
2535         (WebCore::GraphicsContext::clearRect):
2536         (WebCore::GraphicsContext::clip):
2537         (WebCore::GraphicsContext::clipOut):
2538         (WebCore::GraphicsContext::clipOutEllipseInRect):
2539         (WebCore::GraphicsContext::clipPath):
2540         (WebCore::GraphicsContext::clipToImageBuffer):
2541         (WebCore::GraphicsContext::concatCTM):
2542         (WebCore::GraphicsContext::drawConvexPolygon):
2543         (WebCore::GraphicsContext::drawEllipse):
2544         (WebCore::GraphicsContext::drawFocusRing):
2545         (WebCore::GraphicsContext::drawLine):
2546         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2547         (WebCore::GraphicsContext::drawLineForText):
2548         (WebCore::GraphicsContext::drawRect):
2549         (WebCore::GraphicsContext::fillPath):
2550         (WebCore::GraphicsContext::fillRect):
2551         (WebCore::GraphicsContext::fillRoundedRect):
2552         (WebCore::GraphicsContext::getCTM):
2553         (WebCore::GraphicsContext::roundToDevicePixels):
2554         (WebCore::GraphicsContext::scale):
2555         (WebCore::GraphicsContext::setAlpha):
2556         (WebCore::GraphicsContext::setCompositeOperation):
2557         (WebCore::GraphicsContext::setImageInterpolationQuality):
2558         (WebCore::GraphicsContext::setLineCap):
2559         (WebCore::GraphicsContext::setLineDash):
2560         (WebCore::GraphicsContext::setLineJoin):
2561         (WebCore::GraphicsContext::setMiterLimit):
2562         (WebCore::GraphicsContext::setPlatformFillColor):
2563         (WebCore::GraphicsContext::setPlatformShadow):
2564         (WebCore::GraphicsContext::setPlatformStrokeColor):
2565         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2566         (WebCore::GraphicsContext::setPlatformStrokeThickness):
2567         (WebCore::GraphicsContext::setPlatformTextDrawingMode):
2568         (WebCore::GraphicsContext::setURLForRect):
2569         (WebCore::GraphicsContext::setUseAntialiasing):
2570         (WebCore::GraphicsContext::strokeArc):
2571         (WebCore::GraphicsContext::strokePath):
2572         (WebCore::GraphicsContext::strokeRect):
2573         (WebCore::GraphicsContext::rotate):
2574         (WebCore::GraphicsContext::translate):
2575
2576 2009-01-08  David Hyatt  <hyatt@apple.com>
2577
2578         Fix for <rdar://problem/6465682> REGRESSION: In Mail, can't force a message to auto scroll.
2579
2580         Make scrollRectIntoViewRecursively call out to the HostWindow to continue the recursive scroll for
2581         any scrollable views that may contain a WebView.  Does nothing on platforms other than the Mac, but
2582         might eventually be of interest to other platforms.
2583
2584         Reviewed by Oliver Hunt
2585
2586         * WebCore.base.exp:
2587         * page/Chrome.cpp:
2588         (WebCore::Chrome::scrollRectIntoView):
2589         * page/Chrome.h:
2590         * page/ChromeClient.h:
2591         (WebCore::ChromeClient::scrollRectIntoView):
2592         * platform/HostWindow.h:
2593         * platform/ScrollView.cpp:
2594         (WebCore::ScrollView::scrollRectIntoViewRecursively):
2595
2596 2009-01-08  Adam Treat  <adam.treat@torchmobile.com>
2597
2598         Reviewed by David Hyatt.
2599
2600         No need to make this part of HostWindow and moreover HostWindow should
2601         not have any reference to non-platform parts of WebCore.
2602
2603         * page/Chrome.h:
2604         * page/FrameView.cpp:
2605         (WebCore::FrameView::setContentsSize):
2606         * platform/HostWindow.h:
2607
2608 2009-01-08  Eric Carlson  <eric.carlson@apple.com>
2609
2610         Reviewed by Adele Peterson.
2611
2612         Simplify Mac interfaces for drawing media controller elements
2613
2614         <rdar://problem/6293969>
2615
2616         * WebCore.base.exp: update for changed WebKitSystemInterface media controller functions
2617
2618         * platform/mac/WebCoreSystemInterface.h: Ditto
2619         * platform/mac/WebCoreSystemInterface.mm: Ditto
2620
2621         * rendering/MediaControlElements.h:
2622         (WebCore::): Add MediaControlElements enum
2623
2624         * rendering/RenderThemeMac.mm:
2625         (WebCore::RenderThemeMac::paintMediaFullscreenButton):  update for changed WebKitSystemInterface
2626         media controller functions
2627         (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto
2628         (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto
2629         (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto
2630         (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto
2631         (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto
2632         (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto
2633
2634 2009-01-08  Dimitri Glazkov  <dglazkov@chromium.org>
2635
2636         Reviewed by Eric Seidel.
2637
2638         Add two more files for platform/graphics/skia.
2639         https://bugs.webkit.org/show_bug.cgi?id=23191
2640
2641         * platform/graphics/skia/GradientSkia.cpp: Added.
2642         (WebCore::Gradient::platformDestroy):
2643         (WebCore::F2B):
2644         (WebCore::makeSkColor):
2645         (WebCore::totalStopsNeeded):
2646         (WebCore::fillStops):
2647         (WebCore::compareStops):
2648         (WebCore::Gradient::platformGradient):
2649         (WebCore::Gradient::fill):
2650         * platform/graphics/skia/GraphicsContextPlatformPrivate.h: Copied from WebCore/bindings/js/ScriptValue.h.
2651         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
2652         (WebCore::GraphicsContextPlatformPrivate::context):
2653
2654 2009-01-08  Dimitri Glazkov  <dglazkov@chromium.org>
2655
2656         Reviewed by Eric Seidel.
2657
2658         Commit the right files this time!  (Instead of the ugly unfixed ones.)
2659         https://bugs.webkit.org/show_bug.cgi?id=23191
2660
2661         * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
2662         * platform/graphics/skia/FloatPointSkia.cpp:
2663         * platform/graphics/skia/FloatRectSkia.cpp:
2664         * platform/graphics/skia/IntPointSkia.cpp:
2665         * platform/graphics/skia/IntRectSkia.cpp:
2666         (WebCore::IntRect::operator SkRect):
2667         * platform/graphics/skia/SkiaUtils.cpp:
2668         (WebCore::):
2669         (WebCore::WebCoreCompositeToSkiaComposite):
2670         (WebCore::SkPMColorToWebCoreColor):
2671         (WebCore::IntersectRectAndRegion):
2672         (WebCore::ClipRectToCanvas):
2673         (WebCore::SkPathContainsPoint):
2674         (WebCore::scratchContext):
2675         * platform/graphics/skia/SkiaUtils.h:
2676         (WebCore::WebCoreFloatToSkScalar):
2677         (WebCore::WebCoreDoubleToSkScalar):
2678
2679 2009-01-08  Dimitri Glazkov  <dglazkov@chromium.org>
2680
2681         Reviewed by Eric Seidel.
2682
2683         Add the first few files from platform/graphics/skia
2684         https://bugs.webkit.org/show_bug.cgi?id=23191
2685
2686         These are all pretty simple.
2687         Eventually BitmapImageSingleFrameSkia might grow a .cpp file, for now it's just a header.
2688         SkiaUtils needs to die, but that can come later, no need to block up-streaming now.
2689
2690         * platform/graphics/skia/BitmapImageSingleFrameSkia.h: Added.
2691         (WebCore::BitmapImageSingleFrameSkia::isBitmapImage):
2692         (WebCore::BitmapImageSingleFrameSkia::size):
2693         (WebCore::BitmapImageSingleFrameSkia::destroyDecodedData):
2694         (WebCore::BitmapImageSingleFrameSkia::decodedSize):
2695         (WebCore::BitmapImageSingleFrameSkia::nativeImageForCurrentFrame):
2696         (WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
2697         * platform/graphics/skia/FloatPointSkia.cpp: Copied from WebCore/platform/graphics/mac/FloatPointMac.mm.
2698         (WebCore::FloatPoint::FloatPoint):
2699         (WebCore::FloatPoint::operator SkPoint):
2700         * platform/graphics/skia/FloatRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp.
2701         (WebCore::FloatRect::FloatRect):
2702         (WebCore::FloatRect::operator SkRect):
2703         * platform/graphics/skia/IntPointSkia.cpp: Copied from WebCore/platform/graphics/win/IntPointWin.cpp.
2704         (WebCore::IntPoint::IntPoint):
2705         (WebCore::IntPoint::operator SkIPoint):
2706         (WebCore::IntPoint::operator SkPoint):
2707         * platform/graphics/skia/IntRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp.
2708         (WebCore::IntRect::operator SkIRect):
2709         (WebCore::IntRect::operator SkRect):
2710         (WebCore::IntRect::IntRect):
2711         * platform/graphics/skia/SkiaUtils.cpp: Added.
2712         (WebCore::WebCorePointToSkiaPoint):
2713         (WebCore::WebCoreRectToSkiaRect):
2714         (WebCore::):
2715         (WebCore::WebCoreCompositeToSkiaComposite):
2716         (WebCore::InvScaleByte):
2717         (WebCore::SkPMColorToColor):
2718         (WebCore::SkPMColorToWebCoreColor):
2719         (WebCore::IntersectRectAndRegion):
2720         (WebCore::ClipRectToCanvas):
2721         (WebCore::SkPathContainsPoint):
2722         (WebCore::scratchContext):
2723         * platform/graphics/skia/SkiaUtils.h: Added.
2724         (WebCore::WebCoreFloatToSkScalar):
2725         (WebCore::WebCoreDoubleToSkScalar):
2726
2727 2009-01-08  Pierre-Olivier Latour  <pol@apple.com>
2728
2729         Reviewed by Dan Bernstein.
2730
2731         Fixed CSS Transitions with zero-duration but non-zero-delay not starting or ending properly.
2732
2733         Also updated AnimationController::numberOfActiveAnimations() which now returns the number of "active" animations,
2734         instead of simply the "running" ones.
2735
2736         https://bugs.webkit.org/show_bug.cgi?id=23177
2737
2738         Tests: transitions/zero-duration-with-non-zero-delay-end.html
2739                transitions/zero-duration-with-non-zero-delay-start.html
2740
2741         * page/animation/AnimationBase.cpp:
2742         (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
2743         * page/animation/AnimationController.cpp:
2744         (WebCore::AnimationControllerPrivate::animationTimerFired):
2745         * page/animation/CompositeAnimation.cpp:
2746         (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
2747
2748 2009-01-08  Alexey Proskuryakov  <ap@webkit.org>
2749
2750         Reviewed by Oliver Hunt.
2751
2752         <rdar://problem/6477501> Repro crash loading HTML5 AppCache manifest directly
2753
2754         The crash happened whenever a cached resource was downloaded, as opposed to used directly.
2755
2756         No test, as downloading cannot be tested automatically.
2757
2758         * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
2759         Cancel downloads that do not have an associated ResourceHandle, such as downloads from the
2760         application cache. Activity window shows "The URL can't be shown", and the frame remains empty.
2761
2762 2009-01-08  Justin McPherson <justin.mcpherson@nokia.com>
2763
2764         Reviewed by Simon Hausmann.
2765
2766         Fix the Qt build on older X11 systems with special X paths.
2767
2768         * WebCore.pro: Use the x11 qmake config to pull in extra paths
2769         needed for NPAPI.
2770
2771 2009-01-08  Adam Roben  <aroben@apple.com>
2772
2773         Windows build fix after r39699
2774
2775         * DerivedSources.cpp: Added JSDOMStringList.cpp.
2776
2777 2009-01-08  Kent Hansen  <khansen@trolltech.com>
2778
2779         Reviewed by Simon Hausmann.
2780
2781         Fix copy & paste of images in the Qt port.
2782
2783         Store the QPixmap itself in the mimedata, not a QPixmap* converted to bool.
2784
2785         * platform/qt/ClipboardQt.cpp:
2786         (WebCore::ClipboardQt::declareAndWriteDragImage):
2787
2788 2009-01-08  Hiroyuki Ikezoe  <poincare@ikezoe.net>
2789
2790         Reviewed by Holger Freyther.
2791
2792         https://bugs.webkit.org/show_bug.cgi?id=23127
2793
2794         Invoke pango_coverage_get with each Unicode character.
2795
2796         * platform/graphics/gtk/SimpleFontDataPango.cpp:
2797         (WebCore::SimpleFontData::containsCharacters):
2798
2799 2009-01-07  Alexey Proskuryakov  <ap@webkit.org>
2800
2801         Reviewed by Darin Adler.
2802
2803         Part one of 
2804         https://bugs.webkit.org/show_bug.cgi?id=23165
2805         Add support for application cache dynamic entries
2806
2807         Test: http/tests/appcache/dynamic-entries-no-cache.html
2808
2809         * DerivedSources.make:
2810         * GNUmakefile.am:
2811         * WebCore.pro:
2812         * WebCore.scons:
2813         * WebCore.vcproj/WebCore.vcproj:
2814         * WebCore.xcodeproj/project.pbxproj:
2815         * WebCoreSources.bkl:
2816         Added new files.
2817
2818         * bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem):
2819         Added binding for hasItem(). Like other DOMApplicationCache methods, it needs to be custom
2820         to resolve relative URLs correctly.
2821
2822         * bindings/js/JSDOMStringListCustom.cpp: Added.
2823         * dom/DOMStringList.cpp: Added.
2824         * dom/DOMStringList.h: Added.
2825         * dom/DOMStringList.idl: Added.
2826         Added an implementation of DOM 3 Core DOMStringList interface, which is returned by
2827         DOMApplicationCache items attribute.
2828
2829         * dom/StaticStringList.cpp: Added.
2830         * dom/StaticStringList.h: Added.
2831         An implementation of DOMStringList that makes a snapshot (for DOMApplicationCache, this
2832         matches Firefox, as the spec doesn't say whether the returned list should be live or not).
2833
2834         * loader/appcache/ApplicationCache.h: Added a list of pending dynamic entry actions, to be
2835         used in the near future.
2836
2837         * loader/appcache/DOMApplicationCache.idl: Updated for spec changes. Instead of length 
2838         attribute and item(), we now have an items attribute that returns a DOMStringList, and a
2839         hasItem convenience method.
2840
2841         * loader/appcache/DOMApplicationCache.cpp:
2842         (WebCore::DOMApplicationCache::items):
2843         (WebCore::DOMApplicationCache::hasItem):
2844         * loader/appcache/DOMApplicationCache.h:
2845         Added implementations of items attribute and hasItem() (note that underlying ApplicationCache
2846         methods are still unimplemented though).
2847
2848         * page/DOMWindow.idl: Expose a DOMStringList global constructor.
2849
2850 2009-01-07  Chris Marrin  <cmarrin@apple.com>
2851
2852         Reviewed by Eric Seidel.
2853
2854         https://bugs.webkit.org/show_bug.cgi?id=23122
2855
2856         This completes the removal of dependencies on WebKit from the platform code
2857
2858         * css/CSSComputedStyleDeclaration.cpp:
2859         (WebCore::getDelayValue):
2860         (WebCore::getDurationValue):
2861         (WebCore::getTimingFunctionValue):
2862         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2863         * css/CSSHelper.h:
2864         * css/CSSStyleSelector.cpp:
2865         (WebCore::CSSStyleSelector::mapAnimationDelay):
2866         (WebCore::CSSStyleSelector::mapAnimationDirection):
2867         (WebCore::CSSStyleSelector::mapAnimationDuration):
2868         (WebCore::CSSStyleSelector::mapAnimationIterationCount):
2869         (WebCore::CSSStyleSelector::mapAnimationName):
2870         (WebCore::CSSStyleSelector::mapAnimationPlayState):
2871         (WebCore::CSSStyleSelector::mapAnimationProperty):
2872         (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
2873         * platform/animation/Animation.cpp:
2874         (WebCore::Animation::Animation):
2875         * platform/animation/Animation.h:
2876         (WebCore::Animation::initialAnimationDelay):
2877         (WebCore::Animation::initialAnimationDirection):
2878         (WebCore::Animation::initialAnimationDuration):
2879         (WebCore::Animation::initialAnimationIterationCount):
2880         (WebCore::Animation::initialAnimationName):
2881         (WebCore::Animation::initialAnimationPlayState):
2882         (WebCore::Animation::initialAnimationProperty):
2883         (WebCore::Animation::initialAnimationTimingFunction):
2884         * rendering/style/RenderStyle.h:
2885
2886 2008-01-07  Peter Kasting  <pkasting@google.com>
2887
2888         Reviewed by Sam Weinig.
2889
2890         https://bugs.webkit.org/show_bug.cgi?id=22929
2891
2892         Fix errors while decoding GIFs by not calling setData() repeatedly
2893         when it's not necessary.  Pushes the responsibility for calling
2894         setData() after clear() into the ImageSource which presumably knows
2895         better than BitmapImage what needs to be done.
2896
2897         NOTE: The above bug is mainly about a memory regression, which this
2898         patch does not fix.
2899
2900         * platform/graphics/BitmapImage.cpp:
2901         (WebCore::BitmapImage::destroyDecodedData):
2902         * platform/graphics/ImageSource.h:
2903         * platform/graphics/cairo/ImageSourceCairo.cpp:
2904         (WebCore::ImageSource::clear):
2905         * platform/graphics/cg/ImageSourceCG.cpp:
2906         (WebCore::ImageSource::clear):
2907         * platform/graphics/qt/ImageSourceQt.cpp:
2908         (WebCore::ImageSource::~ImageSource):
2909         (WebCore::ImageSource::clear):
2910         * platform/graphics/wx/ImageSourceWx.cpp:
2911         (WebCore::ImageSource::~ImageSource):
2912         (WebCore::ImageSource::clear):
2913
2914 2009-01-07  Justin Garcia  <justin.garcia@apple.com>
2915
2916         Reviewed by Darin Adler.
2917
2918         <rdar://problem/6355786> Find fails for queries that contain a line break
2919
2920         * editing/TextIterator.cpp:
2921         (WebCore::findPlainText): Allow find with queries that contain newlines.
2922
2923 2009-01-07  Dean Jackson  <dino@apple.com>
2924
2925         Reviewed by Dan Bernstein.
2926
2927         Allow removal of inline shorthand properties for
2928         animation, transition and transform origin. Also
2929         add getter for shorthand animation property.
2930
2931         https://bugs.webkit.org/show_bug.cgi?id=22605
2932
2933         Test: fast/css/transform-inline-style-remove.html
2934
2935         * css/CSSMutableStyleDeclaration.cpp:
2936         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
2937             Getter for animation property shorthand
2938         (WebCore::initShorthandMap):
2939             Adds initialisation for transform-origin, animation and transition
2940
2941 2009-01-07  Benjamin Otte  <otte@gnome.org>
2942
2943         Reviewed by Holger Freyther.
2944
2945         * platform/network/ResourceHandleInternal.h:
2946         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2947         * platform/network/soup/ResourceHandleSoup.cpp:
2948         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2949         (WebCore::parseDataUrl):
2950         (WebCore::ResourceHandle::startData): keep track of the idle handler
2951         we add and remove it in the destructor
2952
2953 2009-01-07  Dean Jackson  <dino@apple.com>
2954
2955         Reviewed by Darin Adler.
2956
2957         Finish renaming of AffineTransform to TransformationMatrix, this
2958         time ensuring that the platform implementations get the correct
2959         name. Also, clean up some whitespace cruft in old content.
2960
2961         https://bugs.webkit.org/show_bug.cgi?id=23151
2962
2963         * GNUmakefile.am:
2964         * WebCore.pro:
2965         * WebCore.scons:
2966         * WebCore.vcproj/WebCore.vcproj:
2967         * WebCore.xcodeproj/project.pbxproj:
2968         * platform/graphics/cairo/AffineTransformCairo.cpp: Removed.
2969         * platform/graphics/cairo/TransformationMatrixCairo.cpp: Copied from WebCore/platform/graphics/cairo/AffineTransformCairo.cpp.
2970         * platform/graphics/cg/AffineTransformCG.cpp: Removed.
2971         * platform/graphics/cg/TransformationMatrixCG.cpp: Copied from WebCore/platform/graphics/cg/AffineTransformCG.cpp.
2972         * platform/graphics/qt/AffineTransformQt.cpp: Removed.
2973         * platform/graphics/qt/TransformationMatrixQt.cpp: Copied from WebCore/platform/graphics/qt/AffineTransformQt.cpp.
2974         * platform/graphics/transforms/TransformationMatrix.cpp:
2975         * platform/graphics/transforms/TransformationMatrix.h:
2976         * platform/graphics/wx/AffineTransformWx.cpp: Removed.
2977         * platform/graphics/wx/TransformationMatrixWx.cpp: Copied from WebCore/platform/graphics/wx/AffineTransformWx.cpp.
2978         * webcore-wx.bkl:
2979
2980 2009-01-07  Anders Carlsson  <andersca@apple.com>
2981
2982         Another build fix.
2983         
2984         * WebCore.LP64.exp:
2985
2986 2008-12-16  David Hyatt  <hyatt@apple.com>
2987
2988         Make Safari RSS behave nicely with full page zoom.  Need to add a new value to enable resetting of zoom
2989         back to the document-level default.
2990
2991         Reviewed by Darin Adler
2992
2993         * css/CSSParser.cpp:
2994         (WebCore::CSSParser::parseValue):
2995         * css/CSSStyleSelector.cpp:
2996         (WebCore::CSSStyleSelector::applyProperty):
2997         * css/CSSValueKeywords.in:
2998
2999 2009-01-07  Darin Adler  <darin@apple.com>
3000
3001         Reviewed by Oliver Hunt.
3002
3003         Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
3004         https://bugs.webkit.org/show_bug.cgi?id=23160
3005
3006         * WebCore.base.exp: Added Page::setMemoryCacheClientCallsEnabled.
3007
3008         * inspector/InspectorController.cpp:
3009         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Updated to take a CachedResource
3010         so that there's no extra work the caller has to do when the inspector is disabled.
3011         * inspector/InspectorController.h: Ditto.
3012
3013         * loader/DocumentLoader.h: Added recordMemoryCacheLoadForFutureClientNotification,
3014         takeMemoryCacheLoadsForClientNotification, and m_resourcesLoadedFromMemoryCacheForClientNotification.
3015
3016         * loader/FrameLoader.cpp:
3017         (WebCore::FrameLoader::loadedResourceFromMemoryCache): Streamlined code so less work is done when
3018         there's no inspector or client call needed. Added code to check areMemoryCacheClientCallsEnabled
3019         and if it's false, use recordMemoryCacheLoadForFutureClientNotification.
3020         (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Added.
3021         * loader/FrameLoader.h: Ditto.
3022
3023         * page/Page.cpp:
3024         (WebCore::Page::Page): Initialize m_areMemoryCacheClientCallsEnabled to be compatible with old behavior.
3025         (WebCore::Page::setMemoryCacheClientCallsEnabled): Added.
3026         * page/Page.h: Added setMemoryCacheClientCallsEnabled, areMemoryCacheClientCallsEnabled,
3027         and m_areMemoryCacheClientCallsEnabled.
3028
3029 2009-01-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>
3030
3031         Rubber-stamped by Simon Hausmann.
3032
3033         Qt build fix after r39670.
3034
3035         * bridge/qt/qt_class.cpp:
3036         (JSC::Bindings::QtClass::fallbackObject):
3037         * bridge/qt/qt_class.h:
3038         * bridge/qt/qt_instance.cpp:
3039         (JSC::Bindings::QtInstance::mark):
3040         (JSC::Bindings::QtInstance::invokeMethod):
3041         (JSC::Bindings::QtInstance::defaultValue):
3042         (JSC::Bindings::QtInstance::stringValue):
3043         (JSC::Bindings::QtInstance::numberValue):
3044         (JSC::Bindings::QtInstance::booleanValue):
3045         (JSC::Bindings::QtInstance::valueOf):
3046         (JSC::Bindings::QtField::valueFromInstance):
3047         (JSC::Bindings::QtField::setValueToInstance):
3048         * bridge/qt/qt_instance.h:
3049         * bridge/qt/qt_runtime.cpp:
3050         (JSC::Bindings::valueRealType):
3051         (JSC::Bindings::convertValueToQVariant):
3052         (JSC::Bindings::convertQVariantToValue):
3053         (JSC::Bindings::findMethodIndex):
3054         (JSC::Bindings::QtRuntimeMetaMethod::call):
3055         (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
3056         (JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
3057         (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
3058         (JSC::Bindings::QtRuntimeConnectionMethod::call):
3059         (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
3060         (JSC::Bindings::::setValueAt):
3061         (JSC::Bindings::::valueAt):
3062         * bridge/qt/qt_runtime.h:
3063         (JSC::Bindings::QtRuntimeMethod::createStructure):
3064
3065 2009-01-06  Justin Garcia  <justin.garcia@apple.com>
3066
3067         Reviewed by Oliver Hunt.
3068
3069         <rdar://problem/6391734> SnowLeopard: Crash doing Copy Image from context menu
3070         
3071         Can't create an automated test case for specific contextual menu items yet and
3072         a normal Copy doesn't cause a crash.
3073
3074         * platform/mac/PasteboardMac.mm:
3075         (WebCore::fileWrapperForImage): The SharedBuffer may not have platform data.  It may,
3076         for example, have a purgeable or regular buffer.
3077
3078 2009-01-06  Mark Rowe  <mrowe@apple.com>
3079
3080         Reviewed by Geoff Garen.
3081
3082         Fix <https://bugs.webkit.org/show_bug.cgi?id=23157>.
3083         Bug 23157: Crashes on Acid 3
3084
3085         * dom/Document.cpp:
3086         (WebCore::Document::recalcStyle): Null-check the frame.
3087
3088 2009-01-05  Gavin Barraclough  <baraclough@apple.com>
3089
3090         Rubber Stamped by Oliver Hunt.
3091
3092         Replace all uses of JSValue* with new wrapper class, JSValuePtr.
3093         See JavaScriptCore/ChangeLog for more detailed description.
3094
3095         * bindings/js/JSAttrCustom.cpp:
3096         (WebCore::JSAttr::setValue):
3097         * bindings/js/JSCSSRuleCustom.cpp:
3098         (WebCore::toJS):
3099         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
3100         (WebCore::JSCSSStyleDeclaration::nameGetter):
3101         (WebCore::JSCSSStyleDeclaration::customPut):
3102         * bindings/js/JSCSSValueCustom.cpp:
3103         (WebCore::toJS):
3104         * bindings/js/JSCanvasPixelArrayCustom.h:
3105         (WebCore::JSCanvasPixelArray::getByIndex):
3106         (WebCore::JSCanvasPixelArray::indexSetter):
3107         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3108         (WebCore::toJS):
3109         (WebCore::toHTMLCanvasStyle):
3110         (WebCore::JSCanvasRenderingContext2D::strokeStyle):
3111         (WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
3112         (WebCore::JSCanvasRenderingContext2D::fillStyle):
3113         (WebCore::JSCanvasRenderingContext2D::setFillStyle):
3114         (WebCore::JSCanvasRenderingContext2D::setFillColor):
3115         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
3116         (WebCore::JSCanvasRenderingContext2D::strokeRect):
3117         (WebCore::JSCanvasRenderingContext2D::drawImage):
3118         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
3119         (WebCore::JSCanvasRenderingContext2D::setShadow):
3120         (WebCore::JSCanvasRenderingContext2D::createPattern):
3121         (WebCore::JSCanvasRenderingContext2D::putImageData):
3122         (WebCore::JSCanvasRenderingContext2D::fillText):
3123         (WebCore::JSCanvasRenderingContext2D::strokeText):
3124         * bindings/js/JSClipboardCustom.cpp:
3125         (WebCore::JSClipboard::types):
3126         (WebCore::JSClipboard::clearData):
3127         (WebCore::JSClipboard::getData):
3128         (WebCore::JSClipboard::setData):
3129         (WebCore::JSClipboard::setDragImage):
3130         * bindings/js/JSConsoleCustom.cpp:
3131         (WebCore::JSConsole::profiles):
3132         * bindings/js/JSCustomPositionCallback.cpp:
3133         (WebCore::JSCustomPositionCallback::handleEvent):
3134         * bindings/js/JSCustomPositionErrorCallback.cpp:
3135         (WebCore::JSCustomPositionErrorCallback::handleEvent):
3136         * bindings/js/JSCustomSQLStatementCallback.cpp:
3137         (WebCore::JSCustomSQLStatementCallback::handleEvent):
3138         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3139         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
3140         * bindings/js/JSCustomSQLTransactionCallback.cpp:
3141         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
3142         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
3143         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
3144         * bindings/js/JSCustomVoidCallback.cpp:
3145         (WebCore::JSCustomVoidCallback::handleEvent):
3146         (WebCore::toVoidCallback):
3147         * bindings/js/JSCustomVoidCallback.h:
3148         * bindings/js/JSCustomXPathNSResolver.cpp:
3149         (WebCore::JSCustomXPathNSResolver::create):
3150         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
3151         * bindings/js/JSCustomXPathNSResolver.h:
3152         * bindings/js/JSDOMApplicationCacheCustom.cpp:
3153         (WebCore::JSDOMApplicationCache::add):
3154         (WebCore::JSDOMApplicationCache::remove):
3155         (WebCore::JSDOMApplicationCache::addEventListener):
3156         (WebCore::JSDOMApplicationCache::removeEventListener):
3157         * bindings/js/JSDOMBinding.cpp:
3158         (WebCore::jsStringOrNull):
3159         (WebCore::jsOwnedStringOrNull):
3160         (WebCore::jsStringOrUndefined):
3161         (WebCore::jsStringOrFalse):
3162         (WebCore::valueToStringWithNullCheck):
3163         (WebCore::valueToStringWithUndefinedOrNullCheck):
3164         (WebCore::reportException):
3165         (WebCore::reportCurrentException):
3166         (WebCore::setDOMException):
3167         (WebCore::objectToStringFunctionGetter):
3168         * bindings/js/JSDOMBinding.h:
3169         (WebCore::getDOMObjectWrapper):
3170         (WebCore::getDOMNodeWrapper):
3171         (WebCore::toJS):
3172         * bindings/js/JSDOMGlobalObject.cpp:
3173         (WebCore::JSDOMGlobalObject::findJSEventListener):
3174         (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
3175         (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
3176         (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
3177         * bindings/js/JSDOMGlobalObject.h:
3178         * bindings/js/JSDOMWindowBase.cpp:
3179         (WebCore::createWindow):
3180         (WebCore::showModalDialog):
3181         (jsDOMWindowBaseCrypto):
3182         (jsDOMWindowBaseEvent):
3183         (jsDOMWindowBaseImage):
3184         (jsDOMWindowBaseMessageChannel):
3185         (jsDOMWindowBaseOption):
3186         (jsDOMWindowBaseXMLHttpRequest):
3187         (jsDOMWindowBaseAudio):
3188         (jsDOMWindowBaseWorker):
3189         (jsDOMWindowBaseXSLTProcessor):
3190         (setJSDOMWindowBaseEvent):
3191         (setJSDOMWindowBaseAudio):
3192         (setJSDOMWindowBaseImage):
3193         (setJSDOMWindowBaseMessageChannel):
3194         (setJSDOMWindowBaseOption):
3195         (setJSDOMWindowBaseWorker):
3196         (setJSDOMWindowBaseXMLHttpRequest):
3197         (setJSDOMWindowBaseXSLTProcessor):
3198         (WebCore::JSDOMWindowBase::childFrameGetter):
3199         (WebCore::JSDOMWindowBase::indexGetter):
3200         (WebCore::JSDOMWindowBase::namedItemGetter):
3201         (WebCore::JSDOMWindowBase::getOwnPropertySlot):
3202         (WebCore::JSDOMWindowBase::put):
3203         (WebCore::JSDOMWindowBase::clear):
3204         (windowProtoFuncOpen):
3205         (windowProtoFuncShowModalDialog):
3206         (windowProtoFuncNotImplemented):
3207         (WebCore::JSDOMWindowBase::setReturnValueSlot):
3208         (WebCore::JSDOMWindowBase::installTimeout):
3209         (WebCore::toJS):
3210         (WebCore::toJSDOMWindow):
3211         * bindings/js/JSDOMWindowBase.h:
3212         * bindings/js/JSDOMWindowCustom.cpp:
3213         (WebCore::JSDOMWindow::lookupGetter):
3214         (WebCore::JSDOMWindow::lookupSetter):
3215         (WebCore::JSDOMWindow::setLocation):
3216         (WebCore::JSDOMWindow::postMessage):
3217         (WebCore::setTimeoutOrInterval):
3218         (WebCore::JSDOMWindow::setTimeout):
3219         (WebCore::JSDOMWindow::clearTimeout):
3220         (WebCore::JSDOMWindow::setInterval):
3221         (WebCore::JSDOMWindow::clearInterval):
3222         (WebCore::JSDOMWindow::atob):
3223         (WebCore::JSDOMWindow::btoa):
3224         (WebCore::JSDOMWindow::addEventListener):
3225         (WebCore::JSDOMWindow::removeEventListener):
3226         (WebCore::toDOMWindow):
3227         (WebCore::nonCachingStaticCloseFunctionGetter):
3228         (WebCore::nonCachingStaticBlurFunctionGetter):
3229         (WebCore::nonCachingStaticFocusFunctionGetter):
3230         (WebCore::nonCachingStaticPostMessageFunctionGetter):
3231         * bindings/js/JSDOMWindowCustom.h:
3232         (WebCore::JSDOMWindow::customPut):
3233         * bindings/js/JSDOMWindowShell.cpp:
3234         (WebCore::JSDOMWindowShell::put):
3235         (WebCore::JSDOMWindowShell::putWithAttributes):
3236         (WebCore::JSDOMWindowShell::lookupGetter):
3237         (WebCore::JSDOMWindowShell::lookupSetter):
3238         (WebCore::toJS):
3239         * bindings/js/JSDOMWindowShell.h:
3240         (WebCore::JSDOMWindowShell::createStructure):
3241         * bindings/js/JSDatabaseCustom.cpp:
3242         (WebCore::JSDatabase::changeVersion):
3243         (WebCore::JSDatabase::transaction):
3244         * bindings/js/JSDocumentCustom.cpp:
3245         (WebCore::JSDocument::location):
3246         (WebCore::JSDocument::setLocation):
3247         (WebCore::toJS):
3248         * bindings/js/JSElementCustom.cpp:
3249         (WebCore::JSElement::setAttribute):
3250         (WebCore::JSElement::setAttributeNode):
3251         (WebCore::JSElement::setAttributeNS):
3252         (WebCore::JSElement::setAttributeNodeNS):
3253         (WebCore::toJSNewlyCreated):
3254         * bindings/js/JSEventCustom.cpp:
3255         (WebCore::JSEvent::clipboardData):
3256         (WebCore::toJS):
3257         * bindings/js/JSEventListener.cpp:
3258         (WebCore::JSAbstractEventListener::handleEvent):
3259         (WebCore::eventParameterName):
3260         (WebCore::JSLazyEventListener::parseCode):
3261         * bindings/js/JSEventTarget.cpp:
3262         (WebCore::toJS):
3263         * bindings/js/JSEventTarget.h:
3264         * bindings/js/JSEventTargetBase.h:
3265         * bindings/js/JSEventTargetNodeCustom.cpp:
3266         (WebCore::JSEventTargetNode::addEventListener):
3267         (WebCore::JSEventTargetNode::removeEventListener):
3268         * bindings/js/JSGeolocationCustom.cpp:
3269         (WebCore::createPositionOptions):
3270         (WebCore::JSGeolocation::getCurrentPosition):
3271         (WebCore::JSGeolocation::watchPosition):
3272         * bindings/js/JSHTMLAllCollection.h:
3273         (WebCore::JSHTMLAllCollection::createStructure):
3274         * bindings/js/JSHTMLAppletElementCustom.cpp:
3275         (WebCore::JSHTMLAppletElement::customPut):
3276         (WebCore::JSHTMLAppletElement::nameGetter):
3277         * bindings/js/JSHTMLCollectionCustom.cpp:
3278         (WebCore::getNamedItems):
3279         (WebCore::callHTMLCollection):
3280         (WebCore::JSHTMLCollection::nameGetter):
3281         (WebCore::JSHTMLCollection::item):
3282         (WebCore::JSHTMLCollection::namedItem):
3283         (WebCore::toJS):
3284         * bindings/js/JSHTMLDocumentCustom.cpp:
3285         (WebCore::JSHTMLDocument::nameGetter):
3286         (WebCore::JSHTMLDocument::all):
3287         (WebCore::JSHTMLDocument::setAll):
3288         (WebCore::JSHTMLDocument::open):
3289         (WebCore::JSHTMLDocument::write):
3290         (WebCore::JSHTMLDocument::writeln):
3291         * bindings/js/JSHTMLEmbedElementCustom.cpp:
3292         (WebCore::JSHTMLEmbedElement::customPut):
3293         (WebCore::JSHTMLEmbedElement::nameGetter):
3294         * bindings/js/JSHTMLFormElementCustom.cpp:
3295         (WebCore::JSHTMLFormElement::nameGetter):
3296         * bindings/js/JSHTMLFrameElementCustom.cpp:
3297         (WebCore::JSHTMLFrameElement::setSrc):
3298         (WebCore::JSHTMLFrameElement::setLocation):
3299         * bindings/js/JSHTMLFrameSetElementCustom.cpp:
3300         (WebCore::JSHTMLFrameSetElement::nameGetter):
3301         * bindings/js/JSHTMLIFrameElementCustom.cpp:
3302         (WebCore::JSHTMLIFrameElement::setSrc):
3303         * bindings/js/JSHTMLInputElementCustom.cpp:
3304         (WebCore::JSHTMLInputElement::selectionStart):
3305         (WebCore::JSHTMLInputElement::selectionEnd):
3306         * bindings/js/JSHTMLObjectElementCustom.cpp:
3307         (WebCore::JSHTMLObjectElement::customPut):
3308         (WebCore::JSHTMLObjectElement::nameGetter):
3309         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
3310         (WebCore::JSHTMLOptionsCollection::length):
3311         (WebCore::JSHTMLOptionsCollection::setLength):
3312         (WebCore::JSHTMLOptionsCollection::indexSetter):
3313         (WebCore::JSHTMLOptionsCollection::add):
3314         (WebCore::JSHTMLOptionsCollection::remove):
3315         * bindings/js/JSHTMLSelectElementCustom.cpp:
3316         (WebCore::JSHTMLSelectElement::remove):
3317         (WebCore::selectIndexSetter):
3318         (WebCore::JSHTMLSelectElement::indexSetter):
3319         * bindings/js/JSHTMLSelectElementCustom.h:
3320         * bindings/js/JSHistoryCustom.cpp:
3321         (WebCore::nonCachingStaticBackFunctionGetter):
3322         (WebCore::nonCachingStaticForwardFunctionGetter):
3323         (WebCore::nonCachingStaticGoFunctionGetter):
3324         (WebCore::JSHistory::customPut):
3325         * bindings/js/JSImageDataCustom.cpp:
3326         (WebCore::toJS):
3327         * bindings/js/JSInspectedObjectWrapper.cpp:
3328         (WebCore::JSInspectedObjectWrapper::wrap):
3329         (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
3330         * bindings/js/JSInspectedObjectWrapper.h:
3331         (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
3332         * bindings/js/JSInspectorCallbackWrapper.cpp:
3333         (WebCore::JSInspectorCallbackWrapper::wrap):
3334         (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
3335         * bindings/js/JSInspectorCallbackWrapper.h:
3336         (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
3337         * bindings/js/JSJavaScriptCallFrameCustom.cpp:
3338         (WebCore::JSJavaScriptCallFrame::evaluate):
3339         (WebCore::JSJavaScriptCallFrame::thisObject):
3340         (WebCore::JSJavaScriptCallFrame::type):
3341         (WebCore::JSJavaScriptCallFrame::scopeChain):
3342         * bindings/js/JSLocationCustom.cpp:
3343         (WebCore::nonCachingStaticReplaceFunctionGetter):
3344         (WebCore::nonCachingStaticReloadFunctionGetter):
3345         (WebCore::nonCachingStaticAssignFunctionGetter):
3346         (WebCore::JSLocation::customPut):
3347         (WebCore::JSLocation::setHref):
3348         (WebCore::JSLocation::setProtocol):
3349         (WebCore::JSLocation::setHost):
3350         (WebCore::JSLocation::setHostname):
3351         (WebCore::JSLocation::setPort):
3352         (WebCore::JSLocation::setPathname):
3353         (WebCore::JSLocation::setSearch):
3354         (WebCore::JSLocation::setHash):
3355         (WebCore::JSLocation::replace):
3356         (WebCore::JSLocation::reload):
3357         (WebCore::JSLocation::assign):
3358         (WebCore::JSLocation::toString):
3359         * bindings/js/JSMessageChannelConstructor.h:
3360         * bindings/js/JSMessagePortCustom.cpp:
3361         (WebCore::JSMessagePort::startConversation):
3362         (WebCore::JSMessagePort::addEventListener):
3363         (WebCore::JSMessagePort::removeEventListener):
3364         * bindings/js/JSMimeTypeArrayCustom.cpp:
3365         (WebCore::JSMimeTypeArray::nameGetter):
3366         * bindings/js/JSNamedNodeMapCustom.cpp:
3367         (WebCore::JSNamedNodeMap::nameGetter):
3368         * bindings/js/JSNamedNodesCollection.cpp:
3369         (WebCore::JSNamedNodesCollection::lengthGetter):
3370         (WebCore::JSNamedNodesCollection::indexGetter):
3371         * bindings/js/JSNamedNodesCollection.h:
3372         (WebCore::JSNamedNodesCollection::createStructure):
3373         * bindings/js/JSNavigatorCustom.cpp:
3374         (WebCore::needsYouTubeQuirk):
3375         (WebCore::JSNavigator::appVersion):
3376         * bindings/js/JSNodeCustom.cpp:
3377         (WebCore::JSNode::insertBefore):
3378         (WebCore::JSNode::replaceChild):
3379         (WebCore::JSNode::removeChild):
3380         (WebCore::JSNode::appendChild):
3381         (WebCore::createWrapper):
3382         (WebCore::toJSNewlyCreated):
3383         (WebCore::toJS):
3384         * bindings/js/JSNodeFilterCondition.cpp:
3385         (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
3386         (WebCore::JSNodeFilterCondition::acceptNode):
3387         * bindings/js/JSNodeFilterCondition.h:
3388         (WebCore::JSNodeFilterCondition::create):
3389         * bindings/js/JSNodeFilterCustom.cpp:
3390         (WebCore::JSNodeFilter::acceptNode):
3391         (WebCore::toNodeFilter):
3392         * bindings/js/JSNodeIteratorCustom.cpp:
3393         (WebCore::JSNodeIterator::nextNode):
3394         (WebCore::JSNodeIterator::previousNode):
3395         * bindings/js/JSNodeListCustom.cpp:
3396         (WebCore::callNodeList):
3397         (WebCore::JSNodeList::nameGetter):
3398         * bindings/js/JSPluginArrayCustom.cpp:
3399         (WebCore::JSPluginArray::nameGetter):
3400         * bindings/js/JSPluginCustom.cpp:
3401         (WebCore::JSPlugin::nameGetter):
3402         * bindings/js/JSPluginElementFunctions.cpp:
3403         (WebCore::runtimeObjectGetter):
3404         (WebCore::runtimeObjectPropertyGetter):
3405         (WebCore::runtimeObjectCustomPut):
3406         (WebCore::callPlugin):
3407         * bindings/js/JSPluginElementFunctions.h:
3408         * bindings/js/JSQuarantinedObjectWrapper.cpp:
3409         (WebCore::JSQuarantinedObjectWrapper::asWrapper):
3410         (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter):
3411         (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
3412         (WebCore::JSQuarantinedObjectWrapper::put):
3413         (WebCore::JSQuarantinedObjectWrapper::construct):
3414         (WebCore::JSQuarantinedObjectWrapper::hasInstance):
3415         (WebCore::JSQuarantinedObjectWrapper::call):
3416         * bindings/js/JSQuarantinedObjectWrapper.h:
3417         (WebCore::JSQuarantinedObjectWrapper::createStructure):
3418         * bindings/js/JSRGBColor.cpp:
3419         (WebCore::getJSRGBColor):
3420         (jsRGBColorRed):
3421         (jsRGBColorGreen):
3422         (jsRGBColorBlue):
3423         * bindings/js/JSRGBColor.h:
3424         (WebCore::JSRGBColor::createStructure):
3425         * bindings/js/JSSQLResultSetRowListCustom.cpp:
3426         (WebCore::JSSQLResultSetRowList::item):
3427         * bindings/js/JSSQLTransactionCustom.cpp:
3428         (WebCore::JSSQLTransaction::executeSql):
3429         * bindings/js/JSSVGElementInstanceCustom.cpp:
3430         (WebCore::JSSVGElementInstance::addEventListener):
3431         (WebCore::JSSVGElementInstance::removeEventListener):
3432         * bindings/js/JSSVGLengthCustom.cpp:
3433         (WebCore::JSSVGLength::value):
3434         (WebCore::JSSVGLength::convertToSpecifiedUnits):
3435         * bindings/js/JSSVGMatrixCustom.cpp:
3436         (WebCore::JSSVGMatrix::multiply):
3437         (WebCore::JSSVGMatrix::inverse):
3438         (WebCore::JSSVGMatrix::translate):
3439         (WebCore::JSSVGMatrix::scale):
3440         (WebCore::JSSVGMatrix::scaleNonUniform):
3441         (WebCore::JSSVGMatrix::rotate):
3442         (WebCore::JSSVGMatrix::rotateFromVector):
3443         (WebCore::JSSVGMatrix::flipX):
3444         (WebCore::JSSVGMatrix::flipY):
3445         (WebCore::JSSVGMatrix::skewX):
3446         (WebCore::JSSVGMatrix::skewY):
3447         * bindings/js/JSSVGPathSegCustom.cpp:
3448         (WebCore::toJS):
3449         * bindings/js/JSSVGPathSegListCustom.cpp:
3450         (WebCore::JSSVGPathSegList::clear):
3451         (WebCore::JSSVGPathSegList::initialize):
3452         (WebCore::JSSVGPathSegList::getItem):
3453         (WebCore::JSSVGPathSegList::insertItemBefore):
3454         (WebCore::JSSVGPathSegList::replaceItem):
3455         (WebCore::JSSVGPathSegList::removeItem):
3456         (WebCore::JSSVGPathSegList::appendItem):
3457         * bindings/js/JSSVGPointListCustom.cpp:
3458         (WebCore::finishGetter):
3459         (WebCore::finishSetter):
3460         (WebCore::finishSetterReadOnlyResult):
3461         (WebCore::JSSVGPointList::clear):
3462         (WebCore::JSSVGPointList::initialize):
3463         (WebCore::JSSVGPointList::getItem):
3464         (WebCore::JSSVGPointList::insertItemBefore):
3465         (WebCore::JSSVGPointList::replaceItem):
3466         (WebCore::JSSVGPointList::removeItem):
3467         (WebCore::JSSVGPointList::appendItem):
3468         * bindings/js/JSSVGTransformListCustom.cpp:
3469         (WebCore::finishGetter):
3470         (WebCore::finishSetter):
3471         (WebCore::finishSetterReadOnlyResult):
3472         (WebCore::JSSVGTransformList::clear):
3473         (WebCore::JSSVGTransformList::initialize):
3474         (WebCore::JSSVGTransformList::getItem):
3475         (WebCore::JSSVGTransformList::insertItemBefore):
3476         (WebCore::JSSVGTransformList::replaceItem):
3477         (WebCore::JSSVGTransformList::removeItem):
3478         (WebCore::JSSVGTransformList::appendItem):
3479         * bindings/js/JSStorageCustom.cpp:
3480         (WebCore::JSStorage::nameGetter):
3481         (WebCore::JSStorage::deleteProperty):
3482         (WebCore::JSStorage::customPut):
3483         * bindings/js/JSStyleSheetCustom.cpp:
3484         (WebCore::toJS):
3485         * bindings/js/JSStyleSheetListCustom.cpp:
3486         (WebCore::JSStyleSheetList::nameGetter):
3487         * bindings/js/JSTextCustom.cpp:
3488         (WebCore::toJSNewlyCreated):
3489         * bindings/js/JSTreeWalkerCustom.cpp:
3490         (WebCore::JSTreeWalker::parentNode):
3491         (WebCore::JSTreeWalker::firstChild):
3492         (WebCore::JSTreeWalker::lastChild):
3493         (WebCore::JSTreeWalker::nextSibling):
3494         (WebCore::JSTreeWalker::previousSibling):
3495         (WebCore::JSTreeWalker::previousNode):
3496         (WebCore::JSTreeWalker::nextNode):
3497         * bindings/js/JSWorkerContextBase.cpp:
3498         (WebCore::JSWorkerContextBase::put):
3499         * bindings/js/JSWorkerContextBase.h:
3500         * bindings/js/JSWorkerContextCustom.cpp:
3501         (WebCore::JSWorkerContext::self):
3502         (WebCore::JSWorkerContext::setSelf):
3503         (WebCore::JSWorkerContext::addEventListener):
3504         (WebCore::JSWorkerContext::removeEventListener):
3505         * bindings/js/JSWorkerCustom.cpp:
3506         (WebCore::JSWorker::addEventListener):
3507         (WebCore::JSWorker::removeEventListener):
3508         * bindings/js/JSXMLHttpRequestCustom.cpp:
3509         (WebCore::JSXMLHttpRequest::open):
3510         (WebCore::JSXMLHttpRequest::setRequestHeader):
3511         (WebCore::JSXMLHttpRequest::send):
3512         (WebCore::JSXMLHttpRequest::getResponseHeader):
3513         (WebCore::JSXMLHttpRequest::overrideMimeType):
3514         (WebCore::JSXMLHttpRequest::addEventListener):
3515         (WebCore::JSXMLHttpRequest::removeEventListener):
3516         (WebCore::JSXMLHttpRequest::responseText):
3517         * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
3518         (WebCore::JSXMLHttpRequestUpload::addEventListener):
3519         (WebCore::JSXMLHttpRequestUpload::removeEventListener):
3520         * bindings/js/JSXSLTProcessorCustom.cpp:
3521         (WebCore::JSXSLTProcessor::importStylesheet):
3522         (WebCore::JSXSLTProcessor::transformToFragment):
3523         (WebCore::JSXSLTProcessor::transformToDocument):
3524         (WebCore::JSXSLTProcessor::setParameter):
3525         (WebCore::JSXSLTProcessor::getParameter):
3526         (WebCore::JSXSLTProcessor::removeParameter):
3527         * bindings/js/ScheduledAction.cpp:
3528         (WebCore::ScheduledAction::ScheduledAction):
3529         (WebCore::ScheduledAction::execute):
3530         * bindings/js/ScheduledAction.h:
3531         * bindings/js/ScriptCallStack.cpp:
3532         (WebCore::ScriptCallStack::ScriptCallStack):
3533         (WebCore::ScriptCallStack::initialize):
3534         * bindings/js/ScriptController.cpp:
3535         (WebCore::ScriptController::createScriptObjectForPluginElement):
3536         * bindings/js/ScriptValue.cpp:
3537         (WebCore::ScriptValue::getString):
3538         (WebCore::ScriptValue::isNull):
3539         (WebCore::ScriptValue::isUndefined):
3540         * bindings/js/ScriptValue.h:
3541         (WebCore::ScriptValue::ScriptValue):
3542         (WebCore::ScriptValue::jsValue):
3543         * bindings/objc/WebScriptObject.mm:
3544         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3545         (-[WebScriptObject evaluateWebScript:]):
3546         (-[WebScriptObject valueForKey:]):
3547         (-[WebScriptObject webScriptValueAtIndex:]):
3548         (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
3549         * bindings/objc/WebScriptObjectPrivate.h:
3550         * bindings/scripts/CodeGeneratorJS.pm:
3551         * bridge/NP_jsobject.cpp:
3552         (_NPN_InvokeDefault):
3553         (_NPN_Invoke):
3554         (_NPN_Evaluate):
3555         (_NPN_GetProperty):
3556         (_NPN_HasMethod):
3557         (_NPN_Construct):
3558         * bridge/c/c_instance.cpp:
3559         (JSC::Bindings::CInstance::invokeMethod):
3560         (JSC::Bindings::CInstance::invokeDefaultMethod):
3561         (JSC::Bindings::CInstance::invokeConstruct):
3562         (JSC::Bindings::CInstance::defaultValue):
3563         (JSC::Bindings::CInstance::stringValue):
3564         (JSC::Bindings::CInstance::numberValue):
3565         (JSC::Bindings::CInstance::booleanValue):
3566         (JSC::Bindings::CInstance::valueOf):
3567         * bridge/c/c_instance.h:
3568         * bridge/c/c_runtime.cpp:
3569         (JSC::Bindings::CField::valueFromInstance):
3570         (JSC::Bindings::CField::setValueToInstance):
3571         * bridge/c/c_runtime.h:
3572         * bridge/c/c_utility.cpp:
3573         (JSC::Bindings::convertValueToNPVariant):
3574         (JSC::Bindings::convertNPVariantToValue):
3575         * bridge/c/c_utility.h:
3576         * bridge/jni/jni_instance.cpp:
3577         (JavaInstance::stringValue):
3578         (JavaInstance::numberValue):
3579         (JavaInstance::booleanValue):
3580         (JavaInstance::invokeMethod):
3581         (JavaInstance::defaultValue):
3582         (JavaInstance::valueOf):
3583         * bridge/jni/jni_instance.h:
3584         * bridge/jni/jni_jsobject.h:
3585         * bridge/jni/jni_jsobject.mm: