d51b6bbf209739e550d1ad14724b6abb5ddef13c
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
2
3         Reviewed by Darin.
4
5         Convert a bunch of RefPtr<StringImpl> to String.
6         
7         * bridge/mac/FrameMac.h:
8         * bridge/mac/FrameMac.mm:
9         (WebCore::FrameMac::didTellBridgeAboutLoad):
10         (WebCore::FrameMac::haveToldBridgeAboutLoad):
11         * dom/BeforeUnloadEvent.cpp:
12         (WebCore::BeforeUnloadEvent::storeResult):
13         * dom/BeforeUnloadEvent.h:
14         (WebCore::BeforeUnloadEvent::result):
15         * dom/Document.cpp:
16         (WebCore::Document::createEntityReference):
17         * dom/Entity.cpp:
18         (WebCore::Entity::Entity):
19         (WebCore::Entity::nodeName):
20         (WebCore::Entity::toString):
21         * dom/Entity.h:
22         (WebCore::Entity::publicId):
23         (WebCore::Entity::systemId):
24         (WebCore::Entity::notationName):
25         * dom/EntityReference.cpp:
26         (WebCore::EntityReference::EntityReference):
27         (WebCore::EntityReference::nodeName):
28         (WebCore::EntityReference::cloneNode):
29         (WebCore::EntityReference::toString):
30         * dom/EntityReference.h:
31         * dom/KeyboardEvent.cpp:
32         (WebCore::KeyboardEvent::KeyboardEvent):
33         (WebCore::KeyboardEvent::initKeyboardEvent):
34         * dom/KeyboardEvent.h:
35         (WebCore::KeyboardEvent::keyIdentifier):
36         * dom/MutationEvent.cpp:
37         (WebCore::MutationEvent::MutationEvent):
38         (WebCore::MutationEvent::initMutationEvent):
39         * dom/MutationEvent.h:
40         (WebCore::MutationEvent::prevValue):
41         (WebCore::MutationEvent::newValue):
42         (WebCore::MutationEvent::attrName):
43         * dom/Notation.cpp:
44         (WebCore::Notation::Notation):
45         (WebCore::Notation::nodeName):
46         * dom/Notation.h:
47         (WebCore::Notation::publicId):
48         (WebCore::Notation::systemId):
49         * dom/ProcessingInstruction.cpp:
50         (WebCore::ProcessingInstruction::ProcessingInstruction):
51         (WebCore::ProcessingInstruction::setData):
52         (WebCore::ProcessingInstruction::nodeName):
53         (WebCore::ProcessingInstruction::nodeValue):
54         (WebCore::ProcessingInstruction::cloneNode):
55         (WebCore::ProcessingInstruction::checkStyleSheet):
56         (WebCore::ProcessingInstruction::toString):
57         * dom/ProcessingInstruction.h:
58         (WebCore::ProcessingInstruction::target):
59         (WebCore::ProcessingInstruction::data):
60         (WebCore::ProcessingInstruction::localHref):
61
62 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
63
64         Reviewed by Tim H.
65
66         Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
67         10 more SVG Objective-C auto-generated bindings
68
69         - Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, 
70           DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement,
71           DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, 
72           DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
73
74         - Auto-generate the text method for DOMRange.
75
76         * DerivedSources.make:
77         * WebCore.xcodeproj/project.pbxproj:
78         * bindings/objc/DOM.mm:
79         * bindings/objc/DOMExtensions.h:
80         * bindings/objc/DOMInternal.h:
81         * bindings/objc/DOMPrivate.h:
82         * bindings/objc/DOMRGBColor.mm:
83         * bindings/objc/DOMSVG.h:
84         * bindings/objc/PublicDOMInterfaces.h:
85         * bindings/scripts/CodeGeneratorObjC.pm:
86         * dom/Range.idl:
87         * ksvg2/svg/SVGFilterElement.cpp:
88         * ksvg2/svg/SVGFilterElement.h:
89         * ksvg2/svg/SVGFilterElement.idl:
90         * ksvg2/svg/SVGForeignObjectElement.idl:
91         * ksvg2/svg/SVGGElement.idl:
92         * ksvg2/svg/SVGGradientElement.idl:
93         * ksvg2/svg/SVGImageElement.idl:
94         * ksvg2/svg/SVGLineElement.idl:
95         * ksvg2/svg/SVGLinearGradientElement.idl:
96         * ksvg2/svg/SVGMarkerElement.idl:
97         * ksvg2/svg/SVGMaskElement.idl:
98         * ksvg2/svg/SVGPaint.idl:
99
100 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
101
102         Reviewed by Tim H.
103
104         Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
105         Auto-generate a few more Objective-C DOM interfaces
106
107         - Fully auto-generate DOMAbstractView and DOMRange.
108
109         - Auto-generate just the interface for DOMRGBColor.
110
111         - Add DOMRanges.h as the new top level file for Ranges
112           module.
113
114         - Add DOMRanges.h and DOMXPath.h to DOM.mm
115
116         * DerivedSources.make:
117         * WebCore.xcodeproj/project.pbxproj:
118         * bindings/objc/DOM.h:
119         * bindings/objc/DOM.mm:
120         * bindings/objc/DOMAbstractView.h: Removed.
121         * bindings/objc/DOMAbstractView.mm: Removed.
122         * bindings/objc/DOMInternal.h:
123         * bindings/objc/DOMPrivate.h:
124         * bindings/objc/DOMRGBColor.h: Removed.
125         * bindings/objc/DOMRGBColor.mm:
126         * bindings/objc/DOMRange.h: Removed.
127         * bindings/objc/DOMRanges.h: Added.
128         * bindings/objc/PublicDOMInterfaces.h:
129         * bindings/scripts/CodeGeneratorObjC.pm:
130         * css/RGBColor.idl:
131         * dom/Range.idl:
132         * page/AbstractView.idl: Added.
133
134 2006-10-07  Andrew Wellington  <proton@wiretapped.net>
135
136         Reviewed by Eric.
137
138         Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
139         http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
140
141         Return null when there is no frame. This matches Firefox.
142
143         * bindings/js/kjs_html.cpp:
144         (KJS::JSHTMLDocument::getValueProperty):
145
146 2006-10-07  David Hyatt  <hyatt@apple.com>
147
148         Implement scroll corner painting (a white rect fill) for overflow areas to cover up
149         scrollbar joins properly.
150
151         Refactor painting of scrollbars and resizers into common functions.  Eliminate the
152         extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
153
154         Reviewed by mitz
155
156         * page/FrameView.cpp:
157         (WebCore::selectCursor):
158         (WebCore::FrameView::handleMouseMoveEvent):
159         * platform/mac/PlatformScrollBar.h:
160         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
161         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
162         * rendering/RenderLayer.cpp:
163         (WebCore::RenderLayer::RenderLayer):
164         (WebCore::RenderLayer::~RenderLayer):
165         (WebCore::RenderLayer::updateLayerPositions):
166         (WebCore::scrollCornerRect):
167         (WebCore::RenderLayer::positionOverflowControls):
168         (WebCore::RenderLayer::paintOverflowControls):
169         (WebCore::RenderLayer::isPointInResizeControl):
170         (WebCore::RenderLayer::paintLayer):
171         * rendering/RenderLayer.h:
172
173 2006-10-07  Mark Rowe  <bdash@webkit.org>
174
175         Reviewed by Mitz.
176
177         Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
178         matching recent ResourceLoader changes.
179
180         * platform/gdk/FrameGdk.cpp:
181         (WebCore::FrameGdk::openURL):
182         (WebCore::FrameGdk::urlSelected):
183         * platform/gdk/PlatformScrollBar.h:
184         * platform/gdk/ResourceLoaderCurl.cpp:
185         (WebCore::ResourceLoader::start):
186         * platform/gdk/ScrollViewGdk.cpp:
187         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
188         (WebCore::ScrollView::resizeContents):
189         (WebCore::ScrollView::scrollBy):
190         (WebCore::ScrollView::hScrollbarMode):
191         (WebCore::ScrollView::vScrollbarMode):
192         (WebCore::ScrollView::suppressScrollbars):
193         (WebCore::ScrollView::setHScrollbarMode):
194         (WebCore::ScrollView::setVScrollbarMode):
195         (WebCore::ScrollView::setScrollbarsMode):
196         * platform/gdk/TemporaryLinkStubs.cpp:
197         (FrameView::passMousePressEventToScrollbar):
198         (Widget::removeFromParent):
199         (ScrollView::addChild):
200         (ScrollView::updateScrollbars):
201         (ScrollView::scrollbarUnderMouse):
202         (PlatformScrollbar::PlatformScrollbar):
203         (PlatformScrollbar::~PlatformScrollbar):
204         (PlatformScrollbar::width):
205         (PlatformScrollbar::height):
206         (PlatformScrollbar::setEnabled):
207         (PlatformScrollbar::paint):
208         (PlatformScrollbar::updateThumbPosition):
209         (PlatformScrollbar::updateThumbProportion):
210         (PlatformScrollbar::setRect):
211         (Scrollbar::Scrollbar):
212         (Scrollbar::setSteps):
213         (Scrollbar::scroll):
214         (Scrollbar::setValue):
215         (Scrollbar::setProportion):
216
217 2006-10-06  Dave Hyatt  <hyatt@apple.com>
218
219         Implement a new method for obtaining accurate clip rectangles that can be used by plugins to properly clip.
220
221         * page/FrameView.cpp:
222         (WebCore::FrameView::windowClipRect):
223         * page/FrameView.h:
224         * platform/ScrollView.h:
225         * platform/Widget.cpp:
226         (WebCore::Widget::windowClipRect):
227         * platform/Widget.h:
228         (WebCore::Widget::geometryChanged):
229         (WebCore::Widget::handleMouseMoveEvent):
230         (WebCore::Widget::handleMouseReleaseEvent):
231         * platform/mac/ScrollViewMac.mm:
232         (WebCore::ScrollView::addChild):
233         * rendering/RenderLayer.cpp:
234         (WebCore::RenderLayer::documentClipRect):
235         * rendering/RenderLayer.h:
236
237 2006-10-06  Steve Falkenburg  <sfalken@apple.com>
238
239         Reviewed by Adam.
240
241         Add another method we'll need for scrollbar dodging
242
243         * platform/ScrollView.h:
244         * platform/win/TemporaryLinkStubs.cpp:
245         (ScrollView::resizerOverlapsContent):
246
247 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
248
249         Reviewed by Tim H.
250
251         Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
252         Auto-generate the interfaces even for Objective-C DOM 
253         bindings that need custom implementations
254
255         - Fully auto-generate DOMEventTarget, DOMNodeFilter and 
256           DOMHTMLOptionElement.
257
258         - Auto-generate just the interface for DOMHTMLAppletElement,
259           DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect
260           using the new IDL property ObjCCustomImplementation.
261
262         * DerivedSources.make:
263         * WebCore.xcodeproj/project.pbxproj:
264         * bindings/objc/DOMEventTarget.h: Removed.
265         * bindings/objc/DOMHTMLAppletElement.h: Removed.
266         * bindings/objc/DOMHTMLEmbedElement.h: Removed.
267         * bindings/objc/DOMHTMLOptionElement.h: Removed.
268         * bindings/objc/DOMHTMLOptionElement.mm: Removed.
269         * bindings/objc/DOMInternal.h:
270         * bindings/objc/DOMNodeFilter.h: Removed.
271         * bindings/objc/DOMSVGNumber.h: Removed.
272         * bindings/objc/DOMSVGPoint.h: Removed.
273         * bindings/objc/DOMSVGPoint.mm:
274         (-[DOMSVGPoint matrixTransform:]):
275         * bindings/objc/DOMSVGRect.h: Removed.
276         * bindings/objc/PublicDOMInterfaces.h:
277         * bindings/scripts/CodeGeneratorObjC.pm:
278         * dom/EventTarget.idl:
279         * html/HTMLAppletElement.idl:
280         * html/HTMLEmbedElement.idl:
281         * html/HTMLOptionElement.idl:
282         * ksvg2/svg/SVGNumber.idl:
283         * ksvg2/svg/SVGPoint.idl:
284         * ksvg2/svg/SVGRect.idl:
285
286 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
287
288         Reviewed by Tim H.
289
290         Make Qt/Linux compile again completly.
291
292         * platform/qt/WidgetQt.cpp:
293         (WebCore::Widget::removeFromParent):
294
295 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
296
297         Reviewed by Tim H.
298
299         Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.
300
301         * platform/qt/PlatformScrollBar.h:
302         * platform/qt/ScrollViewQt.cpp:
303         (WebCore::ScrollView::hScrollbarMode):
304         (WebCore::ScrollView::vScrollbarMode):
305         (WebCore::ScrollView::suppressScrollbars):
306         (WebCore::ScrollView::setHScrollbarMode):
307         (WebCore::ScrollView::setVScrollbarMode):
308         (WebCore::ScrollView::setScrollbarsMode):
309         (WebCore::ScrollView::scrollbarUnderMouse):
310         * platform/qt/TemporaryLinkStubs.cpp:
311         (WebCore::Scrollbar::Scrollbar):
312         (WebCore::Scrollbar::setSteps):
313         (WebCore::Scrollbar::scroll):
314         (WebCore::Scrollbar::setValue):
315         (WebCore::Scrollbar::setProportion):
316         (WebCore::PlatformScrollbar::PlatformScrollbar):
317         (WebCore::PlatformScrollbar::~PlatformScrollbar):
318         (WebCore::PlatformScrollbar::width):
319         (WebCore::PlatformScrollbar::height):
320         (WebCore::PlatformScrollbar::setEnabled):
321         (WebCore::PlatformScrollbar::paint):
322         (WebCore::PlatformScrollbar::updateThumbPosition):
323         (WebCore::PlatformScrollbar::updateThumbProportion):
324         (WebCore::PlatformScrollbar::setRect):
325         (FrameView::passMousePressEventToScrollbar):
326
327 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
328
329         Reviewed by Tim H.
330
331         Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
332         Another round of Objective-C SVG DOM bindings auto-generation
333
334         - Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect, 
335           DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement, 
336           DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement, 
337           DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement,
338           DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement, 
339           DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement, 
340           DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement, 
341           DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement, 
342           DOMSVGFEOffsetElement, DOMSVGFEPointLightElement, 
343           DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement, 
344           DOMSVGFETileElement, DOMSVGFETurbulenceElement, 
345           DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList. 
346
347         - Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint
348           and DOMSVGRect.
349
350         - IDL clean up.
351
352         - Make numOctaves in SVGFETurbulenceElement use a long instead of an int
353           in it's macro declaration and definition.
354
355         * DerivedSources.make:
356         * WebCore.xcodeproj/project.pbxproj:
357         * bindings/objc/DOMCSS.mm:
358         (+[DOMCSSValue _CSSValueWith:WebCore::]):
359         * bindings/objc/DOMInternal.h:
360         * bindings/objc/DOMSVG.h:
361         * bindings/objc/DOMSVGNumber.h: Added.
362         * bindings/objc/DOMSVGNumber.mm: Added.
363         (-[DOMSVGNumber dealloc]):
364         (-[DOMSVGNumber finalize]):
365         (-[DOMSVGNumber value]):
366         (-[DOMSVGNumber setValue:]):
367         (-[DOMSVGNumber _SVGNumber]):
368         (-[DOMSVGNumber _initWithFloat:]):
369         (+[DOMSVGNumber _SVGNumberWith:]):
370         * bindings/objc/DOMSVGPoint.h: Added.
371         * bindings/objc/DOMSVGPoint.mm: Added.
372         (-[DOMSVGPoint dealloc]):
373         (-[DOMSVGPoint finalize]):
374         (-[DOMSVGPoint x]):
375         (-[DOMSVGPoint setX:]):
376         (-[DOMSVGPoint y]):
377         (-[DOMSVGPoint setY:]):
378         (-[DOMSVGPoint WebCore::]):
379         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
380         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
381         * bindings/objc/DOMSVGRect.h: Added.
382         * bindings/objc/DOMSVGRect.mm: Added.
383         (-[DOMSVGRect dealloc]):
384         (-[DOMSVGRect finalize]):
385         (-[DOMSVGRect x]):
386         (-[DOMSVGRect setX:]):
387         (-[DOMSVGRect y]):
388         (-[DOMSVGRect setY:]):
389         (-[DOMSVGRect width]):
390         (-[DOMSVGRect setWidth:]):
391         (-[DOMSVGRect height]):
392         (-[DOMSVGRect setHeight:]):
393         (-[DOMSVGRect WebCore::]):
394         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
395         (+[DOMSVGRect _SVGRectWith:WebCore::]):
396         * bindings/scripts/CodeGeneratorObjC.pm:
397         * ksvg2/svg/SVGAnimatedNumberList.idl:
398         * ksvg2/svg/SVGAnimatedRect.idl:
399         * ksvg2/svg/SVGComponentTransferFunctionElement.idl:
400         * ksvg2/svg/SVGCursorElement.idl:
401         * ksvg2/svg/SVGFEBlendElement.idl:
402         * ksvg2/svg/SVGFEColorMatrixElement.idl:
403         * ksvg2/svg/SVGFEComponentTransferElement.idl:
404         * ksvg2/svg/SVGFECompositeElement.idl:
405         * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
406         * ksvg2/svg/SVGFEDisplacementMapElement.idl:
407         * ksvg2/svg/SVGFEDistantLightElement.idl:
408         * ksvg2/svg/SVGFEFloodElement.idl:
409         * ksvg2/svg/SVGFEFuncAElement.idl:
410         * ksvg2/svg/SVGFEFuncBElement.idl:
411         * ksvg2/svg/SVGFEFuncGElement.idl:
412         * ksvg2/svg/SVGFEFuncRElement.idl:
413         * ksvg2/svg/SVGFEGaussianBlurElement.idl:
414         * ksvg2/svg/SVGFEImageElement.idl:
415         * ksvg2/svg/SVGFEMergeElement.idl:
416         * ksvg2/svg/SVGFEMergeNodeElement.idl:
417         * ksvg2/svg/SVGFEOffsetElement.idl:
418         * ksvg2/svg/SVGFEPointLightElement.idl:
419         * ksvg2/svg/SVGFESpecularLightingElement.idl:
420         * ksvg2/svg/SVGFESpotLightElement.idl:
421         * ksvg2/svg/SVGFETileElement.idl:
422         * ksvg2/svg/SVGFETurbulenceElement.cpp:
423         * ksvg2/svg/SVGFETurbulenceElement.h:
424         * ksvg2/svg/SVGFETurbulenceElement.idl:
425         * ksvg2/svg/SVGNumberList.idl:
426
427 2006-10-06  Adam Roben  <aroben@apple.com>
428
429         Backing out my previous change.
430
431         * WebCore.xcodeproj/project.pbxproj:
432         * page/FrameView.cpp:
433         (WebCore::FrameView::adjustViewSize):
434
435 2006-10-06  Adam Roben  <aroben@apple.com>
436
437         Build fix.
438
439         * WebCore.xcodeproj/project.pbxproj:
440         * page/FrameView.cpp:
441         (WebCore::FrameView::windowResizerRect):
442
443 2006-10-06  Adam Roben  <aroben@apple.com>
444
445         Reviewed by Maciej.
446
447         More loader tweaks.
448
449         * platform/ResourceLoader.h:
450         * platform/ResourceLoaderInternal.h:
451         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
452         * platform/win/TemporaryLinkStubs.cpp:
453         (WebCore::ResourceLoader::newHTTPRequest):
454
455 2006-10-05  Steve Falkenburg  <sfalken@apple.com>
456
457         Reviewed by aroben.
458
459         Stub out some methods that we'll be able to use to dodge a window resizer.
460
461         * bridge/win/FrameWin.h:
462         * page/Frame.h:
463         (WebCore::Frame::windowResizerRect):
464         * page/FrameView.h:
465         * platform/ScrollView.h:
466         (WebCore::ScrollView::windowResizerRect):
467         * platform/Widget.h:
468         * platform/win/TemporaryLinkStubs.cpp:
469         (FrameView::windowResizerRect):
470         (Widget::setParent):
471         (Widget::parent):
472         (FrameWin::windowResizerRect):
473
474 2006-10-05  Dave Hyatt  <hyatt@apple.com>
475
476         Stub out setFrameGeometry.
477         
478         * platform/ScrollView.h:
479
480 2006-10-05  Adele Peterson  <adele@apple.com>
481
482         Reverting autoscroll fix.  I need to rework this a little.
483
484         * page/Frame.cpp:
485         (WebCore::Frame::handleAutoscroll):
486         (WebCore::Frame::autoscrollTimerFired):
487         (WebCore::Frame::stopAutoscrollTimer):
488         * page/Frame.h:
489         * rendering/RenderLayer.cpp:
490         (WebCore::RenderLayer::~RenderLayer):
491         * rendering/RenderListBox.cpp:
492         (WebCore::RenderListBox::~RenderListBox):
493
494 2006-10-05  Alice  <alice.liu@apple.com>
495
496         Reviewed by Adam.
497
498         Fixed <rdar://problem/4731778>
499
500         * editing/CommandByName.cpp:
501         (WebCore::Frame::Command::):
502         was calling the wrong enabledFn for arrow selection and navigation
503
504 2006-10-05  Adele Peterson  <adele@apple.com>
505
506         Reviewed by Maciej.
507
508         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text">
509           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
510
511         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
512         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
513
514         * page/Frame.cpp: Added getter and setter for the renderer being autoscrolled.
515         (WebCore::Frame::handleAutoscroll):
516         (WebCore::Frame::autoscrollTimerFired):
517         (WebCore::Frame::autoscrollRenderer):
518         (WebCore::Frame::setAutoscrollRenderer):
519         (WebCore::Frame::stopAutoscrollTimer):
520         * page/Frame.h:
521
522 2006-10-05  Don Gibson  <dgibson77@gmail.com>
523
524         Reviewed by Eric.
525
526         Fix win32 build bustage after ggaren's Scrollbar renaming changes.
527         Properly include PlatformScrollBar.h in WbCore.vcproj.
528         Clean up WidgetWin.cpp a bit.
529
530         * WebCore.vcproj/WebCore/WebCore.vcproj:
531         * platform/Widget.h:
532         * platform/win/PlatformScrollBar.h:
533         * platform/win/ScrollViewWin.cpp:
534         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
535         (WebCore::ScrollView::resizeContents):
536         (WebCore::ScrollView::scrollBy):
537         (WebCore::ScrollView::hScrollbarMode):
538         (WebCore::ScrollView::vScrollbarMode):
539         (WebCore::ScrollView::suppressScrollbars):
540         (WebCore::ScrollView::setHScrollbarMode):
541         (WebCore::ScrollView::setVScrollbarMode):
542         (WebCore::ScrollView::setScrollbarsMode):
543         (WebCore::ScrollView::updateScrollbars):
544         * platform/win/TemporaryLinkStubs.cpp:
545         (FrameView::passMousePressEventToScrollbar):
546         (Widget::removeFromParent):
547         (ScrollView::scrollbarUnderMouse):
548         (PlatformScrollbar::PlatformScrollbar):
549         (PlatformScrollbar::~PlatformScrollbar):
550         (PlatformScrollbar::width):
551         (PlatformScrollbar::height):
552         (PlatformScrollbar::setEnabled):
553         (PlatformScrollbar::paint):
554         (PlatformScrollbar::updateThumbPosition):
555         (PlatformScrollbar::updateThumbProportion):
556         (PlatformScrollbar::setRect):
557         (Scrollbar::Scrollbar):
558         (Scrollbar::setSteps):
559         (Scrollbar::scroll):
560         (Scrollbar::setValue):
561         (Scrollbar::setProportion):
562         * platform/win/WidgetWin.cpp:
563         (WebCore::WidgetPrivate::WidgetPrivate):
564         (WebCore::Widget::Widget):
565         (WebCore::Widget::setContainingWindow):
566         (WebCore::Widget::containingWindow):
567
568 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
569
570         build fix.
571         
572         * WebCore.xcodeproj/project.pbxproj:
573         * bridge/mac/BrowserExtensionMac.mm:
574         (WebCore::BrowserExtensionMac::createNewWindow):
575         * bridge/mac/FrameMac.mm:
576         (WebCore::FrameMac::createFrame):
577         * bridge/mac/FrameViewMac.mm:
578         (WebCore::FrameView::passMousePressEventToScrollbar):
579         * bridge/mac/WebCoreFrameBridge.mm:
580         (-[WebCoreFrameBridge installInFrame:]):
581         * bridge/mac/WebCoreFrameView.h:
582         * platform/ScrollBar.cpp:
583         * platform/Widget.h:
584         * platform/mac/PlatformScrollBar.h:
585         * platform/mac/PlatformScrollBarMac.mm:
586         (NSControlSizeForScrollBarControlSize):
587         (-[WebCoreScrollBar initWithPlatformScrollbar:]):
588         (-[WebCoreScrollBar detachPlatformScrollbar]):
589         (-[WebCoreScrollBar scroll:]):
590         (-[WebCoreScrollBar widget]):
591         (WebCore::PlatformScrollbar::PlatformScrollbar):
592         (WebCore::PlatformScrollbar::~PlatformScrollbar):
593         (WebCore::PlatformScrollbar::updateThumbPosition):
594         (WebCore::PlatformScrollbar::updateThumbProportion):
595         (WebCore::PlatformScrollbar::scrollbarHit):
596         (WebCore::PlatformScrollbar::width):
597         (WebCore::PlatformScrollbar::height):
598         (WebCore::PlatformScrollbar::setRect):
599         (WebCore::PlatformScrollbar::setEnabled):
600         (WebCore::PlatformScrollbar::paint):
601         * platform/mac/ScrollViewMac.mm:
602         (WebCore::ScrollView::setVScrollbarMode):
603         (WebCore::ScrollView::setHScrollbarMode):
604         (WebCore::ScrollView::setScrollbarsMode):
605         (WebCore::ScrollView::vScrollbarMode):
606         (WebCore::ScrollView::hScrollbarMode):
607         (WebCore::ScrollView::suppressScrollbars):
608         (WebCore::ScrollView::scrollbarUnderMouse):
609         * platform/mac/WidgetMac.mm:
610         (WebCore::Widget::removeFromParent):
611         * rendering/RenderLayer.cpp:
612         (WebCore::RenderLayer::destroyScrollbar):
613
614 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
615
616         build fix.
617         
618         * platform/Widget.h:
619         * rendering/RenderLayer.cpp:
620         (WebCore::RenderLayer::destroyScrollbar):
621
622 2006-10-06  Mitz Pettel  <mitz@webkit.org>
623
624         http://bugs.webkit.org/show_bug.cgi?id=8276
625         Fix broken manual test added back in r13990.
626
627         Add resource forks for test resources.
628
629         * manual-tests/resources/plain-text-paste/._1.textClipping: Added.
630         * manual-tests/resources/plain-text-paste/._2.textClipping: Added.
631         * manual-tests/resources/plain-text-paste/._4.txt: Added.
632         * manual-tests/resources/plain-text-paste/._5.webloc: Added.
633
634 2006-10-05  David Hyatt  <hyatt@apple.com>
635
636         Rename addClip to clip.
637
638         Reviewed by darin
639
640         * kcanvas/RenderForeignObject.cpp:
641         (WebCore::RenderForeignObject::paint):
642         * kcanvas/RenderSVGContainer.cpp:
643         (WebCore::RenderSVGContainer::paint):
644         * kcanvas/RenderSVGImage.cpp:
645         (WebCore::RenderSVGImage::paint):
646         * platform/GraphicsContext.h:
647         * platform/cairo/GraphicsContextCairo.cpp:
648         (WebCore::GraphicsContext::clip):
649         * platform/cg/GraphicsContextCG.cpp:
650         (WebCore::GraphicsContext::savePlatformState):
651         (WebCore::GraphicsContext::restorePlatformState):
652         (WebCore::GraphicsContext::clip):
653         (WebCore::GraphicsContext::addRoundedRectClip):
654         (WebCore::GraphicsContext::addInnerRoundedRectClip):
655         (WebCore::GraphicsContext::scale):
656         (WebCore::GraphicsContext::rotate):
657         (WebCore::GraphicsContext::translate):
658         (WebCore::GraphicsContext::concatCTM):
659         * platform/cg/GraphicsContextPlatformPrivate.h:
660         (WebCore::GraphicsContextPlatformPrivate::save):
661         (WebCore::GraphicsContextPlatformPrivate::restore):
662         (WebCore::GraphicsContextPlatformPrivate::clip):
663         (WebCore::GraphicsContextPlatformPrivate::scale):
664         (WebCore::GraphicsContextPlatformPrivate::rotate):
665         (WebCore::GraphicsContextPlatformPrivate::translate):
666         (WebCore::GraphicsContextPlatformPrivate::concatCTM):
667         * platform/qt/GraphicsContextQt.cpp:
668         (WebCore::GraphicsContext::clip):
669         (WebCore::GraphicsContext::addInnerRoundedRectClip):
670         (WebCore::GraphicsContext::addRoundedRectClip):
671         * rendering/InlineFlowBox.cpp:
672         (WebCore::InlineFlowBox::paintBackground):
673         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
674         * rendering/InlineTextBox.cpp:
675         (WebCore::InlineTextBox::paintSelection):
676         (WebCore::InlineTextBox::paintTextMatchMarker):
677         * rendering/RenderBox.cpp:
678         (WebCore::RenderBox::paintBackgroundExtended):
679         * rendering/RenderButton.cpp:
680         (WebCore::RenderButton::paintObject):
681         * rendering/RenderFileUploadControl.cpp:
682         (WebCore::RenderFileUploadControl::paintObject):
683         * rendering/RenderLayer.cpp:
684         (WebCore::RenderLayer::beginTransparencyLayers):
685         (WebCore::setClip):
686         * rendering/RenderListBox.cpp:
687         (WebCore::RenderListBox::paintObject):
688         * rendering/RenderMenuList.cpp:
689         (WebCore::RenderMenuList::paintObject):
690         * rendering/RenderTableCell.cpp:
691         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
692
693 2006-10-05  Mitz Pettel  <mitz@webkit.org>
694
695         Reviewed by Darin.
696
697         - http://bugs.webkit.org/show_bug.cgi?id=10386
698           Delete RenderImageButton.* and remove references from .vcproj and .bkl files
699
700         * CMakeLists.txt:
701         * WebCore.vcproj/WebCore/WebCore.vcproj:
702         * WebCoreSources.bkl:
703         * rendering/RenderImageButton.cpp: Removed.
704         * rendering/RenderImageButton.h: Removed.
705
706 2006-10-05  Mitz Pettel  <opendarwin.org@mitzpettel.com>
707
708         Reviewed by Darin.
709
710         - http://bugs.webkit.org/show_bug.cgi?id=11067
711           manual-tests/scrollbar-hittest2.html is invalid
712
713         * manual-tests/scrollbar-hittest2.html:
714
715 2006-10-05  David Carson  <dacarson@gmail.com>
716
717         Reviewed by Darin.
718
719         http://bugs.webkit.org/show_bug.cgi?id=11152
720         Adjust the tokenizer chunk size to be smaller for
721         mobile devices, and also decrease the yield timer
722         for the tokenizer so that it can resume earlier.
723
724         * html/HTMLTokenizer.cpp:
725         * config.h:
726
727 2006-10-05  Adam Roben  <aroben@apple.com>
728
729         Removing accidentally-checked-in do-nothing code.
730
731         * html/HTMLInputElement.cpp:
732         (WebCore::HTMLInputElement::defaultEventHandler):
733
734 2006-10-05  David Carson  <dacarson@gmail.com>
735
736         Reviewed by Mitz.
737
738         http://bugs.webkit.org/show_bug.cgi?id=11158
739         Initialize class variables
740
741         * rendering/RenderLayer.cpp:
742         (WebCore::RenderLayer::RenderLayer):
743
744 2006-10-05  Don Gibson  <dgibson77@gmail.com>
745
746         Reviewed by Darin, landed by Adam.
747
748         http://bugs.webkit.org/show_bug.cgi?id=11176
749         Fix win32 build, adapt to Maciej's ResourceLoader changes.
750
751         * platform/win/ResourceLoaderWin.cpp:
752         (WebCore::ResourceLoader::start):
753
754 2006-10-05  Marvin Decker  <marv.decker@gmail.com>
755
756         Reviewed by Darin.
757
758         http://bugs.webkit.org/show_bug.cgi?id=10989
759         Provide a way for embedders to implement BrowserExtensionWin
760
761         * WebCore.vcproj/WebCore/WebCore.vcproj:
762         * bridge/win/BrowserExtensionWin.cpp: Added.
763         (BrowserExtensionWin::BrowserExtensionWin):
764         (BrowserExtensionWin::setTypedIconURL):
765         (BrowserExtensionWin::setIconURL):
766         (BrowserExtensionWin::getHistoryLength):
767         (BrowserExtensionWin::canRunModal):
768         (BrowserExtensionWin::createNewWindow):
769         (BrowserExtensionWin::canRunModalNow):
770         (BrowserExtensionWin::runModal):
771         (BrowserExtensionWin::goBackOrForward):
772         (BrowserExtensionWin::historyURL):
773         * bridge/win/BrowserExtensionWin.h:
774         * bridge/win/FrameWin.cpp:
775         (WebCore::FrameWin::createNewWindow):
776         * bridge/win/FrameWin.h:
777         * platform/win/TemporaryLinkStubs.cpp:
778
779 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
780
781         Reviewed by Darin.
782         
783         Fixed <rdar://problem/4766987>
784         
785         - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
786         except for file names.
787         
788         - fixed RenderLayer to properly tear down scrollbars, removing them from
789         their parents.
790
791         * bindings/js/kjs_window.cpp:
792         (KJS::showModalDialog):
793         (KJS::setWindowFeature):
794         (KJS::parseWindowFeatures):
795         * bridge/BrowserExtension.h:
796         * dom/Document.cpp:
797         (WebCore::Document::setInPageCache):
798         * html/HTMLFrameElement.cpp:
799         (WebCore::HTMLFrameElement::init):
800         (WebCore::HTMLFrameElement::parseMappedAttribute):
801         * html/HTMLFrameElement.h:
802         (WebCore::HTMLFrameElement::scrollingMode):
803         * page/Frame.cpp:
804         (WebCore::Frame::finishedParsing):
805         (WebCore::Frame::scrollbarsVisible):
806         * page/FrameView.cpp:
807         (WebCore::FrameViewPrivate::FrameViewPrivate):
808         (WebCore::FrameViewPrivate::reset):
809         (WebCore::FrameView::~FrameView):
810         (WebCore::FrameView::resetScrollbars):
811         (WebCore::FrameView::clear):
812         (WebCore::FrameView::initScrollbars):
813         (WebCore::FrameView::applyOverflowToViewport):
814         (WebCore::FrameView::layout):
815         (WebCore::FrameView::handleMousePressEvent):
816         (WebCore::selectCursor):
817         (WebCore::FrameView::handleMouseMoveEvent):
818         (WebCore::FrameView::setScrollbarsMode):
819         (WebCore::FrameView::setVScrollbarMode):
820         (WebCore::FrameView::setHScrollbarMode):
821         (WebCore::FrameView::restoreScrollbar):
822         (WebCore::FrameView::dispatchMouseEvent):
823         (WebCore::FrameView::scrollbarMoved):
824         * page/FrameView.h:
825         * page/MouseEventWithHitTestResults.cpp:
826         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
827         * page/MouseEventWithHitTestResults.h:
828         (WebCore::MouseEventWithHitTestResults::scrollbar):
829         * platform/ScrollBar.cpp:
830         (WebCore::Scrollbar::Scrollbar):
831         (WebCore::Scrollbar::setValue):
832         (WebCore::Scrollbar::setProportion):
833         (WebCore::Scrollbar::setSteps):
834         (WebCore::Scrollbar::scroll):
835         * platform/ScrollBar.h:
836         (WebCore::):
837         (WebCore::ScrollbarClient::~ScrollbarClient):
838         (WebCore::Scrollbar::~Scrollbar):
839         (WebCore::Scrollbar::orientation):
840         (WebCore::Scrollbar::controlSize):
841         (WebCore::Scrollbar::hasPlatformScrollbars):
842         (WebCore::Scrollbar::client):
843         * platform/ScrollBarMode.h:
844         (WebCore::):
845         * platform/ScrollView.h:
846         * rendering/RenderBlock.cpp:
847         (WebCore::RenderBlock::isPointInScrollbar):
848         * rendering/RenderLayer.cpp:
849         (WebCore::RenderLayer::RenderLayer):
850         (WebCore::RenderLayer::~RenderLayer):
851         (WebCore::RenderLayer::scrollToOffset):
852         (WebCore::RenderLayer::horizontaScrollbarWidget):
853         (WebCore::RenderLayer::verticalScrollbarWidget):
854         (WebCore::RenderLayer::valueChanged):
855         (WebCore::RenderLayer::createScrollbar):
856         (WebCore::RenderLayer::destroyScrollbar):
857         (WebCore::RenderLayer::setHasHorizontalScrollbar):
858         (WebCore::RenderLayer::setHasVerticalScrollbar):
859         (WebCore::RenderLayer::verticalScrollbarWidth):
860         (WebCore::RenderLayer::horizontalScrollbarHeight):
861         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
862         * rendering/RenderLayer.h:
863         (WebCore::RenderLayer::horizontalScrollbar):
864         (WebCore::RenderLayer::verticalScrollbar):
865         * rendering/RenderListBox.cpp:
866         (WebCore::RenderListBox::~RenderListBox):
867         (WebCore::RenderListBox::calcMinMaxWidth):
868         (WebCore::RenderListBox::isPointInScrollbar):
869         (WebCore::RenderListBox::optionAtPoint):
870         (WebCore::RenderListBox::valueChanged):
871         * rendering/RenderListBox.h:
872         * rendering/RenderObject.h:
873         (WebCore::RenderObject::NodeInfo::scrollbar):
874         (WebCore::RenderObject::NodeInfo::setScrollbar):
875
876 2006-10-05  Don Gibson  <dgibson77@gmail.com>
877
878         Reviewed by Adam.
879
880         http://bugs.webkit.org/show_bug.cgi?id=11138
881         Incorrect mouse event generation on Windows
882
883         * platform/win/MouseEventWin.cpp:
884         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
885         (1) Set mouse button even for non-click-related messages.
886         (2) Track clicks correctly for all buttons, not just the left button.
887
888 2006-10-05  Nikolas Zimmermann  <zimmermann@kde.org>
889
890         Reviewed and landed by ap.
891
892         Fix Qt/Linux build, adapt to Eric's quartz changes and to Maciej's ResourceLoader changes.
893
894         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
895         (WebCore::KRenderingPaintServerLinearGradientQt::renderPath):
896         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
897         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
898         (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
899         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
900         (WebCore::KRenderingPaintServerPatternQt::renderPath):
901         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
902         (WebCore::KRenderingPaintServerQt::setPenProperties):
903         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
904         (WebCore::KRenderingPaintServerSolidQt::setup):
905         (WebCore::KRenderingPaintServerSolidQt::renderPath):
906         * kcanvas/device/qt/RenderPathQt.cpp:
907         (WebCore::getPathStroke):
908
909 2006-10-05  Alexey Proskuryakov  <ap@nypop.com>
910
911         Reviewed by Darin.
912
913         http://bugs.webkit.org/show_bug.cgi?id=11054
914         REGRESSION: Traditional Chinese encoding in login authentication
915
916         1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
917         2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding
918         for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
919
920         * platform/StreamingTextDecoderICU.cpp:
921         (WebCore::TextCodecICU::registerEncodingNames):
922
923 2006-10-05  Eric Seidel  <eric@eseidel.com>
924
925         Reviewed by mjs.
926
927         Removed dead code.
928         Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
929
930         * WebCore.xcodeproj/project.pbxproj:
931         * ksvg2/ecma/GlobalObject.cpp: Removed.
932         * ksvg2/ecma/GlobalObject.h: Removed.
933
934 2006-10-05  Adam Roben  <aroben@apple.com>
935
936         Reviewed by Maciej.
937
938         Small ResourceLoaderInternal tweak.
939
940         * platform/ResourceLoaderInternal.h:
941         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
942
943 2006-10-05  Eric Seidel  <eric@eseidel.com>
944
945         Reviewed by mjs.
946
947         More incremental KCanvas cleanup and optimization.
948         Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
949         Optimized dash array usage to not malloc.
950         Also removed un-needed KSVGRenderingStyle includes.
951
952         * kcanvas/KCanvasTreeDebug.cpp:
953         (WebCore::operator<<):
954         * kcanvas/RenderPath.cpp:
955         (WebCore::RenderPath::nodeAtPoint):
956         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
957         (WebCore::RenderPath::strokeBBox):
958         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
959         (WebCore::KRenderingPaintServerGradientQuartz::setup):
960         (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
961         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
962         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
963         (WebCore::KRenderingPaintServerSolidQuartz::setup):
964         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
965         (WebCore::KRenderingPaintServerPatternQuartz::setup):
966         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
967         * kcanvas/device/quartz/QuartzSupport.mm:
968         (WebCore::applyStrokeStyleToContext):
969         * ksvg2/css/SVGRenderStyle.h:
970         (WebCore::SVGRenderStyle::hasStroke):
971         (WebCore::SVGRenderStyle::hasFill):
972         * ksvg2/misc/KCanvasRenderingStyle.cpp:
973         (WebCore::KSVGPainterFactory::fillPaintServer):
974         (WebCore::KSVGPainterFactory::strokePaintServer):
975         * ksvg2/misc/KCanvasRenderingStyle.h:
976
977 2006-10-05  Maciej Stachowiak  <mjs@apple.com>
978
979         Reviewed by Adam.
980
981         - changed ResourceLoader to be refcounted
982
983         It keeps a ref on itself while loading as well. This makes
984         for a much saner memory management model than the previous.
985
986         * bridge/mac/WebCoreResourceLoaderImp.mm:
987         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
988         * dom/XMLTokenizer.cpp:
989         (WebCore::openFunc):
990         * loader/icon/IconLoader.cpp:
991         (IconLoader::IconLoader):
992         (IconLoader::~IconLoader):
993         (IconLoader::startLoading):
994         (IconLoader::stopLoading):
995         (IconLoader::receivedData):
996         * loader/icon/IconLoader.h:
997         * loader/loader.cpp:
998         (WebCore::Loader::servePendingRequests):
999         * platform/ResourceLoader.cpp:
1000         (WebCore::ResourceLoader::create):
1001         (WebCore::ResourceLoader::kill):
1002         * platform/ResourceLoader.h:
1003         * platform/ResourceLoaderInternal.h:
1004         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1005         * platform/mac/ResourceLoaderMac.mm:
1006         (WebCore::ResourceLoader::start):
1007         * xml/XSLTProcessor.cpp:
1008         (WebCore::docLoaderFunc):
1009         * xml/xmlhttprequest.cpp:
1010         (WebCore::XMLHttpRequest::send):
1011         * xml/xmlhttprequest.h:
1012
1013 2006-10-05  Eric Seidel  <eric@eseidel.com>
1014
1015         Reviewed by mjs.
1016
1017         Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
1018         http://bugs.webkit.org/show_bug.cgi?id=11163
1019         
1020         No SVG performance tests yet.
1021
1022         * kcanvas/RenderForeignObject.cpp:
1023         (WebCore::RenderForeignObject::paint):
1024         * kcanvas/RenderSVGContainer.cpp:
1025         (WebCore::RenderSVGContainer::paint):
1026         * kcanvas/RenderSVGImage.cpp:
1027         (WebCore::RenderSVGImage::paint):
1028         * kcanvas/RenderSVGText.cpp:
1029         (WebCore::RenderSVGText::paint):
1030
1031 2006-10-05  Dave Hyatt  <hyatt@apple.com>
1032
1033         Stub out some stuff for widget focusability.
1034
1035         Reviewed by maciej
1036  
1037         * page/FrameView.cpp:
1038         (WebCore::FrameView::dispatchMouseEvent):
1039         * platform/ScrollView.h:
1040         * platform/Widget.h:
1041
1042 2006-10-05  Adam Roben  <aroben@apple.com>
1043
1044         Reviewed by Maciej and Tim H.
1045
1046         Copy some WebKit frame lifetime logic into WebCore -- just a step
1047         along the path to frame lifetime being handled completely in WebCore.
1048
1049         * bridge/mac/FrameMac.mm:
1050         (WebCore::FrameMac::setView): Move platform-independent parts of this
1051         method into Frame.
1052         * page/Frame.cpp:
1053         (WebCore::Frame::setView): Adding platform-independent parts of
1054         FrameMac::setView
1055         (WebCore::Frame::detachChildren): New method to accomplish what
1056         -[WebFrameBridge _detachChildren] currently does.
1057         (WebCore::Frame::clear): Call detachChildren
1058         * page/Frame.h: Add declaration for detachChildren
1059
1060 2006-10-04  Alice Liu  <alice.liu@apple.com>
1061
1062         Reviewed by Darin.
1063
1064         Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query
1065
1066         * xml/xmlhttprequest.cpp:
1067         (WebCore::XMLHttpRequest::setRequestHeader):
1068         removed exception set when the request is not open yet
1069
1070 2006-10-04  Anders Carlsson  <acarlsson@apple.com>
1071
1072         Reviewed by John Sullivan.
1073
1074         <rdar://problem/4654328>
1075         Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
1076         
1077         * loader/PluginDocument.cpp:
1078         (WebCore::PluginTokenizer::writeRawData):
1079         Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
1080
1081 2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
1082
1083         Reviewed by Tim H.
1084
1085         http://bugs.webkit.org/show_bug.cgi?id=11130
1086         Convert "undefined" to AE missing value
1087
1088         * bridge/mac/WebCoreFrameBridge.mm:
1089         (aeDescFromJSValue): return missing value for UndefinedType.
1090
1091 2006-10-03  Dave Hyatt  <hyatt@apple.com>
1092
1093         Scrolling work.  Eliminate convertTo/FromContainingWindow as cross-platform functions.  Add back in
1094         the windowToContents/contentsToWindow functions.
1095         
1096         Reviewed by anders
1097
1098         * bridge/mac/FrameMac.mm:
1099         (WebCore::FrameMac::eventMayStartDrag):
1100         (WebCore::FrameMac::dragHysteresisExceeded):
1101         (WebCore::FrameMac::mouseDown):
1102         (WebCore::FrameMac::shouldDragAutoNode):
1103         (WebCore::FrameMac::sendContextMenuEvent):
1104         * bridge/mac/FrameViewMac.mm:
1105         (WebCore::FrameView::passMousePressEventToScrollbar):
1106         * bridge/mac/WebCoreFrameBridge.mm:
1107         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
1108         * dom/EventTargetNode.cpp:
1109         (WebCore::EventTargetNode::dispatchMouseEvent):
1110         (WebCore::EventTargetNode::dispatchWheelEvent):
1111         * page/Frame.cpp:
1112         (WebCore::Frame::selectClosestWordFromMouseEvent):
1113         (WebCore::Frame::handleMousePressEventTripleClick):
1114         (WebCore::Frame::handleMousePressEventSingleClick):
1115         (WebCore::Frame::handleMouseMoveEvent):
1116         (WebCore::Frame::handleMouseReleaseEvent):
1117         * page/FrameView.cpp:
1118         (WebCore::FrameView::handleMousePressEvent):
1119         (WebCore::FrameView::handleMouseDoubleClickEvent):
1120         (WebCore::selectCursor):
1121         (WebCore::FrameView::handleMouseMoveEvent):
1122         (WebCore::FrameView::handleMouseReleaseEvent):
1123         (WebCore::FrameView::dispatchDragEvent):
1124         (WebCore::FrameView::prepareMouseEvent):
1125         (WebCore::FrameView::handleWheelEvent):
1126         * page/FrameView.h:
1127         * platform/ScrollBar.cpp:
1128         (WebCore::ScrollBar::setValue):
1129         * platform/ScrollView.h:
1130         * platform/Widget.h:
1131         (WebCore::Widget::scrolled):
1132         * platform/mac/ScrollViewMac.mm:
1133         (WebCore::ScrollView::contentsToWindow):
1134         (WebCore::ScrollView::windowToContents):
1135         (WebCore::ScrollView::scrollbarUnderMouse):
1136         * platform/mac/WidgetMac.mm:
1137         * rendering/RenderLayer.cpp:
1138         (WebCore::RenderLayer::resize):
1139         (WebCore::RenderLayer::positionScrollbars):
1140         * rendering/RenderReplaced.cpp:
1141         (WebCore::RenderReplaced::shouldPaint):
1142         * rendering/RenderView.cpp:
1143         * rendering/RenderView.h:
1144         * rendering/RenderWidget.cpp:
1145         (WebCore::RenderWidget::setWidget):
1146
1147 2006-09-26  David Smith  <catfish.man@gmail.com>
1148
1149         Reviewed by Timothy.
1150
1151         http://bugs.webkit.org/show_bug.cgi?id=3723
1152         Add -scrollDOMRangeToVisible:
1153
1154         No automated tests are possible as this code path isn't reachable from JavaScript.
1155
1156         * bridge/mac/WebCoreFrameBridge.h:
1157         * bridge/mac/WebCoreFrameBridge.mm:
1158         (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
1159
1160 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
1161
1162         Reviewed by Timothy.
1163
1164         <http://bugs.webkit.org/show_bug.cgi?id=10338>
1165         When contentEditable, cursor doesn't change to hand
1166         
1167         Allow the behaviour of editable links to be specified by a WebPreference
1168         The preference WebKitEditableLinkBehavior has four options:
1169          - AlwaysLive: Safari 2.0 behaviour
1170          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
1171          - LiveWhenNotFocused: Editable links are live only when their editable block is not
1172              focused, or when the shift key is pressed
1173          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
1174          
1175         No layout tests, just a modification of a manual-test as it isn't possible to test
1176         this automatically.
1177
1178         * bridge/mac/WebCoreSettings.h:
1179         * bridge/mac/WebCoreSettings.mm:
1180         (-[WebCoreSettings setEditableLinkBehavior:]):
1181         (-[WebCoreSettings editableLinkBehavior]):
1182         * html/HTMLAnchorElement.cpp:
1183         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
1184         (WebCore::HTMLAnchorElement::defaultEventHandler):
1185         (WebCore::HTMLAnchorElement::setActive):
1186         * html/HTMLAnchorElement.h:
1187         * manual-tests/contenteditable-link.html:
1188         * page/FrameView.cpp:
1189         (WebCore::nodeIsNotBeingEdited):
1190         (WebCore::selectCursor):
1191         * page/Settings.h:
1192         (WebCore::Settings::):
1193         (WebCore::Settings::Settings):
1194         (WebCore::Settings::editableLinkBehavior):
1195         (WebCore::Settings::setEditableLinkBehavior):
1196
1197 2006-10-03  Beth Dakin  <bdakin@apple.com>
1198
1199         Reviewed Darin.
1200
1201         No test cases needed.
1202
1203         Implemented a version of StringImpl::append that takes a UChar* and 
1204         a length.
1205
1206         * platform/StringImpl.cpp:
1207         (WebCore::StringImpl::append):
1208         (WebCore::StringImpl::insert): Call new append instead of making a 
1209         new StringImpl.
1210         * platform/StringImpl.h:
1211
1212 2006-10-03  MorganL  <morganl.webkit@yahoo.com>
1213
1214         Reviewed by Darin.
1215
1216         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
1217         HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
1218
1219         * platform/win/ResourceLoaderWin.cpp:
1220         (WebCore::ResourceLoader::onHandleCreated):
1221
1222 2006-10-02  Geoffrey Garen  <ggaren@apple.com>
1223
1224         Feared, loathed, reviewed by Darin.
1225
1226         More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach 
1227         into FRAME, plus other cleanup.
1228         
1229         No new behavior, so no new test. Layout tests pass. Basic browsing and
1230         Mail editing seem to work.
1231         
1232         * dom/Node.cpp:
1233         (WebCore::Node::detach): Removed random commented-out code.
1234         * html/HTMLFrameElement.cpp:
1235         (WebCore::HTMLFrameElement::isURLAllowed): 
1236         (1) Removed reference to FrameView, to dissociate frame loading from rendering.
1237         (2) Renamed newURL to completeURL because the difference between newURL
1238         and URLString is that newURL is a KURL that is the complete version of URLString,
1239         not that it is new.
1240         (WebCore::HTMLFrameElement::willRemove): 
1241         (1) Removed close() call and moved close() code into willRemove(), also removing 
1242         close() call from detach(), since willRemove is the well-defined place 
1243         from DOM tear-down, not detach().
1244         (2) Removed manual renderer detach code because the DOM is not responsible
1245         for managing the render tree. I confirmed that this change not
1246         regress <rdar://problem/4132581>.
1247         (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
1248         lost their content frames after being removed from the DOM. That's our 
1249         current behavior, but it's going to change in future rounds of refactoring.
1250         This also fixes <rdar://problem/4750835>.
1251         (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
1252         attach/detach, because the render tree should not be in charge of deciding
1253         when to load.
1254         * html/HTMLFrameElement.h:
1255         * html/HTMLIFrameElement.cpp:
1256         (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
1257         because the renderer is a renderPartObject, not a renderPart.
1258         * html/HTMLIFrameElement.h:
1259
1260 2006-10-03  Mark Rowe  <bdash@webkit.org>
1261
1262         Reviewed by Mitz.
1263
1264         http://bugs.webkit.org/show_bug.cgi?id=11137
1265         Bug 11137: GdkLauncher dies with "pure virtual method called" if
1266         window is closed while page still loading
1267
1268         * platform/gdk/FrameGdk.cpp:
1269         (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
1270         methods to be called before the FrameGdk portion of "this" is torn down.
1271
1272 2006-10-03  Adam Roben  <aroben@apple.com>
1273
1274         Reviewed by Darin.
1275
1276         Handle tab key presses in the DOM.
1277
1278         * dom/EventTargetNode.cpp:
1279         (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
1280         * page/FrameView.cpp:
1281         (WebCore::FrameView::advanceFocus): Rename and reimplement
1282         focusNextPrevNode. Now we just call Element::focus().
1283         * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
1284         it public.
1285
1286 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
1287
1288         Reviewed by mjs
1289         
1290         <rdar://problem/4760612>
1291         TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
1292         
1293         No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
1294         
1295         * dom/Range.cpp:
1296         (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming 
1297         positions are non-null since most of it's callers would be in a bad state if the positions 
1298         were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.  
1299         Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it 
1300         from entering compareBoundaryPoints and hitting the assert.
1301
1302 2006-10-03  Adele Peterson  <adele@apple.com>
1303
1304         Reviewed by Geoff.
1305
1306         Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
1307
1308         * html/HTMLSelectElement.cpp:
1309         (WebCore::HTMLSelectElement::recalcStyle):
1310         (WebCore::HTMLSelectElement::isKeyboardFocusable):
1311         (WebCore::HTMLSelectElement::isMouseFocusable):
1312         (WebCore::HTMLSelectElement::createRenderer):
1313         (WebCore::HTMLSelectElement::setRecalcListItems):
1314         (WebCore::HTMLSelectElement::notifyOptionSelected):
1315         (WebCore::HTMLSelectElement::defaultEventHandler):
1316
1317 2006-10-04  Darin Adler  <darin@apple.com>
1318
1319         Reviewed by Geoff.
1320
1321         - fix http://bugs.webkit.org/show_bug.cgi?id=11132
1322           Caret disappears when you're typing
1323
1324         * editing/SelectionController.cpp:
1325         (WebCore::SelectionController::setSelection): Remove unnecessary call to
1326         clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
1327         (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
1328         to false so we can get the old caret repaint rect. Later we need to change the
1329         design so getting the rect doesn't have a side effect of causing a layout without
1330         invalidation.
1331
1332 2006-10-03  David Harrison  <harrison@apple.com>
1333
1334         Reviewed by Maciej.
1335
1336         <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
1337
1338         Updated test:
1339         * fast/text/justified-text-rect.html
1340
1341         * bridge/mac/WebCoreFrameBridge.mm:
1342         (-[WebCoreFrameBridge convertToNSRange:]):
1343         (-[WebCoreFrameBridge convertToDOMRange:]):
1344         Make the selection's root editable element (or the document itself) be
1345         the basis for NSRange conversions. This supports "shadow DOM" like
1346         that for text fields and text areas.
1347         
1348         * editing/CompositeEditCommand.cpp:
1349         (WebCore::CompositeEditCommand::moveParagraphs):
1350         Pass the document element as the scope.
1351         
1352         * editing/TextIterator.cpp:
1353         (WebCore::TextIterator::rangeFromLocationAndLength):
1354         Make the first parameter the scope.
1355         
1356         * editing/TextIterator.h:
1357         Make the first parameter of rangeFromLocationAndLength() the scope.
1358
1359 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
1360
1361         Reviewed by Eric.
1362
1363         Fix Qt/Linux build.
1364
1365         * CMakeLists.txt: Add counter related files.
1366
1367 2006-10-03  Mark Rowe  <bdash@webkit.org>
1368
1369         Reviewed by Eric.
1370
1371         http://bugs.webkit.org/show_bug.cgi?id=10981
1372         Linux/GDK build fixes
1373
1374         Based on a patch by Krzysztof Kowalczyk.
1375
1376         * WebCoreSources.bkl:
1377         * platform/gdk/FrameGdk.cpp:
1378         (WebCore::doScroll):
1379         (WebCore::FrameGdk::handleGdkEvent):
1380         * platform/gdk/PlatformScrollBar.h: Added.
1381         (WebCore::PlatformScrollBar::isWidget):
1382         * platform/gdk/ScrollViewGdk.cpp:
1383         * platform/gdk/TemporaryLinkStubs.cpp:
1384         (FrameView::passMousePressEventToScrollbar):
1385         (FrameView::passMousePressEventToSubframe):
1386         (FrameView::passMouseReleaseEventToSubframe):
1387         (FrameView::passMouseMoveEventToSubframe):
1388         (FrameView::passWheelEventToSubframe):
1389         (Cursor::Cursor):
1390         (Widget::invalidate):
1391         (Widget::invalidateRect):
1392         (ScrollView::wheelEvent):
1393         (ScrollView::convertToContainingWindow):
1394         (ScrollView::convertFromContainingWindow):
1395         (GraphicsContext::clip):
1396         (PlatformScrollBar::PlatformScrollBar):
1397         (PlatformScrollBar::updateThumbPosition):
1398         (PlatformScrollBar::updateThumbProportion):
1399         (ScrollBar::ScrollBar):
1400         (ScrollBar::setProportion):
1401         (WebCore::supportedKeySizes):
1402         (WebCore::signedPublicKeyAndChallengeString):
1403         * platform/gdk/WheelEventGdk.cpp:
1404         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1405         * platform/gdk/WidgetGdk.cpp:
1406         (WebCore::Widget::convertToContainingWindow):
1407         (WebCore::Widget::convertFromContainingWindow):
1408
1409 2006-10-02  Adam Roben  <aroben@apple.com>
1410
1411         Reviewed by Maciej.
1412
1413         Let Windows determine which mouse button is pressed.
1414
1415         * platform/PlatformMouseEvent.h: Add message parameter to constructor.
1416         * platform/win/MouseEventWin.cpp:
1417         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
1418         parameter to determine which mouse button is pressed.
1419
1420 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
1421
1422         Reviewed by anders
1423         
1424         Build fix
1425         
1426         * editing/SelectionController.cpp:
1427         (WebCore::SelectionController::empty):
1428         * editing/SelectionController.h:
1429
1430 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
1431
1432         Reviewed by john
1433         
1434         <rdar://problem/4755287>
1435         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
1436
1437         * editing/markup.cpp:
1438         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced 
1439         elements).  Don't skip blocks that aren't containers (like horizontal rules).
1440
1441 2006-10-03  Darin Adler  <darin@apple.com>
1442
1443         Reviewed by Justin Garcia.
1444
1445         - correct mistaken code that would restart blinking every
1446           time "invalidateSelection" is called even if the caret
1447           has not moved
1448
1449         * editing/SelectionController.h:
1450         * editing/SelectionController.cpp:
1451         (WebCore::SelectionController::setSelection): Update for name change.
1452         (WebCore::SelectionController::recomputeCaretRect): New function.
1453         Computes caret rect and does any necessary invalidation if the rect
1454         changes.
1455         (WebCore::SelectionController::invalidateCaretRect): Renamed from
1456         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
1457         calls recomputeCaretRect as a side effect.
1458
1459         * page/Frame.cpp:
1460         (WebCore::Frame::invalidateSelection): Remove unneeded call to
1461         clearCaretRectIfNeeded.
1462         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
1463         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
1464         recomputeCaretRect function and not restart blinking if caret has
1465         not changed position.
1466         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
1467         are not needed since selectionLayoutChanged already checks these.
1468
1469         * page/FramePrivate.h: Removed unused m_blinkCaret.
1470
1471 2006-10-02  Beth Dakin  <bdakin@apple.com>
1472
1473         Reviewed by Adam.
1474
1475         Build fix. Add counters to vcproj.
1476
1477         * WebCore.vcproj/WebCore/WebCore.vcproj:
1478
1479 2006-10-02  Brady Eidson  <beidson@apple.com>
1480
1481         Reviewed by Adele
1482
1483         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
1484         icon data out because we don't correctly check SQL error conditions.
1485
1486         * loader/icon/IconDataCache.cpp:
1487         (WebCore::IconDataCache::writeToDatabase):
1488
1489 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
1490
1491         Reviewed by Hyatt.
1492
1493         Added method to find out whether a layout has occurred.
1494
1495         * page/FrameView.cpp:
1496         (WebCore::FrameView::didFirstLayout):
1497         * page/FrameView.h:
1498
1499 2006-10-02  Beth Dakin  <bdakin@apple.com>
1500
1501         Reviewed by Darin.
1502
1503         Initial implementation of CSS2 counters. See http://
1504         bugs.webkit.org/show_bug.cgi?id=4980 for more details.
1505
1506         * WebCore.xcodeproj/project.pbxproj:
1507         * css/CSSComputedStyleDeclaration.cpp: 
1508         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 
1509         the increment/reset list now that this is implemented.
1510         * css/CSSPrimitiveValue.cpp:
1511         (WebCore::CSSPrimitiveValue::cssText): 
1512         * css/Counter.h:
1513         (WebCore::Counter::Counter):
1514         (WebCore::Counter::~Counter):
1515         (WebCore::Counter::identifier):
1516         (WebCore::Counter::listStyle):
1517         (WebCore::Counter::separator):
1518         (WebCore::Counter::listStyleNumber):
1519         (WebCore::Counter::setIdentifier):
1520         (WebCore::Counter::setListStyle):
1521         (WebCore::Counter::setSeparator):
1522         * css/cssparser.cpp:
1523         (WebCore::CSSParser::addProperty): Take care of reset/increment
1524         (WebCore::CSSParser::parseValue):
1525         (WebCore::CSSParser::parseContent): content can now take counters
1526         (WebCore::CSSParser::parseCounterContent): Parse counter() and 
1527         counters()
1528         (WebCore::CSSParser::parseCounter): Parse counter-reset and 
1529         counter-increment
1530         * css/cssparser.h:
1531         * css/cssstyleselector.cpp:
1532         (WebCore::CSSStyleSelector::matchUARules):
1533         (WebCore::CSSStyleSelector::applyProperty):
1534         * platform/PlatformString.h:
1535         * platform/String.cpp:
1536         (WebCore::String::insert): Implemented a version of insert that 
1537         accepts a UChar* and a length.
1538         * platform/StringImpl.cpp:
1539         (WebCore::StringImpl::insert): Same as above.
1540         * platform/StringImpl.h:
1541         * rendering/CounterListItem.h: Added.
1542         * rendering/CounterNode.cpp: Added.
1543         (WebCore::CounterNode::CounterNode):
1544         (WebCore::CounterNode::insertAfter):
1545         (WebCore::CounterNode::removeChild):
1546         (WebCore::CounterNode::remove):
1547         (WebCore::CounterNode::setUsesSeparator):
1548         (WebCore::CounterNode::recountAndGetNext):
1549         (WebCore::CounterNode::recountTree):
1550         (WebCore::CounterNode::setSelfDirty):
1551         (WebCore::CounterNode::setParentDirty):
1552         * rendering/CounterNode.h: Added.
1553         (WebCore::CounterNode::~CounterNode):
1554         (WebCore::CounterNode::parent):
1555         (WebCore::CounterNode::previousSibling):
1556         (WebCore::CounterNode::nextSibling):
1557         (WebCore::CounterNode::firstChild):
1558         (WebCore::CounterNode::lastChild):
1559         (WebCore::CounterNode::value):
1560         (WebCore::CounterNode::setValue):
1561         (WebCore::CounterNode::count):
1562         (WebCore::CounterNode::setCount):
1563         (WebCore::CounterNode::setHasSeparator):
1564         (WebCore::CounterNode::isReset):
1565         (WebCore::CounterNode::hasSeparator):
1566         (WebCore::CounterNode::willNeedLayout):
1567         (WebCore::CounterNode::setWillNeedLayout):
1568         (WebCore::CounterNode::isRoot):
1569         (WebCore::CounterNode::setRenderer):
1570         (WebCore::CounterNode::renderer):
1571         * rendering/CounterResetNode.cpp: Added.
1572         (WebCore::CounterResetNode::CounterResetNode):
1573         (WebCore::CounterResetNode::insertAfter):
1574         (WebCore::CounterResetNode::removeChild):
1575         (WebCore::CounterResetNode::recountAndGetNext):
1576         (WebCore::CounterResetNode::setParentDirty):
1577         (WebCore::CounterResetNode::updateTotal):
1578         * rendering/CounterResetNode.h: Added.
1579         (WebCore::CounterResetNode::firstChild):
1580         (WebCore::CounterResetNode::lastChild):
1581         (WebCore::CounterResetNode::isReset):
1582         (WebCore::CounterResetNode::total):
1583         * rendering/RenderContainer.cpp:
1584         (WebCore::RenderContainer::updatePseudoChildForObject): Account for 
1585         counter content.
1586         * rendering/RenderCounter.cpp: Added.
1587         (WebCore::RenderCounter::RenderCounter):
1588         (WebCore::RenderCounter::layout):
1589         (WebCore::toRoman):
1590         (WebCore::toLetterString):
1591         (WebCore::toHebrew):
1592         (WebCore::RenderCounter::convertValueToType):
1593         (WebCore::RenderCounter::calcMinMaxWidth):
1594         * rendering/RenderCounter.h: Added.
1595         (WebCore::RenderCounter::renderName):
1596         (WebCore::RenderCounter::isCounter):
1597         * rendering/RenderObject.cpp:
1598         (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to 
1599         maps of CounterNodes
1600         (WebCore::RenderObject::RenderObject):
1601         (WebCore::RenderObject::destroy): Destroy the maps.
1602         (WebCore::RenderObject::findCounter): Finds/creates counters.
1603         * rendering/RenderObject.h:
1604         (WebCore::RenderObject::isCounter):
1605         * rendering/RenderStyle.cpp:
1606         (WebCore::StyleVisualData::StyleVisualData):
1607         (WebCore::RenderStyle::arenaDelete):
1608         (WebCore::RenderStyle::RenderStyle):
1609         (WebCore::RenderStyle::diff):
1610         (WebCore::RenderStyle::setContent):
1611         (WebCore::ContentData::clearContent):
1612         (WebCore::RenderStyle::counterDataEquivalent):
1613         (WebCore::hasCounter):
1614         (WebCore::RenderStyle::hasCounterReset):
1615         (WebCore::RenderStyle::hasCounterIncrement):
1616         (WebCore::readCounter):
1617         (WebCore::RenderStyle::counterReset):
1618         (WebCore::RenderStyle::counterIncrement):
1619         * rendering/RenderStyle.h:
1620         (WebCore::StyleVisualData::operator==):
1621         (WebCore::CounterData::CounterData):
1622         (WebCore::CounterData::identifier):
1623         (WebCore::CounterData::listStyle):
1624         (WebCore::CounterData::separator):
1625         (WebCore::ContentData::contentCounter):
1626         (WebCore::ContentData::):
1627         (WebCore::RenderStyle::counterIncrement):
1628         (WebCore::RenderStyle::counterReset):
1629         (WebCore::RenderStyle::setCounterIncrement):
1630         (WebCore::RenderStyle::setCounterReset):
1631         (WebCore::RenderStyle::setCounterResetList):
1632         (WebCore::RenderStyle::setCounterIncrementList):
1633         (WebCore::RenderStyle::counterResetValueList):
1634         (WebCore::RenderStyle::counterIncrementValueList):
1635
1636 2006-10-02  Adele Peterson  <adele@apple.com>
1637
1638         Reviewed by Adam.
1639
1640         - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
1641
1642         There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
1643         by using "-webkit-appearance:none".
1644
1645         * css/html4.css:
1646
1647 2006-10-02  David Harrison  <harrison@apple.com>
1648
1649         Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
1650         addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
1651         Left the layout test.
1652         
1653         * rendering/bidi.cpp:
1654         (WebCore::checkMidpoints):
1655
1656 2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>
1657
1658         Reviewed by eseidel.  Landed by eseidel.
1659
1660         Fix Qt/Linux build.
1661
1662         * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
1663         (WebCore::supportedKeySizes):
1664
1665 2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>
1666
1667         Reviewed by eseidel & mjs.  Landed by eseidel.
1668
1669         Fix Qt/Linux build with older gcc 3.3.4.
1670         http://bugs.webkit.org/show_bug.cgi?id=11116
1671
1672         As discussed with Maciej, the GCC_ROOT_NS_HACK
1673         can be completely removed, as well as the friendship
1674         between cacheGlobalObject & the JS* objects.
1675
1676         * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
1677         * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
1678         (png_read_filter_row_mmx_avg):
1679         * platform/image-decoders/png/pngvcrd.c: Ditto.
1680         (png_mmx_support):
1681         (png_read_filter_row_mmx_avg):
1682
1683 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
1684
1685         Rubber stamped by Alexey.
1686
1687         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes
1688
1689         * css/CSSGrammar.y:
1690
1691 2006-10-01  Eric Seidel  <eric@webkit.org>
1692
1693         Reviewed by mjs.
1694
1695         Eliminate a few more hotspots in SVG drawing code.
1696         
1697         No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)
1698
1699         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1700         (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
1701         * platform/mac/ColorMac.mm:
1702         (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance
1703
1704 2006-10-01  Geoffrey Garen  <ggaren@apple.com>
1705
1706         Reviewed by Maciej.
1707         
1708         More frame/iframe merging.
1709         
1710         - Removed needWidgetUpdate and related code. needWidgetUpdate is always
1711         false, so this was dead code.
1712         - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
1713         than attach(), is the correct place for setInViewSourceMode, because
1714         openURL() is the function that creates our frame.
1715         - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
1716         code that did the same thing in other places.
1717         - Made FRAME's attach() method suffuciently generic so that IFRAME could
1718         call up to it, rather than skipping its superclass and calling up directly 
1719         to ELEMENT.
1720         - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
1721         - Replaced ad hoc frame loading code in FRAME::attach() with call to
1722         openURL(), the designated frame loading function.
1723
1724         Layout tests pass. I added a layout test for viewsource mode, since I
1725         broke it in the course of writing this patch.
1726
1727 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
1728
1729         Reviewed by Geoff.
1730
1731         * dom/Document.cpp:
1732         (WebCore::Document::recalcStyleSelector):
1733         * dom/Document.h:
1734         Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
1735         
1736         * dom/Node.h:
1737         Remove DeprecatedStringList class forward declaration.
1738         
1739         * editing/markup.cpp:
1740         Include DeprecatedStringList.h here since it's not included by Document.h anymore.
1741         
1742         * kcanvas/KCanvasTreeDebug.cpp:
1743         * kcanvas/KCanvasTreeDebug.h:
1744         Remove unused functions.
1745         
1746         * loader/loader.cpp:
1747         * page/Frame.cpp:
1748         * page/Frame.h:
1749         * page/FrameView.h:
1750         Fixup DeprecatedStringList.h includes.
1751
1752 2006-09-30  David Harrison  <harrison@apple.com>
1753
1754         Reviewed by John Sullivan.
1755
1756         <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
1757
1758         Problem was that the decision to trim was based only on whether the character
1759         is a soft hyphen, which caused pretty much any Japanese character to go.
1760         Changed to decide based on whether the character is ignorable whitespace.
1761         
1762         Test:
1763         * fast/text/international/wrap-CJK-001.html
1764
1765         * rendering/bidi.cpp:
1766         (WebCore::isTrimmableChar):
1767         New. Checks whether character is whitespace that can be ignored
1768         according to the text node's style.
1769         trimmed from the end of wrapped line.
1770         (WebCore::checkMidpoints):
1771         Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
1772
1773 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
1774
1775         Reviewed by Mitz Pettel.
1776
1777         Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
1778
1779         * ksvg2/svg/SVGColor.cpp:
1780         (WebCore::SVGColor::setRGBColor):
1781         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1782         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1783         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
1784         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1785         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
1786         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1787         (SVGFESpecularLightingElement::parseMappedAttribute):
1788         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1789         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
1790         * ksvg2/svg/SVGLengthList.cpp:
1791         * ksvg2/svg/SVGNumberList.cpp:
1792         (SVGNumberList::parse):
1793         * ksvg2/svg/SVGNumberList.h:
1794         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
1795         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
1796         * ksvg2/svg/SVGStringList.cpp:
1797         (WebCore::SVGStringList::reset):
1798         * ksvg2/svg/SVGStringList.h:
1799         * ksvg2/svg/SVGTransformable.cpp:
1800         (SVGTransformable::parseTransformAttribute):
1801
1802 2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>
1803
1804         Reviewed by Eric, tweaked and landed by ap.
1805
1806         Fix Qt/Linux build.
1807
1808         * CMakeLists.txt:
1809         * platform/qt/PlatformScrollBar.h:
1810         * platform/qt/TemporaryLinkStubs.cpp:
1811         (WebCore::ScrollBar::ScrollBar):
1812         (WebCore::PlatformScrollBar::PlatformScrollBar):
1813         (FrameView::passMousePressEventToSubframe):
1814         (FrameView::passMouseMoveEventToSubframe):
1815         (FrameView::passMouseReleaseEventToSubframe):
1816         (FrameView::passWheelEventToSubframe):
1817         (FrameView::passMousePressEventToScrollbar):
1818         * ksvg2/svg/SVGDocument.h:
1819
1820 2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>
1821
1822         Reviewed by Darin.
1823
1824         Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
1825         REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
1826
1827         No test case added (probably requires new DumpRenderTree functionality)
1828
1829         * rendering/RenderImage.cpp:
1830         (WebCore::RenderImage::imageChanged): Added early return if the document is
1831         being destroyed.
1832
1833 2006-10-01  Graham Dennis  <graham.dennis@gmail.com>
1834
1835         Reviewed by Hyatt.
1836
1837         Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
1838         REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
1839         
1840         Make sure we only break after a space (and not any other valid line-break) if
1841         the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
1842         I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
1843         twice in quick succession.
1844
1845         * rendering/bidi.cpp:
1846         (WebCore::RenderBlock::findNextLineBreak): 
1847
1848 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
1849
1850         Reviewed by Maciej and Darin.
1851
1852         http://bugs.webkit.org/show_bug.cgi?id=4372
1853         JavaScript document.write page form does not submit in Safari
1854
1855         Test: fast/forms/document-write.html
1856
1857         * page/Frame.cpp:
1858         (WebCore::Frame::submitForm): Don't check for parsing().
1859
1860 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
1861
1862         Build fix.
1863
1864         * bridge/mac/FrameViewMac.mm: Add missing #imports.
1865
1866 2006-10-01  Dave Hyatt  <hyatt@apple.com>
1867
1868         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
1869        
1870         Reviewed by mitz
1871
1872         * bridge/mac/FrameMac.mm:
1873         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
1874         * bridge/mac/FrameViewMac.mm:
1875         (WebCore::FrameView::passMousePressEventToScrollbar):
1876         * page/FrameView.cpp:
1877         (WebCore::FrameView::handleMousePressEvent):
1878         (WebCore::FrameView::setMousePressed):
1879         * page/FrameView.h:
1880         * platform/win/TemporaryLinkStubs.cpp:
1881         (FrameView::passMousePressEventToScrollbar):
1882
1883 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
1884
1885         Reviewed by Darin.
1886
1887         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
1888         Add more SVG Objective-C DOM bindings
1889
1890         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
1891           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
1892           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
1893           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
1894           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument, 
1895           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
1896
1897         * DerivedSources.make:
1898         * WebCore.xcodeproj/project.pbxproj:
1899         * bindings/objc/DOMInternal.h:
1900         * bindings/objc/DOMSVG.h:
1901         * bindings/scripts/CodeGeneratorObjC.pm:
1902         * ksvg2/svg/SVGAElement.idl:
1903         * ksvg2/svg/SVGAnimateColorElement.idl:
1904         * ksvg2/svg/SVGAnimateElement.idl:
1905         * ksvg2/svg/SVGAnimateTransformElement.idl:
1906         * ksvg2/svg/SVGAnimatedPathData.idl:
1907         * ksvg2/svg/SVGAnimatedPoints.idl:
1908         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
1909         * ksvg2/svg/SVGAnimationElement.idl:
1910         * ksvg2/svg/SVGCircleElement.idl:
1911         * ksvg2/svg/SVGClipPathElement.idl:
1912         * ksvg2/svg/SVGColor.idl:
1913         * ksvg2/svg/SVGCursorElement.idl:
1914         * ksvg2/svg/SVGDefsElement.idl:
1915         * ksvg2/svg/SVGDescElement.idl:
1916         * ksvg2/svg/SVGDocument.idl:
1917         * ksvg2/svg/SVGEllipseElement.idl:
1918         * ksvg2/svg/SVGPointList.idl:
1919         * ksvg2/svg/SVGPreserveAspectRatio.idl:
1920         * ksvg2/svg/SVGRect.idl:
1921         * ksvg2/svg/SVGSVGElement.idl:
1922
1923 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
1924
1925         Reviewed by Adele.
1926
1927         - fix build
1928
1929         * platform/FloatRect.h:
1930         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
1931         but more appropriate for path-type stuff.
1932         * platform/cg/PathCG.cpp:
1933         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
1934
1935 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
1936
1937         Reviewed by Darin.
1938
1939         http://bugs.webkit.org/show_bug.cgi?id=11011
1940         External CSS is parsed as iso-8859-1 even though the main document is utf-8
1941
1942         Test: fast/encoding/css-charset-default.xhtml
1943
1944         * loader/CachedResourceClient.h:
1945         (WebCore::CachedResourceClient::setCSSStyleSheet):
1946         (WebCore::CachedResourceClient::setXSLStyleSheet):
1947         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
1948         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
1949
1950         * css/CSSImportRule.cpp:
1951         (WebCore::CSSImportRule::setCSSStyleSheet):
1952         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
1953         * css/CSSImportRule.h:
1954
1955         * css/CSSStyleSheet.cpp:
1956         (WebCore::CSSStyleSheet::CSSStyleSheet):
1957         * css/CSSStyleSheet.h:
1958         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
1959         member. Changed some String parameters to const String&.
1960
1961         * css/StyleSheet.cpp:
1962         (WebCore::StyleSheet::StyleSheet):
1963         * css/StyleSheet.h:
1964         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
1965
1966         * css/StyleSheetList.cpp:
1967         (WebCore::StyleSheetList::length):
1968         (WebCore::StyleSheetList::item):
1969         * css/StyleSheetList.h:
1970         Special-casing implicit stylesheets seemed to be dead code, removed.
1971
1972         * dom/Document.cpp:
1973         (WebCore::Document::setCSSStyleSheet):
1974         (WebCore::Document::recalcStyleSelector):
1975         * dom/Document.h:
1976         Renamed setStyleSheet() to setCSSStyleSheet().
1977
1978         * dom/ProcessingInstruction.cpp:
1979         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
1980         (WebCore::ProcessingInstruction::setCSSStyleSheet):
1981         (WebCore::ProcessingInstruction::setXSLStyleSheet):
1982         (WebCore::ProcessingInstruction::parseStyleSheet):
1983         * dom/ProcessingInstruction.h:
1984
1985         * html/HTMLLinkElement.cpp:
1986         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute 
1987         is not specified.
1988         (WebCore::HTMLLinkElement::setCSSStyleSheet):
1989         * html/HTMLLinkElement.h:
1990
1991         * html/HTMLStyleElement.cpp:
1992         (WebCore::HTMLStyleElement::childrenChanged):
1993         * ksvg2/svg/SVGStyleElement.cpp:
1994         (WebCore::SVGStyleElement::childrenChanged):
1995         Inherit URL and charset from the document.
1996
1997         * loader/Cache.cpp:
1998         (WebCore::Cache::requestCSSStyleSheet):
1999         * loader/Cache.h:
2000         Adjust for setStyleSheet() renaming.
2001
2002         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
2003         * loader/CachedCSSStyleSheet.cpp:
2004         (WebCore::CachedCSSStyleSheet::ref):
2005         (WebCore::CachedCSSStyleSheet::deref):
2006         (WebCore::CachedCSSStyleSheet::checkNotify):
2007         Pass the encoding to setCSSStyleSheet().
2008
2009         * loader/CachedXSLStyleSheet.cpp:
2010         (WebCore::CachedXSLStyleSheet::ref):
2011         (WebCore::CachedXSLStyleSheet::checkNotify):
2012         * loader/DocLoader.cpp:
2013         (WebCore::DocLoader::requestCSSStyleSheet):
2014         * loader/DocLoader.h:
2015         * page/Frame.cpp:
2016         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
2017         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
2018         * xml/XSLImportRule.cpp:
2019         (WebCore::XSLImportRule::setXSLStyleSheet):
2020         (WebCore::XSLImportRule::loadSheet):
2021         * xml/XSLImportRule.h:
2022         Adjust for setStyleSheet() renaming.
2023
2024 2006-09-30  Rob Buis  <buis@kde.org>
2025
2026         Reviewed by eseidel.
2027
2028         http://bugs.webkit.org/show_bug.cgi?id=11096
2029         Hit testing for polylines fails
2030
2031         Fix Path::contains so it handles filled, non-closed paths too.
2032
2033         * platform/cg/PathCG.cpp:
2034         (WebCore::Path::contains):
2035
2036 2006-09-30  Dave Hyatt  <hyatt@apple.com>
2037
2038         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
2039         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
2040         subframes while the mouse is down.
2041       
2042         Reviewed by mitzpettel
2043
2044         * bridge/mac/FrameMac.h:
2045         * bridge/mac/FrameMac.mm:
2046         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
2047         (WebCore::FrameMac::passWheelEventToWidget):
2048         * bridge/mac/FrameViewMac.mm:
2049         (WebCore::FrameView::passMousePressEventToSubframe):
2050         (WebCore::FrameView::passMouseMoveEventToSubframe):
2051         (WebCore::FrameView::passMouseReleaseEventToSubframe):
2052         (WebCore::FrameView::passWheelEventToSubframe):
2053         * page/Frame.cpp:
2054         * page/Frame.h:
2055         * page/FrameView.cpp:
2056         (WebCore::subframeForTargetNode):
2057         (WebCore::FrameView::handleMousePressEvent):
2058         (WebCore::FrameView::handleMouseDoubleClickEvent):
2059         (WebCore::FrameView::handleMouseMoveEvent):
2060         (WebCore::FrameView::handleMouseReleaseEvent):
2061         (WebCore::FrameView::handleWheelEvent):
2062         * page/FrameView.h:
2063         * platform/ScrollBar.h:
2064         (WebCore::ScrollBar::handleMouseMoveEvent):
2065         (WebCore::ScrollBar::handleMouseOutEvent):
2066         * platform/Widget.h:
2067         (WebCore::Widget::handleMouseMoveEvent):
2068         (WebCore::Widget::handleMouseReleaseEvent):
2069         * platform/win/TemporaryLinkStubs.cpp:
2070         (FrameView::passMousePressEventToSubframe):
2071         (FrameView::passMouseMoveEventToSubframe):
2072         (FrameView::passMouseReleaseEventToSubframe):
2073         (FrameView::passWheelEventToSubframe):
2074         (Widget::capturingMouse):
2075         (Widget::setCapturingMouse):
2076         (Widget::capturingTarget):
2077         (Widget::capturingChild):
2078         (Widget::setCapturingChild):
2079         * rendering/RenderView.cpp:
2080         (WebCore::RenderView::paintBoxDecorations):
2081
2082 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
2083
2084         Reviewed by Adele.
2085
2086         Fixes windows bustage:
2087         http://bugs.webkit.org/show_bug.cgi?id=11093
2088
2089         * platform/win/PlatformScrollBar.h:
2090         * platform/win/TemporaryLinkStubs.cpp:
2091         (PlatformScrollBar::PlatformScrollBar):
2092         (ScrollBar::ScrollBar):
2093
2094 2006-09-29  David Hyatt  <hyatt@apple.com>
2095
2096         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
2097         in RenderObject::NodeInfo (and then propagating that Widget to
2098         MouseEventWithHitTestResults).
2099
2100         This allows RenderListBox and RenderBlock to do the same thing when the
2101         mouse is over the scrollbar.
2102
2103         Also land fix to support font-size: 0.
2104
2105         Reviewed by mjs (scrollbar), eric (font-size)
2106
2107         * dom/Document.cpp:
2108         (WebCore::Document::prepareMouseEvent):
2109         * page/Frame.cpp:
2110         (WebCore::Frame::passWidgetMouseDownEventToWidget):
2111         * page/FrameView.cpp:
2112         (WebCore::selectCursor):
2113         (WebCore::FrameView::handleMouseMoveEvent):
2114         (WebCore::FrameView::dispatchMouseEvent):
2115         * page/MouseEventWithHitTestResults.cpp:
2116         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2117         * page/MouseEventWithHitTestResults.h:
2118         (WebCore::MouseEventWithHitTestResults::scrollbar):
2119         * rendering/RenderBlock.cpp:
2120         (WebCore::RenderBlock::isPointInScrollbar):
2121         (WebCore::RenderBlock::nodeAtPoint):
2122         * rendering/RenderBlock.h:
2123         * rendering/RenderLayer.cpp:
2124         (WebCore::RenderLayer::hitTest):
2125         * rendering/RenderLayer.h:
2126         (WebCore::RenderLayer::getHiddenBehavior):
2127         * rendering/RenderListBox.cpp:
2128         (WebCore::RenderListBox::RenderListBox):
2129         (WebCore::RenderListBox::~RenderListBox):
2130         (WebCore::RenderListBox::isPointInScrollbar):
2131         * rendering/RenderListBox.h:
2132         * rendering/RenderObject.h:
2133         (WebCore::RenderObject::NodeInfo::NodeInfo):
2134         (WebCore::RenderObject::NodeInfo::scrollbar):
2135         (WebCore::RenderObject::NodeInfo::setScrollbar):
2136
2137 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
2138
2139         Reviewed by Adele.
2140
2141         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
2142
2143         * platform/win/ScrollViewWin.cpp:
2144         (WebCore::ScrollView::convertToContainingWindow):
2145         (WebCore::ScrollView::convertFromContainingWindow):
2146         * platform/win/WidgetWin.cpp:
2147         (WebCore::Widget::convertToContainingWindow):
2148         (WebCore::Widget::convertFromContainingWindow):
2149
2150 2006-09-29  Adele Peterson  <adele@apple.com>
2151
2152         Updated with new argument for PlatformScrollBar.
2153
2154         * platform/win/TemporaryLinkStubs.cpp:
2155         (PlatformScrollBar::PlatformScrollBar):
2156
2157 2006-09-29  Adele Peterson  <adele@apple.com>
2158
2159         Reviewed by Hyatt.
2160
2161         Fixing build bustage with cast to int.
2162
2163         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
2164
2165 2006-09-29  Adele Peterson  <adele@apple.com>
2166
2167         Fixing accidental include.
2168
2169         * rendering/RenderListBox.cpp:
2170
2171 2006-09-29  Adele Peterson  <adele@apple.com>
2172
2173         Adding RenderListBox files.
2174
2175         * WebCore.vcproj/WebCore/WebCore.vcproj:
2176
2177 2006-09-29  Adele Peterson  <adele@apple.com>
2178
2179         Reviewed by Adam.
2180
2181         Initial implementation of engine-based list box control.
2182
2183         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
2184
2185         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
2186         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
2187         (WebCore::FrameMac::FrameMac):
2188         (WebCore::FrameMac::handleMousePressEvent):
2189         (WebCore::FrameMac::handleMouseMoveEvent):
2190         (WebCore::FrameMac::mouseDown):
2191
2192         * page/Frame.cpp:
2193         (WebCore::Frame::handleMouseMoveEvent):
2194         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
2195         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
2196         (WebCore::Frame::autoscrollTimerFired): ditto.
2197         (WebCore::Frame::stopAutoscrollTimer): ditto.
2198         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
2199         * page/Frame.h:
2200         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
2201
2202         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
2203         (WebCore::FrameViewPrivate::reset):
2204         (WebCore::FrameView::currentMousePosition):
2205         (WebCore::FrameView::handleMousePressEvent):
2206         (WebCore::FrameView::handleMouseDoubleClickEvent):
2207         (WebCore::selectCursor):
2208         (WebCore::FrameView::handleMouseMoveEvent):
2209         (WebCore::FrameView::handleMouseReleaseEvent):
2210         * page/FrameView.h:
2211
2212         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
2213         * platform/ScrollBar.h:
2214         (WebCore::):
2215         (WebCore::ScrollBar::controlSize):
2216         * platform/mac/PlatformScrollBar.h:
2217         * platform/mac/PlatformScrollBarMac.mm:
2218         (NSControlSizeForScrollBarControlSize):
2219         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
2220         (WebCore::PlatformScrollBar::PlatformScrollBar):
2221
2222         * rendering/RenderBlock.h:
2223         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
2224         * rendering/RenderLayer.h:
2225         * rendering/RenderObject.cpp:
2226         (WebCore::RenderObject::shouldAutoscroll):
2227         (WebCore::RenderObject::autoscroll):
2228         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
2229
2230         * css/html4.css: Added properties for new list boxes.
2231
2232         * html/HTMLOptionElement.cpp:
2233         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
2234         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
2235         * html/HTMLOptionElement.h: Added disabled method.
2236
2237         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
2238         (WebCore::HTMLSelectElement::recalcStyle):
2239         (WebCore::HTMLSelectElement::lastSelectedListIndex):
2240         (WebCore::HTMLSelectElement::deselectItems):
2241         (WebCore::HTMLSelectElement::setSelectedIndex):
2242         (WebCore::HTMLSelectElement::isKeyboardFocusable):
2243         (WebCore::HTMLSelectElement::isMouseFocusable):
2244         (WebCore::HTMLSelectElement::createRenderer):
2245         (WebCore::HTMLSelectElement::recalcListItems):
2246         (WebCore::HTMLSelectElement::setRecalcListItems):
2247         (WebCore::HTMLSelectElement::reset):
2248         (WebCore::HTMLSelectElement::notifyOptionSelected):
2249         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
2250         (WebCore::HTMLSelectElement::nextSelectableListIndex):
2251         (WebCore::HTMLSelectElement::previousSelectableListIndex):
2252         * html/HTMLSelectElement.h:
2253
2254         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
2255         (WebCore::RenderTheme::paint):
2256         (WebCore::RenderTheme::paintBorderOnly):
2257         (WebCore::RenderTheme::paintDecorations):
2258         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
2259         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
2260         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
2261         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
2262         (WebCore::RenderTheme::isControlStyled):
2263         (WebCore::RenderTheme::supportsFocusRing):
2264         * rendering/RenderTheme.h:
2265         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
2266
2267         * rendering/RenderListBox.cpp: Added.
2268         (WebCore::RenderListBox::RenderListBox):
2269         (WebCore::RenderListBox::~RenderListBox):
2270         (WebCore::RenderListBox::setStyle):
2271         (WebCore::RenderListBox::updateFromElement):
2272         (WebCore::RenderListBox::calcMinMaxWidth):
2273         (WebCore::RenderListBox::size):
2274         (WebCore::RenderListBox::numItems):
2275         (WebCore::RenderListBox::calcHeight):
2276         (WebCore::RenderListBox::baselinePosition):
2277         (WebCore::RenderListBox::itemBoundingBoxRect):
2278         (WebCore::RenderListBox::paintObject):
2279         (WebCore::RenderListBox::paintScrollbar):
2280         (WebCore::RenderListBox::paintItemForeground):
2281         (WebCore::RenderListBox::paintItemBackground):
2282         (WebCore::RenderListBox::scrollBarTarget):
2283         (WebCore::RenderListBox::isPointInScrollbar):
2284         (WebCore::RenderListBox::optionAtPoint):
2285         (WebCore::RenderListBox::autoscroll):
2286         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
2287         (WebCore::RenderListBox::scroll):
2288         (WebCore::RenderListBox::valueChanged):
2289         * rendering/RenderListBox.h: Added.
2290         (WebCore::RenderListBox::isListBox):
2291         (WebCore::RenderListBox::selectionChanged):
2292         (WebCore::RenderListBox::setSelectionChanged):
2293         (WebCore::RenderListBox::canHaveChildren):
2294         (WebCore::RenderListBox::renderName):
2295         (WebCore::RenderListBox::setOptionsChanged):
2296         (WebCore::RenderListBox::shouldAutoscroll):
2297         (WebCore::RenderListBox::listIndexIsVisible):
2298
2299 2006-09-29  Beth Dakin  <bdakin@apple.com>
2300
2301         Reviewed by Darin.
2302
2303         We had a bug where html4.css was ignoring Media Queries. In the end 
2304         the problem was that we were trying to send a char* to the 
2305         MediaQueryEvaluator constructor that expects a String, but the 
2306         char* got interpreted as a bool, the wrong constructor was called, 
2307         and the media type was never set.
2308
2309         No test case possible since this only affects html4.css
2310
2311         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a 
2312         char*
2313         (WebCore::MediaQueryEvaluator):
2314         * css/MediaQueryEvaluator.h: Same.
2315
2316 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
2317
2318         Reviewed by John, Maciej.
2319         
2320         Integrated some frame and iframe code. I'm trying to fix up frame ownership
2321         and loading. Reducing the number of different code paths involved
2322         seemed like a good first step.
2323         
2324         As a side effect, I fixed a bug where FRAME elements would report their
2325         src attributes as relative, rather than compelete, URLs. (IFRAME elements
2326         had the correct complete URL behavior.)
2327
2328         * html/HTMLFrameElement.cpp:
2329         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
2330         (WebCore::HTMLFrameElement::openURL):
2331             (1) Removed checks that requestFrame does for us
2332             (2) Added isURLAllowed check, to have one clear bottleneck for it
2333             (3) Added viewsource check, to have one clear bottleneck for it
2334         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
2335         method, instead of finding our content frame in our own unique way.
2336         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
2337         since openURL does this for us now.
2338         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
2339         This is what FF does, and it made no sense to have different behaviors
2340         for FRAME and IFRAME elements.
2341         * html/HTMLIFrameElement.cpp:
2342         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
2343         code.
2344         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
2345         HTMLFrameElement now does everything we need.
2346
2347 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
2348
2349         Reviewed by Hyatt.
2350
2351         Fix Qt/Linux build.
2352
2353         * CMakeLists.txt:
2354         * platform/qt/ScrollViewQt.cpp:
2355         (WebCore::ScrollView::convertToContainingWindow):
2356         (WebCore::ScrollView::convertFromContainingWindow):
2357         * platform/qt/TemporaryLinkStubs.cpp:
2358         (WebCore::signedPublicKeyAndChallengeString):
2359         * platform/qt/WidgetQt.cpp:
2360         (WebCore::Widget::convertToContainingWindow):
2361         (WebCore::Widget::convertFromContainingWindow):
2362
2363 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
2364
2365         Reviewed by Tim H.
2366
2367         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
2368         Simplify Internal methods for the auto-generated Objective-C DOM code
2369
2370         - Auto-generate the internal methods for more Objective-C classes.
2371
2372         * WebCore.xcodeproj/project.pbxproj:
2373         * bindings/objc/DOM.mm:
2374         * bindings/objc/DOMCSS.mm:
2375         (-[DOMStyleSheet WebCore::]):
2376         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
2377         (-[DOMCSSRule WebCore::]):
2378         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
2379         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
2380         (-[DOMCSSValue WebCore::]):
2381         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
2382         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2383         * bindings/objc/DOMHTMLAppletElement.mm:
2384         (-[DOMHTMLAppletElement WebCore::]):
2385         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
2386         * bindings/objc/DOMHTMLEmbedElement.mm:
2387         (-[DOMHTMLEmbedElement WebCore::]):
2388         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
2389         * bindings/objc/DOMInternal.h:
2390         * bindings/objc/DOMInternal.mm:
2391         * bindings/scripts/CodeGeneratorObjC.pm:
2392         * css/CSSCharsetRule.idl:
2393         * css/CSSFontFaceRule.idl:
2394         * css/CSSImportRule.idl:
2395         * css/CSSMediaRule.idl:
2396         * css/CSSPageRule.idl:
2397         * css/CSSPrimitiveValue.idl:
2398         * css/CSSStyleRule.idl:
2399         * css/CSSStyleSheet.idl:
2400         * css/CSSUnknownRule.idl:
2401         * css/CSSValueList.idl:
2402         * dom/KeyboardEvent.idl:
2403         * dom/MouseEvent.idl:
2404         * dom/MutationEvent.idl:
2405         * dom/NodeIterator.idl:
2406         * dom/OverflowEvent.idl:
2407         * dom/UIEvent.idl:
2408         * dom/WheelEvent.idl:
2409
2410 2006-09-29  David Harrison  <harrison@apple.com>
2411
2412         Reviewed by John Sullivan.
2413
2414         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
2415         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
2416
2417         Test added
2418         * fast/text/attributed-substring-from-range-001.html
2419
2420         * bridge/mac/FrameMac.mm:
2421         (WebCore::FrameMac::attributedString):
2422         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
2423         Also, add validation of the range.
2424
2425 2006-09-29  Rob Buis  <buis@kde.org>
2426
2427         Reviewed by Maciej.
2428
2429         http://bugs.webkit.org/show_bug.cgi?id=10893
2430         InsertRule can not handle @import statements
2431
2432         Allow @import as part of a css rule.
2433
2434         * css/CSSGrammar.y:
2435
2436 2006-09-28  David Hyatt  <hyatt@apple.com>
2437
2438         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
2439
2440         * bridge/mac/FrameMac.mm:
2441         (WebCore::FrameMac::eventMayStartDrag):
2442         (WebCore::FrameMac::dragHysteresisExceeded):
2443         (WebCore::FrameMac::mouseDown):
2444         (WebCore::FrameMac::shouldDragAutoNode):
2445         (WebCore::FrameMac::sendContextMenuEvent):
2446         * bridge/mac/WebCoreFrameBridge.mm:
2447         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
2448
2449 2006-09-28  Dave Hyatt  <hyatt@apple.com>
2450
2451         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
2452         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
2453         view.
2454        
2455         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
2456         the patch after review, once I realized that these new functions essentially do the same thing.)
2457
2458         * dom/EventTargetNode.cpp:
2459         (WebCore::EventTargetNode::dispatchMouseEvent):
2460         (WebCore::EventTargetNode::dispatchWheelEvent):
2461         * page/Frame.cpp:
2462         (WebCore::Frame::selectClosestWordFromMouseEvent):
2463         (WebCore::Frame::handleMousePressEventTripleClick):
2464         (WebCore::Frame::handleMousePressEventSingleClick):
2465         (WebCore::Frame::handleMouseMoveEvent):
2466         (WebCore::Frame::handleMouseReleaseEvent):
2467         * page/FrameView.cpp:
2468         (WebCore::FrameView::handleMousePressEvent):
2469         (WebCore::selectCursor):
2470         (WebCore::FrameView::dispatchDragEvent):
2471         (WebCore::FrameView::prepareMouseEvent):
2472         (WebCore::FrameView::handleWheelEvent):
2473         * platform/ScrollView.h:
2474         * platform/Widget.cpp:
2475         (WebCore::Widget::convertToContainingWindow):
2476         * platform/Widget.h:
2477         * platform/mac/ScrollViewMac.mm:
2478         (WebCore::ScrollView::convertToContainingWindow):
2479         (WebCore::ScrollView::convertFromContainingWindow):
2480         * platform/mac/WidgetMac.mm:
2481         (WebCore::Widget::convertToContainingWindow):
2482         (WebCore::Widget::convertFromContainingWindow):
2483         * platform/win/ScrollViewWin.cpp:
2484         (WebCore::ScrollView::convertToContainingWindow):
2485         (WebCore::ScrollView::convertFromContainingWindow):
2486         * rendering/RenderLayer.cpp:
2487         (WebCore::RenderLayer::resize):
2488
2489 2006-09-28  Alice Liu  <alice.liu@apple.com>
2490
2491         Build fix by adding missing files for CommandByName
2492
2493         * WebCore.xcodeproj/project.pbxproj:
2494
2495 2006-09-28  Alice Liu  <alice.liu@apple.com>
2496
2497         Adding CommandByName files to the vcproj
2498
2499         * WebCore.vcproj/WebCore/WebCore.vcproj:
2500
2501 2006-09-28  Alice Liu  <alice.liu@apple.com>
2502
2503         Reviewed by Adam Roben.
2504
2505         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc. 
2506         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
2507         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
2508
2509         * editing/CommandByName.cpp: Added.
2510         Added a command class that hangs off the frame so the frame can call commands more easily.  
2511         (WebCore::Frame::commandImp):
2512         (WebCore::Frame::execCopy):
2513         (WebCore::Frame::execCut):
2514         (WebCore::Frame::execDelete):
2515         (WebCore::Frame::execForwardDelete):
2516         (WebCore::Frame::execPaste):
2517         (WebCore::Frame::execMoveLeft):
2518         (WebCore::Frame::execMoveRight):
2519         (WebCore::Frame::execMoveUp):
2520         (WebCore::Frame::execMoveDown):
2521         (WebCore::Frame::execSelectAll):
2522         (WebCore::Frame::execSelectLeft):
2523         (WebCore::Frame::execSelectRight):
2524         (WebCore::Frame::execSelectUp):
2525         (WebCore::Frame::execSelectDown):
2526         (WebCore::Frame::enabled):
2527         (WebCore::Frame::enabledAnySelection):
2528         (WebCore::Frame::enabledAnyEditableSelection):
2529         (WebCore::Frame::enabledPaste):
2530         (WebCore::Frame::enabledAnyRangeSelection):
2531         (WebCore::Frame::enabledAnyEditableRangeSelection):
2532         (WebCore::Frame::createCommandDictionary):
2533         (WebCore::Frame::Command::):
2534         (WebCore:::m_frame):
2535         (WebCore::CommandByName::execCommand):
2536         * editing/CommandByName.h: Added.
2537         * page/Frame.cpp:
2538         Added implementation of accessor for CommandByName member
2539         (WebCore::Frame::command):
2540         * page/Frame.h:
2541         Added accessor for CommandByName member
2542         * page/FramePrivate.h:
2543         Added a CommandByName member
2544         (WebCore::FramePrivate::FramePrivate):
2545         * platform/PlatformMouseEvent.h:
2546         Changed constructor prototype
2547         * platform/StringImpl.cpp:
2548         Exposing getWordBreakIterator to be used elsewhere
2549         (WebCore::getWordBreakIterator):
2550         * platform/StringImpl.h:
2551         Exposing getWordBreakIterator to be used elsewhere
2552         * platform/win/MouseEventWin.cpp:
2553         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
2554         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2555
2556 2006-09-28  Adam Roben  <aroben@apple.com>
2557
2558         Reviewed by Adele.
2559
2560         Remove no-longer-used PopUpButton.
2561
2562         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
2563         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
2564         PopUpButtonMac.mm
2565         * platform/PopUpButton.h: Removed.
2566         * platform/mac/PopUpButtonMac.mm: Removed.
2567         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
2568         * rendering/DeprecatedRenderSelect.cpp: Change #include of
2569         PopUpButton.h to ListBox.h
2570
2571 2006-09-28  Darin Adler  <darin@apple.com>
2572
2573         Reviewed by Alice.
2574
2575         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
2576           10% perf. regression (copying strings while decoding)
2577
2578         Use Vector<UChar> instead of String when building up the decoded string in
2579         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
2580         String grows the buffer every single time that append is called. Using
2581         Vector::append instead of String::append also avoids constructing a string
2582         each time just to append and a questionable copy that is done inside the
2583         String::append function which also contributed to the slowness.
2584
2585         * platform/PlatformString.h:
2586         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
2587         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
2588         allocation.
2589         * platform/StringImpl.h:
2590         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
2591
2592         * platform/StreamingTextDecoder.h:
2593         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
2594         Change to use a Vector<UChar> instead of a String, since vectors have better
2595         resizing performance (they store a separate capacity).
2596
2597         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
2598         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
2599         Change to use Vector<UChar> instead of String and then create a string at
2600         the end of the process using the new adopt function.
2601
2602 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
2603
2604         Reviewed by Tim H.
2605
2606         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
2607         Auto-generate more SVG Objective-C bindings
2608
2609         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean, 
2610           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
2611           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
2612           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
2613           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
2614           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests, 
2615           and DOMSVGTransformable.
2616
2617         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
2618           parent interfaces and the SVG animated classes.
2619
2620         - Corrects CodeGenerator.pm to only skip the first parent for the main 
2621           interface.
2622
2623         * DerivedSources.make:
2624         * WebCore.xcodeproj/project.pbxproj:
2625         * bindings/objc/DOMInternal.h:
2626         * bindings/objc/DOMSVG.h:
2627         * bindings/scripts/CodeGenerator.pm:
2628         * bindings/scripts/CodeGeneratorObjC.pm:
2629         * ksvg2/svg/SVGAnimatedAngle.idl:
2630         * ksvg2/svg/SVGAnimatedBoolean.idl:
2631         * ksvg2/svg/SVGAnimatedEnumeration.idl:
2632         * ksvg2/svg/SVGAnimatedInteger.idl:
2633         * ksvg2/svg/SVGAnimatedLength.idl:
2634         * ksvg2/svg/SVGAnimatedLengthList.idl:
2635         * ksvg2/svg/SVGAnimatedNumber.idl:
2636         * ksvg2/svg/SVGAnimatedPathData.idl:
2637         * ksvg2/svg/SVGAnimatedString.idl:
2638         * ksvg2/svg/SVGAnimatedTransformList.idl:
2639         * ksvg2/svg/SVGExternalResourcesRequired.idl:
2640         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
2641         * ksvg2/svg/SVGFitToViewBox.idl:
2642         * ksvg2/svg/SVGLangSpace.idl:
2643         * ksvg2/svg/SVGLocatable.idl:
2644         * ksvg2/svg/SVGMetadataElement.idl:
2645         * ksvg2/svg/SVGStringList.idl:
2646         * ksvg2/svg/SVGStylable.idl:
2647         * ksvg2/svg/SVGStyleElement.idl:
2648         * ksvg2/svg/SVGTests.idl:
2649         * ksvg2/svg/SVGTransformable.idl:
2650         * ksvg2/svg/SVGURIReference.idl:
2651         * ksvg2/svg/SVGUnitTypes.idl:
2652         * ksvg2/svg/SVGZoomAndPan.idl:
2653
2654 2006-09-28  Brady Eidson  <beidson@apple.com>
2655
2656         Reviewed by Mitz Pettel!!!
2657
2658         Change the error code check for common functions from SQLResultOk to SQLResultDone 
2659
2660         * loader/icon/IconDatabase.cpp:
2661         (WebCore::IconDatabase::forgetPageURLQuery):
2662         (WebCore::IconDatabase::setIconIDForPageURLQuery):
2663         (WebCore::IconDatabase::addIconForIconURLQuery):
2664
2665 2006-09-28  Dave Hyatt  <hyatt@apple.com>
2666
2667         Just eliminate MapWindowPoints usage and use the HWND as
2668         the viewport.
2669
2670         * platform/win/MouseEventWin.cpp:
2671         (WebCore::positionForEvent):
2672         * platform/win/ScrollViewWin.cpp:
2673         (WebCore::ScrollView::viewportToContents):
2674         (WebCore::ScrollView::contentsToViewport):
2675
2676 2006-09-27  David Hyatt  <hyatt@apple.com>
2677
2678         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
2679         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
2680         scrollbars to provide hover feedback if needed.
2681
2682         Reviewed by Eric
2683
2684         * page/FrameView.cpp:
2685         (WebCore::selectCursor):
2686         (WebCore::FrameView::handleMouseMoveEvent):
2687         * platform/ScrollBar.h:
2688         (WebCore::ScrollBar::mouseMoved):
2689
2690 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
2691
2692         Reviewed by Maciej and Adam, landed by Adam
2693
2694         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
2695         Windows build is busted
2696
2697         * platform/win/TemporaryLinkStubs.cpp:
2698         (ScrollView::paint):
2699         (ScrollView::themeChanged):
2700
2701 2006-09-27  Eric Seidel  <eric@eseidel.com>
2702
2703         Reviewed by mitz.
2704
2705         paths with no fill specified default to black but do not recieve paint-related mouse events
2706         http://bugs.webkit.org/show_bug.cgi?id=11069
2707         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
2708
2709         Test: svg/custom/hover-default-fill.svg
2710
2711         * kcanvas/RenderPath.cpp:
2712         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
2713         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
2714         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2715         (WebCore::KSVGPainterFactory::isFilled): remove null check
2716         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
2717         (WebCore::KSVGPainterFactory::isStroked): remove null check
2718         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
2719         * ksvg2/svg/SVGPaint.cpp:
2720         (WebCore::SVGPaint::defaultFill): added.
2721         (WebCore::SVGPaint::defaultStroke): added.
2722         * ksvg2/svg/SVGPaint.h:
2723
2724 2006-09-27  Rob Buis  <buis@kde.org>
2725
2726         Reviewed by eseidel.
2727
2728         http://bugs.webkit.org/show_bug.cgi?id=11015
2729         SVG handles em units incorrectly
2730
2731         Calculate viewport coordinates at layout time, since
2732         at this point the font size is known and lengths depending
2733         on font sizes can be calculated correctly.
2734
2735         * kcanvas/RenderSVGContainer.cpp:
2736         (WebCore::RenderSVGContainer::layout):
2737         (WebCore::RenderSVGContainer::viewport):
2738         (WebCore::RenderSVGContainer::calcViewport):
2739         * kcanvas/RenderSVGContainer.h:
2740         * ksvg2/svg/SVGLength.cpp:
2741         (WebCore::SVGLength::updateValue):
2742         * ksvg2/svg/SVGMarkerElement.cpp:
2743         (WebCore::SVGMarkerElement::createRenderer):
2744         * ksvg2/svg/SVGSVGElement.cpp:
2745         (WebCore::SVGSVGElement::createRenderer):
2746         (WebCore::SVGSVGElement::attributeChanged):
2747         * ksvg2/svg/SVGSVGElement.h:
2748
2749 2006-09-27  Eric Seidel  <eric@eseidel.com>
2750
2751         Reviewed by darin.
2752
2753         Change our invalid-fill error behavior to match Opera (and soon Firefox)
2754         http://bugs.webkit.org/show_bug.cgi?id=11017
2755
2756         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2757         (WebCore::KSVGPainterFactory::isFilled):
2758         (WebCore::KSVGPainterFactory::fillPaintServer):
2759         (WebCore::KSVGPainterFactory::isStroked):
2760         (WebCore::KSVGPainterFactory::strokePaintServer):
2761
2762 2006-09-27  Brady Eidson  <beidson@apple.com>
2763
2764         Build fix
2765
2766         * loader/icon/IconDatabase.cpp:
2767         (WebCore::readySQLStatement):
2768
2769 2006-09-27  Brady Eidson  <beidson@apple.com>
2770
2771         Reviewed by Adam
2772
2773         In very specific circumstances, prepared SQLStatements can become invalid without
2774         any warning.  This checks for that state and re-prepares the statement and also
2775         adds more aggressive error-checking everywhere these statements are used.
2776
2777         * loader/icon/IconDatabase.cpp:
2778         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
2779         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
2780         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
2781         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
2782         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
2783         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
2784         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
2785         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
2786         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
2787         * loader/icon/SQLStatement.cpp:
2788         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
2789         * loader/icon/SQLStatement.h:
2790
2791 2006-09-26  Darin Adler  <darin@apple.com>
2792
2793         Reviewed by Steve.
2794
2795         - clean up options for font code path
2796
2797         * platform/Font.h:
2798         * platform/Font.cpp:
2799         (WebCore::Font::setCodePath): Added. Replaces boolean version.
2800         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
2801
2802         * platform/mac/WebCoreTextRenderer.mm:
2803         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
2804
2805 2006-09-26  John Sullivan  <sullivan@apple.com>
2806
2807         Reviewed by Darin
2808
2809         * bridge/mac/WebCoreFrameBridge.h:
2810         * bridge/mac/WebCoreFrameBridge.mm:
2811         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
2812         Added limit parameter, passed down to Frame
2813         
2814         * page/Frame.h:
2815         * page/Frame.cpp:
2816         (WebCore::Frame::markAllMatchesForText):
2817         Added limit parameter. Stop the search if it hits limit.
2818
2819 2006-09-26  Sean Gies  <seangies@apple.com>
2820
2821         Reviewed by Brady Eidson.
2822
2823         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
2824
2825 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
2826
2827         Reviewed by john
2828         
2829         <rdar://problem/4747695> 
2830         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
2831         
2832         * editing/DeleteSelectionCommand.cpp:
2833         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
2834         to select special elements that are fully selected after expansion
2835         moves to positions that are visually distinct from the originals.
2836         * editing/InsertListCommand.cpp:
2837         (WebCore::InsertListCommand::doApply): If the content of the list 
2838         item will be moved into another list, put it in a list item.
2839
2840 2006-09-26  Geoffrey Garen <ggaren@apple.com>
2841
2842         Reviewed by Darin.
2843         
2844         Temporary work-around for frame lifetime issue.
2845
2846         * page/Frame.cpp:
2847         (WebCore::Frame::clear):
2848         (WebCore::Frame::disconnectOwnerElement):
2849
2850 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
2851
2852         Reviewed by Tim H.
2853
2854         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
2855         Auto-generate DOMSVGElement for the Objective-C bindings
2856
2857         - Auto-generates DOMSVGElement.
2858
2859         - Make SVGExceptions work like all the other ExceptionCode
2860           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
2861           and SVGExceptionMax.
2862
2863         * DerivedSources.make:
2864         * WebCore.xcodeproj/project.pbxproj:
2865         * bindings/js/kjs_binding.cpp:
2866         (KJS::):
2867         (KJS::setDOMException):
2868         * bindings/objc/DOMInternal.h:
2869         * bindings/objc/DOMInternal.mm:
2870         (raiseDOMException):
2871         * bindings/objc/DOMSVG.h:
2872         * bindings/objc/DOMSVGExecption.h: Added.
2873         * ksvg2/ksvg.h:
2874         * ksvg2/svg/SVGElement.cpp:
2875         (WebCore::SVGElement::setId):
2876         (WebCore::SVGElement::setXmlbase):
2877         * ksvg2/svg/SVGElement.h:
2878         * ksvg2/svg/SVGElement.idl:
2879         * ksvg2/svg/SVGException.h: Added.
2880         (WebCore::):
2881
2882 2006-09-26  Eric Seidel  <eric@eseidel.com>
2883
2884         Reviewed by Tim H.
2885         
2886         viewbox parser does not allow <tab> as a delimiter
2887         http://bugs.webkit.org/show_bug.cgi?id=11014
2888
2889         Test: svg/hixie/viewbox/003.xml
2890
2891         * ksvg2/svg/svgpathparser.cpp:
2892         (WebCore::isWhitespace): new function
2893         (WebCore::skipOptionalSpaces):
2894         (WebCore::skipOptionalSpacesOrComma):
2895
2896 2006-09-26  Eric Seidel  <eric@eseidel.com>
2897
2898         Reviewed by Tim H.
2899
2900         SVGDocument::createElement does not create elements in the SVG namespace
2901         http://bugs.webkit.org/show_bug.cgi?id=10932
2902         
2903         Test: svg/custom/createelement.svg
2904
2905         * ksvg2/svg/SVGDocument.cpp:
2906         (WebCore::SVGDocument::createElement):
2907         * ksvg2/svg/SVGDocument.h:
2908
2909 2006-09-26  Eric Seidel  <eric@eseidel.com>
2910
2911         Reviewed by Tim H.
2912         
2913         RenderPath::nodeAtPoint does not respect stroke width
2914         http://bugs.webkit.org/show_bug.cgi?id=10829
2915
2916         Test: svg/custom/stroke-width-click.svg
2917
2918         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
2919         (WebCore::RenderPath::strokeContains):
2920         * kcanvas/device/quartz/QuartzSupport.h:
2921         * kcanvas/device/quartz/QuartzSupport.mm:
2922
2923 2006-09-26  Eric Seidel  <eric@eseidel.com>
2924
2925         Reviewed by mitz.
2926
2927         Bring animation back to life
2928         http://bugs.webkit.org/show_bug.cgi?id=11021
2929         
2930         Register/unregister SVGSVGElements as time containers on insertion/removal.
2931         Replace uses of DeprecatedString with String in SVGAnimationElement
2932         Various whitespace clean-up.
2933
2934         * ksvg2/misc/KSVGTimeScheduler.cpp:
2935         (WebCore::SVGTimer::notifyAll):
2936         * ksvg2/misc/SVGDocumentExtensions.cpp:
2937         (WebCore::SVGDocumentExtensions::startAnimations):
2938         (WebCore::SVGDocumentExtensions::pauseAnimations):
2939         (WebCore::SVGDocumentExtensions::unpauseAnimations):
2940         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2941         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2942         (WebCore::SVGAnimateTransformElement::parseTransformValue):
2943         * ksvg2/svg/SVGAnimateTransformElement.h:
2944         * ksvg2/svg/SVGAnimationElement.cpp:
2945         (WebCore::SVGAnimationElement::SVGAnimationElement):
2946         (WebCore::SVGAnimationElement::parseMappedAttribute):
2947         (WebCore::SVGAnimationElement::parseClockValue):
2948         (WebCore::SVGAnimationElement::targetAttribute):
2949         (WebCore::SVGAnimationElement::setTargetAttribute):
2950         (WebCore::SVGAnimationElement::attributeName):
2951         * ksvg2/svg/SVGAnimationElement.h:
2952         (WebCore::SVGAnimationElement::rendererIsNeeded):
2953         * ksvg2/svg/SVGSVGElement.cpp:
2954         (WebCore::SVGSVGElement::getScreenCTM):
2955         (WebCore::SVGSVGElement::createRenderer):
2956         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
2957         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
2958         * ksvg2/svg/SVGSVGElement.h:
2959         * ksvg2/svg/SVGSetElement.cpp:
2960         (WebCore::SVGSetElement::handleTimerEvent):
2961         * ksvg2/svg/SVGURIReference.cpp:
2962         (WebCore::SVGURIReference::getTarget):
2963         * ksvg2/svg/SVGURIReference.h:
2964
2965 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
2966
2967         Reviewed by mitzpettel.
2968
2969         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
2970         No-SVG build broken since r16549
2971         
2972         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
2973
2974         * css/cssparser.cpp:
2975         (WebCore::CSSParser::parseValue):
2976         * css/cssstyleselector.cpp:
2977         (WebCore::CSSStyleSelector::applyProperty):
2978         * page/FrameView.cpp:
2979         (WebCore::selectCursor):
2980         * platform/qt/GraphicsContextQt.cpp:
2981
2982 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
2983
2984         Reviewed by Maciej.
2985
2986         http://bugs.webkit.org/show_bug.cgi?id=10820
2987         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
2988         
2989         (Originally written by Eric Seidel).
2990         
2991         * bindings/js/kjs_window.cpp:
2992         (KJS::floatFeature):
2993         * ksvg2/svg/SVGAngle.cpp:
2994         (SVGAngle::setValueAsString):
2995         * ksvg2/svg/SVGAnimationElement.cpp:
2996         (SVGAnimationElement::parseMappedAttribute):
2997         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2998         (SVGComponentTransferFunctionElement::parseMappedAttribute):
2999         * ksvg2/svg/SVGFECompositeElement.cpp:
3000         (WebCore::SVGFECompositeElement::parseMappedAttribute):
3001         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3002         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
3003         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3004         (SVGFEDisplacementMapElement::parseMappedAttribute):
3005         * ksvg2/svg/SVGFELightElement.cpp:
3006         (SVGFELightElement::parseMappedAttribute):
3007         * ksvg2/svg/SVGFEOffsetElement.cpp:
3008         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
3009         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
3010         (SVGFESpecularLightingElement::parseMappedAttribute):
3011         * ksvg2/svg/SVGFETurbulenceElement.cpp:
3012         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
3013         * ksvg2/svg/SVGStopElement.cpp:
3014         (SVGStopElement::parseMappedAttribute):
3015         * platform/AtomicString.h:
3016         (WebCore::AtomicString::toDouble):
3017         * platform/PlatformString.h:
3018         * platform/String.cpp:
3019         (WebCore::String::toDouble):
3020         * platform/StringImpl.cpp:
3021         (WebCore::StringImpl::toDouble):
3022         * platform/StringImpl.h:
3023         * rendering/DeprecatedSlider.cpp:
3024         (WebCore::DeprecatedSlider::updateFromElement):
3025         * xml/XPathGrammar.y:
3026
3027 2006-09-25  David Harrison  <harrison@apple.com>
3028
3029         Reviewed by Tim Omernick and Tim Hatcher.
3030
3031         <rdar://problem/4717965> Text Field text parameterized attributes should work
3032         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
3033
3034         * bridge/mac/WebCoreAXObject.mm:
3035         (-[WebCoreAXObject accessibilityAttributeValue:]):
3036         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
3037         
3038         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
3039         Cleaned up. Added text field and text area parameterzed attributes.
3040         
3041         (-[WebCoreAXObject doAXLineForTextMarker:]):
3042         Fixed to be zero-based and to deal with the first position properly.
3043         
3044         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
3045         Minor formatting.
3046         
3047         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
3048         (-[WebCoreAXObject indexForTextMarker:]):
3049         (-[WebCoreAXObject textMarkerRangeForRange:]):
3050         (-[WebCoreAXObject rangeForTextMarkerRange:]):
3051         New utility methods.
3052         
3053         (-[WebCoreAXObject doAXLineForIndex:]):
3054         (-[WebCoreAXObject doAXRangeForLine:]):
3055         (-[WebCoreAXObject doAXStringForRange:]):
3056         (-[WebCoreAXObject doAXRangeForPosition:]):
3057         (-[WebCoreAXObject doAXRangeForIndex:]):
3058         (-[WebCoreAXObject doAXBoundsForRange:]):
3059         (-[WebCoreAXObject doAXAttributedStringForRange:]):
3060         (-[WebCoreAXObject doAXRTFForRange:]):
3061         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
3062         Implement text field and text area parameterized attributes.
3063          
3064         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
3065         Added text field and text area parameterzed attributes.
3066
3067         * rendering/RenderTextControl.h:
3068         Made indexForVisiblePosition() and visiblePositionForIndex() public.
3069
3070 2006-09-25  Adam Roben  <aroben@apple.com>
3071
3072         Reviewed by Brady.
3073
3074         Build fixes.
3075
3076         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
3077         * platform/ResourceLoader.h: Store whether a particular job
3078         has received a response within the ResourceLoader object itself, since
3079         it's possible that we will enter the InternetReadFileExA while loop
3080         twice for the same job.
3081         * platform/ResourceLoaderInternal.h: Add private instance variable to
3082         store whether we've received a response.
3083         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3084         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
3085         directives.
3086         * platform/win/ResourceLoaderWin.cpp: 
3087         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
3088         whether it has received a response instead of assuming it hasn't.
3089         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
3090         (WebCore::ResourceLoader::hasReceivedResponse): Added.
3091         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
3092         setProportion
3093         (ScrollBar::setProportion):
3094
3095 2006-09-25  Brady Eidson  <beidson@apple.com>
3096
3097         Requested by ggaren
3098
3099         Disabled IconDatabase logging by default
3100
3101         * platform/Logging.cpp:
3102         (WebCore::):
3103
3104 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
3105
3106         Build fix
3107
3108         * platform/cf/ResourceLoaderCFNet.cpp:
3109         (WebCore::willCacheResponse):
3110
3111 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
3112
3113         Reviewed by john
3114         
3115         <http://bugs.webkit.org/show_bug.cgi?id=11002>
3116         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
3117         
3118         * editing/IndentOutdentCommand.cpp:
3119         (WebCore::IndentOutdentCommand::indentRegion): Special case
3120         an empty root editable element.
3121
3122 2006-09-25  Brady Eidson  <beidson@apple.com>
3123
3124         Reviewed by Steve
3125
3126         Math error in SystemTimeWin
3127
3128         * platform/win/SystemTimeWin.cpp:
3129         (WebCore::currentTime):
3130
3131 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
3132
3133         Reviewed by Eric.
3134
3135         Whitespace cleanup; rename *job variables to *loader.
3136
3137         * bindings/js/JSXMLHttpRequest.cpp:
3138         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
3139         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
3140         (KJS::JSXMLHttpRequestConstructorImp::construct):
3141         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
3142         (KJS::JSXMLHttpRequest::getValueProperty):
3143         (KJS::JSXMLHttpRequest::put):
3144         (KJS::JSXMLHttpRequest::putValueProperty):
3145         (KJS::JSXMLHttpRequest::mark):
3146         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
3147         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
3148         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
3149         * bindings/js/JSXMLHttpRequest.h:
3150         (KJS::JSXMLHttpRequest::toBoolean):
3151         * xml/xmlhttprequest.cpp:
3152         (WebCore::XMLHttpRequest::XMLHttpRequest):
3153         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
3154         (WebCore::XMLHttpRequest::send):
3155         (WebCore::XMLHttpRequest::abort):
3156         (WebCore::XMLHttpRequest::receivedAllData):
3157         (WebCore::XMLHttpRequest::receivedData):
3158         * xml/xmlhttprequest.h:
3159         (WebCore::):
3160
3161 2006-09-25  Timothy Hatcher  <timothy@apple.com>
3162
3163         Reviewed by Brady.
3164
3165         - Deprecate the rest of the old-style methods that are not generated.
3166         - Add @property syntax to DOMRange.
3167
3168         * WebCore.xcodeproj/project.pbxproj:
3169         * bindings/objc/DOM.mm:
3170         (-[DOMRange setStart:offset:]):
3171         (-[DOMRange setEnd:offset:]):
3172         (-[DOMRange compareBoundaryPoints:sourceRange:]):
3173         (-[DOMRange setStart::]):
3174         (-[DOMRange setEnd::]):
3175         (-[DOMRange compareBoundaryPoints::]):
3176         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3177         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3178         (-[DOMDocument createNodeIterator::::]):
3179         (-[DOMDocument createTreeWalker::::]):
3180         * bindings/objc/DOMCSS.h:
3181         * bindings/objc/DOMCSS.mm:
3182         (-[DOMDocument getComputedStyle:pseudoElement:]):
3183         (-[DOMDocument getComputedStyle::]):
3184         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
3185         * bindings/objc/DOMExtensions.h:
3186         * bindings/objc/DOMHTML.h:
3187         * bindings/objc/DOMRange.h:
3188         * bindings/objc/DOMTraversal.h:
3189
3190 2006-09-25  Eric Seidel  <eric@eseidel.com>
3191
3192         Reviewed by mjs.
3193         
3194         Outermost <svg> element should clip to viewport
3195         http://bugs.webkit.org/show_bug.cgi?id=11007
3196
3197         Test: svg/custom/viewport-clip.svg
3198
3199         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
3200
3201 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
3202
3203         Reviewed by Maciej.
3204
3205         * css/MediaList.cpp:
3206         Remove unused header.
3207         
3208         * dom/Document.cpp:
3209         (WebCore::Document::clear):
3210         Use clear instead of iterating through the list of event listeners, removing each one.
3211         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
3212         
3213         * html/HTMLKeygenElement.cpp:
3214         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
3215         (WebCore::HTMLKeygenElement::appendFormData):
3216         Update due to changes in the SSL key generator.
3217         
3218         * ksvg2/svg/SVGAngle.cpp:
3219         Remove unused header.
3220         
3221         * ksvg2/svg/SVGAnimationElement.cpp:
3222         (SVGAnimationElement::parseMappedAttribute):
3223         Rename methods and pass Strings instead of DeprecatedStrings to
3224         parseSeparatedList.
3225         
3226         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3227         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3228         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3229         * ksvg2/svg/SVGFEMergeElement.cpp:
3230         * ksvg2/svg/SVGFEOffsetElement.cpp:
3231         Remove unused headers.
3232         
3233         * ksvg2/svg/SVGHelper.cpp:
3234         (WebCore::SVGHelper::parseSeparatedList):
3235         * ksvg2/svg/SVGHelper.h:
3236         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a 
3237         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
3238         
3239         * ksvg2/svg/SVGLengthList.cpp:
3240         (WebCore::SVGLengthList::parse):
3241         * ksvg2/svg/SVGLengthList.h:
3242         Use Vector<String> instead of DeprecatedStringList.
3243         
3244         * loader/Cache.cpp:
3245         (WebCore::Cache::requestImage):
3246         (WebCore::Cache::requestStyleSheet):
3247         (WebCore::Cache::requestScript):
3248         (WebCore::Cache::requestXSLStyleSheet):
3249         (WebCore::Cache::requestXBLDocument):
3250         (WebCore::Cache::remove):
3251         (WebCore::Cache::get):
3252         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
3253         
3254         * loader/DocLoader.cpp:
3255         (WebCore::DocLoader::needReload):
3256         * loader/DocLoader.h:
3257         Use a HashSet instead of DeprecatedStringList.
3258         
3259         * page/FrameView.h:
3260         Remove declarations that have no functions.
3261         
3262         * platform/SSLKeyGenerator.h:
3263         * platform/mac/SSLKeyGeneratorMac.mm:
3264         (WebCore::supportedKeySizes):
3265         (WebCore::signedPublicKeyAndChallengeString):
3266         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
3267         DeprecatedString.
3268
3269 2006-09-25  Dave Hyatt  <hyatt@apple.com>
3270
3271         Shunt the RenderTheme world transform adoption between
3272         Cairo and Windows into getWindowsContext and move the method
3273         out of GraphicsContextCairo and into GraphicsContextWin.
3274
3275         * ChangeLog:
3276         * WebCore.vcproj/WebCore/WebCore.vcproj:
3277         * platform/cairo/GraphicsContextCairo.cpp:
3278         * platform/win/GraphicsContextWin.cpp: Added.
3279         (WebCore::GraphicsContext::getWindowsContext):
3280         (WebCore::GraphicsContext::releaseWindowsContext):
3281         * rendering/RenderThemeWin.cpp:
3282         (WebCore::prepareForDrawing):
3283
3284 2006-09-24  Eric Seidel  <eric@eseidel.com>
3285
3286         Reviewed by hyatt.
3287
3288         <svg:a> cannot be styled with a:hover
3289         http://bugs.webkit.org/show_bug.cgi?id=11005
3290         
3291         Test: svg/hixie/cascade/002.xml
3292
3293         * css/cssstyleselector.cpp:
3294         (WebCore::checkPseudoState):
3295
3296 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
3297
3298         Reviewed by Tim H.
3299
3300         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
3301         SVG needs Obj-C DOM bindings
3302
3303         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The 
3304           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
3305           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and 
3306           DOMSVGTransformList.
3307
3308         * DerivedSources.make:
3309         * WebCore.xcodeproj/project.pbxproj:
3310         * bindings/objc/DOMInternal.h:
3311         * bindings/objc/DOMSVG.h: Added.
3312         * ksvg2/svg/SVGAngle.idl:
3313         * ksvg2/svg/SVGLength.idl:
3314         * ksvg2/svg/SVGLengthList.idl:
3315         * ksvg2/svg/SVGMatrix.idl:
3316         * ksvg2/svg/SVGPathSeg.idl:
3317         * ksvg2/svg/SVGPathSegList.idl:
3318         * ksvg2/svg/SVGTransform.idl:
3319         * ksvg2/svg/SVGTransformList.idl:
3320
3321 2006-09-24  Rob Buis  <buis@kde.org>
3322
3323         Reviewed by eseidel.
3324
3325         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
3326         WebKit does not handle fallback custom cursors
3327         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
3328         WebKit does not properly handle SVG <cursor> element
3329
3330         Add support for svg cursor images. Also make sure hotspot
3331         settings are handled correctly. Add tests for handling of css3
3332         cursor syntax with hotspots in strict and quirks mode. Finally
3333         implement fallback.
3334
3335         * WebCore.xcodeproj/project.pbxproj:
3336         * css/CSSComputedStyleDeclaration.cpp:
3337         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3338         * css/CSSCursorImageValue.cpp: Added.
3339         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
3340         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
3341         * css/CSSCursorImageValue.h: Added.
3342         (WebCore::CSSCursorImageValue::hotspot):
3343         * css/cssparser.cpp:
3344         (WebCore::CSSParser::parseValue):
3345         * css/cssstyleselector.cpp:
3346         (WebCore::CSSStyleSelector::applyProperty):
3347         * ksvg2/svg/SVGCursorElement.cpp:
3348         * manual-tests/css3-cursor-fallback-quirks.html: Added.
3349         * manual-tests/css3-cursor-fallback-strict.html: Added.
3350         * manual-tests/cursorfallback.xml: Added.
3351         * page/FrameView.cpp:
3352         (WebCore::selectCursor):
3353         * platform/Cursor.h:
3354         * platform/mac/CursorMac.mm:
3355         (WebCore::createCustomCursor):
3356         (WebCore::Cursor::Cursor):
3357         * platform/qt/CursorQt.cpp:
3358         (WebCore::Cursor::Cursor):
3359         * rendering/RenderStyle.cpp:
3360         (WebCore::StyleInheritedData::StyleInheritedData):
3361         (WebCore::StyleInheritedData::operator==):
3362         (WebCore::RenderStyle::diff):
3363         (WebCore::RenderStyle::addCursor):
3364         (WebCore::RenderStyle::addSVGCursor):
3365         (WebCore::RenderStyle::setCursorList):
3366         (WebCore::RenderStyle::clearCursorList):
3367         * rendering/RenderStyle.h:
3368         (WebCore::CursorData::CursorData):
3369         (WebCore::CursorList::operator[]):
3370         (WebCore::CursorList::size):
3371         (WebCore::CursorList::append):
3372         (WebCore::RenderStyle::cursors):
3373
3374 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
3375
3376         Reviewed by Tim H.
3377
3378         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
3379         Auto-generate the internal methods interfaces for the Objective-C bindings
3380
3381         - Auto-generate the internal method declarations into their own files
3382           named in the form DOMFooBarInternal.h for class DOMFooBar.
3383
3384         - Remove all use of DOM_cast from code.
3385
3386         - Assorted cleanups.
3387
3388         * WebCore.xcodeproj/project.pbxproj:
3389         * bindings/objc/DOM.mm:
3390         (-[DOMNode _initWithNode:WebCore::]):
3391         (-[DOMNode WebCore::]):
3392         (-[DOMRange dealloc]):
3393         (-[DOMRange finalize]):
3394         (-[DOMRange _initWithRange:WebCore::]):
3395         (-[DOMRange WebCore::]):
3396         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
3397         (-[DOMNodeFilter WebCore::]):
3398         (-[DOMNodeFilter dealloc]):
3399         (-[DOMNodeFilter finalize]):
3400         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
3401         (-[DOMNodeIterator WebCore::]):
3402         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
3403         (-[DOMTreeWalker WebCore::]):
3404         * bindings/objc/DOMAbstractView.mm:
3405         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
3406         * bindings/objc/DOMCSS.mm:
3407         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
3408         (-[DOMCSSRule _initWithRule:WebCore::]):
3409         (-[DOMCSSValue _initWithValue:WebCore::]):
3410         * bindings/objc/DOMEvents.mm:
3411         (-[DOMEvent _initWithEvent:WebCore::]):
3412         * bindings/objc/DOMHTMLAppletElement.mm:
3413         (-[DOMHTMLAppletElement align]):
3414         (-[DOMHTMLAppletElement setAlign:]):
3415         (-[DOMHTMLAppletElement alt]):
3416         (-[DOMHTMLAppletElement setAlt:]):
3417         (-[DOMHTMLAppletElement archive]):
3418         (-[DOMHTMLAppletElement setArchive:]):
3419         (-[DOMHTMLAppletElement code]):
3420         (-[DOMHTMLAppletElement setCode:]):
3421         (-[DOMHTMLAppletElement codeBase]):
3422         (-[DOMHTMLAppletElement setCodeBase:]):
3423         (-[DOMHTMLAppletElement height]):
3424         (-[DOMHTMLAppletElement setHeight:]):
3425         (-[DOMHTMLAppletElement hspace]):
3426         (-[DOMHTMLAppletElement setHspace:]):
3427         (-[DOMHTMLAppletElement name]):
3428         (-[DOMHTMLAppletElement setName:]):
3429         (-[DOMHTMLAppletElement object]):
3430         (-[DOMHTMLAppletElement setObject:]):
3431         (-[DOMHTMLAppletElement vspace]):
3432         (-[DOMHTMLAppletElement setVspace:]):
3433         (-[DOMHTMLAppletElement width]):
3434         (-[DOMHTMLAppletElement setWidth:]):
3435         * bindings/objc/DOMInternal.h:
3436         (getDOMWrapper):
3437         (addDOMWrapper):
3438         (raiseOnDOMError):
3439         * bindings/objc/DOMXPath.mm:
3440         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
3441         * bindings/scripts/CodeGeneratorObjC.pm:
3442
3443 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
3444
3445         Reviewed by eseidel.
3446
3447         Fix Qt/Linux build after Dave's Scrollbar changes.
3448
3449         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
3450         * platform/qt/TemporaryLinkStubs.cpp:
3451         (WebCore::ScrollBar::setProportion):
3452         (WebCore::PlatformScrollBar::updateThumbPosition):
3453         (WebCore::PlatformScrollBar::updateThumbProportion):
3454
3455 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
3456
3457         Reviewed by eseidel.
3458
3459         Qt/Linux build system changes: enable xpath/xslt by default.
3460         Offer possibility to change all of these using 'ccmake'.
3461
3462         * CMakeLists.txt:
3463
3464 2006-09-24  Dave Hyatt  <hyatt@apple.com>
3465
3466         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
3467         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
3468         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
3469
3470         * platform/ScrollBar.cpp:
3471         (WebCore::ScrollBar::setValue):
3472         (WebCore::ScrollBar::setProportion):
3473         * platform/ScrollBar.h:
3474         (WebCore::ScrollBar::value):
3475         * platform/mac/PlatformScrollBar.h:
3476         * platform/mac/PlatformScrollBarMac.mm:
3477         (WebCore::PlatformScrollBar::updateThumbPosition):
3478         (WebCore::PlatformScrollBar::updateThumbProportion):
3479         * platform/win/PlatformScrollBar.h:
3480         * platform/win/TemporaryLinkStubs.cpp:
3481         (PlatformScrollBar::updateThumbPosition):
3482         (PlatformScrollBar::updateThumbProportion):
3483         * rendering/RenderLayer.cpp:
3484         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
3485
3486 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
3487
3488         Reviewed by Eric.
3489
3490         http://bugs.webkit.org/show_bug.cgi?id=4872
3491         XMLHttpRequest fails to throw an exception when there is a security violation
3492         (mismatching domains)
3493
3494         Raise an exception if there is a security violation, and also in cases required by
3495         the current draft of XHR specification.
3496
3497         * bindings/js/JSXMLHttpRequest.cpp:
3498         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
3499         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
3500         reports one, and also if there were too few arguments passed. 
3501
3502         * bindings/js/kjs_binding.cpp:
3503         (KJS::setDOMException): Added support for custom XHR exceptions.
3504
3505         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
3506         exception code range for XHR exceptions.
3507
3508         * xml/xmlhttprequest.cpp:
3509         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
3510         (WebCore::XMLHttpRequest::send):
3511         (WebCore::XMLHttpRequest::setRequestHeader):
3512         (WebCore::XMLHttpRequest::getStatus):
3513         (WebCore::XMLHttpRequest::getStatusText):
3514         (WebCore::XMLHttpRequest::processSyncLoadResults):
3515         (WebCore::XMLHttpRequest::receivedAllData):
3516         (WebCore::XMLHttpRequest::receivedData):
3517
3518 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
3519
3520         Reviewed by Jeff Jenkins.
3521
3522         Tweak CF types.
3523
3524         * platform/cf/ResourceLoaderCFNet.cpp:
3525         (WebCore::willCacheResponse):
3526
3527 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
3528
3529         Reviewed by darin
3530
3531         <http://bugs.webkit.org/show_bug.cgi?id=8029>
3532         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
3533
3534         * dom/Document.cpp:
3535         (WebCore::Document::clearSelectionIfNeeded):
3536         * dom/Element.cpp:
3537         (WebCore::Element::contains):
3538         * dom/Node.cpp:
3539         (WebCore::Node::traverseNextNode):
3540         (WebCore::Node::traverseNextSibling):
3541         (WebCore::Node::traversePreviousNodePostOrder):
3542         (WebCore::Node::checkAddChild):
3543         (WebCore::Node::isDescendantOf):
3544         * dom/Node.h:
3545         * dom/NodeIterator.cpp:
3546         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
3547         * editing/ApplyStyleCommand.cpp:
3548         (WebCore::ApplyStyleCommand::applyBlockStyle):
3549         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
3550         (WebCore::ApplyStyleCommand::applyInlineStyle):
3551         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
3552         * editing/CompositeEditCommand.cpp:
3553         (WebCore::CompositeEditCommand::mergeIdenticalElements):
3554         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
3555         * editing/DeleteSelectionCommand.cpp:
3556         (WebCore::updatePositionForNodeRemoval):
3557         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
3558         (WebCore::DeleteSelectionCommand::mergeParagraphs):
3559         * editing/FormatBlockCommand.cpp:
3560         (WebCore::FormatBlockCommand::doApply):
3561         * editing/IndentOutdentCommand.cpp:
3562         (WebCore::enclosingListOrBlockquote):
3563         * editing/Selection.cpp:
3564         (WebCore::Selection::validate):
3565         * editing/SelectionController.cpp:
3566         (WebCore::SelectionController::nodeWillBeRemoved):
3567         * editing/TextIterator.cpp:
3568         (WebCore::SimplifiedBackwardsTextIterator::advance):
3569         * editing/VisiblePosition.cpp:
3570         (WebCore::VisiblePosition::next):
3571         (WebCore::VisiblePosition::previous):
3572         (WebCore::VisiblePosition::canonicalPosition):
3573         (WebCore::isFirstVisiblePositionInNode):
3574         (WebCore::isLastVisiblePositionInNode):
3575         * editing/htmlediting.cpp:
3576         (WebCore::firstEditablePositionAfterPositionInRoot):
3577         (WebCore::lastEditablePositionBeforePositionInRoot):
3578         (WebCore::enclosingNodeWithTag):
3579         (WebCore::enclosingList):
3580         (WebCore::enclosingListChild):
3581         * editing/markup.cpp:
3582         (WebCore::createMarkup):
3583
3584 2006-09-22  Timothy Hatcher  <timothy@apple.com>
3585
3586         Reviewed by Darin.
3587
3588         - Added @property syntax to non-generated headers
3589           inside #ifndef BUILDING_ON_TIGER.
3590         - Changed the DOMEventTarget protocol to have have new versions
3591           of addEventListener and removeEventListener with named parameters.
3592           These old style methods can be removed once Mail changes to use
3593           the new methods <rdar://problem/4746649>.
3594
3595         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
3596         * bindings/objc/DOM.mm:
3597         (-[DOMNode addEventListener:listener:useCapture:]):
3598         (-[DOMNode addEventListener:::]): call the new method
3599         (-[DOMNode removeEventListener:listener:useCapture:]):
3600         (-[DOMNode removeEventListener:::]): call the new method
3601         * bindings/objc/DOMAbstractView.h:
3602         * bindings/objc/DOMEventTarget.h:
3603         * bindings/objc/DOMHTMLAppletElement.h:
3604         * bindings/objc/DOMHTMLEmbedElement.h:
3605         * bindings/objc/DOMHTMLOptionElement.h:
3606         * bindings/objc/DOMObject.h:
3607         * bindings/objc/DOMRGBColor.h:
3608
3609 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
3610
3611         Reviewed by Eric.
3612
3613         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
3614
3615         * platform/qt/FrameQt.cpp:
3616         * platform/qt/GraphicsContextQt.cpp:
3617         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
3618         (WebCore::GraphicsContext::origin):
3619         * platform/qt/PlatformScrollBar.h: Added.
3620         (WebCore::PlatformScrollBar::isWidget):