1 2006-10-07 Anders Carlsson <acarlsson@apple.com>
5 Convert a bunch of RefPtr<StringImpl> to String.
7 * bridge/mac/FrameMac.h:
8 * bridge/mac/FrameMac.mm:
9 (WebCore::FrameMac::didTellBridgeAboutLoad):
10 (WebCore::FrameMac::haveToldBridgeAboutLoad):
11 * dom/BeforeUnloadEvent.cpp:
12 (WebCore::BeforeUnloadEvent::storeResult):
13 * dom/BeforeUnloadEvent.h:
14 (WebCore::BeforeUnloadEvent::result):
16 (WebCore::Document::createEntityReference):
18 (WebCore::Entity::Entity):
19 (WebCore::Entity::nodeName):
20 (WebCore::Entity::toString):
22 (WebCore::Entity::publicId):
23 (WebCore::Entity::systemId):
24 (WebCore::Entity::notationName):
25 * dom/EntityReference.cpp:
26 (WebCore::EntityReference::EntityReference):
27 (WebCore::EntityReference::nodeName):
28 (WebCore::EntityReference::cloneNode):
29 (WebCore::EntityReference::toString):
30 * dom/EntityReference.h:
31 * dom/KeyboardEvent.cpp:
32 (WebCore::KeyboardEvent::KeyboardEvent):
33 (WebCore::KeyboardEvent::initKeyboardEvent):
34 * dom/KeyboardEvent.h:
35 (WebCore::KeyboardEvent::keyIdentifier):
36 * dom/MutationEvent.cpp:
37 (WebCore::MutationEvent::MutationEvent):
38 (WebCore::MutationEvent::initMutationEvent):
39 * dom/MutationEvent.h:
40 (WebCore::MutationEvent::prevValue):
41 (WebCore::MutationEvent::newValue):
42 (WebCore::MutationEvent::attrName):
44 (WebCore::Notation::Notation):
45 (WebCore::Notation::nodeName):
47 (WebCore::Notation::publicId):
48 (WebCore::Notation::systemId):
49 * dom/ProcessingInstruction.cpp:
50 (WebCore::ProcessingInstruction::ProcessingInstruction):
51 (WebCore::ProcessingInstruction::setData):
52 (WebCore::ProcessingInstruction::nodeName):
53 (WebCore::ProcessingInstruction::nodeValue):
54 (WebCore::ProcessingInstruction::cloneNode):
55 (WebCore::ProcessingInstruction::checkStyleSheet):
56 (WebCore::ProcessingInstruction::toString):
57 * dom/ProcessingInstruction.h:
58 (WebCore::ProcessingInstruction::target):
59 (WebCore::ProcessingInstruction::data):
60 (WebCore::ProcessingInstruction::localHref):
62 2006-10-07 Sam Weinig <sam.weinig@gmail.com>
66 Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
67 10 more SVG Objective-C auto-generated bindings
69 - Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox,
70 DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement,
71 DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement,
72 DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
74 - Auto-generate the text method for DOMRange.
76 * DerivedSources.make:
77 * WebCore.xcodeproj/project.pbxproj:
78 * bindings/objc/DOM.mm:
79 * bindings/objc/DOMExtensions.h:
80 * bindings/objc/DOMInternal.h:
81 * bindings/objc/DOMPrivate.h:
82 * bindings/objc/DOMRGBColor.mm:
83 * bindings/objc/DOMSVG.h:
84 * bindings/objc/PublicDOMInterfaces.h:
85 * bindings/scripts/CodeGeneratorObjC.pm:
87 * ksvg2/svg/SVGFilterElement.cpp:
88 * ksvg2/svg/SVGFilterElement.h:
89 * ksvg2/svg/SVGFilterElement.idl:
90 * ksvg2/svg/SVGForeignObjectElement.idl:
91 * ksvg2/svg/SVGGElement.idl:
92 * ksvg2/svg/SVGGradientElement.idl:
93 * ksvg2/svg/SVGImageElement.idl:
94 * ksvg2/svg/SVGLineElement.idl:
95 * ksvg2/svg/SVGLinearGradientElement.idl:
96 * ksvg2/svg/SVGMarkerElement.idl:
97 * ksvg2/svg/SVGMaskElement.idl:
98 * ksvg2/svg/SVGPaint.idl:
100 2006-10-07 Sam Weinig <sam.weinig@gmail.com>
104 Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
105 Auto-generate a few more Objective-C DOM interfaces
107 - Fully auto-generate DOMAbstractView and DOMRange.
109 - Auto-generate just the interface for DOMRGBColor.
111 - Add DOMRanges.h as the new top level file for Ranges
114 - Add DOMRanges.h and DOMXPath.h to DOM.mm
116 * DerivedSources.make:
117 * WebCore.xcodeproj/project.pbxproj:
118 * bindings/objc/DOM.h:
119 * bindings/objc/DOM.mm:
120 * bindings/objc/DOMAbstractView.h: Removed.
121 * bindings/objc/DOMAbstractView.mm: Removed.
122 * bindings/objc/DOMInternal.h:
123 * bindings/objc/DOMPrivate.h:
124 * bindings/objc/DOMRGBColor.h: Removed.
125 * bindings/objc/DOMRGBColor.mm:
126 * bindings/objc/DOMRange.h: Removed.
127 * bindings/objc/DOMRanges.h: Added.
128 * bindings/objc/PublicDOMInterfaces.h:
129 * bindings/scripts/CodeGeneratorObjC.pm:
132 * page/AbstractView.idl: Added.
134 2006-10-07 Andrew Wellington <proton@wiretapped.net>
138 Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
139 http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
141 Return null when there is no frame. This matches Firefox.
143 * bindings/js/kjs_html.cpp:
144 (KJS::JSHTMLDocument::getValueProperty):
146 2006-10-07 David Hyatt <hyatt@apple.com>
148 Implement scroll corner painting (a white rect fill) for overflow areas to cover up
149 scrollbar joins properly.
151 Refactor painting of scrollbars and resizers into common functions. Eliminate the
152 extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
156 * page/FrameView.cpp:
157 (WebCore::selectCursor):
158 (WebCore::FrameView::handleMouseMoveEvent):
159 * platform/mac/PlatformScrollBar.h:
160 (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
161 (WebCore::PlatformScrollbar::verticalScrollbarWidth):
162 * rendering/RenderLayer.cpp:
163 (WebCore::RenderLayer::RenderLayer):
164 (WebCore::RenderLayer::~RenderLayer):
165 (WebCore::RenderLayer::updateLayerPositions):
166 (WebCore::scrollCornerRect):
167 (WebCore::RenderLayer::positionOverflowControls):
168 (WebCore::RenderLayer::paintOverflowControls):
169 (WebCore::RenderLayer::isPointInResizeControl):
170 (WebCore::RenderLayer::paintLayer):
171 * rendering/RenderLayer.h:
173 2006-10-07 Mark Rowe <bdash@webkit.org>
177 Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
178 matching recent ResourceLoader changes.
180 * platform/gdk/FrameGdk.cpp:
181 (WebCore::FrameGdk::openURL):
182 (WebCore::FrameGdk::urlSelected):
183 * platform/gdk/PlatformScrollBar.h:
184 * platform/gdk/ResourceLoaderCurl.cpp:
185 (WebCore::ResourceLoader::start):
186 * platform/gdk/ScrollViewGdk.cpp:
187 (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
188 (WebCore::ScrollView::resizeContents):
189 (WebCore::ScrollView::scrollBy):
190 (WebCore::ScrollView::hScrollbarMode):
191 (WebCore::ScrollView::vScrollbarMode):
192 (WebCore::ScrollView::suppressScrollbars):
193 (WebCore::ScrollView::setHScrollbarMode):
194 (WebCore::ScrollView::setVScrollbarMode):
195 (WebCore::ScrollView::setScrollbarsMode):
196 * platform/gdk/TemporaryLinkStubs.cpp:
197 (FrameView::passMousePressEventToScrollbar):
198 (Widget::removeFromParent):
199 (ScrollView::addChild):
200 (ScrollView::updateScrollbars):
201 (ScrollView::scrollbarUnderMouse):
202 (PlatformScrollbar::PlatformScrollbar):
203 (PlatformScrollbar::~PlatformScrollbar):
204 (PlatformScrollbar::width):
205 (PlatformScrollbar::height):
206 (PlatformScrollbar::setEnabled):
207 (PlatformScrollbar::paint):
208 (PlatformScrollbar::updateThumbPosition):
209 (PlatformScrollbar::updateThumbProportion):
210 (PlatformScrollbar::setRect):
211 (Scrollbar::Scrollbar):
212 (Scrollbar::setSteps):
214 (Scrollbar::setValue):
215 (Scrollbar::setProportion):
217 2006-10-06 Dave Hyatt <hyatt@apple.com>
219 Implement a new method for obtaining accurate clip rectangles that can be used by plugins to properly clip.
221 * page/FrameView.cpp:
222 (WebCore::FrameView::windowClipRect):
224 * platform/ScrollView.h:
225 * platform/Widget.cpp:
226 (WebCore::Widget::windowClipRect):
228 (WebCore::Widget::geometryChanged):
229 (WebCore::Widget::handleMouseMoveEvent):
230 (WebCore::Widget::handleMouseReleaseEvent):
231 * platform/mac/ScrollViewMac.mm:
232 (WebCore::ScrollView::addChild):
233 * rendering/RenderLayer.cpp:
234 (WebCore::RenderLayer::documentClipRect):
235 * rendering/RenderLayer.h:
237 2006-10-06 Steve Falkenburg <sfalken@apple.com>
241 Add another method we'll need for scrollbar dodging
243 * platform/ScrollView.h:
244 * platform/win/TemporaryLinkStubs.cpp:
245 (ScrollView::resizerOverlapsContent):
247 2006-10-06 Sam Weinig <sam.weinig@gmail.com>
251 Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
252 Auto-generate the interfaces even for Objective-C DOM
253 bindings that need custom implementations
255 - Fully auto-generate DOMEventTarget, DOMNodeFilter and
256 DOMHTMLOptionElement.
258 - Auto-generate just the interface for DOMHTMLAppletElement,
259 DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect
260 using the new IDL property ObjCCustomImplementation.
262 * DerivedSources.make:
263 * WebCore.xcodeproj/project.pbxproj:
264 * bindings/objc/DOMEventTarget.h: Removed.
265 * bindings/objc/DOMHTMLAppletElement.h: Removed.
266 * bindings/objc/DOMHTMLEmbedElement.h: Removed.
267 * bindings/objc/DOMHTMLOptionElement.h: Removed.
268 * bindings/objc/DOMHTMLOptionElement.mm: Removed.
269 * bindings/objc/DOMInternal.h:
270 * bindings/objc/DOMNodeFilter.h: Removed.
271 * bindings/objc/DOMSVGNumber.h: Removed.
272 * bindings/objc/DOMSVGPoint.h: Removed.
273 * bindings/objc/DOMSVGPoint.mm:
274 (-[DOMSVGPoint matrixTransform:]):
275 * bindings/objc/DOMSVGRect.h: Removed.
276 * bindings/objc/PublicDOMInterfaces.h:
277 * bindings/scripts/CodeGeneratorObjC.pm:
278 * dom/EventTarget.idl:
279 * html/HTMLAppletElement.idl:
280 * html/HTMLEmbedElement.idl:
281 * html/HTMLOptionElement.idl:
282 * ksvg2/svg/SVGNumber.idl:
283 * ksvg2/svg/SVGPoint.idl:
284 * ksvg2/svg/SVGRect.idl:
286 2006-10-06 Nikolas Zimmermann <zimmermann@kde.org>
290 Make Qt/Linux compile again completly.
292 * platform/qt/WidgetQt.cpp:
293 (WebCore::Widget::removeFromParent):
295 2006-10-06 Nikolas Zimmermann <zimmermann@kde.org>
299 Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.
301 * platform/qt/PlatformScrollBar.h:
302 * platform/qt/ScrollViewQt.cpp:
303 (WebCore::ScrollView::hScrollbarMode):
304 (WebCore::ScrollView::vScrollbarMode):
305 (WebCore::ScrollView::suppressScrollbars):
306 (WebCore::ScrollView::setHScrollbarMode):
307 (WebCore::ScrollView::setVScrollbarMode):
308 (WebCore::ScrollView::setScrollbarsMode):
309 (WebCore::ScrollView::scrollbarUnderMouse):
310 * platform/qt/TemporaryLinkStubs.cpp:
311 (WebCore::Scrollbar::Scrollbar):
312 (WebCore::Scrollbar::setSteps):
313 (WebCore::Scrollbar::scroll):
314 (WebCore::Scrollbar::setValue):
315 (WebCore::Scrollbar::setProportion):
316 (WebCore::PlatformScrollbar::PlatformScrollbar):
317 (WebCore::PlatformScrollbar::~PlatformScrollbar):
318 (WebCore::PlatformScrollbar::width):
319 (WebCore::PlatformScrollbar::height):
320 (WebCore::PlatformScrollbar::setEnabled):
321 (WebCore::PlatformScrollbar::paint):
322 (WebCore::PlatformScrollbar::updateThumbPosition):
323 (WebCore::PlatformScrollbar::updateThumbProportion):
324 (WebCore::PlatformScrollbar::setRect):
325 (FrameView::passMousePressEventToScrollbar):
327 2006-10-06 Sam Weinig <sam.weinig@gmail.com>
331 Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
332 Another round of Objective-C SVG DOM bindings auto-generation
334 - Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect,
335 DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement,
336 DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement,
337 DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement,
338 DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement,
339 DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement,
340 DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement,
341 DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement,
342 DOMSVGFEOffsetElement, DOMSVGFEPointLightElement,
343 DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement,
344 DOMSVGFETileElement, DOMSVGFETurbulenceElement,
345 DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList.
347 - Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint
352 - Make numOctaves in SVGFETurbulenceElement use a long instead of an int
353 in it's macro declaration and definition.
355 * DerivedSources.make:
356 * WebCore.xcodeproj/project.pbxproj:
357 * bindings/objc/DOMCSS.mm:
358 (+[DOMCSSValue _CSSValueWith:WebCore::]):
359 * bindings/objc/DOMInternal.h:
360 * bindings/objc/DOMSVG.h:
361 * bindings/objc/DOMSVGNumber.h: Added.
362 * bindings/objc/DOMSVGNumber.mm: Added.
363 (-[DOMSVGNumber dealloc]):
364 (-[DOMSVGNumber finalize]):
365 (-[DOMSVGNumber value]):
366 (-[DOMSVGNumber setValue:]):
367 (-[DOMSVGNumber _SVGNumber]):
368 (-[DOMSVGNumber _initWithFloat:]):
369 (+[DOMSVGNumber _SVGNumberWith:]):
370 * bindings/objc/DOMSVGPoint.h: Added.
371 * bindings/objc/DOMSVGPoint.mm: Added.
372 (-[DOMSVGPoint dealloc]):
373 (-[DOMSVGPoint finalize]):
375 (-[DOMSVGPoint setX:]):
377 (-[DOMSVGPoint setY:]):
378 (-[DOMSVGPoint WebCore::]):
379 (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
380 (+[DOMSVGPoint _SVGPointWith:WebCore::]):
381 * bindings/objc/DOMSVGRect.h: Added.
382 * bindings/objc/DOMSVGRect.mm: Added.
383 (-[DOMSVGRect dealloc]):
384 (-[DOMSVGRect finalize]):
386 (-[DOMSVGRect setX:]):
388 (-[DOMSVGRect setY:]):
389 (-[DOMSVGRect width]):
390 (-[DOMSVGRect setWidth:]):
391 (-[DOMSVGRect height]):
392 (-[DOMSVGRect setHeight:]):
393 (-[DOMSVGRect WebCore::]):
394 (-[DOMSVGRect _initWithFloatRect:WebCore::]):
395 (+[DOMSVGRect _SVGRectWith:WebCore::]):
396 * bindings/scripts/CodeGeneratorObjC.pm:
397 * ksvg2/svg/SVGAnimatedNumberList.idl:
398 * ksvg2/svg/SVGAnimatedRect.idl:
399 * ksvg2/svg/SVGComponentTransferFunctionElement.idl:
400 * ksvg2/svg/SVGCursorElement.idl:
401 * ksvg2/svg/SVGFEBlendElement.idl:
402 * ksvg2/svg/SVGFEColorMatrixElement.idl:
403 * ksvg2/svg/SVGFEComponentTransferElement.idl:
404 * ksvg2/svg/SVGFECompositeElement.idl:
405 * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
406 * ksvg2/svg/SVGFEDisplacementMapElement.idl:
407 * ksvg2/svg/SVGFEDistantLightElement.idl:
408 * ksvg2/svg/SVGFEFloodElement.idl:
409 * ksvg2/svg/SVGFEFuncAElement.idl:
410 * ksvg2/svg/SVGFEFuncBElement.idl:
411 * ksvg2/svg/SVGFEFuncGElement.idl:
412 * ksvg2/svg/SVGFEFuncRElement.idl:
413 * ksvg2/svg/SVGFEGaussianBlurElement.idl:
414 * ksvg2/svg/SVGFEImageElement.idl:
415 * ksvg2/svg/SVGFEMergeElement.idl:
416 * ksvg2/svg/SVGFEMergeNodeElement.idl:
417 * ksvg2/svg/SVGFEOffsetElement.idl:
418 * ksvg2/svg/SVGFEPointLightElement.idl:
419 * ksvg2/svg/SVGFESpecularLightingElement.idl:
420 * ksvg2/svg/SVGFESpotLightElement.idl:
421 * ksvg2/svg/SVGFETileElement.idl:
422 * ksvg2/svg/SVGFETurbulenceElement.cpp:
423 * ksvg2/svg/SVGFETurbulenceElement.h:
424 * ksvg2/svg/SVGFETurbulenceElement.idl:
425 * ksvg2/svg/SVGNumberList.idl:
427 2006-10-06 Adam Roben <aroben@apple.com>
429 Backing out my previous change.
431 * WebCore.xcodeproj/project.pbxproj:
432 * page/FrameView.cpp:
433 (WebCore::FrameView::adjustViewSize):
435 2006-10-06 Adam Roben <aroben@apple.com>
439 * WebCore.xcodeproj/project.pbxproj:
440 * page/FrameView.cpp:
441 (WebCore::FrameView::windowResizerRect):
443 2006-10-06 Adam Roben <aroben@apple.com>
449 * platform/ResourceLoader.h:
450 * platform/ResourceLoaderInternal.h:
451 (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
452 * platform/win/TemporaryLinkStubs.cpp:
453 (WebCore::ResourceLoader::newHTTPRequest):
455 2006-10-05 Steve Falkenburg <sfalken@apple.com>
459 Stub out some methods that we'll be able to use to dodge a window resizer.
461 * bridge/win/FrameWin.h:
463 (WebCore::Frame::windowResizerRect):
465 * platform/ScrollView.h:
466 (WebCore::ScrollView::windowResizerRect):
468 * platform/win/TemporaryLinkStubs.cpp:
469 (FrameView::windowResizerRect):
472 (FrameWin::windowResizerRect):
474 2006-10-05 Dave Hyatt <hyatt@apple.com>
476 Stub out setFrameGeometry.
478 * platform/ScrollView.h:
480 2006-10-05 Adele Peterson <adele@apple.com>
482 Reverting autoscroll fix. I need to rework this a little.
485 (WebCore::Frame::handleAutoscroll):
486 (WebCore::Frame::autoscrollTimerFired):
487 (WebCore::Frame::stopAutoscrollTimer):
489 * rendering/RenderLayer.cpp:
490 (WebCore::RenderLayer::~RenderLayer):
491 * rendering/RenderListBox.cpp:
492 (WebCore::RenderListBox::~RenderListBox):
494 2006-10-05 Alice <alice.liu@apple.com>
498 Fixed <rdar://problem/4731778>
500 * editing/CommandByName.cpp:
501 (WebCore::Frame::Command::):
502 was calling the wrong enabledFn for arrow selection and navigation
504 2006-10-05 Adele Peterson <adele@apple.com>
508 - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text">
509 and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
511 * rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
512 * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
514 * page/Frame.cpp: Added getter and setter for the renderer being autoscrolled.
515 (WebCore::Frame::handleAutoscroll):
516 (WebCore::Frame::autoscrollTimerFired):
517 (WebCore::Frame::autoscrollRenderer):
518 (WebCore::Frame::setAutoscrollRenderer):
519 (WebCore::Frame::stopAutoscrollTimer):
522 2006-10-05 Don Gibson <dgibson77@gmail.com>
526 Fix win32 build bustage after ggaren's Scrollbar renaming changes.
527 Properly include PlatformScrollBar.h in WbCore.vcproj.
528 Clean up WidgetWin.cpp a bit.
530 * WebCore.vcproj/WebCore/WebCore.vcproj:
532 * platform/win/PlatformScrollBar.h:
533 * platform/win/ScrollViewWin.cpp:
534 (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
535 (WebCore::ScrollView::resizeContents):
536 (WebCore::ScrollView::scrollBy):
537 (WebCore::ScrollView::hScrollbarMode):
538 (WebCore::ScrollView::vScrollbarMode):
539 (WebCore::ScrollView::suppressScrollbars):
540 (WebCore::ScrollView::setHScrollbarMode):
541 (WebCore::ScrollView::setVScrollbarMode):
542 (WebCore::ScrollView::setScrollbarsMode):
543 (WebCore::ScrollView::updateScrollbars):
544 * platform/win/TemporaryLinkStubs.cpp:
545 (FrameView::passMousePressEventToScrollbar):
546 (Widget::removeFromParent):
547 (ScrollView::scrollbarUnderMouse):
548 (PlatformScrollbar::PlatformScrollbar):
549 (PlatformScrollbar::~PlatformScrollbar):
550 (PlatformScrollbar::width):
551 (PlatformScrollbar::height):
552 (PlatformScrollbar::setEnabled):
553 (PlatformScrollbar::paint):
554 (PlatformScrollbar::updateThumbPosition):
555 (PlatformScrollbar::updateThumbProportion):
556 (PlatformScrollbar::setRect):
557 (Scrollbar::Scrollbar):
558 (Scrollbar::setSteps):
560 (Scrollbar::setValue):
561 (Scrollbar::setProportion):
562 * platform/win/WidgetWin.cpp:
563 (WebCore::WidgetPrivate::WidgetPrivate):
564 (WebCore::Widget::Widget):
565 (WebCore::Widget::setContainingWindow):
566 (WebCore::Widget::containingWindow):
568 2006-10-05 Geoffrey Garen <ggaren@apple.com>
572 * WebCore.xcodeproj/project.pbxproj:
573 * bridge/mac/BrowserExtensionMac.mm:
574 (WebCore::BrowserExtensionMac::createNewWindow):
575 * bridge/mac/FrameMac.mm:
576 (WebCore::FrameMac::createFrame):
577 * bridge/mac/FrameViewMac.mm:
578 (WebCore::FrameView::passMousePressEventToScrollbar):
579 * bridge/mac/WebCoreFrameBridge.mm:
580 (-[WebCoreFrameBridge installInFrame:]):
581 * bridge/mac/WebCoreFrameView.h:
582 * platform/ScrollBar.cpp:
584 * platform/mac/PlatformScrollBar.h:
585 * platform/mac/PlatformScrollBarMac.mm:
586 (NSControlSizeForScrollBarControlSize):
587 (-[WebCoreScrollBar initWithPlatformScrollbar:]):
588 (-[WebCoreScrollBar detachPlatformScrollbar]):
589 (-[WebCoreScrollBar scroll:]):
590 (-[WebCoreScrollBar widget]):
591 (WebCore::PlatformScrollbar::PlatformScrollbar):
592 (WebCore::PlatformScrollbar::~PlatformScrollbar):
593 (WebCore::PlatformScrollbar::updateThumbPosition):
594 (WebCore::PlatformScrollbar::updateThumbProportion):
595 (WebCore::PlatformScrollbar::scrollbarHit):
596 (WebCore::PlatformScrollbar::width):
597 (WebCore::PlatformScrollbar::height):
598 (WebCore::PlatformScrollbar::setRect):
599 (WebCore::PlatformScrollbar::setEnabled):
600 (WebCore::PlatformScrollbar::paint):
601 * platform/mac/ScrollViewMac.mm:
602 (WebCore::ScrollView::setVScrollbarMode):
603 (WebCore::ScrollView::setHScrollbarMode):
604 (WebCore::ScrollView::setScrollbarsMode):
605 (WebCore::ScrollView::vScrollbarMode):
606 (WebCore::ScrollView::hScrollbarMode):
607 (WebCore::ScrollView::suppressScrollbars):
608 (WebCore::ScrollView::scrollbarUnderMouse):
609 * platform/mac/WidgetMac.mm:
610 (WebCore::Widget::removeFromParent):
611 * rendering/RenderLayer.cpp:
612 (WebCore::RenderLayer::destroyScrollbar):
614 2006-10-05 Geoffrey Garen <ggaren@apple.com>
619 * rendering/RenderLayer.cpp:
620 (WebCore::RenderLayer::destroyScrollbar):
622 2006-10-06 Mitz Pettel <mitz@webkit.org>
624 http://bugs.webkit.org/show_bug.cgi?id=8276
625 Fix broken manual test added back in r13990.
627 Add resource forks for test resources.
629 * manual-tests/resources/plain-text-paste/._1.textClipping: Added.
630 * manual-tests/resources/plain-text-paste/._2.textClipping: Added.
631 * manual-tests/resources/plain-text-paste/._4.txt: Added.
632 * manual-tests/resources/plain-text-paste/._5.webloc: Added.
634 2006-10-05 David Hyatt <hyatt@apple.com>
636 Rename addClip to clip.
640 * kcanvas/RenderForeignObject.cpp:
641 (WebCore::RenderForeignObject::paint):
642 * kcanvas/RenderSVGContainer.cpp:
643 (WebCore::RenderSVGContainer::paint):
644 * kcanvas/RenderSVGImage.cpp:
645 (WebCore::RenderSVGImage::paint):
646 * platform/GraphicsContext.h:
647 * platform/cairo/GraphicsContextCairo.cpp:
648 (WebCore::GraphicsContext::clip):
649 * platform/cg/GraphicsContextCG.cpp:
650 (WebCore::GraphicsContext::savePlatformState):
651 (WebCore::GraphicsContext::restorePlatformState):
652 (WebCore::GraphicsContext::clip):
653 (WebCore::GraphicsContext::addRoundedRectClip):
654 (WebCore::GraphicsContext::addInnerRoundedRectClip):
655 (WebCore::GraphicsContext::scale):
656 (WebCore::GraphicsContext::rotate):
657 (WebCore::GraphicsContext::translate):
658 (WebCore::GraphicsContext::concatCTM):
659 * platform/cg/GraphicsContextPlatformPrivate.h:
660 (WebCore::GraphicsContextPlatformPrivate::save):
661 (WebCore::GraphicsContextPlatformPrivate::restore):
662 (WebCore::GraphicsContextPlatformPrivate::clip):
663 (WebCore::GraphicsContextPlatformPrivate::scale):
664 (WebCore::GraphicsContextPlatformPrivate::rotate):
665 (WebCore::GraphicsContextPlatformPrivate::translate):
666 (WebCore::GraphicsContextPlatformPrivate::concatCTM):
667 * platform/qt/GraphicsContextQt.cpp:
668 (WebCore::GraphicsContext::clip):
669 (WebCore::GraphicsContext::addInnerRoundedRectClip):
670 (WebCore::GraphicsContext::addRoundedRectClip):
671 * rendering/InlineFlowBox.cpp:
672 (WebCore::InlineFlowBox::paintBackground):
673 (WebCore::InlineFlowBox::paintBackgroundAndBorder):
674 * rendering/InlineTextBox.cpp:
675 (WebCore::InlineTextBox::paintSelection):
676 (WebCore::InlineTextBox::paintTextMatchMarker):
677 * rendering/RenderBox.cpp:
678 (WebCore::RenderBox::paintBackgroundExtended):
679 * rendering/RenderButton.cpp:
680 (WebCore::RenderButton::paintObject):
681 * rendering/RenderFileUploadControl.cpp:
682 (WebCore::RenderFileUploadControl::paintObject):
683 * rendering/RenderLayer.cpp:
684 (WebCore::RenderLayer::beginTransparencyLayers):
686 * rendering/RenderListBox.cpp:
687 (WebCore::RenderListBox::paintObject):
688 * rendering/RenderMenuList.cpp:
689 (WebCore::RenderMenuList::paintObject):
690 * rendering/RenderTableCell.cpp:
691 (WebCore::RenderTableCell::paintBackgroundsBehindCell):
693 2006-10-05 Mitz Pettel <mitz@webkit.org>
697 - http://bugs.webkit.org/show_bug.cgi?id=10386
698 Delete RenderImageButton.* and remove references from .vcproj and .bkl files
701 * WebCore.vcproj/WebCore/WebCore.vcproj:
702 * WebCoreSources.bkl:
703 * rendering/RenderImageButton.cpp: Removed.
704 * rendering/RenderImageButton.h: Removed.
706 2006-10-05 Mitz Pettel <opendarwin.org@mitzpettel.com>
710 - http://bugs.webkit.org/show_bug.cgi?id=11067
711 manual-tests/scrollbar-hittest2.html is invalid
713 * manual-tests/scrollbar-hittest2.html:
715 2006-10-05 David Carson <dacarson@gmail.com>
719 http://bugs.webkit.org/show_bug.cgi?id=11152
720 Adjust the tokenizer chunk size to be smaller for
721 mobile devices, and also decrease the yield timer
722 for the tokenizer so that it can resume earlier.
724 * html/HTMLTokenizer.cpp:
727 2006-10-05 Adam Roben <aroben@apple.com>
729 Removing accidentally-checked-in do-nothing code.
731 * html/HTMLInputElement.cpp:
732 (WebCore::HTMLInputElement::defaultEventHandler):
734 2006-10-05 David Carson <dacarson@gmail.com>
738 http://bugs.webkit.org/show_bug.cgi?id=11158
739 Initialize class variables
741 * rendering/RenderLayer.cpp:
742 (WebCore::RenderLayer::RenderLayer):
744 2006-10-05 Don Gibson <dgibson77@gmail.com>
746 Reviewed by Darin, landed by Adam.
748 http://bugs.webkit.org/show_bug.cgi?id=11176
749 Fix win32 build, adapt to Maciej's ResourceLoader changes.
751 * platform/win/ResourceLoaderWin.cpp:
752 (WebCore::ResourceLoader::start):
754 2006-10-05 Marvin Decker <marv.decker@gmail.com>
758 http://bugs.webkit.org/show_bug.cgi?id=10989
759 Provide a way for embedders to implement BrowserExtensionWin
761 * WebCore.vcproj/WebCore/WebCore.vcproj:
762 * bridge/win/BrowserExtensionWin.cpp: Added.
763 (BrowserExtensionWin::BrowserExtensionWin):
764 (BrowserExtensionWin::setTypedIconURL):
765 (BrowserExtensionWin::setIconURL):
766 (BrowserExtensionWin::getHistoryLength):
767 (BrowserExtensionWin::canRunModal):
768 (BrowserExtensionWin::createNewWindow):
769 (BrowserExtensionWin::canRunModalNow):
770 (BrowserExtensionWin::runModal):
771 (BrowserExtensionWin::goBackOrForward):
772 (BrowserExtensionWin::historyURL):
773 * bridge/win/BrowserExtensionWin.h:
774 * bridge/win/FrameWin.cpp:
775 (WebCore::FrameWin::createNewWindow):
776 * bridge/win/FrameWin.h:
777 * platform/win/TemporaryLinkStubs.cpp:
779 2006-10-05 Geoffrey Garen <ggaren@apple.com>
783 Fixed <rdar://problem/4766987>
785 - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
786 except for file names.
788 - fixed RenderLayer to properly tear down scrollbars, removing them from
791 * bindings/js/kjs_window.cpp:
792 (KJS::showModalDialog):
793 (KJS::setWindowFeature):
794 (KJS::parseWindowFeatures):
795 * bridge/BrowserExtension.h:
797 (WebCore::Document::setInPageCache):
798 * html/HTMLFrameElement.cpp:
799 (WebCore::HTMLFrameElement::init):
800 (WebCore::HTMLFrameElement::parseMappedAttribute):
801 * html/HTMLFrameElement.h:
802 (WebCore::HTMLFrameElement::scrollingMode):
804 (WebCore::Frame::finishedParsing):
805 (WebCore::Frame::scrollbarsVisible):
806 * page/FrameView.cpp:
807 (WebCore::FrameViewPrivate::FrameViewPrivate):
808 (WebCore::FrameViewPrivate::reset):
809 (WebCore::FrameView::~FrameView):
810 (WebCore::FrameView::resetScrollbars):
811 (WebCore::FrameView::clear):
812 (WebCore::FrameView::initScrollbars):
813 (WebCore::FrameView::applyOverflowToViewport):
814 (WebCore::FrameView::layout):
815 (WebCore::FrameView::handleMousePressEvent):
816 (WebCore::selectCursor):
817 (WebCore::FrameView::handleMouseMoveEvent):
818 (WebCore::FrameView::setScrollbarsMode):
819 (WebCore::FrameView::setVScrollbarMode):
820 (WebCore::FrameView::setHScrollbarMode):
821 (WebCore::FrameView::restoreScrollbar):
822 (WebCore::FrameView::dispatchMouseEvent):
823 (WebCore::FrameView::scrollbarMoved):
825 * page/MouseEventWithHitTestResults.cpp:
826 (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
827 * page/MouseEventWithHitTestResults.h:
828 (WebCore::MouseEventWithHitTestResults::scrollbar):
829 * platform/ScrollBar.cpp:
830 (WebCore::Scrollbar::Scrollbar):
831 (WebCore::Scrollbar::setValue):
832 (WebCore::Scrollbar::setProportion):
833 (WebCore::Scrollbar::setSteps):
834 (WebCore::Scrollbar::scroll):
835 * platform/ScrollBar.h:
837 (WebCore::ScrollbarClient::~ScrollbarClient):
838 (WebCore::Scrollbar::~Scrollbar):
839 (WebCore::Scrollbar::orientation):
840 (WebCore::Scrollbar::controlSize):
841 (WebCore::Scrollbar::hasPlatformScrollbars):
842 (WebCore::Scrollbar::client):
843 * platform/ScrollBarMode.h:
845 * platform/ScrollView.h:
846 * rendering/RenderBlock.cpp:
847 (WebCore::RenderBlock::isPointInScrollbar):
848 * rendering/RenderLayer.cpp:
849 (WebCore::RenderLayer::RenderLayer):
850 (WebCore::RenderLayer::~RenderLayer):
851 (WebCore::RenderLayer::scrollToOffset):
852 (WebCore::RenderLayer::horizontaScrollbarWidget):
853 (WebCore::RenderLayer::verticalScrollbarWidget):
854 (WebCore::RenderLayer::valueChanged):
855 (WebCore::RenderLayer::createScrollbar):
856 (WebCore::RenderLayer::destroyScrollbar):
857 (WebCore::RenderLayer::setHasHorizontalScrollbar):
858 (WebCore::RenderLayer::setHasVerticalScrollbar):
859 (WebCore::RenderLayer::verticalScrollbarWidth):
860 (WebCore::RenderLayer::horizontalScrollbarHeight):
861 (WebCore::RenderLayer::updateScrollInfoAfterLayout):
862 * rendering/RenderLayer.h:
863 (WebCore::RenderLayer::horizontalScrollbar):
864 (WebCore::RenderLayer::verticalScrollbar):
865 * rendering/RenderListBox.cpp:
866 (WebCore::RenderListBox::~RenderListBox):
867 (WebCore::RenderListBox::calcMinMaxWidth):
868 (WebCore::RenderListBox::isPointInScrollbar):
869 (WebCore::RenderListBox::optionAtPoint):
870 (WebCore::RenderListBox::valueChanged):
871 * rendering/RenderListBox.h:
872 * rendering/RenderObject.h:
873 (WebCore::RenderObject::NodeInfo::scrollbar):
874 (WebCore::RenderObject::NodeInfo::setScrollbar):
876 2006-10-05 Don Gibson <dgibson77@gmail.com>
880 http://bugs.webkit.org/show_bug.cgi?id=11138
881 Incorrect mouse event generation on Windows
883 * platform/win/MouseEventWin.cpp:
884 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
885 (1) Set mouse button even for non-click-related messages.
886 (2) Track clicks correctly for all buttons, not just the left button.
888 2006-10-05 Nikolas Zimmermann <zimmermann@kde.org>
890 Reviewed and landed by ap.
892 Fix Qt/Linux build, adapt to Eric's quartz changes and to Maciej's ResourceLoader changes.
894 * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
895 (WebCore::KRenderingPaintServerLinearGradientQt::renderPath):
896 (WebCore::KRenderingPaintServerLinearGradientQt::setup):
897 (WebCore::KRenderingPaintServerRadialGradientQt::setup):
898 (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
899 * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
900 (WebCore::KRenderingPaintServerPatternQt::renderPath):
901 * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
902 (WebCore::KRenderingPaintServerQt::setPenProperties):
903 * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
904 (WebCore::KRenderingPaintServerSolidQt::setup):
905 (WebCore::KRenderingPaintServerSolidQt::renderPath):
906 * kcanvas/device/qt/RenderPathQt.cpp:
907 (WebCore::getPathStroke):
909 2006-10-05 Alexey Proskuryakov <ap@nypop.com>
913 http://bugs.webkit.org/show_bug.cgi?id=11054
914 REGRESSION: Traditional Chinese encoding in login authentication
916 1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
917 2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding
918 for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
920 * platform/StreamingTextDecoderICU.cpp:
921 (WebCore::TextCodecICU::registerEncodingNames):
923 2006-10-05 Eric Seidel <eric@eseidel.com>
928 Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
930 * WebCore.xcodeproj/project.pbxproj:
931 * ksvg2/ecma/GlobalObject.cpp: Removed.
932 * ksvg2/ecma/GlobalObject.h: Removed.
934 2006-10-05 Adam Roben <aroben@apple.com>
938 Small ResourceLoaderInternal tweak.
940 * platform/ResourceLoaderInternal.h:
941 (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
943 2006-10-05 Eric Seidel <eric@eseidel.com>
947 More incremental KCanvas cleanup and optimization.
948 Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
949 Optimized dash array usage to not malloc.
950 Also removed un-needed KSVGRenderingStyle includes.
952 * kcanvas/KCanvasTreeDebug.cpp:
953 (WebCore::operator<<):
954 * kcanvas/RenderPath.cpp:
955 (WebCore::RenderPath::nodeAtPoint):
956 * kcanvas/device/quartz/KCanvasItemQuartz.mm:
957 (WebCore::RenderPath::strokeBBox):
958 * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
959 (WebCore::KRenderingPaintServerGradientQuartz::setup):
960 (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
961 (WebCore::KRenderingPaintServerGradientQuartz::teardown):
962 * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
963 (WebCore::KRenderingPaintServerSolidQuartz::setup):
964 (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
965 (WebCore::KRenderingPaintServerPatternQuartz::setup):
966 (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
967 * kcanvas/device/quartz/QuartzSupport.mm:
968 (WebCore::applyStrokeStyleToContext):
969 * ksvg2/css/SVGRenderStyle.h:
970 (WebCore::SVGRenderStyle::hasStroke):
971 (WebCore::SVGRenderStyle::hasFill):
972 * ksvg2/misc/KCanvasRenderingStyle.cpp:
973 (WebCore::KSVGPainterFactory::fillPaintServer):
974 (WebCore::KSVGPainterFactory::strokePaintServer):
975 * ksvg2/misc/KCanvasRenderingStyle.h:
977 2006-10-05 Maciej Stachowiak <mjs@apple.com>
981 - changed ResourceLoader to be refcounted
983 It keeps a ref on itself while loading as well. This makes
984 for a much saner memory management model than the previous.
986 * bridge/mac/WebCoreResourceLoaderImp.mm:
987 (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
988 * dom/XMLTokenizer.cpp:
990 * loader/icon/IconLoader.cpp:
991 (IconLoader::IconLoader):
992 (IconLoader::~IconLoader):
993 (IconLoader::startLoading):
994 (IconLoader::stopLoading):
995 (IconLoader::receivedData):
996 * loader/icon/IconLoader.h:
998 (WebCore::Loader::servePendingRequests):
999 * platform/ResourceLoader.cpp:
1000 (WebCore::ResourceLoader::create):
1001 (WebCore::ResourceLoader::kill):
1002 * platform/ResourceLoader.h:
1003 * platform/ResourceLoaderInternal.h:
1004 (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1005 * platform/mac/ResourceLoaderMac.mm:
1006 (WebCore::ResourceLoader::start):
1007 * xml/XSLTProcessor.cpp:
1008 (WebCore::docLoaderFunc):
1009 * xml/xmlhttprequest.cpp:
1010 (WebCore::XMLHttpRequest::send):
1011 * xml/xmlhttprequest.h:
1013 2006-10-05 Eric Seidel <eric@eseidel.com>
1017 Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
1018 http://bugs.webkit.org/show_bug.cgi?id=11163
1020 No SVG performance tests yet.
1022 * kcanvas/RenderForeignObject.cpp:
1023 (WebCore::RenderForeignObject::paint):
1024 * kcanvas/RenderSVGContainer.cpp:
1025 (WebCore::RenderSVGContainer::paint):
1026 * kcanvas/RenderSVGImage.cpp:
1027 (WebCore::RenderSVGImage::paint):
1028 * kcanvas/RenderSVGText.cpp:
1029 (WebCore::RenderSVGText::paint):
1031 2006-10-05 Dave Hyatt <hyatt@apple.com>
1033 Stub out some stuff for widget focusability.
1037 * page/FrameView.cpp:
1038 (WebCore::FrameView::dispatchMouseEvent):
1039 * platform/ScrollView.h:
1040 * platform/Widget.h:
1042 2006-10-05 Adam Roben <aroben@apple.com>
1044 Reviewed by Maciej and Tim H.
1046 Copy some WebKit frame lifetime logic into WebCore -- just a step
1047 along the path to frame lifetime being handled completely in WebCore.
1049 * bridge/mac/FrameMac.mm:
1050 (WebCore::FrameMac::setView): Move platform-independent parts of this
1053 (WebCore::Frame::setView): Adding platform-independent parts of
1055 (WebCore::Frame::detachChildren): New method to accomplish what
1056 -[WebFrameBridge _detachChildren] currently does.
1057 (WebCore::Frame::clear): Call detachChildren
1058 * page/Frame.h: Add declaration for detachChildren
1060 2006-10-04 Alice Liu <alice.liu@apple.com>
1064 Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query
1066 * xml/xmlhttprequest.cpp:
1067 (WebCore::XMLHttpRequest::setRequestHeader):
1068 removed exception set when the request is not open yet
1070 2006-10-04 Anders Carlsson <acarlsson@apple.com>
1072 Reviewed by John Sullivan.
1074 <rdar://problem/4654328>
1075 Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
1077 * loader/PluginDocument.cpp:
1078 (WebCore::PluginTokenizer::writeRawData):
1079 Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
1081 2006-10-03 Alexey Proskuryakov <ap@nypop.com>
1085 http://bugs.webkit.org/show_bug.cgi?id=11130
1086 Convert "undefined" to AE missing value
1088 * bridge/mac/WebCoreFrameBridge.mm:
1089 (aeDescFromJSValue): return missing value for UndefinedType.
1091 2006-10-03 Dave Hyatt <hyatt@apple.com>
1093 Scrolling work. Eliminate convertTo/FromContainingWindow as cross-platform functions. Add back in
1094 the windowToContents/contentsToWindow functions.
1098 * bridge/mac/FrameMac.mm:
1099 (WebCore::FrameMac::eventMayStartDrag):
1100 (WebCore::FrameMac::dragHysteresisExceeded):
1101 (WebCore::FrameMac::mouseDown):
1102 (WebCore::FrameMac::shouldDragAutoNode):
1103 (WebCore::FrameMac::sendContextMenuEvent):
1104 * bridge/mac/FrameViewMac.mm:
1105 (WebCore::FrameView::passMousePressEventToScrollbar):
1106 * bridge/mac/WebCoreFrameBridge.mm:
1107 (-[WebCoreFrameBridge _visiblePositionForPoint:]):
1108 * dom/EventTargetNode.cpp:
1109 (WebCore::EventTargetNode::dispatchMouseEvent):
1110 (WebCore::EventTargetNode::dispatchWheelEvent):
1112 (WebCore::Frame::selectClosestWordFromMouseEvent):
1113 (WebCore::Frame::handleMousePressEventTripleClick):
1114 (WebCore::Frame::handleMousePressEventSingleClick):
1115 (WebCore::Frame::handleMouseMoveEvent):
1116 (WebCore::Frame::handleMouseReleaseEvent):
1117 * page/FrameView.cpp:
1118 (WebCore::FrameView::handleMousePressEvent):
1119 (WebCore::FrameView::handleMouseDoubleClickEvent):
1120 (WebCore::selectCursor):
1121 (WebCore::FrameView::handleMouseMoveEvent):
1122 (WebCore::FrameView::handleMouseReleaseEvent):
1123 (WebCore::FrameView::dispatchDragEvent):
1124 (WebCore::FrameView::prepareMouseEvent):
1125 (WebCore::FrameView::handleWheelEvent):
1127 * platform/ScrollBar.cpp:
1128 (WebCore::ScrollBar::setValue):
1129 * platform/ScrollView.h:
1130 * platform/Widget.h:
1131 (WebCore::Widget::scrolled):
1132 * platform/mac/ScrollViewMac.mm:
1133 (WebCore::ScrollView::contentsToWindow):
1134 (WebCore::ScrollView::windowToContents):
1135 (WebCore::ScrollView::scrollbarUnderMouse):
1136 * platform/mac/WidgetMac.mm:
1137 * rendering/RenderLayer.cpp:
1138 (WebCore::RenderLayer::resize):
1139 (WebCore::RenderLayer::positionScrollbars):
1140 * rendering/RenderReplaced.cpp:
1141 (WebCore::RenderReplaced::shouldPaint):
1142 * rendering/RenderView.cpp:
1143 * rendering/RenderView.h:
1144 * rendering/RenderWidget.cpp:
1145 (WebCore::RenderWidget::setWidget):
1147 2006-09-26 David Smith <catfish.man@gmail.com>
1149 Reviewed by Timothy.
1151 http://bugs.webkit.org/show_bug.cgi?id=3723
1152 Add -scrollDOMRangeToVisible:
1154 No automated tests are possible as this code path isn't reachable from JavaScript.
1156 * bridge/mac/WebCoreFrameBridge.h:
1157 * bridge/mac/WebCoreFrameBridge.mm:
1158 (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
1160 2006-10-03 Graham Dennis <graham.dennis@gmail.com>
1162 Reviewed by Timothy.
1164 <http://bugs.webkit.org/show_bug.cgi?id=10338>
1165 When contentEditable, cursor doesn't change to hand
1167 Allow the behaviour of editable links to be specified by a WebPreference
1168 The preference WebKitEditableLinkBehavior has four options:
1169 - AlwaysLive: Safari 2.0 behaviour
1170 - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
1171 - LiveWhenNotFocused: Editable links are live only when their editable block is not
1172 focused, or when the shift key is pressed
1173 - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
1175 No layout tests, just a modification of a manual-test as it isn't possible to test
1178 * bridge/mac/WebCoreSettings.h:
1179 * bridge/mac/WebCoreSettings.mm:
1180 (-[WebCoreSettings setEditableLinkBehavior:]):
1181 (-[WebCoreSettings editableLinkBehavior]):
1182 * html/HTMLAnchorElement.cpp:
1183 (WebCore::HTMLAnchorElement::HTMLAnchorElement):
1184 (WebCore::HTMLAnchorElement::defaultEventHandler):
1185 (WebCore::HTMLAnchorElement::setActive):
1186 * html/HTMLAnchorElement.h:
1187 * manual-tests/contenteditable-link.html:
1188 * page/FrameView.cpp:
1189 (WebCore::nodeIsNotBeingEdited):
1190 (WebCore::selectCursor):
1192 (WebCore::Settings::):
1193 (WebCore::Settings::Settings):
1194 (WebCore::Settings::editableLinkBehavior):
1195 (WebCore::Settings::setEditableLinkBehavior):
1197 2006-10-03 Beth Dakin <bdakin@apple.com>
1201 No test cases needed.
1203 Implemented a version of StringImpl::append that takes a UChar* and
1206 * platform/StringImpl.cpp:
1207 (WebCore::StringImpl::append):
1208 (WebCore::StringImpl::insert): Call new append instead of making a
1210 * platform/StringImpl.h:
1212 2006-10-03 MorganL <morganl.webkit@yahoo.com>
1216 Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
1217 HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
1219 * platform/win/ResourceLoaderWin.cpp:
1220 (WebCore::ResourceLoader::onHandleCreated):
1222 2006-10-02 Geoffrey Garen <ggaren@apple.com>
1224 Feared, loathed, reviewed by Darin.
1226 More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach
1227 into FRAME, plus other cleanup.
1229 No new behavior, so no new test. Layout tests pass. Basic browsing and
1230 Mail editing seem to work.
1233 (WebCore::Node::detach): Removed random commented-out code.
1234 * html/HTMLFrameElement.cpp:
1235 (WebCore::HTMLFrameElement::isURLAllowed):
1236 (1) Removed reference to FrameView, to dissociate frame loading from rendering.
1237 (2) Renamed newURL to completeURL because the difference between newURL
1238 and URLString is that newURL is a KURL that is the complete version of URLString,
1240 (WebCore::HTMLFrameElement::willRemove):
1241 (1) Removed close() call and moved close() code into willRemove(), also removing
1242 close() call from detach(), since willRemove is the well-defined place
1243 from DOM tear-down, not detach().
1244 (2) Removed manual renderer detach code because the DOM is not responsible
1245 for managing the render tree. I confirmed that this change not
1246 regress <rdar://problem/4132581>.
1247 (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
1248 lost their content frames after being removed from the DOM. That's our
1249 current behavior, but it's going to change in future rounds of refactoring.
1250 This also fixes <rdar://problem/4750835>.
1251 (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
1252 attach/detach, because the render tree should not be in charge of deciding
1254 * html/HTMLFrameElement.h:
1255 * html/HTMLIFrameElement.cpp:
1256 (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
1257 because the renderer is a renderPartObject, not a renderPart.
1258 * html/HTMLIFrameElement.h:
1260 2006-10-03 Mark Rowe <bdash@webkit.org>
1264 http://bugs.webkit.org/show_bug.cgi?id=11137
1265 Bug 11137: GdkLauncher dies with "pure virtual method called" if
1266 window is closed while page still loading
1268 * platform/gdk/FrameGdk.cpp:
1269 (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
1270 methods to be called before the FrameGdk portion of "this" is torn down.
1272 2006-10-03 Adam Roben <aroben@apple.com>
1276 Handle tab key presses in the DOM.
1278 * dom/EventTargetNode.cpp:
1279 (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
1280 * page/FrameView.cpp:
1281 (WebCore::FrameView::advanceFocus): Rename and reimplement
1282 focusNextPrevNode. Now we just call Element::focus().
1283 * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
1286 2006-10-03 Justin Garcia <justin.garcia@apple.com>
1290 <rdar://problem/4760612>
1291 TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
1293 No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
1296 (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming
1297 positions are non-null since most of it's callers would be in a bad state if the positions
1298 were null. boundaryPointsValid, which calls compareBoundaryPoints, is an exception.
1299 Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it
1300 from entering compareBoundaryPoints and hitting the assert.
1302 2006-10-03 Adele Peterson <adele@apple.com>
1306 Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
1308 * html/HTMLSelectElement.cpp:
1309 (WebCore::HTMLSelectElement::recalcStyle):
1310 (WebCore::HTMLSelectElement::isKeyboardFocusable):
1311 (WebCore::HTMLSelectElement::isMouseFocusable):
1312 (WebCore::HTMLSelectElement::createRenderer):
1313 (WebCore::HTMLSelectElement::setRecalcListItems):
1314 (WebCore::HTMLSelectElement::notifyOptionSelected):
1315 (WebCore::HTMLSelectElement::defaultEventHandler):
1317 2006-10-04 Darin Adler <darin@apple.com>
1321 - fix http://bugs.webkit.org/show_bug.cgi?id=11132
1322 Caret disappears when you're typing
1324 * editing/SelectionController.cpp:
1325 (WebCore::SelectionController::setSelection): Remove unnecessary call to
1326 clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
1327 (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
1328 to false so we can get the old caret repaint rect. Later we need to change the
1329 design so getting the rect doesn't have a side effect of causing a layout without
1332 2006-10-03 David Harrison <harrison@apple.com>
1336 <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
1339 * fast/text/justified-text-rect.html
1341 * bridge/mac/WebCoreFrameBridge.mm:
1342 (-[WebCoreFrameBridge convertToNSRange:]):
1343 (-[WebCoreFrameBridge convertToDOMRange:]):
1344 Make the selection's root editable element (or the document itself) be
1345 the basis for NSRange conversions. This supports "shadow DOM" like
1346 that for text fields and text areas.
1348 * editing/CompositeEditCommand.cpp:
1349 (WebCore::CompositeEditCommand::moveParagraphs):
1350 Pass the document element as the scope.
1352 * editing/TextIterator.cpp:
1353 (WebCore::TextIterator::rangeFromLocationAndLength):
1354 Make the first parameter the scope.
1356 * editing/TextIterator.h:
1357 Make the first parameter of rangeFromLocationAndLength() the scope.
1359 2006-10-03 Nikolas Zimmermann <zimmermann@kde.org>
1365 * CMakeLists.txt: Add counter related files.
1367 2006-10-03 Mark Rowe <bdash@webkit.org>
1371 http://bugs.webkit.org/show_bug.cgi?id=10981
1372 Linux/GDK build fixes
1374 Based on a patch by Krzysztof Kowalczyk.
1376 * WebCoreSources.bkl:
1377 * platform/gdk/FrameGdk.cpp:
1378 (WebCore::doScroll):
1379 (WebCore::FrameGdk::handleGdkEvent):
1380 * platform/gdk/PlatformScrollBar.h: Added.
1381 (WebCore::PlatformScrollBar::isWidget):
1382 * platform/gdk/ScrollViewGdk.cpp:
1383 * platform/gdk/TemporaryLinkStubs.cpp:
1384 (FrameView::passMousePressEventToScrollbar):
1385 (FrameView::passMousePressEventToSubframe):
1386 (FrameView::passMouseReleaseEventToSubframe):
1387 (FrameView::passMouseMoveEventToSubframe):
1388 (FrameView::passWheelEventToSubframe):
1390 (Widget::invalidate):
1391 (Widget::invalidateRect):
1392 (ScrollView::wheelEvent):
1393 (ScrollView::convertToContainingWindow):
1394 (ScrollView::convertFromContainingWindow):
1395 (GraphicsContext::clip):
1396 (PlatformScrollBar::PlatformScrollBar):
1397 (PlatformScrollBar::updateThumbPosition):
1398 (PlatformScrollBar::updateThumbProportion):
1399 (ScrollBar::ScrollBar):
1400 (ScrollBar::setProportion):
1401 (WebCore::supportedKeySizes):
1402 (WebCore::signedPublicKeyAndChallengeString):
1403 * platform/gdk/WheelEventGdk.cpp:
1404 (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1405 * platform/gdk/WidgetGdk.cpp:
1406 (WebCore::Widget::convertToContainingWindow):
1407 (WebCore::Widget::convertFromContainingWindow):
1409 2006-10-02 Adam Roben <aroben@apple.com>
1413 Let Windows determine which mouse button is pressed.
1415 * platform/PlatformMouseEvent.h: Add message parameter to constructor.
1416 * platform/win/MouseEventWin.cpp:
1417 (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
1418 parameter to determine which mouse button is pressed.
1420 2006-10-02 Justin Garcia <justin.garcia@apple.com>
1426 * editing/SelectionController.cpp:
1427 (WebCore::SelectionController::empty):
1428 * editing/SelectionController.h:
1430 2006-10-02 Justin Garcia <justin.garcia@apple.com>
1434 <rdar://problem/4755287>
1435 Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
1437 * editing/markup.cpp:
1438 (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced
1439 elements). Don't skip blocks that aren't containers (like horizontal rules).
1441 2006-10-03 Darin Adler <darin@apple.com>
1443 Reviewed by Justin Garcia.
1445 - correct mistaken code that would restart blinking every
1446 time "invalidateSelection" is called even if the caret
1449 * editing/SelectionController.h:
1450 * editing/SelectionController.cpp:
1451 (WebCore::SelectionController::setSelection): Update for name change.
1452 (WebCore::SelectionController::recomputeCaretRect): New function.
1453 Computes caret rect and does any necessary invalidation if the rect
1455 (WebCore::SelectionController::invalidateCaretRect): Renamed from
1456 needsCaretRepaint. Invalidates the caret rect unconditionally. Also
1457 calls recomputeCaretRect as a side effect.
1460 (WebCore::Frame::invalidateSelection): Remove unneeded call to
1461 clearCaretRectIfNeeded.
1462 (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
1463 (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
1464 recomputeCaretRect function and not restart blinking if caret has
1465 not changed position.
1466 (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
1467 are not needed since selectionLayoutChanged already checks these.
1469 * page/FramePrivate.h: Removed unused m_blinkCaret.
1471 2006-10-02 Beth Dakin <bdakin@apple.com>
1475 Build fix. Add counters to vcproj.
1477 * WebCore.vcproj/WebCore/WebCore.vcproj:
1479 2006-10-02 Brady Eidson <beidson@apple.com>
1483 If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
1484 icon data out because we don't correctly check SQL error conditions.
1486 * loader/icon/IconDataCache.cpp:
1487 (WebCore::IconDataCache::writeToDatabase):
1489 2006-10-02 Steve Falkenburg <sfalken@apple.com>
1493 Added method to find out whether a layout has occurred.
1495 * page/FrameView.cpp:
1496 (WebCore::FrameView::didFirstLayout):
1499 2006-10-02 Beth Dakin <bdakin@apple.com>
1503 Initial implementation of CSS2 counters. See http://
1504 bugs.webkit.org/show_bug.cgi?id=4980 for more details.
1506 * WebCore.xcodeproj/project.pbxproj:
1507 * css/CSSComputedStyleDeclaration.cpp:
1508 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return
1509 the increment/reset list now that this is implemented.
1510 * css/CSSPrimitiveValue.cpp:
1511 (WebCore::CSSPrimitiveValue::cssText):
1513 (WebCore::Counter::Counter):
1514 (WebCore::Counter::~Counter):
1515 (WebCore::Counter::identifier):
1516 (WebCore::Counter::listStyle):
1517 (WebCore::Counter::separator):
1518 (WebCore::Counter::listStyleNumber):
1519 (WebCore::Counter::setIdentifier):
1520 (WebCore::Counter::setListStyle):
1521 (WebCore::Counter::setSeparator):
1522 * css/cssparser.cpp:
1523 (WebCore::CSSParser::addProperty): Take care of reset/increment
1524 (WebCore::CSSParser::parseValue):
1525 (WebCore::CSSParser::parseContent): content can now take counters
1526 (WebCore::CSSParser::parseCounterContent): Parse counter() and
1528 (WebCore::CSSParser::parseCounter): Parse counter-reset and
1531 * css/cssstyleselector.cpp:
1532 (WebCore::CSSStyleSelector::matchUARules):
1533 (WebCore::CSSStyleSelector::applyProperty):
1534 * platform/PlatformString.h:
1535 * platform/String.cpp:
1536 (WebCore::String::insert): Implemented a version of insert that
1537 accepts a UChar* and a length.
1538 * platform/StringImpl.cpp:
1539 (WebCore::StringImpl::insert): Same as above.
1540 * platform/StringImpl.h:
1541 * rendering/CounterListItem.h: Added.
1542 * rendering/CounterNode.cpp: Added.
1543 (WebCore::CounterNode::CounterNode):
1544 (WebCore::CounterNode::insertAfter):
1545 (WebCore::CounterNode::removeChild):
1546 (WebCore::CounterNode::remove):
1547 (WebCore::CounterNode::setUsesSeparator):
1548 (WebCore::CounterNode::recountAndGetNext):
1549 (WebCore::CounterNode::recountTree):
1550 (WebCore::CounterNode::setSelfDirty):
1551 (WebCore::CounterNode::setParentDirty):
1552 * rendering/CounterNode.h: Added.
1553 (WebCore::CounterNode::~CounterNode):
1554 (WebCore::CounterNode::parent):
1555 (WebCore::CounterNode::previousSibling):
1556 (WebCore::CounterNode::nextSibling):
1557 (WebCore::CounterNode::firstChild):
1558 (WebCore::CounterNode::lastChild):
1559 (WebCore::CounterNode::value):
1560 (WebCore::CounterNode::setValue):
1561 (WebCore::CounterNode::count):
1562 (WebCore::CounterNode::setCount):
1563 (WebCore::CounterNode::setHasSeparator):
1564 (WebCore::CounterNode::isReset):
1565 (WebCore::CounterNode::hasSeparator):
1566 (WebCore::CounterNode::willNeedLayout):
1567 (WebCore::CounterNode::setWillNeedLayout):
1568 (WebCore::CounterNode::isRoot):
1569 (WebCore::CounterNode::setRenderer):
1570 (WebCore::CounterNode::renderer):
1571 * rendering/CounterResetNode.cpp: Added.
1572 (WebCore::CounterResetNode::CounterResetNode):
1573 (WebCore::CounterResetNode::insertAfter):
1574 (WebCore::CounterResetNode::removeChild):
1575 (WebCore::CounterResetNode::recountAndGetNext):
1576 (WebCore::CounterResetNode::setParentDirty):
1577 (WebCore::CounterResetNode::updateTotal):
1578 * rendering/CounterResetNode.h: Added.
1579 (WebCore::CounterResetNode::firstChild):
1580 (WebCore::CounterResetNode::lastChild):
1581 (WebCore::CounterResetNode::isReset):
1582 (WebCore::CounterResetNode::total):
1583 * rendering/RenderContainer.cpp:
1584 (WebCore::RenderContainer::updatePseudoChildForObject): Account for
1586 * rendering/RenderCounter.cpp: Added.
1587 (WebCore::RenderCounter::RenderCounter):
1588 (WebCore::RenderCounter::layout):
1590 (WebCore::toLetterString):
1591 (WebCore::toHebrew):
1592 (WebCore::RenderCounter::convertValueToType):
1593 (WebCore::RenderCounter::calcMinMaxWidth):
1594 * rendering/RenderCounter.h: Added.
1595 (WebCore::RenderCounter::renderName):
1596 (WebCore::RenderCounter::isCounter):
1597 * rendering/RenderObject.cpp:
1598 (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to
1599 maps of CounterNodes
1600 (WebCore::RenderObject::RenderObject):
1601 (WebCore::RenderObject::destroy): Destroy the maps.
1602 (WebCore::RenderObject::findCounter): Finds/creates counters.
1603 * rendering/RenderObject.h:
1604 (WebCore::RenderObject::isCounter):
1605 * rendering/RenderStyle.cpp:
1606 (WebCore::StyleVisualData::StyleVisualData):
1607 (WebCore::RenderStyle::arenaDelete):
1608 (WebCore::RenderStyle::RenderStyle):
1609 (WebCore::RenderStyle::diff):
1610 (WebCore::RenderStyle::setContent):
1611 (WebCore::ContentData::clearContent):
1612 (WebCore::RenderStyle::counterDataEquivalent):
1613 (WebCore::hasCounter):
1614 (WebCore::RenderStyle::hasCounterReset):
1615 (WebCore::RenderStyle::hasCounterIncrement):
1616 (WebCore::readCounter):
1617 (WebCore::RenderStyle::counterReset):
1618 (WebCore::RenderStyle::counterIncrement):
1619 * rendering/RenderStyle.h:
1620 (WebCore::StyleVisualData::operator==):
1621 (WebCore::CounterData::CounterData):
1622 (WebCore::CounterData::identifier):
1623 (WebCore::CounterData::listStyle):
1624 (WebCore::CounterData::separator):
1625 (WebCore::ContentData::contentCounter):
1626 (WebCore::ContentData::):
1627 (WebCore::RenderStyle::counterIncrement):
1628 (WebCore::RenderStyle::counterReset):
1629 (WebCore::RenderStyle::setCounterIncrement):
1630 (WebCore::RenderStyle::setCounterReset):
1631 (WebCore::RenderStyle::setCounterResetList):
1632 (WebCore::RenderStyle::setCounterIncrementList):
1633 (WebCore::RenderStyle::counterResetValueList):
1634 (WebCore::RenderStyle::counterIncrementValueList):
1636 2006-10-02 Adele Peterson <adele@apple.com>
1640 - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
1642 There are a few outstanding issues, so I've left the old code in for now. So you can use the old-style listboxes
1643 by using "-webkit-appearance:none".
1647 2006-10-02 David Harrison <harrison@apple.com>
1649 Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
1650 addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
1651 Left the layout test.
1653 * rendering/bidi.cpp:
1654 (WebCore::checkMidpoints):
1656 2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>
1658 Reviewed by eseidel. Landed by eseidel.
1662 * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
1663 (WebCore::supportedKeySizes):
1665 2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>
1667 Reviewed by eseidel & mjs. Landed by eseidel.
1669 Fix Qt/Linux build with older gcc 3.3.4.
1670 http://bugs.webkit.org/show_bug.cgi?id=11116
1672 As discussed with Maciej, the GCC_ROOT_NS_HACK
1673 can be completely removed, as well as the friendship
1674 between cacheGlobalObject & the JS* objects.
1676 * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
1677 * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
1678 (png_read_filter_row_mmx_avg):
1679 * platform/image-decoders/png/pngvcrd.c: Ditto.
1681 (png_read_filter_row_mmx_avg):
1683 2006-10-01 Maciej Stachowiak <mjs@apple.com>
1685 Rubber stamped by Alexey.
1687 - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes
1691 2006-10-01 Eric Seidel <eric@webkit.org>
1695 Eliminate a few more hotspots in SVG drawing code.
1697 No test cases were harmed in the making of this patch. (And SVG has no perf tests.)
1699 * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1700 (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
1701 * platform/mac/ColorMac.mm:
1702 (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance
1704 2006-10-01 Geoffrey Garen <ggaren@apple.com>
1708 More frame/iframe merging.
1710 - Removed needWidgetUpdate and related code. needWidgetUpdate is always
1711 false, so this was dead code.
1712 - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
1713 than attach(), is the correct place for setInViewSourceMode, because
1714 openURL() is the function that creates our frame.
1715 - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
1716 code that did the same thing in other places.
1717 - Made FRAME's attach() method suffuciently generic so that IFRAME could
1718 call up to it, rather than skipping its superclass and calling up directly
1720 - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
1721 - Replaced ad hoc frame loading code in FRAME::attach() with call to
1722 openURL(), the designated frame loading function.
1724 Layout tests pass. I added a layout test for viewsource mode, since I
1725 broke it in the course of writing this patch.
1727 2006-10-01 Anders Carlsson <acarlsson@apple.com>
1732 (WebCore::Document::recalcStyleSelector):
1734 Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
1737 Remove DeprecatedStringList class forward declaration.
1739 * editing/markup.cpp:
1740 Include DeprecatedStringList.h here since it's not included by Document.h anymore.
1742 * kcanvas/KCanvasTreeDebug.cpp:
1743 * kcanvas/KCanvasTreeDebug.h:
1744 Remove unused functions.
1746 * loader/loader.cpp:
1750 Fixup DeprecatedStringList.h includes.
1752 2006-09-30 David Harrison <harrison@apple.com>
1754 Reviewed by John Sullivan.
1756 <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
1758 Problem was that the decision to trim was based only on whether the character
1759 is a soft hyphen, which caused pretty much any Japanese character to go.
1760 Changed to decide based on whether the character is ignorable whitespace.
1763 * fast/text/international/wrap-CJK-001.html
1765 * rendering/bidi.cpp:
1766 (WebCore::isTrimmableChar):
1767 New. Checks whether character is whitespace that can be ignored
1768 according to the text node's style.
1769 trimmed from the end of wrapped line.
1770 (WebCore::checkMidpoints):
1771 Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
1773 2006-10-01 Anders Carlsson <acarlsson@apple.com>
1775 Reviewed by Mitz Pettel.
1777 Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
1779 * ksvg2/svg/SVGColor.cpp:
1780 (WebCore::SVGColor::setRGBColor):
1781 * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1782 * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1783 (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
1784 * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1785 (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
1786 * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1787 (SVGFESpecularLightingElement::parseMappedAttribute):
1788 * ksvg2/svg/SVGFETurbulenceElement.cpp:
1789 (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
1790 * ksvg2/svg/SVGLengthList.cpp:
1791 * ksvg2/svg/SVGNumberList.cpp:
1792 (SVGNumberList::parse):
1793 * ksvg2/svg/SVGNumberList.h:
1794 * ksvg2/svg/SVGPreserveAspectRatio.cpp:
1795 (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
1796 * ksvg2/svg/SVGStringList.cpp:
1797 (WebCore::SVGStringList::reset):
1798 * ksvg2/svg/SVGStringList.h:
1799 * ksvg2/svg/SVGTransformable.cpp:
1800 (SVGTransformable::parseTransformAttribute):
1802 2006-10-01 Nikolas Zimmermann <zimmermann@kde.org>
1804 Reviewed by Eric, tweaked and landed by ap.
1809 * platform/qt/PlatformScrollBar.h:
1810 * platform/qt/TemporaryLinkStubs.cpp:
1811 (WebCore::ScrollBar::ScrollBar):
1812 (WebCore::PlatformScrollBar::PlatformScrollBar):
1813 (FrameView::passMousePressEventToSubframe):
1814 (FrameView::passMouseMoveEventToSubframe):
1815 (FrameView::passMouseReleaseEventToSubframe):
1816 (FrameView::passWheelEventToSubframe):
1817 (FrameView::passMousePressEventToScrollbar):
1818 * ksvg2/svg/SVGDocument.h:
1820 2006-10-01 Mitz Pettel <opendarwin.org@mitzpettel.com>
1824 Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
1825 REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
1827 No test case added (probably requires new DumpRenderTree functionality)
1829 * rendering/RenderImage.cpp:
1830 (WebCore::RenderImage::imageChanged): Added early return if the document is
1833 2006-10-01 Graham Dennis <graham.dennis@gmail.com>
1837 Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
1838 REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
1840 Make sure we only break after a space (and not any other valid line-break) if
1841 the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
1842 I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
1843 twice in quick succession.
1845 * rendering/bidi.cpp:
1846 (WebCore::RenderBlock::findNextLineBreak):
1848 2006-10-01 Alexey Proskuryakov <ap@nypop.com>
1850 Reviewed by Maciej and Darin.
1852 http://bugs.webkit.org/show_bug.cgi?id=4372
1853 JavaScript document.write page form does not submit in Safari
1855 Test: fast/forms/document-write.html
1858 (WebCore::Frame::submitForm): Don't check for parsing().
1860 2006-10-01 Alexey Proskuryakov <ap@nypop.com>
1864 * bridge/mac/FrameViewMac.mm: Add missing #imports.
1866 2006-10-01 Dave Hyatt <hyatt@apple.com>
1868 Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
1872 * bridge/mac/FrameMac.mm:
1873 (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
1874 * bridge/mac/FrameViewMac.mm:
1875 (WebCore::FrameView::passMousePressEventToScrollbar):
1876 * page/FrameView.cpp:
1877 (WebCore::FrameView::handleMousePressEvent):
1878 (WebCore::FrameView::setMousePressed):
1880 * platform/win/TemporaryLinkStubs.cpp:
1881 (FrameView::passMousePressEventToScrollbar):
1883 2006-09-30 Sam Weinig <sam.weinig@gmail.com>
1887 Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
1888 Add more SVG Objective-C DOM bindings
1890 - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
1891 DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
1892 DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
1893 DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
1894 DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument,
1895 DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
1897 * DerivedSources.make:
1898 * WebCore.xcodeproj/project.pbxproj:
1899 * bindings/objc/DOMInternal.h:
1900 * bindings/objc/DOMSVG.h:
1901 * bindings/scripts/CodeGeneratorObjC.pm:
1902 * ksvg2/svg/SVGAElement.idl:
1903 * ksvg2/svg/SVGAnimateColorElement.idl:
1904 * ksvg2/svg/SVGAnimateElement.idl:
1905 * ksvg2/svg/SVGAnimateTransformElement.idl:
1906 * ksvg2/svg/SVGAnimatedPathData.idl:
1907 * ksvg2/svg/SVGAnimatedPoints.idl:
1908 * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
1909 * ksvg2/svg/SVGAnimationElement.idl:
1910 * ksvg2/svg/SVGCircleElement.idl:
1911 * ksvg2/svg/SVGClipPathElement.idl:
1912 * ksvg2/svg/SVGColor.idl:
1913 * ksvg2/svg/SVGCursorElement.idl:
1914 * ksvg2/svg/SVGDefsElement.idl:
1915 * ksvg2/svg/SVGDescElement.idl:
1916 * ksvg2/svg/SVGDocument.idl:
1917 * ksvg2/svg/SVGEllipseElement.idl:
1918 * ksvg2/svg/SVGPointList.idl:
1919 * ksvg2/svg/SVGPreserveAspectRatio.idl:
1920 * ksvg2/svg/SVGRect.idl:
1921 * ksvg2/svg/SVGSVGElement.idl:
1923 2006-09-30 Maciej Stachowiak <mjs@apple.com>
1929 * platform/FloatRect.h:
1930 (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
1931 but more appropriate for path-type stuff.
1932 * platform/cg/PathCG.cpp:
1933 (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
1935 2006-09-30 Alexey Proskuryakov <ap@nypop.com>
1939 http://bugs.webkit.org/show_bug.cgi?id=11011
1940 External CSS is parsed as iso-8859-1 even though the main document is utf-8
1942 Test: fast/encoding/css-charset-default.xhtml
1944 * loader/CachedResourceClient.h:
1945 (WebCore::CachedResourceClient::setCSSStyleSheet):
1946 (WebCore::CachedResourceClient::setXSLStyleSheet):
1947 Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
1948 takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
1950 * css/CSSImportRule.cpp:
1951 (WebCore::CSSImportRule::setCSSStyleSheet):
1952 (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
1953 * css/CSSImportRule.h:
1955 * css/CSSStyleSheet.cpp:
1956 (WebCore::CSSStyleSheet::CSSStyleSheet):
1957 * css/CSSStyleSheet.h:
1958 Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
1959 member. Changed some String parameters to const String&.
1961 * css/StyleSheet.cpp:
1962 (WebCore::StyleSheet::StyleSheet):
1964 Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
1966 * css/StyleSheetList.cpp:
1967 (WebCore::StyleSheetList::length):
1968 (WebCore::StyleSheetList::item):
1969 * css/StyleSheetList.h:
1970 Special-casing implicit stylesheets seemed to be dead code, removed.
1973 (WebCore::Document::setCSSStyleSheet):
1974 (WebCore::Document::recalcStyleSelector):
1976 Renamed setStyleSheet() to setCSSStyleSheet().
1978 * dom/ProcessingInstruction.cpp:
1979 (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
1980 (WebCore::ProcessingInstruction::setCSSStyleSheet):
1981 (WebCore::ProcessingInstruction::setXSLStyleSheet):
1982 (WebCore::ProcessingInstruction::parseStyleSheet):
1983 * dom/ProcessingInstruction.h:
1985 * html/HTMLLinkElement.cpp:
1986 (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute
1988 (WebCore::HTMLLinkElement::setCSSStyleSheet):
1989 * html/HTMLLinkElement.h:
1991 * html/HTMLStyleElement.cpp:
1992 (WebCore::HTMLStyleElement::childrenChanged):
1993 * ksvg2/svg/SVGStyleElement.cpp:
1994 (WebCore::SVGStyleElement::childrenChanged):
1995 Inherit URL and charset from the document.
1998 (WebCore::Cache::requestCSSStyleSheet):
2000 Adjust for setStyleSheet() renaming.
2002 * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
2003 * loader/CachedCSSStyleSheet.cpp:
2004 (WebCore::CachedCSSStyleSheet::ref):
2005 (WebCore::CachedCSSStyleSheet::deref):
2006 (WebCore::CachedCSSStyleSheet::checkNotify):
2007 Pass the encoding to setCSSStyleSheet().
2009 * loader/CachedXSLStyleSheet.cpp:
2010 (WebCore::CachedXSLStyleSheet::ref):
2011 (WebCore::CachedXSLStyleSheet::checkNotify):
2012 * loader/DocLoader.cpp:
2013 (WebCore::DocLoader::requestCSSStyleSheet):
2014 * loader/DocLoader.h:
2016 (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
2017 (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
2018 * xml/XSLImportRule.cpp:
2019 (WebCore::XSLImportRule::setXSLStyleSheet):
2020 (WebCore::XSLImportRule::loadSheet):
2021 * xml/XSLImportRule.h:
2022 Adjust for setStyleSheet() renaming.
2024 2006-09-30 Rob Buis <buis@kde.org>
2026 Reviewed by eseidel.
2028 http://bugs.webkit.org/show_bug.cgi?id=11096
2029 Hit testing for polylines fails
2031 Fix Path::contains so it handles filled, non-closed paths too.
2033 * platform/cg/PathCG.cpp:
2034 (WebCore::Path::contains):
2036 2006-09-30 Dave Hyatt <hyatt@apple.com>
2038 Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
2039 Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
2040 subframes while the mouse is down.
2042 Reviewed by mitzpettel
2044 * bridge/mac/FrameMac.h:
2045 * bridge/mac/FrameMac.mm:
2046 (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
2047 (WebCore::FrameMac::passWheelEventToWidget):
2048 * bridge/mac/FrameViewMac.mm:
2049 (WebCore::FrameView::passMousePressEventToSubframe):
2050 (WebCore::FrameView::passMouseMoveEventToSubframe):
2051 (WebCore::FrameView::passMouseReleaseEventToSubframe):
2052 (WebCore::FrameView::passWheelEventToSubframe):
2055 * page/FrameView.cpp:
2056 (WebCore::subframeForTargetNode):
2057 (WebCore::FrameView::handleMousePressEvent):
2058 (WebCore::FrameView::handleMouseDoubleClickEvent):
2059 (WebCore::FrameView::handleMouseMoveEvent):
2060 (WebCore::FrameView::handleMouseReleaseEvent):
2061 (WebCore::FrameView::handleWheelEvent):
2063 * platform/ScrollBar.h:
2064 (WebCore::ScrollBar::handleMouseMoveEvent):
2065 (WebCore::ScrollBar::handleMouseOutEvent):
2066 * platform/Widget.h:
2067 (WebCore::Widget::handleMouseMoveEvent):
2068 (WebCore::Widget::handleMouseReleaseEvent):
2069 * platform/win/TemporaryLinkStubs.cpp:
2070 (FrameView::passMousePressEventToSubframe):
2071 (FrameView::passMouseMoveEventToSubframe):
2072 (FrameView::passMouseReleaseEventToSubframe):
2073 (FrameView::passWheelEventToSubframe):
2074 (Widget::capturingMouse):
2075 (Widget::setCapturingMouse):
2076 (Widget::capturingTarget):
2077 (Widget::capturingChild):
2078 (Widget::setCapturingChild):
2079 * rendering/RenderView.cpp:
2080 (WebCore::RenderView::paintBoxDecorations):
2082 2006-09-29 MorganL <morganl.webkit@yahoo.com>
2086 Fixes windows bustage:
2087 http://bugs.webkit.org/show_bug.cgi?id=11093
2089 * platform/win/PlatformScrollBar.h:
2090 * platform/win/TemporaryLinkStubs.cpp:
2091 (PlatformScrollBar::PlatformScrollBar):
2092 (ScrollBar::ScrollBar):
2094 2006-09-29 David Hyatt <hyatt@apple.com>
2096 Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
2097 in RenderObject::NodeInfo (and then propagating that Widget to
2098 MouseEventWithHitTestResults).
2100 This allows RenderListBox and RenderBlock to do the same thing when the
2101 mouse is over the scrollbar.
2103 Also land fix to support font-size: 0.
2105 Reviewed by mjs (scrollbar), eric (font-size)
2108 (WebCore::Document::prepareMouseEvent):
2110 (WebCore::Frame::passWidgetMouseDownEventToWidget):
2111 * page/FrameView.cpp:
2112 (WebCore::selectCursor):
2113 (WebCore::FrameView::handleMouseMoveEvent):
2114 (WebCore::FrameView::dispatchMouseEvent):
2115 * page/MouseEventWithHitTestResults.cpp:
2116 (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2117 * page/MouseEventWithHitTestResults.h:
2118 (WebCore::MouseEventWithHitTestResults::scrollbar):
2119 * rendering/RenderBlock.cpp:
2120 (WebCore::RenderBlock::isPointInScrollbar):
2121 (WebCore::RenderBlock::nodeAtPoint):
2122 * rendering/RenderBlock.h:
2123 * rendering/RenderLayer.cpp:
2124 (WebCore::RenderLayer::hitTest):
2125 * rendering/RenderLayer.h:
2126 (WebCore::RenderLayer::getHiddenBehavior):
2127 * rendering/RenderListBox.cpp:
2128 (WebCore::RenderListBox::RenderListBox):
2129 (WebCore::RenderListBox::~RenderListBox):
2130 (WebCore::RenderListBox::isPointInScrollbar):
2131 * rendering/RenderListBox.h:
2132 * rendering/RenderObject.h:
2133 (WebCore::RenderObject::NodeInfo::NodeInfo):
2134 (WebCore::RenderObject::NodeInfo::scrollbar):
2135 (WebCore::RenderObject::NodeInfo::setScrollbar):
2137 2006-09-29 MorganL <morganl.webkit@yahoo.com>
2141 Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
2143 * platform/win/ScrollViewWin.cpp:
2144 (WebCore::ScrollView::convertToContainingWindow):
2145 (WebCore::ScrollView::convertFromContainingWindow):
2146 * platform/win/WidgetWin.cpp:
2147 (WebCore::Widget::convertToContainingWindow):
2148 (WebCore::Widget::convertFromContainingWindow):
2150 2006-09-29 Adele Peterson <adele@apple.com>
2152 Updated with new argument for PlatformScrollBar.
2154 * platform/win/TemporaryLinkStubs.cpp:
2155 (PlatformScrollBar::PlatformScrollBar):
2157 2006-09-29 Adele Peterson <adele@apple.com>
2161 Fixing build bustage with cast to int.
2163 * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
2165 2006-09-29 Adele Peterson <adele@apple.com>
2167 Fixing accidental include.
2169 * rendering/RenderListBox.cpp:
2171 2006-09-29 Adele Peterson <adele@apple.com>
2173 Adding RenderListBox files.
2175 * WebCore.vcproj/WebCore/WebCore.vcproj:
2177 2006-09-29 Adele Peterson <adele@apple.com>
2181 Initial implementation of engine-based list box control.
2183 * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
2185 * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
2186 * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
2187 (WebCore::FrameMac::FrameMac):
2188 (WebCore::FrameMac::handleMousePressEvent):
2189 (WebCore::FrameMac::handleMouseMoveEvent):
2190 (WebCore::FrameMac::mouseDown):
2193 (WebCore::Frame::handleMouseMoveEvent):
2194 (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
2195 (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
2196 (WebCore::Frame::autoscrollTimerFired): ditto.
2197 (WebCore::Frame::stopAutoscrollTimer): ditto.
2198 (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
2200 * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
2202 * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
2203 (WebCore::FrameViewPrivate::reset):
2204 (WebCore::FrameView::currentMousePosition):
2205 (WebCore::FrameView::handleMousePressEvent):
2206 (WebCore::FrameView::handleMouseDoubleClickEvent):
2207 (WebCore::selectCursor):
2208 (WebCore::FrameView::handleMouseMoveEvent):
2209 (WebCore::FrameView::handleMouseReleaseEvent):
2212 * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument. The list box will use a smaller scroll bar size.
2213 * platform/ScrollBar.h:
2215 (WebCore::ScrollBar::controlSize):
2216 * platform/mac/PlatformScrollBar.h:
2217 * platform/mac/PlatformScrollBarMac.mm:
2218 (NSControlSizeForScrollBarControlSize):
2219 (-[WebCoreScrollBar initWithPlatformScrollBar:]):
2220 (WebCore::PlatformScrollBar::PlatformScrollBar):
2222 * rendering/RenderBlock.h:
2223 * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
2224 * rendering/RenderLayer.h:
2225 * rendering/RenderObject.cpp:
2226 (WebCore::RenderObject::shouldAutoscroll):
2227 (WebCore::RenderObject::autoscroll):
2228 * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
2230 * css/html4.css: Added properties for new list boxes.
2232 * html/HTMLOptionElement.cpp:
2233 (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
2234 (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
2235 * html/HTMLOptionElement.h: Added disabled method.
2237 * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
2238 (WebCore::HTMLSelectElement::recalcStyle):
2239 (WebCore::HTMLSelectElement::lastSelectedListIndex):
2240 (WebCore::HTMLSelectElement::deselectItems):
2241 (WebCore::HTMLSelectElement::setSelectedIndex):
2242 (WebCore::HTMLSelectElement::isKeyboardFocusable):
2243 (WebCore::HTMLSelectElement::isMouseFocusable):
2244 (WebCore::HTMLSelectElement::createRenderer):
2245 (WebCore::HTMLSelectElement::recalcListItems):
2246 (WebCore::HTMLSelectElement::setRecalcListItems):
2247 (WebCore::HTMLSelectElement::reset):
2248 (WebCore::HTMLSelectElement::notifyOptionSelected):
2249 (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
2250 (WebCore::HTMLSelectElement::nextSelectableListIndex):
2251 (WebCore::HTMLSelectElement::previousSelectableListIndex):
2252 * html/HTMLSelectElement.h:
2254 * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
2255 (WebCore::RenderTheme::paint):
2256 (WebCore::RenderTheme::paintBorderOnly):
2257 (WebCore::RenderTheme::paintDecorations):
2258 (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
2259 (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
2260 (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
2261 (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
2262 (WebCore::RenderTheme::isControlStyled):
2263 (WebCore::RenderTheme::supportsFocusRing):
2264 * rendering/RenderTheme.h:
2265 * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
2267 * rendering/RenderListBox.cpp: Added.
2268 (WebCore::RenderListBox::RenderListBox):
2269 (WebCore::RenderListBox::~RenderListBox):
2270 (WebCore::RenderListBox::setStyle):
2271 (WebCore::RenderListBox::updateFromElement):
2272 (WebCore::RenderListBox::calcMinMaxWidth):
2273 (WebCore::RenderListBox::size):
2274 (WebCore::RenderListBox::numItems):
2275 (WebCore::RenderListBox::calcHeight):
2276 (WebCore::RenderListBox::baselinePosition):
2277 (WebCore::RenderListBox::itemBoundingBoxRect):
2278 (WebCore::RenderListBox::paintObject):
2279 (WebCore::RenderListBox::paintScrollbar):
2280 (WebCore::RenderListBox::paintItemForeground):
2281 (WebCore::RenderListBox::paintItemBackground):
2282 (WebCore::RenderListBox::scrollBarTarget):
2283 (WebCore::RenderListBox::isPointInScrollbar):
2284 (WebCore::RenderListBox::optionAtPoint):
2285 (WebCore::RenderListBox::autoscroll):
2286 (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
2287 (WebCore::RenderListBox::scroll):
2288 (WebCore::RenderListBox::valueChanged):
2289 * rendering/RenderListBox.h: Added.
2290 (WebCore::RenderListBox::isListBox):
2291 (WebCore::RenderListBox::selectionChanged):
2292 (WebCore::RenderListBox::setSelectionChanged):
2293 (WebCore::RenderListBox::canHaveChildren):
2294 (WebCore::RenderListBox::renderName):
2295 (WebCore::RenderListBox::setOptionsChanged):
2296 (WebCore::RenderListBox::shouldAutoscroll):
2297 (WebCore::RenderListBox::listIndexIsVisible):
2299 2006-09-29 Beth Dakin <bdakin@apple.com>
2303 We had a bug where html4.css was ignoring Media Queries. In the end
2304 the problem was that we were trying to send a char* to the
2305 MediaQueryEvaluator constructor that expects a String, but the
2306 char* got interpreted as a bool, the wrong constructor was called,
2307 and the media type was never set.
2309 No test case possible since this only affects html4.css
2311 * css/MediaQueryEvaluator.cpp: New constructor that expects takes a
2313 (WebCore::MediaQueryEvaluator):
2314 * css/MediaQueryEvaluator.h: Same.
2316 2006-09-29 Geoffrey Garen <ggaren@apple.com>
2318 Reviewed by John, Maciej.
2320 Integrated some frame and iframe code. I'm trying to fix up frame ownership
2321 and loading. Reducing the number of different code paths involved
2322 seemed like a good first step.
2324 As a side effect, I fixed a bug where FRAME elements would report their
2325 src attributes as relative, rather than compelete, URLs. (IFRAME elements
2326 had the correct complete URL behavior.)
2328 * html/HTMLFrameElement.cpp:
2329 (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
2330 (WebCore::HTMLFrameElement::openURL):
2331 (1) Removed checks that requestFrame does for us
2332 (2) Added isURLAllowed check, to have one clear bottleneck for it
2333 (3) Added viewsource check, to have one clear bottleneck for it
2334 (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
2335 method, instead of finding our content frame in our own unique way.
2336 (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
2337 since openURL does this for us now.
2338 (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
2339 This is what FF does, and it made no sense to have different behaviors
2340 for FRAME and IFRAME elements.
2341 * html/HTMLIFrameElement.cpp:
2342 (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
2344 * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
2345 HTMLFrameElement now does everything we need.
2347 2006-09-30 Nikolas Zimmermann <zimmermann@kde.org>
2354 * platform/qt/ScrollViewQt.cpp:
2355 (WebCore::ScrollView::convertToContainingWindow):
2356 (WebCore::ScrollView::convertFromContainingWindow):
2357 * platform/qt/TemporaryLinkStubs.cpp:
2358 (WebCore::signedPublicKeyAndChallengeString):
2359 * platform/qt/WidgetQt.cpp:
2360 (WebCore::Widget::convertToContainingWindow):
2361 (WebCore::Widget::convertFromContainingWindow):
2363 2006-09-29 Sam Weinig <sam.weinig@gmail.com>
2367 Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
2368 Simplify Internal methods for the auto-generated Objective-C DOM code
2370 - Auto-generate the internal methods for more Objective-C classes.
2372 * WebCore.xcodeproj/project.pbxproj:
2373 * bindings/objc/DOM.mm:
2374 * bindings/objc/DOMCSS.mm:
2375 (-[DOMStyleSheet WebCore::]):
2376 (+[DOMStyleSheet _styleSheetWith:WebCore::]):
2377 (-[DOMCSSRule WebCore::]):
2378 (-[DOMCSSRule _initWithCSSRule:WebCore::]):
2379 (+[DOMCSSRule _CSSRuleWith:WebCore::]):
2380 (-[DOMCSSValue WebCore::]):
2381 (-[DOMCSSValue _initWithCSSValue:WebCore::]):
2382 (+[DOMCSSValue _CSSValueWith:WebCore::]):
2383 * bindings/objc/DOMHTMLAppletElement.mm:
2384 (-[DOMHTMLAppletElement WebCore::]):
2385 (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
2386 * bindings/objc/DOMHTMLEmbedElement.mm:
2387 (-[DOMHTMLEmbedElement WebCore::]):
2388 (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
2389 * bindings/objc/DOMInternal.h:
2390 * bindings/objc/DOMInternal.mm:
2391 * bindings/scripts/CodeGeneratorObjC.pm:
2392 * css/CSSCharsetRule.idl:
2393 * css/CSSFontFaceRule.idl:
2394 * css/CSSImportRule.idl:
2395 * css/CSSMediaRule.idl:
2396 * css/CSSPageRule.idl:
2397 * css/CSSPrimitiveValue.idl:
2398 * css/CSSStyleRule.idl:
2399 * css/CSSStyleSheet.idl:
2400 * css/CSSUnknownRule.idl:
2401 * css/CSSValueList.idl:
2402 * dom/KeyboardEvent.idl:
2403 * dom/MouseEvent.idl:
2404 * dom/MutationEvent.idl:
2405 * dom/NodeIterator.idl:
2406 * dom/OverflowEvent.idl:
2408 * dom/WheelEvent.idl:
2410 2006-09-29 David Harrison <harrison@apple.com>
2412 Reviewed by John Sullivan.
2414 <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
2415 <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
2418 * fast/text/attributed-substring-from-range-001.html
2420 * bridge/mac/FrameMac.mm:
2421 (WebCore::FrameMac::attributedString):
2422 Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
2423 Also, add validation of the range.
2425 2006-09-29 Rob Buis <buis@kde.org>
2429 http://bugs.webkit.org/show_bug.cgi?id=10893
2430 InsertRule can not handle @import statements
2432 Allow @import as part of a css rule.
2436 2006-09-28 David Hyatt <hyatt@apple.com>
2438 Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
2440 * bridge/mac/FrameMac.mm:
2441 (WebCore::FrameMac::eventMayStartDrag):
2442 (WebCore::FrameMac::dragHysteresisExceeded):
2443 (WebCore::FrameMac::mouseDown):
2444 (WebCore::FrameMac::shouldDragAutoNode):
2445 (WebCore::FrameMac::sendContextMenuEvent):
2446 * bridge/mac/WebCoreFrameBridge.mm:
2447 (-[WebCoreFrameBridge _visiblePositionForPoint:]):
2449 2006-09-28 Dave Hyatt <hyatt@apple.com>
2451 This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
2452 ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
2455 Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
2456 the patch after review, once I realized that these new functions essentially do the same thing.)
2458 * dom/EventTargetNode.cpp:
2459 (WebCore::EventTargetNode::dispatchMouseEvent):
2460 (WebCore::EventTargetNode::dispatchWheelEvent):
2462 (WebCore::Frame::selectClosestWordFromMouseEvent):
2463 (WebCore::Frame::handleMousePressEventTripleClick):
2464 (WebCore::Frame::handleMousePressEventSingleClick):
2465 (WebCore::Frame::handleMouseMoveEvent):
2466 (WebCore::Frame::handleMouseReleaseEvent):
2467 * page/FrameView.cpp:
2468 (WebCore::FrameView::handleMousePressEvent):
2469 (WebCore::selectCursor):
2470 (WebCore::FrameView::dispatchDragEvent):
2471 (WebCore::FrameView::prepareMouseEvent):
2472 (WebCore::FrameView::handleWheelEvent):
2473 * platform/ScrollView.h:
2474 * platform/Widget.cpp:
2475 (WebCore::Widget::convertToContainingWindow):
2476 * platform/Widget.h:
2477 * platform/mac/ScrollViewMac.mm:
2478 (WebCore::ScrollView::convertToContainingWindow):
2479 (WebCore::ScrollView::convertFromContainingWindow):
2480 * platform/mac/WidgetMac.mm:
2481 (WebCore::Widget::convertToContainingWindow):
2482 (WebCore::Widget::convertFromContainingWindow):
2483 * platform/win/ScrollViewWin.cpp:
2484 (WebCore::ScrollView::convertToContainingWindow):
2485 (WebCore::ScrollView::convertFromContainingWindow):
2486 * rendering/RenderLayer.cpp:
2487 (WebCore::RenderLayer::resize):
2489 2006-09-28 Alice Liu <alice.liu@apple.com>
2491 Build fix by adding missing files for CommandByName
2493 * WebCore.xcodeproj/project.pbxproj:
2495 2006-09-28 Alice Liu <alice.liu@apple.com>
2497 Adding CommandByName files to the vcproj
2499 * WebCore.vcproj/WebCore/WebCore.vcproj:
2501 2006-09-28 Alice Liu <alice.liu@apple.com>
2503 Reviewed by Adam Roben.
2505 This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc.
2506 This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
2507 This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
2509 * editing/CommandByName.cpp: Added.
2510 Added a command class that hangs off the frame so the frame can call commands more easily.
2511 (WebCore::Frame::commandImp):
2512 (WebCore::Frame::execCopy):
2513 (WebCore::Frame::execCut):
2514 (WebCore::Frame::execDelete):
2515 (WebCore::Frame::execForwardDelete):
2516 (WebCore::Frame::execPaste):
2517 (WebCore::Frame::execMoveLeft):
2518 (WebCore::Frame::execMoveRight):
2519 (WebCore::Frame::execMoveUp):
2520 (WebCore::Frame::execMoveDown):
2521 (WebCore::Frame::execSelectAll):
2522 (WebCore::Frame::execSelectLeft):
2523 (WebCore::Frame::execSelectRight):
2524 (WebCore::Frame::execSelectUp):
2525 (WebCore::Frame::execSelectDown):
2526 (WebCore::Frame::enabled):
2527 (WebCore::Frame::enabledAnySelection):
2528 (WebCore::Frame::enabledAnyEditableSelection):
2529 (WebCore::Frame::enabledPaste):
2530 (WebCore::Frame::enabledAnyRangeSelection):
2531 (WebCore::Frame::enabledAnyEditableRangeSelection):
2532 (WebCore::Frame::createCommandDictionary):
2533 (WebCore::Frame::Command::):
2534 (WebCore:::m_frame):
2535 (WebCore::CommandByName::execCommand):
2536 * editing/CommandByName.h: Added.
2538 Added implementation of accessor for CommandByName member
2539 (WebCore::Frame::command):
2541 Added accessor for CommandByName member
2542 * page/FramePrivate.h:
2543 Added a CommandByName member
2544 (WebCore::FramePrivate::FramePrivate):
2545 * platform/PlatformMouseEvent.h:
2546 Changed constructor prototype
2547 * platform/StringImpl.cpp:
2548 Exposing getWordBreakIterator to be used elsewhere
2549 (WebCore::getWordBreakIterator):
2550 * platform/StringImpl.h:
2551 Exposing getWordBreakIterator to be used elsewhere
2552 * platform/win/MouseEventWin.cpp:
2553 Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
2554 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2556 2006-09-28 Adam Roben <aroben@apple.com>
2560 Remove no-longer-used PopUpButton.
2562 * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
2563 * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
2565 * platform/PopUpButton.h: Removed.
2566 * platform/mac/PopUpButtonMac.mm: Removed.
2567 * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
2568 * rendering/DeprecatedRenderSelect.cpp: Change #include of
2569 PopUpButton.h to ListBox.h
2571 2006-09-28 Darin Adler <darin@apple.com>
2575 - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
2576 10% perf. regression (copying strings while decoding)
2578 Use Vector<UChar> instead of String when building up the decoded string in
2579 the ICU and Mac decoders. Using String leads to O(n^2) behavior because
2580 String grows the buffer every single time that append is called. Using
2581 Vector::append instead of String::append also avoids constructing a string
2582 each time just to append and a questionable copy that is done inside the
2583 String::append function which also contributed to the slowness.
2585 * platform/PlatformString.h:
2586 * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
2587 Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
2589 * platform/StringImpl.h:
2590 * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
2592 * platform/StreamingTextDecoder.h:
2593 * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
2594 Change to use a Vector<UChar> instead of a String, since vectors have better
2595 resizing performance (they store a separate capacity).
2597 * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
2598 * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
2599 Change to use Vector<UChar> instead of String and then create a string at
2600 the end of the process using the new adopt function.
2602 2006-09-28 Sam Weinig <sam.weinig@gmail.com>
2606 Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
2607 Auto-generate more SVG Objective-C bindings
2609 - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean,
2610 DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
2611 DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
2612 DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
2613 DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
2614 DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests,
2615 and DOMSVGTransformable.
2617 - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
2618 parent interfaces and the SVG animated classes.
2620 - Corrects CodeGenerator.pm to only skip the first parent for the main
2623 * DerivedSources.make:
2624 * WebCore.xcodeproj/project.pbxproj:
2625 * bindings/objc/DOMInternal.h:
2626 * bindings/objc/DOMSVG.h:
2627 * bindings/scripts/CodeGenerator.pm:
2628 * bindings/scripts/CodeGeneratorObjC.pm:
2629 * ksvg2/svg/SVGAnimatedAngle.idl:
2630 * ksvg2/svg/SVGAnimatedBoolean.idl:
2631 * ksvg2/svg/SVGAnimatedEnumeration.idl:
2632 * ksvg2/svg/SVGAnimatedInteger.idl:
2633 * ksvg2/svg/SVGAnimatedLength.idl:
2634 * ksvg2/svg/SVGAnimatedLengthList.idl:
2635 * ksvg2/svg/SVGAnimatedNumber.idl:
2636 * ksvg2/svg/SVGAnimatedPathData.idl:
2637 * ksvg2/svg/SVGAnimatedString.idl:
2638 * ksvg2/svg/SVGAnimatedTransformList.idl:
2639 * ksvg2/svg/SVGExternalResourcesRequired.idl:
2640 * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
2641 * ksvg2/svg/SVGFitToViewBox.idl:
2642 * ksvg2/svg/SVGLangSpace.idl:
2643 * ksvg2/svg/SVGLocatable.idl:
2644 * ksvg2/svg/SVGMetadataElement.idl:
2645 * ksvg2/svg/SVGStringList.idl:
2646 * ksvg2/svg/SVGStylable.idl:
2647 * ksvg2/svg/SVGStyleElement.idl:
2648 * ksvg2/svg/SVGTests.idl:
2649 * ksvg2/svg/SVGTransformable.idl:
2650 * ksvg2/svg/SVGURIReference.idl:
2651 * ksvg2/svg/SVGUnitTypes.idl:
2652 * ksvg2/svg/SVGZoomAndPan.idl:
2654 2006-09-28 Brady Eidson <beidson@apple.com>
2656 Reviewed by Mitz Pettel!!!
2658 Change the error code check for common functions from SQLResultOk to SQLResultDone
2660 * loader/icon/IconDatabase.cpp:
2661 (WebCore::IconDatabase::forgetPageURLQuery):
2662 (WebCore::IconDatabase::setIconIDForPageURLQuery):
2663 (WebCore::IconDatabase::addIconForIconURLQuery):
2665 2006-09-28 Dave Hyatt <hyatt@apple.com>
2667 Just eliminate MapWindowPoints usage and use the HWND as
2670 * platform/win/MouseEventWin.cpp:
2671 (WebCore::positionForEvent):
2672 * platform/win/ScrollViewWin.cpp:
2673 (WebCore::ScrollView::viewportToContents):
2674 (WebCore::ScrollView::contentsToViewport):
2676 2006-09-27 David Hyatt <hyatt@apple.com>
2678 Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas. Make sure
2679 selectCursor checks for whether or not a scrollbar was hit. Also stub out a mouseMoved method for
2680 scrollbars to provide hover feedback if needed.
2684 * page/FrameView.cpp:
2685 (WebCore::selectCursor):
2686 (WebCore::FrameView::handleMouseMoveEvent):
2687 * platform/ScrollBar.h:
2688 (WebCore::ScrollBar::mouseMoved):
2690 2006-09-27 MorganL <morganl.webkit@yahoo.com>
2692 Reviewed by Maciej and Adam, landed by Adam
2694 Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
2695 Windows build is busted
2697 * platform/win/TemporaryLinkStubs.cpp:
2698 (ScrollView::paint):
2699 (ScrollView::themeChanged):
2701 2006-09-27 Eric Seidel <eric@eseidel.com>
2705 paths with no fill specified default to black but do not recieve paint-related mouse events
2706 http://bugs.webkit.org/show_bug.cgi?id=11069
2707 The default fill was being applied at the wrong place in the rendering chain, causing this problem.
2709 Test: svg/custom/hover-default-fill.svg
2711 * kcanvas/RenderPath.cpp:
2712 (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
2713 * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
2714 * ksvg2/misc/KCanvasRenderingStyle.cpp:
2715 (WebCore::KSVGPainterFactory::isFilled): remove null check
2716 (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
2717 (WebCore::KSVGPainterFactory::isStroked): remove null check
2718 (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
2719 * ksvg2/svg/SVGPaint.cpp:
2720 (WebCore::SVGPaint::defaultFill): added.
2721 (WebCore::SVGPaint::defaultStroke): added.
2722 * ksvg2/svg/SVGPaint.h:
2724 2006-09-27 Rob Buis <buis@kde.org>
2726 Reviewed by eseidel.
2728 http://bugs.webkit.org/show_bug.cgi?id=11015
2729 SVG handles em units incorrectly
2731 Calculate viewport coordinates at layout time, since
2732 at this point the font size is known and lengths depending
2733 on font sizes can be calculated correctly.
2735 * kcanvas/RenderSVGContainer.cpp:
2736 (WebCore::RenderSVGContainer::layout):
2737 (WebCore::RenderSVGContainer::viewport):
2738 (WebCore::RenderSVGContainer::calcViewport):
2739 * kcanvas/RenderSVGContainer.h:
2740 * ksvg2/svg/SVGLength.cpp:
2741 (WebCore::SVGLength::updateValue):
2742 * ksvg2/svg/SVGMarkerElement.cpp:
2743 (WebCore::SVGMarkerElement::createRenderer):
2744 * ksvg2/svg/SVGSVGElement.cpp:
2745 (WebCore::SVGSVGElement::createRenderer):
2746 (WebCore::SVGSVGElement::attributeChanged):
2747 * ksvg2/svg/SVGSVGElement.h:
2749 2006-09-27 Eric Seidel <eric@eseidel.com>
2753 Change our invalid-fill error behavior to match Opera (and soon Firefox)
2754 http://bugs.webkit.org/show_bug.cgi?id=11017
2756 * ksvg2/misc/KCanvasRenderingStyle.cpp:
2757 (WebCore::KSVGPainterFactory::isFilled):
2758 (WebCore::KSVGPainterFactory::fillPaintServer):
2759 (WebCore::KSVGPainterFactory::isStroked):
2760 (WebCore::KSVGPainterFactory::strokePaintServer):
2762 2006-09-27 Brady Eidson <beidson@apple.com>
2766 * loader/icon/IconDatabase.cpp:
2767 (WebCore::readySQLStatement):
2769 2006-09-27 Brady Eidson <beidson@apple.com>
2773 In very specific circumstances, prepared SQLStatements can become invalid without
2774 any warning. This checks for that state and re-prepares the statement and also
2775 adds more aggressive error-checking everywhere these statements are used.
2777 * loader/icon/IconDatabase.cpp:
2778 (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
2779 (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
2780 (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
2781 (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
2782 (WebCore::IconDatabase::forgetPageURLQuery): Ditto
2783 (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
2784 (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
2785 (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
2786 (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
2787 * loader/icon/SQLStatement.cpp:
2788 (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
2789 * loader/icon/SQLStatement.h:
2791 2006-09-26 Darin Adler <darin@apple.com>
2795 - clean up options for font code path
2798 * platform/Font.cpp:
2799 (WebCore::Font::setCodePath): Added. Replaces boolean version.
2800 (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
2802 * platform/mac/WebCoreTextRenderer.mm:
2803 (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
2805 2006-09-26 John Sullivan <sullivan@apple.com>
2809 * bridge/mac/WebCoreFrameBridge.h:
2810 * bridge/mac/WebCoreFrameBridge.mm:
2811 (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
2812 Added limit parameter, passed down to Frame
2816 (WebCore::Frame::markAllMatchesForText):
2817 Added limit parameter. Stop the search if it hits limit.
2819 2006-09-26 Sean Gies <seangies@apple.com>
2821 Reviewed by Brady Eidson.
2823 * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
2825 2006-09-26 Justin Garcia <justin.garcia@apple.com>
2829 <rdar://problem/4747695>
2830 Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
2832 * editing/DeleteSelectionCommand.cpp:
2833 (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
2834 to select special elements that are fully selected after expansion
2835 moves to positions that are visually distinct from the originals.
2836 * editing/InsertListCommand.cpp:
2837 (WebCore::InsertListCommand::doApply): If the content of the list
2838 item will be moved into another list, put it in a list item.
2840 2006-09-26 Geoffrey Garen <ggaren@apple.com>
2844 Temporary work-around for frame lifetime issue.
2847 (WebCore::Frame::clear):
2848 (WebCore::Frame::disconnectOwnerElement):
2850 2006-09-26 Sam Weinig <sam.weinig@gmail.com>
2854 Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
2855 Auto-generate DOMSVGElement for the Objective-C bindings
2857 - Auto-generates DOMSVGElement.
2859 - Make SVGExceptions work like all the other ExceptionCode
2860 extensions (Range, XPath, etc.) by adding SVGExceptionOffset
2861 and SVGExceptionMax.
2863 * DerivedSources.make:
2864 * WebCore.xcodeproj/project.pbxproj:
2865 * bindings/js/kjs_binding.cpp:
2867 (KJS::setDOMException):
2868 * bindings/objc/DOMInternal.h:
2869 * bindings/objc/DOMInternal.mm:
2870 (raiseDOMException):
2871 * bindings/objc/DOMSVG.h:
2872 * bindings/objc/DOMSVGExecption.h: Added.
2874 * ksvg2/svg/SVGElement.cpp:
2875 (WebCore::SVGElement::setId):
2876 (WebCore::SVGElement::setXmlbase):
2877 * ksvg2/svg/SVGElement.h:
2878 * ksvg2/svg/SVGElement.idl:
2879 * ksvg2/svg/SVGException.h: Added.
2882 2006-09-26 Eric Seidel <eric@eseidel.com>
2886 viewbox parser does not allow <tab> as a delimiter
2887 http://bugs.webkit.org/show_bug.cgi?id=11014
2889 Test: svg/hixie/viewbox/003.xml
2891 * ksvg2/svg/svgpathparser.cpp:
2892 (WebCore::isWhitespace): new function
2893 (WebCore::skipOptionalSpaces):
2894 (WebCore::skipOptionalSpacesOrComma):
2896 2006-09-26 Eric Seidel <eric@eseidel.com>
2900 SVGDocument::createElement does not create elements in the SVG namespace
2901 http://bugs.webkit.org/show_bug.cgi?id=10932
2903 Test: svg/custom/createelement.svg
2905 * ksvg2/svg/SVGDocument.cpp:
2906 (WebCore::SVGDocument::createElement):
2907 * ksvg2/svg/SVGDocument.h:
2909 2006-09-26 Eric Seidel <eric@eseidel.com>
2913 RenderPath::nodeAtPoint does not respect stroke width
2914 http://bugs.webkit.org/show_bug.cgi?id=10829
2916 Test: svg/custom/stroke-width-click.svg
2918 * kcanvas/device/quartz/KCanvasItemQuartz.mm:
2919 (WebCore::RenderPath::strokeContains):
2920 * kcanvas/device/quartz/QuartzSupport.h:
2921 * kcanvas/device/quartz/QuartzSupport.mm:
2923 2006-09-26 Eric Seidel <eric@eseidel.com>
2927 Bring animation back to life
2928 http://bugs.webkit.org/show_bug.cgi?id=11021
2930 Register/unregister SVGSVGElements as time containers on insertion/removal.
2931 Replace uses of DeprecatedString with String in SVGAnimationElement
2932 Various whitespace clean-up.
2934 * ksvg2/misc/KSVGTimeScheduler.cpp:
2935 (WebCore::SVGTimer::notifyAll):
2936 * ksvg2/misc/SVGDocumentExtensions.cpp:
2937 (WebCore::SVGDocumentExtensions::startAnimations):
2938 (WebCore::SVGDocumentExtensions::pauseAnimations):
2939 (WebCore::SVGDocumentExtensions::unpauseAnimations):
2940 * ksvg2/svg/SVGAnimateTransformElement.cpp:
2941 (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2942 (WebCore::SVGAnimateTransformElement::parseTransformValue):
2943 * ksvg2/svg/SVGAnimateTransformElement.h:
2944 * ksvg2/svg/SVGAnimationElement.cpp:
2945 (WebCore::SVGAnimationElement::SVGAnimationElement):
2946 (WebCore::SVGAnimationElement::parseMappedAttribute):
2947 (WebCore::SVGAnimationElement::parseClockValue):
2948 (WebCore::SVGAnimationElement::targetAttribute):
2949 (WebCore::SVGAnimationElement::setTargetAttribute):
2950 (WebCore::SVGAnimationElement::attributeName):
2951 * ksvg2/svg/SVGAnimationElement.h:
2952 (WebCore::SVGAnimationElement::rendererIsNeeded):
2953 * ksvg2/svg/SVGSVGElement.cpp:
2954 (WebCore::SVGSVGElement::getScreenCTM):
2955 (WebCore::SVGSVGElement::createRenderer):
2956 (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
2957 (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
2958 * ksvg2/svg/SVGSVGElement.h:
2959 * ksvg2/svg/SVGSetElement.cpp:
2960 (WebCore::SVGSetElement::handleTimerEvent):
2961 * ksvg2/svg/SVGURIReference.cpp:
2962 (WebCore::SVGURIReference::getTarget):
2963 * ksvg2/svg/SVGURIReference.h:
2965 2006-09-26 Graham Dennis <graham.dennis@gmail.com>
2967 Reviewed by mitzpettel.
2969 - fix http://bugs.webkit.org/show_bug.cgi?id=11020
2970 No-SVG build broken since r16549
2972 Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
2974 * css/cssparser.cpp:
2975 (WebCore::CSSParser::parseValue):
2976 * css/cssstyleselector.cpp:
2977 (WebCore::CSSStyleSelector::applyProperty):
2978 * page/FrameView.cpp:
2979 (WebCore::selectCursor):
2980 * platform/qt/GraphicsContextQt.cpp:
2982 2006-09-26 Anders Carlsson <acarlsson@apple.com>
2986 http://bugs.webkit.org/show_bug.cgi?id=10820
2987 Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
2989 (Originally written by Eric Seidel).
2991 * bindings/js/kjs_window.cpp:
2992 (KJS::floatFeature):
2993 * ksvg2/svg/SVGAngle.cpp:
2994 (SVGAngle::setValueAsString):
2995 * ksvg2/svg/SVGAnimationElement.cpp:
2996 (SVGAnimationElement::parseMappedAttribute):
2997 * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2998 (SVGComponentTransferFunctionElement::parseMappedAttribute):
2999 * ksvg2/svg/SVGFECompositeElement.cpp:
3000 (WebCore::SVGFECompositeElement::parseMappedAttribute):
3001 * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3002 (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
3003 * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3004 (SVGFEDisplacementMapElement::parseMappedAttribute):
3005 * ksvg2/svg/SVGFELightElement.cpp:
3006 (SVGFELightElement::parseMappedAttribute):
3007 * ksvg2/svg/SVGFEOffsetElement.cpp:
3008 (WebCore::SVGFEOffsetElement::parseMappedAttribute):
3009 * ksvg2/svg/SVGFESpecularLightingElement.cpp:
3010 (SVGFESpecularLightingElement::parseMappedAttribute):
3011 * ksvg2/svg/SVGFETurbulenceElement.cpp:
3012 (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
3013 * ksvg2/svg/SVGStopElement.cpp:
3014 (SVGStopElement::parseMappedAttribute):
3015 * platform/AtomicString.h:
3016 (WebCore::AtomicString::toDouble):
3017 * platform/PlatformString.h:
3018 * platform/String.cpp:
3019 (WebCore::String::toDouble):
3020 * platform/StringImpl.cpp:
3021 (WebCore::StringImpl::toDouble):
3022 * platform/StringImpl.h:
3023 * rendering/DeprecatedSlider.cpp:
3024 (WebCore::DeprecatedSlider::updateFromElement):
3025 * xml/XPathGrammar.y:
3027 2006-09-25 David Harrison <harrison@apple.com>
3029 Reviewed by Tim Omernick and Tim Hatcher.
3031 <rdar://problem/4717965> Text Field text parameterized attributes should work
3032 <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
3034 * bridge/mac/WebCoreAXObject.mm:
3035 (-[WebCoreAXObject accessibilityAttributeValue:]):
3036 Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
3038 (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
3039 Cleaned up. Added text field and text area parameterzed attributes.
3041 (-[WebCoreAXObject doAXLineForTextMarker:]):
3042 Fixed to be zero-based and to deal with the first position properly.
3044 (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
3047 (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
3048 (-[WebCoreAXObject indexForTextMarker:]):
3049 (-[WebCoreAXObject textMarkerRangeForRange:]):
3050 (-[WebCoreAXObject rangeForTextMarkerRange:]):
3051 New utility methods.
3053 (-[WebCoreAXObject doAXLineForIndex:]):
3054 (-[WebCoreAXObject doAXRangeForLine:]):
3055 (-[WebCoreAXObject doAXStringForRange:]):
3056 (-[WebCoreAXObject doAXRangeForPosition:]):
3057 (-[WebCoreAXObject doAXRangeForIndex:]):
3058 (-[WebCoreAXObject doAXBoundsForRange:]):
3059 (-[WebCoreAXObject doAXAttributedStringForRange:]):
3060 (-[WebCoreAXObject doAXRTFForRange:]):
3061 (-[WebCoreAXObject doAXStyleRangeForIndex:]):
3062 Implement text field and text area parameterized attributes.
3064 (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
3065 Added text field and text area parameterzed attributes.
3067 * rendering/RenderTextControl.h:
3068 Made indexForVisiblePosition() and visiblePositionForIndex() public.
3070 2006-09-25 Adam Roben <aroben@apple.com>
3076 * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
3077 * platform/ResourceLoader.h: Store whether a particular job
3078 has received a response within the ResourceLoader object itself, since
3079 it's possible that we will enter the InternetReadFileExA while loop
3080 twice for the same job.
3081 * platform/ResourceLoaderInternal.h: Add private instance variable to
3082 store whether we've received a response.
3083 (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3084 * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
3086 * platform/win/ResourceLoaderWin.cpp:
3087 (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
3088 whether it has received a response instead of assuming it hasn't.
3089 (WebCore::ResourceLoader::setHasReceivedResponse): Added.
3090 (WebCore::ResourceLoader::hasReceivedResponse): Added.
3091 * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
3093 (ScrollBar::setProportion):
3095 2006-09-25 Brady Eidson <beidson@apple.com>
3099 Disabled IconDatabase logging by default
3101 * platform/Logging.cpp:
3104 2006-09-25 Steve Falkenburg <sfalken@apple.com>
3108 * platform/cf/ResourceLoaderCFNet.cpp:
3109 (WebCore::willCacheResponse):
3111 2006-09-25 Justin Garcia <justin.garcia@apple.com>
3115 <http://bugs.webkit.org/show_bug.cgi?id=11002>
3116 Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
3118 * editing/IndentOutdentCommand.cpp:
3119 (WebCore::IndentOutdentCommand::indentRegion): Special case
3120 an empty root editable element.
3122 2006-09-25 Brady Eidson <beidson@apple.com>
3126 Math error in SystemTimeWin
3128 * platform/win/SystemTimeWin.cpp:
3129 (WebCore::currentTime):
3131 2006-09-25 Alexey Proskuryakov <ap@nypop.com>
3135 Whitespace cleanup; rename *job variables to *loader.
3137 * bindings/js/JSXMLHttpRequest.cpp:
3138 (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
3139 (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
3140 (KJS::JSXMLHttpRequestConstructorImp::construct):
3141 (KJS::JSXMLHttpRequest::getOwnPropertySlot):
3142 (KJS::JSXMLHttpRequest::getValueProperty):
3143 (KJS::JSXMLHttpRequest::put):
3144 (KJS::JSXMLHttpRequest::putValueProperty):
3145 (KJS::JSXMLHttpRequest::mark):
3146 (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
3147 (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
3148 (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
3149 * bindings/js/JSXMLHttpRequest.h:
3150 (KJS::JSXMLHttpRequest::toBoolean):
3151 * xml/xmlhttprequest.cpp:
3152 (WebCore::XMLHttpRequest::XMLHttpRequest):
3153 (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
3154 (WebCore::XMLHttpRequest::send):
3155 (WebCore::XMLHttpRequest::abort):
3156 (WebCore::XMLHttpRequest::receivedAllData):
3157 (WebCore::XMLHttpRequest::receivedData):
3158 * xml/xmlhttprequest.h:
3161 2006-09-25 Timothy Hatcher <timothy@apple.com>
3165 - Deprecate the rest of the old-style methods that are not generated.
3166 - Add @property syntax to DOMRange.
3168 * WebCore.xcodeproj/project.pbxproj:
3169 * bindings/objc/DOM.mm:
3170 (-[DOMRange setStart:offset:]):
3171 (-[DOMRange setEnd:offset:]):
3172 (-[DOMRange compareBoundaryPoints:sourceRange:]):
3173 (-[DOMRange setStart::]):
3174 (-[DOMRange setEnd::]):
3175 (-[DOMRange compareBoundaryPoints::]):
3176 (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3177 (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3178 (-[DOMDocument createNodeIterator::::]):
3179 (-[DOMDocument createTreeWalker::::]):
3180 * bindings/objc/DOMCSS.h:
3181 * bindings/objc/DOMCSS.mm:
3182 (-[DOMDocument getComputedStyle:pseudoElement:]):
3183 (-[DOMDocument getComputedStyle::]):
3184 (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
3185 * bindings/objc/DOMExtensions.h:
3186 * bindings/objc/DOMHTML.h:
3187 * bindings/objc/DOMRange.h:
3188 * bindings/objc/DOMTraversal.h:
3190 2006-09-25 Eric Seidel <eric@eseidel.com>
3194 Outermost <svg> element should clip to viewport
3195 http://bugs.webkit.org/show_bug.cgi?id=11007
3197 Test: svg/custom/viewport-clip.svg
3199 * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
3201 2006-09-25 Anders Carlsson <acarlsson@apple.com>
3205 * css/MediaList.cpp:
3206 Remove unused header.
3209 (WebCore::Document::clear):
3210 Use clear instead of iterating through the list of event listeners, removing each one.
3211 (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
3213 * html/HTMLKeygenElement.cpp:
3214 (WebCore::HTMLKeygenElement::HTMLKeygenElement):
3215 (WebCore::HTMLKeygenElement::appendFormData):
3216 Update due to changes in the SSL key generator.
3218 * ksvg2/svg/SVGAngle.cpp:
3219 Remove unused header.
3221 * ksvg2/svg/SVGAnimationElement.cpp:
3222 (SVGAnimationElement::parseMappedAttribute):
3223 Rename methods and pass Strings instead of DeprecatedStrings to
3226 * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3227 * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3228 * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3229 * ksvg2/svg/SVGFEMergeElement.cpp:
3230 * ksvg2/svg/SVGFEOffsetElement.cpp:
3231 Remove unused headers.
3233 * ksvg2/svg/SVGHelper.cpp:
3234 (WebCore::SVGHelper::parseSeparatedList):
3235 * ksvg2/svg/SVGHelper.h:
3236 Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
3237 DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
3239 * ksvg2/svg/SVGLengthList.cpp:
3240 (WebCore::SVGLengthList::parse):
3241 * ksvg2/svg/SVGLengthList.h:
3242 Use Vector<String> instead of DeprecatedStringList.
3245 (WebCore::Cache::requestImage):
3246 (WebCore::Cache::requestStyleSheet):
3247 (WebCore::Cache::requestScript):
3248 (WebCore::Cache::requestXSLStyleSheet):
3249 (WebCore::Cache::requestXBLDocument):
3250 (WebCore::Cache::remove):
3251 (WebCore::Cache::get):
3252 Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
3254 * loader/DocLoader.cpp:
3255 (WebCore::DocLoader::needReload):
3256 * loader/DocLoader.h:
3257 Use a HashSet instead of DeprecatedStringList.
3260 Remove declarations that have no functions.
3262 * platform/SSLKeyGenerator.h:
3263 * platform/mac/SSLKeyGeneratorMac.mm:
3264 (WebCore::supportedKeySizes):
3265 (WebCore::signedPublicKeyAndChallengeString):
3266 Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
3269 2006-09-25 Dave Hyatt <hyatt@apple.com>
3271 Shunt the RenderTheme world transform adoption between
3272 Cairo and Windows into getWindowsContext and move the method
3273 out of GraphicsContextCairo and into GraphicsContextWin.
3276 * WebCore.vcproj/WebCore/WebCore.vcproj:
3277 * platform/cairo/GraphicsContextCairo.cpp:
3278 * platform/win/GraphicsContextWin.cpp: Added.
3279 (WebCore::GraphicsContext::getWindowsContext):
3280 (WebCore::GraphicsContext::releaseWindowsContext):
3281 * rendering/RenderThemeWin.cpp:
3282 (WebCore::prepareForDrawing):
3284 2006-09-24 Eric Seidel <eric@eseidel.com>
3288 <svg:a> cannot be styled with a:hover
3289 http://bugs.webkit.org/show_bug.cgi?id=11005
3291 Test: svg/hixie/cascade/002.xml
3293 * css/cssstyleselector.cpp:
3294 (WebCore::checkPseudoState):
3296 2006-09-24 Sam Weinig <sam.weinig@gmail.com>
3300 Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
3301 SVG needs Obj-C DOM bindings
3303 - Auto-generate the first 8 Objective-C SVG DOM bindings. The
3304 auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
3305 DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
3306 DOMSVGTransformList.
3308 * DerivedSources.make:
3309 * WebCore.xcodeproj/project.pbxproj:
3310 * bindings/objc/DOMInternal.h:
3311 * bindings/objc/DOMSVG.h: Added.
3312 * ksvg2/svg/SVGAngle.idl:
3313 * ksvg2/svg/SVGLength.idl:
3314 * ksvg2/svg/SVGLengthList.idl:
3315 * ksvg2/svg/SVGMatrix.idl:
3316 * ksvg2/svg/SVGPathSeg.idl:
3317 * ksvg2/svg/SVGPathSegList.idl:
3318 * ksvg2/svg/SVGTransform.idl:
3319 * ksvg2/svg/SVGTransformList.idl:
3321 2006-09-24 Rob Buis <buis@kde.org>
3323 Reviewed by eseidel.
3325 Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
3326 WebKit does not handle fallback custom cursors
3327 Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
3328 WebKit does not properly handle SVG <cursor> element
3330 Add support for svg cursor images. Also make sure hotspot
3331 settings are handled correctly. Add tests for handling of css3
3332 cursor syntax with hotspots in strict and quirks mode. Finally
3335 * WebCore.xcodeproj/project.pbxproj:
3336 * css/CSSComputedStyleDeclaration.cpp:
3337 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3338 * css/CSSCursorImageValue.cpp: Added.
3339 (WebCore::CSSCursorImageValue::CSSCursorImageValue):
3340 (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
3341 * css/CSSCursorImageValue.h: Added.
3342 (WebCore::CSSCursorImageValue::hotspot):
3343 * css/cssparser.cpp:
3344 (WebCore::CSSParser::parseValue):
3345 * css/cssstyleselector.cpp:
3346 (WebCore::CSSStyleSelector::applyProperty):
3347 * ksvg2/svg/SVGCursorElement.cpp:
3348 * manual-tests/css3-cursor-fallback-quirks.html: Added.
3349 * manual-tests/css3-cursor-fallback-strict.html: Added.
3350 * manual-tests/cursorfallback.xml: Added.
3351 * page/FrameView.cpp:
3352 (WebCore::selectCursor):
3353 * platform/Cursor.h:
3354 * platform/mac/CursorMac.mm:
3355 (WebCore::createCustomCursor):
3356 (WebCore::Cursor::Cursor):
3357 * platform/qt/CursorQt.cpp:
3358 (WebCore::Cursor::Cursor):
3359 * rendering/RenderStyle.cpp:
3360 (WebCore::StyleInheritedData::StyleInheritedData):
3361 (WebCore::StyleInheritedData::operator==):
3362 (WebCore::RenderStyle::diff):
3363 (WebCore::RenderStyle::addCursor):
3364 (WebCore::RenderStyle::addSVGCursor):
3365 (WebCore::RenderStyle::setCursorList):
3366 (WebCore::RenderStyle::clearCursorList):
3367 * rendering/RenderStyle.h:
3368 (WebCore::CursorData::CursorData):
3369 (WebCore::CursorList::operator[]):
3370 (WebCore::CursorList::size):
3371 (WebCore::CursorList::append):
3372 (WebCore::RenderStyle::cursors):
3374 2006-09-24 Sam Weinig <sam.weinig@gmail.com>
3378 Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
3379 Auto-generate the internal methods interfaces for the Objective-C bindings
3381 - Auto-generate the internal method declarations into their own files
3382 named in the form DOMFooBarInternal.h for class DOMFooBar.
3384 - Remove all use of DOM_cast from code.
3386 - Assorted cleanups.
3388 * WebCore.xcodeproj/project.pbxproj:
3389 * bindings/objc/DOM.mm:
3390 (-[DOMNode _initWithNode:WebCore::]):
3391 (-[DOMNode WebCore::]):
3392 (-[DOMRange dealloc]):
3393 (-[DOMRange finalize]):
3394 (-[DOMRange _initWithRange:WebCore::]):
3395 (-[DOMRange WebCore::]):
3396 (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
3397 (-[DOMNodeFilter WebCore::]):
3398 (-[DOMNodeFilter dealloc]):
3399 (-[DOMNodeFilter finalize]):
3400 (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
3401 (-[DOMNodeIterator WebCore::]):
3402 (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
3403 (-[DOMTreeWalker WebCore::]):
3404 * bindings/objc/DOMAbstractView.mm:
3405 (-[DOMAbstractView _initWithAbstractView:WebCore::]):
3406 * bindings/objc/DOMCSS.mm:
3407 (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
3408 (-[DOMCSSRule _initWithRule:WebCore::]):
3409 (-[DOMCSSValue _initWithValue:WebCore::]):
3410 * bindings/objc/DOMEvents.mm:
3411 (-[DOMEvent _initWithEvent:WebCore::]):
3412 * bindings/objc/DOMHTMLAppletElement.mm:
3413 (-[DOMHTMLAppletElement align]):
3414 (-[DOMHTMLAppletElement setAlign:]):
3415 (-[DOMHTMLAppletElement alt]):
3416 (-[DOMHTMLAppletElement setAlt:]):
3417 (-[DOMHTMLAppletElement archive]):
3418 (-[DOMHTMLAppletElement setArchive:]):
3419 (-[DOMHTMLAppletElement code]):
3420 (-[DOMHTMLAppletElement setCode:]):
3421 (-[DOMHTMLAppletElement codeBase]):
3422 (-[DOMHTMLAppletElement setCodeBase:]):
3423 (-[DOMHTMLAppletElement height]):
3424 (-[DOMHTMLAppletElement setHeight:]):
3425 (-[DOMHTMLAppletElement hspace]):
3426 (-[DOMHTMLAppletElement setHspace:]):
3427 (-[DOMHTMLAppletElement name]):
3428 (-[DOMHTMLAppletElement setName:]):
3429 (-[DOMHTMLAppletElement object]):
3430 (-[DOMHTMLAppletElement setObject:]):
3431 (-[DOMHTMLAppletElement vspace]):
3432 (-[DOMHTMLAppletElement setVspace:]):
3433 (-[DOMHTMLAppletElement width]):
3434 (-[DOMHTMLAppletElement setWidth:]):
3435 * bindings/objc/DOMInternal.h:
3439 * bindings/objc/DOMXPath.mm:
3440 (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
3441 * bindings/scripts/CodeGeneratorObjC.pm:
3443 2006-09-24 Nikolas Zimmermann <zimmermann@kde.org>
3445 Reviewed by eseidel.
3447 Fix Qt/Linux build after Dave's Scrollbar changes.
3449 * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
3450 * platform/qt/TemporaryLinkStubs.cpp:
3451 (WebCore::ScrollBar::setProportion):
3452 (WebCore::PlatformScrollBar::updateThumbPosition):
3453 (WebCore::PlatformScrollBar::updateThumbProportion):
3455 2006-09-24 Nikolas Zimmermann <zimmermann@kde.org>
3457 Reviewed by eseidel.
3459 Qt/Linux build system changes: enable xpath/xslt by default.
3460 Offer possibility to change all of these using 'ccmake'.
3464 2006-09-24 Dave Hyatt <hyatt@apple.com>
3466 Cleanup of Scrollbar APIs. Rename setKnobProportion to setProportion. Rename setScrollbarValue to updateThumbPosition.
3467 Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
3468 the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
3470 * platform/ScrollBar.cpp:
3471 (WebCore::ScrollBar::setValue):
3472 (WebCore::ScrollBar::setProportion):
3473 * platform/ScrollBar.h:
3474 (WebCore::ScrollBar::value):
3475 * platform/mac/PlatformScrollBar.h:
3476 * platform/mac/PlatformScrollBarMac.mm:
3477 (WebCore::PlatformScrollBar::updateThumbPosition):
3478 (WebCore::PlatformScrollBar::updateThumbProportion):
3479 * platform/win/PlatformScrollBar.h:
3480 * platform/win/TemporaryLinkStubs.cpp:
3481 (PlatformScrollBar::updateThumbPosition):
3482 (PlatformScrollBar::updateThumbProportion):
3483 * rendering/RenderLayer.cpp:
3484 (WebCore::RenderLayer::updateScrollInfoAfterLayout):
3486 2006-09-23 Alexey Proskuryakov <ap@nypop.com>
3490 http://bugs.webkit.org/show_bug.cgi?id=4872
3491 XMLHttpRequest fails to throw an exception when there is a security violation
3492 (mismatching domains)
3494 Raise an exception if there is a security violation, and also in cases required by
3495 the current draft of XHR specification.
3497 * bindings/js/JSXMLHttpRequest.cpp:
3498 (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
3499 (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
3500 reports one, and also if there were too few arguments passed.
3502 * bindings/js/kjs_binding.cpp:
3503 (KJS::setDOMException): Added support for custom XHR exceptions.
3505 * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
3506 exception code range for XHR exceptions.
3508 * xml/xmlhttprequest.cpp:
3509 (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
3510 (WebCore::XMLHttpRequest::send):
3511 (WebCore::XMLHttpRequest::setRequestHeader):
3512 (WebCore::XMLHttpRequest::getStatus):
3513 (WebCore::XMLHttpRequest::getStatusText):
3514 (WebCore::XMLHttpRequest::processSyncLoadResults):
3515 (WebCore::XMLHttpRequest::receivedAllData):
3516 (WebCore::XMLHttpRequest::receivedData):
3518 2006-09-22 Steve Falkenburg <sfalken@apple.com>
3520 Reviewed by Jeff Jenkins.
3524 * platform/cf/ResourceLoaderCFNet.cpp:
3525 (WebCore::willCacheResponse):
3527 2006-09-22 Justin Garcia <justin.garcia@apple.com>
3531 <http://bugs.webkit.org/show_bug.cgi?id=8029>
3532 Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
3535 (WebCore::Document::clearSelectionIfNeeded):
3537 (WebCore::Element::contains):
3539 (WebCore::Node::traverseNextNode):
3540 (WebCore::Node::traverseNextSibling):
3541 (WebCore::Node::traversePreviousNodePostOrder):
3542 (WebCore::Node::checkAddChild):
3543 (WebCore::Node::isDescendantOf):
3545 * dom/NodeIterator.cpp:
3546 (WebCore::NodeIterator::notifyBeforeNodeRemoval):
3547 * editing/ApplyStyleCommand.cpp:
3548 (WebCore::ApplyStyleCommand::applyBlockStyle):
3549 (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
3550 (WebCore::ApplyStyleCommand::applyInlineStyle):
3551 (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
3552 * editing/CompositeEditCommand.cpp:
3553 (WebCore::CompositeEditCommand::mergeIdenticalElements):
3554 (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
3555 * editing/DeleteSelectionCommand.cpp:
3556 (WebCore::updatePositionForNodeRemoval):
3557 (WebCore::DeleteSelectionCommand::handleGeneralDelete):
3558 (WebCore::DeleteSelectionCommand::mergeParagraphs):
3559 * editing/FormatBlockCommand.cpp:
3560 (WebCore::FormatBlockCommand::doApply):
3561 * editing/IndentOutdentCommand.cpp:
3562 (WebCore::enclosingListOrBlockquote):
3563 * editing/Selection.cpp:
3564 (WebCore::Selection::validate):
3565 * editing/SelectionController.cpp:
3566 (WebCore::SelectionController::nodeWillBeRemoved):
3567 * editing/TextIterator.cpp:
3568 (WebCore::SimplifiedBackwardsTextIterator::advance):
3569 * editing/VisiblePosition.cpp:
3570 (WebCore::VisiblePosition::next):
3571 (WebCore::VisiblePosition::previous):
3572 (WebCore::VisiblePosition::canonicalPosition):
3573 (WebCore::isFirstVisiblePositionInNode):
3574 (WebCore::isLastVisiblePositionInNode):
3575 * editing/htmlediting.cpp:
3576 (WebCore::firstEditablePositionAfterPositionInRoot):
3577 (WebCore::lastEditablePositionBeforePositionInRoot):
3578 (WebCore::enclosingNodeWithTag):
3579 (WebCore::enclosingList):
3580 (WebCore::enclosingListChild):
3581 * editing/markup.cpp:
3582 (WebCore::createMarkup):
3584 2006-09-22 Timothy Hatcher <timothy@apple.com>
3588 - Added @property syntax to non-generated headers
3589 inside #ifndef BUILDING_ON_TIGER.
3590 - Changed the DOMEventTarget protocol to have have new versions
3591 of addEventListener and removeEventListener with named parameters.
3592 These old style methods can be removed once Mail changes to use
3593 the new methods <rdar://problem/4746649>.
3595 * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
3596 * bindings/objc/DOM.mm:
3597 (-[DOMNode addEventListener:listener:useCapture:]):
3598 (-[DOMNode addEventListener:::]): call the new method
3599 (-[DOMNode removeEventListener:listener:useCapture:]):
3600 (-[DOMNode removeEventListener:::]): call the new method
3601 * bindings/objc/DOMAbstractView.h:
3602 * bindings/objc/DOMEventTarget.h:
3603 * bindings/objc/DOMHTMLAppletElement.h:
3604 * bindings/objc/DOMHTMLEmbedElement.h:
3605 * bindings/objc/DOMHTMLOptionElement.h:
3606 * bindings/objc/DOMObject.h:
3607 * bindings/objc/DOMRGBColor.h:
3609 2006-09-22 Nikolas Zimmermann <zimmermann@kde.org>
3613 Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
3615 * platform/qt/FrameQt.cpp:
3616 * platform/qt/GraphicsContextQt.cpp:
3617 (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
3618 (WebCore::GraphicsContext::origin):
3619 * platform/qt/PlatformScrollBar.h: Added.
3620 (WebCore::PlatformScrollBar::isWidget):
3621 * platform/qt/WidgetQt.cpp:
3622 (WebCore::Widget::invalidate):
3623 (WebCore::Widget::invalidateRect):
3625 2006-09-22 Dave Hyatt <hyatt@apple.com>
3627 Super-minor tweaks to the systemFont function on Mac.
3628 Set the generic family to None rather than to Serif, and
3629 don't waste time setting the computed size, since that is
3630 set from the specified size over in CSSStyleSelector anyway.
3632 * rendering/RenderThemeMac.mm:
3633 (WebCore::RenderThemeMac::systemFont):
3635 2006-09-22 Timothy Hatcher <timothy@apple.com>
3639 Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
3640 take floats. There was already an implicit conversion to float/double
3641 when calling CGContextTranslateCTM or cairo_translate.
3643 * platform/GraphicsContext.h:
3644 * platform/cairo/GraphicsContextCairo.cpp:
3645 (WebCore::GraphicsContext::translate):
3646 * platform/cg/GraphicsContextCG.cpp:
3647 (WebCore::GraphicsContext::translate):
3649 2006-09-22 Brady Eidson <beidson@apple.com>
3653 Add redirect and other cleanup to ResourceLoaderWin.cpp
3654 Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10927
3655 Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10744
3657 * WebCore.xcodeproj/project.pbxproj:
3658 * platform/ResourceLoader.h:
3659 * platform/win/ResourceLoaderWin.cpp:
3660 (WebCore::ResourceLoaderWndProc):
3661 (WebCore::initializeOffScreenResourceLoaderWindow):
3662 (WebCore::ResourceLoader::onHandleCreated):
3663 (WebCore::ResourceLoader::onRequestRedirected):
3664 (WebCore::ResourceLoader::onRequestComplete):
3665 (WebCore::transferJobStatusCallback):
3667 2006-09-22 Alexey Proskuryakov <ap@nypop.com>
3671 http://bugs.webkit.org/show_bug.cgi?id=10803
3672 REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
3674 * page/FrameView.cpp:
3675 (WebCore::FrameView::hoverTimerFired): Use the current event.
3677 2006-09-22 Nikolas Zimmermann <zimmermann@kde.org>
3681 Fix (last) svg memory leak.
3683 * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
3684 (SVGTransformable::parseTransformAttribute):
3686 2006-09-22 Eric Seidel <eric@eseidel.com>
3688 No review necessary, just removing a dead file.
3690 Remove unused file (added previously by mistake) to make room for real implementation.
3692 * platform/mac/BitmapImageMac.mm: Removed.
3694 2006-09-22 Dave Hyatt <hyatt@apple.com>
3696 Move PlatformScrollBar.h down into the platforms.
3698 Reviewed by andersca
3700 * platform/PlatformScrollBar.h: Removed.
3701 * platform/win/PlatformScrollBar.h: Added.
3702 * platform/mac/PlatformScrollBar.h: Added.
3704 2006-09-22 Dave Hyatt <hyatt@apple.com>
3706 Add support for invalidation of widgets. This will be needed for the Win32 widget subsystem (and for
3707 any widget subsystems that don't have any underlying native objects backing the widgets.
3711 * platform/Widget.h:
3712 * platform/mac/WidgetMac.mm:
3713 (WebCore::Widget::invalidate):
3714 (WebCore::Widget::invalidateRect):
3715 * platform/win/TemporaryLinkStubs.cpp:
3716 (Widget::invalidate):
3717 (Widget::invalidateRect):
3719 2006-09-22 Rob Buis <buis@kd.org>
3721 Reviewed by eseidel.
3723 http://bugs.webkit.org/show_bug.cgi?id=10901
3724 Merge build fixes from unity
3728 2006-09-21 Nikolas Zimmermann <zimmermann@kde.org>
3730 Reviewed by eseidel.
3732 http://bugs.webkit.org/show_bug.cgi?id=10977
3733 SVGDocument does not expose 'rootElement' property
3735 Enable 'rootElement' property.
3737 * ksvg2/svg/SVGDocument.idl:
3739 2006-09-21 Steve Falkenburg <sfalken@apple.com>
3743 * platform/ResourceLoaderInternal.h:
3745 2006-09-21 Geoffrey Garen <ggaren@apple.com>
3747 build fixed. band happy.
3749 * platform/cg/GraphicsContextCG.cpp:
3750 (WebCore::GraphicsContext::translate):
3751 * platform/mac/WidgetMac.mm:
3753 2006-09-21 Geoffrey Garen <ggaren@apple.com>
3757 Some Widget refactoring.
3759 * WebCore.vcproj/WebCore/WebCore.vcproj:
3760 * bridge/mac/FrameMac.mm:
3761 * bridge/win/FrameWin.cpp:
3762 (WebCore::FrameWin::runJavaScriptAlert):
3763 (WebCore::FrameWin::runJavaScriptConfirm):
3764 * bridge/win/PageWin.cpp:
3765 (WebCore::Page::Page):
3766 (WebCore::rootWindowForFrame):
3767 * html/CanvasRenderingContext2D.cpp:
3768 (WebCore::CanvasRenderingContext2D::translate):
3769 * page/FrameView.cpp:
3770 (WebCore::FrameView::isFrameView):
3772 (WebCore::Page::setInstanceHandle):
3773 (WebCore::Page::instanceHandle):
3774 * platform/GraphicsContext.h:
3775 * platform/ScrollView.h:
3776 * platform/Widget.h:
3777 * platform/cairo/GraphicsContextCairo.cpp:
3778 (WebCore::GraphicsContext::translate):
3779 (WebCore::GraphicsContext::origin):
3780 * platform/mac/WidgetMac.mm:
3781 (WebCore::Widget::clearFocus):
3782 * platform/win/ResourceLoaderWin.cpp:
3783 (WebCore::initializeOffScreenResourceLoaderWindow):
3784 * platform/win/ScreenWin.cpp:
3785 (WebCore::monitorInfo):
3786 * platform/win/ScrollViewWin.cpp:
3787 (WebCore::ScrollView::updateContents):
3788 (WebCore::ScrollView::visibleWidth):
3789 (WebCore::ScrollView::visibleHeight):
3790 (WebCore::ScrollView::visibleContentRect):
3791 (WebCore::ScrollView::viewportToContents):
3792 (WebCore::ScrollView::contentsToViewport):
3793 (WebCore::ScrollView::scrollBy):
3794 (WebCore::ScrollView::updateScrollInfo):
3795 (WebCore::ScrollView::updateScrollBars):
3796 * platform/win/SharedTimerWin.cpp:
3797 (WebCore::initializeOffScreenTimerWindow):
3798 * platform/win/TemporaryLinkStubs.cpp:
3799 (FrameView::updateBorder):
3800 (ScrollView::paint):
3801 (GraphicsContext::clip):
3802 * platform/win/WidgetWin.cpp:
3803 (WebCore::Widget::Widget):
3804 (WebCore::Widget::parentWindow):
3805 (WebCore::Widget::setParentWindow):
3806 (WebCore::Widget::frameGeometry):
3807 (WebCore::Widget::hasFocus):
3808 (WebCore::Widget::setFocus):
3809 (WebCore::Widget::show):
3810 (WebCore::Widget::hide):
3811 (WebCore::Widget::setFrameGeometry):
3813 2006-09-22 Anders Carlsson <acarlsson@apple.com>
3817 * platform/TextEncoding.cpp:
3818 (WebCore::TextEncoding::backslashAsCurrencySymbol):
3819 Add comment clarifying why backslashAsCurrencySymbol is needed.
3821 2006-09-21 Sean Gies <seangies@apple.com>
3823 Reviewed by Adam Roben.
3825 Add utility functions to get and release HDC from GraphicsContext.
3827 * platform/GraphicsContext.h: Add utilities to get and release HDC.
3828 * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
3829 * rendering/RenderThemeWin.cpp: Switch to new utilities.
3831 2006-09-21 Justin Garcia <justin.garcia@apple.com>
3835 <rdar://problem/4426622>
3836 Plain text paste slow. Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
3838 * editing/htmlediting.cpp:
3839 (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
3840 aren't producing complicated sequences here. Use multiple UChar -> UChar replaces instead for speed.
3841 Got rid of uses of DepricatedString.
3843 2006-09-21 Nikolas Zimmermann <zimmermann@kde.org>
3845 Reviewed by eseidel.
3847 Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
3850 (WebCore::Frame::endIfNotLoading):
3852 2006-09-21 Nikolas Zimmermann <zimmermann@kde.org>
3854 Reviewed by eseidel.
3859 * kcanvas/device/qt/KCanvasClipperQt.h:
3860 * kcanvas/device/qt/KRenderingDeviceQt.cpp:
3861 * platform/qt/FrameQt.cpp:
3862 (WebCore::FrameQt::isLoadTypeReload):
3863 (WebCore::FrameQt::originalRequestURL):
3864 * platform/qt/FrameQt.h:
3865 * platform/qt/GraphicsContextQt.cpp:
3866 (WebCore::GraphicsContext::concatCTM):
3867 * platform/qt/ScrollViewQt.cpp:
3868 (WebCore::ScrollView::wheelEvent):
3869 * platform/qt/TemporaryLinkStubs.cpp:
3870 (WebCore::IconDatabase::setIconURLForPageURL):
3872 2006-09-20 Justin Garcia <justin.garcia@apple.com>
3876 <http://bugs.webkit.org/show_bug.cgi?id=7165>
3877 TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
3879 * editing/MoveSelectionCommand.cpp:
3880 (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
3881 to the position-to-move-to's document, not the fragment's document. The
3882 fragment's document is the document used to create the fragment and is irrelavant.
3884 === Safari-521.27 ===
3886 2006-09-21 Brady Eidson <beidson@apple.com>
3890 When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
3891 This fixes Spinneret so it won't crash on its first load!
3894 (WebCore::Frame::endIfNotLoading):
3896 2006-09-21 Brady Eidson <beidson@apple.com>
3900 * platform/win/TemporaryLinkStubs.cpp:
3901 (ScrollView::wheelEvent):
3903 2006-09-20 Rob Buis <buis@kde.org>
3905 Reviewed by eseidel.
3907 http://bugs.webkit.org/show_bug.cgi?id=10946
3908 new marker code draws end-marker in wrong place
3910 Keep track of the start of the subpath so we can handle
3911 closeTo/moveTo correctly.
3913 * kcanvas/RenderPath.cpp:
3914 (WebCore::DrawMarkersData::DrawMarkersData):
3915 (WebCore::updateMarkerDataForElement):
3917 2006-09-21 David Hyatt <hyatt@apple.com>
3919 Wheel scrolling prep for Win32.
3921 WARNING: NO TEST CASES ADDED OR CHANGED
3923 * platform/PlatformWheelEvent.h:
3924 * platform/ScrollBar.h:
3925 * platform/ScrollView.h:
3926 * platform/mac/ScrollViewMac.mm:
3927 (WebCore::ScrollView::wheelEvent):
3928 * rendering/RenderLayer.cpp:
3930 2006-09-20 Timothy Hatcher <timothy@apple.com>
3934 Bug 10917: REGRESSION (r16027): iFrame transparency broken
3935 http://bugs.webkit.org/show_bug.cgi?id=10917
3937 Don't paint the base background color if we transparent.
3939 * rendering/RenderBox.cpp:
3940 (WebCore::RenderBox::paintBackgroundExtended):
3942 2006-09-20 Adam Roben <aroben@apple.com>
3944 Reviewed by andersca.
3946 * platform/FileChooser.h: Remove no-longer-necessary namespace std
3948 2006-09-20 Eric Seidel <eric@eseidel.com>
3952 Cleanup style in KCanvas.
3953 Remove extra white-space, unneeded arguments, etc.
3955 * WebCore.xcodeproj/project.pbxproj:
3956 * kcanvas/KCanvasClipper.cpp:
3957 (WebCore::operator<<):
3958 (WebCore::KCanvasClipper::externalRepresentation):
3959 * kcanvas/KCanvasClipper.h:
3960 * kcanvas/KCanvasFilters.cpp:
3961 (WebCore::KCanvasFilter::externalRepresentation):
3962 (WebCore::operator<<):
3963 (WebCore::KCanvasFilterEffect::externalRepresentation):
3964 (WebCore::KCPointLightSource::externalRepresentation):
3965 (WebCore::KCSpotLightSource::externalRepresentation):
3966 (WebCore::KCDistantLightSource::externalRepresentation):
3967 (WebCore::KCanvasFEBlend::externalRepresentation):
3968 (WebCore::KCanvasFEColorMatrix::externalRepresentation):
3969 (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
3970 (WebCore::KCanvasFEComposite::externalRepresentation):
3971 (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
3972 (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
3973 (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
3974 (WebCore::KCanvasFEFlood::externalRepresentation):
3975 (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
3976 (WebCore::KCanvasFEImage::externalRepresentation):
3977 (WebCore::KCanvasFEMerge::externalRepresentation):
3978 (WebCore::KCanvasFEMorphology::externalRepresentation):
3979 (WebCore::KCanvasFEOffset::externalRepresentation):
3980 (WebCore::KCanvasFESpecularLighting::externalRepresentation):
3981 (WebCore::KCanvasFETile::externalRepresentation):
3982 (WebCore::KCanvasFETurbulence::externalRepresentation):
3983 * kcanvas/KCanvasFilters.h:
3984 (WebCore::KCanvasFEDiffuseLighting::lightSource):
3985 (WebCore::KCanvasFESpecularLighting::lightSource):
3986 * kcanvas/KCanvasImage.h:
3987 * kcanvas/KCanvasMarker.cpp:
3988 (WebCore::KCanvasMarker::externalRepresentation):
3989 * kcanvas/KCanvasMarker.h:
3990 * kcanvas/KCanvasResource.cpp:
3991 (WebCore::operator<<):
3992 * kcanvas/KCanvasResource.h:
3993 * kcanvas/KCanvasTreeDebug.cpp:
3994 (WebCore::operator<<):
3995 (WebCore::writeIndent):
3996 (WebCore::writeStyle):
3998 (WebCore::writeRenderResources):
3999 * kcanvas/KCanvasTreeDebug.h:
4000 (WebCore::operator<<):
4001 * kcanvas/RenderForeignObject.cpp:
4002 (WebCore::RenderForeignObject::paint):
4003 * kcanvas/RenderPath.cpp:
4004 (WebCore::RenderPath::paint):
4005 (WebCore::drawStartAndMidMarkers):
4006 * kcanvas/RenderSVGContainer.cpp:
4007 (WebCore::RenderSVGContainer::paint):
4008 * kcanvas/RenderSVGImage.cpp:
4009 (WebCore::RenderSVGImage::translateForAttributes):
4010 * kcanvas/RenderSVGImage.h:
4011 * kcanvas/device/KRenderingDevice.cpp:
4012 (WebCore::KRenderingDevice::currentContext):
4013 (WebCore::KRenderingDevice::popContext):
4014 (WebCore::KRenderingDevice::pushContext):
4015 * kcanvas/device/KRenderingDevice.h:
4016 * kcanvas/device/KRenderingFillPainter.h:
4017 * kcanvas/device/KRenderingPaintServer.h:
4018 (WebCore::KRenderingPaintServer::KRenderingPaintServer):
4019 (WebCore::KRenderingPaintServer::activeClient):
4020 (WebCore::KRenderingPaintServer::setActiveClient):
4021 * kcanvas/device/KRenderingPaintServerGradient.cpp:
4022 (WebCore::operator<<):
4023 (WebCore::KRenderingPaintServerGradient::externalRepresentation):
4024 (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
4025 (WebCore::KRenderingPaintServerGradient::listener):
4026 (WebCore::KRenderingPaintServerGradient::setListener):
4027 (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
4028 * kcanvas/device/KRenderingPaintServerGradient.h:
4029 * kcanvas/device/KRenderingPaintServerPattern.cpp:
4030 (WebCore::KRenderingPaintServerPattern::tile):
4031 (WebCore::KRenderingPaintServerPattern::setTile):
4032 (WebCore::KRenderingPaintServerPattern::listener):
4033 (WebCore::KRenderingPaintServerPattern::setListener):
4034 (WebCore::KRenderingPaintServerPattern::externalRepresentation):
4035 * kcanvas/device/KRenderingPaintServerPattern.h:
4036 * kcanvas/device/KRenderingPaintServerSolid.cpp:
4037 (WebCore::KRenderingPaintServerSolid::externalRepresentation):
4038 * kcanvas/device/KRenderingPaintServerSolid.h:
4039 * kcanvas/device/KRenderingStrokePainter.cpp:
4040 (WebCore::KRenderingStrokePainter::strokeMiterLimit):
4041 (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
4042 * kcanvas/device/KRenderingStrokePainter.h:
4043 * kcanvas/device/quartz/KCanvasFilterQuartz.h:
4044 * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
4045 (WebCore::KCanvasFilterQuartz::prepareFilter):
4046 * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
4047 * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
4048 (WebCore::KCanvasMaskerQuartz::applyMask):
4049 * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
4050 (WebCore::KCanvasImageQuartz::init):
4051 * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
4052 (WebCore::KCanvasClipperQuartz::applyClip):
4053 * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
4054 * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
4055 (WebCore::KRenderingDeviceQuartz::quartzContext):
4056 (WebCore::KRenderingDeviceQuartz::contextForImage):
4057 (WebCore::KRenderingDeviceQuartz::createPaintServer):
4058 (WebCore::KRenderingDeviceQuartz::createResource):
4059 (WebCore::KRenderingDeviceQuartz::createFilterEffect):
4060 * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
4061 (WebCore::CGShadingRefForLinearGradient):
4062 (WebCore::CGShadingRefForRadialGradient):
4063 (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
4064 (WebCore::KRenderingPaintServerGradientQuartz::teardown):
4065 * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
4066 * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
4067 (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
4068 (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
4069 (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
4070 (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
4071 (WebCore::KRenderingPaintServerSolidQuartz::draw):
4072 (WebCore::KRenderingPaintServerSolidQuartz::setup):
4073 (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
4074 (WebCore::KRenderingPaintServerPatternQuartz::setup):
4075 (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
4076 (WebCore::KRenderingPaintServerPatternQuartz::teardown):
4077 * kcanvas/device/quartz/QuartzSupport.h:
4078 * kcanvas/device/quartz/QuartzSupport.mm:
4079 (WebCore::applyStrokeStyleToContext):
4081 2006-09-20 Anders Carlsson <acarlsson@apple.com>
4083 Reviewed by Dave Hyatt.
4085 * dom/WheelEvent.cpp:
4086 (WebCore::WheelEvent::WheelEvent):
4087 Use lroundf instead of lround since deltas are floats.
4089 2006-09-20 Julien Palmas <julien.palmas@gmail.com>
4091 Reviewed by eseidel. Landed by eseidel.
4093 Test: svg/custom/pattern-y-offset.svg
4095 * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
4096 (WebCore::KRenderingPaintServerPatternQuartz::setup):
4098 2006-09-20 David Hyatt <hyatt@apple.com>
4100 Add a new wheelEvent method to ScrollView. Platforms that wish
4101 to handle the wheel event for the scroll view themselves can then
4102 do so there. (Mac lets the underlying NSScrollView do it for now.)
4104 * page/FrameView.cpp:
4105 (WebCore::FrameView::handleWheelEvent):
4106 * platform/ScrollView.h:
4107 (WebCore::ScrollView::wheelEvent):
4109 2006-09-20 Brady Eidson <beidson@apple.com>
4111 Reviewed by Tim Omernick
4113 Part of fixing a crash Tim O showed me that I missed in a release build.
4114 WebKit should be able to call through the bridge to WebCore no matter what -
4115 Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
4117 * bridge/mac/WebCoreIconDatabaseBridge.h:
4118 * bridge/mac/WebCoreIconDatabaseBridge.mm:
4119 (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
4120 (-[WebCoreIconDatabaseBridge isOpen]):
4121 (-[WebCoreIconDatabaseBridge removeAllIcons]):
4122 (-[WebCoreIconDatabaseBridge _isEmpty]):
4123 (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
4124 (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
4125 (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
4126 (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
4127 (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
4128 (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
4129 (-[WebCoreIconDatabaseBridge retainIconForURL:]):
4130 (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
4131 (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
4132 (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
4133 (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
4134 (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
4135 (-[WebCoreIconDatabaseBridge _setEnabled:]):
4136 (-[WebCoreIconDatabaseBridge _isEnabled]):
4138 2006-09-20 Anders Carlsson <acarlsson@apple.com>
4142 Add String::split which returns a Vector of Strings and use it instead of
4143 DeprecatedStringList.
4145 * bindings/js/kjs_events.cpp:
4146 (KJS::Clipboard::getValueProperty):
4147 * bindings/js/kjs_window.cpp:
4148 (KJS::parseModalDialogFeatures):
4149 * css/MediaList.cpp:
4150 (WebCore::MediaList::setMediaText):
4152 * html/HTMLFormElement.cpp:
4153 (WebCore::HTMLFormElement::formData):
4154 * html/HTMLLinkElement.cpp:
4155 (WebCore::HTMLLinkElement::tokenizeRelAttribute):
4156 * platform/PlatformString.h:
4157 * platform/String.cpp:
4158 (WebCore::String::split):
4159 * platform/StringImpl.cpp:
4160 * platform/StringImpl.h:
4161 * platform/mac/ClipboardMac.h:
4162 * platform/mac/ClipboardMac.mm:
4163 (WebCore::ClipboardMac::types):
4165 2006-09-20 Justin Garcia <justin.garcia@apple.com>
4167 Reviewed by harrison
4169 * css/cssstyleselector.cpp:
4170 (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
4171 HTMLElement::isContentEditable just to check the Frame's editability, since
4172 it calls updateRenderering, which can get us into infinite recursion.
4174 2006-09-20 Brady Eidson <beidson@apple.com>
4178 Cleaned up my last patch alot, and made the WebCore icon database disabled by default
4180 * loader/icon/IconDatabase.cpp:
4181 (WebCore::IconDatabase::IconDatabase): Disabled by default
4182 (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
4183 (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
4184 (WebCore::IconDatabase::iconForPageURL): Ditto
4185 (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
4186 (WebCore::IconDatabase::iconURLForPageURL): Ditto
4187 (WebCore::IconDatabase::retainIconForPageURL): Ditto
4188 (WebCore::IconDatabase::releaseIconForPageURL): Ditto
4189 (WebCore::IconDatabase::setIconDataForIconURL): Ditto
4190 (WebCore::IconDatabase::setIconURLForPageURL): Ditto
4191 (WebCore::IconDatabase::hasEntryForIconURL): Ditto
4192 (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
4194 2006-09-20 Adam Roben <aroben@apple.com>
4198 Fixes http://bugs.webkit.org/show_bug.cgi?id=10935
4199 REGRESSION: file upload control with direction:rtl or text-align:right
4200 draws button on top of filename/icon
4202 * rendering/RenderFileUploadControl.cpp:
4203 (WebCore::RenderFileUploadControl::setStyle): Force text-align to
4205 (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
4206 the filename and icon in RTL
4208 2006-09-20 Alice Liu <alice.liu@apple.com>
4210 Reviewed by Adam Roben.
4214 * dom/WheelEvent.cpp:
4215 (WebCore::WheelEvent::WheelEvent):
4216 changed lrint to lround
4218 2006-09-20 Sam Weinig <sam.weinig@gmail.com>
4220 Build Fix. Adds isHorizontal attribute back to WheelEvent
4221 for the Objective-C bindings. If it is found that isHorizontal
4222 is not used, we should remove it again but also remove it's
4223 declaration from PublicDOMInterfaces.h
4226 (WebCore::WheelEvent::isHorizontal):
4227 * dom/WheelEvent.idl:
4229 2006-09-20 David Hyatt <hyatt@apple.com>
4231 Fix for 10945, WheelEvent should support two dimensions at once, since
4232 MacBooks allow for diagonal scrolling. Also enhance the PlatformWheelEvent
4233 to allow for diagonal scrolling.
4237 * dom/EventTargetNode.cpp:
4238 (WebCore::EventTargetNode::dispatchWheelEvent):
4239 * dom/WheelEvent.cpp:
4240 (WebCore::WheelEvent::WheelEvent):
4241 (WebCore::WheelEvent::initWheelEvent):
4243 (WebCore::WheelEvent::wheelDelta):
4244 (WebCore::WheelEvent::wheelDeltaX):
4245 (WebCore::WheelEvent::wheelDeltaY):
4246 * dom/WheelEvent.idl:
4247 * page/FrameView.cpp:
4248 (WebCore::FrameView::handleWheelEvent):
4249 * platform/PlatformWheelEvent.h:
4250 (WebCore::PlatformWheelEvent::deltaX):
4251 (WebCore::PlatformWheelEvent::deltaY):
4252 (WebCore::PlatformWheelEvent::normalize):
4253 * platform/mac/WheelEventMac.mm:
4254 (WebCore::PlatformWheelEvent::PlatformWheelEvent):
4256 2006-09-19 Eric Seidel <eric@eseidel.com>
4260 Split KCanvasResources.* into multiple files (and some other minor spacing changes).
4262 No tests were harmed in the making of this patch.
4264 * WebCore.xcodeproj/project.pbxproj:
4265 * kcanvas/KCanvasClipper.cpp: Added.
4266 (WebCore::operator<<):
4267 * kcanvas/KCanvasClipper.h: Added.
4268 * kcanvas/KCanvasFilters.h:
4269 * kcanvas/KCanvasImage.h:
4270 * kcanvas/KCanvasMarker.cpp: Added.
4271 * kcanvas/KCanvasMarker.h: Added.
4272 * kcanvas/KCanvasMasker.cpp: Added.
4273 (WebCore::KCanvasMasker::KCanvasMasker):
4274 (WebCore::KCanvasMasker::setMask):
4275 (WebCore::KCanvasMasker::externalRepresentation):
4276 (WebCore::getMaskerById):
4277 * kcanvas/KCanvasMasker.h: Added.
4278 * kcanvas/KCanvasResource.cpp: Added.
4279 (WebCore::KCanvasResource::invalidate):
4280 (WebCore::KCanvasResource::externalRepresentation):