Reviewed by Eric.
[WebKit-https.git] / WebCore / ChangeLog
1 2006-08-22  Rob Buis  <buis@kde.org>
2
3         Reviewed by Eric.
4
5         http://bugzilla.opendarwin.org/show_bug.cgi?id=10405
6         REPRO: SVG Maze crashes in RenderPath code
7
8         Do not render a path when it is empty so maze15.svg does not crash anymore.
9         Also get rid of a runtime warning issued by CGContextGetPathBoundingBox.
10
11         * kcanvas/RenderPath.cpp:
12         (WebCore::RenderPath::paint):
13         * kcanvas/device/quartz/KCanvasPathQuartz.mm:
14         (WebCore::KCanvasPathQuartz::strokeBoundingBox):
15
16 2006-08-21  Brady Eidson  <beidson@apple.com>
17
18         Reviewed by Maciej
19
20         <rdar://4690949> - New IconDB: Need to prune unretained icons on startup
21
22         Added a flag to track whether or not the initial pruning has taken place on startup
23         If that flag is not set, IconURL retain counts will be tracked in a temporary db table
24         in addition to the in-memory hash.  Then when the timer fires after initial retains
25         are complete, we prune those icons not in the retain table, prune dangling PageURL
26         references, delete the temporary table, and set the flag - and carry on as normal
27
28         * loader/icon/IconDatabase.cpp:
29         (WebCore::IconDatabase::IconDatabase): initialize the flag
30         (WebCore::IconDatabase::open): changed the schema of the temporary table
31         (WebCore::IconDatabase::retainIconURL): store the icon retain to the temp table if starting up
32         (WebCore::IconDatabase::releaseIconURL): ditto
33         (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): remove all icons *not* in the retain table, then
34           wipe all the PageURLs who no longer point to a valid IconURL
35         * loader/icon/IconDatabase.h:
36
37 2006-08-21  Alexey Proskuryakov  <ap@nypop.com>
38
39         Reviewed by Eric.
40
41         http://bugzilla.opendarwin.org/show_bug.cgi?id=10419
42         XSLTProcessor transformToFragment fails because of an XML declaration
43
44         Test: fast/xsl/transformToFragment-XML-declaration.html
45
46         * xml/XSLTProcessor.cpp:
47         (WebCore::XSLTProcessor::transformToString): Always inhibit XML declaration printout.
48
49 2006-08-21  David Harrison  <harrison@apple.com>
50
51         Reviewed by Justin.
52
53         <rdar://problem/4471481> Represent misspellings in AXAttributedStringForTextMarkerRange
54
55         Added support for the NSAccessibilityMisspelledTextAttribute.
56         
57         Test cases added: None.  Manual AX testing is way too awkward, and automated testing
58         is not possible.  See following bug...
59             <rdar://problem/4256882> Need automated testing support for accessibility APIs
60
61         * bridge/mac/WebCoreAXObject.mm:
62         Lots of trivial formatting in many methods.
63         
64         (-[WebCoreAXObject accessibilityAttributeValue:]):
65         Fixed AXStartTextMarker and AXEndTextMarker to use startOfDocument and endOfDocument, instead of
66         of positionForCoordinates. I had seen erroneous endOfDocument results while testing the spelling
67         attribute.
68
69         (WebCore::AXAttributeStringSetSpelling): 
70         New. Adds the NSAccessibilityMisspelledTextAttribute for misspelled words.
71
72         (-[WebCoreAXObject AXAttributedStringAppendText:]):
73         Added call to AXAttributeStringSetSpelling.
74         
75         * editing/visible_units.cpp:
76         (WebCore::startOfDocument):
77         (WebCore::endOfDocument):
78         Added for AXStartTextMarker/AXEndTextMarker fix, these forms of the familiar functions take a Node*,
79         so a previously existing VisiblePosition is not required.
80         
81         * editing/visible_units.h:
82         Declare new forms of startOfDocument and endOfDocument.
83
84 2006-08-21  Nikolas Zimmermann  <zimmermann@kde.org>
85
86         Reviewed by Eric.
87
88         Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
89         WebKit should have Qt platform support
90
91         * platform/qt/TemporaryLinkStubs.cpp: Added.
92         (JavaAppletWidget::JavaAppletWidget):
93         (Font::selectionRectForComplexText):
94         (Font::offsetForPositionForComplexText):
95         (WebCore::refreshPlugins):
96         (WebCore::focusRingColor):
97         (Image::drawTiled):
98         (WebCore::TextField::selectAll):
99         (WebCore::TextField::addSearchResult):
100         (WebCore::TextField::selectionStart):
101         (WebCore::TextField::hasSelectedText):
102         (WebCore::TextField::selectedText):
103         (WebCore::TextField::setAutoSaveName):
104         (WebCore::TextField::checksDescendantsForFocus):
105         (WebCore::TextField::setSelection):
106         (WebCore::TextField::setMaxResults):
107         (WebCore::TextField::edited):
108         (WebCore::TextField::focusPolicy):
109         (WebCore::TextField::TextField):
110         (WebCore::TextField::~TextField):
111         (WebCore::TextField::setFont):
112         (WebCore::TextField::setAlignment):
113         (WebCore::TextField::setWritingDirection):
114         (WebCore::TextField::maxLength):
115         (WebCore::TextField::setMaxLength):
116         (WebCore::TextField::text):
117         (WebCore::TextField::setText):
118         (WebCore::TextField::cursorPosition):
119         (WebCore::TextField::setCursorPosition):
120         (WebCore::TextField::setEdited):
121         (WebCore::TextField::setReadOnly):
122         (WebCore::TextField::setPlaceholderString):
123         (WebCore::TextField::setColors):
124         (WebCore::TextField::sizeForCharacterWidth):
125         (WebCore::TextField::baselinePosition):
126         (WebCore::TextField::setLiveSearch):
127         (WebCore::Slider::Slider):
128         (WebCore::Slider::sizeHint):
129         (WebCore::Slider::~Slider):
130         (WebCore::Slider::setValue):
131         (WebCore::Slider::setMaxValue):
132         (WebCore::Slider::setMinValue):
133         (WebCore::Slider::setFont):
134         (WebCore::Slider::value):
135         (WebCore::Slider::focusPolicy):
136         (WebCore::ScrollBar::ScrollBar):
137         (WebCore::ScrollBar::setSteps):
138         (WebCore::ScrollBar::scroll):
139         (WebCore::ScrollBar::setValue):
140         (WebCore::ScrollBar::setKnobProportion):
141         (WebCore::PlatformScrollBar::PlatformScrollBar):
142         (WebCore::PlatformScrollBar::~PlatformScrollBar):
143         (WebCore::PlatformScrollBar::width):
144         (WebCore::PlatformScrollBar::height):
145         (WebCore::PlatformScrollBar::setEnabled):
146         (WebCore::PlatformScrollBar::paint):
147         (WebCore::PlatformScrollBar::setScrollBarValue):
148         (WebCore::PlatformScrollBar::setKnobProportion):
149         (WebCore::PlatformScrollBar::setRect):
150         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
151         (WebCore::CheckCacheObjectStatus):
152         (WebCore::CheckIfReloading):
153         (WebCore::ServeSynchronousRequest):
154         (WebCore::historyContains):
155         (WebCore::submitButtonDefaultLabel):
156         (WebCore::inputElementAltText):
157         (WebCore::resetButtonDefaultLabel):
158         (WebCore::defaultLanguage):
159         (WebCore::findNextSentenceFromIndex):
160         (WebCore::findSentenceBoundary):
161         (WebCore::findNextWordFromIndex):
162         (WebCore::findWordBoundary):
163         (Frame::setNeedsReapplyStyles):
164         (WebCore::screenDepthPerComponent):
165         (WebCore::screenIsMonochrome):
166         (WebCore::searchableIndexIntroduction):
167         (WebCore::setFocusRingColorChangeFunction):
168         (FrameView::updateBorder):
169         (loadResourceIntoArray):
170         (PlugInInfoStore::createPluginInfoForPluginAtIndex):
171         (PlugInInfoStore::pluginCount):
172         (WebCore::PlugInInfoStore::supportsMIMEType):
173         (FileButton::FileButton):
174         (FileButton::click):
175         (FileButton::sizeForCharacterWidth):
176         (FileButton::focusPolicy):
177         (FileButton::frameGeometry):
178         (FileButton::setFilename):
179         (FileButton::baselinePosition):
180         (FileButton::setFrameGeometry):
181         (FileButton::setDisabled):
182         (WebCore::supportedKeySizes):
183         (WebCore::signedPublicKeyAndChallengeString):
184
185 2006-08-21  Nikolas Zimmermann  <zimmermann@kde.org>
186
187         Reviewed by Maciej.
188
189         Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
190         WebKit should have Qt platform support
191
192         * platform/qt/CursorQt.cpp: Added.
193         (WebCore::Cursor::Cursor):
194         (WebCore::Cursor::~Cursor):
195         (WebCore::Cursor::operator=):
196         (WebCore::Cursors::Cursors::self):
197         (WebCore::moveCursor):
198         (WebCore::crossCursor):
199         (WebCore::handCursor):
200         (WebCore::iBeamCursor):
201         (WebCore::waitCursor):
202         (WebCore::helpCursor):
203         (WebCore::eastResizeCursor):
204         (WebCore::northResizeCursor):
205         (WebCore::northEastResizeCursor):
206         (WebCore::northWestResizeCursor):
207         (WebCore::southResizeCursor):
208         (WebCore::southEastResizeCursor):
209         (WebCore::southWestResizeCursor):
210         (WebCore::westResizeCursor):
211         (WebCore::northSouthResizeCursor):
212         (WebCore::eastWestResizeCursor):
213         (WebCore::northEastSouthWestResizeCursor):
214         (WebCore::northWestSouthEastResizeCursor):
215         (WebCore::columnResizeCursor):
216         (WebCore::rowResizeCursor):
217         * platform/qt/RenderThemeQt.cpp: Added.
218         (WebCore::RenderThemeQt::RenderThemeQt):
219         (WebCore::RenderThemeQt::supportsHover):
220         (WebCore::RenderThemeQt::paintCheckbox):
221         (WebCore::RenderThemeQt::paintRadio):
222         (WebCore::theme):
223         (WebCore::RenderThemeQt::isControlStyled):
224         (WebCore::RenderThemeQt::controlSupportsTints):
225         (WebCore::RenderThemeQt::systemFont):
226         (WebCore::RenderThemeQt::createPopupMenu):
227         (WebCore::RenderThemeQt::addIntrinsicMargins):
228         (WebCore::RenderThemeQt::stylePainterAndWidgetForPaintInfo):
229         (WebCore::RenderThemeQt::setCheckboxSize):
230         (WebCore::RenderThemeQt::setRadioSize):
231         (WebCore::RenderThemeQt::supportsFocus):
232         (WebCore::RenderThemeQt::applyTheme):
233         (WebCore::RenderThemeQt::adjustButtonStyle):
234         (WebCore::RenderThemeQt::paintButton):
235         (WebCore::RenderThemeQt::adjustTextFieldStyle):
236         (WebCore::RenderThemeQt::paintTextField):
237
238 2006-08-21  Nikolas Zimmermann  <zimmermann@kde.org>
239
240         Reviewed by Maciej.
241
242         Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
243         WebKit should have Qt platform support
244
245         * platform/qt/SharedTimerQt.cpp: Added.
246         (WebCore:setSharedTimerFiredFunction):
247         (WebCore::setSharedTimerFireTime):
248         (WebCore::stopSharedTimer):
249         * platform/qt/SharedTimerQt.h: Added.
250         (WebCore::SharedTimerQt::SharedTimerQt):
251         (WebCore::SharedTimerQt::~SharedTimerQt):
252         (WebCore::SharedTimerQt::inst):
253         (WebCore::SharedTimerQt::fire):
254         * platform/qt/SystemTimeQt.cpp: Added.
255         (WebCore::currentTime):
256
257 2006-08-21  Brady Eidson  <beidson@apple.com>
258
259         Reviewed by John
260
261         -Defers writing to the database via a timer and handles starting the timer
262          intelligently
263
264         * loader/icon/IconDatabase.cpp:
265         (WebCore::IconDatabase::IconDatabase):
266         (WebCore::IconDatabase::open): Don't start the update timer by default
267         (WebCore::IconDatabase::close): Call syncDatabase()
268         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Call syncDatabase()
269         (WebCore::IconDatabase::setIconURLForPageURL): Setup the cached url, but defer the DB call
270         (WebCore::IconDatabase::setIconURLForPageURLInDatabase): Actually commit the url to the DB
271         (WebCore::IconDatabase::pruneUnretainedIconsOnStartup):
272         (WebCore::IconDatabase::updateDatabase): The updateTimer calls this, which just calls syncDatabase()
273         (WebCore::IconDatabase::syncDatabase): Add and remove pending pageURLs and iconURLs, and stop the updateTimer
274         * loader/icon/IconDatabase.h:
275
276 2006-08-21  Alexey Proskuryakov  <ap@nypop.com>
277
278         Reviewed by Eric.
279
280         - http://bugzilla.opendarwin.org/show_bug.cgi?id=10429
281           XSLTProcessor.transformToFragment crashes if the owner document is empty
282
283         Test: fast/js/xslt-fragment-in-empty-doc.html
284
285         * dom/XMLTokenizer.cpp:
286         (WebCore::XMLTokenizer::XMLTokenizer): Don't iterate over the element stack if it's empty.
287
288 2006-08-21  Brady Eidson  <beidson@apple.com>
289
290         Reviewed by Anders
291
292         -Added timer-based, deferred deletion of database records - PageURLs and Icons handled seperately
293          In the near future, we'll also have timer-based deferred *addition* of database records
294         -Keep retain/release counts in a hash instead of a DB table
295         -Keep only one hash record for the SiteIcons
296         -Renamed some methods for clarity
297
298         * bridge/mac/WebCoreIconDatabaseBridge.h: Renamed method for clarity
299         * bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto
300         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]): Ditto
301         * loader/icon/IconDatabase.cpp:
302         (WebCore::IconDatabase::IconDatabase):
303         (WebCore::IconDatabase::open): Added new timer setup
304         (WebCore::IconDatabase::iconForPageURL): Only work with one hash of the SiteIcons
305         (WebCore::IconDatabase::retainIconForPageURL): Keep count in a hash
306         (WebCore::IconDatabase::releaseIconForPageURL): Keep count in a hash, use deferred deletion
307         (WebCore::IconDatabase::retainIconURL): Added
308         (WebCore::IconDatabase::releaseIconURL): Added
309         (WebCore::IconDatabase::forgetPageURL):  Added
310         (WebCore::IconDatabase::isIconURLRetained): New and improved simplicity
311         (WebCore::IconDatabase::setIconDataForIconURL): Cleanup
312         (WebCore::IconDatabase::setIconURLForPageURL):
313         (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Renamed
314         (WebCore::IconDatabase::pruneIconsPendingDeletion): Added
315         (WebCore::IconDatabase::hasEntryForIconURL): Renamed for clarity
316         * loader/icon/IconDatabase.h: Added multiple stuffs
317
318 2006-08-21  Brady Eidson  <beidson@apple.com>
319
320         Reviewed by Maciej's rubberstamp
321
322         Removed stale file references from the Xcode.proj
323
324         * WebCore.xcodeproj/project.pbxproj:
325
326 2006-08-20  Nikolas Zimmermann  <zimmermann@kde.org>
327
328         Reviewed by Maciej. Landed by rwlbuis.
329
330         Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
331         WebKit should have Qt platform support
332
333         Removing HelperQt.h usage by creating appropriate operators
334         constructor in some of the platform classes, as suggested by Darin.
335
336         * CMakeLists.txt:
337         * platform/DeprecatedString.h:
338         * platform/Font.h:
339         * platform/PlatformString.h:
340         * platform/qt/ComboBoxQt.cpp:
341         (WebCore::PlatformComboBox::appendItem):
342         (WebCore::PlatformComboBox::appendGroupLabel):
343         (WebCore::PlatformComboBox::setFont):
344         * platform/qt/LineEditQt.cpp:
345         (WebCore::PlatformLineEdit::setFont):
346         (WebCore::PlatformLineEdit::setText):
347         (WebCore::PlatformLineEdit::text):
348         (WebCore::PlatformLineEdit::selectedText):
349         * platform/qt/ListBoxQt.cpp:
350         (WebCore::ListBox::setFont):
351         (WebCore::ListBox::appendItem):
352         * platform/qt/PlatformKeyboardEventQt.cpp:
353         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
354         * platform/qt/ScrollViewQt.cpp:
355         * platform/qt/StringQt.cpp: Added.
356         (WebCore::String::String):
357         (WebCore::String::operator QString):
358         (WebCore::DeprecatedString::operator QString):
359         * platform/qt/TextEditQt.cpp:
360         * platform/qt/WidgetQt.cpp:
361         (WebCore::Widget::setFont):
362
363 2006-08-18  Steve Falkenburg  <sfalken@apple.com>
364
365         Rubber stamped by adele.
366         
367         Fix call to WebFormDelegate's textFieldDidBeginEditing.
368
369         * rendering/RenderTextControl.cpp:
370         (WebCore::RenderTextControl::subtreeHasChanged):
371
372 2006-08-19  Nikolas Zimmermann  <zimmermann@kde.org>
373
374         Reviewed by Eric. Landed by rwlbuis.
375
376         Next chunk of the implementation for:
377         http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
378
379         WebKit should have Qt platform support
380
381         * platform/qt/KeyboardCodes.h: Added.
382         * platform/qt/PlatformKeyboardEventQt.cpp: Added.
383         (WebCore::keyIdentifierForQtKeyCode):
384         (WebCore::windowsKeyCodeForKeyEvent):
385         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
386         * platform/qt/PlatformMouseEventQt.cpp: Added.
387         (WebCore::):
388         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
389
390 2006-08-19  Nikolas Zimmermann  <zimmermann@kde.org>
391
392         Reviewed by Eric. Landed by rwlbuis.
393
394         Next chunk of the implementation for:
395         http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
396
397         WebKit should have Qt platform support
398
399         * platform/qt/AffineTransformQt.cpp: Added.
400         (WebCore::AffineTransform::AffineTransform):
401         (WebCore::AffineTransform::setMatrix):
402         (WebCore::AffineTransform::map):
403         (WebCore::AffineTransform::mapRect):
404         (WebCore::AffineTransform::isIdentity):
405         (WebCore::AffineTransform::m11):
406         (WebCore::AffineTransform::m12):
407         (WebCore::AffineTransform::m21):
408         (WebCore::AffineTransform::m22):
409         (WebCore::AffineTransform::dx):
410         (WebCore::AffineTransform::dy):
411         (WebCore::AffineTransform::reset):
412         (WebCore::AffineTransform::scale):
413         (WebCore::AffineTransform::rotate):
414         (WebCore::AffineTransform::translate):
415         (WebCore::AffineTransform::shear):
416         (WebCore::AffineTransform::det):
417         (WebCore::AffineTransform::invert):
418         (WebCore::AffineTransform::operator QMatrix):
419         (WebCore::AffineTransform::operator==):
420         (WebCore::AffineTransform::operator*=):
421         (WebCore::AffineTransform::operator*):
422         * platform/qt/BrowserExtensionQt.cpp: Added.
423         (WebCore::BrowserExtensionQt::BrowserExtensionQt):
424         (WebCore::BrowserExtensionQt::canRunModal):
425         (WebCore::BrowserExtensionQt::createNewWindow):
426         (WebCore::BrowserExtensionQt::canRunModalNow):
427         (WebCore::BrowserExtensionQt::runModal):
428         (WebCore::BrowserExtensionQt::goBackOrForward):
429         (WebCore::BrowserExtensionQt::historyURL):
430         (WebCore::BrowserExtensionQt::setTypedIconURL):
431         (WebCore::BrowserExtensionQt::setIconURL):
432         (WebCore::BrowserExtensionQt::getHistoryLength):
433         * platform/qt/BrowserExtensionQt.h: Added.
434         * platform/qt/CookieJarQt.cpp: Added.
435         (WebCore::setCookies):
436         (WebCore::cookies):
437         (WebCore::cookiesEnabled):
438         * platform/qt/PageQt.cpp: Added.
439         (WebCore::rootWindowForFrame):
440         (WebCore::Page::windowRect):
441         (WebCore::Page::setWindowRect):
442         * platform/qt/PathQt.cpp: Added.
443         (WebCore::Path::Path):
444         (WebCore::Path::~Path):
445         (WebCore::Path::operator=):
446         (WebCore::Path::contains):
447         (WebCore::Path::translate):
448         (WebCore::Path::boundingRect):
449         (WebCore::Path::moveTo):
450         (WebCore::Path::addLineTo):
451         (WebCore::Path::addQuadCurveTo):
452         (WebCore::Path::addBezierCurveTo):
453         (WebCore::Path::addArcTo):
454         (WebCore::Path::closeSubpath):
455         (WebCore::Path::addArc):
456         (WebCore::Path::addRect):
457         (WebCore::Path::addEllipse):
458         (WebCore::Path::clear):
459         * platform/qt/ScreenQt.cpp: Added.
460         (WebCore::screenRect):
461         (WebCore::screenDepth):
462         (WebCore::usableScreenRect):
463
464
465 2006-08-19  Nikolas Zimmermann  <zimmermann@kde.org>
466
467         Reviewed by Eric. Landed by rwlbuis.
468
469         First chunk of the implementation for:
470         http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
471
472         WebKit should have Qt platform support
473
474         * platform/qt/ComboBoxQt.cpp: Added.
475         (WebCore::PlatformComboBox::PlatformComboBox):
476         (WebCore::PlatformComboBox::~PlatformComboBox):
477         (WebCore::PlatformComboBox::setParentWidget):
478         (WebCore::PlatformComboBox::clear):
479         (WebCore::PlatformComboBox::appendItem):
480         (WebCore::PlatformComboBox::appendGroupLabel):
481         (WebCore::PlatformComboBox::appendSeparator):
482         (WebCore::PlatformComboBox::setCurrentItem):
483         (WebCore::PlatformComboBox::sizeHint):
484         (WebCore::PlatformComboBox::frameGeometry):
485         (WebCore::PlatformComboBox::setFrameGeometry):
486         (WebCore::PlatformComboBox::baselinePosition):
487         (WebCore::PlatformComboBox::setFont):
488         (WebCore::PlatformComboBox::focusPolicy):
489         (WebCore::PlatformComboBox::itemSelected):
490         (WebCore::PlatformComboBox::setWritingDirection):
491         (WebCore::PlatformComboBox::populate):
492         (WebCore::PlatformComboBox::populateMenu):
493         * platform/qt/LineEditQt.cpp: Added.
494         (WebCore::PlatformLineEdit::PlatformLineEdit):
495         (WebCore::PlatformLineEdit::~PlatformLineEdit):
496         (WebCore::PlatformLineEdit::setParentWidget):
497         (WebCore::PlatformLineEdit::setColors):
498         (WebCore::PlatformLineEdit::setAlignment):
499         (WebCore::PlatformLineEdit::setCursorPosition):
500         (WebCore::PlatformLineEdit::cursorPosition):
501         (WebCore::PlatformLineEdit::setEdited):
502         (WebCore::PlatformLineEdit::edited):
503         (WebCore::PlatformLineEdit::setFont):
504         (WebCore::PlatformLineEdit::setMaxLength):
505         (WebCore::PlatformLineEdit::maxLength):
506         (WebCore::PlatformLineEdit::setReadOnly):
507         (WebCore::PlatformLineEdit::isReadOnly):
508         (WebCore::PlatformLineEdit::setText):
509         (WebCore::PlatformLineEdit::text):
510         (WebCore::PlatformLineEdit::setWritingDirection):
511         (WebCore::PlatformLineEdit::selectAll):
512         (WebCore::PlatformLineEdit::hasSelectedText):
513         (WebCore::PlatformLineEdit::selectionStart):
514         (WebCore::PlatformLineEdit::selectedText):
515         (WebCore::PlatformLineEdit::setSelection):
516         (WebCore::PlatformLineEdit::sizeForCharacterWidth):
517         (WebCore::PlatformLineEdit::baselinePosition):
518         (WebCore::PlatformLineEdit::focusPolicy):
519         (WebCore::PlatformLineEdit::checksDescendantsForFocus):
520         (WebCore::PlatformLineEdit::setLiveSearch):
521         (WebCore::PlatformLineEdit::setAutoSaveName):
522         (WebCore::PlatformLineEdit::setMaxResults):
523         (WebCore::PlatformLineEdit::setPlaceholderString):
524         (WebCore::PlatformLineEdit::addSearchResult):
525         * platform/qt/ListBoxQt.cpp: Added.
526         (WebCore::ListBox::ListBox):
527         (WebCore::ListBox::~ListBox):
528         (WebCore::ListBox::setParentWidget):
529         (WebCore::ListBox::sizeForNumberOfLines):
530         (WebCore::ListBox::setSelectionMode):
531         (WebCore::ListBox::clear):
532         (WebCore::ListBox::doneAppendingItems):
533         (WebCore::ListBox::setSelected):
534         (WebCore::ListBox::isSelected):
535         (WebCore::ListBox::setEnabled):
536         (WebCore::ListBox::isEnabled):
537         (WebCore::ListBox::setWritingDirection):
538         (WebCore::ListBox::focusPolicy):
539         (WebCore::ListBox::checksDescendantsForFocus):
540         (WebCore::ListBox::clearCachedTextRenderers):
541         (WebCore::ListBox::setFont):
542         (WebCore::ListBox::appendItem):
543         * platform/qt/ScrollViewQt.cpp: Added.
544         (WebCore::ScrollView::ScrollView):
545         (WebCore::ScrollView::~ScrollView):
546         (WebCore::ScrollView::setParentWidget):
547         (WebCore::ScrollView::updateContents):
548         (WebCore::ScrollView::visibleWidth):
549         (WebCore::ScrollView::visibleHeight):
550         (WebCore::ScrollView::visibleContentRect):
551         (WebCore::ScrollView::setContentsPos):
552         (WebCore::ScrollView::resizeContents):
553         (WebCore::ScrollView::contentsX):
554         (WebCore::ScrollView::contentsY):
555         (WebCore::ScrollView::contentsWidth):
556         (WebCore::ScrollView::contentsHeight):
557         (WebCore::ScrollView::viewportToContents):
558         (WebCore::ScrollView::contentsToViewport):
559         (WebCore::ScrollView::scrollOffset):
560         (WebCore::ScrollView::scrollBy):
561         (WebCore::ScrollView::hScrollBarMode):
562         (WebCore::ScrollView::vScrollBarMode):
563         (WebCore::ScrollView::suppressScrollBars):
564         (WebCore::ScrollView::setHScrollBarMode):
565         (WebCore::ScrollView::setVScrollBarMode):
566         (WebCore::ScrollView::setScrollBarsMode):
567         (WebCore::ScrollView::setStaticBackground):
568         (WebCore::ScrollView::addChild):
569         (WebCore::ScrollView::removeChild):
570         (WebCore::ScrollView::scrollPointRecursively):
571         (WebCore::ScrollView::inWindow):
572         * platform/qt/TextEditQt.cpp: Added.
573         (WebCore::PlatformTextEdit::PlatformTextEdit):
574         (WebCore::PlatformTextEdit::~PlatformTextEdit):
575         (WebCore::PlatformTextEdit::setParentWidget):
576         (WebCore::PlatformTextEdit::setColors):
577         (WebCore::PlatformTextEdit::setAlignment):
578         (WebCore::PlatformTextEdit::setLineHeight):
579         (WebCore::PlatformTextEdit::setCursorPosition):
580         (WebCore::PlatformTextEdit::getCursorPosition):
581         (WebCore::PlatformTextEdit::setFont):
582         (WebCore::PlatformTextEdit::setReadOnly):
583         (WebCore::PlatformTextEdit::isReadOnly):
584         (WebCore::PlatformTextEdit::setDisabled):
585         (WebCore::PlatformTextEdit::isDisabled):
586         (WebCore::PlatformTextEdit::hasSelectedText):
587         (WebCore::PlatformTextEdit::setText):
588         (WebCore::PlatformTextEdit::text):
589         (WebCore::PlatformTextEdit::textWithHardLineBreaks):
590         (WebCore::PlatformTextEdit::focusPolicy):
591         (WebCore::PlatformTextEdit::setWordWrap):
592         (WebCore::PlatformTextEdit::wordWrap):
593         (WebCore::PlatformTextEdit::setScrollBarModes):
594         (WebCore::PlatformTextEdit::setWritingDirection):
595         (WebCore::PlatformTextEdit::selectionStart):
596         (WebCore::PlatformTextEdit::selectionEnd):
597         (WebCore::PlatformTextEdit::setSelectionStart):
598         (WebCore::PlatformTextEdit::setSelectionEnd):
599         (WebCore::PlatformTextEdit::selectAll):
600         (WebCore::PlatformTextEdit::setSelectionRange):
601         (WebCore::PlatformTextEdit::sizeWithColumnsAndRows):
602         (WebCore::PlatformTextEdit::checksDescendantsForFocus):
603         * platform/qt/WidgetQt.cpp: Added.
604         (WebCore::WidgetPrivate::WidgetPrivate):
605         (WebCore::WidgetPrivate::~WidgetPrivate):
606         (WebCore::Widget::Widget):
607         (WebCore::Widget::~Widget):
608         (WebCore::Widget::setClient):
609         (WebCore::Widget::client):
610         (WebCore::Widget::frameGeometry):
611         (WebCore::Widget::hasFocus):
612         (WebCore::Widget::setFocus):
613         (WebCore::Widget::clearFocus):
614         (WebCore::Widget::font):
615         (WebCore::Widget::setFont):
616         (WebCore::Widget::setCursor):
617         (WebCore::Widget::show):
618         (WebCore::Widget::hide):
619         (WebCore::Widget::setQWidget):
620         (WebCore::Widget::qwidget):
621         (WebCore::Widget::setParentWidget):
622         (WebCore::Widget::parentWidget):
623         (WebCore::Widget::setFrameGeometry):
624         (WebCore::Widget::mapFromGlobal):
625         (WebCore::Widget::scaleFactor):
626         (WebCore::Widget::lockDrawingFocus):
627         (WebCore::Widget::unlockDrawingFocus):
628         (WebCore::Widget::paint):
629         (WebCore::Widget::enableFlushDrawing):
630         (WebCore::Widget::isEnabled):
631         (WebCore::Widget::setIsSelected):
632         (WebCore::Widget::disableFlushDrawing):
633         (WebCore::Widget::setEnabled):
634         (WebCore::Widget::focusPolicy):
635
636 2006-08-19  Nikolas Zimmermann  <zimmermann@kde.org>
637
638         Reviewed by Eric. Landed by rwlbuis.
639
640         First chunk of the implementation for:
641         http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
642
643         WebKit should have Qt platform support
644
645         * platform/qt/ColorQt.cpp: Added.
646         (WebCore::Color::Color):
647         (WebCore::Color::operator QColor):
648         * platform/qt/FloatPointQt.cpp: Added.
649         (WebCore::FloatPoint::FloatPoint):
650         (WebCore::FloatPoint::operator QPointF):
651         * platform/qt/FloatRectQt.cpp: Added.
652         (WebCore::FloatRect::FloatRect):
653         (WebCore::FloatRect::operator QRectF):
654         * platform/qt/IntPointQt.cpp: Added.
655         (WebCore::IntPoint::IntPoint):
656         (WebCore::IntPoint::operator QPoint):
657         * platform/qt/IntRectQt.cpp: Added.
658         (WebCore::IntRect::IntRect):
659         (WebCore::IntRect::operator QRect):
660         * platform/qt/IntSizeQt.cpp: Added.
661         (WebCore::IntSize::IntSize):
662         (WebCore::IntSize::operator QSize):
663
664  2006-08-18  Nikolas Zimmermann  <zimmermann@kde.org>
665  
666          Reviewed by Eric. Landed by rwlbuis.
667  
668          Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10470
669          The Qt platform needs a KCanvas device.
670  
671          * kcanvas/device/qt/KCanvasClipperQt.cpp: Added.
672          (WebCore::KCanvasClipperQt::applyClip):
673          * kcanvas/device/qt/KCanvasClipperQt.h: Added.
674          (WebCore::KCanvasClipperQt::KCanvasClipperQt):
675          * kcanvas/device/qt/KCanvasPathQt.cpp: Added.
676          (WebCore::KCanvasPathQt::KCanvasPathQt):
677          (WebCore::KCanvasPathQt::~KCanvasPathQt):
678          (WebCore::KCanvasPathQt::isEmpty):
679          (WebCore::KCanvasPathQt::moveTo):
680          (WebCore::KCanvasPathQt::lineTo):
681          (WebCore::KCanvasPathQt::curveTo):
682          (WebCore::KCanvasPathQt::closeSubpath):
683          (WebCore::KCanvasPathQt::boundingBox):
684          (WebCore::KCanvasPathQt::strokeBoundingBox):
685          (WebCore::KCanvasPathQt::strokeContainsPoint):
686          (WebCore::KCanvasPathQt::containsPoint):
687          * kcanvas/device/qt/KCanvasPathQt.h: Added.
688          (WebCore::KCanvasPathQt::qtPath):
689          * kcanvas/device/qt/KRenderingDeviceQt.cpp: Added.
690          (WebCore::KRenderingDeviceContextQt::KRenderingDeviceContextQt):
691          (WebCore::KRenderingDeviceContextQt::~KRenderingDeviceContextQt):
692          (WebCore::KRenderingDeviceContextQt::concatCTM):
693          (WebCore::KRenderingDeviceContextQt::ctm):
694          (WebCore::KRenderingDeviceContextQt::mapFromVisual):
695          (WebCore::KRenderingDeviceContextQt::mapToVisual):
696          (WebCore::KRenderingDeviceContextQt::clearPath):
697          (WebCore::KRenderingDeviceContextQt::addPath):
698          (WebCore::KRenderingDeviceContextQt::createGraphicsContext):
699          (WebCore::KRenderingDeviceContextQt::painter):
700          (WebCore::KRenderingDeviceContextQt::pathBBox):
701          (WebCore::KRenderingDeviceContextQt::setFillRule):
702          (WebCore::KRenderingDeviceContextQt::fillPath):
703          (WebCore::KRenderingDeviceContextQt::strokePath):
704          (WebCore::KRenderingDeviceQt::KRenderingDeviceQt):
705          (WebCore::KRenderingDeviceQt::~KRenderingDeviceQt):
706          (WebCore::KRenderingDeviceQt::popContext):
707          (WebCore::KRenderingDeviceQt::pushContext):
708          (WebCore::KRenderingDeviceQt::qtContext):
709          (WebCore::KRenderingDeviceQt::contextForImage):
710          (WebCore::KRenderingDeviceQt::stringForPath):
711          (WebCore::KRenderingDeviceQt::createResource):
712          (WebCore::KRenderingDeviceQt::createPaintServer):
713          (WebCore::KRenderingDeviceQt::createFilterEffect):
714
715 2006-08-17  Nikolas Zimmermann  <zimmermann@kde.org>
716
717         Reviewed by Eric. Landed by rwlbuis.
718
719         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10466
720         WebKit should have Qt platform support.
721
722         * platform/Color.h:
723         * platform/Cursor.h:
724         (WebCore::Cursor::Cursor):
725         * platform/FloatPoint.h:
726         * platform/FloatRect.h:
727         * platform/GlyphBuffer.h:
728         (WebCore::GlyphBuffer::glyphAt):
729         (WebCore::GlyphBuffer::advanceAt):
730         (WebCore::GlyphBuffer::add):
731         * platform/GraphicsContext.h:
732         * platform/ImageSource.h:
733         * platform/IntPoint.h:
734         * platform/IntRect.h:
735         * platform/IntSize.h:
736         * platform/ListBox.h:
737         * platform/Path.h:
738         * platform/PlatformKeyboardEvent.h:
739         * platform/PlatformMouseEvent.h:
740         * platform/ResourceLoader.h:
741         * platform/ResourceLoaderClient.h:
742         * platform/ResourceLoaderInternal.h:
743         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
744         * platform/ScrollView.h:
745         * platform/Widget.h:
746
747 2006-08-17  Nikolas Zimmermann  <zimmermann@kde.org>
748
749         Reviewed by Eric. Landed by rwlbuis.
750
751         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10465
752         General WebKit Linux build fixes.
753
754         * kcanvas/KCanvasFilters.cpp:
755         (WebCore::operator<<):
756         * kcanvas/RenderSVGImage.cpp:
757         * ksvg2/css/SVGCSSStyleSelector.cpp:
758         * ksvg2/svg/SVGAnimateColorElement.cpp:
759         * ksvg2/svg/SVGMaskElement.cpp:
760         * ksvg2/svg/SVGPatternElement.cpp:
761         * page/Frame.h:
762         * rendering/RenderStyle.h:
763         (WebCore::RenderStyle::deleteBindingURIs):
764         * xml/DOMParser.cpp:
765
766 2006-08-17  Nikolas Zimmermann  <zimmermann@kde.org>
767
768         Reviewed by Eric. Landed by rwlbuis.
769
770         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10464
771         Offer a cmake build system for Qt platform.
772
773         * CMakeLists.txt: Added.
774
775 2006-08-17  David Harrison  <harrison@apple.com>
776
777         Reviewed by John Sullivan.
778
779         <rdar://problem/4671069> REGRESSION: Popup buttons in web pages aren't exposed as AXPopupButtons
780
781         Accessorized RenderMenuList objects.
782         
783         * bridge/mac/WebCoreAXObject.mm:
784         (-[WebCoreAXObject mouseButtonListener]):
785         Trivial formatting.
786         
787         (-[WebCoreAXObject actionElement]):
788         Return the HTMLSelectElement.
789         
790         (-[WebCoreAXObject firstChild]):
791         (-[WebCoreAXObject lastChild]):
792         (-[WebCoreAXObject previousSibling]):
793         (-[WebCoreAXObject nextSibling]):
794         (-[WebCoreAXObject parentObject]):
795         (-[WebCoreAXObject parentObjectUnignored]):
796         (-[WebCoreAXObject isAttachment]):
797         (-[WebCoreAXObject attachmentView]):
798         Trivial formatting.
799
800         (-[WebCoreAXObject role]):
801         Return NSAccessibilityPopUpButtonRole.
802
803         (-[WebCoreAXObject subrole]):
804         Trivial formatting.
805         
806         (-[WebCoreAXObject roleDescription]):
807         Return NSAccessibilityPopUpButtonRole.
808         
809         (-[WebCoreAXObject textUnderElement]):
810         Trivial formatting.
811
812         (-[WebCoreAXObject value]):
813         Return the RenderMenuList::text().
814         
815         (-[WebCoreAXObject position]):
816          Trivial formatting.
817
818         (-[WebCoreAXObject accessibilityIsIgnored]):
819         - Ignore popup menu items because AppKit does.
820         - Remove redundant check for buttonTag (earlier isControl() check suffices).
821         
822         (-[WebCoreAXObject accessibilityAttributeNames]):
823         (-[WebCoreAXObject accessibilityActionNames]):
824         (-[WebCoreAXObject accessibilityAttributeValue:]):
825         Trivial formatting.
826         
827         (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
828         Removed old debugging code that is no longer needed.
829         Trivial formatting.
830         
831         (-[WebCoreAXObject doAXSentenceTextMarkerRangeForTextMarker:]):
832         (-[WebCoreAXObject doAXParagraphTextMarkerRangeForTextMarker:]):
833         (-[WebCoreAXObject removeAXObjectID]):
834         Trivial formatting.
835         
836         * html/HTMLSelectElement.cpp:
837         (WebCore::HTMLSelectElement::accessKeyAction):
838         Call click() instead of focus().
839         
840         * rendering/RenderMenuList.cpp:
841         (WebCore::RenderMenuList::text):
842         Added for easy access to popup's current text.
843         
844         * rendering/RenderMenuList.h:
845         (WebCore::RenderMenuList::isMenuList):
846         * rendering/RenderObject.h:
847         (WebCore::RenderObject::isMenuList):
848         Added so popups can be identified.
849
850 2006-08-17  David Harrison  <harrison@apple.com>
851
852         Reviewed by Maciej.
853
854         <rdar://problem/4527201> REGRESSION: AXTextMarkerRangeForUnorderedTextMarkers returns out of order range
855
856         Test cases added: None.  Manual AX testing is way too awkward, and automated testing
857         is not possible.  See following bug...
858             <rdar://problem/4256882> Need automated testing support for accessibility APIs
859
860         * bridge/mac/AXObjectCacheMac.mm:
861         (WebCore::AXObjectCache::visiblePositionForTextMarker):
862         Validate the marker by comparing the node and offset to those of the resulting VisiblePosition.
863
864 2006-08-17  Nikolas Zimmermann  <zimmermann@kde.org>
865
866         Reviewed by Anders.
867
868         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10447
869         AffineTransform should be multi-platform compatible
870
871         * platform/AffineTransform.h:
872         * platform/cg/AffineTransformCG.cpp:
873         (WebCore::AffineTransform::m11):
874         (WebCore::AffineTransform::m12):
875         (WebCore::AffineTransform::m21):
876         (WebCore::AffineTransform::m22):
877         (WebCore::AffineTransform::dx):
878         (WebCore::AffineTransform::dy):
879
880 2006-08-16  David Hyatt  <hyatt@apple.com>
881
882         Fix an issue with CSS2 system fonts where they did not respect text
883         zoom.  This was most visible with the new control fonts used for form
884         controls (they stopped swapping between small/mini/regular as you zoomed).
885
886         Reviewed by beth
887
888         * css/cssstyleselector.cpp:
889         (WebCore::CSSStyleSelector::applyProperty):
890
891 2006-08-15  Justin Garcia  <justin.garcia@apple.com>
892
893         Reviewed by thatcher
894         
895         First part of fix for:
896         <rdar://problem/4384589>
897         Mail hung on paste text
898         
899         Fixes:
900         <http://bugzilla.opendarwin.org/show_bug.cgi?id=8592>
901         Extra line left after deleting whitespace:pre text
902         <rdar://problem/4128080> Paste as HTML does not yield equivalent style
903         <rdar://problem/4046469> Box styles on first element aren't copied/pasted
904         Copy/paste of arstechnica.com
905         
906         Here's how we avoid adding redundant style information on paste: insert 
907         the fragment and do a test rendering, save away style information for 
908         every node in the fragment, remove all style information from the fragment, 
909         remove the fragment, insert it into the appropriate place in the document, 
910         then restore only those styles gathered during the test insertion that aren't
911         redundant.  Restoring the styles in this way results in an ApplyStyleCommand 
912         and a layout for nearly every inserted node.  
913         Instead we want to insert the fragment into the document without removing the 
914         style information, then mark style nodes and inline style declarations for 
915         removal if they are redundant, and sweep to remove them.  This means that we 
916         can't rely on ReplacementFragment::wasBlock anymore, because blocks will now 
917         have style spans around them.  This patch removes the use of wasBlock in 
918         ReplaceSelectionCommand.
919         
920         * editing/CompositeEditCommand.cpp:
921         (WebCore::CompositeEditCommand::moveParagraphs): Added code
922         to remove the line placeholder left after a move from preserveNewline text.
923         * editing/DeleteSelectionCommand.cpp:
924         (WebCore::DeleteSelectionCommand::doApply): Don't add a placeholder if 
925         we're deleting a paragraph in preserveNewline text.
926         * editing/JSEditor.cpp: Pass true to prevent nesting.
927         * editing/ReplaceSelectionCommand.cpp: Removed wasBlock and friends.
928         (WebCore::ReplacementFragment::ReplacementFragment): Ditto.
929         (WebCore::ReplacementFragment::saveRenderingInfo): Ditto.
930         (WebCore::RenderingInfo::RenderingInfo): Ditto.
931         (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
932         (WebCore::ReplaceSelectionCommand::shouldMergeStart): Combined the to/from
933         merging rules into one method.
934         (WebCore::ReplaceSelectionCommand::shouldMergeEnd):
935         (WebCore::ReplaceSelectionCommand::shouldMerge):
936         (WebCore::ReplaceSelectionCommand::doApply): 
937         Don't do nesting prevention when pasting into an empty paragraph, this
938         fixes 4046469, the common cause of paste fidelity bugs, but needs
939         to be tweaked a little because this can lead to margin/border build-up
940         on repeated copy/pastes.
941         Don't track startPos in addition to insertionPos.  It was never used.
942         Fixed a bug where a fragment starting with an interchange newline would
943         cause content to be put outside of an editable region when pasting at the 
944         very end of it.
945         Adjust insertionPos before insertion (not during) and do not consult wasBlock
946         to decide whether or not to do so.
947         Changed the way we do the start merge: insert the fragment, then stich 
948         paragraphs together, in the same way that we do the end merge.  This 
949         doesn't require wasBlock and fixes bugs.
950         Replaced some uses of insertionPos with endOfInsertedContent.
951         Fixed a bug in the expansion of the last incoming br (a "collapsed" br
952         is one where !isStartOfParagraph([br,0])).
953         Removed the special case code that did the end merge for the preserveNewline 
954         case, since this patch fixes the moveParagraph bug in the preserveNewline case.
955         Removed some unused variables.
956         (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): An endBR that was 
957         holding a line open should always be displaced by inserted content, unless 
958         the inserted content ends with a br.
959         (WebCore::ReplaceSelectionCommand::updateNodesInserted):
960         * editing/ReplaceSelectionCommand.h:
961         (WebCore::RenderingInfo::style):
962         * editing/markup.cpp:
963         (WebCore::createMarkup): Only add mail blockquotes and list/table/pre when
964         annotate is true (when we're creating markup for the pasteboard).
965
966 2006-08-16  John Sullivan  <sullivan@apple.com>
967
968         Reviewed by Brady Eidson
969         
970         - fixed <rdar://problem/4637156> underlines appearing in white selection text
971
972         * rendering/InlineFlowBox.cpp:
973         (WebCore::InlineFlowBox::paintDecorations):
974         bail out if phase is PaintPhaseSelection and forceWhiteText is true
975
976 2006-08-16  Brady Eidson  <beidson@apple.com>
977
978         Reviewed by John
979
980         Updated the DB version number and added a helpful comment explaining its meaning
981
982         * loader/icon/IconDatabase.cpp:
983
984 2006-08-16  Brady Eidson  <beidson@apple.com>
985
986         Reviewed by Maciej
987
988         Major refactoring of new iconDB:
989         -Instead of private browsing being handled by in-memory tables, it's now handled
990          by a separate in-memory database with the same table names.  This allows us to 
991          re-use the same SQL on either the main or private-browsing database
992         -So it follows, I broke out much of the SQL queries into seperate methods suffixed with
993          "Query" that take a database as the method's argument so the same language can run on
994          both private and main tables
995         -Now that we have two DBs, moved the retain/release count to the m_mainDB
996         -While I was at it, updated the schema to combine the Icon and IconResource table - cuts 
997          down on some high-usage, low value queries which were too expensive
998         -Ditched the _url -> url convention for escaping urls for SQL.  Now its url and escapedURL
999         -Pruned tons of unused methods from previous revisions
1000
1001      * bridge/mac/WebCoreIconDatabaseBridge.h: Removed isIconExpiredForPageURL as it was never used 
1002         * bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto
1003         * loader/icon/IconDatabase.cpp:
1004         (WebCore::IconDatabase::IconDatabase): Updated initializer list
1005         (WebCore::IconDatabase::open): Sets up both databases
1006         (WebCore::IconDatabase::close): Closes both databases
1007         (WebCore::IconDatabase::isEmpty): Queries both databases for at least 1 record
1008         (WebCore::IconDatabase::isValidDatabase): Reflect the updated schema
1009         (WebCore::IconDatabase::clearDatabaseTables): Ditto - and takes DB as a parameter
1010         (WebCore::IconDatabase::createDatabaseTables): Ditto
1011         (WebCore::IconDatabase::imageDataForIconURL): style cleanup, and using a query-function
1012         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Resets private DB instead of private tables
1013         (WebCore::IconDatabase::isIconExpiredForIconURL): Uses a query-function on each DB
1014         (WebCore::IconDatabase::iconURLForPageURL): Uses a query-function on each DB
1015         (WebCore::IconDatabase::retainIconForPageURL): Retain count DB changes 
1016         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
1017         (WebCore::IconDatabase::isIconURLRetained): Determine if it's time to prune a released icon yet
1018         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase): Alot simpler
1019         (WebCore::IconDatabase::setIconDataForIconURL): Style cleanup
1020         (WebCore::IconDatabase::setHaveNoIconForIconURL): Ditto
1021         (WebCore::IconDatabase::setIconURLForPageURL): Ditto - and using a query-function
1022         (WebCore::IconDatabase::establishIconIDForIconURL): Style cleanup
1023         (WebCore::IconDatabase::pruneUnreferencedIcons): DB name change
1024         (WebCore::IconDatabase::pruneUnretainedIcons): Ditto
1025         (WebCore::IconDatabase::hasIconForIconURL): Simpler, using a query-function
1026         (WebCore::IconDatabase::~IconDatabase):
1027         (WebCore::pageURLTableIsEmptyQuery): Self-explanatory SQL query
1028         (WebCore::imageDataForIconURLQuery): Self-explanatory SQL query
1029         (WebCore::timeStampForIconURLQuery): Self-explanatory SQL query
1030         (WebCore::iconURLForPageURLQuery): Self-explanatory SQL query
1031         (WebCore::forgetPageURLQuery): Self-explanatory SQL query
1032         (WebCore::setIconIDForPageURLQuery): Self-explanatory SQL query
1033         (WebCore::getIconIDForIconURLQuery): Self-explanatory SQL query
1034         (WebCore::addIconForIconURLQuery): Self-explanatory SQL query
1035         (WebCore::hasIconForIconURLQuery): Self-explanatory SQL query
1036      * loader/icon/IconDatabase.h: Some new/changed methods, pruned methods, and new comments
1037         (WebCore::IconDatabase::isOpen):  Changed our meaning of "isOpen" to reflect the 2 databases
1038
1039 2006-08-15  Jonas Witt <jonas.witt@gmail.com>
1040
1041         Reviewed by Darin.
1042
1043         - added ObjC wrappers for the KeyboardEvent and WheelEvent initializers
1044           http://bugzilla.opendarwin.org/show_bug.cgi?id=9736
1045
1046         * bindings/objc/DOMEvents.mm:
1047         (-[DOMKeyboardEvent initKeyboardEvent::::::::::]):
1048         * bindings/objc/DOMEventsNonstandard.mm:
1049         (-[DOMWheelEvent initWheelEvent:::::::::::]):
1050         * bindings/objc/DOMPrivate.h:
1051
1052         - added an initializer for the WheelEvent
1053
1054         * dom/WheelEvent.cpp:
1055         (WebCore::WheelEvent::initWheelEvent):
1056         * dom/WheelEvent.h:
1057
1058 2006-08-15  Mark Rowe  <opendarwin.org@bdash.net.nz>
1059
1060         Reviewed by Tim H.
1061
1062         Build fix:  DWARF and -gfull are incompatible with symbol separation.
1063
1064         * WebCore.xcodeproj/project.pbxproj:
1065
1066 2006-08-15  Mark Rowe  <opendarwin.org@bdash.net.nz>
1067
1068         Reviewed by Tim H.
1069
1070         http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
1071         Bug 10394: WebKit Release and Production configurations should enable dead code stripping
1072
1073         * WebCore.xcodeproj/project.pbxproj:
1074
1075 2006-08-15  Geoffrey Garen  <ggaren@apple.com>
1076
1077         Reviewed by Darin.
1078         
1079         - This patch reworks a previous fix for <rdar://problem/3524912> repro 
1080         crash in KHTMLParser::parseToken, due to parser's current element being 
1081         destroyed (www.gnnetcom.dk), along with subsequent adjustments to fix
1082         leaks.
1083         
1084         The previous solutions caused a ~2% performance regression on iBench HTML,
1085         due to RefPtr churn. The optimizations here gain back that ~2% plus ~1% more,
1086         for a total win of ~3% vs current TOT.
1087         
1088         We can merge this fix to the branch to fix <rdar://problem/4661982> 
1089         (crash in KHTMLParser::popBlock).
1090         
1091         The solution here is:
1092         (1) Don't let the parser ref document nodes -- that causes leaks.
1093         (2) Handle ref/deref manually, to avoid RefPtr churn. Specifically, when 
1094         moving a node between stacks or to/from 'current', rather than deref'ing
1095         and then ref'ing again, simply move the node, along with its refcount, to
1096         its new location, and overwrite its old location.
1097  
1098         * WebCore.xcodeproj/project.pbxproj:
1099         * html/HTMLParser.cpp:
1100         (WebCore::HTMLStackElem::HTMLStackElem):
1101         (WebCore::HTMLStackElem::derefNode):
1102         (WebCore::HTMLParser::HTMLParser):
1103         (WebCore::HTMLParser::setCurrent):
1104         (WebCore::HTMLParser::insertNode):
1105         (WebCore::HTMLParser::popNestedHeaderTag):
1106         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
1107         (WebCore::HTMLParser::reopenResidualStyleTags):
1108         (WebCore::HTMLParser::pushBlock):
1109         (WebCore::HTMLParser::popBlock):
1110         (WebCore::HTMLParser::popOneBlockCommon):
1111         (WebCore::HTMLParser::popOneBlock):
1112         (WebCore::HTMLParser::moveOneBlockToStack):
1113         * html/HTMLParser.h:
1114
1115 2006-08-15  Mark Rowe  <opendarwin.org@bdash.net.nz>
1116
1117         Reviewed by Tim H.
1118
1119         http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
1120         Bug 10384: Switch to DWARF for Release configuration
1121
1122         * WebCore.xcodeproj/project.pbxproj:
1123
1124 2006-08-15  Mark Rowe  <opendarwin.org@bdash.net.nz>
1125
1126         Reviewed by Hyatt.
1127         Tweaked and landed by Darin.
1128
1129         http://bugzilla.opendarwin.org/show_bug.cgi?id=10399
1130         Bug 10399: RenderTextArea is unused
1131
1132         * WebCore.vcproj/WebCore/WebCore.vcproj:
1133         * WebCore.xcodeproj/project.pbxproj:
1134         * WebCoreSources.bkl:
1135         Removed RenderTextArea source files.
1136
1137         * html/HTMLTextAreaElement.cpp: Removed include of RenderTextArea.h.
1138         * html/HTMLTextAreaElement.h: Removed forward declaration of RenderTextArea.
1139
1140         * platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Updated a comment.
1141
1142         * platform/TextBox.h: Removed.
1143         * platform/mac/TextBoxMac.mm: Removed.
1144         * platform/mac/WebCoreTextArea.h: Removed.
1145         * platform/mac/WebCoreTextArea.mm: Removed.
1146         * rendering/RenderTextArea.cpp: Removed.
1147         * rendering/RenderTextArea.h: Removed.
1148
1149 2006-08-15  Brady Eidson  <beidson@apple.com>
1150
1151         Reviewed by THE OTHER Maciej...
1152
1153         Two small fixes -
1154         1) Renamed retain/release methods to add PageUrl in - we're being consistent and clear in the WebCore API
1155         2) Fixed a bug where a null SiteIcon reference would be added into the pageURLToSiteIcon map causing a
1156         null dereference later
1157
1158         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1159         (-[WebCoreIconDatabaseBridge retainIconForURL:]):  Changed IconDatabase method name
1160         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):  ditto
1161         * loader/icon/IconDatabase.cpp:
1162         (WebCore::IconDatabase::retainIconForPageURL):  Name change
1163         (WebCore::IconDatabase::releaseIconForPageURL):  ditto
1164         (WebCore::IconDatabase::setIconURLForPageURL):  Added the null site-icon check when changing a PageURL's iconURL
1165         * loader/icon/IconDatabase.h:  Some renames
1166
1167 2006-08-14  Eric Seidel  <eric@eseidel.com>
1168
1169         Reviewed by mjs.
1170
1171         <mask>, <marker>, <pattern> inside <defs> do not work
1172         http://bugzilla.opendarwin.org/show_bug.cgi?id=6548
1173
1174         * ksvg2/svg/SVGDefsElement.cpp:
1175         (WebCore::SVGDefsElement::SVGDefsElement): moved to .cpp file
1176         (WebCore::SVGDefsElement::isValid): moved to .cpp file
1177         (WebCore::SVGDefsElement::rendererIsNeeded): Added.
1178         (WebCore::SVGDefsElement::createRenderer): Added.
1179         * ksvg2/svg/SVGDefsElement.h:
1180         * ksvg2/svg/SVGGElement.cpp:
1181         (WebCore::SVGGElement::SVGGElement): adjusted spacing
1182         (WebCore::SVGGElement::parseMappedAttribute): adjusted spacing
1183         (WebCore::SVGDummyElement::SVGDummyElement): adjusted spacing
1184
1185 2006-08-14  Eric Seidel  <eric@eseidel.com>
1186
1187         Reviewed by darin and mjs.
1188         
1189         Add better SVGLoad event support.
1190         http://bugzilla.opendarwin.org/show_bug.cgi?id=6010
1191         There will still need to be additional support added for <link> and <script> elements.
1192         Not all of the error -> loaded -> error transition cases work yet.
1193
1194         * dom/EventTargetNode.cpp:
1195         (WebCore::EventTargetNode::dispatchGenericEvent):
1196         * html/HTMLImageLoader.cpp:
1197         (WebCore::HTMLImageLoader::dispatchLoadEvent):
1198         * html/HTMLImageLoader.h:
1199         (WebCore::HTMLImageLoader::haveFiredLoadEvent):
1200         (WebCore::HTMLImageLoader::setHaveFiredLoadEvent):
1201         * ksvg2/misc/SVGImageLoader.cpp:
1202         (WebCore::SVGImageLoader::SVGImageLoader):
1203         (WebCore::SVGImageLoader::dispatchLoadEvent):
1204         * ksvg2/misc/SVGImageLoader.h:
1205         * ksvg2/svg/SVGAElement.cpp:
1206         (WebCore::SVGAElement::parseMappedAttribute):
1207         * ksvg2/svg/SVGAnimatedBoolean.h:
1208         * ksvg2/svg/SVGElement.cpp:
1209         (WebCore::SVGElement::SVGElement):
1210         (WebCore::SVGElement::parseMappedAttribute):
1211         (WebCore::SVGElement::haveLoadedRequiredResources):
1212         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
1213         (WebCore::SVGElement::closeRenderer):
1214         * ksvg2/svg/SVGElement.h:
1215         (WebCore::SVGElement::rendererIsNeeded):
1216         (WebCore::svg_dynamic_cast):
1217         * ksvg2/svg/SVGExternalResourcesRequired.h:
1218         * ksvg2/svg/SVGImageElement.cpp:
1219         (SVGImageElement::SVGImageElement):
1220         (SVGImageElement::haveLoadedRequiredResources):
1221         * ksvg2/svg/SVGImageElement.h:
1222         * ksvg2/svg/SVGSVGElement.cpp:
1223         (WebCore::SVGSVGElement::parseMappedAttribute):
1224         * ksvg2/svg/SVGScriptElement.cpp:
1225         (WebCore::SVGScriptElement::SVGScriptElement):
1226         (WebCore::SVGScriptElement::parseMappedAttribute):
1227         (WebCore::SVGScriptElement::executeScript):
1228         * xml/xmlhttprequest.cpp:
1229         (WebCore::XMLHttpRequest::callReadyStateChangeListener): use new Event() instead of createEvent
1230
1231 2006-08-14  Anders Carlsson  <acarlsson@apple.com>
1232
1233         Reviewed by Maciej.
1234
1235         http://bugzilla.opendarwin.org/show_bug.cgi?id=10393
1236         Autogenerate NodeIterator and TreeWalker.
1237         
1238         * DerivedSources.make:
1239         * WebCore.xcodeproj/project.pbxproj:
1240         Add new files.
1241         
1242         * bindings/js/JSNodeIteratorCustom.cpp: Added.
1243         (WebCore::JSNodeIterator::mark):
1244         * bindings/js/JSTreeWalkerCustom.cpp: Added.
1245         (WebCore::JSTreeWalker::mark):
1246         
1247         * bindings/js/kjs_traversal.cpp:
1248         * bindings/js/kjs_traversal.h:
1249         Remove implementations of DOMNodeIterator and DOMTreeWalker.
1250
1251         * bindings/scripts/CodeGeneratorJS.pm:
1252         Add "CustomMarkFunction" attribute for classes where mark() needs to be overridden.
1253         
1254         * bindings/objc/DOM.mm:
1255         (-[DOMNodeIterator detach]):
1256         * dom/NodeIterator.cpp:
1257         (WebCore::NodeIterator::detach):
1258         * dom/NodeIterator.h:
1259         Get rid of exception in detach, it isn't used at all and this function can't throw an exception according to the spec.
1260         * dom/NodeIterator.idl: Added.
1261         * dom/TreeWalker.idl: Added.
1262
1263 2006-08-14  Brady Eidson  <beidson@apple.com>
1264
1265         Reviewed by John
1266
1267         The changes are plentiful, but small, mostly to improve performance
1268         1) Add a bool flag to SiteIcon to stop it from querying the database over and over
1269         2) Added a pageURL->iconURL hashmap to cache database results, as an optimization
1270         3) Fix a bug in setIconURLForPageURL code where the pageURL would still point to an old icon
1271         4) Added isIconURLRetained() to optimize the retain count check
1272         5) Prune old, unused code
1273
1274         * loader/icon/IconDatabase.cpp:
1275         (WebCore::IconDatabase::imageDataForIconID): Removed unused code
1276         (WebCore::IconDatabase::imageDataForIconURL): Removed unused code
1277         (WebCore::IconDatabase::imageDataForPageURL): Removed unused code
1278         (WebCore::IconDatabase::isIconExpiredForIconURL): Removed LOG msg
1279         (WebCore::IconDatabase::isIconExpiredForPageURL): Removed LOG msg
1280         (WebCore::IconDatabase::iconURLForPageURL): Added a hashmap cache to avoid common queries
1281         (WebCore::IconDatabase::releaseIconForURL): Changed to is isRetained() instead of retainCount()
1282         (WebCore::IconDatabase::isIconURLRetained): Added - we don't care about the actual retain count
1283           for an icon so much as whether or not it is retained
1284         (WebCore::IconDatabase::setIconURLForPageURL): If the new and old iconURLs are the same, skip the
1285           SQLite code
1286         * loader/icon/IconDatabase.h:  Added new methods/variables
1287         * loader/icon/SiteIcon.cpp:
1288         (SiteIcon::SiteIcon): Added a flag so it only queries the database for icon data once
1289         (SiteIcon::getImage): Ditto
1290
1291 2006-08-14  David Hyatt  <hyatt@apple.com>
1292
1293         Fix for bug 10385, add more support for crappy pseudo-XML-in-HTML.
1294
1295         Reviewed by ggaren
1296
1297         Added fast/parser/bad-xml-slash.html
1298
1299         * html/HTMLTokenizer.cpp:
1300         (WebCore::HTMLTokenizer::parseTag):
1301
1302 2006-08-14  Darin Adler  <darin@apple.com>
1303
1304         Reviewed by John Sullivan.
1305
1306         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10204
1307           REGRESSION: title tag parsing problem breaks Travelocity and Google Analytics pages
1308
1309         Test: fast/parser/title-error-test.html
1310
1311         * html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Fixed an error
1312         handling case that was skipping until a </style> tag in code that was shared
1313         between both <title> and <style>. Also rearranged the code a tiny bit.
1314
1315 2006-08-14  Darin Adler  <darin@apple.com>
1316
1317         Reviewed by Hyatt.
1318
1319         - fixed some storage leaks
1320           (part of http://bugzilla.opendarwin.org/show_bug.cgi?id=10259)
1321
1322         * platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
1323         Rearrange code so that "delete this" is called any time the function returns
1324         false -- ownership was inconsistent before.
1325
1326         * rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode):
1327         Call deleteLineBoxWrapper even when documentBeingDestroyed() is true, because
1328         some of what it does has to be done during destruction. A little awkward since
1329         I preserved the order of operations. Perhaps we could structure this better later.
1330
1331 2006-08-14  David Harrison  <harrison@apple.com>
1332
1333         Reviewed by John Sullivan and Geoff Garen.
1334
1335         <rdar://problem/3854950> AX Seed: Blackboard Learning Systems - frame names need to be put in AXDescription AXAttribute
1336
1337         Test cases added: None.  Manual AX testing is way too awkward, and automated testing
1338         is not possible.  See following bug...
1339             <rdar://problem/4256882> Need automated testing support for accessibility APIs
1340
1341         * bridge/mac/WebCoreAXObject.mm:
1342         (-[WebCoreAXObject accessibilityDescription]):
1343         For a web area, return the name of the owning frame or iframe.
1344         
1345         (-[WebCoreAXObject accessibilityAttributeNames]):
1346         Advertize NSAccessibilityDescriptionAttribute.
1347         
1348         (-[WebCoreAXObject rendererForView:]):
1349         Clean up some old naming.
1350
1351 2006-08-11  Anders Carlsson  <acarlsson@apple.com>
1352
1353         Reviewed by Darin.
1354
1355         http://bugzilla.opendarwin.org/show_bug.cgi?id=10353
1356         XMLSerializer and DOMParser should have real implementations
1357         
1358         Make real implementation files for DOMParser and XMLSerializer and wrap them
1359         using our bindings generation.
1360         
1361         * DerivedSources.make:
1362         * WebCore.xcodeproj/project.pbxproj:
1363         * bindings/js/JSDOMParser.cpp: Removed.
1364         * bindings/js/JSDOMParser.h: Removed.
1365         * bindings/js/JSXMLSerializer.cpp: Removed.
1366         * bindings/js/JSXMLSerializer.h: Removed.
1367         * bindings/js/kjs_window.cpp:
1368         (KJS::Window::getValueProperty):
1369         * bindings/js/kjs_window.h:
1370         (KJS::Window::):
1371         * page/DOMWindow.idl:
1372         * xml/DOMParser.cpp: Added.
1373         (WebCore::DOMParser::parseFromString):
1374         * xml/DOMParser.h: Added.
1375         * xml/DOMParser.idl: Added.
1376         * xml/XMLSerializer.cpp: Added.
1377         (WebCore::XMLSerializer::serializeToString):
1378         * xml/XMLSerializer.h: Added.
1379         * xml/XMLSerializer.idl: Added.
1380
1381 2006-08-14  Maciej Stachowiak  <mjs@apple.com>
1382
1383         Reviewed by Brady.
1384
1385         - removed WebKit-level dependencies from WebFormDataStream. Use WebCore version of system interface
1386
1387         * WebCore.exp: export new functions
1388         * platform/mac/WebCoreSystemInterface.h: Added CFReadStream related functions
1389         * platform/mac/WebCoreSystemInterface.mm: ditto
1390
1391 2006-08-13  Maks Orlovich  <maksim@kde.org>
1392
1393         Reviewed (and tweaked a little) by Maciej.
1394         
1395         - shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting
1396         in a 1.2% speed improvement on JS iBench (and probably overall memory savings).
1397
1398         The WebCore part of this is to expect only FunctionImp to have a scope, not all JSObjects.
1399         
1400         * bindings/js/kjs_events.cpp:
1401         (KJS::JSLazyEventListener::parseCode):
1402
1403 2006-08-12  Eric Seidel  <eric@eseidel.com>
1404
1405         Reviewed by hyatt and mjs.
1406
1407         Fix two missing null checks causing layout test crashes.
1408
1409         * css/cssstyleselector.cpp:
1410         (WebCore::CSSStyleSelector::adjustRenderStyle): check e for null (null for pseudo styles)
1411         * kcanvas/RenderSVGContainer.cpp:
1412         (WebCore::RenderSVGContainer::requiresLayer): check parent()->element() for null
1413
1414
1415 2006-08-11  Eric Seidel  <eric@eseidel.com>
1416
1417         Reviewed by andersca.
1418
1419         The outermost <svg> element needs to clip itself
1420         http://bugzilla.opendarwin.org/show_bug.cgi?id=5358
1421
1422         * css/cssstyleselector.cpp:
1423         (WebCore::CSSStyleSelector::adjustRenderStyle): adjust for SVG overflow rules
1424         * kcanvas/RenderSVGContainer.cpp:
1425         (WebCore::RenderSVGContainer::requiresLayer): only require layers for absolute/relative positioning of outermost SVG
1426         (WebCore::RenderSVGContainer::paint):
1427         * kcanvas/device/KRenderingDevice.h:
1428         * kcanvas/device/quartz/KRenderingDeviceQuartz.h: remove dead methods
1429         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: remove dead methods
1430         (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz):
1431         * ksvg2/svg/SVGPaint.cpp: spacing changes
1432         (WebCore::SVGPaint::SVGPaint): spacing cleanup
1433         * ksvg2/svg/SVGSVGElement.cpp:
1434         (WebCore::SVGSVGElement::parseMappedAttribute): spacing cleanup
1435         * platform/GraphicsContext.h: Added concatCTM
1436         * platform/cg/GraphicsContextCG.cpp:
1437         (WebCore::GraphicsContext::concatCTM): Added.
1438
1439 2006-08-11  Brady Eidson  <beidson@apple.com>
1440
1441         Reviewed by Maciej
1442
1443         Renamed a method/parameter for clarity and consistency, as well as some style
1444         cleanups and removing some ridiculously verbose log messages.
1445         Also added an _isEmpty method to the database and bridge for WebKit's use.
1446         Finally, added a central way for both WebKit and WebCore to get the icon database filename
1447
1448         * bridge/mac/WebCoreIconDatabaseBridge.h:  Added _isEmpty and defaultDatabaseFilename
1449         * bridge/mac/WebCoreIconDatabaseBridge.mm:  Removed an unnecessary semicolon off most of these methods
1450         (-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]):
1451         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
1452         (-[WebCoreIconDatabaseBridge isOpen]):
1453         (-[WebCoreIconDatabaseBridge _isEmpty]):  Added
1454         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
1455         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
1456         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
1457         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
1458         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
1459         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
1460         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
1461         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
1462         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
1463         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
1464         (-[WebCoreIconDatabaseBridge _hasIconForIconURL:]):
1465         (-[WebCoreIconDatabaseBridge defaultDatabaseFilename]):  Added
1466
1467         * loader/icon/IconDatabase.cpp:
1468         (WebCore::IconDatabase::defaultDatabaseFilename):  Added
1469         (WebCore::IconDatabase::open):  
1470         (WebCore::IconDatabase::isEmpty):  Added
1471         (WebCore::IconDatabase::retainIconForURL):  Removed log message
1472         (WebCore::IconDatabase::releaseIconForURL):  Removed log message
1473         * loader/icon/IconDatabase.h: 
1474
1475 2006-08-11  David Hyatt  <hyatt@apple.com>
1476
1477         Eliminate RenderImageButton.
1478
1479         Reviewed by darin
1480
1481         * WebCore.xcodeproj/project.pbxproj:
1482         * bridge/mac/WebCoreAXObject.mm:
1483         (-[WebCoreAXObject isImageButton]):
1484         * html/HTMLInputElement.cpp:
1485         (WebCore::HTMLInputElement::createRenderer):
1486         * rendering/RenderImage.h:
1487         (WebCore::RenderImage::isImage):
1488
1489 2006-08-11  Adele Peterson  <adele@apple.com>
1490
1491         Reviewed by Brady.
1492
1493         - Fix for <rdar://problem/4656274> 
1494         REGRESSION: option elements are selected when added regardless of "selected" property
1495
1496         Test: fast/forms/option-constructor-selected.html
1497
1498         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption):
1499         When adding an option element, check that the option element is selected before calling setSelectedIndex.
1500
1501 2006-08-11  David Hyatt  <hyatt@apple.com>
1502
1503         Fix for bug 10349, make sure to call setChanged when an anchor changes
1504         from not being a link to being a link (and vice versa).
1505
1506         Test is in fast/dynamic/link-href-change.html
1507
1508         Reviewed by darin
1509
1510         * html/HTMLAnchorElement.cpp:
1511         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
1512         (WebCore::HTMLAnchorElement::parseMappedAttribute):
1513         * html/HTMLAnchorElement.h:
1514         * html/HTMLAreaElement.cpp:
1515         (WebCore::HTMLAreaElement::parseMappedAttribute):
1516
1517 2006-08-09  Rob Buis  <buis@kde.org>
1518
1519         Reviewed by Darin.
1520
1521         Revert an over-optimization step that messed up the HashSet lookup.
1522
1523         * dom/DOMImplementation.cpp:
1524
1525 2006-08-12  Oliver  <ojh16@student.canterbury.ac.nz>
1526
1527         Rubber stamped by tim
1528
1529         Removed commented out code
1530
1531         * kcanvas/RenderSVGImage.cpp:
1532         (WebCore::RenderSVGImage::paint):
1533
1534 2006-08-12  Oliver  <ojh16@student.canterbury.ac.nz>
1535
1536         Reviewed by geoff
1537
1538         Fixed regression in SVG image layout
1539         (see bug #10346)
1540
1541         * kcanvas/RenderSVGImage.cpp:
1542         (WebCore::RenderSVGImage::paint):
1543
1544 2006-08-10  Anders Carlsson  <acarlsson@apple.com>
1545
1546         Rubber-stamped by Maciej.
1547
1548         Move xpath to xml.
1549         
1550         * DerivedSources.make:
1551         * WebCore.vcproj/WebCore/WebCore.vcproj:
1552         * WebCore.xcodeproj/project.pbxproj:
1553         * xpath/XPathEvaluator.cpp: Removed.
1554         * xpath/XPathEvaluator.h: Removed.
1555         * xpath/XPathEvaluator.idl: Removed.
1556         * xpath/XPathExpression.cpp: Removed.
1557         * xpath/XPathExpression.h: Removed.
1558         * xpath/XPathExpression.idl: Removed.
1559         * xpath/XPathNSResolver.cpp: Removed.
1560         * xpath/XPathNSResolver.h: Removed.
1561         * xpath/XPathNSResolver.idl: Removed.
1562         * xpath/XPathNamespace.cpp: Removed.
1563         * xpath/XPathNamespace.h: Removed.
1564         * xpath/XPathResult.cpp: Removed.
1565         * xpath/XPathResult.h: Removed.
1566         * xpath/XPathResult.idl: Removed.
1567         * xpath/impl/XPathExpressionNode.cpp: Removed.
1568         * xpath/impl/XPathExpressionNode.h: Removed.
1569         * xpath/impl/XPathFunctions.cpp: Removed.
1570         * xpath/impl/XPathFunctions.h: Removed.
1571         * xpath/impl/XPathGrammar.y: Removed.
1572         * xpath/impl/XPathParser.cpp: Removed.
1573         * xpath/impl/XPathParser.h: Removed.
1574         * xpath/impl/XPathPath.cpp: Removed.
1575         * xpath/impl/XPathPath.h: Removed.
1576         * xpath/impl/XPathPredicate.cpp: Removed.
1577         * xpath/impl/XPathPredicate.h: Removed.
1578         * xpath/impl/XPathStep.cpp: Removed.
1579         * xpath/impl/XPathStep.h: Removed.
1580         * xpath/impl/XPathUtil.cpp: Removed.
1581         * xpath/impl/XPathUtil.h: Removed.
1582         * xpath/impl/XPathValue.cpp: Removed.
1583         * xpath/impl/XPathValue.h: Removed.
1584         * xpath/impl/XPathVariableReference.cpp: Removed.
1585         * xpath/impl/XPathVariableReference.h: Removed.
1586
1587 2006-08-10  David Harrison  <harrison@apple.com>
1588
1589         Reviewed by John Sullivan.
1590
1591         <rdar://problem/4600112> REGRESSION: VO no longer able to review text within an edit field on web pages
1592
1593         Test cases added: None.  Manual AX testing is way too awkward, and automated testing
1594         is not possible.  See following bug...
1595             <rdar://problem/4256882> Need automated testing support for accessibility APIs
1596
1597         * bridge/mac/WebCoreAXObject.mm:
1598         (-[WebCoreAXObject value]):
1599         Add handling for text input fields.
1600
1601 2006-08-09  Graham Dennis  <graham.dennis@gmail.com>
1602
1603         Reviewed by Darin.
1604
1605         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10247
1606         REGRESSION: Unable to build webkit without SVG/XPATH
1607
1608         * bindings/js/kjs_binding.cpp:
1609         (KJS::setDOMException):
1610         * bindings/js/kjs_dom.cpp:
1611         (KJS::toJS):
1612         * bindings/js/kjs_html.cpp:
1613         (KJS::HTMLElementFunction::callAsFunction):
1614         * bindings/js/kjs_proxy.cpp:
1615         * bindings/js/kjs_proxy.h:
1616         * bindings/objc/DOMInternal.h:
1617         * bindings/objc/DOMInternal.mm:
1618         (raiseDOMException):
1619         * bindings/objc/DOMXPath.mm:
1620         * bindings/objc/DOMXPathInternal.h:
1621         * bindings/scripts/CodeGeneratorJS.pm:
1622         * bridge/mac/WebCoreFrameBridge.mm:
1623         (+[WebCoreFrameBridge supportedNonImageMIMETypes]):
1624         * css/CSSGrammar.y:
1625         * css/CSSStyleDeclaration.cpp:
1626         (WebCore::propertyID):
1627         * css/cssparser.cpp:
1628         (WebCore::CSSParser::parseValue):
1629         * css/cssparser.h:
1630         * css/cssstyleselector.cpp:
1631         (WebCore::CSSStyleSelector::loadDefaultStyle):
1632         (WebCore::CSSStyleSelector::applyProperty):
1633         * css/cssstyleselector.h:
1634         * dom/Document.cpp:
1635         (WebCore::Document::Document):
1636         (WebCore::Document::~Document):
1637         (WebCore::Document::createElementNS):
1638         (WebCore::Document::implicitClose):
1639         (WebCore::Document::recalcStyleSelector):
1640         (WebCore::Document::createEvent):
1641         * dom/Document.h:
1642         * dom/Document.idl:
1643         * dom/Node.cpp:
1644         (WebCore::Node::createRendererIfNeeded):
1645         * dom/Node.h:
1646         * dom/XMLTokenizer.cpp:
1647         (WebCore::XMLTokenizer::endElementNs):
1648         (WebCore::XMLTokenizer::insertErrorMessageBlock):
1649         * html/HTMLEmbedElement.cpp:
1650         * html/HTMLEmbedElement.h:
1651         * html/HTMLObjectElement.cpp:
1652         * html/HTMLObjectElement.h:
1653         * kcanvas/KCanvasCreator.cpp:
1654         * kcanvas/KCanvasCreator.h:
1655         * kcanvas/KCanvasFilters.cpp:
1656         * kcanvas/KCanvasFilters.h:
1657         * kcanvas/KCanvasImage.h:
1658         * kcanvas/KCanvasMatrix.cpp:
1659         * kcanvas/KCanvasMatrix.h:
1660         * kcanvas/KCanvasPath.cpp:
1661         * kcanvas/KCanvasPath.h:
1662         * kcanvas/KCanvasResourceListener.h:
1663         * kcanvas/KCanvasResources.cpp:
1664         * kcanvas/KCanvasResources.h:
1665         * kcanvas/KCanvasTreeDebug.cpp:
1666         * kcanvas/RenderForeignObject.cpp:
1667         * kcanvas/RenderForeignObject.h:
1668         * kcanvas/RenderPath.cpp:
1669         * kcanvas/RenderPath.h:
1670         * kcanvas/RenderSVGContainer.cpp:
1671         * kcanvas/RenderSVGContainer.h:
1672         * kcanvas/RenderSVGImage.cpp:
1673         * kcanvas/RenderSVGImage.h:
1674         * kcanvas/RenderSVGText.cpp:
1675         * kcanvas/RenderSVGText.h:
1676         * kcanvas/device/KRenderingDevice.cpp:
1677         * kcanvas/device/KRenderingDevice.h:
1678         * kcanvas/device/KRenderingFillPainter.cpp:
1679         * kcanvas/device/KRenderingFillPainter.h:
1680         * kcanvas/device/KRenderingPaintServer.h:
1681         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1682         * kcanvas/device/KRenderingPaintServerGradient.h:
1683         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1684         * kcanvas/device/KRenderingPaintServerPattern.h:
1685         * kcanvas/device/KRenderingPaintServerSolid.cpp:
1686         * kcanvas/device/KRenderingPaintServerSolid.h:
1687         * kcanvas/device/KRenderingStrokePainter.cpp:
1688         * kcanvas/device/KRenderingStrokePainter.h:
1689         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
1690         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1691         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1692         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1693         * kcanvas/device/quartz/KCanvasPathQuartz.mm:
1694         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1695         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1696         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1697         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1698         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1699         * kcanvas/device/quartz/QuartzSupport.h:
1700         * kcanvas/device/quartz/QuartzSupport.mm:
1701         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
1702         * ksvg2/bindings/js/JSSVGElementWrapperFactory.h:
1703         * ksvg2/css/SVGCSSParser.cpp:
1704         * ksvg2/css/SVGCSSStyleSelector.cpp:
1705         * ksvg2/css/SVGRenderStyle.cpp:
1706         * ksvg2/css/SVGRenderStyle.h:
1707         * ksvg2/css/SVGRenderStyleDefs.cpp:
1708         * ksvg2/css/SVGRenderStyleDefs.h:
1709         * ksvg2/ecma/GlobalObject.cpp:
1710         * ksvg2/ecma/GlobalObject.h:
1711         * ksvg2/events/JSSVGLazyEventListener.cpp:
1712         * ksvg2/events/JSSVGLazyEventListener.h:
1713         * ksvg2/events/SVGZoomEvent.cpp:
1714         * ksvg2/events/SVGZoomEvent.h:
1715         * ksvg2/ksvg.h:
1716         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1717         * ksvg2/misc/KCanvasRenderingStyle.h:
1718         * ksvg2/misc/KSVGTimeScheduler.cpp:
1719         * ksvg2/misc/KSVGTimeScheduler.h:
1720         * ksvg2/misc/SVGDocumentExtensions.cpp:
1721         * ksvg2/misc/SVGDocumentExtensions.h:
1722         * ksvg2/misc/SVGImageLoader.cpp:
1723         * ksvg2/misc/SVGImageLoader.h:
1724         * ksvg2/svg/DOMList.h:
1725         * ksvg2/svg/SVGAElement.cpp:
1726         * ksvg2/svg/SVGAElement.h:
1727         * ksvg2/svg/SVGAngle.cpp:
1728         * ksvg2/svg/SVGAngle.h:
1729         * ksvg2/svg/SVGAnimateColorElement.cpp:
1730         * ksvg2/svg/SVGAnimateColorElement.h:
1731         * ksvg2/svg/SVGAnimateElement.cpp:
1732         * ksvg2/svg/SVGAnimateElement.h:
1733         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1734         * ksvg2/svg/SVGAnimateTransformElement.h:
1735         * ksvg2/svg/SVGAnimatedAngle.cpp:
1736         * ksvg2/svg/SVGAnimatedAngle.h:
1737         * ksvg2/svg/SVGAnimatedBoolean.cpp:
1738         * ksvg2/svg/SVGAnimatedBoolean.h:
1739         * ksvg2/svg/SVGAnimatedColor.cpp:
1740         * ksvg2/svg/SVGAnimatedColor.h:
1741         * ksvg2/svg/SVGAnimatedEnumeration.cpp:
1742         * ksvg2/svg/SVGAnimatedEnumeration.h:
1743         * ksvg2/svg/SVGAnimatedInteger.cpp:
1744         * ksvg2/svg/SVGAnimatedInteger.h:
1745         * ksvg2/svg/SVGAnimatedLength.cpp:
1746         * ksvg2/svg/SVGAnimatedLength.h:
1747         * ksvg2/svg/SVGAnimatedLengthList.cpp:
1748         * ksvg2/svg/SVGAnimatedLengthList.h:
1749         * ksvg2/svg/SVGAnimatedNumber.cpp:
1750         * ksvg2/svg/SVGAnimatedNumber.h:
1751         * ksvg2/svg/SVGAnimatedNumberList.cpp:
1752         * ksvg2/svg/SVGAnimatedNumberList.h:
1753         * ksvg2/svg/SVGAnimatedPathData.cpp:
1754         * ksvg2/svg/SVGAnimatedPathData.h:
1755         * ksvg2/svg/SVGAnimatedPoints.cpp:
1756         * ksvg2/svg/SVGAnimatedPoints.h:
1757         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.cpp:
1758         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.h:
1759         * ksvg2/svg/SVGAnimatedRect.cpp:
1760         * ksvg2/svg/SVGAnimatedRect.h:
1761         * ksvg2/svg/SVGAnimatedString.cpp:
1762         * ksvg2/svg/SVGAnimatedString.h:
1763         * ksvg2/svg/SVGAnimatedTemplate.h:
1764         * ksvg2/svg/SVGAnimatedTransformList.cpp:
1765         * ksvg2/svg/SVGAnimatedTransformList.h:
1766         * ksvg2/svg/SVGAnimationElement.cpp:
1767         * ksvg2/svg/SVGAnimationElement.h:
1768         * ksvg2/svg/SVGCircleElement.cpp:
1769         * ksvg2/svg/SVGCircleElement.h:
1770         * ksvg2/svg/SVGClipPathElement.cpp:
1771         * ksvg2/svg/SVGClipPathElement.h:
1772         * ksvg2/svg/SVGColor.cpp:
1773         * ksvg2/svg/SVGColor.h:
1774         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1775         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
1776         * ksvg2/svg/SVGCursorElement.cpp:
1777         * ksvg2/svg/SVGCursorElement.h:
1778         * ksvg2/svg/SVGDOMImplementation.cpp:
1779         * ksvg2/svg/SVGDOMImplementation.h:
1780         * ksvg2/svg/SVGDefsElement.cpp:
1781         * ksvg2/svg/SVGDefsElement.h:
1782         * ksvg2/svg/SVGDescElement.cpp:
1783         * ksvg2/svg/SVGDescElement.h:
1784         * ksvg2/svg/SVGDocument.cpp:
1785         * ksvg2/svg/SVGDocument.h:
1786         * ksvg2/svg/SVGElement.cpp:
1787         * ksvg2/svg/SVGElement.h:
1788         * ksvg2/svg/SVGElementInstance.cpp:
1789         * ksvg2/svg/SVGElementInstance.h:
1790         * ksvg2/svg/SVGElementInstanceList.cpp:
1791         * ksvg2/svg/SVGElementInstanceList.h:
1792         * ksvg2/svg/SVGEllipseElement.cpp:
1793         * ksvg2/svg/SVGEllipseElement.h:
1794         * ksvg2/svg/SVGExternalResourcesRequired.cpp:
1795         * ksvg2/svg/SVGExternalResourcesRequired.h:
1796         * ksvg2/svg/SVGFEBlendElement.cpp:
1797         * ksvg2/svg/SVGFEBlendElement.h:
1798         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1799         * ksvg2/svg/SVGFEColorMatrixElement.h:
1800         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
1801         * ksvg2/svg/SVGFEComponentTransferElement.h:
1802         * ksvg2/svg/SVGFECompositeElement.cpp:
1803         * ksvg2/svg/SVGFECompositeElement.h:
1804         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1805         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
1806         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1807         * ksvg2/svg/SVGFEDisplacementMapElement.h:
1808         * ksvg2/svg/SVGFEDistantLightElement.cpp:
1809         * ksvg2/svg/SVGFEDistantLightElement.h:
1810         * ksvg2/svg/SVGFEFloodElement.cpp:
1811         * ksvg2/svg/SVGFEFloodElement.h:
1812         * ksvg2/svg/SVGFEFuncAElement.cpp:
1813         * ksvg2/svg/SVGFEFuncAElement.h:
1814         * ksvg2/svg/SVGFEFuncBElement.cpp:
1815         * ksvg2/svg/SVGFEFuncBElement.h:
1816         * ksvg2/svg/SVGFEFuncGElement.cpp:
1817         * ksvg2/svg/SVGFEFuncGElement.h:
1818         * ksvg2/svg/SVGFEFuncRElement.cpp:
1819         * ksvg2/svg/SVGFEFuncRElement.h:
1820         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1821         * ksvg2/svg/SVGFEGaussianBlurElement.h:
1822         * ksvg2/svg/SVGFEImageElement.cpp:
1823         * ksvg2/svg/SVGFEImageElement.h:
1824         * ksvg2/svg/SVGFELightElement.cpp:
1825         * ksvg2/svg/SVGFELightElement.h:
1826         * ksvg2/svg/SVGFEMergeElement.cpp:
1827         * ksvg2/svg/SVGFEMergeElement.h:
1828         * ksvg2/svg/SVGFEMergeNodeElement.cpp:
1829         * ksvg2/svg/SVGFEMergeNodeElement.h:
1830         * ksvg2/svg/SVGFEOffsetElement.cpp:
1831         * ksvg2/svg/SVGFEOffsetElement.h:
1832         * ksvg2/svg/SVGFEPointLightElement.cpp:
1833         * ksvg2/svg/SVGFEPointLightElement.h:
1834         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1835         * ksvg2/svg/SVGFESpecularLightingElement.h:
1836         * ksvg2/svg/SVGFESpotLightElement.cpp:
1837         * ksvg2/svg/SVGFESpotLightElement.h:
1838         * ksvg2/svg/SVGFETileElement.cpp:
1839         * ksvg2/svg/SVGFETileElement.h:
1840         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1841         * ksvg2/svg/SVGFETurbulenceElement.h:
1842         * ksvg2/svg/SVGFilterElement.cpp:
1843         * ksvg2/svg/SVGFilterElement.h:
1844         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
1845         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
1846         * ksvg2/svg/SVGFitToViewBox.cpp:
1847         * ksvg2/svg/SVGFitToViewBox.h:
1848         * ksvg2/svg/SVGForeignObjectElement.cpp:
1849         * ksvg2/svg/SVGForeignObjectElement.h:
1850         * ksvg2/svg/SVGGElement.cpp:
1851         * ksvg2/svg/SVGGElement.h:
1852         * ksvg2/svg/SVGGradientElement.cpp:
1853         * ksvg2/svg/SVGGradientElement.h:
1854         * ksvg2/svg/SVGHelper.cpp:
1855         * ksvg2/svg/SVGHelper.h:
1856         * ksvg2/svg/SVGImageElement.cpp:
1857         * ksvg2/svg/SVGImageElement.h:
1858         * ksvg2/svg/SVGLangSpace.cpp:
1859         * ksvg2/svg/SVGLangSpace.h:
1860         * ksvg2/svg/SVGLength.cpp:
1861         * ksvg2/svg/SVGLength.h:
1862         * ksvg2/svg/SVGLengthList.cpp:
1863         * ksvg2/svg/SVGLengthList.h:
1864         * ksvg2/svg/SVGLineElement.cpp:
1865         * ksvg2/svg/SVGLineElement.h:
1866         * ksvg2/svg/SVGLinearGradientElement.cpp:
1867         * ksvg2/svg/SVGLinearGradientElement.h:
1868         * ksvg2/svg/SVGList.h:
1869         * ksvg2/svg/SVGLocatable.cpp:
1870         * ksvg2/svg/SVGLocatable.h:
1871         * ksvg2/svg/SVGMarkerElement.cpp:
1872         * ksvg2/svg/SVGMarkerElement.h:
1873         * ksvg2/svg/SVGMaskElement.cpp:
1874         * ksvg2/svg/SVGMaskElement.h:
1875         * ksvg2/svg/SVGMatrix.cpp:
1876         * ksvg2/svg/SVGMatrix.h:
1877         * ksvg2/svg/SVGNumber.cpp:
1878         * ksvg2/svg/SVGNumber.h:
1879         * ksvg2/svg/SVGNumberList.cpp:
1880         * ksvg2/svg/SVGNumberList.h:
1881         * ksvg2/svg/SVGPaint.cpp:
1882         * ksvg2/svg/SVGPaint.h:
1883         * ksvg2/svg/SVGPathElement.cpp:
1884         * ksvg2/svg/SVGPathElement.h:
1885         * ksvg2/svg/SVGPathSeg.cpp:
1886         * ksvg2/svg/SVGPathSeg.h:
1887         * ksvg2/svg/SVGPathSegArc.cpp:
1888         * ksvg2/svg/SVGPathSegArc.h:
1889         * ksvg2/svg/SVGPathSegClosePath.cpp:
1890         * ksvg2/svg/SVGPathSegClosePath.h:
1891         * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
1892         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
1893         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
1894         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
1895         * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
1896         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
1897         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
1898         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
1899         * ksvg2/svg/SVGPathSegLineto.cpp:
1900         * ksvg2/svg/SVGPathSegLineto.h:
1901         * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
1902         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
1903         * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
1904         * ksvg2/svg/SVGPathSegLinetoVertical.h:
1905         * ksvg2/svg/SVGPathSegList.cpp:
1906         * ksvg2/svg/SVGPathSegList.h:
1907         * ksvg2/svg/SVGPathSegMoveto.cpp:
1908         * ksvg2/svg/SVGPathSegMoveto.h:
1909         * ksvg2/svg/SVGPatternElement.cpp:
1910         * ksvg2/svg/SVGPatternElement.h:
1911         * ksvg2/svg/SVGPoint.cpp:
1912         * ksvg2/svg/SVGPoint.h:
1913         * ksvg2/svg/SVGPointList.cpp:
1914         * ksvg2/svg/SVGPointList.h:
1915         * ksvg2/svg/SVGPolyElement.cpp:
1916         * ksvg2/svg/SVGPolyElement.h:
1917         * ksvg2/svg/SVGPolygonElement.cpp:
1918         * ksvg2/svg/SVGPolygonElement.h:
1919         * ksvg2/svg/SVGPolylineElement.cpp:
1920         * ksvg2/svg/SVGPolylineElement.h:
1921         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
1922         * ksvg2/svg/SVGPreserveAspectRatio.h:
1923         * ksvg2/svg/SVGRadialGradientElement.cpp:
1924         * ksvg2/svg/SVGRadialGradientElement.h:
1925         * ksvg2/svg/SVGRect.cpp:
1926         * ksvg2/svg/SVGRect.h:
1927         * ksvg2/svg/SVGRectElement.cpp:
1928         * ksvg2/svg/SVGRectElement.h:
1929         * ksvg2/svg/SVGSVGElement.cpp:
1930         * ksvg2/svg/SVGSVGElement.h:
1931         * ksvg2/svg/SVGScriptElement.cpp:
1932         * ksvg2/svg/SVGScriptElement.h:
1933         * ksvg2/svg/SVGSetElement.cpp:
1934         * ksvg2/svg/SVGSetElement.h:
1935         * ksvg2/svg/SVGStopElement.cpp:
1936         * ksvg2/svg/SVGStopElement.h:
1937         * ksvg2/svg/SVGStringList.cpp:
1938         * ksvg2/svg/SVGStringList.h:
1939         * ksvg2/svg/SVGStylable.cpp:
1940         * ksvg2/svg/SVGStylable.h:
1941         * ksvg2/svg/SVGStyleElement.cpp:
1942         * ksvg2/svg/SVGStyleElement.h:
1943         * ksvg2/svg/SVGStyledElement.cpp:
1944         * ksvg2/svg/SVGStyledElement.h:
1945         * ksvg2/svg/SVGStyledLocatableElement.cpp:
1946         * ksvg2/svg/SVGStyledLocatableElement.h:
1947         * ksvg2/svg/SVGStyledTransformableElement.cpp:
1948         * ksvg2/svg/SVGStyledTransformableElement.h:
1949         * ksvg2/svg/SVGSwitchElement.cpp:
1950         * ksvg2/svg/SVGSwitchElement.h:
1951         * ksvg2/svg/SVGSymbolElement.cpp:
1952         * ksvg2/svg/SVGSymbolElement.h:
1953         * ksvg2/svg/SVGTRefElement.cpp:
1954         * ksvg2/svg/SVGTRefElement.h:
1955         * ksvg2/svg/SVGTSpanElement.cpp:
1956         * ksvg2/svg/SVGTSpanElement.h:
1957         * ksvg2/svg/SVGTests.cpp:
1958         * ksvg2/svg/SVGTests.h:
1959         * ksvg2/svg/SVGTextContentElement.cpp:
1960         * ksvg2/svg/SVGTextContentElement.h:
1961         * ksvg2/svg/SVGTextElement.cpp:
1962         * ksvg2/svg/SVGTextElement.h:
1963         * ksvg2/svg/SVGTextPositioningElement.cpp:
1964         * ksvg2/svg/SVGTextPositioningElement.h:
1965         * ksvg2/svg/SVGTitleElement.cpp:
1966         * ksvg2/svg/SVGTitleElement.h:
1967         * ksvg2/svg/SVGTransform.cpp:
1968         * ksvg2/svg/SVGTransform.h:
1969         * ksvg2/svg/SVGTransformList.cpp:
1970         * ksvg2/svg/SVGTransformList.h:
1971         * ksvg2/svg/SVGTransformable.cpp:
1972         * ksvg2/svg/SVGTransformable.h:
1973         * ksvg2/svg/SVGURIReference.cpp:
1974         * ksvg2/svg/SVGURIReference.h:
1975         * ksvg2/svg/SVGUseElement.cpp:
1976         * ksvg2/svg/SVGUseElement.h:
1977         * ksvg2/svg/SVGViewElement.cpp:
1978         * ksvg2/svg/SVGViewElement.h:
1979         * ksvg2/svg/SVGZoomAndPan.cpp:
1980         * ksvg2/svg/SVGZoomAndPan.h:
1981         * ksvg2/svg/svgpathparser.cpp:
1982         * ksvg2/svg/svgpathparser.h:
1983         * page/DOMWindow.idl:
1984         * page/Frame.cpp:
1985         (WebCore::Frame::Frame):
1986         (WebCore::Frame::begin):
1987         (WebCore::Frame::pauseTimeouts):
1988         (WebCore::Frame::resumeTimeouts):
1989         * platform/GraphicsContext.h:
1990         * platform/cg/GraphicsContextCG.cpp:
1991         * rendering/RenderLayer.cpp:
1992         (WebCore::RenderLayer::isTransparent):
1993         * rendering/RenderObject.cpp:
1994         (WebCore::RenderObject::containingBlock):
1995         * rendering/RenderObject.h:
1996         * rendering/RenderStyle.cpp:
1997         (WebCore::RenderStyle::RenderStyle):
1998         (WebCore::RenderStyle::inheritFrom):
1999         (WebCore::RenderStyle::operator==):
2000         (WebCore::RenderStyle::inheritedNotEqual):
2001         (WebCore::RenderStyle::diff):
2002         * rendering/RenderStyle.h:
2003         * rendering/RenderTreeAsText.cpp:
2004         (WebCore::write):
2005         (WebCore::externalRepresentation):
2006         * xpath/XPathEvaluator.cpp:
2007         * xpath/XPathEvaluator.h:
2008         * xpath/XPathExpression.cpp:
2009         * xpath/XPathExpression.h:
2010         * xpath/XPathNSResolver.cpp:
2011         * xpath/XPathNSResolver.h:
2012         * xpath/XPathNamespace.cpp:
2013         * xpath/XPathNamespace.h:
2014         * xpath/XPathResult.cpp:
2015         * xpath/XPathResult.h:
2016         * xpath/impl/XPathExpressionNode.cpp:
2017         * xpath/impl/XPathExpressionNode.h:
2018         * xpath/impl/XPathFunctions.cpp:
2019         * xpath/impl/XPathFunctions.h:
2020         * xpath/impl/XPathGrammar.y:
2021         * xpath/impl/XPathParser.cpp:
2022         * xpath/impl/XPathParser.h:
2023         * xpath/impl/XPathPath.cpp:
2024         * xpath/impl/XPathPath.h:
2025         * xpath/impl/XPathPredicate.cpp:
2026         * xpath/impl/XPathPredicate.h:
2027         * xpath/impl/XPathStep.cpp:
2028         * xpath/impl/XPathStep.h:
2029         * xpath/impl/XPathUtil.cpp:
2030         * xpath/impl/XPathUtil.h:
2031         * xpath/impl/XPathValue.cpp:
2032         * xpath/impl/XPathValue.h:
2033         * xpath/impl/XPathVariableReference.cpp:
2034         * xpath/impl/XPathVariableReference.h:
2035
2036         Change all #if SVG_SUPPORT to #ifdef SVG_SUPPORT and
2037         #if XPATH_SUPPORT to #ifdef XPATH_SUPPORT
2038         (except for one #if !SVG_SUPPORT to a #ifndef SVG_SUPPORT
2039         in RenderTreeAsText.cpp)
2040
2041 2006-08-08  Rob Buis  <buis@kde.org>
2042
2043         Reviewed by Darin.
2044
2045         http://bugzilla.opendarwin.org/show_bug.cgi?id=10230
2046         SVGDOMImplementation should die (and be rolled into DOMImplementation)
2047
2048         Delete SVGDOMImplementation and references to it. The
2049         svg specific functionality is now in DOMImplementation.
2050
2051         * WebCore.xcodeproj/project.pbxproj:
2052         * dom/DOMImplementation.cpp:
2053         (WebCore::svgFeatureSet):
2054         (WebCore::DOMImplementation::hasFeature):
2055         (WebCore::DOMImplementation::createDocument):
2056         (WebCore::DOMImplementation::createSVGDocument):
2057         * dom/DOMImplementation.h:
2058         * ksvg2/bindings/idl/svg/SVGDOMImplementation.idl: Removed.
2059         * ksvg2/misc/KSVGTimeScheduler.cpp:
2060         * ksvg2/svg/SVGColor.cpp:
2061         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2062         * ksvg2/svg/SVGDocument.cpp:
2063         (WebCore::SVGDocument::SVGDocument):
2064         * ksvg2/svg/SVGDocument.h:
2065         * ksvg2/svg/SVGElement.cpp:
2066         (WebCore::SVGElement::isSupported):
2067         * ksvg2/svg/SVGFEBlendElement.cpp:
2068         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2069         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2070         * ksvg2/svg/SVGFECompositeElement.cpp:
2071         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2072         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2073         * ksvg2/svg/SVGFEFloodElement.cpp:
2074         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2075         * ksvg2/svg/SVGFELightElement.cpp:
2076         * ksvg2/svg/SVGFEMergeElement.cpp:
2077         * ksvg2/svg/SVGFEOffsetElement.cpp:
2078         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
2079         * ksvg2/svg/SVGFETileElement.cpp:
2080         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2081         * ksvg2/svg/SVGGradientElement.cpp:
2082         * ksvg2/svg/SVGPatternElement.cpp:
2083         * ksvg2/svg/SVGPolyElement.cpp:
2084         * ksvg2/svg/SVGStopElement.cpp:
2085         * ksvg2/svg/SVGStyledElement.cpp:
2086         * ksvg2/svg/SVGStyledTransformableElement.cpp:
2087         * ksvg2/svg/SVGTests.cpp:
2088         (WebCore::SVGTests::isValid):
2089         * ksvg2/svg/SVGTransformable.cpp:
2090         * page/Frame.cpp:
2091         (WebCore::Frame::begin):
2092
2093 2006-08-07  Brady Eidson  <beidson@apple.com>
2094
2095         Reviewed by Anders and John
2096
2097         Icons can now refresh when new data is sent from WebKit, both on disk and in memory
2098
2099         * bridge/mac/WebCoreIconDatabaseBridge.h:
2100         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2101         (WebCore::IconDatabase::loadIconFromURL):  Allows WebCore/Kit to kick off a load
2102         outside of any greater context
2103         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
2104         (-[WebCoreIconDatabaseBridge isIconExpiredForPageURL:]): Allows WebKit
2105         to get whether or not an icon has expired
2106
2107         * loader/icon/IconDatabase.cpp:
2108         (WebCore::IconDatabase::recreateDatabase): Changed database schema slightly
2109         (WebCore::IconDatabase::createPrivateTables): Changed database schema slightly
2110         (WebCore::IconDatabase::iconForPageURL): 
2111         (WebCore::IconDatabase::isIconExpiredForIconURL): Get if an icon has expired
2112         (WebCore::IconDatabase::isIconExpiredForPageURL): Get if an icon has expired
2113         (WebCore::IconDatabase::setIconDataForIconURL): Force a refresh of the in memory
2114         image when new icon data is loaded
2115         (WebCore::IconDatabase::setIconURLForPageURL): added a check for null iconID
2116
2117         * loader/icon/IconDatabase.h: added/changed some methods
2118         * loader/icon/SiteIcon.cpp:
2119         (SiteIcon::getImage): simplified/removed debugging code
2120         (SiteIcon::manuallySetImageData): allow the image data to be changed when new icon
2121         data is loaded
2122
2123 2006-08-05  Darin Adler  <darin@apple.com>
2124
2125         Reviewed by Eric Seidel.
2126
2127         - fix a storage leak
2128
2129         * rendering/RenderView.cpp: (WebCore::RenderView::setSelection):
2130         Delete the values if we are going to exit without using the maps.
2131         Otherwise all the values leak.
2132
2133 2006-08-05  Darin Adler  <darin@apple.com>
2134
2135         Reviewed by Hyatt.
2136
2137         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10213
2138           REGRESSION: Crash in WebCore::RenderLayer::isTransparent involving <iframe> and <select>
2139
2140         Test: fast/frames/iframe-option-crash.xhtml
2141
2142         * rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
2143         Check for a nil renderer.
2144
2145 2006-08-04  David Hyatt  <hyatt@apple.com>
2146
2147         Fix for Radar bug #4644045, regression where dragging selection no longer
2148         works for floats contained inside layers.  I added an optimization to
2149         refine dirty rect checking for layers, and it incorrectly excluded floats
2150         from the paint bounds since PaintPhaseSelection was not considered when
2151         analyzing the floatRect().
2152
2153         Reviewed by beth
2154
2155         * rendering/RenderBlock.cpp:
2156         (WebCore::RenderBlock::paint):
2157
2158 2006-08-04  David Hyatt  <hyatt@apple.com>
2159
2160         Fix remove() so that it is equivalent to calling removeChild on the
2161         parent.  This involved moving three operations that remove did.
2162
2163         (1) Move the accessibility object cache removal into the destroy methods,
2164         since this really should just happen when a render object is going away.
2165
2166         (2) removeFromObjectLists shifted into removeChild, which means it will
2167         now be called more often (this is a correct change).  Note that there is
2168         also now a new guard on removeFromObjectLists so that it won't do any
2169         work unless the document is not being destroyed.
2170
2171         (3) The big one.  deleteLineBoxWrapper was not getting called to clean up
2172         the line box tree.  This moved right into RenderContainer's removeChildNode so
2173         that it is now done even in the lowest level RenderContainer removal primitive.
2174
2175         Reviewed by beth
2176
2177         * rendering/RenderContainer.cpp:
2178         (WebCore::RenderContainer::removeChildNode):
2179         (WebCore::RenderContainer::removeChild):
2180         * rendering/RenderObject.cpp:
2181         (WebCore::RenderObject::removeFromObjectLists):
2182         (WebCore::RenderObject::destroy):
2183         * rendering/RenderObject.h:
2184         (WebCore::RenderObject::remove):
2185         * rendering/RenderWidget.cpp:
2186         (WebCore::RenderWidget::destroy):
2187
2188 2006-08-04  David Hyatt  <hyatt@apple.com>
2189
2190         Back out the fix for list marker crashes.  The actual bug here is that
2191         there is a confusing mismatch between remove() and removeChild() in the
2192         render tree.  remove() does a little bit of extra work that removeChild
2193         should be doing instead (so that remove() can just be a shorthand for
2194         removeChild).
2195
2196         This conservative fix does not solve the remove/removeChild mismatch
2197         but instead just changes the list marker updating code to use remove
2198         instead.
2199
2200         Reviewed by beth
2201
2202         Test Case: fast/lists/dynamic-marker-crash.html
2203
2204         * rendering/ListMarkerBox.cpp:
2205         * rendering/ListMarkerBox.h:
2206         * rendering/RenderListItem.cpp:
2207         (WebCore::RenderListItem::updateMarkerLocation):
2208
2209 2006-08-04  Sam Weinig  <sam.weinig@gmail.com>
2210
2211         Reviewed by Darin.
2212
2213         - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
2214           Make WebCore (and friends) compile with -Wshorten-64-to-32
2215
2216           * Adds -Wshorten-64-to-32 flag to Xcode project.
2217           * Adds 'f' to float literals where expecting a float.
2218           * Use cosf() instead of cos() when assigning to a float.
2219
2220         * WebCore.xcodeproj/project.pbxproj:
2221         * kcanvas/device/quartz/filters/WKDiffuseLightingFilter.m:
2222         (+[WKDiffuseLightingFilter initialize]):
2223         * kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m:
2224         (-[WKDiscreteTransferFilter outputImage]):
2225         * kcanvas/device/quartz/filters/WKDisplacementMapFilter.m:
2226         (+[WKDisplacementMapFilter initialize]):
2227         * kcanvas/device/quartz/filters/WKSpecularLightingFilter.m:
2228         (+[WKSpecularLightingFilter initialize]):
2229         * kcanvas/device/quartz/filters/WKSpotLightFilter.m:
2230         (-[WKSpotLightFilter outputImage]):
2231         * kcanvas/device/quartz/filters/WKTableTransferFilter.m:
2232         (-[WKTableTransferFilter outputImage]):
2233
2234 2006-08-03  David Hyatt  <hyatt@apple.com>
2235
2236         Fix for bug 10229, don't bother trying to clear when no floats are
2237         present.  I suspect there's still a bug in the math that follows, but
2238         this fix is safer in that it just does the obvious thing (and doesn't
2239         compute any clearance if no floats are even around).
2240
2241         Reviewed by maciej
2242
2243         * ChangeLog:
2244         * rendering/RenderBlock.cpp:
2245         (WebCore::RenderBlock::getClearDelta):
2246
2247 2006-08-03  Justin Garcia  <justin.garcia@apple.com>
2248
2249         Reviewed by harrison
2250         
2251         <rdar://problem/4641033/4515463/4052426/4046570/4053718/4053724/4060115/4062858>
2252         Copy/Paste fidelity was bad.
2253
2254         * editing/ApplyStyleCommand.cpp:
2255         (WebCore::ApplyStyleCommand::applyInlineStyle):
2256         * editing/markup.cpp:
2257         (WebCore::startMarkup): We were not adding non-inheritable styles
2258         to the markup for an element unless they were in the elements inline
2259         style declaration.
2260
2261 2006-08-03  Sam Weinig  <sam.weinig@gmail.com>
2262
2263         Reviewed by Darin.
2264
2265         - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
2266           Make WebCore compile with -Wundef
2267
2268           * Adds -Wundef flag to Xcode project
2269           * Converts #ifs to #ifdef and #ifndefs where needed.
2270           * Replaces #ifdef WIN32 with #if PLATFORM(WIN_OS) or PLATFORM(WIN)
2271             (and in one instance in config.h with #if !COMPILER(MSVC))
2272           * Added #define YYMAXDEPTH 10000 in XPathGrammar.y and CSSGrammar.y
2273             to fix a warning from within Bison.
2274           * Cleaned up style a little in surrounding code.
2275
2276         * WebCore.xcodeproj/project.pbxproj:
2277         * bridge/mac/WebCoreAXObject.mm:
2278         (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
2279         * config.h:
2280         * css/CSSGrammar.y:
2281         * css/MediaFeatureNames.cpp:
2282         * css/MediaFeatureNames.h:
2283         * css/cssparser.cpp:
2284         * dom/ContainerNode.cpp:
2285         (WebCore::ContainerNode::setActive):
2286         * dom/Element.cpp:
2287         (WebCore::Element::attach):
2288         * dom/Element.h:
2289         * dom/EventNames.cpp:
2290         * dom/EventNames.h:
2291         * dom/NamedAttrMap.h:
2292         * dom/Position.cpp:
2293         * dom/QualifiedName.cpp:
2294         * dom/QualifiedName.h:
2295         * dom/Range.h:
2296         * dom/XMLTokenizer.cpp:
2297         (WebCore::XMLTokenizer::error):
2298         * html/HTMLTokenizer.cpp:
2299         (WebCore::HTMLTokenizer::scriptHandler):
2300         (WebCore::HTMLTokenizer::scriptExecution):
2301         (WebCore::HTMLTokenizer::parseTag):
2302         (WebCore::HTMLTokenizer::continueProcessing):
2303         (WebCore::HTMLTokenizer::write):
2304         (WebCore::HTMLTokenizer::timerFired):
2305         (WebCore::HTMLTokenizer::notifyFinished):
2306         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
2307         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2308         * ksvg2/css/SVGRenderStyle.h:
2309         * ksvg2/css/SVGRenderStyleDefs.h:
2310         * ksvg2/scripts/make_names.pl:
2311         * loader/CachedResource.h:
2312         * loader/LoaderFunctions.h:
2313         * loader/loader.h:
2314         * page/Frame.cpp:
2315         * page/FrameTree.cpp:
2316         * page/FrameView.cpp:
2317         (WebCore::FrameView::clear):
2318         (WebCore::FrameView::layout):
2319         (WebCore::FrameView::layoutTimerFired):
2320         (WebCore::FrameView::scheduleRelayout):
2321         (WebCore::FrameView::unscheduleRelayout):
2322         * platform/AtomicString.cpp:
2323         * platform/AtomicString.h:
2324         * platform/Cursor.h:
2325         * platform/DeprecatedArray.h:
2326         * platform/DeprecatedString.cpp:
2327         (WebCore::allocateHandle):
2328         (WebCore::initializeHandleNodeBlock):
2329         (WebCore::freeHandle):
2330         * platform/FloatPoint.h:
2331         * platform/FloatRect.h:
2332         * platform/FloatSize.h:
2333         * platform/GraphicsContext.h:
2334         * platform/Image.h:
2335         * platform/IntPoint.h:
2336         * platform/IntRect.h:
2337         (WebCore::IntRect::inflateX):
2338         (WebCore::IntRect::inflateY):
2339         * platform/IntSize.h:
2340         * platform/PlatformKeyboardEvent.h:
2341         * platform/PlatformMouseEvent.h:
2342         * platform/PlatformString.h:
2343         * platform/ResourceLoader.h:
2344         * platform/ResourceLoaderInternal.h:
2345         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2346         * platform/ScrollView.h:
2347         * platform/StaticConstructors.h:
2348         * platform/StreamingTextDecoderICU.cpp:
2349         (WebCore::StreamingTextDecoderICU::convert):
2350         * platform/StringImpl.h:
2351         * platform/Widget.h:
2352         * platform/mac/BlockExceptions.mm:
2353         * platform/mac/ColorMac.mm:
2354         (+[WebCoreControlTintObserver WebCore]):
2355         * platform/mac/FloatPointMac.mm:
2356         * platform/mac/FloatRectMac.mm:
2357         * platform/mac/FloatSizeMac.mm:
2358         * platform/mac/FontMac.mm:
2359         * platform/mac/GraphicsContextMac.mm:
2360         (WebCore::GraphicsContext::drawFocusRing):
2361         * platform/mac/IntPointMac.mm:
2362         * platform/mac/IntRectMac.mm:
2363         * platform/mac/IntSizeMac.mm:
2364         * platform/mac/WebCoreSystemInterface.h:
2365         * rendering/RenderBlock.h:
2366         * rendering/RenderTableCell.h:
2367         * rendering/bidi.cpp:
2368         (WebCore::appendRun):
2369         (WebCore::RenderBlock::layoutInlineChildren):
2370         * xml/XSLTProcessor.cpp:
2371         (WebCore::parseErrorFunc):
2372         * xpath/impl/XPathGrammar.y:
2373
2374 2006-08-03  Adam Roben  <aroben@apple.com>
2375
2376         Reviewed by Maciej and Beth.
2377
2378         Fix use-after-dispose heap corruption bug.
2379
2380         * rendering/ListMarkerBox.cpp:
2381         (WebCore::ListMarkerBox::destroy): Only call removeChild if we're not
2382         destroying the document
2383
2384 2006-08-03  Adam Roben  <aroben@apple.com>
2385
2386         Reviewed by Anders.
2387
2388         - Fixed Windows build.
2389
2390         * platform/Color.cpp:
2391         (WebCore::makeRGBAFromHSLA): Whitespace change
2392         * platform/win/TemporaryLinkStubs.cpp: Add new method stubs
2393         (PlatformScrollBar::PlatformScrollBar):
2394         (PlatformScrollBar::~PlatformScrollBar):
2395         (PlatformScrollBar::width):
2396         (PlatformScrollBar::height):
2397         (PlatformScrollBar::setEnabled):
2398         (PlatformScrollBar::paint):
2399         (PlatformScrollBar::setScrollBarValue):
2400         (PlatformScrollBar::setKnobProportion):
2401         (PlatformScrollBar::setRect):
2402         (ScrollBar::ScrollBar):
2403         (ScrollBar::scroll):
2404         (ScrollBar::setValue):
2405
2406 2006-08-02  Justin Garcia  <justin.garcia@apple.com>
2407
2408         Reviewed by mjs
2409         
2410         <http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
2411         GMail Editor: Change Hilite Color doesn't work
2412
2413         * editing/JSEditor.cpp: Added support for execCommand("HiliteColor", ...).
2414         It's what GMail uses to implement text hiliting.  It's just a synonym for BackColor.
2415         * editing/SelectionController.cpp:
2416         (WebCore::SelectionController::nodeWillBeRemoved): Moved a comment
2417         a more appropriate place.
2418
2419 2006-08-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>
2420
2421         Reviewed by Adele and Darin.
2422
2423         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10177
2424           REGRESSION: Successfully dragging text into a disabled field
2425
2426         Test: fast/forms/textfield-drag-into-disabled.html
2427
2428         * rendering/RenderTextControl.cpp:
2429         (WebCore::RenderTextControl::createDivStyle): Changed to set -webkit-user-modify
2430         to read-only on the inner div if the control is disabled.       
2431         (WebCore::RenderTextControl::updateFromElement): Ditto.
2432
2433 2006-08-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>
2434
2435         Reviewed by Darin.
2436
2437         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10198
2438           REGRESSION: WebKit r15750 crashes while loading anthem.com
2439
2440         Test: fast/overflow/generated-content-crash.html
2441
2442         * rendering/RenderLayer.cpp:
2443         (WebCore::RenderLayer::updateScrollInfoAfterLayout): Added a null check for
2444         the renderer's element. Generated content does not have an element and
2445         therefore does not need to maintain overflow status.
2446
2447 2006-08-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>
2448
2449         Reviewed by Anders.
2450
2451         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10202
2452           REGRESSION: Repro crash when loading an empty image document
2453
2454         Test: fast/tokenizer/image-empty-crash.html
2455
2456         * loader/ImageDocument.cpp:
2457         (WebCore::ImageTokenizer::stopParsing): Added null check for m_imageElement.
2458         (WebCore::ImageTokenizer::finish): Ditto.
2459
2460 2006-08-03  Darin Adler  <darin@apple.com>
2461
2462         Reviewed by Anders.
2463
2464         - clean up "flip"-related code a tiny bit
2465
2466         * platform/Screen.h: Removed redundant parameter names.
2467         * platform/mac/ScreenMac.mm:
2468         (WebCore::flipScreenRect): Changed to call flipScreenPoint so we only have one
2469         copy of the flipping code.
2470         (WebCore::flipScreenPoint): Fixed indentation.
2471
2472         * bridge/mac/WebCoreFrameBridge.mm: (globalPoint): Removed type casts and
2473         simplified a bit.
2474
2475         * platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPositionForEvent):
2476         * platform/mac/WheelEventMac.mm: (WebCore::globalPositionForEvent):
2477         Removed unneeded local variable.
2478
2479 2006-08-02  David Hyatt  <hyatt@apple.com>
2480
2481         Abstract RenderLayer scrollbar creation and destruction so that there
2482         is a clean spot in which to drop in engine scrollbar stuff.
2483
2484         Reviewed by timo
2485
2486         * platform/ScrollBar.h:
2487         (WebCore::ScrollBar::hasPlatformScrollBars):
2488         * rendering/RenderLayer.cpp:
2489         (WebCore::RenderLayer::createScrollbar):
2490         (WebCore::RenderLayer::destroyScrollbar):
2491         (WebCore::RenderLayer::setHasHorizontalScrollbar):
2492         (WebCore::RenderLayer::setHasVerticalScrollbar):
2493         * rendering/RenderLayer.h:
2494
2495 2006-08-02  Mitz Pettel  <opendarwin.org@mitzpettel.com>
2496
2497         Reviewed by Darin.
2498
2499         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3438
2500           incorrect display of transparent 1x1 PNGs
2501
2502         Test: fast/replaced/image-solid-color-with-alpha.html
2503
2504         * platform/mac/ImageMac.mm:
2505         (WebCore::Image::checkForSolidColor): Changed to divide each color component
2506         by the alpha component. You need to do that since the bitmap context has
2507         premultiplied alpha but m_solidColor should be non-premultiplied.
2508
2509 2006-08-02  Adam Roben  <aroben@apple.com>
2510
2511         Reviewed by Brady.
2512
2513         - Remove redundant #include
2514
2515         * loader/loader.cpp:
2516
2517 2006-07-31  Sam Weinig  <sam.weinig@gmail.com>
2518
2519         Reviewed by Darin.
2520
2521         - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=9955
2522         Colors scaled from [0, 1] range to [0, 255] incorrectly
2523         
2524         Fixes scaling issue and fixes Color to follow style guidelines.
2525
2526         * css/cssstyleselector.cpp:
2527         (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
2528         * platform/Color.cpp:
2529         (WebCore::calcHue):
2530         (WebCore::makeRGBAFromHSLA):
2531         (WebCore::Color::Color):
2532         (WebCore::Color::name):
2533         (WebCore::Color::setNamedColor):
2534         (WebCore::Color::light):
2535         (WebCore::Color::dark):
2536         (WebCore::blend):
2537         * platform/Color.h:
2538         (WebCore::Color::Color):
2539         (WebCore::Color::isValid):
2540         (WebCore::Color::red):
2541         (WebCore::Color::green):
2542         (WebCore::Color::blue):
2543         (WebCore::Color::alpha):
2544         (WebCore::Color::rgb):
2545         (WebCore::Color::setRGB):
2546         (WebCore::operator==):
2547         (WebCore::operator!=):
2548         * rendering/RenderObject.cpp:
2549         (WebCore::RenderObject::drawBorder):
2550
2551 2006-07-31  Mitz Pettel  <opendarwin.org@mitzpettel.com>
2552
2553         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10158
2554           REGRESSION: Selection highlight is dark and opaque when solid-color images are used
2555
2556         Reviewed by Darin.
2557
2558         Pixel test: fast/backgrounds/solid-color-context-restore.html
2559
2560         * platform/mac/ImageMac.mm:
2561         (WebCore::Image::draw): Added calls to preserve the graphics context
2562         around the painting of a solid color image.
2563         (WebCore::Image::drawTiled): Ditto.
2564
2565 2006-07-31  Maciej Stachowiak  <mjs@apple.com>
2566
2567         Rubber-stamped by Tim Hatcher.
2568
2569         - renamed TransferJob to ResourceLoader
2570
2571         * Projects/gdk/webcore-gdk.bkl:
2572         * WebCore.vcproj/WebCore/WebCore.vcproj:
2573         * WebCore.xcodeproj/project.pbxproj:
2574         * WebCoreSources.bkl:
2575         * bridge/mac/FrameMac.mm:
2576         * bridge/mac/WebCoreResourceLoaderImp.h:
2577         * bridge/mac/WebCoreResourceLoaderImp.mm:
2578         (-[WebCoreResourceLoaderImp redirectedToURL:]):
2579         (-[WebCoreResourceLoaderImp addData:]):
2580         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
2581         * bridge/win/FrameWin.cpp:
2582         * dom/XMLTokenizer.cpp:
2583         (WebCore::openFunc):
2584         * loader/Cache.cpp:
2585         * loader/LoaderFunctions.h:
2586         * loader/loader.cpp:
2587         (WebCore::Loader::servePendingRequests):
2588         (WebCore::Loader::receivedAllData):
2589         (WebCore::Loader::receivedResponse):
2590         (WebCore::Loader::receivedData):
2591         (WebCore::Loader::cancelRequests):
2592         (WebCore::Loader::jobForRequest):
2593         * loader/loader.h:
2594         * loader/mac/LoaderFunctionsMac.mm:
2595         (WebCore::ServeSynchronousRequest):
2596         * platform/ResourceLoader.cpp: Added.
2597         (WebCore::ResourceLoader::ResourceLoader):
2598         (WebCore::ResourceLoader::isErrorPage):
2599         (WebCore::ResourceLoader::error):
2600         (WebCore::ResourceLoader::setError):
2601         (WebCore::ResourceLoader::queryMetaData):
2602         (WebCore::ResourceLoader::addMetaData):
2603         (WebCore::ResourceLoader::kill):
2604         (WebCore::ResourceLoader::url):
2605         (WebCore::ResourceLoader::postData):
2606         (WebCore::ResourceLoader::method):
2607         (WebCore::ResourceLoader::client):
2608         * platform/ResourceLoader.h: Added.
2609         (WebCore::ResourceLoader::getInternal):
2610         * platform/ResourceLoaderClient.h: Added.
2611         (WebCore::ResourceLoaderClient::~ResourceLoaderClient):
2612         (WebCore::ResourceLoaderClient::receivedRedirect):
2613         (WebCore::ResourceLoaderClient::receivedResponse):
2614         (WebCore::ResourceLoaderClient::receivedData):
2615         (WebCore::ResourceLoaderClient::receivedAllData):
2616         * platform/ResourceLoaderInternal.h: Added.
2617         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2618         * platform/TransferJob.cpp: Removed.
2619         * platform/TransferJob.h: Removed.
2620         * platform/TransferJobClient.h: Removed.
2621         * platform/TransferJobInternal.h: Removed.
2622         * platform/gdk/FrameGdk.cpp:
2623         (WebCore::FrameGdk::openURL):
2624         (WebCore::FrameGdk::urlSelected):
2625         (WebCore::FrameGdk::receivedData):
2626         (WebCore::FrameGdk::receivedAllData):
2627         * platform/gdk/FrameGdk.h:
2628         * platform/gdk/ResourceLoaderCurl.cpp: Added.
2629         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
2630         (WebCore::ResourceLoader::~ResourceLoader):
2631         (WebCore::ResourceLoader::start):
2632         (WebCore::ResourceLoader::cancel):
2633         * platform/gdk/ResourceLoaderManager.cpp: Added.
2634         (WebCore::ResourceLoaderManager::ResourceLoaderManager):
2635         (WebCore::ResourceLoaderManager::get):
2636         (WebCore::ResourceLoaderManager::useSimpleTransfer):
2637         (WebCore::writeCallback):
2638         (WebCore::ResourceLoaderManager::downloadTimerCallback):
2639         (WebCore::ResourceLoaderManager::remove):
2640         (WebCore::ResourceLoaderManager::add):
2641         (WebCore::ResourceLoaderManager::cancel):
2642         * platform/gdk/ResourceLoaderManager.h: Added.
2643         * platform/gdk/TemporaryLinkStubs.cpp:
2644         (WebCore::ServeSynchronousRequest):
2645         (WebCore::ResourceLoader::assembleResponseHeaders):
2646         (WebCore::ResourceLoader::retrieveCharset):
2647         * platform/gdk/TransferJobCurl.cpp: Removed.
2648         * platform/gdk/TransferJobManager.cpp: Removed.
2649         * platform/gdk/TransferJobManager.h: Removed.
2650         * platform/mac/ResourceLoaderMac.mm: Added.
2651         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
2652         (WebCore::ResourceLoader::~ResourceLoader):
2653         (WebCore::ResourceLoader::start):
2654         (WebCore::ResourceLoader::assembleResponseHeaders):
2655         (WebCore::ResourceLoader::retrieveCharset):
2656         (WebCore::ResourceLoader::setLoader):
2657         (WebCore::ResourceLoader::receivedResponse):
2658         (WebCore::ResourceLoader::cancel):
2659         * platform/mac/TransferJobMac.mm: Removed.
2660         * platform/win/ResourceLoaderWin.cpp: Added.
2661         (WebCore::addToOutstandingJobs):
2662         (WebCore::lookupResourceLoader):
2663         (WebCore::ResourceLoaderWndProc):
2664         (WebCore::initializeOffScreenResourceLoaderWindow):
2665         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
2666         (WebCore::ResourceLoader::~ResourceLoader):
2667         (WebCore::ResourceLoader::start):
2668         (WebCore::ResourceLoader::fileLoadTimer):
2669         (WebCore::ResourceLoader::cancel):
2670         * platform/win/ResourceLoaderWin.h: Added.
2671         * platform/win/TemporaryLinkStubs.cpp:
2672         (WebCore::ServeSynchronousRequest):
2673         (WebCore::ResourceLoader::assembleResponseHeaders):
2674         (WebCore::ResourceLoader::retrieveCharset):
2675         * platform/win/TransferJobWin.cpp: Removed.
2676         * platform/win/TransferJobWin.h: Removed.
2677         * xml/XSLTProcessor.cpp:
2678         (WebCore::docLoaderFunc):
2679         * xml/xmlhttprequest.cpp:
2680         (WebCore::XMLHttpRequest::send):
2681         (WebCore::XMLHttpRequest::receivedAllData):
2682         (WebCore::XMLHttpRequest::receivedRedirect):
2683         (WebCore::XMLHttpRequest::receivedData):
2684         * xml/xmlhttprequest.h:
2685
2686 2006-07-31  Darin Adler  <darin@apple.com>
2687
2688         Reviewed by Hyatt.
2689
2690         - removed obsolete cell margin hack
2691
2692         * rendering/RenderBox.cpp: (WebCore::RenderBox::calcVerticalMargins):
2693         Set top and bottom margins to 0 for table cells instead of -16384.
2694         No effect on layout (including layout tests).
2695
2696         * css/CSSComputedStyleDeclaration.cpp:
2697         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2698         Added a few comments about differences between this class and the
2699         what the CSS specification says about computed style.
2700
2701 2006-07-31  Mark Rowe  <opendarwin.org@bdash.net.nz>
2702
2703         Reviewed by Maciej.
2704
2705         http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
2706         Bug 9738: Unqualified :hover selector ignored in strict parsing mode
2707
2708         * css/cssstyleselector.cpp:
2709         (WebCore::CSSStyleSelector::checkSelector): Restrict the :hover and :active
2710         exclusion based on onlyHoverActive to quirks mode.
2711
2712 2006-07-31  David Hyatt  <hyatt@apple.com>
2713
2714         Fix for bug 10179, digg.com scrolls slowly.  Improve fixed positioning
2715         and fixed backgrounds so that a count of them is kept on the FrameView.
2716         This allows us to switch slow scrolling on and off as these objects come
2717         and go.
2718
2719         * css/cssstyleselector.cpp:
2720         (WebCore::CSSStyleSelector::adjustRenderStyle):
2721         (WebCore::CSSStyleSelector::applyProperty):
2722         * page/FrameView.cpp:
2723         (WebCore::FrameViewPrivate::reset):
2724         (WebCore::FrameView::layout):
2725         (WebCore::FrameView::useSlowRepaints):
2726         (WebCore::FrameView::setUseSlowRepaints):
2727         (WebCore::FrameView::addSlowRepaintObject):
2728         (WebCore::FrameView::removeSlowRepaintObject):
2729         * page/FrameView.h:
2730         * rendering/RenderBox.cpp:
2731         (WebCore::RenderBox::paintBackgroundExtended):
2732         * rendering/RenderObject.cpp:
2733         (WebCore::RenderObject::setStyle):
2734         * rendering/RenderView.cpp:
2735         (WebCore::RenderView::paintBoxDecorations):
2736
2737 2006-07-31  David Hyatt  <hyatt@apple.com>
2738
2739         Begin disentangling of scrollbar logic in preparation for engine-implemented
2740         scrollbars.  Split ScrollBar into two classes, an abstract base (still named
2741         ScrollBar) and a new PlatformScrollBar subclass.  This subclass is used only
2742         by platforms that want to continue to use a platform scrollbar (rather than
2743         the engine one).
2744
2745         Reviewed by darin
2746
2747         * WebCore.xcodeproj/project.pbxproj:
2748         * html/HTMLCanvasElement.h:
2749         * page/Frame.cpp:
2750         * platform/PlatformScrollBar.h: Added.
2751         (WebCore::PlatformScrollBar::isWidget):
2752         * platform/ScrollBar.h:
2753         (WebCore::ScrollBarClient::~ScrollBarClient):
2754         (WebCore::ScrollBar::~ScrollBar):
2755         (WebCore::ScrollBar::orientation):
2756         (WebCore::ScrollBar::value):
2757         (WebCore::ScrollBar::client):
2758         * platform/mac/PlatformScrollBarMac.mm: Added.
2759         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
2760         (-[WebCoreScrollBar detachPlatformScrollBar]):
2761         (-[WebCoreScrollBar scroll:]):
2762         (-[WebCoreScrollBar widget]):
2763         (-[WebCoreScrollBar mouseDown:]):
2764         (WebCore::PlatformScrollBar::PlatformScrollBar):
2765         (WebCore::PlatformScrollBar::~PlatformScrollBar):
2766         (WebCore::PlatformScrollBar::setScrollBarValue):
2767         (WebCore::PlatformScrollBar::setKnobProportion):
2768         (WebCore::PlatformScrollBar::scrollbarHit):
2769         (WebCore::PlatformScrollBar::width):
2770         (WebCore::PlatformScrollBar::height):
2771         (WebCore::PlatformScrollBar::setRect):
2772         (WebCore::PlatformScrollBar::setEnabled):
2773         (WebCore::PlatformScrollBar::paint):
2774         * platform/mac/ScrollBarMac.mm: Removed.
2775         * platform/mac/WebCoreTextArea.mm:
2776         * rendering/RenderBlock.cpp:
2777         (WebCore::RenderBlock::isPointInScrollbar):
2778         * rendering/RenderFormElement.cpp:
2779         * rendering/RenderLayer.cpp:
2780         (WebCore::RenderLayer::horizontalScrollbarWidget):
2781         (WebCore::RenderLayer::verticalScrollbarWidget):
2782         (WebCore::RenderLayer::valueChanged):
2783         (WebCore::RenderLayer::setHasHorizontalScrollbar):
2784         (WebCore::RenderLayer::setHasVerticalScrollbar):
2785         (WebCore::RenderLayer::positionScrollbars):
2786         * rendering/RenderLayer.h:
2787         * rendering/RenderWidget.h:
2788
2789 2006-07-31  Adele Peterson  <adele@apple.com>
2790
2791         Reviewed by John and Anders.
2792
2793         - Fix for <rdar://problem/4380576> onChange does not get called when field changed by return key
2794
2795         Test: fast/forms/onchange-enter-submit.html
2796
2797         Blur (which will fire onChange appropriately) before submitting a form when pressing Enter.
2798         This matches the sequence of events fired in WinIE.
2799
2800         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
2801         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler):
2802
2803 2006-07-31  Geoffrey Garen  <ggaren@apple.com>
2804
2805         Reviewed by Kevin.
2806
2807         Moved string debug function outside of the WebCore namespace so that it's
2808         easier to call in the debugger. I will never doubt Darin again (x100).
2809
2810         * platform/String.cpp:
2811         (string):
2812
2813 2006-07-31  David Hyatt  <hyatt@apple.com>
2814
2815         Partial fix for 5453.  Improve overflow so that when it changes
2816         dynamically from scroll/auto to hidden that we properly hide the
2817         scrollbars.  Also refine the dirty dashboard region updating so that
2818         it only happens if the scrollbars genuinely come and go.
2819
2820         Also eliminate the extra repaint of the entire block.  This should not be
2821         necessary, since the scrollbars repaint themselves already and children
2822         will repaint already if they move.
2823
2824         Reviewed by darin
2825
2826         Adding test case from bug into fast/overflow/dynamic-hidden.html
2827
2828         * rendering/RenderLayer.cpp:
2829         (WebCore::RenderLayer::setHasHorizontalScrollbar):
2830         (WebCore::RenderLayer::setHasVerticalScrollbar):
2831         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
2832
2833 2006-07-31  Graham Dennis  <graham.dennis@gmail.com>
2834
2835         Reviewed by justin
2836         
2837         <http://bugzilla.opendarwin.org/show_bug.cgi?id=9507>
2838         Empty style spans created in applyInlineStyle
2839         
2840         Improves paste fidelity because some of these empty font/style spans had a non-zero
2841         size and were messing up the layout of pasted content:
2842         <rdar://problem/4515463>
2843         REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page   
2844
2845         * editing/ApplyStyleCommand.cpp:
2846         (WebCore::ApplyStyleCommand::applyInlineStyle): Use the adjusted start node instead 
2847         of start.node().  Don't do any application if the endpoints are swapped.  Adjust
2848         endNode if the start node is a descendant of it, so that the pre-order traversal will
2849         terminate properly.
2850
2851 2006-07-31  Geoffrey Garen  <ggaren@apple.com>
2852
2853         Reviewed by Darin.
2854
2855         * platform/String.cpp:
2856         (WebCore::string): Added a debugging function to create a String from a
2857         const char*.
2858
2859 2006-07-31  Anders Carlsson  <acarlsson@apple.com>
2860
2861         * css/CSSPrimitiveValue.cpp:
2862         Fix windows build.
2863
2864 2006-07-31  Geoffrey Garen  <ggaren@apple.com>
2865
2866         Reinstating my last change. Everything builds now.
2867         
2868 2006-07-31  Geoffrey Garen  <ggaren@apple.com>
2869
2870         Backing out my last change because it causes a build failure in some
2871         configurations. This seems to be the cleanest way to get svn to cooperate.
2872
2873 2006-07-31  Geoffrey Garen  <ggaren@apple.com>
2874
2875         Reviewed by Maciej.
2876
2877         Moved files around to make WebCore's structure clearer
2878         and easier to explain.
2879
2880         DerivedSources/JS* -> bindings/js/DerivedSources/ (so JS* files
2881         show up when you search inside bindings/js/, but are marked, at
2882         the same time, as files that you should not edit manually)
2883
2884         WebCore+SVG/DOMList.h -> ksvg2/svg/ (only files inside ksvg2/svg/
2885         use DOMList.h)
2886
2887         icon -> loader/icon
2888
2889         I tested that everything still builds.
2890
2891 2006-07-30  Darin Adler  <darin@apple.com>
2892
2893         Reviewed by Tim Hatcher.
2894
2895         - some improvements for the benefit of the style pane of the inspector
2896
2897         * css/CSSComputedStyleDeclaration.cpp: Removed background-position
2898         and border-spacing from the list of properties that show up in
2899         computed style, because of background-position-x, background-position-y,
2900         -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.
2901         (WebCore::valueForLength): Added handling for undefinedLength, intrinsic,
2902         and min-intrinsic.
2903         (WebCore::primitiveValueFromLength): Removed code that would add a
2904         space to the string for no good reason.
2905         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a
2906         special case for a line clamp of -1, which should come back as "none"
2907         rather than an actual "-1".
2908         (WebCore::CSSComputedStyleDeclaration::length): Return 0 if the
2909         declaration has no corresponding node or no renderer.
2910         (WebCore::CSSComputedStyleDeclaration::item): Check against length()
2911         so that the two stay consistent rather than using a constant.
2912
2913         * css/CSSPrimitiveValue.cpp:
2914         (WebCore::isCSSTokenizerIdentifier): Added.
2915         (WebCore::isCSSTokenizerURL): Added.
2916         (WebCore::quoteString): Added.
2917         (WebCore::quoteStringIfNeeded): Changed to quote strings in many more
2918         cases -- any cases where they would not parse in the CSS parser otherwise.
2919         The main case this affects is font names with spaces in them.
2920         (WebCore::quoteURLIfNeeded): Added.
2921         (WebCore::CSSPrimitiveValue::cssText): Use quoteURLIfNeeded in the case
2922         where we're making the text form of a URI.
2923
2924         * css/tokenizer.flex: Whitespace tweaks to line things up better.
2925
2926 2006-07-30  Eric Seidel  <eric@eseidel.com>
2927
2928         Reviewed by gramps!
2929
2930         Remove some unused SVG code.
2931
2932         * ksvg2/ecma/Ecma.cpp: Removed.
2933         * ksvg2/ecma/Ecma.h: Removed.
2934         * ksvg2/ecma/GlobalObject.cpp: remove a couple dead functions.
2935         * ksvg2/ecma/GlobalObject.h: add a comment about this dead code.
2936         * ksvg2/ecma/SVGLookup.h: Removed.
2937
2938 2006-07-29  Darin Adler  <darin@apple.com>
2939
2940         - Removed tabs from these source files that still had them.
2941           We don't use them; that way source files look fine in editors
2942           that have tabs set to 8 spaces or to 4 spaces.
2943         - Removed allow-tabs Subversion property from the files too.
2944
2945         * bindings/objc/WebScriptObject.h:
2946         * bindings/objc/WebScriptObject.mm:
2947         * platform/FontData.cpp:
2948
2949 2006-07-29  Sam Weinig  <sam.weinig@gmail.com>
2950
2951         Reviewed by Darin.
2952
2953         - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10080
2954           Adopt pedantic changes from the Unity project to improve 
2955           cross-compiler compatibility
2956
2957           Changes include:
2958           * Removing trailing semicolon from namespace braces.
2959           * Removing trailing comma from last enum declaration.
2960           * Updating to match style guidelines.
2961           * Adding missing newline to the end of the file.
2962           * Turning on gcc warning for missing newline at the end of a source file
2963             (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
2964           * Alphabetical sorting of Xcode source list files.
2965           * Use abs() function from <math.h> instead of ABS() macro.
2966           * Use C-style comments instead of C++ comments in files that might
2967             be included by either C or C++ files.
2968           * Use -numeric_limits<double>::infinity() instead of -HUGE_VAL.
2969
2970         * WebCore+SVG/DOMList.h:
2971         * WebCore.xcodeproj/project.pbxproj:
2972         * WebCorePrefix.h:
2973         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2974         * bindings/js/JSXSLTProcessor.h:
2975         * bindings/js/kjs_domnode.h:
2976         (KJS::DOMNode::):
2977         * bindings/objc/DOMCSS.h:
2978         (-[DOMCSSValue enum]):
2979         * bindings/objc/DOMCore.h:
2980         (-[DOMImplementation createDocument:::]):
2981         * bindings/objc/DOMEvents.h:
2982         (-[DOMOverflowEvent enum]):
2983         * bindings/objc/DOMRange.h:
2984         * bindings/objc/DOMTraversal.h:
2985         * bindings/objc/DOMXPath.h:
2986         (-[DOMXPathNSResolver lookupNamespaceURI:]):
2987         * bridge/mac/WebCoreFrameBridge.h:
2988         * bridge/mac/WebCoreKeyboardAccess.h:
2989         * css/makeprop:
2990         * css/makevalues:
2991         * dom/ChildNodeList.h:
2992         * dom/DocPtr.h:
2993         * dom/Document.h:
2994         (WebCore::Document::):
2995         * dom/DocumentMarker.h:
2996         (WebCore::DocumentMarker::):
2997         (WebCore::DocumentMarker::operator==):
2998         (WebCore::DocumentMarker::operator!=):
2999         * dom/EventTargetNode.h:
3000         * dom/KeyboardEvent.h:
3001         (WebCore::KeyboardEvent::):
3002         * dom/NameNodeList.h:
3003         (WebCore::NameNodeList::rootNodeChildrenChanged):
3004         * dom/QualifiedName.cpp:
3005         * editing/TypingCommand.h:
3006         (WebCore::TypingCommand::):
3007         * editing/UnlinkCommand.h:
3008         (WebCore::UnlinkCommand::editingAction):
3009         * html/FormDataList.h:
3010         (WebCore::FormDataListItem::FormDataListItem):
3011         (WebCore::FormDataList::appendData):
3012         * html/HTMLBlockquoteElement.h:
3013         * html/HTMLDivElement.h:
3014         * html/HTMLFormElement.h:
3015         * html/HTMLHRElement.h:
3016         * html/HTMLHeadingElement.h:
3017         * html/HTMLMarqueeElement.h:
3018         * html/HTMLParagraphElement.h:
3019         * html/HTMLPlugInElement.h:
3020         * html/HTMLPreElement.h:
3021         * html/HTMLTokenizer.h:
3022         (WebCore::HTMLTokenizer::State::):
3023         * icon/IconDatabase.cpp:
3024         * icon/SQLStatement.cpp:
3025         * kcanvas/KCanvasFilters.h:
3026         (WebCore::):
3027         (WebCore::KCanvasPoint3F::KCanvasPoint3F):
3028         (WebCore::KCanvasFilter::KCanvasFilter):
3029         (WebCore::KCanvasFilter::~KCanvasFilter):
3030         (WebCore::KCanvasFilterEffect::~KCanvasFilterEffect):
3031         (WebCore::KCComponentTransferFunction::KCComponentTransferFunction):
3032         (WebCore::KCanvasFEConvolveMatrix::KCanvasFEConvolveMatrix):
3033         (WebCore::KCLightSource::KCLightSource):
3034         (WebCore::KCDistantLightSource::KCDistantLightSource):
3035         (WebCore::KCPointLightSource::KCPointLightSource):
3036         (WebCore::KCSpotLightSource::KCSpotLightSource):
3037         (WebCore::KCanvasFEDiffuseLighting::KCanvasFEDiffuseLighting):
3038         (WebCore::KCanvasFEDisplacementMap::KCanvasFEDisplacementMap):
3039         (WebCore::KCanvasFEImage::KCanvasFEImage):
3040         (WebCore::KCanvasFESpecularLighting::KCanvasFESpecularLighting):
3041         * kcanvas/RenderSVGImage.h:
3042         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
3043         * ksvg2/css/SVGRenderStyle.h:
3044         (WebCore::SVGRenderStyle::InheritedFlags::):
3045         (WebCore::SVGRenderStyle::NonInheritedFlags::):
3046         * ksvg2/css/SVGRenderStyleDefs.h:
3047         (WebCore::):
3048         * ksvg2/events/SVGZoomEvent.h:
3049         * ksvg2/ksvg.h:
3050         (WebCore::):
3051         * ksvg2/misc/KCanvasRenderingStyle.h:
3052         * ksvg2/misc/SVGImageLoader.h:
3053         * ksvg2/scripts/make_names.pl:
3054         * ksvg2/svg/SVGAElement.h:
3055         * ksvg2/svg/SVGAngle.h:
3056         * ksvg2/svg/SVGAnimateColorElement.h:
3057         * ksvg2/svg/SVGAnimateElement.h:
3058         * ksvg2/svg/SVGAnimateTransformElement.h:
3059         * ksvg2/svg/SVGAnimatedAngle.h:
3060         * ksvg2/svg/SVGAnimatedBoolean.h:
3061         * ksvg2/svg/SVGAnimatedColor.h:
3062         * ksvg2/svg/SVGAnimatedEnumeration.h:
3063         * ksvg2/svg/SVGAnimatedInteger.h:
3064         * ksvg2/svg/SVGAnimatedLength.h:
3065         * ksvg2/svg/SVGAnimatedLengthList.h:
3066         * ksvg2/svg/SVGAnimatedNumber.h:
3067         * ksvg2/svg/SVGAnimatedNumberList.h:
3068         * ksvg2/svg/SVGAnimatedPathData.h:
3069         * ksvg2/svg/SVGAnimatedPoints.h:
3070         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.h:
3071         * ksvg2/svg/SVGAnimatedRect.h:
3072         * ksvg2/svg/SVGAnimatedString.h:
3073         * ksvg2/svg/SVGAnimatedTemplate.h:
3074         * ksvg2/svg/SVGAnimatedTransformList.h:
3075         * ksvg2/svg/SVGAnimationElement.cpp:
3076         (SVGAnimationElement::calculateCurrentValueItem):
3077         (SVGAnimationElement::calculateRelativeTimePercentage):
3078         * ksvg2/svg/SVGAnimationElement.h:
3079         (WebCore::):
3080         * ksvg2/svg/SVGCircleElement.h:
3081         * ksvg2/svg/SVGClipPathElement.h:
3082         * ksvg2/svg/SVGColor.h:
3083         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
3084         * ksvg2/svg/SVGCursorElement.h:
3085         * ksvg2/svg/SVGDOMImplementation.h:
3086         * ksvg2/svg/SVGDefsElement.h:
3087         * ksvg2/svg/SVGDescElement.h:
3088         * ksvg2/svg/SVGDocument.h:
3089         * ksvg2/svg/SVGElement.h:
3090         (WebCore::SVGElement::rendererIsNeeded):
3091         (WebCore::svg_dynamic_cast):
3092         * ksvg2/svg/SVGElementInstance.h:
3093         * ksvg2/svg/SVGElementInstanceList.h:
3094         * ksvg2/svg/SVGEllipseElement.h:
3095         * ksvg2/svg/SVGExternalResourcesRequired.h:
3096         * ksvg2/svg/SVGFEBlendElement.h:
3097         * ksvg2/svg/SVGFEColorMatrixElement.h:
3098         * ksvg2/svg/SVGFEComponentTransferElement.h:
3099         * ksvg2/svg/SVGFECompositeElement.h:
3100         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
3101         * ksvg2/svg/SVGFEDisplacementMapElement.h:
3102         * ksvg2/svg/SVGFEDistantLightElement.h:
3103         * ksvg2/svg/SVGFEFloodElement.h:
3104         * ksvg2/svg/SVGFEFuncAElement.h:
3105         * ksvg2/svg/SVGFEFuncBElement.h:
3106         * ksvg2/svg/SVGFEFuncGElement.h:
3107         * ksvg2/svg/SVGFEFuncRElement.h:
3108         * ksvg2/svg/SVGFEGaussianBlurElement.h:
3109         * ksvg2/svg/SVGFEImageElement.h:
3110         * ksvg2/svg/SVGFELightElement.h:
3111         * ksvg2/svg/SVGFEMergeElement.h:
3112         * ksvg2/svg/SVGFEMergeNodeElement.h:
3113         * ksvg2/svg/SVGFEOffsetElement.h:
3114         * ksvg2/svg/SVGFEPointLightElement.h:
3115         * ksvg2/svg/SVGFESpecularLightingElement.h:
3116         * ksvg2/svg/SVGFESpotLightElement.h:
3117         * ksvg2/svg/SVGFETileElement.h:
3118         * ksvg2/svg/SVGFETurbulenceElement.h:
3119         * ksvg2/svg/SVGFilterElement.h:
3120         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
3121         * ksvg2/svg/SVGFitToViewBox.h:
3122         * ksvg2/svg/SVGForeignObjectElement.cpp:
3123         * ksvg2/svg/SVGForeignObjectElement.h:
3124         * ksvg2/svg/SVGGElement.h:
3125         * ksvg2/svg/SVGGradientElement.h:
3126         * ksvg2/svg/SVGHelper.h:
3127         (WebCore::):
3128         * ksvg2/svg/SVGImageElement.h:
3129         * ksvg2/svg/SVGLangSpace.h:
3130         * ksvg2/svg/SVGLength.h:
3131         * ksvg2/svg/SVGLengthList.h:
3132         * ksvg2/svg/SVGLineElement.h:
3133         * ksvg2/svg/SVGLinearGradientElement.h:
3134         * ksvg2/svg/SVGList.h:
3135         * ksvg2/svg/SVGLocatable.h:
3136         * ksvg2/svg/SVGMarkerElement.h:
3137         * ksvg2/svg/SVGMaskElement.h:
3138         * ksvg2/svg/SVGMatrix.h:
3139         * ksvg2/svg/SVGNumber.h:
3140         * ksvg2/svg/SVGNumberList.h:
3141         * ksvg2/svg/SVGPaint.h:
3142         * ksvg2/svg/SVGPathElement.h:
3143         * ksvg2/svg/SVGPathSeg.h:
3144         * ksvg2/svg/SVGPathSegArc.h:
3145         * ksvg2/svg/SVGPathSegClosePath.h:
3146         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
3147         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
3148         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
3149         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
3150         * ksvg2/svg/SVGPathSegLineto.h:
3151         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
3152         * ksvg2/svg/SVGPathSegLinetoVertical.h:
3153         * ksvg2/svg/SVGPathSegList.h:
3154         * ksvg2/svg/SVGPathSegMoveto.h:
3155         * ksvg2/svg/SVGPatternElement.h:
3156         * ksvg2/svg/SVGPoint.h:
3157         * ksvg2/svg/SVGPointList.h:
3158         * ksvg2/svg/SVGPolyElement.h:
3159         * ksvg2/svg/SVGPolygonElement.h:
3160         * ksvg2/svg/SVGPolylineElement.h:
3161         * ksvg2/svg/SVGPreserveAspectRatio.h:
3162         * ksvg2/svg/SVGRadialGradientElement.h:
3163         * ksvg2/svg/SVGRect.h:
3164         * ksvg2/svg/SVGRectElement.h:
3165         * ksvg2/svg/SVGSVGElement.h:
3166         * ksvg2/svg/SVGScriptElement.h:
3167         * ksvg2/svg/SVGSetElement.h:
3168         * ksvg2/svg/SVGStopElement.h:
3169         * ksvg2/svg/SVGStringList.h:
3170         * ksvg2/svg/SVGStylable.h:
3171         * ksvg2/svg/SVGStyleElement.h:
3172         * ksvg2/svg/SVGStyledElement.h:
3173         (WebCore::SVGStyledElement::rendererIsNeeded):
3174         (WebCore::SVGStyledElement::canvasResource):
3175         * ksvg2/svg/SVGStyledLocatableElement.h:
3176         * ksvg2/svg/SVGStyledTransformableElement.h:
3177         * ksvg2/svg/SVGSwitchElement.h:
3178         * ksvg2/svg/SVGSymbolElement.h:
3179         * ksvg2/svg/SVGTRefElement.h:
3180         * ksvg2/svg/SVGTSpanElement.h:
3181         * ksvg2/svg/SVGTests.h:
3182         * ksvg2/svg/SVGTextContentElement.h:
3183         * ksvg2/svg/SVGTextElement.h:
3184         * ksvg2/svg/SVGTextPositioningElement.h:
3185         * ksvg2/svg/SVGTitleElement.h:
3186         * ksvg2/svg/SVGTransform.h:
3187         * ksvg2/svg/SVGTransformList.h:
3188         * ksvg2/svg/SVGTransformable.h:
3189         * ksvg2/svg/SVGURIReference.h:
3190         * ksvg2/svg/SVGUseElement.h:
3191         * ksvg2/svg/SVGViewElement.h:
3192         * ksvg2/svg/SVGZoomAndPan.h:
3193         * ksvg2/svg/svgpathparser.h:
3194         * page/Frame.h:
3195         (WebCore::):
3196         * platform/AffineTransform.h:
3197         * platform/FontCache.cpp:
3198         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
3199         * platform/FontData.cpp:
3200         (WebCore::FontData::FontData):
3201         * platform/FontData.h:
3202         * platform/TextBox.h:
3203         (WebCore::TextBox::):
3204         * platform/Timer.cpp:
3205         (WebCore::TimerBase::heapPop):
3206         * platform/mac/FontCacheMac.mm:
3207         * platform/mac/GlyphMapMac.cpp:
3208         * platform/mac/WebFontCache.mm:
3209         (betterChoice):
3210         * rendering/DeprecatedRenderSelect.cpp:
3211         (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection):
3212         * rendering/EllipsisBox.h:
3213         * rendering/RenderBR.h:
3214         (WebCore::RenderBR::renderName):
3215         (WebCore::RenderBR::width):
3216         * rendering/RenderBlock.h:
3217         (WebCore::):
3218         * rendering/RenderFlexibleBox.h:
3219         * rendering/RenderFlow.h:
3220         (WebCore::RenderFlow::RenderFlow):
3221         * rendering/RenderFrame.cpp:
3222         * rendering/bidi.h:
3223         * rendering/break_lines.cpp:
3224
3225 2006-07-29  Rob Buis  <buis@kde.org>
3226
3227         Reviewed by Geoff.
3228
3229         http://bugzilla.opendarwin.org/show_bug.cgi?id=10151
3230         ghostmap XHTML + SVG fails due to javascript undefined exception
3231
3232         Make sure document.URL works when called from a non-HTML document.
3233
3234         * bindings/js/kjs_html.cpp:
3235         (KJS::JSHTMLDocument::getValueProperty):
3236         * bindings/js/kjs_html.h:
3237         (KJS::JSHTMLDocument::):
3238         * dom/Document.idl:
3239
3240 2006-07-29  Mike Emmel  <mike.emmel@gmail.com>
3241
3242         Reviewed and tweaked by Darin.
3243
3244         - fixes for Linux build
3245           (still might not compile, since Darin tweaked but was unable to test).
3246
3247         * WebCoreSources.bkl: Added some new sources, removed some obsolete ones.
3248         * Projects/gdk/webcore-gdk.bkl: Added RenderPopupMenuGdk.cpp
3249
3250         * html/HTMLPlugInElement.h: Removed incorrect syntax with class name
3251         before ::.
3252
3253         * platform/gdk/FrameGdk.h:
3254         * platform/gdk/FrameGdk.cpp: Updated parameters of constructor. Moved a couple stubs
3255         out of this file.
3256         * platform/gdk/RenderPopupMenuGdk.h: Added.
3257         * platform/gdk/RenderPopupMenuGdk.cpp: Added. Just a file full of empty stubs.
3258         * platform/gdk/RenderThemeGdk.h:
3259         * platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::createPopupMenu): Added.
3260
3261         * platform/gdk/TemporaryLinkStubs.cpp: Add some new stubs.
3262
3263 2006-07-29  Mark Rowe  <opendarwin.org@bdash.net.nz>
3264
3265         Reviewed by Darin.
3266
3267         http://bugzilla.opendarwin.org/show_bug.cgi?id=10022
3268         Bug 10022: REGRESSION: Crash in WebCore::XMLTokenizer::characters
3269
3270         * dom/XMLTokenizer.cpp:
3271         (WebCore::XMLTokenizer::resumeParsing): If the write() call resulted in new callbacks being
3272         added, don't call through to end() just yet.
3273
3274 2006-07-29  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3275
3276         Reviewed by John Sullivan.
3277
3278         - manual test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9984
3279           ASSERTION FAILURE: _private->mouseDownEvent != nil
3280           (WebKit/WebView/WebHTMLView.m:4863 -[WebHTMLView(WebInternal) _delegateDragSourceActionMask])
3281
3282         * manual-tests/subview-click-assertion.html: Added.
3283
3284 2006-07-29  Andrew Wellington  <proton@wiretapped.net>
3285
3286         Reviewed by Darin.
3287
3288         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 / <rdar://problem/4631844>
3289         REGRESSION: {display:list-item} items outside an ol or ul element don't number correctly
3290
3291         * rendering/RenderListItem.cpp:
3292         (WebCore::enclosingList): If no real list element is found, use parent instead.
3293         (WebCore::previousListItem): Check list elements to see if they are list items -- the
3294         old code assumed that a list would never be a list item but this is entirely possible
3295         with CSS and especially with the new rule that means any DOM element could act as a list.
3296
3297 2006-07-29  Alexey Proskuryakov  <ap@nypop.com>
3298
3299         Reviewed by Darin.
3300
3301         Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10147
3302         REGRESSION: custom attribute values set via javascript are not persistent
3303
3304         Test: fast/dom/Element/setAttribute-case-insensitivity.html
3305
3306         * dom/Element.cpp:
3307         (WebCore::Element::setAttribute): Use the lowercased localName for retrieving the old value, too.
3308
3309 2006-07-28  Timothy Hatcher  <timothy@apple.com>
3310
3311         Suggested by Darin.
3312
3313         Moving the implementation of isContentEditable to the
3314         the WebPrivate category.
3315
3316         * bindings/objc/DOM.mm:
3317         (-[DOMNode isContentEditable]):
3318
3319 2006-07-28  Justin Garcia  <justin.garcia@apple.com>
3320
3321         Reviewed by levi
3322         
3323         First part of:
3324         <rdar://problem/4515463>
3325         REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page
3326         
3327         Migrate to isBlock and enclosingBlock.
3328         Changed RendereringInfo::isBlock and ReplacementFragment::isBlock
3329         to wasBlock so that they don't conflict with isBlock and because
3330         it's more descriptive.
3331
3332         * editing/ReplaceSelectionCommand.cpp:
3333         (WebCore::ReplacementFragment::mergeStartNode):
3334         (WebCore::ReplacementFragment::wasBlock):
3335         (WebCore::ReplacementFragment::saveRenderingInfo):
3336         (WebCore::ReplacementFragment::renderedBlocks):
3337         (WebCore::RenderingInfo::RenderingInfo):
3338         (WebCore::ReplaceSelectionCommand::shouldMergeStart):
3339         (WebCore::ReplaceSelectionCommand::doApply):
3340         * editing/ReplaceSelectionCommand.h:
3341         (WebCore::RenderingInfo::wasBlock):
3342
3343 2006-07-27  Justin Garcia  <justin.garcia@apple.com>
3344
3345         Reviewed by levi
3346         
3347         More changes for:
3348         <rdar://problem/4242293>
3349         Poor paste fidelity of http://www.google.com/
3350
3351         * editing/markup.cpp:
3352         (WebCore::needInterchangeNewlineAfter): Added.
3353         (WebCore::createMarkup): 
3354         Only add an interchangeNewline if we're annotating for interchange.  Can't test 
3355         this until we expose createMarkup in non-annotate mode (I'd expose Range::toHTML).
3356         Remove the FIXME about prepending the interchangeNewline before creating the rest 
3357         of the markup.  Its correct to surround the interchangeNewline in ancestors of the
3358         adjusted startNode.
3359         Fixed the check to see if an interchangeNewline is needed (!inSameBlock).  This would
3360         add an interchangeNewline for a selection that started before a table.
3361         Removed the workaround for the bug where markup for a table was not included when 
3362         selecting the contents of a table, since this change fixes the general problem of 
3363         markup for ancestors of the startNode being left out.
3364         Don't leave out ancestors of the startNode as we leave their subtrees.  Execute the
3365         code to include them even if we closed ancestors in the ancestorsToClose list.
3366
3367 2006-07-28  Timothy Hatcher  <timothy@apple.com>
3368
3369         Reviewed by John.
3370
3371         Adding isContentEditable to DOMNode's private category. 
3372
3373         * bindings/objc/DOMPrivate.h:
3374
3375 2006-07-28  Alexey Proskuryakov  <ap@nypop.com>
3376
3377         Rolling out http://bugzilla.opendarwin.org/show_bug.cgi?id=6010 because of failing layout tests.
3378         Add better SVGLoad event support.
3379
3380         * dom/EventTargetNode.cpp:
3381         (WebCore::EventTargetNode::dispatchGenericEvent):
3382         * html/HTMLImageLoader.cpp:
3383         (WebCore::HTMLImageLoader::dispatchLoadEvent):
3384         * html/HTMLImageLoader.h:
3385         * ksvg2/misc/SVGImageLoader.cpp:
3386         (WebCore::SVGImageLoader::SVGImageLoader):
3387         * ksvg2/misc/SVGImageLoader.h:
3388         * ksvg2/svg/SVGAElement.cpp:
3389         (WebCore::SVGAElement::parseMappedAttribute):
3390         * ksvg2/svg/SVGAnimatedBoolean.h:
3391         * ksvg2/svg/SVGElement.cpp:
3392         (WebCore::SVGElement::SVGElement):
3393         (WebCore::SVGElement::parseMappedAttribute):
3394         * ksvg2/svg/SVGElement.h:
3395         (WebCore::SVGElement::adjustViewportClipping):
3396         (WebCore::SVGElement::closeRenderer):
3397         (WebCore::SVGElement::rendererIsNeeded):
3398         (WebCore::SVGElement::isClosed):
3399         (WebCore::svg_dynamic_cast):
3400         * ksvg2/svg/SVGExternalResourcesRequired.h:
3401         * ksvg2/svg/SVGImageElement.cpp:
3402         (SVGImageElement::SVGImageElement):
3403         * ksvg2/svg/SVGImageElement.h:
3404         * ksvg2/svg/SVGSVGElement.cpp:
3405         (WebCore::SVGSVGElement::parseMappedAttribute):
3406         * ksvg2/svg/SVGScriptElement.cpp:
3407         (SVGScriptElement::SVGScriptElement):
3408         (SVGScriptElement::parseMappedAttribute):
3409         (SVGScriptElement::executeScript):
3410         * xml/xmlhttprequest.cpp:
3411         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
3412
3413 2006-07-28  Adele Peterson  <adele@apple.com>
3414
3415         Rolling out http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 because of failing layout tests.
3416         SVG with width and height 100% leaves room for scrollbar on the right.
3417
3418         * kcanvas/RenderPath.cpp:
3419         * kcanvas/RenderPath.h:
3420         * kcanvas/RenderSVGContainer.cpp:
3421         (WebCore::RenderSVGContainer::layout):
3422         * ksvg2/svg/SVGCircleElement.cpp:
3423         * ksvg2/svg/SVGCircleElement.h:
3424         * ksvg2/svg/SVGEllipseElement.cpp:
3425         * ksvg2/svg/SVGEllipseElement.h:
3426         * ksvg2/svg/SVGLineElement.cpp:
3427         * ksvg2/svg/SVGLineElement.h:
3428         * ksvg2/svg/SVGRectElement.cpp:
3429         * ksvg2/svg/SVGRectElement.h:
3430         * ksvg2/svg/SVGStyledElement.h:
3431
3432 2006-07-27  Eric Seidel  <eric@eseidel.com>
3433
3434         Reviewed by darin.
3435         
3436         Add better SVGLoad event support.
3437         http://bugzilla.opendarwin.org/show_bug.cgi?id=6010
3438         There will still need to be additional support added for <link> and <script> elements.
3439         Not all of the error -> loaded -> error transition cases work yet.
3440
3441         * dom/EventTargetNode.cpp:
3442         (WebCore::EventTargetNode::dispatchGenericEvent):
3443         * html/HTMLImageLoader.cpp:
3444         (WebCore::HTMLImageLoader::dispatchLoadEvent):
3445         * html/HTMLImageLoader.h:
3446         (WebCore::HTMLImageLoader::haveFiredLoadEvent):
3447         (WebCore::HTMLImageLoader::setHaveFiredLoadEvent):
3448         * ksvg2/misc/SVGImageLoader.cpp:
3449         (WebCore::SVGImageLoader::SVGImageLoader):
3450         (WebCore::SVGImageLoader::dispatchLoadEvent):
3451         * ksvg2/misc/SVGImageLoader.h:
3452         * ksvg2/svg/SVGAElement.cpp:
3453         (WebCore::SVGAElement::parseMappedAttribute):
3454         * ksvg2/svg/SVGAnimatedBoolean.h:
3455         * ksvg2/svg/SVGElement.cpp:
3456         (WebCore::SVGElement::SVGElement):
3457         (WebCore::SVGElement::parseMappedAttribute):
3458         (WebCore::SVGElement::haveLoadedRequiredResources):
3459         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
3460         (WebCore::SVGElement::closeRenderer):
3461         * ksvg2/svg/SVGElement.h:
3462         (WebCore::SVGElement::rendererIsNeeded):
3463         (WebCore::svg_dynamic_cast):
3464         * ksvg2/svg/SVGExternalResourcesRequired.h:
3465         * ksvg2/svg/SVGImageElement.cpp:
3466         (SVGImageElement::SVGImageElement):
3467         (SVGImageElement::haveLoadedRequiredResources):
3468         * ksvg2/svg/SVGImageElement.h:
3469         * ksvg2/svg/SVGSVGElement.cpp:
3470         (WebCore::SVGSVGElement::parseMappedAttribute):
3471         * ksvg2/svg/SVGScriptElement.cpp:
3472         (WebCore::SVGScriptElement::SVGScriptElement):
3473         (WebCore::SVGScriptElement::parseMappedAttribute):
3474         (WebCore::SVGScriptElement::executeScript):
3475         * xml/xmlhttprequest.cpp:
3476         (WebCore::XMLHttpRequest::callReadyStateChangeListener): use new Event() instead of createEvent
3477
3478 2006-07-27  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3479
3480         Reviewed by Anders.
3481
3482         - http://bugzilla.opendarwin.org/show_bug.cgi?id=10135
3483           Cleanup: remove useless parameters from RenderObject::position()
3484
3485         No test possible (no functionality change)
3486
3487         * rendering/RenderBox.cpp:
3488         (WebCore::RenderBox::position):
3489         * rendering/RenderBox.h:
3490         * rendering/RenderObject.h:
3491         (WebCore::RenderObject::position):
3492         * rendering/RenderTableRow.h:
3493         (WebCore::RenderTableRow::position):
3494         * rendering/RenderTableSection.h:
3495         (WebCore::RenderTableSection::position):
3496         * rendering/RenderText.cpp:
3497         (WebCore::RenderText::position):
3498         * rendering/RenderText.h:
3499         * rendering/bidi.cpp:
3500         (WebCore::RenderBlock::constructLine):
3501         (WebCore::RenderBlock::computeVerticalPositionsForLine):
3502
3503 2006-07-27  Rob Buis  <buis@kde.org>
3504
3505         Reviewed by Maciej.
3506
3507         http://bugzilla.opendarwin.org/show_bug.cgi?id=9753
3508         SVG with width and height 100% leaves room for scrollbar on the right.
3509
3510         Relayout children of svg containers, except svg shapes that do not depend on percentages.
3511
3512         * kcanvas/RenderPath.cpp: (WebCore::RenderPath::hasPercentageValues):
3513         * kcanvas/RenderPath.h:
3514         * kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
3515         * ksvg2/svg/SVGCircleElement.cpp: (SVGCircleElement::hasPercentageValues):
3516         * ksvg2/svg/SVGCircleElement.h:
3517         * ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::hasPercentageValues):
3518         * ksvg2/svg/SVGEllipseElement.h:
3519         * ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::hasPercentageValues):
3520         * ksvg2/svg/SVGLineElement.h:
3521         * ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::hasPercentageValues):
3522         * ksvg2/svg/SVGRectElement.h:
3523         * ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasPercentageValues):
3524
3525 2006-07-27  Justin Garcia  <justin.garcia@apple.com>
3526
3527         Reviewed by levi
3528         
3529         <rdar://problem/4242293>
3530         Poor paste fidelity of http://www.google.com/
3531
3532         * editing/ApplyStyleCommand.cpp:
3533         (WebCore::ApplyStyleCommand::applyInlineStyle):  Fixed crasher with nil-check.
3534         * editing/markup.cpp:
3535         (WebCore::startMarkup): Style information wasn't added to an element if it had
3536         attributes but no style attribute.
3537
3538 2006-07-27  Alexander Kellett  <lypanov@kde.org>
3539
3540         Reviewed by Darin.
3541
3542         - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9867
3543           REGRESSION: code that modifies form element in Firefox modifies form attribute in WebKit
3544
3545         * bindings/scripts/CodeGeneratorJS.pm: add new attribute - HasOverridingNameGetter
3546         * html/HTMLFormElement.idl:
3547
3548 2006-07-27  Rob Buis  <buis@kde.org>
3549
3550         Reviewed by Anders.
3551
3552         http://bugzilla.opendarwin.org/show_bug.cgi?id=8992
3553         Some HTML DOM attributes have incorrect types
3554
3555         Adjust idl and dom source code for HTMLImageElement and
3556         HTMLBaseFontElement to choose correct type for
3557         HTMLImageElement::border and HTMLBaseFontElement::size
3558         attributes.
3559