Reviewed by Adam Roben.
[WebKit-https.git] / WebCore / ChangeLog
1 2009-03-04  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Roben.
4
5         Add an ASSERT to better demonstrate the cause of the crash in
6         https://bugs.webkit.org/show_bug.cgi?id=23736
7
8         * loader/DocLoader.cpp:
9         (WebCore::DocLoader::~DocLoader):
10
11 2009-03-04  David Levin  <levin@chromium.org>
12
13         Reviewed by Alexey Proskuryakov.
14
15         Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
16         <https://bugs.webkit.org/show_bug.cgi?id=24337>
17
18         Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
19                http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html
20
21         * loader/mac/ResourceLoaderMac.mm:
22         (WebCore::ResourceLoader::willCacheResponse):
23         An identifier is only asssigned if resource load callbacks are done.  So don't send
24         willCacheResponse which uses identifier if resource load callbacks aren't being sent.
25
26 2009-03-04  David Levin  <levin@chromium.org>
27
28         Reviewed by Alexey Proskuryakov.
29
30         Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
31         <https://bugs.webkit.org/show_bug.cgi?id=24330>
32
33         Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html
34
35         * dom/ExceptionCode.cpp:
36         (WebCore::xmlHttpRequestExceptionNames):
37         Added missing ABORT_ERR whose absence caused an assert.
38
39         * loader/WorkerThreadableLoader.cpp:
40         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
41         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
42         Add more logic to handle the termination case for sync xhr.
43
44 2009-03-04  Eric Carlson  <eric.carlson@apple.com>
45
46         Reviewed by Antti Koivisto.
47
48         https://bugs.webkit.org/show_bug.cgi?id=24364
49         Add support for HTMLMediaElement canPlayType method. Make
50         MediaPlayer::supportsType take a ContentType instead of a
51         separate mime type and codecs parameter.
52
53         Test: media/video-can-play-type.html
54
55         * dom/DOMImplementation.cpp:
56         (WebCore::DOMImplementation::createDocument):
57         * html/HTMLMediaElement.cpp:
58         (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method.
59         (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType.
60         (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type.
61         (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
62         * html/HTMLMediaElement.h: Add prototype.
63         * html/HTMLMediaElement.idl: Ditto.
64         * platform/graphics/MediaPlayer.cpp:
65         (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type.
66         (WebCore::MediaPlayer::supportsType): Ditto.
67         * platform/graphics/MediaPlayer.h:
68
69 2009-03-04  Antti Koivisto  <antti@apple.com>
70
71         Reviewed by Dave Hyatt.
72
73         https://bugs.webkit.org/show_bug.cgi?id=24359
74         Repaint throttling mechanism
75         
76         Excessive repainting can slow down page loadind. This implements a timer
77         based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not 
78         enabled by default.
79
80         * loader/FrameLoader.cpp:
81         (WebCore::FrameLoader::checkCompleted):
82         * page/EventHandler.cpp:
83         (WebCore::EventHandler::dispatchDragEvent):
84         (WebCore::EventHandler::dispatchMouseEvent):
85         (WebCore::EventHandler::keyEvent):
86         (WebCore::EventHandler::handleTextInputEvent):
87         * page/FrameView.cpp:
88         (WebCore::FrameView::FrameView):
89         (WebCore::FrameView::reset):
90         (WebCore::FrameView::repaintContentRectangle):
91         (WebCore::FrameView::beginDeferredRepaints):
92         (WebCore::FrameView::endDeferredRepaints):
93         (WebCore::FrameView::checkStopDelayingDeferredRepaints):
94         (WebCore::FrameView::doDeferredRepaints):
95         (WebCore::FrameView::updateDeferredRepaintDelay):
96         (WebCore::FrameView::resetDeferredRepaintDelay):
97         (WebCore::FrameView::adjustedDeferredRepaintDelay):
98         (WebCore::FrameView::deferredRepaintTimerFired):
99         (WebCore::FrameView::paintContents):
100         * page/FrameView.h:
101
102 2009-03-04  Sam Weinig  <sam@webkit.org>
103
104         Rubber-stamped by Antti Koivisto.
105
106         Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.
107
108         * dom/Document.cpp:
109         (WebCore::Document::Document):
110         * dom/Document.h:
111         (WebCore::Document::haveStylesheetsLoaded):
112         * html/HTMLTokenizer.cpp:
113         (WebCore::HTMLTokenizer::scriptHandler):
114         * loader/Cache.cpp:
115         (WebCore::Cache::requestResource):
116         * loader/CachedCSSStyleSheet.cpp:
117         (WebCore::CachedCSSStyleSheet::checkNotify):
118         * loader/DocLoader.h:
119         * loader/FrameLoader.cpp:
120         (WebCore::FrameLoader::FrameLoader):
121         (WebCore::FrameLoader::requestFrame):
122         (WebCore::FrameLoader::stopLoading):
123         (WebCore::FrameLoader::begin):
124         (WebCore::FrameLoader::write):
125         (WebCore::FrameLoader::endIfNotLoadingMainResource):
126         (WebCore::FrameLoader::checkCompleted):
127         (WebCore::FrameLoader::requestObject):
128         (WebCore::FrameLoader::loadItem):
129         * loader/FrameLoader.h:
130
131 2009-03-02  Xan Lopez  <xan@gnome.org>
132
133         Reviewed by Mark Rowe.
134
135         https://bugs.webkit.org/show_bug.cgi?id=24287
136         [GTK] Move auth dialog feature to WebKit/
137
138         Remove WebKitSoupAuthDialog files from build and stop using it.
139
140         * GNUmakefile.am:
141         * platform/network/soup/ResourceHandleSoup.cpp:
142         (WebCore::ensureSessionIsInitialized):
143         * platform/network/soup/webkit-soup-auth-dialog.c: Removed.
144         * platform/network/soup/webkit-soup-auth-dialog.h: Removed.
145
146 2009-03-04  Simon Fraser  <simon.fraser@apple.com>
147
148         Reviewed by Dave Hyatt
149         
150         https://bugs.webkit.org/show_bug.cgi?id=24361
151         
152         Reinstate code that sets result.innerNode when hitTest() returns true,
153         but never filled in the innerNode. Fixes hit testing of generated content.
154
155         Test: fast/css-generated-content/hit-test-generated-content.html
156
157         * rendering/RenderLayer.cpp:
158         (WebCore::RenderLayer::hitTestContents):
159
160 2009-03-04  Adam Barth  <abath@webkit.org>
161
162         Reviewed by Alexey Proskuryakov.
163
164         https://bugs.webkit.org/show_bug.cgi?id=24356
165
166         Fix WebKit style for allowUniversalAccessFromFileURLs.
167
168         * WebCore.base.exp:
169         * dom/Document.cpp:
170         (WebCore::Document::initSecurityContext):
171         * page/Settings.cpp:
172         (WebCore::Settings::Settings):
173         (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
174         * page/Settings.h:
175         (WebCore::Settings::allowUniversalAccessFromFileURLs):
176
177 2009-03-04  Brady Eidson  <beidson@apple.com>
178
179         Reviewed by Darin Adler
180
181         <rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.
182
183         I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
184         consolidated some of the various decision making pieces of the Cache into the new method
185         FrameLoader::cachePolicy().
186
187         Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader 
188         is reloading.  If it is, we'd evict any existing resource then recreate it.  Quick looks uses the
189         same URL for this image every time and expects it to be reloaded with each new card.
190
191         The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
192         is "ReloadIgnoringCacheData".  This check was lost in the consolidation to the new method.  
193
194         * loader/FrameLoader.cpp:
195         (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible
196           condition for returning CachePolicyReload.
197
198 2009-03-04  Timothy Hatcher  <timothy@apple.com>
199
200         * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
201         "LOCAL STORAGE" and "SESSION STORAGE".
202
203 2009-03-04  Timothy Hatcher  <timothy@apple.com>
204
205         Fix a regression where the Web Inspector console would not animate
206         in or out correctly.
207
208         Reviewed by Anders Carlsson.
209
210         * inspector/front-end/inspector.css: Move a z-index to a child element
211         to get the correct stacking order during the animation.
212
213 2009-03-03  David Hyatt  <hyatt@apple.com>
214
215         https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.
216
217         Make sure to factor clear deltas into y position estimates.  Also avoid doing the comparison of
218         the final position against the y position estimate until after the clear has happened.  This gets rid
219         of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.
220
221         Reviewed by Dan Bernstein
222
223         Added fast/block/float/nested-clearance.html
224
225         * rendering/RenderBlock.cpp:
226         (WebCore::RenderBlock::collapseMargins):
227         (WebCore::RenderBlock::clearFloatsIfNeeded):
228         (WebCore::RenderBlock::estimateVerticalPosition):
229         (WebCore::RenderBlock::layoutBlockChildren):
230         (WebCore::RenderBlock::getClearDelta):
231         * rendering/RenderBlock.h:
232
233 2009-03-02  Kim Grönholm  <kim.gronholm@nomovok.com>
234
235         Reviewed by Simon Hausmann.
236
237         Improvement to 3d transformations rendering in QtWebKit. QTransform is used
238         instead of QMatrix. This allows perspective transformations since QTransform is
239         a true 3x3 matrix.
240
241         * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere.
242         (WebCore::GraphicsContext::getCTM):
243         (WebCore::GraphicsContext::restorePlatformState):
244         (WebCore::GraphicsContext::fillPath):
245         (WebCore::GraphicsContext::strokePath):
246         (WebCore::GraphicsContext::fillRect):
247         (WebCore::GraphicsContext::translate):
248         (WebCore::GraphicsContext::rotate):
249         (WebCore::GraphicsContext::scale):
250         (WebCore::GraphicsContext::concatCTM):
251         * platform/graphics/qt/ImageQt.cpp:
252         (WebCore::Image::drawPattern):
253         * platform/graphics/qt/PathQt.cpp:
254         (WebCore::Path::translate):
255         (WebCore::Path::transform):
256         * platform/graphics/qt/PatternQt.cpp:
257         (WebCore::Pattern::createPlatformPattern):
258         * platform/graphics/qt/TransformationMatrixQt.cpp:
259         (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator
260         to QMatrix with one to QTransform.
261         * platform/graphics/transforms/TransformationMatrix.h:
262         * platform/graphics/qt/FontQt.cpp:
263
264 2009-02-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
265
266         Reviewed by Simon Hausmann.
267
268         https://bugs.webkit.org/show_bug.cgi?id=24151
269         Fix Qt/S60 build break
270
271         * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds
272         * platform/qt/FileSystemQt.cpp: Ditto
273         (WebCore::unloadModule):
274
275 2009-03-03  Mike Belshe  <mike@belshe.com>
276
277         Reviewed by Alexey Proskuryakov.
278
279         https://bugs.webkit.org/show_bug.cgi?id=21939
280         Uninitialized ExceptionCode in DOMWindow::postMessage
281
282         * dom/MessagePort.cpp:
283         (WebCore::MessagePort::postMessage):
284
285 2009-03-03  David Kilzer  <ddkilzer@apple.com>
286
287         <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
288
289         Reviewed by Mark Rowe.
290
291         The fix is to add INSTALLHDRS_COPY_PHASE = YES and
292         INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
293         sure various build phase scripts work with the installhdrs build
294         phase.
295
296         * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
297         based on PLATFORM_NAME to work around the missing definition on
298         Tiger.
299         * Configurations/WebCore.xcconfig: Added
300         JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
301         the "Generate Derived Sources" script.  Added
302         INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
303
304         * WebCore.xcodeproj/project.pbxproj:
305         - Added shell code to prevent running "Check For Global
306           Initializers", "Check For Exit Time Destructors" and "Check
307           For Weak VTables" scripts during the installhdrs build phase.
308         - Made "Generate Derived Sources" work for the installhdrs build
309           phase.  Also simplified setting of CREATE_HASH_TABLE by using
310           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
311
312 2009-03-02  Adam Langley  <agl@google.com>
313
314         Reviewed by Darin Fisher.
315
316         Chromium Linux: Switch to using Skia to render widgets.
317
318         In order to sandbox the Chromium renderer on Linux we need to remove
319         the X connection. GTK cannot render without an X connection so, for
320         now, we render widgets ourselves.
321
322         Previously didn't use anti-alias fonts in order to match Windows font
323         rendering exactly. This was helpful when bootstrapping our layout
324         tests. Now, however, we are ready to enable it.
325
326         https://bugs.webkit.org/show_bug.cgi?id=24244
327
328         * platform/chromium/ScrollbarThemeChromium.cpp:
329         (WebCore::ScrollbarThemeChromium::buttonSize):
330         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
331         (WebCore::ScrollbarThemeChromium::scrollbarThickness):
332         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
333         (WebCore::ScrollbarThemeChromium::paintButton):
334         (WebCore::ScrollbarThemeChromium::paintThumb):
335         * platform/graphics/chromium/FontPlatformDataLinux.cpp:
336         (WebCore::FontPlatformData::setupPaint):
337         * platform/graphics/skia/PlatformContextSkia.cpp:
338         (PlatformContextSkia::PlatformContextSkia):
339         (PlatformContextSkia::~PlatformContextSkia):
340         * platform/graphics/skia/PlatformContextSkia.h:
341         * rendering/RenderThemeChromiumGtk.cpp: Removed.
342         * rendering/RenderThemeChromiumGtk.h: Removed.
343         * rendering/RenderThemeChromiumLinux.cpp: Added.
344         * rendering/RenderThemeChromiumLinux.h: Added.
345
346 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
347
348         Reviewed by Darin Fisher.
349
350         https://bugs.webkit.org/show_bug.cgi?id=24261
351         Fix return types.
352
353         Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
354
355         * bindings/v8/V8Binding.h:
356         (WebCore::toInt32): change return type to int
357         (WebCore::toFloat): change return type to float.
358
359 2009-03-03  Anders Carlsson  <andersca@apple.com>
360
361         Reviewed by John Sullivan.
362
363         https://bugs.webkit.org/show_bug.cgi?id=22884
364         <rdar://problem/6449783>
365         modified layout test crashes Safari
366
367         Null check NPStream before dereferencing it.
368         
369         * plugins/PluginView.cpp:
370         (WebCore::PluginView::destroyStream):
371
372 2009-03-03  Eric Carlson  <eric.carlson@apple.com>
373
374         Reviewed by Simon Fraser.
375
376         Fix for <rdar://problem/6641045>
377         Don't call QTKit to get movie properties until movie metadata has been loaded.
378
379         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
380         (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
381         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
382         (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
383         (WebCore::MediaPlayerPrivate::play): Ditto.
384         (WebCore::MediaPlayerPrivate::pause): Ditto.
385         (WebCore::MediaPlayerPrivate::duration): Ditto.
386         (WebCore::MediaPlayerPrivate::currentTime): Ditto.
387         (WebCore::MediaPlayerPrivate::seek): Ditto.
388         (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
389         (WebCore::MediaPlayerPrivate::paused): Ditto.
390         (WebCore::MediaPlayerPrivate::seeking): Ditto.
391         (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
392         (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
393         (WebCore::MediaPlayerPrivate::setVolume): Ditto.
394         (WebCore::MediaPlayerPrivate::setRate): Ditto.
395         (WebCore::MediaPlayerPrivate::dataRate): Ditto.
396         (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
397         (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
398
399 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
400
401         - Spelling fix.
402
403         * page/Console.cpp:
404         (WebCore::Console::profile):
405
406 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
407
408         Reviewed by Darin Fisher.
409
410         https://bugs.webkit.org/show_bug.cgi?id=23657
411         Remove Database API callback IDLs from the project. 
412         They were removed in r40633.
413
414         * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
415
416 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
417
418         Reviewed by Oliver Hunt.
419
420         <rdar://problem/6639110> console.profile() doesn't work without a title
421
422         * page/Console.cpp:
423         (WebCore::Console::profile): If there is no title assume this is a user
424         initiated profile and give it the next incremented title name.
425
426 2009-03-03  Timothy Hatcher  <timothy@apple.com>
427
428         Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
429         the console code and refactored things to have fewer code paths and duplication.
430
431         rdar://problem/6367127
432         https://bugs.webkit.org/show_bug.cgi?id=24329
433
434         Reviewed by Kevin McCullough.
435
436         Test: manual-tests/inspector/console-dir.html
437
438         * bindings/js/JSInspectedObjectWrapper.cpp:
439         (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
440         to fix an ASSERT about using a wrapper from the wrong ExecState.
441         * bindings/js/JSQuarantinedObjectWrapper.cpp:
442         (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
443         (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
444         * inspector/front-end/Console.js:
445         (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
446         When forceObjectFormat is true, the only formatter used is _formatobject.
447         (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
448         (WebInspector.Console.prototype._formatstring): Ditto.
449         (WebInspector.Console.prototype._formatregexp): Ditto.
450         (WebInspector.Console.prototype._formatarray): Ditto.
451         (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
452         (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
453         (WebInspector.Console.prototype._formaterror): Remove the inline argument.
454         (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
455         simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
456         (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
457         (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
458         (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
459         (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
460         * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
461         * inspector/front-end/utilities.js:
462         (Object.type): Return "node" for Node objects.
463         (Object.describe): Handle the "node" type.
464         * page/Console.cpp:
465         (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
466         (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
467         * page/Console.h:
468         (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
469
470 2009-03-03  Scott Violet  <sky@google.com>
471
472         Reviewed by Eric Seidel.
473
474         https://bugs.webkit.org/show_bug.cgi?id=24325
475         Crash on replacing document contents during drop.
476
477         Makes sure a node is in the document during a move before using it.
478
479         Test: fast/events/crash-on-mutate-during-drop.html
480
481         * editing/MoveSelectionCommand.cpp:
482         (WebCore::MoveSelectionCommand::doApply):
483
484 2009-03-03  Jungshik Shin <jshin@chromium.org>
485
486         Reviewed by Eric Seidel.
487
488         https://bugs.webkit.org/show_bug.cgi?id=23028
489         Enable dynamic web font support to Chromium on Windows.
490         Files that were omitted by mistake in the latest patch
491         that was landed.
492
493         * loader/CachedFont.cpp:
494         (WebCore::CachedFont::~CachedFont):
495         (WebCore::CachedFont::ensureCustomFontData):
496         (WebCore::CachedFont::platformDataFromCustomData):
497         (WebCore::CachedFont::allClientsRemoved):
498         * platform/graphics/chromium/FontCustomPlatformData.cpp:
499         (WebCore::EOTStream::EOTStream):
500         (WebCore::createFontCustomPlatformData):
501         * platform/graphics/win/FontCustomPlatformData.cpp:
502         (WebCore::EOTStream::EOTStream):
503         (WebCore::createFontCustomPlatformData):
504
505 2009-03-03  Gustavo Noronha Silva  <gns@gnome.org>
506
507         Reviewed by Alexey Proskuryakov.
508
509         https://bugs.webkit.org/show_bug.cgi?id=16826
510         [Gtk] Implement WebKitDownload
511
512         Make the Soup backend able to handle requests without a frame,
513         since we may have such things now that we support downloads.
514
515         * platform/network/ResourceHandleInternal.h:
516         * platform/network/soup/ResourceHandleSoup.cpp:
517         (WebCore::ResourceHandle::start):
518
519 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
520
521         Reviewed by Eric Seidel.
522
523         https://bugs.webkit.org/show_bug.cgi?id=24331
524         Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
525
526         * bindings/v8/custom/V8AttrCustom.cpp: Added.
527         * bindings/v8/custom/V8CustomBinding.cpp: Added.
528         * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
529         * bindings/v8/custom/V8ElementCustom.cpp: Added.
530         * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
531         * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
532
533 2009-03-03  Brady Eidson  <beidson@apple.com>
534
535         Reviewed by Darin Adler
536
537         <rdar://problem/6616664> - Quick looks of various file types is broken
538
539         In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
540         for non-HTTP loads when the underlying ResourceRequest changed.  Unfortunately it was a little
541         overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
542
543         Partially reverted behavior to always set the mainDocumentURL in situations when we would've
544         before that patch.
545
546         * loader/FrameLoader.cpp:
547         (WebCore::FrameLoader::addExtraFieldsToRequest):
548
549         * platform/network/ResourceRequestBase.cpp:
550         (WebCore::ResourceRequestBase::setMainDocumentURL):
551
552 2009-03-03  Chris Marrin  <cmarrin@apple.com>
553
554         Reviewed by Simon Fraser.
555
556         https://bugs.webkit.org/show_bug.cgi?id=24256
557
558         Added a WebCoreForceSoftwareAnimation flag.
559
560         * platform/graphics/mac/GraphicsLayerCA.mm:
561         (WebCore::forceSoftwareAnimation):
562         (WebCore::GraphicsLayerCA::setOpacity):
563         (WebCore::GraphicsLayerCA::animateTransform):
564         (WebCore::GraphicsLayerCA::animateFloat):
565
566 2009-03-02  Chris Marrin  <cmarrin@apple.com>
567
568         Reviewed by Sam Weinig.
569
570         https://bugs.webkit.org/show_bug.cgi?id=24257
571
572         Added prototype properties for several classes with constructors that
573         were missing them, including the one mentioned in the bug.
574
575         Test: fast/dom/Window/custom-constructors.html
576
577         * bindings/js/JSAudioConstructor.cpp:
578         (WebCore::JSAudioConstructor::JSAudioConstructor):
579         * bindings/js/JSDOMWindowBase.cpp:
580         (jsDOMWindowBaseWebKitCSSMatrix):
581         * bindings/js/JSImageConstructor.cpp:
582         (WebCore::JSImageConstructor::JSImageConstructor):
583         * bindings/js/JSOptionConstructor.cpp:
584         (WebCore::JSOptionConstructor::JSOptionConstructor):
585         * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
586         (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
587         * bindings/js/JSWebKitCSSMatrixConstructor.h:
588         * bindings/js/JSWebKitPointConstructor.cpp:
589         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
590         * bindings/js/JSWorkerConstructor.cpp:
591         (WebCore::JSWorkerConstructor::JSWorkerConstructor):
592
593 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
594
595         Reviewed by Darin Fisher.
596
597         https://bugs.webkit.org/show_bug.cgi?id=24321
598         Add V8 bindings headers.
599
600         * bindings/v8/V8Binding.h: Added.
601         * bindings/v8/V8Proxy.h: Added.
602         * bindings/v8/custom/V8CustomBinding.h: Added.
603         * bindings/v8/custom/V8CustomEventListener.h: Added.
604
605 2009-03-03  Jungshik Shin <jshin@chromium.org>
606
607         Reviewed by Eric Seidel.
608
609         https://bugs.webkit.org/show_bug.cgi?id=23803
610         Fix an 'off-by-1' error in ChromiumWin's font fallback.
611
612         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
613         (WebCore::FontCache::getFontDataForCharacters):
614
615 2009-03-03  Jungshik Shin  <jshin@chromium.org>
616
617         Reviewed by Eric Seidel.
618
619         http://bugs.webkit.org/show_bug.cgi?id=23028
620         Enable dynamic web font support to Chromium on Windows: Part 1
621         - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
622           from platform/graphics/win because both Windows port and Chromium Windows
623           port will use them.
624         - Adjust WebCore.vcproj accordingly.
625
626         * WebCore.vcproj/WebCore.vcproj:
627         * platform/graphics/opentype: Added.
628         * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
629         * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
630         * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
631         * platform/graphics/win/OpenTypeUtilities.h: Removed.
632
633 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
634
635         Reviewed by Dave Hyatt
636
637         https://bugs.webkit.org/show_bug.cgi?id=24312
638         
639         Take 3D transforms into account when hit testing:
640         
641         1. Maintain a bit on each RenderLayer that is set when the layer
642            has 3d descendants, so that we know when to fall into the slow
643            hit testing path.
644            
645         2. Make a ref-counted HitTestingTransformState, which is used to store
646            an accumulated transform, and the hit test point, and hitTestRect
647            in the plane of the ancestor non-3d ('flattening') layer.
648            
649            It's ref-counted so we can heap allocate it (to avoid stack bloat),
650            and avoid copying when hitTestLayer calls itself after applying the transform.
651            
652         3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
653            3D transforms, or to do deep depth-testing when traversing a preserves-3d
654            hierarchy. When hit, layers compute a z-offset from the ancestor flattening
655            layer, which allows for correct depth testing.
656            
657            The existing early-return codepath is unaffected when there are no 3d transforms
658            and no preserve-3d.
659
660         * rendering/RenderLayer.cpp:
661         (WebCore::RenderLayer::RenderLayer):
662         (WebCore::RenderLayer::updateTransform):
663         (WebCore::RenderLayer::dirty3DTransformedDescendantStatus):
664         (WebCore::RenderLayer::update3DTransformedDescendantStatus):
665         (WebCore::RenderLayer::hitTest):
666         (WebCore::computeZOffset):
667         (WebCore::RenderLayer::createLocalTransformState):
668         (WebCore::RenderLayer::hitTestLayer):
669         (WebCore::RenderLayer::hitTestContents):
670         * rendering/RenderLayer.h:
671         (WebCore::RenderLayer::preserves3D):
672         (WebCore::RenderLayer::has3DTransform):
673         (WebCore::RenderLayer::setHas3DTransformedDescendant):
674         (WebCore::RenderLayer::has3DTransformedDescendant):
675         * rendering/RenderLayerBacking.cpp:
676         * rendering/TransformState.cpp:
677         (WebCore::TransformState::flatten):
678         (WebCore::TransformState::mappedPoint):
679         (WebCore::HitTestingTransformState::move):
680         (WebCore::HitTestingTransformState::applyTransform):
681         (WebCore::HitTestingTransformState::flatten):
682         (WebCore::HitTestingTransformState::mappedPoint):
683         (WebCore::HitTestingTransformState::mappedQuad):
684         * rendering/TransformState.h:
685         (WebCore::TransformState::TransformState):
686         (WebCore::HitTestingTransformState::create):
687         (WebCore::HitTestingTransformState::move):
688         (WebCore::HitTestingTransformState::HitTestingTransformState):
689
690 2009-03-03  Brett Wilson  <brettw@chromium.org>
691
692         Fix uninitialized memory reads in the Chromium Windows transparency
693         code that were identified by Purify,
694
695         Reviewed by Darin Fisher.
696
697         * platform/graphics/chromium/TransparencyWin.cpp:
698         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
699         (WebCore::TransparencyWin::initializeNewContext):
700
701 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
702
703         Reviewed by Dave Hyatt
704
705         https://bugs.webkit.org/show_bug.cgi?id=24312
706         
707         Factor the code that compute a transform relative to the container
708         into RenderObject::transformFromContainer().
709         
710         * rendering/RenderBox.cpp:
711         (WebCore::RenderBox::mapLocalToAbsolutePoint):
712         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
713         * rendering/RenderObject.cpp:
714         (WebCore::RenderObject::transformFromContainer):
715         * rendering/RenderObject.h:
716
717 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
718
719         Reviewed by Dave Hyatt
720
721         https://bugs.webkit.org/show_bug.cgi?id=24317
722         
723         Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
724         the superclass found a node, otherwise we set the innerNode of the
725         HitTestResult, but don't actually report that we found a hit.
726
727         * rendering/RenderTextControlMultiLine.cpp:
728         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
729
730 2009-03-03  Onne Gorter  <onne.gorter@avinity.net>
731
732         Reviewed by Anders Carlsson.
733
734         https://bugs.webkit.org/show_bug.cgi?id=23707
735         resizing plugins does not work, because the plugin never gets informed
736
737         Make gtk plugins resize correctly, by sending them the setwindow event
738         correctly. Also ensure that all plugin eventing is done with correct
739         locking/calling. Mostly copied from mac implementation.
740
741         manual test: manual-tests/gtk/plugin-resize-scroll.html
742
743         * plugins/PluginView.h:
744         * plugins/gtk/PluginViewGtk.cpp:
745         (WebCore::PluginView::dispatchNPEvent):
746         ensure locking/calling for NPEvents
747         (WebCore::PluginView::updatePluginWidget):
748         if something changed, let setNPWindowIfNeeded handle it
749         (WebCore::PluginView::paint):
750         (WebCore::PluginView::handleKeyboardEvent):
751         (WebCore::PluginView::handleMouseEvent):
752         ensure calling conventions
753         (WebCore::PluginView::setNPWindowRect):
754         just pass control to setNPWindowIfNeeded
755         (WebCore::PluginView::setNPWindowIfNeeded):
756         event the plugin correctly of new window
757         (WebCore::PluginView::init):
758         init through the new setup
759
760 2009-03-03  Mike Belshe  <mike@belshe.com>
761
762         Reviewed by Darin Fisher.
763
764         https://bugs.webkit.org/show_bug.cgi?id=24311
765         Make IDL returning DOMObject use [V8Custom]
766
767         * dom/Document.idl:
768         * html/HTMLCanvasElement.idl:
769
770 2009-03-02  Simon Fraser  <simon.fraser@apple.com>
771
772         Reviewed by Adele Peterson
773
774         https://bugs.webkit.org/show_bug.cgi?id=24313
775         
776         If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
777         HitTestResult, then it had better well return |true|. And m_innerBlock
778         could never have been set as the hit node by the superclass, because
779         the superclass knows nothing about m_innerBlock.
780         
781         Test: fast/forms/input-hit-test-border.html
782
783         * rendering/RenderTextControlSingleLine.cpp:
784         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
785
786 2009-03-02  Sam Weinig  <sam@webkit.org>
787
788         Reviewed by Mark Rowe.
789
790         Enable Geolocation (except on Tiger and Leopard).
791
792         * Configurations/WebCore.xcconfig:
793
794 2009-03-02  Ojan Vafai  <ojan@chromium.org>
795
796         Reviewed by Adele Peterson.
797
798         Fix https://bugs.webkit.org/show_bug.cgi?id=24307
799         Null out m_highlightedNode on hideHighlight().
800         Ran WebCore/manual-tests/inspector/highlight-nodes.html.
801
802         * inspector/InspectorController.cpp:
803         (WebCore::InspectorController::hideHighlight):
804
805 2009-03-02  Sam Weinig  <sam@webkit.org>
806
807         Reviewed by Geoffrey Garen.
808
809         Fix for <rdar://problem/6507404> Add Geolocation support.
810
811         This is not yet turned on for any Mac platform.
812
813         * WebCore.xcodeproj/project.pbxproj:
814         * page/Chrome.cpp:
815         (WebCore::Chrome::shouldAllowGeolocationForFrame):
816         * page/Chrome.h:
817         * page/ChromeClient.h:
818         (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
819         * page/Geolocation.cpp:
820         (WebCore::Geolocation::Geolocation):
821         (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
822         will not be alive at this point.
823         (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
824         return a PERMISSION_DENIED if not.
825         (WebCore::Geolocation::watchPosition): Ditto.
826         (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
827         to allow geolocation and cache the result. 
828         * page/Geolocation.h:
829         (WebCore::Geolocation::):
830         * platform/GeolocationService.cpp:
831         * platform/GeolocationService.h:
832         (WebCore::GeolocationService::~GeolocationService):
833         (WebCore::GeolocationService::stopUpdating):
834         * platform/mac/GeolocationServiceMac.h: Added.
835         (WebCore::GeolocationServiceMac::lastPosition):
836         (WebCore::GeolocationServiceMac::lastError):
837         * platform/mac/GeolocationServiceMac.mm: Added.
838         (WebCore::GeolocationService::create):
839         (WebCore::GeolocationServiceMac::GeolocationServiceMac):
840         (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
841         (WebCore::GeolocationServiceMac::startUpdating):
842         (WebCore::GeolocationServiceMac::stopUpdating):
843         (WebCore::GeolocationServiceMac::suspend):
844         (WebCore::GeolocationServiceMac::resume):
845         (WebCore::GeolocationServiceMac::positionChanged):
846         (WebCore::GeolocationServiceMac::errorOccurred):
847         (-[WebCoreCoreLocationObserver initWithCallback:]):
848         (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
849         (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
850
851 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
852
853         Build fixes for wxWidgets Mac trunk build.
854
855         * platform/wx/wxcode/mac/carbon/fontprops.cpp:
856         (wxFontProperties::wxFontProperties):
857         (GetTextExtent):
858         * webcore-wx.bkl:
859
860 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
861
862         wxGTK missing header build fix.
863
864         * platform/wx/wxcode/gtk/fontprops.cpp:
865
866 2009-03-02  Dan Bernstein  <mitz@apple.com>
867
868         Reviewed by Adam Roben.
869
870         - fix https://bugs.webkit.org/show_bug.cgi?id=21811
871           REGRESSION: Windows Build Not Selecting Proper Font
872
873         * platform/graphics/win/FontCacheWin.cpp:
874         (WebCore::createGDIFont): Added back code to verify that the created
875         HFONT has the requested face name.
876
877 2009-03-02  Timothy Hatcher  <timothy@apple.com>
878
879         Fixes a regression caused by splitting the input and output of console commands.
880
881         https://bugs.webkit.org/show_bug.cgi?id=24293
882
883         Reviewed by Kevin McCullough.
884
885         * inspector/front-end/Console.js:
886         (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
887         normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
888
889 2009-03-02  Timothy Hatcher  <timothy@apple.com>
890
891         Make exception messages and logged Error objects display consistently.
892
893         https://bugs.webkit.org/show_bug.cgi?id=18983
894
895         Reviewed by Adam Roben.
896
897         * English.lproj/localizedStrings.js: Remove a string for line numbers.
898         * inspector/front-end/Console.js:
899         (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
900         boolean to the ConsoleCommandResult constructor and don't pass level.
901         (WebInspector.Console.prototype._formatnode): Fix a className typo.
902         (WebInspector.Console.prototype._formaterror): Add an error-message
903         classed span around the message to show in red and remove the
904         console-message-url class from the link so it doesn't float right.
905         Instead enclose the link in parentheses and use displayNameForURL
906         to shorten the URL in the link.
907         (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
908         how line numbers are shown since link underlining a string with
909         parentheses looks bad.
910         (WebInspector.ConsoleCommandResult): Take an exception boolean flag
911         instead of a level and get line and URL based on that flag.
912         * inspector/front-end/inspector.css: Tweaks to the styles.
913
914 2009-03-02  Ojan Vafai  <ojan@chromium.org>
915
916         Reviewed by Adele Peterson.
917
918         Bug 24048: extra windows button padding doesn't apply when there's no appearance
919         <https://bugs.webkit.org/show_bug.cgi?id=24048>
920
921         Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
922
923         No tests added as existing tests already cover this behavior.
924
925         * rendering/RenderButton.cpp:
926         (WebCore::RenderButton::setupInnerStyle):
927         * rendering/RenderTheme.cpp:
928         * rendering/RenderTheme.h:
929         (WebCore::RenderTheme::buttonInternalPaddingLeft):
930         (WebCore::RenderTheme::buttonInternalPaddingRight):
931         (WebCore::RenderTheme::buttonInternalPaddingTop):
932         * rendering/RenderThemeChromiumGtk.cpp:
933         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
934         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
935         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
936         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
937         * rendering/RenderThemeChromiumGtk.h:
938         * rendering/RenderThemeChromiumWin.cpp:
939         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
940         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
941         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
942         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
943         * rendering/RenderThemeChromiumWin.h:
944         * rendering/RenderThemeWin.cpp:
945         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
946         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
947         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
948         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
949         * rendering/RenderThemeWin.h:
950
951 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
952
953         Build fix for Qt port.  Remove unnecessary assert.
954
955         * platform/graphics/qt/ImageBufferQt.cpp:
956         (WebCore::ImageBuffer::putImageData):
957
958 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
959
960         Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
961
962         https://bugs.webkit.org/show_bug.cgi?id=24227
963         Ensure that the checkForSolidColor() optimization is correctly triggered
964         for all cases of drawPattern.  Currently, the optimization was not triggered
965         when the check had not been previously performed via a request for the
966         image's NativeImagePtr.
967
968         Implement the Qt version of the checkForSolidColor() method.  Combined with
969         the bug fix this reduces the time it takes to draw a repeating background
970         of a 1x1 image from ~50msecs to ~0msecs on my machine.
971
972         * platform/graphics/BitmapImage.cpp:
973         (WebCore::BitmapImage::BitmapImage):
974         * platform/graphics/BitmapImage.h:
975         (WebCore::BitmapImage::mayFillWithSolidColor):
976         * platform/graphics/Image.h:
977         (WebCore::Image::mayFillWithSolidColor):
978         * platform/graphics/cairo/ImageCairo.cpp:
979         (WebCore::BitmapImage::BitmapImage):
980         (WebCore::BitmapImage::checkForSolidColor):
981         * platform/graphics/cg/ImageCG.cpp:
982         (WebCore::BitmapImage::BitmapImage):
983         (WebCore::BitmapImage::checkForSolidColor):
984         * platform/graphics/qt/ImageQt.cpp:
985         (WebCore::BitmapImage::checkForSolidColor):
986         * platform/graphics/skia/ImageSkia.cpp:
987         (WebCore::BitmapImage::checkForSolidColor):
988         * platform/graphics/wx/ImageWx.cpp:
989         (WebCore::BitmapImage::checkForSolidColor):
990
991 2009-03-02  Gustavo Noronha Silva  <gns@gnome.org>
992
993         Unreviewed build fix; adding missing files to EXTRA_DIST, so that
994         they show up in the tarball.
995
996         * GNUmakefile.am:
997
998 2009-03-02  Dirk Schulze  <krit@webkit.org>
999
1000         Reviewed by Holger Freyther.
1001
1002         Added putImageData to Qt. Discussed with Ariya Hidayat.
1003
1004         [Qt] lacks putImageData support in Canvas
1005         https://bugs.webkit.org/show_bug.cgi?id=22186
1006
1007         * platform/graphics/qt/ImageBufferQt.cpp:
1008         (WebCore::ImageBuffer::putImageData):
1009
1010 2009-03-02  Timothy Hatcher  <timothy@apple.com>
1011
1012         Show exception messages again when evaluating bad expressions in the
1013         Web Inspector's console.
1014
1015         https://bugs.webkit.org/show_bug.cgi?id=19890
1016
1017         Reviewed by Oliver Hunt.
1018
1019         * bindings/js/JSQuarantinedObjectWrapper.cpp:
1020         (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
1021         Fix the order in which the exception is set and cleared now that the
1022         exception is stored in the shared GlobalData, not per ExecState.
1023
1024 2009-02-28  Timothy Hatcher  <timothy@apple.com>
1025
1026         Make input in the Web Inspector console print before any output
1027         that might be added by the called function.
1028
1029         https://bugs.webkit.org/show_bug.cgi?id=19931
1030
1031         Reviewed by Oliver Hunt.
1032
1033         * inspector/front-end/Console.js:
1034         (WebInspector.Console.prototype._enterKeyPressed): Add the command
1035         message before evaluating the result. Associate the originating
1036         command to the result, so if they are adjacent there is no divider.
1037         (WebInspector.ConsoleCommand): No longer take a result.
1038         (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
1039         code removed since it isn't used now.
1040         (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
1041         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
1042         Call the ConsoleMessage toMessageElement and add a style class.
1043         * inspector/front-end/inspector.css: Add a new style class for
1044         adjacent results to hide the divider. Also tweak the position of
1045         the disclosure triangle for objects to not use the left margin.
1046
1047 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
1048
1049         Reviewed by Oliver Hunt.
1050
1051         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
1052         <https://bugs.webkit.org/show_bug.cgi?id=24282>
1053
1054         When fetching an array of elements with a range, attachment views need to be returned
1055         instead of the actual attachment.
1056
1057         * page/mac/AccessibilityObjectWrapper.mm:
1058         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
1059         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
1060
1061 2009-03-01  Ojan Vafai  <ojan@chromium.org>
1062
1063         Reviewed by Eric Seidel.
1064
1065         Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
1066         <https://bugs.webkit.org/show_bug.cgi?id=24251>
1067         
1068         Make RenderObject::positionForCoordinate non-virtual and
1069         RenderObject::positionForPoint virtual in preparation for
1070         removing positionFor* from RenderObject/RenderText.
1071
1072         * page/Frame.cpp:
1073         (WebCore::Frame::visiblePositionForPoint):
1074         * rendering/RenderBR.cpp:
1075         (WebCore::RenderBR::positionForPoint):
1076         * rendering/RenderBR.h:
1077         * rendering/RenderBlock.cpp:
1078         (WebCore::RenderBlock::positionForPoint):
1079         * rendering/RenderBlock.h:
1080         * rendering/RenderBox.cpp:
1081         (WebCore::RenderBox::positionForPoint):
1082         * rendering/RenderBox.h:
1083         * rendering/RenderInline.cpp:
1084         (WebCore::RenderInline::positionForPoint):
1085         * rendering/RenderInline.h:
1086         * rendering/RenderObject.cpp:
1087         (WebCore::RenderObject::positionForCoordinates):
1088         (WebCore::RenderObject::positionForPoint):
1089         * rendering/RenderObject.h:
1090         * rendering/RenderReplaced.cpp:
1091         (WebCore::RenderReplaced::positionForPoint):
1092         * rendering/RenderReplaced.h:
1093         * rendering/RenderSVGInlineText.cpp:
1094         (WebCore::RenderSVGInlineText::positionForPoint):
1095         * rendering/RenderSVGInlineText.h:
1096         * rendering/RenderText.cpp:
1097         (WebCore::RenderText::positionForPoint):
1098         * rendering/RenderText.h:
1099
1100 2009-03-01  Larry Ewing  <lewing@novell.com>
1101
1102         Reviewed by Alexey Proskuryakov.
1103
1104         https://bugs.webkit.org/show_bug.cgi?id=24080
1105         NPN_GetValue casting to the wrong type and writing outside bounds
1106
1107         Make sure to cast the value to the correct type so that only
1108         memory owned by the value is written to.
1109
1110         * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic): 
1111         * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
1112         * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): 
1113         (PluginView::getValue):
1114
1115 2009-03-01  Jeremy Moskovich  <jeremy@chromium.org>
1116
1117         Reviewed by Simon Fraser.
1118
1119         https://bugs.webkit.org/show_bug.cgi?id=24197 and
1120         https://bugs.webkit.org/show_bug.cgi?id=23512
1121
1122         The Windows version of cgColor() is conditionally compiled using
1123         !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
1124         can use the OS X version instead of the Windows version.
1125
1126         Also rename cgColor() -> createCGColor()
1127
1128         No observable change in behavior, so no test.
1129
1130         * platform/graphics/Color.h:
1131         * platform/graphics/cg/ColorCG.cpp:
1132         (WebCore::createCGColor):
1133         * platform/graphics/cg/GraphicsContextCG.cpp:
1134         (WebCore::GraphicsContext::setPlatformShadow):
1135         * platform/graphics/mac/ColorMac.mm:
1136         (WebCore::createCGColor):
1137         * platform/graphics/mac/GraphicsContextMac.mm:
1138         (WebCore::GraphicsContext::drawFocusRing):
1139         * platform/graphics/mac/GraphicsLayerCA.mm:
1140         (WebCore::setLayerBorderColor):
1141         (WebCore::setLayerBackgroundColor):
1142         (WebCore::GraphicsLayerCA::setBackgroundColor):
1143         * platform/graphics/win/GraphicsContextCGWin.cpp:
1144         (WebCore::GraphicsContext::drawFocusRing):
1145         * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
1146         (WebCore::ciColor):
1147
1148 2009-03-01  David Levin  <levin@chromium.org>
1149
1150         Reviewed by Alexey Proskuryakov.
1151
1152         Bug 24271: XMLHttpRequest needs js bindings for Workers.
1153         <https://bugs.webkit.org/show_bug.cgi?id=24271>
1154
1155         Tests: http/tests/xmlhttprequest/workers/methods-async.html
1156                http/tests/xmlhttprequest/workers/methods.html
1157
1158         * bindings/js/JSWorkerContextBase.cpp:
1159         (WebCore::JSWorkerContextBase::getOwnPropertySlot):
1160         (jsWorkerContextBaseXMLHttpRequest):
1161         (setJSWorkerContextBaseXMLHttpRequest):
1162         Expose XMLHttpRequest to Workers.
1163
1164         * bindings/js/JSWorkerContextBase.h:
1165
1166         * bindings/js/JSXMLHttpRequestConstructor.cpp:
1167         (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
1168         (WebCore::constructXMLHttpRequest):
1169         (WebCore::JSXMLHttpRequestConstructor::mark):
1170         Removed the dependencies on Document.
1171
1172         * bindings/js/JSXMLHttpRequestConstructor.h:
1173         (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
1174         * dom/EventException.idl:
1175         * dom/EventListener.idl:
1176         Change to have the NoStaticTables attribute since they are used from XHR.
1177
1178         * loader/WorkerThreadableLoader.cpp:
1179         (WebCore::workerContextDidFinishLoading):
1180         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
1181         Fixed identifier to be unsigned long.
1182
1183         * loader/WorkerThreadableLoader.h:
1184         * workers/WorkerThread.cpp:
1185         (WebCore::WorkerThread::workerThread):
1186         Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
1187
1188         * xml/XMLHttpRequestUpload.cpp:
1189
1190         * xml/XMLHttpRequest.idl:
1191         * xml/XMLHttpRequestException.idl:
1192         * xml/XMLHttpRequestProgressEvent.idl:
1193         * xml/XMLHttpRequestUpload.idl:
1194         Change to have the NoStaticTables attribute since they are used from XHR.
1195
1196 2009-03-01  Horia Olaru  <olaru@adobe.com>
1197
1198         Adding manual debugger test cases for bug.
1199
1200         https://bugs.webkit.org/show_bug.cgi?id=21073
1201
1202         Reviewed by Kevin McCullough.
1203
1204         * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
1205         * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
1206         * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
1207         * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
1208         * manual-tests/inspector/resources/loop-statements.js: Added.
1209
1210 2009-03-01  Dan Bernstein  <mitz@apple.com>
1211
1212         Reviewed by Darin Adler.
1213
1214         - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
1215
1216         Test: fast/events/scroll-during-zoom-change.html
1217
1218         * dom/Document.cpp:
1219         (WebCore::Document::recalcStyle): Pause scheduled events during style
1220         reclaculation. Changes to the zoom property result in scroll events
1221         being generated during style recalc, and those events need to be
1222         deferred until the render tree is consistent.
1223         * page/FrameView.cpp:
1224         (WebCore::FrameView::layout): Changed to account for a case in which the
1225         post-layout tasks trigger a nested layout, which reactivates the
1226         post-layout task timer.
1227
1228 2009-03-01  Ross Boucher  <rboucher@gmail.com>
1229
1230         Alphabetically sort scripts in the Script's panel file popup menu.
1231
1232         https://bugs.webkit.org/show_bug.cgi?id=23395
1233
1234         Reviewed by Timothy Hatcher.
1235
1236         * inspector/front-end/ScriptsPanel.js:
1237         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
1238         * inspector/front-end/utilities.js:
1239         (insertionIndexForObjectInListSortedByFunction):
1240         (indexOfObjectInListSortedByFunction):
1241
1242 2009-03-01  Yael Aharon  <yael.aharon@nokia.com>
1243
1244         Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
1245         when creating databases, localStorage or sessionStorage. Changing document.domain
1246         should have no affect on databases, localStorage and sessionStorage in Web Inspector.
1247
1248         https://bugs.webkit.org/show_bug.cgi?id=23844
1249
1250         Reviewed by Timothy Hatcher.
1251
1252         * inspector/InspectorController.cpp:
1253         (WebCore::InspectorController::addDOMStorageScriptResource):
1254         (WebCore::InspectorController::didUseDOMStorage):
1255         * storage/Database.cpp:
1256         (WebCore::Database::openDatabase):
1257
1258 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1259
1260         Reviewed by Holger Freyther.
1261
1262         Avoid leaking errors when reporting GIO errors.
1263
1264         * platform/network/soup/ResourceHandleSoup.cpp:
1265         (WebCore::readCallback):
1266         (WebCore::openCallback):
1267         (WebCore::queryInfoCallback):
1268
1269 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1270
1271         Reviewed by Holger Freyther.
1272
1273         Fixes crash when the GIO backend is given the URI for a directory.
1274
1275         * platform/network/soup/ResourceHandleSoup.cpp:
1276         (WebCore::networkErrorForFile):
1277
1278 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1279
1280         Reviewed by Darin Fisher.
1281
1282         https://bugs.webkit.org/show_bug.cgi?id=24261
1283         Fix V8 custom binding scrubbing error.
1284
1285         Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
1286         Test: traversal/exception-forwarding.html
1287         TesT: traversal/stay-within-root.html
1288
1289         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1290         * bindings/v8/custom/V8NodeIteratorCustom.cpp:
1291         (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
1292         * bindings/v8/custom/V8TreeWalkerCustom.cpp:
1293         (WebCore::toV8): Ditto.
1294
1295 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1296
1297         Reviewed by Darin Fisher.
1298
1299         https://bugs.webkit.org/show_bug.cgi?id=24261
1300         Fix V8 custom binding scrubbing error.
1301
1302         Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
1303
1304         * WebCore.xcodeproj/project.pbxproj:
1305         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1306         (WebCore::cssPropertyName):  Remove dubious checks, left over from
1307             incomplete conversion of parameter from pointer to pass-by-ref.
1308         (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
1309         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
1310
1311 2009-02-28  Xan Lopez  <xan@gnome.org>
1312
1313         Reviewed by Holger Freyther.
1314
1315         https://bugs.webkit.org/show_bug.cgi?id=24263
1316         [GTK] ref ResourceHandle until we are finished with it
1317
1318         Add a ref to the ResourceHandle in startHttp so we can keep it
1319         alive untill all callbacks have been executed, and unref it when
1320         soup tells us it's done with the SoupMessage (in
1321         finishedCallback). Fixes a number of crashes when calling
1322         didReceiveData whould crash because of the handle dying.
1323
1324         * platform/network/soup/ResourceHandleSoup.cpp:
1325         (WebCore::finishedCallback):
1326         (WebCore::ResourceHandle::startHttp):
1327
1328 2009-02-28  Adam Bergkvist <adam.bergkvist@ericsson.com>
1329
1330         Reviewed by Alexey Proskuryakov.
1331
1332         https://bugs.webkit.org/show_bug.cgi?id=24226
1333         [SOUP] HTTP status text is never set
1334
1335         Set HTTP status text to SoupMessage reason_phrase.
1336
1337         * platform/network/soup/ResourceHandleSoup.cpp:
1338         (WebCore::fillResponseFromMessage):
1339
1340 2009-02-28  Dan Bernstein  <mitz@apple.com>
1341
1342         - fix malformed project file
1343
1344         * WebCore.xcodeproj/project.pbxproj:
1345
1346 2009-02-28  Dan Bernstein  <mitz@apple.com>
1347
1348         Reviewed by Oliver Hunt.
1349
1350         - fix https://bugs.webkit.org/show_bug.cgi?id=23848
1351           <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
1352
1353         Test: fast/layers/inline-dirty-z-order-lists.html
1354
1355         * rendering/RenderBox.cpp:
1356         (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
1357         layer's and its stacking context's z-order lists when the layer's
1358         z-index or visibility change from here...
1359         * rendering/RenderBoxModelObject.cpp:
1360         (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
1361         it will apply to RenderInline too.
1362
1363 2009-02-27  Alexey Proskuryakov  <ap@webkit.org>
1364
1365         Reviewed by David Hyatt.
1366
1367         Don't include TextResourceDecoder.h in Document.h
1368
1369         This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
1370         when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
1371
1372         * dom/Document.cpp:
1373         (WebCore::Document::displayStringModifiedByEncoding):
1374         (WebCore::Document::displayBufferModifiedByEncoding):
1375         * dom/Document.h:
1376         * WebCore.base.exp:
1377
1378 2009-02-27  Matt Pennig  <pennig@apple.com>
1379
1380         Reviewed by David Hyatt.
1381
1382         Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
1383         "Fixed elements have 0 as an offsetLeft property"
1384         
1385         Code also brings offsetLeft/Top in full conformance with the spec.
1386         Added two tests, one for fixed-position elements, and one for <html>.
1387         
1388         Tests: fast/dom/Element/fixed-position-offset-parent.html
1389                fast/dom/Element/offsetLeft-offsetTop-html.html
1390
1391         * rendering/RenderBoxModelObject.cpp:
1392         (WebCore::RenderBoxModelObject::offsetLeft):
1393         (WebCore::RenderBoxModelObject::offsetTop):
1394
1395 2009-02-27  Dean Jackson  <dino@apple.com>
1396
1397         Reviewed by Simon Fraser.
1398
1399         renderer()->hasTransform() returns true for elements
1400         with perspective, but no transform, so test for transform
1401         when hit testing. This fixes ASSERT from
1402         https://bugs.webkit.org/show_bug.cgi?id=24252
1403
1404         Test: transforms/no_transform_hit_testing.html
1405
1406         * rendering/RenderLayer.cpp:
1407         (WebCore::RenderLayer::hitTestLayer):
1408
1409 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1410
1411         Reviewed by Darin Fisher.
1412
1413         Fix scrubbing error -- a reversed condition.
1414
1415         * bindings/v8/ScriptValue.h:
1416         (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
1417
1418 2009-02-27  Jian Li  <jianli@chromium.org>
1419
1420         Reviewed by Alexey Proskuryakov.
1421
1422         Add confirmMessageFromWorkerObject to WorkerObjectProxy.
1423         https://bugs.webkit.org/show_bug.cgi?id=24152
1424
1425         * workers/WorkerMessagingProxy.cpp:
1426         (WebCore::MessageWorkerContextTask::performTask):
1427         (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
1428         * workers/WorkerMessagingProxy.h:
1429         * workers/WorkerObjectProxy.h:
1430
1431 2009-02-27  Anders Carlsson  <andersca@apple.com>
1432
1433         Reviewed by David Hyatt.
1434
1435         Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227 
1436         because it leads to assertion failures in the Mac port.
1437         
1438         * platform/graphics/BitmapImage.cpp:
1439         (WebCore::BitmapImage::BitmapImage):
1440         * platform/graphics/BitmapImage.h:
1441         (WebCore::BitmapImage::mayFillWithSolidColor):
1442         * platform/graphics/Image.h:
1443         (WebCore::Image::mayFillWithSolidColor):
1444         * platform/graphics/cairo/ImageCairo.cpp:
1445         (WebCore::BitmapImage::BitmapImage):
1446         * platform/graphics/cg/ImageCG.cpp:
1447         (WebCore::BitmapImage::BitmapImage):
1448         (WebCore::BitmapImage::checkForSolidColor):
1449         * platform/graphics/qt/ImageQt.cpp:
1450         (WebCore::BitmapImage::checkForSolidColor):
1451         * platform/graphics/skia/ImageSkia.cpp:
1452         (WebCore::BitmapImage::checkForSolidColor):
1453         * platform/graphics/wx/ImageWx.cpp:
1454         (WebCore::BitmapImage::checkForSolidColor):
1455
1456 2009-02-27  Adam Barth  <abarth@webkit.org>
1457
1458         Reviewed by Eric Seidel.
1459
1460         https://bugs.webkit.org/show_bug.cgi?id=20249
1461
1462         Add a preference to allow universal access from local URLs to mitigate
1463         some attacks.  Some clients still want to allow this access, so we
1464         expose this as a preference.
1465
1466         * WebCore.base.exp:
1467         * dom/Document.cpp:
1468         (WebCore::Document::initSecurityContext):
1469         * page/SecurityOrigin.cpp:
1470         (WebCore::SecurityOrigin::SecurityOrigin):
1471         * page/Settings.cpp:
1472         (WebCore::Settings::Settings):
1473         (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
1474         * page/Settings.h:
1475         (WebCore::Settings::allowUniversalAccessFromFileUrls):
1476
1477 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1478
1479         Reviewed by Eric Seidel.
1480
1481         https://bugs.webkit.org/show_bug.cgi?id=24229
1482         If an image has no alpha channel there is no reason to use SourceOver.
1483
1484         * platform/graphics/qt/ImageQt.cpp:
1485         (WebCore::Image::drawPattern):
1486         (WebCore::BitmapImage::draw):
1487
1488 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1489
1490         Reviewed by Eric Seidel and Simon Fraser.
1491
1492         https://bugs.webkit.org/show_bug.cgi?id=24227
1493         Ensure that the checkForSolidColor() optimization is correctly triggered
1494         for all cases of drawPattern.  Currently, the optimization was not triggered
1495         when the check had not been previously performed via a request for the
1496         image's NativeImagePtr.
1497
1498         Implement the Qt version of the checkForSolidColor() method.  Combined with
1499         the bug fix this reduces the time it takes to draw a repeating background
1500         of a 1x1 image from ~50msecs to ~0msecs on my machine.
1501
1502         * platform/graphics/BitmapImage.cpp:
1503         (WebCore::BitmapImage::BitmapImage):
1504         * platform/graphics/BitmapImage.h:
1505         (WebCore::BitmapImage::mayFillWithSolidColor):
1506         * platform/graphics/Image.h:
1507         (WebCore::Image::mayFillWithSolidColor):
1508         * platform/graphics/cairo/ImageCairo.cpp:
1509         (WebCore::BitmapImage::BitmapImage):
1510         * platform/graphics/cg/ImageCG.cpp:
1511         (WebCore::BitmapImage::BitmapImage):
1512         (WebCore::BitmapImage::checkForSolidColor):
1513         * platform/graphics/qt/ImageQt.cpp:
1514         (WebCore::BitmapImage::checkForSolidColor):
1515         * platform/graphics/skia/ImageSkia.cpp:
1516         (WebCore::BitmapImage::checkForSolidColor):
1517         * platform/graphics/wx/ImageWx.cpp:
1518         (WebCore::BitmapImage::checkForSolidColor):
1519
1520 2009-02-27  Dirk Schulze  <krit@webkit.org>
1521
1522         Reviewed by Zack Rusin.
1523
1524         Added support for gradients and pattern on Fonts for Qt.
1525
1526         [Qt] gradients and patterns for FontQt
1527         https://bugs.webkit.org/show_bug.cgi?id=24243
1528
1529         * platform/graphics/qt/FontQt.cpp:
1530         (WebCore::Font::drawComplexText):
1531
1532 2009-02-27  Jian Li  <jianli@chromium.org>
1533
1534         Reviewed by Alexey Proskuryakov.
1535
1536         WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
1537         https://bugs.webkit.org/show_bug.cgi?id=24113
1538
1539         * workers/WorkerMessagingProxy.cpp:
1540
1541 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1542
1543         Added a refresh button to storage views.
1544
1545         https://bugs.webkit.org/show_bug.cgi?id=24040
1546
1547         Reviewed by Timothy Hatcher.
1548
1549         * inspector/front-end/DOMStorageItemsView.js:
1550         (WebInspector.DOMStorageItemsView):
1551         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1552         (WebInspector.DOMStorageItemsView.prototype.update):
1553         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
1554         * inspector/front-end/DatabaseTableView.js:
1555         (WebInspector.DatabaseTableView):
1556         (WebInspector.DatabaseTableView.prototype.get statusBarItems):
1557         (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
1558         * inspector/front-end/DatabasesPanel.js:
1559         (WebInspector.DatabasesPanel):
1560         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1561         (WebInspector.DatabasesPanel.prototype.reset):
1562         (WebInspector.DatabasesPanel.prototype.showDatabase):
1563         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1564         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1565         * inspector/front-end/inspector.css:
1566
1567 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1568
1569         Added support for editing/deleting localStorage and sessionStorage items
1570         directly from Web Inspector.
1571
1572         https://bugs.webkit.org/show_bug.cgi?id=23866.
1573
1574         Reviewed by Timothy Hatcher.
1575
1576         * WebCore.vcproj/WebCore.vcproj:
1577         * inspector/front-end/DOMStorageDataGrid.js: Added.
1578         (WebInspector.DOMStorageDataGrid):
1579         (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
1580         (WebInspector.DOMStorageDataGrid.prototype._startEditing):
1581         (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
1582         (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
1583         (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
1584         * inspector/front-end/DOMStorageItemsView.js:
1585         (WebInspector.DOMStorageItemsView):
1586         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1587         (WebInspector.DOMStorageItemsView.prototype.hide):
1588         (WebInspector.DOMStorageItemsView.prototype.update):
1589         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
1590         * inspector/front-end/DatabasesPanel.js:
1591         (WebInspector.DatabasesPanel):
1592         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1593         (WebInspector.DatabasesPanel.prototype.reset):
1594         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1595         (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
1596         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1597         * inspector/front-end/WebKit.qrc:
1598         * inspector/front-end/inspector.css:
1599         * inspector/front-end/inspector.html:
1600
1601 2009-02-26  Brett Wilson  <brettw@chromium.org>
1602
1603         Fix Windows transparency for the Chromium port. Implement a helper
1604         class for handling transparency on Windows. It allows semitransparent
1605         ClearType and semitransparent form controls by making new layers in the
1606         background.
1607
1608         It also replaces the "ThemeHelper" which allows better
1609         scaling and transforms on Windows form controls. In addition to the
1610         functionality that the ThemeHelper did, but additionally handles the
1611         antialiasing properly so that the form controls aren't composited on a
1612         white square.
1613
1614         https://bugs.webkit.org/show_bug.cgi?id=24101
1615
1616         Reviewed by Eric Seidel.
1617
1618         * platform/graphics/chromium/FontChromiumWin.cpp:
1619         (WebCore::):
1620         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
1621         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1622         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
1623         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
1624         (WebCore::Font::drawGlyphs):
1625         * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
1626         * platform/graphics/chromium/ThemeHelperChromiumWin.h:
1627         * platform/graphics/chromium/TransparencyWin.cpp: Added.
1628         (WebCore::):
1629         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
1630         (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
1631         (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
1632         (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
1633         (WebCore::TransparencyWin::TransparencyWin):
1634         (WebCore::TransparencyWin::~TransparencyWin):
1635         (WebCore::TransparencyWin::init):
1636         (WebCore::TransparencyWin::computeLayerSize):
1637         (WebCore::TransparencyWin::setupLayer):
1638         (WebCore::TransparencyWin::setupLayerForNoLayer):
1639         (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
1640         (WebCore::TransparencyWin::setupLayerForTextComposite):
1641         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1642         (WebCore::TransparencyWin::setupTransform):
1643         (WebCore::TransparencyWin::setupTransformForKeepTransform):
1644         (WebCore::TransparencyWin::setupTransformForUntransform):
1645         (WebCore::TransparencyWin::setupTransformForScaleTransform):
1646         (WebCore::TransparencyWin::setTextCompositeColor):
1647         (WebCore::TransparencyWin::initializeNewContext):
1648         (WebCore::TransparencyWin::compositeOpaqueComposite):
1649         (WebCore::TransparencyWin::compositeTextComposite):
1650         (WebCore::TransparencyWin::makeLayerOpaque):
1651         * platform/graphics/chromium/TransparencyWin.h: Added.
1652         (WebCore::TransparencyWin::):
1653         (WebCore::TransparencyWin::context):
1654         (WebCore::TransparencyWin::platformContext):
1655         (WebCore::TransparencyWin::drawRect):
1656         * platform/graphics/skia/GraphicsContextSkia.cpp:
1657         (WebCore::GraphicsContext::endTransparencyLayer):
1658         * platform/graphics/skia/ImageSkia.cpp:
1659         (WebCore::paintSkBitmap):
1660         * rendering/RenderThemeChromiumWin.cpp:
1661         (WebCore::):
1662         (WebCore::RenderThemeChromiumWin::paintButton):
1663         (WebCore::RenderThemeChromiumWin::paintMenuList):
1664         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1665
1666 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1667
1668         Reviewed by Eric Seidel.
1669
1670         https://bugs.webkit.org/show_bug.cgi?id=24211
1671         Add ScheduledAction for V8.
1672
1673         * bindings/v8/ScheduledAction.cpp: Added.
1674         (WebCore::ScheduledAction::ScheduledAction):
1675         (WebCore::ScheduledAction::~ScheduledAction):
1676         (WebCore::ScheduledAction::execute):
1677         * bindings/v8/ScheduledAction.h: Added.
1678         (WebCore::ScheduledAction::ScheduledAction):
1679
1680 2009-02-27  Zack Rusin  <zack@kde.org>
1681
1682         Reviewed by Nikolas Zimmermann.
1683
1684         Qt: be more reasonable about scrolled lines
1685
1686         cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
1687         match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
1688         irritating. so lets scroll vertically by the Qt set number of lines * Qt default
1689         single step scroll
1690
1691         * platform/qt/WheelEventQt.cpp:
1692
1693 2009-02-27  Xan Lopez  <xan@gnome.org>
1694
1695         Rubber-stamped by Alexey Proskuryakov.
1696
1697         https://bugs.webkit.org/show_bug.cgi?id=24222
1698         [GTK] Remove checks for old glib versions
1699
1700         libsoup, which is a hard dependency, needs at least glib 2.15.3,
1701         so remove all glib checks for versions older than that.
1702
1703         * platform/gtk/ContextMenuGtk.cpp:
1704         (WebCore::ContextMenu::ContextMenu):
1705         * platform/gtk/ContextMenuItemGtk.cpp:
1706         (WebCore::ContextMenuItem::setSubMenu):
1707         * platform/gtk/PopupMenuGtk.cpp:
1708         (WebCore::PopupMenu::show):
1709         * platform/gtk/WidgetGtk.cpp:
1710         (WebCore::Widget::retainPlatformWidget):
1711         * platform/network/soup/ResourceHandleSoup.cpp:
1712
1713 2009-02-26  Dirk Schulze  <krit@webkit.org>
1714
1715         Reviewed by Oliver Hunt.
1716
1717         Added support for Gradients and Patterns on filled or stroked Fonts
1718         in Cairo. I also added support for globalAlpha on FontCairo.
1719
1720         [CAIRO] SVG/Canvas fonts miss gradients/pattern support
1721         https://bugs.webkit.org/show_bug.cgi?id=18617
1722
1723         * html/CanvasRenderingContext2D.cpp:
1724         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1725         * platform/graphics/cairo/FontCairo.cpp:
1726         (WebCore::Font::drawGlyphs):
1727
1728 2009-02-26  Stephen White  <senorblanco@chromium.org>
1729
1730         Reviewed by Eric Seidel.
1731
1732         https://bugs.webkit.org/show_bug.cgi?id=23957
1733
1734         Fix for SVG gradient and pattern text for Chromium/skia. 
1735         Added accessors for the fill and stroke gradients to
1736         GraphicsContext.  Changed the paintSkiaText function to take a
1737         GraphicsContext, so we can check for gradients/patterns. 
1738         Changed the skiaDrawText function to set the SkPaint shader
1739         correctly, and to scale up the gradient shader matrix to
1740         encompass the entire text string.  Also offset each glyph
1741         separately, rather than transforming the canvas, so that the
1742         gradient/pattern stays fixed relative to the text origin.
1743
1744         * platform/graphics/GraphicsContext.cpp:
1745         (WebCore::GraphicsContext::getFillGradient):
1746         (WebCore::GraphicsContext::getStrokeGradient):
1747         (WebCore::GraphicsContext::getFillPattern):
1748         (WebCore::GraphicsContext::getStrokePattern):
1749         * platform/graphics/GraphicsContext.h:
1750         * platform/graphics/chromium/FontChromiumWin.cpp:
1751         (WebCore::Font::drawGlyphs):
1752         * platform/graphics/chromium/UniscribeHelper.cpp:
1753         (WebCore::UniscribeHelper::draw):
1754         * platform/graphics/skia/SkiaFontWin.cpp:
1755         (WebCore::windowsCanHandleTextDrawing):
1756         (WebCore::skiaDrawText):
1757         (WebCore::paintSkiaText):
1758         * platform/graphics/skia/SkiaFontWin.h:
1759
1760 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1761
1762         Reviewed by Eric Seidel.
1763
1764         https://bugs.webkit.org/show_bug.cgi?id=24208
1765         Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
1766
1767         * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
1768         (WebCore::ACCESSOR_GETTER):
1769         (WebCore::CALLBACK_FUNC_DECL):
1770         * bindings/v8/custom/V8DocumentCustom.cpp: Added.
1771         (WebCore::CALLBACK_FUNC_DECL):
1772         * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
1773         (WebCore::ACCESSOR_GETTER):
1774         * bindings/v8/custom/V8NodeCustom.cpp: Added.
1775         (WebCore::CALLBACK_FUNC_DECL):
1776
1777 2009-02-26  Gustavo Noronha Silva  <gns@gnome.org>
1778
1779         Unreviewed build fix for building with GNOME Keyring enabled.
1780
1781         * platform/network/soup/webkit-soup-auth-dialog.c:
1782         (show_auth_dialog):
1783
1784 2009-02-26  Xan Lopez  <xan@gnome.org>
1785
1786         Reviewed by Holger Freyther.
1787
1788         https://bugs.webkit.org/show_bug.cgi?id=16947
1789         [GTK] Missing HTTP Auth challenge
1790
1791         Add HTTP authentication dialog with optional GNOME Keyring
1792         storage.
1793
1794         * GNUmakefile.am:
1795         * platform/network/ResourceHandleInternal.h:
1796         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1797         * platform/network/soup/ResourceHandleSoup.cpp:
1798         (WebCore::currentToplevelCallback):
1799         (WebCore::ResourceHandle::startHttp):
1800         (WebCore::ResourceHandle::start):
1801         * platform/network/soup/webkit-soup-auth-dialog.c: Added.
1802         (webkit_soup_auth_dialog_class_init):
1803         (webkit_soup_auth_dialog_init):
1804         (webkit_soup_auth_dialog_session_feature_init):
1805         (free_authData):
1806         (set_password_callback):
1807         (response_callback):
1808         (show_auth_dialog):
1809         (find_password_callback):
1810         (session_authenticate):
1811         (attach):
1812         * platform/network/soup/webkit-soup-auth-dialog.h: Added.
1813
1814 2009-02-25  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
1815
1816         Reviewed by Dave Hyatt.
1817
1818         After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
1819         svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
1820         started failing because Ojan's new code was now *correctly* calling through to
1821         SVG asking for the closest text offset in the last line box, instead of
1822         just returning the offset at the end of the last line box when clicking below a box.
1823
1824         But!  The SVG code was wrong, in that it returned the character offset of the last
1825         character when you asked for a character offset after the end of the box, instead
1826         it should return the offset *after* the last character.  This patch fixes
1827         that behavior by reordering the last two clauses in svgCharacterHitsPosition.
1828
1829         The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
1830         to document what's wrong.  I've also cleaned up the code a bit so it's clearer
1831         what it is doing (which also makes more obvious what's wrong with it).
1832
1833         * rendering/RenderSVGInlineText.cpp:
1834         (WebCore::RenderSVGInlineText::positionForCoordinates):
1835         * rendering/SVGInlineTextBox.cpp:
1836         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
1837         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
1838         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
1839         (WebCore::SVGInlineTextBox::closestCharacterToPosition):
1840         (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
1841
1842 2009-02-26  Darin Fisher  <darin@chromium.org>
1843
1844         Reviewed by Eric Seidel.
1845
1846         Minor cleanup of ChromiumBridge:
1847         Removing unused matchesMIMEType method and s/Javascript/JavaScript/
1848
1849         * platform/chromium/ChromiumBridge.h:
1850         * platform/chromium/MimeTypeRegistryChromium.cpp:
1851         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
1852         (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
1853         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
1854
1855 2009-02-26  David Hyatt  <hyatt@apple.com>
1856
1857         Reviewed by Sam Weinig
1858
1859         Fix text-bottom vertical alignment.  It was incorrectly aligning the bottom of the descent instead of including
1860         the line-height below the descent.
1861
1862         Added fast/inline/vertical-align-text-bottom.html
1863
1864         * rendering/RenderBoxModelObject.cpp:
1865         (WebCore::RenderBoxModelObject::verticalPosition):
1866
1867 2009-02-26  Dirk Schulze  <krit@webkit.org>
1868
1869         Reviewed by Eric Seidel.
1870
1871         Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
1872         ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
1873         just to implement this three methods to support SVG Masking now.
1874  
1875         Make SVG Masking platform aware
1876         https://bugs.webkit.org/show_bug.cgi?id=19243
1877
1878         * GNUmakefile.am:
1879         * WebCore.pro:
1880         * WebCore.vcproj/WebCore.vcproj:
1881         * WebCore.xcodeproj/project.pbxproj:
1882         * svg/graphics/SVGResourceMasker.cpp:
1883         (WebCore::SVGResourceMasker::applyMask):
1884         * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
1885         * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
1886         * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
1887         * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
1888         * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
1889
1890 2009-02-26  Yong Li  <yong.li@torchmobile.com>
1891
1892         Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
1893
1894         Test: http/tests/misc/slow-preload-cancel.html
1895
1896         https://bugs.webkit.org/show_bug.cgi?id=24133
1897         Clear all pending preloads in the DocLoader object when we decide to
1898         cancel its all requests.
1899
1900         * loader/DocLoader.cpp:
1901         (WebCore::DocLoader::clearPendingPreloads):
1902         * loader/DocLoader.h:
1903         * loader/loader.cpp:
1904         (WebCore::Loader::cancelRequests):
1905
1906 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1907
1908         Reviewed by Eric Seidel.
1909
1910         https://bugs.webkit.org/show_bug.cgi?id=24182
1911         Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
1912
1913         * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
1914         (WebCore::CALLBACK_FUNC_DECL):
1915         * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
1916         (WebCore::toV8):
1917         (WebCore::CALLBACK_FUNC_DECL):
1918         * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
1919         (WebCore::toV8):
1920         (WebCore::CALLBACK_FUNC_DECL):
1921
1922 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
1923
1924         Reviewed by Darin Adler.
1925
1926         https://bugs.webkit.org/show_bug.cgi?id=23500
1927         KURL::parse() incorrectly compares its result to original string
1928
1929         * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
1930
1931 2009-02-26  Ojan Vafai  <ojan@chromium.org>
1932
1933         Reviewed by Kevin McCullough.
1934
1935         Manual test for inspector node highlighting.
1936
1937         * manual-tests/inspector/highlight-nodes.html: Added.
1938
1939 2009-02-16  Anantanarayanan Iyengar  <ananta@chromium.org>
1940
1941         Reviewed by Darin Fisher.
1942
1943         https://bugs.webkit.org/show_bug.cgi?id=23973
1944         ScrollView::scrollContents can be invoked during view shutdown.  In
1945         this scenario the FrameView::hostWindow method can return NULL, which
1946         indicates that the frame/page is being destroyed. This causes a crash
1947         when we try to dereference a NULL hostWindow pointer.  Fix is to add a
1948         NULL check for this.  
1949
1950         * platform/ScrollView.cpp:
1951         (WebCore::ScrollView::scrollContents):
1952
1953 2009-02-26  Rahul Kuchhal  <kuchhal@chromium.org>
1954
1955         Reviewed by Dave Hyatt.
1956
1957         https://bugs.webkit.org/show_bug.cgi?id=24003
1958         Fix a crash caused by unsafe type conversion.
1959
1960         Test: fast/block/positioning/absolute-in-inline-rtl-4.html
1961
1962         * rendering/RenderBox.cpp:
1963         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
1964
1965 2009-02-26  Ojan Vafai  <ojan@chromium.org>
1966
1967         Reviewed by Adam Roben.
1968
1969         https://bugs.webkit.org/show_bug.cgi?id=24202
1970         Have drawNodeHighlight clip instead of clearing. This makes it work for
1971         both Safari and Chromium since Chromium draws the inspector highlighting
1972         in the same buffer as the page.
1973
1974         * inspector/InspectorController.cpp:
1975         (WebCore::quadToPath):
1976         (WebCore::drawOutlinedQuad):
1977         (WebCore::drawOutlinedQuadWithClip):
1978         (WebCore::drawHighlightForBox):
1979
1980 2009-02-26  David Hyatt  <hyatt@apple.com>
1981
1982         Reviewed by Dan Bernstein & Darin Adler
1983
1984         Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
1985         
1986         Added fast/inline/inline-continuation-borders.html
1987
1988         * rendering/InlineFlowBox.cpp:
1989         (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
1990
1991 2009-02-26  Simon Fraser  <simon.fraser@apple.com>
1992
1993         Build fix, no review.
1994         
1995         Try to fix the wx build after r41218.
1996
1997         * WebCoreSources.bkl:
1998
1999 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
2000
2001         Reviewed by Darin Adler.
2002
2003         https://bugs.webkit.org/show_bug.cgi?id=19527
2004         ASSERTION FAILED: containerA && containerB
2005
2006         Test: fast/dom/Range/bug-19527.html
2007
2008         * dom/Range.cpp:
2009         (WebCore::Range::isPointInRange):
2010         (WebCore::Range::comparePoint):
2011         Bring the behavior in line with current Firefox, making it impossible for these methods
2012         to pass a null container to compareBoundaryPoints().
2013
2014 2009-02-26  Jonathon Jongsma  <jonathon@quotidian.org>
2015
2016         Reviewed by Holger Freyther.
2017
2018         https://bugs.webkit.org/show_bug.cgi?id=20358
2019
2020         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
2021         (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
2022         should set the computed size rather than the specified size, otherwise
2023         the caps just get rendered normal size.
2024
2025 2009-02-26  Benjamin Meyer  <benjamin.meyer@torchmobile.com>
2026
2027         Reviewed by George Staikos.
2028
2029         https://bugs.webkit.org/show_bug.cgi?id=24062
2030         QNetworkCookieJar expects the url and not the policy url.  Sending the
2031         policy url will cause QNetworkCookieJar to behave incorrectly.  One
2032         example would be a cookie that does not have a path or domain.
2033         QNetworkCookieJar will use the url it is given to fill in default values.
2034         This allows setting cookies on the url of the main frame from an iFrame
2035         when the cookie should be set on the url of the iFrame.
2036
2037         Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
2038
2039         * platform/qt/CookieJarQt.cpp:
2040         (WebCore::setCookies):
2041
2042 2009-02-26  Charles Wei  <charles.wei@torchmobile.com.cn>
2043
2044         Reviewed by George Staikos.
2045
2046         make WebKit/Qt compile with SVG disabled
2047
2048         * WebCore.pro:
2049         * platform/graphics/qt/FontPlatformDataQt.cpp:
2050
2051 2009-02-25  Gustavo Noronha Silva  <gns@gnome.org>
2052
2053         Unreviewed build fix. Add WebCore/workers to the list of paths
2054         searched by the bindings generator perl script.
2055
2056         * GNUmakefile.am:
2057
2058 2009-02-25  Sam Weinig  <sam@webkit.org>
2059
2060         Reviewed by Geoffrey Garen.
2061
2062         Add canvas to the list of RenderObjects that can mark a page as
2063         visually not empty.
2064
2065         * rendering/RenderHTMLCanvas.cpp:
2066         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
2067
2068 2009-02-25  Eric Carlson  <eric.carlson@apple.com>
2069
2070         Reviewed by Dave Hyatt.
2071
2072         * rendering/RenderBox.cpp:
2073         (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
2074         as RenderMedia with controls always has a layer.
2075
2076 2009-02-25  Dan Bernstein  <mitz@apple.com>
2077
2078         Reviewed by Simon Fraser.
2079
2080         - fix https://bugs.webkit.org/show_bug.cgi?id=24130
2081           <rdar://problem/6618196> Paint very slow when horizontally resizing
2082
2083         Test: fast/gradients/background-clipped.html
2084
2085         * rendering/RenderBoxModelObject.cpp:
2086         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
2087         destination rectangle passed to drawTiledImage() with the dirty
2088         rectangle. This makes it more likely for the destination rect to be
2089         contained in a single tile rect, which results in a faster code path
2090         being taken down the road (just drawing a single tile instead of
2091         tiling).
2092
2093 2009-02-25  Ojan Vafai  <ojan@chromium.org>
2094
2095         Reviewed by Eric Seidel.
2096
2097         Fix test regressions from positionForCoordinates patch.
2098         https://bugs.webkit.org/show_bug.cgi?id=24148
2099
2100         * rendering/RenderBlock.cpp:
2101         (WebCore::positionForPointWithInlineChildren):
2102         Remove ASSERT that placeholder text codepath is hitting.
2103
2104 2009-02-25  Chris Fleizach  <cfleizach@apple.com>
2105
2106         Reviewed by Beth Dakin.
2107
2108         Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
2109         https://bugs.webkit.org/show_bug.cgi?id=24143
2110
2111         When an AX object is marked dirty, do not create AX elements while going up the parent chain.
2112         Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
2113         Make sure the AXObjectWrapper's have an object before calling them
2114         In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
2115
2116         Test: platform/mac-snowleopard/accessibility/table-updating.html
2117
2118         * WebCore.base.exp:
2119         * page/AXObjectCache.cpp:
2120         (WebCore::AXObjectCache::~AXObjectCache):
2121         (WebCore::AXObjectCache::get):
2122         (WebCore::AXObjectCache::getOrCreate):
2123         (WebCore::AXObjectCache::removeAXID):
2124         (WebCore::AXObjectCache::handleActiveDescendantChanged):
2125         (WebCore::AXObjectCache::handleAriaRoleChanged):
2126         * page/AXObjectCache.h:
2127         * page/AccessibilityImageMapLink.cpp:
2128         (WebCore::AccessibilityImageMapLink::parentObject):
2129         * page/AccessibilityListBox.cpp:
2130         (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
2131         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
2132         * page/AccessibilityListBoxOption.cpp:
2133         (WebCore::AccessibilityListBoxOption::elementRect):
2134         (WebCore::AccessibilityListBoxOption::parentObject):
2135         * page/AccessibilityObject.cpp:
2136         (WebCore::AccessibilityObject::detach):
2137         (WebCore::AccessibilityObject::parentObjectIfExists):
2138         (WebCore::replacedNodeNeedsCharacter):
2139         (WebCore::AccessibilityObject::accessibilityObjectForPosition):
2140         * page/AccessibilityObject.h:
2141         * page/AccessibilityRenderObject.cpp:
2142         (WebCore::AccessibilityRenderObject::firstChild):
2143         (WebCore::AccessibilityRenderObject::lastChild):
2144         (WebCore::AccessibilityRenderObject::previousSibling):
2145         (WebCore::AccessibilityRenderObject::nextSibling):
2146         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
2147         (WebCore::AccessibilityRenderObject::parentObject):
2148         (WebCore::AccessibilityRenderObject::isAttachment):
2149         (WebCore::AccessibilityRenderObject::headingLevel):
2150         (WebCore::AccessibilityRenderObject::anchorElement):
2151         (WebCore::AccessibilityRenderObject::menuForMenuButton):
2152         (WebCore::AccessibilityRenderObject::menuButtonForMenu):
2153         (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
2154         (WebCore::AccessibilityRenderObject::internalLinkElement):
2155         (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
2156         (WebCore::AccessibilityRenderObject::titleUIElement):
2157         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2158         (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
2159         (WebCore::AccessibilityRenderObject::getDocumentLinks):
2160         (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
2161         (WebCore::AccessibilityRenderObject::focusedUIElement):
2162         (WebCore::AccessibilityRenderObject::activeDescendant):
2163         (WebCore::AccessibilityRenderObject::observableObject):
2164         (WebCore::AccessibilityRenderObject::childrenChanged):
2165         (WebCore::AccessibilityRenderObject::addChildren):
2166         * page/AccessibilityRenderObject.h:
2167         (WebCore::AccessibilityRenderObject::setRenderObject):
2168         * page/AccessibilityTable.cpp:
2169         (WebCore::AccessibilityTable::addChildren):
2170         (WebCore::AccessibilityTable::headerContainer):
2171         (WebCore::AccessibilityTable::cellForColumnAndRow):
2172         * page/AccessibilityTableCell.cpp:
2173         (WebCore::AccessibilityTableCell::isTableCell):
2174         (WebCore::AccessibilityTableCell::titleUIElement):
2175         * page/AccessibilityTableColumn.cpp:
2176         (WebCore::AccessibilityTableColumn::headerObjectForSection):
2177         * page/AccessibilityTableRow.cpp:
2178         (WebCore::AccessibilityTableRow::isTableRow):
2179         * page/gtk/AccessibilityObjectWrapperAtk.cpp:
2180         * page/mac/AXObjectCacheMac.mm:
2181         (WebCore::AXObjectCache::postNotification):
2182         (WebCore::AXObjectCache::postNotificationToElement):
2183         * page/mac/AccessibilityObjectWrapper.mm:
2184         (textMarkerForVisiblePosition):
2185         (AXLinkElementForNode):
2186         (nsStringForReplacedNode):
2187         (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
2188         (-[AccessibilityObjectWrapper accessibilityActionNames]):
2189         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2190         (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
2191         (-[AccessibilityObjectWrapper accessibilityHitTest:]):
2192         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
2193         (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
2194         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
2195         (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
2196         (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
2197         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
2198         (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
2199         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
2200         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
2201         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
2202
2203 2009-02-25  Beth Dakin  <bdakin@apple.com>
2204
2205         Reviewed by Geoff Garen.
2206
2207         Re-working of <rdar://problem/6487249> repro crash in 
2208         WebCore::CSSParser::parseFillImage copying entire contents of this 
2209         page
2210         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2211
2212         Fixes a bunch of layout test failures I caused!
2213
2214         * css/CSSParser.cpp:
2215         (WebCore::CSSParser::parseValue):
2216         (WebCore::CSSParser::parseContent):
2217         (WebCore::CSSParser::parseFillImage):
2218         (WebCore::CSSParser::parseFontFaceSrc):
2219         (WebCore::CSSParser::parseBorderImage):
2220
2221 2009-02-25  Dimitri Glazkov  <dglazkov@chromium.org>
2222
2223         Reviewed by Eric Seidel.
2224
2225         https://bugs.webkit.org/show_bug.cgi?id=24174
2226         Add more V8 custom bindings.
2227
2228         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
2229         (WebCore::hasCSSPropertyNamePrefix):
2230         (WebCore::cssPropertyName):
2231         (WebCore::NAMED_PROPERTY_GETTER):
2232         (WebCore::NAMED_PROPERTY_SETTER):
2233         * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
2234         (WebCore::INDEXED_PROPERTY_GETTER):
2235         (WebCore::CALLBACK_FUNC_DECL):
2236         * bindings/v8/custom/V8EventCustom.cpp: Added.
2237         (WebCore::ACCESSOR_SETTER):
2238         (WebCore::ACCESSOR_GETTER):
2239         * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
2240         (WebCore::NAMED_PROPERTY_DELETER):
2241         (WebCore::NAMED_PROPERTY_SETTER):
2242         (WebCore::NAMED_PROPERTY_GETTER):
2243         * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
2244         (WebCore::NAMED_PROPERTY_GETTER):
2245         * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
2246         (WebCore::INDEXED_PROPERTY_GETTER):
2247         (WebCore::NAMED_PROPERTY_GETTER):
2248         * bindings/v8/custom/V8NodeListCustom.cpp: Added.
2249         (WebCore::NAMED_PROPERTY_GETTER):
2250         * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
2251         (WebCore::NAMED_PROPERTY_GETTER):
2252
2253 2009-02-25  Scott Violet  <sky@google.com>
2254
2255         Reviewed by Dave Hyatt.
2256
2257         https://bugs.webkit.org/show_bug.cgi?id=24171
2258         Provides a RenderTheme method for getting the scroll bar size and
2259         changes RenderListBox to use it. RenderTheme returns a size of regular,
2260         and Mac's override to return small. Changes ScrollbarThemeChromium to
2261         use the scrollbarsize of the scrollbar when getting the size
2262         instead of passing in no-args.
2263
2264         * platform/chromium/ScrollbarThemeChromium.cpp:
2265         (WebCore::ScrollbarThemeChromium::trackRect):
2266         (WebCore::ScrollbarThemeChromium::buttonSize):
2267         * rendering/RenderListBox.cpp:
2268         (WebCore::RenderListBox::createScrollbar):
2269         * rendering/RenderTheme.h:
2270         (WebCore::RenderTheme::scrollbarControlSizeForPart):
2271         * rendering/RenderThemeChromiumMac.h:
2272         (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
2273         * rendering/RenderThemeMac.h:
2274         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
2275
2276 2009-02-25  Beth Dakin  <bdakin@apple.com>
2277
2278         Reviewed by Darin Adler.
2279
2280         Fix for <rdar://problem/6487249> repro crash in 
2281         WebCore::CSSParser::parseFillImage copying entire contents of this 
2282         page
2283         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2284
2285         * css/CSSParser.cpp:
2286         (WebCore::CSSParser::parseValue): Null-check m_styleSheet
2287
2288 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
2289
2290         Fix the Qt build.
2291
2292         * WebCore.pro:
2293
2294 2009-02-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2295
2296         Gtk build fix. Not reviewed.
2297
2298         Add files to the build per r41218.
2299         Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp
2300
2301         * GNUmakefile.am:
2302         * page/DOMWindow.cpp:
2303
2304 2009-02-25  Zan Dobersek  <zandobersek@gmail.com>
2305
2306         Reviewed by Alexey Proskuryakov.
2307
2308         https://bugs.webkit.org/show_bug.cgi?id=24043
2309         When faced with URLs with unsupported protocol on Gtk port,
2310         report the error through an idle function and return true, so
2311         a proper resource handle is created.
2312
2313         * platform/network/soup/ResourceHandleSoup.cpp:
2314         (WebCore::reportUnknownProtocolError):
2315         (WebCore::ResourceHandle::start):
2316
2317 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2318
2319         Windows build fix.
2320         Use struct to forward declare ResourceRequest.
2321
2322         * history/HistoryItem.h:
2323         * inspector/InspectorController.h:
2324         * loader/DocumentThreadableLoader.h:
2325         * loader/FrameLoaderClient.h:
2326         * loader/MainResourceLoader.h:
2327         * loader/SubresourceLoader.h:
2328         * loader/SubresourceLoaderClient.h:
2329         * loader/ThreadableLoader.h:
2330         * loader/WorkerThreadableLoader.h:
2331         * platform/CrossThreadCopier.h:
2332         * platform/network/ResourceHandle.h:
2333         * platform/network/ResourceHandleClient.h:
2334         * platform/network/ResourceRequestBase.h:
2335         * platform/network/cf/ResourceRequestCFNet.h:
2336         * xml/XMLHttpRequest.h:
2337
2338 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2339
2340         Partial Windows build fix.
2341         
2342         * DerivedSources.cpp:
2343         * WebCore.vcproj/WebCore.vcproj:
2344
2345 2009-02-25  Dirk Schulze  <krit@webkit.org>
2346
2347         Reviewed by Oliver Hunt.
2348
2349         Ported arcTo to Qt. Qt has no native support for arcTo. This changes
2350         calculate the behavior of arcTo and draws it with lineTo and arc.
2351
2352         [QT] implement Canvas arcTo
2353         https://bugs.webkit.org/show_bug.cgi?id=23873
2354
2355         * platform/graphics/qt/PathQt.cpp:
2356         (WebCore::Path::addArcTo):
2357
2358 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
2359
2360         Reviewed by Dan Bernstein
2361
2362         Remove idl files from Resources, and sort.
2363         
2364         * WebCore.xcodeproj/project.pbxproj:
2365
2366 2009-02-25  Chris Marrin  <cmarrin@apple.com>
2367
2368         Reviewed by Simon Fraser.
2369
2370         https://bugs.webkit.org/show_bug.cgi?id=23943
2371
2372         Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
2373         the window object. Also added WebKitPoint object, which is passed in and out
2374         of these functions.
2375
2376         Test: fast/dom/Window/webkitConvertPoint.html
2377
2378         * DerivedSources.make:
2379         * WebCore.pro:
2380         * WebCore.vcproj/WebCore.vcproj:
2381         * WebCore.xcodeproj/project.pbxproj:
2382         * WebCoreSources.bkl:
2383         * bindings/js/JSDOMWindowBase.cpp:
2384         (jsDOMWindowBaseWebKitPoint):
2385         (setJSDOMWindowBaseWebKitPoint):
2386         * bindings/js/JSWebKitPointConstructor.cpp: Added.
2387         (WebCore::):
2388         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
2389         (WebCore::constructWebKitPoint):
2390         (WebCore::JSWebKitPointConstructor::getConstructData):
2391         * bindings/js/JSWebKitPointConstructor.h: Added.
2392         (WebCore::JSWebKitPointConstructor::classInfo):
2393         * dom/Node.cpp:
2394         (WebCore::Node::convertToPage):
2395         (WebCore::Node::convertFromPage):
2396         * dom/Node.h:
2397         * page/DOMWindow.cpp:
2398         (WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
2399         (WebCore::DOMWindow::webkitConvertPointFromPageToNode):
2400         * page/DOMWindow.h:
2401         * page/DOMWindow.idl:
2402         * page/WebKitPoint.h: Added.
2403         (WebCore::WebKitPoint::create):
2404         (WebCore::WebKitPoint::x):
2405         (WebCore::WebKitPoint::y):
2406         (WebCore::WebKitPoint::setX):
2407         (WebCore::WebKitPoint::setY):
2408         (WebCore::WebKitPoint::WebKitPoint):
2409         * page/WebKitPoint.idl: Added.
2410
2411 2009-02-25  Jian Li  <jianli@chromium.org>
2412
2413         Reviewed by Alexey Proskuryakov.
2414
2415         Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
2416         https://bugs.webkit.org/show_bug.cgi?id=24145
2417
2418         * platform/CrossThreadCopier.cpp:
2419         * platform/CrossThreadCopier.h:
2420
2421 2009-02-25  David Levin  <levin@chromium.org>
2422
2423         Reviewed by Alexey Proskuryakov.
2424
2425         Bug 23688: ThreadableLoader needs a sync implementation for Workers.
2426         <https://bugs.webkit.org/show_bug.cgi?id=23688>
2427
2428         No observable change in behavior, so no test.
2429
2430         * loader/ThreadableLoader.cpp:
2431         (WebCore::ThreadableLoader::loadResourceSynchronously):
2432         * loader/ThreadableLoaderClientWrapper.h:
2433         (WebCore::ThreadableLoaderClientWrapper::clearClient):
2434         (WebCore::ThreadableLoaderClientWrapper::done):
2435         (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
2436         (WebCore::ThreadableLoaderClientWrapper::didFail):
2437         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
2438         (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
2439         Expose whether the loader is done (based on what callbacks were done).
2440
2441         * loader/WorkerThreadableLoader.cpp:
2442         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
2443         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
2444         Each loader is given its own mode so that only its callbacks get through the run loop.
2445
2446         The xhr spec says that the readystatechange events are synchronous, so in the case of a
2447         nested sync xhr no readystatechange events should be fired for the outer xhr.
2448
2449         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
2450
2451         * loader/WorkerThreadableLoader.h:
2452         (WebCore::WorkerThreadableLoader::create):
2453         (WebCore::WorkerThreadableLoader::done):
2454
2455         * workers/WorkerRunLoop.cpp:
2456         (WebCore::WorkerRunLoop::WorkerRunLoop):
2457         * workers/WorkerRunLoop.h:
2458         (WebCore::WorkerRunLoop::createUniqueId):
2459         Simple method to create a uniqueId on demand with respect to the run loop.
2460
2461         * workers/WorkerThread.h:
2462
2463 2009-02-25  David Levin  <levin@chromium.org>
2464
2465         Reviewed by Alexey Proskuryakov.
2466
2467         Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
2468         <https://bugs.webkit.org/show_bug.cgi?id=24089>
2469
2470         Make threadable loader callbacks to happen during the sync load call.
2471
2472         Changes the behavior of sync xhr for insecure redirects in two ways:
2473         + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
2474         + Throws a network exception which is what other browsers do and what the spec
2475         says to do (http://www.w3.org/TR/XMLHttpRequest/).
2476
2477         * loader/DocumentThreadableLoader.cpp:
2478         (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
2479         * loader/DocumentThreadableLoader.h:
2480         * loader/ThreadableLoader.cpp:
2481         (WebCore::ThreadableLoader::loadResourceSynchronously):
2482         * loader/ThreadableLoader.h:
2483         * xml/XMLHttpRequest.cpp:
2484         (WebCore::XMLHttpRequest::XMLHttpRequest):
2485         (WebCore::XMLHttpRequest::loadRequestSynchronously):
2486         (WebCore::XMLHttpRequest::loadRequestAsynchronously):
2487         (WebCore::XMLHttpRequest::didFail):
2488         (WebCore::XMLHttpRequest::didFailRedirectCheck):
2489         * xml/XMLHttpRequest.h:
2490
2491 2009-02-24  Chris Marrin  <cmarrin@apple.com>
2492
2493         Reviewed by David Hyatt.
2494
2495         https://bugs.webkit.org/show_bug.cgi?id=23368
2496
2497         Added logic to correctly hit test accelerated layers.
2498
2499         Tests: animations/animation-hit-test-transform.html
2500                animations/animation-hit-test.html
2501                transitions/transition-hit-test-transform.html
2502                transitions/transition-hit-test.html
2503
2504         * page/animation/KeyframeAnimation.cpp:
2505         (WebCore::KeyframeAnimation::animate):
2506         * rendering/RenderLayer.cpp:
2507         (WebCore::RenderLayer::hitTestLayer):
2508         (WebCore::RenderLayer::updateClipRects):
2509         * rendering/RenderLayerBacking.cpp:
2510         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2511
2512 2009-02-25  Alexey Proskuryakov  <ap@webkit.org>
2513
2514         Reviewed by Darin Adler.
2515
2516         https://bugs.webkit.org/show_bug.cgi?id=24067
2517         REGRESSION: Crash in WebCore::Document::initSecurityContext
2518
2519         The crash started to happen when we removed a check for frame->document() being null.
2520         However, the original document shouldn't be null here, because it is needed to alias
2521         security origins. So, this patch fixes the crash by correcting security origin behavior.
2522
2523         Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
2524         This tests for not crashing, and for inheriting the domain from the document being replaced.
2525         Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
2526         domain to remove a prefix from.
2527
2528         * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
2529         clearing the frame, so that Document::initSecurityContext() could access the old one.
2530
2531 2009-02-25  Jay Campan  <jcampan@google.com>
2532
2533         Reviewed by Darin Fisher.
2534
2535         https://bugs.webkit.org/show_bug.cgi?id=24066
2536
2537         Items in drop-downs were not painted correctly.  Makes sure the
2538         PopupListBox invalidates in the coordinates of the window as this is
2539         FramelessScrollView::invalidateRect paints to.
2540
2541         * platform/chromium/PopupMenuChromium.cpp:
2542         (WebCore::PopupListBox::invalidateRow):
2543
2544 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2545
2546         Reviewed by Anders Carlsson
2547
2548         https://bugs.webkit.org/show_bug.cgi?id=15081
2549         
2550         Make display:none work for applet, emebed and object elements
2551         by calling rendererIsNeeded() on superclasses.
2552
2553         Tests: fast/replaced/applet-display-none.html
2554                fast/replaced/embed-display-none.html
2555                fast/replaced/object-display-none.html
2556
2557         * html/HTMLAppletElement.cpp:
2558         (WebCore::HTMLAppletElement::rendererIsNeeded):
2559         * html/HTMLElement.cpp:
2560         (WebCore::HTMLElement::rendererIsNeeded):
2561         * html/HTMLEmbedElement.cpp:
2562         (WebCore::HTMLEmbedElement::rendererIsNeeded):
2563         * html/HTMLObjectElement.cpp:
2564         (WebCore::HTMLObjectElement::rendererIsNeeded):
2565
2566 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2567
2568         Reviewed by Dave Hyatt
2569
2570         https://bugs.webkit.org/show_bug.cgi?id=24137
2571         
2572         Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
2573         taking perspective and transform-style: preserve-3d into account.
2574         
2575         In order to support transform-style: preserve-3d, which keeps elements in a
2576         3d space, we have to carry along an accumulated matrix in TransformState.
2577         We also need to apply the perspective from the parent, if any, with the
2578         appropriate origin.
2579
2580         * GNUmakefile.am:
2581         * WebCore.base.exp:
2582         * WebCore.pro:
2583         * WebCore.scons:
2584         * WebCore.vcproj/WebCore.vcproj:
2585         * WebCore.xcodeproj/project.pbxproj:
2586         * WebCoreSources.bkl:
2587         * css/CSSComputedStyleDeclaration.cpp:
2588         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2589         * platform/graphics/transforms/TransformationMatrix.cpp:
2590         (WebCore::TransformationMatrix::translate):
2591         (WebCore::TransformationMatrix::translate3d):
2592         (WebCore::TransformationMatrix::translateRight3d):
2593         * platform/graphics/transforms/TransformationMatrix.h:
2594         * rendering/RenderBox.cpp:
2595         (WebCore::RenderBox::mapLocalToAbsolutePoint):
2596         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
2597         * rendering/RenderBox.h:
2598         * rendering/RenderLayer.cpp:
2599         (WebCore::RenderLayer::updateTransform):
2600         (WebCore::RenderLayer::perspectiveTransform):
2601         (WebCore::RenderLayer::perspectiveOrigin):
2602         * rendering/RenderLayer.h:
2603         * rendering/RenderLayerBacking.cpp:
2604         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2605         * rendering/RenderLayerCompositor.cpp:
2606         (WebCore::requiresCompositingLayerForTransform):
2607         (WebCore::RenderLayerCompositor::layerHas3DContent):
2608         * rendering/RenderObject.cpp:
2609         (WebCore::RenderObject::localToAbsolute):
2610         (WebCore::RenderObject::absoluteToLocal):
2611         (WebCore::RenderObject::mapLocalToAbsolutePoint):
2612         (WebCore::RenderObject::mapAbsoluteToLocalPoint):
2613         * rendering/RenderObject.h:
2614         * rendering/RenderTableCell.cpp:
2615         (WebCore::RenderTableCell::mapLocalToAbsolutePoint):
2616         (WebCore::RenderTableCell::mapAbsoluteToLocalPoint):
2617         * rendering/RenderTableCell.h:
2618         * rendering/RenderView.cpp:
2619         (WebCore::RenderView::mapLocalToAbsolutePoint):
2620         (WebCore::RenderView::mapAbsoluteToLocalPoint):
2621         * rendering/RenderView.h:
2622         * rendering/TransformState.cpp: Added.
2623         (WebCore::TransformState::move):
2624         (WebCore::TransformState::applyTransform):
2625         (WebCore::TransformState::flatten):
2626         * rendering/TransformState.h: Added.
2627         (WebCore::TransformState::):
2628         (WebCore::TransformState::TransformState):
2629         (WebCore::TransformState::move):
2630         * rendering/style/RenderStyle.h:
2631         (WebCore::InheritedFlags::hasPerspective):
2632
2633 2009-02-24  Sam Weinig  <sam@webkit.org>
2634
2635         Reviewed by David Hyatt.
2636
2637         Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
2638         Regression (r40837): JavaScript image popup doesn't work
2639
2640         Make the getClientRects and getBoundingClientRect methods return rects
2641         relative to the viewport.
2642
2643         Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
2644
2645         * dom/Element.cpp:
2646         (WebCore::Element::getClientRects):
2647         (WebCore::Element::getBoundingClientRect):
2648
2649 2009-02-24  Ojan Vafai  <ojan@chromium.org>
2650
2651         Reviewed by Eric Seidel.
2652
2653         SVG pages don't have a body or an html element! 
2654         Don't return early if there is no body.
2655
2656         * editing/VisiblePosition.cpp:
2657         (WebCore::VisiblePosition::canonicalPosition):
2658
2659 2009-02-23  David Hyatt  <hyatt@apple.com>
2660
2661         Reviewed by Eric Seidel
2662
2663         https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden
2664         
2665         This patch reworks the painting of overflow.  There is now the concept of a "self-painting layer."  All
2666         layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
2667         reflections or masks).
2668         
2669         If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
2670         The only difference is that the clip has to be pushed and popped when painting the object's children.
2671         
2672         The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case.  With
2673         the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
2674         use the new functions.
2675         
2676         Hit testing has also been patched to check the overflow clip rect first before recurring into children.
2677         
2678         Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
2679         yet, and scrollbar hit testing was already there anyway.  Now the two code paths are more symmetrical.
2680         
2681         Masks are now treated like normal flow layers (just like reflections).
2682
2683         A couple of test cases have been added to fast/overflow to test the stacking order. 
2684
2685         * rendering/InlineFlowBox.cpp:
2686         (WebCore::InlineFlowBox::nodeAtPoint):
2687         (WebCore::InlineFlowBox::paint):
2688         * rendering/RenderBlock.cpp:
2689         (WebCore::RenderBlock::repaintOverhangingFloats):
2690         (WebCore::RenderBlock::paint):
2691         (WebCore::RenderBlock::paintChildren):
2692         (WebCore::RenderBlock::paintObject):
2693         (WebCore::RenderBlock::paintFloats):
2694         (WebCore::RenderBlock::insertFloatingObject):
2695         (WebCore::RenderBlock::floatRect):
2696         (WebCore::RenderBlock::lowestPosition):
2697         (WebCore::RenderBlock::rightmostPosition):
2698         (WebCore::RenderBlock::leftmostPosition):
2699         (WebCore::RenderBlock::addOverhangingFloats):
2700         (WebCore::RenderBlock::nodeAtPoint):
2701         (WebCore::RenderBlock::hitTestContents):
2702         * rendering/RenderBox.cpp:
2703         (WebCore::RenderBox::nodeAtPoint):
2704         (WebCore::RenderBox::pushContentsClip):
2705         (WebCore::RenderBox::popContentsClip):
2706         * rendering/RenderBox.h:
2707         (WebCore::RenderBox::paintObject):
2708         * rendering/RenderBoxModelObject.cpp:
2709         (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
2710         * rendering/RenderBoxModelObject.h:
2711         * rendering/RenderLayer.cpp:
2712         (WebCore::RenderLayer::paintLayer):
2713         (WebCore::RenderLayer::hitTestLayer):
2714         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
2715         (WebCore::RenderLayer::isSelfPaintingLayer):
2716         * rendering/RenderLayer.h:
2717         * rendering/RenderTable.cpp:
2718         (WebCore::RenderTable::paint):
2719         (WebCore::RenderTable::paintObject):
2720         (WebCore::RenderTable::nodeAtPoint):
2721         * rendering/RenderTable.h:
2722         * rendering/RenderTableCell.cpp:
2723         (WebCore::RenderTableCell::paint):
2724         * rendering/RenderTableRow.cpp:
2725         (WebCore::RenderTableRow::nodeAtPoint):
2726         (WebCore::RenderTableRow::paint):
2727         * rendering/RenderTableRow.h:
2728         * rendering/RenderTableSection.cpp:
2729         (WebCore::RenderTableSection::paint):
2730         (WebCore::RenderTableSection::paintObject):
2731         (WebCore::RenderTableSection::nodeAtPoint):
2732         * rendering/RenderTableSection.h:
2733         * rendering/RenderTreeAsText.cpp:
2734         (WebCore::write):
2735         (WebCore::writeLayers):
2736
2737 2009-02-24  David Levin  <levin@chromium.org>
2738
2739         Reviewed by NOBODY (build fix).
2740
2741         Attempted build fix for wx-mac.
2742
2743         * WebCoreSources.bkl:
2744
2745 2009-02-24  David Levin  <levin@chromium.org>
2746
2747         Reviewed by NOBODY (build fix).
2748
2749         Attempted build fixes for qt-linux and wx-mac.
2750
2751         * WebCore.pro:
2752         * webcore-base.bkl:
2753
2754 2009-02-24  Ojan Vafai  <ojan@dhcp-172-31-134-214.sfo.corp.google.com>
2755
2756         Reviewed by Sam Weinig.
2757
2758         Fix null pointer error. If the node is the Document, then ownerDocument() 
2759         returns null, document() does not.
2760
2761         * editing/VisiblePosition.cpp:
2762         (WebCore::VisiblePosition::canonicalPosition):
2763
2764 2009-02-24  Jian Li  <jianli@chromium.org>
2765
2766         Reviewed by NOBODY (attempted build fixes).
2767
2768         Fix build break for Windows and Linux.
2769
2770         * GNUmakefile.am:
2771         * WebCore.vcproj/WebCore.vcproj:
2772
2773 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2774
2775         Reviewed by Eric Seidel.
2776
2777         https://bugs.webkit.org/show_bug.cgi?id=24131
2778         Fix-up COM/RefCounted dichotomy in Chromium port.
2779
2780         * page/chromium/AccessibilityObjectWrapper.h:
2781         (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
2782         explicit setting of recount.
2783
2784 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2785
2786         Reviewed by Eric Seidel.
2787
2788         https://bugs.webkit.org/show_bug.cgi?id=24141
2789         Add clarity to V8 interceptor helper function.
2790
2791         * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
2792         (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
2793         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
2794         (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
2795         (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
2796
2797 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2798
2799         Reviewed by Eric Seidel
2800
2801         Minor numeric cleanup: convert float literals to doubles.
2802         
2803         * platform/graphics/transforms/RotateTransformOperation.cpp:
2804         (WebCore::RotateTransformOperation::blend):
2805
2806 2009-02-24  Mark Mentovai  <mark@chromium.org>
2807
2808         Reviewed by Eric Seidel.
2809
2810         https://bugs.webkit.org/show_bug.cgi?id=24139
2811         Add missing include.
2812
2813         * bindings/v8/ScriptInstance.h:
2814
2815 2009-02-24  Jian Li  <jianli@chromium.org>
2816
2817         Reviewed by Alexey Proskuryakov.
2818
2819         Move worker related files from dom directory to worker directory under WebCore.
2820         https://bugs.webkit.org/show_bug.cgi?id=24123
2821
2822         * DerivedSources.make:
2823         * GNUmakefile.am:
2824         * WebCore.pro:
2825         * WebCore.scons:
2826         * WebCore.vcproj/MigrateIDLAndScripts:
2827         * WebCore.vcproj/WebCore.vcproj:
2828         * WebCore.xcodeproj/project.pbxproj:
2829         * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
2830         * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
2831         * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
2832         * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
2833         * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
2834         * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
2835         * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
2836         * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
2837         * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
2838         * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
2839         * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
2840         * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
2841         * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
2842         * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
2843         * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
2844         * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
2845         * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
2846         * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
2847         * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
2848         * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
2849
2850 2009-02-05  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
2851
2852         Reviewed by Dave Hyatt.
2853
2854         Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
2855         around divs inside editable regions.
2856         https://bugs.webkit.org/show_bug.cgi?id=23605
2857
2858         Fix clicks outside editable regions from focusing the editable region.
2859         https://bugs.webkit.org/show_bug.cgi?id=23607
2860
2861         Removed editing/selection/contenteditable-click-outside.html as it's
2862         not as useful as our new tests.
2863
2864         Clean up RenderBlock::positionForCoordinates to remove dead code,
2865         duplicate code, and generally make it more readable.
2866
2867         Tests: editing/selection/click-in-margins-inside-editable-div.html
2868                editing/selection/click-in-padding-with-multiple-line-boxes.html
2869                editing/selection/click-outside-editable-div.html
2870
2871         * editing/VisiblePosition.cpp:
2872         (WebCore::VisiblePosition::canonicalPosition):
2873         * rendering/RenderBlock.cpp:
2874         (WebCore::positionForPointRespectingEditingBoundaries):
2875         (WebCore::positionForPointWithInlineChildren):
2876         (WebCore::RenderBlock::positionForCoordinates):
2877         (WebCore::RenderBlock::updateFirstLetter):
2878
2879 2009-02-24  Sam Weinig  <sam@webkit.org>
2880
2881         Reviewed by Geoffrey Garen.
2882
2883         Related to <rdar://problem/6590295>
2884         Allow disabling javascript: urls.
2885
2886         * WebCore.base.exp:
2887         * html/HTMLAnchorElement.cpp:
2888         (WebCore::HTMLAnchorElement::parseMappedAttribute):
2889         * loader/FrameLoader.cpp:
2890         (WebCore::FrameLoader::executeIfJavaScriptURL):
2891         * page/Page.cpp:
2892         (WebCore::Page::Page):
2893         (WebCore::Page::setJavaScriptURLsAreAllowed):
2894         (WebCore::Page::javaScriptURLsAreAllowed):
2895         * page/Page.h:
2896
2897 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2898
2899         Fix build when ACCELERATED_COMPOSITING is turned on
2900         (overflowList() -> normalFlowList()).
2901     
2902         * rendering/RenderLayerBacking.cpp:
2903         (WebCore::RenderLayerBacking::hasNonCompositingContent):
2904         (WebCore::RenderLayerBacking::paintIntoLayer):
2905         * rendering/RenderLayerCompositor.cpp:
2906         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
2907         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2908         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
2909         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
2910         (WebCore::RenderLayerCompositor::layerHas3DContent):
2911
2912 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2913
2914         Reviewed by Darin Adler
2915         
2916         https://bugs.webkit.org/show_bug.cgi?id=24135
2917         
2918         Round the FloatPoint returned by absoluteToLocal(), rather than
2919         truncating it.
2920
2921         * dom/MouseRelatedEvent.cpp:
2922         (WebCore::MouseRelatedEvent::receivedTarget):
2923
2924 2009-02-24  Beth Dakin  <bdakin@apple.com>
2925
2926         Reviewed by Sam Weinig.
2927
2928         Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION: 
2929         Ordered list item marker misaligned when line height is not 1.2 
2930         -and corresponding <rdar://problem/6602506>
2931
2932         This is a regression from http://trac.webkit.org/changeset/40880 
2933         where createInlineBox was taken off of RenderObject and moved to 
2934         RenderBox. The problem was that the RenderBox version still needs 
2935         to be virtual because there is still an existing implementation in 
2936         RenderListMarker. 
2937
2938         * rendering/RenderBox.h:
2939         * rendering/RenderListMarker.cpp:
2940         (WebCore::RenderListMarker::createInlineBox):
2941         * rendering/RenderListMarker.h:
2942
2943 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2944
2945         Reviewed by Eric Seidel.
2946
2947         https://bugs.webkit.org/show_bug.cgi?id=24128
2948         Upstream more V8 custom bindings: constructors, XSLTProcessor.
2949
2950         * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
2951         (WebCore::CALLBACK_FUNC_DECL):
2952         * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
2953         (WebCore::CALLBACK_FUNC_DECL):
2954         * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
2955         (WebCore::CALLBACK_FUNC_DECL):
2956         * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
2957         (WebCore::CALLBACK_FUNC_DECL):
2958         * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
2959         (WebCore::CALLBACK_FUNC_DECL):
2960         * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
2961         (WebCore::CALLBACK_FUNC_DECL):
2962
2963 2009-02-24  David Levin  <levin@chromium.org>
2964
2965         Reviewed by Alexey Proskuryakov.
2966
2967         Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
2968         <https://bugs.webkit.org/show_bug.cgi?id=24090>
2969
2970         No observable change in behavior, so no test.
2971
2972         * dom/WorkerMessagingProxy.cpp:
2973         (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
2974         (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
2975         Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.
2976
2977         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
2978
2979         * dom/WorkerMessagingProxy.h:
2980         * loader/ThreadableLoader.cpp:
2981         (WebCore::ThreadableLoader::create):
2982         * loader/WorkerThreadableLoader.cpp:
2983         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
2984         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
2985         (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
2986         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
2987         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
2988         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
2989         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
2990         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
2991         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
2992         Changed these methods to post task using a mode.
2993
2994         * loader/WorkerThreadableLoader.h:
2995         (WebCore::WorkerThreadableLoader::create):
2996
2997 2009-02-24  Alexey Proskuryakov  <ap@webkit.org>
2998
2999         Reviewed by Darin Adler.
3000
3001         https://bugs.webkit.org/show_bug.cgi?id=24091
3002         <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache
3003
3004         Test: http/tests/appcache/access-via-redirect.php
3005
3006         * loader/appcache/ApplicationCacheGroup.cpp:
3007         (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
3008         not the original one.
3009
3010 2009-02-24  Jian Li  <jianli@chromium.org>
3011
3012         Reviewed by Alexey Proskuryakov.
3013
3014         Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
3015         https://bugs.webkit.org/show_bug.cgi?id=24112
3016
3017         * bindings/js/WorkerScriptController.cpp:
3018         * dom/WorkerContext.cpp:
3019
3020 2009-02-23  Antti Koivisto  <antti@apple.com>
3021
3022         Reviewed by Oliver Hunt.
3023
3024         <rdar://problem/6613796> Extended text codecs registered on webview creation
3025
3026         Comparing a text encoding with string "GBK" ended up constructing
3027         TextEncoding("GBK") which in turn initialized all extended
3028         text codecs.
3029
3030         * platform/text/TextCodecICU.cpp:
3031         (WebCore::TextCodecICU::decode):
3032
3033 2009-02-23  Sam Weinig  <sam@webkit.org>
3034
3035         Fix Qt build.
3036
3037         * bridge/qt/qt_runtime.cpp:
3038         (JSC::Bindings::valueRealType):
3039
3040 2009-02-23  Julien Chaffraix  <jchaffraix@webkit.org>
3041
3042         Reviewed by Darin Adler.
3043
3044         Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)
3045
3046         The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
3047         element created with createElement could have a wrong nodeName (createElement sets the string as the
3048         localName without checking for a prefix).
3049
3050         The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
3051         and will always succeed.
3052         Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
3053         to ensure that).
3054
3055         Test: fast/dom/cloneNode.html
3056
3057         * dom/Element.cpp:
3058         (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
3059         always return an element.
3060
3061         * html/HTMLElement.cpp:
3062         * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.
3063
3064 2009-02-23  Dimitri Glazkov  <dglazkov@chromium.org>
3065
3066         Reviewed by Eric Seidel.
3067
3068         https://bugs.webkit.org/show_bug.cgi?id=24109
3069         Upstream V8 Script abstractions, all except ScriptController.
3070
3071         * bindings/v8/ScriptCachedFrameData.h: Added.
3072         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
3073         (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
3074         (WebCore::ScriptCachedFrameData::restore):
3075         (WebCore::ScriptCachedFrameData::clear):
3076         (WebCore::ScriptCachedFrameData::domWindow):
3077         * bindings/v8/ScriptCallFrame.cpp: Added.
3078         (WebCore::ScriptCallFrame::ScriptCallFrame):
3079         (WebCore::ScriptCallFrame::~ScriptCallFrame):
3080         (WebCore::ScriptCallFrame::argumentAt):
3081         * bindings/v8/ScriptCallFrame.h: Added.
3082         (WebCore::ScriptCallFrame::functionName):
3083         (WebCore::ScriptCallFrame::sourceURL):
3084         (WebCore::ScriptCallFrame::lineNumber):
3085         (WebCore::ScriptCallFrame::argumentCount):
3086         * bindings/v8/ScriptCallStack.cpp: Added.
3087         (WebCore::ScriptCallStack::ScriptCallStack):
3088         (WebCore::ScriptCallStack::~ScriptCallStack):
3089         (WebCore::ScriptCallStack::at):
3090         * bindings/v8/ScriptCallStack.h: Added.
3091         (WebCore::ScriptCallStack::size):
3092         * bindings/v8/ScriptInstance.cpp: Added.
3093         (WebCore::V8ScriptInstance::V8ScriptInstance):
3094         (WebCore::V8ScriptInstance::~V8ScriptInstance):
3095         (WebCore::V8ScriptInstance::instance):
3096         (WebCore::V8ScriptInstance::clear):
3097         (WebCore::V8ScriptInstance::set):
3098         * bindings/v8/ScriptInstance.h: Added.
3099         (WebCore::V8ScriptInstance::create):
3100         * bindings/v8/ScriptSourceCode.h: Added.
3101         (WebCore::ScriptSourceCode::ScriptSourceCode):
3102         (WebCore::ScriptSourceCode::isEmpty):
3103         (WebCore::ScriptSourceCode::source):
3104         (WebCore::ScriptSourceCode::url):
3105         (WebCore::ScriptSourceCode::startLine):
3106         * bindings/v8/ScriptState.h: Added.
3107         (WebCore::ScriptState::hadException):
3108         (WebCore::ScriptState::setException):
3109         (WebCore::ScriptState::exception):
3110         * bindings/v8/ScriptString.h: Added.
3111         (WebCore::ScriptString::ScriptString):
3112         (WebCore::ScriptString::operator String):
3113         (WebCore::ScriptString::isNull):
3114         (WebCore::ScriptString::size):
3115         (WebCore::ScriptString::operator=):
3116         (WebCore::ScriptString::operator+=):
3117         * bindings/v8/ScriptValue.cpp: Added.
3118         (WebCore::ScriptValue::getString):
3119         * bindings/v8/ScriptValue.h: Added.
3120         (WebCore::ScriptValue::ScriptValue):
3121         (WebCore::ScriptValue::operator=):
3122         (WebCore::ScriptValue::operator==):
3123         (WebCore::ScriptValue::operator!=):
3124         (WebCore::ScriptValue::isNull):
3125         (WebCore::ScriptValue::isUndefined):
3126         (WebCore::ScriptValue::clear):
3127         (WebCore::ScriptValue::~ScriptValue):
3128         (WebCore::ScriptValue::v8Value):
3129
3130 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3131
3132         Reviewed by Timothy Hatcher.
3133
3134         https://bugs.webkit.org/show_bug.cgi?id=24106
3135         The Qt port is crashing on exit because the tear down procedure involves
3136         the WebCore::InspectorController trying to access the JS execution context
3137         for a page that is being deleted.  This patch amends the inspector so
3138         that it does not try and access the execution context of the WebCore::Page
3139         in the midst of deletion.
3140
3141         * inspector/InspectorController.cpp:
3142         (WebCore::InspectorController::inspectedPageDestroyed):
3143         (WebCore::InspectorController::stopUserInitiatedProfiling):
3144
3145 2009-02-23  David Levin  <levin@chromium.org>
3146
3147         Reviewed by Alexey Proskuryakov.
3148
3149         Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
3150         <https://bugs.webkit.org/show_bug.cgi?id=24088>
3151
3152         No observable change in behavior, so no test.
3153
3154         * loader/DocumentThreadableLoader.cpp:
3155         (WebCore::DocumentThreadableLoader::create):
3156         * loader/ThreadableLoaderClient.h:
3157         (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
3158         * loader/ThreadableLoaderClientWrapper.h:
3159         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
3160         * loader/WorkerThreadableLoader.cpp:
3161         (WebCore::workerContextDidFailRedirectCheck):
3162         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
3163         * loader/WorkerThreadableLoader.h:
3164         * xml/XMLHttpRequest.cpp:
3165         (WebCore::XMLHttpRequest::didFinishLoading):
3166         * xml/XMLHttpRequest.h:
3167
3168 2009-02-23  David Levin  <levin@chromium.org>
3169
3170         Reviewed by Alexey Proskuryakov.
3171
3172         Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
3173         <https://bugs.webkit.org/show_bug.cgi?id=24047>
3174
3175         Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
3176         using only MessageQueue::waitForMessageFilteredWithTimeout instead
3177         of three different MessageQueue methods.
3178
3179         No observable change in behavior, so no test.
3180
3181         * dom/WorkerRunLoop.cpp:
3182         (WebCore::ModePredicate::operator()):
3183         Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
3184         (WebCore::WorkerRunLoop::runInMode):
3185         * dom/WorkerRunLoop.h:
3186
3187 2009-02-23  David Hyatt  <hyatt@apple.com>
3188
3189         In preparation for making layers for multicol objects (so that they can properly split child layers
3190         into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
3191         of RenderLayer to use the term "normal flow" instead.
3192
3193         Reviewed by Cameron Zwarich
3194
3195         * rendering/RenderLayer.cpp:
3196         (WebCore::RenderLayer::RenderLayer):
3197         (WebCore::RenderLayer::~RenderLayer):
3198         (WebCore::RenderLayer::setHasVisibleContent):
3199         (WebCore::RenderLayer::enclosingCompositingLayer):
3200         (WebCore::RenderLayer::addChild):
3201         (WebCore::RenderLayer::removeChild):
3202         (WebCore::RenderLayer::paintLayer):
3203         (WebCore::RenderLayer::hitTestLayer):
3204         (WebCore::RenderLayer::dirtyNormalFlowList):
3205         (WebCore::RenderLayer::updateNormalFlowList):
3206         (WebCore::RenderLayer::collectLayers):
3207         (WebCore::RenderLayer::updateLayerListsIfNeeded):
3208         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
3209         (WebCore::RenderLayer::styleChanged):
3210         * rendering/RenderLayer.h:
3211         (WebCore::RenderLayer::isNormalFlowOnly):
3212         (WebCore::RenderLayer::normalFlowList):
3213         * rendering/RenderTreeAsText.cpp:
3214         (WebCore::writeLayers):
3215
3216 2009-02-23  David Hyatt  <hyatt@apple.com>
3217
3218         Fix the stacking order for column rules in multi-column layout.  Column rules should paint as part of the background of an element, just
3219         after all other components of the background have been painted.  This allows negative z-index children to still paint on top of the
3220         column rules (rather than ending up above the background of the box but behind the column rules).
3221
3222         Reviewed by Eric Seidel
3223
3224         Added fast/multicol/column-rules-stacking.html
3225
3226         * rendering/RenderBlock.cpp:
3227         (WebCore::RenderBlock::paintColumnRules):
3228         (WebCore::RenderBlock::paintColumnContents):
3229         (WebCore::RenderBlock::paintObject):
3230         * rendering/RenderBlock.h:
3231
3232 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3233
3234         Reviewed by David Hyatt.
3235
3236         No testcases have been added or modified since this patch should not result in
3237         a behavior change for ports that have layout tests enabled.
3238
3239         Currently, the implementation of GraphicsContext::drawLineForText amongst
3240         the various ports differ in that some of them are honoring the context's
3241         strokeStyle when drawing a text-decoration and some of them are not.
3242         For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
3243         but the Cairo implementation does and has an explicit workaround that
3244         sets the strokeStyle() temporarily.
3245
3246         This patch fixes so that all ports are consistent by explicitly making sure
3247         to set the GraphicsContext strokeStyle to SolidStroke whenever
3248         painting the text-decoration of an InlineFlowBox or InlineTextBox as these
3249         should always use a solid stroke.
3250
3251         This patch addresses these bugs:
3252         https://bugs.webkit.org/show_bug.cgi?id=19364
3253         https://bugs.webkit.org/show_bug.cgi?id=15659
3254
3255         * rendering/InlineFlowBox.cpp:
3256         (WebCore::InlineFlowBox::paintTextDecorations):
3257         * rendering/InlineTextBox.cpp:
3258         (WebCore::InlineTextBox::paintDecoration):
3259
3260 2009-02-23  Scott Violet  <sky@google.com>
3261
3262         Reviewed by Eric Seidel.
3263
3264         https://bugs.webkit.org/show_bug.cgi?id=24098
3265         Bugs in ClipboardChromium
3266
3267         Fixes the following bugs in ClipboardChromium:
3268         * It's possible for the extension to be empty, resulting in a bad file
3269           name, for example, 'foo.' or just '.'.
3270         * We weren't restricting the size of the file to MAX_PATH.
3271         * We weren't removing characters that are invalid for file system names.
3272
3273         * platform/chromium/ClipboardChromium.cpp:
3274         (WebCore::writeImageToDataObject):
3275         * platform/chromium/ClipboardChromium.h:
3276         * platform/chromium/ClipboardChromiumLinux.cpp: Added.
3277         (WebCore::ClipboardChromium::validateFileName):
3278         * platform/chromium/ClipboardChromiumMac.cpp: Added.
3279         (WebCore::ClipboardChromium::validateFileName):
3280         * platform/chromium/ClipboardChromiumWin.cpp: Added.
3281         (WebCore::isInvalidFileCharacter):
3282         (WebCore::ClipboardChromium::validateFileName):
3283
3284 2009-02-23  Thiago Macieira  <thiago.macieira@nokia.com>
3285
3286         Reviewed by Simon Hausmann.
3287
3288         Fix the Copyright notices in a few files
3289
3290         * platform/qt/RenderThemeQt.h:
3291
3292 2009-02-23  Xan Lopez  <xan@gnome.org>
3293
3294         Reviewed by Alexey Proskuryakov.
3295
3296         https://bugs.webkit.org/show_bug.cgi?id=22624
3297         [SOUP][GTK] Need API to get SoupSession from WebKit.
3298
3299         Allow to retrieve the Soup session and modify the code to take
3300         into account users changing features on it.
3301
3302         * platform/network/ResourceHandle.h:
3303         * platform/network/soup/CookieJarSoup.cpp:
3304         (WebCore::defaultCookieJar):
3305         (WebCore::setDefaultCookieJar):
3306         * platform/network/soup/CookieJarSoup.h:
3307         * platform/network/soup/ResourceHandleSoup.cpp:
3308         (WebCore::createSoupSession):
3309         (WebCore::ensureSessionIsInitialized):
3310         (WebCore::ResourceHandle::startHttp):
3311         (WebCore::ResourceHandle::cancel):
3312         (WebCore::ResourceHandle::defaultSession):
3313
3314 2009-02-23  Xan Lopez  <xan@gnome.org>
3315
3316         Reviewed by Alexey Proskuryakov.
3317
3318         https://bugs.webkit.org/show_bug.cgi?id=22624
3319         [SOUP][GTK] Need API to get SoupSession from WebKit.
3320
3321         Remove CURL support.
3322
3323         * GNUmakefile.am:
3324
3325 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3326
3327         Reviewed by Mark Rowe.
3328
3329         Test: fast/dom/empty-hash-and-search.html
3330
3331         https://bugs.webkit.org/show_bug.cgi?id=21147
3332         hash property returns incorrect value for links w/o hash
3333
3334         Make hash() and search() behavior for empty and missing parts match IE and Firefox.
3335
3336         * platform/KURL.cpp:
3337         (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
3338         (WebCore::KURL::prettyURL): Append the query with the question mark.
3339
3340         * page/Location.cpp:
3341         (WebCore::Location::search): Return an empty string if query is empty or missing.
3342         (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
3343
3344         * dom/WorkerLocation.cpp:
3345         (WebCore::WorkerLocation::search):
3346         (WebCore::WorkerLocation::hash):
3347         Match document.location fixes above.
3348
3349         * html/HTMLAnchorElement.cpp:
3350         (WebCore::HTMLAnchorElement::hash):
3351         (WebCore::HTMLAnchorElement::search):
3352         Return an empty string for empty and missing parts.
3353
3354 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3355
3356         Reviewed by Darin Adler.
3357
3358         https://bugs.webkit.org/show_bug.cgi?id=20184
3359         SELECT with no name generates invalid query string
3360
3361         Test: fast/forms/select-no-name.html
3362
3363         * html/HTMLSelectElement.cpp:
3364         (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
3365
3366 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3367
3368         Apply review comments for the previous check-in (forgot to save the file, oops).
3369
3370         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
3371
3372 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3373
3374         Reviewed by Darin Adler.
3375
3376         https://bugs.webkit.org/show_bug.cgi?id=15707
3377         Crash when manipulating document from within an iframe onload function
3378
3379         Test: fast/dom/onload-open.html
3380
3381         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
3382         the current node, because anything can happen when dispatching events.
3383
3384 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3385
3386         Reviewed by Darin Adler.
3387
3388         https://bugs.webkit.org/show_bug.cgi?id=18970
3389         Numerically named input fields cause document.forms loop problems
3390
3391         Test: fast/forms/numeric-input-name.html
3392
3393         * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
3394         latter overrides properties.
3395
3396 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3397
3398         Reviewed by Sam Weinig.
3399
3400         https://bugs.webkit.org/show_bug.cgi?id=24059
3401         Tokenizer::write() return value is never used
3402
3403         * dom/Tokenizer.h:
3404         * dom/XMLTokenizer.cpp:
3405         (WebCore::XMLTokenizer::write):
3406         * dom/XMLTokenizer.h:
3407         * html/HTMLTokenizer.cpp:
3408         (WebCore::HTMLTokenizer::write):
3409         * html/HTMLTokenizer.h:
3410         * loader/FTPDirectoryDocument.cpp:
3411         (WebCore::FTPDirectoryTokenizer::write):
3412         * loader/ImageDocument.cpp:
3413         (WebCore::ImageTokenizer::write):
3414         * loader/MediaDocument.cpp:
3415         (WebCore::MediaTokenizer::write):
3416         * loader/PluginDocument.cpp:
3417         (WebCore::PluginTokenizer::write):
3418         * loader/TextDocument.cpp:
3419         (WebCore::TextTokenizer::write):
3420         Made write() return void, not bool.
3421
3422 2009-02-20  Geoffrey Garen  <ggaren@apple.com>
3423
3424         Reviewed by Sam Weinig.
3425
3426         Updated for JavaScriptCore changes to timeout checking.
3427
3428         * bindings/js/JSCustomPositionCallback.cpp:
3429         (WebCore::JSCustomPositionCallback::handleEvent):
3430         * bindings/js/JSCustomPositionErrorCallback.cpp:
3431         (WebCore::JSCustomPositionErrorCallback::handleEvent):
3432         * bindings/js/JSCustomSQLStatementCallback.cpp:
3433         (WebCore::JSCustomSQLStatementCallback::handleEvent):
3434         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3435         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
3436         * bindings/js/JSCustomSQLTransactionCallback.cpp:
3437         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
3438         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
3439         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
3440         * bindings/js/JSCustomVoidCallback.cpp:
3441         (WebCore::JSCustomVoidCallback::handleEvent):
3442         * bindings/js/JSCustomXPathNSResolver.cpp:
3443         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
3444         * bindings/js/JSDOMWindowBase.cpp:
3445         (WebCore::JSDOMWindowBase::JSDOMWindowBase):
3446         (WebCore::JSDOMWindowBase::commonJSGlobalData):
3447         * bindings/js/JSEventListener.cpp:
3448         (WebCore::JSAbstractEventListener::handleEvent):
3449         * bindings/js/ScheduledAction.cpp:
3450         (WebCore::ScheduledAction::executeFunctionInContext):
3451         * bindings/js/ScriptController.cpp:
3452         (WebCore::ScriptController::evaluate):
3453         * bindings/js/WorkerScriptController.cpp:
3454         (WebCore::WorkerScriptController::evaluate):
3455         (WebCore::WorkerScriptController::forbidExecution):
3456         * bindings/objc/WebScriptObject.mm:
3457         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3458         (-[WebScriptObject evaluateWebScript:]):
3459         * bridge/NP_jsobject.cpp:
3460         (_NPN_InvokeDefault):
3461         (_NPN_Invoke):
3462         (_NPN_Evaluate):
3463         (_NPN_Construct):
3464         * bridge/jni/jni_jsobject.mm:
3465         (JavaJSObject::call):
3466         (JavaJSObject::eval):
3467
3468 2009-02-21  Hironori Bono  <hbono@chromium.org>
3469
3470         Reviewed by Alexey Proskuryakov.
3471
3472         https://bugs.webkit.org/show_bug.cgi?id=23786
3473         [Chromium] line-break characters in a complex text are treated as zero-width spaces
3474
3475         This change prevents the UniscribeHelper class from treating the line-break characters
3476         as whitespaces.
3477
3478         Tests: fast/text/international/bidi-linebreak-001.html
3479                fast/text/international/bidi-linebreak-002.html
3480                fast/text/international/bidi-linebreak-003.html
3481
3482         * platform/graphics/chromium/UniscribeHelper.cpp:
3483         (WebCore::UniscribeHelper::adjustSpaceAdvances):
3484         Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in
3485         the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces,
3486         so does when Chromium renders a simple text.
3487
3488 2009-02-20  Julien Chaffraix  <jchaffraix@webkit.org>
3489
3490         Reviewed by Alexey Proskuryakov.
3491
3492         Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
3493
3494         Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
3495         or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
3496         unneeded.
3497
3498         It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
3499         enables us to use some generated QualifiedName.
3500
3501         * bindings/js/JSOptionConstructor.cpp:
3502         (WebCore::constructHTMLOptionElement):
3503         * dom/Document.cpp:
3504         (WebCore::Document::setTitle):
3505         * dom/XMLTokenizer.cpp:
3506         (WebCore::createXHTMLParserErrorHeader):
3507         (WebCore::XMLTokenizer::insertErrorMessageBlock):
3508         * editing/CompositeEditCommand.cpp:
3509         (WebCore::createBlockPlaceholderElement):
3510         * editing/htmlediting.cpp:
3511         (WebCore::createTabSpanElement):
3512         * html/HTMLSelectElement.cpp:
3513         (WebCore::HTMLSelectElement::setLength):
3514         * loader/FTPDirectoryDocument.cpp:
3515         (WebCore::FTPDirectoryTokenizer::appendEntry):
3516         (WebCore::FTPDirectoryTokenizer::createTDForFilename):
3517         (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
3518         (WebCore::FTPDirectoryTokenizer::createBasicDocument):
3519         * loader/ImageDocument.cpp:
3520         (WebCore::ImageDocument::createDocumentStructure):
3521         * loader/MediaDocument.cpp:
3522         (WebCore::MediaTokenizer::createDocumentStructure):
3523         * loader/PluginDocument.cpp:
3524         (WebCore::PluginTokenizer::createDocumentStructure):
3525         * loader/TextDocument.cpp:
3526         (WebCore::TextTokenizer::write):
3527         * page/Frame.cpp:
3528         (WebCore::Frame::selectionComputedStyle):
3529         (WebCore::Frame::styleForSelectionStart):
3530         Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
3531
3532         * xml/XPathFunctions.cpp:
3533         (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
3534         * page/DragController.cpp:
3535         (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
3536
3537 2009-02-19  Dimitri Glazkov  <dglazkov@chromium.org>
3538
3539         Reviewed by Eric Seidel.
3540
3541         https://bugs.webkit.org/show_bug.cgi?id=24060
3542         Fix up to accommodate for CanvasPixelArray return.
3543
3544         * platform/graphics/skia/ImageBufferSkia.cpp:
3545         (WebCore::ImageBuffer::getImageData): Added an extra data() to call.
3546         (WebCore::ImageBuffer::putImageData): Ditto.
3547
3548 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
3549
3550         Simon Fraser
3551
3552         https://bugs.webkit.org/show_bug.cgi?id=24042
3553         Bug 24042: MediaPlayer should cache plug-in proxy
3554
3555         The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
3556         MediaPlayer will always have created the private media player object before
3557         the plug-in is instantiated and calls back with the proxy object. This is not
3558         true on all platforms because of threading latency, so MediaPlayer should
3559         cache the plug-in proxy so it can pass it to the media engine at a later time.
3560
3561         * platform/graphics/MediaPlayer.cpp:
3562         (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods.
3563         (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto.
3564         (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto.
3565         (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy.
3566         (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine.
3567         (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
3568         * platform/graphics/MediaPlayer.h: Declare m_playerProxy.
3569
3570 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
3571
3572         Simon Fraser.
3573
3574         https://bugs.webkit.org/show_bug.cgi?id=24063
3575         Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element
3576
3577         * html/HTMLMediaElement.cpp:
3578         (WebCore::HTMLMediaElement::HTMLMediaElement):  Rename m_loadRestrictions to m_Restrictions.
3579         Initialize m_internalCall.
3580         (WebCore::HTMLMediaElement::loadTimerFired): Increment m_internalCall around call to load().
3581         (WebCore::HTMLMediaElement::load): Call loadInternal if restrictions check out.
3582         (WebCore::HTMLMediaElement::loadInternal): New, guts of old load()
3583         (WebCore::HTMLMediaElement::setNetworkState): Fix bug introduced in r40943
3584         (WebCore::HTMLMediaElement::play): Call playInternal if restrictions check out.
3585         (WebCore::HTMLMediaElement::playInternal): New, guts of old play()
3586         (WebCore::HTMLMediaElement::pause): Call pauseInternal if restrictions check out.
3587         (WebCore::HTMLMediaElement::pauseInternal): New, guts of old pause()
3588         (WebCore::HTMLMediaElement::togglePlayState): Call playInternal/pauseInternal
3589         (WebCore::HTMLMediaElement::deliverNotification): Remove unnecessary white space.
3590         * html/HTMLMediaElement.h: Rename m_loadRestrictions to m_Restrictions, add m_internalCall,
3591         add RequireUserGestureRateChangeRestriction.
3592
3593 2009-02-20  Darin Fisher  <darin@chromium.org>
3594
3595         Fix build bustage in FileSystemWin.cpp.
3596
3597         Need to return CString() instead of 0 since there are now two CString
3598         constructors that take a pointer type.
3599
3600         * platform/win/FileSystemWin.cpp:
3601         (WebCore::openTemporaryFile):
3602
3603 2009-02-20  Dimitri Glazkov  <dglazkov@chromium.org>
3604
3605         Reviewed by Sam Weinig.
3606
3607         https://bugs.webkit.org/show_bug.cgi?id=23999
3608         Change license headers to accurately reflect code history.