cfbc4e0ad64020df20aa3b727bd3e1d0487109a1
[WebKit-https.git] / WebCore / ChangeLog
1 2006-05-10  Justin Garcia  <justin.garcia@apple.com>
2
3         Reviewed by darin
4
5         * editing/ReplaceSelectionCommand.cpp:
6         (WebCore::ReplaceSelectionCommand::doApply):
7         Removed the code to find out if we must later add smart replace whitespace.  We can 
8         wait until we've done the insertion to figure it out, and the position sampled (startPos)
9         to make the decision about trailing whitespace was wrong.
10         Changed the order that work is done during a paste: 1) Insert everything 2) Do one of
11         the following: a) handle a trailing interchange newline, b) uncollapse the last incoming
12         br if it has been collapsed because of quirks mode, c) do an end merge 3) Add smart replace
13         whitespace (2 and 3 were reversed because the end merge must happen before we can know
14         whether or not we need to add a trailing space).
15         Don't do an end merge if the last node inserted was a br because the end merge will 
16         clobber it.
17         
18         (WebCore::ReplaceSelectionCommand::removeEndBRIfNeeded):
19         brs that are at the end of a block and not at the start of a block are not the one brs
20         that are collapsed because of quirks mode.
21
22 2006-05-10  David Hyatt  <hyatt@apple.com>
23
24         Rename isSpace to treatAsSpace.  Move it and the rounding hack function into
25         Font and make them static methods (inlined in the header).  Make the rounding
26         hack character table a static member as well.  Remove the redundant space/rounding
27         functions from FontData.mm.
28
29         Reviewed by darin
30
31         * platform/Font.cpp:
32         (WebCore::):
33         (WebCore::m_finalRoundingWidth):
34         (WebCore::WidthIterator::advance):
35         * platform/Font.h:
36         (WebCore::Font::treatAsSpace):
37         (WebCore::Font::isRoundingHackCharacter):
38         * platform/mac/FontData.mm:
39         (WebCore::overrideLayoutOperation):
40         (WebCore::createATSULayoutParameters):
41         (WebCore::initializeWidthIterator):
42         (WebCore::advanceWidthIterator):
43         * platform/mac/FontMac.mm:
44         (WebCore::overrideLayoutOperation):
45         (WebCore::ATSULayoutParameters::initialize):
46
47 2006-05-10  Darin Adler  <darin@apple.com>
48
49         * WebCore: Removed an extra WebCore subtree that somehow got checked in.
50
51 2006-05-10  David Carson <dacarson@gmail.com>
52
53         - Fix for bug 8833. Removed inline keyword from functions declared
54         in .mm and .cpp files. inline function code needs to reside in the
55         header file for the linker to find the code. 
56         http://www.parashift.com/c++-faq-lite/inline-functions.html#faq-9.7
57
58         Reviewed by Darin, landed by Timothy.
59
60         * platform/Font.cpp:
61         (WebCore::isSpace):
62         * platform/mac/FontData.mm:
63         (WebCore::widthForGlyph):
64         (WebCore::isRoundingHackCharacter):
65         (WebCore::glyphForCharacter):
66
67 2006-05-10  Mitz Pettel  <opendarwin.org@mitzpettel.com>
68
69         Reviewed and landed by Anders.
70
71         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8830
72           REGRESSION: Words render on top of each other when fallback font is used
73
74         Already covered by several pixel tests in fast/text
75
76         * platform/Font.cpp:
77         (WebCore::Font::drawSimpleText):
78
79 2006-05-10  David Hyatt  <hyatt@apple.com>
80
81         Fix for bug 8809, lift the Mac-specific WebTextRenderer code for
82         drawing and measuring of runs up into the Font class.  The fast code
83         path is in Font.cpp and is designed to be mostly cross-platform.  The
84         slow code path is in FontMac.cpp and is Mac-specific.
85
86         Reviewed by darin
87
88         * WebCore.xcodeproj/project.pbxproj:
89         * platform/Font.cpp:
90         (WebCore::isSpace):
91         (WebCore::):
92         (WebCore::isRoundingHackCharacter):
93         (WebCore::m_finalRoundingWidth):
94         (WebCore::WidthIterator::advance):
95         (WebCore::WidthIterator::normalizeVoicingMarks):
96         (WebCore::Font::primaryFont):
97         (WebCore::Font::setAlwaysUseComplexPath):
98         (WebCore::Font::canUseGlyphCache):
99         (WebCore::Font::drawSimpleText):
100         (WebCore::Font::drawText):
101         (WebCore::Font::floatWidth):
102         (WebCore::Font::floatWidthForSimpleText):
103         * platform/Font.h:
104         * platform/FontData.h:
105         (WebCore::FontData::platformData):
106         * platform/GlyphBuffer.h: Added.
107         (WebCore::GlyphBuffer::GlyphBuffer):
108         (WebCore::GlyphBuffer::isEmpty):
109         (WebCore::GlyphBuffer::size):
110         (WebCore::GlyphBuffer::glyphs):
111         (WebCore::GlyphBuffer::advances):
112         (WebCore::GlyphBuffer::fontDataAt):
113         (WebCore::GlyphBuffer::swap):
114         (WebCore::GlyphBuffer::glyphAt):
115         (WebCore::GlyphBuffer::advanceAt):
116         (WebCore::GlyphBuffer::add):
117         * platform/mac/FontData.mm:
118         (WebCore::isSpace):
119         (WebCore::isRoundingHackCharacter):
120         (WebCore::FontData::widthForGlyph):
121         (WebCore::m_ATSUMirrors):
122         (WebCore::FontData::xHeight):
123         (WebCore::FontData::smallCapsFontData):
124         (WebCore::findSubstituteFont):
125         (WebCore::rendererForAlternateFont):
126         (WebCore::findSubstituteRenderer):
127         (WebCore::FontData::findSubstituteFontData):
128         (WebCore::computeWidthForSpace):
129         (WebCore::FontData::updateGlyphMapEntry):
130         (WebCore::extendGlyphMap):
131         (WebCore::extendWidthMap):
132         (WebCore::createATSULayoutParameters):
133         (WebCore::FontData::glyphForCharacter):
134         (WebCore::advanceWidthIterator):
135         (WebCore::shouldUseATSU):
136         * platform/mac/FontMac.mm:
137         (WebCore::ATSULayoutParameters::m_padPerSpace):
138         (WebCore::addDirectionalOverride):
139         (WebCore::initializeATSUStyle):
140         (WebCore::overrideLayoutOperation):
141         (WebCore::ATSULayoutParameters::initialize):
142         (WebCore::disposeATSULayoutParameters):
143         (WebCore::Font::drawComplexText):
144         (WebCore::Font::floatWidthForComplexText):
145         (WebCore::Font::drawGlyphs):
146         * platform/mac/WebCoreTextRenderer.mm:
147         (WebCoreSetAlwaysUseATSU):
148
149 2006-05-10  Darin Adler  <darin@apple.com>
150
151         - another try at fixing the Windows build
152
153         * platform/win/FontWin.cpp: (WebCore::getFontData): Use characters()
154         instead of unicode().
155
156 == Rolled over to ChangeLog-2006-05-10 ==