WebCore/ChangeLog

   1 2006-09-27  Rob Buis  <buis@kde.org>
   2
   3         Reviewed by eseidel.
   4
   5         http://bugzilla.opendarwin.org/show_bug.cgi?id=11015
   6         SVG handles em units incorrectly
   7
   8         Calculate viewport coordinates at layout time, since
   9         at this point the font size is known and lengths depending
  10         on font sizes can be calculated correctly.
  11
  12         * kcanvas/RenderSVGContainer.cpp:
  13         (WebCore::RenderSVGContainer::layout):
  14         (WebCore::RenderSVGContainer::viewport):
  15         (WebCore::RenderSVGContainer::calcViewport):
  16         * kcanvas/RenderSVGContainer.h:
  17         * ksvg2/svg/SVGLength.cpp:
  18         (WebCore::SVGLength::updateValue):
  19         * ksvg2/svg/SVGMarkerElement.cpp:
  20         (WebCore::SVGMarkerElement::createRenderer):
  21         * ksvg2/svg/SVGSVGElement.cpp:
  22         (WebCore::SVGSVGElement::createRenderer):
  23         (WebCore::SVGSVGElement::attributeChanged):
  24         * ksvg2/svg/SVGSVGElement.h:
  25
  26 2006-09-27  Eric Seidel  <eric@eseidel.com>
  27
  28         Reviewed by darin.
  29
  30         Change our invalid-fill error behavior to match Opera (and soon Firefox)
  31         http://bugzilla.opendarwin.org/show_bug.cgi?id=11017
  32
  33         * ksvg2/misc/KCanvasRenderingStyle.cpp:
  34         (WebCore::KSVGPainterFactory::isFilled):
  35         (WebCore::KSVGPainterFactory::fillPaintServer):
  36         (WebCore::KSVGPainterFactory::isStroked):
  37         (WebCore::KSVGPainterFactory::strokePaintServer):
  38
  39 2006-09-27  Brady Eidson  <beidson@apple.com>
  40
  41         Build fix
  42
  43         * loader/icon/IconDatabase.cpp:
  44         (WebCore::readySQLStatement):
  45
  46 2006-09-27  Brady Eidson  <beidson@apple.com>
  47
  48         Reviewed by Adam
  49
  50         In very specific circumstances, prepared SQLStatements can become invalid without
  51         any warning.  This checks for that state and re-prepares the statement and also
  52         adds more aggressive error-checking everywhere these statements are used.
  53
  54         * loader/icon/IconDatabase.cpp:
  55         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
  56         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
  57         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
  58         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
  59         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
  60         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
  61         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
  62         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
  63         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
  64         * loader/icon/SQLStatement.cpp:
  65         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
  66         * loader/icon/SQLStatement.h:
  67
  68 2006-09-26  Darin Adler  <darin@apple.com>
  69
  70         Reviewed by Steve.
  71
  72         - clean up options for font code path
  73
  74         * platform/Font.h:
  75         * platform/Font.cpp:
  76         (WebCore::Font::setCodePath): Added. Replaces boolean version.
  77         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
  78
  79         * platform/mac/WebCoreTextRenderer.mm:
  80         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
  81
  82 2006-09-26  John Sullivan  <sullivan@apple.com>
  83
  84         Reviewed by Darin
  85
  86         * bridge/mac/WebCoreFrameBridge.h:
  87         * bridge/mac/WebCoreFrameBridge.mm:
  88         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
  89         Added limit parameter, passed down to Frame
  90
  91         * page/Frame.h:
  92         * page/Frame.cpp:
  93         (WebCore::Frame::markAllMatchesForText):
  94         Added limit parameter. Stop the search if it hits limit.
  95
  96 2006-09-26  Sean Gies  <seangies@apple.com>
  97
  98         Reviewed by Brady Eidson.
  99
 100         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
 101
 102 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
 103
 104         Reviewed by john
 105
 106         <rdar://problem/4747695>
 107         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
 108
 109         * editing/DeleteSelectionCommand.cpp:
 110         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
 111         to select special elements that are fully selected after expansion
 112         moves to positions that are visually distinct from the originals.
 113         * editing/InsertListCommand.cpp:
 114         (WebCore::InsertListCommand::doApply): If the content of the list
 115         item will be moved into another list, put it in a list item.
 116
 117 2006-09-26  Geoffrey Garen <ggaren@apple.com>
 118
 119         Reviewed by Darin.
 120
 121         Temporary work-around for frame lifetime issue.
 122
 123         * page/Frame.cpp:
 124         (WebCore::Frame::clear):
 125         (WebCore::Frame::disconnectOwnerElement):
 126
 127 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
 128
 129         Reviewed by Tim H.
 130
 131         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11038
 132         Auto-generate DOMSVGElement for the Objective-C bindings
 133
 134         - Auto-generates DOMSVGElement.
 135
 136         - Make SVGExceptions work like all the other ExceptionCode
 137           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
 138           and SVGExceptionMax.
 139
 140         * DerivedSources.make:
 141         * WebCore.xcodeproj/project.pbxproj:
 142         * bindings/js/kjs_binding.cpp:
 143         (KJS::):
 144         (KJS::setDOMException):
 145         * bindings/objc/DOMInternal.h:
 146         * bindings/objc/DOMInternal.mm:
 147         (raiseDOMException):
 148         * bindings/objc/DOMSVG.h:
 149         * bindings/objc/DOMSVGExecption.h: Added.
 150         * ksvg2/ksvg.h:
 151         * ksvg2/svg/SVGElement.cpp:
 152         (WebCore::SVGElement::setId):
 153         (WebCore::SVGElement::setXmlbase):
 154         * ksvg2/svg/SVGElement.h:
 155         * ksvg2/svg/SVGElement.idl:
 156         * ksvg2/svg/SVGException.h: Added.
 157         (WebCore::):
 158
 159 2006-09-26  Eric Seidel  <eric@eseidel.com>
 160
 161         Reviewed by Tim H.
 162
 163         viewbox parser does not allow <tab> as a delimiter
 164         http://bugzilla.opendarwin.org/show_bug.cgi?id=11014
 165
 166         Test: svg/hixie/viewbox/003.xml
 167
 168         * ksvg2/svg/svgpathparser.cpp:
 169         (WebCore::isWhitespace): new function
 170         (WebCore::skipOptionalSpaces):
 171         (WebCore::skipOptionalSpacesOrComma):
 172
 173 2006-09-26  Eric Seidel  <eric@eseidel.com>
 174
 175         Reviewed by Tim H.
 176
 177         SVGDocument::createElement does not create elements in the SVG namespace
 178         http://bugzilla.opendarwin.org/show_bug.cgi?id=10932
 179
 180         Test: svg/custom/createelement.svg
 181
 182         * ksvg2/svg/SVGDocument.cpp:
 183         (WebCore::SVGDocument::createElement):
 184         * ksvg2/svg/SVGDocument.h:
 185
 186 2006-09-26  Eric Seidel  <eric@eseidel.com>
 187
 188         Reviewed by Tim H.
 189
 190         RenderPath::nodeAtPoint does not respect stroke width
 191         http://bugzilla.opendarwin.org/show_bug.cgi?id=10829
 192
 193         Test: svg/custom/stroke-width-click.svg
 194
 195         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
 196         (WebCore::RenderPath::strokeContains):
 197         * kcanvas/device/quartz/QuartzSupport.h:
 198         * kcanvas/device/quartz/QuartzSupport.mm:
 199
 200 2006-09-26  Eric Seidel  <eric@eseidel.com>
 201
 202         Reviewed by mitz.
 203
 204         Bring animation back to life
 205         http://bugzilla.opendarwin.org/show_bug.cgi?id=11021
 206
 207         Register/unregister SVGSVGElements as time containers on insertion/removal.
 208         Replace uses of DeprecatedString with String in SVGAnimationElement
 209         Various whitespace clean-up.
 210
 211         * ksvg2/misc/KSVGTimeScheduler.cpp:
 212         (WebCore::SVGTimer::notifyAll):
 213         * ksvg2/misc/SVGDocumentExtensions.cpp:
 214         (WebCore::SVGDocumentExtensions::startAnimations):
 215         (WebCore::SVGDocumentExtensions::pauseAnimations):
 216         (WebCore::SVGDocumentExtensions::unpauseAnimations):
 217         * ksvg2/svg/SVGAnimateTransformElement.cpp:
 218         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
 219         (WebCore::SVGAnimateTransformElement::parseTransformValue):
 220         * ksvg2/svg/SVGAnimateTransformElement.h:
 221         * ksvg2/svg/SVGAnimationElement.cpp:
 222         (WebCore::SVGAnimationElement::SVGAnimationElement):
 223         (WebCore::SVGAnimationElement::parseMappedAttribute):
 224         (WebCore::SVGAnimationElement::parseClockValue):
 225         (WebCore::SVGAnimationElement::targetAttribute):
 226         (WebCore::SVGAnimationElement::setTargetAttribute):
 227         (WebCore::SVGAnimationElement::attributeName):
 228         * ksvg2/svg/SVGAnimationElement.h:
 229         (WebCore::SVGAnimationElement::rendererIsNeeded):
 230         * ksvg2/svg/SVGSVGElement.cpp:
 231         (WebCore::SVGSVGElement::getScreenCTM):
 232         (WebCore::SVGSVGElement::createRenderer):
 233         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
 234         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
 235         * ksvg2/svg/SVGSVGElement.h:
 236         * ksvg2/svg/SVGSetElement.cpp:
 237         (WebCore::SVGSetElement::handleTimerEvent):
 238         * ksvg2/svg/SVGURIReference.cpp:
 239         (WebCore::SVGURIReference::getTarget):
 240         * ksvg2/svg/SVGURIReference.h:
 241
 242 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
 243
 244         Reviewed by mitzpettel.
 245
 246         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=11020
 247         No-SVG build broken since r16549
 248
 249         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
 250
 251         * css/cssparser.cpp:
 252         (WebCore::CSSParser::parseValue):
 253         * css/cssstyleselector.cpp:
 254         (WebCore::CSSStyleSelector::applyProperty):
 255         * page/FrameView.cpp:
 256         (WebCore::selectCursor):
 257         * platform/qt/GraphicsContextQt.cpp:
 258
 259 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
 260
 261         Reviewed by Maciej.
 262
 263         http://bugzilla.opendarwin.org/show_bug.cgi?id=10820
 264         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
 265
 266         (Originally written by Eric Seidel).
 267
 268         * bindings/js/kjs_window.cpp:
 269         (KJS::floatFeature):
 270         * ksvg2/svg/SVGAngle.cpp:
 271         (SVGAngle::setValueAsString):
 272         * ksvg2/svg/SVGAnimationElement.cpp:
 273         (SVGAnimationElement::parseMappedAttribute):
 274         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
 275         (SVGComponentTransferFunctionElement::parseMappedAttribute):
 276         * ksvg2/svg/SVGFECompositeElement.cpp:
 277         (WebCore::SVGFECompositeElement::parseMappedAttribute):
 278         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
 279         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
 280         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
 281         (SVGFEDisplacementMapElement::parseMappedAttribute):
 282         * ksvg2/svg/SVGFELightElement.cpp:
 283         (SVGFELightElement::parseMappedAttribute):
 284         * ksvg2/svg/SVGFEOffsetElement.cpp:
 285         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
 286         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
 287         (SVGFESpecularLightingElement::parseMappedAttribute):
 288         * ksvg2/svg/SVGFETurbulenceElement.cpp:
 289         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
 290         * ksvg2/svg/SVGStopElement.cpp:
 291         (SVGStopElement::parseMappedAttribute):
 292         * platform/AtomicString.h:
 293         (WebCore::AtomicString::toDouble):
 294         * platform/PlatformString.h:
 295         * platform/String.cpp:
 296         (WebCore::String::toDouble):
 297         * platform/StringImpl.cpp:
 298         (WebCore::StringImpl::toDouble):
 299         * platform/StringImpl.h:
 300         * rendering/DeprecatedSlider.cpp:
 301         (WebCore::DeprecatedSlider::updateFromElement):
 302         * xml/XPathGrammar.y:
 303
 304 2006-09-25  David Harrison  <harrison@apple.com>
 305
 306         Reviewed by Tim Omernick and Tim Hatcher.
 307
 308         <rdar://problem/4717965> Text Field text parameterized attributes should work
 309         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
 310
 311         * bridge/mac/WebCoreAXObject.mm:
 312         (-[WebCoreAXObject accessibilityAttributeValue:]):
 313         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
 314
 315         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
 316         Cleaned up. Added text field and text area parameterzed attributes.
 317
 318         (-[WebCoreAXObject doAXLineForTextMarker:]):
 319         Fixed to be zero-based and to deal with the first position properly.
 320
 321         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
 322         Minor formatting.
 323
 324         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
 325         (-[WebCoreAXObject indexForTextMarker:]):
 326         (-[WebCoreAXObject textMarkerRangeForRange:]):
 327         (-[WebCoreAXObject rangeForTextMarkerRange:]):
 328         New utility methods.
 329
 330         (-[WebCoreAXObject doAXLineForIndex:]):
 331         (-[WebCoreAXObject doAXRangeForLine:]):
 332         (-[WebCoreAXObject doAXStringForRange:]):
 333         (-[WebCoreAXObject doAXRangeForPosition:]):
 334         (-[WebCoreAXObject doAXRangeForIndex:]):
 335         (-[WebCoreAXObject doAXBoundsForRange:]):
 336         (-[WebCoreAXObject doAXAttributedStringForRange:]):
 337         (-[WebCoreAXObject doAXRTFForRange:]):
 338         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
 339         Implement text field and text area parameterized attributes.
 340
 341         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
 342         Added text field and text area parameterzed attributes.
 343
 344         * rendering/RenderTextControl.h:
 345         Made indexForVisiblePosition() and visiblePositionForIndex() public.
 346
 347 2006-09-25  Adam Roben  <aroben@apple.com>
 348
 349         Reviewed by Brady.
 350
 351         Build fixes.
 352
 353         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
 354         * platform/ResourceLoader.h: Store whether a particular job
 355         has received a response within the ResourceLoader object itself, since
 356         it's possible that we will enter the InternetReadFileExA while loop
 357         twice for the same job.
 358         * platform/ResourceLoaderInternal.h: Add private instance variable to
 359         store whether we've received a response.
 360         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
 361         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
 362         directives.
 363         * platform/win/ResourceLoaderWin.cpp:
 364         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
 365         whether it has received a response instead of assuming it hasn't.
 366         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
 367         (WebCore::ResourceLoader::hasReceivedResponse): Added.
 368         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
 369         setProportion
 370         (ScrollBar::setProportion):
 371
 372 2006-09-25  Brady Eidson  <beidson@apple.com>
 373
 374         Requested by ggaren
 375
 376         Disabled IconDatabase logging by default
 377
 378         * platform/Logging.cpp:
 379         (WebCore::):
 380
 381 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
 382
 383         Build fix
 384
 385         * platform/cf/ResourceLoaderCFNet.cpp:
 386         (WebCore::willCacheResponse):
 387
 388 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
 389
 390         Reviewed by john
 391
 392         <http://bugzilla.opendarwin.org/show_bug.cgi?id=11002>
 393         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
 394
 395         * editing/IndentOutdentCommand.cpp:
 396         (WebCore::IndentOutdentCommand::indentRegion): Special case
 397         an empty root editable element.
 398
 399 2006-09-25  Brady Eidson  <beidson@apple.com>
 400
 401         Reviewed by Steve
 402
 403         Math error in SystemTimeWin
 404
 405         * platform/win/SystemTimeWin.cpp:
 406         (WebCore::currentTime):
 407
 408 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
 409
 410         Reviewed by Eric.
 411
 412         Whitespace cleanup; rename *job variables to *loader.
 413
 414         * bindings/js/JSXMLHttpRequest.cpp:
 415         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
 416         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
 417         (KJS::JSXMLHttpRequestConstructorImp::construct):
 418         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
 419         (KJS::JSXMLHttpRequest::getValueProperty):
 420         (KJS::JSXMLHttpRequest::put):
 421         (KJS::JSXMLHttpRequest::putValueProperty):
 422         (KJS::JSXMLHttpRequest::mark):
 423         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
 424         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
 425         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
 426         * bindings/js/JSXMLHttpRequest.h:
 427         (KJS::JSXMLHttpRequest::toBoolean):
 428         * xml/xmlhttprequest.cpp:
 429         (WebCore::XMLHttpRequest::XMLHttpRequest):
 430         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
 431         (WebCore::XMLHttpRequest::send):
 432         (WebCore::XMLHttpRequest::abort):
 433         (WebCore::XMLHttpRequest::receivedAllData):
 434         (WebCore::XMLHttpRequest::receivedData):
 435         * xml/xmlhttprequest.h:
 436         (WebCore::):
 437
 438 2006-09-25  Timothy Hatcher  <timothy@apple.com>
 439
 440         Reviewed by Brady.
 441
 442         - Deprecate the rest of the old-style methods that are not generated.
 443         - Add @property syntax to DOMRange.
 444
 445         * WebCore.xcodeproj/project.pbxproj:
 446         * bindings/objc/DOM.mm:
 447         (-[DOMRange setStart:offset:]):
 448         (-[DOMRange setEnd:offset:]):
 449         (-[DOMRange compareBoundaryPoints:sourceRange:]):
 450         (-[DOMRange setStart::]):
 451         (-[DOMRange setEnd::]):
 452         (-[DOMRange compareBoundaryPoints::]):
 453         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
 454         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
 455         (-[DOMDocument createNodeIterator::::]):
 456         (-[DOMDocument createTreeWalker::::]):
 457         * bindings/objc/DOMCSS.h:
 458         * bindings/objc/DOMCSS.mm:
 459         (-[DOMDocument getComputedStyle:pseudoElement:]):
 460         (-[DOMDocument getComputedStyle::]):
 461         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
 462         * bindings/objc/DOMExtensions.h:
 463         * bindings/objc/DOMHTML.h:
 464         * bindings/objc/DOMRange.h:
 465         * bindings/objc/DOMTraversal.h:
 466
 467 2006-09-25  Eric Seidel  <eric@eseidel.com>
 468
 469         Reviewed by mjs.
 470
 471         Outermost <svg> element should clip to viewport
 472         http://bugzilla.opendarwin.org/show_bug.cgi?id=11007
 473
 474         Test: svg/custom/viewport-clip.svg
 475
 476         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
 477
 478 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
 479
 480         Reviewed by Maciej.
 481
 482         * css/MediaList.cpp:
 483         Remove unused header.
 484
 485         * dom/Document.cpp:
 486         (WebCore::Document::clear):
 487         Use clear instead of iterating through the list of event listeners, removing each one.
 488         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
 489
 490         * html/HTMLKeygenElement.cpp:
 491         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
 492         (WebCore::HTMLKeygenElement::appendFormData):
 493         Update due to changes in the SSL key generator.
 494
 495         * ksvg2/svg/SVGAngle.cpp:
 496         Remove unused header.
 497
 498         * ksvg2/svg/SVGAnimationElement.cpp:
 499         (SVGAnimationElement::parseMappedAttribute):
 500         Rename methods and pass Strings instead of DeprecatedStrings to
 501         parseSeparatedList.
 502
 503         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
 504         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
 505         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
 506         * ksvg2/svg/SVGFEMergeElement.cpp:
 507         * ksvg2/svg/SVGFEOffsetElement.cpp:
 508         Remove unused headers.
 509
 510         * ksvg2/svg/SVGHelper.cpp:
 511         (WebCore::SVGHelper::parseSeparatedList):
 512         * ksvg2/svg/SVGHelper.h:
 513         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
 514         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
 515
 516         * ksvg2/svg/SVGLengthList.cpp:
 517         (WebCore::SVGLengthList::parse):
 518         * ksvg2/svg/SVGLengthList.h:
 519         Use Vector<String> instead of DeprecatedStringList.
 520
 521         * loader/Cache.cpp:
 522         (WebCore::Cache::requestImage):
 523         (WebCore::Cache::requestStyleSheet):
 524         (WebCore::Cache::requestScript):
 525         (WebCore::Cache::requestXSLStyleSheet):
 526         (WebCore::Cache::requestXBLDocument):
 527         (WebCore::Cache::remove):
 528         (WebCore::Cache::get):
 529         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
 530
 531         * loader/DocLoader.cpp:
 532         (WebCore::DocLoader::needReload):
 533         * loader/DocLoader.h:
 534         Use a HashSet instead of DeprecatedStringList.
 535
 536         * page/FrameView.h:
 537         Remove declarations that have no functions.
 538
 539         * platform/SSLKeyGenerator.h:
 540         * platform/mac/SSLKeyGeneratorMac.mm:
 541         (WebCore::supportedKeySizes):
 542         (WebCore::signedPublicKeyAndChallengeString):
 543         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
 544         DeprecatedString.
 545
 546 2006-09-25  Dave Hyatt  <hyatt@apple.com>
 547
 548         Shunt the RenderTheme world transform adoption between
 549         Cairo and Windows into getWindowsContext and move the method
 550         out of GraphicsContextCairo and into GraphicsContextWin.
 551
 552         * ChangeLog:
 553         * WebCore.vcproj/WebCore/WebCore.vcproj:
 554         * platform/cairo/GraphicsContextCairo.cpp:
 555         * platform/win/GraphicsContextWin.cpp: Added.
 556         (WebCore::GraphicsContext::getWindowsContext):
 557         (WebCore::GraphicsContext::releaseWindowsContext):
 558         * rendering/RenderThemeWin.cpp:
 559         (WebCore::prepareForDrawing):
 560
 561 2006-09-24  Eric Seidel  <eric@eseidel.com>
 562
 563         Reviewed by hyatt.
 564
 565         <svg:a> cannot be styled with a:hover
 566         http://bugzilla.opendarwin.org/show_bug.cgi?id=11005
 567
 568         Test: svg/hixie/cascade/002.xml
 569
 570         * css/cssstyleselector.cpp:
 571         (WebCore::checkPseudoState):
 572
 573 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
 574
 575         Reviewed by Tim H.
 576
 577         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10882
 578         SVG needs Obj-C DOM bindings
 579
 580         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
 581           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
 582           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
 583           DOMSVGTransformList.
 584
 585         * DerivedSources.make:
 586         * WebCore.xcodeproj/project.pbxproj:
 587         * bindings/objc/DOMInternal.h:
 588         * bindings/objc/DOMSVG.h: Added.
 589         * ksvg2/svg/SVGAngle.idl:
 590         * ksvg2/svg/SVGLength.idl:
 591         * ksvg2/svg/SVGLengthList.idl:
 592         * ksvg2/svg/SVGMatrix.idl:
 593         * ksvg2/svg/SVGPathSeg.idl:
 594         * ksvg2/svg/SVGPathSegList.idl:
 595         * ksvg2/svg/SVGTransform.idl:
 596         * ksvg2/svg/SVGTransformList.idl:
 597
 598 2006-09-24  Rob Buis  <buis@kde.org>
 599
 600         Reviewed by eseidel.
 601
 602         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6001
 603         WebKit does not handle fallback custom cursors
 604         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6002
 605         WebKit does not properly handle SVG <cursor> element
 606
 607         Add support for svg cursor images. Also make sure hotspot
 608         settings are handled correctly. Add tests for handling of css3
 609         cursor syntax with hotspots in strict and quirks mode. Finally
 610         implement fallback.
 611
 612         * WebCore.xcodeproj/project.pbxproj:
 613         * css/CSSComputedStyleDeclaration.cpp:
 614         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
 615         * css/CSSCursorImageValue.cpp: Added.
 616         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
 617         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
 618         * css/CSSCursorImageValue.h: Added.
 619         (WebCore::CSSCursorImageValue::hotspot):
 620         * css/cssparser.cpp:
 621         (WebCore::CSSParser::parseValue):
 622         * css/cssstyleselector.cpp:
 623         (WebCore::CSSStyleSelector::applyProperty):
 624         * ksvg2/svg/SVGCursorElement.cpp:
 625         * manual-tests/css3-cursor-fallback-quirks.html: Added.
 626         * manual-tests/css3-cursor-fallback-strict.html: Added.
 627         * manual-tests/cursorfallback.xml: Added.
 628         * page/FrameView.cpp:
 629         (WebCore::selectCursor):
 630         * platform/Cursor.h:
 631         * platform/mac/CursorMac.mm:
 632         (WebCore::createCustomCursor):
 633         (WebCore::Cursor::Cursor):
 634         * platform/qt/CursorQt.cpp:
 635         (WebCore::Cursor::Cursor):
 636         * rendering/RenderStyle.cpp:
 637         (WebCore::StyleInheritedData::StyleInheritedData):
 638         (WebCore::StyleInheritedData::operator==):
 639         (WebCore::RenderStyle::diff):
 640         (WebCore::RenderStyle::addCursor):
 641         (WebCore::RenderStyle::addSVGCursor):
 642         (WebCore::RenderStyle::setCursorList):
 643         (WebCore::RenderStyle::clearCursorList):
 644         * rendering/RenderStyle.h:
 645         (WebCore::CursorData::CursorData):
 646         (WebCore::CursorList::operator[]):
 647         (WebCore::CursorList::size):
 648         (WebCore::CursorList::append):
 649         (WebCore::RenderStyle::cursors):
 650
 651 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
 652
 653         Reviewed by Tim H.
 654
 655         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11009
 656         Auto-generate the internal methods interfaces for the Objective-C bindings
 657
 658         - Auto-generate the internal method declarations into their own files
 659           named in the form DOMFooBarInternal.h for class DOMFooBar.
 660
 661         - Remove all use of DOM_cast from code.
 662
 663         - Assorted cleanups.
 664
 665         * WebCore.xcodeproj/project.pbxproj:
 666         * bindings/objc/DOM.mm:
 667         (-[DOMNode _initWithNode:WebCore::]):
 668         (-[DOMNode WebCore::]):
 669         (-[DOMRange dealloc]):
 670         (-[DOMRange finalize]):
 671         (-[DOMRange _initWithRange:WebCore::]):
 672         (-[DOMRange WebCore::]):
 673         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
 674         (-[DOMNodeFilter WebCore::]):
 675         (-[DOMNodeFilter dealloc]):
 676         (-[DOMNodeFilter finalize]):
 677         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
 678         (-[DOMNodeIterator WebCore::]):
 679         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
 680         (-[DOMTreeWalker WebCore::]):
 681         * bindings/objc/DOMAbstractView.mm:
 682         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
 683         * bindings/objc/DOMCSS.mm:
 684         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
 685         (-[DOMCSSRule _initWithRule:WebCore::]):
 686         (-[DOMCSSValue _initWithValue:WebCore::]):
 687         * bindings/objc/DOMEvents.mm:
 688         (-[DOMEvent _initWithEvent:WebCore::]):
 689         * bindings/objc/DOMHTMLAppletElement.mm:
 690         (-[DOMHTMLAppletElement align]):
 691         (-[DOMHTMLAppletElement setAlign:]):
 692         (-[DOMHTMLAppletElement alt]):
 693         (-[DOMHTMLAppletElement setAlt:]):
 694         (-[DOMHTMLAppletElement archive]):
 695         (-[DOMHTMLAppletElement setArchive:]):
 696         (-[DOMHTMLAppletElement code]):
 697         (-[DOMHTMLAppletElement setCode:]):
 698         (-[DOMHTMLAppletElement codeBase]):
 699         (-[DOMHTMLAppletElement setCodeBase:]):
 700         (-[DOMHTMLAppletElement height]):
 701         (-[DOMHTMLAppletElement setHeight:]):
 702         (-[DOMHTMLAppletElement hspace]):
 703         (-[DOMHTMLAppletElement setHspace:]):
 704         (-[DOMHTMLAppletElement name]):
 705         (-[DOMHTMLAppletElement setName:]):
 706         (-[DOMHTMLAppletElement object]):
 707         (-[DOMHTMLAppletElement setObject:]):
 708         (-[DOMHTMLAppletElement vspace]):
 709         (-[DOMHTMLAppletElement setVspace:]):
 710         (-[DOMHTMLAppletElement width]):
 711         (-[DOMHTMLAppletElement setWidth:]):
 712         * bindings/objc/DOMInternal.h:
 713         (getDOMWrapper):
 714         (addDOMWrapper):
 715         (raiseOnDOMError):
 716         * bindings/objc/DOMXPath.mm:
 717         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
 718         * bindings/scripts/CodeGeneratorObjC.pm:
 719
 720 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
 721
 722         Reviewed by eseidel.
 723
 724         Fix Qt/Linux build after Dave's Scrollbar changes.
 725
 726         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
 727         * platform/qt/TemporaryLinkStubs.cpp:
 728         (WebCore::ScrollBar::setProportion):
 729         (WebCore::PlatformScrollBar::updateThumbPosition):
 730         (WebCore::PlatformScrollBar::updateThumbProportion):
 731
 732 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
 733
 734         Reviewed by eseidel.
 735
 736         Qt/Linux build system changes: enable xpath/xslt by default.
 737         Offer possibility to change all of these using 'ccmake'.
 738
 739         * CMakeLists.txt:
 740
 741 2006-09-24  Dave Hyatt  <hyatt@apple.com>
 742
 743         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
 744         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
 745         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
 746
 747         * platform/ScrollBar.cpp:
 748         (WebCore::ScrollBar::setValue):
 749         (WebCore::ScrollBar::setProportion):
 750         * platform/ScrollBar.h:
 751         (WebCore::ScrollBar::value):
 752         * platform/mac/PlatformScrollBar.h:
 753         * platform/mac/PlatformScrollBarMac.mm:
 754         (WebCore::PlatformScrollBar::updateThumbPosition):
 755         (WebCore::PlatformScrollBar::updateThumbProportion):
 756         * platform/win/PlatformScrollBar.h:
 757         * platform/win/TemporaryLinkStubs.cpp:
 758         (PlatformScrollBar::updateThumbPosition):
 759         (PlatformScrollBar::updateThumbProportion):
 760         * rendering/RenderLayer.cpp:
 761         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
 762
 763 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
 764
 765         Reviewed by Eric.
 766
 767         http://bugzilla.opendarwin.org/show_bug.cgi?id=4872
 768         XMLHttpRequest fails to throw an exception when there is a security violation
 769         (mismatching domains)
 770
 771         Raise an exception if there is a security violation, and also in cases required by
 772         the current draft of XHR specification.
 773
 774         * bindings/js/JSXMLHttpRequest.cpp:
 775         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
 776         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
 777         reports one, and also if there were too few arguments passed.
 778
 779         * bindings/js/kjs_binding.cpp:
 780         (KJS::setDOMException): Added support for custom XHR exceptions.
 781
 782         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
 783         exception code range for XHR exceptions.
 784
 785         * xml/xmlhttprequest.cpp:
 786         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
 787         (WebCore::XMLHttpRequest::send):
 788         (WebCore::XMLHttpRequest::setRequestHeader):
 789         (WebCore::XMLHttpRequest::getStatus):
 790         (WebCore::XMLHttpRequest::getStatusText):
 791         (WebCore::XMLHttpRequest::processSyncLoadResults):
 792         (WebCore::XMLHttpRequest::receivedAllData):
 793         (WebCore::XMLHttpRequest::receivedData):
 794
 795 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
 796
 797         Reviewed by Jeff Jenkins.
 798
 799         Tweak CF types.
 800
 801         * platform/cf/ResourceLoaderCFNet.cpp:
 802         (WebCore::willCacheResponse):
 803
 804 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
 805
 806         Reviewed by darin
 807
 808         <http://bugzilla.opendarwin.org/show_bug.cgi?id=8029>
 809         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
 810
 811         * dom/Document.cpp:
 812         (WebCore::Document::clearSelectionIfNeeded):
 813         * dom/Element.cpp:
 814         (WebCore::Element::contains):
 815         * dom/Node.cpp:
 816         (WebCore::Node::traverseNextNode):
 817         (WebCore::Node::traverseNextSibling):
 818         (WebCore::Node::traversePreviousNodePostOrder):
 819         (WebCore::Node::checkAddChild):
 820         (WebCore::Node::isDescendantOf):
 821         * dom/Node.h:
 822         * dom/NodeIterator.cpp:
 823         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
 824         * editing/ApplyStyleCommand.cpp:
 825         (WebCore::ApplyStyleCommand::applyBlockStyle):
 826         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
 827         (WebCore::ApplyStyleCommand::applyInlineStyle):
 828         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
 829         * editing/CompositeEditCommand.cpp:
 830         (WebCore::CompositeEditCommand::mergeIdenticalElements):
 831         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
 832         * editing/DeleteSelectionCommand.cpp:
 833         (WebCore::updatePositionForNodeRemoval):
 834         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
 835         (WebCore::DeleteSelectionCommand::mergeParagraphs):
 836         * editing/FormatBlockCommand.cpp:
 837         (WebCore::FormatBlockCommand::doApply):
 838         * editing/IndentOutdentCommand.cpp:
 839         (WebCore::enclosingListOrBlockquote):
 840         * editing/Selection.cpp:
 841         (WebCore::Selection::validate):
 842         * editing/SelectionController.cpp:
 843         (WebCore::SelectionController::nodeWillBeRemoved):
 844         * editing/TextIterator.cpp:
 845         (WebCore::SimplifiedBackwardsTextIterator::advance):
 846         * editing/VisiblePosition.cpp:
 847         (WebCore::VisiblePosition::next):
 848         (WebCore::VisiblePosition::previous):
 849         (WebCore::VisiblePosition::canonicalPosition):
 850         (WebCore::isFirstVisiblePositionInNode):
 851         (WebCore::isLastVisiblePositionInNode):
 852         * editing/htmlediting.cpp:
 853         (WebCore::firstEditablePositionAfterPositionInRoot):
 854         (WebCore::lastEditablePositionBeforePositionInRoot):
 855         (WebCore::enclosingNodeWithTag):
 856         (WebCore::enclosingList):
 857         (WebCore::enclosingListChild):
 858         * editing/markup.cpp:
 859         (WebCore::createMarkup):
 860
 861 2006-09-22  Timothy Hatcher  <timothy@apple.com>
 862
 863         Reviewed by Darin.
 864
 865         - Added @property syntax to non-generated headers
 866           inside #ifndef BUILDING_ON_TIGER.
 867         - Changed the DOMEventTarget protocol to have have new versions
 868           of addEventListener and removeEventListener with named parameters.
 869           These old style methods can be removed once Mail changes to use
 870           the new methods <rdar://problem/4746649>.
 871
 872         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
 873         * bindings/objc/DOM.mm:
 874         (-[DOMNode addEventListener:listener:useCapture:]):
 875         (-[DOMNode addEventListener:::]): call the new method
 876         (-[DOMNode removeEventListener:listener:useCapture:]):
 877         (-[DOMNode removeEventListener:::]): call the new method
 878         * bindings/objc/DOMAbstractView.h:
 879         * bindings/objc/DOMEventTarget.h:
 880         * bindings/objc/DOMHTMLAppletElement.h:
 881         * bindings/objc/DOMHTMLEmbedElement.h:
 882         * bindings/objc/DOMHTMLOptionElement.h:
 883         * bindings/objc/DOMObject.h:
 884         * bindings/objc/DOMRGBColor.h:
 885
 886 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
 887
 888         Reviewed by Eric.
 889
 890         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
 891
 892         * platform/qt/FrameQt.cpp:
 893         * platform/qt/GraphicsContextQt.cpp:
 894         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
 895         (WebCore::GraphicsContext::origin):
 896         * platform/qt/PlatformScrollBar.h: Added.
 897         (WebCore::PlatformScrollBar::isWidget):
 898         * platform/qt/WidgetQt.cpp:
 899         (WebCore::Widget::invalidate):
 900         (WebCore::Widget::invalidateRect):
 901
 902 2006-09-22  Dave Hyatt <hyatt@apple.com>
 903
 904         Super-minor tweaks to the systemFont function on Mac.
 905         Set the generic family to None rather than to Serif, and
 906         don't waste time setting the computed size, since that is
 907         set from the specified size over in CSSStyleSelector anyway.
 908
 909         * rendering/RenderThemeMac.mm:
 910         (WebCore::RenderThemeMac::systemFont):
 911
 912 2006-09-22  Timothy Hatcher  <timothy@apple.com>
 913
 914         Reviewed by Brady.
 915
 916         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
 917         take floats. There was already an implicit conversion to float/double
 918         when calling CGContextTranslateCTM or cairo_translate.
 919
 920         * platform/GraphicsContext.h:
 921         * platform/cairo/GraphicsContextCairo.cpp:
 922         (WebCore::GraphicsContext::translate):
 923         * platform/cg/GraphicsContextCG.cpp:
 924         (WebCore::GraphicsContext::translate):
 925
 926 2006-09-22  Brady Eidson  <beidson@apple.com>
 927
 928         Reviewed by Sfalken
 929
 930         Add redirect and other cleanup to ResourceLoaderWin.cpp
 931         Fixes bug http://bugzilla.opendarwin.org/show_bug.cgi?id=10927
 932         Fixes bug http://bugzilla.opendarwin.org/show_bug.cgi?id=10744
 933
 934         * WebCore.xcodeproj/project.pbxproj:
 935         * platform/ResourceLoader.h:
 936         * platform/win/ResourceLoaderWin.cpp:
 937         (WebCore::ResourceLoaderWndProc):
 938         (WebCore::initializeOffScreenResourceLoaderWindow):
 939         (WebCore::ResourceLoader::onHandleCreated):
 940         (WebCore::ResourceLoader::onRequestRedirected):
 941         (WebCore::ResourceLoader::onRequestComplete):
 942         (WebCore::transferJobStatusCallback):
 943
 944 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
 945
 946         Reviewed by Geoff.
 947
 948         http://bugzilla.opendarwin.org/show_bug.cgi?id=10803
 949         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
 950
 951         * page/FrameView.cpp:
 952         (WebCore::FrameView::hoverTimerFired): Use the current event.
 953
 954 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
 955
 956         Reviewed by Anders.
 957
 958         Fix (last) svg memory leak.
 959
 960         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
 961         (SVGTransformable::parseTransformAttribute):
 962
 963 2006-09-22  Eric Seidel  <eric@eseidel.com>
 964
 965         No review necessary, just removing a dead file.
 966
 967         Remove unused file (added previously by mistake) to make room for real implementation.
 968
 969         * platform/mac/BitmapImageMac.mm: Removed.
 970
 971 2006-09-22  Dave Hyatt <hyatt@apple.com>
 972
 973         Move PlatformScrollBar.h down into the platforms.
 974
 975         Reviewed by andersca
 976
 977         * platform/PlatformScrollBar.h: Removed.
 978         * platform/win/PlatformScrollBar.h: Added.
 979         * platform/mac/PlatformScrollBar.h: Added.
 980
 981 2006-09-22   Dave Hyatt  <hyatt@apple.com>
 982
 983         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
 984         any widget subsystems that don't have any underlying native objects backing the widgets.
 985
 986         Reviewed by anders
 987
 988         * platform/Widget.h:
 989         * platform/mac/WidgetMac.mm:
 990         (WebCore::Widget::invalidate):
 991         (WebCore::Widget::invalidateRect):
 992         * platform/win/TemporaryLinkStubs.cpp:
 993         (Widget::invalidate):
 994         (Widget::invalidateRect):
 995
 996 2006-09-22  Rob Buis  <buis@kd.org>
 997
 998         Reviewed by eseidel.
 999
1000         http://bugzilla.opendarwin.org/show_bug.cgi?id=10901
1001         Merge build fixes from unity
1002
1003         * CMakeLists.txt:
1004
1005 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1006
1007         Reviewed by eseidel.
1008
1009         http://bugzilla.opendarwin.org/show_bug.cgi?id=10977
1010         SVGDocument does not expose 'rootElement' property
1011
1012         Enable 'rootElement' property.
1013
1014         * ksvg2/svg/SVGDocument.idl:
1015
1016 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
1017
1018         Tweak includes.
1019
1020         * platform/ResourceLoaderInternal.h:
1021
1022 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
1023
1024         build fixed. band happy.
1025
1026         * platform/cg/GraphicsContextCG.cpp:
1027         (WebCore::GraphicsContext::translate):
1028         * platform/mac/WidgetMac.mm:
1029
1030 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
1031
1032         Reviewed by Maciej.
1033
1034         Some Widget refactoring.
1035
1036         * WebCore.vcproj/WebCore/WebCore.vcproj:
1037         * bridge/mac/FrameMac.mm:
1038         * bridge/win/FrameWin.cpp:
1039         (WebCore::FrameWin::runJavaScriptAlert):
1040         (WebCore::FrameWin::runJavaScriptConfirm):
1041         * bridge/win/PageWin.cpp:
1042         (WebCore::Page::Page):
1043         (WebCore::rootWindowForFrame):
1044         * html/CanvasRenderingContext2D.cpp:
1045         (WebCore::CanvasRenderingContext2D::translate):
1046         * page/FrameView.cpp:
1047         (WebCore::FrameView::isFrameView):
1048         * page/Page.h:
1049         (WebCore::Page::setInstanceHandle):
1050         (WebCore::Page::instanceHandle):
1051         * platform/GraphicsContext.h:
1052         * platform/ScrollView.h:
1053         * platform/Widget.h:
1054         * platform/cairo/GraphicsContextCairo.cpp:
1055         (WebCore::GraphicsContext::translate):
1056         (WebCore::GraphicsContext::origin):
1057         * platform/mac/WidgetMac.mm:
1058         (WebCore::Widget::clearFocus):
1059         * platform/win/ResourceLoaderWin.cpp:
1060         (WebCore::initializeOffScreenResourceLoaderWindow):
1061         * platform/win/ScreenWin.cpp:
1062         (WebCore::monitorInfo):
1063         * platform/win/ScrollViewWin.cpp:
1064         (WebCore::ScrollView::updateContents):
1065         (WebCore::ScrollView::visibleWidth):
1066         (WebCore::ScrollView::visibleHeight):
1067         (WebCore::ScrollView::visibleContentRect):
1068         (WebCore::ScrollView::viewportToContents):
1069         (WebCore::ScrollView::contentsToViewport):
1070         (WebCore::ScrollView::scrollBy):
1071         (WebCore::ScrollView::updateScrollInfo):
1072         (WebCore::ScrollView::updateScrollBars):
1073         * platform/win/SharedTimerWin.cpp:
1074         (WebCore::initializeOffScreenTimerWindow):
1075         * platform/win/TemporaryLinkStubs.cpp:
1076         (FrameView::updateBorder):
1077         (ScrollView::paint):
1078         (GraphicsContext::clip):
1079         * platform/win/WidgetWin.cpp:
1080         (WebCore::Widget::Widget):
1081         (WebCore::Widget::parentWindow):
1082         (WebCore::Widget::setParentWindow):
1083         (WebCore::Widget::frameGeometry):
1084         (WebCore::Widget::hasFocus):
1085         (WebCore::Widget::setFocus):
1086         (WebCore::Widget::show):
1087         (WebCore::Widget::hide):
1088         (WebCore::Widget::setFrameGeometry):
1089
1090 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
1091
1092         Reviewed by Tim H.
1093
1094         * platform/TextEncoding.cpp:
1095         (WebCore::TextEncoding::backslashAsCurrencySymbol):
1096         Add comment clarifying why backslashAsCurrencySymbol is needed.
1097
1098 2006-09-21  Sean Gies  <seangies@apple.com>
1099
1100         Reviewed by Adam Roben.
1101
1102         Add utility functions to get and release HDC from GraphicsContext.
1103
1104         * platform/GraphicsContext.h: Add utilities to get and release HDC.
1105         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
1106         * rendering/RenderThemeWin.cpp: Switch to new utilities.
1107
1108 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
1109
1110         Reviewed by anders
1111
1112         <rdar://problem/4426622>
1113         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
1114
1115         * editing/htmlediting.cpp:
1116         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
1117         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
1118         Got rid of uses of DepricatedString.
1119
1120 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1121
1122         Reviewed by eseidel.
1123
1124         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
1125
1126         * page/Frame.cpp:
1127         (WebCore::Frame::endIfNotLoading):
1128
1129 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1130
1131         Reviewed by eseidel.
1132
1133         Fix Qt/Linux build.
1134
1135         * CMakeLists.txt:
1136         * kcanvas/device/qt/KCanvasClipperQt.h:
1137         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1138         * platform/qt/FrameQt.cpp:
1139         (WebCore::FrameQt::isLoadTypeReload):
1140         (WebCore::FrameQt::originalRequestURL):
1141         * platform/qt/FrameQt.h:
1142         * platform/qt/GraphicsContextQt.cpp:
1143         (WebCore::GraphicsContext::concatCTM):
1144         * platform/qt/ScrollViewQt.cpp:
1145         (WebCore::ScrollView::wheelEvent):
1146         * platform/qt/TemporaryLinkStubs.cpp:
1147         (WebCore::IconDatabase::setIconURLForPageURL):
1148
1149 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
1150
1151         Reviewed by john
1152
1153         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
1154         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
1155
1156         * editing/MoveSelectionCommand.cpp:
1157         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
1158         to the position-to-move-to's document, not the fragment's document.  The
1159         fragment's document is the document used to create the fragment and is irrelavant.
1160
1161 === Safari-521.27 ===
1162
1163 2006-09-21  Brady Eidson  <beidson@apple.com>
1164
1165         Reviewed by Anders
1166
1167         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
1168         This fixes Spinneret so it won't crash on its first load!
1169
1170         * page/Frame.cpp:
1171         (WebCore::Frame::endIfNotLoading):
1172
1173 2006-09-21  Brady Eidson  <beidson@apple.com>
1174
1175         Build fix
1176
1177         * platform/win/TemporaryLinkStubs.cpp:
1178         (ScrollView::wheelEvent):
1179
1180 2006-09-20  Rob Buis  <buis@kde.org>
1181
1182         Reviewed by eseidel.
1183
1184         http://bugzilla.opendarwin.org/show_bug.cgi?id=10946
1185         new marker code draws end-marker in wrong place
1186
1187         Keep track of the start of the subpath so we can handle
1188         closeTo/moveTo correctly.
1189
1190         * kcanvas/RenderPath.cpp:
1191         (WebCore::DrawMarkersData::DrawMarkersData):
1192         (WebCore::updateMarkerDataForElement):
1193
1194 2006-09-21  David Hyatt <hyatt@apple.com>
1195
1196         Wheel scrolling prep for Win32.
1197
1198         WARNING: NO TEST CASES ADDED OR CHANGED
1199
1200         * platform/PlatformWheelEvent.h:
1201         * platform/ScrollBar.h:
1202         * platform/ScrollView.h:
1203         * platform/mac/ScrollViewMac.mm:
1204         (WebCore::ScrollView::wheelEvent):
1205         * rendering/RenderLayer.cpp:
1206
1207 2006-09-20  Timothy Hatcher  <timothy@apple.com>
1208
1209         Reviewed by Hyatt.
1210
1211         Bug 10917: REGRESSION (r16027): iFrame transparency broken
1212         http://bugzilla.opendarwin.org/show_bug.cgi?id=10917
1213
1214         Don't paint the base background color if we transparent.
1215
1216         * rendering/RenderBox.cpp:
1217         (WebCore::RenderBox::paintBackgroundExtended):
1218
1219 2006-09-20  Adam Roben  <aroben@apple.com>
1220
1221         Reviewed by andersca.
1222
1223         * platform/FileChooser.h: Remove no-longer-necessary namespace std
1224
1225 2006-09-20  Eric Seidel  <eric@eseidel.com>
1226
1227         Reviewed by beth.
1228
1229         Cleanup style in KCanvas.
1230         Remove extra white-space, unneeded arguments, etc.
1231
1232         * WebCore.xcodeproj/project.pbxproj:
1233         * kcanvas/KCanvasClipper.cpp:
1234         (WebCore::operator<<):
1235         (WebCore::KCanvasClipper::externalRepresentation):
1236         * kcanvas/KCanvasClipper.h:
1237         * kcanvas/KCanvasFilters.cpp:
1238         (WebCore::KCanvasFilter::externalRepresentation):
1239         (WebCore::operator<<):
1240         (WebCore::KCanvasFilterEffect::externalRepresentation):
1241         (WebCore::KCPointLightSource::externalRepresentation):
1242         (WebCore::KCSpotLightSource::externalRepresentation):
1243         (WebCore::KCDistantLightSource::externalRepresentation):
1244         (WebCore::KCanvasFEBlend::externalRepresentation):
1245         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
1246         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
1247         (WebCore::KCanvasFEComposite::externalRepresentation):
1248         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
1249         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
1250         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
1251         (WebCore::KCanvasFEFlood::externalRepresentation):
1252         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
1253         (WebCore::KCanvasFEImage::externalRepresentation):
1254         (WebCore::KCanvasFEMerge::externalRepresentation):
1255         (WebCore::KCanvasFEMorphology::externalRepresentation):
1256         (WebCore::KCanvasFEOffset::externalRepresentation):
1257         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
1258         (WebCore::KCanvasFETile::externalRepresentation):
1259         (WebCore::KCanvasFETurbulence::externalRepresentation):
1260         * kcanvas/KCanvasFilters.h:
1261         (WebCore::KCanvasFEDiffuseLighting::lightSource):
1262         (WebCore::KCanvasFESpecularLighting::lightSource):
1263         * kcanvas/KCanvasImage.h:
1264         * kcanvas/KCanvasMarker.cpp:
1265         (WebCore::KCanvasMarker::externalRepresentation):
1266         * kcanvas/KCanvasMarker.h:
1267         * kcanvas/KCanvasResource.cpp:
1268         (WebCore::operator<<):
1269         * kcanvas/KCanvasResource.h:
1270         * kcanvas/KCanvasTreeDebug.cpp:
1271         (WebCore::operator<<):
1272         (WebCore::writeIndent):
1273         (WebCore::writeStyle):
1274         (WebCore::write):
1275         (WebCore::writeRenderResources):
1276         * kcanvas/KCanvasTreeDebug.h:
1277         (WebCore::operator<<):
1278         * kcanvas/RenderForeignObject.cpp:
1279         (WebCore::RenderForeignObject::paint):
1280         * kcanvas/RenderPath.cpp:
1281         (WebCore::RenderPath::paint):
1282         (WebCore::drawStartAndMidMarkers):
1283         * kcanvas/RenderSVGContainer.cpp:
1284         (WebCore::RenderSVGContainer::paint):
1285         * kcanvas/RenderSVGImage.cpp:
1286         (WebCore::RenderSVGImage::translateForAttributes):
1287         * kcanvas/RenderSVGImage.h:
1288         * kcanvas/device/KRenderingDevice.cpp:
1289         (WebCore::KRenderingDevice::currentContext):
1290         (WebCore::KRenderingDevice::popContext):
1291         (WebCore::KRenderingDevice::pushContext):
1292         * kcanvas/device/KRenderingDevice.h:
1293         * kcanvas/device/KRenderingFillPainter.h:
1294         * kcanvas/device/KRenderingPaintServer.h:
1295         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1296         (WebCore::KRenderingPaintServer::activeClient):
1297         (WebCore::KRenderingPaintServer::setActiveClient):
1298         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1299         (WebCore::operator<<):
1300         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
1301         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
1302         (WebCore::KRenderingPaintServerGradient::listener):
1303         (WebCore::KRenderingPaintServerGradient::setListener):
1304         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
1305         * kcanvas/device/KRenderingPaintServerGradient.h:
1306         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1307         (WebCore::KRenderingPaintServerPattern::tile):
1308         (WebCore::KRenderingPaintServerPattern::setTile):
1309         (WebCore::KRenderingPaintServerPattern::listener):
1310         (WebCore::KRenderingPaintServerPattern::setListener):
1311         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
1312         * kcanvas/device/KRenderingPaintServerPattern.h:
1313         * kcanvas/device/KRenderingPaintServerSolid.cpp:
1314         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
1315         * kcanvas/device/KRenderingPaintServerSolid.h:
1316         * kcanvas/device/KRenderingStrokePainter.cpp:
1317         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
1318         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
1319         * kcanvas/device/KRenderingStrokePainter.h:
1320         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
1321         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1322         (WebCore::KCanvasFilterQuartz::prepareFilter):
1323         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
1324         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1325         (WebCore::KCanvasMaskerQuartz::applyMask):
1326         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1327         (WebCore::KCanvasImageQuartz::init):
1328         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1329         (WebCore::KCanvasClipperQuartz::applyClip):
1330         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1331         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1332         (WebCore::KRenderingDeviceQuartz::quartzContext):
1333         (WebCore::KRenderingDeviceQuartz::contextForImage):
1334         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1335         (WebCore::KRenderingDeviceQuartz::createResource):
1336         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
1337         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1338         (WebCore::CGShadingRefForLinearGradient):
1339         (WebCore::CGShadingRefForRadialGradient):
1340         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
1341         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1342         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1343         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1344         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
1345         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
1346         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
1347         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
1348         (WebCore::KRenderingPaintServerSolidQuartz::draw):
1349         (WebCore::KRenderingPaintServerSolidQuartz::setup):
1350         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
1351         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1352         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
1353         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
1354         * kcanvas/device/quartz/QuartzSupport.h:
1355         * kcanvas/device/quartz/QuartzSupport.mm:
1356         (WebCore::applyStrokeStyleToContext):
1357
1358 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1359
1360         Reviewed by Dave Hyatt.
1361
1362         * dom/WheelEvent.cpp:
1363         (WebCore::WheelEvent::WheelEvent):
1364         Use lroundf instead of lround since deltas are floats.
1365
1366 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
1367
1368         Reviewed by eseidel.  Landed by eseidel.
1369
1370         Test: svg/custom/pattern-y-offset.svg
1371
1372         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1373         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1374
1375 2006-09-20  David Hyatt  <hyatt@apple.com>
1376
1377         Add a new wheelEvent method to ScrollView.  Platforms that wish
1378         to handle the wheel event for the scroll view themselves can then
1379         do so there.  (Mac lets the underlying NSScrollView do it for now.)
1380
1381         * page/FrameView.cpp:
1382         (WebCore::FrameView::handleWheelEvent):
1383         * platform/ScrollView.h:
1384         (WebCore::ScrollView::wheelEvent):
1385
1386 2006-09-20  Brady Eidson  <beidson@apple.com>
1387
1388         Reviewed by Tim Omernick
1389
1390         Part of fixing a crash Tim O showed me that I missed in a release build.
1391         WebKit should be able to call through the bridge to WebCore no matter what -
1392         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
1393
1394         * bridge/mac/WebCoreIconDatabaseBridge.h:
1395         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1396         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
1397         (-[WebCoreIconDatabaseBridge isOpen]):
1398         (-[WebCoreIconDatabaseBridge removeAllIcons]):
1399         (-[WebCoreIconDatabaseBridge _isEmpty]):
1400         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
1401         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
1402         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
1403         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
1404         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
1405         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
1406         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
1407         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
1408         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
1409         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
1410         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
1411         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
1412         (-[WebCoreIconDatabaseBridge _setEnabled:]):
1413         (-[WebCoreIconDatabaseBridge _isEnabled]):
1414
1415 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1416
1417         Reviewed by Darin.
1418
1419         Add String::split which returns a Vector of Strings and use it instead of
1420         DeprecatedStringList.
1421
1422         * bindings/js/kjs_events.cpp:
1423         (KJS::Clipboard::getValueProperty):
1424         * bindings/js/kjs_window.cpp:
1425         (KJS::parseModalDialogFeatures):
1426         * css/MediaList.cpp:
1427         (WebCore::MediaList::setMediaText):
1428         * dom/Clipboard.h:
1429         * html/HTMLFormElement.cpp:
1430         (WebCore::HTMLFormElement::formData):
1431         * html/HTMLLinkElement.cpp:
1432         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
1433         * platform/PlatformString.h:
1434         * platform/String.cpp:
1435         (WebCore::String::split):
1436         * platform/StringImpl.cpp:
1437         * platform/StringImpl.h:
1438         * platform/mac/ClipboardMac.h:
1439         * platform/mac/ClipboardMac.mm:
1440         (WebCore::ClipboardMac::types):
1441
1442 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
1443
1444         Reviewed by harrison
1445
1446         * css/cssstyleselector.cpp:
1447         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
1448         HTMLElement::isContentEditable just to check the Frame's editability, since
1449         it calls updateRenderering, which can get us into infinite recursion.
1450
1451 2006-09-20  Brady Eidson  <beidson@apple.com>
1452
1453         Reviewed by Darin
1454
1455         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
1456
1457         * loader/icon/IconDatabase.cpp:
1458         (WebCore::IconDatabase::IconDatabase): Disabled by default
1459         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
1460         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
1461         (WebCore::IconDatabase::iconForPageURL): Ditto
1462         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
1463         (WebCore::IconDatabase::iconURLForPageURL): Ditto
1464         (WebCore::IconDatabase::retainIconForPageURL): Ditto
1465         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
1466         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
1467         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
1468         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
1469         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
1470
1471 2006-09-20  Adam Roben  <aroben@apple.com>
1472
1473         Reviewed by Adele.
1474
1475         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
1476         REGRESSION: file upload control with direction:rtl or text-align:right
1477         draws button on top of filename/icon
1478
1479         * rendering/RenderFileUploadControl.cpp:
1480         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
1481         match direction
1482         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
1483         the filename and icon in RTL
1484
1485 2006-09-20  Alice Liu  <alice.liu@apple.com>
1486
1487         Reviewed by Adam Roben.
1488
1489         fixed windows build
1490
1491         * dom/WheelEvent.cpp:
1492         (WebCore::WheelEvent::WheelEvent):
1493         changed lrint to lround
1494
1495 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
1496
1497         Build Fix.  Adds isHorizontal attribute back to WheelEvent
1498         for the Objective-C bindings.  If it is found that isHorizontal
1499         is not used, we should remove it again but also remove it's
1500         declaration from PublicDOMInterfaces.h
1501
1502         * dom/WheelEvent.h:
1503         (WebCore::WheelEvent::isHorizontal):
1504         * dom/WheelEvent.idl:
1505
1506 2006-09-20  David Hyatt  <hyatt@apple.com>
1507
1508         Fix for 10945, WheelEvent should support two dimensions at once, since
1509         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
1510         to allow for diagonal scrolling.
1511
1512         Reviewed by Eric
1513
1514         * dom/EventTargetNode.cpp:
1515         (WebCore::EventTargetNode::dispatchWheelEvent):
1516         * dom/WheelEvent.cpp:
1517         (WebCore::WheelEvent::WheelEvent):
1518         (WebCore::WheelEvent::initWheelEvent):
1519         * dom/WheelEvent.h:
1520         (WebCore::WheelEvent::wheelDelta):
1521         (WebCore::WheelEvent::wheelDeltaX):
1522         (WebCore::WheelEvent::wheelDeltaY):
1523         * dom/WheelEvent.idl:
1524         * page/FrameView.cpp:
1525         (WebCore::FrameView::handleWheelEvent):
1526         * platform/PlatformWheelEvent.h:
1527         (WebCore::PlatformWheelEvent::deltaX):
1528         (WebCore::PlatformWheelEvent::deltaY):
1529         (WebCore::PlatformWheelEvent::normalize):
1530         * platform/mac/WheelEventMac.mm:
1531         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1532
1533 2006-09-19  Eric Seidel  <eric@eseidel.com>
1534
1535         Reviewed by hyatt.
1536
1537         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
1538
1539         No tests were harmed in the making of this patch.
1540
1541         * WebCore.xcodeproj/project.pbxproj:
1542         * kcanvas/KCanvasClipper.cpp: Added.
1543         (WebCore::operator<<):
1544         * kcanvas/KCanvasClipper.h: Added.
1545         * kcanvas/KCanvasFilters.h:
1546         * kcanvas/KCanvasImage.h:
1547         * kcanvas/KCanvasMarker.cpp: Added.
1548         * kcanvas/KCanvasMarker.h: Added.
1549         * kcanvas/KCanvasMasker.cpp: Added.
1550         (WebCore::KCanvasMasker::KCanvasMasker):
1551         (WebCore::KCanvasMasker::setMask):
1552         (WebCore::KCanvasMasker::externalRepresentation):
1553         (WebCore::getMaskerById):
1554         * kcanvas/KCanvasMasker.h: Added.
1555         * kcanvas/KCanvasResource.cpp: Added.
1556         (WebCore::KCanvasResource::invalidate):
1557         (WebCore::KCanvasResource::externalRepresentation):
1558         (WebCore::getResourceById):
1559         (WebCore::getPaintServerById):
1560         * kcanvas/KCanvasResource.h: Added.
1561         * kcanvas/KCanvasResources.cpp: Removed.
1562         * kcanvas/KCanvasResources.h: Removed.
1563         * kcanvas/RenderPath.cpp:
1564         * kcanvas/RenderSVGContainer.cpp:
1565         * kcanvas/RenderSVGImage.cpp:
1566         * kcanvas/RenderSVGText.cpp:
1567         * kcanvas/device/KRenderingPaintServer.h:
1568         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1569         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1570         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1571         * ksvg2/svg/SVGClipPathElement.h:
1572         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1573         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
1574         * ksvg2/svg/SVGFECompositeElement.cpp:
1575         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1576         * ksvg2/svg/SVGFELightElement.cpp:
1577         * ksvg2/svg/SVGFEOffsetElement.cpp:
1578         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1579         * ksvg2/svg/SVGFilterElement.cpp:
1580         * ksvg2/svg/SVGLinearGradientElement.cpp:
1581         * ksvg2/svg/SVGMarkerElement.h:
1582         * ksvg2/svg/SVGMaskElement.h:
1583
1584 2006-09-19  Brady Eidson <beidson@apple.com>
1585
1586         Reviewed by Sarge Decker
1587
1588         <rdar://problem/4739892> and <rdar://problem/4729797>
1589         - WebCore::IconDatabase needs to have and respect an enabled() flag
1590         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
1591
1592         * bridge/mac/WebCoreIconDatabaseBridge.h:
1593         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1594         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
1595         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
1596         * loader/icon/IconDatabase.cpp:
1597         (WebCore::IconDatabase::IconDatabase):
1598         (WebCore::IconDatabase::open): Don't open if disabled
1599         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
1600         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
1601         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
1602         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
1603         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
1604         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
1605         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
1606         (WebCore::IconDatabase::releaseIconURL):
1607         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
1608         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
1609         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
1610         (WebCore::IconDatabase::setEnabled): Added
1611         * loader/icon/IconDatabase.h:
1612         (WebCore::IconDatabase::enabled): Added
1613         * page/Frame.cpp:
1614         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
1615         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
1616
1617 2006-09-20  David Hyatt  <hyatt@apple.com>
1618
1619         Massage mouse wheel handling so that it is more cross-platform.  Make
1620         all the work happen in handleWheelEvent on the FrameView.
1621
1622         Reviewed by bradee-oh
1623
1624         * bridge/mac/FrameMac.mm:
1625         (WebCore::FrameMac::wheelEvent):
1626         * page/FrameView.cpp:
1627         (WebCore::FrameView::handleWheelEvent):
1628         * platform/PlatformWheelEvent.h:
1629         (WebCore::PlatformWheelEvent::platformDelta):
1630         (WebCore::PlatformWheelEvent::delta):
1631         * platform/mac/WheelEventMac.mm:
1632         (WebCore::platformDeltaForEvent):
1633         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1634         * rendering/RenderLayer.cpp:
1635         (WebCore::RenderLayer::scroll):
1636         * rendering/RenderObject.cpp:
1637         (WebCore::RenderObject::scroll):
1638
1639 2006-09-19  Eric Seidel  <eric@eseidel.com>
1640
1641         Reviewed by adele.
1642
1643         Improve test output for filters with bounding-box relative sizes.
1644         http://bugzilla.opendarwin.org/show_bug.cgi?id=8585
1645
1646         Many test results updated.
1647
1648         * kcanvas/KCanvasFilters.cpp:
1649         (WebCore::KCanvasFilter::externalRepresentation):
1650
1651 2006-09-19  Eric Seidel  <eric@eseidel.com>
1652
1653         Reviewed by adele.
1654
1655         Markers should clip to their viewport.
1656         http://bugzilla.opendarwin.org/show_bug.cgi?id=5967
1657
1658         Test: svg/custom/marker-overflow-clip.svg
1659
1660         * kcanvas/KCanvasResources.cpp:
1661         (WebCore::KCanvasMarker::KCanvasMarker):
1662         (WebCore::KCanvasMarker::setMarker):
1663         (WebCore::KCanvasMarker::draw):
1664         * kcanvas/KCanvasResources.h:
1665         (WebCore::KCanvasMasker::mask):
1666         * ksvg2/svg/SVGMarkerElement.cpp:
1667         (WebCore::SVGMarkerElement::SVGMarkerElement):
1668         (WebCore::SVGMarkerElement::parseMappedAttribute):
1669         (WebCore::SVGMarkerElement::canvasResource):
1670         (WebCore::SVGMarkerElement::createRenderer):
1671
1672 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1673
1674         Reviewed by eseidel
1675
1676         Backing out my recent change.
1677
1678         * css/cssstyleselector.cpp:
1679         (WebCore::CSSStyleSelector::adjustRenderStyle):
1680
1681 2006-09-19  Brady Eidson  <beidson@apple.com>
1682
1683         Reviewed by Kevin McCullough
1684
1685         http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
1686         Opening a PDF in a new tab/window creates a documentless-frame
1687         and we deref the document without checking its validity
1688
1689         * page/Frame.cpp:
1690         (WebCore::Frame::iconURL):
1691
1692 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1693
1694         Reviewed by harrison
1695
1696         <rdar://problem/4735272>
1697         Can not click into link in programmatically editable content
1698
1699         * css/cssstyleselector.cpp:
1700         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
1701         userModify to implement document wide editability.
1702
1703 2006-09-19  MorganL  <morlmor@yahoo.com>
1704
1705         Reviewed by Darin and landed by Brady
1706
1707         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10939
1708         Build broken when SVG is not enabled.
1709
1710         * dom/XMLTokenizer.cpp:
1711         (WebCore::XMLTokenizer::startElementNs):
1712
1713 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1714
1715         Reviewed by harrison
1716
1717         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
1718
1719         Pasting plain text results in a match style paste, and the insertion
1720         position is whitespace normal, which clobbers the whitespace:pre on
1721         tab spans.  Skip changes to the whitespace mode when computing a style
1722         change for tab spans or the text nodes inside tab spans.
1723
1724         * editing/ApplyStyleCommand.cpp:
1725         (WebCore::StyleChange::init): Don't change the whitespace mode inside
1726         tab spans.
1727
1728 2006-09-19  David Hyatt  <hyatt@apple.com>
1729
1730         Fix for bug 5298, shape=default not supported for image maps.  Implement
1731         support for it.
1732
1733         Reviewed by timo
1734
1735         * html/HTMLAreaElement.cpp:
1736         (WebCore::HTMLAreaElement::getRegion):
1737         * html/HTMLMapElement.cpp:
1738         (WebCore::HTMLMapElement::mapMouseEvent):
1739
1740 2006-09-19  Adam Roben  <aroben@apple.com>
1741
1742         Reviewed by Adele.
1743
1744         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10824
1745         "no file selected" placeholder text missing from file upload control
1746
1747         * WebCore.xcodeproj/project.pbxproj:
1748         * rendering/RenderFileUploadControl.cpp: Remove class
1749         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
1750         defaultWidthNumChars
1751         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
1752         RenderBlock constructor instead of RenderFlexibleBox,
1753         (WebCore::RenderFileUploadControl::setStyle): Remove references to
1754         m_fileBox.
1755         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
1756         instead of updateIconAndFileName() (which has been removed)
1757         (WebCore::RenderFileUploadControl::updateFromElement): Remove
1758         references to m_fileBox, don't call updateIconAndFilename()
1759         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
1760         without using m_fileBox
1761         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
1762         now-unnecessary display:box rule.
1763         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
1764         to paintingDisabled() now that Icon::paint() does it, and add code to
1765         paint the filename directly.
1766         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
1767         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
1768         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
1769         subclass of RenderBlock instead of RenderFlexibleBox, remove
1770         updateIconAndFilename() method, remove m_fileBox instance variable.
1771
1772 2006-09-19  Eric Seidel  <eric@eseidel.com>
1773
1774         Reviewed by hyatt.
1775
1776         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
1777         http://bugzilla.opendarwin.org/show_bug.cgi?id=10846
1778
1779         No automated test case possible until http://bugzilla.opendarwin.org/show_bug.cgi?id=10905 is resolved.
1780
1781         * dom/XMLTokenizer.cpp:
1782         (WebCore::XMLTokenizer::XMLTokenizer):
1783         (WebCore::XMLTokenizer::startElementNs):
1784         (WebCore::XMLTokenizer::endElementNs):
1785
1786 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
1787
1788         Reviewed by eseidel.  Landed by eseidel.
1789
1790         Build fix only, no tests affected.
1791
1792         * platform/gdk/FontPlatformDataGdk.cpp:
1793         (WebCore::FontPlatformData::FontPlatformData):
1794         (WebCore::FontPlatformData::~FontPlatformData):
1795         * platform/gdk/FrameGdk.h:
1796         * platform/gdk/TemporaryLinkStubs.cpp:
1797         (FrameGdk::isLoadTypeReload):
1798         (FrameGdk::originalRequestURL):
1799         (IconDatabase::setIconURLForPageURL):
1800
1801 2006-09-19  David Hyatt  <hyatt@apple.com>
1802
1803         Refine the fix for 9805 to really get all the complex cases right.
1804
1805         Reviewed by Eric
1806
1807         * rendering/RenderBlock.cpp:
1808         (WebCore::RenderBlock::clearFloatsIfNeeded):
1809         (WebCore::RenderBlock::handleBottomOfBlock):
1810
1811 2006-09-18  David Hyatt  <hyatt@apple.com>
1812
1813         Fix for 9805, <hr> not positioned properly following a previous empty sibling
1814         that had clear:both set on it.  Update self-collapsing block clearance
1815         behavior to match what is specified in the latest draft of CSS2.1.
1816
1817         Reviewed by Eric
1818
1819         Added fast/block/margin-collapse/empty-clear-blocks.html
1820
1821         * rendering/RenderBlock.cpp:
1822         (WebCore::RenderBlock::clearFloatsIfNeeded):
1823         (WebCore::RenderBlock::handleBottomOfBlock):
1824
1825 2006-09-18  MorganL  <morlmor@yahoo.com>
1826
1827         Reviewed by Brady, landed by Brady
1828
1829         Send receivedResponse callback to ResourceLoaderClient when loading
1830         file URLs.
1831
1832         See http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
1833
1834         * platform/win/ResourceLoaderWin.cpp:
1835         (WebCore::ResourceLoader::fileLoadTimer):
1836
1837 2006-09-18  Brady Eidson  <beidson@apple.com>
1838
1839         Reviewed by Anders
1840
1841         <rdar://problem/3028061> - WebKit never updates favicon
1842         The WebKit enforced expiration date for icons has worked for some time, but the
1843         move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
1844         functionality.  This patch fixes that up, along with some other architectural improvements,
1845         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
1846
1847         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
1848         * bridge/mac/FrameMac.mm:
1849         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
1850         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
1851         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
1852         * dom/Document.h: Added m_iconURL
1853         (WebCore::Document::iconURL): Added
1854         (WebCore::Document::setIconURL): Ditto
1855         * html/HTMLLinkElement.cpp:
1856         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
1857         * page/Frame.cpp:
1858         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
1859         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
1860         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
1861         * page/FramePrivate.h: Nuked IconURL
1862         * platform/win/TemporaryLinkStubs.cpp:
1863         (FrameWin::isLoadTypeReload):
1864
1865 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
1866
1867         Reviewed by Tim H.
1868
1869         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
1870           it is it turns out that AppKit uses it.
1871
1872         * bindings/objc/DOMPrivate.h:
1873         * bindings/objc/DOMRGBColor.mm:
1874         (-[DOMRGBColor _color]):
1875
1876 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
1877
1878         Reviewed by Tim H.
1879
1880         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
1881         Yet Another Objective-C Bindings Patch
1882
1883         - Whitespace cleanup for IDLParser.pm
1884
1885         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
1886           and DOMAbstractView into their own files.
1887
1888         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
1889           it is not used and a public method is available now.
1890
1891         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
1892           as it not used.
1893
1894         - Auto-generate method isContentEditable for DOMNode.
1895
1896         - General cleanup of bindings code including removing unneeded #imports
1897           and whitespace cleanup
1898
1899         * WebCore.xcodeproj/project.pbxproj:
1900         * bindings/objc/DOM.mm:
1901         (addElementClass):
1902         (elementClass):
1903         (-[DOMNode _initWithNode:WebCore::]):
1904         (+[DOMNode _nodeWith:WebCore::]):
1905         (-[DOMNode WebCore::]):
1906         (-[DOMNode KJS::Bindings::]):
1907         (-[DOMNode addEventListener:::]):
1908         (-[DOMNode removeEventListener:::]):
1909         (-[DOMNode dispatchEvent:]):
1910         (-[DOMElement image]):
1911         (-[DOMElement _font]):
1912         (-[DOMElement _imageTIFFRepresentation]):
1913         (-[DOMElement _getURLAttribute:]):
1914         (-[DOMElement _NPObject]):
1915         (-[DOMElement isFocused]):
1916         (-[DOMRange dealloc]):
1917         (-[DOMRange finalize]):
1918         (-[DOMRange description]):
1919         (-[DOMRange startContainer]):
1920         (-[DOMRange startOffset]):
1921         (-[DOMRange endContainer]):
1922         (-[DOMRange endOffset]):
1923         (-[DOMRange collapsed]):
1924         (-[DOMRange commonAncestorContainer]):
1925         (-[DOMRange setStart::]):
1926         (-[DOMRange setEnd::]):
1927         (-[DOMRange setStartBefore:]):
1928         (-[DOMRange setStartAfter:]):
1929         (-[DOMRange setEndBefore:]):
1930         (-[DOMRange setEndAfter:]):
1931         (-[DOMRange collapse:]):
1932         (-[DOMRange selectNode:]):
1933         (-[DOMRange selectNodeContents:]):
1934         (-[DOMRange compareBoundaryPoints::]):
1935         (-[DOMRange deleteContents]):
1936         (-[DOMRange extractContents]):
1937         (-[DOMRange cloneContents]):
1938         (-[DOMRange insertNode:]):
1939         (-[DOMRange surroundContents:]):
1940         (-[DOMRange cloneRange]):
1941         (-[DOMRange toString]):
1942         (-[DOMRange detach]):
1943         (-[DOMRange _initWithRange:WebCore::]):
1944         (+[DOMRange _rangeWith:WebCore::]):
1945         (-[DOMRange WebCore::]):
1946         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1947         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
1948         (-[DOMNodeFilter WebCore::]):
1949         (-[DOMNodeFilter dealloc]):
1950         (-[DOMNodeFilter finalize]):
1951         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
1952         (-[DOMNodeIterator WebCore::]):
1953         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
1954         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
1955         (-[DOMTreeWalker WebCore::]):
1956         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
1957         (ObjCNodeFilterCondition::acceptNode):
1958         (-[DOMDocument createNodeIterator::::]):
1959         (-[DOMDocument createTreeWalker::::]):
1960         (ObjCEventListener::find):
1961         (ObjCEventListener::create):
1962         (ObjCEventListener::handleEvent):
1963         * bindings/objc/DOMAbstractView.h: Added.
1964         * bindings/objc/DOMAbstractView.mm: Added.
1965         (-[DOMAbstractView document]):
1966         (-[DOMAbstractView WebCore::]):
1967         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
1968         (+[DOMAbstractView _abstractViewWith:WebCore::]):
1969         * bindings/objc/DOMCSS.mm:
1970         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1971         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
1972         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
1973         (-[DOMCSSRule _initWithRule:WebCore::]):
1974         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
1975         (-[DOMCSSValue _initWithValue:WebCore::]):
1976         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1977         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
1978         (-[DOMDocument getComputedStyle::]):
1979         (-[DOMDocument getMatchedCSSRules::]):
1980         * bindings/objc/DOMCore.h:
1981         * bindings/objc/DOMEventException.h: Added.
1982         * bindings/objc/DOMEvents.h:
1983         * bindings/objc/DOMEvents.mm:
1984         * bindings/objc/DOMException.h: Added.
1985         * bindings/objc/DOMHTML.mm:
1986         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
1987         (viewForElement):
1988         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
1989         (-[DOMHTMLInputElement _selectedRange]):
1990         (-[DOMHTMLInputElement _setAutofilled:]):
1991         * bindings/objc/DOMInternal.h:
1992         * bindings/objc/DOMObject.h:
1993         * bindings/objc/DOMPrivate.h:
1994         * bindings/objc/DOMRange.h:
1995         * bindings/objc/DOMRangeException.h: Added.
1996         * bindings/objc/DOMViews.h:
1997         * bindings/objc/DOMViews.mm: Removed.
1998         * bindings/objc/DOMXPath.h:
1999         * bindings/objc/DOMXPathException.h: Added.
2000         * bindings/scripts/IDLParser.pm:
2001         * dom/Node.idl:
2002
2003 2006-09-18  Brady Eidson  <beidson@apple.com>
2004
2005         Windows build fix
2006
2007         * platform/win/TemporaryLinkStubs.cpp:
2008         (IconDatabase::setIconURLForPageURL):
2009
2010 2006-09-18  David Hyatt  <hyatt@apple.com>
2011
2012         Fix for bug 3969, hr width doesn't update when it clears a float.  This
2013         was also a problem with tables and overflow sections.
2014
2015         Reviewed by Eric
2016
2017         Added fast/block/float/width-update-after-clear.html
2018
2019         * rendering/RenderBlock.cpp:
2020         (WebCore::RenderBlock::collapseMargins):
2021         (WebCore::RenderBlock::clearFloatsIfNeeded):
2022
2023 2006-09-18  Brady Eidson  <beidson@apple.com>
2024
2025         Reviewed by John
2026
2027         http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
2028         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
2029
2030         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
2031         * bridge/win/FrameWin.h: Added originalRequestURL()
2032         * loader/icon/IconLoader.cpp:
2033         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
2034         * page/Frame.cpp:
2035         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
2036         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
2037         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
2038         * page/Frame.h: Added pure virtual originalRequestURL()
2039         * platform/win/TemporaryLinkStubs.cpp:
2040         (FrameWin::originalRequestURL): Added
2041
2042 2006-09-18  Rob Buis  <buis@kde.org>
2043
2044         Reviewed by Maciej.
2045
2046         http://bugzilla.opendarwin.org/show_bug.cgi?id=10807
2047         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
2048
2049         Make sure the paint method is not exited without popping
2050         context and transparency layer.
2051
2052         WARNING: NO TEST CASES ADDED OR CHANGED
2053
2054         * kcanvas/RenderSVGImage.cpp:
2055         (WebCore::RenderSVGImage::paint):
2056
2057 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
2058
2059         Reviewed by Eric.
2060
2061         - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10896
2062         REGRESSION: WebKit can't be built with SVG disabled
2063
2064         * bindings/scripts/CodeGeneratorObjC.pm:
2065         For each file generated add a #ifdef <something>_SUPPORT / #endif
2066         pair if the idl file has a Conditional extended attribute
2067
2068 2006-09-17  Eric Seidel  <eric@eseidel.com>
2069
2070         Reviewed by ap.
2071
2072         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
2073         http://bugzilla.opendarwin.org/show_bug.cgi?id=10813
2074
2075         * bridge/mac/WebCoreFrameBridge.mm:
2076         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
2077
2078 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
2079
2080         Reviewed by Hyatt.
2081
2082         http://bugzilla.opendarwin.org/show_bug.cgi?id=10779
2083         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
2084
2085         No test possible.
2086
2087         * platform/Image.cpp:
2088         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
2089         maybe the rest just hasn't been loaded yet.
2090         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
2091         to start animating before we get at least two frames.
2092
2093 2006-09-17  Brady Eidson <beidson@apple.com>
2094
2095         Reviewed by Sarge
2096
2097         IconLoader now gracefully handles the condition where there's no document in the frame
2098         (ie. PDFs)
2099
2100         * loader/icon/IconLoader.cpp:
2101         (IconLoader::startLoading):
2102
2103 2006-09-17  David Hyatt  <hyatt@apple.com>
2104
2105         Fix for bug 10899, rework how CSS keywords work to be smarter about
2106         using the correct size when generic families change (e.g., monospace to
2107         serif and vice versa).
2108
2109         Reviewed by aroben
2110
2111         Added fast/text/basic/generic-family-changes.html
2112
2113         * css/cssstyleselector.cpp:
2114         (WebCore::CSSStyleSelector::applyProperty):
2115         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
2116         (WebCore::CSSStyleSelector::fontSizeForKeyword):
2117         * css/cssstyleselector.h:
2118         * dom/Document.cpp:
2119         (WebCore::Document::recalcStyle):
2120         * platform/FontDescription.h:
2121         (WebCore::FontDescription::FontDescription):
2122         (WebCore::FontDescription::keywordSize):
2123         (WebCore::FontDescription::setKeywordSize):
2124         (WebCore::FontDescription::operator==):
2125
2126 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
2127
2128         Reviewed by Brady.
2129
2130         http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
2131         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
2132
2133         Test: http/tests/xmlhttprequest/xhr-onunload.html
2134
2135         * xml/xmlhttprequest.cpp:
2136         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
2137
2138         * loader/icon/IconLoader.cpp:
2139         (IconLoader::startLoading): Fix a similar latent bug here.
2140
2141 2006-09-17  Adam Roben  <aroben@apple.com>
2142
2143         Build fix.
2144
2145         * loader/icon/IconDatabase.cpp:
2146
2147 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
2148
2149         Reviewed by Brady.
2150
2151         Add simplifyWhiteSpace and stripWhiteSpace to the String class.
2152         Change the XSLT Parameter Map to use Strings instead of StringImpls.
2153         General cleanup.
2154
2155         * bindings/js/JSXSLTProcessor.cpp:
2156         (KJS::XSLTProcessorProtoFunc::callAsFunction):
2157         * bindings/js/kjs_events.cpp:
2158         (KJS::JSAbstractEventListener::handleEvent):
2159         * bindings/js/kjs_window.cpp:
2160         (KJS::ScheduledAction::execute):
2161         * css/MediaList.cpp:
2162         (WebCore::MediaList::setMediaText):
2163         * dom/Document.cpp:
2164         (WebCore::Document::processHttpEquiv):
2165         * editing/ApplyStyleCommand.cpp:
2166         (WebCore::StyleChange::init):
2167         * html/HTMLDocument.cpp:
2168         (WebCore::parseDocTypeDeclaration):
2169         * html/HTMLLinkElement.cpp:
2170         (WebCore::HTMLLinkElement::parseMappedAttribute):
2171         * html/HTMLObjectElement.cpp:
2172         (WebCore::HTMLObjectElement::HTMLObjectElement):
2173         (WebCore::HTMLObjectElement::parseMappedAttribute):
2174         (WebCore::HTMLObjectElement::attach):
2175         (WebCore::HTMLObjectElement::setComplete):
2176         (WebCore::HTMLObjectElement::detach):
2177         (WebCore::HTMLObjectElement::recalcStyle):
2178         (WebCore::HTMLObjectElement::childrenChanged):
2179         (WebCore::HTMLObjectElement::isImageType):
2180         * html/HTMLObjectElement.h:
2181         * html/HTMLOptionElement.cpp:
2182         (WebCore::HTMLOptionElement::value):
2183         * html/HTMLSelectElement.cpp:
2184         (WebCore::HTMLSelectElement::appendFormData):
2185         * html/HTMLTokenizer.cpp:
2186         (WebCore::HTMLTokenizer::parseTag):
2187         * ksvg2/svg/SVGColor.cpp:
2188         (WebCore::SVGColor::setRGBColor):
2189         * ksvg2/svg/SVGDescElement.cpp:
2190         (WebCore::SVGDescElement::description):
2191         * platform/PlatformString.h:
2192         * platform/String.cpp:
2193         (WebCore::String::stripWhiteSpace):
2194         (WebCore::String::simplifyWhiteSpace):
2195         * platform/StringImpl.cpp:
2196         (WebCore::isSpace):
2197         (WebCore::parseLength):
2198         (WebCore::StringImpl::stripWhiteSpace):
2199         (WebCore::StringImpl::simplifyWhiteSpace):
2200         (WebCore::StringImpl::toInt):
2201         * platform/StringImpl.h:
2202         * platform/mac/ClipboardMac.mm:
2203         (WebCore::cocoaTypeFromMIMEType):
2204         * rendering/RenderPartObject.cpp:
2205         (WebCore::RenderPartObject::updateWidget):
2206         * xml/XPathFunctions.cpp:
2207         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
2208         * xml/XPathGrammar.y:
2209         * xml/XPathStep.cpp:
2210         (WebCore::XPath::Step::nodeTestMatches):
2211         * xml/XSLStyleSheet.cpp:
2212         (WebCore::XSLStyleSheet::loadChildSheets):
2213         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
2214         * xml/XSLTProcessor.cpp:
2215         (WebCore::xsltParamArrayFromParameterMap):
2216         (WebCore::XSLTProcessor::setParameter):
2217         (WebCore::XSLTProcessor::getParameter):
2218         (WebCore::XSLTProcessor::removeParameter):
2219         * xml/XSLTProcessor.h:
2220         * xml/xmlhttprequest.cpp:
2221         (WebCore::XMLHttpRequest::getStatusText):
2222
2223 2006-09-17  David Hyatt  <hyatt@apple.com>
2224
2225         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
2226         are declared right before the fieldsets.  It turns out fieldsets in other
2227         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
2228         adding that behavior to fieldset fixes the bug.
2229
2230         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
2231         and fieldsets all subclass.
2232
2233         Reviewed by anders
2234
2235         Added fast/forms/float-before-fieldset.html
2236
2237         * rendering/RenderFieldset.h:
2238         (WebCore::RenderFieldset::avoidsFloats):
2239         * rendering/RenderFlexibleBox.h:
2240         (WebCore::RenderFlexibleBox::avoidsFloats):
2241         * rendering/RenderObject.cpp:
2242         (WebCore::RenderObject::avoidsFloats):
2243         * rendering/RenderObject.h:
2244         * rendering/RenderTable.h:
2245         (WebCore::RenderTable::avoidsFloats):
2246
2247 2006-09-17  David Hyatt  <hyatt@apple.com>
2248
2249         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
2250         "rules" attributes on tables.
2251
2252         Reviewed by bradee-oh
2253
2254         Well-covered by existing layout tests.
2255
2256         * html/HTMLTableCellElement.cpp:
2257         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
2258         * html/HTMLTableColElement.cpp:
2259         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
2260         * html/HTMLTableColElement.h:
2261         * html/HTMLTableElement.cpp:
2262         (WebCore::HTMLTableElement::HTMLTableElement):
2263         (WebCore::HTMLTableElement::~HTMLTableElement):
2264         (WebCore::HTMLTableElement::setCaption):
2265         (WebCore::HTMLTableElement::setTHead):
2266         (WebCore::HTMLTableElement::setTFoot):
2267         (WebCore::HTMLTableElement::setTBody):
2268         (WebCore::HTMLTableElement::createTHead):
2269         (WebCore::HTMLTableElement::deleteTHead):
2270         (WebCore::HTMLTableElement::createTFoot):
2271         (WebCore::HTMLTableElement::deleteTFoot):
2272         (WebCore::HTMLTableElement::createCaption):
2273         (WebCore::HTMLTableElement::deleteCaption):
2274         (WebCore::HTMLTableElement::insertRow):
2275         (WebCore::HTMLTableElement::deleteRow):
2276         (WebCore::HTMLTableElement::addChild):
2277         (WebCore::HTMLTableElement::childrenChanged):
2278         (WebCore::HTMLTableElement::mapToEntry):
2279         (WebCore::HTMLTableElement::parseMappedAttribute):
2280         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
2281         (WebCore::HTMLTableElement::getSharedCellDecl):
2282         (WebCore::HTMLTableElement::getSharedGroupDecl):
2283         (WebCore::HTMLTableElement::attach):
2284         * html/HTMLTableElement.h:
2285         (WebCore::HTMLTableElement::caption):
2286         (WebCore::HTMLTableElement::tHead):
2287         (WebCore::HTMLTableElement::tFoot):
2288         (WebCore::HTMLTableElement::):
2289         * html/HTMLTableRowElement.h:
2290         * html/HTMLTableSectionElement.cpp:
2291         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
2292         * html/HTMLTableSectionElement.h:
2293
2294 2006-09-17  David Hyatt  <hyatt@apple.com>
2295
2296         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
2297         specify their own new font-family list.  Make sure to always
2298         reset the generic family along with the family list when mapping in
2299         new font-family values.
2300
2301         Reviewed by bradee-oh
2302
2303         fast/text/basic/generic-family-reset.html
2304
2305         * css/cssstyleselector.cpp:
2306         (WebCore::CSSStyleSelector::applyProperty):
2307
2308 2006-09-16  Brady Eidson <beidson@apple.com>
2309
2310         Reviewed by Hyatt
2311
2312         Pruning code relating to WebKit's icon loader
2313
2314         * bridge/mac/WebCoreIconDatabaseBridge.h:
2315         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2316         * loader/icon/IconDatabase.h:
2317         * page/Frame.cpp:
2318         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to
2319         its new home
2320
2321 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
2322
2323         Reviewed by Tim H.
2324
2325         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10885
2326         Auto-generate DOMHTMLDocument for the Objective-C bindings
2327
2328         * DerivedSources.make:
2329         * WebCore.xcodeproj/project.pbxproj:
2330         * bindings/objc/DOMExtensions.h:
2331         * bindings/objc/DOMHTML.mm:
2332         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
2333         * bindings/objc/DOMHTMLDocument.h: Removed.
2334         * bindings/objc/DOMHTMLDocument.mm: Removed.
2335         * bindings/objc/PublicDOMInterfaces.h:
2336         * bindings/scripts/CodeGeneratorObjC.pm:
2337         * html/HTMLDocument.idl:
2338         * platform/DeprecatedString.h:
2339         (WebCore::DeprecatedString::operator NSString*):
2340
2341 2006-09-16  Rob Buis  <buis@kde.org>
2342
2343         Reviewed by Eric.
2344
2345         http://bugzilla.opendarwin.org/show_bug.cgi?id=10866
2346         Code in kcanvas/ should not use Private
2347
2348         Remove Private classes and tweak coding style.
2349
2350         WARNING: NO TEST CASES ADDED OR CHANGED
2351
2352         * kcanvas/RenderPath.cpp:
2353         (WebCore::RenderPath::RenderPath):
2354         (WebCore::RenderPath::~RenderPath):
2355         (WebCore::RenderPath::localTransform):
2356         (WebCore::RenderPath::setLocalTransform):
2357         (WebCore::RenderPath::fillContains):
2358         (WebCore::RenderPath::relativeBBox):
2359         (WebCore::RenderPath::setPath):
2360         (WebCore::RenderPath::path):
2361         (WebCore::RenderPath::layout):
2362         * kcanvas/RenderPath.h:
2363         * kcanvas/RenderSVGContainer.cpp:
2364         (WebCore::RenderSVGContainer::RenderSVGContainer):
2365         (WebCore::RenderSVGContainer::~RenderSVGContainer):
2366         (WebCore::RenderSVGContainer::drawsContents):
2367         (WebCore::RenderSVGContainer::setDrawsContents):
2368         (WebCore::RenderSVGContainer::localTransform):
2369         (WebCore::RenderSVGContainer::setLocalTransform):
2370         (WebCore::RenderSVGContainer::layout):
2371         (WebCore::RenderSVGContainer::paint):
2372         (WebCore::RenderSVGContainer::setViewport):
2373         (WebCore::RenderSVGContainer::viewport):
2374         (WebCore::RenderSVGContainer::setViewBox):
2375         (WebCore::RenderSVGContainer::viewBox):
2376         (WebCore::RenderSVGContainer::setAlign):
2377         (WebCore::RenderSVGContainer::align):
2378         (WebCore::RenderSVGContainer::fillContains):
2379         (WebCore::RenderSVGContainer::strokeContains):
2380         (WebCore::RenderSVGContainer::setSlice):
2381         (WebCore::RenderSVGContainer::slice):
2382         * kcanvas/RenderSVGContainer.h:
2383         * kcanvas/device/KRenderingFillPainter.cpp:
2384         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
2385         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
2386         (WebCore::KRenderingFillPainter::fillRule):
2387         (WebCore::KRenderingFillPainter::setFillRule):
2388         (WebCore::KRenderingFillPainter::opacity):
2389         (WebCore::KRenderingFillPainter::setOpacity):
2390         * kcanvas/device/KRenderingFillPainter.h:
2391         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2392         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
2393         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
2394         (WebCore::KRenderingPaintServerGradient::gradientStops):
2395         (WebCore::KRenderingPaintServerGradient::setGradientStops):
2396         (WebCore::KRenderingPaintServerGradient::spreadMethod):
2397         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
2398         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
2399         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
2400         (WebCore::KRenderingPaintServerGradient::gradientTransform):
2401         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
2402         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
2403         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
2404         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
2405         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
2406         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
2407         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
2408         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
2409         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
2410         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
2411         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
2412         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
2413         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
2414         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
2415         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
2416         (WebCore::KRenderingPaintServerGradient::listener):
2417         (WebCore::KRenderingPaintServerGradient::setListener):
2418         * kcanvas/device/KRenderingPaintServerGradient.h:
2419         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2420         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
2421         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
2422         (WebCore::KRenderingPaintServerPattern::setBbox):
2423         (WebCore::KRenderingPaintServerPattern::bbox):
2424         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
2425         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
2426         (WebCore::KRenderingPaintServerPattern::tile):
2427         (WebCore::KRenderingPaintServerPattern::setTile):
2428         (WebCore::KRenderingPaintServerPattern::patternTransform):
2429         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
2430         (WebCore::KRenderingPaintServerPattern::listener):
2431         (WebCore::KRenderingPaintServerPattern::setListener):
2432         * kcanvas/device/KRenderingPaintServerPattern.h:
2433         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2434         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
2435         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
2436         (WebCore::KRenderingPaintServerSolid::color):
2437         (WebCore::KRenderingPaintServerSolid::setColor):
2438         * kcanvas/device/KRenderingPaintServerSolid.h:
2439         * kcanvas/device/KRenderingStrokePainter.cpp:
2440         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
2441         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
2442         (WebCore::KRenderingStrokePainter::strokeWidth):
2443         (WebCore::KRenderingStrokePainter::setStrokeWidth):
2444         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2445         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2446         (WebCore::KRenderingStrokePainter::strokeCapStyle):
2447         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
2448         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
2449         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
2450         (WebCore::KRenderingStrokePainter::dashOffset):
2451         (WebCore::KRenderingStrokePainter::setDashOffset):
2452         (WebCore::KRenderingStrokePainter::dashArray):
2453         (WebCore::KRenderingStrokePainter::setDashArray):
2454         (WebCore::KRenderingStrokePainter::opacity):
2455         (WebCore::KRenderingStrokePainter::setOpacity):
2456         (WebCore::KRenderingStrokePainter::dirty):
2457         (WebCore::KRenderingStrokePainter::setDirty):
2458         * kcanvas/device/KRenderingStrokePainter.h:
2459
2460 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
2461
2462         Reviewed by Anders.
2463
2464         http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
2465         Fix build error
2466
2467         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
2468
2469 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
2470
2471         Reviewed by Anders.
2472
2473         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10886
2474         REGRESSION (r16387): Reproducible crash when mousing over HTML document
2475
2476         - Special case method [DOMNode ownerDocument] to call document() instead
2477           or ownerDocument() to return to the old behavior.
2478
2479         * WebCore.xcodeproj/project.pbxproj:
2480         * bindings/scripts/CodeGeneratorObjC.pm:
2481
2482 2006-09-15  Brady Eidson  <beidson@apple.com>
2483
2484         Reviewed by Tim Hatcher
2485
2486         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
2487         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
2488
2489         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
2490         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
2491         (WebCore::IconDatabase::open): Make sure the directory exists
2492
2493 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2494
2495         Reviewed by Brady.
2496
2497         Make new style ObjC methods public API.
2498
2499         * WebCore.xcodeproj/project.pbxproj:
2500         * bindings/objc/DOMPrivate.h:
2501         * bindings/objc/PublicDOMInterfaces.h:
2502
2503 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
2504
2505         Reviewed by Tim H.
2506
2507         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
2508         Auto-generate DOMNode for the Objective-C bindings
2509
2510         * DerivedSources.make:
2511         * WebCore.xcodeproj/project.pbxproj:
2512         * bindings/objc/DOM.mm:
2513         (-[DOMNode boundingBox]):
2514         (-[DOMNode lineBoxRects]):
2515         * bindings/objc/DOMEvents.h:
2516         * bindings/objc/DOMExtensions.h:
2517         * bindings/objc/DOMNode.h: Removed.
2518         * bindings/objc/DOMNode.mm: Removed.
2519         * bindings/objc/PublicDOMInterfaces.h:
2520         * bindings/scripts/CodeGeneratorObjC.pm:
2521         * dom/Node.idl:
2522
2523 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2524
2525         Reviewed by Justin.
2526
2527         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
2528
2529         * bridge/mac/WebCoreFrameBridge.h:
2530         * bridge/mac/WebCoreFrameBridge.mm:
2531         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
2532         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
2533         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
2534         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
2535         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
2536         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
2537         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2538         (-[WebCoreFrameBridge increaseSelectionListLevel]):
2539         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
2540         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
2541         (-[WebCoreFrameBridge decreaseSelectionListLevel]):
2542         (-[WebCoreFrameBridge insertLineBreak]):
2543         (-[WebCoreFrameBridge insertParagraphSeparator]):
2544         (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
2545         (-[WebCoreFrameBridge insertText:selectInsertedText:]):
2546         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
2547         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
2548         (createMouseEventFromDraggingInfo):
2549         * editing/SelectionController.cpp:
2550         (WebCore::SelectionController::moveTo):
2551         (WebCore::SelectionController::setSelection):
2552         (WebCore::SelectionController::modify):
2553         (WebCore::SelectionController::setBase):
2554         (WebCore::SelectionController::setExtent):
2555         * editing/SelectionController.h:
2556         * page/Frame.cpp:
2557         (WebCore::Frame::revealSelection):
2558         (WebCore::Frame::revealCaret):
2559         * page/Frame.h:
2560
2561 2006-09-15  Brady Eidson  <beidson@apple.com>
2562
2563         Reviewed by Anders
2564
2565         Added the ability to get a mutable char* from a CString, which will copy the internal
2566         buffer if the ref count is greater than 1 so your mutable char* won't affect any other
2567         referrer of that buffer.
2568
2569         * platform/CString.cpp:
2570         (WebCore::CString::mutableData):
2571         (WebCore::CString::copyBufferIfNeeded):
2572         * platform/CString.h:
2573
2574 2006-09-15  Justin Garcia  <justin.garcia@apple.com>
2575
2576         Reviewed by harrison
2577
2578         <rdar://problem/4674869>
2579         REGRESSION: selecting text to write over results in cursor jumping to middle of next line
2580
2581         * editing/SelectionController.cpp:
2582         (WebCore::SelectionController::modify): Added lineBoundary to test fix.
2583         * editing/visible_units.cpp:
2584         (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
2585         position before it, not after it.
2586
2587 2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2588
2589         Reviewed by Adam.
2590
2591         http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
2592         Bug 10864: Linux\GDK build fixes
2593
2594         * Projects/gdk/webcore-gdk.bkl:
2595         * WebCoreSources.bkl:
2596         * platform/gdk/FontCacheGdk.cpp:
2597         * platform/gdk/FontDataGdk.cpp:
2598         (WebCore::FontData::platformInit):
2599         * platform/gdk/FontGdk.cpp:
2600         (WebCore::Font::drawGlyphs):
2601         * platform/gdk/FrameGdk.cpp:
2602         (WebCore::FrameGdk::handleGdkEvent):
2603         * platform/gdk/FrameGdk.h:
2604         * platform/gdk/ImageGdk.cpp: Added.
2605         (WebCore::Image::initPlatformData):
2606         (WebCore::Image::invalidatePlatformData):
2607         (WebCore::Image::loadPlatformResource):
2608         (WebCore::Image::supportsType):
2609         * platform/gdk/RenderPopupMenuGdk.cpp:
2610         (WebCore::RenderPopupMenuGdk::hidePopup):
2611         * platform/gdk/RenderPopupMenuGdk.h:
2612         * platform/gdk/ScreenGdk.cpp:
2613         (WebCore::drawableForPage):
2614         (WebCore::screenRect):
2615         (WebCore::screenDepth):
2616         (WebCore::usableScreenRect):
2617         (WebCore::scaleFactor):
2618         * platform/gdk/SystemTimeLinux.cpp:
2619         (WebCore::currentTime):
2620         * platform/gdk/TemporaryLinkStubs.cpp:
2621         (FrameGdk::bindingRootObject):
2622         (FrameGdk::markMisspellings):
2623         (WebCore::screenDepthPerComponent):
2624         (WebCore::screenIsMonochrome):
2625         (WebCore::fileButtonChooseFileLabel):
2626         (WebCore::fileButtonNoFileSelectedLabel):
2627         (FrameGdk::shouldChangeSelection):
2628         (FrameGdk::respondToChangedSelection):
2629         (FrameGdk::respondToChangedContents):
2630         (Path::contains):
2631         (PlatformScrollBar::PlatformScrollBar):
2632         (PlatformScrollBar::~PlatformScrollBar):
2633         (PlatformScrollBar::width):
2634         (PlatformScrollBar::height):
2635         (PlatformScrollBar::setEnabled):
2636         (PlatformScrollBar::paint):
2637         (PlatformScrollBar::setScrollBarValue):
2638         (PlatformScrollBar::setKnobProportion):
2639         (PlatformScrollBar::setRect):
2640         (ScrollBar::ScrollBar):
2641         (FileChooser::FileChooser):
2642         (FileChooser::~FileChooser):
2643         (FileChooser::openFileChooser):
2644         (FileChooser::basenameForWidth):
2645         (FileChooser::uploadControlDetaching):
2646         (FileChooser::chooseFile):
2647         (Icon::Icon):
2648         (Icon::~Icon):
2649         (Icon::newIconForFile):
2650         (Icon::paint):
2651         (IconLoader::stopLoading):
2652         (IconLoader::startLoading):
2653         (IconLoader::createForFrame):
2654         (IconDatabase::isIconExpiredForIconURL):
2655         (IconDatabase::hasEntryForIconURL):
2656         (IconDatabase::sharedIconDatabase):
2657         * platform/gdk/WidgetGdk.cpp:
2658         * webcore-base.bkl:
2659
2660 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
2661
2662         Reviewed by Eric.
2663
2664         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
2665         Fix svg memory leaks.
2666
2667         Reworked SVGList to deal with RefPtr's for ptr types
2668         which makes manual refcounting unnecessary, and is much safer.
2669
2670         Removing all virtual functions (nullItem) from SVGList, and
2671         also remove SVGListBase. Switch to a similar concept like
2672         Vector/VectorTraits (see new file SVGListTraits.h).
2673
2674         Credits go to Eric/Maciej for the inspiration.
2675
2676         * CMakeLists.txt: Add SVGListTraits.cpp to build
2677         * WebCore.xcodeproj/project.pbxproj: Ditto.
2678         * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
2679         * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
2680         (WebCore::RenderSVGText::translationForAttributes):
2681         * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
2682         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2683         * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
2684         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
2685         * ksvg2/svg/SVGElementInstanceList.h:
2686         * ksvg2/svg/SVGLengthList.cpp: Ditto.
2687         (WebCore::SVGLengthList::SVGLengthList):
2688         * ksvg2/svg/SVGLengthList.h: Ditto.
2689         * ksvg2/svg/SVGList.h: Rewrote, as described above.
2690         (WebCore::SVGListTypeOperations::nullItem):
2691         (WebCore::SVGList::SVGList):
2692         (WebCore::SVGList::~SVGList):
2693         (WebCore::SVGList::clear):
2694         (WebCore::SVGList::getFirst):
2695         (WebCore::SVGList::getLast):
2696         (WebCore::SVGList::getItem):
2697         (WebCore::SVGList::replaceItem):
2698         (WebCore::SVGList::removeItem):
2699         * ksvg2/svg/SVGListTraits.cpp: Added.
2700         * ksvg2/svg/SVGListTraits.h: Added.
2701         (WebCore::):
2702         * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
2703         (WebCore::SVGPathElement::toPathData):
2704         * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
2705         (WebCore::SVGPathSegList::SVGPathSegList):
2706         * ksvg2/svg/SVGPathSegList.h: Ditto.
2707         * ksvg2/svg/SVGTransform.cpp: Style cleanup.
2708         (SVGTransform::SVGTransform):
2709         * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
2710         (SVGTransformList::SVGTransformList):
2711         (SVGTransformList::createSVGTransformFromMatrix):
2712         (SVGTransformList::consolidate):
2713         * ksvg2/svg/SVGTransformList.h: Ditto.
2714         * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
2715         (SVGTransformable::parseTransformAttribute):
2716
2717 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
2718
2719         Reviewed by eseidel.  Landed by eseidel.
2720
2721         Fix build on Qt/Linux and implement Frame::addMessageToConsole to
2722         be able to see javascript errors for instance.
2723
2724         * CMakeLists.txt:
2725         * platform/qt/FrameQt.h:
2726         * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
2727         (WebCore::FrameQt::bindingRootObject):
2728         * platform/qt/TemporaryLinkStubs.cp
2729         (WebCore::IconDatabase::hasEntryForIconURL):
2730         (WebCore::IconDatabase::sharedIconDatabase):
2731
2732 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
2733
2734         Reviewed by Tim H.
2735
2736         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10869
2737         Auto-generate the internal methods for the Objective-C bindings
2738
2739         - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
2740           implementations where standard.  For cases where a custom implementation was
2741           needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
2742
2743         - Some general cleanup of some of the non-generated bindings, to bring them in-
2744           line with what the generated bindings look like.
2745
2746         * bindings/objc/DOM.mm:
2747         (-[DOMNode description]):
2748         * bindings/objc/DOMCSS.mm:
2749         (-[DOMCSSPrimitiveValue WebCore::]):
2750         (-[DOMDocument getComputedStyle::]):
2751         (-[DOMDocument getMatchedCSSRules::]):
2752         * bindings/objc/DOMEvents.mm:
2753         (-[DOMEvent WebCore::]):
2754         * bindings/objc/DOMHTML.mm:
2755         * bindings/objc/DOMHTMLDocument.mm:
2756         (-[DOMHTMLDocument title]):
2757         (-[DOMHTMLDocument setTitle:]):
2758         (-[DOMHTMLDocument referrer]):
2759         (-[DOMHTMLDocument domain]):
2760         (-[DOMHTMLDocument URL]):
2761         (-[DOMHTMLDocument body]):
2762         (-[DOMHTMLDocument setBody:]):
2763         (-[DOMHTMLDocument images]):
2764         (-[DOMHTMLDocument applets]):
2765         (-[DOMHTMLDocument links]):
2766         (-[DOMHTMLDocument forms]):
2767         (-[DOMHTMLDocument anchors]):
2768         (-[DOMHTMLDocument cookie]):
2769         (-[DOMHTMLDocument setCookie:]):
2770         (-[DOMHTMLDocument open]):
2771         (-[DOMHTMLDocument close]):
2772         (-[DOMHTMLDocument write:]):
2773         (-[DOMHTMLDocument writeln:]):
2774         (-[DOMHTMLDocument getElementById:]):
2775         (-[DOMHTMLDocument getElementsByName:]):
2776         (-[DOMHTMLDocument WebCore::]):
2777         (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
2778         * bindings/objc/DOMHTMLOptionElement.mm:
2779         (-[DOMHTMLOptionElement form]):
2780         (-[DOMHTMLOptionElement defaultSelected]):
2781         (-[DOMHTMLOptionElement setDefaultSelected:]):
2782         (-[DOMHTMLOptionElement text]):
2783         (-[DOMHTMLOptionElement index]):
2784         (-[DOMHTMLOptionElement disabled]):
2785         (-[DOMHTMLOptionElement setDisabled:]):
2786         (-[DOMHTMLOptionElement label]):
2787         (-[DOMHTMLOptionElement setLabel:]):
2788         (-[DOMHTMLOptionElement selected]):
2789         (-[DOMHTMLOptionElement setSelected:]):
2790         (-[DOMHTMLOptionElement value]):
2791         (-[DOMHTMLOptionElement setValue:]):
2792         (-[DOMHTMLOptionElement WebCore::]):
2793         (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
2794         * bindings/objc/DOMInternal.h:
2795         * bindings/objc/DOMNode.mm:
2796         (-[DOMNode dealloc]):
2797         (-[DOMNode finalize]):
2798         (-[DOMNode nodeName]):
2799         (-[DOMNode nodeValue]):
2800         (-[DOMNode setNodeValue:]):
2801         (-[DOMNode nodeType]):
2802         (-[DOMNode parentNode]):
2803         (-[DOMNode childNodes]):
2804         (-[DOMNode firstChild]):
2805         (-[DOMNode lastChild]):
2806         (-[DOMNode previousSibling]):
2807         (-[DOMNode nextSibling]):
2808         (-[DOMNode attributes]):
2809         (-[DOMNode ownerDocument]):
2810         (-[DOMNode insertBefore::]):
2811         (-[DOMNode replaceChild::]):
2812         (-[DOMNode removeChild:]):
2813         (-[DOMNode appendChild:]):
2814         (-[DOMNode hasChildNodes]):
2815         (-[DOMNode cloneNode:]):
2816         (-[DOMNode normalize]):
2817         (-[DOMNode isSupported::]):
2818         (-[DOMNode namespaceURI]):
2819         (-[DOMNode prefix]):
2820         (-[DOMNode setPrefix:]):
2821         (-[DOMNode localName]):
2822         (-[DOMNode hasAttributes]):
2823         (-[DOMNode isSameNode:]):
2824         (-[DOMNode isEqualNode:]):
2825         (-[DOMNode isDefaultNamespace:]):
2826         (-[DOMNode lookupPrefix:]):
2827         (-[DOMNode lookupNamespaceURI:]):
2828         (-[DOMNode textContent]):
2829         (-[DOMNode setTextContent:]):
2830         (-[DOMNode boundingBox]):
2831         (-[DOMNode lineBoxRects]):
2832         * bindings/objc/DOMObject.mm:
2833         (-[DOMObject _init]):
2834         * bindings/objc/DOMXPath.mm:
2835         (-[DOMNativeXPathNSResolver dealloc]):
2836         (-[DOMNativeXPathNSResolver finalize]):
2837         (-[DOMNativeXPathNSResolver WebCore::]):
2838         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
2839         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
2840         (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
2841         * bindings/scripts/CodeGeneratorObjC.pm:
2842         * bridge/mac/WebCoreFrameBridge.mm:
2843         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2844         (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
2845         * css/CSSCharsetRule.idl:
2846         * css/CSSFontFaceRule.idl:
2847         * css/CSSImportRule.idl:
2848         * css/CSSMediaRule.idl:
2849         * css/CSSPageRule.idl:
2850         * css/CSSPrimitiveValue.idl:
2851         * css/CSSRule.idl:
2852         * css/CSSStyleRule.idl:
2853         * css/CSSStyleSheet.idl:
2854         * css/CSSUnknownRule.idl:
2855         * css/CSSValue.idl:
2856         * css/CSSValueList.idl:
2857         * css/StyleSheet.idl:
2858         * dom/Event.idl:
2859         * dom/KeyboardEvent.idl:
2860         * dom/MouseEvent.idl:
2861         * dom/MutationEvent.idl:
2862         * dom/NodeIterator.idl:
2863         * dom/OverflowEvent.idl:
2864         * dom/TreeWalker.idl:
2865         * dom/UIEvent.idl:
2866         * dom/WheelEvent.idl:
2867
2868 2006-09-15  Adam Roben  <aroben@apple.com>
2869
2870         Reviewed by timothy.
2871
2872         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
2873         New file upload control should match the width of the old one
2874
2875         Make width of new file upload control match the old one as closely as
2876         possible.
2877
2878         * rendering/RenderFileUploadControl.cpp:
2879
2880 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2881
2882         Reviewed by Eric.
2883
2884         Remove the SVG IDL files from the Copy Resources phase.
2885
2886         * WebCore.xcodeproj/project.pbxproj:
2887
2888 2006-09-15  Brady Eidson  <beidson@apple.com>
2889
2890         Reviewed by Eric Siedel
2891
2892         Dumped the use of CGColorRef and directly use the floating point data from
2893         WebCore::Color
2894
2895         This fixes the performance regression found between 16285 and 16286
2896
2897         * platform/mac/FontMac.mm:
2898         (WebCore::Font::drawComplexText):
2899         (WebCore::Font::drawGlyphs):
2900
2901 2006-09-14  Mark Rowe  <opendarwin.org@bdash.net.nz>
2902
2903         Reviewed by Adam.
2904
2905         http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
2906         Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate
2907
2908         FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
2909         Frame::cleanupPluginObjects method is called from Frame's destructor, which results
2910         in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.
2911
2912         * bridge/mac/FrameMac.mm:
2913         (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
2914         will be called from Frame::clear
2915         * page/Frame.cpp:
2916         (WebCore::Frame::~Frame): Use cancelAndClear.
2917         (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
2918         FrameMac can use.
2919         * page/Frame.h:
2920
2921 2006-09-14  Brady Eidson  <beidson@apple.com>
2922
2923         Reviewed by Maciej's rubber stamp
2924
2925         Exact same fix I just made, but in the other method I horked up
2926         Also added a reference to the bugzilla in comments
2927
2928         * page/Frame.cpp:
2929         (WebCore::Frame::endIfNotLoading):
2930         (WebCore::Frame::stop):
2931
2932 2006-09-14  Brady Eidson  <beidson@apple.com>
2933
2934         Reviewed by Maciej
2935
2936         Fixed a bad iFrame crash, resolving some of the layout test badness
2937
2938         * page/Frame.cpp:
2939         (WebCore::Frame::endIfNotLoading):
2940         - Added a RefPtr to protect the frame itself to prevent its destruction during this method
2941
2942 2006-09-14  Justin Garcia  <justin.garcia@apple.com>
2943
2944         Reviewed by harrison
2945
2946         <rdar://problem/4655880> Up/Down arrows skip over To Do
2947
2948         * bridge/mac/WebCoreFrameBridge.mm:
2949         (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
2950         * dom/Node.cpp: Removed the unused inSameRootEditableElement.
2951         * dom/Node.h:
2952         * editing/SelectionController.cpp:
2953         (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
2954         * editing/visible_units.cpp:
2955         (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
2956         editable content into editable content that's embedded in non-editable content.
2957         (WebCore::nextLinePosition): Ditto.
2958         (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
2959         This is the behavior that callers desire.  This fixes Command + Up/Down.
2960         (WebCore::endOfEditableContent): Ditto.
2961         * editing/visible_units.h:
2962
2963 2006-09-14  Karthik Kumar  <karthikkumar@gmail.com>
2964
2965         Reviewed by timothy. Landed by aroben.
2966
2967         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
2968         Windows build fixes after r16360
2969
2970         * WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to
2971         AdditionalIncludeDirectories
2972         * platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader,
2973         IconDatabase
2974         (IconLoader::stopLoading):
2975         (IconLoader::startLoading):
2976         (IconLoader::createForFrame):
2977         (IconDatabase::isIconExpiredForIconURL):
2978         (IconDatabase::hasEntryForIconURL):
2979         (IconDatabase::sharedIconDatabase):
2980
2981 2006-09-14  Brady Eidson  <beidson@apple.com>
2982
2983         Part of a build fix for Windows - rest will be working out a mess of temporary link stubs
2984
2985         * loader/icon/IconLoader.cpp:
2986         (IconLoader::receivedAllData):
2987         * page/Frame.cpp:
2988         * page/FramePrivate.h:
2989
2990 2006-09-14  Graham Dennis  <graham.dennis@gmail.com>
2991
2992         Reviewed by Justin Garcia.
2993
2994         - http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
2995           Crash in ApplyStyleCommand::applyRelativeFontStyleChange
2996
2997         * editing/ApplyStyleCommand.cpp:
2998         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by
2999         makeing sure that the 'beyondEnd' node is after the start node.
3000
3001 2006-09-14  MorganL  <morlmor@yahoo.com>
3002
3003         Reviewed by Brady.
3004
3005         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
3006         Various bugs/crashes in ResourceLoaderWin with local files.
3007
3008         * platform/ResourceLoaderInternal.h:
3009         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3010         * platform/win/ResourceLoaderWin.cpp:
3011         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
3012         (WebCore::ResourceLoader::fileLoadTimer):
3013
3014 2006-09-13  Brady Eidson <beidson@apple.com>
3015
3016         Reviewed by Maciej
3017
3018         Icon loads now take place in WebCore
3019
3020         * WebCore.xcodeproj/project.pbxproj:
3021         * bridge/BrowserExtension.h:
3022         * bridge/mac/BrowserExtensionMac.h:
3023         * bridge/mac/BrowserExtensionMac.mm:
3024         - Moved enforcement of a Mozilla Favicon extension elsewhere
3025
3026         * bridge/mac/FrameMac.h:
3027         * bridge/mac/FrameMac.mm:
3028         (WebCore::FrameMac::originalRequestURL):
3029         - Added accessor to "original request URL"
3030
3031         * bridge/mac/WebCoreFrameBridge.h:
3032         - Removed methods to set the iconURL as all loading is now done in WebCore
3033         - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL
3034
3035         * html/HTMLLinkElement.cpp:
3036         (WebCore::HTMLLinkElement::process):
3037         - Moved enforcement of a Mozilla Favicon extension elsewhere
3038
3039         * loader/icon/IconDatabase.cpp:
3040         (WebCore::IconDatabase::setIconURLForPageURL):
3041         - Changed an ASSERT to correctly handle a sketchy (invalid) situation
3042
3043         * loader/icon/IconLoader.h: Added.
3044         * loader/icon/IconLoader.cpp: Added.
3045         (IconLoader::IconLoader):
3046         (IconLoader::createForFrame):
3047         - Static factory method with a private constructor to enforce
3048           "you MUST have a Frame to create an IconLoader" semantics
3049         (IconLoader::~IconLoader):
3050         (IconLoader::startLoading):
3051         (IconLoader::stopLoading):
3052         (IconLoader::receivedData):
3053         - ResourceLoaderClient delegate
3054         (IconLoader::receivedAllData):
3055         - Ditto
3056
3057         * loader/mac/IconLoaderMac.mm: Added.
3058         (IconLoader::receivedResponse):
3059         (IconLoader::notifyIconChanged):
3060         - For now, these are platform specific methods
3061         - One to get the HTTP response code of an icon load
3062         - The other to call through to the app when the icon has changed (loaded)
3063
3064         * page/Frame.h:
3065         * page/Frame.cpp:
3066         (WebCore::Frame::iconURL):
3067         (WebCore::Frame::setIconURL):
3068         - Frame objects now have an inherent icon URL and a way to calculate/access it
3069         (WebCore::Frame::endIfNotLoading):
3070         - This is where we actually kick off the IconLoader
3071         (WebCore::Frame::stop):
3072         - Added call to stop loading the icon
3073
3074         * page/FramePrivate.h:
3075         (WebCore::FramePrivate::FramePrivate):
3076         (WebCore::FramePrivate::~FramePrivate):
3077         - Added the icon URL as a private member
3078         - Added the IconLoader as a private member, and clean it up on deletion
3079
3080         * platform/mac/ResourceLoaderMac.mm:
3081         (WebCore::ResourceLoader::start):  Added a valuable ASSERT
3082
3083 2006-09-13  David Hyatt  <hyatt@apple.com>
3084
3085         Fix for 10841, unable to check checkboxes inside labels.
3086
3087         Reviewed by xenon, bradee-oh
3088
3089         * css/html4.css:
3090         * dom/Element.cpp:
3091         (WebCore::Element::contains):
3092         * dom/Element.h:
3093         * html/HTMLLabelElement.cpp:
3094         (WebCore::HTMLLabelElement::defaultEventHandler):
3095
3096 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
3097
3098         Reviewed by Adam.
3099
3100         http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
3101         Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller
3102
3103         * platform/mac/FileChooserMac.mm:
3104         (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
3105
3106 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
3107
3108         Reviewed by Eric.
3109
3110         http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
3111         Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef
3112
3113         * platform/mac/FontMac.mm:
3114         (WebCore::Font::drawComplexText): Release CGColorRef after use.
3115         (WebCore::Font::drawGlyphs): Ditto.
3116
3117 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
3118
3119         Try fixing the Win32 build.
3120
3121         * bridge/win/FrameWin.h:
3122         * platform/win/TemporaryLinkStubs.cpp:
3123         (FrameWin::bindingRootObject):
3124
3125 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
3126
3127         Reviewed by Tim O.
3128
3129         Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.
3130
3131         * bindings/js/kjs_binding.cpp:
3132         (KJS::ScriptInterpreter::createLanguageInstanceForValue):
3133         * bindings/js/kjs_dom.cpp:
3134         (KJS::getRuntimeObject):
3135         * bridge/mac/FrameMac.h:
3136         * config.h:
3137         * html/HTMLAppletElement.cpp:
3138         (WebCore::HTMLAppletElement::~HTMLAppletElement):
3139         (WebCore::HTMLAppletElement::detach):
3140         * html/HTMLAppletElement.h:
3141         * html/HTMLEmbedElement.cpp:
3142         (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
3143         (WebCore::HTMLEmbedElement::detach):
3144         * html/HTMLEmbedElement.h:
3145         * html/HTMLObjectElement.cpp:
3146         (WebCore::HTMLObjectElement::~HTMLObjectElement):
3147         (WebCore::HTMLObjectElement::detach):
3148         * html/HTMLObjectElement.h:
3149         * html/HTMLPlugInElement.cpp:
3150         (WebCore::HTMLPlugInElement::HTMLPlugInElement):
3151         (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
3152         (WebCore::HTMLPlugInElement::createNPObject):
3153         * html/HTMLPlugInElement.h:
3154         * page/Frame.h:
3155
3156 2006-09-13  David Hyatt  <hyatt@apple.com>
3157
3158         Clean up the XBL and XSLT ifdefs to be consistent with the SVG
3159         and XPath ifdefs.  KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
3160         KHTML_XSLT is now XSLT_SUPPORT.
3161
3162         * WebCore.xcodeproj/project.pbxproj:
3163         * bindings/js/JSXSLTProcessor.cpp:
3164         * bindings/js/JSXSLTProcessor.h:
3165         * bindings/js/kjs_window.cpp:
3166         (KJS::Window::getValueProperty):
3167         * config.h:
3168         * css/CSSComputedStyleDeclaration.cpp:
3169         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3170         * css/cssparser.cpp:
3171         (WebCore::CSSParser::parseValue):
3172         * css/cssstyleselector.cpp:
3173         (WebCore::CSSStyleSelector::applyProperty):
3174         * dom/Document.cpp:
3175         (WebCore::Document::Document):
3176         (WebCore::Document::~Document):
3177         (WebCore::Document::recalcStyleSelector):
3178         * dom/Document.h:
3179         (WebCore::Document::bindingManager):
3180         * dom/Node.cpp:
3181         (WebCore::Node::createRendererIfNeeded):
3182         * dom/ProcessingInstruction.cpp:
3183         (WebCore::ProcessingInstruction::ProcessingInstruction):
3184         (WebCore::ProcessingInstruction::checkStyleSheet):
3185         (WebCore::ProcessingInstruction::setStyleSheet):
3186         * dom/ProcessingInstruction.h:
3187         * dom/XMLTokenizer.cpp:
3188         (WebCore::XMLTokenizer::processingInstruction):
3189         (WebCore::XMLTokenizer::insertErrorMessageBlock):
3190         * dom/XMLTokenizer.h:
3191         * loader/Cache.cpp:
3192         (WebCore::Cache::getStatistics):
3193         * loader/Cache.h:
3194         * loader/CachedResource.h:
3195         (WebCore::CachedResource::):
3196         * loader/CachedResourceClient.h:
3197         * loader/CachedXBLDocument.cpp:
3198         * loader/CachedXBLDocument.h:
3199         * loader/CachedXSLStyleSheet.cpp:
3200         * loader/CachedXSLStyleSheet.h:
3201         * loader/DocLoader.cpp:
3202         * loader/DocLoader.h:
3203         * rendering/RenderStyle.cpp:
3204         (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
3205         (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData):
3206         (WebCore::StyleCSS3NonInheritedData::operator==):
3207         * rendering/RenderStyle.h:
3208         * xml/XSLImportRule.cpp:
3209         * xml/XSLImportRule.h:
3210         * xml/XSLStyleSheet.cpp:
3211         * xml/XSLStyleSheet.h:
3212         * xml/XSLTProcessor.cpp:
3213         * xml/XSLTProcessor.h:
3214
3215 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
3216
3217         Reviewed by eseidel.  Landed by eseidel.
3218
3219         Fix newly introduced memory leaks in SVG.
3220         http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
3221
3222         * ksvg2/svg/SVGList.h:
3223         (WebCore::SVGListBase::~SVGListBase):
3224         (WebCore::SVGListBase::clearVector):
3225         (WebCore::SVGListBase::clear):
3226         (WebCore::SVGList::clearVector):
3227         (WebCore::):
3228         * ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that!
3229         (SVGNumberList::SVGNumberList):
3230         * ksvg2/svg/SVGNumberList.h: Ditto.
3231
3232 2006-09-13  MorganL  <morlmor@yahoo.com>
3233
3234         Reviewed/landed by aroben.
3235
3236         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
3237         Windows build needs fixed after move to engine-rendered file upload widget
3238
3239         * WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files,
3240         remove RenderFileButton files
3241         * platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon
3242         (FileChooser::FileChooser):
3243         (FileChooser::~FileChooser):
3244         (FileChooser::openFileChooser):
3245         (FileChooser::basenameForWidth):
3246         (FileChooser::uploadControlDetaching):
3247         (FileChooser::chooseFile):
3248         (WebCore::fileButtonChooseFileLabel):
3249         (WebCore::fileButtonNoFileSelectedLabel):
3250         (Icon::Icon):
3251         (Icon::~Icon):
3252         (Icon::newIconForFile):
3253         (Icon::paint):
3254
3255 2006-09-13  MorganL  <morlmor@yahoo.com>
3256
3257         Reviewed/landed by aroben.
3258
3259         Fixes http://bugzilla.opendarwin.org/attachment.cgi?id=10537
3260         Webkit WebCore build fails on Windows
3261
3262         * WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT
3263         variable
3264
3265 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
3266
3267         Reviewed by Tim H.
3268
3269         Fix Qt/Linux build.
3270
3271         * CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
3272         * platform/Icon.h: Add wtf/Platform.h include
3273         * platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though.
3274         (WebCore::FileChooser::FileChooser):
3275         (WebCore::FileChooser::~FileChooser):
3276         (WebCore::FileChooser::openFileChooser):
3277         (WebCore::FileChooser::basenameForWidth):
3278         (WebCore::FileChooser::uploadControlDetaching):
3279         (WebCore::FileChooser::chooseFile):
3280         * platform/qt/IconQt.cpp: Added as stub.
3281         (WebCore::Icon::Icon):
3282         (WebCore::Icon::~Icon):
3283         (WebCore::Icon::newIconForFile):
3284         (WebCore::Icon::paint):
3285         * platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed
3286         (searchableIndexIntroduction):
3287         (fileButtonChooseFileLabel):
3288         (fileButtonNoFileSelectedLabel):
3289
3290 2006-09-12  Adam Roben  <aroben@apple.com>
3291
3292         Reviewed by eseidel.
3293
3294         Switch back to passing relative paths to generate-bindings.pl when
3295         generating JS bindings.
3296
3297         * DerivedSources.make: Pass in relative paths to generate-bindings.pl
3298         * bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call
3299         chdir and always construct absolute paths instead.
3300
3301 2006-09-12  David Hyatt  <hyatt@apple.com>
3302
3303         Fix for bug 3244, implement html4 label support.
3304
3305         Reviewed by mjs, aroben
3306
3307         Added fast/events/label-focus.html
3308
3309         * css/html4.css:
3310         * html/HTMLLabelElement.cpp:
3311         (WebCore::HTMLLabelElement::formElement):
3312         (WebCore::HTMLLabelElement::setActive):
3313         (WebCore::HTMLLabelElement::setHovered):
3314         (WebCore::HTMLLabelElement::defaultEventHandler):
3315         * html/HTMLLabelElement.h:
3316
3317 2006-09-12  Julien Palmas  <julien.palmas@gmail.com>
3318
3319         Reviewed by darin.  Landed by eseidel.
3320
3321         * ksvg2/svg/svgpathparser.cpp:
3322         (WebCore::SVGPolyParser::parsePoints):
3323
3324 2006-09-11  Kevin McCullough  <KMcCullough@apple.com>
3325
3326         Reviewed by Andersca, Maciej, Brady.
3327
3328         - Implemented intersectsNode in the Range Class
3329           to be compliant with Mozilla standard
3330
3331         * dom/Range.cpp:
3332         (WebCore::Range::intersectsNode):
3333         * dom/Range.h:
3334         * dom/Range.idl:
3335
3336 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>
3337
3338         Reviewed by eseidel.  Landed by eseidel.
3339
3340         Test: svg/W3C-SVG-1.1/struct-dom-01-b.svg (fixed)
3341         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10826
3342
3343         Also finally fixes some long outstanding bugs:
3344         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9190
3345         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9229
3346         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10413
3347
3348         Enable all JavaScript SVG bindings. Builds on Qt/Linux & OSX.
3349
3350         * CMakeLists.txt:
3351         * DerivedSources.make:
3352         * WebCore.xcodeproj/project.pbxproj:
3353         * bindings/scripts/CodeGenerator.pm:
3354         * bindings/scripts/CodeGeneratorJS.pm:
3355         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
3356         * ksvg2/svg/SVGAElement.idl: Added.
3357         * ksvg2/svg/SVGAngle.idl:
3358         * ksvg2/svg/SVGAnimateColorElement.idl: Added.
3359         * ksvg2/svg/SVGAnimateElement.idl: Added.
3360         * ksvg2/svg/SVGAnimateTransformElement.idl: Added.
3361         * ksvg2/svg/SVGAnimatedLengthList.idl: Added.
3362         * ksvg2/svg/SVGAnimatedNumberList.idl: Added.
3363         * ksvg2/svg/SVGAnimatedTransformList.idl: Added.
3364         * ksvg2/svg/SVGAnimationElement.idl: Added.
3365         * ksvg2/svg/SVGCircleElement.idl: Added.
3366         * ksvg2/svg/SVGClipPathElement.idl: Added.
3367         * ksvg2/svg/SVGColor.idl:
3368         * ksvg2/svg/SVGComponentTransferFunctionElement.idl: Added.
3369         * ksvg2/svg/SVGCursorElement.idl: Added.
3370         * ksvg2/svg/SVGDefsElement.idl: Added.
3371         * ksvg2/svg/SVGDescElement.idl: Added.
3372         * ksvg2/svg/SVGEllipseElement.idl: Added.
3373         * ksvg2/svg/SVGEvent.idl:
3374         * ksvg2/svg/SVGExternalResourcesRequired.idl: Added.
3375         * ksvg2/svg/SVGFEBlendElement.idl: Added.
3376         * ksvg2/svg/SVGFEColorMatrixElement.idl: Added.
3377         * ksvg2/svg/SVGFEComponentTransferElement.idl: Added.
3378         * ksvg2/svg/SVGFECompositeElement.idl: Added.
3379         * ksvg2/svg/SVGFEDiffuseLightingElement.idl: Added.
3380         * ksvg2/svg/SVGFEDisplacementMapElement.idl: Added.
3381         * ksvg2/svg/SVGFEDistantLightElement.idl: Added.
3382         * ksvg2/svg/SVGFEFloodElement.idl: Added.
3383         * ksvg2/svg/SVGFEFuncAElement.idl: Added.
3384         * ksvg2/svg/SVGFEFuncBElement.idl: Added.
3385         * ksvg2/svg/SVGFEFuncGElement.idl: Added.
3386         * ksvg2/svg/SVGFEFuncRElement.idl: Added.
3387         * ksvg2/svg/SVGFEGaussianBlurElement.idl: Added.
3388         * ksvg2/svg/SVGFEImageElement.idl: Added.
3389         * ksvg2/svg/SVGFEMergeElement.idl: Added.
3390         * ksvg2/svg/SVGFEMergeNodeElement.idl: Added.
3391         * ksvg2/svg/SVGFEOffsetElement.idl: Added.
3392         * ksvg2/svg/SVGFEPointLightElement.idl: Added.
3393         * ksvg2/svg/SVGFESpecularLightingElement.idl: Added.
3394         * ksvg2/svg/SVGFESpotLightElement.idl: Added.
3395         * ksvg2/svg/SVGFETileElement.idl: Added.
3396         * ksvg2/svg/SVGFETurbulenceElement.idl: Added.
3397         * ksvg2/svg/SVGFilterElement.idl: Added.
3398         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
3399         * ksvg2/svg/SVGFitToViewBox.idl: Added.
3400         * ksvg2/svg/SVGForeignObjectElement.idl: Added.
3401         * ksvg2/svg/SVGGElement.idl: Added.
3402         * ksvg2/svg/SVGGradientElement.idl: Added.
3403         * ksvg2/svg/SVGImageElement.idl: Added.
3404         * ksvg2/svg/SVGLangSpace.idl: Added.
3405         * ksvg2/svg/SVGLength.idl:
3406         * ksvg2/svg/SVGLengthList.idl: Added.
3407         * ksvg2/svg/SVGLineElement.idl: Added.
3408         * ksvg2/svg/SVGLinearGradientElement.idl: Added.
3409         * ksvg2/svg/SVGLocatable.idl: Added.
3410         * ksvg2/svg/SVGMarkerElement.idl: Added.
3411         * ksvg2/svg/SVGMaskElement.idl: Added.
3412         * ksvg2/svg/SVGNumberList.idl: Added.
3413         * ksvg2/svg/SVGPaint.idl: Added.
3414         * ksvg2/svg/SVGPathElement.idl:
3415         * ksvg2/svg/SVGPathSeg.idl:
3416         * ksvg2/svg/SVGPatternElement.idl: Added.
3417         * ksvg2/svg/SVGPointList.idl: Added.
3418         * ksvg2/svg/SVGPolygonElement.idl: Added.
3419         * ksvg2/svg/SVGPolylineElement.idl: Added.
3420         * ksvg2/svg/SVGPreserveAspectRatio.idl:
3421         * ksvg2/svg/SVGRadialGradientElement.idl: Added.
3422         * ksvg2/svg/SVGRectElement.idl: Added.
3423         * ksvg2/svg/SVGRenderingIntent.idl: Added.
3424         * ksvg2/svg/SVGSVGElement.idl:
3425         * ksvg2/svg/SVGScriptElement.idl: Added.
3426         * ksvg2/svg/SVGSetElement.idl: Added.
3427         * ksvg2/svg/SVGStopElement.idl: Added.
3428         * ksvg2/svg/SVGStringList.idl: Added.
3429         * ksvg2/svg/SVGStylable.idl: Added.
3430         * ksvg2/svg/SVGStyleElement.idl: Added.
3431         * ksvg2/svg/SVGSwitchElement.idl: Added.
3432         * ksvg2/svg/SVGSymbolElement.idl: Added.
3433         * ksvg2/svg/SVGTRefElement.idl: Added.
3434         * ksvg2/svg/SVGTSpanElement.idl: Added.
3435         * ksvg2/svg/SVGTests.idl: Added.
3436         * ksvg2/svg/SVGTextContentElement.idl: Added.
3437         * ksvg2/svg/SVGTextElement.idl: Added.
3438         * ksvg2/svg/SVGTextPositioningElement.idl: Added.
3439         * ksvg2/svg/SVGTitleElement.idl: Added.
3440         * ksvg2/svg/SVGTransform.idl:
3441         * ksvg2/svg/SVGTransformList.idl: Added.
3442         * ksvg2/svg/SVGTransformable.idl: Added.
3443         * ksvg2/svg/SVGURIReference.idl: Added.
3444         * ksvg2/svg/SVGUnitTypes.idl: Added.
3445         * ksvg2/svg/SVGUseElement.idl: Added.
3446         * ksvg2/svg/SVGViewElement.idl: Added.
3447         * ksvg2/svg/SVGZoomAndPan.idl: Added.
3448         * ksvg2/svg/SVGZoomEvent.idl: Added.
3449
3450 2006-09-12  Adam Roben  <aroben@apple.com>
3451
3452         Reviewed by timo, ggaren.
3453
3454         Make Icon ref-counted.
3455
3456         * platform/FileChooser.h: Store m_icon as a RefPtr instead of
3457         auto_ptr.
3458         * platform/Icon.h: Inherit from Shared<Icon>
3459         * platform/mac/FileChooserMac.mm:
3460         (WebCore::FileChooser::chooseFile): Update m_icon usage
3461         * platform/mac/IconMac.mm:
3462         (WebCore::Icon::newIconForFile): Return a RefPtr instead of an
3463         auto_ptr
3464
3465 === Safari-521.26 ===
3466
3467 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>
3468
3469         Reviewed by Anders.
3470
3471         Add exception codes to SVGList functions, adjust all code using it.
3472
3473         Move SVGPaintType enums from ksvg.h into SVGPaint (needed for js generation)
3474         Move SVGUnitTypes enums from ksvg.h into it's own file SVGUnitType.h (ditto)
3475         Move SVGRenderingIntent enums from ksvg.h into it's own file SVGRenderingIntent.h (ditto)
3476         Move SVGZoomAndPan enums from ksvg.h into SVGSVGElement (ditto)
3477         Move SVGFE* related enums into their respecitive classes.
3478
3479         Fix JSSVGNumber to operator on doubles, instead of floats.
3480
3481         * ksvg2/bindings/js/JSSVGNumber.cpp:
3482         (WebCore::getJSSVGNumber):
3483         * ksvg2/bindings/js/JSSVGNumber.h:
3484         (WebCore::JSSVGNumber::JSSVGNumber):
3485         * ksvg2/css/SVGCSSParser.cpp:
3486         (WebCore::CSSParser::parseSVGValue):
3487         (WebCore::CSSParser::parseSVGPaint):
3488         * ksvg2/css/SVGRenderStyleDefs.cpp:
3489         (StyleFillData::operator==):
3490         * ksvg2/ksvg.h:
3491         * ksvg2/misc/KCanvasRenderingStyle.cpp:
3492         (WebCore::KSVGPainterFactory::isFilled):
3493         (WebCore::KSVGPainterFactory::fillPaintServer):
3494         (WebCore::KSVGPainterFactory::isStroked):
3495         (WebCore::KSVGPainterFactory::strokePaintServer):
3496         * ksvg2/misc/KSVGTimeScheduler.cpp:
3497         (WebCore::SVGTimer::notifyAll):
3498         * ksvg2/svg/SVGAnimateColorElement.cpp:
3499         (WebCore::SVGAnimateColorElement::handleTimerEvent):
3500         * ksvg2/svg/SVGAnimateTransformElement.cpp:
3501         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
3502         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
3503         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
3504         (WebCore::SVGAnimateTransformElement::parseTransformValue):
3505         * ksvg2/svg/SVGAnimateTransformElement.h:
3506         * ksvg2/svg/SVGAnimatedTemplate.h:
3507         * ksvg2/svg/SVGAnimationElement.cpp:
3508         (SVGAnimationElement::getSimpleDuration):
3509         (SVGAnimationElement::parseMappedAttribute):
3510         (SVGAnimationElement::setTargetAttribute):
3511         * ksvg2/svg/SVGAnimationElement.h:
3512         * ksvg2/svg/SVGClipPathElement.cpp:
3513         (SVGClipPathElement::SVGClipPathElement):
3514         (SVGClipPathElement::parseMappedAttribute):
3515         (SVGClipPathElement::canvasResource):
3516         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
3517         (SVGComponentTransferFunctionElement::transferFunction):
3518         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
3519         (WebCore::SVGComponentTransferFunctionElement::):
3520         * ksvg2/svg/SVGDocument.cpp:
3521         (WebCore::SVGDocument::dispatchZoomEvent):
3522         (WebCore::SVGDocument::dispatchScrollEvent):
3523         * ksvg2/svg/SVGFEBlendElement.cpp:
3524         (WebCore::SVGFEBlendElement::parseMappedAttribute):
3525         (WebCore::SVGFEBlendElement::filterEffect):
3526         * ksvg2/svg/SVGFEBlendElement.h:
3527         (WebCore::SVGFEBlendElement::):
3528         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3529         (SVGFEColorMatrixElement::parseMappedAttribute):
3530         (SVGFEColorMatrixElement::filterEffect):
3531         * ksvg2/svg/SVGFEColorMatrixElement.h:
3532         (WebCore::SVGFEColorMatrixElement::):
3533         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
3534         (WebCore::SVGFEComponentTransferElement::parseMappedAttribute):
3535         (WebCore::SVGFEComponentTransferElement::filterEffect):
3536         * ksvg2/svg/SVGFEComponentTransferElement.h:
3537         * ksvg2/svg/SVGFECompositeElement.cpp:
3538         (SVGFECompositeElement::parseMappedAttribute):
3539         (SVGFECompositeElement::filterEffect):
3540         * ksvg2/svg/SVGFECompositeElement.h:
3541         (WebCore::SVGFECompositeElement::):
3542         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3543         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
3544         (WebCore::SVGFEDiffuseLightingElement::filterEffect):
3545         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
3546         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3547         (SVGFEDisplacementMapElement::parseMappedAttribute):
3548         (SVGFEDisplacementMapElement::filterEffect):
3549         * ksvg2/svg/SVGFEDisplacementMapElement.h:
3550         (WebCore::SVGFEDisplacementMapElement::):
3551         * ksvg2/svg/SVGFEFloodElement.cpp:
3552         (WebCore::SVGFEFloodElement::parseMappedAttribute):
3553         (WebCore::SVGFEFloodElement::filterEffect):
3554         * ksvg2/svg/SVGFEFloodElement.h:
3555         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
3556         (SVGFEGaussianBlurElement::parseMappedAttribute):
3557         (SVGFEGaussianBlurElement::filterEffect):
3558         * ksvg2/svg/SVGFEGaussianBlurElement.h:
3559         * ksvg2/svg/SVGFEMergeElement.cpp:
3560         (SVGFEMergeElement::filterEffect):
3561         * ksvg2/svg/SVGFEMergeNodeElement.cpp:
3562         (SVGFEMergeNodeElement::parseMappedAttribute):
3563         * ksvg2/svg/SVGFEMergeNodeElement.h:
3564         * ksvg2/svg/SVGFEOffsetElement.cpp:
3565         (SVGFEOffsetElement::parseMappedAttribute):
3566         (SVGFEOffsetElement::filterEffect):
3567         * ksvg2/svg/SVGFEOffsetElement.h:
3568         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
3569         (SVGFESpecularLightingElement::parseMappedAttribute):
3570         (SVGFESpecularLightingElement::filterEffect):
3571         * ksvg2/svg/SVGFESpecularLightingElement.h:
3572         * ksvg2/svg/SVGFETileElement.cpp:
3573         (WebCore::SVGFETileElement::parseMappedAttribute):
3574         (WebCore::SVGFETileElement::filterEffect):
3575         * ksvg2/svg/SVGFETileElement.h:
3576         * ksvg2/svg/SVGFETurbulenceElement.h:
3577         (WebCore::SVGFETurbulenceElement::):
3578         * ksvg2/svg/SVGFilterElement.cpp:
3579         (SVGFilterElement::SVGFilterElement):
3580         (SVGFilterElement::parseMappedAttribute):
3581         (SVGFilterElement::canvasResource):
3582         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
3583         (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
3584         * ksvg2/svg/SVGGradientElement.cpp:
3585         (SVGGradientElement::SVGGradientElement):
3586         (SVGGradientElement::parseMappedAttribute):
3587         * ksvg2/svg/SVGGradientElement.h:
3588         (WebCore::SVGGradientElement::):
3589         * ksvg2/svg/SVGHelper.cpp:
3590         (WebCore::SVGHelper::ParseSeperatedList):
3591         * ksvg2/svg/SVGLengthList.cpp:
3592         (WebCore::SVGLengthList::parse):
3593         * ksvg2/svg/SVGLinearGradientElement.cpp:
3594         (SVGLinearGradientElement::buildGradient):
3595         * ksvg2/svg/SVGList.h:
3596         (WebCore::SVGListBase::clear):
3597         (WebCore::SVGListBase::initialize):
3598         (WebCore::SVGListBase::getItem):
3599         (WebCore::SVGListBase::insertItemBefore):
3600         (WebCore::SVGListBase::replaceItem):
3601         (WebCore::SVGListBase::removeItem):
3602         (WebCore::SVGListBase::appendItem):
3603         * ksvg2/svg/SVGLocatable.cpp:
3604         * ksvg2/svg/SVGLocatable.h:
3605         * ksvg2/svg/SVGMarkerElement.h:
3606         (WebCore::SVGMarkerElement::):
3607         * ksvg2/svg/SVGNumberList.cpp:
3608         (SVGNumberList::parse):
3609         * ksvg2/svg/SVGPaint.cpp:
3610         (WebCore::SVGPaint::SVGPaint):
3611         (WebCore::SVGPaint::uri):
3612         (WebCore::SVGPaint::setUri):
3613         (WebCore::SVGPaint::setPaint):
3614         * ksvg2/svg/SVGPaint.h:
3615         (WebCore::SVGPaint::):
3616         * ksvg2/svg/SVGPathElement.cpp:
3617         (WebCore::SVGPathElement::svgMoveTo):
3618         (WebCore::SVGPathElement::svgLineTo):
3619         (WebCore::SVGPathElement::svgLineToHorizontal):
3620         (WebCore::SVGPathElement::svgLineToVertical):
3621         (WebCore::SVGPathElement::svgCurveToCubic):
3622         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
3623         (WebCore::SVGPathElement::svgCurveToQuadratic):
3624         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
3625         (WebCore::SVGPathElement::svgArcTo):
3626         (WebCore::SVGPathElement::svgClosePath):
3627         (WebCore::SVGPathElement::parseMappedAttribute):
3628         (WebCore::SVGPathElement::toPathData):
3629         * ksvg2/svg/SVGPatternElement.cpp:
3630         (WebCore::SVGPatternElement::SVGPatternElement):
3631         (WebCore::SVGPatternElement::parseMappedAttribute):
3632         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
3633         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
3634         * ksvg2/svg/SVGPolyElement.cpp:
3635         (SVGPolyElement::parseMappedAttribute):
3636         (SVGPolyElement::svgPolyTo):
3637         (SVGPolyElement::notifyAttributeChange):
3638         * ksvg2/svg/SVGPolygonElement.cpp:
3639         (SVGPolygonElement::toPathData):
3640         * ksvg2/svg/SVGPolylineElement.cpp:
3641         (SVGPolylineElement::toPathData):
3642         * ksvg2/svg/SVGRadialGradientElement.cpp:
3643         (WebCore::SVGRadialGradientElement::buildGradient):
3644         * ksvg2/svg/SVGRenderingIntent.h: Added.
3645         (WebCore::SVGRenderingIntent::):
3646         (WebCore::SVGRenderingIntent::SVGRenderingIntent):
3647         (WebCore::SVGRenderingIntent::~SVGRenderingIntent):
3648         * ksvg2/svg/SVGSVGElement.h:
3649         (WebCore::SVGSVGElement::):
3650         * ksvg2/svg/SVGScriptElement.cpp:
3651         (WebCore::SVGScriptElement::type):
3652         (WebCore::SVGScriptElement::setType):
3653         (WebCore::SVGScriptElement::parseMappedAttribute):
3654         * ksvg2/svg/SVGScriptElement.h:
3655         * ksvg2/svg/SVGStringList.cpp:
3656         (WebCore::SVGStringList::reset):
3657         * ksvg2/svg/SVGStyledLocatableElement.cpp:
3658         (SVGStyledLocatableElement::getTransformToElement):
3659         * ksvg2/svg/SVGStyledLocatableElement.h:
3660         * ksvg2/svg/SVGStyledTransformableElement.cpp:
3661         (SVGStyledTransformableElement::parseMappedAttribute):
3662         (SVGStyledTransformableElement::getTransformToElement):
3663         * ksvg2/svg/SVGStyledTransformableElement.h:
3664         * ksvg2/svg/SVGTests.cpp:
3665         (WebCore::SVGTests::hasExtension):
3666         (WebCore::SVGTests::isValid):
3667         * ksvg2/svg/SVGTests.h:
3668         * ksvg2/svg/SVGTextContentElement.cpp:
3669         (SVGTextContentElement::getSubStringLength):
3670         (SVGTextContentElement::getStartPositionOfChar):
3671         (SVGTextContentElement::getEndPositionOfChar):
3672         (SVGTextContentElement::getExtentOfChar):
3673         (SVGTextContentElement::getRotationOfChar):
3674         (SVGTextContentElement::selectSubString):
3675         * ksvg2/svg/SVGTextContentElement.h:
3676         (WebCore::SVGTextContentElement::):
3677         * ksvg2/svg/SVGTextElement.cpp:
3678         (WebCore::SVGTextElement::parseMappedAttribute):
3679         * ksvg2/svg/SVGTextElement.h:
3680         (WebCore::SVGTextElement::getTransformToElement):
3681         * ksvg2/svg/SVGTransform.h:
3682         * ksvg2/svg/SVGTransformList.cpp:
3683         (SVGTransformList::consolidate):
3684         (SVGTransformList::concatenate):
3685         * ksvg2/svg/SVGTransformable.cpp:
3686         (SVGTransformable::parseTransformAttribute):
3687         * ksvg2/svg/SVGUnitTypes.h: Added.
3688         (WebCore::SVGUnitTypes::):
3689         (WebCore::SVGUnitTypes::SVGUnitTypes):
3690         (WebCore::SVGUnitTypes::~SVGUnitTypes):
3691         * ksvg2/svg/SVGUseElement.cpp:
3692         (SVGUseElement::closeRenderer):
3693         * ksvg2/svg/SVGViewElement.h:
3694         (WebCore::SVGViewElement::):
3695         * ksvg2/svg/SVGZoomAndPan.cpp:
3696         (WebCore::SVGZoomAndPan::SVGZoomAndPan):
3697         (WebCore::SVGZoomAndPan::parseMappedAttribute):
3698
3699 2006-09-12  John Sullivan  <sullivan@apple.com>
3700
3701         Reviewed by Adele Peterson.
3702
3703         * bridge/mac/FrameMac.mm:
3704         (WebCore::FrameMac::doTextFieldCommandFromEvent):
3705         Don't call textField:doCommandBySelector: with a nil selector. This was indirectly causing a
3706         (valid) assertion failure in some Safari code.
3707
3708 2006-09-12  David Harrison  <harrison@apple.com>
3709
3710         Reviewed by John Sullivan.
3711
3712         <rdar://problem/4717841> Setting AXFocused to true does not activate the insertion point in text field
3713
3714         * bridge/mac/WebCoreAXObject.mm:
3715         (-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
3716         For AXFocus, use focus() if the node is an element, so that selection is set.
3717         Matches tabbing behavior in text fields and text areas.
3718
3719 2006-09-12  Adam Roben  <aroben@apple.com>
3720
3721         Reviewed by adele.
3722
3723         Make uploading work with the new file upload control.
3724
3725         * css/html4.css: Remove unnecessary style (this is already done in
3726         RenderFileUpload.cpp)
3727         * html/HTMLInputElement.cpp: Don't get the button text from the value
3728         attribute for file controls.
3729         (WebCore::HTMLInputElement::valueWithDefault):
3730         * platform/mac/FileChooserMac.mm: Call
3731         RenderFileUploadControl::valueChanged when the user selects a file.
3732         (WebCore::FileChooser::chooseFile):
3733         * rendering/RenderFileUploadControl.cpp: Add valueChanged() method to
3734         update the form and fire the onChange event.
3735         (WebCore::RenderFileUploadControl::valueChanged):
3736         (WebCore::RenderFileUploadControl::updateFromElement):
3737         * rendering/RenderFileUploadControl.h: Add valueChanged() declaration.
3738
3739 2006-09-12  Adam Roben  <aroben@apple.com>
3740
3741         Adding rules to html4.css to style the button in file upload controls.
3742
3743         * css/html4.css:
3744
3745 2006-09-12  Adam Roben  <aroben@apple.com>
3746
3747         Reviewed many times by darin, hyatt.
3748
3749         Switch to new engine-based implementation of <input type="file">
3750
3751         * WebCore.exp: Remove obsolete symbol WebCoreFileButton
3752         * WebCore.xcodeproj/project.pbxproj: Remove files for old widget-based
3753         control, add files for new engine-based control
3754         * css/CSSSelector.cpp: Add support for new
3755         '-webkit-file-upload-button' pseudo element
3756         (WebCore::CSSSelector::extractPseudoType):
3757         * css/CSSSelector.h: Ditto.
3758         (WebCore::CSSSelector::):
3759         * css/cssstyleselector.cpp: Ditto.
3760         (WebCore::CSSStyleSelector::checkOneSelector):
3761         * html/HTMLInputElement.cpp: Send click events to new control
3762         (WebCore::HTMLInputElement::select):
3763         (WebCore::HTMLInputElement::click):
3764         (WebCore::HTMLInputElement::createRenderer):
3765         (WebCore::HTMLInputElement::valueWithDefault):
3766         (WebCore::HTMLInputElement::defaultEventHandler):
3767         * html/HTMLTextFieldInnerElement.h: Add 'virtual' keyword
3768         (WebCore::HTMLTextFieldInnerElement::shadowParentNode):
3769         * platform/FileButton.h: Removed.
3770         * platform/FileChooser.h: Added. This is the replacement for
3771         FileButton.h
3772         (WebCore::FileChooser::filename):
3773         (WebCore::FileChooser::icon):
3774         (WebCore::FileChooser::uploadControl):
3775         (WebCore::FileChooser::document):
3776         * platform/Icon.h: Added new platform-specific class representing a
3777         file icon.
3778         * platform/LocalizedStrings.h:
3779         * platform/mac/FileButtonMac.mm: Removed.
3780         * platform/mac/FileChooserMac.mm: Added. This is the replacement for
3781         FileButtonMac.mm
3782         (-[OpenPanelController initWithFileChooser:]):
3783         (-[OpenPanelController fileChooserDetachingSoon]):
3784         (-[OpenPanelController beginSheet]):
3785         (-[OpenPanelController chooseFilename:]):
3786         (-[OpenPanelController cancel]):
3787         (WebCore::FileChooser::FileChooser):
3788         (WebCore::FileChooser::~FileChooser):
3789         (WebCore::FileChooser::openFileChooser):
3790         (WebCore::FileChooser::basenameForWidth):
3791         (WebCore::FileChooser::uploadControlDetaching):
3792         (WebCore::FileChooser::chooseFile):
3793         * platform/mac/IconMac.mm: Added.
3794         (WebCore::Icon::Icon):
3795         (WebCore::Icon::~Icon):
3796         (WebCore::Icon::newIconForFile):
3797         (WebCore::Icon::paint):
3798         * platform/mac/LocalizedStringsMac.mm: Call across bridge to get
3799         localized strings.
3800         (WebCore::fileButtonChooseFileLabel):
3801         (WebCore::fileButtonNoFileSelectedLabel):
3802         * rendering/RenderButton.cpp: Extract method setText() from
3803         updateFromElement.
3804         (WebCore::RenderButton::updateFromElement):
3805         (WebCore::RenderButton::setText):
3806         * rendering/RenderButton.h: Add declaration for new setText method.
3807         * rendering/RenderFileButton.cpp: Removed.
3808         * rendering/RenderFileButton.h: Removed.
3809         * rendering/RenderFileUploadControl.cpp: Added. This is the
3810         replacement for RenderFileButton.cpp.
3811         (WebCore::RenderFileUploadInnerFileBox::renderName):
3812         (WebCore::HTMLFileUploadInnerButtonElement::isShadowNode):
3813         (WebCore::HTMLFileUploadInnerButtonElement::shadowParentNode):
3814         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
3815         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
3816         (WebCore::RenderFileUploadControl::setStyle):
3817         (WebCore::RenderFileUploadControl::updateIconAndFilename):
3818         (WebCore::RenderFileUploadControl::click):
3819         (WebCore::RenderFileUploadControl::updateFromElement):
3820         (WebCore::RenderFileUploadControl::maxFilenameWidth):
3821         (WebCore::RenderFileUploadControl::createButtonStyle):
3822         (WebCore::RenderFileUploadControl::paintObject):
3823         (WebCore::RenderFileUploadInnerFileBox::RenderFileUploadInnerFileBox):
3824         (WebCore::RenderFileUploadInnerFileBox::setStyle):
3825         (WebCore::RenderFileUploadInnerFileBox::layout):
3826         (WebCore::RenderFileUploadInnerFileBox::setHasIcon):
3827         (WebCore::RenderFileUploadInnerFileBox::setFilename):
3828         (WebCore::RenderFileUploadInnerFileBox::calcMinMaxWidth):
3829         (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement):
3830         (WebCore::HTMLFileUploadInnerButtonElement::createRenderer):
3831         * rendering/RenderFileUploadControl.h: Added. This is the replacement
3832         for RenderFileButton.h.
3833         (WebCore::RenderFileUploadControl::renderName):
3834         * rendering/RenderStyle.cpp: Add support for
3835         -webkit-file-upload-button pseudo element.
3836         (WebCore::):
3837         (WebCore::pseudoBit):
3838         * rendering/RenderStyle.h: Ditto.
3839         (WebCore::RenderStyle::):
3840
3841 2006-09-12  Anders Carlsson  <acarlsson@apple.com>
3842
3843         Reviewed by John Sullivan.
3844
3845         Do the plugin object cleanup in Frame::clear instead of setView.
3846
3847         * bridge/mac/FrameMac.h:
3848         * bridge/mac/FrameMac.mm:
3849         (WebCore::FrameMac::setView):
3850         (WebCore::FrameMac::cleanupPluginObjects):
3851         * page/Frame.cpp:
3852         (WebCore::Frame::clear):
3853         * page/Frame.h:
3854
3855 2006-09-12  MorganL  <morlmor@yahoo.com>
3856
3857         Reviewed/landed by aroben.
3858
3859         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10822
3860         windows build is busted
3861
3862         * WebCore.vcproj/WebCore/WebCore.vcproj: Add missing
3863         JSRangeException.{cpp,h} to project
3864
3865 2006-09-12  David Hyatt  <hyatt@apple.com>
3866
3867         Fix fieldsets so that they properly expand to enclose overhanging floats
3868         when the fieldset has auto height.  This is a nifty undocumented behavior
3869         of the fieldset element.  The bug is 3898.
3870
3871         Reviewed by mjs
3872
3873         Added fast/forms/fieldset-with-float.html
3874
3875         * rendering/RenderBlock.cpp:
3876         (WebCore::RenderBlock::layoutBlock):
3877         * rendering/RenderFieldset.h:
3878         (WebCore::RenderFieldset::renderName):
3879         (WebCore::RenderFieldset::expandsToEncloseOverhangingFloats):
3880         * rendering/RenderObject.h:
3881         (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
3882         * rendering/RenderTableCell.h:
3883         (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats):
3884
3885 2006-09-11  Eric Seidel  <eric@eseidel.com>
3886
3887         Reviewed by hyatt.
3888
3889         REGRESSION: When dragging a link on a page, the selected link doesn't display it's name or URL
3890         http://bugzilla.opendarwin.org/show_bug.cgi?id=10819
3891         http://bugzilla.opendarwin.org/show_bug.cgi?id=10814
3892
3893         No test cases were harmed in the coding of the patch.
3894
3895         * platform/mac/WebCoreTextRenderer.mm:
3896         (WebCoreDrawTextAtPoint):
3897
3898 2006-09-11  David Hyatt  <hyatt@apple.com>
3899
3900         Fix for bug 8126, column widths apply to the border boxes of cells.
3901
3902         Reviewed by aroben
3903
3904         * rendering/RenderTableCell.cpp:
3905         (WebCore::RenderTableCell::styleOrColWidth):
3906
3907 2006-09-11  Nikolas Zimmermann  <zimmermann@kde.org>
3908
3909         Reviewed by Adele.
3910
3911         Fix Qt/Linux build.
3912
3913         * CMakeLists.txt: Add dom/RangeException.idl to build & fix feature defines.
3914
3915 2006-09-11  Nikolas Zimmermann  <zimmermann@kde.org>
3916
3917         Reviewed by eseidel.  Landed by eseidel.
3918
3919         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10750
3920
3921         This finally fixes the SVGAnimated* classes JS bindings!
3922
3923         - Move all SVGAnimated*.idl files from ksvg2/bindings/idl/svg to ksvg2/svg
3924         - Adjust XCode/Qt build files to generate the new idl files
3925
3926         - Remove all SVGAnimated* primitives cpp implementations (Angle/Boolean/Color/Enumeration/Integer/Length/
3927                                                                   LengthList/Number/NumberList/PreserveAspectRatio/
3928                                                                   Rect/String/TransformList)
3929
3930         - Remove unneeded methods from CodeGenerator.pm and add new helper function: IsSVGAnimatedType
3931         - Adjust CodeGeneratorJS.pm to the new SVGAnimated* tear-off concept
3932
3933         - Add two new macros: ANIMATED_PROPERTY_EMPTY_DECLARATIONS / ANIMATED_PROPERTY_FORWARD_DECLARATIONS.
3934           This is used to fix multiple-inheritance issues in SVG with properties,
3935           similar like SVGTests::isValid() was fixed.
3936
3937         - Rewrote SVGList using WTF::Vector, instead of DeprecatedPtrList and killed DOMList.
3938           (SVGAnimated*Lists work again now)
3939
3940         - Adjust macros in SVGElement to create the "*Animated" tear-off classes.
3941
3942         - Adjust all SVG classes which use the ANIMATED macros to include the ClassName as first param in the header.
3943
3944         * CMakeLists.txt:
3945         * DerivedSources.make:
3946         * WebCore.xcodeproj/project.pbxproj:
3947         * bindings/scripts/CodeGenerator.pm:
3948         * bindings/scripts/CodeGeneratorJS.pm:
3949         * kcanvas/RenderSVGImage.cpp:
3950         (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
3951         (WebCore::RenderSVGImage::paint):
3952         * kcanvas/RenderSVGText.cpp:
3953         (WebCore::RenderSVGText::translationForAttributes):
3954         * ksvg2/ksvg.h:
3955         * ksvg2/misc/SVGDocumentExtensions.h:
3956         (WebCore::FloatRect):
3957         * ksvg2/svg/SVGAElement.h:
3958         * ksvg2/svg/SVGAnimateColorElement.cpp:
3959         * ksvg2/svg/SVGAnimateColorElement.h:
3960         * ksvg2/svg/SVGAnimateTransformElement.h:
3961         * ksvg2/svg/SVGAnimatedTemplate.h:
3962         (WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate):
3963         * ksvg2/svg/SVGAnimationElement.h:
3964         * ksvg2/svg/SVGCircleElement.h:
3965         * ksvg2/svg/SVGClipPathElement.h:
3966         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
3967         (SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
3968         (SVGComponentTransferFunctionElement::transferFunction):
3969         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
3970         * ksvg2/svg/SVGCursorElement.h:
3971         * ksvg2/svg/SVGDefsElement.h:
3972         * ksvg2/svg/SVGElement.h:
3973         * ksvg2/svg/SVGElementInstanceList.cpp:
3974         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
3975         * ksvg2/svg/SVGElementInstanceList.h:
3976         * ksvg2/svg/SVGEllipseElement.h:
3977         * ksvg2/svg/SVGExternalResourcesRequired.h:
3978         * ksvg2/svg/SVGFEBlendElement.h:
3979         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3980         (SVGFEColorMatrixElement::SVGFEColorMatrixElement):
3981         (SVGFEColorMatrixElement::parseMappedAttribute):
3982         (SVGFEColorMatrixElement::filterEffect):
3983         * ksvg2/svg/SVGFEColorMatrixElement.h:
3984         * ksvg2/svg/SVGFEComponentTransferElement.h:
3985         * ksvg2/svg/SVGFECompositeElement.h:
3986         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
3987         * ksvg2/svg/SVGFEDisplacementMapElement.h:
3988         * ksvg2/svg/SVGFEFloodElement.h:
3989         * ksvg2/svg/SVGFEGaussianBlurElement.h:
3990         * ksvg2/svg/SVGFEImageElement.h:
3991         * ksvg2/svg/SVGFELightElement.h:
3992         * ksvg2/svg/SVGFEMergeNodeElement.h:
3993         * ksvg2/svg/SVGFEOffsetElement.h:
3994         * ksvg2/svg/SVGFESpecularLightingElement.h:
3995         * ksvg2/svg/SVGFETileElement.h:
3996         * ksvg2/svg/SVGFETurbulenceElement.h:
3997         * ksvg2/svg/SVGFilterElement.h:
3998         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
3999         * ksvg2/svg/SVGFitToViewBox.cpp:
4000         (WebCore::SVGFitToViewBox::SVGFitToViewBox):
4001         (WebCore::SVGFitToViewBox::parseViewBox):
4002         (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
4003         * ksvg2/svg/SVGFitToViewBox.h:
4004         * ksvg2/svg/SVGForeignObjectElement.h:
4005         * ksvg2/svg/SVGGElement.h:
4006         * ksvg2/svg/SVGGradientElement.cpp:
4007         (SVGGradientElement::SVGGradientElement):
4008         * ksvg2/svg/SVGGradientElement.h:
4009         * ksvg2/svg/SVGHelper.cpp:
4010         (WebCore::SVGHelper::PercentageOfViewport):
4011         * ksvg2/svg/SVGImageElement.h:
4012         * ksvg2/svg/SVGLength.cpp:
4013         * ksvg2/svg/SVGLengthList.cpp:
4014         (WebCore::SVGLengthList::SVGLengthList):
4015         (WebCore::SVGLengthList::parse):
4016         * ksvg2/svg/SVGLengthList.h:
4017         * ksvg2/svg/SVGLineElement.h:
4018         * ksvg2/svg/SVGLinearGradientElement.h:
4019         * ksvg2/svg/SVGList.h:
4020         (WebCore::SVGListBase::SVGListBase):
4021         (WebCore::SVGListBase::~SVGListBase):
4022         (WebCore::SVGListBase::numberOfItems):
4023         (WebCore::SVGListBase::clear):
4024         (WebCore::SVGListBase::initialize):
4025         (WebCore::SVGListBase::getFirst):
4026         (WebCore::SVGListBase::getLast):
4027         (WebCore::SVGListBase::getItem):
4028         (WebCore::SVGListBase::insertItemBefore):
4029         (WebCore::SVGListBase::replaceItem):
4030         (WebCore::SVGListBase::removeItem):
4031         (WebCore::SVGListBase::appendItem):
4032         (WebCore::SVGList::nullItem):
4033         (WebCore::):
4034         * ksvg2/svg/SVGLocatable.cpp:
4035         * ksvg2/svg/SVGMarkerElement.h:
4036         * ksvg2/svg/SVGMaskElement.h:
4037         * ksvg2/svg/SVGNumberList.cpp:
4038         (SVGNumberList::SVGNumberList):
4039         (SVGNumberList::parse):
4040         * ksvg2/svg/SVGNumberList.h:
4041         * ksvg2/svg/SVGPathElement.cpp:
4042         (WebCore::SVGPathElement::pathSegList):
4043         * ksvg2/svg/SVGPathElement.h:
4044         * ksvg2/svg/SVGPathSegList.cpp:
4045         (WebCore::SVGPathSegList::SVGPathSegList):
4046         * ksvg2/svg/SVGPathSegList.h:
4047         * ksvg2/svg/SVGPatternElement.cpp:
4048         (WebCore::SVGPatternElement::SVGPatternElement):
4049         * ksvg2/svg/SVGPatternElement.h:
4050         * ksvg2/svg/SVGPointList.cpp:
4051         (SVGPointList::SVGPointList):
4052         * ksvg2/svg/SVGPointList.h:
4053         * ksvg2/svg/SVGPolyElement.cpp:
4054         (SVGPolyElement::points):
4055         (SVGPolyElement::svgPolyTo):
4056         (SVGPolyElement::notifyAttributeChange):
4057         * ksvg2/svg/SVGPolyElement.h:
4058         * ksvg2/svg/SVGPolygonElement.cpp:
4059         (SVGPolygonElement::toPathData):
4060         * ksvg2/svg/SVGPolylineElement.cpp:
4061         (SVGPolylineElement::toPathData):
4062         * ksvg2/svg/SVGPreserveAspectRatio.h:
4063         (WebCore::SVGPreserveAspectRatio::):
4064         * ksvg2/svg/SVGRadialGradientElement.h:
4065         * ksvg2/svg/SVGRectElement.h:
4066         * ksvg2/svg/SVGSVGElement.cpp:
4067         (WebCore::SVGSVGElement::SVGSVGElement):
4068         (WebCore::SVGSVGElement::parseMappedAttribute):
4069         (WebCore::SVGSVGElement::createRenderer):
4070         * ksvg2/svg/SVGSVGElement.h:
4071         * ksvg2/svg/SVGScriptElement.h:
4072         * ksvg2/svg/SVGStopElement.h:
4073         * ksvg2/svg/SVGStringList.cpp:
4074         (WebCore::SVGStringList::SVGStringList):
4075         (WebCore::SVGStringList::reset):
4076         * ksvg2/svg/SVGStringList.h:
4077         * ksvg2/svg/SVGStyledElement.h:
4078         * ksvg2/svg/SVGStyledLocatableElement.cpp:
4079         * ksvg2/svg/SVGStyledTransformableElement.cpp:
4080         (SVGStyledTransformableElement::SVGStyledTransformableElement):
4081         * ksvg2/svg/SVGStyledTransformableElement.h:
4082         * ksvg2/svg/SVGSwitchElement.h:
4083         * ksvg2/svg/SVGSymbolElement.h:
4084         * ksvg2/svg/SVGTRefElement.h:
4085         * ksvg2/svg/SVGTests.cpp:
4086         (WebCore::SVGTests::isValid):
4087         * ksvg2/svg/SVGTextContentElement.h:
4088         * ksvg2/svg/SVGTextElement.cpp:
4089         (WebCore::SVGTextElement::SVGTextElement):
4090         * ksvg2/svg/SVGTextElement.h:
4091         * ksvg2/svg/SVGTextPositioningElement.cpp:
4092         (SVGTextPositioningElement::SVGTextPositioningElement):
4093         (SVGTextPositioningElement::parseMappedAttribute):
4094         * ksvg2/svg/SVGTextPositioningElement.h:
4095         * ksvg2/svg/SVGTransformList.cpp:
4096         (SVGTransformList::SVGTransformList):
4097         (SVGTransformList::createSVGTransformFromMatrix):
4098         (SVGTransformList::consolidate):
4099         (SVGTransformList::concatenate):
4100         * ksvg2/svg/SVGTransformList.h:
4101         * ksvg2/svg/SVGURIReference.h:
4102         * ksvg2/svg/SVGUseElement.h:
4103         * ksvg2/svg/SVGViewElement.h:
4104
4105 2006-09-11  Adam Roben  <aroben@apple.com>
4106
4107         Rubberstamped by Adele.
4108
4109         Rename LocalGraphicsContext.{h,mm} to
4110         LocalCurrentGraphicsContext.{h,mm} to match the class name.
4111
4112         * WebCore.xcodeproj/project.pbxproj:
4113         * platform/mac/LocalCurrentGraphicsContext.mm: Added.
4114         * platform/mac/LocalCurrentGraphicsContext.h: Added.
4115         * platform/mac/LocalGraphicsContext.h: Removed.
4116         * platform/mac/LocalGraphicsContext.mm: Removed.
4117         * rendering/RenderThemeMac.mm: Fix #include to match renamed file
4118
4119 2006-09-11  Brady Eidson  <beidson@apple.com>
4120
4121         Build fix
4122
4123         * WebCore.xcodeproj/project.pbxproj:
4124
4125 2006-09-11  Kevin McCullough  <KMcCullough@apple.com>
4126
4127         Reviewed by Darin.
4128
4129         - Implements comparePoint on the Range class
4130
4131         - Exposes RangeExceptions in JavaScript
4132
4133         * DerivedSources.make:
4134         * WebCore.xcodeproj/project.pbxproj:
4135         * bindings/js/kjs_binding.cpp:
4136         * bindings/objc/DOMInternal.mm:
4137         * dom/Range.cpp:
4138         (WebCore::Range::comparePoint):
4139         (WebCore::Range::compareNode):
4140         * dom/Range.h:
4141         (WebCore::Range::):
4142         * dom/Range.idl:
4143         * dom/RangeException.h: Added.
4144         (WebCore::):
4145         * dom/RangeException.idl: Added.
4146         * page/DOMWindow.idl:
4147
4148 2006-09-11  Adam Roben  <aroben@apple.com>
4149
4150         Reviewed by timo.
4151
4152         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10812
4153         Move LocalGraphicsContext out of RenderThemeMac
4154
4155         * WebCore.xcodeproj/project.pbxproj:
4156         * platform/mac/LocalGraphicsContext.h: Added.
4157         * platform/mac/LocalGraphicsContext.mm: Added.
4158         (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
4159         (WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
4160         * rendering/RenderThemeMac.mm:
4161
4162 2006-09-11  Vladimir Olexa  <vladimir.olexa@gmail.com>
4163
4164         Reviewed by Darin.
4165
4166         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10323
4167           REGRESSION: javascript: URL containing '\\' gets passed as '//'
4168
4169         Test: fast/dom/javascript-backslash.html
4170
4171         * platform/KURL.cpp: (WebCore::KURL::init): Don't do backslash
4172         substitution in JavaScript URLs.
4173
4174 2006-09-11  Sam Weinig  <sam.weinig@gmail.com>
4175
4176         Reviewed by Darin and Tim H.
4177
4178         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10792
4179         Remove the [Exclude=LANGUAGE] idiom from IDL's and code generators
4180         for something better
4181
4182         - Replaces [Exclude=LANGUAGE] idiom with preprocessor #if defined(LANGUAGE)
4183           idiom.
4184
4185         - Assorted whitespace changes to IDL files.
4186
4187         * DerivedSources.make:
4188         * WebCore.xcodeproj/project.pbxproj:
4189         * bindings/objc/DOMEvents.h:
4190         * bindings/scripts/CodeGenerator.pm:
4191         * bindings/scripts/CodeGeneratorJS.pm:
4192         * bindings/scripts/CodeGeneratorObjC.pm:
4193         * css/CSSRule.idl:
4194         * css/CSSStyleDeclaration.idl:
4195         * css/CSSValue.idl:
4196         * dom/DOMImplementation.idl:
4197         * dom/Document.idl:
4198         * dom/Element.idl:
4199         * dom/Event.idl:
4200         * dom/KeyboardEvent.idl:
4201         * dom/MouseEvent.idl:
4202         * dom/NamedNodeMap.idl:
4203         * dom/NodeFilter.idl:
4204         * dom/UIEvent.idl:
4205         * dom/WheelEvent.idl:
4206         * html/HTMLAnchorElement.idl:
4207         * html/HTMLAreaElement.idl:
4208         * html/HTMLDocument.idl:
4209         * html/HTMLElement.idl:
4210         * html/HTMLImageElement.idl:
4211         * html/HTMLInputElement.idl:
4212         * html/HTMLLinkElement.idl:
4213         * html/HTMLOptionsCollection.idl:
4214
4215 2006-09-11  David Hyatt  <hyatt@apple.com>
4216
4217         Fix an unwitting victim of the kMin->min change.  calcBlockMinMaxWidth
4218         was accidentally renamed to calcBlominMaxWidth.
4219
4220         * rendering/RenderBlock.cpp:
4221         (WebCore::RenderBlock::calcMinMaxWidth):
4222         (WebCore::RenderBlock::calcBlockMinMaxWidth):
4223         * rendering/RenderBlock.h:
4224
4225 2006-09-10  David Hyatt  <hyatt@apple.com>
4226
4227         Rework the printer font stuff a little bit so that the Font API doesn't
4228         have to be changed.
4229
4230         Reviewed by eseidel
4231
4232         * WebCore.xcodeproj/project.pbxproj:
4233         * bridge/mac/WebCoreStringTruncator.mm:
4234         (truncateString):
4235         (+[WebCoreStringTruncator widthOfString:font:]):
4236         * platform/Font.cpp:
4237         (WebCore::Font::drawSimpleText):
4238         * platform/Font.h:
4239         * platform/TextStyle.h:
4240         (WebCore::TextStyle::TextStyle):
4241         (WebCore::TextStyle::attemptFontSubstitution):
4242         (WebCore::TextStyle::setRTL):
4243         * platform/mac/FontMac.mm:
4244         (WebCore::m_wordSpacing):
4245         (WebCore::Font::drawGlyphs):
4246         * platform/mac/ListBoxMac.mm:
4247         (itemTextRenderer):
4248         (groupLabelTextRenderer):
4249         (-[WebCoreTableView drawRow:clipRect:]):
4250         * platform/mac/PopUpButtonMac.mm:
4251         (PopUpButton::sizeHint):
4252         * platform/mac/TextFieldMac.mm:
4253         (-[NSSearchFieldCell _addStringToRecentSearches:]):
4254         * platform/mac/WebCoreTextRenderer.mm:
4255         (WebCoreDrawTextAtPoint):
4256         (WebCoreTextFloatWidth):
4257         * rendering/EllipsisBox.cpp:
4258         (WebCore::EllipsisBox::paint):
4259         * rendering/InlineTextBox.cpp:
4260         (WebCore::InlineTextBox::paint):
4261         * rendering/RenderImage.cpp:
4262         (WebCore::RenderImage::paint):