c7b014b18425233b328264314aaa6745e8a4e22f
[WebKit-https.git] / WebCore / ChangeLog
1 2008-09-08  Alexey Proskuryakov  <ap@webkit.org>
2
3         Reviewed by Darin Adler.
4
5         https://bugs.webkit.org/show_bug.cgi?id=20668
6         multipart/form-data does not always include Content-type for submitted files
7
8         Cannot be tested with DRT or manual tests.
9
10         * platform/MIMETypeRegistry.cpp:
11         (WebCore::initializeSupportedNonImageMimeTypes): Fix spacing.
12         (WebCore::MIMETypeRegistry::getMIMETypeForPath): Default to application/octet-stream for
13         unknown extensions, not just missing ones.
14
15 2008-09-08  Simon Hausmann  <hausmann@webkit.org>
16
17         Build fix for the Qt/Windows build, define USE_JSC to
18         enable the WebCore::String -> JSC::UString operator that
19         MSVC insists on seeing
20
21         * WebCore.pro:
22
23 2008-09-08  Anders Carlsson  <andersca@apple.com>
24
25         Reviewed by Maciej.
26
27         <rdar://problem/5850387> Showing bookmarks reloads Google Reader instead.
28         
29         In some cases, timeouts scheduled by a page in the onunload handler could fire even when the
30         page had been unloaded and replaced by a non-HTML representation based view (such as the bookmarks view).
31         
32         Fix this by clearing timeouts for pages that aren't cached when the provisional load is committed.
33         
34         * bindings/js/JSDOMWindowBase.h:
35         * loader/FrameLoader.cpp:
36         (WebCore::FrameLoader::commitProvisionalLoad):
37
38 2008-09-07  Antti Koivisto  <antti@apple.com>
39
40         Reviewed by Dave Hyatt.
41
42         Don't leak the simple stylesheet.
43         Also call RenderTheme::adjustDefaultStyleSheet() in right place.
44
45         * css/CSSStyleSelector.cpp:
46         (WebCore::loadFullDefaultStyle):
47         (WebCore::loadSimpleDefaultStyle):
48         (WebCore::CSSStyleSelector::styleForElement):
49
50 2008-09-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
51
52         Reviewed by Oliver Hunt.
53
54         Bug 20711: Change KJS prefix on preprocessor macros to JSC
55         <https://bugs.webkit.org/show_bug.cgi?id=20711>
56
57         * bindings/js/JSEventTargetBase.h:
58         * bindings/js/JSHTMLInputElementBase.cpp:
59         * bindings/js/JSHTMLInputElementBase.h:
60         * bindings/scripts/CodeGeneratorJS.pm:
61
62 2008-09-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
63
64         Reviewed by Maciej Stachowiak.
65
66         Bug 20704: Replace the KJS namespace
67         <https://bugs.webkit.org/show_bug.cgi?id=20704>
68
69         Rename the KJS namespace to JSC. There are still some uses of KJS in the
70         names of JNI functions, and I will check if these are safe to change
71         as well.
72
73         * WebCore.base.exp:
74         * bindings/js/GCController.cpp:
75         * bindings/js/JSAttrCustom.cpp:
76         * bindings/js/JSAudioConstructor.cpp:
77         * bindings/js/JSAudioConstructor.h:
78         (WebCore::JSAudioConstructor::classInfo):
79         * bindings/js/JSCSSRuleCustom.cpp:
80         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
81         * bindings/js/JSCSSValueCustom.cpp:
82         * bindings/js/JSCanvasPixelArrayCustom.cpp:
83         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
84         * bindings/js/JSClipboardCustom.cpp:
85         * bindings/js/JSConsoleCustom.cpp:
86         * bindings/js/JSCustomSQLStatementCallback.cpp:
87         (WebCore::JSCustomSQLStatementCallback::handleEvent):
88         * bindings/js/JSCustomSQLStatementCallback.h:
89         (WebCore::JSCustomSQLStatementCallback::create):
90         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
91         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
92         * bindings/js/JSCustomSQLStatementErrorCallback.h:
93         (WebCore::JSCustomSQLStatementErrorCallback::create):
94         * bindings/js/JSCustomSQLTransactionCallback.cpp:
95         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
96         * bindings/js/JSCustomSQLTransactionCallback.h:
97         (WebCore::JSCustomSQLTransactionCallback::create):
98         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
99         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
100         * bindings/js/JSCustomSQLTransactionErrorCallback.h:
101         (WebCore::JSCustomSQLTransactionErrorCallback::create):
102         * bindings/js/JSCustomVoidCallback.cpp:
103         (WebCore::JSCustomVoidCallback::handleEvent):
104         * bindings/js/JSCustomVoidCallback.h:
105         (WebCore::JSCustomVoidCallback::create):
106         * bindings/js/JSCustomXPathNSResolver.cpp:
107         (WebCore::JSCustomXPathNSResolver::create):
108         * bindings/js/JSCustomXPathNSResolver.h:
109         * bindings/js/JSDOMApplicationCacheCustom.cpp:
110         (WebCore::JSDOMApplicationCache::dispatchEvent):
111         * bindings/js/JSDOMBinding.cpp:
112         (WebCore::jsOwnedStringOrNull):
113         * bindings/js/JSDOMBinding.h:
114         (WebCore::DOMObject::DOMObject):
115         (WebCore::cacheDOMObject):
116         (WebCore::cacheSVGDOMObject):
117         (WebCore::DOMExceptionTranslator::DOMExceptionTranslator):
118         (WebCore::toJS):
119         * bindings/js/JSDOMWindowBase.cpp:
120         * bindings/js/JSDOMWindowBase.h:
121         (WebCore::JSDOMWindowBase::classInfo):
122         (WebCore::JSDOMWindowBase::d):
123         * bindings/js/JSDOMWindowCustom.cpp:
124         (WebCore::JSDOMWindow::getPropertyAttributes):
125         * bindings/js/JSDOMWindowCustom.h:
126         (WebCore::asJSDOMWindow):
127         (WebCore::JSDOMWindow::customGetOwnPropertySlot):
128         (WebCore::JSDOMWindow::customPut):
129         (WebCore::JSDOMWindowBase::allowsAccessFrom):
130         (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
131         * bindings/js/JSDOMWindowShell.cpp:
132         (WebCore::JSDOMWindowShell::getPropertyAttributes):
133         * bindings/js/JSDOMWindowShell.h:
134         (WebCore::JSDOMWindowShell::classInfo):
135         * bindings/js/JSDatabaseCustom.cpp:
136         * bindings/js/JSDocumentCustom.cpp:
137         * bindings/js/JSDocumentFragmentCustom.cpp:
138         * bindings/js/JSElementCustom.cpp:
139         * bindings/js/JSEventCustom.cpp:
140         * bindings/js/JSEventListener.cpp:
141         * bindings/js/JSEventListener.h:
142         (WebCore::JSUnprotectedEventListener::create):
143         (WebCore::JSEventListener::create):
144         * bindings/js/JSEventTargetBase.cpp:
145         * bindings/js/JSEventTargetBase.h:
146         (WebCore::JSEventTargetBase::getValueProperty):
147         (WebCore::JSEventTargetBase::putValueProperty):
148         (WebCore::JSEventTargetBase::getOwnPropertySlot):
149         (WebCore::JSEventTargetBase::put):
150         (WebCore::JSEventTargetPrototype::JSEventTargetPrototype):
151         (WebCore::JSEventTargetPrototype::self):
152         (WebCore::JSEventTargetPrototype::getOwnPropertySlot):
153         (WebCore::JSEventTargetPrototype::classInfo):
154         * bindings/js/JSEventTargetNode.cpp:
155         * bindings/js/JSEventTargetNode.h:
156         (WebCore::JSEventTargetNode::getOwnPropertySlot):
157         (WebCore::JSEventTargetNode::getValueProperty):
158         (WebCore::JSEventTargetNode::put):
159         (WebCore::JSEventTargetNode::putValueProperty):
160         * bindings/js/JSHTMLAllCollection.h:
161         (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
162         (WebCore::JSHTMLAllCollection::toBoolean):
163         * bindings/js/JSHTMLAppletElementCustom.cpp:
164         * bindings/js/JSHTMLCollectionCustom.cpp:
165         * bindings/js/JSHTMLDocumentCustom.cpp:
166         * bindings/js/JSHTMLElementCustom.cpp:
167         * bindings/js/JSHTMLEmbedElementCustom.cpp:
168         * bindings/js/JSHTMLFormElementCustom.cpp:
169         * bindings/js/JSHTMLFrameElementCustom.cpp:
170         * bindings/js/JSHTMLFrameSetElementCustom.cpp:
171         * bindings/js/JSHTMLIFrameElementCustom.cpp:
172         * bindings/js/JSHTMLInputElementBase.cpp:
173         (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
174         (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
175         * bindings/js/JSHTMLInputElementBase.h:
176         (WebCore::JSHTMLInputElementBase::classInfo):
177         * bindings/js/JSHTMLObjectElementCustom.cpp:
178         * bindings/js/JSHTMLOptionElementConstructor.cpp:
179         * bindings/js/JSHTMLOptionElementConstructor.h:
180         (WebCore::JSHTMLOptionElementConstructor::classInfo):
181         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
182         * bindings/js/JSHTMLSelectElementCustom.cpp:
183         (WebCore::selectIndexSetter):
184         (WebCore::JSHTMLSelectElement::indexSetter):
185         * bindings/js/JSHTMLSelectElementCustom.h:
186         * bindings/js/JSHistoryCustom.cpp:
187         * bindings/js/JSImageConstructor.cpp:
188         * bindings/js/JSImageConstructor.h:
189         (WebCore::JSImageConstructor::classInfo):
190         * bindings/js/JSInspectedObjectWrapper.cpp:
191         * bindings/js/JSInspectedObjectWrapper.h:
192         (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
193         (WebCore::JSInspectedObjectWrapper::classInfo):
194         * bindings/js/JSInspectorCallbackWrapper.cpp:
195         * bindings/js/JSInspectorCallbackWrapper.h:
196         (WebCore::JSInspectorCallbackWrapper::classInfo):
197         (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
198         * bindings/js/JSJavaScriptCallFrameCustom.cpp:
199         * bindings/js/JSLocationCustom.cpp:
200         * bindings/js/JSMimeTypeArrayCustom.cpp:
201         * bindings/js/JSNSResolver.cpp:
202         * bindings/js/JSNSResolver.h:
203         (WebCore::JSNSResolver::create):
204         * bindings/js/JSNamedNodeMapCustom.cpp:
205         * bindings/js/JSNamedNodesCollection.cpp:
206         (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
207         * bindings/js/JSNamedNodesCollection.h:
208         (WebCore::JSNamedNodesCollection::classInfo):
209         * bindings/js/JSNavigatorCustom.cpp:
210         * bindings/js/JSNodeCustom.cpp:
211         * bindings/js/JSNodeFilterCondition.cpp:
212         (WebCore::JSNodeFilterCondition::acceptNode):
213         * bindings/js/JSNodeFilterCondition.h:
214         (WebCore::JSNodeFilterCondition::create):
215         * bindings/js/JSNodeFilterCustom.cpp:
216         * bindings/js/JSNodeIteratorCustom.cpp:
217         * bindings/js/JSNodeListCustom.cpp:
218         * bindings/js/JSPluginArrayCustom.cpp:
219         * bindings/js/JSPluginCustom.cpp:
220         * bindings/js/JSPluginElementFunctions.cpp:
221         (WebCore::getRuntimeObject):
222         * bindings/js/JSPluginElementFunctions.h:
223         * bindings/js/JSQuarantinedObjectWrapper.cpp:
224         (WebCore::JSQuarantinedObjectWrapper::construct):
225         (WebCore::JSQuarantinedObjectWrapper::call):
226         * bindings/js/JSQuarantinedObjectWrapper.h:
227         (WebCore::JSQuarantinedObjectWrapper::unwrappedObject):
228         (WebCore::JSQuarantinedObjectWrapper::unwrappedGlobalObject):
229         (WebCore::JSQuarantinedObjectWrapper::className):
230         * bindings/js/JSRGBColor.cpp:
231         * bindings/js/JSRGBColor.h:
232         (WebCore::JSRGBColor::classInfo):
233         * bindings/js/JSSQLResultSetRowListCustom.cpp:
234         * bindings/js/JSSQLTransactionCustom.cpp:
235         * bindings/js/JSSVGLazyEventListener.cpp:
236         * bindings/js/JSSVGLazyEventListener.h:
237         * bindings/js/JSSVGLengthCustom.cpp:
238         * bindings/js/JSSVGMatrixCustom.cpp:
239         (WebCore::JSSVGMatrix::inverse):
240         (WebCore::JSSVGMatrix::rotateFromVector):
241         * bindings/js/JSSVGPathSegCustom.cpp:
242         * bindings/js/JSSVGPathSegListCustom.cpp:
243         (WebCore::JSSVGPathSegList::initialize):
244         (WebCore::JSSVGPathSegList::getItem):
245         (WebCore::JSSVGPathSegList::insertItemBefore):
246         (WebCore::JSSVGPathSegList::replaceItem):
247         (WebCore::JSSVGPathSegList::removeItem):
248         (WebCore::JSSVGPathSegList::appendItem):
249         * bindings/js/JSSVGPointListCustom.cpp:
250         * bindings/js/JSSVGTransformListCustom.cpp:
251         * bindings/js/JSStorageCustom.cpp:
252         * bindings/js/JSStyleSheetCustom.cpp:
253         * bindings/js/JSStyleSheetListCustom.cpp:
254         * bindings/js/JSTextCustom.cpp:
255         * bindings/js/JSTreeWalkerCustom.cpp:
256         * bindings/js/JSXMLHttpRequestConstructor.cpp:
257         * bindings/js/JSXMLHttpRequestConstructor.h:
258         (WebCore::JSXMLHttpRequestConstructor::classInfo):
259         * bindings/js/JSXMLHttpRequestCustom.cpp:
260         * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
261         * bindings/js/JSXSLTProcessorConstructor.cpp:
262         * bindings/js/JSXSLTProcessorConstructor.h:
263         (WebCore::JSXSLTProcessorConstructor::classInfo):
264         * bindings/js/JSXSLTProcessorCustom.cpp:
265         * bindings/js/ScheduledAction.cpp:
266         * bindings/js/ScheduledAction.h:
267         * bindings/js/ScriptController.cpp:
268         (WebCore::ScriptController::attachDebugger):
269         (WebCore::ScriptController::windowScriptNPObject):
270         * bindings/js/ScriptController.h:
271         * bindings/js/ScriptControllerGtk.cpp:
272         (WebCore::ScriptController::createScriptInstanceForWidget):
273         * bindings/js/ScriptControllerMac.mm:
274         (WebCore::ScriptController::createScriptInstanceForWidget):
275         (WebCore::ScriptController::windowScriptObject):
276         (WebCore::ScriptController::clearPlatformScriptObjects):
277         (WebCore::updateRenderingForBindings):
278         (WebCore::ScriptController::initJavaJSBindings):
279         * bindings/js/ScriptControllerQt.cpp:
280         (WebCore::ScriptController::createScriptInstanceForWidget):
281         * bindings/js/ScriptControllerWin.cpp:
282         (WebCore::ScriptController::createScriptInstanceForWidget):
283         * bindings/js/ScriptControllerWx.cpp:
284         (WebCore::ScriptController::createScriptInstanceForWidget):
285         * bindings/js/StringSourceProvider.h:
286         (WebCore::StringSourceProvider::getRange):
287         * bindings/objc/DOM.mm:
288         (-[DOMNode JSC::Bindings::]):
289         * bindings/objc/DOMInternal.h:
290         * bindings/objc/DOMInternal.mm:
291         (-[WebScriptObject _initializeScriptDOMNodeImp]):
292         * bindings/objc/DOMUtility.mm:
293         (JSC::createDOMWrapper):
294         (WebCore::createDOMWrapper):
295         * bindings/objc/WebScriptObject.mm:
296         (WebCore::createJSWrapper):
297         (-[WebScriptObject _initWithJSObject:JSC::originRootObject:JSC::Bindings::rootObject:JSC::Bindings::]):
298         * bindings/objc/WebScriptObjectPrivate.h:
299         * bindings/scripts/CodeGeneratorJS.pm:
300         * bridge/NP_jsobject.cpp:
301         * bridge/NP_jsobject.h:
302         * bridge/c/c_class.cpp:
303         * bridge/c/c_class.h:
304         * bridge/c/c_instance.cpp:
305         * bridge/c/c_instance.h:
306         * bridge/c/c_runtime.cpp:
307         * bridge/c/c_runtime.h:
308         * bridge/c/c_utility.cpp:
309         * bridge/c/c_utility.h:
310         * bridge/jni/jni_class.cpp:
311         * bridge/jni/jni_class.h:
312         * bridge/jni/jni_instance.cpp:
313         * bridge/jni/jni_instance.h:
314         * bridge/jni/jni_jsobject.h:
315         * bridge/jni/jni_jsobject.mm:
316         (JavaJSObject::call):
317         (JavaJSObject::convertJObjectToValue):
318         * bridge/jni/jni_objc.mm:
319         (JSC::Bindings::dispatchJNICall):
320         * bridge/jni/jni_runtime.cpp:
321         * bridge/jni/jni_runtime.h:
322         * bridge/jni/jni_utility.cpp:
323         * bridge/jni/jni_utility.h:
324         * bridge/npruntime.cpp:
325         (_NPN_GetStringIdentifier):
326         * bridge/objc/WebScriptObject.h:
327         * bridge/objc/objc_class.h:
328         * bridge/objc/objc_class.mm:
329         * bridge/objc/objc_instance.h:
330         * bridge/objc/objc_instance.mm:
331         * bridge/objc/objc_runtime.h:
332         * bridge/objc/objc_runtime.mm:
333         * bridge/objc/objc_utility.h:
334         * bridge/objc/objc_utility.mm:
335         * bridge/qt/qt_class.cpp:
336         * bridge/qt/qt_class.h:
337         * bridge/qt/qt_instance.cpp:
338         * bridge/qt/qt_instance.h:
339         * bridge/qt/qt_runtime.cpp:
340         (JSC::Bindings::convertQVariantToValue):
341         (JSC::Bindings::):
342         * bridge/qt/qt_runtime.h:
343         * bridge/runtime.cpp:
344         * bridge/runtime.h:
345         * bridge/runtime_array.cpp:
346         * bridge/runtime_array.h:
347         * bridge/runtime_method.cpp:
348         * bridge/runtime_method.h:
349         * bridge/runtime_object.cpp:
350         * bridge/runtime_object.h:
351         * bridge/runtime_root.cpp:
352         (JSC::Bindings::RootObject::invalidate):
353         (JSC::Bindings::RootObject::gcProtect):
354         (JSC::Bindings::RootObject::gcUnprotect):
355         * bridge/runtime_root.h:
356         * bridge/testbindings.cpp:
357         * bridge/testbindings.mm:
358         * bridge/testqtbindings.cpp:
359         * dom/Document.cpp:
360         (WebCore::Document::~Document):
361         * dom/NSResolver.h:
362         * dom/Node.cpp:
363         (WebCore::Node::setDocument):
364         (WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
365         (WebCore::resolveNamespacesForSelector):
366         (WebCore::Node::querySelector):
367         (WebCore::Node::querySelectorAll):
368         * dom/Node.h:
369         * dom/NodeFilter.cpp:
370         * dom/NodeFilter.h:
371         * dom/NodeFilterCondition.cpp:
372         * dom/NodeFilterCondition.h:
373         * dom/NodeIterator.cpp:
374         * dom/NodeIterator.h:
375         * dom/Traversal.cpp:
376         * dom/Traversal.h:
377         * dom/TreeWalker.cpp:
378         * dom/TreeWalker.h:
379         * dom/make_names.pl:
380         * history/CachedPage.cpp:
381         * history/CachedPage.h:
382         * html/HTMLPlugInElement.cpp:
383         (WebCore::HTMLPlugInElement::getInstance):
384         * html/HTMLPlugInElement.h:
385         * loader/FrameLoader.cpp:
386         * loader/FrameLoader.h:
387         * loader/icon/IconDatabase.cpp:
388         (WebCore::iconDatabase):
389         * page/Console.cpp:
390         * page/Console.h:
391         * page/InspectorController.cpp:
392         (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
393         (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
394         (WebCore::InspectorResource::setXMLHttpRequestProperties):
395         (WebCore::InspectorResource::sourceString):
396         (WebCore::getResourceDocumentNode):
397         (WebCore::search):
398         (WebCore::InspectorController::focusNode):
399         (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
400         (WebCore::InspectorController::addDatabaseScriptResource):
401         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
402         * page/InspectorController.h:
403         (WebCore::InspectorController::profiles):
404         * page/JavaScriptCallFrame.cpp:
405         (WebCore::JavaScriptCallFrame::scopeChain):
406         * page/JavaScriptCallFrame.h:
407         (WebCore::JavaScriptCallFrame::create):
408         (WebCore::JavaScriptCallFrame::update):
409         * page/JavaScriptDebugListener.h:
410         * page/JavaScriptDebugServer.cpp:
411         (WebCore::dispatchDidParseSource):
412         * page/JavaScriptDebugServer.h:
413         * page/JavaScriptProfile.cpp:
414         * page/JavaScriptProfile.h:
415         * page/JavaScriptProfileNode.cpp:
416         (WebCore::getTotalTime):
417         (WebCore::getSelfTime):
418         (WebCore::getTotalPercent):
419         (WebCore::getSelfPercent):
420         (WebCore::getNumberOfCalls):
421         (WebCore::getChildren):
422         (WebCore::getVisible):
423         * page/JavaScriptProfileNode.h:
424         * page/Page.cpp:
425         (WebCore::Page::setDebuggerForAllPages):
426         (WebCore::Page::setDebugger):
427         * page/Page.h:
428         (WebCore::Page::debugger):
429         * page/mac/FrameMac.mm:
430         * platform/KURL.h:
431         (WebCore::KURL::operator JSC::UString):
432         * platform/text/AtomicString.cpp:
433         (WebCore::AtomicString::add):
434         (WebCore::AtomicString::find):
435         * platform/text/AtomicString.h:
436         (WebCore::AtomicString::AtomicString):
437         * platform/text/PlatformString.h:
438         * platform/text/String.cpp:
439         (WebCore::charactersToDouble):
440         * platform/win/BString.cpp:
441         * platform/win/BString.h:
442         * plugins/MimeTypeArray.h:
443         * plugins/Plugin.h:
444         * plugins/PluginArray.h:
445         * plugins/PluginView.cpp:
446         (WebCore::PluginView::start):
447         (WebCore::PluginView::performRequest):
448         (WebCore::PluginView::bindingInstance):
449         * plugins/PluginView.h:
450         * plugins/gtk/PluginViewGtk.cpp:
451         (WebCore::PluginView::paint):
452         (WebCore::PluginView::handleKeyboardEvent):
453         (WebCore::PluginView::handleMouseEvent):
454         (WebCore::PluginView::setNPWindowRect):
455         (WebCore::PluginView::stop):
456         (WebCore::PluginView::init):
457         * plugins/qt/PluginViewQt.cpp:
458         (WebCore::PluginView::setNPWindowRect):
459         (WebCore::PluginView::stop):
460         (WebCore::PluginView::init):
461         * plugins/win/PluginViewWin.cpp:
462         (WebCore::PluginView::dispatchNPEvent):
463         (WebCore::PluginView::handleKeyboardEvent):
464         (WebCore::PluginView::handleMouseEvent):
465         (WebCore::PluginView::setNPWindowRect):
466         (WebCore::PluginView::stop):
467         * storage/Database.cpp:
468         (WebCore::Database::Database):
469         * xml/XMLHttpRequest.cpp:
470         (WebCore::XMLHttpRequest::responseText):
471         (WebCore::XMLHttpRequest::loadRequestAsynchronously):
472         (WebCore::XMLHttpRequest::clearResponse):
473         (WebCore::XMLHttpRequest::dropProtection):
474         (WebCore::XMLHttpRequest::didFinishLoading):
475         (WebCore::XMLHttpRequest::didReceiveData):
476         * xml/XMLHttpRequest.h:
477
478 2008-09-07  Adam Barth  <abarth@webkit.org>
479
480         Reviewed by Sam Weinig.
481
482         Adopt opener restriction on frame navigation.
483           https://bugs.webkit.org/show_bug.cgi?id=20642
484
485         This restriction helps prevent an attacker from navigating top-level
486         windows that were created by another web site.
487
488         Tests: http/tests/security/frameNavigation/not-opener.html
489                http/tests/security/frameNavigation/opener.html
490
491         * loader/FrameLoader.cpp:
492         (WebCore::canAccessAncestor):
493         (WebCore::FrameLoader::shouldAllowNavigation):
494
495 2008-09-07  Dan Bernstein  <mitz@apple.com>
496
497         Reviewed by Maciej Stachowiak.
498
499         - use the correct sign for vertical offsets of combining marks
500
501         * platform/graphics/win/UniscribeController.cpp:
502         (WebCore::UniscribeController::shapeAndPlaceItem):
503
504 2008-09-07  Dan Bernstein  <mitz@apple.com>
505
506         Reviewed by Dave Hyatt.
507
508         - add the combining mark offsets in two places where I forgot them
509
510         * platform/graphics/win/FontCGWin.cpp:
511         (WebCore::Font::drawGlyphs):
512
513 2008-09-07  Dan Bernstein  <mitz@apple.com>
514
515         Reviewed by Dave Hyatt.
516
517         - correct glyph advances in complex text using web fonts rendered with
518           Core Graphics
519
520         * platform/graphics/win/FontCustomPlatformData.cpp:
521         (WebCore::FontCustomPlatformData::fontPlatformData):
522
523 2008-09-07  Keishi Hattori  <casey.hattori@gmail.com>
524
525         Adds console.dirxml support to the Web Inspector.
526
527         https://bugs.webkit.org/show_bug.cgi?id=19156
528
529         Reviewed by Timothy Hatcher.
530
531         * WebCore.vcproj/WebCore.vcproj: Added ElementsTreeOutline.js.
532         * bindings/js/JSConsoleCustom.cpp:
533         (WebCore::JSConsole::dirxml):
534         * page/Console.cpp:
535         (WebCore::Console::dirxml): Adds a ConsoleMessage with NodeMessageLevel.
536         * page/Console.h:
537         (WebCore::): Added NodeMessageLevel.
538         * page/Console.idl: Added console.dirxml.
539         * page/inspector/Console.js: A NodeMessage creates a ElementsTreeOutline.
540         * page/inspector/ElementsPanel.js: Modified to use ElementsTreeOutline. The ElementsTreeOutline 
541         in the ElementsPanel has includeRootDOMNode and selectEnabled set to true.
542         * page/inspector/ElementsTreeOutline.js: Added.
543         (WebInspector.ElementsTreeOutline): A subclass of TreeOutline for displaying a DOM node tree.
544         (WebInspector.ElementsTreeElement): A subclass of TreeElement for ElementsTreeOutline.
545         * page/inspector/WebKit.qrc: Added ElementsTreeOutline.js.
546         * page/inspector/inspector.css:
547         * page/inspector/inspector.html: Added ElementsTreeOutline.js.
548         * page/inspector/inspector.js: Moved hover related methods to WebInspector.
549         (WebInspector.altKeyDown):
550         (WebInspector.forceHoverHighlight):
551         (WebInspector.hoveredDOMNode):
552         (WebInspector._updateHoverHighlightSoon):
553         (WebInspector._updateHoverHighlight):
554         (WebInspector.documentKeyDown): Updates WebInspector.altKeyDown
555         (WebInspector.documentKeyUp): Updates WebInspector.altKeyDown
556         * page/inspector/utilities.js: Added getDocumentForNode, parentNodeOrFrameElement,
557         isAncestorIncludingParentFrames.
558
559 2008-09-06  Mark Rowe  <mrowe@apple.com>
560
561         Qt build fix.
562
563         * bridge/qt/qt_runtime.cpp:
564         (KJS::Bindings::convertQVariantToValue):
565
566 === End merge of squirrelfish-extreme ===
567
568 2008-09-05  Oliver Hunt  <oliver@apple.com>
569
570         Start bringing up SFX on windows.
571
572         Reviewed by Mark Rowe and Sam Weinig
573
574         Start doing the work to bring up SFX on windows.  Initially
575         just working on WREC, as it does not make any calls so reduces
576         the amount of code that needs to be corrected.
577
578         Add forwarding headers
579
580         * ChangeLog:
581         * ForwardingHeaders/masm/MacroAssembler.h: Added.
582         * WebCore.vcproj/WebCore.vcproj:
583
584 2008-08-27  Mark Rowe  <mrowe@apple.com>
585
586         Reviewed by Oliver Hunt.
587
588         Fix the build of the full WebKit stack.
589
590         Add forwarding headers.
591
592         * ForwardingHeaders/masm/IA32MacroAsm.h: Added.
593         * ForwardingHeaders/wrec/WREC.h: Added.
594
595 === Start merge of squirrelfish-extreme ===
596
597 2008-09-06  Antti Koivisto  <antti@apple.com>
598
599         Reviewed by Dave Hyatt.
600
601         <rdar://problem/6187043> 
602         Don't parse full HTML user agent style sheet unless it is actually needed
603         <rdar://problem/6131889> 
604         WebView is significantly more expensive to create recently
605         
606         Parsing the html4.css takes significant amount of time and memory (~50kb) on application
607         startup. Some clients may never use most of the rules.
608         
609         With this patch we use simplified UA stylesheet until we hit something it can't handle. 
610         This avoids full stylesheet parsing on application startup (due to empty document construction)
611         and also makes it possible for clients with very simple demands (divs and spans only) never to load 
612         the full style.
613         
614         It also delays view source style parsing until it is used.
615
616         * css/CSSStyleSelector.cpp:
617         (WebCore::elementCanUseSimpleDefaultStyle):
618         (WebCore::CSSStyleSelector::CSSStyleSelector):
619         (WebCore::loadFullDefaultStyle):
620         (WebCore::loadSimpleDefaultStyle):
621         (WebCore::loadViewSourceStyle):
622         (WebCore::CSSStyleSelector::matchUARules):
623         (WebCore::CSSStyleSelector::styleForElement):
624
625 2008-09-06  Kevin Ollivier  <kevino@theolliviers.com>
626
627         wx build fix.
628
629         * WebCoreSources.bkl:
630
631 2008-09-06  Antti Koivisto  <antti@apple.com>
632
633         Reverting r35953 which was causing problems on Windows which relies on
634         WebCore timers in nested event loops. r36132 did alternative fix.
635
636         * page/Chrome.cpp:
637         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
638         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
639
640 2008-09-06  Antti Koivisto  <antti@apple.com>
641
642         Reviewed by Dan Bernstein.
643
644         Fix <rdar://problem/6201644>
645         https://bugs.webkit.org/show_bug.cgi?id=20493
646         Crash after OK in dialog box and reloading page in secure mode
647         
648         Limited loader only fix since the general timer fix is causing problems on Windows.
649
650         * loader/loader.cpp:
651         (WebCore::Loader::servePendingRequests):
652         (WebCore::Loader::Host::Host):
653         (WebCore::Loader::Host::didFinishLoading):
654         (WebCore::Loader::Host::didFail):
655         (WebCore::Loader::Host::didReceiveData):
656         * loader/loader.h:
657         (WebCore::Loader::Host::processingResource):
658
659 2008-09-06  Dan Bernstein  <mitz@apple.com>
660
661         Reviewed by Dave Hyatt.
662
663         The initial Core Text adoption prototype was made by Daniel Fenwick.
664
665         - <rdar://problem/5158514> Add a Core Text-based complex text code path
666
667         Currently the Core Text code path is not used in any configuration.
668
669         * WebCore.xcodeproj/project.pbxproj: Added files.
670         * config.h: Defined WTF_USE_ATSUI and WTF_USE_CORE_TEXT.
671         * platform/graphics/Font.cpp:
672         (WebCore::WidthIterator::advance): Moved the spacingDisabled() test out
673         of the loop.
674         * platform/graphics/GlyphBuffer.h:
675         (WebCore::GlyphBuffer::add): Added this version that takes an advance.
676         * platform/graphics/SimpleFontData.h: Added ATSUI and CORE_TEXT #ifdefs.
677         Added getCTFont() and getCFStringAttributes() and corresponding data
678         members for Core Text.
679         * platform/graphics/mac/CoreTextController.cpp: Added.
680         (WebCore::roundCGFloat): Helper function.
681         (WebCore::ceilCGFloat): Helper function.
682         (WebCore::CoreTextController::CoreTextRun::CoreTextRun):
683         (WebCore::CoreTextController::CoreTextController):
684         (WebCore::CoreTextController::offsetForPosition):
685         (WebCore::CoreTextController::collectCoreTextRuns): Added. Segments the
686         run into subruns as necessary such that each subrun can be rendered with
687         a single font. Also separates out soft hyphens and replaces them with
688         real hyphens, because Core Text does not emit a glyph for soft hyphens.
689         Then calls collectCoreTextRunsForCharacters() on each subrun.
690         (WebCore::CoreTextController::advance):
691         (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Creates
692         a CTLine from the given subrun and collects its CoreTextRuns.
693         (WebCore::CoreTextController::adjustGlyphsAndAdvances): Applies the
694         rounding hacks, letter- and word-spacing and glyph substitutions and
695         stores the resulting adjusted glyphs and advances.
696         * platform/graphics/mac/CoreTextController.h: Copied from WebCore/platform/graphics/win/UniscribeController.h.
697         (WebCore::CoreTextController::totalWidth):
698         (WebCore::CoreTextController::finalRoundingWidth):
699         (WebCore::CoreTextController::CoreTextRun::ctRun):
700         (WebCore::CoreTextController::CoreTextRun::glyphCount):
701         (WebCore::CoreTextController::CoreTextRun::fontData):
702         (WebCore::CoreTextController::CoreTextRun::characters):
703         (WebCore::CoreTextController::CoreTextRun::stringLocation):
704         (WebCore::CoreTextController::CoreTextRun::stringLength):
705         (WebCore::CoreTextController::CoreTextRun::indexAt):
706         * platform/graphics/mac/FontMac.mm: Moved the ATSUI-specific parts to
707         FontMacATSUI.mm.
708         * platform/graphics/mac/FontMacATSUI.mm: Copied from WebCore/platform/graphics/mac/FontMac.mm.
709         (WebCore::disableLigatures): Changed to call
710         FontPlatformData::allowsLigatures().
711         (WebCore::overrideLayoutOperation): Changed to call
712         FontPlatformData::roundsGlyphAdvances().
713         * platform/graphics/mac/FontMacCoreText.cpp: Copied from WebCore/platform/graphics/win/FontWin.cpp.
714         (WebCore::Font::selectionRectForComplexText): Changed to use
715         totalWidth() instead of advancing to the end and using runWidthSoFar().
716         (WebCore::Font::drawComplexText):
717         (WebCore::Font::floatWidthForComplexText): Ditto.
718         (WebCore::Font::offsetForPositionForComplexText):
719         * platform/graphics/mac/FontPlatformData.h:
720         * platform/graphics/mac/FontPlatformDataMac.mm:
721         (WebCore::FontPlatformData::setFont):
722         (WebCore::FontPlatformData::roundsGlyphAdvances): Added. Checks the
723         AppKit rendering mode.
724         (WebCore::FontPlatformData::allowsLigatures): Added. Implements the
725         heuristic that allows ligatures in fonts that do not have a glyph for
726         'a', based on the assumption that such fonts are only used in complex
727         text.
728         * platform/graphics/mac/SimpleFontDataMac.mm:
729         (WebCore::SimpleFontData::platformInit):
730         (WebCore::SimpleFontData::platformDestroy):
731         (WebCore::SimpleFontData::getCTFont): Added.
732         (WebCore::SimpleFontData::getCFStringAttributes): Added. Caches and
733         returns an attributes dictionary.
734         * platform/text/mac/ShapeArabic.c: Added ATSUI #ifdefs.
735         * platform/text/mac/ShapeArabic.h: Ditto.
736
737 2008-09-06  Dan Bernstein  <mitz@apple.com>
738
739         Reviewed by Dave Hyatt.
740
741         - make combining mark offsets work in CG text on Windows
742
743         * platform/graphics/win/FontCGWin.cpp:
744         (WebCore::Font::drawGlyphs): The old code tried to translate the text
745         matrix, but failed for two reasons: it did not actually change the
746         matrix, and even if it did, CGContextSetTextPosition overwrites the
747         translation values in the text matrix. Instead, just added the
748         translation to the anchor point.
749
750 2008-09-05  Gustavo Noronha Silva  <gns@gnome.org>
751
752         Reviewed by Alp Toker.
753
754         https://bugs.webkit.org/show_bug.cgi?id=18346
755         [GTK] Remove build warnings
756
757         Applied some casts, and removed an unused typedef to make the
758         compiler happy, printing less warnings when building.
759
760         * page/gtk/AccessibilityObjectWrapperAtk.cpp:
761         * platform/graphics/gtk/SimpleFontDataPango.cpp:
762         (WebCore::SimpleFontData::containsCharacters):
763         * platform/graphics/gtk/VideoSinkGStreamer.cpp:
764         (webkit_video_sink_set_caps):
765         * platform/network/soup/ResourceHandleSoup.cpp:
766
767 2008-09-05  Eric Seidel  <eric@webkit.org>
768
769         Reviewed by Adam Roben.
770
771         Build fix for WebKitWin and Chromium
772
773         * platform/FileSystem.h:
774
775 2008-09-05  Eric Seidel  <eric@webkit.org>
776
777         Reviewed by Darin Adler.
778
779         Try to make Chromium compile with ToT:
780         - Wrap a few places which depend on KJS:: in #if USE(JSC)
781         - Include some windows forward declarations
782
783         * dom/Node.h:
784         * page/Console.h:
785         * page/animation/CompositeAnimation.h:
786         * platform/FileSystem.h:
787         * platform/graphics/Image.h:
788         * platform/text/AtomicString.h:
789         * platform/text/String.cpp:
790         * rendering/style/RenderStyle.h:
791
792 2008-09-05  Dave Hyatt  <hyatt@apple.com>
793
794         Add support for runtime switchability of the Aqua look and the native look on Windows.
795         Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
796
797         Reviewed by Adam Roben
798
799         * WebCore.vcproj/WebCore.vcproj:
800         * page/Settings.cpp:
801         (WebCore::Settings::setShouldPaintNativeControls):
802         * page/Settings.h:
803         (WebCore::Settings::shouldPaintNativeControls):
804         * rendering/RenderThemeSafari.cpp:
805         (WebCore::theme):
806         * rendering/RenderThemeWin.cpp:
807
808 2008-09-05  Antti Koivisto  <antti@apple.com>
809
810         Qt build fix.
811
812         * svg/SVGFEImageElement.cpp:
813         (WebCore::SVGFEImageElement::build):
814
815 2008-09-05  Dirk Schulze  <vbs85@gmx.de>
816
817         Gtk build fix
818
819         * GNUmakefile.am:
820
821 2008-09-05  Antti Koivisto  <antti@apple.com>
822
823         Another build fix.
824
825         * svg/SVGFEImageElement.cpp:
826         (WebCore::SVGFEImageElement::notifyFinished):
827
828 2008-09-05  Antti Koivisto  <antti@apple.com>
829
830         Build fixes.
831         
832         * WebCore.xcodeproj/project.pbxproj:
833         * svg/graphics/filters/SVGFEImage.cpp:
834         (WebCore::FEImage::cachedImage):
835
836 2008-09-05  Antti Koivisto  <antti@apple.com>
837
838         Reviewed by Darin Adler.
839
840         Most of the implementation for https://bugs.webkit.org/show_bug.cgi?id=17998
841         When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"
842
843         Implement HTTP 1.1 "Specific end-to-end revalidation" for WebCore memory cache. This patch does
844         not yet enable it for the biggest use case, reloading. However it is good for general browsing as
845         well. Doing this in WebCore level as opposed to relying on disk cache has big benefit that
846         we avoid re-decoding resources, especially images. 
847         
848         To be exact the enabled case is not actually the "Specific end-to-end revalidation" since it does not include
849         CacheControl: max-age=0 header. That would be added in reload case.
850         
851         The approach for revalidation is to kick the original resource out from the memory cache
852         and create a new CachedResource that represents the revalidation request. In case
853         we get 304 back for the request we put the original resource back to the cache, update 
854         its expiration date and switch the clients registered to revalidation resource to be
855         clients of the original resource.
856         
857         All heap allocated CachedImage pointers now use CachedResourceHandle<CachedImage> (and so on) instead.
858         This allows updating the handles to point to the original resource when the revalidation succeeds. It
859         also acts as refcounting smart pointer.
860
861         * WebCore.pro:
862         * WebCore.vcproj/WebCore.vcproj:
863         * WebCore.xcodeproj/project.pbxproj:
864         * css/CSSFontFaceSource.h:
865         * css/CSSImportRule.h:
866         * dom/Clipboard.h:
867         (WebCore::Clipboard::dragImage):
868         * dom/ProcessingInstruction.h:
869         * dom/ScriptElement.h:
870         * dom/XMLTokenizer.cpp:
871         (WebCore::XMLTokenizer::isWaitingForScripts):
872         * dom/XMLTokenizer.h:
873         * html/HTMLImageLoader.cpp:
874         (WebCore::HTMLImageLoader::setImage):
875         (WebCore::HTMLImageLoader::updateFromElement):
876         (WebCore::HTMLImageLoader::notifyFinished):
877         * html/HTMLImageLoader.h:
878         (WebCore::HTMLImageLoader::image):
879         * html/HTMLLinkElement.h:
880         * html/HTMLTokenizer.cpp:
881         (WebCore::HTMLTokenizer::reset):
882         (WebCore::HTMLTokenizer::scriptHandler):
883         (WebCore::HTMLTokenizer::notifyFinished):
884         * html/HTMLTokenizer.h:
885         * loader/Cache.cpp:
886         (WebCore::Cache::revalidateResource):
887         (WebCore::Cache::revalidationSucceeded):
888         (WebCore::Cache::revalidationFailed):
889         * loader/Cache.h:
890         * loader/CachedResource.cpp:
891         (WebCore::CachedResource::CachedResource):
892         (WebCore::CachedResource::~CachedResource):
893         (WebCore::CachedResource::isExpired):
894         (WebCore::CachedResource::setResponse):
895         (WebCore::CachedResource::deleteIfPossible):
896         (WebCore::CachedResource::setResourceToRevalidate):
897         (WebCore::CachedResource::clearResourceToRevalidate):
898         (WebCore::CachedResource::switchClientsToRevalidatedResource):
899         (WebCore::CachedResource::canUseCacheValidator):
900         (WebCore::CachedResource::mustRevalidate):
901         * loader/CachedResource.h:
902         (WebCore::CachedResource::canDelete):
903         (WebCore::CachedResource::registerHandle):
904         (WebCore::CachedResource::unregisterHandle):
905         (WebCore::CachedResource::isCacheValidator):
906         (WebCore::CachedResource::resourceToRevalidate):
907         (WebCore::CachedResource::setExpirationDate):
908         * loader/CachedResourceHandle.cpp: Added.
909         (WebCore::CachedResourceHandleBase::setResource):
910         * loader/CachedResourceHandle.h: Added.
911         (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
912         (WebCore::CachedResourceHandleBase::get):
913         (WebCore::CachedResourceHandleBase::operator!):
914         (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
915         (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
916         (WebCore::CachedResourceHandleBase::operator=):
917         (WebCore::CachedResourceHandle::CachedResourceHandle):
918         (WebCore::CachedResourceHandle::get):
919         (WebCore::CachedResourceHandle::operator->):
920         (WebCore::CachedResourceHandle::operator=):
921         (WebCore::CachedResourceHandle::operator==):
922         (WebCore::CachedResourceHandle::operator!=):
923         (WebCore::operator==):
924         (WebCore::operator!=):
925         * loader/DocLoader.cpp:
926         (WebCore::DocLoader::checkForReload):
927         * loader/UserStyleSheetLoader.h:
928         * loader/loader.cpp:
929         (WebCore::Loader::Host::servePendingRequests):
930         (WebCore::Loader::Host::didFinishLoading):
931         (WebCore::Loader::Host::didFail):
932         (WebCore::Loader::Host::didReceiveResponse):
933         (WebCore::Loader::Host::didReceiveData):
934         * page/EventHandler.cpp:
935         (WebCore::EventHandler::selectCursor):
936         * rendering/RenderImage.cpp:
937         (WebCore::RenderImage::setCachedImage):
938         (WebCore::RenderImage::imageChanged):
939         * rendering/RenderImage.h:
940         (WebCore::RenderImage::cachedImage):
941         (WebCore::RenderImage::imagePtr):
942         * rendering/style/RenderStyle.h:
943         * rendering/style/StyleCachedImage.h:
944         (WebCore::StyleCachedImage::data):
945         (WebCore::StyleCachedImage::cachedImage):
946         * svg/SVGFEImageElement.h:
947         * svg/graphics/filters/SVGFEImage.h:
948         * xml/XSLImportRule.h:
949
950 2008-09-04  Brady Eidson  <beidson@apple.com>
951
952         Reviewed by Mitz
953
954         <rdar://problem/6180236> - Safari times out connections after 1 or 2 minutes
955
956         A 60-second default timeout was added in http://trac.webkit.org/changeset/17144 in an attempt 
957         to model default NSURLRequest behavior in a cross-platform manner.  
958
959         Sadly by always enforcing this 60 second timeout, WebCore was stomping over the wishes of any Webkit 
960         client that wished to enforce a much larger default timeout using NSURLRequest API.
961
962         Additionally, upon reviewing what all other browsers do, it seems apparent that "no limit" is desirable
963         behavior on the web and this restores previous Safari/WebKit behavior.
964
965         It would be easy to write a layout test for this, but to be effective it would have
966         to run for at least 61 seconds, which seems insane until will can parallelize run-webkit-tests
967
968         * manual-tests/timeout-test.html: Added.
969         * manual-tests/timeout-test.php: Added.
970
971         * platform/network/ResourceRequestBase.h:
972         (WebCore::ResourceRequestBase::ResourceRequestBase):  Rename the constant to "unspecifiedTimeoutInterval"
973           and make it UINT_MAX so platforms that do set it have an effective "no timeout."  (Windows, for example)
974         * platform/network/mac/ResourceRequestMac.mm:
975         (WebCore::ResourceRequest::doUpdatePlatformRequest):  If the timeout for this request is 
976           "unspecifiedTimeoutInterval", then don't bother setting the timeout using NSURLRequest API, allowing
977           WebKit applications to enforce their own default timeout.
978
979 2008-09-04  Dan Bernstein  <mitz@apple.com>
980
981         Reviewed by Beth Dakin.
982
983         - fix <rdar://problem/6198514> Changing a button's opacity triggers relayout
984
985         Test: fast/repaint/button-spurious-layout-hint.html
986
987         * rendering/RenderButton.cpp:
988         (WebCore::RenderButton::setStyle): Reset the inner block's style box
989         flex to 0 to avoid getting a spurious layout hint. 
990
991 2008-09-04  Kevin Ollivier  <kevino@theolliviers.com>
992
993         wx build fixes.
994
995         * WebCoreSources.bkl:
996         * bindings/js/ScriptControllerWx.cpp: Added.
997         (WebCore::ScriptController::createScriptInstanceForWidget):
998         * page/wx/AccessibilityObjectWx.cpp: Added.
999         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
1000         * platform/graphics/wx/GraphicsContextWx.cpp:
1001         * webcore-base.bkl:
1002         * webcore-wx.bkl:
1003
1004 2008-09-04  Dan Bernstein  <mitz@apple.com>
1005
1006         Reviewed by Mark Rowe.
1007
1008         - roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail,
1009           and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to
1010           require a different approach
1011
1012         * css/CSSGrammar.y:
1013
1014 2008-09-04  Mark Rowe  <mrowe@apple.com>
1015
1016         Reviewed by Eric Seidel.
1017
1018         Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
1019         Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
1020
1021         * Configurations/WebCore.xcconfig: Remove ENABLE_DASHBOARD_SUPPORT from FEATURE_DEFINES.
1022         * DerivedSources.make: Revert to checking for ENABLE_DASHBOARD_SUPPORT rather than looking
1023         for ENABLE_DASHBOARD_SUPPORT in FEATURE_DEFINES.
1024
1025 2008-09-04  Mark Rowe  <mrowe@apple.com>
1026
1027         Mac build fix.
1028
1029         * config.h: Only check the value of HAVE_CONFIG_H if it is defined.
1030
1031 2008-09-04  Eric Seidel  <eric@webkit.org>
1032
1033         Build fix only, no review.
1034
1035         * dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere).
1036
1037 2008-09-04  Marco Barisione  <marco.barisione@collabora.co.uk>
1038
1039         Reviewed by Eric Seidel.
1040
1041         http://bugs.webkit.org/show_bug.cgi?id=20380
1042         [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h
1043
1044         * config.h: Include the configuration header generated by autotools if
1045         available.
1046
1047 2008-09-04  Dan Bernstein  <mitz@apple.com>
1048
1049         Rubber-stamped by Dave Hyatt.
1050
1051         - rename CachedResource::allReferencesRemoved() to allClientsRemoved()
1052
1053         * loader/CachedFont.cpp:
1054         (WebCore::CachedFont::allClientsRemoved):
1055         * loader/CachedFont.h:
1056         * loader/CachedImage.cpp:
1057         (WebCore::CachedImage::allClientsRemoved):
1058         * loader/CachedImage.h:
1059         * loader/CachedResource.cpp:
1060         (WebCore::CachedResource::removeClient):
1061         * loader/CachedResource.h:
1062         (WebCore::CachedResource::allClientsRemoved):
1063
1064 2008-09-04  Adam Roben  <aroben@apple.com>
1065
1066         Windows build fix after r36071
1067
1068         We were getting these errors:
1069
1070         error C2356: initialization segment must not change during translation
1071         unit
1072
1073         This was happening because multiple files #included by
1074         DerivedSources.cpp were themselves #including StaticConstructors.h. I
1075         fixed the error by adding header guards to StaticConstructors.h so its
1076         contents will only be included once.
1077
1078         But it's also not a good idea for StaticConstructors.h to end up in
1079         DerivedSources.cpp, since it ends up "polluting" all the source files
1080         we have in there. So I removed all the files that include
1081         StaticConstructors.h and added some preprocessor directives to
1082         DerivedSources.cpp to catch this error in the future.
1083
1084         * DerivedSources.cpp: Removed the *Names.cpp files, which include
1085         StaticConstructors.h, and added some preprocessor directives to make
1086         sure we don't end up accidentally including StaticConstructors.h in
1087         the future.
1088         * WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files.
1089         * platform/StaticConstructors.h: Added header guards.
1090
1091 2008-09-04  Adam Roben  <aroben@apple.com>
1092
1093         Windows build fix
1094
1095         * platform/graphics/win/FontPlatformData.h: Added a missing #include
1096         of PassRefPtr.h, and corrected the capitalization of RefCounted.h.
1097         * platform/text/PlatformString.h: Added a missing #include of
1098         PassRefPtr.h.
1099
1100 2008-09-04  Tor Arne Vestbø  <tavestbo@trolltech.com>
1101
1102         Reviewed by Simon.
1103
1104         Fix the QtWebKit build to match changes in r36016
1105
1106         * WebCore.pro:
1107         * bridge/qt/qt_instance.cpp:
1108         (KJS::Bindings::QtInstance::getRuntimeObject):
1109         * bridge/qt/qt_runtime.cpp:
1110         (KJS::Bindings::convertQVariantToValue):
1111         (KJS::Bindings::QtConnectionObject::execute):
1112
1113 2008-09-04  Tor Arne Vestbø  <tavestbo@trolltech.com>
1114
1115         Reviewed by Simon.
1116
1117         Re-enable support for user stylesheets in QtWebKit
1118         
1119         QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET
1120         code path, which allows us to keep API support for
1121         loading user style sheets from remote URLs.
1122         
1123         As part of the change UserStyleSheetLoader.cpp/h was
1124         moved from WebCore/loader/mac to WebCore/loader.
1125
1126         * WebCore.pro:
1127         * WebCore.xcodeproj/project.pbxproj:
1128         * dom/Document.h:
1129         * loader/UserStyleSheetLoader.cpp: Renamed from WebCore/loader/mac/UserStyleSheetLoader.cpp.
1130         (UserStyleSheetLoader::UserStyleSheetLoader):
1131         (UserStyleSheetLoader::~UserStyleSheetLoader):
1132         * loader/UserStyleSheetLoader.h: Renamed from WebCore/loader/mac/UserStyleSheetLoader.h.
1133         * page/qt/FrameQt.cpp:
1134         (WebCore::Frame::setUserStyleSheetLocation):
1135         (WebCore::Frame::setUserStyleSheet):
1136
1137 2008-09-04  Alp Toker  <alp@nuanti.com>
1138
1139         Reviewed by Eric.
1140
1141         Remove left-over QT and CAIRO platform checks.
1142
1143         * html/CanvasRenderingContext2D.cpp:
1144
1145 2008-09-04  Eric Seidel  <eric@webkit.org>
1146
1147         Reviewed by Mark Rowe.
1148
1149         Fix leak of TextMetrics due to over-ref as see on buildbot.
1150
1151         * html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now.
1152
1153 2008-09-04  Dan Bernstein  <mitz@apple.com>
1154
1155         Reviewed by Dave Hyatt.
1156
1157         - fix https://bugs.webkit.org/show_bug.cgi?id=19717
1158           <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist
1159
1160         * rendering/RenderBlock.cpp:
1161         (WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
1162         positioned movement only case, call
1163         tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
1164         layout if that fails.
1165         (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
1166         * rendering/RenderBox.h:
1167         (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
1168         layoutDoingPositionedMovementOnly to this, and made this function
1169         check if the width changed. If it did, return, leaving the object
1170         dirty. The caller can then call layout(). The width can change even
1171         in the "positioned movement only" case if the object is shrink-to-fit
1172         and the available width constraint is met. (This was the case in the
1173         bug).
1174         * rendering/RenderObject.h:
1175         (WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
1176         Renamed layoutDoingPositionedMovementOnly() to this.
1177
1178 2008-09-03  Eric Seidel  <eric@webkit.org>
1179
1180         No review, build fix only.
1181
1182         Attempt to fix the Qt build.
1183
1184         * WebCore.pro: add page/animation to include path
1185
1186 2008-09-03  Mark Rowe  <mrowe@apple.com>
1187
1188         Mac build fix.  Correctly detect whether dashboard support is enabled.
1189
1190         * DerivedSources.make:
1191
1192 2008-09-03  Eric Seidel  <eric@webkit.org>
1193
1194         Reviewed by Sam.
1195
1196         Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)
1197
1198         * Configurations/WebCore.xcconfig: add missing ENABLE_*
1199         * config.h: add rules for V8_BINDINGS
1200
1201 2008-09-03  Eric Seidel  <eric@webkit.org>
1202
1203         Reviewed by Sam.
1204
1205         https://bugs.webkit.org/show_bug.cgi?id=20620
1206
1207         Add #if USE(JSC) around KJS dependencies
1208         Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:
1209         1. Most platforms have it on anyway
1210         2. V8 is going to want to share some of that code
1211         3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp
1212
1213         * bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
1214         * config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
1215         * html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
1216         * html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
1217         * html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
1218         * html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
1219         * html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
1220         * html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
1221         * html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
1222         * html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
1223         * platform/text/AtomicString.cpp: add USE(JSC)
1224         * platform/text/AtomicString.h: add USE(JSC)
1225         * platform/text/PlatformString.h: add USE(JSC)
1226         * platform/text/String.cpp: add USE(JSC)
1227         * platform/text/StringImpl.cpp: add USE(JSC)
1228         * platform/text/StringImpl.h: add USE(JSC)
1229
1230 2008-09-03  Dean McNamee  <deanm@chromium.org>
1231
1232         Reviewed by Darin Adler.
1233
1234         Fix https://bugs.webkit.org/show_bug.cgi?id=20511
1235         Bug 20511: Remove static initializers on Windows
1236
1237         Avoid static initializers on Windows by forcing Visual C++ to put
1238         all static initializers in a code segment that is never executed.
1239
1240         * config.h:
1241         * css/MediaFeatureNames.cpp:
1242         * dom/EventNames.cpp:
1243         * dom/QualifiedName.cpp:
1244         * dom/make_names.pl:
1245         * platform/StaticConstructors.h:
1246         * platform/text/AtomicString.cpp:
1247
1248 2008-09-03  Dirk Schulze  <vbs85@gmx.de>
1249
1250         Reviewed by Dave Hyatt.
1251
1252         Make FontCairo draw TextStroke and TextFill separately.
1253
1254         [CAIRO] draw TextFill and TextStroke separately.
1255         [https://bugs.webkit.org/show_bug.cgi?id=20631]
1256
1257         * platform/graphics/cairo/FontCairo.cpp:
1258         (WebCore::Font::drawGlyphs):
1259
1260 2008-09-03  Peter Kasting  <zerodpx@gmail.com>
1261
1262         Reviewed by Dave Hyatt.
1263
1264         https://bugs.webkit.org/show_bug.cgi?id=19663
1265         Account for paint and timer lag when animating images.  Also pretend
1266         that images whose animations were paused (by becoming invisible)
1267         continued to animate, by "catching up" to the correct frame when they're
1268         shown again.
1269
1270         * platform/graphics/BitmapImage.cpp:
1271         (WebCore::BitmapImage::BitmapImage):
1272         (WebCore::BitmapImage::startAnimation):
1273         (WebCore::BitmapImage::advanceAnimation):
1274         (WebCore::BitmapImage::internalAdvanceAnimation):
1275         (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
1276         * platform/graphics/BitmapImage.h:
1277         * platform/graphics/cairo/ImageCairo.cpp:
1278         (WebCore::BitmapImage::draw):
1279         * platform/graphics/cg/ImageCG.cpp:
1280         (WebCore::BitmapImage::draw):
1281         * platform/graphics/qt/ImageQt.cpp:
1282         (WebCore::BitmapImage::draw):
1283         * platform/graphics/wx/ImageWx.cpp:
1284         (WebCore::BitmapImage::draw):
1285
1286 2008-09-03  Kevin McCullough  <kmccullough@apple.com>
1287
1288         Reviewed by Tim.
1289
1290         Remove the rest of the "zombie" code from the profiler.
1291         - There is no longer a need for the ProfilerClient callback mechanism.
1292
1293         * page/Console.cpp: 
1294         (WebCore::Console::Console):
1295         (WebCore::Console::profile):
1296         (WebCore::Console::profileEnd): Move the variables from the header to
1297         here since we don't have to wait for a callback to use them.
1298         * page/Console.h:
1299         * page/InspectorController.cpp:
1300         (WebCore::InspectorController::startUserInitiatedProfiling):
1301         (WebCore::InspectorController::stopUserInitiatedProfiling):
1302         * page/InspectorController.h:
1303
1304 2008-09-03  Ada Chan  <adachan@apple.com>
1305
1306         Windows build fix.
1307
1308         * WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.
1309
1310 2008-09-01  Dean Jackson  <dino@apple.com>
1311
1312         Reviewed by Dave Hyatt.
1313
1314         https://bugs.webkit.org/show_bug.cgi?id=20594
1315         Add DOM interfaces for WebKitCSSKeyframeRule
1316         and WebKitCSSKeyframesRule.
1317
1318         TEST: LayoutTests/css3/keyframes-rule.html
1319
1320         * css/WebKitCSSKeyframeRule.idl: Added
1321         * css/WebKitCSSKeyframesRule.idl: Added
1322
1323         * bindings/js/JSCSSRuleCustom.cpp:
1324         (WebCore::toJS):
1325             Add return of new JS Keyframe rules
1326         * bindings/objc/DOMInternal.h:
1327             Include new internal header
1328
1329         * DerivedSources.make:
1330         * GNUmakefile.am:
1331         * WebCore.pro:
1332         * WebCore.vcproj/WebCore.vcproj:
1333         * WebCore.xcodeproj/project.pbxproj:
1334         * WebCoreSources.bkl:
1335             Build configs for new files
1336
1337 2008-09-03  Adam Roben  <aroben@apple.com>
1338
1339         Windows build fix
1340
1341         * DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
1342         * WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for
1343         convenience/consistency.
1344
1345 2008-09-03  Adele Peterson  <adele@apple.com>
1346
1347         Build fix.
1348
1349         * WebCore.vcproj/WebCore.vcproj:
1350
1351 2008-09-03  David Hyatt  <hyatt@apple.com>
1352
1353         Fix for bug 18203, right floats should be allowed to overflow past the left border edge.
1354
1355         Reviewed by Darin (ages ago)
1356
1357         Added fast/block/float/clamped-right-float.html
1358
1359         * rendering/RenderBlock.cpp:
1360         (WebCore::RenderBlock::positionNewFloats):
1361
1362 2008-09-02  David Hyatt  <hyatt@apple.com>
1363
1364         Add support for canvas text drawing APIs.
1365
1366         Reviewed by olliej
1367
1368         Tests added as fast/canvas/canvas-text-*.html
1369
1370         * DerivedSources.make:
1371         * WebCore.xcodeproj/project.pbxproj:
1372         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
1373         (WebCore::JSCanvasRenderingContext2D::fillText):
1374         (WebCore::JSCanvasRenderingContext2D::strokeText):
1375         * css/CSSStyleSelector.cpp:
1376         (WebCore::CSSStyleSelector::initForStyleResolve):
1377         (WebCore::CSSStyleSelector::applyPropertyToStyle):
1378         * css/CSSStyleSelector.h:
1379         * html/CanvasRenderingContext2D.cpp:
1380         (WebCore::CanvasRenderingContext2D::State::State):
1381         (WebCore::CanvasRenderingContext2D::font):
1382         (WebCore::CanvasRenderingContext2D::setFont):
1383         (WebCore::CanvasRenderingContext2D::textAlign):
1384         (WebCore::CanvasRenderingContext2D::setTextAlign):
1385         (WebCore::CanvasRenderingContext2D::textBaseline):
1386         (WebCore::CanvasRenderingContext2D::setTextBaseline):
1387         (WebCore::CanvasRenderingContext2D::fillText):
1388         (WebCore::CanvasRenderingContext2D::strokeText):
1389         (WebCore::CanvasRenderingContext2D::measureText):
1390         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1391         (WebCore::CanvasRenderingContext2D::accessFont):
1392         * html/CanvasRenderingContext2D.h:
1393         * html/CanvasRenderingContext2D.idl:
1394         * html/TextMetrics.h: Added.
1395         (WebCore::TextMetrics::create):
1396         (WebCore::TextMetrics::width):
1397         (WebCore::TextMetrics::setWidth):
1398         (WebCore::TextMetrics::TextMetrics):
1399         * html/TextMetrics.idl: Added.
1400         * platform/graphics/Font.cpp:
1401         (WebCore::Font::lineGap):
1402         * platform/graphics/Font.h:
1403         * platform/graphics/GraphicsContext.cpp:
1404         (WebCore::GraphicsContext::drawBidiText):
1405         * platform/graphics/GraphicsContext.h:
1406         * platform/graphics/GraphicsTypes.cpp:
1407         (WebCore::textAlignName):
1408         (WebCore::parseTextAlign):
1409         (WebCore::textBaselineName):
1410         (WebCore::parseTextBaseline):
1411         * platform/graphics/GraphicsTypes.h:
1412         (WebCore::):
1413
1414 2008-09-03  John Sullivan  <sullivan@apple.com>
1415
1416         Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps
1417
1418         Fixed by Darin, reviewed by me
1419
1420         * page/animation/AnimationBase.cpp:
1421         (WebCore::AnimationBase::propertiesEqual):
1422         added ensurePropertyMap() to this static function
1423         (WebCore::AnimationBase::getPropertyAtIndex):
1424         ditto
1425         (WebCore::AnimationBase::getNumProperties):
1426         ditto
1427
1428 2008-09-03  Kevin McCullough  <kmccullough@apple.com>
1429
1430         Reviewed by Darin and Tim.
1431
1432         Remove most of the "zombie" mode from the profiler.  Next we will need
1433         to remove the client callback mechanism in profiles.
1434         - These changes are a result of changes to JSCore.
1435
1436         * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
1437         * page/Console.cpp:
1438         (WebCore::retrieveLastCaller):
1439         (WebCore::Console::profileEnd):
1440         * page/InspectorController.cpp:
1441         (WebCore::InspectorController::stopUserInitiatedProfiling):
1442
1443 2008-09-03  Adele Peterson  <adele@apple.com>
1444
1445         Reviewed by Darin Adler.
1446
1447         Test: fast/forms/search-display-none-cancel-button.html
1448
1449         Allow display:none to work on a search field's cancel button.  Prepare for adding more style-ability for the results button too.
1450
1451         * css/html4.css: Set display:inline-block for these buttons.  Now they can be overridden by a web author.
1452
1453         * rendering/RenderTextControl.cpp:
1454         (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
1455         (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly.  This is now done in html4.css.
1456         (WebCore::RenderTextControl::createCancelButtonStyle): ditto.
1457         (WebCore::RenderTextControl::createSubtreeIfNeeded):
1458         Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
1459         (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
1460         (WebCore::RenderTextControl::subtreeHasChanged): ditto.
1461         (WebCore::RenderTextControl::calcHeight): ditto.
1462         (WebCore::RenderTextControl::nodeAtPoint): ditto.
1463         (WebCore::RenderTextControl::layout): ditto.
1464         (WebCore::RenderTextControl::calcPrefWidths): ditto.
1465         (WebCore::RenderTextControl::clientPaddingLeft): ditto.
1466         (WebCore::RenderTextControl::clientPaddingRight): ditto.
1467
1468         * rendering/TextControlInnerElements.cpp:
1469         (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
1470         (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
1471         (WebCore::TextControlInnerElement::attachInnerElement): Added.
1472          This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
1473         (WebCore::TextControlInnerTextElement::createRenderer): Added.  Creates a RenderTextControlInnerBlock.
1474         * rendering/TextControlInnerElements.h:
1475
1476 2008-08-28  Alexey Proskuryakov  <ap@webkit.org>
1477
1478         Reviewed by Maciej.
1479
1480         Elminate SQLiteAuthorizer class.
1481
1482         * WebCore.xcodeproj/project.pbxproj:
1483         * WebCore.vcproj/WebCore.vcproj:
1484         * GNUmakefile.am
1485         Removed SQLiteAuthorizer.h.
1486
1487         * platform/sql/SQLiteAuthorizer.cpp:
1488         * platform/sql/SQLiteAuthorizer.h: Removed.
1489         * platform/sql/SQLiteDatabase.cpp:
1490         (WebCore::SQLiteDatabase::authorizerFunction):
1491         (WebCore::SQLiteDatabase::setAuthorizer):
1492         * platform/sql/SQLiteDatabase.h:
1493         * storage/DatabaseAuthorizer.h:
1494         (WebCore::DatabaseAuthorizer::create):
1495         (WebCore::DatabaseAuthorizer::createView):
1496         (WebCore::DatabaseAuthorizer::createTempView):
1497         (WebCore::DatabaseAuthorizer::dropView):
1498         (WebCore::DatabaseAuthorizer::dropTempView):
1499         (WebCore::DatabaseAuthorizer::allowSelect):
1500         (WebCore::DatabaseAuthorizer::allowReindex):
1501         Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.
1502
1503 2008-09-03  Dirk Schulze  <vbs85@gmx.de>
1504
1505         Reviewed by Mark Rowe.
1506
1507         WebKitGtk build fix.
1508
1509         * GNUmakefile.am:
1510         * page/animation/AnimationController.h:
1511
1512 2008-09-02  Robert Blaut  <webkit@blaut.biz>
1513
1514         Reviewed by Geoff Garen.
1515
1516         Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
1517         Misplaced elements should not close DL lists.
1518
1519         Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
1520
1521         * html/HTMLParser.cpp:
1522         (WebCore::HTMLParser::handleError):
1523
1524 2008-09-02  Glenn Wilson  <wilsong@gmail.com>
1525
1526         Reviewed by Darin Adler.
1527
1528         Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360>
1529         Bug 15360: color:#{predefined colorName} is treated as colorName in Safari
1530
1531         We would inappropriately interpret and apply an invalid CSS "color" property
1532         when the value is a predefined color preceded by a '#' symbol.  For example,
1533         style="color:#gray;" would apply the color gray when it should not.
1534
1535         In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
1536         This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be 
1537         interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
1538         an ignorable token.
1539
1540         To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
1541         '#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
1542         CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.
1543
1544         Test: css1/color_and_background/invalid_color.html
1545
1546         * css/CSSGrammar.y:
1547
1548 2008-09-02  Mihnea Ovidenie  <mihnea@adobe.com>
1549
1550         Reviewed by Darin Adler.
1551
1552         Fix for https://bugs.webkit.org/show_bug.cgi?id=19964
1553         Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image
1554
1555         Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered.
1556
1557         Test: css3/khtml-background-size-0x0-bmp.html
1558
1559         * rendering/RenderBox.cpp:
1560         (WebCore::RenderBox::repaintLayerRectsForImage):
1561
1562 2008-09-02  Glenn Wilson  <wilsong@gmail.com>
1563
1564         Reviewed by Eric Seidel.
1565
1566         Fix https://bugs.webkit.org/show_bug.cgi?id=20397
1567         Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash
1568
1569         The function checkForOrphanedUnits() would change the length of a list whose size was
1570         was already determined before the call to checkForOrphanedUnits was made.  Later in
1571         the caller, the old size was being used for boundary management.
1572
1573         This has been fixed by moving the call to checkForOrphanedUnits() earlier in the
1574         calling function, before the size of the list is determined.
1575
1576         Test: fast/css/orphaned_units_crash.html
1577
1578         * css/CSSParser.cpp:
1579         (WebCore::CSSParser::parseValue):  Moved call to checkForOrphanedUnits() earlier in the function.
1580
1581 2008-09-02  Dirk Schulze  <vbs85@gmx.de>
1582
1583         Reviewed by Darin Adler.
1584
1585         Fallback on invalid fill or stroke styles in Canvas was
1586         transparent black. Changed it to last valid style.
1587
1588         Canvas fillStyle() and strokeStyle() needs fallback
1589         https://bugs.webkit.org/show_bug.cgi?id=20474
1590
1591         Tests: fast/canvas/canvas-invalid-fillstyle.html
1592                fast/canvas/canvas-invalid-strokestyle.html
1593
1594         * html/CanvasStyle.cpp:
1595         (WebCore::CanvasStyle::applyStrokeColor):
1596         (WebCore::CanvasStyle::applyFillColor):
1597
1598 2008-09-02  Dirk Schulze  <vbs85@gmx.de>
1599
1600         Reviewed by Darin Adler.
1601
1602         Fix https://bugs.webkit.org/show_bug.cgi?id=20468
1603         Updated drawImage() in canvas to match the current specification.
1604
1605         Test: fast/canvas/drawImage-with-negative-source-destination.html
1606
1607         * html/CanvasRenderingContext2D.cpp:
1608         (WebCore::normalizeRect):
1609         (WebCore::CanvasRenderingContext2D::drawImage):
1610
1611 2008-08-26  Mark Rowe  <mrowe@apple.com>
1612
1613         Reviewed by Darin Adler.
1614
1615         <rdar://problem/5768210> Switch back to the system version of SQLite
1616
1617         Use the system version of SQLite when it is new enough to provide the functionality
1618         that WebCore requires.
1619
1620         * Configurations/Base.xcconfig:
1621         * Configurations/DebugRelease.xcconfig:
1622         * Configurations/WebCore.xcconfig:
1623
1624 2008-09-02  Dan Bernstein  <mitz@apple.com>
1625
1626         - build fix
1627
1628         * page/animation/AnimationBase.h:
1629
1630 2008-09-02  Chris Marrin  <cmarrin@apple.com>
1631
1632         Reviewed by Dave Hyatt.
1633
1634         AnimationController.cpp should be split into separate files
1635         https://bugs.webkit.org/show_bug.cgi?id=20604
1636         
1637         Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon
1638         recommendation of Dave Hyatt.
1639
1640         * GNUmakefile.am:
1641         * WebCore.pro:
1642         * WebCore.vcproj/WebCore.vcproj:
1643         * WebCore.xcodeproj/project.pbxproj:
1644         * WebCoreSources.bkl:
1645             Build files.
1646         
1647         * page/AnimationController.cpp: Removed.
1648         * page/AnimationController.h: Removed.
1649         * page/animation: Added.
1650         * page/animation/AnimationBase.cpp: Added.
1651         * page/animation/AnimationBase.h: Added.
1652         * page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp.
1653         * page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h.
1654         * page/animation/CompositeAnimation.cpp: Added.
1655         * page/animation/CompositeAnimation.h: Added.
1656         * page/animation/ImplicitAnimation.cpp: Added.
1657         * page/animation/ImplicitAnimation.h: Added.
1658         * page/animation/KeyframeAnimation.cpp: Added.
1659         * page/animation/KeyframeAnimation.h: Added.
1660
1661 2008-09-02  Dan Bernstein  <mitz@apple.com>
1662
1663         - release build fix
1664
1665         * platform/graphics/cg/GraphicsContextCG.cpp:
1666         (WebCore::calculateDrawingMode):
1667
1668 2008-09-02  Timothy Hatcher  <timothy@apple.com>
1669
1670         Make console functions log the correct resource URL and
1671         line number for where the call originated.
1672
1673         https://bugs.webkit.org/show_bug.cgi?id=17234
1674         <rdar://problem/5732837>
1675
1676         Reviewed by Kevin McCullough.
1677
1678         Test: manual-tests/inspector/console-call-line-numbers.html
1679
1680         * bindings/js/JSConsoleCustom.cpp:
1681         (WebCore::JSConsole::count): Call the impl.
1682         (WebCore::JSConsole::timeEnd): Ditto.
1683         * manual-tests/inspector/console-call-line-numbers.html: Added.
1684         * manual-tests/inspector/resources/script-console-calls.js: Added.
1685         * page/Console.cpp:
1686         (WebCore::retrieveLastCaller): Helper to get the URL and line.
1687         (WebCore::Console::error): Call retrieveLastCaller to get the URL and
1688         line number to pass to addMessageToConsole.
1689         (WebCore::Console::info): Ditto.
1690         (WebCore::Console::log): Ditto.
1691         (WebCore::Console::assertCondition): Ditto.
1692         (WebCore::Console::count): Ditto.
1693         (WebCore::Console::timeEnd): Ditto.
1694         (WebCore::Console::warn): Ditto.
1695         * page/Console.h:
1696         * page/Console.idl: Make count and timeEnd custom.
1697
1698 2008-09-02  Timothy Hatcher  <timothy@apple.com>
1699
1700         Removed IDL files from WebCore's framework resources.
1701
1702         * WebCore.xcodeproj/project.pbxproj:
1703
1704 2008-09-02  Dan Bernstein  <mitz@apple.com>
1705
1706         Reviewed by Dave Hyatt.
1707
1708         - <rdar://problem/5681647> pages at http://www.stendmarsofa.com/ are so slow to calculate style it seems like a hang
1709
1710         * html/HTMLParser.cpp:
1711         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a
1712         cap on the number of consecutive identical residual style tags to
1713         reopen.
1714         (WebCore::HTMLParser::popBlock): Ditto.
1715
1716 2008-09-02  Alexey Proskuryakov  <ap@webkit.org>
1717
1718         Reviewed by Adam Roben.
1719
1720         A little database quota management cleanup.
1721
1722         * storage/OriginQuotaManager.cpp:
1723         (WebCore::OriginQuotaManager::OriginQuotaManager):
1724         (WebCore::OriginQuotaManager::lock):
1725         (WebCore::OriginQuotaManager::unlock):
1726         (WebCore::OriginQuotaManager::trackOrigin):
1727         (WebCore::OriginQuotaManager::tracksOrigin):
1728         (WebCore::OriginQuotaManager::addDatabase):
1729         (WebCore::OriginQuotaManager::removeDatabase):
1730         (WebCore::OriginQuotaManager::removeOrigin):
1731         (WebCore::OriginQuotaManager::markDatabase):
1732         (WebCore::OriginQuotaManager::diskUsage):
1733         * storage/OriginQuotaManager.h:
1734         Changed to assert that a lock is taken more directly and reliably. Removed comments about
1735         main/background threads, as this is likely to stop being true with synchronous Database calls
1736         being made on worker threads.
1737
1738         * storage/OriginUsageRecord.cpp:
1739         (WebCore::OriginUsageRecord::OriginUsageRecord):
1740         (WebCore::OriginUsageRecord::addDatabase):
1741         (WebCore::OriginUsageRecord::removeDatabase):
1742         (WebCore::OriginUsageRecord::markDatabase):
1743         (WebCore::OriginUsageRecord::diskUsage):
1744         * storage/OriginUsageRecord.h:
1745         (WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry):
1746         Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and
1747         can be replaced with a single boolean for OriginUsageRecord.
1748         Added assertions for string parameters being unshared.
1749
1750
1751 2008-09-01  Adam Barth  <abarth@webkit.org>
1752
1753         Reviewed by Sam Weinig.
1754
1755         https://bugs.webkit.org/show_bug.cgi?id=19760
1756
1757         Make granting LoadLocalResources conditional on a policy.
1758
1759         * WebCore.base.exp:
1760         * dom/Document.cpp:
1761         (WebCore::Document::initSecurityContext):
1762         * loader/FrameLoader.cpp:
1763         (WebCore::FrameLoader::setLocalLoadPolicy):
1764         (WebCore::FrameLoader::restrictAccessToLocal):
1765         * loader/FrameLoader.h:
1766         (WebCore::FrameLoader::):
1767         * platform/SecurityOrigin.cpp:
1768         (WebCore::SecurityOrigin::grantLoadLocalResources):
1769         * platform/SecurityOrigin.h:
1770
1771 2008-09-01  Dean Jackson  <dino@apple.com>
1772
1773         Reviewed by Sam Weinig.
1774
1775         https://bugs.webkit.org/show_bug.cgi?id=20571
1776         Make sure Window object can assign Animation/Transition event
1777         listeners via attributes.
1778
1779         Also added a bunch of transition event tests, although
1780         only transition-end-event-window is directly relevant to this patch.
1781
1782         (WebCore::JSDOMWindowBase::put):
1783
1784         Tests: transitions/transition-end-event-all-properties.html
1785                transitions/transition-end-event-attributes.html
1786                transitions/transition-end-event-container.html
1787                transitions/transition-end-event-left.html
1788                transitions/transition-end-event-multiple-01.html
1789                transitions/transition-end-event-multiple-02.html
1790                transitions/transition-end-event-multiple-03.html
1791                transitions/transition-end-event-multiple-04.html
1792                transitions/transition-end-event-nested.html
1793                transitions/transition-end-event-transform.html
1794                transitions/transition-end-event-window.html
1795
1796 2008-09-01  Dean Jackson  <dino@apple.com>
1797
1798         Reviewed by Sam Weinig
1799
1800         Code styling cleanup.
1801
1802         * bindings/js/JSDOMWindowBase.cpp:
1803         (WebCore::JSDOMWindowBase::getValueProperty):
1804         (WebCore::JSDOMWindowBase::put):
1805
1806 2008-09-01  Geoffrey Garen  <ggaren@apple.com>
1807
1808         Reviewed by Darin Adler.
1809
1810         First cut at inline caching for access to vanilla JavaScript properties.
1811
1812         Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
1813         to WebCore classes, and PutPropertySlot& arguments to put functions.
1814
1815         (WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with
1816         inline caching for global properties, so global assignment can be optimized.
1817
1818         * ForwardingHeaders/kjs/StructureID.h: Added.
1819         * bindings/js/JSDOMBinding.h:
1820         (WebCore::DOMObject::DOMObject):
1821         * bindings/js/JSDOMWindowBase.cpp:
1822         (WebCore::JSDOMWindowBase::put):
1823         * bindings/js/JSDOMWindowBase.h:
1824         * bindings/js/JSDOMWindowCustom.h:
1825         (WebCore::JSDOMWindow::customPut):
1826         * bindings/js/JSDOMWindowShell.cpp:
1827         (WebCore::JSDOMWindowShell::JSDOMWindowShell):
1828         (WebCore::JSDOMWindowShell::put):
1829         * bindings/js/JSDOMWindowShell.h:
1830         * bindings/js/JSEventTargetBase.h:
1831         (WebCore::JSEventTargetBase::put):
1832         * bindings/js/JSEventTargetNode.h:
1833         (WebCore::JSEventTargetNode::put):
1834         * bindings/js/JSHTMLAppletElementCustom.cpp:
1835         (WebCore::JSHTMLAppletElement::customPut):
1836         * bindings/js/JSHTMLEmbedElementCustom.cpp:
1837         (WebCore::JSHTMLEmbedElement::customPut):
1838         * bindings/js/JSHTMLInputElementBase.cpp:
1839         (WebCore::JSHTMLInputElementBase::put):
1840         * bindings/js/JSHTMLInputElementBase.h:
1841         * bindings/js/JSHTMLObjectElementCustom.cpp:
1842         (WebCore::JSHTMLObjectElement::customPut):
1843         * bindings/js/JSHistoryCustom.cpp:
1844         (WebCore::JSHistory::customPut):
1845         * bindings/js/JSInspectedObjectWrapper.cpp:
1846         (WebCore::JSInspectedObjectWrapper::wrap):
1847         (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
1848         * bindings/js/JSInspectedObjectWrapper.h:
1849         * bindings/js/JSInspectorCallbackWrapper.cpp:
1850         (WebCore::JSInspectorCallbackWrapper::wrap):
1851         (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
1852         * bindings/js/JSInspectorCallbackWrapper.h:
1853         * bindings/js/JSLocationCustom.cpp:
1854         (WebCore::JSLocation::customPut):
1855         * bindings/js/JSPluginElementFunctions.cpp:
1856         (WebCore::runtimeObjectCustomPut):
1857         * bindings/js/JSPluginElementFunctions.h:
1858         * bindings/js/JSQuarantinedObjectWrapper.cpp:
1859         (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
1860         (WebCore::JSQuarantinedObjectWrapper::put):
1861         * bindings/js/JSQuarantinedObjectWrapper.h:
1862         * bindings/js/JSStorageCustom.cpp:
1863         (WebCore::JSStorage::customPut):
1864         * bindings/objc/WebScriptObject.mm:
1865         (-[WebScriptObject setValue:forKey:]):
1866         * bindings/scripts/CodeGeneratorJS.pm:
1867         * bridge/NP_jsobject.cpp:
1868         (_NPN_SetProperty):
1869         * bridge/jni/jni_jsobject.mm:
1870         (JavaJSObject::setMember):
1871         * bridge/objc/objc_class.mm:
1872         (KJS::Bindings::ObjcClass::fallbackObject):
1873         * bridge/objc/objc_runtime.h:
1874         * bridge/objc/objc_runtime.mm:
1875         (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
1876         (ObjcFallbackObjectImp::put):
1877         * bridge/runtime.cpp:
1878         (KJS::Bindings::Instance::createRuntimeObject):
1879         * bridge/runtime_array.cpp:
1880         (RuntimeArray::put):
1881         * bridge/runtime_array.h:
1882         * bridge/runtime_object.cpp:
1883         (RuntimeObjectImp::RuntimeObjectImp):
1884         (RuntimeObjectImp::put):
1885         * bridge/runtime_object.h:
1886
1887 2008-09-01  Dirk Schulze  <vbs85@gmx.de>
1888
1889         Reviewed by Eric Seidel.
1890
1891         Fixed border-radius for Cairo.
1892
1893         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1894         (WebCore::GraphicsContext::strokeArc):
1895
1896 2008-09-01  Dirk Schulze  <vbs85@gmx.de>
1897
1898         Reviewed by Eric Seidel.
1899
1900         Added canvas's globalAlpha to cairo.
1901
1902         * platform/graphics/GraphicsContext.h:
1903         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1904         (WebCore::GraphicsContext::fillPath):
1905         (WebCore::GraphicsContext::strokePath):
1906         (WebCore::GraphicsContext::setAlpha):
1907         (WebCore::GraphicsContext::getAlpha):
1908         * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
1909         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
1910         * platform/graphics/cairo/ImageCairo.cpp:
1911         (WebCore::BitmapImage::draw):
1912
1913 2008-08-31  Simon Hausmann  <hausmann@webkit.org>
1914
1915         Unreviewed Qt build fix.
1916
1917         * WebCore.pro: Add TextControlInnerElements.cpp to SOURCES instead of
1918         the .h file
1919
1920 2008-08-30  Darin Adler  <darin@apple.com>
1921
1922         Reviewed by Maciej.
1923
1924         - adopt some new JavaScriptCore functions where appropriate
1925
1926         * bindings/js/JSDOMWindowBase.cpp:
1927         (WebCore::windowProtoFuncAToB): Adopted jsEmptyString.
1928         (WebCore::windowProtoFuncBToA): Ditto.
1929         * bindings/js/JSEventListener.cpp:
1930         (WebCore::JSLazyEventListener::eventParameterName): Adopted
1931         jsNontrivialString.
1932         * bindings/js/JSSVGLazyEventListener.cpp:
1933         (WebCore::JSSVGLazyEventListener::eventParameterName): Ditto.
1934
1935 2008-08-29  Brady Eidson  <beidson@apple.com>
1936
1937         Reviewed by Anders' rubberstamp
1938
1939         Style cleanup to match MediaTokenizer::writeRawData()
1940
1941         * loader/PluginDocument.cpp:
1942         (WebCore::PluginTokenizer::writeRawData):
1943
1944 2008-08-29  Brady Eidson  <beidson@apple.com>
1945
1946         Reviewed by Anders
1947
1948         Fix regression I introducted in 35946
1949         Already covered by media/video-click-dlbclick-standalone.html
1950
1951         * loader/MediaDocument.cpp:
1952         (WebCore::MediaTokenizer::createDocumentStructure): Don't cancel the load here - too early!
1953         (WebCore::MediaTokenizer::writeRawData): Call finish() here so onload() can be called.  Also add
1954           an ASSERT signifying that this method should only be called once, to more closely follow the
1955           PluginDocument case.
1956
1957 2008-08-29  Beth Dakin  <bdakin@apple.com>
1958
1959         Reviewed by Sam Weinig.
1960
1961         Fix for <rdar://problem/6181588>
1962
1963         This patch makes hit testing take into account the new concept of a 
1964         disconnected frame, in which some of the content may not be 
1965         visible. The current hit testing mechanism starts at a target frame 
1966         and drills down for a HitTestResult. In some cases, drilling down 
1967         will find a non-visible result. When this happens, we need to try 
1968         again, starting at a higher level -- namely, starting at the main 
1969         frame.
1970
1971         * editing/Editor.cpp:
1972         (WebCore::Editor::insideVisibleArea): New function that tests if a 
1973         point is inside the visible area for a disconnected frame.
1974         * editing/Editor.h:
1975         * page/EventHandler.cpp:
1976         (WebCore::EventHandler::hitTestResultAtPoint):
1977
1978 2008-08-29  Adele Peterson  <adele@apple.com>
1979
1980         Reviewed by Adam Roben. 
1981
1982         Rename HTMLTextFieldInnerElement.h/.cpp to TextControlInnerElements.h/.cpp
1983
1984         * GNUmakefile.am:
1985         * WebCore.pro:
1986         * WebCore.vcproj/WebCore.vcproj:
1987         * WebCore.xcodeproj/project.pbxproj:
1988         * WebCoreSources.bkl:
1989         * html/HTMLTextFieldInnerElement.cpp: Removed.
1990         * html/HTMLTextFieldInnerElement.h: Removed.
1991         * rendering/RenderTextControl.cpp:
1992         (WebCore::RenderTextControl::createSubtreeIfNeeded):
1993         * rendering/RenderTextControl.h:
1994         * rendering/TextControlInnerElements.cpp: Copied from html/HTMLTextFieldInnerElement.cpp.
1995         (WebCore::TextControlInnerElement::TextControlInnerElement):
1996         (WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
1997         (WebCore::TextControlInnerTextElement::defaultEventHandler):
1998         (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
1999         (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
2000         (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
2001         (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
2002         * rendering/TextControlInnerElements.h: Copied from html/HTMLTextFieldInnerElement.h.
2003
2004 2008-08-29  Eric Seidel  <eric@webkit.org>
2005
2006         Rubber-stamped by aroben.
2007
2008         Add GraphicsContext.h include to GraphcisContextPrivate.h
2009
2010         GraphicsContextPrivate uses StrokeStyle which is defined
2011         in GraphicsContext.h but it doesn't include that header.
2012         CoreGraphics build doesn't fail here due to the order
2013         it happens to include files.
2014
2015         * platform/graphics/GraphicsContextPrivate.h:
2016
2017 2008-08-29  Eric Seidel  <eric@webkit.org>
2018
2019         Reviewed by hyatt.
2020
2021         Fix GeneratedImage to respect Image's refcounting
2022         Fixing potential crashers (future if not current)
2023         https://bugs.webkit.org/show_bug.cgi?id=20567
2024         
2025         I don't know if it's possible to make the current code
2026         crash, thus I've not made a test.
2027
2028         * css/CSSGradientValue.cpp:
2029         (WebCore::CSSGradientValue::image):
2030         * css/CSSImageGeneratorValue.cpp:
2031         (WebCore::CSSImageGeneratorValue::removeClient):
2032         (WebCore::CSSImageGeneratorValue::getImage):
2033         * css/CSSImageGeneratorValue.h:
2034         * platform/graphics/GeneratedImage.h:
2035         (WebCore::GeneratedImage::GeneratedImage):
2036         * rendering/style/RenderStyle.cpp:
2037         (WebCore::RenderStyle::setContent):
2038         * rendering/style/RenderStyle.h:
2039
2040 2008-08-29  Eric Carlson  <eric.carlson@apple.com>
2041
2042         Reviewed by Adele.
2043
2044         Fix for <rdar://problem/6093767>
2045         https://bugs.webkit.org/show_bug.cgi?id=20526
2046
2047         Don't allow video to render until unsupported track types have been disabled.
2048
2049         * platform/graphics/win/QTMovieWin.cpp:
2050         (QTMovieWinPrivate::task):
2051         (QTMovieWinPrivate::drawingComplete):
2052         (QTMovieWinPrivate::clearGWorld):
2053
2054 2008-08-29  Eric Carlson  <eric.carlson@apple.com>
2055
2056         Reviewed by Adele.
2057
2058         Fix for https://bugs.webkit.org/show_bug.cgi?id=20525
2059         <rdar://problem/6169301>
2060         
2061         Return the size of the movie data instead of 1000.
2062         
2063         Test: media/progress-event-total.html
2064
2065         * platform/graphics/win/QTMovieWin.cpp:
2066         (QTMovieWin::dataSize):
2067
2068 2008-08-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2069
2070         Reviewed by Eric Seidel.
2071
2072         [janitor/qt] Start replacing port specific getters with the generic native getter
2073         To get the native presentation of an image we currently have platform
2074         specific #ifdef's and a generic getter using NativeImagePtr. This patch
2075         extends this to the ImageBuffer and updates the Qt platform to get rid
2076         of the special #ifdefs.
2077
2078         https://bugs.webkit.org/attachment.cgi?id=22861
2079
2080         * platform/graphics/BitmapImage.h:
2081         * platform/graphics/Image.h:
2082         * platform/graphics/qt/ImageQt.cpp:
2083         * platform/graphics/qt/StillImageQt.cpp:
2084         * platform/graphics/qt/StillImageQt.h:
2085         * platform/qt/ClipboardQt.cpp:
2086         (WebCore::ClipboardQt::createDragImage):
2087         (WebCore::ClipboardQt::declareAndWriteDragImage):
2088         * platform/qt/CursorQt.cpp:
2089         * platform/qt/PasteboardQt.cpp:
2090         (WebCore::Pasteboard::writeImage):
2091
2092 2008-08-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2093
2094         Reviewed by Simon.
2095
2096         [svg/qt] Stop crashing... when no RenderPath/RenderObject is given...
2097
2098         * svg/graphics/qt/SVGPaintServerQt.cpp:
2099         (WebCore::SVGPaintServer::renderPath):
2100         * svg/graphics/qt/SVGPaintServerSolidQt.cpp:
2101         (WebCore::SVGPaintServerSolid::setup):
2102
2103 2008-08-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2104
2105         Reviewed by Simon.
2106
2107         [network/qt] Implement defering of loading ResourceHandle's
2108         This is needed otherwise we end in an ASSERT in the MainResourceLoader. The
2109         implementation is simply not forwarding anything to the
2110         ResourceHandleClient until we are allowed to. This might lead to a deadlock
2111         in Qt as we do not empty the QNetworkReply input buffer and wait until we
2112         are allowed to read. If that happens we are forced to buffer the data
2113         within QNetworkReplyHandler, for now this is not done.
2114
2115         Manual test:
2116         - Open http://acid3.acidtests.org
2117         - Wait for the test to complete
2118         - Click on the Reference Rendering link
2119         - Be fast and see the results of acid3
2120         => assert
2121
2122         * platform/network/qt/QNetworkReplyHandler.cpp:
2123         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
2124         (WebCore::QNetworkReplyHandler::setLoadMode):
2125         (WebCore::QNetworkReplyHandler::finish):
2126         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2127         (WebCore::QNetworkReplyHandler::forwardData):
2128         (WebCore::QNetworkReplyHandler::start):
2129         (WebCore::QNetworkReplyHandler::resetState):
2130         (WebCore::QNetworkReplyHandler::sendQueuedItems):
2131         * platform/network/qt/QNetworkReplyHandler.h:
2132         (WebCore::QNetworkReplyHandler::):
2133         * platform/network/qt/ResourceHandleQt.cpp:
2134         (WebCore::ResourceHandle::start):
2135         (WebCore::ResourceHandle::loadResourceSynchronously):
2136         (WebCore::ResourceHandle::setDefersLoading):
2137
2138 2008-08-29  Simon Hausmann  <hausmann@webkit.org>
2139
2140         Reviewed by Holger.
2141
2142         Don't crash when drawing patterns with the HTML canvas. Patterns
2143         remain unimplemented but at least they don't crash anymore. This is
2144         done by changing the PlatformPatternPtr to be a brush for the Qt
2145         platform.
2146
2147         * platform/graphics/Pattern.h:
2148         * platform/graphics/qt/GraphicsContextQt.cpp:
2149         (WebCore::GraphicsContext::fillPath):
2150         (WebCore::GraphicsContext::strokePath):
2151         (WebCore::GraphicsContext::fillRect):
2152         * platform/graphics/qt/PatternQt.cpp:
2153         (WebCore::Pattern::createPlatformPattern):
2154
2155 2008-08-29  Simon Hausmann  <hausmann@webkit.org>
2156
2157         Fix the Qt build, fontSelector() is not used by the Qt port yet
2158         and we just return 0 in Font::fontSelector().
2159
2160         * platform/graphics/Font.h:
2161
2162 2008-08-28  Alp Toker  <alp@nuanti.com>
2163
2164         GTK+ dist/build fix. List newly added header files.
2165
2166         * GNUmakefile.am:
2167
2168 2008-08-28  Simon Fraser  <simon.fraser@apple.com>
2169
2170         Reviewed by Dave Hyatt
2171
2172         Various WebKitCSSTransformValue-related fixes
2173         https://bugs.webkit.org/show_bug.cgi?id=20562
2174
2175         Test: css3/transform-value-types.html
2176
2177         * bindings/js/JSCSSValueCustom.cpp:
2178         (WebCore::toJS):
2179         * css/CSSValue.h:
2180         * css/WebKitCSSTransformValue.cpp:
2181         (WebCore::WebKitCSSTransformValue::cssText):
2182         * css/WebKitCSSTransformValue.h:
2183         (WebCore::WebKitCSSTransformValue::):
2184         * css/WebKitCSSTransformValue.idl:
2185
2186 2008-08-28  Dan Bernstein  <mitz@apple.com>
2187
2188         Reviewed by Steve Falkenburg.
2189
2190         - do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred
2191
2192         * platform/win/SharedTimerWin.cpp:
2193         (WebCore::TimerWindowWndProc):
2194
2195 2008-08-28  David Hyatt  <hyatt@apple.com>
2196
2197         RenderStyle cleanup.
2198
2199         Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.
2200
2201         Reviewed by Adam
2202
2203         * css/CSSImageGeneratorValue.cpp:
2204         * css/CSSImageValue.cpp:
2205         * css/CSSStyleSelector.cpp:
2206         * rendering/RenderImageGeneratedContent.cpp:
2207         * rendering/style/NinePieceImage.cpp: Added.
2208         * rendering/style/NinePieceImage.h: Added.
2209         * rendering/style/RenderStyle.cpp:
2210         (WebCore::FillLayer::operator==):
2211         (WebCore::FillLayer::containsImage):
2212         (WebCore::StyleInheritedData::operator==):
2213         (WebCore::RenderStyle::contentDataEquivalent):
2214         * rendering/style/RenderStyle.h:
2215         * rendering/style/StyleCachedImage.cpp: Added.
2216         * rendering/style/StyleCachedImage.h: Added.
2217         * rendering/style/StyleGeneratedImage.cpp: Added.
2218         * rendering/style/StyleGeneratedImage.h: Added.
2219         * rendering/style/StyleImage.h: Added.
2220
2221 2008-08-28  Simon Fraser  <simon.fraser@apple.com>
2222
2223         Reviewed by Dave Hyatt
2224
2225         Make all the 'isFoo()' methods on CSSValue const,
2226         and fix the subclasses.
2227         
2228         https://bugs.webkit.org/show_bug.cgi?id=20561
2229         
2230         * css/CSSTimingFunctionValue.h:
2231         * css/CSSValue.h:
2232         (WebCore::CSSValue::isFontValue):
2233         (WebCore::CSSValue::isImageGeneratorValue):
2234         (WebCore::CSSValue::isImageValue):
2235         (WebCore::CSSValue::isImplicitInitialValue):
2236         * css/CSSValueList.h:
2237         * css/FontValue.h:
2238
2239 2008-08-28  David Hyatt  <hyatt@apple.com>
2240
2241         The great RenderStyle cleanup begins!
2242
2243         Move LengthBox and LengthSize out of RenderStyle and into Length.
2244
2245         Reviewed by Adam
2246
2247         * rendering/Length.h:
2248         (WebCore::):
2249         (WebCore::Length::Length):
2250         (WebCore::Length::operator==):
2251         (WebCore::Length::operator!=):
2252         (WebCore::Length::value):
2253         (WebCore::Length::rawValue):
2254         (WebCore::Length::percent):
2255         (WebCore::Length::type):
2256         (WebCore::Length::quirk):
2257         (WebCore::Length::setValue):
2258         (WebCore::Length::setRawValue):
2259         (WebCore::Length::calcValue):
2260         (WebCore::Length::calcMinValue):
2261         (WebCore::Length::calcFloatValue):
2262         (WebCore::Length::isUndefined):
2263         (WebCore::Length::isZero):
2264         (WebCore::Length::isPositive):
2265         (WebCore::Length::isNegative):
2266         (WebCore::Length::isAuto):
2267         (WebCore::Length::isRelative):
2268         (WebCore::Length::isPercent):
2269         (WebCore::Length::isFixed):
2270         (WebCore::Length::isStatic):
2271         (WebCore::Length::isIntrinsicOrAuto):
2272         (WebCore::Length::blend):
2273         (WebCore::LengthBox::LengthBox):
2274         (WebCore::LengthBox::operator=):
2275         (WebCore::LengthBox::operator==):
2276         (WebCore::LengthBox::operator!=):
2277         (WebCore::LengthBox::nonZero):
2278         (WebCore::LengthSize::LengthSize):
2279         * rendering/style/RenderStyle.h:
2280
2281 2008-08-28  David Hyatt  <hyatt@apple.com>
2282
2283         Reviewed by Darin
2284
2285         https://bugs.webkit.org/show_bug.cgi?id=18091
2286
2287         font-size should be animatable using -webkit-transition.
2288
2289         * page/AnimationController.cpp:
2290         (WebCore::AnimationControllerPrivate::ensurePropertyMap):
2291         * rendering/style/RenderStyle.h:
2292         (WebCore::RenderStyle::setFontSize):
2293
2294 2008-08-28  Brad Garcia  <bgarcia@google.com>
2295
2296         Reviewed by Dan Bernstein.
2297
2298         https://bugs.webkit.org/show_bug.cgi?id=20549
2299         Correctly determine when cursor is over a resizable border within
2300         a nested frameset.
2301
2302         * rendering/RenderFrameSet.cpp:
2303         (WebCore::RenderFrameSet::canResizeRow):
2304         (WebCore::RenderFrameSet::canResizeColumn):
2305
2306 2008-08-28  Simon Fraser  <simon.fraser@apple.com>
2307
2308         Reviewed by Eric Seidel
2309
2310         Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
2311         https://bugs.webkit.org/show_bug.cgi?id=20552
2312
2313         Test: animations/animation-css-rule-types.html
2314
2315         * css/CSSRule.idl:
2316
2317 2008-08-28  Anders Carlsson  <andersca@apple.com>
2318
2319         Reviewed by Kevin and Darin.
2320
2321         <rdar://problem/6182541>
2322         https://bugs.webkit.org/show_bug.cgi?id=20202
2323         Missing http status line from the http headers.
2324         
2325         Add a status line to the header string.
2326         
2327         * plugins/PluginStream.cpp:
2328         (WebCore::PluginStream::startStream):
2329
2330 2008-08-28  Holger Hans Peter Freyther  <zecke@selfish.org>
2331
2332         Rubber-stamped by Darin Adler.
2333
2334         https://bugs.webkit.org/show_bug.cgi?id=17261
2335
2336         Make it possible to theme the default Url icon and enable this for
2337         the Qt port. To have a minimal usage of #ifdef in the code the setting
2338         of the icon was moved to a new method which comes in two flavors.
2339
2340         * loader/icon/IconDatabase.cpp:
2341         (WebCore::loadDefaultIconRecord): Load or set the default icon
2342         (WebCore::IconDatabase::defaultIcon):
2343
2344 2008-08-28  Holger Hans Peter Freyther <zecke@selfish.org>
2345
2346         Unreviewed compile fix
2347
2348         * platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions
2349
2350 2008-08-28  Adam Roben  <aroben@apple.com>
2351
2352         Windows (and others?) build fix
2353
2354         * page/Chrome.cpp: Added a missing #include.
2355         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.
2356
2357 2008-08-27  Eric Seidel  <eric@webkit.org>
2358
2359         Reviewed by Oliver Hunt.
2360
2361         Qt and Cairo support from krit (and blind stab @ wx compile support)
2362         https://bugs.webkit.org/show_bug.cgi?id=20373
2363
2364         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2365         (WebCore::GraphicsContext::fillPath):
2366         (WebCore::GraphicsContext::strokePath):
2367         (WebCore::GraphicsContext::drawPath):
2368         (WebCore::GraphicsContext::fillRect):
2369         (WebCore::GraphicsContext::setPlatformFillColor):
2370         (WebCore::GraphicsContext::setPlatformStrokeColor):
2371         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2372         (WebCore::GraphicsContext::strokeRect):
2373         (WebCore::GraphicsContext::setImageInterpolationQuality):
2374         (WebCore::GraphicsContext::imageInterpolationQuality):
2375         (WebCore::GraphicsContext::setPlatformFillPattern):
2376         (WebCore::GraphicsContext::setPlatformStrokePattern):
2377         (WebCore::GraphicsContext::setPlatformFillGradient):
2378         (WebCore::GraphicsContext::setPlatformStrokeGradient):
2379         * platform/graphics/qt/GraphicsContextQt.cpp:
2380         (WebCore::GraphicsContext::fillPath):
2381         (WebCore::GraphicsContext::strokePath):
2382         (WebCore::GraphicsContext::fillRect):
2383         (WebCore::GraphicsContext::strokeRect):
2384         (WebCore::GraphicsContext::clipToImageBuffer):
2385         (WebCore::GraphicsContext::setPlatformFillPattern):
2386         (WebCore::GraphicsContext::setPlatformStrokePattern):
2387         (WebCore::GraphicsContext::setPlatformFillGradient):
2388         (WebCore::GraphicsContext::setPlatformStrokeGradient):
2389         (WebCore::GraphicsContext::setImageInterpolationQuality):
2390         (WebCore::GraphicsContext::imageInterpolationQuality):
2391         * platform/graphics/wx/GraphicsContextWx.cpp:
2392         (WebCore::GraphicsContext::clipToImageBuffer):
2393         (WebCore::GraphicsContext::setImageInterpolationQuality):
2394         (WebCore::GraphicsContext::imageInterpolationQuality):
2395         (WebCore::GraphicsContext::fillPath):
2396         (WebCore::GraphicsContext::strokePath):
2397         (WebCore::GraphicsContext::drawPath):
2398         (WebCore::GraphicsContext::fillRect):
2399         (WebCore::GraphicsContext::setPlatformFillPattern):
2400         (WebCore::GraphicsContext::setPlatformStrokePattern):
2401         (WebCore::GraphicsContext::setPlatformFillGradient):
2402
2403 2008-08-27  Eric Seidel  <eric@webkit.org>
2404
2405         Reviewed by Oliver Hunt.
2406
2407         Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
2408         https://bugs.webkit.org/show_bug.cgi?id=20373
2409
2410         Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()
2411         
2412         Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
2413         have to store large Gradient objects in the GraphicsContextState
2414         
2415         Made Pattern RefCounted for the same reason.
2416         
2417         Many updates to GraphicsContext to support easier drawing with
2418         Patterns and Gradients.
2419
2420         * WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
2421         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2422         (WebCore::toJS):
2423         * css/CSSGradientValue.cpp:
2424         (WebCore::CSSGradientValue::createGradient):
2425         * css/CSSGradientValue.h:
2426         * html/CanvasGradient.cpp:
2427         (WebCore::CanvasGradient::CanvasGradient):
2428         * html/CanvasGradient.h:
2429         (WebCore::CanvasGradient::gradient):
2430         (WebCore::CanvasGradient::addColorStop):
2431         (WebCore::CanvasGradient::getColor):
2432         * html/CanvasPattern.cpp:
2433         * html/CanvasPattern.h:
2434         (WebCore::CanvasPattern::pattern):
2435         (WebCore::CanvasPattern::originClean):
2436         * html/CanvasRenderingContext2D.cpp:
2437         (WebCore::CanvasRenderingContext2D::State::State):
2438         (WebCore::CanvasRenderingContext2D::setStrokeStyle):
2439         (WebCore::CanvasRenderingContext2D::setFillStyle):
2440         (WebCore::CanvasRenderingContext2D::fill):
2441         (WebCore::CanvasRenderingContext2D::stroke):
2442         (WebCore::CanvasRenderingContext2D::fillRect):
2443         (WebCore::CanvasRenderingContext2D::strokeRect):
2444         * html/CanvasRenderingContext2D.h:
2445         * html/CanvasStyle.cpp:
2446         (WebCore::CanvasStyle::applyStrokeColor):
2447         (WebCore::CanvasStyle::applyFillColor):
2448         * html/CanvasStyle.h:
2449         * platform/graphics/GeneratedImage.h:
2450         (WebCore::GeneratedImage::GeneratedImage):
2451         * platform/graphics/Generator.h:
2452         * platform/graphics/Gradient.h:
2453         (WebCore::Gradient::create):
2454         * platform/graphics/GraphicsContext.cpp:
2455         (WebCore::GraphicsContext::fillRule):
2456         (WebCore::GraphicsContext::setFillRule):
2457         (WebCore::GraphicsContext::setStrokePattern):
2458         (WebCore::GraphicsContext::setFillPattern):
2459         (WebCore::GraphicsContext::setStrokeGradient):
2460         (WebCore::GraphicsContext::setFillGradient):
2461         * platform/graphics/GraphicsContext.h:
2462         * platform/graphics/GraphicsContextPrivate.h:
2463         (WebCore::):
2464         (WebCore::GraphicsContextState::GraphicsContextState):
2465         * platform/graphics/GraphicsTypes.h:
2466         * platform/graphics/Path.h:
2467         * platform/graphics/Pattern.h:
2468         (WebCore::Pattern::create):
2469         (WebCore::Pattern::tileImage):
2470         * platform/graphics/cg/GraphicsContextCG.cpp:
2471         (WebCore::GraphicsContext::drawRect):
2472         (WebCore::GraphicsContext::drawEllipse):
2473         (WebCore::GraphicsContext::drawConvexPolygon):
2474         (WebCore::calculateDrawingMode):
2475         (WebCore::GraphicsContext::drawPath):
2476         (WebCore::fillPathWithFillRule):
2477         (WebCore::GraphicsContext::fillPath):
2478         (WebCore::GraphicsContext::strokePath):
2479         (WebCore::GraphicsContext::fillRect):
2480         (WebCore::GraphicsContext::fillRoundedRect):
2481         (WebCore::GraphicsContext::setPlatformStrokePattern):
2482         (WebCore::GraphicsContext::setPlatformFillPattern):
2483         (WebCore::GraphicsContext::setPlatformStrokeGradient):
2484         (WebCore::GraphicsContext::setPlatformFillGradient):
2485
2486 2008-08-20  Eric Seidel  <eric@webkit.org>
2487
2488         Reviewed by Darin and Alexey.
2489
2490         Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
2491         with timeouts paused.
2492         https://bugs.webkit.org/show_bug.cgi?id=20469
2493         
2494         I attempted to clean up the memory management of PausedTimeouts, I'm not
2495         sure the solution I came up with is "cleaner", but it's in some ways
2496         "safer", since it no longer uses raw pointers and manual new/delete.
2497         
2498         This also now prevents CachedPage from needlessly creating Window
2499         objects when caching pages which didn't already have one. :)
2500         
2501         I also made Chrome.cpp no longer depend on the JavaScript bindings
2502         (aka JSDOMWindowBase.h), since there was no real reason for it to.
2503
2504         * bindings/js/JSDOMWindowBase.cpp:
2505         (WebCore::JSDOMWindowBase::pauseTimeouts):
2506         (WebCore::JSDOMWindowBase::resumeTimeouts):
2507         * bindings/js/JSDOMWindowBase.h:
2508         * bindings/js/ScriptController.cpp:
2509         (WebCore::ScriptController::pauseTimeouts):
2510         (WebCore::ScriptController::resumeTimeouts):
2511         * bindings/js/ScriptController.h:
2512         * history/CachedPage.cpp:
2513         (WebCore::CachedPage::CachedPage):
2514         (WebCore::CachedPage::restore):
2515         * page/Chrome.cpp:
2516         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2517         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2518         * page/JavaScriptDebugServer.cpp:
2519         (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
2520         (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
2521
2522 2008-08-27  Holger Hans Peter Freyther <zecke@selfish.org>
2523
2524         Unreviewed compile fix
2525
2526         Add the stub for the Qt port.
2527
2528         * WebCore.pro:
2529         * page/qt/AccessibilityObjectQt.cpp: Added.
2530         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2531
2532 2008-08-27  Alp Toker  <alp@nuanti.com>
2533
2534         Reviewed by Eric.
2535
2536         https://bugs.webkit.org/show_bug.cgi?id=20551
2537         [GTK] search popup crash
2538
2539         * platform/gtk/SearchPopupMenuGtk.cpp:
2540         (WebCore::SearchPopupMenu::enabled):
2541         Fix a search popup crasher by disabling the history popup since we
2542         don't support this feature yet in the GTK+ port.
2543
2544 2008-08-27  Alp Toker  <alp@nuanti.com>
2545
2546         Reviewed by Eric.
2547
2548         https://bugs.webkit.org/show_bug.cgi?id=20551
2549         [GTK] curl crashers
2550
2551         * platform/network/curl/ResourceHandleManager.cpp:
2552         (WebCore::ResourceHandleManager::startScheduledJobs):
2553         Remove the resource handle from the pending list before starting the
2554         job, not afterwards. Fixes crashers in the test suite.
2555
2556         Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
2557         Test: fast/encoding/char-encoding.html
2558
2559 2008-08-27  Dirk Schulze  <vbs85@gmx.de>
2560
2561         Reviewed by eseidel.
2562
2563         Fix canvas drawImage to support composite operations.
2564         Composite had no effect on canvas elements like these:
2565         http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html
2566
2567         [CAIRO] Canvas composite don't work on canvas-elements.
2568         https://bugs.webkit.org/show_bug.cgi?id=20548
2569
2570         * html/CanvasRenderingContext2D.cpp:
2571         (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call
2572
2573 2008-08-27  Mario Bensi  <mbensi@pleyo.com>
2574
2575         Reviewed by Eric Seidel.
2576         
2577         Fix the data content of an image with a base64.
2578
2579         * platform/network/curl/ResourceHandleManager.cpp:
2580         (WebCore::parseDataUrl): Remove the String and use only the data
2581         Vector because the data.latin1().data() convert the data content and
2582         the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is
2583         not drawn correctly.
2584
2585 2008-08-27  Antti Koivisto  <antti@apple.com>
2586
2587         Reviewed by Eric Seidel.
2588
2589         Crash after OK in dialog box and reloading page in secure mode
2590         https://bugs.webkit.org/show_bug.cgi?id=20493
2591         
2592         The new run loop spawned by a modal dialog causes a timer in the loader to run 
2593         synchronously inside didFinishLoading() deleting "this" object.
2594         
2595         Defer all WebCore timers when a modal dialog is up. They are not
2596         safe to execute.
2597
2598         * page/Chrome.cpp:
2599         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2600         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2601
2602 2008-08-27  Chris Marrin  <cmarrin@apple.com>
2603
2604         Reviewed by Dave Hyatt
2605
2606         Memory leaks when animating transforms
2607         https://bugs.webkit.org/show_bug.cgi?id=20532
2608
2609         * rendering/style/RenderStyle.cpp:
2610         (WebCore::ScaleTransformOperation::blend):
2611         (WebCore::RotateTransformOperation::blend):
2612         (WebCore::SkewTransformOperation::blend):
2613         (WebCore::TranslateTransformOperation::blend):
2614         (WebCore::MatrixTransformOperation::blend):
2615         * rendering/style/RenderStyle.h:
2616
2617 2008-08-27  Timothy Hatcher  <timothy@apple.com>
2618
2619         Add support for support for -webkit-appearance: default-button on the Mac platform.
2620
2621         <rdar://problem/6173530>
2622
2623         Reviewed by Dave Hyatt.
2624
2625         * WebCore.base.exp: Export new symbols.
2626         * platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
2627         * platform/mac/WebCoreSystemInterface.mm: Ditto.
2628         * rendering/RenderButton.cpp:
2629         (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN).
2630         (WebCore::RenderButton::setStyle): Ditto.
2631         * rendering/RenderButton.h: Ditto.
2632         * rendering/RenderThemeMac.mm:
2633         (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance.
2634         (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return
2635         key if the button is default, otherwise reset the key equivalent.
2636         (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell:
2637         on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore
2638         the window's previous default button cell when finished.
2639
2640 2008-08-26  David Hyatt  <hyatt@apple.com>
2641
2642         First cut at making form controls on OS X respect full page zoom.  There are lots of bugs.
2643
2644         Reviewed by weinig
2645
2646         Added fast/forms/zoomed-controls.html
2647
2648         * css/CSSStyleSelector.cpp:
2649         (WebCore::addIntrinsicMargins):
2650         * rendering/RenderSlider.cpp:
2651         (WebCore::RenderSlider::calcPrefWidths):
2652         * rendering/RenderThemeMac.h:
2653         * rendering/RenderThemeMac.mm:
2654         (WebCore::RenderThemeMac::adjustRepaintRect):
2655         (WebCore::RenderThemeMac::inflateRect):
2656         (WebCore::RenderThemeMac::baselinePosition):
2657         (WebCore::RenderThemeMac::setControlSize):
2658         (WebCore::RenderThemeMac::sizeForFont):
2659         (WebCore::RenderThemeMac::sizeForSystemFont):
2660         (WebCore::RenderThemeMac::setFontFromControlSize):
2661         (WebCore::RenderThemeMac::paintCheckbox):
2662         (WebCore::RenderThemeMac::setCheckboxCellState):
2663         (WebCore::RenderThemeMac::paintRadio):
2664         (WebCore::RenderThemeMac::setRadioCellState):
2665         (WebCore::RenderThemeMac::setButtonPaddingFromControlSize):
2666         (WebCore::RenderThemeMac::adjustButtonStyle):
2667         (WebCore::RenderThemeMac::setButtonCellState):
2668         (WebCore::RenderThemeMac::paintButton):
2669         (WebCore::RenderThemeMac::paintMenuList):
2670         (WebCore::RenderThemeMac::paintMenuListButton):
2671         (WebCore::RenderThemeMac::popupInternalPaddingLeft):
2672         (WebCore::RenderThemeMac::popupInternalPaddingRight):
2673         (WebCore::RenderThemeMac::popupInternalPaddingTop):
2674         (WebCore::RenderThemeMac::popupInternalPaddingBottom):
2675         (WebCore::RenderThemeMac::setPopupButtonCellState):
2676         (WebCore::RenderThemeMac::paintSliderTrack):
2677         (WebCore::RenderThemeMac::paintSliderThumb):
2678         (WebCore::RenderThemeMac::adjustSliderThumbSize):
2679         (WebCore::RenderThemeMac::paintSearchField):
2680         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
2681         (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
2682         (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
2683
2684 2008-08-27  Brady Eidson  <beidson@apple.com>
2685
2686         Reviewed by Anders
2687
2688         <rdar://problem/6134133> - Crash when loading large movie as a standalone document
2689
2690         We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
2691         to load and buffer the data for the movie in WebCore.  With large media files, this results in blowing
2692         away the virtual address space and a crash.
2693
2694         * loader/EmptyClients.h:
2695         (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
2696         * loader/FrameLoaderClient.h:  Added client method to get platform specific error for
2697           "plugin will handle load"
2698
2699         * loader/MediaDocument.cpp:
2700         (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data,
2701           and cancel the WebCore-managed load
2702         (WebCore::MediaTokenizer::writeRawData):
2703         (WebCore::MediaTokenizer::finish):
2704
2705 2008-08-26  Simon Fraser  <simon.fraser@apple.com>
2706
2707         Reviewed by Eric Seidel
2708
2709         Linear timing functions should have control points 0, 0, 1, 1.
2710         https://bugs.webkit.org/show_bug.cgi?id=20535
2711
2712         * css/CSSStyleSelector.cpp:
2713         (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
2714         * rendering/style/RenderStyle.h:
2715
2716 2008-08-27  Adam Roben  <aroben@apple.com>
2717
2718         Windows build fix
2719
2720         * WebCore.vcproj/WebCore.vcproj: Fix file extension.
2721
2722 2008-08-26  Chris Fleizach  <cfleizach@apple.com>
2723
2724         Reviewed by Beth Dakin.
2725
2726         <rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown
2727
2728         Added platform-specific accessibilityIgnoreAttachment, which allows the platform
2729         to determine if an attachment is ignored through accessibility. Added equivalent
2730         methods in Gtk, Win and Mac
2731
2732         Test: accessibility/plugin.html
2733
2734         * GNUmakefile.am:
2735         * WebCore.vcproj/WebCore.vcproj:
2736         * WebCore.xcodeproj/project.pbxproj:
2737         * page/AccessibilityObject.h:
2738         * page/AccessibilityRenderObject.cpp:
2739         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2740         * page/gtk/AccessibilityObjectAtk.cpp: Added.
2741         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2742         * page/mac/AccessibilityObjectMac.mm: Added.
2743         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2744         * page/mac/AccessibilityObjectWrapper.h:
2745         * page/win/AccessibilityObjectWin.cpp: Added.
2746         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2747
2748 2008-08-26  Chris Fleizach  <cfleizach@apple.com>
2749
2750         Reviewed by Beth Dakin.
2751
2752         <rdar://problem/5817770> can't bring up contextual menu for embedded objects in WebText
2753
2754         * page/mac/AccessibilityObjectWrapper.mm:
2755         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
2756         (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
2757
2758 2008-08-26  Chris Fleizach  <cfleizach@apple.com>
2759
2760         Reviewed by Darin Adler.
2761
2762         <rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns
2763
2764         Tests: accessibility/table-notbody.html
2765
2766         * page/AccessibilityTable.cpp:
2767         (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
2768
2769 2008-08-26  Sam Weinig  <sam@webkit.org>
2770
2771         Reviewed by Beth Dakin.
2772
2773         Fix typo.
2774
2775         * dom/DOMCoreException.h:
2776
2777 2008-08-26  Sam Weinig  <sam@webkit.org>
2778
2779         Reviewed by Oliver Hunt.
2780
2781         Fix https://bugs.webkit.org/show_bug.cgi?id=20479
2782         <rdar://problem/6167660>
2783         Take image redirects into account when tainting the canvas.
2784
2785         Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html
2786
2787         * html/CanvasRenderingContext2D.cpp:
2788         (WebCore::CanvasRenderingContext2D::drawImage):
2789         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
2790
2791 2008-08-26  Sam Weinig  <sam@webkit.org>
2792
2793         Reviewed by Darin Adler.
2794
2795         Change canvas tainting logic to ask the image if it contains
2796         any resources outside of its own origin. Since there is no 
2797         way to determine if SVG images contain any resources outside its
2798         origin, we always assume it does.
2799
2800         * html/CanvasRenderingContext2D.cpp:
2801         (WebCore::CanvasRenderingContext2D::drawImage):
2802         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
2803         * platform/graphics/BitmapImage.h:
2804         (WebCore::BitmapImage::hasSingleSecurityOrigin):
2805         * platform/graphics/GeneratedImage.h:
2806         (WebCore::GeneratedImage::hasSingleSecurityOrigin):
2807         * platform/graphics/Image.h:
2808         (WebCore::Image::hasSingleSecurityOrigin):
2809         * platform/graphics/cg/PDFDocumentImage.h:
2810         (WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
2811         * svg/graphics/SVGImage.h:
2812
2813 2008-08-26  Maxime Britto  <britto@apple.com>
2814
2815         Reviewed by Adele.
2816
2817         <rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
2818         This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
2819         This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.
2820
2821         * page/EventHandler.cpp:
2822         (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
2823         * page/EventHandler.h:
2824         * rendering/RenderLayer.cpp:
2825         (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta
2826         (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
2827         * rendering/RenderLayer.h:
2828         * rendering/RenderObject.cpp:
2829         (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled
2830         (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method
2831         (WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
2832
2833 2008-08-25  Julien Chaffraix  <jchaffraix@webkit.org>
2834
2835         Reviewed by Darin Adler.
2836
2837         Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
2838         https://bugs.webkit.org/show_bug.cgi?id=20247
2839
2840         <rdar://problem/6118218>
2841
2842         Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
2843         check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
2844         (case insensitive for HTML elements).
2845
2846         Test: fast/dom/Element/getAttribute-check-case-sensitivity.html
2847
2848         * dom/Element.cpp:
2849         (WebCore::Element::getAttribute):
2850         * dom/NamedAttrMap.cpp:
2851         (WebCore::NamedAttrMap::getNamedItem):
2852         (WebCore::NamedAttrMap::getAttributeItem):
2853         * dom/NamedAttrMap.h:
2854
2855 2008-08-25  Sam Weinig  <sam@webkit.org>
2856
2857         Reviewed by Oliver Hunt.
2858
2859         Fix for https://bugs.webkit.org/show_bug.cgi?id=20514
2860         <rdar://problem/6174096>
2861         Treat SVG images as dirty when drawing to a canvas.
2862
2863         Test: http/tests/security/canvas-remote-read-svg-image.html
2864
2865         * html/CanvasRenderingContext2D.cpp:
2866         (WebCore::CanvasRenderingContext2D::drawImage):
2867         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
2868         * platform/graphics/Image.h:
2869         (WebCore::Image::isSVGImage):
2870         * svg/graphics/SVGImage.h:
2871         (WebCore::SVGImage::isSVGImage):
2872
2873 2008-08-25  Sam Weinig  <sam@webkit.org>
2874
2875         Reviewed by Mark Rowe.
2876
2877         Fix https://bugs.webkit.org/show_bug.cgi?id=20377
2878         Leak in XMLHttpRequest.
2879
2880         * xml/XMLHttpRequest.cpp:
2881         (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
2882
2883 2008-08-25  Brady Eidson  <beidson@apple.com>
2884
2885         Reviewed by Anders
2886
2887         Speculative fix for <rdar://problem/6173217>
2888
2889         Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
2890         Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
2891         the first null check invalid.
2892
2893         * loader/FrameLoader.cpp:
2894         (WebCore::FrameLoader::stopAllLoaders):
2895
2896
2897 2008-08-25  Kevin McCullough  <kmccullough@apple.com>
2898
2899         Reviewed by Tim.
2900
2901         <rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
2902         there is no profile, can cause crash
2903
2904         * page/inspector/ProfilesPanel.js:
2905
2906 2008-08-25  Dean Jackson  <dino@apple.com>
2907
2908         Reviewed by Dave Hyatt
2909
2910         Make sure 'inherit' is handled by transition property.
2911         https://bugs.webkit.org/show_bug.cgi?id=20513
2912
2913         Test: transitions/inherit.html
2914         Test: transitions/inherit-other-props.html
2915
2916         * css/CSSStyleSelector.cpp:
2917           fix macro to check existence of list before getting size
2918
2919 2008-08-25  Anders Carlsson  <andersca@apple.com>
2920
2921         Reviewed by Mark.
2922
2923         <rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.
2924         
2925         Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume 
2926         (safely) that any class that needs finalization on the main thread will also need to be deallocated
2927         on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
2928         calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.
2929
2930         * platform/mac/WebCoreObjCExtras.c:
2931         (WebCoreObjCFinalizeOnMainThread):
2932
2933 2008-08-25  Antti Koivisto  <antti@apple.com>
2934
2935         Reviewed by Dan Bernstein.
2936
2937         Rename CachedResource::referenced() to CachedResource::hasClients() to
2938         match previous ref() -> addClient() rename.
2939
2940         * loader/Cache.cpp:
2941         (WebCore::Cache::pruneLiveResources):
2942         (WebCore::Cache::pruneDeadResources):
2943         (WebCore::Cache::remove):
2944         (WebCore::Cache::getStatistics):
2945         (WebCore::Cache::dumpLRULists):
2946         * loader/CachedResource.cpp:
2947         (WebCore::CachedResource::addClient):
2948         (WebCore::CachedResource::removeClient):
2949         (WebCore::CachedResource::setDecodedSize):
2950         (WebCore::CachedResource::setEncodedSize):
2951         * loader/CachedResource.h:
2952         (WebCore::CachedResource::hasClients):
2953         (WebCore::CachedResource::canDelete):
2954
2955 2008-08-25  Anthony Ricaud  <rik24d@gmail.com>
2956
2957         Add a missing Inspector localized string for "other".
2958
2959         https://bugs.webkit.org/show_bug.cgi?id=20509
2960
2961         Reviewed by Tim Hatcher.
2962
2963         * English.lproj/localizedStrings.js:
2964
2965 2008-08-22  Kevin McCullough  <kmccullough@apple.com>
2966
2967         Reviewed by Geoff, Mark and Tim.
2968
2969         <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
2970         in the console said what file and line number they came from
2971         - Lay the foundation for getting line numbers and other data from the
2972         JavaScript engine.
2973
2974         * ForwardingHeaders/VM: Added.
2975         * ForwardingHeaders/VM/Machine.h: Added.
2976         * page/Console.cpp: Gather the line number and file information when 
2977         profileEnd has been called, but don't use it until didFinishProfiling is
2978         called.  We won't need to wait once we remove the profiler "zombie" mode
2979         which this patch helps pave the foundation for.
2980         (WebCore::Console::Console):
2981         (WebCore::Console::profileEnd):
2982         (WebCore::Console::finishedProfiling):
2983         * page/Console.h:
2984         * page/InspectorController.cpp: Modify calls to
2985         addProfileMessageToConsole to satisfy the new arguments it takes.
2986         (WebCore::InspectorController::finishedProfiling):
2987         (WebCore::InspectorController::addProfile):
2988         (WebCore::InspectorController::addProfileMessageToConsole):
2989         (WebCore::InspectorController::finishedProfiling):
2990         * page/InspectorController.h:
2991
2992 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
2993
2994         Reviewed by Simon.
2995
2996         [inspector] Update the WebKit.qrc Qt resources file
2997         Catchup with the changes in the directory.
2998
2999         * page/inspector/WebKit.qrc:
3000
3001 2008-08-25  Dirk Schulze  <vbs85@gmx.de>
3002
3003         Reviewed by Simon.
3004
3005         Transformed the radian to degree, to get rotate()
3006         in canvas work as expected.
3007
3008         [Qt] Canvas.rotate() doesn't work
3009         https://bugs.webkit.org/show_bug.cgi?id=20496
3010
3011         * platform/graphics/qt/GraphicsContextQt.cpp:
3012         (WebCore::GraphicsContext::rotate):
3013
3014 2008-08-24  Steve Falkenburg  <sfalken@apple.com>
3015
3016         Add a "last chance" WM_TIMER to the Windows shared timer.
3017         
3018         The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
3019         Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
3020         timers if a timer with an earlier expiration is already pending. This results in no timers
3021         firing from that point on.
3022         
3023         We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
3024         buggy window message hook.
3025         
3026         This timer will start when the first WM_TIMER is scheduled, and will
3027         fire every 5 seconds thereafter, causing any lost timers to be fired.
3028         
3029         Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
3030         and prevents the WebFrame leak.
3031         
3032         Reviewed by Darin Adler, Geoff Garen.
3033
3034         * platform/win/SharedTimerWin.cpp:
3035         (WebCore::):
3036         (WebCore::TimerWindowWndProc):
3037         (WebCore::setSharedTimerFireTime):
3038
3039 2008-08-24  Dan Bernstein  <mitz@apple.com>
3040
3041         Reviewed by Darin Adler.
3042
3043         - fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
3044
3045         Test: fast/css/font-property-priority.html
3046
3047         * css/CSSParser.cpp:
3048         (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
3049         to the font-property-parsing functions.
3050         (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
3051         changed to use it rather than the m_important member.
3052         (WebCore::CSSParser::parseFontVariant): Ditto.
3053         (WebCore::CSSParser::parseFontWeight): Ditto.
3054         * css/CSSParser.h:
3055
3056 2008-08-24  Timothy Hatcher  <timothy@apple.com>
3057
3058         Fixes a bug where the Inspector's UI would not animate or
3059         fully function because JavaScript timeouts, intervals and
3060         CSS animation timers where not firing while paused at a
3061         a breakpoint in the inspected page.
3062
3063         https://bugs.webkit.org/show_bug.cgi?id=20042
3064
3065         Reviewed by Darin Adler.
3066
3067         Test: manual-tests/inspector/forzen-ui-while-paused.html
3068
3069         * page/JavaScriptDebugServer.cpp:
3070         (WebCore::JavaScriptDebugServer::pauseIfNeeded):
3071         Add a call to TimerBase::fireTimersInNestedEventLoop before
3072         spinning the EventLoop.
3073
3074 2008-08-24  Rob Buis  <buis@kde.org>
3075
3076         Reviewed by Sam Weinig.
3077
3078         https://bugs.webkit.org/show_bug.cgi?id=20324
3079         A change in SVG Glyph wont show up
3080
3081         Invalidate the glyph cache when the d attribute is set.
3082
3083         Test: svg/custom/glyph-setting-d-attribute.svg
3084
3085         * svg/SVGGlyphElement.cpp:
3086         (WebCore::SVGGlyphElement::invalidateGlyphCache):
3087         (WebCore::SVGGlyphElement::parseMappedAttribute):
3088         (WebCore::SVGGlyphElement::insertedIntoDocument):
3089         (WebCore::SVGGlyphElement::removedFromDocument):
3090         * svg/SVGGlyphElement.h:
3091
3092 2008-08-24  Dan Bernstein  <mitz@apple.com>
3093
3094         Reviewed by Sam Weinig.
3095
3096         - fix https://bugs.webkit.org/show_bug.cgi?id=13864
3097           <rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()
3098
3099         * rendering/RenderText.cpp:
3100         (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
3101         beginWS and endWS before the early return to ensure that they are
3102         initialized in that case.
3103
3104 2008-08-23  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3105
3106         Rubber-stamped by Mark Rowe.
3107
3108         Remove modelines.
3109
3110         * WebCore.pro:
3111         * bridge/testbindings.cpp:
3112         * dom/DocPtr.h:
3113         * loader/SubstituteData.h:
3114         * page/Chrome.cpp:
3115         * page/Chrome.h:
3116         * page/ChromeClient.h:
3117         * page/Frame.h:
3118         * page/FrameLoadRequest.h:
3119         * page/FrameTree.cpp:
3120         * page/FrameTree.h:
3121         * page/Page.h:
3122         * page/mac/ChromeMac.mm:
3123         * platform/network/HTTPHeaderMap.h:
3124         * platform/network/ResourceErrorBase.cpp:
3125         * platform/network/ResourceErrorBase.h:
3126         * platform/network/ResourceHandleInternal.h:
3127         * platform/network/ResourceRequestBase.cpp:
3128         * platform/network/ResourceRequestBase.h:
3129         * platform/network/ResourceResponseBase.cpp:
3130         * platform/network/ResourceResponseBase.h:
3131         * platform/network/cf/ResourceError.h:
3132         * platform/network/cf/ResourceRequest.h:
3133         * platform/network/cf/ResourceRequestCFNet.h:
3134         * platform/network/cf/ResourceResponse.h:
3135         * platform/network/cf/ResourceResponseCFNet.h:
3136         * platform/network/curl/ResourceError.h:
3137         * platform/network/curl/ResourceRequest.h:
3138         * platform/network/curl/ResourceResponse.h:
3139         * platform/network/mac/ResourceError.h:
3140         * platform/network/mac/ResourceErrorMac.mm:
3141         * platform/network/mac/ResourceRequest.h:
3142         * platform/network/mac/ResourceRequestMac.mm:
3143         * platform/network/mac/ResourceResponse.h:
3144         * platform/network/mac/ResourceResponseMac.mm:
3145         * platform/network/qt/ResourceError.h:
3146         * platform/network/qt/ResourceRequest.h:
3147         * platform/network/qt/ResourceResponse.h:
3148         * platform/network/soup/CookieJarSoup.cpp:
3149         * platform/network/soup/ResourceError.h:
3150         * platform/network/soup/ResourceRequest.h:
3151         * platform/network/soup/ResourceResponse.h:
3152
3153 2008-08-23  Dan Bernstein  <mitz@apple.com>
3154
3155         Reviewed by Dave Hyatt.
3156
3157         - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
3158
3159         Test: fast/table/vertical-align-baseline.html
3160
3161         * rendering/RenderTable.cpp:
3162         (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
3163         baseline of the first table row, if there is one, -1 otherwise.
3164         * rendering/RenderTable.h:
3165         * rendering/RenderTableCell.cpp:
3166         (WebCore::RenderTableCell::baselinePosition): Changed to follow the
3167         CSS2.1 definition of the baseline of a table cell.
3168         * rendering/RenderTableSection.cpp:
3169         (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
3170         the baseline of the first row in the section.
3171         * rendering/RenderTableSection.h:
3172
3173 2008-08-18  Jon Honeycutt  <jhoneycutt@apple.com>
3174
3175         Add SPI to make a Windows WebView transparent.
3176
3177         Reviewed by Dan Bernstein.
3178
3179         * platform/graphics/GraphicsContext.h: Add a parameter, hasAlpha, that
3180         determines whether the created context has an alpha channel.
3181         * platform/graphics/win/GraphicsContextCGWin.cpp:
3182         (WebCore::CGContextWithHDC):
3183
3184 2008-08-22  Timothy Hatcher  <timothy@apple.com>
3185
3186         Rolls out r35834 because it caused a regression in the Inspector's
3187         Console where some expressions always threw a syntax error.
3188
3189         https://bugs.webkit.org/show_bug.cgi?id=20487
3190
3191         * page/inspector/Console.js:
3192         (Console.prototype._evalInInspectedWindow): Removes parenthesis
3193         around the expression.
3194
3195 2008-08-22  Timothy Hatcher  <timothy@apple.com>
3196
3197         Makes getStyleProperty return a value for the overflow property
3198         when overflow-x and overflow-y are equal.
3199
3200         https://bugs.webkit.org/show_bug.cgi?id=20485
3201
3202         Reviewed by Dan Bernstein.
3203
3204         Test: fast/css/overflow-property.html
3205
3206         * css/CSSMutableStyleDeclaration.cpp:
3207         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
3208
3209 2008-08-22  Timothy Hatcher  <timothy@apple.com>
3210
3211         Fixes a bug where while editing in the Inspector the
3212         sidebar scroll position would jump to the top.
3213
3214         https://bugs.webkit.org/show_bug.cgi?id=20484
3215
3216         Reviewed by Darin Adler.
3217
3218         * page/inspector/treeoutline.js:
3219         (TreeOutline._removeChildren): Remove the offsetTop call that
3220         was forcing a layout, since layout causes scroll positions
3221         to be clamped to the new scrollHeight/Width. Layout will happen
3222         normally when needed.
3223
3224 2008-08-22  Kevin Ollivier  <kevino@theolliviers.com>
3225
3226         wx build fix. Add AccessibilityTable sources.
3227
3228         * WebCoreSources.bkl:
3229
3230 2008-08-21  Dan Bernstein  <mitz@apple.com>
3231
3232         Reviewed by Jon Honeycutt and Alexey Proskuryakov.
3233
3234         - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
3235
3236         Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
3237
3238         * platform/graphics/mac/SimpleFontDataMac.mm:
3239         (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
3240         ascent and 100% to its reported descent.
3241
3242 2008-08-21  Kalle Vahlman  <kalle.vahlman@movial.com>
3243
3244         Reviewed by Darin Adler.
3245
3246         https://bugs.webkit.org/show_bug.cgi?id=20267
3247         [GTK] Crash on some pages due to a plugin
3248
3249         Fix handling of badly formatted and empty plugin mime descriptions
3250
3251         * plugins/gtk/PluginPackageGtk.cpp:
3252         (WebCore::PluginPackage::fetchInfo):
3253
3254 2008-08-21  Kevin Watters  <kevinwatters@gmail.com>
3255
3256         Reviewed by Darin Adler.
3257
3258         Follow other ports (and IE) in ImageSourceWx.cpp never to return an
3259         animated GIF frame duration of less than 50ms.
3260
3261         * platform/graphics/wx/ImageSourceWx.cpp:
3262         (WebCore::ImageSource::frameDurationAtIndex):
3263
3264 2008-08-21  Maxime Britto  <britto@apple.com>
3265
3266         Reviewed by Kevin McCullough.
3267
3268         Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
3269         https://bugs.webkit.org/show_bug.cgi?id=20451
3270    
3271         rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
3272         When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
3273         This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
3274
3275         * page/EventHandler.cpp:
3276         (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
3277
3278         (WebCore::EventHandler::handleMousePressEvent): ditto
3279
3280 2008-08-21  Anthony Ricaud  <rik24d@gmail.com>
3281
3282         Small optimization for when the dividers in the Inspector's
3283         Resources panel are updated.
3284
3285         Reviewed by Tim Hatcher.
3286
3287         * page/inspector/ResourcesPanel.js:
3288         (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
3289         Combind a for loop and clone the divider element.
3290
3291 2008-08-21  Chris Marrin  <cmarrin@apple.com>
3292
3293         Allow 0 (without units) for Time eg. duration
3294         Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
3295
3296         Reviewed by Dave Hyatt.
3297
3298         Test: css1/units/zero-duration-without-units.html
3299
3300         * css/CSSParser.cpp:
3301         (WebCore::CSSParser::validUnit):
3302
3303 2008-08-21  Timothy Hatcher  <timothy@apple.com>
3304
3305         Make deleting all text while editing a DOM attribute in
3306         the Inspector delete the attribute. This also fixes
3307         an exception that would happen before.
3308
3309         https://bugs.webkit.org/show_bug.cgi?id=20472
3310
3311         Reviewed by Kevin McCullough.
3312
3313         * page/inspector/ElementsPanel.js:
3314         (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
3315         Don't check for hasAttributes on the parseElement, continuing
3316         through the function will correctly remove the attribute.
3317         If the parseElement is null, call _editingCancelled not
3318         editingCancelled, this fixes an exception.
3319
3320 2008-08-21  Timothy Hatcher  <timothy@apple.com>
3321
3322         Update the Inspector's Metrics pane when editing in
3323         the Styles pane. This makes sure the metrics shown
3324         always match what the Styles pane shows.
3325
3326         https://bugs.webkit.org/show_bug.cgi?id=20470
3327
3328         Reviewed by Kevin McCullough.
3329
3330         * page/inspector/ElementsPanel.js:
3331         (WebInspector.ElementsPanel): Add event listeners for
3332         the "style edited" and "style property toggled" events,
3333         so the Metrics pane is updated.
3334         (WebInspector.ElementsPanel.prototype._stylesPaneEdited):
3335         Update the Metrics pane.
3336         * page/inspector/StylesSidebarPane.js:
3337         (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
3338         Dispatch the "style property toggled" event.
3339         (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
3340         Dispatch the "style edited" event when the CSS text is restored.
3341         (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
3342         Dispatch the "style edited" event.
3343
3344 2008-08-21  Timothy Hatcher  <timothy@apple.com>
3345
3346         Make the Inspector's Metrics sidebar pane editable.
3347
3348         https://bugs.webkit.org/show_bug.cgi?id=17218
3349         rdar://problem/5732818
3350
3351         Reviewed by Kevin McCullough.
3352
3353         * page/inspector/ElementsPanel.js:
3354         (WebInspector.ElementsPanel): Add an event listener for
3355         the "metrics edited" event, so the Styles pane is updated.
3356         * page/inspector/MetricsSidebarPane.js:
3357         (WebInspector.MetricsSidebarPane.prototype.update): Remember the node
3358         so future updates work. Add a double click event listener for the
3359         metric values to start editing.
3360         (WebInspector.MetricsSidebarPane.prototype.startEditing):
3361         Call WebInspector.startEditing with some context.
3362         (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
3363         (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
3364         Set the user input on the elements inline style. Fire the
3365         "metrics edited" event.
3366
3367 2008-08-21  Steve Falkenburg  <sfalken@apple.com>
3368
3369         Fix a race condition in Windows timer code.
3370         Timer function could end up being called with a 0 timer, leading to a Windows exception.
3371         
3372         Don't post a timer message if one is already pending.
3373         
3374         Reviewed by Ada Chan.
3375
3376         * platform/win/SharedTimerWin.cpp:
3377         (WebCore::TimerWindowWndProc):
3378         (WebCore::clearTimer):
3379         (WebCore::queueTimerProc):
3380         (WebCore::setSharedTimerFireTime):
3381
3382 2008-08-21  Anthony Ricaud  <rik24d@gmail.com>
3383
3384         After trying to add the expression, try again with quotes for
3385         easier edition.
3386
3387         https://bugs.webkit.org/show_bug.cgi?id=20466
3388
3389         Reviewed by Tim Hatcher.
3390
3391         * page/inspector/ObjectPropertiesSection.js: Added an
3392         evaluateExpression function.
3393
3394 2008-08-21  Anthony Ricaud  <rik24d@gmail.com>
3395
3396         Perform Inspector searches on search event to clear results when
3397         clicking the cross to empty it. Delete the lastQuery when the field
3398         is emptied in order to perform the search if exactly the same query
3399         is entered next.
3400
3401         https://bugs.webkit.org/show_bug.cgi?id=20462
3402
3403         Reviewed by Tim Hatcher.
3404
3405         * page/inspector/inspector.js:
3406
3407 2008-08-21  Marco Barisione  <marco.barisione@collabora.co.uk>
3408
3409         Reviewed by Mark Rowe.
3410
3411         http://bugs.webkit.org/show_bug.cgi?id=19656
3412         [SOUP] The gio code should call didFail() instead of
3413         didFinishLoading() in case of error
3414
3415         In case of error call didFail() instead of didReceiveResponse() and
3416         didFinishLoading().
3417
3418         * platform/network/soup/ResourceHandleSoup.cpp:
3419         (WebCore::networkErrorForFile):
3420         (WebCore::readCallback):
3421         (WebCore::openCallback):
3422         (WebCore::queryInfoCallback):
3423
3424 2008-08-20  Mark Rowe  <mrowe@apple.com>
3425
3426         Reviewed by Jon Honeycutt.
3427
3428         Fix build failure.
3429
3430         * bridge/c/c_instance.cpp:
3431         (KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
3432         as that is what NPEnumerationFunctionPtr is declared as accepting.
3433
3434 2008-08-20  Mark Rowe  <mrowe@apple.com>
3435
3436         Reviewed by Dan Bernstein.
3437
3438         Build fix.  Handle kCGInterpolationMedium in switch statements if it is available.
3439
3440         * platform/graphics/GraphicsContext.h:
3441         (WebCore::):
3442         * platform/graphics/cg/GraphicsContextCG.cpp:
3443         (WebCore::GraphicsContext::setImageInterpolationQuality):
3444         (WebCore::GraphicsContext::imageInterpolationQuality):
3445
3446 2008-08-20  Dan Bernstein  <mitz@apple.com>
3447
3448         Rubber-stamped by John Sullivan.
3449
3450         - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
3451           rename related methods and variables accordingly.
3452
3453         * WebCore.base.exp:
3454         * page/FrameView.cpp:
3455         (WebCore::FrameViewPrivate::FrameViewPrivate):
3456         (WebCore::FrameView::shouldUpdateWhileOffscreen):
3457         (WebCore::FrameView::setShouldUpdateWhileOffscreen):
3458         * page/FrameView.h:
3459         * platform/ScrollView.h:
3460         * platform/mac/ScrollViewMac.mm:
3461         (WebCore::ScrollView::updateContents):
3462
3463 2008-08-20  Brady Eidson  <beidson@apple.com>
3464
3465         Reviewed by Mitzpettel
3466
3467         <rdar://problem/6163636> - Many images broken in Mail
3468
3469         This can be traced back to the preload scanner.  With that change, CachedResources are created a lot 
3470         sooner than before and confuse the WebArchive machinery.  
3471
3472         When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore 
3473         such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate 
3474         machinery and nothing is known about where the data will eventually come from.
3475
3476         * loader/DocumentLoader.cpp:
3477         (WebCore::DocumentLoader::subresource):  Ignore a CachedResource if its preloadResult is 
3478           CachedResource::PreloadReferenced.
3479
3480 2008-08-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3481
3482         Unreviewed compile fix
3483
3484         Catch up with the JSValue::type elimination.
3485
3486         * bridge/qt/qt_instance.cpp:
3487         (KJS::Bindings::QtRuntimeObjectImp::construct):
3488         (KJS::Bindings::QtInstance::defaultValue):
3489         * bridge/qt/qt_runtime.cpp:
3490         (KJS::Bindings::QtRuntimeConnectionMethod::call):
3491
3492 2008-08-20  Chris Teague  <chris.teague@gmail.com>
3493
3494         Reviewed by Mark Rowe.
3495
3496         Fix https://bugs.webkit.org/show_bug.cgi?id=20449
3497         Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
3498
3499         * ChangeLog:
3500         * loader/FrameLoader.cpp:
3501         (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
3502
3503 2008-08-20  Simon Fraser  <simon.fraser@apple.com>
3504
3505         Reviewed by Dave Hyatt
3506
3507         getComputedStyle() for webkitTransform should return a transform
3508         that does not have the transform origin baked into it.
3509         https://bugs.webkit.org/show_bug.cgi?id=20464
3510         
3511         Test: fast/css/getComputedStyle-transform.html
3512
3513         * css/CSSComputedStyleDeclaration.cpp:
3514         (WebCore::computedTransform):
3515         * rendering/style/RenderStyle.cpp:
3516         (WebCore::RenderStyle::applyTransform):
3517         * rendering/style/RenderStyle.h:
3518
3519 2008-08-20  Josh Aas  <joshmoz@gmail.com>
3520
3521         Reviewed and landed by Anders.
3522
3523         <rdar://problem/6163636> 
3524         rename NPCocoaEvent's "event" struct to "data" (20446)
3525         
3526         * bridge/npapi.h:
3527         (_NPCocoaEvent::):
3528
3529 2008-08-20  Beth Dakin  <bdakin@apple.com>
3530
3531         Reviewed by Darin Adler.
3532
3533         Fix for <rdar://problem/6145626> 
3534         This patch fixes a number of remaining problems getting 
3535         disconnected frames to work correctly with markAllMatchesForText() 
3536         and findString(). Details inline. 
3537
3538         This was a static helper function in Frame, but this patch requires 
3539         the same functionality in Editor, so I just added it as a function 
3540         on Node.
3541         * dom/Node.cpp:
3542         (WebCore::Node::isInShadowTree):
3543         * dom/Node.h:
3544
3545         * editing/Editor.cpp:
3546         (WebCore::Editor::insideVisibleArea): Returns false if 
3547         excludeFromTextSearch() is true.
3548
3549         In a normal (non-disconnected) frame, findString returns a range of 
3550         the document node if the text is not found in the frame. I changed 
3551         firstVisibleRange and lastVisibleRange to match that behavior when 
3552         the text is not found
3553         (WebCore::Editor::firstVisibleRange):
3554         (WebCore::Editor::lastVisibleRange):
3555
3556         Here are the bulk of the changes in the patch. A lot of text was 
3557         not being found in disconnected frames because I failed to account 
3558         for all of the possible problems associated with shadow trees. That 
3559         is fixed here.
3560         (WebCore::Editor::nextVisibleRange):
3561         * editing/Editor.h:
3562
3563         excludeFromTextSearch() is new. It allows a WebKit client to mark a 
3564         frame as not-text-searchable through SPI. 
3565         * WebCore.base.exp:
3566         * page/Frame.cpp:
3567         (WebCore::Frame::excludeFromTextSearch):
3568         (WebCore::Frame::setExcludeFromTextSearch):
3569         (WebCore::FramePrivate::FramePrivate):
3570         * page/Frame.h:
3571         * page/FramePrivate.h:
3572
3573         (WebCore::Frame::findString):
3574         (WebCore::Frame::markAllMatchesForText):  I kept running into an 
3575         assertion failure in paining code because of the forced paint on 
3576         empty visible rects.
3577
3578 2008-08-20  Timothy Hatcher  <timothy@apple.com>
3579
3580         Adds a positon box to the Inspector's Metrics sidebar
3581         pane. When an element is not statically positioned, there
3582         is now a position box that show top, right, bottom and
3583         left computed values.
3584
3585         Reviewed by Kevin McCullough.
3586
3587         * English.lproj/localizedStrings.js: Updated the strings.
3588         * page/inspector/MetricsSidebarPane.js:
3589         (WebInspector.MetricsSidebarPane.prototype.update):
3590         Renamed the boxPartValue function to createBoxPartElement
3591         and made it create the entire element. Made it understand
3592         how to get position style properties. Don't use the figure dash
3593         when 0px is used for positions, since the 0 is meaningful there.
3594         Instead use the figure dash when a position is auto.
3595         * page/inspector/inspector.css: Added a new rule for position.
3596
3597 2008-08-20  Chris Fleizach  <cfleizach@apple.com>
3598
3599         Reviewed by Beth Dakin
3600
3601         Qt build fix
3602
3603         * WebCore.pro:
3604
3605 2008-08-20  Dan Bernstein  <mitz@apple.com>
3606
3607         Reviewed by Anders Carlsson.
3608
3609         - avoid using a deprecated NSScroller method on Leopard
3610
3611         * platform/mac/PlatformScrollBarMac.mm:
3612         (WebCore::PlatformScrollbar::updateThumbPosition):
3613         (WebCore::PlatformScrollbar::updateThumbProportion):
3614
3615 2008-08-20  Jan Michael Alonzo  <jmalonzo@webkit.org>
3616
3617         Reviewed by Oliver Hunt.
3618
3619         Gtk build fix
3620
3621         * GNUmakefile.am:
3622         * page/AccessibilityTable.cpp: Change nil to 0
3623         (WebCore::AccessibilityTable::cellForColumnAndRow):
3624
3625 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
3626
3627         Reviewed by Geoff Garen.
3628
3629         Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
3630
3631         * ForwardingHeaders/kjs/JSLock.h: Added.
3632         * WebCore.vcproj/WebCore.vcproj:
3633         * bindings/js/GCController.cpp:
3634         (WebCore::collect):
3635         (WebCore::GCController::gcTimerFired):
3636         (WebCore::GCController::garbageCollectNow):
3637         * bindings/js/JSCustomSQLStatementCallback.cpp:
3638         (WebCore::JSCustomSQLStatementCallback::handleEvent):
3639         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3640         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
3641         * bindings/js/JSCustomSQLTransactionCallback.cpp:
3642         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
3643         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
3644         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
3645         * bindings/js/JSCustomVoidCallback.cpp:
3646         (WebCore::JSCustomVoidCallback::handleEvent):
3647         * bindings/js/JSCustomXPathNSResolver.cpp:
3648         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
3649         * bindings/js/JSDOMWindowBase.cpp:
3650         (WebCore::DOMWindowTimer::~DOMWindowTimer):
3651         (WebCore::JSDOMWindowBase::clear):
3652         (WebCore::JSDOMWindowBase::timerFired):
3653         * bindings/js/JSEventCustom.cpp:
3654         (WebCore::toJS):
3655         * bindings/js/JSEventListener.cpp:
3656         (WebCore::JSAbstractEventListener::handleEvent):
3657         * bindings/js/JSNSResolver.cpp:
3658         (WebCore::JSNSResolver::lookupNamespaceURI):
3659         * bindings/js/JSNodeFilterCondition.cpp:
3660         (WebCore::JSNodeFilterCondition::acceptNode):
3661         * bindings/js/ScheduledAction.cpp:
3662         (WebCore::ScheduledAction::execute):
3663         * bindings/js/ScriptController.cpp:
3664         (WebCore::ScriptController::evaluate):
3665         (WebCore::ScriptController::clearWindowShell):
3666         (WebCore::ScriptController::createHTMLEventHandler):
3667         (WebCore::ScriptController::createSVGEventHandler):
3668         (WebCore::ScriptController::initScript):
3669         (WebCore::ScriptController::updateDocument):
3670         (WebCore::ScriptController::bindingRootObject):
3671         (WebCore::ScriptController::windowScriptNPObject):
3672         (WebCore::ScriptController::createScriptObjectForPluginElement):
3673         (WebCore::ScriptController::clearScriptObjects):
3674         * bindings/js/ScriptControllerMac.mm:
3675         (WebCore::ScriptController::windowScriptObject):
3676         * bindings/objc/WebScriptObject.mm:
3677         (_didExecute):
3678         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3679         (-[WebScriptObject evaluateWebScript:]):
3680         (-[WebScriptObject setValue:forKey:]):
3681         (-[WebScriptObject valueForKey:]):
3682         (-[WebScriptObject removeWebScriptKey:]):
3683         (-[WebScriptObject stringRepresentation]):
3684         (-[WebScriptObject webScriptValueAtIndex:]):
3685         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
3686         (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
3687         * bridge/NP_jsobject.cpp:
3688         (_NPN_InvokeDefault):
3689         (_NPN_Invoke):
3690         (_NPN_Evaluate):
3691         (_NPN_GetProperty):
3692         (_NPN_SetProperty):
3693         (_NPN_RemoveProperty):
3694         (_NPN_HasProperty):
3695         (_NPN_HasMethod):
3696         (_NPN_Enumerate):
3697         * bridge/c/c_class.cpp:
3698         (KJS::Bindings::CClass::~CClass):
3699         (KJS::Bindings::CClass::methodsNamed):
3700         (KJS::Bindings::CClass::fieldNamed):
3701         * bridge/c/c_instance.cpp:
3702         (KJS::Bindings::CInstance::invokeMethod):
3703         (KJS::Bindings::CInstance::invokeDefaultMethod):
3704         (KJS::Bindings::CInstance::getPropertyNames):
3705         * bridge/c/c_runtime.cpp:
3706         (KJS::Bindings::CField::valueFromInstance):
3707         (KJS::Bindings::CField::setValueToInstance):
3708         * bridge/c/c_utility.cpp:
3709         (KJS::Bindings::convertValueToNPVariant):
3710         (KJS::Bindings::convertNPVariantToValue):
3711         * bridge/jni/jni_class.cpp:
3712         (JavaClass::JavaClass):
3713         (JavaClass::~JavaClass):
3714         * bridge/jni/jni_instance.cpp:
3715         (JavaInstance::stringValue):
3716         * bridge/jni/jni_jsobject.mm:
3717         (JavaJSObject::call):
3718         (JavaJSObject::eval):
3719         (JavaJSObject::getMember):
3720         (JavaJSObject::setMember):
3721         (JavaJSObject::removeMember):
3722         (JavaJSObject::getSlot):
3723         (JavaJSObject::setSlot):
3724         (JavaJSObject::toString):
3725         (JavaJSObject::convertValueToJObject):
3726         (JavaJSObject::convertJObjectToValue):
3727         * bridge/jni/jni_objc.mm:
3728         (KJS::Bindings::dispatchJNICall):
3729         * bridge/jni/jni_runtime.cpp:
3730         (appendClassName):
3731         (JavaMethod::signature):
3732         * bridge/jni/jni_runtime.h:
3733         (KJS::Bindings::JavaString::JavaString):
3734         (KJS::Bindings::JavaString::_commonInit):
3735         (KJS::Bindings::JavaString::~JavaString):
3736         (KJS::Bindings::JavaString::UTF8String):
3737         * bridge/jni/jni_utility.cpp:
3738         (KJS::Bindings::convertValueToJValue):
3739         * bridge/npruntime.cpp:
3740         (_NPN_GetStringIdentifier):
3741         * bridge/objc/objc_instance.mm:
3742         (ObjcInstance::moveGlobalExceptionToExecState):
3743         (ObjcInstance::invokeMethod):
3744         (ObjcInstance::invokeDefaultMethod):
3745         (ObjcInstance::setValueOfUndefinedField):
3746         (ObjcInstance::getValueOfUndefinedField):
3747         * bridge/objc/objc_runtime.mm:
3748         (ObjcField::valueFromInstance):
3749         (ObjcField::setValueToInstance):
3750         * bridge/objc/objc_utility.mm:
3751         (KJS::Bindings::convertValueToObjcValue):
3752         (KJS::Bindings::convertNSStringToString):
3753         (KJS::Bindings::convertObjcValueToValue):
3754         * bridge/qt/qt_instance.cpp:
3755         (KJS::Bindings::QtRuntimeObjectImp::removeFromCache):
3756         (KJS::Bindings::QtInstance::~QtInstance):
3757         (KJS::Bindings::QtInstance::getQtInstance):
3758         (KJS::Bindings::QtInstance::getRuntimeObject):
3759         * bridge/qt/qt_runtime.cpp:
3760         (KJS::Bindings::convertValueToQVariant):
3761         (KJS::Bindings::convertQVariantToValue):
3762         (KJS::Bindings::QtRuntimeMetaMethod::call):
3763         (KJS::Bindings::QtRuntimeConnectionMethod::call):
3764         (KJS::Bindings::QtConnectionObject::QtConnectionObject):
3765         (KJS::Bindings::QtConnectionObject::execute):
3766         * bridge/runtime.cpp:
3767         (KJS::Bindings::Instance::createRuntimeObject):
3768         * bridge/testbindings.cpp:
3769         (main):
3770         * bridge/testbindings.mm:
3771         (main):
3772         * bridge/testqtbindings.cpp:
3773         (main):
3774         * dom/Document.cpp:
3775         (WebCore::Document::~Document):
3776         * dom/Node.cpp:
3777         (WebCore::Node::setDocument):
3778         * history/CachedPage.cpp:
3779         (WebCore::CachedPage::CachedPage):
3780         (WebCore::CachedPage::restore):
3781         (WebCore::CachedPage::clear):
3782         * loader/FrameLoader.cpp:
3783         (WebCore::getString):
3784         * page/InspectorController.cpp:
3785         (WebCore::ConsoleMessage::ConsoleMessage):
3786         (WebCore::XMLHttpRequestResource::XMLHttpRequestResource):
3787         (WebCore::XMLHttpRequestResource::~XMLHttpRequestResource):
3788         (WebCore::getResourceDocumentNode):
3789         (WebCore::search):
3790         (WebCore::inspectedWindow):
3791         (WebCore::wrapCallback):
3792         (WebCore::currentCallFrame):
3793         (WebCore::profiles):
3794         (WebCore::InspectorController::focusNode):
3795         (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
3796         (WebCore::InspectorController::addDatabaseScriptResource):
3797         (WebCore::InspectorController::addScriptProfile):
3798         * page/JavaScriptCallFrame.cpp:
3799         (WebCore::JavaScriptCallFrame::evaluate):
3800         * page/JavaScriptProfileNode.cpp:
3801         (WebCore::getTotalTime):
3802         (WebCore::getSelfTime):
3803         (WebCore::getTotalPercent):
3804         (WebCore::getSelfPercent):
3805         (WebCore::getNumberOfCalls):
3806         (WebCore::getChildren):
3807         (WebCore::getVisible):
3808         * page/Page.cpp:
3809         * page/mac/FrameMac.mm:
3810         * plugins/PluginView.cpp:
3811         (WebCore::PluginView::start):
3812         (WebCore::getString):
3813         (WebCore::PluginView::performRequest):
3814         (WebCore::PluginView::bindingInstance):
3815         * plugins/gtk/PluginViewGtk.cpp:
3816         (WebCore::PluginView::paint):
3817         (WebCore::PluginView::handleKeyboardEvent):
3818         (WebCore::PluginView::handleMouseEvent):
3819         (WebCore::PluginView::setNPWindowRect):
3820         (WebCore::PluginView::stop):
3821         (WebCore::PluginView::init):
3822         * plugins/qt/PluginViewQt.cpp:
3823         (WebCore::PluginView::setNPWindowRect):
3824         (WebCore::PluginView::stop):
3825         (WebCore::PluginView::init):
3826         * plugins/win/PluginViewWin.cpp:
3827         (WebCore::PluginView::dispatchNPEvent):
3828         (WebCore::PluginView::handleKeyboardEvent):
3829         (WebCore::PluginView::handleMouseEvent):
3830         (WebCore::PluginView::setNPWindowRect):
3831         (WebCore::PluginView::stop):
3832         * xml/XMLHttpRequest.cpp:
3833         (WebCore::XMLHttpRequest::clearResponse):
3834         (WebCore::XMLHttpRequest::didFinishLoading):
3835         (WebCore::XMLHttpRequest::didReceiveData):
3836
3837 2008-08-19  Eric Seidel  <eric@webkit.org>
3838
3839         Reviewed by Geoff Garen.
3840
3841         Add the beginnings of Skia graphics support to WebCore
3842         as I try to begin the long process of un-forking the changes
3843         needed to WebCore to make Andriod's WebCore build.
3844
3845         I'll follow this up with actual *Skia.cpp files in a separate patch.
3846
3847         * platform/graphics/AffineTransform.h:
3848         * platform/graphics/FloatPoint.h:
3849         * platform/graphics/FloatRect.h:
3850         * platform/graphics/Gradient.h:
3851         * platform/graphics/GraphicsContext.h:
3852         * platform/graphics/Image.h:
3853         * platform/graphics/ImageBuffer.h:
3854         * platform/graphics/ImageSource.h:
3855         * platform/graphics/IntPoint.h:
3856         * platform/graphics/IntRect.h:
3857         * platform/graphics/Path.h:
3858         * platform/graphics/Pattern.h:
3859         * svg/graphics/SVGPaintServerPattern.h:
3860         * svg/graphics/SVGPaintServerSolid.h:
3861
3862 2008-08-19  Steve Falkenburg  <sfalken@apple.com>
3863
3864         Fix Windows build more.
3865
3866         * WebCore.vcproj/WebCore.vcproj:
3867
3868 2008-08-19  Steve Falkenburg  <sfalken@apple.com>
3869
3870         Fix Windows build.
3871
3872         * page/AccessibilityRenderObject.cpp:
3873         (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
3874
3875 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
3876
3877         Reviewed by Beth Dakin.
3878
3879         <rdar://problem/4003764> Expose tables as AXTables
3880  
3881         Tests: accessibility/table-attributes.html
3882                accessibility/table-cell-spans.html
3883                accessibility/table-cells.html
3884                accessibility/table-detection.html
3885                accessibility/table-sections.html
3886                accessibility/table-with-rules.html
3887
3888         * WebCore.xcodeproj/project.pbxproj:
3889         * page/AXObjectCache.cpp:
3890         (WebCore::AXObjectCache::get):
3891         * page/AccessibilityObject.h:
3892         (WebCore::):
3893         (WebCore::AccessibilityObject::isDataTable):
3894         (WebCore::AccessibilityObject::isTableRow):
3895         (WebCore::AccessibilityObject::isTableColumn):
3896         (WebCore::AccessibilityObject::isTableCell):
3897         * page/AccessibilityRenderObject.cpp:
3898         (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
3899         * page/AccessibilityTable.cpp: Added.
3900         (WebCore::AccessibilityTable::AccessibilityTable):
3901         (WebCore::AccessibilityTable::~AccessibilityTable):
3902         (WebCore::AccessibilityTable::create):
3903         (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
3904         (WebCore::AccessibilityTable::clearChildren):
3905         (WebCore::AccessibilityTable::addChildren):
3906         (WebCore::AccessibilityTable::headerContainer):
3907         (WebCore::AccessibilityTable::columns):
3908         (WebCore::AccessibilityTable::rows):
3909         (WebCore::AccessibilityTable::rowHeaders):
3910         (WebCore::AccessibilityTable::columnHeaders):
3911         (WebCore::AccessibilityTable::cells):
3912         (WebCore::AccessibilityTable::columnCount):
3913         (WebCore::AccessibilityTable::rowCount):
3914         (WebCore::AccessibilityTable::cellForColumnAndRow):
3915         (WebCore::AccessibilityTable::roleValue):
3916         (WebCore::AccessibilityTable::accessibilityIsIgnored):
3917         (WebCore::AccessibilityTable::title):
3918         (WebCore::AccessibilityTable::isDataTable):
3919         * page/AccessibilityTable.h: Added.
3920         * page/AccessibilityTableCell.cpp: Added.
3921         (WebCore::AccessibilityTableCell::AccessibilityTableCell):
3922         (WebCore::AccessibilityTableCell::~AccessibilityTableCell):
3923         (WebCore::AccessibilityTableCell::create):
3924         (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
3925         (WebCore::AccessibilityTableCell::rowIndexRange):
3926         (WebCore::AccessibilityTableCell::columnIndexRange):
3927         * page/AccessibilityTableCell.h: Added.
3928         (WebCore::AccessibilityTableCell::isTableCell):
3929         (WebCore::AccessibilityTableCell::roleValue):
3930         * page/AccessibilityTableColumn.cpp: Added.
3931         (WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
3932         (WebCore::AccessibilityTableColumn::~AccessibilityTableColumn):
3933         (WebCore::AccessibilityTableColumn::create):
3934         (WebCore::AccessibilityTableColumn::setParentTable):
3935         (WebCore::AccessibilityTableColumn::elementRect):
3936         (WebCore::AccessibilityTableColumn::size):
3937         (WebCore::AccessibilityTableColumn::children):
3938         (WebCore::AccessibilityTableColumn::headerObject):
3939         (WebCore::AccessibilityTableColumn::headerObjectForSection):
3940         (WebCore::AccessibilityTableColumn::addChildren):
3941         * page/AccessibilityTableColumn.h: Added.
3942         (WebCore::AccessibilityTableColumn::parentObject):
3943         (WebCore::AccessibilityTableColumn::roleValue):
3944         (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
3945         (WebCore::AccessibilityTableColumn::isTableColumn):
3946         (WebCore::AccessibilityTableColumn::setColumnIndex):
3947         (WebCore::AccessibilityTableColumn::columnIndex):
3948         * page/AccessibilityTableHeaderContainer.cpp: Added.
3949         (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
3950         (WebCore::AccessibilityTableHeaderContainer::~AccessibilityTableHeaderContainer):
3951         (WebCore::AccessibilityTableHeaderContainer::create):
3952         (WebCore::AccessibilityTableHeaderContainer::children):
3953         (WebCore::AccessibilityTableHeaderContainer::elementRect):
3954         (WebCore::AccessibilityTableHeaderContainer::size):
3955         (WebCore::AccessibilityTableHeaderContainer::addChildren):
3956         * page/AccessibilityTableHeaderContainer.h: Added.
3957         (WebCore::AccessibilityTableHeaderContainer::roleValue):
3958         (WebCore::AccessibilityTableHeaderContainer::setParentTable):
3959         (WebCore::AccessibilityTableHeaderContainer::parentObject):
3960         (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
3961         * page/AccessibilityTableRow.cpp: Added.
3962         (WebCore::AccessibilityTableRow::AccessibilityTableRow):
3963         (WebCore::AccessibilityTableRow::~AccessibilityTableRow):
3964         (WebCore::AccessibilityTableRow::create):
3965         (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
3966         (WebCore::AccessibilityTableRow::headerObject):
3967         * page/AccessibilityTableRow.h: Added.
3968         (WebCore::AccessibilityTableRow::isTableRow):
3969         (WebCore::AccessibilityTableRow::roleValue):
3970         (WebCore::AccessibilityTableRow::setRowIndex):
3971         (WebCore::AccessibilityTableRow::rowIndex):
3972         * page/mac/AccessibilityObjectWrapper.mm:
3973         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
3974         (RoleEntry::):
3975         (-[AccessibilityObjectWrapper roleDescription]):
3976         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
3977         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
3978         (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
3979
3980 2008-08-19  Steve Falkenburg  <sfalken@apple.com>
3981
3982         Build fix.
3983         Add buildfailed support to stop builds early (preventing inaccurate error messages).
3984         Add missing post-build rule to Release.
3985
3986         * WebCore.vcproj/QTMovieWin.vcproj:
3987
3988 2008-08-19  Keishi Hattori  <casey.hattori@gmail.com>
3989
3990         Added support for console.count in the inspector.
3991
3992         Reviewed by Geoff Garen.
3993
3994         * page/Console.cpp:
3995         (WebCore::Console::count):
3996         * page/Console.h:
3997         * page/Console.idl: Added console.count.
3998         * page/InspectorController.cpp:
3999         (WebCore::InspectorController::didCommitLoad): Clears m_counts.
4000         (WebCore::InspectorController::count): Updates the count number
4001         sing "title@source:line" as the identifier, and adds a
4002         message to the console.
4003         * page/InspectorController.h: Added m_counts.
4004
4005 2008-08-19  Keishi Hattori  <casey.hattori@gmail.com>
4006
4007         Clear console.time timers when changing page.
4008
4009         Reviewed by Geoff Garen.
4010
4011         * page/InspectorController.cpp:
4012         (WebCore::InspectorController::didCommitLoad):
4013
4014 2008-08-19  Eric Carlson  <eric.carlson@apple.com>
4015
4016         Reviewed by Adele.
4017
4018         Fix for <rdar://problem/6154695> Full-page movies flicker while playing
4019         https://bugs.webkit.org/show_bug.cgi?id=20404
4020
4021         Ignore setVisible() when visibility doesn't change.
4022
4023         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
4024         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
4025         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
4026         (WebCore::MediaPlayerPrivate::setVisible):
4027
4028 2008-08-19  Timothy Hatcher  <timothy@apple.com>
4029
4030         Fixes a bug in the Profile view where switching sort order, then
4031         switching from heavy to tree mode would show the tree in the
4032         previous sort order.
4033
4034         https://bugs.webkit.org/show_bug.cgi?id=20441
4035
4036         Reviewed by Kevin McCullough.
4037
4038         * page/inspector/ProfileView.js:
4039         (WebInspector.ProfileView.prototype._changeView): Call _sortProfile
4040         on the next profile before assigning it to this.profile.
4041         (WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
4042         (WebInspector.ProfileView.prototype._sortProfile): Moves from
4043         _sortData and takes a profile argument. If the profile passed in
4044         matches the this.profile, then call refresh.
4045
4046 2008-08-18  Timothy Hatcher  <timothy@apple.com>
4047
4048         Changed the default sort order now that heavy view is the default.
4049         Also fixes a bug where the heavy profile was not sorted at first.
4050
4051         https://bugs.webkit.org/show_bug.cgi?id=20440
4052
4053         Reviewed by Kevin McCullough.
4054
4055         * page/inspector/ProfileView.js:
4056         (WebInspector.ProfileView): Changed the default sort column. Also assign
4057         heavyProfile to profile, so the sortSelfTimeDescending call happens
4058         on the heavy profile before assigning to this.profile.
4059
4060 2008-08-18  Timothy Hatcher  <timothy@apple.com>
4061
4062         Add support for editing DOM properties and scope variables by double
4063         clicking a property to enter edit mode.
4064
4065         https://bugs.webkit.org/show_bug.cgi?id=20415
4066
4067         Reviewed by Kevin McCullough.
4068
4069         * page/inspector/ObjectPropertiesSection.js:
4070         (WebInspector.ObjectPropertiesSection): Set editable to true by default.
4071         (WebInspector.ObjectPropertiesSection.prototype.onpopulate):
4072         Factored out code into update, and calls update.
4073         (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
4074         Call removeChildren since this method can be called multiple times now.
4075         (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
4076         gets made later in onattach.
4077         (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
4078         if shouldRefreshChildren is true. Call removeChildren since this method can be
4079         called multiple times now.
4080         (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
4081         (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
4082         (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
4083         this element (code moved from the constructor.)
4084         (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
4085         sibling property elements.
4086         (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
4087         WebInspector.startEditing after rememebring some context.
4088         (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
4089         for the list element, since it might have scrolled during editing.
4090         (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
4091         then restore the state from the context. Then call update to restore the title.
4092         (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
4093         if the user input and the previous input are the same. Call editingEnded, then call applyExpression
4094         to commit the user input.
4095         (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
4096         and stores the result on the object for the property name of this element. If the expression is
4097         empty, delete the property and remove the tree element.
4098         * page/inspector/ScopeChainSidebarPane.js:
4099         (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
4100         property on each ObjectPropertiesSection.
4101         (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
4102         since it is now implemented.
4103         * page/inspector/ScriptsPanel.js:
4104         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
4105         that defaults to true if omitted. It specifies whether to call update on the scope chain.
4106         * page/inspector/inspector.css: New styles.
4107         * page/inspector/treeoutline.js:
4108         (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
4109         change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
4110
4111 2008-08-18  Timothy Hatcher  <timothy@apple.com>
4112
4113         Surround the expression to be evaluated in parenthesis so the
4114         result of the eval is the result of the whole expression not
4115         the last potential sub-expression. So evaluating {x: 123}
4116         will show the Object not 123.
4117
4118         https://bugs.webkit.org/show_bug.cgi?id=20428
4119
4120         Reviewed by Kevin McCullough.
4121
4122         * page/inspector/Console.js:
4123         (Console.prototype._evalInInspectedWindow): Add parenthesis
4124         around the expression. And add couple comments.
4125
4126 2008-08-19 Kevin McCullough <kmccullough@apple.com>
4127
4128         Reviewed by Geoff.
4129
4130         -Implement a page() function to extract a common code pattern.
4131
4132         * WebCore.xcodeproj/project.pbxproj:
4133         * page/Console.cpp:
4134         (WebCore::Console::addMessage):
4135         (WebCore::Console::error):
4136         (WebCore::Console::info):
4137         (WebCore::Console::log):
4138         (WebCore::Console::dir):
4139         (WebCore::Console::assertCondition):
4140         (WebCore::Console::time):
4141         (WebCore::Console::timeEnd):
4142         (WebCore::Console::group):
4143         (WebCore::Console::groupEnd):
4144         (WebCore::Console::finishedProfiling):
4145         (WebCore::Console::warn):
4146         (WebCore::Console::framePage):
4147         * page/Console.h:
4148
4149 2008-08-12  Darin Adler  <darin@apple.com>
4150
4151         Reviewed by Geoff.
4152
4153         - eliminate JSValue::type()
4154
4155         * bridge/c/c_instance.cpp:
4156         (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
4157         argument instead of JSType argument. Removed unneeded code to handle
4158         boolean, since that's never passed.
4159         * bridge/c/c_instance.h: Ditto.
4160
4161         * bridge/c/c_utility.cpp:
4162         (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
4163         instead of JSValue::type(). Removed unneeded code to handle
4164         "unspecified".
4165
4166         * bridge/jni/jni_instance.cpp:
4167         (JavaInstance::defaultValue): Take PreferredPrimitiveType argument
4168         instead of JSType argument. Removed unneeded code to handle boolean.
4169         * bridge/jni/jni_instance.h: Ditto.
4170
4171         * bridge/jni/jni_jsobject.mm:
4172         (JavaJSObject::convertValueToJObject): Use JSValue::is functions
4173         instead of JSValue::type().
4174
4175         * bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
4176         instead of JSType argument. Removed unused argument.
4177         * bridge/objc/objc_instance.mm:
4178         (ObjcInstance::getValueOfUndefinedField): Removed unused argument.
4179         (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
4180         instead of JSType argument. Removed unneeded code to handle boolean
4181         and another dead code path for unknown types.
4182
4183         * bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
4184         instead of JSType argument. Removed override of type() that caused
4185         the fallback object to return "UndefinedType" when there is no
4186         invokeUndefinedMethodFromWebScript:withArguments: method defined.
4187         That didn't accomplish much, since most checks for undefined don't
4188         ever call type().
4189         * bridge/objc/objc_runtime.mm:
4190         (ObjcFallbackObjectImp::defaultValue): Ditto.
4191
4192         * bridge/qt/qt_instance.cpp:
4193         (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
4194         argument instead of JSType argument. Removed unneeded code to handle
4195         boolean.
4196         * bridge/qt/qt_instance.h: Ditto.
4197
4198         * bridge/runtime.h:
4199         (KJS::Bindings::Instance::getValueOfUndefinedField): Removed
4200         unsed argument.
4201         * bridge/runtime_object.cpp:
4202         (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
4203         argument instead of JSType argument.
4204         * bridge/runtime_object.h: Ditto.
4205
4206 2008-08-18  Maxime Britto  <britto@apple.com>
4207
4208         Reviewed by Adele.
4209
4210         <rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
4211         Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
4212         We shouldn't be able to create another window while we are in pan scrolling.
4213         Other browsers behaviors :
4214           FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
4215           IE7 : Keys are not disabled but stops immediately the panning.
4216         This patch matches FF3 behavior by disabling every key but the esc key.
4217
4218         * page/EventHandler.cpp:
4219         (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
4220         (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
4221
4222 2008-08-18  Dan Bernstein  <mitz@apple.com>
4223
4224         Reviewed by Dave Hyatt.
4225
4226         - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
4227
4228         Test: fast/replaced/max-width-percent.html
4229
4230         Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
4231         When false, max-width is not factored into the
4232         calculation.
4233         Changed RenderReplaced and subclasses' calcPrefWidths() to call
4234         calcReplacedWidth(false) and then apply max-width only if it has a
4235         fixed, positive value.
4236
4237         * rendering/RenderBox.cpp:
4238         (WebCore::RenderBox::calcReplacedWidth):
4239         * rendering/RenderBox.h:
4240         * rendering/RenderImage.cpp:
4241         (WebCore::RenderImage::calcReplacedWidth):
4242         (WebCore::RenderImage::calcPrefWidths): 
4243         * rendering/RenderImage.h:
4244         * rendering/RenderReplaced.cpp:
4245         (WebCore::RenderReplaced::calcPrefWidths):
4246         * rendering/RenderSVGRoot.cpp:
4247         (WebCore::RenderSVGRoot::calcPrefWidths):
4248         * rendering/RenderVideo.cpp:
4249         (WebCore::RenderVideo::calcReplacedWidth):
4250         (WebCore::RenderVideo::calcPrefWidths):
4251         * rendering/RenderVideo.h: