c34353933c5bac77695b137203f690d1ac0b6f76
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
2
3         Windows build fix
4
5         * platform/network/cf/SocketStreamHandleCFNet.cpp:
6         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
7         avoiding a sign mismatch warning.
8
9 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
10
11         Release build fix.
12
13         * platform/network/cf/SocketStreamHandleCFNet.cpp:
14         (WebCore::SocketStreamHandle::readStreamCallback):
15         (WebCore::SocketStreamHandle::writeStreamCallback):
16         Use ASSERT_UNUSED for unused stream parameter.
17
18 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
19
20         Reviewed by Darin Adler.
21
22         https://bugs.webkit.org/show_bug.cgi?id=31441
23         Implement SocketStreamHandleCFNet
24
25         Existing WebSocket tests now pass on Mac. No proxy support yet.
26
27         * platform/network/SocketStreamHandleClient.h:
28         * platform/network/cf/SocketStreamHandle.h:
29         (WebCore::SocketStreamHandle::shouldUseSSL):
30         (WebCore::SocketStreamHandle::refAuthenticationClient):
31         (WebCore::SocketStreamHandle::derefAuthenticationClient):
32         (WebCore::SocketStreamHandle::):
33         * platform/network/cf/SocketStreamHandleCFNet.cpp:
34         (WebCore::SocketStreamHandle::SocketStreamHandle):
35         (WebCore::SocketStreamHandle::chooseProxy):
36         (WebCore::SocketStreamHandle::createStreams):
37         (WebCore::SocketStreamHandle::copyCFStreamDescription):
38         (WebCore::SocketStreamHandle::readStreamCallback):
39         (WebCore::SocketStreamHandle::writeStreamCallback):
40         (WebCore::SocketStreamHandle::~SocketStreamHandle):
41         (WebCore::SocketStreamHandle::platformSend):
42         (WebCore::SocketStreamHandle::platformClose):
43         (WebCore::SocketStreamHandle::receivedCredential):
44         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
45         (WebCore::SocketStreamHandle::receivedCancellation):
46
47 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
48
49         Reviewed by Timothy Hatcher.
50
51         Web Inspector: preload status bar button glyphs
52         in order to prevent them from flickering (take 2).
53
54         https://bugs.webkit.org/show_bug.cgi?id=31439
55
56         * inspector/front-end/inspector.js:
57         (preloadImages):
58
59 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
60
61         Reviewed by Adam Barth.
62
63         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
64         Rolling back r50890.
65
66         https://bugs.webkit.org/show_bug.cgi?id=31467
67
68         * bindings/v8/V8Proxy.cpp:
69         (WebCore::V8Proxy::canAccessPrivate):
70
71 2009-11-13  Dirk Schulze  <krit@webkit.org>
72
73         Reviewed by Gustavo Noronha.
74
75         [CAIRO] shadow support for Canvas and SVG
76         [https://bugs.webkit.org/show_bug.cgi?id=30960]
77         
78         This is the fix of a regression, caused by the shadow patch
79         from the bug above. Reinserted the save and restore calls
80         that were accidently removed by the previous patch.
81
82         * platform/graphics/cairo/GraphicsContextCairo.cpp:
83         (WebCore::setPlatformFill):
84         (WebCore::setPlatformStroke):
85
86 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
87
88         Not reviewed. Reverting r50908 since it makes inspector tests
89         time out.
90
91         https://bugs.webkit.org/show_bug.cgi?id=31439
92
93         * inspector/front-end/inspector.js:
94
95 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
96
97         Reviewed by Timothy Hatcher.
98
99         Enable 'console.profile()' and 'console.profileEnd()'
100         regardless of JAVASCRIPT_DEBUGGER.
101
102         https://bugs.webkit.org/show_bug.cgi?id=31293
103
104         * WebCore.gypi:
105         * bindings/js/JSConsoleCustom.cpp:
106         (WebCore::JSConsole::profile):
107         (WebCore::JSConsole::profileEnd):
108         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
109         (WebCore::CALLBACK_FUNC_DECL):
110         * bindings/v8/custom/V8CustomBinding.h:
111         * page/Console.idl:
112
113 2009-11-12  David Levin  <levin@chromium.org>
114
115         Reviewed by NOBODY.
116
117         Chromium build fix.
118
119         * bindings/v8/ScriptController.h:
120         (WebCore::ScriptController::evaluateInWorld): Add a dummy
121          method which isn't called in chromium to make things compile.
122
123 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
124
125         Reviewed by Adam Barth.
126         
127         The document-open.html test was flaky at times. The test invokes the layout test plugin
128         which in its destroy stream handler opens a new document. This basically tears down the
129         stream and the associated plugin instance, which causes a crash when the plugin stream
130         dereferences an invalid m_client pointer which points to the PluginView instance which
131         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
132         and check for the same.
133        
134         https://bugs.webkit.org/show_bug.cgi?id=31067
135
136         * plugins/PluginStream.cpp:
137         (WebCore::PluginStream::stop):
138         (WebCore::PluginStream::destroyStream):
139
140 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
141
142         Reviewed by Dimitri Glazkov.
143
144         Renaming some parameters passed to DB-related methods to better
145         indicate their purpose.
146
147         https://bugs.webkit.org/show_bug.cgi?id=31449
148
149         * platform/chromium/ChromiumBridge.h:
150
151 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
152
153         Reviewed by Dan Bernstein.
154
155         Transformed reflected elements are clipped inside element with opacity
156         https://bugs.webkit.org/show_bug.cgi?id=30957
157         
158         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
159         each clip rect into painting space before taking the unions. This, however, did not work
160         correctly with combinations of reflections and transforms. Fixed by unioning the
161         clipRect and mapping through transforms along the way.
162         
163         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
164         where the transparency layers are.
165
166         Test: fast/reflections/opacity-reflection-transform.html
167
168         * rendering/RenderLayer.cpp:
169         (WebCore::expandClipRectForDescendantsAndReflection):
170         (WebCore::transparencyClipBox):
171         (WebCore::RenderLayer::beginTransparencyLayers):
172
173 2009-11-12  Adam Barth  <abarth@webkit.org>
174
175         Reviewed by Darin Fisher.
176
177         Improve SecurityOrigin::toString comment
178         https://bugs.webkit.org/show_bug.cgi?id=31041
179
180         * page/SecurityOrigin.h:
181
182 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
183
184         Reviewed by Darin Adler.
185
186         externalRepresentation should take Frame as the argument
187         https://bugs.webkit.org/show_bug.cgi?id=31393
188
189         No new tests as this is just a refactoring.
190
191         * WebCore.base.exp:
192         * rendering/RenderTreeAsText.cpp:
193         (WebCore::externalRepresentation):
194         * rendering/RenderTreeAsText.h:
195
196 2009-11-12  Ben Murdoch  <benm@google.com>
197
198         Reviewed by Dimitri Glazkov.
199
200         [Android] The Android specific files in page/Android are out of date.
201         https://bugs.webkit.org/show_bug.cgi?id=31437
202
203         No tests required.
204
205         * page/android/DragControllerAndroid.cpp:
206         (WebCore::DragController::dragOperation): Added.
207         (WebCore::DragController::cleanupAfterSystemDrag):
208         * page/android/EventHandlerAndroid.cpp:
209         (WebCore::EventHandler::accessKeyModifiers): Added.
210         * page/android/InspectorControllerAndroid.cpp: Removed.
211
212 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
213
214         Reviewed by Simon Fraser.
215
216         [CAIRO] shadow support for Canvas and SVG.
217         [https://bugs.webkit.org/show_bug.cgi?id=30960]
218
219         Implement Canvas/SVG shadow support for Cairo.  This patch
220         uses the filter code from SVG Filters.  That means that it is
221         necessary to activate filters to see the shadows.
222
223         Test: fast/canvas/canvas-shadow.html
224
225         * GNUmakefile.am:
226         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
227         * platform/graphics/GraphicsContext.h:
228         * platform/graphics/cairo/GraphicsContextCairo.cpp:
229         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
230         (WebCore::setPlatformFill):
231         (WebCore::setPlatformStroke):
232         (WebCore::copyContextProperties):
233         (WebCore::drawPathShadow):
234         (WebCore::GraphicsContext::fillPath):
235         (WebCore::GraphicsContext::strokePath):
236         (WebCore::GraphicsContext::drawPath):
237         (WebCore::GraphicsContext::setPlatformShadow):
238         (WebCore::GraphicsContext::createPlatformShadow):
239         * platform/graphics/cairo/ImageCairo.cpp:
240         (WebCore::BitmapImage::draw): Add filter effect.
241         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
242         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
243         * platform/graphics/filters/ImageBufferFilter.h: Added.
244         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
245         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
246
247 2009-11-12  Dmitry Titov  <dimich@chromium.org>
248
249         Reviewed by Alexey Proskuryakov.
250
251         Add postTaskToMainThread to ScriptExecutionContext.
252         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
253         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
254         contexts that live on the main thread.
255         https://bugs.webkit.org/show_bug.cgi?id=31427
256
257         No new tests - simply moving the code.
258
259         * dom/Document.cpp:
260         (WebCore::Document::postTask):
261         * dom/ScriptExecutionContext.cpp:
262         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
263         (WebCore::ScriptExecutionContextTaskTimer::fired):
264         (WebCore::PerformTaskData::PerformTaskData):
265         (WebCore::PerformTaskData::performTask):
266         (WebCore::ScriptExecutionContext::postTaskToMainThread):
267         * dom/ScriptExecutionContext.h:
268
269 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
270
271         Reviewed by Darin Adler.
272
273         Fix crash when removing compositing layers when GC is enabled
274         https://bugs.webkit.org/show_bug.cgi?id=31429
275
276         Workaround <rdar://problem/7390716> by special-casing the removal
277         of all sublayers when GC is enabled.
278
279         * platform/graphics/mac/GraphicsLayerCA.mm:
280         (WebCore::safeSetSublayers):
281         (WebCore::GraphicsLayerCA::updateSublayerList):
282         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
283
284 2009-11-12  Jens Alfke  <snej@chromium.org>
285
286         Reviewed by Dimitri Glazkov.
287
288         The last of the V8 binding optimizations.
289         - Replace string-valued element accessors with a shared getter/setter function.
290         - Change error handling flow of control to avoid extra branches and function calls.
291         https://bugs.webkit.org/show_bug.cgi?id=31443
292         
293         * bindings/scripts/CodeGeneratorV8.pm:
294         * bindings/v8/V8Binding.cpp:
295         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
296         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
297         * bindings/v8/V8Binding.h:
298
299 2009-11-12  Sam Weinig  <sam@webkit.org>
300
301         Reviewed by Oliver Hunt.
302
303         Fix for <rdar://problem/7267951>
304         Canvas methods should reject uses of NaN and Infinity.
305
306         Test: fast/canvas/canvas-with-illegal-args.html
307
308         * html/canvas/CanvasRenderingContext2D.cpp:
309         (WebCore::CanvasRenderingContext2D::scale):
310         (WebCore::CanvasRenderingContext2D::rotate):
311         (WebCore::CanvasRenderingContext2D::translate):
312         (WebCore::CanvasRenderingContext2D::transform):
313         (WebCore::CanvasRenderingContext2D::setTransform):
314
315 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
316
317         Reviewed by Timothy Hatcher.
318
319         Web Inspector: profile timeline panel, fix obvious problems.
320
321         https://bugs.webkit.org/show_bug.cgi?id=31432
322
323         * inspector/front-end/AbstractTimelinePanel.js:
324         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
325         * inspector/front-end/TimelinePanel.js:
326         (WebInspector.TimelinePanel.prototype._setWindowPosition):
327         (WebInspector.TimelineCalculator):
328         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
329         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
330         (WebInspector.TimelineCalculator.prototype.reset):
331         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
332         (WebInspector.TimelineCalculator.prototype.formatValue):
333         (WebInspector.TimelineGraph):
334         (WebInspector.TimelineGraph.prototype.refresh):
335         * inspector/front-end/utilities.js:
336         (Element.prototype.hasStyleClass):
337
338 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
339
340         Reviewed by Timothy Hatcher.
341
342         Web Inspector: preload status bar button glyphs
343         in order to prevent them from flickering.
344
345         https://bugs.webkit.org/show_bug.cgi?id=31439
346
347         * inspector/front-end/inspector.js:
348         (preloadImages):
349
350 2009-11-12  Adam Roben  <aroben@apple.com>
351
352         Replace worldIDs with world objects
353
354         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
355         user scripts/stylesheets and isolated worlds
356
357         Reviewed by Sam Weinig.
358
359         Covered by existing tests.
360
361         * WebCore.base.exp: Update exported symbols to match what now exists
362         and is needed by WebKit.
363
364         * bindings/js/ScheduledAction.cpp:
365         (WebCore::ScheduledAction::execute): Updated for function rename.
366
367         * bindings/js/ScriptController.cpp: Removed code that dealt with
368         worldIDs.
369         (WebCore::ScriptController::createWorld): Added. Returns a new world
370         suitable for use on the main thread.
371         (WebCore::ScriptController::executeScriptInWorld): Renamed from
372         executeScriptInIsolatedWorld, since this works just fine with a
373         "normal" world.
374
375         * bindings/js/ScriptController.h: Added createWorld, removed functions
376         that took worldIDs, renamed executeScriptInIsolatedWorld to
377         executeScriptInWorld.
378
379         * page/Frame.cpp:
380         (WebCore::Frame::injectUserScripts):
381         (WebCore::Frame::injectUserScriptsForWorld):
382         Updated for changes to UserScriptMap and ScriptController.
383
384         * page/Frame.h: Changed injectUserScriptsForWorld to take a
385         DOMWrapperWorld* instead of a worldID.
386
387         * page/PageGroup.cpp:
388         (WebCore::PageGroup::addUserScriptToWorld):
389         (WebCore::PageGroup::addUserStyleSheetToWorld):
390         (WebCore::PageGroup::removeUserScriptFromWorld):
391         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
392         (WebCore::PageGroup::removeUserScriptsFromWorld):
393         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
394         * page/PageGroup.h:
395         Changed these functions to take a DOMWrapperWorld* instead of a
396         worldID. Also updated for changes to UserScript and UserStyleSheet.
397
398         * page/UserScript.h:
399         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
400         never used.
401
402         * page/UserScriptTypes.h:
403         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
404         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
405         worldID as their key type.
406
407
408 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
409
410         Reviewed by Tim Hatcher.
411
412         Fixes <http://webkit.org/b/31260>.
413         Web Inspector: Main Resources Other than HTML are mis-detected.
414         
415         Even if the resource is a main resource, look at its CachedResource type, 
416         because it might be an image, stylesheet, or JavaScript file, and we
417         want to show them all correctly.
418
419         * inspector/InspectorResource.cpp:
420         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
421         (WebCore::InspectorResource::type): 
422         * inspector/InspectorResource.h:
423
424 2009-11-12  Jens Alfke  <snej@chromium.org>
425
426         Reviewed by Dimitri Glazkov.
427
428         Table-driven setup for V8 binding template callback functions. 100k in code savings.
429         https://bugs.webkit.org/show_bug.cgi?id=31420
430
431         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
432             to call configureTemplate().
433         * bindings/v8/V8Binding.cpp:
434         (WebCore::configureTemplate):  New function; does all the standard configuration work.
435         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
436         * bindings/v8/V8Binding.h:
437         * bindings/v8/V8Proxy.cpp:
438         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
439         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
440         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
441         * bindings/v8/V8Proxy.h:
442
443 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
444
445         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
446
447         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
448
449 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
450
451         Reviewed by Dan Bernstein.
452
453         <rdar://problem/7388969> Add DOM API for fullscreen video
454         
455         DOM API for fullscreen <video>.
456
457         Tests: media/media-fullscreen-inline.html
458                media/media-fullscreen-not-in-document.html
459
460         * dom/EventNames.h:
461             Add webkitbeginfullscreen and webkitendfullscreen.
462
463         * html/HTMLAttributeNames.in:
464             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
465
466         * html/HTMLMediaElement.cpp:
467         (WebCore::HTMLMediaElement::parseMappedAttribute):
468             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
469         (WebCore::HTMLMediaElement::enterFullscreen):
470             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
471             actually do enter fullscreen.
472         (WebCore::HTMLMediaElement::exitFullscreen):
473             Schedule webkitendfullscreenEvent event.
474         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
475         (WebCore::HTMLMediaElement::webkitExitFullScreen):
476         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
477         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
478             New, access to fullscreen properties and methods.
479
480         * html/HTMLMediaElement.h:
481         * html/HTMLMediaElement.idl:
482             Declare methods needed for fullscreen API.
483
484         * html/HTMLVideoElement.cpp:
485         (WebCore::HTMLVideoElement::supportsFullscreen):
486             Return false if a movie does not have video.
487
488         * page/DOMWindow.h:
489             Add webkitbeginfullscreen and webkitendfullscreen.
490
491 2009-11-12  Adam Barth  <abarth@webkit.org>
492
493         Reviewed by Dimitri Glazkov.
494
495         [Chromium] Sify compose button alerts error
496         https://bugs.webkit.org/show_bug.cgi?id=31394
497
498         Test: http/tests/security/calling-versus-current.html
499
500         We're supposed to use the calling context for security checks.  In JSC
501         land, this is the lexicalGlobalObject.
502
503         * bindings/v8/V8Proxy.cpp:
504         (WebCore::V8Proxy::canAccessPrivate):
505
506 2009-11-12  Daniel Bates  <dbates@webkit.org>
507
508         Reviewed by Darin Adler.
509
510         https://bugs.webkit.org/show_bug.cgi?id=30291
511
512         Fixes an issue where the returned drop effect is incorrect when
513         effectAllowed == "uninitialized".
514
515         According to section 7.9.2 of the HTML 5 spec.
516         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
517         when effectAllowed = "uninitialized" the resulting dropEffect should be the
518         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
519         other case.
520         
521         No test cases are included because we have an existing test case from
522         bug #24731.
523
524         * dom/Clipboard.cpp:
525         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
526
527 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
528
529         Reviewed by Timothy Hatcher.
530
531         Web Inspector: Do not highlight node on refresh.
532
533         https://bugs.webkit.org/show_bug.cgi?id=31419
534
535         * inspector/front-end/ElementsPanel.js:
536         (WebInspector.ElementsPanel.prototype.reset):
537
538 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
539
540         Reviewed by Timothy Hatcher.
541
542         Web Inspector: Minor timeline fixes.
543
544         https://bugs.webkit.org/show_bug.cgi?id=31417
545
546         * inspector/front-end/TimelinePanel.js:
547         (WebInspector.TimelinePanel.prototype._getRecordDetails):
548         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
549         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
550         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
551
552 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
553
554         SnowLeopard build fix.
555
556         Renamed initWithClient to initWithAuthenticationClient.
557
558         * platform/network/mac/AuthenticationMac.mm:
559         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
560         (WebCore::AuthenticationChallenge::setAuthenticationClient):
561
562 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
563
564         Reviewed by Darin Adler.
565
566         ARIA: add alert type roles
567         https://bugs.webkit.org/show_bug.cgi?id=31392
568
569         Test: platform/mac/accessibility/aria-alerts.html
570
571         * accessibility/AccessibilityObject.h:
572         * accessibility/AccessibilityRenderObject.cpp:
573         * accessibility/mac/AccessibilityObjectWrapper.mm:
574
575 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
576
577         Reviewed by Darin Adler.
578
579         https://bugs.webkit.org/show_bug.cgi?id=31386
580         Make Mac AuthenticationChallenge usable from cross-platform code
581
582         No change in behavior, so no tests.
583
584         * platform/network/ResourceHandle.cpp:
585         (WebCore::ResourceHandle::clearAuthentication):
586         * platform/network/ResourceHandleInternal.h:
587         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
588         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
589         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
590         is identical.
591
592         * platform/network/cf/AuthenticationChallenge.h:
593         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
594         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
595
596         * platform/network/cf/ResourceHandleCFNet.cpp:
597         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
598         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
599         be already set.
600
601         * platform/network/mac/AuthenticationChallenge.h:
602         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
603         best of my understanding.
604         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
605         confusion with "mac" and "web" challenges in ResourceHandleInternal.
606
607         * platform/network/mac/AuthenticationMac.mm:
608         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
609         making it possible to use the latter with NSURLAuthenticationChallenge.
610         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
611         m_nsChallenge renaming.
612         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
613         set it as sender (or unset, if client is null).
614
615         * platform/network/mac/ResourceHandleMac.mm:
616         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
617         authentication challenge sender.
618         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
619         authentication sheet.
620         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
621         using the new setAuthenticationClient() method.
622         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
623         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
624         the original Mac one, not the one we created for use with authentication sheet. I don't
625         know when a connection would cancel authentication in practice, so I haven't tested this.
626
627 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
628
629         Reviewed by Timothy Hatcher.
630
631         Web Inspector: breakpoint sidebar entries should allow click over entire list item
632         https://bugs.webkit.org/show_bug.cgi?id=31411
633
634         No new tests; no new functionality, small usability change. 
635
636         * inspector/front-end/BreakpointsSidebarPane.js:
637         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
638         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
639
640 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
641
642         Reviewed by Timothy Hatcher.
643
644         Web Inspector: breakpoints in named evals are not restored after a reload
645         https://bugs.webkit.org/show_bug.cgi?id=31375
646
647         Manual test added
648
649         * inspector/front-end/ScriptsPanel.js:
650         (WebInspector.ScriptsPanel.prototype.addScript):
651         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
652
653 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
654
655         Reviewed by Kenneth Rohde Christiansen.
656
657         Custom printing shrink factors
658         https://bugs.webkit.org/show_bug.cgi?id=29042
659
660         This reverts commit r49769. The public API for this needs to be reviewed
661         before its inclusion in Qt.
662
663         * page/PrintContext.cpp:
664         (WebCore::PrintContext::begin):
665         * page/Settings.cpp:
666         (WebCore::Settings::Settings):
667         * page/Settings.h:
668
669 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
670
671         Reviewed by Pavel Feldman.
672
673         Web Inspector: Resource errors/warnings not shown in the Resource tree.
674
675         Error/Warning bubbles are not displayed next to the resource in the 
676         Resources panel if those occur before the resource is attached to the tree.
677         https://bugs.webkit.org/show_bug.cgi?id=31404
678
679         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
680
681         * inspector/front-end/AbstractTimelinePanel.js:
682         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
683         * inspector/front-end/ResourcesPanel.js:
684         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
685
686 2009-11-12  Philippe Normand  <pnormand@igalia.com>
687
688         Reviewed by Jan Alonzo.
689
690         https://bugs.webkit.org/show_bug.cgi?id=31047
691         [GTK] Failing test media/video-played-ranges-1.html
692
693         Follow-up of r50726, don't block the UI thread when calling
694         gst_element_get_state(). Also fixed a compilation warning and some
695         static casts.
696
697         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
698         (WebCore::playbackPosition):
699         (WebCore::MediaPlayerPrivate::seek):
700         (WebCore::MediaPlayerPrivate::setRate):
701
702 2009-11-12  Philippe Normand  <pnormand@igalia.com>
703
704         Reviewed by Jan Alonzo.
705
706         https://bugs.webkit.org/show_bug.cgi?id=31047
707         [GTK] Failing test media/video-played-ranges-1.html
708
709         don't pause pipeline if already paused, same for play()
710
711         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
712         (WebCore::MediaPlayerPrivate::play):
713         (WebCore::MediaPlayerPrivate::pause):
714
715 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
716
717         Reviewed by David Levin.
718
719         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
720         Chromium too.
721         https://bugs.webkit.org/show_bug.cgi?id=31292
722
723         No new tests. (Corresponding test for Gtk+ is
724         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
725
726         * page/EventHandler.cpp:
727         * page/chromium/EventHandlerChromium.cpp:
728
729 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
730
731         Reviewed by Eric Seidel.
732
733         Prevent text inside a multi-column block from being split into columns.
734         
735         If the tentative height of a multi-column block was too small, we need to
736         expand the block height and try to layout again, in order to prevent text
737         from being split into different columns.
738
739         CSS Multicolumn text is split awkwardly
740         https://bugs.webkit.org/show_bug.cgi?id=22249
741
742         Test: fast/multicol/single-line.html
743
744         * rendering/RenderBlock.cpp:
745         (WebCore::RenderBlock::layoutColumns):
746         * rendering/RenderBlock.h:
747         * rendering/RenderLineBoxList.cpp:
748         (WebCore::RenderLineBoxList::paint):
749         * rendering/RenderView.h:
750         (WebCore::RenderView::setTruncatedAt):
751         (WebCore::RenderView::setMinimumColumnHeight):
752         (WebCore::RenderView::minimumColumnHeight):
753
754 2009-11-11  Kent Tamura  <tkent@chromium.org>
755
756         Reviewed by Darin Adler.
757
758         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
759         https://bugs.webkit.org/show_bug.cgi?id=31195
760
761         Test: fast/forms/input-file-re-render.html
762
763         * rendering/RenderFileUploadControl.cpp:
764         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
765
766 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
767
768         Reviewed by Dimitri Glazkov.
769
770         Fixing Chromium's POSIX VFS implementation, by adding the required
771         "used file descriptors" logic.
772
773         https://bugs.webkit.org/show_bug.cgi?id=31275
774
775         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
776
777 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
778
779         Reviewed by Oliver Hunt.
780
781         need to implement aria tree roles
782         https://bugs.webkit.org/show_bug.cgi?id=31284
783
784         Tests: platform/mac/accessibility/aria-multiselectable.html
785                platform/mac/accessibility/aria-tree.html
786
787         * accessibility/AccessibilityList.cpp:
788         (WebCore::AccessibilityList::accessibilityIsIgnored):
789         * accessibility/AccessibilityObject.cpp:
790         (WebCore::AccessibilityObject::ariaTreeRows):
791         (WebCore::AccessibilityObject::ariaTreeItemContent):
792         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
793         * accessibility/AccessibilityObject.h:
794         (WebCore::):
795         (WebCore::AccessibilityObject::isTree):
796         (WebCore::AccessibilityObject::isTreeItem):
797         (WebCore::AccessibilityObject::setIsExpanded):
798         (WebCore::AccessibilityObject::canSetExpandedAttribute):
799         (WebCore::AccessibilityObject::hierarchicalLevel):
800         (WebCore::AccessibilityObject::setSelectedRows):
801         (WebCore::AccessibilityObject::performDefaultAction):
802         * accessibility/AccessibilityRenderObject.cpp:
803         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
804         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
805         (WebCore::AccessibilityRenderObject::isExpanded):
806         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
807         (WebCore::AccessibilityRenderObject::elementAttributeValue):
808         (WebCore::AccessibilityRenderObject::setIsExpanded):
809         (WebCore::AccessibilityRenderObject::isSelected):
810         (WebCore::AccessibilityRenderObject::setSelected):
811         (WebCore::AccessibilityRenderObject::setSelectedRows):
812         (WebCore::createARIARoleMap):
813         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
814         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
815         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
816         (WebCore::AccessibilityRenderObject::selectedChildren):
817         * accessibility/AccessibilityRenderObject.h:
818         * accessibility/mac/AccessibilityObjectMac.mm:
819         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
820         * accessibility/mac/AccessibilityObjectWrapper.mm:
821         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
822         (RoleEntry::):
823         (-[AccessibilityObjectWrapper subrole]):
824         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
825         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
826         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
827         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
828         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
829         * html/HTMLAttributeNames.in:
830
831 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
832
833         Build fix after @r50760 with ENABLE_FILTERS.
834
835         * platform/graphics/filters/SourceAlpha.cpp:
836         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
837         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
838           to fillRect.
839
840 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
841
842         Reviewed by Alexey Proskuryakov.
843
844         Fix WebSocket frame parser of frame_type with high-order bit set.
845         https://bugs.webkit.org/show_bug.cgi?id=30668
846
847         If buffer is smaller than frame's length, it should break the loop
848         instead of reading next byte.
849
850         Tests: websocket/tests/frame-length-longer-than-buffer.html
851                websocket/tests/frame-length-skip.html
852
853         * websockets/WebSocketChannel.cpp:
854         (WebCore::WebSocketChannel::didReceiveData):
855
856 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
857
858         Reviewed by Adam Barth.
859
860         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
861         https://bugs.webkit.org/show_bug.cgi?id=31345
862
863         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
864
865         * platform/graphics/chromium/FontCustomPlatformData.cpp:
866         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
867         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
868         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
869
870 2009-11-11  Beth Dakin  <bdakin@apple.com>
871
872         Build fix. No review needed.
873
874         * platform/graphics/gtk/FontGtk.cpp:
875         (WebCore::Font::drawComplexText):
876
877 2009-11-11  Beth Dakin  <bdakin@apple.com>
878
879         Build fix. No review needed.
880
881         * platform/graphics/cairo/FontCairo.cpp:
882         (WebCore::Font::drawGlyphs):
883
884 2009-11-11  Beth Dakin  <bdakin@apple.com>
885
886         Windows build fix. No review needed. 
887
888         * platform/graphics/win/FontCGWin.cpp:
889         (WebCore::Font::drawGlyphs):
890
891 2009-11-11  Beth Dakin  <bdakin@apple.com>
892
893         Reviewed by Simon Fraser.
894
895         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
896         Make -webkit-color-correction work with shadows
897
898         From canvas, just send DeviceColorSpace to setShadow() for now. 
899         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
900         * html/canvas/CanvasRenderingContext2D.cpp:
901         (WebCore::CanvasRenderingContext2D::setShadow):
902         (WebCore::CanvasRenderingContext2D::applyShadow):
903
904         setShadow() and setPlatformShadow() now take a ColorSpace.
905         * platform/graphics/GraphicsContext.cpp:
906         (WebCore::GraphicsContext::setShadow):
907         * platform/graphics/GraphicsContext.h:
908         * platform/graphics/cg/GraphicsContextCG.cpp:
909         (WebCore::createCGColorWithColorSpace): New helper to create a 
910         color in a ColorSpace.
911         (WebCore::setCGFillColor): Call new helper.
912         (WebCore::setCGStrokeColor): Call new helper.
913         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
914         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
915         (WebCore::GraphicsContext::setPlatformShadow):
916
917         Send appropriate ColorSpace to setShadow().
918         * platform/graphics/mac/FontMac.mm:
919         (WebCore::Font::drawGlyphs):
920         * rendering/EllipsisBox.cpp:
921         (WebCore::EllipsisBox::paint):
922         * rendering/InlineFlowBox.cpp:
923         (WebCore::InlineFlowBox::paintTextDecorations):
924         * rendering/InlineTextBox.cpp:
925         (WebCore::paintTextWithShadows):
926         (WebCore::InlineTextBox::paintDecoration):
927         * rendering/RenderBoxModelObject.cpp:
928         (WebCore::RenderBoxModelObject::paintBoxShadow):
929         * rendering/SVGInlineTextBox.cpp:
930         (WebCore::SVGInlineTextBox::paintCharacters):
931         * rendering/SVGRenderSupport.cpp:
932         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
933
934         Attempt to keep ports building.
935         * platform/graphics/cairo/GraphicsContextCairo.cpp:
936         (WebCore::GraphicsContext::setPlatformShadow):
937         * platform/graphics/qt/GraphicsContextQt.cpp:
938         (WebCore::GraphicsContext::setPlatformShadow):
939         * platform/graphics/skia/GraphicsContextSkia.cpp:
940         (WebCore::GraphicsContext::setPlatformShadow):
941         * platform/graphics/wince/GraphicsContextWince.cpp:
942         (WebCore::GraphicsContext::setPlatformShadow):
943         * platform/graphics/wx/GraphicsContextWx.cpp:
944         (WebCore::GraphicsContext::setPlatformShadow):
945
946 2009-11-11  Kent Tamura  <tkent@chromium.org>
947
948         Reviewed by Darin Adler.
949
950         Print the file text of a file upload control in DumpRenderTree for ease of tests.
951         https://bugs.webkit.org/show_bug.cgi?id=31195
952
953         * rendering/RenderFileUploadControl.cpp:
954         (WebCore::RenderFileUploadControl::paintObject):
955         (WebCore::RenderFileUploadControl::fileTextValue):
956         * rendering/RenderFileUploadControl.h:
957         (WebCore::RenderFileUploadControl::isFileUploadControl):
958         (WebCore::toRenderFileUploadControl):
959         * rendering/RenderObject.h:
960         (WebCore::RenderObject::isFileUploadControl):
961         * rendering/RenderTreeAsText.cpp:
962         (WebCore::operator<<):
963
964 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
965
966         Reviewed by Sam Weinig.
967
968         DOM Wrappers for some nodes may not be marked.
969         https://bugs.webkit.org/show_bug.cgi?id=31380
970
971         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
972         the wrapper for the current world only.  This means that wrappers may be GC'ed
973         prematurely, and properties lost.
974
975         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
976
977         * bindings/js/JSAttrCustom.cpp:
978         (WebCore::JSAttr::markChildren):
979         * bindings/js/JSDOMBinding.cpp:
980         (WebCore::markDOMNodeWrapper):
981         * bindings/js/JSDOMBinding.h:
982         * bindings/js/JSNamedNodeMapCustom.cpp:
983         (WebCore::JSNamedNodeMap::markChildren):
984         * bindings/js/JSNodeCustom.cpp:
985         (WebCore::JSNode::markChildren):
986         * bindings/js/JSSVGElementInstanceCustom.cpp:
987         (WebCore::JSSVGElementInstance::markChildren):
988         * bindings/js/JSStyleSheetCustom.cpp:
989         (WebCore::JSStyleSheet::markChildren):
990
991 2009-11-11  Ben Murdoch  <benm@google.com>
992
993         Reviewed by Darin Adler.
994
995         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
996         https://bugs.webkit.org/show_bug.cgi?id=31384
997
998         No functionality change so no tests required.
999
1000         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
1001
1002 2009-11-11  Jens Alfke  <snej@chromium.org>
1003
1004         Reviewed by Dimitri Glazkov.
1005
1006         The Big De-Inlining. 450k code size reduction (32-bit x86.)
1007         - Various inline functions in V8Binding.h made non-inline.
1008         - Some renaming for consistency.
1009         - New function createRawTemplate().
1010         https://bugs.webkit.org/show_bug.cgi?id=31383
1011
1012         * bindings/scripts/CodeGeneratorV8.pm:
1013         * bindings/v8/V8Binding.cpp:
1014         (WebCore::v8DOMWrapperToNative):
1015         (WebCore::v8ValueToWebCoreString):
1016         (WebCore::v8ValueToAtomicWebCoreString):
1017         (WebCore::toInt32):
1018         (WebCore::toWebCoreString):
1019         (WebCore::toWebCoreStringWithNullCheck):
1020         (WebCore::toAtomicWebCoreStringWithNullCheck):
1021         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
1022         (WebCore::isUndefinedOrNull):
1023         (WebCore::v8Boolean):
1024         (WebCore::v8UndetectableString):
1025         (WebCore::v8StringOrNull):
1026         (WebCore::v8StringOrUndefined):
1027         (WebCore::v8StringOrFalse):
1028         (WebCore::v8StringToWebCoreString):
1029         (WebCore::v8ExternalString):
1030         (WebCore::createRawTemplate):  New function.
1031         * bindings/v8/V8Binding.h:
1032         (WebCore::v8DOMWrapperTo):
1033         (WebCore::v8DOMWrapperToNode):
1034         (WebCore::v8StringToWebCoreString):
1035         (WebCore::v8StringToAtomicWebCoreString):
1036
1037 2009-11-11  Jens Alfke  <snej@chromium.org>
1038
1039         Reviewed by Dimitri Glazkov.
1040
1041         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
1042         event-listener setter into a new subroutine transferHiddenDependency().
1043         https://bugs.webkit.org/show_bug.cgi?id=31377
1044
1045         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
1046         * bindings/v8/V8Utilities.cpp:
1047         (WebCore::transferHiddenDependency):  New.
1048         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
1049
1050 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
1051
1052         Reviewed by Beth Dakin.
1053
1054         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
1055         because there is a CG bug preventing this from working.
1056
1057         * platform/graphics/cg/GraphicsContextCG.cpp:
1058         (WebCore::sRGBColorSpaceRef):
1059
1060 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
1061
1062         Reviewed by Timothy Hatcher.
1063
1064         Check that if Storage panel exists before calling its methods
1065
1066         https://bugs.webkit.org/show_bug.cgi?id=31343
1067
1068         * inspector/front-end/inspector.js:
1069         (WebInspector.addDatabase):
1070         (WebInspector.addCookieDomain):
1071         (WebInspector.addDOMStorage):
1072         (WebInspector.updateDOMStorage):
1073
1074 2009-11-11  Jens Alfke  <snej@chromium.org>
1075
1076         Reviewed by Dimitri Glazkov.
1077
1078         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
1079         times in the generated V8 bindings.
1080         https://bugs.webkit.org/show_bug.cgi?id=31368
1081
1082         * bindings/v8/V8DOMWrapper.cpp:
1083         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
1084         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
1085
1086 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
1087
1088         Reviewed by Timothy Hatcher.
1089
1090         Display the correct summary in the web inspector for the shorthands
1091         border-color, border-width, border-style, margin, and padding.
1092         https://bugs.webkit.org/show_bug.cgi?id=7987
1093
1094         Test: fast/css/shorthands-four-values.html
1095
1096         * css/CSSMutableStyleDeclaration.cpp:
1097         (WebCore::CSSMutableStyleDeclaration::get4Values):
1098         Display the summary information in the same way the shorthand would be
1099         specified in a css rule.
1100
1101 2009-11-11  Jens Alfke  <snej@chromium.org>
1102
1103         Reviewed by Dimitri Glazkov.
1104
1105         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
1106         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
1107         https://bugs.webkit.org/show_bug.cgi?id=31367
1108
1109         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
1110
1111 2009-11-11  Jens Alfke  <snej@chromium.org>
1112
1113         Reviewed by Dimitri Glazkov.
1114
1115         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
1116
1117         * bindings/v8/DOMData.cpp:
1118         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
1119             so it can be inlined by its caller.
1120         * bindings/v8/DOMData.h:
1121         * bindings/v8/MainThreadDOMData.cpp:
1122         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
1123         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
1124         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
1125             and getStore, which inline both calls together.
1126         * bindings/v8/MainThreadDOMData.h:
1127         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
1128         * bindings/v8/V8DOMMap.cpp:
1129         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
1130
1131 2009-11-11  Nate Chapin  <japhet@chromium.org>
1132
1133         Reviewed by Dimitri Glazkov.
1134
1135         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
1136
1137         https://bugs.webkit.org/show_bug.cgi?id=31357
1138
1139         * platform/KURLGoogle.cpp:
1140         (WebCore::isSchemeFirstChar):
1141         (WebCore::isSchemeChar):
1142         (WebCore::KURL::hasPort):
1143         (WebCore::KURL::removePort):
1144         (WebCore::protocolIsValid):
1145
1146 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
1147
1148         Build fix, no reviewed.
1149
1150         Correct setPlatformFillColor and setPlatformStrokeColor calls
1151         to match new ColorSpace-supporting signatures.
1152
1153         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
1154           color space to the set[...]Color calls.
1155
1156 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1157
1158         Reviewed by Sam Weinig.
1159
1160         https://bugs.webkit.org/show_bug.cgi?id=31327
1161         Clean up SocketStreamHandleClient interface
1162
1163         No change in behavior.
1164
1165         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
1166         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
1167         the only client (WebSocketChannel), and it's not clear what this callback's semantics
1168         should be.
1169         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
1170         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
1171         For ResourceHandle, this method is called when the user cancels authentication sheet,
1172         not when something happens with the stream.
1173
1174         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
1175         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
1176
1177         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
1178         callbacks have no real implementation yet.
1179
1180 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
1181
1182         Reviewed by Eric Seidel.
1183
1184         Allow custom memory allocation control for the part of page directory in WebCore
1185         https://bugs.webkit.org/show_bug.cgi?id=31350
1186
1187         Inherits the following classes from Noncopyable because these are instantiated
1188         by 'new' and these are no need to be copyable:
1189
1190         class DragController         - instantiated at: WebCore/page/Page.cpp:107
1191         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
1192         class Settings               - instantiated at: WebCore/page/Page.cpp:116
1193         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
1194         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
1195         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
1196         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1197         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1198         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
1199
1200         Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
1201         PropertyWrapper is instantiated by 'new' in 
1202         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1203
1204         * page/DragController.h:
1205         * page/EventHandler.h:
1206         * page/FocusController.h:
1207         * page/FrameView.cpp:
1208         * page/PluginHalter.h:
1209         * page/Settings.h:
1210         * page/UserScript.h:
1211         * page/UserStyleSheet.h:
1212         * page/XSSAuditor.h:
1213         * page/animation/AnimationBase.cpp:
1214
1215 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1216
1217         Reviewed by Kenneth Rohde Christiansen.
1218
1219         https://bugs.webkit.org/show_bug.cgi?id=31323
1220         Fix a few compiler warnings
1221
1222         No new tests as there is no new functionality.
1223
1224         * editing/htmlediting.cpp:
1225         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1226         parentheses to silence gcc 4.4 -Wparentheses warnings
1227
1228 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1229
1230         Reviewed by Mark Rowe.
1231
1232         Set m_hasPendingGeometryChange to true by default, so that
1233         at least one call to NPP_SetWindow is executed, which is
1234         needed by the DRT plugin testing framework.
1235
1236         * plugins/PluginView.cpp:
1237         (WebCore::PluginView::PluginView):
1238
1239 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
1240
1241         Rubber-stamped by Kenneth Rohde Christiansen.
1242
1243         https://bugs.webkit.org/show_bug.cgi?id=31348
1244         [Qt] Remove unnecessary LUT creator from WebCore.pro
1245
1246         * WebCore.pro:
1247
1248 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1249
1250         Reviewed by Tor Arne Vestbø.
1251
1252         Introduce a function for querying the input method status
1253         in QWebPageClient.
1254
1255         * platform/qt/QWebPageClient.h:
1256
1257 2009-11-11  Benjamin Otte  <otte@gnome.org>
1258
1259         Reviewed by Jan Alonzo.
1260
1261         [GTK] Black artifacts in youtube.com/html5
1262
1263         Paint the video to the given size. It's the job of the callers to keep
1264         track of aspect ratio. RenderVideo.cpp does it for the <video>
1265         element.
1266         https://bugs.webkit.org/show_bug.cgi?id=30925
1267
1268         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1269         (WebCore::MediaPlayerPrivate::paint):
1270
1271 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1272
1273         Reviewed by Reviewed by Jan Alonzo.
1274
1275         https://bugs.webkit.org/show_bug.cgi?id=30901
1276         [Gtk] Need to de-lint the Atk a11y code
1277
1278         Cleaned up some missed capitalization style-guideline violations.
1279
1280         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1281
1282 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1283
1284         Reviewed by Eric Seidel.
1285
1286         [Qt] Make the default style background color valid.
1287         Currently the color is transparent but invalid, this causes
1288         list boxes in QtWebKit to be drawn with a black background
1289         since r49242.
1290         https://bugs.webkit.org/show_bug.cgi?id=31295
1291
1292         * rendering/style/RenderStyle.h:
1293         (WebCore::InheritedFlags::initialBackgroundColor):
1294         * rendering/style/StyleBackgroundData.cpp:
1295         (WebCore::StyleBackgroundData::StyleBackgroundData):
1296
1297 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1298
1299         Reviewed by Geoff Garen.
1300
1301         Simplify the ownership model for worlds - rather than having a pair of weak references
1302         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1303         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
1304         back forward cache.
1305
1306         * WebCore.base.exp:
1307         * bindings/js/JSDOMBinding.cpp:
1308         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1309         * bindings/js/JSDOMBinding.h:
1310         (WebCore::DOMWrapperWorld::forgetDocument):
1311         * bindings/js/ScriptCachedFrameData.cpp:
1312         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1313         (WebCore::ScriptCachedFrameData::restore):
1314         (WebCore::ScriptCachedFrameData::clear):
1315         * bindings/js/ScriptCachedFrameData.h:
1316         * bindings/js/ScriptController.cpp:
1317         (WebCore::ScriptController::~ScriptController):
1318         (WebCore::ScriptController::clearWindowShell):
1319         (WebCore::ScriptController::initScript):
1320         (WebCore::ScriptController::updateDocument):
1321         * bindings/js/ScriptController.h:
1322
1323 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
1324
1325         Reviewed by Darin Adler.
1326
1327         rename counter to makeCounterNode in RenderCounter.cpp
1328         https://bugs.webkit.org/show_bug.cgi?id=31289
1329
1330         No new test because this is just a small refactoring.
1331
1332         * rendering/RenderCounter.cpp:
1333         (WebCore::findPlaceForCounter):
1334         (WebCore::makeCounterNode):
1335         (WebCore::RenderCounter::originalText):
1336
1337 2009-11-10  Daniel Bates  <dbates@webkit.org>
1338
1339         Reviewed by Oliver Hunt.
1340
1341         https://bugs.webkit.org/show_bug.cgi?id=30754
1342
1343         Patch 2 of 2.
1344
1345         Removed method EventHandler::dragSourceMovedTo, since it is no longer
1346         needed. This method fired a drag event whenever the mouse moved, but
1347         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1348         model independent of when the mouse moves. See "Among other changes..."
1349         in the change log for patch 1 for more details.
1350
1351         * WebCore.DragSupport.exp:
1352         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1353         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1354         * page/EventHandler.h:
1355
1356 2009-11-10  Daniel Bates  <dbates@webkit.org>
1357
1358         Reviewed by Oliver Hunt.
1359
1360         https://bugs.webkit.org/show_bug.cgi?id=30754
1361
1362         Patch 1 of 2.
1363
1364         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1365         the drag event should always fire before the dragover event.
1366
1367         In fixing this bug, this patch also makes our drag processing model
1368         conform to the HTML 5 spec.
1369
1370         Among the changes, this patch ensures that the drag event isn't fired outside
1371         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1372         Currently, the drag event is fired whenever the mouse button is down and the OS
1373         detects the mouse moved. But, as per the spec, the drag event should
1374         fire approx. every 350ms so long as the mouse button is down.
1375
1376         Test: fast/events/drag-and-drop-fire-drag-dragover.html
1377
1378         * page/EventHandler.cpp:
1379         (WebCore::EventHandler::clear):
1380         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1381         Modified to determine when we are in the correct instance of EventHandler to service the drag
1382         and drop operation.
1383         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1384         into this method.
1385         (WebCore::EventHandler::cancelDragAndDrop):
1386         (WebCore::EventHandler::performDragAndDrop):
1387         (WebCore::EventHandler::clearDragState):
1388         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1389         we should fire both drag and dragover events or only the dragover event.
1390
1391 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
1392
1393         Reviewed by Dimitri Glazkov.
1394
1395         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1396         https://bugs.webkit.org/show_bug.cgi?id=31301
1397
1398         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1399
1400         Allowed passing V8Proxy for the calling JS context:
1401         * bindings/v8/V8DOMWrapper.h:
1402         (WebCore::V8DOMWrapper::getXPathNSResolver):
1403         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1404         (WebCore::V8CustomXPathNSResolver::create):
1405         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1406         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1407         * bindings/v8/custom/V8CustomXPathNSResolver.h:
1408         * bindings/v8/custom/V8DocumentCustom.cpp:
1409         (WebCore::CALLBACK_FUNC_DECL):
1410
1411 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
1412
1413         Reviewed by Timothy Hatcher.
1414
1415         Implement URL decomposition IDL attributes for HTMLAnchorElement.
1416         https://bugs.webkit.org/show_bug.cgi?id=29972.
1417
1418         Add methods for setting different parts of the URL in href attribute.
1419
1420         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1421                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1422                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1423                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1424                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1425                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1426                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1427
1428         * bindings/js/JSLocationCustom.cpp:
1429         (WebCore::JSLocation::setPort):
1430         * html/HTMLAnchorElement.cpp:
1431         (WebCore::parsePortFromStringPosition):
1432         (WebCore::HTMLAnchorElement::setHash):
1433         (WebCore::HTMLAnchorElement::setHost):
1434         (WebCore::HTMLAnchorElement::setHostname):
1435         (WebCore::HTMLAnchorElement::setPathname):
1436         (WebCore::HTMLAnchorElement::setPort):
1437         (WebCore::HTMLAnchorElement::setProtocol):
1438         (WebCore::HTMLAnchorElement::setSearch):
1439         * html/HTMLAnchorElement.h:
1440         * html/HTMLAnchorElement.idl:
1441         * loader/FrameLoader.cpp:
1442         (WebCore::FrameLoader::iconURL):
1443         * platform/KURL.cpp:
1444         (WebCore::KURL::removePort):
1445         (WebCore::KURL::setPort):
1446         (WebCore::KURL::prettyURL):
1447         (WebCore::protocolIsValid):
1448         * platform/KURL.h:
1449         (WebCore::KURL::canSetHostOrPort):
1450         (WebCore::KURL::canSetPathname):
1451         (WebCore::KURL::hasPort):
1452         * platform/network/soup/ResourceHandleSoup.cpp:
1453         (WebCore::):
1454
1455 2009-11-10  Nate Chapin  <japhet@chromium.org>
1456
1457         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1458
1459         * platform/chromium/PopupMenuChromium.cpp:
1460         (WebCore::PopupContainer::paintBorder):
1461         (WebCore::PopupListBox::paint):
1462         (WebCore::PopupListBox::paintRow):
1463         * platform/graphics/chromium/TransparencyWin.cpp:
1464         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1465         * platform/graphics/skia/GraphicsContextSkia.cpp:
1466         (WebCore::GraphicsContext::fillRect):
1467         (WebCore::GraphicsContext::fillRoundedRect):
1468         (WebCore::GraphicsContext::setPlatformFillColor):
1469         (WebCore::GraphicsContext::setPlatformStrokeColor):
1470         * rendering/RenderMediaControlsChromium.cpp:
1471         (WebCore::paintMediaSlider):
1472         (WebCore::paintMediaVolumeSlider):
1473         (WebCore::paintMediaTimelineContainer):
1474         * rendering/RenderThemeChromiumMac.mm:
1475         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1476
1477 2009-11-10  Brady Eidson  <beidson@apple.com>
1478
1479         Reviewed by Sam Weinig.
1480
1481         Repro crash saving pcmag.com article as a webarchive.
1482         <rdar://problem/7381219> and https://webkit.org/b/31322
1483
1484         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1485
1486         * css/CSSStyleSheet.cpp:
1487         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1488           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1489
1490 2009-11-10  Beth Dakin  <bdakin@apple.com>
1491
1492         Attempt 2 to fix Tiger build. No review needed.
1493
1494         * platform/graphics/cg/GraphicsContextCG.cpp:
1495         (WebCore::deviceRGBColorSpaceRef):
1496         (WebCore::sRGBColorSpaceRef):
1497
1498 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
1499
1500         wx build fix. Changes needed after r50760.
1501
1502         * platform/graphics/wx/GraphicsContextWx.cpp:
1503         (WebCore::GraphicsContext::GraphicsContext):
1504         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1505         (WebCore::drawTextWithSpacing):
1506
1507 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1508
1509         Qt build fix.
1510
1511         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1512         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1513
1514 2009-11-10  Beth Dakin  <bdakin@apple.com>
1515
1516         Tiger build fix. No review needed.
1517
1518         * platform/graphics/cg/GraphicsContextCG.cpp:
1519         (WebCore::sRGBColorSpaceRef):
1520
1521 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1522
1523         Reviewed by Dan Bernstein.
1524
1525         https://bugs.webkit.org/show_bug.cgi?id=31312
1526         Decouple authentication panel callbacks from ResourceHandle
1527
1528         No change in functionality.
1529
1530         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1531         ResourceHandle as delegate.
1532
1533         * WebCore.vcproj/WebCore.vcproj:
1534         * platform/network/AuthenticationClient.h: Added.
1535         Added a new interface for listening to authentication panel notifications.
1536
1537         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1538         it wants with the project file.
1539
1540         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1541         interface class.
1542         (WebCore::AuthenticationClient::deref): Ditto.
1543
1544         * platform/network/ResourceHandle.h:
1545         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1546         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1547
1548         * platform/network/cf/AuthenticationCF.cpp:
1549         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1550         (WebCore::AuthenticationChallenge::platformCompare):
1551         * platform/network/cf/AuthenticationChallenge.h:
1552         (WebCore::AuthenticationChallenge::authenticationClient):
1553         * platform/network/chromium/AuthenticationChallenge.h:
1554         (WebCore::AuthenticationChallenge::authenticationClient):
1555         * platform/network/curl/AuthenticationChallenge.h:
1556         (WebCore::AuthenticationChallenge::authenticationClient):
1557         Keeping a reference to AuthenticationClient, not to ResourceHandle.
1558
1559 2009-11-10  Beth Dakin  <bdakin@apple.com>
1560
1561        Second attempted gtk build fix. No review needed.
1562
1563         * html/canvas/CanvasStyle.cpp:
1564         (WebCore::CanvasStyle::applyStrokeColor):
1565
1566
1567 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1568
1569         Reviewed by Geoff Garen.
1570
1571         Fix back/forwards cache with JSC isolated worlds.
1572         https://bugs.webkit.org/show_bug.cgi?id=31310
1573         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1574
1575         Store the global object for all worlds, not just the normal world.
1576         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1577         so we can forget global objects if a world goes away.
1578
1579         * bindings/js/JSDOMBinding.cpp:
1580         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1581         * bindings/js/JSDOMBinding.h:
1582         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
1583         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
1584         * bindings/js/ScriptCachedFrameData.cpp:
1585         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1586         (WebCore::ScriptCachedFrameData::forgetWorld):
1587         (WebCore::ScriptCachedFrameData::domWindow):
1588         (WebCore::ScriptCachedFrameData::restore):
1589         (WebCore::ScriptCachedFrameData::clear):
1590         * bindings/js/ScriptCachedFrameData.h:
1591         * bindings/js/ScriptController.h:
1592
1593 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1594
1595         [Qt] Unreviewed buildfix after r50760.
1596
1597         * platform/graphics/qt/GraphicsContextQt.cpp:
1598         (WebCore::GraphicsContext::GraphicsContext):
1599
1600 2009-11-10  Beth Dakin  <bdakin@apple.com>
1601
1602         Attempted build fix. (No review needed.)
1603
1604         * GNUmakefile.am: Adding ColorSpace.h
1605
1606 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
1607
1608         Reviewed by NOBODY - Build Fix.
1609
1610         Updated function calls to take a ColorSpace argument, passing
1611         in DeviceColorSpace for now - this should be fixed. Also added
1612         ColorSpace.h to WebCore project.
1613
1614         * WebCore.vcproj/WebCore.vcproj:
1615         * platform/graphics/win/FontCGWin.cpp:
1616         (WebCore::Font::drawGlyphs):
1617         * platform/graphics/win/GraphicsContextCGWin.cpp:
1618         (WebCore::GraphicsContext::GraphicsContext):
1619         * platform/win/PopupMenuWin.cpp:
1620         (WebCore::PopupMenu::paint):
1621         * platform/win/WebCoreTextRenderer.cpp:
1622         (WebCore::doDrawTextAtPoint):
1623         * rendering/RenderThemeSafari.cpp:
1624         (WebCore::RenderThemeSafari::paintMenuListButton):
1625
1626 2009-11-10  Jens Alfke  <snej@chromium.org>
1627
1628         Reviewed by Darin Adler.
1629
1630         Optimizations to Element::getAttribute
1631         https://bugs.webkit.org/show_bug.cgi?id=30926
1632
1633         * dom/Element.cpp:
1634         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
1635         * dom/NamedAttrMap.cpp:
1636         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
1637         * platform/text/PlatformString.h:
1638         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
1639
1640 2009-11-10  Beth Dakin  <bdakin@apple.com>
1641
1642         Reviewed by Darin Adler.
1643
1644         Fix for <rdar://problem/7059710> 
1645         -and corresponding-
1646         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
1647         color-correction for CSS colors
1648
1649         New exported symbol for GraphicsContext::fillColor() which now 
1650         accepts a ColorSpace as an optional parameter.
1651         * WebCore.base.exp:
1652
1653         Added a new file, ColorSpace.h, to define the ColorSpace enum.
1654         * WebCore.xcodeproj/project.pbxproj:
1655
1656         Computed Style for -webkit-color-correction
1657         * css/CSSComputedStyleDeclaration.cpp:
1658         (WebCore::):
1659         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1660
1661         Parse -webkit-color-correction
1662         * css/CSSParser.cpp:
1663         (WebCore::CSSParser::parseValue):
1664
1665        Map CSS identifiers to the appropriate values of the ColorSpace enum
1666         * css/CSSPrimitiveValueMappings.h:
1667         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1668         (WebCore::CSSPrimitiveValue::operator ColorSpace):
1669
1670         New property -webkit-color-correction
1671         * css/CSSPropertyNames.in:
1672
1673         Map -webkit-color-correction into the RenderStyle.
1674         * css/CSSStyleSelector.cpp:
1675         (WebCore::CSSStyleSelector::applyProperty):
1676
1677         Add new value sRGB.
1678         * css/CSSValueKeywords.in:
1679
1680         Comment out the reference to sRGB since it will now be inherited as 
1681         a value from CSSValueKeywords.
1682         * css/SVGCSSValueKeywords.in:
1683
1684         Definition of the ColorSpace enum.
1685         * platform/graphics/ColorSpace.h: Added.
1686         (WebCore::):
1687
1688         These functions all now take a ColorSpace as a parameter.
1689         * platform/graphics/GraphicsContext.cpp:
1690         (WebCore::GraphicsContext::setStrokeColor):
1691         (WebCore::GraphicsContext::setFillColor):
1692         (WebCore::GraphicsContext::drawHighlightForText):
1693
1694         Return the appropriate ColorSpace.
1695         (WebCore::GraphicsContext::strokeColorSpace):
1696         (WebCore::GraphicsContext::fillColorSpace):
1697
1698         These functions all call other functions which require a ColorSpace 
1699         as a parameter.
1700         (WebCore::GraphicsContext::setStrokePattern):
1701         (WebCore::GraphicsContext::setFillPattern):
1702         (WebCore::GraphicsContext::setStrokeGradient):
1703         (WebCore::GraphicsContext::setFillGradient):
1704
1705         All of the GraphicsContext functions that take a Color should now 
1706         also take a ColorSpace.
1707         * platform/graphics/GraphicsContext.h:
1708
1709         Added new member variables stokeColorSpace and fillColorSpace.
1710         * platform/graphics/GraphicsContextPrivate.h:
1711         (WebCore::GraphicsContextState::GraphicsContextState):
1712
1713         Attempt to keep the Cairo port building with all of the massive 
1714         changes to GraphicsContext.        
1715         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1716         (WebCore::GraphicsContext::fillRect):
1717         (WebCore::GraphicsContext::setPlatformFillColor):
1718         (WebCore::GraphicsContext::setPlatformStrokeColor):
1719         (WebCore::GraphicsContext::fillRoundedRect):
1720
1721         
1722         * platform/graphics/cg/GraphicsContextCG.cpp:
1723         (WebCore::sRGBColorSpaceRef): New static function that returns a 
1724         CGColorSpaceRef for the sRGB color space.
1725         (WebCore::deviceRGBColorSpaceRef): New static function that returns 
1726         a CGColorSpaceRef for the device RGB color space.
1727
1728         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and 
1729         sets the fill color to the specified color in the given ColorSpace.
1730         (WebCore::setCGStrokeColor): Same, but for stroke.
1731
1732         (WebCore::setCGFillColorSpace): New static to set the 
1733         CGFillColorSpace to the given ColorSpace
1734         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
1735
1736         Send ColorSpaces when appropriate, set ColorSpaces when 
1737         appropriate, and check ColorSpaces when appropriate.
1738         (WebCore::GraphicsContext::GraphicsContext):
1739         (WebCore::GraphicsContext::drawRect):
1740         (WebCore::GraphicsContext::drawLine):
1741         (WebCore::GraphicsContext::fillPath):
1742         (WebCore::GraphicsContext::strokePath):
1743         (WebCore::GraphicsContext::fillRect):
1744         (WebCore::GraphicsContext::fillRoundedRect):
1745         (WebCore::GraphicsContext::strokeRect):
1746         (WebCore::GraphicsContext::drawLineForText):
1747         (WebCore::GraphicsContext::setPlatformStrokeColor):
1748         (WebCore::GraphicsContext::setPlatformFillColor):
1749
1750         Attempt to keep Haiku building.
1751         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1752         (WebCore::GraphicsContext::fillRect):
1753         (WebCore::GraphicsContext::fillRoundedRect):
1754         (WebCore::GraphicsContext::setPlatformStrokeColor):
1755         (WebCore::GraphicsContext::setPlatformFillColor):
1756
1757         Attempt to keep QT building.
1758         * platform/graphics/qt/GraphicsContextQt.cpp:
1759         (WebCore::GraphicsContext::fillRect):
1760         (WebCore::GraphicsContext::fillRoundedRect):
1761         (WebCore::GraphicsContext::setPlatformStrokeColor):
1762         (WebCore::GraphicsContext::setPlatformFillColor):
1763
1764         Attempt to keep Wince building.
1765         * platform/graphics/wince/GraphicsContextWince.cpp:
1766         (WebCore::GraphicsContext::fillRect):
1767         (WebCore::GraphicsContext::setPlatformFillColor):
1768         (WebCore::GraphicsContext::setPlatformStrokeColor):
1769         (WebCore::GraphicsContext::clearRect):
1770         (WebCore::GraphicsContext::fillRoundedRect):
1771         (WebCore::GraphicsContext::setPlatformShadow):
1772
1773         Attempt to keep WX building.
1774         * platform/graphics/wx/GraphicsContextWx.cpp:
1775         (WebCore::GraphicsContext::fillRect):
1776         (WebCore::GraphicsContext::fillRoundedRect):
1777         (WebCore::GraphicsContext::setPlatformStrokeColor):
1778         (WebCore::GraphicsContext::setPlatformFillColor):
1779
1780         Added functions colorSpace() and setColorSpace()
1781         * rendering/style/RenderStyle.h:
1782         (WebCore::InheritedFlags::colorSpace):
1783         (WebCore::InheritedFlags::setColorSpace):
1784
1785         The ColorSpace is stored here.
1786         * rendering/style/StyleRareInheritedData.cpp:
1787         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1788         (WebCore::StyleRareInheritedData::operator==):
1789         * rendering/style/StyleRareInheritedData.h:
1790
1791         All of these call sites call GraphicsContext functions which now 
1792         require ColorSpaces.
1793         * editing/SelectionController.cpp:
1794         (WebCore::SelectionController::paintCaret):
1795         * html/canvas/CanvasRenderingContext2D.cpp:
1796         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1797         * html/canvas/CanvasStyle.cpp:
1798         (WebCore::CanvasStyle::applyStrokeColor):
1799         (WebCore::CanvasStyle::applyFillColor):
1800         * inspector/InspectorController.cpp:
1801         (WebCore::drawOutlinedQuad):
1802         * page/FrameView.cpp:
1803         (WebCore::FrameView::paintContents):
1804         * platform/ScrollbarTheme.h:
1805         (WebCore::ScrollbarTheme::paintScrollCorner):
1806         * platform/ScrollbarThemeComposite.cpp:
1807         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
1808         * platform/graphics/Image.cpp:
1809         (WebCore::Image::fillWithSolidColor):
1810         * platform/graphics/mac/FontMac.mm:
1811         (WebCore::Font::drawGlyphs):
1812         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1813         (WebCore::MediaPlayerPrivate::paint):
1814         * rendering/EllipsisBox.cpp:
1815         (WebCore::EllipsisBox::paint):
1816         * rendering/InlineFlowBox.cpp:
1817         (WebCore::InlineFlowBox::paintTextDecorations):
1818         * rendering/InlineTextBox.cpp:
1819         (WebCore::updateGraphicsContext):
1820         (WebCore::paintTextWithShadows):
1821         (WebCore::InlineTextBox::paint):
1822         (WebCore::InlineTextBox::paintSelection):
1823         (WebCore::InlineTextBox::paintCompositionBackground):
1824         (WebCore::InlineTextBox::paintDecoration):
1825         (WebCore::InlineTextBox::paintTextMatchMarker):
1826         (WebCore::InlineTextBox::paintCompositionUnderline):
1827         * rendering/InlineTextBox.h:
1828         * rendering/RenderBlock.cpp:
1829         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1830         (WebCore::RenderBlock::fillVerticalSelectionGap):
1831         (WebCore::RenderBlock::fillLeftSelectionGap):
1832         (WebCore::RenderBlock::fillRightSelectionGap):
1833         * rendering/RenderBoxModelObject.cpp:
1834         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1835         (WebCore::RenderBoxModelObject::paintBoxShadow):
1836         * rendering/RenderFileUploadControl.cpp:
1837         (WebCore::RenderFileUploadControl::paintObject):
1838         * rendering/RenderFrameSet.cpp:
1839         (WebCore::RenderFrameSet::paintColumnBorder):
1840         (WebCore::RenderFrameSet::paintRowBorder):
1841         * rendering/RenderImage.cpp:
1842         (WebCore::RenderImage::paintReplaced):
1843         * rendering/RenderLayer.cpp:
1844         (WebCore::RenderLayer::paintScrollCorner):
1845         (WebCore::RenderLayer::paintResizer):
1846         * rendering/RenderListBox.cpp:
1847         (WebCore::RenderListBox::paintItemForeground):
1848         (WebCore::RenderListBox::paintItemBackground):
1849         * rendering/RenderListMarker.cpp:
1850         (WebCore::RenderListMarker::paint):
1851         * rendering/RenderObject.cpp:
1852         (WebCore::RenderObject::drawLineForBoxSide):
1853         (WebCore::RenderObject::drawArcForBoxSide):
1854         * rendering/RenderReplaced.cpp:
1855         (WebCore::RenderReplaced::paint):
1856         * rendering/RenderScrollbarTheme.cpp:
1857         (WebCore::RenderScrollbarTheme::paintScrollCorner):
1858         * rendering/RenderThemeMac.mm:
1859         (WebCore::RenderThemeMac::paintMenuListButton):
1860         * rendering/RenderView.cpp:
1861         (WebCore::RenderView::paintBoxDecorations):
1862         * rendering/RenderWidget.cpp:
1863         (WebCore::RenderWidget::paint):
1864         * rendering/SVGInlineTextBox.cpp:
1865         (WebCore::SVGInlineTextBox::paintSelection):
1866         * svg/graphics/SVGPaintServerGradient.cpp:
1867         (WebCore::SVGPaintServerGradient::setup):
1868         * svg/graphics/SVGPaintServerSolid.cpp:
1869         (WebCore::SVGPaintServerSolid::setup):
1870
1871 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
1872
1873         Reviewed by Timothy Hatcher.
1874
1875         Web Inspector: Speed up syntax highlighter
1876         https://bugs.webkit.org/show_bug.cgi?id=31291
1877
1878         * inspector/front-end/SourceFrame.js:
1879         (WebInspector.SourceFrame.prototype._loaded):
1880         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
1881         (WebInspector.SourceSyntaxHighlighter.prototype.process):
1882         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
1883         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
1884         (WebInspector.CSSSourceSyntaxHighlighter):
1885         (WebInspector.JavaScriptSourceSyntaxHighlighter):
1886
1887 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
1888
1889         Reviewed by Eric Seidel.
1890
1891         Remove session storage setting
1892         https://bugs.webkit.org/show_bug.cgi?id=31279
1893
1894         Remove session storage from Settings.  It was added temporarily so we could
1895         disable it by default at runtime in Chromium.  We now disable these things in a
1896         different way, so it's time to remove it.  Qt also depended on this setting for
1897         a short period of time, but after talking to them we agreed that it should be
1898         removed.
1899
1900         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
1901
1902         * page/DOMWindow.cpp:
1903         (WebCore::DOMWindow::sessionStorage):
1904         * page/Settings.cpp:
1905         (WebCore::Settings::Settings):
1906         * page/Settings.h:
1907
1908 2009-11-10  Dan Bernstein  <mitz@apple.com>
1909
1910         Reviewed by Eric Carlson and Darin Adler.
1911
1912         WebCore part of making full-screen video pause during scrubbing.
1913
1914         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
1915         and HTMLMediaElement::endScrubbing().
1916
1917 2009-11-10  Anton Muhin  <antonm@chromium.org>
1918
1919         Reviewed by Adam Barth.
1920
1921         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
1922         https://bugs.webkit.org/show_bug.cgi?id=31051
1923
1924         * bindings/v8/V8GCController.cpp:
1925         (WebCore::V8GCController::gcEpilogue):
1926         (WebCore::V8GCController::checkMemoryUsage):
1927         * bindings/v8/V8GCController.h:
1928         * bindings/v8/V8Proxy.cpp:
1929         (WebCore::V8Proxy::evaluate):
1930         (WebCore::V8Proxy::runScript):
1931         (WebCore::V8Proxy::callFunction):
1932
1933 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
1934
1935         Reviewed by Darin Adler.
1936
1937         Allow custom memory allocation control for the part of loader directory in WebCore
1938         https://bugs.webkit.org/show_bug.cgi?id=31161
1939
1940         Inherits the following classes from Noncopyable because these are instantiated
1941         by 'new' and these are no need to be copyable:
1942
1943         class Request - WebCore/loader/loader.cpp:100
1944         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
1945         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
1946         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
1947         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
1948         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
1949
1950         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
1951         MainThreadBridge is instantiated by 'new' in 
1952         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
1953
1954         ThreadableLoaderClient's inheriting has been changed to public.
1955
1956         * loader/ImageLoader.cpp:
1957         * loader/ProgressTracker.cpp:
1958         * loader/RedirectScheduler.cpp:
1959         * loader/Request.h:
1960         * loader/ThreadableLoaderClient.h:
1961         * loader/WorkerThreadableLoader.h:
1962         * loader/appcache/ApplicationCacheHost.h:
1963         * loader/appcache/ApplicationCacheStorage.h:
1964
1965 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1966
1967         Reviewed by Eric Seidel.
1968
1969         https://bugs.webkit.org/show_bug.cgi?id=31047
1970         [GTK] Failing test media/video-played-ranges-1.html
1971
1972         WebKit coding style fixes.
1973
1974         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1975         (WebCore::mediaPlayerPrivateMessageCallback):
1976         (WebCore::MediaPlayerPrivate::naturalSize):
1977         (WebCore::MediaPlayerPrivate::paint):
1978         (WebCore::mimeTypeCache):
1979
1980 2009-11-10  Oliver Hunt  <oliver@apple.com>
1981
1982         Remove build failure introduced by earlier build fix.
1983
1984         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1985
1986 2009-11-10  Oliver Hunt  <oliver@apple.com>
1987
1988         Is this the last build fix? grep tells me yes.
1989
1990         * bindings/v8/custom/V8DocumentCustom.cpp:
1991         (WebCore::CALLBACK_FUNC_DECL):
1992
1993 2009-11-10  Oliver Hunt  <oliver@apple.com>
1994
1995         Hopefully the last one.  Why aren't these autogenerated?
1996
1997         * bindings/v8/V8DOMWrapper.cpp:
1998         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
1999         (WebCore::V8DOMWrapper::getTemplate):
2000         (WebCore::V8DOMWrapper::convertToV8Object):
2001
2002 2009-11-10  Oliver Hunt  <oliver@apple.com>
2003
2004         Another chrome build fix.
2005
2006         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
2007         (WebCore::CALLBACK_FUNC_DECL):
2008
2009 2009-11-10  Oliver Hunt  <oliver@apple.com>
2010
2011         Yet another chrome buildfix
2012
2013         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2014         (WebCore::CALLBACK_FUNC_DECL):
2015         * bindings/v8/custom/V8WebGLArrayCustom.h:
2016         (WebCore::constructCanvasArray):
2017         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2018         (WebCore::CALLBACK_FUNC_DECL):
2019         (WebCore::INDEXED_PROPERTY_GETTER):
2020         (WebCore::INDEXED_PROPERTY_SETTER):
2021         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2022         (WebCore::CALLBACK_FUNC_DECL):
2023         (WebCore::INDEXED_PROPERTY_GETTER):
2024         (WebCore::INDEXED_PROPERTY_SETTER):
2025         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2026         (WebCore::CALLBACK_FUNC_DECL):
2027         (WebCore::INDEXED_PROPERTY_GETTER):
2028         (WebCore::INDEXED_PROPERTY_SETTER):
2029         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2030         (WebCore::CALLBACK_FUNC_DECL):
2031         (WebCore::vertexAttribAndUniformHelperf):
2032         (WebCore::uniformHelperi):
2033         (WebCore::uniformMatrixHelper):
2034         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2035         (WebCore::CALLBACK_FUNC_DECL):
2036         (WebCore::INDEXED_PROPERTY_GETTER):
2037         (WebCore::INDEXED_PROPERTY_SETTER):
2038         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2039         (WebCore::CALLBACK_FUNC_DECL):
2040         (WebCore::INDEXED_PROPERTY_GETTER):
2041         (WebCore::INDEXED_PROPERTY_SETTER):
2042         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2043         (WebCore::CALLBACK_FUNC_DECL):
2044         (WebCore::INDEXED_PROPERTY_GETTER):
2045         (WebCore::INDEXED_PROPERTY_SETTER):
2046         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2047         (WebCore::CALLBACK_FUNC_DECL):
2048         (WebCore::INDEXED_PROPERTY_GETTER):
2049         (WebCore::INDEXED_PROPERTY_SETTER):
2050
2051 2009-11-10  Oliver Hunt  <oliver@apple.com>
2052
2053         Chrome build fix.
2054
2055         * bindings/v8/V8Index.h:
2056
2057 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2058
2059         Reviewed by Reviewed by Jan Alonzo.
2060
2061         https://bugs.webkit.org/show_bug.cgi?id=30901
2062         [Gtk] Need to de-lint the Atk a11y code
2063
2064         Removal of various and sundry style-violating nits.
2065
2066         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2067
2068 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2069
2070         Reviewed by Jan Alonzo.
2071
2072         https://bugs.webkit.org/show_bug.cgi?id=31047
2073         [GTK] Failing test media/video-played-ranges-1.html
2074
2075         Fix playback rate setter by remembering the rate was changed. Also
2076         correctly handle reverse playback by doing a seek from end to
2077         beginning of the media.
2078
2079         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2080         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
2081         (WebCore::MediaPlayerPrivate::currentTime):
2082         (WebCore::MediaPlayerPrivate::seek):
2083         (WebCore::MediaPlayerPrivate::hasAudio):
2084         (WebCore::MediaPlayerPrivate::setVolume):
2085         (WebCore::MediaPlayerPrivate::setRate):
2086         (WebCore::MediaPlayerPrivate::updateStates):
2087         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2088
2089 2009-11-10  Oliver Hunt  <oliver@apple.com>
2090
2091         Reviewed by Maciej Stachowiak.
2092
2093         Rename 3D Canvas related classes to use WebGL prefix
2094         https://bugs.webkit.org/show_bug.cgi?id=29095
2095
2096         Automatic rename of all WebGL related types from Canvas* to
2097         WebGL* per more recent version of the WebGL spec.
2098
2099         Due to the automatic rename I've removed the 600+ line change list.
2100
2101 2009-11-09  Dirk Schulze  <krit@webkit.org>
2102
2103         Reviewed by Oliver Hunt.
2104
2105         SVG feDisplacementMap is not implemented
2106         [https://bugs.webkit.org/show_bug.cgi?id=31255]
2107
2108         This is the implementation of the SVG filter effect
2109         feDisplacementMap. 
2110
2111         Test: svg/filters/feDisplacementMap.svg
2112
2113         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
2114         (WebCore::FEDisplacementMap::apply):
2115
2116 2009-11-09  Kent Tamura  <tkent@chromium.org>
2117
2118         Reviewed by Darin Adler.
2119
2120         Add a comment about null strings and hash functions.
2121         https://bugs.webkit.org/show_bug.cgi?id=29118
2122
2123         * platform/text/StringHash.h:
2124
2125 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2126
2127         Reviewed by Darin Adler.
2128
2129         Compiler warnings in InspectorResource.h
2130         https://bugs.webkit.org/show_bug.cgi?id=29231
2131
2132         Fix compilation warnings by removing addition operation on an enum type.
2133
2134         * inspector/InspectorResource.h:
2135         (WebCore::InspectorResource::):
2136         (WebCore::InspectorResource::Changes::hasChange):
2137         (WebCore::InspectorResource::Changes::set):
2138         (WebCore::InspectorResource::Changes::setAll):
2139
2140 2009-11-09  Anders Carlsson  <andersca@apple.com>
2141
2142         Reviewed by Darin Adler and Dan Bernstein.
2143
2144         <rdar://problem/7328395>
2145         https://bugs.webkit.org/show_bug.cgi?id=31277
2146
2147         When an object tag's style changes (for example when child nodes are added/removed),
2148         reuse its Frame (if it has one) instead of creating multiple Frames.
2149
2150         Test: fast/dom/HTMLObjectElement/children-changed.html
2151
2152         * loader/FrameLoader.cpp:
2153         (WebCore::FrameLoader::requestObject):
2154
2155 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
2156
2157         Reviewed by Kenneth Rohde Christiansen.
2158
2159         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
2160         since adjustment of RW-section base address will be needed for all new symbian
2161         tool chains, specifically for arm and gcc compilation targets.
2162         Also, change target address to 0xE00000 to be sufficient for all targets.
2163
2164         * WebCore.pro:
2165
2166 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
2167
2168         Reviewed by Timothy Hatcher.
2169
2170         Web Inspector: Crash when inspecting
2171         WebCore\manual-tests\inspector\dom-mutation.html
2172
2173         https://bugs.webkit.org/show_bug.cgi?id=31259
2174
2175         * inspector/InspectorDOMAgent.cpp:
2176         (WebCore::InspectorDOMAgent::handleEvent):
2177
2178 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2179
2180         Reviewed by Kenneth Rohde Christiansen.
2181
2182         [Qt] Few classes have virtual functions but non-virtual destructor
2183         https://bugs.webkit.org/show_bug.cgi?id=31269
2184
2185         No new tests as there is no functional change.
2186
2187         * platform/qt/QWebPageClient.h:
2188         (QWebPageClient::~QWebPageClient): Add virtual destructor.
2189
2190 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2191
2192         Reviewed by Kenneth Rohde Christiansen.
2193
2194         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2195         https://bugs.webkit.org/show_bug.cgi?id=31140
2196
2197         QtNetwork interprets null string as request to remove the header, not add it.
2198         Replace null values with empty values before passing them to QtNetwork.
2199
2200         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2201
2202         * platform/network/qt/ResourceRequestQt.cpp:
2203         (WebCore::ResourceRequest::toNetworkRequest):
2204
2205 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
2206
2207         Reviewed by Kevin Ollivier.
2208
2209         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2210         simply ignored before resulting in transparent areas being black in PNG
2211         images for example.
2212         
2213         https://bugs.webkit.org/show_bug.cgi?id=30823
2214
2215         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2216         (WebCore::RGBA32Buffer::asNewNativeImage):
2217
2218 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2219
2220         Reviewed by Kenneth Rohde Christiansen.
2221
2222         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2223         https://bugs.webkit.org/show_bug.cgi?id=31040
2224
2225         No new tests as there is no functional change.
2226
2227         * dom/Document.cpp:
2228         (WebCore::Document::recalcStyleSelector):
2229         * editing/TextIterator.cpp:
2230         (WebCore::pushFullyClippedState):
2231         * editing/VisibleSelection.cpp:
2232         (WebCore::VisibleSelection::appendTrailingWhitespace):
2233         * html/HTMLLinkElement.cpp:
2234         (WebCore::HTMLLinkElement::process):
2235         * loader/RedirectScheduler.cpp:
2236         (WebCore::RedirectScheduler::mustLockBackForwardList):
2237         * loader/appcache/ApplicationCacheGroup.cpp:
2238         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2239         * platform/graphics/qt/FontCacheQt.cpp:
2240         (WebCore::FontPlatformDataCacheKey::computeHash):
2241         * rendering/RenderBlock.cpp:
2242         (WebCore::RenderBlock::handleRunInChild):
2243         * rendering/RenderBox.cpp:
2244         (WebCore::RenderBox::calcHeight):
2245         * rendering/RenderTextControlMultiLine.cpp:
2246         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2247         * rendering/style/RenderStyle.cpp:
2248         (WebCore::RenderStyle::diff):
2249         * svg/SVGAnimateElement.cpp:
2250         (WebCore::parseNumberValueAndUnit):
2251         * svg/SVGAnimationElement.cpp:
2252         (WebCore::SVGAnimationElement::startedActiveInterval):
2253         * svg/SVGPreserveAspectRatio.cpp:
2254         (WebCore::SVGPreserveAspectRatio::getCTM):
2255
2256 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
2257
2258         Reviewed by Dimitri Glazkov.
2259
2260         Win chromium is slow to draw transparent texts
2261         https://bugs.webkit.org/show_bug.cgi?id=31258
2262
2263         Clip graphics context to reduce calculation.
2264
2265         No new tests because this change only affects performance.
2266
2267         * platform/graphics/chromium/FontChromiumWin.cpp:
2268         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2269         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2270
2271 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
2272
2273         Reviewed by Darin Adler.
2274
2275         showTree(CounterNode*) generates too little info and has too many spaces.
2276         https://bugs.webkit.org/show_bug.cgi?id=31212
2277
2278         No new tests as the change has no functional effect it is just for
2279         improved debugging.
2280
2281         * rendering/CounterNode.cpp:
2282         (WebCore::showTreeAndMark):
2283         Changed to also show addresses of parent, next and previous
2284         siblings.
2285
2286 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
2287
2288         Reviewed by Darin Adler.
2289
2290         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2291         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2292
2293         https://bugs.webkit.org/show_bug.cgi?id=31083
2294
2295         No new tests; implementation is unchanged.
2296
2297         * page/Frame.cpp:
2298         (WebCore::Frame::setUseSecureKeyboardEntry):
2299         * page/mac/FrameMac.mm:
2300
2301 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2302
2303         Reviewed by Jan Alonzo.
2304
2305         Make XP_UNIX tests consistent
2306         https://bugs.webkit.org/show_bug.cgi?id=31250
2307
2308         No new tests as there is no functional change.
2309
2310         * plugins/PluginView.cpp:
2311         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2312         instead of the value of the macro
2313
2314         * plugins/gtk/PluginViewGtk.cpp:
2315         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2316         defined instead of using the PLATFORM macro to be consistent
2317         (WebCore::PluginView::getValue): Ditto.
2318
2319 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
2320
2321         Reviewed by Darin Adler.
2322
2323         Thunk to the main thread from ~Database to deref Database's m_document.
2324
2325         If the Database was the Document's last referrer, then ~Document occurs on the
2326         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2327         ASSERT in debug builds.
2328
2329         * storage/Database.cpp:
2330         (WebCore::derefDocument):
2331         (WebCore::Database::~Database):
2332
2333 2009-11-09  Mark Mentovai  <mark@chromium.org>
2334
2335         Reviewed by Dan Bernstein.
2336
2337         Track "can have scrollbar" state within FrameView independently of the
2338         individual scrollbar states in ScrollView.
2339
2340         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2341         REGRESSION (r48064): mint.com loses scrollbars after coming out of
2342         edit mode.
2343
2344         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2345         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2346
2347         Test: fast/overflow/scrollbar-restored.html
2348
2349         * WebCore.base.exp:
2350         * page/FrameView.cpp:
2351         (WebCore::FrameView::FrameView):
2352         (WebCore::FrameView::resetScrollbars):
2353         (WebCore::FrameView::setCanHaveScrollbars):
2354         (WebCore::FrameView::updateCanHaveScrollbars):
2355         (WebCore::FrameView::layout):
2356         * page/FrameView.h:
2357         * platform/ScrollView.h:
2358
2359 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
2360
2361         Reviewed by Timothy Hatcher.
2362
2363         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2364         https://bugs.webkit.org/show_bug.cgi?id=31257
2365
2366         * inspector/front-end/SourceFrame.js:
2367
2368 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
2369
2370         Reviewed by Timothy Hatcher.
2371
2372         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2373         https://bugs.webkit.org/show_bug.cgi?id=31252
2374
2375         Route F1-F12 keypresses in the Console view to the current panel if there is one.
2376
2377         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2378
2379         * inspector/front-end/ConsoleView.js:
2380         (WebInspector.ConsoleView.prototype._promptKeyDown):
2381         * inspector/front-end/utilities.js:
2382         ():
2383         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2384
2385 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2386
2387         Reviewed by Kenneth Rohde Christiansen.
2388
2389         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2390         https://bugs.webkit.org/show_bug.cgi?id=31208
2391
2392         After r42483, the credentials are no longer passed to the network request
2393         in the URL of the request.
2394         Pass the credentials from XMLHTTPRequest to the network request, the same
2395         way that other ports do.
2396
2397         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2398
2399         * platform/network/qt/ResourceHandleQt.cpp:
2400         (WebCore::ResourceHandle::start):
2401         (WebCore::ResourceHandle::loadResourceSynchronously):
2402
2403 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2404
2405         Unreviewed.
2406
2407         https://bugs.webkit.org/show_bug.cgi?id=31161
2408
2409         Roll back r50657 because it breaks the MAC builds.
2410
2411         * loader/ImageLoader.cpp:
2412         * loader/ProgressTracker.cpp:
2413         * loader/RedirectScheduler.cpp:
2414         * loader/Request.h:
2415         * loader/ThreadableLoaderClient.h:
2416         * loader/WorkerThreadableLoader.h:
2417         * loader/appcache/ApplicationCacheHost.h:
2418         * loader/appcache/ApplicationCacheStorage.h:
2419         * loader/icon/IconDatabaseClient.h:
2420
2421 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2422
2423         Reviewed by Darin Adler.
2424
2425         Allow custom memory allocation control for the part of loader directory in WebCore
2426         https://bugs.webkit.org/show_bug.cgi?id=31161
2427
2428         Inherits the following classes from Noncopyable because these are instantiated
2429         by 'new' and these are no need to be copyable:
2430
2431         class Request - WebCore/loader/loader.cpp:100
2432         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2433         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2434         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2435         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2436         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2437         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2438
2439         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
2440         MainThreadBridge is instantiated by 'new' in 
2441         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2442
2443         ThreadableLoaderClient's inheriting has been changed to public.
2444
2445         * loader/ImageLoader.cpp:
2446         * loader/ProgressTracker.cpp:
2447         * loader/RedirectScheduler.cpp:
2448         * loader/Request.h:
2449         * loader/ThreadableLoaderClient.h:
2450         * loader/WorkerThreadableLoader.h:
2451         * loader/appcache/ApplicationCacheHost.h:
2452         * loader/appcache/ApplicationCacheStorage.h:
2453         * loader/icon/IconDatabaseClient.h:
2454
2455 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2456
2457         Reviewed by Darin Adler.
2458
2459         Allow custom memory allocation control for WebCore's DocLoader
2460         https://bugs.webkit.org/show_bug.cgi?id=31163
2461
2462         Inherits DocLoader class from Noncopyable because it is
2463         instantiated by 'new' in WebCore/dom/Document.cpp:370 and 
2464         it is no need to be copyable.
2465
2466         * loader/DocLoader.h:
2467
2468 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2469
2470         Reviewed by Darin Adler.
2471
2472         Allow custom memory allocation control for WebCore's Tokenizer
2473         https://bugs.webkit.org/show_bug.cgi?id=31162
2474
2475         Inherits Tokenizer class from Noncopyable because (its child class)
2476         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178 
2477         and it is no need to be copyable.
2478
2479         * dom/Tokenizer.h:
2480
2481 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2482
2483         Reviewed by Darin Adler.
2484
2485         Allow custom memory allocation control for WebCore's DeleteButtonController
2486         https://bugs.webkit.org/show_bug.cgi?id=31105
2487
2488         Inherits DeleteButtonController class from Noncopyable because it is 
2489         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2490         it is no need to be copyable.  
2491
2492         * editing/DeleteButtonController.h:
2493
2494 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2495
2496         Reviewed by Jan Alonzo.
2497
2498         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2499         https://bugs.webkit.org/show_bug.cgi?id=30482
2500
2501         Expose Page::tabKeyCyclesThroughElements as a property of
2502         WebKitWebView.
2503
2504         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2505
2506         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2507         (WebCore::singleCharacterString):
2508
2509 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2510
2511         Reviewed by Xan Lopez.
2512
2513         https://bugs.webkit.org/show_bug.cgi?id=25415
2514         [GTK][ATK] Please implement support for get_text_at_offset
2515
2516         Fix a crasher that occurred with text which included newline
2517         chars in the markup.
2518
2519         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2520         (convertUniCharToUTF8):
2521
2522 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
2523
2524         Reviewed by Holger Freyther.
2525
2526         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2527         https://bugs.webkit.org/show_bug.cgi?id=31144
2528
2529         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2530         documents that end prematurely but are not considered invalid by QXmlStream.
2531         This is to stay compatible with the libxml2 implementation.
2532         However, that code path would be also hit in situations when it should not,
2533         i.e. the error would have already been caught and handled. As a result, the
2534         same error would be reported twice.
2535
2536         No new tests, because the problem is already covered by
2537         fast/parser/xml-declaration-missing-ending-mark.html.
2538
2539         * dom/XMLTokenizerQt.cpp:
2540         (WebCore::XMLTokenizer::doEnd):
2541
2542 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
2543
2544         Reviewed by Pavel Feldman.
2545
2546         Web Inspector: Inspector should support copy() in the command line
2547         https://bugs.webkit.org/show_bug.cgi?id=31238
2548
2549         * inspector/InspectorBackend.cpp:
2550         (WebCore::InspectorBackend::copyText): Added.
2551         * inspector/InspectorBackend.h: Added copyText
2552         * inspector/InspectorBackend.idl: Added copyText
2553         * inspector/front-end/InjectedScript.js:
2554         (InjectedScript._copy): Added.
2555         (InjectedScript._ensureCommandLineAPIInstalled):
2556
2557 2009-11-08  Drew Wilson  <atwilson@chromium.org>
2558
2559         Reviewed by Dimitri Glazkov.
2560
2561         V8 WorkerContextExecutionProxy does not handle SharedWorkers
2562         https://bugs.webkit.org/show_bug.cgi?id=31226
2563
2564         Now checks to see what type of context is active and creates the
2565         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2566
2567         Added support for converting to SharedWorkers and SharedWorkerContexts.
2568
2569         Test: Existing layout tests cover this case (start passing in Chrome).
2570
2571         * bindings/v8/WorkerContextExecutionProxy.cpp:
2572         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2573         Now generates the right type of DOMWrapper for SharedWorkerContexts.
2574         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2575         Added support for SHAREDWORKERCONTEXT.
2576         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2577         Added support for SharedWorker and SharedWorkerContext.
2578
2579 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
2580
2581         Reviewed by Dimitri Glazkov.
2582
2583         https://bugs.webkit.org/show_bug.cgi?id=31224
2584         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
2585
2586         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
2587
2588         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2589         (WebCore::NAMED_PROPERTY_GETTER):
2590
2591 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2592
2593         Reviewed by Timothy Hatcher.
2594
2595         Web Inspector: "Search again" on scripts panel switches
2596         to the script this search started with.
2597
2598         https://bugs.webkit.org/show_bug.cgi?id=31243
2599
2600         * inspector/front-end/Panel.js:
2601         (WebInspector.Panel.prototype.jumpToNextSearchResult):
2602
2603 2009-11-08  Kent Tamura  <tkent@chromium.org>
2604
2605         Reviewed by Darin Adler.
2606
2607         Simplify Icon interface.
2608         https://bugs.webkit.org/show_bug.cgi?id=31154
2609
2610         - Remove Icon::createIconForFile().  createIconForFiles() covers
2611           createIconForFile()'s role.
2612         - Remove FileChooser::chooseIcon()
2613         - Change the parameter types of FileChooser constructor and the
2614           factory method, String -> const Vector<String>&, in order to
2615           support initialization with multiple files.
2616         - Remove the icon loading code in IconChromiumWin.cpp, which
2617           doesn't work because of the sandbox.
2618
2619         No tests because it's just a refactoring.
2620
2621         * platform/FileChooser.cpp:
2622         (WebCore::FileChooser::FileChooser):
2623         (WebCore::FileChooser::create):
2624         (WebCore::FileChooser::chooseFile):
2625         (WebCore::FileChooser::chooseFiles):
2626         * platform/FileChooser.h:
2627         * platform/graphics/Icon.h:
2628         * platform/graphics/chromium/IconChromiumLinux.cpp:
2629         * platform/graphics/chromium/IconChromiumMac.cpp:
2630         * platform/graphics/chromium/IconChromiumWin.cpp:
2631         (WebCore::Icon::createIconForFiles):
2632         * platform/graphics/gtk/IconGtk.cpp:
2633         (WebCore::Icon::createIconForFiles):
2634         * platform/graphics/haiku/IconHaiku.cpp:
2635         * platform/graphics/mac/IconMac.mm:
2636         (WebCore::Icon::createIconForFiles):
2637         * platform/graphics/qt/IconQt.cpp:
2638         (WebCore::Icon::createIconForFiles):
2639         * platform/graphics/win/IconWin.cpp:
2640         (WebCore::Icon::createIconForFiles):
2641         * platform/graphics/wx/IconWx.cpp:
2642         * rendering/RenderFileUploadControl.cpp:
2643         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2644
2645 2009-11-08  Daniel Bates  <dbates@webkit.org>
2646
2647         Reviewed by Adam Barth.
2648
2649         https://bugs.webkit.org/show_bug.cgi?id=31098
2650
2651         Allows same-origin plugin-based content to load.
2652
2653         Test: http/tests/security/xssAuditor/object-src-inject.html
2654
2655         * page/XSSAuditor.cpp:
2656         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
2657         (WebCore::XSSAuditor::canLoadObject): Ditto.
2658         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 
2659         (WebCore::XSSAuditor::isSameOriginResource): Added.
2660         * page/XSSAuditor.h:
2661
2662 2009-11-08  David Levin  <levin@chromium.org>
2663
2664         Reviewed by NOBODY (chromium build fix).
2665
2666         * platform/network/HTTPParsers.cpp:
2667         (WebCore::parseDate): Changed this to not
2668         use a date parser that needs ExecState passed.
2669         
2670 2009-11-08  David Levin  <levin@chromium.org>
2671
2672         Unreviewed build fix for chromium.
2673
2674         * platform/graphics/skia/GraphicsContextSkia.cpp:
2675         (WebCore::GraphicsContext::fillPath):
2676         (WebCore::GraphicsContext::fillRect):
2677         (WebCore::GraphicsContext::strokePath):
2678         (WebCore::GraphicsContext::strokeRect):
2679
2680 2009-11-08  David Levin  <levin@chromium.org>
2681
2682         Unreviewed build fix for chromium.
2683
2684         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
2685         Clean up GraphicsContext's current concept of ColorSpace
2686
2687         * platform/graphics/skia/GraphicsContextSkia.cpp:
2688         (WebCore::GraphicsContext::fillPath):
2689         (WebCore::GraphicsContext::fillRect):
2690         (WebCore::GraphicsContext::strokePath):
2691         (WebCore::GraphicsContext::strokeRect):
2692
2693 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2694
2695         Reviewed by Timothy Hatcher.
2696
2697         Web Inspector: [REGRESSION] committing style edit
2698         clears elements panel selection.
2699
2700         https://bugs.webkit.org/show_bug.cgi?id=31242
2701
2702         * inspector/front-end/ElementsTreeOutline.js:
2703         (WebInspector.ElementsTreeOutline.prototype.update):
2704         * inspector/front-end/StylesSidebarPane.js:
2705         (WebInspector.StylePropertyTreeElement.prototype.):
2706         (WebInspector.StylePropertyTreeElement.prototype):
2707
2708 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
2709
2710         Reviewed by Holger Freyther.
2711
2712         ResourceRequest to be class instead of struct
2713         https://bugs.webkit.org/show_bug.cgi?id=30670
2714
2715         Started as a compilation fix for Symbian where the compiler makes a distinction between
2716         class and struct in function argument signatures.
2717         Changed all forward declarations of ResourceRequest to have class in the forward
2718         declaration instead of struct and changed the definition of ResourceRequest to be class
2719         and added access qualifiers where missing. Additionally two references of friend
2720         struct ResourceRequestBase changed to class instead.
2721
2722         * history/HistoryItem.h:
2723         * inspector/InspectorController.h:
2724         * inspector/InspectorResource.h:
2725         * loader/DocumentThreadableLoader.h:
2726         * loader/FrameLoaderClient.h:
2727         * loader/MainResourceLoader.h:
2728         * loader/ResourceLoadNotifier.h:
2729         * loader/SubresourceLoader.h:
2730         * loader/SubresourceLoaderClient.h:
2731         * loader/ThreadableLoader.h:
2732         * loader/WorkerThreadableLoader.h:
2733         * loader/appcache/ApplicationCache.h:
2734         * loader/appcache/ApplicationCacheHost.h:
2735         * platform/CrossThreadCopier.h:
2736         * platform/network/ResourceHandle.h:
2737         * platform/network/ResourceHandleClient.h:
2738         * platform/network/ResourceRequestBase.h:
2739         * platform/network/cf/ResourceRequest.h:
2740         * platform/network/cf/ResourceRequestCFNet.h:
2741         * platform/network/chromium/ResourceRequest.h:
2742         * platform/network/curl/ResourceRequest.h:
2743         * platform/network/qt/ResourceRequest.h:
2744         * platform/network/soup/ResourceRequest.h:
2745         * xml/XMLHttpRequest.h:
2746
2747 2009-11-08  Dan Bernstein  <mitz@apple.com>
2748
2749         Reviewed by Simon Fraser.
2750
2751         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
2752         below FrameView::layout
2753         https://bugs.webkit.org/show_bug.cgi?id=31093
2754
2755         Test: fast/block/positioning/relative-positioned-inline-container.html
2756
2757         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
2758         to mark the object for layout, doing so without marking its ancestors.
2759         However, RenderBlock::skipLeadingWhitespace and
2760         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
2761         positioned inline container, causing it to be marked for layout without
2762         ever going back to give it layout, and thus layout could end with a
2763         dirty object still in the tree, leading to all sorts of badness.
2764
2765         The fix is to revert setStaticY() to not marking the object dirty, and
2766         instead do it in the call sites that require it, which are in
2767         RenderBlock and RenderFlexibleBox.
2768
2769         * rendering/RenderBlock.cpp:
2770         (WebCore::RenderBlock::adjustPositionedBlock):
2771         * rendering/RenderFlexibleBox.cpp:
2772         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2773         (WebCore::RenderFlexibleBox::layoutVerticalBox):
2774         * rendering/RenderLayer.cpp:
2775         * rendering/RenderLayer.h:
2776         (WebCore::RenderLayer::setStaticY):
2777
2778 2009-11-07  Daniel Bates  <dbates@webkit.org>
2779
2780         Reviewed by Darin Adler.
2781
2782         https://bugs.webkit.org/show_bug.cgi?id=20780
2783         
2784         Fixes an issue where the onchange event handler is not fired when the 
2785         input field is autocompleted.
2786         
2787         We cannot test this using DRT since DRT cannot emulate autocompletion.
2788         So, a manual-test is included.
2789
2790         Tests: manual-tests/autocompletion-fire-onchange.html
2791
2792         * manual-tests/autocompletion-fire-onchange.html: Added.
2793         * rendering/RenderTextControl.cpp:
2794         (WebCore::RenderTextControl::setInnerTextValue):
2795
2796 2009-11-07  Benjamin Otte  <otte@gnome.org>
2797
2798         Reviewed by Holger Freyther.
2799
2800         Mark redrawn areas on image surfaces as dirty.
2801
2802         This is required to conform to the Cairo API, but is currently only
2803         used by debugging tools like cairo-trace.
2804
2805         * platform/graphics/cairo/ImageBufferCairo.cpp:
2806         (WebCore::ImageBuffer::platformTransformColorSpace):
2807         (WebCore::putImageData):
2808
2809 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2810
2811         Reviewed by Xan Lopez.
2812
2813         https://bugs.webkit.org/show_bug.cgi?id=30878
2814         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
2815
2816         If the end_offset is -1, use the String length as the end_offset.
2817
2818         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2819         (webkit_accessible_text_get_text):
2820
2821 2009-11-06  Beth Dakin  <bdakin@apple.com>
2822
2823         Reviewed by Adele Peterson.
2824
2825         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up 
2826         GraphicsContext's current concept of ColorSpace
2827
2828         ColorSpace is now called ColorType. The variables on the state we 
2829         appropriately re-named as well. I removed strokeColorSpace() and 
2830         fillColorSpace() from GraphicsContext since they were never called. 
2831
2832         * platform/graphics/GraphicsContext.cpp:
2833         (WebCore::GraphicsContext::setStrokeColor):
2834         (WebCore::GraphicsContext::setFillColor):
2835         (WebCore::GraphicsContext::setStrokePattern):
2836         (WebCore::GraphicsContext::setFillPattern):
2837         (WebCore::GraphicsContext::setStrokeGradient):
2838         (WebCore::GraphicsContext::setFillGradient):
2839         * platform/graphics/GraphicsContext.h:
2840         (WebCore::):
2841         * platform/graphics/GraphicsContextPrivate.h:
2842         (WebCore::GraphicsContextState::GraphicsContextState):
2843         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2844         (WebCore::GraphicsContext::fillPath):
2845         (WebCore::GraphicsContext::strokePath):
2846         * platform/graphics/cg/GraphicsContextCG.cpp:
2847         (WebCore::calculateDrawingMode):
2848         (WebCore::GraphicsContext::drawPath):
2849         (WebCore::GraphicsContext::fillPath):
2850         (WebCore::GraphicsContext::strokePath):
2851         (WebCore::GraphicsContext::fillRect):
2852         (WebCore::GraphicsContext::strokeRect):
2853         * platform/graphics/qt/GraphicsContextQt.cpp:
2854         (WebCore::GraphicsContext::fillPath):
2855         (WebCore::GraphicsContext::strokePath):
2856         (WebCore::GraphicsContext::fillRect):
2857         * platform/graphics/wince/GraphicsContextWince.cpp:
2858         (WebCore::GraphicsContext::fillPath):
2859         (WebCore::GraphicsContext::fillRect):
2860
2861 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
2862
2863         Reviewed by Tim Hatcher.
2864
2865         Fixes <http://webkit.org/b/31177>.
2866         Web Inspector: Bind backspace to delete cookies and DOM Storage.
2867         
2868         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
2869         places in the inspector can use editing in DataGrid (added a FIXME for
2870         some stuff that needs to be generalized).
2871         
2872         Also added deleting functionality to DataGrid, and implemented it for
2873         Cookies and DOM Storage. The reason this patch is so big is because of
2874         the refactoring of editing code, which won't be used yet in a cross-datagrid
2875         way, but should be able to.
2876         
2877         Additionally, moved the callbacks members from DOMStorageDataGrid to
2878         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to 
2879         make the architecture of DOM Storage look a lot more like the Cookies view.
2880         
2881         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the 
2882         inspector from beeping at you when you delete an element.
2883
2884         * WebCore.gypi: Removed DOMStorageDataGrid.
2885         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
2886         * inspector/front-end/CookieItemsView.js:
2887         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
2888         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
2889         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2890         * inspector/front-end/DOMStorageDataGrid.js: Removed.
2891         * inspector/front-end/DOMStorageItemsView.js:
2892         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2893         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
2894         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
2895         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
2896         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
2897         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
2898         * inspector/front-end/DataGrid.js:
2899         (WebInspector.DataGrid):
2900         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
2901         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
2902         (WebInspector.DataGrid.prototype._startEditing): Ditto.
2903         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
2904         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
2905         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
2906         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
2907         * inspector/front-end/ElementsTreeOutline.js:
2908         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
2909         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
2910         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
2911
2912 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2913
2914         Qt build fix: added an ExecState parameter.
2915
2916         * bridge/qt/qt_runtime.cpp:
2917         (JSC::Bindings::convertValueToQVariant):
2918         (JSC::Bindings::convertQVariantToValue):
2919
2920 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2921
2922         https://bugs.webkit.org/show_bug.cgi?id=31197
2923         Implemented a timezone cache not based on Mac OS X's notify_check API.
2924
2925         Updated for JavaScriptCore internal API change.
2926
2927         * bridge/qt/qt_runtime.cpp:
2928         (JSC::Bindings::convertValueToQVariant):
2929         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
2930
2931         * platform/network/HTTPParsers.cpp:
2932         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
2933         (This function probably shouldn't be using a JavaScript date parser
2934         to begin with, but oh well.)
2935
2936 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2937
2938         Reviewed by Adam Barth.
2939
2940         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
2941         which affects Chromium only.
2942         
2943         Changes to V8HTMLDocumentCustom.cpp are as below:-
2944         1. The HTMLDocumentOpen function would cause a crash in Chromium if
2945            there was no calling javascript context. We now check for this case
2946            and pass in NULL to the HTMLDocument::open function which can handle
2947            a NULL document parameter.
2948         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
2949            had ASSERTS for a NULL caller frame, which was bogus as it would crash
2950            anyway. We now check for this case and return a failure.
2951            
2952         Changes to V8DOMWindowCustom.cpp are as below:-
2953         1. Instead of failing the window.open call made by NPAPI for lack of a
2954            calling javascript context, we now use the entered context as the calling
2955            context.
2956
2957         Tests: plugins/document-open.html
2958                plugins/window-open.html
2959
2960         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2961         (WebCore::CALLBACK_FUNC_DECL):
2962         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
2963         (WebCore::CALLBACK_FUNC_DECL):
2964
2965 2009-11-06  Steve Block  <steveblock@google.com>
2966
2967         Reviewed by Eric Seidel.
2968
2969         Geolocation error code UNKNOWN_ERROR is deprecated.
2970         https://bugs.webkit.org/show_bug.cgi?id=31184
2971
2972         Remove this error code from PositionError, both for use from C++ code and from the JS object.
2973
2974         Updated fast/dom/Geolocation/error.html to test this.
2975
2976         * page/PositionError.h: Modified.
2977         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
2978         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
2979         * page/Geolocation.cpp: Modified.
2980         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2981         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
2982         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2983
2984 2009-11-06  Dirk Schulze  <krit@webkit.org>
2985
2986         Reviewed by Nikolas Zimmermann.
2987
2988         feMorphology filter is not implemented
2989         [https://bugs.webkit.org/show_bug.cgi?id=5863]
2990
2991         The Implementation of feMorphology.
2992         
2993         Test: We have allready a test for feMorphology
2994               svg/W3C-SVG-1.1/filters-morph-01-f.svg
2995
2996         * svg/graphics/filters/SVGFEMorphology.cpp:
2997         (WebCore::FEMorphology::apply):
2998
2999 2009-11-06  Steve Block  <steveblock@google.com>
3000
3001         Reviewed by Eric Seidel.
3002
3003         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
3004         https://bugs.webkit.org/show_bug.cgi?id=31209
3005
3006         Build fix only. No new tests possible.
3007
3008         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
3009
3010 2009-11-06  Drew Wilson  <atwilson@chromium.org>
3011
3012         Reviewed by David Levin.
3013
3014         V8 bindings do not support SharedWorkers as event targets
3015         https://bugs.webkit.org/show_bug.cgi?id=31199
3016
3017         No new tests because existing layout tests suffice (they currently
3018         crash on Chromium)
3019
3020         * bindings/v8/V8DOMWrapper.cpp:
3021         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
3022         Added clause to create a DOM wrapper for SharedWorkers.
3023
3024 2009-11-06  Anton Muhin  <antonm@chromium.org>
3025
3026         Reviewed by Adam Barth.
3027
3028         Do not unnecessarly synchronzie in weak reference callbacks.
3029         https://bugs.webkit.org/show_bug.cgi?id=31191
3030
3031         * bindings/v8/DOMData.h:
3032         (WebCore::DOMData::handleWeakObject):
3033
3034 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
3035
3036         Reviewed by Pavel Feldman.
3037
3038         Fix resource content search.
3039         https://bugs.webkit.org/show_bug.cgi?id=31202
3040
3041         * inspector/front-end/AbstractTimelinePanel.js:
3042         (WebInspector.AbstractTimelinePanel.prototype.refresh):
3043         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3044         * inspector/front-end/TimelinePanel.js:
3045         (WebInspector.TimelineGraph.prototype.refresh):
3046
3047 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
3048
3049         Reviewed by Eric Seidel.
3050
3051         Fix ASSERT(currentStyle = renderStyle()).
3052         https://bugs.webkit.org/show_bug.cgi?id=31152
3053
3054         * dom/Element.cpp:
3055         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
3056
3057 2009-11-05  Alpha Lam  <hclam@chromium.org>
3058
3059         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
3060
3061         * bindings/v8/V8GCController.cpp:
3062         (WebCore::V8GCController::gcEpilogue):
3063         * bindings/v8/V8GCController.h:
3064         * bindings/v8/V8Proxy.cpp:
3065         (WebCore::V8Proxy::evaluate):
3066         (WebCore::V8Proxy::runScript):
3067         (WebCore::V8Proxy::callFunction):
3068
3069 2009-11-05  Adam Barth  <abarth@webkit.org>
3070
3071         Reviewed by Sam Weinig.
3072
3073         Cross-domain access to stylesheet text should not be allowed
3074         https://bugs.webkit.org/show_bug.cgi?id=20527
3075
3076         Check whether whether the current document can read the cssRules from
3077         the style sheet.  Firefox throws a security error here, but we return
3078         null instead because that's what we usually do in these cases.
3079
3080         Test: http/tests/security/cannot-read-cssrules-redirect.html
3081               http/tests/security/cannot-read-cssrules.html
3082
3083         * css/CSSStyleSheet.cpp:
3084         (WebCore::CSSStyleSheet::cssRules):
3085
3086 2009-11-05  Steve Block  <steveblock@google.com>
3087
3088         Reviewed by Eric Seidel.
3089
3090         If the Geolocation service fails to start, invoke the error callback asynchronously.
3091         https://bugs.webkit.org/show_bug.cgi?id=28276
3092
3093         All Geolocation callbacks must be invoked asynchronously.
3094         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
3095
3096         No new tests possible with current LayoutTestController.
3097
3098         * page/Geolocation.cpp:
3099         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
3100         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
3101         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
3102
3103 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3104
3105         Reviewed by Eric Seidel.
3106
3107         Removed the "this is part of the KDE project" comments from 
3108         all *.h, *.cpp, *.idl, and *.pm files.
3109         
3110         https://bugs.webkit.org/show_bug.cgi?id=31167
3111         
3112         The maintenance and architecture page in the project wiki lists
3113         this as a task.
3114         
3115         This change includes no changes or additions to test cases 
3116         since the change affects only comments.
3117
3118         * bindings/scripts/CodeGeneratorV8.pm:
3119         * bindings/scripts/IDLParser.pm:
3120         * bindings/scripts/IDLStructure.pm:
3121         * css/CSSInheritedValue.cpp:
3122         * css/CSSInitialValue.cpp:
3123         * css/CSSMediaRule.cpp:
3124         * css/CSSNamespace.h:
3125         * css/CSSProperty.cpp:
3126         * css/CSSProperty.h:
3127         * css/CSSRuleList.cpp:
3128         * css/CSSRuleList.h:
3129         * css/CSSSelector.h:
3130         * css/CSSValueList.cpp:
3131         * css/FontValue.cpp:
3132         * css/MediaFeatureNames.cpp:
3133         * css/MediaFeatureNames.h:
3134         * css/Pair.h:
3135         * css/SVGCSSStyleSelector.cpp:
3136         * css/ShadowValue.cpp:
3137         * css/StyleSheet.cpp:
3138         * css/StyleSheetList.cpp:
3139         * css/maketokenizer:
3140         * dom/BeforeUnloadEvent.cpp:
3141         * dom/BeforeUnloadEvent.h:
3142         * dom/CSSMappedAttributeDeclaration.cpp:
3143         * dom/EventNames.cpp:
3144         * dom/EventTarget.cpp:
3145         * dom/MappedAttributeEntry.h:
3146         * dom/MouseRelatedEvent.h:
3147         * dom/RangeException.h:
3148         * dom/StyleElement.h:
3149         * dom/Tokenizer.h:
3150         * html/HTMLHeadElement.h:
3151         * html/HTMLHeadingElement.cpp:
3152         * html/HTMLHeadingElement.h:
3153         * html/HTMLHtmlElement.h:
3154         * html/HTMLImageLoader.h:
3155         * html/HTMLMetaElement.h:
3156         * html/HTMLModElement.cpp:
3157         * html/HTMLModElement.h:
3158         * html/HTMLOptionsCollection.cpp:
3159         * html/HTMLPlugInElement.cpp:
3160         * html/HTMLPreElement.cpp:
3161         * html/HTMLPreElement.h:
3162         * html/HTMLTableCellElement.cpp:
3163         * html/HTMLTableCellElement.h:
3164         * html/HTMLTableColElement.cpp:
3165         * html/HTMLTableColElement.h:
3166         * html/HTMLTablePartElement.cpp:
3167         * html/HTMLTablePartElement.h:
3168         * html/HTMLTitleElement.h:
3169         * page/MouseEventWithHitTestResults.h:
3170         * platform/StaticConstructors.h:
3171         * platform/text/AtomicStringImpl.h:
3172         * platform/text/qt/TextBreakIteratorQt.cpp:
3173         * rendering/AutoTableLayout.h:
3174         * rendering/CounterNode.cpp:
3175         * rendering/EllipsisBox.cpp:
3176         * rendering/EllipsisBox.h:
3177         * rendering/FixedTableLayout.cpp:
3178         * rendering/FixedTableLayout.h:
3179         * rendering/HitTestRequest.h:
3180         * rendering/HitTestResult.h:
3181         * rendering/InlineRunBox.h:
3182         * rendering/PointerEventsHitRules.cpp:
3183         * rendering/PointerEventsHitRules.h:
3184         * rendering/RenderBR.cpp:
3185         * rendering/RenderBR.h:
3186         * rendering/RenderButton.cpp:
3187         * rendering/RenderButton.h:
3188         * rendering/RenderFieldset.cpp:
3189         * rendering/RenderFrameSet.cpp:
3190         * rendering/RenderListItem.cpp:
3191         * rendering/RenderTableRow.cpp:
3192         * rendering/RenderView.h:
3193         * rendering/RootInlineBox.h:
3194         * rendering/SVGInlineTextBox.cpp:
3195         * rendering/SVGInlineTextBox.h:
3196         * rendering/TableLayout.h:
3197         * rendering/break_lines.h:
3198         * rendering/style/SVGRenderStyle.cpp:
3199         * rendering/style/SVGRenderStyle.h:
3200         * rendering/style/SVGRenderStyleDefs.cpp:
3201         * rendering/style/SVGRenderStyleDefs.h:
3202         * svg/GradientAttributes.h:
3203         * svg/LinearGradientAttributes.h:
3204         * svg/PatternAttributes.h:
3205         * svg/RadialGradientAttributes.h:
3206         * svg/SVGAElement.cpp:
3207         * svg/SVGAngle.idl:
3208         * svg/SVGAnimateColorElement.cpp:
3209         * svg/SVGAnimateColorElement.h:
3210         * svg/SVGAnimateElement.cpp:
3211         * svg/SVGAnimateElement.h:
3212         * svg/SVGAnimateTransformElement.h:
3213         * svg/SVGAnimatedPathData.cpp:
3214         * svg/SVGAnimatedPathData.h:
3215         * svg/SVGAnimatedPoints.cpp:
3216         * svg/SVGAnimatedPoints.h:
3217         * svg/SVGAnimationElement.cpp:
3218         * svg/SVGCircleElement.cpp:
3219         * svg/SVGClipPathElement.cpp:
3220         * svg/SVGColor.cpp:
3221         * svg/SVGColor.idl:
3222         * svg/SVGComponentTransferFunctionElement.cpp:
3223         * svg/SVGComponentTransferFunctionElement.h:
3224         * svg/SVGCursorElement.cpp:
3225         * svg/SVGDefsElement.cpp:
3226         * svg/SVGDescElement.cpp:
3227         * svg/SVGDescElement.h:
3228         * svg/SVGDocument.idl:
3229         * svg/SVGElement.idl:
3230         * svg/SVGElementInstanceList.cpp:
3231         * svg/SVGElementInstanceList.h:
3232         * svg/SVGEllipseElement.cpp:
3233         * svg/SVGExternalResourcesRequired.cpp:
3234         * svg/SVGFEBlendElement.cpp:
3235         * svg/SVGFEBlendElement.h:
3236         * svg/SVGFEColorMatrixElement.cpp:
3237         * svg/SVGFEColorMatrixElement.h:
3238         * svg/SVGFEComponentTransferElement.cpp:
3239         * svg/SVGFEComponentTransferElement.h:
3240         * svg/SVGFECompositeElement.cpp:
3241         * svg/SVGFECompositeElement.h:
3242         * svg/SVGFEFloodElement.cpp:
3243         * svg/SVGFEFloodElement.h:
3244         * svg/SVGFEFuncAElement.cpp:
3245         * svg/SVGFEFuncAElement.h:
3246         * svg/SVGFEFuncBElement.cpp:
3247         * svg/SVGFEFuncBElement.h:
3248         * svg/SVGFEFuncGElement.cpp:
3249         * svg/SVGFEFuncGElement.h:
3250         * svg/SVGFEFuncRElement.cpp:
3251         * svg/SVGFEFuncRElement.h:
3252         * svg/SVGFEGaussianBlurElement.cpp:
3253         * svg/SVGFEGaussianBlurElement.h:
3254         * svg/SVGFEImageElement.cpp:
3255         * svg/SVGFEMergeElement.cpp:
3256         * svg/SVGFEMergeElement.h:
3257         * svg/SVGFEMergeNodeElement.cpp:
3258         * svg/SVGFEOffsetElement.cpp:
3259         * svg/SVGFEOffsetElement.h:
3260         * svg/SVGFETileElement.cpp:
3261         * svg/SVGFETileElement.h:
3262         * svg/SVGFETurbulenceElement.cpp:
3263         * svg/SVGFETurbulenceElement.h:
3264         * svg/SVGFilterElement.cpp:
3265         * svg/SVGGElement.cpp:
3266         * svg/SVGGradientElement.cpp:
3267         * svg/SVGHKernElement.idl:
3268         * svg/SVGLangSpace.cpp:
3269         * svg/SVGLangSpace.h:
3270         * svg/SVGLength.cpp:
3271         * svg/SVGLength.h:
3272         * svg/SVGLength.idl:
3273         * svg/SVGLengthList.cpp:
3274         * svg/SVGLengthList.h:
3275         * svg/SVGLineElement.cpp:
3276         * svg/SVGLinearGradientElement.h:
3277         * svg/SVGList.h:
3278         * svg/SVGListTraits.h:
3279         * svg/SVGLocatable.h:
3280         * svg/SVGMaskElement.cpp:
3281         * svg/SVGMatrix.idl:
3282         * svg/SVGMetadataElement.cpp:
3283         * svg/SVGMetadataElement.h:
3284         * svg/SVGMetadataElement.idl:
3285         * svg/SVGNumber.idl:
3286         * svg/SVGNumberList.cpp:
3287         * svg/SVGNumberList.h:
3288         * svg/SVGPaint.cpp:
3289         * svg/SVGPathElement.cpp:
3290         * svg/SVGPathSeg.h:
3291         * svg/SVGPathSegArc.cpp:
3292         * svg/SVGPathSegArc.h:
3293         * svg/SVGPathSegClosePath.cpp:
3294         * svg/SVGPathSegClosePath.h:
3295         * svg/SVGPathSegCurvetoCubic.cpp:
3296         * svg/SVGPathSegCurvetoCubic.h:
3297         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
3298         * svg/SVGPathSegCurvetoCubicSmooth.h:
3299         * svg/SVGPathSegCurvetoQuadratic.cpp:
3300         * svg/SVGPathSegCurvetoQuadratic.h:
3301         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
3302         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
3303         * svg/SVGPathSegLineto.cpp:
3304         * svg/SVGPathSegLineto.h:
3305         * svg/SVGPathSegLinetoHorizontal.cpp:
3306         * svg/SVGPathSegLinetoHorizontal.h:
3307         * svg/SVGPathSegLinetoVertical.cpp:
3308         * svg/SVGPathSegLinetoVertical.h:
3309         * svg/SVGPathSegMoveto.cpp:
3310         * svg/SVGPathSegMoveto.h:
3311         * svg/SVGPatternElement.cpp:
3312         * svg/SVGPoint.idl:
3313         * svg/SVGPointList.cpp:
3314         * svg/SVGPointList.h:
3315         * svg/SVGPolyElement.cpp:
3316         * svg/SVGPolygonElement.cpp:
3317         * svg/SVGPolygonElement.h:
3318         * svg/SVGPolylineElement.cpp:
3319         * svg/SVGPolylineElement.h:
3320         * svg/SVGPreserveAspectRatio.cpp:
3321         * svg/SVGPreserveAspectRatio.h:
3322         * svg/SVGRadialGradientElement.h:
3323         * svg/SVGRect.idl:
3324         * svg/SVGRectElement.cpp:
3325         * svg/SVGRenderingIntent.h:
3326         * svg/SVGSVGElement.idl:
3327         * svg/SVGScriptElement.cpp:
3328         * svg/SVGSetElement.cpp:
3329         * svg/SVGSetElement.h:
3330         * svg/SVGStopElement.cpp:
3331         * svg/SVGStringList.cpp:
3332         * svg/SVGStringList.h:
3333         * svg/SVGStylable.cpp:
3334         * svg/SVGStylable.h:
3335         * svg/SVGStyleElement.cpp:
3336         * svg/SVGStyleElement.h:
3337         * svg/SVGStyledElement.h:
3338         * svg/SVGStyledLocatableElement.cpp:
3339         * svg/SVGStyledLocatableElement.h:
3340         * svg/SVGStyledTransformableElement.cpp:
3341         * svg/SVGStyledTransformableElement.h:
3342         * svg/SVGSwitchElement.cpp:
3343         * svg/SVGSymbolElement.cpp:
3344         * svg/SVGTRefElement.cpp:
3345         * svg/SVGTSpanElement.cpp:
3346         * svg/SVGTSpanElement.h:
3347         * svg/SVGTests.h:
3348         * svg/SVGTextElement.cpp:
3349         * svg/SVGTextElement.h:
3350         * svg/SVGTextPathElement.cpp:
3351         * svg/SVGTextPositioningElement.cpp:
3352         * svg/SVGTextPositioningElement.h:
3353         * svg/SVGTitleElement.cpp:
3354         * svg/SVGTitleElement.h:
3355         * svg/SVGTransform.cpp:
3356         * svg/SVGTransform.h:
3357         * svg/SVGTransform.idl:
3358         * svg/SVGTransformList.cpp:
3359         * svg/SVGTransformList.h:
3360         * svg/SVGTransformable.h:
3361         * svg/SVGURIReference.h:
3362         * svg/SVGUnitTypes.h:
3363         * svg/SVGUseElement.cpp:
3364         * svg/SVGViewElement.cpp:
3365         * svg/SVGZoomAndPan.cpp:
3366         * svg/SVGZoomAndPan.h:
3367         * svg/SVGZoomEvent.cpp:
3368
3369 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3370
3371         Reviewed by Dimitri Glazkov.
3372
3373         REGRESSION Clean up security origin usage in DOM Storage.
3374         https://bugs.webkit.org/show_bug.cgi?id=31188
3375
3376         Clean up security origin usage in DOM Storage.  This fixes a bug in my
3377         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
3378
3379         Instead of having StorageAreaSync's constructor (which is called in the
3380         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
3381         database identifier, simply have StorageAreaImpl pass the identifier into
3382         StorageAreaSync.
3383
3384         No test because there's no change in externally observable behavior.
3385
3386         * storage/StorageAreaImpl.cpp:
3387         (WebCore::StorageAreaImpl::StorageAreaImpl):
3388         * storage/StorageAreaImpl.h:
3389         * storage/StorageAreaSync.cpp:
3390         (WebCore::StorageAreaSync::create):
3391         (WebCore::StorageAreaSync::StorageAreaSync):
3392         * storage/StorageAreaSync.h:
3393
3394 2009-11-05  Scott Violet  <sky@google.com>
3395
3396         Reviewed by Dimitri Glazkov.
3397
3398         Need notification of scrolling frame
3399         https://bugs.webkit.org/show_bug.cgi?id=31145
3400
3401         Adds FrameLoaderClient::didChangeScrollOffset that is called when
3402         the frame scrolls. This will be used to know when history state
3403         needs to be updated.
3404
3405         * loader/FrameLoaderClient.h:
3406         (WebCore::FrameLoaderClient::didChangeScrollOffset):
3407         * page/FrameView.cpp:
3408         (WebCore::FrameView::valueChanged):
3409
3410 2009-11-05  Kenneth Russell  <kbr@google.com>
3411
3412         Reviewed by Dimitri Glazkov.
3413
3414         [V8] Update bindings to use new API for external arrays
3415         https://bugs.webkit.org/show_bug.cgi?id=31181
3416
3417         No new tests; covered by existing WebGL tests.
3418
3419         * bindings/v8/V8DOMWrapper.cpp:
3420         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
3421         (WebCore::V8DOMWrapper::getTemplate):
3422         (WebCore::V8DOMWrapper::convertToV8Object):
3423         * bindings/v8/V8DOMWrapper.h:
3424         * bindings/v8/custom/V8CanvasArrayCustom.h:
3425         (WebCore::constructCanvasArray):
3426
3427 2009-11-05  Alpha Lam  <hclam@chromium.org>
3428
3429         Not reviewed, Chromium build fix.
3430
3431         50561 introduces a custom method for SVGMatrix, we need to implement
3432         this in V8.
3433
3434         * bindings/v8/custom/V8CustomBinding.h:
3435         Adding definition for V8SVGMatrixMultiply.
3436         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
3437         (WebCore::CALLBACK_FUNC_DECL):
3438         Implement V8SVGMatrixMultiply according to the same method in JSC.
3439
3440 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3441
3442         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
3443
3444         * page/DOMWindow.cpp:
3445         (WebCore::DOMWindow::sessionStorage):
3446         * page/Settings.cpp:
3447         (WebCore::Settings::Settings):
3448         (WebCore::Settings::setSessionStorageEnabled):
3449         * page/Settings.h:
3450         (WebCore::Settings::sessionStorageEnabled):
3451
3452 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3453
3454         Reviewed by Timothy Hatcher.
3455
3456         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
3457
3458         https://bugs.webkit.org/show_bug.cgi?id=30884
3459
3460         Test: inspector/styles-iframe.html
3461
3462         * inspector/front-end/DOMAgent.js:
3463         (WebInspector.DOMNode):
3464         * inspector/front-end/InjectedScript.js:
3465         (InjectedScript.getStyles):
3466         (InjectedScript.getComputedStyle):
3467         (InjectedScript.addStyleSelector):
3468         * inspector/front-end/TestController.js:
3469         (WebInspector.TestController.prototype.notifyDone):
3470         (WebInspector.TestController.prototype.runAfterPendingDispatches):
3471         (WebInspector.evaluateForTestInFrontend.invokeMethod):
3472         (WebInspector.evaluateForTestInFrontend):
3473
3474 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
3475
3476         Reviewed by Geoffrey Garen and Dimitri Glazkov.
3477
3478         Rehashing of EventListenerMap leads to loss of EvenListenerList.
3479         https://bugs.webkit.org/show_bug.cgi?id=31027
3480
3481         Tested by new fast/events/event-listener-map-rehash-crash.html.
3482
3483         EventListenerMap modified to store pointers to listener vectors:
3484         * dom/EventTarget.cpp:
3485         (WebCore::EventTargetData::~EventTargetData):
3486         (WebCore::EventTarget::addEventListener):
3487         (WebCore::EventTarget::removeEventListener):
3488         (WebCore::EventTarget::fireEventListeners):
3489         (WebCore::EventTarget::getEventListeners):
3490         (WebCore::EventTarget::removeAllEventListeners):
3491         * dom/EventTarget.h:
3492
3493         Usages updated after interface changes:
3494         * inspector/InspectorDOMAgent.cpp:
3495         (WebCore::InspectorDOMAgent::getEventListenersForNode):
3496         * svg/SVGUseElement.cpp:
3497         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
3498
3499 2009-11-05  Dan Kegel  <dank@chromium.org>
3500
3501         Reviewed by Dmitri Titov.
3502
3503         Add missing initialization for m_createdByParser.
3504         https://bugs.webkit.org/show_bug.cgi?id=31089
3505
3506         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
3507
3508         * dom/ProcessingInstruction.cpp:
3509         (WebCore::ProcessingInstruction::ProcessingInstruction):
3510
3511 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3512
3513         Reviewed by Adam Barth.
3514
3515         DOM Storage runtime flag changes
3516         https://bugs.webkit.org/show_bug.cgi?id=30602
3517
3518         Part 2/2.
3519
3520         Revert my changes to Settings and instead implement DOM Storage enabling via
3521         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
3522
3523         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
3524         LayoutTest visible changes and thus no tests.
3525
3526         * bindings/v8/custom/V8CustomBinding.h:
3527         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3528         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3529         * page/DOMWindow.cpp:
3530         (WebCore::DOMWindow::sessionStorage):
3531         * page/DOMWindow.idl:
3532         * page/Settings.cpp:
3533         (WebCore::Settings::Settings):
3534         * page/Settings.h:
3535         * storage/Storage.cpp:
3536         (WebCore::Storage::setLocalStorageAvailable):
3537         (WebCore::Storage::localStorageAvailable):
3538         (WebCore::Storage::setSessionStorageAvailable):
3539         (WebCore::Storage::sessionStorageAvailable):
3540         * storage/Storage.h:
3541
3542 2009-11-05  Jian Li  <jianli@chromium.org>
3543
3544         Reviewed by Pavel Feldman.
3545
3546         Bug 31108 - [V8] REGRESSION: Pause on exception is broken
3547         https://bugs.webkit.org/show_bug.cgi?id=31108
3548
3549         * bindings/v8/V8AbstractEventListener.cpp:
3550         (WebCore::V8AbstractEventListener::invokeEventHandler):
3551         * bindings/v8/V8Utilities.cpp:
3552         (WebCore::reportException):
3553
3554 2009-11-05  Jian Li  <jianli@chromium.org>
3555
3556         Reviewed by Dmitri Titov.
3557
3558         We should not bubble up events if we drag something to an iframe that
3559         has an invalid source.
3560         https://bugs.webkit.org/show_bug.cgi?id=30469
3561
3562         Test: http/tests/misc/bubble-drag-events.html
3563
3564         * page/EventHandler.cpp:
3565         (WebCore::EventHandler::handleDragAndDropForTarget):
3566         (WebCore::EventHandler::updateDragAndDrop):
3567         (WebCore::EventHandler::cancelDragAndDrop):
3568         (WebCore::EventHandler::performDragAndDrop):
3569         * page/EventHandler.h:
3570         (WebCore::EventHandler::):
3571
3572 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3573
3574         Reviewed by Timothy Hatcher.
3575
3576         Web Inspector: speed up Timelines Clear by a factor of thousands.
3577
3578         https://bugs.webkit.org/show_bug.cgi?id=31160
3579
3580         * inspector/front-end/utilities.js:
3581         (Element.prototype.removeChildren):
3582
3583 2009-11-05  Anton Muhin  <antonm@chromium.org>
3584
3585         Reviewed by Adam Barth.
3586
3587         If high memory usage is detected, hint to V8 that it might be due
3588         to external objects retained by V8 objects.
3589         https://bugs.webkit.org/show_bug.cgi?id=31051
3590
3591         * bindings/v8/V8GCController.cpp:
3592         (WebCore::GetMemoryUsageInMB):
3593         (WebCore::V8GCController::gcEpilogue):
3594         (WebCore::V8GCController::checkMemoryUsage):
3595         * bindings/v8/V8GCController.h:
3596         * bindings/v8/V8Proxy.cpp:
3597         (WebCore::V8Proxy::evaluate):
3598         (WebCore::V8Proxy::runScript):
3599         (WebCore::V8Proxy::callFunction):
3600
3601 2009-11-05  Jeff Schiller  <codedread@gmail.com>
3602
3603         Reviewed by Simon Fraser.
3604
3605         Correct order of matrix multiplication for SVGMatrix.
3606         https://bugs.webkit.org/show_bug.cgi?id=16062
3607
3608         Test: svg/dom/SVGMatrix-interface.xhtml
3609
3610         * bindings/js/JSSVGMatrixCustom.cpp:
3611         (WebCore::JSSVGMatrix::multiply):
3612         * svg/SVGMatrix.idl:
3613
3614 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
3615
3616         Reviewed by Timothy Hatcher.
3617
3618         Web Inspector: Make resource-related records in timeline
3619         actually take some time.
3620
3621         https://bugs.webkit.org/show_bug.cgi?id=31139
3622
3623         * English.lproj/localizedStrings.js:
3624         * inspector/front-end/TimelinePanel.js:
3625         (WebInspector.TimelinePanel):
3626         (WebInspector.TimelinePanel.prototype._formatRecord):
3627         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3628         (WebInspector.TimelinePanel.prototype.reset):
3629
3630 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3631
3632         Reviewed by Darin Fisher.
3633
3634         Simplify LocalStorageThread
3635         https://bugs.webkit.org/show_bug.cgi?id=30935
3636
3637         This is a re-submit of 50519.  LocalStorageTask should have never been ref
3638         counted.  I've removed that and switched a PassRefPtr over to a PassOwnPtr.
3639
3640         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
3641         of the method names a bit more clear. Assert proper thread usage. Join rather
3642         than detaching the thread and doing an ad-hoc form of join. Avoid touching
3643         variables on the background thread when simple to do so.  Also create a generic
3644         scheduleTask function rather than one for each task.
3645
3646         No behavior should have changed.
3647
3648         * storage/LocalStorageTask.h:
3649         * storage/LocalStorageThread.cpp:
3650         (WebCore::LocalStorageThread::create):
3651         (WebCore::LocalStorageThread::LocalStorageThread):
3652         (WebCore::LocalStorageThread::~LocalStorageThread):
3653         (WebCore::LocalStorageThread::start):
3654         (WebCore::LocalStorageThread::threadEntryPointCallback):
3655         (WebCore::LocalStorageThread::threadEntryPoint):
3656         (WebCore::LocalStorageThread::scheduleTask):
3657         (WebCore::LocalStorageThread::terminate):
3658         (WebCore::LocalStorageThread::performTerminate):
3659         * storage/LocalStorageThread.h:
3660         * storage/StorageSyncManager.cpp:
3661         (WebCore::StorageSyncManager::StorageSyncManager):
3662         (WebCore::StorageSyncManager::~StorageSyncManager):
3663         (WebCore::StorageSyncManager::scheduleImport):
3664         (WebCore::StorageSyncManager::scheduleSync):
3665         * storage/StorageSyncManager.h:
3666
3667 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3668
3669         Reviewed by Darin Fisher.
3670
3671         Calling databaseIdentifier on LocalStorage's background thread is not safe.
3672         https://bugs.webkit.org/show_bug.cgi?id=31149
3673
3674         Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
3675         is not safe.  databaseIdentifier does a bunch of string concatenation which
3676         ref-counts StringImpls in some cases.  This was caught by valgrind thread
3677         sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645
3678
3679         There's no way to test for such racyness, unfortunately.
3680
3681         * storage/StorageAreaSync.cpp:
3682         (WebCore::StorageAreaSync::StorageAreaSync):
3683         (WebCore::StorageAreaSync::performImport):
3684         * storage/StorageAreaSync.h:
3685         * storage/StorageSyncManager.cpp:
3686         (WebCore::StorageSyncManager::fullDatabaseFilename):
3687         * storage/StorageSyncManager.h:
3688
3689 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
3690
3691         Reviewed by Darin Fisher.
3692
3693         Clean up StorageAreaSync
3694         https://bugs.webkit.org/show_bug.cgi?id=31100
3695
3696         Major fixes: Break the ref count cycle for StorageArea on the main
3697         thread, not the background thread since the latter is not safe.
3698         Length() needs to block on the import completing.
3699
3700         Small fixes: setItem needs to handle the copy on write case even if it
3701         has an exception.  setItem and removeItem should just bail from the
3702         the function if the value hasn't changed rather than wrapping the end
3703         in an if block.  Clear should only send an event if it wasn't already
3704         cleared.  StorageAreaSync should assert that the final sync was
3705         scheduled.
3706
3707         * storage/StorageAreaImpl.cpp:
3708         (WebCore::StorageAreaImpl::length):
3709           Forgot to block on the import.
3710         (WebCore::StorageAreaImpl::key):
3711         (WebCore::StorageAreaImpl::setItem):
3712           Handle the copy on write case even when there's an exception.
3713         (WebCore::StorageAreaImpl::removeItem):
3714         (WebCore::StorageAreaImpl::clear):
3715         * storage/StorageAreaSync.cpp:
3716         (WebCore::StorageAreaSync::~StorageAreaSync):
3717         (WebCore::StorageAreaSync::scheduleFinalSync):
3718         (WebCore::StorageAreaSync::performImport):
3719         (WebCore::StorageAreaSync::markImported):
3720         (WebCore::StorageAreaSync::blockUntilImportComplete):
3721         * storage/StorageAreaSync.h:
3722
3723 2009-11-05  Zoltan Horvath  <zoltan@webkit.org>
3724
3725         Reviewed by Eric Seidel.
3726
3727         Allow custom memory allocation control for WebCore's CachedResource
3728         https://bugs.webkit.org/show_bug.cgi?id=31114
3729
3730         Inherits CachedResource class from Noncopyable because its (its child
3731         class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75 
3732         and it is no need to be copyable.
3733
3734         * loader/CachedResource.h:
3735
3736 2009-11-04  Mark Mentovai  <mark@chromium.org>
3737
3738         Reviewed by Mark Rowe.
3739
3740         Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
3741         is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
3742         which is true when targeting 10.6 or later.
3743
3744         HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
3745         is present in the CGInterpolationQuality enum, and must be handled
3746         by a switch that has cases for each enumerated value.
3747
3748         USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
3749         on 10.6 or later, and that CoreGraphics will understand when
3750         InterpolationMedium is mapped to kCGInterpolationMedium at runtime.
3751
3752         * platform/graphics/cg/GraphicsContextCG.cpp:
3753         (WebCore::GraphicsContext::setImageInterpolationQuality):
3754         (WebCore::GraphicsContext::imageInterpolationQuality):
3755
3756 2009-11-04  Dan Kegel  <dank@chromium.org>
3757
3758         Reviewed by Alexey Proskuryakov.
3759
3760         Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
3761         https://bugs.webkit.org/show_bug.cgi?id=31138
3762
3763         Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind
3764
3765         * page/Page.cpp:
3766         (WebCore::Page::userStyleSheetLocationChanged):
3767
3768 2009-11-04  Timothy Hatcher  <timothy@apple.com>
3769
3770         Update the Web Inspector Timeline panel to better match the mock-up.
3771
3772         https://bugs.webkit.org/show_bug.cgi?id=31150
3773
3774         Reviewed by Pavel Feldman.
3775
3776         * inspector/front-end/TimelinePanel.js:
3777         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3778         (WebInspector.TimelinePanel.prototype._dragWindow):
3779         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
3780         (WebInspector.TimelinePanel.prototype._resizeWindowRight):
3781         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
3782         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3783         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
3784         (WebInspector.TimelineCategoryGraph):
3785         * inspector/front-end/inspector.css:
3786
3787 2009-11-05  Justin Garcia  <justin.garcia@apple.com>
3788
3789         Reviewed by Adele Peterson.
3790
3791         https://bugs.webkit.org/show_bug.cgi?id=25439
3792         Deleting when in front of a block image removes character from previous paragraph
3793
3794         Added editing/deleting/25439-{1,2,3}.html
3795
3796         * editing/DeleteSelectionCommand.cpp:
3797         (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot 
3798         be made inline with other content.  Instead of merging, just move the caret to just before 
3799         the selection we deleted.
3800         * editing/htmlediting.cpp:
3801         (WebCore::firstInSpecialElement): Added a FIXME.  This function begins iterating up from pos.node(), which 
3802         doesn't necessarily contain pos (suppose pos was [img, 0]).
3803         (WebCore::lastInSpecialElement): Ditto.
3804         (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp.  Added a check for non-inline images.
3805         * editing/htmlediting.h:
3806         * editing/visible_units.cpp:
3807         (WebCore::startOfParagraph): Use moved/renamed function.  Removed FIXME.  The problem causing 
3808         5027702 is now squarely in first/lastInSpecialElement
3809         (WebCore::endOfParagraph): Ditto.
3810         
3811 2009-11-04  Enrica Casucci  <enrica@apple.com>
3812
3813         Reviewed by Adele Peterson.
3814
3815         Hang in Mail on attempting to change indent level.
3816         <rdar://problem/7131805>
3817         https://bugs.webkit.org/show_bug.cgi?id=31127
3818
3819         The hang was caused by an infinite loop inside outdentRegion.
3820         The code did not account for the fact that, when a list item
3821         contains multiple paragraphs, outdent moves all paragraphs at
3822         once, invalidating some of the positions we keep track of in the loop.
3823         Some code refactoring has also been done to minimize duplicated code.
3824         
3825         Test: editing/execCommand/outdent-multiparagraph-list.html
3826
3827         * editing/IndentOutdentCommand.cpp:
3828         (WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
3829         outdentRegion to doApply.
3830         (WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
3831         (WebCore::IndentOutdentCommand::doApply): Some code refactoring.
3832         * editing/IndentOutdentCommand.h: Added VisiblePosition parameters to
3833         indentRegion and outdentRegion.
3834
3835 2009-11-04  Alpha Lam  <hclam@chromium.org>
3836
3837         Reviewed by Eric Carlson.
3838
3839         Volume slider doesn't have a thumb
3840         https://bugs.webkit.org/show_bug.cgi?id=31135
3841
3842         Fixed an incorrect if statement that prevents volume slider
3843         being updated.
3844
3845         The statement checks if the slider value equals to the current
3846         volume value of the media control to avoid updating the volume
3847         slider. Updating the volume slider control shouldn't be within
3848         this condition because we explicitly set them to be equals
3849         during creation of the controls and also when mouse events are
3850         received on the volume control.
3851
3852         No new tests because existing code breaks:
3853         LayoutTests/media/video-volume-slider.html
3854
3855         It should now start passing on Chromium.
3856
3857         * rendering/MediaControlElements.cpp:
3858         (WebCore::MediaControlVolumeSliderElement::update):
3859         Update the volume slider regardless of the current volume value
3860         of the media control.
3861
3862 2009-11-04  Jenn Braithwaite  <jennb@chromium.org>
3863
3864         Reviewed by David Levin.
3865
3866         Need to properly disable applicationCache at runtime
3867         https://bugs.webkit.org/show_bug.cgi?id=30417
3868
3869         Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.
3870
3871         No new exposed functionality, so no new tests.
3872
3873         * bindings/v8/RuntimeEnabledFeatures.cpp:
3874         * bindings/v8/RuntimeEnabledFeatures.h:
3875         (WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
3876         (WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
3877         * bindings/v8/custom/V8CustomBinding.h:
3878         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3879         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3880         * page/DOMWindow.idl:
3881
3882 2009-11-04  Alexey Proskuryakov  <ap@apple.com>
3883
3884         Reviewed by Dan Bernstein.
3885
3886         https://bugs.webkit.org/show_bug.cgi?id=31143
3887         Assertion failure in CredentialStorage::set() when proxy credentials are being set
3888
3889         No test, cannot test proxy behavior.
3890
3891         * platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the
3892         possibility of null url. Release mode changes are likely inconsequential - e.g. we used to
3893         add "://" to origin set, which is weird, but safe.
3894
3895 2009-11-04  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3896
3897         Reviewed by Timothy Hatcher.
3898
3899         Web Inspector: Leftover Breakpoints in the Sidebar Pane
3900         https://bugs.webkit.org/show_bug.cgi?id=30659
3901
3902         No new tests.
3903
3904         * inspector/front-end/ScriptsPanel.js:
3905         (WebInspector.ScriptsPanel.prototype.addScript):
3906
3907 2009-11-04  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3908
3909         Reviewed by Timothy Hatcher.
3910
3911         WebInspector: Use a different method to identify the webkit port in
3912         InspectorBackent::platform().
3913         This corrects the inspector expected behavior with Qt on Windows.
3914         https://bugs.webkit.org/show_bug.cgi?id=31116
3915
3916         * inspector/InspectorBackend.cpp:
3917         (WebCore::InspectorBackend::platform):
3918         (WebCore::InspectorBackend::port):
3919         * inspector/InspectorBackend.h:
3920         * inspector/InspectorBackend.idl:
3921         * inspector/front-end/InspectorControllerStub.js:
3922         (.WebInspector.InspectorControllerStub.prototype.port):
3923         * inspector/front-end/inspector.css:
3924         * inspector/front-end/inspector.js:
3925         (WebInspector.loaded):
3926         (WebInspector.toolbarDragStart):
3927
3928 2009-11-04  Benjamin Otte  <otte@gnome.org>
3929
3930         Reviewed by Gustavo Noronha.
3931
3932         Update Cairo requirement to 1.6.
3933
3934         Also remove all conditional code and workarounds for older versions of
3935         Cairo.
3936         In particular, gain image quality by removing the use of
3937         CAIRO_FILTER_NEAREST when rendering images and use the default
3938         bilinear filter instead.
3939         https://bugs.webkit.org/show_bug.cgi?id=19266
3940
3941         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3942         (WebCore::GraphicsContext::clipOut):
3943         * platform/graphics/cairo/ImageCairo.cpp:
3944         (WebCore::BitmapImage::draw):
3945         (WebCore::BitmapImage::drawPattern):
3946         * platform/graphics/cairo/PathCairo.cpp:
3947         (WebCore::Path::isEmpty):
3948         (WebCore::Path::boundingRect):
3949         * platform/gtk/RenderThemeGtk.cpp:
3950         (WebCore::paintMozWidget):
3951
3952 2009-11-04  Kevin Ollivier  <kevino@theolliviers.com>
3953
3954         wx build fix. Restore removed string conversion after cleanup.
3955
3956         * platform/graphics/wx/FontPlatformDataWx.cpp:
3957         (WebCore::FontPlatformData::computeHash):
3958
3959 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3960
3961         Reviewed by Beth Dakin.
3962
3963         Need to implement ARIA role="combobox"
3964         https://bugs.webkit.org/show_bug.cgi?id=31096
3965
3966         Test: accessibility/aria-combobox.html
3967
3968         * accessibility/AccessibilityObject.h:
3969         (WebCore::AccessibilityObject::isComboBox):
3970         (WebCore::AccessibilityObject::isExpanded):
3971         (WebCore::AccessibilityObject::expandObject):
3972         (WebCore::AccessibilityObject::increment):
3973         (WebCore::AccessibilityObject::decrement):
3974         * accessibility/AccessibilityRenderObject.cpp:
3975         (WebCore::AccessibilityRenderObject::expandObject):
3976         (WebCore::AccessibilityRenderObject::isExpanded):
3977         (WebCore::createARIARoleMap):
3978         * accessibility/AccessibilityRenderObject.h:
3979         * accessibility/mac/AccessibilityObjectWrapper.mm:
3980         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
3981         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
3982         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
3983         * html/HTMLAttributeNames.in:
3984
3985 2009-11-04  Kelly Norton  <knorton@google.com>
3986
3987         Reviewed by Pavel Feldman.
3988
3989         Fixes naming inconsistencies in TimelineRecordFactory.
3990         https://bugs.webkit.org/show_bug.cgi?id=31132
3991
3992         * inspector/InspectorTimelineAgent.cpp:
3993         (WebCore::InspectorTimelineAgent::willPaint):
3994         (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
3995         (WebCore::InspectorTimelineAgent::willLoadXHR):
3996         (WebCore::InspectorTimelineAgent::willEvaluateScript):
3997         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
3998         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
3999         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
4000         * inspector/TimelineRecordFactory.cpp:
4001         (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord):
4002         (WebCore::TimelineRecordFactory::createXHRLoadRecord):
4003         (WebCore::TimelineRecordFactory::createEvaluateScriptRecord):
4004         (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
4005         (WebCore::TimelineRecordFactory::createResourceSendRequestRecord):
4006         (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord):
4007         (WebCore::TimelineRecordFactory::createResourceFinishRecord):
4008         (WebCore::TimelineRecordFactory::createPaintRecord):
4009         * inspector/TimelineRecordFactory.h:
4010
4011 2009-11-04  Eric Z. Ayers  <zundel@google.com>
4012
4013         Reviewed by Pavel Feldman.
4014
4015         Followon to bug 31080, which protects Timeline
4016         instrumentation in the case where InspectorTimelineAgent
4017         is enabled or disabled during an event dispatch.
4018         
4019         https://bugs.webkit.org/show_bug.cgi?id=31121
4020
4021         * bindings/v8/V8Proxy.cpp:
4022         (WebCore::V8Proxy::evaluate):
4023         * dom/Document.cpp:
4024         (WebCore::Document::recalcStyle):
4025         * dom/Node.cpp:
4026         (WebCore::Node::dispatchGenericEvent):
4027         * html/HTMLTokenizer.cpp:
4028         (WebCore::HTMLTokenizer::write):
4029         * page/DOMWindow.cpp:
4030         (WebCore::DOMWindow::inspectorTimelineAgent):
4031         (WebCore::DOMWindow::dispatchEvent):
4032         * page/DOMWindow.h:
4033         * page/FrameView.cpp:
4034         (WebCore::FrameView::layout):
4035         (WebCore::FrameView::paintContents):
4036         * xml/XMLHttpRequest.cpp:
4037         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
4038
4039 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
4040
4041         Revert 50519 while I work out what went wrong.
4042
4043         * storage/LocalStorageThread.cpp:
4044         (WebCore::LocalStorageThread::create):
4045         (WebCore::LocalStorageThread::LocalStorageThread):
4046         (WebCore::LocalStorageThread::start):
4047         (WebCore::LocalStorageThread::localStorageThreadStart):
4048         (WebCore::LocalStorageThread::localStorageThread):
4049         (WebCore::LocalStorageThread::scheduleImport):
4050         (WebCore::LocalStorageThread::scheduleSync):
4051         (WebCore::LocalStorageThread::terminate):
4052         (WebCore::LocalStorageThread::performTerminate):
4053         * storage/LocalStorageThread.h:
4054         * storage/StorageSyncManager.cpp:
4055         (WebCore::StorageSyncManager::StorageSyncManager):
4056         (WebCore::StorageSyncManager::~StorageSyncManager):
4057         (WebCore::StorageSyncManager::scheduleImport):
4058         (WebCore::StorageSyncManager::scheduleSync):
4059         * storage/StorageSyncManager.h:
4060
4061 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
4062
4063         Reviewed by Timothy Hatcher.
4064
4065         Web Inspector: Add basic support for resource events and marks.
4066         Couple of drive-by fixes. Enabling the panel!
4067
4068         https://bugs.webkit.org/show_bug.cgi?id=31130
4069
4070         * English.lproj/localizedStrings.js:
4071         * inspector/front-end/TimelinePanel.js:
4072         (WebInspector.TimelinePanel):
4073         (WebInspector.TimelinePanel.prototype._formatRecord):
4074         (WebInspector.TimelinePanel.prototype._getRecordDetails):
4075         (WebInspector.TimelinePanel.prototype.reset):
4076         (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked):
4077         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
4078         * inspector/front-end/inspector.js:
4079         (WebInspector._createPanels):
4080
4081 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
4082
4083         Reviewed by Darin Fisher.
4084
4085         Simplify LocalStorageThread
4086         https://bugs.webkit.org/show_bug.cgi?id=30935
4087
4088         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
4089         of the method names a bit more clear. Assert proper thread usage. Join rather
4090         than detaching the thread and doing an ad-hoc form of join. Avoid touching
4091         variables on the background thread when simple to do so.  Also create a generic
4092         scheduleTask function rather than one for each task.
4093
4094         No behavior should have changed.
4095
4096         * storage/LocalStorageThread.cpp:
4097         (WebCore::LocalStorageThread::create):
4098         (WebCore::LocalStorageThread::LocalStorageThread):
4099         (WebCore::LocalStorageThread::~LocalStorageThread):
4100         (WebCore::LocalStorageThread::start):
4101         (WebCore::LocalStorageThread::threadEntryPointCallback):
4102         (WebCore::LocalStorageThread::threadEntryPoint):
4103         (WebCore::LocalStorageThread::scheduleTask):
4104         (WebCore::LocalStorageThread::terminate):
4105         (WebCore::LocalStorageThread::performTerminate):
4106         * storage/LocalStorageThread.h:
4107         * storage/StorageSyncManager.cpp:
4108         (WebCore::StorageSyncManager::StorageSyncManager):
4109         (WebCore::StorageSyncManager::~StorageSyncManager):
4110         (WebCore::StorageSyncManager::scheduleImport):
4111         (WebCore::StorageSyncManager::scheduleSync):
4112         * storage/StorageSyncManager.h:
4113
4114 2009-11-04  Vadim Zeitlin  <vadim@wxwidgets.org>
4115
4116         Reviewed by Eric Seidel.
4117
4118         [wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.
4119
4120         * platform/graphics/wx/FontPlatformDataWx.cpp:
4121         (WebCore::FontPlatformData::computeHash):
4122
4123 2009-11-04  Kelly Norton  <knorton@google.com>
4124
4125         Reviewed by Pavel Feldman.
4126
4127         Adds lightweight network resources to InspectorTimelineAgent.
4128         https://bugs.webkit.org/show_bug.cgi?id=31065
4129
4130         * inspector/InspectorController.cpp:
4131         (WebCore::InspectorController::willSendRequest):
4132         (WebCore::InspectorController::didReceiveResponse):
4133         (WebCore::InspectorController::didFinishLoading):
4134         (WebCore::InspectorController::didFailLoading):
4135         * inspector/InspectorTimelineAgent.cpp:
4136         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
4137         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
4138         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
4139         * inspector/InspectorTimelineAgent.h:
4140         (WebCore::):
4141         * inspector/TimelineRecordFactory.cpp:
4142         (WebCore::TimelineRecordFactory::createResourceSendRequestTimelineRecord):
4143         (WebCore::TimelineRecordFactory::createResourceReceiveResponseTimelineRecord):
4144         (WebCore::TimelineRecordFactory::createResourceFinishTimelineRecord):
4145         * inspector/TimelineRecordFactory.h:
4146         * inspector/front-end/TimelineAgent.js:
4147
4148 2009-11-04  Yael Aharon  <yael.aharon@nokia.com>
4149
4150         Reviewed by Tor Arne Vestbø.
4151
4152         [Qt] ASSERT failure when receiving 401 HTTP Authentication response.
4153         https://bugs.webkit.org/show_bug.cgi?id=31077
4154
4155         Allow sending the response body under the same conditions that we
4156         allow it to finish without reporting an error.
4157
4158         * platform/network/qt/QNetworkReplyHandler.cpp:
4159         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
4160
4161 2009-11-04  Adam Roben  <aroben@apple.com>
4162
4163         Sort WebCore.base.exp
4164
4165         Rubber-stamped by Dan Bernstein.
4166
4167         * WebCore.base.exp: Sorted.
4168
4169 2009-11-04  Csaba Osztrogonác  <ossy@webkit.org>
4170
4171         Unreviewed rollout.
4172
4173         Revert r50496 because it broke all layout tests on QtBuildBot.
4174
4175         * WebCore.pro:
4176         * platform/graphics/qt/FontCacheQt.cpp:
4177         (WebCore::fontCache):
4178         (WebCore::FontCache::FontCache):
4179         (WebCore::FontCache::getTraitsInFamily):
4180         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
4181         (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
4182         (WebCore::FontPlatformDataCacheKey::):
4183         (WebCore::FontPlatformDataCacheKey::operator==):
4184         (WebCore::FontPlatformDataCacheKey::hash):
4185         (WebCore::FontPlatformDataCacheKey::computeHash):
4186         (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
4187         (WebCore::FontPlatformDataCacheKeyHash::hash):
4188         (WebCore::FontPlatformDataCacheKeyHash::equal):
4189         (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
4190         (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
4191         (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
4192         (WebCore::FontCache::getCachedFontPlatformData):
4193         (WebCore::FontCache::getCachedFontData):
4194         (WebCore::FontCache::getLastResortFallbackFont):
4195         (WebCore::FontCache::releaseFontData):
4196         (WebCore::FontCache::purgeInactiveFontData):
4197         (WebCore::FontCache::addClient):
4198         (WebCore::FontCache::removeClient):
4199         (WebCore::FontCache::invalidate):
4200         * platform/graphics/qt/FontFallbackListQt.cpp: Added.
4201         (WebCore::FontFallbackList::FontFallbackList):
4202         (WebCore::FontFallbackList::invalidate):
4203         (WebCore::FontFallbackList::releaseFontData):
4204         (WebCore::FontFallbackList::determinePitch):
4205         (WebCore::FontFallbackList::fontDataAt):
4206         (WebCore::FontFallbackList::fontDataForCharacters):
4207         (WebCore::FontFallbackList::setPlatformFont):
4208         * platform/graphics/qt/FontPlatformData.h:
4209         (WebCore::FontPlatformData::pixelSize):
4210         * platform/graphics/qt/FontPlatformDataQt.cpp:
4211         (WebCore::FontPlatformData::FontPlatformData):
4212
4213 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
4214
4215         Reviewed by Jan Alonzo.
4216
4217         https://bugs.webkit.org/show_bug.cgi?id=31044
4218         [Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view
4219
4220         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
4221         (atkParentOfWebView):
4222         (webkit_accessible_get_index_in_parent):
4223         (webkit_accessible_get_parent):
4224
4225 2009-11-04  Dominik Röttsches  <dominik.roettsches@access-company.com>
4226
4227         Reviewed by Eric Seidel.
4228
4229         https://bugs.webkit.org/show_bug.cgi?id=15914
4230         [GTK] Implement Unicode functionality using GLib
4231
4232         Initial version of this patch by Jürg Billeter and Naiem Shaik.
4233         Patch 2/4 - Moving TextCodecs to GLib
4234         
4235         Added probing for a hard-coded lists of text encodings.
4236         The basis of this list is taken from the encodings supported by iconv,
4237         then extended by e.g. tis-620, windows-1251, euc-kr, windows-1253 and
4238         a number of Chinese ones.
4239
4240         Probing is necessary with the current design of text codecs
4241         as iconv/GLib do not support enumerating available encodings.
4242
4243         * GNUmakefile.am:
4244         * platform/ThreadGlobalData.cpp:
4245         (WebCore::ThreadGlobalData::ThreadGlobalData):
4246         (WebCore::ThreadGlobalData::~ThreadGlobalData):
4247         * platform/text/TextEncoding.cpp:
4248         (WebCore::TextEncoding::encode):
4249         * platform/text/TextEncodingRegistry.cpp:
4250         (WebCore::buildBaseTextCodecMaps):
4251         (WebCore::extendTextCodecMaps):
4252         * platform/text/gtk/TextCodecGtk.cpp: Added.
4253         (WebCore::):
4254         (WebCore::newTextCodecGtk):
4255         (WebCore::TextCodecGtk::isEncodingAvailable):
4256         (WebCore::TextCodecGtk::registerEncodingNames):
4257         (WebCore::TextCodecGtk::registerCodecs):
4258         (WebCore::TextCodecGtk::registerBaseEncodingNames):
4259         (WebCore::TextCodecGtk::registerBaseCodecs):
4260         (WebCore::TextCodecGtk::registerExtendedEncodingNames):
4261         (WebCore::TextCodecGtk::registerExtendedCodecs):
4262         (WebCore::TextCodecGtk::TextCodecGtk):
4263         (WebCore::TextCodecGtk::~TextCodecGtk):
4264         (WebCore::TextCodecGtk::releaseIConv):
4265         (WebCore::TextCodecGtk::createIConvDecoder):
4266         (WebCore::TextCodecGtk::createIConvEncoder):
4267         (WebCore::TextCodecGtk::decode):
4268         (WebCore::TextCodecGtk::encode):
4269         * platform/text/gtk/TextCodecGtk.h: Added.
4270
4271 2009-11-04  Martin Robinson  <martin.james.robinson@gmail.com>
4272
4273         Reviewed by Jan Alonzo.
4274
4275         [GTK] Enable DOM clipboard and drag-and-drop access
4276         https://bugs.webkit.org/show_bug.cgi?id=30623
4277
4278         Unify redudant methods which will always return the same value.
4279
4280         * platform/gtk/PasteboardGtk.cpp:
4281         (WebCore::Pasteboard::writeSelection):
4282         * platform/gtk/PasteboardHelper.h:
4283
4284 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
4285
4286         Reviewed by Jan Alonzo.
4287
4288         https://bugs.webkit.org/show_bug.cgi?id=31035
4289         [GTK] some accessibility tests hitting assertion in debug builds
4290
4291         Removes the assertions in webkit_accessible_ref_child; adds sanity checks.
4292         Any app or AT can attempt to ref a child at a bogus index.
4293
4294         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
4295         (webkit_accessible_ref_child):
4296
4297 2009-11-04  Benjamin Otte  <otte@gnome.org>
4298
4299         Reviewed by Jan Alonzo.
4300
4301         [gtk] Use gst_element_class_set_details_simple()
4302
4303         Cosmetic change, just code simplification