WebCore/ChangeLog

   1 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
   2
   3         Reviewed by Darin Adler.
   4
   5         externalRepresentation should take Frame as the argument
   6         https://bugs.webkit.org/show_bug.cgi?id=31393
   7
   8         No new tests as this is just a refactoring.
   9
  10         * WebCore.base.exp:
  11         * rendering/RenderTreeAsText.cpp:
  12         (WebCore::externalRepresentation):
  13         * rendering/RenderTreeAsText.h:
  14
  15 2009-11-12  Ben Murdoch  <benm@google.com>
  16
  17         Reviewed by Dimitri Glazkov.
  18
  19         [Android] The Android specific files in page/Android are out of date.
  20         https://bugs.webkit.org/show_bug.cgi?id=31437
  21
  22         No tests required.
  23
  24         * page/android/DragControllerAndroid.cpp:
  25         (WebCore::DragController::dragOperation): Added.
  26         (WebCore::DragController::cleanupAfterSystemDrag):
  27         * page/android/EventHandlerAndroid.cpp:
  28         (WebCore::EventHandler::accessKeyModifiers): Added.
  29         * page/android/InspectorControllerAndroid.cpp: Removed.
  30
  31 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
  32
  33         Reviewed by Simon Fraser.
  34
  35         [CAIRO] shadow support for Canvas and SVG.
  36         [https://bugs.webkit.org/show_bug.cgi?id=30960]
  37
  38         Implement Canvas/SVG shadow support for Cairo.  This patch
  39         uses the filter code from SVG Filters.  That means that it is
  40         necessary to activate filters to see the shadows.
  41
  42         Test: fast/canvas/canvas-shadow.html
  43
  44         * GNUmakefile.am:
  45         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
  46         * platform/graphics/GraphicsContext.h:
  47         * platform/graphics/cairo/GraphicsContextCairo.cpp:
  48         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
  49         (WebCore::setPlatformFill):
  50         (WebCore::setPlatformStroke):
  51         (WebCore::copyContextProperties):
  52         (WebCore::drawPathShadow):
  53         (WebCore::GraphicsContext::fillPath):
  54         (WebCore::GraphicsContext::strokePath):
  55         (WebCore::GraphicsContext::drawPath):
  56         (WebCore::GraphicsContext::setPlatformShadow):
  57         (WebCore::GraphicsContext::createPlatformShadow):
  58         * platform/graphics/cairo/ImageCairo.cpp:
  59         (WebCore::BitmapImage::draw): Add filter effect.
  60         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
  61         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
  62         * platform/graphics/filters/ImageBufferFilter.h: Added.
  63         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
  64         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
  65
  66 2009-11-12  Dmitry Titov  <dimich@chromium.org>
  67
  68         Reviewed by Alexey Proskuryakov.
  69
  70         Add postTaskToMainThread to ScriptExecutionContext.
  71         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
  72         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
  73         contexts that live on the main thread.
  74         https://bugs.webkit.org/show_bug.cgi?id=31427
  75
  76         No new tests - simply moving the code.
  77
  78         * dom/Document.cpp:
  79         (WebCore::Document::postTask):
  80         * dom/ScriptExecutionContext.cpp:
  81         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
  82         (WebCore::ScriptExecutionContextTaskTimer::fired):
  83         (WebCore::PerformTaskData::PerformTaskData):
  84         (WebCore::PerformTaskData::performTask):
  85         (WebCore::ScriptExecutionContext::postTaskToMainThread):
  86         * dom/ScriptExecutionContext.h:
  87
  88 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
  89
  90         Reviewed by Darin Adler.
  91
  92         Fix crash when removing compositing layers when GC is enabled
  93         https://bugs.webkit.org/show_bug.cgi?id=31429
  94
  95         Workaround <rdar://problem/7390716> by special-casing the removal
  96         of all sublayers when GC is enabled.
  97
  98         * platform/graphics/mac/GraphicsLayerCA.mm:
  99         (WebCore::safeSetSublayers):
 100         (WebCore::GraphicsLayerCA::updateSublayerList):
 101         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
 102
 103 2009-11-12  Jens Alfke  <snej@chromium.org>
 104
 105         Reviewed by Dimitri Glazkov.
 106
 107         The last of the V8 binding optimizations.
 108         - Replace string-valued element accessors with a shared getter/setter function.
 109         - Change error handling flow of control to avoid extra branches and function calls.
 110         https://bugs.webkit.org/show_bug.cgi?id=31443
 111
 112         * bindings/scripts/CodeGeneratorV8.pm:
 113         * bindings/v8/V8Binding.cpp:
 114         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
 115         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
 116         * bindings/v8/V8Binding.h:
 117
 118 2009-11-12  Sam Weinig  <sam@webkit.org>
 119
 120         Reviewed by Oliver Hunt.
 121
 122         Fix for <rdar://problem/7267951>
 123         Canvas methods should reject uses of NaN and Infinity.
 124
 125         Test: fast/canvas/canvas-with-illegal-args.html
 126
 127         * html/canvas/CanvasRenderingContext2D.cpp:
 128         (WebCore::CanvasRenderingContext2D::scale):
 129         (WebCore::CanvasRenderingContext2D::rotate):
 130         (WebCore::CanvasRenderingContext2D::translate):
 131         (WebCore::CanvasRenderingContext2D::transform):
 132         (WebCore::CanvasRenderingContext2D::setTransform):
 133
 134 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 135
 136         Reviewed by Timothy Hatcher.
 137
 138         Web Inspector: profile timeline panel, fix obvious problems.
 139
 140         https://bugs.webkit.org/show_bug.cgi?id=31432
 141
 142         * inspector/front-end/AbstractTimelinePanel.js:
 143         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
 144         * inspector/front-end/TimelinePanel.js:
 145         (WebInspector.TimelinePanel.prototype._setWindowPosition):
 146         (WebInspector.TimelineCalculator):
 147         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
 148         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
 149         (WebInspector.TimelineCalculator.prototype.reset):
 150         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
 151         (WebInspector.TimelineCalculator.prototype.formatValue):
 152         (WebInspector.TimelineGraph):
 153         (WebInspector.TimelineGraph.prototype.refresh):
 154         * inspector/front-end/utilities.js:
 155         (Element.prototype.hasStyleClass):
 156
 157 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 158
 159         Reviewed by Timothy Hatcher.
 160
 161         Web Inspector: preload status bar button glyphs
 162         in order to prevent them from flickering.
 163
 164         https://bugs.webkit.org/show_bug.cgi?id=31439
 165
 166         * inspector/front-end/inspector.js:
 167         (preloadImages):
 168
 169 2009-11-12  Adam Roben  <aroben@apple.com>
 170
 171         Replace worldIDs with world objects
 172
 173         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
 174         user scripts/stylesheets and isolated worlds
 175
 176         Reviewed by Sam Weinig.
 177
 178         Covered by existing tests.
 179
 180         * WebCore.base.exp: Update exported symbols to match what now exists
 181         and is needed by WebKit.
 182
 183         * bindings/js/ScheduledAction.cpp:
 184         (WebCore::ScheduledAction::execute): Updated for function rename.
 185
 186         * bindings/js/ScriptController.cpp: Removed code that dealt with
 187         worldIDs.
 188         (WebCore::ScriptController::createWorld): Added. Returns a new world
 189         suitable for use on the main thread.
 190         (WebCore::ScriptController::executeScriptInWorld): Renamed from
 191         executeScriptInIsolatedWorld, since this works just fine with a
 192         "normal" world.
 193
 194         * bindings/js/ScriptController.h: Added createWorld, removed functions
 195         that took worldIDs, renamed executeScriptInIsolatedWorld to
 196         executeScriptInWorld.
 197
 198         * page/Frame.cpp:
 199         (WebCore::Frame::injectUserScripts):
 200         (WebCore::Frame::injectUserScriptsForWorld):
 201         Updated for changes to UserScriptMap and ScriptController.
 202
 203         * page/Frame.h: Changed injectUserScriptsForWorld to take a
 204         DOMWrapperWorld* instead of a worldID.
 205
 206         * page/PageGroup.cpp:
 207         (WebCore::PageGroup::addUserScriptToWorld):
 208         (WebCore::PageGroup::addUserStyleSheetToWorld):
 209         (WebCore::PageGroup::removeUserScriptFromWorld):
 210         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
 211         (WebCore::PageGroup::removeUserScriptsFromWorld):
 212         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
 213         * page/PageGroup.h:
 214         Changed these functions to take a DOMWrapperWorld* instead of a
 215         worldID. Also updated for changes to UserScript and UserStyleSheet.
 216
 217         * page/UserScript.h:
 218         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
 219         never used.
 220
 221         * page/UserScriptTypes.h:
 222         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
 223         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
 224         worldID as their key type.
 225
 226
 227 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
 228
 229         Reviewed by Tim Hatcher.
 230
 231         Fixes <http://webkit.org/b/31260>.
 232         Web Inspector: Main Resources Other than HTML are mis-detected.
 233
 234         Even if the resource is a main resource, look at its CachedResource type,
 235         because it might be an image, stylesheet, or JavaScript file, and we
 236         want to show them all correctly.
 237
 238         * inspector/InspectorResource.cpp:
 239         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
 240         (WebCore::InspectorResource::type):
 241         * inspector/InspectorResource.h:
 242
 243 2009-11-12  Jens Alfke  <snej@chromium.org>
 244
 245         Reviewed by Dimitri Glazkov.
 246
 247         Table-driven setup for V8 binding template callback functions. 100k in code savings.
 248         https://bugs.webkit.org/show_bug.cgi?id=31420
 249
 250         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
 251             to call configureTemplate().
 252         * bindings/v8/V8Binding.cpp:
 253         (WebCore::configureTemplate):  New function; does all the standard configuration work.
 254         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
 255         * bindings/v8/V8Binding.h:
 256         * bindings/v8/V8Proxy.cpp:
 257         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
 258         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
 259         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
 260         * bindings/v8/V8Proxy.h:
 261
 262 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
 263
 264         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
 265
 266         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
 267
 268 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
 269
 270         Reviewed by Dan Bernstein.
 271
 272         <rdar://problem/7388969> Add DOM API for fullscreen video
 273
 274         DOM API for fullscreen <video>.
 275
 276         Tests: media/media-fullscreen-inline.html
 277                media/media-fullscreen-not-in-document.html
 278
 279         * dom/EventNames.h:
 280             Add webkitbeginfullscreen and webkitendfullscreen.
 281
 282         * html/HTMLAttributeNames.in:
 283             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
 284
 285         * html/HTMLMediaElement.cpp:
 286         (WebCore::HTMLMediaElement::parseMappedAttribute):
 287             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
 288         (WebCore::HTMLMediaElement::enterFullscreen):
 289             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
 290             actually do enter fullscreen.
 291         (WebCore::HTMLMediaElement::exitFullscreen):
 292             Schedule webkitendfullscreenEvent event.
 293         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
 294         (WebCore::HTMLMediaElement::webkitExitFullScreen):
 295         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
 296         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
 297             New, access to fullscreen properties and methods.
 298
 299         * html/HTMLMediaElement.h:
 300         * html/HTMLMediaElement.idl:
 301             Declare methods needed for fullscreen API.
 302
 303         * html/HTMLVideoElement.cpp:
 304         (WebCore::HTMLVideoElement::supportsFullscreen):
 305             Return false if a movie does not have video.
 306
 307         * page/DOMWindow.h:
 308             Add webkitbeginfullscreen and webkitendfullscreen.
 309
 310 2009-11-12  Adam Barth  <abarth@webkit.org>
 311
 312         Reviewed by Dimitri Glazkov.
 313
 314         [Chromium] Sify compose button alerts error
 315         https://bugs.webkit.org/show_bug.cgi?id=31394
 316
 317         Test: http/tests/security/calling-versus-current.html
 318
 319         We're supposed to use the calling context for security checks.  In JSC
 320         land, this is the lexicalGlobalObject.
 321
 322         * bindings/v8/V8Proxy.cpp:
 323         (WebCore::V8Proxy::canAccessPrivate):
 324
 325 2009-11-12  Daniel Bates  <dbates@webkit.org>
 326
 327         Reviewed by Darin Adler.
 328
 329         https://bugs.webkit.org/show_bug.cgi?id=30291
 330
 331         Fixes an issue where the returned drop effect is incorrect when
 332         effectAllowed == "uninitialized".
 333
 334         According to section 7.9.2 of the HTML 5 spec.
 335         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
 336         when effectAllowed = "uninitialized" the resulting dropEffect should be the
 337         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
 338         other case.
 339
 340         No test cases are included because we have an existing test case from
 341         bug #24731.
 342
 343         * dom/Clipboard.cpp:
 344         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
 345
 346 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 347
 348         Reviewed by Timothy Hatcher.
 349
 350         Web Inspector: Do not highlight node on refresh.
 351
 352         https://bugs.webkit.org/show_bug.cgi?id=31419
 353
 354         * inspector/front-end/ElementsPanel.js:
 355         (WebInspector.ElementsPanel.prototype.reset):
 356
 357 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 358
 359         Reviewed by Timothy Hatcher.
 360
 361         Web Inspector: Minor timeline fixes.
 362
 363         https://bugs.webkit.org/show_bug.cgi?id=31417
 364
 365         * inspector/front-end/TimelinePanel.js:
 366         (WebInspector.TimelinePanel.prototype._getRecordDetails):
 367         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
 368         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
 369         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
 370
 371 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
 372
 373         SnowLeopard build fix.
 374
 375         Renamed initWithClient to initWithAuthenticationClient.
 376
 377         * platform/network/mac/AuthenticationMac.mm:
 378         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
 379         (WebCore::AuthenticationChallenge::setAuthenticationClient):
 380
 381 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
 382
 383         Reviewed by Darin Adler.
 384
 385         ARIA: add alert type roles
 386         https://bugs.webkit.org/show_bug.cgi?id=31392
 387
 388         Test: platform/mac/accessibility/aria-alerts.html
 389
 390         * accessibility/AccessibilityObject.h:
 391         * accessibility/AccessibilityRenderObject.cpp:
 392         * accessibility/mac/AccessibilityObjectWrapper.mm:
 393
 394 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
 395
 396         Reviewed by Darin Adler.
 397
 398         https://bugs.webkit.org/show_bug.cgi?id=31386
 399         Make Mac AuthenticationChallenge usable from cross-platform code
 400
 401         No change in behavior, so no tests.
 402
 403         * platform/network/ResourceHandle.cpp:
 404         (WebCore::ResourceHandle::clearAuthentication):
 405         * platform/network/ResourceHandleInternal.h:
 406         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
 407         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
 408         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
 409         is identical.
 410
 411         * platform/network/cf/AuthenticationChallenge.h:
 412         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
 413         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
 414
 415         * platform/network/cf/ResourceHandleCFNet.cpp:
 416         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
 417         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
 418         be already set.
 419
 420         * platform/network/mac/AuthenticationChallenge.h:
 421         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
 422         best of my understanding.
 423         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
 424         confusion with "mac" and "web" challenges in ResourceHandleInternal.
 425
 426         * platform/network/mac/AuthenticationMac.mm:
 427         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
 428         making it possible to use the latter with NSURLAuthenticationChallenge.
 429         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
 430         m_nsChallenge renaming.
 431         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
 432         set it as sender (or unset, if client is null).
 433
 434         * platform/network/mac/ResourceHandleMac.mm:
 435         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
 436         authentication challenge sender.
 437         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
 438         authentication sheet.
 439         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
 440         using the new setAuthenticationClient() method.
 441         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
 442         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
 443         the original Mac one, not the one we created for use with authentication sheet. I don't
 444         know when a connection would cancel authentication in practice, so I haven't tested this.
 445
 446 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
 447
 448         Reviewed by Timothy Hatcher.
 449
 450         Web Inspector: breakpoint sidebar entries should allow click over entire list item
 451         https://bugs.webkit.org/show_bug.cgi?id=31411
 452
 453         No new tests; no new functionality, small usability change.
 454
 455         * inspector/front-end/BreakpointsSidebarPane.js:
 456         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
 457         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
 458
 459 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
 460
 461         Reviewed by Timothy Hatcher.
 462
 463         Web Inspector: breakpoints in named evals are not restored after a reload
 464         https://bugs.webkit.org/show_bug.cgi?id=31375
 465
 466         Manual test added
 467
 468         * inspector/front-end/ScriptsPanel.js:
 469         (WebInspector.ScriptsPanel.prototype.addScript):
 470         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
 471
 472 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
 473
 474         Reviewed by Kenneth Rohde Christiansen.
 475
 476         Custom printing shrink factors
 477         https://bugs.webkit.org/show_bug.cgi?id=29042
 478
 479         This reverts commit r49769. The public API for this needs to be reviewed
 480         before its inclusion in Qt.
 481
 482         * page/PrintContext.cpp:
 483         (WebCore::PrintContext::begin):
 484         * page/Settings.cpp:
 485         (WebCore::Settings::Settings):
 486         * page/Settings.h:
 487
 488 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
 489
 490         Reviewed by Pavel Feldman.
 491
 492         Web Inspector: Resource errors/warnings not shown in the Resource tree.
 493
 494         Error/Warning bubbles are not displayed next to the resource in the
 495         Resources panel if those occur before the resource is attached to the tree.
 496         https://bugs.webkit.org/show_bug.cgi?id=31404
 497
 498         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
 499
 500         * inspector/front-end/AbstractTimelinePanel.js:
 501         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
 502         * inspector/front-end/ResourcesPanel.js:
 503         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
 504
 505 2009-11-12  Philippe Normand  <pnormand@igalia.com>
 506
 507         Reviewed by Jan Alonzo.
 508
 509         https://bugs.webkit.org/show_bug.cgi?id=31047
 510         [GTK] Failing test media/video-played-ranges-1.html
 511
 512         Follow-up of r50726, don't block the UI thread when calling
 513         gst_element_get_state(). Also fixed a compilation warning and some
 514         static casts.
 515
 516         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
 517         (WebCore::playbackPosition):
 518         (WebCore::MediaPlayerPrivate::seek):
 519         (WebCore::MediaPlayerPrivate::setRate):
 520
 521 2009-11-12  Philippe Normand  <pnormand@igalia.com>
 522
 523         Reviewed by Jan Alonzo.
 524
 525         https://bugs.webkit.org/show_bug.cgi?id=31047
 526         [GTK] Failing test media/video-played-ranges-1.html
 527
 528         don't pause pipeline if already paused, same for play()
 529
 530         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
 531         (WebCore::MediaPlayerPrivate::play):
 532         (WebCore::MediaPlayerPrivate::pause):
 533
 534 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
 535
 536         Reviewed by David Levin.
 537
 538         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
 539         Chromium too.
 540         https://bugs.webkit.org/show_bug.cgi?id=31292
 541
 542         No new tests. (Corresponding test for Gtk+ is
 543         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
 544
 545         * page/EventHandler.cpp:
 546         * page/chromium/EventHandlerChromium.cpp:
 547
 548 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
 549
 550         Reviewed by Eric Seidel.
 551
 552         Prevent text inside a multi-column block from being split into columns.
 553
 554         If the tentative height of a multi-column block was too small, we need to
 555         expand the block height and try to layout again, in order to prevent text
 556         from being split into different columns.
 557
 558         CSS Multicolumn text is split awkwardly
 559         https://bugs.webkit.org/show_bug.cgi?id=22249
 560
 561         Test: fast/multicol/single-line.html
 562
 563         * rendering/RenderBlock.cpp:
 564         (WebCore::RenderBlock::layoutColumns):
 565         * rendering/RenderBlock.h:
 566         * rendering/RenderLineBoxList.cpp:
 567         (WebCore::RenderLineBoxList::paint):
 568         * rendering/RenderView.h:
 569         (WebCore::RenderView::setTruncatedAt):
 570         (WebCore::RenderView::setMinimumColumnHeight):
 571         (WebCore::RenderView::minimumColumnHeight):
 572
 573 2009-11-11  Kent Tamura  <tkent@chromium.org>
 574
 575         Reviewed by Darin Adler.
 576
 577         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
 578         https://bugs.webkit.org/show_bug.cgi?id=31195
 579
 580         Test: fast/forms/input-file-re-render.html
 581
 582         * rendering/RenderFileUploadControl.cpp:
 583         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
 584
 585 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
 586
 587         Reviewed by Dimitri Glazkov.
 588
 589         Fixing Chromium's POSIX VFS implementation, by adding the required
 590         "used file descriptors" logic.
 591
 592         https://bugs.webkit.org/show_bug.cgi?id=31275
 593
 594         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
 595
 596 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
 597
 598         Reviewed by Oliver Hunt.
 599
 600         need to implement aria tree roles
 601         https://bugs.webkit.org/show_bug.cgi?id=31284
 602
 603         Tests: platform/mac/accessibility/aria-multiselectable.html
 604                platform/mac/accessibility/aria-tree.html
 605
 606         * accessibility/AccessibilityList.cpp:
 607         (WebCore::AccessibilityList::accessibilityIsIgnored):
 608         * accessibility/AccessibilityObject.cpp:
 609         (WebCore::AccessibilityObject::ariaTreeRows):
 610         (WebCore::AccessibilityObject::ariaTreeItemContent):
 611         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
 612         * accessibility/AccessibilityObject.h:
 613         (WebCore::):
 614         (WebCore::AccessibilityObject::isTree):
 615         (WebCore::AccessibilityObject::isTreeItem):
 616         (WebCore::AccessibilityObject::setIsExpanded):
 617         (WebCore::AccessibilityObject::canSetExpandedAttribute):
 618         (WebCore::AccessibilityObject::hierarchicalLevel):
 619         (WebCore::AccessibilityObject::setSelectedRows):
 620         (WebCore::AccessibilityObject::performDefaultAction):
 621         * accessibility/AccessibilityRenderObject.cpp:
 622         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
 623         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
 624         (WebCore::AccessibilityRenderObject::isExpanded):
 625         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
 626         (WebCore::AccessibilityRenderObject::elementAttributeValue):
 627         (WebCore::AccessibilityRenderObject::setIsExpanded):
 628         (WebCore::AccessibilityRenderObject::isSelected):
 629         (WebCore::AccessibilityRenderObject::setSelected):
 630         (WebCore::AccessibilityRenderObject::setSelectedRows):
 631         (WebCore::createARIARoleMap):
 632         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
 633         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
 634         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
 635         (WebCore::AccessibilityRenderObject::selectedChildren):
 636         * accessibility/AccessibilityRenderObject.h:
 637         * accessibility/mac/AccessibilityObjectMac.mm:
 638         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
 639         * accessibility/mac/AccessibilityObjectWrapper.mm:
 640         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
 641         (RoleEntry::):
 642         (-[AccessibilityObjectWrapper subrole]):
 643         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
 644         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
 645         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
 646         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
 647         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
 648         * html/HTMLAttributeNames.in:
 649
 650 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
 651
 652         Build fix after @r50760 with ENABLE_FILTERS.
 653
 654         * platform/graphics/filters/SourceAlpha.cpp:
 655         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
 656         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
 657           to fillRect.
 658
 659 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
 660
 661         Reviewed by Alexey Proskuryakov.
 662
 663         Fix WebSocket frame parser of frame_type with high-order bit set.
 664         https://bugs.webkit.org/show_bug.cgi?id=30668
 665
 666         If buffer is smaller than frame's length, it should break the loop
 667         instead of reading next byte.
 668
 669         Tests: websocket/tests/frame-length-longer-than-buffer.html
 670                websocket/tests/frame-length-skip.html
 671
 672         * websockets/WebSocketChannel.cpp:
 673         (WebCore::WebSocketChannel::didReceiveData):
 674
 675 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
 676
 677         Reviewed by Adam Barth.
 678
 679         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
 680         https://bugs.webkit.org/show_bug.cgi?id=31345
 681
 682         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
 683
 684         * platform/graphics/chromium/FontCustomPlatformData.cpp:
 685         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
 686         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
 687         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
 688
 689 2009-11-11  Beth Dakin  <bdakin@apple.com>
 690
 691         Build fix. No review needed.
 692
 693         * platform/graphics/gtk/FontGtk.cpp:
 694         (WebCore::Font::drawComplexText):
 695
 696 2009-11-11  Beth Dakin  <bdakin@apple.com>
 697
 698         Build fix. No review needed.
 699
 700         * platform/graphics/cairo/FontCairo.cpp:
 701         (WebCore::Font::drawGlyphs):
 702
 703 2009-11-11  Beth Dakin  <bdakin@apple.com>
 704
 705         Windows build fix. No review needed.
 706
 707         * platform/graphics/win/FontCGWin.cpp:
 708         (WebCore::Font::drawGlyphs):
 709
 710 2009-11-11  Beth Dakin  <bdakin@apple.com>
 711
 712         Reviewed by Simon Fraser.
 713
 714         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
 715         Make -webkit-color-correction work with shadows
 716
 717         From canvas, just send DeviceColorSpace to setShadow() for now.
 718         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
 719         * html/canvas/CanvasRenderingContext2D.cpp:
 720         (WebCore::CanvasRenderingContext2D::setShadow):
 721         (WebCore::CanvasRenderingContext2D::applyShadow):
 722
 723         setShadow() and setPlatformShadow() now take a ColorSpace.
 724         * platform/graphics/GraphicsContext.cpp:
 725         (WebCore::GraphicsContext::setShadow):
 726         * platform/graphics/GraphicsContext.h:
 727         * platform/graphics/cg/GraphicsContextCG.cpp:
 728         (WebCore::createCGColorWithColorSpace): New helper to create a
 729         color in a ColorSpace.
 730         (WebCore::setCGFillColor): Call new helper.
 731         (WebCore::setCGStrokeColor): Call new helper.
 732         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
 733         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
 734         (WebCore::GraphicsContext::setPlatformShadow):
 735
 736         Send appropriate ColorSpace to setShadow().
 737         * platform/graphics/mac/FontMac.mm:
 738         (WebCore::Font::drawGlyphs):
 739         * rendering/EllipsisBox.cpp:
 740         (WebCore::EllipsisBox::paint):
 741         * rendering/InlineFlowBox.cpp:
 742         (WebCore::InlineFlowBox::paintTextDecorations):
 743         * rendering/InlineTextBox.cpp:
 744         (WebCore::paintTextWithShadows):
 745         (WebCore::InlineTextBox::paintDecoration):
 746         * rendering/RenderBoxModelObject.cpp:
 747         (WebCore::RenderBoxModelObject::paintBoxShadow):
 748         * rendering/SVGInlineTextBox.cpp:
 749         (WebCore::SVGInlineTextBox::paintCharacters):
 750         * rendering/SVGRenderSupport.cpp:
 751         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
 752
 753         Attempt to keep ports building.
 754         * platform/graphics/cairo/GraphicsContextCairo.cpp:
 755         (WebCore::GraphicsContext::setPlatformShadow):
 756         * platform/graphics/qt/GraphicsContextQt.cpp:
 757         (WebCore::GraphicsContext::setPlatformShadow):
 758         * platform/graphics/skia/GraphicsContextSkia.cpp:
 759         (WebCore::GraphicsContext::setPlatformShadow):
 760         * platform/graphics/wince/GraphicsContextWince.cpp:
 761         (WebCore::GraphicsContext::setPlatformShadow):
 762         * platform/graphics/wx/GraphicsContextWx.cpp:
 763         (WebCore::GraphicsContext::setPlatformShadow):
 764
 765 2009-11-11  Kent Tamura  <tkent@chromium.org>
 766
 767         Reviewed by Darin Adler.
 768
 769         Print the file text of a file upload control in DumpRenderTree for ease of tests.
 770         https://bugs.webkit.org/show_bug.cgi?id=31195
 771
 772         * rendering/RenderFileUploadControl.cpp:
 773         (WebCore::RenderFileUploadControl::paintObject):
 774         (WebCore::RenderFileUploadControl::fileTextValue):
 775         * rendering/RenderFileUploadControl.h:
 776         (WebCore::RenderFileUploadControl::isFileUploadControl):
 777         (WebCore::toRenderFileUploadControl):
 778         * rendering/RenderObject.h:
 779         (WebCore::RenderObject::isFileUploadControl):
 780         * rendering/RenderTreeAsText.cpp:
 781         (WebCore::operator<<):
 782
 783 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
 784
 785         Reviewed by Sam Weinig.
 786
 787         DOM Wrappers for some nodes may not be marked.
 788         https://bugs.webkit.org/show_bug.cgi?id=31380
 789
 790         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
 791         the wrapper for the current world only.  This means that wrappers may be GC'ed
 792         prematurely, and properties lost.
 793
 794         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
 795
 796         * bindings/js/JSAttrCustom.cpp:
 797         (WebCore::JSAttr::markChildren):
 798         * bindings/js/JSDOMBinding.cpp:
 799         (WebCore::markDOMNodeWrapper):
 800         * bindings/js/JSDOMBinding.h:
 801         * bindings/js/JSNamedNodeMapCustom.cpp:
 802         (WebCore::JSNamedNodeMap::markChildren):
 803         * bindings/js/JSNodeCustom.cpp:
 804         (WebCore::JSNode::markChildren):
 805         * bindings/js/JSSVGElementInstanceCustom.cpp:
 806         (WebCore::JSSVGElementInstance::markChildren):
 807         * bindings/js/JSStyleSheetCustom.cpp:
 808         (WebCore::JSStyleSheet::markChildren):
 809
 810 2009-11-11  Ben Murdoch  <benm@google.com>
 811
 812         Reviewed by Darin Adler.
 813
 814         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
 815         https://bugs.webkit.org/show_bug.cgi?id=31384
 816
 817         No functionality change so no tests required.
 818
 819         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
 820
 821 2009-11-11  Jens Alfke  <snej@chromium.org>
 822
 823         Reviewed by Dimitri Glazkov.
 824
 825         The Big De-Inlining. 450k code size reduction (32-bit x86.)
 826         - Various inline functions in V8Binding.h made non-inline.
 827         - Some renaming for consistency.
 828         - New function createRawTemplate().
 829         https://bugs.webkit.org/show_bug.cgi?id=31383
 830
 831         * bindings/scripts/CodeGeneratorV8.pm:
 832         * bindings/v8/V8Binding.cpp:
 833         (WebCore::v8DOMWrapperToNative):
 834         (WebCore::v8ValueToWebCoreString):
 835         (WebCore::v8ValueToAtomicWebCoreString):
 836         (WebCore::toInt32):
 837         (WebCore::toWebCoreString):
 838         (WebCore::toWebCoreStringWithNullCheck):
 839         (WebCore::toAtomicWebCoreStringWithNullCheck):
 840         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
 841         (WebCore::isUndefinedOrNull):
 842         (WebCore::v8Boolean):
 843         (WebCore::v8UndetectableString):
 844         (WebCore::v8StringOrNull):
 845         (WebCore::v8StringOrUndefined):
 846         (WebCore::v8StringOrFalse):
 847         (WebCore::v8StringToWebCoreString):
 848         (WebCore::v8ExternalString):
 849         (WebCore::createRawTemplate):  New function.
 850         * bindings/v8/V8Binding.h:
 851         (WebCore::v8DOMWrapperTo):
 852         (WebCore::v8DOMWrapperToNode):
 853         (WebCore::v8StringToWebCoreString):
 854         (WebCore::v8StringToAtomicWebCoreString):
 855
 856 2009-11-11  Jens Alfke  <snej@chromium.org>
 857
 858         Reviewed by Dimitri Glazkov.
 859
 860         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
 861         event-listener setter into a new subroutine transferHiddenDependency().
 862         https://bugs.webkit.org/show_bug.cgi?id=31377
 863
 864         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
 865         * bindings/v8/V8Utilities.cpp:
 866         (WebCore::transferHiddenDependency):  New.
 867         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
 868
 869 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
 870
 871         Reviewed by Beth Dakin.
 872
 873         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
 874         because there is a CG bug preventing this from working.
 875
 876         * platform/graphics/cg/GraphicsContextCG.cpp:
 877         (WebCore::sRGBColorSpaceRef):
 878
 879 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
 880
 881         Reviewed by Timothy Hatcher.
 882
 883         Check that if Storage panel exists before calling its methods
 884
 885         https://bugs.webkit.org/show_bug.cgi?id=31343
 886
 887         * inspector/front-end/inspector.js:
 888         (WebInspector.addDatabase):
 889         (WebInspector.addCookieDomain):
 890         (WebInspector.addDOMStorage):
 891         (WebInspector.updateDOMStorage):
 892
 893 2009-11-11  Jens Alfke  <snej@chromium.org>
 894
 895         Reviewed by Dimitri Glazkov.
 896
 897         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
 898         times in the generated V8 bindings.
 899         https://bugs.webkit.org/show_bug.cgi?id=31368
 900
 901         * bindings/v8/V8DOMWrapper.cpp:
 902         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
 903         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
 904
 905 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
 906
 907         Reviewed by Timothy Hatcher.
 908
 909         Display the correct summary in the web inspector for the shorthands
 910         border-color, border-width, border-style, margin, and padding.
 911         https://bugs.webkit.org/show_bug.cgi?id=7987
 912
 913         Test: fast/css/shorthands-four-values.html
 914
 915         * css/CSSMutableStyleDeclaration.cpp:
 916         (WebCore::CSSMutableStyleDeclaration::get4Values):
 917         Display the summary information in the same way the shorthand would be
 918         specified in a css rule.
 919
 920 2009-11-11  Jens Alfke  <snej@chromium.org>
 921
 922         Reviewed by Dimitri Glazkov.
 923
 924         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
 925         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
 926         https://bugs.webkit.org/show_bug.cgi?id=31367
 927
 928         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
 929
 930 2009-11-11  Jens Alfke  <snej@chromium.org>
 931
 932         Reviewed by Dimitri Glazkov.
 933
 934         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
 935
 936         * bindings/v8/DOMData.cpp:
 937         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
 938             so it can be inlined by its caller.
 939         * bindings/v8/DOMData.h:
 940         * bindings/v8/MainThreadDOMData.cpp:
 941         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
 942         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
 943         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
 944             and getStore, which inline both calls together.
 945         * bindings/v8/MainThreadDOMData.h:
 946         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
 947         * bindings/v8/V8DOMMap.cpp:
 948         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
 949
 950 2009-11-11  Nate Chapin  <japhet@chromium.org>
 951
 952         Reviewed by Dimitri Glazkov.
 953
 954         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
 955
 956         https://bugs.webkit.org/show_bug.cgi?id=31357
 957
 958         * platform/KURLGoogle.cpp:
 959         (WebCore::isSchemeFirstChar):
 960         (WebCore::isSchemeChar):
 961         (WebCore::KURL::hasPort):
 962         (WebCore::KURL::removePort):
 963         (WebCore::protocolIsValid):
 964
 965 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
 966
 967         Build fix, no reviewed.
 968
 969         Correct setPlatformFillColor and setPlatformStrokeColor calls
 970         to match new ColorSpace-supporting signatures.
 971
 972         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
 973           color space to the set[...]Color calls.
 974
 975 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
 976
 977         Reviewed by Sam Weinig.
 978
 979         https://bugs.webkit.org/show_bug.cgi?id=31327
 980         Clean up SocketStreamHandleClient interface
 981
 982         No change in behavior.
 983
 984         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
 985         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
 986         the only client (WebSocketChannel), and it's not clear what this callback's semantics
 987         should be.
 988         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
 989         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
 990         For ResourceHandle, this method is called when the user cancels authentication sheet,
 991         not when something happens with the stream.
 992
 993         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
 994         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
 995
 996         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
 997         callbacks have no real implementation yet.
 998
 999 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
1000
1001         Reviewed by Eric Seidel.
1002
1003         Allow custom memory allocation control for the part of page directory in WebCore
1004         https://bugs.webkit.org/show_bug.cgi?id=31350
1005
1006         Inherits the following classes from Noncopyable because these are instantiated
1007         by 'new' and these are no need to be copyable:
1008
1009         class DragController         - instantiated at: WebCore/page/Page.cpp:107
1010         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
1011         class Settings               - instantiated at: WebCore/page/Page.cpp:116
1012         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
1013         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
1014         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
1015         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1016         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1017         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
1018
1019         Inherits PropertyWrapperBase class from Noncopyable because (its child class)
1020         PropertyWrapper is instantiated by 'new' in
1021         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1022
1023         * page/DragController.h:
1024         * page/EventHandler.h:
1025         * page/FocusController.h:
1026         * page/FrameView.cpp:
1027         * page/PluginHalter.h:
1028         * page/Settings.h:
1029         * page/UserScript.h:
1030         * page/UserStyleSheet.h:
1031         * page/XSSAuditor.h:
1032         * page/animation/AnimationBase.cpp:
1033
1034 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1035
1036         Reviewed by Kenneth Rohde Christiansen.
1037
1038         https://bugs.webkit.org/show_bug.cgi?id=31323
1039         Fix a few compiler warnings
1040
1041         No new tests as there is no new functionality.
1042
1043         * editing/htmlediting.cpp:
1044         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1045         parentheses to silence gcc 4.4 -Wparentheses warnings
1046
1047 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1048
1049         Reviewed by Mark Rowe.
1050
1051         Set m_hasPendingGeometryChange to true by default, so that
1052         at least one call to NPP_SetWindow is executed, which is
1053         needed by the DRT plugin testing framework.
1054
1055         * plugins/PluginView.cpp:
1056         (WebCore::PluginView::PluginView):
1057
1058 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
1059
1060         Rubber-stamped by Kenneth Rohde Christiansen.
1061
1062         https://bugs.webkit.org/show_bug.cgi?id=31348
1063         [Qt] Remove unnecessary LUT creator from WebCore.pro
1064
1065         * WebCore.pro:
1066
1067 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1068
1069         Reviewed by Tor Arne Vestbø.
1070
1071         Introduce a function for querying the input method status
1072         in QWebPageClient.
1073
1074         * platform/qt/QWebPageClient.h:
1075
1076 2009-11-11  Benjamin Otte  <otte@gnome.org>
1077
1078         Reviewed by Jan Alonzo.
1079
1080         [GTK] Black artifacts in youtube.com/html5
1081
1082         Paint the video to the given size. It's the job of the callers to keep
1083         track of aspect ratio. RenderVideo.cpp does it for the <video>
1084         element.
1085         https://bugs.webkit.org/show_bug.cgi?id=30925
1086
1087         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1088         (WebCore::MediaPlayerPrivate::paint):
1089
1090 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1091
1092         Reviewed by Reviewed by Jan Alonzo.
1093
1094         https://bugs.webkit.org/show_bug.cgi?id=30901
1095         [Gtk] Need to de-lint the Atk a11y code
1096
1097         Cleaned up some missed capitalization style-guideline violations.
1098
1099         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1100
1101 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1102
1103         Reviewed by Eric Seidel.
1104
1105         [Qt] Make the default style background color valid.
1106         Currently the color is transparent but invalid, this causes
1107         list boxes in QtWebKit to be drawn with a black background
1108         since r49242.
1109         https://bugs.webkit.org/show_bug.cgi?id=31295
1110
1111         * rendering/style/RenderStyle.h:
1112         (WebCore::InheritedFlags::initialBackgroundColor):
1113         * rendering/style/StyleBackgroundData.cpp:
1114         (WebCore::StyleBackgroundData::StyleBackgroundData):
1115
1116 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1117
1118         Reviewed by Geoff Garen.
1119
1120         Simplify the ownership model for worlds - rather than having a pair of weak references
1121         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1122         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
1123         back forward cache.
1124
1125         * WebCore.base.exp:
1126         * bindings/js/JSDOMBinding.cpp:
1127         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1128         * bindings/js/JSDOMBinding.h:
1129         (WebCore::DOMWrapperWorld::forgetDocument):
1130         * bindings/js/ScriptCachedFrameData.cpp:
1131         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1132         (WebCore::ScriptCachedFrameData::restore):
1133         (WebCore::ScriptCachedFrameData::clear):
1134         * bindings/js/ScriptCachedFrameData.h:
1135         * bindings/js/ScriptController.cpp:
1136         (WebCore::ScriptController::~ScriptController):
1137         (WebCore::ScriptController::clearWindowShell):
1138         (WebCore::ScriptController::initScript):
1139         (WebCore::ScriptController::updateDocument):
1140         * bindings/js/ScriptController.h:
1141
1142 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
1143
1144         Reviewed by Darin Adler.
1145
1146         rename counter to makeCounterNode in RenderCounter.cpp
1147         https://bugs.webkit.org/show_bug.cgi?id=31289
1148
1149         No new test because this is just a small refactoring.
1150
1151         * rendering/RenderCounter.cpp:
1152         (WebCore::findPlaceForCounter):
1153         (WebCore::makeCounterNode):
1154         (WebCore::RenderCounter::originalText):
1155
1156 2009-11-10  Daniel Bates  <dbates@webkit.org>
1157
1158         Reviewed by Oliver Hunt.
1159
1160         https://bugs.webkit.org/show_bug.cgi?id=30754
1161
1162         Patch 2 of 2.
1163
1164         Removed method EventHandler::dragSourceMovedTo, since it is no longer
1165         needed. This method fired a drag event whenever the mouse moved, but
1166         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1167         model independent of when the mouse moves. See "Among other changes..."
1168         in the change log for patch 1 for more details.
1169
1170         * WebCore.DragSupport.exp:
1171         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1172         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1173         * page/EventHandler.h:
1174
1175 2009-11-10  Daniel Bates  <dbates@webkit.org>
1176
1177         Reviewed by Oliver Hunt.
1178
1179         https://bugs.webkit.org/show_bug.cgi?id=30754
1180
1181         Patch 1 of 2.
1182
1183         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1184         the drag event should always fire before the dragover event.
1185
1186         In fixing this bug, this patch also makes our drag processing model
1187         conform to the HTML 5 spec.
1188
1189         Among the changes, this patch ensures that the drag event isn't fired outside
1190         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1191         Currently, the drag event is fired whenever the mouse button is down and the OS
1192         detects the mouse moved. But, as per the spec, the drag event should
1193         fire approx. every 350ms so long as the mouse button is down.
1194
1195         Test: fast/events/drag-and-drop-fire-drag-dragover.html
1196
1197         * page/EventHandler.cpp:
1198         (WebCore::EventHandler::clear):
1199         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1200         Modified to determine when we are in the correct instance of EventHandler to service the drag
1201         and drop operation.
1202         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1203         into this method.
1204         (WebCore::EventHandler::cancelDragAndDrop):
1205         (WebCore::EventHandler::performDragAndDrop):
1206         (WebCore::EventHandler::clearDragState):
1207         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1208         we should fire both drag and dragover events or only the dragover event.
1209
1210 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
1211
1212         Reviewed by Dimitri Glazkov.
1213
1214         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1215         https://bugs.webkit.org/show_bug.cgi?id=31301
1216
1217         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1218
1219         Allowed passing V8Proxy for the calling JS context:
1220         * bindings/v8/V8DOMWrapper.h:
1221         (WebCore::V8DOMWrapper::getXPathNSResolver):
1222         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1223         (WebCore::V8CustomXPathNSResolver::create):
1224         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1225         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1226         * bindings/v8/custom/V8CustomXPathNSResolver.h:
1227         * bindings/v8/custom/V8DocumentCustom.cpp:
1228         (WebCore::CALLBACK_FUNC_DECL):
1229
1230 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
1231
1232         Reviewed by Timothy Hatcher.
1233
1234         Implement URL decomposition IDL attributes for HTMLAnchorElement.
1235         https://bugs.webkit.org/show_bug.cgi?id=29972.
1236
1237         Add methods for setting different parts of the URL in href attribute.
1238
1239         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1240                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1241                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1242                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1243                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1244                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1245                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1246
1247         * bindings/js/JSLocationCustom.cpp:
1248         (WebCore::JSLocation::setPort):
1249         * html/HTMLAnchorElement.cpp:
1250         (WebCore::parsePortFromStringPosition):
1251         (WebCore::HTMLAnchorElement::setHash):
1252         (WebCore::HTMLAnchorElement::setHost):
1253         (WebCore::HTMLAnchorElement::setHostname):
1254         (WebCore::HTMLAnchorElement::setPathname):
1255         (WebCore::HTMLAnchorElement::setPort):
1256         (WebCore::HTMLAnchorElement::setProtocol):
1257         (WebCore::HTMLAnchorElement::setSearch):
1258         * html/HTMLAnchorElement.h:
1259         * html/HTMLAnchorElement.idl:
1260         * loader/FrameLoader.cpp:
1261         (WebCore::FrameLoader::iconURL):
1262         * platform/KURL.cpp:
1263         (WebCore::KURL::removePort):
1264         (WebCore::KURL::setPort):
1265         (WebCore::KURL::prettyURL):
1266         (WebCore::protocolIsValid):
1267         * platform/KURL.h:
1268         (WebCore::KURL::canSetHostOrPort):
1269         (WebCore::KURL::canSetPathname):
1270         (WebCore::KURL::hasPort):
1271         * platform/network/soup/ResourceHandleSoup.cpp:
1272         (WebCore::):
1273
1274 2009-11-10  Nate Chapin  <japhet@chromium.org>
1275
1276         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1277
1278         * platform/chromium/PopupMenuChromium.cpp:
1279         (WebCore::PopupContainer::paintBorder):
1280         (WebCore::PopupListBox::paint):
1281         (WebCore::PopupListBox::paintRow):
1282         * platform/graphics/chromium/TransparencyWin.cpp:
1283         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1284         * platform/graphics/skia/GraphicsContextSkia.cpp:
1285         (WebCore::GraphicsContext::fillRect):
1286         (WebCore::GraphicsContext::fillRoundedRect):
1287         (WebCore::GraphicsContext::setPlatformFillColor):
1288         (WebCore::GraphicsContext::setPlatformStrokeColor):
1289         * rendering/RenderMediaControlsChromium.cpp:
1290         (WebCore::paintMediaSlider):
1291         (WebCore::paintMediaVolumeSlider):
1292         (WebCore::paintMediaTimelineContainer):
1293         * rendering/RenderThemeChromiumMac.mm:
1294         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1295
1296 2009-11-10  Brady Eidson  <beidson@apple.com>
1297
1298         Reviewed by Sam Weinig.
1299
1300         Repro crash saving pcmag.com article as a webarchive.
1301         <rdar://problem/7381219> and https://webkit.org/b/31322
1302
1303         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1304
1305         * css/CSSStyleSheet.cpp:
1306         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1307           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1308
1309 2009-11-10  Beth Dakin  <bdakin@apple.com>
1310
1311         Attempt 2 to fix Tiger build. No review needed.
1312
1313         * platform/graphics/cg/GraphicsContextCG.cpp:
1314         (WebCore::deviceRGBColorSpaceRef):
1315         (WebCore::sRGBColorSpaceRef):
1316
1317 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
1318
1319         wx build fix. Changes needed after r50760.
1320
1321         * platform/graphics/wx/GraphicsContextWx.cpp:
1322         (WebCore::GraphicsContext::GraphicsContext):
1323         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1324         (WebCore::drawTextWithSpacing):
1325
1326 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1327
1328         Qt build fix.
1329
1330         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1331         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1332
1333 2009-11-10  Beth Dakin  <bdakin@apple.com>
1334
1335         Tiger build fix. No review needed.
1336
1337         * platform/graphics/cg/GraphicsContextCG.cpp:
1338         (WebCore::sRGBColorSpaceRef):
1339
1340 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1341
1342         Reviewed by Dan Bernstein.
1343
1344         https://bugs.webkit.org/show_bug.cgi?id=31312
1345         Decouple authentication panel callbacks from ResourceHandle
1346
1347         No change in functionality.
1348
1349         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1350         ResourceHandle as delegate.
1351
1352         * WebCore.vcproj/WebCore.vcproj:
1353         * platform/network/AuthenticationClient.h: Added.
1354         Added a new interface for listening to authentication panel notifications.
1355
1356         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1357         it wants with the project file.
1358
1359         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1360         interface class.
1361         (WebCore::AuthenticationClient::deref): Ditto.
1362
1363         * platform/network/ResourceHandle.h:
1364         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1365         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1366
1367         * platform/network/cf/AuthenticationCF.cpp:
1368         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1369         (WebCore::AuthenticationChallenge::platformCompare):
1370         * platform/network/cf/AuthenticationChallenge.h:
1371         (WebCore::AuthenticationChallenge::authenticationClient):
1372         * platform/network/chromium/AuthenticationChallenge.h:
1373         (WebCore::AuthenticationChallenge::authenticationClient):
1374         * platform/network/curl/AuthenticationChallenge.h:
1375         (WebCore::AuthenticationChallenge::authenticationClient):
1376         Keeping a reference to AuthenticationClient, not to ResourceHandle.
1377
1378 2009-11-10  Beth Dakin  <bdakin@apple.com>
1379
1380        Second attempted gtk build fix. No review needed.
1381
1382         * html/canvas/CanvasStyle.cpp:
1383         (WebCore::CanvasStyle::applyStrokeColor):
1384
1385
1386 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1387
1388         Reviewed by Geoff Garen.
1389
1390         Fix back/forwards cache with JSC isolated worlds.
1391         https://bugs.webkit.org/show_bug.cgi?id=31310
1392         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1393
1394         Store the global object for all worlds, not just the normal world.
1395         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1396         so we can forget global objects if a world goes away.
1397
1398         * bindings/js/JSDOMBinding.cpp:
1399         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1400         * bindings/js/JSDOMBinding.h:
1401         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
1402         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
1403         * bindings/js/ScriptCachedFrameData.cpp:
1404         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1405         (WebCore::ScriptCachedFrameData::forgetWorld):
1406         (WebCore::ScriptCachedFrameData::domWindow):
1407         (WebCore::ScriptCachedFrameData::restore):
1408         (WebCore::ScriptCachedFrameData::clear):
1409         * bindings/js/ScriptCachedFrameData.h:
1410         * bindings/js/ScriptController.h:
1411
1412 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1413
1414         [Qt] Unreviewed buildfix after r50760.
1415
1416         * platform/graphics/qt/GraphicsContextQt.cpp:
1417         (WebCore::GraphicsContext::GraphicsContext):
1418
1419 2009-11-10  Beth Dakin  <bdakin@apple.com>
1420
1421         Attempted build fix. (No review needed.)
1422
1423         * GNUmakefile.am: Adding ColorSpace.h
1424
1425 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
1426
1427         Reviewed by NOBODY - Build Fix.
1428
1429         Updated function calls to take a ColorSpace argument, passing
1430         in DeviceColorSpace for now - this should be fixed. Also added
1431         ColorSpace.h to WebCore project.
1432
1433         * WebCore.vcproj/WebCore.vcproj:
1434         * platform/graphics/win/FontCGWin.cpp:
1435         (WebCore::Font::drawGlyphs):
1436         * platform/graphics/win/GraphicsContextCGWin.cpp:
1437         (WebCore::GraphicsContext::GraphicsContext):
1438         * platform/win/PopupMenuWin.cpp:
1439         (WebCore::PopupMenu::paint):
1440         * platform/win/WebCoreTextRenderer.cpp:
1441         (WebCore::doDrawTextAtPoint):
1442         * rendering/RenderThemeSafari.cpp:
1443         (WebCore::RenderThemeSafari::paintMenuListButton):
1444
1445 2009-11-10  Jens Alfke  <snej@chromium.org>
1446
1447         Reviewed by Darin Adler.
1448
1449         Optimizations to Element::getAttribute
1450         https://bugs.webkit.org/show_bug.cgi?id=30926
1451
1452         * dom/Element.cpp:
1453         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
1454         * dom/NamedAttrMap.cpp:
1455         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
1456         * platform/text/PlatformString.h:
1457         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
1458
1459 2009-11-10  Beth Dakin  <bdakin@apple.com>
1460
1461         Reviewed by Darin Adler.
1462
1463         Fix for <rdar://problem/7059710>
1464         -and corresponding-
1465         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
1466         color-correction for CSS colors
1467
1468         New exported symbol for GraphicsContext::fillColor() which now
1469         accepts a ColorSpace as an optional parameter.
1470         * WebCore.base.exp:
1471
1472         Added a new file, ColorSpace.h, to define the ColorSpace enum.
1473         * WebCore.xcodeproj/project.pbxproj:
1474
1475         Computed Style for -webkit-color-correction
1476         * css/CSSComputedStyleDeclaration.cpp:
1477         (WebCore::):
1478         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1479
1480         Parse -webkit-color-correction
1481         * css/CSSParser.cpp:
1482         (WebCore::CSSParser::parseValue):
1483
1484        Map CSS identifiers to the appropriate values of the ColorSpace enum
1485         * css/CSSPrimitiveValueMappings.h:
1486         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1487         (WebCore::CSSPrimitiveValue::operator ColorSpace):
1488
1489         New property -webkit-color-correction
1490         * css/CSSPropertyNames.in:
1491
1492         Map -webkit-color-correction into the RenderStyle.
1493         * css/CSSStyleSelector.cpp:
1494         (WebCore::CSSStyleSelector::applyProperty):
1495
1496         Add new value sRGB.
1497         * css/CSSValueKeywords.in:
1498
1499         Comment out the reference to sRGB since it will now be inherited as
1500         a value from CSSValueKeywords.
1501         * css/SVGCSSValueKeywords.in:
1502
1503         Definition of the ColorSpace enum.
1504         * platform/graphics/ColorSpace.h: Added.
1505         (WebCore::):
1506
1507         These functions all now take a ColorSpace as a parameter.
1508         * platform/graphics/GraphicsContext.cpp:
1509         (WebCore::GraphicsContext::setStrokeColor):
1510         (WebCore::GraphicsContext::setFillColor):
1511         (WebCore::GraphicsContext::drawHighlightForText):
1512
1513         Return the appropriate ColorSpace.
1514         (WebCore::GraphicsContext::strokeColorSpace):
1515         (WebCore::GraphicsContext::fillColorSpace):
1516
1517         These functions all call other functions which require a ColorSpace
1518         as a parameter.
1519         (WebCore::GraphicsContext::setStrokePattern):
1520         (WebCore::GraphicsContext::setFillPattern):
1521         (WebCore::GraphicsContext::setStrokeGradient):
1522         (WebCore::GraphicsContext::setFillGradient):
1523
1524         All of the GraphicsContext functions that take a Color should now
1525         also take a ColorSpace.
1526         * platform/graphics/GraphicsContext.h:
1527
1528         Added new member variables stokeColorSpace and fillColorSpace.
1529         * platform/graphics/GraphicsContextPrivate.h:
1530         (WebCore::GraphicsContextState::GraphicsContextState):
1531
1532         Attempt to keep the Cairo port building with all of the massive
1533         changes to GraphicsContext.
1534         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1535         (WebCore::GraphicsContext::fillRect):
1536         (WebCore::GraphicsContext::setPlatformFillColor):
1537         (WebCore::GraphicsContext::setPlatformStrokeColor):
1538         (WebCore::GraphicsContext::fillRoundedRect):
1539
1540
1541         * platform/graphics/cg/GraphicsContextCG.cpp:
1542         (WebCore::sRGBColorSpaceRef): New static function that returns a
1543         CGColorSpaceRef for the sRGB color space.
1544         (WebCore::deviceRGBColorSpaceRef): New static function that returns
1545         a CGColorSpaceRef for the device RGB color space.
1546
1547         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and
1548         sets the fill color to the specified color in the given ColorSpace.
1549         (WebCore::setCGStrokeColor): Same, but for stroke.
1550
1551         (WebCore::setCGFillColorSpace): New static to set the
1552         CGFillColorSpace to the given ColorSpace
1553         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
1554
1555         Send ColorSpaces when appropriate, set ColorSpaces when
1556         appropriate, and check ColorSpaces when appropriate.
1557         (WebCore::GraphicsContext::GraphicsContext):
1558         (WebCore::GraphicsContext::drawRect):
1559         (WebCore::GraphicsContext::drawLine):
1560         (WebCore::GraphicsContext::fillPath):
1561         (WebCore::GraphicsContext::strokePath):
1562         (WebCore::GraphicsContext::fillRect):
1563         (WebCore::GraphicsContext::fillRoundedRect):
1564         (WebCore::GraphicsContext::strokeRect):
1565         (WebCore::GraphicsContext::drawLineForText):
1566         (WebCore::GraphicsContext::setPlatformStrokeColor):
1567         (WebCore::GraphicsContext::setPlatformFillColor):
1568
1569         Attempt to keep Haiku building.
1570         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1571         (WebCore::GraphicsContext::fillRect):
1572         (WebCore::GraphicsContext::fillRoundedRect):
1573         (WebCore::GraphicsContext::setPlatformStrokeColor):
1574         (WebCore::GraphicsContext::setPlatformFillColor):
1575
1576         Attempt to keep QT building.
1577         * platform/graphics/qt/GraphicsContextQt.cpp:
1578         (WebCore::GraphicsContext::fillRect):
1579         (WebCore::GraphicsContext::fillRoundedRect):
1580         (WebCore::GraphicsContext::setPlatformStrokeColor):
1581         (WebCore::GraphicsContext::setPlatformFillColor):
1582
1583         Attempt to keep Wince building.
1584         * platform/graphics/wince/GraphicsContextWince.cpp:
1585         (WebCore::GraphicsContext::fillRect):
1586         (WebCore::GraphicsContext::setPlatformFillColor):
1587         (WebCore::GraphicsContext::setPlatformStrokeColor):
1588         (WebCore::GraphicsContext::clearRect):
1589         (WebCore::GraphicsContext::fillRoundedRect):
1590         (WebCore::GraphicsContext::setPlatformShadow):
1591
1592         Attempt to keep WX building.
1593         * platform/graphics/wx/GraphicsContextWx.cpp:
1594         (WebCore::GraphicsContext::fillRect):
1595         (WebCore::GraphicsContext::fillRoundedRect):
1596         (WebCore::GraphicsContext::setPlatformStrokeColor):
1597         (WebCore::GraphicsContext::setPlatformFillColor):
1598
1599         Added functions colorSpace() and setColorSpace()
1600         * rendering/style/RenderStyle.h:
1601         (WebCore::InheritedFlags::colorSpace):
1602         (WebCore::InheritedFlags::setColorSpace):
1603
1604         The ColorSpace is stored here.
1605         * rendering/style/StyleRareInheritedData.cpp:
1606         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1607         (WebCore::StyleRareInheritedData::operator==):
1608         * rendering/style/StyleRareInheritedData.h:
1609
1610         All of these call sites call GraphicsContext functions which now
1611         require ColorSpaces.
1612         * editing/SelectionController.cpp:
1613         (WebCore::SelectionController::paintCaret):
1614         * html/canvas/CanvasRenderingContext2D.cpp:
1615         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1616         * html/canvas/CanvasStyle.cpp:
1617         (WebCore::CanvasStyle::applyStrokeColor):
1618         (WebCore::CanvasStyle::applyFillColor):
1619         * inspector/InspectorController.cpp:
1620         (WebCore::drawOutlinedQuad):
1621         * page/FrameView.cpp:
1622         (WebCore::FrameView::paintContents):
1623         * platform/ScrollbarTheme.h:
1624         (WebCore::ScrollbarTheme::paintScrollCorner):
1625         * platform/ScrollbarThemeComposite.cpp:
1626         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
1627         * platform/graphics/Image.cpp:
1628         (WebCore::Image::fillWithSolidColor):
1629         * platform/graphics/mac/FontMac.mm:
1630         (WebCore::Font::drawGlyphs):
1631         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1632         (WebCore::MediaPlayerPrivate::paint):
1633         * rendering/EllipsisBox.cpp:
1634         (WebCore::EllipsisBox::paint):
1635         * rendering/InlineFlowBox.cpp:
1636         (WebCore::InlineFlowBox::paintTextDecorations):
1637         * rendering/InlineTextBox.cpp:
1638         (WebCore::updateGraphicsContext):
1639         (WebCore::paintTextWithShadows):
1640         (WebCore::InlineTextBox::paint):
1641         (WebCore::InlineTextBox::paintSelection):
1642         (WebCore::InlineTextBox::paintCompositionBackground):
1643         (WebCore::InlineTextBox::paintDecoration):
1644         (WebCore::InlineTextBox::paintTextMatchMarker):
1645         (WebCore::InlineTextBox::paintCompositionUnderline):
1646         * rendering/InlineTextBox.h:
1647         * rendering/RenderBlock.cpp:
1648         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1649         (WebCore::RenderBlock::fillVerticalSelectionGap):
1650         (WebCore::RenderBlock::fillLeftSelectionGap):
1651         (WebCore::RenderBlock::fillRightSelectionGap):
1652         * rendering/RenderBoxModelObject.cpp:
1653         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1654         (WebCore::RenderBoxModelObject::paintBoxShadow):
1655         * rendering/RenderFileUploadControl.cpp:
1656         (WebCore::RenderFileUploadControl::paintObject):
1657         * rendering/RenderFrameSet.cpp:
1658         (WebCore::RenderFrameSet::paintColumnBorder):
1659         (WebCore::RenderFrameSet::paintRowBorder):
1660         * rendering/RenderImage.cpp:
1661         (WebCore::RenderImage::paintReplaced):
1662         * rendering/RenderLayer.cpp:
1663         (WebCore::RenderLayer::paintScrollCorner):
1664         (WebCore::RenderLayer::paintResizer):
1665         * rendering/RenderListBox.cpp:
1666         (WebCore::RenderListBox::paintItemForeground):
1667         (WebCore::RenderListBox::paintItemBackground):
1668         * rendering/RenderListMarker.cpp:
1669         (WebCore::RenderListMarker::paint):
1670         * rendering/RenderObject.cpp:
1671         (WebCore::RenderObject::drawLineForBoxSide):
1672         (WebCore::RenderObject::drawArcForBoxSide):
1673         * rendering/RenderReplaced.cpp:
1674         (WebCore::RenderReplaced::paint):
1675         * rendering/RenderScrollbarTheme.cpp:
1676         (WebCore::RenderScrollbarTheme::paintScrollCorner):
1677         * rendering/RenderThemeMac.mm:
1678         (WebCore::RenderThemeMac::paintMenuListButton):
1679         * rendering/RenderView.cpp:
1680         (WebCore::RenderView::paintBoxDecorations):
1681         * rendering/RenderWidget.cpp:
1682         (WebCore::RenderWidget::paint):
1683         * rendering/SVGInlineTextBox.cpp:
1684         (WebCore::SVGInlineTextBox::paintSelection):
1685         * svg/graphics/SVGPaintServerGradient.cpp:
1686         (WebCore::SVGPaintServerGradient::setup):
1687         * svg/graphics/SVGPaintServerSolid.cpp:
1688         (WebCore::SVGPaintServerSolid::setup):
1689
1690 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
1691
1692         Reviewed by Timothy Hatcher.
1693
1694         Web Inspector: Speed up syntax highlighter
1695         https://bugs.webkit.org/show_bug.cgi?id=31291
1696
1697         * inspector/front-end/SourceFrame.js:
1698         (WebInspector.SourceFrame.prototype._loaded):
1699         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
1700         (WebInspector.SourceSyntaxHighlighter.prototype.process):
1701         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
1702         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
1703         (WebInspector.CSSSourceSyntaxHighlighter):
1704         (WebInspector.JavaScriptSourceSyntaxHighlighter):
1705
1706 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
1707
1708         Reviewed by Eric Seidel.
1709
1710         Remove session storage setting
1711         https://bugs.webkit.org/show_bug.cgi?id=31279
1712
1713         Remove session storage from Settings.  It was added temporarily so we could
1714         disable it by default at runtime in Chromium.  We now disable these things in a
1715         different way, so it's time to remove it.  Qt also depended on this setting for
1716         a short period of time, but after talking to them we agreed that it should be
1717         removed.
1718
1719         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
1720
1721         * page/DOMWindow.cpp:
1722         (WebCore::DOMWindow::sessionStorage):
1723         * page/Settings.cpp:
1724         (WebCore::Settings::Settings):
1725         * page/Settings.h:
1726
1727 2009-11-10  Dan Bernstein  <mitz@apple.com>
1728
1729         Reviewed by Eric Carlson and Darin Adler.
1730
1731         WebCore part of making full-screen video pause during scrubbing.
1732
1733         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
1734         and HTMLMediaElement::endScrubbing().
1735
1736 2009-11-10  Anton Muhin  <antonm@chromium.org>
1737
1738         Reviewed by Adam Barth.
1739
1740         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
1741         https://bugs.webkit.org/show_bug.cgi?id=31051
1742
1743         * bindings/v8/V8GCController.cpp:
1744         (WebCore::V8GCController::gcEpilogue):
1745         (WebCore::V8GCController::checkMemoryUsage):
1746         * bindings/v8/V8GCController.h:
1747         * bindings/v8/V8Proxy.cpp:
1748         (WebCore::V8Proxy::evaluate):
1749         (WebCore::V8Proxy::runScript):
1750         (WebCore::V8Proxy::callFunction):
1751
1752 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
1753
1754         Reviewed by Darin Adler.
1755
1756         Allow custom memory allocation control for the part of loader directory in WebCore
1757         https://bugs.webkit.org/show_bug.cgi?id=31161
1758
1759         Inherits the following classes from Noncopyable because these are instantiated
1760         by 'new' and these are no need to be copyable:
1761
1762         class Request - WebCore/loader/loader.cpp:100
1763         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
1764         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
1765         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
1766         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
1767         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
1768
1769         Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
1770         MainThreadBridge is instantiated by 'new' in
1771         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
1772
1773         ThreadableLoaderClient's inheriting has been changed to public.
1774
1775         * loader/ImageLoader.cpp:
1776         * loader/ProgressTracker.cpp:
1777         * loader/RedirectScheduler.cpp:
1778         * loader/Request.h:
1779         * loader/ThreadableLoaderClient.h:
1780         * loader/WorkerThreadableLoader.h:
1781         * loader/appcache/ApplicationCacheHost.h:
1782         * loader/appcache/ApplicationCacheStorage.h:
1783
1784 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1785
1786         Reviewed by Eric Seidel.
1787
1788         https://bugs.webkit.org/show_bug.cgi?id=31047
1789         [GTK] Failing test media/video-played-ranges-1.html
1790
1791         WebKit coding style fixes.
1792
1793         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1794         (WebCore::mediaPlayerPrivateMessageCallback):
1795         (WebCore::MediaPlayerPrivate::naturalSize):
1796         (WebCore::MediaPlayerPrivate::paint):
1797         (WebCore::mimeTypeCache):
1798
1799 2009-11-10  Oliver Hunt  <oliver@apple.com>
1800
1801         Remove build failure introduced by earlier build fix.
1802
1803         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1804
1805 2009-11-10  Oliver Hunt  <oliver@apple.com>
1806
1807         Is this the last build fix? grep tells me yes.
1808
1809         * bindings/v8/custom/V8DocumentCustom.cpp:
1810         (WebCore::CALLBACK_FUNC_DECL):
1811
1812 2009-11-10  Oliver Hunt  <oliver@apple.com>
1813
1814         Hopefully the last one.  Why aren't these autogenerated?
1815
1816         * bindings/v8/V8DOMWrapper.cpp:
1817         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
1818         (WebCore::V8DOMWrapper::getTemplate):
1819         (WebCore::V8DOMWrapper::convertToV8Object):
1820
1821 2009-11-10  Oliver Hunt  <oliver@apple.com>
1822
1823         Another chrome build fix.
1824
1825         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
1826         (WebCore::CALLBACK_FUNC_DECL):
1827
1828 2009-11-10  Oliver Hunt  <oliver@apple.com>
1829
1830         Yet another chrome buildfix
1831
1832         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
1833         (WebCore::CALLBACK_FUNC_DECL):
1834         * bindings/v8/custom/V8WebGLArrayCustom.h:
1835         (WebCore::constructCanvasArray):
1836         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
1837         (WebCore::CALLBACK_FUNC_DECL):
1838         (WebCore::INDEXED_PROPERTY_GETTER):
1839         (WebCore::INDEXED_PROPERTY_SETTER):
1840         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
1841         (WebCore::CALLBACK_FUNC_DECL):
1842         (WebCore::INDEXED_PROPERTY_GETTER):
1843         (WebCore::INDEXED_PROPERTY_SETTER):
1844         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1845         (WebCore::CALLBACK_FUNC_DECL):
1846         (WebCore::INDEXED_PROPERTY_GETTER):
1847         (WebCore::INDEXED_PROPERTY_SETTER):
1848         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
1849         (WebCore::CALLBACK_FUNC_DECL):
1850         (WebCore::vertexAttribAndUniformHelperf):
1851         (WebCore::uniformHelperi):
1852         (WebCore::uniformMatrixHelper):
1853         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
1854         (WebCore::CALLBACK_FUNC_DECL):
1855         (WebCore::INDEXED_PROPERTY_GETTER):
1856         (WebCore::INDEXED_PROPERTY_SETTER):
1857         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
1858         (WebCore::CALLBACK_FUNC_DECL):
1859         (WebCore::INDEXED_PROPERTY_GETTER):
1860         (WebCore::INDEXED_PROPERTY_SETTER):
1861         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
1862         (WebCore::CALLBACK_FUNC_DECL):
1863         (WebCore::INDEXED_PROPERTY_GETTER):
1864         (WebCore::INDEXED_PROPERTY_SETTER):
1865         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
1866         (WebCore::CALLBACK_FUNC_DECL):
1867         (WebCore::INDEXED_PROPERTY_GETTER):
1868         (WebCore::INDEXED_PROPERTY_SETTER):
1869
1870 2009-11-10  Oliver Hunt  <oliver@apple.com>
1871
1872         Chrome build fix.
1873
1874         * bindings/v8/V8Index.h:
1875
1876 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1877
1878         Reviewed by Reviewed by Jan Alonzo.
1879
1880         https://bugs.webkit.org/show_bug.cgi?id=30901
1881         [Gtk] Need to de-lint the Atk a11y code
1882
1883         Removal of various and sundry style-violating nits.
1884
1885         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1886
1887 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1888
1889         Reviewed by Jan Alonzo.
1890
1891         https://bugs.webkit.org/show_bug.cgi?id=31047
1892         [GTK] Failing test media/video-played-ranges-1.html
1893
1894         Fix playback rate setter by remembering the rate was changed. Also
1895         correctly handle reverse playback by doing a seek from end to
1896         beginning of the media.
1897
1898         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1899         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
1900         (WebCore::MediaPlayerPrivate::currentTime):
1901         (WebCore::MediaPlayerPrivate::seek):
1902         (WebCore::MediaPlayerPrivate::hasAudio):
1903         (WebCore::MediaPlayerPrivate::setVolume):
1904         (WebCore::MediaPlayerPrivate::setRate):
1905         (WebCore::MediaPlayerPrivate::updateStates):
1906         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
1907
1908 2009-11-10  Oliver Hunt  <oliver@apple.com>
1909
1910         Reviewed by Maciej Stachowiak.
1911
1912         Rename 3D Canvas related classes to use WebGL prefix
1913         https://bugs.webkit.org/show_bug.cgi?id=29095
1914
1915         Automatic rename of all WebGL related types from Canvas* to
1916         WebGL* per more recent version of the WebGL spec.
1917
1918         Due to the automatic rename I've removed the 600+ line change list.
1919
1920 2009-11-09  Dirk Schulze  <krit@webkit.org>
1921
1922         Reviewed by Oliver Hunt.
1923
1924         SVG feDisplacementMap is not implemented
1925         [https://bugs.webkit.org/show_bug.cgi?id=31255]
1926
1927         This is the implementation of the SVG filter effect
1928         feDisplacementMap.
1929
1930         Test: svg/filters/feDisplacementMap.svg
1931
1932         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
1933         (WebCore::FEDisplacementMap::apply):
1934
1935 2009-11-09  Kent Tamura  <tkent@chromium.org>
1936
1937         Reviewed by Darin Adler.
1938
1939         Add a comment about null strings and hash functions.
1940         https://bugs.webkit.org/show_bug.cgi?id=29118
1941
1942         * platform/text/StringHash.h:
1943
1944 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1945
1946         Reviewed by Darin Adler.
1947
1948         Compiler warnings in InspectorResource.h
1949         https://bugs.webkit.org/show_bug.cgi?id=29231
1950
1951         Fix compilation warnings by removing addition operation on an enum type.
1952
1953         * inspector/InspectorResource.h:
1954         (WebCore::InspectorResource::):
1955         (WebCore::InspectorResource::Changes::hasChange):
1956         (WebCore::InspectorResource::Changes::set):
1957         (WebCore::InspectorResource::Changes::setAll):
1958
1959 2009-11-09  Anders Carlsson  <andersca@apple.com>
1960
1961         Reviewed by Darin Adler and Dan Bernstein.
1962
1963         <rdar://problem/7328395>
1964         https://bugs.webkit.org/show_bug.cgi?id=31277
1965
1966         When an object tag's style changes (for example when child nodes are added/removed),
1967         reuse its Frame (if it has one) instead of creating multiple Frames.
1968
1969         Test: fast/dom/HTMLObjectElement/children-changed.html
1970
1971         * loader/FrameLoader.cpp:
1972         (WebCore::FrameLoader::requestObject):
1973
1974 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
1975
1976         Reviewed by Kenneth Rohde Christiansen.
1977
1978         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
1979         since adjustment of RW-section base address will be needed for all new symbian
1980         tool chains, specifically for arm and gcc compilation targets.
1981         Also, change target address to 0xE00000 to be sufficient for all targets.
1982
1983         * WebCore.pro:
1984
1985 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
1986
1987         Reviewed by Timothy Hatcher.
1988
1989         Web Inspector: Crash when inspecting
1990         WebCore\manual-tests\inspector\dom-mutation.html
1991
1992         https://bugs.webkit.org/show_bug.cgi?id=31259
1993
1994         * inspector/InspectorDOMAgent.cpp:
1995         (WebCore::InspectorDOMAgent::handleEvent):
1996
1997 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1998
1999         Reviewed by Kenneth Rohde Christiansen.
2000
2001         [Qt] Few classes have virtual functions but non-virtual destructor
2002         https://bugs.webkit.org/show_bug.cgi?id=31269
2003
2004         No new tests as there is no functional change.
2005
2006         * platform/qt/QWebPageClient.h:
2007         (QWebPageClient::~QWebPageClient): Add virtual destructor.
2008
2009 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2010
2011         Reviewed by Kenneth Rohde Christiansen.
2012
2013         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2014         https://bugs.webkit.org/show_bug.cgi?id=31140
2015
2016         QtNetwork interprets null string as request to remove the header, not add it.
2017         Replace null values with empty values before passing them to QtNetwork.
2018
2019         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2020
2021         * platform/network/qt/ResourceRequestQt.cpp:
2022         (WebCore::ResourceRequest::toNetworkRequest):
2023
2024 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
2025
2026         Reviewed by Kevin Ollivier.
2027
2028         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2029         simply ignored before resulting in transparent areas being black in PNG
2030         images for example.
2031
2032         https://bugs.webkit.org/show_bug.cgi?id=30823
2033
2034         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2035         (WebCore::RGBA32Buffer::asNewNativeImage):
2036
2037 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2038
2039         Reviewed by Kenneth Rohde Christiansen.
2040
2041         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2042         https://bugs.webkit.org/show_bug.cgi?id=31040
2043
2044         No new tests as there is no functional change.
2045
2046         * dom/Document.cpp:
2047         (WebCore::Document::recalcStyleSelector):
2048         * editing/TextIterator.cpp:
2049         (WebCore::pushFullyClippedState):
2050         * editing/VisibleSelection.cpp:
2051         (WebCore::VisibleSelection::appendTrailingWhitespace):
2052         * html/HTMLLinkElement.cpp:
2053         (WebCore::HTMLLinkElement::process):
2054         * loader/RedirectScheduler.cpp:
2055         (WebCore::RedirectScheduler::mustLockBackForwardList):
2056         * loader/appcache/ApplicationCacheGroup.cpp:
2057         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2058         * platform/graphics/qt/FontCacheQt.cpp:
2059         (WebCore::FontPlatformDataCacheKey::computeHash):
2060         * rendering/RenderBlock.cpp:
2061         (WebCore::RenderBlock::handleRunInChild):
2062         * rendering/RenderBox.cpp:
2063         (WebCore::RenderBox::calcHeight):
2064         * rendering/RenderTextControlMultiLine.cpp:
2065         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2066         * rendering/style/RenderStyle.cpp:
2067         (WebCore::RenderStyle::diff):
2068         * svg/SVGAnimateElement.cpp:
2069         (WebCore::parseNumberValueAndUnit):
2070         * svg/SVGAnimationElement.cpp:
2071         (WebCore::SVGAnimationElement::startedActiveInterval):
2072         * svg/SVGPreserveAspectRatio.cpp:
2073         (WebCore::SVGPreserveAspectRatio::getCTM):
2074
2075 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
2076
2077         Reviewed by Dimitri Glazkov.
2078
2079         Win chromium is slow to draw transparent texts
2080         https://bugs.webkit.org/show_bug.cgi?id=31258
2081
2082         Clip graphics context to reduce calculation.
2083
2084         No new tests because this change only affects performance.
2085
2086         * platform/graphics/chromium/FontChromiumWin.cpp:
2087         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2088         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2089
2090 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
2091
2092         Reviewed by Darin Adler.
2093
2094         showTree(CounterNode*) generates too little info and has too many spaces.
2095         https://bugs.webkit.org/show_bug.cgi?id=31212
2096
2097         No new tests as the change has no functional effect it is just for
2098         improved debugging.
2099
2100         * rendering/CounterNode.cpp:
2101         (WebCore::showTreeAndMark):
2102         Changed to also show addresses of parent, next and previous
2103         siblings.
2104
2105 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
2106
2107         Reviewed by Darin Adler.
2108
2109         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2110         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2111
2112         https://bugs.webkit.org/show_bug.cgi?id=31083
2113
2114         No new tests; implementation is unchanged.
2115
2116         * page/Frame.cpp:
2117         (WebCore::Frame::setUseSecureKeyboardEntry):
2118         * page/mac/FrameMac.mm:
2119
2120 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2121
2122         Reviewed by Jan Alonzo.
2123
2124         Make XP_UNIX tests consistent
2125         https://bugs.webkit.org/show_bug.cgi?id=31250
2126
2127         No new tests as there is no functional change.
2128
2129         * plugins/PluginView.cpp:
2130         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2131         instead of the value of the macro
2132
2133         * plugins/gtk/PluginViewGtk.cpp:
2134         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2135         defined instead of using the PLATFORM macro to be consistent
2136         (WebCore::PluginView::getValue): Ditto.
2137
2138 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
2139
2140         Reviewed by Darin Adler.
2141
2142         Thunk to the main thread from ~Database to deref Database's m_document.
2143
2144         If the Database was the Document's last referrer, then ~Document occurs on the
2145         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2146         ASSERT in debug builds.
2147
2148         * storage/Database.cpp:
2149         (WebCore::derefDocument):
2150         (WebCore::Database::~Database):
2151
2152 2009-11-09  Mark Mentovai  <mark@chromium.org>
2153
2154         Reviewed by Dan Bernstein.
2155
2156         Track "can have scrollbar" state within FrameView independently of the
2157         individual scrollbar states in ScrollView.
2158
2159         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2160         REGRESSION (r48064): mint.com loses scrollbars after coming out of
2161         edit mode.
2162
2163         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2164         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2165
2166         Test: fast/overflow/scrollbar-restored.html
2167
2168         * WebCore.base.exp:
2169         * page/FrameView.cpp:
2170         (WebCore::FrameView::FrameView):
2171         (WebCore::FrameView::resetScrollbars):
2172         (WebCore::FrameView::setCanHaveScrollbars):
2173         (WebCore::FrameView::updateCanHaveScrollbars):
2174         (WebCore::FrameView::layout):
2175         * page/FrameView.h:
2176         * platform/ScrollView.h:
2177
2178 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
2179
2180         Reviewed by Timothy Hatcher.
2181
2182         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2183         https://bugs.webkit.org/show_bug.cgi?id=31257
2184
2185         * inspector/front-end/SourceFrame.js:
2186
2187 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
2188
2189         Reviewed by Timothy Hatcher.
2190
2191         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2192         https://bugs.webkit.org/show_bug.cgi?id=31252
2193
2194         Route F1-F12 keypresses in the Console view to the current panel if there is one.
2195
2196         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2197
2198         * inspector/front-end/ConsoleView.js:
2199         (WebInspector.ConsoleView.prototype._promptKeyDown):
2200         * inspector/front-end/utilities.js:
2201         ():
2202         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2203
2204 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2205
2206         Reviewed by Kenneth Rohde Christiansen.
2207
2208         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2209         https://bugs.webkit.org/show_bug.cgi?id=31208
2210
2211         After r42483, the credentials are no longer passed to the network request
2212         in the URL of the request.
2213         Pass the credentials from XMLHTTPRequest to the network request, the same
2214         way that other ports do.
2215
2216         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2217
2218         * platform/network/qt/ResourceHandleQt.cpp:
2219         (WebCore::ResourceHandle::start):
2220         (WebCore::ResourceHandle::loadResourceSynchronously):
2221
2222 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2223
2224         Unreviewed.
2225
2226         https://bugs.webkit.org/show_bug.cgi?id=31161
2227
2228         Roll back r50657 because it breaks the MAC builds.
2229
2230         * loader/ImageLoader.cpp:
2231         * loader/ProgressTracker.cpp:
2232         * loader/RedirectScheduler.cpp:
2233         * loader/Request.h:
2234         * loader/ThreadableLoaderClient.h:
2235         * loader/WorkerThreadableLoader.h:
2236         * loader/appcache/ApplicationCacheHost.h:
2237         * loader/appcache/ApplicationCacheStorage.h:
2238         * loader/icon/IconDatabaseClient.h:
2239
2240 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2241
2242         Reviewed by Darin Adler.
2243
2244         Allow custom memory allocation control for the part of loader directory in WebCore
2245         https://bugs.webkit.org/show_bug.cgi?id=31161
2246
2247         Inherits the following classes from Noncopyable because these are instantiated
2248         by 'new' and these are no need to be copyable:
2249
2250         class Request - WebCore/loader/loader.cpp:100
2251         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2252         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2253         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2254         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2255         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2256         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2257
2258         Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
2259         MainThreadBridge is instantiated by 'new' in
2260         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2261
2262         ThreadableLoaderClient's inheriting has been changed to public.
2263
2264         * loader/ImageLoader.cpp:
2265         * loader/ProgressTracker.cpp:
2266         * loader/RedirectScheduler.cpp:
2267         * loader/Request.h:
2268         * loader/ThreadableLoaderClient.h:
2269         * loader/WorkerThreadableLoader.h:
2270         * loader/appcache/ApplicationCacheHost.h:
2271         * loader/appcache/ApplicationCacheStorage.h:
2272         * loader/icon/IconDatabaseClient.h:
2273
2274 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2275
2276         Reviewed by Darin Adler.
2277
2278         Allow custom memory allocation control for WebCore's DocLoader
2279         https://bugs.webkit.org/show_bug.cgi?id=31163
2280
2281         Inherits DocLoader class from Noncopyable because it is
2282         instantiated by 'new' in WebCore/dom/Document.cpp:370 and
2283         it is no need to be copyable.
2284
2285         * loader/DocLoader.h:
2286
2287 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2288
2289         Reviewed by Darin Adler.
2290
2291         Allow custom memory allocation control for WebCore's Tokenizer
2292         https://bugs.webkit.org/show_bug.cgi?id=31162
2293
2294         Inherits Tokenizer class from Noncopyable because (its child class)
2295         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178
2296         and it is no need to be copyable.
2297
2298         * dom/Tokenizer.h:
2299
2300 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2301
2302         Reviewed by Darin Adler.
2303
2304         Allow custom memory allocation control for WebCore's DeleteButtonController
2305         https://bugs.webkit.org/show_bug.cgi?id=31105
2306
2307         Inherits DeleteButtonController class from Noncopyable because it is
2308         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2309         it is no need to be copyable.
2310
2311         * editing/DeleteButtonController.h:
2312
2313 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2314
2315         Reviewed by Jan Alonzo.
2316
2317         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2318         https://bugs.webkit.org/show_bug.cgi?id=30482
2319
2320         Expose Page::tabKeyCyclesThroughElements as a property of
2321         WebKitWebView.
2322
2323         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2324
2325         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2326         (WebCore::singleCharacterString):
2327
2328 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2329
2330         Reviewed by Xan Lopez.
2331
2332         https://bugs.webkit.org/show_bug.cgi?id=25415
2333         [GTK][ATK] Please implement support for get_text_at_offset
2334
2335         Fix a crasher that occurred with text which included newline
2336         chars in the markup.
2337
2338         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2339         (convertUniCharToUTF8):
2340
2341 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
2342
2343         Reviewed by Holger Freyther.
2344
2345         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2346         https://bugs.webkit.org/show_bug.cgi?id=31144
2347
2348         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2349         documents that end prematurely but are not considered invalid by QXmlStream.
2350         This is to stay compatible with the libxml2 implementation.
2351         However, that code path would be also hit in situations when it should not,
2352         i.e. the error would have already been caught and handled. As a result, the
2353         same error would be reported twice.
2354
2355         No new tests, because the problem is already covered by
2356         fast/parser/xml-declaration-missing-ending-mark.html.
2357
2358         * dom/XMLTokenizerQt.cpp:
2359         (WebCore::XMLTokenizer::doEnd):
2360
2361 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
2362
2363         Reviewed by Pavel Feldman.
2364
2365         Web Inspector: Inspector should support copy() in the command line
2366         https://bugs.webkit.org/show_bug.cgi?id=31238
2367
2368         * inspector/InspectorBackend.cpp:
2369         (WebCore::InspectorBackend::copyText): Added.
2370         * inspector/InspectorBackend.h: Added copyText
2371         * inspector/InspectorBackend.idl: Added copyText
2372         * inspector/front-end/InjectedScript.js:
2373         (InjectedScript._copy): Added.
2374         (InjectedScript._ensureCommandLineAPIInstalled):
2375
2376 2009-11-08  Drew Wilson  <atwilson@chromium.org>
2377
2378         Reviewed by Dimitri Glazkov.
2379
2380         V8 WorkerContextExecutionProxy does not handle SharedWorkers
2381         https://bugs.webkit.org/show_bug.cgi?id=31226
2382
2383         Now checks to see what type of context is active and creates the
2384         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2385
2386         Added support for converting to SharedWorkers and SharedWorkerContexts.
2387
2388         Test: Existing layout tests cover this case (start passing in Chrome).
2389
2390         * bindings/v8/WorkerContextExecutionProxy.cpp:
2391         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2392         Now generates the right type of DOMWrapper for SharedWorkerContexts.
2393         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2394         Added support for SHAREDWORKERCONTEXT.
2395         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2396         Added support for SharedWorker and SharedWorkerContext.
2397
2398 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
2399
2400         Reviewed by Dimitri Glazkov.
2401
2402         https://bugs.webkit.org/show_bug.cgi?id=31224
2403         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
2404
2405         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
2406
2407         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2408         (WebCore::NAMED_PROPERTY_GETTER):
2409
2410 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2411
2412         Reviewed by Timothy Hatcher.
2413
2414         Web Inspector: "Search again" on scripts panel switches
2415         to the script this search started with.
2416
2417         https://bugs.webkit.org/show_bug.cgi?id=31243
2418
2419         * inspector/front-end/Panel.js:
2420         (WebInspector.Panel.prototype.jumpToNextSearchResult):
2421
2422 2009-11-08  Kent Tamura  <tkent@chromium.org>
2423
2424         Reviewed by Darin Adler.
2425
2426         Simplify Icon interface.
2427         https://bugs.webkit.org/show_bug.cgi?id=31154
2428
2429         - Remove Icon::createIconForFile().  createIconForFiles() covers
2430           createIconForFile()'s role.
2431         - Remove FileChooser::chooseIcon()
2432         - Change the parameter types of FileChooser constructor and the
2433           factory method, String -> const Vector<String>&, in order to
2434           support initialization with multiple files.
2435         - Remove the icon loading code in IconChromiumWin.cpp, which
2436           doesn't work because of the sandbox.
2437
2438         No tests because it's just a refactoring.
2439
2440         * platform/FileChooser.cpp:
2441         (WebCore::FileChooser::FileChooser):
2442         (WebCore::FileChooser::create):
2443         (WebCore::FileChooser::chooseFile):
2444         (WebCore::FileChooser::chooseFiles):
2445         * platform/FileChooser.h:
2446         * platform/graphics/Icon.h:
2447         * platform/graphics/chromium/IconChromiumLinux.cpp:
2448         * platform/graphics/chromium/IconChromiumMac.cpp:
2449         * platform/graphics/chromium/IconChromiumWin.cpp:
2450         (WebCore::Icon::createIconForFiles):
2451         * platform/graphics/gtk/IconGtk.cpp:
2452         (WebCore::Icon::createIconForFiles):
2453         * platform/graphics/haiku/IconHaiku.cpp:
2454         * platform/graphics/mac/IconMac.mm:
2455         (WebCore::Icon::createIconForFiles):
2456         * platform/graphics/qt/IconQt.cpp:
2457         (WebCore::Icon::createIconForFiles):
2458         * platform/graphics/win/IconWin.cpp:
2459         (WebCore::Icon::createIconForFiles):
2460         * platform/graphics/wx/IconWx.cpp:
2461         * rendering/RenderFileUploadControl.cpp:
2462         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2463
2464 2009-11-08  Daniel Bates  <dbates@webkit.org>
2465
2466         Reviewed by Adam Barth.
2467
2468         https://bugs.webkit.org/show_bug.cgi?id=31098
2469
2470         Allows same-origin plugin-based content to load.
2471
2472         Test: http/tests/security/xssAuditor/object-src-inject.html
2473
2474         * page/XSSAuditor.cpp:
2475         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
2476         (WebCore::XSSAuditor::canLoadObject): Ditto.
2477         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
2478         (WebCore::XSSAuditor::isSameOriginResource): Added.
2479         * page/XSSAuditor.h:
2480
2481 2009-11-08  David Levin  <levin@chromium.org>
2482
2483         Reviewed by NOBODY (chromium build fix).
2484
2485         * platform/network/HTTPParsers.cpp:
2486         (WebCore::parseDate): Changed this to not
2487         use a date parser that needs ExecState passed.
2488
2489 2009-11-08  David Levin  <levin@chromium.org>
2490
2491         Unreviewed build fix for chromium.
2492
2493         * platform/graphics/skia/GraphicsContextSkia.cpp:
2494         (WebCore::GraphicsContext::fillPath):
2495         (WebCore::GraphicsContext::fillRect):
2496         (WebCore::GraphicsContext::strokePath):
2497         (WebCore::GraphicsContext::strokeRect):
2498
2499 2009-11-08  David Levin  <levin@chromium.org>
2500
2501         Unreviewed build fix for chromium.
2502
2503         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
2504         Clean up GraphicsContext's current concept of ColorSpace
2505
2506         * platform/graphics/skia/GraphicsContextSkia.cpp:
2507         (WebCore::GraphicsContext::fillPath):
2508         (WebCore::GraphicsContext::fillRect):
2509         (WebCore::GraphicsContext::strokePath):
2510         (WebCore::GraphicsContext::strokeRect):
2511
2512 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2513
2514         Reviewed by Timothy Hatcher.
2515
2516         Web Inspector: [REGRESSION] committing style edit
2517         clears elements panel selection.
2518
2519         https://bugs.webkit.org/show_bug.cgi?id=31242
2520
2521         * inspector/front-end/ElementsTreeOutline.js:
2522         (WebInspector.ElementsTreeOutline.prototype.update):
2523         * inspector/front-end/StylesSidebarPane.js:
2524         (WebInspector.StylePropertyTreeElement.prototype.):
2525         (WebInspector.StylePropertyTreeElement.prototype):
2526
2527 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
2528
2529         Reviewed by Holger Freyther.
2530
2531         ResourceRequest to be class instead of struct
2532         https://bugs.webkit.org/show_bug.cgi?id=30670
2533
2534         Started as a compilation fix for Symbian where the compiler makes a distinction between
2535         class and struct in function argument signatures.
2536         Changed all forward declarations of ResourceRequest to have class in the forward
2537         declaration instead of struct and changed the definition of ResourceRequest to be class
2538         and added access qualifiers where missing. Additionally two references of friend
2539         struct ResourceRequestBase changed to class instead.
2540
2541         * history/HistoryItem.h:
2542         * inspector/InspectorController.h:
2543         * inspector/InspectorResource.h:
2544         * loader/DocumentThreadableLoader.h:
2545         * loader/FrameLoaderClient.h:
2546         * loader/MainResourceLoader.h:
2547         * loader/ResourceLoadNotifier.h:
2548         * loader/SubresourceLoader.h:
2549         * loader/SubresourceLoaderClient.h:
2550         * loader/ThreadableLoader.h:
2551         * loader/WorkerThreadableLoader.h:
2552         * loader/appcache/ApplicationCache.h:
2553         * loader/appcache/ApplicationCacheHost.h:
2554         * platform/CrossThreadCopier.h:
2555         * platform/network/ResourceHandle.h:
2556         * platform/network/ResourceHandleClient.h:
2557         * platform/network/ResourceRequestBase.h:
2558         * platform/network/cf/ResourceRequest.h:
2559         * platform/network/cf/ResourceRequestCFNet.h:
2560         * platform/network/chromium/ResourceRequest.h:
2561         * platform/network/curl/ResourceRequest.h:
2562         * platform/network/qt/ResourceRequest.h:
2563         * platform/network/soup/ResourceRequest.h:
2564         * xml/XMLHttpRequest.h:
2565
2566 2009-11-08  Dan Bernstein  <mitz@apple.com>
2567
2568         Reviewed by Simon Fraser.
2569
2570         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
2571         below FrameView::layout
2572         https://bugs.webkit.org/show_bug.cgi?id=31093
2573
2574         Test: fast/block/positioning/relative-positioned-inline-container.html
2575
2576         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
2577         to mark the object for layout, doing so without marking its ancestors.
2578         However, RenderBlock::skipLeadingWhitespace and
2579         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
2580         positioned inline container, causing it to be marked for layout without
2581         ever going back to give it layout, and thus layout could end with a
2582         dirty object still in the tree, leading to all sorts of badness.
2583
2584         The fix is to revert setStaticY() to not marking the object dirty, and
2585         instead do it in the call sites that require it, which are in
2586         RenderBlock and RenderFlexibleBox.
2587
2588         * rendering/RenderBlock.cpp:
2589         (WebCore::RenderBlock::adjustPositionedBlock):
2590         * rendering/RenderFlexibleBox.cpp:
2591         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2592         (WebCore::RenderFlexibleBox::layoutVerticalBox):
2593         * rendering/RenderLayer.cpp:
2594         * rendering/RenderLayer.h:
2595         (WebCore::RenderLayer::setStaticY):
2596
2597 2009-11-07  Daniel Bates  <dbates@webkit.org>
2598
2599         Reviewed by Darin Adler.
2600
2601         https://bugs.webkit.org/show_bug.cgi?id=20780
2602
2603         Fixes an issue where the onchange event handler is not fired when the
2604         input field is autocompleted.
2605
2606         We cannot test this using DRT since DRT cannot emulate autocompletion.
2607         So, a manual-test is included.
2608
2609         Tests: manual-tests/autocompletion-fire-onchange.html
2610
2611         * manual-tests/autocompletion-fire-onchange.html: Added.
2612         * rendering/RenderTextControl.cpp:
2613         (WebCore::RenderTextControl::setInnerTextValue):
2614
2615 2009-11-07  Benjamin Otte  <otte@gnome.org>
2616
2617         Reviewed by Holger Freyther.
2618
2619         Mark redrawn areas on image surfaces as dirty.
2620
2621         This is required to conform to the Cairo API, but is currently only
2622         used by debugging tools like cairo-trace.
2623
2624         * platform/graphics/cairo/ImageBufferCairo.cpp:
2625         (WebCore::ImageBuffer::platformTransformColorSpace):
2626         (WebCore::putImageData):
2627
2628 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2629
2630         Reviewed by Xan Lopez.
2631
2632         https://bugs.webkit.org/show_bug.cgi?id=30878
2633         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
2634
2635         If the end_offset is -1, use the String length as the end_offset.
2636
2637         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2638         (webkit_accessible_text_get_text):
2639
2640 2009-11-06  Beth Dakin  <bdakin@apple.com>
2641
2642         Reviewed by Adele Peterson.
2643
2644         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up
2645         GraphicsContext's current concept of ColorSpace
2646
2647         ColorSpace is now called ColorType. The variables on the state we
2648         appropriately re-named as well. I removed strokeColorSpace() and
2649         fillColorSpace() from GraphicsContext since they were never called.
2650
2651         * platform/graphics/GraphicsContext.cpp:
2652         (WebCore::GraphicsContext::setStrokeColor):
2653         (WebCore::GraphicsContext::setFillColor):
2654         (WebCore::GraphicsContext::setStrokePattern):
2655         (WebCore::GraphicsContext::setFillPattern):
2656         (WebCore::GraphicsContext::setStrokeGradient):
2657         (WebCore::GraphicsContext::setFillGradient):
2658         * platform/graphics/GraphicsContext.h:
2659         (WebCore::):
2660         * platform/graphics/GraphicsContextPrivate.h:
2661         (WebCore::GraphicsContextState::GraphicsContextState):
2662         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2663         (WebCore::GraphicsContext::fillPath):
2664         (WebCore::GraphicsContext::strokePath):
2665         * platform/graphics/cg/GraphicsContextCG.cpp:
2666         (WebCore::calculateDrawingMode):
2667         (WebCore::GraphicsContext::drawPath):
2668         (WebCore::GraphicsContext::fillPath):
2669         (WebCore::GraphicsContext::strokePath):
2670         (WebCore::GraphicsContext::fillRect):
2671         (WebCore::GraphicsContext::strokeRect):
2672         * platform/graphics/qt/GraphicsContextQt.cpp:
2673         (WebCore::GraphicsContext::fillPath):
2674         (WebCore::GraphicsContext::strokePath):
2675         (WebCore::GraphicsContext::fillRect):
2676         * platform/graphics/wince/GraphicsContextWince.cpp:
2677         (WebCore::GraphicsContext::fillPath):
2678         (WebCore::GraphicsContext::fillRect):
2679
2680 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
2681
2682         Reviewed by Tim Hatcher.
2683
2684         Fixes <http://webkit.org/b/31177>.
2685         Web Inspector: Bind backspace to delete cookies and DOM Storage.
2686
2687         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
2688         places in the inspector can use editing in DataGrid (added a FIXME for
2689         some stuff that needs to be generalized).
2690
2691         Also added deleting functionality to DataGrid, and implemented it for
2692         Cookies and DOM Storage. The reason this patch is so big is because of
2693         the refactoring of editing code, which won't be used yet in a cross-datagrid
2694         way, but should be able to.
2695
2696         Additionally, moved the callbacks members from DOMStorageDataGrid to
2697         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to
2698         make the architecture of DOM Storage look a lot more like the Cookies view.
2699
2700         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the
2701         inspector from beeping at you when you delete an element.
2702
2703         * WebCore.gypi: Removed DOMStorageDataGrid.
2704         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
2705         * inspector/front-end/CookieItemsView.js:
2706         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
2707         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
2708         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2709         * inspector/front-end/DOMStorageDataGrid.js: Removed.
2710         * inspector/front-end/DOMStorageItemsView.js:
2711         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2712         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
2713         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
2714         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
2715         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
2716         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
2717         * inspector/front-end/DataGrid.js:
2718         (WebInspector.DataGrid):
2719         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
2720         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
2721         (WebInspector.DataGrid.prototype._startEditing): Ditto.
2722         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
2723         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
2724         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
2725         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
2726         * inspector/front-end/ElementsTreeOutline.js:
2727         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
2728         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
2729         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
2730
2731 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2732
2733         Qt build fix: added an ExecState parameter.
2734
2735         * bridge/qt/qt_runtime.cpp:
2736         (JSC::Bindings::convertValueToQVariant):
2737         (JSC::Bindings::convertQVariantToValue):
2738
2739 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2740
2741         https://bugs.webkit.org/show_bug.cgi?id=31197
2742         Implemented a timezone cache not based on Mac OS X's notify_check API.
2743
2744         Updated for JavaScriptCore internal API change.
2745
2746         * bridge/qt/qt_runtime.cpp:
2747         (JSC::Bindings::convertValueToQVariant):
2748         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
2749
2750         * platform/network/HTTPParsers.cpp:
2751         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
2752         (This function probably shouldn't be using a JavaScript date parser
2753         to begin with, but oh well.)
2754
2755 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2756
2757         Reviewed by Adam Barth.
2758
2759         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
2760         which affects Chromium only.
2761
2762         Changes to V8HTMLDocumentCustom.cpp are as below:-
2763         1. The HTMLDocumentOpen function would cause a crash in Chromium if
2764            there was no calling javascript context. We now check for this case
2765            and pass in NULL to the HTMLDocument::open function which can handle
2766            a NULL document parameter.
2767         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
2768            had ASSERTS for a NULL caller frame, which was bogus as it would crash
2769            anyway. We now check for this case and return a failure.
2770
2771         Changes to V8DOMWindowCustom.cpp are as below:-
2772         1. Instead of failing the window.open call made by NPAPI for lack of a
2773            calling javascript context, we now use the entered context as the calling
2774            context.
2775
2776         Tests: plugins/document-open.html
2777                plugins/window-open.html
2778
2779         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2780         (WebCore::CALLBACK_FUNC_DECL):
2781         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
2782         (WebCore::CALLBACK_FUNC_DECL):
2783
2784 2009-11-06  Steve Block  <steveblock@google.com>
2785
2786         Reviewed by Eric Seidel.
2787
2788         Geolocation error code UNKNOWN_ERROR is deprecated.
2789         https://bugs.webkit.org/show_bug.cgi?id=31184
2790
2791         Remove this error code from PositionError, both for use from C++ code and from the JS object.
2792
2793         Updated fast/dom/Geolocation/error.html to test this.
2794
2795         * page/PositionError.h: Modified.
2796         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
2797         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
2798         * page/Geolocation.cpp: Modified.
2799         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2800         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
2801         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2802
2803 2009-11-06  Dirk Schulze  <krit@webkit.org>
2804
2805         Reviewed by Nikolas Zimmermann.
2806
2807         feMorphology filter is not implemented
2808         [https://bugs.webkit.org/show_bug.cgi?id=5863]
2809
2810         The Implementation of feMorphology.
2811
2812         Test: We have allready a test for feMorphology
2813               svg/W3C-SVG-1.1/filters-morph-01-f.svg
2814
2815         * svg/graphics/filters/SVGFEMorphology.cpp:
2816         (WebCore::FEMorphology::apply):
2817
2818 2009-11-06  Steve Block  <steveblock@google.com>
2819
2820         Reviewed by Eric Seidel.
2821
2822         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
2823         https://bugs.webkit.org/show_bug.cgi?id=31209
2824
2825         Build fix only. No new tests possible.
2826
2827         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
2828
2829 2009-11-06  Drew Wilson  <atwilson@chromium.org>
2830
2831         Reviewed by David Levin.
2832
2833         V8 bindings do not support SharedWorkers as event targets
2834         https://bugs.webkit.org/show_bug.cgi?id=31199
2835
2836         No new tests because existing layout tests suffice (they currently
2837         crash on Chromium)
2838
2839         * bindings/v8/V8DOMWrapper.cpp:
2840         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
2841         Added clause to create a DOM wrapper for SharedWorkers.
2842
2843 2009-11-06  Anton Muhin  <antonm@chromium.org>
2844
2845         Reviewed by Adam Barth.
2846
2847         Do not unnecessarly synchronzie in weak reference callbacks.
2848         https://bugs.webkit.org/show_bug.cgi?id=31191
2849
2850         * bindings/v8/DOMData.h:
2851         (WebCore::DOMData::handleWeakObject):
2852
2853 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
2854
2855         Reviewed by Pavel Feldman.
2856
2857         Fix resource content search.
2858         https://bugs.webkit.org/show_bug.cgi?id=31202
2859
2860         * inspector/front-end/AbstractTimelinePanel.js:
2861         (WebInspector.AbstractTimelinePanel.prototype.refresh):
2862         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
2863         * inspector/front-end/TimelinePanel.js:
2864         (WebInspector.TimelineGraph.prototype.refresh):
2865
2866 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
2867
2868         Reviewed by Eric Seidel.
2869
2870         Fix ASSERT(currentStyle = renderStyle()).
2871         https://bugs.webkit.org/show_bug.cgi?id=31152
2872
2873         * dom/Element.cpp:
2874         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
2875
2876 2009-11-05  Alpha Lam  <hclam@chromium.org>
2877
2878         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
2879
2880         * bindings/v8/V8GCController.cpp:
2881         (WebCore::V8GCController::gcEpilogue):
2882         * bindings/v8/V8GCController.h:
2883         * bindings/v8/V8Proxy.cpp:
2884         (WebCore::V8Proxy::evaluate):
2885         (WebCore::V8Proxy::runScript):
2886         (WebCore::V8Proxy::callFunction):
2887
2888 2009-11-05  Adam Barth  <abarth@webkit.org>
2889
2890         Reviewed by Sam Weinig.
2891
2892         Cross-domain access to stylesheet text should not be allowed
2893         https://bugs.webkit.org/show_bug.cgi?id=20527
2894
2895         Check whether whether the current document can read the cssRules from
2896         the style sheet.  Firefox throws a security error here, but we return
2897         null instead because that's what we usually do in these cases.
2898
2899         Test: http/tests/security/cannot-read-cssrules-redirect.html
2900               http/tests/security/cannot-read-cssrules.html
2901
2902         * css/CSSStyleSheet.cpp:
2903         (WebCore::CSSStyleSheet::cssRules):
2904
2905 2009-11-05  Steve Block  <steveblock@google.com>
2906
2907         Reviewed by Eric Seidel.
2908
2909         If the Geolocation service fails to start, invoke the error callback asynchronously.
2910         https://bugs.webkit.org/show_bug.cgi?id=28276
2911
2912         All Geolocation callbacks must be invoked asynchronously.
2913         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
2914
2915         No new tests possible with current LayoutTestController.
2916
2917         * page/Geolocation.cpp:
2918         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
2919         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
2920         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
2921
2922 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2923
2924         Reviewed by Eric Seidel.
2925
2926         Removed the "this is part of the KDE project" comments from
2927         all *.h, *.cpp, *.idl, and *.pm files.
2928
2929         https://bugs.webkit.org/show_bug.cgi?id=31167
2930
2931         The maintenance and architecture page in the project wiki lists
2932         this as a task.
2933
2934         This change includes no changes or additions to test cases
2935         since the change affects only comments.
2936
2937         * bindings/scripts/CodeGeneratorV8.pm:
2938         * bindings/scripts/IDLParser.pm:
2939         * bindings/scripts/IDLStructure.pm:
2940         * css/CSSInheritedValue.cpp:
2941         * css/CSSInitialValue.cpp:
2942         * css/CSSMediaRule.cpp:
2943         * css/CSSNamespace.h:
2944         * css/CSSProperty.cpp:
2945         * css/CSSProperty.h:
2946         * css/CSSRuleList.cpp:
2947         * css/CSSRuleList.h:
2948         * css/CSSSelector.h:
2949         * css/CSSValueList.cpp:
2950         * css/FontValue.cpp:
2951         * css/MediaFeatureNames.cpp:
2952         * css/MediaFeatureNames.h:
2953         * css/Pair.h:
2954         * css/SVGCSSStyleSelector.cpp:
2955         * css/ShadowValue.cpp:
2956         * css/StyleSheet.cpp:
2957         * css/StyleSheetList.cpp:
2958         * css/maketokenizer:
2959         * dom/BeforeUnloadEvent.cpp:
2960         * dom/BeforeUnloadEvent.h:
2961         * dom/CSSMappedAttributeDeclaration.cpp:
2962         * dom/EventNames.cpp:
2963         * dom/EventTarget.cpp:
2964         * dom/MappedAttributeEntry.h:
2965         * dom/MouseRelatedEvent.h:
2966         * dom/RangeException.h:
2967         * dom/StyleElement.h:
2968         * dom/Tokenizer.h:
2969         * html/HTMLHeadElement.h:
2970         * html/HTMLHeadingElement.cpp:
2971         * html/HTMLHeadingElement.h:
2972         * html/HTMLHtmlElement.h:
2973         * html/HTMLImageLoader.h:
2974         * html/HTMLMetaElement.h:
2975         * html/HTMLModElement.cpp:
2976         * html/HTMLModElement.h:
2977         * html/HTMLOptionsCollection.cpp:
2978         * html/HTMLPlugInElement.cpp:
2979         * html/HTMLPreElement.cpp:
2980         * html/HTMLPreElement.h:
2981         * html/HTMLTableCellElement.cpp:
2982         * html/HTMLTableCellElement.h:
2983         * html/HTMLTableColElement.cpp:
2984         * html/HTMLTableColElement.h:
2985         * html/HTMLTablePartElement.cpp:
2986         * html/HTMLTablePartElement.h:
2987         * html/HTMLTitleElement.h:
2988         * page/MouseEventWithHitTestResults.h:
2989         * platform/StaticConstructors.h:
2990         * platform/text/AtomicStringImpl.h:
2991         * platform/text/qt/TextBreakIteratorQt.cpp:
2992         * rendering/AutoTableLayout.h:
2993         * rendering/CounterNode.cpp:
2994         * rendering/EllipsisBox.cpp:
2995         * rendering/EllipsisBox.h:
2996         * rendering/FixedTableLayout.cpp:
2997         * rendering/FixedTableLayout.h:
2998         * rendering/HitTestRequest.h:
2999         * rendering/HitTestResult.h:
3000         * rendering/InlineRunBox.h:
3001         * rendering/PointerEventsHitRules.cpp:
3002         * rendering/PointerEventsHitRules.h:
3003         * rendering/RenderBR.cpp:
3004         * rendering/RenderBR.h:
3005         * rendering/RenderButton.cpp:
3006         * rendering/RenderButton.h:
3007         * rendering/RenderFieldset.cpp:
3008         * rendering/RenderFrameSet.cpp:
3009         * rendering/RenderListItem.cpp:
3010         * rendering/RenderTableRow.cpp:
3011         * rendering/RenderView.h:
3012         * rendering/RootInlineBox.h:
3013         * rendering/SVGInlineTextBox.cpp:
3014         * rendering/SVGInlineTextBox.h:
3015         * rendering/TableLayout.h:
3016         * rendering/break_lines.h:
3017         * rendering/style/SVGRenderStyle.cpp:
3018         * rendering/style/SVGRenderStyle.h:
3019         * rendering/style/SVGRenderStyleDefs.cpp:
3020         * rendering/style/SVGRenderStyleDefs.h:
3021         * svg/GradientAttributes.h:
3022         * svg/LinearGradientAttributes.h:
3023         * svg/PatternAttributes.h:
3024         * svg/RadialGradientAttributes.h:
3025         * svg/SVGAElement.cpp:
3026         * svg/SVGAngle.idl:
3027         * svg/SVGAnimateColorElement.cpp:
3028         * svg/SVGAnimateColorElement.h:
3029         * svg/SVGAnimateElement.cpp:
3030         * svg/SVGAnimateElement.h:
3031         * svg/SVGAnimateTransformElement.h:
3032         * svg/SVGAnimatedPathData.cpp:
3033         * svg/SVGAnimatedPathData.h:
3034         * svg/SVGAnimatedPoints.cpp:
3035         * svg/SVGAnimatedPoints.h:
3036         * svg/SVGAnimationElement.cpp:
3037         * svg/SVGCircleElement.cpp:
3038         * svg/SVGClipPathElement.cpp:
3039         * svg/SVGColor.cpp:
3040         * svg/SVGColor.idl:
3041         * svg/SVGComponentTransferFunctionElement.cpp:
3042         * svg/SVGComponentTransferFunctionElement.h:
3043         * svg/SVGCursorElement.cpp:
3044         * svg/SVGDefsElement.cpp:
3045         * svg/SVGDescElement.cpp:
3046         * svg/SVGDescElement.h:
3047         * svg/SVGDocument.idl:
3048         * svg/SVGElement.idl:
3049         * svg/SVGElementInstanceList.cpp:
3050         * svg/SVGElementInstanceList.h:
3051         * svg/SVGEllipseElement.cpp:
3052         * svg/SVGExternalResourcesRequired.cpp:
3053         * svg/SVGFEBlendElement.cpp:
3054         * svg/SVGFEBlendElement.h:
3055         * svg/SVGFEColorMatrixElement.cpp:
3056         * svg/SVGFEColorMatrixElement.h:
3057         * svg/SVGFEComponentTransferElement.cpp:
3058         * svg/SVGFEComponentTransferElement.h:
3059         * svg/SVGFECompositeElement.cpp:
3060         * svg/SVGFECompositeElement.h:
3061         * svg/SVGFEFloodElement.cpp:
3062         * svg/SVGFEFloodElement.h:
3063         * svg/SVGFEFuncAElement.cpp:
3064         * svg/SVGFEFuncAElement.h:
3065         * svg/SVGFEFuncBElement.cpp:
3066         * svg/SVGFEFuncBElement.h:
3067         * svg/SVGFEFuncGElement.cpp:
3068         * svg/SVGFEFuncGElement.h:
3069         * svg/SVGFEFuncRElement.cpp:
3070         * svg/SVGFEFuncRElement.h:
3071         * svg/SVGFEGaussianBlurElement.cpp:
3072         * svg/SVGFEGaussianBlurElement.h:
3073         * svg/SVGFEImageElement.cpp:
3074         * svg/SVGFEMergeElement.cpp:
3075         * svg/SVGFEMergeElement.h:
3076         * svg/SVGFEMergeNodeElement.cpp:
3077         * svg/SVGFEOffsetElement.cpp:
3078         * svg/SVGFEOffsetElement.h:
3079         * svg/SVGFETileElement.cpp:
3080         * svg/SVGFETileElement.h:
3081         * svg/SVGFETurbulenceElement.cpp:
3082         * svg/SVGFETurbulenceElement.h:
3083         * svg/SVGFilterElement.cpp:
3084         * svg/SVGGElement.cpp:
3085         * svg/SVGGradientElement.cpp:
3086         * svg/SVGHKernElement.idl:
3087         * svg/SVGLangSpace.cpp:
3088         * svg/SVGLangSpace.h:
3089         * svg/SVGLength.cpp:
3090         * svg/SVGLength.h:
3091         * svg/SVGLength.idl:
3092         * svg/SVGLengthList.cpp:
3093         * svg/SVGLengthList.h:
3094         * svg/SVGLineElement.cpp:
3095         * svg/SVGLinearGradientElement.h:
3096         * svg/SVGList.h:
3097         * svg/SVGListTraits.h:
3098         * svg/SVGLocatable.h:
3099         * svg/SVGMaskElement.cpp:
3100         * svg/SVGMatrix.idl:
3101         * svg/SVGMetadataElement.cpp:
3102         * svg/SVGMetadataElement.h:
3103         * svg/SVGMetadataElement.idl:
3104         * svg/SVGNumber.idl:
3105         * svg/SVGNumberList.cpp:
3106         * svg/SVGNumberList.h:
3107         * svg/SVGPaint.cpp:
3108         * svg/SVGPathElement.cpp:
3109         * svg/SVGPathSeg.h:
3110         * svg/SVGPathSegArc.cpp:
3111         * svg/SVGPathSegArc.h:
3112         * svg/SVGPathSegClosePath.cpp:
3113         * svg/SVGPathSegClosePath.h:
3114         * svg/SVGPathSegCurvetoCubic.cpp:
3115         * svg/SVGPathSegCurvetoCubic.h:
3116         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
3117         * svg/SVGPathSegCurvetoCubicSmooth.h:
3118         * svg/SVGPathSegCurvetoQuadratic.cpp:
3119         * svg/SVGPathSegCurvetoQuadratic.h:
3120         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
3121         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
3122         * svg/SVGPathSegLineto.cpp:
3123         * svg/SVGPathSegLineto.h:
3124         * svg/SVGPathSegLinetoHorizontal.cpp:
3125         * svg/SVGPathSegLinetoHorizontal.h:
3126         * svg/SVGPathSegLinetoVertical.cpp:
3127         * svg/SVGPathSegLinetoVertical.h:
3128         * svg/SVGPathSegMoveto.cpp:
3129         * svg/SVGPathSegMoveto.h:
3130         * svg/SVGPatternElement.cpp:
3131         * svg/SVGPoint.idl:
3132         * svg/SVGPointList.cpp:
3133         * svg/SVGPointList.h:
3134         * svg/SVGPolyElement.cpp:
3135         * svg/SVGPolygonElement.cpp:
3136         * svg/SVGPolygonElement.h:
3137         * svg/SVGPolylineElement.cpp:
3138         * svg/SVGPolylineElement.h:
3139         * svg/SVGPreserveAspectRatio.cpp:
3140         * svg/SVGPreserveAspectRatio.h:
3141         * svg/SVGRadialGradientElement.h:
3142         * svg/SVGRect.idl:
3143         * svg/SVGRectElement.cpp:
3144         * svg/SVGRenderingIntent.h:
3145         * svg/SVGSVGElement.idl:
3146         * svg/SVGScriptElement.cpp:
3147         * svg/SVGSetElement.cpp:
3148         * svg/SVGSetElement.h:
3149         * svg/SVGStopElement.cpp:
3150         * svg/SVGStringList.cpp:
3151         * svg/SVGStringList.h:
3152         * svg/SVGStylable.cpp:
3153         * svg/SVGStylable.h:
3154         * svg/SVGStyleElement.cpp:
3155         * svg/SVGStyleElement.h:
3156         * svg/SVGStyledElement.h:
3157         * svg/SVGStyledLocatableElement.cpp:
3158         * svg/SVGStyledLocatableElement.h:
3159         * svg/SVGStyledTransformableElement.cpp:
3160         * svg/SVGStyledTransformableElement.h:
3161         * svg/SVGSwitchElement.cpp:
3162         * svg/SVGSymbolElement.cpp:
3163         * svg/SVGTRefElement.cpp:
3164         * svg/SVGTSpanElement.cpp:
3165         * svg/SVGTSpanElement.h:
3166         * svg/SVGTests.h:
3167         * svg/SVGTextElement.cpp:
3168         * svg/SVGTextElement.h:
3169         * svg/SVGTextPathElement.cpp:
3170         * svg/SVGTextPositioningElement.cpp:
3171         * svg/SVGTextPositioningElement.h:
3172         * svg/SVGTitleElement.cpp:
3173         * svg/SVGTitleElement.h:
3174         * svg/SVGTransform.cpp:
3175         * svg/SVGTransform.h:
3176         * svg/SVGTransform.idl:
3177         * svg/SVGTransformList.cpp:
3178         * svg/SVGTransformList.h:
3179         * svg/SVGTransformable.h:
3180         * svg/SVGURIReference.h:
3181         * svg/SVGUnitTypes.h:
3182         * svg/SVGUseElement.cpp:
3183         * svg/SVGViewElement.cpp:
3184         * svg/SVGZoomAndPan.cpp:
3185         * svg/SVGZoomAndPan.h:
3186         * svg/SVGZoomEvent.cpp:
3187
3188 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3189
3190         Reviewed by Dimitri Glazkov.
3191
3192         REGRESSION Clean up security origin usage in DOM Storage.
3193         https://bugs.webkit.org/show_bug.cgi?id=31188
3194
3195         Clean up security origin usage in DOM Storage.  This fixes a bug in my
3196         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
3197
3198         Instead of having StorageAreaSync's constructor (which is called in the
3199         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
3200         database identifier, simply have StorageAreaImpl pass the identifier into
3201         StorageAreaSync.
3202
3203         No test because there's no change in externally observable behavior.
3204
3205         * storage/StorageAreaImpl.cpp:
3206         (WebCore::StorageAreaImpl::StorageAreaImpl):
3207         * storage/StorageAreaImpl.h:
3208         * storage/StorageAreaSync.cpp:
3209         (WebCore::StorageAreaSync::create):
3210         (WebCore::StorageAreaSync::StorageAreaSync):
3211         * storage/StorageAreaSync.h:
3212
3213 2009-11-05  Scott Violet  <sky@google.com>
3214
3215         Reviewed by Dimitri Glazkov.
3216
3217         Need notification of scrolling frame
3218         https://bugs.webkit.org/show_bug.cgi?id=31145
3219
3220         Adds FrameLoaderClient::didChangeScrollOffset that is called when
3221         the frame scrolls. This will be used to know when history state
3222         needs to be updated.
3223
3224         * loader/FrameLoaderClient.h:
3225         (WebCore::FrameLoaderClient::didChangeScrollOffset):
3226         * page/FrameView.cpp:
3227         (WebCore::FrameView::valueChanged):
3228
3229 2009-11-05  Kenneth Russell  <kbr@google.com>
3230
3231         Reviewed by Dimitri Glazkov.
3232
3233         [V8] Update bindings to use new API for external arrays
3234         https://bugs.webkit.org/show_bug.cgi?id=31181
3235
3236         No new tests; covered by existing WebGL tests.
3237
3238         * bindings/v8/V8DOMWrapper.cpp:
3239         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
3240         (WebCore::V8DOMWrapper::getTemplate):
3241         (WebCore::V8DOMWrapper::convertToV8Object):
3242         * bindings/v8/V8DOMWrapper.h:
3243         * bindings/v8/custom/V8CanvasArrayCustom.h:
3244         (WebCore::constructCanvasArray):
3245
3246 2009-11-05  Alpha Lam  <hclam@chromium.org>
3247
3248         Not reviewed, Chromium build fix.
3249
3250         50561 introduces a custom method for SVGMatrix, we need to implement
3251         this in V8.
3252
3253         * bindings/v8/custom/V8CustomBinding.h:
3254         Adding definition for V8SVGMatrixMultiply.
3255         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
3256         (WebCore::CALLBACK_FUNC_DECL):
3257         Implement V8SVGMatrixMultiply according to the same method in JSC.
3258
3259 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3260
3261         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
3262
3263         * page/DOMWindow.cpp:
3264         (WebCore::DOMWindow::sessionStorage):
3265         * page/Settings.cpp:
3266         (WebCore::Settings::Settings):
3267         (WebCore::Settings::setSessionStorageEnabled):
3268         * page/Settings.h:
3269         (WebCore::Settings::sessionStorageEnabled):
3270
3271 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3272
3273         Reviewed by Timothy Hatcher.
3274
3275         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
3276
3277         https://bugs.webkit.org/show_bug.cgi?id=30884
3278
3279         Test: inspector/styles-iframe.html
3280
3281         * inspector/front-end/DOMAgent.js:
3282         (WebInspector.DOMNode):
3283         * inspector/front-end/InjectedScript.js:
3284         (InjectedScript.getStyles):
3285         (InjectedScript.getComputedStyle):
3286         (InjectedScript.addStyleSelector):
3287         * inspector/front-end/TestController.js:
3288         (WebInspector.TestController.prototype.notifyDone):
3289         (WebInspector.TestController.prototype.runAfterPendingDispatches):
3290         (WebInspector.evaluateForTestInFrontend.invokeMethod):
3291         (WebInspector.evaluateForTestInFrontend):
3292
3293 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
3294
3295         Reviewed by Geoffrey Garen and Dimitri Glazkov.
3296
3297         Rehashing of EventListenerMap leads to loss of EvenListenerList.
3298         https://bugs.webkit.org/show_bug.cgi?id=31027
3299
3300         Tested by new fast/events/event-listener-map-rehash-crash.html.
3301
3302         EventListenerMap modified to store pointers to listener vectors:
3303         * dom/EventTarget.cpp:
3304         (WebCore::EventTargetData::~EventTargetData):
3305         (WebCore::EventTarget::addEventListener):
3306         (WebCore::EventTarget::removeEventListener):
3307         (WebCore::EventTarget::fireEventListeners):
3308         (WebCore::EventTarget::getEventListeners):
3309         (WebCore::EventTarget::removeAllEventListeners):
3310         * dom/EventTarget.h:
3311
3312         Usages updated after interface changes:
3313         * inspector/InspectorDOMAgent.cpp:
3314         (WebCore::InspectorDOMAgent::getEventListenersForNode):
3315         * svg/SVGUseElement.cpp:
3316         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
3317
3318 2009-11-05  Dan Kegel  <dank@chromium.org>
3319
3320         Reviewed by Dmitri Titov.
3321
3322         Add missing initialization for m_createdByParser.
3323         https://bugs.webkit.org/show_bug.cgi?id=31089
3324
3325         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
3326
3327         * dom/ProcessingInstruction.cpp:
3328         (WebCore::ProcessingInstruction::ProcessingInstruction):
3329
3330 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3331
3332         Reviewed by Adam Barth.
3333
3334         DOM Storage runtime flag changes
3335         https://bugs.webkit.org/show_bug.cgi?id=30602
3336
3337         Part 2/2.
3338
3339         Revert my changes to Settings and instead implement DOM Storage enabling via
3340         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
3341
3342         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
3343         LayoutTest visible changes and thus no tests.
3344
3345         * bindings/v8/custom/V8CustomBinding.h:
3346         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3347         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3348         * page/DOMWindow.cpp:
3349         (WebCore::DOMWindow::sessionStorage):
3350         * page/DOMWindow.idl:
3351         * page/Settings.cpp:
3352         (WebCore::Settings::Settings):
3353         * page/Settings.h:
3354         * storage/Storage.cpp:
3355         (WebCore::Storage::setLocalStorageAvailable):
3356         (WebCore::Storage::localStorageAvailable):
3357         (WebCore::Storage::setSessionStorageAvailable):
3358         (WebCore::Storage::sessionStorageAvailable):
3359         * storage/Storage.h:
3360
3361 2009-11-05  Jian Li  <jianli@chromium.org>
3362
3363         Reviewed by Pavel Feldman.
3364
3365         Bug 31108 - [V8] REGRESSION: Pause on exception is broken
3366         https://bugs.webkit.org/show_bug.cgi?id=31108
3367
3368         * bindings/v8/V8AbstractEventListener.cpp:
3369         (WebCore::V8AbstractEventListener::invokeEventHandler):
3370         * bindings/v8/V8Utilities.cpp:
3371         (WebCore::reportException):
3372
3373 2009-11-05  Jian Li  <jianli@chromium.org>
3374
3375         Reviewed by Dmitri Titov.
3376
3377         We should not bubble up events if we drag something to an iframe that
3378         has an invalid source.
3379         https://bugs.webkit.org/show_bug.cgi?id=30469
3380
3381         Test: http/tests/misc/bubble-drag-events.html
3382
3383         * page/EventHandler.cpp:
3384         (WebCore::EventHandler::handleDragAndDropForTarget):
3385         (WebCore::EventHandler::updateDragAndDrop):
3386         (WebCore::EventHandler::cancelDragAndDrop):
3387         (WebCore::EventHandler::performDragAndDrop):
3388         * page/EventHandler.h:
3389         (WebCore::EventHandler::):
3390
3391 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3392
3393         Reviewed by Timothy Hatcher.
3394
3395         Web Inspector: speed up Timelines Clear by a factor of thousands.
3396
3397         https://bugs.webkit.org/show_bug.cgi?id=31160
3398
3399         * inspector/front-end/utilities.js:
3400         (Element.prototype.removeChildren):
3401
3402 2009-11-05  Anton Muhin  <antonm@chromium.org>
3403
3404         Reviewed by Adam Barth.
3405
3406         If high memory usage is detected, hint to V8 that it might be due
3407         to external objects retained by V8 objects.
3408         https://bugs.webkit.org/show_bug.cgi?id=31051
3409
3410         * bindings/v8/V8GCController.cpp:
3411         (WebCore::GetMemoryUsageInMB):
3412         (WebCore::V8GCController::gcEpilogue):
3413         (WebCore::V8GCController::checkMemoryUsage):
3414         * bindings/v8/V8GCController.h:
3415         * bindings/v8/V8Proxy.cpp:
3416         (WebCore::V8Proxy::evaluate):
3417         (WebCore::V8Proxy::runScript):
3418         (WebCore::V8Proxy::callFunction):
3419
3420 2009-11-05  Jeff Schiller  <codedread@gmail.com>
3421
3422         Reviewed by Simon Fraser.
3423
3424         Correct order of matrix multiplication for SVGMatrix.
3425         https://bugs.webkit.org/show_bug.cgi?id=16062
3426
3427         Test: svg/dom/SVGMatrix-interface.xhtml
3428
3429         * bindings/js/JSSVGMatrixCustom.cpp:
3430         (WebCore::JSSVGMatrix::multiply):
3431         * svg/SVGMatrix.idl:
3432
3433 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
3434
3435         Reviewed by Timothy Hatcher.
3436
3437         Web Inspector: Make resource-related records in timeline
3438         actually take some time.
3439
3440         https://bugs.webkit.org/show_bug.cgi?id=31139
3441
3442         * English.lproj/localizedStrings.js:
3443         * inspector/front-end/TimelinePanel.js:
3444         (WebInspector.TimelinePanel):
3445         (WebInspector.TimelinePanel.prototype._formatRecord):
3446         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3447         (WebInspector.TimelinePanel.prototype.reset):
3448
3449 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3450
3451         Reviewed by Darin Fisher.
3452
3453         Simplify LocalStorageThread
3454         https://bugs.webkit.org/show_bug.cgi?id=30935
3455
3456         This is a re-submit of 50519.  LocalStorageTask should have never been ref
3457         counted.  I've removed that and switched a PassRefPtr over to a PassOwnPtr.
3458
3459         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
3460         of the method names a bit more clear. Assert proper thread usage. Join rather
3461         than detaching the thread and doing an ad-hoc form of join. Avoid touching
3462         variables on the background thread when simple to do so.  Also create a generic
3463         scheduleTask function rather than one for each task.
3464
3465         No behavior should have changed.
3466
3467         * storage/LocalStorageTask.h:
3468         * storage/LocalStorageThread.cpp:
3469         (WebCore::LocalStorageThread::create):
3470         (WebCore::LocalStorageThread::LocalStorageThread):
3471         (WebCore::LocalStorageThread::~LocalStorageThread):
3472         (WebCore::LocalStorageThread::start):
3473         (WebCore::LocalStorageThread::threadEntryPointCallback):
3474         (WebCore::LocalStorageThread::threadEntryPoint):
3475         (WebCore::LocalStorageThread::scheduleTask):
3476         (WebCore::LocalStorageThread::terminate):
3477         (WebCore::LocalStorageThread::performTerminate):
3478         * storage/LocalStorageThread.h:
3479         * storage/StorageSyncManager.cpp:
3480         (WebCore::StorageSyncManager::StorageSyncManager):
3481         (WebCore::StorageSyncManager::~StorageSyncManager):
3482         (WebCore::StorageSyncManager::scheduleImport):
3483         (WebCore::StorageSyncManager::scheduleSync):
3484         * storage/StorageSyncManager.h:
3485
3486 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3487
3488         Reviewed by Darin Fisher.
3489
3490         Calling databaseIdentifier on LocalStorage's background thread is not safe.
3491         https://bugs.webkit.org/show_bug.cgi?id=31149
3492
3493         Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
3494         is not safe.  databaseIdentifier does a bunch of string concatenation which
3495         ref-counts StringImpls in some cases.  This was caught by valgrind thread
3496         sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645
3497
3498         There's no way to test for such racyness, unfortunately.
3499
3500         * storage/StorageAreaSync.cpp:
3501         (WebCore::StorageAreaSync::StorageAreaSync):
3502         (WebCore::StorageAreaSync::performImport):
3503         * storage/StorageAreaSync.h:
3504         * storage/StorageSyncManager.cpp:
3505         (WebCore::StorageSyncManager::fullDatabaseFilename):
3506         * storage/StorageSyncManager.h:
3507
3508 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
3509
3510         Reviewed by Darin Fisher.
3511
3512         Clean up StorageAreaSync
3513         https://bugs.webkit.org/show_bug.cgi?id=31100
3514
3515         Major fixes: Break the ref count cycle for StorageArea on the main
3516         thread, not the background thread since the latter is not safe.
3517         Length() needs to block on the import completing.
3518
3519         Small fixes: setItem needs to handle the copy on write case even if it
3520         has an exception.  setItem and removeItem should just bail from the
3521         the function if the value hasn't changed rather than wrapping the end
3522         in an if block.  Clear should only send an event if it wasn't already
3523         cleared.  StorageAreaSync should assert that the final sync was
3524         scheduled.
3525
3526         * storage/StorageAreaImpl.cpp:
3527         (WebCore::StorageAreaImpl::length):
3528           Forgot to block on the import.
3529         (WebCore::StorageAreaImpl::key):
3530         (WebCore::StorageAreaImpl::setItem):
3531           Handle the copy on write case even when there's an exception.
3532         (WebCore::StorageAreaImpl::removeItem):
3533         (WebCore::StorageAreaImpl::clear):
3534         * storage/StorageAreaSync.cpp:
3535         (WebCore::StorageAreaSync::~StorageAreaSync):
3536         (WebCore::StorageAreaSync::scheduleFinalSync):
3537         (WebCore::StorageAreaSync::performImport):
3538         (WebCore::StorageAreaSync::markImported):
3539         (WebCore::StorageAreaSync::blockUntilImportComplete):
3540         * storage/StorageAreaSync.h:
3541
3542 2009-11-05  Zoltan Horvath  <zoltan@webkit.org>
3543
3544         Reviewed by Eric Seidel.
3545
3546         Allow custom memory allocation control for WebCore's CachedResource
3547         https://bugs.webkit.org/show_bug.cgi?id=31114
3548
3549         Inherits CachedResource class from Noncopyable because its (its child
3550         class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75
3551         and it is no need to be copyable.
3552
3553         * loader/CachedResource.h:
3554
3555 2009-11-04  Mark Mentovai  <mark@chromium.org>
3556
3557         Reviewed by Mark Rowe.
3558
3559         Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
3560         is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
3561         which is true when targeting 10.6 or later.
3562
3563         HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
3564         is present in the CGInterpolationQuality enum, and must be handled
3565         by a switch that has cases for each enumerated value.
3566
3567         USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
3568         on 10.6 or later, and that CoreGraphics will understand when
3569         InterpolationMedium is mapped to kCGInterpolationMedium at runtime.
3570
3571         * platform/graphics/cg/GraphicsContextCG.cpp:
3572         (WebCore::GraphicsContext::setImageInterpolationQuality):
3573         (WebCore::GraphicsContext::imageInterpolationQuality):
3574
3575 2009-11-04  Dan Kegel  <dank@chromium.org>
3576
3577         Reviewed by Alexey Proskuryakov.
3578
3579         Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
3580         https://bugs.webkit.org/show_bug.cgi?id=31138
3581
3582         Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind
3583
3584         * page/Page.cpp:
3585         (WebCore::Page::userStyleSheetLocationChanged):
3586
3587 2009-11-04  Timothy Hatcher  <timothy@apple.com>
3588
3589         Update the Web Inspector Timeline panel to better match the mock-up.
3590
3591         https://bugs.webkit.org/show_bug.cgi?id=31150
3592
3593         Reviewed by Pavel Feldman.
3594
3595         * inspector/front-end/TimelinePanel.js:
3596         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3597         (WebInspector.TimelinePanel.prototype._dragWindow):
3598         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
3599         (WebInspector.TimelinePanel.prototype._resizeWindowRight):
3600         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
3601         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3602         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
3603         (WebInspector.TimelineCategoryGraph):
3604         * inspector/front-end/inspector.css:
3605
3606 2009-11-05  Justin Garcia  <justin.garcia@apple.com>
3607
3608         Reviewed by Adele Peterson.
3609
3610         https://bugs.webkit.org/show_bug.cgi?id=25439
3611         Deleting when in front of a block image removes character from previous paragraph
3612
3613         Added editing/deleting/25439-{1,2,3}.html
3614
3615         * editing/DeleteSelectionCommand.cpp:
3616         (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot
3617         be made inline with other content.  Instead of merging, just move the caret to just before
3618         the selection we deleted.
3619         * editing/htmlediting.cpp:
3620         (WebCore::firstInSpecialElement): Added a FIXME.  This function begins iterating up from pos.node(), which
3621         doesn't necessarily contain pos (suppose pos was [img, 0]).
3622         (WebCore::lastInSpecialElement): Ditto.
3623         (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp.  Added a check for non-inline images.
3624         * editing/htmlediting.h:
3625         * editing/visible_units.cpp:
3626         (WebCore::startOfParagraph): Use moved/renamed function.  Removed FIXME.  The problem causing
3627         5027702 is now squarely in first/lastInSpecialElement
3628         (WebCore::endOfParagraph): Ditto.
3629
3630 2009-11-04  Enrica Casucci  <enrica@apple.com>
3631
3632         Reviewed by Adele Peterson.
3633
3634         Hang in Mail on attempting to change indent level.
3635         <rdar://problem/7131805>
3636         https://bugs.webkit.org/show_bug.cgi?id=31127
3637
3638         The hang was caused by an infinite loop inside outdentRegion.
3639         The code did not account for the fact that, when a list item
3640         contains multiple paragraphs, outdent moves all paragraphs at
3641         once, invalidating some of the positions we keep track of in the loop.
3642         Some code refactoring has also been done to minimize duplicated code.
3643
3644         Test: editing/execCommand/outdent-multiparagraph-list.html
3645
3646         * editing/IndentOutdentCommand.cpp:
3647         (WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
3648         outdentRegion to doApply.
3649         (WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
3650         (WebCore::IndentOutdentCommand::doApply): Some code refactoring.
3651         * editing/IndentOutdentCommand.h: Added VisiblePosition parameters to
3652         indentRegion and outdentRegion.
3653
3654 2009-11-04  Alpha Lam  <hclam@chromium.org>
3655
3656         Reviewed by Eric Carlson.
3657
3658         Volume slider doesn't have a thumb
3659         https://bugs.webkit.org/show_bug.cgi?id=31135
3660
3661         Fixed an incorrect if statement that prevents volume slider
3662         being updated.
3663
3664         The statement checks if the slider value equals to the current
3665         volume value of the media control to avoid updating the volume
3666         slider. Updating the volume slider control shouldn't be within
3667         this condition because we explicitly set them to be equals
3668         during creation of the controls and also when mouse events are
3669         received on the volume control.
3670
3671         No new tests because existing code breaks:
3672         LayoutTests/media/video-volume-slider.html
3673
3674         It should now start passing on Chromium.
3675
3676         * rendering/MediaControlElements.cpp:
3677         (WebCore::MediaControlVolumeSliderElement::update):
3678         Update the volume slider regardless of the current volume value
3679         of the media control.
3680
3681 2009-11-04  Jenn Braithwaite  <jennb@chromium.org>
3682
3683         Reviewed by David Levin.
3684
3685         Need to properly disable applicationCache at runtime
3686         https://bugs.webkit.org/show_bug.cgi?id=30417
3687
3688         Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.
3689
3690         No new exposed functionality, so no new tests.
3691
3692         * bindings/v8/RuntimeEnabledFeatures.cpp:
3693         * bindings/v8/RuntimeEnabledFeatures.h:
3694         (WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
3695         (WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
3696         * bindings/v8/custom/V8CustomBinding.h:
3697         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3698         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3699         * page/DOMWindow.idl:
3700
3701 2009-11-04  Alexey Proskuryakov  <ap@apple.com>
3702
3703         Reviewed by Dan Bernstein.
3704
3705         https://bugs.webkit.org/show_bug.cgi?id=31143
3706         Assertion failure in CredentialStorage::set() when proxy credentials are being set
3707
3708         No test, cannot test proxy behavior.
3709
3710         * platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the
3711         possibility of null url. Release mode changes are likely inconsequential - e.g. we used to
3712         add "://" to origin set, which is weird, but safe.
3713
3714 2009-11-04  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3715
3716         Reviewed by Timothy Hatcher.
3717
3718         Web Inspector: Leftover Breakpoints in the Sidebar Pane
3719         https://bugs.webkit.org/show_bug.cgi?id=30659
3720
3721         No new tests.
3722
3723         * inspector/front-end/ScriptsPanel.js:
3724         (WebInspector.ScriptsPanel.prototype.addScript):
3725
3726 2009-11-04  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3727
3728         Reviewed by Timothy Hatcher.
3729
3730         WebInspector: Use a different method to identify the webkit port in
3731         InspectorBackent::platform().
3732         This corrects the inspector expected behavior with Qt on Windows.
3733         https://bugs.webkit.org/show_bug.cgi?id=31116
3734
3735         * inspector/InspectorBackend.cpp:
3736         (WebCore::InspectorBackend::platform):
3737         (WebCore::InspectorBackend::port):
3738         * inspector/InspectorBackend.h:
3739         * inspector/InspectorBackend.idl:
3740         * inspector/front-end/InspectorControllerStub.js:
3741         (.WebInspector.InspectorControllerStub.prototype.port):
3742         * inspector/front-end/inspector.css:
3743         * inspector/front-end/inspector.js:
3744         (WebInspector.loaded):
3745         (WebInspector.toolbarDragStart):
3746
3747 2009-11-04  Benjamin Otte  <otte@gnome.org>
3748
3749         Reviewed by Gustavo Noronha.
3750
3751         Update Cairo requirement to 1.6.
3752
3753         Also remove all conditional code and workarounds for older versions of
3754         Cairo.
3755         In particular, gain image quality by removing the use of
3756         CAIRO_FILTER_NEAREST when rendering images and use the default
3757         bilinear filter instead.
3758         https://bugs.webkit.org/show_bug.cgi?id=19266
3759
3760         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3761         (WebCore::GraphicsContext::clipOut):
3762         * platform/graphics/cairo/ImageCairo.cpp:
3763         (WebCore::BitmapImage::draw):
3764         (WebCore::BitmapImage::drawPattern):
3765         * platform/graphics/cairo/PathCairo.cpp:
3766         (WebCore::Path::isEmpty):
3767         (WebCore::Path::boundingRect):
3768         * platform/gtk/RenderThemeGtk.cpp:
3769         (WebCore::paintMozWidget):
3770
3771 2009-11-04  Kevin Ollivier  <kevino@theolliviers.com>
3772
3773         wx build fix. Restore removed string conversion after cleanup.
3774
3775         * platform/graphics/wx/FontPlatformDataWx.cpp:
3776         (WebCore::FontPlatformData::computeHash):
3777
3778 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3779
3780         Reviewed by Beth Dakin.
3781
3782         Need to implement ARIA role="combobox"
3783         https://bugs.webkit.org/show_bug.cgi?id=31096
3784
3785         Test: accessibility/aria-combobox.html
3786
3787         * accessibility/AccessibilityObject.h:
3788         (WebCore::AccessibilityObject::isComboBox):
3789         (WebCore::AccessibilityObject::isExpanded):
3790         (WebCore::AccessibilityObject::expandObject):
3791         (WebCore::AccessibilityObject::increment):
3792         (WebCore::AccessibilityObject::decrement):
3793         * accessibility/AccessibilityRenderObject.cpp:
3794         (WebCore::AccessibilityRenderObject::expandObject):
3795         (WebCore::AccessibilityRenderObject::isExpanded):
3796         (WebCore::createARIARoleMap):
3797         * accessibility/AccessibilityRenderObject.h:
3798         * accessibility/mac/AccessibilityObjectWrapper.mm:
3799         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
3800         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
3801         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
3802         * html/HTMLAttributeNames.in:
3803
3804 2009-11-04  Kelly Norton  <knorton@google.com>
3805
3806         Reviewed by Pavel Feldman.
3807
3808         Fixes naming inconsistencies in TimelineRecordFactory.
3809         https://bugs.webkit.org/show_bug.cgi?id=31132
3810
3811         * inspector/InspectorTimelineAgent.cpp:
3812         (WebCore::InspectorTimelineAgent::willPaint):
3813         (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
3814         (WebCore::InspectorTimelineAgent::willLoadXHR):
3815         (WebCore::InspectorTimelineAgent::willEvaluateScript):
3816         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
3817         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
3818         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
3819         * inspector/TimelineRecordFactory.cpp:
3820         (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord):
3821         (WebCore::TimelineRecordFactory::createXHRLoadRecord):
3822         (WebCore::TimelineRecordFactory::createEvaluateScriptRecord):
3823         (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
3824         (WebCore::TimelineRecordFactory::createResourceSendRequestRecord):
3825         (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord):
3826         (WebCore::TimelineRecordFactory::createResourceFinishRecord):
3827         (WebCore::TimelineRecordFactory::createPaintRecord):
3828         * inspector/TimelineRecordFactory.h:
3829
3830 2009-11-04  Eric Z. Ayers  <zundel@google.com>
3831
3832         Reviewed by Pavel Feldman.
3833
3834         Followon to bug 31080, which protects Timeline
3835         instrumentation in the case where InspectorTimelineAgent
3836         is enabled or disabled during an event dispatch.
3837
3838         https://bugs.webkit.org/show_bug.cgi?id=31121
3839
3840         * bindings/v8/V8Proxy.cpp:
3841         (WebCore::V8Proxy::evaluate):
3842         * dom/Document.cpp:
3843         (WebCore::Document::recalcStyle):
3844         * dom/Node.cpp:
3845         (WebCore::Node::dispatchGenericEvent):
3846         * html/HTMLTokenizer.cpp:
3847         (WebCore::HTMLTokenizer::write):
3848         * page/DOMWindow.cpp:
3849         (WebCore::DOMWindow::inspectorTimelineAgent):
3850         (WebCore::DOMWindow::dispatchEvent):
3851         * page/DOMWindow.h:
3852         * page/FrameView.cpp:
3853         (WebCore::FrameView::layout):
3854         (WebCore::FrameView::paintContents):
3855         * xml/XMLHttpRequest.cpp:
3856         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
3857
3858 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3859
3860         Revert 50519 while I work out what went wrong.
3861
3862         * storage/LocalStorageThread.cpp:
3863         (WebCore::LocalStorageThread::create):
3864         (WebCore::LocalStorageThread::LocalStorageThread):
3865         (WebCore::LocalStorageThread::start):
3866         (WebCore::LocalStorageThread::localStorageThreadStart):
3867         (WebCore::LocalStorageThread::localStorageThread):
3868         (WebCore::LocalStorageThread::scheduleImport):
3869         (WebCore::LocalStorageThread::scheduleSync):
3870         (WebCore::LocalStorageThread::terminate):
3871         (WebCore::LocalStorageThread::performTerminate):
3872         * storage/LocalStorageThread.h:
3873         * storage/StorageSyncManager.cpp:
3874         (WebCore::StorageSyncManager::StorageSyncManager):
3875         (WebCore::StorageSyncManager::~StorageSyncManager):
3876         (WebCore::StorageSyncManager::scheduleImport):
3877         (WebCore::StorageSyncManager::scheduleSync):
3878         * storage/StorageSyncManager.h:
3879
3880 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
3881
3882         Reviewed by Timothy Hatcher.
3883
3884         Web Inspector: Add basic support for resource events and marks.
3885         Couple of drive-by fixes. Enabling the panel!
3886
3887         https://bugs.webkit.org/show_bug.cgi?id=31130
3888
3889         * English.lproj/localizedStrings.js:
3890         * inspector/front-end/TimelinePanel.js:
3891         (WebInspector.TimelinePanel):
3892         (WebInspector.TimelinePanel.prototype._formatRecord):
3893         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3894         (WebInspector.TimelinePanel.prototype.reset):
3895         (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked):
3896         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3897         * inspector/front-end/inspector.js:
3898         (WebInspector._createPanels):
3899
3900 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
3901
3902         Reviewed by Darin Fisher.
3903
3904         Simplify LocalStorageThread
3905         https://bugs.webkit.org/show_bug.cgi?id=30935
3906
3907         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
3908         of the method names a bit more clear. Assert proper thread usage. Join rather
3909         than detaching the thread and doing an ad-hoc form of join. Avoid touching
3910         variables on the background thread when simple to do so.  Also create a generic
3911         scheduleTask function rather than one for each task.
3912
3913         No behavior should have changed.
3914
3915         * storage/LocalStorageThread.cpp:
3916         (WebCore::LocalStorageThread::create):
3917         (WebCore::LocalStorageThread::LocalStorageThread):
3918         (WebCore::LocalStorageThread::~LocalStorageThread):
3919         (WebCore::LocalStorageThread::start):
3920         (WebCore::LocalStorageThread::threadEntryPointCallback):
3921         (WebCore::LocalStorageThread::threadEntryPoint):
3922         (WebCore::LocalStorageThread::scheduleTask):
3923         (WebCore::LocalStorageThread::terminate):
3924         (WebCore::LocalStorageThread::performTerminate):
3925         * storage/LocalStorageThread.h:
3926         * storage/StorageSyncManager.cpp:
3927         (WebCore::StorageSyncManager::StorageSyncManager):
3928         (WebCore::StorageSyncManager::~StorageSyncManager):
3929         (WebCore::StorageSyncManager::scheduleImport):
3930         (WebCore::StorageSyncManager::scheduleSync):
3931         * storage/StorageSyncManager.h:
3932
3933 2009-11-04  Vadim Zeitlin  <vadim@wxwidgets.org>
3934
3935         Reviewed by Eric Seidel.
3936
3937         [wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.
3938
3939         * platform/graphics/wx/FontPlatformDataWx.cpp:
3940         (WebCore::FontPlatformData::computeHash):
3941
3942 2009-11-04  Kelly Norton  <knorton@google.com>
3943
3944         Reviewed by Pavel Feldman.
3945
3946         Adds lightweight network resources to InspectorTimelineAgent.
3947         https://bugs.webkit.org/show_bug.cgi?id=31065
3948
3949         * inspector/InspectorController.cpp:
3950         (WebCore::InspectorController::willSendRequest):
3951         (WebCore::InspectorController::didReceiveResponse):
3952         (WebCore::InspectorController::didFinishLoading):
3953         (WebCore::InspectorController::didFailLoading):
3954         * inspector/InspectorTimelineAgent.cpp:
3955         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
3956         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
3957         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
3958         * inspector/InspectorTimelineAgent.h:
3959         (WebCore::):
3960         * inspector/TimelineRecordFactory.cpp:
3961         (WebCore::TimelineRecordFactory::createResourceSendRequestTimelineRecord):
3962         (WebCore::TimelineRecordFactory::createResourceReceiveResponseTimelineRecord):
3963         (WebCore::TimelineRecordFactory::createResourceFinishTimelineRecord):
3964         * inspector/TimelineRecordFactory.h:
3965         * inspector/front-end/TimelineAgent.js:
3966
3967 2009-11-04  Yael Aharon  <yael.aharon@nokia.com>
3968
3969         Reviewed by Tor Arne Vestbø.
3970
3971         [Qt] ASSERT failure when receiving 401 HTTP Authentication response.
3972         https://bugs.webkit.org/show_bug.cgi?id=31077
3973
3974         Allow sending the response body under the same conditions that we
3975         allow it to finish without reporting an error.
3976
3977         * platform/network/qt/QNetworkReplyHandler.cpp:
3978         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
3979
3980 2009-11-04  Adam Roben  <aroben@apple.com>
3981
3982         Sort WebCore.base.exp
3983
3984         Rubber-stamped by Dan Bernstein.
3985
3986         * WebCore.base.exp: Sorted.
3987
3988 2009-11-04  Csaba Osztrogonác  <ossy@webkit.org>
3989
3990         Unreviewed rollout.
3991
3992         Revert r50496 because it broke all layout tests on QtBuildBot.
3993
3994         * WebCore.pro:
3995         * platform/graphics/qt/FontCacheQt.cpp:
3996         (WebCore::fontCache):
3997         (WebCore::FontCache::FontCache):
3998         (WebCore::FontCache::getTraitsInFamily):
3999         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
4000         (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
4001         (WebCore::FontPlatformDataCacheKey::):
4002         (WebCore::FontPlatformDataCacheKey::operator==):
4003         (WebCore::FontPlatformDataCacheKey::hash):
4004         (WebCore::FontPlatformDataCacheKey::computeHash):
4005         (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
4006         (WebCore::FontPlatformDataCacheKeyHash::hash):
4007         (WebCore::FontPlatformDataCacheKeyHash::equal):
4008         (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
4009         (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
4010         (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
4011         (WebCore::FontCache::getCachedFontPlatformData):
4012         (WebCore::FontCache::getCachedFontData):
4013         (WebCore::FontCache::getLastResortFallbackFont):
4014         (WebCore::FontCache::releaseFontData):
4015         (WebCore::FontCache::purgeInactiveFontData):
4016         (WebCore::FontCache::addClient):
4017         (WebCore::FontCache::removeClient):
4018         (WebCore::FontCache::invalidate):
4019         * platform/graphics/qt/FontFallbackListQt.cpp: Added.
4020         (WebCore::FontFallbackList::FontFallbackList):
4021         (WebCore::FontFallbackList::invalidate):
4022         (WebCore::FontFallbackList::releaseFontData):
4023         (WebCore::FontFallbackList::determinePitch):
4024         (WebCore::FontFallbackList::fontDataAt):
4025         (WebCore::FontFallbackList::fontDataForCharacters):
4026         (WebCore::FontFallbackList::setPlatformFont):
4027         * platform/graphics/qt/FontPlatformData.h:
4028         (WebCore::FontPlatformData::pixelSize):
4029         * platform/graphics/qt/FontPlatformDataQt.cpp:
4030         (WebCore::FontPlatformData::FontPlatformData):
4031
4032 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
4033
4034         Reviewed by Jan Alonzo.
4035
4036         https://bugs.webkit.org/show_bug.cgi?id=31044
4037         [Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view
4038
4039         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
4040         (atkParentOfWebView):
4041         (webkit_accessible_get_index_in_parent):
4042         (webkit_accessible_get_parent):
4043
4044 2009-11-04  Dominik Röttsches  <dominik.roettsches@access-company.com>
4045
4046         Reviewed by Eric Seidel.
4047
4048         https://bugs.webkit.org/show_bug.cgi?id=15914
4049         [GTK] Implement Unicode functionality using GLib
4050
4051         Initial version of this patch by Jürg Billeter and Naiem Shaik.
4052         Patch 2/4 - Moving TextCodecs to GLib
4053
4054         Added probing for a hard-coded lists of text encodings.
4055         The basis of this list is taken from the encodings supported by iconv,
4056         then extended by e.g. tis-620, windows-1251, euc-kr, windows-1253 and
4057         a number of Chinese ones.
4058
4059         Probing is necessary with the current design of text codecs
4060         as iconv/GLib do not support enumerating available encodings.
4061
4062         * GNUmakefile.am:
4063         * platform/ThreadGlobalData.cpp:
4064         (WebCore::ThreadGlobalData::ThreadGlobalData):
4065         (WebCore::ThreadGlobalData::~ThreadGlobalData):
4066         * platform/text/TextEncoding.cpp:
4067         (WebCore::TextEncoding::encode):
4068         * platform/text/TextEncodingRegistry.cpp:
4069         (WebCore::buildBaseTextCodecMaps):
4070         (WebCore::extendTextCodecMaps):
4071         * platform/text/gtk/TextCodecGtk.cpp: Added.
4072         (WebCore::):
4073         (WebCore::newTextCodecGtk):
4074         (WebCore::TextCodecGtk::isEncodingAvailable):
4075         (WebCore::TextCodecGtk::registerEncodingNames):
4076         (WebCore::TextCodecGtk::registerCodecs):
4077         (WebCore::TextCodecGtk::registerBaseEncodingNames):
4078         (WebCore::TextCodecGtk::registerBaseCodecs):
4079         (WebCore::TextCodecGtk::registerExtendedEncodingNames):
4080         (WebCore::TextCodecGtk::registerExtendedCodecs):
4081         (WebCore::TextCodecGtk::TextCodecGtk):
4082         (WebCore::TextCodecGtk::~TextCodecGtk):
4083         (WebCore::TextCodecGtk::releaseIConv):
4084         (WebCore::TextCodecGtk::createIConvDecoder):
4085         (WebCore::TextCodecGtk::createIConvEncoder):
4086         (WebCore::TextCodecGtk::decode):
4087         (WebCore::TextCodecGtk::encode):
4088         * platform/text/gtk/TextCodecGtk.h: Added.
4089
4090 2009-11-04  Martin Robinson  <martin.james.robinson@gmail.com>
4091
4092         Reviewed by Jan Alonzo.
4093
4094         [GTK] Enable DOM clipboard and drag-and-drop access
4095         https://bugs.webkit.org/show_bug.cgi?id=30623
4096
4097         Unify redudant methods which will always return the same value.
4098
4099         * platform/gtk/PasteboardGtk.cpp:
4100         (WebCore::Pasteboard::writeSelection):
4101         * platform/gtk/PasteboardHelper.h:
4102
4103 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
4104
4105         Reviewed by Jan Alonzo.
4106
4107         https://bugs.webkit.org/show_bug.cgi?id=31035
4108         [GTK] some accessibility tests hitting assertion in debug builds
4109
4110         Removes the assertions in webkit_accessible_ref_child; adds sanity checks.
4111         Any app or AT can attempt to ref a child at a bogus index.
4112
4113         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
4114         (webkit_accessible_ref_child):
4115
4116 2009-11-04  Benjamin Otte  <otte@gnome.org>
4117
4118         Reviewed by Jan Alonzo.
4119
4120         [gtk] Use gst_element_class_set_details_simple()
4121
4122         Cosmetic change, just code simplification
4123
4124         * platform/graphics/gtk/VideoSinkGStreamer.cpp:
4125         (webkit_video_sink_base_init):
4126 2009-11-04  Kelly Norton  <knorton@google.com>
4127
4128         Reviewed by Timothy Hatcher.
4129
4130         Adds paint rectangle information to TimelineAgent's didPaint callback.
4131         https://bugs.webkit.org/show_bug.cgi?id=31087
4132
4133         * inspector/InspectorTimelineAgent.cpp:
4134         (WebCore::InspectorTimelineAgent::willPaint):
4135         * inspector/InspectorTimelineAgent.h:
4136         * inspector/TimelineRecordFactory.cpp:
4137         (WebCore::TimelineRecordFactory::createPaintTimelineRecord):
4138         * inspector/TimelineRecordFactory.h:
4139         * page/FrameView.cpp:
4140         (WebCore::FrameView::paintContents):
4141
4142 2009-11-04  Jaime Yap  <jaimeyap@google.com>
4143
4144         Reviewed by Timothy Hatcher.
4145
4146         This patch adds API to the console object for annotating the
4147         inspector timeline. This allows developers to mark logical
4148         checkpoints in their apps and have them overlaid in the event
4149         record tree.
4150
4151         tests updated: LayoutTests/fast/dom/Window/window-properties.html
4152         https://bugs.webkit.org/show_bug.cgi?id=31082
4153
4154
4155         * inspector/InspectorController.cpp:
4156         (WebCore::InspectorController::markTimeline):
4157         * inspector/InspectorController.h:
4158         * inspector/InspectorTimelineAgent.cpp:
4159         (WebCore::InspectorTimelineAgent::didMarkTimeline):
4160         * inspector/InspectorTimelineAgent.h:
4161         (WebCore::):
4162         * inspector/TimelineRecordFactory.cpp:
4163         (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
4164         * inspector/TimelineRecordFactory.h:
4165         * inspector/front-end/TimelineAgent.js:
4166         * page/Console.cpp:
4167         (WebCore::Console::markTimeline):
4168         * page/Console.h:
4169         * page/Console.idl:
4170
4171 2009-11-03  Simon Hausmann  <hausmann@webkit.org>
4172
4173         Unreviewed build fix for WebInspector with Qt build.
4174
4175         Simply re-generate the Qt resource file by running
4176         WebKitTools/Scripts/generate-qt-inspector-resource
4177
4178         * inspector/front-end/WebKit.qrc:
4179
4180 2009-11-02  Benjamin Poulain  <benjamin.poulain@nokia.com>
4181
4182         Reviewed by Simon Hausmann.
4183
4184         [Qt] Handle fonts like the other ports
4185
4186         Remove FontFallbackListQt and rely on the common FontFallbackList
4187         to handle the fonts. FontCache and FontPlatformData have been
4188         updated to work with the common FontFallbackList.
4189
4190         In the previous implementation, FontPlatformDataCacheKey
4191         was a clone of FontPlatformData with the hashing
4192         capabilities added in order to use it as a key in the cache's
4193         hashmap. FontPlatformData has been modified to handle the hashing
4194         function directly so the data are not copied twice in memory.
4195
4196         FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
4197         code from FontCache::getFontData() and FontFallbackList::fontDataAt().
4198         The behavior is similar except currFamily->family().length() was
4199         not tested and the fallback fonts selector were not used.
4200
4201         https://bugs.webkit.org/show_bug.cgi?id=29856
4202
4203         Test: svg/text/text-font-invalid.html
4204
4205         * WebCore.pro:
4206         * platform/graphics/qt/FontCacheQt.cpp:
4207         (WebCore::FontCache::platformInit):
4208         (WebCore::FontCache::getFontDataForCharacters):
4209         (WebCore::FontCache::getSimilarFontPlatformData):
4210         (WebCore::FontCache::getLastResortFallbackFont):
4211         (WebCore::FontCache::getTraitsInFamily):
4212         (WebCore::FontCache::createFontPlatformData):
4213         * platform/graphics/qt/FontFallbackListQt.cpp:
4214         Removed. We now use the implementation from FontFallbackList.cpp
4215         * platform/graphics/qt/FontPlatformData.h:
4216         Add hashing capabilities to be able to use the data with the FontCache.
4217         This was previously done in FontCacheQt.cpp
4218         (WebCore::FontPlatformData::FontPlatformData):
4219         Added a boolean to identify deleted value in the hash table.
4220         (WebCore::FontPlatformData::isHashTableDeletedValue):
4221         (WebCore::FontPlatformData::hash):
4222         (WebCore::FontPlatformData::operator==):
4223         * platform/graphics/qt/FontPlatformDataQt.cpp:
4224         (WebCore::FontPlatformData::FontPlatformData):
4225
4226 2009-11-03  Dan Bernstein  <mitz@apple.com>
4227
4228         Leopard build fix
4229
4230         * platform/network/mac/AuthenticationMac.mm:
4231         (WebCore::mac):
4232         (WebCore::core):
4233
4234 2009-11-03  Dan Bernstein  <mitz@apple.com>
4235
4236         Reviewed by Alexey Proskuryakov.
4237
4238         Fix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
4239         authentication in AuthenticationMac
4240
4241         * platform/network/mac/AuthenticationMac.mm:
4242
4243 2009-11-03  Eric Z. Ayers  <zundel@google.com>
4244
4245         Reviewed by Timothy Hatcher.
4246
4247         Fixes a problem where the timeline instrumentation crashes if
4248         timeline profiling is enabled or disabled in the middle of an
4249         event dispatch.
4250
4251         https://bugs.webkit.org/show_bug.cgi?id=31080
4252
4253         Test: inspector/timeline-trivial.html
4254
4255         * bindings/js/ScriptController.cpp:
4256         (WebCore::ScriptController::evaluateInWorld):
4257         (WebCore::ScriptController::processingUserGestureEvent):
4258         * inspector/InspectorTimelineAgent.cpp:
4259         (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
4260         * page/DOMTimer.cpp:
4261         (WebCore::DOMTimer::fired):
4262
4263 2009-11-03  Dan Bernstein  <mitz@apple.com>
4264
4265         Reviewed by Dave Hyatt.
4266
4267         Allow a frame to go back to copy-on-scroll when it ceases being overlapped
4268
4269         The code was not testing slow-scrolling frames for overlappedness, thinking the answer
4270         would not matter. That is not the case if the only reason for the slow-scrolling is
4271         being overlapped.
4272
4273         * page/FrameView.cpp:
4274         (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): Added. Returns whether there is any
4275         reason besides being overlapped that the frame would need to fully repaint on scroll.
4276         * page/FrameView.h:
4277         * rendering/RenderWidget.cpp:
4278         (WebCore::RenderWidget::paint): Use useSlowRepaintsIfNotOverlapped().
4279
4280 2009-11-03  Dmitry Titov  <dimich@chromium.org>
4281
4282         Not reviewed, Qt build fix.
4283
4284         Need to use right capitalization for include file.
4285
4286         * page/Navigator.cpp:
4287
4288 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
4289
4290         Reviewed by Timothy Hatcher.
4291
4292         Web Inspector: Migrate from top bar filters to check boxes in Timeline.
4293
4294         https://bugs.webkit.org/show_bug.cgi?id=31081
4295
4296         * inspector/front-end/AbstractTimelinePanel.js:
4297         (WebInspector.AbstractTimelinePanel.prototype.showCategory):
4298         (WebInspector.AbstractTimelinePanel.prototype.hideCategory):
4299         (WebInspector.AbstractTimelinePanel.prototype.filter):
4300         * inspector/front-end/TimelinePanel.js: