WebCore/ChangeLog

   1 2006-09-26  Geoffrey Garen <ggaren@apple.com>
   2
   3         Reviewed by Darin.
   4
   5         Temporary work-around for frame lifetime issue.
   6
   7         * page/Frame.cpp:
   8         (WebCore::Frame::clear):
   9         (WebCore::Frame::disconnectOwnerElement):
  10
  11 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
  12
  13         Reviewed by Tim H.
  14
  15         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11038
  16         Auto-generate DOMSVGElement for the Objective-C bindings
  17
  18         - Auto-generates DOMSVGElement.
  19
  20         - Make SVGExceptions work like all the other ExceptionCode
  21           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
  22           and SVGExceptionMax.
  23
  24         * DerivedSources.make:
  25         * WebCore.xcodeproj/project.pbxproj:
  26         * bindings/js/kjs_binding.cpp:
  27         (KJS::):
  28         (KJS::setDOMException):
  29         * bindings/objc/DOMInternal.h:
  30         * bindings/objc/DOMInternal.mm:
  31         (raiseDOMException):
  32         * bindings/objc/DOMSVG.h:
  33         * bindings/objc/DOMSVGExecption.h: Added.
  34         * ksvg2/ksvg.h:
  35         * ksvg2/svg/SVGElement.cpp:
  36         (WebCore::SVGElement::setId):
  37         (WebCore::SVGElement::setXmlbase):
  38         * ksvg2/svg/SVGElement.h:
  39         * ksvg2/svg/SVGElement.idl:
  40         * ksvg2/svg/SVGException.h: Added.
  41         (WebCore::):
  42
  43 2006-09-26  Eric Seidel  <eric@eseidel.com>
  44
  45         Reviewed by Tim H.
  46
  47         viewbox parser does not allow <tab> as a delimiter
  48         http://bugzilla.opendarwin.org/show_bug.cgi?id=11014
  49
  50         Test: svg/hixie/viewbox/003.xml
  51
  52         * ksvg2/svg/svgpathparser.cpp:
  53         (WebCore::isWhitespace): new function
  54         (WebCore::skipOptionalSpaces):
  55         (WebCore::skipOptionalSpacesOrComma):
  56
  57 2006-09-26  Eric Seidel  <eric@eseidel.com>
  58
  59         Reviewed by Tim H.
  60
  61         SVGDocument::createElement does not create elements in the SVG namespace
  62         http://bugzilla.opendarwin.org/show_bug.cgi?id=10932
  63
  64         Test: svg/custom/createelement.svg
  65
  66         * ksvg2/svg/SVGDocument.cpp:
  67         (WebCore::SVGDocument::createElement):
  68         * ksvg2/svg/SVGDocument.h:
  69
  70 2006-09-26  Eric Seidel  <eric@eseidel.com>
  71
  72         Reviewed by Tim H.
  73
  74         RenderPath::nodeAtPoint does not respect stroke width
  75         http://bugzilla.opendarwin.org/show_bug.cgi?id=10829
  76
  77         Test: svg/custom/stroke-width-click.svg
  78
  79         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
  80         (WebCore::RenderPath::strokeContains):
  81         * kcanvas/device/quartz/QuartzSupport.h:
  82         * kcanvas/device/quartz/QuartzSupport.mm:
  83
  84 2006-09-26  Eric Seidel  <eric@eseidel.com>
  85
  86         Reviewed by mitz.
  87
  88         Bring animation back to life
  89         http://bugzilla.opendarwin.org/show_bug.cgi?id=11021
  90
  91         Register/unregister SVGSVGElements as time containers on insertion/removal.
  92         Replace uses of DeprecatedString with String in SVGAnimationElement
  93         Various whitespace clean-up.
  94
  95         * ksvg2/misc/KSVGTimeScheduler.cpp:
  96         (WebCore::SVGTimer::notifyAll):
  97         * ksvg2/misc/SVGDocumentExtensions.cpp:
  98         (WebCore::SVGDocumentExtensions::startAnimations):
  99         (WebCore::SVGDocumentExtensions::pauseAnimations):
 100         (WebCore::SVGDocumentExtensions::unpauseAnimations):
 101         * ksvg2/svg/SVGAnimateTransformElement.cpp:
 102         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
 103         (WebCore::SVGAnimateTransformElement::parseTransformValue):
 104         * ksvg2/svg/SVGAnimateTransformElement.h:
 105         * ksvg2/svg/SVGAnimationElement.cpp:
 106         (WebCore::SVGAnimationElement::SVGAnimationElement):
 107         (WebCore::SVGAnimationElement::parseMappedAttribute):
 108         (WebCore::SVGAnimationElement::parseClockValue):
 109         (WebCore::SVGAnimationElement::targetAttribute):
 110         (WebCore::SVGAnimationElement::setTargetAttribute):
 111         (WebCore::SVGAnimationElement::attributeName):
 112         * ksvg2/svg/SVGAnimationElement.h:
 113         (WebCore::SVGAnimationElement::rendererIsNeeded):
 114         * ksvg2/svg/SVGSVGElement.cpp:
 115         (WebCore::SVGSVGElement::getScreenCTM):
 116         (WebCore::SVGSVGElement::createRenderer):
 117         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
 118         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
 119         * ksvg2/svg/SVGSVGElement.h:
 120         * ksvg2/svg/SVGSetElement.cpp:
 121         (WebCore::SVGSetElement::handleTimerEvent):
 122         * ksvg2/svg/SVGURIReference.cpp:
 123         (WebCore::SVGURIReference::getTarget):
 124         * ksvg2/svg/SVGURIReference.h:
 125
 126 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
 127
 128         Reviewed by mitzpettel.
 129
 130         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=11020
 131         No-SVG build broken since r16549
 132
 133         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
 134
 135         * css/cssparser.cpp:
 136         (WebCore::CSSParser::parseValue):
 137         * css/cssstyleselector.cpp:
 138         (WebCore::CSSStyleSelector::applyProperty):
 139         * page/FrameView.cpp:
 140         (WebCore::selectCursor):
 141         * platform/qt/GraphicsContextQt.cpp:
 142
 143 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
 144
 145         Reviewed by Maciej.
 146
 147         http://bugzilla.opendarwin.org/show_bug.cgi?id=10820
 148         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
 149
 150         (Originally written by Eric Seidel).
 151
 152         * bindings/js/kjs_window.cpp:
 153         (KJS::floatFeature):
 154         * ksvg2/svg/SVGAngle.cpp:
 155         (SVGAngle::setValueAsString):
 156         * ksvg2/svg/SVGAnimationElement.cpp:
 157         (SVGAnimationElement::parseMappedAttribute):
 158         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
 159         (SVGComponentTransferFunctionElement::parseMappedAttribute):
 160         * ksvg2/svg/SVGFECompositeElement.cpp:
 161         (WebCore::SVGFECompositeElement::parseMappedAttribute):
 162         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
 163         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
 164         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
 165         (SVGFEDisplacementMapElement::parseMappedAttribute):
 166         * ksvg2/svg/SVGFELightElement.cpp:
 167         (SVGFELightElement::parseMappedAttribute):
 168         * ksvg2/svg/SVGFEOffsetElement.cpp:
 169         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
 170         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
 171         (SVGFESpecularLightingElement::parseMappedAttribute):
 172         * ksvg2/svg/SVGFETurbulenceElement.cpp:
 173         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
 174         * ksvg2/svg/SVGStopElement.cpp:
 175         (SVGStopElement::parseMappedAttribute):
 176         * platform/AtomicString.h:
 177         (WebCore::AtomicString::toDouble):
 178         * platform/PlatformString.h:
 179         * platform/String.cpp:
 180         (WebCore::String::toDouble):
 181         * platform/StringImpl.cpp:
 182         (WebCore::StringImpl::toDouble):
 183         * platform/StringImpl.h:
 184         * rendering/DeprecatedSlider.cpp:
 185         (WebCore::DeprecatedSlider::updateFromElement):
 186         * xml/XPathGrammar.y:
 187
 188 2006-09-25  David Harrison  <harrison@apple.com>
 189
 190         Reviewed by Tim Omernick and Tim Hatcher.
 191
 192         <rdar://problem/4717965> Text Field text parameterized attributes should work
 193         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
 194
 195         * bridge/mac/WebCoreAXObject.mm:
 196         (-[WebCoreAXObject accessibilityAttributeValue:]):
 197         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
 198
 199         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
 200         Cleaned up. Added text field and text area parameterzed attributes.
 201
 202         (-[WebCoreAXObject doAXLineForTextMarker:]):
 203         Fixed to be zero-based and to deal with the first position properly.
 204
 205         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
 206         Minor formatting.
 207
 208         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
 209         (-[WebCoreAXObject indexForTextMarker:]):
 210         (-[WebCoreAXObject textMarkerRangeForRange:]):
 211         (-[WebCoreAXObject rangeForTextMarkerRange:]):
 212         New utility methods.
 213
 214         (-[WebCoreAXObject doAXLineForIndex:]):
 215         (-[WebCoreAXObject doAXRangeForLine:]):
 216         (-[WebCoreAXObject doAXStringForRange:]):
 217         (-[WebCoreAXObject doAXRangeForPosition:]):
 218         (-[WebCoreAXObject doAXRangeForIndex:]):
 219         (-[WebCoreAXObject doAXBoundsForRange:]):
 220         (-[WebCoreAXObject doAXAttributedStringForRange:]):
 221         (-[WebCoreAXObject doAXRTFForRange:]):
 222         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
 223         Implement text field and text area parameterized attributes.
 224
 225         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
 226         Added text field and text area parameterzed attributes.
 227
 228         * rendering/RenderTextControl.h:
 229         Made indexForVisiblePosition() and visiblePositionForIndex() public.
 230
 231 2006-09-25  Adam Roben  <aroben@apple.com>
 232
 233         Reviewed by Brady.
 234
 235         Build fixes.
 236
 237         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
 238         * platform/ResourceLoader.h: Store whether a particular job
 239         has received a response within the ResourceLoader object itself, since
 240         it's possible that we will enter the InternetReadFileExA while loop
 241         twice for the same job.
 242         * platform/ResourceLoaderInternal.h: Add private instance variable to
 243         store whether we've received a response.
 244         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
 245         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
 246         directives.
 247         * platform/win/ResourceLoaderWin.cpp:
 248         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
 249         whether it has received a response instead of assuming it hasn't.
 250         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
 251         (WebCore::ResourceLoader::hasReceivedResponse): Added.
 252         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
 253         setProportion
 254         (ScrollBar::setProportion):
 255
 256 2006-09-25  Brady Eidson  <beidson@apple.com>
 257
 258         Requested by ggaren
 259
 260         Disabled IconDatabase logging by default
 261
 262         * platform/Logging.cpp:
 263         (WebCore::):
 264
 265 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
 266
 267         Build fix
 268
 269         * platform/cf/ResourceLoaderCFNet.cpp:
 270         (WebCore::willCacheResponse):
 271
 272 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
 273
 274         Reviewed by john
 275
 276         <http://bugzilla.opendarwin.org/show_bug.cgi?id=11002>
 277         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
 278
 279         * editing/IndentOutdentCommand.cpp:
 280         (WebCore::IndentOutdentCommand::indentRegion): Special case
 281         an empty root editable element.
 282
 283 2006-09-25  Brady Eidson  <beidson@apple.com>
 284
 285         Reviewed by Steve
 286
 287         Math error in SystemTimeWin
 288
 289         * platform/win/SystemTimeWin.cpp:
 290         (WebCore::currentTime):
 291
 292 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
 293
 294         Reviewed by Eric.
 295
 296         Whitespace cleanup; rename *job variables to *loader.
 297
 298         * bindings/js/JSXMLHttpRequest.cpp:
 299         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
 300         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
 301         (KJS::JSXMLHttpRequestConstructorImp::construct):
 302         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
 303         (KJS::JSXMLHttpRequest::getValueProperty):
 304         (KJS::JSXMLHttpRequest::put):
 305         (KJS::JSXMLHttpRequest::putValueProperty):
 306         (KJS::JSXMLHttpRequest::mark):
 307         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
 308         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
 309         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
 310         * bindings/js/JSXMLHttpRequest.h:
 311         (KJS::JSXMLHttpRequest::toBoolean):
 312         * xml/xmlhttprequest.cpp:
 313         (WebCore::XMLHttpRequest::XMLHttpRequest):
 314         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
 315         (WebCore::XMLHttpRequest::send):
 316         (WebCore::XMLHttpRequest::abort):
 317         (WebCore::XMLHttpRequest::receivedAllData):
 318         (WebCore::XMLHttpRequest::receivedData):
 319         * xml/xmlhttprequest.h:
 320         (WebCore::):
 321
 322 2006-09-25  Timothy Hatcher  <timothy@apple.com>
 323
 324         Reviewed by Brady.
 325
 326         - Deprecate the rest of the old-style methods that are not generated.
 327         - Add @property syntax to DOMRange.
 328
 329         * WebCore.xcodeproj/project.pbxproj:
 330         * bindings/objc/DOM.mm:
 331         (-[DOMRange setStart:offset:]):
 332         (-[DOMRange setEnd:offset:]):
 333         (-[DOMRange compareBoundaryPoints:sourceRange:]):
 334         (-[DOMRange setStart::]):
 335         (-[DOMRange setEnd::]):
 336         (-[DOMRange compareBoundaryPoints::]):
 337         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
 338         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
 339         (-[DOMDocument createNodeIterator::::]):
 340         (-[DOMDocument createTreeWalker::::]):
 341         * bindings/objc/DOMCSS.h:
 342         * bindings/objc/DOMCSS.mm:
 343         (-[DOMDocument getComputedStyle:pseudoElement:]):
 344         (-[DOMDocument getComputedStyle::]):
 345         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
 346         * bindings/objc/DOMExtensions.h:
 347         * bindings/objc/DOMHTML.h:
 348         * bindings/objc/DOMRange.h:
 349         * bindings/objc/DOMTraversal.h:
 350
 351 2006-09-25  Eric Seidel  <eric@eseidel.com>
 352
 353         Reviewed by mjs.
 354
 355         Outermost <svg> element should clip to viewport
 356         http://bugzilla.opendarwin.org/show_bug.cgi?id=11007
 357
 358         Test: svg/custom/viewport-clip.svg
 359
 360         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
 361
 362 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
 363
 364         Reviewed by Maciej.
 365
 366         * css/MediaList.cpp:
 367         Remove unused header.
 368
 369         * dom/Document.cpp:
 370         (WebCore::Document::clear):
 371         Use clear instead of iterating through the list of event listeners, removing each one.
 372         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
 373
 374         * html/HTMLKeygenElement.cpp:
 375         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
 376         (WebCore::HTMLKeygenElement::appendFormData):
 377         Update due to changes in the SSL key generator.
 378
 379         * ksvg2/svg/SVGAngle.cpp:
 380         Remove unused header.
 381
 382         * ksvg2/svg/SVGAnimationElement.cpp:
 383         (SVGAnimationElement::parseMappedAttribute):
 384         Rename methods and pass Strings instead of DeprecatedStrings to
 385         parseSeparatedList.
 386
 387         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
 388         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
 389         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
 390         * ksvg2/svg/SVGFEMergeElement.cpp:
 391         * ksvg2/svg/SVGFEOffsetElement.cpp:
 392         Remove unused headers.
 393
 394         * ksvg2/svg/SVGHelper.cpp:
 395         (WebCore::SVGHelper::parseSeparatedList):
 396         * ksvg2/svg/SVGHelper.h:
 397         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
 398         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
 399
 400         * ksvg2/svg/SVGLengthList.cpp:
 401         (WebCore::SVGLengthList::parse):
 402         * ksvg2/svg/SVGLengthList.h:
 403         Use Vector<String> instead of DeprecatedStringList.
 404
 405         * loader/Cache.cpp:
 406         (WebCore::Cache::requestImage):
 407         (WebCore::Cache::requestStyleSheet):
 408         (WebCore::Cache::requestScript):
 409         (WebCore::Cache::requestXSLStyleSheet):
 410         (WebCore::Cache::requestXBLDocument):
 411         (WebCore::Cache::remove):
 412         (WebCore::Cache::get):
 413         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
 414
 415         * loader/DocLoader.cpp:
 416         (WebCore::DocLoader::needReload):
 417         * loader/DocLoader.h:
 418         Use a HashSet instead of DeprecatedStringList.
 419
 420         * page/FrameView.h:
 421         Remove declarations that have no functions.
 422
 423         * platform/SSLKeyGenerator.h:
 424         * platform/mac/SSLKeyGeneratorMac.mm:
 425         (WebCore::supportedKeySizes):
 426         (WebCore::signedPublicKeyAndChallengeString):
 427         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
 428         DeprecatedString.
 429
 430 2006-09-25  Dave Hyatt  <hyatt@apple.com>
 431
 432         Shunt the RenderTheme world transform adoption between
 433         Cairo and Windows into getWindowsContext and move the method
 434         out of GraphicsContextCairo and into GraphicsContextWin.
 435
 436         * ChangeLog:
 437         * WebCore.vcproj/WebCore/WebCore.vcproj:
 438         * platform/cairo/GraphicsContextCairo.cpp:
 439         * platform/win/GraphicsContextWin.cpp: Added.
 440         (WebCore::GraphicsContext::getWindowsContext):
 441         (WebCore::GraphicsContext::releaseWindowsContext):
 442         * rendering/RenderThemeWin.cpp:
 443         (WebCore::prepareForDrawing):
 444
 445 2006-09-24  Eric Seidel  <eric@eseidel.com>
 446
 447         Reviewed by hyatt.
 448
 449         <svg:a> cannot be styled with a:hover
 450         http://bugzilla.opendarwin.org/show_bug.cgi?id=11005
 451
 452         Test: svg/hixie/cascade/002.xml
 453
 454         * css/cssstyleselector.cpp:
 455         (WebCore::checkPseudoState):
 456
 457 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
 458
 459         Reviewed by Tim H.
 460
 461         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10882
 462         SVG needs Obj-C DOM bindings
 463
 464         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
 465           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
 466           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
 467           DOMSVGTransformList.
 468
 469         * DerivedSources.make:
 470         * WebCore.xcodeproj/project.pbxproj:
 471         * bindings/objc/DOMInternal.h:
 472         * bindings/objc/DOMSVG.h: Added.
 473         * ksvg2/svg/SVGAngle.idl:
 474         * ksvg2/svg/SVGLength.idl:
 475         * ksvg2/svg/SVGLengthList.idl:
 476         * ksvg2/svg/SVGMatrix.idl:
 477         * ksvg2/svg/SVGPathSeg.idl:
 478         * ksvg2/svg/SVGPathSegList.idl:
 479         * ksvg2/svg/SVGTransform.idl:
 480         * ksvg2/svg/SVGTransformList.idl:
 481
 482 2006-09-24  Rob Buis  <buis@kde.org>
 483
 484         Reviewed by eseidel.
 485
 486         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6001
 487         WebKit does not handle fallback custom cursors
 488         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6002
 489         WebKit does not properly handle SVG <cursor> element
 490
 491         Add support for svg cursor images. Also make sure hotspot
 492         settings are handled correctly. Add tests for handling of css3
 493         cursor syntax with hotspots in strict and quirks mode. Finally
 494         implement fallback.
 495
 496         * WebCore.xcodeproj/project.pbxproj:
 497         * css/CSSComputedStyleDeclaration.cpp:
 498         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
 499         * css/CSSCursorImageValue.cpp: Added.
 500         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
 501         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
 502         * css/CSSCursorImageValue.h: Added.
 503         (WebCore::CSSCursorImageValue::hotspot):
 504         * css/cssparser.cpp:
 505         (WebCore::CSSParser::parseValue):
 506         * css/cssstyleselector.cpp:
 507         (WebCore::CSSStyleSelector::applyProperty):
 508         * ksvg2/svg/SVGCursorElement.cpp:
 509         * manual-tests/css3-cursor-fallback-quirks.html: Added.
 510         * manual-tests/css3-cursor-fallback-strict.html: Added.
 511         * manual-tests/cursorfallback.xml: Added.
 512         * page/FrameView.cpp:
 513         (WebCore::selectCursor):
 514         * platform/Cursor.h:
 515         * platform/mac/CursorMac.mm:
 516         (WebCore::createCustomCursor):
 517         (WebCore::Cursor::Cursor):
 518         * platform/qt/CursorQt.cpp:
 519         (WebCore::Cursor::Cursor):
 520         * rendering/RenderStyle.cpp:
 521         (WebCore::StyleInheritedData::StyleInheritedData):
 522         (WebCore::StyleInheritedData::operator==):
 523         (WebCore::RenderStyle::diff):
 524         (WebCore::RenderStyle::addCursor):
 525         (WebCore::RenderStyle::addSVGCursor):
 526         (WebCore::RenderStyle::setCursorList):
 527         (WebCore::RenderStyle::clearCursorList):
 528         * rendering/RenderStyle.h:
 529         (WebCore::CursorData::CursorData):
 530         (WebCore::CursorList::operator[]):
 531         (WebCore::CursorList::size):
 532         (WebCore::CursorList::append):
 533         (WebCore::RenderStyle::cursors):
 534
 535 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
 536
 537         Reviewed by Tim H.
 538
 539         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11009
 540         Auto-generate the internal methods interfaces for the Objective-C bindings
 541
 542         - Auto-generate the internal method declarations into their own files
 543           named in the form DOMFooBarInternal.h for class DOMFooBar.
 544
 545         - Remove all use of DOM_cast from code.
 546
 547         - Assorted cleanups.
 548
 549         * WebCore.xcodeproj/project.pbxproj:
 550         * bindings/objc/DOM.mm:
 551         (-[DOMNode _initWithNode:WebCore::]):
 552         (-[DOMNode WebCore::]):
 553         (-[DOMRange dealloc]):
 554         (-[DOMRange finalize]):
 555         (-[DOMRange _initWithRange:WebCore::]):
 556         (-[DOMRange WebCore::]):
 557         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
 558         (-[DOMNodeFilter WebCore::]):
 559         (-[DOMNodeFilter dealloc]):
 560         (-[DOMNodeFilter finalize]):
 561         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
 562         (-[DOMNodeIterator WebCore::]):
 563         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
 564         (-[DOMTreeWalker WebCore::]):
 565         * bindings/objc/DOMAbstractView.mm:
 566         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
 567         * bindings/objc/DOMCSS.mm:
 568         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
 569         (-[DOMCSSRule _initWithRule:WebCore::]):
 570         (-[DOMCSSValue _initWithValue:WebCore::]):
 571         * bindings/objc/DOMEvents.mm:
 572         (-[DOMEvent _initWithEvent:WebCore::]):
 573         * bindings/objc/DOMHTMLAppletElement.mm:
 574         (-[DOMHTMLAppletElement align]):
 575         (-[DOMHTMLAppletElement setAlign:]):
 576         (-[DOMHTMLAppletElement alt]):
 577         (-[DOMHTMLAppletElement setAlt:]):
 578         (-[DOMHTMLAppletElement archive]):
 579         (-[DOMHTMLAppletElement setArchive:]):
 580         (-[DOMHTMLAppletElement code]):
 581         (-[DOMHTMLAppletElement setCode:]):
 582         (-[DOMHTMLAppletElement codeBase]):
 583         (-[DOMHTMLAppletElement setCodeBase:]):
 584         (-[DOMHTMLAppletElement height]):
 585         (-[DOMHTMLAppletElement setHeight:]):
 586         (-[DOMHTMLAppletElement hspace]):
 587         (-[DOMHTMLAppletElement setHspace:]):
 588         (-[DOMHTMLAppletElement name]):
 589         (-[DOMHTMLAppletElement setName:]):
 590         (-[DOMHTMLAppletElement object]):
 591         (-[DOMHTMLAppletElement setObject:]):
 592         (-[DOMHTMLAppletElement vspace]):
 593         (-[DOMHTMLAppletElement setVspace:]):
 594         (-[DOMHTMLAppletElement width]):
 595         (-[DOMHTMLAppletElement setWidth:]):
 596         * bindings/objc/DOMInternal.h:
 597         (getDOMWrapper):
 598         (addDOMWrapper):
 599         (raiseOnDOMError):
 600         * bindings/objc/DOMXPath.mm:
 601         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
 602         * bindings/scripts/CodeGeneratorObjC.pm:
 603
 604 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
 605
 606         Reviewed by eseidel.
 607
 608         Fix Qt/Linux build after Dave's Scrollbar changes.
 609
 610         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
 611         * platform/qt/TemporaryLinkStubs.cpp:
 612         (WebCore::ScrollBar::setProportion):
 613         (WebCore::PlatformScrollBar::updateThumbPosition):
 614         (WebCore::PlatformScrollBar::updateThumbProportion):
 615
 616 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
 617
 618         Reviewed by eseidel.
 619
 620         Qt/Linux build system changes: enable xpath/xslt by default.
 621         Offer possibility to change all of these using 'ccmake'.
 622
 623         * CMakeLists.txt:
 624
 625 2006-09-24  Dave Hyatt  <hyatt@apple.com>
 626
 627         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
 628         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
 629         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
 630
 631         * platform/ScrollBar.cpp:
 632         (WebCore::ScrollBar::setValue):
 633         (WebCore::ScrollBar::setProportion):
 634         * platform/ScrollBar.h:
 635         (WebCore::ScrollBar::value):
 636         * platform/mac/PlatformScrollBar.h:
 637         * platform/mac/PlatformScrollBarMac.mm:
 638         (WebCore::PlatformScrollBar::updateThumbPosition):
 639         (WebCore::PlatformScrollBar::updateThumbProportion):
 640         * platform/win/PlatformScrollBar.h:
 641         * platform/win/TemporaryLinkStubs.cpp:
 642         (PlatformScrollBar::updateThumbPosition):
 643         (PlatformScrollBar::updateThumbProportion):
 644         * rendering/RenderLayer.cpp:
 645         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
 646
 647 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
 648
 649         Reviewed by Eric.
 650
 651         http://bugzilla.opendarwin.org/show_bug.cgi?id=4872
 652         XMLHttpRequest fails to throw an exception when there is a security violation
 653         (mismatching domains)
 654
 655         Raise an exception if there is a security violation, and also in cases required by
 656         the current draft of XHR specification.
 657
 658         * bindings/js/JSXMLHttpRequest.cpp:
 659         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
 660         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
 661         reports one, and also if there were too few arguments passed.
 662
 663         * bindings/js/kjs_binding.cpp:
 664         (KJS::setDOMException): Added support for custom XHR exceptions.
 665
 666         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
 667         exception code range for XHR exceptions.
 668
 669         * xml/xmlhttprequest.cpp:
 670         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
 671         (WebCore::XMLHttpRequest::send):
 672         (WebCore::XMLHttpRequest::setRequestHeader):
 673         (WebCore::XMLHttpRequest::getStatus):
 674         (WebCore::XMLHttpRequest::getStatusText):
 675         (WebCore::XMLHttpRequest::processSyncLoadResults):
 676         (WebCore::XMLHttpRequest::receivedAllData):
 677         (WebCore::XMLHttpRequest::receivedData):
 678
 679 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
 680
 681         Reviewed by Jeff Jenkins.
 682
 683         Tweak CF types.
 684
 685         * platform/cf/ResourceLoaderCFNet.cpp:
 686         (WebCore::willCacheResponse):
 687
 688 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
 689
 690         Reviewed by darin
 691
 692         <http://bugzilla.opendarwin.org/show_bug.cgi?id=8029>
 693         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
 694
 695         * dom/Document.cpp:
 696         (WebCore::Document::clearSelectionIfNeeded):
 697         * dom/Element.cpp:
 698         (WebCore::Element::contains):
 699         * dom/Node.cpp:
 700         (WebCore::Node::traverseNextNode):
 701         (WebCore::Node::traverseNextSibling):
 702         (WebCore::Node::traversePreviousNodePostOrder):
 703         (WebCore::Node::checkAddChild):
 704         (WebCore::Node::isDescendantOf):
 705         * dom/Node.h:
 706         * dom/NodeIterator.cpp:
 707         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
 708         * editing/ApplyStyleCommand.cpp:
 709         (WebCore::ApplyStyleCommand::applyBlockStyle):
 710         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
 711         (WebCore::ApplyStyleCommand::applyInlineStyle):
 712         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
 713         * editing/CompositeEditCommand.cpp:
 714         (WebCore::CompositeEditCommand::mergeIdenticalElements):
 715         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
 716         * editing/DeleteSelectionCommand.cpp:
 717         (WebCore::updatePositionForNodeRemoval):
 718         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
 719         (WebCore::DeleteSelectionCommand::mergeParagraphs):
 720         * editing/FormatBlockCommand.cpp:
 721         (WebCore::FormatBlockCommand::doApply):
 722         * editing/IndentOutdentCommand.cpp:
 723         (WebCore::enclosingListOrBlockquote):
 724         * editing/Selection.cpp:
 725         (WebCore::Selection::validate):
 726         * editing/SelectionController.cpp:
 727         (WebCore::SelectionController::nodeWillBeRemoved):
 728         * editing/TextIterator.cpp:
 729         (WebCore::SimplifiedBackwardsTextIterator::advance):
 730         * editing/VisiblePosition.cpp:
 731         (WebCore::VisiblePosition::next):
 732         (WebCore::VisiblePosition::previous):
 733         (WebCore::VisiblePosition::canonicalPosition):
 734         (WebCore::isFirstVisiblePositionInNode):
 735         (WebCore::isLastVisiblePositionInNode):
 736         * editing/htmlediting.cpp:
 737         (WebCore::firstEditablePositionAfterPositionInRoot):
 738         (WebCore::lastEditablePositionBeforePositionInRoot):
 739         (WebCore::enclosingNodeWithTag):
 740         (WebCore::enclosingList):
 741         (WebCore::enclosingListChild):
 742         * editing/markup.cpp:
 743         (WebCore::createMarkup):
 744
 745 2006-09-22  Timothy Hatcher  <timothy@apple.com>
 746
 747         Reviewed by Darin.
 748
 749         - Added @property syntax to non-generated headers
 750           inside #ifndef BUILDING_ON_TIGER.
 751         - Changed the DOMEventTarget protocol to have have new versions
 752           of addEventListener and removeEventListener with named parameters.
 753           These old style methods can be removed once Mail changes to use
 754           the new methods <rdar://problem/4746649>.
 755
 756         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
 757         * bindings/objc/DOM.mm:
 758         (-[DOMNode addEventListener:listener:useCapture:]):
 759         (-[DOMNode addEventListener:::]): call the new method
 760         (-[DOMNode removeEventListener:listener:useCapture:]):
 761         (-[DOMNode removeEventListener:::]): call the new method
 762         * bindings/objc/DOMAbstractView.h:
 763         * bindings/objc/DOMEventTarget.h:
 764         * bindings/objc/DOMHTMLAppletElement.h:
 765         * bindings/objc/DOMHTMLEmbedElement.h:
 766         * bindings/objc/DOMHTMLOptionElement.h:
 767         * bindings/objc/DOMObject.h:
 768         * bindings/objc/DOMRGBColor.h:
 769
 770 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
 771
 772         Reviewed by Eric.
 773
 774         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
 775
 776         * platform/qt/FrameQt.cpp:
 777         * platform/qt/GraphicsContextQt.cpp:
 778         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
 779         (WebCore::GraphicsContext::origin):
 780         * platform/qt/PlatformScrollBar.h: Added.
 781         (WebCore::PlatformScrollBar::isWidget):
 782         * platform/qt/WidgetQt.cpp:
 783         (WebCore::Widget::invalidate):
 784         (WebCore::Widget::invalidateRect):
 785
 786 2006-09-22  Dave Hyatt <hyatt@apple.com>
 787
 788         Super-minor tweaks to the systemFont function on Mac.
 789         Set the generic family to None rather than to Serif, and
 790         don't waste time setting the computed size, since that is
 791         set from the specified size over in CSSStyleSelector anyway.
 792
 793         * rendering/RenderThemeMac.mm:
 794         (WebCore::RenderThemeMac::systemFont):
 795
 796 2006-09-22  Timothy Hatcher  <timothy@apple.com>
 797
 798         Reviewed by Brady.
 799
 800         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
 801         take floats. There was already an implicit conversion to float/double
 802         when calling CGContextTranslateCTM or cairo_translate.
 803
 804         * platform/GraphicsContext.h:
 805         * platform/cairo/GraphicsContextCairo.cpp:
 806         (WebCore::GraphicsContext::translate):
 807         * platform/cg/GraphicsContextCG.cpp:
 808         (WebCore::GraphicsContext::translate):
 809
 810 2006-09-22  Brady Eidson  <beidson@apple.com>
 811
 812         Reviewed by Sfalken
 813
 814         Add redirect and other cleanup to ResourceLoaderWin.cpp
 815         Fixes bug http://bugzilla.opendarwin.org/show_bug.cgi?id=10927
 816         Fixes bug http://bugzilla.opendarwin.org/show_bug.cgi?id=10744
 817
 818         * WebCore.xcodeproj/project.pbxproj:
 819         * platform/ResourceLoader.h:
 820         * platform/win/ResourceLoaderWin.cpp:
 821         (WebCore::ResourceLoaderWndProc):
 822         (WebCore::initializeOffScreenResourceLoaderWindow):
 823         (WebCore::ResourceLoader::onHandleCreated):
 824         (WebCore::ResourceLoader::onRequestRedirected):
 825         (WebCore::ResourceLoader::onRequestComplete):
 826         (WebCore::transferJobStatusCallback):
 827
 828 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
 829
 830         Reviewed by Geoff.
 831
 832         http://bugzilla.opendarwin.org/show_bug.cgi?id=10803
 833         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
 834
 835         * page/FrameView.cpp:
 836         (WebCore::FrameView::hoverTimerFired): Use the current event.
 837
 838 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
 839
 840         Reviewed by Anders.
 841
 842         Fix (last) svg memory leak.
 843
 844         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
 845         (SVGTransformable::parseTransformAttribute):
 846
 847 2006-09-22  Eric Seidel  <eric@eseidel.com>
 848
 849         No review necessary, just removing a dead file.
 850
 851         Remove unused file (added previously by mistake) to make room for real implementation.
 852
 853         * platform/mac/BitmapImageMac.mm: Removed.
 854
 855 2006-09-22  Dave Hyatt <hyatt@apple.com>
 856
 857         Move PlatformScrollBar.h down into the platforms.
 858
 859         Reviewed by andersca
 860
 861         * platform/PlatformScrollBar.h: Removed.
 862         * platform/win/PlatformScrollBar.h: Added.
 863         * platform/mac/PlatformScrollBar.h: Added.
 864
 865 2006-09-22   Dave Hyatt  <hyatt@apple.com>
 866
 867         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
 868         any widget subsystems that don't have any underlying native objects backing the widgets.
 869
 870         Reviewed by anders
 871
 872         * platform/Widget.h:
 873         * platform/mac/WidgetMac.mm:
 874         (WebCore::Widget::invalidate):
 875         (WebCore::Widget::invalidateRect):
 876         * platform/win/TemporaryLinkStubs.cpp:
 877         (Widget::invalidate):
 878         (Widget::invalidateRect):
 879
 880 2006-09-22  Rob Buis  <buis@kd.org>
 881
 882         Reviewed by eseidel.
 883
 884         http://bugzilla.opendarwin.org/show_bug.cgi?id=10901
 885         Merge build fixes from unity
 886
 887         * CMakeLists.txt:
 888
 889 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
 890
 891         Reviewed by eseidel.
 892
 893         http://bugzilla.opendarwin.org/show_bug.cgi?id=10977
 894         SVGDocument does not expose 'rootElement' property
 895
 896         Enable 'rootElement' property.
 897
 898         * ksvg2/svg/SVGDocument.idl:
 899
 900 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
 901
 902         Tweak includes.
 903
 904         * platform/ResourceLoaderInternal.h:
 905
 906 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
 907
 908         build fixed. band happy.
 909
 910         * platform/cg/GraphicsContextCG.cpp:
 911         (WebCore::GraphicsContext::translate):
 912         * platform/mac/WidgetMac.mm:
 913
 914 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
 915
 916         Reviewed by Maciej.
 917
 918         Some Widget refactoring.
 919
 920         * WebCore.vcproj/WebCore/WebCore.vcproj:
 921         * bridge/mac/FrameMac.mm:
 922         * bridge/win/FrameWin.cpp:
 923         (WebCore::FrameWin::runJavaScriptAlert):
 924         (WebCore::FrameWin::runJavaScriptConfirm):
 925         * bridge/win/PageWin.cpp:
 926         (WebCore::Page::Page):
 927         (WebCore::rootWindowForFrame):
 928         * html/CanvasRenderingContext2D.cpp:
 929         (WebCore::CanvasRenderingContext2D::translate):
 930         * page/FrameView.cpp:
 931         (WebCore::FrameView::isFrameView):
 932         * page/Page.h:
 933         (WebCore::Page::setInstanceHandle):
 934         (WebCore::Page::instanceHandle):
 935         * platform/GraphicsContext.h:
 936         * platform/ScrollView.h:
 937         * platform/Widget.h:
 938         * platform/cairo/GraphicsContextCairo.cpp:
 939         (WebCore::GraphicsContext::translate):
 940         (WebCore::GraphicsContext::origin):
 941         * platform/mac/WidgetMac.mm:
 942         (WebCore::Widget::clearFocus):
 943         * platform/win/ResourceLoaderWin.cpp:
 944         (WebCore::initializeOffScreenResourceLoaderWindow):
 945         * platform/win/ScreenWin.cpp:
 946         (WebCore::monitorInfo):
 947         * platform/win/ScrollViewWin.cpp:
 948         (WebCore::ScrollView::updateContents):
 949         (WebCore::ScrollView::visibleWidth):
 950         (WebCore::ScrollView::visibleHeight):
 951         (WebCore::ScrollView::visibleContentRect):
 952         (WebCore::ScrollView::viewportToContents):
 953         (WebCore::ScrollView::contentsToViewport):
 954         (WebCore::ScrollView::scrollBy):
 955         (WebCore::ScrollView::updateScrollInfo):
 956         (WebCore::ScrollView::updateScrollBars):
 957         * platform/win/SharedTimerWin.cpp:
 958         (WebCore::initializeOffScreenTimerWindow):
 959         * platform/win/TemporaryLinkStubs.cpp:
 960         (FrameView::updateBorder):
 961         (ScrollView::paint):
 962         (GraphicsContext::clip):
 963         * platform/win/WidgetWin.cpp:
 964         (WebCore::Widget::Widget):
 965         (WebCore::Widget::parentWindow):
 966         (WebCore::Widget::setParentWindow):
 967         (WebCore::Widget::frameGeometry):
 968         (WebCore::Widget::hasFocus):
 969         (WebCore::Widget::setFocus):
 970         (WebCore::Widget::show):
 971         (WebCore::Widget::hide):
 972         (WebCore::Widget::setFrameGeometry):
 973
 974 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
 975
 976         Reviewed by Tim H.
 977
 978         * platform/TextEncoding.cpp:
 979         (WebCore::TextEncoding::backslashAsCurrencySymbol):
 980         Add comment clarifying why backslashAsCurrencySymbol is needed.
 981
 982 2006-09-21  Sean Gies  <seangies@apple.com>
 983
 984         Reviewed by Adam Roben.
 985
 986         Add utility functions to get and release HDC from GraphicsContext.
 987
 988         * platform/GraphicsContext.h: Add utilities to get and release HDC.
 989         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
 990         * rendering/RenderThemeWin.cpp: Switch to new utilities.
 991
 992 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
 993
 994         Reviewed by anders
 995
 996         <rdar://problem/4426622>
 997         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
 998
 999         * editing/htmlediting.cpp:
1000         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
1001         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
1002         Got rid of uses of DepricatedString.
1003
1004 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1005
1006         Reviewed by eseidel.
1007
1008         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
1009
1010         * page/Frame.cpp:
1011         (WebCore::Frame::endIfNotLoading):
1012
1013 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1014
1015         Reviewed by eseidel.
1016
1017         Fix Qt/Linux build.
1018
1019         * CMakeLists.txt:
1020         * kcanvas/device/qt/KCanvasClipperQt.h:
1021         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1022         * platform/qt/FrameQt.cpp:
1023         (WebCore::FrameQt::isLoadTypeReload):
1024         (WebCore::FrameQt::originalRequestURL):
1025         * platform/qt/FrameQt.h:
1026         * platform/qt/GraphicsContextQt.cpp:
1027         (WebCore::GraphicsContext::concatCTM):
1028         * platform/qt/ScrollViewQt.cpp:
1029         (WebCore::ScrollView::wheelEvent):
1030         * platform/qt/TemporaryLinkStubs.cpp:
1031         (WebCore::IconDatabase::setIconURLForPageURL):
1032
1033 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
1034
1035         Reviewed by john
1036
1037         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
1038         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
1039
1040         * editing/MoveSelectionCommand.cpp:
1041         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
1042         to the position-to-move-to's document, not the fragment's document.  The
1043         fragment's document is the document used to create the fragment and is irrelavant.
1044
1045 === Safari-521.27 ===
1046
1047 2006-09-21  Brady Eidson  <beidson@apple.com>
1048
1049         Reviewed by Anders
1050
1051         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
1052         This fixes Spinneret so it won't crash on its first load!
1053
1054         * page/Frame.cpp:
1055         (WebCore::Frame::endIfNotLoading):
1056
1057 2006-09-21  Brady Eidson  <beidson@apple.com>
1058
1059         Build fix
1060
1061         * platform/win/TemporaryLinkStubs.cpp:
1062         (ScrollView::wheelEvent):
1063
1064 2006-09-20  Rob Buis  <buis@kde.org>
1065
1066         Reviewed by eseidel.
1067
1068         http://bugzilla.opendarwin.org/show_bug.cgi?id=10946
1069         new marker code draws end-marker in wrong place
1070
1071         Keep track of the start of the subpath so we can handle
1072         closeTo/moveTo correctly.
1073
1074         * kcanvas/RenderPath.cpp:
1075         (WebCore::DrawMarkersData::DrawMarkersData):
1076         (WebCore::updateMarkerDataForElement):
1077
1078 2006-09-21  David Hyatt <hyatt@apple.com>
1079
1080         Wheel scrolling prep for Win32.
1081
1082         WARNING: NO TEST CASES ADDED OR CHANGED
1083
1084         * platform/PlatformWheelEvent.h:
1085         * platform/ScrollBar.h:
1086         * platform/ScrollView.h:
1087         * platform/mac/ScrollViewMac.mm:
1088         (WebCore::ScrollView::wheelEvent):
1089         * rendering/RenderLayer.cpp:
1090
1091 2006-09-20  Timothy Hatcher  <timothy@apple.com>
1092
1093         Reviewed by Hyatt.
1094
1095         Bug 10917: REGRESSION (r16027): iFrame transparency broken
1096         http://bugzilla.opendarwin.org/show_bug.cgi?id=10917
1097
1098         Don't paint the base background color if we transparent.
1099
1100         * rendering/RenderBox.cpp:
1101         (WebCore::RenderBox::paintBackgroundExtended):
1102
1103 2006-09-20  Adam Roben  <aroben@apple.com>
1104
1105         Reviewed by andersca.
1106
1107         * platform/FileChooser.h: Remove no-longer-necessary namespace std
1108
1109 2006-09-20  Eric Seidel  <eric@eseidel.com>
1110
1111         Reviewed by beth.
1112
1113         Cleanup style in KCanvas.
1114         Remove extra white-space, unneeded arguments, etc.
1115
1116         * WebCore.xcodeproj/project.pbxproj:
1117         * kcanvas/KCanvasClipper.cpp:
1118         (WebCore::operator<<):
1119         (WebCore::KCanvasClipper::externalRepresentation):
1120         * kcanvas/KCanvasClipper.h:
1121         * kcanvas/KCanvasFilters.cpp:
1122         (WebCore::KCanvasFilter::externalRepresentation):
1123         (WebCore::operator<<):
1124         (WebCore::KCanvasFilterEffect::externalRepresentation):
1125         (WebCore::KCPointLightSource::externalRepresentation):
1126         (WebCore::KCSpotLightSource::externalRepresentation):
1127         (WebCore::KCDistantLightSource::externalRepresentation):
1128         (WebCore::KCanvasFEBlend::externalRepresentation):
1129         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
1130         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
1131         (WebCore::KCanvasFEComposite::externalRepresentation):
1132         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
1133         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
1134         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
1135         (WebCore::KCanvasFEFlood::externalRepresentation):
1136         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
1137         (WebCore::KCanvasFEImage::externalRepresentation):
1138         (WebCore::KCanvasFEMerge::externalRepresentation):
1139         (WebCore::KCanvasFEMorphology::externalRepresentation):
1140         (WebCore::KCanvasFEOffset::externalRepresentation):
1141         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
1142         (WebCore::KCanvasFETile::externalRepresentation):
1143         (WebCore::KCanvasFETurbulence::externalRepresentation):
1144         * kcanvas/KCanvasFilters.h:
1145         (WebCore::KCanvasFEDiffuseLighting::lightSource):
1146         (WebCore::KCanvasFESpecularLighting::lightSource):
1147         * kcanvas/KCanvasImage.h:
1148         * kcanvas/KCanvasMarker.cpp:
1149         (WebCore::KCanvasMarker::externalRepresentation):
1150         * kcanvas/KCanvasMarker.h:
1151         * kcanvas/KCanvasResource.cpp:
1152         (WebCore::operator<<):
1153         * kcanvas/KCanvasResource.h:
1154         * kcanvas/KCanvasTreeDebug.cpp:
1155         (WebCore::operator<<):
1156         (WebCore::writeIndent):
1157         (WebCore::writeStyle):
1158         (WebCore::write):
1159         (WebCore::writeRenderResources):
1160         * kcanvas/KCanvasTreeDebug.h:
1161         (WebCore::operator<<):
1162         * kcanvas/RenderForeignObject.cpp:
1163         (WebCore::RenderForeignObject::paint):
1164         * kcanvas/RenderPath.cpp:
1165         (WebCore::RenderPath::paint):
1166         (WebCore::drawStartAndMidMarkers):
1167         * kcanvas/RenderSVGContainer.cpp:
1168         (WebCore::RenderSVGContainer::paint):
1169         * kcanvas/RenderSVGImage.cpp:
1170         (WebCore::RenderSVGImage::translateForAttributes):
1171         * kcanvas/RenderSVGImage.h:
1172         * kcanvas/device/KRenderingDevice.cpp:
1173         (WebCore::KRenderingDevice::currentContext):
1174         (WebCore::KRenderingDevice::popContext):
1175         (WebCore::KRenderingDevice::pushContext):
1176         * kcanvas/device/KRenderingDevice.h:
1177         * kcanvas/device/KRenderingFillPainter.h:
1178         * kcanvas/device/KRenderingPaintServer.h:
1179         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1180         (WebCore::KRenderingPaintServer::activeClient):
1181         (WebCore::KRenderingPaintServer::setActiveClient):
1182         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1183         (WebCore::operator<<):
1184         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
1185         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
1186         (WebCore::KRenderingPaintServerGradient::listener):
1187         (WebCore::KRenderingPaintServerGradient::setListener):
1188         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
1189         * kcanvas/device/KRenderingPaintServerGradient.h:
1190         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1191         (WebCore::KRenderingPaintServerPattern::tile):
1192         (WebCore::KRenderingPaintServerPattern::setTile):
1193         (WebCore::KRenderingPaintServerPattern::listener):
1194         (WebCore::KRenderingPaintServerPattern::setListener):
1195         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
1196         * kcanvas/device/KRenderingPaintServerPattern.h:
1197         * kcanvas/device/KRenderingPaintServerSolid.cpp:
1198         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
1199         * kcanvas/device/KRenderingPaintServerSolid.h:
1200         * kcanvas/device/KRenderingStrokePainter.cpp:
1201         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
1202         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
1203         * kcanvas/device/KRenderingStrokePainter.h:
1204         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
1205         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1206         (WebCore::KCanvasFilterQuartz::prepareFilter):
1207         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
1208         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1209         (WebCore::KCanvasMaskerQuartz::applyMask):
1210         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1211         (WebCore::KCanvasImageQuartz::init):
1212         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1213         (WebCore::KCanvasClipperQuartz::applyClip):
1214         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1215         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1216         (WebCore::KRenderingDeviceQuartz::quartzContext):
1217         (WebCore::KRenderingDeviceQuartz::contextForImage):
1218         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1219         (WebCore::KRenderingDeviceQuartz::createResource):
1220         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
1221         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1222         (WebCore::CGShadingRefForLinearGradient):
1223         (WebCore::CGShadingRefForRadialGradient):
1224         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
1225         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1226         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1227         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1228         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
1229         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
1230         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
1231         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
1232         (WebCore::KRenderingPaintServerSolidQuartz::draw):
1233         (WebCore::KRenderingPaintServerSolidQuartz::setup):
1234         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
1235         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1236         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
1237         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
1238         * kcanvas/device/quartz/QuartzSupport.h:
1239         * kcanvas/device/quartz/QuartzSupport.mm:
1240         (WebCore::applyStrokeStyleToContext):
1241
1242 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1243
1244         Reviewed by Dave Hyatt.
1245
1246         * dom/WheelEvent.cpp:
1247         (WebCore::WheelEvent::WheelEvent):
1248         Use lroundf instead of lround since deltas are floats.
1249
1250 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
1251
1252         Reviewed by eseidel.  Landed by eseidel.
1253
1254         Test: svg/custom/pattern-y-offset.svg
1255
1256         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1257         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1258
1259 2006-09-20  David Hyatt  <hyatt@apple.com>
1260
1261         Add a new wheelEvent method to ScrollView.  Platforms that wish
1262         to handle the wheel event for the scroll view themselves can then
1263         do so there.  (Mac lets the underlying NSScrollView do it for now.)
1264
1265         * page/FrameView.cpp:
1266         (WebCore::FrameView::handleWheelEvent):
1267         * platform/ScrollView.h:
1268         (WebCore::ScrollView::wheelEvent):
1269
1270 2006-09-20  Brady Eidson  <beidson@apple.com>
1271
1272         Reviewed by Tim Omernick
1273
1274         Part of fixing a crash Tim O showed me that I missed in a release build.
1275         WebKit should be able to call through the bridge to WebCore no matter what -
1276         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
1277
1278         * bridge/mac/WebCoreIconDatabaseBridge.h:
1279         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1280         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
1281         (-[WebCoreIconDatabaseBridge isOpen]):
1282         (-[WebCoreIconDatabaseBridge removeAllIcons]):
1283         (-[WebCoreIconDatabaseBridge _isEmpty]):
1284         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
1285         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
1286         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
1287         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
1288         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
1289         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
1290         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
1291         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
1292         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
1293         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
1294         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
1295         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
1296         (-[WebCoreIconDatabaseBridge _setEnabled:]):
1297         (-[WebCoreIconDatabaseBridge _isEnabled]):
1298
1299 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1300
1301         Reviewed by Darin.
1302
1303         Add String::split which returns a Vector of Strings and use it instead of
1304         DeprecatedStringList.
1305
1306         * bindings/js/kjs_events.cpp:
1307         (KJS::Clipboard::getValueProperty):
1308         * bindings/js/kjs_window.cpp:
1309         (KJS::parseModalDialogFeatures):
1310         * css/MediaList.cpp:
1311         (WebCore::MediaList::setMediaText):
1312         * dom/Clipboard.h:
1313         * html/HTMLFormElement.cpp:
1314         (WebCore::HTMLFormElement::formData):
1315         * html/HTMLLinkElement.cpp:
1316         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
1317         * platform/PlatformString.h:
1318         * platform/String.cpp:
1319         (WebCore::String::split):
1320         * platform/StringImpl.cpp:
1321         * platform/StringImpl.h:
1322         * platform/mac/ClipboardMac.h:
1323         * platform/mac/ClipboardMac.mm:
1324         (WebCore::ClipboardMac::types):
1325
1326 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
1327
1328         Reviewed by harrison
1329
1330         * css/cssstyleselector.cpp:
1331         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
1332         HTMLElement::isContentEditable just to check the Frame's editability, since
1333         it calls updateRenderering, which can get us into infinite recursion.
1334
1335 2006-09-20  Brady Eidson  <beidson@apple.com>
1336
1337         Reviewed by Darin
1338
1339         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
1340
1341         * loader/icon/IconDatabase.cpp:
1342         (WebCore::IconDatabase::IconDatabase): Disabled by default
1343         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
1344         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
1345         (WebCore::IconDatabase::iconForPageURL): Ditto
1346         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
1347         (WebCore::IconDatabase::iconURLForPageURL): Ditto
1348         (WebCore::IconDatabase::retainIconForPageURL): Ditto
1349         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
1350         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
1351         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
1352         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
1353         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
1354
1355 2006-09-20  Adam Roben  <aroben@apple.com>
1356
1357         Reviewed by Adele.
1358
1359         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
1360         REGRESSION: file upload control with direction:rtl or text-align:right
1361         draws button on top of filename/icon
1362
1363         * rendering/RenderFileUploadControl.cpp:
1364         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
1365         match direction
1366         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
1367         the filename and icon in RTL
1368
1369 2006-09-20  Alice Liu  <alice.liu@apple.com>
1370
1371         Reviewed by Adam Roben.
1372
1373         fixed windows build
1374
1375         * dom/WheelEvent.cpp:
1376         (WebCore::WheelEvent::WheelEvent):
1377         changed lrint to lround
1378
1379 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
1380
1381         Build Fix.  Adds isHorizontal attribute back to WheelEvent
1382         for the Objective-C bindings.  If it is found that isHorizontal
1383         is not used, we should remove it again but also remove it's
1384         declaration from PublicDOMInterfaces.h
1385
1386         * dom/WheelEvent.h:
1387         (WebCore::WheelEvent::isHorizontal):
1388         * dom/WheelEvent.idl:
1389
1390 2006-09-20  David Hyatt  <hyatt@apple.com>
1391
1392         Fix for 10945, WheelEvent should support two dimensions at once, since
1393         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
1394         to allow for diagonal scrolling.
1395
1396         Reviewed by Eric
1397
1398         * dom/EventTargetNode.cpp:
1399         (WebCore::EventTargetNode::dispatchWheelEvent):
1400         * dom/WheelEvent.cpp:
1401         (WebCore::WheelEvent::WheelEvent):
1402         (WebCore::WheelEvent::initWheelEvent):
1403         * dom/WheelEvent.h:
1404         (WebCore::WheelEvent::wheelDelta):
1405         (WebCore::WheelEvent::wheelDeltaX):
1406         (WebCore::WheelEvent::wheelDeltaY):
1407         * dom/WheelEvent.idl:
1408         * page/FrameView.cpp:
1409         (WebCore::FrameView::handleWheelEvent):
1410         * platform/PlatformWheelEvent.h:
1411         (WebCore::PlatformWheelEvent::deltaX):
1412         (WebCore::PlatformWheelEvent::deltaY):
1413         (WebCore::PlatformWheelEvent::normalize):
1414         * platform/mac/WheelEventMac.mm:
1415         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1416
1417 2006-09-19  Eric Seidel  <eric@eseidel.com>
1418
1419         Reviewed by hyatt.
1420
1421         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
1422
1423         No tests were harmed in the making of this patch.
1424
1425         * WebCore.xcodeproj/project.pbxproj:
1426         * kcanvas/KCanvasClipper.cpp: Added.
1427         (WebCore::operator<<):
1428         * kcanvas/KCanvasClipper.h: Added.
1429         * kcanvas/KCanvasFilters.h:
1430         * kcanvas/KCanvasImage.h:
1431         * kcanvas/KCanvasMarker.cpp: Added.
1432         * kcanvas/KCanvasMarker.h: Added.
1433         * kcanvas/KCanvasMasker.cpp: Added.
1434         (WebCore::KCanvasMasker::KCanvasMasker):
1435         (WebCore::KCanvasMasker::setMask):
1436         (WebCore::KCanvasMasker::externalRepresentation):
1437         (WebCore::getMaskerById):
1438         * kcanvas/KCanvasMasker.h: Added.
1439         * kcanvas/KCanvasResource.cpp: Added.
1440         (WebCore::KCanvasResource::invalidate):
1441         (WebCore::KCanvasResource::externalRepresentation):
1442         (WebCore::getResourceById):
1443         (WebCore::getPaintServerById):
1444         * kcanvas/KCanvasResource.h: Added.
1445         * kcanvas/KCanvasResources.cpp: Removed.
1446         * kcanvas/KCanvasResources.h: Removed.
1447         * kcanvas/RenderPath.cpp:
1448         * kcanvas/RenderSVGContainer.cpp:
1449         * kcanvas/RenderSVGImage.cpp:
1450         * kcanvas/RenderSVGText.cpp:
1451         * kcanvas/device/KRenderingPaintServer.h:
1452         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1453         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1454         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1455         * ksvg2/svg/SVGClipPathElement.h:
1456         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1457         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
1458         * ksvg2/svg/SVGFECompositeElement.cpp:
1459         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1460         * ksvg2/svg/SVGFELightElement.cpp:
1461         * ksvg2/svg/SVGFEOffsetElement.cpp:
1462         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1463         * ksvg2/svg/SVGFilterElement.cpp:
1464         * ksvg2/svg/SVGLinearGradientElement.cpp:
1465         * ksvg2/svg/SVGMarkerElement.h:
1466         * ksvg2/svg/SVGMaskElement.h:
1467
1468 2006-09-19  Brady Eidson <beidson@apple.com>
1469
1470         Reviewed by Sarge Decker
1471
1472         <rdar://problem/4739892> and <rdar://problem/4729797>
1473         - WebCore::IconDatabase needs to have and respect an enabled() flag
1474         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
1475
1476         * bridge/mac/WebCoreIconDatabaseBridge.h:
1477         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1478         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
1479         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
1480         * loader/icon/IconDatabase.cpp:
1481         (WebCore::IconDatabase::IconDatabase):
1482         (WebCore::IconDatabase::open): Don't open if disabled
1483         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
1484         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
1485         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
1486         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
1487         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
1488         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
1489         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
1490         (WebCore::IconDatabase::releaseIconURL):
1491         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
1492         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
1493         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
1494         (WebCore::IconDatabase::setEnabled): Added
1495         * loader/icon/IconDatabase.h:
1496         (WebCore::IconDatabase::enabled): Added
1497         * page/Frame.cpp:
1498         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
1499         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
1500
1501 2006-09-20  David Hyatt  <hyatt@apple.com>
1502
1503         Massage mouse wheel handling so that it is more cross-platform.  Make
1504         all the work happen in handleWheelEvent on the FrameView.
1505
1506         Reviewed by bradee-oh
1507
1508         * bridge/mac/FrameMac.mm:
1509         (WebCore::FrameMac::wheelEvent):
1510         * page/FrameView.cpp:
1511         (WebCore::FrameView::handleWheelEvent):
1512         * platform/PlatformWheelEvent.h:
1513         (WebCore::PlatformWheelEvent::platformDelta):
1514         (WebCore::PlatformWheelEvent::delta):
1515         * platform/mac/WheelEventMac.mm:
1516         (WebCore::platformDeltaForEvent):
1517         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1518         * rendering/RenderLayer.cpp:
1519         (WebCore::RenderLayer::scroll):
1520         * rendering/RenderObject.cpp:
1521         (WebCore::RenderObject::scroll):
1522
1523 2006-09-19  Eric Seidel  <eric@eseidel.com>
1524
1525         Reviewed by adele.
1526
1527         Improve test output for filters with bounding-box relative sizes.
1528         http://bugzilla.opendarwin.org/show_bug.cgi?id=8585
1529
1530         Many test results updated.
1531
1532         * kcanvas/KCanvasFilters.cpp:
1533         (WebCore::KCanvasFilter::externalRepresentation):
1534
1535 2006-09-19  Eric Seidel  <eric@eseidel.com>
1536
1537         Reviewed by adele.
1538
1539         Markers should clip to their viewport.
1540         http://bugzilla.opendarwin.org/show_bug.cgi?id=5967
1541
1542         Test: svg/custom/marker-overflow-clip.svg
1543
1544         * kcanvas/KCanvasResources.cpp:
1545         (WebCore::KCanvasMarker::KCanvasMarker):
1546         (WebCore::KCanvasMarker::setMarker):
1547         (WebCore::KCanvasMarker::draw):
1548         * kcanvas/KCanvasResources.h:
1549         (WebCore::KCanvasMasker::mask):
1550         * ksvg2/svg/SVGMarkerElement.cpp:
1551         (WebCore::SVGMarkerElement::SVGMarkerElement):
1552         (WebCore::SVGMarkerElement::parseMappedAttribute):
1553         (WebCore::SVGMarkerElement::canvasResource):
1554         (WebCore::SVGMarkerElement::createRenderer):
1555
1556 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1557
1558         Reviewed by eseidel
1559
1560         Backing out my recent change.
1561
1562         * css/cssstyleselector.cpp:
1563         (WebCore::CSSStyleSelector::adjustRenderStyle):
1564
1565 2006-09-19  Brady Eidson  <beidson@apple.com>
1566
1567         Reviewed by Kevin McCullough
1568
1569         http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
1570         Opening a PDF in a new tab/window creates a documentless-frame
1571         and we deref the document without checking its validity
1572
1573         * page/Frame.cpp:
1574         (WebCore::Frame::iconURL):
1575
1576 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1577
1578         Reviewed by harrison
1579
1580         <rdar://problem/4735272>
1581         Can not click into link in programmatically editable content
1582
1583         * css/cssstyleselector.cpp:
1584         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
1585         userModify to implement document wide editability.
1586
1587 2006-09-19  MorganL  <morlmor@yahoo.com>
1588
1589         Reviewed by Darin and landed by Brady
1590
1591         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10939
1592         Build broken when SVG is not enabled.
1593
1594         * dom/XMLTokenizer.cpp:
1595         (WebCore::XMLTokenizer::startElementNs):
1596
1597 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1598
1599         Reviewed by harrison
1600
1601         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
1602
1603         Pasting plain text results in a match style paste, and the insertion
1604         position is whitespace normal, which clobbers the whitespace:pre on
1605         tab spans.  Skip changes to the whitespace mode when computing a style
1606         change for tab spans or the text nodes inside tab spans.
1607
1608         * editing/ApplyStyleCommand.cpp:
1609         (WebCore::StyleChange::init): Don't change the whitespace mode inside
1610         tab spans.
1611
1612 2006-09-19  David Hyatt  <hyatt@apple.com>
1613
1614         Fix for bug 5298, shape=default not supported for image maps.  Implement
1615         support for it.
1616
1617         Reviewed by timo
1618
1619         * html/HTMLAreaElement.cpp:
1620         (WebCore::HTMLAreaElement::getRegion):
1621         * html/HTMLMapElement.cpp:
1622         (WebCore::HTMLMapElement::mapMouseEvent):
1623
1624 2006-09-19  Adam Roben  <aroben@apple.com>
1625
1626         Reviewed by Adele.
1627
1628         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10824
1629         "no file selected" placeholder text missing from file upload control
1630
1631         * WebCore.xcodeproj/project.pbxproj:
1632         * rendering/RenderFileUploadControl.cpp: Remove class
1633         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
1634         defaultWidthNumChars
1635         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
1636         RenderBlock constructor instead of RenderFlexibleBox,
1637         (WebCore::RenderFileUploadControl::setStyle): Remove references to
1638         m_fileBox.
1639         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
1640         instead of updateIconAndFileName() (which has been removed)
1641         (WebCore::RenderFileUploadControl::updateFromElement): Remove
1642         references to m_fileBox, don't call updateIconAndFilename()
1643         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
1644         without using m_fileBox
1645         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
1646         now-unnecessary display:box rule.
1647         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
1648         to paintingDisabled() now that Icon::paint() does it, and add code to
1649         paint the filename directly.
1650         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
1651         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
1652         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
1653         subclass of RenderBlock instead of RenderFlexibleBox, remove
1654         updateIconAndFilename() method, remove m_fileBox instance variable.
1655
1656 2006-09-19  Eric Seidel  <eric@eseidel.com>
1657
1658         Reviewed by hyatt.
1659
1660         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
1661         http://bugzilla.opendarwin.org/show_bug.cgi?id=10846
1662
1663         No automated test case possible until http://bugzilla.opendarwin.org/show_bug.cgi?id=10905 is resolved.
1664
1665         * dom/XMLTokenizer.cpp:
1666         (WebCore::XMLTokenizer::XMLTokenizer):
1667         (WebCore::XMLTokenizer::startElementNs):
1668         (WebCore::XMLTokenizer::endElementNs):
1669
1670 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
1671
1672         Reviewed by eseidel.  Landed by eseidel.
1673
1674         Build fix only, no tests affected.
1675
1676         * platform/gdk/FontPlatformDataGdk.cpp:
1677         (WebCore::FontPlatformData::FontPlatformData):
1678         (WebCore::FontPlatformData::~FontPlatformData):
1679         * platform/gdk/FrameGdk.h:
1680         * platform/gdk/TemporaryLinkStubs.cpp:
1681         (FrameGdk::isLoadTypeReload):
1682         (FrameGdk::originalRequestURL):
1683         (IconDatabase::setIconURLForPageURL):
1684
1685 2006-09-19  David Hyatt  <hyatt@apple.com>
1686
1687         Refine the fix for 9805 to really get all the complex cases right.
1688
1689         Reviewed by Eric
1690
1691         * rendering/RenderBlock.cpp:
1692         (WebCore::RenderBlock::clearFloatsIfNeeded):
1693         (WebCore::RenderBlock::handleBottomOfBlock):
1694
1695 2006-09-18  David Hyatt  <hyatt@apple.com>
1696
1697         Fix for 9805, <hr> not positioned properly following a previous empty sibling
1698         that had clear:both set on it.  Update self-collapsing block clearance
1699         behavior to match what is specified in the latest draft of CSS2.1.
1700
1701         Reviewed by Eric
1702
1703         Added fast/block/margin-collapse/empty-clear-blocks.html
1704
1705         * rendering/RenderBlock.cpp:
1706         (WebCore::RenderBlock::clearFloatsIfNeeded):
1707         (WebCore::RenderBlock::handleBottomOfBlock):
1708
1709 2006-09-18  MorganL  <morlmor@yahoo.com>
1710
1711         Reviewed by Brady, landed by Brady
1712
1713         Send receivedResponse callback to ResourceLoaderClient when loading
1714         file URLs.
1715
1716         See http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
1717
1718         * platform/win/ResourceLoaderWin.cpp:
1719         (WebCore::ResourceLoader::fileLoadTimer):
1720
1721 2006-09-18  Brady Eidson  <beidson@apple.com>
1722
1723         Reviewed by Anders
1724
1725         <rdar://problem/3028061> - WebKit never updates favicon
1726         The WebKit enforced expiration date for icons has worked for some time, but the
1727         move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
1728         functionality.  This patch fixes that up, along with some other architectural improvements,
1729         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
1730
1731         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
1732         * bridge/mac/FrameMac.mm:
1733         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
1734         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
1735         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
1736         * dom/Document.h: Added m_iconURL
1737         (WebCore::Document::iconURL): Added
1738         (WebCore::Document::setIconURL): Ditto
1739         * html/HTMLLinkElement.cpp:
1740         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
1741         * page/Frame.cpp:
1742         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
1743         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
1744         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
1745         * page/FramePrivate.h: Nuked IconURL
1746         * platform/win/TemporaryLinkStubs.cpp:
1747         (FrameWin::isLoadTypeReload):
1748
1749 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
1750
1751         Reviewed by Tim H.
1752
1753         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
1754           it is it turns out that AppKit uses it.
1755
1756         * bindings/objc/DOMPrivate.h:
1757         * bindings/objc/DOMRGBColor.mm:
1758         (-[DOMRGBColor _color]):
1759
1760 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
1761
1762         Reviewed by Tim H.
1763
1764         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
1765         Yet Another Objective-C Bindings Patch
1766
1767         - Whitespace cleanup for IDLParser.pm
1768
1769         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
1770           and DOMAbstractView into their own files.
1771
1772         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
1773           it is not used and a public method is available now.
1774
1775         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
1776           as it not used.
1777
1778         - Auto-generate method isContentEditable for DOMNode.
1779
1780         - General cleanup of bindings code including removing unneeded #imports
1781           and whitespace cleanup
1782
1783         * WebCore.xcodeproj/project.pbxproj:
1784         * bindings/objc/DOM.mm:
1785         (addElementClass):
1786         (elementClass):
1787         (-[DOMNode _initWithNode:WebCore::]):
1788         (+[DOMNode _nodeWith:WebCore::]):
1789         (-[DOMNode WebCore::]):
1790         (-[DOMNode KJS::Bindings::]):
1791         (-[DOMNode addEventListener:::]):
1792         (-[DOMNode removeEventListener:::]):
1793         (-[DOMNode dispatchEvent:]):
1794         (-[DOMElement image]):
1795         (-[DOMElement _font]):
1796         (-[DOMElement _imageTIFFRepresentation]):
1797         (-[DOMElement _getURLAttribute:]):
1798         (-[DOMElement _NPObject]):
1799         (-[DOMElement isFocused]):
1800         (-[DOMRange dealloc]):
1801         (-[DOMRange finalize]):
1802         (-[DOMRange description]):
1803         (-[DOMRange startContainer]):
1804         (-[DOMRange startOffset]):
1805         (-[DOMRange endContainer]):
1806         (-[DOMRange endOffset]):
1807         (-[DOMRange collapsed]):
1808         (-[DOMRange commonAncestorContainer]):
1809         (-[DOMRange setStart::]):
1810         (-[DOMRange setEnd::]):
1811         (-[DOMRange setStartBefore:]):
1812         (-[DOMRange setStartAfter:]):
1813         (-[DOMRange setEndBefore:]):
1814         (-[DOMRange setEndAfter:]):
1815         (-[DOMRange collapse:]):
1816         (-[DOMRange selectNode:]):
1817         (-[DOMRange selectNodeContents:]):
1818         (-[DOMRange compareBoundaryPoints::]):
1819         (-[DOMRange deleteContents]):
1820         (-[DOMRange extractContents]):
1821         (-[DOMRange cloneContents]):
1822         (-[DOMRange insertNode:]):
1823         (-[DOMRange surroundContents:]):
1824         (-[DOMRange cloneRange]):
1825         (-[DOMRange toString]):
1826         (-[DOMRange detach]):
1827         (-[DOMRange _initWithRange:WebCore::]):
1828         (+[DOMRange _rangeWith:WebCore::]):
1829         (-[DOMRange WebCore::]):
1830         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1831         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
1832         (-[DOMNodeFilter WebCore::]):
1833         (-[DOMNodeFilter dealloc]):
1834         (-[DOMNodeFilter finalize]):
1835         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
1836         (-[DOMNodeIterator WebCore::]):
1837         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
1838         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
1839         (-[DOMTreeWalker WebCore::]):
1840         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
1841         (ObjCNodeFilterCondition::acceptNode):
1842         (-[DOMDocument createNodeIterator::::]):
1843         (-[DOMDocument createTreeWalker::::]):
1844         (ObjCEventListener::find):
1845         (ObjCEventListener::create):
1846         (ObjCEventListener::handleEvent):
1847         * bindings/objc/DOMAbstractView.h: Added.
1848         * bindings/objc/DOMAbstractView.mm: Added.
1849         (-[DOMAbstractView document]):
1850         (-[DOMAbstractView WebCore::]):
1851         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
1852         (+[DOMAbstractView _abstractViewWith:WebCore::]):
1853         * bindings/objc/DOMCSS.mm:
1854         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1855         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
1856         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
1857         (-[DOMCSSRule _initWithRule:WebCore::]):
1858         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
1859         (-[DOMCSSValue _initWithValue:WebCore::]):
1860         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1861         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
1862         (-[DOMDocument getComputedStyle::]):
1863         (-[DOMDocument getMatchedCSSRules::]):
1864         * bindings/objc/DOMCore.h:
1865         * bindings/objc/DOMEventException.h: Added.
1866         * bindings/objc/DOMEvents.h:
1867         * bindings/objc/DOMEvents.mm:
1868         * bindings/objc/DOMException.h: Added.
1869         * bindings/objc/DOMHTML.mm:
1870         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
1871         (viewForElement):
1872         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
1873         (-[DOMHTMLInputElement _selectedRange]):
1874         (-[DOMHTMLInputElement _setAutofilled:]):
1875         * bindings/objc/DOMInternal.h:
1876         * bindings/objc/DOMObject.h:
1877         * bindings/objc/DOMPrivate.h:
1878         * bindings/objc/DOMRange.h:
1879         * bindings/objc/DOMRangeException.h: Added.
1880         * bindings/objc/DOMViews.h:
1881         * bindings/objc/DOMViews.mm: Removed.
1882         * bindings/objc/DOMXPath.h:
1883         * bindings/objc/DOMXPathException.h: Added.
1884         * bindings/scripts/IDLParser.pm:
1885         * dom/Node.idl:
1886
1887 2006-09-18  Brady Eidson  <beidson@apple.com>
1888
1889         Windows build fix
1890
1891         * platform/win/TemporaryLinkStubs.cpp:
1892         (IconDatabase::setIconURLForPageURL):
1893
1894 2006-09-18  David Hyatt  <hyatt@apple.com>
1895
1896         Fix for bug 3969, hr width doesn't update when it clears a float.  This
1897         was also a problem with tables and overflow sections.
1898
1899         Reviewed by Eric
1900
1901         Added fast/block/float/width-update-after-clear.html
1902
1903         * rendering/RenderBlock.cpp:
1904         (WebCore::RenderBlock::collapseMargins):
1905         (WebCore::RenderBlock::clearFloatsIfNeeded):
1906
1907 2006-09-18  Brady Eidson  <beidson@apple.com>
1908
1909         Reviewed by John
1910
1911         http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
1912         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
1913
1914         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
1915         * bridge/win/FrameWin.h: Added originalRequestURL()
1916         * loader/icon/IconLoader.cpp:
1917         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
1918         * page/Frame.cpp:
1919         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
1920         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
1921         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
1922         * page/Frame.h: Added pure virtual originalRequestURL()
1923         * platform/win/TemporaryLinkStubs.cpp:
1924         (FrameWin::originalRequestURL): Added
1925
1926 2006-09-18  Rob Buis  <buis@kde.org>
1927
1928         Reviewed by Maciej.
1929
1930         http://bugzilla.opendarwin.org/show_bug.cgi?id=10807
1931         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
1932
1933         Make sure the paint method is not exited without popping
1934         context and transparency layer.
1935
1936         WARNING: NO TEST CASES ADDED OR CHANGED
1937
1938         * kcanvas/RenderSVGImage.cpp:
1939         (WebCore::RenderSVGImage::paint):
1940
1941 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
1942
1943         Reviewed by Eric.
1944
1945         - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10896
1946         REGRESSION: WebKit can't be built with SVG disabled
1947
1948         * bindings/scripts/CodeGeneratorObjC.pm:
1949         For each file generated add a #ifdef <something>_SUPPORT / #endif
1950         pair if the idl file has a Conditional extended attribute
1951
1952 2006-09-17  Eric Seidel  <eric@eseidel.com>
1953
1954         Reviewed by ap.
1955
1956         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
1957         http://bugzilla.opendarwin.org/show_bug.cgi?id=10813
1958
1959         * bridge/mac/WebCoreFrameBridge.mm:
1960         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
1961
1962 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
1963
1964         Reviewed by Hyatt.
1965
1966         http://bugzilla.opendarwin.org/show_bug.cgi?id=10779
1967         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
1968
1969         No test possible.
1970
1971         * platform/Image.cpp:
1972         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
1973         maybe the rest just hasn't been loaded yet.
1974         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
1975         to start animating before we get at least two frames.
1976
1977 2006-09-17  Brady Eidson <beidson@apple.com>
1978
1979         Reviewed by Sarge
1980
1981         IconLoader now gracefully handles the condition where there's no document in the frame
1982         (ie. PDFs)
1983
1984         * loader/icon/IconLoader.cpp:
1985         (IconLoader::startLoading):
1986
1987 2006-09-17  David Hyatt  <hyatt@apple.com>
1988
1989         Fix for bug 10899, rework how CSS keywords work to be smarter about
1990         using the correct size when generic families change (e.g., monospace to
1991         serif and vice versa).
1992
1993         Reviewed by aroben
1994
1995         Added fast/text/basic/generic-family-changes.html
1996
1997         * css/cssstyleselector.cpp:
1998         (WebCore::CSSStyleSelector::applyProperty):
1999         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
2000         (WebCore::CSSStyleSelector::fontSizeForKeyword):
2001         * css/cssstyleselector.h:
2002         * dom/Document.cpp:
2003         (WebCore::Document::recalcStyle):
2004         * platform/FontDescription.h:
2005         (WebCore::FontDescription::FontDescription):
2006         (WebCore::FontDescription::keywordSize):
2007         (WebCore::FontDescription::setKeywordSize):
2008         (WebCore::FontDescription::operator==):
2009
2010 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
2011
2012         Reviewed by Brady.
2013
2014         http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
2015         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
2016
2017         Test: http/tests/xmlhttprequest/xhr-onunload.html
2018
2019         * xml/xmlhttprequest.cpp:
2020         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
2021
2022         * loader/icon/IconLoader.cpp:
2023         (IconLoader::startLoading): Fix a similar latent bug here.
2024
2025 2006-09-17  Adam Roben  <aroben@apple.com>
2026
2027         Build fix.
2028
2029         * loader/icon/IconDatabase.cpp:
2030
2031 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
2032
2033         Reviewed by Brady.
2034
2035         Add simplifyWhiteSpace and stripWhiteSpace to the String class.
2036         Change the XSLT Parameter Map to use Strings instead of StringImpls.
2037         General cleanup.
2038
2039         * bindings/js/JSXSLTProcessor.cpp:
2040         (KJS::XSLTProcessorProtoFunc::callAsFunction):
2041         * bindings/js/kjs_events.cpp:
2042         (KJS::JSAbstractEventListener::handleEvent):
2043         * bindings/js/kjs_window.cpp:
2044         (KJS::ScheduledAction::execute):
2045         * css/MediaList.cpp:
2046         (WebCore::MediaList::setMediaText):
2047         * dom/Document.cpp:
2048         (WebCore::Document::processHttpEquiv):
2049         * editing/ApplyStyleCommand.cpp:
2050         (WebCore::StyleChange::init):
2051         * html/HTMLDocument.cpp:
2052         (WebCore::parseDocTypeDeclaration):
2053         * html/HTMLLinkElement.cpp:
2054         (WebCore::HTMLLinkElement::parseMappedAttribute):
2055         * html/HTMLObjectElement.cpp:
2056         (WebCore::HTMLObjectElement::HTMLObjectElement):
2057         (WebCore::HTMLObjectElement::parseMappedAttribute):
2058         (WebCore::HTMLObjectElement::attach):
2059         (WebCore::HTMLObjectElement::setComplete):
2060         (WebCore::HTMLObjectElement::detach):
2061         (WebCore::HTMLObjectElement::recalcStyle):
2062         (WebCore::HTMLObjectElement::childrenChanged):
2063         (WebCore::HTMLObjectElement::isImageType):
2064         * html/HTMLObjectElement.h:
2065         * html/HTMLOptionElement.cpp:
2066         (WebCore::HTMLOptionElement::value):
2067         * html/HTMLSelectElement.cpp:
2068         (WebCore::HTMLSelectElement::appendFormData):
2069         * html/HTMLTokenizer.cpp:
2070         (WebCore::HTMLTokenizer::parseTag):
2071         * ksvg2/svg/SVGColor.cpp:
2072         (WebCore::SVGColor::setRGBColor):
2073         * ksvg2/svg/SVGDescElement.cpp:
2074         (WebCore::SVGDescElement::description):
2075         * platform/PlatformString.h:
2076         * platform/String.cpp:
2077         (WebCore::String::stripWhiteSpace):
2078         (WebCore::String::simplifyWhiteSpace):
2079         * platform/StringImpl.cpp:
2080         (WebCore::isSpace):
2081         (WebCore::parseLength):
2082         (WebCore::StringImpl::stripWhiteSpace):
2083         (WebCore::StringImpl::simplifyWhiteSpace):
2084         (WebCore::StringImpl::toInt):
2085         * platform/StringImpl.h:
2086         * platform/mac/ClipboardMac.mm:
2087         (WebCore::cocoaTypeFromMIMEType):
2088         * rendering/RenderPartObject.cpp:
2089         (WebCore::RenderPartObject::updateWidget):
2090         * xml/XPathFunctions.cpp:
2091         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
2092         * xml/XPathGrammar.y:
2093         * xml/XPathStep.cpp:
2094         (WebCore::XPath::Step::nodeTestMatches):
2095         * xml/XSLStyleSheet.cpp:
2096         (WebCore::XSLStyleSheet::loadChildSheets):
2097         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
2098         * xml/XSLTProcessor.cpp:
2099         (WebCore::xsltParamArrayFromParameterMap):
2100         (WebCore::XSLTProcessor::setParameter):
2101         (WebCore::XSLTProcessor::getParameter):
2102         (WebCore::XSLTProcessor::removeParameter):
2103         * xml/XSLTProcessor.h:
2104         * xml/xmlhttprequest.cpp:
2105         (WebCore::XMLHttpRequest::getStatusText):
2106
2107 2006-09-17  David Hyatt  <hyatt@apple.com>
2108
2109         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
2110         are declared right before the fieldsets.  It turns out fieldsets in other
2111         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
2112         adding that behavior to fieldset fixes the bug.
2113
2114         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
2115         and fieldsets all subclass.
2116
2117         Reviewed by anders
2118
2119         Added fast/forms/float-before-fieldset.html
2120
2121         * rendering/RenderFieldset.h:
2122         (WebCore::RenderFieldset::avoidsFloats):
2123         * rendering/RenderFlexibleBox.h:
2124         (WebCore::RenderFlexibleBox::avoidsFloats):
2125         * rendering/RenderObject.cpp:
2126         (WebCore::RenderObject::avoidsFloats):
2127         * rendering/RenderObject.h:
2128         * rendering/RenderTable.h:
2129         (WebCore::RenderTable::avoidsFloats):
2130
2131 2006-09-17  David Hyatt  <hyatt@apple.com>
2132
2133         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
2134         "rules" attributes on tables.
2135
2136         Reviewed by bradee-oh
2137
2138         Well-covered by existing layout tests.
2139
2140         * html/HTMLTableCellElement.cpp:
2141         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
2142         * html/HTMLTableColElement.cpp:
2143         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
2144         * html/HTMLTableColElement.h:
2145         * html/HTMLTableElement.cpp:
2146         (WebCore::HTMLTableElement::HTMLTableElement):
2147         (WebCore::HTMLTableElement::~HTMLTableElement):
2148         (WebCore::HTMLTableElement::setCaption):
2149         (WebCore::HTMLTableElement::setTHead):
2150         (WebCore::HTMLTableElement::setTFoot):
2151         (WebCore::HTMLTableElement::setTBody):
2152         (WebCore::HTMLTableElement::createTHead):
2153         (WebCore::HTMLTableElement::deleteTHead):
2154         (WebCore::HTMLTableElement::createTFoot):
2155         (WebCore::HTMLTableElement::deleteTFoot):
2156         (WebCore::HTMLTableElement::createCaption):
2157         (WebCore::HTMLTableElement::deleteCaption):
2158         (WebCore::HTMLTableElement::insertRow):
2159         (WebCore::HTMLTableElement::deleteRow):
2160         (WebCore::HTMLTableElement::addChild):
2161         (WebCore::HTMLTableElement::childrenChanged):
2162         (WebCore::HTMLTableElement::mapToEntry):
2163         (WebCore::HTMLTableElement::parseMappedAttribute):
2164         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
2165         (WebCore::HTMLTableElement::getSharedCellDecl):
2166         (WebCore::HTMLTableElement::getSharedGroupDecl):
2167         (WebCore::HTMLTableElement::attach):
2168         * html/HTMLTableElement.h:
2169         (WebCore::HTMLTableElement::caption):
2170         (WebCore::HTMLTableElement::tHead):
2171         (WebCore::HTMLTableElement::tFoot):
2172         (WebCore::HTMLTableElement::):
2173         * html/HTMLTableRowElement.h:
2174         * html/HTMLTableSectionElement.cpp:
2175         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
2176         * html/HTMLTableSectionElement.h:
2177
2178 2006-09-17  David Hyatt  <hyatt@apple.com>
2179
2180         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
2181         specify their own new font-family list.  Make sure to always
2182         reset the generic family along with the family list when mapping in
2183         new font-family values.
2184
2185         Reviewed by bradee-oh
2186
2187         fast/text/basic/generic-family-reset.html
2188
2189         * css/cssstyleselector.cpp:
2190         (WebCore::CSSStyleSelector::applyProperty):
2191
2192 2006-09-16  Brady Eidson <beidson@apple.com>
2193
2194         Reviewed by Hyatt
2195
2196         Pruning code relating to WebKit's icon loader
2197
2198         * bridge/mac/WebCoreIconDatabaseBridge.h:
2199         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2200         * loader/icon/IconDatabase.h:
2201         * page/Frame.cpp:
2202         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to
2203         its new home
2204
2205 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
2206
2207         Reviewed by Tim H.
2208
2209         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10885
2210         Auto-generate DOMHTMLDocument for the Objective-C bindings
2211
2212         * DerivedSources.make:
2213         * WebCore.xcodeproj/project.pbxproj:
2214         * bindings/objc/DOMExtensions.h:
2215         * bindings/objc/DOMHTML.mm:
2216         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
2217         * bindings/objc/DOMHTMLDocument.h: Removed.
2218         * bindings/objc/DOMHTMLDocument.mm: Removed.
2219         * bindings/objc/PublicDOMInterfaces.h:
2220         * bindings/scripts/CodeGeneratorObjC.pm:
2221         * html/HTMLDocument.idl:
2222         * platform/DeprecatedString.h:
2223         (WebCore::DeprecatedString::operator NSString*):
2224
2225 2006-09-16  Rob Buis  <buis@kde.org>
2226
2227         Reviewed by Eric.
2228
2229         http://bugzilla.opendarwin.org/show_bug.cgi?id=10866
2230         Code in kcanvas/ should not use Private
2231
2232         Remove Private classes and tweak coding style.
2233
2234         WARNING: NO TEST CASES ADDED OR CHANGED
2235
2236         * kcanvas/RenderPath.cpp:
2237         (WebCore::RenderPath::RenderPath):
2238         (WebCore::RenderPath::~RenderPath):
2239         (WebCore::RenderPath::localTransform):
2240         (WebCore::RenderPath::setLocalTransform):
2241         (WebCore::RenderPath::fillContains):
2242         (WebCore::RenderPath::relativeBBox):
2243         (WebCore::RenderPath::setPath):
2244         (WebCore::RenderPath::path):
2245         (WebCore::RenderPath::layout):
2246         * kcanvas/RenderPath.h:
2247         * kcanvas/RenderSVGContainer.cpp:
2248         (WebCore::RenderSVGContainer::RenderSVGContainer):
2249         (WebCore::RenderSVGContainer::~RenderSVGContainer):
2250         (WebCore::RenderSVGContainer::drawsContents):
2251         (WebCore::RenderSVGContainer::setDrawsContents):
2252         (WebCore::RenderSVGContainer::localTransform):
2253         (WebCore::RenderSVGContainer::setLocalTransform):
2254         (WebCore::RenderSVGContainer::layout):
2255         (WebCore::RenderSVGContainer::paint):
2256         (WebCore::RenderSVGContainer::setViewport):
2257         (WebCore::RenderSVGContainer::viewport):
2258         (WebCore::RenderSVGContainer::setViewBox):
2259         (WebCore::RenderSVGContainer::viewBox):
2260         (WebCore::RenderSVGContainer::setAlign):
2261         (WebCore::RenderSVGContainer::align):
2262         (WebCore::RenderSVGContainer::fillContains):
2263         (WebCore::RenderSVGContainer::strokeContains):
2264         (WebCore::RenderSVGContainer::setSlice):
2265         (WebCore::RenderSVGContainer::slice):
2266         * kcanvas/RenderSVGContainer.h:
2267         * kcanvas/device/KRenderingFillPainter.cpp:
2268         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
2269         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
2270         (WebCore::KRenderingFillPainter::fillRule):
2271         (WebCore::KRenderingFillPainter::setFillRule):
2272         (WebCore::KRenderingFillPainter::opacity):
2273         (WebCore::KRenderingFillPainter::setOpacity):
2274         * kcanvas/device/KRenderingFillPainter.h:
2275         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2276         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
2277         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
2278         (WebCore::KRenderingPaintServerGradient::gradientStops):
2279         (WebCore::KRenderingPaintServerGradient::setGradientStops):
2280         (WebCore::KRenderingPaintServerGradient::spreadMethod):
2281         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
2282         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
2283         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
2284         (WebCore::KRenderingPaintServerGradient::gradientTransform):
2285         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
2286         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
2287         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
2288         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
2289         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
2290         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
2291         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
2292         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
2293         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
2294         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
2295         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
2296         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
2297         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
2298         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
2299         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
2300         (WebCore::KRenderingPaintServerGradient::listener):
2301         (WebCore::KRenderingPaintServerGradient::setListener):
2302         * kcanvas/device/KRenderingPaintServerGradient.h:
2303         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2304         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
2305         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
2306         (WebCore::KRenderingPaintServerPattern::setBbox):
2307         (WebCore::KRenderingPaintServerPattern::bbox):
2308         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
2309         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
2310         (WebCore::KRenderingPaintServerPattern::tile):
2311         (WebCore::KRenderingPaintServerPattern::setTile):
2312         (WebCore::KRenderingPaintServerPattern::patternTransform):
2313         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
2314         (WebCore::KRenderingPaintServerPattern::listener):
2315         (WebCore::KRenderingPaintServerPattern::setListener):
2316         * kcanvas/device/KRenderingPaintServerPattern.h:
2317         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2318         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
2319         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
2320         (WebCore::KRenderingPaintServerSolid::color):
2321         (WebCore::KRenderingPaintServerSolid::setColor):
2322         * kcanvas/device/KRenderingPaintServerSolid.h:
2323         * kcanvas/device/KRenderingStrokePainter.cpp:
2324         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
2325         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
2326         (WebCore::KRenderingStrokePainter::strokeWidth):
2327         (WebCore::KRenderingStrokePainter::setStrokeWidth):
2328         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2329         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2330         (WebCore::KRenderingStrokePainter::strokeCapStyle):
2331         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
2332         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
2333         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
2334         (WebCore::KRenderingStrokePainter::dashOffset):
2335         (WebCore::KRenderingStrokePainter::setDashOffset):
2336         (WebCore::KRenderingStrokePainter::dashArray):
2337         (WebCore::KRenderingStrokePainter::setDashArray):
2338         (WebCore::KRenderingStrokePainter::opacity):
2339         (WebCore::KRenderingStrokePainter::setOpacity):
2340         (WebCore::KRenderingStrokePainter::dirty):
2341         (WebCore::KRenderingStrokePainter::setDirty):
2342         * kcanvas/device/KRenderingStrokePainter.h:
2343
2344 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
2345
2346         Reviewed by Anders.
2347
2348         http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
2349         Fix build error
2350
2351         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
2352
2353 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
2354
2355         Reviewed by Anders.
2356
2357         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10886
2358         REGRESSION (r16387): Reproducible crash when mousing over HTML document
2359
2360         - Special case method [DOMNode ownerDocument] to call document() instead
2361           or ownerDocument() to return to the old behavior.
2362
2363         * WebCore.xcodeproj/project.pbxproj:
2364         * bindings/scripts/CodeGeneratorObjC.pm:
2365
2366 2006-09-15  Brady Eidson  <beidson@apple.com>
2367
2368         Reviewed by Tim Hatcher
2369
2370         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
2371         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
2372
2373         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
2374         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
2375         (WebCore::IconDatabase::open): Make sure the directory exists
2376
2377 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2378
2379         Reviewed by Brady.
2380
2381         Make new style ObjC methods public API.
2382
2383         * WebCore.xcodeproj/project.pbxproj:
2384         * bindings/objc/DOMPrivate.h:
2385         * bindings/objc/PublicDOMInterfaces.h:
2386
2387 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
2388
2389         Reviewed by Tim H.
2390
2391         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
2392         Auto-generate DOMNode for the Objective-C bindings
2393
2394         * DerivedSources.make:
2395         * WebCore.xcodeproj/project.pbxproj:
2396         * bindings/objc/DOM.mm:
2397         (-[DOMNode boundingBox]):
2398         (-[DOMNode lineBoxRects]):
2399         * bindings/objc/DOMEvents.h:
2400         * bindings/objc/DOMExtensions.h:
2401         * bindings/objc/DOMNode.h: Removed.
2402         * bindings/objc/DOMNode.mm: Removed.
2403         * bindings/objc/PublicDOMInterfaces.h:
2404         * bindings/scripts/CodeGeneratorObjC.pm:
2405         * dom/Node.idl:
2406
2407 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2408
2409         Reviewed by Justin.
2410
2411         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
2412
2413         * bridge/mac/WebCoreFrameBridge.h:
2414         * bridge/mac/WebCoreFrameBridge.mm:
2415         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
2416         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
2417         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
2418         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
2419         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
2420         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
2421         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2422         (-[WebCoreFrameBridge increaseSelectionListLevel]):
2423         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
2424         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
2425         (-[WebCoreFrameBridge decreaseSelectionListLevel]):
2426         (-[WebCoreFrameBridge insertLineBreak]):
2427         (-[WebCoreFrameBridge insertParagraphSeparator]):
2428         (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
2429         (-[WebCoreFrameBridge insertText:selectInsertedText:]):
2430         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
2431         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
2432         (createMouseEventFromDraggingInfo):
2433         * editing/SelectionController.cpp:
2434         (WebCore::SelectionController::moveTo):
2435         (WebCore::SelectionController::setSelection):
2436         (WebCore::SelectionController::modify):
2437         (WebCore::SelectionController::setBase):
2438         (WebCore::SelectionController::setExtent):
2439         * editing/SelectionController.h:
2440         * page/Frame.cpp:
2441         (WebCore::Frame::revealSelection):
2442         (WebCore::Frame::revealCaret):
2443         * page/Frame.h:
2444
2445 2006-09-15  Brady Eidson  <beidson@apple.com>
2446
2447         Reviewed by Anders
2448
2449         Added the ability to get a mutable char* from a CString, which will copy the internal
2450         buffer if the ref count is greater than 1 so your mutable char* won't affect any other
2451         referrer of that buffer.
2452
2453         * platform/CString.cpp:
2454         (WebCore::CString::mutableData):
2455         (WebCore::CString::copyBufferIfNeeded):
2456         * platform/CString.h:
2457
2458 2006-09-15  Justin Garcia  <justin.garcia@apple.com>
2459
2460         Reviewed by harrison
2461
2462         <rdar://problem/4674869>
2463         REGRESSION: selecting text to write over results in cursor jumping to middle of next line
2464
2465         * editing/SelectionController.cpp:
2466         (WebCore::SelectionController::modify): Added lineBoundary to test fix.
2467         * editing/visible_units.cpp:
2468         (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
2469         position before it, not after it.
2470
2471 2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2472
2473         Reviewed by Adam.
2474
2475         http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
2476         Bug 10864: Linux\GDK build fixes
2477
2478         * Projects/gdk/webcore-gdk.bkl:
2479         * WebCoreSources.bkl:
2480         * platform/gdk/FontCacheGdk.cpp:
2481         * platform/gdk/FontDataGdk.cpp:
2482         (WebCore::FontData::platformInit):
2483         * platform/gdk/FontGdk.cpp:
2484         (WebCore::Font::drawGlyphs):
2485         * platform/gdk/FrameGdk.cpp:
2486         (WebCore::FrameGdk::handleGdkEvent):
2487         * platform/gdk/FrameGdk.h:
2488         * platform/gdk/ImageGdk.cpp: Added.
2489         (WebCore::Image::initPlatformData):
2490         (WebCore::Image::invalidatePlatformData):
2491         (WebCore::Image::loadPlatformResource):
2492         (WebCore::Image::supportsType):
2493         * platform/gdk/RenderPopupMenuGdk.cpp:
2494         (WebCore::RenderPopupMenuGdk::hidePopup):
2495         * platform/gdk/RenderPopupMenuGdk.h:
2496         * platform/gdk/ScreenGdk.cpp:
2497         (WebCore::drawableForPage):
2498         (WebCore::screenRect):
2499         (WebCore::screenDepth):
2500         (WebCore::usableScreenRect):
2501         (WebCore::scaleFactor):
2502         * platform/gdk/SystemTimeLinux.cpp:
2503         (WebCore::currentTime):
2504         * platform/gdk/TemporaryLinkStubs.cpp:
2505         (FrameGdk::bindingRootObject):
2506         (FrameGdk::markMisspellings):
2507         (WebCore::screenDepthPerComponent):
2508         (WebCore::screenIsMonochrome):
2509         (WebCore::fileButtonChooseFileLabel):
2510         (WebCore::fileButtonNoFileSelectedLabel):
2511         (FrameGdk::shouldChangeSelection):
2512         (FrameGdk::respondToChangedSelection):
2513         (FrameGdk::respondToChangedContents):
2514         (Path::contains):
2515         (PlatformScrollBar::PlatformScrollBar):
2516         (PlatformScrollBar::~PlatformScrollBar):
2517         (PlatformScrollBar::width):
2518         (PlatformScrollBar::height):
2519         (PlatformScrollBar::setEnabled):
2520         (PlatformScrollBar::paint):
2521         (PlatformScrollBar::setScrollBarValue):
2522         (PlatformScrollBar::setKnobProportion):
2523         (PlatformScrollBar::setRect):
2524         (ScrollBar::ScrollBar):
2525         (FileChooser::FileChooser):
2526         (FileChooser::~FileChooser):
2527         (FileChooser::openFileChooser):
2528         (FileChooser::basenameForWidth):
2529         (FileChooser::uploadControlDetaching):
2530         (FileChooser::chooseFile):
2531         (Icon::Icon):
2532         (Icon::~Icon):
2533         (Icon::newIconForFile):
2534         (Icon::paint):
2535         (IconLoader::stopLoading):
2536         (IconLoader::startLoading):
2537         (IconLoader::createForFrame):
2538         (IconDatabase::isIconExpiredForIconURL):
2539         (IconDatabase::hasEntryForIconURL):
2540         (IconDatabase::sharedIconDatabase):
2541         * platform/gdk/WidgetGdk.cpp:
2542         * webcore-base.bkl:
2543
2544 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
2545
2546         Reviewed by Eric.
2547
2548         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
2549         Fix svg memory leaks.
2550
2551         Reworked SVGList to deal with RefPtr's for ptr types
2552         which makes manual refcounting unnecessary, and is much safer.
2553
2554         Removing all virtual functions (nullItem) from SVGList, and
2555         also remove SVGListBase. Switch to a similar concept like
2556         Vector/VectorTraits (see new file SVGListTraits.h).
2557
2558         Credits go to Eric/Maciej for the inspiration.
2559
2560         * CMakeLists.txt: Add SVGListTraits.cpp to build
2561         * WebCore.xcodeproj/project.pbxproj: Ditto.
2562         * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
2563         * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
2564         (WebCore::RenderSVGText::translationForAttributes):
2565         * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
2566         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2567         * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
2568         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
2569         * ksvg2/svg/SVGElementInstanceList.h:
2570         * ksvg2/svg/SVGLengthList.cpp: Ditto.
2571         (WebCore::SVGLengthList::SVGLengthList):
2572         * ksvg2/svg/SVGLengthList.h: Ditto.
2573         * ksvg2/svg/SVGList.h: Rewrote, as described above.
2574         (WebCore::SVGListTypeOperations::nullItem):
2575         (WebCore::SVGList::SVGList):
2576         (WebCore::SVGList::~SVGList):
2577         (WebCore::SVGList::clear):
2578         (WebCore::SVGList::getFirst):
2579         (WebCore::SVGList::getLast):
2580         (WebCore::SVGList::getItem):
2581         (WebCore::SVGList::replaceItem):
2582         (WebCore::SVGList::removeItem):
2583         * ksvg2/svg/SVGListTraits.cpp: Added.
2584         * ksvg2/svg/SVGListTraits.h: Added.
2585         (WebCore::):
2586         * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
2587         (WebCore::SVGPathElement::toPathData):
2588         * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
2589         (WebCore::SVGPathSegList::SVGPathSegList):
2590         * ksvg2/svg/SVGPathSegList.h: Ditto.
2591         * ksvg2/svg/SVGTransform.cpp: Style cleanup.
2592         (SVGTransform::SVGTransform):
2593         * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
2594         (SVGTransformList::SVGTransformList):
2595         (SVGTransformList::createSVGTransformFromMatrix):
2596         (SVGTransformList::consolidate):
2597         * ksvg2/svg/SVGTransformList.h: Ditto.
2598         * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
2599         (SVGTransformable::parseTransformAttribute):
2600
2601 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
2602
2603         Reviewed by eseidel.  Landed by eseidel.
2604
2605         Fix build on Qt/Linux and implement Frame::addMessageToConsole to
2606         be able to see javascript errors for instance.
2607
2608         * CMakeLists.txt:
2609         * platform/qt/FrameQt.h:
2610         * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
2611         (WebCore::FrameQt::bindingRootObject):
2612         * platform/qt/TemporaryLinkStubs.cp
2613         (WebCore::IconDatabase::hasEntryForIconURL):
2614         (WebCore::IconDatabase::sharedIconDatabase):
2615
2616 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
2617
2618         Reviewed by Tim H.
2619
2620         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10869
2621         Auto-generate the internal methods for the Objective-C bindings
2622
2623         - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
2624           implementations where standard.  For cases where a custom implementation was
2625           needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
2626
2627         - Some general cleanup of some of the non-generated bindings, to bring them in-
2628           line with what the generated bindings look like.
2629
2630         * bindings/objc/DOM.mm:
2631         (-[DOMNode description]):
2632         * bindings/objc/DOMCSS.mm:
2633         (-[DOMCSSPrimitiveValue WebCore::]):
2634         (-[DOMDocument getComputedStyle::]):
2635         (-[DOMDocument getMatchedCSSRules::]):
2636         * bindings/objc/DOMEvents.mm:
2637         (-[DOMEvent WebCore::]):
2638         * bindings/objc/DOMHTML.mm:
2639         * bindings/objc/DOMHTMLDocument.mm:
2640         (-[DOMHTMLDocument title]):
2641         (-[DOMHTMLDocument setTitle:]):
2642         (-[DOMHTMLDocument referrer]):
2643         (-[DOMHTMLDocument domain]):
2644         (-[DOMHTMLDocument URL]):
2645         (-[DOMHTMLDocument body]):
2646         (-[DOMHTMLDocument setBody:]):
2647         (-[DOMHTMLDocument images]):
2648         (-[DOMHTMLDocument applets]):
2649         (-[DOMHTMLDocument links]):
2650         (-[DOMHTMLDocument forms]):
2651         (-[DOMHTMLDocument anchors]):
2652         (-[DOMHTMLDocument cookie]):
2653         (-[DOMHTMLDocument setCookie:]):
2654         (-[DOMHTMLDocument open]):
2655         (-[DOMHTMLDocument close]):
2656         (-[DOMHTMLDocument write:]):
2657         (-[DOMHTMLDocument writeln:]):
2658         (-[DOMHTMLDocument getElementById:]):
2659         (-[DOMHTMLDocument getElementsByName:]):
2660         (-[DOMHTMLDocument WebCore::]):
2661         (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
2662         * bindings/objc/DOMHTMLOptionElement.mm:
2663         (-[DOMHTMLOptionElement form]):
2664         (-[DOMHTMLOptionElement defaultSelected]):
2665         (-[DOMHTMLOptionElement setDefaultSelected:]):
2666         (-[DOMHTMLOptionElement text]):
2667         (-[DOMHTMLOptionElement index]):
2668         (-[DOMHTMLOptionElement disabled]):
2669         (-[DOMHTMLOptionElement setDisabled:]):
2670         (-[DOMHTMLOptionElement label]):
2671         (-[DOMHTMLOptionElement setLabel:]):
2672         (-[DOMHTMLOptionElement selected]):
2673         (-[DOMHTMLOptionElement setSelected:]):
2674         (-[DOMHTMLOptionElement value]):
2675         (-[DOMHTMLOptionElement setValue:]):
2676         (-[DOMHTMLOptionElement WebCore::]):
2677         (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
2678         * bindings/objc/DOMInternal.h:
2679         * bindings/objc/DOMNode.mm:
2680         (-[DOMNode dealloc]):
2681         (-[DOMNode finalize]):
2682         (-[DOMNode nodeName]):
2683         (-[DOMNode nodeValue]):
2684         (-[DOMNode setNodeValue:]):
2685         (-[DOMNode nodeType]):
2686         (-[DOMNode parentNode]):
2687         (-[DOMNode childNodes]):
2688         (-[DOMNode firstChild]):
2689         (-[DOMNode lastChild]):
2690         (-[DOMNode previousSibling]):
2691         (-[DOMNode nextSibling]):
2692         (-[DOMNode attributes]):
2693         (-[DOMNode ownerDocument]):
2694         (-[DOMNode insertBefore::]):
2695         (-[DOMNode replaceChild::]):
2696         (-[DOMNode removeChild:]):
2697         (-[DOMNode appendChild:]):
2698         (-[DOMNode hasChildNodes]):
2699         (-[DOMNode cloneNode:]):
2700         (-[DOMNode normalize]):
2701         (-[DOMNode isSupported::]):
2702         (-[DOMNode namespaceURI]):
2703         (-[DOMNode prefix]):
2704         (-[DOMNode setPrefix:]):
2705         (-[DOMNode localName]):
2706         (-[DOMNode hasAttributes]):
2707         (-[DOMNode isSameNode:]):
2708         (-[DOMNode isEqualNode:]):
2709         (-[DOMNode isDefaultNamespace:]):
2710         (-[DOMNode lookupPrefix:]):
2711         (-[DOMNode lookupNamespaceURI:]):
2712         (-[DOMNode textContent]):
2713         (-[DOMNode setTextContent:]):
2714         (-[DOMNode boundingBox]):
2715         (-[DOMNode lineBoxRects]):
2716         * bindings/objc/DOMObject.mm:
2717         (-[DOMObject _init]):
2718         * bindings/objc/DOMXPath.mm:
2719         (-[DOMNativeXPathNSResolver dealloc]):
2720         (-[DOMNativeXPathNSResolver finalize]):
2721         (-[DOMNativeXPathNSResolver WebCore::]):
2722         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
2723         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
2724         (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
2725         * bindings/scripts/CodeGeneratorObjC.pm:
2726         * bridge/mac/WebCoreFrameBridge.mm:
2727         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2728         (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
2729         * css/CSSCharsetRule.idl:
2730         * css/CSSFontFaceRule.idl:
2731         * css/CSSImportRule.idl:
2732         * css/CSSMediaRule.idl:
2733         * css/CSSPageRule.idl:
2734         * css/CSSPrimitiveValue.idl:
2735         * css/CSSRule.idl:
2736         * css/CSSStyleRule.idl:
2737         * css/CSSStyleSheet.idl:
2738         * css/CSSUnknownRule.idl:
2739         * css/CSSValue.idl:
2740         * css/CSSValueList.idl:
2741         * css/StyleSheet.idl:
2742         * dom/Event.idl:
2743         * dom/KeyboardEvent.idl:
2744         * dom/MouseEvent.idl:
2745         * dom/MutationEvent.idl:
2746         * dom/NodeIterator.idl:
2747         * dom/OverflowEvent.idl:
2748         * dom/TreeWalker.idl:
2749         * dom/UIEvent.idl:
2750         * dom/WheelEvent.idl:
2751
2752 2006-09-15  Adam Roben  <aroben@apple.com>
2753
2754         Reviewed by timothy.
2755
2756         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
2757         New file upload control should match the width of the old one
2758
2759         Make width of new file upload control match the old one as closely as
2760         possible.
2761
2762         * rendering/RenderFileUploadControl.cpp:
2763
2764 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2765
2766         Reviewed by Eric.
2767
2768         Remove the SVG IDL files from the Copy Resources phase.
2769
2770         * WebCore.xcodeproj/project.pbxproj:
2771
2772 2006-09-15  Brady Eidson  <beidson@apple.com>
2773
2774         Reviewed by Eric Siedel
2775
2776         Dumped the use of CGColorRef and directly use the floating point data from
2777         WebCore::Color
2778
2779         This fixes the performance regression found between 16285 and 16286
2780
2781         * platform/mac/FontMac.mm:
2782         (WebCore::Font::drawComplexText):
2783         (WebCore::Font::drawGlyphs):
2784
2785 2006-09-14  Mark Rowe  <opendarwin.org@bdash.net.nz>
2786
2787         Reviewed by Adam.
2788
2789         http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
2790         Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate
2791
2792         FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
2793         Frame::cleanupPluginObjects method is called from Frame's destructor, which results
2794         in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.
2795
2796         * bridge/mac/FrameMac.mm:
2797         (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
2798         will be called from Frame::clear
2799         * page/Frame.cpp:
2800         (WebCore::Frame::~Frame): Use cancelAndClear.
2801         (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
2802         FrameMac can use.
2803         * page/Frame.h:
2804
2805 2006-09-14  Brady Eidson  <beidson@apple.com>
2806
2807         Reviewed by Maciej's rubber stamp
2808
2809         Exact same fix I just made, but in the other method I horked up
2810         Also added a reference to the bugzilla in comments
2811
2812         * page/Frame.cpp:
2813         (WebCore::Frame::endIfNotLoading):
2814         (WebCore::Frame::stop):
2815
2816 2006-09-14  Brady Eidson  <beidson@apple.com>
2817
2818         Reviewed by Maciej
2819
2820         Fixed a bad iFrame crash, resolving some of the layout test badness
2821
2822         * page/Frame.cpp:
2823         (WebCore::Frame::endIfNotLoading):
2824         - Added a RefPtr to protect the frame itself to prevent its destruction during this method
2825
2826 2006-09-14  Justin Garcia  <justin.garcia@apple.com>
2827
2828         Reviewed by harrison
2829
2830         <rdar://problem/4655880> Up/Down arrows skip over To Do
2831
2832         * bridge/mac/WebCoreFrameBridge.mm:
2833         (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
2834         * dom/Node.cpp: Removed the unused inSameRootEditableElement.
2835         * dom/Node.h:
2836         * editing/SelectionController.cpp:
2837         (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
2838         * editing/visible_units.cpp:
2839         (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
2840         editable content into editable content that's embedded in non-editable content.
2841         (WebCore::nextLinePosition): Ditto.
2842         (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
2843         This is the behavior that callers desire.  This fixes Command + Up/Down.
2844         (WebCore::endOfEditableContent): Ditto.
2845         * editing/visible_units.h:
2846
2847 2006-09-14  Karthik Kumar  <karthikkumar@gmail.com>
2848
2849         Reviewed by timothy. Landed by aroben.
2850
2851         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
2852         Windows build fixes after r16360
2853
2854         * WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to
2855         AdditionalIncludeDirectories
2856         * platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader,
2857         IconDatabase
2858         (IconLoader::stopLoading):
2859         (IconLoader::startLoading):
2860         (IconLoader::createForFrame):
2861         (IconDatabase::isIconExpiredForIconURL):
2862         (IconDatabase::hasEntryForIconURL):
2863         (IconDatabase::sharedIconDatabase):
2864
2865 2006-09-14  Brady Eidson  <beidson@apple.com>
2866
2867         Part of a build fix for Windows - rest will be working out a mess of temporary link stubs
2868
2869         * loader/icon/IconLoader.cpp:
2870         (IconLoader::receivedAllData):
2871         * page/Frame.cpp:
2872         * page/FramePrivate.h:
2873
2874 2006-09-14  Graham Dennis  <graham.dennis@gmail.com>
2875
2876         Reviewed by Justin Garcia.
2877
2878         - http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
2879           Crash in ApplyStyleCommand::applyRelativeFontStyleChange
2880
2881         * editing/ApplyStyleCommand.cpp:
2882         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by
2883         makeing sure that the 'beyondEnd' node is after the start node.
2884
2885 2006-09-14  MorganL  <morlmor@yahoo.com>
2886
2887         Reviewed by Brady.
2888
2889         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
2890         Various bugs/crashes in ResourceLoaderWin with local files.
2891
2892         * platform/ResourceLoaderInternal.h:
2893         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2894         * platform/win/ResourceLoaderWin.cpp:
2895         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
2896         (WebCore::ResourceLoader::fileLoadTimer):
2897
2898 2006-09-13  Brady Eidson <beidson@apple.com>
2899
2900         Reviewed by Maciej
2901
2902         Icon loads now take place in WebCore
2903
2904         * WebCore.xcodeproj/project.pbxproj:
2905         * bridge/BrowserExtension.h:
2906         * bridge/mac/BrowserExtensionMac.h:
2907         * bridge/mac/BrowserExtensionMac.mm:
2908         - Moved enforcement of a Mozilla Favicon extension elsewhere
2909
2910         * bridge/mac/FrameMac.h:
2911         * bridge/mac/FrameMac.mm:
2912         (WebCore::FrameMac::originalRequestURL):
2913         - Added accessor to "original request URL"
2914
2915         * bridge/mac/WebCoreFrameBridge.h:
2916         - Removed methods to set the iconURL as all loading is now done in WebCore
2917         - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL
2918
2919         * html/HTMLLinkElement.cpp:
2920         (WebCore::HTMLLinkElement::process):
2921         - Moved enforcement of a Mozilla Favicon extension elsewhere
2922
2923         * loader/icon/IconDatabase.cpp:
2924         (WebCore::IconDatabase::setIconURLForPageURL):
2925         - Changed an ASSERT to correctly handle a sketchy (invalid) situation
2926
2927         * loader/icon/IconLoader.h: Added.
2928         * loader/icon/IconLoader.cpp: Added.
2929         (IconLoader::IconLoader):
2930         (IconLoader::createForFrame):
2931         - Static factory method with a private constructor to enforce
2932           "you MUST have a Frame to create an IconLoader" semantics
2933         (IconLoader::~IconLoader):
2934         (IconLoader::startLoading):
2935         (IconLoader::stopLoading):
2936         (IconLoader::receivedData):
2937         - ResourceLoaderClient delegate
2938         (IconLoader::receivedAllData):
2939         - Ditto
2940
2941         * loader/mac/IconLoaderMac.mm: Added.
2942         (IconLoader::receivedResponse):
2943         (IconLoader::notifyIconChanged):
2944         - For now, these are platform specific methods
2945         - One to get the HTTP response code of an icon load
2946         - The other to call through to the app when the icon has changed (loaded)
2947
2948         * page/Frame.h:
2949         * page/Frame.cpp:
2950         (WebCore::Frame::iconURL):
2951         (WebCore::Frame::setIconURL):
2952         - Frame objects now have an inherent icon URL and a way to calculate/access it
2953         (WebCore::Frame::endIfNotLoading):
2954         - This is where we actually kick off the IconLoader
2955         (WebCore::Frame::stop):
2956         - Added call to stop loading the icon
2957
2958         * page/FramePrivate.h:
2959         (WebCore::FramePrivate::FramePrivate):
2960         (WebCore::FramePrivate::~FramePrivate):
2961         - Added the icon URL as a private member
2962         - Added the IconLoader as a private member, and clean it up on deletion
2963
2964         * platform/mac/ResourceLoaderMac.mm:
2965         (WebCore::ResourceLoader::start):  Added a valuable ASSERT
2966
2967 2006-09-13  David Hyatt  <hyatt@apple.com>
2968
2969         Fix for 10841, unable to check checkboxes inside labels.
2970
2971         Reviewed by xenon, bradee-oh
2972
2973         * css/html4.css:
2974         * dom/Element.cpp:
2975         (WebCore::Element::contains):
2976         * dom/Element.h:
2977         * html/HTMLLabelElement.cpp:
2978         (WebCore::HTMLLabelElement::defaultEventHandler):
2979
2980 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
2981
2982         Reviewed by Adam.
2983
2984         http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
2985         Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller
2986
2987         * platform/mac/FileChooserMac.mm:
2988         (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
2989
2990 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
2991
2992         Reviewed by Eric.
2993
2994         http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
2995         Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef
2996
2997         * platform/mac/FontMac.mm:
2998         (WebCore::Font::drawComplexText): Release CGColorRef after use.
2999         (WebCore::Font::drawGlyphs): Ditto.
3000
3001 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
3002
3003         Try fixing the Win32 build.
3004
3005         * bridge/win/FrameWin.h:
3006         * platform/win/TemporaryLinkStubs.cpp:
3007         (FrameWin::bindingRootObject):
3008
3009 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
3010
3011         Reviewed by Tim O.
3012
3013         Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.
3014
3015         * bindings/js/kjs_binding.cpp:
3016         (KJS::ScriptInterpreter::createLanguageInstanceForValue):
3017         * bindings/js/kjs_dom.cpp:
3018         (KJS::getRuntimeObject):
3019         * bridge/mac/FrameMac.h:
3020         * config.h:
3021         * html/HTMLAppletElement.cpp:
3022         (WebCore::HTMLAppletElement::~HTMLAppletElement):
3023         (WebCore::HTMLAppletElement::detach):
3024         * html/HTMLAppletElement.h:
3025         * html/HTMLEmbedElement.cpp:
3026         (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
3027         (WebCore::HTMLEmbedElement::detach):
3028         * html/HTMLEmbedElement.h:
3029         * html/HTMLObjectElement.cpp:
3030         (WebCore::HTMLObjectElement::~HTMLObjectElement):
3031         (WebCore::HTMLObjectElement::detach):
3032         * html/HTMLObjectElement.h:
3033         * html/HTMLPlugInElement.cpp:
3034         (WebCore::HTMLPlugInElement::HTMLPlugInElement):
3035         (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
3036         (WebCore::HTMLPlugInElement::createNPObject):
3037         * html/HTMLPlugInElement.h:
3038         * page/Frame.h:
3039
3040 2006-09-13  David Hyatt  <hyatt@apple.com>
3041
3042         Clean up the XBL and XSLT ifdefs to be consistent with the SVG
3043         and XPath ifdefs.  KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
3044         KHTML_XSLT is now XSLT_SUPPORT.
3045
3046         * WebCore.xcodeproj/project.pbxproj:
3047         * bindings/js/JSXSLTProcessor.cpp:
3048         * bindings/js/JSXSLTProcessor.h:
3049         * bindings/js/kjs_window.cpp:
3050         (KJS::Window::getValueProperty):
3051         * config.h:
3052         * css/CSSComputedStyleDeclaration.cpp:
3053         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3054         * css/cssparser.cpp:
3055         (WebCore::CSSParser::parseValue):
3056         * css/cssstyleselector.cpp:
3057         (WebCore::CSSStyleSelector::applyProperty):
3058         * dom/Document.cpp:
3059         (WebCore::Document::Document):
3060         (WebCore::Document::~Document):
3061         (WebCore::Document::recalcStyleSelector):
3062         * dom/Document.h:
3063         (WebCore::Document::bindingManager):
3064         * dom/Node.cpp:
3065         (WebCore::Node::createRendererIfNeeded):
3066         * dom/ProcessingInstruction.cpp:
3067         (WebCore::ProcessingInstruction::ProcessingInstruction):
3068         (WebCore::ProcessingInstruction::checkStyleSheet):
3069         (WebCore::ProcessingInstruction::setStyleSheet):
3070         * dom/ProcessingInstruction.h:
3071         * dom/XMLTokenizer.cpp:
3072         (WebCore::XMLTokenizer::processingInstruction):
3073         (WebCore::XMLTokenizer::insertErrorMessageBlock):
3074         * dom/XMLTokenizer.h:
3075         * loader/Cache.cpp:
3076         (WebCore::Cache::getStatistics):
3077         * loader/Cache.h:
3078         * loader/CachedResource.h:
3079         (WebCore::CachedResource::):
3080         * loader/CachedResourceClient.h:
3081         * loader/CachedXBLDocument.cpp:
3082         * loader/CachedXBLDocument.h:
3083         * loader/CachedXSLStyleSheet.cpp:
3084         * loader/CachedXSLStyleSheet.h:
3085         * loader/DocLoader.cpp:
3086         * loader/DocLoader.h:
3087         * rendering/RenderStyle.cpp:
3088         (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
3089         (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData):
3090         (WebCore::StyleCSS3NonInheritedData::operator==):
3091         * rendering/RenderStyle.h:
3092         * xml/XSLImportRule.cpp:
3093         * xml/XSLImportRule.h:
3094         * xml/XSLStyleSheet.cpp:
3095         * xml/XSLStyleSheet.h:
3096         * xml/XSLTProcessor.cpp:
3097         * xml/XSLTProcessor.h:
3098
3099 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
3100
3101         Reviewed by eseidel.  Landed by eseidel.
3102
3103         Fix newly introduced memory leaks in SVG.
3104         http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
3105
3106         * ksvg2/svg/SVGList.h:
3107         (WebCore::SVGListBase::~SVGListBase):
3108         (WebCore::SVGListBase::clearVector):
3109         (WebCore::SVGListBase::clear):
3110         (WebCore::SVGList::clearVector):
3111         (WebCore::):
3112         * ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that!
3113         (SVGNumberList::SVGNumberList):
3114         * ksvg2/svg/SVGNumberList.h: Ditto.
3115
3116 2006-09-13  MorganL  <morlmor@yahoo.com>
3117
3118         Reviewed/landed by aroben.
3119
3120         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
3121         Windows build needs fixed after move to engine-rendered file upload widget
3122
3123         * WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files,
3124         remove RenderFileButton files
3125         * platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon
3126         (FileChooser::FileChooser):
3127         (FileChooser::~FileChooser):
3128         (FileChooser::openFileChooser):
3129         (FileChooser::basenameForWidth):
3130         (FileChooser::uploadControlDetaching):
3131         (FileChooser::chooseFile):
3132         (WebCore::fileButtonChooseFileLabel):
3133         (WebCore::fileButtonNoFileSelectedLabel):
3134         (Icon::Icon):
3135         (Icon::~Icon):
3136         (Icon::newIconForFile):
3137         (Icon::paint):
3138
3139 2006-09-13  MorganL  <morlmor@yahoo.com>
3140
3141         Reviewed/landed by aroben.
3142
3143         Fixes http://bugzilla.opendarwin.org/attachment.cgi?id=10537
3144         Webkit WebCore build fails on Windows
3145
3146         * WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT
3147         variable
3148
3149 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
3150
3151         Reviewed by Tim H.
3152
3153         Fix Qt/Linux build.
3154
3155         * CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
3156         * platform/Icon.h: Add wtf/Platform.h include
3157         * platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though.
3158         (WebCore::FileChooser::FileChooser):
3159         (WebCore::FileChooser::~FileChooser):
3160         (WebCore::FileChooser::openFileChooser):
3161         (WebCore::FileChooser::basenameForWidth):
3162         (WebCore::FileChooser::uploadControlDetaching):
3163         (WebCore::FileChooser::chooseFile):
3164         * platform/qt/IconQt.cpp: Added as stub.
3165         (WebCore::Icon::Icon):
3166         (WebCore::Icon::~Icon):
3167         (WebCore::Icon::newIconForFile):
3168         (WebCore::Icon::paint):
3169         * platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed
3170         (searchableIndexIntroduction):
3171         (fileButtonChooseFileLabel):
3172         (fileButtonNoFileSelectedLabel):
3173
3174 2006-09-12  Adam Roben  <aroben@apple.com>
3175
3176         Reviewed by eseidel.
3177
3178         Switch back to passing relative paths to generate-bindings.pl when
3179         generating JS bindings.
3180
3181         * DerivedSources.make: Pass in relative paths to generate-bindings.pl
3182         * bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call
3183         chdir and always construct absolute paths instead.
3184
3185 2006-09-12  David Hyatt  <hyatt@apple.com>
3186
3187         Fix for bug 3244, implement html4 label support.
3188
3189         Reviewed by mjs, aroben
3190
3191         Added fast/events/label-focus.html
3192
3193         * css/html4.css:
3194         * html/HTMLLabelElement.cpp:
3195         (WebCore::HTMLLabelElement::formElement):
3196         (WebCore::HTMLLabelElement::setActive):
3197         (WebCore::HTMLLabelElement::setHovered):
3198         (WebCore::HTMLLabelElement::defaultEventHandler):
3199         * html/HTMLLabelElement.h:
3200
3201 2006-09-12  Julien Palmas  <julien.palmas@gmail.com>
3202
3203         Reviewed by darin.  Landed by eseidel.
3204
3205         * ksvg2/svg/svgpathparser.cpp:
3206         (WebCore::SVGPolyParser::parsePoints):
3207
3208 2006-09-11  Kevin McCullough  <KMcCullough@apple.com>
3209
3210         Reviewed by Andersca, Maciej, Brady.
3211
3212         - Implemented intersectsNode in the Range Class
3213           to be compliant with Mozilla standard
3214
3215         * dom/Range.cpp:
3216         (WebCore::Range::intersectsNode):
3217         * dom/Range.h:
3218         * dom/Range.idl:
3219
3220 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>
3221
3222         Reviewed by eseidel.  Landed by eseidel.
3223
3224         Test: svg/W3C-SVG-1.1/struct-dom-01-b.svg (fixed)
3225         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10826
3226
3227         Also finally fixes some long outstanding bugs:
3228         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9190
3229         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9229
3230         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10413
3231
3232         Enable all JavaScript SVG bindings. Builds on Qt/Linux & OSX.
3233
3234         * CMakeLists.txt:
3235         * DerivedSources.make:
3236         * WebCore.xcodeproj/project.pbxproj:
3237         * bindings/scripts/CodeGenerator.pm:
3238         * bindings/scripts/CodeGeneratorJS.pm:
3239         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
3240         * ksvg2/svg/SVGAElement.idl: Added.
3241         * ksvg2/svg/SVGAngle.idl:
3242         * ksvg2/svg/SVGAnimateColorElement.idl: Added.
3243         * ksvg2/svg/SVGAnimateElement.idl: Added.
3244         * ksvg2/svg/SVGAnimateTransformElement.idl: Added.
3245         * ksvg2/svg/SVGAnimatedLengthList.idl: Added.
3246         * ksvg2/svg/SVGAnimatedNumberList.idl: Added.
3247         * ksvg2/svg/SVGAnimatedTransformList.idl: Added.
3248         * ksvg2/svg/SVGAnimationElement.idl: Added.
3249         * ksvg2/svg/SVGCircleElement.idl: Added.
3250         * ksvg2/svg/SVGClipPathElement.idl: Added.
3251         * ksvg2/svg/SVGColor.idl:
3252         * ksvg2/svg/SVGComponentTransferFunctionElement.idl: Added.
3253         * ksvg2/svg/SVGCursorElement.idl: Added.
3254         * ksvg2/svg/SVGDefsElement.idl: Added.
3255         * ksvg2/svg/SVGDescElement.idl: Added.
3256         * ksvg2/svg/SVGEllipseElement.idl: Added.
3257         * ksvg2/svg/SVGEvent.idl:
3258         * ksvg2/svg/SVGExternalResourcesRequired.idl: Added.
3259         * ksvg2/svg/SVGFEBlendElement.idl: Added.
3260         * ksvg2/svg/SVGFEColorMatrixElement.idl: Added.
3261         * ksvg2/svg/SVGFEComponentTransferElement.idl: Added.
3262         * ksvg2/svg/SVGFECompositeElement.idl: Added.
3263         * ksvg2/svg/SVGFEDiffuseLightingElement.idl: Added.
3264         * ksvg2/svg/SVGFEDisplacementMapElement.idl: Added.
3265         * ksvg2/svg/SVGFEDistantLightElement.idl: Added.
3266         * ksvg2/svg/SVGFEFloodElement.idl: Added.
3267         * ksvg2/svg/SVGFEFuncAElement.idl: Added.
3268         * ksvg2/svg/SVGFEFuncBElement.idl: Added.
3269         * ksvg2/svg/SVGFEFuncGElement.idl: Added.
3270         * ksvg2/svg/SVGFEFuncRElement.idl: Added.
3271         * ksvg2/svg/SVGFEGaussianBlurElement.idl: Added.
3272         * ksvg2/svg/SVGFEImageElement.idl: Added.
3273         * ksvg2/svg/SVGFEMergeElement.idl: Added.
3274         * ksvg2/svg/SVGFEMergeNodeElement.idl: Added.
3275         * ksvg2/svg/SVGFEOffsetElement.idl: Added.
3276         * ksvg2/svg/SVGFEPointLightElement.idl: Added.
3277         * ksvg2/svg/SVGFESpecularLightingElement.idl: Added.
3278         * ksvg2/svg/SVGFESpotLightElement.idl: Added.
3279         * ksvg2/svg/SVGFETileElement.idl: Added.
3280         * ksvg2/svg/SVGFETurbulenceElement.idl: Added.
3281         * ksvg2/svg/SVGFilterElement.idl: Added.
3282         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
3283         * ksvg2/svg/SVGFitToViewBox.idl: Added.
3284         * ksvg2/svg/SVGForeignObjectElement.idl: Added.
3285         * ksvg2/svg/SVGGElement.idl: Added.
3286         * ksvg2/svg/SVGGradientElement.idl: Added.
3287         * ksvg2/svg/SVGImageElement.idl: Added.
3288         * ksvg2/svg/SVGLangSpace.idl: Added.
3289         * ksvg2/svg/SVGLength.idl:
3290         * ksvg2/svg/SVGLengthList.idl: Added.
3291         * ksvg2/svg/SVGLineElement.idl: Added.
3292         * ksvg2/svg/SVGLinearGradientElement.idl: Added.
3293         * ksvg2/svg/SVGLocatable.idl: Added.
3294         * ksvg2/svg/SVGMarkerElement.idl: Added.
3295         * ksvg2/svg/SVGMaskElement.idl: Added.
3296         * ksvg2/svg/SVGNumberList.idl: Added.
3297         * ksvg2/svg/SVGPaint.idl: Added.
3298         * ksvg2/svg/SVGPathElement.idl:
3299         * ksvg2/svg/SVGPathSeg.idl:
3300         * ksvg2/svg/SVGPatternElement.idl: Added.
3301         * ksvg2/svg/SVGPointList.idl: Added.
3302         * ksvg2/svg/SVGPolygonElement.idl: Added.
3303         * ksvg2/svg/SVGPolylineElement.idl: Added.
3304         * ksvg2/svg/SVGPreserveAspectRatio.idl:
3305         * ksvg2/svg/SVGRadialGradientElement.idl: Added.
3306         * ksvg2/svg/SVGRectElement.idl: Added.
3307         * ksvg2/svg/SVGRenderingIntent.idl: Added.
3308         * ksvg2/svg/SVGSVGElement.idl:
3309         * ksvg2/svg/SVGScriptElement.idl: Added.
3310         * ksvg2/svg/SVGSetElement.idl: Added.
3311         * ksvg2/svg/SVGStopElement.idl: Added.
3312         * ksvg2/svg/SVGStringList.idl: Added.
3313         * ksvg2/svg/SVGStylable.idl: Added.
3314         * ksvg2/svg/SVGStyleElement.idl: Added.
3315         * ksvg2/svg/SVGSwitchElement.idl: Added.
3316         * ksvg2/svg/SVGSymbolElement.idl: Added.
3317         * ksvg2/svg/SVGTRefElement.idl: Added.
3318         * ksvg2/svg/SVGTSpanElement.idl: Added.
3319         * ksvg2/svg/SVGTests.idl: Added.
3320         * ksvg2/svg/SVGTextContentElement.idl: Added.
3321         * ksvg2/svg/SVGTextElement.idl: Added.
3322         * ksvg2/svg/SVGTextPositioningElement.idl: Added.
3323         * ksvg2/svg/SVGTitleElement.idl: Added.
3324         * ksvg2/svg/SVGTransform.idl:
3325         * ksvg2/svg/SVGTransformList.idl: Added.
3326         * ksvg2/svg/SVGTransformable.idl: Added.
3327         * ksvg2/svg/SVGURIReference.idl: Added.
3328         * ksvg2/svg/SVGUnitTypes.idl: Added.
3329         * ksvg2/svg/SVGUseElement.idl: Added.
3330         * ksvg2/svg/SVGViewElement.idl: Added.
3331         * ksvg2/svg/SVGZoomAndPan.idl: Added.
3332         * ksvg2/svg/SVGZoomEvent.idl: Added.
3333
3334 2006-09-12  Adam Roben  <aroben@apple.com>
3335
3336         Reviewed by timo, ggaren.
3337
3338         Make Icon ref-counted.
3339
3340         * platform/FileChooser.h: Store m_icon as a RefPtr instead of
3341         auto_ptr.
3342         * platform/Icon.h: Inherit from Shared<Icon>
3343         * platform/mac/FileChooserMac.mm:
3344         (WebCore::FileChooser::chooseFile): Update m_icon usage
3345         * platform/mac/IconMac.mm:
3346         (WebCore::Icon::newIconForFile): Return a RefPtr instead of an
3347         auto_ptr
3348
3349 === Safari-521.26 ===
3350
3351 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>
3352
3353         Reviewed by Anders.
3354
3355         Add exception codes to SVGList functions, adjust all code using it.
3356
3357         Move SVGPaintType enums from ksvg.h into SVGPaint (needed for js generation)
3358         Move SVGUnitTypes enums from ksvg.h into it's own file SVGUnitType.h (ditto)
3359         Move SVGRenderingIntent enums from ksvg.h into it's own file SVGRenderingIntent.h (ditto)
3360         Move SVGZoomAndPan enums from ksvg.h into SVGSVGElement (ditto)
3361         Move SVGFE* related enums into their respecitive classes.
3362
3363         Fix JSSVGNumber to operator on doubles, instead of floats.
3364
3365         * ksvg2/bindings/js/JSSVGNumber.cpp:
3366         (WebCore::getJSSVGNumber):
3367         * ksvg2/bindings/js/JSSVGNumber.h:
3368         (WebCore::JSSVGNumber::JSSVGNumber):
3369         * ksvg2/css/SVGCSSParser.cpp:
3370         (WebCore::CSSParser::parseSVGValue):
3371         (WebCore::CSSParser::parseSVGPaint):
3372         * ksvg2/css/SVGRenderStyleDefs.cpp:
3373         (StyleFillData::operator==):
3374         * ksvg2/ksvg.h:
3375         * ksvg2/misc/KCanvasRenderingStyle.cpp:
3376         (WebCore::KSVGPainterFactory::isFilled):
3377         (WebCore::KSVGPainterFactory::fillPaintServer):
3378         (WebCore::KSVGPainterFactory::isStroked):
3379         (WebCore::KSVGPainterFactory::strokePaintServer):
3380         * ksvg2/misc/KSVGTimeScheduler.cpp:
3381         (WebCore::SVGTimer::notifyAll):
3382         * ksvg2/svg/SVGAnimateColorElement.cpp:
3383         (WebCore::SVGAnimateColorElement::handleTimerEvent):
3384         * ksvg2/svg/SVGAnimateTransformElement.cpp:
3385         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
3386         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
3387         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
3388         (WebCore::SVGAnimateTransformElement::parseTransformValue):
3389         * ksvg2/svg/SVGAnimateTransformElement.h:
3390         * ksvg2/svg/SVGAnimatedTemplate.h:
3391         * ksvg2/svg/SVGAnimationElement.cpp:
3392         (SVGAnimationElement::getSimpleDuration):
3393         (SVGAnimationElement::parseMappedAttribute):
3394         (SVGAnimationElement::setTargetAttribute):
3395         * ksvg2/svg/SVGAnimationElement.h:
3396         * ksvg2/svg/SVGClipPathElement.cpp:
3397         (SVGClipPathElement::SVGClipPathElement):
3398         (SVGClipPathElement::parseMappedAttribute):
3399         (SVGClipPathElement::canvasResource):
3400         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
3401         (SVGComponentTransferFunctionElement::transferFunction):
3402         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
3403         (WebCore::SVGComponentTransferFunctionElement::):
3404         * ksvg2/svg/SVGDocument.cpp:
3405         (WebCore::SVGDocument::dispatchZoomEvent):
3406         (WebCore::SVGDocument::dispatchScrollEvent):
3407         * ksvg2/svg/SVGFEBlendElement.cpp:
3408         (WebCore::SVGFEBlendElement::parseMappedAttribute):
3409         (WebCore::SVGFEBlendElement::filterEffect):
3410         * ksvg2/svg/SVGFEBlendElement.h:
3411         (WebCore::SVGFEBlendElement::):
3412         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3413         (SVGFEColorMatrixElement::parseMappedAttribute):
3414         (SVGFEColorMatrixElement::filterEffect):
3415         * ksvg2/svg/SVGFEColorMatrixElement.h:
3416         (WebCore::SVGFEColorMatrixElement::):
3417         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
3418         (WebCore::SVGFEComponentTransferElement::parseMappedAttribute):
3419         (WebCore::SVGFEComponentTransferElement::filterEffect):
3420         * ksvg2/svg/SVGFEComponentTransferElement.h:
3421         * ksvg2/svg/SVGFECompositeElement.cpp:
3422         (SVGFECompositeElement::parseMappedAttribute):
3423         (SVGFECompositeElement::filterEffect):
3424         * ksvg2/svg/SVGFECompositeElement.h:
3425         (WebCore::SVGFECompositeElement::):
3426         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3427         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
3428         (WebCore::SVGFEDiffuseLightingElement::filterEffect):
3429         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
3430         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3431         (SVGFEDisplacementMapElement::parseMappedAttribute):
3432         (SVGFEDisplacementMapElement::filterEffect):
3433         * ksvg2/svg/SVGFEDisplacementMapElement.h:
3434         (WebCore::SVGFEDisplacementMapElement::):
3435         * ksvg2/svg/SVGFEFloodElement.cpp:
3436         (WebCore::SVGFEFloodElement::parseMappedAttribute):
3437         (WebCore::SVGFEFloodElement::filterEffect):
3438         * ksvg2/svg/SVGFEFloodElement.h:
3439         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
3440         (SVGFEGaussianBlurElement::parseMappedAttribute):
3441         (SVGFEGaussianBlurElement::filterEffect):
3442         * ksvg2/svg/SVGFEGaussianBlurElement.h:
3443         * ksvg2/svg/SVGFEMergeElement.cpp:
3444         (SVGFEMergeElement::filterEffect):
3445         * ksvg2/svg/SVGFEMergeNodeElement.cpp:
3446         (SVGFEMergeNodeElement::parseMappedAttribute):
3447         * ksvg2/svg/SVGFEMergeNodeElement.h:
3448         * ksvg2/svg/SVGFEOffsetElement.cpp:
3449         (SVGFEOffsetElement::parseMappedAttribute):
3450         (SVGFEOffsetElement::filterEffect):
3451         * ksvg2/svg/SVGFEOffsetElement.h:
3452         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
3453         (SVGFESpecularLightingElement::parseMappedAttribute):
3454         (SVGFESpecularLightingElement::filterEffect):
3455         * ksvg2/svg/SVGFESpecularLightingElement.h:
3456         * ksvg2/svg/SVGFETileElement.cpp:
3457         (WebCore::SVGFETileElement::parseMappedAttribute):
3458         (WebCore::SVGFETileElement::filterEffect):
3459         * ksvg2/svg/SVGFETileElement.h:
3460         * ksvg2/svg/SVGFETurbulenceElement.h:
3461         (WebCore::SVGFETurbulenceElement::):
3462         * ksvg2/svg/SVGFilterElement.cpp:
3463         (SVGFilterElement::SVGFilterElement):
3464         (SVGFilterElement::parseMappedAttribute):
3465         (SVGFilterElement::canvasResource):
3466         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
3467         (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
3468         * ksvg2/svg/SVGGradientElement.cpp:
3469         (SVGGradientElement::SVGGradientElement):
3470         (SVGGradientElement::parseMappedAttribute):
3471         * ksvg2/svg/SVGGradientElement.h:
3472         (WebCore::SVGGradientElement::):
3473         * ksvg2/svg/SVGHelper.cpp:
3474         (WebCore::SVGHelper::ParseSeperatedList):
3475         * ksvg2/svg/SVGLengthList.cpp:
3476         (WebCore::SVGLengthList::parse):
3477         * ksvg2/svg/SVGLinearGradientElement.cpp:
3478         (SVGLinearGradientElement::buildGradient):
3479         * ksvg2/svg/SVGList.h:
3480         (WebCore::SVGListBase::clear):
3481         (WebCore::SVGListBase::initialize):
3482         (WebCore::SVGListBase::getItem):
3483         (WebCore::SVGListBase::insertItemBefore):
3484         (WebCore::SVGListBase::replaceItem):
3485         (WebCore::SVGListBase::removeItem):
3486         (WebCore::SVGListBase::appendItem):
3487         * ksvg2/svg/SVGLocatable.cpp:
3488         * ksvg2/svg/SVGLocatable.h:
3489         * ksvg2/svg/SVGMarkerElement.h:
3490         (WebCore::SVGMarkerElement::):
3491         * ksvg2/svg/SVGNumberList.cpp:
3492         (SVGNumberList::parse):
3493         * ksvg2/svg/SVGPaint.cpp:
3494         (WebCore::SVGPaint::SVGPaint):
3495         (WebCore::SVGPaint::uri):
3496         (WebCore::SVGPaint::setUri):
3497         (WebCore::SVGPaint::setPaint):
3498         * ksvg2/svg/SVGPaint.h:
3499         (WebCore::SVGPaint::):
3500         * ksvg2/svg/SVGPathElement.cpp:
3501         (WebCore::SVGPathElement::svgMoveTo):
3502         (WebCore::SVGPathElement::svgLineTo):
3503         (WebCore::SVGPathElement::svgLineToHorizontal):
3504         (WebCore::SVGPathElement::svgLineToVertical):
3505         (WebCore::SVGPathElement::svgCurveToCubic):
3506         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
3507         (WebCore::SVGPathElement::svgCurveToQuadratic):
3508         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
3509         (WebCore::SVGPathElement::svgArcTo):
3510         (WebCore::SVGPathElement::svgClosePath):
3511         (WebCore::SVGPathElement::parseMappedAttribute):
3512         (WebCore::SVGPathElement::toPathData):
3513         * ksvg2/svg/SVGPatternElement.cpp:
3514         (WebCore::SVGPatternElement::SVGPatternElement):
3515         (WebCore::SVGPatternElement::parseMappedAttribute):
3516         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
3517         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
3518         * ksvg2/svg/SVGPolyElement.cpp:
3519         (SVGPolyElement::parseMappedAttribute):
3520         (SVGPolyElement::svgPolyTo):
3521         (SVGPolyElement::notifyAttributeChange):
3522         * ksvg2/svg/SVGPolygonElement.cpp:
3523         (SVGPolygonElement::toPathData):
3524         * ksvg2/svg/SVGPolylineElement.cpp:
3525         (SVGPolylineElement::toPathData):
3526         * ksvg2/svg/SVGRadialGradientElement.cpp:
3527         (WebCore::SVGRadialGradientElement::buildGradient):
3528         * ksvg2/svg/SVGRenderingIntent.h: Added.
3529         (WebCore::SVGRenderingIntent::):
3530         (WebCore::SVGRenderingIntent::SVGRenderingIntent):
3531         (WebCore::SVGRenderingIntent::~SVGRenderingIntent):
3532         * ksvg2/svg/SVGSVGElement.h:
3533         (WebCore::SVGSVGElement::):
3534         * ksvg2/svg/SVGScriptElement.cpp:
3535         (WebCore::SVGScriptElement::type):
3536         (WebCore::SVGScriptElement::setType):
3537         (WebCore::SVGScriptElement::parseMappedAttribute):
3538         * ksvg2/svg/SVGScriptElement.h:
3539         * ksvg2/svg/SVGStringList.cpp:
3540         (WebCore::SVGStringList::reset):
3541         * ksvg2/svg/SVGStyledLocatableElement.cpp:
3542         (SVGStyledLocatableElement::getTransformToElement):
3543         * ksvg2/svg/SVGStyledLocatableElement.h:
3544         * ksvg2/svg/SVGStyledTransformableElement.cpp:
3545         (SVGStyledTransformableElement::parseMappedAttribute):
3546         (SVGStyledTransformableElement::getTransformToElement):
3547         * ksvg2/svg/SVGStyledTransformableElement.h:
3548         * ksvg2/svg/SVGTests.cpp:
3549         (WebCore::SVGTests::hasExtension):
3550         (WebCore::SVGTests::isValid):
3551         * ksvg2/svg/SVGTests.h:
3552         * ksvg2/svg/SVGTextContentElement.cpp:
3553         (SVGTextContentElement::getSubStringLength):
3554         (SVGTextContentElement::getStartPositionOfChar):
3555         (SVGTextContentElement::getEndPositionOfChar):
3556         (SVGTextContentElement::getExtentOfChar):
3557         (SVGTextContentElement::getRotationOfChar):
3558         (SVGTextContentElement::selectSubString):
3559         * ksvg2/svg/SVGTextContentElement.h:
3560         (WebCore::SVGTextContentElement::):
3561         * ksvg2/svg/SVGTextElement.cpp:
3562         (WebCore::SVGTextElement::parseMappedAttribute):
3563         * ksvg2/svg/SVGTextElement.h:
3564         (WebCore::SVGTextElement::getTransformToElement):
3565         * ksvg2/svg/SVGTransform.h:
3566         * ksvg2/svg/SVGTransformList.cpp:
3567         (SVGTransformList::consolidate):
3568         (SVGTransformList::concatenate):
3569         * ksvg2/svg/SVGTransformable.cpp:
3570         (SVGTransformable::parseTransformAttribute):
3571         * ksvg2/svg/SVGUnitTypes.h: Added.
3572         (WebCore::SVGUnitTypes::):
3573         (WebCore::SVGUnitTypes::SVGUnitTypes):
3574         (WebCore::SVGUnitTypes::~SVGUnitTypes):
3575         * ksvg2/svg/SVGUseElement.cpp:
3576         (SVGUseElement::closeRenderer):
3577         * ksvg2/svg/SVGViewElement.h:
3578         (WebCore::SVGViewElement::):
3579         * ksvg2/svg/SVGZoomAndPan.cpp:
3580         (WebCore::SVGZoomAndPan::SVGZoomAndPan):
3581         (WebCore::SVGZoomAndPan::parseMappedAttribute):
3582
3583 2006-09-12  John Sullivan  <sullivan@apple.com>
3584
3585         Reviewed by Adele Peterson.
3586
3587         * bridge/mac/FrameMac.mm:
3588         (WebCore::FrameMac::doTextFieldCommandFromEvent):
3589         Don't call textField:doCommandBySelector: with a nil selector. This was indirectly causing a
3590         (valid) assertion failure in some Safari code.
3591
3592 2006-09-12  David Harrison  <harrison@apple.com>
3593
3594         Reviewed by John Sullivan.
3595
3596         <rdar://problem/4717841> Setting AXFocused to true does not activate the insertion point in text field
3597
3598         * bridge/mac/WebCoreAXObject.mm:
3599         (-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
3600         For AXFocus, use focus() if the node is an element, so that selection is set.
3601         Matches tabbing behavior in text fields and text areas.
3602
3603 2006-09-12  Adam Roben  <aroben@apple.com>
3604
3605         Reviewed by adele.
3606
3607         Make uploading work with the new file upload control.
3608
3609         * css/html4.css: Remove unnecessary style (this is already done in
3610         RenderFileUpload.cpp)
3611         * html/HTMLInputElement.cpp: Don't get the button text from the value
3612         attribute for file controls.
3613         (WebCore::HTMLInputElement::valueWithDefault):
3614         * platform/mac/FileChooserMac.mm: Call
3615         RenderFileUploadControl::valueChanged when the user selects a file.
3616         (WebCore::FileChooser::chooseFile):
3617         * rendering/RenderFileUploadControl.cpp: Add valueChanged() method to
3618         update the form and fire the onChange event.
3619         (WebCore::RenderFileUploadControl::valueChanged):
3620         (WebCore::RenderFileUploadControl::updateFromElement):
3621         * rendering/RenderFileUploadControl.h: Add valueChanged() declaration.
3622
3623 2006-09-12  Adam Roben  <aroben@apple.com>
3624
3625         Adding rules to html4.css to style the button in file upload controls.
3626
3627         * css/html4.css:
3628
3629 2006-09-12  Adam Roben  <aroben@apple.com>
3630
3631         Reviewed many times by darin, hyatt.
3632
3633         Switch to new engine-based implementation of <input type="file">
3634
3635         * WebCore.exp: Remove obsolete symbol WebCoreFileButton
3636         * WebCore.xcodeproj/project.pbxproj: Remove files for old widget-based
3637         control, add files for new engine-based control
3638         * css/CSSSelector.cpp: Add support for new
3639         '-webkit-file-upload-button' pseudo element
3640         (WebCore::CSSSelector::extractPseudoType):
3641         * css/CSSSelector.h: Ditto.
3642         (WebCore::CSSSelector::):
3643         * css/cssstyleselector.cpp: Ditto.
3644         (WebCore::CSSStyleSelector::checkOneSelector):
3645         * html/HTMLInputElement.cpp: Send click events to new control
3646         (WebCore::HTMLInputElement::select):
3647         (WebCore::HTMLInputElement::click):
3648         (WebCore::HTMLInputElement::createRenderer):
3649         (WebCore::HTMLInputElement::valueWithDefault):
3650         (WebCore::HTMLInputElement::defaultEventHandler):
3651         * html/HTMLTextFieldInnerElement.h: Add 'virtual' keyword
3652         (WebCore::HTMLTextFieldInnerElement::shadowParentNode):
3653         * platform/FileButton.h: Removed.
3654         * platform/FileChooser.h: Added. This is the replacement for
3655         FileButton.h
3656         (WebCore::FileChooser::filename):
3657         (WebCore::FileChooser::icon):
3658         (WebCore::FileChooser::uploadControl):
3659         (WebCore::FileChooser::document):
3660         * platform/Icon.h: Added new platform-specific class representing a
3661         file icon.
3662         * platform/LocalizedStrings.h:
3663         * platform/mac/FileButtonMac.mm: Removed.
3664         * platform/mac/FileChooserMac.mm: Added. This is the replacement for
3665         FileButtonMac.mm
3666         (-[OpenPanelController initWithFileChooser:]):
3667         (-[OpenPanelController fileChooserDetachingSoon]):
3668         (-[OpenPanelController beginSheet]):
3669         (-[OpenPanelController chooseFilename:]):
3670         (-[OpenPanelController cancel]):
3671         (WebCore::FileChooser::FileChooser):
3672         (WebCore::FileChooser::~FileChooser):
3673         (WebCore::FileChooser::openFileChooser):
3674         (WebCore::FileChooser::basenameForWidth):
3675         (WebCore::FileChooser::uploadControlDetaching):
3676         (WebCore::FileChooser::chooseFile):
3677         * platform/mac/IconMac.mm: Added.
3678         (WebCore::Icon::Icon):
3679         (WebCore::Icon::~Icon):
3680         (WebCore::Icon::newIconForFile):
3681         (WebCore::Icon::paint):
3682         * platform/mac/LocalizedStringsMac.mm: Call across bridge to get
3683         localized strings.
3684         (WebCore::fileButtonChooseFileLabel):
3685         (WebCore::fileButtonNoFileSelectedLabel):
3686         * rendering/RenderButton.cpp: Extract method setText() from
3687         updateFromElement.
3688         (WebCore::RenderButton::updateFromElement):
3689         (WebCore::RenderButton::setText):
3690         * rendering/RenderButton.h: Add declaration for new setText method.
3691         * rendering/RenderFileButton.cpp: Removed.
3692         * rendering/RenderFileButton.h: Removed.
3693         * rendering/RenderFileUploadControl.cpp: Added. This is the
3694         replacement for RenderFileButton.cpp.
3695         (WebCore::RenderFileUploadInnerFileBox::renderName):
3696         (WebCore::HTMLFileUploadInnerButtonElement::isShadowNode):
3697         (WebCore::HTMLFileUploadInnerButtonElement::shadowParentNode):
3698         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
3699         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
3700         (WebCore::RenderFileUploadControl::setStyle):
3701         (WebCore::RenderFileUploadControl::updateIconAndFilename):
3702         (WebCore::RenderFileUploadControl::click):
3703         (WebCore::RenderFileUploadControl::updateFromElement):
3704         (WebCore::RenderFileUploadControl::maxFilenameWidth):
3705         (WebCore::RenderFileUploadControl::createButtonStyle):
3706         (WebCore::RenderFileUploadControl::paintObject):
3707         (WebCore::RenderFileUploadInnerFileBox::RenderFileUploadInnerFileBox):
3708         (WebCore::RenderFileUploadInnerFileBox::setStyle):
3709         (WebCore::RenderFileUploadInnerFileBox::layout):
3710         (WebCore::RenderFileUploadInnerFileBox::setHasIcon):
3711         (WebCore::RenderFileUploadInnerFileBox::setFilename):
3712         (WebCore::RenderFileUploadInnerFileBox::calcMinMaxWidth):
3713         (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement):
3714         (WebCore::HTMLFileUploadInnerButtonElement::createRenderer):
3715         * rendering/RenderFileUploadControl.h: Added. This is the replacement
3716         for RenderFileButton.h.
3717         (WebCore::RenderFileUploadControl::renderName):
3718         * rendering/RenderStyle.cpp: Add support for
3719         -webkit-file-upload-button pseudo element.
3720         (WebCore::):
3721         (WebCore::pseudoBit):
3722         * rendering/RenderStyle.h: Ditto.
3723         (WebCore::RenderStyle::):
3724
3725 2006-09-12  Anders Carlsson  <acarlsson@apple.com>
3726
3727         Reviewed by John Sullivan.
3728
3729         Do the plugin object cleanup in Frame::clear instead of setView.
3730
3731         * bridge/mac/FrameMac.h:
3732         * bridge/mac/FrameMac.mm:
3733         (WebCore::FrameMac::setView):
3734         (WebCore::FrameMac::cleanupPluginObjects):
3735         * page/Frame.cpp:
3736         (WebCore::Frame::clear):
3737         * page/Frame.h:
3738
3739 2006-09-12  MorganL  <morlmor@yahoo.com>
3740
3741         Reviewed/landed by aroben.
3742
3743         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10822
3744         windows build is busted
3745
3746         * WebCore.vcproj/WebCore/WebCore.vcproj: Add missing
3747         JSRangeException.{cpp,h} to project
3748
3749 2006-09-12  David Hyatt  <hyatt@apple.com>
3750
3751         Fix fieldsets so that they properly expand to enclose overhanging floats
3752         when the fieldset has auto height.  This is a nifty undocumented behavior
3753         of the fieldset element.  The bug is 3898.
3754
3755         Reviewed by mjs
3756
3757         Added fast/forms/fieldset-with-float.html
3758
3759         * rendering/RenderBlock.cpp:
3760         (WebCore::RenderBlock::layoutBlock):
3761         * rendering/RenderFieldset.h:
3762         (WebCore::RenderFieldset::renderName):
3763         (WebCore::RenderFieldset::expandsToEncloseOverhangingFloats):
3764         * rendering/RenderObject.h:
3765         (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
3766         * rendering/RenderTableCell.h:
3767         (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats):
3768
3769 2006-09-11  Eric Seidel  <eric@eseidel.com>
3770
3771         Reviewed by hyatt.
3772
3773         REGRESSION: When dragging a link on a page, the selected link doesn't display it's name or URL
3774         http://bugzilla.opendarwin.org/show_bug.cgi?id=10819
3775         http://bugzilla.opendarwin.org/show_bug.cgi?id=10814
3776
3777         No test cases were harmed in the coding of the patch.
3778
3779         * platform/mac/WebCoreTextRenderer.mm:
3780         (WebCoreDrawTextAtPoint):
3781
3782 2006-09-11  David Hyatt  <hyatt@apple.com>
3783
3784         Fix for bug 8126, column widths apply to the border boxes of cells.
3785
3786         Reviewed by aroben
3787
3788         * rendering/RenderTableCell.cpp:
3789         (WebCore::RenderTableCell::styleOrColWidth):
3790
3791 2006-09-11  Nikolas Zimmermann  <zimmermann@kde.org>
3792
3793         Reviewed by Adele.
3794
3795         Fix Qt/Linux build.
3796
3797         * CMakeLists.txt: Add dom/RangeException.idl to build & fix feature defines.
3798
3799 2006-09-11  Nikolas Zimmermann  <zimmermann@kde.org>
3800
3801         Reviewed by eseidel.  Landed by eseidel.
3802
3803         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10750
3804
3805         This finally fixes the SVGAnimated* classes JS bindings!
3806
3807         - Move all SVGAnimated*.idl files from ksvg2/bindings/idl/svg to ksvg2/svg
3808         - Adjust XCode/Qt build files to generate the new idl files
3809
3810         - Remove all SVGAnimated* primitives cpp implementations (Angle/Boolean/Color/Enumeration/Integer/Length/
3811                                                                   LengthList/Number/NumberList/PreserveAspectRatio/
3812                                                                   Rect/String/TransformList)
3813
3814         - Remove unneeded methods from CodeGenerator.pm and add new helper function: IsSVGAnimatedType
3815         - Adjust CodeGeneratorJS.pm to the new SVGAnimated* tear-off concept
3816
3817         - Add two new macros: ANIMATED_PROPERTY_EMPTY_DECLARATIONS / ANIMATED_PROPERTY_FORWARD_DECLARATIONS.
3818           This is used to fix multiple-inheritance issues in SVG with properties,
3819           similar like SVGTests::isValid() was fixed.
3820
3821         - Rewrote SVGList using WTF::Vector, instead of DeprecatedPtrList and killed DOMList.
3822           (SVGAnimated*Lists work again now)
3823
3824         - Adjust macros in SVGElement to create the "*Animated" tear-off classes.
3825
3826         - Adjust all SVG classes which use the ANIMATED macros to include the ClassName as first param in the header.
3827
3828         * CMakeLists.txt:
3829         * DerivedSources.make:
3830         * WebCore.xcodeproj/project.pbxproj:
3831         * bindings/scripts/CodeGenerator.pm:
3832         * bindings/scripts/CodeGeneratorJS.pm:
3833         * kcanvas/RenderSVGImage.cpp:
3834         (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
3835         (WebCore::RenderSVGImage::paint):
3836         * kcanvas/RenderSVGText.cpp:
3837         (WebCore::RenderSVGText::translationForAttributes):
3838         * ksvg2/ksvg.h:
3839         * ksvg2/misc/SVGDocumentExtensions.h:
3840         (WebCore::FloatRect):
3841         * ksvg2/svg/SVGAElement.h:
3842         * ksvg2/svg/SVGAnimateColorElement.cpp:
3843         * ksvg2/svg/SVGAnimateColorElement.h:
3844         * ksvg2/svg/SVGAnimateTransformElement.h:
3845         * ksvg2/svg/SVGAnimatedTemplate.h:
3846         (WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate):
3847         * ksvg2/svg/SVGAnimationElement.h:
3848         * ksvg2/svg/SVGCircleElement.h:
3849         * ksvg2/svg/SVGClipPathElement.h:
3850         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
3851         (SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
3852         (SVGComponentTransferFunctionElement::transferFunction):
3853         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
3854         * ksvg2/svg/SVGCursorElement.h:
3855         * ksvg2/svg/SVGDefsElement.h:
3856         * ksvg2/svg/SVGElement.h:
3857         * ksvg2/svg/SVGElementInstanceList.cpp:
3858         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
3859         * ksvg2/svg/SVGElementInstanceList.h:
3860         * ksvg2/svg/SVGEllipseElement.h:
3861         * ksvg2/svg/SVGExternalResourcesRequired.h:
3862         * ksvg2/svg/SVGFEBlendElement.h:
3863         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3864         (SVGFEColorMatrixElement::SVGFEColorMatrixElement):
3865         (SVGFEColorMatrixElement::parseMappedAttribute):
3866         (SVGFEColorMatrixElement::filterEffect):
3867         * ksvg2/svg/SVGFEColorMatrixElement.h:
3868         * ksvg2/svg/SVGFEComponentTransferElement.h:
3869         * ksvg2/svg/SVGFECompositeElement.h:
3870         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
3871         * ksvg2/svg/SVGFEDisplacementMapElement.h:
3872         * ksvg2/svg/SVGFEFloodElement.h:
3873         * ksvg2/svg/SVGFEGaussianBlurElement.h:
3874         * ksvg2/svg/SVGFEImageElement.h:
3875         * ksvg2/svg/SVGFELightElement.h:
3876         * ksvg2/svg/SVGFEMergeNodeElement.h:
3877         * ksvg2/svg/SVGFEOffsetElement.h:
3878         * ksvg2/svg/SVGFESpecularLightingElement.h:
3879         * ksvg2/svg/SVGFETileElement.h:
3880         * ksvg2/svg/SVGFETurbulenceElement.h:
3881         * ksvg2/svg/SVGFilterElement.h:
3882         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
3883         * ksvg2/svg/SVGFitToViewBox.cpp:
3884         (WebCore::SVGFitToViewBox::SVGFitToViewBox):
3885         (WebCore::SVGFitToViewBox::parseViewBox):
3886         (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
3887         * ksvg2/svg/SVGFitToViewBox.h:
3888         * ksvg2/svg/SVGForeignObjectElement.h:
3889         * ksvg2/svg/SVGGElement.h:
3890         * ksvg2/svg/SVGGradientElement.cpp:
3891         (SVGGradientElement::SVGGradientElement):
3892         * ksvg2/svg/SVGGradientElement.h:
3893         * ksvg2/svg/SVGHelper.cpp:
3894         (WebCore::SVGHelper::PercentageOfViewport):
3895         * ksvg2/svg/SVGImageElement.h:
3896         * ksvg2/svg/SVGLength.cpp:
3897         * ksvg2/svg/SVGLengthList.cpp:
3898         (WebCore::SVGLengthList::SVGLengthList):
3899         (WebCore::SVGLengthList::parse):
3900         * ksvg2/svg/SVGLengthList.h:
3901         * ksvg2/svg/SVGLineElement.h:
3902         * ksvg2/svg/SVGLinearGradientElement.h:
3903         * ksvg2/svg/SVGList.h:
3904         (WebCore::SVGListBase::SVGListBase):
3905         (WebCore::SVGListBase::~SVGListBase):
3906         (WebCore::SVGListBase::numberOfItems):
3907         (WebCore::SVGListBase::clear):
3908         (WebCore::SVGListBase::initialize):
3909         (WebCore::SVGListBase::getFirst):
3910         (WebCore::SVGListBase::getLast):
3911         (WebCore::SVGListBase::getItem):
3912         (WebCore::SVGListBase::insertItemBefore):
3913         (WebCore::SVGListBase::replaceItem):
3914         (WebCore::SVGListBase::removeItem):
3915         (WebCore::SVGListBase::appendItem):
3916         (WebCore::SVGList::nullItem):
3917         (WebCore::):
3918         * ksvg2/svg/SVGLocatable.cpp:
3919         * ksvg2/svg/SVGMarkerElement.h:
3920         * ksvg2/svg/SVGMaskElement.h:
3921         * ksvg2/svg/SVGNumberList.cpp:
3922         (SVGNumberList::SVGNumberList):
3923         (SVGNumberList::parse):
3924         * ksvg2/svg/SVGNumberList.h:
3925         * ksvg2/svg/SVGPathElement.cpp:
3926         (WebCore::SVGPathElement::pathSegList):
3927         * ksvg2/svg/SVGPathElement.h:
3928         * ksvg2/svg/SVGPathSegList.cpp:
3929         (WebCore::SVGPathSegList::SVGPathSegList):
3930         * ksvg2/svg/SVGPathSegList.h:
3931         * ksvg2/svg/SVGPatternElement.cpp:
3932         (WebCore::SVGPatternElement::SVGPatternElement):
3933         * ksvg2/svg/SVGPatternElement.h:
3934         * ksvg2/svg/SVGPointList.cpp:
3935         (SVGPointList::SVGPointList):
3936         * ksvg2/svg/SVGPointList.h:
3937         * ksvg2/svg/SVGPolyElement.cpp:
3938         (SVGPolyElement::points):
3939         (SVGPolyElement::svgPolyTo):
3940         (SVGPolyElement::notifyAttributeChange):
3941         * ksvg2/svg/SVGPolyElement.h:
3942         * ksvg2/svg/SVGPolygonElement.cpp:
3943         (SVGPolygonElement::toPathData):
3944         * ksvg2/svg/SVGPolylineElement.cpp:
3945         (SVGPolylineElement::toPathData):
3946         * ksvg2/svg/SVGPreserveAspectRatio.h:
3947         (WebCore::SVGPreserveAspectRatio::):
3948         * ksvg2/svg/SVGRadialGradientElement.h:
3949         * ksvg2/svg/SVGRectElement.h:
3950         * ksvg2/svg/SVGSVGElement.cpp:
3951         (WebCore::SVGSVGElement::SVGSVGElement):
3952         (WebCore::SVGSVGElement::parseMappedAttribute):
3953         (WebCore::SVGSVGElement::createRenderer):
3954         * ksvg2/svg/SVGSVGElement.h:
3955         * ksvg2/svg/SVGScriptElement.h:
3956         * ksvg2/svg/SVGStopElement.h:
3957         * ksvg2/svg/SVGStringList.cpp:
3958         (WebCore::SVGStringList::SVGStringList):
3959         (WebCore::SVGStringList::reset):
3960         * ksvg2/svg/SVGStringList.h:
3961         * ksvg2/svg/SVGStyledElement.h:
3962         * ksvg2/svg/SVGStyledLocatableElement.cpp:
3963         * ksvg2/svg/SVGStyledTransformableElement.cpp:
3964         (SVGStyledTransformableElement::SVGStyledTransformableElement):
3965         * ksvg2/svg/SVGStyledTransformableElement.h:
3966         * ksvg2/svg/SVGSwitchElement.h:
3967         * ksvg2/svg/SVGSymbolElement.h:
3968         * ksvg2/svg/SVGTRefElement.h:
3969         * ksvg2/svg/SVGTests.cpp:
3970         (WebCore::SVGTests::isValid):
3971         * ksvg2/svg/SVGTextContentElement.h:
3972         * ksvg2/svg/SVGTextElement.cpp:
3973         (WebCore::SVGTextElement::SVGTextElement):
3974         * ksvg2/svg/SVGTextElement.h:
3975         * ksvg2/svg/SVGTextPositioningElement.cpp:
3976         (SVGTextPositioningElement::SVGTextPositioningElement):
3977         (SVGTextPositioningElement::parseMappedAttribute):
3978         * ksvg2/svg/SVGTextPositioningElement.h:
3979         * ksvg2/svg/SVGTransformList.cpp:
3980         (SVGTransformList::SVGTransformList):
3981         (SVGTransformList::createSVGTransformFromMatrix):
3982         (SVGTransformList::consolidate):
3983         (SVGTransformList::concatenate):
3984         * ksvg2/svg/SVGTransformList.h:
3985         * ksvg2/svg/SVGURIReference.h:
3986         * ksvg2/svg/SVGUseElement.h:
3987         * ksvg2/svg/SVGViewElement.h:
3988
3989 2006-09-11  Adam Roben  <aroben@apple.com>
3990
3991         Rubberstamped by Adele.
3992
3993         Rename LocalGraphicsContext.{h,mm} to
3994         LocalCurrentGraphicsContext.{h,mm} to match the class name.
3995
3996         * WebCore.xcodeproj/project.pbxproj:
3997         * platform/mac/LocalCurrentGraphicsContext.mm: Added.
3998         * platform/mac/LocalCurrentGraphicsContext.h: Added.
3999         * platform/mac/LocalGraphicsContext.h: Removed.
4000         * platform/mac/LocalGraphicsContext.mm: Removed.
4001         * rendering/RenderThemeMac.mm: Fix #include to match renamed file
4002
4003 2006-09-11  Brady Eidson  <beidson@apple.com>
4004
4005         Build fix
4006
4007         * WebCore.xcodeproj/project.pbxproj:
4008
4009 2006-09-11  Kevin McCullough  <KMcCullough@apple.com>
4010
4011         Reviewed by Darin.
4012
4013         - Implements comparePoint on the Range class
4014
4015         - Exposes RangeExceptions in JavaScript
4016
4017         * DerivedSources.make:
4018         * WebCore.xcodeproj/project.pbxproj:
4019         * bindings/js/kjs_binding.cpp:
4020         * bindings/objc/DOMInternal.mm:
4021         * dom/Range.cpp:
4022         (WebCore::Range::comparePoint):
4023         (WebCore::Range::compareNode):
4024         * dom/Range.h:
4025         (WebCore::Range::):
4026         * dom/Range.idl:
4027         * dom/RangeException.h: Added.
4028         (WebCore::):
4029         * dom/RangeException.idl: Added.
4030         * page/DOMWindow.idl:
4031
4032 2006-09-11  Adam Roben  <aroben@apple.com>
4033
4034         Reviewed by timo.
4035
4036         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10812
4037         Move LocalGraphicsContext out of RenderThemeMac
4038
4039         * WebCore.xcodeproj/project.pbxproj:
4040         * platform/mac/LocalGraphicsContext.h: Added.
4041         * platform/mac/LocalGraphicsContext.mm: Added.
4042         (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
4043         (WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
4044         * rendering/RenderThemeMac.mm:
4045
4046 2006-09-11  Vladimir Olexa  <vladimir.olexa@gmail.com>
4047
4048         Reviewed by Darin.
4049
4050         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10323
4051           REGRESSION: javascript: URL containing '\\' gets passed as '//'
4052
4053         Test: fast/dom/javascript-backslash.html
4054
4055         * platform/KURL.cpp: (WebCore::KURL::init): Don't do backslash
4056         substitution in JavaScript URLs.
4057
4058 2006-09-11  Sam Weinig  <sam.weinig@gmail.com>
4059
4060         Reviewed by Darin and Tim H.
4061
4062         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10792
4063         Remove the [Exclude=LANGUAGE] idiom from IDL's and code generators
4064         for something better
4065
4066         - Replaces [Exclude=LANGUAGE] idiom with preprocessor #if defined(LANGUAGE)
4067           idiom.
4068
4069         - Assorted whitespace changes to IDL files.
4070
4071         * DerivedSources.make:
4072         * WebCore.xcodeproj/project.pbxproj:
4073         * bindings/objc/DOMEvents.h:
4074         * bindings/scripts/CodeGenerator.pm:
4075         * bindings/scripts/CodeGeneratorJS.pm:
4076         * bindings/scripts/CodeGeneratorObjC.pm:
4077         * css/CSSRule.idl:
4078         * css/CSSStyleDeclaration.idl:
4079         * css/CSSValue.idl:
4080         * dom/DOMImplementation.idl:
4081         * dom/Document.idl:
4082         * dom/Element.idl:
4083         * dom/Event.idl:
4084         * dom/KeyboardEvent.idl:
4085         * dom/MouseEvent.idl:
4086         * dom/NamedNodeMap.idl:
4087         * dom/NodeFilter.idl:
4088         * dom/UIEvent.idl:
4089         * dom/WheelEvent.idl:
4090         * html/HTMLAnchorElement.idl:
4091         * html/HTMLAreaElement.idl:
4092         * html/HTMLDocument.idl:
4093         * html/HTMLElement.idl:
4094         * html/HTMLImageElement.idl:
4095         * html/HTMLInputElement.idl:
4096         * html/HTMLLinkElement.idl:
4097         * html/HTMLOptionsCollection.idl:
4098
4099 2006-09-11  David Hyatt  <hyatt@apple.com>
4100
4101         Fix an unwitting victim of the kMin->min change.  calcBlockMinMaxWidth
4102         was accidentally renamed to calcBlominMaxWidth.
4103
4104         * rendering/RenderBlock.cpp:
4105         (WebCore::RenderBlock::calcMinMaxWidth):
4106         (WebCore::RenderBlock::calcBlockMinMaxWidth):
4107         * rendering/RenderBlock.h:
4108
4109 2006-09-10  David Hyatt  <hyatt@apple.com>
4110
4111         Rework the printer font stuff a little bit so that the Font API doesn't
4112         have to be changed.
4113
4114         Reviewed by eseidel
4115
4116         * WebCore.xcodeproj/project.pbxproj:
4117         * bridge/mac/WebCoreStringTruncator.mm:
4118         (truncateString):
4119         (+[WebCoreStringTruncator widthOfString:font:]):
4120         * platform/Font.cpp:
4121         (WebCore::Font::drawSimpleText):
4122         * platform/Font.h:
4123         * platform/TextStyle.h:
4124         (WebCore::TextStyle::TextStyle):
4125         (WebCore::TextStyle::attemptFontSubstitution):
4126         (WebCore::TextStyle::setRTL):
4127         * platform/mac/FontMac.mm:
4128         (WebCore::m_wordSpacing):
4129         (WebCore::Font::drawGlyphs):
4130         * platform/mac/ListBoxMac.mm:
4131         (itemTextRenderer):
4132         (groupLabelTextRenderer):
4133         (-[WebCoreTableView drawRow:clipRect:]):
4134         * platform/mac/PopUpButtonMac.mm:
4135         (PopUpButton::sizeHint):
4136         * platform/mac/TextFieldMac.mm:
4137         (-[NSSearchFieldCell _addStringToRecentSearches:]):
4138         * platform/mac/WebCoreTextRenderer.mm:
4139         (WebCoreDrawTextAtPoint):
4140         (WebCoreTextFloatWidth):
4141         * rendering/EllipsisBox.cpp:
4142         (WebCore::EllipsisBox::paint):
4143         * rendering/InlineTextBox.cpp:
4144         (WebCore::InlineTextBox::paint):
4145         * rendering/RenderImage.cpp:
4146         (WebCore::RenderImage::paint):
4147         * rendering/RenderListMarker.cpp:
4148         (WebCore::RenderListMarker::paint):
4149
4150 2006-09-10  Brady Eidson  <beidson@apple.com>
4151
4152         Reviewed by Maciej
4153
4154         Small cleanups + future plans
4155
4156         * loader/icon/IconDatabase.cpp:
4157         (WebCore::IconDatabase::open): path separator cleanup
4158         * platform/Image.h:
4159
4160 2006-09-10  Brady Eidson  <beidson@apple.com>
4161
4162         Reviewed by Maciej
4163
4164         Added specialized HashTraits
4165
4166         * platform/IntSizeHash.h:
4167
4168 2006-09-10  Brady Eidson  <beidson@apple.com>
4169
4170         Forgetting header #define protection is BAAAAAD
4171         (and re-alphabetized the project file)
4172
4173         * WebCore.xcodeproj/project.pbxproj:
4174         * platform/IntSizeHash.h:
4175
4176 2006-09-10  Brady Eidson  <beidson@apple.com>
4177
4178         Reviewed by Maciej
4179
4180         Moved the custom IntSize hash out of IconDatabase into a more generally useful file
4181
4182         * WebCore.xcodeproj/project.pbxproj:
4183         * loader/icon/IconDatabase.h:
4184         * platform/IntSizeHash.h: Added.
4185
4186 2006-09-10  David Hyatt  <hyatt@apple.com>
4187
4188         Fix for bug 10801, form controls that get styled suddenly lose their
4189         intrinsic margins.  Move the intrinsic margin addition code into
4190         adjustRenderStyle and get it out of the theme code and the old form control
4191         code.
4192
4193         Reviewed by aroben
4194
4195         * css/cssstyleselector.cpp:
4196         (WebCore::addIntrinsicMargins):
4197         (WebCore::CSSStyleSelector::adjustRenderStyle):
4198         * css/html4.css:
4199         * rendering/DeprecatedRenderSelect.h:
4200         (WebCore::DeprecatedRenderSelect::calcReplacedHeight):
4201         * rendering/DeprecatedSlider.h:
4202         * rendering/RenderFormElement.cpp:
4203         (WebCore::RenderFormElement::setStyle):
4204         * rendering/RenderFormElement.h:
4205         * rendering/RenderLayer.cpp:
4206         (WebCore::RenderLayer::resize):
4207         * rendering/RenderThemeMac.h:
4208         * rendering/RenderThemeMac.mm:
4209         (WebCore::RenderThemeMac::adjustButtonStyle):
4210         (WebCore::RenderThemeMac::adjustTextFieldStyle):
4211         (WebCore::RenderThemeMac::adjustTextAreaStyle):
4212         (WebCore::RenderThemeMac::adjustMenuListStyle):
4213         (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
4214         * rendering/RenderThemeWin.cpp:
4215         (WebCore::RenderThemeWin::adjustButtonStyle):
4216         (WebCore::RenderThemeWin::adjustTextFieldStyle):
4217         (WebCore::RenderThemeWin::adjustTextAreaStyle):
4218
4219 2006-09-10  Darin Adler  <darin@apple.com>
4220
4221         - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10547
4222
4223         * manual-tests/target-test.html: Added.
4224         * manual-tests/targeted.html: Added.
4225
4226 2006-09-10  Eric Seidel  <eric@eseidel.com>
4227
4228         Reviewed by darin.
4229
4230         Remove a bunch more NSGraphicsContext related code.
4231         Add a LocalCurrentGraphicsContext to simplify methods which need to call up into AppKit controls (and thus depend on the [NSGraphicsContext currentContext] being set correctly)
4232         Add an "isPrinting" flag to many of the text drawing functions in order to avoid the need for a GraphicsContext::isPrinting() function.
4233
4234         No tests were harmed in the making of this patch.
4235
4236         * bridge/mac/WebCoreFrameBridge.mm:
4237         (-[WebCoreFrameBridge drawRect:]):
4238         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
4239         (WebCore::KRenderingDeviceContextQuartz::cgContext):
4240         (WebCore::KRenderingDeviceQuartz::isBuffered):
4241         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
4242         (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz):
4243         (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz):
4244         * kcanvas/device/quartz/QuartzSupport.mm:
4245         * platform/Font.cpp:
4246         (WebCore::Font::drawSimpleText):
4247         (WebCore::Font::drawText):
4248         * platform/Font.h:
4249         * platform/GraphicsContext.cpp:
4250         (WebCore::GraphicsContext::drawText):
4251         * platform/GraphicsContext.h:
4252         * platform/mac/FileButtonMac.mm:
4253         (-[WebFileChooserButton drawRect:]):
4254         * platform/mac/FontMac.mm:
4255         (WebCore::ATSULayoutParameters::ATSULayoutParameters):
4256         (WebCore::ATSULayoutParameters::initialize):
4257         (WebCore::Font::drawComplexText):
4258         (WebCore::Font::drawGlyphs):
4259         * platform/mac/GraphicsContextMac.mm:
4260         (WebCore::GraphicsContext::drawLineForMisspelling):
4261         * platform/mac/ListBoxMac.mm:
4262         (-[WebCoreTableView drawRow:clipRect:]):
4263   &