WebCore/ChangeLog

   1 2009-10-27  Dan Bernstein  <mitz@apple.com>
   2
   3         Reviewed by Darin Adler.
   4
   5         Updated Apple license
   6
   7         * LICENSE-APPLE:
   8
   9 2009-10-27  Brady Eidson  <beidson@apple.com>
  10
  11         Rubberstamped by Sam Weinig.
  12
  13         Re-enable the check that disallows pages with unload handlers in the page cache.
  14
  15         <rdar://problem/7196485> and http://webkit.org/b/29021
  16
  17         * loader/FrameLoader.cpp:
  18         (WebCore::FrameLoader::canCachePageContainingThisFrame):
  19         (WebCore::FrameLoader::logCanCacheFrameDecision):
  20
  21 2009-10-27  Timothy Hatcher  <timothy@apple.com>
  22
  23         Remove more empty files that didn't get removed earlier.
  24
  25         * inspector/DOMDispatchTimelineItem.cpp: Removed.
  26         * inspector/DOMDispatchTimelineItem.h: Removed.
  27
  28 2009-10-27  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
  29
  30         Reviewed by Tor Arne Vestbø.
  31
  32         [Qt] Fix assertion crashes introduced by changes made in r50110.
  33
  34         * dom/XMLTokenizerQt.cpp:
  35         (WebCore::XMLTokenizer::parseEndElement): only call popCurrentNode() if there are nodes left in the stack.
  36
  37 2009-10-27  Timothy Hatcher  <timothy@apple.com>
  38
  39         Remove empty files that didn't get removed earlier.
  40
  41         * inspector/TimelineItem.cpp: Removed.
  42         * inspector/TimelineItem.h: Removed.
  43
  44 2009-10-27  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
  45
  46         Reviewed by Xan Lopez.
  47
  48         https://bugs.webkit.org/show_bug.cgi?id=25534
  49         [GTK] Objects of ROLE_TABLE should implement the accessible table interface
  50
  51         First part of the implementation of AtkTable.
  52
  53         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  54         (getCell):
  55         (getCellIndex):
  56         (webkit_accessible_table_ref_at):
  57         (webkit_accessible_table_get_index_at):
  58         (webkit_accessible_table_get_n_columns):
  59         (webkit_accessible_table_get_n_rows):
  60         (webkit_accessible_table_get_column_extent_at):
  61         (webkit_accessible_table_get_row_extent_at):
  62         (webkit_accessible_table_get_row_header):
  63         (atk_table_interface_init):
  64         (AtkInterfacesInitFunctions):
  65         (GetAtkInterfaceTypeFromWAIType):
  66
  67 2009-10-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
  68
  69         Reviewed by Lars Knoll.
  70
  71         [Qt] Don't lose remainder when computing wheel event deltas
  72
  73         * platform/qt/WheelEventQt.cpp:
  74
  75 2009-10-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
  76
  77         Reviewed by Antti Koivisto.
  78
  79         Fix QtWebKit build for WIN_OS if Netscape plug-in support
  80         is turned off and refactor some related code
  81         https://bugs.webkit.org/show_bug.cgi?id=30786
  82
  83         No new tests as there is no new functionality introduced.
  84
  85         * platform/FileSystem.h: Refactor to make sure that each different
  86         type definition is only repeated once.
  87
  88         * plugins/PluginPackage.cpp:
  89         (WebCore::PluginPackage::compareFileVersion): Move it out from the
  90         ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH guard and combine it with the
  91         function body from PluginPackageWin.
  92
  93         * plugins/win/PluginPackageWin.cpp: Remove compareFileVersion as
  94         it is now in PluginPackage.cpp.
  95
  96 2009-10-26  Xan Lopez  <xlopez@igalia.com>
  97
  98         Reviewed by Gustavo Noronha.
  99
 100         https://bugs.webkit.org/show_bug.cgi?id=27011
 101         [Gtk] Implement support for get_index_in_parent
 102
 103         Implement atk_object_get_index_in_parent.
 104
 105         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
 106         (webkit_accessible_get_index_in_parent):
 107
 108 2009-10-27  Eric Seidel  <eric@webkit.org>
 109
 110         No review, rolling out r50131.
 111         http://trac.webkit.org/changeset/50131
 112
 113         * bridge/objc/objc_instance.h:
 114         * bridge/objc/objc_instance.mm:
 115         (ObjcInstance::ObjcInstance):
 116         (ObjcInstance::virtualEnd):
 117
 118 2009-10-26  Daniel Bates  <dbates@webkit.org>
 119
 120         Reviewed by Darin Adler.
 121
 122         https://bugs.webkit.org/show_bug.cgi?id=30491
 123
 124         Fixes an issue where pressing return/enter on the keyboard
 125         in <isindex> does not submit it if is not within a <form>.
 126
 127         According to the HTML 2.0 thru HTML 4.01 spec
 128         (http://www.w3.org/MarkUp/html-spec/html-spec_7.html#SEC7.5), the
 129         <isindex> element does not need to be within a <form> element in
 130         order to submit it. It can submitted on its own. Also, if present,
 131         the href property of the <base> element will dictate where to submit
 132         the value of the <isindex> element (this is analogous to the action
 133         property of the <form> element).
 134
 135         Tests: http/tests/misc/isindex-with-no-form-base-href.html
 136                http/tests/misc/isindex-with-no-form.html
 137
 138         * html/HTMLInputElement.cpp:
 139         (WebCore::HTMLInputElement::defaultEventHandler): Calls createTemporaryFormForIsIndex()
 140         to create a <form> if none is present and we are an <isindex> element.
 141         (WebCore::HTMLInputElement::createTemporaryFormForIsIndex): Added.
 142         * html/HTMLInputElement.h:
 143
 144 2009-10-26  Oliver Hunt  <oliver@apple.com>
 145
 146         Reviewed by Maciej Stachowiak.
 147
 148         Crash occurs after launching Newsfire 1.6 for the first time
 149         https://bugs.webkit.org/show_bug.cgi?id=30807
 150
 151         Use a RetainPtr in ObjcBinding to ensure that we adequately
 152         protect the autorelease pool from GC in GC'd applications.
 153
 154         * bridge/objc/objc_instance.h:
 155         * bridge/objc/objc_instance.mm:
 156         (ObjcInstance::ObjcInstance):
 157         (ObjcInstance::virtualEnd):
 158
 159 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 160
 161         Unreviewed.
 162
 163         [Qt] Build fix for QtWebKit after r50125.
 164
 165         * WebCore.pro: Rename TimelineItem to TimelineRecord.
 166
 167 2009-10-26  Matt Mueller  <mattm@chromium.org>
 168
 169         Reviewed by Darin Adler.
 170
 171         Refactor synchronizable property handling to store one shouldSynchronize flag per set of properties rather than one per property.
 172
 173         Fixes reading uninitialized memory in SynchronizableProperty hash function as well as simplifying the code.
 174
 175         https://bugs.webkit.org/show_bug.cgi?id=30658
 176
 177         Covered by running various svg tests under valgrind, ex:
 178         LayoutTests/svg/custom/js-late-mask-and-object-creation.svg
 179
 180         * svg/SynchronizablePropertyController.cpp:
 181         (WebCore::SynchronizableProperties::addProperty):
 182         (WebCore::SynchronizableProperties::synchronize):
 183         (WebCore::SynchronizableProperties::startAnimation):
 184         (WebCore::SynchronizableProperties::stopAnimation):
 185         (WebCore::SynchronizablePropertyController::registerProperty):
 186         (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization):
 187         (WebCore::SynchronizablePropertyController::synchronizeProperty):
 188         (WebCore::SynchronizablePropertyController::synchronizeAllProperties):
 189         (WebCore::SynchronizablePropertyController::startAnimation):
 190         (WebCore::SynchronizablePropertyController::stopAnimation):
 191         * svg/SynchronizablePropertyController.h:
 192         (WebCore::SynchronizableProperties::SynchronizableProperties):
 193         (WebCore::SynchronizableProperties::setNeedsSynchronization):
 194
 195 2009-10-26  Kelly Norton  <knorton@google.com>
 196
 197         Reviewed by Timothy Hatcher.
 198
 199         Renames TimelineItem to TimelineRecord and updates all call sites.
 200         https://bugs.webkit.org/show_bug.cgi?id=30785
 201
 202         * GNUmakefile.am:
 203         * WebCore.gypi:
 204         * WebCore.vcproj/WebCore.vcproj:
 205         * WebCore.xcodeproj/project.pbxproj:
 206         * inspector/InspectorFrontend.cpp:
 207         (WebCore::InspectorFrontend::addRecordToTimeline):
 208         * inspector/InspectorFrontend.h:
 209         * inspector/InspectorTimelineAgent.cpp:
 210         (WebCore::InspectorTimelineAgent::willDispatchDOMEvent):
 211         (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
 212         (WebCore::InspectorTimelineAgent::willLayout):
 213         (WebCore::InspectorTimelineAgent::didLayout):
 214         (WebCore::InspectorTimelineAgent::willRecalculateStyle):
 215         (WebCore::InspectorTimelineAgent::didRecalculateStyle):
 216         (WebCore::InspectorTimelineAgent::willPaint):
 217         (WebCore::InspectorTimelineAgent::didPaint):
 218         (WebCore::InspectorTimelineAgent::willWriteHTML):
 219         (WebCore::InspectorTimelineAgent::didWriteHTML):
 220         (WebCore::InspectorTimelineAgent::didInstallTimer):
 221         (WebCore::InspectorTimelineAgent::didRemoveTimer):
 222         (WebCore::InspectorTimelineAgent::willFireTimer):
 223         (WebCore::InspectorTimelineAgent::didFireTimer):
 224         (WebCore::InspectorTimelineAgent::reset):
 225         (WebCore::InspectorTimelineAgent::addRecordToTimeline):
 226         (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
 227         (WebCore::InspectorTimelineAgent::pushCurrentRecord):
 228         * inspector/InspectorTimelineAgent.h:
 229         (WebCore::):
 230         (WebCore::InspectorTimelineAgent::RecordEntry::RecordEntry):
 231         * inspector/TimelineItemFactory.cpp: Removed.
 232         * inspector/TimelineItemFactory.h: Removed.
 233         * inspector/TimelineRecordFactory.cpp: Added.
 234         (WebCore::TimelineRecordFactory::createGenericRecord):
 235         (WebCore::TimelineRecordFactory::createDOMDispatchRecord):
 236         (WebCore::TimelineRecordFactory::createGenericTimerRecord):
 237         (WebCore::TimelineRecordFactory::createTimerInstallRecord):
 238         * inspector/TimelineRecordFactory.h: Added.
 239         (WebCore::TimelineRecordFactory::TimelineRecordFactory):
 240         * inspector/front-end/TimelineAgent.js:
 241         (WebInspector.addRecordToTimeline):
 242         * inspector/front-end/TimelinePanel.js:
 243         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
 244         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
 245         (WebInspector.TimelinePanel.prototype.getRecordTypeName):
 246         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
 247
 248 2009-10-26  Girish Ramakrishnan  <girish@forwardbias.in>
 249
 250         Reviewed by Antti Koivisto.
 251
 252         [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled
 253
 254         When printing, QPrinter's preview mode uses a QPicture to capture the output. The
 255         QPicture holds a reference to the X Pixmap. As a result, the print preview would
 256         update itself when the X Pixmap changes. To prevent the print preview from updating
 257         whenever m_drawable is updated (i.e when the view updates), we create a copy.
 258
 259         We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap
 260         regardless of the graphicssystem. This is taken care of by
 261         commit d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6)
 262
 263         The beauty of this patch is that the newly created X Pixmap is managed by Qt and
 264         it will free the Pixmap whenever the user closes the print preview dialog and
 265         handles the case of displaying multiple preview dialogs nicely.
 266
 267         All credit to Samuel Rødal for suggesting usage of QPixmap::copy().
 268
 269         https://bugs.webkit.org/show_bug.cgi?id=30714
 270
 271         * plugins/qt/PluginViewQt.cpp:
 272         (WebCore::PluginView::paint):
 273
 274 2009-10-26  Benjamin Otte  <otte@gnome.org>
 275
 276         Reviewed by Gustavo Noronha.
 277
 278         Don't store properties in the MediaPlayerPrivate class
 279
 280         Access them via the MediaPlayer class instead.
 281         https://bugs.webkit.org/show_bug.cgi?id=30462
 282
 283         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
 284         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
 285         (WebCore::MediaPlayerPrivate::seek):
 286         (WebCore::MediaPlayerPrivate::setVolume):
 287         (WebCore::MediaPlayerPrivate::setRate):
 288         (WebCore::MediaPlayerPrivate::setVisible):
 289         (WebCore::MediaPlayerPrivate::paint):
 290         (WebCore::MediaPlayerPrivate::createGSTPlayBin):
 291         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
 292
 293 2009-10-26  Brian Weinstein  <bweinstein@apple.com>
 294
 295         Reviewed by Timothy Hatcher.
 296
 297         Fixes <http://webkit.org/b/30801>.
 298         Web Inspector: Control + ]/[ on Windows doesn't change Panels.
 299
 300         In my testing, Windows uses "U+00DB" and "U+00DD" to represent
 301         [ and ], so we should honor those as well.
 302
 303         * inspector/front-end/inspector.js:
 304         (WebInspector.documentKeyDown):
 305
 306 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 307
 308         Reviewed by Darin Adler.
 309
 310         Make .rc files compile on Windows without depending on MFC headers
 311         https://bugs.webkit.org/show_bug.cgi?id=30750
 312
 313         * WebCore.vcproj/QTMovieWin.rc: Use winresrc.h because it exists
 314         even when MFC is not installed, and is all that's needed here.
 315
 316 2009-10-26  Brent Fulgham  <bfulgham@webkit.org>
 317
 318         Reviewed by Darin Adler.
 319
 320         Build corrections for ENABLE_FILTERS in Windows.
 321         https://bugs.webkit.org/show_bug.cgi?id=30797
 322
 323         Build correction for ENABLE_FILTERS feature.  No new tests needed.
 324
 325         * platform/graphics/filters/FEColorMatrix.cpp: Use MathExtras.h and
 326           its piDouble constant.
 327         * platform/graphics/filters/FEGaussianBlur.cpp: Use MathExtras.h and
 328           its piDouble constant.  Remove unnecessary call to floor used in
 329           the division of an unsigned, converting to int.
 330         * platform/graphics/win/SimpleFontDataCairoWin.cpp: Correct include
 331           style for MathExtras.h.
 332
 333 2009-10-26  Brady Eidson  <beidson@apple.com>
 334
 335         Reviewed by Darin Adler.
 336
 337         <rdar://problem/7289467> and http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load.
 338
 339         Test: fast/loader/grandparent-completion-starts-redirect.html
 340
 341         * loader/FrameLoader.cpp:
 342         (WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children.
 343
 344 2009-10-26  Dan Bernstein  <mitz@apple.com>
 345
 346         Reviewed by Beth Dakin.
 347
 348         Re-add CSSPropertyWebkitBackgroundSize in one more place
 349
 350         Fixes transitions/multiple-background-size-transitions.html, transitions/background-transitions.html
 351
 352         * page/animation/AnimationBase.cpp:
 353         (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
 354
 355 2009-10-26  Jeremy Orlow  <jorlow@chromium.org>
 356
 357         Reviewed by Dimitri Glazkov.
 358
 359         [V8] Tidy up the DOM Storage runtime flag stuff
 360         https://bugs.webkit.org/show_bug.cgi?id=30794
 361
 362         Clean up the DOM Storage runtime flag stuff to match the new way of doing
 363         things.  No behavioral changes.
 364
 365         * bindings/v8/RuntimeEnabledFeatures.cpp:
 366         * bindings/v8/RuntimeEnabledFeatures.h:
 367         (WebCore::RuntimeEnabledFeatures::setDatabaseEnabled):
 368         (WebCore::RuntimeEnabledFeatures::databaseEnabled):
 369         (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled):
 370         (WebCore::RuntimeEnabledFeatures::localStorageEnabled):
 371         (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled):
 372         (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
 373         * bindings/v8/custom/V8DOMWindowCustom.cpp:
 374         (WebCore::ACCESSOR_RUNTIME_ENABLER):
 375         * storage/Storage.cpp:
 376         * storage/Storage.h:
 377
 378 2009-10-26  Brady Eidson  <beidson@apple.com>
 379
 380         Reviewed by Darin Adler.
 381
 382         <rdar://problem/7308952> and http://webkit.org/b/30424 - REGRESSION (r48687): Pages on ucas.com appear blank.
 383
 384         Test: fast/loader/history-forward-in-head.html
 385
 386         * loader/RedirectScheduler.cpp:
 387         (WebCore::RedirectScheduler::scheduleHistoryNavigation): Restore the moved canGoBackOrForward() check.
 388           This restores the side effect of an invalid history navigation canceling previous scheduled redirects
 389           and also fixes the bug of scheduling an invalid history navigation canceling parsing of the current document.
 390         (WebCore::RedirectScheduler::timerFired): Removed the canGoBackOrForward() check as it is now made before
 391           the redirect is scheduled.
 392
 393 2009-10-26  Alexey Proskuryakov  <ap@apple.com>
 394
 395         Reviewed by Darin Adler.
 396
 397         https://bugs.webkit.org/show_bug.cgi?id=30049
 398         <rdar://problem/7286002> Manipulating DOM from a script while parsing XHTML can cause a crash
 399
 400         Tests: fast/parser/remove-current-node-parent-x-2.xhtml
 401                fast/parser/remove-current-node-parent-x.xhtml
 402
 403         * dom/XMLTokenizer.h: Store the whole stack of parent nodes - element.parentNode() is
 404         unreliable after DOM manipulation.
 405
 406         * dom/XMLTokenizer.cpp:
 407         (WebCore::XMLTokenizer::pushCurrentNode): Push the new node onto stack.
 408         (WebCore::XMLTokenizer::popCurrentNode): This is now called instead of setCurrentNode when
 409         exiting a node.
 410         (WebCore::XMLTokenizer::clearCurrentNodeStack): We're aborting; or just done parsing. This
 411         replaces setCurrentNode(0).
 412         (WebCore::XMLTokenizer::enterText): Call pushCurrentNode().
 413         (WebCore::XMLTokenizer::exitText): Call popCurrentNode(), removing a long-standing FIXME
 414         (not sure if it was ever practical though - how can a parent become null while adding text?)
 415
 416         * dom/XMLTokenizerLibxml2.cpp:
 417         (WebCore::XMLTokenizer::~XMLTokenizer): Call clearCurrentNodeStack().
 418         (WebCore::XMLTokenizer::startElementNs): Call pushCurrentNode().
 419         (WebCore::XMLTokenizer::endElementNs): Call popCurrentNode() to safely get to a parent. Also
 420         added a check fo script element still being in document - Firefox parses those that aren't,
 421         but doesn't execute them.
 422
 423         * dom/XMLTokenizerQt.cpp:
 424         (WebCore::XMLTokenizer::~XMLTokenizer):
 425         (WebCore::XMLTokenizer::parseStartElement):
 426         (WebCore::XMLTokenizer::parseEndElement):
 427         Match libxml2 version changes.
 428
 429 2009-10-26  Dan Bernstein  <mitz@apple.com>
 430
 431         Reviewed by Beth Dakin.
 432
 433         background-size: X treated as background-size: X X, not background-size: X auto
 434         https://bugs.webkit.org/show_bug.cgi?id=28440
 435
 436         Updated fast/backgrounds/size/resources/parsing-background-size-values.js
 437         and fast/backgrounds/size/resources/parsing-inherit.js
 438
 439         Reinstated -webkit-background-size and kept its behavior of filling in
 440         the second value with the first one; and changed background-size to have
 441         the behavior of filling in the second value with 'auto'.
 442
 443         * css/CSSComputedStyleDeclaration.cpp:
 444         (computedProperties): Re-added CSSPropertyWebkitBackgroundSize.
 445         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
 446         * css/CSSParser.cpp:
 447         (WebCore::CSSParser::parseValue): Ditto.
 448         (WebCore::CSSParser::parseFillSize): Adapted for the new parsing rule.
 449         (WebCore::CSSParser::parseFillProperty): Re-added
 450         CSSPropertyWebkitBackgroundSize.
 451         (WebCore::cssPropertyID): Removed mapping of -webkit-background-size to
 452         background-size.
 453         * css/CSSParser.h:
 454         * css/CSSPropertyNames.in: Re-added -webkit-background-size.
 455         * css/CSSStyleSelector.cpp:
 456         (WebCore::CSSStyleSelector::applyProperty): Re-added
 457         CSSPropertyWebkitBackgroundSize.
 458
 459 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 460
 461         Reviewed by Eric Seidel.
 462
 463         [Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash
 464         https://bugs.webkit.org/show_bug.cgi?id=30777
 465
 466         No new tests as the crash can be reproduced by existing storage
 467         LayoutTests (by hitting an assert in debug mode Webkit on WIN_OS).
 468
 469         * platform/text/String.cpp:
 470         (WebCore::String::number): Qt's QString::vsprintf does not
 471         understand the "%I64u" format string. Always use the "%lli"
 472         format string for Qt port.
 473
 474 2009-10-26  Tony Chang  <tony@chromium.org>
 475
 476         Reviewed by Eric Seidel.
 477
 478         Roll back r50073 because r50041-50043 were reverted.  r50073 was
 479         a chromium side fix for r50041.
 480         https://bugs.webkit.org/show_bug.cgi?id=30789
 481
 482         * bindings/v8/V8Collection.h:
 483         * bindings/v8/custom/V8CustomBinding.h:
 484         * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
 485         (WebCore::getNamedItems):
 486         (WebCore::getItem):
 487         (WebCore::NAMED_PROPERTY_GETTER):
 488         (WebCore::CALLBACK_FUNC_DECL):
 489         * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
 490         (WebCore::getNamedItems):
 491         (WebCore::getItem):
 492         (WebCore::NAMED_PROPERTY_GETTER):
 493         (WebCore::CALLBACK_FUNC_DECL):
 494         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
 495
 496 2009-10-26  Geoffrey Garen  <ggaren@apple.com>
 497
 498         Reviewed by Dimitri Glazkov.
 499
 500         Fixed https://bugs.webkit.org/show_bug.cgi?id=30765
 501         REGRESSION (r48701): Removing an event listener causes the one added just after it not to fire
 502
 503         and related bugs.
 504
 505         If the event listener being removed is prior to the current firing event
 506         iterator, we need to decrement the current firing event iterator in
 507         addition to the endpoint. (Otherwise, shrinking the event listener vector
 508         by one implicity moves the current firing event iterator forward by one.
 509         It's like relativity, only without the planets.)
 510
 511         Also took the opportunity to change some pointers to references, since
 512         they can't be null.
 513
 514         * dom/EventTarget.cpp:
 515         (WebCore::EventTarget::removeEventListener):
 516         (WebCore::EventTarget::removeAllEventListeners): Update iterator in addition
 517         to end, if need be.
 518         (WebCore::EventTarget::fireEventListeners): Updated for interface changes.
 519         Added a comment to explain a behavior that was implicit enough to be
 520         confusing.
 521
 522         * dom/EventTarget.h:
 523         (WebCore::FiringEventIterator::FiringEventIterator):
 524         (WebCore::EventTarget::isFiringEventListeners): Updated for interface changes.
 525
 526 2009-10-26  Brian Weinstein  <bweinstein@apple.com>
 527
 528         Reviewed by Timothy Hatcher.
 529
 530         Fixes <http://webkit.org/b/30792>.
 531         Web Inspector: When changing resource scope, resource graph can get in weird state.
 532
 533         If the user was scrolled down while looking at All resources, and then just
 534         selects Fonts, or something that doesn't have many resources, then the graph
 535         will stay scrolled down, even when there is no content there.
 536
 537         When the filter is updated, scroll to the top of the graph view, so this won't
 538         happen.
 539
 540         * inspector/front-end/AbstractTimelinePanel.js:
 541         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
 542
 543 2009-10-26  Sam Weinig  <sam@webkit.org>
 544
 545         Fix mac clean build.
 546
 547         * html/HTMLOptionsCollection.idl:
 548
 549 2009-10-26  Pavel Feldman  <pfeldman@chromium.org>
 550
 551         Reviewed by Timothy Hatcher.
 552
 553         Web Inspector: Extract AbstractTimelinePanel that will be a base
 554         class for ResourcesPanel and TimelinePanel.
 555
 556         https://bugs.webkit.org/show_bug.cgi?id=30776
 557
 558         * WebCore.gypi:
 559         * WebCore.vcproj/WebCore.vcproj:
 560         * inspector/front-end/AbstractTimelinePanel.js: Added.
 561         (WebInspector.AbstractTimelinePanel):
 562         (WebInspector.AbstractTimelinePanel.prototype.get categories):
 563         (WebInspector.AbstractTimelinePanel.prototype.showCategory):
 564         (WebInspector.AbstractTimelinePanel.prototype.hideCategory):
 565         (WebInspector.AbstractTimelinePanel.prototype.createTimelinePanels):
 566         (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel.createFilterElement):
 567         (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel):
 568         (WebInspector.AbstractTimelinePanel.prototype.filter):
 569         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
 570         (WebInspector.AbstractTimelinePanel.prototype._createGraph):
 571         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
 572         (WebInspector.AbstractTimelinePanel.prototype._updateSummaryGraph):
 573         (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition):
 574         (WebInspector.AbstractTimelinePanel.prototype.get needsRefresh):
 575         (WebInspector.AbstractTimelinePanel.prototype.set needsRefresh):
 576         (WebInspector.AbstractTimelinePanel.prototype.refreshIfNeeded):
 577         (WebInspector.AbstractTimelinePanel.prototype.show):
 578         (WebInspector.AbstractTimelinePanel.prototype.resize):
 579         (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth):
 580         (WebInspector.TimelineCalculator):
 581         (WebInspector.TimelineCalculator.prototype.computeSummaryValues):
 582         (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
 583         (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels):
 584         (WebInspector.TimelineCalculator.prototype.get boundarySpan):
 585         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
 586         (WebInspector.TimelineCalculator.prototype.reset):
 587         (WebInspector.TimelineCalculator.prototype._value):
 588         (WebInspector.TimelineCalculator.prototype.formatValue):
 589         * inspector/front-end/ResourceCategory.js:
 590         (WebInspector.ResourceCategory):
 591         * inspector/front-end/ResourcesPanel.js:
 592         (WebInspector.ResourcesPanel):
 593         (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get toolbarItemLabel):
 594         (WebInspector.ResourcesPanel.prototype.get statusBarItems):
 595         (WebInspector.ResourcesPanel.prototype.get categories):
 596         (WebInspector.ResourcesPanel.prototype.showCategory):
 597         (WebInspector.ResourcesPanel.prototype.hideCategory):
 598         (WebInspector.ResourcesPanel.prototype.isCategoryVisible):
 599         (WebInspector.ResourcesPanel.prototype.populateSidebar):
 600         (WebInspector.ResourcesPanel.prototype.createPanelEnabler):
 601         (WebInspector.ResourcesPanel.prototype.createStatusbarButtons):
 602         (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime):
 603         (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime):
 604         (WebInspector.ResourcesPanel.prototype.show):
 605         (WebInspector.ResourcesPanel.prototype.resize):
 606         (WebInspector.ResourcesPanel.prototype.reset):
 607         (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
 608         (WebInspector.ResourcesPanel.prototype.updateMainViewWidth):
 609         (WebInspector.ResourceTimeCalculator):
 610         (WebInspector.ResourceTransferSizeCalculator):
 611         (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
 612         * inspector/front-end/SummaryBar.js:
 613         (WebInspector.SummaryBar.prototype.update):
 614         * inspector/front-end/WebKit.qrc:
 615         * inspector/front-end/inspector.html:
 616         * inspector/front-end/inspector.js:
 617         (WebInspector.loaded):
 618
 619 2009-10-26  Avi Drissman  <avi@google.com>
 620
 621         Reviewed by Darin Adler.
 622
 623         Use Helvetica in the Inspector as intended.
 624         https://bugs.webkit.org/show_bug.cgi?id=30787
 625
 626         * inspector/front-end/inspector.css:
 627
 628 2009-10-26  Nate Chapin  <japhet@chromium.org>
 629
 630         Reviewed by Alexey Proskuryakov.
 631
 632         Don't set window.opener to 0 for the current FrameLoader if a noreferrer link was clicked, only suppress opener in a new frame.
 633         https://bugs.webkit.org/show_bug.cgi?id=30781
 634
 635         * loader/FrameLoader.cpp:
 636         (WebCore::FrameLoader::urlSelected): Don't suppress opener in the current frame for noreferrer navigations.
 637
 638 2009-10-26  Ryosuke Niwa  <rniwa@webkit.org>
 639
 640         Reviewed by Eric Seidel.
 641
 642         Data loss occurs when unbolding nested bold tags.
 643         https://bugs.webkit.org/show_bug.cgi?id=30083
 644
 645         Fixes the loop in swapInNodePreservingAttributesAndChildren by saving nextSibling() of child
 646         to a temporary valuable.  It was originally calling nextSibling() after appending the child
 647         to new parent, in which case, nextSibling is always 0.
 648
 649         Test: editing/style/unbolding-nested-b.html
 650
 651         * editing/ReplaceNodeWithSpanCommand.cpp:
 652         (WebCore::swapInNodePreservingAttributesAndChildren):
 653
 654 2009-10-21  Jeremy Orlow  <jorlow@chromium.org>
 655
 656         Reviewed by Darin Adler.
 657
 658         Storage events should use Document::url() rather than documentURI()
 659         https://bugs.webkit.org/show_bug.cgi?id=30535
 660
 661         Storage events should use Document::url() rather than Document::documentURI()
 662         per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html
 663
 664         Test: storage/domstorage/documentURI.html
 665
 666         * storage/StorageEventDispatcher.cpp:
 667         (WebCore::StorageEventDispatcher::dispatch):
 668
 669 2009-10-26  Sam Weinig  <sam@webkit.org>
 670
 671         Rubber-stamped by Darin Adler.
 672
 673         Rollout r50041-50043.  The HTML5 spec changed to make HTMLOptionsCollection
 674         inherit from HTMLCollection.
 675
 676         * GNUmakefile.am:
 677         * WebCore.gypi:
 678         * WebCore.pro:
 679         * WebCore.vcproj/WebCore.vcproj:
 680         * WebCore.xcodeproj/project.pbxproj:
 681         * bindings/js/JSHTMLAllCollectionCustom.cpp:
 682         (WebCore::getNamedItems):
 683         (WebCore::callHTMLAllCollection):
 684         (WebCore::JSHTMLAllCollection::nameGetter):
 685         (WebCore::JSHTMLAllCollection::item):
 686         (WebCore::JSHTMLAllCollection::namedItem):
 687         * bindings/js/JSHTMLCollectionCustom.cpp:
 688         (WebCore::getNamedItems):
 689         (WebCore::callHTMLCollection):
 690         (WebCore::JSHTMLCollection::nameGetter):
 691         (WebCore::JSHTMLCollection::item):
 692         (WebCore::JSHTMLCollection::namedItem):
 693         (WebCore::toJS):
 694         * bindings/js/JSHTMLCollectionFunctions.h: Removed.
 695         * bindings/js/JSHTMLDocumentCustom.cpp:
 696         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
 697         (WebCore::JSHTMLOptionsCollection::length):
 698         (WebCore::JSHTMLOptionsCollection::indexSetter):
 699         * bindings/objc/DOMHTML.mm:
 700         (kitClass):
 701         * bindings/objc/DOMUtility.mm:
 702         (JSC::createDOMWrapper):
 703         * bindings/scripts/CodeGeneratorJS.pm:
 704         * html/HTMLCollection.idl:
 705         * html/HTMLOptionsCollection.idl:
 706
 707 2009-10-26  Brent Fulgham  <bfulgham@webkit.org>
 708
 709         Reviewed by Adam Roben.
 710
 711         Build fix for ENABLE_FILTERS under Windows.
 712         https://bugs.webkit.org/show_bug.cgi?id=30762
 713
 714         Build correction for ENABLE_FILTERS feature.  No new tests needed.
 715
 716         * WebCore.vcproj/WebCore.vcproj:  Make the following changes:
 717           (1) Create a new 'filters' sub-folder of the platform/graphics
 718               folder to properly show the sources held in this directory.
 719           (2) Move the files that are currently shown in svn/graphics/filters
 720               to platform/graphics/filters (where they actually live on disk).
 721           (3) Add the missing SVGFilter, SVGFilterBuilder, and SVGFETile to
 722               the project so they are built.
 723           (4) Remove SVGFEFloodElement.cpp from the build, since it is already
 724               being compiled by SVGAllInOne.cpp.  Its presence as a separate
 725               entity is causing a linker warning for duplicate symbols.
 726           (5) Add ImageBuffer.cpp to the build to support color space
 727               calculations for non-CG builds.
 728         * WebCore.vcproj/WebCoreCommon.vsprops: Add the platform/graphics/filters
 729           path to the search paths in the project.
 730
 731 2009-10-26  Keishi Hattori  <casey.hattori@gmail.com>
 732
 733         Reviewed by Timothy Hatcher.
 734
 735         console.assert should prefix messages with "Assertion failed: "
 736         https://bugs.webkit.org/show_bug.cgi?id=19135
 737
 738         * English.lproj/localizedStrings.js:
 739         * inspector/front-end/ConsoleView.js:
 740         (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType.
 741         (WebInspector.ConsoleMessage.prototype.toString):
 742         * page/Console.cpp:
 743         (WebCore::Console::assertCondition): Use AssertMessageType.
 744         * page/Console.h:
 745         (WebCore::MessageType): Added AssertMessageType.
 746
 747 2009-10-26  Rahul Kuchhal  <kuchhal@chromium.org>
 748
 749         Reviewed by Eric Seidel.
 750
 751         Prevent crash when optgroup element is empty by adding a NULL check.
 752
 753         https://bugs.webkit.org/show_bug.cgi?id=30365
 754
 755         Test: fast/forms/select-empty-optgroup.html
 756
 757         * dom/SelectElement.cpp:
 758         (WebCore::SelectElement::appendFormData):
 759
 760 2009-10-21  Steven Knight  <sgk@chromium.org>
 761
 762         Reviewed by David Levin.
 763
 764         Refactor gyp for separate webcore_bindings{,_sources} targets.
 765
 766         https://bugs.webkit.org/show_bug.cgi?id=30447
 767
 768         Handle long link lines by building .idl-generated bindings in a
 769         separate webcore_bindings library target.  Avoid Visual Studio
 770         dependency issues by building additional generated .cpp and .h files
 771         in a separate webcore_bindings_sources target.
 772
 773         Chrome should still build and test successfully.
 774
 775         * WebCore.gyp/WebCore.gyp:
 776         * WebCore.gypi:
 777
 778 2009-10-26  Mike Belshe  <mike@belshe.com>
 779
 780         Reviewed by Darin Fisher.
 781
 782         Make the number of connections for chromium controlled by
 783         chromium rather than by ResourceRequestBase.
 784         https://bugs.webkit.org/show_bug.cgi?id=30661
 785
 786         * platform/network/ResourceRequestBase.cpp:
 787         * platform/network/chromium/ResourceRequest.cpp:
 788
 789 2009-10-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 790
 791         Unreviewed. make distcheck build fixes.
 792
 793         * GNUmakefile.am:
 794
 795 2009-10-26  Anton Muhin  <antonm@chromium.org>
 796
 797         Reviewed by Dimitri Glazkov.
 798
 799         Unbreak Chromium build: that requires adding custom implementations
 800         for HTMLOptionsCollection's item and namedItem.  Keep v8 binding
 801         close to JSC bindings as well.
 802         https://bugs.webkit.org/show_bug.cgi?id=30780
 803
 804         * bindings/v8/V8Collection.h:
 805         (WebCore::getNamedItemsFromCollection):
 806         (WebCore::getItemFromCollection):
 807         * bindings/v8/custom/V8CustomBinding.h:
 808         * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
 809         (WebCore::NAMED_PROPERTY_GETTER):
 810         (WebCore::CALLBACK_FUNC_DECL):
 811         * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
 812         (WebCore::NAMED_PROPERTY_GETTER):
 813         (WebCore::CALLBACK_FUNC_DECL):
 814         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
 815         (WebCore::CALLBACK_FUNC_DECL):
 816
 817 2009-10-23  Alexey Proskuryakov  <ap@apple.com>
 818
 819         Reviewed by Adam Barth and Darin Adler.
 820
 821         https://bugs.webkit.org/show_bug.cgi?id=30723
 822         <rdar://problem/6189415> Input names added to multipart/form-data headers need to be escaped.
 823
 824         Test: http/tests/security/escape-form-data-field-names.html
 825
 826         * platform/network/FormDataBuilder.cpp:
 827         (WebCore::appendQuotedString):
 828         (WebCore::FormDataBuilder::beginMultiPartHeader):
 829         (WebCore::FormDataBuilder::addFilenameToMultiPartHeader):
 830         Percent-escape line breaks and quotation marks.
 831
 832 2009-10-26  Kelly Norton  <knorton@google.com>
 833
 834         Reviewed by Pavel Feldman.
 835
 836         Adds DOMTimer support to InspectorTimelineAgent.
 837         https://bugs.webkit.org/show_bug.cgi?id=30467
 838
 839         * inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names.
 840         (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
 841         (WebCore::InspectorTimelineAgent::didLayout):
 842         (WebCore::InspectorTimelineAgent::didRecalculateStyle):
 843         (WebCore::InspectorTimelineAgent::didPaint):
 844         (WebCore::InspectorTimelineAgent::didWriteHTML):
 845         (WebCore::InspectorTimelineAgent::didInstallTimer): Added.
 846         (WebCore::InspectorTimelineAgent::didRemoveTimer): Added.
 847         (WebCore::InspectorTimelineAgent::willFireTimer): Added.
 848         (WebCore::InspectorTimelineAgent::didFireTimer): Added.
 849         (WebCore::InspectorTimelineAgent::addItemToTimeline): Added.
 850         (WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed.
 851         * inspector/InspectorTimelineAgent.h:
 852         (WebCore::):
 853         * inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects.
 854         (WebCore::TimelineItemFactory::createGenericTimerTimelineItem):
 855         (WebCore::TimelineItemFactory::createTimerInstallTimelineItem):
 856         * inspector/TimelineItemFactory.h:
 857         * page/DOMTimer.cpp: Added instrumentation points.
 858         (WebCore::DOMTimer::install):
 859         (WebCore::DOMTimer::removeById):
 860         (WebCore::DOMTimer::fired):
 861
 862 2009-10-26  Simon Fraser  <simon.fraser@apple.com>
 863
 864         Reviewed by Sam Weinig.
 865
 866         <rdar://problem/6988966> Hardware layers do not show up in page snapshots
 867
 868         Add a method that gets called when snapshotting Canvas3DLayers for page snapshots,
 869         that allows the layer to return a CGImageRef of its contents.
 870
 871         * platform/graphics/mac/Canvas3DLayer.h:
 872         * platform/graphics/mac/Canvas3DLayer.mm:
 873         (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]):
 874
 875 2009-10-26  Yury Semikhatsky  <yurys@chromium.org>
 876
 877         Reviewed by Pavel Feldman.
 878
 879         Pass "console" as object group when evaluating selection.
 880
 881         https://bugs.webkit.org/show_bug.cgi?id=30738
 882
 883         * inspector/front-end/SourceFrame.js:
 884         (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
 885
 886 2009-10-26  Keishi Hattori  <casey.hattori@gmail.com>
 887
 888         Reviewed by Pavel Feldman.
 889
 890         Fix for Console not showing repeat count when repeatedly logging an Event
 891         https://bugs.webkit.org/show_bug.cgi?id=30324
 892
 893         * inspector/ConsoleMessage.cpp:
 894         (WebCore::ConsoleMessage::addToConsole):
 895         (WebCore::ConsoleMessage::updateRepeatCountInConsole): Added.
 896         * inspector/ConsoleMessage.h:
 897         * inspector/InspectorController.cpp:
 898         (WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message.
 899         * inspector/InspectorFrontend.cpp:
 900         (WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole
 901         (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented.
 902         * inspector/InspectorFrontend.h:
 903         * inspector/front-end/ConsoleView.js:
 904         (WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual.
 905         (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added.
 906         (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count.
 907         (WebInspector.ConsoleView.prototype.clearMessages):
 908         (WebInspector.ConsoleMessage):
 909         (WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount
 910         (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
 911         * inspector/front-end/inspector.js:
 912         (WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole.
 913         (WebInspector.updateConsoleMessageRepeatCount): Added.
 914
 915 2009-10-26  Chris Fleizach  <cfleizach@apple.com>
 916
 917         Reviewed by Darin Adler.
 918
 919         crash with AX on when an image map contains an anchor tag
 920         https://bugs.webkit.org/show_bug.cgi?id=30739
 921
 922         Tests: accessibility/crashing-a-tag-in-map.html
 923
 924         * accessibility/AccessibilityRenderObject.cpp:
 925         (WebCore::AccessibilityRenderObject::addChildren):
 926
 927 2009-10-26  Steve Block  <steveblock@google.com>
 928
 929         Reviewed by Eric Seidel.
 930
 931         Adds feature ENABLE guards to V8 bindings.
 932         https://bugs.webkit.org/show_bug.cgi?id=30697
 933
 934         This adds guards for the following features to the V8 bindings,
 935         to allow builds with V8 to succeed when these features are not enabled.
 936         - DATABASE
 937         - WORKERS
 938         - SHARED_WORKERS
 939         - SVG
 940         - XPATH
 941         - XSLT
 942         - INSPECTOR
 943
 944         This is a build fix only, no new tests required.
 945
 946         * bindings/v8/DOMObjectsInclude.h: Modified.
 947         * bindings/v8/DerivedSourcesAllInOne.cpp: Modified.
 948         * bindings/v8/V8Index.cpp: Modified.
 949         * bindings/v8/V8Index.h: Modified.
 950
 951 2009-10-26  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
 952
 953         Reviewed by Xan Lopez.
 954
 955         https://bugs.webkit.org/show_bug.cgi?id=25679
 956         [Gtk] Improve accessibility of focusable lists
 957
 958         Fixes the issues with the Atk states exposed for ListBoxOption
 959
 960         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
 961         (setAtkStateSetFromCoreObject):
 962
 963 2009-10-26  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
 964
 965         Reviewed by Xan Lopez.
 966
 967         https://bugs.webkit.org/show_bug.cgi?id=27085
 968         [Gtk] Incorrect rendering of list
 969
 970         Adds a way for platforms to indicate that a particular object
 971         should not be ignored.
 972
 973         * accessibility/AccessibilityObject.h:
 974         * accessibility/chromium/AccessibilityObjectChromium.cpp:
 975         * accessibility/gtk/AccessibilityObjectAtk.cpp:
 976         * accessibility/mac/AccessibilityObjectMac.mm:
 977         * accessibility/qt/AccessibilityObjectQt.cpp:
 978         * accessibility/win/AccessibilityObjectWin.cpp:
 979         * accessibility/wx/AccessibilityObjectWx.cpp:
 980         (AccessibilityObject::accessibilityPlatformIncludesObject):
 981         * accessibility/AccessibilityRenderObject.cpp:
 982         (AccessibilityRenderObject::accessibilityIsIgnored):
 983
 984 2009-10-26  Kinuko Yasuda  <kinuko@google.com>
 985
 986         Reviewed by Jan Alonzo.
 987
 988         Bug 30619: [Linux] Menu key doesn't work
 989         https://bugs.webkit.org/show_bug.cgi?id=30619
 990
 991         Test: manual-tests/keyboard-menukey-event.html
 992         No new layout tests: testing this will require changes in the test
 993         controller in a platform-specific way.
 994
 995         * platform/chromium/KeyCodeConversionGtk.cpp:
 996         (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
 997         GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
 998         * platform/gtk/KeyEventGtk.cpp:
 999         (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
1000         GDK_Menu to return V_APPS instead of VK_MENU.
1001
1002 2009-10-25  Anton Muhin  <antonm@chromium.org>
1003
1004         Reviewed by Adam Barth.
1005
1006         Reuse already fetched proxy.
1007         https://bugs.webkit.org/show_bug.cgi?id=30747
1008
1009         * bindings/v8/V8DOMWrapper.cpp:
1010         (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
1011
1012 2009-10-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1013
1014         Unreviewed build fix.
1015
1016         Build fix for WIN_OS if Netscape plugin support is turned off
1017         https://bugs.webkit.org/show_bug.cgi?id=30753
1018
1019         * plugins/PluginDatabase.cpp:
1020
1021 2009-10-25  Hironori Bono  <hbono@chromium.org>
1022
1023         Reviewed by Darin Adler.
1024
1025         A quick fix for Bug 29103.
1026         Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
1027         and the option string before calling String::startsWith().
1028         https://bugs.webkit.org/show_bug.cgi?id=29103
1029
1030         Tests: fast/forms/listbox-typeahead-cyrillic.html
1031                fast/forms/listbox-typeahead-greek.html
1032
1033         * dom/SelectElement.cpp:
1034         (WebCore::SelectElement::typeAheadFind):
1035
1036 2009-10-25  Keishi Hattori  <casey.hattori@gmail.com>
1037
1038         Reviewed by Timothy Hatcher.
1039
1040         Web Inspector: Expanding a node in the Console should not show the element in Elements panel
1041         https://bugs.webkit.org/show_bug.cgi?id=30749
1042
1043         * inspector/front-end/ElementsTreeOutline.js:
1044         (WebInspector.ElementsTreeElement.prototype.onmousedown): Check if inside disclosure triangle.
1045
1046 2009-10-25  Sam Weinig  <sam@webkit.org>
1047
1048         Reviewed by Dan Bernstein.
1049
1050         Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
1051         HTMLOptionsCollection should not inherit from HTMLCollection
1052
1053         * GNUmakefile.am:
1054         * WebCore.gypi:
1055         * WebCore.pro:
1056         * WebCore.vcproj/WebCore.vcproj:
1057         * WebCore.xcodeproj/project.pbxproj:
1058         Added JSHTMLCollectionFunctions.h
1059
1060         * bindings/js/JSHTMLAllCollectionCustom.cpp:
1061         (WebCore::callHTMLAllCollection):
1062         (WebCore::JSHTMLAllCollection::nameGetter):
1063         (WebCore::JSHTMLAllCollection::item):
1064         (WebCore::JSHTMLAllCollection::namedItem):
1065         * bindings/js/JSHTMLCollectionCustom.cpp:
1066         (WebCore::callHTMLCollection):
1067         (WebCore::JSHTMLCollection::nameGetter):
1068         (WebCore::JSHTMLCollection::item):
1069         (WebCore::JSHTMLCollection::namedItem):
1070         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
1071         (WebCore::callHTMLCollection):
1072         (WebCore::JSHTMLOptionsCollection::getCallData):
1073         (WebCore::JSHTMLOptionsCollection::canGetItemsForName):
1074         (WebCore::JSHTMLOptionsCollection::nameGetter):
1075         (WebCore::JSHTMLOptionsCollection::indexSetter):
1076         (WebCore::JSHTMLOptionsCollection::item):
1077         (WebCore::JSHTMLOptionsCollection::namedItem):
1078         Refactor to use generic implementation of HTMLCollection bindings functions
1079         from JSHTMLCollectionFunctions.h
1080
1081         * bindings/js/JSHTMLCollectionFunctions.h: Added.
1082         (WebCore::getCollectionNamedItems):
1083         (WebCore::getCollectionItems):
1084         (WebCore::callHTMLCollectionGeneric):
1085         Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
1086         JSHTMLOptionsCollection can all use.
1087
1088         * bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h
1089         for toJS on document.all.
1090
1091         * bindings/objc/DOMHTML.mm:
1092         * bindings/objc/DOMUtility.mm:
1093         (JSC::createDOMWrapper):
1094         Remove special cases for HTMLOptionsCollection.
1095
1096         * bindings/scripts/CodeGeneratorJS.pm:
1097         * html/HTMLAllCollection.idl:
1098         * html/HTMLCollection.idl:
1099         * html/HTMLOptionsCollection.idl:
1100
1101 2009-10-24  Keishi Hattori  <casey.hattori@gmail.com>
1102
1103         Reviewed by Timothy Hatcher.
1104
1105         WebInspector: Fixed issue with IME inside console
1106         https://bugs.webkit.org/show_bug.cgi?id=30660
1107
1108         * inspector/front-end/ConsoleView.js:
1109         (WebInspector.ConsoleView.prototype._promptKeyDown):
1110         * inspector/front-end/DatabaseQueryView.js:
1111         (WebInspector.DatabaseQueryView.prototype._promptKeyDown):
1112         * inspector/front-end/inspector.js:
1113         (WebInspector.loaded):
1114         (WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp.
1115         (WebInspector.startEditing.element.handleKeyEvent):
1116         (WebInspector.startEditing):
1117         * inspector/front-end/utilities.js:
1118         (isEnterKey): Added. Check if in IME.
1119
1120 2009-10-24  Brian Weinstein  <bweinstein@apple.com>
1121
1122         Reviewed by Timothy Hatcher.
1123
1124         Fixes <https://bugs.webkit.org/show_bug.cgi?id=30752>.
1125         Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX.
1126
1127         Have the scope bars select one scope by default, but if the multiple selection key
1128         is pressed, allow for multiple selection.
1129
1130         * inspector/front-end/ConsoleView.js:
1131         (WebInspector.ConsoleView):
1132         (WebInspector.ConsoleView.prototype._updateFilter):
1133         (WebInspector.ConsoleView.prototype.filter):
1134         * inspector/front-end/ResourcesPanel.js:
1135         (WebInspector.ResourcesPanel):
1136         (WebInspector.ResourcesPanel.prototype.filter):
1137         (WebInspector.ResourcesPanel.prototype._updateFilter):
1138
1139 2009-10-24  Timothy Hatcher  <timothy@apple.com>
1140
1141         Make the scope bars in the Web Inspector match other scope bars in Mac OS X.
1142         Also cleans up the CSS to use classes instead of ID selectors.
1143
1144         https://bugs.webkit.org/show_bug.cgi?id=28186
1145
1146         Reviewed by Dan Bernstein.
1147
1148         * inspector/front-end/ResourcesPanel.js: Add the scope-bar class.
1149         * inspector/front-end/inspector.css: Lots of changes to make it look right.
1150         * inspector/front-end/inspector.html: Add the scope-bar class.
1151
1152 2009-10-24  Timothy Hatcher  <timothy@apple.com>
1153
1154         Fix selecting Resources in the Web Inspector's Resources panel.
1155
1156         https://bugs.webkit.org/show_bug.cgi?id=30743
1157
1158         Reviewed by Pavel Feldman.
1159
1160         * inspector/front-end/ResourcesPanel.js:
1161         (WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added.
1162         (WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call
1163         isCategoryVisible on the ResourcesPanel.
1164
1165 2009-10-24  Timothy Hatcher  <timothy@apple.com>
1166
1167         Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting
1168         All will deselect the other filters.
1169
1170         https://bugs.webkit.org/show_bug.cgi?id=30744
1171
1172         Reviewed by Pavel Feldman.
1173
1174         * inspector/front-end/ResourcesPanel.js:
1175         (WebInspector.ResourcesPanel.createFilterElement): Better syntax.
1176         (WebInspector.ResourcesPanel):
1177         (WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop,
1178         and the child variable instead of target in the loop. Other clean up.
1179
1180 2009-10-24  Timothy Hatcher  <timothy@apple.com>
1181
1182         Make resizing the Web Inspector's Elements panel sidebar work again.
1183         Also makes Resources panel use the sidebar code in Panel.
1184
1185         https://bugs.webkit.org/show_bug.cgi?id=30742
1186
1187         Reviewed by Pavel Feldman.
1188
1189         * inspector/front-end/Panel.js:
1190         (WebInspector.Panel): Don't create the sidebar with an argument.
1191         (WebInspector.Panel.prototype.show): Call updateSidebarWidth.
1192         (WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent.
1193         (WebInspector.Panel.prototype.handleSidebarKeyEvent): Added.
1194         (WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar.
1195         (WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth.
1196         (WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth.
1197         (WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth.
1198         (WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
1199         * inspector/front-end/ProfilesPanel.js:
1200         (WebInspector.ProfilesPanel): Call createSidebar.
1201         (WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
1202         * inspector/front-end/ResourcesPanel.js:
1203         (WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth.
1204         (WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth
1205         (WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto.
1206         (WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added.
1207         (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added.
1208         * inspector/front-end/StoragePanel.js:
1209         (WebInspector.StoragePanel): Call createSidebar.
1210         (WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
1211         * inspector/front-end/TimelinePanel.js:
1212         (WebInspector.TimelinePanel): Call createSidebar.
1213         (WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
1214
1215 2009-10-24  Timothy Hatcher  <timothy@apple.com>
1216
1217         Call updateSelection() in a few places so hovering in the Web Inspector's
1218         Elements panel always has the correct row selection height.
1219
1220         https://bugs.webkit.org/show_bug.cgi?id=30735
1221
1222         Reviewed by Pavel Feldman.
1223
1224         * inspector/front-end/ElementsTreeOutline.js:
1225         (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
1226         (WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.
1227         * inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.
1228
1229 2009-10-24  Timothy Hatcher  <timothy@apple.com>
1230
1231         Remove the re-root tree feature from the Web Inspector's
1232         Elements panel. This feature wasn't super useful and gets
1233         in the way of double-click to edit.
1234
1235         https://bugs.webkit.org/show_bug.cgi?id=30736
1236
1237         Reviewed by Pavel Feldman.
1238
1239         * inspector/front-end/ElementsTreeOutline.js:
1240         (WebInspector.ElementsTreeElement.prototype.ondblclick):
1241
1242 2009-10-24  Anton Muhin  <antonm@chromium.org>
1243
1244         Reviewed by Adam Barth.
1245
1246         Implements ReturnsNew hint for V8 bindings generation code.
1247         https://bugs.webkit.org/show_bug.cgi?id=30745
1248
1249         * bindings/scripts/CodeGeneratorV8.pm:
1250         * bindings/v8/V8DOMWrapper.h:
1251         (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
1252
1253 2009-10-24  Dan Bernstein  <mitz@apple.com>
1254
1255         Reviewed by Sam Weinig.
1256
1257         Missing images at 350.org due to wrong URLs
1258         https://bugs.webkit.org/show_bug.cgi?id=30748
1259
1260         Test: fast/dom/HTMLImageElement/parse-src.html
1261
1262         * dom/Element.cpp:
1263         (WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL().
1264         This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI()
1265         and SVGImageLoader::sourceURI() do.
1266
1267 2009-10-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1268
1269         Unreviewed.
1270
1271         [Qt] Build fix for QtWebKit after r50013.
1272
1273         * WebCore.pro:
1274
1275 2009-10-24  Dimitri Glazkov  <dglazkov@chromium.org>
1276
1277         Unreviewed, build fix.
1278
1279         [V8] Fix up to accommodate for HTMLAllCollection changes in
1280         http://trac.webkit.org/changeset/49998.
1281
1282         * WebCore.gypi:
1283         * bindings/scripts/CodeGeneratorV8.pm:
1284         * bindings/v8/custom/V8CustomBinding.h:
1285         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
1286
1287 2009-10-23  Dan Bernstein  <mitz@apple.com>
1288
1289         Reviewed by Alexey Proskuryakov.
1290
1291         <rdar://problem/7294131> Assertion failure in AuthenticationMac at
1292         mac(const Credential&) after authenticating to MobileMe Gallery movie
1293
1294         * platform/network/Credential.cpp:
1295         (WebCore::Credential::Credential): Initialize m_persistence.
1296         (WebCore::Credential::isEmpty): Made this method const.
1297         * platform/network/Credential.h:
1298         * platform/network/mac/AuthenticationMac.mm:
1299         (WebCore::mac): Return nil if the Credential is empty.
1300
1301 2009-10-23  Brian Weinstein  <bweinstein@apple.com>
1302
1303         Reviewed by Timothy Hatcher.
1304
1305         Fixes <https://bugs.webkit.org/show_bug.cgi?id=30617>.
1306         Web Inspector: Resources Scope Bar Should Allow Combinations.
1307
1308         Refactor the filtering in ResourcePanel to make it match ConsoleView,
1309         and add a divider between All, and the other choices of Resource types.
1310
1311         * inspector/front-end/ResourcesPanel.js:
1312         (WebInspector.ResourcesPanel):
1313         (WebInspector.ResourcesPanel.prototype.filter):
1314         (WebInspector.ResourcesPanel.prototype._updateFilter):
1315         * inspector/front-end/inspector.css:
1316
1317 2009-10-23  Chris Evans  <cevans@chromium.org>
1318
1319         Reviewed by Adam Barth.
1320
1321         Ignore the Refresh header if we're in view source mode.
1322
1323         https://bugs.webkit.org/show_bug.cgi?id=27239
1324
1325         Test: http/tests/security/view-source-no-refresh.html
1326
1327         * loader/FrameLoader.cpp: ignore Refresh in view-source mode.
1328
1329 2009-10-23  Alexey Proskuryakov  <ap@apple.com>
1330
1331         Reviewed by Sam Weinig.
1332
1333         https://bugs.webkit.org/show_bug.cgi?id=30734
1334         Remove XMLTokenizer::m_currentNodeIsReferenced
1335
1336         No change in behavior, no tests.
1337
1338         * dom/XMLTokenizer.cpp:
1339         (WebCore::XMLTokenizer::setCurrentNode):
1340         * dom/XMLTokenizer.h:
1341         Don't store a boolean for the current node being the document - we can always check for that.
1342
1343         * dom/XMLTokenizerLibxml2.cpp:
1344         (WebCore::XMLTokenizer::XMLTokenizer):
1345         * dom/XMLTokenizerQt.cpp:
1346         (WebCore::XMLTokenizer::XMLTokenizer):
1347         A fragment passed to XMLTokenizer is never null - in fact, the first thing we do is dereference
1348         it unconditionally, and then begin checking it for null, as if it could help.
1349
1350 2009-10-23  Beth Dakin  <bdakin@apple.com>
1351
1352         No review since this is a build fix.
1353
1354         Build fix for the Mac. (Build is only broken when SVG filters are
1355         enabled.)
1356
1357         Labelled these function static.
1358         * platform/graphics/filters/FEComponentTransfer.cpp:
1359         (WebCore::identity):
1360         (WebCore::table):
1361         (WebCore::discrete):
1362         (WebCore::linear):
1363         (WebCore::gamma):
1364         * platform/graphics/filters/FEGaussianBlur.cpp:
1365         (WebCore::boxBlur):
1366
1367 2009-10-23  Pavel Feldman  <pfeldman@chromium.org>
1368
1369         Reviewed by Timothy Hatcher.
1370
1371         Web Inspector: Implement a Timeline panel.
1372
1373         https://bugs.webkit.org/show_bug.cgi?id=30725
1374
1375         * WebCore.gypi:
1376         * WebCore.vcproj/WebCore.vcproj:
1377         * inspector/front-end/Images/timelineIcon.png: Added.
1378         * inspector/front-end/TimelineAgent.js:
1379         (WebInspector.addItemToTimeline):
1380         (WebInspector.timelineProfilerWasStarted):
1381         (WebInspector.timelineProfilerWasStopped):
1382         * inspector/front-end/TimelinePanel.js: Added.
1383         (WebInspector.TimelinePanel):
1384         (WebInspector.TimelinePanel.prototype.toolbarItemClass.get toolbarItemLabel):
1385         (WebInspector.TimelinePanel.prototype.get statusBarItems):
1386         (WebInspector.TimelinePanel.prototype.handleKeyEvent):
1387         (WebInspector.TimelinePanel.prototype.timelineWasStarted):
1388         (WebInspector.TimelinePanel.prototype.timelineWasStopped):
1389         (WebInspector.TimelinePanel.prototype.addItemToTimeline):
1390         (WebInspector.TimelinePanel.prototype._innerAddItemToTimeline):
1391         (WebInspector.TimelinePanel.prototype._toggleTimelineButton):
1392         (WebInspector.TimelinePanel.prototype.setMainViewWidth):
1393         (WebInspector.TimelinePanel.prototype.getItemTypeName):
1394         (WebInspector.TimelineRecordTreeElement):
1395         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
1396         * inspector/front-end/WebKit.qrc:
1397         * inspector/front-end/inspector.css:
1398         * inspector/front-end/inspector.html:
1399         * inspector/front-end/inspector.js:
1400         (WebInspector._createPanels):
1401
1402 2009-10-23  Joseph Pecoraro  <joepeck@webkit.org>
1403
1404         Reviewed by Timothy Hatcher.
1405
1406         Web Inspector: Clash Between Search's onkeyup and incremental search events
1407         https://bugs.webkit.org/show_bug.cgi?id=30731
1408
1409         * inspector/front-end/inspector.js:
1410         (WebInspector.performSearch): prevent incremental search event from clobbering a forced search
1411
1412 2009-10-23  Kelly Norton  <knorton@google.com>
1413
1414         Reviewed by Pavel Feldman.
1415
1416         Removes the need for C++ Timeline types in InspectorTimelineAgent in favor
1417         of ScriptObjects.
1418         https://bugs.webkit.org/show_bug.cgi?id=30707
1419
1420         * GNUmakefile.am:
1421         * WebCore.vcproj/WebCore.vcproj:
1422         * WebCore.xcodeproj/project.pbxproj:
1423         * inspector/DOMDispatchTimelineItem.cpp: Removed.
1424         * inspector/DOMDispatchTimelineItem.h: Removed.
1425         * inspector/InspectorTimelineAgent.cpp:
1426         (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
1427         (WebCore::InspectorTimelineAgent::willDispatchDOMEvent):
1428         (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
1429         (WebCore::InspectorTimelineAgent::willLayout):
1430         (WebCore::InspectorTimelineAgent::didLayout):
1431         (WebCore::InspectorTimelineAgent::willRecalculateStyle):
1432         (WebCore::InspectorTimelineAgent::didRecalculateStyle):
1433         (WebCore::InspectorTimelineAgent::willPaint):
1434         (WebCore::InspectorTimelineAgent::didPaint):
1435         (WebCore::InspectorTimelineAgent::willWriteHTML):
1436         (WebCore::InspectorTimelineAgent::didWriteHTML):
1437         (WebCore::InspectorTimelineAgent::reset):
1438         (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
1439         (WebCore::InspectorTimelineAgent::pushCurrentTimelineItem):
1440         * inspector/InspectorTimelineAgent.h:
1441         (WebCore::InspectorTimelineAgent::TimelineItemEntry::TimelineItemEntry):
1442         * inspector/TimelineItem.cpp: Removed.
1443         * inspector/TimelineItem.h: Removed.
1444         * inspector/TimelineItemFactory.cpp: Added.
1445         (WebCore::TimelineItemFactory::createGenericTimelineItem):
1446         (WebCore::TimelineItemFactory::createDOMDispatchTimelineItem):
1447         * inspector/TimelineItemFactory.h: Added.
1448         (WebCore::):
1449         (WebCore::TimelineItemFactory::TimelineItemFactory):
1450
1451 2009-10-23  Gavin Barraclough  <barraclough@apple.com>
1452
1453         Reviewed by Geoff Garen.
1454
1455         https://bugs.webkit.org/show_bug.cgi?id=30729
1456         Provide private API to request the global context for a specific world.
1457         Used to initialize parameters on the global object.
1458
1459         * bindings/js/ScriptController.cpp:
1460         (WebCore::ScriptController::globalObject):
1461         * bindings/js/ScriptController.h:
1462
1463 2009-10-23  Steve Block  <steveblock@google.com>
1464
1465         Reviewed by Eric Seidel.
1466
1467         Fixes style problems in Android-specific files.
1468         https://bugs.webkit.org/show_bug.cgi?id=30717
1469
1470         Style changes only, no new tests possible.
1471
1472         * page/android/EventHandlerAndroid.cpp: Modified.
1473         (WebCore::EventHandler::passMouseDownEventToWidget): Fixes whitespace in method signature.
1474         (WebCore::EventHandler::passSubframeEventToSubframe): Fixes whitespace in method signature.
1475         (WebCore::EventHandler::passWheelEventToWidget): Fixes whitespace in method signature.
1476         (WebCore::EventHandler::passMouseMoveEventToSubframe): Fixes whitespace in method signature.
1477         * platform/android/ClipboardAndroid.h: Modified. Fixes header include order and indenting.
1478         * platform/android/CursorAndroid.cpp: Modified.
1479         (WebCore::grabCursor): Fixes function braces.
1480         (WebCore::grabbingCursor): Fixes function braces.
1481         * platform/android/FileChooserAndroid.cpp: Modified.
1482         (WebCore::FileChooser::basenameForWidth): Fixes braces on while statement, and updates String::copy to String::threadsafeCopy.
1483         * platform/android/FileSystemAndroid.cpp: Modified. Fixes header include order.
1484         (WebCore::unloadModule): Fixes zero test.
1485         (WebCore::writeToFile): Fixes if statement structure.
1486         * platform/android/KeyEventAndroid.cpp: Modified.
1487         (WebCore::windowsKeyCodeForKeyEvent): Fixes switch statement indenting.
1488         (WebCore::keyIdentifierForAndroidKeyCode): Fixes switch statement indenting.
1489         * platform/android/ScreenAndroid.cpp: Modified. Fixes header include order and switch statement indenting.
1490         * platform/android/TemporaryLinkStubs.cpp: Modified. Fixes header include order.
1491
1492 2009-10-23  Sam Weinig  <sam@webkit.org>
1493
1494         Another shot at a fixed build.
1495
1496         * DerivedSources.cpp:
1497
1498 2009-10-23  Sam Weinig  <sam@webkit.org>
1499
1500         Another shot at a fixed build.
1501
1502         * html/HTMLOptionsCollection.idl:
1503
1504 2009-10-23  Brady Eidson  <beidson@apple.com>
1505
1506         50,000!
1507
1508         * ChangeLog: Point out revision 50,000.
1509
1510 2009-10-23  Sam Weinig  <sam@webkit.org>
1511
1512         Reviewed by Anders Carlsson.
1513
1514         Fix for https://bugs.webkit.org/show_bug.cgi?id=30695
1515         Drop .tags() support from HTMLCollection
1516
1517         - Make .tags() only work for HTMLAllCollections in JS. .tags() is still
1518           available for all HTMLCollection like objects in Objective-C since that
1519           is API.
1520         - Auto-generate HTMLAllCollection.
1521
1522         Test: fast/dom/HTMLDocument/document-all.html
1523
1524         * DerivedSources.make:
1525         * GNUmakefile.am:
1526         * WebCore.gypi:
1527         * WebCore.pro:
1528         * WebCore.vcproj/WebCore.vcproj:
1529         * WebCore.xcodeproj/project.pbxproj:
1530         * bindings/js/JSHTMLAllCollection.cpp: Removed.
1531         * bindings/js/JSHTMLAllCollection.h: Removed.
1532         * bindings/js/JSHTMLAllCollectionCustom.cpp: Added.
1533         (WebCore::getNamedItems):
1534         (WebCore::callHTMLAllCollection):
1535         (WebCore::JSHTMLAllCollection::getCallData):
1536         (WebCore::JSHTMLAllCollection::canGetItemsForName):
1537         (WebCore::JSHTMLAllCollection::nameGetter):
1538         (WebCore::JSHTMLAllCollection::item):
1539         (WebCore::JSHTMLAllCollection::namedItem):
1540         * bindings/js/JSHTMLCollectionCustom.cpp:
1541         (WebCore::toJS):
1542         * bindings/js/JSHTMLDocumentCustom.cpp:
1543         * bindings/scripts/CodeGeneratorJS.pm:
1544         * dom/Document.cpp:
1545         (WebCore::Document::all):
1546         * dom/Document.h:
1547         * dom/HTMLAllCollection.idl: Removed.
1548         * html/HTMLAllCollection.cpp: Added.
1549         (WebCore::HTMLAllCollection::create):
1550         (WebCore::HTMLAllCollection::HTMLAllCollection):
1551         (WebCore::HTMLAllCollection::~HTMLAllCollection):
1552         * html/HTMLAllCollection.h: Added.
1553         * html/HTMLAllCollection.idl: Added.
1554         * html/HTMLCollection.h:
1555         * html/HTMLCollection.idl:
1556         * html/HTMLDocument.idl:
1557         * page/DOMWindow.idl:
1558
1559 2009-10-23  Pavel Feldman  <pfeldman@chromium.org>
1560
1561         Reviewed by Timothy Hatcher.
1562
1563         Web Inspector: pull basic sidebar implementation into the Panel.
1564
1565         https://bugs.webkit.org/show_bug.cgi?id=30720
1566
1567         * inspector/front-end/Panel.js:
1568         (WebInspector.Panel):
1569         (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
1570         (WebInspector.Panel.prototype.handleKeyEvent):
1571         (WebInspector.Panel.prototype._createSidebar):
1572         (WebInspector.Panel.prototype._startSidebarDragging):
1573         (WebInspector.Panel.prototype._sidebarDragging):
1574         (WebInspector.Panel.prototype._endSidebarDragging):
1575         (WebInspector.Panel.prototype._updateSidebarWidth):
1576         (WebInspector.Panel.prototype.setCenterViewWidth):
1577         * inspector/front-end/ProfilesPanel.js:
1578         (WebInspector.ProfilesPanel):
1579         (WebInspector.ProfilesPanel.prototype.setCenterViewWidth):
1580         * inspector/front-end/StoragePanel.js:
1581         (WebInspector.StoragePanel):
1582         (WebInspector.StoragePanel.prototype.setCenterViewWidth):
1583
1584 2009-10-23  Jens Alfke  <snej@chromium.org>
1585
1586         Reviewed by Dimitri Glazkov.
1587
1588         Slight optimizations to object returning and exception handling in generated V8 bindings.
1589         https://bugs.webkit.org/show_bug.cgi?id=30599
1590
1591         * bindings/scripts/CodeGeneratorV8.pm: Generate better code
1592         * bindings/v8/V8DOMWrapper.h:
1593         (WebCore::V8DOMWrapper::convertToV8Object): Added overload that takes a Ref<>
1594         * bindings/v8/custom/V8InspectorBackendCustom.cpp:
1595         (WebCore::CALLBACK_FUNC_DECL): Remove unnecessary template param to prevent compile error
1596
1597 2009-10-23  Alpha Lam  <hclam@chromium.org>
1598
1599         Reviewed by Eric Carlson.
1600
1601         Volume slider always starts at half volume
1602         https://bugs.webkit.org/show_bug.cgi?id=28322
1603
1604         Sets the value attribute of volume slider to the volume attribute
1605         of the media element. Also update the value attribute of the
1606         input element for the volume slider when the volume attribute
1607         of the media element is updated.
1608
1609         Test: media/video-volume-slider.html
1610
1611         * rendering/MediaControlElements.cpp:
1612         (WebCore::MediaControlVolumeSliderElement::update):
1613         Set the value attribute of the input element for the volume slider
1614         using the current volume of the media element.
1615         * rendering/MediaControlElements.h:
1616         Add method definition of update().
1617         * rendering/RenderMedia.cpp:
1618         (WebCore::RenderMedia::createVolumeSlider):
1619         Creates a volume slider with value attribute equals to the current
1620         volume attribute of the media element.
1621
1622 2009-10-23  Evan Martin  <evan@chromium.org>
1623
1624         Reviewed by Eric Seidel.
1625
1626         Chrome Linux: fix caret positioning in LTR complex languages
1627         The caret is positioned off by one in languages like Thai.
1628
1629         https://bugs.webkit.org/show_bug.cgi?id=28284
1630
1631         A group of us spent a while trying various approaches to write a test
1632         for this; however, since it is only that the blinking cursor is
1633         displayed incorrectly, we concluded it can not be tested.
1634
1635         (Patch by Hironori Bono.)
1636
1637         * platform/graphics/chromium/FontLinux.cpp:
1638         (WebCore::Font::selectionRectForComplexText):
1639
1640 2009-10-23  Tony Chang  <tony@chromium.org>
1641
1642         Reviewed by David Levin.
1643
1644         Fix Chromium build after IsoldatedWorld change (r49963).
1645         https://bugs.webkit.org/show_bug.cgi?id=30719
1646
1647         * bindings/ScriptControllerBase.cpp:
1648         * bindings/js/ScriptController.cpp:
1649         (WebCore::ScriptController::executeScriptInIsolatedWorld):
1650         * bindings/v8/ScriptController.cpp:
1651         (WebCore::mainThreadNormalWorld):
1652         * bindings/v8/ScriptController.h:
1653         (WebCore::ScriptController::windowShell):
1654         (WebCore::ScriptController::existingWindowShell):
1655         * dom/Document.cpp:
1656         (WebCore::Document::createWrapperCache):
1657         * dom/ScriptExecutionContext.cpp:
1658         * dom/ScriptExecutionContext.h:
1659         * xml/XMLHttpRequest.cpp:
1660         * xml/XMLHttpRequest.h:
1661
1662 2009-10-23  Xiaomei Ji  <xji@chromium.org>
1663
1664         Reviewed by Sam Weinig.
1665
1666         Fix caretRangeFromPoint()/elementFromPoint() returns wrong result
1667         for a zoomed and scrolled page.
1668         https://bugs.webkit.org/show_bug.cgi?id=30689.
1669
1670         The real cause is the wrong calculation of event.clientX/Y when
1671         page is zoomed and scolled.
1672         After Sam fixed the event.clientX/Y in r49551, the hit test point
1673         should be recalculated (revert r49490).
1674
1675         Test: fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html
1676
1677         * dom/Document.cpp:
1678         (WebCore::Document::elementFromPoint): calculate the correct point
1679         relative to document when page is zoomed and scrolled.
1680         (WebCore::Document::caretRangeFromPoint): calculate the correct point
1681         relative to document when page is zoomed and scrolled.
1682
1683 2009-10-22  Dumitru Daniliuc  <dumi@chromium.org>
1684
1685         Reviewed by Dmitry Titov.
1686
1687         Adding a class that allows us to enable/disable features at
1688         runtime. Adding a flag to enable database support.
1689
1690         https://bugs.webkit.org/show_bug.cgi?id=30653
1691
1692         * WebCore.gypi:
1693         * bindings/v8/RuntimeEnabledFeatures.cpp: Added.
1694         * bindings/v8/RuntimeEnabledFeatures.h: Added.
1695         (WebCore::RuntimeEnabledFeatures::setDatabaseEnabled):
1696         (WebCore::RuntimeEnabledFeatures::databaseEnabled):
1697         (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
1698         * bindings/v8/custom/V8CustomBinding.h:
1699         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1700         (WebCore::ACCESSOR_RUNTIME_ENABLER):
1701         * page/DOMWindow.idl:
1702
1703 2009-10-23  Keishi Hattori  <casey.hattori@gmail.com>
1704
1705         Reviewed by Timothy Hatcher.
1706
1707         Inspector injects _inspectorCommandLineAPI into global object when opened
1708         https://bugs.webkit.org/show_bug.cgi?id=30675
1709
1710         * inspector/front-end/InjectedScript.js:
1711         (InjectedScript.getCompletions):
1712         (InjectedScript._evaluateOn):
1713         (InjectedScript.addInspectedNode):
1714         (InjectedScript._ensureCommandLineAPIInstalled): Moved _inspectorCommandLineAPI from window to console.
1715
1716 2009-10-23  Janne Koskinen  <janne.p.koskinen@digia.com>
1717
1718         Reviewed by Tor Arne Vestbø.
1719
1720         [Qt] don't undef NULL in Symbian emulator
1721
1722         npapi.h way of defining mwerks compiler,__intel__
1723         and win32 are all true for Symbian emulator.
1724         Changed the definions so that NULL won't be undefined
1725         when compiling for Symbian emulator nor target HW.
1726
1727         * bridge/npapi.h:
1728
1729 2009-10-23  Janne Koskinen  <janne.p.koskinen@digia.com>
1730
1731         Reviewed by Tor Arne Vestbø.
1732
1733         [Qt] Correct linking of sqlite3 for Symbian
1734         https://bugs.webkit.org/show_bug.cgi?id=30569
1735
1736         ".lib" will try to include library as static library
1737         causing the library to be searched from wrong directory and if found
1738         will be statically linked instead of the inteded dynamic linking.
1739
1740         * WebCore.pro:
1741
1742 2009-10-23  Enrica Casucci  <enrica@apple.com>
1743
1744         Reviewed by Adele Peterson.
1745
1746         REGRESSION: Copy is copying incorrect background-color
1747         <rdar://problem/7248529>
1748         https://bugs.webkit.org/show_bug.cgi?id=29697
1749
1750         Test: editing/execCommand/indent-paragraphs.html
1751
1752         This change removes the BackgroundColor from the list
1753         of inheritable CSS properties and changes significantly
1754         the way we perform indentation.
1755         The new implementation of IndentOutdentCommand uses a new method
1756         defined in CompositeEditCommand called moveParagraphWithClones.
1757         This is an improved version of the original moveParagraph that
1758         is aimed at preserving the original markup of the paragraph being
1759         moved.
1760
1761         * editing/ApplyStyleCommand.cpp:
1762         (WebCore::): removed CSSPropertyBackgroundColor from editingStyleProperties.
1763         * editing/CompositeEditCommand.cpp:
1764         (WebCore::CompositeEditCommand::CompositeEditCommand): Removed trailing blanks.
1765         (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Removed trailing blanks.
1766         (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added.
1767         (WebCore::CompositeEditCommand::cleanupAfterDeletion): Added.
1768         (WebCore::CompositeEditCommand::moveParagraphWithClones): Added.
1769         (WebCore::CompositeEditCommand::moveParagraphs): Modified to use cleanupAfterDeletion.
1770         (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Removed trailing blanks.
1771         (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Removed trailing blanks.
1772         (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): Removed trailing blanks.
1773         * editing/CompositeEditCommand.h: Added three new methods.
1774         * editing/IndentOutdentCommand.cpp:
1775         (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Changed to use moveParagraphWithClones.
1776         (WebCore::IndentOutdentCommand::indentIntoBlockquote): Changed to use moveParagraphWithClones.
1777         (WebCore::IndentOutdentCommand::indentRegion): Removed comment.
1778         * editing/IndentOutdentCommand.h: Removed prepareBlockquoteLevelForInsertion method.
1779
1780 2009-10-23  Steve Block  <steveblock@google.com>
1781
1782         Reviewed by Eric Seidel.
1783
1784         Adds missing UnusedParam.h includes, required when INSPECTOR is not enabled.
1785         https://bugs.webkit.org/show_bug.cgi?id=30677
1786
1787         Build fix, no new tests required.
1788
1789         * page/Console.cpp: Modified. Added UnusedParam.h include.
1790         * workers/WorkerContext.cpp: Modified. Added UnusedParam.h include.
1791
1792 2009-10-23  Girish Ramakrishnan  <girish@forwardbias.in>
1793
1794         Reviewed by Holger Freyther.
1795
1796         [Qt] Plugins : Use window's winId() instead of the widget's.
1797
1798         As per, https://developer.mozilla.org/en/NPN_GetValue
1799         NPNVnetscapeWindow on Unix/X11: "Gets the browser toplevel window in which the
1800         plug-in is displayed; returns Window".
1801
1802         The issue was found because NPNVNetscapeWindow winId() ends up creating
1803         a native window resulting in flicker.
1804
1805         https://bugs.webkit.org/show_bug.cgi?id=30706
1806
1807         * plugins/qt/PluginViewQt.cpp:
1808         (WebCore::PluginView::getValue):
1809
1810 2009-10-23  Girish Ramakrishnan  <girish@forwardbias.in>
1811
1812         Reviewed by Holger Freyther.
1813
1814         [Qt] Windowless Plugins : Don't use m_clipRect when painting.
1815
1816         Though it works, it is not correct to use m_clipRect for painting
1817         in Windowless mode. Instead, the rect paramater that is passed
1818         as a part of PluginView::paint() must be used. This change will
1819         also result in some speedup since previously we used to paint all
1820         the visible parts of a windowless plugin (even if those parts were
1821         not dirty).
1822
1823         Also, fix invalidateRect() to compute the correct width and height.
1824
1825         https://bugs.webkit.org/show_bug.cgi?id=30711
1826
1827         * plugins/qt/PluginViewQt.cpp:
1828         (WebCore::PluginView::paint):
1829         (WebCore::PluginView::invalidateRect):
1830
1831 2009-10-21  Girish Ramakrishnan  <girish@forwardbias.in>
1832
1833         Reviewed by Holger Freyther.
1834
1835         Plugins : Use test.swf in the plugins manual tests.
1836
1837         They previously referenced youtube videos which among other things are
1838         cumbersome to use without internet connection. The old youtube link is
1839         just commented out so that testing with youtube can be done with
1840         little effort.
1841
1842         https://bugs.webkit.org/show_bug.cgi?id=30662
1843
1844         * manual-tests/plugins/test.swf: Copied from LayoutTests/fast/replaced/resources/test.swf.
1845         * manual-tests/plugins/windowed.html:
1846         * manual-tests/plugins/windowless.html:
1847         * manual-tests/qt/plugin-sibling-frame-include.html:
1848
1849 2009-10-23  Brian Weinstein  <bweinstein@apple.com>
1850
1851         Reviewed by Jon Honeycutt.
1852
1853         Fix the Windows Release build by moving Accessibility files
1854         into all-in-one file and excluding them from the build.
1855
1856         * WebCore.vcproj/WebCore.vcproj:
1857         * accessibility/AccessibilityAllInOne.cpp: Added.
1858
1859 2009-10-16  Gavin Barraclough  <barraclough@apple.com>
1860
1861         Reviewed by Sam Weinig & Geoff Garen.
1862
1863         https://bugs.webkit.org/show_bug.cgi?id=30696
1864         Add support for IsolatedWorlds to JSC bindings.
1865
1866         An IsolatedWorld is basically a parallel, separate copy of the window shells and DOM wrapper objects for
1867         a given document.  To support isolation this patch:
1868
1869             * Adds support to the ScriptController to track multiple window shells, one per world.
1870             * Adds support to Document to support multiple separate wrapper-maps, one per world.
1871             * Replaces the single global DOM wrapper map (on the WebCoreJSClientData) with separate maps,
1872               stored on the (new) IsolatedWorld objects.
1873
1874         In addition to supporting separate copies of these objects, two other features are supported:
1875
1876             * It is necessary to track the current world on entry into JSC, so that within callbacks out to WebCore
1877               we can determine which world (and as such, set of DOM bindings) we should be operating on.
1878             * EventListeners & Callbacks are run in the world they were registered in.
1879               This requires the handler to retain a reference to the world.
1880
1881         No new tests. (Enabled existing isolated world layout tests.)
1882
1883         * WebCore.base.exp:
1884         * bindings/js/JSAbstractWorkerCustom.cpp:
1885         (WebCore::JSAbstractWorker::addEventListener):
1886         (WebCore::JSAbstractWorker::removeEventListener):
1887         * bindings/js/JSCallbackData.cpp:
1888         (WebCore::JSCallbackData::invokeCallback):
1889         * bindings/js/JSCallbackData.h:
1890         (WebCore::JSCallbackData::JSCallbackData):
1891         * bindings/js/JSCustomXPathNSResolver.cpp:
1892         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
1893         * bindings/js/JSDOMApplicationCacheCustom.cpp:
1894         (WebCore::JSDOMApplicationCache::addEventListener):
1895         (WebCore::JSDOMApplicationCache::removeEventListener):
1896         * bindings/js/JSDOMBinding.cpp:
1897         (WebCore::removeWrappers):
1898         (WebCore::DOMObjectWrapperMap::get):
1899         (WebCore::DOMObjectWrapperMap::set):
1900         (WebCore::DOMObjectWrapperMap::remove):
1901         (WebCore::DOMObjectWrapperMap::take):
1902         (WebCore::IsolatedWorld::IsolatedWorld):
1903         (WebCore::IsolatedWorld::~IsolatedWorld):
1904         (WebCore::EnterIsolatedWorld::EnterIsolatedWorld):
1905         (WebCore::EnterIsolatedWorld::~EnterIsolatedWorld):
1906         (WebCore::JSGlobalDataWorldIterator::JSGlobalDataWorldIterator):
1907         (WebCore::JSGlobalDataWorldIterator::operator bool):
1908         (WebCore::JSGlobalDataWorldIterator::operator*):
1909         (WebCore::JSGlobalDataWorldIterator::operator->):
1910         (WebCore::JSGlobalDataWorldIterator::operator++):
1911         (WebCore::getCurrentWorld):
1912         (WebCore::getNormalWorld):
1913         (WebCore::commonNormalWorld):
1914         (WebCore::commonCurrentWorld):
1915         (WebCore::DOMObjectHashTableMap::mapFor):
1916         (WebCore::DOMObjectWrapperMap::mapFor):
1917         (WebCore::forgetDOMObject):
1918         (WebCore::getCachedDOMNodeWrapper):
1919         (WebCore::forgetDOMNode):
1920         (WebCore::cacheDOMNodeWrapper):
1921         (WebCore::forgetAllDOMNodesForDocument):
1922         (WebCore::forgetWorldOfDOMNodesForDocument):
1923         (WebCore::isObservableThroughDOM):
1924         (WebCore::markDOMNodesForDocument):
1925         (WebCore::markActiveObjectsForContext):
1926         (WebCore::takeWrappers):
1927         (WebCore::updateDOMNodeDocument):
1928         (WebCore::markDOMObjectWrapper):
1929         (WebCore::allowsAccessFromFrame):
1930         (WebCore::printErrorMessageForFrame):
1931         (WebCore::JSC_DebuggerCallFrame_evaluateInWorld):
1932         (WebCore::JSC_callInWorld):
1933         (WebCore::JSC_constructInWorld):
1934         (WebCore::JSC_evaluateInWorld):
1935         * bindings/js/JSDOMBinding.h:
1936         (WebCore::IsolatedWorld::rememberDocument):
1937         (WebCore::IsolatedWorld::forgetDocument):
1938         (WebCore::IsolatedWorld::rememberScriptController):
1939         (WebCore::IsolatedWorld::forgetScriptController):
1940         (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
1941         (WebCore::DOMObjectHashTableMap::get):
1942         (WebCore::WebCoreJSClientData::WebCoreJSClientData):
1943         (WebCore::WebCoreJSClientData::currentWorld):
1944         (WebCore::WebCoreJSClientData::normalWorld):
1945         (WebCore::WebCoreJSClientData::rememberWorld):
1946         (WebCore::WebCoreJSClientData::forgetWorld):
1947         (WebCore::debuggerWorld):
1948         (WebCore::pluginWorld):
1949         * bindings/js/JSDOMGlobalObject.cpp:
1950         (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
1951         (WebCore::toJSDOMGlobalObject):
1952         * bindings/js/JSDOMGlobalObject.h:
1953         * bindings/js/JSDOMWindowBase.cpp:
1954         (WebCore::JSDOMWindowBase::printErrorMessage):
1955         (WebCore::JSDOMWindowBase::commonJSGlobalData):
1956         (WebCore::toJS):
1957         (WebCore::toJSDOMWindow):
1958         * bindings/js/JSDOMWindowBase.h:
1959         * bindings/js/JSDOMWindowCustom.cpp:
1960         (WebCore::createWindow):
1961         (WebCore::JSDOMWindow::open):
1962         (WebCore::JSDOMWindow::showModalDialog):
1963         (WebCore::JSDOMWindow::setTimeout):
1964         (WebCore::JSDOMWindow::setInterval):
1965         (WebCore::JSDOMWindow::addEventListener):
1966         (WebCore::JSDOMWindow::removeEventListener):
1967         * bindings/js/JSDOMWindowShell.cpp:
1968         (WebCore::toJS):
1969         (WebCore::toJSDOMWindowShell):
1970         * bindings/js/JSDOMWindowShell.h:
1971         * bindings/js/JSDesktopNotificationsCustom.cpp:
1972         (WebCore::JSNotification::addEventListener):
1973         (WebCore::):
1974         * bindings/js/JSEventListener.cpp:
1975         (WebCore::JSEventListener::JSEventListener):
1976         (WebCore::JSEventListener::handleEvent):
1977         (WebCore::JSEventListener::reportError):
1978         * bindings/js/JSEventListener.h:
1979         (WebCore::JSEventListener::create):
1980         * bindings/js/JSEventSourceCustom.cpp:
1981         (WebCore::JSEventSource::addEventListener):
1982         (WebCore::JSEventSource::removeEventListener):
1983         * bindings/js/JSEventTarget.cpp:
1984         (WebCore::toJS):
1985         * bindings/js/JSHTMLDocumentCustom.cpp:
1986         (WebCore::JSHTMLDocument::open):
1987         * bindings/js/JSHTMLFrameSetElementCustom.cpp:
1988         (WebCore::JSHTMLFrameSetElement::nameGetter):
1989         * bindings/js/JSInspectorBackendCustom.cpp:
1990         (WebCore::JSInspectorBackend::databaseForId):
1991         (WebCore::JSInspectorBackend::inspectedWindow):
1992         (WebCore::JSInspectorBackend::nodeForId):
1993         * bindings/js/JSLazyEventListener.cpp:
1994         (WebCore::JSLazyEventListener::JSLazyEventListener):
1995         (WebCore::JSLazyEventListener::parseCode):
1996         * bindings/js/JSLazyEventListener.h:
1997         (WebCore::JSLazyEventListener::create):
1998         * bindings/js/JSMessageChannelCustom.cpp:
1999         (WebCore::JSMessageChannel::markChildren):
2000         * bindings/js/JSMessagePortCustom.cpp:
2001         (WebCore::JSMessagePort::markChildren):
2002         (WebCore::JSMessagePort::addEventListener):
2003         (WebCore::JSMessagePort::removeEventListener):
2004         * bindings/js/JSNodeCustom.cpp:
2005         (WebCore::JSNode::addEventListener):
2006         (WebCore::JSNode::removeEventListener):
2007         (WebCore::JSNode::markChildren):
2008         * bindings/js/JSNodeFilterCondition.cpp:
2009         (WebCore::JSNodeFilterCondition::acceptNode):
2010         * bindings/js/JSQuarantinedObjectWrapper.cpp:
2011         (WebCore::JSQuarantinedObjectWrapper::construct):
2012         (WebCore::JSQuarantinedObjectWrapper::call):
2013         * bindings/js/JSSVGElementInstanceCustom.cpp:
2014         (WebCore::JSSVGElementInstance::addEventListener):
2015         (WebCore::JSSVGElementInstance::removeEventListener):
2016         * bindings/js/JSSharedWorkerCustom.cpp:
2017         (WebCore::JSSharedWorker::markChildren):
2018         * bindings/js/JSWebSocketCustom.cpp:
2019         (WebCore::JSWebSocket::addEventListener):
2020         (WebCore::JSWebSocket::removeEventListener):
2021         * bindings/js/JSWorkerContextCustom.cpp:
2022         (WebCore::JSWorkerContext::addEventListener):
2023         (WebCore::JSWorkerContext::removeEventListener):
2024         (WebCore::JSWorkerContext::setTimeout):
2025         (WebCore::JSWorkerContext::setInterval):
2026         * bindings/js/JSXMLHttpRequestConstructor.cpp:
2027         (WebCore::constructXMLHttpRequest):
2028         * bindings/js/JSXMLHttpRequestCustom.cpp:
2029         (WebCore::JSXMLHttpRequest::markChildren):
2030         (WebCore::JSXMLHttpRequest::addEventListener):
2031         (WebCore::JSXMLHttpRequest::removeEventListener):
2032         * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
2033         (WebCore::JSXMLHttpRequestUpload::markChildren):
2034         (WebCore::JSXMLHttpRequestUpload::addEventListener):
2035         (WebCore::JSXMLHttpRequestUpload::removeEventListener):
2036         * bindings/js/ScheduledAction.cpp:
2037         (WebCore::ScheduledAction::create):
2038         (WebCore::ScheduledAction::ScheduledAction):
2039         (WebCore::ScheduledAction::executeFunctionInContext):
2040         (WebCore::ScheduledAction::execute):
2041         * bindings/js/ScheduledAction.h:
2042         (WebCore::ScheduledAction::ScheduledAction):
2043         * bindings/js/ScriptCachedFrameData.cpp:
2044         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
2045         (WebCore::ScriptCachedFrameData::restore):
2046         * bindings/js/ScriptController.cpp:
2047         (WebCore::ScriptController::~ScriptController):
2048         (WebCore::ScriptController::evaluateInWorld):
2049         (WebCore::ScriptController::evaluate):
2050         (WebCore::ScriptController::evaluateInIsolatedWorld):
2051         (WebCore::ScriptController::clearWindowShell):
2052         (WebCore::ScriptController::initScript):
2053         (WebCore::ScriptController::processingUserGestureEvent):
2054         (WebCore::ScriptController::attachDebugger):
2055         (WebCore::ScriptController::updateDocument):
2056         (WebCore::ScriptController::bindingRootObject):
2057         (WebCore::ScriptController::createRootObject):
2058         (WebCore::ScriptController::windowScriptNPObject):
2059         (WebCore::ScriptController::jsObjectForPluginElement):
2060         * bindings/js/ScriptController.h:
2061         (WebCore::ScriptController::windowShell):
2062         (WebCore::ScriptController::existingWindowShell):
2063         (WebCore::ScriptController::globalObject):
2064         (WebCore::ScriptController::forgetWorld):
2065         * bindings/js/ScriptControllerMac.mm:
2066         (WebCore::ScriptController::windowScriptObject):
2067         * bindings/js/ScriptEventListener.cpp:
2068         (WebCore::createAttributeEventListener):
2069         * bindings/js/ScriptFunctionCall.cpp:
2070         (WebCore::ScriptFunctionCall::call):
2071         (WebCore::ScriptFunctionCall::construct):
2072         * bindings/js/ScriptObjectQuarantine.cpp:
2073         (WebCore::getQuarantinedScriptObject):
2074         * bindings/js/ScriptState.cpp:
2075         (WebCore::scriptStateFromNode):
2076         (WebCore::scriptStateFromPage):
2077         * bindings/js/ScriptState.h:
2078         * bindings/js/WorkerScriptController.cpp:
2079         (WebCore::WorkerScriptController::WorkerScriptController):
2080         (WebCore::WorkerScriptController::evaluate):
2081         * bindings/objc/DOMInternal.mm:
2082         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2083         * bindings/objc/WebScriptObject.mm:
2084         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2085         (-[WebScriptObject evaluateWebScript:]):
2086         * bindings/scripts/CodeGeneratorJS.pm:
2087         * bridge/NP_jsobject.cpp:
2088         (_NPN_InvokeDefault):
2089         (_NPN_Invoke):
2090         (_NPN_Evaluate):
2091         (_NPN_Construct):
2092         * bridge/jni/jni_jsobject.mm:
2093         (JavaJSObject::call):
2094         (JavaJSObject::eval):
2095         * dom/Document.cpp:
2096         (WebCore::Document::createWrapperCache):
2097         * dom/Document.h:
2098         (WebCore::Document::wrapperCacheMap):
2099         (WebCore::Document::getWrapperCache):
2100         * inspector/InspectorController.cpp:
2101         (WebCore::InspectorController::startUserInitiatedProfiling):
2102         (WebCore::InspectorController::stopUserInitiatedProfiling):
2103         * inspector/JavaScriptCallFrame.cpp:
2104         (WebCore::JavaScriptCallFrame::evaluate):
2105         * loader/FrameLoader.cpp:
2106         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
2107         * platform/network/mac/AuthenticationMac.mm:
2108         * xml/XMLHttpRequest.cpp:
2109         (WebCore::XMLHttpRequest::XMLHttpRequest):
2110         (WebCore::XMLHttpRequest::dropProtection):
2111         * xml/XMLHttpRequest.h:
2112         (WebCore::XMLHttpRequest::create):
2113
2114 2009-10-22  Joseph Pecoraro  <joepeck@webkit.org>
2115
2116         Reviewed by Timothy Hatcher.
2117
2118         Web Inspector: EventListenersSidebarPane TODO No Longer Needed
2119         https://bugs.webkit.org/show_bug.cgi?id=30705
2120
2121         * inspector/front-end/EventListenersSidebarPane.js:
2122
2123 2009-10-22  Alexey Proskuryakov  <ap@apple.com>
2124
2125         Reviewed by Tim Hatcher.
2126
2127         https://bugs.webkit.org/show_bug.cgi?id=30506
2128         <rdar://problem/7319845> Resources that the server sent as 304 not modified are not shown
2129         in the inspectors resource pane
2130
2131         I don't know how to make a test for this.
2132
2133         The issue here was that preloaded resources weren't added to DocLoader document resource set,
2134         but Web Inspector asked DocLoader to fetch data from CachedResource. Even when (if) document
2135         parser eventually requested the same resource for real and it got added to resource set, it
2136         was too late - the Inspector wasn't updated.
2137
2138         * inspector/InspectorResource.cpp:
2139         (WebCore::InspectorResource::cachedResource):
2140         (WebCore::InspectorResource::type):
2141         (WebCore::InspectorResource::resourceData):
2142         * inspector/InspectorResource.h:
2143         Fix the issue by trying to fetch corresponding CachedResource harder - also look in global
2144         cache. This seems safe, and easier than updating the Inspector on transitions between
2145         resource states (revalidate vs. revalidate done and preload vs. non-preload).
2146
2147 2009-10-22  Beth Dakin  <bdakin@apple.com>
2148
2149         Reviewed by Dan Bernstein.
2150
2151         Fix for <rdar://problem/6942706> ER: Add a CSS property that allows
2152         shadows to work for SVG content
2153         -and corresponding-
2154         https://bugs.webkit.org/show_bug.cgi?id=30479
2155
2156         This patch adds a new SVG-specific CSS property called -webkit-
2157         shadow that has the same syntax as -webkit-box-shadow
2158
2159         Add CSSPropertyWebkitShadow to the list of SVG CSS properties, and
2160         make valueForShadow a member function rather than a static function
2161         * css/CSSComputedStyleDeclaration.cpp:
2162         (WebCore::):
2163         (WebCore::CSSComputedStyleDeclaration::valueForShadow):
2164         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2165         * css/CSSComputedStyleDeclaration.h:
2166
2167         Call valueForShadow for CSSPropertyWebkitShadow
2168         * css/SVGCSSComputedStyleDeclaration.cpp:
2169         (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
2170
2171         Do standard CSS stuff for CSSPropertyWebkitShadow
2172         * css/SVGCSSParser.cpp:
2173         (WebCore::CSSParser::parseSVGValue):
2174         * css/SVGCSSPropertyNames.in:
2175         * css/SVGCSSStyleSelector.cpp:
2176         (WebCore::CSSStyleSelector::applySVGProperty):
2177
2178         Set the appropriate shadow on the paint context if we have one.
2179         This seems to be all we have to do to have an SVG-shaped shadow.
2180         * rendering/SVGRenderSupport.cpp:
2181         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
2182
2183         Add shadow to SVGRenderStyle. I added a new macro that I don't like
2184         just because that's the way things are done here right now.
2185         * rendering/style/SVGRenderStyle.cpp:
2186         (WebCore::SVGRenderStyle::SVGRenderStyle):
2187         (WebCore::SVGRenderStyle::operator==):
2188         * rendering/style/SVGRenderStyle.h:
2189         * rendering/style/SVGRenderStyleDefs.cpp:
2190         (StyleShadowSVGData::StyleShadowSVGData):
2191         (StyleShadowSVGData::operator==):
2192         * rendering/style/SVGRenderStyleDefs.h:
2193         (WebCore::StyleShadowSVGData::create):
2194         (WebCore::StyleShadowSVGData::copy):
2195         (WebCore::StyleShadowSVGData::operator!=):
2196
2197 2009-10-22  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2198
2199         Reviewed by Xan Lopez.
2200
2201         https://bugs.webkit.org/show_bug.cgi?id=25530
2202         [Gtk] Implement LABEL_FOR/LABELLED_BY relationship pair for labels
2203
2204         Implements atk_object_ref_relation_set and LABEL_FOR/LABELLED_BY.
2205         Also causes the accessible name for labeled controls to be based on
2206         the label as expected, rather than based on the contents.
2207
2208         * accessibility/AccessibilityRenderObject.h:
2209         * accessibility/AccessibilityRenderObject.cpp:
2210         (correspondingLabelForControlElement):
2211         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2212         (setAtkRelationSetFromCoreObject):
2213         (webkit_accessible_ref_relation_set):
2214         (webkit_accessible_class_init):
2215         (webkit_accessible_get_name):
2216
2217 2009-10-22  Joseph Pecoraro  <joepeck@webkit.org>
2218
2219         Reviewed by Timothy Hatcher.
2220
2221         Web Inspector: windowFocused and windowBlured Fail to Clear/Mark Inspector as "inactive"
2222         https://bugs.webkit.org/show_bug.cgi?id=30663
2223
2224           Correctly handle focusing/blurring on inner <iframe>'s such as Source Frames.
2225
2226         * inspector/front-end/inspector.js:
2227         (WebInspector.windowFocused): fix for inner iframes
2228         (WebInspector.windowBlurred): fix for inner iframes
2229         (WebInspector.addMainEventListeners): change useCapture to false
2230
2231 2009-10-22  Jaime Yap  <jaimeyap@google.com>
2232
2233         Reviewed by Timothy Hatcher.
2234
2235         Makes a page reload optional when activating resource monitoring in
2236         InspectorController. It leaves the default behavior as performing the reload.
2237         Reload is an optional param so callsites do not have to change.
2238
2239         https://bugs.webkit.org/show_bug.cgi?id=30684
2240
2241         No new tests added.
2242
2243         * inspector/InspectorController.cpp:
2244         (WebCore::InspectorController::enableResourceTracking):
2245         * inspector/InspectorController.h:
2246
2247 2009-10-22  Shu Chang  <Chang.Shu@nokia.com>
2248
2249         Reviewed by Eric Seidel.
2250
2251         [Qt] Fix memory leak in QNetworkReplyHandler::abort().
2252         In QNetworkReplyHandler::release(), m_reply should no longer point to its parent
2253         after being released.
2254         https://bugs.webkit.org/show_bug.cgi?id=30167
2255
2256         No layout test available as a non-functional fix.
2257
2258         * platform/network/qt/QNetworkReplyHandler.cpp:
2259         (WebCore::QNetworkReplyHandler::abort):
2260         (WebCore::QNetworkReplyHandler::release):
2261
2262 2009-10-22  Pavel Feldman  <pfeldman@chromium.org>
2263
2264         Reviewed by Timothy Hatcher.
2265
2266         Web Inspector: Fix DOMAgent leak.
2267
2268         https://bugs.webkit.org/show_bug.cgi?id=30615
2269
2270         * inspector/InspectorController.cpp:
2271         (WebCore::InspectorController::~InspectorController):
2272         (WebCore::InspectorController::setFrontendProxyObject):
2273         (WebCore::InspectorController::close):
2274         (WebCore::InspectorController::releaseDOMAgent):
2275         * inspector/InspectorController.h:
2276         * inspector/InspectorDOMAgent.h:
2277         (WebCore::InspectorDOMAgent::create):
2278
2279 2009-10-22  Dimitri Glazkov  <dglazkov@chromium.org>
2280
2281         Reviewed by Adam Barth.
2282
2283         [V8] Rework event listeners to not hold references to frame or V8 context.
2284
2285         https://bugs.webkit.org/show_bug.cgi?id=30648
2286
2287         Covered by existing layout tests: fast/events/attribute-listener*
2288
2289         * bindings/scripts/CodeGeneratorV8.pm: Added passing ScriptExecutionContext*
2290             to event listener handling code.
2291         * bindings/v8/DateExtension.cpp:
2292         (WebCore::DateExtension::setAllowSleep): Changed to use currentContext().
2293         * bindings/v8/ScriptEventListener.cpp:
2294         (WebCore::createAttributeEventListener): Reworked to match JSC logic.
2295         (WebCore::getEventListenerHandlerBody): Added ScriptExecutionContext* param.
2296         * bindings/v8/V8AbstractEventListener.cpp:
2297         (WebCore::V8AbstractEventListener::V8AbstractEventListener): Removed Frame* param
2298             and usage.
2299         (WebCore::V8AbstractEventListener::handleEvent): Chaged to use ScriptExecutionContext*.
2300         (WebCore::V8AbstractEventListener::invokeEventHandler): Ditto.
2301         * bindings/v8/V8AbstractEventListener.h:
2302         (WebCore::V8AbstractEventListener::getListenerObject): Ditto.
2303         (WebCore::V8AbstractEventListener::prepareListenerObject): Ditto.
2304         * bindings/v8/V8DOMWrapper.cpp:
2305         (WebCore::V8DOMWrapper::convertEventListenerToV8Object):  Added ScriptExecutionContext* param.
2306         (WebCore::V8DOMWrapper::getEventListener): Ditto.
2307         * bindings/v8/V8DOMWrapper.h:
2308         (WebCore::V8DOMWrapper::convertEventListenerToV8Object): Ditto.
2309         * bindings/v8/V8EventListenerList.h:
2310         (WebCore::V8EventListenerList::findOrCreateWrapper): Removed ContextType* template param,
2311             because it's no longer needed.
2312         * bindings/v8/V8IsolatedWorld.h:
2313         (WebCore::V8IsolatedWorld::sharedContext): Renamed from shared_context.
2314         * bindings/v8/V8LazyEventListener.cpp:
2315         (WebCore::V8LazyEventListener::V8LazyEventListener): Removed Frame* param and usage.
2316         (WebCore::V8LazyEventListener::callListenerFunction): Added ScriptExecutionContext* param.
2317         (WebCore::V8LazyEventListener::prepareListenerObject): Ditto.
2318         * bindings/v8/V8LazyEventListener.h:
2319         (WebCore::V8LazyEventListener::create): Reordered params to match JSC impl.
2320         * bindings/v8/V8Proxy.cpp:
2321         (WebCore::V8Proxy::V8Proxy): Adjusted formatting to match WebKit style.
2322         (WebCore::V8Proxy::evaluateInNewContext): Changed to use m_context directly.
2323         (WebCore::V8Proxy::setInjectedScriptContextDebugId): Ditto.
2324         (WebCore::V8Proxy::createWrapperFromCacheSlowCase): Ditto.
2325         (WebCore::V8Proxy::isContextInitialized): Ditto.
2326         (WebCore::V8Proxy::updateDocumentWrapperCache): Ditto.
2327         (WebCore::V8Proxy::clearDocumentWrapperCache): Ditto.
2328         (WebCore::V8Proxy::disposeContextHandles): Added explicit disposing of m_context.
2329         (WebCore::V8Proxy::clearForClose): Changed to use m_context directly.
2330         (WebCore::V8Proxy::clearForNavigation): Ditto.
2331         (WebCore::V8Proxy::setSecurityToken): Ditto.
2332         (WebCore::V8Proxy::updateDocument): Ditto.
2333         (WebCore::V8Proxy::initContextIfNeeded): Ditto.
2334         (WebCore::V8Proxy::context): Changed to use v8::Local.
2335         (WebCore::V8Proxy::mainWorldContext): Changed to use m_context directly.
2336         (WebCore::V8Proxy::setContextDebugId): Ditto.
2337         (WebCore::toV8Context):
2338         * bindings/v8/V8Proxy.h: Removed shared_context decl, changed to use straight
2339             v8::Persistent for m_context.
2340         * bindings/v8/V8WorkerContextEventListener.cpp:
2341         (WebCore::workerProxy): Added.
2342         (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Removed
2343             WorkerContextExecutionProxy* param.
2344         (WebCore::V8WorkerContextEventListener::handleEvent): Started using ScriptExecutionContext*.
2345         (WebCore::V8WorkerContextEventListener::reportError): Ditto.
2346         (WebCore::V8WorkerContextEventListener::callListenerFunction): Ditto.
2347         (WebCore::V8WorkerContextEventListener::getReceiverObject): Ditto.
2348         * bindings/v8/V8WorkerContextEventListener.h:
2349         (WebCore::V8WorkerContextEventListener::create): Removed
2350             WorkerContextExecutionProxy* param.
2351         * bindings/v8/WorkerContextExecutionProxy.cpp:
2352         (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener): Removed ContextType*
2353             template param.
2354         * bindings/v8/custom/V8CustomEventListener.cpp:
2355         (WebCore::V8EventListener::V8EventListener): Removed Frame* param.
2356         (WebCore::V8EventListener::getListenerFunction): Started using ScriptExecutionContext*.
2357         (WebCore::V8EventListener::callListenerFunction): Ditto.
2358         * bindings/v8/custom/V8CustomEventListener.h:
2359         (WebCore::V8EventListener::create): Removed Frame* param.
2360
2361 2009-10-14  Gaurav Shah  <gauravsh@google.com>
2362
2363         Reviewed by Darin Fisher.
2364
2365         Replaces temporary link stub for <keygen> tag handler for the Chromium
2366         browser with a call via the Chromium Bridge.
2367
2368         https://bugs.webkit.org/show_bug.cgi?id=30360
2369
2370         * platform/SSLKeyGenerator.h:
2371         * platform/chromium/ChromiumBridge.h:
2372         * platform/chromium/SSLKeyGeneratorChromium.cpp:
2373         (WebCore::getSupportedKeySizes):
2374         (WebCore::signedPublicKeyAndChallengeString):
2375         * platform/chromium/TemporaryLinkStubs.cpp:
2376         (WebCore::KURL::fileSystemPath):
2377         (WebCore::SharedBuffer::createWithContentsOfFile):
2378
2379 2009-10-22  Avi Drissman  <avi@chromium.org>
2380
2381         Reviewed by Eric Seidel.
2382
2383         Fixes Chromium Mac pasteboard handling to flow through the same code paths as other platforms.
2384
2385         https://bugs.webkit.org/show_bug.cgi?id=30591
2386
2387         * platform/chromium/ChromiumBridge.h:
2388         * platform/chromium/PasteboardChromium.cpp:
2389         (WebCore::Pasteboard::writeImage):
2390
2391 2009-10-20  Simon Fraser  <simon.fraser@apple.com>
2392
2393         Reviewed by Darin Adler.
2394
2395         Make accelerated compositing debug indicators work in release builds
2396         https://bugs.webkit.org/show_bug.cgi?id=30588
2397
2398         Allow some debug indicators, that show which page elements go into compositing layers,
2399         to work in release builds, when the runtime prefs are set.
2400
2401         * platform/graphics/GraphicsLayer.cpp:
2402         (WebCore::GraphicsLayer::GraphicsLayer):
2403         (WebCore::GraphicsLayer::setZPosition):
2404         * platform/graphics/GraphicsLayer.h:
2405         * platform/graphics/mac/GraphicsLayerCA.h:
2406         * platform/graphics/mac/GraphicsLayerCA.mm:
2407         (WebCore::clearBorderColor):
2408         (WebCore::GraphicsLayer::showRepaintCounter):
2409         (WebCore::GraphicsLayerCA::GraphicsLayerCA):
2410         (WebCore::GraphicsLayerCA::updateMasksToBounds):
2411         (WebCore::GraphicsLayerCA::updateLayerDrawsContent):
2412         (WebCore::GraphicsLayerCA::setDebugBorder):
2413         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
2414         (WebCore::GraphicsLayerCA::setupContentsLayer):
2415         * platform/graphics/mac/WebLayer.mm:
2416
2417 2009-10-22  Keishi Hattori  <casey.hattori@gmail.com>
2418
2419         Reviewed by Pavel Feldman.
2420
2421         Inspector should support monitorEvents/un monitorEvents() in the command line
2422         https://bugs.webkit.org/show_bug.cgi?id=19879
2423
2424         * inspector/front-end/EventListenersSidebarPane.js:
2425         (WebInspector.EventListenersSidebarPane.prototype.update.callback): Ignores event listeners generated by monitorEvent
2426         * inspector/front-end/InjectedScript.js:
2427         (InjectedScript._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI._logEvent, _allEventTypes,
2428         _normalizeEventTypes, monitorEvent, unmonitorEvent.
2429
2430 2009-10-21  Joseph Pecoraro  <joepeck@webkit.org>
2431
2432         Reviewed by Pavel Feldman.
2433
2434         Web Inspector: windowFocused and windowBlurred Fail to Clear/Mark Inspector as "inactive"
2435         https://bugs.webkit.org/show_bug.cgi?id=30663
2436
2437         * inspector/front-end/inspector.js:
2438         (WebInspector.windowFocused):
2439         (WebInspector.windowBlurred):
2440
2441 2009-10-22  Joseph Pecoraro  <joepeck@webkit.org>
2442
2443         Reviewed by Pavel Feldman.
2444
2445         Web Inspector: Error - requestContentType [undefined] is not an object
2446         https://bugs.webkit.org/show_bug.cgi?id=30666
2447
2448         * inspector/front-end/ResourceView.js:
2449         (WebInspector.ResourceView.prototype._refreshFormData):
2450
2451 2009-10-22  Maxime Simon  <simon.maxime@gmail.com>
2452
2453         Reviewed by Holger Freyther.
2454
2455         [Haiku] Correction of the accented letter width (they were 2 characters long).
2456         https://bugs.webkit.org/show_bug.cgi?id=30629
2457
2458         * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
2459         (WebCore::SimpleFontData::platformWidthForGlyph):
2460
2461 2009-10-21  Jon Honeycutt  <jhoneycutt@apple.com>
2462
2463         <rdar://problem/7270320> Screenshots of off-screen plug-ins are blank
2464         <rdar://problem/7270314> After halting a transparent PluginView on
2465         Windows, the transparency is applied twice
2466
2467         Replace use of Frame::nodeImage() with a function that takes a snapshot
2468         of a PluginView.
2469
2470         Reviewed by Dan Bernstein.
2471
2472         * plugins/PluginView.h:
2473         Made paintWindowedPluginIntoContext() non-const, as it now calls
2474         paintIntoTransformedContext(). Declare paintIntoTransformedContext()
2475         and snapshot() for Windows platforms.
2476
2477         * plugins/win/PluginViewWin.cpp:
2478         (WebCore::PluginView::paintIntoTransformedContext):
2479         Paints into the passed HDC without applying any coordinate translations.
2480         Code moved from paintWindowedPluginIntoContext() and paint(). Removed
2481         the memset() of windowpos in lieu of assignment.
2482         (WebCore::PluginView::paintWindowedPluginIntoContext):
2483         Code moved to paintIntoTransformedContext().
2484         (WebCore::PluginView::paint):
2485         Ditto.
2486         (WebCore::PluginView::snapshot):
2487         Create a context, and if the plug-in is windowless, translate it so the
2488         plug-in will draw at the correct location. Create a bitmap, and select
2489         it into the context. Paint the plug-in, and create a BitmapImage from
2490         the bitmap.
2491         (WebCore::PluginView::halt):
2492         Use snapshot().
2493
2494 2009-10-22  Fumitoshi Ukai  <ukai@chromium.org>
2495
2496         Reviewed by Alexey Proskuryakov.
2497
2498         Fix calculation of length in WebSocketChannel.cpp
2499         https://bugs.webkit.org/show_bug.cgi?id=30656
2500
2501         * websockets/WebSocketChannel.cpp:
2502         (WebCore::WebSocketChannel::didReceiveData):
2503
2504 2009-10-21  Dumitru Daniliuc  <dumi@chromium.org>
2505
2506         Reviewed by Dimitri Glazkov.
2507
2508         Adding the ability to enable/disable functions in V8 at runtime.
2509
2510         https://bugs.webkit.org/show_bug.cgi?id=30650
2511
2512         * bindings/scripts/CodeGeneratorV8.pm:
2513
2514 2009-10-21  Darin Adler  <darin@apple.com>
2515
2516         Swedish search (and other languages as well) is broken while fixing Japanese search
2517         https://bugs.webkit.org/show_bug.cgi?id=30646
2518
2519         Rolled Japanese tailoring out that was done to fix
2520         https://bugs.webkit.org/show_bug.cgi?id=30437 earlier.
2521         It was overriding the locale-specific tailoring.
2522         We'll land a fix once we figure out how to add the
2523         Japanese tailoring without removing anything.
2524
2525         * editing/TextIterator.cpp: Rolled out r49924.
2526
2527 2009-10-21  Pavel Feldman  <pfeldman@chromium.org>
2528
2529         Not reviewed: chromium build fix - add missing image to gypi.
2530
2531         * WebCore.gypi:
2532
2533 2009-10-21  Brian Weinstein  <bweinstein@apple.com>
2534
2535         Reviewed by Eric Seidel.
2536
2537         Fixes part of <http://webkit.org/b/30522>.
2538         Web Inspector: DOM Exceptions throughout the Inspector should be more human readable.
2539
2540         Expose the description attribute that is now a member of
2541         ExceptionBase as of r49723, so when a user logs an exception, they
2542         can see the description in the Web Inspector.
2543
2544         Test: fast/dom/dom-exception-description.html
2545
2546         * dom/DOMCoreException.idl:
2547         * dom/EventException.idl:
2548         * dom/RangeException.idl:
2549         * svg/SVGException.idl:
2550         * xml/XMLHttpRequestException.idl:
2551         * xml/XPathException.idl:
2552
2553 2009-10-21  Brian Weinstein  <bweinstein@apple.com>
2554
2555         Reviewed by Timothy Hatcher.
2556
2557         Fixes <https://bugs.webkit.org/show_bug.cgi?id=30616>.
2558         REGRESSION (r49036): Web Inspector: Summary graph no longer switching to size summary.
2559
2560         Add a check to make sure a function we need to calculate percentages is
2561         defined before we use it.
2562
2563         * inspector/front-end/ResourcesPanel.js:
2564         (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
2565
2566 2009-10-21  Keishi Hattori  <casey.hattori@gmail.com>
2567
2568         Reviewed by Timothy Hatcher.
2569
2570         REGRESSION: Clicking on nodes in the console should take you to the element in the DOM
2571         https://bugs.webkit.org/show_bug.cgi?id=27231
2572
2573         * inspector/front-end/ConsoleView.js:
2574         (WebInspector.ConsoleView.prototype._formatnode): Turns on ElementsTreeOutline.showInElementsPanelEnabled
2575         * inspector/front-end/ElementsTreeOutline.js:
2576         (WebInspector.ElementsTreeOutline): Added ElementsTreeOutline.showInElementsPanelEnabled
2577         (WebInspector.ElementsTreeElement.prototype.onmousedown): Reveals the node in the Elements panel if
2578         treeOutline.showInElementsPanelEnabled is true.
2579
2580 2009-10-21  Jeremy Orlow  <jorlow@chromium.org>
2581
2582         Reviewed by Eric Seidel.
2583
2584         https://bugs.webkit.org/show_bug.cgi?id=30637
2585         Fix a compiler warning in windows.
2586
2587         * loader/ResourceLoadNotifier.h:
2588
2589 2009-10-21  Dmitry Titov  <dimich@chromium.org>
2590
2591         Reviewed by Darin Adler.
2592
2593         Fix the crash when a node not in a document receives dispatchEvent.
2594         https://bugs.webkit.org/show_bug.cgi?id=30611
2595
2596         Test: fast/events/dispatch-event-no-document.html
2597
2598         * dom/EventTarget.cpp: Check for scriptExecutionContext() at the moment of dispatchEvent; do nothing if no context.
2599         (WebCore::EventTarget::dispatchEvent):
2600
2601 2009-10-21  Adam Langley  <agl@google.com>
2602
2603         Reviewed by Eric Seidel.
2604
2605         Chromium Linux: disable subpixel text on layers.
2606
2607         https://bugs.webkit.org/show_bug.cgi?id=30635
2608         http://code.google.com/p/chromium/issues/detail?id=25365
2609
2610         With the addition of layers for drawing rounded corners in r49641,
2611         subpixel text on rounded rectangles broke. This is because the layer
2612         only contains a single alpha channel and this is insufficient to
2613         compose subpixel text correctly.
2614
2615         On Windows, a large body of code in TransparencyWin.cpp exists to try
2616         to deal with this. Even then, in some cases, it downgrades to
2617         anti-aliased text. We need a fix for the grevious effects quickly thus
2618         this patch disables subpixel text when rendering into a layer.
2619
2620         This would be covered by existing tests except that subpixel text is
2621         disabled for pixel tests on Chromium Linux.
2622
2623         * platform/graphics/chromium/FontLinux.cpp:
2624         (WebCore::isCanvasMultiLayered):
2625         (WebCore::adjustTextRenderMode):
2626         (WebCore::Font::drawGlyphs):
2627         (WebCore::Font::drawComplexText):
2628
2629 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2630
2631         wxMac 10.4 build fix, make sure we specify the Sqlite3 dependency correctly as otherwise
2632         it will use the sqlite3 system library rather than WebCoreSQLite3.
2633
2634         * wscript:
2635
2636 2009-10-21  Dan Bernstein  <mitz@apple.com>
2637
2638         Reviewed by Sam Weinig.
2639
2640         Fixed background-clip parsing regressions introduced in r46240.
2641
2642         Test: fast/css/background-clip-text.html
2643
2644         * css/CSSParser.cpp:
2645         (WebCore::parseBackgroundClip): Added this helper method.
2646         (WebCore::CSSParser::parseFillShorthand): Use parseBackgroundClip() to
2647         reparse the value. The old code called parseFillProperty() again, which
2648         didn’t work, because parseFillProperty() advances the value list.
2649         (WebCore::CSSParser::parseFillProperty): Changed to use
2650         parseBackgroundClip().
2651         * css/CSSPrimitiveValueMappings.h:
2652         (WebCore::CSSPrimitiveValue::operator EFillBox): Added a case for
2653         CSSValueWebkitText.
2654
2655 2009-10-21  Alexander Pavlov  <apavlov@chromium.org>
2656
2657         Reviewed by Timothy Hatcher.
2658
2659         Enable creation of custom SidebarTreeElements for different ProfileTypes
2660
2661         ProfileTypes can now create sidebar tree elements of custom types.
2662         https://bugs.webkit.org/show_bug.cgi?id=30520
2663
2664         * inspector/front-end/ProfileView.js:
2665         (WebInspector.CPUProfileType.prototype.setRecordingProfile):
2666         (WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
2667         (WebInspector.CPUProfileType.prototype.createView):
2668         (WebInspector.CPUProfile.prototype.get head):
2669         * inspector/front-end/ProfilesPanel.js:
2670         (WebInspector.ProfileType.prototype.buttonClicked):
2671         (WebInspector.ProfileType.prototype.viewForProfile):
2672         (WebInspector.ProfileType.prototype.createView):
2673         (WebInspector.ProfileType.prototype.createSidebarTreeElementForProfile):
2674         (WebInspector.ProfilesPanel.prototype.addProfileHeader):
2675         (WebInspector.ProfilesPanel.prototype.showProfile):
2676
2677 2009-10-20  Joseph Pecoraro  <joepeck@webkit.org>
2678
2679         Reviewed by Timothy Hatcher.
2680
2681         Web Inspector: Selectors in the Styles pane should trigger a search for that selector when clicked
2682         https://bugs.webkit.org/show_bug.cgi?id=17126
2683
2684         * inspector/front-end/ElementsPanel.js:
2685         (WebInspector.ElementsPanel.prototype.addNodesToSearchResult): only change focusedDOMNode on a manual search
2686         * inspector/front-end/StylesSidebarPane.js:
2687         (WebInspector.StylePropertiesSection.prototype._clickSelector): trigger a search
2688         * inspector/front-end/ElementsTreeOutline.js:
2689         (WebInspector.ElementsTreeElement.prototype._startEditing): correctly start editing attribute value instead of name
2690
2691 2009-10-20  Pavel Feldman  <pfeldman@chromium.org>
2692
2693         Reviewed by Timothy Hatcher.
2694
2695         Web Inspector: Fix DOM Agent leak.
2696
2697         https://bugs.webkit.org/show_bug.cgi?id=30615
2698
2699         * inspector/InspectorController.cpp:
2700         (WebCore::InspectorController::~InspectorController):
2701
2702 2009-10-21  Girish Ramakrishnan  <girish@forwardbias.in>
2703
2704         Reviewed by Holger Freyther.
2705
2706         Plugins: Create manual tests for testing plugins
2707
2708         Create two test files:
2709         1. windowed.html - Test plugin in windowed mode.
2710         2. windowless.html - Test plugin in windowless mode.
2711
2712         https://bugs.webkit.org/show_bug.cgi?id=30503
2713
2714         * manual-tests/plugins/windowed.html: Added.
2715         * manual-tests/plugins/windowless.html: Added.
2716
2717 2009-10-21  Satoshi Nakagawa  <psychs@limechat.net>
2718
2719         Reviewed by Darin Adler.
2720
2721         Fixed Japanese text search problems.
2722         Treat small kana letters and kana letters as different characters in search.
2723         Do not ignore diacritic marks in search for Japanese texts.
2724
2725         https://bugs.webkit.org/show_bug.cgi?id=30437
2726
2727         Test: fast/text/international/japanese-kana-letters.html
2728
2729         * editing/TextIterator.cpp:
2730         (WebCore::createCollator):
2731         (WebCore::collator):
2732         (WebCore::createSearcher):
2733
2734 2009-10-20  Eric Z. Ayers  <zundel@google.com>
2735
2736         Reviewed by Timothy Hatcher.
2737
2738         Changes TimelineItems to be created with raw timestamps as opposed
2739         to a time relative to a start of session.  Normalized timestamps cause
2740         problems when monitoring a browsing session across multiple page
2741         transitions.
2742
2743         * inspector/InspectorTimelineAgent.cpp:
2744         (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
2745         (WebCore::InspectorTimelineAgent::willDispatchDOMEvent):
2746         (WebCore::InspectorTimelineAgent::willLayout):
2747         (WebCore::InspectorTimelineAgent::willRecalculateStyle):
2748         (WebCore::InspectorTimelineAgent::willPaint):
2749         (WebCore::InspectorTimelineAgent::willWriteHTML):
2750         (WebCore::InspectorTimelineAgent::reset):
2751         (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
2752         * inspector/InspectorTimelineAgent.h:
2753
2754 2009-10-20  Mark Rowe  <mrowe@apple.com>
2755
2756         Reviewed by Oliver Hunt.
2757
2758         Fix leak of WebSocketChannel by adopting the newly-created reference.
2759
2760         * websockets/WebSocketChannel.h:
2761         (WebCore::WebSocketChannel::create):
2762
2763 2009-10-20  Jeremy Orlow  <jorlow@chromium.org>
2764
2765         Reviewed by Adam Barth.
2766
2767         DOM Storage runtime flag changes
2768         https://bugs.webkit.org/show_bug.cgi?id=30602
2769
2770         Part 1/2.  Removing sessionStorageEnabled in next patch after the
2771         Chromium side of the changes lands.
2772
2773         Revert my changes to Settings and instead implement DOM Storage enabling via
2774         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
2775
2776         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
2777         LayoutTest visible changes and thus no tests.
2778
2779         * bindings/v8/custom/V8CustomBinding.h:
2780         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2781         (WebCore::ACCESSOR_RUNTIME_ENABLER):
2782         * page/DOMWindow.idl:
2783         * storage/Storage.cpp:
2784         (WebCore::Storage::setLocalStorageAvailable):
2785         (WebCore::Storage::localStorageAvailable):
2786         (WebCore::Storage::setSessionStorageAvailable):
2787         (WebCore::Storage::sessionStorageAvailable):
2788         * storage/Storage.h:
2789
2790 2009-10-20  John Gregg  <johnnyg@google.com>
2791
2792         Reviewed by David Levin.
2793
2794         Need to turn off notifications properly at runtime
2795         https://bugs.webkit.org/show_bug.cgi?id=30409
2796
2797         This code only affects chromium, and is all behind a compile time
2798         flag current turned off, so no new tests.
2799
2800         * bindings/v8/custom/V8CustomBinding.h:
2801         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2802         (WebCore::ACCESSOR_RUNTIME_ENABLER):
2803         * bindings/v8/custom/V8WorkerContextCustom.cpp:
2804         (WebCore::ACCESSOR_RUNTIME_ENABLER):
2805         * notifications/NotificationCenter.cpp:
2806         (WebCore::NotificationCenter::setIsAvailable):
2807         (WebCore::NotificationCenter::isAvailable):
2808         * notifications/NotificationCenter.h:
2809         * page/DOMWindow.idl:
2810         * workers/WorkerContext.idl:
2811
2812 2009-10-20  James Robinson  <jamesr@chromium.org>
2813
2814         Reviewed by Adam Barth.
2815
2816         Fixes RefPtr initialization in the V8 implementation of WebCore::ScriptString to use the ::create() idiom and
2817         use adoptRef() properly.  I failed to read the RefPtr docs the first time through :(
2818
2819         No new tests, error was caught by valgrind on the Chromium builders.
2820
2821         * bindings/v8/ScriptString.h:
2822         (WebCore::ScriptString::ScriptString):
2823         (WebCore::ScriptString::operator=):
2824         * bindings/v8/ScriptStringImpl.h:
2825         (WebCore::ScriptStringImpl::create):
2826
2827 2009-10-20  Mikhail Naganov  <mnaganov@chromium.org>
2828
2829         Reviewed by Pavel Feldman.
2830
2831         Web Inspector: populate child nodes before sorting them.
2832
2833         https://bugs.webkit.org/show_bug.cgi?id=29673
2834
2835         * inspector/front-end/BottomUpProfileDataGridTree.js:
2836         (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode.
2837         (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
2838         (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
2839         (WebInspector.BottomUpProfileDataGridNode.prototype._exclude):
2840         (WebInspector.BottomUpProfileDataGridNode.prototype._merge):
2841         (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
2842         (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
2843         * inspector/front-end/ProfileDataGridTree.js:
2844         (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses.
2845         (WebInspector.ProfileDataGridNode.prototype.get _parent):
2846         (WebInspector.ProfileDataGridNode.prototype._populate):
2847         * inspector/front-end/TopDownProfileDataGridTree.js:
2848         (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
2849
2850 2009-10-20  Jens Alfke  <snej@chromium.org>
2851
2852         Reviewed by Eric Seidel.
2853
2854         Remove redundant String ref/deref calls in generated V8 bindings.
2855         https://bugs.webkit.org/show_bug.cgi?id=30579
2856
2857         * bindings/v8/V8Binding.h:
2858         (WebCore::toString): Fix return type of 'toString' to make it truly a no-op
2859             instead of constructing/destructing a String.
2860
2861 2009-10-20  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2862
2863         Reviewed by Xan Lopez.
2864
2865         https://bugs.webkit.org/show_bug.cgi?id=25411
2866         [GTK] ATK accessible ancestry broken
2867
2868         Work around for the problem of bogus additional objects in the ancestry.
2869         We now set the parent when we ref the child, then ask the Atk child if
2870         it knows its parent. This solves the bulk of the cases. For those it
2871         doesn't, fall back to the existing logic.
2872
2873         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2874         (webkit_accessible_get_parent):
2875         (webkit_accessible_ref_child):
2876
2877 2009-10-20  Brian Weinstein  <bweinstein@apple.com>
2878
2879         Reviewed by Alice Liu.
2880
2881         Fixes <http://webkit.org/b/30421>.
2882         Web Inpsector: Local Files can show up on Cookies List with Cookies from other Domain.
2883
2884         When a page like Google generates an about:blank, it shows up as a local file on
2885         the list of Cookie domains, but has all of the cookies of Google. When we are adding
2886         cookie domains to the inspector, we should only add the domain is the URL of the resource
2887         is in the HTTP protocol family or a file URL.
2888
2889         * inspector/InspectorController.cpp:
2890         (WebCore::InspectorController::populateScriptObjects):
2891         (WebCore::InspectorController::didFinishLoading):
2892
2893 2009-10-20  Mark Mentovai  <mark@chromium.org>
2894
2895         Reviewed by Darin Fisher.
2896
2897         Use a version of libWebKitSystemInterface with global symbols marked
2898         private_extern for Chromium Mac.
2899
2900         https://bugs.webkit.org/show_bug.cgi?id=30590
2901
2902         * WebCore.gyp/WebCore.gyp:
2903         * WebCore.gyp/mac: Added.
2904         * WebCore.gyp/mac/Empty.cpp: Added.
2905         * WebCore.gyp/mac/adjust_visibility.sh: Added.
2906
2907 2009-10-20  Zoltan Horvath  <zoltan@webkit.org>
2908
2909         Reviewed by Eric Seidel.
2910
2911         Allow custom memory allocation control for WebCore's CSSProperty
2912         https://bugs.webkit.org/show_bug.cgi?id=30564
2913
2914         Inherits CSSProperty class from FastAllocBase because it has been
2915         instantiated by 'new' in WebCore/css/CSSParser.cpp:367.
2916
2917         * css/CSSProperty.h:
2918
2919 2009-10-20  Andrew Scherkus  <scherkus@chromium.org>
2920
2921         Reviewed by Eric Seidel.
2922
2923         Hide Chromium's media slider thumb if no source has been loaded.
2924
2925         https://bugs.webkit.org/show_bug.cgi?id=30529
2926
2927         Covered by existing layout tests, notably:
2928             LayoutTests/media/controls-rendering.html
2929             LayoutTests/media/unsupported-tracks.html
2930             LayoutTests/media/video-src-none.html
2931
2932         * rendering/RenderMediaControlsChromium.cpp:
2933         (WebCore::hasSource): Returns true if an HTMLMediaElement has a valid source set.
2934         (WebCore::paintMediaMuteButton): Refactored to use hasSource().
2935         (WebCore::paintMediaPlayButton): Ditto.
2936         (WebCore::paintMediaSliderThumb): Add call to hasSource() to determine if we should paint the thumb.
2937
2938 2009-10-20  Nate Chapin  <japhet@chromium.org>
2939
2940         Reviewed by Adam Barth.
2941
2942         Added getter for FrameLoader:m_suppressOpenerInNewFrame.
2943         This will allow Chromium to more intelligently detect
2944         noreferrer links and therefore open them in a new process.
2945
2946         https://bugs.webkit.org/show_bug.cgi?id=30581
2947
2948         * loader/FrameLoader.h:
2949         (WebCore::FrameLoader::suppressOpenerInNewFrame): Added.
2950
2951 2009-10-20  Zoltan Horvath  <zoltan@webkit.org>
2952
2953         Reviewed by Darin Adler.
2954
2955         Allow custom memory allocation control for WebCore's CSSParserFunction
2956         https://bugs.webkit.org/show_bug.cgi?id=30563
2957
2958         Inherits CSSParserFunction struct from FastAllocBase because it has been
2959         instantiated by 'new' in WebCore/css/CSSParser.cpp:4827.
2960
2961         * css/CSSProperty.h:
2962
2963 2009-10-20  Joseph Pecoraro  <joepeck@webkit.org>
2964
2965         Reviewed by Timothy Hatcher.
2966
2967         Web Inspector: Watched Expressions Buttons Do Not Match Inspector Styles
2968         https://bugs.webkit.org/show_bug.cgi?id=30554
2969
2970         * inspector/front-end/inspector.css: added style to pane buttons
2971
2972 2009-10-20  Yury Semikhatsky  <yurys@chromium.org>
2973
2974         Reviewed by Pavel Feldman.
2975
2976         Set debug id for contexts of isolated worlds to distinguish them in debugger.
2977
2978         https://bugs.webkit.org/show_bug.cgi?id=30559
2979
2980         * bindings/v8/V8Proxy.cpp:
2981         (WebCore::V8Proxy::evaluateInIsolatedWorld):
2982         (WebCore::V8Proxy::evaluateInNewContext):
2983         (WebCore::V8Proxy::setInjectedScriptContextDebugId):
2984         * bindings/v8/V8Proxy.h:
2985
2986 2009-10-20  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2987
2988         Unreviewed buildfix.
2989         [Qt] Add FEGaussianBlur.h and FEGaussianBlur.cpp which were refactored in r49778 to WebCore.pro.
2990
2991         * WebCore.pro:
2992
2993 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2994
2995         Reviewed by David Levin.
2996
2997         Set EnabledAtRuntime for WebSocket in DOMWindow
2998         https://bugs.webkit.org/show_bug.cgi?id=29896
2999
3000         Supported by chromium/v8 only.
3001         Add WebSocket::isAvailable()/setIsAvailable(bool) to control v8
3002         bindings.
3003         Remove Settings::experimentalWebSocketsEnabled() and
3004         setExperimentalWebSocketsEnabled(bool).
3005
3006         * WebCore.base.exp:
3007         * bindings/js/JSDOMWindowCustom.cpp:
3008         (WebCore::JSDOMWindow::webSocket):
3009         * bindings/v8/V8DOMWrapper.cpp:
3010         (WebCore::V8DOMWrapper::getConstructor):
3011         * bindings/v8/custom/V8CustomBinding.h:
3012         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3013         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3014         * page/DOMWindow.idl:
3015         * page/Settings.cpp:
3016         (WebCore::Settings::Settings):
3017         * page/Settings.h:
3018         * websockets/WebSocket.cpp:
3019         (WebCore::WebSocket::setIsAvailable):
3020         (WebCore::WebSocket::isAvailable):
3021         * websockets/WebSocket.h:
3022
3023 2009-10-19  Oliver Hunt  <oliver@apple.com>
3024
3025         Reviewed by Sam Weinig.
3026
3027         REGRESSION: Dromaeo DOM test is 14% slower
3028         https://bugs.webkit.org/show_bug.cgi?id=30273
3029
3030         Whoops, make prototype bindings actually use the StructureFlags.
3031
3032         * bindings/scripts/CodeGeneratorJS.pm:
3033
3034 2009-10-19  James Robinson  <jamesr@chromium.org>
3035
3036         Reviewed by Adam Barth.
3037
3038         Better implementation of WebCore::ScriptString for the V8 bindings.
3039
3040         https://bugs.webkit.org/show_bug.cgi?id=29909
3041
3042         WebCore::ScriptString is used for XMLHttpRequest's responseText attribute which is
3043         shared with JavaScript.  Thus, simply using a WebCore::String and copying the value
3044         is pretty inefficient, especially since responseText is built up with a sequence of
3045         operator+= calls.  JSC builds use a JSC::UString to share the buffer when possible,
3046         this patch adopts a similar approach for V8.
3047
3048         No new tests, behavior is unchanged and covered by LayoutTests/http/tests/xmlhttprequest
3049
3050         * WebCore.gypi:
3051         * bindings/v8/ScriptString.h:
3052         (WebCore::ScriptString::ScriptString):
3053         (WebCore::ScriptString::operator String):
3054         (WebCore::ScriptString::isNull):
3055         (WebCore::ScriptString::size):
3056         (WebCore::ScriptString::operator=):
3057         (WebCore::ScriptString::operator+=):
3058         (WebCore::ScriptString::v8StringOrNull):
3059         * bindings/v8/ScriptStringImpl.cpp: Added.
3060         (WebCore::ScriptStringImpl::ScriptStringImpl):
3061         (WebCore::ScriptStringImpl::~ScriptStringImpl):
3062         (WebCore::ScriptStringImpl::toString):
3063         (WebCore::ScriptStringImpl::isNull):
3064         (WebCore::ScriptStringImpl::size):
3065         (WebCore::ScriptStringImpl::append):
3066         * bindings/v8/ScriptStringImpl.h: Added.
3067         (WebCore::ScriptStringImpl::ScriptStringImpl):
3068         (WebCore::ScriptStringImpl::v8StringHandle):
3069         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
3070         (WebCore::ACCESSOR_GETTER):
3071
3072 2009-10-19  Adam Barth  <abarth@webkit.org>
3073
3074         No review, rolling out r49837.
3075         http://trac.webkit.org/changeset/49837
3076
3077         * page/Settings.cpp:
3078         (WebCore::Settings::setStandardFontFamily):
3079         (WebCore::Settings::setFixedFontFamily):
3080         (WebCore::Settings::setSerifFontFamily):
3081         (WebCore::Settings::setSansSerifFontFamily):
3082         (WebCore::Settings::setCursiveFontFamily):
3083         (WebCore::Settings::setFantasyFontFamily):
3084         * page/Settings.h:
3085         (WebCore::Settings::standardFontFamily):
3086         (WebCore::Settings::fixedFontFamily):
3087         (WebCore::Settings::serifFontFamily):
3088         (WebCore::Settings::sansSerifFontFamily):
3089         (WebCore::Settings::cursiveFontFamily):
3090         (WebCore::Settings::fantasyFontFamily):
3091         * platform/text/UScriptCode.h: Removed.
3092
3093 2009-10-19  Kwang Yul Seo  <skyul@company100.net>
3094
3095         Reviewed by Eric Seidel.
3096
3097         Check COMPILER(MSVC) instead of PLATFORM(WIN_OS) to avoid the use of vasprintf.
3098         https://bugs.webkit.org/show_bug.cgi?id=30473
3099
3100         vasprintf is missing in MSVC. Use COMPILER(MSVC) guards instead of
3101         PLALTFORM(WIN_OS) guards.
3102
3103         * dom/XMLTokenizerLibxml2.cpp:
3104         (WebCore::XMLTokenizer::error):
3105
3106 2009-10-19  Jungshik Shin  <jshin@chromium.org>
3107
3108         Reviewed by Eric Seidel.
3109
3110         https://bugs.webkit.org/show_bug.cgi?id=20797
3111
3112         Make generic font family getters/setters accept an additional
3113         argument (script code). It has a default value so that if an embedder
3114         does not have/want a per-script font family setting, call-sites
3115         don't have to be changed.
3116         This is to prepare for fixing bug 10874 (font selection is not
3117         language-dependent) and bug 18085.
3118
3119         There should be no change in layout and no new layout test
3120         is added.
3121
3122         * WebCore.base.exp:
3123         * page/Settings.cpp:
3124         * page/Settings.h:
3125         * platform/text/UScriptCode.h: Added. This is for ports that
3126           do not use ICU. the part of ICU's common/unicode/uscript.h
3127           that defines script code enum was copied. To keep enums compatible
3128           with those in ICU, we don't generate the list out of Scripts.txt
3129           of the Unicode Data base or CLDR's data.
3130
3131 2009-10-19  Evan Stade  <estade@chromium.org>
3132
3133         Reviewed by Darin Adler.
3134
3135         Clarify usage of SuddenTermination API. No code change.
3136
3137         * platform/SuddenTermination.h:
3138
3139 2009-10-19  Oliver Hunt  <oliver@apple.com>
3140
3141         Reviewed by Gavin Barraclough.
3142
3143         REGRESSION: Dromaeo DOM test is 14% slower
3144         https://bugs.webkit.org/show_bug.cgi?id=30273
3145
3146         Make DOM bindings automatically inherit correct structure
3147         flags rather than being needlessly conservative.  This is
3148         done by making the bindings generator use the same model
3149         for TypeInfo flags that we now use in JSC.
3150
3151         This gains us about 1% of this regression back.
3152
3153         * bindings/js/JSDOMBinding.h:
3154         (WebCore::DOMObjectWithGlobalPointer::createStructure):
3155         (WebCore::DOMConstructorObject::createStructure):
3156         * bindings/js/JSDOMWindowShell.h:
3157         (WebCore::JSDOMWindowShell::createStructure):
3158         * bindings/js/JSHTMLAllCollection.h:
3159         (WebCore::JSHTMLAllCollection::createStructure):
3160         * bindings/js/JSQuarantinedObjectWrapper.h:
3161         (WebCore::JSQuarantinedObjectWrapper::createStructure):
3162         * bindings/scripts/CodeGeneratorJS.pm:
3163         * bridge/objc/objc_runtime.h:
3164         (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
3165         * bridge/runtime_array.h:
3166         (JSC::RuntimeArray::createStructure):
3167         * bridge/runtime_method.h:
3168         (JSC::RuntimeMethod::createStructure):
3169         * bridge/runtime_object.h:
3170         (JSC::RuntimeObjectImp::createStructure):
3171
3172 2009-10-19  Robin Qiu  <robin.qiu@torchmobile.com.cn>
3173
3174         Reviewed by Nikolas Zimmermann.
3175
3176         Fixed a bug on nested SVG <use> elements.
3177         https://bugs.webkit.org/show_bug.cgi?id=26117
3178         When a <use> element refer to another <use> element which has
3179         child/children, the instance tree built for this <use> element
3180         is incorrect (more nodes than expected).
3181
3182         Test: svg/dom/use-on-use-with-child.svg
3183
3184         * svg/SVGUseElement.cpp:
3185         (WebCore::SVGUseElement::buildInstanceTree):
3186
3187 2009-10-19  Oliver Hunt  <oliver@apple.com>
3188
3189         Small changes to fully invalidate and update the JavaScriptCallFrame.
3190
3191         <rdar://problem/7020755> JSDebugger crashes after reloading from a breakpoint
3192         https://bugs.webkit.org/show_bug.cgi?id=27146
3193
3194         Reviewed by Timothy Hatcher.
3195
3196         * inspector/JavaScriptCallFrame.h:
3197         (WebCore::JavaScriptCallFrame::invalidate):
3198         (WebCore::JavaScriptCallFrame::update):
3199
3200 2009-10-19  Jeremy Orlow  <jorlow@chromium.org>
3201
3202         Reviewed by Dmitri Titov.
3203
3204         Remove "source" from storage events
3205         https://bugs.webkit.org/show_bug.cgi?id=30536
3206
3207         Remove "source" from storage events per
3208         http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html
3209
3210         This was removed because it makes it introduces synchronous access that can
3211         cross the event loop boundry (since a storage event can fire from one process
3212         and be handled in another).
3213
3214         * inspector/InspectorDOMStorageResource.cpp:
3215         (WebCore::InspectorDOMStorageResource::handleEvent):
3216         * storage/StorageEvent.cpp:
3217         (WebCore::StorageEvent::create):
3218         (WebCore::StorageEvent::StorageEvent):
3219         (WebCore::StorageEvent::initStorageEvent):
3220         * storage/StorageEvent.h:
3221         (WebCore::StorageEvent::uri):
3222         * storage/StorageEvent.idl:
3223         * storage/StorageEventDispatcher.cpp:
3224         (WebCore::StorageEventDispatcher::dispatch):
3225
3226 2009-10-19  Adam Barth  <abarth@webkit.org>
3227
3228         Reviewed by Eric Seidel.
3229
3230         Remove ResourceLoadNotifier::activeDocumentLoader
3231         https://bugs.webkit.org/show_bug.cgi?id=30533
3232
3233         Removing this method from ResourceLoadNotifier better decouples the
3234         notifier from FrameLoader.
3235
3236         * loader/FrameLoader.cpp:
3237         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
3238         (WebCore::FrameLoader::requestFromDelegate):
3239         * loader/ResourceLoadNotifier.cpp:
3240         (WebCore::ResourceLoadNotifier::didReceiveResponse):
3241         * loader/ResourceLoadNotifier.h:
3242         * loader/ResourceLoader.cpp:
3243         (WebCore::ResourceLoader::willSendRequest):
3244
3245 2009-10-19  Adam Barth  <abarth@webkit.org>
3246
3247         Reviewed by Eric Seidel.
3248
3249         Move sendRemainingDelegateMessages to ResourceLoadNotifier
3250         https://bugs.webkit.org/show_bug.cgi?id=30531
3251
3252         This method is about notifying folks and doesn't interact with the rest
3253         of FrameLoader.
3254
3255         * loader/FrameLoader.cpp:
3256         (WebCore::FrameLoader::willLoadMediaElementURL):
3257         (WebCore::FrameLoader::commitProvisionalLoad):
3258         (WebCore::FrameLoader::loadResourceSynchronously):
3259         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
3260         * loader/FrameLoader.h:
3261         * loader/ResourceLoadNotifier.cpp:
3262         (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
3263         * loader/ResourceLoadNotifier.h:
3264
3265 2009-10-19  Adam Barth  <abarth@webkit.org>
3266
3267         Reviewed by Eric Seidel.
3268
3269         Bypass popup blocker using click event
3270         https://bugs.webkit.org/show_bug.cgi?id=21501
3271
3272         Keep track of which events were generated by JavaScript and use that
3273         inforation when figuring out if we're processing a user gesture.
3274
3275         Test: http/tests/security/popup-blocked-from-fake-event.html
3276
3277         * bindings/js/ScriptController.cpp:
3278         (WebCore::ScriptController::processingUserGestureEvent):
3279         * bindings/v8/ScriptController.cpp:
3280         (WebCore::ScriptController::processingUserGesture):
3281         * dom/Document.cpp:
3282         (WebCore::Document::createEvent):
3283         * dom/Event.cpp:
3284         (WebCore::Event::Event):
3285         * dom/Event.h:
3286         (WebCore::Event::createdByDOM):
3287         (WebCore::Event::setCreatedByDOM):
3288
3289 2009-10-19  Dumitru Daniliuc  <dumi@chromium.org>
3290
3291         Reviewed by Darin Adler.
3292
3293         Fixing a typo.
3294
3295         https://bugs.webkit.org/show_bug.cgi?id=30543
3296
3297         * platform/sql/SQLiteDatabase.h:
3298
3299 2009-10-19  Dmitry Titov  <dimich@chromium.org>
3300
3301         Reviewed by Darin Adler.
3302
3303         Manual Test for crash caused by JS accessing DOMWindow which is disconnected from the Frame.
3304         https://bugs.webkit.org/show_bug.cgi?id=30544
3305
3306         * manual-tests/crash-on-accessing-domwindow-without-frame.html: Added.
3307
3308 2009-10-19  Simon Fraser  <simon.fraser@apple.com>
3309
3310         Reviewed by Darin Adler.
3311
3312         Flash at end of opacity/transform transition sometimes
3313         https://bugs.webkit.org/show_bug.cgi?id=30501
3314
3315         When a transition finishes, there window of time between when the animation is
3316         removed, and the final style set on the GraphicsLayer. This caused the layer to revert
3317         to its old appearance for one or two frames. To avoid this, we set the final
3318         transform or opacity at the start of the transition; we know that the animation
3319         will override the final value for as long as its running.
3320
3321         No test because this is a very transient effect that can't be captured
3322         in a test.
3323
3324         * rendering/RenderLayerBacking.cpp:
3325         (WebCore::RenderLayerBacking::createGraphicsLayer):
3326         (WebCore::RenderLayerBacking::updateLayerOpacity):
3327         (WebCore::RenderLayerBacking::updateLayerTransform):
3328         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
3329         (WebCore::RenderLayerBacking::startTransition):
3330         * rendering/RenderLayerBacking.h:
3331
3332 2009-10-19  Pavel Feldman  <pfeldman@chromium.org>
3333
3334         Reviewed by Timothy Hatcher.
3335
3336         Web Inspector: Add more stop characters into console completions.
3337
3338         https://bugs.webkit.org/show_bug.cgi?id=30477
3339
3340         * inspector/front-end/ConsoleView.js:
3341         (WebInspector.ConsoleView.prototype.completions):
3342         (WebInspector.ConsoleView.prototype._reportCompletions):
3343
3344 2009-10-19  Marshall Culpepper  <mculpepper@appcelerator.com>
3345
3346         Reviewed by Adam Roben.
3347
3348         implemented ClipboardWin::files()
3349         https://bugs.webkit.org/show_bug.cgi?id=29666
3350
3351         * platform/win/ClipboardWin.cpp:
3352         (WebCore::ClipboardWin::files):
3353
3354 2009-10-19  Nate Chapin  <japhet@chromium.org>
3355
3356         Reviewed by Alexey Proskuryakov.
3357
3358         Add support for link relations in HTMLAnchorElement and implement rel="noreferrer".
3359
3360         https://bugs.webkit.org/show_bug.cgi?id=28986
3361
3362         Tests: http/tests/navigation/no-referrer-reset.html
3363                http/tests/navigation/no-referrer-same-window.html
3364                http/tests/navigation/no-referrer-subframe.html
3365                http/tests/navigation/no-referrer-target-blank.html
3366
3367         * WebCore.base.exp: Update FrameLoader::loadFrameRequest export symbol
3368         * html/HTMLAnchorElement.cpp: Add support for link relations and implement noreferrer
3369         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
3370         (WebCore::HTMLAnchorElement::defaultEventHandler):
3371         (WebCore::HTMLAnchorElement::parseMappedAttribute):
3372         (WebCore::HTMLAnchorElement::hasRel):
3373         (WebCore::HTMLAnchorElement::setRel):
3374         * html/HTMLAnchorElement.h: Add support for link relations and implement noreferrer
3375         * loader/FrameLoader.cpp:
3376         (WebCore::FrameLoader::FrameLoader):
3377         (WebCore::FrameLoader::createWindow):
3378         (WebCore::FrameLoader::changeLocation):
3379         (WebCore::FrameLoader::urlSelected): Add parameter for referrer policy
3380         (WebCore::FrameLoader::loadFrameRequest): Add parameter for referrer policy
3381         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Suppress opener if requested by ReferrerPolicy
3382         * loader/FrameLoader.h: Update urlSelected and loadFrameRequest prototypes
3383         * loader/FrameLoaderTypes.h: Add enum for referrer policy
3384         * loader/RedirectScheduler.cpp:
3385         (WebCore::RedirectScheduler::timerFired):
3386         * page/ContextMenuController.cpp:
3387         (WebCore::ContextMenuController::contextMenuItemSelected): Update call to urlSelected()
3388         * svg/SVGAElement.cpp:
3389         (WebCore::SVGAElement::defaultEventHandler): Update call to urlSelected()
3390
3391
3392 2009-10-19  Alpha Lam  <hclam@chromium.org>
3393
3394         Reviewed by Dimitri Glazkov (dglazkov@chromium.org).
3395
3396         [v8] typeof(HTMLMediaElement) should return undefined if media
3397         engine is not available
3398         https://bugs.webkit.org/show_bug.cgi?id=30343
3399
3400         Check for availability of the media engine to disable
3401         HTMLMediaElement, HTMLAudioElement, HTMLVideoElement, MediaError
3402         in runtime.
3403
3404         Try runs and review in Chromium:
3405         http://codereview.chromium.org/276011
3406
3407         Test: manual-tests/chromium/media-player-not-available.html
3408
3409         The above test can work work in Chromium. Testing procedures:
3410         1. Remove all media support libraries in Chromium (e.g. ffmpeg libraries)
3411         2. Open Chromium with above test page
3412         3. Verify the test results according to the test page
3413
3414         * bindings/v8/custom/V8CustomBinding.h:
3415         Declare enabler methods.
3416         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3417         Report enabled only if media player is available.
3418         * manual-tests/chromium/media-player-not-available.html: Added.
3419         Manual test, following instruction in this test for procedures.
3420         * page/DOMWindow.idl:
3421         Mark HTMLMediaElement, HTMLAudioElement, HTMLVideElement, MediaError
3422         as enabled at runtime.
3423
3424 2009-10-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3425
3426         Reviewed by David Hyatt.
3427
3428         Refactor out some of the code in paint() into paintPanScrollIcon()
3429         and paintScrollbars() in preparation of some Qt API changes.
3430
3431         * platform/ScrollView.cpp:
3432         (WebCore::ScrollView::paint):
3433         * platform/ScrollView.h:
3434
3435 2009-10-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3436
3437         Reviewed by Adam Roben.
3438
3439         Make the local static panScrollIcon into a Image* instead
3440         of a RefPtr<Image>.
3441
3442         * platform/ScrollView.cpp:
3443         (WebCore::ScrollView::wheelEvent):
3444
3445 2009-10-19  Andrew Scherkus  <scherkus@chromium.org>
3446
3447         Reviewed by David Levin.
3448
3449         Forcefully set antialiasing for Chromium media controls.
3450
3451         https://bugs.webkit.org/show_bug.cgi?id=30521
3452
3453         Before it was nondeterministiacally being enabled based on the previous state of GraphicsContext.
3454
3455         Covered by existing layout tests.
3456
3457         * rendering/RenderMediaControlsChromium.cpp:
3458         (WebCore::paintMediaSlider): Added setShouldAntialias(true).
3459
3460 2009-10-19  Jens Alfke  <jens@mooseyard.com>
3461
3462         Reviewed by Darin Adler.
3463
3464         Optimize string upper/lowercasing
3465         https://bugs.webkit.org/show_bug.cgi?id=30261
3466
3467         - Added AtomicString::upper() and lower()
3468         - Further optimized StringImpl::lower()
3469         - Removed StringImpl::isLower()
3470         - Added QualifiedName::localNameUpper(), which is cached, thereby saving
3471           thousands of upper() calls and string allocations.
3472
3473          * dom/Element.cpp:
3474          (WebCore::Element::setAttribute): Call AtomicString::lower()
3475          * dom/QualifiedName.cpp:
3476          (WebCore::QualifiedName::localNameUpper): New method
3477          * dom/QualifiedName.h: Added localNameUpper() method
3478          * dom/StyledElement.cpp:
3479          (WebCore::StyledElement::parseMappedAttribute):  Call AtomicString::lower()
3480          * html/HTMLDocument.cpp:
3481          (WebCore::HTMLDocument::createElement): Call AtomicString::lower()
3482          * html/HTMLElement.cpp:
3483          (WebCore::HTMLElement::nodeName): Call localNameUpper()
3484          * platform/text/AtomicString.cpp:
3485          (WebCore::AtomicString::lower): New method
3486          (WebCore::AtomicString::upper): New method
3487          * platform/text/AtomicString.h: Added lower() and upper()
3488          * platform/text/StringImpl.cpp: Removed isLower()
3489          (WebCore::StringImpl::lower): Further optimization of initial loop
3490          * platform/text/StringImpl.h: Removed isLower()
3491
3492 2009-10-19  Nate Chapin  <japhet@chromium.org>
3493
3494         Reviewed by Adam Barth.
3495
3496         If a call to a plugin's invokeMethod, invokeDefault or construct
3497         returns false, throw an exception into JS.
3498
3499         https://bugs.webkit.org/show_bug.cgi?id=30239
3500
3501         Test: plugins/netscape-invoke-failure.html
3502
3503         * bindings/v8/V8NPObject.cpp: Check return values of invokeMethod, invokeDefault and construct.
3504         (npObjectInvokeImpl):
3505         * bridge/c/c_instance.cpp:
3506         (JSC::Bindings::CInstance::invokeMethod): Check return value
3507         (JSC::Bindings::CInstance::invokeDefaultMethod): Check return value
3508         (JSC::Bindings::CInstance::invokeConstruct): Check return value
3509
3510 2009-10-16  Stephen White  <senorblanco@chromium.org>
3511
3512         Reviewed by Adam Barth.
3513
3514         Fix for chromium/skia canvas arc start/end positions, when the arc is
3515         >= 360 degrees.
3516         https://bugs.webkit.org/show_bug.cgi?id=30449
3517
3518         Covered by new test:
3519         LayoutTests/fast/canvas/arc360.html
3520
3521         * platform/graphics/skia/PathSkia.cpp:
3522         (WebCore::Path::addArc):
3523
3524 2009-10-19  Kent Tamura  <tkent@chromium.org>
3525
3526         Reviewed by Alexey Proskuryakov.
3527
3528         Fix uninitialized variable reference in Element::removeAttribute().
3529         https://bugs.webkit.org/show_bug.cgi?id=30502
3530
3531         * dom/Element.cpp:
3532         (WebCore::Element::removeAttribute):
3533
3534 2009-10-19  Eric Carlson  <eric.carlson@apple.com>
3535
3536         Reviewed by Simon Fraser.
3537
3538         https://bugs.webkit.org/show_bug.cgi?id=30463
3539         Remove HTML5 media element 'loadend' event
3540
3541         * dom/EventNames.h:
3542         * html/HTMLMediaElement.cpp:
3543         (WebCore::HTMLMediaElement::parseMappedAttribute): Remove 'loadend'.
3544         (WebCore::HTMLMediaElement::loadInternal): Ditto.
3545         (WebCore::HTMLMediaElement::noneSupported): Ditto.
3546         (WebCore::HTMLMediaElement::mediaEngineError): Ditto.
3547         (WebCore::HTMLMediaElement::setNetworkState): Ditto.
3548         (WebCore::HTMLMediaElement::userCancelledLoad): Ditto.
3549
3550 2009-10-19  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3551
3552         Reviewed by Adam Barth.
3553
3554         [Qt] Remove deletion of outgoing FormData object when reply is finished.
3555         The buffers will be destroyed a bit later, when the QNetworkReply is deleted.
3556         Bug: https://bugs.webkit.org/show_bug.cgi?id=29551
3557
3558         * platform/network/qt/QNetworkReplyHandler.cpp:
3559         * platform/network/qt/QNetworkReplyHandler.h:
3560
3561 2009-10-19  Dimitri Glazkov  <dglazkov@chromium.org>
3562
3563         Reviewed by Darin Adler.
3564
3565         Fix hard-to-reproduce crash in HTMLTokenizer by avoiding a rare
3566         fastRealloc edge case.
3567         https://bugs.webkit.org/show_bug.cgi?id=29313
3568
3569         No test, the crash shows up occasionally in crash dumps, we weren't able
3570         to reproduce it locally.
3571
3572         * html/HTMLTokenizer.cpp:
3573         (WebCore::HTMLTokenizer::enlargeScriptBuffer): Added an early exit to
3574             avoid calling fastRealloc with the size of 0.
3575
3576 2009-10-19  Andrew Scherkus  <scherkus@chromium.org>
3577
3578         Reviewed by Eric Seidel.
3579
3580         Use fillRect() instead of drawRect() to fix Chromium media controls rendering.
3581
3582         https://bugs.webkit.org/show_bug.cgi?id=30371
3583
3584         Chromium Mac layout tests will need to be rebaselined.  Existing layout tests for Linux/Win still pass.
3585
3586         * rendering/RenderMediaControlsChromium.cpp:
3587         (WebCore::paintMediaSlider): Use fillRect() instead of drawRect().
3588
3589 2009-10-19  Dmitry Titov  <dimich@chromium.org>
3590
3591         Reviewed by Adam Barth.
3592
3593         Crash in DOMWindow::clearTimeout etc when DOMWindow is not connected to a frame.
3594         https://bugs.webkit.org/show_bug.cgi?id=29832
3595
3596         Need to make sure the script caches are reset when frame gets disconnected from still-alive DOMWindow.
3597         This will prevent JS from calling DOMWindow methods that can not be completed w/o the frame.
3598
3599         I am not sure it's possible to test this since the only file that repros the problem need ~10 seconds to cause crash.
3600
3601         * page/Frame.cpp:
3602         (WebCore::Frame::~Frame): Right after frame disconnects from DOMWindow, clear WindowShell.
3603
3604 2009-10-19  Csaba Osztrogonác  <ossy@webkit.org>
3605
3606         Unreviewed build warning fix.
3607         [Qt] Apply changes to WebCore.pro introduced in r49778
3608
3609         * WebCore.pro: Removed svg/graphics/filters/SVGFEGaussianBlur.h from HEADERS
3610
3611 2009-10-19  Dirk Schulze  <krit@webkit.org>
3612
3613         Reviewed by Darin Adler.
3614
3615         Move feGaussianBlur from WebCore/svg to WebCore/platform