bcea395140a10c43984f501bfc7d1286ebff2ce7
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2
3         Reviewed by Jan Alonzo.
4
5         https://bugs.webkit.org/show_bug.cgi?id=31047
6         [GTK] Failing test media/video-played-ranges-1.html
7
8         Fix playback rate setter by remembering the rate was changed. Also
9         correctly handle reverse playback by doing a seek from end to
10         beginning of the media.
11
12         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
13         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
14         (WebCore::MediaPlayerPrivate::currentTime):
15         (WebCore::MediaPlayerPrivate::seek):
16         (WebCore::MediaPlayerPrivate::hasAudio):
17         (WebCore::MediaPlayerPrivate::setVolume):
18         (WebCore::MediaPlayerPrivate::setRate):
19         (WebCore::MediaPlayerPrivate::updateStates):
20         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
21
22 2009-11-10  Oliver Hunt  <oliver@apple.com>
23
24         Reviewed by Maciej Stachowiak.
25
26         Rename 3D Canvas related classes to use WebGL prefix
27         https://bugs.webkit.org/show_bug.cgi?id=29095
28
29         Automatic rename of all WebGL related types from Canvas* to
30         WebGL* per more recent version of the WebGL spec.
31
32         Due to the automatic rename I've removed the 600+ line change list.
33
34 2009-11-09  Dirk Schulze  <krit@webkit.org>
35
36         Reviewed by Oliver Hunt.
37
38         SVG feDisplacementMap is not implemented
39         [https://bugs.webkit.org/show_bug.cgi?id=31255]
40
41         This is the implementation of the SVG filter effect
42         feDisplacementMap. 
43
44         Test: svg/filters/feDisplacementMap.svg
45
46         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
47         (WebCore::FEDisplacementMap::apply):
48
49 2009-11-09  Kent Tamura  <tkent@chromium.org>
50
51         Reviewed by Darin Adler.
52
53         Add a comment about null strings and hash functions.
54         https://bugs.webkit.org/show_bug.cgi?id=29118
55
56         * platform/text/StringHash.h:
57
58 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
59
60         Reviewed by Darin Adler.
61
62         Compiler warnings in InspectorResource.h
63         https://bugs.webkit.org/show_bug.cgi?id=29231
64
65         Fix compilation warnings by removing addition operation on an enum type.
66
67         * inspector/InspectorResource.h:
68         (WebCore::InspectorResource::):
69         (WebCore::InspectorResource::Changes::hasChange):
70         (WebCore::InspectorResource::Changes::set):
71         (WebCore::InspectorResource::Changes::setAll):
72
73 2009-11-09  Anders Carlsson  <andersca@apple.com>
74
75         Reviewed by Darin Adler and Dan Bernstein.
76
77         <rdar://problem/7328395>
78         https://bugs.webkit.org/show_bug.cgi?id=31277
79
80         When an object tag's style changes (for example when child nodes are added/removed),
81         reuse its Frame (if it has one) instead of creating multiple Frames.
82
83         Test: fast/dom/HTMLObjectElement/children-changed.html
84
85         * loader/FrameLoader.cpp:
86         (WebCore::FrameLoader::requestObject):
87
88 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
89
90         Reviewed by Kenneth Rohde Christiansen.
91
92         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
93         since adjustment of RW-section base address will be needed for all new symbian
94         tool chains, specifically for arm and gcc compilation targets.
95         Also, change target address to 0xE00000 to be sufficient for all targets.
96
97         * WebCore.pro:
98
99 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
100
101         Reviewed by Timothy Hatcher.
102
103         Web Inspector: Crash when inspecting
104         WebCore\manual-tests\inspector\dom-mutation.html
105
106         https://bugs.webkit.org/show_bug.cgi?id=31259
107
108         * inspector/InspectorDOMAgent.cpp:
109         (WebCore::InspectorDOMAgent::handleEvent):
110
111 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
112
113         Reviewed by Kenneth Rohde Christiansen.
114
115         [Qt] Few classes have virtual functions but non-virtual destructor
116         https://bugs.webkit.org/show_bug.cgi?id=31269
117
118         No new tests as there is no functional change.
119
120         * platform/qt/QWebPageClient.h:
121         (QWebPageClient::~QWebPageClient): Add virtual destructor.
122
123 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
124
125         Reviewed by Kenneth Rohde Christiansen.
126
127         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
128         https://bugs.webkit.org/show_bug.cgi?id=31140
129
130         QtNetwork interprets null string as request to remove the header, not add it.
131         Replace null values with empty values before passing them to QtNetwork.
132
133         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
134
135         * platform/network/qt/ResourceRequestQt.cpp:
136         (WebCore::ResourceRequest::toNetworkRequest):
137
138 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
139
140         Reviewed by Kevin Ollivier.
141
142         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
143         simply ignored before resulting in transparent areas being black in PNG
144         images for example.
145         
146         https://bugs.webkit.org/show_bug.cgi?id=30823
147
148         * platform/image-decoders/wx/ImageDecoderWx.cpp:
149         (WebCore::RGBA32Buffer::asNewNativeImage):
150
151 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
152
153         Reviewed by Kenneth Rohde Christiansen.
154
155         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
156         https://bugs.webkit.org/show_bug.cgi?id=31040
157
158         No new tests as there is no functional change.
159
160         * dom/Document.cpp:
161         (WebCore::Document::recalcStyleSelector):
162         * editing/TextIterator.cpp:
163         (WebCore::pushFullyClippedState):
164         * editing/VisibleSelection.cpp:
165         (WebCore::VisibleSelection::appendTrailingWhitespace):
166         * html/HTMLLinkElement.cpp:
167         (WebCore::HTMLLinkElement::process):
168         * loader/RedirectScheduler.cpp:
169         (WebCore::RedirectScheduler::mustLockBackForwardList):
170         * loader/appcache/ApplicationCacheGroup.cpp:
171         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
172         * platform/graphics/qt/FontCacheQt.cpp:
173         (WebCore::FontPlatformDataCacheKey::computeHash):
174         * rendering/RenderBlock.cpp:
175         (WebCore::RenderBlock::handleRunInChild):
176         * rendering/RenderBox.cpp:
177         (WebCore::RenderBox::calcHeight):
178         * rendering/RenderTextControlMultiLine.cpp:
179         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
180         * rendering/style/RenderStyle.cpp:
181         (WebCore::RenderStyle::diff):
182         * svg/SVGAnimateElement.cpp:
183         (WebCore::parseNumberValueAndUnit):
184         * svg/SVGAnimationElement.cpp:
185         (WebCore::SVGAnimationElement::startedActiveInterval):
186         * svg/SVGPreserveAspectRatio.cpp:
187         (WebCore::SVGPreserveAspectRatio::getCTM):
188
189 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
190
191         Reviewed by Dimitri Glazkov.
192
193         Win chromium is slow to draw transparent texts
194         https://bugs.webkit.org/show_bug.cgi?id=31258
195
196         Clip graphics context to reduce calculation.
197
198         No new tests because this change only affects performance.
199
200         * platform/graphics/chromium/FontChromiumWin.cpp:
201         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
202         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
203
204 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
205
206         Reviewed by Darin Adler.
207
208         showTree(CounterNode*) generates too little info and has too many spaces.
209         https://bugs.webkit.org/show_bug.cgi?id=31212
210
211         No new tests as the change has no functional effect it is just for
212         improved debugging.
213
214         * rendering/CounterNode.cpp:
215         (WebCore::showTreeAndMark):
216         Changed to also show addresses of parent, next and previous
217         siblings.
218
219 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
220
221         Reviewed by Darin Adler.
222
223         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
224         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
225
226         https://bugs.webkit.org/show_bug.cgi?id=31083
227
228         No new tests; implementation is unchanged.
229
230         * page/Frame.cpp:
231         (WebCore::Frame::setUseSecureKeyboardEntry):
232         * page/mac/FrameMac.mm:
233
234 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
235
236         Reviewed by Jan Alonzo.
237
238         Make XP_UNIX tests consistent
239         https://bugs.webkit.org/show_bug.cgi?id=31250
240
241         No new tests as there is no functional change.
242
243         * plugins/PluginView.cpp:
244         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
245         instead of the value of the macro
246
247         * plugins/gtk/PluginViewGtk.cpp:
248         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
249         defined instead of using the PLATFORM macro to be consistent
250         (WebCore::PluginView::getValue): Ditto.
251
252 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
253
254         Reviewed by Darin Adler.
255
256         Thunk to the main thread from ~Database to deref Database's m_document.
257
258         If the Database was the Document's last referrer, then ~Document occurs on the
259         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
260         ASSERT in debug builds.
261
262         * storage/Database.cpp:
263         (WebCore::derefDocument):
264         (WebCore::Database::~Database):
265
266 2009-11-09  Mark Mentovai  <mark@chromium.org>
267
268         Reviewed by Dan Bernstein.
269
270         Track "can have scrollbar" state within FrameView independently of the
271         individual scrollbar states in ScrollView.
272
273         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
274         REGRESSION (r48064): mint.com loses scrollbars after coming out of
275         edit mode.
276
277         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
278         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
279
280         Test: fast/overflow/scrollbar-restored.html
281
282         * WebCore.base.exp:
283         * page/FrameView.cpp:
284         (WebCore::FrameView::FrameView):
285         (WebCore::FrameView::resetScrollbars):
286         (WebCore::FrameView::setCanHaveScrollbars):
287         (WebCore::FrameView::updateCanHaveScrollbars):
288         (WebCore::FrameView::layout):
289         * page/FrameView.h:
290         * platform/ScrollView.h:
291
292 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
293
294         Reviewed by Timothy Hatcher.
295
296         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
297         https://bugs.webkit.org/show_bug.cgi?id=31257
298
299         * inspector/front-end/SourceFrame.js:
300
301 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
302
303         Reviewed by Timothy Hatcher.
304
305         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
306         https://bugs.webkit.org/show_bug.cgi?id=31252
307
308         Route F1-F12 keypresses in the Console view to the current panel if there is one.
309
310         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
311
312         * inspector/front-end/ConsoleView.js:
313         (WebInspector.ConsoleView.prototype._promptKeyDown):
314         * inspector/front-end/utilities.js:
315         ():
316         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
317
318 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
319
320         Reviewed by Kenneth Rohde Christiansen.
321
322         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
323         https://bugs.webkit.org/show_bug.cgi?id=31208
324
325         After r42483, the credentials are no longer passed to the network request
326         in the URL of the request.
327         Pass the credentials from XMLHTTPRequest to the network request, the same
328         way that other ports do.
329
330         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
331
332         * platform/network/qt/ResourceHandleQt.cpp:
333         (WebCore::ResourceHandle::start):
334         (WebCore::ResourceHandle::loadResourceSynchronously):
335
336 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
337
338         Unreviewed.
339
340         https://bugs.webkit.org/show_bug.cgi?id=31161
341
342         Roll back r50657 because it breaks the MAC builds.
343
344         * loader/ImageLoader.cpp:
345         * loader/ProgressTracker.cpp:
346         * loader/RedirectScheduler.cpp:
347         * loader/Request.h:
348         * loader/ThreadableLoaderClient.h:
349         * loader/WorkerThreadableLoader.h:
350         * loader/appcache/ApplicationCacheHost.h:
351         * loader/appcache/ApplicationCacheStorage.h:
352         * loader/icon/IconDatabaseClient.h:
353
354 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
355
356         Reviewed by Darin Adler.
357
358         Allow custom memory allocation control for the part of loader directory in WebCore
359         https://bugs.webkit.org/show_bug.cgi?id=31161
360
361         Inherits the following classes from Noncopyable because these are instantiated
362         by 'new' and these are no need to be copyable:
363
364         class Request - WebCore/loader/loader.cpp:100
365         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
366         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
367         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
368         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
369         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
370         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
371
372         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
373         MainThreadBridge is instantiated by 'new' in 
374         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
375
376         ThreadableLoaderClient's inheriting has been changed to public.
377
378         * loader/ImageLoader.cpp:
379         * loader/ProgressTracker.cpp:
380         * loader/RedirectScheduler.cpp:
381         * loader/Request.h:
382         * loader/ThreadableLoaderClient.h:
383         * loader/WorkerThreadableLoader.h:
384         * loader/appcache/ApplicationCacheHost.h:
385         * loader/appcache/ApplicationCacheStorage.h:
386         * loader/icon/IconDatabaseClient.h:
387
388 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
389
390         Reviewed by Darin Adler.
391
392         Allow custom memory allocation control for WebCore's DocLoader
393         https://bugs.webkit.org/show_bug.cgi?id=31163
394
395         Inherits DocLoader class from Noncopyable because it is
396         instantiated by 'new' in WebCore/dom/Document.cpp:370 and 
397         it is no need to be copyable.
398
399         * loader/DocLoader.h:
400
401 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
402
403         Reviewed by Darin Adler.
404
405         Allow custom memory allocation control for WebCore's Tokenizer
406         https://bugs.webkit.org/show_bug.cgi?id=31162
407
408         Inherits Tokenizer class from Noncopyable because (its child class)
409         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178 
410         and it is no need to be copyable.
411
412         * dom/Tokenizer.h:
413
414 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
415
416         Reviewed by Darin Adler.
417
418         Allow custom memory allocation control for WebCore's DeleteButtonController
419         https://bugs.webkit.org/show_bug.cgi?id=31105
420
421         Inherits DeleteButtonController class from Noncopyable because it is 
422         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
423         it is no need to be copyable.  
424
425         * editing/DeleteButtonController.h:
426
427 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
428
429         Reviewed by Jan Alonzo.
430
431         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
432         https://bugs.webkit.org/show_bug.cgi?id=30482
433
434         Expose Page::tabKeyCyclesThroughElements as a property of
435         WebKitWebView.
436
437         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
438
439         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
440         (WebCore::singleCharacterString):
441
442 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
443
444         Reviewed by Xan Lopez.
445
446         https://bugs.webkit.org/show_bug.cgi?id=25415
447         [GTK][ATK] Please implement support for get_text_at_offset
448
449         Fix a crasher that occurred with text which included newline
450         chars in the markup.
451
452         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
453         (convertUniCharToUTF8):
454
455 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
456
457         Reviewed by Holger Freyther.
458
459         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
460         https://bugs.webkit.org/show_bug.cgi?id=31144
461
462         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
463         documents that end prematurely but are not considered invalid by QXmlStream.
464         This is to stay compatible with the libxml2 implementation.
465         However, that code path would be also hit in situations when it should not,
466         i.e. the error would have already been caught and handled. As a result, the
467         same error would be reported twice.
468
469         No new tests, because the problem is already covered by
470         fast/parser/xml-declaration-missing-ending-mark.html.
471
472         * dom/XMLTokenizerQt.cpp:
473         (WebCore::XMLTokenizer::doEnd):
474
475 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
476
477         Reviewed by Pavel Feldman.
478
479         Web Inspector: Inspector should support copy() in the command line
480         https://bugs.webkit.org/show_bug.cgi?id=31238
481
482         * inspector/InspectorBackend.cpp:
483         (WebCore::InspectorBackend::copyText): Added.
484         * inspector/InspectorBackend.h: Added copyText
485         * inspector/InspectorBackend.idl: Added copyText
486         * inspector/front-end/InjectedScript.js:
487         (InjectedScript._copy): Added.
488         (InjectedScript._ensureCommandLineAPIInstalled):
489
490 2009-11-08  Drew Wilson  <atwilson@chromium.org>
491
492         Reviewed by Dimitri Glazkov.
493
494         V8 WorkerContextExecutionProxy does not handle SharedWorkers
495         https://bugs.webkit.org/show_bug.cgi?id=31226
496
497         Now checks to see what type of context is active and creates the
498         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
499
500         Added support for converting to SharedWorkers and SharedWorkerContexts.
501
502         Test: Existing layout tests cover this case (start passing in Chrome).
503
504         * bindings/v8/WorkerContextExecutionProxy.cpp:
505         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
506         Now generates the right type of DOMWrapper for SharedWorkerContexts.
507         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
508         Added support for SHAREDWORKERCONTEXT.
509         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
510         Added support for SharedWorker and SharedWorkerContext.
511
512 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
513
514         Reviewed by Dimitri Glazkov.
515
516         https://bugs.webkit.org/show_bug.cgi?id=31224
517         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
518
519         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
520
521         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
522         (WebCore::NAMED_PROPERTY_GETTER):
523
524 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
525
526         Reviewed by Timothy Hatcher.
527
528         Web Inspector: "Search again" on scripts panel switches
529         to the script this search started with.
530
531         https://bugs.webkit.org/show_bug.cgi?id=31243
532
533         * inspector/front-end/Panel.js:
534         (WebInspector.Panel.prototype.jumpToNextSearchResult):
535
536 2009-11-08  Kent Tamura  <tkent@chromium.org>
537
538         Reviewed by Darin Adler.
539
540         Simplify Icon interface.
541         https://bugs.webkit.org/show_bug.cgi?id=31154
542
543         - Remove Icon::createIconForFile().  createIconForFiles() covers
544           createIconForFile()'s role.
545         - Remove FileChooser::chooseIcon()
546         - Change the parameter types of FileChooser constructor and the
547           factory method, String -> const Vector<String>&, in order to
548           support initialization with multiple files.
549         - Remove the icon loading code in IconChromiumWin.cpp, which
550           doesn't work because of the sandbox.
551
552         No tests because it's just a refactoring.
553
554         * platform/FileChooser.cpp:
555         (WebCore::FileChooser::FileChooser):
556         (WebCore::FileChooser::create):
557         (WebCore::FileChooser::chooseFile):
558         (WebCore::FileChooser::chooseFiles):
559         * platform/FileChooser.h:
560         * platform/graphics/Icon.h:
561         * platform/graphics/chromium/IconChromiumLinux.cpp:
562         * platform/graphics/chromium/IconChromiumMac.cpp:
563         * platform/graphics/chromium/IconChromiumWin.cpp:
564         (WebCore::Icon::createIconForFiles):
565         * platform/graphics/gtk/IconGtk.cpp:
566         (WebCore::Icon::createIconForFiles):
567         * platform/graphics/haiku/IconHaiku.cpp:
568         * platform/graphics/mac/IconMac.mm:
569         (WebCore::Icon::createIconForFiles):
570         * platform/graphics/qt/IconQt.cpp:
571         (WebCore::Icon::createIconForFiles):
572         * platform/graphics/win/IconWin.cpp:
573         (WebCore::Icon::createIconForFiles):
574         * platform/graphics/wx/IconWx.cpp:
575         * rendering/RenderFileUploadControl.cpp:
576         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
577
578 2009-11-08  Daniel Bates  <dbates@webkit.org>
579
580         Reviewed by Adam Barth.
581
582         https://bugs.webkit.org/show_bug.cgi?id=31098
583
584         Allows same-origin plugin-based content to load.
585
586         Test: http/tests/security/xssAuditor/object-src-inject.html
587
588         * page/XSSAuditor.cpp:
589         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
590         (WebCore::XSSAuditor::canLoadObject): Ditto.
591         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 
592         (WebCore::XSSAuditor::isSameOriginResource): Added.
593         * page/XSSAuditor.h:
594
595 2009-11-08  David Levin  <levin@chromium.org>
596
597         Reviewed by NOBODY (chromium build fix).
598
599         * platform/network/HTTPParsers.cpp:
600         (WebCore::parseDate): Changed this to not
601         use a date parser that needs ExecState passed.
602         
603 2009-11-08  David Levin  <levin@chromium.org>
604
605         Unreviewed build fix for chromium.
606
607         * platform/graphics/skia/GraphicsContextSkia.cpp:
608         (WebCore::GraphicsContext::fillPath):
609         (WebCore::GraphicsContext::fillRect):
610         (WebCore::GraphicsContext::strokePath):
611         (WebCore::GraphicsContext::strokeRect):
612
613 2009-11-08  David Levin  <levin@chromium.org>
614
615         Unreviewed build fix for chromium.
616
617         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
618         Clean up GraphicsContext's current concept of ColorSpace
619
620         * platform/graphics/skia/GraphicsContextSkia.cpp:
621         (WebCore::GraphicsContext::fillPath):
622         (WebCore::GraphicsContext::fillRect):
623         (WebCore::GraphicsContext::strokePath):
624         (WebCore::GraphicsContext::strokeRect):
625
626 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
627
628         Reviewed by Timothy Hatcher.
629
630         Web Inspector: [REGRESSION] committing style edit
631         clears elements panel selection.
632
633         https://bugs.webkit.org/show_bug.cgi?id=31242
634
635         * inspector/front-end/ElementsTreeOutline.js:
636         (WebInspector.ElementsTreeOutline.prototype.update):
637         * inspector/front-end/StylesSidebarPane.js:
638         (WebInspector.StylePropertyTreeElement.prototype.):
639         (WebInspector.StylePropertyTreeElement.prototype):
640
641 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
642
643         Reviewed by Holger Freyther.
644
645         ResourceRequest to be class instead of struct
646         https://bugs.webkit.org/show_bug.cgi?id=30670
647
648         Started as a compilation fix for Symbian where the compiler makes a distinction between
649         class and struct in function argument signatures.
650         Changed all forward declarations of ResourceRequest to have class in the forward
651         declaration instead of struct and changed the definition of ResourceRequest to be class
652         and added access qualifiers where missing. Additionally two references of friend
653         struct ResourceRequestBase changed to class instead.
654
655         * history/HistoryItem.h:
656         * inspector/InspectorController.h:
657         * inspector/InspectorResource.h:
658         * loader/DocumentThreadableLoader.h:
659         * loader/FrameLoaderClient.h:
660         * loader/MainResourceLoader.h:
661         * loader/ResourceLoadNotifier.h:
662         * loader/SubresourceLoader.h:
663         * loader/SubresourceLoaderClient.h:
664         * loader/ThreadableLoader.h:
665         * loader/WorkerThreadableLoader.h:
666         * loader/appcache/ApplicationCache.h:
667         * loader/appcache/ApplicationCacheHost.h:
668         * platform/CrossThreadCopier.h:
669         * platform/network/ResourceHandle.h:
670         * platform/network/ResourceHandleClient.h:
671         * platform/network/ResourceRequestBase.h:
672         * platform/network/cf/ResourceRequest.h:
673         * platform/network/cf/ResourceRequestCFNet.h:
674         * platform/network/chromium/ResourceRequest.h:
675         * platform/network/curl/ResourceRequest.h:
676         * platform/network/qt/ResourceRequest.h:
677         * platform/network/soup/ResourceRequest.h:
678         * xml/XMLHttpRequest.h:
679
680 2009-11-08  Dan Bernstein  <mitz@apple.com>
681
682         Reviewed by Simon Fraser.
683
684         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
685         below FrameView::layout
686         https://bugs.webkit.org/show_bug.cgi?id=31093
687
688         Test: fast/block/positioning/relative-positioned-inline-container.html
689
690         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
691         to mark the object for layout, doing so without marking its ancestors.
692         However, RenderBlock::skipLeadingWhitespace and
693         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
694         positioned inline container, causing it to be marked for layout without
695         ever going back to give it layout, and thus layout could end with a
696         dirty object still in the tree, leading to all sorts of badness.
697
698         The fix is to revert setStaticY() to not marking the object dirty, and
699         instead do it in the call sites that require it, which are in
700         RenderBlock and RenderFlexibleBox.
701
702         * rendering/RenderBlock.cpp:
703         (WebCore::RenderBlock::adjustPositionedBlock):
704         * rendering/RenderFlexibleBox.cpp:
705         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
706         (WebCore::RenderFlexibleBox::layoutVerticalBox):
707         * rendering/RenderLayer.cpp:
708         * rendering/RenderLayer.h:
709         (WebCore::RenderLayer::setStaticY):
710
711 2009-11-07  Daniel Bates  <dbates@webkit.org>
712
713         Reviewed by Darin Adler.
714
715         https://bugs.webkit.org/show_bug.cgi?id=20780
716         
717         Fixes an issue where the onchange event handler is not fired when the 
718         input field is autocompleted.
719         
720         We cannot test this using DRT since DRT cannot emulate autocompletion.
721         So, a manual-test is included.
722
723         Tests: manual-tests/autocompletion-fire-onchange.html
724
725         * manual-tests/autocompletion-fire-onchange.html: Added.
726         * rendering/RenderTextControl.cpp:
727         (WebCore::RenderTextControl::setInnerTextValue):
728
729 2009-11-07  Benjamin Otte  <otte@gnome.org>
730
731         Reviewed by Holger Freyther.
732
733         Mark redrawn areas on image surfaces as dirty.
734
735         This is required to conform to the Cairo API, but is currently only
736         used by debugging tools like cairo-trace.
737
738         * platform/graphics/cairo/ImageBufferCairo.cpp:
739         (WebCore::ImageBuffer::platformTransformColorSpace):
740         (WebCore::putImageData):
741
742 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
743
744         Reviewed by Xan Lopez.
745
746         https://bugs.webkit.org/show_bug.cgi?id=30878
747         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
748
749         If the end_offset is -1, use the String length as the end_offset.
750
751         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
752         (webkit_accessible_text_get_text):
753
754 2009-11-06  Beth Dakin  <bdakin@apple.com>
755
756         Reviewed by Adele Peterson.
757
758         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up 
759         GraphicsContext's current concept of ColorSpace
760
761         ColorSpace is now called ColorType. The variables on the state we 
762         appropriately re-named as well. I removed strokeColorSpace() and 
763         fillColorSpace() from GraphicsContext since they were never called. 
764
765         * platform/graphics/GraphicsContext.cpp:
766         (WebCore::GraphicsContext::setStrokeColor):
767         (WebCore::GraphicsContext::setFillColor):
768         (WebCore::GraphicsContext::setStrokePattern):
769         (WebCore::GraphicsContext::setFillPattern):
770         (WebCore::GraphicsContext::setStrokeGradient):
771         (WebCore::GraphicsContext::setFillGradient):
772         * platform/graphics/GraphicsContext.h:
773         (WebCore::):
774         * platform/graphics/GraphicsContextPrivate.h:
775         (WebCore::GraphicsContextState::GraphicsContextState):
776         * platform/graphics/cairo/GraphicsContextCairo.cpp:
777         (WebCore::GraphicsContext::fillPath):
778         (WebCore::GraphicsContext::strokePath):
779         * platform/graphics/cg/GraphicsContextCG.cpp:
780         (WebCore::calculateDrawingMode):
781         (WebCore::GraphicsContext::drawPath):
782         (WebCore::GraphicsContext::fillPath):
783         (WebCore::GraphicsContext::strokePath):
784         (WebCore::GraphicsContext::fillRect):
785         (WebCore::GraphicsContext::strokeRect):
786         * platform/graphics/qt/GraphicsContextQt.cpp:
787         (WebCore::GraphicsContext::fillPath):
788         (WebCore::GraphicsContext::strokePath):
789         (WebCore::GraphicsContext::fillRect):
790         * platform/graphics/wince/GraphicsContextWince.cpp:
791         (WebCore::GraphicsContext::fillPath):
792         (WebCore::GraphicsContext::fillRect):
793
794 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
795
796         Reviewed by Tim Hatcher.
797
798         Fixes <http://webkit.org/b/31177>.
799         Web Inspector: Bind backspace to delete cookies and DOM Storage.
800         
801         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
802         places in the inspector can use editing in DataGrid (added a FIXME for
803         some stuff that needs to be generalized).
804         
805         Also added deleting functionality to DataGrid, and implemented it for
806         Cookies and DOM Storage. The reason this patch is so big is because of
807         the refactoring of editing code, which won't be used yet in a cross-datagrid
808         way, but should be able to.
809         
810         Additionally, moved the callbacks members from DOMStorageDataGrid to
811         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to 
812         make the architecture of DOM Storage look a lot more like the Cookies view.
813         
814         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the 
815         inspector from beeping at you when you delete an element.
816
817         * WebCore.gypi: Removed DOMStorageDataGrid.
818         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
819         * inspector/front-end/CookieItemsView.js:
820         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
821         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
822         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
823         * inspector/front-end/DOMStorageDataGrid.js: Removed.
824         * inspector/front-end/DOMStorageItemsView.js:
825         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
826         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
827         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
828         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
829         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
830         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
831         * inspector/front-end/DataGrid.js:
832         (WebInspector.DataGrid):
833         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
834         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
835         (WebInspector.DataGrid.prototype._startEditing): Ditto.
836         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
837         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
838         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
839         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
840         * inspector/front-end/ElementsTreeOutline.js:
841         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
842         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
843         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
844
845 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
846
847         Qt build fix: added an ExecState parameter.
848
849         * bridge/qt/qt_runtime.cpp:
850         (JSC::Bindings::convertValueToQVariant):
851         (JSC::Bindings::convertQVariantToValue):
852
853 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
854
855         https://bugs.webkit.org/show_bug.cgi?id=31197
856         Implemented a timezone cache not based on Mac OS X's notify_check API.
857
858         Updated for JavaScriptCore internal API change.
859
860         * bridge/qt/qt_runtime.cpp:
861         (JSC::Bindings::convertValueToQVariant):
862         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
863
864         * platform/network/HTTPParsers.cpp:
865         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
866         (This function probably shouldn't be using a JavaScript date parser
867         to begin with, but oh well.)
868
869 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
870
871         Reviewed by Adam Barth.
872
873         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
874         which affects Chromium only.
875         
876         Changes to V8HTMLDocumentCustom.cpp are as below:-
877         1. The HTMLDocumentOpen function would cause a crash in Chromium if
878            there was no calling javascript context. We now check for this case
879            and pass in NULL to the HTMLDocument::open function which can handle
880            a NULL document parameter.
881         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
882            had ASSERTS for a NULL caller frame, which was bogus as it would crash
883            anyway. We now check for this case and return a failure.
884            
885         Changes to V8DOMWindowCustom.cpp are as below:-
886         1. Instead of failing the window.open call made by NPAPI for lack of a
887            calling javascript context, we now use the entered context as the calling
888            context.
889
890         Tests: plugins/document-open.html
891                plugins/window-open.html
892
893         * bindings/v8/custom/V8DOMWindowCustom.cpp:
894         (WebCore::CALLBACK_FUNC_DECL):
895         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
896         (WebCore::CALLBACK_FUNC_DECL):
897
898 2009-11-06  Steve Block  <steveblock@google.com>
899
900         Reviewed by Eric Seidel.
901
902         Geolocation error code UNKNOWN_ERROR is deprecated.
903         https://bugs.webkit.org/show_bug.cgi?id=31184
904
905         Remove this error code from PositionError, both for use from C++ code and from the JS object.
906
907         Updated fast/dom/Geolocation/error.html to test this.
908
909         * page/PositionError.h: Modified.
910         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
911         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
912         * page/Geolocation.cpp: Modified.
913         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
914         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
915         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
916
917 2009-11-06  Dirk Schulze  <krit@webkit.org>
918
919         Reviewed by Nikolas Zimmermann.
920
921         feMorphology filter is not implemented
922         [https://bugs.webkit.org/show_bug.cgi?id=5863]
923
924         The Implementation of feMorphology.
925         
926         Test: We have allready a test for feMorphology
927               svg/W3C-SVG-1.1/filters-morph-01-f.svg
928
929         * svg/graphics/filters/SVGFEMorphology.cpp:
930         (WebCore::FEMorphology::apply):
931
932 2009-11-06  Steve Block  <steveblock@google.com>
933
934         Reviewed by Eric Seidel.
935
936         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
937         https://bugs.webkit.org/show_bug.cgi?id=31209
938
939         Build fix only. No new tests possible.
940
941         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
942
943 2009-11-06  Drew Wilson  <atwilson@chromium.org>
944
945         Reviewed by David Levin.
946
947         V8 bindings do not support SharedWorkers as event targets
948         https://bugs.webkit.org/show_bug.cgi?id=31199
949
950         No new tests because existing layout tests suffice (they currently
951         crash on Chromium)
952
953         * bindings/v8/V8DOMWrapper.cpp:
954         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
955         Added clause to create a DOM wrapper for SharedWorkers.
956
957 2009-11-06  Anton Muhin  <antonm@chromium.org>
958
959         Reviewed by Adam Barth.
960
961         Do not unnecessarly synchronzie in weak reference callbacks.
962         https://bugs.webkit.org/show_bug.cgi?id=31191
963
964         * bindings/v8/DOMData.h:
965         (WebCore::DOMData::handleWeakObject):
966
967 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
968
969         Reviewed by Pavel Feldman.
970
971         Fix resource content search.
972         https://bugs.webkit.org/show_bug.cgi?id=31202
973
974         * inspector/front-end/AbstractTimelinePanel.js:
975         (WebInspector.AbstractTimelinePanel.prototype.refresh):
976         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
977         * inspector/front-end/TimelinePanel.js:
978         (WebInspector.TimelineGraph.prototype.refresh):
979
980 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
981
982         Reviewed by Eric Seidel.
983
984         Fix ASSERT(currentStyle = renderStyle()).
985         https://bugs.webkit.org/show_bug.cgi?id=31152
986
987         * dom/Element.cpp:
988         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
989
990 2009-11-05  Alpha Lam  <hclam@chromium.org>
991
992         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
993
994         * bindings/v8/V8GCController.cpp:
995         (WebCore::V8GCController::gcEpilogue):
996         * bindings/v8/V8GCController.h:
997         * bindings/v8/V8Proxy.cpp:
998         (WebCore::V8Proxy::evaluate):
999         (WebCore::V8Proxy::runScript):
1000         (WebCore::V8Proxy::callFunction):
1001
1002 2009-11-05  Adam Barth  <abarth@webkit.org>
1003
1004         Reviewed by Sam Weinig.
1005
1006         Cross-domain access to stylesheet text should not be allowed
1007         https://bugs.webkit.org/show_bug.cgi?id=20527
1008
1009         Check whether whether the current document can read the cssRules from
1010         the style sheet.  Firefox throws a security error here, but we return
1011         null instead because that's what we usually do in these cases.
1012
1013         Test: http/tests/security/cannot-read-cssrules-redirect.html
1014               http/tests/security/cannot-read-cssrules.html
1015
1016         * css/CSSStyleSheet.cpp:
1017         (WebCore::CSSStyleSheet::cssRules):
1018
1019 2009-11-05  Steve Block  <steveblock@google.com>
1020
1021         Reviewed by Eric Seidel.
1022
1023         If the Geolocation service fails to start, invoke the error callback asynchronously.
1024         https://bugs.webkit.org/show_bug.cgi?id=28276
1025
1026         All Geolocation callbacks must be invoked asynchronously.
1027         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
1028
1029         No new tests possible with current LayoutTestController.
1030
1031         * page/Geolocation.cpp:
1032         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
1033         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
1034         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
1035
1036 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
1037
1038         Reviewed by Eric Seidel.
1039
1040         Removed the "this is part of the KDE project" comments from 
1041         all *.h, *.cpp, *.idl, and *.pm files.
1042         
1043         https://bugs.webkit.org/show_bug.cgi?id=31167
1044         
1045         The maintenance and architecture page in the project wiki lists
1046         this as a task.
1047         
1048         This change includes no changes or additions to test cases 
1049         since the change affects only comments.
1050
1051         * bindings/scripts/CodeGeneratorV8.pm:
1052         * bindings/scripts/IDLParser.pm:
1053         * bindings/scripts/IDLStructure.pm:
1054         * css/CSSInheritedValue.cpp:
1055         * css/CSSInitialValue.cpp:
1056         * css/CSSMediaRule.cpp:
1057         * css/CSSNamespace.h:
1058         * css/CSSProperty.cpp:
1059         * css/CSSProperty.h:
1060         * css/CSSRuleList.cpp:
1061         * css/CSSRuleList.h:
1062         * css/CSSSelector.h:
1063         * css/CSSValueList.cpp:
1064         * css/FontValue.cpp:
1065         * css/MediaFeatureNames.cpp:
1066         * css/MediaFeatureNames.h:
1067         * css/Pair.h:
1068         * css/SVGCSSStyleSelector.cpp:
1069         * css/ShadowValue.cpp:
1070         * css/StyleSheet.cpp:
1071         * css/StyleSheetList.cpp:
1072         * css/maketokenizer:
1073         * dom/BeforeUnloadEvent.cpp:
1074         * dom/BeforeUnloadEvent.h:
1075         * dom/CSSMappedAttributeDeclaration.cpp:
1076         * dom/EventNames.cpp:
1077         * dom/EventTarget.cpp:
1078         * dom/MappedAttributeEntry.h:
1079         * dom/MouseRelatedEvent.h:
1080         * dom/RangeException.h:
1081         * dom/StyleElement.h:
1082         * dom/Tokenizer.h:
1083         * html/HTMLHeadElement.h:
1084         * html/HTMLHeadingElement.cpp:
1085         * html/HTMLHeadingElement.h:
1086         * html/HTMLHtmlElement.h:
1087         * html/HTMLImageLoader.h:
1088         * html/HTMLMetaElement.h:
1089         * html/HTMLModElement.cpp:
1090         * html/HTMLModElement.h:
1091         * html/HTMLOptionsCollection.cpp:
1092         * html/HTMLPlugInElement.cpp:
1093         * html/HTMLPreElement.cpp:
1094         * html/HTMLPreElement.h:
1095         * html/HTMLTableCellElement.cpp:
1096         * html/HTMLTableCellElement.h:
1097         * html/HTMLTableColElement.cpp:
1098         * html/HTMLTableColElement.h:
1099         * html/HTMLTablePartElement.cpp:
1100         * html/HTMLTablePartElement.h:
1101         * html/HTMLTitleElement.h:
1102         * page/MouseEventWithHitTestResults.h:
1103         * platform/StaticConstructors.h:
1104         * platform/text/AtomicStringImpl.h:
1105         * platform/text/qt/TextBreakIteratorQt.cpp:
1106         * rendering/AutoTableLayout.h:
1107         * rendering/CounterNode.cpp:
1108         * rendering/EllipsisBox.cpp:
1109         * rendering/EllipsisBox.h:
1110         * rendering/FixedTableLayout.cpp:
1111         * rendering/FixedTableLayout.h:
1112         * rendering/HitTestRequest.h:
1113         * rendering/HitTestResult.h:
1114         * rendering/InlineRunBox.h:
1115         * rendering/PointerEventsHitRules.cpp:
1116         * rendering/PointerEventsHitRules.h:
1117         * rendering/RenderBR.cpp:
1118         * rendering/RenderBR.h:
1119         * rendering/RenderButton.cpp:
1120         * rendering/RenderButton.h:
1121         * rendering/RenderFieldset.cpp:
1122         * rendering/RenderFrameSet.cpp:
1123         * rendering/RenderListItem.cpp:
1124         * rendering/RenderTableRow.cpp:
1125         * rendering/RenderView.h:
1126         * rendering/RootInlineBox.h:
1127         * rendering/SVGInlineTextBox.cpp:
1128         * rendering/SVGInlineTextBox.h:
1129         * rendering/TableLayout.h:
1130         * rendering/break_lines.h:
1131         * rendering/style/SVGRenderStyle.cpp:
1132         * rendering/style/SVGRenderStyle.h:
1133         * rendering/style/SVGRenderStyleDefs.cpp:
1134         * rendering/style/SVGRenderStyleDefs.h:
1135         * svg/GradientAttributes.h:
1136         * svg/LinearGradientAttributes.h:
1137         * svg/PatternAttributes.h:
1138         * svg/RadialGradientAttributes.h:
1139         * svg/SVGAElement.cpp:
1140         * svg/SVGAngle.idl:
1141         * svg/SVGAnimateColorElement.cpp:
1142         * svg/SVGAnimateColorElement.h:
1143         * svg/SVGAnimateElement.cpp:
1144         * svg/SVGAnimateElement.h:
1145         * svg/SVGAnimateTransformElement.h:
1146         * svg/SVGAnimatedPathData.cpp:
1147         * svg/SVGAnimatedPathData.h:
1148         * svg/SVGAnimatedPoints.cpp:
1149         * svg/SVGAnimatedPoints.h:
1150         * svg/SVGAnimationElement.cpp:
1151         * svg/SVGCircleElement.cpp:
1152         * svg/SVGClipPathElement.cpp:
1153         * svg/SVGColor.cpp:
1154         * svg/SVGColor.idl:
1155         * svg/SVGComponentTransferFunctionElement.cpp:
1156         * svg/SVGComponentTransferFunctionElement.h:
1157         * svg/SVGCursorElement.cpp:
1158         * svg/SVGDefsElement.cpp:
1159         * svg/SVGDescElement.cpp:
1160         * svg/SVGDescElement.h:
1161         * svg/SVGDocument.idl:
1162         * svg/SVGElement.idl:
1163         * svg/SVGElementInstanceList.cpp:
1164         * svg/SVGElementInstanceList.h:
1165         * svg/SVGEllipseElement.cpp:
1166         * svg/SVGExternalResourcesRequired.cpp:
1167         * svg/SVGFEBlendElement.cpp:
1168         * svg/SVGFEBlendElement.h:
1169         * svg/SVGFEColorMatrixElement.cpp:
1170         * svg/SVGFEColorMatrixElement.h:
1171         * svg/SVGFEComponentTransferElement.cpp:
1172         * svg/SVGFEComponentTransferElement.h:
1173         * svg/SVGFECompositeElement.cpp:
1174         * svg/SVGFECompositeElement.h:
1175         * svg/SVGFEFloodElement.cpp:
1176         * svg/SVGFEFloodElement.h:
1177         * svg/SVGFEFuncAElement.cpp:
1178         * svg/SVGFEFuncAElement.h:
1179         * svg/SVGFEFuncBElement.cpp:
1180         * svg/SVGFEFuncBElement.h:
1181         * svg/SVGFEFuncGElement.cpp:
1182         * svg/SVGFEFuncGElement.h:
1183         * svg/SVGFEFuncRElement.cpp:
1184         * svg/SVGFEFuncRElement.h:
1185         * svg/SVGFEGaussianBlurElement.cpp:
1186         * svg/SVGFEGaussianBlurElement.h:
1187         * svg/SVGFEImageElement.cpp:
1188         * svg/SVGFEMergeElement.cpp:
1189         * svg/SVGFEMergeElement.h:
1190         * svg/SVGFEMergeNodeElement.cpp:
1191         * svg/SVGFEOffsetElement.cpp:
1192         * svg/SVGFEOffsetElement.h:
1193         * svg/SVGFETileElement.cpp:
1194         * svg/SVGFETileElement.h:
1195         * svg/SVGFETurbulenceElement.cpp:
1196         * svg/SVGFETurbulenceElement.h:
1197         * svg/SVGFilterElement.cpp:
1198         * svg/SVGGElement.cpp:
1199         * svg/SVGGradientElement.cpp:
1200         * svg/SVGHKernElement.idl:
1201         * svg/SVGLangSpace.cpp:
1202         * svg/SVGLangSpace.h:
1203         * svg/SVGLength.cpp:
1204         * svg/SVGLength.h:
1205         * svg/SVGLength.idl:
1206         * svg/SVGLengthList.cpp:
1207         * svg/SVGLengthList.h:
1208         * svg/SVGLineElement.cpp:
1209         * svg/SVGLinearGradientElement.h:
1210         * svg/SVGList.h:
1211         * svg/SVGListTraits.h:
1212         * svg/SVGLocatable.h:
1213         * svg/SVGMaskElement.cpp:
1214         * svg/SVGMatrix.idl:
1215         * svg/SVGMetadataElement.cpp:
1216         * svg/SVGMetadataElement.h:
1217         * svg/SVGMetadataElement.idl:
1218         * svg/SVGNumber.idl:
1219         * svg/SVGNumberList.cpp:
1220         * svg/SVGNumberList.h:
1221         * svg/SVGPaint.cpp:
1222         * svg/SVGPathElement.cpp:
1223         * svg/SVGPathSeg.h:
1224         * svg/SVGPathSegArc.cpp:
1225         * svg/SVGPathSegArc.h:
1226         * svg/SVGPathSegClosePath.cpp:
1227         * svg/SVGPathSegClosePath.h:
1228         * svg/SVGPathSegCurvetoCubic.cpp:
1229         * svg/SVGPathSegCurvetoCubic.h:
1230         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
1231         * svg/SVGPathSegCurvetoCubicSmooth.h:
1232         * svg/SVGPathSegCurvetoQuadratic.cpp:
1233         * svg/SVGPathSegCurvetoQuadratic.h:
1234         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
1235         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
1236         * svg/SVGPathSegLineto.cpp:
1237         * svg/SVGPathSegLineto.h:
1238         * svg/SVGPathSegLinetoHorizontal.cpp:
1239         * svg/SVGPathSegLinetoHorizontal.h:
1240         * svg/SVGPathSegLinetoVertical.cpp:
1241         * svg/SVGPathSegLinetoVertical.h:
1242         * svg/SVGPathSegMoveto.cpp:
1243         * svg/SVGPathSegMoveto.h:
1244         * svg/SVGPatternElement.cpp:
1245         * svg/SVGPoint.idl:
1246         * svg/SVGPointList.cpp:
1247         * svg/SVGPointList.h:
1248         * svg/SVGPolyElement.cpp:
1249         * svg/SVGPolygonElement.cpp:
1250         * svg/SVGPolygonElement.h:
1251         * svg/SVGPolylineElement.cpp:
1252         * svg/SVGPolylineElement.h:
1253         * svg/SVGPreserveAspectRatio.cpp:
1254         * svg/SVGPreserveAspectRatio.h:
1255         * svg/SVGRadialGradientElement.h:
1256         * svg/SVGRect.idl:
1257         * svg/SVGRectElement.cpp:
1258         * svg/SVGRenderingIntent.h:
1259         * svg/SVGSVGElement.idl:
1260         * svg/SVGScriptElement.cpp:
1261         * svg/SVGSetElement.cpp:
1262         * svg/SVGSetElement.h:
1263         * svg/SVGStopElement.cpp:
1264         * svg/SVGStringList.cpp:
1265         * svg/SVGStringList.h:
1266         * svg/SVGStylable.cpp:
1267         * svg/SVGStylable.h:
1268         * svg/SVGStyleElement.cpp:
1269         * svg/SVGStyleElement.h:
1270         * svg/SVGStyledElement.h:
1271         * svg/SVGStyledLocatableElement.cpp:
1272         * svg/SVGStyledLocatableElement.h:
1273         * svg/SVGStyledTransformableElement.cpp:
1274         * svg/SVGStyledTransformableElement.h:
1275         * svg/SVGSwitchElement.cpp:
1276         * svg/SVGSymbolElement.cpp:
1277         * svg/SVGTRefElement.cpp:
1278         * svg/SVGTSpanElement.cpp:
1279         * svg/SVGTSpanElement.h:
1280         * svg/SVGTests.h:
1281         * svg/SVGTextElement.cpp:
1282         * svg/SVGTextElement.h:
1283         * svg/SVGTextPathElement.cpp:
1284         * svg/SVGTextPositioningElement.cpp:
1285         * svg/SVGTextPositioningElement.h:
1286         * svg/SVGTitleElement.cpp:
1287         * svg/SVGTitleElement.h:
1288         * svg/SVGTransform.cpp:
1289         * svg/SVGTransform.h:
1290         * svg/SVGTransform.idl:
1291         * svg/SVGTransformList.cpp:
1292         * svg/SVGTransformList.h:
1293         * svg/SVGTransformable.h:
1294         * svg/SVGURIReference.h:
1295         * svg/SVGUnitTypes.h:
1296         * svg/SVGUseElement.cpp:
1297         * svg/SVGViewElement.cpp:
1298         * svg/SVGZoomAndPan.cpp:
1299         * svg/SVGZoomAndPan.h:
1300         * svg/SVGZoomEvent.cpp:
1301
1302 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
1303
1304         Reviewed by Dimitri Glazkov.
1305
1306         REGRESSION Clean up security origin usage in DOM Storage.
1307         https://bugs.webkit.org/show_bug.cgi?id=31188
1308
1309         Clean up security origin usage in DOM Storage.  This fixes a bug in my
1310         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
1311
1312         Instead of having StorageAreaSync's constructor (which is called in the
1313         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
1314         database identifier, simply have StorageAreaImpl pass the identifier into
1315         StorageAreaSync.
1316
1317         No test because there's no change in externally observable behavior.
1318
1319         * storage/StorageAreaImpl.cpp:
1320         (WebCore::StorageAreaImpl::StorageAreaImpl):
1321         * storage/StorageAreaImpl.h:
1322         * storage/StorageAreaSync.cpp:
1323         (WebCore::StorageAreaSync::create):
1324         (WebCore::StorageAreaSync::StorageAreaSync):
1325         * storage/StorageAreaSync.h:
1326
1327 2009-11-05  Scott Violet  <sky@google.com>
1328
1329         Reviewed by Dimitri Glazkov.
1330
1331         Need notification of scrolling frame
1332         https://bugs.webkit.org/show_bug.cgi?id=31145
1333
1334         Adds FrameLoaderClient::didChangeScrollOffset that is called when
1335         the frame scrolls. This will be used to know when history state
1336         needs to be updated.
1337
1338         * loader/FrameLoaderClient.h:
1339         (WebCore::FrameLoaderClient::didChangeScrollOffset):
1340         * page/FrameView.cpp:
1341         (WebCore::FrameView::valueChanged):
1342
1343 2009-11-05  Kenneth Russell  <kbr@google.com>
1344
1345         Reviewed by Dimitri Glazkov.
1346
1347         [V8] Update bindings to use new API for external arrays
1348         https://bugs.webkit.org/show_bug.cgi?id=31181
1349
1350         No new tests; covered by existing WebGL tests.
1351
1352         * bindings/v8/V8DOMWrapper.cpp:
1353         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
1354         (WebCore::V8DOMWrapper::getTemplate):
1355         (WebCore::V8DOMWrapper::convertToV8Object):
1356         * bindings/v8/V8DOMWrapper.h:
1357         * bindings/v8/custom/V8CanvasArrayCustom.h:
1358         (WebCore::constructCanvasArray):
1359
1360 2009-11-05  Alpha Lam  <hclam@chromium.org>
1361
1362         Not reviewed, Chromium build fix.
1363
1364         50561 introduces a custom method for SVGMatrix, we need to implement
1365         this in V8.
1366
1367         * bindings/v8/custom/V8CustomBinding.h:
1368         Adding definition for V8SVGMatrixMultiply.
1369         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
1370         (WebCore::CALLBACK_FUNC_DECL):
1371         Implement V8SVGMatrixMultiply according to the same method in JSC.
1372
1373 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
1374
1375         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
1376
1377         * page/DOMWindow.cpp:
1378         (WebCore::DOMWindow::sessionStorage):
1379         * page/Settings.cpp:
1380         (WebCore::Settings::Settings):
1381         (WebCore::Settings::setSessionStorageEnabled):
1382         * page/Settings.h:
1383         (WebCore::Settings::sessionStorageEnabled):
1384
1385 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
1386
1387         Reviewed by Timothy Hatcher.
1388
1389         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
1390
1391         https://bugs.webkit.org/show_bug.cgi?id=30884
1392
1393         Test: inspector/styles-iframe.html
1394
1395         * inspector/front-end/DOMAgent.js:
1396         (WebInspector.DOMNode):
1397         * inspector/front-end/InjectedScript.js:
1398         (InjectedScript.getStyles):
1399         (InjectedScript.getComputedStyle):
1400         (InjectedScript.addStyleSelector):
1401         * inspector/front-end/TestController.js:
1402         (WebInspector.TestController.prototype.notifyDone):
1403         (WebInspector.TestController.prototype.runAfterPendingDispatches):
1404         (WebInspector.evaluateForTestInFrontend.invokeMethod):
1405         (WebInspector.evaluateForTestInFrontend):
1406
1407 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
1408
1409         Reviewed by Geoffrey Garen and Dimitri Glazkov.
1410
1411         Rehashing of EventListenerMap leads to loss of EvenListenerList.
1412         https://bugs.webkit.org/show_bug.cgi?id=31027
1413
1414         Tested by new fast/events/event-listener-map-rehash-crash.html.
1415
1416         EventListenerMap modified to store pointers to listener vectors:
1417         * dom/EventTarget.cpp:
1418         (WebCore::EventTargetData::~EventTargetData):
1419         (WebCore::EventTarget::addEventListener):
1420         (WebCore::EventTarget::removeEventListener):
1421         (WebCore::EventTarget::fireEventListeners):
1422         (WebCore::EventTarget::getEventListeners):
1423         (WebCore::EventTarget::removeAllEventListeners):
1424         * dom/EventTarget.h:
1425
1426         Usages updated after interface changes:
1427         * inspector/InspectorDOMAgent.cpp:
1428         (WebCore::InspectorDOMAgent::getEventListenersForNode):
1429         * svg/SVGUseElement.cpp:
1430         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
1431
1432 2009-11-05  Dan Kegel  <dank@chromium.org>
1433
1434         Reviewed by Dmitri Titov.
1435
1436         Add missing initialization for m_createdByParser.
1437         https://bugs.webkit.org/show_bug.cgi?id=31089
1438
1439         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
1440
1441         * dom/ProcessingInstruction.cpp:
1442         (WebCore::ProcessingInstruction::ProcessingInstruction):
1443
1444 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
1445
1446         Reviewed by Adam Barth.
1447
1448         DOM Storage runtime flag changes
1449         https://bugs.webkit.org/show_bug.cgi?id=30602
1450
1451         Part 2/2.
1452
1453         Revert my changes to Settings and instead implement DOM Storage enabling via
1454         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
1455
1456         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
1457         LayoutTest visible changes and thus no tests.
1458
1459         * bindings/v8/custom/V8CustomBinding.h:
1460         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1461         (WebCore::ACCESSOR_RUNTIME_ENABLER):
1462         * page/DOMWindow.cpp:
1463         (WebCore::DOMWindow::sessionStorage):
1464         * page/DOMWindow.idl:
1465         * page/Settings.cpp:
1466         (WebCore::Settings::Settings):
1467         * page/Settings.h:
1468         * storage/Storage.cpp:
1469         (WebCore::Storage::setLocalStorageAvailable):
1470         (WebCore::Storage::localStorageAvailable):
1471         (WebCore::Storage::setSessionStorageAvailable):
1472         (WebCore::Storage::sessionStorageAvailable):
1473         * storage/Storage.h:
1474
1475 2009-11-05  Jian Li  <jianli@chromium.org>
1476
1477         Reviewed by Pavel Feldman.
1478
1479         Bug 31108 - [V8] REGRESSION: Pause on exception is broken
1480         https://bugs.webkit.org/show_bug.cgi?id=31108
1481
1482         * bindings/v8/V8AbstractEventListener.cpp:
1483         (WebCore::V8AbstractEventListener::invokeEventHandler):
1484         * bindings/v8/V8Utilities.cpp:
1485         (WebCore::reportException):
1486
1487 2009-11-05  Jian Li  <jianli@chromium.org>
1488
1489         Reviewed by Dmitri Titov.
1490
1491         We should not bubble up events if we drag something to an iframe that
1492         has an invalid source.
1493         https://bugs.webkit.org/show_bug.cgi?id=30469
1494
1495         Test: http/tests/misc/bubble-drag-events.html
1496
1497         * page/EventHandler.cpp:
1498         (WebCore::EventHandler::handleDragAndDropForTarget):
1499         (WebCore::EventHandler::updateDragAndDrop):
1500         (WebCore::EventHandler::cancelDragAndDrop):
1501         (WebCore::EventHandler::performDragAndDrop):
1502         * page/EventHandler.h:
1503         (WebCore::EventHandler::):
1504
1505 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
1506
1507         Reviewed by Timothy Hatcher.
1508
1509         Web Inspector: speed up Timelines Clear by a factor of thousands.
1510
1511         https://bugs.webkit.org/show_bug.cgi?id=31160
1512
1513         * inspector/front-end/utilities.js:
1514         (Element.prototype.removeChildren):
1515
1516 2009-11-05  Anton Muhin  <antonm@chromium.org>
1517
1518         Reviewed by Adam Barth.
1519
1520         If high memory usage is detected, hint to V8 that it might be due
1521         to external objects retained by V8 objects.
1522         https://bugs.webkit.org/show_bug.cgi?id=31051
1523
1524         * bindings/v8/V8GCController.cpp:
1525         (WebCore::GetMemoryUsageInMB):
1526         (WebCore::V8GCController::gcEpilogue):
1527         (WebCore::V8GCController::checkMemoryUsage):
1528         * bindings/v8/V8GCController.h:
1529         * bindings/v8/V8Proxy.cpp:
1530         (WebCore::V8Proxy::evaluate):
1531         (WebCore::V8Proxy::runScript):
1532         (WebCore::V8Proxy::callFunction):
1533
1534 2009-11-05  Jeff Schiller  <codedread@gmail.com>
1535
1536         Reviewed by Simon Fraser.
1537
1538         Correct order of matrix multiplication for SVGMatrix.
1539         https://bugs.webkit.org/show_bug.cgi?id=16062
1540
1541         Test: svg/dom/SVGMatrix-interface.xhtml
1542
1543         * bindings/js/JSSVGMatrixCustom.cpp:
1544         (WebCore::JSSVGMatrix::multiply):
1545         * svg/SVGMatrix.idl:
1546
1547 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
1548
1549         Reviewed by Timothy Hatcher.
1550
1551         Web Inspector: Make resource-related records in timeline
1552         actually take some time.
1553
1554         https://bugs.webkit.org/show_bug.cgi?id=31139
1555
1556         * English.lproj/localizedStrings.js:
1557         * inspector/front-end/TimelinePanel.js:
1558         (WebInspector.TimelinePanel):
1559         (WebInspector.TimelinePanel.prototype._formatRecord):
1560         (WebInspector.TimelinePanel.prototype._getRecordDetails):
1561         (WebInspector.TimelinePanel.prototype.reset):
1562
1563 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
1564
1565         Reviewed by Darin Fisher.
1566
1567         Simplify LocalStorageThread
1568         https://bugs.webkit.org/show_bug.cgi?id=30935
1569
1570         This is a re-submit of 50519.  LocalStorageTask should have never been ref
1571         counted.  I've removed that and switched a PassRefPtr over to a PassOwnPtr.
1572
1573         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
1574         of the method names a bit more clear. Assert proper thread usage. Join rather
1575         than detaching the thread and doing an ad-hoc form of join. Avoid touching
1576         variables on the background thread when simple to do so.  Also create a generic
1577         scheduleTask function rather than one for each task.
1578
1579         No behavior should have changed.
1580
1581         * storage/LocalStorageTask.h:
1582         * storage/LocalStorageThread.cpp:
1583         (WebCore::LocalStorageThread::create):
1584         (WebCore::LocalStorageThread::LocalStorageThread):
1585         (WebCore::LocalStorageThread::~LocalStorageThread):
1586         (WebCore::LocalStorageThread::start):
1587         (WebCore::LocalStorageThread::threadEntryPointCallback):
1588         (WebCore::LocalStorageThread::threadEntryPoint):
1589         (WebCore::LocalStorageThread::scheduleTask):
1590         (WebCore::LocalStorageThread::terminate):
1591         (WebCore::LocalStorageThread::performTerminate):
1592         * storage/LocalStorageThread.h:
1593         * storage/StorageSyncManager.cpp:
1594         (WebCore::StorageSyncManager::StorageSyncManager):
1595         (WebCore::StorageSyncManager::~StorageSyncManager):
1596         (WebCore::StorageSyncManager::scheduleImport):
1597         (WebCore::StorageSyncManager::scheduleSync):
1598         * storage/StorageSyncManager.h:
1599
1600 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
1601
1602         Reviewed by Darin Fisher.
1603
1604         Calling databaseIdentifier on LocalStorage's background thread is not safe.
1605         https://bugs.webkit.org/show_bug.cgi?id=31149
1606
1607         Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
1608         is not safe.  databaseIdentifier does a bunch of string concatenation which
1609         ref-counts StringImpls in some cases.  This was caught by valgrind thread
1610         sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645
1611
1612         There's no way to test for such racyness, unfortunately.
1613
1614         * storage/StorageAreaSync.cpp:
1615         (WebCore::StorageAreaSync::StorageAreaSync):
1616         (WebCore::StorageAreaSync::performImport):
1617         * storage/StorageAreaSync.h:
1618         * storage/StorageSyncManager.cpp:
1619         (WebCore::StorageSyncManager::fullDatabaseFilename):
1620         * storage/StorageSyncManager.h:
1621
1622 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
1623
1624         Reviewed by Darin Fisher.
1625
1626         Clean up StorageAreaSync
1627         https://bugs.webkit.org/show_bug.cgi?id=31100
1628
1629         Major fixes: Break the ref count cycle for StorageArea on the main
1630         thread, not the background thread since the latter is not safe.
1631         Length() needs to block on the import completing.
1632
1633         Small fixes: setItem needs to handle the copy on write case even if it
1634         has an exception.  setItem and removeItem should just bail from the
1635         the function if the value hasn't changed rather than wrapping the end
1636         in an if block.  Clear should only send an event if it wasn't already
1637         cleared.  StorageAreaSync should assert that the final sync was
1638         scheduled.
1639
1640         * storage/StorageAreaImpl.cpp:
1641         (WebCore::StorageAreaImpl::length):
1642           Forgot to block on the import.
1643         (WebCore::StorageAreaImpl::key):
1644         (WebCore::StorageAreaImpl::setItem):
1645           Handle the copy on write case even when there's an exception.
1646         (WebCore::StorageAreaImpl::removeItem):
1647         (WebCore::StorageAreaImpl::clear):
1648         * storage/StorageAreaSync.cpp:
1649         (WebCore::StorageAreaSync::~StorageAreaSync):
1650         (WebCore::StorageAreaSync::scheduleFinalSync):
1651         (WebCore::StorageAreaSync::performImport):
1652         (WebCore::StorageAreaSync::markImported):
1653         (WebCore::StorageAreaSync::blockUntilImportComplete):
1654         * storage/StorageAreaSync.h:
1655
1656 2009-11-05  Zoltan Horvath  <zoltan@webkit.org>
1657
1658         Reviewed by Eric Seidel.
1659
1660         Allow custom memory allocation control for WebCore's CachedResource
1661         https://bugs.webkit.org/show_bug.cgi?id=31114
1662
1663         Inherits CachedResource class from Noncopyable because its (its child
1664         class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75 
1665         and it is no need to be copyable.
1666
1667         * loader/CachedResource.h:
1668
1669 2009-11-04  Mark Mentovai  <mark@chromium.org>
1670
1671         Reviewed by Mark Rowe.
1672
1673         Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
1674         is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
1675         which is true when targeting 10.6 or later.
1676
1677         HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
1678         is present in the CGInterpolationQuality enum, and must be handled
1679         by a switch that has cases for each enumerated value.
1680
1681         USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
1682         on 10.6 or later, and that CoreGraphics will understand when
1683         InterpolationMedium is mapped to kCGInterpolationMedium at runtime.
1684
1685         * platform/graphics/cg/GraphicsContextCG.cpp:
1686         (WebCore::GraphicsContext::setImageInterpolationQuality):
1687         (WebCore::GraphicsContext::imageInterpolationQuality):
1688
1689 2009-11-04  Dan Kegel  <dank@chromium.org>
1690
1691         Reviewed by Alexey Proskuryakov.
1692
1693         Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
1694         https://bugs.webkit.org/show_bug.cgi?id=31138
1695
1696         Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind
1697
1698         * page/Page.cpp:
1699         (WebCore::Page::userStyleSheetLocationChanged):
1700
1701 2009-11-04  Timothy Hatcher  <timothy@apple.com>
1702
1703         Update the Web Inspector Timeline panel to better match the mock-up.
1704
1705         https://bugs.webkit.org/show_bug.cgi?id=31150
1706
1707         Reviewed by Pavel Feldman.
1708
1709         * inspector/front-end/TimelinePanel.js:
1710         (WebInspector.TimelinePanel.prototype._getRecordDetails):
1711         (WebInspector.TimelinePanel.prototype._dragWindow):
1712         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
1713         (WebInspector.TimelinePanel.prototype._resizeWindowRight):
1714         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
1715         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
1716         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
1717         (WebInspector.TimelineCategoryGraph):
1718         * inspector/front-end/inspector.css:
1719
1720 2009-11-05  Justin Garcia  <justin.garcia@apple.com>
1721
1722         Reviewed by Adele Peterson.
1723
1724         https://bugs.webkit.org/show_bug.cgi?id=25439
1725         Deleting when in front of a block image removes character from previous paragraph
1726
1727         Added editing/deleting/25439-{1,2,3}.html
1728
1729         * editing/DeleteSelectionCommand.cpp:
1730         (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot 
1731         be made inline with other content.  Instead of merging, just move the caret to just before 
1732         the selection we deleted.
1733         * editing/htmlediting.cpp:
1734         (WebCore::firstInSpecialElement): Added a FIXME.  This function begins iterating up from pos.node(), which 
1735         doesn't necessarily contain pos (suppose pos was [img, 0]).
1736         (WebCore::lastInSpecialElement): Ditto.
1737         (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp.  Added a check for non-inline images.
1738         * editing/htmlediting.h:
1739         * editing/visible_units.cpp:
1740         (WebCore::startOfParagraph): Use moved/renamed function.  Removed FIXME.  The problem causing 
1741         5027702 is now squarely in first/lastInSpecialElement
1742         (WebCore::endOfParagraph): Ditto.
1743         
1744 2009-11-04  Enrica Casucci  <enrica@apple.com>
1745
1746         Reviewed by Adele Peterson.
1747
1748         Hang in Mail on attempting to change indent level.
1749         <rdar://problem/7131805>
1750         https://bugs.webkit.org/show_bug.cgi?id=31127
1751
1752         The hang was caused by an infinite loop inside outdentRegion.
1753         The code did not account for the fact that, when a list item
1754         contains multiple paragraphs, outdent moves all paragraphs at
1755         once, invalidating some of the positions we keep track of in the loop.
1756         Some code refactoring has also been done to minimize duplicated code.
1757         
1758         Test: editing/execCommand/outdent-multiparagraph-list.html
1759
1760         * editing/IndentOutdentCommand.cpp:
1761         (WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
1762         outdentRegion to doApply.
1763         (WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
1764         (WebCore::IndentOutdentCommand::doApply): Some code refactoring.
1765         * editing/IndentOutdentCommand.h: Added VisiblePosition parameters to
1766         indentRegion and outdentRegion.
1767
1768 2009-11-04  Alpha Lam  <hclam@chromium.org>
1769
1770         Reviewed by Eric Carlson.
1771
1772         Volume slider doesn't have a thumb
1773         https://bugs.webkit.org/show_bug.cgi?id=31135
1774
1775         Fixed an incorrect if statement that prevents volume slider
1776         being updated.
1777
1778         The statement checks if the slider value equals to the current
1779         volume value of the media control to avoid updating the volume
1780         slider. Updating the volume slider control shouldn't be within
1781         this condition because we explicitly set them to be equals
1782         during creation of the controls and also when mouse events are
1783         received on the volume control.
1784
1785         No new tests because existing code breaks:
1786         LayoutTests/media/video-volume-slider.html
1787
1788         It should now start passing on Chromium.
1789
1790         * rendering/MediaControlElements.cpp:
1791         (WebCore::MediaControlVolumeSliderElement::update):
1792         Update the volume slider regardless of the current volume value
1793         of the media control.
1794
1795 2009-11-04  Jenn Braithwaite  <jennb@chromium.org>
1796
1797         Reviewed by David Levin.
1798
1799         Need to properly disable applicationCache at runtime
1800         https://bugs.webkit.org/show_bug.cgi?id=30417
1801
1802         Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.
1803
1804         No new exposed functionality, so no new tests.
1805
1806         * bindings/v8/RuntimeEnabledFeatures.cpp:
1807         * bindings/v8/RuntimeEnabledFeatures.h:
1808         (WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
1809         (WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
1810         * bindings/v8/custom/V8CustomBinding.h:
1811         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1812         (WebCore::ACCESSOR_RUNTIME_ENABLER):
1813         * page/DOMWindow.idl:
1814
1815 2009-11-04  Alexey Proskuryakov  <ap@apple.com>
1816
1817         Reviewed by Dan Bernstein.
1818
1819         https://bugs.webkit.org/show_bug.cgi?id=31143
1820         Assertion failure in CredentialStorage::set() when proxy credentials are being set
1821
1822         No test, cannot test proxy behavior.
1823
1824         * platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the
1825         possibility of null url. Release mode changes are likely inconsequential - e.g. we used to
1826         add "://" to origin set, which is weird, but safe.
1827
1828 2009-11-04  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
1829
1830         Reviewed by Timothy Hatcher.
1831
1832         Web Inspector: Leftover Breakpoints in the Sidebar Pane
1833         https://bugs.webkit.org/show_bug.cgi?id=30659
1834
1835         No new tests.
1836
1837         * inspector/front-end/ScriptsPanel.js:
1838         (WebInspector.ScriptsPanel.prototype.addScript):
1839
1840 2009-11-04  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1841
1842         Reviewed by Timothy Hatcher.
1843
1844         WebInspector: Use a different method to identify the webkit port in
1845         InspectorBackent::platform().
1846         This corrects the inspector expected behavior with Qt on Windows.
1847         https://bugs.webkit.org/show_bug.cgi?id=31116
1848
1849         * inspector/InspectorBackend.cpp:
1850         (WebCore::InspectorBackend::platform):
1851         (WebCore::InspectorBackend::port):
1852         * inspector/InspectorBackend.h:
1853         * inspector/InspectorBackend.idl:
1854         * inspector/front-end/InspectorControllerStub.js:
1855         (.WebInspector.InspectorControllerStub.prototype.port):
1856         * inspector/front-end/inspector.css:
1857         * inspector/front-end/inspector.js:
1858         (WebInspector.loaded):
1859         (WebInspector.toolbarDragStart):
1860
1861 2009-11-04  Benjamin Otte  <otte@gnome.org>
1862
1863         Reviewed by Gustavo Noronha.
1864
1865         Update Cairo requirement to 1.6.
1866
1867         Also remove all conditional code and workarounds for older versions of
1868         Cairo.
1869         In particular, gain image quality by removing the use of
1870         CAIRO_FILTER_NEAREST when rendering images and use the default
1871         bilinear filter instead.
1872         https://bugs.webkit.org/show_bug.cgi?id=19266
1873
1874         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1875         (WebCore::GraphicsContext::clipOut):
1876         * platform/graphics/cairo/ImageCairo.cpp:
1877         (WebCore::BitmapImage::draw):
1878         (WebCore::BitmapImage::drawPattern):
1879         * platform/graphics/cairo/PathCairo.cpp:
1880         (WebCore::Path::isEmpty):
1881         (WebCore::Path::boundingRect):
1882         * platform/gtk/RenderThemeGtk.cpp:
1883         (WebCore::paintMozWidget):
1884
1885 2009-11-04  Kevin Ollivier  <kevino@theolliviers.com>
1886
1887         wx build fix. Restore removed string conversion after cleanup.
1888
1889         * platform/graphics/wx/FontPlatformDataWx.cpp:
1890         (WebCore::FontPlatformData::computeHash):
1891
1892 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1893
1894         Reviewed by Beth Dakin.
1895
1896         Need to implement ARIA role="combobox"
1897         https://bugs.webkit.org/show_bug.cgi?id=31096
1898
1899         Test: accessibility/aria-combobox.html
1900
1901         * accessibility/AccessibilityObject.h:
1902         (WebCore::AccessibilityObject::isComboBox):
1903         (WebCore::AccessibilityObject::isExpanded):
1904         (WebCore::AccessibilityObject::expandObject):
1905         (WebCore::AccessibilityObject::increment):
1906         (WebCore::AccessibilityObject::decrement):
1907         * accessibility/AccessibilityRenderObject.cpp:
1908         (WebCore::AccessibilityRenderObject::expandObject):
1909         (WebCore::AccessibilityRenderObject::isExpanded):
1910         (WebCore::createARIARoleMap):
1911         * accessibility/AccessibilityRenderObject.h:
1912         * accessibility/mac/AccessibilityObjectWrapper.mm:
1913         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
1914         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1915         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
1916         * html/HTMLAttributeNames.in:
1917
1918 2009-11-04  Kelly Norton  <knorton@google.com>
1919
1920         Reviewed by Pavel Feldman.
1921
1922         Fixes naming inconsistencies in TimelineRecordFactory.
1923         https://bugs.webkit.org/show_bug.cgi?id=31132
1924
1925         * inspector/InspectorTimelineAgent.cpp:
1926         (WebCore::InspectorTimelineAgent::willPaint):
1927         (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
1928         (WebCore::InspectorTimelineAgent::willLoadXHR):
1929         (WebCore::InspectorTimelineAgent::willEvaluateScript):
1930         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
1931         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
1932         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
1933         * inspector/TimelineRecordFactory.cpp:
1934         (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord):
1935         (WebCore::TimelineRecordFactory::createXHRLoadRecord):
1936         (WebCore::TimelineRecordFactory::createEvaluateScriptRecord):
1937         (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
1938         (WebCore::TimelineRecordFactory::createResourceSendRequestRecord):
1939         (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord):
1940         (WebCore::TimelineRecordFactory::createResourceFinishRecord):
1941         (WebCore::TimelineRecordFactory::createPaintRecord):
1942         * inspector/TimelineRecordFactory.h:
1943
1944 2009-11-04  Eric Z. Ayers  <zundel@google.com>
1945
1946         Reviewed by Pavel Feldman.
1947
1948         Followon to bug 31080, which protects Timeline
1949         instrumentation in the case where InspectorTimelineAgent
1950         is enabled or disabled during an event dispatch.
1951         
1952         https://bugs.webkit.org/show_bug.cgi?id=31121
1953
1954         * bindings/v8/V8Proxy.cpp:
1955         (WebCore::V8Proxy::evaluate):
1956         * dom/Document.cpp:
1957         (WebCore::Document::recalcStyle):
1958         * dom/Node.cpp:
1959         (WebCore::Node::dispatchGenericEvent):
1960         * html/HTMLTokenizer.cpp:
1961         (WebCore::HTMLTokenizer::write):
1962         * page/DOMWindow.cpp:
1963         (WebCore::DOMWindow::inspectorTimelineAgent):
1964         (WebCore::DOMWindow::dispatchEvent):
1965         * page/DOMWindow.h:
1966         * page/FrameView.cpp:
1967         (WebCore::FrameView::layout):
1968         (WebCore::FrameView::paintContents):
1969         * xml/XMLHttpRequest.cpp:
1970         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
1971
1972 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
1973
1974         Revert 50519 while I work out what went wrong.
1975
1976         * storage/LocalStorageThread.cpp:
1977         (WebCore::LocalStorageThread::create):
1978         (WebCore::LocalStorageThread::LocalStorageThread):
1979         (WebCore::LocalStorageThread::start):
1980         (WebCore::LocalStorageThread::localStorageThreadStart):
1981         (WebCore::LocalStorageThread::localStorageThread):
1982         (WebCore::LocalStorageThread::scheduleImport):
1983         (WebCore::LocalStorageThread::scheduleSync):
1984         (WebCore::LocalStorageThread::terminate):
1985         (WebCore::LocalStorageThread::performTerminate):
1986         * storage/LocalStorageThread.h:
1987         * storage/StorageSyncManager.cpp:
1988         (WebCore::StorageSyncManager::StorageSyncManager):
1989         (WebCore::StorageSyncManager::~StorageSyncManager):
1990         (WebCore::StorageSyncManager::scheduleImport):
1991         (WebCore::StorageSyncManager::scheduleSync):
1992         * storage/StorageSyncManager.h:
1993
1994 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
1995
1996         Reviewed by Timothy Hatcher.
1997
1998         Web Inspector: Add basic support for resource events and marks.
1999         Couple of drive-by fixes. Enabling the panel!
2000
2001         https://bugs.webkit.org/show_bug.cgi?id=31130
2002
2003         * English.lproj/localizedStrings.js:
2004         * inspector/front-end/TimelinePanel.js:
2005         (WebInspector.TimelinePanel):
2006         (WebInspector.TimelinePanel.prototype._formatRecord):
2007         (WebInspector.TimelinePanel.prototype._getRecordDetails):
2008         (WebInspector.TimelinePanel.prototype.reset):
2009         (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked):
2010         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
2011         * inspector/front-end/inspector.js:
2012         (WebInspector._createPanels):
2013
2014 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
2015
2016         Reviewed by Darin Fisher.
2017
2018         Simplify LocalStorageThread
2019         https://bugs.webkit.org/show_bug.cgi?id=30935
2020
2021         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
2022         of the method names a bit more clear. Assert proper thread usage. Join rather
2023         than detaching the thread and doing an ad-hoc form of join. Avoid touching
2024         variables on the background thread when simple to do so.  Also create a generic
2025         scheduleTask function rather than one for each task.
2026
2027         No behavior should have changed.
2028
2029         * storage/LocalStorageThread.cpp:
2030         (WebCore::LocalStorageThread::create):
2031         (WebCore::LocalStorageThread::LocalStorageThread):
2032         (WebCore::LocalStorageThread::~LocalStorageThread):
2033         (WebCore::LocalStorageThread::start):
2034         (WebCore::LocalStorageThread::threadEntryPointCallback):
2035         (WebCore::LocalStorageThread::threadEntryPoint):
2036         (WebCore::LocalStorageThread::scheduleTask):
2037         (WebCore::LocalStorageThread::terminate):
2038         (WebCore::LocalStorageThread::performTerminate):
2039         * storage/LocalStorageThread.h:
2040         * storage/StorageSyncManager.cpp:
2041         (WebCore::StorageSyncManager::StorageSyncManager):
2042         (WebCore::StorageSyncManager::~StorageSyncManager):
2043         (WebCore::StorageSyncManager::scheduleImport):
2044         (WebCore::StorageSyncManager::scheduleSync):
2045         * storage/StorageSyncManager.h:
2046
2047 2009-11-04  Vadim Zeitlin  <vadim@wxwidgets.org>
2048
2049         Reviewed by Eric Seidel.
2050
2051         [wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.
2052
2053         * platform/graphics/wx/FontPlatformDataWx.cpp:
2054         (WebCore::FontPlatformData::computeHash):
2055
2056 2009-11-04  Kelly Norton  <knorton@google.com>
2057
2058         Reviewed by Pavel Feldman.
2059
2060         Adds lightweight network resources to InspectorTimelineAgent.
2061         https://bugs.webkit.org/show_bug.cgi?id=31065
2062
2063         * inspector/InspectorController.cpp:
2064         (WebCore::InspectorController::willSendRequest):
2065         (WebCore::InspectorController::didReceiveResponse):
2066         (WebCore::InspectorController::didFinishLoading):
2067         (WebCore::InspectorController::didFailLoading):
2068         * inspector/InspectorTimelineAgent.cpp:
2069         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
2070         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
2071         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
2072         * inspector/InspectorTimelineAgent.h:
2073         (WebCore::):
2074         * inspector/TimelineRecordFactory.cpp:
2075         (WebCore::TimelineRecordFactory::createResourceSendRequestTimelineRecord):
2076         (WebCore::TimelineRecordFactory::createResourceReceiveResponseTimelineRecord):
2077         (WebCore::TimelineRecordFactory::createResourceFinishTimelineRecord):
2078         * inspector/TimelineRecordFactory.h:
2079         * inspector/front-end/TimelineAgent.js:
2080
2081 2009-11-04  Yael Aharon  <yael.aharon@nokia.com>
2082
2083         Reviewed by Tor Arne Vestbø.
2084
2085         [Qt] ASSERT failure when receiving 401 HTTP Authentication response.
2086         https://bugs.webkit.org/show_bug.cgi?id=31077
2087
2088         Allow sending the response body under the same conditions that we
2089         allow it to finish without reporting an error.
2090
2091         * platform/network/qt/QNetworkReplyHandler.cpp:
2092         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2093
2094 2009-11-04  Adam Roben  <aroben@apple.com>
2095
2096         Sort WebCore.base.exp
2097
2098         Rubber-stamped by Dan Bernstein.
2099
2100         * WebCore.base.exp: Sorted.
2101
2102 2009-11-04  Csaba Osztrogonác  <ossy@webkit.org>
2103
2104         Unreviewed rollout.
2105
2106         Revert r50496 because it broke all layout tests on QtBuildBot.
2107
2108         * WebCore.pro:
2109         * platform/graphics/qt/FontCacheQt.cpp:
2110         (WebCore::fontCache):
2111         (WebCore::FontCache::FontCache):
2112         (WebCore::FontCache::getTraitsInFamily):
2113         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
2114         (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
2115         (WebCore::FontPlatformDataCacheKey::):
2116         (WebCore::FontPlatformDataCacheKey::operator==):
2117         (WebCore::FontPlatformDataCacheKey::hash):
2118         (WebCore::FontPlatformDataCacheKey::computeHash):
2119         (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
2120         (WebCore::FontPlatformDataCacheKeyHash::hash):
2121         (WebCore::FontPlatformDataCacheKeyHash::equal):
2122         (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
2123         (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
2124         (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
2125         (WebCore::FontCache::getCachedFontPlatformData):
2126         (WebCore::FontCache::getCachedFontData):
2127         (WebCore::FontCache::getLastResortFallbackFont):
2128         (WebCore::FontCache::releaseFontData):
2129         (WebCore::FontCache::purgeInactiveFontData):
2130         (WebCore::FontCache::addClient):
2131         (WebCore::FontCache::removeClient):
2132         (WebCore::FontCache::invalidate):
2133         * platform/graphics/qt/FontFallbackListQt.cpp: Added.
2134         (WebCore::FontFallbackList::FontFallbackList):
2135         (WebCore::FontFallbackList::invalidate):
2136         (WebCore::FontFallbackList::releaseFontData):
2137         (WebCore::FontFallbackList::determinePitch):
2138         (WebCore::FontFallbackList::fontDataAt):
2139         (WebCore::FontFallbackList::fontDataForCharacters):
2140         (WebCore::FontFallbackList::setPlatformFont):
2141         * platform/graphics/qt/FontPlatformData.h:
2142         (WebCore::FontPlatformData::pixelSize):
2143         * platform/graphics/qt/FontPlatformDataQt.cpp:
2144         (WebCore::FontPlatformData::FontPlatformData):
2145
2146 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2147
2148         Reviewed by Jan Alonzo.
2149
2150         https://bugs.webkit.org/show_bug.cgi?id=31044
2151         [Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view
2152
2153         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2154         (atkParentOfWebView):
2155         (webkit_accessible_get_index_in_parent):
2156         (webkit_accessible_get_parent):
2157
2158 2009-11-04  Dominik Röttsches  <dominik.roettsches@access-company.com>
2159
2160         Reviewed by Eric Seidel.
2161
2162         https://bugs.webkit.org/show_bug.cgi?id=15914
2163         [GTK] Implement Unicode functionality using GLib
2164
2165         Initial version of this patch by Jürg Billeter and Naiem Shaik.
2166         Patch 2/4 - Moving TextCodecs to GLib
2167         
2168         Added probing for a hard-coded lists of text encodings.
2169         The basis of this list is taken from the encodings supported by iconv,
2170         then extended by e.g. tis-620, windows-1251, euc-kr, windows-1253 and
2171         a number of Chinese ones.
2172
2173         Probing is necessary with the current design of text codecs
2174         as iconv/GLib do not support enumerating available encodings.
2175
2176         * GNUmakefile.am:
2177         * platform/ThreadGlobalData.cpp:
2178         (WebCore::ThreadGlobalData::ThreadGlobalData):
2179         (WebCore::ThreadGlobalData::~ThreadGlobalData):
2180         * platform/text/TextEncoding.cpp:
2181         (WebCore::TextEncoding::encode):
2182         * platform/text/TextEncodingRegistry.cpp:
2183         (WebCore::buildBaseTextCodecMaps):
2184         (WebCore::extendTextCodecMaps):
2185         * platform/text/gtk/TextCodecGtk.cpp: Added.
2186         (WebCore::):
2187         (WebCore::newTextCodecGtk):
2188         (WebCore::TextCodecGtk::isEncodingAvailable):
2189         (WebCore::TextCodecGtk::registerEncodingNames):
2190         (WebCore::TextCodecGtk::registerCodecs):
2191         (WebCore::TextCodecGtk::registerBaseEncodingNames):
2192         (WebCore::TextCodecGtk::registerBaseCodecs):
2193         (WebCore::TextCodecGtk::registerExtendedEncodingNames):
2194         (WebCore::TextCodecGtk::registerExtendedCodecs):
2195         (WebCore::TextCodecGtk::TextCodecGtk):
2196         (WebCore::TextCodecGtk::~TextCodecGtk):
2197         (WebCore::TextCodecGtk::releaseIConv):
2198         (WebCore::TextCodecGtk::createIConvDecoder):
2199         (WebCore::TextCodecGtk::createIConvEncoder):
2200         (WebCore::TextCodecGtk::decode):
2201         (WebCore::TextCodecGtk::encode):
2202         * platform/text/gtk/TextCodecGtk.h: Added.
2203
2204 2009-11-04  Martin Robinson  <martin.james.robinson@gmail.com>
2205
2206         Reviewed by Jan Alonzo.
2207
2208         [GTK] Enable DOM clipboard and drag-and-drop access
2209         https://bugs.webkit.org/show_bug.cgi?id=30623
2210
2211         Unify redudant methods which will always return the same value.
2212
2213         * platform/gtk/PasteboardGtk.cpp:
2214         (WebCore::Pasteboard::writeSelection):
2215         * platform/gtk/PasteboardHelper.h:
2216
2217 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2218
2219         Reviewed by Jan Alonzo.
2220
2221         https://bugs.webkit.org/show_bug.cgi?id=31035
2222         [GTK] some accessibility tests hitting assertion in debug builds
2223
2224         Removes the assertions in webkit_accessible_ref_child; adds sanity checks.
2225         Any app or AT can attempt to ref a child at a bogus index.
2226
2227         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2228         (webkit_accessible_ref_child):
2229
2230 2009-11-04  Benjamin Otte  <otte@gnome.org>
2231
2232         Reviewed by Jan Alonzo.
2233
2234         [gtk] Use gst_element_class_set_details_simple()
2235
2236         Cosmetic change, just code simplification
2237
2238         * platform/graphics/gtk/VideoSinkGStreamer.cpp:
2239         (webkit_video_sink_base_init):
2240 2009-11-04  Kelly Norton  <knorton@google.com>
2241
2242         Reviewed by Timothy Hatcher.
2243
2244         Adds paint rectangle information to TimelineAgent's didPaint callback.
2245         https://bugs.webkit.org/show_bug.cgi?id=31087
2246
2247         * inspector/InspectorTimelineAgent.cpp:
2248         (WebCore::InspectorTimelineAgent::willPaint):
2249         * inspector/InspectorTimelineAgent.h:
2250         * inspector/TimelineRecordFactory.cpp:
2251         (WebCore::TimelineRecordFactory::createPaintTimelineRecord):
2252         * inspector/TimelineRecordFactory.h:
2253         * page/FrameView.cpp:
2254         (WebCore::FrameView::paintContents):
2255
2256 2009-11-04  Jaime Yap  <jaimeyap@google.com>
2257
2258         Reviewed by Timothy Hatcher.
2259
2260         This patch adds API to the console object for annotating the
2261         inspector timeline. This allows developers to mark logical
2262         checkpoints in their apps and have them overlaid in the event
2263         record tree.
2264
2265         tests updated: LayoutTests/fast/dom/Window/window-properties.html
2266         https://bugs.webkit.org/show_bug.cgi?id=31082
2267
2268
2269         * inspector/InspectorController.cpp:
2270         (WebCore::InspectorController::markTimeline):
2271         * inspector/InspectorController.h:
2272         * inspector/InspectorTimelineAgent.cpp:
2273         (WebCore::InspectorTimelineAgent::didMarkTimeline):
2274         * inspector/InspectorTimelineAgent.h:
2275         (WebCore::):
2276         * inspector/TimelineRecordFactory.cpp:
2277         (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
2278         * inspector/TimelineRecordFactory.h:
2279         * inspector/front-end/TimelineAgent.js:
2280         * page/Console.cpp:
2281         (WebCore::Console::markTimeline):
2282         * page/Console.h:
2283         * page/Console.idl:
2284
2285 2009-11-03  Simon Hausmann  <hausmann@webkit.org>
2286
2287         Unreviewed build fix for WebInspector with Qt build.
2288
2289         Simply re-generate the Qt resource file by running
2290         WebKitTools/Scripts/generate-qt-inspector-resource
2291
2292         * inspector/front-end/WebKit.qrc:
2293
2294 2009-11-02  Benjamin Poulain  <benjamin.poulain@nokia.com>
2295
2296         Reviewed by Simon Hausmann.
2297
2298         [Qt] Handle fonts like the other ports
2299
2300         Remove FontFallbackListQt and rely on the common FontFallbackList
2301         to handle the fonts. FontCache and FontPlatformData have been
2302         updated to work with the common FontFallbackList.
2303
2304         In the previous implementation, FontPlatformDataCacheKey
2305         was a clone of FontPlatformData with the hashing
2306         capabilities added in order to use it as a key in the cache's
2307         hashmap. FontPlatformData has been modified to handle the hashing
2308         function directly so the data are not copied twice in memory.
2309
2310         FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
2311         code from FontCache::getFontData() and FontFallbackList::fontDataAt().
2312         The behavior is similar except currFamily->family().length() was
2313         not tested and the fallback fonts selector were not used.
2314
2315         https://bugs.webkit.org/show_bug.cgi?id=29856
2316
2317         Test: svg/text/text-font-invalid.html
2318
2319         * WebCore.pro:
2320         * platform/graphics/qt/FontCacheQt.cpp:
2321         (WebCore::FontCache::platformInit):
2322         (WebCore::FontCache::getFontDataForCharacters):
2323         (WebCore::FontCache::getSimilarFontPlatformData):
2324         (WebCore::FontCache::getLastResortFallbackFont):
2325         (WebCore::FontCache::getTraitsInFamily):
2326         (WebCore::FontCache::createFontPlatformData):
2327         * platform/graphics/qt/FontFallbackListQt.cpp:
2328         Removed. We now use the implementation from FontFallbackList.cpp
2329         * platform/graphics/qt/FontPlatformData.h:
2330         Add hashing capabilities to be able to use the data with the FontCache.
2331         This was previously done in FontCacheQt.cpp
2332         (WebCore::FontPlatformData::FontPlatformData):
2333         Added a boolean to identify deleted value in the hash table.
2334         (WebCore::FontPlatformData::isHashTableDeletedValue):
2335         (WebCore::FontPlatformData::hash):
2336         (WebCore::FontPlatformData::operator==):
2337         * platform/graphics/qt/FontPlatformDataQt.cpp:
2338         (WebCore::FontPlatformData::FontPlatformData):
2339
2340 2009-11-03  Dan Bernstein  <mitz@apple.com>
2341
2342         Leopard build fix
2343
2344         * platform/network/mac/AuthenticationMac.mm:
2345         (WebCore::mac):
2346         (WebCore::core):
2347
2348 2009-11-03  Dan Bernstein  <mitz@apple.com>
2349
2350         Reviewed by Alexey Proskuryakov.
2351
2352         Fix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
2353         authentication in AuthenticationMac
2354
2355         * platform/network/mac/AuthenticationMac.mm:
2356
2357 2009-11-03  Eric Z. Ayers  <zundel@google.com>
2358
2359         Reviewed by Timothy Hatcher.
2360
2361         Fixes a problem where the timeline instrumentation crashes if
2362         timeline profiling is enabled or disabled in the middle of an
2363         event dispatch.
2364
2365         https://bugs.webkit.org/show_bug.cgi?id=31080
2366
2367         Test: inspector/timeline-trivial.html
2368
2369         * bindings/js/ScriptController.cpp:
2370         (WebCore::ScriptController::evaluateInWorld):
2371         (WebCore::ScriptController::processingUserGestureEvent):
2372         * inspector/InspectorTimelineAgent.cpp:
2373         (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
2374         * page/DOMTimer.cpp:
2375         (WebCore::DOMTimer::fired):
2376
2377 2009-11-03  Dan Bernstein  <mitz@apple.com>
2378
2379         Reviewed by Dave Hyatt.
2380
2381         Allow a frame to go back to copy-on-scroll when it ceases being overlapped
2382
2383         The code was not testing slow-scrolling frames for overlappedness, thinking the answer
2384         would not matter. That is not the case if the only reason for the slow-scrolling is
2385         being overlapped.
2386
2387         * page/FrameView.cpp:
2388         (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): Added. Returns whether there is any
2389         reason besides being overlapped that the frame would need to fully repaint on scroll.
2390         * page/FrameView.h:
2391         * rendering/RenderWidget.cpp:
2392         (WebCore::RenderWidget::paint): Use useSlowRepaintsIfNotOverlapped().
2393
2394 2009-11-03  Dmitry Titov  <dimich@chromium.org>
2395
2396         Not reviewed, Qt build fix.
2397
2398         Need to use right capitalization for include file.
2399
2400         * page/Navigator.cpp:
2401
2402 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
2403
2404         Reviewed by Timothy Hatcher.
2405
2406         Web Inspector: Migrate from top bar filters to check boxes in Timeline.
2407
2408         https://bugs.webkit.org/show_bug.cgi?id=31081
2409
2410         * inspector/front-end/AbstractTimelinePanel.js:
2411         (WebInspector.AbstractTimelinePanel.prototype.showCategory):
2412         (WebInspector.AbstractTimelinePanel.prototype.hideCategory):
2413         (WebInspector.AbstractTimelinePanel.prototype.filter):
2414         * inspector/front-end/TimelinePanel.js:
2415         (WebInspector.TimelinePanel):
2416         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
2417         (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClick):
2418         (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
2419         (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
2420         * inspector/front-end/inspector.css:
2421
2422 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
2423
2424         Reviewed by Timothy Hatcher.
2425
2426         Web Inspector: clear overview on Clear action and panel reset.
2427
2428         https://bugs.webkit.org/show_bug.cgi?id=31078
2429
2430         * inspector/front-end/TimelinePanel.js:
2431         (WebInspector.TimelinePanel.prototype._getRecordDetails):
2432         (WebInspector.TimelinePanel.prototype.reset):
2433
2434 2009-11-03  Yaar Schnitman  <yaar@chromium.org>
2435
2436         Reviewed by Dimitri Glazkov.
2437
2438         Imported action and rules python files that WebCore.gyp depends on. 
2439         These files used to live in chromium.org and deal mostly with auto-generation
2440         of code by wrapping existing webkit perl scripts.
2441
2442         https://bugs.webkit.org/show_bug.cgi?id=31071
2443
2444         * WebCore.gyp/WebCore.gyp: Fixed paths in actions and rules.
2445         * WebCore.gyp/scripts/action_csspropertynames.py: Added.
2446         * WebCore.gyp/scripts/action_cssvaluekeywords.py: Added.
2447         * WebCore.gyp/scripts/action_makenames.py: Added.
2448         * WebCore.gyp/scripts/action_maketokenizer.py: Added.
2449         * WebCore.gyp/scripts/action_useragentstylesheets.py: Added.
2450         * WebCore.gyp/scripts/rule_binding.py: Added.
2451         * WebCore.gyp/scripts/rule_bison.py: Added.
2452         * WebCore.gyp/scripts/rule_gperf.py: Added.
2453
2454 2009-11-03  Bradley Green  <brg@chromium.org>
2455
2456         Reviewed by Dmitry Titov.
2457
2458         Implement window.navigator.registerProtocolHandler in webkit,
2459         https://bugs.webkit.org/b/29651
2460
2461         Also implemented its sister API window.navigator.registerContentHandler.
2462
2463         These methods are as described in the HTML5 specification which can be
2464         found here,
2465         http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler
2466         http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registercontenthandler
2467
2468         As specified in the document, the behavior of the browser is determined
2469         by the current registered handler.  The state of a registered handler
2470         can change at any time, with the user clearing a registered handler,
2471         registering a different page as handler, or deferring the hander to the
2472         OS.  If webkit was to track the state of the currently registered
2473         handlers, it would need more APIs and complexity to keep in sync with
2474         user actions reported to webkit from the UA.  For simplicity, the state
2475         of protocol handlers should be kept isolated from webkit and webkit only
2476         notifies the UA that a page has made the call.  The UA is then
2477         responsible for correctly handling the registerProtocolHandler call and
2478         the redirects which result from registration.
2479
2480         We do however follow the specification in insuring that the reserved
2481         schemes and mimeTypes are not passed to the UA as custom handler
2482         registration tests.  We also insure that the "%s" token is present as
2483         required by the specification.
2484
2485         Updated test expectations for window.clientInformation and navigator
2486         objects.
2487
2488         Tests: fast/dom/registerContentHandler.html
2489                fast/dom/registerProtocolHandler.html
2490
2491         * page/Chrome.cpp:
2492         (WebCore::Chrome::registerProtocolHandler):
2493         (WebCore::Chrome::registerContentHandler):
2494         * page/Chrome.h:
2495         * page/ChromeClient.h:
2496         (WebCore::ChromeClient::registerProtocolHandler):
2497         (WebCore::ChromeClient::registerContentHandler):
2498         * page/Navigator.cpp:
2499         (WebCore::verifyCustomHandlerURL):
2500         (WebCore::verifyProtocolHandlerScheme):
2501         (WebCore::Navigator::registerProtocolHandler):
2502         (WebCore::verifyProtocolHandlerMimeType):
2503         (WebCore::Navigator::registerContentHandler):
2504         * page/Navigator.h:
2505         * page/Navigator.idl:
2506
2507 2009-11-03  Brady Eidson  <beidson@apple.com>
2508
2509         Reviewed by Darin Adler.
2510
2511         https://bugs.webkit.org/show_bug.cgi?id=31079 - Remove #include "Page.h" from Document.h
2512
2513         No new tests. (No change in functionality)
2514
2515         * dom/Document.cpp:
2516         (WebCore::Document::inspectorTimelineAgent): Moved from Document.h
2517         * dom/Document.h:
2518
2519         Include "Page.h" directly:
2520         * html/HTMLVideoElement.cpp:
2521         * loader/RedirectScheduler.cpp:
2522         * page/History.cpp:
2523         * rendering/MediaControlElements.cpp:
2524         * storage/StorageAreaImpl.cpp:
2525
2526 2009-11-03  Keishi Hattori  <casey.hattori@gmail.com>
2527
2528         Reviewed by Timothy Hatcher.
2529
2530         Web Inspector: hover over JS "things" in source and see their values
2531         https://bugs.webkit.org/show_bug.cgi?id=30913
2532
2533         * inspector/front-end/SourceFrame.js:
2534
2535 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
2536
2537         Reviewed by Timothy Hatcher.
2538
2539         Web Inspector: update timeline content boundaries on timer.
2540
2541         https://bugs.webkit.org/show_bug.cgi?id=31072
2542
2543         * inspector/front-end/TimelinePanel.js:
2544         (WebInspector.TimelinePanel.prototype.refresh):
2545         (WebInspector.TimelinePanel.prototype._setWindowPosition):
2546
2547 2009-11-03  Dan Bernstein  <mitz@apple.com>
2548
2549         Reviewed by Anders Carlsson and Beth Dakin.
2550
2551         https://bugs.webkit.org/show_bug.cgi?id=31070
2552         Fix <rdar://problem/7194735> Crashes at RenderText::RenderText()
2553         Fix <rdar://problem/6937089> Crashes at RenderWidget::destroy()
2554
2555         Tests: plugins/attach-during-destroy.html
2556                plugins/destroy-reentry.html
2557
2558         These crashes were caused by plug-in code running during detach(),
2559         causing re-entry into RenderWidget::destroy() in one case and a call
2560         into attach() in the other. The fix is to prevent plug-in code from
2561         being called at certain unsafe times (during attach(), detach(), and
2562         recalcStyle()) by deferring changes to the widget hierarchy.
2563
2564         * dom/Document.cpp:
2565         (WebCore::Document::recalcStyle): Suspend widget hierarchy updates
2566             during style recalculation.
2567
2568         * dom/Element.cpp:
2569         (WebCore::Element::attach): Suspend widget hierarchy updates during
2570             attach().
2571         (WebCore::Element::detach): Suspend widget hierarchy updates during
2572             detach().
2573
2574         * rendering/RenderWidget.cpp:
2575         (WebCore::widgetNewParentMap): Returns a static map of pending changes
2576             to the widget hierarchy.
2577         (WebCore::RenderWidget::suspendWidgetHierarchyUpdates): Increments the
2578             suspend count.
2579         (WebCore::RenderWidget::resumeWidgetHierarchyUpdates): Decrements the
2580             suspend count. If the count is going to be zero, updates the widget
2581             hierarchy by executing the pending changes stored in the map.
2582         (WebCore::moveWidgetToParentSoon): Updates the widget hierarchy
2583             immediately or makes or updates an entry in the map, depending on
2584             whether updates are suspended.
2585         (WebCore::RenderWidget::destroy): Removed earlier bandaid fix for
2586             <rdar://problem/6937089>.
2587         (WebCore::RenderWidget::setWidgetGeometry): Assert that widget updates
2588             are not suspended, because this function updates the widget’s
2589             bounds, which can result in arbitrary native and JavaScript code
2590             execution. I think this assertion is true thanks to some deferred-
2591             update mechanisms that have already been deployed in other places
2592             in the code.
2593         (WebCore::RenderWidget::setWidget): Call moveWidgetToParentSoon instead
2594             of changing the widget hierarchy directly.
2595         * rendering/RenderWidget.h: Declared suspendWidgetHierarchyUpdates()
2596             and resumeWidgetHierarchyUpdates().
2597
2598 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
2599
2600         Reviewed by Timothy Hatcher.
2601
2602         Web Inspector: only show timeline records that contribute
2603         to the current window.
2604
2605         https://bugs.webkit.org/show_bug.cgi?id=31069
2606
2607         * inspector/front-end/TimelinePanel.js:
2608         (WebInspector.TimelinePanel.prototype.refresh):
2609         (WebInspector.TimelineGraph):
2610         (WebInspector.TimelineGraph.prototype.refresh):
2611
2612 2009-11-03  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
2613
2614         Reviewed by Timothy Hatcher.
2615
2616         Watch expression editor should stay open after Add button was clicked
2617         https://bugs.webkit.org/show_bug.cgi?id=31049
2618
2619         No new tests, was a regression, use existing manual test.
2620
2621         * inspector/front-end/WatchExpressionsSidebarPane.js:
2622         (WebInspector.WatchExpressionsSection.prototype.update):
2623         (WebInspector.WatchExpressionsSection.prototype.addExpression):
2624
2625 2009-11-03  Evan Martin  <evan@chromium.org>
2626
2627         Reviewed by Darin Adler.
2628
2629         Fix an off-by-one in the CSS lexer that causes memory corruption in
2630         hard-to-trigger circumstances.
2631
2632         https://bugs.webkit.org/show_bug.cgi?id=30827
2633
2634         Test: fast/css/end-of-buffer-crash.html
2635
2636         * css/maketokenizer: Add comments, fix off-by-one.
2637
2638 2009-11-02  Darin Adler  <darin@apple.com>
2639
2640         Reviewed by Dan Bernstein.
2641
2642         Crash due to double-destroy related to CSS run-in property
2643         https://bugs.webkit.org/show_bug.cgi?id=31034
2644         rdar://problem/7328458
2645
2646         Test: fast/css/run-in-crash.html
2647
2648         * rendering/RenderBlock.cpp:
2649         (WebCore::RenderBlock::destroy): Reorder destruction so the
2650         continuation is destroyed after anonymous children. See comment
2651         in the code for more details of why this is right.
2652         * rendering/RenderInline.cpp:
2653         (WebCore::RenderInline::destroy): Ditto.
2654
2655 2009-11-03  Alexander Pavlov  <apavlov@chromium.org>
2656
2657         Reviewed by Pavel Feldman.
2658
2659         Fix exception in ElementsPanel.js when moving pointer out of crumbs and window
2660
2661         There might be no new node under mouse if the pointer is moved out of the window
2662         in which case we get an exception.
2663         https://bugs.webkit.org/show_bug.cgi?id=31061
2664
2665         * inspector/front-end/ElementsPanel.js:
2666         (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
2667
2668 2009-11-03  Zoltan Horvath  <zoltan@webkit.org>
2669
2670         Reviewed by Darin Adler.
2671
2672         Allow custom memory allocation control for the dom directory of WebCore
2673         https://bugs.webkit.org/show_bug.cgi?id=31053
2674
2675         Inherits the following classes from Noncopyable because these are
2676         instantiated by 'new' and these are no need to be copyable:
2677
2678         class EventNames - 'new' call: WebCore/platform/ThreadGlobalData.cpp:73
2679         struct PerformTaskContext - 'new' call: WebCore/dom/Document.cpp:4581
2680         class EventData - 'new' call: WebCore/dom/MessagePortChannel.cpp:38
2681         struct NodeListsNodeData - 'new' call: WebCore/dom/NodeRareData.h:51 
2682         struct EventTargetData - 'new' call: WebCore/dom/NodeRareData.h:100
2683         class NodeRareData - 'new' call: WebCore/dom/Node.cpp:552
2684
2685         Inherits QualifiedName class from FastAllocBase because it is
2686         instantiated by 'new' in WebCore/editing/markup.cpp:319
2687
2688         * dom/Document.cpp:
2689         * dom/EventNames.h:
2690         * dom/EventTarget.h:
2691         * dom/MessagePortChannel.h:
2692         * dom/NodeRareData.h:
2693         * dom/QualifiedName.h:
2694
2695 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
2696
2697         Reviewed by Timothy Hatcher.
2698
2699         Web Inspector: Implement timeline summary panel.
2700
2701         https://bugs.webkit.org/show_bug.cgi?id=31064
2702
2703         * inspector/front-end/TimelinePanel.js:
2704         (WebInspector.TimelinePanel.prototype._createOverview):
2705         (WebInspector.TimelinePanel.prototype.refresh):
2706         (WebInspector.TimelineCategoryGraph):
2707         (WebInspector.TimelineCategoryGraph.prototype.get graphElement):
2708         (WebInspector.TimelineCategoryGraph.prototype.addChunk):
2709         (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
2710         (WebInspector.TimelineGraph.prototype.refresh):
2711         * inspector/front-end/inspector.css:
2712
2713 2009-11-03  Alexander Pavlov  <apavlov@chromium.org>
2714
2715         Reviewed by Timothy Hatcher.
2716
2717         Toggle off 'Search for node' when the Inspector window is closing
2718
2719         Searching for node should be toggled off when the Inspector window is closed,
2720         in a platform-independent manner.
2721         https://bugs.webkit.org/show_bug.cgi?id=31059
2722
2723         * inspector/InspectorController.cpp:
2724         (WebCore::InspectorController::setWindowVisible):
2725
2726 2009-11-03  Mikhail Naganov  <mnaganov@chromium.org>
2727
2728         Reviewed by Timothy Hatcher.
2729
2730         Prepare for heap profiles upstreaming:
2731         - pass profile type id from InspectorController;
2732         - this makes WebInspector.CPUProfile redundant---removed;
2733         - support multiple profile types when populating profiles.
2734
2735         https://bugs.webkit.org/show_bug.cgi?id=31052
2736
2737         * inspector/InspectorController.cpp:
2738         (WebCore::InspectorController::createProfileHeader):
2739         * inspector/front-end/ProfileView.js:
2740         (WebInspector.CPUProfileView.profileCallback):
2741         (WebInspector.CPUProfileView):
2742         (WebInspector.CPUProfileView.prototype._sortData):
2743         * inspector/front-end/ProfilesPanel.js:
2744         (WebInspector.ProfilesPanel.prototype.addProfileHeader):
2745         * inspector/front-end/inspector.js:
2746         (WebInspector.addProfileHeader):
2747
2748 2009-11-03  Dan Kegel  <dank@chromium.org>
2749
2750         Reviewed by Dimitri Glazkov.
2751
2752         UMR in WebCore::AccessibilityRenderObject::children(); m_childrenDirty uninitialized in constructor
2753         https://bugs.webkit.org/show_bug.cgi?id=31063
2754
2755         * accessibility/AccessibilityRenderObject.cpp:
2756         (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
2757
2758 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
2759
2760         Reviewed by Timothy Hatcher.
2761
2762         Web Inspector: Implement Timeline Window, wire it to the bottom timeline.
2763
2764         https://bugs.webkit.org/show_bug.cgi?id=31056
2765
2766         * English.lproj/localizedStrings.js:
2767         * inspector/front-end/AbstractTimelinePanel.js:
2768         (WebInspector.AbstractTimelinePanel.prototype.get items):
2769         (WebInspector.AbstractTimelinePanel.prototype.createInterface):
2770         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
2771         (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition):
2772         (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
2773         (WebInspector.AbstractTimelinePanel.prototype.refresh):
2774         (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition):
2775         (WebInspector.AbstractTimelinePanel.prototype.addExtraDivider):
2776         (WebInspector.TimelineGrid):
2777         (WebInspector.TimelineGrid.prototype.get itemsGraphsElement):
2778         (WebInspector.TimelineGrid.prototype.updateDividers):
2779         (WebInspector.TimelineGrid.prototype.addExtraDivider):
2780         (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
2781         * inspector/front-end/ResourcesPanel.js:
2782         (WebInspector.ResourcesPanel):
2783         (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
2784         (WebInspector.ResourcesPanel.prototype.get _resources):
2785         * inspector/front-end/TimelinePanel.js:
2786         (WebInspector.TimelinePanel):
2787         (WebInspector.TimelinePanel.prototype.get categories):
2788         (WebInspector.TimelinePanel.prototype._formatRecord):
2789         (WebInspector.TimelinePanel.prototype.reset):
2790         (WebInspector.TimelinePanel.prototype._createOverview):
2791         (WebInspector.TimelinePanel.prototype.setSidebarWidth):
2792         (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
2793         (WebInspector.TimelinePanel.prototype.updateGraphDividersIfNeeded):
2794         (WebInspector.TimelinePanel.prototype.refresh):
2795         (WebInspector.TimelinePanel.prototype._resizeWindow):
2796         (WebInspector.TimelinePanel.prototype._windowResizeDragging):
2797         (WebInspector.TimelinePanel.prototype._dragWindow):
2798         (WebInspector.TimelinePanel.prototype._windowDragging):
2799         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
2800         (WebInspector.TimelinePanel.prototype._resizeWindowRight):
2801         (WebInspector.TimelinePanel.prototype._setWindowPosition):
2802         (WebInspector.TimelinePanel.prototype._endWindowDragging):
2803         (WebInspector.TimelineCategoryTreeElement):
2804         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
2805         (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
2806         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
2807         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
2808         (WebInspector.TimelineCalculator.prototype.reset):
2809         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
2810         (WebInspector.TimelineCalculator.prototype.formatValue):
2811         * inspector/front-end/inspector.css:
2812
2813 2009-11-03  Simon Hausmann  <hausmann@webkit.org>
2814
2815         Reviewed by Tor Arne Vestbø.
2816
2817         Make QWebPluginDatabase private API for now.
2818
2819         https://bugs.webkit.org/show_bug.cgi?id=30775
2820
2821         * WebCore.pro:
2822
2823 2009-11-03  Simon Hausmann  <hausmann@webkit.org>
2824
2825         Reviewed by Tor Arne Vestbø.
2826
2827         Extended the conversion of the WebCore ResourceRequest to the
2828         QNetworkRequest with a mandatory originating object argument,
2829         which is meant to be the QWebFrame the request belongs to.
2830
2831         https://bugs.webkit.org/show_bug.cgi?id=29975
2832
2833         * platform/network/qt/QNetworkReplyHandler.cpp:
2834         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
2835         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2836         (WebCore::QNetworkReplyHandler::start):
2837         * platform/network/qt/ResourceRequest.h:
2838         * platform/network/qt/ResourceRequestQt.cpp:
2839         (WebCore::ResourceRequest::toNetworkRequest):
2840
2841 2009-11-03  Keishi Hattori  <casey.hattori@gmail.com>
2842
2843         Reviewed by Pavel Feldman.
2844
2845         Web Inspector: monitorEvent should be monitorEvents
2846         https://bugs.webkit.org/show_bug.cgi?id=31042
2847
2848         * inspector/front-end/InjectedScript.js:
2849         (InjectedScript._ensureCommandLineAPIInstalled):
2850
2851 2009-11-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2852
2853         Rubber-stamped by Antti Koivisto.
2854
2855         [Qt] Build fix for Windows CE
2856
2857         * plugins/PluginDatabase.cpp:
2858
2859 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2860
2861         Reviewed by David Levin.
2862
2863         fix accessibility webkit-style-check errors
2864         https://bugs.webkit.org/show_bug.cgi?id=29672
2865
2866         * accessibility/AXObjectCache.cpp:
2867         (WebCore::AXObjectCache::getOrCreate):
2868         (WebCore::AXObjectCache::remove):
2869         (WebCore::AXObjectCache::platformGenerateAXID):
2870         (WebCore::AXObjectCache::removeAXID):
2871         * accessibility/AXObjectCache.h:
2872         (WebCore::AXObjectCache::enableAccessibility):
2873         (WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility):
2874         (WebCore::AXObjectCache::accessibilityEnabled):
2875         (WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
2876         (WebCore::AXObjectCache::isIDinUse):
2877         (WebCore::AXObjectCache::objectFromAXID):
2878         (WebCore::AXObjectCache::):
2879         (WebCore::AXObjectCache::handleActiveDescendantChanged):
2880         (WebCore::AXObjectCache::handleAriaRoleChanged):
2881         (WebCore::AXObjectCache::detachWrapper):
2882         (WebCore::AXObjectCache::attachWrapper):
2883         (WebCore::AXObjectCache::selectedChildrenChanged):
2884         (WebCore::AXObjectCache::postNotification):
2885         (WebCore::AXObjectCache::postPlatformNotification):
2886         (WebCore::AXObjectCache::handleFocusedUIElementChanged):
2887         (WebCore::AXObjectCache::handleScrolledToAnchor):
2888         * accessibility/AccessibilityARIAGrid.cpp:
2889         (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
2890         * accessibility/AccessibilityAllInOne.cpp:
2891         * accessibility/AccessibilityImageMapLink.cpp:
2892         * accessibility/AccessibilityList.h:
2893         (WebCore::AccessibilityList::isList):
2894         * accessibility/AccessibilityListBox.cpp:
2895         * accessibility/AccessibilityListBox.h:
2896         (WebCore::AccessibilityListBox::isListBox):
2897         * accessibility/AccessibilityListBoxOption.cpp:
2898         * accessibility/AccessibilityListBoxOption.h:
2899         (WebCore::AccessibilityListBoxOption::isListBoxOption):
2900         * accessibility/AccessibilityMediaControls.h:
2901         (WebCore::AccessibilityMediaControl::~AccessibilityMediaControl):
2902         (WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline):
2903         (WebCore::AccessibilityMediaTimeline::isMediaTimeline):
2904         (WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer):
2905         (WebCore::AccessibilityMediaControlsContainer::roleValue):
2906         (WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored):
2907         (WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay):
2908         (WebCore::AccessibilityMediaTimeDisplay::roleValue):
2909         * accessibility/AccessibilityObject.cpp:
2910         (WebCore::AccessibilityObject::parentObjectUnignored):
2911         (WebCore::AccessibilityObject::rightLineVisiblePositionRange):
2912         (WebCore::replacedNodeNeedsCharacter):
2913         (WebCore::AccessibilityObject::stringForVisiblePositionRange):
2914         (WebCore::AccessibilityObject::lengthForVisiblePositionRange):
2915         (WebCore::AccessibilityObject::actionVerb):
2916         * accessibility/AccessibilityObject.h:
2917         (WebCore::PlainTextRange::isNull):
2918         (WebCore::AccessibilityObject::isAccessibilityRenderObject):
2919         (WebCore::AccessibilityObject::isAnchor):
2920         (WebCore::AccessibilityObject::isAttachment):
2921         (WebCore::AccessibilityObject::isHeading):
2922         (WebCore::AccessibilityObject::isLink):
2923         (WebCore::AccessibilityObject::isImage):
2924         (WebCore::AccessibilityObject::isNativeImage):
2925         (WebCore::AccessibilityObject::isImageButton):
2926         (WebCore::AccessibilityObject::isPasswordField):
2927         (WebCore::AccessibilityObject::isTextControl):
2928         (WebCore::AccessibilityObject::isNativeTextControl):
2929         (WebCore::AccessibilityObject::isWebArea):
2930         (WebCore::AccessibilityObject::isCheckboxOrRadio):
2931         (WebCore::AccessibilityObject::isListBox):
2932         (WebCore::AccessibilityObject::isFileUploadButton):
2933         (WebCore::AccessibilityObject::isProgressIndicator):
2934         (WebCore::AccessibilityObject::isSlider):
2935         (WebCore::AccessibilityObject::isControl):
2936         (WebCore::AccessibilityObject::isList):
2937         (WebCore::AccessibilityObject::isDataTable):
2938         (WebCore::AccessibilityObject::isTableRow):
2939         (WebCore::AccessibilityObject::isTableColumn):
2940         (WebCore::AccessibilityObject::isTableCell):
2941         (WebCore::AccessibilityObject::isFieldset):
2942         (WebCore::AccessibilityObject::isGroup):
2943         (WebCore::AccessibilityObject::isChecked):
2944         (WebCore::AccessibilityObject::isEnabled):
2945         (WebCore::AccessibilityObject::isSelected):
2946         (WebCore::AccessibilityObject::isFocused):
2947         (WebCore::AccessibilityObject::isHovered):
2948         (WebCore::AccessibilityObject::isIndeterminate):
2949         (WebCore::AccessibilityObject::isLoaded):
2950         (WebCore::AccessibilityObject::isMultiSelect):
2951         (WebCore::AccessibilityObject::isOffScreen):
2952         (WebCore::AccessibilityObject::isPressed):
2953         (WebCore::AccessibilityObject::isReadOnly):
2954         (WebCore::AccessibilityObject::isVisited):
2955         (WebCore::AccessibilityObject::isRequired):
2956         (WebCore::AccessibilityObject::canSetFocusAttribute):
2957         (WebCore::AccessibilityObject::canSetTextRangeAttributes):
2958         (WebCore::AccessibilityObject::canSetValueAttribute):
2959         (WebCore::AccessibilityObject::hasIntValue):
2960         (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
2961         (WebCore::AccessibilityObject::accessibilityIsIgnored):
2962         * accessibility/AccessibilityRenderObject.cpp:
2963         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
2964         (WebCore::AccessibilityRenderObject::parentObject):
2965         (WebCore::AccessibilityRenderObject::isMenuRelated):
2966         (WebCore::AccessibilityRenderObject::accessibilityDescription):
2967         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2968         (WebCore::AccessibilityRenderObject::isFocused):
2969         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
2970         (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
2971         (WebCore::AccessibilityRenderObject::doAXRangeForLine):
2972         (WebCore::AccessibilityRenderObject::doAXStringForRange):
2973         (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
2974         (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
2975         (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
2976         (WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole):
2977         (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
2978         (WebCore::AccessibilityRenderObject::canHaveChildren):
2979         (WebCore::AccessibilityRenderObject::actionVerb):
2980         (WebCore::shouldReturnTagNameAsRoleForMSAA):
2981         * accessibility/AccessibilityRenderObject.h:
2982         (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
2983         * accessibility/AccessibilitySlider.cpp:
2984         (WebCore::AccessibilitySlider::orientation):
2985         * accessibility/AccessibilitySlider.h:
2986         (WebCore::AccessibilitySlider::~AccessibilitySlider):
2987         (WebCore::AccessibilitySlider::roleValue):
2988         (WebCore::AccessibilitySlider::accessibilityIsIgnored):
2989         (WebCore::AccessibilitySlider::isSlider):
2990         (WebCore::AccessibilitySlider::canSetValueAttribute):
2991         (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
2992         (WebCore::AccessibilitySliderThumb::roleValue):
2993         (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
2994         (WebCore::AccessibilitySliderThumb::setParentObject):
2995         (WebCore::AccessibilitySliderThumb::parentObject):
2996         * accessibility/AccessibilityTable.cpp:
2997         (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
2998         * accessibility/AccessibilityTableColumn.cpp:
2999         * accessibility/AccessibilityTableHeaderContainer.cpp:
3000         (WebCore::AccessibilityTableHeaderContainer::addChildren):
3001         * accessibility/AccessibilityTableRow.cpp:
3002         * accessibility/mac/AccessibilityObjectWrapper.h:
3003
3004 2009-11-02  Darin Fisher  <darin@chromium.org>
3005
3006         Fixing JSC build bustage.
3007
3008         * bindings/js/ScriptController.cpp: Added missing #include
3009
3010 2009-10-30  Darin Fisher  <darin@chromium.org>
3011
3012         Reviewed by Adam Barth.
3013
3014         Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled.
3015         https://bugs.webkit.org/show_bug.cgi?id=30967
3016
3017         * bindings/js/ScriptController.cpp:
3018         (WebCore::ScriptController::isEnabled):
3019         * bindings/v8/ScriptController.cpp:
3020         (WebCore::ScriptController::isEnabled):
3021         * bindings/v8/V8Proxy.cpp: Move implementation of isEnabled to ScriptController
3022         * bindings/v8/V8Proxy.h: Ditto
3023         * loader/FrameLoaderClient.h:
3024         (WebCore::FrameLoaderClient::allowJavaScript):
3025         * platform/chromium/ChromiumBridge.h: Delete uiResourceProtocol function
3026
3027 2009-11-02  Brady Eidson  <beidson@apple.com>
3028
3029         Rubberstamped by Mark Rowe.
3030
3031         Fix a typo in Mark's last commit.
3032
3033         * loader/archive/ArchiveFactory.cpp:
3034         (WebCore::archiveMIMETypes):
3035
3036 2009-11-02  Mark Rowe  <mrowe@apple.com>
3037
3038         Rubber-stamped by Brady Eidson.
3039
3040         Re-enable support for web archives on Windows.  It was mistakenly disabled in r50438.
3041
3042         * loader/archive/ArchiveFactory.cpp:
3043         (WebCore::archiveMIMETypes):
3044
3045 2009-11-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3046
3047         Reviewed by Darin Adler.
3048
3049         PLATFORM(CF) should be set when building for Qt on Darwin
3050         https://bugs.webkit.org/show_bug.cgi?id=23671
3051
3052         * WebCore.pro: Add SharedBufferCF.cpp and SmartReplaceCF.cpp
3053         to the Darwin build.
3054         * loader/archive/ArchiveFactory.cpp: Change the support for 
3055         legacy WebArchive from all CF platforms to Mac and Chromium 
3056         CF platforms.
3057         (WebCore::archiveMIMETypes):
3058         * platform/text/AtomicString.h: Remove PLATFORM(QT) &&
3059         PLATFORM(DARWIN) test as it is redundant now.
3060         * platform/text/PlatformString.h: Ditto.
3061         * platform/text/StringImpl.h: Ditto.
3062         * platform/text/cf/StringCF.cpp: Ditto.
3063         * platform/text/cf/StringImplCF.cpp: Ditto.
3064
3065 2009-11-02  Adam Barth  <abarth@webkit.org>
3066
3067         Reviewed by David Levin.
3068
3069         [Chromium] Actually declare getPluginMimeTypeFromExtension in a header.
3070         https://bugs.webkit.org/show_bug.cgi?id=30985
3071
3072         Our current code does not conform to our style guide.
3073
3074         * WebCore.gyp/WebCore.gyp:
3075         * WebCore.gypi:
3076         * platform/chromium/MIMETypeRegistryChromium.cpp:
3077         * plugins/chromium/PluginDataChromium.cpp:
3078         * plugins/chromium/PluginDataChromium.h: Added.
3079
3080 2009-11-02  Adele Peterson  <adele@apple.com>
3081
3082         Reviewed by Darin Adler.
3083
3084         Fix for <rdar://problem/7038305> REGRESSION (Safari 4.0.2 - ToT): After navigating back to a known phishy page, the "Ignore warning" button appears highlighted (along with the "Go Back" button)
3085
3086         This bug is timing dependent, and not always reproducible.  I could not think of a way to add a 
3087         layout test that would demonstrate the problem and fix.
3088
3089         * platform/mac/ThemeMac.mm:
3090         (WebCore::checkbox): Update style.
3091         (WebCore::paintCheckbox): ditto.
3092         (WebCore::radio): ditto.
3093         (WebCore::paintRadio): ditto.
3094         (WebCore::setupButtonCell): Added convenience method.
3095         (WebCore::button): Use a separate NSButtonCell for defaultButtons and regular buttons.
3096         (WebCore::paintButton): Don't check for the key window here.  Consider that when deciding if the button should have the default style in RenderTheme.
3097         * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isDefault): Only consider a button to be default if the page is active.  This fixes 
3098         a problem I noticed where the button would flicker crazily if the page with the default button was in the background.
3099
3100 2009-11-02  Dan Bernstein  <mitz@apple.com>
3101
3102         Reviewed by Anders Carlsson.
3103
3104         Minor RenderWidget clean-up in preparation for deferring widget tree
3105         mutation when it is not safe.
3106
3107         * rendering/RenderWidget.cpp:
3108         (WebCore::RenderWidget::RenderWidget): Initialize m_refCount to 1
3109         instead of calling ref().
3110         (WebCore::RenderWidget::destroy): Call setWidget(0) instead of
3111         repeating what it does.
3112         (WebCore::RenderWidget::setWidgetGeometry): Now returns a boolean
3113         indicating whether the bounds have changed.
3114         (WebCore::RenderWidget::setWidget): Replaced all-encompassing if
3115         statement with an early return.
3116         (WebCore::RenderWidget::updateWidgetPosition): Call setWidgetGeometry().
3117         * rendering/RenderWidget.h:
3118
3119 2009-11-02  Dumitru Daniliuc  <dumi@chromium.org>
3120
3121         Reviewed by Dimitri Glazkov.
3122
3123         Adding Chromium's DatabaseTracker and SQLTransactionClient
3124         implementations.
3125
3126         https://bugs.webkit.org/show_bug.cgi?id=30701
3127
3128         * storage/chromium: Added.
3129         * storage/chromium/DatabaseObserver.h: Added.
3130         * storage/chromium/DatabaseTrackerChromium.cpp: Added.
3131         * storage/chromium/QuotaTracker.cpp: Added.
3132         * storage/chromium/QuotaTracker.h: Added.
3133         * storage/chromium/SQLTransactionClientChromium.cpp: Added.
3134
3135 2009-11-02  Enrica Casucci  <enrica@apple.com>
3136
3137         Reviewed by Adele Peterson and Dan Bernstein.
3138
3139         Safari crashes when calling execCommand on formatted html in special case
3140         <rdar://problem/7318656>
3141         https://bugs.webkit.org/show_bug.cgi?id=31023
3142
3143         Test: editing/execCommand/align-in-span.html
3144
3145         * rendering/RenderObject.cpp:
3146         (WebCore::RenderObject::containingBlock): Modified comment on containingBlock returning NULL.
3147         * rendering/RenderText.cpp:
3148         (WebCore::RenderText::setSelectionState): Added check for NULL return from containingBlock,
3149         since it is possible when dealing with orphaned trees.
3150
3151 2009-11-02  Chris Marrin  <cmarrin@apple.com>
3152
3153         Reviewed by Oliver Hunt.
3154
3155         Exception checks were being too aggressive
3156         https://bugs.webkit.org/show_bug.cgi?id=31005
3157
3158         Several calls in CanvasRenderingContext3D are allowed to
3159         have a null value passed, which indicated that the 
3160         object is being unbound. Handle this case and the corresponding
3161         null handling in GraphicsContext3DMac.
3162
3163         * html/canvas/CanvasRenderingContext3D.cpp:
3164         (WebCore::CanvasRenderingContext3D::bindBuffer):
3165         (WebCore::CanvasRenderingContext3D::bindFramebuffer):
3166         (WebCore::CanvasRenderingContext3D::bindRenderbuffer):
3167         (WebCore::CanvasRenderingContext3D::bindTexture):
3168         (WebCore::CanvasRenderingContext3D::framebufferRenderbuffer):
3169         (WebCore::CanvasRenderingContext3D::framebufferTexture2D):
3170         * platform/graphics/mac/GraphicsContext3DMac.cpp:
3171         (WebCore::GraphicsContext3D::framebufferRenderbuffer):
3172         (WebCore::GraphicsContext3D::framebufferTexture2D):
3173
3174 2009-11-02  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3175
3176         Reviewed by Timothy Hatcher.
3177
3178         Each JS execution in console adds extra item into "scripts" combo
3179         https://bugs.webkit.org/show_bug.cgi?id=30212
3180
3181         Added manual test
3182
3183         * inspector/front-end/ScriptsPanel.js:
3184         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
3185         * manual-tests/inspector/hidden-evals.html: Added.
3186
3187 2009-11-02  Kelly Norton  <knorton@google.com>
3188
3189         Reviewed by Timothy Hatcher.
3190
3191         Adds a missed case for InspectorTimeline, DOMWindow dispatch of DOM events.
3192         https://bugs.webkit.org/show_bug.cgi?id=31030
3193
3194         * dom/Node.cpp:
3195         (WebCore::eventHasListeners): Checks DOMWindow for listeners.
3196         (WebCore::Node::dispatchGenericEvent):
3197
3198 2009-11-02  Dmitry Titov  <dimich@chromium.org>
3199
3200         Reviewed by David Levin.
3201
3202         Remove threadsafe refcounting from tasks used with WTF::MessageQueue.
3203         https://bugs.webkit.org/show_bug.cgi?id=30612
3204
3205         No new tests since no new functionality. Storage, MessagePorts and Workers tests cover this.
3206
3207         There are a lot of files but most changes are simply replace RefPtr and PassRefPtr with
3208         OwnPtr and PassOwnPtr when dealing with Tasks.
3209
3210         ScriptExecutionContext::Task, DatabaseTask and WorkerRunLoop::Task are no longer
3211         threadsafe refcounted, but simply Noncopyable.
3212
3213         * dom/Document.cpp:
3214         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
3215         (WebCore::PerformTaskContext::PerformTaskContext):
3216         (WebCore::Document::postTask):
3217         * dom/Document.h:
3218         * dom/ScriptExecutionContext.cpp:
3219         (WebCore::ProcessMessagesSoonTask::create):
3220         * dom/ScriptExecutionContext.h:
3221         * dom/default/PlatformMessagePortChannel.cpp:
3222         (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
3223         * dom/default/PlatformMessagePortChannel.h:
3224         (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
3225         (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
3226         * loader/FrameLoader.cpp:
3227         (WebCore::HashChangeEventTask::create):
3228         * loader/appcache/ApplicationCacheGroup.cpp:
3229         (WebCore::CallCacheListenerTask::create):
3230         * storage/Database.cpp:
3231         (WebCore::Database::openAndVerifyVersion):
3232         (WebCore::Database::markAsDeletedAndClose):
3233         (WebCore::Database::scheduleTransaction):
3234         (WebCore::Database::scheduleTransactionStep):
3235         (WebCore::Database::tableNames):
3236         * storage/DatabaseTask.h:
3237         (WebCore::DatabaseOpenTask::create):
3238         (WebCore::DatabaseCloseTask::create):
3239         (WebCore::DatabaseTransactionTask::create):
3240         (WebCore::DatabaseTableNamesTask::create):
3241         * storage/DatabaseThread.cpp:
3242         (WebCore::DatabaseThread::databaseThread):
3243         (WebCore::DatabaseThread::scheduleTask):
3244         (WebCore::DatabaseThread::scheduleImmediateTask):
3245         (WebCore::SameDatabasePredicate::operator()):
3246         * storage/DatabaseThread.h:
3247         * storage/LocalStorageTask.h:
3248         (WebCore::LocalStorageTask::createImport):
3249         (WebCore::LocalStorageTask::createSync):
3250         (WebCore::LocalStorageTask::createTerminate):
3251         * storage/LocalStorageThread.cpp:
3252         (WebCore::LocalStorageThread::localStorageThread):
3253         * storage/LocalStorageThread.h:
3254         * websockets/WebSocket.cpp:
3255         (WebCore::ProcessWebSocketEventTask::create):
3256         * workers/DefaultSharedWorkerRepository.cpp:
3257         (WebCore::SharedWorkerProxy::postTaskToLoader):
3258         (WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
3259         (WebCore::SharedWorkerConnectTask::create):
3260         * workers/GenericWorkerTask.h:
3261         (WebCore::GenericWorkerTask1::create):
3262         (WebCore::GenericWorkerTask2::create):
3263         (WebCore::GenericWorkerTask3::create):
3264         (WebCore::GenericWorkerTask4::create):
3265         (WebCore::GenericWorkerTask5::create):
3266         (WebCore::GenericWorkerTask6::create):
3267         (WebCore::GenericWorkerTask7::create):
3268         (WebCore::GenericWorkerTask8::create):
3269         (WebCore::createCallbackTask):
3270         * workers/WorkerContext.cpp:
3271         (WebCore::WorkerContext::postTask):
3272         * workers/WorkerContext.h:
3273         * workers/WorkerLoaderProxy.h:
3274         * workers/WorkerMessagingProxy.cpp:
3275         (WebCore::MessageWorkerContextTask::create):
3276         (WebCore::MessageWorkerTask::create):
3277         (WebCore::WorkerExceptionTask::create):
3278         (WebCore::WorkerContextDestroyedTask::create):
3279         (WebCore::WorkerTerminateTask::create):
3280         (WebCore::WorkerThreadActivityReportTask::create):
3281         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
3282         (WebCore::WorkerMessagingProxy::postTaskToLoader):
3283         (WebCore::WorkerMessagingProxy::workerThreadCreated):
3284         * workers/WorkerMessagingProxy.h:
3285         * workers/WorkerRunLoop.cpp:
3286         (WebCore::ModePredicate::operator()):
3287         (WebCore::WorkerRunLoop::runInMode):
3288         (WebCore::WorkerRunLoop::postTask):
3289         (WebCore::WorkerRunLoop::postTaskForMode):
3290         (WebCore::WorkerRunLoop::Task::create):
3291         (WebCore::WorkerRunLoop::Task::performTask):
3292         (WebCore::WorkerRunLoop::Task::Task):
3293         * workers/WorkerRunLoop.h:
3294         (WebCore::WorkerRunLoop::Task::~Task):
3295         (WebCore::WorkerRunLoop::Task::mode):
3296
3297 2009-11-02  Philippe Normand  <pnormand@igalia.com>
3298
3299         Reviewed by Jan Alonzo.
3300
3301         [GTK] Failing media/video-played-reset.html
3302         https://bugs.webkit.org/show_bug.cgi?id=30589
3303
3304         new m_seekTime attribute to keep track of the seek position
3305
3306         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3307         (WebCore::MediaPlayerPrivate::currentTime):
3308         (WebCore::MediaPlayerPrivate::seek):
3309         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
3310
3311 2009-11-02  Xan Lopez  <xlopez@igalia.com>
3312
3313         Reviewed by Jan Alonzo.
3314
3315         [GTK] Remove Referer when redirecting to non-secure site
3316         https://bugs.webkit.org/show_bug.cgi?id=31021
3317
3318         Remove referer from HTTP headers when redirecting to a non-secure
3319         site.
3320
3321         * platform/network/soup/ResourceHandleSoup.cpp:
3322         (WebCore::restartedCallback):
3323
3324 2009-11-02  Alexey Proskuryakov  <ap@apple.com>
3325
3326         Reviewed by Dan Bernstein.
3327
3328         https://bugs.webkit.org/show_bug.cgi?id=18539
3329         multipart/form-data not being parsed correctly on server due to '+' in boundary string
3330
3331         No test - the characters that the boundary is made of are not deterministic.
3332
3333         * platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString):
3334         Don't ever put a '+' in boundary string, either. Removed a FIXME to bring '/' back once
3335         GMail is fixed - I don't think we'll ever want to allow non-alphanumeric characters, as
3336         they cause problems on many web sites.
3337
3338 2009-10-30  Alexey Proskuryakov  <ap@apple.com>
3339
3340         Reviewed by Darin Adler.
3341
3342         https://bugs.webkit.org/show_bug.cgi?id=30969
3343         A no-prefix XPath node test should not match no-namespace elements in HTML document
3344
3345         Test: fast/xpath/null-namespace-in-html.html
3346
3347         * xml/XPathStep.cpp: (WebCore::XPath::nodeMatchesBasicTest): Special case non-HTML elements
3348         in HTML documents (as these are the ones that can have null namespace).
3349
3350 2009-11-02  Pavel Feldman  <pfeldman@chromium.org>
3351
3352         Reviewed by Timothy Hatcher.
3353
3354         Web Inspector: [REGRESSION] No timeline marks on resources panel.
3355
3356         https://bugs.webkit.org/show_bug.cgi?id=31013
3357
3358         * inspector/front-end/AbstractTimelinePanel.js:
3359         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
3360
3361 2009-11-02  David Levin  <levin@chromium.org>
3362
3363         Reviewed by Dan Bernstein.
3364
3365         Possible crash in RenderSlider::layout.
3366         https://bugs.webkit.org/show_bug.cgi?id=31016
3367
3368         Fix out of place line of code.
3369
3370         Test: scrollbars/overflow-scrollbar-combinations.html
3371         This crash only seems to repro when WebKit draws the play controls,
3372         so the crash repros in chromium running this test but not WebKit
3373         nightlies which use QuickTime to draw the controls.
3374
3375         * rendering/RenderSlider.cpp:
3376         (WebCore::RenderSlider::layout):
3377
3378 2009-11-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3379
3380         Reviewed by Tor Arne Vestbø.
3381
3382         [Qt] Fix Qt build on Windows.
3383         https://bugs.webkit.org/show_bug.cgi?id=30905
3384
3385         * WebCore.pro:
3386         * platform/graphics/BitmapImage.h:
3387         * platform/graphics/qt/ImageQt.cpp:
3388         (WebCore::BitmapImage::BitmapImage):
3389         (WebCore::BitmapImage::create):
3390
3391 2009-11-02  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3392
3393         Reviewed by Adam Barth.
3394
3395         QWebView crash fix.
3396
3397         The QWebView should not crash if the stop() method is called from
3398         a function triggered by the loadProgress signal.
3399
3400         A null pointer protection was added in the ProgressTracker::incrementProgress.
3401
3402         New autotest was created.
3403
3404         https://bugs.webkit.org/show_bug.cgi?id=29425
3405
3406         * loader/ProgressTracker.cpp:
3407         (WebCore::ProgressTracker::incrementProgress):
3408
3409 2009-11-02  Mikhail Naganov  <mnaganov@chromium.org>
3410
3411         Reviewed by Pavel Feldman.
3412
3413         Fix a leftover from profiles panel generalization.
3414
3415         https://bugs.webkit.org/show_bug.cgi?id=31010
3416
3417         * inspector/front-end/ProfilesPanel.js:
3418         (WebInspector.ProfilesPanel.prototype.get searchableViews):
3419
3420 2009-11-02  Kai Koehne  <kai.koehne@nokia.com>
3421
3422         Reviewed by Holger Freyther.
3423
3424         Remove implementation of ImageDecocerQt::clearFrameBufferCache.
3425         The implementation was buggy, and will visually break repeating
3426         animations anyway.
3427
3428         https://bugs.webkit.org/show_bug.cgi?id=31009
3429
3430         * platform/graphics/qt/ImageDecoderQt.cpp:
3431         (WebCore::ImageDecoderQt::clearFrameBufferCache):
3432
3433 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3434
3435         Reviewed by Jan Alonzo.
3436
3437         https://bugs.webkit.org/show_bug.cgi?id=30964
3438         [Gtk] Implemment AtkDocument
3439
3440         Provides access to the reported content language.
3441
3442         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3443         (webkit_accessible_document_get_locale):
3444
3445 2009-11-02  Keishi Hattori  <casey.hattori@gmail.com>
3446
3447         Reviewed by Timothy Hatcher.
3448
3449         Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
3450         https://bugs.webkit.org/show_bug.cgi?id=30907
3451
3452         Test: inspector/css-syntax-highlight.html
3453
3454         * inspector/front-end/ElementsTreeOutline.js:
3455         * inspector/front-end/SourceFrame.js:
3456         (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
3457         (WebInspector.SourceSyntaxHighlighter):
3458         (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk):
3459         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine):
3460         (WebInspector.SourceSyntaxHighlighter.prototype.process):
3461         (WebInspector.SourceSyntaxHighlighter.prototype.lex):
3462         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
3463         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
3464         (WebInspector.CSSSourceSyntaxHighlighter):
3465         * inspector/front-end/inspectorSyntaxHighlight.css:
3466
3467 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
3468
3469         Reviewed by Beth Dakin.
3470
3471         Support ARIA "tab" roles
3472         https://bugs.webkit.org/show_bug.cgi?id=30842
3473
3474         Implement support for ARIA "tab", "tabpanel" and "tablist".
3475         As a consequence, we also needed to implement aria-selected
3476         and aria-controls.
3477
3478         Tests: accessibility/aria-controls-with-tabs.html
3479                accessibility/aria-tab-roles.html
3480
3481         * accessibility/AXObjectCache.cpp:
3482         * accessibility/AccessibilityObject.h:
3483         * accessibility/AccessibilityRenderObject.cpp:
3484         * accessibility/AccessibilityRenderObject.h:
3485         * accessibility/mac/AccessibilityObjectWrapper.mm:
3486         * html/HTMLAttributeNames.in:
3487
3488 2009-10-27  Stephen White  <senorblanco@chromium.org>
3489
3490         Reviewed by Dmitry Titov.
3491
3492         This is the WebKit-side change needed to fix canvas.getImageData() for
3493         Chromium.  The unpremultiply code in Skia assumes that unpremultiplied
3494         values should be rounded, while CG does not.  In addition, the fixed
3495         point inversion used by Skia introduces slight inaccuracies that make
3496         us fail this test.  This change brings Chromium in line with
3497         the CG path.
3498         https://bugs.webkit.org/show_bug.cgi?id=30825
3499
3500         Covered by LayoutTests/fast/canvas/canvas-getImageData.html
3501
3502         * platform/graphics/skia/ImageBufferSkia.cpp:
3503         (WebCore::getImageData):
3504
3505 2009-11-01  Kelly Norton  <knorton@google.com>
3506
3507         Reviewed by Timothy Hatcher.
3508
3509         Adds window event dispatches to InspectorTimelineAgent.
3510         https://bugs.webkit.org/show_bug.cgi?id=31002
3511
3512         * English.lproj/localizedStrings.js:
3513         * dom/Node.cpp: Updated call site to willDispatchEvent and didDispatchEvent.
3514         (WebCore::Node::dispatchGenericEvent):
3515         * inspector/InspectorTimelineAgent.cpp:
3516         (WebCore::InspectorTimelineAgent::willDispatchEvent): Renamed.
3517         (WebCore::InspectorTimelineAgent::didDispatchEvent): Renamed.
3518         * inspector/InspectorTimelineAgent.h:
3519         (WebCore::):
3520         * inspector/TimelineRecordFactory.cpp:
3521         (WebCore::TimelineRecordFactory::createEventDispatchRecord): Renamed.
3522         * inspector/TimelineRecordFactory.h:
3523         * inspector/front-end/TimelineAgent.js:
3524         * inspector/front-end/TimelinePanel.js:
3525         (WebInspector.TimelinePanel.prototype._formatRecord):
3526         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3527         * page/DOMWindow.cpp:
3528         (WebCore::DOMWindow::dispatchEvent):
3529
3530 2009-11-01  Pavel Feldman  <pfeldman@chromium.org>
3531
3532         Reviewed by Timothy Hatcher.
3533
3534         Web Inspector: Convert script tag event into a more generic
3535         script eval event in timeline.
3536
3537         https://bugs.webkit.org/show_bug.cgi?id=30999
3538
3539         * bindings/js/ScriptController.cpp:
3540         (WebCore::ScriptController::evaluateInWorld):
3541         * bindings/v8/V8Proxy.cpp:
3542         (WebCore::V8Proxy::evaluate):
3543         * html/HTMLTokenizer.cpp:
3544         (WebCore::HTMLTokenizer::scriptExecution):
3545         * inspector/InspectorTimelineAgent.cpp:
3546         (WebCore::InspectorTimelineAgent::willEvaluateScript):
3547         (WebCore::InspectorTimelineAgent::didEvaluateScript):
3548         * inspector/InspectorTimelineAgent.h:
3549         (WebCore::):
3550         * inspector/TimelineRecordFactory.cpp:
3551         (WebCore::TimelineRecordFactory::createEvaluateScriptTimelineRecord):
3552         * inspector/TimelineRecordFactory.h:
3553         * inspector/front-end/TimelineAgent.js:
3554         * inspector/front-end/TimelinePanel.js:
3555         (WebInspector.TimelinePanel.prototype._formatRecord):
3556         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3557
3558 2009-11-01  Brian Weinstein  <bweinstein@apple.com>
3559
3560         Rubber-stamped by Mark Rowe.
3561
3562         Fix for loop to use an size_t instead of unsigned and some spacing
3563         style fixes.
3564
3565         * dom/Node.cpp:
3566         (WebCore::eventHasListeners):
3567
3568 2009-11-01  Kelly Norton  <knorton@google.com>
3569
3570         Reviewed by Timothy Hatcher.
3571
3572         Does not send DOM dispatches to the InspectorTimelineAgent if there
3573         are no event listeners.
3574         https://bugs.webkit.org/show_bug.cgi?id=30995
3575
3576         * dom/Node.cpp:
3577         (WebCore::eventHasListeners):
3578         (WebCore::Node::dispatchGenericEvent):
3579         * xml/XMLHttpRequest.cpp:
3580         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
3581
3582 2009-11-01  Roland Steiner  <rolandsteiner@chromium.org>
3583
3584         No review (build fix).
3585
3586         Add missing files for Ruby implementation to WebCore.vcproj
3587         (Fix build break after 50397)
3588         https://bugs.webkit.org/show_bug.cgi?id=31001
3589
3590         No new tests. (No functional change)
3591
3592         * WebCore.vcproj/WebCore.vcproj:
3593
3594 2009-11-02  Roland Steiner  <rolandsteiner@chromium.org>
3595
3596         Reviewed by Dave Hyatt.
3597
3598         Bug 28420 -  Implement HTML5 <ruby> rendering
3599         (https://bugs.webkit.org/show_bug.cgi?id=28420)
3600
3601         First rudimentary implementation of HTML5 ruby rendering support.
3602
3603         Following the HTML 5 spec, the box object model for a <ruby> element allows several runs of ruby
3604         bases with their respective ruby texts looks as follows:
3605
3606         1 RenderRuby object, corresponding to the whole <ruby> HTML element
3607              1+ RenderRubyRun (anonymous)
3608                  0 or 1 RenderRubyText - shuffled to the front in order to re-use existing block layouting
3609                      0-n inline object(s)
3610                  0 or 1 RenderRubyBase - contains the inline objects that make up the ruby base
3611                      1-n inline object(s)
3612
3613         Note: <rp> elements are defined as having 'display:none' and thus normally are not assigned a renderer.
3614         
3615         New layout tests will be committed in a follow-up patch under fast/ruby.
3616
3617         Makefiles, etc.
3618         * GNUmakefile.am:
3619         * WebCore.gypi:
3620         * WebCore.pro:
3621         * WebCore.xcodeproj/project.pbxproj:
3622
3623         CSS
3624         * css/html.css: Added <ruby> and <rt>
3625
3626         Existing render files:
3627         * rendering/RenderBlock.cpp: make moveChild a member function moveChildTo
3628         (WebCore::RenderBlock::moveChildTo):
3629         (WebCore::RenderBlock::makeChildrenNonInline):
3630         (WebCore::RenderBlock::removeChild):
3631         * rendering/RenderBlock.h:
3632         * rendering/RenderObject.cpp:
3633         (WebCore::RenderObject::createObject): instantiate ruby renderers based on element name
3634         * rendering/RenderObject.h: add query methods for ruby renderers
3635         (WebCore::RenderObject::isRuby):
3636         (WebCore::RenderObject::isRubyBase):
3637         (WebCore::RenderObject::isRubyRun):
3638         (WebCore::RenderObject::isRubyText):
3639
3640         New ruby renderers:
3641         * rendering/RenderRuby.cpp: Added.
3642         (WebCore::lastRubyRun):
3643         (WebCore::findRubyRunParent):
3644         (WebCore::RenderRubyAsInline::RenderRubyAsInline):
3645         (WebCore::RenderRubyAsInline::~RenderRubyAsInline):
3646         (WebCore::RenderRubyAsInline::isChildAllowed):
3647         (WebCore::RenderRubyAsInline::addChild):
3648         (WebCore::RenderRubyAsInline::removeChild):
3649         (WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
3650         (WebCore::RenderRubyAsBlock::~RenderRubyAsBlock):
3651         (WebCore::RenderRubyAsBlock::isChildAllowed):
3652         (WebCore::RenderRubyAsBlock::addChild):
3653         (WebCore::RenderRubyAsBlock::removeChild):
3654         * rendering/RenderRuby.h: Added.
3655         (WebCore::RenderRubyAsInline::renderName):
3656         (WebCore::RenderRubyAsInline::isRuby):
3657         (WebCore::RenderRubyAsBlock::renderName):
3658         (WebCore::RenderRubyAsBlock::isRuby):
3659         * rendering/RenderRubyBase.cpp: Added.
3660         (WebCore::RenderRubyBase::RenderRubyBase):
3661         (WebCore::RenderRubyBase::~RenderRubyBase):
3662         (WebCore::RenderRubyBase::isChildAllowed):
3663         (WebCore::RenderRubyBase::splitToLeft):
3664         (WebCore::RenderRubyBase::mergeWithRight):
3665         * rendering/RenderRubyBase.h: Added.
3666         (WebCore::RenderRubyBase::renderName):
3667         (WebCore::RenderRubyBase::isRubyBase):
3668         * rendering/RenderRubyRun.cpp: Added.
3669         (WebCore::RenderRubyRun::RenderRubyRun):
3670         (WebCore::RenderRubyRun::~RenderRubyRun):
3671         (WebCore::RenderRubyRun::hasRubyText):
3672         (WebCore::RenderRubyRun::hasRubyBase):
3673         (WebCore::RenderRubyRun::isEmpty):
3674         (WebCore::RenderRubyRun::rubyText):
3675         (WebCore::RenderRubyRun::rubyBase):
3676         (WebCore::RenderRubyRun::rubyBaseSafe):
3677         (WebCore::RenderRubyRun::firstLineBlock):
3678         (WebCore::RenderRubyRun::updateFirstLetter):
3679         (WebCore::RenderRubyRun::isChildAllowed):
3680         (WebCore::RenderRubyRun::addChild):
3681         (WebCore::RenderRubyRun::removeChild):
3682         (WebCore::RenderRubyRun::createRubyBase):
3683         (WebCore::RenderRubyRun::staticCreateRubyRun):
3684         * rendering/RenderRubyRun.h: Added.
3685         (WebCore::RenderRubyRun::renderName):
3686         (WebCore::RenderRubyRun::isRubyRun):
3687         * rendering/RenderRubyText.cpp: Added.
3688         (WebCore::RenderRubyText::RenderRubyText):
3689         (WebCore::RenderRubyText::~RenderRubyText):
3690         (WebCore::RenderRubyText::isChildAllowed):
3691         * rendering/RenderRubyText.h: Added.
3692         (WebCore::RenderRubyText::renderName):
3693         (WebCore::RenderRubyText::isRubyText):
3694
3695 2009-11-01  Alexey Proskuryakov  <ap@apple.com>
3696
3697         Reviewed by Dan Bernstein.
3698
3699         https://bugs.webkit.org/show_bug.cgi?id=30992
3700         Node.isDefaultNamespace doesn't convert empty strings to null
3701
3702         Test: fast/dom/Node/default-namespace-empty-argument.html
3703
3704         * dom/Node.cpp: (WebCore::Node::isDefaultNamespace): Per DOM 3 Core, treat empty input
3705         as null.
3706
3707 2009-11-01  Yael Aharon  <yael.aharon@nokia.com>
3708
3709         Reviewed by Darin Adler.
3710
3711         Don't add '/' to the URL path if the it does not include '/' after the protocol component
3712         https://bugs.webkit.org/show_bug.cgi?id=30971
3713
3714         Match IE8 behaviour, that does not add '/' if there is none after the protocol component.
3715
3716         * platform/KURL.cpp:
3717         (WebCore::KURL::parse):
3718
3719 2009-10-31  Oliver Hunt  <oliver@apple.com>
3720
3721         Reviewed by Darin Adler.
3722
3723         Fix layering violations in GraphicsContext3D
3724         https://bugs.webkit.org/show_bug.cgi?id=30986
3725
3726         Remove uses of HTMLImageElement and HTMLCanvasElement
3727
3728         * html/canvas/CanvasRenderingContext3D.cpp:
3729         (WebCore::CanvasRenderingContext3D::texImage2D):
3730         (WebCore::CanvasRenderingContext3D::texSubImage2D):
3731         * platform/graphics/GraphicsContext3D.h:
3732         * platform/graphics/mac/GraphicsContext3DMac.cpp:
3733         (WebCore::GraphicsContext3D::texImage2D):
3734         (WebCore::GraphicsContext3D::texSubImage2D):
3735
3736 2009-11-01  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3737
3738         Reviewed by Jan Alonzo.
3739
3740         https://bugs.webkit.org/show_bug.cgi?id=30964
3741         [Gtk] Implemment AtkDocument
3742
3743         Provides access to expected document attributes.
3744
3745         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3746         (documentAttributeValue):
3747         (webkit_accessible_document_get_document_attribute_value):
3748         (webkit_accessible_document_get_document_attributes):
3749
3750 2009-11-03  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3751
3752         Reviewed by Jan Alonzo.
3753
3754         https://bugs.webkit.org/show_bug.cgi?id=30964
3755         [Gtk] Implemment AtkDocument
3756
3757         Implements what has been implemented in AT-SPI.
3758
3759         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3760         (GetAtkInterfaceTypeFromWAIType):
3761         (getInterfaceMaskFromObject):
3762         (atk_document_interface_init):
3763         (webkit_accessible_document_get_document_attribute_value):
3764         (webkit_accessible_document_get_document_attributes):
3765         (webkit_accessible_document_get_locale):
3766
3767 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3768
3769         Reviewed by Eric Seidel.
3770
3771         Turn on warnings for QtWebKit for gcc
3772         https://bugs.webkit.org/show_bug.cgi?id=30958
3773
3774         No new tests as there is no functional change.
3775
3776         * platform/image-decoders/qt/RGBA32BufferQt.cpp:
3777         (WebCore::RGBA32Buffer::RGBA32Buffer): Reorder 
3778         initialization list to fix compiler warnings.
3779
3780
3781 2009-11-01  Keishi Hattori  <casey.hattori@gmail.com>
3782
3783         Reviewed by Pavel Feldman.
3784
3785         [Regression] monitorEvent doesn't work
3786
3787         * inspector/front-end/InjectedScript.js:
3788         (InjectedScript._ensureCommandLineAPIInstalled):
3789
3790 2009-11-01  Keishi Hattori  <casey.hattori@gmail.com>
3791
3792         Reviewed by Pavel Feldman.
3793
3794         Fix Web Inspector: Bug with Message Bubble in Syntax Highlighter
3795         https://bugs.webkit.org/show_bug.cgi?id=30990
3796
3797         * inspector/front-end/SourceFrame.js:
3798
3799 2009-10-31  Alexey Proskuryakov  <ap@apple.com>
3800
3801         Reviewed by John Sullivan.
3802
3803         https://bugs.webkit.org/show_bug.cgi?id=30982
3804         createHTMLDocument doesn't escape ampersand and less-than in title
3805
3806         Test: fast/dom/DOMImplementation/createHTMLDocument-title.html
3807
3808         * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument):
3809         Set document title after creating the document, avoiding parser intricacies.
3810
3811 2009-11-01  Keishi Hattori  <casey.hattori@gmail.com>
3812
3813         Reviewed by Timothy Hatcher.
3814
3815         Web Inspector: Double clicking on a breakpoints should not select text
3816         https://bugs.webkit.org/show_bug.cgi?id=30950
3817
3818         * inspector/front-end/SourceFrame.js:
3819         (WebInspector.SourceFrame.prototype._documentMouseDown):
3820
3821 2009-11-01  Yuta Kitamura  <yutak@chromium.org>
3822
3823         Reviewed by Darin Adler.
3824
3825         Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().
3826
3827         [Crash (debug)] Combination of list-item and :after causes assertion failure
3828         https://bugs.webkit.org/show_bug.cgi?id=30944
3829
3830         Test: fast/css/list-item-pseudo-nocrash.html
3831
3832         * rendering/RenderObjectChildList.cpp:
3833         (WebCore::RenderObjectChildList::updateBeforeAfterContent):
3834
3835 2009-11-01  Philippe Normand  <pnormand@igalia.com>
3836
3837         Reviewed by Eric Seidel.
3838
3839         https://bugs.webkit.org/show_bug.cgi?id=30586
3840         [GTK] Failing test media/video-src-empty.html
3841
3842         Correctly set network/ready state depending on GStreamer errors
3843         received on the bus.
3844
3845         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3846         (WebCore::mediaPlayerPrivateMessageCallback):
3847
3848 2009-10-31  Oliver Hunt  <oliver@apple.com>
3849
3850         Build fix
3851
3852         * platform/graphics/mac/GraphicsContext3DMac.cpp:
3853         (WebCore::GraphicsContext3D::attachShader):
3854
3855 2009-10-31  Oliver Hunt  <oliver@apple.com>
3856
3857         Reviewed by Darin Adler.
3858
3859         Remove obsolete null checks from CanvasRenderingContext3DMac
3860         https://bugs.webkit.org/show_bug.cgi?id=30983
3861
3862         * platform/graphics/mac/GraphicsContext3DMac.cpp:
3863         (WebCore::GraphicsContext3D::attachShader):
3864         (WebCore::GraphicsContext3D::bindAttribLocation):
3865         (WebCore::GraphicsContext3D::compileShader):
3866         (WebCore::GraphicsContext3D::detachShader):
3867         (WebCore::GraphicsContext3D::framebufferRenderbuffer):
3868         (WebCore::GraphicsContext3D::framebufferTexture2D):
3869         (WebCore::GraphicsContext3D::linkProgram):
3870         (WebCore::GraphicsContext3D::shaderSource):
3871         (WebCore::GraphicsContext3D::useProgram):
3872         (WebCore::GraphicsContext3D::validateProgram):
3873         (WebCore::GraphicsContext3D::getProgramInfoLog):
3874         (WebCore::GraphicsContext3D::getShaderi):
3875         (WebCore::GraphicsContext3D::getShaderiv):
3876         (WebCore::GraphicsContext3D::getShaderInfoLog):
3877         (WebCore::GraphicsContext3D::getShaderSource):
3878         (WebCore::GraphicsContext3D::getUniformLocation):
3879
3880 2009-10-31  Oliver Hunt  <oliver@apple.com>
3881
3882         Reviewed by Jon Honeycutt.
3883
3884         WebGL allows objects to be used with the wrong context
3885         https://bugs.webkit.org/show_bug.cgi?id=30981
3886
3887         Simply add null checks and a few context guards to ensure we don't
3888         deref null or attempt to use an object from a different context.
3889
3890         Tests: fast/canvas/webgl/incorrect-context-object-behaviour.html
3891                fast/canvas/webgl/null-object-behaviour.html
3892
3893         * html/canvas/CanvasRenderingContext3D.cpp:
3894         (WebCore::CanvasRenderingContext3D::attachShader):
3895         (WebCore::CanvasRenderingContext3D::bindAttribLocation):
3896         (WebCore::CanvasRenderingContext3D::bindBuffer):
3897         (WebCore::CanvasRenderingContext3D::bindFramebuffer):
3898         (WebCore::CanvasRenderingContext3D::bindRenderbuffer):
3899         (WebCore::CanvasRenderingContext3D::bindTexture):
3900         (WebCore::CanvasRenderingContext3D::compileShader):
3901         (WebCore::CanvasRenderingContext3D::detachShader):
3902         (WebCore::CanvasRenderingContext3D::framebufferRenderbuffer):
3903         (WebCore::CanvasRenderingContext3D::framebufferTexture2D):
3904         (WebCore::CanvasRenderingContext3D::getProgrami):
3905         (WebCore::CanvasRenderingContext3D::getProgramiv):
3906         (WebCore::CanvasRenderingContext3D::getProgramInfoLog):
3907         (WebCore::CanvasRenderingContext3D::getShaderi):
3908         (WebCore::CanvasRenderingContext3D::getShaderiv):
3909         (WebCore::CanvasRenderingContext3D::getShaderInfoLog):
3910         (WebCore::CanvasRenderingContext3D::getShaderSource):
3911         (WebCore::CanvasRenderingContext3D::getUniformf):
3912         (WebCore::CanvasRenderingContext3D::getUniformfv):
3913         (WebCore::CanvasRenderingContext3D::getUniformi):
3914         (WebCore::CanvasRenderingContext3D::getUniformiv):
3915         (WebCore::CanvasRenderingContext3D::getUniformLocation):
3916         (WebCore::CanvasRenderingContext3D::isBuffer):
3917         (WebCore::CanvasRenderingContext3D::linkProgram):
3918         (WebCore::CanvasRenderingContext3D::shaderSource):
3919         * html/canvas/CanvasRenderingContext3D.h:
3920         * html/canvas/CanvasRenderingContext3D.idl:
3921
3922 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
3923
3924         Reviewed by Darin Adler.
3925
3926         Allow custom memory allocation control for WebCore's MediaQueryResult
3927         https://bugs.webkit.org/show_bug.cgi?id=30857
3928
3929         Inherits MediaQueryResult class from Noncopyable because it is
3930         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:5984 and
3931         it is no need to be copyable.
3932
3933         * css/CSSStyleSelector.h:
3934
3935 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
3936
3937         Reviewed by Darin Adler.
3938
3939         Allow custom memory allocation control for WebCore's MediaQueryEvaluator
3940         https://bugs.webkit.org/show_bug.cgi?id=30854
3941
3942         Inherits MediaQueryEvaluator class from Noncopyable because it is
3943         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and   
3944         it is no need to be copyable.
3945
3946         * css/MediaQueryEvaluator.h:
3947
3948 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
3949
3950         Reviewed by Darin Adler.
3951
3952         Allow custom memory allocation control for WebCore's CSSRuleSet
3953         https://bugs.webkit.org/show_bug.cgi?id=30852
3954
3955         Inherits CSSRuleSet class from Noncopyable because it is
3956         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:455 and
3957         it is no need to be copyable.
3958
3959         * css/CSSStyleSelector.cpp:
3960
3961 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
3962
3963         Reviewed by Darin Adler.
3964
3965         Allow custom memory allocation control for WebCore's CSSRuleData
3966         https://bugs.webkit.org/show_bug.cgi?id=30851
3967
3968         Inherits CSSRuleData class from Noncopyable because it is
3969         instantiated by 'new' in WebCore/css/CSSStyleSelector.h:320 and
3970         it is no need to be copyable.
3971
3972         * css/CSSStyleSelector.h:
3973
3974 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
3975
3976         Reviewed by Darin Adler.
3977
3978         Allow custom memory allocation control for WebCore's CSSRuleDataList
3979         https://bugs.webkit.org/show_bug.cgi?id=30850
3980
3981         Inherits CSSRuleDataList class from Noncopyable because it has been
3982         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:2715 and
3983         it is no need to be copyable.
3984
3985         * css/CSSStyleSelector.h:
3986
3987 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
3988
3989         Reviewed by Darin Adler.
3990
3991         Allow custom memory allocation control for WebCore's CSSNamespace
3992         https://bugs.webkit.org/show_bug.cgi?id=30849
3993
3994         Inherits CSSNamespace struct from Noncopyable because it is
3995         instantiated by 'new' in WebCore/css/CSSStyleSheet.cpp:141 and
3996         it is no need to be copyable.
3997
3998         * css/CSSNamespace.h:
3999
4000 2009-10-30  Dmitry Titov  <dimich@chromium.org>
4001
4002         Reviewed by David Levin.
4003
4004         Refactor DatabaseTask in preparation for removing threadsafe refcounting from it.
4005         Move the synchronizer object out of the DatabaseTask so there is no need to keep
4006         the pointer to Databasetask around after passing it to MessageQueue.
4007         Also pass the references to return parameters to the task so it can update them.
4008         https://bugs.webkit.org/show_bug.cgi?id=30941
4009
4010         No new tests, since this is just moving the code around, no change in functionality.
4011
4012         * storage/Database.cpp:
4013         (WebCore::Database::Database):
4014         (WebCore::Database::openAndVerifyVersion): Use new DatabaseTaskSynchronizer to wait for task completion.
4015         (WebCore::Database::markAsDeletedAndClose): Ditto.
4016         (WebCore::Database::tableNames): Ditto.
4017         (WebCore::Database::stop): Use the boolean flag rather then 'killed' flag built into MessageQueue.
4018         (WebCore::Database::scheduleTransaction): Transaction queue is a Deque now, change the way to fetch the transaction.
4019         * storage/Database.h: Change the SQLTransaction queue to be a Deque rather then a MessageQueue.
4020         * storage/DatabaseTask.cpp:
4021         (WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
4022         (WebCore::DatabaseTaskSynchronizer::waitForTaskCompletion):
4023         (WebCore::DatabaseTaskSynchronizer::taskCompleted):
4024         (WebCore::DatabaseTask::DatabaseTask): Ctor takes DatabaseTaskSynchronizer which can be 0.
4025         (WebCore::DatabaseTask::performTask): Signal completion. m_synchronizer should still be around since main thread is waiting on it.
4026         (WebCore::DatabaseOpenTask::DatabaseOpenTask): Pass synchronizer and return parameters via constructor.
4027         (WebCore::DatabaseCloseTask::DatabaseCloseTask): Ditto.
4028         (WebCore::DatabaseTransactionTask::DatabaseTransactionTask): Ditto.
4029         (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): Ditto.
4030         * storage/DatabaseTask.h:
4031         (WebCore::DatabaseOpenTask::create):
4032         (WebCore::DatabaseCloseTask::create):
4033         (WebCore::DatabaseTransactionTask::create):
4034         (WebCore::DatabaseTableNamesTask::create):
4035
4036 2009-10-30  Enrica Casucci  <enrica@apple.com>
4037
4038         Reviewed by Darin Adler.
4039
4040         REGRESSION: In Mail, Undo does not restore some characters I have deleted at the end of a line
4041         https://bugs.webkit.org/show_bug.cgi?id=30955
4042         <rdar://problem/7067033>
4043         
4044         When the command is deleteWordBackward or deleteWordForward
4045         we should not add to the open typing command, but
4046         create a new one.
4047         
4048         Test: editing/undo/undo-deleteWord.html
4049
4050         * editing/TypingCommand.cpp:
4051         (WebCore::TypingCommand::deleteKeyPressed): Always start a new command if the granularity is
4052         not CharacterGranularity. 
4053         (WebCore::TypingCommand::forwardDeleteKeyPressed): Always start a new command if the granularity is
4054         not CharacterGranularity. 
4055
4056 2009-10-30  Eric Carlson  <eric.carlson@apple.com>
4057
4058         Reviewed by Darin Adler.
4059
4060         Make MediaPlayer constructor private
4061         https://bugs.webkit.org/show_bug.cgi?id=30965
4062
4063         * html/HTMLMediaElement.cpp:
4064         (WebCore::HTMLMediaElement::loadResource): 
4065         (WebCore::HTMLMediaElement::finishParsingChildren): Use MediaPlayer::create.
4066
4067         * platform/graphics/MediaPlayer.h:
4068         (WebCore::MediaPlayer::create): New.
4069
4070 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
4071
4072         MSAA: Accessibility of headings is not correct
4073
4074         https://bugs.webkit.org/show_bug.cgi?id=30937
4075
4076         Reviewed by Alice Liu.
4077
4078         * accessibility/AccessibilityObject.h:
4079         (WebCore::AccessibilityObject::stringRoleForMSAA):
4080         (WebCore::AccessibilityObject::descriptionForMSAA):
4081
4082         * accessibility/AccessibilityRenderObject.cpp:
4083         (WebCore::shouldReturnTagNameAsRoleForMSAA):
4084         If the element's tag name is one of h1, h2, h3, h4, h5, h6, return
4085         true.
4086         (WebCore::AccessibilityRenderObject::stringRoleForMSAA):
4087         If the element should return its tag name as the role, return the tag
4088         name.
4089         (WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):
4090         If the object is a heading, return the string "L" followed by the
4091         heading level.
4092         (WebCore::AccessibilityRenderObject::descriptionForMSAA):
4093         If the object has a positional description, return it. Otherwise, get
4094         the accessibility description, and prefix it with "Description" so that
4095         MSAA clients know that it's not a positional description.
4096
4097         * accessibility/AccessibilityRenderObject.h:
4098
4099 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
4100
4101         MSAA: Accessibility of links is wrong
4102
4103         https://bugs.webkit.org/show_bug.cgi?id=30928
4104
4105         Reviewed by Darin Adler.
4106
4107         * accessibility/AccessibilityImageMapLink.cpp:
4108         (WebCore::AccessibilityImageMapLink::stringValueForMSAA):
4109         Return the URL.
4110         (WebCore::AccessibilityImageMapLink::nameForMSAA):
4111         Return the alt text.
4112
4113         * accessibility/AccessibilityImageMapLink.h:
4114         (WebCore::AccessibilityImageMapLink::isLinked):
4115         Return true.
4116
4117         * accessibility/AccessibilityObject.h:
4118         (WebCore::AccessibilityObject::isLinked):
4119         (WebCore::AccessibilityObject::stringValueForMSAA):
4120         (WebCore::AccessibilityObject::nameForMSAA):
4121
4122         * accessibility/AccessibilityRenderObject.cpp:
4123         (WebCore::isLinkable):
4124         Return true if the element is considered "linkable" with respect to
4125         accessibility.
4126         (WebCore::AccessibilityRenderObject::stringValueForMSAA):
4127         If the element is linkable, check whether it has a parent anchor
4128         element. If so, return the anchor element's href.
4129         (WebCore::AccessibilityRenderObject::isLinked):
4130         Return true if the element is linkable and if it's parent anchor tag's
4131         href is non-empty.
4132         (WebCore::AccessibilityRenderObject::nameForMSAA):
4133         For text nodes, return the text.
4134
4135         * accessibility/AccessibilityRenderObject.h:
4136
4137 2009-10-30  Evan Stade  <estade@chromium.org>
4138
4139         Reviewed by David Levin.
4140
4141         Notify the chrome when the focused node has changed.
4142         https://bugs.webkit.org/show_bug.cgi?id=30832
4143
4144         This is similar to AX code that is already in place, except that this also informs the
4145         chrome when there stops being a focused node. This is needed for a browser to show the
4146         anchor for links that have keyboard focus.
4147
4148         * dom/Document.cpp:
4149         (WebCore::Document::setFocusedNode):
4150         * loader/EmptyClients.h:
4151         (WebCore::EmptyChromeClient::focusedNodeChanged):
4152         * page/Chrome.cpp:
4153         (WebCore::Chrome::focusedNodeChanged):
4154         * page/Chrome.h:
4155         * page/ChromeClient.h:
4156
4157 2009-10-30  Ben Murdoch  <benm@google.com>
4158
4159         Reviewed by David Kilzer.
4160
4161         openDatabase() with empty version sets db version up incorrectly
4162         https://bugs.webkit.org/show_bug.cgi?id=28417
4163
4164         Test: storage/open-database-set-empty-version.html
4165
4166         * storage/Database.cpp:
4167         (WebCore::Database::performOpenAndVerify): Raise an exception if the current database version does not match the expected version when the current version is the empty string.
4168
4169 2009-10-30  John Gregg  <johnnyg@google.com>
4170
4171         Reviewed by David Levin.
4172
4173         Need to turn off notifications properly at runtime
4174         https://bugs.webkit.org/show_bug.cgi?id=30409
4175
4176         Moving the notificationsEnabled bit from NotificationCenter
4177         to the new V8 RuntimeEnabledFeatures object.
4178
4179         Just moving a bit around, so no new tests.
4180
4181         * bindings/v8/RuntimeEnabledFeatures.cpp:
4182         * bindings/v8/RuntimeEnabledFeatures.h:
4183         (WebCore::RuntimeEnabledFeatures::setNotificationsEnabled):
4184         (WebCore::RuntimeEnabledFeatures::notificationsEnabled):
4185         * bindings/v8/custom/V8DOMWindowCustom.cpp:
4186         (WebCore::ACCESSOR_RUNTIME_ENABLER):
4187         * bindings/v8/custom/V8WorkerContextCustom.cpp:
4188         (WebCore::ACCESSOR_RUNTIME_ENABLER):
4189         * notifications/NotificationCenter.cpp:
4190         * notifications/NotificationCenter.h:
4191
4192 2009-10-30  Dmitry Titov  <dimich@chromium.org>
4193
4194         Reviewed by Dimitri Glazkov.
4195
4196         [V8] More cleanup after r49949: remove ListenerGuard.
4197         ListenerGuard is no longer needed since EventListeners do not depend on frame or v8 context.
4198         https://bugs.webkit.org/show_bug.cgi?id=30943
4199
4200         Covered by fast/events/add-event-without-document.html which will now pass in Chromium.
4201
4202         * bindings/v8/V8AbstractEventListener.cpp:
4203         (WebCore::V8AbstractEventListener::V8AbstractEventListener):
4204         (WebCore::V8AbstractEventListener::handleEvent):
4205         * bindings/v8/V8AbstractEventListener.h:
4206         * bindings/v8/V8DOMWrapper.cpp:
4207         (WebCore::V8DOMWrapper::getEventListener):
4208         * bindings/v8/V8EventListenerList.h:
4209         (WebCore::V8EventListenerList::findOrCreateWrapper):
4210         * bindings/v8/V8LazyEventListener.cpp:
4211         (WebCore::V8LazyEventListener::V8LazyEventListener):
4212         * bindings/v8/V8Proxy.cpp:
4213         (WebCore::V8Proxy::V8Proxy):
4214         (WebCore::V8Proxy::disconnectFrame):
4215         (WebCore::V8Proxy::clearForNavigation):
4216         * bindings/v8/V8Proxy.h:
4217         * bindings/v8/V8WorkerContextEventListener.cpp:
4218         (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
4219         (WebCore::V8WorkerContextEventListener::handleEvent):
4220         (WebCore::V8WorkerContextEventListener::reportError):
4221         * bindings/v8/V8WorkerContextEventListener.h:
4222         (WebCore::V8WorkerContextEventListener::create):
4223         * bindings/v8/WorkerContextExecutionProxy.cpp:
4224         (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
4225         (WebCore::WorkerContextExecutionProxy::dispose):
4226         (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
4227         * bindings/v8/WorkerContextExecutionProxy.h:
4228         * bindings/v8/custom/V8CustomEventListener.cpp:
4229         (WebCore::V8EventListener::V8EventListener):
4230         * bindings/v8/custom/V8CustomEventListener.h:
4231         (WebCore::V8EventListener::create):
4232
4233 2009-10-30  Shinichiro Hamaji  <hamaji@chromium.org>
4234
4235         Reviewed by Darin Adler.
4236
4237         counterValueForElementById should return space-separated string for multiple counters
4238         https://bugs.webkit.org/show_bug.cgi?id=30939
4239
4240         Test: fast/css/counters/counterValueForElementById.html
4241
4242         * rendering/RenderTreeAsText.cpp:
4243         (WebCore::writeCounterValuesFromChildren):
4244         (WebCore::counterValueForElement):
4245
4246 2009-10-30  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
4247
4248         Reviewed by Gustavo Noronha.
4249
4250         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
4251         (WebCore::MediaPlayerPrivate::paint):
4252         Add some comments to explain what is happening here.
4253
4254 2009-10-30  Alexander Pavlov  <apavlov@chromium.org>
4255
4256         Reviewed by Timothy Hatcher.
4257
4258         Fix Web Inspector crash on the errors/warnings counter click
4259
4260         RenderObject::createVisiblePosition(const Position& position)
4261         understands "null Positions", so we can construct such a Position manually.
4262
4263         https://bugs.webkit.org/show_bug.cgi?id=30499
4264
4265         * rendering/RenderBox.cpp:
4266         (WebCore::RenderBox::positionForPoint):
4267
4268 2009-10-30  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
4269
4270         Reviewed by Xan Lopez.
4271
4272         https://bugs.webkit.org/show_bug.cgi?id=25534
4273         [GTK] Objects of ROLE_TABLE should implement the accessible table interface
4274
4275         Third part of the implementation of AtkTable.
4276
4277         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
4278         (nameFromChildren):
4279         (webkit_accessible_get_name):
4280         New convenience function to construct an object's name using the name(s) of
4281         any children it has.
4282
4283         (atk_table_interface_init):
4284         (webkit_accessible_table_get_column_description):
4285         (webkit_accessible_table_get_row_description):
4286         Implemented.
4287
4288         (webkit_accessible_table_get_column_header):
4289         Stub function added so that webkit_accessible_table_get_column_description
4290         could be implemented in the meantime.
4291
4292 2009-10-30  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
4293
4294         Reviewed by Xan Lopez.
4295
4296         https://bugs.webkit.org/show_bug.cgi?id=25534