2009-03-04 Brady Eidson <beidson@apple.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-03-04  Brady Eidson  <beidson@apple.com>
2
3         Reviewed by Darin Adler
4
5         <rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.
6
7         I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
8         consolidated some of the various decision making pieces of the Cache into the new method
9         FrameLoader::cachePolicy().
10
11         Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader 
12         is reloading.  If it is, we'd evict any existing resource then recreate it.  Quick looks uses the
13         same URL for this image every time and expects it to be reloaded with each new card.
14
15         The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
16         is "ReloadIgnoringCacheData".  This check was lost in the consolidation to the new method.  
17
18         * loader/FrameLoader.cpp:
19         (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible
20           condition for returning CachePolicyReload.
21
22 2009-03-04  Timothy Hatcher  <timothy@apple.com>
23
24         * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
25         "LOCAL STORAGE" and "SESSION STORAGE".
26
27 2009-03-04  Timothy Hatcher  <timothy@apple.com>
28
29         Fix a regression where the Web Inspector console would not animate
30         in or out correctly.
31
32         Reviewed by Anders Carlsson.
33
34         * inspector/front-end/inspector.css: Move a z-index to a child element
35         to get the correct stacking order during the animation.
36
37 2009-03-03  David Hyatt  <hyatt@apple.com>
38
39         https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.
40
41         Make sure to factor clear deltas into y position estimates.  Also avoid doing the comparison of
42         the final position against the y position estimate until after the clear has happened.  This gets rid
43         of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.
44
45         Reviewed by Dan Bernstein
46
47         Added fast/block/float/nested-clearance.html
48
49         * rendering/RenderBlock.cpp:
50         (WebCore::RenderBlock::collapseMargins):
51         (WebCore::RenderBlock::clearFloatsIfNeeded):
52         (WebCore::RenderBlock::estimateVerticalPosition):
53         (WebCore::RenderBlock::layoutBlockChildren):
54         (WebCore::RenderBlock::getClearDelta):
55         * rendering/RenderBlock.h:
56
57 2009-03-02  Kim Grönholm  <kim.gronholm@nomovok.com>
58
59         Reviewed by Simon Hausmann.
60
61         Improvement to 3d transformations rendering in QtWebKit. QTransform is used
62         instead of QMatrix. This allows perspective transformations since QTransform is
63         a true 3x3 matrix.
64
65         * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere.
66         (WebCore::GraphicsContext::getCTM):
67         (WebCore::GraphicsContext::restorePlatformState):
68         (WebCore::GraphicsContext::fillPath):
69         (WebCore::GraphicsContext::strokePath):
70         (WebCore::GraphicsContext::fillRect):
71         (WebCore::GraphicsContext::translate):
72         (WebCore::GraphicsContext::rotate):
73         (WebCore::GraphicsContext::scale):
74         (WebCore::GraphicsContext::concatCTM):
75         * platform/graphics/qt/ImageQt.cpp:
76         (WebCore::Image::drawPattern):
77         * platform/graphics/qt/PathQt.cpp:
78         (WebCore::Path::translate):
79         (WebCore::Path::transform):
80         * platform/graphics/qt/PatternQt.cpp:
81         (WebCore::Pattern::createPlatformPattern):
82         * platform/graphics/qt/TransformationMatrixQt.cpp:
83         (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator
84         to QMatrix with one to QTransform.
85         * platform/graphics/transforms/TransformationMatrix.h:
86         * platform/graphics/qt/FontQt.cpp:
87
88 2009-02-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
89
90         Reviewed by Simon Hausmann.
91
92         https://bugs.webkit.org/show_bug.cgi?id=24151
93         Fix Qt/S60 build break
94
95         * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds
96         * platform/qt/FileSystemQt.cpp: Ditto
97         (WebCore::unloadModule):
98
99 2009-03-03  Mike Belshe  <mike@belshe.com>
100
101         Reviewed by Alexey Proskuryakov.
102
103         https://bugs.webkit.org/show_bug.cgi?id=21939
104         Uninitialized ExceptionCode in DOMWindow::postMessage
105
106         * dom/MessagePort.cpp:
107         (WebCore::MessagePort::postMessage):
108
109 2009-03-03  David Kilzer  <ddkilzer@apple.com>
110
111         <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
112
113         Reviewed by Mark Rowe.
114
115         The fix is to add INSTALLHDRS_COPY_PHASE = YES and
116         INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
117         sure various build phase scripts work with the installhdrs build
118         phase.
119
120         * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
121         based on PLATFORM_NAME to work around the missing definition on
122         Tiger.
123         * Configurations/WebCore.xcconfig: Added
124         JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
125         the "Generate Derived Sources" script.  Added
126         INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
127
128         * WebCore.xcodeproj/project.pbxproj:
129         - Added shell code to prevent running "Check For Global
130           Initializers", "Check For Exit Time Destructors" and "Check
131           For Weak VTables" scripts during the installhdrs build phase.
132         - Made "Generate Derived Sources" work for the installhdrs build
133           phase.  Also simplified setting of CREATE_HASH_TABLE by using
134           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
135
136 2009-03-02  Adam Langley  <agl@google.com>
137
138         Reviewed by Darin Fisher.
139
140         Chromium Linux: Switch to using Skia to render widgets.
141
142         In order to sandbox the Chromium renderer on Linux we need to remove
143         the X connection. GTK cannot render without an X connection so, for
144         now, we render widgets ourselves.
145
146         Previously didn't use anti-alias fonts in order to match Windows font
147         rendering exactly. This was helpful when bootstrapping our layout
148         tests. Now, however, we are ready to enable it.
149
150         https://bugs.webkit.org/show_bug.cgi?id=24244
151
152         * platform/chromium/ScrollbarThemeChromium.cpp:
153         (WebCore::ScrollbarThemeChromium::buttonSize):
154         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
155         (WebCore::ScrollbarThemeChromium::scrollbarThickness):
156         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
157         (WebCore::ScrollbarThemeChromium::paintButton):
158         (WebCore::ScrollbarThemeChromium::paintThumb):
159         * platform/graphics/chromium/FontPlatformDataLinux.cpp:
160         (WebCore::FontPlatformData::setupPaint):
161         * platform/graphics/skia/PlatformContextSkia.cpp:
162         (PlatformContextSkia::PlatformContextSkia):
163         (PlatformContextSkia::~PlatformContextSkia):
164         * platform/graphics/skia/PlatformContextSkia.h:
165         * rendering/RenderThemeChromiumGtk.cpp: Removed.
166         * rendering/RenderThemeChromiumGtk.h: Removed.
167         * rendering/RenderThemeChromiumLinux.cpp: Added.
168         * rendering/RenderThemeChromiumLinux.h: Added.
169
170 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
171
172         Reviewed by Darin Fisher.
173
174         https://bugs.webkit.org/show_bug.cgi?id=24261
175         Fix return types.
176
177         Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
178
179         * bindings/v8/V8Binding.h:
180         (WebCore::toInt32): change return type to int
181         (WebCore::toFloat): change return type to float.
182
183 2009-03-03  Anders Carlsson  <andersca@apple.com>
184
185         Reviewed by John Sullivan.
186
187         https://bugs.webkit.org/show_bug.cgi?id=22884
188         <rdar://problem/6449783>
189         modified layout test crashes Safari
190
191         Null check NPStream before dereferencing it.
192         
193         * plugins/PluginView.cpp:
194         (WebCore::PluginView::destroyStream):
195
196 2009-03-03  Eric Carlson  <eric.carlson@apple.com>
197
198         Reviewed by Simon Fraser.
199
200         Fix for <rdar://problem/6641045>
201         Don't call QTKit to get movie properties until movie metadata has been loaded.
202
203         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
204         (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
205         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
206         (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
207         (WebCore::MediaPlayerPrivate::play): Ditto.
208         (WebCore::MediaPlayerPrivate::pause): Ditto.
209         (WebCore::MediaPlayerPrivate::duration): Ditto.
210         (WebCore::MediaPlayerPrivate::currentTime): Ditto.
211         (WebCore::MediaPlayerPrivate::seek): Ditto.
212         (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
213         (WebCore::MediaPlayerPrivate::paused): Ditto.
214         (WebCore::MediaPlayerPrivate::seeking): Ditto.
215         (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
216         (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
217         (WebCore::MediaPlayerPrivate::setVolume): Ditto.
218         (WebCore::MediaPlayerPrivate::setRate): Ditto.
219         (WebCore::MediaPlayerPrivate::dataRate): Ditto.
220         (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
221         (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
222
223 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
224
225         - Spelling fix.
226
227         * page/Console.cpp:
228         (WebCore::Console::profile):
229
230 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
231
232         Reviewed by Darin Fisher.
233
234         https://bugs.webkit.org/show_bug.cgi?id=23657
235         Remove Database API callback IDLs from the project. 
236         They were removed in r40633.
237
238         * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
239
240 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
241
242         Reviewed by Oliver Hunt.
243
244         <rdar://problem/6639110> console.profile() doesn't work without a title
245
246         * page/Console.cpp:
247         (WebCore::Console::profile): If there is no title assume this is a user
248         initiated profile and give it the next incremented title name.
249
250 2009-03-03  Timothy Hatcher  <timothy@apple.com>
251
252         Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
253         the console code and refactored things to have fewer code paths and duplication.
254
255         rdar://problem/6367127
256         https://bugs.webkit.org/show_bug.cgi?id=24329
257
258         Reviewed by Kevin McCullough.
259
260         Test: manual-tests/inspector/console-dir.html
261
262         * bindings/js/JSInspectedObjectWrapper.cpp:
263         (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
264         to fix an ASSERT about using a wrapper from the wrong ExecState.
265         * bindings/js/JSQuarantinedObjectWrapper.cpp:
266         (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
267         (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
268         * inspector/front-end/Console.js:
269         (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
270         When forceObjectFormat is true, the only formatter used is _formatobject.
271         (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
272         (WebInspector.Console.prototype._formatstring): Ditto.
273         (WebInspector.Console.prototype._formatregexp): Ditto.
274         (WebInspector.Console.prototype._formatarray): Ditto.
275         (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
276         (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
277         (WebInspector.Console.prototype._formaterror): Remove the inline argument.
278         (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
279         simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
280         (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
281         (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
282         (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
283         (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
284         * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
285         * inspector/front-end/utilities.js:
286         (Object.type): Return "node" for Node objects.
287         (Object.describe): Handle the "node" type.
288         * page/Console.cpp:
289         (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
290         (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
291         * page/Console.h:
292         (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
293
294 2009-03-03  Scott Violet  <sky@google.com>
295
296         Reviewed by Eric Seidel.
297
298         https://bugs.webkit.org/show_bug.cgi?id=24325
299         Crash on replacing document contents during drop.
300
301         Makes sure a node is in the document during a move before using it.
302
303         Test: fast/events/crash-on-mutate-during-drop.html
304
305         * editing/MoveSelectionCommand.cpp:
306         (WebCore::MoveSelectionCommand::doApply):
307
308 2009-03-03  Jungshik Shin <jshin@chromium.org>
309
310         Reviewed by Eric Seidel.
311
312         https://bugs.webkit.org/show_bug.cgi?id=23028
313         Enable dynamic web font support to Chromium on Windows.
314         Files that were omitted by mistake in the latest patch
315         that was landed.
316
317         * loader/CachedFont.cpp:
318         (WebCore::CachedFont::~CachedFont):
319         (WebCore::CachedFont::ensureCustomFontData):
320         (WebCore::CachedFont::platformDataFromCustomData):
321         (WebCore::CachedFont::allClientsRemoved):
322         * platform/graphics/chromium/FontCustomPlatformData.cpp:
323         (WebCore::EOTStream::EOTStream):
324         (WebCore::createFontCustomPlatformData):
325         * platform/graphics/win/FontCustomPlatformData.cpp:
326         (WebCore::EOTStream::EOTStream):
327         (WebCore::createFontCustomPlatformData):
328
329 2009-03-03  Gustavo Noronha Silva  <gns@gnome.org>
330
331         Reviewed by Alexey Proskuryakov.
332
333         https://bugs.webkit.org/show_bug.cgi?id=16826
334         [Gtk] Implement WebKitDownload
335
336         Make the Soup backend able to handle requests without a frame,
337         since we may have such things now that we support downloads.
338
339         * platform/network/ResourceHandleInternal.h:
340         * platform/network/soup/ResourceHandleSoup.cpp:
341         (WebCore::ResourceHandle::start):
342
343 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
344
345         Reviewed by Eric Seidel.
346
347         https://bugs.webkit.org/show_bug.cgi?id=24331
348         Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
349
350         * bindings/v8/custom/V8AttrCustom.cpp: Added.
351         * bindings/v8/custom/V8CustomBinding.cpp: Added.
352         * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
353         * bindings/v8/custom/V8ElementCustom.cpp: Added.
354         * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
355         * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
356
357 2009-03-03  Brady Eidson  <beidson@apple.com>
358
359         Reviewed by Darin Adler
360
361         <rdar://problem/6616664> - Quick looks of various file types is broken
362
363         In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
364         for non-HTTP loads when the underlying ResourceRequest changed.  Unfortunately it was a little
365         overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
366
367         Partially reverted behavior to always set the mainDocumentURL in situations when we would've
368         before that patch.
369
370         * loader/FrameLoader.cpp:
371         (WebCore::FrameLoader::addExtraFieldsToRequest):
372
373         * platform/network/ResourceRequestBase.cpp:
374         (WebCore::ResourceRequestBase::setMainDocumentURL):
375
376 2009-03-03  Chris Marrin  <cmarrin@apple.com>
377
378         Reviewed by Simon Fraser.
379
380         https://bugs.webkit.org/show_bug.cgi?id=24256
381
382         Added a WebCoreForceSoftwareAnimation flag.
383
384         * platform/graphics/mac/GraphicsLayerCA.mm:
385         (WebCore::forceSoftwareAnimation):
386         (WebCore::GraphicsLayerCA::setOpacity):
387         (WebCore::GraphicsLayerCA::animateTransform):
388         (WebCore::GraphicsLayerCA::animateFloat):
389
390 2009-03-02  Chris Marrin  <cmarrin@apple.com>
391
392         Reviewed by Sam Weinig.
393
394         https://bugs.webkit.org/show_bug.cgi?id=24257
395
396         Added prototype properties for several classes with constructors that
397         were missing them, including the one mentioned in the bug.
398
399         Test: fast/dom/Window/custom-constructors.html
400
401         * bindings/js/JSAudioConstructor.cpp:
402         (WebCore::JSAudioConstructor::JSAudioConstructor):
403         * bindings/js/JSDOMWindowBase.cpp:
404         (jsDOMWindowBaseWebKitCSSMatrix):
405         * bindings/js/JSImageConstructor.cpp:
406         (WebCore::JSImageConstructor::JSImageConstructor):
407         * bindings/js/JSOptionConstructor.cpp:
408         (WebCore::JSOptionConstructor::JSOptionConstructor):
409         * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
410         (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
411         * bindings/js/JSWebKitCSSMatrixConstructor.h:
412         * bindings/js/JSWebKitPointConstructor.cpp:
413         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
414         * bindings/js/JSWorkerConstructor.cpp:
415         (WebCore::JSWorkerConstructor::JSWorkerConstructor):
416
417 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
418
419         Reviewed by Darin Fisher.
420
421         https://bugs.webkit.org/show_bug.cgi?id=24321
422         Add V8 bindings headers.
423
424         * bindings/v8/V8Binding.h: Added.
425         * bindings/v8/V8Proxy.h: Added.
426         * bindings/v8/custom/V8CustomBinding.h: Added.
427         * bindings/v8/custom/V8CustomEventListener.h: Added.
428
429 2009-03-03  Jungshik Shin <jshin@chromium.org>
430
431         Reviewed by Eric Seidel.
432
433         https://bugs.webkit.org/show_bug.cgi?id=23803
434         Fix an 'off-by-1' error in ChromiumWin's font fallback.
435
436         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
437         (WebCore::FontCache::getFontDataForCharacters):
438
439 2009-03-03  Jungshik Shin  <jshin@chromium.org>
440
441         Reviewed by Eric Seidel.
442
443         http://bugs.webkit.org/show_bug.cgi?id=23028
444         Enable dynamic web font support to Chromium on Windows: Part 1
445         - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
446           from platform/graphics/win because both Windows port and Chromium Windows
447           port will use them.
448         - Adjust WebCore.vcproj accordingly.
449
450         * WebCore.vcproj/WebCore.vcproj:
451         * platform/graphics/opentype: Added.
452         * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
453         * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
454         * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
455         * platform/graphics/win/OpenTypeUtilities.h: Removed.
456
457 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
458
459         Reviewed by Dave Hyatt
460
461         https://bugs.webkit.org/show_bug.cgi?id=24312
462         
463         Take 3D transforms into account when hit testing:
464         
465         1. Maintain a bit on each RenderLayer that is set when the layer
466            has 3d descendants, so that we know when to fall into the slow
467            hit testing path.
468            
469         2. Make a ref-counted HitTestingTransformState, which is used to store
470            an accumulated transform, and the hit test point, and hitTestRect
471            in the plane of the ancestor non-3d ('flattening') layer.
472            
473            It's ref-counted so we can heap allocate it (to avoid stack bloat),
474            and avoid copying when hitTestLayer calls itself after applying the transform.
475            
476         3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
477            3D transforms, or to do deep depth-testing when traversing a preserves-3d
478            hierarchy. When hit, layers compute a z-offset from the ancestor flattening
479            layer, which allows for correct depth testing.
480            
481            The existing early-return codepath is unaffected when there are no 3d transforms
482            and no preserve-3d.
483
484         * rendering/RenderLayer.cpp:
485         (WebCore::RenderLayer::RenderLayer):
486         (WebCore::RenderLayer::updateTransform):
487         (WebCore::RenderLayer::dirty3DTransformedDescendantStatus):
488         (WebCore::RenderLayer::update3DTransformedDescendantStatus):
489         (WebCore::RenderLayer::hitTest):
490         (WebCore::computeZOffset):
491         (WebCore::RenderLayer::createLocalTransformState):
492         (WebCore::RenderLayer::hitTestLayer):
493         (WebCore::RenderLayer::hitTestContents):
494         * rendering/RenderLayer.h:
495         (WebCore::RenderLayer::preserves3D):
496         (WebCore::RenderLayer::has3DTransform):
497         (WebCore::RenderLayer::setHas3DTransformedDescendant):
498         (WebCore::RenderLayer::has3DTransformedDescendant):
499         * rendering/RenderLayerBacking.cpp:
500         * rendering/TransformState.cpp:
501         (WebCore::TransformState::flatten):
502         (WebCore::TransformState::mappedPoint):
503         (WebCore::HitTestingTransformState::move):
504         (WebCore::HitTestingTransformState::applyTransform):
505         (WebCore::HitTestingTransformState::flatten):
506         (WebCore::HitTestingTransformState::mappedPoint):
507         (WebCore::HitTestingTransformState::mappedQuad):
508         * rendering/TransformState.h:
509         (WebCore::TransformState::TransformState):
510         (WebCore::HitTestingTransformState::create):
511         (WebCore::HitTestingTransformState::move):
512         (WebCore::HitTestingTransformState::HitTestingTransformState):
513
514 2009-03-03  Brett Wilson  <brettw@chromium.org>
515
516         Fix uninitialized memory reads in the Chromium Windows transparency
517         code that were identified by Purify,
518
519         Reviewed by Darin Fisher.
520
521         * platform/graphics/chromium/TransparencyWin.cpp:
522         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
523         (WebCore::TransparencyWin::initializeNewContext):
524
525 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
526
527         Reviewed by Dave Hyatt
528
529         https://bugs.webkit.org/show_bug.cgi?id=24312
530         
531         Factor the code that compute a transform relative to the container
532         into RenderObject::transformFromContainer().
533         
534         * rendering/RenderBox.cpp:
535         (WebCore::RenderBox::mapLocalToAbsolutePoint):
536         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
537         * rendering/RenderObject.cpp:
538         (WebCore::RenderObject::transformFromContainer):
539         * rendering/RenderObject.h:
540
541 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
542
543         Reviewed by Dave Hyatt
544
545         https://bugs.webkit.org/show_bug.cgi?id=24317
546         
547         Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
548         the superclass found a node, otherwise we set the innerNode of the
549         HitTestResult, but don't actually report that we found a hit.
550
551         * rendering/RenderTextControlMultiLine.cpp:
552         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
553
554 2009-03-03  Onne Gorter  <onne.gorter@avinity.net>
555
556         Reviewed by Anders Carlsson.
557
558         https://bugs.webkit.org/show_bug.cgi?id=23707
559         resizing plugins does not work, because the plugin never gets informed
560
561         Make gtk plugins resize correctly, by sending them the setwindow event
562         correctly. Also ensure that all plugin eventing is done with correct
563         locking/calling. Mostly copied from mac implementation.
564
565         manual test: manual-tests/gtk/plugin-resize-scroll.html
566
567         * plugins/PluginView.h:
568         * plugins/gtk/PluginViewGtk.cpp:
569         (WebCore::PluginView::dispatchNPEvent):
570         ensure locking/calling for NPEvents
571         (WebCore::PluginView::updatePluginWidget):
572         if something changed, let setNPWindowIfNeeded handle it
573         (WebCore::PluginView::paint):
574         (WebCore::PluginView::handleKeyboardEvent):
575         (WebCore::PluginView::handleMouseEvent):
576         ensure calling conventions
577         (WebCore::PluginView::setNPWindowRect):
578         just pass control to setNPWindowIfNeeded
579         (WebCore::PluginView::setNPWindowIfNeeded):
580         event the plugin correctly of new window
581         (WebCore::PluginView::init):
582         init through the new setup
583
584 2009-03-03  Mike Belshe  <mike@belshe.com>
585
586         Reviewed by Darin Fisher.
587
588         https://bugs.webkit.org/show_bug.cgi?id=24311
589         Make IDL returning DOMObject use [V8Custom]
590
591         * dom/Document.idl:
592         * html/HTMLCanvasElement.idl:
593
594 2009-03-02  Simon Fraser  <simon.fraser@apple.com>
595
596         Reviewed by Adele Peterson
597
598         https://bugs.webkit.org/show_bug.cgi?id=24313
599         
600         If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
601         HitTestResult, then it had better well return |true|. And m_innerBlock
602         could never have been set as the hit node by the superclass, because
603         the superclass knows nothing about m_innerBlock.
604         
605         Test: fast/forms/input-hit-test-border.html
606
607         * rendering/RenderTextControlSingleLine.cpp:
608         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
609
610 2009-03-02  Sam Weinig  <sam@webkit.org>
611
612         Reviewed by Mark Rowe.
613
614         Enable Geolocation (except on Tiger and Leopard).
615
616         * Configurations/WebCore.xcconfig:
617
618 2009-03-02  Ojan Vafai  <ojan@chromium.org>
619
620         Reviewed by Adele Peterson.
621
622         Fix https://bugs.webkit.org/show_bug.cgi?id=24307
623         Null out m_highlightedNode on hideHighlight().
624         Ran WebCore/manual-tests/inspector/highlight-nodes.html.
625
626         * inspector/InspectorController.cpp:
627         (WebCore::InspectorController::hideHighlight):
628
629 2009-03-02  Sam Weinig  <sam@webkit.org>
630
631         Reviewed by Geoffrey Garen.
632
633         Fix for <rdar://problem/6507404> Add Geolocation support.
634
635         This is not yet turned on for any Mac platform.
636
637         * WebCore.xcodeproj/project.pbxproj:
638         * page/Chrome.cpp:
639         (WebCore::Chrome::shouldAllowGeolocationForFrame):
640         * page/Chrome.h:
641         * page/ChromeClient.h:
642         (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
643         * page/Geolocation.cpp:
644         (WebCore::Geolocation::Geolocation):
645         (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
646         will not be alive at this point.
647         (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
648         return a PERMISSION_DENIED if not.
649         (WebCore::Geolocation::watchPosition): Ditto.
650         (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
651         to allow geolocation and cache the result. 
652         * page/Geolocation.h:
653         (WebCore::Geolocation::):
654         * platform/GeolocationService.cpp:
655         * platform/GeolocationService.h:
656         (WebCore::GeolocationService::~GeolocationService):
657         (WebCore::GeolocationService::stopUpdating):
658         * platform/mac/GeolocationServiceMac.h: Added.
659         (WebCore::GeolocationServiceMac::lastPosition):
660         (WebCore::GeolocationServiceMac::lastError):
661         * platform/mac/GeolocationServiceMac.mm: Added.
662         (WebCore::GeolocationService::create):
663         (WebCore::GeolocationServiceMac::GeolocationServiceMac):
664         (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
665         (WebCore::GeolocationServiceMac::startUpdating):
666         (WebCore::GeolocationServiceMac::stopUpdating):
667         (WebCore::GeolocationServiceMac::suspend):
668         (WebCore::GeolocationServiceMac::resume):
669         (WebCore::GeolocationServiceMac::positionChanged):
670         (WebCore::GeolocationServiceMac::errorOccurred):
671         (-[WebCoreCoreLocationObserver initWithCallback:]):
672         (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
673         (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
674
675 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
676
677         Build fixes for wxWidgets Mac trunk build.
678
679         * platform/wx/wxcode/mac/carbon/fontprops.cpp:
680         (wxFontProperties::wxFontProperties):
681         (GetTextExtent):
682         * webcore-wx.bkl:
683
684 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
685
686         wxGTK missing header build fix.
687
688         * platform/wx/wxcode/gtk/fontprops.cpp:
689
690 2009-03-02  Dan Bernstein  <mitz@apple.com>
691
692         Reviewed by Adam Roben.
693
694         - fix https://bugs.webkit.org/show_bug.cgi?id=21811
695           REGRESSION: Windows Build Not Selecting Proper Font
696
697         * platform/graphics/win/FontCacheWin.cpp:
698         (WebCore::createGDIFont): Added back code to verify that the created
699         HFONT has the requested face name.
700
701 2009-03-02  Timothy Hatcher  <timothy@apple.com>
702
703         Fixes a regression caused by splitting the input and output of console commands.
704
705         https://bugs.webkit.org/show_bug.cgi?id=24293
706
707         Reviewed by Kevin McCullough.
708
709         * inspector/front-end/Console.js:
710         (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
711         normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
712
713 2009-03-02  Timothy Hatcher  <timothy@apple.com>
714
715         Make exception messages and logged Error objects display consistently.
716
717         https://bugs.webkit.org/show_bug.cgi?id=18983
718
719         Reviewed by Adam Roben.
720
721         * English.lproj/localizedStrings.js: Remove a string for line numbers.
722         * inspector/front-end/Console.js:
723         (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
724         boolean to the ConsoleCommandResult constructor and don't pass level.
725         (WebInspector.Console.prototype._formatnode): Fix a className typo.
726         (WebInspector.Console.prototype._formaterror): Add an error-message
727         classed span around the message to show in red and remove the
728         console-message-url class from the link so it doesn't float right.
729         Instead enclose the link in parentheses and use displayNameForURL
730         to shorten the URL in the link.
731         (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
732         how line numbers are shown since link underlining a string with
733         parentheses looks bad.
734         (WebInspector.ConsoleCommandResult): Take an exception boolean flag
735         instead of a level and get line and URL based on that flag.
736         * inspector/front-end/inspector.css: Tweaks to the styles.
737
738 2009-03-02  Ojan Vafai  <ojan@chromium.org>
739
740         Reviewed by Adele Peterson.
741
742         Bug 24048: extra windows button padding doesn't apply when there's no appearance
743         <https://bugs.webkit.org/show_bug.cgi?id=24048>
744
745         Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
746
747         No tests added as existing tests already cover this behavior.
748
749         * rendering/RenderButton.cpp:
750         (WebCore::RenderButton::setupInnerStyle):
751         * rendering/RenderTheme.cpp:
752         * rendering/RenderTheme.h:
753         (WebCore::RenderTheme::buttonInternalPaddingLeft):
754         (WebCore::RenderTheme::buttonInternalPaddingRight):
755         (WebCore::RenderTheme::buttonInternalPaddingTop):
756         * rendering/RenderThemeChromiumGtk.cpp:
757         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
758         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
759         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
760         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
761         * rendering/RenderThemeChromiumGtk.h:
762         * rendering/RenderThemeChromiumWin.cpp:
763         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
764         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
765         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
766         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
767         * rendering/RenderThemeChromiumWin.h:
768         * rendering/RenderThemeWin.cpp:
769         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
770         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
771         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
772         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
773         * rendering/RenderThemeWin.h:
774
775 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
776
777         Build fix for Qt port.  Remove unnecessary assert.
778
779         * platform/graphics/qt/ImageBufferQt.cpp:
780         (WebCore::ImageBuffer::putImageData):
781
782 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
783
784         Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
785
786         https://bugs.webkit.org/show_bug.cgi?id=24227
787         Ensure that the checkForSolidColor() optimization is correctly triggered
788         for all cases of drawPattern.  Currently, the optimization was not triggered
789         when the check had not been previously performed via a request for the
790         image's NativeImagePtr.
791
792         Implement the Qt version of the checkForSolidColor() method.  Combined with
793         the bug fix this reduces the time it takes to draw a repeating background
794         of a 1x1 image from ~50msecs to ~0msecs on my machine.
795
796         * platform/graphics/BitmapImage.cpp:
797         (WebCore::BitmapImage::BitmapImage):
798         * platform/graphics/BitmapImage.h:
799         (WebCore::BitmapImage::mayFillWithSolidColor):
800         * platform/graphics/Image.h:
801         (WebCore::Image::mayFillWithSolidColor):
802         * platform/graphics/cairo/ImageCairo.cpp:
803         (WebCore::BitmapImage::BitmapImage):
804         (WebCore::BitmapImage::checkForSolidColor):
805         * platform/graphics/cg/ImageCG.cpp:
806         (WebCore::BitmapImage::BitmapImage):
807         (WebCore::BitmapImage::checkForSolidColor):
808         * platform/graphics/qt/ImageQt.cpp:
809         (WebCore::BitmapImage::checkForSolidColor):
810         * platform/graphics/skia/ImageSkia.cpp:
811         (WebCore::BitmapImage::checkForSolidColor):
812         * platform/graphics/wx/ImageWx.cpp:
813         (WebCore::BitmapImage::checkForSolidColor):
814
815 2009-03-02  Gustavo Noronha Silva  <gns@gnome.org>
816
817         Unreviewed build fix; adding missing files to EXTRA_DIST, so that
818         they show up in the tarball.
819
820         * GNUmakefile.am:
821
822 2009-03-02  Dirk Schulze  <krit@webkit.org>
823
824         Reviewed by Holger Freyther.
825
826         Added putImageData to Qt. Discussed with Ariya Hidayat.
827
828         [Qt] lacks putImageData support in Canvas
829         https://bugs.webkit.org/show_bug.cgi?id=22186
830
831         * platform/graphics/qt/ImageBufferQt.cpp:
832         (WebCore::ImageBuffer::putImageData):
833
834 2009-03-02  Timothy Hatcher  <timothy@apple.com>
835
836         Show exception messages again when evaluating bad expressions in the
837         Web Inspector's console.
838
839         https://bugs.webkit.org/show_bug.cgi?id=19890
840
841         Reviewed by Oliver Hunt.
842
843         * bindings/js/JSQuarantinedObjectWrapper.cpp:
844         (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
845         Fix the order in which the exception is set and cleared now that the
846         exception is stored in the shared GlobalData, not per ExecState.
847
848 2009-02-28  Timothy Hatcher  <timothy@apple.com>
849
850         Make input in the Web Inspector console print before any output
851         that might be added by the called function.
852
853         https://bugs.webkit.org/show_bug.cgi?id=19931
854
855         Reviewed by Oliver Hunt.
856
857         * inspector/front-end/Console.js:
858         (WebInspector.Console.prototype._enterKeyPressed): Add the command
859         message before evaluating the result. Associate the originating
860         command to the result, so if they are adjacent there is no divider.
861         (WebInspector.ConsoleCommand): No longer take a result.
862         (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
863         code removed since it isn't used now.
864         (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
865         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
866         Call the ConsoleMessage toMessageElement and add a style class.
867         * inspector/front-end/inspector.css: Add a new style class for
868         adjacent results to hide the divider. Also tweak the position of
869         the disclosure triangle for objects to not use the left margin.
870
871 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
872
873         Reviewed by Oliver Hunt.
874
875         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
876         <https://bugs.webkit.org/show_bug.cgi?id=24282>
877
878         When fetching an array of elements with a range, attachment views need to be returned
879         instead of the actual attachment.
880
881         * page/mac/AccessibilityObjectWrapper.mm:
882         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
883         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
884
885 2009-03-01  Ojan Vafai  <ojan@chromium.org>
886
887         Reviewed by Eric Seidel.
888
889         Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
890         <https://bugs.webkit.org/show_bug.cgi?id=24251>
891         
892         Make RenderObject::positionForCoordinate non-virtual and
893         RenderObject::positionForPoint virtual in preparation for
894         removing positionFor* from RenderObject/RenderText.
895
896         * page/Frame.cpp:
897         (WebCore::Frame::visiblePositionForPoint):
898         * rendering/RenderBR.cpp:
899         (WebCore::RenderBR::positionForPoint):
900         * rendering/RenderBR.h:
901         * rendering/RenderBlock.cpp:
902         (WebCore::RenderBlock::positionForPoint):
903         * rendering/RenderBlock.h:
904         * rendering/RenderBox.cpp:
905         (WebCore::RenderBox::positionForPoint):
906         * rendering/RenderBox.h:
907         * rendering/RenderInline.cpp:
908         (WebCore::RenderInline::positionForPoint):
909         * rendering/RenderInline.h:
910         * rendering/RenderObject.cpp:
911         (WebCore::RenderObject::positionForCoordinates):
912         (WebCore::RenderObject::positionForPoint):
913         * rendering/RenderObject.h:
914         * rendering/RenderReplaced.cpp:
915         (WebCore::RenderReplaced::positionForPoint):
916         * rendering/RenderReplaced.h:
917         * rendering/RenderSVGInlineText.cpp:
918         (WebCore::RenderSVGInlineText::positionForPoint):
919         * rendering/RenderSVGInlineText.h:
920         * rendering/RenderText.cpp:
921         (WebCore::RenderText::positionForPoint):
922         * rendering/RenderText.h:
923
924 2009-03-01  Larry Ewing  <lewing@novell.com>
925
926         Reviewed by Alexey Proskuryakov.
927
928         https://bugs.webkit.org/show_bug.cgi?id=24080
929         NPN_GetValue casting to the wrong type and writing outside bounds
930
931         Make sure to cast the value to the correct type so that only
932         memory owned by the value is written to.
933
934         * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic): 
935         * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
936         * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): 
937         (PluginView::getValue):
938
939 2009-03-01  Jeremy Moskovich  <jeremy@chromium.org>
940
941         Reviewed by Simon Fraser.
942
943         https://bugs.webkit.org/show_bug.cgi?id=24197 and
944         https://bugs.webkit.org/show_bug.cgi?id=23512
945
946         The Windows version of cgColor() is conditionally compiled using
947         !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
948         can use the OS X version instead of the Windows version.
949
950         Also rename cgColor() -> createCGColor()
951
952         No observable change in behavior, so no test.
953
954         * platform/graphics/Color.h:
955         * platform/graphics/cg/ColorCG.cpp:
956         (WebCore::createCGColor):
957         * platform/graphics/cg/GraphicsContextCG.cpp:
958         (WebCore::GraphicsContext::setPlatformShadow):
959         * platform/graphics/mac/ColorMac.mm:
960         (WebCore::createCGColor):
961         * platform/graphics/mac/GraphicsContextMac.mm:
962         (WebCore::GraphicsContext::drawFocusRing):
963         * platform/graphics/mac/GraphicsLayerCA.mm:
964         (WebCore::setLayerBorderColor):
965         (WebCore::setLayerBackgroundColor):
966         (WebCore::GraphicsLayerCA::setBackgroundColor):
967         * platform/graphics/win/GraphicsContextCGWin.cpp:
968         (WebCore::GraphicsContext::drawFocusRing):
969         * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
970         (WebCore::ciColor):
971
972 2009-03-01  David Levin  <levin@chromium.org>
973
974         Reviewed by Alexey Proskuryakov.
975
976         Bug 24271: XMLHttpRequest needs js bindings for Workers.
977         <https://bugs.webkit.org/show_bug.cgi?id=24271>
978
979         Tests: http/tests/xmlhttprequest/workers/methods-async.html
980                http/tests/xmlhttprequest/workers/methods.html
981
982         * bindings/js/JSWorkerContextBase.cpp:
983         (WebCore::JSWorkerContextBase::getOwnPropertySlot):
984         (jsWorkerContextBaseXMLHttpRequest):
985         (setJSWorkerContextBaseXMLHttpRequest):
986         Expose XMLHttpRequest to Workers.
987
988         * bindings/js/JSWorkerContextBase.h:
989
990         * bindings/js/JSXMLHttpRequestConstructor.cpp:
991         (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
992         (WebCore::constructXMLHttpRequest):
993         (WebCore::JSXMLHttpRequestConstructor::mark):
994         Removed the dependencies on Document.
995
996         * bindings/js/JSXMLHttpRequestConstructor.h:
997         (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
998         * dom/EventException.idl:
999         * dom/EventListener.idl:
1000         Chnage to have the NoStaticTables attribute since they are used from XHR.
1001
1002         * loader/WorkerThreadableLoader.cpp:
1003         (WebCore::workerContextDidFinishLoading):
1004         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
1005         Fixed identifier to be unsigned long.
1006
1007         * loader/WorkerThreadableLoader.h:
1008         * workers/WorkerThread.cpp:
1009         (WebCore::WorkerThread::workerThread):
1010         Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
1011
1012         * xml/XMLHttpRequestUpload.cpp:
1013
1014         * xml/XMLHttpRequest.idl:
1015         * xml/XMLHttpRequestException.idl:
1016         * xml/XMLHttpRequestProgressEvent.idl:
1017         * xml/XMLHttpRequestUpload.idl:
1018         Chnage to have the NoStaticTables attribute since they are used from XHR.
1019
1020 2009-03-01  Horia Olaru  <olaru@adobe.com>
1021
1022         Adding manual debugger test cases for bug.
1023
1024         https://bugs.webkit.org/show_bug.cgi?id=21073
1025
1026         Reviewed by Kevin McCullough.
1027
1028         * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
1029         * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
1030         * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
1031         * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
1032         * manual-tests/inspector/resources/loop-statements.js: Added.
1033
1034 2009-03-01  Dan Bernstein  <mitz@apple.com>
1035
1036         Reviewed by Darin Adler.
1037
1038         - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
1039
1040         Test: fast/events/scroll-during-zoom-change.html
1041
1042         * dom/Document.cpp:
1043         (WebCore::Document::recalcStyle): Pause scheduled events during style
1044         reclaculation. Changes to the zoom property result in scroll events
1045         being generated during style recalc, and those events need to be
1046         deferred until the render tree is consistent.
1047         * page/FrameView.cpp:
1048         (WebCore::FrameView::layout): Changed to account for a case in which the
1049         post-layout tasks trigger a nested layout, which reactivates the
1050         post-layout task timer.
1051
1052 2009-03-01  Ross Boucher  <rboucher@gmail.com>
1053
1054         Alphabetically sort scripts in the Script's panel file popup menu.
1055
1056         https://bugs.webkit.org/show_bug.cgi?id=23395
1057
1058         Reviewed by Timothy Hatcher.
1059
1060         * inspector/front-end/ScriptsPanel.js:
1061         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
1062         * inspector/front-end/utilities.js:
1063         (insertionIndexForObjectInListSortedByFunction):
1064         (indexOfObjectInListSortedByFunction):
1065
1066 2009-03-01  Yael Aharon  <yael.aharon@nokia.com>
1067
1068         Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
1069         when creating databases, localStorage or sessionStorage. Changing document.domain
1070         should have no affect on databases, localStorage and sessionStorage in Web Inspector.
1071
1072         https://bugs.webkit.org/show_bug.cgi?id=23844
1073
1074         Reviewed by Timothy Hatcher.
1075
1076         * inspector/InspectorController.cpp:
1077         (WebCore::InspectorController::addDOMStorageScriptResource):
1078         (WebCore::InspectorController::didUseDOMStorage):
1079         * storage/Database.cpp:
1080         (WebCore::Database::openDatabase):
1081
1082 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1083
1084         Reviewed by Holger Freyther.
1085
1086         Avoid leaking errors when reporting GIO errors.
1087
1088         * platform/network/soup/ResourceHandleSoup.cpp:
1089         (WebCore::readCallback):
1090         (WebCore::openCallback):
1091         (WebCore::queryInfoCallback):
1092
1093 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1094
1095         Reviewed by Holger Freyther.
1096
1097         Fixes crash when the GIO backend is given the URI for a directory.
1098
1099         * platform/network/soup/ResourceHandleSoup.cpp:
1100         (WebCore::networkErrorForFile):
1101
1102 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1103
1104         Reviewed by Darin Fisher.
1105
1106         https://bugs.webkit.org/show_bug.cgi?id=24261
1107         Fix V8 custom binding scrubbing error.
1108
1109         Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
1110         Test: traversal/exception-forwarding.html
1111         TesT: traversal/stay-within-root.html
1112
1113         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1114         * bindings/v8/custom/V8NodeIteratorCustom.cpp:
1115         (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
1116         * bindings/v8/custom/V8TreeWalkerCustom.cpp:
1117         (WebCore::toV8): Ditto.
1118
1119 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1120
1121         Reviewed by Darin Fisher.
1122
1123         https://bugs.webkit.org/show_bug.cgi?id=24261
1124         Fix V8 custom binding scrubbing error.
1125
1126         Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
1127
1128         * WebCore.xcodeproj/project.pbxproj:
1129         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1130         (WebCore::cssPropertyName):  Remove dubious checks, left over from
1131             incomplete conversion of parameter from pointer to pass-by-ref.
1132         (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
1133         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
1134
1135 2009-02-28  Xan Lopez  <xan@gnome.org>
1136
1137         Reviewed by Holger Freyther.
1138
1139         https://bugs.webkit.org/show_bug.cgi?id=24263
1140         [GTK] ref ResourceHandle until we are finished with it
1141
1142         Add a ref to the ResourceHandle in startHttp so we can keep it
1143         alive untill all callbacks have been executed, and unref it when
1144         soup tells us it's done with the SoupMessage (in
1145         finishedCallback). Fixes a number of crashes when calling
1146         didReceiveData whould crash because of the handle dying.
1147
1148         * platform/network/soup/ResourceHandleSoup.cpp:
1149         (WebCore::finishedCallback):
1150         (WebCore::ResourceHandle::startHttp):
1151
1152 2009-02-28  Adam Bergkvist <adam.bergkvist@ericsson.com>
1153
1154         Reviewed by Alexey Proskuryakov.
1155
1156         https://bugs.webkit.org/show_bug.cgi?id=24226
1157         [SOUP] HTTP status text is never set
1158
1159         Set HTTP status text to SoupMessage reason_phrase.
1160
1161         * platform/network/soup/ResourceHandleSoup.cpp:
1162         (WebCore::fillResponseFromMessage):
1163
1164 2009-02-28  Dan Bernstein  <mitz@apple.com>
1165
1166         - fix malformed project file
1167
1168         * WebCore.xcodeproj/project.pbxproj:
1169
1170 2009-02-28  Dan Bernstein  <mitz@apple.com>
1171
1172         Reviewed by Oliver Hunt.
1173
1174         - fix https://bugs.webkit.org/show_bug.cgi?id=23848
1175           <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
1176
1177         Test: fast/layers/inline-dirty-z-order-lists.html
1178
1179         * rendering/RenderBox.cpp:
1180         (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
1181         layer's and its stacking context's z-order lists when the layer's
1182         z-index or visibility change from here...
1183         * rendering/RenderBoxModelObject.cpp:
1184         (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
1185         it will apply to RenderInline too.
1186
1187 2009-02-27  Alexey Proskuryakov  <ap@webkit.org>
1188
1189         Reviewed by David Hyatt.
1190
1191         Don't include TextResourceDecoder.h in Document.h
1192
1193         This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
1194         when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
1195
1196         * dom/Document.cpp:
1197         (WebCore::Document::displayStringModifiedByEncoding):
1198         (WebCore::Document::displayBufferModifiedByEncoding):
1199         * dom/Document.h:
1200         * WebCore.base.exp:
1201
1202 2009-02-27  Matt Pennig  <pennig@apple.com>
1203
1204         Reviewed by David Hyatt.
1205
1206         Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
1207         "Fixed elements have 0 as an offsetLeft property"
1208         
1209         Code also brings offsetLeft/Top in full conformance with the spec.
1210         Added two tests, one for fixed-position elements, and one for <html>.
1211         
1212         Tests: fast/dom/Element/fixed-position-offset-parent.html
1213                fast/dom/Element/offsetLeft-offsetTop-html.html
1214
1215         * rendering/RenderBoxModelObject.cpp:
1216         (WebCore::RenderBoxModelObject::offsetLeft):
1217         (WebCore::RenderBoxModelObject::offsetTop):
1218
1219 2009-02-27  Dean Jackson  <dino@apple.com>
1220
1221         Reviewed by Simon Fraser.
1222
1223         renderer()->hasTransform() returns true for elements
1224         with perspective, but no transform, so test for transform
1225         when hit testing. This fixes ASSERT from
1226         https://bugs.webkit.org/show_bug.cgi?id=24252
1227
1228         Test: transforms/no_transform_hit_testing.html
1229
1230         * rendering/RenderLayer.cpp:
1231         (WebCore::RenderLayer::hitTestLayer):
1232
1233 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1234
1235         Reviewed by Darin Fisher.
1236
1237         Fix scrubbing error -- a reversed condition.
1238
1239         * bindings/v8/ScriptValue.h:
1240         (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
1241
1242 2009-02-27  Jian Li  <jianli@chromium.org>
1243
1244         Reviewed by Alexey Proskuryakov.
1245
1246         Add confirmMessageFromWorkerObject to WorkerObjectProxy.
1247         https://bugs.webkit.org/show_bug.cgi?id=24152
1248
1249         * workers/WorkerMessagingProxy.cpp:
1250         (WebCore::MessageWorkerContextTask::performTask):
1251         (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
1252         * workers/WorkerMessagingProxy.h:
1253         * workers/WorkerObjectProxy.h:
1254
1255 2009-02-27  Anders Carlsson  <andersca@apple.com>
1256
1257         Reviewed by David Hyatt.
1258
1259         Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227 
1260         because it leads to assertion failures in the Mac port.
1261         
1262         * platform/graphics/BitmapImage.cpp:
1263         (WebCore::BitmapImage::BitmapImage):
1264         * platform/graphics/BitmapImage.h:
1265         (WebCore::BitmapImage::mayFillWithSolidColor):
1266         * platform/graphics/Image.h:
1267         (WebCore::Image::mayFillWithSolidColor):
1268         * platform/graphics/cairo/ImageCairo.cpp:
1269         (WebCore::BitmapImage::BitmapImage):
1270         * platform/graphics/cg/ImageCG.cpp:
1271         (WebCore::BitmapImage::BitmapImage):
1272         (WebCore::BitmapImage::checkForSolidColor):
1273         * platform/graphics/qt/ImageQt.cpp:
1274         (WebCore::BitmapImage::checkForSolidColor):
1275         * platform/graphics/skia/ImageSkia.cpp:
1276         (WebCore::BitmapImage::checkForSolidColor):
1277         * platform/graphics/wx/ImageWx.cpp:
1278         (WebCore::BitmapImage::checkForSolidColor):
1279
1280 2009-02-27  Adam Barth  <abarth@webkit.org>
1281
1282         Reviewed by Eric Seidel.
1283
1284         https://bugs.webkit.org/show_bug.cgi?id=20249
1285
1286         Add a preference to allow universal access from local URLs to mitigate
1287         some attacks.  Some clients still want to allow this access, so we
1288         expose this as a preference.
1289
1290         * WebCore.base.exp:
1291         * dom/Document.cpp:
1292         (WebCore::Document::initSecurityContext):
1293         * page/SecurityOrigin.cpp:
1294         (WebCore::SecurityOrigin::SecurityOrigin):
1295         * page/Settings.cpp:
1296         (WebCore::Settings::Settings):
1297         (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
1298         * page/Settings.h:
1299         (WebCore::Settings::allowUniversalAccessFromFileUrls):
1300
1301 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1302
1303         Reviewed by Eric Seidel.
1304
1305         https://bugs.webkit.org/show_bug.cgi?id=24229
1306         If an image has no alpha channel there is no reason to use SourceOver.
1307
1308         * platform/graphics/qt/ImageQt.cpp:
1309         (WebCore::Image::drawPattern):
1310         (WebCore::BitmapImage::draw):
1311
1312 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1313
1314         Reviewed by Eric Seidel and Simon Fraser.
1315
1316         https://bugs.webkit.org/show_bug.cgi?id=24227
1317         Ensure that the checkForSolidColor() optimization is correctly triggered
1318         for all cases of drawPattern.  Currently, the optimization was not triggered
1319         when the check had not been previously performed via a request for the
1320         image's NativeImagePtr.
1321
1322         Implement the Qt version of the checkForSolidColor() method.  Combined with
1323         the bug fix this reduces the time it takes to draw a repeating background
1324         of a 1x1 image from ~50msecs to ~0msecs on my machine.
1325
1326         * platform/graphics/BitmapImage.cpp:
1327         (WebCore::BitmapImage::BitmapImage):
1328         * platform/graphics/BitmapImage.h:
1329         (WebCore::BitmapImage::mayFillWithSolidColor):
1330         * platform/graphics/Image.h:
1331         (WebCore::Image::mayFillWithSolidColor):
1332         * platform/graphics/cairo/ImageCairo.cpp:
1333         (WebCore::BitmapImage::BitmapImage):
1334         * platform/graphics/cg/ImageCG.cpp:
1335         (WebCore::BitmapImage::BitmapImage):
1336         (WebCore::BitmapImage::checkForSolidColor):
1337         * platform/graphics/qt/ImageQt.cpp:
1338         (WebCore::BitmapImage::checkForSolidColor):
1339         * platform/graphics/skia/ImageSkia.cpp:
1340         (WebCore::BitmapImage::checkForSolidColor):
1341         * platform/graphics/wx/ImageWx.cpp:
1342         (WebCore::BitmapImage::checkForSolidColor):
1343
1344 2009-02-27  Dirk Schulze  <krit@webkit.org>
1345
1346         Reviewed by Zack Rusin.
1347
1348         Added support for gradients and pattern on Fonts for Qt.
1349
1350         [Qt] gradients and patterns for FontQt
1351         https://bugs.webkit.org/show_bug.cgi?id=24243
1352
1353         * platform/graphics/qt/FontQt.cpp:
1354         (WebCore::Font::drawComplexText):
1355
1356 2009-02-27  Jian Li  <jianli@chromium.org>
1357
1358         Reviewed by Alexey Proskuryakov.
1359
1360         WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
1361         https://bugs.webkit.org/show_bug.cgi?id=24113
1362
1363         * workers/WorkerMessagingProxy.cpp:
1364
1365 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1366
1367         Added a refresh button to storage views.
1368
1369         https://bugs.webkit.org/show_bug.cgi?id=24040
1370
1371         Reviewed by Timothy Hatcher.
1372
1373         * inspector/front-end/DOMStorageItemsView.js:
1374         (WebInspector.DOMStorageItemsView):
1375         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1376         (WebInspector.DOMStorageItemsView.prototype.update):
1377         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
1378         * inspector/front-end/DatabaseTableView.js:
1379         (WebInspector.DatabaseTableView):
1380         (WebInspector.DatabaseTableView.prototype.get statusBarItems):
1381         (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
1382         * inspector/front-end/DatabasesPanel.js:
1383         (WebInspector.DatabasesPanel):
1384         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1385         (WebInspector.DatabasesPanel.prototype.reset):
1386         (WebInspector.DatabasesPanel.prototype.showDatabase):
1387         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1388         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1389         * inspector/front-end/inspector.css:
1390
1391 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1392
1393         Added support for editing/deleting localStorage and sessionStorage items
1394         directly from Web Inspector.
1395
1396         https://bugs.webkit.org/show_bug.cgi?id=23866.
1397
1398         Reviewed by Timothy Hatcher.
1399
1400         * WebCore.vcproj/WebCore.vcproj:
1401         * inspector/front-end/DOMStorageDataGrid.js: Added.
1402         (WebInspector.DOMStorageDataGrid):
1403         (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
1404         (WebInspector.DOMStorageDataGrid.prototype._startEditing):
1405         (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
1406         (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
1407         (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
1408         * inspector/front-end/DOMStorageItemsView.js:
1409         (WebInspector.DOMStorageItemsView):
1410         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1411         (WebInspector.DOMStorageItemsView.prototype.hide):
1412         (WebInspector.DOMStorageItemsView.prototype.update):
1413         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
1414         * inspector/front-end/DatabasesPanel.js:
1415         (WebInspector.DatabasesPanel):
1416         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1417         (WebInspector.DatabasesPanel.prototype.reset):
1418         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1419         (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
1420         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1421         * inspector/front-end/WebKit.qrc:
1422         * inspector/front-end/inspector.css:
1423         * inspector/front-end/inspector.html:
1424
1425 2009-02-26  Brett Wilson  <brettw@chromium.org>
1426
1427         Fix Windows transparency for the Chromium port. Implement a helper
1428         class for handling transparency on Windows. It allows semitransparent
1429         ClearType and semitransparent form controls by making new layers in the
1430         background.
1431
1432         It also replaces the "ThemeHelper" which allows better
1433         scaling and transforms on Windows form controls. In addition to the
1434         functionality that the ThemeHelper did, but additionally handles the
1435         antialiasing properly so that the form controls aren't composited on a
1436         white square.
1437
1438         https://bugs.webkit.org/show_bug.cgi?id=24101
1439
1440         Reviewed by Eric Seidel.
1441
1442         * platform/graphics/chromium/FontChromiumWin.cpp:
1443         (WebCore::):
1444         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
1445         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1446         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
1447         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
1448         (WebCore::Font::drawGlyphs):
1449         * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
1450         * platform/graphics/chromium/ThemeHelperChromiumWin.h:
1451         * platform/graphics/chromium/TransparencyWin.cpp: Added.
1452         (WebCore::):
1453         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
1454         (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
1455         (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
1456         (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
1457         (WebCore::TransparencyWin::TransparencyWin):
1458         (WebCore::TransparencyWin::~TransparencyWin):
1459         (WebCore::TransparencyWin::init):
1460         (WebCore::TransparencyWin::computeLayerSize):
1461         (WebCore::TransparencyWin::setupLayer):
1462         (WebCore::TransparencyWin::setupLayerForNoLayer):
1463         (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
1464         (WebCore::TransparencyWin::setupLayerForTextComposite):
1465         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1466         (WebCore::TransparencyWin::setupTransform):
1467         (WebCore::TransparencyWin::setupTransformForKeepTransform):
1468         (WebCore::TransparencyWin::setupTransformForUntransform):
1469         (WebCore::TransparencyWin::setupTransformForScaleTransform):
1470         (WebCore::TransparencyWin::setTextCompositeColor):
1471         (WebCore::TransparencyWin::initializeNewContext):
1472         (WebCore::TransparencyWin::compositeOpaqueComposite):
1473         (WebCore::TransparencyWin::compositeTextComposite):
1474         (WebCore::TransparencyWin::makeLayerOpaque):
1475         * platform/graphics/chromium/TransparencyWin.h: Added.
1476         (WebCore::TransparencyWin::):
1477         (WebCore::TransparencyWin::context):
1478         (WebCore::TransparencyWin::platformContext):
1479         (WebCore::TransparencyWin::drawRect):
1480         * platform/graphics/skia/GraphicsContextSkia.cpp:
1481         (WebCore::GraphicsContext::endTransparencyLayer):
1482         * platform/graphics/skia/ImageSkia.cpp:
1483         (WebCore::paintSkBitmap):
1484         * rendering/RenderThemeChromiumWin.cpp:
1485         (WebCore::):
1486         (WebCore::RenderThemeChromiumWin::paintButton):
1487         (WebCore::RenderThemeChromiumWin::paintMenuList):
1488         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1489
1490 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1491
1492         Reviewed by Eric Seidel.
1493
1494         https://bugs.webkit.org/show_bug.cgi?id=24211
1495         Add ScheduledAction for V8.
1496
1497         * bindings/v8/ScheduledAction.cpp: Added.
1498         (WebCore::ScheduledAction::ScheduledAction):
1499         (WebCore::ScheduledAction::~ScheduledAction):
1500         (WebCore::ScheduledAction::execute):
1501         * bindings/v8/ScheduledAction.h: Added.
1502         (WebCore::ScheduledAction::ScheduledAction):
1503
1504 2009-02-27  Zack Rusin  <zack@kde.org>
1505
1506         Reviewed by Nikolas Zimmermann.
1507
1508         Qt: be more reasonable about scrolled lines
1509
1510         cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
1511         match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
1512         irritating. so lets scroll vertically by the Qt set number of lines * Qt default
1513         single step scroll
1514
1515         * platform/qt/WheelEventQt.cpp:
1516
1517 2009-02-27  Xan Lopez  <xan@gnome.org>
1518
1519         Rubber-stamped by Alexey Proskuryakov.
1520
1521         https://bugs.webkit.org/show_bug.cgi?id=24222
1522         [GTK] Remove checks for old glib versions
1523
1524         libsoup, which is a hard dependency, needs at least glib 2.15.3,
1525         so remove all glib checks for versions older than that.
1526
1527         * platform/gtk/ContextMenuGtk.cpp:
1528         (WebCore::ContextMenu::ContextMenu):
1529         * platform/gtk/ContextMenuItemGtk.cpp:
1530         (WebCore::ContextMenuItem::setSubMenu):
1531         * platform/gtk/PopupMenuGtk.cpp:
1532         (WebCore::PopupMenu::show):
1533         * platform/gtk/WidgetGtk.cpp:
1534         (WebCore::Widget::retainPlatformWidget):
1535         * platform/network/soup/ResourceHandleSoup.cpp:
1536
1537 2009-02-26  Dirk Schulze  <krit@webkit.org>
1538
1539         Reviewed by Oliver Hunt.
1540
1541         Added support for Gradients and Patterns on filled or stroked Fonts
1542         in Cairo. I also added support for globalAlpha on FontCairo.
1543
1544         [CAIRO] SVG/Canvas fonts miss gradients/pattern support
1545         https://bugs.webkit.org/show_bug.cgi?id=18617
1546
1547         * html/CanvasRenderingContext2D.cpp:
1548         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1549         * platform/graphics/cairo/FontCairo.cpp:
1550         (WebCore::Font::drawGlyphs):
1551
1552 2009-02-26  Stephen White  <senorblanco@chromium.org>
1553
1554         Reviewed by Eric Seidel.
1555
1556         https://bugs.webkit.org/show_bug.cgi?id=23957
1557
1558         Fix for SVG gradient and pattern text for Chromium/skia. 
1559         Added accessors for the fill and stroke gradients to
1560         GraphicsContext.  Changed the paintSkiaText function to take a
1561         GraphicsContext, so we can check for gradients/patterns. 
1562         Changed the skiaDrawText function to set the SkPaint shader
1563         correctly, and to scale up the gradient shader matrix to
1564         encompass the entire text string.  Also offset each glyph
1565         separately, rather than transforming the canvas, so that the
1566         gradient/pattern stays fixed relative to the text origin.
1567
1568         * platform/graphics/GraphicsContext.cpp:
1569         (WebCore::GraphicsContext::getFillGradient):
1570         (WebCore::GraphicsContext::getStrokeGradient):
1571         (WebCore::GraphicsContext::getFillPattern):
1572         (WebCore::GraphicsContext::getStrokePattern):
1573         * platform/graphics/GraphicsContext.h:
1574         * platform/graphics/chromium/FontChromiumWin.cpp:
1575         (WebCore::Font::drawGlyphs):
1576         * platform/graphics/chromium/UniscribeHelper.cpp:
1577         (WebCore::UniscribeHelper::draw):
1578         * platform/graphics/skia/SkiaFontWin.cpp:
1579         (WebCore::windowsCanHandleTextDrawing):
1580         (WebCore::skiaDrawText):
1581         (WebCore::paintSkiaText):
1582         * platform/graphics/skia/SkiaFontWin.h:
1583
1584 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1585
1586         Reviewed by Eric Seidel.
1587
1588         https://bugs.webkit.org/show_bug.cgi?id=24208
1589         Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
1590
1591         * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
1592         (WebCore::ACCESSOR_GETTER):
1593         (WebCore::CALLBACK_FUNC_DECL):
1594         * bindings/v8/custom/V8DocumentCustom.cpp: Added.
1595         (WebCore::CALLBACK_FUNC_DECL):
1596         * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
1597         (WebCore::ACCESSOR_GETTER):
1598         * bindings/v8/custom/V8NodeCustom.cpp: Added.
1599         (WebCore::CALLBACK_FUNC_DECL):
1600
1601 2009-02-26  Gustavo Noronha Silva  <gns@gnome.org>
1602
1603         Unreviewed build fix for building with GNOME Keyring enabled.
1604
1605         * platform/network/soup/webkit-soup-auth-dialog.c:
1606         (show_auth_dialog):
1607
1608 2009-02-26  Xan Lopez  <xan@gnome.org>
1609
1610         Reviewed by Holger Freyther.
1611
1612         https://bugs.webkit.org/show_bug.cgi?id=16947
1613         [GTK] Missing HTTP Auth challenge
1614
1615         Add HTTP authentication dialog with optional GNOME Keyring
1616         storage.
1617
1618         * GNUmakefile.am:
1619         * platform/network/ResourceHandleInternal.h:
1620         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1621         * platform/network/soup/ResourceHandleSoup.cpp:
1622         (WebCore::currentToplevelCallback):
1623         (WebCore::ResourceHandle::startHttp):
1624         (WebCore::ResourceHandle::start):
1625         * platform/network/soup/webkit-soup-auth-dialog.c: Added.
1626         (webkit_soup_auth_dialog_class_init):
1627         (webkit_soup_auth_dialog_init):
1628         (webkit_soup_auth_dialog_session_feature_init):
1629         (free_authData):
1630         (set_password_callback):
1631         (response_callback):
1632         (show_auth_dialog):
1633         (find_password_callback):
1634         (session_authenticate):
1635         (attach):
1636         * platform/network/soup/webkit-soup-auth-dialog.h: Added.
1637
1638 2009-02-25  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
1639
1640         Reviewed by Dave Hyatt.
1641
1642         After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
1643         svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
1644         started failing because Ojan's new code was now *correctly* calling through to
1645         SVG asking for the closest text offset in the last line box, instead of
1646         just returning the offset at the end of the last line box when clicking below a box.
1647
1648         But!  The SVG code was wrong, in that it returned the character offset of the last
1649         character when you asked for a character offset after the end of the box, instead
1650         it should return the offset *after* the last character.  This patch fixes
1651         that behavior by reordering the last two clauses in svgCharacterHitsPosition.
1652
1653         The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
1654         to document what's wrong.  I've also cleaned up the code a bit so it's clearer
1655         what it is doing (which also makes more obvious what's wrong with it).
1656
1657         * rendering/RenderSVGInlineText.cpp:
1658         (WebCore::RenderSVGInlineText::positionForCoordinates):
1659         * rendering/SVGInlineTextBox.cpp:
1660         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
1661         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
1662         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
1663         (WebCore::SVGInlineTextBox::closestCharacterToPosition):
1664         (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
1665
1666 2009-02-26  Darin Fisher  <darin@chromium.org>
1667
1668         Reviewed by Eric Seidel.
1669
1670         Minor cleanup of ChromiumBridge:
1671         Removing unused matchesMIMEType method and s/Javascript/JavaScript/
1672
1673         * platform/chromium/ChromiumBridge.h:
1674         * platform/chromium/MimeTypeRegistryChromium.cpp:
1675         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
1676         (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
1677         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
1678
1679 2009-02-26  David Hyatt  <hyatt@apple.com>
1680
1681         Reviewed by Sam Weinig
1682
1683         Fix text-bottom vertical alignment.  It was incorrectly aligning the bottom of the descent instead of including
1684         the line-height below the descent.
1685
1686         Added fast/inline/vertical-align-text-bottom.html
1687
1688         * rendering/RenderBoxModelObject.cpp:
1689         (WebCore::RenderBoxModelObject::verticalPosition):
1690
1691 2009-02-26  Dirk Schulze  <krit@webkit.org>
1692
1693         Reviewed by Eric Seidel.
1694
1695         Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
1696         ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
1697         just to implement this three methods to support SVG Masking now.
1698  
1699         Make SVG Masking platform aware
1700         https://bugs.webkit.org/show_bug.cgi?id=19243
1701
1702         * GNUmakefile.am:
1703         * WebCore.pro:
1704         * WebCore.vcproj/WebCore.vcproj:
1705         * WebCore.xcodeproj/project.pbxproj:
1706         * svg/graphics/SVGResourceMasker.cpp:
1707         (WebCore::SVGResourceMasker::applyMask):
1708         * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
1709         * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
1710         * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
1711         * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
1712         * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
1713
1714 2009-02-26  Yong Li  <yong.li@torchmobile.com>
1715
1716         Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
1717
1718         Test: http/tests/misc/slow-preload-cancel.html
1719
1720         https://bugs.webkit.org/show_bug.cgi?id=24133
1721         Clear all pending preloads in the DocLoader object when we decide to
1722         cancel its all requests.
1723
1724         * loader/DocLoader.cpp:
1725         (WebCore::DocLoader::clearPendingPreloads):
1726         * loader/DocLoader.h:
1727         * loader/loader.cpp:
1728         (WebCore::Loader::cancelRequests):
1729
1730 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1731
1732         Reviewed by Eric Seidel.
1733
1734         https://bugs.webkit.org/show_bug.cgi?id=24182
1735         Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
1736
1737         * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
1738         (WebCore::CALLBACK_FUNC_DECL):
1739         * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
1740         (WebCore::toV8):
1741         (WebCore::CALLBACK_FUNC_DECL):
1742         * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
1743         (WebCore::toV8):
1744         (WebCore::CALLBACK_FUNC_DECL):
1745
1746 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
1747
1748         Reviewed by Darin Adler.
1749
1750         https://bugs.webkit.org/show_bug.cgi?id=23500
1751         KURL::parse() incorrectly compares its result to original string
1752
1753         * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
1754
1755 2009-02-26  Ojan Vafai  <ojan@chromium.org>
1756
1757         Reviewed by Kevin McCullough.
1758
1759         Manual test for inspector node highlighting.
1760
1761         * manual-tests/inspector/highlight-nodes.html: Added.
1762
1763 2009-02-16  Anantanarayanan Iyengar  <ananta@chromium.org>
1764
1765         Reviewed by Darin Fisher.
1766
1767         https://bugs.webkit.org/show_bug.cgi?id=23973
1768         ScrollView::scrollContents can be invoked during view shutdown.  In
1769         this scenario the FrameView::hostWindow method can return NULL, which
1770         indicates that the frame/page is being destroyed. This causes a crash
1771         when we try to dereference a NULL hostWindow pointer.  Fix is to add a
1772         NULL check for this.  
1773
1774         * platform/ScrollView.cpp:
1775         (WebCore::ScrollView::scrollContents):
1776
1777 2009-02-26  Rahul Kuchhal  <kuchhal@chromium.org>
1778
1779         Reviewed by Dave Hyatt.
1780
1781         https://bugs.webkit.org/show_bug.cgi?id=24003
1782         Fix a crash caused by unsafe type conversion.
1783
1784         Test: fast/block/positioning/absolute-in-inline-rtl-4.html
1785
1786         * rendering/RenderBox.cpp:
1787         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
1788
1789 2009-02-26  Ojan Vafai  <ojan@chromium.org>
1790
1791         Reviewed by Adam Roben.
1792
1793         https://bugs.webkit.org/show_bug.cgi?id=24202
1794         Have drawNodeHighlight clip instead of clearing. This makes it work for
1795         both Safari and Chromium since Chromium draws the inspector highlighting
1796         in the same buffer as the page.
1797
1798         * inspector/InspectorController.cpp:
1799         (WebCore::quadToPath):
1800         (WebCore::drawOutlinedQuad):
1801         (WebCore::drawOutlinedQuadWithClip):
1802         (WebCore::drawHighlightForBox):
1803
1804 2009-02-26  David Hyatt  <hyatt@apple.com>
1805
1806         Reviewed by Dan Bernstein & Darin Adler
1807
1808         Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
1809         
1810         Added fast/inline/inline-continuation-borders.html
1811
1812         * rendering/InlineFlowBox.cpp:
1813         (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
1814
1815 2009-02-26  Simon Fraser  <simon.fraser@apple.com>
1816
1817         Build fix, no review.
1818         
1819         Try to fix the wx build after r41218.
1820
1821         * WebCoreSources.bkl:
1822
1823 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
1824
1825         Reviewed by Darin Adler.
1826
1827         https://bugs.webkit.org/show_bug.cgi?id=19527
1828         ASSERTION FAILED: containerA && containerB
1829
1830         Test: fast/dom/Range/bug-19527.html
1831
1832         * dom/Range.cpp:
1833         (WebCore::Range::isPointInRange):
1834         (WebCore::Range::comparePoint):
1835         Bring the behavior in line with current Firefox, making it impossible for these methods
1836         to pass a null container to compareBoundaryPoints().
1837
1838 2009-02-26  Jonathon Jongsma  <jonathon@quotidian.org>
1839
1840         Reviewed by Holger Freyther.
1841
1842         https://bugs.webkit.org/show_bug.cgi?id=20358
1843
1844         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
1845         (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
1846         should set the computed size rather than the specified size, otherwise
1847         the caps just get rendered normal size.
1848
1849 2009-02-26  Benjamin Meyer  <benjamin.meyer@torchmobile.com>
1850
1851         Reviewed by George Staikos.
1852
1853         https://bugs.webkit.org/show_bug.cgi?id=24062
1854         QNetworkCookieJar expects the url and not the policy url.  Sending the
1855         policy url will cause QNetworkCookieJar to behave incorrectly.  One
1856         example would be a cookie that does not have a path or domain.
1857         QNetworkCookieJar will use the url it is given to fill in default values.
1858         This allows setting cookies on the url of the main frame from an iFrame
1859         when the cookie should be set on the url of the iFrame.
1860
1861         Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
1862
1863         * platform/qt/CookieJarQt.cpp:
1864         (WebCore::setCookies):
1865
1866 2009-02-26  Charles Wei  <charles.wei@torchmobile.com.cn>
1867
1868         Reviewed by George Staikos.
1869
1870         make WebKit/Qt compile with SVG disabled
1871
1872         * WebCore.pro:
1873         * platform/graphics/qt/FontPlatformDataQt.cpp:
1874
1875 2009-02-25  Gustavo Noronha Silva  <gns@gnome.org>
1876
1877         Unreviewed build fix. Add WebCore/workers to the list of paths
1878         searched by the bindings generator perl script.
1879
1880         * GNUmakefile.am:
1881
1882 2009-02-25  Sam Weinig  <sam@webkit.org>
1883
1884         Reviewed by Geoffrey Garen.
1885
1886         Add canvas to the list of RenderObjects that can mark a page as
1887         visually not empty.
1888
1889         * rendering/RenderHTMLCanvas.cpp:
1890         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1891
1892 2009-02-25  Eric Carlson  <eric.carlson@apple.com>
1893
1894         Reviewed by Dave Hyatt.
1895
1896         * rendering/RenderBox.cpp:
1897         (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
1898         as RenderMedia with controls always has a layer.
1899
1900 2009-02-25  Dan Bernstein  <mitz@apple.com>
1901
1902         Reviewed by Simon Fraser.
1903
1904         - fix https://bugs.webkit.org/show_bug.cgi?id=24130
1905           <rdar://problem/6618196> Paint very slow when horizontally resizing
1906
1907         Test: fast/gradients/background-clipped.html
1908
1909         * rendering/RenderBoxModelObject.cpp:
1910         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
1911         destination rectangle passed to drawTiledImage() with the dirty
1912         rectangle. This makes it more likely for the destination rect to be
1913         contained in a single tile rect, which results in a faster code path
1914         being taken down the road (just drawing a single tile instead of
1915         tiling).
1916
1917 2009-02-25  Ojan Vafai  <ojan@chromium.org>
1918
1919         Reviewed by Eric Seidel.
1920
1921         Fix test regressions from positionForCoordinates patch.
1922         https://bugs.webkit.org/show_bug.cgi?id=24148
1923
1924         * rendering/RenderBlock.cpp:
1925         (WebCore::positionForPointWithInlineChildren):
1926         Remove ASSERT that placeholder text codepath is hitting.
1927
1928 2009-02-25  Chris Fleizach  <cfleizach@apple.com>
1929
1930         Reviewed by Beth Dakin.
1931
1932         Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
1933         https://bugs.webkit.org/show_bug.cgi?id=24143
1934
1935         When an AX object is marked dirty, do not create AX elements while going up the parent chain.
1936         Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
1937         Make sure the AXObjectWrapper's have an object before calling them
1938         In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
1939
1940         Test: platform/mac-snowleopard/accessibility/table-updating.html
1941
1942         * WebCore.base.exp:
1943         * page/AXObjectCache.cpp:
1944         (WebCore::AXObjectCache::~AXObjectCache):
1945         (WebCore::AXObjectCache::get):
1946         (WebCore::AXObjectCache::getOrCreate):
1947         (WebCore::AXObjectCache::removeAXID):
1948         (WebCore::AXObjectCache::handleActiveDescendantChanged):
1949         (WebCore::AXObjectCache::handleAriaRoleChanged):
1950         * page/AXObjectCache.h:
1951         * page/AccessibilityImageMapLink.cpp:
1952         (WebCore::AccessibilityImageMapLink::parentObject):
1953         * page/AccessibilityListBox.cpp:
1954         (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
1955         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
1956         * page/AccessibilityListBoxOption.cpp:
1957         (WebCore::AccessibilityListBoxOption::elementRect):
1958         (WebCore::AccessibilityListBoxOption::parentObject):
1959         * page/AccessibilityObject.cpp:
1960         (WebCore::AccessibilityObject::detach):
1961         (WebCore::AccessibilityObject::parentObjectIfExists):
1962         (WebCore::replacedNodeNeedsCharacter):
1963         (WebCore::AccessibilityObject::accessibilityObjectForPosition):
1964         * page/AccessibilityObject.h:
1965         * page/AccessibilityRenderObject.cpp:
1966         (WebCore::AccessibilityRenderObject::firstChild):
1967         (WebCore::AccessibilityRenderObject::lastChild):
1968         (WebCore::AccessibilityRenderObject::previousSibling):
1969         (WebCore::AccessibilityRenderObject::nextSibling):
1970         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
1971         (WebCore::AccessibilityRenderObject::parentObject):
1972         (WebCore::AccessibilityRenderObject::isAttachment):
1973         (WebCore::AccessibilityRenderObject::headingLevel):
1974         (WebCore::AccessibilityRenderObject::anchorElement):
1975         (WebCore::AccessibilityRenderObject::menuForMenuButton):
1976         (WebCore::AccessibilityRenderObject::menuButtonForMenu):
1977         (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
1978         (WebCore::AccessibilityRenderObject::internalLinkElement):
1979         (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
1980         (WebCore::AccessibilityRenderObject::titleUIElement):
1981         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1982         (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
1983         (WebCore::AccessibilityRenderObject::getDocumentLinks):
1984         (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
1985         (WebCore::AccessibilityRenderObject::focusedUIElement):
1986         (WebCore::AccessibilityRenderObject::activeDescendant):
1987         (WebCore::AccessibilityRenderObject::observableObject):
1988         (WebCore::AccessibilityRenderObject::childrenChanged):
1989         (WebCore::AccessibilityRenderObject::addChildren):
1990         * page/AccessibilityRenderObject.h:
1991         (WebCore::AccessibilityRenderObject::setRenderObject):
1992         * page/AccessibilityTable.cpp:
1993         (WebCore::AccessibilityTable::addChildren):
1994         (WebCore::AccessibilityTable::headerContainer):
1995         (WebCore::AccessibilityTable::cellForColumnAndRow):
1996         * page/AccessibilityTableCell.cpp:
1997         (WebCore::AccessibilityTableCell::isTableCell):
1998         (WebCore::AccessibilityTableCell::titleUIElement):
1999         * page/AccessibilityTableColumn.cpp:
2000         (WebCore::AccessibilityTableColumn::headerObjectForSection):
2001         * page/AccessibilityTableRow.cpp:
2002         (WebCore::AccessibilityTableRow::isTableRow):
2003         * page/gtk/AccessibilityObjectWrapperAtk.cpp:
2004         * page/mac/AXObjectCacheMac.mm:
2005         (WebCore::AXObjectCache::postNotification):
2006         (WebCore::AXObjectCache::postNotificationToElement):
2007         * page/mac/AccessibilityObjectWrapper.mm:
2008         (textMarkerForVisiblePosition):
2009         (AXLinkElementForNode):
2010         (nsStringForReplacedNode):
2011         (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
2012         (-[AccessibilityObjectWrapper accessibilityActionNames]):
2013         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2014         (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
2015         (-[AccessibilityObjectWrapper accessibilityHitTest:]):
2016         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
2017         (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
2018         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
2019         (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
2020         (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
2021         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
2022         (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
2023         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
2024         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
2025         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
2026
2027 2009-02-25  Beth Dakin  <bdakin@apple.com>
2028
2029         Reviewed by Geoff Garen.
2030
2031         Re-working of <rdar://problem/6487249> repro crash in 
2032         WebCore::CSSParser::parseFillImage copying entire contents of this 
2033         page
2034         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2035
2036         Fixes a bunch of layout test failures I caused!
2037
2038         * css/CSSParser.cpp:
2039         (WebCore::CSSParser::parseValue):
2040         (WebCore::CSSParser::parseContent):
2041         (WebCore::CSSParser::parseFillImage):
2042         (WebCore::CSSParser::parseFontFaceSrc):
2043         (WebCore::CSSParser::parseBorderImage):
2044
2045 2009-02-25  Dimitri Glazkov  <dglazkov@chromium.org>
2046
2047         Reviewed by Eric Seidel.
2048
2049         https://bugs.webkit.org/show_bug.cgi?id=24174
2050         Add more V8 custom bindings.
2051
2052         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
2053         (WebCore::hasCSSPropertyNamePrefix):
2054         (WebCore::cssPropertyName):
2055         (WebCore::NAMED_PROPERTY_GETTER):
2056         (WebCore::NAMED_PROPERTY_SETTER):
2057         * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
2058         (WebCore::INDEXED_PROPERTY_GETTER):
2059         (WebCore::CALLBACK_FUNC_DECL):
2060         * bindings/v8/custom/V8EventCustom.cpp: Added.
2061         (WebCore::ACCESSOR_SETTER):
2062         (WebCore::ACCESSOR_GETTER):
2063         * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
2064         (WebCore::NAMED_PROPERTY_DELETER):
2065         (WebCore::NAMED_PROPERTY_SETTER):
2066         (WebCore::NAMED_PROPERTY_GETTER):
2067         * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
2068         (WebCore::NAMED_PROPERTY_GETTER):
2069         * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
2070         (WebCore::INDEXED_PROPERTY_GETTER):
2071         (WebCore::NAMED_PROPERTY_GETTER):
2072         * bindings/v8/custom/V8NodeListCustom.cpp: Added.
2073         (WebCore::NAMED_PROPERTY_GETTER):
2074         * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
2075         (WebCore::NAMED_PROPERTY_GETTER):
2076
2077 2009-02-25  Scott Violet  <sky@google.com>
2078
2079         Reviewed by Dave Hyatt.
2080
2081         https://bugs.webkit.org/show_bug.cgi?id=24171
2082         Provides a RenderTheme method for getting the scroll bar size and
2083         changes RenderListBox to use it. RenderTheme returns a size of regular,
2084         and Mac's override to return small. Changes ScrollbarThemeChromium to
2085         use the scrollbarsize of the scrollbar when getting the size
2086         instead of passing in no-args.
2087
2088         * platform/chromium/ScrollbarThemeChromium.cpp:
2089         (WebCore::ScrollbarThemeChromium::trackRect):
2090         (WebCore::ScrollbarThemeChromium::buttonSize):
2091         * rendering/RenderListBox.cpp:
2092         (WebCore::RenderListBox::createScrollbar):
2093         * rendering/RenderTheme.h:
2094         (WebCore::RenderTheme::scrollbarControlSizeForPart):
2095         * rendering/RenderThemeChromiumMac.h:
2096         (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
2097         * rendering/RenderThemeMac.h:
2098         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
2099
2100 2009-02-25  Beth Dakin  <bdakin@apple.com>
2101
2102         Reviewed by Darin Adler.
2103
2104         Fix for <rdar://problem/6487249> repro crash in 
2105         WebCore::CSSParser::parseFillImage copying entire contents of this 
2106         page
2107         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2108
2109         * css/CSSParser.cpp:
2110         (WebCore::CSSParser::parseValue): Null-check m_styleSheet
2111
2112 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
2113
2114         Fix the Qt build.
2115
2116         * WebCore.pro:
2117
2118 2009-02-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2119
2120         Gtk build fix. Not reviewed.
2121
2122         Add files to the build per r41218.
2123         Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp
2124
2125         * GNUmakefile.am:
2126         * page/DOMWindow.cpp:
2127
2128 2009-02-25  Zan Dobersek  <zandobersek@gmail.com>
2129
2130         Reviewed by Alexey Proskuryakov.
2131
2132         https://bugs.webkit.org/show_bug.cgi?id=24043
2133         When faced with URLs with unsupported protocol on Gtk port,
2134         report the error through an idle function and return true, so
2135         a proper resource handle is created.
2136
2137         * platform/network/soup/ResourceHandleSoup.cpp:
2138         (WebCore::reportUnknownProtocolError):
2139         (WebCore::ResourceHandle::start):
2140
2141 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2142
2143         Windows build fix.
2144         Use struct to forward declare ResourceRequest.
2145
2146         * history/HistoryItem.h:
2147         * inspector/InspectorController.h:
2148         * loader/DocumentThreadableLoader.h:
2149         * loader/FrameLoaderClient.h:
2150         * loader/MainResourceLoader.h:
2151         * loader/SubresourceLoader.h:
2152         * loader/SubresourceLoaderClient.h:
2153         * loader/ThreadableLoader.h:
2154         * loader/WorkerThreadableLoader.h:
2155         * platform/CrossThreadCopier.h:
2156         * platform/network/ResourceHandle.h:
2157         * platform/network/ResourceHandleClient.h:
2158         * platform/network/ResourceRequestBase.h:
2159         * platform/network/cf/ResourceRequestCFNet.h:
2160         * xml/XMLHttpRequest.h:
2161
2162 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2163
2164         Partial Windows build fix.
2165         
2166         * DerivedSources.cpp:
2167         * WebCore.vcproj/WebCore.vcproj:
2168
2169 2009-02-25  Dirk Schulze  <krit@webkit.org>
2170
2171         Reviewed by Oliver Hunt.
2172
2173         Ported arcTo to Qt. Qt has no native support for arcTo. This changes
2174         calculate the behavior of arcTo and draws it with lineTo and arc.
2175
2176         [QT] implement Canvas arcTo
2177         https://bugs.webkit.org/show_bug.cgi?id=23873
2178
2179         * platform/graphics/qt/PathQt.cpp:
2180         (WebCore::Path::addArcTo):
2181
2182 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
2183
2184         Reviewed by Dan Bernstein
2185
2186         Remove idl files from Resources, and sort.
2187         
2188         * WebCore.xcodeproj/project.pbxproj:
2189
2190 2009-02-25  Chris Marrin  <cmarrin@apple.com>
2191
2192         Reviewed by Simon Fraser.
2193
2194         https://bugs.webkit.org/show_bug.cgi?id=23943
2195
2196         Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
2197         the window object. Also added WebKitPoint object, which is passed in and out
2198         of these functions.
2199
2200         Test: fast/dom/Window/webkitConvertPoint.html
2201
2202         * DerivedSources.make:
2203         * WebCore.pro:
2204         * WebCore.vcproj/WebCore.vcproj:
2205         * WebCore.xcodeproj/project.pbxproj:
2206         * WebCoreSources.bkl:
2207         * bindings/js/JSDOMWindowBase.cpp:
2208         (jsDOMWindowBaseWebKitPoint):
2209         (setJSDOMWindowBaseWebKitPoint):
2210         * bindings/js/JSWebKitPointConstructor.cpp: Added.
2211         (WebCore::):
2212         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
2213         (WebCore::constructWebKitPoint):
2214         (WebCore::JSWebKitPointConstructor::getConstructData):
2215         * bindings/js/JSWebKitPointConstructor.h: Added.
2216         (WebCore::JSWebKitPointConstructor::classInfo):
2217         * dom/Node.cpp:
2218         (WebCore::Node::convertToPage):
2219         (WebCore::Node::convertFromPage):
2220         * dom/Node.h:
2221         * page/DOMWindow.cpp:
2222         (WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
2223         (WebCore::DOMWindow::webkitConvertPointFromPageToNode):
2224         * page/DOMWindow.h:
2225         * page/DOMWindow.idl:
2226         * page/WebKitPoint.h: Added.
2227         (WebCore::WebKitPoint::create):
2228         (WebCore::WebKitPoint::x):
2229         (WebCore::WebKitPoint::y):
2230         (WebCore::WebKitPoint::setX):
2231         (WebCore::WebKitPoint::setY):
2232         (WebCore::WebKitPoint::WebKitPoint):
2233         * page/WebKitPoint.idl: Added.
2234
2235 2009-02-25  Jian Li  <jianli@chromium.org>
2236
2237         Reviewed by Alexey Proskuryakov.
2238
2239         Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
2240         https://bugs.webkit.org/show_bug.cgi?id=24145
2241
2242         * platform/CrossThreadCopier.cpp:
2243         * platform/CrossThreadCopier.h:
2244
2245 2009-02-25  David Levin  <levin@chromium.org>
2246
2247         Reviewed by Alexey Proskuryakov.
2248
2249         Bug 23688: ThreadableLoader needs a sync implementation for Workers.
2250         <https://bugs.webkit.org/show_bug.cgi?id=23688>
2251
2252         No observable change in behavior, so no test.
2253
2254         * loader/ThreadableLoader.cpp:
2255         (WebCore::ThreadableLoader::loadResourceSynchronously):
2256         * loader/ThreadableLoaderClientWrapper.h:
2257         (WebCore::ThreadableLoaderClientWrapper::clearClient):
2258         (WebCore::ThreadableLoaderClientWrapper::done):
2259         (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
2260         (WebCore::ThreadableLoaderClientWrapper::didFail):
2261         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
2262         (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
2263         Expose whether the loader is done (based on what callbacks were done).
2264
2265         * loader/WorkerThreadableLoader.cpp:
2266         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
2267         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
2268         Each loader is given its own mode so that only its callbacks get through the run loop.
2269
2270         The xhr spec says that the readystatechange events are synchronous, so in the case of a
2271         nested sync xhr no readystatechange events should be fired for the outer xhr.
2272
2273         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
2274
2275         * loader/WorkerThreadableLoader.h:
2276         (WebCore::WorkerThreadableLoader::create):
2277         (WebCore::WorkerThreadableLoader::done):
2278
2279         * workers/WorkerRunLoop.cpp:
2280         (WebCore::WorkerRunLoop::WorkerRunLoop):
2281         * workers/WorkerRunLoop.h:
2282         (WebCore::WorkerRunLoop::createUniqueId):
2283         Simple method to create a uniqueId on demand with respect to the run loop.
2284
2285         * workers/WorkerThread.h:
2286
2287 2009-02-25  David Levin  <levin@chromium.org>
2288
2289         Reviewed by Alexey Proskuryakov.
2290
2291         Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
2292         <https://bugs.webkit.org/show_bug.cgi?id=24089>
2293
2294         Make threadable loader callbacks to happen during the sync load call.
2295
2296         Changes the behavior of sync xhr for insecure redirects in two ways:
2297         + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
2298         + Throws a network exception which is what other browsers do and what the spec
2299         says to do (http://www.w3.org/TR/XMLHttpRequest/).
2300
2301         * loader/DocumentThreadableLoader.cpp:
2302         (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
2303         * loader/DocumentThreadableLoader.h:
2304         * loader/ThreadableLoader.cpp:
2305         (WebCore::ThreadableLoader::loadResourceSynchronously):
2306         * loader/ThreadableLoader.h:
2307         * xml/XMLHttpRequest.cpp:
2308         (WebCore::XMLHttpRequest::XMLHttpRequest):
2309         (WebCore::XMLHttpRequest::loadRequestSynchronously):
2310         (WebCore::XMLHttpRequest::loadRequestAsynchronously):
2311         (WebCore::XMLHttpRequest::didFail):
2312         (WebCore::XMLHttpRequest::didFailRedirectCheck):
2313         * xml/XMLHttpRequest.h:
2314
2315 2009-02-24  Chris Marrin  <cmarrin@apple.com>
2316
2317         Reviewed by David Hyatt.
2318
2319         https://bugs.webkit.org/show_bug.cgi?id=23368
2320
2321         Added logic to correctly hit test accelerated layers.
2322
2323         Tests: animations/animation-hit-test-transform.html
2324                animations/animation-hit-test.html
2325                transitions/transition-hit-test-transform.html
2326                transitions/transition-hit-test.html
2327
2328         * page/animation/KeyframeAnimation.cpp:
2329         (WebCore::KeyframeAnimation::animate):
2330         * rendering/RenderLayer.cpp:
2331         (WebCore::RenderLayer::hitTestLayer):
2332         (WebCore::RenderLayer::updateClipRects):
2333         * rendering/RenderLayerBacking.cpp:
2334         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2335
2336 2009-02-25  Alexey Proskuryakov  <ap@webkit.org>
2337
2338         Reviewed by Darin Adler.
2339
2340         https://bugs.webkit.org/show_bug.cgi?id=24067
2341         REGRESSION: Crash in WebCore::Document::initSecurityContext
2342
2343         The crash started to happen when we removed a check for frame->document() being null.
2344         However, the original document shouldn't be null here, because it is needed to alias
2345         security origins. So, this patch fixes the crash by correcting security origin behavior.
2346
2347         Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
2348         This tests for not crashing, and for inheriting the domain from the document being replaced.
2349         Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
2350         domain to remove a prefix from.
2351
2352         * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
2353         clearing the frame, so that Document::initSecurityContext() could access the old one.
2354
2355 2009-02-25  Jay Campan  <jcampan@google.com>
2356
2357         Reviewed by Darin Fisher.
2358
2359         https://bugs.webkit.org/show_bug.cgi?id=24066
2360
2361         Items in drop-downs were not painted correctly.  Makes sure the
2362         PopupListBox invalidates in the coordinates of the window as this is
2363         FramelessScrollView::invalidateRect paints to.
2364
2365         * platform/chromium/PopupMenuChromium.cpp:
2366         (WebCore::PopupListBox::invalidateRow):
2367
2368 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2369
2370         Reviewed by Anders Carlsson
2371
2372         https://bugs.webkit.org/show_bug.cgi?id=15081
2373         
2374         Make display:none work for applet, emebed and object elements
2375         by calling rendererIsNeeded() on superclasses.
2376
2377         Tests: fast/replaced/applet-display-none.html
2378                fast/replaced/embed-display-none.html
2379                fast/replaced/object-display-none.html
2380
2381         * html/HTMLAppletElement.cpp:
2382         (WebCore::HTMLAppletElement::rendererIsNeeded):
2383         * html/HTMLElement.cpp:
2384         (WebCore::HTMLElement::rendererIsNeeded):
2385         * html/HTMLEmbedElement.cpp:
2386         (WebCore::HTMLEmbedElement::rendererIsNeeded):
2387         * html/HTMLObjectElement.cpp:
2388         (WebCore::HTMLObjectElement::rendererIsNeeded):
2389
2390 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2391
2392         Reviewed by Dave Hyatt
2393
2394         https://bugs.webkit.org/show_bug.cgi?id=24137
2395         
2396         Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
2397         taking perspective and transform-style: preserve-3d into account.
2398         
2399         In order to support transform-style: preserve-3d, which keeps elements in a
2400         3d space, we have to carry along an accumulated matrix in TransformState.
2401         We also need to apply the perspective from the parent, if any, with the
2402         appropriate origin.
2403
2404         * GNUmakefile.am:
2405         * WebCore.base.exp:
2406         * WebCore.pro:
2407         * WebCore.scons:
2408         * WebCore.vcproj/WebCore.vcproj:
2409         * WebCore.xcodeproj/project.pbxproj:
2410         * WebCoreSources.bkl:
2411         * css/CSSComputedStyleDeclaration.cpp:
2412         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2413         * platform/graphics/transforms/TransformationMatrix.cpp:
2414         (WebCore::TransformationMatrix::translate):
2415         (WebCore::TransformationMatrix::translate3d):
2416         (WebCore::TransformationMatrix::translateRight3d):
2417         * platform/graphics/transforms/TransformationMatrix.h:
2418         * rendering/RenderBox.cpp:
2419         (WebCore::RenderBox::mapLocalToAbsolutePoint):
2420         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
2421         * rendering/RenderBox.h:
2422         * rendering/RenderLayer.cpp:
2423         (WebCore::RenderLayer::updateTransform):
2424         (WebCore::RenderLayer::perspectiveTransform):
2425         (WebCore::RenderLayer::perspectiveOrigin):
2426         * rendering/RenderLayer.h:
2427         * rendering/RenderLayerBacking.cpp:
2428         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2429         * rendering/RenderLayerCompositor.cpp:
2430         (WebCore::requiresCompositingLayerForTransform):
2431         (WebCore::RenderLayerCompositor::layerHas3DContent):
2432         * rendering/RenderObject.cpp:
2433         (WebCore::RenderObject::localToAbsolute):
2434         (WebCore::RenderObject::absoluteToLocal):
2435         (WebCore::RenderObject::mapLocalToAbsolutePoint):
2436         (WebCore::RenderObject::mapAbsoluteToLocalPoint):
2437         * rendering/RenderObject.h:
2438         * rendering/RenderTableCell.cpp:
2439         (WebCore::RenderTableCell::mapLocalToAbsolutePoint):
2440         (WebCore::RenderTableCell::mapAbsoluteToLocalPoint):
2441         * rendering/RenderTableCell.h:
2442         * rendering/RenderView.cpp:
2443         (WebCore::RenderView::mapLocalToAbsolutePoint):
2444         (WebCore::RenderView::mapAbsoluteToLocalPoint):
2445         * rendering/RenderView.h:
2446         * rendering/TransformState.cpp: Added.
2447         (WebCore::TransformState::move):
2448         (WebCore::TransformState::applyTransform):
2449         (WebCore::TransformState::flatten):
2450         * rendering/TransformState.h: Added.
2451         (WebCore::TransformState::):
2452         (WebCore::TransformState::TransformState):
2453         (WebCore::TransformState::move):
2454         * rendering/style/RenderStyle.h:
2455         (WebCore::InheritedFlags::hasPerspective):
2456
2457 2009-02-24  Sam Weinig  <sam@webkit.org>
2458
2459         Reviewed by David Hyatt.
2460
2461         Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
2462         Regression (r40837): JavaScript image popup doesn't work
2463
2464         Make the getClientRects and getBoundingClientRect methods return rects
2465         relative to the viewport.
2466
2467         Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
2468
2469         * dom/Element.cpp:
2470         (WebCore::Element::getClientRects):
2471         (WebCore::Element::getBoundingClientRect):
2472
2473 2009-02-24  Ojan Vafai  <ojan@chromium.org>
2474
2475         Reviewed by Eric Seidel.
2476
2477         SVG pages don't have a body or an html element! 
2478         Don't return early if there is no body.
2479
2480         * editing/VisiblePosition.cpp:
2481         (WebCore::VisiblePosition::canonicalPosition):
2482
2483 2009-02-23  David Hyatt  <hyatt@apple.com>
2484
2485         Reviewed by Eric Seidel
2486
2487         https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden
2488         
2489         This patch reworks the painting of overflow.  There is now the concept of a "self-painting layer."  All
2490         layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
2491         reflections or masks).
2492         
2493         If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
2494         The only difference is that the clip has to be pushed and popped when painting the object's children.
2495         
2496         The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case.  With
2497         the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
2498         use the new functions.
2499         
2500         Hit testing has also been patched to check the overflow clip rect first before recurring into children.
2501         
2502         Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
2503         yet, and scrollbar hit testing was already there anyway.  Now the two code paths are more symmetrical.
2504         
2505         Masks are now treated like normal flow layers (just like reflections).
2506
2507         A couple of test cases have been added to fast/overflow to test the stacking order. 
2508
2509         * rendering/InlineFlowBox.cpp:
2510         (WebCore::InlineFlowBox::nodeAtPoint):
2511         (WebCore::InlineFlowBox::paint):
2512         * rendering/RenderBlock.cpp:
2513         (WebCore::RenderBlock::repaintOverhangingFloats):
2514         (WebCore::RenderBlock::paint):
2515         (WebCore::RenderBlock::paintChildren):
2516         (WebCore::RenderBlock::paintObject):
2517         (WebCore::RenderBlock::paintFloats):
2518         (WebCore::RenderBlock::insertFloatingObject):
2519         (WebCore::RenderBlock::floatRect):
2520         (WebCore::RenderBlock::lowestPosition):
2521         (WebCore::RenderBlock::rightmostPosition):
2522         (WebCore::RenderBlock::leftmostPosition):
2523         (WebCore::RenderBlock::addOverhangingFloats):
2524         (WebCore::RenderBlock::nodeAtPoint):
2525         (WebCore::RenderBlock::hitTestContents):
2526         * rendering/RenderBox.cpp:
2527         (WebCore::RenderBox::nodeAtPoint):
2528         (WebCore::RenderBox::pushContentsClip):
2529         (WebCore::RenderBox::popContentsClip):
2530         * rendering/RenderBox.h:
2531         (WebCore::RenderBox::paintObject):
2532         * rendering/RenderBoxModelObject.cpp:
2533         (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
2534         * rendering/RenderBoxModelObject.h:
2535         * rendering/RenderLayer.cpp:
2536         (WebCore::RenderLayer::paintLayer):
2537         (WebCore::RenderLayer::hitTestLayer):
2538         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
2539         (WebCore::RenderLayer::isSelfPaintingLayer):
2540         * rendering/RenderLayer.h:
2541         * rendering/RenderTable.cpp:
2542         (WebCore::RenderTable::paint):
2543         (WebCore::RenderTable::paintObject):
2544         (WebCore::RenderTable::nodeAtPoint):
2545         * rendering/RenderTable.h:
2546         * rendering/RenderTableCell.cpp:
2547         (WebCore::RenderTableCell::paint):
2548         * rendering/RenderTableRow.cpp:
2549         (WebCore::RenderTableRow::nodeAtPoint):
2550         (WebCore::RenderTableRow::paint):
2551         * rendering/RenderTableRow.h:
2552         * rendering/RenderTableSection.cpp:
2553         (WebCore::RenderTableSection::paint):
2554         (WebCore::RenderTableSection::paintObject):
2555         (WebCore::RenderTableSection::nodeAtPoint):
2556         * rendering/RenderTableSection.h:
2557         * rendering/RenderTreeAsText.cpp:
2558         (WebCore::write):
2559         (WebCore::writeLayers):
2560
2561 2009-02-24  David Levin  <levin@chromium.org>
2562
2563         Reviewed by NOBODY (build fix).
2564
2565         Attempted build fix for wx-mac.
2566
2567         * WebCoreSources.bkl:
2568
2569 2009-02-24  David Levin  <levin@chromium.org>
2570
2571         Reviewed by NOBODY (build fix).
2572
2573         Attempted build fixes for qt-linux and wx-mac.
2574
2575         * WebCore.pro:
2576         * webcore-base.bkl:
2577
2578 2009-02-24  Ojan Vafai  <ojan@dhcp-172-31-134-214.sfo.corp.google.com>
2579
2580         Reviewed by Sam Weinig.
2581
2582         Fix null pointer error. If the node is the Document, then ownerDocument() 
2583         returns null, document() does not.
2584
2585         * editing/VisiblePosition.cpp:
2586         (WebCore::VisiblePosition::canonicalPosition):
2587
2588 2009-02-24  Jian Li  <jianli@chromium.org>
2589
2590         Reviewed by NOBODY (attempted build fixes).
2591
2592         Fix build break for Windows and Linux.
2593
2594         * GNUmakefile.am:
2595         * WebCore.vcproj/WebCore.vcproj:
2596
2597 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2598
2599         Reviewed by Eric Seidel.
2600
2601         https://bugs.webkit.org/show_bug.cgi?id=24131
2602         Fix-up COM/RefCounted dichotomy in Chromium port.
2603
2604         * page/chromium/AccessibilityObjectWrapper.h:
2605         (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
2606         explicit setting of recount.
2607
2608 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2609
2610         Reviewed by Eric Seidel.
2611
2612         https://bugs.webkit.org/show_bug.cgi?id=24141
2613         Add clarity to V8 interceptor helper function.
2614
2615         * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
2616         (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
2617         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
2618         (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
2619         (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
2620
2621 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2622
2623         Reviewed by Eric Seidel
2624
2625         Minor numeric cleanup: convert float literals to doubles.
2626         
2627         * platform/graphics/transforms/RotateTransformOperation.cpp:
2628         (WebCore::RotateTransformOperation::blend):
2629
2630 2009-02-24  Mark Mentovai  <mark@chromium.org>
2631
2632         Reviewed by Eric Seidel.
2633
2634         https://bugs.webkit.org/show_bug.cgi?id=24139
2635         Add missing include.
2636
2637         * bindings/v8/ScriptInstance.h:
2638
2639 2009-02-24  Jian Li  <jianli@chromium.org>
2640
2641         Reviewed by Alexey Proskuryakov.
2642
2643         Move worker related files from dom directory to worker directory under WebCore.
2644         https://bugs.webkit.org/show_bug.cgi?id=24123
2645
2646         * DerivedSources.make:
2647         * GNUmakefile.am:
2648         * WebCore.pro:
2649         * WebCore.scons:
2650         * WebCore.vcproj/MigrateIDLAndScripts:
2651         * WebCore.vcproj/WebCore.vcproj:
2652         * WebCore.xcodeproj/project.pbxproj:
2653         * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
2654         * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
2655         * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
2656         * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
2657         * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
2658         * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
2659         * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
2660         * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
2661         * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
2662         * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
2663         * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
2664         * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
2665         * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
2666         * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
2667         * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
2668         * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
2669         * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
2670         * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
2671         * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
2672         * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
2673
2674 2009-02-05  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
2675
2676         Reviewed by Dave Hyatt.
2677
2678         Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
2679         around divs inside editable regions.
2680         https://bugs.webkit.org/show_bug.cgi?id=23605
2681
2682         Fix clicks outside editable regions from focusing the editable region.
2683         https://bugs.webkit.org/show_bug.cgi?id=23607
2684
2685         Removed editing/selection/contenteditable-click-outside.html as it's
2686         not as useful as our new tests.
2687
2688         Clean up RenderBlock::positionForCoordinates to remove dead code,
2689         duplicate code, and generally make it more readable.
2690
2691         Tests: editing/selection/click-in-margins-inside-editable-div.html
2692                editing/selection/click-in-padding-with-multiple-line-boxes.html
2693                editing/selection/click-outside-editable-div.html
2694
2695         * editing/VisiblePosition.cpp:
2696         (WebCore::VisiblePosition::canonicalPosition):
2697         * rendering/RenderBlock.cpp:
2698         (WebCore::positionForPointRespectingEditingBoundaries):
2699         (WebCore::positionForPointWithInlineChildren):
2700         (WebCore::RenderBlock::positionForCoordinates):
2701         (WebCore::RenderBlock::updateFirstLetter):
2702
2703 2009-02-24  Sam Weinig  <sam@webkit.org>
2704
2705         Reviewed by Geoffrey Garen.
2706
2707         Related to <rdar://problem/6590295>
2708         Allow disabling javascript: urls.
2709
2710         * WebCore.base.exp:
2711         * html/HTMLAnchorElement.cpp:
2712         (WebCore::HTMLAnchorElement::parseMappedAttribute):
2713         * loader/FrameLoader.cpp:
2714         (WebCore::FrameLoader::executeIfJavaScriptURL):
2715         * page/Page.cpp:
2716         (WebCore::Page::Page):
2717         (WebCore::Page::setJavaScriptURLsAreAllowed):
2718         (WebCore::Page::javaScriptURLsAreAllowed):
2719         * page/Page.h:
2720
2721 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2722
2723         Fix build when ACCELERATED_COMPOSITING is turned on
2724         (overflowList() -> normalFlowList()).
2725     
2726         * rendering/RenderLayerBacking.cpp:
2727         (WebCore::RenderLayerBacking::hasNonCompositingContent):
2728         (WebCore::RenderLayerBacking::paintIntoLayer):
2729         * rendering/RenderLayerCompositor.cpp:
2730         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
2731         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2732         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
2733         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
2734         (WebCore::RenderLayerCompositor::layerHas3DContent):
2735
2736 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2737
2738         Reviewed by Darin Adler
2739         
2740         https://bugs.webkit.org/show_bug.cgi?id=24135
2741         
2742         Round the FloatPoint returned by absoluteToLocal(), rather than
2743         truncating it.
2744
2745         * dom/MouseRelatedEvent.cpp:
2746         (WebCore::MouseRelatedEvent::receivedTarget):
2747
2748 2009-02-24  Beth Dakin  <bdakin@apple.com>
2749
2750         Reviewed by Sam Weinig.
2751
2752         Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION: 
2753         Ordered list item marker misaligned when line height is not 1.2 
2754         -and corresponding <rdar://problem/6602506>
2755
2756         This is a regression from http://trac.webkit.org/changeset/40880 
2757         where createInlineBox was taken off of RenderObject and moved to 
2758         RenderBox. The problem was that the RenderBox version still needs 
2759         to be virtual because there is still an existing implementation in 
2760         RenderListMarker. 
2761
2762         * rendering/RenderBox.h:
2763         * rendering/RenderListMarker.cpp:
2764         (WebCore::RenderListMarker::createInlineBox):
2765         * rendering/RenderListMarker.h:
2766
2767 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2768
2769         Reviewed by Eric Seidel.
2770
2771         https://bugs.webkit.org/show_bug.cgi?id=24128
2772         Upstream more V8 custom bindings: constructors, XSLTProcessor.
2773
2774         * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
2775         (WebCore::CALLBACK_FUNC_DECL):
2776         * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
2777         (WebCore::CALLBACK_FUNC_DECL):
2778         * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
2779         (WebCore::CALLBACK_FUNC_DECL):
2780         * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
2781         (WebCore::CALLBACK_FUNC_DECL):
2782         * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
2783         (WebCore::CALLBACK_FUNC_DECL):
2784         * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
2785         (WebCore::CALLBACK_FUNC_DECL):
2786
2787 2009-02-24  David Levin  <levin@chromium.org>
2788
2789         Reviewed by Alexey Proskuryakov.
2790
2791         Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
2792         <https://bugs.webkit.org/show_bug.cgi?id=24090>
2793
2794         No observable change in behavior, so no test.
2795
2796         * dom/WorkerMessagingProxy.cpp:
2797         (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
2798         (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
2799         Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.
2800
2801         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
2802
2803         * dom/WorkerMessagingProxy.h:
2804         * loader/ThreadableLoader.cpp:
2805         (WebCore::ThreadableLoader::create):
2806         * loader/WorkerThreadableLoader.cpp:
2807         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
2808         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
2809         (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
2810         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
2811         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
2812         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
2813         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
2814         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
2815         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
2816         Changed these methods to post task using a mode.
2817
2818         * loader/WorkerThreadableLoader.h:
2819         (WebCore::WorkerThreadableLoader::create):
2820
2821 2009-02-24  Alexey Proskuryakov  <ap@webkit.org>
2822
2823         Reviewed by Darin Adler.
2824
2825         https://bugs.webkit.org/show_bug.cgi?id=24091
2826         <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache
2827
2828         Test: http/tests/appcache/access-via-redirect.php
2829
2830         * loader/appcache/ApplicationCacheGroup.cpp:
2831         (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
2832         not the original one.
2833
2834 2009-02-24  Jian Li  <jianli@chromium.org>
2835
2836         Reviewed by Alexey Proskuryakov.
2837
2838         Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
2839         https://bugs.webkit.org/show_bug.cgi?id=24112
2840
2841         * bindings/js/WorkerScriptController.cpp:
2842         * dom/WorkerContext.cpp:
2843
2844 2009-02-23  Antti Koivisto  <antti@apple.com>
2845
2846         Reviewed by Oliver Hunt.
2847
2848         <rdar://problem/6613796> Extended text codecs registered on webview creation
2849
2850         Comparing a text encoding with string "GBK" ended up constructing
2851         TextEncoding("GBK") which in turn initialized all extended
2852         text codecs.
2853
2854         * platform/text/TextCodecICU.cpp:
2855         (WebCore::TextCodecICU::decode):
2856
2857 2009-02-23  Sam Weinig  <sam@webkit.org>
2858
2859         Fix Qt build.
2860
2861         * bridge/qt/qt_runtime.cpp:
2862         (JSC::Bindings::valueRealType):
2863
2864 2009-02-23  Julien Chaffraix  <jchaffraix@webkit.org>
2865
2866         Reviewed by Darin Adler.
2867
2868         Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)
2869
2870         The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
2871         element created with createElement could have a wrong nodeName (createElement sets the string as the
2872         localName without checking for a prefix).
2873
2874         The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
2875         and will always succeed.
2876         Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
2877         to ensure that).
2878
2879         Test: fast/dom/cloneNode.html
2880
2881         * dom/Element.cpp:
2882         (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
2883         always return an element.
2884
2885         * html/HTMLElement.cpp:
2886         * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.
2887
2888 2009-02-23  Dimitri Glazkov  <dglazkov@chromium.org>
2889
2890         Reviewed by Eric Seidel.
2891
2892         https://bugs.webkit.org/show_bug.cgi?id=24109
2893         Upstream V8 Script abstractions, all except ScriptController.
2894
2895         * bindings/v8/ScriptCachedFrameData.h: Added.
2896         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
2897         (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
2898         (WebCore::ScriptCachedFrameData::restore):
2899         (WebCore::ScriptCachedFrameData::clear):
2900         (WebCore::ScriptCachedFrameData::domWindow):
2901         * bindings/v8/ScriptCallFrame.cpp: Added.
2902         (WebCore::ScriptCallFrame::ScriptCallFrame):
2903         (WebCore::ScriptCallFrame::~ScriptCallFrame):
2904         (WebCore::ScriptCallFrame::argumentAt):
2905         * bindings/v8/ScriptCallFrame.h: Added.
2906         (WebCore::ScriptCallFrame::functionName):
2907         (WebCore::ScriptCallFrame::sourceURL):
2908         (WebCore::ScriptCallFrame::lineNumber):
2909         (WebCore::ScriptCallFrame::argumentCount):
2910         * bindings/v8/ScriptCallStack.cpp: Added.
2911         (WebCore::ScriptCallStack::ScriptCallStack):
2912         (WebCore::ScriptCallStack::~ScriptCallStack):
2913         (WebCore::ScriptCallStack::at):
2914         * bindings/v8/ScriptCallStack.h: Added.
2915         (WebCore::ScriptCallStack::size):
2916         * bindings/v8/ScriptInstance.cpp: Added.
2917         (WebCore::V8ScriptInstance::V8ScriptInstance):
2918         (WebCore::V8ScriptInstance::~V8ScriptInstance):
2919         (WebCore::V8ScriptInstance::instance):
2920         (WebCore::V8ScriptInstance::clear):
2921         (WebCore::V8ScriptInstance::set):
2922         * bindings/v8/ScriptInstance.h: Added.
2923         (WebCore::V8ScriptInstance::create):
2924         * bindings/v8/ScriptSourceCode.h: Added.
2925         (WebCore::ScriptSourceCode::ScriptSourceCode):
2926         (WebCore::ScriptSourceCode::isEmpty):
2927         (WebCore::ScriptSourceCode::source):
2928         (WebCore::ScriptSourceCode::url):
2929         (WebCore::ScriptSourceCode::startLine):
2930         * bindings/v8/ScriptState.h: Added.
2931         (WebCore::ScriptState::hadException):
2932         (WebCore::ScriptState::setException):
2933         (WebCore::ScriptState::exception):
2934         * bindings/v8/ScriptString.h: Added.
2935         (WebCore::ScriptString::ScriptString):
2936         (WebCore::ScriptString::operator String):
2937         (WebCore::ScriptString::isNull):
2938         (WebCore::ScriptString::size):
2939         (WebCore::ScriptString::operator=):
2940         (WebCore::ScriptString::operator+=):
2941         * bindings/v8/ScriptValue.cpp: Added.
2942         (WebCore::ScriptValue::getString):
2943         * bindings/v8/ScriptValue.h: Added.
2944         (WebCore::ScriptValue::ScriptValue):
2945         (WebCore::ScriptValue::operator=):
2946         (WebCore::ScriptValue::operator==):
2947         (WebCore::ScriptValue::operator!=):
2948         (WebCore::ScriptValue::isNull):
2949         (WebCore::ScriptValue::isUndefined):
2950         (WebCore::ScriptValue::clear):
2951         (WebCore::ScriptValue::~ScriptValue):
2952         (WebCore::ScriptValue::v8Value):
2953
2954 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
2955
2956         Reviewed by Timothy Hatcher.
2957
2958         https://bugs.webkit.org/show_bug.cgi?id=24106
2959         The Qt port is crashing on exit because the tear down procedure involves
2960         the WebCore::InspectorController trying to access the JS execution context
2961         for a page that is being deleted.  This patch amends the inspector so
2962         that it does not try and access the execution context of the WebCore::Page
2963         in the midst of deletion.
2964
2965         * inspector/InspectorController.cpp:
2966         (WebCore::InspectorController::inspectedPageDestroyed):
2967         (WebCore::InspectorController::stopUserInitiatedProfiling):
2968
2969 2009-02-23  David Levin  <levin@chromium.org>
2970
2971         Reviewed by Alexey Proskuryakov.
2972
2973         Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
2974         <https://bugs.webkit.org/show_bug.cgi?id=24088>
2975
2976         No observable change in behavior, so no test.
2977
2978         * loader/DocumentThreadableLoader.cpp:
2979         (WebCore::DocumentThreadableLoader::create):
2980         * loader/ThreadableLoaderClient.h:
2981         (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
2982         * loader/ThreadableLoaderClientWrapper.h:
2983         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
2984         * loader/WorkerThreadableLoader.cpp:
2985         (WebCore::workerContextDidFailRedirectCheck):
2986         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
2987         * loader/WorkerThreadableLoader.h:
2988         * xml/XMLHttpRequest.cpp:
2989         (WebCore::XMLHttpRequest::didFinishLoading):
2990         * xml/XMLHttpRequest.h:
2991
2992 2009-02-23  David Levin  <levin@chromium.org>
2993
2994         Reviewed by Alexey Proskuryakov.
2995
2996         Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
2997         <https://bugs.webkit.org/show_bug.cgi?id=24047>
2998
2999         Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
3000         using only MessageQueue::waitForMessageFilteredWithTimeout instead
3001         of three different MessageQueue methods.
3002
3003         No observable change in behavior, so no test.
3004
3005         * dom/WorkerRunLoop.cpp:
3006         (WebCore::ModePredicate::operator()):
3007         Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
3008         (WebCore::WorkerRunLoop::runInMode):
3009         * dom/WorkerRunLoop.h:
3010
3011 2009-02-23  David Hyatt  <hyatt@apple.com>
3012
3013         In preparation for making layers for multicol objects (so that they can properly split child layers
3014         into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
3015         of RenderLayer to use the term "normal flow" instead.
3016
3017         Reviewed by Cameron Zwarich
3018
3019         * rendering/RenderLayer.cpp:
3020         (WebCore::RenderLayer::RenderLayer):
3021         (WebCore::RenderLayer::~RenderLayer):
3022         (WebCore::RenderLayer::setHasVisibleContent):
3023         (WebCore::RenderLayer::enclosingCompositingLayer):
3024         (WebCore::RenderLayer::addChild):
3025         (WebCore::RenderLayer::removeChild):
3026         (WebCore::RenderLayer::paintLayer):
3027         (WebCore::RenderLayer::hitTestLayer):
3028         (WebCore::RenderLayer::dirtyNormalFlowList):
3029         (WebCore::RenderLayer::updateNormalFlowList):
3030         (WebCore::RenderLayer::collectLayers):
3031         (WebCore::RenderLayer::updateLayerListsIfNeeded):
3032         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
3033         (WebCore::RenderLayer::styleChanged):
3034         * rendering/RenderLayer.h:
3035         (WebCore::RenderLayer::isNormalFlowOnly):
3036         (WebCore::RenderLayer::normalFlowList):
3037         * rendering/RenderTreeAsText.cpp:
3038         (WebCore::writeLayers):
3039
3040 2009-02-23  David Hyatt  <hyatt@apple.com>
3041
3042         Fix the stacking order for column rules in multi-column layout.  Column rules should paint as part of the background of an element, just
3043         after all other components of the background have been painted.  This allows negative z-index children to still paint on top of the
3044         column rules (rather than ending up above the background of the box but behind the column rules).
3045
3046         Reviewed by Eric Seidel
3047
3048         Added fast/multicol/column-rules-stacking.html
3049
3050         * rendering/RenderBlock.cpp:
3051         (WebCore::RenderBlock::paintColumnRules):
3052         (WebCore::RenderBlock::paintColumnContents):
3053         (WebCore::RenderBlock::paintObject):
3054         * rendering/RenderBlock.h:
3055
3056 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3057
3058         Reviewed by David Hyatt.
3059
3060         No testcases have been added or modified since this patch should not result in
3061         a behavior change for ports that have layout tests enabled.
3062
3063         Currently, the implementation of GraphicsContext::drawLineForText amongst
3064         the various ports differ in that some of them are honoring the context's
3065         strokeStyle when drawing a text-decoration and some of them are not.
3066         For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
3067         but the Cairo implementation does and has an explicit workaround that
3068         sets the strokeStyle() temporarily.
3069
3070         This patch fixes so that all ports are consistent by explicitly making sure
3071         to set the GraphicsContext strokeStyle to SolidStroke whenever
3072         painting the text-decoration of an InlineFlowBox or InlineTextBox as these
3073         should always use a solid stroke.
3074
3075         This patch addresses these bugs:
3076         https://bugs.webkit.org/show_bug.cgi?id=19364
3077         https://bugs.webkit.org/show_bug.cgi?id=15659
3078
3079         * rendering/InlineFlowBox.cpp:
3080         (WebCore::InlineFlowBox::paintTextDecorations):
3081         * rendering/InlineTextBox.cpp:
3082         (WebCore::InlineTextBox::paintDecoration):
3083
3084 2009-02-23  Scott Violet  <sky@google.com>
3085
3086         Reviewed by Eric Seidel.
3087
3088         https://bugs.webkit.org/show_bug.cgi?id=24098
3089         Bugs in ClipboardChromium
3090
3091         Fixes the following bugs in ClipboardChromium:
3092         * It's possible for the extension to be empty, resulting in a bad file
3093           name, for example, 'foo.' or just '.'.
3094         * We weren't restricting the size of the file to MAX_PATH.
3095         * We weren't removing characters that are invalid for file system names.
3096
3097         * platform/chromium/ClipboardChromium.cpp:
3098         (WebCore::writeImageToDataObject):
3099         * platform/chromium/ClipboardChromium.h:
3100         * platform/chromium/ClipboardChromiumLinux.cpp: Added.
3101         (WebCore::ClipboardChromium::validateFileName):
3102         * platform/chromium/ClipboardChromiumMac.cpp: Added.
3103         (WebCore::ClipboardChromium::validateFileName):
3104         * platform/chromium/ClipboardChromiumWin.cpp: Added.
3105         (WebCore::isInvalidFileCharacter):
3106         (WebCore::ClipboardChromium::validateFileName):
3107
3108 2009-02-23  Thiago Macieira  <thiago.macieira@nokia.com>
3109
3110         Reviewed by Simon Hausmann.
3111
3112         Fix the Copyright notices in a few files
3113
3114         * platform/qt/RenderThemeQt.h:
3115
3116 2009-02-23  Xan Lopez  <xan@gnome.org>
3117
3118         Reviewed by Alexey Proskuryakov.
3119
3120         https://bugs.webkit.org/show_bug.cgi?id=22624
3121         [SOUP][GTK] Need API to get SoupSession from WebKit.
3122
3123         Allow to retrieve the Soup session and modify the code to take
3124         into account users changing features on it.
3125
3126         * platform/network/ResourceHandle.h:
3127         * platform/network/soup/CookieJarSoup.cpp:
3128         (WebCore::defaultCookieJar):
3129         (WebCore::setDefaultCookieJar):
3130         * platform/network/soup/CookieJarSoup.h:
3131         * platform/network/soup/ResourceHandleSoup.cpp:
3132         (WebCore::createSoupSession):
3133         (WebCore::ensureSessionIsInitialized):
3134         (WebCore::ResourceHandle::startHttp):
3135         (WebCore::ResourceHandle::cancel):
3136         (WebCore::ResourceHandle::defaultSession):
3137
3138 2009-02-23  Xan Lopez  <xan@gnome.org>
3139
3140         Reviewed by Alexey Proskuryakov.
3141
3142         https://bugs.webkit.org/show_bug.cgi?id=22624
3143         [SOUP][GTK] Need API to get SoupSession from WebKit.
3144
3145         Remove CURL support.
3146
3147         * GNUmakefile.am:
3148
3149 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3150
3151         Reviewed by Mark Rowe.
3152
3153         Test: fast/dom/empty-hash-and-search.html
3154
3155         https://bugs.webkit.org/show_bug.cgi?id=21147
3156         hash property returns incorrect value for links w/o hash
3157
3158         Make hash() and search() behavior for empty and missing parts match IE and Firefox.
3159
3160         * platform/KURL.cpp:
3161         (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
3162         (WebCore::KURL::prettyURL): Append the query with the question mark.
3163
3164         * page/Location.cpp:
3165         (WebCore::Location::search): Return an empty string if query is empty or missing.
3166         (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
3167
3168         * dom/WorkerLocation.cpp:
3169         (WebCore::WorkerLocation::search):
3170         (WebCore::WorkerLocation::hash):
3171         Match document.location fixes above.
3172
3173         * html/HTMLAnchorElement.cpp:
3174         (WebCore::HTMLAnchorElement::hash):
3175         (WebCore::HTMLAnchorElement::search):
3176         Return an empty string for empty and missing parts.
3177
3178 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3179
3180         Reviewed by Darin Adler.
3181
3182         https://bugs.webkit.org/show_bug.cgi?id=20184
3183         SELECT with no name generates invalid query string
3184
3185         Test: fast/forms/select-no-name.html
3186
3187         * html/HTMLSelectElement.cpp:
3188         (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
3189
3190 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3191
3192         Apply review comments for the previous check-in (forgot to save the file, oops).
3193
3194         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
3195
3196 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3197
3198         Reviewed by Darin Adler.
3199
3200         https://bugs.webkit.org/show_bug.cgi?id=15707
3201         Crash when manipulating document from within an iframe onload function
3202
3203         Test: fast/dom/onload-open.html
3204
3205         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
3206         the current node, because anything can happen when dispatching events.
3207
3208 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3209
3210         Reviewed by Darin Adler.
3211
3212         https://bugs.webkit.org/show_bug.cgi?id=18970
3213         Numerically named input fields cause document.forms loop problems
3214
3215         Test: fast/forms/numeric-input-name.html
3216
3217         * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
3218         latter overrides properties.
3219
3220 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3221
3222         Reviewed by Sam Weinig.
3223
3224         https://bugs.webkit.org/show_bug.cgi?id=24059
3225         Tokenizer::write() return value is never used
3226
3227         * dom/Tokenizer.h:
3228         * dom/XMLTokenizer.cpp:
3229         (WebCore::XMLTokenizer::write):
3230         * dom/XMLTokenizer.h:
3231         * html/HTMLTokenizer.cpp:
3232         (WebCore::HTMLTokenizer::write):
3233         * html/HTMLTokenizer.h:
3234         * loader/FTPDirectoryDocument.cpp:
3235         (WebCore::FTPDirectoryTokenizer::write):
3236         * loader/ImageDocument.cpp:
3237         (WebCore::ImageTokenizer::write):
3238         * loader/MediaDocument.cpp:
3239         (WebCore::MediaTokenizer::write):
3240         * loader/PluginDocument.cpp:
3241         (WebCore::PluginTokenizer::write):
3242         * loader/TextDocument.cpp:
3243         (WebCore::TextTokenizer::write):
3244         Made write() return void, not bool.
3245
3246 2009-02-20  Geoffrey Garen  <ggaren@apple.com>
3247
3248         Reviewed by Sam Weinig.
3249
3250         Updated for JavaScriptCore changes to timeout checking.
3251
3252         * bindings/js/JSCustomPositionCallback.cpp:
3253         (WebCore::JSCustomPositionCallback::handleEvent):
3254         * bindings/js/JSCustomPositionErrorCallback.cpp:
3255         (WebCore::JSCustomPositionErrorCallback::handleEvent):
3256         * bindings/js/JSCustomSQLStatementCallback.cpp:
3257         (WebCore::JSCustomSQLStatementCallback::handleEvent):
3258         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3259         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
3260         * bindings/js/JSCustomSQLTransactionCallback.cpp:
3261         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
3262         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
3263         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
3264         * bindings/js/JSCustomVoidCallback.cpp:
3265         (WebCore::JSCustomVoidCallback::handleEvent):
3266         * bindings/js/JSCustomXPathNSResolver.cpp:
3267         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
3268         * bindings/js/JSDOMWindowBase.cpp:
3269         (WebCore::JSDOMWindowBase::JSDOMWindowBase):
3270         (WebCore::JSDOMWindowBase::commonJSGlobalData):
3271         * bindings/js/JSEventListener.cpp:
3272         (WebCore::JSAbstractEventListener::handleEvent):
3273         * bindings/js/ScheduledAction.cpp:
3274         (WebCore::ScheduledAction::executeFunctionInContext):
3275         * bindings/js/ScriptController.cpp:
3276         (WebCore::ScriptController::evaluate):
3277         * bindings/js/WorkerScriptController.cpp:
3278         (WebCore::WorkerScriptController::evaluate):
3279         (WebCore::WorkerScriptController::forbidExecution):
3280         * bindings/objc/WebScriptObject.mm:
3281         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3282         (-[WebScriptObject evaluateWebScript:]):
3283         * bridge/NP_jsobject.cpp:
3284         (_NPN_InvokeDefault):
3285         (_NPN_Invoke):
3286         (_NPN_Evaluate):
3287         (_NPN_Construct):
3288         * bridge/jni/jni_jsobject.mm:
3289         (JavaJSObject::call):
3290         (JavaJSObject::eval):
3291
3292 2009-02-21  Hironori Bono  <hbono@chromium.org>
3293
3294         Reviewed by Alexey Proskuryakov.
3295
3296         https://bugs.webkit.org/show_bug.cgi?id=23786
3297         [Chromium] line-break characters in a complex text are treated as zero-width spaces
3298
3299         This change prevents the UniscribeHelper class from treating the line-break characters
3300         as whitespaces.
3301
3302         Tests: fast/text/international/bidi-linebreak-001.html
3303                fast/text/international/bidi-linebreak-002.html
3304                fast/text/international/bidi-linebreak-003.html
3305
3306         * platform/graphics/chromium/UniscribeHelper.cpp:
3307         (WebCore::UniscribeHelper::adjustSpaceAdvances):
3308         Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in
3309         the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces,
3310         so does when Chromium renders a simple text.
3311
3312 2009-02-20  Julien Chaffraix  <jchaffraix@webkit.org>
3313
3314         Reviewed by Alexey Proskuryakov.
3315
3316         Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
3317
3318         Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
3319         or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
3320         unneeded.
3321
3322         It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
3323         enables us to use some generated QualifiedName.
3324
3325         * bindings/js/JSOptionConstructor.cpp:
3326         (WebCore::constructHTMLOptionElement):
3327         * dom/Document.cpp:
3328         (WebCore::Document::setTitle):
3329         * dom/XMLTokenizer.cpp:
3330         (WebCore::createXHTMLParserErrorHeader):
3331         (WebCore::XMLTokenizer::insertErrorMessageBlock):
3332         * editing/CompositeEditCommand.cpp:
3333         (WebCore::createBlockPlaceholderElement):
3334         * editing/htmlediting.cpp:
3335         (WebCore::createTabSpanElement):
3336         * html/HTMLSelectElement.cpp:
3337         (WebCore::HTMLSelectElement::setLength):
3338         * loader/FTPDirectoryDocument.cpp:
3339         (WebCore::FTPDirectoryTokenizer::appendEntry):
3340         (WebCore::FTPDirectoryTokenizer::createTDForFilename):
3341         (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
3342         (WebCore::FTPDirectoryTokenizer::createBasicDocument):
3343         * loader/ImageDocument.cpp:
3344         (WebCore::ImageDocument::createDocumentStructure):
3345         * loader/MediaDocument.cpp:
3346         (WebCore::MediaTokenizer::createDocumentStructure):
3347         * loader/PluginDocument.cpp:
3348         (WebCore::PluginTokenizer::createDocumentStructure):
3349         * loader/TextDocument.cpp:
3350         (WebCore::TextTokenizer::write):
3351         * page/Frame.cpp:
3352         (WebCore::Frame::selectionComputedStyle):
3353         (WebCore::Frame::styleForSelectionStart):
3354         Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
3355
3356         * xml/XPathFunctions.cpp:
3357         (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
3358         * page/DragController.cpp:
3359         (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
3360
3361 2009-02-19  Dimitri Glazkov  <dglazkov@chromium.org>
3362
3363         Reviewed by Eric Seidel.
3364
3365         https://bugs.webkit.org/show_bug.cgi?id=24060
3366         Fix up to accommodate for CanvasPixelArray return.
3367
3368         * platform/graphics/skia/ImageBufferSkia.cpp:
3369         (WebCore::ImageBuffer::getImageData): Added an extra data() to call.
3370         (WebCore::ImageBuffer::putImageData): Ditto.
3371
3372 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
3373
3374         Simon Fraser
3375
3376         https://bugs.webkit.org/show_bug.cgi?id=24042
3377         Bug 24042: MediaPlayer should cache plug-in proxy
3378
3379         The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
3380         MediaPlayer will always have created the private media player object before
3381         the plug-in is instantiated and calls back with the proxy object. This is not
3382         true on all platforms because of threading latency, so MediaPlayer should
3383         cache the plug-in proxy so it can pass it to the media engine at a later time.
3384
3385         * platform/graphics/MediaPlayer.cpp:
3386         (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods.
3387         (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto.
3388         (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto.
3389         (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy.
3390         (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine.
3391         (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
3392         * platform/graphics/MediaPlayer.h: Declare m_playerProxy.
3393
3394 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
3395
3396         Simon Fraser.
3397
3398         https://bugs.webkit.org/show_bug.cgi?id=24063
3399         Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element
3400
3401         * html/HTMLMediaElement.cpp:
3402         (WebCore::HTMLMediaElement::HTMLMediaElement):  Rename m_loadRestrictions to m_Restrictions.
3403         Initialize m_internalCall.
3404         (WebCore::HTMLMediaElement::loadTimerFired): Increment m_internalCall around call to load().
3405         (WebCore::HTMLMediaElement::load): Call loadInternal if restrictions check out.
3406         (WebCore::HTMLMediaElement::loadInternal): New, guts of old load()
3407         (WebCore::HTMLMediaElement::setNetworkState): Fix bug introduced in r40943
3408         (WebCore::HTMLMediaElement::play): Call playInternal if restrictions check out.
3409         (WebCore::HTMLMediaElement::playInternal): New, guts of old play()
3410         (WebCore::HTMLMediaElement::pause): Call pauseInternal if restrictions check out.
3411         (WebCore::HTMLMediaElement::pauseInternal): New, guts of old pause()
3412         (WebCore::HTMLMediaElement::togglePlayState): Call playInternal/pauseInternal
3413         (WebCore::HTMLMediaElement::deliverNotification): Remove unnecessary white space.
3414         * html/HTMLMediaElement.h: Rename m_loadRestrictions to m_Restrictions, add m_internalCall,
3415         add RequireUserGestureRateChangeRestriction.
3416
3417 2009-02-20  Darin Fisher  <darin@chromium.org>
3418
3419         Fix build bustage in FileSystemWin.cpp.
3420
3421         Need to return CString() instead of 0 since there are now two CString
3422         constructors that take a pointer type.
3423
3424         * platform/win/FileSystemWin.cpp:
3425         (WebCore::openTemporaryFile):
3426
3427 2009-02-20  Dimitri Glazkov  <dglazkov@chromium.org>
3428
3429         Reviewed by Sam Weinig.
3430
3431         https://bugs.webkit.org/show_bug.cgi?id=23999
3432         Change license headers to accurately reflect code history.
3433
3434         * platform/ContentType.cpp:
3435         * platform/ContentType.h:
3436
3437 2009-02-18  Dimitri Glazkov  <dglazkov@chromium.org>
3438
3439         Reviewed by Antti Koivisto.
3440
3441         https://bugs.webkit.org/show_bug.cgi?id=23999
3442         Split off MIME type parsing into its own class.
3443
3444         * GNUmakefile.am: Added ContentType sources.
3445         * WebCore.pro: Ditto.
3446         * WebCore.scons: Ditto.
3447         * WebCore.vcproj/WebCore.vcproj: Ditto.
3448         * WebCore.xcodeproj/project.pbxproj: Ditto.
3449         * WebCoreSources.bkl: Ditto.
3450         * html/HTMLMediaElement.cpp: Changed to use ContentType.
3451         (WebCore::HTMLMediaElement::selectMediaURL):
3452         * platform/ContentType.cpp: Added.
3453         (WebCore::ContentType::ContentType):
3454         (WebCore::ContentType::parameter):
3455         (WebCore::ContentType::type):
3456         * platform/ContentType.h: Added.
3457         (WebCore::ContentType::raw):
3458         * platform/MIMETypeRegistry.cpp:
3459         * platform/MIMETypeRegistry.h:
3460         * platform/graphics/MediaPlayer.cpp:
3461         (WebCore::MediaPlayer::load):
3462         * rendering/style/ContentData.h: Renamed ContentType to StyleContentType.
3463         * rendering/style/RenderStyleConstants.h: Ditto.
3464         (WebCore::):
3465
3466 2009-02-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3467
3468         Unreviewed build fix.
3469
3470         Use CString() instead of 0.
3471
3472         * platform/gtk/FileSystemGtk.cpp:
3473         (WebCore::openTemporaryFile):
3474         * platform/qt/FileSystemQt.cpp:
3475         (WebCore::openTemporaryFile):
3476
3477 2009-02-20  Gustavo Noronha Silva  <gns@gnome.org>
3478
3479         Reviewed by Holger Freyther.
3480
3481         When dealing with local files, use a path instead of an URI. GFile
3482         has problems decoding URIs with percent signs on them.
3483
3484         * platform/network/soup/ResourceHandleSoup.cpp:
3485         (WebCore::ResourceHandle::startGio):
3486
3487 2009-02-20  Gustavo Noronha Silva  <gns@gnome.org>
3488
3489         Reviewed by Holger Freyther.
3490
3491         Protect the ResourceHandle instance from being destroyed by
3492         didReceiveData inside the GIO readCallback call, so that
3493         cancelling caused by scripts is handled correctly.
3494
3495         * platform/network/soup/ResourceHandleSoup.cpp:
3496         (WebCore::readCallback):
3497
3498 2009-02-20  David Kilzer  <ddkilzer@apple.com>
3499
3500         Make IconDatabaseNone.cpp compile with -Wunused and pass check-for-exit-time-destructors
3501
3502         Reviewed by Sam Weinig.
3503
3504         * loader/icon/IconDatabaseNone.cpp:
3505         (WebCore::IconDatabase::defaultDatabaseFilename): Use DEFINE_STATIC_LOCAL().
3506         (WebCore::IconDatabase::open): Commented out unused parameter.
3507         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto.
3508         (WebCore::IconDatabase::iconForPageURL): Ditto.
3509         (WebCore::IconDatabase::iconURLForPageURL): Ditto.
3510         (WebCore::IconDatabase::defaultIcon): Ditto.
3511         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
3512         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
3513         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
3514         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
3515         (WebCore::IconDatabase::setEnabled): Ditto.
3516         (WebCore::IconDatabase::pageURLMappingCount): Added stub.
3517         (WebCore::IconDatabase::retainedPageURLCount): Ditto.
3518         (WebCore::IconDatabase::iconRecordCount): Ditto.
3519         (WebCore::IconDatabase::iconRecordCountWithData): Ditto.
3520
3521 2009-02-20  David Kilzer  <ddkilzer@apple.com>
3522
3523         Add comment to generated code when shadowing a built-in object
3524
3525         Reviewed by Sam Weinig.
3526
3527         * bindings/scripts/CodeGeneratorJS.pm: Added comment to
3528         generated code output.
3529
3530 2009-02-20  Avi Drissman  <avi@chromium.org>
3531
3532         Reviewed by Eric Seidel.
3533
3534         https://bugs.webkit.org/show_bug.cgi?id=24036
3535         Keyboard events need disambiguation on the Linux platform too.
3536
3537         * platform/chromium/PlatformKeyboardEventChromium.cpp:
3538         (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
3539
3540 2009-02-19  Darin Fisher  <darin@chromium.org>
3541
3542         Reviewed by Eric Seidel.
3543
3544         https://bugs.webkit.org/show_bug.cgi?id=24046
3545
3546         Several improvements to CString:
3547         1- Make it possible to initialize a CString from a CStringBuffer
3548         2- Make it possible to get a CStringBuffer from a CString
3549         3- Change CStringBuffer::data() to return a const pointer to ward off mutation
3550         4- Remove unused releaseBuffer() methods.
3551         5- Make CStringBuffer::create() private to force consumers to get a CStringBuffer from a CString.
3552
3553         * platform/text/CString.cpp:
3554         (WebCore::CString::init):
3555         (WebCore::CString::mutableData):
3556         (WebCore::CString::newUninitialized):
3557         (WebCore::CString::copyBufferIfNeeded):
3558         * platform/text/CString.h:
3559         (WebCore::CStringBuffer::data):
3560         (WebCore::CStringBuffer::length):
3561         (WebCore::CStringBuffer::create):
3562         (WebCore::CStringBuffer::mutableData):
3563         (WebCore::CString::CString):
3564         (WebCore::CString::buffer):
3565
3566 2009-02-19  Dmitry Titov  <dimich@chromium.org>
3567
3568         Reviewed by Alexey Proskuryakov.
3569
3570         https://bugs.webkit.org/show_bug.cgi?id=24017
3571         Remove some usage of Document in Worker.
3572
3573         * dom/WorkerContext.h:
3574         (WebCore::WorkerContext::userAgent):
3575         * dom/Document.cpp:
3576         (WebCore::Document::userAgent):
3577         * dom/Document.h:
3578         * dom/ScriptExecutionContext.h:
3579         Added virtual ScriptExecutionContext::userAgent(const KURL&).
3580         Document implementation uses FrameLoader::userAgent and
3581         WorkerContext receives the string on creation and stores it in a member.
3582
3583         * dom/Worker.cpp:
3584         (WebCore::Worker::Worker):
3585         (WebCore::Worker::notifyFinished):
3586         * dom/Worker.h:
3587         (WebCore::Worker::create):
3588         Instead of Document the Worker constructor now gets a ScriptExecutionContext.
3589         Start using some methods on SEC (like completeURL() and userAgent()).
3590         For others, explicitly case to Document and add a FIXME.
3591         Remove Worker::document() too.
3592
3593 2009-02-20  Gustavo Noronha Silva  <gns@gnome.org>
3594
3595         Rubber-stamped by Holger Freyther.
3596
3597         Do not set httpStatus to SOUP_STATUS_OK when serving local files
3598         to match other ports' behavior, fixing xmlhttprequest test
3599         regressions.
3600
3601         * platform/network/soup/ResourceHandleSoup.cpp:
3602         (WebCore::queryInfoCallback):
3603
3604 2009-02-19  Dan Bernstein  <mitz@apple.com>
3605
3606         Reviewed by Sam Weinig.
3607
3608         - WebCore part of fixing https://bugs.webkit.org/show_bug.cgi?id=24027
3609       &