Versioning.
[WebKit-https.git] / WebCore / ChangeLog
1 === Safari-521.30 ===
2
3 2006-11-10  Timothy Hatcher  <timothy@apple.com>
4
5         Reviewed by Hyatt.
6
7         Check for BHIDDEN in isVisible() also.
8
9         * rendering/RenderStyle.h:
10         (WebCore::BorderValue::isVisible):
11
12 2006-11-10  Timothy Hatcher  <timothy@apple.com>
13
14         Reviewed by Adam.
15
16         <rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
17
18         Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
19
20         * editing/DeleteButtonController.cpp:
21         (WebCore::isDeletableElement):
22         * rendering/RenderStyle.h:
23         (WebCore::BorderValue::isVisible):
24
25 2006-11-10  Adam Roben  <aroben@apple.com>
26
27         Rubberstamped by Anders.
28
29         Back out some accidentally-committed changes from r17711.
30
31         * page/Frame.cpp:
32         (WebCore::Frame::command):
33         (WebCore::FramePrivate::FramePrivate):
34         * page/Frame.h:
35         * page/FramePrivate.h:
36
37 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
38
39         Reviewed by Geoff.
40
41         Add more commands, make toggleBold and toggleItalic executable commands.
42
43         * WebCore.exp:
44         * editing/Editor.cpp:
45         (WebCore::execCopy):
46         (WebCore::execCut):
47         (WebCore::execDelete):
48         (WebCore::execForwardDelete):
49         (WebCore::execPaste):
50         (WebCore::execSelectAll):
51         (WebCore::execToggleBold):
52         (WebCore::execToggleItalic):
53         (WebCore::enabled):
54         (WebCore::canPaste):
55         (WebCore::hasEditableSelection):
56         (WebCore::hasEditableRangeSelection):
57         (WebCore::hasRangeSelection):
58         (WebCore::hasRichlyEditableSelection):
59         (WebCore::CommandEntry::):
60         * editing/Editor.h:
61
62 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
63
64         Reviewed by Maciej, Geoff.
65
66         Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
67         the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.
68
69         * WebCore.exp:
70         * bridge/mac/WebCoreFrameBridge.h:
71         * bridge/mac/WebCoreFrameBridge.mm:
72         * editing/Editor.cpp:
73         (WebCore::execMoveBackward):
74         (WebCore::execMoveBackwardAndModifySelection):
75         (WebCore::execMoveDown):
76         (WebCore::execMoveDownAndModifySelection):
77         (WebCore::execMoveForward):
78         (WebCore::execMoveForwardAndModifySelection):
79         (WebCore::execMoveLeft):
80         (WebCore::execMoveLeftAndModifySelection):
81         (WebCore::execMoveRight):
82         (WebCore::execMoveRightAndModifySelection):
83         (WebCore::execMoveToBeginningOfDocument):
84         (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
85         (WebCore::execMoveToBeginningOfSentence):
86         (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
87         (WebCore::execMoveToBeginningOfLine):
88         (WebCore::execMoveToBeginningOfLineAndModifySelection):
89         (WebCore::execMoveToBeginningOfParagraph):
90         (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
91         (WebCore::execMoveToEndOfDocument):
92         (WebCore::execMoveToEndOfDocumentAndModifySelection):
93         (WebCore::execMoveToEndOfSentence):
94         (WebCore::execMoveToEndOfSentenceAndModifySelection):
95         (WebCore::execMoveToEndOfLine):
96         (WebCore::execMoveToEndOfLineAndModifySelection):
97         (WebCore::execMoveToEndOfParagraph):
98         (WebCore::execMoveToEndOfParagraphAndModifySelection):
99         (WebCore::execMoveParagraphBackwardAndModifySelection):
100         (WebCore::execMoveParagraphForwardAndModifySelection):
101         (WebCore::execMoveUp):
102         (WebCore::execMoveUpAndModifySelection):
103         (WebCore::execMoveWordBackward):
104         (WebCore::execMoveWordBackwardAndModifySelection):
105         (WebCore::execMoveWordForward):
106         (WebCore::execMoveWordForwardAndModifySelection):
107         (WebCore::execMoveWordLeft):
108         (WebCore::execMoveWordLeftAndModifySelection):
109         (WebCore::execMoveWordRight):
110         (WebCore::execMoveWordRightAndModifySelection):
111         (WebCore::enabledAnySelection):
112         (WebCore::createCommandMap):
113         (WebCore::CommandEntry::):
114         (WebCore::Editor::execCommand):
115         * editing/Editor.h:
116
117 2006-11-10  Brady Eidson  <beidson@apple.com>
118
119         Reviewed by Darin
120
121         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
122
123         * WebCore.exp:
124         * WebCore.xcodeproj/project.pbxproj:
125         * bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
126         * bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
127         * loader/FrameLoaderClient.h:
128         * loader/icon/IconDatabase.cpp:
129         (WebCore::IconDatabase::sharedIconDatabase):
130         (WebCore::IconDatabase::~IconDatabase):
131         * loader/icon/IconDatabase.h:
132         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
133         (WebCore::IconDatabase::enabled):
134         * loader/icon/IconLoader.cpp:
135         (WebCore::IconLoader::finishLoading):
136         * loader/mac/FrameLoaderMac.mm:
137
138 2006-11-10  Zack Rusin  <zack@kde.org>
139
140         Reviewed and landed by Anders.
141
142         Adjust platform Qt/KDE code to the recent loader
143         changes. 
144
145         * CMakeLists.txt:
146         * loader/DocumentLoader.h:
147         * loader/FrameLoader.cpp:
148         (WebCore::FrameLoader::createEmptyDocument):
149         * loader/FrameLoader.h:
150         * loader/FrameLoaderClient.h:
151         * loader/qt/DocumentLoaderQt.cpp: Added.
152         (WebCore::canonicalizedTitle):
153         (WebCore::DocumentLoader::DocumentLoader):
154         (WebCore::DocumentLoader::frameLoader):
155         (WebCore::DocumentLoader::~DocumentLoader):
156         (WebCore::DocumentLoader::URL):
157         (WebCore::DocumentLoader::unreachableURL):
158         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
159         (WebCore::DocumentLoader::isStopping):
160         (WebCore::DocumentLoader::clearErrors):
161         (WebCore::DocumentLoader::stopLoading):
162         (WebCore::DocumentLoader::setupForReplace):
163         (WebCore::DocumentLoader::commitIfReady):
164         (WebCore::DocumentLoader::finishedLoading):
165         (WebCore::DocumentLoader::setCommitted):
166         (WebCore::DocumentLoader::isCommitted):
167         (WebCore::DocumentLoader::setLoading):
168         (WebCore::DocumentLoader::isLoading):
169         (WebCore::DocumentLoader::doesProgressiveLoad):
170         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
171         (WebCore::DocumentLoader::updateLoading):
172         (WebCore::DocumentLoader::setFrame):
173         (WebCore::DocumentLoader::attachToFrame):
174         (WebCore::DocumentLoader::detachFromFrame):
175         (WebCore::DocumentLoader::prepareForLoadStart):
176         (WebCore::DocumentLoader::loadingStartedTime):
177         (WebCore::DocumentLoader::setIsClientRedirect):
178         (WebCore::DocumentLoader::isClientRedirect):
179         (WebCore::DocumentLoader::setPrimaryLoadComplete):
180         (WebCore::DocumentLoader::isLoadingInAPISense):
181         (WebCore::DocumentLoader::stopRecordingResponses):
182         (WebCore::DocumentLoader::title):
183         (WebCore::DocumentLoader::triggeringAction):
184         (WebCore::DocumentLoader::setTriggeringAction):
185         (WebCore::DocumentLoader::setOverrideEncoding):
186         (WebCore::DocumentLoader::overrideEncoding):
187         (WebCore::DocumentLoader::setTitle):
188         (WebCore::DocumentLoader::URLForHistory):
189         * loader/qt/FrameLoaderClientQt.cpp: Added.
190         (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
191         (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt):
192         (WebCore::FrameLoaderClientQt::detachFrameLoader):
193         (WebCore::FrameLoaderClientQt::hasWebView):
194         (WebCore::FrameLoaderClientQt::hasFrameView):
195         (WebCore::FrameLoaderClientQt::hasBackForwardList):
196         (WebCore::FrameLoaderClientQt::resetBackForwardList):
197         (WebCore::FrameLoaderClientQt::provisionalItemIsTarget):
198         (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache):
199         (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache):
200         (WebCore::FrameLoaderClientQt::privateBrowsingEnabled):
201         (WebCore::FrameLoaderClientQt::makeDocumentView):
202         (WebCore::FrameLoaderClientQt::makeRepresentation):
203         (WebCore::FrameLoaderClientQt::forceLayout):
204         (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML):
205         (WebCore::FrameLoaderClientQt::updateHistoryForCommit):
206         (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation):
207         (WebCore::FrameLoaderClientQt::updateHistoryForReload):
208         (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad):
209         (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad):
210         (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect):
211         (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
212         (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset):
213         (WebCore::FrameLoaderClientQt::resetAfterLoadError):
214         (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError):
215         (WebCore::FrameLoaderClientQt::willCloseDocument):
216         (WebCore::FrameLoaderClientQt::detachedFromParent1):
217         (WebCore::FrameLoaderClientQt::detachedFromParent2):
218         (WebCore::FrameLoaderClientQt::detachedFromParent3):
219         (WebCore::FrameLoaderClientQt::detachedFromParent4):
220         (WebCore::FrameLoaderClientQt::loadedFromPageCache):
221         (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
222         (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad):
223         (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect):
224         (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
225         (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
226         (WebCore::FrameLoaderClientQt::dispatchWillClose):
227         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
228         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
229         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
230         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
231         (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
232         (WebCore::FrameLoaderClientQt::dispatchShow):
233         (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
234         (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
235         (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource):
236         (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache):
237         (WebCore::FrameLoaderClientQt::isLoadingFromPageCache):
238         (WebCore::FrameLoaderClientQt::revertToProvisionalState):
239         (WebCore::FrameLoaderClientQt::clearUnarchivingState):
240         (WebCore::FrameLoaderClientQt::progressStarted):
241         (WebCore::FrameLoaderClientQt::progressCompleted):
242         (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
243         (WebCore::FrameLoaderClientQt::willChangeTitle):
244         (WebCore::FrameLoaderClientQt::didChangeTitle):
245         (WebCore::FrameLoaderClientQt::finishedLoading):
246         (WebCore::FrameLoaderClientQt::finalSetupForReplace):
247         (WebCore::FrameLoaderClientQt::setDefersLoading):
248         (WebCore::FrameLoaderClientQt::isArchiveLoadPending):
249         (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad):
250         (WebCore::FrameLoaderClientQt::clearArchivedResources):
251         (WebCore::FrameLoaderClientQt::canShowMIMEType):
252         (WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
253         (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
254         (WebCore::FrameLoaderClientQt::frameLoadCompleted):
255         (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState):
256         (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
257         (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent):
258         (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll):
259         (WebCore::FrameLoaderClientQt::didFinishLoad):
260         (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
261         (WebCore::FrameLoaderClientQt::setTitle):
262         (WebCore::FrameLoaderClientQt::userAgent):
263         * loader/qt/FrameLoaderClientQt.h: Added.
264         * loader/qt/FrameLoaderQt.cpp:
265         (WebCore::FrameLoader::submitForm):
266         (WebCore::FrameLoader::overrideMediaType):
267         (WebCore::FrameLoader::getHistoryLength):
268         (WebCore::FrameLoader::referrer):
269         (WebCore::FrameLoader::detachFromParent):
270         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
271         (WebCore::FrameLoader::goBackOrForward):
272         (WebCore::FrameLoader::historyURL):
273         (WebCore::FrameLoader::didFirstLayout):
274         (WebCore::FrameLoader::canGoBackOrForward):
275         (WebCore::FrameLoader::partClearedInBegin):
276         (WebCore::FrameLoader::saveDocumentState):
277         (WebCore::FrameLoader::restoreDocumentState):
278         (WebCore::FrameLoader::didChangeTitle):
279         (WebCore::FrameLoader::redirectDataToPlugin):
280         (WebCore::PolicyCheck::PolicyCheck):
281         (WebCore::PolicyCheck::clear):
282         (WebCore::PolicyCheck::set):
283         (WebCore::PolicyCheck::call):
284         (WebCore::PolicyCheck::clearRequest):
285         * loader/qt/NavigationActionQt.cpp: Added.
286         (WebCore::navigationType):
287         (WebCore::NavigationAction::NavigationAction):
288         * loader/qt/ResourceLoaderQt.cpp: Added.
289         (WebCore::ResourceLoader::ResourceLoader):
290         (WebCore::ResourceLoader::~ResourceLoader):
291         (WebCore::ResourceLoader::setDefersLoading):
292         (WebCore::ResourceLoader::cancel):
293         (WebCore::ResourceLoader::loadsBlocked):
294         * platform/MimeTypeRegistry.cpp:
295         (WebCore::initialiseSupportedImageMIMETypes):
296         * platform/network/qt/ResourceHandleManager.cpp:
297         (WebCore::ResourceHandleManager::slotResult):
298         (WebCore::ResourceHandleManager::cancel):
299         * platform/qt/ChromeClientQt.cpp: Added.
300         (WebCore::rootWindowForFrame):
301         (WebCore::ChromeClientQt::ChromeClientQt):
302         (WebCore::ChromeClientQt::~ChromeClientQt):
303         (WebCore::ChromeClientQt::setWindowRect):
304         (WebCore::ChromeClientQt::windowRect):
305         (WebCore::ChromeClientQt::pageRect):
306         (WebCore::ChromeClientQt::scaleFactor):
307         (WebCore::ChromeClientQt::focus):
308         (WebCore::ChromeClientQt::unfocus):
309         (WebCore::ChromeClientQt::createWindow):
310         (WebCore::ChromeClientQt::createModalDialog):
311         (WebCore::ChromeClientQt::show):
312         (WebCore::ChromeClientQt::canRunModal):
313         (WebCore::ChromeClientQt::runModal):
314         (WebCore::ChromeClientQt::setToolbarsVisible):
315         (WebCore::ChromeClientQt::toolbarsVisible):
316         (WebCore::ChromeClientQt::setStatusbarVisible):
317         (WebCore::ChromeClientQt::statusbarVisible):
318         (WebCore::ChromeClientQt::setScrollbarsVisible):
319         (WebCore::ChromeClientQt::scrollbarsVisible):
320         (WebCore::ChromeClientQt::setMenubarVisible):
321         (WebCore::ChromeClientQt::menubarVisible):
322         (WebCore::ChromeClientQt::setResizable):
323         * platform/qt/ChromeClientQt.h: Added.
324         * platform/qt/EditorClientQt.cpp:
325         (WebCore::EditorClientQt::shouldBeginEditing):
326         (WebCore::EditorClientQt::shouldEndEditing):
327         (WebCore::EditorClientQt::shouldApplyStyle):
328         (WebCore::EditorClientQt::didBeginEditing):
329         (WebCore::EditorClientQt::respondToChangedContents):
330         (WebCore::EditorClientQt::didEndEditing):
331         * platform/qt/EditorClientQt.h:
332         * platform/qt/FrameQt.cpp:
333         (WebCore::FrameQt::FrameQt):
334         (WebCore::FrameQt::~FrameQt):
335         (WebCore::FrameQt::keyEvent):
336         * platform/qt/FrameQt.h:
337         * platform/qt/FrameQtClient.cpp:
338         (WebCore::FrameQtClientDefault::openURL):
339         (WebCore::FrameQtClientDefault::didReceiveData):
340         (WebCore::FrameQtClientDefault::receivedAllData):
341         * platform/qt/ImageQt.cpp:
342         * platform/qt/MimeTypeRegistryQt.cpp: Added.
343         (WebCore::getMIMETypeForUTI):
344         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
345         * platform/qt/PageQt.cpp:
346         * platform/qt/PlatformKeyboardEventQt.cpp:
347         (WebCore::keyIdentifierForQtKeyCode):
348         * platform/qt/ScreenQt.cpp:
349         * platform/qt/TemporaryLinkStubs.cpp:
350         (WebCore::TextField::TextField):
351         (WebCore::screenDepth):
352         (WebCore::screenDepthPerComponent):
353         (WebCore::screenIsMonochrome):
354         (WebCore::screenRect):
355         (WebCore::screenAvailableRect):
356
357 2006-11-10  Brady Eidson <beidson@apple.com>
358
359         Reviewed by Mitz
360
361         http://bugs.webkit.org/show_bug.cgi?id=11554
362         Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
363         in case the icon load fails after some data has been received. 
364
365         * loader/icon/IconLoader.cpp:
366         (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB
367         on error.  Also, as a loader re-factoring sanity check, added an assertion
368         (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon 
369         is already committed to the DB.  Skip doing that step twice.
370
371 2006-11-09  Oliver Hunt  <oliver@apple.com>
372
373         Reviewed by Brady.
374
375         Pulled MIME type handling out of WebFrameBridge and added
376         a general C++ class to store/query MIME info
377         Added an Obj-C bridge to provide WebKit with access to the
378         MimeTypeRegistry for non-Obj-C++ classes.
379         
380         * WebCore.exp:
381         * WebCore.xcodeproj/project.pbxproj:
382         * bridge/mac/WebCoreFrameBridge.h:
383         * bridge/mac/WebCoreFrameBridge.mm:
384         * bridge/mac/WebMimeTypeRegistryBridge.h: Added.
385         * bridge/mac/WebMimeTypeRegistryBridge.mm: Added.
386         (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]):
387         (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]):
388         (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]):
389         (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]):
390         (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
391         * platform/Image.cpp:
392         (WebCore::Image::supportsType):
393         * platform/Image.h:
394         * platform/MimeTypeRegistry.cpp: Added.
395         (WebCore::initialiseSupportedImageMIMETypes):
396         (WebCore::initialiseSupportedNonImageMimeTypes):
397         (WebCore::initialiseMimeTypeRegistry):
398         (WebCore::MimeTypeRegistry::isSupportedImageMIMEType):
399         (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType):
400         (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType):
401         (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes):
402         (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes):
403         (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
404         * platform/MimeTypeRegistry.h: Added.
405         * platform/mac/ImageMac.mm:
406         * platform/mac/MimeTypeRegistryMac.mm: Added.
407         (WebCore::getMIMETypeForUTI):
408         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
409
410 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
411
412         Reviewed by Oliver.
413
414         - rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search
415         for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size
416         for you and use vsnprintf.
417
418         * bindings/js/kjs_window.cpp:
419         (KJS::Window::isSafeScript):
420         * css/cssparser.cpp:
421         (WebCore::CSSParser::parseColorFromValue):
422         * dom/StyledElement.cpp:
423         (WebCore::StyledElement::addCSSColor):
424         * dom/XMLTokenizer.cpp:
425         (WebCore::XMLTokenizer::handleError):
426         * ksvg2/css/SVGCSSParser.cpp:
427         (WebCore::CSSParser::parseSVGPaint):
428         (WebCore::CSSParser::parseSVGColor):
429         * ksvg2/svg/SVGPathSegArc.h:
430         (WebCore::SVGPathSegArcAbs::toString):
431         (WebCore::SVGPathSegArcRel::toString):
432         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
433         (WebCore::SVGPathSegCurvetoCubicAbs::toString):
434         (WebCore::SVGPathSegCurvetoCubicRel::toString):
435         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
436         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
437         (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
438         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
439         (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
440         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
441         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
442         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
443         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
444         * ksvg2/svg/SVGPathSegLineto.h:
445         (WebCore::SVGPathSegLinetoAbs::toString):
446         (WebCore::SVGPathSegLinetoRel::toString):
447         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
448         (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
449         (WebCore::SVGPathSegLinetoHorizontalRel::toString):
450         * ksvg2/svg/SVGPathSegLinetoVertical.h:
451         (WebCore::SVGPathSegLinetoVerticalAbs::toString):
452         (WebCore::SVGPathSegLinetoVerticalRel::toString):
453         * ksvg2/svg/SVGPathSegMoveto.h:
454         (WebCore::SVGPathSegMovetoAbs::toString):
455         (WebCore::SVGPathSegMovetoRel::toString):
456         * ksvg2/svg/SVGPolyElement.cpp:
457         (WebCore::SVGPolyElement::notifyAttributeChange):
458         * ksvg2/svg/SVGUseElement.cpp:
459         (WebCore::SVGUseElement::closeRenderer):
460         * loader/icon/IconDatabase.cpp:
461         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
462         * loader/icon/SQLDatabase.cpp:
463         (WebCore::SQLDatabase::setSynchronous):
464         * platform/Color.cpp:
465         (WebCore::Color::name):
466         * platform/DeprecatedString.cpp:
467         (WebCore::DeprecatedString::setNum):
468         (WebCore::DeprecatedString::format):
469         * platform/DeprecatedString.h:
470         * platform/PlatformString.h:
471         * platform/String.cpp:
472         (WebCore::String::format):
473         (WebCore::String::number):
474         * platform/mac/KeyEventMac.mm:
475         (WebCore::keyIdentifierForKeyEvent):
476         * platform/win/KeyEventWin.cpp:
477         (WebCore::keyIdentifierForWindowsKeyCode):
478         * rendering/RenderListMarker.cpp:
479         (WebCore::RenderListMarker::calcMinMaxWidth):
480
481 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
482
483         Reviewed by Anders.
484
485         - fixed "Regression: Can't log into gmail.com"
486         - fixed "iBench doesn't report results - tests run but no number is recorded"
487         
488         * platform/network/cf/FormDataStreamCFNet.cpp:
489         (WebCore::setHTTPBody): Removed extra ! character.
490
491 2006-11-09  Beth Dakin  <bdakin@apple.com>
492
493         Reviewed by Hyatt.
494
495         Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in 
496         WebCore::RenderBlock::skipWhitespace
497
498         Note that this will still crash on Debug builds because it will hit 
499         an assertion failure in editing. (One of the reasons there is no 
500         layout test along with this fix.) There is definitely some editing 
501         wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
502         id=10144 for updates on the assertion failure bug.
503
504         * rendering/RootInlineBox.cpp:
505         (WebCore::RootInlineBox::childRemoved): It is possible for a 
506         prevRootBox and its prevRootBox to share a lineBreakObj. So instead 
507         of just clearing the lineBreakObj of the prevRootBox, cycle through 
508         all prevRootBoxs with the same lineBreakObj. 
509
510 2006-11-09  Adam Roben  <aroben@apple.com>
511
512         Reviewed by Geoff.
513
514         Fix the change in behavior I caused in r17680 with my build fix.
515
516         * rendering/RenderObject.cpp:
517         (WebCore::RenderObject::maxTopMargin):
518         (WebCore::RenderObject::maxBottomMargin):
519
520 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
521
522         Reviewed by Adam, Oliver.
523
524         Move more functions to Editor.
525
526         * bridge/EditorClient.h:
527         * bridge/mac/FrameMac.h:
528         * bridge/mac/FrameMac.mm:
529         * bridge/mac/WebCoreFrameBridge.h:
530         * editing/EditCommand.cpp:
531         (WebCore::EditCommand::apply):
532         (WebCore::EditCommand::unapply):
533         (WebCore::EditCommand::reapply):
534         * editing/Editor.cpp:
535         (WebCore::Editor::respondToChangedContents):
536         (WebCore::dispatchEditableContentChangedEvents):
537         (WebCore::Editor::appliedEditing):
538         (WebCore::Editor::unappliedEditing):
539         (WebCore::Editor::reappliedEditing):
540         * editing/Editor.h:
541         * editing/TypingCommand.cpp:
542         (WebCore::TypingCommand::typingAddedToOpenCommand):
543         * page/Frame.cpp:
544         * page/Frame.h:
545
546 2006-11-09  Darin Adler  <darin@apple.com>
547
548         * rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
549
550 2006-11-09  Alice Liu  <alice.liu@apple.com>
551
552         Reviewed by Beth Dakin.
553
554         Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
555         All existing layout tests pass
556
557         * html/HTMLTableElement.cpp:
558         (WebCore::HTMLTableElement::deleteRow):
559         check lastSection before deleting row
560
561 2006-11-09  Darin Adler  <darin@apple.com>
562
563         - improved version of last night's build fix (should not do using namespace in a header)
564
565         * rendering/RenderObject.h:
566         * rendering/RenderObject.cpp:
567         (WebCore::RenderObject::maxTopMargin):
568         (WebCore::RenderObject::maxBottomMargin):
569
570 2006-11-08  Maciej Stachowiak  <mjs@apple.com>
571
572         Reviewed by Geoff.
573         
574         - added ResourceError class and didFailWithError client method
575
576         * WebCore.xcodeproj/project.pbxproj:
577         * loader/icon/IconLoader.cpp:
578         (WebCore::IconLoader::didFailWithError):
579         (WebCore::IconLoader::didFinishLoading):
580         * loader/icon/IconLoader.h:
581         * loader/loader.cpp:
582         (WebCore::Loader::receivedAllData):
583         (WebCore::Loader::didFailWithError):
584         * loader/loader.h:
585         * loader/mac/SubresourceLoaderMac.mm:
586         (WebCore::SubresourceLoader::didFail):
587         (WebCore::SubresourceLoader::didCancel):
588         * platform/cf/RetainPtr.h:
589         (WebCore::):
590         (WebCore::adoptCFReference):
591         (WebCore::RetainPtr::RetainPtr):
592         (WebCore::::adopt):
593         * platform/network/ResourceError.cpp: Added.
594         * platform/network/ResourceError.h: Added.
595         (WebCore::ResourceError::ResourceError):
596         (WebCore::ResourceError::domain):
597         (WebCore::ResourceError::errorCode):
598         (WebCore::ResourceError::failingURL):
599         (WebCore::ResourceError::localizedDescription):
600         (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
601         * platform/network/ResourceHandle.cpp:
602         * platform/network/ResourceHandle.h:
603         * platform/network/ResourceHandleClient.h:
604         (WebCore::ResourceHandleClient::didFailWithError):
605         * platform/network/cf/ResourceHandleCFNet.cpp:
606         (WebCore::didFail):
607         (WebCore::ResourceHandle::cancel):
608         * platform/network/mac/ResourceErrorMac.mm: Added.
609         (-[NSError WebCore]):
610         * platform/network/mac/ResourceHandleMac.mm:
611         (WebCore::ResourceHandle::reportError):
612         * xml/xmlhttprequest.cpp:
613         (WebCore::XMLHttpRequest::didFailWithError):
614         (WebCore::XMLHttpRequest::didFinishLoading):
615         * xml/xmlhttprequest.h:
616
617 2006-11-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
618
619         Reviewed by Maciej.
620
621         Linux\Gdk fixes.
622
623         * platform/gdk/ChromeClientGdk.h:
624         (WebCore::ChromeClientGdk::~ChromeClientGdk):
625         * platform/gdk/CursorGdk.cpp:
626         (WebCore::Cursor::Cursor):
627         (WebCore::moveCursor):
628         * platform/gdk/FrameGdk.cpp:
629         (WebCore::FrameGdk::FrameGdk):
630         (WebCore::FrameGdk::submitForm):
631         (WebCore::FrameGdk::urlSelected):
632         * platform/gdk/PageGdk.cpp:
633         * platform/gdk/ScreenClientGdk.h: Added.
634         (WebCore::ScreenClientGdk::~ScreenClientGdk):
635         * platform/gdk/ScreenGdk.cpp:
636         (WebCore::ScreenClientGdk::depth):
637         (WebCore::ScreenClientGdk::depthPerComponent):
638         (WebCore::ScreenClientGdk::isMonochrome):
639         (WebCore::ScreenClientGdk::rect):
640         (WebCore::ScreenClientGdk::usableRect):
641         * platform/gdk/TemporaryLinkStubs.cpp:
642         (FrameGdk::historyURL):
643         (ChromeClientGdk::windowRect):
644         (ChromeClientGdk::setWindowRect):
645         (ChromeClientGdk::pageRect):
646         (ChromeClientGdk::scaleFactor):
647         (ChromeClientGdk::focus):
648         (ChromeClientGdk::unfocus):
649         (ChromeClientGdk::createWindow):
650         (ChromeClientGdk::createModalDialog):
651         (ChromeClientGdk::show):
652         (ChromeClientGdk::canRunModal):
653         (ChromeClientGdk::runModal):
654         (ChromeClientGdk::setToolbarsVisible):
655         (ChromeClientGdk::toolbarsVisible):
656         (ChromeClientGdk::setStatusbarVisible):
657         (ChromeClientGdk::statusbarVisible):
658         (ChromeClientGdk::setScrollbarsVisible):
659         (ChromeClientGdk::scrollbarsVisible):
660         (ChromeClientGdk::setMenubarVisible):
661         (ChromeClientGdk::menubarVisible):
662         (ChromeClientGdk::setResizable):
663         * platform/network/ResourceHandleInternal.h:
664         (WebCore::ResourceHandleInternal::client):
665         * platform/network/gdk/ResourceHandleManager.cpp:
666         (WebCore::writeCallback):
667         (WebCore::ResourceHandleManager::downloadTimerCallback):
668         (WebCore::ResourceHandleManager::remove):
669
670 2006-11-08  Adam Roben  <aroben@apple.com>
671
672         Build fix.
673
674         * rendering/RenderObject.h:
675         (WebCore::RenderObject::maxTopMargin):
676         (WebCore::RenderObject::maxBottomMargin):
677
678 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
679
680         Reviewed by Anders Carlsson.
681
682         Made Screen a good platform citizen by removing its reference to Page. This
683         made a class unnecessary, so all screen fuctions are stand-alone now.
684
685         * bindings/js/kjs_window.cpp: Removed unnecessary subtractions
686         when computing the screen's available dimensions.
687
688 2006-11-08  Sam Weinig  <sam.weinig@gmail.com>
689
690         Reviewed by Mitz.
691
692         Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
693         Cleanup RenderObject
694
695         * rendering/RenderObject.cpp:
696         (WebCore::RenderObject::operator delete):
697         (WebCore::RenderObject::createObject):
698         (WebCore::RenderObjectCounter::~RenderObjectCounter):
699         (WebCore::RenderObject::RenderObject):
700         (WebCore::RenderObject::isDescendantOf):
701         (WebCore::RenderObject::isRoot):
702         (WebCore::RenderObject::addChild):
703         (WebCore::RenderObject::removeChildNode):
704         (WebCore::RenderObject::removeChild):
705         (WebCore::RenderObject::appendChildNode):
706         (WebCore::RenderObject::insertChildNode):
707         (WebCore::RenderObject::nextInPreOrder):
708         (WebCore::RenderObject::nextInPreOrderAfterChildren):
709         (WebCore::RenderObject::previousInPreOrder):
710         (WebCore::RenderObject::isEditable):
711         (WebCore::RenderObject::nextEditable):
712         (WebCore::RenderObject::previousEditable):
713         (WebCore::RenderObject::firstLeafChild):
714         (WebCore::RenderObject::lastLeafChild):
715         (WebCore::RenderObject::addLayers):
716         (WebCore::RenderObject::removeLayers):
717         (WebCore::RenderObject::moveLayers):
718         (WebCore::RenderObject::findNextLayer):
719         (WebCore::RenderObject::enclosingLayer):
720         (WebCore::RenderObject::updateFirstLetter):
721         (WebCore::RenderObject::offsetParent):
722         (WebCore::RenderObject::scroll):
723         (WebCore::RenderObject::hasStaticX):
724         (WebCore::RenderObject::setNeedsLayout):
725         (WebCore::RenderObject::setChildNeedsLayout):
726         (WebCore::RenderObject::markContainingBlocksForLayout):
727         (WebCore::RenderObject::containingBlock):
728         (WebCore::RenderObject::containingBlockWidth):
729         (WebCore::RenderObject::containingBlockHeight):
730         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
731         (WebCore::RenderObject::drawBorderArc):
732         (WebCore::RenderObject::drawBorder):
733         (WebCore::RenderObject::paintBorderImage):
734         (WebCore::RenderObject::paintBorder):
735         (WebCore::RenderObject::absoluteRects):
736         (WebCore::RenderObject::addPDFURLRect):
737         (WebCore::RenderObject::addFocusRingRects):
738         (WebCore::RenderObject::paintOutline):
739         (WebCore::RenderObject::repaint):
740         (WebCore::RenderObject::repaintRectangle):
741         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
742         (WebCore::RenderObject::repaintObjectsBeforeLayout):
743         (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
744         (WebCore::RenderObject::information):
745         (WebCore::RenderObject::dump):
746         (WebCore::selectStartNode):
747         (WebCore::RenderObject::shouldSelect):
748         (WebCore::RenderObject::draggableNode):
749         (WebCore::RenderObject::createAnonymousBlock):
750         (WebCore::RenderObject::handleDynamicFloatPositionChange):
751         (WebCore::RenderObject::setStyle):
752         (WebCore::RenderObject::setStyleInternal):
753         (WebCore::RenderObject::updateBackgroundImages):
754         (WebCore::RenderObject::absolutePosition):
755         (WebCore::RenderObject::caretRect):
756         (WebCore::RenderObject::paddingTop):
757         (WebCore::RenderObject::paddingBottom):
758         (WebCore::RenderObject::paddingLeft):
759         (WebCore::RenderObject::paddingRight):
760         (WebCore::RenderObject::tabWidth):
761         (WebCore::RenderObject::container):
762         (WebCore::RenderObject::removeFromObjectLists):
763         (WebCore::RenderObject::destroy):
764         (WebCore::RenderObject::arenaDelete):
765         (WebCore::RenderObject::hitTest):
766         (WebCore::RenderObject::setInnerNode):
767         (WebCore::RenderObject::nodeAtPoint):
768         (WebCore::RenderObject::verticalPositionHint):
769         (WebCore::RenderObject::getVerticalPosition):
770         (WebCore::RenderObject::lineHeight):
771         (WebCore::RenderObject::invalidateVerticalPositions):
772         (WebCore::RenderObject::recalcMinMaxWidths):
773         (WebCore::RenderObject::scheduleRelayout):
774         (WebCore::RenderObject::setInlineBoxWrapper):
775         (WebCore::RenderObject::firstLineStyle):
776         (WebCore::RenderObject::getPseudoStyle):
777         (WebCore::RenderObject::getTextDecorationColors):
778         (WebCore::RenderObject::addDashboardRegions):
779         (WebCore::RenderObject::collectDashboardRegions):
780         (WebCore::RenderObject::avoidsFloats):
781         (WebCore::RenderObject::findCounter):
782         (WebCore::RenderObject::backslashAsCurrencySymbol):
783         (WebCore::RenderObject::imageChanged):
784         (WebCore::RenderObject::previousOffset):
785         (WebCore::RenderObject::nextOffset):
786         (WebCore::RenderObject::inlineBox):
787         * rendering/RenderObject.h:
788         (WebCore::):
789         (WebCore::RenderObject::renderName):
790         (WebCore::RenderObject::parent):
791         (WebCore::RenderObject::previousSibling):
792         (WebCore::RenderObject::nextSibling):
793         (WebCore::RenderObject::firstChild):
794         (WebCore::RenderObject::lastChild):
795         (WebCore::RenderObject::getOverflowClipRect):
796         (WebCore::RenderObject::getClipRect):
797         (WebCore::RenderObject::getBaselineOfFirstLineBox):
798         (WebCore::RenderObject::setEdited):
799         (WebCore::RenderObject::setStaticX):
800         (WebCore::RenderObject::setStaticY):
801         (WebCore::RenderObject::setPreviousSibling):
802         (WebCore::RenderObject::setNextSibling):
803         (WebCore::RenderObject::setParent):
804         (WebCore::RenderObject::isInlineBlockOrInlineTable):
805         (WebCore::RenderObject::isRenderView):
806         (WebCore::RenderObject::childrenInline):
807         (WebCore::RenderObject::setChildrenInline):
808         (WebCore::RenderObject::isAnonymousBlock):
809         (WebCore::RenderObject::isDragging):
810         (WebCore::RenderObject::needsLayout):
811         (WebCore::RenderObject::setMinMaxKnown):
812         (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
813         (WebCore::RenderObject::setPositioned):
814         (WebCore::RenderObject::setRelPositioned):
815         (WebCore::RenderObject::setFloating):
816         (WebCore::RenderObject::setInline):
817         (WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
818         (WebCore::RenderObject::setReplaced):
819         (WebCore::RenderObject::PaintInfo::PaintInfo):
820         (WebCore::RenderObject::paintBackgroundExtended):
821         (WebCore::RenderObject::calcWidth):
822         (WebCore::RenderObject::updateFromElement):
823         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
824         (WebCore::RenderObject::setOverrideSize):
825         (WebCore::RenderObject::setPos):
826         (WebCore::RenderObject::setWidth):
827         (WebCore::RenderObject::setHeight):
828         (WebCore::RenderObject::absolutePositionForContent):
829         (WebCore::RenderObject::overflowHeight):
830         (WebCore::RenderObject::overflowWidth):
831         (WebCore::RenderObject::setOverflowHeight):
832         (WebCore::RenderObject::setOverflowWidth):
833         (WebCore::RenderObject::overflowLeft):
834         (WebCore::RenderObject::overflowTop):
835         (WebCore::RenderObject::overflowRect):
836         (WebCore::RenderObject::stopAutoscroll):
837         (WebCore::RenderObject::collapsedMarginTop):
838         (WebCore::RenderObject::collapsedMarginBottom):
839         (WebCore::RenderObject::maxTopMargin):
840         (WebCore::RenderObject::maxBottomMargin):
841         (WebCore::RenderObject::):
842         (WebCore::RenderObject::setTable):
843         (WebCore::RenderObject::isFloatingOrPositioned):
844         (WebCore::RenderObject::containsFloat):
845         (WebCore::RenderObject::setSelectionState):
846         (WebCore::RenderObject::SelectionInfo::SelectionInfo):
847         (WebCore::RenderObject::lowestPosition):
848         (WebCore::RenderObject::rightmostPosition):
849         (WebCore::RenderObject::leftmostPosition):
850         (WebCore::RenderObject::calcVerticalMargins):
851         (WebCore::RenderObject::font):
852
853 2006-11-08  Darin Adler  <darin@apple.com>
854
855         Reviewed by Anders.
856
857         - added event parameters to focus-related functions so we can
858           implement the "option-tab to all links" behavior without relying
859           on a global "current event" -- also makes it work with DOM events
860
861         * page/Frame.h: Removed unneeded includes. Moved some functions
862         that were misplaced into the appropriate sections.
863         * page/Frame.cpp:
864         (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
865         PlatformKeyboardEvent to the DOM keyboard event class.
866         (WebCore::Frame::tabsToLinks): Added event parameter.
867         (WebCore::Frame::tabsToAllControls): Ditto.
868         (WebCore::scanForForm): Fixed code that incorrectly assumes
869         that an iframe is an HTMLFrameElement (no longer true since Geoff
870         changed the class hierarchy a bit).
871         (WebCore::Frame::hitTestResultAtPoint): Ditto.
872
873         * bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
874         that were misplaced into the appropriate sections.
875         * bridge/mac/FrameMac.mm:
876         (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
877         a PlatformKeyboardEvent.
878         (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
879         and pass event into next/previousFocusNode.
880         (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
881         the AppKit current event, if it's a keyboard event. Really just a hack that's
882         needed to preserve some code we can remove once we deal with the last NSView-
883         based form control.
884         (WebCore::isKeyboardOptionTab): Added.
885         (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
886         option (alt) key is down.
887         (WebCore::FrameMac::tabsToAllControls): Ditto.
888         (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
889         call resetMultipleFormSubmissionProtection() explicitly instead.
890         (WebCore::FrameMac::mouseDown): Ditto.
891
892         * bridge/mac/WebCoreAXObject.mm:
893         (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
894         assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
895         changed the class hierarchy a bit).
896         (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
897         prepareForUserAction() to call resetMultipleFormSubmissionProtection()
898         explicitly instead.
899
900         * page/FrameView.h:
901         * page/FrameView.cpp:
902         (WebCore::FrameView::advanceFocus): Changed function to take an
903         event parameter, and decide the direction based on the shift key
904         modifier instead of a passed-in boolean.
905
906         * dom/Document.h:
907         * dom/Document.cpp:
908         (WebCore::Document::nextFocusNode): Added event parameter.
909         (WebCore::Document::previousFocusNode): Ditto.
910         * dom/Node.h:
911         * dom/Node.cpp:
912         (WebCore::Node::isKeyboardFocusable): Ditto.
913         * html/HTMLAnchorElement.h:
914         * html/HTMLAnchorElement.cpp:
915         (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
916         * html/HTMLGenericFormElement.h:
917         * html/HTMLGenericFormElement.cpp:
918         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
919         * html/HTMLInputElement.h:
920         * html/HTMLInputElement.cpp:
921         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
922         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
923         * html/HTMLSelectElement.h:
924         * html/HTMLSelectElement.cpp:
925         (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
926         * html/HTMLTextAreaElement.h:
927         * html/HTMLTextAreaElement.cpp:
928         (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
929
930         * dom/EventTargetNode.cpp:
931         (WebCore::EventTargetNode::defaultEventHandler): Pass event to the
932         advanceFocus function.
933
934         * platform/TextField.h:
935         * platform/mac/TextFieldMac.mm: Removed the non-search field code.
936
937         * platform/mac/WebCoreTextField.h:
938         * platform/mac/WebCoreTextField.mm: Removed the non-search field code.
939         (-[WebCoreTextFieldController controlTextDidChange:]): Removed the
940         call to FrameMac::handleKeyboardOptionTabInView, which is no longer
941         needed since the default handler in HTMLInputElement takes care of
942         option-tab.
943
944         * platform/mac/SliderMac.mm:
945         (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
946         and pass event into tabsToAllControls.
947         (Slider::focusPolicy): Ditto.
948
949         * rendering/RenderLineEdit.cpp:
950         (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
951         (WebCore::RenderLineEdit::updateFromElement): Ditto.
952
953 2006-11-08  Brady Eidson  <beidson@apple.com>
954
955         Reviewed by Dave Harrison, Oliver, and Darin 
956         (oh my!  where was superkevin on this one?)
957
958         <rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
959
960         More "free nil checking" we lost in the transition from ObjC to C++
961
962         * loader/mac/FrameLoaderMac.mm:
963         (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
964         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
965
966 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
967
968         Reviewed by Adam.
969
970         Move more code into editor.
971         
972         * WebCore.exp:
973         * bridge/EditorClient.h:
974         * bridge/mac/FrameMac.h:
975         * bridge/mac/FrameMac.mm:
976         * bridge/mac/WebCoreFrameBridge.h:
977         * dom/Document.cpp:
978         (WebCore::Document::relinquishesEditingFocus):
979         (WebCore::Document::acceptsEditingFocus):
980         (WebCore::Document::didBeginEditing):
981         (WebCore::Document::didEndEditing):
982         * editing/Editor.cpp:
983         (WebCore::Editor::indent):
984         (WebCore::Editor::outdent):
985         * editing/Editor.h:
986         * page/Frame.cpp:
987         * page/Frame.h:
988
989 2006-11-08  Beth Dakin  <bdakin@apple.com>
990
991         Reviewed by Adam.
992
993         Add ability to HitTestResult to ask if the inner non-shared node is 
994         content editable.
995
996         * WebCore.exp: Export HitTestResult::isContentEditable()
997         * rendering/HitTestResult.cpp:
998         (WebCore::HitTestResult::isContentEditable):
999         * rendering/HitTestResult.h:
1000
1001 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1002
1003         Build fix.
1004         
1005         * WebCore.xcodeproj/project.pbxproj:
1006         Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
1007
1008 2006-11-08  Timothy Hatcher  <timothy@apple.com>
1009
1010         Reviewed by Darin.
1011
1012         <rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
1013         <rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
1014
1015         Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
1016
1017         * bindings/objc/DOM.mm:
1018         (WebCore::kit):
1019         (-[DOMNode lineBoxRects]):
1020         (-[DOMRange boundingBox]):
1021         (-[DOMRange lineBoxRects]):
1022         * bindings/objc/DOMPrivate.h:
1023         * dom/Range.cpp:
1024         (WebCore::Range::boundingBox):
1025         (WebCore::Range::addLineBoxRects):
1026         * dom/Range.h:
1027         * rendering/RenderContainer.cpp:
1028         (WebCore::RenderContainer::addLineBoxRects):
1029         * rendering/RenderContainer.h:
1030         * rendering/RenderObject.cpp:
1031         (WebCore::RenderObject::addLineBoxRects):
1032         * rendering/RenderObject.h:
1033         * rendering/RenderText.cpp:
1034         (WebCore::RenderText::addLineBoxRects):
1035         * rendering/RenderText.h:
1036
1037 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1038
1039         Reviewed by Oliver.
1040         
1041         Move methods from the bridge and frame into editor.
1042         
1043         * WebCore.exp:
1044         * bridge/EditorClient.h:
1045         * bridge/mac/WebCoreFrameBridge.h:
1046         * bridge/mac/WebCoreFrameBridge.mm:
1047         * editing/Editor.cpp:
1048         (WebCore::Editor::removeFormattingAndStyle):
1049         (WebCore::Editor::applyStyle):
1050         (WebCore::Editor::applyParagraphStyle):
1051         (WebCore::Editor::applyStyleToSelection):
1052         (WebCore::Editor::applyParagraphStyleToSelection):
1053         (WebCore::Editor::toggleBold):
1054         (WebCore::Editor::toggleItalic):
1055         (WebCore::Editor::selectionStartHasStyle):
1056         * editing/Editor.h:
1057         * editing/JSEditor.cpp:
1058         * page/Frame.cpp:
1059         * page/Frame.h:
1060
1061 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1062
1063         Reviewed by Beth.
1064         
1065         Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
1066         be able to dispatch user events even when off-screen, so we have to support
1067         off-screen windows when handling mouse events.
1068
1069         * platform/Screen.h:
1070         * platform/mac/PlatformMouseEventMac.mm:
1071         (WebCore::globalPoint): Grab the best screen instead of the screen you're
1072         on, since you might be off-screen.
1073         * platform/mac/ScreenMac.mm:
1074         (WebCore::screenForWindow):
1075
1076 2006-11-08  Darin Adler  <darin@apple.com>
1077
1078         - fix bug caused by last-minute change to my check-in last night
1079           that is causing layout tests to hang
1080
1081         * dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
1082         * loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn
1083         a null string into an empty string before calling completeURL.
1084
1085 2006-11-08  Brady Eidson <beidson@apple.com>
1086
1087         Reviewed by Maciej
1088
1089         If the request has already been aborted, bail out of didFinishLoading()
1090         immediately.  This prevents state change notifications that aren't
1091         needed.
1092
1093         * xml/xmlhttprequest.cpp:
1094         (WebCore::XMLHttpRequest::didFinishLoading):
1095
1096 2006-11-08  Darin Adler  <darin@apple.com>
1097
1098         - another attempt to fix Qt build
1099
1100         * loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
1101
1102 2006-11-08  Darin Adler  <darin@apple.com>
1103
1104         Reviewed by Geoff.
1105
1106         - stray bits of my FrameLoader patch that I left out by accident
1107
1108         * loader/FrameLoader.cpp:
1109         (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer()
1110         inside the FrameLoader class.
1111         (WebCore::FrameLoader::requestFrame): Use less DeprecatedString.
1112         (WebCore::FrameLoader::clear): Stop the redirection timer.
1113         (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the
1114         entire function in an if statement. Use less DeprecatedString.
1115         (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator.
1116         (WebCore::FrameLoader::scheduleRefresh): Ditto.
1117         (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer()
1118         inside the FrameLoader class.
1119         * loader/mac/FrameLoaderMac.mm:
1120         (WebCore::FrameLoader::load): Ditto.
1121         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
1122
1123 2006-11-07  Beth Dakin  <bdakin@apple.com>
1124
1125         Reviewed by Hyatt.
1126
1127         Another go at fix for <rdar://problem/4820814> A crash occurs at 
1128         WebCore::HitTestResult::spellingToolTip() when mousing down on 
1129         iframe at www.macsurfer.com
1130
1131         The fix from yesterday caused a layout test regression which 
1132         exposed an existing bug. The existing bug was that we allowed text 
1133         nodes to stay in the head tag, but other browsers move them to the 
1134         body. The previous fix also caused a performance regression, which 
1135         was seemingly easy to fix by moving the new clause in 
1136         HTMLParser::handleError() to be below the HTMLElement case.
1137
1138         * html/HTMLDocument.cpp:
1139         (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to 
1140         be the child of the document.
1141         * html/HTMLHeadElement.cpp:
1142         (WebCore::HTMLHeadElement::childAllowed): Do not allow non-
1143         whitespace text nodes to be children of the head.
1144         * html/HTMLHeadElement.h:
1145         * html/HTMLParser.cpp:
1146         (WebCore::HTMLParser::handleError): Error case for comment nodes.
1147         * page/FrameView.cpp:
1148         (WebCore::FrameView::handleMousePressEvent): Safety-net null check 
1149         for the original crash. 
1150
1151 2006-11-07  Darin Adler  <darin@apple.com>
1152
1153         - another attempt to fix Qt build
1154
1155         * loader/icon/IconLoader.h: Added missing include.
1156
1157 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1158
1159         Reviewed by Tim Hatcher.
1160         
1161         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
1162         
1163         None of Screen's responsibilities require up-calls to WebKit or delegates, 
1164         so WebCore can handle it all.
1165         
1166         Moved Screen back from page/ to platform/ because it's a platform
1167         abstraction again.
1168
1169         Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
1170         since the two were always used together.
1171         
1172         Changed pixel depth queries to query the deepest screen. Darin mentioned
1173         that it might have been a feature, not a bug, to use the main/menubar screen
1174         regardless of the screen you were on. For scaling and flipping that's not
1175         the case, but for querying pixel depth I think it is. You want to know
1176         about the highest pixel depth your content may display on.
1177         
1178         Tests still pass.
1179
1180         * WebCore.exp:
1181         * WebCore.xcodeproj/project.pbxproj:
1182         * page/Page.cpp:
1183         (WebCore::Page::Page):
1184         * page/Page.h:
1185         * page/Screen.cpp: Removed.
1186         * page/Screen.h: Removed.
1187         * page/ScreenClient.h: Removed.
1188         * platform/mac/PlatformMouseEventMac.mm:
1189         (WebCore::globalPoint):
1190         * platform/mac/ScreenMac.mm:
1191         (WebCore::window):
1192         (WebCore::bestScreen):
1193         (WebCore::Screen::depth):
1194         (WebCore::Screen::depthPerComponent):
1195         (WebCore::Screen::isMonochrome):
1196         (WebCore::Screen::rect):
1197         (WebCore::Screen::usableRect):
1198         (WebCore::toUserSpace):
1199         (WebCore::toDeviceSpace):
1200
1201 2006-11-07  Darin Adler  <darin@apple.com>
1202
1203         - try to fix Qt build
1204
1205         * CMakeLists.txt: Updated for some file changes.
1206         * WebCoreSources.bkl: Ditto.
1207
1208 2006-11-07  Darin Adler  <darin@apple.com>
1209
1210         Reviewed by Geoff.
1211
1212         - moved loader code from Frame/FrameMac to FrameLoader
1213
1214         * WebCore.exp:
1215         * WebCore.xcodeproj/project.pbxproj:
1216         * bindings/js/JSXSLTProcessor.h:
1217         * bindings/js/kjs_events.cpp:
1218         (KJS::JSLazyEventListener::parseCode):
1219         * bindings/js/kjs_html.cpp:
1220         (KJS::JSHTMLDocument::putValueProperty):
1221         * bindings/js/kjs_navigator.cpp:
1222         (KJS::Navigator::getValueProperty):
1223         * bindings/js/kjs_proxy.cpp:
1224         (WebCore::KJSProxy::initScriptIfNeeded):
1225         * bindings/js/kjs_window.cpp:
1226         (KJS::Screen::Screen):
1227         (KJS::createNewWindow):
1228         (KJS::Window::getValueProperty):
1229         (KJS::Window::put):
1230         (KJS::Window::isSafeScript):
1231         (KJS::WindowFunc::callAsFunction):
1232         (KJS::ScheduledAction::execute):
1233         (KJS::Location::getValueProperty):
1234         (KJS::Location::put):
1235         (KJS::Location::toString):
1236         (KJS::LocationFunc::callAsFunction):
1237         (KJS::History::getValueProperty):
1238         (KJS::HistoryFunc::callAsFunction):
1239         * bindings/objc/DOM.mm:
1240         (+[DOMNode _nodeWith:WebCore::]):
1241         * bridge/mac/FrameMac.h:
1242         * bridge/mac/FrameMac.mm:
1243         (WebCore::FrameMac::~FrameMac):
1244         (WebCore::FrameMac::setView):
1245         (WebCore::FrameMac::setStatusBarText):
1246         * bridge/mac/WebCoreFrameBridge.h:
1247         * bridge/mac/WebCoreFrameBridge.mm:
1248         (-[WebCoreFrameBridge close]):
1249         (-[WebCoreFrameBridge addData:]):
1250         (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
1251         (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
1252         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1253         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1254         (-[WebCoreFrameBridge baseURL]):
1255         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
1256         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
1257         (-[WebCoreFrameBridge canProvideDocumentSource]):
1258         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
1259         * css/cssparser.cpp:
1260         (WebCore::CSSParser::parseContent):
1261         * dom/DOMImplementation.cpp:
1262         (WebCore::DOMImplementation::createDocument):
1263         (WebCore::DOMImplementation::createHTMLDocument):
1264         * dom/DOMImplementation.h:
1265         * dom/Document.cpp:
1266         (WebCore::Document::readyState):
1267         (WebCore::Document::updateTitle):
1268         (WebCore::Document::open):
1269         (WebCore::Document::close):
1270         (WebCore::Document::implicitClose):
1271         (WebCore::Document::processHttpEquiv):
1272         (WebCore::Document::referrer):
1273         (WebCore::Document::finishedParsing):
1274         * dom/ProcessingInstruction.cpp:
1275         (WebCore::ProcessingInstruction::checkStyleSheet):
1276         * dom/XMLTokenizer.cpp:
1277         (WebCore::XMLTokenizer::endElementNs):
1278         (WebCore::ignorableWhitespaceHandler):
1279         (WebCore::XMLTokenizer::notifyFinished):
1280         * editing/TextIterator.cpp:
1281         (WebCore::TextIterator::rangeFromLocationAndLength):
1282         * html/HTMLAnchorElement.cpp:
1283         (WebCore::HTMLAnchorElement::defaultEventHandler):
1284         * html/HTMLBaseElement.cpp:
1285         (WebCore::HTMLBaseElement::process):
1286         * html/HTMLDocument.cpp:
1287         (WebCore::HTMLDocument::lastModified):
1288         * html/HTMLFormElement.cpp:
1289         (WebCore::HTMLFormElement::formData):
1290         (WebCore::HTMLFormElement::submit):
1291         * html/HTMLFrameElementBase.cpp:
1292         (WebCore::HTMLFrameElementBase::isURLAllowed):
1293         (WebCore::HTMLFrameElementBase::openURL):
1294         (WebCore::HTMLFrameElementBase::willRemove):
1295         * html/HTMLInputElement.cpp:
1296         (WebCore::HTMLInputElement::setValueFromRenderer):
1297         * html/HTMLLinkElement.cpp:
1298         (WebCore::HTMLLinkElement::process):
1299         * html/HTMLParser.cpp:
1300         (WebCore::HTMLParser::handleError):
1301         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
1302         * html/HTMLPreElement.idl:
1303         * html/HTMLScriptElement.cpp:
1304         (WebCore::HTMLScriptElement::parseMappedAttribute):
1305         (WebCore::HTMLScriptElement::insertedIntoDocument):
1306         * html/HTMLTokenizer.cpp:
1307         (WebCore::HTMLTokenizer::scriptExecution):
1308         (WebCore::HTMLTokenizer::parseTag):
1309         (WebCore::HTMLTokenizer::write):
1310         (WebCore::HTMLTokenizer::stopParsing):
1311         (WebCore::HTMLTokenizer::timerFired):
1312         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1313         (WebCore::KCanvasFilterQuartz::prepareFilter):
1314         * ksvg2/svg/SVGAElement.cpp:
1315         (WebCore::SVGAElement::defaultEventHandler):
1316         * ksvg2/svg/SVGElement.cpp:
1317         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
1318         * loader/DocLoader.cpp:
1319         (WebCore::DocLoader::setLoadInProgress):
1320         * loader/FrameLoader.cpp:
1321         (WebCore::FormSubmission::FormSubmission):
1322         (WebCore::ScheduledRedirection::):
1323         (WebCore::ScheduledRedirection::ScheduledRedirection):
1324         (WebCore::cancelAll):
1325         (WebCore::getString):
1326         (WebCore::isBackForwardLoadType):
1327         (WebCore::numRequests):
1328         (WebCore::FrameLoader::FrameLoader):
1329         (WebCore::FrameLoader::~FrameLoader):
1330         (WebCore::FrameLoader::createWindow):
1331         (WebCore::FrameLoader::changeLocation):
1332         (WebCore::FrameLoader::urlSelected):
1333         (WebCore::FrameLoader::requestFrame):
1334         (WebCore::FrameLoader::loadSubframe):
1335         (WebCore::FrameLoader::submitFormAgain):
1336         (WebCore::FrameLoader::submitForm):
1337         (WebCore::FrameLoader::stopLoading):
1338         (WebCore::FrameLoader::stop):
1339         (WebCore::FrameLoader::closeURL):
1340         (WebCore::FrameLoader::cancelRedirection):
1341         (WebCore::FrameLoader::iconURL):
1342         (WebCore::FrameLoader::didOpenURL):
1343         (WebCore::FrameLoader::didExplicitOpen):
1344         (WebCore::FrameLoader::replaceContentsWithScriptResult):
1345         (WebCore::FrameLoader::executeScript):
1346         (WebCore::FrameLoader::cancelAndClear):
1347         (WebCore::FrameLoader::clear):
1348         (WebCore::FrameLoader::receivedFirstData):
1349         (WebCore::FrameLoader::responseMIMEType):
1350         (WebCore::FrameLoader::setResponseMIMEType):
1351         (WebCore::FrameLoader::begin):
1352         (WebCore::FrameLoader::write):
1353         (WebCore::FrameLoader::end):
1354         (WebCore::FrameLoader::endIfNotLoading):
1355         (WebCore::FrameLoader::startIconLoader):
1356         (WebCore::FrameLoader::commitIconURLToIconDatabase):
1357         (WebCore::FrameLoader::gotoAnchor):
1358         (WebCore::FrameLoader::finishedParsing):
1359         (WebCore::FrameLoader::loadDone):
1360         (WebCore::FrameLoader::checkCompleted):
1361         (WebCore::FrameLoader::checkEmitLoadEvent):
1362         (WebCore::FrameLoader::baseURL):
1363         (WebCore::FrameLoader::baseTarget):
1364         (WebCore::FrameLoader::completeURL):
1365         (WebCore::FrameLoader::scheduleRedirection):
1366         (WebCore::FrameLoader::scheduleLocationChange):
1367         (WebCore::FrameLoader::scheduleRefresh):
1368         (WebCore::FrameLoader::isScheduledLocationChangePending):
1369         (WebCore::FrameLoader::scheduleHistoryNavigation):
1370         (WebCore::FrameLoader::redirectionTimerFired):
1371         (WebCore::FrameLoader::encoding):
1372         (WebCore::FrameLoader::requestObject):
1373         (WebCore::FrameLoader::shouldUsePlugin):
1374         (WebCore::FrameLoader::loadPlugin):
1375         (WebCore::FrameLoader::clearRecordedFormValues):
1376         (WebCore::FrameLoader::recordFormValue):
1377         (WebCore::FrameLoader::parentCompleted):
1378         (WebCore::FrameLoader::outgoingReferrer):
1379         (WebCore::FrameLoader::lastModified):
1380         (WebCore::FrameLoader::opener):
1381         (WebCore::FrameLoader::setOpener):
1382         (WebCore::FrameLoader::openedByJavaScript):
1383         (WebCore::FrameLoader::setOpenedByJavaScript):
1384         (WebCore::FrameLoader::handleFallbackContent):
1385         (WebCore::FrameLoader::provisionalLoadStarted):
1386         (WebCore::FrameLoader::userGestureHint):
1387         (WebCore::FrameLoader::didNotOpenURL):
1388         (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
1389         (WebCore::FrameLoader::setEncoding):
1390         (WebCore::FrameLoader::addData):
1391         (WebCore::FrameLoader::canCachePage):
1392         (WebCore::FrameLoader::updatePolicyBaseURL):
1393         (WebCore::FrameLoader::setPolicyBaseURL):
1394         (WebCore::FrameLoader::scrollToAnchor):
1395         (WebCore::FrameLoader::isComplete):
1396         (WebCore::FrameLoader::isLoadingMainResource):
1397         (WebCore::FrameLoader::url):
1398         (WebCore::FrameLoader::startRedirectionTimer):
1399         (WebCore::FrameLoader::stopRedirectionTimer):
1400         (WebCore::FrameLoader::updateBaseURLForEmptyDocument):
1401         (WebCore::FrameLoader::completed):
1402         (WebCore::FrameLoader::started):
1403         (WebCore::FrameLoader::containsPlugins):
1404         (WebCore::FrameLoader::prepareForLoadStart):
1405         (WebCore::FrameLoader::setupForReplace):
1406         (WebCore::FrameLoader::setupForReplaceByMIMEType):
1407         (WebCore::FrameLoader::finalSetupForReplace):
1408         (WebCore::FrameLoader::load):
1409         (WebCore::FrameLoader::canTarget):
1410         (WebCore::FrameLoader::stopLoadingPlugIns):
1411         (WebCore::FrameLoader::stopLoadingSubresources):
1412         (WebCore::FrameLoader::stopLoadingSubframes):
1413         (WebCore::FrameLoader::stopAllLoaders):
1414         (WebCore::FrameLoader::cancelMainResourceLoad):
1415         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1416         (WebCore::FrameLoader::activeDocumentLoader):
1417         (WebCore::FrameLoader::addPlugInStreamLoader):
1418         (WebCore::FrameLoader::removePlugInStreamLoader):
1419         (WebCore::FrameLoader::hasMainResourceLoader):
1420         (WebCore::FrameLoader::isLoadingSubresources):
1421         (WebCore::FrameLoader::isLoadingPlugIns):
1422         (WebCore::FrameLoader::isLoading):
1423         (WebCore::FrameLoader::addSubresourceLoader):
1424         (WebCore::FrameLoader::removeSubresourceLoader):
1425         (WebCore::FrameLoader::releaseMainResourceLoader):
1426         (WebCore::FrameLoader::setDocumentLoader):
1427         (WebCore::FrameLoader::documentLoader):
1428         (WebCore::FrameLoader::setPolicyDocumentLoader):
1429         (WebCore::FrameLoader::provisionalDocumentLoader):
1430         (WebCore::FrameLoader::setProvisionalDocumentLoader):
1431         (WebCore::FrameLoader::state):
1432         (WebCore::FrameLoader::timeOfLastCompletedLoad):
1433         (WebCore::FrameLoader::setState):
1434         (WebCore::FrameLoader::clearProvisionalLoad):
1435         (WebCore::FrameLoader::markLoadComplete):
1436         (WebCore::FrameLoader::commitProvisionalLoad):
1437         (WebCore::FrameLoader::privateBrowsingEnabled):
1438         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
1439         (WebCore::FrameLoader::clientRedirected):
1440         (WebCore::FrameLoader::shouldReload):
1441         (WebCore::FrameLoader::closeOldDataSources):
1442         (WebCore::FrameLoader::open):
1443         (WebCore::FrameLoader::isStopping):
1444         (WebCore::FrameLoader::finishedLoading):
1445         (WebCore::FrameLoader::URL):
1446         (WebCore::FrameLoader::isArchiveLoadPending):
1447         (WebCore::FrameLoader::isHostedByObjectElement):
1448         (WebCore::FrameLoader::isLoadingMainFrame):
1449         (WebCore::FrameLoader::canShowMIMEType):
1450         (WebCore::FrameLoader::representationExistsForURLScheme):
1451         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
1452         (WebCore::FrameLoader::cancelContentPolicyCheck):
1453         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
1454         (WebCore::FrameLoader::finishedLoadingDocument):
1455         (WebCore::FrameLoader::isReplacing):
1456         (WebCore::FrameLoader::setReplacing):
1457         (WebCore::FrameLoader::revertToProvisional):
1458         (WebCore::FrameLoader::subframeIsLoading):
1459         (WebCore::FrameLoader::willChangeTitle):
1460         (WebCore::FrameLoader::loadType):
1461         (WebCore::FrameLoader::stopPolicyCheck):
1462         (WebCore::FrameLoader::continueAfterContentPolicy):
1463         (WebCore::FrameLoader::continueAfterWillSubmitForm):
1464         (WebCore::FrameLoader::didFirstLayout):
1465         (WebCore::FrameLoader::frameLoadCompleted):
1466         (WebCore::FrameLoader::firstLayoutDone):
1467         (WebCore::FrameLoader::isQuickRedirectComing):
1468         (WebCore::FrameLoader::closeDocument):
1469         (WebCore::FrameLoader::detachChildren):
1470         (WebCore::FrameLoader::checkLoadComplete):
1471         (WebCore::FrameLoader::numPendingOrLoadingRequests):
1472         (WebCore::FrameLoader::setClient):
1473         (WebCore::FrameLoader::client):
1474         (WebCore::FrameLoader::userAgent):
1475         (WebCore::FrameLoader::createEmptyDocument):
1476         (WebCore::FrameLoader::tokenizerProcessedData):
1477         (WebCore::FrameLoader::didTellBridgeAboutLoad):
1478         (WebCore::FrameLoader::haveToldBridgeAboutLoad):
1479         (WebCore::FrameLoader::handledOnloadEvents):
1480         (WebCore::FrameLoader::frameDetached):
1481         (WebCore::FrameLoader::setTitle):
1482         (WebCore::FrameLoaderClient::~FrameLoaderClient):
1483         * loader/FrameLoader.h:
1484         (WebCore::):
1485         * loader/FrameLoaderClient.h:
1486         * loader/PluginDocument.cpp:
1487         (WebCore::PluginTokenizer::createDocumentStructure):
1488         (WebCore::PluginTokenizer::writeRawData):
1489         * loader/ResourceLoader.h:
1490         * loader/TextResourceDecoder.cpp:
1491         (WebCore::TextResourceDecoder::checkForHeadCharset):
1492         * loader/icon/IconLoader.cpp:
1493         (WebCore::IconLoader::startLoading):
1494         (WebCore::IconLoader::finishLoading):
1495         * loader/loader.cpp:
1496         (WebCore::Loader::didReceiveResponse):
1497         * loader/mac/DocumentLoaderMac.mm:
1498         (WebCore::DocumentLoader::~DocumentLoader):
1499         (WebCore::DocumentLoader::stopLoading):
1500         (WebCore::DocumentLoader::finishedLoading):
1501         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
1502         (WebCore::DocumentLoader::setPrimaryLoadComplete):
1503         * loader/mac/FrameLoaderMac.mm:
1504         (WebCore::FrameLoader::load):
1505         (WebCore::FrameLoader::startLoading):
1506         (WebCore::FrameLoader::cancelMainResourceLoad):
1507         (WebCore::FrameLoader::receivedMainResourceError):
1508         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
1509         (WebCore::FrameLoader::commitProvisionalLoad):
1510         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
1511         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1512         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
1513         (WebCore::FrameLoader::detachFromParent):
1514         (WebCore::FrameLoader::addExtraFieldsToRequest):
1515         (WebCore::FrameLoader::loadResourceSynchronously):
1516         (WebCore::FrameLoader::createFrame):
1517         (WebCore::FrameLoader::objectContentType):
1518         (WebCore::nsArray):
1519         (WebCore::FrameLoader::createPlugin):
1520         (WebCore::FrameLoader::redirectDataToPlugin):
1521         (WebCore::FrameLoader::createJavaAppletWidget):
1522         (WebCore::FrameLoader::partClearedInBegin):
1523         (WebCore::FrameLoader::saveDocumentState):
1524         (WebCore::FrameLoader::restoreDocumentState):
1525         (WebCore::FrameLoader::overrideMediaType):
1526         (WebCore::FrameLoader::mainResourceData):
1527         (WebCore::FrameLoader::canGoBackOrForward):
1528         (WebCore::FrameLoader::originalRequestURL):
1529         (WebCore::FrameLoader::getHistoryLength):
1530         (WebCore::FrameLoader::goBackOrForward):
1531         (WebCore::FrameLoader::historyURL):
1532         (WebCore::FrameLoader::didFinishLoad):
1533         * loader/mac/LoaderFunctionsMac.mm:
1534         (WebCore::ServeSynchronousRequest):
1535         (WebCore::CheckCacheObjectStatus):
1536         * loader/mac/ResourceLoaderMac.mm:
1537         (WebCore::ResourceLoader::cancel):
1538         * loader/mac/SubresourceLoaderMac.mm:
1539         (WebCore::SubresourceLoader::create):
1540         * loader/qt/FrameLoaderQt.cpp: Added.
1541         (WebCore::FrameLoader::submitForm):
1542         (WebCore::FrameLoader::urlSelected):
1543         (WebCore::FrameLoader::setTitle):
1544         (WebCore::FrameLoader::createFrame):
1545         (WebCore::FrameLoader::objectContentType):
1546         (WebCore::FrameLoader::createPlugin):
1547         (WebCore::FrameLoader::createJavaAppletWidget):
1548         (WebCore::FrameLoader::originalRequestURL):
1549         * page/DOMWindow.cpp:
1550         (WebCore::DOMWindow::document):
1551         * page/Frame.cpp:
1552         (WebCore::Frame::~Frame):
1553         (WebCore::Frame::reparseConfiguration):
1554         (WebCore::Frame::shouldDragAutoNode):
1555         (WebCore::Frame::prepareForUserAction):
1556         (WebCore::FramePrivate::FramePrivate):
1557         (WebCore::FramePrivate::~FramePrivate):
1558         * page/Frame.h:
1559         * page/FramePrivate.h:
1560         * page/FrameView.cpp:
1561         (WebCore::FrameView::layout):
1562         (WebCore::FrameView::mediaType):
1563         * page/FrameView.h:
1564         * page/PageState.cpp:
1565         (WebCore::PageState::PageState):
1566         (WebCore::PageState::restoreJavaScriptState):
1567         * platform/mac/CookieJar.mm:
1568         (WebCore::setCookies):
1569         * platform/mac/TextCodecMac.cpp:
1570         * platform/mac/WebFontCache.mm:
1571         (+[WebFontCache fontWithFamily:traits:size:]):
1572         * platform/network/cf/ResourceHandleCFNet.cpp:
1573         (WebCore::ResourceHandle::start):
1574         * platform/network/mac/ResourceHandleMac.mm:
1575         (WebCore::ResourceHandle::start):
1576         * platform/qt/FrameQt.cpp:
1577         * platform/qt/FrameQt.h:
1578         * rendering/RenderApplet.cpp:
1579         (WebCore::RenderApplet::createWidgetIfNecessary):
1580         * rendering/RenderBlock.h:
1581         * rendering/RenderPartObject.cpp:
1582         (WebCore::isURLAllowed):
1583         (WebCore::RenderPartObject::updateWidget):
1584         * xml/DOMParser.cpp:
1585         (WebCore::DOMParser::parseFromString):
1586         * xml/XSLTProcessor.cpp:
1587         (WebCore::XSLTProcessor::createDocumentFromSource):
1588         * xml/xmlhttprequest.cpp:
1589         (WebCore::XMLHttpRequest::getResponseXML):
1590
1591 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
1592
1593         Reviewed by Geoff.
1594
1595         Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.
1596         
1597         * bridge/mac/FrameMac.mm:
1598         (WebCore::FrameMac::registerCommandForUndoOrRedo):
1599         * bridge/mac/WebCoreFrameBridge.h:
1600         * bridge/mac/WebCoreFrameBridge.mm:
1601         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1602         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1603         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]):
1604         (-[WebCoreFrameBridge selectionGranularity]):
1605         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
1606         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
1607         (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
1608         (-[WebCoreFrameBridge applyStyle:withUndoAction:]):
1609         (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
1610         * editing/SelectionController.cpp:
1611         (WebCore::SelectionController::setModifyBias):
1612         (WebCore::SelectionController::modify):
1613         * editing/SelectionController.h:
1614         (WebCore::SelectionController::):
1615         * editing/TextGranularity.h:
1616
1617 2006-11-07  Brady Eidson  <beidson@apple.com>
1618
1619         Reviewed by Maciej
1620
1621         Changed the check for "top level frame" to something much more valid
1622
1623         * page/Frame.cpp:
1624         (WebCore::Frame::endIfNotLoading):
1625
1626 2006-11-07  Beth Dakin  <bdakin@apple.com>
1627
1628         Reviewed by Hyatt (yesterday).
1629
1630         Here is part of my patch from yesterday that is safe to roll back 
1631         in. It will make the BuildBot happy.
1632
1633         * rendering/HitTestResult.cpp:
1634         (WebCore::HitTestResult::spellingToolTip): Null-check 
1635         m_innerNonSharedNode.
1636
1637 2006-11-07  Darin Adler  <darin@apple.com>
1638
1639         * loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse):
1640         Comment grammar fix.
1641
1642 2006-11-07  Darin Adler  <darin@apple.com>
1643
1644         Rolled out change for <rdar://problem/4820814>.
1645
1646         Beth's planning on landing a new change for it soon, but in the mean time
1647         we need layout tests succeeding again.
1648
1649 2006-11-07  Darin Adler  <darin@apple.com>
1650
1651         Reviewed by Brady.
1652
1653         - fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher
1654           crashes on launch in WebCore::ResourceLoader::start
1655
1656         No layout test, because this depends on cached icons, although there's
1657         perhaps a way to write a test for it with some further ingenuity.
1658
1659         * loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable
1660         to make explicit the fact that it can't be successfully copied.
1661         Remove notifyIconChanged function and put the contents in the caller.
1662         This eliminates the need for IconLoaderMac.mm. Added finishedLoading
1663         and clearLoadingState functions to share code. Removed m_url, since the
1664         resource handle already stores the URL. Renamed m_resourceLoader to
1665         m_handle to reflect the class's name change. Removed the 4096-byte
1666         inline buffer from m_data, since the malloc savings is not sufficient
1667         to offset the additional memory use. Removed m_httpStatusCode because
1668         we can instead cancel the load when we get a status code that reflects
1669         failure. Added m_loadIsInProgress boolean because we need to detect
1670         loads that complete during the ResourceHandle::create function call.
1671
1672         * loader/icon/IconLoader.cpp:
1673         (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress.
1674         Don't initialize m_httpStatusCode.
1675         (WebCore::IconLoader::~IconLoader): Updated for name change.
1676         (WebCore::IconLoader::startLoading): Added code to use the
1677         m_loadIsInProgress flag to detect if the load completed while inside
1678         the ResourceHandle::create function. Removed code to set m_url.
1679         (WebCore::IconLoader::stopLoading): Call clearLoadingState to share
1680         more code.
1681         (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle
1682         and finish loading if the HTTP status code indicates failure.
1683         (WebCore::IconLoader::didReceiveData): Removed assertion that checks
1684         the ResourceHandle, since we can't do that any more.
1685         (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading
1686         so we can share code with the new didReceiveResponse code path.
1687         (WebCore::IconLoader::finishLoading): Moved code here from the
1688         didFinishLoading callback. Pass a URL when calling
1689         commitIconURLToIconDatabase. Call notifyIconChanged directly here
1690         instead of using a separate function. Call clearLoadingState to
1691         share more code with stopLoading.
1692         (WebCore::IconLoader::clearLoadingState): Added.
1693
1694         * loader/mac/IconLoaderMac.mm: Removed.
1695         * WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
1696
1697 2006-11-06  David Harrison  <harrison@apple.com>
1698
1699         Reviewed by Darin.
1700
1701         <rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
1702
1703         * editing/pasteboard/3976872-expected.txt:
1704         * editing/pasteboard/4076267-2-expected.txt:
1705         * editing/pasteboard/4076267-3-expected.txt:
1706         * editing/pasteboard/4076267-expected.txt:
1707         * editing/pasteboard/8145-1-expected.txt:
1708         * editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
1709         * editing/pasteboard/paste-match-style-001-expected.txt:
1710         * editing/pasteboard/paste-match-style-002-expected.txt:
1711         * editing/pasteboard/paste-text-019-expected.txt:
1712         * editing/pasteboard/pasting-tabs-expected.txt:
1713         Updated because pasting text with no newlines does not use intermediate div.
1714         
1715         * editing/markup.cpp:
1716         (WebCore::fillContainerFromString):
1717         First parameter is now a Container so a fragment can be passed.
1718         
1719         (WebCore::createFragmentFromText):
1720         A string with no newlines gets added inline, rather than being put into a paragraph.
1721
1722 2006-11-06  Beth Dakin  <bdakin@apple.com>
1723
1724         Reviewed by Hyatt.
1725
1726         Fix for <rdar://problem/4820814> A crash occurs at 
1727         WebCore::HitTestResult::spellingToolTip() when mousing down on 
1728         iframe at www.macsurfer.com
1729
1730         The bug here is that the source of the iframe is only a comment, 
1731         and we were not properly constructing the frame because it was 
1732         sort-of empty but not.
1733
1734         * html/HTMLDocument.cpp:
1735         (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if 
1736         it is a comment node.
1737         * html/HTMLParser.cpp:
1738         (WebCore::HTMLParser::handleError): if n is a comment node and 
1739         there is no head, we create a head, insert in the document, and add 
1740         the comment node as a child. This is what Firefox does too. 
1741         * page/FrameView.cpp:
1742         (WebCore::FrameView::handleMousePressEvent): Safe-guard for the 
1743         fix. It is possible to get a mouse event without a target node, so 
1744         we null check it. (Of course, in the case of this bug, it should 
1745         not have been null, but it is a good thing to check for anyway.
1746         * rendering/HitTestResult.cpp:
1747         (WebCore::HitTestResult::spellingToolTip): Null-check 
1748         m_innerNonSharedNode.
1749
1750 2006-11-06  Justin Garcia  <justin.garcia@apple.com>
1751
1752         Reviewed by harrison
1753         
1754         <rdar://problem/4641880>
1755         Setting bullets to existing text grabs subsequent paragraph
1756         
1757         When a selection ends at the start of a paragraph, we rarely paint 
1758         the selection gap before that paragraph, because there often is no gap.  
1759         In a case like this, it's not obvious to the user that the selection 
1760         ends "inside" that paragraph, so it would be confusing if 
1761         InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.
1762         
1763         * editing/FormatBlockCommand.cpp:
1764         (WebCore::FormatBlockCommand::doApply): Moved the check for editability of
1765         the selection to a more appropriate place.  Change the endingSelection
1766         if it ends at the start of a paragraph.
1767         * editing/IndentOutdentCommand.cpp:
1768         (WebCore::IndentOutdentCommand::doApply): Ditto.
1769         * editing/InsertListCommand.cpp:
1770         (WebCore::InsertListCommand::doApply): Ditto.
1771
1772 2006-11-06  Brady Eidson  <beidson@apple.com>
1773
1774         Reviewed by Sarge
1775
1776         <rdar://problem/4822911> - ASSERTION was a little overzealous.  
1777         Toned it down a bit.
1778
1779         * xml/xmlhttprequest.cpp:
1780         (WebCore::XMLHttpRequest::didFinishLoading):  Toned down assertion
1781
1782 2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1783
1784         Reviewed by Maciej.
1785
1786         Linux\Gdk build fixes.
1787
1788         * loader/icon/IconDatabase.cpp:
1789         * loader/icon/SQLStatement.h:
1790         * platform/gdk/ChromeClientGdk.h: Added.
1791         (WebCore::ChromeClientGdk::~ChromeClientGdk):
1792         * platform/gdk/CursorGdk.cpp:
1793         (WebCore::pointerCursor):
1794         * platform/gdk/FrameGdk.cpp:
1795         (WebCore::doScroll):
1796         (WebCore::FrameGdk::FrameGdk):
1797         (WebCore::FrameGdk::submitForm):
1798         (WebCore::FrameGdk::urlSelected):
1799         (WebCore::FrameGdk::openURL):
1800         (WebCore::FrameGdk::handleGdkEvent):
1801         * platform/gdk/FrameGdk.h:
1802         (WebCore::FrameGdk::client):
1803         * platform/gdk/RenderPopupMenuGdk.cpp:
1804         (WebCore::PopupMenu::updateFromElement):
1805         * platform/gdk/ScreenGdk.cpp:
1806         * platform/gdk/TemporaryLinkStubs.cpp:
1807         (Slider::focusPolicy):
1808         (WebCore::ServeSynchronousRequest):
1809         (FrameGdk::goBackOrForward):
1810         (FrameGdk::getHistoryLength):
1811         (FrameGdk::historyURL):
1812         (ChromeClientGdk::canRunModal):
1813         (ChromeClientGdk::runModal):
1814         (WebCore::systemBeep):
1815         (WebCore::CachedResource::setPlatformResponse):
1816         (Path::transform):
1817         (ResourceLoader::loadsBlocked):
1818         (IconLoader::notifyIconChanged):
1819         * platform/network/gdk/ResourceHandleManager.cpp:
1820         (WebCore::writeCallback):
1821         (WebCore::ResourceHandleManager::downloadTimerCallback):
1822         (WebCore::ResourceHandleManager::remove):
1823         (WebCore::ResourceHandleManager::add):
1824
1825 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1826
1827         build fix.
1828         
1829         * WebCore.xcodeproj/project.pbxproj:
1830
1831 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1832
1833         Reviewed by Maciej, Anders, Darin.
1834
1835         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
1836         Fixed a minor where WebCore would always assume it was displayed on the 
1837         monitor containing the menubar. window.open and window.showModalDialog 
1838         are now cross-platform. 
1839         
1840         Layout tests, manual-tests/show-modal-dialog, and manual-tests/
1841         window-open-features-parsing all pass. I verified the new screen functionality
1842         by running in DRT, and checking whether WebCore knew it was off-screen.
1843         
1844         Some refactoring remains, as all were not pleased by this design. I see
1845         in my future another patch.
1846
1847         * bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
1848         client, to encapsulate asking the platform questions about the screen occupied by
1849         the page. (Previously, we always assumed we were on screen 0, which was a bug.)
1850         * bridge/mac/WebCoreFrameBridge.mm:
1851         (createMouseEventFromDraggingInfo): Reversed argument order, to match other
1852         functions.
1853         (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
1854         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
1855         * bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
1856         * bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
1857         * bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
1858         * bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
1859         * manual-tests/window-open-features-parsing.html: Updated for accuracy.
1860         (In this case, neither size nor position is specified, so you should
1861         get the default window size and position.)
1862         * page/Screen.cpp: Added. Includes screen-related helper functions used
1863         in WebCore and WebKit.
1864         * platform/PlatformMouseEvent.h: Exported common code so it doesn't have
1865         to be duplicated. Renamed "position" to "point" since both were used,
1866         and "point" seemed clearer.
1867         * platform/Screen.h: Removed. Dead Code.
1868         * platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
1869         initialization.
1870
1871 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
1872
1873         Reviewed by Tim Hatcher.
1874
1875         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
1876         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
1877         
1878         No layout tests added as this must be tested manually by the test
1879         WebCore/manual-tests/contenteditable-link.html
1880
1881         * WebCore.exp: Exported HitTestResult::isLiveLink().
1882         * html/HTMLAnchorElement.cpp:
1883         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
1884         (WebCore::HTMLAnchorElement::defaultEventHandler):
1885         (WebCore::HTMLAnchorElement::isLiveLink):
1886         * html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
1887         to track shift key status.
1888         * manual-tests/contenteditable-link.html: Added description about link
1889         dragging behaviour.
1890         * rendering/HitTestResult.cpp:
1891         (WebCore::HitTestResult::isLiveLink): Added.
1892         * rendering/HitTestResult.h:
1893
1894 2006-11-06  Brady Eidson  <beidson@apple.com>
1895
1896         Reviewed by Oliver
1897
1898         Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
1899         For now, we have to not load favicons when we have no Document - linking directly 
1900         to PDFs being the common case
1901
1902         * loader/icon/IconLoader.cpp:
1903         (WebCore::IconLoader::startLoading): Check for the document and return if none
1904
1905 2006-11-06  Brady Eidson  <beidson@apple.com>
1906
1907         Reviewed by Dave Harrison
1908
1909         <rdar://problem/4801066>
1910         Added a critical null frameLoader() check
1911
1912         * loader/mac/MainResourceLoaderMac.mm:
1913         (WebCore::MainResourceLoader::loadNow):
1914
1915 2006-11-06  David Harrison  <harrison@apple.com>
1916
1917         Reviewed by Darin.
1918
1919         <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
1920
1921         Test:
1922         * editing/deleting/delete-br-012.html
1923         
1924         * editing/DeleteSelectionCommand.cpp:
1925         (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
1926         Update m_endingPosition when preventing merge.
1927         Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
1928
1929 2006-11-06  Mark Rowe  <bdash@webkit.org>
1930
1931         Reviewed by Maciej.
1932
1933         http://bugs.webkit.org/show_bug.cgi?id=11526
1934         Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
1935
1936         Update DOMNode::toString to always use className rather than preferring nodeName.
1937
1938         * bindings/js/kjs_dom.cpp:
1939         (KJS::DOMNode::toString): Match the format returned by valueOf.
1940
1941 2006-11-06  Oliver Hunt  <oliver@apple.com>
1942
1943         Reviewed by Maciej.
1944
1945         Fix RTL text in SVG to have correct positioning
1946
1947         * rendering/SVGRootInlineBox.cpp:
1948         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
1949
1950 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
1951
1952         Reviewed by Maciej.
1953
1954         http://bugs.webkit.org/show_bug.cgi?id=11517
1955         REGRESSION: Flash clicks/interactivity not working properly
1956
1957         * bridge/mac/FrameMac.mm:
1958         (WebCore::FrameMac::handleMouseMoveEvent):
1959         (WebCore::FrameMac::handleMouseReleaseEvent):
1960         Restore parts of event dispatching that were removed when fixing
1961         bug 7323 - just bypass those for subframes.
1962
1963 2006-11-05  Darin Adler  <darin@apple.com>
1964
1965         - quick attempt to fix the no-SVG build
1966
1967         * platform/graphics/svg/SVGResource.cpp:
1968         * platform/graphics/svg/SVGResource.h:
1969         * platform/graphics/svg/SVGResourceClipper.cpp:
1970         * platform/graphics/svg/SVGResourceClipper.h:
1971         * platform/graphics/svg/SVGResourceImage.h:
1972         * platform/graphics/svg/SVGResourceMarker.cpp:
1973         * platform/graphics/svg/SVGResourceMarker.h:
1974         * platform/graphics/svg/SVGResourceMasker.cpp:
1975         * platform/graphics/svg/SVGResourceMasker.h:
1976         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
1977         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
1978         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
1979         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
1980         Added #ifdef SVG_SUPPORT to these files.
1981
1982 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
1983
1984         Reviewed & landed by Maciej.
1985
1986         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
1987
1988         * platform/win/ResourceLoaderWin.cpp:
1989         (WebCore::transferJobStatusCallback):
1990         (WebCore::ResourceLoader::start):
1991
1992 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
1993
1994         Reviewed by Oliver.
1995
1996         - moved FormData and FormDataStream to platform/network directory
1997
1998         * WebCore.xcodeproj/project.pbxproj:
1999         * bridge/mac/WebCoreFrameBridge.mm:
2000         * loader/FormData.cpp: Removed.
2001         * loader/FormData.h: Removed.
2002         * loader/mac/FormDataStream.h: Removed.
2003         * loader/mac/FormDataStream.m: Removed.
2004         * loader/mac/FrameLoaderMac.mm:
2005         * loader/mac/SubresourceLoaderMac.mm:
2006         * platform/network/mac/FormDataStreamMac.h: Added.
2007         * platform/network/mac/FormDataStreamMac.mm: Added.
2008         * platform/network/mac/ResourceRequestMac.mm:
2009
2010 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
2011
2012         Fix build breaks
2013
2014         * loader/DocumentLoader.h:
2015         * platform/win/ScreenWin.cpp:
2016
2017 2006-11-05  Darin Adler  <darin@apple.com>
2018
2019         Reviewed by Geoff.
2020
2021         - more preparation for splitting up Frame into sub-pieces
2022         - removed unnecessary includes from Frame.h
2023
2024         * page/Frame.h: Removed unneeded includes and forward declarations.
2025         Added additional forward declarations. Removed the constant
2026         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
2027         Created sections of functions to be moved into Chrome, Editor,
2028         EventHandler, FrameLoader, SelectionController, and the Platform
2029         directory, as well as marking one function for deletion.
2030
2031         * page/FramePrivate.h: Removed the definition of the constructor and
2032         destructor and removed unnecessary includes.
2033
2034         * page/FrameView.h: Removed unneeded forward declarations and friend
2035         declarations. Created a section of functions and data to be moved into
2036         EventHandler.
2037
2038         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
2039         Created sections of functions and data to be moved into Chrome,
2040         Editor, EventHandler, FrameLoader, and the Platform directory.
2041
2042         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
2043         Removed unused methods areScrollbarsVisible,
2044         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
2045
2046         * page/Frame.cpp:
2047         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
2048         to include KURL.h just for the KURL default constructor.
2049         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
2050         (WebCore::FramePrivate::~FramePrivate): Ditto.
2051
2052         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
2053         booleans, scrollbarMoved and cleared funcitons.
2054         (WebCore::FrameView::clear): Moved the code from the cleared
2055         function in here.
2056         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
2057
2058         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
2059         for changes to header.
2060
2061         * editing/SelectionController.cpp:
2062         (WebCore::SelectionController::setSelection):
2063         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
2064         Moved NoXPosForVerticalArrowNavigation into this file.
2065
2066         * bindings/js/kjs_events.cpp:
2067         * bindings/js/kjs_html.cpp:
2068         * bindings/js/kjs_window.cpp:
2069         * bridge/mac/WebCoreAXObject.mm:
2070         * bridge/mac/WebCoreFrameBridge.mm:
2071         * css/cssstyleselector.cpp:
2072         * dom/Document.cpp:
2073         * dom/Element.cpp:
2074         * dom/EventTargetNode.cpp:
2075         * dom/MouseRelatedEvent.cpp:
2076         * dom/XMLTokenizer.cpp:
2077         * html/HTMLBaseElement.cpp:
2078         * html/HTMLDocument.cpp:
2079         * html/HTMLEmbedElement.cpp:
2080         * html/HTMLFrameElementBase.cpp:
2081         * html/HTMLGenericFormElement.cpp:
2082         * html/HTMLObjectElement.cpp:
2083         * html/HTMLTokenizer.cpp:
2084         * loader/mac/FrameLoaderMac.mm:
2085         * page/PageState.cpp:
2086         * rendering/RenderApplet.cpp:
2087         * rendering/RenderBlock.cpp:
2088         * rendering/RenderLayer.cpp:
2089         * rendering/RenderObject.cpp:
2090         * rendering/RenderPartObject.cpp:
2091         * rendering/RenderTreeAsText.cpp:
2092         * xml/XSLTProcessor.cpp:
2093         Added includes as needed to keep compiling, since there are fewer
2094         includes in Frame.h.
2095
2096 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
2097
2098         Reviewed by Dave Harrison.
2099
2100         http://bugs.webkit.org/show_bug.cgi?id=11402
2101         REGRESSION: onChange does not work anymore for 1st item in popup
2102
2103         * html/HTMLSelectElement.cpp:
2104         (WebCore::HTMLSelectElement::HTMLSelectElement):
2105         (WebCore::HTMLSelectElement::reset):
2106         Set m_lastOnChangeIndex to -1.
2107
2108 2006-11-04  Darin Adler  <darin@apple.com>
2109
2110         Reviewed by Anders.
2111
2112         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
2113           REGRESSION: Status bar always shows cancelled opening the page
2114
2115         * platform/network/mac/ResourceHandleMac.mm:
2116         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
2117         Since the subresource owns the resource handle, there's no need to cancel.
2118         This arrangement is only temporary, anyway, since Maciej will soon change
2119         things so that the subresource loader uses the resource handle and the
2120         resource handle doesn't know anything about the subresource loader.
2121
2122 2006-11-04  Darin Adler  <darin@apple.com>
2123
2124         Reviewed by Maciej.
2125
2126         - converted more of the loader machinery to work with cross-platform
2127           data structures instead of Macintosh-specific ones
2128
2129           converted most uses of NSURL to KURL and NSEvent to DOM Event in
2130           loader classes
2131
2132           moved download function out of FrameLoader.h to avoid reference to
2133           NSURLConnection
2134
2135           added DOM Event parameters to various functions so that the handlers
2136           can use the DOM Event instead of the global "current NSEvent";
2137           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
2138           HTMLFormElement::submit, FrameLoader::load
2139
2140           moved the setMainFrame call that hands ownership to the Page
2141           into one of the Frame constructors, and removed it from all
2142           the clients
2143
2144           removed const from Event parameter to the urlSelected function
2145           (we rarely use const with DOM elements)
2146
2147           removed some redundant includes and declarations from various
2148           header files
2149
2150           removed NSURL parameter from userAgent function -- if we need it we
2151           can add it back, but converting from NSURL to KURL and back is
2152           inefficient enough that it's best to have it out for now (since it's
2153           been unused for years) -- if we add it back, we can choose an
2154           appropriate parameter type that's always inexpensive to pass
2155
2156           did some basic cleanup in the IconLoader class, including removing
2157           an unnecessary loop that added icon data a byte at a time
2158
2159           renamed safeLoad to load, since it's no different from the other
2160           FrameLoader load functions, safety-wise
2161
2162           fixed some code that was trying to distinguish null frame name from
2163           empty string frame name -- both should be handled the same, but callers
2164           were doing it by checking for empty and turning it into null (in a way
2165           that was causing extra round trips between NSString and WebCore::String)
2166
2167           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
2168           and got rid of case-insensitive compares of methods
2169
2170         * WebCore.exp:
2171         * WebCore.xcodeproj/project.pbxproj:
2172         * bindings/js/kjs_navigator.cpp:
2173         (KJS::Navigator::getValueProperty):
2174         * bridge/mac/FrameMac.h:
2175         * bridge/mac/FrameMac.mm:
2176         (WebCore::FrameMac::submitForm):
2177         (WebCore::FrameMac::urlSelected):
2178         (WebCore::FrameMac::userAgent):
2179         * bridge/mac/FrameViewMac.mm:
2180         * bridge/mac/WebCoreAXObject.mm:
2181         (-[WebCoreAXObject rendererForView:]):
2182         * bridge/mac/WebCorePageBridge.h:
2183         * bridge/mac/WebCorePageBridge.mm:
2184         * bridge/mac/WebCoreSettings.mm:
2185         * bridge/win/FrameWin.cpp:
2186         (WebCore::FrameWin::urlSelected):
2187         (WebCore::FrameWin::submitForm):
2188         * bridge/win/FrameWin.h:
2189         * dom/MouseRelatedEvent.cpp:
2190         * dom/MouseRelatedEvent.h:
2191         * dom/UIEvent.cpp:
2192         (WebCore::UIEvent::~UIEvent):
2193         * dom/UIEvent.h:
2194         * dom/UIEventWithKeyState.h:
2195         * dom/XMLTokenizer.cpp:
2196         (WebCore::openFunc):
2197         * html/HTMLAnchorElement.cpp:
2198         (WebCore::HTMLAnchorElement::defaultEventHandler):
2199         * html/HTMLButtonElement.cpp:
2200         (WebCore::HTMLButtonElement::defaultEventHandler):
2201         * html/HTMLFormElement.cpp:
2202         (WebCore::HTMLFormElement::submitClick):
2203         (WebCore::HTMLFormElement::prepareSubmit):
2204         (WebCore::HTMLFormElement::submit):
2205         * html/HTMLFormElement.h:
2206         * html/HTMLInputElement.cpp:
2207         (WebCore::HTMLInputElement::defaultEventHandler):
2208         * html/HTMLSelectElement.cpp:
2209         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
2210         * loader/DocumentLoader.h:
2211         * loader/FrameLoader.h:
2212         * loader/FrameLoaderClient.h:
2213         * loader/NavigationAction.h:
2214         (WebCore::NavigationAction::event):
2215         * loader/icon/IconLoader.cpp:
2216         (WebCore::IconLoader::create):
2217         (WebCore::IconLoader::startLoading):
2218         (WebCore::IconLoader::didReceiveData):
2219         (WebCore::IconLoader::didFinishLoading):
2220         * loader/icon/IconLoader.h:
2221         * loader/loader.cpp:
2222         * loader/mac/DocumentLoaderMac.mm:
2223         (WebCore::DocumentLoader::URL):
2224         (WebCore::DocumentLoader::unreachableURL):
2225         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
2226         (WebCore::DocumentLoader::URLForHistory):
2227         * loader/mac/FrameLoaderMac.mm:
2228         (WebCore::FrameLoader::load):
2229         (WebCore::FrameLoader::willSendRequest):
2230         (WebCore::FrameLoader::clientRedirected):
2231         (WebCore::FrameLoader::shouldReload):
2232         (WebCore::FrameLoader::notifyIconChanged):
2233         (WebCore::FrameLoader::URL):
2234         (WebCore::FrameLoader::reloadAllowingStaleData):
2235         (WebCore::FrameLoader::reload):
2236         (WebCore::FrameLoader::didChangeTitle):
2237         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2238         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2239         (WebCore::FrameLoader::post):
2240         (WebCore::FrameLoader::addExtraFieldsToRequest):
2241         (WebCore::FrameLoader::loadResourceSynchronously):
2242         * loader/mac/IconLoaderMac.mm:
2243         (WebCore::IconLoader::notifyIconChanged):
2244         * loader/mac/LoaderFunctionsMac.mm:
2245         * loader/mac/MainResourceLoaderMac.mm:
2246         (WebCore::shouldLoadAsEmptyDocument):
2247         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2248         * loader/mac/NavigationActionMac.mm:
2249         (WebCore::navigationType):
2250         (WebCore::NavigationAction::NavigationAction):
2251         * loader/mac/ResourceLoaderMac.mm:
2252         * loader/mac/SubresourceLoaderMac.mm:
2253         * page/Frame.cpp:
2254         (WebCore::Frame::Frame):
2255         (WebCore::Frame::urlSelected):
2256         (WebCore::Frame::submitFormAgain):
2257         (WebCore::Frame::submitForm):
2258         (WebCore::Frame::endIfNotLoading):
2259         (WebCore::Frame::hitTestResultAtPoint):
2260         * page/Frame.h:
2261         * page/FramePrivate.h:
2262         * platform/gdk/FrameGdk.cpp:
2263         (WebCore::FrameGdk::FrameGdk):
2264         (WebCore::FrameGdk::submitForm):
2265         (WebCore::FrameGdk::urlSelected):
2266         * platform/gdk/FrameGdk.h:
2267         * platform/mac/TextFieldMac.mm:
2268         * platform/network/HTTPHeaderMap.h:
2269         * platform/network/ResourceHandle.h:
2270         * platform/network/ResourceHandleClient.h:
2271         * platform/network/ResourceHandleInternal.h:
2272         * platform/network/mac/ResourceHandleMac.mm:
2273         * platform/network/mac/ResourceResponseMac.h:
2274         * platform/network/mac/ResourceResponseMac.mm:
2275         (-[NSURLResponse WebCore]):
2276         * platform/network/win/ResourceHandleWin.cpp:
2277         * platform/qt/FrameQt.cpp:
2278         (WebCore::FrameQt::submitForm):
2279         (WebCore::FrameQt::urlSelected):
2280         * platform/qt/FrameQt.h:
2281         * rendering/RenderLineEdit.cpp:
2282         (WebCore::RenderLineEdit::returnPressed):
2283         * xml/XSLTProcessor.cpp:
2284         (WebCore::docLoaderFunc):
2285         * xml/xmlhttprequest.cpp:
2286
2287 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2288
2289         Reviewed by Adele.
2290
2291         - replaced receivedRedirect with new willSendRequest delegate
2292         - removed most mac-specific loader functions
2293         - use ResourceResponse more in loader code
2294
2295         * WebCore.xcodeproj/project.pbxproj: Add new files.
2296         * bridge/mac/WebCoreFrameBridge.mm:
2297         (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
2298         for CachedResource method renames.
2299         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2300         Ditto.
2301         * loader/CachedCSSStyleSheet.cpp:
2302         (WebCore::CachedCSSStyleSheet::checkNotify): simplified
2303         based on ResourceResponse
2304         * loader/CachedImage.cpp:
2305         (WebCore::CachedImage::createImage): adapt for ResourceResponse
2306         * loader/CachedResource.cpp:
2307         (WebCore::CachedResource::CachedResource): store a ResourceResponse;
2308         platform response is now called platformResponse and expiration date
2309         is removed.
2310         (WebCore::CachedResource::~CachedResource): ditto
2311         (WebCore::CachedResource::isExpired): ditto
2312         * loader/CachedResource.h:
2313         (WebCore::CachedResource::platformResponse): ditto
2314         (WebCore::CachedResource::setResponse): ditto
2315         (WebCore::CachedResource::canDelete): ditto
2316         * loader/LoaderFunctions.h:
2317         * loader/loader.cpp:
2318         (WebCore::Loader::receivedResponse): Adjusted for renames.
2319         (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
2320         in the CachedResource.
2321         * loader/loader.h:
2322         * loader/mac/FormDataStream.h:
2323         * loader/mac/FormDataStream.m:
2324         (WebCore::getStreamFormDatas): Rearranged things so it's
2325         possible to get a FormData back out of a form data stream.
2326         (WebCore::formCreate): ditto
2327         (WebCore::formFinalize): ditto
2328         (WebCore::httpBodyFromStream): ditto
2329         * loader/mac/ImageDocumentMac.mm:
2330         (WebCore::finishImageLoad): s/response/platformResponse/
2331         * loader/mac/LoaderFunctionsMac.mm:
2332         (WebCore::CheckCacheObjectStatus): ditto
2333         (WebCore::CachedResource::setPlatformResponse): ditto
2334         * loader/mac/SubresourceLoaderMac.mm:
2335         (WebCore::SubresourceLoader::willSendRequest): send redirect
2336         to client appropriately
2337         * platform/network/ResourceHandle.h:
2338         * platform/network/ResourceHandleClient.h:
2339         (WebCore::ResourceHandleClient::willSendRequest): new entry
2340         point for SubresourceLoader, dispatch to client.
2341         * platform/network/ResourceRequest.h:
2342         (WebCore::ResourceRequest::allowHTTPCookies): implemented
2343         (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
2344         * platform/network/ResourceResponse.h:
2345         (WebCore::ResourceResponse::ResourceResponse): initialize expiration
2346         date(!)
2347         * platform/network/cf/FormDataStreamCFNet.cpp: Added.
2348         (WebCore::getStreamFormDatas): Added this, ported from NSURL version.
2349         (WebCore::openNextStream): ditto
2350         (WebCore::formCreate): ditto
2351         (WebCore::formFinalize): ditto
2352         (WebCore::formCanRead): ditto
2353         (WebCore::formEventCallback): ditto
2354         (WebCore::setHTTPBody): ditto
2355         (WebCore::httpBodyFromStream): ditto
2356         * platform/network/cf/FormDataStreamCFNet.h: Added.
2357         * platform/network/cf/ResourceHandleCFNet.cpp:
2358         (WebCore::willSendRequest): implemented
2359         (WebCore::ResourceHandle::start): use new ResourceRequest stuff
2360         * platform/network/cf/ResourceResponseCFNet.cpp:
2361         (WebCore::getResourceResponse): do nothing for a null response
2362         * platform/network/mac/ResourceHandleMac.mm:
2363         (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
2364         * platform/network/mac/ResourceRequestMac.h: Added.
2365         * platform/network/mac/ResourceRequestMac.mm: Added.
2366         (WebCore::getResourceRequest): Added way to convert an NSURLRequest
2367         to a ResourceRequest.
2368         (WebCore::nsURLRequest): Opposite of the above.
2369         * platform/network/cf/ResourceRequestCFNet.h: Added.
2370         * platform/network/cf/ResourceRequestCFNet.cpp: Added.
2371         (WebCore::getResourceRequest): Added way to convert an CFURLRequest
2372         to a ResourceRequest.
2373         (WebCore::cfURLRequest): Opposite of the above.
2374         * xml/xmlhttprequest.cpp:
2375         (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
2376         adjusted.
2377         * xml/xmlhttprequest.h:
2378
2379 2006-11-04  Darin Adler  <darin@apple.com>
2380
2381         Change suggested by Mitz.
2382
2383         - fix http://bugs.webkit.org/show_bug.cgi?id=11514
2384           REGRESSION (r17438): Repro crash when opening a web archive
2385
2386         * bridge/mac/WebCorePageState.mm:
2387         (-[WebCorePageState dealloc]): Add null check.
2388         (-[WebCorePageState finalize]): Ditto.
2389
2390 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
2391
2392         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
2393
2394         http://bugs.webkit.org/show_bug.cgi?id=11433
2395         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
2396
2397         * WebCore.vcproj/WebCore/WebCore.vcproj:
2398         Added platform/graphics platform/network and platform/network/win to headers search paths
2399         Created platform/graphics and platform/network filters in hierarchy
2400         Moved GraphicsContext and GraphicsTypes to their respective filters
2401         Added EditorClient.h
2402         Added FrameLoader* files in loader/
2403         Added HitTest* files in rendering/
2404         Added Editor.* files in editing/
2405         Added DeleteButton.* and DeleteButtonController.* in editing/
2406
2407         * bridge/win/ChromeClientWin.h: Added.
2408         (WebCore::ChromeClientWin::~ChromeClientWin):
2409         * bridge/win/EditorClientWin.h: Added.
2410         (WebCore::EditorClientWin::~EditorClientWin):
2411
2412         * bridge/win/FrameWin.cpp:
2413         (WebCore::FrameWin::FrameWin):
2414         (WebCore::FrameWin::urlSelected):
2415         (WebCore::FrameWin::submitForm):
2416         (WebCore::FrameWin::createNewWindow):
2417         * bridge/win/FrameWin.h:
2418         Added EditorClient parameter to constructor
2419         Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
2420         Removed openURL() and openURLRequest from class definition
2421
2422         * bridge/win/PageWin.cpp:
2423         * platform/AffineTransform.h:
2424         * platform/cairo/AffineTransformCairo.cpp: Added.
2425         (WebCore::AffineTransform::AffineTransform):
2426         (WebCore::AffineTransform::setMatrix):
2427         (WebCore::AffineTransform::map):
2428         (WebCore::AffineTransform::mapRect):
2429         (WebCore::AffineTransform::isIdentity):
2430         (WebCore::AffineTransform::m11):
2431         (WebCore::AffineTransform::m12):
2432         (WebCore::AffineTransform::m21):
2433         (WebCore::AffineTransform::m22):
2434         (WebCore::AffineTransform::dx):
2435         (WebCore::AffineTransform::dy):
2436         (WebCore::AffineTransform::reset):
2437         (WebCore::AffineTransform::scale):
2438         (WebCore::AffineTransform::rotate):
2439         (WebCore::AffineTransform::translate):
2440         (WebCore::AffineTransform::shear):
2441         (WebCore::AffineTransform::det):
2442         (WebCore::AffineTransform::invert):
2443         (WebCore::AffineTransform::operator cairo_matrix_t):
2444         (WebCore::AffineTransform::operator== ):
2445         (WebCore::AffineTransform::operator*= ):
2446         (WebCore::AffineTransform::operator* ):
2447         * platform/cairo/GraphicsContextCairo.cpp:
2448         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2449         * platform/network/win/ResourceHandleWin.cpp:
2450         (WebCore::ResourceHandle::onHandleCreated):
2451         (WebCore::ResourceHandle::start):
2452         (WebCore::ResourceHandle::fileLoadTimer):
2453         (WebCore::ResourceHandle::cancel):
2454         * platform/win/TemporaryLinkStubs.cpp:
2455         (WebCore::FrameWin::goBackOrForward):
2456         (WebCore::FrameWin::getHistoryLength):
2457         (WebCore::FrameWin::historyURL):
2458         (WebCore::ServeSynchronousRequest):
2459         (WebCore::ChromeClientWin::canRunModal):
2460         (WebCore::ChromeClientWin::runModal):
2461         (WebCore::EditorClientWin::shouldDeleteRange):
2462         (WebCore::EditorClientWin::shouldShowDeleteInterface):
2463         (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
2464         (WebCore::EditorClientWin::isGrammarCheckingEnabled):
2465         (WebCore::EditorClientWin::spellCheckerDocumentTag):
2466         (WebCore::Path::transform):
2467         (WebCore::PopupMenu::updateFromElement):
2468         (WebCore::ResourceLoader::loadsBlocked):
2469         (WebCore::systemBeep):
2470         * rendering/RenderThemeWin.cpp:
2471         (WebCore::RenderThemeWin::paintButton):
2472         (WebCore::RenderThemeWin::paintTextField):
2473
2474 2006-11-04  Alexey Proskuryakov  <ap@nypop.com>
2475
2476         Reviewed by Maciej.
2477
2478         http://bugs.webkit.org/show_bug.cgi?id=11448
2479         &lang; and &rang; entities are mapped to the incorrect Unicode codepoint
2480
2481         * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
2482
2483 2006-11-03  Mark Rowe  <bdash@webkit.org>
2484
2485         Reviewed by Oliver.
2486
2487         Update Windows and Qt project files for file removals in r17585.
2488
2489         * CMakeLists.txt:
2490         * WebCore.vcproj/WebCore/WebCore.vcproj:
2491
2492 2006-11-03  Zack Rusin  <zack@kde.org>
2493
2494         Reviewed by Maciej.
2495
2496         The patch fixes text field drawing on the Qt platform.
2497
2498         * platform/qt/RenderThemeQt.cpp:
2499         (WebCore::RenderThemeQt::paintTextField): Use the style to correctly
2500         render the text field
2501
2502 2006-11-03  Oliver Hunt  <oliver@apple.com>
2503
2504         Reviewed by Tim.
2505
2506         Correct incorrect call to SetCursor
2507
2508         * rendering/RenderFrameSet.cpp:
2509         (WebCore::RenderFrameSet::userResize):
2510
2511 2006-11-03  Adele Peterson  <adele@apple.com>
2512
2513         Reviewed by Oliver.
2514
2515         Removed DeprecatedRenderSelect and ListBox classes.
2516
2517         * WebCore.xcodeproj/project.pbxproj:
2518         * css/html4.css:
2519         * html/HTMLOptionElement.h:
2520         * html/HTMLSelectElement.cpp:
2521         (WebCore::HTMLSelectElement::recalcStyle):
2522         (WebCore::HTMLSelectElement::isKeyboardFocusable):
2523         (WebCore::HTMLSelectElement::isMouseFocusable):
2524         (WebCore::HTMLSelectElement::createRenderer):
2525         (WebCore::HTMLSelectElement::setRecalcListItems):
2526         (WebCore::HTMLSelectElement::notifyOptionSelected):
2527         (WebCore::HTMLSelectElement::defaultEventHandler):
2528         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
2529         (WebCore::HTMLSelectElement::updateListBoxSelection):
2530         * html/HTMLSelectElement.h:
2531         * platform/ListBox.h: Removed.
2532         * platform/mac/FontCacheMac.mm:
2533         * platform/mac/ListBoxMac.mm: Removed.
2534         * platform/win/TemporaryLinkStubs.cpp:
2535         * rendering/DeprecatedRenderSelect.cpp: Removed.
2536         * rendering/DeprecatedRenderSelect.h: Removed.
2537
2538 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2539
2540         Not reviewed, fix for accidental commit.
2541
2542         - rolled back more of the accidentall commit that I forgot.
2543
2544         * platform/network/mac/ResourceRequestMac.h: Removed.
2545         * platform/network/mac/ResourceRequestMac.mm: Removed.
2546
2547 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2548
2549         Not reviewed, fix for accidental commit.
2550
2551         - roll back some network changes accidentally committed with a previous patch.
2552
2553         * WebCore.xcodeproj/project.pbxproj:
2554         * bridge/mac/WebCoreFrameBridge.mm:
2555         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
2556         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2557         * loader/CachedCSSStyleSheet.cpp:
2558         (WebCore::CachedCSSStyleSheet::checkNotify):
2559         * loader/CachedImage.cpp:
2560         (WebCore::CachedImage::createImage):
2561         * loader/CachedResource.cpp:
2562         (WebCore::CachedResource::CachedResource):
2563         (WebCore::CachedResource::~CachedResource):
2564         (WebCore::CachedResource::setExpireDate):
2565         (WebCore::CachedResource::isExpired):
2566         * loader/CachedResource.h:
2567         (WebCore::CachedResource::response):
2568         * loader/LoaderFunctions.h:
2569         * loader/loader.cpp:
2570         (WebCore::Loader::receivedResponse):
2571         (WebCore::Loader::didReceivedResponse):
2572         * loader/loader.h:
2573         * loader/mac/FormDataStream.h:
2574         * loader/mac/FormDataStream.m:
2575         (WebCore::formCreate):
2576         (WebCore::formFinalize):
2577         * loader/mac/ImageDocumentMac.mm:
2578         (WebCore::finishImageLoad):
2579         * loader/mac/LoaderFunctionsMac.mm:
2580         (WebCore::CheckCacheObjectStatus):
2581         (WebCore::CachedResource::setResponse):
2582         * loader/mac/SubresourceLoaderMac.mm:
2583         (WebCore::SubresourceLoader::willSendRequest):
2584         * platform/network/ResourceHandle.h:
2585         * platform/network/ResourceHandleClient.h:
2586         (WebCore::ResourceHandleClient::receivedRedirect):
2587         * platform/network/ResourceRequest.h:
2588         * platform/network/ResourceResponse.h:
2589         (WebCore::ResourceResponse::ResourceResponse):
2590         * platform/network/mac/ResourceHandleMac.mm:
2591         (WebCore::ResourceHandle::redirectedToURL):
2592         * xml/xmlhttprequest.cpp:
2593         (WebCore::XMLHttpRequest::receivedRedirect):
2594         * xml/xmlhttprequest.h:
2595
2596 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
2597
2598         Rubber-stamped by Oliver.
2599
2600         Remove these, they have been merged with SVGRenderTreeAsText.
2601         
2602         * rendering/SVGRenderAsText.cpp: Removed.
2603         * rendering/SVGRenderAsText.h: Removed.
2604
2605 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
2606
2607         Build fix.
2608         
2609         * platform/network/cf/ResourceHandleCFNet.cpp:
2610         (WebCore::willSendRequest):
2611
2612 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
2613
2614         Reviewed by Darin, Beth.
2615         
2616         First cut at factoring Page's UIDelegate-related functions into Chrome
2617         and ChromeClient.
2618
2619         Layout tests pass.
2620         
2621         * bridge/mac/PageMac.mm: Removed platform-specific constructor, added
2622         setBridge method to replace it.
2623         (WebCore::Page::setBridge):
2624
2625         * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact
2626         that WebCorePageBridge.h doesn't need to be included by ObjC-only files,
2627         and, now that it uses PassRefPtr, can't be.
2628         
2629         * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
2630
2631         * page/Page.h:
2632         (WebCore::Page::dragCaretController): Made this function non-const so that
2633         m_dragCaretController doesn't have to be mutable.
2634
2635 2006-11-03  Alexey Proskuryakov  <ap@nypop.com>
2636
2637         Reviewed by Adele.
2638
2639         http://bugs.webkit.org/show_bug.cgi?id=7323
2640         REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
2641
2642         * bridge/mac/FrameMac.h: Moved drag source information to a static variable
2643         in FrameMac.mm. There can be only one drag active at any moment, and having 
2644         this information here was making sharing this information between 
2645         subframes hard.
2646
2647         * bridge/mac/FrameMac.mm:
2648         (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo.
2649         (WebCore::FrameMac::freeClipboard):
2650         (WebCore::FrameMac::dragHysteresisExceeded):
2651         (WebCore::FrameMac::handleMouseMoveEvent):
2652         (WebCore::FrameMac::handleMouseReleaseEvent):
2653         (WebCore::FrameMac::mouseDown):
2654         (WebCore::FrameMac::dragSourceMovedTo):
2655         (WebCore::FrameMac::dragSourceEndedAt):
2656         (WebCore::FrameMac::dispatchDragSrcEvent):
2657         Access drag source info via sharedDragInfo - this fixes drag source even dispatching.
2658         Also removed some old code that was forwarding mouse events to subviews to make 
2659         HTML editing work in subframes.
2660
2661         * page/FrameView.cpp:
2662         (WebCore::FrameView::updateDragAndDrop):
2663         (WebCore::FrameView::cancelDragAndDrop):
2664         (WebCore::FrameView::performDragAndDrop):
2665         Forward events to subframes for dispatching - this fixes drag target events.
2666
2667 2006-11-03  Zack Rusin  <zack@kde.org>
2668
2669         Reviewed by Tim.
2670
2671         Fixing compile.
2672
2673         * platform/qt/LoaderFunctionsQt.cpp:
2674         (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
2675
2676 2006-11-01  Zack Rusin  <zack@kde.org>
2677
2678         Reviewed by Maciej.
2679
2680         Moving the word/sentence seperators into a file of their own
2681         and implementing findWordBoundary.
2682
2683         * CMakeLists.txt:
2684         * platform/qt/TemporaryLinkStubs.cpp:
2685         * platform/qt/TextBoundaries.cpp: Added.
2686         (WebCore::findNextSentenceFromIndex):
2687         (WebCore::findSentenceBoundary):
2688         (WebCore::findNextWordFromIndex):
2689         (WebCore::findWordBoundary):
2690
2691 2006-11-03  Zack Rusin  <zack@kde.org>
2692
2693         Reviewed by Maciej.
2694
2695         Compile on both KDE and Qt platforms
2696
2697         * CMakeLists.txt: add zlib explicitly
2698         * platform/network/qt/ResourceHandleManager.cpp:
2699         (WebCore::ResourceHandleManager::self):
2700         (WebCore::QtJob::QtJob):
2701         (WebCore::QtJob::timerEvent): Integrate both implementations
2702         so that moc can parse it
2703         (WebCore::ResourceHandleManager::deliverJobData):
2704         (WebCore::ResourceHandleManager::remove):
2705         * platform/network/qt/ResourceHandleManager.h:
2706
2707 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2708
2709         No review, suggested by Mitz.
2710
2711         - fix a #if to be #ifdef
2712
2713         * platform/graphics/svg/cg/SVGResourceImageCg.cpp:
2714
2715 2006-11-03  Zack Rusin  <zack@kde.org>
2716
2717         Reviewed and landed by Maciej.
2718         
2719         Compile on the Qt platform.
2720
2721         * ksvg2/misc/KCanvasRenderingStyle.h:
2722         * platform/qt/RenderThemeQt.cpp:
2723         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
2724
2725 2006-11-03  Zack Rusin  <zack@kde.org>
2726
2727         Reviewed by Hyatt. Landed by Maciej.
2728
2729         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
2730         to graphics context to be able to set consistant state
2731         on the platform specific painter without having to change
2732         fill/stroke/font on every operation. This fixes color/stroke/fill
2733         and font handling in the Qt port.
2734
2735         * platform/graphics/GraphicsContext.cpp:
2736         (WebCore::GraphicsContext::setFont):
2737         (WebCore::GraphicsContext::setPen):
2738         (WebCore::GraphicsContext::setFillColor):
2739         (WebCore::GraphicsContext::setPlatformPen):
2740         (WebCore::GraphicsContext::setPlatformFillColor):
2741         (WebCore::GraphicsContext::setPlatformFont):
2742         * platform/graphics/GraphicsContext.h:
2743         * platform/qt/GraphicsContextQt.cpp:
2744         (WebCore::toQtCompositionMode):
2745         (WebCore::toQtLineCap):
2746         (WebCore::toQtLineJoin):
2747         (WebCore::toQPenStyle):
2748         (WebCore::penToQPen):
2749         (WebCore::TransparencyLayer::TransparencyLayer):
2750         (WebCore::GraphicsContext::addRoundedRectClip):
2751         (WebCore::GraphicsContext::setPlatformFont):
2752         (WebCore::GraphicsContext::setPlatformPen):
2753         (WebCore::GraphicsContext::setPlatformFillColor):
2754         * platform/qt/ScrollViewCanvasQt.cpp:
2755         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
2756         (WebCore::ScrollViewCanvasQt::paintEvent):
2757         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
2758         * platform/qt/ScrollViewCanvasQt.h:
2759
2760 2006-11-02  Adele Peterson  <adele@apple.com>
2761
2762         Reviewed by Anders.
2763
2764         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
2765         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
2766
2767         Test: fast/forms/textarea-no-scroll-on-blur.html
2768
2769         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
2770           On blur, only scroll back to the start for text fields.
2771
2772 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
2773
2774         Another build fix.
2775         
2776         * rendering/RenderFileUploadControl.cpp:
2777         (WebCore::RenderFileUploadControl::paintObject):
2778
2779 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
2780
2781         Build fix.
2782         
2783         * page/FramePrivate.h:
2784         (WebCore::FramePrivate::FramePrivate):
2785
2786 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
2787
2788         Reviewed by Geoff, landed by Anders.
2789         
2790         Fix dependency problems caused when running move-js-headers.sh
2791         
2792         * move-js-headers.sh:
2793         Use cp -p instead of just cp so that the modification time
2794         of the original files are used.
2795
2796 2006-11-02  Adam Roben  <aroben@apple.com>
2797
2798         Reviewed by Tim H, landed by Anders.
2799
2800         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
2801         REGRESSION: Shadow of file upload button is clipped
2802
2803         * rendering/RenderFileUploadControl.cpp:
2804         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
2805         height to keep from clipping in the shadow
2806
2807 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
2808
2809         Reviewed by Maciej, landed by Anders.
2810
2811         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
2812         content and window. ScrollViewQt already receives correct content
2813         coordinates from QScrollArea.
2814         (WebCore::ScrollView::contentsToWindow):
2815         (WebCore::ScrollView::windowToContents):
2816
2817 2006-11-02  Simon Hausmann  <hausmann@kde.org>
2818
2819         Reviewed by Maciej, landed by Anders
2820
2821         * CMakeLists.txt: Make linkage against KDE libraries conditional
2822         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
2823           Qt base resource handler that supports only requests to the
2824           local filesystem. Used when compiling without KDE support.
2825           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
2826           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
2827         (WebCore::QtJob::QtJob):
2828         (WebCore::QtJob::timerEvent):
2829         (WebCore::ResourceHandleManager::ResourceHandleManager):
2830         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2831         (WebCore::ResourceHandleManager::self):
2832         (WebCore::ResourceHandleManager::remove):
2833         (WebCore::ResourceHandleManager::add):
2834         (WebCore::ResourceHandleManager::cancel):
2835         (WebCore::ResourceHandleManager::deliverJobData):
2836         * platform/network/qt/ResourceHandleManager.h:
2837         * platform/qt/FrameQtClient.cpp:
2838         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
2839         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
2840         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
2841         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
2842           input dialog functions when compiling without KDE support
2843         (WebCore::ServeSynchronousRequest):
2844
2845 2006-11-02  David Carson  <dacarson@gmail.com>
2846
2847         Reviewed by Geoff, landed by Anders.
2848
2849         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
2850         Initializing variable in constructor.
2851
2852         * page/FramePrivate.h:
2853         (WebCore::FramePrivate::FramePrivate):
2854
2855 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
2856
2857         Reviewed by Geoff.
2858
2859         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
2860         
2861         * platform/network/cf/ResourceHandleCFNet.cpp:
2862         (WebCore::addHeadersFromHashMap):
2863         Don't set all headers at once since that clears any previous headers set.
2864         
2865         (WebCore::ResourceHandle::start):
2866
2867 2006-11-02  Adele Peterson  <adele@apple.com>
2868
2869         Reviewed by Mitz and Geoff.
2870
2871         - Fix for:
2872         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
2873         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
2874         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
2875
2876         Test: fast/forms/textarea-scrollbar.html
2877
2878         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
2879         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
2880
2881         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
2882         * rendering/RenderTextControl.cpp: 
2883         (WebCore::RenderTextControl::RenderTextControl):
2884         (WebCore::RenderTextControl::setStyle):
2885         (WebCore::RenderTextControl::createDivStyle):
2886         (WebCore::RenderTextControl::updateFromElement):
2887         (WebCore::RenderTextControl::calcHeight):
2888         (WebCore::RenderTextControl::baselinePosition):
2889         (WebCore::RenderTextControl::nodeAtPoint):
2890         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
2891         (WebCore::RenderTextControl::scrollWidth):
2892         (WebCore::RenderTextControl::scrollHeight):
2893         (WebCore::RenderTextControl::scrollLeft):
2894         (WebCore::RenderTextControl::scrollTop):
2895
2896         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
2897
2898 2006-11-02  John Sullivan  <sullivan@apple.com>
2899
2900         Reviewed by Geoff Garen
2901
2902         * editing/Selection.cpp:
2903         (WebCore::Selection::showTreeForThis):
2904         this debugging method now displays start offset and end offset, at Darin's suggestion
2905
2906 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
2907
2908         Reviewed by darin
2909
2910         <rdar://problem/4062865>
2911         Copy/paste of a select element fails to include the options
2912         
2913         * editing/SelectionController.cpp:
2914         (WebCore::SelectionController::modify): Added paragraphBoundary.
2915         * editing/htmlediting.cpp:
2916         (WebCore::canHaveChildrenForEditing): Added checks for input elements
2917         and textareas.  Insertion operations would fail when performed just 
2918         before/after one of these elements b/c the content would be put inside 
2919         the element.
2920         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
2921         editable content, and made the code to stop at an root faster (don't check
2922         isDescendantOf on every iteration).
2923         (WebCore::enclosingNodeOfType): Ditto.
2924         (WebCore::enclosingList): Ditto.
2925         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
2926         inappropriately named.
2927         * editing/markup.cpp:
2928         (WebCore::startMarkup): Use the text node's value instead of its rendered
2929         content for text nodes inside select elements.  One might also turn off
2930         annotation when createMarkup enters a select element, but createMarkup
2931         is iterative, not recursive, so doing so would be complicated.
2932         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
2933         descendants of a select element.
2934         * editing/visible_units.cpp:
2935         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
2936         where various replaced elements can't be copied when they are the only
2937         thing selected.
2938         (WebCore::endOfParagraph): Ditto.
2939
2940 2006-11-01  Oliver Hunt  <oliver@apple.com>
2941
2942         Reviewed by Adam.
2943
2944         Converting more or kcanvas/quartz from Obj-C to C++
2945         Minor SVG updates
2946         compatibility fixes
2947
2948         * WebCore.xcodeproj/project.pbxproj:
2949         * kcanvas/device/KRenderingPaintServer.h:
2950         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
2951         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
2952         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
2953         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
2954         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
2955         * kcanvas/device/quartz/QuartzSupport.h:
2956         * ksvg2/css/SVGCSSStyleSelector.cpp:
2957         * ksvg2/misc/KCanvasRenderingStyle.h:
2958         * ksvg2/scripts/cssmakeprops:
2959         * ksvg2/scripts/cssmakevalues:
2960         * ksvg2/scripts/make_names.pl:
2961         * ksvg2/svg/SVGAnimateColorElement.cpp:
2962         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2963         * ksvg2/svg/SVGAnimationElement.cpp:
2964         * ksvg2/svg/SVGMaskElement.cpp:
2965         * ksvg2/svg/SVGPatternElement.cpp:
2966         * ksvg2/svg/svgpathparser.cpp:
2967         * platform/Path.cpp:
2968         * platform/graphics/svg/SVGResourceImage.h:
2969         * rendering/RenderPath.cpp:
2970         * rendering/SVGRenderAsText.cpp:
2971
2972 2006-11-02  Mitz Pettel  <mitz@webkit.org>
2973
2974         Reviewed by Adele.
2975
2976         - Fix a regression from r17521: painting of and crash caused by tables
2977           with collapsed borders
2978
2979         * rendering/RenderTable.cpp:
2980         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
2981         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
2982         and 'paintInfo' is the parameter, which we were accidently modifying.
2983
2984 2006-11-01  Adele Peterson  <adele@apple.com>
2985
2986         Reviewed by Mitz.
2987
2988         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
2989         REGRESSION: Incomplete repaint of overflow areas when deleting
2990
2991         Restrict the repaint rect for overflow blocks after the height has been fully computed.
2992         Also, adjust the repaint rect coordinates for the scroll offset.
2993
2994         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
2995         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
2996
2997 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
2998
2999         Reviewed by Mitz.
3000
3001         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
3002         Rename the "p" member variable of the PaintInfo struct to "context"
3003
3004         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
3005           'context' and 'rect' respectively.
3006
3007         - Assorted surrounding cleanups.
3008
3009         * rendering/EllipsisBox.cpp:
3010         (WebCore::EllipsisBox::paint):
3011         * rendering/EllipsisBox.h:
3012         * rendering/InlineBox.cpp:
3013         (WebCore::InlineBox::paint):
3014         * rendering/InlineFlowBox.cpp:
3015         (WebCore::InlineFlowBox::paint):
3016         (WebCore::InlineFlowBox::paintBackground):
3017         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
3018         (WebCore::InlineFlowBox::paintDecorations):
3019         * rendering/InlineFlowBox.h:
3020         * rendering/InlineRunBox.h:
3021         * rendering/InlineTextBox.cpp:
3022         (WebCore::InlineTextBox::paint):
3023         * rendering/InlineTextBox.h:
3024         * rendering/RenderBlock.cpp:
3025         (WebCore::RenderBlock::paint):
3026         (WebCore::RenderBlock::paintChildren):
3027         (WebCore::RenderBlock::paintCaret):
3028         (WebCore::RenderBlock::paintObject):
3029         (WebCore::RenderBlock::paintFloats):
3030         (WebCore::RenderBlock::paintEllipsisBoxes):
3031         (WebCore::RenderBlock::paintSelection):
3032         (WebCore::RenderBlock::fillSelectionGaps):
3033         (WebCore::RenderBlock::fillInlineSelectionGaps):
3034         (WebCore::RenderBlock::fillBlockSelectionGaps):
3035         (WebCore::RenderBlock::fillHorizontalSelectionGap):
3036         (WebCore::RenderBlock::fillVerticalSelectionGap):
3037         (WebCore::RenderBlock::fillLeftSelectionGap):
3038         (WebCore::RenderBlock::fillRightSelectionGap):
3039         * rendering/RenderBox.cpp:
3040         (WebCore::RenderBox::paint):
3041         (WebCore::RenderBox::paintRootBoxDecorations):
3042         (WebCore::RenderBox::paintBoxDecorations):
3043         * rendering/RenderBox.h:
3044         * rendering/RenderButton.cpp:
3045         (WebCore::RenderButton::paintObject):
3046         * rendering/RenderFieldset.cpp:
3047         (WebCore::RenderFieldset::paintBoxDecorations):
3048         * rendering/RenderFileUploadControl.cpp:
3049         (WebCore::RenderFileUploadControl::paintObject):
3050         * rendering/RenderFlow.cpp:
3051         (WebCore::RenderFlow::continuationBefore):
3052         (WebCore::RenderFlow::addChildWithContinuation):
3053         (WebCore::RenderFlow::addChild):
3054         (WebCore::RenderFlow::attachLineBox):
3055         (WebCore::RenderFlow::destroy):
3056         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
3057         (WebCore::RenderFlow::dirtyLineBoxes):
3058         (WebCore::RenderFlow::createInlineBox):
3059         (WebCore::RenderFlow::paintLines):
3060         (WebCore::RenderFlow::getAbsoluteRepaintRect):
3061         (WebCore::RenderFlow::lowestPosition):
3062         (WebCore::RenderFlow::rightmostPosition):
3063         (WebCore::RenderFlow::leftmostPosition):
3064         (WebCore::RenderFlow::caretRect):
3065         (WebCore::RenderFlow::addFocusRingRects):
3066         (WebCore::RenderFlow::paintOutline):
3067         (WebCore::RenderFlow::paintOutlineForLine):
3068         * rendering/RenderForeignObject.cpp:
3069         (WebCore::RenderForeignObject::paint):
3070         * rendering/RenderHTMLCanvas.cpp:
3071         (WebCore::RenderHTMLCanvas::paint):
3072         * rendering/RenderImage.cpp:
3073         (WebCore::RenderImage::paint):
3074         * rendering/RenderLayer.cpp:
3075         (WebCore::RenderLayer::paintLayer):
3076         * rendering/RenderListBox.cpp:
3077         (WebCore::RenderListBox::paintObject):
3078         (WebCore::RenderListBox::paintScrollbar):
3079         (WebCore::RenderListBox::paintItemForeground):
3080         (WebCore::RenderListBox::paintItemBackground):
3081         * rendering/RenderListMarker.cpp:
3082         (WebCore::RenderListMarker::paint):
3083         * rendering/RenderMenuList.cpp:
3084         (WebCore::RenderMenuList::paintObject):
3085         * rendering/RenderObject.cpp:
3086         (WebCore::RenderObject::paint):
3087         * rendering/RenderObject.h:
3088         (WebCore::RenderObject::PaintInfo::PaintInfo):
3089         (WebCore::RenderObject::paintBoxDecorations):
3090         (WebCore::RenderObject::paintingRootForChildren):
3091         (WebCore::RenderObject::shouldPaintWithinRoot):
3092         (WebCore::RenderObject::printBoxDecorations):
3093         * rendering/RenderPath.cpp:
3094         (WebCore::RenderPath::paint):
3095         * rendering/RenderReplaced.cpp:
3096         (WebCore::RenderReplaced::shouldPaint):
3097         * rendering/RenderSVGContainer.cpp:
3098         (WebCore::RenderSVGContainer::paint):
3099         * rendering/RenderSVGContainer.h:
3100         * rendering/RenderSVGImage.cpp:
3101         (WebCore::RenderSVGImage::paint):
3102         * rendering/RenderSVGText.cpp:
3103         (WebCore::RenderSVGText::paint):
3104         * rendering/RenderSVGText.h:
3105         (WebCore::RenderSVGText::renderName):
3106         * rendering/RenderTable.cpp:
3107         (WebCore::RenderTable::paint):
3108         (WebCore::RenderTable::paintBoxDecorations):
3109         * rendering/RenderTable.h:
3110         * rendering/RenderTableCell.cpp:
3111         (WebCore::RenderTableCell::paint):
3112         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
3113         (WebCore::RenderTableCell::paintBoxDecorations):
3114         * rendering/RenderTableCell.h:
3115         * rendering/RenderTableRow.cpp:
3116         (WebCore::RenderTableRow::paint):
3117         * rendering/RenderTableRow.h:
3118         * rendering/RenderTableSection.cpp:
3119         (WebCore::RenderTableSection::paint):
3120         * rendering/RenderTableSection.h:
3121         (WebCore::RenderTableSection::getBaseline):
3122         (WebCore::RenderTableSection::setNeedCellRecalc):
3123         * rendering/RenderText.h:
3124         (WebCore::RenderText::renderName):
3125         (WebCore::RenderText::paint):
3126         (WebCore::RenderText::element):
3127         * rendering/RenderTheme.cpp:
3128         (WebCore::RenderTheme::paint):
3129         (WebCore::RenderTheme::paintBorderOnly):
3130         (WebCore::RenderTheme::paintDecorations):
3131         * rendering/RenderTheme.h:
3132         (WebCore::RenderTheme::RenderTheme):
3133         (WebCore::RenderTheme::~RenderTheme):
3134         (WebCore::RenderTheme::controlSupportsTints):
3135         (WebCore::RenderTheme::adjustRepaintRect):
3136         (WebCore::RenderTheme::themeChanged):
3137         (WebCore::RenderTheme::supportsHover):
3138         (WebCore::RenderTheme::paintCheckbox):
3139         (WebCore::RenderTheme::setCheckboxSize):
3140         (WebCore::RenderTheme::paintRadio):
3141         (WebCore::RenderTheme::setRadioSize):
3142         (WebCore::RenderTheme::paintButton):
3143         (WebCore::RenderTheme::setButtonSize):
3144         (WebCore::RenderTheme::paintTextField):
3145         (WebCore::RenderTheme::paintTextArea):
3146         (WebCore::RenderTheme::paintMenuList):
3147         (WebCore::RenderTheme::paintMenuListButton):
3148         * rendering/RenderThemeMac.mm:
3149         (WebCore::RenderThemeMac::paintCheckbox):
3150         (WebCore::RenderThemeMac::paintRadio):
3151         (WebCore::RenderThemeMac::paintButton):
3152         (WebCore::RenderThemeMac::paintTextField):
3153         (WebCore::RenderThemeMac::paintTextArea):
3154         (WebCore::RenderThemeMac::paintMenuList):
3155         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
3156         (WebCore::RenderThemeMac::paintMenuListButton):
3157         * rendering/RenderView.cpp:
3158         (WebCore::RenderView::paint):
3159         (WebCore::RenderView::paintBoxDecorations):
3160         * rendering/RenderView.h:
3161         * rendering/RenderWidget.cpp:
3162         (WebCore::RenderWidget::paint):
3163         * rendering/RenderWidget.h:
3164         (WebCore::RenderWidget::isWidget):
3165         * rendering/RootInlineBox.cpp:
3166         (WebCore::RootInlineBox::paintEllipsisBox):
3167         (WebCore::RootInlineBox::paintCustomHighlight):
3168         (WebCore::RootInlineBox::paint):
3169         (WebCore::RootInlineBox::fillLineSelectionGap):
3170         * rendering/RootInlineBox.h:
3171         * rendering/SVGInlineFlowBox.cpp:
3172         (WebCore::paintSVGInlineFlow):
3173
3174 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
3175
3176         Reviewed by Oliver, Brady.
3177
3178         * platform/network/ResourceResponse.h:
3179         (WebCore::ResourceResponse::setLastModifiedDate):
3180         (WebCore::ResourceResponse::lastModifiedDate):
3181         Add getters and setters for last modified dadte.
3182         
3183         * platform/network/cf/ResourceResponseCFNet.cpp:
3184         (WebCore::getResourceResponse):
3185         Fetch the last modified date. Add correct offset to expired date.
3186
3187 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
3188
3189         Reviewed by Mitz.
3190
3191         Added missing "break;" statement in switch statement from r17493.
3192
3193         Bug 11442: [CSS 3] support for cursor: all-scroll
3194         http://bugs.webkit.org/show_bug.cgi?id=11442
3195
3196         * css/CSSComputedStyleDeclaration.cpp:
3197         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3198
3199 2006-10-31  Mitz Pettel  <mitz@webkit.org>
3200
3201         Reviewed by Maciej.
3202
3203         - fix image dragging
3204
3205         This is covered by editing/selection/drag-to-contenteditable-iframe.html
3206
3207         * rendering/HitTestResult.cpp:
3208         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
3209         HTML IMG elements.
3210         (WebCore::HitTestResult::absoluteImageURL): Ditto.
3211
3212 2006-10-31  Beth Dakin  <bdakin@apple.com>
3213
3214         Reviewed by Maciej.
3215
3216         This adds the back-end of the remaining WebElementDictionary 
3217         functions into HitTestResult.
3218
3219         * WebCore.exp:
3220         * rendering/HitTestResult.cpp:
3221         (WebCore::HitTestResult::title):
3222         (WebCore::displayString): This is nearly identical to the 
3223         displayString() defined in DOMInternal.mm except that it returns a 
3224         String instead of an NSString. The old code path used the 
3225         DOMInternal method, so I made a new one here for the new code path.
3226         (WebCore::HitTestResult::altDisplayString):
3227         (WebCore::HitTestResult::image):
3228         (WebCore::HitTestResult::absoluteImageURL):
3229         (WebCore::HitTestResult::absoluteLinkURL):
3230         (WebCore::HitTestResult::titleDisplayString):
3231         (WebCore::HitTestResult::textContent):
3232         * rendering/HitTestResult.h:
3233
3234 2006-10-31  John Sullivan  <sullivan@apple.com>
3235
3236         * bridge/mac/FrameMac.mm:
3237         (WebCore::FrameMac::markMisspellings):
3238         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
3239
3240 2006-10-31  John Sullivan  <sullivan@apple.com>
3241
3242         Reviewed by Maciej
3243         
3244         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
3245         
3246         The foundation of this was in my last checkin. This checkin is all about displaying
3247         the correct string in the toolTip.
3248
3249         * dom/DocumentMarker.h:
3250         New description field in this struct.
3251
3252         * bridge/mac/FrameMac.mm:
3253         (WebCore::FrameMac::advanceToNextMisspelling):
3254         When adding a grammar marker, supply the appropriate description. Also, added a comment
3255         about the remaining work to make grammar checking return sensible answers.
3256         (WebCore::FrameMac::markMisspellings):
3257         ditto (yes, still needs some refactoring to minimize duplicated code)
3258         
3259         * dom/Document.h:
3260         * dom/Document.cpp:
3261         (WebCore::Document::addMarker):
3262         Now takes an optional description string
3263         (WebCore::Document::markerContainingPoint):
3264         New function, returns a pointer to the (first) marker of the specified type whose rect 
3265         contains the specified point, or 0 if none.
3266         
3267         * rendering/HitTestResult.cpp:
3268         (WebCore::HitTestResult::spellingToolTip):
3269         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
3270         and gets the description from the marker.
3271
3272 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
3273
3274         Reviewed by Maciej.
3275         
3276         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
3277
3278         * loader/mac/FrameLoaderMac.mm:
3279         (WebCore::FrameLoader::createWindow):
3280         * manual-tests/window-open-features-parsing.html: Updated for clarity.
3281
3282 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
3283
3284         Reviewed by Alice.
3285
3286         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
3287         to WebCore::Editor.
3288         
3289         Layout tests pass.
3290         
3291         Renamed "may*" to "can*" because "can" is more accurate (these functions
3292         aren't just about permission) and it matches WebKit.
3293
3294         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
3295         password field. Now that WebCore fully implements canCopy(), it doesn't just
3296         mean "the selection is not in a password field" anymore.
3297         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
3298         The fact that it's not called anymore may represent a security issue, but I
3299         don't see how commented-out code will help reveal the issue, and the
3300         bridge is going away, anyway.
3301         * editing/SelectionController.h: Changed selection() calls to references
3302         to m_sel, to match the rest of the file.
3303
3304 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
3305
3306         Reviewed by harrison
3307         
3308         <rdar://problem/4711063>
3309         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
3310
3311         * editing/ReplaceSelectionCommand.cpp:
3312         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
3313         insertion and plain text string creation unless we need the string
3314         for a BeforeTextInserted event handler or for a plain text only region.
3315         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
3316         code here from ReplacementFragment's constructor.
3317         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
3318         FIXME.
3319         * editing/ReplaceSelectionCommand.h:
3320
3321 2006-10-31  Ada Chan  <adachan@apple.com>
3322
3323         Reviewed by Adam
3324
3325         Correct forward declarations of the HitTestRequest struct.
3326
3327         * rendering/EllipsisBox.h:
3328         * rendering/InlineBox.h:
3329         * rendering/InlineFlowBox.h:
3330         * rendering/RenderLayer.h:
3331         * rendering/RenderObject.h:
3332
3333 2006-10-31  John Sullivan  <sullivan@apple.com>
3334
3335         Reviewed by Beth and Adam
3336
3337         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
3338         next I'll make it use a string that's relevant for a specific grammar error.
3339
3340         * WebCore.exp:
3341         export symbol for spellingToolTip function
3342         
3343         * rendering/HitTestResult.h:
3344         * rendering/HitTestResult.cpp:
3345         (WebCore::HitTestResult::spellingToolTip):
3346         new function, returns the string to be used in a tool tip that describes the questionable grammar
3347         
3348         * rendering/InlineTextBox.h:
3349         * rendering/InlineTextBox.cpp:
3350         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
3351         now takes a style and font, needed to compute the rect representing the range containing
3352         questionable grammar. Computes the rect and associates it with the marker.
3353         (WebCore::InlineTextBox::paintDocumentMarkers):
3354         Pass in the style and font now needed by paintSpellingOrGrammarMarker
3355
3356 2006-10-31  Adele Peterson  <adele@apple.com>
3357
3358         Removed commented out variable from last checkin.
3359
3360         * html/HTMLSelectElement.cpp:
3361         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
3362
3363 2006-10-31  Brady Eidson  <beidson@apple.com>
3364
3365         Build fix (unused variable in release builds)
3366
3367         * html/HTMLSelectElement.cpp:
3368         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
3369
3370 2006-10-31  Adele Peterson  <adele@apple.com>
3371
3372         Reviewed by Adam.
3373
3374         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
3375         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
3376         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
3377
3378         Tests: 
3379         * LayoutTests/fast/forms/listbox-selection.html
3380         * LayoutTests/fast/forms/listbox-onchange.html
3381
3382         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
3383           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
3384           And one for onChange, that is updated after onChange is fired.
3385           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
3386  
3387         * html/HTMLSelectElement.cpp:
3388         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
3389         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
3390         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
3391         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
3392         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
3393         (WebCore::HTMLSelectElement::setExtent): Added.
3394         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
3395         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
3396
3397         * rendering/RenderListBox.cpp:
3398         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
3399         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
3400         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
3401         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
3402          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
3403          notify the select element from here.
3404         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
3405         (WebCore::RenderListBox::listIndexIsVisible): Added.
3406         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
3407
3408         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
3409         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
3410         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
3411         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
3412         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
3413
3414 2006-10-31  Beth Dakin  <bdakin@apple.com>
3415
3416         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
3417
3418         * rendering/HitTestRequest.h: Added.
3419         (WebCore::HitTestRequest::HitTestRequest):
3420
3421 2006-10-31  Beth Dakin  <bdakin@apple.com>
3422
3423         Reviewed by Maciej.
3424
3425         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
3426         should be split into HitTestRequest and HitTestResult
3427
3428         This patch creates a new struct called HitTestRequest that holds 
3429         the three boolean values (readonly, active, and mouseMove) that 
3430         were formerly a part of HitTestResult. All hitTest() and 
3431         nodeAtPoint() functions now take a HitTestRequest in addition to 
3432         the HitTestResult.
3433
3434         * WebCore.exp:
3435         * WebCore.xcodeproj/project.pbxproj:
3436         * bridge/mac/FrameMac.mm:
3437         (WebCore::FrameMac::eventMayStartDrag):
3438         (WebCore::FrameMac::handleMouseMoveEvent):
3439         * bridge/mac/WebCoreAXObject.mm:
3440         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
3441         (-[WebCoreAXObject accessibilityHitTest:]):
3442         * dom/Document.cpp:
3443         (WebCore::Document::elementFromPoint):
3444         (WebCore::Document::prepareMouseEvent):
3445         * editing/SelectionController.cpp:
3446         (WebCore::SelectionController::contains):
3447         * page/Frame.cpp:
3448         (WebCore::Frame::hitTestResultAtPoint):
3449         * page/FrameView.cpp:
3450         (WebCore::FrameView::handleWheelEvent):
3451         * rendering/EllipsisBox.cpp:
3452         (WebCore::EllipsisBox::nodeAtPoint):
3453         * rendering/EllipsisBox.h:
3454         * rendering/HitTestResult.cpp:
3455         (WebCore::HitTestResult::HitTestResult):
3456         (WebCore::HitTestResult::operator=):
3457         * rendering/HitTestResult.h:
3458         * rendering/InlineBox.cpp:
3459         (WebCore::InlineBox::nodeAtPoint):
3460         * rendering/InlineBox.h:
3461         * rendering/InlineFlowBox.cpp:
3462         (WebCore::InlineFlowBox::nodeAtPoint):
3463         * rendering/InlineFlowBox.h:
3464         * rendering/InlineTextBox.cpp:
3465         (WebCore::InlineTextBox::nodeAtPoint):
3466         * rendering/InlineTextBox.h:
3467         * rendering/RenderBlock.cpp:
3468         (WebCore::RenderBlock::nodeAtPoint):
3469         * rendering/RenderBlock.h:
3470         * rendering/RenderBox.cpp:
3471         (WebCore::RenderBox::nodeAtPoint):
3472         * rendering/RenderBox.h:
3473         * rendering/RenderFlow.cpp:
3474         (WebCore::RenderFlow::hitTestLines):
3475         * rendering/RenderFlow.h:
3476         * rendering/RenderForeignObject.cpp:
3477         (WebCore::RenderForeignObject::nodeAtPoint):
3478         * rendering/RenderForeignObject.h:
3479         * rendering/RenderFrameSet.cpp:
3480         (WebCore::RenderFrameSet::nodeAtPoint):
3481         * rendering/RenderFrameSet.h:
3482         * rendering/RenderImage.cpp:
3483         (WebCore::RenderImage::nodeAtPoint):
3484         * rendering/RenderImage.h:
3485         * rendering/RenderInline.cpp:
3486         (WebCore::RenderInline::nodeAtPoint):
3487         * rendering/RenderInline.h:
3488         * rendering/RenderLayer.cpp:
3489         (WebCore::RenderLayer::autoscroll):
3490         (WebCore::RenderLayer::hitTest):
3491         (WebCore::RenderLayer::hitTestLayer):
3492         (WebCore::RenderLayer::updateHoverActiveState):
3493         * rendering/RenderLayer.h:
3494         * rendering/RenderObject.cpp:
3495         (WebCore::RenderObject::hitTest):
3496         (WebCore::RenderObject::nodeAtPoint):
3497         * rendering/RenderObject.h:
3498         * rendering/RenderPath.cpp:
3499         (WebCore::RenderPath::nodeAtPoint):
3500         * rendering/RenderPath.h:
3501         * rendering/RenderSVGImage.cpp:
3502         (WebCore::RenderSVGImage::nodeAtPoint):
3503         * rendering/RenderSVGImage.h:
3504         * rendering/RenderSVGText.cpp:
3505         (WebCore::RenderSVGText::nodeAtPoint):
3506         * rendering/RenderSVGText.h:
3507         * rendering/RenderTableRow.cpp:
3508         (WebCore::RenderTableRow::nodeAtPoint):
3509         * rendering/RenderTableRow.h:
3510         * rendering/RenderTableSection.cpp:
3511         (WebCore::RenderTableSection::nodeAtPoint):
3512         * rendering/RenderTableSection.h:
3513         * rendering/RenderText.h:
3514         (WebCore::RenderText::nodeAtPoint):
3515         * rendering/RenderTextControl.cpp:
3516         (WebCore::RenderTextControl::nodeAtPoint):
3517         * rendering/RenderTextControl.h:
3518         * rendering/RootInlineBox.cpp:
3519         (WebCore::RootInlineBox::nodeAtPoint):
3520         * rendering/RootInlineBox.h:
3521
3522 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
3523
3524         Reviewed by Maciej.
3525
3526         Bug 11442: [CSS 3] support for cursor: all-scroll
3527         http://bugs.webkit.org/show_bug.cgi?id=11442
3528
3529         * css/CSSComputedStyleDeclaration.cpp:
3530         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3531         * css/CSSValueKeywords.in:
3532         * css/cssparser.cpp:
3533         (WebCore::CSSParser::parseValue):
3534         * page/FrameView.cpp:
3535         (WebCore::selectCursor):
3536         * rendering/RenderStyle.h:
3537
3538 2006-10-31  Oliver Hunt  <oliver@apple.com>
3539
3540         Reviewed by Geoff.
3541
3542         Converting Obj-C++ to C++ in kcanvas
3543
3544         * WebCore.xcodeproj/project.pbxproj:
3545         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
3546         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3547         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
3548         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
3549         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.