WebCore/ChangeLog

   1 2009-11-19  Avi Drissman  <avi@chromium.org>
   2
   3         Reviewed by Darin Adler.
   4
   5         Quick style fix.
   6         https://bugs.webkit.org/show_bug.cgi?id=27777
   7
   8         * platform/graphics/cg/PDFDocumentImage.cpp:
   9
  10 2009-11-19  Beth Dakin  <bdakin@apple.com>
  11
  12        Build fix. No review needed.
  13
  14         * platform/chromium/ScrollbarThemeChromium.cpp:
  15         (WebCore::ScrollbarThemeChromium::paintTickmarks):
  16         * rendering/RenderMediaControlsChromium.cpp:
  17         (WebCore::paintMediaButton):
  18
  19 2009-11-19  Beth Dakin  <bdakin@apple.com>
  20
  21        Build fix. No review needed.
  22
  23         * rendering/RenderThemeChromiumSkia.cpp:
  24         (WebCore::RenderThemeChromiumSkia::paintCheckbox):
  25         (WebCore::RenderThemeChromiumSkia::paintRadio):
  26         (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
  27         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
  28         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
  29
  30 2009-11-19  Beth Dakin  <bdakin@apple.com>
  31
  32        Build fix. No review needed.
  33
  34         * platform/graphics/qt/StillImageQt.cpp:
  35         (WebCore::StillImage::draw):
  36         * platform/graphics/qt/StillImageQt.h:
  37
  38 2009-11-19  Beth Dakin  <bdakin@apple.com>
  39
  40        Build fix. No review needed.
  41
  42         * rendering/RenderThemeWin.cpp:
  43         (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
  44         (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
  45         (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
  46
  47 2009-11-19  Beth Dakin  <bdakin@apple.com>
  48
  49        Build fix. No review needed.
  50
  51         * plugins/PluginView.cpp:
  52         (WebCore::PluginView::paintMissingPluginIcon):
  53
  54 2009-11-19  Beth Dakin  <bdakin@apple.com>
  55
  56         Build fix. No review needed.
  57
  58         * platform/graphics/win/ImageCGWin.cpp:
  59         (WebCore::BitmapImage::getHBITMAPOfSize):
  60         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
  61
  62 2009-11-19  Beth Dakin  <bdakin@apple.com>
  63
  64         Reviewed by Darin Adler.
  65
  66         Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
  67         color-correction work with untagged images
  68
  69         Image's draw(), drawPattern(), and fillWithSolidColor() functions
  70         now take a ColorSpace. A bunch of classes inherit from Image, so
  71         draw() and drawPattern() functions there must also take a
  72         ColorSpace.
  73         * platform/graphics/Image.cpp:
  74         (WebCore::Image::fillWithSolidColor):
  75         (WebCore::Image::drawTiled):
  76         * platform/graphics/Image.h:
  77         * platform/graphics/BitmapImage.h:
  78         * platform/graphics/GeneratedImage.cpp:
  79         (WebCore::GeneratedImage::draw):
  80         (WebCore::GeneratedImage::drawPattern):
  81         * platform/graphics/GeneratedImage.h:
  82         * platform/graphics/cg/PDFDocumentImage.cpp:
  83         (WebCore::PDFDocumentImage::draw):
  84         * platform/graphics/cg/PDFDocumentImage.h:
  85         * svg/graphics/SVGImage.cpp:
  86         (WebCore::SVGImage::draw):
  87         * svg/graphics/SVGImage.h:
  88
  89         All of the drawImage() functions and drawTiled() functions of
  90         GraphicsContext now take a ColorSpace.
  91         * platform/graphics/GraphicsContext.cpp:
  92         (WebCore::GraphicsContext::drawImage):
  93         (WebCore::GraphicsContext::drawTiledImage):
  94         * platform/graphics/GraphicsContext.h:
  95
  96         This is where the actual work is done.
  97         * platform/graphics/cg/ImageCG.cpp:
  98         (WebCore::imageWithColorSpace): New static function that returns a
  99         copy of the given image in the given ColorSpace *IF* we should use
 100         the given ColorSpace. We will ignore the color space if the image
 101         is tagged and return 0.
 102         (WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to
 103         call imageWithColorSpace().
 104         (WebCore::Image::drawPattern): Same.
 105
 106         Attempt to keep all ports building.
 107         * platform/graphics/cairo/ImageCairo.cpp:
 108         (WebCore::BitmapImage::draw):
 109         (WebCore::Image::drawPattern):
 110         * platform/graphics/haiku/ImageHaiku.cpp:
 111         (WebCore::BitmapImage::draw):
 112         (WebCore::Image::drawPattern):
 113         * platform/graphics/qt/ImageQt.cpp:
 114         (WebCore::Image::drawPattern):
 115         (WebCore::BitmapImage::draw):
 116         * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
 117         * platform/graphics/skia/ImageSkia.cpp:
 118         (WebCore::Image::drawPattern):
 119         (WebCore::BitmapImage::draw):
 120         (WebCore::BitmapImageSingleFrameSkia::draw):
 121         * platform/graphics/wx/ImageWx.cpp:
 122         (WebCore::BitmapImage::draw):
 123         (WebCore::BitmapImage::drawPattern):
 124
 125         Callers of GraphicsContext's drawImage() and drawTiled() functions
 126         now need to send a ColorSpace.
 127         * html/HTMLCanvasElement.cpp:
 128         (WebCore::HTMLCanvasElement::paint):
 129         * html/canvas/CanvasRenderingContext2D.cpp:
 130         (WebCore::CanvasRenderingContext2D::drawImage):
 131         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
 132         * platform/ScrollView.cpp:
 133         (WebCore::ScrollView::wheelEvent):
 134         * platform/graphics/filters/FEColorMatrix.cpp:
 135         (WebCore::FEColorMatrix::apply):
 136         * platform/graphics/filters/FEComposite.cpp:
 137         (WebCore::FEComposite::apply):
 138         * platform/graphics/filters/SourceGraphic.cpp:
 139         (WebCore::SourceGraphic::apply):
 140         * platform/mac/ScrollbarThemeMac.mm:
 141         (WebCore::ScrollbarThemeMac::paint):
 142         * rendering/RenderBoxModelObject.cpp:
 143         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
 144         (WebCore::RenderBoxModelObject::paintNinePieceImage):
 145         * rendering/RenderImage.cpp:
 146         (WebCore::RenderImage::paintReplaced):
 147         * rendering/RenderLayer.cpp:
 148         (WebCore::RenderLayer::paintResizer):
 149         * rendering/RenderListMarker.cpp:
 150         (WebCore::RenderListMarker::paint):
 151         * rendering/RenderSVGImage.cpp:
 152         (WebCore::RenderSVGImage::paint):
 153         * rendering/RenderWidget.cpp:
 154         (WebCore::RenderWidget::paint):
 155         * svg/graphics/SVGPaintServerPattern.cpp:
 156         (WebCore::SVGPaintServerPattern::setup):
 157         * svg/graphics/SVGResourceFilter.cpp:
 158         (WebCore::SVGResourceFilter::applyFilter):
 159         * svg/graphics/filters/SVGFEMerge.cpp:
 160         (WebCore::FEMerge::apply):
 161         * svg/graphics/filters/SVGFEOffset.cpp:
 162         (WebCore::FEOffset::apply):
 163         * svg/graphics/filters/SVGFETile.cpp:
 164         (WebCore::FETile::apply):
 165
 166 2009-11-19  Avi Drissman  <avi@chromium.org>
 167
 168         Reviewed by Darin Adler.
 169
 170         Properly create a CGImageRef on non-PLATFORM(MAC).
 171         https://bugs.webkit.org/show_bug.cgi?id=27777
 172
 173         * platform/graphics/cg/ImageSourceCG.cpp:
 174         (WebCore::sharedBufferGetBytesAtPosition):
 175         (WebCore::sharedBufferRelease):
 176         (WebCore::ImageSource::setData):
 177         * platform/graphics/cg/ImageSourceCG.h:
 178         * platform/graphics/cg/PDFDocumentImage.cpp:
 179         (WebCore::PDFDocumentImage::dataChanged):
 180
 181 2009-11-19  Oliver Hunt  <oliver@apple.com>
 182
 183         Reviewed by Dave Hyatt.
 184
 185         -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
 186         https://bugs.webkit.org/show_bug.cgi?id=31656
 187
 188         Make sure we're a child of the painting root before drawing overflow features.
 189
 190         * manual-tests/user-drag-with-decorations.html: Added.
 191         * rendering/RenderBlock.cpp:
 192         (WebCore::RenderBlock::paint):
 193
 194 2009-11-19  Dmitry Titov  <dimich@chromium.org>
 195
 196         Not reviewed, attempt to fix Chromium build.
 197
 198         * rendering/RenderMediaControlsChromium.cpp:
 199         (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.
 200
 201 2009-11-19  Rahul Kuchhal  <kuchhal@chromium.org>
 202
 203         Reviewed by Darin Adler.
 204
 205         Do not assert when a high number is used for roman numerals in lists.
 206         https://bugs.webkit.org/show_bug.cgi?id=31652
 207
 208         Test: fast/lists/ol-start-roman.html
 209
 210         * rendering/RenderListMarker.cpp:
 211         (WebCore::toRoman): Increase the char array size.
 212
 213 2009-11-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 214
 215         Rubber-stamped by Oliver Hunt.
 216
 217         Add translatable strings to cover validationMessage, after
 218         r51172. Already covered by existing test.
 219
 220         * platform/gtk/LocalizedStringsGtk.cpp:
 221         (WebCore::validationMessageValueMissingText):
 222         (WebCore::validationMessageTypeMismatchText):
 223         (WebCore::validationMessagePatternMismatchText):
 224         (WebCore::validationMessageTooLongText):
 225         (WebCore::validationMessageRangeUnderflowText):
 226         (WebCore::validationMessageRangeOverflowText):
 227         (WebCore::validationMessageStepMismatchText):
 228
 229 2009-11-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 230
 231         Reviewed by Darin Adler.
 232
 233         Remove HAVE(FLOAT_H) guard
 234         https://bugs.webkit.org/show_bug.cgi?id=31661
 235
 236         WebCore has a dependency on float.h, there is
 237         no need to guard float.h.
 238
 239         No new tests as there is no functional change.
 240
 241         * html/HTMLInputElement.cpp: Remove include directive
 242         for float.h as it is included in MathExtras.h already.
 243
 244 2009-11-19  Simon Fraser  <simon.fraser@apple.com>
 245
 246         Reviewed by Pavel Feldman.
 247
 248         Instrumentation should account for painting in compositing layers
 249         https://bugs.webkit.org/show_bug.cgi?id=31674
 250
 251         Add calls to InspectorTimelineAgent for painting into compositing layers,
 252         which is not accounted for in FrameView::paintContents().
 253
 254         * rendering/RenderLayerBacking.cpp:
 255         (WebCore::RenderLayerBacking::paintIntoLayer):
 256         Avoid fetching the FrameView multiple times.
 257
 258         (WebCore::inspectorTimelineAgent):
 259         (WebCore::RenderLayerBacking::paintContents):
 260
 261 2009-11-19  Eric Carlson  <eric.carlson@apple.com>
 262
 263         Reviewed by Dan Bernstein.
 264
 265         <rdar://problem/7035231>
 266         Support closed caption in <video> element
 267
 268         Test: media/media-captions.html
 269
 270         * WebCore.base.exp:
 271         * accessibility/AccessibilityMediaControls.cpp:
 272         (WebCore::AccessibilityMediaControl::controlTypeName):
 273             Define ShowClosedCaptionsButton and HideClosedCaptionsButton.
 274
 275         * css/CSSPrimitiveValueMappings.h:
 276         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
 277             Add MediaToggleClosedCaptionsButtonPart.
 278
 279         * css/CSSSelector.cpp:
 280         (WebCore::CSSSelector::extractPseudoType):
 281             Define and match mediaControlsToggleClosedCaptionsButton.
 282
 283         * css/CSSSelector.h:
 284         (WebCore::CSSSelector::):
 285         * css/CSSStyleSelector.cpp:
 286         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
 287             Define and match PseudoMediaControlsToggleClosedCaptions.
 288
 289         * css/CSSValueKeywords.in:
 290             Define and use media-toggle-closed-captions-button.
 291
 292         * css/mediaControls.css:
 293         * css/mediaControlsQuickTime.css:
 294             Add webkit-media-controls-toggle-closed-captions-button.
 295
 296         * html/HTMLMediaElement.cpp:
 297         (WebCore::HTMLMediaElement::HTMLMediaElement):
 298             Initialize m_closedCaptionsVisible.
 299         (WebCore::HTMLMediaElement::loadInternal):
 300             Set m_closedCaptionsVisible to false.
 301         (WebCore::HTMLMediaElement::hasClosedCaptions):
 302         (WebCore::HTMLMediaElement::closedCaptionsVisible):
 303         (WebCore::HTMLMediaElement::setClosedCaptionsVisible):
 304             New, captions internal methods.
 305         (WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible):
 306         (WebCore::HTMLMediaElement::webkitClosedCaptionsVisible):
 307         (WebCore::HTMLMediaElement::webkitHasClosedCaptions):
 308             New, captions DOM API.
 309
 310         * html/HTMLMediaElement.h:
 311         * html/HTMLMediaElement.idl:
 312             Declare methods needed for captions API.
 313
 314         * platform/ThemeTypes.h:
 315             Add MediaToggleClosedCaptionsButtonPart.
 316
 317         * platform/android/LocalizedStringsAndroid.cpp:
 318         (WebCore::localizedMediaControlElementString):
 319         (WebCore::localizedMediaControlElementHelpText):
 320         (WebCore::localizedMediaTimeDescription):
 321             Add empty implmentations.
 322
 323         * platform/graphics/MediaPlayer.cpp:
 324         (WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
 325         (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
 326             New, empty implementations of media engine closed caption functions.
 327         (WebCore::MediaPlayer::hasClosedCaptions):
 328         (WebCore::MediaPlayer::setClosedCaptionsVisible):
 329             New, call media engine closed caption functions.
 330
 331         * platform/graphics/MediaPlayer.h:
 332         * platform/graphics/MediaPlayerPrivate.h:
 333         (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions):
 334         (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):
 335             Declare new media engine methods.
 336
 337         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
 338         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
 339         (WebCore::MediaPlayerPrivate::hasClosedCaptions):
 340         (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
 341             New, QTKit implementation of closed caption methods.
 342
 343         * platform/gtk/LocalizedStringsGtk.cpp:
 344         (WebCore::localizedMediaControlElementString):
 345         (WebCore::localizedMediaControlElementHelpText):
 346             Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.
 347
 348         * platform/mac/WebCoreSystemInterface.h:
 349         * platform/mac/WebCoreSystemInterface.mm:
 350             Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.
 351
 352         * rendering/MediaControlElements.cpp:
 353         (WebCore::MediaControlInputElement::MediaControlInputElement):
 354             Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
 355         (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
 356         (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
 357         (WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
 358             New, implement the closed caption toggle button,
 359
 360         * rendering/MediaControlElements.h:
 361             Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
 362             declare MediaControlToggleClosedCaptionsButtonElement.
 363
 364         * rendering/RenderMedia.cpp:
 365         (WebCore::RenderMedia::styleDidChange):
 366         (WebCore::RenderMedia::createToggleClosedCaptionsButton):
 367         (WebCore::RenderMedia::createStatusDisplay):
 368         (WebCore::RenderMedia::updateControls):
 369         (WebCore::RenderMedia::forwardEvent):
 370         * rendering/RenderMedia.h:
 371             Deal with m_toggleClosedCaptionsButton.
 372
 373         * rendering/RenderTheme.cpp:
 374         (WebCore::RenderTheme::paint):
 375             Deal with MediaToggleClosedCaptionsButtonPart.
 376
 377         * rendering/RenderTheme.h:
 378         * rendering/RenderThemeMac.h:
 379             Declare paintMediaToggleClosedCaptionsButton.
 380
 381         * rendering/RenderThemeMac.mm:
 382         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
 383             New.
 384         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
 385             Don't render captions toggle button unless we are using the new theme, the
 386             movie has captions, and the movie is in a <video> element since we currently
 387             rely on QTKit to render the captions.
 388
 389         * rendering/style/RenderStyleConstants.h:
 390             Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
 391
 392 2009-11-19  Kevin Ollivier  <kevino@theolliviers.com>
 393
 394         wx build fix. Add missing header.
 395
 396         * platform/wx/LocalizedStringsWx.cpp:
 397
 398 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
 399
 400         Reviewed by Darin Adler.
 401
 402         https://bugs.webkit.org/show_bug.cgi?id=31634
 403         Ignore realm for proxy protection spaces
 404
 405         Only affects WebSocket proxy authentication, cannot be tested in DRT.
 406
 407         * platform/network/ProtectionSpace.cpp:
 408         (WebCore::operator==):
 409         * platform/network/ProtectionSpaceHash.h:
 410         (WebCore::ProtectionSpaceHash::hash):
 411
 412 2009-11-19  Olivier Goffart  <ogoffart@trolltech.com>
 413
 414         Reviewed by Simon Hausmann.
 415
 416         [Qt] Normalize signal and slot signatures.
 417
 418         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
 419         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
 420
 421 2009-11-19  Alexander Pavlov  <apavlov@chromium.org>
 422
 423         Reviewed by Pavel Feldman.
 424
 425         Store cookie domains in the WebInspector object
 426
 427         The cookie domains have been moved from StoragePanel into WebInspector.
 428         Also, the document URLs are now passed inside the WebInspector.addResource()
 429         payload rather than pushed directly from InspectorController.
 430         https://bugs.webkit.org/show_bug.cgi?id=31627
 431
 432         * inspector/InspectorController.cpp:
 433         (WebCore::InspectorController::populateScriptObjects):
 434         (WebCore::InspectorController::didFinishLoading):
 435         * inspector/InspectorFrontend.cpp:
 436         * inspector/InspectorFrontend.h:
 437         * inspector/InspectorResource.cpp:
 438         (WebCore::InspectorResource::createScriptObject):
 439         (WebCore::InspectorResource::updateScriptObject):
 440         * inspector/front-end/StoragePanel.js:
 441         (WebInspector.StoragePanel.prototype.reset):
 442         (WebInspector.StoragePanel.prototype.addCookieDomain):
 443         * inspector/front-end/inspector.js:
 444         (WebInspector.addResource):
 445         (WebInspector.addCookieDomain):
 446         (WebInspector.reset):
 447
 448 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 449
 450         Reviewed by Darin Adler.
 451
 452         Allow custom memory allocation control for the other part of platform directory in WebCore
 453         https://bugs.webkit.org/show_bug.cgi?id=31585
 454
 455         Inherits the following classes from FastAllocBase because these are
 456         instantiated by 'new':
 457
 458         class RegularExpression    - instantiated at: WebCore/page/Frame.cpp:415
 459         class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
 460         class Path                 - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
 461         class FontPlatformData     - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188
 462
 463         Inherits the following classes from Noncopyable because these are
 464         instantiated by 'new' and no need to be copyable:
 465
 466         class Cursors                         - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
 467         class NetworkStateNotifier            - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
 468         struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71
 469
 470         class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
 471         class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119
 472
 473         * platform/graphics/MediaPlayerPrivate.h:
 474         * platform/graphics/Path.h:
 475         * platform/graphics/qt/FontPlatformData.h:
 476         * platform/graphics/transforms/TransformationMatrix.h:
 477         * platform/image-decoders/ImageDecoder.h:
 478         * platform/network/NetworkStateNotifier.h:
 479         * platform/network/ResourceRequestBase.h:
 480         * platform/qt/CursorQt.cpp:
 481         * platform/text/RegularExpression.h:
 482
 483 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 484
 485         Unreviewed.
 486
 487         [Qt] Build fix for QtWebKit after r51172.
 488
 489         * platform/qt/Localizations.cpp:
 490         (WebCore::validationMessageValueMissingText):
 491         (WebCore::validationMessageTypeMismatchText):
 492         (WebCore::validationMessagePatternMismatchText):
 493         (WebCore::validationMessageTooLongText):
 494         (WebCore::validationMessageRangeUnderflowText):
 495         (WebCore::validationMessageRangeOverflowText):
 496         (WebCore::validationMessageStepMismatchText):
 497
 498 2009-11-18  Dan Bernstein  <mitz@apple.com>
 499
 500         Reviewed by Simon Fraser.
 501
 502         Fixed <rdar://problem/7398987> Assertion failure in
 503         RenderLayer::updateClipRects when a plug-in’s enclosing layer is
 504         enclosed by a transformed layer
 505
 506         Tests: fast/layers/clip-rects-transformed-2.html
 507                fast/layers/clip-rects-transformed.html
 508
 509         * rendering/RenderLayer.cpp:
 510         (WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
 511         that is either transformed or composited. During painting and hit
 512         testing, when a transformed or composited layer is hit, it becomes the
 513         new root layer, which ultimately gets passed to calculateRects().
 514         (WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
 515         root layer to calculateRects(), and return the bounding box of the
 516         transformed rectangle.
 517         (WebCore::RenderLayer::selfClipRect): Ditto.
 518         * rendering/RenderLayer.h:
 519
 520 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 521
 522         Reviewed by Kenneth Rohde Christiansen.
 523
 524         [Qt] Remove support for Qt v4.3 or older versions
 525         https://bugs.webkit.org/show_bug.cgi?id=29469
 526
 527         No new tests as there is no change if compiled with
 528         Qt v4.4 or later version.
 529
 530         * WebCore.pro:
 531         * dom/XMLTokenizerQt.cpp:
 532         (WebCore::EntityResolver::resolveUndeclaredEntity):
 533         (WebCore::XMLTokenizer::XMLTokenizer):
 534         (WebCore::XMLTokenizer::~XMLTokenizer):
 535         (WebCore::XMLTokenizer::doWrite):
 536         (WebCore::XMLTokenizer::startDocument):
 537         (WebCore::XMLTokenizer::parseDtd):
 538         * platform/graphics/qt/FontQt.cpp:
 539         * platform/graphics/qt/FontQt43.cpp: Removed.
 540         * platform/graphics/qt/ImageQt.cpp:
 541         * platform/network/ResourceHandleInternal.h:
 542         * platform/network/qt/QNetworkReplyHandler.cpp:
 543         * platform/network/qt/QNetworkReplyHandler.h:
 544         * platform/network/qt/ResourceHandleQt.cpp:
 545         (WebCore::ResourceHandle::start):
 546         (WebCore::ResourceHandle::cancel):
 547         (WebCore::ResourceHandle::loadResourceSynchronously):
 548         (WebCore::ResourceHandle::setDefersLoading):
 549         * platform/network/qt/ResourceRequest.h:
 550         * platform/network/qt/ResourceRequestQt.cpp:
 551         * platform/qt/ClipboardQt.cpp:
 552         (WebCore::ClipboardQt::clearData):
 553         * platform/qt/CookieJarQt.cpp:
 554         (WebCore::cookieJar):
 555         (WebCore::setCookies):
 556         (WebCore::cookies):
 557         (WebCore::cookiesEnabled):
 558         * platform/qt/PlatformKeyboardEventQt.cpp:
 559         (WebCore::keyIdentifierForQtKeyCode):
 560         (WebCore::windowsKeyCodeForKeyEvent):
 561         * platform/text/qt/TextBoundaries.cpp:
 562         * platform/text/qt/TextBreakIteratorQt.cpp:
 563         * plugins/qt/PluginDataQt.cpp:
 564         (WebCore::PluginData::initPlugins):
 565
 566 2009-11-18  Michelangelo De Simone  <micdesim@gmail.com>
 567
 568         Reviewed by Darin Adler.
 569
 570         Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
 571         Support for validationMessage attribute, as per HTML5 specs.
 572
 573         Test: fast/forms/validationMessage.html
 574
 575         * html/HTMLButtonElement.idl: validationMessage attribute
 576         * html/HTMLFieldSetElement.idl: validationMessage attribute
 577         * html/HTMLFormControlElement.cpp:
 578         * html/HTMLFormControlElement.h:
 579         * html/HTMLInputElement.idl: validationMessage attribute
 580         * html/HTMLSelectElement.idl: validationMessage attribute
 581         * html/HTMLTextAreaElement.idl: validationMessage attribute
 582         * html/ValidityState.cpp: new method to retrieve pertinent localized text
 583         * html/ValidityState.h:
 584         * page/mac/WebCoreViewFactory.h:
 585         * platform/LocalizedStrings.h:
 586         * platform/android/LocalizedStringsAndroid.cpp:
 587         * platform/gtk/LocalizedStringsGtk.cpp:
 588         * platform/haiku/LocalizedStringsHaiku.cpp:
 589         * platform/mac/LocalizedStringsMac.mm:
 590         * platform/wx/LocalizedStringsWx.cpp:
 591
 592 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 593
 594         Unreviewed.
 595
 596         Fix a typo. Remove the trailing semicolon
 597         from an include directive after r51137.
 598
 599         No new tests as there is no functional change.
 600
 601         * platform/qt/QWebPageClient.h:
 602
 603 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 604
 605         Unreviewed.
 606
 607         [Qt] Build fix for QtWebKit after r51159.
 608
 609         Include float.h for DBL_MANT_DIG. Not sure why this
 610         is not a problem for other ports.
 611
 612         * html/HTMLInputElement.cpp:
 613
 614 2009-11-19  Roland Steiner  <rolandsteiner@chromium.org>
 615
 616         Reviewed by Darin Adler.
 617
 618         Bug 31574 -  Crashing bug when removing <ruby> element
 619         (https://bugs.webkit.org/show_bug.cgi?id=31574)
 620
 621         Cause of the bug:
 622         1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
 623         2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
 624         3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
 625         4.) this triggers the special handling of child removal in RenderRubyRun that
 626             causes it to destroy itself
 627         5.) On returning from all this the renderer crashes when accessing a member
 628             or virtual function on this now illegal object.
 629
 630         I therefore added a flag that tracks if the ruby run is being destroyed.
 631         If so, avoid doing the special handling in removeChild that caused this.
 632         It's not the most elegant solution, but the easiest to implement without
 633         touching unrelated code. Also, it's self-documenting.
 634
 635         Test: fast/ruby/ruby-remove.html
 636
 637         * rendering/RenderRubyRun.cpp:
 638         (WebCore::RenderRubyRun::RenderRubyRun):
 639         (WebCore::RenderRubyRun::destroy):
 640         (WebCore::RenderRubyRun::removeChild):
 641         * rendering/RenderRubyRun.h:
 642
 643 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 644
 645         Reviewed by Kenneth Rohde Christiansen.
 646
 647         [Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
 648         https://bugs.webkit.org/show_bug.cgi?id=31643
 649
 650         No new tests as there is no functional change.
 651
 652         * WebCore.pro:
 653
 654 2009-11-18  Yong Li  <yong.li@torchmobile.com>
 655
 656         Reviewed by Eric Seidel.
 657
 658         Implement TextBoundaries for WINCE port.
 659         https://bugs.webkit.org/show_bug.cgi?id=27371
 660
 661         * platform/text/wince/TextBoundariesWince.cpp: Added.
 662
 663 2009-11-18  Yong Li  <yong.li@torchmobile.com>
 664
 665         Reviewed by Eric Seidel.
 666
 667         Implement TextBreakIterator for WINCE port.
 668         https://bugs.webkit.org/show_bug.cgi?id=27371
 669
 670         * platform/text/wince/TextBreakIteratorWince.cpp: Added.
 671
 672 2009-11-18  Kent Tamura  <tkent@chromium.org>
 673
 674         Reviewed by Darin Adler.
 675
 676         Add support for ValidityState.typeMismatch for the following INPUT types:
 677           date datetime datetime-local month time week
 678         https://bugs.webkit.org/show_bug.cgi?id=31342
 679
 680         Tests: fast/forms/ValidityState-typeMismatch-date.html
 681                fast/forms/ValidityState-typeMismatch-datetime.html
 682                fast/forms/ValidityState-typeMismatch-datetimelocal.html
 683                fast/forms/ValidityState-typeMismatch-month.html
 684                fast/forms/ValidityState-typeMismatch-time.html
 685                fast/forms/ValidityState-typeMismatch-week.html
 686
 687         * html/HTMLInputElement.cpp:
 688         (WebCore::HTMLInputElement::formStringToISODateTime): Check the type
 689           validity of the specified type and string using the ISODateTime class.
 690         * html/HTMLInputElement.h:
 691         * html/ValidityState.cpp:
 692         (WebCore::ValidityState::typeMismatch): Check the type validity
 693           for date, datetime, datetime-local, month, time and week with
 694           HTMLInputElemtn::formStringToISODateTime()
 695
 696 2009-11-18  Maciej Stachowiak  <mjs@apple.com>
 697
 698         Reviewed by Oliver Hunt.
 699
 700         Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
 701         https://bugs.webkit.org/show_bug.cgi?id=31237
 702
 703         Also speeds up Dromaeo DOM Core tests by 1.31x.
 704
 705         * bindings/js/JSNodeCustom.cpp:
 706         (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N^2) behavior. The subtree
 707         mark bit was no longer effective; instead I changed things so only a node that has no ancestors
 708         with wrappers would do marking; there should be only one in the typical case (the root of the
 709         detached subtree).
 710         * dom/Node.cpp:
 711         (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
 712         * dom/Node.h: ditto
 713
 714 2009-11-18  Darin Adler  <darin@apple.com>
 715
 716         Reviewed by Sam Weinig.
 717
 718         Get rid of the redundant strokeType and fillType data members on
 719         a GraphicsContext as well as the FillOrStrokeType enum. Use
 720         null pointers instead.
 721
 722         * platform/graphics/GraphicsContext.cpp:
 723         (WebCore::GraphicsContext::setStrokeColor): Null out the pattern
 724         and gradient.
 725         (WebCore::GraphicsContext::setFillColor): Ditto.
 726         (WebCore::GraphicsContext::setStrokePattern): Null out the graident.
 727         (WebCore::GraphicsContext::setFillPattern): Ditto.
 728         (WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
 729         (WebCore::GraphicsContext::setFillGradient): Ditto.
 730
 731         * platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
 732
 733         * platform/graphics/cairo/GraphicsContextCairo.cpp:
 734         (WebCore::setPlatformFill): Use null checks on fillPattern and
 735         fillGraident instead of a switch statement.
 736         (WebCore::setPlatformStroke): Ditto.
 737
 738         * platform/graphics/cg/GraphicsContextCG.cpp:
 739         (WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
 740         (WebCore::GraphicsContext::applyFillPattern): Ditto.
 741         (WebCore::calculateDrawingMode): Use fillPattern and strokePattern
 742         to see if there is a pattern instead of fillType and strokeType.
 743         (WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
 744         fillPattern, and strokePattern instead of fillType and strokeType.
 745         (WebCore::GraphicsContext::fillPath): Added FIXME about color space that
 746         is used in the pattern and gradient case probably erroneously. Moved
 747         gradient code inside an if statement. Streamlined pattern code and
 748         use an if statement. No switch any more.
 749         (WebCore::GraphicsContext::strokePath): Ditto.
 750         (WebCore::GraphicsContext::fillRect): Ditto.
 751         (WebCore::GraphicsContext::strokeRect): Ditto.
 752
 753         * platform/graphics/qt/GraphicsContextQt.cpp:
 754         (WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
 755         fillGraident instead of a switch statement.
 756         (WebCore::GraphicsContext::strokePath): Ditto.
 757         (WebCore::GraphicsContext::fillRect): Ditto.
 758
 759         * platform/graphics/wince/GraphicsContextWince.cpp:
 760         (WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
 761         (WebCore::GraphicsContext::fillRect): Ditto.
 762
 763 2009-11-18  Kent Tamura  <tkent@chromium.org>
 764
 765         Reviewed by Darin Adler.
 766
 767         Support for step attribute and ValidityStae.stepMismatch for
 768         type=number and range.  stepMismatch will be false if the
 769         difference between the current value and a multiple of the step
 770         value is very small.
 771
 772         Change the behavior of RenderSlider so that it always has a value
 773         rounded to the step attribute value.
 774
 775         https://bugs.webkit.org/show_bug.cgi?id=31331
 776
 777         Tests: fast/forms/ValidityState-stepMismatch-number.html
 778                fast/forms/ValidityState-stepMismatch-range.html
 779                fast/forms/ValidityState-stepMismatch-unsupported.html
 780                fast/forms/input-step.html
 781
 782         * html/HTMLAttributeNames.in: Add "step".
 783         * html/HTMLInputElement.cpp:
 784         (WebCore::HTMLInputElement::stepMismatch):
 785         (WebCore::HTMLInputElement::getStepParameters):
 786         (WebCore::HTMLInputElement::getAllowedValueStep):
 787         * html/HTMLInputElement.h:
 788         * html/HTMLInputElement.idl: Add "step".
 789         * html/ValidityState.cpp:
 790         (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
 791         * html/ValidityState.h:
 792         * rendering/RenderSlider.cpp:
 793         (WebCore::SliderRange::SliderRange):
 794         (WebCore::SliderRange::clampValue):
 795
 796 2009-11-18  Dmitry Titov  <dimich@chromium.org>
 797
 798         Reviewed by Darin Adler.
 799
 800         Need to ASSERT(isMainThread()) in ThreadShared methods.
 801         https://bugs.webkit.org/show_bug.cgi?id=31637
 802
 803         Added ASSERT(IsMainThread()) to all following methods:
 804         * platform/TreeShared.h:
 805         (WebCore::TreeShared::TreeShared):
 806         (WebCore::TreeShared::~TreeShared):
 807         (WebCore::TreeShared::ref):
 808         (WebCore::TreeShared::deref):
 809         (WebCore::TreeShared::setParent):
 810         (WebCore::TreeShared::parent):
 811
 812 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
 813
 814         Reviewed by Eric Seidel.
 815
 816         Add plugin visibility manual test
 817
 818         https://bugs.webkit.org/show_bug.cgi?id=31542
 819
 820         * manual-tests/plugins/windowed.html:
 821         * manual-tests/plugins/windowless.html:
 822
 823 2009-11-18  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
 824
 825         Reviewed by Pavel Feldman.
 826
 827         Web Inspector - remember last script displayed in Scripts panel
 828         https://bugs.webkit.org/show_bug.cgi?id=27552
 829
 830         Manual test added
 831
 832         * inspector/front-end/ScriptsPanel.js:
 833         (WebInspector.ScriptsPanel.prototype.showScript):
 834         (WebInspector.ScriptsPanel.prototype.showResource):
 835         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
 836         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
 837         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
 838         (WebInspector.ScriptsPanel.prototype._goBack):
 839         (WebInspector.ScriptsPanel.prototype._goForward):
 840         * manual-tests/inspector/remember-last-script.html: Added.
 841
 842 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
 843
 844         Reviewed by Dimitri Glazkov.
 845
 846         Win chromium is slow to draw transparent texts
 847         https://bugs.webkit.org/show_bug.cgi?id=31258
 848
 849         Create bounded transparency layers instead of just clipping.
 850
 851         No new tests because this is just a performance improvement.
 852
 853         * platform/graphics/chromium/FontChromiumWin.cpp:
 854         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
 855
 856 2009-11-18  Shu Chang  <Chang.Shu@nokia.com>
 857
 858         Reviewed by Eric Seidel.
 859
 860         [Qt] Add support for displaying deleteButton.
 861         https://bugs.webkit.org/show_bug.cgi?id=31560
 862
 863         Test: LayoutTests/editing/deleting/5408255.html
 864
 865         * WebCore.qrc:
 866         * platform/graphics/qt/ImageQt.cpp:
 867         (loadResourcePixmap):
 868
 869 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
 870
 871         Reviewed by Eric Seidel.
 872
 873         Fix Qt build without JavaScript debugger.
 874
 875         https://bugs.webkit.org/show_bug.cgi?id=31575
 876
 877         * page/Console.idl:
 878
 879 2009-11-18  Daniel Bates  <dbates@webkit.org>
 880
 881         Reviewed by Dave Hyatt.
 882
 883         https://bugs.webkit.org/show_bug.cgi?id=24971
 884         And
 885         <rdar://problem/7138265>
 886
 887         Fixes an issue where setting the height of a table row programmatically
 888         (via JavaScript) causes the table to be improperly rendered because the
 889         height of each row in the table is not recalculated with respect to the
 890         CSS height property.
 891
 892         In particular, programmatically setting the height of some table row causes
 893         the rows of that table to be rendered with a height equal to the minimum
 894         height required by the cells in that row, regardless of any specified cell
 895         heights. Instead, when RenderTableSection::recalcCells is called, the height
 896         of each row should be set to the CSS height property just as we do in
 897         RenderTableSection::addChild.
 898
 899         Test: fast/table/row-height-recalc2.html
 900
 901         * rendering/RenderTableSection.cpp:
 902         (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added.
 903         (WebCore::RenderTableSection::addChild): Moved code that set row height into
 904         method WebCore::setRowHeightToRowStyleHeightIfNotRelative.
 905         (WebCore::RenderTableSection::recalcCells): Modified to call
 906         WebCore::setRowHeightToRowStyleHeightIfNotRelative.
 907
 908 2009-11-18  Zoltan Horvath  <zoltan@webkit.org>
 909
 910         Reviewed by Darin Adler.
 911
 912         Allow custom memory allocation control for the part of platform directory in WebCore
 913         https://bugs.webkit.org/show_bug.cgi?id=31473
 914
 915         Inherits the following classes from FastAllocBase because these are
 916         instantiated by 'new':
 917
 918         class  AnimationList         - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
 919         class  Color                 - instantiated at WebCore/rendering/RenderTheme.cpp:48
 920         struct Length                - instantiated at WebCore/platform/Length.cpp:103
 921         class  PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
 922         class  ContextMenuItem       - instantiated at WebCore/platform/ContextMenu.cpp:70
 923         class  DeprecatedPtrList     - instantiated at WebCore/rendering/RenderBlock.cpp:2284
 924
 925         Inherits the following classes from Noncopyable because these are
 926         instantiated by 'new' and no need to be copyable:
 927
 928         class  GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
 929         class  FontCache              - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
 930         struct MediaPlayerFactory     - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
 931         class  DeprecatedPtrListNode  - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53
 932
 933         * platform/ContextMenuItem.h:
 934         * platform/DeprecatedPtrList.h:
 935         * platform/DeprecatedPtrListImpl.cpp:
 936         * platform/Length.h:
 937         * platform/PlatformKeyboardEvent.h:
 938         * platform/animation/AnimationList.h:
 939         * platform/graphics/Color.h:
 940         * platform/graphics/FontCache.h:
 941         * platform/graphics/GraphicsContextPrivate.h:
 942         * platform/graphics/MediaPlayer.cpp:
 943
 944 2009-11-18  Daniel Bates  <dbates@webkit.org>
 945
 946         Reviewed by Darin Adler.
 947
 948         https://bugs.webkit.org/show_bug.cgi?id=31186
 949
 950         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
 951         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
 952         These are more descriptive names so as to clear an ambiguity surrounding
 953         their usage. Also, renames associated setters and getters so that they
 954         coincide with the renamed fields.
 955
 956         No functionality was changed. So, no tests were included.
 957
 958         * bindings/objc/DOMHTML.mm:
 959         (-[DOMHTMLInputElement _isEdited]):
 960         (-[DOMHTMLTextAreaElement _isEdited]):
 961         * dom/Document.cpp:
 962         (WebCore::Document::setFocusedNode):
 963         * html/HTMLInputElement.cpp:
 964         (WebCore::HTMLInputElement::defaultEventHandler):
 965         * rendering/RenderTextControl.cpp:
 966         (WebCore::RenderTextControl::RenderTextControl):
 967         (WebCore::RenderTextControl::setInnerTextValue):
 968         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
 969         (WebCore::RenderTextControl::subtreeHasChanged):
 970         * rendering/RenderTextControl.h:
 971         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
 972         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
 973         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
 974         * rendering/RenderTextControlSingleLine.cpp:
 975         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
 976         * wml/WMLInputElement.cpp:
 977         (WebCore::WMLInputElement::defaultEventHandler):
 978
 979 2009-11-18  Tony Chang  <tony@chromium.org>
 980
 981         Reviewed by Adam Barth.
 982
 983         Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
 984         https://bugs.webkit.org/show_bug.cgi?id=31499
 985
 986         No new tests, just a build cleanup.
 987
 988         * WebCore.gypi:
 989         * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
 990         * bindings/v8/custom/V8CustomBinding.h:
 991
 992 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
 993
 994         Reviewed by Kevin Ollivier.
 995
 996         Enable wx plugin support using the Windows implementation as a base.
 997
 998         https://bugs.webkit.org/show_bug.cgi?id=31636
 999
1000         * platform/graphics/GraphicsContext.h:
1001         (WebCore::GraphicsContext::inTransparencyLayer):
1002         * platform/graphics/wx/GraphicsContextWx.cpp:
1003         (WebCore::GraphicsContext::getWindowsContext):
1004         (WebCore::GraphicsContext::releaseWindowsContext):
1005         * platform/wx/FileSystemWx.cpp:
1006         (WebCore::unloadModule):
1007         (WebCore::listDirectory):
1008         * plugins/PluginDatabase.cpp:
1009         * plugins/PluginView.cpp:
1010         (WebCore::PluginView::stop):
1011         (WebCore::PluginView::PluginView):
1012         * plugins/PluginView.h:
1013         * plugins/win/PluginViewWin.cpp:
1014         (windowHandleForPageClient):
1015         (WebCore::PluginView::handleMouseEvent):
1016         (WebCore::PluginView::platformStart):
1017         (WebCore::PluginView::snapshot):
1018         * wscript:
1019
1020 2009-11-18  Andrei Popescu  <andreip@google.com>
1021
1022         Reviewed by Dimitri Glazkov.
1023
1024         [Android] Add shared timer and sound utilities to platform/android
1025         https://bugs.webkit.org/show_bug.cgi?id=31584
1026
1027         No new tests required, this is platform specific code.
1028
1029         * platform/android/SharedTimerAndroid.cpp: Added.
1030         (WebCore::setSharedTimerFiredFunction):
1031         (WebCore::setSharedTimerFireTime):
1032         (WebCore::stopSharedTimer):
1033         * platform/android/SoundAndroid.cpp: Added.
1034         (WebCore::systemBeep):
1035
1036 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
1037
1038         Reviewed by Timothy Hatcher.
1039
1040         Fix profile tree nodes loss after focus / restore actions.
1041
1042         Focusing on a node is currently implemented via nodes reattaching
1043         with some caching involved. It seems that not all code was updated
1044         to handle this scenario correctly.
1045
1046         https://bugs.webkit.org/show_bug.cgi?id=31553
1047
1048         * inspector/front-end/BottomUpProfileDataGridTree.js:
1049         (WebInspector.BottomUpProfileDataGridNode):
1050         (WebInspector.BottomUpProfileDataGridNode.prototype._restore):
1051         (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
1052         (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
1053         * inspector/front-end/DataGrid.js:
1054         (WebInspector.DataGrid.prototype.insertChild):
1055         (WebInspector.DataGridNode.prototype._detach):
1056         (WebInspector.DataGridNode.prototype.savePosition):
1057         (WebInspector.DataGridNode.prototype.restorePosition):
1058         * inspector/front-end/TopDownProfileDataGridTree.js:
1059         (WebInspector.TopDownProfileDataGridTree.prototype.focus):
1060         (WebInspector.TopDownProfileDataGridTree.prototype.restore):
1061
1062 2009-11-18  Carol Szabo  <carol.szabo@nokia.com>
1063
1064         Reviewed by Kenneth Rohde Christiansen.
1065
1066         [Qt] QWebPageClient.h needs in some cases QCursor, but it does not
1067         include it
1068         https://bugs.webkit.org/show_bug.cgi?id=31527
1069
1070         No new tests as this is just a coding style fix that affects the
1071         build of some not yet submitted patches (i.e. for bug 30173).
1072
1073         * platform/qt/QWebPageClient.h:
1074
1075 2009-11-18  Nicolas Roard   <nicolas@roard.com>
1076
1077         Reviewed by Dimitri Glazkov.
1078
1079         InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
1080         https://bugs.webkit.org/show_bug.cgi?id=31504
1081
1082         * inspector/InspectorTimelineAgent.h:Added the guard.
1083
1084 2009-11-18  Jens Alfke  <snej@chromium.org>
1085
1086         Build fix to my previous checkin, for Windows Chromium
1087
1088         * svg/SVGAnimatedProperty.h:
1089         (WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.
1090
1091 2009-11-18  Joseph Pecoraro  <joepeck@webkit.org>
1092
1093         Reviewed by Pavel Feldman.
1094
1095         Web Inspector: Directly Access <head> Instead of Searching for It
1096         https://bugs.webkit.org/show_bug.cgi?id=31641
1097
1098         Changed old access of the head element (document.getElementsByTagName)
1099         to just use the document.head accessor.
1100
1101         * inspector/front-end/FontView.js:
1102         (WebInspector.FontView):
1103         * inspector/front-end/InjectedScript.js:
1104         (InjectedScript.addStyleSelector):
1105         * inspector/front-end/SourceFrame.js:
1106         (WebInspector.SourceFrame.prototype._loaded):
1107         * inspector/front-end/inspector.js:
1108         (windowLoaded):
1109
1110 2009-11-18  Sam Weinig  <sam@webkit.org>
1111
1112         Reviewed by Anders Carlsson.
1113
1114         Fix two Geolocation assertions.
1115
1116         * page/Chrome.cpp:
1117         (WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
1118         is not called from JS.
1119         * page/Geolocation.cpp:
1120         (WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
1121         a RefPtr first.
1122
1123 2009-11-18  Alexey Proskuryakov  <ap@apple.com>
1124
1125         Case sensitive file system build fix.
1126
1127         * platform/network/Credential.h: It's not WTF, just wtf.
1128
1129 2009-11-18  Aaron Golden  <agolden@apple.com>
1130
1131         Reviewed by Alexey Proskuryakov.
1132
1133         Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
1134         objects and WebCore::Credential objects without losing certificate information.
1135
1136         * platform/network/Credential.cpp:
1137         (WebCore::Credential::Credential):  Adding a constructor that takes an identity argument and a certificate chain argument
1138         (WebCore::Credential::isEmpty):  Modifying isEmpty to support certificate based credentials (which don't have a username or password)
1139         (WebCore::Credential::identity): Accessor for the m_identity property
1140         (WebCore::Credential::certificates): Accessor for the m_certificates property
1141         (WebCore::Credential::type):  Accessor for the m_type property
1142         (WebCore::operator==):  Modifying == to compare the identity and certificate chains of certificate based credentials.
1143         * platform/network/Credential.h:  Adding new fields to WebCore::Credential to support certificate based credentials.
1144         * platform/network/mac/AuthenticationMac.mm:
1145         (WebCore::mac):  Modifying the mac() conversion method to correctly convert certificate based WebCore::Credential objects.
1146         (WebCore::core):  Modifying the core() conversion method to correctly convert certificate based NSURLCredential objects.
1147
1148 2009-11-18  Dmitry Titov  <dimich@chromium.org>
1149
1150         Reviewed by Eric Seidel.
1151
1152         Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
1153         https://bugs.webkit.org/show_bug.cgi?id=31615
1154
1155         * dom/Document.cpp:
1156         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
1157         (WebCore::ScriptExecutionContextTaskTimer::fired):
1158         (WebCore::PerformTaskContext::PerformTaskContext):
1159         (WebCore::performTask):
1160         (WebCore::Document::postTask):
1161         * dom/ScriptExecutionContext.cpp:
1162         * dom/ScriptExecutionContext.h:
1163
1164 2009-11-18  Jens Alfke  <snej@chromium.org>
1165
1166         Reviewed by Darin Adler.
1167
1168         Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
1169         by causing the right v8-to-WebCore conversion function to be called for every parameter.
1170         This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
1171         To enforce correctness, I added a mode that disables implicit
1172         String-->AtomicString conversions while compiling the generated bindings.
1173         https://bugs.webkit.org/show_bug.cgi?id=31168
1174
1175         * bindings/scripts/CodeGeneratorV8.pm:  Generate usage of V8Parameter class.
1176         * bindings/v8/DerivedSourcesAllInOne.cpp:  Enable NO_IMPLICIT_ATOMICSTRING.
1177         * bindings/v8/V8Binding.h:  Add V8Parameter class.
1178         * css/WebKitCSSKeyframesRule.h:  Make AtomicString conversions explicit.
1179         * dom/Document.idl:  Remove obsolete [HintAtomic] annotation.
1180         * platform/text/AtomicString.h:  Added NO_IMPLICIT_ATOMICSTRING option.
1181         * svg/SVGAnimatedTemplate.h:  Change some return types to String to avoid implicit conversion.
1182         * svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.
1183
1184 2009-11-18  Darin Adler  <darin@apple.com>
1185
1186         Reviewed by Dan Bernstein.
1187
1188         Move FillOrStrokeType out of public header.
1189
1190         * platform/graphics/GraphicsContext.h: Updated copyright date to cover
1191         some years we published Apple changes, sorted forward declarations,
1192         removed FillOrStrokeType enum.
1193         * platform/graphics/GraphicsContextPrivate.h: Updated copyright date
1194         to cover some years we published Apple changes, sorted includes,
1195         moved FillOrStrokeType enum here.
1196
1197 2009-11-18  Chris Marrin  <cmarrin@apple.com>
1198
1199         Reviewed by Simon Fraser.
1200
1201         Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
1202         https://bugs.webkit.org/show_bug.cgi?id=31601
1203
1204         These are used to debug accelerated compositing layers. I removed
1205         the platform specific code from GraphicsLayerCA.mm and added calls
1206         to GraphicsLayerClient to get it from the higher levels. The values
1207         now get cached in RenderLayerCompositing and are queried from there
1208         by RenderLayerBacking (which implements the GraphicsLayerClient interface).
1209
1210         * WebCore.base.exp:
1211         * page/FrameView.cpp:
1212         (WebCore::FrameView::updateCompositingLayers):
1213         * page/Settings.cpp:
1214         (WebCore::Settings::Settings):
1215         (WebCore::Settings::setShowDebugBorders):
1216         (WebCore::Settings::setShowRepaintCounter):
1217         * page/Settings.h:
1218         (WebCore::Settings::showDebugBorders):
1219         (WebCore::Settings::showRepaintCounter):
1220         * platform/graphics/GraphicsLayer.h:
1221         (WebCore::GraphicsLayer::showDebugBorders):
1222         (WebCore::GraphicsLayer::showRepaintCounter):
1223         * platform/graphics/GraphicsLayerClient.h:
1224         * platform/graphics/mac/GraphicsLayerCA.mm:
1225         * rendering/RenderLayerBacking.cpp:
1226         (WebCore::RenderLayerBacking::showDebugBorders):
1227         (WebCore::RenderLayerBacking::showRepaintCounter):
1228         * rendering/RenderLayerBacking.h:
1229         * rendering/RenderLayerCompositor.cpp:
1230         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
1231         (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
1232         * rendering/RenderLayerCompositor.h:
1233         (WebCore::RenderLayerCompositor::showDebugBorders):
1234         (WebCore::RenderLayerCompositor::showRepaintCounter):
1235
1236 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1237
1238         Reviewed by Timothy Hatcher.
1239
1240         Web Inspector: Get rid of metrics and properties sidebars'
1241         flickering.
1242
1243         https://bugs.webkit.org/show_bug.cgi?id=31629
1244
1245         * inspector/front-end/MetricsSidebarPane.js:
1246         * inspector/front-end/PropertiesSidebarPane.js:
1247
1248 2009-11-17  Brian Weinstein  <bweinstein@apple.com>
1249
1250         Reviewed by Pavel Feldman.
1251
1252         Fixes <http://webkit.org/b/31606>.
1253         Web Inspector: Enter/Return key should enter edit mode for Editable Fields.
1254
1255         This implements Enter starting editing mode in an editable DataGrid. If the
1256         DataGrid is editable and the user hits return, startEditing the first child
1257         of the selected node. Also refactored some editing functions to take an
1258         event target instead of the event itself, because the functions only needed
1259         the target. Lastly, added had return in editing mode stop propogation, because
1260         when enter was hit to confirm text, it would propagate back to the datagrid
1261         and try to start editing again.
1262
1263         * inspector/front-end/DataGrid.js:
1264         (WebInspector.DataGrid.prototype._ondblclick):
1265         (WebInspector.DataGrid.prototype._startEditing):
1266         (WebInspector.DataGrid.prototype.handleKeyEvent):
1267         (WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
1268         (WebInspector.DataGrid.prototype._mouseDownInDataTable):
1269         (WebInspector.DataGrid.prototype._clickInDataTable):
1270         * inspector/front-end/inspector.js:
1271         (WebInspector.startEditing.element.handleKeyEvent):
1272         (WebInspector.startEditing):
1273
1274 2009-11-18  Ben Murdoch  <benm@google.com>
1275
1276         Reviewed by Darin Adler.
1277
1278         HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
1279         https://bugs.webkit.org/show_bug.cgi?id=31593
1280
1281         Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html
1282
1283         * html/HTMLAnchorElement.cpp:
1284         (WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.
1285
1286 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1287
1288         Not reviewed. Touch InspectorController so that frontend
1289         JS files are deployed on Windows.
1290
1291         * inspector/InspectorController.cpp:
1292
1293 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1294
1295         Reviewed by Timothy Hatcher.
1296
1297         Web Inspector: clone timeline records array instead of
1298         copying reference on invalidate all.
1299
1300         https://bugs.webkit.org/show_bug.cgi?id=31596
1301
1302         * inspector/front-end/AbstractTimelinePanel.js:
1303         (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
1304
1305 2009-11-18  Simon Fraser  <simon.fraser@apple.com>
1306
1307         Reviewed by Dan Bernstein.
1308
1309         Elements don't drop out of compositing layers when animation ends
1310         https://bugs.webkit.org/show_bug.cgi?id=31613
1311         <rdar://problem/7402913>
1312
1313         Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
1314         are compositing anyway for other reasons. Doing so can cause those layers
1315         to stay in compositing mode even after animations finish, because needsToBeComposited()
1316         continues to return true.
1317
1318         No new tests because it's not possible to determine which elements are in
1319         compositing layers from DRT output.
1320
1321         * rendering/RenderLayerCompositor.cpp:
1322         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
1323
1324 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
1325
1326         Reviewed by Tor Arne Vestbø.
1327
1328         [Qt] Mac Plugins: Remove null timer
1329
1330         A null timer was used to send mouse move events. Instead, we now use
1331         move events to send nullEvent. This brings down CPU usage by 20-30%.
1332
1333         https://bugs.webkit.org/show_bug.cgi?id=31624
1334
1335         * plugins/PluginView.h:
1336         * plugins/mac/PluginViewMac.cpp:
1337         (WebCore::PluginView::platformStart):
1338         (WebCore::PluginView::handleMouseEvent):
1339
1340 2009-11-18  Benjamin Poulain  <benjamin.poulain@nokia.com>
1341
1342         Reviewed by Simon Hausmann.
1343
1344         [Qt] WebKit crashes when loading certain SVG images
1345
1346         Check if the familly exist before creating the PlatformData from it.
1347
1348         https://bugs.webkit.org/show_bug.cgi?id=29443
1349
1350         Test: svg/text/text-font-invalid.html
1351
1352         * platform/graphics/qt/FontFallbackListQt.cpp:
1353         (WebCore::FontFallbackList::fontDataAt):
1354
1355 2009-11-17  Nicolas Weber  <thakis@chromium.org>
1356
1357         Reviewed by Darin Fisher.
1358
1359         Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
1360         after navigation.
1361         https://bugs.webkit.org/show_bug.cgi?id=31609
1362
1363         * platform/chromium/PopupMenuChromium.cpp:
1364         (WebCore::PopupContainer::showExternal): Set parent for external
1365         dropdowns, so that |PopupListBox::hidePopup()| can successfully notify
1366         its parent's client.
1367
1368 2009-11-17  Hayato Ito  <hayato@google.com>
1369
1370         Reviewed by Darin Adler.
1371
1372         Avoid infinite mutual recursion when deeply nested tags are loaded
1373         https://bugs.webkit.org/show_bug.cgi?id=30651
1374
1375         Test: fast/parser/block-nesting-cap-table.html
1376
1377         * html/HTMLParser.cpp:
1378         (WebCore::HTMLParser::parseToken):
1379         (WebCore::tagPriorityOfNode):
1380         (WebCore::HTMLParser::limitBlockDepth):
1381         (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth):
1382         (WebCore::HTMLParser::insertNode):
1383         * html/HTMLParser.h:
1384
1385 2009-11-17  Brent Fulgham  <bfulgham@webkit.org>
1386
1387         Rubber-stamped by Alexey Proskuryakov.
1388
1389         Final clean-ups for minor coding standard violations.
1390         https://bugs.webkit.org/show_bug.cgi?id=26102.
1391
1392         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1393
1394 2009-11-17  Johnny Ding  <jnd@chromium.org>
1395
1396         Reviewed by Darin Adler.
1397
1398         In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
1399         https://bugs.webkit.org/show_bug.cgi?id=31567
1400
1401         * dom/ScriptElement.cpp:
1402         (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
1403
1404 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1405
1406         Reviewed by Timothy Hatcher.
1407
1408         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1409         - Updated DRT to show/close inspector for all tests under /inspector
1410         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1411           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1412         - Removed reload on each inspector test
1413         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1414         inspector for those.
1415         - Reimplemented timeline tests in order to get rid of reload there.
1416         - Moved tests that don't require harness into the fast group.
1417
1418         https://bugs.webkit.org/show_bug.cgi?id=31472
1419
1420         * WebCore.Inspector.exp:
1421         * inspector/front-end/TimelinePanel.js:
1422         (WebInspector.TimelinePanel.prototype._formatRecord):
1423
1424 2009-11-17  Andrei Popescu  <andreip@google.com>
1425
1426         Reviewed by Dimitri Glazkov.
1427
1428         [Android] Android is missing the implementation of the GeolocationService iface.
1429         https://bugs.webkit.org/show_bug.cgi?id=31554
1430
1431         No new tests required as this is platform specific code.
1432
1433         * platform/android/GeolocationServiceAndroid.cpp: Added.
1434         (WebCore::GeolocationServiceAndroid::create):
1435         (WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
1436         (WebCore::GeolocationServiceAndroid::startUpdating):
1437         (WebCore::GeolocationServiceAndroid::stopUpdating):
1438         (WebCore::GeolocationServiceAndroid::suspend):
1439         (WebCore::GeolocationServiceAndroid::resume):
1440         (WebCore::GeolocationServiceAndroid::newPositionAvailable):
1441         (WebCore::GeolocationServiceAndroid::newErrorAvailable):
1442         (WebCore::GeolocationServiceAndroid::timerFired):
1443         (WebCore::GeolocationServiceAndroid::isPositionMovement):
1444         (WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
1445         (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):
1446         * platform/android/GeolocationServiceAndroid.h: Added.
1447         (WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
1448         (WebCore::GeolocationServiceAndroid::lastPosition):
1449         (WebCore::GeolocationServiceAndroid::lastError):
1450         * platform/android/GeolocationServiceBridge.cpp: Added.
1451         (WebCore::):
1452         (WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
1453         (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
1454         (WebCore::GeolocationServiceBridge::start):
1455         (WebCore::GeolocationServiceBridge::stop):
1456         (WebCore::GeolocationServiceBridge::setEnableGps):
1457         (WebCore::GeolocationServiceBridge::newLocationAvailable):
1458         (WebCore::GeolocationServiceBridge::newErrorAvailable):
1459         (WebCore::GeolocationServiceBridge::toGeoposition):
1460         (WebCore::GeolocationServiceBridge::startJavaImplementation):
1461         (WebCore::GeolocationServiceBridge::stopJavaImplementation):
1462         * platform/android/GeolocationServiceBridge.h: Added.
1463
1464 2009-11-16  Kent Tamura  <tkent@chromium.org>
1465
1466         Unreviewd build fix.
1467
1468         - Fix typo in WebCore.vcproj.
1469         - Intlude limits.h for INT_MAX.
1470         - Enclose with parenthesis to suspress warning.
1471
1472         * WebCore.vcproj/WebCore.vcproj:
1473         * html/ISODateTime.cpp:
1474         (WebCore::ISODateTime::addDay):
1475
1476 2009-11-16  Robin Dunn  <robin@alldunn.com>
1477
1478         Reviewed by Kevin Ollivier.
1479
1480         Make sure wx scrollbar drawing code factors in transforms when switching backends,
1481         fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.
1482
1483         https://bugs.webkit.org/show_bug.cgi?id=31570
1484
1485         * platform/wx/ScrollbarThemeWx.cpp:
1486         (WebCore::ScrollbarThemeWx::minimumThumbLength):
1487         (WebCore::ScrollbarThemeWx::splitTrack):
1488         (WebCore::ScrollbarThemeWx::forwardButtonRect):
1489         * platform/wx/ScrollbarThemeWx.h:
1490         * platform/wx/wxcode/gtk/scrollbar_render.cpp:
1491         (wxRenderer_DrawScrollbar):
1492         * platform/wx/wxcode/scrollbar_render.h:
1493         (calcThumbStartAndLength):
1494         * platform/wx/wxcode/win/scrollbar_render.cpp:
1495         (wxRenderer_DrawScrollbar):
1496
1497 2009-11-16  Kent Tamura  <tkent@chromium.org>
1498
1499         Reviewed by David Levin.
1500
1501         Introduce WebCore::ISODateTime class.
1502         https://bugs.webkit.org/show_bug.cgi?id=31340
1503
1504         This class represents a value of date/time types of the HTML5 INPUT
1505         element, and has some parsing methods for ISO 8601.
1506
1507         This change has no tests because the class is not used yet.
1508
1509         * GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
1510         * WebCore.gypi: ditto.
1511         * WebCore.pro: ditto.
1512         * WebCore.vcproj/WebCore.vcproj: ditto.
1513         * WebCore.xcodeproj/project.pbxproj: ditto.
1514         * WebCoreSources.bkl: ditto.
1515         * html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class.
1516         (WebCore::isLeapYear):
1517         (WebCore::maxDayOfMonth):
1518         (WebCore::dayOfWeek):
1519         (WebCore::ISODateTime::maxWeekNumberInYear):
1520         (WebCore::countDigits):
1521         (WebCore::toInt):
1522         (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek().
1523         (WebCore::ISODateTime::addDay): Private helper for parseTimeZone().
1524         (WebCore::ISODateTime::addMinute): ditto.
1525         (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime().
1526         (WebCore::ISODateTime::parseMonth): Parser for <input type=month>.
1527         (WebCore::ISODateTime::parseDate): Parser for <input type=date>.
1528         (WebCore::ISODateTime::parseWeek): Parser for <input type=week>.
1529         (WebCore::ISODateTime::parseTime): Parser for <input type=time>.
1530         (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>.
1531         (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
1532         * html/ISODateTime.h: Added.  Declare WebCore::ISODateTime class.
1533         (WebCore::ISODateTime::ISODateTime):
1534         (WebCore::ISODateTime::millisecond):
1535         (WebCore::ISODateTime::second):
1536         (WebCore::ISODateTime::minute):
1537         (WebCore::ISODateTime::hour):
1538         (WebCore::ISODateTime::monthDay):
1539         (WebCore::ISODateTime::month):
1540         (WebCore::ISODateTime::fullYear):
1541         (WebCore::ISODateTime::week):
1542
1543 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1544
1545         Fix a typo in previous commit.
1546
1547         * platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.
1548
1549 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1550
1551         Fix a typo in previous commit.
1552
1553         * platform/network/cf/SocketStreamHandleCFNet.cpp:
1554
1555 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1556
1557         Tiger build fix.
1558
1559         * platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named
1560         differently in Tiger CFNetwork.
1561
1562 2009-11-16  Dimitri Glazkov  <dglazkov@chromium.org>
1563
1564         Reviewed by Darin Fisher.
1565
1566         [KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.
1567
1568         Fix a bug in the code that was dormant until http://trac.webkit.org/changeset/50784.
1569
1570         Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1571
1572         * platform/KURLGoogle.cpp:
1573         (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.
1574
1575 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1576
1577         Rubber-stamped by Jon Honeycutt.
1578
1579         A better Windows build fix
1580
1581         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
1582         Use a macro that inserts __declspec(dllimport) when appropriate for CFNetwork imports.
1583
1584 2009-11-16  Yael Aharon  <yael.aharon@nokia.com>
1585
1586         Reviewed by Darin Adler.
1587
1588         Rename protocolIsValid to isValidProtocol.
1589         https://bugs.webkit.org/show_bug.cgi?id=31503
1590
1591         This name change was suggested in https://bugs.webkit.org/show_bug.cgi?id=29972#c19.
1592
1593         No new tests since no new functionality was introduced.
1594
1595         * html/HTMLAnchorElement.cpp:
1596         (WebCore::HTMLAnchorElement::setProtocol):
1597         * platform/KURL.cpp:
1598         (WebCore::isValidProtocol):
1599         * platform/KURL.h:
1600         * platform/KURLGoogle.cpp:
1601         (WebCore::isValidProtocol):
1602
1603 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1604
1605         Reviewed by Beth Dakin.
1606
1607         AX: aria-labelledby duplicates some of its WAI-ARIA label
1608         https://bugs.webkit.org/show_bug.cgi?id=31565
1609
1610         Test: accessibility/aria-labelledby-overrides-label.html
1611
1612         * accessibility/AccessibilityRenderObject.cpp:
1613         (WebCore::AccessibilityRenderObject::hasTextAlternative):
1614         (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
1615         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1616         * accessibility/AccessibilityRenderObject.h:
1617
1618 2009-11-16  Nate Chapin  <japhet@chromium.org>
1619
1620         Reviewed by Darin Fisher.
1621
1622         Handle the case of a null NPObject* in NPN_SetException in
1623         the V8 bindings.  This allow out of process plugins calling
1624         NPN_SetException to just send null instead of sending an
1625         NPObject* that would be an address in a different
1626         process's memory space.
1627
1628         https://bugs.webkit.org/show_bug.cgi?id=31561
1629
1630         * bindings/v8/NPV8Object.cpp:
1631         (_NPN_SetException): Allow null NPObject* and just throw a general error.
1632
1633 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1634
1635         Windows build fix.
1636
1637         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
1638         Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.
1639
1640 2009-11-14  Yael Aharon  <yael.aharon@nokia.com>
1641
1642         Reviewed by Kenneth Rohde Christiansen.
1643
1644         [Qt] ASSERT failure while running DRT
1645         https://bugs.webkit.org/show_bug.cgi?id=30978
1646
1647         Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
1648         These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.
1649
1650         * bridge/qt/qt_instance.cpp:
1651         (JSC::Bindings::QtRuntimeObjectImp::createStructure):
1652         * bridge/qt/qt_runtime.h:
1653         (JSC::Bindings::QtRuntimeMethod::createStructure):
1654
1655 2009-11-16  Mark Rowe  <mrowe@apple.com>
1656
1657         Attempt to fix the build.  Land a file that was missing from r51049.
1658
1659         * bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.
1660         (WebCore::setWebGLArrayFromArray):
1661
1662 2009-11-16  Kenneth Russell  <kbr@google.com>
1663
1664         Reviewed by Oliver Hunt.
1665
1666         Update API of WebGLArray and friends
1667         https://bugs.webkit.org/show_bug.cgi?id=31175
1668
1669         * bindings/js/JSWebGLArrayCustom.cpp:
1670         (WebCore::toJS):
1671         * bindings/js/JSWebGLArrayHelper.h: Added.
1672         (WebCore::setWebGLArrayFromArray):
1673         * bindings/js/JSWebGLByteArrayCustom.cpp:
1674         (WebCore::JSWebGLByteArray::set):
1675         * bindings/js/JSWebGLFloatArrayCustom.cpp:
1676         (WebCore::JSWebGLFloatArray::set):
1677         * bindings/js/JSWebGLIntArrayCustom.cpp:
1678         (WebCore::JSWebGLIntArray::set):
1679         * bindings/js/JSWebGLShortArrayCustom.cpp:
1680         (WebCore::JSWebGLShortArray::set):
1681         * bindings/js/JSWebGLUnsignedByteArrayCustom.cpp:
1682         (WebCore::JSWebGLUnsignedByteArray::set):
1683         * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
1684         (WebCore::JSWebGLUnsignedIntArray::set):
1685         * bindings/js/JSWebGLUnsignedShortArrayCustom.cpp:
1686         (WebCore::JSWebGLUnsignedShortArray::set):
1687         * bindings/scripts/CodeGeneratorV8.pm:
1688         * bindings/v8/V8DOMWrapper.cpp:
1689         (WebCore::V8DOMWrapper::convertToV8Object):
1690         * bindings/v8/custom/V8CustomBinding.h:
1691         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
1692         (WebCore::CALLBACK_FUNC_DECL):
1693         * bindings/v8/custom/V8WebGLArrayCustom.h:
1694         (WebCore::constructWebGLArray):
1695         (WebCore::getWebGLArrayElement):
1696         (WebCore::setWebGLArrayFromArray):
1697         (WebCore::setWebGLArray):
1698         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
1699         (WebCore::CALLBACK_FUNC_DECL):
1700         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
1701         (WebCore::CALLBACK_FUNC_DECL):
1702         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1703         (WebCore::CALLBACK_FUNC_DECL):
1704         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
1705         (WebCore::CALLBACK_FUNC_DECL):
1706         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
1707         (WebCore::CALLBACK_FUNC_DECL):
1708         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
1709         (WebCore::CALLBACK_FUNC_DECL):
1710         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
1711         (WebCore::CALLBACK_FUNC_DECL):
1712         * html/canvas/WebGLArray.cpp:
1713         (WebCore::WebGLArray::WebGLArray):
1714         (WebCore::WebGLArray::~WebGLArray):
1715         (WebCore::WebGLArray::setImpl):
1716         * html/canvas/WebGLArray.h:
1717         (WebCore::WebGLArray::isByteArray):
1718         (WebCore::WebGLArray::isUnsignedByteArray):
1719         (WebCore::WebGLArray::isShortArray):
1720         (WebCore::WebGLArray::isUnsignedShortArray):
1721         (WebCore::WebGLArray::isIntArray):
1722         (WebCore::WebGLArray::isUnsignedIntArray):
1723         (WebCore::WebGLArray::isFloatArray):
1724         (WebCore::WebGLArray::buffer):
1725         (WebCore::WebGLArray::baseAddress):
1726         (WebCore::WebGLArray::byteOffset):
1727         * html/canvas/WebGLArray.idl:
1728         * html/canvas/WebGLArrayBuffer.cpp:
1729         (WebCore::WebGLArrayBuffer::create):
1730         (WebCore::WebGLArrayBuffer::WebGLArrayBuffer):
1731         (WebCore::WebGLArrayBuffer::data):
1732         (WebCore::WebGLArrayBuffer::byteLength):
1733         (WebCore::WebGLArrayBuffer::~WebGLArrayBuffer):
1734         * html/canvas/WebGLArrayBuffer.h:
1735         * html/canvas/WebGLByteArray.cpp:
1736         (WebCore::WebGLByteArray::create):
1737         (WebCore::WebGLByteArray::byteLength):
1738         (WebCore::WebGLByteArray::slice):
1739         (WebCore::WebGLByteArray::set):
1740         * html/canvas/WebGLByteArray.h:
1741         (WebCore::WebGLByteArray::isByteArray):
1742         (WebCore::WebGLByteArray::data):
1743         (WebCore::WebGLByteArray::set):
1744         (WebCore::WebGLByteArray::get):
1745         (WebCore::WebGLByteArray::item):
1746         * html/canvas/WebGLByteArray.idl:
1747         * html/canvas/WebGLFloatArray.cpp:
1748         (WebCore::WebGLFloatArray::create):
1749         (WebCore::WebGLFloatArray::WebGLFloatArray):
1750         (WebCore::WebGLFloatArray::length):
1751         (WebCore::WebGLFloatArray::byteLength):
1752         (WebCore::WebGLFloatArray::slice):
1753         (WebCore::WebGLFloatArray::set):
1754         * html/canvas/WebGLFloatArray.h:
1755         (WebCore::WebGLFloatArray::isFloatArray):
1756         (WebCore::WebGLFloatArray::data):
1757         (WebCore::WebGLFloatArray::set):
1758         (WebCore::WebGLFloatArray::get):
1759         (WebCore::WebGLFloatArray::item):
1760         * html/canvas/WebGLFloatArray.idl:
1761         * html/canvas/WebGLIntArray.cpp:
1762         (WebCore::WebGLIntArray::create):
1763         (WebCore::WebGLIntArray::WebGLIntArray):
1764         (WebCore::WebGLIntArray::length):
1765         (WebCore::WebGLIntArray::byteLength):
1766         (WebCore::WebGLIntArray::slice):
1767         (WebCore::WebGLIntArray::set):
1768         * html/canvas/WebGLIntArray.h:
1769         (WebCore::WebGLIntArray::isIntArray):
1770         (WebCore::WebGLIntArray::data):
1771         (WebCore::WebGLIntArray::set):
1772         (WebCore::WebGLIntArray::get):
1773         (WebCore::WebGLIntArray::item):
1774         * html/canvas/WebGLIntArray.idl:
1775         * html/canvas/WebGLShortArray.cpp:
1776         (WebCore::WebGLShortArray::create):
1777         (WebCore::WebGLShortArray::WebGLShortArray):
1778         (WebCore::WebGLShortArray::length):
1779         (WebCore::WebGLShortArray::byteLength):
1780         (WebCore::WebGLShortArray::slice):
1781         (WebCore::WebGLShortArray::set):
1782         * html/canvas/WebGLShortArray.h:
1783         (WebCore::WebGLShortArray::isShortArray):
1784         (WebCore::WebGLShortArray::data):
1785         (WebCore::WebGLShortArray::set):
1786         (WebCore::WebGLShortArray::get):
1787         (WebCore::WebGLShortArray::item):
1788         * html/canvas/WebGLShortArray.idl:
1789         * html/canvas/WebGLUnsignedByteArray.cpp:
1790         (WebCore::WebGLUnsignedByteArray::create):
1791         (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
1792         (WebCore::WebGLUnsignedByteArray::length):
1793         (WebCore::WebGLUnsignedByteArray::byteLength):
1794         (WebCore::WebGLUnsignedByteArray::slice):
1795         (WebCore::WebGLUnsignedByteArray::set):
1796         * html/canvas/WebGLUnsignedByteArray.h:
1797         (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
1798         (WebCore::WebGLUnsignedByteArray::data):
1799         (WebCore::WebGLUnsignedByteArray::set):
1800         (WebCore::WebGLUnsignedByteArray::get):
1801         (WebCore::WebGLUnsignedByteArray::item):
1802         * html/canvas/WebGLUnsignedByteArray.idl:
1803         * html/canvas/WebGLUnsignedIntArray.cpp:
1804         (WebCore::WebGLUnsignedIntArray::create):
1805         (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
1806         (WebCore::WebGLUnsignedIntArray::length):
1807         (WebCore::WebGLUnsignedIntArray::byteLength):
1808         (WebCore::WebGLUnsignedIntArray::slice):
1809         (WebCore::WebGLUnsignedIntArray::set):
1810         * html/canvas/WebGLUnsignedIntArray.h:
1811         (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
1812         (WebCore::WebGLUnsignedIntArray::data):
1813         (WebCore::WebGLUnsignedIntArray::set):
1814         (WebCore::WebGLUnsignedIntArray::get):
1815         (WebCore::WebGLUnsignedIntArray::item):
1816         * html/canvas/WebGLUnsignedIntArray.idl:
1817         * html/canvas/WebGLUnsignedShortArray.cpp:
1818         (WebCore::WebGLUnsignedShortArray::create):
1819         (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
1820         (WebCore::WebGLUnsignedShortArray::length):
1821         (WebCore::WebGLUnsignedShortArray::byteLength):
1822         (WebCore::WebGLUnsignedShortArray::slice):
1823         (WebCore::WebGLUnsignedShortArray::set):
1824         * html/canvas/WebGLUnsignedShortArray.h:
1825         (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
1826         (WebCore::WebGLUnsignedShortArray::data):
1827         (WebCore::WebGLUnsignedShortArray::set):
1828         (WebCore::WebGLUnsignedShortArray::get):
1829         (WebCore::WebGLUnsignedShortArray::item):
1830         * html/canvas/WebGLUnsignedShortArray.idl:
1831         * platform/graphics/mac/GraphicsContext3DMac.cpp:
1832         (WebCore::GraphicsContext3D::bufferData):
1833         (WebCore::GraphicsContext3D::bufferSubData):
1834
1835 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1836
1837         Windows build fix.
1838
1839         * platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".
1840
1841 2009-11-15  Brent Fulgham  <bfulgham@webkit.org>
1842
1843         Reviewed by Oliver Hunt.
1844
1845         Enable support for webkit-box-shadow in Cairo builds.
1846         https://bugs.webkit.org/show_bug.cgi?id=26102.
1847
1848         Covered by existing fast/box-shadow tests.
1849
1850         * platform/graphics/cairo/GraphicsContextCairo.cpp:  Add
1851           support for fillRect shadows.
1852
1853 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1854
1855         Windows build fix.
1856
1857         * platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not
1858         in WebKitSupportLibrary.
1859
1860 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1861
1862         Reviewed by Darin Adler.
1863
1864         https://bugs.webkit.org/show_bug.cgi?id=31494
1865         Add unauthenticated proxy support to SocketStreamHandleCFNet
1866
1867         Cannot be tested in DRT.
1868
1869         * platform/network/cf/SocketStreamHandleCFNet.cpp:
1870         (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS.
1871         (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.
1872
1873 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1874
1875         Reviewed by Antti Koivisto.
1876
1877         [Qt] Broken back/forward after using ErrorPageExtension to set error page
1878         https://bugs.webkit.org/show_bug.cgi?id=30573
1879
1880         Make FrameLoader::checkLoadCompleteForThisFrame method
1881         to check for any working DocumentLoader instance (through
1882         activeDocumentLoader()) instead of only checking for
1883         'm_provisionalDocumentLoader' in order to decide to if
1884         it is going to reset of not the back and forward history.
1885         after an error page has been loaded.
1886
1887         Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html
1888
1889         * loader/FrameLoader.cpp:
1890         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1891
1892 2009-11-14  Chris Fleizach  <cfleizach@apple.com>
1893
1894         Reviewed by Darin Adler.
1895
1896         Need to implement ARIA role="directory"
1897         https://bugs.webkit.org/show_bug.cgi?id=31516
1898
1899         Test: platform/mac/accessibility/aria-directory.html
1900
1901         * accessibility/AXObjectCache.cpp:
1902         (WebCore::AXObjectCache::getOrCreate):
1903         * accessibility/AccessibilityList.cpp:
1904         (WebCore::AccessibilityList::isOrderedList):
1905         * accessibility/AccessibilityRenderObject.cpp:
1906         (WebCore::createARIARoleMap):
1907
1908 2009-11-15  Dave Tapuska  <dtapuska@rim.com>
1909
1910         Reviewed by George Staikos.
1911
1912         Compare UChars single unit at a time as opposed to the uint32_t
1913         approach as casting to unaligned addresses may cause a bus failure
1914         on ARMv5 and below. This change replicates the same defines that
1915         exists in AtomicString.cpp
1916
1917         https://bugs.webkit.org/show_bug.cgi?id=31475
1918
1919         * platform/text/StringHash.h:
1920         (WebCore::StringHash::equal):
1921
1922 2009-11-15  Evan Martin  <evan@chromium.org>
1923
1924         Reviewed by Adam Barth.
1925
1926         Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.
1927
1928         https://bugs.webkit.org/show_bug.cgi?id=31490
1929
1930         * bindings/v8/V8DOMWrapper.cpp:
1931
1932 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
1933
1934         Reviewed by Adam Barth.
1935
1936         [Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.
1937
1938         * platform/haiku/FileChooserHaiku.cpp:
1939
1940 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
1941
1942         Reviewed by Adam Barth.
1943
1944         [Haiku] Build fix. ColorSpace name had a wrong CamelCase.
1945
1946         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1947         (WebCore::GraphicsContext::setPlatformStrokeColor):
1948
1949 2009-11-15  Daniel Bates  <dbates@webkit.org>
1950
1951         No review, rolling out r50999.
1952         http://trac.webkit.org/changeset/50999
1953
1954         Need to fix some issues in the Windows build. Missed some places where
1955         RenderTextControl::isEdited is called.
1956
1957         * bindings/objc/DOMHTML.mm:
1958         (-[DOMHTMLInputElement _isEdited]):
1959         (-[DOMHTMLTextAreaElement _isEdited]):
1960         * dom/Document.cpp:
1961         (WebCore::Document::setFocusedNode):
1962         * html/HTMLInputElement.cpp:
1963         (WebCore::HTMLInputElement::defaultEventHandler):
1964         * rendering/RenderTextControl.cpp:
1965         (WebCore::RenderTextControl::RenderTextControl):
1966         (WebCore::RenderTextControl::setInnerTextValue):
1967         (WebCore::RenderTextControl::setUserEdited):
1968         (WebCore::RenderTextControl::subtreeHasChanged):
1969         * rendering/RenderTextControl.h:
1970         (WebCore::RenderTextControl::isEdited):
1971         (WebCore::RenderTextControl::setEdited):
1972         (WebCore::RenderTextControl::isUserEdited):
1973         * rendering/RenderTextControlSingleLine.cpp:
1974         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
1975         * wml/WMLInputElement.cpp:
1976         (WebCore::WMLInputElement::defaultEventHandler):
1977
1978 2009-11-15  Daniel Bates  <dbates@webkit.org>
1979
1980         Reviewed by Darin Adler.
1981
1982         https://bugs.webkit.org/show_bug.cgi?id=31186
1983
1984         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
1985         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
1986         These are more descriptive names so as to clear an ambiguity surrounding
1987         their usage. Also, renames associated setters and getters so that they
1988         coincide with the renamed fields.
1989
1990         No functionality was changed. So, no tests were included.
1991
1992         * bindings/objc/DOMHTML.mm:
1993         (-[DOMHTMLInputElement _isEdited]):
1994         (-[DOMHTMLTextAreaElement _isEdited]):
1995         * dom/Document.cpp:
1996         (WebCore::Document::setFocusedNode):
1997         * html/HTMLInputElement.cpp:
1998         (WebCore::HTMLInputElement::defaultEventHandler):
1999         * rendering/RenderTextControl.cpp:
2000         (WebCore::RenderTextControl::RenderTextControl):
2001         (WebCore::RenderTextControl::setInnerTextValue):
2002         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
2003         (WebCore::RenderTextControl::subtreeHasChanged):
2004         * rendering/RenderTextControl.h:
2005         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
2006         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
2007         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
2008         * rendering/RenderTextControlSingleLine.cpp:
2009         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2010         * wml/WMLInputElement.cpp:
2011         (WebCore::WMLInputElement::defaultEventHandler):
2012
2013 2009-11-14  Adele Peterson  <adele@apple.com>
2014
2015         Reviewed by Dan Bernstein.
2016
2017         Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
2018
2019         Test: fast/overflow/line-clamp.html
2020
2021         * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
2022         * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
2023         * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
2024
2025         * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
2026         Use the line count value if available.  Otherwise, convert the percentage to the line count, as we did before.  Also,
2027         if there is anchor as the last child box, still allow adding the ellipsis.
2028
2029         * rendering/RenderLayer.cpp:
2030         (WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
2031         (WebCore::RenderLayer::scrollRectToVisible): ditto.
2032
2033         * WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
2034         * rendering/style/LineClampValue.h: Added.
2035         (WebCore::LineClampValue::LineClampValue):
2036         (WebCore::LineClampValue::value):
2037         (WebCore::LineClampValue::isPercentage):
2038         (WebCore::LineClampValue::isNone):
2039         (WebCore::LineClampValue::operator==):
2040         (WebCore::LineClampValue::operator!=):
2041         * rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
2042
2043         * rendering/style/RenderStyle.h: Use LineClampValue.
2044         (WebCore::InheritedFlags::lineClamp):
2045         (WebCore::InheritedFlags::setLineClamp):
2046         (WebCore::InheritedFlags::initialLineClamp):
2047         * rendering/style/StyleRareNonInheritedData.h:
2048
2049 2009-11-14  Eric Carlson  <eric.carlson@apple.com>
2050
2051         Reviewed by Oliver Hunt.
2052
2053         <rdar://problem/7287487>
2054         Do not use QuickTime version to detect media controller theme
2055
2056         * WebCore.base.exp: Export wkMediaControllerThemeAvailable
2057         * platform/mac/WebCoreSystemInterface.h: Ditto.
2058         * platform/mac/WebCoreSystemInterface.mm: Ditto.
2059
2060         * rendering/RenderThemeMac.mm:
2061         (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the
2062         QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.
2063
2064 2009-11-14  Kent Tamura  <tkent@chromium.org>
2065
2066         Reviewed by Darin Adler.
2067
2068         - Recognizes date/datetime/datetime-local/month/time/week types of INPUT element.
2069           They have no dedicated UI and no type validation for now.
2070         - Clean up setInputType() and formControlType() of HTMLInputElement.
2071         https://bugs.webkit.org/show_bug.cgi?id=29004
2072
2073         Test: fast/forms/input-type-change3.html
2074
2075         * html/HTMLInputElement.cpp:
2076         (WebCore::HTMLInputElement::valueMissing):
2077         (WebCore::HTMLInputElement::patternMismatch):
2078         (WebCore::HTMLInputElement::tooLong):
2079         (WebCore::createTypeMap):
2080         (WebCore::HTMLInputElement::setInputType):
2081         (WebCore::createFormControlTypes):
2082         (WebCore::HTMLInputElement::formControlType):
2083         (WebCore::HTMLInputElement::saveFormControlState):
2084         (WebCore::HTMLInputElement::restoreFormControlState):
2085         (WebCore::HTMLInputElement::accessKeyAction):
2086         (WebCore::HTMLInputElement::rendererIsNeeded):
2087         (WebCore::HTMLInputElement::createRenderer):
2088         (WebCore::HTMLInputElement::appendFormData):
2089         (WebCore::HTMLInputElement::isTextField):
2090         (WebCore::HTMLInputElement::valueWithDefault):
2091         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
2092         (WebCore::HTMLInputElement::defaultEventHandler):
2093         (WebCore::HTMLInputElement::isRequiredFormControl):
2094         (WebCore::HTMLInputElement::dataList):
2095         * html/HTMLInputElement.h:
2096         (WebCore::HTMLInputElement::):
2097
2098 2009-11-13  Chris Fleizach  <cfleizach@apple.com>
2099
2100         Reviewed by Darin Adler.
2101
2102         WAI-ARIA: checkbox does not determine its label from text content
2103         https://bugs.webkit.org/show_bug.cgi?id=31456
2104
2105         Test: accessibility/aria-checkbox-text.html
2106
2107         * accessibility/AccessibilityRenderObject.cpp:
2108         (WebCore::AccessibilityRenderObject::title):
2109
2110 2009-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2111
2112         Unreviewed, build fix.
2113
2114         [Chromium] Fix build to catch up with http://trac.webkit.org/changeset/50973.
2115         This is just enough changes to unbreak the port.
2116
2117         * bindings/v8/ScriptController.cpp:
2118         (WebCore::mainThreadNormalWorld):
2119         * bindings/v8/V8Proxy.cpp:
2120         (WebCore::V8Proxy::initContextIfNeeded):
2121         * loader/FrameLoaderClient.h:
2122
2123 2009-11-13  Aaron Boodman  <aa@chromium.org>
2124
2125         Unreviewed fix for Chromium build.
2126
2127         * loader/FrameLoaderClient.h:
2128         (WebCore::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
2129         Provide an empty implementation of this method because I don't know
2130         what it is supposed to do on Chromium.
2131
2132 2009-11-13  Aaron Boodman  <aa@chromium.org>
2133
2134         Unreviewed fix for Chromium build.
2135
2136         * loader/FrameLoader.h: Make dispatchDidClearWindowObjectsInAllWorlds()
2137         public, as Chromium's V8Proxy calls it.
2138
2139 2009-11-13  Aaron Boodman  <aa@chromium.org>
2140
2141         Unreviewed fix to Chromium build.
2142
2143         * bindings/v8/ScriptController.cpp:
2144         (WebCore::ScriptController::getAllWorlds):
2145
2146 2009-11-13  Aaron Boodman  <aa@chromium.org>
2147
2148         Unreviewed fix for Chromium build.
2149
2150         * platform/text/TextBoundaries.cpp: Use longer path to refer to Unicode.h.
2151
2152 2009-11-13  Adam Barth  <abarth@webkit.org>
2153
2154         Unreviewed partial build fix for Chromium.  Should fix failure #4.
2155
2156         * bindings/v8/ScriptController.cpp:
2157         (WebCore::ScriptController::getAllWorlds):
2158         * bindings/v8/ScriptController.h:
2159         * bindings/v8/V8Proxy.cpp:
2160         (WebCore::V8Proxy::initContextIfNeeded):
2161
2162 2009-11-13  Adam Barth  <abarth@webkit.org>
2163
2164         Unreviewed partial build fix for Chromium.
2165
2166         * bindings/v8/ScriptController.h:
2167         (WebCore::ScriptController::getAllWorlds):
2168
2169 2009-11-13  Eric Seidel  <eric@webkit.org>
2170
2171         No review, build fix only.
2172
2173         Fix Windows and Chromium builds after http://trac.webkit.org/changeset/50977.
2174
2175         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
2176         https://bugs.webkit.org/show_bug.cgi?id=31468
2177
2178         * WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
2179         * WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries
2180
2181 2009-11-12  Jeremy Orlow  <jorlow@chromium.org>
2182
2183         Reviewed by Dmitry Titov.
2184
2185         LocalStorage quota should include key sizes in its count
2186         https://bugs.webkit.org/show_bug.cgi?id=31451
2187
2188         * storage/StorageMap.cpp:
2189         (WebCore::StorageMap::setItem):
2190             Count keys in the quota when adding a new item.
2191         (WebCore::StorageMap::removeItem):
2192             Remove the key's length from the quota if we're removing the item.
2193         (WebCore::StorageMap::importItem):
2194             Assume that we're adding things for the first time.
2195             Count keys in the quota.
2196
2197 2009-11-13  Dominik Röttsches  <dominik.roettsches@access-company.com>
2198
2199         Reviewed by Eric Seidel.
2200
2201         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
2202         https://bugs.webkit.org/show_bug.cgi?id=31468
2203
2204         Moving TextBoundariesICU.cpp to TextBoundaries.cpp
2205         by removing the direct ICU dependency and replacing it
2206         with WTF functions and WebCore's own TextBreakIterator
2207         abstractions.
2208
2209         * GNUmakefile.am:
2210         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
2211         * platform/text/TextBoundaries.cpp: Added.
2212         (WebCore::findNextWordFromIndex):
2213         (WebCore::findWordBoundary):
2214         * platform/text/TextBoundariesICU.cpp: Removed.
2215         * platform/text/TextBreakIterator.h:
2216         * platform/text/TextBreakIteratorICU.cpp:
2217         (WebCore::textBreakLast):
2218         (WebCore::textBreakPrevious):
2219
2220 2009-11-13  Shinichiro Hamaji  <hamaji@chromium.org>
2221
2222         Reviewed by Darin Adler.
2223
2224         WebCore::externalRepresentation should update layout before getting render object
2225         https://bugs.webkit.org/show_bug.cgi?id=31459
2226
2227         * rendering/RenderTreeAsText.cpp:
2228         (WebCore::externalRepresentation):
2229
2230 2009-11-13  Adam Roben  <aroben@apple.com>
2231
2232         Tell FrameLoaderClient when window objects in isolated worlds are
2233         cleared
2234
2235         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2236         window objects in isolated worlds are cleared
2237
2238         Test: http/tests/security/isolatedWorld/didClearWindowObject.html
2239
2240         Reviewed by Dave Hyatt.
2241
2242         * bindings/js/JSDOMBinding.h:
2243         (WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
2244         worlds in m_worldSet to the passed-in Vector.
2245
2246         * bindings/js/ScriptController.cpp:
2247         (WebCore::ScriptController::getAllWorlds): Added. Calls through to
2248         WebCoreJSClientData.
2249         (WebCore::ScriptController::initScript): Changed to call
2250         FrameLoader::dispatchDidClearWindowObjectInWorld.
2251
2252         * bindings/js/ScriptController.h: Added getAllWorlds.
2253
2254         * loader/EmptyClients.h:
2255         (WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
2256         Updated for FrameLoaderClient change.
2257
2258         * loader/FrameLoader.cpp:
2259         (WebCore::FrameLoader::receivedFirstData):
2260         (WebCore::FrameLoader::begin):
2261         Changed to call dispatchDidClearWindowObjectsInAllWorlds.
2262
2263         (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
2264         Added. Retrieves all the worlds, then calls through to
2265         dispatchDidClearWindowObjectInWorld for each one.
2266         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
2267         dispatchWindowObjectAvailable. Calls up to the client, then, if the
2268         world is the mainThreadNormalWorld(), tells the Inspector about it,
2269         too.
2270
2271         * loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with
2272         dispatchDidClearWindowObjectInWorld. Added
2273         dispatchDidClearWindowObjectsInAllWorlds.
2274
2275         * loader/FrameLoaderClient.h: Replaced windowObjectCleared with
2276         dispatchDidClearWindowObjectForWorld.
2277
2278 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
2279
2280         Reviewed by Dimitri Glazkov.
2281
2282         [V8] Fix SVG context assignment for pod types.
2283         https://bugs.webkit.org/show_bug.cgi?id=31497
2284
2285         I broke this in r50958.
2286
2287         Tested by svg/custom/viewport-update2.svg.
2288
2289         * bindings/scripts/CodeGeneratorV8.pm:
2290
2291 2009-11-13  Andrei Popescu  <andreip@google.com>
2292
2293         Reviewed by Dmitry Titov.
2294
2295         Bring the platform/android files inline with Android 2.0
2296         https://bugs.webkit.org/show_bug.cgi?id=31423
2297
2298         No new tests required: these are all Android-specific files.
2299
2300         * platform/android/ClipboardAndroid.cpp:
2301         (WebCore::ClipboardAndroid::files):
2302         * platform/android/ClipboardAndroid.h:
2303         * platform/android/FileChooserAndroid.cpp:
2304         (WebCore::FileChooser::basenameForWidth):
2305         (WebCore::fileButtonChooseFileLabel):
2306         * platform/android/KeyEventAndroid.cpp:
2307         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2308         * platform/android/LocalizedStringsAndroid.cpp:
2309         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
2310         (WebCore::contextMenuItemTagDownloadLinkToDisk):
2311         (WebCore::contextMenuItemTagCopyLinkToClipboard):
2312         (WebCore::contextMenuItemTagOpenImageInNewWindow):
2313         (WebCore::contextMenuItemTagDownloadImageToDisk):
2314         (WebCore::contextMenuItemTagCopyImageToClipboard):
2315         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
2316         (WebCore::contextMenuItemTagCopy):
2317         (WebCore::contextMenuItemTagGoBack):
2318         (WebCore::contextMenuItemTagGoForward):
2319         (WebCore::contextMenuItemTagStop):
2320         (WebCore::contextMenuItemTagReload):
2321         (WebCore::contextMenuItemTagCut):
2322         (WebCore::contextMenuItemTagPaste):
2323         (WebCore::contextMenuItemTagNoGuessesFound):
2324         (WebCore::contextMenuItemTagIgnoreSpelling):
2325         (WebCore::contextMenuItemTagLearnSpelling):
2326         (WebCore::contextMenuItemTagSearchWeb):
2327         (WebCore::contextMenuItemTagLookUpInDictionary):
2328         (WebCore::contextMenuItemTagOpenLink):
2329         (WebCore::contextMenuItemTagIgnoreGrammar):
2330         (WebCore::contextMenuItemTagSpellingMenu):
2331         (WebCore::contextMenuItemTagShowSpellingPanel):
2332         (WebCore::contextMenuItemTagCheckSpelling):
2333         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
2334         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2335         (WebCore::contextMenuItemTagFontMenu):
2336         (WebCore::contextMenuItemTagBold):
2337         (WebCore::contextMenuItemTagItalic):
2338         (WebCore::contextMenuItemTagUnderline):
2339         (WebCore::contextMenuItemTagOutline):
2340         (WebCore::contextMenuItemTagWritingDirectionMenu):
2341         (WebCore::contextMenuItemTagTextDirectionMenu):
2342         (WebCore::contextMenuItemTagDefaultDirection):
2343         (WebCore::contextMenuItemTagLeftToRight):
2344         (WebCore::contextMenuItemTagRightToLeft):
2345         (WebCore::mediaElementLoadingStateText):
2346         (WebCore::mediaElementLiveBroadcastStateText):
2347         (WebCore::searchableIndexIntroduction):
2348         (WebCore::resetButtonDefaultLabel):
2349         (WebCore::submitButtonDefaultLabel):
2350         (WebCore::inputElementAltText):
2351         * platform/android/RenderThemeAndroid.cpp:
2352         (WebCore::RenderTheme::themeForPage):
2353         (WebCore::RenderThemeAndroid::baselinePosition):
2354         (WebCore::RenderThemeAndroid::paintButton):
2355         (WebCore::adjustMenuListStyleCommon):
2356         (WebCore::RenderThemeAndroid::paintCombo):
2357         * platform/android/ScreenAndroid.cpp:
2358         * platform/android/ScrollViewAndroid.cpp:
2359         (WebCore::ScrollView::platformOffscreenContentRectangle):
2360         * platform/android/TemporaryLinkStubs.cpp:
2361         (JSC::Bindings::dispatchJNICall):
2362         * platform/android/WidgetAndroid.cpp:
2363         (WebCore::Widget::setFrameRect):
2364
2365 2009-11-13  Norbert Leser  <norbert.leser&nokia.com>
2366
2367         Reviewed by Eric Seidel.
2368
2369         Added macros for USERINCLUDE paths within symbian blocks
2370         to guarantee inclusion of respective header files from local path
2371         first (to avoid clashes with same names of header files in system include path).
2372
2373         * WebCore.pro:
2374
2375 2009-11-13  Hironori Bono  <hbono@chromium.org>
2376
2377         Reviewed by Oliver Hunt.
2378
2379         Implement composition events introduced in DOM Level 3.
2380         This change adds a new IDL which defines the composition events, adds a class which
2381         implements the composition events, and sends the composition events according to
2382         the specification.
2383         https://bugs.webkit.org/show_bug.cgi?id=26310
2384
2385         Test: fast/events/ime-composition-events-001.html
2386
2387         * DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
2388         * GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
2389         * WebCore.gypi: ditto.
2390         * WebCore.pro: ditto
2391         * WebCore.vcproj/WebCore.vcproj: ditto.
2392         * WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
2393         * WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
2394         * bindings/js/JSEventCustom.cpp:
2395         (WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
2396         * bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
2397         * bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
2398         * bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
2399         (WebCore::V8DOMWrapper::convertEventToV8Object):
2400         * bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
2401         * bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
2402         * dom/CompositionEvent.cpp: Implements the CompositionEvent class.
2403         (WebCore::CompositionEvent::CompositionEvent):
2404         (WebCore::CompositionEvent::~CompositionEvent):
2405         (WebCore::CompositionEvent::initCompositionEvent):
2406         (WebCore::CompositionEvent::isCompositionEvent):
2407         * dom/CompositionEvent.h: Declares the CompositionEvent class.
2408         (WebCore::CompositionEvent::create):
2409         (WebCore::CompositionEvent::data):
2410         * dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
2411         * dom/Event.cpp:
2412         (WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
2413         * dom/Event.h:
2414         * dom/EventNames.h: Added composition{start,update,end} to eventNames.
2415         * editing/Editor.cpp:
2416         (WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
2417         (WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
2418
2419 2009-11-13  Jens Alfke  <snej@chromium.org>
2420
2421         Reviewed by Dimitri Glazkov.
2422
2423         Fix a link error in unofficial GCC 4.4 builds on Linux.
2424         https://bugs.webkit.org/show_bug.cgi?id=31477
2425
2426         * bindings/v8/V8Binding.cpp:  Add explicit instantiations of v8StringToWebCoreString template.
2427
2428 2009-11-13  Eric Seidel  <eric@webkit.org>
2429
2430         No review, build fix only.
2431
2432         Fix Debug build after http://trac.webkit.org/changeset/50960.
2433
2434         The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
2435         https://bugs.webkit.org/show_bug.cgi?id=31213
2436
2437         * rendering/CounterNode.cpp:
2438         (WebCore::showTreeAndMark):
2439         * rendering/RenderCounter.cpp:
2440         (WebCore::destroyCounterNodeChildren):
2441
2442 2009-11-13  Dirk Schulze  <krit@webkit.org>
2443
2444         Reviewed by Gustavo Noronha.
2445
2446         [CAIRO] shadow support for Canvas and SVG
2447         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2448
2449         We currently fill a path with solid color instead of filling
2450         a clipping path. This causes problems on some composite operators,
2451         since Cairo modifies the area outside the path.
2452         This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
2453
2454         Thanks to Benjamin Otte for tracking the bug down.
2455
2456         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2457         (WebCore::setPlatformFill):
2458
2459 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
2460
2461         Reviewed by Dimitri Glazkov.
2462
2463         Adding Chromium's DatabaseTracker implementation.
2464
2465         https://bugs.webkit.org/show_bug.cgi?id=31440
2466
2467         * WebCore.gyp/WebCore.gyp:
2468         * WebCore.gypi:
2469         * storage/DatabaseTracker.h:
2470         * storage/chromium/DatabaseTrackerChromium.cpp:
2471         (WebCore::DatabaseTracker::fullPathForDatabase):
2472         (WebCore::DatabaseTracker::getMaxSizeForDatabase):
2473         * storage/chromium/QuotaTracker.cpp:
2474         (WebCore::QuotaTracker::updateDatabaseSize):
2475         * storage/chromium/QuotaTracker.h:
2476
2477 2009-11-13  Carol Szabo  <carol.szabo@nokia.com>
2478
2479         Reviewed by Darin Adler.
2480
2481         The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
2482         https://bugs.webkit.org/show_bug.cgi?id=31213
2483         Added tree navigation methods that permit full implementation of CSS2.1
2484         counter feature without using recursion proportional to the counter
2485         tree depth.
2486         No new tests because I did not find any bug that is fixed by this
2487         commit yet, this just reduces the size of the patch for 11031 and
2488         helps respond to some concerns regarding that patch.
2489
2490         * rendering/CounterNode.cpp:
2491         (WebCore::CounterNode::CounterNode):
2492
2493         (WebCore::CounterNode::nextInPreOrderAfterChildren):
2494         (WebCore::CounterNode::nextInPreOrder):
2495         Added to support non-recursive tree traversal necessary for
2496         efficient full implementation of CSS2.1 counters.
2497
2498         (WebCore::CounterNode::lastDescendant):
2499         (WebCore::CounterNode::previousInPreOrder):
2500         Moved this methods such that they occupy a place similar to that of
2501         identically named methods on the render tree. This allows for their
2502         broader use needed in full implementation of CSS2.1 counters.
2503
2504         (WebCore::CounterNode::resetRenderer):
2505         (WebCore::CounterNode::resetRenderers):
2506         (WebCore::CounterNode::recount):
2507         (WebCore::CounterNode::insertAfter):
2508         (WebCore::CounterNode::removeChild):
2509         Changed such that insertion/removal of a counter, triggers not only
2510         recalculation of PrefixWidths, but also reassesment of values in
2511         counter nodes. This is the basis full implementation of CSS2.1
2512         counters. It does not change current behavior by much because of
2513         changes needed to the recalculation algorithm, but those are comming
2514         in the patch for 11031.
2515         (WebCore::showTreeAndMark):
2516         * rendering/CounterNode.h:
2517         * rendering/RenderCounter.cpp:
2518         (WebCore::counter):
2519         Only changed argument type to prepare for implementation of Darin
2520         Adler's recommendation for the patch to 11031.
2521
2522         (WebCore::RenderCounter::invalidate):
2523         (WebCore::destroyCounterNodeChildren):
2524         (WebCore::RenderCounter::destroyCounterNodes):
2525         * rendering/RenderCounter.h:
2526         * rendering/RenderObjectChildList.cpp:
2527         (WebCore::invalidateCountersInContainer):
2528         (WebCore::RenderObjectChildList::invalidateCounters):
2529         * rendering/RenderObjectChildList.h:
2530         Added the ability to restrict invalidation to counters with a given
2531         identifier.
2532         Also invalidated counters that are on the child container itself
2533         which were missed by the previous algorithm, but were a valid case.
2534
2535 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
2536
2537         Reviewed by Dimitri Glazkov.
2538
2539         [V8] Protect SVG animated properties from destruction in bindings.
2540         https://bugs.webkit.org/show_bug.cgi?id=31474
2541
2542         See http://crbug.com/26719.
2543
2544         Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
2545         under Valgrind.
2546
2547         Made sure we keep a reference to SVG properties while setting a
2548         context:
2549         * bindings/scripts/CodeGeneratorV8.pm:
2550         * bindings/v8/V8Proxy.h:
2551         (WebCore::V8Proxy::withSVGContext):
2552
2553 2009-11-13  Brent Fulgham  <bfulgham@webkit.org>
2554
2555         Reviewed by Alexey Proskuryakov.
2556
2557         [CAIRO] shadow support for Canvas and SVG.
2558         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2559
2560         Incorporate Benjamin Otte's recommendations to avoid
2561         a buffer overrun, and small performance improvement.
2562
2563         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2564         (WebCore::copyContextProperties): Correctly size output
2565          storage for cairo_get_dash to avoid buffer overrun.
2566         (WebCore::drawPathShadow): Prefer cairo_fill_extents
2567          to slower cairo_stroke_extents when not drawing shadows.
2568
2569 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
2570
2571         Reviewed by Dimitri Glazkov.
2572
2573         Do not register Chromium's HTML5 DB VFS as the default
2574         VFS. Otherwise, other sqlite DB users in the same process will
2575         stop working.
2576
2577         https://bugs.webkit.org/show_bug.cgi?id=31462
2578
2579         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
2580         (WebCore::SQLiteFileSystem::openDatabase):
2581         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
2582         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
2583         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
2584         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
2585
2586 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
2587
2588         Windows build fix
2589
2590         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2591         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
2592         avoiding a sign mismatch warning.
2593
2594 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
2595
2596         Release build fix.
2597
2598         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2599         (WebCore::SocketStreamHandle::readStreamCallback):
2600         (WebCore::SocketStreamHandle::writeStreamCallback):
2601         Use ASSERT_UNUSED for unused stream parameter.
2602
2603 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
2604
2605         Reviewed by Darin Adler.
2606
2607         https://bugs.webkit.org/show_bug.cgi?id=31441
2608         Implement SocketStreamHandleCFNet
2609
2610         Existing WebSocket tests now pass on Mac. No proxy support yet.
2611
2612         * platform/network/SocketStreamHandleClient.h:
2613         * platform/network/cf/SocketStreamHandle.h:
2614         (WebCore::SocketStreamHandle::shouldUseSSL):
2615         (WebCore::SocketStreamHandle::refAuthenticationClient):
2616         (WebCore::SocketStreamHandle::derefAuthenticationClient):
2617         (WebCore::SocketStreamHandle::):
2618         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2619         (WebCore::SocketStreamHandle::SocketStreamHandle):
2620         (WebCore::SocketStreamHandle::chooseProxy):
2621         (WebCore::SocketStreamHandle::createStreams):
2622         (WebCore::SocketStreamHandle::copyCFStreamDescription):
2623         (WebCore::SocketStreamHandle::readStreamCallback):
2624         (WebCore::SocketStreamHandle::writeStreamCallback):
2625         (WebCore::SocketStreamHandle::~SocketStreamHandle):
2626         (WebCore::SocketStreamHandle::platformSend):
2627         (WebCore::SocketStreamHandle::platformClose):
2628         (WebCore::SocketStreamHandle::receivedCredential):
2629         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
2630         (WebCore::SocketStreamHandle::receivedCancellation):
2631
2632 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
2633
2634         Reviewed by Timothy Hatcher.
2635
2636         Web Inspector: preload status bar button glyphs
2637         in order to prevent them from flickering (take 2).
2638
2639         https://bugs.webkit.org/show_bug.cgi?id=31439
2640
2641         * inspector/front-end/inspector.js:
2642         (preloadImages):
2643
2644 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
2645
2646         Reviewed by Adam Barth.
2647
2648         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
2649         Rolling back r50890.
2650
2651         https://bugs.webkit.org/show_bug.cgi?id=31467
2652
2653         * bindings/v8/V8Proxy.cpp:
2654         (WebCore::V8Proxy::canAccessPrivate):
2655
2656 2009-11-13  Dirk Schulze  <krit@webkit.org>
2657
2658         Reviewed by Gustavo Noronha.
2659
2660         [CAIRO] shadow support for Canvas and SVG
2661         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2662
2663         This is the fix of a regression, caused by the shadow patch
2664         from the bug above. Reinserted the save and restore calls
2665         that were accidently removed by the previous patch.
2666
2667         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2668         (WebCore::setPlatformFill):
2669         (WebCore::setPlatformStroke):
2670
2671 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
2672
2673         Not reviewed. Reverting r50908 since it makes inspector tests
2674         time out.
2675
2676         https://bugs.webkit.org/show_bug.cgi?id=31439
2677
2678         * inspector/front-end/inspector.js:
2679
2680 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
2681
2682         Reviewed by Timothy Hatcher.
2683
2684         Enable 'console.profile()' and 'console.profileEnd()'
2685         regardless of JAVASCRIPT_DEBUGGER.
2686
2687         https://bugs.webkit.org/show_bug.cgi?id=31293
2688
2689         * WebCore.gypi:
2690         * bindings/js/JSConsoleCustom.cpp:
2691         (WebCore::JSConsole::profile):
2692         (WebCore::JSConsole::profileEnd):
2693         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
2694         (WebCore::CALLBACK_FUNC_DECL):
2695         * bindings/v8/custom/V8CustomBinding.h:
2696         * page/Console.idl:
2697
2698 2009-11-12  David Levin  <levin@chromium.org>
2699
2700         Reviewed by NOBODY.
2701
2702         Chromium build fix.
2703
2704         * bindings/v8/ScriptController.h:
2705         (WebCore::ScriptController::evaluateInWorld): Add a dummy
2706          method which isn't called in chromium to make things compile.
2707
2708 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2709
2710         Reviewed by Adam Barth.
2711
2712         The document-open.html test was flaky at times. The test invokes the layout test plugin
2713         which in its destroy stream handler opens a new document. This basically tears down the
2714         stream and the associated plugin instance, which causes a crash when the plugin stream
2715         dereferences an invalid m_client pointer which points to the PluginView instance which
2716         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
2717         and check for the same.
2718
2719         https://bugs.webkit.org/show_bug.cgi?id=31067
2720
2721         * plugins/PluginStream.cpp:
2722         (WebCore::PluginStream::stop):
2723         (WebCore::PluginStream::destroyStream):
2724
2725 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
2726
2727         Reviewed by Dimitri Glazkov.
2728
2729         Renaming some parameters passed to DB-related methods to better
2730         indicate their purpose.
2731
2732         https://bugs.webkit.org/show_bug.cgi?id=31449
2733
2734         * platform/chromium/ChromiumBridge.h:
2735
2736 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
2737
2738         Reviewed by Dan Bernstein.
2739
2740         Transformed reflected elements are clipped inside element with opacity
2741         https://bugs.webkit.org/show_bug.cgi?id=30957
2742
2743         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
2744         each clip rect into painting space before taking the unions. This, however, did not work
2745         correctly with combinations of reflections and transforms. Fixed by unioning the
2746         clipRect and mapping through transforms along the way.
2747
2748         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
2749         where the transparency layers are.
2750
2751         Test: fast/reflections/opacity-reflection-transform.html
2752
2753         * rendering/RenderLayer.cpp:
2754         (WebCore::expandClipRectForDescendantsAndReflection):
2755         (WebCore::transparencyClipBox):
2756         (WebCore::RenderLayer::beginTransparencyLayers):
2757
2758 2009-11-12  Adam Barth  <abarth@webkit.org>
2759
2760         Reviewed by Darin Fisher.
2761
2762         Improve SecurityOrigin::toString comment
2763         https://bugs.webkit.org/show_bug.cgi?id=31041
2764
2765         * page/SecurityOrigin.h:
2766
2767 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
2768
2769         Reviewed by Darin Adler.
2770
2771         externalRepresentation should take Frame as the argument
2772         https://bugs.webkit.org/show_bug.cgi?id=31393
2773
2774         No new tests as this is just a refactoring.
2775
2776         * WebCore.base.exp:
2777         * rendering/RenderTreeAsText.cpp:
2778         (WebCore::externalRepresentation):
2779         * rendering/RenderTreeAsText.h:
2780
2781 2009-11-12  Ben Murdoch  <benm@google.com>
2782
2783         Reviewed by Dimitri Glazkov.
2784
2785         [Android] The Android specific files in page/Android are out of date.
2786         https://bugs.webkit.org/show_bug.cgi?id=31437
2787
2788         No tests required.
2789
2790         * page/android/DragControllerAndroid.cpp:
2791         (WebCore::DragController::dragOperation): Added.
2792         (WebCore::DragController::cleanupAfterSystemDrag):
2793         * page/android/EventHandlerAndroid.cpp:
2794         (WebCore::EventHandler::accessKeyModifiers): Added.
2795         * page/android/InspectorControllerAndroid.cpp: Removed.
2796
2797 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
2798
2799         Reviewed by Simon Fraser.
2800
2801         [CAIRO] shadow support for Canvas and SVG.
2802         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2803
2804         Implement Canvas/SVG shadow support for Cairo.  This patch
2805         uses the filter code from SVG Filters.  That means that it is
2806         necessary to activate filters to see the shadows.
2807
2808         Test: fast/canvas/canvas-shadow.html
2809
2810         * GNUmakefile.am:
2811         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
2812         * platform/graphics/GraphicsContext.h:
2813         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2814         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
2815         (WebCore::setPlatformFill):
2816         (WebCore::setPlatformStroke):
2817         (WebCore::copyContextProperties):
2818         (WebCore::drawPathShadow):
2819         (WebCore::GraphicsContext::fillPath):
2820         (WebCore::GraphicsContext::strokePath):
2821         (WebCore::GraphicsContext::drawPath):
2822         (WebCore::GraphicsContext::setPlatformShadow):
2823         (WebCore::GraphicsContext::createPlatformShadow):
2824         * platform/graphics/cairo/ImageCairo.cpp:
2825         (WebCore::BitmapImage::draw): Add filter effect.
2826         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
2827         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
2828         * platform/graphics/filters/ImageBufferFilter.h: Added.
2829         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
2830         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
2831
2832 2009-11-12  Dmitry Titov  <dimich@chromium.org>
2833
2834         Reviewed by Alexey Proskuryakov.
2835
2836         Add postTaskToMainThread to ScriptExecutionContext.
2837         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
2838         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
2839         contexts that live on the main thread.
2840         https://bugs.webkit.org/show_bug.cgi?id=31427
2841
2842         No new tests - simply moving the code.
2843
2844         * dom/Document.cpp:
2845         (WebCore::Document::postTask):
2846         * dom/ScriptExecutionContext.cpp:
2847         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
2848         (WebCore::ScriptExecutionContextTaskTimer::fired):
2849         (WebCore::PerformTaskData::PerformTaskData):
2850         (WebCore::PerformTaskData::performTask):
2851         (WebCore::ScriptExecutionContext::postTaskToMainThread):
2852         * dom/ScriptExecutionContext.h:
2853
2854 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
2855
2856         Reviewed by Darin Adler.
2857
2858         Fix crash when removing compositing layers when GC is enabled
2859         https://bugs.webkit.org/show_bug.cgi?id=31429
2860
2861         Workaround <rdar://problem/7390716> by special-casing the removal
2862         of all sublayers when GC is enabled.
2863
2864         * platform/graphics/mac/GraphicsLayerCA.mm:
2865         (WebCore::safeSetSublayers):
2866         (WebCore::GraphicsLayerCA::updateSublayerList):
2867         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
2868
2869 2009-11-12  Jens Alfke  <snej@chromium.org>
2870
2871         Reviewed by Dimitri Glazkov.
2872
2873         The last of the V8 binding optimizations.
2874         - Replace string-valued element accessors with a shared getter/setter function.
2875         - Change error handling flow of control to avoid extra branches and function calls.
2876         https://bugs.webkit.org/show_bug.cgi?id=31443
2877
2878         * bindings/scripts/CodeGeneratorV8.pm:
2879         * bindings/v8/V8Binding.cpp:
2880         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
2881         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
2882         * bindings/v8/V8Binding.h:
2883
2884 2009-11-12  Sam Weinig  <sam@webkit.org>
2885
2886         Reviewed by Oliver Hunt.
2887
2888         Fix for <rdar://problem/7267951>
2889         Canvas methods should reject uses of NaN and Infinity.
2890
2891         Test: fast/canvas/canvas-with-illegal-args.html
2892
2893         * html/canvas/CanvasRenderingContext2D.cpp:
2894         (WebCore::CanvasRenderingContext2D::scale):
2895         (WebCore::CanvasRenderingContext2D::rotate):
2896         (WebCore::CanvasRenderingContext2D::translate):
2897         (WebCore::CanvasRenderingContext2D::transform):
2898         (WebCore::CanvasRenderingContext2D::setTransform):
2899
2900 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
2901
2902         Reviewed by Timothy Hatcher.
2903
2904         Web Inspector: profile timeline panel, fix obvious problems.
2905
2906         https://bugs.webkit.org/show_bug.cgi?id=31432
2907
2908         * inspector/front-end/AbstractTimelinePanel.js:
2909         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
2910         * inspector/front-end/TimelinePanel.js:
2911         (WebInspector.TimelinePanel.prototype._setWindowPosition):
2912         (WebInspector.TimelineCalculator):
2913         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
2914         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
2915         (WebInspector.TimelineCalculator.prototype.reset):
2916         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
2917         (WebInspector.TimelineCalculator.prototype.formatValue):
2918         (WebInspector.TimelineGraph):
2919         (WebInspector.TimelineGraph.prototype.refresh):
2920         * inspector/front-end/utilities.js:
2921         (Element.prototype.hasStyleClass):
2922
2923 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
2924
2925         Reviewed by Timothy Hatcher.
2926
2927         Web Inspector: preload status bar button glyphs
2928         in order to prevent them from flickering.
2929
2930         https://bugs.webkit.org/show_bug.cgi?id=31439
2931
2932         * inspector/front-end/inspector.js:
2933         (preloadImages):
2934
2935 2009-11-12  Adam Roben  <aroben@apple.com>
2936
2937         Replace worldIDs with world objects
2938
2939         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2940         user scripts/stylesheets and isolated worlds
2941
2942         Reviewed by Sam Weinig.
2943
2944         Covered by existing tests.
2945
2946         * WebCore.base.exp: Update exported symbols to match what now exists
2947         and is needed by WebKit.
2948
2949         * bindings/js/ScheduledAction.cpp:
2950         (WebCore::ScheduledAction::execute): Updated for function rename.
2951
2952         * bindings/js/ScriptController.cpp: Removed code that dealt with
2953         worldIDs.
2954         (WebCore::ScriptController::createWorld): Added. Returns a new world
2955         suitable for use on the main thread.
2956         (WebCore::ScriptController::executeScriptInWorld): Renamed from
2957         executeScriptInIsolatedWorld, since this works just fine with a
2958         "normal" world.
2959
2960         * bindings/js/ScriptController.h: Added createWorld, removed functions
2961         that took worldIDs, renamed executeScriptInIsolatedWorld to
2962         executeScriptInWorld.
2963
2964         * page/Frame.cpp:
2965         (WebCore::Frame::injectUserScripts):
2966         (WebCore::Frame::injectUserScriptsForWorld):
2967         Updated for changes to UserScriptMap and ScriptController.
2968
2969         * page/Frame.h: Changed injectUserScriptsForWorld to take a
2970         DOMWrapperWorld* instead of a worldID.
2971
2972         * page/PageGroup.cpp:
2973         (WebCore::PageGroup::addUserScriptToWorld):
2974         (WebCore::PageGroup::addUserStyleSheetToWorld):
2975         (WebCore::PageGroup::removeUserScriptFromWorld):
2976         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
2977         (WebCore::PageGroup::removeUserScriptsFromWorld):
2978         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
2979         * page/PageGroup.h:
2980         Changed these functions to take a DOMWrapperWorld* instead of a
2981         worldID. Also updated for changes to UserScript and UserStyleSheet.
2982
2983         * page/UserScript.h:
2984         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
2985         never used.
2986
2987         * page/UserScriptTypes.h:
2988         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
2989         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
2990         worldID as their key type.
2991
2992
2993 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
2994
2995         Reviewed by Tim Hatcher.
2996
2997         Fixes <http://webkit.org/b/31260>.
2998         Web Inspector: Main Resources Other than HTML are mis-detected.
2999
3000         Even if the resource is a main resource, look at its CachedResource type,
3001         because it might be an image, stylesheet, or JavaScript file, and we
3002         want to show them all correctly.
3003
3004         * inspector/InspectorResource.cpp:
3005         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
3006         (WebCore::InspectorResource::type):
3007         * inspector/InspectorResource.h:
3008
3009 2009-11-12  Jens Alfke  <snej@chromium.org>
3010
3011         Reviewed by Dimitri Glazkov.
3012
3013         Table-driven setup for V8 binding template callback functions. 100k in code savings.
3014         https://bugs.webkit.org/show_bug.cgi?id=31420
3015
3016         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
3017             to call configureTemplate().
3018         * bindings/v8/V8Binding.cpp:
3019         (WebCore::configureTemplate):  New function; does all the standard configuration work.
3020         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
3021         * bindings/v8/V8Binding.h:
3022         * bindings/v8/V8Proxy.cpp:
3023         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
3024         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
3025         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
3026         * bindings/v8/V8Proxy.h:
3027
3028 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
3029
3030         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
3031
3032         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3033
3034 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
3035
3036         Reviewed by Dan Bernstein.
3037
3038         <rdar://problem/7388969> Add DOM API for fullscreen video
3039
3040         DOM API for fullscreen <video>.
3041
3042         Tests: media/media-fullscreen-inline.html
3043                media/media-fullscreen-not-in-document.html
3044
3045         * dom/EventNames.h:
3046             Add webkitbeginfullscreen and webkitendfullscreen.
3047
3048         * html/HTMLAttributeNames.in:
3049             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
3050
3051         * html/HTMLMediaElement.cpp:
3052         (WebCore::HTMLMediaElement::parseMappedAttribute):
3053             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
3054         (WebCore::HTMLMediaElement::enterFullscreen):
3055             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
3056             actually do enter fullscreen.
3057         (WebCore::HTMLMediaElement::exitFullscreen):
3058             Schedule webkitendfullscreenEvent event.
3059         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
3060         (WebCore::HTMLMediaElement::webkitExitFullScreen):
3061         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
3062         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
3063             New, access to fullscreen properties and methods.
3064
3065         * html/HTMLMediaElement.h:
3066         * html/HTMLMediaElement.idl:
3067             Declare methods needed for fullscreen API.
3068
3069         * html/HTMLVideoElement.cpp:
3070         (WebCore::HTMLVideoElement::supportsFullscreen):
3071             Return false if a movie does not have video.
3072
3073         * page/DOMWindow.h:
3074             Add webkitbeginfullscreen and webkitendfullscreen.
3075
3076 2009-11-12  Adam Barth  <abarth@webkit.org>
3077
3078         Reviewed by Dimitri Glazkov.
3079
3080         [Chromium] Sify compose button alerts error
3081         https://bugs.webkit.org/show_bug.cgi?id=31394
3082
3083         Test: http/tests/security/calling-versus-current.html
3084
3085         We're supposed to use the calling context for security checks.  In JSC
3086         land, this is the lexicalGlobalObject.
3087
3088         * bindings/v8/V8Proxy.cpp:
3089         (WebCore::V8Proxy::canAccessPrivate):
3090
3091 2009-11-12  Daniel Bates  <dbates@webkit.org>
3092
3093         Reviewed by Darin Adler.
3094
3095         https://bugs.webkit.org/show_bug.cgi?id=30291
3096
3097         Fixes an issue where the returned drop effect is incorrect when
3098         effectAllowed == "uninitialized".
3099
3100         According to section 7.9.2 of the HTML 5 spec.
3101         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
3102         when effectAllowed = "uninitialized" the resulting dropEffect should be the
3103         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
3104         other case.
3105
3106         No test cases are included because we have an existing test case from
3107         bug #24731.
3108
3109         * dom/Clipboard.cpp:
3110         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
3111
3112 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3113
3114         Reviewed by Timothy Hatcher.
3115
3116         Web Inspector: Do not highlight node on refresh.
3117
3118         https://bugs.webkit.org/show_bug.cgi?id=31419
3119
3120         * inspector/front-end/ElementsPanel.js:
3121         (WebInspector.ElementsPanel.prototype.reset):
3122
3123 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3124
3125         Reviewed by Timothy Hatcher.
3126
3127         Web Inspector: Minor timeline fixes.
3128
3129         https://bugs.webkit.org/show_bug.cgi?id=31417
3130
3131         * inspector/front-end/TimelinePanel.js:
3132         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3133         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3134         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
3135         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
3136
3137 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
3138
3139         SnowLeopard build fix.
3140
3141         Renamed initWithClient to initWithAuthenticationClient.
3142
3143         * platform/network/mac/AuthenticationMac.mm:
3144         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
3145         (WebCore::AuthenticationChallenge::setAuthenticationClient):
3146
3147 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
3148
3149         Reviewed by Darin Adler.
3150
3151         ARIA: add alert type roles
3152         https://bugs.webkit.org/show_bug.cgi?id=31392
3153
3154         Test: platform/mac/accessibility/aria-alerts.html
3155
3156         * accessibility/AccessibilityObject.h:
3157         * accessibility/AccessibilityRenderObject.cpp:
3158         * accessibility/mac/AccessibilityObjectWrapper.mm:
3159
3160 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
3161
3162         Reviewed by Darin Adler.
3163
3164         https://bugs.webkit.org/show_bug.cgi?id=31386
3165         Make Mac AuthenticationChallenge usable from cross-platform code
3166
3167         No change in behavior, so no tests.
3168
3169         * platform/network/ResourceHandle.cpp:
3170         (WebCore::ResourceHandle::clearAuthentication):
3171         * platform/network/ResourceHandleInternal.h:
3172         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
3173         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
3174         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
3175         is identical.
3176
3177         * platform/network/cf/AuthenticationChallenge.h:
3178         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
3179         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
3180
3181         * platform/network/cf/ResourceHandleCFNet.cpp:
3182         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
3183         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
3184         be already set.
3185
3186         * platform/network/mac/AuthenticationChallenge.h:
3187         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
3188         best of my understanding.
3189         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
3190         confusion with "mac" and "web" challenges in ResourceHandleInternal.
3191
3192         * platform/network/mac/AuthenticationMac.mm:
3193         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
3194         making it possible to use the latter with NSURLAuthenticationChallenge.
3195         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
3196         m_nsChallenge renaming.
3197         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
3198         set it as sender (or unset, if client is null).
3199
3200         * platform/network/mac/ResourceHandleMac.mm:
3201         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
3202         authentication challenge sender.
3203         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
3204         authentication sheet.
3205         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
3206         using the new setAuthenticationClient() method.
3207         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
3208         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
3209         the original Mac one, not the one we created for use with authentication sheet. I don't
3210         know when a connection would cancel authentication in practice, so I haven't tested this.
3211
3212 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3213
3214         Reviewed by Timothy Hatcher.
3215
3216         Web Inspector: breakpoint sidebar entries should allow click over entire list item
3217         https://bugs.webkit.org/show_bug.cgi?id=31411
3218
3219         No new tests; no new functionality, small usability change.
3220
3221         * inspector/front-end/BreakpointsSidebarPane.js:
3222         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
3223         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
3224
3225 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3226
3227         Reviewed by Timothy Hatcher.
3228
3229         Web Inspector: breakpoints in named evals are not restored after a reload
3230         https://bugs.webkit.org/show_bug.cgi?id=31375
3231
3232         Manual test added
3233
3234         * inspector/front-end/ScriptsPanel.js:
3235         (WebInspector.ScriptsPanel.prototype.addScript):
3236         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
3237
3238 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
3239
3240         Reviewed by Kenneth Rohde Christiansen.
3241
3242         Custom printing shrink factors
3243         https://bugs.webkit.org/show_bug.cgi?id=29042
3244
3245         This reverts commit r49769. The public API for this needs to be reviewed
3246         before its inclusion in Qt.
3247
3248         * page/PrintContext.cpp:
3249         (WebCore::PrintContext::begin):
3250         * page/Settings.cpp:
3251         (WebCore::Settings::Settings):
3252         * page/Settings.h:
3253
3254 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
3255
3256         Reviewed by Pavel Feldman.
3257
3258         Web Inspector: Resource errors/warnings not shown in the Resource tree.
3259
3260         Error/Warning bubbles are not displayed next to the resource in the
3261         Resources panel if those occur before the resource is attached to the tree.
3262         https://bugs.webkit.org/show_bug.cgi?id=31404
3263
3264         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
3265
3266         * inspector/front-end/AbstractTimelinePanel.js:
3267         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3268         * inspector/front-end/ResourcesPanel.js:
3269         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
3270
3271 2009-11-12  Philippe Normand  <pnormand@igalia.com>
3272
3273         Reviewed by Jan Alonzo.
3274
3275         https://bugs.webkit.org/show_bug.cgi?id=31047
3276         [GTK] Failing test media/video-played-ranges-1.html
3277
3278         Follow-up of r50726, don't block the UI thread when calling
3279         gst_element_get_state(). Also fixed a compilation warning and some
3280         static casts.
3281
3282         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3283         (WebCore::playbackPosition):
3284         (WebCore::MediaPlayerPrivate::seek):
3285         (WebCore::MediaPlayerPrivate::setRate):
3286
3287 2009-11-12  Philippe Normand  <pnormand@igalia.com>
3288
3289         Reviewed by Jan Alonzo.
3290
3291         https://bugs.webkit.org/show_bug.cgi?id=31047
3292         [GTK] Failing test media/video-played-ranges-1.html
3293
3294         don't pause pipeline if already paused, same for play()
3295
3296         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3297         (WebCore::MediaPlayerPrivate::play):
3298         (WebCore::MediaPlayerPrivate::pause):
3299
3300 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
3301
3302         Reviewed by David Levin.
3303
3304         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
3305         Chromium too.
3306         https://bugs.webkit.org/show_bug.cgi?id=31292
3307
3308         No new tests. (Corresponding test for Gtk+ is
3309         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
3310
3311         * page/EventHandler.cpp:
3312         * page/chromium/EventHandlerChromium.cpp:
3313
3314 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
3315
3316         Reviewed by Eric Seidel.
3317
3318         Prevent text inside a multi-column block from being split into columns.
3319
3320         If the tentative height of a multi-column block was too small, we need to
3321         expand the block height and try to layout again, in order to prevent text
3322         from being split into different columns.
3323
3324         CSS Multicolumn text is split awkwardly
3325         https://bugs.webkit.org/show_bug.cgi?id=22249
3326
3327         Test: fast/multicol/single-line.html
3328
3329         * rendering/RenderBlock.cpp:
3330         (WebCore::RenderBlock::layoutColumns):
3331         * rendering/RenderBlock.h:
3332         * rendering/RenderLineBoxList.cpp:
3333         (WebCore::RenderLineBoxList::paint):
3334         * rendering/RenderView.h:
3335         (WebCore::RenderView::setTruncatedAt):
3336         (WebCore::RenderView::setMinimumColumnHeight):
3337         (WebCore::RenderView::minimumColumnHeight):
3338
3339 2009-11-11  Kent Tamura  <tkent@chromium.org>
3340
3341         Reviewed by Darin Adler.
3342
3343         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
3344         https://bugs.webkit.org/show_bug.cgi?id=31195
3345
3346         Test: fast/forms/input-file-re-render.html
3347
3348         * rendering/RenderFileUploadControl.cpp:
3349         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
3350
3351 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
3352
3353         Reviewed by Dimitri Glazkov.
3354
3355         Fixing Chromium's POSIX VFS implementation, by adding the required
3356         "used file descriptors" logic.
3357
3358         https://bugs.webkit.org/show_bug.cgi?id=31275
3359
3360         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3361
3362 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
3363
3364         Reviewed by Oliver Hunt.
3365
3366         need to implement aria tree roles
3367         https://bugs.webkit.org/show_bug.cgi?id=31284
3368
3369         Tests: platform/mac/accessibility/aria-multiselectable.html
3370                platform/mac/accessibility/aria-tree.html
3371
3372         * accessibility/AccessibilityList.cpp:
3373         (WebCore::AccessibilityList::accessibilityIsIgnored):
3374         * accessibility/AccessibilityObject.cpp:
3375         (WebCore::AccessibilityObject::ariaTreeRows):
3376         (WebCore::AccessibilityObject::ariaTreeItemContent):
3377         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
3378         * accessibility/AccessibilityObject.h:
3379         (WebCore::):
3380         (WebCore::AccessibilityObject::isTree):
3381         (WebCore::AccessibilityObject::isTreeItem):
3382         (WebCore::AccessibilityObject::setIsExpanded):
3383         (WebCore::AccessibilityObject::canSetExpandedAttribute):
3384         (WebCore::AccessibilityObject::hierarchicalLevel):
3385         (WebCore::AccessibilityObject::setSelectedRows):
3386         (WebCore::AccessibilityObject::performDefaultAction):
3387         * accessibility/AccessibilityRenderObject.cpp:
3388         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
3389         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
3390         (WebCore::AccessibilityRenderObject::isExpanded):
3391         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
3392         (WebCore::AccessibilityRenderObject::elementAttributeValue):
3393         (WebCore::AccessibilityRenderObject::setIsExpanded):
3394         (WebCore::AccessibilityRenderObject::isSelected):
3395         (WebCore::AccessibilityRenderObject::setSelected):
3396         (WebCore::AccessibilityRenderObject::setSelectedRows):
3397         (WebCore::createARIARoleMap):
3398         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
3399         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
3400         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
3401         (WebCore::AccessibilityRenderObject::selectedChildren):
3402         * accessibility/AccessibilityRenderObject.h:
3403         * accessibility/mac/AccessibilityObjectMac.mm:
3404         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
3405         * accessibility/mac/AccessibilityObjectWrapper.mm:
3406         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
3407         (RoleEntry::):
3408         (-[AccessibilityObjectWrapper subrole]):
3409         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
3410         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
3411         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
3412         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
3413         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
3414         * html/HTMLAttributeNames.in:
3415
3416 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
3417
3418         Build fix after @r50760 with ENABLE_FILTERS.
3419
3420         * platform/graphics/filters/SourceAlpha.cpp:
3421         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
3422         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
3423           to fillRect.
3424
3425 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
3426
3427         Reviewed by Alexey Proskuryakov.
3428
3429         Fix WebSocket frame parser of frame_type with high-order bit set.
3430         https://bugs.webkit.org/show_bug.cgi?id=30668
3431
3432         If buffer is smaller than frame's length, it should break the loop
3433         instead of reading next byte.
3434
3435         Tests: websocket/tests/frame-length-longer-than-buffer.html
3436                websocket/tests/frame-length-skip.html
3437
3438         * websockets/WebSocketChannel.cpp:
3439         (WebCore::WebSocketChannel::didReceiveData):
3440
3441 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
3442
3443         Reviewed by Adam Barth.
3444
3445         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
3446         https://bugs.webkit.org/show_bug.cgi?id=31345
3447
3448         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
3449
3450         * platform/graphics/chromium/FontCustomPlatformData.cpp:
3451         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
3452         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
3453         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
3454
3455 2009-11-11  Beth Dakin  <bdakin@apple.com>
3456
3457         Build fix. No review needed.
3458
3459         * platform/graphics/gtk/FontGtk.cpp:
3460         (WebCore::Font::drawComplexText):
3461
3462 2009-11-11  Beth Dakin  <bdakin@apple.com>
3463
3464         Build fix. No review needed.
3465
3466         * platform/graphics/cairo/FontCairo.cpp:
3467         (WebCore::Font::drawGlyphs):
3468
3469 2009-11-11  Beth Dakin  <bdakin@apple.com>
3470
3471         Windows build fix. No review needed.
3472
3473         * platform/graphics/win/FontCGWin.cpp:
3474         (WebCore::Font::drawGlyphs):
3475
3476 2009-11-11  Beth Dakin  <bdakin@apple.com>
3477
3478         Reviewed by Simon Fraser.
3479
3480         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
3481         Make -webkit-color-correction work with shadows
3482
3483         From canvas, just send DeviceColorSpace to setShadow() for now.
3484         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
3485         * html/canvas/CanvasRenderingContext2D.cpp:
3486         (WebCore::CanvasRenderingContext2D::setShadow):
3487         (WebCore::CanvasRenderingContext2D::applyShadow):
3488
3489         setShadow() and setPlatformShadow() now take a ColorSpace.
3490         * platform/graphics/GraphicsContext.cpp:
3491         (WebCore::GraphicsContext::setShadow):
3492         * platform/graphics/GraphicsContext.h:
3493         * platform/graphics/cg/GraphicsContextCG.cpp:
3494         (WebCore::createCGColorWithColorSpace): New helper to create a
3495         color in a ColorSpace.
3496         (WebCore::setCGFillColor): Call new helper.
3497         (WebCore::setCGStrokeColor): Call new helper.
3498         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
3499         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
3500         (WebCore::GraphicsContext::setPlatformShadow):
3501
3502         Send appropriate ColorSpace to setShadow().
3503         * platform/graphics/mac/FontMac.mm:
3504         (WebCore::Font::drawGlyphs):
3505         * rendering/EllipsisBox.cpp:
3506         (WebCore::EllipsisBox::paint):
3507         * rendering/InlineFlowBox.cpp:
3508         (WebCore::InlineFlowBox::paintTextDecorations):
3509         * rendering/InlineTextBox.cpp:
3510         (WebCore::paintTextWithShadows):
3511         (WebCore::InlineTextBox::paintDecoration):
3512         * rendering/RenderBoxModelObject.cpp:
3513         (WebCore::RenderBoxModelObject::paintBoxShadow):
3514         * rendering/SVGInlineTextBox.cpp:
3515         (WebCore::SVGInlineTextBox::paintCharacters):
3516         * rendering/SVGRenderSupport.cpp:
3517         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
3518
3519         Attempt to keep ports building.
3520         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3521         (WebCore::GraphicsContext::setPlatformShadow):
3522         * platform/graphics/qt/GraphicsContextQt.cpp:
3523         (WebCore::GraphicsContext::setPlatformShadow):
3524         * platform/graphics/skia/GraphicsContextSkia.cpp:
3525         (WebCore::GraphicsContext::setPlatformShadow):
3526         * platform/graphics/wince/GraphicsContextWince.cpp:
3527         (WebCore::GraphicsContext::setPlatformShadow):
3528         * platform/graphics/wx/GraphicsContextWx.cpp:
3529         (WebCore::GraphicsContext::setPlatformShadow):
3530
3531 2009-11-11  Kent Tamura  <tkent@chromium.org>
3532
3533         Reviewed by Darin Adler.
3534
3535         Print the file text of a file upload control in DumpRenderTree for ease of tests.
3536         https://bugs.webkit.org/show_bug.cgi?id=31195
3537
3538         * rendering/RenderFileUploadControl.cpp:
3539         (WebCore::RenderFileUploadControl::paintObject):
3540         (WebCore::RenderFileUploadControl::fileTextValue):
3541         * rendering/RenderFileUploadControl.h:
3542         (WebCore::RenderFileUploadControl::isFileUploadControl):
3543         (WebCore::toRenderFileUploadControl):
3544         * rendering/RenderObject.h:
3545         (WebCore::RenderObject::isFileUploadControl):
3546         * rendering/RenderTreeAsText.cpp:
3547         (WebCore::operator<<):
3548
3549 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
3550
3551         Reviewed by Sam Weinig.
3552
3553         DOM Wrappers for some nodes may not be marked.
3554         https://bugs.webkit.org/show_bug.cgi?id=31380
3555
3556         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
3557         the wrapper for the current world only.  This means that wrappers may be GC'ed
3558         prematurely, and properties lost.
3559
3560         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
3561
3562         * bindings/js/JSAttrCustom.cpp:
3563         (WebCore::JSAttr::markChildren):
3564         * bindings/js/JSDOMBinding.cpp:
3565         (WebCore::markDOMNodeWrapper):
3566         * bindings/js/JSDOMBinding.h:
3567         * bindings/js/JSNamedNodeMapCustom.cpp:
3568         (WebCore::JSNamedNodeMap::markChildren):
3569         * bindings/js/JSNodeCustom.cpp:
3570         (WebCore::JSNode::markChildren):
3571         * bindings/js/JSSVGElementInstanceCustom.cpp:
3572         (WebCore::JSSVGElementInstance::markChildren):
3573         * bindings/js/JSStyleSheetCustom.cpp:
3574         (WebCore::JSStyleSheet::markChildren):
3575
3576 2009-11-11  Ben Murdoch  <benm@google.com>
3577
3578         Reviewed by Darin Adler.
3579
3580         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
3581         https://bugs.webkit.org/show_bug.cgi?id=31384
3582
3583         No functionality change so no tests required.
3584
3585         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
3586
3587 2009-11-11  Jens Alfke  <snej@chromium.org>
3588
3589         Reviewed by Dimitri Glazkov.
3590
3591         The Big De-Inlining. 450k code size reduction (32-bit x86.)
3592         - Various inline functions in V8Binding.h made non-inline.
3593         - Some renaming for consistency.
3594         - New function createRawTemplate().
3595         https://bugs.webkit.org/show_bug.cgi?id=31383
3596
3597         * bindings/scripts/CodeGeneratorV8.pm:
3598         * bindings/v8/V8Binding.cpp:
3599         (WebCore::v8DOMWrapperToNative):
3600         (WebCore::v8ValueToWebCoreString):
3601         (WebCore::v8ValueToAtomicWebCoreString):
3602         (WebCore::toInt32):
3603         (WebCore::toWebCoreString):
3604         (WebCore::toWebCoreStringWithNullCheck):
3605         (WebCore::toAtomicWebCoreStringWithNullCheck):
3606         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
3607         (WebCore::isUndefinedOrNull):
3608         (WebCore::v8Boolean):
3609         (WebCore::v8UndetectableString):
3610         (WebCore::v8StringOrNull):
3611         (WebCore::v8StringOrUndefined):
3612         (WebCore::v8StringOrFalse):
3613         (WebCore::v8StringToWebCoreString):
3614         (WebCore::v8ExternalString):
3615         (WebCore::createRawTemplate):  New function.
3616         * bindings/v8/V8Binding.h:
3617         (WebCore::v8DOMWrapperTo):
3618         (WebCore::v8DOMWrapperToNode):
3619         (WebCore::v8StringToWebCoreString):
3620         (WebCore::v8StringToAtomicWebCoreString):
3621
3622 2009-11-11  Jens Alfke  <snej@chromium.org>