WebCore/ChangeLog

   1 2009-11-12  Jeremy Orlow  <jorlow@chromium.org>
   2
   3         Reviewed by Dmitry Titov.
   4
   5         LocalStorage quota should include key sizes in its count
   6         https://bugs.webkit.org/show_bug.cgi?id=31451
   7
   8         * storage/StorageMap.cpp:
   9         (WebCore::StorageMap::setItem):
  10             Count keys in the quota when adding a new item.
  11         (WebCore::StorageMap::removeItem):
  12             Remove the key's length from the quota if we're removing the item.
  13         (WebCore::StorageMap::importItem):
  14             Assume that we're adding things for the first time.
  15             Count keys in the quota.
  16
  17 2009-11-13  Dominik Röttsches  <dominik.roettsches@access-company.com>
  18
  19         Reviewed by Eric Seidel.
  20
  21         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
  22         https://bugs.webkit.org/show_bug.cgi?id=31468
  23
  24         Moving TextBoundariesICU.cpp to TextBoundaries.cpp
  25         by removing the direct ICU dependency and replacing it
  26         with WTF functions and WebCore's own TextBreakIterator
  27         abstractions.
  28
  29         * GNUmakefile.am:
  30         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
  31         * platform/text/TextBoundaries.cpp: Added.
  32         (WebCore::findNextWordFromIndex):
  33         (WebCore::findWordBoundary):
  34         * platform/text/TextBoundariesICU.cpp: Removed.
  35         * platform/text/TextBreakIterator.h:
  36         * platform/text/TextBreakIteratorICU.cpp:
  37         (WebCore::textBreakLast):
  38         (WebCore::textBreakPrevious):
  39
  40 2009-11-13  Shinichiro Hamaji  <hamaji@chromium.org>
  41
  42         Reviewed by Darin Adler.
  43
  44         WebCore::externalRepresentation should update layout before getting render object
  45         https://bugs.webkit.org/show_bug.cgi?id=31459
  46
  47         * rendering/RenderTreeAsText.cpp:
  48         (WebCore::externalRepresentation):
  49
  50 2009-11-13  Adam Roben  <aroben@apple.com>
  51
  52         Tell FrameLoaderClient when window objects in isolated worlds are
  53         cleared
  54
  55         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
  56         window objects in isolated worlds are cleared
  57
  58         Test: http/tests/security/isolatedWorld/didClearWindowObject.html
  59
  60         Reviewed by Dave Hyatt.
  61
  62         * bindings/js/JSDOMBinding.h:
  63         (WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
  64         worlds in m_worldSet to the passed-in Vector.
  65
  66         * bindings/js/ScriptController.cpp:
  67         (WebCore::ScriptController::getAllWorlds): Added. Calls through to
  68         WebCoreJSClientData.
  69         (WebCore::ScriptController::initScript): Changed to call
  70         FrameLoader::dispatchDidClearWindowObjectInWorld.
  71
  72         * bindings/js/ScriptController.h: Added getAllWorlds.
  73
  74         * loader/EmptyClients.h:
  75         (WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
  76         Updated for FrameLoaderClient change.
  77
  78         * loader/FrameLoader.cpp:
  79         (WebCore::FrameLoader::receivedFirstData):
  80         (WebCore::FrameLoader::begin):
  81         Changed to call dispatchDidClearWindowObjectsInAllWorlds.
  82
  83         (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
  84         Added. Retrieves all the worlds, then calls through to
  85         dispatchDidClearWindowObjectInWorld for each one.
  86         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
  87         dispatchWindowObjectAvailable. Calls up to the client, then, if the
  88         world is the mainThreadNormalWorld(), tells the Inspector about it,
  89         too.
  90
  91         * loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with
  92         dispatchDidClearWindowObjectInWorld. Added
  93         dispatchDidClearWindowObjectsInAllWorlds.
  94
  95         * loader/FrameLoaderClient.h: Replaced windowObjectCleared with
  96         dispatchDidClearWindowObjectForWorld.
  97
  98 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
  99
 100         Reviewed by Dimitri Glazkov.
 101
 102         [V8] Fix SVG context assignment for pod types.
 103         https://bugs.webkit.org/show_bug.cgi?id=31497
 104
 105         I broke this in r50958.
 106
 107         Tested by svg/custom/viewport-update2.svg.
 108
 109         * bindings/scripts/CodeGeneratorV8.pm:
 110
 111 2009-11-13  Andrei Popescu  <andreip@google.com>
 112
 113         Reviewed by Dmitry Titov.
 114
 115         Bring the platform/android files inline with Android 2.0
 116         https://bugs.webkit.org/show_bug.cgi?id=31423
 117
 118         No new tests required: these are all Android-specific files.
 119
 120         * platform/android/ClipboardAndroid.cpp:
 121         (WebCore::ClipboardAndroid::files):
 122         * platform/android/ClipboardAndroid.h:
 123         * platform/android/FileChooserAndroid.cpp:
 124         (WebCore::FileChooser::basenameForWidth):
 125         (WebCore::fileButtonChooseFileLabel):
 126         * platform/android/KeyEventAndroid.cpp:
 127         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
 128         * platform/android/LocalizedStringsAndroid.cpp:
 129         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
 130         (WebCore::contextMenuItemTagDownloadLinkToDisk):
 131         (WebCore::contextMenuItemTagCopyLinkToClipboard):
 132         (WebCore::contextMenuItemTagOpenImageInNewWindow):
 133         (WebCore::contextMenuItemTagDownloadImageToDisk):
 134         (WebCore::contextMenuItemTagCopyImageToClipboard):
 135         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
 136         (WebCore::contextMenuItemTagCopy):
 137         (WebCore::contextMenuItemTagGoBack):
 138         (WebCore::contextMenuItemTagGoForward):
 139         (WebCore::contextMenuItemTagStop):
 140         (WebCore::contextMenuItemTagReload):
 141         (WebCore::contextMenuItemTagCut):
 142         (WebCore::contextMenuItemTagPaste):
 143         (WebCore::contextMenuItemTagNoGuessesFound):
 144         (WebCore::contextMenuItemTagIgnoreSpelling):
 145         (WebCore::contextMenuItemTagLearnSpelling):
 146         (WebCore::contextMenuItemTagSearchWeb):
 147         (WebCore::contextMenuItemTagLookUpInDictionary):
 148         (WebCore::contextMenuItemTagOpenLink):
 149         (WebCore::contextMenuItemTagIgnoreGrammar):
 150         (WebCore::contextMenuItemTagSpellingMenu):
 151         (WebCore::contextMenuItemTagShowSpellingPanel):
 152         (WebCore::contextMenuItemTagCheckSpelling):
 153         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
 154         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
 155         (WebCore::contextMenuItemTagFontMenu):
 156         (WebCore::contextMenuItemTagBold):
 157         (WebCore::contextMenuItemTagItalic):
 158         (WebCore::contextMenuItemTagUnderline):
 159         (WebCore::contextMenuItemTagOutline):
 160         (WebCore::contextMenuItemTagWritingDirectionMenu):
 161         (WebCore::contextMenuItemTagTextDirectionMenu):
 162         (WebCore::contextMenuItemTagDefaultDirection):
 163         (WebCore::contextMenuItemTagLeftToRight):
 164         (WebCore::contextMenuItemTagRightToLeft):
 165         (WebCore::mediaElementLoadingStateText):
 166         (WebCore::mediaElementLiveBroadcastStateText):
 167         (WebCore::searchableIndexIntroduction):
 168         (WebCore::resetButtonDefaultLabel):
 169         (WebCore::submitButtonDefaultLabel):
 170         (WebCore::inputElementAltText):
 171         * platform/android/RenderThemeAndroid.cpp:
 172         (WebCore::RenderTheme::themeForPage):
 173         (WebCore::RenderThemeAndroid::baselinePosition):
 174         (WebCore::RenderThemeAndroid::paintButton):
 175         (WebCore::adjustMenuListStyleCommon):
 176         (WebCore::RenderThemeAndroid::paintCombo):
 177         * platform/android/ScreenAndroid.cpp:
 178         * platform/android/ScrollViewAndroid.cpp:
 179         (WebCore::ScrollView::platformOffscreenContentRectangle):
 180         * platform/android/TemporaryLinkStubs.cpp:
 181         (JSC::Bindings::dispatchJNICall):
 182         * platform/android/WidgetAndroid.cpp:
 183         (WebCore::Widget::setFrameRect):
 184
 185 2009-11-13  Norbert Leser  <norbert.leser&nokia.com>
 186
 187         Reviewed by Eric Seidel.
 188
 189         Added macros for USERINCLUDE paths within symbian blocks
 190         to guarantee inclusion of respective header files from local path
 191         first (to avoid clashes with same names of header files in system include path).
 192
 193         * WebCore.pro:
 194
 195 2009-11-13  Hironori Bono  <hbono@chromium.org>
 196
 197         Reviewed by Oliver Hunt.
 198
 199         Implement composition events introduced in DOM Level 3.
 200         This change adds a new IDL which defines the composition events, adds a class which
 201         implements the composition events, and sends the composition events according to
 202         the specification.
 203         https://bugs.webkit.org/show_bug.cgi?id=26310
 204
 205         Test: fast/events/ime-composition-events-001.html
 206
 207         * DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
 208         * GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
 209         * WebCore.gypi: ditto.
 210         * WebCore.pro: ditto
 211         * WebCore.vcproj/WebCore.vcproj: ditto.
 212         * WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
 213         * WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
 214         * bindings/js/JSEventCustom.cpp:
 215         (WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
 216         * bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
 217         * bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
 218         * bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
 219         (WebCore::V8DOMWrapper::convertEventToV8Object):
 220         * bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
 221         * bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
 222         * dom/CompositionEvent.cpp: Implements the CompositionEvent class.
 223         (WebCore::CompositionEvent::CompositionEvent):
 224         (WebCore::CompositionEvent::~CompositionEvent):
 225         (WebCore::CompositionEvent::initCompositionEvent):
 226         (WebCore::CompositionEvent::isCompositionEvent):
 227         * dom/CompositionEvent.h: Declares the CompositionEvent class.
 228         (WebCore::CompositionEvent::create):
 229         (WebCore::CompositionEvent::data):
 230         * dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
 231         * dom/Event.cpp:
 232         (WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
 233         * dom/Event.h:
 234         * dom/EventNames.h: Added composition{start,update,end} to eventNames.
 235         * editing/Editor.cpp:
 236         (WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
 237         (WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
 238
 239 2009-11-13  Jens Alfke  <snej@chromium.org>
 240
 241         Reviewed by Dimitri Glazkov.
 242
 243         Fix a link error in unofficial GCC 4.4 builds on Linux.
 244         https://bugs.webkit.org/show_bug.cgi?id=31477
 245
 246         * bindings/v8/V8Binding.cpp:  Add explicit instantiations of v8StringToWebCoreString template.
 247
 248 2009-11-13  Eric Seidel  <eric@webkit.org>
 249
 250         No review, build fix only.
 251
 252         Fix Debug build after http://trac.webkit.org/changeset/50960.
 253
 254         The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
 255         https://bugs.webkit.org/show_bug.cgi?id=31213
 256
 257         * rendering/CounterNode.cpp:
 258         (WebCore::showTreeAndMark):
 259         * rendering/RenderCounter.cpp:
 260         (WebCore::destroyCounterNodeChildren):
 261
 262 2009-11-13  Dirk Schulze  <krit@webkit.org>
 263
 264         Reviewed by Gustavo Noronha.
 265
 266         [CAIRO] shadow support for Canvas and SVG
 267         [https://bugs.webkit.org/show_bug.cgi?id=30960]
 268
 269         We currently fill a path with solid color instead of filling
 270         a clipping path. This causes problems on some composite operators,
 271         since Cairo modifies the area outside the path.
 272         This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
 273
 274         Thanks to Benjamin Otte for tracking the bug down.
 275
 276         * platform/graphics/cairo/GraphicsContextCairo.cpp:
 277         (WebCore::setPlatformFill):
 278
 279 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
 280
 281         Reviewed by Dimitri Glazkov.
 282
 283         Adding Chromium's DatabaseTracker implementation.
 284
 285         https://bugs.webkit.org/show_bug.cgi?id=31440
 286
 287         * WebCore.gyp/WebCore.gyp:
 288         * WebCore.gypi:
 289         * storage/DatabaseTracker.h:
 290         * storage/chromium/DatabaseTrackerChromium.cpp:
 291         (WebCore::DatabaseTracker::fullPathForDatabase):
 292         (WebCore::DatabaseTracker::getMaxSizeForDatabase):
 293         * storage/chromium/QuotaTracker.cpp:
 294         (WebCore::QuotaTracker::updateDatabaseSize):
 295         * storage/chromium/QuotaTracker.h:
 296
 297 2009-11-13  Carol Szabo  <carol.szabo@nokia.com>
 298
 299         Reviewed by Darin Adler.
 300
 301         The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
 302         https://bugs.webkit.org/show_bug.cgi?id=31213
 303         Added tree navigation methods that permit full implementation of CSS2.1
 304         counter feature without using recursion proportional to the counter
 305         tree depth.
 306         No new tests because I did not find any bug that is fixed by this
 307         commit yet, this just reduces the size of the patch for 11031 and
 308         helps respond to some concerns regarding that patch.
 309
 310         * rendering/CounterNode.cpp:
 311         (WebCore::CounterNode::CounterNode):
 312
 313         (WebCore::CounterNode::nextInPreOrderAfterChildren):
 314         (WebCore::CounterNode::nextInPreOrder):
 315         Added to support non-recursive tree traversal necessary for
 316         efficient full implementation of CSS2.1 counters.
 317
 318         (WebCore::CounterNode::lastDescendant):
 319         (WebCore::CounterNode::previousInPreOrder):
 320         Moved this methods such that they occupy a place similar to that of
 321         identically named methods on the render tree. This allows for their
 322         broader use needed in full implementation of CSS2.1 counters.
 323
 324         (WebCore::CounterNode::resetRenderer):
 325         (WebCore::CounterNode::resetRenderers):
 326         (WebCore::CounterNode::recount):
 327         (WebCore::CounterNode::insertAfter):
 328         (WebCore::CounterNode::removeChild):
 329         Changed such that insertion/removal of a counter, triggers not only
 330         recalculation of PrefixWidths, but also reassesment of values in
 331         counter nodes. This is the basis full implementation of CSS2.1
 332         counters. It does not change current behavior by much because of
 333         changes needed to the recalculation algorithm, but those are comming
 334         in the patch for 11031.
 335         (WebCore::showTreeAndMark):
 336         * rendering/CounterNode.h:
 337         * rendering/RenderCounter.cpp:
 338         (WebCore::counter):
 339         Only changed argument type to prepare for implementation of Darin
 340         Adler's recommendation for the patch to 11031.
 341
 342         (WebCore::RenderCounter::invalidate):
 343         (WebCore::destroyCounterNodeChildren):
 344         (WebCore::RenderCounter::destroyCounterNodes):
 345         * rendering/RenderCounter.h:
 346         * rendering/RenderObjectChildList.cpp:
 347         (WebCore::invalidateCountersInContainer):
 348         (WebCore::RenderObjectChildList::invalidateCounters):
 349         * rendering/RenderObjectChildList.h:
 350         Added the ability to restrict invalidation to counters with a given
 351         identifier.
 352         Also invalidated counters that are on the child container itself
 353         which were missed by the previous algorithm, but were a valid case.
 354
 355 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
 356
 357         Reviewed by Dimitri Glazkov.
 358
 359         [V8] Protect SVG animated properties from destruction in bindings.
 360         https://bugs.webkit.org/show_bug.cgi?id=31474
 361
 362         See http://crbug.com/26719.
 363
 364         Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
 365         under Valgrind.
 366
 367         Made sure we keep a reference to SVG properties while setting a
 368         context:
 369         * bindings/scripts/CodeGeneratorV8.pm:
 370         * bindings/v8/V8Proxy.h:
 371         (WebCore::V8Proxy::withSVGContext):
 372
 373 2009-11-13  Brent Fulgham  <bfulgham@webkit.org>
 374
 375         Reviewed by Alexey Proskuryakov.
 376
 377         [CAIRO] shadow support for Canvas and SVG.
 378         [https://bugs.webkit.org/show_bug.cgi?id=30960]
 379
 380         Incorporate Benjamin Otte's recommendations to avoid
 381         a buffer overrun, and small performance improvement.
 382
 383         * platform/graphics/cairo/GraphicsContextCairo.cpp:
 384         (WebCore::copyContextProperties): Correctly size output
 385          storage for cairo_get_dash to avoid buffer overrun.
 386         (WebCore::drawPathShadow): Prefer cairo_fill_extents
 387          to slower cairo_stroke_extents when not drawing shadows.
 388
 389 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
 390
 391         Reviewed by Dimitri Glazkov.
 392
 393         Do not register Chromium's HTML5 DB VFS as the default
 394         VFS. Otherwise, other sqlite DB users in the same process will
 395         stop working.
 396
 397         https://bugs.webkit.org/show_bug.cgi?id=31462
 398
 399         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
 400         (WebCore::SQLiteFileSystem::openDatabase):
 401         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
 402         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
 403         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
 404         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
 405
 406 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
 407
 408         Windows build fix
 409
 410         * platform/network/cf/SocketStreamHandleCFNet.cpp:
 411         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
 412         avoiding a sign mismatch warning.
 413
 414 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
 415
 416         Release build fix.
 417
 418         * platform/network/cf/SocketStreamHandleCFNet.cpp:
 419         (WebCore::SocketStreamHandle::readStreamCallback):
 420         (WebCore::SocketStreamHandle::writeStreamCallback):
 421         Use ASSERT_UNUSED for unused stream parameter.
 422
 423 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
 424
 425         Reviewed by Darin Adler.
 426
 427         https://bugs.webkit.org/show_bug.cgi?id=31441
 428         Implement SocketStreamHandleCFNet
 429
 430         Existing WebSocket tests now pass on Mac. No proxy support yet.
 431
 432         * platform/network/SocketStreamHandleClient.h:
 433         * platform/network/cf/SocketStreamHandle.h:
 434         (WebCore::SocketStreamHandle::shouldUseSSL):
 435         (WebCore::SocketStreamHandle::refAuthenticationClient):
 436         (WebCore::SocketStreamHandle::derefAuthenticationClient):
 437         (WebCore::SocketStreamHandle::):
 438         * platform/network/cf/SocketStreamHandleCFNet.cpp:
 439         (WebCore::SocketStreamHandle::SocketStreamHandle):
 440         (WebCore::SocketStreamHandle::chooseProxy):
 441         (WebCore::SocketStreamHandle::createStreams):
 442         (WebCore::SocketStreamHandle::copyCFStreamDescription):
 443         (WebCore::SocketStreamHandle::readStreamCallback):
 444         (WebCore::SocketStreamHandle::writeStreamCallback):
 445         (WebCore::SocketStreamHandle::~SocketStreamHandle):
 446         (WebCore::SocketStreamHandle::platformSend):
 447         (WebCore::SocketStreamHandle::platformClose):
 448         (WebCore::SocketStreamHandle::receivedCredential):
 449         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
 450         (WebCore::SocketStreamHandle::receivedCancellation):
 451
 452 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 453
 454         Reviewed by Timothy Hatcher.
 455
 456         Web Inspector: preload status bar button glyphs
 457         in order to prevent them from flickering (take 2).
 458
 459         https://bugs.webkit.org/show_bug.cgi?id=31439
 460
 461         * inspector/front-end/inspector.js:
 462         (preloadImages):
 463
 464 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
 465
 466         Reviewed by Adam Barth.
 467
 468         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
 469         Rolling back r50890.
 470
 471         https://bugs.webkit.org/show_bug.cgi?id=31467
 472
 473         * bindings/v8/V8Proxy.cpp:
 474         (WebCore::V8Proxy::canAccessPrivate):
 475
 476 2009-11-13  Dirk Schulze  <krit@webkit.org>
 477
 478         Reviewed by Gustavo Noronha.
 479
 480         [CAIRO] shadow support for Canvas and SVG
 481         [https://bugs.webkit.org/show_bug.cgi?id=30960]
 482
 483         This is the fix of a regression, caused by the shadow patch
 484         from the bug above. Reinserted the save and restore calls
 485         that were accidently removed by the previous patch.
 486
 487         * platform/graphics/cairo/GraphicsContextCairo.cpp:
 488         (WebCore::setPlatformFill):
 489         (WebCore::setPlatformStroke):
 490
 491 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
 492
 493         Not reviewed. Reverting r50908 since it makes inspector tests
 494         time out.
 495
 496         https://bugs.webkit.org/show_bug.cgi?id=31439
 497
 498         * inspector/front-end/inspector.js:
 499
 500 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
 501
 502         Reviewed by Timothy Hatcher.
 503
 504         Enable 'console.profile()' and 'console.profileEnd()'
 505         regardless of JAVASCRIPT_DEBUGGER.
 506
 507         https://bugs.webkit.org/show_bug.cgi?id=31293
 508
 509         * WebCore.gypi:
 510         * bindings/js/JSConsoleCustom.cpp:
 511         (WebCore::JSConsole::profile):
 512         (WebCore::JSConsole::profileEnd):
 513         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
 514         (WebCore::CALLBACK_FUNC_DECL):
 515         * bindings/v8/custom/V8CustomBinding.h:
 516         * page/Console.idl:
 517
 518 2009-11-12  David Levin  <levin@chromium.org>
 519
 520         Reviewed by NOBODY.
 521
 522         Chromium build fix.
 523
 524         * bindings/v8/ScriptController.h:
 525         (WebCore::ScriptController::evaluateInWorld): Add a dummy
 526          method which isn't called in chromium to make things compile.
 527
 528 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
 529
 530         Reviewed by Adam Barth.
 531
 532         The document-open.html test was flaky at times. The test invokes the layout test plugin
 533         which in its destroy stream handler opens a new document. This basically tears down the
 534         stream and the associated plugin instance, which causes a crash when the plugin stream
 535         dereferences an invalid m_client pointer which points to the PluginView instance which
 536         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
 537         and check for the same.
 538
 539         https://bugs.webkit.org/show_bug.cgi?id=31067
 540
 541         * plugins/PluginStream.cpp:
 542         (WebCore::PluginStream::stop):
 543         (WebCore::PluginStream::destroyStream):
 544
 545 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
 546
 547         Reviewed by Dimitri Glazkov.
 548
 549         Renaming some parameters passed to DB-related methods to better
 550         indicate their purpose.
 551
 552         https://bugs.webkit.org/show_bug.cgi?id=31449
 553
 554         * platform/chromium/ChromiumBridge.h:
 555
 556 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
 557
 558         Reviewed by Dan Bernstein.
 559
 560         Transformed reflected elements are clipped inside element with opacity
 561         https://bugs.webkit.org/show_bug.cgi?id=30957
 562
 563         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
 564         each clip rect into painting space before taking the unions. This, however, did not work
 565         correctly with combinations of reflections and transforms. Fixed by unioning the
 566         clipRect and mapping through transforms along the way.
 567
 568         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
 569         where the transparency layers are.
 570
 571         Test: fast/reflections/opacity-reflection-transform.html
 572
 573         * rendering/RenderLayer.cpp:
 574         (WebCore::expandClipRectForDescendantsAndReflection):
 575         (WebCore::transparencyClipBox):
 576         (WebCore::RenderLayer::beginTransparencyLayers):
 577
 578 2009-11-12  Adam Barth  <abarth@webkit.org>
 579
 580         Reviewed by Darin Fisher.
 581
 582         Improve SecurityOrigin::toString comment
 583         https://bugs.webkit.org/show_bug.cgi?id=31041
 584
 585         * page/SecurityOrigin.h:
 586
 587 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
 588
 589         Reviewed by Darin Adler.
 590
 591         externalRepresentation should take Frame as the argument
 592         https://bugs.webkit.org/show_bug.cgi?id=31393
 593
 594         No new tests as this is just a refactoring.
 595
 596         * WebCore.base.exp:
 597         * rendering/RenderTreeAsText.cpp:
 598         (WebCore::externalRepresentation):
 599         * rendering/RenderTreeAsText.h:
 600
 601 2009-11-12  Ben Murdoch  <benm@google.com>
 602
 603         Reviewed by Dimitri Glazkov.
 604
 605         [Android] The Android specific files in page/Android are out of date.
 606         https://bugs.webkit.org/show_bug.cgi?id=31437
 607
 608         No tests required.
 609
 610         * page/android/DragControllerAndroid.cpp:
 611         (WebCore::DragController::dragOperation): Added.
 612         (WebCore::DragController::cleanupAfterSystemDrag):
 613         * page/android/EventHandlerAndroid.cpp:
 614         (WebCore::EventHandler::accessKeyModifiers): Added.
 615         * page/android/InspectorControllerAndroid.cpp: Removed.
 616
 617 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
 618
 619         Reviewed by Simon Fraser.
 620
 621         [CAIRO] shadow support for Canvas and SVG.
 622         [https://bugs.webkit.org/show_bug.cgi?id=30960]
 623
 624         Implement Canvas/SVG shadow support for Cairo.  This patch
 625         uses the filter code from SVG Filters.  That means that it is
 626         necessary to activate filters to see the shadows.
 627
 628         Test: fast/canvas/canvas-shadow.html
 629
 630         * GNUmakefile.am:
 631         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
 632         * platform/graphics/GraphicsContext.h:
 633         * platform/graphics/cairo/GraphicsContextCairo.cpp:
 634         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
 635         (WebCore::setPlatformFill):
 636         (WebCore::setPlatformStroke):
 637         (WebCore::copyContextProperties):
 638         (WebCore::drawPathShadow):
 639         (WebCore::GraphicsContext::fillPath):
 640         (WebCore::GraphicsContext::strokePath):
 641         (WebCore::GraphicsContext::drawPath):
 642         (WebCore::GraphicsContext::setPlatformShadow):
 643         (WebCore::GraphicsContext::createPlatformShadow):
 644         * platform/graphics/cairo/ImageCairo.cpp:
 645         (WebCore::BitmapImage::draw): Add filter effect.
 646         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
 647         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
 648         * platform/graphics/filters/ImageBufferFilter.h: Added.
 649         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
 650         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
 651
 652 2009-11-12  Dmitry Titov  <dimich@chromium.org>
 653
 654         Reviewed by Alexey Proskuryakov.
 655
 656         Add postTaskToMainThread to ScriptExecutionContext.
 657         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
 658         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
 659         contexts that live on the main thread.
 660         https://bugs.webkit.org/show_bug.cgi?id=31427
 661
 662         No new tests - simply moving the code.
 663
 664         * dom/Document.cpp:
 665         (WebCore::Document::postTask):
 666         * dom/ScriptExecutionContext.cpp:
 667         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
 668         (WebCore::ScriptExecutionContextTaskTimer::fired):
 669         (WebCore::PerformTaskData::PerformTaskData):
 670         (WebCore::PerformTaskData::performTask):
 671         (WebCore::ScriptExecutionContext::postTaskToMainThread):
 672         * dom/ScriptExecutionContext.h:
 673
 674 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
 675
 676         Reviewed by Darin Adler.
 677
 678         Fix crash when removing compositing layers when GC is enabled
 679         https://bugs.webkit.org/show_bug.cgi?id=31429
 680
 681         Workaround <rdar://problem/7390716> by special-casing the removal
 682         of all sublayers when GC is enabled.
 683
 684         * platform/graphics/mac/GraphicsLayerCA.mm:
 685         (WebCore::safeSetSublayers):
 686         (WebCore::GraphicsLayerCA::updateSublayerList):
 687         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
 688
 689 2009-11-12  Jens Alfke  <snej@chromium.org>
 690
 691         Reviewed by Dimitri Glazkov.
 692
 693         The last of the V8 binding optimizations.
 694         - Replace string-valued element accessors with a shared getter/setter function.
 695         - Change error handling flow of control to avoid extra branches and function calls.
 696         https://bugs.webkit.org/show_bug.cgi?id=31443
 697
 698         * bindings/scripts/CodeGeneratorV8.pm:
 699         * bindings/v8/V8Binding.cpp:
 700         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
 701         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
 702         * bindings/v8/V8Binding.h:
 703
 704 2009-11-12  Sam Weinig  <sam@webkit.org>
 705
 706         Reviewed by Oliver Hunt.
 707
 708         Fix for <rdar://problem/7267951>
 709         Canvas methods should reject uses of NaN and Infinity.
 710
 711         Test: fast/canvas/canvas-with-illegal-args.html
 712
 713         * html/canvas/CanvasRenderingContext2D.cpp:
 714         (WebCore::CanvasRenderingContext2D::scale):
 715         (WebCore::CanvasRenderingContext2D::rotate):
 716         (WebCore::CanvasRenderingContext2D::translate):
 717         (WebCore::CanvasRenderingContext2D::transform):
 718         (WebCore::CanvasRenderingContext2D::setTransform):
 719
 720 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 721
 722         Reviewed by Timothy Hatcher.
 723
 724         Web Inspector: profile timeline panel, fix obvious problems.
 725
 726         https://bugs.webkit.org/show_bug.cgi?id=31432
 727
 728         * inspector/front-end/AbstractTimelinePanel.js:
 729         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
 730         * inspector/front-end/TimelinePanel.js:
 731         (WebInspector.TimelinePanel.prototype._setWindowPosition):
 732         (WebInspector.TimelineCalculator):
 733         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
 734         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
 735         (WebInspector.TimelineCalculator.prototype.reset):
 736         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
 737         (WebInspector.TimelineCalculator.prototype.formatValue):
 738         (WebInspector.TimelineGraph):
 739         (WebInspector.TimelineGraph.prototype.refresh):
 740         * inspector/front-end/utilities.js:
 741         (Element.prototype.hasStyleClass):
 742
 743 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 744
 745         Reviewed by Timothy Hatcher.
 746
 747         Web Inspector: preload status bar button glyphs
 748         in order to prevent them from flickering.
 749
 750         https://bugs.webkit.org/show_bug.cgi?id=31439
 751
 752         * inspector/front-end/inspector.js:
 753         (preloadImages):
 754
 755 2009-11-12  Adam Roben  <aroben@apple.com>
 756
 757         Replace worldIDs with world objects
 758
 759         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
 760         user scripts/stylesheets and isolated worlds
 761
 762         Reviewed by Sam Weinig.
 763
 764         Covered by existing tests.
 765
 766         * WebCore.base.exp: Update exported symbols to match what now exists
 767         and is needed by WebKit.
 768
 769         * bindings/js/ScheduledAction.cpp:
 770         (WebCore::ScheduledAction::execute): Updated for function rename.
 771
 772         * bindings/js/ScriptController.cpp: Removed code that dealt with
 773         worldIDs.
 774         (WebCore::ScriptController::createWorld): Added. Returns a new world
 775         suitable for use on the main thread.
 776         (WebCore::ScriptController::executeScriptInWorld): Renamed from
 777         executeScriptInIsolatedWorld, since this works just fine with a
 778         "normal" world.
 779
 780         * bindings/js/ScriptController.h: Added createWorld, removed functions
 781         that took worldIDs, renamed executeScriptInIsolatedWorld to
 782         executeScriptInWorld.
 783
 784         * page/Frame.cpp:
 785         (WebCore::Frame::injectUserScripts):
 786         (WebCore::Frame::injectUserScriptsForWorld):
 787         Updated for changes to UserScriptMap and ScriptController.
 788
 789         * page/Frame.h: Changed injectUserScriptsForWorld to take a
 790         DOMWrapperWorld* instead of a worldID.
 791
 792         * page/PageGroup.cpp:
 793         (WebCore::PageGroup::addUserScriptToWorld):
 794         (WebCore::PageGroup::addUserStyleSheetToWorld):
 795         (WebCore::PageGroup::removeUserScriptFromWorld):
 796         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
 797         (WebCore::PageGroup::removeUserScriptsFromWorld):
 798         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
 799         * page/PageGroup.h:
 800         Changed these functions to take a DOMWrapperWorld* instead of a
 801         worldID. Also updated for changes to UserScript and UserStyleSheet.
 802
 803         * page/UserScript.h:
 804         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
 805         never used.
 806
 807         * page/UserScriptTypes.h:
 808         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
 809         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
 810         worldID as their key type.
 811
 812
 813 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
 814
 815         Reviewed by Tim Hatcher.
 816
 817         Fixes <http://webkit.org/b/31260>.
 818         Web Inspector: Main Resources Other than HTML are mis-detected.
 819
 820         Even if the resource is a main resource, look at its CachedResource type,
 821         because it might be an image, stylesheet, or JavaScript file, and we
 822         want to show them all correctly.
 823
 824         * inspector/InspectorResource.cpp:
 825         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
 826         (WebCore::InspectorResource::type):
 827         * inspector/InspectorResource.h:
 828
 829 2009-11-12  Jens Alfke  <snej@chromium.org>
 830
 831         Reviewed by Dimitri Glazkov.
 832
 833         Table-driven setup for V8 binding template callback functions. 100k in code savings.
 834         https://bugs.webkit.org/show_bug.cgi?id=31420
 835
 836         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
 837             to call configureTemplate().
 838         * bindings/v8/V8Binding.cpp:
 839         (WebCore::configureTemplate):  New function; does all the standard configuration work.
 840         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
 841         * bindings/v8/V8Binding.h:
 842         * bindings/v8/V8Proxy.cpp:
 843         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
 844         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
 845         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
 846         * bindings/v8/V8Proxy.h:
 847
 848 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
 849
 850         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
 851
 852         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
 853
 854 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
 855
 856         Reviewed by Dan Bernstein.
 857
 858         <rdar://problem/7388969> Add DOM API for fullscreen video
 859
 860         DOM API for fullscreen <video>.
 861
 862         Tests: media/media-fullscreen-inline.html
 863                media/media-fullscreen-not-in-document.html
 864
 865         * dom/EventNames.h:
 866             Add webkitbeginfullscreen and webkitendfullscreen.
 867
 868         * html/HTMLAttributeNames.in:
 869             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
 870
 871         * html/HTMLMediaElement.cpp:
 872         (WebCore::HTMLMediaElement::parseMappedAttribute):
 873             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
 874         (WebCore::HTMLMediaElement::enterFullscreen):
 875             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
 876             actually do enter fullscreen.
 877         (WebCore::HTMLMediaElement::exitFullscreen):
 878             Schedule webkitendfullscreenEvent event.
 879         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
 880         (WebCore::HTMLMediaElement::webkitExitFullScreen):
 881         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
 882         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
 883             New, access to fullscreen properties and methods.
 884
 885         * html/HTMLMediaElement.h:
 886         * html/HTMLMediaElement.idl:
 887             Declare methods needed for fullscreen API.
 888
 889         * html/HTMLVideoElement.cpp:
 890         (WebCore::HTMLVideoElement::supportsFullscreen):
 891             Return false if a movie does not have video.
 892
 893         * page/DOMWindow.h:
 894             Add webkitbeginfullscreen and webkitendfullscreen.
 895
 896 2009-11-12  Adam Barth  <abarth@webkit.org>
 897
 898         Reviewed by Dimitri Glazkov.
 899
 900         [Chromium] Sify compose button alerts error
 901         https://bugs.webkit.org/show_bug.cgi?id=31394
 902
 903         Test: http/tests/security/calling-versus-current.html
 904
 905         We're supposed to use the calling context for security checks.  In JSC
 906         land, this is the lexicalGlobalObject.
 907
 908         * bindings/v8/V8Proxy.cpp:
 909         (WebCore::V8Proxy::canAccessPrivate):
 910
 911 2009-11-12  Daniel Bates  <dbates@webkit.org>
 912
 913         Reviewed by Darin Adler.
 914
 915         https://bugs.webkit.org/show_bug.cgi?id=30291
 916
 917         Fixes an issue where the returned drop effect is incorrect when
 918         effectAllowed == "uninitialized".
 919
 920         According to section 7.9.2 of the HTML 5 spec.
 921         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
 922         when effectAllowed = "uninitialized" the resulting dropEffect should be the
 923         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
 924         other case.
 925
 926         No test cases are included because we have an existing test case from
 927         bug #24731.
 928
 929         * dom/Clipboard.cpp:
 930         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
 931
 932 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 933
 934         Reviewed by Timothy Hatcher.
 935
 936         Web Inspector: Do not highlight node on refresh.
 937
 938         https://bugs.webkit.org/show_bug.cgi?id=31419
 939
 940         * inspector/front-end/ElementsPanel.js:
 941         (WebInspector.ElementsPanel.prototype.reset):
 942
 943 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 944
 945         Reviewed by Timothy Hatcher.
 946
 947         Web Inspector: Minor timeline fixes.
 948
 949         https://bugs.webkit.org/show_bug.cgi?id=31417
 950
 951         * inspector/front-end/TimelinePanel.js:
 952         (WebInspector.TimelinePanel.prototype._getRecordDetails):
 953         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
 954         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
 955         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
 956
 957 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
 958
 959         SnowLeopard build fix.
 960
 961         Renamed initWithClient to initWithAuthenticationClient.
 962
 963         * platform/network/mac/AuthenticationMac.mm:
 964         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
 965         (WebCore::AuthenticationChallenge::setAuthenticationClient):
 966
 967 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
 968
 969         Reviewed by Darin Adler.
 970
 971         ARIA: add alert type roles
 972         https://bugs.webkit.org/show_bug.cgi?id=31392
 973
 974         Test: platform/mac/accessibility/aria-alerts.html
 975
 976         * accessibility/AccessibilityObject.h:
 977         * accessibility/AccessibilityRenderObject.cpp:
 978         * accessibility/mac/AccessibilityObjectWrapper.mm:
 979
 980 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
 981
 982         Reviewed by Darin Adler.
 983
 984         https://bugs.webkit.org/show_bug.cgi?id=31386
 985         Make Mac AuthenticationChallenge usable from cross-platform code
 986
 987         No change in behavior, so no tests.
 988
 989         * platform/network/ResourceHandle.cpp:
 990         (WebCore::ResourceHandle::clearAuthentication):
 991         * platform/network/ResourceHandleInternal.h:
 992         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
 993         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
 994         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
 995         is identical.
 996
 997         * platform/network/cf/AuthenticationChallenge.h:
 998         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
 999         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
1000
1001         * platform/network/cf/ResourceHandleCFNet.cpp:
1002         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
1003         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
1004         be already set.
1005
1006         * platform/network/mac/AuthenticationChallenge.h:
1007         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
1008         best of my understanding.
1009         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
1010         confusion with "mac" and "web" challenges in ResourceHandleInternal.
1011
1012         * platform/network/mac/AuthenticationMac.mm:
1013         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
1014         making it possible to use the latter with NSURLAuthenticationChallenge.
1015         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
1016         m_nsChallenge renaming.
1017         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
1018         set it as sender (or unset, if client is null).
1019
1020         * platform/network/mac/ResourceHandleMac.mm:
1021         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
1022         authentication challenge sender.
1023         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
1024         authentication sheet.
1025         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
1026         using the new setAuthenticationClient() method.
1027         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
1028         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
1029         the original Mac one, not the one we created for use with authentication sheet. I don't
1030         know when a connection would cancel authentication in practice, so I haven't tested this.
1031
1032 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
1033
1034         Reviewed by Timothy Hatcher.
1035
1036         Web Inspector: breakpoint sidebar entries should allow click over entire list item
1037         https://bugs.webkit.org/show_bug.cgi?id=31411
1038
1039         No new tests; no new functionality, small usability change.
1040
1041         * inspector/front-end/BreakpointsSidebarPane.js:
1042         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
1043         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
1044
1045 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
1046
1047         Reviewed by Timothy Hatcher.
1048
1049         Web Inspector: breakpoints in named evals are not restored after a reload
1050         https://bugs.webkit.org/show_bug.cgi?id=31375
1051
1052         Manual test added
1053
1054         * inspector/front-end/ScriptsPanel.js:
1055         (WebInspector.ScriptsPanel.prototype.addScript):
1056         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
1057
1058 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
1059
1060         Reviewed by Kenneth Rohde Christiansen.
1061
1062         Custom printing shrink factors
1063         https://bugs.webkit.org/show_bug.cgi?id=29042
1064
1065         This reverts commit r49769. The public API for this needs to be reviewed
1066         before its inclusion in Qt.
1067
1068         * page/PrintContext.cpp:
1069         (WebCore::PrintContext::begin):
1070         * page/Settings.cpp:
1071         (WebCore::Settings::Settings):
1072         * page/Settings.h:
1073
1074 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
1075
1076         Reviewed by Pavel Feldman.
1077
1078         Web Inspector: Resource errors/warnings not shown in the Resource tree.
1079
1080         Error/Warning bubbles are not displayed next to the resource in the
1081         Resources panel if those occur before the resource is attached to the tree.
1082         https://bugs.webkit.org/show_bug.cgi?id=31404
1083
1084         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
1085
1086         * inspector/front-end/AbstractTimelinePanel.js:
1087         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
1088         * inspector/front-end/ResourcesPanel.js:
1089         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
1090
1091 2009-11-12  Philippe Normand  <pnormand@igalia.com>
1092
1093         Reviewed by Jan Alonzo.
1094
1095         https://bugs.webkit.org/show_bug.cgi?id=31047
1096         [GTK] Failing test media/video-played-ranges-1.html
1097
1098         Follow-up of r50726, don't block the UI thread when calling
1099         gst_element_get_state(). Also fixed a compilation warning and some
1100         static casts.
1101
1102         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1103         (WebCore::playbackPosition):
1104         (WebCore::MediaPlayerPrivate::seek):
1105         (WebCore::MediaPlayerPrivate::setRate):
1106
1107 2009-11-12  Philippe Normand  <pnormand@igalia.com>
1108
1109         Reviewed by Jan Alonzo.
1110
1111         https://bugs.webkit.org/show_bug.cgi?id=31047
1112         [GTK] Failing test media/video-played-ranges-1.html
1113
1114         don't pause pipeline if already paused, same for play()
1115
1116         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1117         (WebCore::MediaPlayerPrivate::play):
1118         (WebCore::MediaPlayerPrivate::pause):
1119
1120 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
1121
1122         Reviewed by David Levin.
1123
1124         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
1125         Chromium too.
1126         https://bugs.webkit.org/show_bug.cgi?id=31292
1127
1128         No new tests. (Corresponding test for Gtk+ is
1129         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
1130
1131         * page/EventHandler.cpp:
1132         * page/chromium/EventHandlerChromium.cpp:
1133
1134 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
1135
1136         Reviewed by Eric Seidel.
1137
1138         Prevent text inside a multi-column block from being split into columns.
1139
1140         If the tentative height of a multi-column block was too small, we need to
1141         expand the block height and try to layout again, in order to prevent text
1142         from being split into different columns.
1143
1144         CSS Multicolumn text is split awkwardly
1145         https://bugs.webkit.org/show_bug.cgi?id=22249
1146
1147         Test: fast/multicol/single-line.html
1148
1149         * rendering/RenderBlock.cpp:
1150         (WebCore::RenderBlock::layoutColumns):
1151         * rendering/RenderBlock.h:
1152         * rendering/RenderLineBoxList.cpp:
1153         (WebCore::RenderLineBoxList::paint):
1154         * rendering/RenderView.h:
1155         (WebCore::RenderView::setTruncatedAt):
1156         (WebCore::RenderView::setMinimumColumnHeight):
1157         (WebCore::RenderView::minimumColumnHeight):
1158
1159 2009-11-11  Kent Tamura  <tkent@chromium.org>
1160
1161         Reviewed by Darin Adler.
1162
1163         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
1164         https://bugs.webkit.org/show_bug.cgi?id=31195
1165
1166         Test: fast/forms/input-file-re-render.html
1167
1168         * rendering/RenderFileUploadControl.cpp:
1169         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
1170
1171 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
1172
1173         Reviewed by Dimitri Glazkov.
1174
1175         Fixing Chromium's POSIX VFS implementation, by adding the required
1176         "used file descriptors" logic.
1177
1178         https://bugs.webkit.org/show_bug.cgi?id=31275
1179
1180         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
1181
1182 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1183
1184         Reviewed by Oliver Hunt.
1185
1186         need to implement aria tree roles
1187         https://bugs.webkit.org/show_bug.cgi?id=31284
1188
1189         Tests: platform/mac/accessibility/aria-multiselectable.html
1190                platform/mac/accessibility/aria-tree.html
1191
1192         * accessibility/AccessibilityList.cpp:
1193         (WebCore::AccessibilityList::accessibilityIsIgnored):
1194         * accessibility/AccessibilityObject.cpp:
1195         (WebCore::AccessibilityObject::ariaTreeRows):
1196         (WebCore::AccessibilityObject::ariaTreeItemContent):
1197         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
1198         * accessibility/AccessibilityObject.h:
1199         (WebCore::):
1200         (WebCore::AccessibilityObject::isTree):
1201         (WebCore::AccessibilityObject::isTreeItem):
1202         (WebCore::AccessibilityObject::setIsExpanded):
1203         (WebCore::AccessibilityObject::canSetExpandedAttribute):
1204         (WebCore::AccessibilityObject::hierarchicalLevel):
1205         (WebCore::AccessibilityObject::setSelectedRows):
1206         (WebCore::AccessibilityObject::performDefaultAction):
1207         * accessibility/AccessibilityRenderObject.cpp:
1208         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
1209         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1210         (WebCore::AccessibilityRenderObject::isExpanded):
1211         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
1212         (WebCore::AccessibilityRenderObject::elementAttributeValue):
1213         (WebCore::AccessibilityRenderObject::setIsExpanded):
1214         (WebCore::AccessibilityRenderObject::isSelected):
1215         (WebCore::AccessibilityRenderObject::setSelected):
1216         (WebCore::AccessibilityRenderObject::setSelectedRows):
1217         (WebCore::createARIARoleMap):
1218         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
1219         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
1220         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
1221         (WebCore::AccessibilityRenderObject::selectedChildren):
1222         * accessibility/AccessibilityRenderObject.h:
1223         * accessibility/mac/AccessibilityObjectMac.mm:
1224         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
1225         * accessibility/mac/AccessibilityObjectWrapper.mm:
1226         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
1227         (RoleEntry::):
1228         (-[AccessibilityObjectWrapper subrole]):
1229         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1230         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
1231         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
1232         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
1233         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
1234         * html/HTMLAttributeNames.in:
1235
1236 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
1237
1238         Build fix after @r50760 with ENABLE_FILTERS.
1239
1240         * platform/graphics/filters/SourceAlpha.cpp:
1241         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
1242         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
1243           to fillRect.
1244
1245 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
1246
1247         Reviewed by Alexey Proskuryakov.
1248
1249         Fix WebSocket frame parser of frame_type with high-order bit set.
1250         https://bugs.webkit.org/show_bug.cgi?id=30668
1251
1252         If buffer is smaller than frame's length, it should break the loop
1253         instead of reading next byte.
1254
1255         Tests: websocket/tests/frame-length-longer-than-buffer.html
1256                websocket/tests/frame-length-skip.html
1257
1258         * websockets/WebSocketChannel.cpp:
1259         (WebCore::WebSocketChannel::didReceiveData):
1260
1261 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
1262
1263         Reviewed by Adam Barth.
1264
1265         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
1266         https://bugs.webkit.org/show_bug.cgi?id=31345
1267
1268         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
1269
1270         * platform/graphics/chromium/FontCustomPlatformData.cpp:
1271         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
1272         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
1273         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
1274
1275 2009-11-11  Beth Dakin  <bdakin@apple.com>
1276
1277         Build fix. No review needed.
1278
1279         * platform/graphics/gtk/FontGtk.cpp:
1280         (WebCore::Font::drawComplexText):
1281
1282 2009-11-11  Beth Dakin  <bdakin@apple.com>
1283
1284         Build fix. No review needed.
1285
1286         * platform/graphics/cairo/FontCairo.cpp:
1287         (WebCore::Font::drawGlyphs):
1288
1289 2009-11-11  Beth Dakin  <bdakin@apple.com>
1290
1291         Windows build fix. No review needed.
1292
1293         * platform/graphics/win/FontCGWin.cpp:
1294         (WebCore::Font::drawGlyphs):
1295
1296 2009-11-11  Beth Dakin  <bdakin@apple.com>
1297
1298         Reviewed by Simon Fraser.
1299
1300         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
1301         Make -webkit-color-correction work with shadows
1302
1303         From canvas, just send DeviceColorSpace to setShadow() for now.
1304         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
1305         * html/canvas/CanvasRenderingContext2D.cpp:
1306         (WebCore::CanvasRenderingContext2D::setShadow):
1307         (WebCore::CanvasRenderingContext2D::applyShadow):
1308
1309         setShadow() and setPlatformShadow() now take a ColorSpace.
1310         * platform/graphics/GraphicsContext.cpp:
1311         (WebCore::GraphicsContext::setShadow):
1312         * platform/graphics/GraphicsContext.h:
1313         * platform/graphics/cg/GraphicsContextCG.cpp:
1314         (WebCore::createCGColorWithColorSpace): New helper to create a
1315         color in a ColorSpace.
1316         (WebCore::setCGFillColor): Call new helper.
1317         (WebCore::setCGStrokeColor): Call new helper.
1318         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
1319         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1320         (WebCore::GraphicsContext::setPlatformShadow):
1321
1322         Send appropriate ColorSpace to setShadow().
1323         * platform/graphics/mac/FontMac.mm:
1324         (WebCore::Font::drawGlyphs):
1325         * rendering/EllipsisBox.cpp:
1326         (WebCore::EllipsisBox::paint):
1327         * rendering/InlineFlowBox.cpp:
1328         (WebCore::InlineFlowBox::paintTextDecorations):
1329         * rendering/InlineTextBox.cpp:
1330         (WebCore::paintTextWithShadows):
1331         (WebCore::InlineTextBox::paintDecoration):
1332         * rendering/RenderBoxModelObject.cpp:
1333         (WebCore::RenderBoxModelObject::paintBoxShadow):
1334         * rendering/SVGInlineTextBox.cpp:
1335         (WebCore::SVGInlineTextBox::paintCharacters):
1336         * rendering/SVGRenderSupport.cpp:
1337         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
1338
1339         Attempt to keep ports building.
1340         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1341         (WebCore::GraphicsContext::setPlatformShadow):
1342         * platform/graphics/qt/GraphicsContextQt.cpp:
1343         (WebCore::GraphicsContext::setPlatformShadow):
1344         * platform/graphics/skia/GraphicsContextSkia.cpp:
1345         (WebCore::GraphicsContext::setPlatformShadow):
1346         * platform/graphics/wince/GraphicsContextWince.cpp:
1347         (WebCore::GraphicsContext::setPlatformShadow):
1348         * platform/graphics/wx/GraphicsContextWx.cpp:
1349         (WebCore::GraphicsContext::setPlatformShadow):
1350
1351 2009-11-11  Kent Tamura  <tkent@chromium.org>
1352
1353         Reviewed by Darin Adler.
1354
1355         Print the file text of a file upload control in DumpRenderTree for ease of tests.
1356         https://bugs.webkit.org/show_bug.cgi?id=31195
1357
1358         * rendering/RenderFileUploadControl.cpp:
1359         (WebCore::RenderFileUploadControl::paintObject):
1360         (WebCore::RenderFileUploadControl::fileTextValue):
1361         * rendering/RenderFileUploadControl.h:
1362         (WebCore::RenderFileUploadControl::isFileUploadControl):
1363         (WebCore::toRenderFileUploadControl):
1364         * rendering/RenderObject.h:
1365         (WebCore::RenderObject::isFileUploadControl):
1366         * rendering/RenderTreeAsText.cpp:
1367         (WebCore::operator<<):
1368
1369 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
1370
1371         Reviewed by Sam Weinig.
1372
1373         DOM Wrappers for some nodes may not be marked.
1374         https://bugs.webkit.org/show_bug.cgi?id=31380
1375
1376         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
1377         the wrapper for the current world only.  This means that wrappers may be GC'ed
1378         prematurely, and properties lost.
1379
1380         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
1381
1382         * bindings/js/JSAttrCustom.cpp:
1383         (WebCore::JSAttr::markChildren):
1384         * bindings/js/JSDOMBinding.cpp:
1385         (WebCore::markDOMNodeWrapper):
1386         * bindings/js/JSDOMBinding.h:
1387         * bindings/js/JSNamedNodeMapCustom.cpp:
1388         (WebCore::JSNamedNodeMap::markChildren):
1389         * bindings/js/JSNodeCustom.cpp:
1390         (WebCore::JSNode::markChildren):
1391         * bindings/js/JSSVGElementInstanceCustom.cpp:
1392         (WebCore::JSSVGElementInstance::markChildren):
1393         * bindings/js/JSStyleSheetCustom.cpp:
1394         (WebCore::JSStyleSheet::markChildren):
1395
1396 2009-11-11  Ben Murdoch  <benm@google.com>
1397
1398         Reviewed by Darin Adler.
1399
1400         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
1401         https://bugs.webkit.org/show_bug.cgi?id=31384
1402
1403         No functionality change so no tests required.
1404
1405         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
1406
1407 2009-11-11  Jens Alfke  <snej@chromium.org>
1408
1409         Reviewed by Dimitri Glazkov.
1410
1411         The Big De-Inlining. 450k code size reduction (32-bit x86.)
1412         - Various inline functions in V8Binding.h made non-inline.
1413         - Some renaming for consistency.
1414         - New function createRawTemplate().
1415         https://bugs.webkit.org/show_bug.cgi?id=31383
1416
1417         * bindings/scripts/CodeGeneratorV8.pm:
1418         * bindings/v8/V8Binding.cpp:
1419         (WebCore::v8DOMWrapperToNative):
1420         (WebCore::v8ValueToWebCoreString):
1421         (WebCore::v8ValueToAtomicWebCoreString):
1422         (WebCore::toInt32):
1423         (WebCore::toWebCoreString):
1424         (WebCore::toWebCoreStringWithNullCheck):
1425         (WebCore::toAtomicWebCoreStringWithNullCheck):
1426         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
1427         (WebCore::isUndefinedOrNull):
1428         (WebCore::v8Boolean):
1429         (WebCore::v8UndetectableString):
1430         (WebCore::v8StringOrNull):
1431         (WebCore::v8StringOrUndefined):
1432         (WebCore::v8StringOrFalse):
1433         (WebCore::v8StringToWebCoreString):
1434         (WebCore::v8ExternalString):
1435         (WebCore::createRawTemplate):  New function.
1436         * bindings/v8/V8Binding.h:
1437         (WebCore::v8DOMWrapperTo):
1438         (WebCore::v8DOMWrapperToNode):
1439         (WebCore::v8StringToWebCoreString):
1440         (WebCore::v8StringToAtomicWebCoreString):
1441
1442 2009-11-11  Jens Alfke  <snej@chromium.org>
1443
1444         Reviewed by Dimitri Glazkov.
1445
1446         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
1447         event-listener setter into a new subroutine transferHiddenDependency().
1448         https://bugs.webkit.org/show_bug.cgi?id=31377
1449
1450         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
1451         * bindings/v8/V8Utilities.cpp:
1452         (WebCore::transferHiddenDependency):  New.
1453         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
1454
1455 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
1456
1457         Reviewed by Beth Dakin.
1458
1459         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
1460         because there is a CG bug preventing this from working.
1461
1462         * platform/graphics/cg/GraphicsContextCG.cpp:
1463         (WebCore::sRGBColorSpaceRef):
1464
1465 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
1466
1467         Reviewed by Timothy Hatcher.
1468
1469         Check that if Storage panel exists before calling its methods
1470
1471         https://bugs.webkit.org/show_bug.cgi?id=31343
1472
1473         * inspector/front-end/inspector.js:
1474         (WebInspector.addDatabase):
1475         (WebInspector.addCookieDomain):
1476         (WebInspector.addDOMStorage):
1477         (WebInspector.updateDOMStorage):
1478
1479 2009-11-11  Jens Alfke  <snej@chromium.org>
1480
1481         Reviewed by Dimitri Glazkov.
1482
1483         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
1484         times in the generated V8 bindings.
1485         https://bugs.webkit.org/show_bug.cgi?id=31368
1486
1487         * bindings/v8/V8DOMWrapper.cpp:
1488         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
1489         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
1490
1491 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
1492
1493         Reviewed by Timothy Hatcher.
1494
1495         Display the correct summary in the web inspector for the shorthands
1496         border-color, border-width, border-style, margin, and padding.
1497         https://bugs.webkit.org/show_bug.cgi?id=7987
1498
1499         Test: fast/css/shorthands-four-values.html
1500
1501         * css/CSSMutableStyleDeclaration.cpp:
1502         (WebCore::CSSMutableStyleDeclaration::get4Values):
1503         Display the summary information in the same way the shorthand would be
1504         specified in a css rule.
1505
1506 2009-11-11  Jens Alfke  <snej@chromium.org>
1507
1508         Reviewed by Dimitri Glazkov.
1509
1510         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
1511         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
1512         https://bugs.webkit.org/show_bug.cgi?id=31367
1513
1514         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
1515
1516 2009-11-11  Jens Alfke  <snej@chromium.org>
1517
1518         Reviewed by Dimitri Glazkov.
1519
1520         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
1521
1522         * bindings/v8/DOMData.cpp:
1523         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
1524             so it can be inlined by its caller.
1525         * bindings/v8/DOMData.h:
1526         * bindings/v8/MainThreadDOMData.cpp:
1527         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
1528         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
1529         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
1530             and getStore, which inline both calls together.
1531         * bindings/v8/MainThreadDOMData.h:
1532         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
1533         * bindings/v8/V8DOMMap.cpp:
1534         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
1535
1536 2009-11-11  Nate Chapin  <japhet@chromium.org>
1537
1538         Reviewed by Dimitri Glazkov.
1539
1540         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
1541
1542         https://bugs.webkit.org/show_bug.cgi?id=31357
1543
1544         * platform/KURLGoogle.cpp:
1545         (WebCore::isSchemeFirstChar):
1546         (WebCore::isSchemeChar):
1547         (WebCore::KURL::hasPort):
1548         (WebCore::KURL::removePort):
1549         (WebCore::protocolIsValid):
1550
1551 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
1552
1553         Build fix, no reviewed.
1554
1555         Correct setPlatformFillColor and setPlatformStrokeColor calls
1556         to match new ColorSpace-supporting signatures.
1557
1558         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
1559           color space to the set[...]Color calls.
1560
1561 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1562
1563         Reviewed by Sam Weinig.
1564
1565         https://bugs.webkit.org/show_bug.cgi?id=31327
1566         Clean up SocketStreamHandleClient interface
1567
1568         No change in behavior.
1569
1570         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
1571         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
1572         the only client (WebSocketChannel), and it's not clear what this callback's semantics
1573         should be.
1574         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
1575         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
1576         For ResourceHandle, this method is called when the user cancels authentication sheet,
1577         not when something happens with the stream.
1578
1579         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
1580         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
1581
1582         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
1583         callbacks have no real implementation yet.
1584
1585 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
1586
1587         Reviewed by Eric Seidel.
1588
1589         Allow custom memory allocation control for the part of page directory in WebCore
1590         https://bugs.webkit.org/show_bug.cgi?id=31350
1591
1592         Inherits the following classes from Noncopyable because these are instantiated
1593         by 'new' and these are no need to be copyable:
1594
1595         class DragController         - instantiated at: WebCore/page/Page.cpp:107
1596         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
1597         class Settings               - instantiated at: WebCore/page/Page.cpp:116
1598         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
1599         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
1600         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
1601         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1602         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1603         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
1604
1605         Inherits PropertyWrapperBase class from Noncopyable because (its child class)
1606         PropertyWrapper is instantiated by 'new' in
1607         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1608
1609         * page/DragController.h:
1610         * page/EventHandler.h:
1611         * page/FocusController.h:
1612         * page/FrameView.cpp:
1613         * page/PluginHalter.h:
1614         * page/Settings.h:
1615         * page/UserScript.h:
1616         * page/UserStyleSheet.h:
1617         * page/XSSAuditor.h:
1618         * page/animation/AnimationBase.cpp:
1619
1620 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1621
1622         Reviewed by Kenneth Rohde Christiansen.
1623
1624         https://bugs.webkit.org/show_bug.cgi?id=31323
1625         Fix a few compiler warnings
1626
1627         No new tests as there is no new functionality.
1628
1629         * editing/htmlediting.cpp:
1630         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1631         parentheses to silence gcc 4.4 -Wparentheses warnings
1632
1633 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1634
1635         Reviewed by Mark Rowe.
1636
1637         Set m_hasPendingGeometryChange to true by default, so that
1638         at least one call to NPP_SetWindow is executed, which is
1639         needed by the DRT plugin testing framework.
1640
1641         * plugins/PluginView.cpp:
1642         (WebCore::PluginView::PluginView):
1643
1644 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
1645
1646         Rubber-stamped by Kenneth Rohde Christiansen.
1647
1648         https://bugs.webkit.org/show_bug.cgi?id=31348
1649         [Qt] Remove unnecessary LUT creator from WebCore.pro
1650
1651         * WebCore.pro:
1652
1653 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1654
1655         Reviewed by Tor Arne Vestbø.
1656
1657         Introduce a function for querying the input method status
1658         in QWebPageClient.
1659
1660         * platform/qt/QWebPageClient.h:
1661
1662 2009-11-11  Benjamin Otte  <otte@gnome.org>
1663
1664         Reviewed by Jan Alonzo.
1665
1666         [GTK] Black artifacts in youtube.com/html5
1667
1668         Paint the video to the given size. It's the job of the callers to keep
1669         track of aspect ratio. RenderVideo.cpp does it for the <video>
1670         element.
1671         https://bugs.webkit.org/show_bug.cgi?id=30925
1672
1673         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1674         (WebCore::MediaPlayerPrivate::paint):
1675
1676 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1677
1678         Reviewed by Reviewed by Jan Alonzo.
1679
1680         https://bugs.webkit.org/show_bug.cgi?id=30901
1681         [Gtk] Need to de-lint the Atk a11y code
1682
1683         Cleaned up some missed capitalization style-guideline violations.
1684
1685         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1686
1687 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1688
1689         Reviewed by Eric Seidel.
1690
1691         [Qt] Make the default style background color valid.
1692         Currently the color is transparent but invalid, this causes
1693         list boxes in QtWebKit to be drawn with a black background
1694         since r49242.
1695         https://bugs.webkit.org/show_bug.cgi?id=31295
1696
1697         * rendering/style/RenderStyle.h:
1698         (WebCore::InheritedFlags::initialBackgroundColor):
1699         * rendering/style/StyleBackgroundData.cpp:
1700         (WebCore::StyleBackgroundData::StyleBackgroundData):
1701
1702 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1703
1704         Reviewed by Geoff Garen.
1705
1706         Simplify the ownership model for worlds - rather than having a pair of weak references
1707         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1708         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
1709         back forward cache.
1710
1711         * WebCore.base.exp:
1712         * bindings/js/JSDOMBinding.cpp:
1713         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1714         * bindings/js/JSDOMBinding.h:
1715         (WebCore::DOMWrapperWorld::forgetDocument):
1716         * bindings/js/ScriptCachedFrameData.cpp:
1717         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1718         (WebCore::ScriptCachedFrameData::restore):
1719         (WebCore::ScriptCachedFrameData::clear):
1720         * bindings/js/ScriptCachedFrameData.h:
1721         * bindings/js/ScriptController.cpp:
1722         (WebCore::ScriptController::~ScriptController):
1723         (WebCore::ScriptController::clearWindowShell):
1724         (WebCore::ScriptController::initScript):
1725         (WebCore::ScriptController::updateDocument):
1726         * bindings/js/ScriptController.h:
1727
1728 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
1729
1730         Reviewed by Darin Adler.
1731
1732         rename counter to makeCounterNode in RenderCounter.cpp
1733         https://bugs.webkit.org/show_bug.cgi?id=31289
1734
1735         No new test because this is just a small refactoring.
1736
1737         * rendering/RenderCounter.cpp:
1738         (WebCore::findPlaceForCounter):
1739         (WebCore::makeCounterNode):
1740         (WebCore::RenderCounter::originalText):
1741
1742 2009-11-10  Daniel Bates  <dbates@webkit.org>
1743
1744         Reviewed by Oliver Hunt.
1745
1746         https://bugs.webkit.org/show_bug.cgi?id=30754
1747
1748         Patch 2 of 2.
1749
1750         Removed method EventHandler::dragSourceMovedTo, since it is no longer
1751         needed. This method fired a drag event whenever the mouse moved, but
1752         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1753         model independent of when the mouse moves. See "Among other changes..."
1754         in the change log for patch 1 for more details.
1755
1756         * WebCore.DragSupport.exp:
1757         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1758         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1759         * page/EventHandler.h:
1760
1761 2009-11-10  Daniel Bates  <dbates@webkit.org>
1762
1763         Reviewed by Oliver Hunt.
1764
1765         https://bugs.webkit.org/show_bug.cgi?id=30754
1766
1767         Patch 1 of 2.
1768
1769         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1770         the drag event should always fire before the dragover event.
1771
1772         In fixing this bug, this patch also makes our drag processing model
1773         conform to the HTML 5 spec.
1774
1775         Among the changes, this patch ensures that the drag event isn't fired outside
1776         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1777         Currently, the drag event is fired whenever the mouse button is down and the OS
1778         detects the mouse moved. But, as per the spec, the drag event should
1779         fire approx. every 350ms so long as the mouse button is down.
1780
1781         Test: fast/events/drag-and-drop-fire-drag-dragover.html
1782
1783         * page/EventHandler.cpp:
1784         (WebCore::EventHandler::clear):
1785         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1786         Modified to determine when we are in the correct instance of EventHandler to service the drag
1787         and drop operation.
1788         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1789         into this method.
1790         (WebCore::EventHandler::cancelDragAndDrop):
1791         (WebCore::EventHandler::performDragAndDrop):
1792         (WebCore::EventHandler::clearDragState):
1793         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1794         we should fire both drag and dragover events or only the dragover event.
1795
1796 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
1797
1798         Reviewed by Dimitri Glazkov.
1799
1800         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1801         https://bugs.webkit.org/show_bug.cgi?id=31301
1802
1803         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1804
1805         Allowed passing V8Proxy for the calling JS context:
1806         * bindings/v8/V8DOMWrapper.h:
1807         (WebCore::V8DOMWrapper::getXPathNSResolver):
1808         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1809         (WebCore::V8CustomXPathNSResolver::create):
1810         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1811         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1812         * bindings/v8/custom/V8CustomXPathNSResolver.h:
1813         * bindings/v8/custom/V8DocumentCustom.cpp:
1814         (WebCore::CALLBACK_FUNC_DECL):
1815
1816 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
1817
1818         Reviewed by Timothy Hatcher.
1819
1820         Implement URL decomposition IDL attributes for HTMLAnchorElement.
1821         https://bugs.webkit.org/show_bug.cgi?id=29972.
1822
1823         Add methods for setting different parts of the URL in href attribute.
1824
1825         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1826                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1827                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1828                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1829                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1830                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1831                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1832
1833         * bindings/js/JSLocationCustom.cpp:
1834         (WebCore::JSLocation::setPort):
1835         * html/HTMLAnchorElement.cpp:
1836         (WebCore::parsePortFromStringPosition):
1837         (WebCore::HTMLAnchorElement::setHash):
1838         (WebCore::HTMLAnchorElement::setHost):
1839         (WebCore::HTMLAnchorElement::setHostname):
1840         (WebCore::HTMLAnchorElement::setPathname):
1841         (WebCore::HTMLAnchorElement::setPort):
1842         (WebCore::HTMLAnchorElement::setProtocol):
1843         (WebCore::HTMLAnchorElement::setSearch):
1844         * html/HTMLAnchorElement.h:
1845         * html/HTMLAnchorElement.idl:
1846         * loader/FrameLoader.cpp:
1847         (WebCore::FrameLoader::iconURL):
1848         * platform/KURL.cpp:
1849         (WebCore::KURL::removePort):
1850         (WebCore::KURL::setPort):
1851         (WebCore::KURL::prettyURL):
1852         (WebCore::protocolIsValid):
1853         * platform/KURL.h:
1854         (WebCore::KURL::canSetHostOrPort):
1855         (WebCore::KURL::canSetPathname):
1856         (WebCore::KURL::hasPort):
1857         * platform/network/soup/ResourceHandleSoup.cpp:
1858         (WebCore::):
1859
1860 2009-11-10  Nate Chapin  <japhet@chromium.org>
1861
1862         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1863
1864         * platform/chromium/PopupMenuChromium.cpp:
1865         (WebCore::PopupContainer::paintBorder):
1866         (WebCore::PopupListBox::paint):
1867         (WebCore::PopupListBox::paintRow):
1868         * platform/graphics/chromium/TransparencyWin.cpp:
1869         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1870         * platform/graphics/skia/GraphicsContextSkia.cpp:
1871         (WebCore::GraphicsContext::fillRect):
1872         (WebCore::GraphicsContext::fillRoundedRect):
1873         (WebCore::GraphicsContext::setPlatformFillColor):
1874         (WebCore::GraphicsContext::setPlatformStrokeColor):
1875         * rendering/RenderMediaControlsChromium.cpp:
1876         (WebCore::paintMediaSlider):
1877         (WebCore::paintMediaVolumeSlider):
1878         (WebCore::paintMediaTimelineContainer):
1879         * rendering/RenderThemeChromiumMac.mm:
1880         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1881
1882 2009-11-10  Brady Eidson  <beidson@apple.com>
1883
1884         Reviewed by Sam Weinig.
1885
1886         Repro crash saving pcmag.com article as a webarchive.
1887         <rdar://problem/7381219> and https://webkit.org/b/31322
1888
1889         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1890
1891         * css/CSSStyleSheet.cpp:
1892         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1893           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1894
1895 2009-11-10  Beth Dakin  <bdakin@apple.com>
1896
1897         Attempt 2 to fix Tiger build. No review needed.
1898
1899         * platform/graphics/cg/GraphicsContextCG.cpp:
1900         (WebCore::deviceRGBColorSpaceRef):
1901         (WebCore::sRGBColorSpaceRef):
1902
1903 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
1904
1905         wx build fix. Changes needed after r50760.
1906
1907         * platform/graphics/wx/GraphicsContextWx.cpp:
1908         (WebCore::GraphicsContext::GraphicsContext):
1909         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1910         (WebCore::drawTextWithSpacing):
1911
1912 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1913
1914         Qt build fix.
1915
1916         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1917         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1918
1919 2009-11-10  Beth Dakin  <bdakin@apple.com>
1920
1921         Tiger build fix. No review needed.
1922
1923         * platform/graphics/cg/GraphicsContextCG.cpp:
1924         (WebCore::sRGBColorSpaceRef):
1925
1926 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1927
1928         Reviewed by Dan Bernstein.
1929
1930         https://bugs.webkit.org/show_bug.cgi?id=31312
1931         Decouple authentication panel callbacks from ResourceHandle
1932
1933         No change in functionality.
1934
1935         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1936         ResourceHandle as delegate.
1937
1938         * WebCore.vcproj/WebCore.vcproj:
1939         * platform/network/AuthenticationClient.h: Added.
1940         Added a new interface for listening to authentication panel notifications.
1941
1942         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1943         it wants with the project file.
1944
1945         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1946         interface class.
1947         (WebCore::AuthenticationClient::deref): Ditto.
1948
1949         * platform/network/ResourceHandle.h:
1950         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1951         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1952
1953         * platform/network/cf/AuthenticationCF.cpp:
1954         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1955         (WebCore::AuthenticationChallenge::platformCompare):
1956         * platform/network/cf/AuthenticationChallenge.h:
1957         (WebCore::AuthenticationChallenge::authenticationClient):
1958         * platform/network/chromium/AuthenticationChallenge.h:
1959         (WebCore::AuthenticationChallenge::authenticationClient):
1960         * platform/network/curl/AuthenticationChallenge.h:
1961         (WebCore::AuthenticationChallenge::authenticationClient):
1962         Keeping a reference to AuthenticationClient, not to ResourceHandle.
1963
1964 2009-11-10  Beth Dakin  <bdakin@apple.com>
1965
1966        Second attempted gtk build fix. No review needed.
1967
1968         * html/canvas/CanvasStyle.cpp:
1969         (WebCore::CanvasStyle::applyStrokeColor):
1970
1971
1972 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1973
1974         Reviewed by Geoff Garen.
1975
1976         Fix back/forwards cache with JSC isolated worlds.
1977         https://bugs.webkit.org/show_bug.cgi?id=31310
1978         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1979
1980         Store the global object for all worlds, not just the normal world.
1981         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1982         so we can forget global objects if a world goes away.
1983
1984         * bindings/js/JSDOMBinding.cpp:
1985         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1986         * bindings/js/JSDOMBinding.h:
1987         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
1988         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
1989         * bindings/js/ScriptCachedFrameData.cpp:
1990         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1991         (WebCore::ScriptCachedFrameData::forgetWorld):
1992         (WebCore::ScriptCachedFrameData::domWindow):
1993         (WebCore::ScriptCachedFrameData::restore):
1994         (WebCore::ScriptCachedFrameData::clear):
1995         * bindings/js/ScriptCachedFrameData.h:
1996         * bindings/js/ScriptController.h:
1997
1998 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1999
2000         [Qt] Unreviewed buildfix after r50760.
2001
2002         * platform/graphics/qt/GraphicsContextQt.cpp:
2003         (WebCore::GraphicsContext::GraphicsContext):
2004
2005 2009-11-10  Beth Dakin  <bdakin@apple.com>
2006
2007         Attempted build fix. (No review needed.)
2008
2009         * GNUmakefile.am: Adding ColorSpace.h
2010
2011 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
2012
2013         Reviewed by NOBODY - Build Fix.
2014
2015         Updated function calls to take a ColorSpace argument, passing
2016         in DeviceColorSpace for now - this should be fixed. Also added
2017         ColorSpace.h to WebCore project.
2018
2019         * WebCore.vcproj/WebCore.vcproj:
2020         * platform/graphics/win/FontCGWin.cpp:
2021         (WebCore::Font::drawGlyphs):
2022         * platform/graphics/win/GraphicsContextCGWin.cpp:
2023         (WebCore::GraphicsContext::GraphicsContext):
2024         * platform/win/PopupMenuWin.cpp:
2025         (WebCore::PopupMenu::paint):
2026         * platform/win/WebCoreTextRenderer.cpp:
2027         (WebCore::doDrawTextAtPoint):
2028         * rendering/RenderThemeSafari.cpp:
2029         (WebCore::RenderThemeSafari::paintMenuListButton):
2030
2031 2009-11-10  Jens Alfke  <snej@chromium.org>
2032
2033         Reviewed by Darin Adler.
2034
2035         Optimizations to Element::getAttribute
2036         https://bugs.webkit.org/show_bug.cgi?id=30926
2037
2038         * dom/Element.cpp:
2039         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
2040         * dom/NamedAttrMap.cpp:
2041         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
2042         * platform/text/PlatformString.h:
2043         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
2044
2045 2009-11-10  Beth Dakin  <bdakin@apple.com>
2046
2047         Reviewed by Darin Adler.
2048
2049         Fix for <rdar://problem/7059710>
2050         -and corresponding-
2051         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
2052         color-correction for CSS colors
2053
2054         New exported symbol for GraphicsContext::fillColor() which now
2055         accepts a ColorSpace as an optional parameter.
2056         * WebCore.base.exp:
2057
2058         Added a new file, ColorSpace.h, to define the ColorSpace enum.
2059         * WebCore.xcodeproj/project.pbxproj:
2060
2061         Computed Style for -webkit-color-correction
2062         * css/CSSComputedStyleDeclaration.cpp:
2063         (WebCore::):
2064         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2065
2066         Parse -webkit-color-correction
2067         * css/CSSParser.cpp:
2068         (WebCore::CSSParser::parseValue):
2069
2070        Map CSS identifiers to the appropriate values of the ColorSpace enum
2071         * css/CSSPrimitiveValueMappings.h:
2072         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2073         (WebCore::CSSPrimitiveValue::operator ColorSpace):
2074
2075         New property -webkit-color-correction
2076         * css/CSSPropertyNames.in:
2077
2078         Map -webkit-color-correction into the RenderStyle.
2079         * css/CSSStyleSelector.cpp:
2080         (WebCore::CSSStyleSelector::applyProperty):
2081
2082         Add new value sRGB.
2083         * css/CSSValueKeywords.in:
2084
2085         Comment out the reference to sRGB since it will now be inherited as
2086         a value from CSSValueKeywords.
2087         * css/SVGCSSValueKeywords.in:
2088
2089         Definition of the ColorSpace enum.
2090         * platform/graphics/ColorSpace.h: Added.
2091         (WebCore::):
2092
2093         These functions all now take a ColorSpace as a parameter.
2094         * platform/graphics/GraphicsContext.cpp:
2095         (WebCore::GraphicsContext::setStrokeColor):
2096         (WebCore::GraphicsContext::setFillColor):
2097         (WebCore::GraphicsContext::drawHighlightForText):
2098
2099         Return the appropriate ColorSpace.
2100         (WebCore::GraphicsContext::strokeColorSpace):
2101         (WebCore::GraphicsContext::fillColorSpace):
2102
2103         These functions all call other functions which require a ColorSpace
2104         as a parameter.
2105         (WebCore::GraphicsContext::setStrokePattern):
2106         (WebCore::GraphicsContext::setFillPattern):
2107         (WebCore::GraphicsContext::setStrokeGradient):
2108         (WebCore::GraphicsContext::setFillGradient):
2109
2110         All of the GraphicsContext functions that take a Color should now
2111         also take a ColorSpace.
2112         * platform/graphics/GraphicsContext.h:
2113
2114         Added new member variables stokeColorSpace and fillColorSpace.
2115         * platform/graphics/GraphicsContextPrivate.h:
2116         (WebCore::GraphicsContextState::GraphicsContextState):
2117
2118         Attempt to keep the Cairo port building with all of the massive
2119         changes to GraphicsContext.
2120         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2121         (WebCore::GraphicsContext::fillRect):
2122         (WebCore::GraphicsContext::setPlatformFillColor):
2123         (WebCore::GraphicsContext::setPlatformStrokeColor):
2124         (WebCore::GraphicsContext::fillRoundedRect):
2125
2126
2127         * platform/graphics/cg/GraphicsContextCG.cpp:
2128         (WebCore::sRGBColorSpaceRef): New static function that returns a
2129         CGColorSpaceRef for the sRGB color space.
2130         (WebCore::deviceRGBColorSpaceRef): New static function that returns
2131         a CGColorSpaceRef for the device RGB color space.
2132
2133         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and
2134         sets the fill color to the specified color in the given ColorSpace.
2135         (WebCore::setCGStrokeColor): Same, but for stroke.
2136
2137         (WebCore::setCGFillColorSpace): New static to set the
2138         CGFillColorSpace to the given ColorSpace
2139         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
2140
2141         Send ColorSpaces when appropriate, set ColorSpaces when
2142         appropriate, and check ColorSpaces when appropriate.
2143         (WebCore::GraphicsContext::GraphicsContext):
2144         (WebCore::GraphicsContext::drawRect):
2145         (WebCore::GraphicsContext::drawLine):
2146         (WebCore::GraphicsContext::fillPath):
2147         (WebCore::GraphicsContext::strokePath):
2148         (WebCore::GraphicsContext::fillRect):
2149         (WebCore::GraphicsContext::fillRoundedRect):
2150         (WebCore::GraphicsContext::strokeRect):
2151         (WebCore::GraphicsContext::drawLineForText):
2152         (WebCore::GraphicsContext::setPlatformStrokeColor):
2153         (WebCore::GraphicsContext::setPlatformFillColor):
2154
2155         Attempt to keep Haiku building.
2156         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
2157         (WebCore::GraphicsContext::fillRect):
2158         (WebCore::GraphicsContext::fillRoundedRect):
2159         (WebCore::GraphicsContext::setPlatformStrokeColor):
2160         (WebCore::GraphicsContext::setPlatformFillColor):
2161
2162         Attempt to keep QT building.
2163         * platform/graphics/qt/GraphicsContextQt.cpp:
2164         (WebCore::GraphicsContext::fillRect):
2165         (WebCore::GraphicsContext::fillRoundedRect):
2166         (WebCore::GraphicsContext::setPlatformStrokeColor):
2167         (WebCore::GraphicsContext::setPlatformFillColor):
2168
2169         Attempt to keep Wince building.
2170         * platform/graphics/wince/GraphicsContextWince.cpp:
2171         (WebCore::GraphicsContext::fillRect):
2172         (WebCore::GraphicsContext::setPlatformFillColor):
2173         (WebCore::GraphicsContext::setPlatformStrokeColor):
2174         (WebCore::GraphicsContext::clearRect):
2175         (WebCore::GraphicsContext::fillRoundedRect):
2176         (WebCore::GraphicsContext::setPlatformShadow):
2177
2178         Attempt to keep WX building.
2179         * platform/graphics/wx/GraphicsContextWx.cpp:
2180         (WebCore::GraphicsContext::fillRect):
2181         (WebCore::GraphicsContext::fillRoundedRect):
2182         (WebCore::GraphicsContext::setPlatformStrokeColor):
2183         (WebCore::GraphicsContext::setPlatformFillColor):
2184
2185         Added functions colorSpace() and setColorSpace()
2186         * rendering/style/RenderStyle.h:
2187         (WebCore::InheritedFlags::colorSpace):
2188         (WebCore::InheritedFlags::setColorSpace):
2189
2190         The ColorSpace is stored here.
2191         * rendering/style/StyleRareInheritedData.cpp:
2192         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2193         (WebCore::StyleRareInheritedData::operator==):
2194         * rendering/style/StyleRareInheritedData.h:
2195
2196         All of these call sites call GraphicsContext functions which now
2197         require ColorSpaces.
2198         * editing/SelectionController.cpp:
2199         (WebCore::SelectionController::paintCaret):
2200         * html/canvas/CanvasRenderingContext2D.cpp:
2201         (WebCore::CanvasRenderingContext2D::drawTextInternal):
2202         * html/canvas/CanvasStyle.cpp:
2203         (WebCore::CanvasStyle::applyStrokeColor):
2204         (WebCore::CanvasStyle::applyFillColor):
2205         * inspector/InspectorController.cpp:
2206         (WebCore::drawOutlinedQuad):
2207         * page/FrameView.cpp:
2208         (WebCore::FrameView::paintContents):
2209         * platform/ScrollbarTheme.h:
2210         (WebCore::ScrollbarTheme::paintScrollCorner):
2211         * platform/ScrollbarThemeComposite.cpp:
2212         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
2213         * platform/graphics/Image.cpp:
2214         (WebCore::Image::fillWithSolidColor):
2215         * platform/graphics/mac/FontMac.mm:
2216         (WebCore::Font::drawGlyphs):
2217         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2218         (WebCore::MediaPlayerPrivate::paint):
2219         * rendering/EllipsisBox.cpp:
2220         (WebCore::EllipsisBox::paint):
2221         * rendering/InlineFlowBox.cpp:
2222         (WebCore::InlineFlowBox::paintTextDecorations):
2223         * rendering/InlineTextBox.cpp:
2224         (WebCore::updateGraphicsContext):
2225         (WebCore::paintTextWithShadows):
2226         (WebCore::InlineTextBox::paint):
2227         (WebCore::InlineTextBox::paintSelection):
2228         (WebCore::InlineTextBox::paintCompositionBackground):
2229         (WebCore::InlineTextBox::paintDecoration):
2230         (WebCore::InlineTextBox::paintTextMatchMarker):
2231         (WebCore::InlineTextBox::paintCompositionUnderline):
2232         * rendering/InlineTextBox.h:
2233         * rendering/RenderBlock.cpp:
2234         (WebCore::RenderBlock::fillHorizontalSelectionGap):
2235         (WebCore::RenderBlock::fillVerticalSelectionGap):
2236         (WebCore::RenderBlock::fillLeftSelectionGap):
2237         (WebCore::RenderBlock::fillRightSelectionGap):
2238         * rendering/RenderBoxModelObject.cpp:
2239         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2240         (WebCore::RenderBoxModelObject::paintBoxShadow):
2241         * rendering/RenderFileUploadControl.cpp:
2242         (WebCore::RenderFileUploadControl::paintObject):
2243         * rendering/RenderFrameSet.cpp:
2244         (WebCore::RenderFrameSet::paintColumnBorder):
2245         (WebCore::RenderFrameSet::paintRowBorder):
2246         * rendering/RenderImage.cpp:
2247         (WebCore::RenderImage::paintReplaced):
2248         * rendering/RenderLayer.cpp:
2249         (WebCore::RenderLayer::paintScrollCorner):
2250         (WebCore::RenderLayer::paintResizer):
2251         * rendering/RenderListBox.cpp:
2252         (WebCore::RenderListBox::paintItemForeground):
2253         (WebCore::RenderListBox::paintItemBackground):
2254         * rendering/RenderListMarker.cpp:
2255         (WebCore::RenderListMarker::paint):
2256         * rendering/RenderObject.cpp:
2257         (WebCore::RenderObject::drawLineForBoxSide):
2258         (WebCore::RenderObject::drawArcForBoxSide):
2259         * rendering/RenderReplaced.cpp:
2260         (WebCore::RenderReplaced::paint):
2261         * rendering/RenderScrollbarTheme.cpp:
2262         (WebCore::RenderScrollbarTheme::paintScrollCorner):
2263         * rendering/RenderThemeMac.mm:
2264         (WebCore::RenderThemeMac::paintMenuListButton):
2265         * rendering/RenderView.cpp:
2266         (WebCore::RenderView::paintBoxDecorations):
2267         * rendering/RenderWidget.cpp:
2268         (WebCore::RenderWidget::paint):
2269         * rendering/SVGInlineTextBox.cpp:
2270         (WebCore::SVGInlineTextBox::paintSelection):
2271         * svg/graphics/SVGPaintServerGradient.cpp:
2272         (WebCore::SVGPaintServerGradient::setup):
2273         * svg/graphics/SVGPaintServerSolid.cpp:
2274         (WebCore::SVGPaintServerSolid::setup):
2275
2276 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
2277
2278         Reviewed by Timothy Hatcher.
2279
2280         Web Inspector: Speed up syntax highlighter
2281         https://bugs.webkit.org/show_bug.cgi?id=31291
2282
2283         * inspector/front-end/SourceFrame.js:
2284         (WebInspector.SourceFrame.prototype._loaded):
2285         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
2286         (WebInspector.SourceSyntaxHighlighter.prototype.process):
2287         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
2288         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
2289         (WebInspector.CSSSourceSyntaxHighlighter):
2290         (WebInspector.JavaScriptSourceSyntaxHighlighter):
2291
2292 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
2293
2294         Reviewed by Eric Seidel.
2295
2296         Remove session storage setting
2297         https://bugs.webkit.org/show_bug.cgi?id=31279
2298
2299         Remove session storage from Settings.  It was added temporarily so we could
2300         disable it by default at runtime in Chromium.  We now disable these things in a
2301         different way, so it's time to remove it.  Qt also depended on this setting for
2302         a short period of time, but after talking to them we agreed that it should be
2303         removed.
2304
2305         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
2306
2307         * page/DOMWindow.cpp:
2308         (WebCore::DOMWindow::sessionStorage):
2309         * page/Settings.cpp:
2310         (WebCore::Settings::Settings):
2311         * page/Settings.h:
2312
2313 2009-11-10  Dan Bernstein  <mitz@apple.com>
2314
2315         Reviewed by Eric Carlson and Darin Adler.
2316
2317         WebCore part of making full-screen video pause during scrubbing.
2318
2319         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
2320         and HTMLMediaElement::endScrubbing().
2321
2322 2009-11-10  Anton Muhin  <antonm@chromium.org>
2323
2324         Reviewed by Adam Barth.
2325
2326         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
2327         https://bugs.webkit.org/show_bug.cgi?id=31051
2328
2329         * bindings/v8/V8GCController.cpp:
2330         (WebCore::V8GCController::gcEpilogue):
2331         (WebCore::V8GCController::checkMemoryUsage):
2332         * bindings/v8/V8GCController.h:
2333         * bindings/v8/V8Proxy.cpp:
2334         (WebCore::V8Proxy::evaluate):
2335         (WebCore::V8Proxy::runScript):
2336         (WebCore::V8Proxy::callFunction):
2337
2338 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
2339
2340         Reviewed by Darin Adler.
2341
2342         Allow custom memory allocation control for the part of loader directory in WebCore
2343         https://bugs.webkit.org/show_bug.cgi?id=31161
2344
2345         Inherits the following classes from Noncopyable because these are instantiated
2346         by 'new' and these are no need to be copyable:
2347
2348         class Request - WebCore/loader/loader.cpp:100
2349         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2350         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2351         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2352         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2353         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2354
2355         Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
2356         MainThreadBridge is instantiated by 'new' in
2357         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2358
2359         ThreadableLoaderClient's inheriting has been changed to public.
2360
2361         * loader/ImageLoader.cpp:
2362         * loader/ProgressTracker.cpp:
2363         * loader/RedirectScheduler.cpp:
2364         * loader/Request.h:
2365         * loader/ThreadableLoaderClient.h:
2366         * loader/WorkerThreadableLoader.h:
2367         * loader/appcache/ApplicationCacheHost.h:
2368         * loader/appcache/ApplicationCacheStorage.h:
2369
2370 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2371
2372         Reviewed by Eric Seidel.
2373
2374         https://bugs.webkit.org/show_bug.cgi?id=31047
2375         [GTK] Failing test media/video-played-ranges-1.html
2376
2377         WebKit coding style fixes.
2378
2379         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2380         (WebCore::mediaPlayerPrivateMessageCallback):
2381         (WebCore::MediaPlayerPrivate::naturalSize):
2382         (WebCore::MediaPlayerPrivate::paint):
2383         (WebCore::mimeTypeCache):
2384
2385 2009-11-10  Oliver Hunt  <oliver@apple.com>
2386
2387         Remove build failure introduced by earlier build fix.
2388
2389         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2390
2391 2009-11-10  Oliver Hunt  <oliver@apple.com>
2392
2393         Is this the last build fix? grep tells me yes.
2394
2395         * bindings/v8/custom/V8DocumentCustom.cpp:
2396         (WebCore::CALLBACK_FUNC_DECL):
2397
2398 2009-11-10  Oliver Hunt  <oliver@apple.com>
2399
2400         Hopefully the last one.  Why aren't these autogenerated?
2401
2402         * bindings/v8/V8DOMWrapper.cpp:
2403         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
2404         (WebCore::V8DOMWrapper::getTemplate):
2405         (WebCore::V8DOMWrapper::convertToV8Object):
2406
2407 2009-11-10  Oliver Hunt  <oliver@apple.com>
2408
2409         Another chrome build fix.
2410
2411         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
2412         (WebCore::CALLBACK_FUNC_DECL):
2413
2414 2009-11-10  Oliver Hunt  <oliver@apple.com>
2415
2416         Yet another chrome buildfix
2417
2418         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2419         (WebCore::CALLBACK_FUNC_DECL):
2420         * bindings/v8/custom/V8WebGLArrayCustom.h:
2421         (WebCore::constructCanvasArray):
2422         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2423         (WebCore::CALLBACK_FUNC_DECL):
2424         (WebCore::INDEXED_PROPERTY_GETTER):
2425         (WebCore::INDEXED_PROPERTY_SETTER):
2426         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2427         (WebCore::CALLBACK_FUNC_DECL):
2428         (WebCore::INDEXED_PROPERTY_GETTER):
2429         (WebCore::INDEXED_PROPERTY_SETTER):
2430         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2431         (WebCore::CALLBACK_FUNC_DECL):
2432         (WebCore::INDEXED_PROPERTY_GETTER):
2433         (WebCore::INDEXED_PROPERTY_SETTER):
2434         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2435         (WebCore::CALLBACK_FUNC_DECL):
2436         (WebCore::vertexAttribAndUniformHelperf):
2437         (WebCore::uniformHelperi):
2438         (WebCore::uniformMatrixHelper):
2439         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2440         (WebCore::CALLBACK_FUNC_DECL):
2441         (WebCore::INDEXED_PROPERTY_GETTER):
2442         (WebCore::INDEXED_PROPERTY_SETTER):
2443         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2444         (WebCore::CALLBACK_FUNC_DECL):
2445         (WebCore::INDEXED_PROPERTY_GETTER):
2446         (WebCore::INDEXED_PROPERTY_SETTER):
2447         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2448         (WebCore::CALLBACK_FUNC_DECL):
2449         (WebCore::INDEXED_PROPERTY_GETTER):
2450         (WebCore::INDEXED_PROPERTY_SETTER):
2451         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2452         (WebCore::CALLBACK_FUNC_DECL):
2453         (WebCore::INDEXED_PROPERTY_GETTER):
2454         (WebCore::INDEXED_PROPERTY_SETTER):
2455
2456 2009-11-10  Oliver Hunt  <oliver@apple.com>
2457
2458         Chrome build fix.
2459
2460         * bindings/v8/V8Index.h:
2461
2462 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2463
2464         Reviewed by Reviewed by Jan Alonzo.
2465
2466         https://bugs.webkit.org/show_bug.cgi?id=30901
2467         [Gtk] Need to de-lint the Atk a11y code
2468
2469         Removal of various and sundry style-violating nits.
2470
2471         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2472
2473 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2474
2475         Reviewed by Jan Alonzo.
2476
2477         https://bugs.webkit.org/show_bug.cgi?id=31047
2478         [GTK] Failing test media/video-played-ranges-1.html
2479
2480         Fix playback rate setter by remembering the rate was changed. Also
2481         correctly handle reverse playback by doing a seek from end to
2482         beginning of the media.
2483
2484         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2485         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
2486         (WebCore::MediaPlayerPrivate::currentTime):
2487         (WebCore::MediaPlayerPrivate::seek):
2488         (WebCore::MediaPlayerPrivate::hasAudio):
2489         (WebCore::MediaPlayerPrivate::setVolume):
2490         (WebCore::MediaPlayerPrivate::setRate):
2491         (WebCore::MediaPlayerPrivate::updateStates):
2492         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2493
2494 2009-11-10  Oliver Hunt  <oliver@apple.com>
2495
2496         Reviewed by Maciej Stachowiak.
2497
2498         Rename 3D Canvas related classes to use WebGL prefix
2499         https://bugs.webkit.org/show_bug.cgi?id=29095
2500
2501         Automatic rename of all WebGL related types from Canvas* to
2502         WebGL* per more recent version of the WebGL spec.
2503
2504         Due to the automatic rename I've removed the 600+ line change list.
2505
2506 2009-11-09  Dirk Schulze  <krit@webkit.org>
2507
2508         Reviewed by Oliver Hunt.
2509
2510         SVG feDisplacementMap is not implemented
2511         [https://bugs.webkit.org/show_bug.cgi?id=31255]
2512
2513         This is the implementation of the SVG filter effect
2514         feDisplacementMap.
2515
2516         Test: svg/filters/feDisplacementMap.svg
2517
2518         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
2519         (WebCore::FEDisplacementMap::apply):
2520
2521 2009-11-09  Kent Tamura  <tkent@chromium.org>
2522
2523         Reviewed by Darin Adler.
2524
2525         Add a comment about null strings and hash functions.
2526         https://bugs.webkit.org/show_bug.cgi?id=29118
2527
2528         * platform/text/StringHash.h:
2529
2530 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2531
2532         Reviewed by Darin Adler.
2533
2534         Compiler warnings in InspectorResource.h
2535         https://bugs.webkit.org/show_bug.cgi?id=29231
2536
2537         Fix compilation warnings by removing addition operation on an enum type.
2538
2539         * inspector/InspectorResource.h:
2540         (WebCore::InspectorResource::):
2541         (WebCore::InspectorResource::Changes::hasChange):
2542         (WebCore::InspectorResource::Changes::set):
2543         (WebCore::InspectorResource::Changes::setAll):
2544
2545 2009-11-09  Anders Carlsson  <andersca@apple.com>
2546
2547         Reviewed by Darin Adler and Dan Bernstein.
2548
2549         <rdar://problem/7328395>
2550         https://bugs.webkit.org/show_bug.cgi?id=31277
2551
2552         When an object tag's style changes (for example when child nodes are added/removed),
2553         reuse its Frame (if it has one) instead of creating multiple Frames.
2554
2555         Test: fast/dom/HTMLObjectElement/children-changed.html
2556
2557         * loader/FrameLoader.cpp:
2558         (WebCore::FrameLoader::requestObject):
2559
2560 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
2561
2562         Reviewed by Kenneth Rohde Christiansen.
2563
2564         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
2565         since adjustment of RW-section base address will be needed for all new symbian
2566         tool chains, specifically for arm and gcc compilation targets.
2567         Also, change target address to 0xE00000 to be sufficient for all targets.
2568
2569         * WebCore.pro:
2570
2571 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
2572
2573         Reviewed by Timothy Hatcher.
2574
2575         Web Inspector: Crash when inspecting
2576         WebCore\manual-tests\inspector\dom-mutation.html
2577
2578         https://bugs.webkit.org/show_bug.cgi?id=31259
2579
2580         * inspector/InspectorDOMAgent.cpp:
2581         (WebCore::InspectorDOMAgent::handleEvent):
2582
2583 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2584
2585         Reviewed by Kenneth Rohde Christiansen.
2586
2587         [Qt] Few classes have virtual functions but non-virtual destructor
2588         https://bugs.webkit.org/show_bug.cgi?id=31269
2589
2590         No new tests as there is no functional change.
2591
2592         * platform/qt/QWebPageClient.h:
2593         (QWebPageClient::~QWebPageClient): Add virtual destructor.
2594
2595 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2596
2597         Reviewed by Kenneth Rohde Christiansen.
2598
2599         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2600         https://bugs.webkit.org/show_bug.cgi?id=31140
2601
2602         QtNetwork interprets null string as request to remove the header, not add it.
2603         Replace null values with empty values before passing them to QtNetwork.
2604
2605         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2606
2607         * platform/network/qt/ResourceRequestQt.cpp:
2608         (WebCore::ResourceRequest::toNetworkRequest):
2609
2610 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
2611
2612         Reviewed by Kevin Ollivier.
2613
2614         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2615         simply ignored before resulting in transparent areas being black in PNG
2616         images for example.
2617
2618         https://bugs.webkit.org/show_bug.cgi?id=30823
2619
2620         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2621         (WebCore::RGBA32Buffer::asNewNativeImage):
2622
2623 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2624
2625         Reviewed by Kenneth Rohde Christiansen.
2626
2627         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2628         https://bugs.webkit.org/show_bug.cgi?id=31040
2629
2630         No new tests as there is no functional change.
2631
2632         * dom/Document.cpp:
2633         (WebCore::Document::recalcStyleSelector):
2634         * editing/TextIterator.cpp:
2635         (WebCore::pushFullyClippedState):
2636         * editing/VisibleSelection.cpp:
2637         (WebCore::VisibleSelection::appendTrailingWhitespace):
2638         * html/HTMLLinkElement.cpp:
2639         (WebCore::HTMLLinkElement::process):
2640         * loader/RedirectScheduler.cpp:
2641         (WebCore::RedirectScheduler::mustLockBackForwardList):
2642         * loader/appcache/ApplicationCacheGroup.cpp:
2643         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2644         * platform/graphics/qt/FontCacheQt.cpp:
2645         (WebCore::FontPlatformDataCacheKey::computeHash):
2646         * rendering/RenderBlock.cpp:
2647         (WebCore::RenderBlock::handleRunInChild):
2648         * rendering/RenderBox.cpp:
2649         (WebCore::RenderBox::calcHeight):
2650         * rendering/RenderTextControlMultiLine.cpp:
2651         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2652         * rendering/style/RenderStyle.cpp:
2653         (WebCore::RenderStyle::diff):
2654         * svg/SVGAnimateElement.cpp:
2655         (WebCore::parseNumberValueAndUnit):
2656         * svg/SVGAnimationElement.cpp:
2657         (WebCore::SVGAnimationElement::startedActiveInterval):
2658         * svg/SVGPreserveAspectRatio.cpp:
2659         (WebCore::SVGPreserveAspectRatio::getCTM):
2660
2661 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
2662
2663         Reviewed by Dimitri Glazkov.
2664
2665         Win chromium is slow to draw transparent texts
2666         https://bugs.webkit.org/show_bug.cgi?id=31258
2667
2668         Clip graphics context to reduce calculation.
2669
2670         No new tests because this change only affects performance.
2671
2672         * platform/graphics/chromium/FontChromiumWin.cpp:
2673         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2674         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2675
2676 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
2677
2678         Reviewed by Darin Adler.
2679
2680         showTree(CounterNode*) generates too little info and has too many spaces.
2681         https://bugs.webkit.org/show_bug.cgi?id=31212
2682
2683         No new tests as the change has no functional effect it is just for
2684         improved debugging.
2685
2686         * rendering/CounterNode.cpp:
2687         (WebCore::showTreeAndMark):
2688         Changed to also show addresses of parent, next and previous
2689         siblings.
2690
2691 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
2692
2693         Reviewed by Darin Adler.
2694
2695         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2696         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2697
2698         https://bugs.webkit.org/show_bug.cgi?id=31083
2699
2700         No new tests; implementation is unchanged.
2701
2702         * page/Frame.cpp:
2703         (WebCore::Frame::setUseSecureKeyboardEntry):
2704         * page/mac/FrameMac.mm:
2705
2706 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2707
2708         Reviewed by Jan Alonzo.
2709
2710         Make XP_UNIX tests consistent
2711         https://bugs.webkit.org/show_bug.cgi?id=31250
2712
2713         No new tests as there is no functional change.
2714
2715         * plugins/PluginView.cpp:
2716         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2717         instead of the value of the macro
2718
2719         * plugins/gtk/PluginViewGtk.cpp:
2720         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2721         defined instead of using the PLATFORM macro to be consistent
2722         (WebCore::PluginView::getValue): Ditto.
2723
2724 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
2725
2726         Reviewed by Darin Adler.
2727
2728         Thunk to the main thread from ~Database to deref Database's m_document.
2729
2730         If the Database was the Document's last referrer, then ~Document occurs on the
2731         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2732         ASSERT in debug builds.
2733
2734         * storage/Database.cpp:
2735         (WebCore::derefDocument):
2736         (WebCore::Database::~Database):
2737
2738 2009-11-09  Mark Mentovai  <mark@chromium.org>
2739
2740         Reviewed by Dan Bernstein.
2741
2742         Track "can have scrollbar" state within FrameView independently of the
2743         individual scrollbar states in ScrollView.
2744
2745         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2746         REGRESSION (r48064): mint.com loses scrollbars after coming out of
2747         edit mode.
2748
2749         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2750         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2751
2752         Test: fast/overflow/scrollbar-restored.html
2753
2754         * WebCore.base.exp:
2755         * page/FrameView.cpp:
2756         (WebCore::FrameView::FrameView):
2757         (WebCore::FrameView::resetScrollbars):
2758         (WebCore::FrameView::setCanHaveScrollbars):
2759         (WebCore::FrameView::updateCanHaveScrollbars):
2760         (WebCore::FrameView::layout):
2761         * page/FrameView.h:
2762         * platform/ScrollView.h:
2763
2764 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
2765
2766         Reviewed by Timothy Hatcher.
2767
2768         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2769         https://bugs.webkit.org/show_bug.cgi?id=31257
2770
2771         * inspector/front-end/SourceFrame.js:
2772
2773 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
2774
2775         Reviewed by Timothy Hatcher.
2776
2777         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2778         https://bugs.webkit.org/show_bug.cgi?id=31252
2779
2780         Route F1-F12 keypresses in the Console view to the current panel if there is one.
2781
2782         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2783
2784         * inspector/front-end/ConsoleView.js:
2785         (WebInspector.ConsoleView.prototype._promptKeyDown):
2786         * inspector/front-end/utilities.js:
2787         ():
2788         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2789
2790 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2791
2792         Reviewed by Kenneth Rohde Christiansen.
2793
2794         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2795         https://bugs.webkit.org/show_bug.cgi?id=31208
2796
2797         After r42483, the credentials are no longer passed to the network request
2798         in the URL of the request.
2799         Pass the credentials from XMLHTTPRequest to the network request, the same
2800         way that other ports do.
2801
2802         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2803
2804         * platform/network/qt/ResourceHandleQt.cpp:
2805         (WebCore::ResourceHandle::start):
2806         (WebCore::ResourceHandle::loadResourceSynchronously):
2807
2808 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2809
2810         Unreviewed.
2811
2812         https://bugs.webkit.org/show_bug.cgi?id=31161
2813
2814         Roll back r50657 because it breaks the MAC builds.
2815
2816         * loader/ImageLoader.cpp:
2817         * loader/ProgressTracker.cpp:
2818         * loader/RedirectScheduler.cpp:
2819         * loader/Request.h:
2820         * loader/ThreadableLoaderClient.h:
2821         * loader/WorkerThreadableLoader.h:
2822         * loader/appcache/ApplicationCacheHost.h:
2823         * loader/appcache/ApplicationCacheStorage.h:
2824         * loader/icon/IconDatabaseClient.h:
2825
2826 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2827
2828         Reviewed by Darin Adler.
2829
2830         Allow custom memory allocation control for the part of loader directory in WebCore
2831         https://bugs.webkit.org/show_bug.cgi?id=31161
2832
2833         Inherits the following classes from Noncopyable because these are instantiated
2834         by 'new' and these are no need to be copyable:
2835
2836         class Request - WebCore/loader/loader.cpp:100
2837         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2838         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2839         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2840         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2841         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2842         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2843
2844         Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
2845         MainThreadBridge is instantiated by 'new' in
2846         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2847
2848         ThreadableLoaderClient's inheriting has been changed to public.
2849
2850         * loader/ImageLoader.cpp:
2851         * loader/ProgressTracker.cpp:
2852         * loader/RedirectScheduler.cpp:
2853         * loader/Request.h:
2854         * loader/ThreadableLoaderClient.h:
2855         * loader/WorkerThreadableLoader.h:
2856         * loader/appcache/ApplicationCacheHost.h:
2857         * loader/appcache/ApplicationCacheStorage.h:
2858         * loader/icon/IconDatabaseClient.h:
2859
2860 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2861
2862         Reviewed by Darin Adler.
2863
2864         Allow custom memory allocation control for WebCore's DocLoader
2865         https://bugs.webkit.org/show_bug.cgi?id=31163
2866
2867         Inherits DocLoader class from Noncopyable because it is
2868         instantiated by 'new' in WebCore/dom/Document.cpp:370 and
2869         it is no need to be copyable.
2870
2871         * loader/DocLoader.h:
2872
2873 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2874
2875         Reviewed by Darin Adler.
2876
2877         Allow custom memory allocation control for WebCore's Tokenizer
2878         https://bugs.webkit.org/show_bug.cgi?id=31162
2879
2880         Inherits Tokenizer class from Noncopyable because (its child class)
2881         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178
2882         and it is no need to be copyable.
2883
2884         * dom/Tokenizer.h:
2885
2886 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2887
2888         Reviewed by Darin Adler.
2889
2890         Allow custom memory allocation control for WebCore's DeleteButtonController
2891         https://bugs.webkit.org/show_bug.cgi?id=31105
2892
2893         Inherits DeleteButtonController class from Noncopyable because it is
2894         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2895         it is no need to be copyable.
2896
2897         * editing/DeleteButtonController.h:
2898
2899 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2900
2901         Reviewed by Jan Alonzo.
2902
2903         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2904         https://bugs.webkit.org/show_bug.cgi?id=30482
2905
2906         Expose Page::tabKeyCyclesThroughElements as a property of
2907         WebKitWebView.
2908
2909         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2910
2911         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2912         (WebCore::singleCharacterString):
2913
2914 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2915
2916         Reviewed by Xan Lopez.
2917
2918         https://bugs.webkit.org/show_bug.cgi?id=25415
2919         [GTK][ATK] Please implement support for get_text_at_offset
2920
2921         Fix a crasher that occurred with text which included newline
2922         chars in the markup.
2923
2924         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2925         (convertUniCharToUTF8):
2926
2927 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
2928
2929         Reviewed by Holger Freyther.
2930
2931         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2932         https://bugs.webkit.org/show_bug.cgi?id=31144
2933
2934         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2935         documents that end prematurely but are not considered invalid by QXmlStream.
2936         This is to stay compatible with the libxml2 implementation.
2937         However, that code path would be also hit in situations when it should not,
2938         i.e. the error would have already been caught and handled. As a result, the
2939         same error would be reported twice.
2940
2941         No new tests, because the problem is already covered by
2942         fast/parser/xml-declaration-missing-ending-mark.html.
2943
2944         * dom/XMLTokenizerQt.cpp:
2945         (WebCore::XMLTokenizer::doEnd):
2946
2947 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
2948
2949         Reviewed by Pavel Feldman.
2950
2951         Web Inspector: Inspector should support copy() in the command line
2952         https://bugs.webkit.org/show_bug.cgi?id=31238
2953
2954         * inspector/InspectorBackend.cpp:
2955         (WebCore::InspectorBackend::copyText): Added.
2956         * inspector/InspectorBackend.h: Added copyText
2957         * inspector/InspectorBackend.idl: Added copyText
2958         * inspector/front-end/InjectedScript.js:
2959         (InjectedScript._copy): Added.
2960         (InjectedScript._ensureCommandLineAPIInstalled):
2961
2962 2009-11-08  Drew Wilson  <atwilson@chromium.org>
2963
2964         Reviewed by Dimitri Glazkov.
2965
2966         V8 WorkerContextExecutionProxy does not handle SharedWorkers
2967         https://bugs.webkit.org/show_bug.cgi?id=31226
2968
2969         Now checks to see what type of context is active and creates the
2970         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2971
2972         Added support for converting to SharedWorkers and SharedWorkerContexts.
2973
2974         Test: Existing layout tests cover this case (start passing in Chrome).
2975
2976         * bindings/v8/WorkerContextExecutionProxy.cpp:
2977         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2978         Now generates the right type of DOMWrapper for SharedWorkerContexts.
2979         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2980         Added support for SHAREDWORKERCONTEXT.
2981         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2982         Added support for SharedWorker and SharedWorkerContext.
2983
2984 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
2985
2986         Reviewed by Dimitri Glazkov.
2987
2988         https://bugs.webkit.org/show_bug.cgi?id=31224
2989         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
2990
2991         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
2992
2993         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2994         (WebCore::NAMED_PROPERTY_GETTER):
2995
2996 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2997
2998         Reviewed by Timothy Hatcher.
2999
3000         Web Inspector: "Search again" on scripts panel switches
3001         to the script this search started with.
3002
3003         https://bugs.webkit.org/show_bug.cgi?id=31243
3004
3005         * inspector/front-end/Panel.js:
3006         (WebInspector.Panel.prototype.jumpToNextSearchResult):
3007
3008 2009-11-08  Kent Tamura  <tkent@chromium.org>
3009
3010         Reviewed by Darin Adler.
3011
3012         Simplify Icon interface.
3013         https://bugs.webkit.org/show_bug.cgi?id=31154
3014
3015         - Remove Icon::createIconForFile().  createIconForFiles() covers
3016           createIconForFile()'s role.
3017         - Remove FileChooser::chooseIcon()
3018         - Change the parameter types of FileChooser constructor and the
3019           factory method, String -> const Vector<String>&, in order to
3020           support initialization with multiple files.
3021         - Remove the icon loading code in IconChromiumWin.cpp, which
3022           doesn't work because of the sandbox.
3023
3024         No tests because it's just a refactoring.
3025
3026         * platform/FileChooser.cpp:
3027         (WebCore::FileChooser::FileChooser):
3028         (WebCore::FileChooser::create):
3029         (WebCore::FileChooser::chooseFile):
3030         (WebCore::FileChooser::chooseFiles):
3031         * platform/FileChooser.h:
3032         * platform/graphics/Icon.h:
3033         * platform/graphics/chromium/IconChromiumLinux.cpp:
3034         * platform/graphics/chromium/IconChromiumMac.cpp:
3035         * platform/graphics/chromium/IconChromiumWin.cpp:
3036         (WebCore::Icon::createIconForFiles):
3037         * platform/graphics/gtk/IconGtk.cpp:
3038         (WebCore::Icon::createIconForFiles):
3039         * platform/graphics/haiku/IconHaiku.cpp:
3040         * platform/graphics/mac/IconMac.mm:
3041         (WebCore::Icon::createIconForFiles):
3042         * platform/graphics/qt/IconQt.cpp:
3043         (WebCore::Icon::createIconForFiles):
3044         * platform/graphics/win/IconWin.cpp:
3045         (WebCore::Icon::createIconForFiles):
3046         * platform/graphics/wx/IconWx.cpp:
3047         * rendering/RenderFileUploadControl.cpp:
3048         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
3049
3050 2009-11-08  Daniel Bates  <dbates@webkit.org>
3051
3052         Reviewed by Adam Barth.
3053
3054         https://bugs.webkit.org/show_bug.cgi?id=31098
3055
3056         Allows same-origin plugin-based content to load.
3057
3058         Test: http/tests/security/xssAuditor/object-src-inject.html
3059
3060         * page/XSSAuditor.cpp:
3061         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
3062         (WebCore::XSSAuditor::canLoadObject): Ditto.
3063         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
3064         (WebCore::XSSAuditor::isSameOriginResource): Added.
3065         * page/XSSAuditor.h:
3066
3067 2009-11-08  David Levin  <levin@chromium.org>
3068
3069         Reviewed by NOBODY (chromium build fix).
3070
3071         * platform/network/HTTPParsers.cpp:
3072         (WebCore::parseDate): Changed this to not
3073         use a date parser that needs ExecState passed.
3074
3075 2009-11-08  David Levin  <levin@chromium.org>
3076
3077         Unreviewed build fix for chromium.
3078
3079         * platform/graphics/skia/GraphicsContextSkia.cpp:
3080         (WebCore::GraphicsContext::fillPath):
3081         (WebCore::GraphicsContext::fillRect):
3082         (WebCore::GraphicsContext::strokePath):
3083         (WebCore::GraphicsContext::strokeRect):
3084
3085 2009-11-08  David Levin  <levin@chromium.org>
3086
3087         Unreviewed build fix for chromium.
3088
3089         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
3090         Clean up GraphicsContext's current concept of ColorSpace
3091
3092         * platform/graphics/skia/GraphicsContextSkia.cpp:
3093         (WebCore::GraphicsContext::fillPath):
3094         (WebCore::GraphicsContext::fillRect):
3095         (WebCore::GraphicsContext::strokePath):
3096         (WebCore::GraphicsContext::strokeRect):
3097
3098 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
3099
3100         Reviewed by Timothy Hatcher.
3101
3102         Web Inspector: [REGRESSION] committing style edit
3103         clears elements panel selection.
3104
3105         https://bugs.webkit.org/show_bug.cgi?id=31242
3106
3107         * inspector/front-end/ElementsTreeOutline.js:
3108         (WebInspector.ElementsTreeOutline.prototype.update):
3109         * inspector/front-end/StylesSidebarPane.js:
3110         (WebInspector.StylePropertyTreeElement.prototype.):
3111         (WebInspector.StylePropertyTreeElement.prototype):
3112
3113 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
3114
3115         Reviewed by Holger Freyther.
3116
3117         ResourceRequest to be class instead of struct
3118         https://bugs.webkit.org/show_bug.cgi?id=30670
3119
3120         Started as a compilation fix for Symbian where the compiler makes a distinction between
3121         class and struct in function argument signatures.
3122         Changed all forward declarations of ResourceRequest to have class in the forward
3123         declaration instead of struct and changed the definition of ResourceRequest to be class
3124         and added access qualifiers where missing. Additionally two references of friend
3125         struct ResourceRequestBase changed to class instead.
3126
3127         * history/HistoryItem.h:
3128         * inspector/InspectorController.h:
3129         * inspector/InspectorResource.h:
3130         * loader/DocumentThreadableLoader.h:
3131         * loader/FrameLoaderClient.h:
3132         * loader/MainResourceLoader.h:
3133         * loader/ResourceLoadNotifier.h:
3134         * loader/SubresourceLoader.h:
3135         * loader/SubresourceLoaderClient.h:
3136         * loader/ThreadableLoader.h:
3137         * loader/WorkerThreadableLoader.h:
3138         * loader/appcache/ApplicationCache.h:
3139         * loader/appcache/ApplicationCacheHost.h:
3140         * platform/CrossThreadCopier.h:
3141         * platform/network/ResourceHandle.h:
3142         * platform/network/ResourceHandleClient.h:
3143         * platform/network/ResourceRequestBase.h:
3144         * platform/network/cf/ResourceRequest.h:
3145         * platform/network/cf/ResourceRequestCFNet.h:
3146         * platform/network/chromium/ResourceRequest.h:
3147         * platform/network/curl/ResourceRequest.h:
3148         * platform/network/qt/ResourceRequest.h:
3149         * platform/network/soup/ResourceRequest.h:
3150         * xml/XMLHttpRequest.h:
3151
3152 2009-11-08  Dan Bernstein  <mitz@apple.com>
3153
3154         Reviewed by Simon Fraser.
3155
3156         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
3157         below FrameView::layout
3158         https://bugs.webkit.org/show_bug.cgi?id=31093
3159
3160         Test: fast/block/positioning/relative-positioned-inline-container.html
3161
3162         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
3163         to mark the object for layout, doing so without marking its ancestors.
3164         However, RenderBlock::skipLeadingWhitespace and
3165         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
3166         positioned inline container, causing it to be marked for layout without
3167         ever going back to give it layout, and thus layout could end with a
3168         dirty object still in the tree, leading to all sorts of badness.
3169
3170         The fix is to revert setStaticY() to not marking the object dirty, and
3171         instead do it in the call sites that require it, which are in
3172         RenderBlock and RenderFlexibleBox.
3173
3174         * rendering/RenderBlock.cpp:
3175         (WebCore::RenderBlock::adjustPositionedBlock):
3176         * rendering/RenderFlexibleBox.cpp:
3177         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
3178         (WebCore::RenderFlexibleBox::layoutVerticalBox):
3179         * rendering/RenderLayer.cpp:
3180         * rendering/RenderLayer.h:
3181         (WebCore::RenderLayer::setStaticY):
3182
3183 2009-11-07  Daniel Bates  <dbates@webkit.org>
3184
3185         Reviewed by Darin Adler.
3186
3187         https://bugs.webkit.org/show_bug.cgi?id=20780
3188
3189         Fixes an issue where the onchange event handler is not fired when the
3190         input field is autocompleted.
3191
3192         We cannot test this using DRT since DRT cannot emulate autocompletion.
3193         So, a manual-test is included.
3194
3195         Tests: manual-tests/autocompletion-fire-onchange.html
3196
3197         * manual-tests/autocompletion-fire-onchange.html: Added.
3198         * rendering/RenderTextControl.cpp:
3199         (WebCore::RenderTextControl::setInnerTextValue):
3200
3201 2009-11-07  Benjamin Otte  <otte@gnome.org>
3202
3203         Reviewed by Holger Freyther.
3204
3205         Mark redrawn areas on image surfaces as dirty.
3206
3207         This is required to conform to the Cairo API, but is currently only
3208         used by debugging tools like cairo-trace.
3209
3210         * platform/graphics/cairo/ImageBufferCairo.cpp:
3211         (WebCore::ImageBuffer::platformTransformColorSpace):
3212         (WebCore::putImageData):
3213
3214 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3215
3216         Reviewed by Xan Lopez.
3217
3218         https://bugs.webkit.org/show_bug.cgi?id=30878
3219         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
3220
3221         If the end_offset is -1, use the String length as the end_offset.
3222
3223         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3224         (webkit_accessible_text_get_text):
3225
3226 2009-11-06  Beth Dakin  <bdakin@apple.com>
3227
3228         Reviewed by Adele Peterson.
3229
3230         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up
3231         GraphicsContext's current concept of ColorSpace
3232
3233         ColorSpace is now called ColorType. The variables on the state we
3234         appropriately re-named as well. I removed strokeColorSpace() and
3235         fillColorSpace() from GraphicsContext since they were never called.
3236
3237         * platform/graphics/GraphicsContext.cpp:
3238         (WebCore::GraphicsContext::setStrokeColor):
3239         (WebCore::GraphicsContext::setFillColor):
3240         (WebCore::GraphicsContext::setStrokePattern):
3241         (WebCore::GraphicsContext::setFillPattern):
3242         (WebCore::GraphicsContext::setStrokeGradient):
3243         (WebCore::GraphicsContext::setFillGradient):
3244         * platform/graphics/GraphicsContext.h:
3245         (WebCore::):
3246         * platform/graphics/GraphicsContextPrivate.h:
3247         (WebCore::GraphicsContextState::GraphicsContextState):
3248         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3249         (WebCore::GraphicsContext::fillPath):
3250         (WebCore::GraphicsContext::strokePath):
3251         * platform/graphics/cg/GraphicsContextCG.cpp:
3252         (WebCore::calculateDrawingMode):
3253         (WebCore::GraphicsContext::drawPath):
3254         (WebCore::GraphicsContext::fillPath):
3255         (WebCore::GraphicsContext::strokePath):
3256         (WebCore::GraphicsContext::fillRect):
3257         (WebCore::GraphicsContext::strokeRect):
3258         * platform/graphics/qt/GraphicsContextQt.cpp:
3259         (WebCore::GraphicsContext::fillPath):
3260         (WebCore::GraphicsContext::strokePath):
3261         (WebCore::GraphicsContext::fillRect):
3262         * platform/graphics/wince/GraphicsContextWince.cpp:
3263         (WebCore::GraphicsContext::fillPath):
3264         (WebCore::GraphicsContext::fillRect):
3265
3266 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
3267
3268         Reviewed by Tim Hatcher.
3269
3270         Fixes <http://webkit.org/b/31177>.
3271         Web Inspector: Bind backspace to delete cookies and DOM Storage.
3272
3273         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
3274         places in the inspector can use editing in DataGrid (added a FIXME for
3275         some stuff that needs to be generalized).
3276
3277         Also added deleting functionality to DataGrid, and implemented it for
3278         Cookies and DOM Storage. The reason this patch is so big is because of
3279         the refactoring of editing code, which won't be used yet in a cross-datagrid
3280         way, but should be able to.
3281
3282         Additionally, moved the callbacks members from DOMStorageDataGrid to
3283         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to
3284         make the architecture of DOM Storage look a lot more like the Cookies view.
3285
3286         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the
3287         inspector from beeping at you when you delete an element.
3288
3289         * WebCore.gypi: Removed DOMStorageDataGrid.
3290         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
3291         * inspector/front-end/CookieItemsView.js:
3292         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
3293         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
3294         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
3295         * inspector/front-end/DOMStorageDataGrid.js: Removed.
3296         * inspector/front-end/DOMStorageItemsView.js:
3297         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
3298         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
3299         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
3300         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
3301         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
3302         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
3303         * inspector/front-end/DataGrid.js:
3304         (WebInspector.DataGrid):
3305         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
3306         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
3307         (WebInspector.DataGrid.prototype._startEditing): Ditto.
3308         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
3309         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
3310         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
3311         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
3312         * inspector/front-end/ElementsTreeOutline.js:
3313         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
3314         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
3315         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
3316
3317 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
3318
3319         Qt build fix: added an ExecState parameter.
3320
3321         * bridge/qt/qt_runtime.cpp:
3322         (JSC::Bindings::convertValueToQVariant):
3323         (JSC::Bindings::convertQVariantToValue):
3324
3325 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
3326
3327         https://bugs.webkit.org/show_bug.cgi?id=31197
3328         Implemented a timezone cache not based on Mac OS X's notify_check API.
3329
3330         Updated for JavaScriptCore internal API change.
3331
3332         * bridge/qt/qt_runtime.cpp:
3333         (JSC::Bindings::convertValueToQVariant):
3334         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
3335
3336         * platform/network/HTTPParsers.cpp:
3337         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
3338         (This function probably shouldn't be using a JavaScript date parser
3339         to begin with, but oh well.)
3340
3341 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
3342
3343         Reviewed by Adam Barth.
3344
3345         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
3346         which affects Chromium only.
3347
3348         Changes to V8HTMLDocumentCustom.cpp are as below:-
3349         1. The HTMLDocumentOpen function would cause a crash in Chromium if
3350            there was no calling javascript context. We now check for this case
3351            and pass in NULL to the HTMLDocument::open function which can handle
3352            a NULL document parameter.
3353         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
3354            had ASSERTS for a NULL caller frame, which was bogus as it would crash
3355            anyway. We now check for this case and return a failure.
3356
3357         Changes to V8DOMWindowCustom.cpp are as below:-
3358         1. Instead of failing the window.open call made by NPAPI for lack of a
3359            calling javascript context, we now use the entered context as the calling
3360            context.
3361
3362         Tests: plugins/document-open.html
3363                plugins/window-open.html
3364
3365         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3366         (WebCore::CALLBACK_FUNC_DECL):
3367         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
3368         (WebCore::CALLBACK_FUNC_DECL):
3369
3370 2009-11-06  Steve Block  <steveblock@google.com>
3371
3372         Reviewed by Eric Seidel.
3373
3374         Geolocation error code UNKNOWN_ERROR is deprecated.
3375         https://bugs.webkit.org/show_bug.cgi?id=31184
3376
3377         Remove this error code from PositionError, both for use from C++ code and from the JS object.
3378
3379         Updated fast/dom/Geolocation/error.html to test this.
3380
3381         * page/PositionError.h: Modified.
3382         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
3383         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
3384         * page/Geolocation.cpp: Modified.
3385         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3386         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
3387         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3388
3389 2009-11-06  Dirk Schulze  <krit@webkit.org>
3390
3391         Reviewed by Nikolas Zimmermann.
3392
3393         feMorphology filter is not implemented
3394         [https://bugs.webkit.org/show_bug.cgi?id=5863]
3395
3396         The Implementation of feMorphology.
3397
3398         Test: We have allready a test for feMorphology
3399               svg/W3C-SVG-1.1/filters-morph-01-f.svg
3400
3401         * svg/graphics/filters/SVGFEMorphology.cpp:
3402         (WebCore::FEMorphology::apply):
3403
3404 2009-11-06  Steve Block  <steveblock@google.com>
3405
3406         Reviewed by Eric Seidel.
3407
3408         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
3409         https://bugs.webkit.org/show_bug.cgi?id=31209
3410
3411         Build fix only. No new tests possible.
3412
3413         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
3414
3415 2009-11-06  Drew Wilson  <atwilson@chromium.org>
3416
3417         Reviewed by David Levin.
3418
3419         V8 bindings do not support SharedWorkers as event targets
3420         https://bugs.webkit.org/show_bug.cgi?id=31199
3421
3422         No new tests because existing layout tests suffice (they currently
3423         crash on Chromium)
3424
3425         * bindings/v8/V8DOMWrapper.cpp:
3426         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
3427         Added clause to create a DOM wrapper for SharedWorkers.
3428
3429 2009-11-06  Anton Muhin  <antonm@chromium.org>
3430
3431         Reviewed by Adam Barth.
3432
3433         Do not unnecessarly synchronzie in weak reference callbacks.
3434         https://bugs.webkit.org/show_bug.cgi?id=31191
3435
3436         * bindings/v8/DOMData.h:
3437         (WebCore::DOMData::handleWeakObject):
3438
3439 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
3440
3441         Reviewed by Pavel Feldman.
3442
3443         Fix resource content search.
3444         https://bugs.webkit.org/show_bug.cgi?id=31202
3445
3446         * inspector/front-end/AbstractTimelinePanel.js:
3447         (WebInspector.AbstractTimelinePanel.prototype.refresh):
3448         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3449         * inspector/front-end/TimelinePanel.js:
3450         (WebInspector.TimelineGraph.prototype.refresh):
3451
3452 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
3453
3454         Reviewed by Eric Seidel.
3455
3456         Fix ASSERT(currentStyle = renderStyle()).
3457         https://bugs.webkit.org/show_bug.cgi?id=31152
3458
3459         * dom/Element.cpp:
3460         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
3461
3462 2009-11-05  Alpha Lam  <hclam@chromium.org>
3463
3464         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
3465
3466         * bindings/v8/V8GCController.cpp:
3467         (WebCore::V8GCController::gcEpilogue):
3468         * bindings/v8/V8GCController.h:
3469         * bindings/v8/V8Proxy.cpp:
3470         (WebCore::V8Proxy::evaluate):
3471         (WebCore::V8Proxy::runScript):
3472         (WebCore::V8Proxy::callFunction):
3473
3474 2009-11-05  Adam Barth  <abarth@webkit.org>
3475
3476         Reviewed by Sam Weinig.
3477
3478         Cross-domain access to stylesheet text should not be allowed
3479         https://bugs.webkit.org/show_bug.cgi?id=20527
3480
3481         Check whether whether the current document can read the cssRules from
3482         the style sheet.  Firefox throws a security error here, but we return
3483         null instead because that's what we usually do in these cases.
3484
3485         Test: http/tests/security/cannot-read-cssrules-redirect.html
3486               http/tests/security/cannot-read-cssrules.html
3487
3488         * css/CSSStyleSheet.cpp:
3489         (WebCore::CSSStyleSheet::cssRules):
3490
3491 2009-11-05  Steve Block  <steveblock@google.com>
3492
3493         Reviewed by Eric Seidel.
3494
3495         If the Geolocation service fails to start, invoke the error callback asynchronously.
3496         https://bugs.webkit.org/show_bug.cgi?id=28276
3497
3498         All Geolocation callbacks must be invoked asynchronously.
3499         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
3500
3501         No new tests possible with current LayoutTestController.
3502
3503         * page/Geolocation.cpp:
3504         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
3505         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
3506         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
3507
3508 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3509
3510         Reviewed by Eric Seidel.
3511
3512         Removed the "this is part of the KDE project" comments from
3513         all *.h, *.cpp, *.idl, and *.pm files.
3514
3515         https://bugs.webkit.org/show_bug.cgi?id=31167
3516
3517         The maintenance and architecture page in the project wiki lists
3518         this as a task.
3519
3520         This change includes no changes or additions to test cases
3521         since the change affects only comments.
3522
3523         * bindings/scripts/CodeGeneratorV8.pm:
3524         * bindings/scripts/IDLParser.pm:
3525         * bindings/scripts/IDLStructure.pm:
3526         * css/CSSInheritedValue.cpp:
3527         * css/CSSInitialValue.cpp:
3528         * css/CSSMediaRule.cpp:
3529         * css/CSSNamespace.h:
3530         * css/CSSProperty.cpp:
3531         * css/CSSProperty.h:
3532         * css/CSSRuleList.cpp:
3533         * css/CSSRuleList.h:
3534         * css/CSSSelector.h:
3535         * css/CSSValueList.cpp:
3536         * css/FontValue.cpp:
3537         * css/MediaFeatureNames.cpp:
3538         * css/MediaFeatureNames.h:
3539         * css/Pair.h:
3540         * css/SVGCSSStyleSelector.cpp:
3541         * css/ShadowValue.cpp:
3542         * css/StyleSheet.cpp:
3543         * css/StyleSheetList.cpp:
3544         * css/maketokenizer:
3545         * dom/BeforeUnloadEvent.cpp:
3546         * dom/BeforeUnloadEvent.h:
3547         * dom/CSSMappedAttributeDeclaration.cpp:
3548         * dom/EventNames.cpp:
3549         * dom/EventTarget.cpp:
3550         * dom/MappedAttributeEntry.h:
3551         * dom/MouseRelatedEvent.h:
3552         * dom/RangeException.h:
3553         * dom/StyleElement.h:
3554         * dom/Tokenizer.h:
3555         * html/HTMLHeadElement.h:
3556         * html/HTMLHeadingElement.cpp:
3557         * html/HTMLHeadingElement.h:
3558         * html/HTMLHtmlElement.h:
3559         * html/HTMLImageLoader.h:
3560         * html/HTMLMetaElement.h:
3561         * html/HTMLModElement.cpp:
3562         * html/HTMLModElement.h:
3563         * html/HTMLOptionsCollection.cpp:
3564         * html/HTMLPlugInElement.cpp:
3565         * html/HTMLPreElement.cpp:
3566         * html/HTMLPreElement.h:
3567         * html/HTMLTableCellElement.cpp:
3568         * html/HTMLTableCellElement.h:
3569         * html/HTMLTableColElement.cpp:
3570         * html/HTMLTableColElement.h:
3571         * html/HTMLTablePartElement.cpp:
3572         * html/HTMLTablePartElement.h:
3573         * html/HTMLTitleElement.h:
3574         * page/MouseEventWithHitTestResults.h:
3575         * platform/StaticConstructors.h:
3576         * platform/text/AtomicStringImpl.h:
3577         * platform/text/qt/TextBreakIteratorQt.cpp:
3578         * rendering/AutoTableLayout.h:
3579         * rendering/CounterNode.cpp:
3580         * rendering/EllipsisBox.cpp:
3581         * rendering/EllipsisBox.h:
3582         * rendering/FixedTableLayout.cpp:
3583         * rendering/FixedTableLayout.h:
3584         * rendering/HitTestRequest.h:
3585         * rendering/HitTestResult.h:
3586         * rendering/InlineRunBox.h:
3587         * rendering/PointerEventsHitRules.cpp:
3588         * rendering/PointerEventsHitRules.h:
3589         * rendering/RenderBR.cpp:
3590         * rendering/RenderBR.h:
3591         * rendering/RenderButton.cpp:
3592         * rendering/RenderButton.h:
3593         * rendering/RenderFieldset.cpp:
3594         * rendering/RenderFrameSet.cpp:
3595         * rendering/RenderListItem.cpp:
3596         * rendering/RenderTableRow.cpp:
3597         * rendering/RenderView.h:
3598         * rendering/RootInlineBox.h:
3599         * rendering/SVGInlineTextBox.cpp:
3600         * rendering/SVGInlineTextBox.h:
3601         * rendering/TableLayout.h:
3602         * rendering/break_lines.h:
3603         * rendering/style/SVGRenderStyle.cpp:
3604         * rendering/style/SVGRenderStyle.h:
3605         * rendering/style/SVGRenderStyleDefs.cpp:
3606         * rendering/style/SVGRenderStyleDefs.h:
3607         * svg/GradientAttributes.h:
3608         * svg/LinearGradientAttributes.h:
3609         * svg/PatternAttributes.h:
3610         * svg/RadialGradientAttributes.h:
3611         * svg/SVGAElement.cpp:
3612         * svg/SVGAngle.idl:
3613         * svg/SVGAnimateColorElement.cpp:
3614         * svg/SVGAnimateColorElement.h:
3615         * svg/SVGAnimateElement.cpp:
3616         * svg/SVGAnimateElement.h:
3617         * svg/SVGAnimateTransformElement.h:
3618         * svg/SVGAnimatedPathData.cpp:
3619         * svg/SVGAnimatedPathData.h:
3620         * svg/SVGAnimatedPoints.cpp:
3621         * svg/SVGAnimatedPoints.h:
3622         * svg/SVGAnimationElement.cpp:
3623         * svg/SVGCircleElement.cpp:
3624         * svg/SVGClipPathElement.cpp:
3625         * svg/SVGColor.cpp:
3626         * svg/SVGColor.idl:
3627         * svg/SVGComponentTransferFunctionElement.cpp:
3628         * svg/SVGComponentTransferFunctionElement.h:
3629         * svg/SVGCursorElement.cpp:
3630         * svg/SVGDefsElement.cpp:
3631         * svg/SVGDescElement.cpp:
3632         * svg/SVGDescElement.h:
3633         * svg/SVGDocument.idl:
3634         * svg/SVGElement.idl:
3635         * svg/SVGElementInstanceList.cpp:
3636         * svg/SVGElementInstanceList.h:
3637         * svg/SVGEllipseElement.cpp:
3638         * svg/SVGExternalResourcesRequired.cpp:
3639         * svg/SVGFEBlendElement.cpp:
3640         * svg/SVGFEBlendElement.h:
3641         * svg/SVGFEColorMatrixElement.cpp:
3642         * svg/SVGFEColorMatrixElement.h:
3643         * svg/SVGFEComponentTransferElement.cpp:
3644         * svg/SVGFEComponentTransferElement.h:
3645         * svg/SVGFECompositeElement.cpp:
3646         * svg/SVGFECompositeElement.h:
3647         * svg/SVGFEFloodElement.cpp:
3648         * svg/SVGFEFloodElement.h:
3649         * svg/SVGFEFuncAElement.cpp:
3650         * svg/SVGFEFuncAElement.h:
3651         * svg/SVGFEFuncBElement.cpp:
3652         * svg/SVGFEFuncBElement.h:
3653         * svg/SVGFEFuncGElement.cpp:
3654         * svg/SVGFEFuncGElement.h:
3655         * svg/SVGFEFuncRElement.cpp:
3656         * svg/SVGFEFuncRElement.h:
3657         * svg/SVGFEGaussianBlurElement.cpp:
3658         * svg/SVGFEGaussianBlurElement.h:
3659         * svg/SVGFEImageElement.cpp:
3660         * svg/SVGFEMergeElement.cpp:
3661         * svg/SVGFEMergeElement.h:
3662         * svg/SVGFEMergeNodeElement.cpp:
3663         * svg/SVGFEOffsetElement.cpp:
3664         * svg/SVGFEOffsetElement.h:
3665         * svg/SVGFETileElement.cpp:
3666         * svg/SVGFETileElement.h:
3667         * svg/SVGFETurbulenceElement.cpp:
3668         * svg/SVGFETurbulenceElement.h:
3669         * svg/SVGFilterElement.cpp:
3670         * svg/SVGGElement.cpp:
3671         * svg/SVGGradientElement.cpp:
3672         * svg/SVGHKernElement.idl:
3673         * svg/SVGLangSpace.cpp:
3674         * svg/SVGLangSpace.h:
3675         * svg/SVGLength.cpp:
3676         * svg/SVGLength.h:
3677         * svg/SVGLength.idl:
3678         * svg/SVGLengthList.cpp:
3679         * svg/SVGLengthList.h:
3680         * svg/SVGLineElement.cpp:
3681         * svg/SVGLinearGradientElement.h:
3682         * svg/SVGList.h:
3683         * svg/SVGListTraits.h:
3684         * svg/SVGLocatable.h:
3685         * svg/SVGMaskElement.cpp:
3686         * svg/SVGMatrix.idl:
3687         * svg/SVGMetadataElement.cpp:
3688         * svg/SVGMetadataElement.h:
3689         * svg/SVGMetadataElement.idl:
3690         * svg/SVGNumber.idl:
3691         * svg/SVGNumberList.cpp:
3692         * svg/SVGNumberList.h:
3693         * svg/SVGPaint.cpp:
3694         * svg/SVGPathElement.cpp:
3695         * svg/SVGPathSeg.h:
3696         * svg/SVGPathSegArc.cpp:
3697         * svg/SVGPathSegArc.h:
3698         * svg/SVGPathSegClosePath.cpp:
3699         * svg/SVGPathSegClosePath.h:
3700         * svg/SVGPathSegCurvetoCubic.cpp:
3701         * svg/SVGPathSegCurvetoCubic.h:
3702         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
3703         * svg/SVGPathSegCurvetoCubicSmooth.h:
3704         * svg/SVGPathSegCurvetoQuadratic.cpp:
3705         * svg/SVGPathSegCurvetoQuadratic.h:
3706         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
3707         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
3708         * svg/SVGPathSegLineto.cpp:
3709         * svg/SVGPathSegLineto.h:
3710         * svg/SVGPathSegLinetoHorizontal.cpp:
3711         * svg/SVGPathSegLinetoHorizontal.h:
3712         * svg/SVGPathSegLinetoVertical.cpp:
3713         * svg/SVGPathSegLinetoVertical.h:
3714         * svg/SVGPathSegMoveto.cpp:
3715         * svg/SVGPathSegMoveto.h:
3716         * svg/SVGPatternElement.cpp:
3717         * svg/SVGPoint.idl:
3718         * svg/SVGPointList.cpp:
3719         * svg/SVGPointList.h:
3720         * svg/SVGPolyElement.cpp:
3721         * svg/SVGPolygonElement.cpp:
3722         * svg/SVGPolygonElement.h:
3723         * svg/SVGPolylineElement.cpp:
3724         * svg/SVGPolylineElement.h:
3725         * svg/SVGPreserveAspectRatio.cpp:
3726         * svg/SVGPreserveAspectRatio.h:
3727         * svg/SVGRadialGradientElement.h:
3728         * svg/SVGRect.idl:
3729         * svg/SVGRectElement.cpp:
3730         * svg/SVGRenderingIntent.h:
3731         * svg/SVGSVGElement.idl:
3732         * svg/SVGScriptElement.cpp:
3733         * svg/SVGSetElement.cpp:
3734         * svg/SVGSetElement.h:
3735         * svg/SVGStopElement.cpp:
3736         * svg/SVGStringList.cpp:
3737         * svg/SVGStringList.h:
3738         * svg/SVGStylable.cpp:
3739         * svg/SVGStylable.h:
3740         * svg/SVGStyleElement.cpp:
3741         * svg/SVGStyleElement.h:
3742         * svg/SVGStyledElement.h:
3743         * svg/SVGStyledLocatableElement.cpp:
3744         * svg/SVGStyledLocatableElement.h:
3745         * svg/SVGStyledTransformableElement.cpp:
3746         * svg/SVGStyledTransformableElement.h:
3747         * svg/SVGSwitchElement.cpp:
3748         * svg/SVGSymbolElement.cpp:
3749         * svg/SVGTRefElement.cpp:
3750         * svg/SVGTSpanElement.cpp:
3751         * svg/SVGTSpanElement.h:
3752         * svg/SVGTests.h:
3753         * svg/SVGTextElement.cpp:
3754         * svg/SVGTextElement.h:
3755         * svg/SVGTextPathElement.cpp:
3756         * svg/SVGTextPositioningElement.cpp:
3757         * svg/SVGTextPositioningElement.h:
3758         * svg/SVGTitleElement.cpp:
3759         * svg/SVGTitleElement.h:
3760         * svg/SVGTransform.cpp:
3761         * svg/SVGTransform.h:
3762         * svg/SVGTransform.idl:
3763         * svg/SVGTransformList.cpp:
3764         * svg/SVGTransformList.h:
3765         * svg/SVGTransformable.h:
3766         * svg/SVGURIReference.h:
3767         * svg/SVGUnitTypes.h:
3768         * svg/SVGUseElement.cpp:
3769         * svg/SVGViewElement.cpp:
3770         * svg/SVGZoomAndPan.cpp:
3771         * svg/SVGZoomAndPan.h:
3772         * svg/SVGZoomEvent.cpp:
3773
3774 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3775
3776         Reviewed by Dimitri Glazkov.
3777
3778         REGRESSION Clean up security origin usage in DOM Storage.
3779         https://bugs.webkit.org/show_bug.cgi?id=31188
3780
3781         Clean up security origin usage in DOM Storage.  This fixes a bug in my
3782         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
3783
3784         Instead of having StorageAreaSync's constructor (which is called in the
3785         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
3786         database identifier, simply have StorageAreaImpl pass the identifier into
3787         StorageAreaSync.
3788
3789         No test because there's no change in externally observable behavior.
3790
3791         * storage/StorageAreaImpl.cpp:
3792         (WebCore::StorageAreaImpl::StorageAreaImpl):
3793         * storage/StorageAreaImpl.h:
3794         * storage/StorageAreaSync.cpp:
3795         (WebCore::StorageAreaSync::create):
3796         (WebCore::StorageAreaSync::StorageAreaSync):
3797         * storage/StorageAreaSync.h:
3798
3799 2009-11-05  Scott Violet  <sky@google.com>
3800
3801         Reviewed by Dimitri Glazkov.
3802
3803         Need notification of scrolling frame
3804         https://bugs.webkit.org/show_bug.cgi?id=31145
3805
3806         Adds FrameLoaderClient::didChangeScrollOffset that is called when
3807         the frame scrolls. This will be used to know when history state
3808         needs to be updated.
3809
3810         * loader/FrameLoaderClient.h:
3811         (WebCore::FrameLoaderClient::didChangeScrollOffset):
3812         * page/FrameView.cpp:
3813         (WebCore::FrameView::valueChanged):
3814
3815 2009-11-05  Kenneth Russell  <kbr@google.com>
3816
3817         Reviewed by Dimitri Glazkov.
3818
3819         [V8] Update bindings to use new API for external arrays
3820         https://bugs.webkit.org/show_bug.cgi?id=31181
3821
3822         No new tests; covered by existing WebGL tests.
3823
3824         * bindings/v8/V8DOMWrapper.cpp:
3825         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
3826         (WebCore::V8DOMWrapper::getTemplate):
3827         (WebCore::V8DOMWrapper::convertToV8Object):
3828         * bindings/v8/V8DOMWrapper.h:
3829         * bindings/v8/custom/V8CanvasArrayCustom.h:
3830         (WebCore::constructCanvasArray):
3831
3832 2009-11-05  Alpha Lam  <hclam@chromium.org>
3833
3834         Not reviewed, Chromium build fix.
3835
3836         50561 introduces a custom method for SVGMatrix, we need to implement
3837         this in V8.
3838
3839         * bindings/v8/custom/V8CustomBinding.h:
3840         Adding definition for V8SVGMatrixMultiply.
3841         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
3842         (WebCore::CALLBACK_FUNC_DECL):
3843         Implement V8SVGMatrixMultiply according to the same method in JSC.
3844
3845 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3846
3847         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
3848
3849         * page/DOMWindow.cpp:
3850         (WebCore::DOMWindow::sessionStorage):
3851         * page/Settings.cpp:
3852         (WebCore::Settings::Settings):
3853         (WebCore::Settings::setSessionStorageEnabled):
3854         * page/Settings.h:
3855         (WebCore::Settings::sessionStorageEnabled):
3856
3857 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3858
3859         Reviewed by Timothy Hatcher.
3860
3861         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
3862
3863         https://bugs.webkit.org/show_bug.cgi?id=30884
3864
3865         Test: inspector/styles-iframe.html
3866
3867         * inspector/front-end/DOMAgent.js:
3868         (WebInspector.DOMNode):
3869         * inspector/front-end/InjectedScript.js:
3870         (InjectedScript.getStyles):
3871         (InjectedScript.getComputedStyle):
3872         (InjectedScript.addStyleSelector):
3873         * inspector/front-end/TestController.js:
3874         (WebInspector.TestController.prototype.notifyDone):
3875         (WebInspector.TestController.prototype.runAfterPendingDispatches):
3876         (WebInspector.evaluateForTestInFrontend.invokeMethod):
3877         (WebInspector.evaluateForTestInFrontend):
3878
3879 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
3880
3881         Reviewed by Geoffrey Garen and Dimitri Glazkov.
3882
3883         Rehashing of EventListenerMap leads to loss of EvenListenerList.
3884         https://bugs.webkit.org/show_bug.cgi?id=31027
3885
3886         Tested by new fast/events/event-listener-map-rehash-crash.html.
3887
3888         EventListenerMap modified to store pointers to listener vectors:
3889         * dom/EventTarget.cpp:
3890         (WebCore::EventTargetData::~EventTargetData):
3891         (WebCore::EventTarget::addEventListener):
3892         (WebCore::EventTarget::removeEventListener):
3893         (WebCore::EventTarget::fireEventListeners):
3894         (WebCore::EventTarget::getEventListeners):
3895         (WebCore::EventTarget::removeAllEventListeners):
3896         * dom/EventTarget.h:
3897
3898         Usages updated after interface changes:
3899         * inspector/InspectorDOMAgent.cpp:
3900         (WebCore::InspectorDOMAgent::getEventListenersForNode):
3901         * svg/SVGUseElement.cpp:
3902         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
3903
3904 2009-11-05  Dan Kegel  <dank@chromium.org>
3905
3906         Reviewed by Dmitri Titov.
3907
3908         Add missing initialization for m_createdByParser.
3909         https://bugs.webkit.org/show_bug.cgi?id=31089
3910
3911         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
3912
3913         * dom/ProcessingInstruction.cpp:
3914         (WebCore::ProcessingInstruction::ProcessingInstruction):
3915
3916 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3917
3918         Reviewed by Adam Barth.
3919
3920         DOM Storage runtime flag changes
3921         https://bugs.webkit.org/show_bug.cgi?id=30602
3922
3923         Part 2/2.
3924
3925         Revert my changes to Settings and instead implement DOM Storage enabling via
3926         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
3927
3928         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
3929         LayoutTest visible changes and thus no tests.
3930
3931         * bindings/v8/custom/V8CustomBinding.h:
3932         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3933         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3934         * page/DOMWindow.cpp:
3935         (WebCore::DOMWindow::sessionStorage):
3936         * page/DOMWindow.idl:
3937         * page/Settings.cpp:
3938         (WebCore::Settings::Settings):
3939         * page/Settings.h:
3940         * storage/Storage.cpp:
3941         (WebCore::Storage::setLocalStorageAvailable):
3942         (WebCore::Storage::localStorageAvailable):
3943         (WebCore::Storage::setSessionStorageAvailable):
3944         (WebCore::Storage::sessionStorageAvailable):
3945         * storage/Storage.h:
3946
3947 2009-11-05  Jian Li  <jianli@chromium.org>
3948
3949         Reviewed by Pavel Feldman.
3950
3951         Bug 31108 - [V8] REGRESSION: Pause on exception is broken
3952         https://bugs.webkit.org/show_bug.cgi?id=31108
3953
3954         * bindings/v8/V8AbstractEventListener.cpp:
3955         (WebCore::V8AbstractEventListener::invokeEventHandler):
3956         * bindings/v8/V8Utilities.cpp:
3957         (WebCore::reportException):
3958
3959 2009-11-05  Jian Li  <jianli@chromium.org>
3960
3961         Reviewed by Dmitri Titov.
3962
3963         We should not bubble up events if we drag something to an iframe that
3964         has an invalid source.
3965         https://bugs.webkit.org/show_bug.cgi?id=30469
3966
3967         Test: http/tests/misc/bubble-drag-events.html
3968
3969         * page/EventHandler.cpp:
3970         (WebCore::EventHandler::handleDragAndDropForTarget):
3971         (WebCore::EventHandler::updateDragAndDrop):
3972         (WebCore::EventHandler::cancelDragAndDrop):
3973         (WebCore::EventHandler::performDragAndDrop):
3974         * page/EventHandler.h:
3975         (WebCore::EventHandler::):
3976
3977 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3978
3979         Reviewed by Timothy Hatcher.
3980
3981         Web Inspector: speed up Timelines Clear by a factor of thousands.
3982
3983         https://bugs.webkit.org/show_bug.cgi?id=31160
3984
3985         * inspector/front-end/utilities.js:
3986         (Element.prototype.removeChildren):
3987
3988 2009-11-05  Anton Muhin  <antonm@chromium.org>
3989
3990         Reviewed by Adam Barth.
3991
3992         If high memory usage is detected, hint to V8 that it might be due
3993         to external objects retained by V8 objects.
3994         https://bugs.webkit.org/show_bug.cgi?id=31051
3995
3996         * bindings/v8/V8GCController.cpp:
3997         (WebCore::GetMemoryUsageInMB):
3998         (WebCore::V8GCController::gcEpilogue):
3999         (WebCore::V8GCController::checkMemoryUsage):
4000         * bindings/v8/V8GCController.h:
4001         * bindings/v8/V8Proxy.cpp:
4002         (WebCore::V8Proxy::evaluate):
4003         (WebCore::V8Proxy::runScript):
4004         (WebCore::V8Proxy::callFunction):
4005
4006 2009-11-05  Jeff Schiller  <codedread@gmail.com>
4007
4008         Reviewed by Simon Fraser.
4009
4010         Correct order of matrix multiplication for SVGMatrix.
4011         https://bugs.webkit.org/show_bug.cgi?id=16062
4012
4013         Test: svg/dom/SVGMatrix-interface.xhtml
4014
4015         * bindings/js/JSSVGMatrixCustom.cpp:
4016         (WebCore::JSSVGMatrix::multiply):
4017         * svg/SVGMatrix.idl:
4018
4019 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
4020
4021         Reviewed by Timothy Hatcher.
4022
4023         Web Inspector: Make resource-related records in timeline
4024         actually take some time.
4025
4026         https://bugs.webkit.org/show_bug.cgi?id=31139
4027
4028         * English.lproj/localizedStrings.js:
4029         * inspector/front-end/TimelinePanel.js:
4030         (WebInspector.TimelinePanel):
4031         (WebInspector.TimelinePanel.prototype._formatRecord):
4032         (WebInspector.TimelinePanel.prototype._getRecordDetails):
4033         (WebInspector.TimelinePanel.prototype.reset):
4034
4035 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
4036
4037         Reviewed by Darin Fisher.
4038
4039         Simplify LocalStorageThread
4040         https://bugs.webkit.org/show_bug.cgi?id=30935
4041
4042         This is a re-submit of 50519.  LocalStorageTask should have never been ref
4043         counted.  I've removed that and switched a PassRefPtr over to a PassOwnPtr.
4044
4045         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
4046         of the method names a bit more clear. Assert proper thread usage. Join rather
4047         than detaching the thread and doing an ad-hoc form of join. Avoid touching
4048         variables on the background thread when simple to do so.  Also create a generic
4049         scheduleTask function rather than one for each task.
4050
4051         No behavior should have changed.
4052
4053         * storage/LocalStorageTask.h:
4054         * storage/LocalStorageThread.cpp:
4055         (WebCore::LocalStorageThread::create):
4056         (WebCore::LocalStorageThread::LocalStorageThread):
4057         (WebCore::LocalStorageThread::~LocalStorageThread):
4058         (WebCore::LocalStorageThread::start):
4059         (WebCore::LocalStorageThread::threadEntryPointCallback):
4060         (WebCore::LocalStorageThread::threadEntryPoint):
4061         (WebCore::LocalStorageThread::scheduleTask):
4062         (WebCore::LocalStorageThread::terminate):
4063         (WebCore::LocalStorageThread::performTerminate):
4064         * storage/LocalStorageThread.h:
4065         * storage/StorageSyncManager.cpp:
4066         (WebCore::StorageSyncManager::StorageSyncManager):
4067         (WebCore::StorageSyncManager::~StorageSyncManager):
4068         (WebCore::StorageSyncManager::scheduleImport):
4069         (WebCore::StorageSyncManager::scheduleSync):
4070         * storage/StorageSyncManager.h:
4071
4072 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
4073
4074         Reviewed by Darin Fisher.
4075
4076         Calling databaseIdentifier on LocalStorage's background thread is not safe.
4077         https://bugs.webkit.org/show_bug.cgi?id=31149
4078
4079         Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
4080         is not safe.  databaseIdentifier does a bunch of string concatenation which
4081         ref-counts StringImpls in some cases.  This was caught by valgrind thread
4082         sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645
4083
4084         There's no way to test for such racyness, unfortunately.
4085
4086         * storage/StorageAreaSync.cpp:
4087         (WebCore::StorageAreaSync::StorageAreaSync):
4088         (WebCore::StorageAreaSync::performImport):
4089         * storage/StorageAreaSync.h:
4090         * storage/StorageSyncManager.cpp:
4091         (WebCore::StorageSyncManager::fullDatabaseFilename):
4092         * storage/StorageSyncManager.h:
4093
4094 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
4095
4096         Reviewed by Darin Fisher.
4097
4098         Clean up StorageAreaSync
4099         https://bugs.webkit.org/show_bug.cgi?id=31100
4100
4101         Major fixes: Break the ref count cycle for StorageArea on the main
4102         thread, not the background thread since the latter is not safe.
4103         Length() needs to block on the import completing.
4104
4105         Small fixes: setItem needs to handle the copy on write case even if it
4106         has an exception.  setItem and removeItem should just bail from the
4107         the function if the value hasn't changed rather than wrapping the end
4108         in an if block.  Clear should only send an event if it wasn't already
4109         cleared.  StorageAreaSync should assert that the final sync was
4110         scheduled.
4111
4112         * storage/StorageAreaImpl.cpp:
4113         (WebCore::StorageAreaImpl::length):
4114           Forgot to block on the import.
4115         (WebCore::StorageAreaImpl::key):
4116         (WebCore::StorageAreaImpl::setItem):
4117           Handle the copy on write case even when there's an exception.
4118         (WebCore::StorageAreaImpl::removeItem):
4119         (WebCore::StorageAreaImpl::clear):
4120         * storage/StorageAreaSync.cpp:
4121         (WebCore::StorageAreaSync::~StorageAreaSync):
4122         (WebCore::StorageAreaSync::scheduleFinalSync):
4123         (WebCore::StorageAreaSync::performImport):
4124         (WebCore::StorageAreaSync::markImported):
4125         (WebCore::StorageAreaSync::blockUntilImportComplete):
4126         * storage/StorageAreaSync.h:
4127
4128 2009-11-05  Zoltan Horvath  <zoltan@webkit.org>
4129
4130         Reviewed by Eric Seidel.
4131
4132         Allow custom memory allocation control for WebCore's CachedResource
4133         https://bugs.webkit.org/show_bug.cgi?id=31114
4134
4135         Inherits CachedResource class from Noncopyable because its (its child
4136         class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75
4137         and it is no need to be copyable.
4138
4139         * loader/CachedResource.h:
4140
4141 2009-11-04  Mark Mentovai  <mark@chromium.org>
4142
4143         Reviewed by Mark Rowe.
4144
4145         Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
4146         is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
4147         which is true when targeting 10.6 or later.
4148
4149         HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
4150         is present in the CGInterpolationQuality enum, and must be handled
4151         by a switch that has cases for each enumerated value.
4152
4153         USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
4154         on 10.6 or later, and that CoreGraphics will understand when
4155         InterpolationMedium is mapped to kCGInterpolationMedium at runtime.
4156
4157         * platform/graphics/cg/GraphicsContextCG.cpp:
4158         (WebCore::GraphicsContext::setImageInterpolationQuality):
4159         (WebCore::GraphicsContext::imageInterpolationQuality):
4160
4161 2009-11-04  Dan Kegel  <dank@chromium.org>
4162
4163         Reviewed by Alexey Proskuryakov.
4164
4165         Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
4166         https://bugs.webkit.org/show_bug.cgi?id=31138
4167
4168         Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind
4169
4170         * page/Page.cpp:
4171         (WebCore::Page::userStyleSheetLocationChanged):
4172
4173 2009-11-04  Timothy Hatcher  <timothy@apple.com>
4174
4175         Update the Web Inspector Timeline panel to better match the mock-up.
4176
4177         https://bugs.webkit.org/show_bug.cgi?id=31150
4178
4179         Reviewed by Pavel Feldman.
4180
4181         * inspector/front-end/TimelinePanel.js:
4182         (WebInspector.TimelinePanel.prototype._getRecordDetails):
4183         (WebInspector.TimelinePanel.prototype._dragWindow):
4184         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
4185         (WebInspector.TimelinePanel.prototype._resizeWindowRight):
4186         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
4187         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
4188         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
4189         (WebInspector.TimelineCategoryGraph):
4190         * inspector/front-end/inspector.css:
4191
4192 2009-11-05  Justin Garcia  <justin.garcia@apple.com>
4193
4194         Reviewed by Adele Peterson.
4195
4196         https://bugs.webkit.org/show_bug.cgi?id=25439
4197         Deleting when in front of a block image removes character from previous paragraph
4198
4199         Added editing/deleting/25439-{1,2,3}.html
4200
4201         * editing/DeleteSelectionCommand.cpp:
4202         (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot
4203         be made inline with other content.  Instead of merging, just move the caret to just before
4204         the selection we deleted.
4205         * editing/htmlediting.cpp:
4206         (WebCore::firstInSpecialElement): Added a FIXME.  This function begins iterating up from pos.node(), which
4207         doesn't necessarily contain pos (suppose pos was [img, 0]).
4208         (WebCore::lastInSpecialElement): Ditto.
4209         (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp.  Added a check for non-inline images.
4210         * editing/htmlediting.h:
4211         * editing/visible_units.cpp:
4212         (WebCore::startOfParagraph): Use moved/renamed function.  Removed FIXME.  The problem causing
4213         5027702 is now squarely in first/lastInSpecialElement
4214         (WebCore::endOfParagraph): Ditto.
4215
4216 2009-11-04  Enrica Casucci  <enrica@apple.com>
4217
4218         Reviewed by Adele Peterson.
4219
4220         Hang in Mail on attempting to change indent level.
4221         <rdar://problem/7131805>
4222         https://bugs.webkit.org/show_bug.cgi?id=31127
4223
4224         The hang was caused by an infinite loop inside outdentRegion.
4225         The code did not account for the fact that, when a list item
4226         contains multiple paragraphs, outdent moves all paragraphs at
4227         once, invalidating some of the positions we keep track of in the loop.
4228         Some code refactoring has also been done to minimize duplicated code.
4229
4230         Test: editing/execCommand/outdent-multiparagraph-list.html
4231
4232         * editing/IndentOutdentCommand.cpp:
4233         (WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
4234         outdentRegion to doApply.
4235         (WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
4236         (WebCore::IndentOutdentCommand::doApply): Some code refactoring.
4237         * editing/IndentOutdentCommand.h: Added VisiblePosition parameters to
4238         indentRegion and outdentRegion.
4239
4240 2009-11-04  Alpha Lam  <hclam@chromium.org>
4241
4242         Reviewed by Eric Carlson.
4243
4244         Volume slider doesn't have a thumb
4245         https://bugs.webkit.org/show_bug.cgi?id=31135
4246
4247         Fixed an incorrect if statement that prevents volume slider
4248         being updated.
4249
4250         The statement checks if the slider value equals to the current
4251         volume value of the media control to avoid updating the volume
4252         slider. Updating the volume slider control shouldn't be within
4253         this condition because we explicitly set them to be equals
4254         during creation of the controls and also when mouse events are
4255         received on the volume control.
4256
4257         No new tests because existing code breaks:
4258         LayoutTests/media/video-volume-slider.html
4259
4260         It should now start passing on Chromium.
4261
4262         * rendering/MediaControlElements.cpp:
4263         (WebCore::MediaControlVolumeSliderElement::update):
4264         Update the volume slider regardless of the current volume value
4265         of the media control.
4266
4267 2009-11-04  Jenn Braithwaite  <jennb@chromium.org>
4268
4269         Reviewed by David Levin.
4270
4271         Need to properly disable applicationCache at runtime
4272         https://bugs.webkit.org/show_bug.cgi?id=30417
4273
4274         Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.
4275
4276         No new exposed functionality, so no new tests.
4277
4278         * bindings/v8/RuntimeEnabledFeatures.cpp:
4279         * bindings/v8/RuntimeEnabledFeatures.h:
4280         (WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
4281         (WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
4282         * bindings/v8/custom/V8CustomBinding.h:
4283         * bindings/v8/custom/V8DOMWindowCustom.cpp:
4284         (WebCore::ACCESSOR_RUNTIME_ENABLER):
4285         * page/DOMWindow.idl:
4286
4287 2009-11-04  Alexey Proskuryakov  <ap@apple.com>
4288
4289         Reviewed by Dan Bernstein.
4290
4291         https://bugs.webkit.org/show_bug.cgi?id=31143
4292         Assertion failure in CredentialStorage::set() when proxy credentials are being set
4293
4294         No test, cannot test proxy behavior.