Reverted the code part of r16696, my patch for <rdar://problem/4641262>,...
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-02  David Harrison  <harrison@apple.com>
2
3         Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
4         addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
5         Left the layout test.
6         
7         * rendering/bidi.cpp:
8         (WebCore::checkMidpoints):
9
10 2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>
11
12         Reviewed by eseidel.  Landed by eseidel.
13
14         Fix Qt/Linux build.
15
16         * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
17         (WebCore::supportedKeySizes):
18
19 2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>
20
21         Reviewed by eseidel & mjs.  Landed by eseidel.
22
23         Fix Qt/Linux build with older gcc 3.3.4.
24         http://bugs.webkit.org/show_bug.cgi?id=11116
25
26         As discussed with Maciej, the GCC_ROOT_NS_HACK
27         can be completely removed, as well as the friendship
28         between cacheGlobalObject & the JS* objects.
29
30         * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
31         * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
32         (png_read_filter_row_mmx_avg):
33         * platform/image-decoders/png/pngvcrd.c: Ditto.
34         (png_mmx_support):
35         (png_read_filter_row_mmx_avg):
36
37 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
38
39         Rubber stamped by Alexey.
40
41         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes
42
43         * css/CSSGrammar.y:
44
45 2006-10-01  Eric Seidel  <eric@webkit.org>
46
47         Reviewed by mjs.
48
49         Eliminate a few more hotspots in SVG drawing code.
50         
51         No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)
52
53         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
54         (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
55         * platform/mac/ColorMac.mm:
56         (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance
57
58 2006-10-01  Geoffrey Garen  <ggaren@apple.com>
59
60         Reviewed by Maciej.
61         
62         More frame/iframe merging.
63         
64         - Removed needWidgetUpdate and related code. needWidgetUpdate is always
65         false, so this was dead code.
66         - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
67         than attach(), is the correct place for setInViewSourceMode, because
68         openURL() is the function that creates our frame.
69         - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
70         code that did the same thing in other places.
71         - Made FRAME's attach() method suffuciently generic so that IFRAME could
72         call up to it, rather than skipping its superclass and calling up directly 
73         to ELEMENT.
74         - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
75         - Replaced ad hoc frame loading code in FRAME::attach() with call to
76         openURL(), the designated frame loading function.
77
78         Layout tests pass. I added a layout test for viewsource mode, since I
79         broke it in the course of writing this patch.
80
81 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
82
83         Reviewed by Geoff.
84
85         * dom/Document.cpp:
86         (WebCore::Document::recalcStyleSelector):
87         * dom/Document.h:
88         Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
89         
90         * dom/Node.h:
91         Remove DeprecatedStringList class forward declaration.
92         
93         * editing/markup.cpp:
94         Include DeprecatedStringList.h here since it's not included by Document.h anymore.
95         
96         * kcanvas/KCanvasTreeDebug.cpp:
97         * kcanvas/KCanvasTreeDebug.h:
98         Remove unused functions.
99         
100         * loader/loader.cpp:
101         * page/Frame.cpp:
102         * page/Frame.h:
103         * page/FrameView.h:
104         Fixup DeprecatedStringList.h includes.
105
106 2006-09-30  David Harrison  <harrison@apple.com>
107
108         Reviewed by John Sullivan.
109
110         <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
111
112         Problem was that the decision to trim was based only on whether the character
113         is a soft hyphen, which caused pretty much any Japanese character to go.
114         Changed to decide based on whether the character is ignorable whitespace.
115         
116         Test:
117         * fast/text/international/wrap-CJK-001.html
118
119         * rendering/bidi.cpp:
120         (WebCore::isTrimmableChar):
121         New. Checks whether character is whitespace that can be ignored
122         according to the text node's style.
123         trimmed from the end of wrapped line.
124         (WebCore::checkMidpoints):
125         Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
126
127 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
128
129         Reviewed by Mitz Pettel.
130
131         Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
132
133         * ksvg2/svg/SVGColor.cpp:
134         (WebCore::SVGColor::setRGBColor):
135         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
136         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
137         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
138         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
139         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
140         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
141         (SVGFESpecularLightingElement::parseMappedAttribute):
142         * ksvg2/svg/SVGFETurbulenceElement.cpp:
143         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
144         * ksvg2/svg/SVGLengthList.cpp:
145         * ksvg2/svg/SVGNumberList.cpp:
146         (SVGNumberList::parse):
147         * ksvg2/svg/SVGNumberList.h:
148         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
149         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
150         * ksvg2/svg/SVGStringList.cpp:
151         (WebCore::SVGStringList::reset):
152         * ksvg2/svg/SVGStringList.h:
153         * ksvg2/svg/SVGTransformable.cpp:
154         (SVGTransformable::parseTransformAttribute):
155
156 2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>
157
158         Reviewed by Eric, tweaked and landed by ap.
159
160         Fix Qt/Linux build.
161
162         * CMakeLists.txt:
163         * platform/qt/PlatformScrollBar.h:
164         * platform/qt/TemporaryLinkStubs.cpp:
165         (WebCore::ScrollBar::ScrollBar):
166         (WebCore::PlatformScrollBar::PlatformScrollBar):
167         (FrameView::passMousePressEventToSubframe):
168         (FrameView::passMouseMoveEventToSubframe):
169         (FrameView::passMouseReleaseEventToSubframe):
170         (FrameView::passWheelEventToSubframe):
171         (FrameView::passMousePressEventToScrollbar):
172         * ksvg2/svg/SVGDocument.h:
173
174 2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>
175
176         Reviewed by Darin.
177
178         Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
179         REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
180
181         No test case added (probably requires new DumpRenderTree functionality)
182
183         * rendering/RenderImage.cpp:
184         (WebCore::RenderImage::imageChanged): Added early return if the document is
185         being destroyed.
186
187 2006-10-01  Graham Dennis  <graham.dennis@gmail.com>
188
189         Reviewed by Hyatt.
190
191         Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
192         REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
193         
194         Make sure we only break after a space (and not any other valid line-break) if
195         the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
196         I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
197         twice in quick succession.
198
199         * rendering/bidi.cpp:
200         (WebCore::RenderBlock::findNextLineBreak): 
201
202 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
203
204         Reviewed by Maciej and Darin.
205
206         http://bugs.webkit.org/show_bug.cgi?id=4372
207         JavaScript document.write page form does not submit in Safari
208
209         Test: fast/forms/document-write.html
210
211         * page/Frame.cpp:
212         (WebCore::Frame::submitForm): Don't check for parsing().
213
214 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
215
216         Build fix.
217
218         * bridge/mac/FrameViewMac.mm: Add missing #imports.
219
220 2006-10-01  Dave Hyatt  <hyatt@apple.com>
221
222         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
223        
224         Reviewed by mitz
225
226         * bridge/mac/FrameMac.mm:
227         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
228         * bridge/mac/FrameViewMac.mm:
229         (WebCore::FrameView::passMousePressEventToScrollbar):
230         * page/FrameView.cpp:
231         (WebCore::FrameView::handleMousePressEvent):
232         (WebCore::FrameView::setMousePressed):
233         * page/FrameView.h:
234         * platform/win/TemporaryLinkStubs.cpp:
235         (FrameView::passMousePressEventToScrollbar):
236
237 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
238
239         Reviewed by Darin.
240
241         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
242         Add more SVG Objective-C DOM bindings
243
244         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
245           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
246           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
247           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
248           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument, 
249           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
250
251         * DerivedSources.make:
252         * WebCore.xcodeproj/project.pbxproj:
253         * bindings/objc/DOMInternal.h:
254         * bindings/objc/DOMSVG.h:
255         * bindings/scripts/CodeGeneratorObjC.pm:
256         * ksvg2/svg/SVGAElement.idl:
257         * ksvg2/svg/SVGAnimateColorElement.idl:
258         * ksvg2/svg/SVGAnimateElement.idl:
259         * ksvg2/svg/SVGAnimateTransformElement.idl:
260         * ksvg2/svg/SVGAnimatedPathData.idl:
261         * ksvg2/svg/SVGAnimatedPoints.idl:
262         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
263         * ksvg2/svg/SVGAnimationElement.idl:
264         * ksvg2/svg/SVGCircleElement.idl:
265         * ksvg2/svg/SVGClipPathElement.idl:
266         * ksvg2/svg/SVGColor.idl:
267         * ksvg2/svg/SVGCursorElement.idl:
268         * ksvg2/svg/SVGDefsElement.idl:
269         * ksvg2/svg/SVGDescElement.idl:
270         * ksvg2/svg/SVGDocument.idl:
271         * ksvg2/svg/SVGEllipseElement.idl:
272         * ksvg2/svg/SVGPointList.idl:
273         * ksvg2/svg/SVGPreserveAspectRatio.idl:
274         * ksvg2/svg/SVGRect.idl:
275         * ksvg2/svg/SVGSVGElement.idl:
276
277 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
278
279         Reviewed by Adele.
280
281         - fix build
282
283         * platform/FloatRect.h:
284         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
285         but more appropriate for path-type stuff.
286         * platform/cg/PathCG.cpp:
287         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
288
289 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
290
291         Reviewed by Darin.
292
293         http://bugs.webkit.org/show_bug.cgi?id=11011
294         External CSS is parsed as iso-8859-1 even though the main document is utf-8
295
296         Test: fast/encoding/css-charset-default.xhtml
297
298         * loader/CachedResourceClient.h:
299         (WebCore::CachedResourceClient::setCSSStyleSheet):
300         (WebCore::CachedResourceClient::setXSLStyleSheet):
301         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
302         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
303
304         * css/CSSImportRule.cpp:
305         (WebCore::CSSImportRule::setCSSStyleSheet):
306         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
307         * css/CSSImportRule.h:
308
309         * css/CSSStyleSheet.cpp:
310         (WebCore::CSSStyleSheet::CSSStyleSheet):
311         * css/CSSStyleSheet.h:
312         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
313         member. Changed some String parameters to const String&.
314
315         * css/StyleSheet.cpp:
316         (WebCore::StyleSheet::StyleSheet):
317         * css/StyleSheet.h:
318         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
319
320         * css/StyleSheetList.cpp:
321         (WebCore::StyleSheetList::length):
322         (WebCore::StyleSheetList::item):
323         * css/StyleSheetList.h:
324         Special-casing implicit stylesheets seemed to be dead code, removed.
325
326         * dom/Document.cpp:
327         (WebCore::Document::setCSSStyleSheet):
328         (WebCore::Document::recalcStyleSelector):
329         * dom/Document.h:
330         Renamed setStyleSheet() to setCSSStyleSheet().
331
332         * dom/ProcessingInstruction.cpp:
333         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
334         (WebCore::ProcessingInstruction::setCSSStyleSheet):
335         (WebCore::ProcessingInstruction::setXSLStyleSheet):
336         (WebCore::ProcessingInstruction::parseStyleSheet):
337         * dom/ProcessingInstruction.h:
338
339         * html/HTMLLinkElement.cpp:
340         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute 
341         is not specified.
342         (WebCore::HTMLLinkElement::setCSSStyleSheet):
343         * html/HTMLLinkElement.h:
344
345         * html/HTMLStyleElement.cpp:
346         (WebCore::HTMLStyleElement::childrenChanged):
347         * ksvg2/svg/SVGStyleElement.cpp:
348         (WebCore::SVGStyleElement::childrenChanged):
349         Inherit URL and charset from the document.
350
351         * loader/Cache.cpp:
352         (WebCore::Cache::requestCSSStyleSheet):
353         * loader/Cache.h:
354         Adjust for setStyleSheet() renaming.
355
356         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
357         * loader/CachedCSSStyleSheet.cpp:
358         (WebCore::CachedCSSStyleSheet::ref):
359         (WebCore::CachedCSSStyleSheet::deref):
360         (WebCore::CachedCSSStyleSheet::checkNotify):
361         Pass the encoding to setCSSStyleSheet().
362
363         * loader/CachedXSLStyleSheet.cpp:
364         (WebCore::CachedXSLStyleSheet::ref):
365         (WebCore::CachedXSLStyleSheet::checkNotify):
366         * loader/DocLoader.cpp:
367         (WebCore::DocLoader::requestCSSStyleSheet):
368         * loader/DocLoader.h:
369         * page/Frame.cpp:
370         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
371         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
372         * xml/XSLImportRule.cpp:
373         (WebCore::XSLImportRule::setXSLStyleSheet):
374         (WebCore::XSLImportRule::loadSheet):
375         * xml/XSLImportRule.h:
376         Adjust for setStyleSheet() renaming.
377
378 2006-09-30  Rob Buis  <buis@kde.org>
379
380         Reviewed by eseidel.
381
382         http://bugs.webkit.org/show_bug.cgi?id=11096
383         Hit testing for polylines fails
384
385         Fix Path::contains so it handles filled, non-closed paths too.
386
387         * platform/cg/PathCG.cpp:
388         (WebCore::Path::contains):
389
390 2006-09-30  Dave Hyatt  <hyatt@apple.com>
391
392         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
393         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
394         subframes while the mouse is down.
395       
396         Reviewed by mitzpettel
397
398         * bridge/mac/FrameMac.h:
399         * bridge/mac/FrameMac.mm:
400         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
401         (WebCore::FrameMac::passWheelEventToWidget):
402         * bridge/mac/FrameViewMac.mm:
403         (WebCore::FrameView::passMousePressEventToSubframe):
404         (WebCore::FrameView::passMouseMoveEventToSubframe):
405         (WebCore::FrameView::passMouseReleaseEventToSubframe):
406         (WebCore::FrameView::passWheelEventToSubframe):
407         * page/Frame.cpp:
408         * page/Frame.h:
409         * page/FrameView.cpp:
410         (WebCore::subframeForTargetNode):
411         (WebCore::FrameView::handleMousePressEvent):
412         (WebCore::FrameView::handleMouseDoubleClickEvent):
413         (WebCore::FrameView::handleMouseMoveEvent):
414         (WebCore::FrameView::handleMouseReleaseEvent):
415         (WebCore::FrameView::handleWheelEvent):
416         * page/FrameView.h:
417         * platform/ScrollBar.h:
418         (WebCore::ScrollBar::handleMouseMoveEvent):
419         (WebCore::ScrollBar::handleMouseOutEvent):
420         * platform/Widget.h:
421         (WebCore::Widget::handleMouseMoveEvent):
422         (WebCore::Widget::handleMouseReleaseEvent):
423         * platform/win/TemporaryLinkStubs.cpp:
424         (FrameView::passMousePressEventToSubframe):
425         (FrameView::passMouseMoveEventToSubframe):
426         (FrameView::passMouseReleaseEventToSubframe):
427         (FrameView::passWheelEventToSubframe):
428         (Widget::capturingMouse):
429         (Widget::setCapturingMouse):
430         (Widget::capturingTarget):
431         (Widget::capturingChild):
432         (Widget::setCapturingChild):
433         * rendering/RenderView.cpp:
434         (WebCore::RenderView::paintBoxDecorations):
435
436 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
437
438         Reviewed by Adele.
439
440         Fixes windows bustage:
441         http://bugs.webkit.org/show_bug.cgi?id=11093
442
443         * platform/win/PlatformScrollBar.h:
444         * platform/win/TemporaryLinkStubs.cpp:
445         (PlatformScrollBar::PlatformScrollBar):
446         (ScrollBar::ScrollBar):
447
448 2006-09-29  David Hyatt  <hyatt@apple.com>
449
450         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
451         in RenderObject::NodeInfo (and then propagating that Widget to
452         MouseEventWithHitTestResults).
453
454         This allows RenderListBox and RenderBlock to do the same thing when the
455         mouse is over the scrollbar.
456
457         Also land fix to support font-size: 0.
458
459         Reviewed by mjs (scrollbar), eric (font-size)
460
461         * dom/Document.cpp:
462         (WebCore::Document::prepareMouseEvent):
463         * page/Frame.cpp:
464         (WebCore::Frame::passWidgetMouseDownEventToWidget):
465         * page/FrameView.cpp:
466         (WebCore::selectCursor):
467         (WebCore::FrameView::handleMouseMoveEvent):
468         (WebCore::FrameView::dispatchMouseEvent):
469         * page/MouseEventWithHitTestResults.cpp:
470         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
471         * page/MouseEventWithHitTestResults.h:
472         (WebCore::MouseEventWithHitTestResults::scrollbar):
473         * rendering/RenderBlock.cpp:
474         (WebCore::RenderBlock::isPointInScrollbar):
475         (WebCore::RenderBlock::nodeAtPoint):
476         * rendering/RenderBlock.h:
477         * rendering/RenderLayer.cpp:
478         (WebCore::RenderLayer::hitTest):
479         * rendering/RenderLayer.h:
480         (WebCore::RenderLayer::getHiddenBehavior):
481         * rendering/RenderListBox.cpp:
482         (WebCore::RenderListBox::RenderListBox):
483         (WebCore::RenderListBox::~RenderListBox):
484         (WebCore::RenderListBox::isPointInScrollbar):
485         * rendering/RenderListBox.h:
486         * rendering/RenderObject.h:
487         (WebCore::RenderObject::NodeInfo::NodeInfo):
488         (WebCore::RenderObject::NodeInfo::scrollbar):
489         (WebCore::RenderObject::NodeInfo::setScrollbar):
490
491 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
492
493         Reviewed by Adele.
494
495         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
496
497         * platform/win/ScrollViewWin.cpp:
498         (WebCore::ScrollView::convertToContainingWindow):
499         (WebCore::ScrollView::convertFromContainingWindow):
500         * platform/win/WidgetWin.cpp:
501         (WebCore::Widget::convertToContainingWindow):
502         (WebCore::Widget::convertFromContainingWindow):
503
504 2006-09-29  Adele Peterson  <adele@apple.com>
505
506         Updated with new argument for PlatformScrollBar.
507
508         * platform/win/TemporaryLinkStubs.cpp:
509         (PlatformScrollBar::PlatformScrollBar):
510
511 2006-09-29  Adele Peterson  <adele@apple.com>
512
513         Reviewed by Hyatt.
514
515         Fixing build bustage with cast to int.
516
517         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
518
519 2006-09-29  Adele Peterson  <adele@apple.com>
520
521         Fixing accidental include.
522
523         * rendering/RenderListBox.cpp:
524
525 2006-09-29  Adele Peterson  <adele@apple.com>
526
527         Adding RenderListBox files.
528
529         * WebCore.vcproj/WebCore/WebCore.vcproj:
530
531 2006-09-29  Adele Peterson  <adele@apple.com>
532
533         Reviewed by Adam.
534
535         Initial implementation of engine-based list box control.
536
537         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
538
539         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
540         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
541         (WebCore::FrameMac::FrameMac):
542         (WebCore::FrameMac::handleMousePressEvent):
543         (WebCore::FrameMac::handleMouseMoveEvent):
544         (WebCore::FrameMac::mouseDown):
545
546         * page/Frame.cpp:
547         (WebCore::Frame::handleMouseMoveEvent):
548         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
549         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
550         (WebCore::Frame::autoscrollTimerFired): ditto.
551         (WebCore::Frame::stopAutoscrollTimer): ditto.
552         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
553         * page/Frame.h:
554         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
555
556         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
557         (WebCore::FrameViewPrivate::reset):
558         (WebCore::FrameView::currentMousePosition):
559         (WebCore::FrameView::handleMousePressEvent):
560         (WebCore::FrameView::handleMouseDoubleClickEvent):
561         (WebCore::selectCursor):
562         (WebCore::FrameView::handleMouseMoveEvent):
563         (WebCore::FrameView::handleMouseReleaseEvent):
564         * page/FrameView.h:
565
566         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
567         * platform/ScrollBar.h:
568         (WebCore::):
569         (WebCore::ScrollBar::controlSize):
570         * platform/mac/PlatformScrollBar.h:
571         * platform/mac/PlatformScrollBarMac.mm:
572         (NSControlSizeForScrollBarControlSize):
573         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
574         (WebCore::PlatformScrollBar::PlatformScrollBar):
575
576         * rendering/RenderBlock.h:
577         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
578         * rendering/RenderLayer.h:
579         * rendering/RenderObject.cpp:
580         (WebCore::RenderObject::shouldAutoscroll):
581         (WebCore::RenderObject::autoscroll):
582         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
583
584         * css/html4.css: Added properties for new list boxes.
585
586         * html/HTMLOptionElement.cpp:
587         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
588         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
589         * html/HTMLOptionElement.h: Added disabled method.
590
591         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
592         (WebCore::HTMLSelectElement::recalcStyle):
593         (WebCore::HTMLSelectElement::lastSelectedListIndex):
594         (WebCore::HTMLSelectElement::deselectItems):
595         (WebCore::HTMLSelectElement::setSelectedIndex):
596         (WebCore::HTMLSelectElement::isKeyboardFocusable):
597         (WebCore::HTMLSelectElement::isMouseFocusable):
598         (WebCore::HTMLSelectElement::createRenderer):
599         (WebCore::HTMLSelectElement::recalcListItems):
600         (WebCore::HTMLSelectElement::setRecalcListItems):
601         (WebCore::HTMLSelectElement::reset):
602         (WebCore::HTMLSelectElement::notifyOptionSelected):
603         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
604         (WebCore::HTMLSelectElement::nextSelectableListIndex):
605         (WebCore::HTMLSelectElement::previousSelectableListIndex):
606         * html/HTMLSelectElement.h:
607
608         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
609         (WebCore::RenderTheme::paint):
610         (WebCore::RenderTheme::paintBorderOnly):
611         (WebCore::RenderTheme::paintDecorations):
612         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
613         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
614         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
615         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
616         (WebCore::RenderTheme::isControlStyled):
617         (WebCore::RenderTheme::supportsFocusRing):
618         * rendering/RenderTheme.h:
619         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
620
621         * rendering/RenderListBox.cpp: Added.
622         (WebCore::RenderListBox::RenderListBox):
623         (WebCore::RenderListBox::~RenderListBox):
624         (WebCore::RenderListBox::setStyle):
625         (WebCore::RenderListBox::updateFromElement):
626         (WebCore::RenderListBox::calcMinMaxWidth):
627         (WebCore::RenderListBox::size):
628         (WebCore::RenderListBox::numItems):
629         (WebCore::RenderListBox::calcHeight):
630         (WebCore::RenderListBox::baselinePosition):
631         (WebCore::RenderListBox::itemBoundingBoxRect):
632         (WebCore::RenderListBox::paintObject):
633         (WebCore::RenderListBox::paintScrollbar):
634         (WebCore::RenderListBox::paintItemForeground):
635         (WebCore::RenderListBox::paintItemBackground):
636         (WebCore::RenderListBox::scrollBarTarget):
637         (WebCore::RenderListBox::isPointInScrollbar):
638         (WebCore::RenderListBox::optionAtPoint):
639         (WebCore::RenderListBox::autoscroll):
640         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
641         (WebCore::RenderListBox::scroll):
642         (WebCore::RenderListBox::valueChanged):
643         * rendering/RenderListBox.h: Added.
644         (WebCore::RenderListBox::isListBox):
645         (WebCore::RenderListBox::selectionChanged):
646         (WebCore::RenderListBox::setSelectionChanged):
647         (WebCore::RenderListBox::canHaveChildren):
648         (WebCore::RenderListBox::renderName):
649         (WebCore::RenderListBox::setOptionsChanged):
650         (WebCore::RenderListBox::shouldAutoscroll):
651         (WebCore::RenderListBox::listIndexIsVisible):
652
653 2006-09-29  Beth Dakin  <bdakin@apple.com>
654
655         Reviewed by Darin.
656
657         We had a bug where html4.css was ignoring Media Queries. In the end 
658         the problem was that we were trying to send a char* to the 
659         MediaQueryEvaluator constructor that expects a String, but the 
660         char* got interpreted as a bool, the wrong constructor was called, 
661         and the media type was never set.
662
663         No test case possible since this only affects html4.css
664
665         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a 
666         char*
667         (WebCore::MediaQueryEvaluator):
668         * css/MediaQueryEvaluator.h: Same.
669
670 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
671
672         Reviewed by John, Maciej.
673         
674         Integrated some frame and iframe code. I'm trying to fix up frame ownership
675         and loading. Reducing the number of different code paths involved
676         seemed like a good first step.
677         
678         As a side effect, I fixed a bug where FRAME elements would report their
679         src attributes as relative, rather than compelete, URLs. (IFRAME elements
680         had the correct complete URL behavior.)
681
682         * html/HTMLFrameElement.cpp:
683         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
684         (WebCore::HTMLFrameElement::openURL):
685             (1) Removed checks that requestFrame does for us
686             (2) Added isURLAllowed check, to have one clear bottleneck for it
687             (3) Added viewsource check, to have one clear bottleneck for it
688         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
689         method, instead of finding our content frame in our own unique way.
690         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
691         since openURL does this for us now.
692         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
693         This is what FF does, and it made no sense to have different behaviors
694         for FRAME and IFRAME elements.
695         * html/HTMLIFrameElement.cpp:
696         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
697         code.
698         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
699         HTMLFrameElement now does everything we need.
700
701 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
702
703         Reviewed by Hyatt.
704
705         Fix Qt/Linux build.
706
707         * CMakeLists.txt:
708         * platform/qt/ScrollViewQt.cpp:
709         (WebCore::ScrollView::convertToContainingWindow):
710         (WebCore::ScrollView::convertFromContainingWindow):
711         * platform/qt/TemporaryLinkStubs.cpp:
712         (WebCore::signedPublicKeyAndChallengeString):
713         * platform/qt/WidgetQt.cpp:
714         (WebCore::Widget::convertToContainingWindow):
715         (WebCore::Widget::convertFromContainingWindow):
716
717 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
718
719         Reviewed by Tim H.
720
721         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
722         Simplify Internal methods for the auto-generated Objective-C DOM code
723
724         - Auto-generate the internal methods for more Objective-C classes.
725
726         * WebCore.xcodeproj/project.pbxproj:
727         * bindings/objc/DOM.mm:
728         * bindings/objc/DOMCSS.mm:
729         (-[DOMStyleSheet WebCore::]):
730         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
731         (-[DOMCSSRule WebCore::]):
732         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
733         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
734         (-[DOMCSSValue WebCore::]):
735         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
736         (+[DOMCSSValue _CSSValueWith:WebCore::]):
737         * bindings/objc/DOMHTMLAppletElement.mm:
738         (-[DOMHTMLAppletElement WebCore::]):
739         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
740         * bindings/objc/DOMHTMLEmbedElement.mm:
741         (-[DOMHTMLEmbedElement WebCore::]):
742         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
743         * bindings/objc/DOMInternal.h:
744         * bindings/objc/DOMInternal.mm:
745         * bindings/scripts/CodeGeneratorObjC.pm:
746         * css/CSSCharsetRule.idl:
747         * css/CSSFontFaceRule.idl:
748         * css/CSSImportRule.idl:
749         * css/CSSMediaRule.idl:
750         * css/CSSPageRule.idl:
751         * css/CSSPrimitiveValue.idl:
752         * css/CSSStyleRule.idl:
753         * css/CSSStyleSheet.idl:
754         * css/CSSUnknownRule.idl:
755         * css/CSSValueList.idl:
756         * dom/KeyboardEvent.idl:
757         * dom/MouseEvent.idl:
758         * dom/MutationEvent.idl:
759         * dom/NodeIterator.idl:
760         * dom/OverflowEvent.idl:
761         * dom/UIEvent.idl:
762         * dom/WheelEvent.idl:
763
764 2006-09-29  David Harrison  <harrison@apple.com>
765
766         Reviewed by John Sullivan.
767
768         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
769         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
770
771         Test added
772         * fast/text/attributed-substring-from-range-001.html
773
774         * bridge/mac/FrameMac.mm:
775         (WebCore::FrameMac::attributedString):
776         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
777         Also, add validation of the range.
778
779 2006-09-29  Rob Buis  <buis@kde.org>
780
781         Reviewed by Maciej.
782
783         http://bugs.webkit.org/show_bug.cgi?id=10893
784         InsertRule can not handle @import statements
785
786         Allow @import as part of a css rule.
787
788         * css/CSSGrammar.y:
789
790 2006-09-28  David Hyatt  <hyatt@apple.com>
791
792         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
793
794         * bridge/mac/FrameMac.mm:
795         (WebCore::FrameMac::eventMayStartDrag):
796         (WebCore::FrameMac::dragHysteresisExceeded):
797         (WebCore::FrameMac::mouseDown):
798         (WebCore::FrameMac::shouldDragAutoNode):
799         (WebCore::FrameMac::sendContextMenuEvent):
800         * bridge/mac/WebCoreFrameBridge.mm:
801         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
802
803 2006-09-28  Dave Hyatt  <hyatt@apple.com>
804
805         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
806         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
807         view.
808        
809         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
810         the patch after review, once I realized that these new functions essentially do the same thing.)
811
812         * dom/EventTargetNode.cpp:
813         (WebCore::EventTargetNode::dispatchMouseEvent):
814         (WebCore::EventTargetNode::dispatchWheelEvent):
815         * page/Frame.cpp:
816         (WebCore::Frame::selectClosestWordFromMouseEvent):
817         (WebCore::Frame::handleMousePressEventTripleClick):
818         (WebCore::Frame::handleMousePressEventSingleClick):
819         (WebCore::Frame::handleMouseMoveEvent):
820         (WebCore::Frame::handleMouseReleaseEvent):
821         * page/FrameView.cpp:
822         (WebCore::FrameView::handleMousePressEvent):
823         (WebCore::selectCursor):
824         (WebCore::FrameView::dispatchDragEvent):
825         (WebCore::FrameView::prepareMouseEvent):
826         (WebCore::FrameView::handleWheelEvent):
827         * platform/ScrollView.h:
828         * platform/Widget.cpp:
829         (WebCore::Widget::convertToContainingWindow):
830         * platform/Widget.h:
831         * platform/mac/ScrollViewMac.mm:
832         (WebCore::ScrollView::convertToContainingWindow):
833         (WebCore::ScrollView::convertFromContainingWindow):
834         * platform/mac/WidgetMac.mm:
835         (WebCore::Widget::convertToContainingWindow):
836         (WebCore::Widget::convertFromContainingWindow):
837         * platform/win/ScrollViewWin.cpp:
838         (WebCore::ScrollView::convertToContainingWindow):
839         (WebCore::ScrollView::convertFromContainingWindow):
840         * rendering/RenderLayer.cpp:
841         (WebCore::RenderLayer::resize):
842
843 2006-09-28  Alice Liu  <alice.liu@apple.com>
844
845         Build fix by adding missing files for CommandByName
846
847         * WebCore.xcodeproj/project.pbxproj:
848
849 2006-09-28  Alice Liu  <alice.liu@apple.com>
850
851         Adding CommandByName files to the vcproj
852
853         * WebCore.vcproj/WebCore/WebCore.vcproj:
854
855 2006-09-28  Alice Liu  <alice.liu@apple.com>
856
857         Reviewed by Adam Roben.
858
859         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc. 
860         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
861         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
862
863         * editing/CommandByName.cpp: Added.
864         Added a command class that hangs off the frame so the frame can call commands more easily.  
865         (WebCore::Frame::commandImp):
866         (WebCore::Frame::execCopy):
867         (WebCore::Frame::execCut):
868         (WebCore::Frame::execDelete):
869         (WebCore::Frame::execForwardDelete):
870         (WebCore::Frame::execPaste):
871         (WebCore::Frame::execMoveLeft):
872         (WebCore::Frame::execMoveRight):
873         (WebCore::Frame::execMoveUp):
874         (WebCore::Frame::execMoveDown):
875         (WebCore::Frame::execSelectAll):
876         (WebCore::Frame::execSelectLeft):
877         (WebCore::Frame::execSelectRight):
878         (WebCore::Frame::execSelectUp):
879         (WebCore::Frame::execSelectDown):
880         (WebCore::Frame::enabled):
881         (WebCore::Frame::enabledAnySelection):
882         (WebCore::Frame::enabledAnyEditableSelection):
883         (WebCore::Frame::enabledPaste):
884         (WebCore::Frame::enabledAnyRangeSelection):
885         (WebCore::Frame::enabledAnyEditableRangeSelection):
886         (WebCore::Frame::createCommandDictionary):
887         (WebCore::Frame::Command::):
888         (WebCore:::m_frame):
889         (WebCore::CommandByName::execCommand):
890         * editing/CommandByName.h: Added.
891         * page/Frame.cpp:
892         Added implementation of accessor for CommandByName member
893         (WebCore::Frame::command):
894         * page/Frame.h:
895         Added accessor for CommandByName member
896         * page/FramePrivate.h:
897         Added a CommandByName member
898         (WebCore::FramePrivate::FramePrivate):
899         * platform/PlatformMouseEvent.h:
900         Changed constructor prototype
901         * platform/StringImpl.cpp:
902         Exposing getWordBreakIterator to be used elsewhere
903         (WebCore::getWordBreakIterator):
904         * platform/StringImpl.h:
905         Exposing getWordBreakIterator to be used elsewhere
906         * platform/win/MouseEventWin.cpp:
907         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
908         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
909
910 2006-09-28  Adam Roben  <aroben@apple.com>
911
912         Reviewed by Adele.
913
914         Remove no-longer-used PopUpButton.
915
916         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
917         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
918         PopUpButtonMac.mm
919         * platform/PopUpButton.h: Removed.
920         * platform/mac/PopUpButtonMac.mm: Removed.
921         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
922         * rendering/DeprecatedRenderSelect.cpp: Change #include of
923         PopUpButton.h to ListBox.h
924
925 2006-09-28  Darin Adler  <darin@apple.com>
926
927         Reviewed by Alice.
928
929         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
930           10% perf. regression (copying strings while decoding)
931
932         Use Vector<UChar> instead of String when building up the decoded string in
933         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
934         String grows the buffer every single time that append is called. Using
935         Vector::append instead of String::append also avoids constructing a string
936         each time just to append and a questionable copy that is done inside the
937         String::append function which also contributed to the slowness.
938
939         * platform/PlatformString.h:
940         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
941         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
942         allocation.
943         * platform/StringImpl.h:
944         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
945
946         * platform/StreamingTextDecoder.h:
947         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
948         Change to use a Vector<UChar> instead of a String, since vectors have better
949         resizing performance (they store a separate capacity).
950
951         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
952         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
953         Change to use Vector<UChar> instead of String and then create a string at
954         the end of the process using the new adopt function.
955
956 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
957
958         Reviewed by Tim H.
959
960         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
961         Auto-generate more SVG Objective-C bindings
962
963         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean, 
964           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
965           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
966           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
967           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
968           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests, 
969           and DOMSVGTransformable.
970
971         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
972           parent interfaces and the SVG animated classes.
973
974         - Corrects CodeGenerator.pm to only skip the first parent for the main 
975           interface.
976
977         * DerivedSources.make:
978         * WebCore.xcodeproj/project.pbxproj:
979         * bindings/objc/DOMInternal.h:
980         * bindings/objc/DOMSVG.h:
981         * bindings/scripts/CodeGenerator.pm:
982         * bindings/scripts/CodeGeneratorObjC.pm:
983         * ksvg2/svg/SVGAnimatedAngle.idl:
984         * ksvg2/svg/SVGAnimatedBoolean.idl:
985         * ksvg2/svg/SVGAnimatedEnumeration.idl:
986         * ksvg2/svg/SVGAnimatedInteger.idl:
987         * ksvg2/svg/SVGAnimatedLength.idl:
988         * ksvg2/svg/SVGAnimatedLengthList.idl:
989         * ksvg2/svg/SVGAnimatedNumber.idl:
990         * ksvg2/svg/SVGAnimatedPathData.idl:
991         * ksvg2/svg/SVGAnimatedString.idl:
992         * ksvg2/svg/SVGAnimatedTransformList.idl:
993         * ksvg2/svg/SVGExternalResourcesRequired.idl:
994         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
995         * ksvg2/svg/SVGFitToViewBox.idl:
996         * ksvg2/svg/SVGLangSpace.idl:
997         * ksvg2/svg/SVGLocatable.idl:
998         * ksvg2/svg/SVGMetadataElement.idl:
999         * ksvg2/svg/SVGStringList.idl:
1000         * ksvg2/svg/SVGStylable.idl:
1001         * ksvg2/svg/SVGStyleElement.idl:
1002         * ksvg2/svg/SVGTests.idl:
1003         * ksvg2/svg/SVGTransformable.idl:
1004         * ksvg2/svg/SVGURIReference.idl:
1005         * ksvg2/svg/SVGUnitTypes.idl:
1006         * ksvg2/svg/SVGZoomAndPan.idl:
1007
1008 2006-09-28  Brady Eidson  <beidson@apple.com>
1009
1010         Reviewed by Mitz Pettel!!!
1011
1012         Change the error code check for common functions from SQLResultOk to SQLResultDone 
1013
1014         * loader/icon/IconDatabase.cpp:
1015         (WebCore::IconDatabase::forgetPageURLQuery):
1016         (WebCore::IconDatabase::setIconIDForPageURLQuery):
1017         (WebCore::IconDatabase::addIconForIconURLQuery):
1018
1019 2006-09-28  Dave Hyatt  <hyatt@apple.com>
1020
1021         Just eliminate MapWindowPoints usage and use the HWND as
1022         the viewport.
1023
1024         * platform/win/MouseEventWin.cpp:
1025         (WebCore::positionForEvent):
1026         * platform/win/ScrollViewWin.cpp:
1027         (WebCore::ScrollView::viewportToContents):
1028         (WebCore::ScrollView::contentsToViewport):
1029
1030 2006-09-27  David Hyatt  <hyatt@apple.com>
1031
1032         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
1033         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
1034         scrollbars to provide hover feedback if needed.
1035
1036         Reviewed by Eric
1037
1038         * page/FrameView.cpp:
1039         (WebCore::selectCursor):
1040         (WebCore::FrameView::handleMouseMoveEvent):
1041         * platform/ScrollBar.h:
1042         (WebCore::ScrollBar::mouseMoved):
1043
1044 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
1045
1046         Reviewed by Maciej and Adam, landed by Adam
1047
1048         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
1049         Windows build is busted
1050
1051         * platform/win/TemporaryLinkStubs.cpp:
1052         (ScrollView::paint):
1053         (ScrollView::themeChanged):
1054
1055 2006-09-27  Eric Seidel  <eric@eseidel.com>
1056
1057         Reviewed by mitz.
1058
1059         paths with no fill specified default to black but do not recieve paint-related mouse events
1060         http://bugs.webkit.org/show_bug.cgi?id=11069
1061         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
1062
1063         Test: svg/custom/hover-default-fill.svg
1064
1065         * kcanvas/RenderPath.cpp:
1066         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
1067         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
1068         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1069         (WebCore::KSVGPainterFactory::isFilled): remove null check
1070         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
1071         (WebCore::KSVGPainterFactory::isStroked): remove null check
1072         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
1073         * ksvg2/svg/SVGPaint.cpp:
1074         (WebCore::SVGPaint::defaultFill): added.
1075         (WebCore::SVGPaint::defaultStroke): added.
1076         * ksvg2/svg/SVGPaint.h:
1077
1078 2006-09-27  Rob Buis  <buis@kde.org>
1079
1080         Reviewed by eseidel.
1081
1082         http://bugs.webkit.org/show_bug.cgi?id=11015
1083         SVG handles em units incorrectly
1084
1085         Calculate viewport coordinates at layout time, since
1086         at this point the font size is known and lengths depending
1087         on font sizes can be calculated correctly.
1088
1089         * kcanvas/RenderSVGContainer.cpp:
1090         (WebCore::RenderSVGContainer::layout):
1091         (WebCore::RenderSVGContainer::viewport):
1092         (WebCore::RenderSVGContainer::calcViewport):
1093         * kcanvas/RenderSVGContainer.h:
1094         * ksvg2/svg/SVGLength.cpp:
1095         (WebCore::SVGLength::updateValue):
1096         * ksvg2/svg/SVGMarkerElement.cpp:
1097         (WebCore::SVGMarkerElement::createRenderer):
1098         * ksvg2/svg/SVGSVGElement.cpp:
1099         (WebCore::SVGSVGElement::createRenderer):
1100         (WebCore::SVGSVGElement::attributeChanged):
1101         * ksvg2/svg/SVGSVGElement.h:
1102
1103 2006-09-27  Eric Seidel  <eric@eseidel.com>
1104
1105         Reviewed by darin.
1106
1107         Change our invalid-fill error behavior to match Opera (and soon Firefox)
1108         http://bugs.webkit.org/show_bug.cgi?id=11017
1109
1110         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1111         (WebCore::KSVGPainterFactory::isFilled):
1112         (WebCore::KSVGPainterFactory::fillPaintServer):
1113         (WebCore::KSVGPainterFactory::isStroked):
1114         (WebCore::KSVGPainterFactory::strokePaintServer):
1115
1116 2006-09-27  Brady Eidson  <beidson@apple.com>
1117
1118         Build fix
1119
1120         * loader/icon/IconDatabase.cpp:
1121         (WebCore::readySQLStatement):
1122
1123 2006-09-27  Brady Eidson  <beidson@apple.com>
1124
1125         Reviewed by Adam
1126
1127         In very specific circumstances, prepared SQLStatements can become invalid without
1128         any warning.  This checks for that state and re-prepares the statement and also
1129         adds more aggressive error-checking everywhere these statements are used.
1130
1131         * loader/icon/IconDatabase.cpp:
1132         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
1133         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
1134         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
1135         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
1136         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
1137         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
1138         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
1139         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
1140         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
1141         * loader/icon/SQLStatement.cpp:
1142         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
1143         * loader/icon/SQLStatement.h:
1144
1145 2006-09-26  Darin Adler  <darin@apple.com>
1146
1147         Reviewed by Steve.
1148
1149         - clean up options for font code path
1150
1151         * platform/Font.h:
1152         * platform/Font.cpp:
1153         (WebCore::Font::setCodePath): Added. Replaces boolean version.
1154         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
1155
1156         * platform/mac/WebCoreTextRenderer.mm:
1157         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
1158
1159 2006-09-26  John Sullivan  <sullivan@apple.com>
1160
1161         Reviewed by Darin
1162
1163         * bridge/mac/WebCoreFrameBridge.h:
1164         * bridge/mac/WebCoreFrameBridge.mm:
1165         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
1166         Added limit parameter, passed down to Frame
1167         
1168         * page/Frame.h:
1169         * page/Frame.cpp:
1170         (WebCore::Frame::markAllMatchesForText):
1171         Added limit parameter. Stop the search if it hits limit.
1172
1173 2006-09-26  Sean Gies  <seangies@apple.com>
1174
1175         Reviewed by Brady Eidson.
1176
1177         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
1178
1179 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
1180
1181         Reviewed by john
1182         
1183         <rdar://problem/4747695> 
1184         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
1185         
1186         * editing/DeleteSelectionCommand.cpp:
1187         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
1188         to select special elements that are fully selected after expansion
1189         moves to positions that are visually distinct from the originals.
1190         * editing/InsertListCommand.cpp:
1191         (WebCore::InsertListCommand::doApply): If the content of the list 
1192         item will be moved into another list, put it in a list item.
1193
1194 2006-09-26  Geoffrey Garen <ggaren@apple.com>
1195
1196         Reviewed by Darin.
1197         
1198         Temporary work-around for frame lifetime issue.
1199
1200         * page/Frame.cpp:
1201         (WebCore::Frame::clear):
1202         (WebCore::Frame::disconnectOwnerElement):
1203
1204 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
1205
1206         Reviewed by Tim H.
1207
1208         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
1209         Auto-generate DOMSVGElement for the Objective-C bindings
1210
1211         - Auto-generates DOMSVGElement.
1212
1213         - Make SVGExceptions work like all the other ExceptionCode
1214           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
1215           and SVGExceptionMax.
1216
1217         * DerivedSources.make:
1218         * WebCore.xcodeproj/project.pbxproj:
1219         * bindings/js/kjs_binding.cpp:
1220         (KJS::):
1221         (KJS::setDOMException):
1222         * bindings/objc/DOMInternal.h:
1223         * bindings/objc/DOMInternal.mm:
1224         (raiseDOMException):
1225         * bindings/objc/DOMSVG.h:
1226         * bindings/objc/DOMSVGExecption.h: Added.
1227         * ksvg2/ksvg.h:
1228         * ksvg2/svg/SVGElement.cpp:
1229         (WebCore::SVGElement::setId):
1230         (WebCore::SVGElement::setXmlbase):
1231         * ksvg2/svg/SVGElement.h:
1232         * ksvg2/svg/SVGElement.idl:
1233         * ksvg2/svg/SVGException.h: Added.
1234         (WebCore::):
1235
1236 2006-09-26  Eric Seidel  <eric@eseidel.com>
1237
1238         Reviewed by Tim H.
1239         
1240         viewbox parser does not allow <tab> as a delimiter
1241         http://bugs.webkit.org/show_bug.cgi?id=11014
1242
1243         Test: svg/hixie/viewbox/003.xml
1244
1245         * ksvg2/svg/svgpathparser.cpp:
1246         (WebCore::isWhitespace): new function
1247         (WebCore::skipOptionalSpaces):
1248         (WebCore::skipOptionalSpacesOrComma):
1249
1250 2006-09-26  Eric Seidel  <eric@eseidel.com>
1251
1252         Reviewed by Tim H.
1253
1254         SVGDocument::createElement does not create elements in the SVG namespace
1255         http://bugs.webkit.org/show_bug.cgi?id=10932
1256         
1257         Test: svg/custom/createelement.svg
1258
1259         * ksvg2/svg/SVGDocument.cpp:
1260         (WebCore::SVGDocument::createElement):
1261         * ksvg2/svg/SVGDocument.h:
1262
1263 2006-09-26  Eric Seidel  <eric@eseidel.com>
1264
1265         Reviewed by Tim H.
1266         
1267         RenderPath::nodeAtPoint does not respect stroke width
1268         http://bugs.webkit.org/show_bug.cgi?id=10829
1269
1270         Test: svg/custom/stroke-width-click.svg
1271
1272         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1273         (WebCore::RenderPath::strokeContains):
1274         * kcanvas/device/quartz/QuartzSupport.h:
1275         * kcanvas/device/quartz/QuartzSupport.mm:
1276
1277 2006-09-26  Eric Seidel  <eric@eseidel.com>
1278
1279         Reviewed by mitz.
1280
1281         Bring animation back to life
1282         http://bugs.webkit.org/show_bug.cgi?id=11021
1283         
1284         Register/unregister SVGSVGElements as time containers on insertion/removal.
1285         Replace uses of DeprecatedString with String in SVGAnimationElement
1286         Various whitespace clean-up.
1287
1288         * ksvg2/misc/KSVGTimeScheduler.cpp:
1289         (WebCore::SVGTimer::notifyAll):
1290         * ksvg2/misc/SVGDocumentExtensions.cpp:
1291         (WebCore::SVGDocumentExtensions::startAnimations):
1292         (WebCore::SVGDocumentExtensions::pauseAnimations):
1293         (WebCore::SVGDocumentExtensions::unpauseAnimations):
1294         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1295         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
1296         (WebCore::SVGAnimateTransformElement::parseTransformValue):
1297         * ksvg2/svg/SVGAnimateTransformElement.h:
1298         * ksvg2/svg/SVGAnimationElement.cpp:
1299         (WebCore::SVGAnimationElement::SVGAnimationElement):
1300         (WebCore::SVGAnimationElement::parseMappedAttribute):
1301         (WebCore::SVGAnimationElement::parseClockValue):
1302         (WebCore::SVGAnimationElement::targetAttribute):
1303         (WebCore::SVGAnimationElement::setTargetAttribute):
1304         (WebCore::SVGAnimationElement::attributeName):
1305         * ksvg2/svg/SVGAnimationElement.h:
1306         (WebCore::SVGAnimationElement::rendererIsNeeded):
1307         * ksvg2/svg/SVGSVGElement.cpp:
1308         (WebCore::SVGSVGElement::getScreenCTM):
1309         (WebCore::SVGSVGElement::createRenderer):
1310         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
1311         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
1312         * ksvg2/svg/SVGSVGElement.h:
1313         * ksvg2/svg/SVGSetElement.cpp:
1314         (WebCore::SVGSetElement::handleTimerEvent):
1315         * ksvg2/svg/SVGURIReference.cpp:
1316         (WebCore::SVGURIReference::getTarget):
1317         * ksvg2/svg/SVGURIReference.h:
1318
1319 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
1320
1321         Reviewed by mitzpettel.
1322
1323         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
1324         No-SVG build broken since r16549
1325         
1326         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
1327
1328         * css/cssparser.cpp:
1329         (WebCore::CSSParser::parseValue):
1330         * css/cssstyleselector.cpp:
1331         (WebCore::CSSStyleSelector::applyProperty):
1332         * page/FrameView.cpp:
1333         (WebCore::selectCursor):
1334         * platform/qt/GraphicsContextQt.cpp:
1335
1336 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
1337
1338         Reviewed by Maciej.
1339
1340         http://bugs.webkit.org/show_bug.cgi?id=10820
1341         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
1342         
1343         (Originally written by Eric Seidel).
1344         
1345         * bindings/js/kjs_window.cpp:
1346         (KJS::floatFeature):
1347         * ksvg2/svg/SVGAngle.cpp:
1348         (SVGAngle::setValueAsString):
1349         * ksvg2/svg/SVGAnimationElement.cpp:
1350         (SVGAnimationElement::parseMappedAttribute):
1351         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1352         (SVGComponentTransferFunctionElement::parseMappedAttribute):
1353         * ksvg2/svg/SVGFECompositeElement.cpp:
1354         (WebCore::SVGFECompositeElement::parseMappedAttribute):
1355         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1356         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
1357         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1358         (SVGFEDisplacementMapElement::parseMappedAttribute):
1359         * ksvg2/svg/SVGFELightElement.cpp:
1360         (SVGFELightElement::parseMappedAttribute):
1361         * ksvg2/svg/SVGFEOffsetElement.cpp:
1362         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
1363         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1364         (SVGFESpecularLightingElement::parseMappedAttribute):
1365         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1366         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
1367         * ksvg2/svg/SVGStopElement.cpp:
1368         (SVGStopElement::parseMappedAttribute):
1369         * platform/AtomicString.h:
1370         (WebCore::AtomicString::toDouble):
1371         * platform/PlatformString.h:
1372         * platform/String.cpp:
1373         (WebCore::String::toDouble):
1374         * platform/StringImpl.cpp:
1375         (WebCore::StringImpl::toDouble):
1376         * platform/StringImpl.h:
1377         * rendering/DeprecatedSlider.cpp:
1378         (WebCore::DeprecatedSlider::updateFromElement):
1379         * xml/XPathGrammar.y:
1380
1381 2006-09-25  David Harrison  <harrison@apple.com>
1382
1383         Reviewed by Tim Omernick and Tim Hatcher.
1384
1385         <rdar://problem/4717965> Text Field text parameterized attributes should work
1386         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
1387
1388         * bridge/mac/WebCoreAXObject.mm:
1389         (-[WebCoreAXObject accessibilityAttributeValue:]):
1390         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
1391         
1392         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
1393         Cleaned up. Added text field and text area parameterzed attributes.
1394         
1395         (-[WebCoreAXObject doAXLineForTextMarker:]):
1396         Fixed to be zero-based and to deal with the first position properly.
1397         
1398         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
1399         Minor formatting.
1400         
1401         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
1402         (-[WebCoreAXObject indexForTextMarker:]):
1403         (-[WebCoreAXObject textMarkerRangeForRange:]):
1404         (-[WebCoreAXObject rangeForTextMarkerRange:]):
1405         New utility methods.
1406         
1407         (-[WebCoreAXObject doAXLineForIndex:]):
1408         (-[WebCoreAXObject doAXRangeForLine:]):
1409         (-[WebCoreAXObject doAXStringForRange:]):
1410         (-[WebCoreAXObject doAXRangeForPosition:]):
1411         (-[WebCoreAXObject doAXRangeForIndex:]):
1412         (-[WebCoreAXObject doAXBoundsForRange:]):
1413         (-[WebCoreAXObject doAXAttributedStringForRange:]):
1414         (-[WebCoreAXObject doAXRTFForRange:]):
1415         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
1416         Implement text field and text area parameterized attributes.
1417          
1418         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
1419         Added text field and text area parameterzed attributes.
1420
1421         * rendering/RenderTextControl.h:
1422         Made indexForVisiblePosition() and visiblePositionForIndex() public.
1423
1424 2006-09-25  Adam Roben  <aroben@apple.com>
1425
1426         Reviewed by Brady.
1427
1428         Build fixes.
1429
1430         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
1431         * platform/ResourceLoader.h: Store whether a particular job
1432         has received a response within the ResourceLoader object itself, since
1433         it's possible that we will enter the InternetReadFileExA while loop
1434         twice for the same job.
1435         * platform/ResourceLoaderInternal.h: Add private instance variable to
1436         store whether we've received a response.
1437         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1438         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
1439         directives.
1440         * platform/win/ResourceLoaderWin.cpp: 
1441         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
1442         whether it has received a response instead of assuming it hasn't.
1443         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
1444         (WebCore::ResourceLoader::hasReceivedResponse): Added.
1445         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
1446         setProportion
1447         (ScrollBar::setProportion):
1448
1449 2006-09-25  Brady Eidson  <beidson@apple.com>
1450
1451         Requested by ggaren
1452
1453         Disabled IconDatabase logging by default
1454
1455         * platform/Logging.cpp:
1456         (WebCore::):
1457
1458 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
1459
1460         Build fix
1461
1462         * platform/cf/ResourceLoaderCFNet.cpp:
1463         (WebCore::willCacheResponse):
1464
1465 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
1466
1467         Reviewed by john
1468         
1469         <http://bugs.webkit.org/show_bug.cgi?id=11002>
1470         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
1471         
1472         * editing/IndentOutdentCommand.cpp:
1473         (WebCore::IndentOutdentCommand::indentRegion): Special case
1474         an empty root editable element.
1475
1476 2006-09-25  Brady Eidson  <beidson@apple.com>
1477
1478         Reviewed by Steve
1479
1480         Math error in SystemTimeWin
1481
1482         * platform/win/SystemTimeWin.cpp:
1483         (WebCore::currentTime):
1484
1485 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
1486
1487         Reviewed by Eric.
1488
1489         Whitespace cleanup; rename *job variables to *loader.
1490
1491         * bindings/js/JSXMLHttpRequest.cpp:
1492         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
1493         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
1494         (KJS::JSXMLHttpRequestConstructorImp::construct):
1495         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
1496         (KJS::JSXMLHttpRequest::getValueProperty):
1497         (KJS::JSXMLHttpRequest::put):
1498         (KJS::JSXMLHttpRequest::putValueProperty):
1499         (KJS::JSXMLHttpRequest::mark):
1500         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
1501         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
1502         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
1503         * bindings/js/JSXMLHttpRequest.h:
1504         (KJS::JSXMLHttpRequest::toBoolean):
1505         * xml/xmlhttprequest.cpp:
1506         (WebCore::XMLHttpRequest::XMLHttpRequest):
1507         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
1508         (WebCore::XMLHttpRequest::send):
1509         (WebCore::XMLHttpRequest::abort):
1510         (WebCore::XMLHttpRequest::receivedAllData):
1511         (WebCore::XMLHttpRequest::receivedData):
1512         * xml/xmlhttprequest.h:
1513         (WebCore::):
1514
1515 2006-09-25  Timothy Hatcher  <timothy@apple.com>
1516
1517         Reviewed by Brady.
1518
1519         - Deprecate the rest of the old-style methods that are not generated.
1520         - Add @property syntax to DOMRange.
1521
1522         * WebCore.xcodeproj/project.pbxproj:
1523         * bindings/objc/DOM.mm:
1524         (-[DOMRange setStart:offset:]):
1525         (-[DOMRange setEnd:offset:]):
1526         (-[DOMRange compareBoundaryPoints:sourceRange:]):
1527         (-[DOMRange setStart::]):
1528         (-[DOMRange setEnd::]):
1529         (-[DOMRange compareBoundaryPoints::]):
1530         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1531         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1532         (-[DOMDocument createNodeIterator::::]):
1533         (-[DOMDocument createTreeWalker::::]):
1534         * bindings/objc/DOMCSS.h:
1535         * bindings/objc/DOMCSS.mm:
1536         (-[DOMDocument getComputedStyle:pseudoElement:]):
1537         (-[DOMDocument getComputedStyle::]):
1538         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
1539         * bindings/objc/DOMExtensions.h:
1540         * bindings/objc/DOMHTML.h:
1541         * bindings/objc/DOMRange.h:
1542         * bindings/objc/DOMTraversal.h:
1543
1544 2006-09-25  Eric Seidel  <eric@eseidel.com>
1545
1546         Reviewed by mjs.
1547         
1548         Outermost <svg> element should clip to viewport
1549         http://bugs.webkit.org/show_bug.cgi?id=11007
1550
1551         Test: svg/custom/viewport-clip.svg
1552
1553         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
1554
1555 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
1556
1557         Reviewed by Maciej.
1558
1559         * css/MediaList.cpp:
1560         Remove unused header.
1561         
1562         * dom/Document.cpp:
1563         (WebCore::Document::clear):
1564         Use clear instead of iterating through the list of event listeners, removing each one.
1565         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
1566         
1567         * html/HTMLKeygenElement.cpp:
1568         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
1569         (WebCore::HTMLKeygenElement::appendFormData):
1570         Update due to changes in the SSL key generator.
1571         
1572         * ksvg2/svg/SVGAngle.cpp:
1573         Remove unused header.
1574         
1575         * ksvg2/svg/SVGAnimationElement.cpp:
1576         (SVGAnimationElement::parseMappedAttribute):
1577         Rename methods and pass Strings instead of DeprecatedStrings to
1578         parseSeparatedList.
1579         
1580         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1581         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1582         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1583         * ksvg2/svg/SVGFEMergeElement.cpp:
1584         * ksvg2/svg/SVGFEOffsetElement.cpp:
1585         Remove unused headers.
1586         
1587         * ksvg2/svg/SVGHelper.cpp:
1588         (WebCore::SVGHelper::parseSeparatedList):
1589         * ksvg2/svg/SVGHelper.h:
1590         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a 
1591         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
1592         
1593         * ksvg2/svg/SVGLengthList.cpp:
1594         (WebCore::SVGLengthList::parse):
1595         * ksvg2/svg/SVGLengthList.h:
1596         Use Vector<String> instead of DeprecatedStringList.
1597         
1598         * loader/Cache.cpp:
1599         (WebCore::Cache::requestImage):
1600         (WebCore::Cache::requestStyleSheet):
1601         (WebCore::Cache::requestScript):
1602         (WebCore::Cache::requestXSLStyleSheet):
1603         (WebCore::Cache::requestXBLDocument):
1604         (WebCore::Cache::remove):
1605         (WebCore::Cache::get):
1606         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
1607         
1608         * loader/DocLoader.cpp:
1609         (WebCore::DocLoader::needReload):
1610         * loader/DocLoader.h:
1611         Use a HashSet instead of DeprecatedStringList.
1612         
1613         * page/FrameView.h:
1614         Remove declarations that have no functions.
1615         
1616         * platform/SSLKeyGenerator.h:
1617         * platform/mac/SSLKeyGeneratorMac.mm:
1618         (WebCore::supportedKeySizes):
1619         (WebCore::signedPublicKeyAndChallengeString):
1620         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
1621         DeprecatedString.
1622
1623 2006-09-25  Dave Hyatt  <hyatt@apple.com>
1624
1625         Shunt the RenderTheme world transform adoption between
1626         Cairo and Windows into getWindowsContext and move the method
1627         out of GraphicsContextCairo and into GraphicsContextWin.
1628
1629         * ChangeLog:
1630         * WebCore.vcproj/WebCore/WebCore.vcproj:
1631         * platform/cairo/GraphicsContextCairo.cpp:
1632         * platform/win/GraphicsContextWin.cpp: Added.
1633         (WebCore::GraphicsContext::getWindowsContext):
1634         (WebCore::GraphicsContext::releaseWindowsContext):
1635         * rendering/RenderThemeWin.cpp:
1636         (WebCore::prepareForDrawing):
1637
1638 2006-09-24  Eric Seidel  <eric@eseidel.com>
1639
1640         Reviewed by hyatt.
1641
1642         <svg:a> cannot be styled with a:hover
1643         http://bugs.webkit.org/show_bug.cgi?id=11005
1644         
1645         Test: svg/hixie/cascade/002.xml
1646
1647         * css/cssstyleselector.cpp:
1648         (WebCore::checkPseudoState):
1649
1650 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1651
1652         Reviewed by Tim H.
1653
1654         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
1655         SVG needs Obj-C DOM bindings
1656
1657         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The 
1658           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
1659           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and 
1660           DOMSVGTransformList.
1661
1662         * DerivedSources.make:
1663         * WebCore.xcodeproj/project.pbxproj:
1664         * bindings/objc/DOMInternal.h:
1665         * bindings/objc/DOMSVG.h: Added.
1666         * ksvg2/svg/SVGAngle.idl:
1667         * ksvg2/svg/SVGLength.idl:
1668         * ksvg2/svg/SVGLengthList.idl:
1669         * ksvg2/svg/SVGMatrix.idl:
1670         * ksvg2/svg/SVGPathSeg.idl:
1671         * ksvg2/svg/SVGPathSegList.idl:
1672         * ksvg2/svg/SVGTransform.idl:
1673         * ksvg2/svg/SVGTransformList.idl:
1674
1675 2006-09-24  Rob Buis  <buis@kde.org>
1676
1677         Reviewed by eseidel.
1678
1679         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
1680         WebKit does not handle fallback custom cursors
1681         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
1682         WebKit does not properly handle SVG <cursor> element
1683
1684         Add support for svg cursor images. Also make sure hotspot
1685         settings are handled correctly. Add tests for handling of css3
1686         cursor syntax with hotspots in strict and quirks mode. Finally
1687         implement fallback.
1688
1689         * WebCore.xcodeproj/project.pbxproj:
1690         * css/CSSComputedStyleDeclaration.cpp:
1691         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1692         * css/CSSCursorImageValue.cpp: Added.
1693         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1694         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
1695         * css/CSSCursorImageValue.h: Added.
1696         (WebCore::CSSCursorImageValue::hotspot):
1697         * css/cssparser.cpp:
1698         (WebCore::CSSParser::parseValue):
1699         * css/cssstyleselector.cpp:
1700         (WebCore::CSSStyleSelector::applyProperty):
1701         * ksvg2/svg/SVGCursorElement.cpp:
1702         * manual-tests/css3-cursor-fallback-quirks.html: Added.
1703         * manual-tests/css3-cursor-fallback-strict.html: Added.
1704         * manual-tests/cursorfallback.xml: Added.
1705         * page/FrameView.cpp:
1706         (WebCore::selectCursor):
1707         * platform/Cursor.h:
1708         * platform/mac/CursorMac.mm:
1709         (WebCore::createCustomCursor):
1710         (WebCore::Cursor::Cursor):
1711         * platform/qt/CursorQt.cpp:
1712         (WebCore::Cursor::Cursor):
1713         * rendering/RenderStyle.cpp:
1714         (WebCore::StyleInheritedData::StyleInheritedData):
1715         (WebCore::StyleInheritedData::operator==):
1716         (WebCore::RenderStyle::diff):
1717         (WebCore::RenderStyle::addCursor):
1718         (WebCore::RenderStyle::addSVGCursor):
1719         (WebCore::RenderStyle::setCursorList):
1720         (WebCore::RenderStyle::clearCursorList):
1721         * rendering/RenderStyle.h:
1722         (WebCore::CursorData::CursorData):
1723         (WebCore::CursorList::operator[]):
1724         (WebCore::CursorList::size):
1725         (WebCore::CursorList::append):
1726         (WebCore::RenderStyle::cursors):
1727
1728 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1729
1730         Reviewed by Tim H.
1731
1732         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
1733         Auto-generate the internal methods interfaces for the Objective-C bindings
1734
1735         - Auto-generate the internal method declarations into their own files
1736           named in the form DOMFooBarInternal.h for class DOMFooBar.
1737
1738         - Remove all use of DOM_cast from code.
1739
1740         - Assorted cleanups.
1741
1742         * WebCore.xcodeproj/project.pbxproj:
1743         * bindings/objc/DOM.mm:
1744         (-[DOMNode _initWithNode:WebCore::]):
1745         (-[DOMNode WebCore::]):
1746         (-[DOMRange dealloc]):
1747         (-[DOMRange finalize]):
1748         (-[DOMRange _initWithRange:WebCore::]):
1749         (-[DOMRange WebCore::]):
1750         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1751         (-[DOMNodeFilter WebCore::]):
1752         (-[DOMNodeFilter dealloc]):
1753         (-[DOMNodeFilter finalize]):
1754         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
1755         (-[DOMNodeIterator WebCore::]):
1756         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
1757         (-[DOMTreeWalker WebCore::]):
1758         * bindings/objc/DOMAbstractView.mm:
1759         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
1760         * bindings/objc/DOMCSS.mm:
1761         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1762         (-[DOMCSSRule _initWithRule:WebCore::]):
1763         (-[DOMCSSValue _initWithValue:WebCore::]):
1764         * bindings/objc/DOMEvents.mm:
1765         (-[DOMEvent _initWithEvent:WebCore::]):
1766         * bindings/objc/DOMHTMLAppletElement.mm:
1767         (-[DOMHTMLAppletElement align]):
1768         (-[DOMHTMLAppletElement setAlign:]):
1769         (-[DOMHTMLAppletElement alt]):
1770         (-[DOMHTMLAppletElement setAlt:]):
1771         (-[DOMHTMLAppletElement archive]):
1772         (-[DOMHTMLAppletElement setArchive:]):
1773         (-[DOMHTMLAppletElement code]):
1774         (-[DOMHTMLAppletElement setCode:]):
1775         (-[DOMHTMLAppletElement codeBase]):
1776         (-[DOMHTMLAppletElement setCodeBase:]):
1777         (-[DOMHTMLAppletElement height]):
1778         (-[DOMHTMLAppletElement setHeight:]):
1779         (-[DOMHTMLAppletElement hspace]):
1780         (-[DOMHTMLAppletElement setHspace:]):
1781         (-[DOMHTMLAppletElement name]):
1782         (-[DOMHTMLAppletElement setName:]):
1783         (-[DOMHTMLAppletElement object]):
1784         (-[DOMHTMLAppletElement setObject:]):
1785         (-[DOMHTMLAppletElement vspace]):
1786         (-[DOMHTMLAppletElement setVspace:]):
1787         (-[DOMHTMLAppletElement width]):
1788         (-[DOMHTMLAppletElement setWidth:]):
1789         * bindings/objc/DOMInternal.h:
1790         (getDOMWrapper):
1791         (addDOMWrapper):
1792         (raiseOnDOMError):
1793         * bindings/objc/DOMXPath.mm:
1794         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
1795         * bindings/scripts/CodeGeneratorObjC.pm:
1796
1797 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1798
1799         Reviewed by eseidel.
1800
1801         Fix Qt/Linux build after Dave's Scrollbar changes.
1802
1803         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
1804         * platform/qt/TemporaryLinkStubs.cpp:
1805         (WebCore::ScrollBar::setProportion):
1806         (WebCore::PlatformScrollBar::updateThumbPosition):
1807         (WebCore::PlatformScrollBar::updateThumbProportion):
1808
1809 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1810
1811         Reviewed by eseidel.
1812
1813         Qt/Linux build system changes: enable xpath/xslt by default.
1814         Offer possibility to change all of these using 'ccmake'.
1815
1816         * CMakeLists.txt:
1817
1818 2006-09-24  Dave Hyatt  <hyatt@apple.com>
1819
1820         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
1821         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
1822         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
1823
1824         * platform/ScrollBar.cpp:
1825         (WebCore::ScrollBar::setValue):
1826         (WebCore::ScrollBar::setProportion):
1827         * platform/ScrollBar.h:
1828         (WebCore::ScrollBar::value):
1829         * platform/mac/PlatformScrollBar.h:
1830         * platform/mac/PlatformScrollBarMac.mm:
1831         (WebCore::PlatformScrollBar::updateThumbPosition):
1832         (WebCore::PlatformScrollBar::updateThumbProportion):
1833         * platform/win/PlatformScrollBar.h:
1834         * platform/win/TemporaryLinkStubs.cpp:
1835         (PlatformScrollBar::updateThumbPosition):
1836         (PlatformScrollBar::updateThumbProportion):
1837         * rendering/RenderLayer.cpp:
1838         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
1839
1840 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
1841
1842         Reviewed by Eric.
1843
1844         http://bugs.webkit.org/show_bug.cgi?id=4872
1845         XMLHttpRequest fails to throw an exception when there is a security violation
1846         (mismatching domains)
1847
1848         Raise an exception if there is a security violation, and also in cases required by
1849         the current draft of XHR specification.
1850
1851         * bindings/js/JSXMLHttpRequest.cpp:
1852         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
1853         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
1854         reports one, and also if there were too few arguments passed. 
1855
1856         * bindings/js/kjs_binding.cpp:
1857         (KJS::setDOMException): Added support for custom XHR exceptions.
1858
1859         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
1860         exception code range for XHR exceptions.
1861
1862         * xml/xmlhttprequest.cpp:
1863         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
1864         (WebCore::XMLHttpRequest::send):
1865         (WebCore::XMLHttpRequest::setRequestHeader):
1866         (WebCore::XMLHttpRequest::getStatus):
1867         (WebCore::XMLHttpRequest::getStatusText):
1868         (WebCore::XMLHttpRequest::processSyncLoadResults):
1869         (WebCore::XMLHttpRequest::receivedAllData):
1870         (WebCore::XMLHttpRequest::receivedData):
1871
1872 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
1873
1874         Reviewed by Jeff Jenkins.
1875
1876         Tweak CF types.
1877
1878         * platform/cf/ResourceLoaderCFNet.cpp:
1879         (WebCore::willCacheResponse):
1880
1881 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
1882
1883         Reviewed by darin
1884
1885         <http://bugs.webkit.org/show_bug.cgi?id=8029>
1886         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
1887
1888         * dom/Document.cpp:
1889         (WebCore::Document::clearSelectionIfNeeded):
1890         * dom/Element.cpp:
1891         (WebCore::Element::contains):
1892         * dom/Node.cpp:
1893         (WebCore::Node::traverseNextNode):
1894         (WebCore::Node::traverseNextSibling):
1895         (WebCore::Node::traversePreviousNodePostOrder):
1896         (WebCore::Node::checkAddChild):
1897         (WebCore::Node::isDescendantOf):
1898         * dom/Node.h:
1899         * dom/NodeIterator.cpp:
1900         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
1901         * editing/ApplyStyleCommand.cpp:
1902         (WebCore::ApplyStyleCommand::applyBlockStyle):
1903         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
1904         (WebCore::ApplyStyleCommand::applyInlineStyle):
1905         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
1906         * editing/CompositeEditCommand.cpp:
1907         (WebCore::CompositeEditCommand::mergeIdenticalElements):
1908         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
1909         * editing/DeleteSelectionCommand.cpp:
1910         (WebCore::updatePositionForNodeRemoval):
1911         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
1912         (WebCore::DeleteSelectionCommand::mergeParagraphs):
1913         * editing/FormatBlockCommand.cpp:
1914         (WebCore::FormatBlockCommand::doApply):
1915         * editing/IndentOutdentCommand.cpp:
1916         (WebCore::enclosingListOrBlockquote):
1917         * editing/Selection.cpp:
1918         (WebCore::Selection::validate):
1919         * editing/SelectionController.cpp:
1920         (WebCore::SelectionController::nodeWillBeRemoved):
1921         * editing/TextIterator.cpp:
1922         (WebCore::SimplifiedBackwardsTextIterator::advance):
1923         * editing/VisiblePosition.cpp:
1924         (WebCore::VisiblePosition::next):
1925         (WebCore::VisiblePosition::previous):
1926         (WebCore::VisiblePosition::canonicalPosition):
1927         (WebCore::isFirstVisiblePositionInNode):
1928         (WebCore::isLastVisiblePositionInNode):
1929         * editing/htmlediting.cpp:
1930         (WebCore::firstEditablePositionAfterPositionInRoot):
1931         (WebCore::lastEditablePositionBeforePositionInRoot):
1932         (WebCore::enclosingNodeWithTag):
1933         (WebCore::enclosingList):
1934         (WebCore::enclosingListChild):
1935         * editing/markup.cpp:
1936         (WebCore::createMarkup):
1937
1938 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1939
1940         Reviewed by Darin.
1941
1942         - Added @property syntax to non-generated headers
1943           inside #ifndef BUILDING_ON_TIGER.
1944         - Changed the DOMEventTarget protocol to have have new versions
1945           of addEventListener and removeEventListener with named parameters.
1946           These old style methods can be removed once Mail changes to use
1947           the new methods <rdar://problem/4746649>.
1948
1949         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
1950         * bindings/objc/DOM.mm:
1951         (-[DOMNode addEventListener:listener:useCapture:]):
1952         (-[DOMNode addEventListener:::]): call the new method
1953         (-[DOMNode removeEventListener:listener:useCapture:]):
1954         (-[DOMNode removeEventListener:::]): call the new method
1955         * bindings/objc/DOMAbstractView.h:
1956         * bindings/objc/DOMEventTarget.h:
1957         * bindings/objc/DOMHTMLAppletElement.h:
1958         * bindings/objc/DOMHTMLEmbedElement.h:
1959         * bindings/objc/DOMHTMLOptionElement.h:
1960         * bindings/objc/DOMObject.h:
1961         * bindings/objc/DOMRGBColor.h:
1962
1963 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
1964
1965         Reviewed by Eric.
1966
1967         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
1968
1969         * platform/qt/FrameQt.cpp:
1970         * platform/qt/GraphicsContextQt.cpp:
1971         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
1972         (WebCore::GraphicsContext::origin):
1973         * platform/qt/PlatformScrollBar.h: Added.
1974         (WebCore::PlatformScrollBar::isWidget):
1975         * platform/qt/WidgetQt.cpp:
1976         (WebCore::Widget::invalidate):
1977         (WebCore::Widget::invalidateRect):
1978
1979 2006-09-22  Dave Hyatt <hyatt@apple.com>
1980
1981         Super-minor tweaks to the systemFont function on Mac.
1982         Set the generic family to None rather than to Serif, and
1983         don't waste time setting the computed size, since that is
1984         set from the specified size over in CSSStyleSelector anyway.
1985
1986         * rendering/RenderThemeMac.mm:
1987         (WebCore::RenderThemeMac::systemFont):
1988
1989 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1990
1991         Reviewed by Brady.
1992
1993         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
1994         take floats. There was already an implicit conversion to float/double
1995         when calling CGContextTranslateCTM or cairo_translate.
1996
1997         * platform/GraphicsContext.h:
1998         * platform/cairo/GraphicsContextCairo.cpp:
1999         (WebCore::GraphicsContext::translate):
2000         * platform/cg/GraphicsContextCG.cpp:
2001         (WebCore::GraphicsContext::translate):
2002
2003 2006-09-22  Brady Eidson  <beidson@apple.com>
2004
2005         Reviewed by Sfalken
2006
2007         Add redirect and other cleanup to ResourceLoaderWin.cpp
2008         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10927
2009         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10744
2010
2011         * WebCore.xcodeproj/project.pbxproj:
2012         * platform/ResourceLoader.h:
2013         * platform/win/ResourceLoaderWin.cpp:
2014         (WebCore::ResourceLoaderWndProc):
2015         (WebCore::initializeOffScreenResourceLoaderWindow):
2016         (WebCore::ResourceLoader::onHandleCreated):
2017         (WebCore::ResourceLoader::onRequestRedirected):
2018         (WebCore::ResourceLoader::onRequestComplete):
2019         (WebCore::transferJobStatusCallback):
2020
2021 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
2022
2023         Reviewed by Geoff.
2024
2025         http://bugs.webkit.org/show_bug.cgi?id=10803
2026         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
2027
2028         * page/FrameView.cpp:
2029         (WebCore::FrameView::hoverTimerFired): Use the current event.
2030
2031 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
2032
2033         Reviewed by Anders.
2034
2035         Fix (last) svg memory leak.
2036
2037         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
2038         (SVGTransformable::parseTransformAttribute):
2039
2040 2006-09-22  Eric Seidel  <eric@eseidel.com>
2041
2042         No review necessary, just removing a dead file.
2043
2044         Remove unused file (added previously by mistake) to make room for real implementation.
2045
2046         * platform/mac/BitmapImageMac.mm: Removed.
2047
2048 2006-09-22  Dave Hyatt <hyatt@apple.com>
2049
2050         Move PlatformScrollBar.h down into the platforms.
2051         
2052         Reviewed by andersca
2053
2054         * platform/PlatformScrollBar.h: Removed.
2055         * platform/win/PlatformScrollBar.h: Added.
2056         * platform/mac/PlatformScrollBar.h: Added.
2057
2058 2006-09-22   Dave Hyatt  <hyatt@apple.com>
2059
2060         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
2061         any widget subsystems that don't have any underlying native objects backing the widgets.
2062
2063         Reviewed by anders
2064
2065         * platform/Widget.h:
2066         * platform/mac/WidgetMac.mm:
2067         (WebCore::Widget::invalidate):
2068         (WebCore::Widget::invalidateRect):
2069         * platform/win/TemporaryLinkStubs.cpp:
2070         (Widget::invalidate):
2071         (Widget::invalidateRect):
2072
2073 2006-09-22  Rob Buis  <buis@kd.org>
2074
2075         Reviewed by eseidel.
2076
2077         http://bugs.webkit.org/show_bug.cgi?id=10901
2078         Merge build fixes from unity
2079
2080         * CMakeLists.txt:
2081
2082 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2083
2084         Reviewed by eseidel.
2085
2086         http://bugs.webkit.org/show_bug.cgi?id=10977
2087         SVGDocument does not expose 'rootElement' property
2088
2089         Enable 'rootElement' property.
2090
2091         * ksvg2/svg/SVGDocument.idl:
2092
2093 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
2094
2095         Tweak includes.
2096
2097         * platform/ResourceLoaderInternal.h:
2098
2099 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2100
2101         build fixed. band happy.
2102         
2103         * platform/cg/GraphicsContextCG.cpp:
2104         (WebCore::GraphicsContext::translate):
2105         * platform/mac/WidgetMac.mm:
2106
2107 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2108
2109         Reviewed by Maciej.
2110         
2111         Some Widget refactoring.
2112
2113         * WebCore.vcproj/WebCore/WebCore.vcproj:
2114         * bridge/mac/FrameMac.mm:
2115         * bridge/win/FrameWin.cpp:
2116         (WebCore::FrameWin::runJavaScriptAlert):
2117         (WebCore::FrameWin::runJavaScriptConfirm):
2118         * bridge/win/PageWin.cpp:
2119         (WebCore::Page::Page):
2120         (WebCore::rootWindowForFrame):
2121         * html/CanvasRenderingContext2D.cpp:
2122         (WebCore::CanvasRenderingContext2D::translate):
2123         * page/FrameView.cpp:
2124         (WebCore::FrameView::isFrameView):
2125         * page/Page.h:
2126         (WebCore::Page::setInstanceHandle):
2127         (WebCore::Page::instanceHandle):
2128         * platform/GraphicsContext.h:
2129         * platform/ScrollView.h:
2130         * platform/Widget.h:
2131         * platform/cairo/GraphicsContextCairo.cpp:
2132         (WebCore::GraphicsContext::translate):
2133         (WebCore::GraphicsContext::origin):
2134         * platform/mac/WidgetMac.mm:
2135         (WebCore::Widget::clearFocus):
2136         * platform/win/ResourceLoaderWin.cpp:
2137         (WebCore::initializeOffScreenResourceLoaderWindow):
2138         * platform/win/ScreenWin.cpp:
2139         (WebCore::monitorInfo):
2140         * platform/win/ScrollViewWin.cpp:
2141         (WebCore::ScrollView::updateContents):
2142         (WebCore::ScrollView::visibleWidth):
2143         (WebCore::ScrollView::visibleHeight):
2144         (WebCore::ScrollView::visibleContentRect):
2145         (WebCore::ScrollView::viewportToContents):
2146         (WebCore::ScrollView::contentsToViewport):
2147         (WebCore::ScrollView::scrollBy):
2148         (WebCore::ScrollView::updateScrollInfo):
2149         (WebCore::ScrollView::updateScrollBars):
2150         * platform/win/SharedTimerWin.cpp:
2151         (WebCore::initializeOffScreenTimerWindow):
2152         * platform/win/TemporaryLinkStubs.cpp:
2153         (FrameView::updateBorder):
2154         (ScrollView::paint):
2155         (GraphicsContext::clip):
2156         * platform/win/WidgetWin.cpp:
2157         (WebCore::Widget::Widget):
2158         (WebCore::Widget::parentWindow):
2159         (WebCore::Widget::setParentWindow):
2160         (WebCore::Widget::frameGeometry):
2161         (WebCore::Widget::hasFocus):
2162         (WebCore::Widget::setFocus):
2163         (WebCore::Widget::show):
2164         (WebCore::Widget::hide):
2165         (WebCore::Widget::setFrameGeometry):
2166
2167 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
2168
2169         Reviewed by Tim H.
2170
2171         * platform/TextEncoding.cpp:
2172         (WebCore::TextEncoding::backslashAsCurrencySymbol):
2173         Add comment clarifying why backslashAsCurrencySymbol is needed.
2174
2175 2006-09-21  Sean Gies  <seangies@apple.com>
2176
2177         Reviewed by Adam Roben.
2178
2179         Add utility functions to get and release HDC from GraphicsContext.
2180
2181         * platform/GraphicsContext.h: Add utilities to get and release HDC.
2182         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
2183         * rendering/RenderThemeWin.cpp: Switch to new utilities.
2184
2185 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
2186
2187         Reviewed by anders
2188         
2189         <rdar://problem/4426622>
2190         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
2191
2192         * editing/htmlediting.cpp:
2193         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
2194         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
2195         Got rid of uses of DepricatedString.
2196
2197 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2198
2199         Reviewed by eseidel.
2200
2201         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
2202
2203         * page/Frame.cpp:
2204         (WebCore::Frame::endIfNotLoading):
2205
2206 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2207
2208         Reviewed by eseidel.
2209
2210         Fix Qt/Linux build.
2211
2212         * CMakeLists.txt:
2213         * kcanvas/device/qt/KCanvasClipperQt.h:
2214         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
2215         * platform/qt/FrameQt.cpp:
2216         (WebCore::FrameQt::isLoadTypeReload):
2217         (WebCore::FrameQt::originalRequestURL):
2218         * platform/qt/FrameQt.h:
2219         * platform/qt/GraphicsContextQt.cpp:
2220         (WebCore::GraphicsContext::concatCTM):
2221         * platform/qt/ScrollViewQt.cpp:
2222         (WebCore::ScrollView::wheelEvent):
2223         * platform/qt/TemporaryLinkStubs.cpp:
2224         (WebCore::IconDatabase::setIconURLForPageURL):
2225
2226 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2227
2228         Reviewed by john
2229         
2230         <http://bugs.webkit.org/show_bug.cgi?id=7165>
2231         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
2232
2233         * editing/MoveSelectionCommand.cpp:
2234         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
2235         to the position-to-move-to's document, not the fragment's document.  The 
2236         fragment's document is the document used to create the fragment and is irrelavant.
2237
2238 === Safari-521.27 ===
2239
2240 2006-09-21  Brady Eidson  <beidson@apple.com>
2241
2242         Reviewed by Anders
2243
2244         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
2245         This fixes Spinneret so it won't crash on its first load!
2246
2247         * page/Frame.cpp:
2248         (WebCore::Frame::endIfNotLoading):
2249
2250 2006-09-21  Brady Eidson  <beidson@apple.com>
2251
2252         Build fix
2253
2254         * platform/win/TemporaryLinkStubs.cpp:
2255         (ScrollView::wheelEvent):
2256
2257 2006-09-20  Rob Buis  <buis@kde.org>
2258
2259         Reviewed by eseidel.
2260
2261         http://bugs.webkit.org/show_bug.cgi?id=10946
2262         new marker code draws end-marker in wrong place
2263
2264         Keep track of the start of the subpath so we can handle
2265         closeTo/moveTo correctly.
2266
2267         * kcanvas/RenderPath.cpp:
2268         (WebCore::DrawMarkersData::DrawMarkersData):
2269         (WebCore::updateMarkerDataForElement):
2270
2271 2006-09-21  David Hyatt <hyatt@apple.com>
2272
2273         Wheel scrolling prep for Win32.
2274
2275         WARNING: NO TEST CASES ADDED OR CHANGED
2276
2277         * platform/PlatformWheelEvent.h:
2278         * platform/ScrollBar.h:
2279         * platform/ScrollView.h:
2280         * platform/mac/ScrollViewMac.mm:
2281         (WebCore::ScrollView::wheelEvent):
2282         * rendering/RenderLayer.cpp:
2283
2284 2006-09-20  Timothy Hatcher  <timothy@apple.com>
2285
2286         Reviewed by Hyatt.
2287
2288         Bug 10917: REGRESSION (r16027): iFrame transparency broken
2289         http://bugs.webkit.org/show_bug.cgi?id=10917
2290
2291         Don't paint the base background color if we transparent.
2292
2293         * rendering/RenderBox.cpp:
2294         (WebCore::RenderBox::paintBackgroundExtended):
2295
2296 2006-09-20  Adam Roben  <aroben@apple.com>
2297
2298         Reviewed by andersca.
2299
2300         * platform/FileChooser.h: Remove no-longer-necessary namespace std
2301
2302 2006-09-20  Eric Seidel  <eric@eseidel.com>
2303
2304         Reviewed by beth.
2305
2306         Cleanup style in KCanvas.
2307         Remove extra white-space, unneeded arguments, etc.
2308
2309         * WebCore.xcodeproj/project.pbxproj:
2310         * kcanvas/KCanvasClipper.cpp:
2311         (WebCore::operator<<):
2312         (WebCore::KCanvasClipper::externalRepresentation):
2313         * kcanvas/KCanvasClipper.h:
2314         * kcanvas/KCanvasFilters.cpp:
2315         (WebCore::KCanvasFilter::externalRepresentation):
2316         (WebCore::operator<<):
2317         (WebCore::KCanvasFilterEffect::externalRepresentation):
2318         (WebCore::KCPointLightSource::externalRepresentation):
2319         (WebCore::KCSpotLightSource::externalRepresentation):
2320         (WebCore::KCDistantLightSource::externalRepresentation):
2321         (WebCore::KCanvasFEBlend::externalRepresentation):
2322         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
2323         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
2324         (WebCore::KCanvasFEComposite::externalRepresentation):
2325         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
2326         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
2327         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
2328         (WebCore::KCanvasFEFlood::externalRepresentation):
2329         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
2330         (WebCore::KCanvasFEImage::externalRepresentation):
2331         (WebCore::KCanvasFEMerge::externalRepresentation):
2332         (WebCore::KCanvasFEMorphology::externalRepresentation):
2333         (WebCore::KCanvasFEOffset::externalRepresentation):
2334         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
2335         (WebCore::KCanvasFETile::externalRepresentation):
2336         (WebCore::KCanvasFETurbulence::externalRepresentation):
2337         * kcanvas/KCanvasFilters.h:
2338         (WebCore::KCanvasFEDiffuseLighting::lightSource):
2339         (WebCore::KCanvasFESpecularLighting::lightSource):
2340         * kcanvas/KCanvasImage.h:
2341         * kcanvas/KCanvasMarker.cpp:
2342         (WebCore::KCanvasMarker::externalRepresentation):
2343         * kcanvas/KCanvasMarker.h:
2344         * kcanvas/KCanvasResource.cpp:
2345         (WebCore::operator<<):
2346         * kcanvas/KCanvasResource.h:
2347         * kcanvas/KCanvasTreeDebug.cpp:
2348         (WebCore::operator<<):
2349         (WebCore::writeIndent):
2350         (WebCore::writeStyle):
2351         (WebCore::write):
2352         (WebCore::writeRenderResources):
2353         * kcanvas/KCanvasTreeDebug.h:
2354         (WebCore::operator<<):
2355         * kcanvas/RenderForeignObject.cpp:
2356         (WebCore::RenderForeignObject::paint):
2357         * kcanvas/RenderPath.cpp:
2358         (WebCore::RenderPath::paint):
2359         (WebCore::drawStartAndMidMarkers):
2360         * kcanvas/RenderSVGContainer.cpp:
2361         (WebCore::RenderSVGContainer::paint):
2362         * kcanvas/RenderSVGImage.cpp:
2363         (WebCore::RenderSVGImage::translateForAttributes):
2364         * kcanvas/RenderSVGImage.h:
2365         * kcanvas/device/KRenderingDevice.cpp:
2366         (WebCore::KRenderingDevice::currentContext):
2367         (WebCore::KRenderingDevice::popContext):
2368         (WebCore::KRenderingDevice::pushContext):
2369         * kcanvas/device/KRenderingDevice.h:
2370         * kcanvas/device/KRenderingFillPainter.h:
2371         * kcanvas/device/KRenderingPaintServer.h:
2372         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
2373         (WebCore::KRenderingPaintServer::activeClient):
2374         (WebCore::KRenderingPaintServer::setActiveClient):
2375         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2376         (WebCore::operator<<):
2377         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
2378         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
2379         (WebCore::KRenderingPaintServerGradient::listener):
2380         (WebCore::KRenderingPaintServerGradient::setListener):
2381         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
2382         * kcanvas/device/KRenderingPaintServerGradient.h:
2383         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2384         (WebCore::KRenderingPaintServerPattern::tile):
2385         (WebCore::KRenderingPaintServerPattern::setTile):
2386         (WebCore::KRenderingPaintServerPattern::listener):
2387         (WebCore::KRenderingPaintServerPattern::setListener):
2388         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
2389         * kcanvas/device/KRenderingPaintServerPattern.h:
2390         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2391         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
2392         * kcanvas/device/KRenderingPaintServerSolid.h:
2393         * kcanvas/device/KRenderingStrokePainter.cpp:
2394         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2395         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2396         * kcanvas/device/KRenderingStrokePainter.h:
2397         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
2398         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2399         (WebCore::KCanvasFilterQuartz::prepareFilter):
2400         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
2401         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
2402         (WebCore::KCanvasMaskerQuartz::applyMask):
2403         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2404         (WebCore::KCanvasImageQuartz::init):
2405         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
2406         (WebCore::KCanvasClipperQuartz::applyClip):
2407         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2408         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2409         (WebCore::KRenderingDeviceQuartz::quartzContext):
2410         (WebCore::KRenderingDeviceQuartz::contextForImage):
2411         (WebCore::KRenderingDeviceQuartz::createPaintServer):
2412         (WebCore::KRenderingDeviceQuartz::createResource):
2413         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
2414         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2415         (WebCore::CGShadingRefForLinearGradient):
2416         (WebCore::CGShadingRefForRadialGradient):
2417         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
2418         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
2419         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
2420         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2421         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
2422         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
2423         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
2424         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
2425         (WebCore::KRenderingPaintServerSolidQuartz::draw):
2426         (WebCore::KRenderingPaintServerSolidQuartz::setup):
2427         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
2428         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2429         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
2430         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
2431         * kcanvas/device/quartz/QuartzSupport.h:
2432         * kcanvas/device/quartz/QuartzSupport.mm:
2433         (WebCore::applyStrokeStyleToContext):
2434
2435 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2436
2437         Reviewed by Dave Hyatt.
2438
2439         * dom/WheelEvent.cpp:
2440         (WebCore::WheelEvent::WheelEvent):
2441         Use lroundf instead of lround since deltas are floats.
2442
2443 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
2444
2445         Reviewed by eseidel.  Landed by eseidel.
2446
2447         Test: svg/custom/pattern-y-offset.svg
2448
2449         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2450         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2451
2452 2006-09-20  David Hyatt  <hyatt@apple.com>
2453
2454         Add a new wheelEvent method to ScrollView.  Platforms that wish
2455         to handle the wheel event for the scroll view themselves can then
2456         do so there.  (Mac lets the underlying NSScrollView do it for now.)
2457
2458         * page/FrameView.cpp:
2459         (WebCore::FrameView::handleWheelEvent):
2460         * platform/ScrollView.h:
2461         (WebCore::ScrollView::wheelEvent):
2462
2463 2006-09-20  Brady Eidson  <beidson@apple.com>
2464
2465         Reviewed by Tim Omernick
2466
2467         Part of fixing a crash Tim O showed me that I missed in a release build.
2468         WebKit should be able to call through the bridge to WebCore no matter what -
2469         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
2470
2471         * bridge/mac/WebCoreIconDatabaseBridge.h:
2472         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2473         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
2474         (-[WebCoreIconDatabaseBridge isOpen]):
2475         (-[WebCoreIconDatabaseBridge removeAllIcons]):
2476         (-[WebCoreIconDatabaseBridge _isEmpty]):
2477         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
2478         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
2479         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
2480         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
2481         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
2482         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
2483         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
2484         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
2485         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
2486         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
2487         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
2488         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
2489         (-[WebCoreIconDatabaseBridge _setEnabled:]):
2490         (-[WebCoreIconDatabaseBridge _isEnabled]):
2491
2492 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2493
2494         Reviewed by Darin.
2495
2496         Add String::split which returns a Vector of Strings and use it instead of 
2497         DeprecatedStringList.
2498         
2499         * bindings/js/kjs_events.cpp:
2500         (KJS::Clipboard::getValueProperty):
2501         * bindings/js/kjs_window.cpp:
2502         (KJS::parseModalDialogFeatures):
2503         * css/MediaList.cpp:
2504         (WebCore::MediaList::setMediaText):
2505         * dom/Clipboard.h:
2506         * html/HTMLFormElement.cpp:
2507         (WebCore::HTMLFormElement::formData):
2508         * html/HTMLLinkElement.cpp:
2509         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
2510         * platform/PlatformString.h:
2511         * platform/String.cpp:
2512         (WebCore::String::split):
2513         * platform/StringImpl.cpp:
2514         * platform/StringImpl.h:
2515         * platform/mac/ClipboardMac.h:
2516         * platform/mac/ClipboardMac.mm:
2517         (WebCore::ClipboardMac::types):
2518
2519 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2520
2521         Reviewed by harrison
2522
2523         * css/cssstyleselector.cpp:
2524         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call 
2525         HTMLElement::isContentEditable just to check the Frame's editability, since
2526         it calls updateRenderering, which can get us into infinite recursion.
2527
2528 2006-09-20  Brady Eidson  <beidson@apple.com>
2529
2530         Reviewed by Darin
2531
2532         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
2533
2534         * loader/icon/IconDatabase.cpp:
2535         (WebCore::IconDatabase::IconDatabase): Disabled by default
2536         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
2537         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
2538         (WebCore::IconDatabase::iconForPageURL): Ditto
2539         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
2540         (WebCore::IconDatabase::iconURLForPageURL): Ditto
2541         (WebCore::IconDatabase::retainIconForPageURL): Ditto
2542         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
2543         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
2544         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
2545         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
2546         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
2547
2548 2006-09-20  Adam Roben  <aroben@apple.com>
2549
2550         Reviewed by Adele.
2551
2552         Fixes http://bugs.webkit.org/show_bug.cgi?id=10935
2553         REGRESSION: file upload control with direction:rtl or text-align:right
2554         draws button on top of filename/icon
2555
2556         * rendering/RenderFileUploadControl.cpp:
2557         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
2558         match direction
2559         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
2560         the filename and icon in RTL
2561
2562 2006-09-20  Alice Liu  <alice.liu@apple.com>
2563
2564         Reviewed by Adam Roben.
2565
2566         fixed windows build
2567
2568         * dom/WheelEvent.cpp:
2569         (WebCore::WheelEvent::WheelEvent):
2570         changed lrint to lround
2571
2572 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
2573
2574         Build Fix.  Adds isHorizontal attribute back to WheelEvent
2575         for the Objective-C bindings.  If it is found that isHorizontal
2576         is not used, we should remove it again but also remove it's
2577         declaration from PublicDOMInterfaces.h
2578
2579         * dom/WheelEvent.h:
2580         (WebCore::WheelEvent::isHorizontal):
2581         * dom/WheelEvent.idl:
2582
2583 2006-09-20  David Hyatt  <hyatt@apple.com>
2584
2585         Fix for 10945, WheelEvent should support two dimensions at once, since
2586         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
2587         to allow for diagonal scrolling.
2588
2589         Reviewed by Eric
2590
2591         * dom/EventTargetNode.cpp:
2592         (WebCore::EventTargetNode::dispatchWheelEvent):
2593         * dom/WheelEvent.cpp:
2594         (WebCore::WheelEvent::WheelEvent):
2595         (WebCore::WheelEvent::initWheelEvent):
2596         * dom/WheelEvent.h:
2597         (WebCore::WheelEvent::wheelDelta):
2598         (WebCore::WheelEvent::wheelDeltaX):
2599         (WebCore::WheelEvent::wheelDeltaY):
2600         * dom/WheelEvent.idl:
2601         * page/FrameView.cpp:
2602         (WebCore::FrameView::handleWheelEvent):
2603         * platform/PlatformWheelEvent.h:
2604         (WebCore::PlatformWheelEvent::deltaX):
2605         (WebCore::PlatformWheelEvent::deltaY):
2606         (WebCore::PlatformWheelEvent::normalize):
2607         * platform/mac/WheelEventMac.mm:
2608         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2609
2610 2006-09-19  Eric Seidel  <eric@eseidel.com>
2611
2612         Reviewed by hyatt.
2613
2614         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
2615         
2616         No tests were harmed in the making of this patch.
2617
2618         * WebCore.xcodeproj/project.pbxproj:
2619         * kcanvas/KCanvasClipper.cpp: Added.
2620         (WebCore::operator<<):
2621         * kcanvas/KCanvasClipper.h: Added.
2622         * kcanvas/KCanvasFilters.h:
2623         * kcanvas/KCanvasImage.h:
2624         * kcanvas/KCanvasMarker.cpp: Added.
2625         * kcanvas/KCanvasMarker.h: Added.
2626         * kcanvas/KCanvasMasker.cpp: Added.
2627         (WebCore::KCanvasMasker::KCanvasMasker):
2628         (WebCore::KCanvasMasker::setMask):
2629         (WebCore::KCanvasMasker::externalRepresentation):
2630         (WebCore::getMaskerById):
2631         * kcanvas/KCanvasMasker.h: Added.
2632         * kcanvas/KCanvasResource.cpp: Added.
2633         (WebCore::KCanvasResource::invalidate):
2634         (WebCore::KCanvasResource::externalRepresentation):
2635         (WebCore::getResourceById):
2636         (WebCore::getPaintServerById):
2637         * kcanvas/KCanvasResource.h: Added.
2638         * kcanvas/KCanvasResources.cpp: Removed.
2639         * kcanvas/KCanvasResources.h: Removed.
2640         * kcanvas/RenderPath.cpp:
2641         * kcanvas/RenderSVGContainer.cpp:
2642         * kcanvas/RenderSVGImage.cpp:
2643         * kcanvas/RenderSVGText.cpp:
2644         * kcanvas/device/KRenderingPaintServer.h:
2645         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
2646         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2647         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2648         * ksvg2/svg/SVGClipPathElement.h:
2649         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2650         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2651         * ksvg2/svg/SVGFECompositeElement.cpp:
2652         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2653         * ksvg2/svg/SVGFELightElement.cpp:
2654         * ksvg2/svg/SVGFEOffsetElement.cpp:
2655         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2656         * ksvg2/svg/SVGFilterElement.cpp:
2657         * ksvg2/svg/SVGLinearGradientElement.cpp:
2658         * ksvg2/svg/SVGMarkerElement.h:
2659         * ksvg2/svg/SVGMaskElement.h:
2660
2661 2006-09-19  Brady Eidson <beidson@apple.com>
2662
2663         Reviewed by Sarge Decker
2664
2665         <rdar://problem/4739892> and <rdar://problem/4729797>
2666         - WebCore::IconDatabase needs to have and respect an enabled() flag
2667         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
2668
2669         * bridge/mac/WebCoreIconDatabaseBridge.h:
2670         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2671         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
2672         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
2673         * loader/icon/IconDatabase.cpp:
2674         (WebCore::IconDatabase::IconDatabase):
2675         (WebCore::IconDatabase::open): Don't open if disabled
2676         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
2677         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
2678         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
2679         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
2680         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
2681         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
2682         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
2683         (WebCore::IconDatabase::releaseIconURL):
2684         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
2685         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
2686         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
2687         (WebCore::IconDatabase::setEnabled): Added
2688         * loader/icon/IconDatabase.h:
2689         (WebCore::IconDatabase::enabled): Added
2690         * page/Frame.cpp:
2691         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
2692         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
2693
2694 2006-09-20  David Hyatt  <hyatt@apple.com>
2695
2696         Massage mouse wheel handling so that it is more cross-platform.  Make
2697         all the work happen in handleWheelEvent on the FrameView.
2698
2699         Reviewed by bradee-oh
2700
2701         * bridge/mac/FrameMac.mm:
2702         (WebCore::FrameMac::wheelEvent):
2703         * page/FrameView.cpp:
2704         (WebCore::FrameView::handleWheelEvent):
2705         * platform/PlatformWheelEvent.h:
2706         (WebCore::PlatformWheelEvent::platformDelta):
2707         (WebCore::PlatformWheelEvent::delta):
2708         * platform/mac/WheelEventMac.mm:
2709         (WebCore::platformDeltaForEvent):
2710         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2711         * rendering/RenderLayer.cpp:
2712         (WebCore::RenderLayer::scroll):
2713         * rendering/RenderObject.cpp:
2714         (WebCore::RenderObject::scroll):
2715
2716 2006-09-19  Eric Seidel  <eric@eseidel.com>
2717
2718         Reviewed by adele.
2719
2720         Improve test output for filters with bounding-box relative sizes.
2721         http://bugs.webkit.org/show_bug.cgi?id=8585
2722
2723         Many test results updated.
2724
2725         * kcanvas/KCanvasFilters.cpp:
2726         (WebCore::KCanvasFilter::externalRepresentation):
2727
2728 2006-09-19  Eric Seidel  <eric@eseidel.com>
2729
2730         Reviewed by adele.
2731         
2732         Markers should clip to their viewport.
2733         http://bugs.webkit.org/show_bug.cgi?id=5967
2734
2735         Test: svg/custom/marker-overflow-clip.svg
2736
2737         * kcanvas/KCanvasResources.cpp:
2738         (WebCore::KCanvasMarker::KCanvasMarker):
2739         (WebCore::KCanvasMarker::setMarker):
2740         (WebCore::KCanvasMarker::draw):
2741         * kcanvas/KCanvasResources.h:
2742         (WebCore::KCanvasMasker::mask):
2743         * ksvg2/svg/SVGMarkerElement.cpp:
2744         (WebCore::SVGMarkerElement::SVGMarkerElement):
2745         (WebCore::SVGMarkerElement::parseMappedAttribute):
2746         (WebCore::SVGMarkerElement::canvasResource):
2747         (WebCore::SVGMarkerElement::createRenderer):
2748
2749 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2750
2751         Reviewed by eseidel
2752
2753         Backing out my recent change.
2754
2755         * css/cssstyleselector.cpp:
2756         (WebCore::CSSStyleSelector::adjustRenderStyle): 
2757
2758 2006-09-19  Brady Eidson  <beidson@apple.com>
2759
2760         Reviewed by Kevin McCullough
2761
2762         http://bugs.webkit.org/show_bug.cgi?id=10940
2763         Opening a PDF in a new tab/window creates a documentless-frame
2764         and we deref the document without checking its validity
2765
2766         * page/Frame.cpp:
2767         (WebCore::Frame::iconURL):
2768
2769 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2770
2771         Reviewed by harrison
2772         
2773         <rdar://problem/4735272>
2774         Can not click into link in programmatically editable content
2775
2776         * css/cssstyleselector.cpp:
2777         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
2778         userModify to implement document wide editability.
2779
2780 2006-09-19  MorganL  <morlmor@yahoo.com>
2781
2782         Reviewed by Darin and landed by Brady
2783
2784         Fixes http://bugs.webkit.org/show_bug.cgi?id=10939
2785         Build broken when SVG is not enabled.
2786
2787         * dom/XMLTokenizer.cpp:
2788         (WebCore::XMLTokenizer::startElementNs):
2789
2790 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2791
2792         Reviewed by harrison
2793         
2794         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
2795
2796         Pasting plain text results in a match style paste, and the insertion
2797         position is whitespace normal, which clobbers the whitespace:pre on 
2798         tab spans.  Skip changes to the whitespace mode when computing a style
2799         change for tab spans or the text nodes inside tab spans.
2800
2801         * editing/ApplyStyleCommand.cpp:
2802         (WebCore::StyleChange::init): Don't change the whitespace mode inside
2803         tab spans.
2804
2805 2006-09-19  David Hyatt  <hyatt@apple.com>
2806
2807         Fix for bug 5298, shape=default not supported for image maps.  Implement
2808         support for it.
2809
2810         Reviewed by timo
2811
2812         * html/HTMLAreaElement.cpp:
2813         (WebCore::HTMLAreaElement::getRegion):
2814         * html/HTMLMapElement.cpp:
2815         (WebCore::HTMLMapElement::mapMouseEvent):
2816
2817 2006-09-19  Adam Roben  <aroben@apple.com>
2818
2819         Reviewed by Adele.
2820
2821         Fixes http://bugs.webkit.org/show_bug.cgi?id=10824
2822         "no file selected" placeholder text missing from file upload control
2823
2824         * WebCore.xcodeproj/project.pbxproj:
2825         * rendering/RenderFileUploadControl.cpp: Remove class
2826         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
2827         defaultWidthNumChars
2828         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
2829         RenderBlock constructor instead of RenderFlexibleBox, 
2830         (WebCore::RenderFileUploadControl::setStyle): Remove references to
2831         m_fileBox.
2832         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
2833         instead of updateIconAndFileName() (which has been removed)
2834         (WebCore::RenderFileUploadControl::updateFromElement): Remove
2835         references to m_fileBox, don't call updateIconAndFilename()
2836         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
2837         without using m_fileBox
2838         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
2839         now-unnecessary display:box rule.
2840         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
2841         to paintingDisabled() now that Icon::paint() does it, and add code to
2842         paint the filename directly.
2843         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
2844         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
2845         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
2846         subclass of RenderBlock instead of RenderFlexibleBox, remove
2847         updateIconAndFilename() method, remove m_fileBox instance variable.
2848
2849 2006-09-19  Eric Seidel  <eric@eseidel.com>
2850
2851         Reviewed by hyatt.
2852
2853         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
2854         http://bugs.webkit.org/show_bug.cgi?id=10846
2855         
2856         No automated test case possible until http://bugs.webkit.org/show_bug.cgi?id=10905 is resolved.
2857
2858         * dom/XMLTokenizer.cpp:
2859         (WebCore::XMLTokenizer::XMLTokenizer):
2860         (WebCore::XMLTokenizer::startElementNs):
2861         (WebCore::XMLTokenizer::endElementNs):
2862
2863 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
2864
2865         Reviewed by eseidel.  Landed by eseidel.
2866         
2867         Build fix only, no tests affected.
2868
2869         * platform/gdk/FontPlatformDataGdk.cpp:
2870         (WebCore::FontPlatformData::FontPlatformData):
2871         (WebCore::FontPlatformData::~FontPlatformData):
2872         * platform/gdk/FrameGdk.h:
2873         * platform/gdk/TemporaryLinkStubs.cpp:
2874         (FrameGdk::isLoadTypeReload):
2875         (FrameGdk::originalRequestURL):
2876         (IconDatabase::setIconURLForPageURL):
2877
2878 2006-09-19  David Hyatt  <hyatt@apple.com>
2879
2880         Refine the fix for 9805 to really get all the complex cases right.
2881
2882         Reviewed by Eric
2883
2884         * rendering/RenderBlock.cpp:
2885         (WebCore::RenderBlock::clearFloatsIfNeeded):
2886         (WebCore::RenderBlock::handleBottomOfBlock):
2887
2888 2006-09-18  David Hyatt  <hyatt@apple.com>
2889
2890         Fix for 9805, <hr> not positioned properly following a previous empty sibling
2891         that had clear:both set on it.  Update self-collapsing block clearance
2892         behavior to match what is specified in the latest draft of CSS2.1.
2893
2894         Reviewed by Eric
2895
2896         Added fast/block/margin-collapse/empty-clear-blocks.html
2897
2898         * rendering/RenderBlock.cpp:
2899         (WebCore::RenderBlock::clearFloatsIfNeeded):
2900         (WebCore::RenderBlock::handleBottomOfBlock):
2901
2902 2006-09-18  MorganL  <morlmor@yahoo.com>
2903
2904         Reviewed by Brady, landed by Brady
2905
2906         Send receivedResponse callback to ResourceLoaderClient when loading
2907         file URLs.
2908
2909         See http://bugs.webkit.org/show_bug.cgi?id=10845
2910
2911         * platform/win/ResourceLoaderWin.cpp:
2912         (WebCore::ResourceLoader::fileLoadTimer):
2913
2914 2006-09-18  Brady Eidson  <beidson@apple.com>
2915
2916         Reviewed by Anders
2917
2918         <rdar://problem/3028061> - WebKit never updates favicon
2919         The WebKit enforced expiration date for icons has worked for some time, but the
2920         move to the new Icon Loader broke the "always get the icon if the user refreshes the page" 
2921         functionality.  This patch fixes that up, along with some other architectural improvements,
2922         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
2923
2924         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
2925         * bridge/mac/FrameMac.mm:
2926         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
2927         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
2928         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
2929         * dom/Document.h: Added m_iconURL
2930         (WebCore::Document::iconURL): Added
2931         (WebCore::Document::setIconURL): Ditto
2932         * html/HTMLLinkElement.cpp:
2933         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
2934         * page/Frame.cpp:
2935         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
2936         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
2937         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
2938         * page/FramePrivate.h: Nuked IconURL
2939         * platform/win/TemporaryLinkStubs.cpp:
2940         (FrameWin::isLoadTypeReload):
2941
2942 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2943
2944         Reviewed by Tim H.
2945
2946         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
2947           it is it turns out that AppKit uses it.
2948
2949         * bindings/objc/DOMPrivate.h:
2950         * bindings/objc/DOMRGBColor.mm:
2951         (-[DOMRGBColor _color]):
2952
2953 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2954
2955         Reviewed by Tim H.
2956
2957         Patch for http://bugs.webkit.org/show_bug.cgi?id=10903
2958         Yet Another Objective-C Bindings Patch
2959
2960         - Whitespace cleanup for IDLParser.pm
2961
2962         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
2963           and DOMAbstractView into their own files.
2964
2965         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
2966           it is not used and a public method is available now.
2967
2968         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
2969           as it not used.
2970
2971         - Auto-generate method isContentEditable for DOMNode.
2972
2973         - General cleanup of bindings code including removing unneeded #imports
2974           and whitespace cleanup
2975
2976         * WebCore.xcodeproj/project.pbxproj:
2977         * bindings/objc/DOM.mm:
2978         (addElementClass):
2979         (elementClass):
2980         (-[DOMNode _initWithNode:WebCore::]):
2981         (+[DOMNode _nodeWith:WebCore::]):
2982         (-[DOMNode WebCore::]):
2983         (-[DOMNode KJS::Bindings::]):
2984         (-[DOMNode addEventListener:::]):
2985         (-[DOMNode removeEventListener:::]):
2986         (-[DOMNode dispatchEvent:]):
2987         (-[DOMElement image]):
2988         (-[DOMElement _font]):
2989         (-[DOMElement _imageTIFFRepresentation]):
2990         (-[DOMElement _getURLAttribute:]):
2991         (-[DOMElement _NPObject]):
2992         (-[DOMElement isFocused]):
2993         (-[DOMRange dealloc]):
2994         (-[DOMRange finalize]):
2995         (-[DOMRange description]):
2996         (-[DOMRange startContainer]):
2997         (-[DOMRange startOffset]):
2998         (-[DOMRange endContainer]):
2999         (-[DOMRange endOffset]):
3000         (-[DOMRange collapsed]):
3001         (-[DOMRange commonAncestorContainer]):
3002         (-[DOMRange setStart::]):
3003         (-[DOMRange setEnd::]):
3004         (-[DOMRange setStartBefore:]):
3005         (-[DOMRange setStartAfter:]):
3006         (-[DOMRange setEndBefore:]):
3007         (-[DOMRange setEndAfter:]):
3008         (-[DOMRange collapse:]):
3009         (-[DOMRange selectNode:]):
3010         (-[DOMRange selectNodeContents:]):
3011         (-[DOMRange compareBoundaryPoints::]):
3012         (-[DOMRange deleteContents]):
3013         (-[DOMRange extractContents]):
3014         (-[DOMRange cloneContents]):
3015         (-[DOMRange insertNode:]):
3016         (-[DOMRange surroundContents:]):
3017         (-[DOMRange cloneRange]):
3018         (-[DOMRange toString]):
3019         (-[DOMRange detach]):
3020         (-[DOMRange _initWithRange:WebCore::]):
3021         (+[DOMRange _rangeWith:WebCore::]):
3022         (-[DOMRange WebCore::]):
3023         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
3024         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
3025         (-[DOMNodeFilter WebCore::]):
3026         (-[DOMNodeFilter dealloc]):
3027         (-[DOMNodeFilter finalize]):
3028         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
3029         (-[DOMNodeIterator WebCore::]):
3030         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
3031         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
3032         (-[DOMTreeWalker WebCore::]):
3033         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
3034         (ObjCNodeFilterCondition::acceptNode):
3035         (-[DOMDocument createNodeIterator::::]):
3036         (-[DOMDocument createTreeWalker::::]):
3037         (ObjCEventListener::find):
3038         (ObjCEventListener::create):
3039         (ObjCEventListener::handleEvent):
3040         * bindings/objc/DOMAbstractView.h: Added.
3041         * bindings/objc/DOMAbstractView.mm: Added.
3042         (-[DOMAbstractView document]):
3043         (-[DOMAbstractView WebCore::]):
3044         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
3045         (+[DOMAbstractView _abstractViewWith:WebCore::]):
3046         * bindings/objc/DOMCSS.mm:
3047         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
3048         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
3049         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
3050         (-[DOMCSSRule _initWithRule:WebCore::]):
3051         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
3052         (-[DOMCSSValue _initWithValue:WebCore::]):
3053         (+[DOMCSSValue _CSSValueWith:WebCore::]):
3054         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
3055         (-[DOMDocument getComputedStyle::]):
3056         (-[DOMDocument getMatchedCSSRules::]):
3057         * bindings/objc/DOMCore.h:
3058         * bindings/objc/DOMEventException.h: Added.
3059         * bindings/objc/DOMEvents.h:
3060         * bindings/objc/DOMEvents.mm:
3061         * bindings/objc/DOMException.h: Added.
3062         * bindings/objc/DOMHTML.mm:
3063         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
3064         (viewForElement):
3065         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
3066         (-[DOMHTMLInputElement _selectedRange]):
3067         (-[DOMHTMLInputElement _setAutofilled:]):
3068         * bindings/objc/DOMInternal.h:
3069         * bindings/objc/DOMObject.h:
3070         * bindings/objc/DOMPrivate.h:
3071         * bindings/objc/DOMRange.h:
3072         * bindings/objc/DOMRangeException.h: Added.
3073         * bindings/objc/DOMViews.h:
3074         * bindings/objc/DOMViews.mm: Removed.
3075         * bindings/objc/DOMXPath.h:
3076         * bindings/objc/DOMXPathException.h: Added.
3077         * bindings/scripts/IDLParser.pm:
3078         * dom/Node.idl:
3079
3080 2006-09-18  Brady Eidson  <beidson@apple.com>
3081
3082         Windows build fix
3083
3084         * platform/win/TemporaryLinkStubs.cpp:
3085         (IconDatabase::setIconURLForPageURL):
3086
3087 2006-09-18  David Hyatt  <hyatt@apple.com>
3088
3089         Fix for bug 3969, hr width doesn't update when it clears a float.  This
3090         was also a problem with tables and overflow sections.
3091
3092         Reviewed by Eric
3093
3094         Added fast/block/float/width-update-after-clear.html
3095
3096         * rendering/RenderBlock.cpp:
3097         (WebCore::RenderBlock::collapseMargins):
3098         (WebCore::RenderBlock::clearFloatsIfNeeded):
3099
3100 2006-09-18  Brady Eidson  <beidson@apple.com>
3101
3102         Reviewed by John
3103
3104         http://bugs.webkit.org/show_bug.cgi?id=10907
3105         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
3106
3107         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
3108         * bridge/win/FrameWin.h: Added originalRequestURL()
3109         * loader/icon/IconLoader.cpp:
3110         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
3111         * page/Frame.cpp:
3112         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
3113         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
3114         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
3115         * page/Frame.h: Added pure virtual originalRequestURL()
3116         * platform/win/TemporaryLinkStubs.cpp:
3117         (FrameWin::originalRequestURL): Added
3118
3119 2006-09-18  Rob Buis  <buis@kde.org>
3120
3121         Reviewed by Maciej.
3122
3123         http://bugs.webkit.org/show_bug.cgi?id=10807
3124         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
3125
3126         Make sure the paint method is not exited without popping
3127         context and transparency layer.
3128
3129         WARNING: NO TEST CASES ADDED OR CHANGED
3130
3131         * kcanvas/RenderSVGImage.cpp:
3132         (WebCore::RenderSVGImage::paint):
3133
3134 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
3135
3136         Reviewed by Eric.
3137         
3138         - fix for http://bugs.webkit.org/show_bug.cgi?id=10896
3139         REGRESSION: WebKit can't be built with SVG disabled
3140         
3141         * bindings/scripts/CodeGeneratorObjC.pm:
3142         For each file generated add a #ifdef <something>_SUPPORT / #endif
3143         pair if the idl file has a Conditional extended attribute
3144
3145 2006-09-17  Eric Seidel  <eric@eseidel.com>
3146
3147         Reviewed by ap.
3148         
3149         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
3150         http://bugs.webkit.org/show_bug.cgi?id=10813
3151
3152         * bridge/mac/WebCoreFrameBridge.mm:
3153         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
3154
3155 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
3156
3157         Reviewed by Hyatt.
3158
3159         http://bugs.webkit.org/show_bug.cgi?id=10779
3160         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
3161
3162         No test possible.
3163
3164         * platform/Image.cpp:
3165         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
3166         maybe the rest just hasn't been loaded yet.
3167         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
3168         to start animating before we get at least two frames.
3169
3170 2006-09-17  Brady Eidson <beidson@apple.com>
3171
3172         Reviewed by Sarge
3173
3174         IconLoader now gracefully handles the condition where there's no document in the frame
3175         (ie. PDFs)
3176
3177         * loader/icon/IconLoader.cpp:
3178         (IconLoader::startLoading):
3179
3180 2006-09-17  David Hyatt  <hyatt@apple.com>
3181
3182         Fix for bug 10899, rework how CSS keywords work to be smarter about
3183         using the correct size when generic families change (e.g., monospace to
3184         serif and vice versa).
3185
3186         Reviewed by aroben
3187
3188         Added fast/text/basic/generic-family-changes.html
3189
3190         * css/cssstyleselector.cpp:
3191         (WebCore::CSSStyleSelector::applyProperty):
3192         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
3193         (WebCore::CSSStyleSelector::fontSizeForKeyword):
3194         * css/cssstyleselector.h:
3195         * dom/Document.cpp:
3196         (WebCore::Document::recalcStyle):
3197         * platform/FontDescription.h:
3198         (WebCore::FontDescription::FontDescription):
3199         (WebCore::FontDescription::keywordSize):
3200         (WebCore::FontDescription::setKeywordSize):
3201         (WebCore::FontDescription::operator==):
3202
3203 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
3204
3205         Reviewed by Brady.
3206
3207         http://bugs.webkit.org/show_bug.cgi?id=10852
3208         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
3209
3210         Test: http/tests/xmlhttprequest/xhr-onunload.html
3211
3212         * xml/xmlhttprequest.cpp:
3213         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
3214
3215         * loader/icon/IconLoader.cpp:
3216         (IconLoader::startLoading): Fix a similar latent bug here.
3217
3218 2006-09-17  Adam Roben  <aroben@apple.com>
3219
3220         Build fix.
3221
3222         * loader/icon/IconDatabase.cpp:
3223
3224 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
3225
3226         Reviewed by Brady.
3227
3228         Add simplifyWhiteSpace and stripWhiteSpace to the String class. 
3229         Change the XSLT Parameter Map to use Strings instead of StringImpls.
3230         General cleanup.
3231
3232         * bindings/js/JSXSLTProcessor.cpp:
3233         (KJS::XSLTProcessorProtoFunc::callAsFunction):
3234         * bindings/js/kjs_events.cpp:
3235         (KJS::JSAbstractEventListener::handleEvent):
3236         * bindings/js/kjs_window.cpp:
3237         (KJS::ScheduledAction::execute):
3238         * css/MediaList.cpp:
3239         (WebCore::MediaList::setMediaText):
3240         * dom/Document.cpp:
3241         (WebCore::Document::processHttpEquiv):
3242         * editing/ApplyStyleCommand.cpp:
3243         (WebCore::StyleChange::init):
3244         * html/HTMLDocument.cpp:
3245         (WebCore::parseDocTypeDeclaration):
3246         * html/HTMLLinkElement.cpp:
3247         (WebCore::HTMLLinkElement::parseMappedAttribute):
3248         * html/HTMLObjectElement.cpp:
3249         (WebCore::HTMLObjectElement::HTMLObjectElement):
3250         (WebCore::HTMLObjectElement::parseMappedAttribute):
3251         (WebCore::HTMLObjectElement::attach):
3252         (WebCore::HTMLObjectElement::setComplete):
3253         (WebCore::HTMLObjectElement::detach):
3254         (WebCore::HTMLObjectElement::recalcStyle):
3255         (WebCore::HTMLObjectElement::childrenChanged):
3256         (WebCore::HTMLObjectElement::isImageType):
3257         * html/HTMLObjectElement.h:
3258         * html/HTMLOptionElement.cpp:
3259         (WebCore::HTMLOptionElement::value):
3260         * html/HTMLSelectElement.cpp:
3261         (WebCore::HTMLSelectElement::appendFormData):
3262         * html/HTMLTokenizer.cpp:
3263         (WebCore::HTMLTokenizer::parseTag):
3264         * ksvg2/svg/SVGColor.cpp:
3265         (WebCore::SVGColor::setRGBColor):
3266         * ksvg2/svg/SVGDescElement.cpp:
3267         (WebCore::SVGDescElement::description):
3268         * platform/PlatformString.h:
3269         * platform/String.cpp:
3270         (WebCore::String::stripWhiteSpace):
3271         (WebCore::String::simplifyWhiteSpace):
3272         * platform/StringImpl.cpp:
3273         (WebCore::isSpace):
3274         (WebCore::parseLength):
3275         (WebCore::StringImpl::stripWhiteSpace):
3276         (WebCore::StringImpl::simplifyWhiteSpace):
3277         (WebCore::StringImpl::toInt):
3278         * platform/StringImpl.h:
3279         * platform/mac/ClipboardMac.mm:
3280         (WebCore::cocoaTypeFromMIMEType):
3281         * rendering/RenderPartObject.cpp:
3282         (WebCore::RenderPartObject::updateWidget):
3283         * xml/XPathFunctions.cpp:
3284         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
3285         * xml/XPathGrammar.y:
3286         * xml/XPathStep.cpp:
3287         (WebCore::XPath::Step::nodeTestMatches):
3288         * xml/XSLStyleSheet.cpp:
3289         (WebCore::XSLStyleSheet::loadChildSheets):
3290         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
3291         * xml/XSLTProcessor.cpp:
3292         (WebCore::xsltParamArrayFromParameterMap):
3293         (WebCore::XSLTProcessor::setParameter):
3294         (WebCore::XSLTProcessor::getParameter):
3295         (WebCore::XSLTProcessor::removeParameter):
3296         * xml/XSLTProcessor.h:
3297         * xml/xmlhttprequest.cpp:
3298         (WebCore::XMLHttpRequest::getStatusText):
3299
3300 2006-09-17  David Hyatt  <hyatt@apple.com>
3301
3302         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
3303         are declared right before the fieldsets.  It turns out fieldsets in other
3304         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
3305         adding that behavior to fieldset fixes the bug.
3306
3307         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
3308         and fieldsets all subclass.
3309
3310         Reviewed by anders
3311
3312         Added fast/forms/float-before-fieldset.html
3313
3314         * rendering/RenderFieldset.h:
3315         (WebCore::RenderFieldset::avoidsFloats):
3316         * rendering/RenderFlexibleBox.h:
3317         (WebCore::RenderFlexibleBox::avoidsFloats):
3318         * rendering/RenderObject.cpp:
3319         (WebCore::RenderObject::avoidsFloats):
3320         * rendering/RenderObject.h:
3321         * rendering/RenderTable.h:
3322         (WebCore::RenderTable::avoidsFloats):
3323
3324 2006-09-17  David Hyatt  <hyatt@apple.com>
3325
3326         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
3327         "rules" attributes on tables.
3328
3329         Reviewed by bradee-oh
3330
3331         Well-covered by existing layout tests.
3332
3333         * html/HTMLTableCellElement.cpp:
3334         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
3335         * html/HTMLTableColElement.cpp:
3336         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
3337         * html/HTMLTableColElement.h:
3338         * html/HTMLTableElement.cpp:
3339         (WebCore::HTMLTableElement::HTMLTableElement):
3340         (WebCore::HTMLTableElement::~HTMLTableElement):
3341         (WebCore::HTMLTableElement::setCaption):
3342         (WebCore::HTMLTableElement::setTHead):
3343         (WebCore::HTMLTableElement::setTFoot):
3344         (WebCore::HTMLTableElement::setTBody):
3345         (WebCore::HTMLTableElement::createTHead):
3346         (WebCore::HTMLTableElement::deleteTHead):
3347         (WebCore::HTMLTableElement::createTFoot):
3348         (WebCore::HTMLTableElement::deleteTFoot):
3349         (WebCore::HTMLTableElement::createCaption):
3350         (WebCore::HTMLTableElement::deleteCaption):
3351         (WebCore::HTMLTableElement::insertRow):
3352         (WebCore::HTMLTableElement::deleteRow):
3353         (WebCore::HTMLTableElement::addChild):
3354         (WebCore::HTMLTableElement::childrenChanged):
3355         (WebCore::HTMLTableElement::mapToEntry):
3356         (WebCore::HTMLTableElement::parseMappedAttribute):
3357         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
3358         (WebCore::HTMLTableElement::getSharedCellDecl):
3359         (WebCore::HTMLTableElement::getSharedGroupDecl):
3360         (WebCore::HTMLTableElement::attach):
3361         * html/HTMLTableElement.h:
3362         (WebCore::HTMLTableElement::caption):
3363         (WebCore::HTMLTableElement::tHead):
3364         (WebCore::HTMLTableElement::tFoot):
3365         (WebCore::HTMLTableElement::):
3366         * html/HTMLTableRowElement.h:
3367         * html/HTMLTableSectionElement.cpp:
3368         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
3369         * html/HTMLTableSectionElement.h:
3370
3371 2006-09-17  David Hyatt  <hyatt@apple.com>
3372
3373         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
3374         specify their own new font-family list.  Make sure to always
3375         reset the generic family along with the family list when mapping in
3376         new font-family values.
3377
3378         Reviewed by bradee-oh
3379
3380         fast/text/basic/generic-family-reset.html
3381
3382         * css/cssstyleselector.cpp:
3383         (WebCore::CSSStyleSelector::applyProperty):
3384
3385 2006-09-16  Brady Eidson <beidson@apple.com>
3386
3387         Reviewed by Hyatt
3388
3389         Pruning code relating to WebKit's icon loader
3390
3391         * bridge/mac/WebCoreIconDatabaseBridge.h:
3392         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3393         * loader/icon/IconDatabase.h:
3394         * page/Frame.cpp:
3395         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to 
3396         its new home
3397
3398 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3399
3400         Reviewed by Tim H.
3401
3402         Patch for http://bugs.webkit.org/show_bug.cgi?id=10885
3403         Auto-generate DOMHTMLDocument for the Objective-C bindings
3404
3405         * DerivedSources.make:
3406         * WebCore.xcodeproj/project.pbxproj:
3407         * bindings/objc/DOMExtensions.h:
3408         * bindings/objc/DOMHTML.mm:
3409         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
3410         * bindings/objc/DOMHTMLDocument.h: Removed.
3411         * bindings/objc/DOMHTMLDocument.mm: Removed.
3412         * bindings/objc/PublicDOMInterfaces.h:
3413         * bindings/scripts/CodeGeneratorObjC.pm:
3414         * html/HTMLDocument.idl:
3415         * platform/DeprecatedString.h:
3416         (WebCore::DeprecatedString::operator NSString*):
3417
3418 2006-09-16  Rob Buis  <buis@kde.org>
3419
3420         Reviewed by Eric.
3421
3422         http://bugs.webkit.org/show_bug.cgi?id=10866
3423         Code in kcanvas/ should not use Private
3424
3425         Remove Private classes and tweak coding style.
3426
3427         WARNING: NO TEST CASES ADDED OR CHANGED
3428
3429         * kcanvas/RenderPath.cpp:
3430         (WebCore::RenderPath::RenderPath):
3431         (WebCore::RenderPath::~RenderPath):
3432         (WebCore::RenderPath::localTransform):
3433         (WebCore::RenderPath::setLocalTransform):
3434         (WebCore::RenderPath::fillContains):
3435         (WebCore::RenderPath::relativeBBox):
3436         (WebCore::RenderPath::setPath):
3437         (WebCore::RenderPath::path):
3438         (WebCore::RenderPath::layout):
3439         * kcanvas/RenderPath.h:
3440         * kcanvas/RenderSVGContainer.cpp:
3441         (WebCore::RenderSVGContainer::RenderSVGContainer):
3442         (WebCore::RenderSVGContainer::~RenderSVGContainer):
3443         (WebCore::RenderSVGContainer::drawsContents):
3444         (WebCore::RenderSVGContainer::setDrawsContents):
3445         (WebCore::RenderSVGContainer::localTransform):
3446         (WebCore::RenderSVGContainer::setLocalTransform):
3447         (WebCore::RenderSVGContainer::layout):
3448         (WebCore::RenderSVGContainer::paint):
3449         (WebCore::RenderSVGContainer::setViewport):
3450         (WebCore::RenderSVGContainer::viewport):
3451         (WebCore::RenderSVGContainer::setViewBox):
3452         (WebCore::RenderSVGContainer::viewBox):
3453         (WebCore::RenderSVGContainer::setAlign):
3454         (WebCore::RenderSVGContainer::align):
3455         (WebCore::RenderSVGContainer::fillContains):
3456         (WebCore::RenderSVGContainer::strokeContains):
3457         (WebCore::RenderSVGContainer::setSlice):
3458         (WebCore::RenderSVGContainer::slice):
3459         * kcanvas/RenderSVGContainer.h:
3460         * kcanvas/device/KRenderingFillPainter.cpp:
3461         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
3462         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
3463         (WebCore::KRenderingFillPainter::fillRule):
3464         (WebCore::KRenderingFillPainter::setFillRule):
3465         (WebCore::KRenderingFillPainter::opacity):
3466         (WebCore::KRenderingFillPainter::setOpacity):
3467         * kcanvas/device/KRenderingFillPainter.h:
3468         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3469         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
3470         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
3471         (WebCore::KRenderingPaintServerGradient::gradientStops):
3472         (WebCore::KRenderingPaintServerGradient::setGradientStops):
3473         (WebCore::KRenderingPaintServerGradient::spreadMethod):
3474         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
3475         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
3476         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
3477         (WebCore::KRenderingPaintServerGradient::gradientTransform):
3478         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
3479         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
3480         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
3481         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
3482         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
3483         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
3484         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
3485         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
3486         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
3487         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
3488         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
3489         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
3490         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
3491         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
3492         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
3493         (WebCore::KRenderingPaintServerGradient::listener):
3494         (WebCore::KRenderingPaintServerGradient::setListener):
3495         * kcanvas/device/KRenderingPaintServerGradient.h:
3496         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3497         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
3498         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
3499         (WebCore::KRenderingPaintServerPattern::setBbox):
3500         (WebCore::KRenderingPaintServerPattern::bbox):
3501         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
3502         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
3503         (WebCore::KRenderingPaintServerPattern::tile):
3504         (WebCore::KRenderingPaintServerPattern::setTile):
3505         (WebCore::KRenderingPaintServerPattern::patternTransform):
3506         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
3507         (WebCore::KRenderingPaintServerPattern::listener):
3508         (WebCore::KRenderingPaintServerPattern::setListener):
3509         * kcanvas/device/KRenderingPaintServerPattern.h:
3510         * kcanvas/device/KRenderingPaintServerSolid.cpp:
3511         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
3512         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
3513         (WebCore::KRenderingPaintServerSolid::color):
3514         (WebCore::KRenderingPaintServerSolid::setColor):
3515         * kcanvas/device/KRenderingPaintServerSolid.h:
3516         * kcanvas/device/KRenderingStrokePainter.cpp:
3517         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
3518         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
3519         (WebCore::KRenderingStrokePainter::strokeWidth):
3520         (WebCore::KRenderingStrokePainter::setStrokeWidth):
3521         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
3522         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
3523         (WebCore::KRenderingStrokePainter::strokeCapStyle):
3524         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
3525         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
3526         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
3527         (WebCore::KRenderingStrokePainter::dashOffset):
3528         (WebCore::KRenderingStrokePainter::setDashOffset):
3529         (WebCore::KRenderingStrokePainter::dashArray):
3530         (WebCore::KRenderingStrokePainter::setDashArray):
3531         (WebCore::KRenderingStrokePainter::opacity):
3532         (WebCore::KRenderingStrokePainter::setOpacity):
3533         (WebCore::KRenderingStrokePainter::dirty):
3534         (WebCore::KRenderingStrokePainter::setDirty):
3535         * kcanvas/device/KRenderingStrokePainter.h:
3536
3537 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
3538
3539         Reviewed by Anders.
3540
3541         http://bugs.webkit.org/show_bug.cgi?id=10887
3542         Fix build error
3543
3544         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
3545
3546 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3547
3548         Reviewed by Anders.
3549
3550         Fix for http://bugs.webkit.org/show_bug.cgi?id=10886
3551         REGRESSION (r16387): Reproducible crash when mousing over HTML document
3552
3553         - Special case method [DOMNode ownerDocument] to call document() instead
3554           or ownerDocument() to return to the old behavior. 
3555
3556         * WebCore.xcodeproj/project.pbxproj:
3557         * bindings/scripts/CodeGeneratorObjC.pm:
3558
3559 2006-09-15  Brady Eidson  <beidson@apple.com>
3560
3561         Reviewed by Tim Hatcher
3562
3563         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
3564         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
3565
3566         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
3567         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
3568         (WebCore::IconDatabase::open): Make sure the directory exists
3569
3570 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3571
3572         Reviewed by Brady.
3573
3574         Make new style ObjC methods public API.
3575
3576         * WebCore.xcodeproj/project.pbxproj:
3577         * bindings/objc/DOMPrivate.h:
3578         * bindings/objc/PublicDOMInterfaces.h:
3579
3580 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
3581
3582         Reviewed by Tim H.
3583
3584         Patch for http://bugs.webkit.org/show_bug.cgi?id=10870
3585         Auto-generate DOMNode for the Objective-C bindings
3586
3587         * DerivedSources.make:
3588         * WebCore.xcodeproj/project.pbxproj:
3589         * bindings/objc/DOM.mm:
3590         (-[DOMNode boundingBox]):
3591         (-[DOMNode lineBoxRects]):
3592         * bindings/objc/DOMEvents.h:
3593         * bindings/objc/DOMExtensions.h:
3594         * bindings/objc/DOMNode.h: Removed.
3595         * bindings/objc/DOMNode.mm: Removed.
3596         * bindings/objc/PublicDOMInterfaces.h:
3597         * bindings/scripts/CodeGeneratorObjC.pm:
3598         * dom/Node.idl:
3599
3600 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3601
3602         Reviewed by Justin.
3603
3604         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
3605
3606         * bridge/mac/WebCoreFrameBridge.h:
3607         * bridge/mac/WebCoreFrameBridge.mm:
3608         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
3609         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
3610         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
3611         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
3612         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
3613         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
3614         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3615         (-[WebCoreFrameBridge increaseSelectionListLevel]):
3616    &nb