fix make clean in the qt build to remove all generated files
[WebKit-https.git] / WebCore / ChangeLog
1 2007-01-18  Simon Hausmann  <hausmann@kde.org>
2
3         Reviewed by Zack.
4
5         * WebCore.pro: Remove generated files on make clean.
6
7 2007-01-17  Alice Liu  <alice.liu@apple.com>
8
9         Reviewed by Harrison.
10
11         Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste
12
13         Migration of some editing code from WebHTMView to WebCore::Editor
14         resulted in not calling pasteboardTypesForSelection, which Mail was
15         overriding for the special purpose of adding a type to the
16         pasteboard after WebKit did.  This patch adds 2 separate code paths
17         for Tiger and Leopard.  On Tiger we give in and call the WebView's
18         pasteboardTypesForSelection.  On Leopard we call a delegate after
19         the pasteboard types are set. 
20
21         * bridge/EditorClient.h:
22         * editing/Editor.h:
23         * platform/Pasteboard.h:
24         * platform/graphics/svg/SVGImageEmptyClients.h:
25         (WebCore::SVGEmptyEditorClient::didSetSelectionTypesForPasteboard):
26         (WebCore::SVGEmptyEditorClient::pasteboardTypesForSelection):
27         * platform/mac/PasteboardMac.mm:
28         (WebCore::Pasteboard::Pasteboard):
29         (WebCore::Pasteboard::clear):
30         (WebCore::Pasteboard::writeSelection):
31         (WebCore::Pasteboard::writeURL):
32         (WebCore::Pasteboard::plainText):
33         (WebCore::Pasteboard::documentFragment):
34
35 2007-01-17  John Sullivan  <sullivan@apple.com>
36
37         Reviewed by Darin
38
39         - WebCore part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during 
40           Replace All if the replacement string contains the search string
41         
42         * page/Frame.h:
43         * page/Frame.cpp:
44         (WebCore::Frame::findString):
45         new startInSelection parameter -- if true, search starts looking in selection; if false,
46         search starts looking after the selection
47         
48         * page/mac/WebCoreFrameBridge.h:
49         * page/mac/WebCoreFrameBridge.mm:
50         (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:startInSelection:]):
51         new startInSelection parameter, passed through to Frame::findString()
52
53         * editing/JSEditor.cpp:
54         pass false for new findString parameter, to match old behavior
55
56 2007-01-17  Beth Dakin  <bdakin@apple.com>
57
58         Rubber stamped by Darin.
59
60         * rendering/HitTestResult.cpp: Just added a comment.
61
62 2007-01-17  Justin Garcia  <justin.garcia@apple.com>
63
64         Reviewed by darin
65         
66         <rdar://problem/4920488>
67         REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link)
68
69         * dom/Range.cpp:
70         (WebCore::Range::commonAncestorContainer): Return null if the nodes
71         don't have a common ancestor.  As a side effect, the public 
72         commonAncestorContainer now sets an exception if the Range starts
73         in one document and ends in another, or starts or ends in a tree
74         that's been removed from the document.  The spec doesn't cover
75         this and there is no precedent in other browsers for this case because
76         they don't allow invalid Ranges (you can create one with WebCore
77         by removing a node that contains the start/end of a Range).
78         (WebCore::Range::compareBoundaryPoints): If the the two positions
79         are in nodes that have no common ancestor, return null.  This doesn't
80         change the behavior of the public compareBoundaryPoints: it already
81         throws an exception if the two positions are in nodes that don't have
82         a common ancestor.  This follows the spec.
83
84 2007-01-17  John Sullivan  <sullivan@apple.com>
85
86         The one word was typed by me, but only after debugging for a long time with Darin.
87
88         - fixed <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word
89
90         * editing/TextIterator.cpp:
91         (WebCore::WordAwareIterator::WordAwareIterator):
92         We were creating a TextIterator with the default kind, but WordAwareIterator is designed to work
93         in concert with CharacterIterator, so they need to use the same kind. CharacterIterator uses
94         kind RUNFINDER, so WordAwareIterator needs to do so also.
95
96 2007-01-17  Adele Peterson  <adele@apple.com>
97
98         Reviewed by Brady.
99
100         Fix for <rdar://problem/4900895> REGRESSION: onChange doesn't always fire for popups that have had value changed by JS
101
102         No test case since you need to open up the menu to fire onChange.
103
104         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex):
105           Keep track of m_lastOnChangeIndex even when we're not firing onChange.  Since
106           the selected index has changed, we still want the m_lastOnChangeIndex to be up to date when we compare
107           it later.  This matches our behavior in Safari 2.0.
108
109 2007-01-17  Adele Peterson  <adele@apple.com>
110
111         Reviewed by Darin and John.
112
113         - Fix for <rdar://problem/4816550> REGRESSION: autoscrolling doesn't work after double-click
114
115         * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set swallowEvent bool instead
116           of returning early for double and triple clicks.
117
118 2007-01-17  Darin Adler  <darin@apple.com>
119
120         Reviewed by Hyatt.
121
122         * rendering/RenderObject.h: Removed unused nextEditable and previousEditable.
123         * rendering/RenderObject.cpp: Ditto.
124
125 2007-01-17  Darin Adler  <darin@apple.com>
126
127         Reviewed by Maciej.
128
129         - fix http://bugs.webkit.org/show_bug.cgi?id=12278
130           <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278)
131
132         * WebCore.exp: Added HitTestResult::imageRect,
133         removed HitTestResult::boundingBox.
134
135         * rendering/HitTestResult.h:
136         * rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect):
137         Added. Returns the content rectangle of the image.
138
139         * rendering/RenderObject.h:
140         * rendering/RenderObject.cpp:
141         (WebCore::RenderObject::absolutePosition): Made const.
142         (WebCore::RenderObject::contentBox): Added.
143         (WebCore::RenderObject::absoluteContentBox): Added.
144
145         * rendering/RenderBox.h:
146         * rendering/RenderBox.cpp:
147         (WebCore::RenderBox::absolutePosition): Made const.
148
149         * rendering/RenderTableCell.h:
150         * rendering/RenderTableCell.cpp:
151         (WebCore::RenderTableCell::absolutePosition): Made const.
152
153         * rendering/RenderView.h:
154         * rendering/RenderView.cpp:
155         (WebCore::RenderView::absolutePosition): Made const.
156
157 2007-01-17  Adele Peterson  <adele@apple.com>
158
159         Reviewed by Beth.
160
161         Fix for  http://bugs.webkit.org/show_bug.cgi?id=10139
162         <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle
163
164         Test: fast/css/pseudostyle-anonymous-text.html
165
166         * rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Nil check the node.
167
168 2007-01-17  Adele Peterson  <adele@apple.com>
169
170         Reviewed by Anders and John.
171
172         Fix for http://bugs.webkit.org/show_bug.cgi?id=11278
173         <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options
174
175         Test: fast/forms/menulist-width-change.html
176
177         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
178           When the options change, call setNeedsLayoutAndMinMaxRecalc.
179
180 2007-01-16  Alexey Proskuryakov  <ap@webkit.org>
181
182         Reviewed by Maciej.
183
184         http://bugs.webkit.org/show_bug.cgi?id=12268
185         Give object prototypes their own names
186
187         * bindings/js/kjs_html.cpp: Changed the names of KJS:HTMLElement and KJS::HTMLElement to 
188         not match the names of their WebCore counterparts. The "DOM" prefix I gave them doesn't 
189         seem to carry much sense, but matches some other kjs_html object names.
190
191         * bindings/scripts/CodeGeneratorJS.pm: Append "Proto" to interface name for the prototype's ClassInfo.
192
193         * bindings/js/JSHTMLInputElementBase.cpp:
194         (WebCore::JSHTMLInputElementBasePrototypeFunction::callAsFunction):
195         (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
196         * bindings/js/JSHTMLInputElementBase.h:
197         * bindings/js/JSXMLHttpRequest.cpp:
198         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
199         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
200         (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
201         * bindings/js/JSXMLHttpRequest.h:
202         * bindings/js/JSXSLTProcessor.cpp:
203         (KJS::JSXSLTProcessor::JSXSLTProcessor):
204         (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
205         (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
206         * bindings/js/kjs_css.cpp:
207         (KJS::DOMCSSStyleDeclaration::DOMCSSStyleDeclaration):
208         (KJS::DOMCSSStyleDeclarationPrototypeFunction::callAsFunction):
209         (KJS::DOMMediaList::DOMMediaList):
210         (KJS::KJS::DOMMediaListPrototypeFunction::callAsFunction):
211         (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet):
212         (KJS::DOMCSSStyleSheetPrototypeFunction::callAsFunction):
213         (KJS::DOMCSSValue::DOMCSSValue):
214         (KJS::DOMCSSValuePrototypeFunction::callAsFunction):
215         * bindings/js/kjs_css.h:
216         * bindings/js/kjs_dom.cpp:
217         (KJS::DOMNode::DOMNode):
218         (KJS::DOMNodePrototypeFunction::callAsFunction):
219         (KJS::DOMEventTargetNode::DOMEventTargetNode):
220         (KJS::DOMEventTargetNodePrototypeFunction::callAsFunction):
221         (KJS::DOMNamedNodeMap::DOMNamedNodeMap):
222         (KJS::DOMNamedNodeMapPrototypeFunction::callAsFunction):
223         * bindings/js/kjs_dom.h:
224         * bindings/js/kjs_domnode.h:
225         * bindings/js/kjs_events.cpp:
226         (KJS::DOMEvent::DOMEvent):
227         (KJS::DOMEventPrototypeFunction::callAsFunction):
228         (KJS::Clipboard::Clipboard):
229         (KJS::ClipboardPrototypeFunction::callAsFunction):
230         * bindings/js/kjs_events.h:
231         * bindings/js/kjs_html.cpp:
232         (KJS::JSHTMLDocumentPrototypeFunction::callAsFunction):
233         (KJS::):
234         (KJS::JSHTMLDocument::JSHTMLDocument):
235         (KJS::JSHTMLElementPrototypeFunction::callAsFunction):
236         (KJS::JSHTMLElement::JSHTMLElement):
237         (KJS::JSHTMLCollection::JSHTMLCollection):
238         (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):
239         * bindings/js/kjs_html.h:
240         * bindings/js/kjs_navigator.cpp:
241         * bindings/js/kjs_traversal.cpp:
242         (KJS::DOMNodeFilter::DOMNodeFilter):
243         (KJS::DOMNodeFilterPrototypeFunction::callAsFunction):
244         * bindings/js/kjs_window.cpp:
245         (KJS::Window::clear):
246         Changed Proto to Prototype, and ProtoFunc to PrototypeFunction.
247
248 2007-01-17  Lars Knoll <lars@trolltech.com>
249
250         Reviewed by Zack and Darin
251
252         Fix the Qt build again after the latest Image changes.
253         Also make some of the methods implemented in ImageCG 
254         crossplatform.
255
256         * platform/graphics/BitmapImage.h:
257         * platform/graphics/Image.cpp:
258         (WebCore::Image::fillWithSolidColor):
259         (WebCore::calculatePatternScale):
260         (WebCore::Image::drawTiled):
261         * platform/graphics/Image.h:
262         * platform/graphics/cg/ImageCG.cpp:
263         (WebCore::BitmapImage::draw):
264         * platform/graphics/qt/ImageQt.cpp:
265         (WebCore::Image::loadPlatformResource):
266         (WebCore::Image::drawPattern):
267         (WebCore::BitmapImage::initPlatformData):
268         (WebCore::BitmapImage::invalidatePlatformData):
269         (WebCore::BitmapImage::draw):
270         (WebCore::BitmapImage::drawPattern):
271         * platform/qt/TemporaryLinkStubs.cpp:
272
273 2007-01-17  Darin Adler  <darin@apple.com>
274
275         - quick attempt to fix the Qt build
276
277         * platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::drawTiled):
278         Remove obsolete parameters from this stub.
279
280 2007-01-17  Eric Seidel  <eric@webkit.org>
281
282         Reviewed by rwlbuis.
283
284         Test: svg/custom/inner-svg-hit-test.svg
285
286         * rendering/RenderSVGContainer.cpp:
287         (WebCore::RenderSVGContainer::nodeAtPoint): never allow containers to be hit.
288
289 2007-01-17  Lars Knoll <lars@trolltech.com>
290
291         Reviewed by Zack
292
293         Don't call receivedResponse twice for file: URLs.
294         Never call back into the ResourceHandleClient once
295         cancel() has been called on the ResourceHandle.
296
297         * WebCore.pro:
298         * platform/network/qt/ResourceHandleManagerQt.cpp:
299         (WebCore::ResourceHandleManager::cancel):
300         (WebCore::ResourceHandleManager::receivedResponse):
301         (WebCore::ResourceHandleManager::receivedData):
302         (WebCore::ResourceHandleManager::receivedFinished):
303         (WebCore::FileLoader::request):
304         (WebCore::FileLoader::parseDataUrl):
305         (WebCore::WebCoreHttp::scheduleNextRequest):
306         * platform/network/qt/ResourceHandleManagerQt.h:
307
308 2007-01-17  Eric Seidel  <eric@webkit.org>
309
310         No review, build fix only.
311
312         * platform/graphics/cg/ImageCG.cpp: correct drawPatternCombined to drawPattern
313         (WebCore::Image::drawPattern):
314         (WebCore::Image::drawTiled):
315
316 2007-01-17  Eric Seidel  <eric@webkit.org>
317
318         Reviewed by mitz and rwlbuis.
319         
320         SVGs do not work as background images:
321         http://bugs.webkit.org/show_bug.cgi?id=12096
322
323         Tests updated:
324         - fast/images/svg-as-background.svg: now passes
325         - fast/images/svg-as-tiled-background.svg: now passes
326
327         * platform/graphics/BitmapImage.h:
328         (WebCore::BitmapImage::nativeImageForCurrentFrame):
329         (WebCore::BitmapImage::mayFillWithSolidColor):
330         (WebCore::BitmapImage::solidColor):
331         * platform/graphics/Image.h:
332         (WebCore::Image::mayFillWithSolidColor):
333         (WebCore::Image::solidColor):
334         (WebCore::Image::nativeImageForCurrentFrame):
335         (WebCore::Image::startAnimation):
336         * platform/graphics/cg/ImageCG.cpp:
337         (WebCore::Image::drawPatternCallback):
338         (WebCore::Image::drawPatternCombined):
339         (WebCore::caculatePatternScale):
340         (WebCore::Image::drawTiled):
341         * platform/graphics/cg/PDFDocumentImage.cpp:
342         * platform/graphics/cg/PDFDocumentImage.h:
343         * platform/graphics/svg/SVGImage.cpp:
344         (WebCore::SVGImage::nativeImageForCurrentFrame):
345         * platform/graphics/svg/SVGImage.h:
346
347 2007-01-17  Rob Buis  <buis@kde.org>
348
349         Reviewed by Eric
350
351         Add proper condition for rx attribute negative check.
352
353         * ksvg2/svg/SVGRectElement.cpp:
354         (WebCore::SVGRectElement::parseMappedAttribute):
355
356 2007-01-17  Lars Knoll <lars@trolltech.com>
357
358         Reviewed by Zack
359
360         change all notImplemented() macros to use qDebug
361         instead of fprintf(stder, ...)
362
363         * loader/qt/DocumentLoaderQt.cpp:
364         * loader/qt/FrameLoaderQt.cpp:
365         * page/qt/EventHandlerQt.cpp:
366         * page/qt/FrameQt.cpp:
367         * platform/graphics/qt/GraphicsContextQt.cpp:
368         * platform/graphics/qt/IconQt.cpp:
369         * platform/network/qt/ResourceHandleManagerQt.cpp:
370         * platform/network/qt/ResourceHandleQt.cpp:
371         * platform/qt/CursorQt.cpp:
372         * platform/qt/FileChooserQt.cpp:
373         * platform/qt/MimeTypeRegistryQt.cpp:
374         * platform/qt/PageQt.cpp: Removed.
375         * platform/qt/PopupMenuQt.cpp:
376         * platform/qt/ScrollViewQt.cpp:
377         * platform/qt/TemporaryLinkStubs.cpp:
378         * platform/qt/TextBoundaries.cpp:
379         * platform/qt/WidgetQt.cpp:
380
381 2007-01-16  Brady Eidson  <beidson@apple.com>
382
383         Reviewed by Oliver
384
385         A few enhancements to the HTTP Auth architecture
386
387         * platform/network/ProtectionSpace.cpp:
388         (WebCore::ProtectionSpace::isProxy):
389         (WebCore::ProtectionSpace::receivesCredentialSecurely):
390         * platform/network/ProtectionSpace.h:
391
392 2007-01-16  Alice Liu  <alice.liu@apple.com>
393
394         Reviewed by harrison.
395
396         Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard
397
398         * WebCore.xcodeproj/project.pbxproj:
399         * bridge/EditorClient.h:
400         * editing/Editor.cpp:
401         (WebCore::Editor::copy):
402         (WebCore::Editor::didWriteSelectionToPasteboard):
403         * editing/Editor.h:
404         * platform/graphics/svg/SVGImageEmptyClients.h:
405         (WebCore::SVGEmptyEditorClient::didWriteSelectionToPasteboard):
406
407 2007-01-16  Justin Garcia  <justin.garcia@apple.com>
408
409         Reviewed by harrison
410         
411         <rdar://problem/4747450>
412         Gmail Editor: Caret doesn't always position itself after list marker
413         <rdar://problem/4917055>
414         GMail Editor: A hang can occur when attempting to apply list styling to selected indented text
415
416         * editing/TextIterator.cpp:
417         (WebCore::TextIterator::rangeFromLocationAndLength): Use VisiblePositions
418         to compute the end of a run for emitted '\n's, because it's often wrong
419         in that case.
420
421 2007-01-16  Darin Adler  <darin@apple.com>
422
423         - quick lame attempt to get Qt compiling again
424
425         * platform/qt/ContextMenuQt.cpp: Removed show() function.
426
427 2007-01-17  Nicholas Shanks  <contact@nickshanks.com>
428
429         Reviewed by Darin.
430
431         * platform/network/ResourceRequest.h:
432         (WebCore::ResourceRequest::setHTTPAccept): Correct argument name.
433
434 2007-01-16  Beth Dakin  <bdakin@apple.com>
435
436         Reviewed by Adam.
437
438         Get rid of show() and hide() since they don't do anything.
439
440         * page/ContextMenuController.cpp:
441         (WebCore::ContextMenuController::handleContextMenuEvent):
442         * platform/ContextMenu.h:
443         * platform/mac/ContextMenuMac.mm:
444
445 2007-01-16  Lars Knoll <lars@trolltech.com>
446
447         Reviewed by Zack
448
449         Cleaned up the way we create native widgets. They are
450         now not created in WebCore anymore, but in the new
451         Qt API to WebKit.
452
453         Fix a compile issue in the ResourceHandleManager.
454
455         * WebCore.pro:
456         * platform/ScrollView.h:
457         * platform/Widget.h:
458         (WebCore::ResourceHandleManager::cancel):
459         * platform/qt/ScrollViewCanvasQt.cpp:
460         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
461         (WebCore::ScrollViewCanvasQt::paintEvent):
462         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
463         (WebCore::ScrollViewCanvasQt::mousePressEvent):
464         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
465         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
466         * platform/qt/ScrollViewCanvasQt.h:
467         * platform/qt/ScrollViewQt.cpp:
468         (WebCore::ScrollView::ScrollView):
469         (WebCore::ScrollView::setScrollArea):
470         (WebCore::ScrollView::addChild):
471         * platform/qt/WidgetQt.cpp:
472         * platform/network/qt/ResourceHandleManagerQt.cpp:
473
474 2007-01-16  Lars Knoll <lars@trolltech.com>
475
476         Reviewed by Zack
477
478         Looks like ResourceHandle _has_ to do everything
479         asynchronously if we don't want to run into
480         lots of trouble in the loader.
481
482         Implement support data: URLs.
483
484         Remove some unused Qt only code in ResourceHandleClient.h
485
486         * platform/network/ResourceHandleClient.h:
487         * platform/network/qt/ResourceHandleManagerQt.cpp:
488         (WebCore::RequestQt::setURL):
489         (WebCore::ResourceHandleManager::add):
490         (WebCore::ResourceHandleManager::cancel):
491         (WebCore::ResourceHandleManager::receivedFinished):
492         (WebCore::LoaderThread::run):
493         (WebCore::FileLoader::request):
494         (WebCore::FileLoader::sendData):
495         (WebCore::FileLoader::parseDataUrl):
496         * platform/network/qt/ResourceHandleManagerQt.h:
497
498 2007-01-16  Eric Seidel  <eric@webkit.org>
499
500         Reviewed by mitz.
501
502         Refactor drawTiled implementations in preparation for combining them.
503         Removed unused RoundTile code path.
504
505         * platform/graphics/cg/ImageCG.cpp:
506         (WebCore::drawPattern):
507         (WebCore::BitmapImage::drawTiled):
508         (WebCore::caculatePatternScale):
509
510 2007-01-16  Darin Adler  <darin@apple.com>
511
512         Reviewed by Mark Rowe.
513
514         - removed unused field from loader
515
516         * loader/loader.cpp:
517         (WebCore::Loader::numRequests):
518         (WebCore::Loader::cancelRequests):
519         * loader/loader.h:
520
521 2007-01-15  Rob Buis  <buis@kde.org>
522
523         Reviewed by Eric.
524
525         http://bugs.webkit.org/show_bug.cgi?id=12272
526         SVG picture is clipped (edges not visible)
527
528         Expose css dpi constant and use it for svg, making
529         1in amount to 96 pixels like for html.
530
531         * css/CSSPrimitiveValue.cpp:
532         (WebCore::CSSPrimitiveValue::computeLengthFloat):
533         (WebCore::scaleFactorForConversion):
534         * css/csshelper.h:
535         * ksvg2/svg/SVGLength.cpp:
536         (WebCore::SVGLength::value):
537         (WebCore::SVGLength::setValue):
538         * ksvg2/svg/SVGLength.h:
539
540 2007-01-15  Brady Eidson  <beidson@apple.com>
541
542         Reviewed by Adam
543         
544         CFNet additions
545
546         * platform/network/AuthenticationChallenge.cpp:
547         (WebCore::operator==):
548         * platform/network/AuthenticationChallenge.h:
549         (WebCore::AuthenticationChallenge::sourceHandle):
550         (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
551         * platform/network/ResourceError.h:
552         * platform/network/ResourceHandle.h:
553         * platform/network/ResourceHandleInternal.h:
554         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
555
556 2007-01-15  Eric Seidel  <eric@webkit.org>
557
558         Reviewed by hyatt.
559
560         Don't map attributes in namespaces other than null to CSS properties.
561         
562         Test: svg/custom/attribute-namespace-check.svg
563
564         * ksvg2/svg/SVGStyledElement.cpp:
565         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
566
567 2007-01-15  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
568
569         Reviewed by Darin.
570
571         - http://bugs.webkit.org/show_bug.cgi?id=11112
572           add a drop shadow to the hand cursor used for links
573
574         * Resources/linkCursor.png: Added a drop shadow.
575
576 2007-01-15  Darin Adler  <darin@apple.com>
577
578         Reviewed by Adam.
579
580         - fix http://bugs.webkit.org/show_bug.cgi?id=12190
581           REGRESSION: Placeholder text does not reflect dynamic updates
582
583         Test: fast/forms/placeholder-set-attribute.html
584
585         * html/HTMLTextFieldInnerElement.cpp:
586         (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
587         Call onSearch on the element since I removed it from the renderer.
588
589         * rendering/RenderTextControl.h: Added explicit virtual keywords for overrides
590         of virtual functions. Removed the unneeded onSearch function. Made the inheritance
591         from PopupMenuClient be private, and made the overrides all private. Replaced the
592         showPlaceholderIfNeeded and hidePlaceholderIfNeeded functions with updatePlaceholder.
593         * rendering/RenderTextControl.cpp:
594         (WebCore::RenderTextControl::createResultsButtonStyle): Added an assertion.
595         (WebCore::RenderTextControl::updatePlaceholder): Added. Replaces the two
596         functions, showPlaceholderIfNeeded and hidePlaceholderIfNeeded.
597         (WebCore::RenderTextControl::updateFromElement): Added call to
598         updatePlaceholder before updating the value. Also improved the structure
599         of the function and corrected incorrect use of copy and replace.
600         (WebCore::RenderTextControl::updateCancelButtonVisibility): Added an
601         assertion and removed an unneeded local variable.
602         (WebCore::RenderTextControl::subtreeHasChanged): Removed an unneeded
603         null check and virtual function calls.
604         (WebCore::RenderTextControl::forwardEvent): Replaced calls to the old
605         functions with calls to updatePlaceholder.
606         (WebCore::RenderTextControl::selectionChanged): Changed code to dispatch
607         the select event directly -- I plan to remove the onSelect function, which
608         was only called here.
609         (WebCore::RenderTextControl::autosaveName): Removed too-specific cast and
610         local variable.
611         (WebCore::RenderTextControl::addSearchResult): Added assertion and changed
612         variable name for clarity.
613         (WebCore::RenderTextControl::valueChanged): Changed code to check for empty
614         autosave name instead of null for consistency with other call sites that
615         manage the autosave name. Also changed the code that dispatches an event
616         to call onSearch on the input element so we don't need our own function.
617
618 2007-01-15  Eric Seidel  <eric@webkit.org>
619
620         Reviewed by hyatt.
621
622         Fix SVGStyledElement::parseMappedAttribute to only map SVG-allowed CSS properties
623         (i.e. width is no longer mapped to CSS for SVG)
624         Add SVGStyledElement::mapToEntry to allow RenderStyle-sharing
625         http://bugs.webkit.org/show_bug.cgi?id=12060
626
627         * dom/MappedAttributeEntry.h:
628         (WebCore::):
629         * ksvg2/svg/SVGStyledElement.cpp:
630         (WebCore::cssPropertyIdForName): new helper
631         (WebCore::mapAttributeToCSSProperty): new helper
632         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): new helper
633         (WebCore::SVGStyledElement::mapToEntry): added.
634         (WebCore::SVGStyledElement::parseMappedAttribute): use cssPropertyIdForSVGAttributeName
635         * ksvg2/svg/SVGStyledElement.h:
636
637 2007-01-15  Eric Seidel  <eric@webkit.org>
638
639         Reviewed by bdash.
640
641         Update header guards to follow new style guidelines using new clean-header-guards script.
642
643         * bindings/js/JSHTMLElementWrapperFactory.h:
644         * bindings/js/JSHTMLInputElementBase.h:
645         * bindings/js/JSHTMLOptionElementConstructor.h:
646         * bindings/js/JSSVGElementWrapperFactory.h:
647         * bindings/js/JSSVGPODTypeWrapper.h:
648         * bindings/js/JSXMLHttpRequest.h:
649         * bindings/js/JSXSLTProcessor.h:
650         * bindings/js/kjs_binding.h:
651         * bindings/js/kjs_css.h:
652         * bindings/js/kjs_dom.h:
653         * bindings/js/kjs_domnode.h:
654         * bindings/js/kjs_events.h:
655         * bindings/js/kjs_html.h:
656         * bindings/js/kjs_navigator.h:
657         * bindings/js/kjs_proxy.h:
658         * bindings/js/kjs_traversal.h:
659         * bindings/js/kjs_window.h:
660         * bridge/EditorClient.h:
661         * bridge/History.h:
662         * css/CSSStyleSheet.h:
663         * css/CSSValue.h:
664         * css/CSSValueList.h:
665         * css/DashboardRegion.h:
666         * css/FontFamilyValue.h:
667         * css/FontValue.h:
668         * css/MediaFeatureNames.h:
669         * css/MediaList.h:
670         * css/Pair.h:
671         * css/RectImpl.h:
672         * css/ShadowValue.h:
673         * css/StyleBase.h:
674         * css/StyleList.h:
675         * css/StyleSheet.h:
676         * css/StyleSheetList.h:
677         * css/cssstyleselector.h:
678         * dom/BeforeTextInsertedEvent.h:
679         * dom/CDATASection.h:
680         * dom/CharacterData.h:
681         * dom/ChildNodeList.h:
682         * dom/Comment.h:
683         * dom/DOMImplementation.h:
684         * dom/DocPtr.h:
685         * dom/Document.h:
686         * dom/DocumentFragment.h:
687         * dom/DocumentMarker.h:
688         * dom/DocumentType.h:
689         * dom/EditingText.h:
690         * dom/Entity.h:
691         * dom/EntityReference.h:
692         * dom/EventNames.h:
693         * dom/EventTargetNode.h:
694         * dom/NameNodeList.h:
695         * dom/NamedNodeMap.h:
696         * dom/Node.h:
697         * dom/NodeList.h:
698         * dom/Notation.h:
699         * dom/Position.h:
700         * dom/ProcessingInstruction.h:
701         * dom/Range.h:
702         * dom/StyleElement.h:
703         * dom/Text.h:
704         * editing/AppendNodeCommand.h:
705         * editing/ApplyStyleCommand.h:
706         * editing/BreakBlockquoteCommand.h:
707         * editing/CommandByName.h:
708         * editing/CompositeEditCommand.h:
709         * editing/DeleteButton.h:
710         * editing/DeleteButtonController.h:
711         * editing/DeleteFromTextNodeCommand.h:
712         * editing/DeleteSelectionCommand.h:
713         * editing/InsertIntoTextNodeCommand.h:
714         * editing/InsertLineBreakCommand.h:
715         * editing/InsertNodeBeforeCommand.h:
716         * editing/InsertParagraphSeparatorCommand.h:
717         * editing/InsertTextCommand.h:
718         * editing/JoinTextNodesCommand.h:
719         * editing/MergeIdenticalElementsCommand.h:
720         * editing/ModifySelectionListLevel.h:
721         * editing/MoveSelectionCommand.h:
722         * editing/RemoveCSSPropertyCommand.h:
723         * editing/RemoveNodeAttributeCommand.h:
724         * editing/RemoveNodeCommand.h:
725         * editing/RemoveNodePreservingChildrenCommand.h:
726         * editing/ReplaceSelectionCommand.h:
727         * editing/SetNodeAttributeCommand.h:
728         * editing/SplitElementCommand.h:
729         * editing/SplitTextNodeCommand.h:
730         * editing/SplitTextNodeContainingElementCommand.h:
731         * editing/TextGranularity.h:
732         * editing/TypingCommand.h:
733         * editing/WrapContentsInDummySpanCommand.h:
734         * history/BackForwardList.h:
735         * history/HistoryItem.h:
736         * history/HistoryItemTimer.h:
737         * history/PageCache.h:
738         * html/CanvasGradient.h:
739         * html/CanvasPattern.h:
740         * html/CanvasRenderingContext2D.h:
741         * html/CanvasStyle.h:
742         * html/FormDataList.h:
743         * html/HTMLAnchorElement.h:
744         * html/HTMLAppletElement.h:
745         * html/HTMLAreaElement.h:
746         * html/HTMLBRElement.h:
747         * html/HTMLBaseElement.h:
748         * html/HTMLBaseFontElement.h:
749         * html/HTMLBlockquoteElement.h:
750         * html/HTMLBodyElement.h:
751         * html/HTMLButtonElement.h:
752         * html/HTMLCanvasElement.h:
753         * html/HTMLCollection.h:
754         * html/HTMLDListElement.h:
755         * html/HTMLDirectoryElement.h:
756         * html/HTMLDivElement.h:
757         * html/HTMLElement.h:
758         * html/HTMLElementFactory.h:
759         * html/HTMLEmbedElement.h:
760         * html/HTMLFieldSetElement.h:
761         * html/HTMLFontElement.h:
762         * html/HTMLFormCollection.h:
763         * html/HTMLFormElement.h:
764         * html/HTMLFrameSetElement.h:
765         * html/HTMLGenericFormElement.h:
766         * html/HTMLHRElement.h:
767         * html/HTMLHeadElement.h:
768         * html/HTMLHeadingElement.h:
769         * html/HTMLHtmlElement.h:
770         * html/HTMLImageElement.h:
771         * html/HTMLImageLoader.h:
772         * html/HTMLInputElement.h:
773         * html/HTMLIsIndexElement.h:
774         * html/HTMLKeygenElement.h:
775         * html/HTMLLIElement.h:
776         * html/HTMLLabelElement.h:
777         * html/HTMLLegendElement.h:
778         * html/HTMLLinkElement.h:
779         * html/HTMLMapElement.h:
780         * html/HTMLMarqueeElement.h:
781         * html/HTMLMenuElement.h:
782         * html/HTMLMetaElement.h:
783         * html/HTMLModElement.h:
784         * html/HTMLNameCollection.h:
785         * html/HTMLOListElement.h:
786         * html/HTMLObjectElement.h:
787         * html/HTMLOptGroupElement.h:
788         * html/HTMLOptionElement.h:
789         * html/HTMLOptionsCollection.h:
790         * html/HTMLParagraphElement.h:
791         * html/HTMLParamElement.h:
792         * html/HTMLParser.h:
793         * html/HTMLPlugInElement.h:
794         * html/HTMLPreElement.h:
795         * html/HTMLQuoteElement.h:
796         * html/HTMLScriptElement.h:
797         * html/HTMLSelectElement.h:
798         * html/HTMLStyleElement.h:
799         * html/HTMLTableCaptionElement.h:
800         * html/HTMLTableCellElement.h:
801         * html/HTMLTableColElement.h:
802         * html/HTMLTableElement.h:
803         * html/HTMLTablePartElement.h:
804         * html/HTMLTableRowElement.h:
805         * html/HTMLTableSectionElement.h:
806         * html/HTMLTextAreaElement.h:
807         * html/HTMLTextFieldInnerElement.h:
808         * html/HTMLTitleElement.h:
809         * html/HTMLUListElement.h:
810         * ksvg2/css/SVGRenderStyle.h:
811         * ksvg2/css/SVGRenderStyleDefs.h:
812         * ksvg2/events/JSSVGLazyEventListener.h:
813         * ksvg2/events/SVGZoomEvent.h:
814         * ksvg2/misc/KCanvasRenderingStyle.h:
815         * ksvg2/misc/PointerEventsHitRules.h:
816         * ksvg2/misc/SVGDocumentExtensions.h:
817         * ksvg2/misc/SVGImageLoader.h:
818         * ksvg2/misc/TimeScheduler.h:
819         * ksvg2/svg/GradientAttributes.h:
820         * ksvg2/svg/LinearGradientAttributes.h:
821         * ksvg2/svg/PatternAttributes.h:
822         * ksvg2/svg/RadialGradientAttributes.h:
823         * ksvg2/svg/SVGAElement.h:
824         * ksvg2/svg/SVGAngle.h:
825         * ksvg2/svg/SVGAnimateColorElement.h:
826         * ksvg2/svg/SVGAnimateElement.h:
827         * ksvg2/svg/SVGAnimateMotionElement.h:
828         * ksvg2/svg/SVGAnimateTransformElement.h:
829         * ksvg2/svg/SVGAnimatedPathData.h:
830         * ksvg2/svg/SVGAnimatedPoints.h:
831         * ksvg2/svg/SVGAnimatedTemplate.h:
832         * ksvg2/svg/SVGAnimationElement.h:
833         * ksvg2/svg/SVGCircleElement.h:
834         * ksvg2/svg/SVGClipPathElement.h:
835         * ksvg2/svg/SVGColor.h:
836         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
837         * ksvg2/svg/SVGCursorElement.h:
838         * ksvg2/svg/SVGDOMImplementation.h:
839         * ksvg2/svg/SVGDefsElement.h:
840         * ksvg2/svg/SVGDescElement.h:
841         * ksvg2/svg/SVGDocument.h:
842         * ksvg2/svg/SVGElement.h:
843         * ksvg2/svg/SVGElementInstance.h:
844         * ksvg2/svg/SVGElementInstanceList.h:
845         * ksvg2/svg/SVGEllipseElement.h:
846         * ksvg2/svg/SVGExternalResourcesRequired.h:
847         * ksvg2/svg/SVGFEBlendElement.h:
848         * ksvg2/svg/SVGFEColorMatrixElement.h:
849         * ksvg2/svg/SVGFEComponentTransferElement.h:
850         * ksvg2/svg/SVGFECompositeElement.h:
851         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
852         * ksvg2/svg/SVGFEDisplacementMapElement.h:
853         * ksvg2/svg/SVGFEDistantLightElement.h:
854         * ksvg2/svg/SVGFEFloodElement.h:
855         * ksvg2/svg/SVGFEFuncAElement.h:
856         * ksvg2/svg/SVGFEFuncBElement.h:
857         * ksvg2/svg/SVGFEFuncGElement.h:
858         * ksvg2/svg/SVGFEFuncRElement.h:
859         * ksvg2/svg/SVGFEGaussianBlurElement.h:
860         * ksvg2/svg/SVGFEImageElement.h:
861         * ksvg2/svg/SVGFELightElement.h:
862         * ksvg2/svg/SVGFEMergeElement.h:
863         * ksvg2/svg/SVGFEMergeNodeElement.h:
864         * ksvg2/svg/SVGFEOffsetElement.h:
865         * ksvg2/svg/SVGFEPointLightElement.h:
866         * ksvg2/svg/SVGFESpecularLightingElement.h:
867         * ksvg2/svg/SVGFESpotLightElement.h:
868         * ksvg2/svg/SVGFETileElement.h:
869         * ksvg2/svg/SVGFETurbulenceElement.h:
870         * ksvg2/svg/SVGFilterElement.h:
871         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
872         * ksvg2/svg/SVGFitToViewBox.h:
873         * ksvg2/svg/SVGForeignObjectElement.h:
874         * ksvg2/svg/SVGGElement.h:
875         * ksvg2/svg/SVGGradientElement.h:
876         * ksvg2/svg/SVGImageElement.h:
877         * ksvg2/svg/SVGLangSpace.h:
878         * ksvg2/svg/SVGLength.h:
879         * ksvg2/svg/SVGLengthList.h:
880         * ksvg2/svg/SVGLineElement.h:
881         * ksvg2/svg/SVGLinearGradientElement.h:
882         * ksvg2/svg/SVGList.h:
883         * ksvg2/svg/SVGListTraits.h:
884         * ksvg2/svg/SVGLocatable.h:
885         * ksvg2/svg/SVGMarkerElement.h:
886         * ksvg2/svg/SVGMaskElement.h:
887         * ksvg2/svg/SVGMetadataElement.h:
888         * ksvg2/svg/SVGNumberList.h:
889         * ksvg2/svg/SVGPaint.h:
890         * ksvg2/svg/SVGParserUtilities.h:
891         * ksvg2/svg/SVGPathElement.h:
892         * ksvg2/svg/SVGPathSeg.h:
893         * ksvg2/svg/SVGPathSegArc.h:
894         * ksvg2/svg/SVGPathSegClosePath.h:
895         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
896         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
897         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
898         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
899         * ksvg2/svg/SVGPathSegLineto.h:
900         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
901         * ksvg2/svg/SVGPathSegLinetoVertical.h:
902         * ksvg2/svg/SVGPathSegList.h:
903         * ksvg2/svg/SVGPathSegMoveto.h:
904         * ksvg2/svg/SVGPatternElement.h:
905         * ksvg2/svg/SVGPointList.h:
906         * ksvg2/svg/SVGPolyElement.h:
907         * ksvg2/svg/SVGPolygonElement.h:
908         * ksvg2/svg/SVGPolylineElement.h:
909         * ksvg2/svg/SVGPreserveAspectRatio.h:
910         * ksvg2/svg/SVGRadialGradientElement.h:
911         * ksvg2/svg/SVGRectElement.h:
912         * ksvg2/svg/SVGRenderingIntent.h:
913         * ksvg2/svg/SVGSVGElement.h:
914         * ksvg2/svg/SVGScriptElement.h:
915         * ksvg2/svg/SVGSetElement.h:
916         * ksvg2/svg/SVGStopElement.h:
917         * ksvg2/svg/SVGStringList.h:
918         * ksvg2/svg/SVGStylable.h:
919         * ksvg2/svg/SVGStyleElement.h:
920         * ksvg2/svg/SVGStyledElement.h:
921         * ksvg2/svg/SVGStyledLocatableElement.h:
922         * ksvg2/svg/SVGStyledTransformableElement.h:
923         * ksvg2/svg/SVGSwitchElement.h:
924         * ksvg2/svg/SVGSymbolElement.h:
925         * ksvg2/svg/SVGTRefElement.h:
926         * ksvg2/svg/SVGTSpanElement.h:
927         * ksvg2/svg/SVGTests.h:
928         * ksvg2/svg/SVGTextContentElement.h:
929         * ksvg2/svg/SVGTextElement.h:
930         * ksvg2/svg/SVGTextPositioningElement.h:
931         * ksvg2/svg/SVGTitleElement.h:
932         * ksvg2/svg/SVGTransform.h:
933         * ksvg2/svg/SVGTransformList.h:
934         * ksvg2/svg/SVGTransformable.h:
935         * ksvg2/svg/SVGURIReference.h:
936         * ksvg2/svg/SVGUnitTypes.h:
937         * ksvg2/svg/SVGUseElement.h:
938         * ksvg2/svg/SVGViewElement.h:
939         * ksvg2/svg/SVGZoomAndPan.h:
940         * loader/CachedCSSStyleSheet.h:
941         * loader/CachedImage.h:
942         * loader/CachedXSLStyleSheet.h:
943         * loader/DocumentLoader.h:
944         * loader/Request.h:
945         * loader/SubresourceLoader.h:
946         * loader/icon/IconDataCache.h:
947         * loader/icon/IconDatabase.h:
948         * loader/icon/IconLoader.h:
949         * loader/icon/SQLDatabase.h:
950         * loader/icon/SQLStatement.h:
951         * loader/icon/SQLTransaction.h:
952         * page/Frame.h:
953         * page/FrameLoadRequest.h:
954         * page/FrameTree.h:
955         * page/FrameView.h:
956         * page/PageState.h:
957         * page/Plugin.h:
958         * page/qt/FrameQt.h:
959         * page/qt/FrameQtClient.h:
960         * platform/Arena.h:
961         * platform/ArrayImpl.h:
962         * platform/Cursor.h:
963         * platform/DeprecatedArray.h:
964         * platform/DeprecatedCString.h:
965         * platform/FileChooser.h:
966         * platform/Font.h:
967         * platform/FontCache.h:
968         * platform/FontData.h:
969         * platform/FontDescription.h:
970         * platform/FontFamily.h:
971         * platform/GlyphBuffer.h:
972         * platform/GlyphMap.h:
973         * platform/GlyphWidthMap.h:
974         * platform/Logging.h:
975         * platform/Pasteboard.h:
976         * platform/PlatformString.h:
977         * platform/PlugInInfoStore.h:
978         * platform/PopupMenu.h:
979         * platform/PopupMenuClient.h:
980         * platform/ScrollBar.h:
981         * platform/ScrollView.h:
982         * platform/SearchPopupMenu.h:
983         * platform/Shared.h:
984         * platform/Sound.h:
985         * platform/SystemTime.h:
986         * platform/Timer.h:
987         * platform/Widget.h:
988         * platform/cf/RetainPtr.h:
989         * platform/gdk/ChromeClientGdk.h:
990         * platform/gdk/FontPlatformData.h:
991         * platform/gdk/FrameGdk.h:
992         * platform/gdk/KeyboardCodes.h:
993         * platform/gdk/RenderPopupMenuGdk.h:
994         * platform/gdk/RenderThemeGdk.h:
995         * platform/graphics/BitmapImage.h:
996         * platform/graphics/Color.h:
997         * platform/graphics/FloatPoint.h:
998         * platform/graphics/FloatPoint3D.h:
999         * platform/graphics/FloatRect.h:
1000         * platform/graphics/Icon.h:
1001         * platform/graphics/Image.h:
1002         * platform/graphics/ImageAnimationObserver.h:
1003         * platform/graphics/ImageBuffer.h:
1004         * platform/graphics/ImageSource.h:
1005         * platform/graphics/IntPoint.h:
1006         * platform/graphics/IntRect.h:
1007         * platform/graphics/IntSize.h:
1008         * platform/graphics/IntSizeHash.h:
1009         * platform/graphics/PathTraversalState.h:
1010         * platform/graphics/Pen.h:
1011         * platform/graphics/qt/ImageDecoderQt.h:
1012         * platform/graphics/svg/SVGImage.h:
1013         * platform/graphics/svg/SVGImageEmptyClients.h:
1014         * platform/graphics/svg/SVGPaintServer.h:
1015         * platform/graphics/svg/SVGPaintServerGradient.h:
1016         * platform/graphics/svg/SVGPaintServerLinearGradient.h:
1017         * platform/graphics/svg/SVGPaintServerPattern.h:
1018         * platform/graphics/svg/SVGPaintServerRadialGradient.h:
1019         * platform/graphics/svg/SVGPaintServerSolid.h:
1020         * platform/graphics/svg/SVGResource.h:
1021         * platform/graphics/svg/SVGResourceClipper.h:
1022         * platform/graphics/svg/SVGResourceFilter.h:
1023         * platform/graphics/svg/SVGResourceMarker.h:
1024         * platform/graphics/svg/SVGResourceMasker.h:
1025         * platform/graphics/svg/cg/CgSupport.h:
1026         * platform/graphics/svg/filters/SVGDistantLightSource.h:
1027         * platform/graphics/svg/filters/SVGFEBlend.h:
1028         * platform/graphics/svg/filters/SVGFEColorMatrix.h:
1029         * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
1030         * platform/graphics/svg/filters/SVGFEComposite.h:
1031         * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
1032         * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
1033         * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
1034         * platform/graphics/svg/filters/SVGFEFlood.h:
1035         * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
1036         * platform/graphics/svg/filters/SVGFEImage.h:
1037         * platform/graphics/svg/filters/SVGFEMerge.h:
1038         * platform/graphics/svg/filters/SVGFEMorphology.h:
1039         * platform/graphics/svg/filters/SVGFEOffset.h:
1040         * platform/graphics/svg/filters/SVGFESpecularLighting.h:
1041         * platform/graphics/svg/filters/SVGFETile.h:
1042         * platform/graphics/svg/filters/SVGFETurbulence.h:
1043         * platform/graphics/svg/filters/SVGFilterEffect.h:
1044         * platform/graphics/svg/filters/SVGLightSource.h:
1045         * platform/graphics/svg/filters/SVGPointLightSource.h:
1046         * platform/graphics/svg/filters/SVGSpotLightSource.h:
1047         * platform/mac/FontPlatformData.h:
1048         * platform/mac/PlatformScrollBar.h:
1049         * platform/network/AuthenticationChallenge.h:
1050         * platform/network/Credential.h:
1051         * platform/network/HTTPHeaderMap.h:
1052         * platform/network/ProtectionSpace.h:
1053         * platform/network/ResourceError.h:
1054         * platform/network/ResourceRequest.h:
1055         * platform/network/ResourceResponse.h:
1056         * platform/network/cf/FormDataStreamCFNet.h:
1057         * platform/network/cf/ResourceRequestCFNet.h:
1058         * platform/network/cf/ResourceResponseCFNet.h:
1059         * platform/network/gdk/ResourceHandleManager.h:
1060         * platform/network/mac/AuthenticationMac.h:
1061         * platform/network/mac/FormDataStreamMac.h:
1062         * platform/network/qt/ResourceHandleManagerKDE.h:
1063         * platform/network/qt/ResourceHandleManagerQt.h:
1064         * platform/network/win/ResourceHandleWin.h:
1065         * platform/qt/FontPlatformData.h:
1066         * platform/qt/KeyboardCodes.h:
1067         * platform/qt/PlatformScrollBar.h:
1068         * platform/qt/ScrollViewCanvasQt.h:
1069         * platform/qt/SharedTimerQt.h:
1070         * platform/win/FontPlatformData.h:
1071         * platform/win/PlatformScrollBar.h:
1072         * rendering/AutoTableLayout.h:
1073         * rendering/HitTestRequest.h:
1074         * rendering/HitTestResult.h:
1075         * rendering/InlineBox.h:
1076         * rendering/InlineFlowBox.h:
1077         * rendering/Length.h:
1078         * rendering/ListMarkerBox.h:
1079         * rendering/RenderBox.h:
1080         * rendering/RenderMenuList.h:
1081         * rendering/RenderPart.h:
1082         * rendering/RenderPartObject.h:
1083         * rendering/RenderPath.h:
1084         * rendering/RenderReplaced.h:
1085         * rendering/RenderSVGContainer.h:
1086         * rendering/RenderSVGImage.h:
1087         * rendering/RenderSVGInline.h:
1088         * rendering/RenderSVGInlineText.h:
1089         * rendering/RenderSVGTSpan.h:
1090         * rendering/RenderSVGText.h:
1091         * rendering/RenderStyle.h:
1092         * rendering/RenderTableCol.h:
1093         * rendering/RenderThemeWin.h:
1094         * rendering/bidi.h:
1095         * xml/DOMParser.h:
1096         * xml/XPathEvaluator.h:
1097         * xml/XPathExpression.h:
1098         * xml/XPathExpressionNode.h:
1099         * xml/XPathFunctions.h:
1100         * xml/XPathNSResolver.h:
1101         * xml/XPathNamespace.h:
1102         * xml/XPathParser.h:
1103         * xml/XPathPath.h:
1104         * xml/XPathPredicate.h:
1105         * xml/XPathResult.h:
1106         * xml/XPathStep.h:
1107         * xml/XPathUtil.h:
1108         * xml/XPathValue.h:
1109         * xml/XPathVariableReference.h:
1110         * xml/XSLImportRule.h:
1111         * xml/XSLStyleSheet.h:
1112         * xml/XSLTProcessor.h:
1113         * xml/xmlhttprequest.h:
1114
1115 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
1116
1117         Build fix.
1118         
1119         * loader/ProgressTracker.cpp:
1120
1121 2007-01-15  Lars Knoll <lars@trolltech.com>
1122
1123         Fix the Qt build
1124
1125         * WebCore.pro:
1126
1127 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
1128
1129         Reviewed by Darin.
1130
1131         * loader/ProgressTracker.cpp:
1132         Set finalProgressValue to its value explicitly instead of calculating it 
1133         (which causes a global initializer to be generated).
1134
1135 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
1136
1137         Reviewed by Darin and Adam.
1138
1139         Move progress tracking down to WebCore.
1140         
1141         * WebCore.exp:
1142         Add ProgressTracker::estimatedProgress() to be used by WebKit.
1143         
1144         * WebCore.xcodeproj/project.pbxproj:
1145         Add ProgressTracker.[cpp|h]
1146         
1147         * loader/FrameLoader.cpp:
1148         (WebCore::FrameLoader::prepareForLoadStart):
1149         (WebCore::FrameLoader::clearProvisionalLoad):
1150         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1151         (WebCore::FrameLoader::startLoading):
1152         (WebCore::FrameLoader::didReceiveResponse):
1153         (WebCore::FrameLoader::didReceiveData):
1154         (WebCore::FrameLoader::didFailToLoad):
1155         (WebCore::FrameLoader::requestFromDelegate):
1156         (WebCore::FrameLoader::didFinishLoad):
1157         Call directly to the progress tracker instead of through the frame loader client.
1158         
1159         * loader/FrameLoaderClient.h:
1160         Get rid of the old methods and add new methods for tracking progress.
1161         
1162         * loader/ProgressTracker.cpp: Added.
1163         (WebCore::ProgressItem::ProgressItem):
1164         (WebCore::ProgressTracker::ProgressTracker):
1165         (WebCore::ProgressTracker::~ProgressTracker):
1166         (WebCore::ProgressTracker::estimatedProgress):
1167         (WebCore::ProgressTracker::reset):
1168         (WebCore::ProgressTracker::progressStarted):
1169         (WebCore::ProgressTracker::progressCompleted):
1170         (WebCore::ProgressTracker::finalProgressComplete):
1171         (WebCore::ProgressTracker::incrementProgress):
1172         (WebCore::ProgressTracker::completeProgress):
1173         (WebCore::ProgressTracker::createUniqueIdentifier):
1174         * loader/ProgressTracker.h: Added.
1175         New per page class which tracks progress.
1176         
1177         * loader/ResourceLoader.cpp:
1178         (WebCore::ResourceLoader::willSendRequest):
1179         * page/Page.cpp:
1180         (WebCore::Page::Page):
1181         * page/Page.h:
1182         (WebCore::Page::progress):
1183         Move createUniqueIdentifier to ProgressTracker, add ProgressTracker object to Page.
1184         
1185         * platform/graphics/svg/SVGImageEmptyClients.h:
1186         (WebCore::SVGEmptyFrameLoaderClient::willChangeEstimatedProgress):
1187         (WebCore::SVGEmptyFrameLoaderClient::didChangeEstimatedProgress):
1188         (WebCore::SVGEmptyFrameLoaderClient::postProgressStartedNotification):
1189         (WebCore::SVGEmptyFrameLoaderClient::postProgressEstimateChangedNotification):
1190         (WebCore::SVGEmptyFrameLoaderClient::postProgressFinishedNotification):
1191         Add new methods, get rid of the old ones.
1192
1193 2007-01-15  Adam Roben  <aroben@apple.com>
1194
1195         Reviewed by Anders.
1196
1197         Fix comment.
1198
1199         * html/HTMLScriptElement.cpp:
1200         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
1201
1202 2007-01-15  John Sullivan  <sullivan@apple.com>
1203
1204         * platform/ContextMenu.cpp:
1205         (WebCore::ContextMenu::checkOrEnableIfNeeded):
1206         Leopard build fix; don't declare one of the case values twice
1207
1208 2007-01-15  Mitz Pettel  <mitz@webkit.org>
1209
1210         Reviewed by Darin.
1211
1212         - fix http://bugs.webkit.org/show_bug.cgi?id=8604
1213           rowspan does not work when set through javascript
1214
1215         Covered by existing tests.
1216
1217         * rendering/RenderTableCell.cpp:
1218         (WebCore::RenderTableCell::updateFromElement): Mark the section for grid recalc
1219         if row span or column span change.
1220
1221 2007-01-15  Adam Roben  <aroben@apple.com>
1222
1223         Reviewed by Darin.
1224
1225         Small context menu fixes.
1226
1227         * platform/ContextMenu.cpp:
1228         (WebCore::ContextMenu::populate): Fix typo.
1229         (WebCore::ContextMenu::checkOrEnableIfNeeded): Disabled "No Guesses
1230         Found", and added all enum values explicitly.
1231
1232 2007-01-15  Alexey Proskuryakov  <ap@webkit.org>
1233
1234         Reviewed by Darin.
1235
1236         http://bugs.webkit.org/show_bug.cgi?id=6272
1237         XMLHttpRequest freezes on getting a missing document with overridden Content-Length
1238
1239         http://bugs.webkit.org/show_bug.cgi?id=6212
1240         Investigate disallowing some XMLHttpRequest headers from being set via setRequestHeader.
1241
1242         Tests:
1243         - http/tests/xmlhttprequest/connection-error-sync.html
1244         - http/tests/xmlhttprequest/set-dangerous-headers.html
1245
1246         * bindings/js/kjs_binding.cpp:
1247         (KJS::):
1248         (KJS::setDOMException): Added support for NETWORK_ERR. Changed the temporary 
1249         PERMISSION_DENIED error into a special case.
1250
1251         * loader/FrameLoader.cpp:
1252         (WebCore::FrameLoader::loadResourceSynchronously):
1253         * loader/FrameLoader.h:
1254         Return the error object to the caller. Removed an extra local variable for error, 
1255         which shadowed the one from enclosing block.
1256
1257         * dom/XMLTokenizer.cpp:
1258         (WebCore::openFunc): 
1259         * xml/XSLTProcessor.cpp:
1260         (WebCore::docLoaderFunc): 
1261         Updated to pass an error object (currently ignored).
1262
1263         * xml/xmlhttprequest.cpp:
1264         (WebCore::canSetRequestHeader): Added. The headers to block include the ones from 
1265         the current XMLHttpRequest draft plus "Via", which is blocked by Firefox.
1266         (WebCore::XMLHttpRequest::send): Raise an exception if a sync request results in 
1267         an error.
1268         (WebCore::XMLHttpRequest::setRequestHeader): Call canSetRequestHeader().
1269         * xml/xmlhttprequest.h:
1270         (WebCore::): Added NETWORK_ERR and a comment about PERMISSION_DENIED.
1271
1272 2007-01-15  Zack Rusin  <zack@kde.org>
1273
1274         Optimizing rendering on the Qt platform. Mainly
1275         switching from client side QImage to QPixmap's.
1276         Also cleaning the the ScrollViewCanvasQt code
1277         quite a bit.
1278
1279         * platform/graphics/ImageSource.h: use QPixmap
1280         * platform/graphics/qt/GraphicsContextQt.cpp:
1281         (WebCore::TransparencyLayer::TransparencyLayer):
1282         (WebCore::GraphicsContext::clip): clip rects when you can
1283         * platform/graphics/qt/ImageDecoderQt.cpp:
1284         (WebCore::ImageDecoderQt::ImageData::ImageData):
1285         (WebCore::ImageDecoderQt::ReadContext::read):
1286         (WebCore::ImageDecoderQt::ReadContext::readImageLines):
1287         (WebCore::ImageDecoderQt::imageAtIndex):
1288         * platform/graphics/qt/ImageDecoderQt.h: use QPixmap
1289         * platform/graphics/qt/ImageQt.cpp: QPixmap instead of QImage
1290         (WebCore::BitmapImage::draw):
1291         (WebCore::BitmapImage::drawTiled):
1292         * platform/graphics/qt/ImageSourceQt.cpp:
1293         (WebCore::):
1294         (WebCore::ImageSource::createFrameAtIndex):
1295         (WebCore::ImageSource::frameHasAlphaAtIndex):
1296         * platform/qt/ScrollViewCanvasQt.cpp: clean up
1297         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
1298         (WebCore::ScrollViewCanvasQt::updateFrameView):
1299         (WebCore::ScrollViewCanvasQt::paintEvent):
1300         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
1301         (WebCore::ScrollViewCanvasQt::mousePressEvent):
1302         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
1303         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
1304         * platform/qt/ScrollViewCanvasQt.h:
1305         * platform/qt/ScrollViewQt.cpp: remove hacks
1306         (WebCore::ScrollView::ScrollView):
1307         (WebCore::ScrollView::setParentWidget):
1308         (WebCore::ScrollView::updateContents):
1309
1310 2007-01-15  Lars Knoll <lars@trolltech.com>
1311
1312         Reviewed by Zack
1313
1314         Fix weird crashes when running the layout tests. The
1315         reason was that I used KURL (and thus DeprecatedString)
1316         in a thread. Unfortunately that class is not threadsafe
1317         at all.
1318
1319         * platform/network/qt/ResourceHandleManagerQt.cpp:
1320         (WebCore::RequestQt::RequestQt):
1321         (WebCore::RequestQt::setURL):
1322         (WebCore::ResourceHandleManager::add):
1323         (WebCore::ResourceHandleManager::cancel):
1324         (WebCore::ResourceHandleManager::receivedResponse):
1325         (WebCore::FileLoader::request):
1326         (WebCore::HostInfo::HostInfo):
1327         (WebCore::NetworkLoader::request):
1328         (WebCore::NetworkLoader::cancel):
1329         * platform/network/qt/ResourceHandleManagerQt.h:
1330         (WebCore::HostInfo::HostInfo):
1331         (WebCore::HostInfo::isLocalFile):
1332
1333 2007-01-15  Eric Seidel  <eric@webkit.org>
1334
1335         Reviewed by rwlbuis.
1336
1337         Make isValid check not malloc 3 SVGStringLists for every element.
1338         
1339         No test possible, performance fix only.
1340
1341         * ksvg2/svg/SVGTests.cpp:
1342         (WebCore::SVGTests::isValid):
1343
1344 2007-01-15  Rob Buis  <buis@kde.org>
1345
1346         Reviewed by Eric.
1347
1348         Remove unused member var.
1349
1350         * ksvg2/svg/SVGStyledElement.h:
1351
1352 2007-01-15  Rob Buis  <buis@kde.org>
1353
1354         Reviewed by Eric.
1355
1356         http://bugs.webkit.org/show_bug.cgi?id=12069
1357         Hit detection fails under some viewbox constraints
1358
1359         Do not take viewBox into account when hit testing svg container.
1360
1361         * rendering/RenderSVGContainer.cpp:
1362         (WebCore::RenderSVGContainer::nodeAtPoint):
1363
1364 2007-01-15  David Hyatt  <hyatt@apple.com>
1365
1366         Fix  for 12275, negative margins confuse page breaks.
1367
1368         Reviewed by Eric
1369
1370         * rendering/RenderBlock.cpp:
1371         (WebCore::RenderBlock::paintChildren):
1372
1373 2007-01-15  Eric Seidel  <eric@webkit.org>
1374
1375         Reviewed by mjs.
1376         
1377         SVG gradients do not notice stop additions
1378         http://bugs.webkit.org/show_bug.cgi?id=12192
1379
1380         Test: svg/custom/gradient-add-stops.svg
1381
1382         * ksvg2/svg/SVGGradientElement.cpp:
1383         (WebCore::SVGGradientElement::childrenChanged):
1384         * ksvg2/svg/SVGGradientElement.h:
1385
1386 2007-01-14  David Hyatt  <hyatt@apple.com>
1387
1388         Fix for bug 10356, positioning doesn't work with <svg> elements in XHTML.  Change the requiresLayer
1389         check to use the DOM, since the old check would fail if the parent block had no element.
1390
1391         Reviewed by Eric
1392
1393         Added svg/custom/relative-positioning.html (absolute/fixed too)
1394
1395         * rendering/RenderSVGContainer.cpp:
1396         (WebCore::RenderSVGContainer::requiresLayer):
1397
1398 2007-01-14  Eric Seidel  <eric@webkit.org>
1399
1400         Reviewed by hyatt.
1401         
1402         SVG does not correctly handle float: left
1403         http://bugs.webkit.org/show_bug.cgi?id=12210
1404
1405         Test: svg/custom/svg-float-border-padding.xml
1406
1407         * rendering/RenderSVGContainer.cpp:
1408         (WebCore::RenderSVGContainer::paint):
1409
1410 2007-01-14  David Hyatt  <hyatt@apple.com>
1411
1412         More work to fix 10145, regression where form elements don't break properly.  Make sure to really use
1413         the parent of the replaced element's whitespace value everywhere.
1414
1415         Reviewed by olliej
1416
1417         fast/replaced/three-selects-break.html
1418
1419         * rendering/bidi.cpp:
1420         (WebCore::RenderBlock::findNextLineBreak):
1421
1422 2007-01-14  Sam Weinig  <sam@webkit.org>
1423
1424         Reviewed by Darin and then by Mitz.
1425
1426         Patch for http://bugs.webkit.org/show_bug.cgi?id=12228
1427         Cleanup assorted CSS classes
1428
1429         * css/CSSBorderImageValue.cpp:
1430         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
1431         (WebCore::CSSBorderImageValue::cssText):
1432         * css/CSSBorderImageValue.h:
1433         * css/CSSComputedStyleDeclaration.cpp:
1434         (WebCore::valueForLength):
1435         (WebCore::valueForBorderStyle):
1436         (WebCore::valueForTextAlign):
1437         (WebCore::valueForShadow):
1438         (WebCore::getPositionOffsetValue):
1439         (WebCore::CSSComputedStyleDeclaration::cssText):
1440         (WebCore::primitiveValueFromLength):
1441         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1442         (WebCore::CSSComputedStyleDeclaration::getPropertyPriority):
1443         (WebCore::CSSComputedStyleDeclaration::removeProperty):
1444         (WebCore::CSSComputedStyleDeclaration::setProperty):
1445         (WebCore::CSSComputedStyleDeclaration::length):
1446         (WebCore::CSSComputedStyleDeclaration::item):
1447         * css/CSSComputedStyleDeclaration.h:
1448         * css/CSSCursorImageValue.cpp:
1449         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1450         * css/CSSCursorImageValue.h:
1451         * css/CSSGrammar.y:
1452         * css/CSSImageValue.cpp:
1453         * css/CSSImageValue.h:
1454         * css/CSSInheritedValue.cpp:
1455         * css/CSSInheritedValue.h:
1456         * css/CSSInitialValue.cpp:
1457         * css/CSSInitialValue.h:
1458         * css/CSSMutableStyleDeclaration.cpp:
1459         (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
1460         (WebCore::CSSMutableStyleDeclaration::operator=):
1461         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
1462         (WebCore::CSSMutableStyleDeclaration::get4Values):
1463         (WebCore::CSSMutableStyleDeclaration::getShorthandValue):
1464         (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
1465         (WebCore::CSSMutableStyleDeclaration::removeProperty):
1466         (WebCore::CSSMutableStyleDeclaration::setChanged):
1467         (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
1468         (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
1469         (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
1470         (WebCore::CSSMutableStyleDeclaration::setProperty):
1471         (WebCore::CSSMutableStyleDeclaration::setImageProperty):
1472         (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
1473         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
1474         (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
1475         (WebCore::CSSMutableStyleDeclaration::cssText):
1476         (WebCore::CSSMutableStyleDeclaration::merge):
1477         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
1478         * css/CSSMutableStyleDeclaration.h:
1479         (WebCore::CSSMutableStyleDeclaration::setProperty):
1480         (WebCore::CSSMutableStyleDeclaration::removeProperty):
1481         * css/CSSNamespace.h:
1482         (WebCore::CSSNamespace::CSSNamespace):
1483         * css/CSSPrimitiveValue.cpp:
1484         (WebCore::isCSSTokenizerIdentifier):
1485         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1486         (WebCore::CSSPrimitiveValue::cleanup):
1487         (WebCore::CSSPrimitiveValue::computeLengthInt):
1488         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
1489         (WebCore::CSSPrimitiveValue::computeLengthShort):
1490         (WebCore::CSSPrimitiveValue::computeLengthFloat):
1491         (WebCore::CSSPrimitiveValue::setFloatValue):
1492         (WebCore::scaleFactorForConversion):
1493         (WebCore::CSSPrimitiveValue::getFloatValue):
1494         (WebCore::CSSPrimitiveValue::setStringValue):
1495         (WebCore::CSSPrimitiveValue::getStringValue):
1496         (WebCore::CSSPrimitiveValue::parseString):
1497         (WebCore::CSSPrimitiveValue::getIdent):
1498         (WebCore::CSSPrimitiveValue::cssText):
1499         * css/CSSPrimitiveValue.h:
1500         (WebCore::CSSPrimitiveValue::getCounterValue):
1501         (WebCore::CSSPrimitiveValue::getRectValue):
1502         (WebCore::CSSPrimitiveValue::getRGBColorValue):
1503         (WebCore::CSSPrimitiveValue::getPairValue):
1504         (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
1505         * css/CSSProperty.cpp:
1506         (WebCore::operator==):
1507         * css/CSSProperty.h:
1508         (WebCore::CSSProperty::operator=):
1509         * css/CSSQuirkPrimitiveValue.h:
1510         (WebCore::CSSQuirkPrimitiveValue::CSSQuirkPrimitiveValue):
1511         * css/CSSRuleList.cpp:
1512         (WebCore::CSSRuleList::CSSRuleList):
1513         (WebCore::CSSRuleList::deleteRule):
1514         (WebCore::CSSRuleList::insertRule):
1515         * css/CSSRuleList.h:
1516         (WebCore::CSSRuleList::item):
1517         * css/CSSSelector.cpp:
1518         (WebCore::CSSSelector::print):
1519         (WebCore::CSSSelector::specificity):
1520         (WebCore::CSSSelector::extractPseudoType):
1521         (WebCore::CSSSelector::operator==):
1522         (WebCore::CSSSelector::selectorText):
1523         * css/CSSSelector.h:
1524         (WebCore::CSSSelector::CSSSelector):
1525         (WebCore::CSSSelector::~CSSSelector):
1526         (WebCore::CSSSelector::append):
1527         (WebCore::CSSSelector::next):
1528         (WebCore::CSSSelector::pseudoType):
1529         (WebCore::CSSSelector::hasTag):
1530         (WebCore::CSSSelector::hasAttribute):
1531         * css/CSSStyleDeclaration.cpp:
1532         (WebCore::propertyID):
1533         (WebCore::CSSStyleDeclaration::getPropertyPriority):
1534         (WebCore::CSSStyleDeclaration::getPropertyShorthand):
1535         (WebCore::CSSStyleDeclaration::isPropertyImplicit):
1536         (WebCore::CSSStyleDeclaration::setProperty):
1537         (WebCore::CSSStyleDeclaration::isPropertyName):
1538         (WebCore::CSSStyleDeclaration::parentRule):
1539         (WebCore::CSSStyleDeclaration::diff):
1540         (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
1541         * css/CSSStyleDeclaration.h:
1542         * css/Counter.h:
1543         (WebCore::Counter::Counter):
1544         (WebCore::Counter::listStyleNumber):
1545         * css/csshelper.cpp:
1546         (WebCore::parseURL):
1547         * css/csshelper.h:
1548         * css/cssparser.h:
1549         (WebCore::domString):
1550         (WebCore::atomicString):
1551         (WebCore::CSSParser::operator|):
1552         * css/cssstyleselector.cpp:
1553         (WebCore::CSSStyleSelector::matchRulesForList):
1554         (WebCore::CSSStyleSelector::checkSelector):
1555         (WebCore::CSSStyleSelector::checkOneSelector):
1556         (WebCore::CSSRuleSet::addRule):
1557
1558 2007-01-14  Mitz Pettel  <mitz@webkit.org>
1559
1560         Reviewed by Adam.
1561
1562         - fix http://bugs.webkit.org/show_bug.cgi?id=12264
1563           REGRESSION (r18843): Webkit crashes on 43Folders.com home page
1564
1565         Test: fast/tokenizer/ignore-tags-in-iframe.html
1566
1567         * html/HTMLParser.cpp:
1568         (WebCore::HTMLParser::reset): Removed unused inSelect member variable.
1569         (WebCore::HTMLParser::selectCreateErrorCheck): Ditto.
1570         (WebCore::HTMLParser::processCloseTag): Ditto.
1571         * html/HTMLParser.h: Ditto.
1572         * html/HTMLTokenizer.cpp:
1573         (WebCore::HTMLTokenizer::parseTag): Changed not to process <pre>, <listing>,
1574         <script>, <style>, <title>, <textarea> and <xmp> if the parser is in skip mode
1575         (waiting for a close tag of an element whose contents are not parsed,
1576         such as iframe).
1577         * html/HTMLTokenizer.h:
1578         (WebCore::HTMLTokenizer::State::setInStyle): Removed unused bit.
1579         (WebCore::HTMLTokenizer::State::): Ditto.
1580
1581 2007-01-14  Alexey Proskuryakov  <ap@webkit.org>
1582
1583         Reviewed by Darin.
1584
1585         http://bugs.webkit.org/show_bug.cgi?id=12258
1586         fast/tokenizer/002 test broken
1587
1588         * loader/FrameLoader.h: Added a flush parameter to write().
1589         * loader/FrameLoader.cpp:
1590         (WebCore::FrameLoader::write): Ditto.
1591         (WebCore::FrameLoader::endIfNotLoading): Instead of poorly duplicating the logic in write(),
1592         call it directly.
1593
1594 2007-01-14  Adam Roben  <aroben@apple.com>
1595
1596         Reviewed by Maciej.
1597
1598         Make sure our whitelisting of the type and language attributes of the
1599         <script> element is enforced in all HTMLTokenizer/HTMLScriptElement
1600         code paths.
1601
1602         All layout tests pass.
1603
1604         * html/HTMLScriptElement.cpp:
1605         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): New method to
1606         determine whether the script should be executed, given its type and
1607         language attributes.
1608         (WebCore::HTMLScriptElement::evaluateScript): Check type/language
1609         before executing.
1610         * html/HTMLScriptElement.h: Added new declarations.
1611         * html/HTMLTokenizer.cpp:
1612         (WebCore::HTMLTokenizer::begin): Made scriptSrc a String. 
1613         (WebCore::HTMLTokenizer::scriptHandler): Check
1614         shouldExecuteAsJavaScript before executing.
1615         (WebCore::HTMLTokenizer::notifyFinished): Ditto.
1616         (WebCore::HTMLTokenizer::parseTag): Moved type/language checking from
1617         here to HTMLScriptElement::shouldExecuteAsJavaScript.
1618         * html/HTMLTokenizer.h: Made scriptSrc a String, and removed the
1619         javascript member.
1620
1621 2007-01-14  David Hyatt  <hyatt@apple.com>
1622
1623         Make sure floats are avoided if you have non-auto column property values.  Fixes the crazy layout
1624         on http://weblogs.mozillazine.org/roc.
1625
1626         Reviewed by mitz
1627
1628         Added fast/multicol/float-avoidance.html
1629
1630         * rendering/RenderBlock.cpp:
1631         (WebCore::RenderBlock::avoidsFloats):
1632
1633 2007-01-14  David Hyatt  <hyatt@apple.com>
1634
1635         Fix for 10145, regression where line breaks are not being honored between adjacent replaced elements.
1636         When checking for break opportunities where replaced elements are involved, we ignore their white-space
1637         values and use their parents' instead.  The assumption/idea behind this change is that because the element
1638         is replaced, its white-space value is irrelevant except as a means of applying style to its interior.
1639
1640         The CSS spec does not cover this situation, so we're implementing this based off what other browsers seem to
1641         do.
1642
1643         Reviewed by aroben
1644
1645         * css/CSSComputedStyleDeclaration.cpp:
1646         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1647         * css/CSSValueKeywords.in:
1648         * css/cssparser.cpp:
1649         (WebCore::CSSParser::parseValue):
1650         * css/cssstyleselector.cpp:
1651         (WebCore::CSSStyleSelector::applyProperty):
1652         * page/EventHandler.cpp:
1653         (WebCore::EventHandler::EventHandler):
1654         (WebCore::EventHandler::clear):
1655         (WebCore::EventHandler::handleWheelEvent):
1656         * page/EventHandler.h:
1657         * rendering/RenderBox.cpp:
1658         (WebCore::RenderBox::calcHeight):
1659         * rendering/RenderLayer.cpp:
1660         (WebCore::Marquee::Marquee):
1661         (WebCore::Marquee::start):
1662         (WebCore::Marquee::updateMarqueePosition):
1663         (WebCore::Marquee::updateMarqueeStyle):
1664         (WebCore::Marquee::timerFired):
1665         * rendering/RenderLayer.h:
1666         * rendering/RenderPartObject.cpp:
1667         (WebCore::RenderPartObject::viewCleared):
1668         * rendering/RenderStyle.h:
1669         (WebCore::):
1670         * rendering/bidi.cpp:
1671         (WebCore::RenderBlock::findNextLineBreak):
1672
1673 2007-01-13  David Hyatt  <hyatt@apple.com>
1674
1675         While optimizing form controls and fixing their clipping, I caused this text zoom regression.  The layout
1676         of text is necessary because it needs to recalc minmaxwidth.  This is still a really unfortunate
1677         bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
1678         as dirty when we don't have to.
1679
1680         Reviewed by mitz
1681
1682         * rendering/RenderObject.cpp:
1683         (WebCore::RenderObject::setStyle):
1684
1685 2007-01-13  Lars Knoll <lars@trolltech.com>
1686
1687         Reviewed by Alexey
1688
1689         String::format() was relying on undefined behaviour, which
1690         happened to work on lots of systems (Mac and 32bit Linux at least)
1691         but broke badly on 64bit Linux.
1692         
1693         * platform/String.cpp:
1694         (WebCore::String::format):
1695
1696 2007-01-13  Martin Reddy  <reddy@pixar.com>
1697
1698         Fix for bug 11924: WebCore would crash on any HTML content
1699         with a non-empty <table> tag in it on a 64-bit machine. The
1700         size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
1701         and the clients of this function have been updated to check
1702         for a false return code.
1703
1704         Reviewed by Darin, landed by Lars
1705
1706         * rendering/RenderTableSection.cpp:
1707         (WebCore::RenderTableSection::addChild):
1708         (WebCore::RenderTableSection::ensureRows):
1709         (WebCore::RenderTableSection::recalcCells):
1710
1711 2007-01-13  Alexey Proskuryakov  <ap@webkit.org>
1712
1713         Reviewed by Darin.
1714
1715         http://bugs.webkit.org/show_bug.cgi?id=12165
1716         REGRESSION: text encoding problem at jn.sapo.pt
1717
1718         Test: fast/encoding/script-in-head.html
1719
1720         * loader/TextResourceDecoder.cpp:
1721         (WebCore::TextResourceDecoder::checkForHeadCharset):
1722         Ignore tags within <script> elements in head, just like we do for <title>.
1723
1724 2007-01-13  Lars Knoll <lars@trolltech.com>
1725
1726         Reviewed by Maciej
1727
1728         Don't crash when constructing a GraphicsContext with a 0
1729         PlatformGraphicsContext and don't do anything if painting
1730         is disabled.
1731
1732         * platform/graphics/qt/GraphicsContextQt.cpp:
1733         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
1734         (WebCore::GraphicsContext::origin):
1735         (WebCore::GraphicsContext::setPlatformFont):
1736         (WebCore::GraphicsContext::setPlatformStrokeColor):
1737         (WebCore::GraphicsContext::setPlatformStrokeStyle):
1738         (WebCore::GraphicsContext::setPlatformStrokeThickness):
1739         (WebCore::GraphicsContext::setPlatformFillColor):
1740
1741 2007-01-13  Eric Seidel  <eric@webkit.org>
1742
1743         Reviewed by hyatt.
1744
1745         RichDraw demo does not live-update in Safari
1746         (SVG elements should ignore CSS position)
1747         http://bugs.webkit.org/show_bug.cgi?id=10364
1748
1749         * css/cssstyleselector.cpp:
1750         (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
1751         * ksvg2/svg/SVGStyledElement.cpp:
1752         (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
1753         * rendering/RenderContainer.cpp:
1754         (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
1755         * rendering/RenderPath.cpp:
1756         (WebCore::RenderPath::layout): move path generation into layout()
1757         * rendering/RenderSVGContainer.cpp:
1758         (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout
1759
1760 2007-01-12  David Hyatt  <hyatt@apple.com>
1761
1762         Add support for column rules.
1763
1764         Reviewed by bdash
1765
1766         fast/multicol/column-rules.html
1767
1768         * rendering/RenderBlock.cpp:
1769         (WebCore::RenderBlock::paintColumns):
1770         * rendering/RenderStyle.h:
1771         (WebCore::RenderStyle::columnRuleIsTransparent):
1772
1773 2007-01-12  David Hyatt  <hyatt@apple.com>
1774
1775         Make multicolumn layout work with floats.
1776
1777         Reviewed by andersca
1778
1779         Added fast/multicol/float-multicol.html
1780
1781         * rendering/RenderBlock.cpp:
1782         (WebCore::RenderBlock::layoutBlock):
1783         (WebCore::RenderBlock::paintColumns):
1784         (WebCore::RenderBlock::paintObject):
1785         * rendering/RenderBlock.h:
1786
1787 2007-01-12  David Kilzer  <ddkilzer@kilzer.net>
1788
1789         Reviewed by Maciej.
1790
1791         - fix http://bugs.webkit.org/show_bug.cgi?id=12239
1792           REGRESSION (r18816-r18818): Assertion failure in 
1793           WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
1794
1795         Test: fast/css/line-height.html
1796
1797         * rendering/RenderTextControl.cpp:
1798         (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.
1799
1800 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
1801
1802         Reviewed by Darin.
1803
1804         Use unsigned long for identifiers instead of Objective-C objects.
1805         
1806         * loader/FrameLoader.cpp:
1807         (WebCore::FrameLoader::loadResourceSynchronously):
1808         (WebCore::FrameLoader::startLoadingMainResource):
1809         (WebCore::FrameLoader::startLoading):
1810         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
1811         (WebCore::FrameLoader::opened):
1812         (WebCore::FrameLoader::sendRemainingDelegateMessages):
1813         (WebCore::FrameLoader::requestFromDelegate):
1814         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
1815         * loader/FrameLoader.h:
1816         * loader/FrameLoaderClient.h:
1817         * loader/ResourceLoader.cpp:
1818         (WebCore::ResourceLoader::ResourceLoader):
1819         (WebCore::ResourceLoader::willSendRequest):
1820         * loader/ResourceLoader.h:
1821         (WebCore::ResourceLoader::setIdentifier):
1822         (WebCore::ResourceLoader::identifier):
1823         * page/Page.cpp:
1824         (WebCore::Page::Page):
1825         (WebCore::Page::createUniqueIdentifier):
1826         * page/Page.h:
1827         * platform/graphics/svg/SVGImageEmptyClients.h:
1828         (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest):
1829         (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
1830         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1831         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1832         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse):
1833         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength):
1834         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading):
1835         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading):
1836         (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
1837         (WebCore::SVGEmptyFrameLoaderClient::completeProgress):
1838
1839 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1840
1841         Reviewed by Darin.
1842
1843         - fix http://bugs.webkit.org/show_bug.cgi?id=12235
1844           REGRESSION (r18815): Marquees do not scroll
1845
1846         * css/cssstyleselector.cpp:
1847         (WebCore::CSSStyleSelector::applyProperty): Apply the '-webkit-marquee' value
1848         of 'overflow-x' and 'overflow-y'.
1849
1850 2007-01-12  Justin Garcia  <justin.garcia@apple.com>
1851
1852         Reviewed by hyatt
1853         
1854         <rdar://problem/4875425>
1855         EBay, GMail, and GoogleDocs RTEs font size popups don't work
1856
1857         Changed execCommand("FontSize", ...) to match the spec 
1858         and the behavior of other browsers.  It expects a number, 
1859         n, which, the spec says can be 1 through 7.  Other browsers 
1860         perform the font size change by creating a font element 
1861         wrapper with size="n".  We convert n into one of the absolute 
1862         size CSS keywords (x-small, medium, etc.).
1863
1864         * editing/JSEditor.cpp: Call cssValueFromFontSizeNumber.  If
1865         successful, perform the style change.
1866         * html/HTMLFontElement.cpp:
1867         (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):  Added.
1868         Moved this code from parsedMappedAttribute so that it could be
1869         called from the Editor.
1870         (WebCore::HTMLFontElement::parseMappedAttribute): Moved code into
1871         cssValueFromFontSizeNumber.
1872         * html/HTMLFontElement.h:
1873
1874 2007-01-12  David Hyatt  <hyatt@apple.com>
1875
1876         Fix for bug 11598, implement lightweight control clipping mechanism for
1877         buttons, list boxes, and dropdown lists.  Make sure list box respects
1878         scrollLeft/Top/Width/Height as well as clientWidth/Height.
1879
1880         Fix bugs in RenderStyle::diff.  CursorData was not being compared properly.
1881         vertical-align had a non-inline display check that was wrong (preventing
1882         dynamic changes to keyword-based vertical-align from working).
1883
1884         Reviewed by mitz
1885
1886         * page/EventHandler.cpp:
1887         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
1888         * rendering/RenderBlock.cpp:
1889         (WebCore::RenderBlock::layout):
1890         (WebCore::RenderBlock::layoutBlock):
1891         (WebCore::RenderBlock::determineHorizontalPosition):
1892         (WebCore::RenderBlock::layoutBlockChildren):
1893         (WebCore::RenderBlock::paint):
1894         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1895         (WebCore::RenderBlock::nodeAtPoint):
1896         (WebCore::RenderBlock::layoutColumns):
1897         * rendering/RenderBox.cpp:
1898         (WebCore::RenderBox::computeAbsoluteRepaintRect):
1899         * rendering/RenderBox.h:
1900         * rendering/RenderButton.cpp:
1901         (WebCore::RenderButton::setStyle):
1902         (WebCore::RenderButton::controlClipRect):
1903         * rendering/RenderButton.h:
1904         (WebCore::RenderButton::hasControlClip):
1905         * rendering/RenderFlexibleBox.cpp:
1906         (WebCore::RenderFlexibleBox::layoutBlock):
1907         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
1908         (WebCore::RenderFlexibleBox::layoutVerticalBox):
1909         * rendering/RenderFlow.cpp:
1910         (WebCore::RenderFlow::addFocusRingRects):
1911         * rendering/RenderListBox.cpp:
1912         (WebCore::RenderListBox::itemBoundingBoxRect):
1913         (WebCore::RenderListBox::paintObject):
1914         (WebCore::RenderListBox::itemHeight):
1915         (WebCore::RenderListBox::verticalScrollbarWidth):
1916         (WebCore::RenderListBox::scrollWidth):
1917         (WebCore::RenderListBox::scrollHeight):
1918         (WebCore::RenderListBox::scrollLeft):
1919         (WebCore::RenderListBox::setScrollLeft):
1920         (WebCore::RenderListBox::scrollTop):
1921         (WebCore::RenderListBox::setScrollTop):
1922         (WebCore::RenderListBox::controlClipRect):
1923         * rendering/RenderListBox.h:
1924         (WebCore::RenderListBox::hasControlClip):
1925         * rendering/RenderMenuList.cpp:
1926         (WebCore::RenderMenuList::setStyle):
1927         (WebCore::RenderMenuList::controlClipRect):
1928         * rendering/RenderMenuList.h:
1929         (WebCore::RenderMenuList::hasControlClip):
1930         * rendering/RenderObject.cpp:
1931         (WebCore::RenderObject::verticalScrollbarWidth):
1932         (WebCore::RenderObject::horizontalScrollbarHeight):
1933         (WebCore::RenderObject::clientWidth):
1934         (WebCore::RenderObject::clientHeight):
1935         (WebCore::RenderObject::setStyle):
1936         * rendering/RenderObject.h:
1937         (WebCore::RenderObject::hasControlClip):
1938         (WebCore::RenderObject::controlClipRect):
1939         (WebCore::RenderObject::contentWidth):
1940         (WebCore::RenderObject::contentHeight):
1941         * rendering/RenderStyle.cpp:
1942         (WebCore::StyleVisualData::StyleVisualData):
1943         (WebCore::cursorDataEqvuialent):
1944         (WebCore::StyleInheritedData::operator==):
1945         (WebCore::CursorList::operator==):
1946         (WebCore::RenderStyle::diff):
1947         * rendering/RenderStyle.h:
1948         (WebCore::LengthBox::operator!=):
1949         (WebCore::StyleVisualData::operator==):
1950         (WebCore::CursorData::operator==):
1951         (WebCore::CursorData::operator!=):
1952         (WebCore::CursorList::operator!=):
1953         (WebCore::RenderStyle::setTableLayout):
1954         * rendering/bidi.cpp:
1955         (WebCore::RenderBlock::layoutInlineChildren):
1956
1957 2007-01-12  David Hyatt  <hyatt@apple.com>
1958
1959         Fix for bug 9934, smaller line heights should not be allowed on
1960         text fields.
1961
1962         Reviewed by darin
1963
1964         * rendering/RenderTextControl.cpp:
1965         (WebCore::RenderTextControl::createInnerTextStyle):
1966
1967 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1968
1969         Reviewed by Hyatt.
1970
1971         - http://bugs.webkit.org/show_bug.cgi?id=12215
1972           Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and
1973           when removing.
1974
1975         Test: fast/css/remove-shorthand.html (updated)
1976
1977         * css/CSSMutableStyleDeclaration.cpp:
1978         (WebCore::initShorthandMap):
1979         * css/cssparser.cpp:
1980         (WebCore::CSSParser::parseValue):
1981
1982 2007-01-12  Rob Buis  <buis@kde.org>
1983
1984         Reviewed by Mitz.
1985
1986         Do not mix up JSSVGPolygonElement and JSSVGPolylineElement.
1987
1988         * bindings/js/JSSVGElementWrapperFactory.cpp:
1989
1990 2007-01-12  Kevin Decker <kdecker@apple.com>
1991
1992         Reviewed by andersca.
1993
1994         Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]
1995
1996         * dom/DOMImplementation.cpp:
1997         (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the 
1998         loader plumbing was moved to WebCore.  Pinging the plug-in database to ask it if it supports a given mime type has the side 
1999         effect of reading from disk on first call, therefore such a check should be a last resort.  
2000
2001 2007-01-12  Mitz Pettel  <mitz@webkit.org>
2002
2003         Reviewed by Darin.
2004
2005         - fix http://bugs.webkit.org/show_bug.cgi?id=12223
2006           REGRESSION: Leaks under CSSStyleSelector::applyProperty
2007
2008         No test possible (no change to functionality).
2009
2010         * rendering/RenderObject.h: Removed unused forward declaration.
2011         * rendering/RenderStyle.cpp:
2012         (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
2013         Delete shadow data.
2014
2015 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
2016
2017         Build fix.
2018         
2019         * WebCore.xcodeproj/project.pbxproj:
2020         Remove SubresourceLoaderMac.mm.
2021         
2022 2007-01-12  Lars Knoll <lars@trolltech.com>
2023
2024         Reviewed by Darin and Anders.
2025
2026         Make some more of the loader code platform independent.
2027
2028         * loader/FrameLoader.cpp:
2029         (WebCore::FrameLoader::clear):
2030         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2031         (WebCore::FrameLoader::urlSelected):
2032         (WebCore::FrameLoader::createEmptyDocument):
2033         (WebCore::FrameLoader::setTitle):
2034         (WebCore::FrameLoader::originalRequestURL):
2035         (WebCore::FrameLoader::referrer):
2036         * loader/SubresourceLoader.cpp:
2037         (WebCore::SubresourceLoader::SubresourceLoader):
2038         (WebCore::SubresourceLoader::load):
2039         (WebCore::SubresourceLoader::create):
2040         (WebCore::SubresourceLoader::willSendRequest):
2041         (WebCore::SubresourceLoader::didReceiveResponse):
2042         (WebCore::SubresourceLoader::didReceiveData):
2043         (WebCore::SubresourceLoader::didFinishLoading):
2044         (WebCore::SubresourceLoader::didFail):
2045         (WebCore::SubresourceLoader::didCancel):
2046         (WebCore::SubresourceLoader::stopLoading):
2047         * loader/SubresourceLoader.h:
2048         * loader/mac/FrameLoaderMac.mm:
2049         * loader/mac/SubresourceLoaderMac.mm: Removed.
2050         * loader/qt/FrameLoaderQt.cpp:
2051
2052 2007-01-12  Lars Knoll <lars@trolltech.com>
2053
2054         Reviewed by Zack
2055
2056         Valgrind reported uninitialized variable.
2057
2058         * platform/network/qt/ResourceHandleManagerQt.cpp:
2059         (WebCore::FileLoader::request):
2060
2061 2007-01-12  Mitz Pettel  <mitz@webkit.org>
2062
2063         Reviewed by rwlbuis.
2064
2065         - add missing null check in new fixed table layout code
2066
2067         * rendering/FixedTableLayout.cpp:
2068         (WebCore::FixedTableLayout::calcWidthArray):
2069
2070 2007-01-12  Lars Knoll <lars@trolltech.com>
2071
2072         Fix the Qt build after the Authenitcation changes.
2073
2074         * WebCore.pro:
2075         * platform/network/ResourceHandleInternal.h:
2076
2077 2007-01-12  David Hyatt  <hyatt@apple.com>
2078
2079         Fix for bug 9569.  Make sure the selection offset for selection roots excludes border and padding.
2080
2081         Reviewed by Eric
2082
2083         * rendering/RenderBlock.cpp:
2084         (WebCore::RenderBlock::leftSelectionOffset):
2085         (WebCore::RenderBlock::rightSelectionOffset):
2086
2087 2007-01-11  David Hyatt  <hyatt@apple.com>
2088
2089         Fix for bug 8705, readonly text fields should not get focus rings.  Add a rule to that effect to
2090         html4.css and then also add readonly as a special case for style sharing so that we can retain the
2091         performance boost from sharing styles on inputs.
2092
2093         Reviewed by bdash
2094
2095         * css/cssstyleselector.cpp:
2096         (WebCore::CSSStyleSelector::canShareStyleWithElement):
2097         (WebCore::CSSStyleSelector::checkOneSelector):
2098         * css/html4.css:
2099
2100 2007-01-11  David Hyatt  <hyatt@apple.com>
2101
2102         Fix for bug 11595.  Autoscrolling of layers didn't really work at all unless the layer was coincidentally
2103         in the root layer's coordinate space.  The event point was an absolute position within the document, but
2104         the layer's rect was only local coords.  This patch makes sure to use absolute bounds for the layer
2105         when comparing it with the point.
2106
2107         This is covered by the scrollRevealButton test case already in the tree... the results change to be more
2108         correct.
2109
2110         Reviewed by ggaren
2111
2112         * rendering/RenderLayer.cpp:
2113         (WebCore::RenderLayer::scrollRectToVisible):
2114
2115 2007-01-11  Brady Eidson  <beidson@apple.com>
2116
2117         Reviewed by Oliver
2118
2119         -Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
2120         -Make more of ResourceLoader cross-platform
2121
2122         * loader/ResourceLoader.cpp:
2123         (WebCore::ResourceLoader::ResourceLoader):
2124         (WebCore::ResourceLoader::releaseResources):
2125         (WebCore::ResourceLoader::didCancel):
2126         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2127         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2128         (WebCore::ResourceLoader::receivedCancellation):
2129         * loader/ResourceLoader.h:
2130         (WebCore::ResourceLoader::willStopBufferingData):
2131         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2132         (WebCore::ResourceLoader::willCacheResponse):
2133         * loader/mac/ResourceLoaderMac.mm:
2134         * platform/network/ResourceHandle.h:
2135         * platform/network/ResourceHandleClient.h:
2136         (WebCore::ResourceHandleClient::willStopBufferingData):
2137         * platform/network/ResourceHandleInternal.h:
2138         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2139         * platform/network/mac/ResourceHandleMac.mm:
2140         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
2141         (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
2142         (WebCore::ResourceHandle::receivedCredential):
2143         (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
2144         (WebCore::ResourceHandle::receivedCancellation):
2145         (WebCore::ResourceHandle::clearAuthentication):
2146         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
2147         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
2148         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
2149         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
2150         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
2151
2152 2007-01-11  David Hyatt  <hyatt@apple.com>
2153
2154         A hit test is returning a null renderer.  Make sure to null-check it in the autoscroll code.
2155         This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
2156         on the front page of yahoo.com!
2157
2158         Reviewed by mark
2159
2160         * rendering/RenderLayer.cpp:
2161         (WebCore::RenderLayer::autoscroll):
2162
2163 2007-01-11  David Hyatt  <hyatt@apple.com>
2164
2165         Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
2166         shorthand (it can be mistaken for column-count otherwise).
2167
2168         Reviewed by Mark
2169
2170         fast/multicol/columns-shorthand-parsing.html
2171
2172         * css/cssparser.cpp:
2173         (WebCore::CSSParser::parseValue):
2174
2175 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2176
2177         Reviewed by Hyatt.
2178
2179         - fix http://bugs.webkit.org/show_bug.cgi?id=12124
2180           RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}
2181
2182         * rendering/RenderTable.cpp:
2183         (WebCore::resetSectionPointerIfNotBefore): Added this function to help with
2184         checking if a section being inserted is the going to be the first of its kind.
2185         (WebCore::RenderTable::addChild): Changed to maintain the pointers to the
2186         header, the footer, the caption and the first table body properly when objects
2187         are inserted in the middle. Also changed to make the first caption win over
2188         any other captions. This matches Firefox and what already used to happen when a
2189         section recalc took place.
2190         (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating
2191         over the sections from top to bottom.
2192         (WebCore::RenderTable::calcBorderLeft): Changed to really find the section
2193         containing the first row.
2194         (WebCore::RenderTable::calcBorderRight): Ditto.
2195         (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was
2196         skipped if the input was the footer.
2197         (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header"
2198         respectively.
2199
2200 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2201
2202         Reviewed by Hyatt.
2203
2204         - fix http://bugs.webkit.org/show_bug.cgi?id=12115
2205           RTL text is jumbled on display
2206
2207         Fixed fixed table layout. Implemented an algorithm that matches the behavior
2208         of Firefox, up to rounding errors.
2209
2210         Fixes three existing table tests.
2211
2212         * rendering/FixedTableLayout.cpp:
2213         Undid accidental search-and-replace of "width" to "m_width" in the comments.
2214         Removed an outdated comment, since WebKit no longer honors table-layout:fixed
2215         for variable-width tables.
2216         (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the
2217         first row. Changed to divide the width specified for a cell that spans multiple
2218         columns between the columns rather than assign its entire width to each column.
2219         (WebCore::FixedTableLayout::calcMinMaxWidth):
2220         (WebCore::FixedTableLayout::layout): Implemented the behavior observed in
2221         Firefox.
2222         * rendering/FixedTableLayout.h:
2223
2224 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2225
2226         Reviewed by Hyatt.
2227
2228         - fix http://bugs.webkit.org/show_bug.cgi?id=8438
2229           iExploder(#460): Assertion failure in RenderObject::drawBorder()
2230
2231         Test: fast/block/basic/fieldset-stretch-to-legend.html
2232
2233         * rendering/RenderBox.cpp:
2234         (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic
2235         width if the object requires it.
2236         (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup.
2237         (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum
2238         intrinsic width if the object requires it.
2239         * rendering/RenderBox.h:
2240         (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
2241         * rendering/RenderFieldset.cpp:
2242         (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's
2243         implementation to ensure that the legend's will fit in the fieldset's
2244         minimum intrinsic width.
2245         (WebCore::RenderFieldset::findLegend): Made const.
2246         (WebCore::RenderFieldset::paintBoxDecorations):
2247         (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when
2248         the legend does overflow the fieldset. This is the part of the fix that
2249         prevents the assertion failure. If the legend intersects with a corner of
2250         the fieldset's border, that corner will not be painted, even if it is not
2251         completely occluded. This edge case can be improved with clipping in the
2252         future. Added FIXME to implement border-radius.
2253         * rendering/RenderFieldset.h:
2254         (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to
2255         return true.
2256
2257 2007-01-11  Brady Eidson  <beidson@apple.com>
2258
2259         Reviewed by Build Fix Karma
2260
2261         I broke the release build (debug build passed)
2262
2263         * platform/network/mac/AuthenticationMac.mm:
2264         (WebCore::core):
2265
2266 2007-01-11  Brady Eidson  <beidson@apple.com>
2267
2268         Reviewed by Anders
2269
2270         Rewrites HTTP Authentication setting up a more platform-independent structure
2271
2272         * WebCore.exp:
2273         * WebCore.xcodeproj/project.pbxproj:
2274         * loader/FrameLoader.cpp:
2275         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2276         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2277         * loader/FrameLoader.h:
2278         * loader/FrameLoaderClient.h:
2279         * loader/ResourceLoader.cpp:
2280         (WebCore::ResourceLoader::ResourceLoader):
2281         (WebCore::ResourceLoader::didCancel):
2282         * loader/ResourceLoader.h:
2283         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2284         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2285         (WebCore::ResourceLoader::receivedCredential):
2286         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2287         (WebCore::ResourceLoader::receivedCancellation):
2288         * loader/mac/FrameLoaderMac.mm:
2289         * loader/mac/ResourceLoaderMac.mm:
2290         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2291         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2292         (WebCore::ResourceLoader::receivedCredential):
2293         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2294         (WebCore::ResourceLoader::receivedCancellation):
2295         * platform/graphics/svg/SVGImageEmptyClients.h:
2296         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2297         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
2298         * platform/network/ResourceHandleClient.h:
2299         (WebCore::ResourceHandleClient::willSendRequest):
2300         (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge):
2301         (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge):
2302         (WebCore::ResourceHandleClient::receivedCredential):
2303         (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential):
2304         (WebCore::ResourceHandleClient::receivedCancellation):
2305         (WebCore::ResourceHandleClient::willCacheResponse):
2306         * platform/network/ResourceResponse.h:
2307         (WebCore::operator!=):
2308         * platform/network/URLAuthenticationChallenge.cpp: Added.
2309         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
2310         (WebCore::URLAuthenticationChallenge::previousFailureCount):
2311         (WebCore::URLAuthenticationChallenge::proposedCredential):
2312         (WebCore::URLAuthenticationChallenge::protectionSpace):
2313         (WebCore::URLAuthenticationChallenge::failureResponse):
2314         (WebCore::URLAuthenticationChallenge::error):
2315         (WebCore::URLAuthenticationChallenge::isNull):
2316         (WebCore::URLAuthenticationChallenge::nullify):
2317         (WebCore::operator==):
2318         (WebCore::operator!=):
2319         * platform/network/URLAuthenticationChallenge.h: Added.
2320         (WebCore::URLAuthenticationChallenge::sender):
2321         (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
2322         * platform/network/URLCredential.cpp: Added.
2323         (WebCore::URLCredential::URLCredential):
2324         (WebCore::URLCredential::user):
2325         (WebCore::URLCredential::password):
2326         (WebCore::URLCredential::hasPassword):
2327         (WebCore::URLCredential::persistence):
2328         (WebCore::operator==):
2329         * platform/network/URLCredential.h: Added.
2330         (WebCore::):
2331         (WebCore::operator!=):
2332         * platform/network/URLProtectionSpace.cpp: Added.
2333         (WebCore::URLProtectionSpace::URLProtectionSpace):
2334         (WebCore::URLProtectionSpace::host):
2335         (WebCore::URLProtectionSpace::port):
2336         (WebCore::URLProtectionSpace::serverType):
2337         (WebCore::URLProtectionSpace::realm):
2338         (WebCore::URLProtectionSpace::authenticationScheme):
2339         (WebCore::operator==):
2340         * platform/network/URLProtectionSpace.h: Added.
2341         (WebCore::):
2342         (WebCore::operator!=):
2343         * platform/network/mac/AuthenticationMac.h: Added.
2344         * platform/network/mac/AuthenticationMac.mm: Added.
2345         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
2346         (WebCore::mac):
2347         (WebCore::core):
2348         * platform/network/mac/ResourceHandleMac.mm:
2349         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
2350         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
2351         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
2352         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
2353         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
2354         * platform/network/mac/ResourceResponseMac.mm:
2355         (WebCore::operator==):
2356
2357 2007-01-11  Geoffrey Garen  <ggaren@apple.com>
2358
2359         Reviewed by Anders Carlsson.
2360         
2361         Even more cleanup in preparation for fixing <rdar://problem/4608404> 
2362         WebScriptObject's _executionContext lack of ownership policy causes 
2363         crashes (e.g., in Dashcode)
2364         
2365         Layout tests pass.
2366         
2367         Renames:
2368             findRootObjectForNativeHandleFunction => createRootObject
2369             FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
2370             rootForView => createRootObject
2371             getInstanceForView => getPluginInstanceForWidget
2372
2373         * page/mac/FrameMac.mm:
2374         (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void*
2375         variable named "nativeHandle" to be more explicit about the fact that JavaScript's
2376         "nativeHandle" is just an NSView *.
2377
2378         (WebCore::getPluginInstanceForWidget): This function now does the NSView *
2379         fetching that its callers used to do.
2380         (WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
2381         (WebCore::FrameMac::getObjectInstanceForWidget): ditto
2382
2383         * page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category,
2384         which was really more of a shmategory.
2385         (createRootObject): Removed rootObjectForView, folding it into its only
2386         caller, the similarly named rootForView. Renamed the pair to "createRootObject"
2387         because that's what they do.
2388
2389         (-[WebCoreFrameBridge init]): Updated for renames
2390
2391 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2392
2393         Reviewed by Darin.
2394
2395         Fix crash on platforms that don't use the new loader yet.
2396         
2397         * loader/DocLoader.cpp:
2398         (WebCore::DocLoader::requestResource):
2399
2400 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2401
2402         Reviewed by Adam.
2403
2404         - fix http://bugs.webkit.org/show_bug.cgi?id=11449
2405           Type-to-select in unopened popups doesn't work with Hebrew
2406
2407         Test: fast/forms/select-type-ahead-non-latin.html
2408
2409         * html/HTMLSelectElement.cpp:
2410         (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific
2411         isprint() condition to a Unicode isPrintableChar().
2412
2413 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
2414
2415         Reviewed by geoff
2416         
2417         <rdar://problem/4889140>
2418         GMail Editor: List creation fails in new message
2419
2420         * editing/InsertListCommand.cpp:
2421         (WebCore::InsertListCommand::doApply): Inserting the list
2422         into an empty paragraph not held open by a br or a '\n', 
2423         will invalidate start and end.  Insert a placeholder and 
2424         then recompute start and end.
2425
2426 2007-01-11  Lars Knoll <lars@trolltech.com>
2427
2428         Rubberstamped by Anders
2429
2430         This one is not needed any longer neither.
2431
2432         * ChangeLog:
2433         * WebCore.pro:
2434         * loader/qt/NavigationActionQt.cpp: Removed.
2435
2436 2007-01-11  Lars Knoll <lars@trolltech.com>
2437
2438         Reviewed by Anders
2439
2440         Remove now unused file
2441
2442         * WebCore.pro:
2443         * loader/qt/LoaderFunctionsQt.cpp: Removed.
2444
2445 2007-01-11  David Kilzer  <ddkilzer@webkit.org>
2446
2447         Reviewed by NOBODY (build fix).
2448
2449         * loader/mac/FrameLoaderMac.mm:  Removed import of LoaderNSURLRequestExtras.h.
2450         * loader/mac/SubresourceLoaderMac.mm:  Ditto.
2451
2452 2007-01-11  George Staikos  <staikos@kde.org>
2453
2454         Fix compile.
2455
2456         * page/qt/FrameQtClient.cpp:
2457
2458 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2459
2460         Fix build.
2461         
2462         * dom/XMLTokenizer.cpp:
2463         * loader/CachedCSSStyleSheet.cpp:
2464         * loader/CachedImage.cpp:
2465         * loader/DocLoader.cpp:
2466         * loader/loader.cpp:
2467         * xml/XSLTProcessor.cpp:
2468         * xml/xmlhttprequest.cpp:
2469
2470 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2471
2472         Reviewed by Adam.
2473
2474         Loader cleanup, get rid of unused code.
2475         
2476         * WebCore.xcodeproj/project.pbxproj:
2477         * loader/CachedResource.h:
2478         * loader/DocLoader.cpp:
2479         (WebCore::DocLoader::requestResource):
2480         (WebCore::DocLoader::checkCacheObjectStatus):
2481         * loader/DocLoader.h:
2482         * loader/LoaderFunctions.h: Removed.
2483         * loader/mac/CachedResourceMac.mm: Removed.
2484         * loader/mac/LoaderFunctionsMac.mm: Removed.
2485         * loader/mac/LoaderNSURLRequestExtras.h: Removed.
2486         * loader/mac/LoaderNSURLRequestExtras.m: Removed.
2487         * loader/mac/SubresourceLoaderMac.mm:
2488         * page/mac/WebCoreFrameBridge.mm:
2489         * platform/network/ResourceHandle.cpp:
2490
2491 2007-01-11  Beth Dakin  <bdakin@apple.com>
2492
2493         Reviewed by Adam.
2494
2495         Fix for http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION: 
2496         <input> and <textarea> not focused on right click (4908884 in 
2497         Radar)
2498
2499         * page/EventHandler.cpp:
2500         (WebCore::EventHandler::sendContextMenuEvent): Since WebcCore now 
2501         handles the context menu event, we want to ask if we *have* 
2502         swallowed the event instead of if we *haven't* when deciding to 
2503         perform a selection. In the past, WebKit handled the event, so 
2504         swallowEvent was false in the case where we want to pop up a menu. 
2505
2506 2007-01-11  Darin Adler  <darin@apple.com>
2507
2508         Reviewed by Anders.
2509
2510         - fix http://bugs.webkit.org/show_bug.cgi?id=12189
2511           REGRESSION(r18614-18640): Crash in WebCore::SharedBuffer::hasPlatformData()
2512
2513         * loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
2514         Added null check.
2515
2516 2007-01-11  Darin Adler  <darin@apple.com>
2517
2518         * platform/CharacterNames.h: Oops! horizontalEllipsis != zeroWidthSpace!
2519
2520 2007-01-11  Lars Knoll <lars@trolltech.com>
2521
2522         Reviewed by Darin.
2523
2524         Start using the loader in the Qt port.
2525
2526         * loader/FrameLoader.cpp:
2527         (WebCore::FrameLoader::clear):
2528         (WebCore::FrameLoader::URL):
2529         (WebCore::FrameLoader::createEmptyDocument):
2530         * loader/qt/FrameLoaderQt.cpp:
2531         (WebCore::FrameLoader::setTitle):
2532         (WebCore::FrameLoader::originalRequestURL):
2533         (WebCore::FrameLoader::referrer):
2534         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2535         * page/qt/FrameQtClient.cpp:
2536         (WebCore::FrameQtClient::openURL):
2537
2538 2007-01-11  Darin Adler  <darin@apple.com>
2539
2540         Reviewed by Hyatt.
2541
2542         - removed a couple Mac bridging classes; put the code in WebKit instead
2543
2544         * WebCore.exp: Updated for new WebKit uses.
2545
2546         * WebCore.xcodeproj/project.pbxproj: Removed files.
2547         * bridge/mac/WebCoreEncodings.h: Removed.
2548         * bridge/mac/WebCoreEncodings.mm: Removed.
2549         * bridge/mac/WebMimeTypeRegistryBridge.h: Removed.
2550         * bridge/mac/WebMimeTypeRegistryBridge.mm: Removed.
2551         * platform/mac/WebNSAttributedStringExtras.h: Removed.
2552         * platform/mac/WebNSAttributedStringExtras.mm: Removed.
2553
2554         * platform/mac/PasteboardMac.mm:
2555         (WebCore::stripAttachmentCharacters): Added. Moved code from
2556         WebNSAttributedStringExtras.mm, and fixed a garbage collection problem
2557         (a global with a plain old retain rather than HardRetain).
2558         (WebCore::Pasteboard::writeSelection): Updated to use stripAttachmentCharacters.
2559
2560         - removed some DeprecatedCString use
2561
2562         * loader/FrameLoader.cpp: Changed to use String more to eliminate use of
2563         DeprecatedCString here in the mailto form support. But maybe we can remove
2564         this entirely. Do we really care about mailto forms any more?
2565
2566         * platform/Pasteboard.h: Removed unneeded DeprecatedCString declaration.
2567
2568         * platform/PlatformString.h: Added replace that takes two strings.
2569         * platform/StringImpl.h: Ditto.
2570         * platform/StringImpl.cpp: (WebCore::StringImpl::replace): Ditto.
2571
2572         * platform/TextStream.h: Remove DeprecatedCString case.
2573         * platform/TextStream.cpp: Ditto.
2574
2575         - made a few more files use CharacterNames.h
2576
2577         * platform/CharacterNames.h: Added some more character names and
2578         sorted alphabetically.
2579
2580         * bridge/mac/WebCoreStringTruncator.mm:
2581         (centerTruncateToBuffer): Use character name from CharacterNames.h.
2582         (rightTruncateToBuffer): Ditto.
2583         (truncateString): Ditto.
2584         * platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): Ditto.
2585         * rendering/RenderFlexibleBox.cpp:
2586         (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
2587         * rendering/bidi.cpp:
2588         (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto.
2589
2590 2007-01-11  David Hyatt  <hyatt@apple.com>
2591
2592         Fix two bugs in positionForCoordinates.  (Make it work when you have a margin in between your border and
2593         your first child block.)
2594
2595         Rewrite column rebalancing to have two modes: constrained and unconstrained.  In unconstrained mode,
2596         the system will dynamically rebalance as it loses space to breaks and compute a final intrinsic height
2597         for the overall block.  In constrained mode, columns flow into the fixed height block, and extra columns
2598         spill out horizontally in the appropriate direction (RTL/LTR).
2599
2600         Make columns work properly with both LTR and RTL overflow blocks.
2601
2602         Initial column test suite coming soon now that the basic layout is right.
2603
2604         Reviewed by darin
2605
2606         * rendering/RenderBlock.cpp:
2607         (WebCore:::RenderFlow):
2608         (WebCore::RenderBlock::layoutBlock):
2609         (WebCore::RenderBlock::paintColumns):
2610         (WebCore::RenderBlock::lowestPosition):
2611         (WebCore::RenderBlock::rightmostPosition):
2612         (WebCore::RenderBlock::leftmostPosition):
2613         (WebCore::RenderBlock::hitTestColumns):
2614         (WebCore::RenderBlock::positionForCoordinates):
2615         (WebCore::RenderBlock::availableWidth):
2616         (WebCore::RenderBlock::calcColumnWidth):
2617         (WebCore::RenderBlock::layoutColumns):
2618         (WebCore::RenderBlock::adjustPointToColumnContents):
2619         * rendering/RenderBlock.h:
2620         (WebCore::RenderBlock::hasColumns):
2621
2622 2007-01-10  Rob Buis  <buis@kde.org>
2623
2624         Reviewed by Eric.
2625
2626         http://bugs.webkit.org/show_bug.cgi?id=12201
2627         Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg
2628
2629         Fix calculation of absolute transform so that viewport x,y
2630         translation is always done, also when viewBox is set.     
2631
2632         * rendering/RenderSVGContainer.cpp:
2633         (WebCore::RenderSVGContainer::paint):
2634         (WebCore::RenderSVGContainer::viewportTransform):
2635         (WebCore::RenderSVGContainer::absoluteTransform):
2636
2637 2007-01-10  David Hyatt  <hyatt@apple.com>
2638
2639         Rework positionForCoordinates to be more efficient and to handle multi-column content.  This entailed
2640         adding a new field to HitTestResult called localPoint that cached the mouse coordinate in the coordinate
2641         space of the renderer.
2642
2643         positionForCoordinates now takes local coordinates and so no longer needs to waste time recomputing
2644         absolute positions over and over again.
2645
2646         Reviewed by darin
2647
2648         * bridge/mac/WebCoreAXObject.mm:
2649         (-[WebCoreAXObject value]):
2650         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
2651         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
2652         * dom/Document.cpp:
2653         (WebCore::Document::prepareMouseEvent):
2654         * editing/SelectionController.cpp:
2655         (WebCore::SelectionController::contains):
2656         * editing/visible_units.cpp:
2657         (WebCore::previousLinePosition):
2658         (WebCore::nextLinePosition):
2659         * page/EventHandler.cpp:
2660         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
2661         (WebCore::EventHandler::handleMousePressEventDoubleClick):
2662         (WebCore::EventHandler::handleMousePressEventTripleClick):
2663         (WebCore::EventHandler::handleMousePressEventSingleClick):
2664         (WebCore::EventHandler::handleMouseMoveEvent):
2665         (WebCore::EventHandler::handleMouseReleaseEvent):
2666         (WebCore::EventHandler::sendContextMenuEvent):
2667         * page/EventHandler.h:
2668         * page/MouseEventWithHitTestResults.cpp:
2669         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2670         * page/MouseEventWithHitTestResults.h:
2671         (WebCore::MouseEventWithHitTestResults::localPoint):
2672         * page/mac/WebCoreFrameBridge.mm:
2673         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
2674         * rendering/EllipsisBox.cpp:
2675         (WebCore::EllipsisBox::nodeAtPoint):
2676         * rendering/HitTestResult.h:
2677         (WebCore::HitTestResult::localPoint):
2678         (WebCore::HitTestResult::setLocalPoint):
2679         * rendering/InlineFlowBox.cpp:
2680         (WebCore::InlineFlowBox::nodeAtPoint):
2681         * rendering/InlineTextBox.cpp:
2682         (WebCore::InlineTextBox::nodeAtPoint):
2683         * rendering/RenderBlock.cpp:
2684         (WebCore::RenderBlock::nodeAtPoint):
2685         (WebCore::RenderBlock::hitTestContents):
2686         (WebCore::RenderBlock::positionForCoordinates):
2687         * rendering/RenderBox.cpp:
2688         (WebCore::RenderBox::nodeAtPoint):
2689         * rendering/RenderContainer.cpp:
2690         (WebCore::RenderContainer::positionForCoordinates):
2691         * rendering/RenderFlow.cpp:
2692         (WebCore::RenderFlow::hitTestLines):
2693         * rendering/RenderInline.cpp:
2694         (WebCore::RenderInline::positionForCoordinates):
2695         * rendering/RenderLayer.cpp:
2696         (WebCore::RenderLayer::autoscroll):
2697         (WebCore::RenderLayer::hitTestLayer):
2698         * rendering/RenderObject.cpp:
2699         (WebCore::RenderObject::updateHitTestResult):
2700         * rendering/RenderObject.h:
2701         * rendering/RenderPath.cpp:
2702         (WebCore::RenderPath::nodeAtPoint):
2703         * rendering/RenderReplaced.cpp:
2704         (WebCore::RenderReplaced::positionForCoordinates):
2705         * rendering/RenderTableRow.cpp:
2706         (WebCore::RenderTableRow::nodeAtPoint):
2707         * rendering/RenderTableSection.cpp:
2708         (WebCore::RenderTableSection::nodeAtPoint):
2709         * rendering/RenderText.cpp:
2710         (WebCore::RenderText::positionForCoordinates):
2711         * rendering/RootInlineBox.cpp:
2712         (WebCore::RootInlineBox::nodeAtPoint):
2713         (WebCore::RootInlineBox::closestLeafChildForXPos):
2714         * rendering/RootInlineBox.h:
2715
2716 2007-01-11  George Staikos  <staikos@kde.org>
2717
2718         Reviewed by Maciej.
2719
2720         Fix Qt Build.
2721
2722         * loader/qt/DocumentLoaderQt.cpp:
2723         (WebCore::DocumentLoader::getResponseModifiedHeader):
2724
2725 2007-01-10  Kirby White  <KWhiteRight@gmail.com>
2726
2727         Reviewed by Darin.
2728
2729         Fixes for http://bugs.webkit.org/show_bug.cgi?id=11841
2730
2731         Set image size to fit alt text when image or input-image element
2732         has no src attribute, so that those images show their alt text instead
2733         of showing nothing at all.
2734
2735         * html/HTMLImageElement.cpp:
2736         (WebCore::HTMLImageElement::attach):
2737         * html/HTMLInputElement.cpp:
2738         (WebCore::HTMLInputElement::attach):
2739         * rendering/RenderImage.cpp:
2740         (WebCore::RenderImage::setImageSizeForAltText):
2741         (WebCore::RenderImage::imageChanged):
2742         * rendering/RenderImage.h:
2743
2744 2007-01-11  Mark Rowe  <mrowe@apple.com>
2745
2746         Build fix.
2747
2748         * rendering/RenderView.cpp:
2749         (WebCore::RenderView::printing):
2750
2751 2007-01-10  Mitz Pettel  <mitz@webkit.org>
2752
2753         Reviewed by Darin.
2754
2755         - fix http://bugs.webkit.org/show_bug.cgi?id=9284
2756           Quirksmode (CSS1): Removing inline border styles is impossible
2757
2758         Test: fast/css/remove-shorthand.html
2759
2760         * css/CSSMutableStyleDeclaration.cpp:
2761         (WebCore::PropertyLonghand::PropertyLonghand): Added this structure
2762         containing a pointer to an array if properties and the array's length.
2763         (WebCore::PropertyLonghand::properties):
2764         (WebCore::PropertyLonghand::length):
2765         (WebCore::initShorthandMap): Initialize the mapping from shorthand
2766         properties to their dependent properties.
2767         (WebCore::CSSMutableStyleDeclaration::removeProperty): Changed to check
2768         if the property being removed is a shorthand, and if so, to remove all
2769         of its dependent properties.
2770         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): Added a
2771         'notifyChanged' boolean parameter which controls whether this method
2772         calls setChanged() if it actually removes any property.
2773         * css/CSSMutableStyleDeclaration.h:
2774
2775 2007-01-10  Steve Falkenburg  <sfalken@apple.com>
2776
2777         Reviewed by Kevin.
2778
2779         Removed unnecessary printing state
2780
2781         * page/FrameView.cpp:
2782         (WebCore::FrameView::layout):
2783         * page/mac/WebCoreFrameBridge.mm:
2784         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
2785         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
2786         (-[WebCoreFrameBridge drawRect:]):
2787         (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
2788         (-[WebCoreFrameBridge adjustPageHeightNew:top:bottom:limit:]):
2789         * rendering/RenderLayer.cpp:
2790         (WebCore::RenderLayer::updateLayerPositions):
2791         * rendering/RenderObject.cpp:
2792         (WebCore::RenderObject::repaint):
2793         (WebCore::RenderObject::repaintRectangle):
2794         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
2795         * rendering/RenderView.cpp:
2796         (WebCore::RenderView::RenderView):
2797         (WebCore::RenderView::calcHeight):
2798         (WebCore::RenderView::calcWidth):
2799         (WebCore::RenderView::layout):
2800         (WebCore::RenderView::paint):
2801         (WebCore::RenderView::repaintViewRectangle):
2802         (WebCore::RenderView::computeAbsoluteRepaintRect):
2803         (WebCore::RenderView::printing):
2804         (WebCore::RenderView::viewRect):
2805         (WebCore::RenderView::docHeight):
2806         (WebCore::RenderView::docWidth):
2807         * rendering/RenderView.h:
2808         * rendering/RenderWidget.cpp:
2809         (WebCore::RenderWidget::updateWidgetPosition):
2810         * rendering/bidi.cpp:
2811         (WebCore::RenderBlock::layoutInlineChildren):
2812
2813 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2814
2815         Reviewed by Maciej.
2816
2817         Get the Refresh header directly from the ResourceResponse.
2818         
2819         * loader/DocumentLoader.h:
2820         * loader/FrameLoader.cpp:
2821         (WebCore::FrameLoader::commitProvisionalLoad):
2822         * loader/mac/DocumentLoaderMac.mm:
2823         (WebCore::DocumentLoader::getResponseModifiedHeader):
2824
2825 2007-01-10  Beth Dakin  <bdakin@apple.com>
2826
2827         Reviewed by John.
2828
2829         Fix for <rdar://problem/4914258> REGRESSION: Search in Google now 
2830         operates on the current WebView instead of invoking Safari's 
2831         service
2832
2833         * page/ContextMenuClient.h: New call to the client to search in 
2834         google.
2835         * page/ContextMenuController.cpp:
2836         (WebCore::ContextMenuController::contextMenuItemSelected): Call 
2837         into the client instead of forming a new url string and loading it.
2838         * platform/graphics/svg/SVGImageEmptyClients.h:
2839         (WebCore::SVGEmptyContextMenuClient::searchWithGoogle): New call.
2840
2841 2007-01-10  Adam Roben  <aroben@apple.com>
2842
2843         Rubberstamped by Darin.
2844
2845         * page/ContextMenuController.cpp:
2846         (WebCore::ContextMenuController::contextMenuItemSelected): Pass 0
2847         instead of an empty Event to FrameLoader::load and
2848         FrameLoader::urlSelected.
2849
2850 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2851
2852         * loader/ResourceLoader.cpp:
2853         (WebCore::ResourceLoader::~ResourceLoader):
2854         Disable assertion (I forgot to do this even though I added the comment!)
2855
2856 2007-01-10  Ross Burton  <ross@burtonini.com>
2857
2858         Reviewed and landed by Anders.
2859
2860         Fix case in vcproj file (the GTK+ port uses the vcproj file).
2861
2862         * WebCore.vcproj/WebCore/WebCore.vcproj:
2863
2864 2007-01-10  Lars Knoll  <lars@trolltech.com>
2865
2866         Make the Qt build compile again after 
2867         the ResourceLoader was made platform
2868         independent. 
2869
2870         * WebCore.pro:
2871         * loader/FrameLoader.cpp:
2872         (WebCore::FrameLoader::didFirstLayout):
2873         * loader/qt/FrameLoaderQt.cpp:
2874         * loader/qt/MainResourceLoaderQt.cpp: Removed.
2875         * loader/qt/ResourceLoaderQt.cpp: Removed.
2876         * page/qt/FrameQtClient.cpp:
2877         (WebCore::FrameQtClient::openURL):
2878         * platform/network/qt/ResourceHandleQt.cpp:
2879         (WebCore::ResourceHandle::setDefersLoading):
2880
2881 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2882
2883         Rubber-stamped by Maciej.
2884         
2885         Move most of ResourceLoader and MainResourceLoader into the platform-independent files.
2886         
2887         * WebCore.xcodeproj/project.pbxproj:
2888         * loader/FrameLoader.cpp:
2889         (WebCore::FrameLoader::didFinishLoad):
2890         * loader/MainResourceLoader.cpp:
2891         (WebCore::MainResourceLoader::MainResourceLoader):
2892         (WebCore::MainResourceLoader::~MainResourceLoader):
2893         (WebCore::MainResourceLoader::create):
2894         (WebCore::MainResourceLoader::receivedError):
2895         (WebCore::MainResourceLoader::didCancel):
2896         (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
2897         (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
2898         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2899         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2900         (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
2901         (WebCore::MainResourceLoader::addData):
2902         (WebCore::MainResourceLoader::willSendRequest):
2903         (WebCore::shouldLoadAsEmptyDocument):
2904         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2905         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2906         (WebCore::MainResourceLoader::didReceiveResponse):
2907         (WebCore::MainResourceLoader::didReceiveData):
2908         (WebCore::MainResourceLoader::didFinishLoading):
2909         (WebCore::MainResourceLoader::didFail):
2910         (WebCore::MainResourceLoader::loadNow):
2911         (WebCore::MainResourceLoader::load):
2912         (WebCore::MainResourceLoader::setDefersLoading):
2913         * loader/MainResourceLoader.h:
2914         * loader/ResourceLoader.cpp:
2915         (WebCore::ResourceLoader::ResourceLoader):
2916         (WebCore::ResourceLoader::~ResourceLoader):
2917         (WebCore::ResourceLoader::releaseResources):
2918         (WebCore::ResourceLoader::load):
2919         (WebCore::ResourceLoader::setDefersLoading):
2920         (WebCore::ResourceLoader::frameLoader):
2921         (WebCore::ResourceLoader::addData):
2922         (WebCore::ResourceLoader::clearResourceData):
2923         (WebCore::ResourceLoader::willSendRequest):
2924         (WebCore::ResourceLoader::didReceiveResponse):
2925         (WebCore::ResourceLoader::didReceiveData):
2926         (WebCore::ResourceLoader::willStopBufferingData):
2927         (WebCore::ResourceLoader::didFinishLoading):
2928         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2929         (WebCore::ResourceLoader::didFail):
2930         (WebCore::ResourceLoader::didCancel):
2931         (WebCore::ResourceLoader::cancel):
2932         (WebCore::ResourceLoader::response):
2933         (WebCore::ResourceLoader::cancelledError):
2934         * loader/ResourceLoader.h:
2935         (WebCore::ResourceLoader::willStopBufferingData):
2936         (WebCore::ResourceLoader::setRequest):
2937         * loader/mac/FrameLoaderMac.mm:
2938         * loader/mac/MainResourceLoaderMac.mm: Removed.
2939         * loader/mac/ResourceLoaderMac.mm:
2940
2941 2007-01-10  Lars Knoll <lars@trolltech.com>
2942
2943         Move files to the correct location,
2944         and remove a few unused methods from 
2945         LoaderFunctionsQt.cpp
2946
2947         * WebCore.pro:
2948         * loader/qt/LoaderFunctionsQt.cpp: Added.
2949         (WebCore::CheckCacheObjectStatus):
2950         * page/qt/FrameQt.cpp: Added.
2951         (WebCore::doScroll):
2952         (WebCore::FrameQt::FrameQt):
2953         (WebCore::FrameQt::~FrameQt):
2954         (WebCore::FrameQt::passMouseDownEventToWidget):
2955         (WebCore::FrameQt::isLoadTypeReload):
2956         (WebCore::FrameQt::markedTextRange):
2957         (WebCore::FrameQt::mimeTypeForFileName):
2958         (WebCore::FrameQt::unfocusWindow):
2959         (WebCore::FrameQt::focusWindow):
2960         (WebCore::FrameQt::getEmbedInstanceForWidget):
2961         (WebCore::FrameQt::getObjectInstanceForWidget):
2962         (WebCore::FrameQt::getAppletInstanceForWidget):
2963         (WebCore::FrameQt::issueCutCommand):
2964         (WebCore::FrameQt::issueCopyCommand):
2965         (WebCore::FrameQt::issuePasteCommand):
2966         (WebCore::FrameQt::issuePasteAndMatchStyleCommand):
2967         (WebCore::FrameQt::issueTransposeCommand):
2968         (WebCore::FrameQt::respondToChangedSelection):
2969         (WebCore::FrameQt::shouldChangeSelection):
2970         (WebCore::FrameQt::print):
2971         (WebCore::FrameQt::shouldInterruptJavaScript):
2972         (WebCore::FrameQt::keyEvent):
2973         (WebCore::FrameQt::setFrameGeometry):
2974         (WebCore::FrameQt::client):
2975         (WebCore::FrameQt::createNewWindow):
2976         (WebCore::FrameQt::goBackOrForward):
2977         (WebCore::FrameQt::historyURL):
2978         (WebCore::FrameQt::runJavaScriptAlert):
2979         (WebCore::FrameQt::runJavaScriptConfirm):
2980         (WebCore::FrameQt::runJavaScriptPrompt):
2981         (WebCore::FrameQt::bindingRootObject):
2982         (WebCore::FrameQt::addPluginRootObject):
2983         * page/qt/FrameQt.h: Added.
2984         (WebCore::QtFrame):
2985         * page/qt/FrameQtClient.cpp: Added.
2986         (WebCore::FrameQtClient::FrameQtClient):
2987         (WebCore::FrameQtClient::~FrameQtClient):
2988         (WebCore::FrameQtClient::setFrame):
2989         (WebCore::FrameQtClient::openURL):
2990         (WebCore::FrameQtClient::submitForm):
2991         (WebCore::FrameQtClient::didReceiveResponse):
2992         (WebCore::FrameQtClient::didFinishLoading):
2993         (WebCore::FrameQtClient::didFail):
2994         (WebCore::FrameQtClient::didReceiveData):
2995         (WebCore::FrameQtClient::traverseNextFrameStayWithin):
2996         (WebCore::numRequests):
2997         (WebCore::FrameQtClient::numPendingOrLoadingRequests):
2998         * page/qt/FrameQtClient.h: Added.
2999         * platform/qt/FrameQt.cpp: Removed.
3000         * platform/qt/FrameQt.h: Removed.
3001         * platform/qt/FrameQtClient.cpp: Removed.
3002         * platform/qt/FrameQtClient.h: Removed.
3003         * platform/qt/LoaderFunctionsQt.cpp: Removed.
3004
3005 2007-01-10  Adam Roben  <aroben@apple.com>
3006
3007         Reviewed by Geoff.
3008
3009         Fix: <rdar://problem/4917054> ContextMenuController leaks Events
3010
3011         No layout tests possible.
3012
3013         * page/ContextMenuController.cpp:
3014         (WebCore::ContextMenuController::contextMenuItemSelected): Use RefPtr
3015         to manage the lifetime of Shared objects.
3016
3017 2007-01-10  Rob Buis  <buis@kde.org>
3018
3019         Reviewed by Sam.
3020
3021         http://bugs.webkit.org/show_bug.cgi?id=12196
3022         SVGPatternElement should not be locatable
3023
3024         Replace SVGStyledLocatableElement derivation with
3025         SVGStyledElement.
3026
3027         * ksvg2/svg/SVGPatternElement.cpp:
3028         (WebCore::SVGPatternElement::SVGPatternElement):
3029         * ksvg2/svg/SVGPatternElement.h:
3030
3031 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
3032
3033         Build fix, not reviewed.
3034
3035         * rendering/RenderSVGText.cpp: Use correct method name.
3036         (WebCore::RenderSVGText::relativeBBox):
3037
3038 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
3039
3040         Reviewed by Eric.
3041
3042         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10262 (SVG fails to redraw top 20 pixels)
3043         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10263 (SVG seems to repaint way too many times during load)
3044         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10404 (Invalidation issues with text skew)
3045         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10407 (bad SVG text invalidation issues on mouseover/mouseout)
3046         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10806 (failing manual-tests/svg-repaint-group.svg)
3047         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10913 (SVG charts from plotkit fail to render unless you scroll them offscreen)
3048         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10964 (inclusion of svg into svg leave a ghost invisible rectangle)
3049         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11680 (DojoKit SVG test chart fails to render (clipping issue?))
3050         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11883 (SVG Text has updating/repainting issues)
3051         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11907 (RenderSVGContainer does not mark itself for repaint after setting viewBox, slice or align) 
3052         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11913 (Invalidation issues in SVG javascript-based animation example)
3053         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11979 (SVG text does not respect font-size scaling in bbox calculation)
3054         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11984 (SVG <text> does not calculate the correct absoluteRepaintRect)
3055         Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=10745 (SVG layout needs to move out of DOM and into rendering tree during layout() call)
3056
3057         Fixes text redrawing issues seen in svg/carto.net (when actually playing with those files, manually)
3058         Fixes svg/carto.net/window.svg (moving "Navigation Window" caused artefacts)
3059         Fixes svg/W3C-SVG-1.1/types-basicDOM-01-b.svg (bbox calculations had one pixel offset)
3060
3061         Large SVG dynamic update rework/optimization. Also fixes SVG printing.
3062
3063         Rename updateCanvasItem() to rebuildRenderer(), as this is what it really does.
3064
3065         Do NOT call rebuildRenderer() in notifyAttributeChange() anymore,
3066         but override notifyAttributeChange() in SVGPathElement/SVGCircleElement/etc..
3067         (as only primitives using RenderPath as rendering object need this logic!)
3068
3069         This should clarify what really happens, as discussed with Eric.
3070
3071         Remove the invocations of notifyAttributeChange() in SVGLength. It's already
3072         handled by the JS bindings, and we do double updating work. Fixed.
3073
3074         Because SVG dynamic updates have been flaky in the past, there was a hack introduced
3075         in RenderPath causing the updateCanvasItem() function to be called _on every layout_ (!!!).
3076         Finally this hack is gone. Offer RenderSVGContainer::absoluteRects() function to be able
3077         to use WebInspector for <g> elements (very handy!).
3078
3079         Remove the unneeded "m_updateVectorial" bool from SVGStyledElement.
3080         Remove computeAbsoluteRepaintRect() from RenderSVGContainer/RenderSVGImage/RenderSVGText,
3081         as dicussed with David (we only need to reimplement getAbsoluteRepaintRect there).
3082
3083         Make RenderSVGText::absoluteRects just use the getAbsoluteRepaintRect() function, instead of
3084         code duplication. Remove unneeded RenderSVGImage::layout() function (RenderImage does the same).
3085
3086         Add new function SVGStyledElement::renderStyleForElement, which centralizes the manual style
3087         resolving needed for gradient stops.
3088
3089         * ksvg2/svg/SVGCircleElement.cpp:
3090         (WebCore::SVGCircleElement::notifyAttributeChange):
3091         (WebCore::SVGCircleElement::hasRelativeValues):
3092         * ksvg2/svg/SVGCircleElement.h:
3093         * ksvg2/svg/SVGEllipseElement.cpp:
3094         (WebCore::SVGEllipseElement::notifyAttributeChange):
3095         (WebCore::SVGEllipseElement::hasRelativeValues):
3096         * ksvg2/svg/SVGEllipseElement.h:
3097         * ksvg2/svg/SVGImageElement.cpp:
3098         (WebCore::SVGImageElement::notifyAttributeChange):
3099         * ksvg2/svg/SVGImageElement.h:
3100         * ksvg2/svg/SVGLength.cpp:
3101         (WebCore::SVGLength::setValue):
3102         (WebCore::SVGLength::setValueInSpecifiedUnits):
3103         * ksvg2/svg/SVGLength.h:
3104         (WebCore::SVGLength::isRelative):
3105         * ksvg2/svg/SVGLineElement.cpp:
3106         (WebCore::SVGLineElement::notifyAttributeChange):
3107         (WebCore::SVGLineElement::hasRelativeValues):
3108         * ksvg2/svg/SVGLineElement.h:
3109         * ksvg2/svg/SVGLocatable.cpp:
3110         (WebCore::SVGLocatable::getBBox):
3111         * ksvg2/svg/SVGPathElement.cpp:
3112         (WebCore::SVGPathElement::notifyAttributeChange):
3113         * ksvg2/svg/SVGPathElement.h:
3114         * ksvg2/svg/SVGPolyElement.cpp:
3115         (WebCore::SVGPolyElement::notifyAttributeChange):
3116         * ksvg2/svg/SVGPolyElement.h:
3117         (WebCore::SVGPolyElement::rendererIsNeeded):
3118         * ksvg2/svg/SVGRectElement.cpp:
3119         (WebCore::SVGRectElement::notifyAttributeChange):
3120         (WebCore::SVGRectElement::hasRelativeValues):
3121         * ksvg2/svg/SVGRectElement.h:
3122         * ksvg2/svg/SVGSVGElement.cpp:
3123         (WebCore::SVGSVGElement::hasRelativeValues):
3124         * ksvg2/svg/SVGSVGElement.h:
3125         * ksvg2/svg/SVGStyledElement.cpp:
3126         (WebCore::SVGStyledElement::SVGStyledElement):
3127         (WebCore::SVGStyledElement::createRenderer):
3128         (WebCore::SVGStyledElement::notifyAttributeChange):
3129         (WebCore::SVGStyledElement::rebuildRenderer):
3130         * ksvg2/svg/SVGStyledElement.h:
3131         (WebCore::SVGStyledElement::hasRelativeValues):
3132         * rendering/RenderPath.cpp:
3133         (WebCore::RenderPath::setLocalTransform):
3134         (WebCore::RenderPath::fillContains):
3135         (WebCore::RenderPath::relativeBBox):
3136         (WebCore::RenderPath::layout):
3137         (WebCore::RenderPath::getAbsoluteRepaintRect):
3138         (WebCore::RenderPath::paint):
3139         (WebCore::RenderPath::nodeAtPoint):
3140         (WebCore::drawMarkerWithData):
3141         (WebCore::updateMarkerDataForElement):
3142         (WebCore::drawStartAndMidMarkers):
3143         (WebCore::RenderPath::drawMarkersIfNeeded):
3144         (WebCore::RenderPath::hasRelativeValues):
3145         * rendering/RenderPath.h:
3146         * rendering/RenderSVGContainer.cpp:
3147         (WebCore::RenderSVGContainer::layout):
3148         (WebCore::RenderSVGContainer::paint):
3149         (WebCore::RenderSVGContainer::calcViewport):
3150         (WebCore::RenderSVGContainer::setViewBox):
3151         (WebCore::RenderSVGContainer::setAlign):
3152         (WebCore::RenderSVGContainer::viewportTransform):
3153         (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
3154         (WebCore::RenderSVGContainer::absoluteRects):
3155         (WebCore::RenderSVGContainer::fillContains):
3156         (WebCore::RenderSVGContainer::strokeContains):
3157         (WebCore::RenderSVGContainer::relativeBBox):
3158         (WebCore::RenderSVGContainer::setSlice):
3159         * rendering/RenderSVGContainer.h:
3160         * rendering/RenderSVGImage.cpp:
3161         (WebCore::RenderSVGImage::RenderSVGImage):
3162         (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
3163         (WebCore::RenderSVGImage::relativeBBox):
3164         (WebCore::RenderSVGImage::imageChanged):
3165         (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
3166         (WebCore::RenderSVGImage::absoluteRects):
3167         * rendering/RenderSVGImage.h:
3168         * rendering/RenderSVGText.cpp:
3169         (WebCore::RenderSVGText::getAbsoluteRepaintRect):
3170         (WebCore::RenderSVGText::layout):
3171         (WebCore::RenderSVGText::createInlineBox):
3172         (WebCore::RenderSVGText::absoluteRects):
3173         (WebCore::RenderSVGText::relativeBBox):
3174         * rendering/RenderSVGText.h:
3175         * rendering/SVGInlineFlowBox.cpp:
3176         (WebCore::placePositionedBoxesHorizontally):
3177
3178 2007-01-10  David Hyatt  <hyatt@apple.com>
3179
3180         Make the selectionRect() method of RenderText better by reusing computeAbsoluteRepaintRect.  This enables
3181         the method to be multi-column aware and also to understand when the selection is clipped out by overflow.
3182
3183         Reviewed by bdash
3184
3185         * rendering/RenderText.cpp:
3186         (WebCore::RenderText::selectionRect):
3187
3188 2007-01-10  David Hyatt  <hyatt@apple.com>
3189
3190         Make the absolutePosition method multi-column aware.  Note that there is now a real problem with the
3191         absoluteRects method, since an object can split across multiple columns and break into multiple rects.
3192         absolutePosition just returns the top-left corner of the element's box in the first column in which it
3193         appears.
3194
3195         Reviewed by bdash
3196
3197         * rendering/RenderBlock.cpp:
3198         (WebCore::RenderBlock::adjustRectForColumns):
3199         * rendering/RenderBlock.h:
3200         * rendering/RenderBox.cpp:
3201         (WebCore::RenderBox::absolutePosition):
3202         (WebCore::RenderBox::computeAbsoluteRepaintRect):
3203         * rendering/RenderFlow.cpp:
3204         (WebCore::RenderFlow::getAbsoluteRepaintRect):
3205
3206 2007-01-09  David Hyatt  <hyatt@apple.com>
3207
3208         Avoid crashing when repainting multiple columns... make sure to use the current vector's size and
3209         not the newly-computed column count.
3210
3211         * rendering/RenderBlock.cpp:
3212         (WebCore::RenderBlock::layoutColumns):
3213         (WebCore::RenderBlock::adjustRepaintRectForColumns):
3214
3215 2007-01-09  David Hyatt  <hyatt@apple.com>
3216
3217         Break up painting and hit testing of children into helper methods and add multi-column versions for both.
3218         
3219         Make incremental repainting able to invalidate the right spot in multiple column layouts so that e.g., link
3220         hover works.
3221
3222         Turn off selection gap filling in columns for now until it can be made to work correctly.
3223
3224         Improve the column balancing heuristic by adding in the block's lineHeight/2 to each column initially to
3225         account for column break adjustments that shrink the columns slightly.  Avoid clipping of the last column's
3226         contents by ensuring it gets all the remaining available height.
3227
3228         Reviewed by mitz
3229
3230         * rendering/RenderBlock.cpp:
3231         (WebCore::RenderBlock::paintColumns):
3232         (WebCore::RenderBlock::paintContents):
3233         (WebCore::RenderBlock::paintObject):
3234         (WebCore::RenderBlock::fillSelectionGaps):
3235         (WebCore::RenderBlock::nodeAtPoint):
3236         (WebCore::RenderBlock::hitTestColumns):
3237         (WebCore::RenderBlock::layoutColumns):
3238         (WebCore::RenderBlock::adjustRepaintRectForColumns):
3239         * rendering/RenderBlock.h:
3240         * rendering/RenderBox.cpp:
3241         (WebCore::RenderBox::computeAbsoluteRepaintRect):
3242         * rendering/RenderFlow.cpp:
3243         (WebCore::RenderFlow::getAbsoluteRepaintRect):
3244
3245 2007-01-09  Remi Zara  <remi_zara@mac.com>
3246
3247         Reviewed by Darin and Eric.
3248
3249         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
3250
3251         Don't use memset to set float to 0
3252
3253         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
3254         (WebCore::cgGradientCallback):
3255
3256 2007-01-09  Anders Carlsson  <acarlsson@apple.com>
3257
3258         Reviewed by Brady.
3259
3260         Add default constructor to SharedBuffer.
3261
3262         * platform/SharedBuffer.cpp:
3263         (WebCore::SharedBuffer::SharedBuffer):
3264         * platform/SharedBuffer.h:
3265
3266 2007-01-09  David Hyatt  <hyatt@apple.com>
3267
3268         This patch gets rudimentary column layout working.  Normal flow content only gets laid out into
3269         columns properly and painted correctly initially.  What doesn't work: hit testing, incremental repainting,
3270         column rule painting, child layers.
3271
3272         Some work needs to be done on the render tree dumper before column tests will be
3273         meaningful.
3274
3275         Also reworked overflow and fixed a bunch of bugs with the computation of overflow.  These include an error
3276         in the height calculations caused by not adding in the horizontal scrollbar height and other errors caused
3277         by not checking overflow in lowest/rightmostPosition.  Existing tests improve their rendering to match
3278         Firefox with this change.
3279
3280         Fixed a bug where a table cell incorrectly expanded to encompass floats inside an overflow:auto block.
3281         This should not have happened.  Covered by new test fast/overflow/table-overflow-float.html.
3282
3283         Reviewed by mitz
3284
3285         * page/Frame.cpp:
3286         * rendering/RenderBlock.cpp:
3287         (WebCore:::RenderFlow):
3288         (WebCore::RenderBlock::layoutBlock):
3289         (WebCore::RenderBlock::paintContents):
3290         (WebCore::RenderBlock::paintChildren):
3291         (WebCore::RenderBlock::paintObject):
3292         (WebCore::RenderBlock::lowestPosition):
3293         (WebCore::RenderBlock::rightmostPosition):
3294         (WebCore::RenderBlock::leftmostPosition):
3295         (WebCore::RenderBlock::avoidsFloats):
3296         (WebCore::RenderBlock::nodeAtPoint):
3297         (WebCore::RenderBlock::hitTestContents):
3298         (WebCore::RenderBlock::layoutColumns):
3299         * rendering/RenderBlock.h:
3300         (WebCore::RenderBlock::hasOverhangingFloats):
3301         (WebCore::RenderBlock::hasColumns):
3302         * rendering/RenderFlexibleBox.cpp:
3303         (WebCore::RenderFlexibleBox::layoutBlock):
3304         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
3305         (WebCore::RenderFlexibleBox::layoutVerticalBox):
3306         * rendering/RenderFlow.cpp:
3307         (WebCore::RenderFlow::paintLines):
3308         (WebCore::RenderFlow::lowestPosition):
3309         (WebCore::RenderFlow::rightmostPosition):
3310         (WebCore::RenderFlow::leftmostPosition):
3311         * rendering/RenderFlow.h:
3312         (WebCore::RenderFlow::hasColumns):
3313         * rendering/RenderListMarker.cpp:
3314         (WebCore::RenderListMarker::paint):
3315         * rendering/RenderObject.h:
3316         (WebCore::RenderObject::expandsToEncloseOverflow):
3317         * rendering/RenderTableCell.h:
3318         (WebCore::RenderTableCell::expandsToEncloseOverflow):
3319         * rendering/RenderView.cpp:
3320         (WebCore::RenderView::paint):
3321
3322 2007-01-09  Darin Adler  <darin@apple.com>
3323
3324         - update all 2007 Apple copyrights for the new company name
3325
3326         * css/cssstyleselector.cpp:
3327         * html/HTMLLIElement.cpp:
3328         * platform/CharacterNames.h:
3329         * platform/TextBreakIterator.h:
3330         * platform/TextBreakIteratorICU.cpp:
3331         * platform/graphics/ImageBuffer.h:
3332         * rendering/CounterNode.cpp:
3333         * rendering/CounterNode.h:
3334         * rendering/RenderBox.h:
3335         * rendering/RenderContainer.cpp:
3336         * rendering/RenderCounter.cpp:
3337         * rendering/RenderCounter.h:
3338         * rendering/RenderImage.h:
3339         * rendering/RenderListItem.h:
3340         * rendering/RenderListMarker.h:
3341         * rendering/RenderObject.cpp:
3342         * rendering/RenderObject.h:
3343         * rendering/RenderStyle.cpp:
3344         * rendering/RenderStyle.h:
3345         * rendering/RenderTable.cpp:
3346         * rendering/RenderTableCell.cpp:
3347         * rendering/RenderTableCell.h:
3348         * rendering/RenderText.cpp:
3349         * rendering/RenderText.h:
3350         * rendering/RenderTreeAsText.cpp:
3351         * rendering/SVGRenderTreeAsText.cpp:
3352         * rendering/break_lines.cpp:
3353
3354 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
3355
3356         Reviewed by john
3357
3358         <rdar://problem/4840662>
3359         REGRESSION: Mail crash when dragging text into a link
3360         
3361         moveParagraphs fails to move content into a display:block 
3362         anchor because of code in positionAvoidingSpecialElementBoundary,
3363         and so it infinitely recurs.
3364         
3365         * editing/htmlediting.cpp:
3366         (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors
3367         that have display:block so that content is inserted in the expected
3368         paragraph.  This fixes the bug and weird behavior when typing before/after
3369         anchors with display:block.
3370
3371 2007-01-09  Rob Buis  <buis@kde.org>
3372
3373         Reviewed by Darin.
3374
3375         http://bugs.webkit.org/show_bug.cgi?id=12145
3376         Color parsing is too relaxed in strict mode
3377         http://bugs.webkit.org/show_bug.cgi?id=12166
3378         REGRESSION (r18480): "336633" is not parsed as a color
3379
3380         Fix a regression by using String::format return value.
3381         Also make strict mode more strict for cases where hexcolors
3382         lack a #.
3383
3384         * css/cssparser.cpp:
3385         (WebCore::CSSParser::parseColor):
3386         (WebCore::CSSParser::parseColorFromValue):
3387         * css/cssparser.h:
3388
3389 2007-01-09  Darin Adler  <darin@apple.com>
3390
3391         Reviewed by Maciej.
3392
3393         - fixed regression where redirects did not have user-agent any more
3394
3395         Showed up as a failure in one of the http tests, so no new test needed.
3396
3397         * loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest):
3398         Don't use a copy of the ResourceRequest; pass the original so it can be modified.
3399
3400 2007-01-09  Mitz Pettel  <mitz@webkit.org>
3401
3402         Reviewed by Darin.
3403
3404         - fix http://bugs.webkit.org/show_bug.cgi?id=11078
3405           Forms Don't Submit (ASP Pages)
3406
3407         Test: fast/dom/collection-namedItem-via-item.html
3408
3409         * bindings/js/kjs_html.cpp:
3410         (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back
3411         to namedItem() if its argument does not convert to a number.
3412
3413 2007-01-09  Darin Adler  <darin@apple.com>
3414
3415         Reviewed by Maciej.
3416
3417         - fix http://bugs.webkit.org/show_bug.cgi?id=12174
3418           improve Unicode use (less WTF::Unicode:: prefix, centralized character names)
3419
3420         - got rid of namespace prefixes from most uses of WTF::Unicode
3421
3422         - updated for removal of WTF::Unicode::memcmp
3423         - updated for renaming of WTF::Unicode::strcasecmp to umemcasecmp.
3424
3425         - unified constants for special Unicode characters in a new
3426           CharacterNames.h header
3427
3428         * WebCore.xcodeproj/project.pbxproj:
3429         * css/cssparser.cpp:
3430         (WebCore::ParseString::lower):
3431         * dom/Document.cpp:
3432         (WebCore::isValidNameStart):
3433         (WebCore::isValidNamePart):
3434         * dom/Position.cpp:
3435         (WebCore::Position::leadingWhitespacePosition):
3436         (WebCore::Position::trailingWhitespacePosition):
3437         * editing/CompositeEditCommand.cpp:
3438         (WebCore::isWhitespace):
3439         * editing/HTMLInterchange.cpp:
3440         * editing/TextIterator.cpp:
3441         (WebCore::CircularSearchBuffer::CircularSearchBuffer):
3442         (WebCore::CircularSearchBuffer::append):
3443         * editing/htmlediting.cpp:
3444         (WebCore::stringWithRebalancedWhitespace):
3445         (WebCore::nonBreakingSpaceString):
3446         * editing/htmlediting.h:
3447         * html/HTMLFontElement.cpp:
3448         (WebCore::parseFontSizeNumber):
3449         * html/HTMLParser.cpp:
3450         (WebCore::HTMLParser::handleError):
3451         * html/HTMLSelectElement.cpp:
3452         (WebCore::stripLeadingWhiteSpace):
3453         * platform/Font.cpp:
3454         (WebCore::WidthIterator::advance):
3455         (WebCore::WidthIterator::normalizeVoicingMarks):
3456         * platform/GlyphMap.cpp:
3457         (WebCore::GlyphMap::locatePage):
3458         * platform/MimeTypeRegistry.h:
3459         * platform/StringHash.h:
3460         * platform/StringImpl.cpp:
3461         (WebCore::isSpace):
3462         (WebCore::StringImpl::append):
3463         (WebCore::StringImpl::insert):
3464         (WebCore::StringImpl::truncate):
3465         (WebCore::StringImpl::remove):
3466         (WebCore::parseLength):
3467         (WebCore::StringImpl::isLower):
3468         (WebCore::StringImpl::lower):
3469         (WebCore::StringImpl::upper):
3470         (WebCore::StringImpl::secure):
3471         (WebCore::StringImpl::foldCase):
3472         (WebCore::StringImpl::capitalize):t
3473         (WebCore::StringImpl::toInt):
3474         (WebCore::equalIgnoringCase):
3475         (WebCore::StringImpl::find):
3476         * platform/TextBoundaries.h:
3477         * platform/TextCodec.h:
3478         * platform/TextCodecLatin1.cpp:
3479         * platform/TextEncoding.h:
3480         * platform/TextEncodingRegistry.h:
3481         * platform/mac/PasteboardMac.mm:
3482         (WebCore::Pasteboard::writeSelection):
3483         * platform/mac/TextCodecMac.cpp:
3484         (WebCore::TextCodecMac::decode):
3485         * rendering/RenderBlock.cpp:
3486         (WebCore::RenderBlock::updateFirstLetter):
3487         * rendering/RenderListMarker.cpp:
3488         (WebCore::listMarkerText):
3489         (WebCore::RenderListMarker::paint):
3490         * rendering/RenderText.cpp:
3491         (WebCore::RenderText::widthFromCache):
3492         (WebCore::isSpaceAccordingToStyle):
3493         (WebCore::RenderText::setInternalString):
3494         * rendering/RenderTreeAsText.cpp:
3495         (WebCore::quoteAndEscapeNonPrintables):
3496         (WebCore::operator<<):
3497         * rendering/bidi.cpp:
3498         (WebCore::BidiState::BidiState):
3499         (WebCore::BidiContext::BidiContext):
3500         (WebCore::bidiNext):
3501         (WebCore::bidiFirst):
3502         (WebCore::BidiIterator::direction):
3503         (WebCore::appendRun):
3504         (WebCore::embed):
3505         (WebCore::RenderBlock::bidiReorderLine):
3506         (WebCore::RenderBlock::layoutInlineChildren):
3507         (WebCore::skipNonBreakingSpace):
3508         (WebCore::RenderBlock::findNextLineBreak):
3509         * rendering/break_lines.cpp:
3510         (WebCore::nextBreakablePosition):
3511         * rendering/break_lines.h:
3512         * xml/XPathParser.cpp:
3513         (WebCore::XPath::charCat):
3514
3515 2007-01-09  Dex Deacon  <occupant4@gmail.com>
3516
3517         Reviewed by Darin.
3518
3519         - fix http://bugs.webkit.org/show_bug.cgi?id=12170
3520           RenderView holds dangling reference to RenderObjects as selection markers
3521
3522         This fixes the crash seen on Windows -- the underlying problem
3523         may still exist.
3524
3525         * rendering/RenderText.h:
3526         (WebCore::RenderText::selectionState):
3527         Change the m_selectionState enum-bitfield to an unsigned-bitfield,
3528         because enums on Windows are signed, which caused it to become
3529         negative (whereas the valid values are all positive).
3530
3531 2007-01-09  Darin Adler  <darin@apple.com>
3532
3533         Reviewed by Hyatt.
3534
3535         - http://bugs.webkit.org/show_bug.cgi?id=12175
3536           port break_lines.cpp to be platform independent
3537
3538         * platform/TextBreakIterator.h: Added lineBreakIterator.
3539         Removed ICU-specific stuff from the header.
3540
3541         * platform/TextBreakIteratorICU.cpp:
3542         (WebCore::setUpIterator): Added helper to be shared by the three different
3543         creation functions.
3544         (WebCore::characterBreakIterator): Changed to use setUpIterator.
3545         (WebCore::wordBreakIterator): Ditto.
3546         (WebCore::lineBreakIterator): Added.
3547
3548         * platform/qt/TextBreakIteratorQt.cpp:
3549         (WebCore::lineBreakIterator): Added a stub.
3550
3551         * rendering/break_lines.cpp:
3552         (WebCore::isBreakableSpace): Added.
3553         (WebCore::shouldBreakAfter): Added.
3554         (WebCore::needsAdvancedBreakAnalysis): Added.
3555         (WebCore::nextBreakablePosition): Changed to use TextBreakIterator on platforms
3556         other than Mac.
3557
3558 2007-01-09  Maciej Stachowiak  <mjs@apple.com>
3559
3560         Reviewed by Darin.
3561
3562         - move WebDataProtocol load handling from ResourceLoader to MainResourceLoader
3563         
3564         (it's only ever used for main resources)
3565
3566         * loader/ResourceLoader.h:
3567         (WebCore::ResourceLoader::setRequest):
3568         * loader/mac/MainResourceLoaderMac.mm:
3569         (WebCore::MainResourceLoader::willSendRequest):
3570         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3571         * loader/mac/ResourceLoaderMac.mm:
3572         (WebCore::ResourceLoader::willSendRequest):
3573         (WebCore::ResourceLoader::didReceiveResponse):
3574
3575 2007-01-09  Rob Buis  <buis@kde.org>
3576
3577         Reviewed by Eric.
3578
3579         http://bugs.webkit.org/show_bug.cgi?id=12129
3580         repaint issue after setting viewBox attribute with ECMAScript
3581
3582         Make sure RenderSVGContainer updates after setting viewBox from js.
3583
3584         * ksvg2/svg/SVGSVGElement.cpp:
3585         (WebCore::SVGSVGElement::parseMappedAttribute):
3586         * rendering/RenderSVGContainer.cpp:
3587         (WebCore::RenderSVGContainer::setViewBox):
3588
3589 2007-01-09  Lars Knoll <lars@trolltech.com>
3590
3591         Make the Qt build compile... again!
3592
3593         * WebCore.pro:
3594         * loader/qt/FrameLoaderQt.cpp:
3595         * platform/graphics/qt/GraphicsContextQt.cpp:
3596         * platform/graphics/qt/ImageBufferQt.cpp:
3597         (WebCore::ImageBuffer::create):
3598         * platform/qt/WidgetQt.cpp:
3599         (WebCore::Widget::focusPolicy):
3600
3601 2007-01-09  David Hyatt  &