WebCore/ChangeLog

   1 2006-10-05  Eric Seidel  <eric@eseidel.com>
   2
   3         Reviewed by mjs.
   4
   5         Removed dead code.
   6         Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
   7
   8         * WebCore.xcodeproj/project.pbxproj:
   9         * ksvg2/ecma/GlobalObject.cpp: Removed.
  10         * ksvg2/ecma/GlobalObject.h: Removed.
  11
  12 2006-10-05  Adam Roben  <aroben@apple.com>
  13
  14         Reviewed by Maciej.
  15
  16         Small ResourceLoaderInternal tweak.
  17
  18         * platform/ResourceLoaderInternal.h:
  19         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  20
  21 2006-10-05  Eric Seidel  <eric@eseidel.com>
  22
  23         Reviewed by mjs.
  24
  25         More incremental KCanvas cleanup and optimization.
  26         Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
  27         Optimized dash array usage to not malloc.
  28         Also removed un-needed KSVGRenderingStyle includes.
  29
  30         * kcanvas/KCanvasTreeDebug.cpp:
  31         (WebCore::operator<<):
  32         * kcanvas/RenderPath.cpp:
  33         (WebCore::RenderPath::nodeAtPoint):
  34         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
  35         (WebCore::RenderPath::strokeBBox):
  36         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  37         (WebCore::KRenderingPaintServerGradientQuartz::setup):
  38         (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
  39         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  40         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
  41         (WebCore::KRenderingPaintServerSolidQuartz::setup):
  42         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
  43         (WebCore::KRenderingPaintServerPatternQuartz::setup):
  44         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
  45         * kcanvas/device/quartz/QuartzSupport.mm:
  46         (WebCore::applyStrokeStyleToContext):
  47         * ksvg2/css/SVGRenderStyle.h:
  48         (WebCore::SVGRenderStyle::hasStroke):
  49         (WebCore::SVGRenderStyle::hasFill):
  50         * ksvg2/misc/KCanvasRenderingStyle.cpp:
  51         (WebCore::KSVGPainterFactory::fillPaintServer):
  52         (WebCore::KSVGPainterFactory::strokePaintServer):
  53         * ksvg2/misc/KCanvasRenderingStyle.h:
  54
  55 2006-10-05  Maciej Stachowiak  <mjs@apple.com>
  56
  57         Reviewed by Adam.
  58
  59         - changed ResourceLoader to be refcounted
  60
  61         It keeps a ref on itself while loading as well. This makes
  62         for a much saner memory management model than the previous.
  63
  64         * bridge/mac/WebCoreResourceLoaderImp.mm:
  65         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
  66         * dom/XMLTokenizer.cpp:
  67         (WebCore::openFunc):
  68         * loader/icon/IconLoader.cpp:
  69         (IconLoader::IconLoader):
  70         (IconLoader::~IconLoader):
  71         (IconLoader::startLoading):
  72         (IconLoader::stopLoading):
  73         (IconLoader::receivedData):
  74         * loader/icon/IconLoader.h:
  75         * loader/loader.cpp:
  76         (WebCore::Loader::servePendingRequests):
  77         * platform/ResourceLoader.cpp:
  78         (WebCore::ResourceLoader::create):
  79         (WebCore::ResourceLoader::kill):
  80         * platform/ResourceLoader.h:
  81         * platform/ResourceLoaderInternal.h:
  82         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  83         * platform/mac/ResourceLoaderMac.mm:
  84         (WebCore::ResourceLoader::start):
  85         * xml/XSLTProcessor.cpp:
  86         (WebCore::docLoaderFunc):
  87         * xml/xmlhttprequest.cpp:
  88         (WebCore::XMLHttpRequest::send):
  89         * xml/xmlhttprequest.h:
  90
  91 2006-10-05  Eric Seidel  <eric@eseidel.com>
  92
  93         Reviewed by mjs.
  94
  95         Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
  96         http://bugs.webkit.org/show_bug.cgi?id=11163
  97
  98         No SVG performance tests yet.
  99
 100         * kcanvas/RenderForeignObject.cpp:
 101         (WebCore::RenderForeignObject::paint):
 102         * kcanvas/RenderSVGContainer.cpp:
 103         (WebCore::RenderSVGContainer::paint):
 104         * kcanvas/RenderSVGImage.cpp:
 105         (WebCore::RenderSVGImage::paint):
 106         * kcanvas/RenderSVGText.cpp:
 107         (WebCore::RenderSVGText::paint):
 108
 109 2006-10-05  Dave Hyatt  <hyatt@apple.com>
 110
 111         Stub out some stuff for widget focusability.
 112
 113         Reviewed by maciej
 114
 115         * page/FrameView.cpp:
 116         (WebCore::FrameView::dispatchMouseEvent):
 117         * platform/ScrollView.h:
 118         * platform/Widget.h:
 119
 120 2006-10-05  Adam Roben  <aroben@apple.com>
 121
 122         Reviewed by Maciej and Tim H.
 123
 124         Copy some WebKit frame lifetime logic into WebCore -- just a step
 125         along the path to frame lifetime being handled completely in WebCore.
 126
 127         * bridge/mac/FrameMac.mm:
 128         (WebCore::FrameMac::setView): Move platform-independent parts of this
 129         method into Frame.
 130         * page/Frame.cpp:
 131         (WebCore::Frame::setView): Adding platform-independent parts of
 132         FrameMac::setView
 133         (WebCore::Frame::detachChildren): New method to accomplish what
 134         -[WebFrameBridge _detachChildren] currently does.
 135         (WebCore::Frame::clear): Call detachChildren
 136         * page/Frame.h: Add declaration for detachChildren
 137
 138 2006-10-04  Alice Liu  <alice.liu@apple.com>
 139
 140         Reviewed by Darin.
 141
 142         Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query
 143
 144         * xml/xmlhttprequest.cpp:
 145         (WebCore::XMLHttpRequest::setRequestHeader):
 146         removed exception set when the request is not open yet
 147
 148 2006-10-04  Anders Carlsson  <acarlsson@apple.com>
 149
 150         Reviewed by John Sullivan.
 151
 152         <rdar://problem/4654328>
 153         Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
 154
 155         * loader/PluginDocument.cpp:
 156         (WebCore::PluginTokenizer::writeRawData):
 157         Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
 158
 159 2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
 160
 161         Reviewed by Tim H.
 162
 163         http://bugs.webkit.org/show_bug.cgi?id=11130
 164         Convert "undefined" to AE missing value
 165
 166         * bridge/mac/WebCoreFrameBridge.mm:
 167         (aeDescFromJSValue): return missing value for UndefinedType.
 168
 169 2006-10-03  Dave Hyatt  <hyatt@apple.com>
 170
 171         Scrolling work.  Eliminate convertTo/FromContainingWindow as cross-platform functions.  Add back in
 172         the windowToContents/contentsToWindow functions.
 173
 174         Reviewed by anders
 175
 176         * bridge/mac/FrameMac.mm:
 177         (WebCore::FrameMac::eventMayStartDrag):
 178         (WebCore::FrameMac::dragHysteresisExceeded):
 179         (WebCore::FrameMac::mouseDown):
 180         (WebCore::FrameMac::shouldDragAutoNode):
 181         (WebCore::FrameMac::sendContextMenuEvent):
 182         * bridge/mac/FrameViewMac.mm:
 183         (WebCore::FrameView::passMousePressEventToScrollbar):
 184         * bridge/mac/WebCoreFrameBridge.mm:
 185         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
 186         * dom/EventTargetNode.cpp:
 187         (WebCore::EventTargetNode::dispatchMouseEvent):
 188         (WebCore::EventTargetNode::dispatchWheelEvent):
 189         * page/Frame.cpp:
 190         (WebCore::Frame::selectClosestWordFromMouseEvent):
 191         (WebCore::Frame::handleMousePressEventTripleClick):
 192         (WebCore::Frame::handleMousePressEventSingleClick):
 193         (WebCore::Frame::handleMouseMoveEvent):
 194         (WebCore::Frame::handleMouseReleaseEvent):
 195         * page/FrameView.cpp:
 196         (WebCore::FrameView::handleMousePressEvent):
 197         (WebCore::FrameView::handleMouseDoubleClickEvent):
 198         (WebCore::selectCursor):
 199         (WebCore::FrameView::handleMouseMoveEvent):
 200         (WebCore::FrameView::handleMouseReleaseEvent):
 201         (WebCore::FrameView::dispatchDragEvent):
 202         (WebCore::FrameView::prepareMouseEvent):
 203         (WebCore::FrameView::handleWheelEvent):
 204         * page/FrameView.h:
 205         * platform/ScrollBar.cpp:
 206         (WebCore::ScrollBar::setValue):
 207         * platform/ScrollView.h:
 208         * platform/Widget.h:
 209         (WebCore::Widget::scrolled):
 210         * platform/mac/ScrollViewMac.mm:
 211         (WebCore::ScrollView::contentsToWindow):
 212         (WebCore::ScrollView::windowToContents):
 213         (WebCore::ScrollView::scrollbarUnderMouse):
 214         * platform/mac/WidgetMac.mm:
 215         * rendering/RenderLayer.cpp:
 216         (WebCore::RenderLayer::resize):
 217         (WebCore::RenderLayer::positionScrollbars):
 218         * rendering/RenderReplaced.cpp:
 219         (WebCore::RenderReplaced::shouldPaint):
 220         * rendering/RenderView.cpp:
 221         * rendering/RenderView.h:
 222         * rendering/RenderWidget.cpp:
 223         (WebCore::RenderWidget::setWidget):
 224
 225 2006-09-26  David Smith  <catfish.man@gmail.com>
 226
 227         Reviewed by Timothy.
 228
 229         http://bugs.webkit.org/show_bug.cgi?id=3723
 230         Add -scrollDOMRangeToVisible:
 231
 232         No automated tests are possible as this code path isn't reachable from JavaScript.
 233
 234         * bridge/mac/WebCoreFrameBridge.h:
 235         * bridge/mac/WebCoreFrameBridge.mm:
 236         (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
 237
 238 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
 239
 240         Reviewed by Timothy.
 241
 242         <http://bugs.webkit.org/show_bug.cgi?id=10338>
 243         When contentEditable, cursor doesn't change to hand
 244
 245         Allow the behaviour of editable links to be specified by a WebPreference
 246         The preference WebKitEditableLinkBehavior has four options:
 247          - AlwaysLive: Safari 2.0 behaviour
 248          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
 249          - LiveWhenNotFocused: Editable links are live only when their editable block is not
 250              focused, or when the shift key is pressed
 251          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
 252
 253         No layout tests, just a modification of a manual-test as it isn't possible to test
 254         this automatically.
 255
 256         * bridge/mac/WebCoreSettings.h:
 257         * bridge/mac/WebCoreSettings.mm:
 258         (-[WebCoreSettings setEditableLinkBehavior:]):
 259         (-[WebCoreSettings editableLinkBehavior]):
 260         * html/HTMLAnchorElement.cpp:
 261         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
 262         (WebCore::HTMLAnchorElement::defaultEventHandler):
 263         (WebCore::HTMLAnchorElement::setActive):
 264         * html/HTMLAnchorElement.h:
 265         * manual-tests/contenteditable-link.html:
 266         * page/FrameView.cpp:
 267         (WebCore::nodeIsNotBeingEdited):
 268         (WebCore::selectCursor):
 269         * page/Settings.h:
 270         (WebCore::Settings::):
 271         (WebCore::Settings::Settings):
 272         (WebCore::Settings::editableLinkBehavior):
 273         (WebCore::Settings::setEditableLinkBehavior):
 274
 275 2006-10-03  Beth Dakin  <bdakin@apple.com>
 276
 277         Reviewed Darin.
 278
 279         No test cases needed.
 280
 281         Implemented a version of StringImpl::append that takes a UChar* and
 282         a length.
 283
 284         * platform/StringImpl.cpp:
 285         (WebCore::StringImpl::append):
 286         (WebCore::StringImpl::insert): Call new append instead of making a
 287         new StringImpl.
 288         * platform/StringImpl.h:
 289
 290 2006-10-03  MorganL  <morganl.webkit@yahoo.com>
 291
 292         Reviewed by Darin.
 293
 294         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
 295         HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
 296
 297         * platform/win/ResourceLoaderWin.cpp:
 298         (WebCore::ResourceLoader::onHandleCreated):
 299
 300 2006-10-02  Geoffrey Garen  <ggaren@apple.com>
 301
 302         Feared, loathed, reviewed by Darin.
 303
 304         More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach
 305         into FRAME, plus other cleanup.
 306
 307         No new behavior, so no new test. Layout tests pass. Basic browsing and
 308         Mail editing seem to work.
 309
 310         * dom/Node.cpp:
 311         (WebCore::Node::detach): Removed random commented-out code.
 312         * html/HTMLFrameElement.cpp:
 313         (WebCore::HTMLFrameElement::isURLAllowed):
 314         (1) Removed reference to FrameView, to dissociate frame loading from rendering.
 315         (2) Renamed newURL to completeURL because the difference between newURL
 316         and URLString is that newURL is a KURL that is the complete version of URLString,
 317         not that it is new.
 318         (WebCore::HTMLFrameElement::willRemove):
 319         (1) Removed close() call and moved close() code into willRemove(), also removing
 320         close() call from detach(), since willRemove is the well-defined place
 321         from DOM tear-down, not detach().
 322         (2) Removed manual renderer detach code because the DOM is not responsible
 323         for managing the render tree. I confirmed that this change not
 324         regress <rdar://problem/4132581>.
 325         (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
 326         lost their content frames after being removed from the DOM. That's our
 327         current behavior, but it's going to change in future rounds of refactoring.
 328         This also fixes <rdar://problem/4750835>.
 329         (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
 330         attach/detach, because the render tree should not be in charge of deciding
 331         when to load.
 332         * html/HTMLFrameElement.h:
 333         * html/HTMLIFrameElement.cpp:
 334         (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
 335         because the renderer is a renderPartObject, not a renderPart.
 336         * html/HTMLIFrameElement.h:
 337
 338 2006-10-03  Mark Rowe  <bdash@webkit.org>
 339
 340         Reviewed by Mitz.
 341
 342         http://bugs.webkit.org/show_bug.cgi?id=11137
 343         Bug 11137: GdkLauncher dies with "pure virtual method called" if
 344         window is closed while page still loading
 345
 346         * platform/gdk/FrameGdk.cpp:
 347         (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
 348         methods to be called before the FrameGdk portion of "this" is torn down.
 349
 350 2006-10-03  Adam Roben  <aroben@apple.com>
 351
 352         Reviewed by Darin.
 353
 354         Handle tab key presses in the DOM.
 355
 356         * dom/EventTargetNode.cpp:
 357         (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
 358         * page/FrameView.cpp:
 359         (WebCore::FrameView::advanceFocus): Rename and reimplement
 360         focusNextPrevNode. Now we just call Element::focus().
 361         * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
 362         it public.
 363
 364 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
 365
 366         Reviewed by mjs
 367
 368         <rdar://problem/4760612>
 369         TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
 370
 371         No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
 372
 373         * dom/Range.cpp:
 374         (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming
 375         positions are non-null since most of it's callers would be in a bad state if the positions
 376         were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.
 377         Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it
 378         from entering compareBoundaryPoints and hitting the assert.
 379
 380 2006-10-03  Adele Peterson  <adele@apple.com>
 381
 382         Reviewed by Geoff.
 383
 384         Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
 385
 386         * html/HTMLSelectElement.cpp:
 387         (WebCore::HTMLSelectElement::recalcStyle):
 388         (WebCore::HTMLSelectElement::isKeyboardFocusable):
 389         (WebCore::HTMLSelectElement::isMouseFocusable):
 390         (WebCore::HTMLSelectElement::createRenderer):
 391         (WebCore::HTMLSelectElement::setRecalcListItems):
 392         (WebCore::HTMLSelectElement::notifyOptionSelected):
 393         (WebCore::HTMLSelectElement::defaultEventHandler):
 394
 395 2006-10-04  Darin Adler  <darin@apple.com>
 396
 397         Reviewed by Geoff.
 398
 399         - fix http://bugs.webkit.org/show_bug.cgi?id=11132
 400           Caret disappears when you're typing
 401
 402         * editing/SelectionController.cpp:
 403         (WebCore::SelectionController::setSelection): Remove unnecessary call to
 404         clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
 405         (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
 406         to false so we can get the old caret repaint rect. Later we need to change the
 407         design so getting the rect doesn't have a side effect of causing a layout without
 408         invalidation.
 409
 410 2006-10-03  David Harrison  <harrison@apple.com>
 411
 412         Reviewed by Maciej.
 413
 414         <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
 415
 416         Updated test:
 417         * fast/text/justified-text-rect.html
 418
 419         * bridge/mac/WebCoreFrameBridge.mm:
 420         (-[WebCoreFrameBridge convertToNSRange:]):
 421         (-[WebCoreFrameBridge convertToDOMRange:]):
 422         Make the selection's root editable element (or the document itself) be
 423         the basis for NSRange conversions. This supports "shadow DOM" like
 424         that for text fields and text areas.
 425
 426         * editing/CompositeEditCommand.cpp:
 427         (WebCore::CompositeEditCommand::moveParagraphs):
 428         Pass the document element as the scope.
 429
 430         * editing/TextIterator.cpp:
 431         (WebCore::TextIterator::rangeFromLocationAndLength):
 432         Make the first parameter the scope.
 433
 434         * editing/TextIterator.h:
 435         Make the first parameter of rangeFromLocationAndLength() the scope.
 436
 437 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
 438
 439         Reviewed by Eric.
 440
 441         Fix Qt/Linux build.
 442
 443         * CMakeLists.txt: Add counter related files.
 444
 445 2006-10-03  Mark Rowe  <bdash@webkit.org>
 446
 447         Reviewed by Eric.
 448
 449         http://bugs.webkit.org/show_bug.cgi?id=10981
 450         Linux/GDK build fixes
 451
 452         Based on a patch by Krzysztof Kowalczyk.
 453
 454         * WebCoreSources.bkl:
 455         * platform/gdk/FrameGdk.cpp:
 456         (WebCore::doScroll):
 457         (WebCore::FrameGdk::handleGdkEvent):
 458         * platform/gdk/PlatformScrollBar.h: Added.
 459         (WebCore::PlatformScrollBar::isWidget):
 460         * platform/gdk/ScrollViewGdk.cpp:
 461         * platform/gdk/TemporaryLinkStubs.cpp:
 462         (FrameView::passMousePressEventToScrollbar):
 463         (FrameView::passMousePressEventToSubframe):
 464         (FrameView::passMouseReleaseEventToSubframe):
 465         (FrameView::passMouseMoveEventToSubframe):
 466         (FrameView::passWheelEventToSubframe):
 467         (Cursor::Cursor):
 468         (Widget::invalidate):
 469         (Widget::invalidateRect):
 470         (ScrollView::wheelEvent):
 471         (ScrollView::convertToContainingWindow):
 472         (ScrollView::convertFromContainingWindow):
 473         (GraphicsContext::clip):
 474         (PlatformScrollBar::PlatformScrollBar):
 475         (PlatformScrollBar::updateThumbPosition):
 476         (PlatformScrollBar::updateThumbProportion):
 477         (ScrollBar::ScrollBar):
 478         (ScrollBar::setProportion):
 479         (WebCore::supportedKeySizes):
 480         (WebCore::signedPublicKeyAndChallengeString):
 481         * platform/gdk/WheelEventGdk.cpp:
 482         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
 483         * platform/gdk/WidgetGdk.cpp:
 484         (WebCore::Widget::convertToContainingWindow):
 485         (WebCore::Widget::convertFromContainingWindow):
 486
 487 2006-10-02  Adam Roben  <aroben@apple.com>
 488
 489         Reviewed by Maciej.
 490
 491         Let Windows determine which mouse button is pressed.
 492
 493         * platform/PlatformMouseEvent.h: Add message parameter to constructor.
 494         * platform/win/MouseEventWin.cpp:
 495         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
 496         parameter to determine which mouse button is pressed.
 497
 498 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
 499
 500         Reviewed by anders
 501
 502         Build fix
 503
 504         * editing/SelectionController.cpp:
 505         (WebCore::SelectionController::empty):
 506         * editing/SelectionController.h:
 507
 508 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
 509
 510         Reviewed by john
 511
 512         <rdar://problem/4755287>
 513         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
 514
 515         * editing/markup.cpp:
 516         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced
 517         elements).  Don't skip blocks that aren't containers (like horizontal rules).
 518
 519 2006-10-03  Darin Adler  <darin@apple.com>
 520
 521         Reviewed by Justin Garcia.
 522
 523         - correct mistaken code that would restart blinking every
 524           time "invalidateSelection" is called even if the caret
 525           has not moved
 526
 527         * editing/SelectionController.h:
 528         * editing/SelectionController.cpp:
 529         (WebCore::SelectionController::setSelection): Update for name change.
 530         (WebCore::SelectionController::recomputeCaretRect): New function.
 531         Computes caret rect and does any necessary invalidation if the rect
 532         changes.
 533         (WebCore::SelectionController::invalidateCaretRect): Renamed from
 534         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
 535         calls recomputeCaretRect as a side effect.
 536
 537         * page/Frame.cpp:
 538         (WebCore::Frame::invalidateSelection): Remove unneeded call to
 539         clearCaretRectIfNeeded.
 540         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
 541         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
 542         recomputeCaretRect function and not restart blinking if caret has
 543         not changed position.
 544         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
 545         are not needed since selectionLayoutChanged already checks these.
 546
 547         * page/FramePrivate.h: Removed unused m_blinkCaret.
 548
 549 2006-10-02  Beth Dakin  <bdakin@apple.com>
 550
 551         Reviewed by Adam.
 552
 553         Build fix. Add counters to vcproj.
 554
 555         * WebCore.vcproj/WebCore/WebCore.vcproj:
 556
 557 2006-10-02  Brady Eidson  <beidson@apple.com>
 558
 559         Reviewed by Adele
 560
 561         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
 562         icon data out because we don't correctly check SQL error conditions.
 563
 564         * loader/icon/IconDataCache.cpp:
 565         (WebCore::IconDataCache::writeToDatabase):
 566
 567 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
 568
 569         Reviewed by Hyatt.
 570
 571         Added method to find out whether a layout has occurred.
 572
 573         * page/FrameView.cpp:
 574         (WebCore::FrameView::didFirstLayout):
 575         * page/FrameView.h:
 576
 577 2006-10-02  Beth Dakin  <bdakin@apple.com>
 578
 579         Reviewed by Darin.
 580
 581         Initial implementation of CSS2 counters. See http://
 582         bugs.webkit.org/show_bug.cgi?id=4980 for more details.
 583
 584         * WebCore.xcodeproj/project.pbxproj:
 585         * css/CSSComputedStyleDeclaration.cpp:
 586         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return
 587         the increment/reset list now that this is implemented.
 588         * css/CSSPrimitiveValue.cpp:
 589         (WebCore::CSSPrimitiveValue::cssText):
 590         * css/Counter.h:
 591         (WebCore::Counter::Counter):
 592         (WebCore::Counter::~Counter):
 593         (WebCore::Counter::identifier):
 594         (WebCore::Counter::listStyle):
 595         (WebCore::Counter::separator):
 596         (WebCore::Counter::listStyleNumber):
 597         (WebCore::Counter::setIdentifier):
 598         (WebCore::Counter::setListStyle):
 599         (WebCore::Counter::setSeparator):
 600         * css/cssparser.cpp:
 601         (WebCore::CSSParser::addProperty): Take care of reset/increment
 602         (WebCore::CSSParser::parseValue):
 603         (WebCore::CSSParser::parseContent): content can now take counters
 604         (WebCore::CSSParser::parseCounterContent): Parse counter() and
 605         counters()
 606         (WebCore::CSSParser::parseCounter): Parse counter-reset and
 607         counter-increment
 608         * css/cssparser.h:
 609         * css/cssstyleselector.cpp:
 610         (WebCore::CSSStyleSelector::matchUARules):
 611         (WebCore::CSSStyleSelector::applyProperty):
 612         * platform/PlatformString.h:
 613         * platform/String.cpp:
 614         (WebCore::String::insert): Implemented a version of insert that
 615         accepts a UChar* and a length.
 616         * platform/StringImpl.cpp:
 617         (WebCore::StringImpl::insert): Same as above.
 618         * platform/StringImpl.h:
 619         * rendering/CounterListItem.h: Added.
 620         * rendering/CounterNode.cpp: Added.
 621         (WebCore::CounterNode::CounterNode):
 622         (WebCore::CounterNode::insertAfter):
 623         (WebCore::CounterNode::removeChild):
 624         (WebCore::CounterNode::remove):
 625         (WebCore::CounterNode::setUsesSeparator):
 626         (WebCore::CounterNode::recountAndGetNext):
 627         (WebCore::CounterNode::recountTree):
 628         (WebCore::CounterNode::setSelfDirty):
 629         (WebCore::CounterNode::setParentDirty):
 630         * rendering/CounterNode.h: Added.
 631         (WebCore::CounterNode::~CounterNode):
 632         (WebCore::CounterNode::parent):
 633         (WebCore::CounterNode::previousSibling):
 634         (WebCore::CounterNode::nextSibling):
 635         (WebCore::CounterNode::firstChild):
 636         (WebCore::CounterNode::lastChild):
 637         (WebCore::CounterNode::value):
 638         (WebCore::CounterNode::setValue):
 639         (WebCore::CounterNode::count):
 640         (WebCore::CounterNode::setCount):
 641         (WebCore::CounterNode::setHasSeparator):
 642         (WebCore::CounterNode::isReset):
 643         (WebCore::CounterNode::hasSeparator):
 644         (WebCore::CounterNode::willNeedLayout):
 645         (WebCore::CounterNode::setWillNeedLayout):
 646         (WebCore::CounterNode::isRoot):
 647         (WebCore::CounterNode::setRenderer):
 648         (WebCore::CounterNode::renderer):
 649         * rendering/CounterResetNode.cpp: Added.
 650         (WebCore::CounterResetNode::CounterResetNode):
 651         (WebCore::CounterResetNode::insertAfter):
 652         (WebCore::CounterResetNode::removeChild):
 653         (WebCore::CounterResetNode::recountAndGetNext):
 654         (WebCore::CounterResetNode::setParentDirty):
 655         (WebCore::CounterResetNode::updateTotal):
 656         * rendering/CounterResetNode.h: Added.
 657         (WebCore::CounterResetNode::firstChild):
 658         (WebCore::CounterResetNode::lastChild):
 659         (WebCore::CounterResetNode::isReset):
 660         (WebCore::CounterResetNode::total):
 661         * rendering/RenderContainer.cpp:
 662         (WebCore::RenderContainer::updatePseudoChildForObject): Account for
 663         counter content.
 664         * rendering/RenderCounter.cpp: Added.
 665         (WebCore::RenderCounter::RenderCounter):
 666         (WebCore::RenderCounter::layout):
 667         (WebCore::toRoman):
 668         (WebCore::toLetterString):
 669         (WebCore::toHebrew):
 670         (WebCore::RenderCounter::convertValueToType):
 671         (WebCore::RenderCounter::calcMinMaxWidth):
 672         * rendering/RenderCounter.h: Added.
 673         (WebCore::RenderCounter::renderName):
 674         (WebCore::RenderCounter::isCounter):
 675         * rendering/RenderObject.cpp:
 676         (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to
 677         maps of CounterNodes
 678         (WebCore::RenderObject::RenderObject):
 679         (WebCore::RenderObject::destroy): Destroy the maps.
 680         (WebCore::RenderObject::findCounter): Finds/creates counters.
 681         * rendering/RenderObject.h:
 682         (WebCore::RenderObject::isCounter):
 683         * rendering/RenderStyle.cpp:
 684         (WebCore::StyleVisualData::StyleVisualData):
 685         (WebCore::RenderStyle::arenaDelete):
 686         (WebCore::RenderStyle::RenderStyle):
 687         (WebCore::RenderStyle::diff):
 688         (WebCore::RenderStyle::setContent):
 689         (WebCore::ContentData::clearContent):
 690         (WebCore::RenderStyle::counterDataEquivalent):
 691         (WebCore::hasCounter):
 692         (WebCore::RenderStyle::hasCounterReset):
 693         (WebCore::RenderStyle::hasCounterIncrement):
 694         (WebCore::readCounter):
 695         (WebCore::RenderStyle::counterReset):
 696         (WebCore::RenderStyle::counterIncrement):
 697         * rendering/RenderStyle.h:
 698         (WebCore::StyleVisualData::operator==):
 699         (WebCore::CounterData::CounterData):
 700         (WebCore::CounterData::identifier):
 701         (WebCore::CounterData::listStyle):
 702         (WebCore::CounterData::separator):
 703         (WebCore::ContentData::contentCounter):
 704         (WebCore::ContentData::):
 705         (WebCore::RenderStyle::counterIncrement):
 706         (WebCore::RenderStyle::counterReset):
 707         (WebCore::RenderStyle::setCounterIncrement):
 708         (WebCore::RenderStyle::setCounterReset):
 709         (WebCore::RenderStyle::setCounterResetList):
 710         (WebCore::RenderStyle::setCounterIncrementList):
 711         (WebCore::RenderStyle::counterResetValueList):
 712         (WebCore::RenderStyle::counterIncrementValueList):
 713
 714 2006-10-02  Adele Peterson  <adele@apple.com>
 715
 716         Reviewed by Adam.
 717
 718         - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
 719
 720         There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
 721         by using "-webkit-appearance:none".
 722
 723         * css/html4.css:
 724
 725 2006-10-02  David Harrison  <harrison@apple.com>
 726
 727         Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
 728         addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
 729         Left the layout test.
 730
 731         * rendering/bidi.cpp:
 732         (WebCore::checkMidpoints):
 733
 734 2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>
 735
 736         Reviewed by eseidel.  Landed by eseidel.
 737
 738         Fix Qt/Linux build.
 739
 740         * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
 741         (WebCore::supportedKeySizes):
 742
 743 2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>
 744
 745         Reviewed by eseidel & mjs.  Landed by eseidel.
 746
 747         Fix Qt/Linux build with older gcc 3.3.4.
 748         http://bugs.webkit.org/show_bug.cgi?id=11116
 749
 750         As discussed with Maciej, the GCC_ROOT_NS_HACK
 751         can be completely removed, as well as the friendship
 752         between cacheGlobalObject & the JS* objects.
 753
 754         * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
 755         * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
 756         (png_read_filter_row_mmx_avg):
 757         * platform/image-decoders/png/pngvcrd.c: Ditto.
 758         (png_mmx_support):
 759         (png_read_filter_row_mmx_avg):
 760
 761 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
 762
 763         Rubber stamped by Alexey.
 764
 765         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes
 766
 767         * css/CSSGrammar.y:
 768
 769 2006-10-01  Eric Seidel  <eric@webkit.org>
 770
 771         Reviewed by mjs.
 772
 773         Eliminate a few more hotspots in SVG drawing code.
 774
 775         No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)
 776
 777         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
 778         (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
 779         * platform/mac/ColorMac.mm:
 780         (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance
 781
 782 2006-10-01  Geoffrey Garen  <ggaren@apple.com>
 783
 784         Reviewed by Maciej.
 785
 786         More frame/iframe merging.
 787
 788         - Removed needWidgetUpdate and related code. needWidgetUpdate is always
 789         false, so this was dead code.
 790         - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
 791         than attach(), is the correct place for setInViewSourceMode, because
 792         openURL() is the function that creates our frame.
 793         - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
 794         code that did the same thing in other places.
 795         - Made FRAME's attach() method suffuciently generic so that IFRAME could
 796         call up to it, rather than skipping its superclass and calling up directly
 797         to ELEMENT.
 798         - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
 799         - Replaced ad hoc frame loading code in FRAME::attach() with call to
 800         openURL(), the designated frame loading function.
 801
 802         Layout tests pass. I added a layout test for viewsource mode, since I
 803         broke it in the course of writing this patch.
 804
 805 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
 806
 807         Reviewed by Geoff.
 808
 809         * dom/Document.cpp:
 810         (WebCore::Document::recalcStyleSelector):
 811         * dom/Document.h:
 812         Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
 813
 814         * dom/Node.h:
 815         Remove DeprecatedStringList class forward declaration.
 816
 817         * editing/markup.cpp:
 818         Include DeprecatedStringList.h here since it's not included by Document.h anymore.
 819
 820         * kcanvas/KCanvasTreeDebug.cpp:
 821         * kcanvas/KCanvasTreeDebug.h:
 822         Remove unused functions.
 823
 824         * loader/loader.cpp:
 825         * page/Frame.cpp:
 826         * page/Frame.h:
 827         * page/FrameView.h:
 828         Fixup DeprecatedStringList.h includes.
 829
 830 2006-09-30  David Harrison  <harrison@apple.com>
 831
 832         Reviewed by John Sullivan.
 833
 834         <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
 835
 836         Problem was that the decision to trim was based only on whether the character
 837         is a soft hyphen, which caused pretty much any Japanese character to go.
 838         Changed to decide based on whether the character is ignorable whitespace.
 839
 840         Test:
 841         * fast/text/international/wrap-CJK-001.html
 842
 843         * rendering/bidi.cpp:
 844         (WebCore::isTrimmableChar):
 845         New. Checks whether character is whitespace that can be ignored
 846         according to the text node's style.
 847         trimmed from the end of wrapped line.
 848         (WebCore::checkMidpoints):
 849         Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
 850
 851 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
 852
 853         Reviewed by Mitz Pettel.
 854
 855         Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
 856
 857         * ksvg2/svg/SVGColor.cpp:
 858         (WebCore::SVGColor::setRGBColor):
 859         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
 860         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
 861         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
 862         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
 863         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
 864         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
 865         (SVGFESpecularLightingElement::parseMappedAttribute):
 866         * ksvg2/svg/SVGFETurbulenceElement.cpp:
 867         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
 868         * ksvg2/svg/SVGLengthList.cpp:
 869         * ksvg2/svg/SVGNumberList.cpp:
 870         (SVGNumberList::parse):
 871         * ksvg2/svg/SVGNumberList.h:
 872         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
 873         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
 874         * ksvg2/svg/SVGStringList.cpp:
 875         (WebCore::SVGStringList::reset):
 876         * ksvg2/svg/SVGStringList.h:
 877         * ksvg2/svg/SVGTransformable.cpp:
 878         (SVGTransformable::parseTransformAttribute):
 879
 880 2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>
 881
 882         Reviewed by Eric, tweaked and landed by ap.
 883
 884         Fix Qt/Linux build.
 885
 886         * CMakeLists.txt:
 887         * platform/qt/PlatformScrollBar.h:
 888         * platform/qt/TemporaryLinkStubs.cpp:
 889         (WebCore::ScrollBar::ScrollBar):
 890         (WebCore::PlatformScrollBar::PlatformScrollBar):
 891         (FrameView::passMousePressEventToSubframe):
 892         (FrameView::passMouseMoveEventToSubframe):
 893         (FrameView::passMouseReleaseEventToSubframe):
 894         (FrameView::passWheelEventToSubframe):
 895         (FrameView::passMousePressEventToScrollbar):
 896         * ksvg2/svg/SVGDocument.h:
 897
 898 2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>
 899
 900         Reviewed by Darin.
 901
 902         Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
 903         REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
 904
 905         No test case added (probably requires new DumpRenderTree functionality)
 906
 907         * rendering/RenderImage.cpp:
 908         (WebCore::RenderImage::imageChanged): Added early return if the document is
 909         being destroyed.
 910
 911 2006-10-01  Graham Dennis  <graham.dennis@gmail.com>
 912
 913         Reviewed by Hyatt.
 914
 915         Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
 916         REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
 917
 918         Make sure we only break after a space (and not any other valid line-break) if
 919         the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
 920         I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
 921         twice in quick succession.
 922
 923         * rendering/bidi.cpp:
 924         (WebCore::RenderBlock::findNextLineBreak):
 925
 926 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
 927
 928         Reviewed by Maciej and Darin.
 929
 930         http://bugs.webkit.org/show_bug.cgi?id=4372
 931         JavaScript document.write page form does not submit in Safari
 932
 933         Test: fast/forms/document-write.html
 934
 935         * page/Frame.cpp:
 936         (WebCore::Frame::submitForm): Don't check for parsing().
 937
 938 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
 939
 940         Build fix.
 941
 942         * bridge/mac/FrameViewMac.mm: Add missing #imports.
 943
 944 2006-10-01  Dave Hyatt  <hyatt@apple.com>
 945
 946         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
 947
 948         Reviewed by mitz
 949
 950         * bridge/mac/FrameMac.mm:
 951         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
 952         * bridge/mac/FrameViewMac.mm:
 953         (WebCore::FrameView::passMousePressEventToScrollbar):
 954         * page/FrameView.cpp:
 955         (WebCore::FrameView::handleMousePressEvent):
 956         (WebCore::FrameView::setMousePressed):
 957         * page/FrameView.h:
 958         * platform/win/TemporaryLinkStubs.cpp:
 959         (FrameView::passMousePressEventToScrollbar):
 960
 961 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
 962
 963         Reviewed by Darin.
 964
 965         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
 966         Add more SVG Objective-C DOM bindings
 967
 968         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
 969           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
 970           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
 971           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
 972           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument,
 973           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
 974
 975         * DerivedSources.make:
 976         * WebCore.xcodeproj/project.pbxproj:
 977         * bindings/objc/DOMInternal.h:
 978         * bindings/objc/DOMSVG.h:
 979         * bindings/scripts/CodeGeneratorObjC.pm:
 980         * ksvg2/svg/SVGAElement.idl:
 981         * ksvg2/svg/SVGAnimateColorElement.idl:
 982         * ksvg2/svg/SVGAnimateElement.idl:
 983         * ksvg2/svg/SVGAnimateTransformElement.idl:
 984         * ksvg2/svg/SVGAnimatedPathData.idl:
 985         * ksvg2/svg/SVGAnimatedPoints.idl:
 986         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
 987         * ksvg2/svg/SVGAnimationElement.idl:
 988         * ksvg2/svg/SVGCircleElement.idl:
 989         * ksvg2/svg/SVGClipPathElement.idl:
 990         * ksvg2/svg/SVGColor.idl:
 991         * ksvg2/svg/SVGCursorElement.idl:
 992         * ksvg2/svg/SVGDefsElement.idl:
 993         * ksvg2/svg/SVGDescElement.idl:
 994         * ksvg2/svg/SVGDocument.idl:
 995         * ksvg2/svg/SVGEllipseElement.idl:
 996         * ksvg2/svg/SVGPointList.idl:
 997         * ksvg2/svg/SVGPreserveAspectRatio.idl:
 998         * ksvg2/svg/SVGRect.idl:
 999         * ksvg2/svg/SVGSVGElement.idl:
1000
1001 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
1002
1003         Reviewed by Adele.
1004
1005         - fix build
1006
1007         * platform/FloatRect.h:
1008         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
1009         but more appropriate for path-type stuff.
1010         * platform/cg/PathCG.cpp:
1011         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
1012
1013 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
1014
1015         Reviewed by Darin.
1016
1017         http://bugs.webkit.org/show_bug.cgi?id=11011
1018         External CSS is parsed as iso-8859-1 even though the main document is utf-8
1019
1020         Test: fast/encoding/css-charset-default.xhtml
1021
1022         * loader/CachedResourceClient.h:
1023         (WebCore::CachedResourceClient::setCSSStyleSheet):
1024         (WebCore::CachedResourceClient::setXSLStyleSheet):
1025         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
1026         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
1027
1028         * css/CSSImportRule.cpp:
1029         (WebCore::CSSImportRule::setCSSStyleSheet):
1030         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
1031         * css/CSSImportRule.h:
1032
1033         * css/CSSStyleSheet.cpp:
1034         (WebCore::CSSStyleSheet::CSSStyleSheet):
1035         * css/CSSStyleSheet.h:
1036         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
1037         member. Changed some String parameters to const String&.
1038
1039         * css/StyleSheet.cpp:
1040         (WebCore::StyleSheet::StyleSheet):
1041         * css/StyleSheet.h:
1042         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
1043
1044         * css/StyleSheetList.cpp:
1045         (WebCore::StyleSheetList::length):
1046         (WebCore::StyleSheetList::item):
1047         * css/StyleSheetList.h:
1048         Special-casing implicit stylesheets seemed to be dead code, removed.
1049
1050         * dom/Document.cpp:
1051         (WebCore::Document::setCSSStyleSheet):
1052         (WebCore::Document::recalcStyleSelector):
1053         * dom/Document.h:
1054         Renamed setStyleSheet() to setCSSStyleSheet().
1055
1056         * dom/ProcessingInstruction.cpp:
1057         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
1058         (WebCore::ProcessingInstruction::setCSSStyleSheet):
1059         (WebCore::ProcessingInstruction::setXSLStyleSheet):
1060         (WebCore::ProcessingInstruction::parseStyleSheet):
1061         * dom/ProcessingInstruction.h:
1062
1063         * html/HTMLLinkElement.cpp:
1064         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute
1065         is not specified.
1066         (WebCore::HTMLLinkElement::setCSSStyleSheet):
1067         * html/HTMLLinkElement.h:
1068
1069         * html/HTMLStyleElement.cpp:
1070         (WebCore::HTMLStyleElement::childrenChanged):
1071         * ksvg2/svg/SVGStyleElement.cpp:
1072         (WebCore::SVGStyleElement::childrenChanged):
1073         Inherit URL and charset from the document.
1074
1075         * loader/Cache.cpp:
1076         (WebCore::Cache::requestCSSStyleSheet):
1077         * loader/Cache.h:
1078         Adjust for setStyleSheet() renaming.
1079
1080         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
1081         * loader/CachedCSSStyleSheet.cpp:
1082         (WebCore::CachedCSSStyleSheet::ref):
1083         (WebCore::CachedCSSStyleSheet::deref):
1084         (WebCore::CachedCSSStyleSheet::checkNotify):
1085         Pass the encoding to setCSSStyleSheet().
1086
1087         * loader/CachedXSLStyleSheet.cpp:
1088         (WebCore::CachedXSLStyleSheet::ref):
1089         (WebCore::CachedXSLStyleSheet::checkNotify):
1090         * loader/DocLoader.cpp:
1091         (WebCore::DocLoader::requestCSSStyleSheet):
1092         * loader/DocLoader.h:
1093         * page/Frame.cpp:
1094         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
1095         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
1096         * xml/XSLImportRule.cpp:
1097         (WebCore::XSLImportRule::setXSLStyleSheet):
1098         (WebCore::XSLImportRule::loadSheet):
1099         * xml/XSLImportRule.h:
1100         Adjust for setStyleSheet() renaming.
1101
1102 2006-09-30  Rob Buis  <buis@kde.org>
1103
1104         Reviewed by eseidel.
1105
1106         http://bugs.webkit.org/show_bug.cgi?id=11096
1107         Hit testing for polylines fails
1108
1109         Fix Path::contains so it handles filled, non-closed paths too.
1110
1111         * platform/cg/PathCG.cpp:
1112         (WebCore::Path::contains):
1113
1114 2006-09-30  Dave Hyatt  <hyatt@apple.com>
1115
1116         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
1117         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
1118         subframes while the mouse is down.
1119
1120         Reviewed by mitzpettel
1121
1122         * bridge/mac/FrameMac.h:
1123         * bridge/mac/FrameMac.mm:
1124         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
1125         (WebCore::FrameMac::passWheelEventToWidget):
1126         * bridge/mac/FrameViewMac.mm:
1127         (WebCore::FrameView::passMousePressEventToSubframe):
1128         (WebCore::FrameView::passMouseMoveEventToSubframe):
1129         (WebCore::FrameView::passMouseReleaseEventToSubframe):
1130         (WebCore::FrameView::passWheelEventToSubframe):
1131         * page/Frame.cpp:
1132         * page/Frame.h:
1133         * page/FrameView.cpp:
1134         (WebCore::subframeForTargetNode):
1135         (WebCore::FrameView::handleMousePressEvent):
1136         (WebCore::FrameView::handleMouseDoubleClickEvent):
1137         (WebCore::FrameView::handleMouseMoveEvent):
1138         (WebCore::FrameView::handleMouseReleaseEvent):
1139         (WebCore::FrameView::handleWheelEvent):
1140         * page/FrameView.h:
1141         * platform/ScrollBar.h:
1142         (WebCore::ScrollBar::handleMouseMoveEvent):
1143         (WebCore::ScrollBar::handleMouseOutEvent):
1144         * platform/Widget.h:
1145         (WebCore::Widget::handleMouseMoveEvent):
1146         (WebCore::Widget::handleMouseReleaseEvent):
1147         * platform/win/TemporaryLinkStubs.cpp:
1148         (FrameView::passMousePressEventToSubframe):
1149         (FrameView::passMouseMoveEventToSubframe):
1150         (FrameView::passMouseReleaseEventToSubframe):
1151         (FrameView::passWheelEventToSubframe):
1152         (Widget::capturingMouse):
1153         (Widget::setCapturingMouse):
1154         (Widget::capturingTarget):
1155         (Widget::capturingChild):
1156         (Widget::setCapturingChild):
1157         * rendering/RenderView.cpp:
1158         (WebCore::RenderView::paintBoxDecorations):
1159
1160 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
1161
1162         Reviewed by Adele.
1163
1164         Fixes windows bustage:
1165         http://bugs.webkit.org/show_bug.cgi?id=11093
1166
1167         * platform/win/PlatformScrollBar.h:
1168         * platform/win/TemporaryLinkStubs.cpp:
1169         (PlatformScrollBar::PlatformScrollBar):
1170         (ScrollBar::ScrollBar):
1171
1172 2006-09-29  David Hyatt  <hyatt@apple.com>
1173
1174         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
1175         in RenderObject::NodeInfo (and then propagating that Widget to
1176         MouseEventWithHitTestResults).
1177
1178         This allows RenderListBox and RenderBlock to do the same thing when the
1179         mouse is over the scrollbar.
1180
1181         Also land fix to support font-size: 0.
1182
1183         Reviewed by mjs (scrollbar), eric (font-size)
1184
1185         * dom/Document.cpp:
1186         (WebCore::Document::prepareMouseEvent):
1187         * page/Frame.cpp:
1188         (WebCore::Frame::passWidgetMouseDownEventToWidget):
1189         * page/FrameView.cpp:
1190         (WebCore::selectCursor):
1191         (WebCore::FrameView::handleMouseMoveEvent):
1192         (WebCore::FrameView::dispatchMouseEvent):
1193         * page/MouseEventWithHitTestResults.cpp:
1194         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
1195         * page/MouseEventWithHitTestResults.h:
1196         (WebCore::MouseEventWithHitTestResults::scrollbar):
1197         * rendering/RenderBlock.cpp:
1198         (WebCore::RenderBlock::isPointInScrollbar):
1199         (WebCore::RenderBlock::nodeAtPoint):
1200         * rendering/RenderBlock.h:
1201         * rendering/RenderLayer.cpp:
1202         (WebCore::RenderLayer::hitTest):
1203         * rendering/RenderLayer.h:
1204         (WebCore::RenderLayer::getHiddenBehavior):
1205         * rendering/RenderListBox.cpp:
1206         (WebCore::RenderListBox::RenderListBox):
1207         (WebCore::RenderListBox::~RenderListBox):
1208         (WebCore::RenderListBox::isPointInScrollbar):
1209         * rendering/RenderListBox.h:
1210         * rendering/RenderObject.h:
1211         (WebCore::RenderObject::NodeInfo::NodeInfo):
1212         (WebCore::RenderObject::NodeInfo::scrollbar):
1213         (WebCore::RenderObject::NodeInfo::setScrollbar):
1214
1215 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
1216
1217         Reviewed by Adele.
1218
1219         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
1220
1221         * platform/win/ScrollViewWin.cpp:
1222         (WebCore::ScrollView::convertToContainingWindow):
1223         (WebCore::ScrollView::convertFromContainingWindow):
1224         * platform/win/WidgetWin.cpp:
1225         (WebCore::Widget::convertToContainingWindow):
1226         (WebCore::Widget::convertFromContainingWindow):
1227
1228 2006-09-29  Adele Peterson  <adele@apple.com>
1229
1230         Updated with new argument for PlatformScrollBar.
1231
1232         * platform/win/TemporaryLinkStubs.cpp:
1233         (PlatformScrollBar::PlatformScrollBar):
1234
1235 2006-09-29  Adele Peterson  <adele@apple.com>
1236
1237         Reviewed by Hyatt.
1238
1239         Fixing build bustage with cast to int.
1240
1241         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
1242
1243 2006-09-29  Adele Peterson  <adele@apple.com>
1244
1245         Fixing accidental include.
1246
1247         * rendering/RenderListBox.cpp:
1248
1249 2006-09-29  Adele Peterson  <adele@apple.com>
1250
1251         Adding RenderListBox files.
1252
1253         * WebCore.vcproj/WebCore/WebCore.vcproj:
1254
1255 2006-09-29  Adele Peterson  <adele@apple.com>
1256
1257         Reviewed by Adam.
1258
1259         Initial implementation of engine-based list box control.
1260
1261         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
1262
1263         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
1264         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
1265         (WebCore::FrameMac::FrameMac):
1266         (WebCore::FrameMac::handleMousePressEvent):
1267         (WebCore::FrameMac::handleMouseMoveEvent):
1268         (WebCore::FrameMac::mouseDown):
1269
1270         * page/Frame.cpp:
1271         (WebCore::Frame::handleMouseMoveEvent):
1272         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
1273         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
1274         (WebCore::Frame::autoscrollTimerFired): ditto.
1275         (WebCore::Frame::stopAutoscrollTimer): ditto.
1276         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
1277         * page/Frame.h:
1278         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
1279
1280         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
1281         (WebCore::FrameViewPrivate::reset):
1282         (WebCore::FrameView::currentMousePosition):
1283         (WebCore::FrameView::handleMousePressEvent):
1284         (WebCore::FrameView::handleMouseDoubleClickEvent):
1285         (WebCore::selectCursor):
1286         (WebCore::FrameView::handleMouseMoveEvent):
1287         (WebCore::FrameView::handleMouseReleaseEvent):
1288         * page/FrameView.h:
1289
1290         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
1291         * platform/ScrollBar.h:
1292         (WebCore::):
1293         (WebCore::ScrollBar::controlSize):
1294         * platform/mac/PlatformScrollBar.h:
1295         * platform/mac/PlatformScrollBarMac.mm:
1296         (NSControlSizeForScrollBarControlSize):
1297         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
1298         (WebCore::PlatformScrollBar::PlatformScrollBar):
1299
1300         * rendering/RenderBlock.h:
1301         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
1302         * rendering/RenderLayer.h:
1303         * rendering/RenderObject.cpp:
1304         (WebCore::RenderObject::shouldAutoscroll):
1305         (WebCore::RenderObject::autoscroll):
1306         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
1307
1308         * css/html4.css: Added properties for new list boxes.
1309
1310         * html/HTMLOptionElement.cpp:
1311         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
1312         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
1313         * html/HTMLOptionElement.h: Added disabled method.
1314
1315         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
1316         (WebCore::HTMLSelectElement::recalcStyle):
1317         (WebCore::HTMLSelectElement::lastSelectedListIndex):
1318         (WebCore::HTMLSelectElement::deselectItems):
1319         (WebCore::HTMLSelectElement::setSelectedIndex):
1320         (WebCore::HTMLSelectElement::isKeyboardFocusable):
1321         (WebCore::HTMLSelectElement::isMouseFocusable):
1322         (WebCore::HTMLSelectElement::createRenderer):
1323         (WebCore::HTMLSelectElement::recalcListItems):
1324         (WebCore::HTMLSelectElement::setRecalcListItems):
1325         (WebCore::HTMLSelectElement::reset):
1326         (WebCore::HTMLSelectElement::notifyOptionSelected):
1327         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
1328         (WebCore::HTMLSelectElement::nextSelectableListIndex):
1329         (WebCore::HTMLSelectElement::previousSelectableListIndex):
1330         * html/HTMLSelectElement.h:
1331
1332         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
1333         (WebCore::RenderTheme::paint):
1334         (WebCore::RenderTheme::paintBorderOnly):
1335         (WebCore::RenderTheme::paintDecorations):
1336         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
1337         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
1338         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
1339         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
1340         (WebCore::RenderTheme::isControlStyled):
1341         (WebCore::RenderTheme::supportsFocusRing):
1342         * rendering/RenderTheme.h:
1343         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
1344
1345         * rendering/RenderListBox.cpp: Added.
1346         (WebCore::RenderListBox::RenderListBox):
1347         (WebCore::RenderListBox::~RenderListBox):
1348         (WebCore::RenderListBox::setStyle):
1349         (WebCore::RenderListBox::updateFromElement):
1350         (WebCore::RenderListBox::calcMinMaxWidth):
1351         (WebCore::RenderListBox::size):
1352         (WebCore::RenderListBox::numItems):
1353         (WebCore::RenderListBox::calcHeight):
1354         (WebCore::RenderListBox::baselinePosition):
1355         (WebCore::RenderListBox::itemBoundingBoxRect):
1356         (WebCore::RenderListBox::paintObject):
1357         (WebCore::RenderListBox::paintScrollbar):
1358         (WebCore::RenderListBox::paintItemForeground):
1359         (WebCore::RenderListBox::paintItemBackground):
1360         (WebCore::RenderListBox::scrollBarTarget):
1361         (WebCore::RenderListBox::isPointInScrollbar):
1362         (WebCore::RenderListBox::optionAtPoint):
1363         (WebCore::RenderListBox::autoscroll):
1364         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
1365         (WebCore::RenderListBox::scroll):
1366         (WebCore::RenderListBox::valueChanged):
1367         * rendering/RenderListBox.h: Added.
1368         (WebCore::RenderListBox::isListBox):
1369         (WebCore::RenderListBox::selectionChanged):
1370         (WebCore::RenderListBox::setSelectionChanged):
1371         (WebCore::RenderListBox::canHaveChildren):
1372         (WebCore::RenderListBox::renderName):
1373         (WebCore::RenderListBox::setOptionsChanged):
1374         (WebCore::RenderListBox::shouldAutoscroll):
1375         (WebCore::RenderListBox::listIndexIsVisible):
1376
1377 2006-09-29  Beth Dakin  <bdakin@apple.com>
1378
1379         Reviewed by Darin.
1380
1381         We had a bug where html4.css was ignoring Media Queries. In the end
1382         the problem was that we were trying to send a char* to the
1383         MediaQueryEvaluator constructor that expects a String, but the
1384         char* got interpreted as a bool, the wrong constructor was called,
1385         and the media type was never set.
1386
1387         No test case possible since this only affects html4.css
1388
1389         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a
1390         char*
1391         (WebCore::MediaQueryEvaluator):
1392         * css/MediaQueryEvaluator.h: Same.
1393
1394 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
1395
1396         Reviewed by John, Maciej.
1397
1398         Integrated some frame and iframe code. I'm trying to fix up frame ownership
1399         and loading. Reducing the number of different code paths involved
1400         seemed like a good first step.
1401
1402         As a side effect, I fixed a bug where FRAME elements would report their
1403         src attributes as relative, rather than compelete, URLs. (IFRAME elements
1404         had the correct complete URL behavior.)
1405
1406         * html/HTMLFrameElement.cpp:
1407         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
1408         (WebCore::HTMLFrameElement::openURL):
1409             (1) Removed checks that requestFrame does for us
1410             (2) Added isURLAllowed check, to have one clear bottleneck for it
1411             (3) Added viewsource check, to have one clear bottleneck for it
1412         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
1413         method, instead of finding our content frame in our own unique way.
1414         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
1415         since openURL does this for us now.
1416         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
1417         This is what FF does, and it made no sense to have different behaviors
1418         for FRAME and IFRAME elements.
1419         * html/HTMLIFrameElement.cpp:
1420         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
1421         code.
1422         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
1423         HTMLFrameElement now does everything we need.
1424
1425 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
1426
1427         Reviewed by Hyatt.
1428
1429         Fix Qt/Linux build.
1430
1431         * CMakeLists.txt:
1432         * platform/qt/ScrollViewQt.cpp:
1433         (WebCore::ScrollView::convertToContainingWindow):
1434         (WebCore::ScrollView::convertFromContainingWindow):
1435         * platform/qt/TemporaryLinkStubs.cpp:
1436         (WebCore::signedPublicKeyAndChallengeString):
1437         * platform/qt/WidgetQt.cpp:
1438         (WebCore::Widget::convertToContainingWindow):
1439         (WebCore::Widget::convertFromContainingWindow):
1440
1441 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
1442
1443         Reviewed by Tim H.
1444
1445         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
1446         Simplify Internal methods for the auto-generated Objective-C DOM code
1447
1448         - Auto-generate the internal methods for more Objective-C classes.
1449
1450         * WebCore.xcodeproj/project.pbxproj:
1451         * bindings/objc/DOM.mm:
1452         * bindings/objc/DOMCSS.mm:
1453         (-[DOMStyleSheet WebCore::]):
1454         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
1455         (-[DOMCSSRule WebCore::]):
1456         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
1457         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
1458         (-[DOMCSSValue WebCore::]):
1459         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
1460         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1461         * bindings/objc/DOMHTMLAppletElement.mm:
1462         (-[DOMHTMLAppletElement WebCore::]):
1463         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
1464         * bindings/objc/DOMHTMLEmbedElement.mm:
1465         (-[DOMHTMLEmbedElement WebCore::]):
1466         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
1467         * bindings/objc/DOMInternal.h:
1468         * bindings/objc/DOMInternal.mm:
1469         * bindings/scripts/CodeGeneratorObjC.pm:
1470         * css/CSSCharsetRule.idl:
1471         * css/CSSFontFaceRule.idl:
1472         * css/CSSImportRule.idl:
1473         * css/CSSMediaRule.idl:
1474         * css/CSSPageRule.idl:
1475         * css/CSSPrimitiveValue.idl:
1476         * css/CSSStyleRule.idl:
1477         * css/CSSStyleSheet.idl:
1478         * css/CSSUnknownRule.idl:
1479         * css/CSSValueList.idl:
1480         * dom/KeyboardEvent.idl:
1481         * dom/MouseEvent.idl:
1482         * dom/MutationEvent.idl:
1483         * dom/NodeIterator.idl:
1484         * dom/OverflowEvent.idl:
1485         * dom/UIEvent.idl:
1486         * dom/WheelEvent.idl:
1487
1488 2006-09-29  David Harrison  <harrison@apple.com>
1489
1490         Reviewed by John Sullivan.
1491
1492         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
1493         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
1494
1495         Test added
1496         * fast/text/attributed-substring-from-range-001.html
1497
1498         * bridge/mac/FrameMac.mm:
1499         (WebCore::FrameMac::attributedString):
1500         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
1501         Also, add validation of the range.
1502
1503 2006-09-29  Rob Buis  <buis@kde.org>
1504
1505         Reviewed by Maciej.
1506
1507         http://bugs.webkit.org/show_bug.cgi?id=10893
1508         InsertRule can not handle @import statements
1509
1510         Allow @import as part of a css rule.
1511
1512         * css/CSSGrammar.y:
1513
1514 2006-09-28  David Hyatt  <hyatt@apple.com>
1515
1516         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
1517
1518         * bridge/mac/FrameMac.mm:
1519         (WebCore::FrameMac::eventMayStartDrag):
1520         (WebCore::FrameMac::dragHysteresisExceeded):
1521         (WebCore::FrameMac::mouseDown):
1522         (WebCore::FrameMac::shouldDragAutoNode):
1523         (WebCore::FrameMac::sendContextMenuEvent):
1524         * bridge/mac/WebCoreFrameBridge.mm:
1525         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
1526
1527 2006-09-28  Dave Hyatt  <hyatt@apple.com>
1528
1529         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
1530         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
1531         view.
1532
1533         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
1534         the patch after review, once I realized that these new functions essentially do the same thing.)
1535
1536         * dom/EventTargetNode.cpp:
1537         (WebCore::EventTargetNode::dispatchMouseEvent):
1538         (WebCore::EventTargetNode::dispatchWheelEvent):
1539         * page/Frame.cpp:
1540         (WebCore::Frame::selectClosestWordFromMouseEvent):
1541         (WebCore::Frame::handleMousePressEventTripleClick):
1542         (WebCore::Frame::handleMousePressEventSingleClick):
1543         (WebCore::Frame::handleMouseMoveEvent):
1544         (WebCore::Frame::handleMouseReleaseEvent):
1545         * page/FrameView.cpp:
1546         (WebCore::FrameView::handleMousePressEvent):
1547         (WebCore::selectCursor):
1548         (WebCore::FrameView::dispatchDragEvent):
1549         (WebCore::FrameView::prepareMouseEvent):
1550         (WebCore::FrameView::handleWheelEvent):
1551         * platform/ScrollView.h:
1552         * platform/Widget.cpp:
1553         (WebCore::Widget::convertToContainingWindow):
1554         * platform/Widget.h:
1555         * platform/mac/ScrollViewMac.mm:
1556         (WebCore::ScrollView::convertToContainingWindow):
1557         (WebCore::ScrollView::convertFromContainingWindow):
1558         * platform/mac/WidgetMac.mm:
1559         (WebCore::Widget::convertToContainingWindow):
1560         (WebCore::Widget::convertFromContainingWindow):
1561         * platform/win/ScrollViewWin.cpp:
1562         (WebCore::ScrollView::convertToContainingWindow):
1563         (WebCore::ScrollView::convertFromContainingWindow):
1564         * rendering/RenderLayer.cpp:
1565         (WebCore::RenderLayer::resize):
1566
1567 2006-09-28  Alice Liu  <alice.liu@apple.com>
1568
1569         Build fix by adding missing files for CommandByName
1570
1571         * WebCore.xcodeproj/project.pbxproj:
1572
1573 2006-09-28  Alice Liu  <alice.liu@apple.com>
1574
1575         Adding CommandByName files to the vcproj
1576
1577         * WebCore.vcproj/WebCore/WebCore.vcproj:
1578
1579 2006-09-28  Alice Liu  <alice.liu@apple.com>
1580
1581         Reviewed by Adam Roben.
1582
1583         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc.
1584         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
1585         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
1586
1587         * editing/CommandByName.cpp: Added.
1588         Added a command class that hangs off the frame so the frame can call commands more easily.
1589         (WebCore::Frame::commandImp):
1590         (WebCore::Frame::execCopy):
1591         (WebCore::Frame::execCut):
1592         (WebCore::Frame::execDelete):
1593         (WebCore::Frame::execForwardDelete):
1594         (WebCore::Frame::execPaste):
1595         (WebCore::Frame::execMoveLeft):
1596         (WebCore::Frame::execMoveRight):
1597         (WebCore::Frame::execMoveUp):
1598         (WebCore::Frame::execMoveDown):
1599         (WebCore::Frame::execSelectAll):
1600         (WebCore::Frame::execSelectLeft):
1601         (WebCore::Frame::execSelectRight):
1602         (WebCore::Frame::execSelectUp):
1603         (WebCore::Frame::execSelectDown):
1604         (WebCore::Frame::enabled):
1605         (WebCore::Frame::enabledAnySelection):
1606         (WebCore::Frame::enabledAnyEditableSelection):
1607         (WebCore::Frame::enabledPaste):
1608         (WebCore::Frame::enabledAnyRangeSelection):
1609         (WebCore::Frame::enabledAnyEditableRangeSelection):
1610         (WebCore::Frame::createCommandDictionary):
1611         (WebCore::Frame::Command::):
1612         (WebCore:::m_frame):
1613         (WebCore::CommandByName::execCommand):
1614         * editing/CommandByName.h: Added.
1615         * page/Frame.cpp:
1616         Added implementation of accessor for CommandByName member
1617         (WebCore::Frame::command):
1618         * page/Frame.h:
1619         Added accessor for CommandByName member
1620         * page/FramePrivate.h:
1621         Added a CommandByName member
1622         (WebCore::FramePrivate::FramePrivate):
1623         * platform/PlatformMouseEvent.h:
1624         Changed constructor prototype
1625         * platform/StringImpl.cpp:
1626         Exposing getWordBreakIterator to be used elsewhere
1627         (WebCore::getWordBreakIterator):
1628         * platform/StringImpl.h:
1629         Exposing getWordBreakIterator to be used elsewhere
1630         * platform/win/MouseEventWin.cpp:
1631         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
1632         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1633
1634 2006-09-28  Adam Roben  <aroben@apple.com>
1635
1636         Reviewed by Adele.
1637
1638         Remove no-longer-used PopUpButton.
1639
1640         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
1641         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
1642         PopUpButtonMac.mm
1643         * platform/PopUpButton.h: Removed.
1644         * platform/mac/PopUpButtonMac.mm: Removed.
1645         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
1646         * rendering/DeprecatedRenderSelect.cpp: Change #include of
1647         PopUpButton.h to ListBox.h
1648
1649 2006-09-28  Darin Adler  <darin@apple.com>
1650
1651         Reviewed by Alice.
1652
1653         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
1654           10% perf. regression (copying strings while decoding)
1655
1656         Use Vector<UChar> instead of String when building up the decoded string in
1657         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
1658         String grows the buffer every single time that append is called. Using
1659         Vector::append instead of String::append also avoids constructing a string
1660         each time just to append and a questionable copy that is done inside the
1661         String::append function which also contributed to the slowness.
1662
1663         * platform/PlatformString.h:
1664         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
1665         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
1666         allocation.
1667         * platform/StringImpl.h:
1668         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
1669
1670         * platform/StreamingTextDecoder.h:
1671         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
1672         Change to use a Vector<UChar> instead of a String, since vectors have better
1673         resizing performance (they store a separate capacity).
1674
1675         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
1676         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
1677         Change to use Vector<UChar> instead of String and then create a string at
1678         the end of the process using the new adopt function.
1679
1680 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
1681
1682         Reviewed by Tim H.
1683
1684         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
1685         Auto-generate more SVG Objective-C bindings
1686
1687         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean,
1688           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
1689           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
1690           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
1691           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
1692           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests,
1693           and DOMSVGTransformable.
1694
1695         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
1696           parent interfaces and the SVG animated classes.
1697
1698         - Corrects CodeGenerator.pm to only skip the first parent for the main
1699           interface.
1700
1701         * DerivedSources.make:
1702         * WebCore.xcodeproj/project.pbxproj:
1703         * bindings/objc/DOMInternal.h:
1704         * bindings/objc/DOMSVG.h:
1705         * bindings/scripts/CodeGenerator.pm:
1706         * bindings/scripts/CodeGeneratorObjC.pm:
1707         * ksvg2/svg/SVGAnimatedAngle.idl:
1708         * ksvg2/svg/SVGAnimatedBoolean.idl:
1709         * ksvg2/svg/SVGAnimatedEnumeration.idl:
1710         * ksvg2/svg/SVGAnimatedInteger.idl:
1711         * ksvg2/svg/SVGAnimatedLength.idl:
1712         * ksvg2/svg/SVGAnimatedLengthList.idl:
1713         * ksvg2/svg/SVGAnimatedNumber.idl:
1714         * ksvg2/svg/SVGAnimatedPathData.idl:
1715         * ksvg2/svg/SVGAnimatedString.idl:
1716         * ksvg2/svg/SVGAnimatedTransformList.idl:
1717         * ksvg2/svg/SVGExternalResourcesRequired.idl:
1718         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
1719         * ksvg2/svg/SVGFitToViewBox.idl:
1720         * ksvg2/svg/SVGLangSpace.idl:
1721         * ksvg2/svg/SVGLocatable.idl:
1722         * ksvg2/svg/SVGMetadataElement.idl:
1723         * ksvg2/svg/SVGStringList.idl:
1724         * ksvg2/svg/SVGStylable.idl:
1725         * ksvg2/svg/SVGStyleElement.idl:
1726         * ksvg2/svg/SVGTests.idl:
1727         * ksvg2/svg/SVGTransformable.idl:
1728         * ksvg2/svg/SVGURIReference.idl:
1729         * ksvg2/svg/SVGUnitTypes.idl:
1730         * ksvg2/svg/SVGZoomAndPan.idl:
1731
1732 2006-09-28  Brady Eidson  <beidson@apple.com>
1733
1734         Reviewed by Mitz Pettel!!!
1735
1736         Change the error code check for common functions from SQLResultOk to SQLResultDone
1737
1738         * loader/icon/IconDatabase.cpp:
1739         (WebCore::IconDatabase::forgetPageURLQuery):
1740         (WebCore::IconDatabase::setIconIDForPageURLQuery):
1741         (WebCore::IconDatabase::addIconForIconURLQuery):
1742
1743 2006-09-28  Dave Hyatt  <hyatt@apple.com>
1744
1745         Just eliminate MapWindowPoints usage and use the HWND as
1746         the viewport.
1747
1748         * platform/win/MouseEventWin.cpp:
1749         (WebCore::positionForEvent):
1750         * platform/win/ScrollViewWin.cpp:
1751         (WebCore::ScrollView::viewportToContents):
1752         (WebCore::ScrollView::contentsToViewport):
1753
1754 2006-09-27  David Hyatt  <hyatt@apple.com>
1755
1756         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
1757         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
1758         scrollbars to provide hover feedback if needed.
1759
1760         Reviewed by Eric
1761
1762         * page/FrameView.cpp:
1763         (WebCore::selectCursor):
1764         (WebCore::FrameView::handleMouseMoveEvent):
1765         * platform/ScrollBar.h:
1766         (WebCore::ScrollBar::mouseMoved):
1767
1768 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
1769
1770         Reviewed by Maciej and Adam, landed by Adam
1771
1772         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
1773         Windows build is busted
1774
1775         * platform/win/TemporaryLinkStubs.cpp:
1776         (ScrollView::paint):
1777         (ScrollView::themeChanged):
1778
1779 2006-09-27  Eric Seidel  <eric@eseidel.com>
1780
1781         Reviewed by mitz.
1782
1783         paths with no fill specified default to black but do not recieve paint-related mouse events
1784         http://bugs.webkit.org/show_bug.cgi?id=11069
1785         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
1786
1787         Test: svg/custom/hover-default-fill.svg
1788
1789         * kcanvas/RenderPath.cpp:
1790         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
1791         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
1792         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1793         (WebCore::KSVGPainterFactory::isFilled): remove null check
1794         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
1795         (WebCore::KSVGPainterFactory::isStroked): remove null check
1796         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
1797         * ksvg2/svg/SVGPaint.cpp:
1798         (WebCore::SVGPaint::defaultFill): added.
1799         (WebCore::SVGPaint::defaultStroke): added.
1800         * ksvg2/svg/SVGPaint.h:
1801
1802 2006-09-27  Rob Buis  <buis@kde.org>
1803
1804         Reviewed by eseidel.
1805
1806         http://bugs.webkit.org/show_bug.cgi?id=11015
1807         SVG handles em units incorrectly
1808
1809         Calculate viewport coordinates at layout time, since
1810         at this point the font size is known and lengths depending
1811         on font sizes can be calculated correctly.
1812
1813         * kcanvas/RenderSVGContainer.cpp:
1814         (WebCore::RenderSVGContainer::layout):
1815         (WebCore::RenderSVGContainer::viewport):
1816         (WebCore::RenderSVGContainer::calcViewport):
1817         * kcanvas/RenderSVGContainer.h:
1818         * ksvg2/svg/SVGLength.cpp:
1819         (WebCore::SVGLength::updateValue):
1820         * ksvg2/svg/SVGMarkerElement.cpp:
1821         (WebCore::SVGMarkerElement::createRenderer):
1822         * ksvg2/svg/SVGSVGElement.cpp:
1823         (WebCore::SVGSVGElement::createRenderer):
1824         (WebCore::SVGSVGElement::attributeChanged):
1825         * ksvg2/svg/SVGSVGElement.h:
1826
1827 2006-09-27  Eric Seidel  <eric@eseidel.com>
1828
1829         Reviewed by darin.
1830
1831         Change our invalid-fill error behavior to match Opera (and soon Firefox)
1832         http://bugs.webkit.org/show_bug.cgi?id=11017
1833
1834         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1835         (WebCore::KSVGPainterFactory::isFilled):
1836         (WebCore::KSVGPainterFactory::fillPaintServer):
1837         (WebCore::KSVGPainterFactory::isStroked):
1838         (WebCore::KSVGPainterFactory::strokePaintServer):
1839
1840 2006-09-27  Brady Eidson  <beidson@apple.com>
1841
1842         Build fix
1843
1844         * loader/icon/IconDatabase.cpp:
1845         (WebCore::readySQLStatement):
1846
1847 2006-09-27  Brady Eidson  <beidson@apple.com>
1848
1849         Reviewed by Adam
1850
1851         In very specific circumstances, prepared SQLStatements can become invalid without
1852         any warning.  This checks for that state and re-prepares the statement and also
1853         adds more aggressive error-checking everywhere these statements are used.
1854
1855         * loader/icon/IconDatabase.cpp:
1856         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
1857         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
1858         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
1859         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
1860         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
1861         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
1862         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
1863         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
1864         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
1865         * loader/icon/SQLStatement.cpp:
1866         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
1867         * loader/icon/SQLStatement.h:
1868
1869 2006-09-26  Darin Adler  <darin@apple.com>
1870
1871         Reviewed by Steve.
1872
1873         - clean up options for font code path
1874
1875         * platform/Font.h:
1876         * platform/Font.cpp:
1877         (WebCore::Font::setCodePath): Added. Replaces boolean version.
1878         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
1879
1880         * platform/mac/WebCoreTextRenderer.mm:
1881         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
1882
1883 2006-09-26  John Sullivan  <sullivan@apple.com>
1884
1885         Reviewed by Darin
1886
1887         * bridge/mac/WebCoreFrameBridge.h:
1888         * bridge/mac/WebCoreFrameBridge.mm:
1889         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
1890         Added limit parameter, passed down to Frame
1891
1892         * page/Frame.h:
1893         * page/Frame.cpp:
1894         (WebCore::Frame::markAllMatchesForText):
1895         Added limit parameter. Stop the search if it hits limit.
1896
1897 2006-09-26  Sean Gies  <seangies@apple.com>
1898
1899         Reviewed by Brady Eidson.
1900
1901         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
1902
1903 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
1904
1905         Reviewed by john
1906
1907         <rdar://problem/4747695>
1908         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
1909
1910         * editing/DeleteSelectionCommand.cpp:
1911         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
1912         to select special elements that are fully selected after expansion
1913         moves to positions that are visually distinct from the originals.
1914         * editing/InsertListCommand.cpp:
1915         (WebCore::InsertListCommand::doApply): If the content of the list
1916         item will be moved into another list, put it in a list item.
1917
1918 2006-09-26  Geoffrey Garen <ggaren@apple.com>
1919
1920         Reviewed by Darin.
1921
1922         Temporary work-around for frame lifetime issue.
1923
1924         * page/Frame.cpp:
1925         (WebCore::Frame::clear):
1926         (WebCore::Frame::disconnectOwnerElement):
1927
1928 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
1929
1930         Reviewed by Tim H.
1931
1932         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
1933         Auto-generate DOMSVGElement for the Objective-C bindings
1934
1935         - Auto-generates DOMSVGElement.
1936
1937         - Make SVGExceptions work like all the other ExceptionCode
1938           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
1939           and SVGExceptionMax.
1940
1941         * DerivedSources.make:
1942         * WebCore.xcodeproj/project.pbxproj:
1943         * bindings/js/kjs_binding.cpp:
1944         (KJS::):
1945         (KJS::setDOMException):
1946         * bindings/objc/DOMInternal.h:
1947         * bindings/objc/DOMInternal.mm:
1948         (raiseDOMException):
1949         * bindings/objc/DOMSVG.h:
1950         * bindings/objc/DOMSVGExecption.h: Added.
1951         * ksvg2/ksvg.h:
1952         * ksvg2/svg/SVGElement.cpp:
1953         (WebCore::SVGElement::setId):
1954         (WebCore::SVGElement::setXmlbase):
1955         * ksvg2/svg/SVGElement.h:
1956         * ksvg2/svg/SVGElement.idl:
1957         * ksvg2/svg/SVGException.h: Added.
1958         (WebCore::):
1959
1960 2006-09-26  Eric Seidel  <eric@eseidel.com>
1961
1962         Reviewed by Tim H.
1963
1964         viewbox parser does not allow <tab> as a delimiter
1965         http://bugs.webkit.org/show_bug.cgi?id=11014
1966
1967         Test: svg/hixie/viewbox/003.xml
1968
1969         * ksvg2/svg/svgpathparser.cpp:
1970         (WebCore::isWhitespace): new function
1971         (WebCore::skipOptionalSpaces):
1972         (WebCore::skipOptionalSpacesOrComma):
1973
1974 2006-09-26  Eric Seidel  <eric@eseidel.com>
1975
1976         Reviewed by Tim H.
1977
1978         SVGDocument::createElement does not create elements in the SVG namespace
1979         http://bugs.webkit.org/show_bug.cgi?id=10932
1980
1981         Test: svg/custom/createelement.svg
1982
1983         * ksvg2/svg/SVGDocument.cpp:
1984         (WebCore::SVGDocument::createElement):
1985         * ksvg2/svg/SVGDocument.h:
1986
1987 2006-09-26  Eric Seidel  <eric@eseidel.com>
1988
1989         Reviewed by Tim H.
1990
1991         RenderPath::nodeAtPoint does not respect stroke width
1992         http://bugs.webkit.org/show_bug.cgi?id=10829
1993
1994         Test: svg/custom/stroke-width-click.svg
1995
1996         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1997         (WebCore::RenderPath::strokeContains):
1998         * kcanvas/device/quartz/QuartzSupport.h:
1999         * kcanvas/device/quartz/QuartzSupport.mm:
2000
2001 2006-09-26  Eric Seidel  <eric@eseidel.com>
2002
2003         Reviewed by mitz.
2004
2005         Bring animation back to life
2006         http://bugs.webkit.org/show_bug.cgi?id=11021
2007
2008         Register/unregister SVGSVGElements as time containers on insertion/removal.
2009         Replace uses of DeprecatedString with String in SVGAnimationElement
2010         Various whitespace clean-up.
2011
2012         * ksvg2/misc/KSVGTimeScheduler.cpp:
2013         (WebCore::SVGTimer::notifyAll):
2014         * ksvg2/misc/SVGDocumentExtensions.cpp:
2015         (WebCore::SVGDocumentExtensions::startAnimations):
2016         (WebCore::SVGDocumentExtensions::pauseAnimations):
2017         (WebCore::SVGDocumentExtensions::unpauseAnimations):
2018         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2019         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2020         (WebCore::SVGAnimateTransformElement::parseTransformValue):
2021         * ksvg2/svg/SVGAnimateTransformElement.h:
2022         * ksvg2/svg/SVGAnimationElement.cpp:
2023         (WebCore::SVGAnimationElement::SVGAnimationElement):
2024         (WebCore::SVGAnimationElement::parseMappedAttribute):
2025         (WebCore::SVGAnimationElement::parseClockValue):
2026         (WebCore::SVGAnimationElement::targetAttribute):
2027         (WebCore::SVGAnimationElement::setTargetAttribute):
2028         (WebCore::SVGAnimationElement::attributeName):
2029         * ksvg2/svg/SVGAnimationElement.h:
2030         (WebCore::SVGAnimationElement::rendererIsNeeded):
2031         * ksvg2/svg/SVGSVGElement.cpp:
2032         (WebCore::SVGSVGElement::getScreenCTM):
2033         (WebCore::SVGSVGElement::createRenderer):
2034         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
2035         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
2036         * ksvg2/svg/SVGSVGElement.h:
2037         * ksvg2/svg/SVGSetElement.cpp:
2038         (WebCore::SVGSetElement::handleTimerEvent):
2039         * ksvg2/svg/SVGURIReference.cpp:
2040         (WebCore::SVGURIReference::getTarget):
2041         * ksvg2/svg/SVGURIReference.h:
2042
2043 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
2044
2045         Reviewed by mitzpettel.
2046
2047         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
2048         No-SVG build broken since r16549
2049
2050         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
2051
2052         * css/cssparser.cpp:
2053         (WebCore::CSSParser::parseValue):
2054         * css/cssstyleselector.cpp:
2055         (WebCore::CSSStyleSelector::applyProperty):
2056         * page/FrameView.cpp:
2057         (WebCore::selectCursor):
2058         * platform/qt/GraphicsContextQt.cpp:
2059
2060 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
2061
2062         Reviewed by Maciej.
2063
2064         http://bugs.webkit.org/show_bug.cgi?id=10820
2065         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
2066
2067         (Originally written by Eric Seidel).
2068
2069         * bindings/js/kjs_window.cpp:
2070         (KJS::floatFeature):
2071         * ksvg2/svg/SVGAngle.cpp:
2072         (SVGAngle::setValueAsString):
2073         * ksvg2/svg/SVGAnimationElement.cpp:
2074         (SVGAnimationElement::parseMappedAttribute):
2075         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2076         (SVGComponentTransferFunctionElement::parseMappedAttribute):
2077         * ksvg2/svg/SVGFECompositeElement.cpp:
2078         (WebCore::SVGFECompositeElement::parseMappedAttribute):
2079         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2080         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
2081         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2082         (SVGFEDisplacementMapElement::parseMappedAttribute):
2083         * ksvg2/svg/SVGFELightElement.cpp:
2084         (SVGFELightElement::parseMappedAttribute):
2085         * ksvg2/svg/SVGFEOffsetElement.cpp:
2086         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
2087         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
2088         (SVGFESpecularLightingElement::parseMappedAttribute):
2089         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2090         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
2091         * ksvg2/svg/SVGStopElement.cpp:
2092         (SVGStopElement::parseMappedAttribute):
2093         * platform/AtomicString.h:
2094         (WebCore::AtomicString::toDouble):
2095         * platform/PlatformString.h:
2096         * platform/String.cpp:
2097         (WebCore::String::toDouble):
2098         * platform/StringImpl.cpp:
2099         (WebCore::StringImpl::toDouble):
2100         * platform/StringImpl.h:
2101         * rendering/DeprecatedSlider.cpp:
2102         (WebCore::DeprecatedSlider::updateFromElement):
2103         * xml/XPathGrammar.y:
2104
2105 2006-09-25  David Harrison  <harrison@apple.com>
2106
2107         Reviewed by Tim Omernick and Tim Hatcher.
2108
2109         <rdar://problem/4717965> Text Field text parameterized attributes should work
2110         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
2111
2112         * bridge/mac/WebCoreAXObject.mm:
2113         (-[WebCoreAXObject accessibilityAttributeValue:]):
2114         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
2115
2116         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
2117         Cleaned up. Added text field and text area parameterzed attributes.
2118
2119         (-[WebCoreAXObject doAXLineForTextMarker:]):
2120         Fixed to be zero-based and to deal with the first position properly.
2121
2122         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
2123         Minor formatting.
2124
2125         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
2126         (-[WebCoreAXObject indexForTextMarker:]):
2127         (-[WebCoreAXObject textMarkerRangeForRange:]):
2128         (-[WebCoreAXObject rangeForTextMarkerRange:]):
2129         New utility methods.
2130
2131         (-[WebCoreAXObject doAXLineForIndex:]):
2132         (-[WebCoreAXObject doAXRangeForLine:]):
2133         (-[WebCoreAXObject doAXStringForRange:]):
2134         (-[WebCoreAXObject doAXRangeForPosition:]):
2135         (-[WebCoreAXObject doAXRangeForIndex:]):
2136         (-[WebCoreAXObject doAXBoundsForRange:]):
2137         (-[WebCoreAXObject doAXAttributedStringForRange:]):
2138         (-[WebCoreAXObject doAXRTFForRange:]):
2139         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
2140         Implement text field and text area parameterized attributes.
2141
2142         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
2143         Added text field and text area parameterzed attributes.
2144
2145         * rendering/RenderTextControl.h:
2146         Made indexForVisiblePosition() and visiblePositionForIndex() public.
2147
2148 2006-09-25  Adam Roben  <aroben@apple.com>
2149
2150         Reviewed by Brady.
2151
2152         Build fixes.
2153
2154         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
2155         * platform/ResourceLoader.h: Store whether a particular job
2156         has received a response within the ResourceLoader object itself, since
2157         it's possible that we will enter the InternetReadFileExA while loop
2158         twice for the same job.
2159         * platform/ResourceLoaderInternal.h: Add private instance variable to
2160         store whether we've received a response.
2161         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2162         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
2163         directives.
2164         * platform/win/ResourceLoaderWin.cpp:
2165         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
2166         whether it has received a response instead of assuming it hasn't.
2167         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
2168         (WebCore::ResourceLoader::hasReceivedResponse): Added.
2169         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
2170         setProportion
2171         (ScrollBar::setProportion):
2172
2173 2006-09-25  Brady Eidson  <beidson@apple.com>
2174
2175         Requested by ggaren
2176
2177         Disabled IconDatabase logging by default
2178
2179         * platform/Logging.cpp:
2180         (WebCore::):
2181
2182 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
2183
2184         Build fix
2185
2186         * platform/cf/ResourceLoaderCFNet.cpp:
2187         (WebCore::willCacheResponse):
2188
2189 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
2190
2191         Reviewed by john
2192
2193         <http://bugs.webkit.org/show_bug.cgi?id=11002>
2194         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
2195
2196         * editing/IndentOutdentCommand.cpp:
2197         (WebCore::IndentOutdentCommand::indentRegion): Special case
2198         an empty root editable element.
2199
2200 2006-09-25  Brady Eidson  <beidson@apple.com>
2201
2202         Reviewed by Steve
2203
2204         Math error in SystemTimeWin
2205
2206         * platform/win/SystemTimeWin.cpp:
2207         (WebCore::currentTime):
2208
2209 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
2210
2211         Reviewed by Eric.
2212
2213         Whitespace cleanup; rename *job variables to *loader.
2214
2215         * bindings/js/JSXMLHttpRequest.cpp:
2216         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
2217         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
2218         (KJS::JSXMLHttpRequestConstructorImp::construct):
2219         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
2220         (KJS::JSXMLHttpRequest::getValueProperty):
2221         (KJS::JSXMLHttpRequest::put):
2222         (KJS::JSXMLHttpRequest::putValueProperty):
2223         (KJS::JSXMLHttpRequest::mark):
2224         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
2225         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
2226         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
2227         * bindings/js/JSXMLHttpRequest.h:
2228         (KJS::JSXMLHttpRequest::toBoolean):
2229         * xml/xmlhttprequest.cpp:
2230         (WebCore::XMLHttpRequest::XMLHttpRequest):
2231         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
2232         (WebCore::XMLHttpRequest::send):
2233         (WebCore::XMLHttpRequest::abort):
2234         (WebCore::XMLHttpRequest::receivedAllData):
2235         (WebCore::XMLHttpRequest::receivedData):
2236         * xml/xmlhttprequest.h:
2237         (WebCore::):
2238
2239 2006-09-25  Timothy Hatcher  <timothy@apple.com>
2240
2241         Reviewed by Brady.
2242
2243         - Deprecate the rest of the old-style methods that are not generated.
2244         - Add @property syntax to DOMRange.
2245
2246         * WebCore.xcodeproj/project.pbxproj:
2247         * bindings/objc/DOM.mm:
2248         (-[DOMRange setStart:offset:]):
2249         (-[DOMRange setEnd:offset:]):
2250         (-[DOMRange compareBoundaryPoints:sourceRange:]):
2251         (-[DOMRange setStart::]):
2252         (-[DOMRange setEnd::]):
2253         (-[DOMRange compareBoundaryPoints::]):
2254         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2255         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2256         (-[DOMDocument createNodeIterator::::]):
2257         (-[DOMDocument createTreeWalker::::]):
2258         * bindings/objc/DOMCSS.h:
2259         * bindings/objc/DOMCSS.mm:
2260         (-[DOMDocument getComputedStyle:pseudoElement:]):
2261         (-[DOMDocument getComputedStyle::]):
2262         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
2263         * bindings/objc/DOMExtensions.h:
2264         * bindings/objc/DOMHTML.h:
2265         * bindings/objc/DOMRange.h:
2266         * bindings/objc/DOMTraversal.h:
2267
2268 2006-09-25  Eric Seidel  <eric@eseidel.com>
2269
2270         Reviewed by mjs.
2271
2272         Outermost <svg> element should clip to viewport
2273         http://bugs.webkit.org/show_bug.cgi?id=11007
2274
2275         Test: svg/custom/viewport-clip.svg
2276
2277         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
2278
2279 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
2280
2281         Reviewed by Maciej.
2282
2283         * css/MediaList.cpp:
2284         Remove unused header.
2285
2286         * dom/Document.cpp:
2287         (WebCore::Document::clear):
2288         Use clear instead of iterating through the list of event listeners, removing each one.
2289         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
2290
2291         * html/HTMLKeygenElement.cpp:
2292         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
2293         (WebCore::HTMLKeygenElement::appendFormData):
2294         Update due to changes in the SSL key generator.
2295
2296         * ksvg2/svg/SVGAngle.cpp:
2297         Remove unused header.
2298
2299         * ksvg2/svg/SVGAnimationElement.cpp:
2300         (SVGAnimationElement::parseMappedAttribute):
2301         Rename methods and pass Strings instead of DeprecatedStrings to
2302         parseSeparatedList.
2303
2304         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2305         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2306         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2307         * ksvg2/svg/SVGFEMergeElement.cpp:
2308         * ksvg2/svg/SVGFEOffsetElement.cpp:
2309         Remove unused headers.
2310
2311         * ksvg2/svg/SVGHelper.cpp:
2312         (WebCore::SVGHelper::parseSeparatedList):
2313         * ksvg2/svg/SVGHelper.h:
2314         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
2315         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
2316
2317         * ksvg2/svg/SVGLengthList.cpp:
2318         (WebCore::SVGLengthList::parse):
2319         * ksvg2/svg/SVGLengthList.h:
2320         Use Vector<String> instead of DeprecatedStringList.
2321
2322         * loader/Cache.cpp:
2323         (WebCore::Cache::requestImage):
2324         (WebCore::Cache::requestStyleSheet):
2325         (WebCore::Cache::requestScript):
2326         (WebCore::Cache::requestXSLStyleSheet):
2327         (WebCore::Cache::requestXBLDocument):
2328         (WebCore::Cache::remove):
2329         (WebCore::Cache::get):
2330         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
2331
2332         * loader/DocLoader.cpp:
2333         (WebCore::DocLoader::needReload):
2334         * loader/DocLoader.h:
2335         Use a HashSet instead of DeprecatedStringList.
2336
2337         * page/FrameView.h:
2338         Remove declarations that have no functions.
2339
2340         * platform/SSLKeyGenerator.h:
2341         * platform/mac/SSLKeyGeneratorMac.mm:
2342         (WebCore::supportedKeySizes):
2343         (WebCore::signedPublicKeyAndChallengeString):
2344         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
2345         DeprecatedString.
2346
2347 2006-09-25  Dave Hyatt  <hyatt@apple.com>
2348
2349         Shunt the RenderTheme world transform adoption between
2350         Cairo and Windows into getWindowsContext and move the method
2351         out of GraphicsContextCairo and into GraphicsContextWin.
2352
2353         * ChangeLog:
2354         * WebCore.vcproj/WebCore/WebCore.vcproj:
2355         * platform/cairo/GraphicsContextCairo.cpp:
2356         * platform/win/GraphicsContextWin.cpp: Added.
2357         (WebCore::GraphicsContext::getWindowsContext):
2358         (WebCore::GraphicsContext::releaseWindowsContext):
2359         * rendering/RenderThemeWin.cpp:
2360         (WebCore::prepareForDrawing):
2361
2362 2006-09-24  Eric Seidel  <eric@eseidel.com>
2363
2364         Reviewed by hyatt.
2365
2366         <svg:a> cannot be styled with a:hover
2367         http://bugs.webkit.org/show_bug.cgi?id=11005
2368
2369         Test: svg/hixie/cascade/002.xml
2370
2371         * css/cssstyleselector.cpp:
2372         (WebCore::checkPseudoState):
2373
2374 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
2375
2376         Reviewed by Tim H.
2377
2378         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
2379         SVG needs Obj-C DOM bindings
2380
2381         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
2382           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
2383           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
2384           DOMSVGTransformList.
2385
2386         * DerivedSources.make:
2387         * WebCore.xcodeproj/project.pbxproj:
2388         * bindings/objc/DOMInternal.h:
2389         * bindings/objc/DOMSVG.h: Added.
2390         * ksvg2/svg/SVGAngle.idl:
2391         * ksvg2/svg/SVGLength.idl:
2392         * ksvg2/svg/SVGLengthList.idl:
2393         * ksvg2/svg/SVGMatrix.idl:
2394         * ksvg2/svg/SVGPathSeg.idl:
2395         * ksvg2/svg/SVGPathSegList.idl:
2396         * ksvg2/svg/SVGTransform.idl:
2397         * ksvg2/svg/SVGTransformList.idl:
2398
2399 2006-09-24  Rob Buis  <buis@kde.org>
2400
2401         Reviewed by eseidel.
2402
2403         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
2404         WebKit does not handle fallback custom cursors
2405         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
2406         WebKit does not properly handle SVG <cursor> element
2407
2408         Add support for svg cursor images. Also make sure hotspot
2409         settings are handled correctly. Add tests for handling of css3
2410         cursor syntax with hotspots in strict and quirks mode. Finally
2411         implement fallback.
2412
2413         * WebCore.xcodeproj/project.pbxproj:
2414         * css/CSSComputedStyleDeclaration.cpp:
2415         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2416         * css/CSSCursorImageValue.cpp: Added.
2417         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
2418         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
2419         * css/CSSCursorImageValue.h: Added.
2420         (WebCore::CSSCursorImageValue::hotspot):
2421         * css/cssparser.cpp:
2422         (WebCore::CSSParser::parseValue):
2423         * css/cssstyleselector.cpp:
2424         (WebCore::CSSStyleSelector::applyProperty):
2425         * ksvg2/svg/SVGCursorElement.cpp:
2426         * manual-tests/css3-cursor-fallback-quirks.html: Added.
2427         * manual-tests/css3-cursor-fallback-strict.html: Added.
2428         * manual-tests/cursorfallback.xml: Added.
2429         * page/FrameView.cpp:
2430         (WebCore::selectCursor):
2431         * platform/Cursor.h:
2432         * platform/mac/CursorMac.mm:
2433         (WebCore::createCustomCursor):
2434         (WebCore::Cursor::Cursor):
2435         * platform/qt/CursorQt.cpp:
2436         (WebCore::Cursor::Cursor):
2437         * rendering/RenderStyle.cpp:
2438         (WebCore::StyleInheritedData::StyleInheritedData):
2439         (WebCore::StyleInheritedData::operator==):
2440         (WebCore::RenderStyle::diff):
2441         (WebCore::RenderStyle::addCursor):
2442         (WebCore::RenderStyle::addSVGCursor):
2443         (WebCore::RenderStyle::setCursorList):
2444         (WebCore::RenderStyle::clearCursorList):
2445         * rendering/RenderStyle.h:
2446         (WebCore::CursorData::CursorData):
2447         (WebCore::CursorList::operator[]):
2448         (WebCore::CursorList::size):
2449         (WebCore::CursorList::append):
2450         (WebCore::RenderStyle::cursors):
2451
2452 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
2453
2454         Reviewed by Tim H.
2455
2456         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
2457         Auto-generate the internal methods interfaces for the Objective-C bindings
2458
2459         - Auto-generate the internal method declarations into their own files
2460           named in the form DOMFooBarInternal.h for class DOMFooBar.
2461
2462         - Remove all use of DOM_cast from code.
2463
2464         - Assorted cleanups.
2465
2466         * WebCore.xcodeproj/project.pbxproj:
2467         * bindings/objc/DOM.mm:
2468         (-[DOMNode _initWithNode:WebCore::]):
2469         (-[DOMNode WebCore::]):
2470         (-[DOMRange dealloc]):
2471         (-[DOMRange finalize]):
2472         (-[DOMRange _initWithRange:WebCore::]):
2473         (-[DOMRange WebCore::]):
2474         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
2475         (-[DOMNodeFilter WebCore::]):
2476         (-[DOMNodeFilter dealloc]):
2477         (-[DOMNodeFilter finalize]):
2478         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
2479         (-[DOMNodeIterator WebCore::]):
2480         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
2481         (-[DOMTreeWalker WebCore::]):
2482         * bindings/objc/DOMAbstractView.mm:
2483         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
2484         * bindings/objc/DOMCSS.mm:
2485         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2486         (-[DOMCSSRule _initWithRule:WebCore::]):
2487         (-[DOMCSSValue _initWithValue:WebCore::]):
2488         * bindings/objc/DOMEvents.mm:
2489         (-[DOMEvent _initWithEvent:WebCore::]):
2490         * bindings/objc/DOMHTMLAppletElement.mm:
2491         (-[DOMHTMLAppletElement align]):
2492         (-[DOMHTMLAppletElement setAlign:]):
2493         (-[DOMHTMLAppletElement alt]):
2494         (-[DOMHTMLAppletElement setAlt:]):
2495         (-[DOMHTMLAppletElement archive]):
2496         (-[DOMHTMLAppletElement setArchive:]):
2497         (-[DOMHTMLAppletElement code]):
2498         (-[DOMHTMLAppletElement setCode:]):
2499         (-[DOMHTMLAppletElement codeBase]):
2500         (-[DOMHTMLAppletElement setCodeBase:]):
2501         (-[DOMHTMLAppletElement height]):
2502         (-[DOMHTMLAppletElement setHeight:]):
2503         (-[DOMHTMLAppletElement hspace]):
2504         (-[DOMHTMLAppletElement setHspace:]):
2505         (-[DOMHTMLAppletElement name]):
2506         (-[DOMHTMLAppletElement setName:]):
2507         (-[DOMHTMLAppletElement object]):
2508         (-[DOMHTMLAppletElement setObject:]):
2509         (-[DOMHTMLAppletElement vspace]):
2510         (-[DOMHTMLAppletElement setVspace:]):
2511         (-[DOMHTMLAppletElement width]):
2512         (-[DOMHTMLAppletElement setWidth:]):
2513         * bindings/objc/DOMInternal.h:
2514         (getDOMWrapper):
2515         (addDOMWrapper):
2516         (raiseOnDOMError):
2517         * bindings/objc/DOMXPath.mm:
2518         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
2519         * bindings/scripts/CodeGeneratorObjC.pm:
2520
2521 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
2522
2523         Reviewed by eseidel.
2524
2525         Fix Qt/Linux build after Dave's Scrollbar changes.
2526
2527         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
2528         * platform/qt/TemporaryLinkStubs.cpp:
2529         (WebCore::ScrollBar::setProportion):
2530         (WebCore::PlatformScrollBar::updateThumbPosition):
2531         (WebCore::PlatformScrollBar::updateThumbProportion):
2532
2533 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
2534
2535         Reviewed by eseidel.
2536
2537         Qt/Linux build system changes: enable xpath/xslt by default.
2538         Offer possibility to change all of these using 'ccmake'.
2539
2540         * CMakeLists.txt:
2541
2542 2006-09-24  Dave Hyatt  <hyatt@apple.com>
2543
2544         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
2545         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
2546         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
2547
2548         * platform/ScrollBar.cpp:
2549         (WebCore::ScrollBar::setValue):
2550         (WebCore::ScrollBar::setProportion):
2551         * platform/ScrollBar.h:
2552         (WebCore::ScrollBar::value):
2553         * platform/mac/PlatformScrollBar.h:
2554         * platform/mac/PlatformScrollBarMac.mm:
2555         (WebCore::PlatformScrollBar::updateThumbPosition):
2556         (WebCore::PlatformScrollBar::updateThumbProportion):
2557         * platform/win/PlatformScrollBar.h:
2558         * platform/win/TemporaryLinkStubs.cpp:
2559         (PlatformScrollBar::updateThumbPosition):
2560         (PlatformScrollBar::updateThumbProportion):
2561         * rendering/RenderLayer.cpp:
2562         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
2563
2564 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
2565
2566         Reviewed by Eric.
2567
2568         http://bugs.webkit.org/show_bug.cgi?id=4872
2569         XMLHttpRequest fails to throw an exception when there is a security violation
2570         (mismatching domains)
2571
2572         Raise an exception if there is a security violation, and also in cases required by
2573         the current draft of XHR specification.
2574
2575         * bindings/js/JSXMLHttpRequest.cpp:
2576         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
2577         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
2578         reports one, and also if there were too few arguments passed.
2579
2580         * bindings/js/kjs_binding.cpp:
2581         (KJS::setDOMException): Added support for custom XHR exceptions.
2582
2583         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
2584         exception code range for XHR exceptions.
2585
2586         * xml/xmlhttprequest.cpp:
2587         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
2588         (WebCore::XMLHttpRequest::send):
2589         (WebCore::XMLHttpRequest::setRequestHeader):
2590         (WebCore::XMLHttpRequest::getStatus):
2591         (WebCore::XMLHttpRequest::getStatusText):
2592         (WebCore::XMLHttpRequest::processSyncLoadResults):
2593         (WebCore::XMLHttpRequest::receivedAllData):
2594         (WebCore::XMLHttpRequest::receivedData):
2595
2596 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
2597
2598         Reviewed by Jeff Jenkins.
2599
2600         Tweak CF types.
2601
2602         * platform/cf/ResourceLoaderCFNet.cpp:
2603         (WebCore::willCacheResponse):
2604
2605 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
2606
2607         Reviewed by darin
2608
2609         <http://bugs.webkit.org/show_bug.cgi?id=8029>
2610         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
2611
2612         * dom/Document.cpp:
2613         (WebCore::Document::clearSelectionIfNeeded):
2614         * dom/Element.cpp:
2615         (WebCore::Element::contains):
2616         * dom/Node.cpp:
2617         (WebCore::Node::traverseNextNode):
2618         (WebCore::Node::traverseNextSibling):
2619         (WebCore::Node::traversePreviousNodePostOrder):
2620         (WebCore::Node::checkAddChild):
2621         (WebCore::Node::isDescendantOf):
2622         * dom/Node.h:
2623         * dom/NodeIterator.cpp:
2624         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
2625         * editing/ApplyStyleCommand.cpp:
2626         (WebCore::ApplyStyleCommand::applyBlockStyle):
2627         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
2628         (WebCore::ApplyStyleCommand::applyInlineStyle):
2629         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
2630         * editing/CompositeEditCommand.cpp:
2631         (WebCore::CompositeEditCommand::mergeIdenticalElements):
2632         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
2633         * editing/DeleteSelectionCommand.cpp:
2634         (WebCore::updatePositionForNodeRemoval):
2635         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2636         (WebCore::DeleteSelectionCommand::mergeParagraphs):
2637         * editing/FormatBlockCommand.cpp:
2638         (WebCore::FormatBlockCommand::doApply):
2639         * editing/IndentOutdentCommand.cpp:
2640         (WebCore::enclosingListOrBlockquote):
2641         * editing/Selection.cpp:
2642         (WebCore::Selection::validate):
2643         * editing/SelectionController.cpp:
2644         (WebCore::SelectionController::nodeWillBeRemoved):
2645         * editing/TextIterator.cpp:
2646         (WebCore::SimplifiedBackwardsTextIterator::advance):
2647         * editing/VisiblePosition.cpp:
2648         (WebCore::VisiblePosition::next):
2649         (WebCore::VisiblePosition::previous):
2650         (WebCore::VisiblePosition::canonicalPosition):
2651         (WebCore::isFirstVisiblePositionInNode):
2652         (WebCore::isLastVisiblePositionInNode):
2653         * editing/htmlediting.cpp:
2654         (WebCore::firstEditablePositionAfterPositionInRoot):
2655         (WebCore::lastEditablePositionBeforePositionInRoot):
2656         (WebCore::enclosingNodeWithTag):
2657         (WebCore::enclosingList):
2658         (WebCore::enclosingListChild):
2659         * editing/markup.cpp:
2660         (WebCore::createMarkup):
2661
2662 2006-09-22  Timothy Hatcher  <timothy@apple.com>
2663
2664         Reviewed by Darin.
2665
2666         - Added @property syntax to non-generated headers
2667           inside #ifndef BUILDING_ON_TIGER.
2668         - Changed the DOMEventTarget protocol to have have new versions
2669           of addEventListener and removeEventListener with named parameters.
2670           These old style methods can be removed once Mail changes to use
2671           the new methods <rdar://problem/4746649>.
2672
2673         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
2674         * bindings/objc/DOM.mm:
2675         (-[DOMNode addEventListener:listener:useCapture:]):
2676         (-[DOMNode addEventListener:::]): call the new method
2677         (-[DOMNode removeEventListener:listener:useCapture:]):
2678         (-[DOMNode removeEventListener:::]): call the new method
2679         * bindings/objc/DOMAbstractView.h:
2680         * bindings/objc/DOMEventTarget.h:
2681         * bindings/objc/DOMHTMLAppletElement.h:
2682         * bindings/objc/DOMHTMLEmbedElement.h:
2683         * bindings/objc/DOMHTMLOptionElement.h:
2684         * bindings/objc/DOMObject.h:
2685         * bindings/objc/DOMRGBColor.h:
2686
2687 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
2688
2689         Reviewed by Eric.
2690
2691         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
2692
2693         * platform/qt/FrameQt.cpp:
2694         * platform/qt/GraphicsContextQt.cpp:
2695         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
2696         (WebCore::GraphicsContext::origin):
2697         * platform/qt/PlatformScrollBar.h: Added.
2698         (WebCore::PlatformScrollBar::isWidget):
2699         * platform/qt/WidgetQt.cpp:
2700         (WebCore::Widget::invalidate):
2701         (WebCore::Widget::invalidateRect):
2702
2703 2006-09-22  Dave Hyatt <hyatt@apple.com>
2704
2705         Super-minor tweaks to the systemFont function on Mac.
2706         Set the generic family to None rather than to Serif, and
2707         don't waste time setting the computed size, since that is
2708         set from the specified size over in CSSStyleSelector anyway.
2709
2710         * rendering/RenderThemeMac.mm:
2711         (WebCore::RenderThemeMac::systemFont):
2712
2713 2006-09-22  Timothy Hatcher  <timothy@apple.com>
2714
2715         Reviewed by Brady.
2716
2717         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
2718         take floats. There was already an implicit conversion to float/double
2719         when calling CGContextTranslateCTM or cairo_translate.
2720
2721         * platform/GraphicsContext.h:
2722         * platform/cairo/GraphicsContextCairo.cpp:
2723         (WebCore::GraphicsContext::translate):
2724         * platform/cg/GraphicsContextCG.cpp:
2725         (WebCore::GraphicsContext::translate):
2726
2727 2006-09-22  Brady Eidson  <beidson@apple.com>
2728
2729         Reviewed by Sfalken
2730
2731         Add redirect and other cleanup to ResourceLoaderWin.cpp
2732         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10927
2733         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10744
2734
2735         * WebCore.xcodeproj/project.pbxproj:
2736         * platform/ResourceLoader.h:
2737         * platform/win/ResourceLoaderWin.cpp:
2738         (WebCore::ResourceLoaderWndProc):
2739         (WebCore::initializeOffScreenResourceLoaderWindow):
2740         (WebCore::ResourceLoader::onHandleCreated):
2741         (WebCore::ResourceLoader::onRequestRedirected):
2742         (WebCore::ResourceLoader::onRequestComplete):
2743         (WebCore::transferJobStatusCallback):
2744
2745 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
2746
2747         Reviewed by Geoff.
2748
2749         http://bugs.webkit.org/show_bug.cgi?id=10803
2750         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
2751
2752         * page/FrameView.cpp:
2753         (WebCore::FrameView::hoverTimerFired): Use the current event.
2754
2755 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
2756
2757         Reviewed by Anders.
2758
2759         Fix (last) svg memory leak.
2760
2761         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
2762         (SVGTransformable::parseTransformAttribute):
2763
2764 2006-09-22  Eric Seidel  <eric@eseidel.com>
2765
2766         No review necessary, just removing a dead file.
2767
2768         Remove unused file (added previously by mistake) to make room for real implementation.
2769
2770         * platform/mac/BitmapImageMac.mm: Removed.
2771
2772 2006-09-22  Dave Hyatt <hyatt@apple.com>
2773
2774         Move PlatformScrollBar.h down into the platforms.
2775
2776         Reviewed by andersca
2777
2778         * platform/PlatformScrollBar.h: Removed.
2779         * platform/win/PlatformScrollBar.h: Added.
2780         * platform/mac/PlatformScrollBar.h: Added.
2781
2782 2006-09-22   Dave Hyatt  <hyatt@apple.com>
2783
2784         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
2785         any widget subsystems that don't have any underlying native objects backing the widgets.
2786
2787         Reviewed by anders
2788
2789         * platform/Widget.h:
2790         * platform/mac/WidgetMac.mm:
2791         (WebCore::Widget::invalidate):
2792         (WebCore::Widget::invalidateRect):
2793         * platform/win/TemporaryLinkStubs.cpp:
2794         (Widget::invalidate):
2795         (Widget::invalidateRect):
2796
2797 2006-09-22  Rob Buis  <buis@kd.org>
2798
2799         Reviewed by eseidel.
2800
2801         http://bugs.webkit.org/show_bug.cgi?id=10901
2802         Merge build fixes from unity
2803
2804         * CMakeLists.txt:
2805
2806 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2807
2808         Reviewed by eseidel.
2809
2810         http://bugs.webkit.org/show_bug.cgi?id=10977
2811         SVGDocument does not expose 'rootElement' property
2812
2813         Enable 'rootElement' property.
2814
2815         * ksvg2/svg/SVGDocument.idl:
2816
2817 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
2818
2819         Tweak includes.
2820
2821         * platform/ResourceLoaderInternal.h:
2822
2823 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2824
2825         build fixed. band happy.
2826
2827         * platform/cg/GraphicsContextCG.cpp:
2828         (WebCore::GraphicsContext::translate):
2829         * platform/mac/WidgetMac.mm:
2830
2831 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2832
2833         Reviewed by Maciej.
2834
2835         Some Widget refactoring.
2836
2837         * WebCore.vcproj/WebCore/WebCore.vcproj:
2838         * bridge/mac/FrameMac.mm:
2839         * bridge/win/FrameWin.cpp:
2840         (WebCore::FrameWin::runJavaScriptAlert):
2841         (WebCore::FrameWin::runJavaScriptConfirm):
2842         * bridge/win/PageWin.cpp:
2843         (WebCore::Page::Page):
2844         (WebCore::rootWindowForFrame):
2845         * html/CanvasRenderingContext2D.cpp:
2846         (WebCore::CanvasRenderingContext2D::translate):
2847         * page/FrameView.cpp:
2848         (WebCore::FrameView::isFrameView):
2849         * page/Page.h:
2850         (WebCore::Page::setInstanceHandle):
2851         (WebCore::Page::instanceHandle):
2852         * platform/GraphicsContext.h:
2853         * platform/ScrollView.h:
2854         * platform/Widget.h:
2855         * platform/cairo/GraphicsContextCairo.cpp:
2856         (WebCore::GraphicsContext::translate):
2857         (WebCore::GraphicsContext::origin):
2858         * platform/mac/WidgetMac.mm:
2859         (WebCore::Widget::clearFocus):
2860         * platform/win/ResourceLoaderWin.cpp:
2861         (WebCore::initializeOffScreenResourceLoaderWindow):
2862         * platform/win/ScreenWin.cpp:
2863         (WebCore::monitorInfo):
2864         * platform/win/ScrollViewWin.cpp:
2865         (WebCore::ScrollView::updateContents):
2866         (WebCore::ScrollView::visibleWidth):
2867         (WebCore::ScrollView::visibleHeight):
2868         (WebCore::ScrollView::visibleContentRect):
2869         (WebCore::ScrollView::viewportToContents):
2870         (WebCore::ScrollView::contentsToViewport):
2871         (WebCore::ScrollView::scrollBy):
2872         (WebCore::ScrollView::updateScrollInfo):
2873         (WebCore::ScrollView::updateScrollBars):
2874         * platform/win/SharedTimerWin.cpp:
2875         (WebCore::initializeOffScreenTimerWindow):
2876         * platform/win/TemporaryLinkStubs.cpp:
2877         (FrameView::updateBorder):
2878         (ScrollView::paint):
2879         (GraphicsContext::clip):
2880         * platform/win/WidgetWin.cpp:
2881         (WebCore::Widget::Widget):
2882         (WebCore::Widget::parentWindow):
2883         (WebCore::Widget::setParentWindow):
2884         (WebCore::Widget::frameGeometry):
2885         (WebCore::Widget::hasFocus):
2886         (WebCore::Widget::setFocus):
2887         (WebCore::Widget::show):
2888         (WebCore::Widget::hide):
2889         (WebCore::Widget::setFrameGeometry):
2890
2891 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
2892
2893         Reviewed by Tim H.
2894
2895         * platform/TextEncoding.cpp:
2896         (WebCore::TextEncoding::backslashAsCurrencySymbol):
2897         Add comment clarifying why backslashAsCurrencySymbol is needed.
2898
2899 2006-09-21  Sean Gies  <seangies@apple.com>
2900
2901         Reviewed by Adam Roben.
2902
2903         Add utility functions to get and release HDC from GraphicsContext.
2904
2905         * platform/GraphicsContext.h: Add utilities to get and release HDC.
2906         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
2907         * rendering/RenderThemeWin.cpp: Switch to new utilities.
2908
2909 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
2910
2911         Reviewed by anders
2912
2913         <rdar://problem/4426622>
2914         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
2915
2916         * editing/htmlediting.cpp:
2917         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
2918         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
2919         Got rid of uses of DepricatedString.
2920
2921 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2922
2923         Reviewed by eseidel.
2924
2925         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
2926
2927         * page/Frame.cpp:
2928         (WebCore::Frame::endIfNotLoading):
2929
2930 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2931
2932         Reviewed by eseidel.
2933
2934         Fix Qt/Linux build.
2935
2936         * CMakeLists.txt:
2937         * kcanvas/device/qt/KCanvasClipperQt.h:
2938         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
2939         * platform/qt/FrameQt.cpp:
2940         (WebCore::FrameQt::isLoadTypeReload):
2941         (WebCore::FrameQt::originalRequestURL):
2942         * platform/qt/FrameQt.h:
2943         * platform/qt/GraphicsContextQt.cpp:
2944         (WebCore::GraphicsContext::concatCTM):
2945         * platform/qt/ScrollViewQt.cpp:
2946         (WebCore::ScrollView::wheelEvent):
2947         * platform/qt/TemporaryLinkStubs.cpp:
2948         (WebCore::IconDatabase::setIconURLForPageURL):
2949
2950 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2951
2952         Reviewed by john
2953
2954         <http://bugs.webkit.org/show_bug.cgi?id=7165>
2955         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
2956
2957         * editing/MoveSelectionCommand.cpp:
2958         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
2959         to the position-to-move-to's document, not the fragment's document.  The
2960         fragment's document is the document used to create the fragment and is irrelavant.
2961
2962 === Safari-521.27 ===
2963
2964 2006-09-21  Brady Eidson  <beidson@apple.com>
2965
2966         Reviewed by Anders
2967
2968         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
2969         This fixes Spinneret so it won't crash on its first load!
2970
2971         * page/Frame.cpp:
2972         (WebCore::Frame::endIfNotLoading):
2973
2974 2006-09-21  Brady Eidson  <beidson@apple.com>
2975
2976         Build fix
2977
2978         * platform/win/TemporaryLinkStubs.cpp:
2979         (ScrollView::wheelEvent):
2980
2981 2006-09-20  Rob Buis  <buis@kde.org>
2982
2983         Reviewed by eseidel.
2984
2985         http://bugs.webkit.org/show_bug.cgi?id=10946
2986         new marker code draws end-marker in wrong place
2987
2988         Keep track of the start of the subpath so we can handle
2989         closeTo/moveTo correctly.
2990
2991         * kcanvas/RenderPath.cpp:
2992         (WebCore::DrawMarkersData::DrawMarkersData):
2993         (WebCore::updateMarkerDataForElement):
2994
2995 2006-09-21  David Hyatt <hyatt@apple.com>
2996
2997         Wheel scrolling prep for Win32.
2998
2999         WARNING: NO TEST CASES ADDED OR CHANGED
3000
3001         * platform/PlatformWheelEvent.h:
3002         * platform/ScrollBar.h:
3003         * platform/ScrollView.h:
3004         * platform/mac/ScrollViewMac.mm:
3005         (WebCore::ScrollView::wheelEvent):
3006         * rendering/RenderLayer.cpp:
3007
3008 2006-09-20  Timothy Hatcher  <timothy@apple.com>
3009
3010         Reviewed by Hyatt.
3011
3012         Bug 10917: REGRESSION (r16027): iFrame transparency broken
3013         http://bugs.webkit.org/show_bug.cgi?id=10917
3014
3015         Don't paint the base background color if we transparent.
3016
3017         * rendering/RenderBox.cpp:
3018         (WebCore::RenderBox::paintBackgroundExtended):
3019
3020 2006-09-20  Adam Roben  <aroben@apple.com>
3021
3022         Reviewed by andersca.
3023
3024         * platform/FileChooser.h: Remove no-longer-necessary namespace std
3025
3026 2006-09-20  Eric Seidel  <eric@eseidel.com>
3027
3028         Reviewed by beth.
3029
3030         Cleanup style in KCanvas.
3031         Remove extra white-space, unneeded arguments, etc.
3032
3033         * WebCore.xcodeproj/project.pbxproj:
3034         * kcanvas/KCanvasClipper.cpp:
3035         (WebCore::operator<<):
3036         (WebCore::KCanvasClipper::externalRepresentation):
3037         * kcanvas/KCanvasClipper.h:
3038         * kcanvas/KCanvasFilters.cpp:
3039         (WebCore::KCanvasFilter::externalRepresentation):
3040         (WebCore::operator<<):
3041         (WebCore::KCanvasFilterEffect::externalRepresentation):
3042         (WebCore::KCPointLightSource::externalRepresentation):
3043         (WebCore::KCSpotLightSource::externalRepresentation):
3044         (WebCore::KCDistantLightSource::externalRepresentation):
3045         (WebCore::KCanvasFEBlend::externalRepresentation):
3046         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
3047         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
3048         (WebCore::KCanvasFEComposite::externalRepresentation):
3049         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
3050         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
3051         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
3052         (WebCore::KCanvasFEFlood::externalRepresentation):
3053         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
3054         (WebCore::KCanvasFEImage::externalRepresentation):
3055         (WebCore::KCanvasFEMerge::externalRepresentation):
3056         (WebCore::KCanvasFEMorphology::externalRepresentation):
3057         (WebCore::KCanvasFEOffset::externalRepresentation):
3058         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
3059         (WebCore::KCanvasFETile::externalRepresentation):
3060         (WebCore::KCanvasFETurbulence::externalRepresentation):
3061         * kcanvas/KCanvasFilters.h:
3062         (WebCore::KCanvasFEDiffuseLighting::lightSource):
3063         (WebCore::KCanvasFESpecularLighting::lightSource):
3064         * kcanvas/KCanvasImage.h:
3065         * kcanvas/KCanvasMarker.cpp:
3066         (WebCore::KCanvasMarker::externalRepresentation):
3067         * kcanvas/KCanvasMarker.h:
3068         * kcanvas/KCanvasResource.cpp:
3069         (WebCore::operator<<):
3070         * kcanvas/KCanvasResource.h:
3071         * kcanvas/KCanvasTreeDebug.cpp:
3072         (WebCore::operator<<):
3073         (WebCore::writeIndent):
3074         (WebCore::writeStyle):
3075         (WebCore::write):
3076         (WebCore::writeRenderResources):
3077         * kcanvas/KCanvasTreeDebug.h:
3078         (WebCore::operator<<):
3079         * kcanvas/RenderForeignObject.cpp:
3080         (WebCore::RenderForeignObject::paint):
3081         * kcanvas/RenderPath.cpp:
3082         (WebCore::RenderPath::paint):
3083         (WebCore::drawStartAndMidMarkers):
3084         * kcanvas/RenderSVGContainer.cpp:
3085         (WebCore::RenderSVGContainer::paint):
3086         * kcanvas/RenderSVGImage.cpp:
3087         (WebCore::RenderSVGImage::translateForAttributes):
3088         * kcanvas/RenderSVGImage.h:
3089         * kcanvas/device/KRenderingDevice.cpp:
3090         (WebCore::KRenderingDevice::currentContext):
3091         (WebCore::KRenderingDevice::popContext):
3092         (WebCore::KRenderingDevice::pushContext):
3093         * kcanvas/device/KRenderingDevice.h:
3094         * kcanvas/device/KRenderingFillPainter.h:
3095         * kcanvas/device/KRenderingPaintServer.h:
3096         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
3097         (WebCore::KRenderingPaintServer::activeClient):
3098         (WebCore::KRenderingPaintServer::setActiveClient):
3099         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3100         (WebCore::operator<<):
3101         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
3102         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
3103         (WebCore::KRenderingPaintServerGradient::listener):
3104         (WebCore::KRenderingPaintServerGradient::setListener):
3105         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
3106         * kcanvas/device/KRenderingPaintServerGradient.h:
3107         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3108         (WebCore::KRenderingPaintServerPattern::tile):
3109         (WebCore::KRenderingPaintServerPattern::setTile):
3110         (WebCore::KRenderingPaintServerPattern::listener):
3111         (WebCore::KRenderingPaintServerPattern::setListener):
3112         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
3113         * kcanvas/device/KRenderingPaintServerPattern.h:
3114         * kcanvas/device/KRenderingPaintServerSolid.cpp:
3115         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
3116         * kcanvas/device/KRenderingPaintServerSolid.h:
3117         * kcanvas/device/KRenderingStrokePainter.cpp:
3118         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
3119         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
3120         * kcanvas/device/KRenderingStrokePainter.h:
3121         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
3122         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3123         (WebCore::KCanvasFilterQuartz::prepareFilter):
3124         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
3125         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
3126         (WebCore::KCanvasMaskerQuartz::applyMask):
3127         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
3128         (WebCore::KCanvasImageQuartz::init):
3129         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
3130         (WebCore::KCanvasClipperQuartz::applyClip):
3131         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
3132         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
3133         (WebCore::KRenderingDeviceQuartz::quartzContext):
3134         (WebCore::KRenderingDeviceQuartz::contextForImage):
3135         (WebCore::KRenderingDeviceQuartz::createPaintServer):
3136         (WebCore::KRenderingDeviceQuartz::createResource):
3137         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
3138         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3139         (WebCore::CGShadingRefForLinearGradient):
3140         (WebCore::CGShadingRefForRadialGradient):
3141         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
3142         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
3143         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
3144         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3145         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
3146         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
3147         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
3148         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
3149         (WebCore::KRenderingPaintServerSolidQuartz::draw):
3150         (WebCore::KRenderingPaintServerSolidQuartz::setup):
3151         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
3152         (WebCore::KRenderingPaintServerPatternQuartz::setup):
3153         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
3154         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
3155         * kcanvas/device/quartz/QuartzSupport.h:
3156         * kcanvas/device/quartz/QuartzSupport.mm:
3157         (WebCore::applyStrokeStyleToContext):
3158
3159 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
3160
3161         Reviewed by Dave Hyatt.
3162
3163         * dom/WheelEvent.cpp:
3164         (WebCore::WheelEvent::WheelEvent):
3165         Use lroundf instead of lround since deltas are floats.
3166
3167 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
3168
3169         Reviewed by eseidel.  Landed by eseidel.
3170
3171         Test: svg/custom/pattern-y-offset.svg
3172
3173         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3174         (WebCore::KRenderingPaintServerPatternQuartz::setup):
3175
3176 2006-09-20  David Hyatt  <hyatt@apple.com>
3177
3178         Add a new wheelEvent method to ScrollView.  Platforms that wish
3179         to handle the wheel event for the scroll view themselves can then
3180         do so there.  (Mac lets the underlying NSScrollView do it for now.)
3181
3182         * page/FrameView.cpp:
3183         (WebCore::FrameView::handleWheelEvent):
3184         * platform/ScrollView.h:
3185         (WebCore::ScrollView::wheelEvent):
3186
3187 2006-09-20  Brady Eidson  <beidson@apple.com>
3188
3189         Reviewed by Tim Omernick
3190
3191         Part of fixing a crash Tim O showed me that I missed in a release build.
3192         WebKit should be able to call through the bridge to WebCore no matter what -
3193         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
3194
3195         * bridge/mac/WebCoreIconDatabaseBridge.h:
3196         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3197         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
3198         (-[WebCoreIconDatabaseBridge isOpen]):
3199         (-[WebCoreIconDatabaseBridge removeAllIcons]):
3200         (-[WebCoreIconDatabaseBridge _isEmpty]):
3201         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
3202         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
3203         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
3204         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
3205         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
3206         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
3207         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
3208         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
3209         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
3210         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
3211         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
3212         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
3213         (-[WebCoreIconDatabaseBridge _setEnabled:]):
3214         (-[WebCoreIconDatabaseBridge _isEnabled]):
3215
3216 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
3217
3218         Reviewed by Darin.
3219
3220         Add String::split which returns a Vector of Strings and use it instead of
3221         DeprecatedStringList.
3222
3223         * bindings/js/kjs_events.cpp:
3224         (KJS::Clipboard::getValueProperty):
3225         * bindings/js/kjs_window.cpp:
3226         (KJS::parseModalDialogFeatures):
3227         * css/MediaList.cpp:
3228         (WebCore::MediaList::setMediaText):
3229         * dom/Clipboard.h:
3230         * html/HTMLFormElement.cpp:
3231         (WebCore::HTMLFormElement::formData):
3232         * html/HTMLLinkElement.cpp:
3233         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
3234         * platform/PlatformString.h:
3235         * platform/String.cpp:
3236         (WebCore::String::split):
3237         * platform/StringImpl.cpp:
3238         * platform/StringImpl.h:
3239         * platform/mac/ClipboardMac.h:
3240         * platform/mac/ClipboardMac.mm:
3241         (WebCore::ClipboardMac::types):
3242
3243 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
3244
3245         Reviewed by harrison
3246
3247         * css/cssstyleselector.cpp:
3248         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
3249         HTMLElement::isContentEditable just to check the Frame's editability, since
3250         it calls updateRenderering, which can get us into infinite recursion.
3251
3252 2006-09-20  Brady Eidson  <beidson@apple.com>
3253
3254         Reviewed by Darin
3255
3256         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
3257
3258         * loader/icon/IconDatabase.cpp:
3259         (WebCore::IconDatabase::IconDatabase): Disabled by default
3260         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
3261         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
3262         (WebCore::IconDatabase::iconForPageURL): Ditto
3263         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
3264         (WebCore::IconDatabase::iconURLForPageURL): Ditto
3265         (WebCore::IconDatabase::retainIconForPageURL): Ditto
3266         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
3267         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
3268         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
3269         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
3270         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
3271
3272 2006-09-20  Adam Roben  <aroben@apple.com>
3273
3274         Reviewed by Adele.
3275
3276         Fixes http://bugs.webkit.org/show_bug.cgi?id=10935
3277         REGRESSION: file upload control with direction:rtl or text-align:right
3278         draws button on top of filename/icon
3279
3280         * rendering/RenderFileUploadControl.cpp:
3281         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
3282         match direction
3283         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
3284         the filename and icon in RTL
3285
3286 2006-09-20  Alice Liu  <alice.liu@apple.com>
3287
3288         Reviewed by Adam Roben.
3289
3290         fixed windows build
3291
3292         * dom/WheelEvent.cpp:
3293         (WebCore::WheelEvent::WheelEvent):
3294         changed lrint to lround
3295
3296 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
3297
3298         Build Fix.  Adds isHorizontal attribute back to WheelEvent
3299         for the Objective-C bindings.  If it is found that isHorizontal
3300         is not used, we should remove it again but also remove it's
3301         declaration from PublicDOMInterfaces.h
3302
3303         * dom/WheelEvent.h:
3304         (WebCore::WheelEvent::isHorizontal):
3305         * dom/WheelEvent.idl:
3306
3307 2006-09-20  David Hyatt  <hyatt@apple.com>
3308
3309         Fix for 10945, WheelEvent should support two dimensions at once, since
3310         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
3311         to allow for diagonal scrolling.
3312
3313         Reviewed by Eric
3314
3315         * dom/EventTargetNode.cpp:
3316         (WebCore::EventTargetNode::dispatchWheelEvent):
3317         * dom/WheelEvent.cpp:
3318         (WebCore::WheelEvent::WheelEvent):
3319         (WebCore::WheelEvent::initWheelEvent):
3320         * dom/WheelEvent.h:
3321         (WebCore::WheelEvent::wheelDelta):
3322         (WebCore::WheelEvent::wheelDeltaX):
3323         (WebCore::WheelEvent::wheelDeltaY):
3324         * dom/WheelEvent.idl:
3325         * page/FrameView.cpp:
3326         (WebCore::FrameView::handleWheelEvent):
3327         * platform/PlatformWheelEvent.h:
3328         (WebCore::PlatformWheelEvent::deltaX):
3329         (WebCore::PlatformWheelEvent::deltaY):
3330         (WebCore::PlatformWheelEvent::normalize):
3331         * platform/mac/WheelEventMac.mm:
3332         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3333
3334 2006-09-19  Eric Seidel  <eric@eseidel.com>
3335
3336         Reviewed by hyatt.
3337
3338         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
3339
3340         No tests were harmed in the making of this patch.
3341
3342         * WebCore.xcodeproj/project.pbxproj:
3343         * kcanvas/KCanvasClipper.cpp: Added.
3344         (WebCore::operator<<):
3345         * kcanvas/KCanvasClipper.h: Added.
3346         * kcanvas/KCanvasFilters.h:
3347         * kcanvas/KCanvasImage.h:
3348         * kcanvas/KCanvasMarker.cpp: Added.
3349         * kcanvas/KCanvasMarker.h: Added.
3350         * kcanvas/KCanvasMasker.cpp: Added.
3351         (WebCore::KCanvasMasker::KCanvasMasker):
3352         (WebCore::KCanvasMasker::setMask):
3353         (WebCore::KCanvasMasker::externalRepresentation):
3354         (WebCore::getMaskerById):
3355         * kcanvas/KCanvasMasker.h: Added.
3356         * kcanvas/KCanvasResource.cpp: Added.
3357         (WebCore::KCanvasResource::invalidate):
3358         (WebCore::KCanvasResource::externalRepresentation):
3359         (WebCore::getResourceById):
3360         (WebCore::getPaintServerById):
3361         * kcanvas/KCanvasResource.h: Added.
3362         * kcanvas/KCanvasResources.cpp: Removed.
3363         * kcanvas/KCanvasResources.h: Removed.
3364         * kcanvas/RenderPath.cpp:
3365         * kcanvas/RenderSVGContainer.cpp:
3366         * kcanvas/RenderSVGImage.cpp:
3367         * kcanvas/RenderSVGText.cpp:
3368         * kcanvas/device/KRenderingPaintServer.h:
3369         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
3370         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
3371         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
3372         * ksvg2/svg/SVGClipPathElement.h:
3373         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3374         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
3375         * ksvg2/svg/SVGFECompositeElement.cpp:
3376         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
3377         * ksvg2/svg/SVGFELightElement.cpp:
3378         * ksvg2/svg/SVGFEOffsetElement.cpp:
3379         * ksvg2/svg/SVGFETurbulenceElement.cpp:
3380         * ksvg2/svg/SVGFilterElement.cpp:
3381         * ksvg2/svg/SVGLinearGradientElement.cpp:
3382         * ksvg2/svg/SVGMarkerElement.h:
3383         * ksvg2/svg/SVGMaskElement.h:
3384
3385 2006-09-19  Brady Eidson <beidson@apple.com>
3386
3387         Reviewed by Sarge Decker
3388
3389         <rdar://problem/4739892> and <rdar://problem/4729797>
3390         - WebCore::IconDatabase needs to have and respect an enabled() flag
3391         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
3392
3393         * bridge/mac/WebCoreIconDatabaseBridge.h:
3394         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3395         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
3396         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
3397         * loader/icon/IconDatabase.cpp:
3398         (WebCore::IconDatabase::IconDatabase):
3399         (WebCore::IconDatabase::open): Don't open if disabled
3400         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
3401         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
3402         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
3403         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
3404         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
3405         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
3406         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
3407         (WebCore::IconDatabase::releaseIconURL):
3408         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
3409         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
3410         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
3411         (WebCore::IconDatabase::setEnabled): Added
3412         * loader/icon/IconDatabase.h:
3413         (WebCore::IconDatabase::enabled): Added
3414         * page/Frame.cpp:
3415         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
3416         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
3417
3418 2006-09-20  David Hyatt  <hyatt@apple.com>
3419
3420         Massage mouse wheel handling so that it is more cross-platform.  Make
3421         all the work happen in handleWheelEvent on the FrameView.
3422
3423         Reviewed by bradee-oh
3424
3425         * bridge/mac/FrameMac.mm:
3426         (WebCore::FrameMac::wheelEvent):
3427         * page/FrameView.cpp:
3428         (WebCore::FrameView::handleWheelEvent):
3429         * platform/PlatformWheelEvent.h:
3430         (WebCore::PlatformWheelEvent::platformDelta):
3431         (WebCore::PlatformWheelEvent::delta):
3432         * platform/mac/WheelEventMac.mm:
3433         (WebCore::platformDeltaForEvent):
3434         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3435         * rendering/RenderLayer.cpp:
3436         (WebCore::RenderLayer::scroll):
3437         * rendering/RenderObject.cpp:
3438         (WebCore::RenderObject::scroll):
3439
3440 2006-09-19  Eric Seidel  <eric@eseidel.com>
3441
3442         Reviewed by adele.
3443
3444         Improve test output for filters with bounding-box relative sizes.
3445         http://bugs.webkit.org/show_bug.cgi?id=8585
3446
3447         Many test results updated.
3448
3449         * kcanvas/KCanvasFilters.cpp:
3450         (WebCore::KCanvasFilter::externalRepresentation):
3451
3452 2006-09-19  Eric Seidel  <eric@eseidel.com>
3453
3454         Reviewed by adele.
3455
3456         Markers should clip to their viewport.
3457         http://bugs.webkit.org/show_bug.cgi?id=5967
3458
3459         Test: svg/custom/marker-overflow-clip.svg
3460
3461         * kcanvas/KCanvasResources.cpp:
3462         (WebCore::KCanvasMarker::KCanvasMarker):
3463         (WebCore::KCanvasMarker::setMarker):
3464         (WebCore::KCanvasMarker::draw):
3465         * kcanvas/KCanvasResources.h:
3466         (WebCore::KCanvasMasker::mask):
3467         * ksvg2/svg/SVGMarkerElement.cpp:
3468         (WebCore::SVGMarkerElement::SVGMarkerElement):
3469         (WebCore::SVGMarkerElement::parseMappedAttribute):
3470         (WebCore::SVGMarkerElement::canvasResource):
3471         (WebCore::SVGMarkerElement::createRenderer):
3472
3473 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
3474
3475         Reviewed by eseidel
3476
3477         Backing out my recent change.
3478
3479         * css/cssstyleselector.cpp:
3480         (WebCore::CSSStyleSelector::adjustRenderStyle):
3481
3482 2006-09-19  Brady Eidson  <beidson@apple.com>
3483
3484         Reviewed by Kevin McCullough
3485
3486         http://bugs.webkit.org/show_bug.cgi?id=10940
3487         Opening a PDF in a new tab/window creates a documentless-frame
3488         and we deref the document without checking its validity
3489
3490         * page/Frame.cpp:
3491         (WebCore::Frame::iconURL):
3492
3493 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
3494
3495         Reviewed by harrison
3496
3497         <rdar://problem/4735272>
3498         Can not click into link in programmatically editable content
3499
3500         * css/cssstyleselector.cpp:
3501         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
3502         userModify to implement document wide editability.
3503
3504 2006-09-19  MorganL  <morlmor@yahoo.com>
3505
3506         Reviewed by Darin and landed by Brady
3507
3508         Fixes http://bugs.webkit.org/show_bug.cgi?id=10939
3509         Build broken when SVG is not enabled.
3510
3511         * dom/XMLTokenizer.cpp:
3512         (WebCore::XMLTokenizer::startElementNs):
3513
3514 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
3515
3516         Reviewed by harrison
3517
3518         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
3519
3520         Pasting plain text results in a match style paste, and the insertion
3521         position is whitespace normal, which clobbers the whitespace:pre on
3522         tab spans.  Skip changes to the whitespace mode when computing a style
3523         change for tab spans or the text nodes inside tab spans.
3524
3525         * editing/ApplyStyleCommand.cpp:
3526         (WebCore::StyleChange::init): Don't change the whitespace mode inside
3527         tab spans.
3528
3529 2006-09-19  David Hyatt  <hyatt@apple.com>
3530
3531         Fix for bug 5298, shape=default not supported for image maps.  Implement
3532         support for it.
3533
3534         Reviewed by timo
3535
3536         * html/HTMLAreaElement.cpp:
3537         (WebCore::HTMLAreaElement::getRegion):
3538         * html/HTMLMapElement.cpp:
3539         (WebCore::HTMLMapElement::mapMouseEvent):
3540
3541 2006-09-19  Adam Roben  <aroben@apple.com>
3542
3543         Reviewed by Adele.
3544
3545         Fixes http://bugs.webkit.org/show_bug.cgi?id=10824
3546         "no file selected" placeholder text missing from file upload control
3547
3548         * WebCore.xcodeproj/project.pbxproj:
3549         * rendering/RenderFileUploadControl.cpp: Remove class
3550         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
3551         defaultWidthNumChars
3552         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
3553         RenderBlock constructor instead of RenderFlexibleBox,
3554         (WebCore::RenderFileUploadControl::setStyle): Remove references to
3555         m_fileBox.
3556         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
3557         instead of updateIconAndFileName() (which has been removed)
3558         (WebCore::RenderFileUploadControl::updateFromElement): Remove
3559         references to m_fileBox, don't call updateIconAndFilename()
3560         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
3561         without using m_fileBox
3562         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
3563         now-unnecessary display:box rule.
3564         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
3565         to paintingDisabled() now that Icon::paint() does it, and add code to
3566         paint the filename directly.
3567         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
3568         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
3569         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
3570         subclass of RenderBlock instead of RenderFlexibleBox, remove
3571         updateIconAndFilename() method, remove m_fileBox instance variable.
3572
3573 2006-09-19  Eric Seidel  <eric@eseidel.com>
3574
3575         Reviewed by hyatt.
3576
3577         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
3578         http://bugs.webkit.org/show_bug.cgi?id=10846
3579
3580         No automated test case possible until http://bugs.webkit.org/show_bug.cgi?id=10905 is resolved.
3581
3582         * dom/XMLTokenizer.cpp:
3583         (WebCore::XMLTokenizer::XMLTokenizer):
3584         (WebCore::XMLTokenizer::startElementNs):
3585         (WebCore::XMLTokenizer::endElementNs):
3586
3587 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
3588
3589         Reviewed by eseidel.  Landed by eseidel.
3590
3591         Build fix only, no tests affected.
3592
3593         * platform/gdk/FontPlatformDataGdk.cpp:
3594         (WebCore::FontPlatformData::FontPlatformData):
3595         (WebCore::FontPlatformData::~FontPlatformData):
3596         * platform/gdk/FrameGdk.h:
3597         * platform/gdk/TemporaryLinkStubs.cpp:
3598         (FrameGdk::isLoadTypeReload):
3599         (FrameGdk::originalRequestURL):
3600         (IconDatabase::setIconURLForPageURL):
3601
3602 2006-09-19  David Hyatt  <hyatt@apple.com>
3603
3604         Refine the fix for 9805 to really get all the complex cases right.
3605
3606         Reviewed by Eric
3607
3608         * rendering/RenderBlock.cpp:
3609         (WebCore::RenderBlock::clearFloatsIfNeeded):
3610         (WebCore::RenderBlock::handleBottomOfBlock):
3611
3612 2006-09-18  David Hyatt  <hyatt@apple.com>
3613
3614         Fix for 9805, <hr> not positioned properly following a previous empty sibling
3615         that had clear:both set on it.  Update self-collapsing block clearance
3616         behavior to match what is specified in the latest draft of CSS2.1.
3617
<