a52c80e1df2d66b54af5abb91054e73e476ec312
[WebKit-https.git] / WebCore / ChangeLog
1 2007-07-06  Oliver Hunt  <oliver@apple.com>
2
3         Reviewed by Maciej.
4
5         Pulled a number of methods from WebKit and WebCoreFrameBridge into 
6         C++ objects.
7
8         * WebCore.exp:
9         * WebCore.xcodeproj/project.pbxproj:
10         * editing/Editor.cpp:
11         (WebCore::Editor::replaceMarkedText):
12             From -[WebCoreFrameBridge replaceMarkedTextWithText:]
13         * editing/Editor.h:
14         * page/Frame.cpp:
15         (WebCore::Frame::setMarkedTextRange):
16             Pulled platform independent logic from Mac specific implementation
17         (WebCore::Frame::selectRangeInMarkedText):
18             Converted from -[WebHTMLView _selectRangeInMarkedText:]
19         * page/Frame.h:
20         * page/mac/FrameMac.mm:
21         (WebCore::Frame::setMarkedTextRange):
22             Now only does Mac specific logic when manipulating initial
23             NSAttributedString
24         * page/mac/WebCoreFrameBridge.h:
25         * page/mac/WebCoreFrameBridge.mm:
26             Removed -[WebCoreFrameBridge replaceMarkedTextWithText:]
27
28 2007-07-06  Mitz Pettel  <mitz@webkit.org>
29
30         Reviewed by Darin.
31
32         - fix http://bugs.webkit.org/show_bug.cgi?id=14545
33           REGRESSION (r21854-r21869): Repro crash in RenderBlock::updateFirstLetter @ nola.com/rose/
34
35         Test: fast/css/first-letter-capitalized.html
36
37         * rendering/RenderBlock.cpp:
38         (WebCore::RenderBlock::updateFirstLetter): Moved the call to setFirstLetter
39         further down so that the first letter is not destroyed if a text transform
40         is applied to the remaining text fragment when it is add to the render tree.
41         * rendering/RenderText.cpp:
42         (WebCore::RenderText::previousCharacter): Factored out of setTextInternal.
43         (WebCore::RenderText::setTextInternal): Changed to call previousCharacter().
44         * rendering/RenderText.h:
45         * rendering/RenderTextFragment.cpp:
46         (WebCore::RenderTextFragment::previousCharacter): Override to return the
47         character in the original string before the start of the fragment. 
48         * rendering/RenderTextFragment.h:
49
50 2007-07-06  Mitz Pettel  <mitz@webkit.org>
51
52         Reviewed by Beth.
53
54         - fix http://bugs.webkit.org/show_bug.cgi?id=14536
55           Unnecessary layout done when mousing down in text field
56
57         No test possible because there is no change in functionality.
58
59         * rendering/RenderTextControl.cpp:
60         (WebCore::RenderTextControl::setStyle): Reset the height and the width in
61         the old style to avoid getting a layout hint as a result of having mutated
62         the old style during layout.
63         (WebCore::RenderTextControl::layout): Update children's layout if an inner
64         block's dimensions should change. This need for layout was previously masked
65         by the bug.
66
67 2007-07-06  Brady Eidson  <beidson@apple.com>
68
69         Fix builds that use IconDatabaseNone.cpp - better, this time
70
71         * loader/icon/IconDatabaseNone.cpp:
72         (WebCore::IconDatabase::isOpen):
73
74 2007-07-06  Brady Eidson  <beidson@apple.com>
75
76         Fix builds that use IconDatabaseNone.cpp
77
78         * loader/icon/IconDatabaseNone.cpp:
79         (WebCore::IconDatabase::databasePath): 
80
81 2007-07-06  John Sullivan  <sullivan@apple.com>
82
83         Reviewed by Brady
84         
85         - WebCore part of fix for: 
86           <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files
87         
88         * loader/icon/IconDatabase.h:
89         * loader/icon/IconDatabase.cpp:
90         (WebCore::IconDatabase::isOpen): 
91         made this method const (necessary to make IconDatabase::databasePath const)
92         (WebCore::IconDatabase::databasePath): 
93         new method, returns SQLDatabase's path if open, otherwise empty string
94         
95         * loader/icon/SQLDatabase.cpp:
96         (WebCore::SQLDatabase::open):
97         don't append a null character to the m_path ivar. The appended null character was making the path()
98         method return a String with a trailing null, which is bad. However, there were no callers to the
99         path() method until now. Instead of appending a null character to the ivar, use charactersWithNullTermination()
100         instead of characters() when opening the database.
101         
102         * loader/icon/SQLDatabase.h:
103         (WebCore::SQLDatabase::isOpen):
104         made this method const (necessary to make IconDatabase::databasePath const)
105         (WebCore::SQLDatabase::path):
106         made this method const (not required for these changes, but seemed worth doing at the same time)
107
108         * WebCore.exp:
109         added symbol for IconDatabase::databasePath
110
111 2007-07-06  George Staikos  <staikos@kde.org>
112
113         No real functional change - just move the localizations out and
114         stick some placeholder text in.
115
116         * platform/qt/Localizations.cpp: Added.
117         (WebCore::submitButtonDefaultLabel):
118         (WebCore::inputElementAltText):
119         (WebCore::resetButtonDefaultLabel):
120         (WebCore::defaultLanguage):
121         (WebCore::searchableIndexIntroduction):
122         (WebCore::fileButtonChooseFileLabel):
123         (WebCore::fileButtonNoFileSelectedLabel):
124         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
125         (WebCore::contextMenuItemTagDownloadLinkToDisk):
126         (WebCore::contextMenuItemTagCopyLinkToClipboard):
127         (WebCore::contextMenuItemTagOpenImageInNewWindow):
128         (WebCore::contextMenuItemTagDownloadImageToDisk):
129         (WebCore::contextMenuItemTagCopyImageToClipboard):
130         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
131         (WebCore::contextMenuItemTagCopy):
132         (WebCore::contextMenuItemTagGoBack):
133         (WebCore::contextMenuItemTagGoForward):
134         (WebCore::contextMenuItemTagStop):
135         (WebCore::contextMenuItemTagReload):
136         (WebCore::contextMenuItemTagCut):
137         (WebCore::contextMenuItemTagPaste):
138         (WebCore::contextMenuItemTagNoGuessesFound):
139         (WebCore::contextMenuItemTagIgnoreSpelling):
140         (WebCore::contextMenuItemTagLearnSpelling):
141         (WebCore::contextMenuItemTagSearchWeb):
142         (WebCore::contextMenuItemTagLookUpInDictionary):
143         (WebCore::contextMenuItemTagOpenLink):
144         (WebCore::contextMenuItemTagIgnoreGrammar):
145         (WebCore::contextMenuItemTagSpellingMenu):
146         (WebCore::contextMenuItemTagShowSpellingPanel):
147         (WebCore::contextMenuItemTagCheckSpelling):
148         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
149         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
150         (WebCore::contextMenuItemTagFontMenu):
151         (WebCore::contextMenuItemTagBold):
152         (WebCore::contextMenuItemTagItalic):
153         (WebCore::contextMenuItemTagUnderline):
154         (WebCore::contextMenuItemTagOutline):
155         (WebCore::contextMenuItemTagWritingDirectionMenu):
156         (WebCore::contextMenuItemTagDefaultDirection):
157         (WebCore::contextMenuItemTagLeftToRight):
158         (WebCore::contextMenuItemTagRightToLeft):
159         (WebCore::contextMenuItemTagInspectElement):
160         (WebCore::searchMenuNoRecentSearchesText):
161         (WebCore::searchMenuRecentSearchesText):
162         (WebCore::searchMenuClearRecentSearchesText):
163         (WebCore::AXWebAreaText):
164         (WebCore::AXLinkText):
165         (WebCore::AXListMarkerText):
166         (WebCore::AXImageMapText):
167         (WebCore::AXHeadingText):
168         * platform/qt/TemporaryLinkStubs.cpp:
169
170 2007-07-06  Geoffrey Garen  <ggaren@apple.com>
171
172         Reviewed by Anders Carlsson.
173
174         A little more FrameLoader cleanup while working on <rdar://problem/5126396>.
175         
176         Moved url() and URL() methods next to each other to highlight their subtlety.
177
178         * loader/FrameLoader.cpp:
179         (WebCore::FrameLoader::url):
180         * loader/FrameLoader.h:
181
182 2007-07-06  Geoffrey Garen  <ggaren@apple.com>
183
184         Reviewed by Anders Carlsson.
185
186         A little FrameLoader cleanup while working on <rdar://problem/5126396>.
187         
188         Renamed endIfNotLoading() to endIfNotLoadingMainResource() because "loading"
189         and "loadingMainResource" have distinct meanings and this function
190         honors the latter.
191
192         (WebCore::FrameLoader::endIfNotLoadingMainResource): Protect after the
193         early return to avoid ref count churn.
194         * loader/FrameLoader.h:
195         (WebCore::FrameLoader::isLoadingMainResource): Inlined this function.
196
197 2007-07-06  Adam Treat  <adam@staikos.net>
198
199         Reviewed by George Staikos.
200
201         Convert QWebFrame to a QFrame from a scroll area.
202
203         * page/qt/EventHandlerQt.cpp:
204         (WebCore::EventHandler::passSubframeEventToSubframe):
205         (WebCore::EventHandler::passWheelEventToWidget):
206         (WebCore::EventHandler::createDraggingClipboard):
207         (WebCore::EventHandler::passMousePressEventToScrollbar):
208         * platform/ScrollView.h:
209         * platform/Widget.h:
210         * platform/qt/PlatformScrollBar.h:
211         * platform/qt/PlatformScrollBarQt.cpp:
212         (WebCore::PlatformScrollbar::setRect):
213         (WebCore::PlatformScrollbar::frameGeometry):
214         (WebCore::PlatformScrollbar::setFrameGeometry):
215         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
216         (WebCore::PlatformScrollbar::handleMousePressEvent):
217         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
218         * platform/qt/ScrollViewQt.cpp:
219         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
220         (WebCore::ScrollView::ScrollViewPrivate::~ScrollViewPrivate):
221         (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
222         (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
223         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
224         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
225         (WebCore::ScrollView::ScrollViewPrivate::windowClipRect):
226         (WebCore::ScrollView::ScrollView):
227         (WebCore::ScrollView::~ScrollView):
228         (WebCore::ScrollView::setScrollArea):
229         (WebCore::ScrollView::horizontalScrollBar):
230         (WebCore::ScrollView::verticalScrollBar):
231         (WebCore::ScrollView::updateContents):
232         (WebCore::ScrollView::update):
233         (WebCore::ScrollView::visibleWidth):
234         (WebCore::ScrollView::visibleHeight):
235         (WebCore::ScrollView::visibleContentRect):
236         (WebCore::ScrollView::setContentsPos):
237         (WebCore::ScrollView::resizeContents):
238         (WebCore::ScrollView::setFrameGeometry):
239         (WebCore::ScrollView::geometryChanged):
240         (WebCore::ScrollView::contentsX):
241         (WebCore::ScrollView::contentsY):
242         (WebCore::ScrollView::contentsWidth):
243         (WebCore::ScrollView::contentsHeight):
244         (WebCore::ScrollView::windowToContents):
245         (WebCore::ScrollView::contentsToWindow):
246         (WebCore::ScrollView::scrollOffset):
247         (WebCore::ScrollView::maximumScroll):
248         (WebCore::ScrollView::scrollBy):
249         (WebCore::ScrollView::scrollRectIntoViewRecursively):
250         (WebCore::ScrollView::hScrollbarMode):
251         (WebCore::ScrollView::vScrollbarMode):
252         (WebCore::ScrollView::suppressScrollbars):
253         (WebCore::ScrollView::setHScrollbarMode):
254         (WebCore::ScrollView::setVScrollbarMode):
255         (WebCore::ScrollView::setScrollbarsMode):
256         (WebCore::ScrollView::setStaticBackground):
257         (WebCore::ScrollView::inWindow):
258         (WebCore::ScrollView::updateScrollbars):
259         (WebCore::ScrollView::scrollbarUnderMouse):
260         (WebCore::ScrollView::addChild):
261         (WebCore::ScrollView::removeChild):
262         (WebCore::ScrollView::paint):
263         (WebCore::ScrollView::wheelEvent):
264         (WebCore::ScrollView::scroll):
265         (WebCore::ScrollView::windowResizerRect):
266         (WebCore::ScrollView::resizerOverlapsContent):
267         (WebCore::ScrollView::adjustOverlappingScrollbarCount):
268         (WebCore::ScrollView::setParent):
269         (WebCore::ScrollView::addToDirtyRegion):
270         (WebCore::ScrollView::scrollBackingStore):
271         (WebCore::ScrollView::updateBackingStore):
272         * platform/qt/WidgetQt.cpp:
273         (WebCore::WidgetPrivate::canvas):
274         (WebCore::WidgetPrivate::setGeometry):
275         (WebCore::WidgetPrivate::geometry):
276         (WebCore::Widget::setQWidget):
277         (WebCore::Widget::paint):
278         (WebCore::Widget::originalGeometry):
279         (WebCore::Widget::geometryChanged):
280
281 2007-07-06  Anders Carlsson  <andersca@apple.com>
282
283         Reviewed by Mitz.
284
285         <rdar://problem/5280532> 
286         REGRESSION: Can't access nested embed by document.name if object is not immediate parent
287         
288         Traverse up the tree looking for an object element.
289         
290         * html/HTMLEmbedElement.cpp:
291         (WebCore::HTMLEmbedElement::getInstance):
292
293 2007-07-06  George Staikos  <staikos@kde.org>
294
295         Qt build fix: Don't clobber qmake variables that are already set.
296
297         * WebCore.pro:
298
299 2007-07-05  Maciej Stachowiak  <mjs@apple.com>
300
301         Reviewed by Antti.
302
303         - <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings
304
305         * platform/StringHash.h:
306         (WTF::): Adapt to newer way to do storage types.
307
308 2007-07-06  Bernhard Rosenkraenzer  <bero@arklinux.org>
309
310         Reviewed by Sam.
311
312         Fix for http://bugs.webkit.org/show_bug.cgi?id=13985
313         Bug 13985: WebCore/rendering/RenderTable.cpp fails to compile with gcc 4.2.x
314
315         * rendering/RenderTable.cpp:
316         (WebKit::RenderTable::calcBorderLeft)
317         (WebKit::RenderTable::calcBorderRight)
318
319 2007-07-06  Maxime Britto  <mbritto@pleyo.com>
320
321         Reviewed by Maciej.
322
323         Fix http://bugs.webkit.org/show_bug.cgi?id=13038
324         Bug 13038: ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
325
326         Modify an ASSERT in goToItem related to going back/forward in history.  We don't need to check the frameset if the target is _blank.
327         The attached test case is a manual one since it relies on having pages opened in tabs in Safari.
328
329         * manual-tests/goBack-blank-tab-page.html: Added.
330         * manual-tests/resources/before-go-back.html: Added.
331         * manual-tests/resources/will-go-back.html: Added.
332         * page/Page.cpp:
333         (WebCore::Page::goToItem):
334
335 2007-07-06  Mitz Pettel  <mitz@webkit.org>
336
337         Reviewed by Maciej.
338
339         - fix http://bugs.webkit.org/show_bug.cgi?id=14400
340           Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube
341
342         Test: fast/forms/button-state-restore.html
343
344         * dom/Document.h:
345         (WebCore::Document::isFormElementRegistered): Added.
346         * html/HTMLGenericFormElement.cpp:
347         (WebCore::HTMLGenericFormElement::closeRenderer): Restore saved form
348         element state only if the element is registered with the document to
349         have its state saved.
350
351 2007-07-06  Mitz Pettel  <mitz@webkit.org>
352
353         Reviewed by Maciej.
354
355         - fix http://bugs.webkit.org/show_bug.cgi?id=14487
356           Incomplete repaint of background and border of boxes with -webkit-border-fit:lines
357
358         Test: fast/repaint/border-fit-lines.html
359
360         * rendering/RenderObject.cpp:
361         (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Do a full repaint if
362         -webkit-border-fit:lines was specified.
363
364 2007-07-06  Tony Chang  <idealisms@gmail.com>
365
366         Reviewed by Maciej.
367
368         http://bugs.webkit.org/show_bug.cgi?id=14516
369         Bug 14516: crash loading multipart/x-mixed-replace data on windows safari
370
371         NULL check m_resourceData to prevent a crash in Safari on Windows.
372
373         * loader/ResourceLoader.cpp:
374         (WebCore::ResourceLoader::clearResourceData):
375
376 2007-07-06  Jungshik Shin  <jungshik.shin@gmail.com>
377
378         Reviewed by Alexey.
379
380         - Add UTF-32 encoding support 
381           http://bugs.webkit.org/show_bug.cgi?id=13415
382
383         Test:
384          - fast/encoding/utf-32-big-endian-bom.html
385          - fast/encoding/utf-32-big-endian-nobom.xml
386          - fast/encoding/utf-32-little-endian-bom.html
387          - fast/encoding/utf-32-little-endian-nobom.xml
388
389         * loader/TextResourceDecoder.cpp:
390         (WebCore::TextResourceDecoder::checkForBOM):
391         (WebCore::TextResourceDecoder::checkForHeadCharset):
392         * platform/TextDecoder.cpp:
393         (WebCore::TextDecoder::checkForBOM):
394         * platform/TextDecoder.h:
395         * platform/TextEncoding.cpp:
396         (WebCore::UTF32BigEndianEncoding):
397         (WebCore::UTF32LittleEndianEncoding):
398         * platform/TextEncoding.h:
399
400 2007-07-06  Holger Hans Peter Freyther  <zecke@selfish.org>
401
402         Reviewed by Maciej.
403
404         Start implementening RenderThemeGdk/Gtk using GtkStyle. The approach is
405         to allocate one native control for each widget type. And use margins, spacing,
406         style properties from the Widget. And for drawing use GtkStyle on the rect supplied.
407
408         This should allow nice integration and be relative resource friendly. Mozilla is using
409         a similiar approach. They seem to share the GdkPixmap among several operations and this
410         will be an obvious candidate for improvements. Create a normally big enough GdkPixmap and
411         use that for drawing and then set clip regions for cairo to make sure to not go beyond the
412         width and height.
413
414         The next steps will be to introduce states for the widgets, add more widgets, handle focus,
415         and various other style attributes, honor the size and margin and use that to propagate this
416         back to RenderStyle*.
417
418         * platform/gdk/RenderThemeGdk.cpp:
419         (WebCore::RenderThemeGdk::RenderThemeGdk):
420         (WebCore::RenderThemeGdk::setCheckboxSize):
421         (WebCore::RenderThemeGdk::paintCheckbox):
422         (WebCore::RenderThemeGdk::setRadioSize):
423         (WebCore::RenderThemeGdk::paintRadio):
424         (WebCore::RenderThemeGdk::paintButton):
425         (WebCore::RenderThemeGdk::copyToContext):
426         (WebCore::RenderThemeGdk::gtkButton):
427         (WebCore::RenderThemeGdk::gtkCheckbox):
428         (WebCore::RenderThemeGdk::gtkRadioButton):
429         (WebCore::RenderThemeGdk::gtkWindowContainer):
430         * platform/gdk/RenderThemeGdk.h:
431
432 2007-07-06  Rob Buis  <buis@kde.org>
433
434         Reviewed by Adam.
435
436         http://bugs.webkit.org/show_bug.cgi?id=14442
437         Adding a stop with value 1.0 to a gradient that has already been used has no effect
438
439         Implement start and end stop handling differently so they are not
440         in the color stop array.
441
442         * html/CanvasGradient.cpp:
443         (WebCore::compareStops):
444         (WebCore::CanvasGradient::getColor):
445         (WebCore::CanvasGradient::findStop):
446
447 2007-07-06  Adam Roben  <aroben@apple.com>
448
449         Fix <rdar://problem/5301994> Garbled text still showing on some sites
450
451         Replace calls to GetGlyphIndices with wkGetGlyphs.
452
453         Reviewed by Alice.
454
455         * platform/win/GlyphPageTreeNodeWin.cpp:
456         (WebCore::GlyphPage::fill): Use wkGetGlyphs.
457         * platform/win/FontDataWin.cpp:
458         (WebCore::FontData::containsCharacters):
459
460 2007-07-06  Matt Lilek  <pewtermoose@gmail.com>
461
462         Not reviewed - Windows build fix.
463
464         * bridge/win/FrameWin.cpp:
465         (WebCore::imageFromSelection):
466
467 2007-07-06  George Staikos  <staikos@kde.org>
468
469         Reviewed by Maciej.
470
471         Switch USE(ICONDATABASE) to ENABLE(ICONDATABASE) and activate the
472         flag via the .pro file
473
474         * WebCore.pro:
475         * loader/icon/IconDatabase.h:
476
477 2007-07-05  John Sullivan  <sullivan@apple.com>
478
479         Reviewed by Adam
480
481         - WebCore part of fix for <rdar://problem/5315033>
482
483         * rendering/RenderObject.h:
484         replaced PaintRestrictionSelectionOnlyWhiteText with PaintRestrictionSelectionOnlyBlackText
485         (WebCore::RenderObject::PaintInfo::PaintInfo):
486         replaced forceWhiteText with forceBlackText
487
488         * rendering/RenderObject.cpp:
489         (WebCore::RenderObject::addLineBoxRects):
490         added a useSelectionHeight parameter, which defaults to false; this method is unimplemented
491         at this level so this has no effect.
492
493         * rendering/RenderText.h:
494         * rendering/RenderText.cpp:
495         (WebCore::RenderText::addLineBoxRects):
496         added a useSelectionHeight parameter, which defaults to false. If true, use the vertical position
497         and height returned by selectionRect rather than replacing it with the more tight-fitting position
498         and height of the line box.
499
500         * dom/Range.h:
501         * dom/Range.cpp:
502         (WebCore::Range::addLineBoxRects):
503         added a useSelectionHeight parameter, which defaults to false. Passes this along to RenderObject.        
504
505         * page/Frame.h:
506         renamed parameter to selectionImage
507         * page/Frame.cpp:
508         (WebCore::Frame::selectionTextRects):
509         pass true for addLineBoxRects new useSelectionHeight parameter, so the rects returned by this new
510         method will match the height that the selection would be painted here
511         (WebCore::Frame::paint):
512         updated for white->black name changes
513         
514         * page/mac/FrameMac.mm:
515         (WebCore::Frame::selectionImage):
516         updated for white->black name changes
517         
518         * rendering/InlineFlowBox.cpp:
519         (WebCore::InlineFlowBox::paintTextDecorations):
520         updated for white->black name changes
521
522         * rendering/RenderLayer.cpp:
523         (WebCore::RenderLayer::paintLayer):
524         updated for white->black name changes
525
526         * rendering/InlineTextBox.cpp:
527         (WebCore::InlineTextBox::paint):
528         updated for white->black name changes, and actually use black instead of white. This was the goal
529         of all the name changes.
530
531 2007-07-05  Anders Carlsson  <andersca@apple.com>
532
533         Reviewed by Oliver.
534
535         Fix layout test failures.
536         
537         * loader/FrameLoader.cpp:
538         (WebCore::FrameLoader::commitProvisionalLoad):
539         Don't make a representation if we're creating the initial document.
540
541 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
542
543         Fix Bug 14388: Input in text fields limited to 1024 characters
544         http://bugs.webkit.org/show_bug.cgi?id=14388
545
546         Slightly modified by Adam Roben.
547
548         Reviewed by Adele.
549
550         Tests: fast/forms/input-implicit-length-limit.html
551                fast/forms/input-maxlength.html
552
553         * html/HTMLInputElement.cpp: Bump limit to 524288.
554         (WebCore::HTMLInputElement::init):
555         (WebCore::HTMLInputElement::parseMappedAttribute):
556         * html/HTMLInputElement.h:
557
558 2007-07-05  Anders Carlsson  <andersca@apple.com>
559
560         Build fix.
561         
562         * loader/FrameLoader.cpp:
563         (WebCore::FrameLoader::init):
564
565 2007-07-05  Sam Weinig  <sam@webkit.org>
566
567         Reviewed by Geoff.
568
569         Add focus, blur and close functions to DOMWindow implementation class
570         and move bindings from Window to JSDOMWindow.
571
572         * bindings/js/JSDOMWindowCustom.cpp:
573         (WebCore::JSDOMWindow::customGetOwnPropertySlot):
574         * bindings/js/kjs_window.cpp:
575         (KJS::Window::getOwnPropertySlot):
576         (KJS::WindowFunc::callAsFunction):
577         * bindings/js/kjs_window.h:
578         (KJS::Window::):
579         * bindings/scripts/CodeGeneratorJS.pm: Move prototype function declaration from
580         the implementation to the header.
581         * page/DOMWindow.cpp:
582         (WebCore::DOMWindow::focus):
583         (WebCore::DOMWindow::blur):
584         (WebCore::DOMWindow::close):
585         * page/DOMWindow.h:
586         * page/DOMWindow.idl:
587
588 2007-07-05  Justin Garcia  <justin.garcia@apple.com>
589
590         Reviewed by Harrison.
591
592         <rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body
593
594         * editing/TextIterator.cpp:
595         (WebCore::TextIterator::exitNode): Previously emitted content shouldn't have
596         to come from a text node in order to emit a '\n' as we exit block containers.
597
598 2007-07-05  Anders Carlsson  <andersca@apple.com>
599
600         Reviewed by Geoff.
601
602         <rdar://problem/5315284> REGRESSION: Leopard Launch Time - plugins are being accessed at startup.
603
604         Set a response that has a MIME type of "text/html" on the document loader so WebKit won't refresh the 
605         plugin database looking for a plug-in that can handle the document's MIME type (which will be null anyway).
606                  
607         * loader/FrameLoader.cpp:
608         (WebCore::FrameLoader::init):
609
610 2007-07-05  Anders Carlsson  <andersca@apple.com>
611
612         Reviewed by Oliver.
613
614         <rdar://problem/5106788>
615         WebKit loads user style sheets too late as seen in Mail (breaks DataDetectors; Mail flashes wrong font)
616
617         Let the document know when the user style sheet is loading so that it try not to display anything
618         until the user style sheet has finished loading.
619         
620         * page/Frame.cpp:
621         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
622         (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader):
623         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
624         (WebCore::Frame::setUserStyleSheetLocation):
625
626 2007-07-05  Sam Weinig  <sam@webkit.org>
627
628         Reviewed by Darin.
629
630         Move JSDOMWindow overriding getOwnPropertySlot logic from KJS::Window
631         up into JSDOMWindow.  No change in functionality so no testcase required. 
632
633         * bindings/js/JSDOMWindowCustom.cpp:
634         (WebCore::JSDOMWindow::customGetOwnPropertySlot):
635         * bindings/js/kjs_window.cpp:
636         (KJS::Window::getOwnPropertySlot):
637         * bindings/js/kjs_window.h:
638
639 2007-07-05  Mitz Pettel  <mitz@webkit.org>
640
641         Reviewed and Landed by Sam.
642
643         - fix bug 14465 for window.showModalDialog
644
645         * bindings/js/kjs_window.cpp:
646         (KJS::parseModalDialogFeatures):
647         (KJS::showModalDialog):
648
649 2007-07-05  Sam Weinig  <sam@webkit.org>
650
651         Reviewed by Mitz.
652
653         Patch for http://bugs.webkit.org/show_bug.cgi?id=14465
654         window.open() uses the literal "undefined" as the URL
655
656         * bindings/js/kjs_window.cpp:
657         (KJS::WindowFunc::callAsFunction): add checks for undefined and null values when setting the url.
658         * manual-tests/open-url-undefined.html: Added.
659
660 2007-07-05  Holger Hans Peter Freyther  <zecke@selfish.org>
661
662         Reviewed by Rob Buis.
663
664         Rework FontData and FontPlatformData for the Gdk work to make valgrind
665         happy.
666
667         Move destroying of FontConfig and Cairo objects held in FontPlatformData
668         to FontData::platformDestroy. The ownership of these objects is held by
669         FontData. This is following the Mac and Qt port at least.
670
671         Currently it is possible that FontPlatformData will not create cairo resources
672         in this case at least make sure the variables are initialized to 0.
673         Initialize x,y of the cairo_glyph_t with zero to avoid extents.x_advance depending
674         on subtracing with not defined values.
675
676         FontPlatformData::hash. Using FontDescription is a bad idea as we don't have a clue
677         about how it is packed, if holes are present, etc. The FcPattern and the m_fontMatrix
678         should be good enough to describe the Font. All other objects are created using these
679         variables
680
681         Replace C-style casts with C++ casts, in this case reinterpret_cast.
682
683         * platform/gdk/FontDataGdk.cpp:
684         (WebCore::FontData::platformInit): Don't assert
685         (WebCore::FontData::platformDestroy): Take over ownership
686         (WebCore::FontData::platformWidthForGlyph): initialize
687         (WebCore::FontData::setFont): be paranoid and assert
688         * platform/gdk/FontPlatformData.h:
689         (WebCore::FontPlatformData::FontPlatformData): Initialize everything
690         (WebCore::FontPlatformData::hash): make valgrind happy and don't use m_fontDescription
691         * platform/gdk/FontPlatformDataGdk.cpp:
692         (WebCore::FontPlatformData::FontPlatformData):
693         (WebCore::FontPlatformData::~FontPlatformData): FontData::platformDestroy will do this
694         (WebCore::FontPlatformData::list): Don't use C-style casts.
695         (WebCore::FontPlatformData::setFont): m_fontFace, m_fontMatrix, m_options might not be initialized
696         (WebCore::FontPlatformData::operator==): Don't use C-style casts.
697
698 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
699
700         Reviewed by Mark Rowe.
701
702         http://bugs.webkit.org/show_bug.cgi?id=14445
703         GraphicsContextCairo code style cleanup
704
705         Follow the cr naming convention for cairo_t*.
706         Remove trailing whitespace.
707         Replace C casts with C++ casts.
708         Avoid needless casts.
709
710         * platform/graphics/cairo/GraphicsContextCairo.cpp:
711         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
712         (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
713         (WebCore::GraphicsContext::GraphicsContext):
714         (WebCore::GraphicsContext::platformContext):
715         (WebCore::GraphicsContext::savePlatformState):
716         (WebCore::GraphicsContext::restorePlatformState):
717         (WebCore::GraphicsContext::drawRect):
718         (WebCore::adjustLineToPixelBoundaries):
719         (WebCore::GraphicsContext::drawLine):
720         (WebCore::GraphicsContext::drawEllipse):
721         (WebCore::GraphicsContext::strokeArc): Save/restore the graphics state.
722         (WebCore::GraphicsContext::drawConvexPolygon):
723         (WebCore::GraphicsContext::fillRect):
724         (WebCore::GraphicsContext::clip):
725         (WebCore::GraphicsContext::drawFocusRing):
726         (WebCore::GraphicsContext::roundToDevicePixels):
727         (WebCore::GraphicsContext::translate):
728         (WebCore::GraphicsContext::origin):
729         (WebCore::GraphicsContext::setPlatformStrokeThickness):
730         (WebCore::GraphicsContext::setPlatformStrokeStyle):
731         (WebCore::GraphicsContext::setPlatformFont):
732         (WebCore::GraphicsContext::concatCTM):
733         (WebCore::GraphicsContext::addInnerRoundedRectClip):
734         (WebCore::GraphicsContext::beginTransparencyLayer):
735         (WebCore::GraphicsContext::endTransparencyLayer):
736         (WebCore::GraphicsContext::clearRect):
737         (WebCore::GraphicsContext::setLineCap):
738         (WebCore::GraphicsContext::setLineJoin):
739         (WebCore::GraphicsContext::setMiterLimit):
740         (WebCore::GraphicsContext::setCompositeOperation):
741         (WebCore::GraphicsContext::beginPath):
742         (WebCore::GraphicsContext::addPath):
743         (WebCore::GraphicsContext::rotate):
744         (WebCore::GraphicsContext::scale):
745         * platform/graphics/cairo/ImageBufferCairo.cpp:
746         (WebCore::ImageBuffer::ImageBuffer):
747         * platform/graphics/cairo/ImageCairo.cpp: Avoid the confusing ctxt/context naming scheme.
748         (WebCore::BitmapImage::draw):
749         (WebCore::Image::drawPattern):
750
751 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
752
753         Reviewed by Mark Rowe.
754
755         http://bugs.webkit.org/show_bug.cgi?id=14531
756         Cairo SVGImage::nativeImageForCurrentFrame() has no return
757
758         Return the Cairo surface from the frame cache.
759
760         Also add a fall-through else macro with notImplemented() so that future
761         ports do not make the same mistake.
762
763         * platform/graphics/svg/SVGImage.cpp:
764         (WebCore::SVGImage::nativeImageForCurrentFrame):
765
766 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
767
768         Reviewed by Mark Rowe.
769
770         http://bugs.webkit.org/show_bug.cgi?id=14513
771         Cairo animated GIF support is broken
772
773         Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.
774
775         * platform/graphics/cairo/ImageSourceCairo.cpp:
776         (WebCore::ImageSource::frameIsCompleteAtIndex):
777
778 2007-07-04  Matt Perry  <mpComplete@gmail.com>
779
780         Reviewed by Adam.
781
782         Fix for http://bugs.webkit.org/show_bug.cgi?id=13400
783         Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
784         <rdar://problem/5153025>
785
786         Treat userGesture as always true for setLocation, forcing a back/forward
787         entry to be created.
788
789         * bindings/js/JSHTMLDocumentCustom.cpp:
790         (WebCore::JSHTMLDocument::setLocation):
791
792 2007-07-04  Adam Roben  <aroben@apple.com>
793
794         Restore MouseEventWithHitTestResults::targetNode's old behavior
795
796         Reviewed by Mark.
797
798         Fixes fast/images/imagemap-case and fast/replace/image-map.
799
800         * page/MouseEventWithHitTestResults.cpp:
801         (WebCore::MouseEventWithHitTestResults::targetNode): Use the inner
802         node, not the inner non-shared node.
803
804 2007-07-04  Adam Roben  <aroben@apple.com>
805
806         Mac, Qt, and Gdk build fixes.
807
808         * page/EventHandler.h:
809         * page/gdk/EventHandlerGdk.cpp:
810         * page/mac/EventHandlerMac.mm:
811         (WebCore::EventHandler::passSubframeEventToSubframe):
812         * page/qt/EventHandlerQt.cpp:
813
814 2007-07-04  Adam Roben  <aroben@apple.com>
815
816         Fix the Qt/Gdk builds.
817
818         * page/gdk/EventHandlerGdk.cpp:
819         * page/qt/EventHandlerQt.cpp:
820
821 2007-07-04  Adam Roben  <aroben@apple.com>
822
823         Move tooltip logic down into WebCore so that it can be shared cross-platform
824
825         Reviewed by Sam.
826
827         * page/Chrome.cpp:
828         (WebCore::Chrome::setToolTip): Added.
829         * page/Chrome.h:
830         * page/ChromeClient.h:
831         * page/EventHandler.cpp:
832         (WebCore::EventHandler::mouseMoved): Call Chrome::setToolTip.
833         * platform/graphics/svg/SVGImageEmptyClients.h:
834
835         Added stubs for Gdk:
836
837         * platform/gdk/ChromeClientGdk.h:
838         * platform/gdk/TemporaryLinkStubs.cpp:
839         (ChromeClientGdk::setToolTip):
840
841 2007-07-04  Adam Roben  <aroben@apple.com>
842
843         Add Settings::showsURLsInToolTips
844
845         Reviewed by Sam.
846
847         * WebCore.exp:
848         * page/Settings.cpp:
849         (WebCore::Settings::Settings):
850         * page/Settings.h:
851
852 2007-07-04  Adam Roben  <aroben@apple.com>
853
854         Move logic for calling mouseDidMoveOverElement into WebCore
855
856         Reviewed by Sam.
857
858         * page/EventHandler.cpp:
859         (WebCore::EventHandler::mouseMoved): Added. Calls Chrome::mouseDidMoveOverElement.
860         (WebCore::EventHandler::handleMouseMoveEvent): Now takes an optional
861         HitTestResult* parameter which is used to communicate to the caller the
862         node the mouse is over.
863         * page/EventHandler.h:
864         * page/mac/EventHandlerMac.mm:
865         (WebCore::EventHandler::mouseMoved): Changed to call the overloaded
866         mouseMoved().
867         (WebCore::EventHandler::passMouseMoveEventToSubframe): Pass hoveredNode
868         through to the subframe so we can get the deepest node hovered, not
869         just the node's parent frame.
870         * page/win/EventHandlerWin.cpp:
871         (WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.
872
873 2007-07-04  Adam Roben  <aroben@apple.com>
874
875         Add Chrome::mouseDidMoveOverElement
876
877         This does the work of calling up to the ChromeClient (which will call
878         the UI delegate).
879
880         Reviewed by Sam.
881
882         * page/Chrome.cpp:
883         (WebCore::Chrome::mouseDidMoveOverElement): Added.
884         * page/Chrome.h:
885         * page/ChromeClient.h:
886         * platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to
887         ChromeClient.
888         * platform/gdk/ChromeClientGdk.h:
889         * platform/gdk/TemporaryLinkStubs.cpp:
890         (ChromeClientGdk::mouseDidMoveOverElement):
891
892 2007-07-04  Adam Roben  <aroben@apple.com>
893
894         Changed PlatformMouseEvent to store the modifier flags of the event
895
896         Reviewed by Sam.
897
898         * platform/PlatformMouseEvent.h:
899         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
900         * platform/mac/PlatformMouseEventMac.mm:
901         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
902         * platform/win/PlatformMouseEventWin.cpp:
903         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
904
905 2007-07-04  Adam Roben  <aroben@apple.com>
906
907         Add HitTestResult::setToNonShadowAncestor
908
909         Reviewed by Sam.
910
911         * page/EventHandler.cpp:
912         (WebCore::EventHandler::hitTestResultAtPoint): Moved logic into
913         HitTestResult::setToNonShadowAncestor.
914         * rendering/HitTestResult.cpp:
915         (WebCore::HitTestResult::setToNonShadowAncestor):
916         * rendering/HitTestResult.h:
917
918 2007-07-04  Adam Roben  <aroben@apple.com>
919
920         Change MouseEventWithHitTestResults to hold onto a HitTestResult
921
922         Reviewed by Sam.
923
924         * dom/Document.cpp:
925         (WebCore::Document::prepareMouseEvent):
926         * page/MouseEventWithHitTestResults.cpp:
927         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
928         (WebCore::MouseEventWithHitTestResults::targetNode):
929         (WebCore::MouseEventWithHitTestResults::localPoint):
930         (WebCore::MouseEventWithHitTestResults::scrollbar):
931         * page/MouseEventWithHitTestResults.h:
932         (WebCore::MouseEventWithHitTestResults::event):
933         (WebCore::MouseEventWithHitTestResults::hitTestResult):
934
935 2007-07-04  Matt Lilek  <pewtermoose@gmail.com>
936
937         Not reviewed, gdk build fix.
938
939         * platform/gdk/FrameGdk.cpp:
940
941 2007-07-05  Antti Koivisto  <antti@apple.com>
942
943         Reviewed by John.
944         
945         Fix Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
946         <rdar://problem/5237811>
947         
948         It is possible to add table parts (thead etc) without table ancestor to a document fragment. If a new table element
949         was added to such a part, as in
950         
951         div.innerHTML = '<tbody><table>';
952         
953         the parser error handling code would try to pop the previous table as normal. However since
954         the table does not actually exist nothing would happen and parser would go to infinite recursion.
955         
956         Solution here is to pop table parts one by one when handling the error inside a fragment instead of trying to pop
957         the table straight away (as it might not exist).
958
959         * html/HTMLParser.cpp:
960         (WebCore::HTMLParser::handleError):
961
962 2007-07-04  Qing Zhao  <qing@staikos.net>
963
964         Reviewed by George Staikos.
965
966         Draw menulist (comboboxes) without text overlap on the button.
967
968         * platform/qt/RenderThemeQt.cpp:
969         (WebCore::RenderThemeQt::setPopupPadding):
970
971 2007-07-04  George Staikos  <staikos@kde.org>
972
973         Compile
974
975         * page/qt/FrameQt.cpp:
976         * WebCore.pro:
977
978 2007-07-04  Sam Weinig  <sam@webkit.org>
979
980         Reviewed by Mitz.
981
982         Patch for http://bugs.webkit.org/show_bug.cgi?id=14504
983         REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly
984
985         - Made it possible (again) to shadow window properties with local variable names.
986
987         Test: fast/dom/Window/window-property-shadowing.html
988
989         * bindings/js/JSDOMWindowCustom.cpp:
990         (WebCore::JSDOMWindow::customPut):
991         * bindings/js/kjs_window.cpp:
992         (KJS::Window::put):
993         * bindings/scripts/CodeGeneratorJS.pm:
994         * page/DOMWindow.idl:
995
996 2007-07-03  Alice Liu  <alice.liu@apple.com>
997
998         Reviewed by Adam.
999
1000         Fixed <rdar://problem/5225119> support smart pasting on Windows
1001
1002         * WebCore.vcproj/WebCore.vcproj:
1003         * WebCore.xcodeproj/project.pbxproj:
1004             Added new files
1005         * editing/SmartReplace.cpp: Added.
1006         (WebCore::isCharacterSmartReplaceExempt):
1007             Added non-CF implementation placeholder
1008         * editing/SmartReplace.h: Added.
1009         * editing/SmartReplaceCF.cpp: Added.
1010         (WebCore::getSmartSet):
1011         (WebCore::isCharacterSmartReplaceExempt):
1012             Added new implementation
1013
1014         * bridge/win/FrameWin.cpp:
1015         * page/Frame.h:
1016         * page/mac/FrameMac.mm:
1017             Removed old declaration and implementation
1018
1019         * editing/ReplaceSelectionCommand.cpp:
1020         (WebCore::ReplaceSelectionCommand::doApply):
1021             Changed to call the new function instead of old
1022
1023         * page/mac/WebCoreFrameBridge.h:
1024         * page/mac/WebCoreFrameBridge.mm:
1025             Removed old declaration and implementation
1026         (-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):
1027             Changed to call the new function instead of old
1028
1029         * platform/win/PasteboardWin.cpp:
1030         (WebCore::Pasteboard::Pasteboard):
1031             Register new clipboard format
1032         (WebCore::Pasteboard::writeSelection):
1033             Set data for smartpaste format on clipboard
1034         (WebCore::Pasteboard::canSmartReplace):
1035             Added non-stub implementation
1036
1037 2007-07-04  Qing Zhao  <qing@staikos.net>
1038
1039         Reviewed by George Staikos.
1040
1041         Similar to the PlatformScrollbar fixes, adjust the painter to make the
1042         styler draw all subcontrols, and in this case the focus rect, in the
1043         proper location
1044
1045         * platform/qt/RenderThemeQt.cpp:
1046         (WebCore::RenderThemeQt::paintMenuList):
1047
1048 2007-07-04  Mitz Pettel  <mitz@webkit.org>
1049
1050         Reviewed by Maciej.
1051
1052         - fix http://bugs.webkit.org/show_bug.cgi?id=14495
1053           REGRESSION: Wrong cursor is displayed during drag and drop when text is selected
1054           <rdar://problem/5312384>
1055
1056         No test possible because DumpRenderTree cannot query the current cursor.
1057
1058         * page/EventHandler.cpp:
1059         (WebCore::EventHandler::selectCursor): Changed into a member function and
1060         added that if the last mouse down event could not have started a
1061         selection, then the cursor should not change to an I-beam unconditionally.
1062         (WebCore::EventHandler::handleMouseMoveEvent):
1063         * page/EventHandler.h:
1064
1065 2007-07-04  Holger Hans Peter Freyther  <zecke@selfish.org>
1066
1067         Reviewed by Rob Buis.
1068
1069         A little progress in tracking dependencies.
1070
1071         * WebCore.pro: Add DEPENDPATH for the Gdk port.
1072
1073 2007-07-03  Darin Adler  <darin@apple.com>
1074
1075         Reviewed by Tim Hatcher.
1076
1077         - fix <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
1078
1079         Test: editing/style/font-family-with-space.html
1080
1081         * css/FontFamilyValue.cpp:
1082         (WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does.
1083         (WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just
1084         checking for a leading "#" character.
1085         * editing/markup.cpp:
1086         (WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency.
1087         (WebCore::renderedText): Changed to return a String for better efficiency.
1088         (WebCore::addNamespace): Updated to pass String to escapeTextForMarkup.
1089         (WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call
1090         to escapeTextForMarkup in the special case for the style property.
1091         (WebCore::createMarkup): Changed from single quotes to double quotes and also added missing
1092         call to escapeTextForMarkup in two special cases for the style property.
1093
1094 2007-07-03  Sam Weinig  <sam@webkit.org>
1095
1096         Reviewed by Darin.
1097
1098         Twelfth round of fixes for implicit 64-32 bit conversion errors.
1099         <rdar://problem/5292262>
1100
1101         - Add casts and accompanying FIXMEs to avoid remaining compiler errors.
1102
1103         * WebCore.xcodeproj/project.pbxproj:
1104         * loader/FrameLoader.cpp:
1105         (WebCore::FrameLoader::opened):
1106         (WebCore::FrameLoader::sendRemainingDelegateMessages):
1107         * loader/FrameLoader.h:
1108         * loader/ResourceLoader.cpp:
1109         (WebCore::ResourceLoader::didReceiveData):
1110         * platform/network/mac/ResourceHandleMac.mm:
1111         (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
1112         (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
1113         * platform/network/mac/ResourceResponseMac.mm:
1114         (WebCore::ResourceResponse::nsURLResponse):
1115
1116 2007-07-03  Anders Carlsson  <andersca@apple.com>
1117
1118         Reviewed by Adam.
1119
1120         <rdar://problem/5093862>
1121         Nothing shown in plugin area when trying to play content using the DivX plugin
1122         
1123         Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.
1124                 
1125         * plugins/win/PluginViewWin.cpp:
1126         (WebCore::PluginViewWin::determineQuirks):
1127
1128 2007-07-03  Sam Weinig  <sam@webkit.org>
1129
1130         Reviewed by Brady Eidson.
1131
1132         Ninth round of fixes for implicit 64-32 bit conversion errors.
1133         <rdar://problem/5292262>
1134
1135         - Fix function signature to use unsigned long instead of unsigned long long.
1136
1137         * loader/ProgressTracker.cpp:
1138         (WebCore::ProgressTracker::completeProgress):
1139         * loader/ProgressTracker.h:
1140
1141 2007-07-03  Sam Weinig  <sam@webkit.org>
1142
1143         Reviewed by Oliver.
1144
1145         Eighth round of fixes for implicit 64-32 bit conversion errors.
1146         <rdar://problem/5292262>
1147
1148         - Convert SVG implementation files to use floats instead of doubles
1149           to match the spec/IDLs.
1150
1151         * bindings/scripts/CodeGeneratorJS.pm:
1152         * ksvg2/svg/SVGAngle.cpp:
1153         * ksvg2/svg/SVGAnimatedTemplate.h:
1154         * ksvg2/svg/SVGAnimationElement.cpp:
1155         (WebCore::SVGAnimationElement::getEndTime):
1156         (WebCore::SVGAnimationElement::getStartTime):
1157         (WebCore::SVGAnimationElement::getCurrentTime):
1158         (WebCore::SVGAnimationElement::getSimpleDuration):
1159         * ksvg2/svg/SVGAnimationElement.h:
1160         * ksvg2/svg/SVGFitToViewBox.cpp:
1161         (WebCore::SVGFitToViewBox::parseViewBox):
1162         * ksvg2/svg/SVGLength.cpp:
1163         (WebCore::SVGLength::setValueAsString):
1164         * ksvg2/svg/SVGLinearGradientElement.cpp:
1165         (WebCore::SVGLinearGradientElement::buildGradient):
1166         * ksvg2/svg/SVGMatrix.idl:
1167         * ksvg2/svg/SVGNumber.idl:
1168         * ksvg2/svg/SVGParserUtilities.cpp:
1169         (WebCore::SVGPathParser::parseSVG):
1170         (WebCore::SVGPathParser::calculateArc):
1171         (WebCore::SVGPathParser::svgLineToHorizontal):
1172         (WebCore::SVGPathParser::svgLineToVertical):
1173         (WebCore::SVGPathParser::svgCurveToCubicSmooth):
1174         (WebCore::SVGPathParser::svgCurveToQuadratic):
1175         (WebCore::SVGPathParser::svgCurveToQuadraticSmooth):
1176         (WebCore::SVGPathParser::svgArcTo):
1177         * ksvg2/svg/SVGParserUtilities.h:
1178         * ksvg2/svg/SVGPathElement.cpp:
1179         (WebCore::SVGPathElement::SVGPathElement):
1180         (WebCore::SVGPathElement::getTotalLength):
1181         (WebCore::SVGPathElement::getPointAtLength):
1182         (WebCore::SVGPathElement::getPathSegAtLength):
1183         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
1184         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
1185         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
1186         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
1187         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
1188         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
1189         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
1190         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
1191         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
1192         (WebCore::SVGPathElement::createSVGPathSegArcRel):
1193         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
1194         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
1195         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
1196         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
1197         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
1198         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
1199         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
1200         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
1201         (WebCore::SVGPathElement::svgMoveTo):
1202         (WebCore::SVGPathElement::svgLineTo):
1203         (WebCore::SVGPathElement::svgLineToHorizontal):
1204         (WebCore::SVGPathElement::svgLineToVertical):
1205         (WebCore::SVGPathElement::svgCurveToCubic):
1206         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
1207         (WebCore::SVGPathElement::svgCurveToQuadratic):
1208         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
1209         (WebCore::SVGPathElement::svgArcTo):
1210         (WebCore::SVGPathElement::parseMappedAttribute):
1211         * ksvg2/svg/SVGPathElement.h:
1212         * ksvg2/svg/SVGPathSegArc.cpp:
1213         (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
1214         (WebCore::SVGPathSegArcAbs::setX):
1215         (WebCore::SVGPathSegArcAbs::x):
1216         (WebCore::SVGPathSegArcAbs::setY):
1217         (WebCore::SVGPathSegArcAbs::y):
1218         (WebCore::SVGPathSegArcAbs::setR1):
1219         (WebCore::SVGPathSegArcAbs::r1):
1220         (WebCore::SVGPathSegArcAbs::setR2):
1221         (WebCore::SVGPathSegArcAbs::r2):
1222         (WebCore::SVGPathSegArcAbs::setAngle):
1223         (WebCore::SVGPathSegArcAbs::angle):
1224         (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
1225         (WebCore::SVGPathSegArcRel::setX):
1226         (WebCore::SVGPathSegArcRel::x):
1227         (WebCore::SVGPathSegArcRel::setY):
1228         (WebCore::SVGPathSegArcRel::y):
1229         (WebCore::SVGPathSegArcRel::setR1):
1230         (WebCore::SVGPathSegArcRel::r1):
1231         (WebCore::SVGPathSegArcRel::setR2):
1232         (WebCore::SVGPathSegArcRel::r2):
1233         (WebCore::SVGPathSegArcRel::setAngle):
1234         (WebCore::SVGPathSegArcRel::angle):
1235         * ksvg2/svg/SVGPathSegArc.h:
1236         * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
1237         (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
1238         (WebCore::SVGPathSegCurvetoCubicAbs::setX):
1239         (WebCore::SVGPathSegCurvetoCubicAbs::x):
1240         (WebCore::SVGPathSegCurvetoCubicAbs::setY):
1241         (WebCore::SVGPathSegCurvetoCubicAbs::y):
1242         (WebCore::SVGPathSegCurvetoCubicAbs::setX1):
1243         (WebCore::SVGPathSegCurvetoCubicAbs::x1):
1244         (WebCore::SVGPathSegCurvetoCubicAbs::setY1):
1245         (WebCore::SVGPathSegCurvetoCubicAbs::y1):
1246         (WebCore::SVGPathSegCurvetoCubicAbs::setX2):
1247         (WebCore::SVGPathSegCurvetoCubicAbs::x2):
1248         (WebCore::SVGPathSegCurvetoCubicAbs::setY2):
1249         (WebCore::SVGPathSegCurvetoCubicAbs::y2):
1250         (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
1251         (WebCore::SVGPathSegCurvetoCubicRel::setX):
1252         (WebCore::SVGPathSegCurvetoCubicRel::x):
1253         (WebCore::SVGPathSegCurvetoCubicRel::setY):
1254         (WebCore::SVGPathSegCurvetoCubicRel::y):
1255         (WebCore::SVGPathSegCurvetoCubicRel::setX1):
1256         (WebCore::SVGPathSegCurvetoCubicRel::x1):
1257         (WebCore::SVGPathSegCurvetoCubicRel::setY1):
1258         (WebCore::SVGPathSegCurvetoCubicRel::y1):
1259         (WebCore::SVGPathSegCurvetoCubicRel::setX2):
1260         (WebCore::SVGPathSegCurvetoCubicRel::x2):
1261         (WebCore::SVGPathSegCurvetoCubicRel::setY2):
1262         (WebCore::SVGPathSegCurvetoCubicRel::y2):
1263         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
1264         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
1265         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
1266         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX):
1267         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x):
1268         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY):
1269         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y):
1270         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX2):
1271         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x2):
1272         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY2):
1273         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y2):
1274         (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
1275         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX):
1276         (WebCore::SVGPathSegCurvetoCubicSmoothRel::x):
1277         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY):
1278         (WebCore::SVGPathSegCurvetoCubicSmoothRel::y):
1279         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX2):
1280         (WebCore::SVGPathSegCurvetoCubicSmoothRel::x2):
1281         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY2):
1282         (WebCore::SVGPathSegCurvetoCubicSmoothRel::y2):
1283         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
1284         * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
1285         (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
1286         (WebCore::SVGPathSegCurvetoQuadraticAbs::setX):
1287         (WebCore::SVGPathSegCurvetoQuadraticAbs::x):
1288         (WebCore::SVGPathSegCurvetoQuadraticAbs::setY):
1289         (WebCore::SVGPathSegCurvetoQuadraticAbs::y):
1290         (WebCore::SVGPathSegCurvetoQuadraticAbs::setX1):
1291         (WebCore::SVGPathSegCurvetoQuadraticAbs::x1):
1292         (WebCore::SVGPathSegCurvetoQuadraticAbs::setY1):
1293         (WebCore::SVGPathSegCurvetoQuadraticAbs::y1):
1294         (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
1295         (WebCore::SVGPathSegCurvetoQuadraticRel::setX):
1296         (WebCore::SVGPathSegCurvetoQuadraticRel::x):
1297         (WebCore::SVGPathSegCurvetoQuadraticRel::setY):
1298         (WebCore::SVGPathSegCurvetoQuadraticRel::y):
1299         (WebCore::SVGPathSegCurvetoQuadraticRel::setX1):
1300         (WebCore::SVGPathSegCurvetoQuadraticRel::x1):
1301         (WebCore::SVGPathSegCurvetoQuadraticRel::setY1):
1302         (WebCore::SVGPathSegCurvetoQuadraticRel::y1):
1303         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
1304         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
1305         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
1306         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
1307         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setX):
1308         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::x):
1309         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setY):
1310         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::y):
1311         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
1312         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setX):
1313         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::x):
1314         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setY):
1315         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::y):
1316         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
1317         * ksvg2/svg/SVGPathSegLineto.cpp:
1318         (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
1319         (WebCore::SVGPathSegLinetoAbs::setX):
1320         (WebCore::SVGPathSegLinetoAbs::x):
1321         (WebCore::SVGPathSegLinetoAbs::setY):
1322         (WebCore::SVGPathSegLinetoAbs::y):
1323         (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
1324         (WebCore::SVGPathSegLinetoRel::setX):
1325         (WebCore::SVGPathSegLinetoRel::x):
1326         (WebCore::SVGPathSegLinetoRel::setY):
1327         (WebCore::SVGPathSegLinetoRel::y):
1328         * ksvg2/svg/SVGPathSegLineto.h:
1329         * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
1330         (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
1331         (WebCore::SVGPathSegLinetoHorizontalAbs::setX):
1332         (WebCore::SVGPathSegLinetoHorizontalAbs::x):
1333         (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
1334         (WebCore::SVGPathSegLinetoHorizontalRel::setX):
1335         (WebCore::SVGPathSegLinetoHorizontalRel::x):
1336         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
1337         * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
1338         (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
1339         (WebCore::SVGPathSegLinetoVerticalAbs::setY):
1340         (WebCore::SVGPathSegLinetoVerticalAbs::y):
1341         (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
1342         (WebCore::SVGPathSegLinetoVerticalRel::setY):
1343         (WebCore::SVGPathSegLinetoVerticalRel::y):
1344         * ksvg2/svg/SVGPathSegLinetoVertical.h:
1345         * ksvg2/svg/SVGPathSegList.cpp:
1346         (WebCore::SVGPathSegList::getPathSegAtLength):
1347         * ksvg2/svg/SVGPathSegList.h:
1348         * ksvg2/svg/SVGPathSegMoveto.cpp:
1349         (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
1350         (WebCore::SVGPathSegMovetoAbs::setX):
1351         (WebCore::SVGPathSegMovetoAbs::x):
1352         (WebCore::SVGPathSegMovetoAbs::setY):
1353         (WebCore::SVGPathSegMovetoAbs::y):
1354         (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
1355         (WebCore::SVGPathSegMovetoRel::setX):
1356         (WebCore::SVGPathSegMovetoRel::x):
1357         (WebCore::SVGPathSegMovetoRel::setY):
1358         (WebCore::SVGPathSegMovetoRel::y):
1359         * ksvg2/svg/SVGPathSegMoveto.h:
1360         * ksvg2/svg/SVGPolyElement.cpp:
1361         (WebCore::SVGPolyElement::svgPolyTo):
1362         * ksvg2/svg/SVGRadialGradientElement.cpp:
1363         (WebCore::SVGRadialGradientElement::buildGradient):
1364         * ksvg2/svg/SVGSVGElement.cpp:
1365         (WebCore::SVGSVGElement::viewport):
1366         (WebCore::SVGSVGElement::getCurrentTime):
1367         * ksvg2/svg/SVGStopElement.cpp:
1368         (WebCore::SVGStopElement::SVGStopElement):
1369         (WebCore::SVGStopElement::parseMappedAttribute):
1370         * ksvg2/svg/SVGStopElement.h:
1371         * ksvg2/svg/SVGTransform.cpp:
1372         (SVGTransform::translate):
1373         (SVGTransform::scale):
1374         * ksvg2/svg/SVGTransformDistance.cpp:
1375         (WebCore::SVGTransformDistance::addToSVGTransform):
1376         (WebCore::SVGTransformDistance::distance):
1377         * ksvg2/svg/SVGTransformable.cpp:
1378         (WebCore::SVGTransformable::parseTransformAttribute):
1379
1380 2007-07-03  Anders Carlsson  <andersca@apple.com>
1381
1382         Reviewed by Darin.
1383
1384         <rdar://problem/5289718>
1385         http://bugs.webkit.org/show_bug.cgi?id=14437
1386         CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)
1387         
1388         Based on a patch from Maxime Britto.
1389         
1390         * page/mac/WebCoreFrameBridge.mm:
1391         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1392         If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys
1393         its frame.
1394
1395         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1396         ASSERT that this is only called on the main frame.
1397
1398 2007-07-03  John Sullivan  <sullivan@apple.com>
1399
1400         Written by Darin, reviewed by me
1401         
1402         - fixed <rdar://problem/5249730> REGRESSION (Leopard, around 9A464): Safari opens the same local 
1403           documents more than once due to canonicalization change
1404
1405         * loader/mac/LoaderNSURLExtras.m:
1406         (canonicalURL):
1407         pass URL through KURL so we get KURL's version of canonicalization as well as
1408         NSURLProtocol's version of canonicalization
1409
1410 2007-07-03  Sam Weinig  <sam@webkit.org>
1411
1412         Reviewed by Darin.
1413
1414         Seventh round of fixes for implicit 64-32 bit conversion errors.
1415         <rdar://problem/5292262>
1416
1417         - Adds more narrowPrecision functions to FloatPoint, FloatSize and FloatRect.
1418         - Changes over more implicit conversions to use new functions.
1419
1420         * bindings/js/kjs_window.cpp:
1421         (KJS::WindowFunc::callAsFunction):
1422         * platform/graphics/FloatPoint.cpp:
1423         (WebCore::FloatPoint::matrixTransform):
1424         (WebCore::FloatPoint::narrowPrecision):
1425         * platform/graphics/FloatPoint.h:
1426         * platform/graphics/FloatRect.cpp:
1427         (WebCore::FloatRect::narrowPrecision):
1428         * platform/graphics/FloatRect.h:
1429         * platform/graphics/FloatSize.cpp:
1430         (WebCore::FloatSize::narrowPrecision):
1431         * platform/graphics/FloatSize.h:
1432         * platform/graphics/Path.cpp:
1433         (WebCore::Path::createRoundedRectangle):
1434         (WebCore::Path::createRectangle):
1435         (WebCore::Path::createEllipse):
1436         * platform/graphics/mac/ColorMac.mm:
1437         (WebCore::nsColor):
1438         * platform/graphics/mac/IconMac.mm:
1439         (WebCore::Icon::paint):
1440         * platform/graphics/svg/cg/CgSupport.cpp:
1441         (WebCore::applyStrokeStyleToContext):
1442         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
1443         (WebCore::CGShadingRefForRadialGradient):
1444         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
1445         (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
1446         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
1447         (WebCore::applyLuminanceToAlphaFilter):
1448         (WebCore::applyExpandAlphatoGrayscaleFilter):
1449         (WebCore::transformImageIntoGrayscaleMask):
1450         * platform/mac/WebCoreTextRenderer.mm:
1451         (WebCoreDrawTextAtPoint):
1452         * rendering/RenderPath.cpp:
1453         (WebCore::RenderPath::mapAbsolutePointToLocal):
1454         * rendering/RenderSVGContainer.cpp:
1455         (WebCore::RenderSVGContainer::calcViewport):
1456         * rendering/RenderSVGImage.cpp:
1457         (WebCore::RenderSVGImage::nodeAtPoint):
1458         * rendering/RenderSVGText.cpp:
1459         (WebCore::RenderSVGText::relativeBBox):
1460
1461 2007-07-03  Anders Carlsson  <andersca@apple.com>
1462
1463         Reviewed by Adam.
1464
1465         <rdar://problem/5261523>
1466         Crash playing MP11 on cnbc.com
1467         
1468         The WMP Netscape plugin still creates a window even when windowless mode is turned on. Work around this by
1469         always removing the "windowlessvideo" parameter before passing it to the plugin.
1470         According to http://msdn2.microsoft.com/en-us/library/bb249373.aspx, "The windowlessVideo property is not 
1471         supported for Netscape Navigator. Setting a value for this property in Navigator may yield unexpected results."
1472         
1473         * plugins/win/PluginViewWin.cpp:
1474         (WebCore::PluginViewWndProc):
1475         (WebCore::PluginViewWin::paint):
1476         (WebCore::PluginViewWin::invalidateRect):
1477         (WebCore::PluginViewWin::determineQuirks):
1478         (WebCore::PluginViewWin::setParameters):
1479         (WebCore::PluginViewWin::PluginViewWin):
1480         (WebCore::PluginViewWin::init):
1481         * plugins/win/PluginViewWin.h:
1482         (WebCore::):
1483
1484 2007-07-03  Qing Zhao  <qing@staikos.net>
1485
1486         Reviewed by George Staikos.
1487
1488         Only draw sunken state for appropriate widgets. Not, for example, for
1489         lineedits.
1490
1491         * platform/qt/RenderThemeQt.cpp:
1492         (WebCore::RenderThemeQt::applyTheme):
1493
1494 2007-07-03  Antti Koivisto  <antti@apple.com>
1495
1496         Reviewed by Maciej.
1497         
1498         REGRESSION: misplaced selection ring remains after link is no longer focused.
1499         <rdar://problem/5205580>
1500         
1501         Fix placement of selection ring when part of the ring is in a different layer.
1502
1503         * rendering/RenderFlow.cpp:
1504         (WebCore::RenderFlow::addFocusRingRects): Get coordinates right when moving to a different layer.
1505         * rendering/RenderObject.cpp:
1506         (WebCore::RenderObject::setStyle): 
1507         Don't reset state variables when not necessary.  When repaint() was called at the end of setSyle() it would
1508         get repaint rects wrong in some cases.
1509
1510 2007-07-03  Antti Koivisto  <antti@apple.com>
1511
1512         Reviewed by Maciej.
1513
1514         Blind fix for CrashTracer: [USER] 25 crashes in Safari at com.apple.WebCore: WebCore::Frame::document const + 6
1515         <rdar://problem/5263939>
1516         
1517         No one has managed to reproduce this but it looks like null check is needed here. There are plausible ways
1518         m_frame could be null for a live FrameView object.
1519
1520         * page/FrameView.cpp:
1521         (WebCore::FrameView::needsLayout):
1522
1523 2007-07-02  Oliver Hunt  <oliver@apple.com>
1524
1525         Reviewed by Darin.
1526
1527         Fix for <rdar://problem/5098378> single-pixel image optimization needs to be rewritten to not depend on floating point bitmap
1528         Tested by fast/replaced/image-solid-color-with-alpha.html
1529
1530         Switch from float to byte based bitmap when pulling the color from 1x1 pixel images so
1531         that we can use the single pixel image optimisation in WebKit/win.
1532
1533         * platform/graphics/cg/ImageCG.cpp:
1534         (WebCore::BitmapImage::checkForSolidColor):
1535
1536 2007-07-02  Adam Roben  <aroben@apple.com>
1537
1538         Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
1539         http://bugs.webkit.org/show_bug.cgi?id=14498
1540
1541         There were two bugs:
1542         1) xPos/yPos were flipped
1543         2) + binds tighter than ?:, so the order of operations was incorrect
1544
1545         Reviewed by Darin.
1546
1547         Test: fast/inline-block/14498-positionForCoordinates.html
1548
1549         * rendering/RenderContainer.cpp:
1550         (WebCore::RenderContainer::positionForCoordinates):
1551
1552 2007-07-02  Darin Adler  <darin@apple.com>
1553
1554         Reviewed by Kevin Decker and Tim Hatcher.
1555
1556         - fix <rdar://problem/5307906> some classes need finalize methods because
1557           of non-trivial work done in dealloc methods
1558
1559         * bindings/objc/DOMRGBColor.mm:
1560         (+[DOMRGBColor initialize]): Added. Tells finalizer to run on main thread,
1561         which is needed because we are sharing a CFDictionary here with no locking.
1562
1563         * bridge/mac/WebCoreAXObject.mm:
1564         (+[WebCoreAXObject initialize]): Added. Tells finalizer to run on main thread.
1565         (-[WebCoreAXObject finalize]): Added. Calls detach.
1566
1567         * WebCore.xcodeproj/project.pbxproj: Let Xcode do what it wants to do.
1568
1569 2007-07-02  Sam Weinig  <sam@webkit.org>
1570
1571         Reviewed by Darin.
1572
1573         Sixth round of fixes for implicit 64-32 bit conversion errors.
1574         <rdar://problem/5292262>
1575
1576         Use new narrowPrecisionToFloat() and narrowPrecisionToCGFloat() where
1577         appropriate.
1578
1579         * html/CanvasRenderingContext2D.cpp:
1580         (WebCore::CanvasRenderingContext2D::setShadow):
1581         (WebCore::CanvasRenderingContext2D::applyShadow):
1582         * html/CanvasStyle.cpp:
1583         (WebCore::CanvasStyle::applyStrokeColor):
1584         (WebCore::CanvasStyle::applyFillColor):
1585         * ksvg2/svg/SVGAngle.cpp:
1586         * ksvg2/svg/SVGAnimationElement.cpp:
1587         (WebCore::SVGAnimationElement::parseKeyNumbers):
1588         (WebCore::parseKeySplines):
1589         (WebCore::SVGAnimationElement::handleTimerEvent):
1590         (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
1591         * ksvg2/svg/SVGPatternElement.cpp:
1592         (WebCore::SVGPatternElement::buildPattern):
1593         * ksvg2/svg/SVGRadialGradientElement.cpp:
1594         (WebCore::SVGRadialGradientElement::buildGradient):
1595         * platform/graphics/cg/AffineTransformCG.cpp:
1596         (WebCore::AffineTransform::AffineTransform):
1597         (WebCore::AffineTransform::setMatrix):
1598         (WebCore::AffineTransform::map):
1599         (WebCore::AffineTransform::setA):
1600         (WebCore::AffineTransform::setB):
1601         (WebCore::AffineTransform::setC):
1602         (WebCore::AffineTransform::setD):
1603         (WebCore::AffineTransform::setE):
1604         (WebCore::AffineTransform::setF):
1605         (WebCore::AffineTransform::scale):
1606         (WebCore::AffineTransform::rotate):
1607         (WebCore::AffineTransform::translate):
1608         (WebCore::AffineTransform::shear):
1609
1610 2007-07-02  John Sullivan  <sullivan@apple.com>
1611
1612         * page/mac/WebCoreFrameBridge.mm:
1613         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
1614         added a comment
1615
1616 2007-07-02  Sam Weinig  <sam@webkit.org>
1617
1618         Rubberstamped by Darin.
1619
1620         Rename FloatConversionUtilities.h to FloatConversion.h.
1621         Fix Win32 build.
1622
1623         * WebCore.vcproj/WebCore.vcproj:
1624         * WebCore.xcodeproj/project.pbxproj:
1625         * platform/DeprecatedString.cpp:
1626         * platform/FloatConversion.h: Copied from platform/FloatConversionUtilities.h.
1627         * platform/FloatConversionUtilities.h: Removed.
1628         * platform/StringImpl.cpp:
1629
1630 2007-07-02  Sam Weinig  <sam@webkit.org>
1631
1632         Reviewed by Darin.
1633
1634         Fifth round of fixes for implicit 64-32 bit conversion errors.
1635         <rdar://problem/5292262>
1636
1637         Add toFloat() method to string classes and use it where appropriate.
1638
1639         * WebCore.xcodeproj/project.pbxproj:
1640         * css/cssparser.cpp:
1641         (WebCore::CSSParser::lex):
1642         * ksvg2/svg/SVGAngle.cpp:
1643         (WebCore::SVGAngle::setValueAsString):
1644         * platform/AtomicString.h:
1645         (WebCore::AtomicString::toFloat):
1646         * platform/DeprecatedString.cpp:
1647         (WebCore::DeprecatedString::toFloat):
1648         * platform/DeprecatedString.h:
1649         * platform/FloatConversionUtilities.h: Added.
1650         (WebCore::narrowPrecisionToFloat):
1651         (WebCore::narrowPrecisionToCGFloat):
1652         * platform/PlatformString.h:
1653         * platform/String.cpp:
1654         (WebCore::String::toFloat):
1655         * platform/StringImpl.cpp:
1656         (WebCore::StringImpl::toFloat):
1657         * platform/StringImpl.h:
1658
1659 2007-07-02  Sam Weinig  <sam@webkit.org>
1660
1661         Reviewed by Kevin McCullough.
1662
1663         Fourth round of fixes for implicit 64-32 bit conversion errors.
1664         <rdar://problem/5292262>
1665
1666         Use new piDouble and piFloat constants instead of M_PI.
1667
1668         * html/CanvasRenderingContext2D.cpp:
1669         (WebCore::CanvasRenderingContext2D::rotate):
1670         * ksvg2/svg/SVGParserUtilities.cpp:
1671         (WebCore::SVGPathParser::calculateArc):
1672         * platform/graphics/Path.cpp:
1673         (WebCore::pathLengthApplierFunction):
1674         (WebCore::Path::createEllipse):
1675         * platform/graphics/cg/GraphicsContextCG.cpp:
1676         (WebCore::GraphicsContext::drawEllipse):
1677         (WebCore::GraphicsContext::strokeArc):
1678         * platform/graphics/cg/PDFDocumentImage.cpp:
1679         (WebCore::PDFDocumentImage::setCurrentPage):
1680         * platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
1681         * rendering/RenderPath.cpp:
1682         (WebCore::drawMarkerWithData):
1683
1684 2007-07-01  Adam Roben  <aroben@apple.com>
1685
1686         Clarify/fix {Shadow,BorderImage}ParseContext's memory management
1687
1688         Prefast emitted warnings that drew my attention to
1689         {Shadow,BorderImage}ParseContext::failed().  It turned out that these
1690         methods were actually correct, but rather confusing. "failed" really
1691         meant "abort and clean up" rather than "did you fail?", which was
1692         unclear. However, once I figured that out, the "and clean up" part was
1693         still a bit confusing, because all failed() did was to set a flag that
1694         would later cause the ParseContext's members to be deleted in the
1695         destructor. To clear this up, I've gotten rid of the failed() method
1696         altogether. It always returned false, so I've replaced all calls to
1697         it with the value false.
1698
1699         I also noticed that the lifetime management of the ParseContexts'
1700         members was in all cases confusing, and in some cases wrong. The
1701         m_border{Top,Right,Bottom,Left} members of BorderImageParseContext
1702         were leaked whenever a border-image property was successfully parsed.
1703         I fixed that by holding these members in OwnPtrs. The
1704         CSSPrimitiveValue members of {Shadow,BorderImage}ParseContext, which
1705         inherit from Shared, were being explicitly deleted, which is not a
1706         safe way to manage the lifetime of objects that inherit from Shared.
1707         To fix this, I put those members inside RefPtrs. These two changes
1708         allowed me to remove the destructors entirely.
1709
1710         Reviewed by Darin.
1711
1712         All regression tests pass.
1713
1714         * css/cssparser.cpp:
1715         (WebCore::ShadowParseContext::commitValue): Use .release() to avoid
1716         ref-count churn.
1717         (WebCore::ShadowParseContext::commitLength): Use a RefPtr for the new
1718         value to avoid a leak.
1719         (WebCore::CSSParser::parseShadow): Use 'false' instead of
1720         'context.failed()', and use .release() to avoid ref-count churn.
1721         (WebCore::BorderImageParseContext::commitWidth): Updated to use
1722         OwnPtr.
1723         (WebCore::CSSParser::parseBorderImage): Use 'false' instead of
1724         'context.failed'.
1725
1726 2007-07-01  Anders Carlsson  <andersca@apple.com>
1727
1728         Reviewed by John Sullivan.
1729
1730         <rdar://problem/5297146>
1731         Crash in Mail at WebCore::Frame::setUserStyleSheetLocation (reproducible w/ particular message)
1732         
1733         * loader/Cache.cpp:
1734         (WebCore::Cache::requestResource):
1735         Only insert the resource in the LRU list if the cache is enabled.
1736         
1737         (WebCore::Cache::insertInLRUList):
1738         (WebCore::Cache::resourceAccessed):
1739         Assert that the resource is in the cache.
1740
1741 2007-07-01  Darin Adler  <darin@apple.com>
1742
1743         * css/tokenizer.flex: Rolled out the fix for 14453.
1744         The layout test wasn't passing. We'll try again.
1745
1746 2007-07-01  Adam Roben  <aroben@apple.com>
1747
1748         Fix a crash in ~PluginViewWin()
1749
1750         This crash was introduced in r23827.
1751
1752         Reviewed by Anders.
1753
1754         Fixes dom/html/level2/html/HTMLAnchorElement01.html
1755
1756         * plugins/win/PluginViewWin.cpp:
1757         (WebCore::PluginViewWin::~PluginViewWin): Allow m_plugin to be null.
1758
1759 2007-07-01  Rob Buis  <buis@kde.org>
1760
1761         Reviewed by Darin.
1762
1763         http://bugs.webkit.org/show_bug.cgi?id=14453
1764         REGRESSION: www.nzherald.co.nz almost all the formating is gone
1765  
1766         * css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
1767
1768 2007-07-01  Sam Weinig  <sam@webkit.org>
1769
1770         Reviewed by Oliver.
1771
1772         Third round of implicit 64-32 bit conversion errors fixes.
1773         <rdar://problem/5292262>
1774
1775         - Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()
1776           methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
1777
1778         * css/CSSPrimitiveValue.cpp:
1779         (WebCore::CSSPrimitiveValue::computeLengthInt):
1780         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
1781         (WebCore::CSSPrimitiveValue::computeLengthShort):
1782         (WebCore::CSSPrimitiveValue::computeLengthFloat):
1783         (WebCore::CSSPrimitiveValue::computeLengthDouble):
1784         (WebCore::CSSPrimitiveValue::getDoubleValue):
1785         * css/CSSPrimitiveValue.h:
1786         (WebCore::CSSPrimitiveValue::getDoubleValue):
1787         (WebCore::CSSPrimitiveValue::getFloatValue):
1788         (WebCore::CSSPrimitiveValue::getIntValue):
1789         * css/Counter.h:
1790         (WebCore::Counter::listStyleNumber):
1791         * css/MediaQueryEvaluator.cpp:
1792         (WebCore::parseAspectRatio):
1793         * css/cssparser.cpp:
1794         (WebCore::BorderImageParseContext::commitBorderImage):
1795         * css/cssstyleselector.cpp:
1796         (WebCore::convertToLength):
1797         (WebCore::applyCounterList):
1798         (WebCore::CSSStyleSelector::applyProperty):
1799         (WebCore::CSSStyleSelector::mapBackgroundSize):
1800         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
1801         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
1802         * html/HTMLTableElement.cpp:
1803         (WebCore::HTMLTableElement::parseMappedAttribute):
1804         * ksvg2/css/SVGCSSStyleSelector.cpp:
1805         (WebCore::CSSStyleSelector::applySVGProperty):
1806         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1807         (WebCore::KSVGPainterFactory::cssPrimitiveToLength):
1808         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
1809
1810 2007-07-01  Pamela Greene  <pamg.bugs@gmail.com>
1811
1812         Reviewed by Darin.
1813
1814         Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
1815         Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
1816         <rdar://problem/5290084>
1817
1818         Use std::stable_sort() instead of qsort() to sort gradient stops.
1819         Adjust the comparison function accordingly.
1820
1821         * html/CanvasGradient.cpp:
1822         (WebCore::compareStops):
1823         (WebCore::CanvasGradient::findStop):
1824
1825 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
1826
1827         Reviewed by Darin.
1828
1829         m_usesPageCache was not initialized. As the b/f cache is only
1830         implemented in the Mac port and WebView.mm is taking care of calling
1831         Settings::setUsesPageCache I decided to make it false by default.
1832
1833         * page/Settings.cpp:
1834         (WebCore::Settings::Settings): m_usesPageCache was not initialized
1835
1836 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
1837
1838         Reviewed by Darin.
1839
1840         Inherited- and NonInheritedFlags is a bit field. But for comparsion
1841         the other part of the union _iflags/_niflags is used for comparions.
1842         This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
1843         Make sure the unused bits have a specified value.
1844
1845         * ksvg2/css/SVGRenderStyle.h:
1846         (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits
1847         have a value as well.
1848
1849 2007-06-30  Adam Roben  <aroben@apple.com>
1850
1851         Compile WebCore with /W4 on Windows
1852
1853         Some more warnings were disabled globally, including assignment within
1854         a conditional, unused variable, and various warnings related to
1855         inability to instantiate opaque structs.
1856
1857         In addition, the "unreachable code" warning was turned off for
1858         CSSGrammar.cpp and XPathGrammar.cpp.
1859
1860         Reviewed by Oliver.
1861
1862         * WebCore.vcproj/WebCore.vcproj:
1863
1864 2007-06-29  Adam Roben  <aroben@apple.com>
1865
1866         Give CString an equality operator to fix a bug in HTMLFormElement::formData
1867
1868         The bug was spotted by MSVC /W4. The problem was that we were comparing
1869         a CString to a char* using ==, but CString had no equality operator.
1870         The result was that the CString was being cast to a const char* and a
1871         pointer comparison was being done, which would (essentially) always
1872         return false.
1873
1874         There are two parts to the fix: get rid of CString's const char*
1875         casting operator, and add an equality operator. Previous uses of the
1876         casting operator have been changed to use CString::data().
1877
1878         Test: http/misc/isindex-formdata.html
1879
1880         Reviewed by Oliver.
1881
1882         * dom/XMLTokenizer.cpp:
1883         (WebCore::parseXMLDocumentFragment):
1884         * html/HTMLDocument.cpp:
1885         (WebCore::HTMLDocument::determineParseMode):
1886         * html/HTMLFormElement.cpp:
1887         (WebCore::HTMLFormElement::formData):
1888         * loader/TextResourceDecoder.cpp:
1889         (WebCore::TextResourceDecoder::checkForCSSCharset):
1890         * platform/CString.cpp:
1891         (WebCore::operator==):
1892         * platform/CString.h:
1893         * platform/KURL.cpp:
1894         (WebCore::encodeRelativeString):
1895         * platform/StringImpl.cpp:
1896         (WebCore::StringImpl::toDouble):
1897         * platform/network/cf/FormDataStreamCFNet.cpp:
1898         (WebCore::setHTTPBody):
1899         * platform/network/mac/FormDataStreamMac.mm:
1900         (WebCore::setHTTPBody):
1901         * platform/win/ClipboardUtilitiesWin.cpp:
1902         (WebCore::markupToCF_HTML):
1903         * plugins/win/PluginPackageWin.cpp:
1904         (WebCore::splitString):
1905         * plugins/win/PluginStreamWin.cpp:
1906         (WebCore::PluginStreamWin::startStream):
1907         (WebCore::PluginStreamWin::destroyStream):
1908         (WebCore::PluginStreamWin::sendJavaScriptStream):
1909         (WebCore::PluginStreamWin::didFinishLoading):
1910         * plugins/win/PluginViewWin.cpp:
1911         (WebCore::PluginViewWin::start):
1912         (WebCore::createUTF8String):
1913         (WebCore::PluginViewWin::userAgent):
1914         * xml/XSLStyleSheet.cpp:
1915         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
1916         * xml/XSLTProcessor.cpp:
1917         (WebCore::xsltParamArrayFromParameterMap):
1918
1919 2007-06-29  Adam Roben  <aroben@apple.com>
1920
1921         Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
1922
1923         Reviewed by John.
1924
1925         * editing/Editor.cpp:
1926         (WebCore::Editor::advanceToNextMisspelling):
1927         * html/HTMLParser.cpp:
1928
1929 2007-06-29  Adam Roben  <aroben@apple.com>
1930
1931         Fix some possibly unitialized variables found by MSVC /W4
1932
1933         Reviewed by John.
1934
1935         * rendering/bidi.cpp:
1936         (WebCore::RenderBlock::layoutInlineChildren):
1937
1938 2007-06-29  Adam Roben  <aroben@apple.com>
1939
1940         Remove bogus cast found by MSVC /W4
1941
1942         Reviewed by John and Oliver.
1943
1944         * ksvg2/css/SVGCSSParser.cpp:
1945         (WebCore::CSSParser::parseSVGValue):
1946
1947 2007-06-29  Adam Roben  <aroben@apple.com>
1948
1949         Remove unused local functions uncovered by MSVC /W4
1950
1951         Reviewed by John and Oliver.
1952
1953         * platform/win/SearchPopupMenuWin.cpp:
1954         * rendering/RenderText.cpp:
1955
1956 2007-06-29  Adam Roben  <aroben@apple.com>
1957
1958         Don't take the address of temporary values to appease MSVC /W4
1959
1960         Reviewed by Oliver.
1961
1962         No regression test possible.
1963
1964         * platform/win/PopupMenuWin.cpp:
1965         (WebCore::PopupMenu::invalidateItem):
1966         (WebCore::PopupMenu::valueChanged):
1967         (WebCore::PopupWndProc):
1968         * platform/win/ScrollViewWin.cpp:
1969         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
1970         * platform/win/UniscribeController.cpp:
1971         (WebCore::UniscribeController::shapeAndPlaceItem):
1972         * platform/win/WidgetWin.cpp:
1973         (WebCore::Widget::invalidateRect):
1974
1975 2007-06-29  Adam Roben  <aroben@apple.com>
1976
1977         Make an int -> UINT conversion explicit that MSVC /W4 complains about
1978
1979         Reviewed by John and Oliver.
1980
1981         No regression test possible.
1982
1983         * platform/win/SoundWin.cpp:
1984
1985 2007-06-29  Adam Roben  <aroben@apple.com>
1986
1987         Remove unreachable code uncovered by MSVC /W4
1988
1989         Reviewed by Oliver.
1990
1991         No regression test possible.
1992
1993         * html/CanvasRenderingContext2D.cpp:
1994         (WebCore::CanvasRenderingContext2D::createPattern):
1995         * html/HTMLAnchorElement.cpp:
1996         (WebCore::HTMLAnchorElement::isLiveLink):
1997         * html/HTMLElement.cpp:
1998         (WebCore::HTMLElement::contentEditable):
1999         * platform/DeprecatedString.cpp:
2000         (WebCore::allocateHandle):
2001         (WebCore::freeHandle):
2002         * plugins/win/npapi.cpp:
2003         (pluginViewForInstance):
2004         * rendering/RenderImage.cpp:
2005         (WebCore::RenderImage::isWidthSpecified):
2006         (WebCore::RenderImage::isHeightSpecified):
2007         * rendering/RenderTheme.cpp:
2008         (WebCore::RenderTheme::isControlStyled):
2009
2010 2007-06-29  John Sullivan  <sullivan@apple.com>
2011
2012         Reviewed by Oliver Hunt.
2013         
2014         - WebCore support for accessing the set of rectangles that encompass the selected text
2015         
2016         * page/Frame.h:
2017         * page/Frame.cpp:
2018         (WebCore::Frame::selectionTextRects):
2019         new function, fills in a passed Vector with the line box rects that represent the selected range
2020
2021         * rendering/RenderText.cpp:
2022         (WebCore::RenderText::addLineBoxRects):
2023         fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
2024
2025         * WebCore.exp:
2026         exported symbol for this new function
2027
2028 2007-06-29  Justin Garcia  <justin.garcia@apple.com>
2029
2030         Reviewed by Harrison.
2031         
2032         <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
2033         
2034         Rolled out a change made in r23787.
2035         
2036         * editing/DeleteSelectionCommand.cpp:
2037         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2038
2039 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
2040
2041         Reviewed by Darin Adler, Anders Carlsson.
2042         
2043         Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML 
2044         returns NULL if response MIME type is not XML -- breaks Wikipedia widget
2045         
2046         The spec says that responseXML must return null for any HTTP response
2047         with a non-XML MIME type. Technically, that leaves non-HTTP responses
2048         free to do whatever they want.
2049
2050         * xml/xmlhttprequest.cpp:
2051         (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
2052         MIME types if the response was HTTP.
2053
2054 2007-06-29  Sam Weinig  <sam@webkit.org>
2055
2056         Reviewed by Darin.
2057
2058         Second pass at fixing implicit 64-32 bit conversion errors.
2059         <rdar://problem/5292262>
2060
2061         - Use new JSValue::toFloat() method instead of toNumber() where
2062           appropriate.
2063
2064         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2065         (WebCore::JSCanvasRenderingContext2D::setFillColor):
2066         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
2067         (WebCore::JSCanvasRenderingContext2D::strokeRect):
2068         (WebCore::JSCanvasRenderingContext2D::drawImage):
2069         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
2070         (WebCore::JSCanvasRenderingContext2D::setShadow):
2071         * bindings/js/JSHTMLSelectElementCustom.cpp:
2072         (WebCore::JSHTMLSelectElement::remove):
2073         * bindings/js/JSSVGMatrixCustom.cpp:
2074         (WebCore::JSSVGMatrix::rotateFromVector):
2075         * bindings/js/kjs_events.cpp:
2076         (KJS::JSClipboardPrototypeFunction::callAsFunction):
2077         * bindings/scripts/CodeGeneratorJS.pm:
2078         * ksvg2/svg/SVGScriptElement.cpp:
2079         (WebCore::SVGScriptElement::executeScript):
2080
2081 2007-06-29  Adele Peterson  <adele@apple.com>
2082
2083         Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
2084
2085         * html/HTMLInputElement.h:
2086         * html/HTMLTextAreaElement.h:
2087
2088 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
2089
2090         Reviewed by Oliver Hunt.
2091
2092         Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing 
2093         local file throws exception -- breaks Wikipedia widget
2094
2095         * WebCore.xcodeproj/project.pbxproj:
2096         * xml/xmlhttprequest.cpp:
2097         (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
2098
2099 2007-06-29  Ada Chan  <adachan@apple.com>
2100
2101         Reviewed by Adam.
2102
2103         Fixed a previous fix to a signed/unsigned mismatch.
2104
2105         * plugins/win/PluginPackageWin.cpp:
2106         (WebCore::splitString):
2107
2108 2007-06-29  Adele Peterson  <adele@apple.com>
2109
2110         Reviewed by Ada and Kevin McCullough.
2111
2112         Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
2113
2114         Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
2115
2116         Tests:
2117         fast/forms/input-readonly-select-all.html
2118         fast/forms/textarea-readonly-select-all.html
2119
2120         * html/HTMLInputElement.h:
2121         (WebCore::HTMLInputElement::canSelectAll):
2122         (WebCore::HTMLInputElement::selectAll):
2123         * html/HTMLTextAreaElement.h:
2124         (WebCore::HTMLTextAreaElement::canSelectAll):
2125         (WebCore::HTMLTextAreaElement::selectAll):
2126
2127 2007-06-29  Adam Roben  <aroben@apple.com>
2128
2129         Build fix
2130
2131         This is what happens when you test your patch on two OSs and then
2132         commit from the wrong one.
2133
2134         * rendering/RenderTextControl.cpp:
2135         (WebCore::RenderTextControl::valueChanged):
2136         (WebCore::RenderTextControl::itemText):
2137         (WebCore::RenderTextControl::itemIsSeparator):
2138
2139 2007-06-29  Adam Roben  <aroben@apple.com>
2140
2141         Start compiling WebCore with /W3 under MSVC
2142
2143         One warning was globally disabled: implicit conversion of int to bool.
2144
2145         Reviewed by Darin.
2146
2147         * WebCore.vcproj/WebCore.vcproj:
2148
2149 2007-06-29  Adam Roben  <aroben@apple.com>
2150
2151         Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
2152
2153         DeprecatedStringData now has no public copy constructor. The single
2154         call to the old one has been replaced with a call to the new
2155         DeprecatedStringData::createAndAdopt static method.
2156
2157         Reviewed by Darin.
2158
2159         All regression tests pass.
2160
2161         * platform/DeprecatedString.cpp:
2162         (WebCore::DeprecatedStringData::createAndAdopt):
2163         (WebCore::DeprecatedStringData::adopt):
2164         (WebCore::DeprecatedString::detachIfInternal):
2165         * platform/DeprecatedString.h:
2166
2167 2007-06-29  Adam Roben  <aroben@apple.com>
2168
2169         Fix more signed/unsigned mismatches uncovered by MSVC /W3
2170
2171         Reviewed by John.
2172
2173         No regression tests possible.
2174
2175         * platform/network/cf/ResourceResponseCFNet.cpp:
2176         (WebCore::filenameHasSaneExtension):
2177         * platform/win/FontDataWin.cpp:
2178         (WebCore::FontData::containsCharacters):
2179         * platform/win/PlatformScrollBarSafari.cpp:
2180         (WebCore::):
2181         * platform/win/UniscribeController.cpp:
2182         (WebCore::UniscribeController::advance):
2183         (WebCore::UniscribeController::shapeAndPlaceItem):
2184         * platform/win/WebCoreTextRenderer.cpp:
2185         (WebCore::doDrawTextAtPoint):
2186         * plugins/win/PluginDatabaseWin.cpp:
2187         (WebCore::parseVersionString):
2188         * plugins/win/PluginPackageWin.cpp:
2189         (WebCore::splitString):
2190         * plugins/win/PluginViewWin.cpp:
2191         (WebCore::freeStringArray):
2192         (WebCore::PluginViewWin::invalidateTimerFired):
2193
2194 2007-06-29  Adam Roben  <aroben@apple.com>
2195
2196         Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
2197
2198         Reviewed by John.
2199
2200         No regression test possible.
2201
2202         * html/HTMLSelectElement.cpp:
2203         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
2204         * platform/PopupMenuClient.h:
2205         * platform/win/PopupMenuWin.cpp:
2206         (WebCore::PopupMenu::calculatePositionAndSize):
2207         (WebCore::PopupMenu::focusFirst):
2208         (WebCore::PopupMenu::focusLast):
2209         (WebCore::PopupMenu::down):
2210         (WebCore::PopupMenu::up):
2211         (WebCore::PopupMenu::paint):
2212         * rendering/RenderMenuList.cpp:
2213         * rendering/RenderMenuList.h:
2214         * rendering/RenderTextControl.cpp:
2215         * rendering/RenderTextControl.h:
2216
2217 2007-06-29  Adam Roben  <aroben@apple.com>
2218
2219         Fix two typos spotted by MSVC /W3
2220
2221         Both typos were a semicolon following the condition of an if. This
2222         would cause the intended body of the if to always execute.
2223
2224         Unfortunately neither of these fixes are testable.
2225         BackForwardList::goForward is only called from WebBackForwardList, and
2226         the createDragImageFromImage bug would only manifest itself when
2227         CreateCompatibleDC failed.
2228
2229         Reviewed by Mark.
2230
2231         * history/BackForwardList.cpp:
2232         (WebCore::BackForwardList::goForward):
2233         * platform/win/DragImageWin.cpp:
2234         (WebCore::createDragImageFromImage):
2235
2236 2007-06-29  Adam Treat  <adam@staikos.net>
2237
2238         Reviewed by george Staikos.
2239
2240         Support horizontal and vertical scroll, and set the right units.
2241
2242         * platform/qt/WheelEventQt.cpp:
2243         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2244
2245 2007-06-28  Adam Roben  <aroben@apple.com>
2246
2247         Get WebCore compiling with /W2 on Windows
2248
2249         Reviewed by Steve.
2250
2251         No regression tests affected.
2252
2253         * WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
2254         disable two warnings: implicit int <=> float conversion, and class vs.
2255         struct inconsistency.
2256         * dom/CharacterData.cpp:
2257         (WebCore::CharacterData::deleteData): Cast to int before negating.
2258         * loader/Cache.cpp:
2259         (WebCore::Cache::remove): Ditto.
2260         * platform/graphics/Path.cpp:
2261         (WebCore::pathLengthApplierFunction): Consistently use floats.
2262         * platform/graphics/cg/GraphicsContextCG.cpp:
2263         (WebCore::GraphicsContext::drawEllipse): Ditto.
2264         * platform/win/GraphicsContextWin.cpp:
2265         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
2266
2267 2007-06-28  Geoffrey Garen  <ggaren@apple.com>
2268
2269         Reviewed by Maciej Stachowiak.
2270         
2271         Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease 
2272         pool => pathologically high high water mark
2273         
2274         I couldn't measure any performance problems with iBench HTML or PLT.
2275
2276         * WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
2277         * platform/mac/SharedTimerMac.cpp:
2278         (WebCore::timerFired): Added autorelease pool.
2279
2280 2007-06-28  Mitz Pettel  <mitz@webkit.org>
2281
2282         Reviewed by Beth.
2283
2284         - fix http://bugs.webkit.org/show_bug.cgi?id=14118
2285           ASSERTION FAILED: !needsLayout() seen again
2286
2287         Test: fast/dynamic/recursive-layout.html
2288
2289         * page/FrameView.cpp:
2290         (WebCore::FrameView::layout): Removed the midLayout guards around
2291         the calls to invalidateSelection() and updateWidgetPositions(). Those
2292         calls may dirty the layout, but in that case they also update it, so
2293         they should be allowed to do it. Added an ASSERT to make sure that when
2294         they return, the root is not marked for layout.
2295
2296 2007-06-28  Sam Weinig  <sam@webkit.org>
2297
2298         Rubberstamped by Adam Roben.
2299
2300         Roll out r23861.  It caused the buildbot to fail on intel.
2301
2302         * page/Page.cpp:
2303         (WebCore::Page::goToItem):
2304
2305 2007-06-26  Maxime Britto  <mbritto@pleyo.com>
2306
2307         Reviewed by Geoff.
2308
2309         Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
2310         ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
2311
2312         Modification of an ASSERT on goToItem related to go back/forward in
2313         history.Don't need to check the frameset if the target is _blank.
2314
2315          * page/Page.cpp:
2316          (WebCore::Page::goToItem):
2317
2318 2007-06-28  Anders Carlsson  <andersca@apple.com>
2319
2320         Reviewed by Oliver.
2321
2322         <rdar://problem/5234139>
2323         <object> with PNG src rendered as image document.
2324         
2325         Complete the URL before passing it to the frame loader client.
2326         
2327         * html/HTMLObjectElement.cpp:
2328         (WebCore::HTMLObjectElement::isImageType):
2329
2330 2007-06-28  Rob Buis  <buis@kde.org>
2331
2332         Reviewed by Maciej.
2333
2334         http://bugs.webkit.org/show_bug.cgi?id=14373
2335         CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
2336
2337         Make sure the id selector validates against the CSS2.1 identfier
2338         definition, not the hexcolor/HASH definition.
2339
2340         * css/CSSGrammar.y:
2341         * css/cssparser.cpp:
2342         (WebCore::CSSParser::lex):
2343         (WebCore::CSSParser::text):
2344         * css/tokenizer.flex:
2345
2346 2007-06-28  Simon Hausmann  <hausmann@kde.org>
2347
2348         Reviewed by Zack.
2349
2350         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
2351
2352         * platform/qt/PasteboardQt.cpp:
2353         (WebCore::Pasteboard::writeSelection):
2354
2355 2007-06-28  Antti Koivisto  <antti@apple.com>
2356
2357         Reviewed by Mitz.
2358         
2359         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
2360         Bug 14332: REGRESSION (r21145): <td> width ignored
2361         <rdar://problem/5290123>
2362         
2363         Cells in table with non-zero cellpadding are not considered empty.
2364
2365         * rendering/AutoTableLayout.cpp:
2366         (WebCore::AutoTableLayout::recalcColumn):
2367
2368 2007-06-28  Adam Roben  <aroben@apple.com>
2369
2370         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
2371
2372         Reviewed by Hyatt.
2373
2374         No layout test possible, as this bug didn't have any effect since
2375         "bool & bool" has the same value as "bool && bool"
2376
2377         * rendering/RenderBlock.cpp:
2378         (WebCore::RenderBlock::paintObject): Changed & to &&.
2379
2380 2007-06-28  Adam Roben  <aroben@apple.com>
2381
2382         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
2383
2384         The bug was caused by two typos found by prefast.
2385
2386         Reviewed by Hyatt.
2387
2388         * css/cssparser.cpp:
2389         (WebCore::CSSParser::parseValue): Fixed typos.
2390
2391 2007-06-20  Matt Perry  <mpComplete@gmail.com>
2392
2393         Reviewed by Adam.
2394
2395         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
2396           onchange handler for select controls doesn't fire when changing via keyboard
2397
2398         * html/HTMLSelectElement.cpp:
2399         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
2400         a call to saveLastSelection in the "Enter" key handler for select
2401         controls that was preventing onchange from firing.
2402
2403 2007-06-27  Sam Weinig  <sam@webkit.org>
2404
2405         Fix Gdk, Qt, and Win32 builds.
2406
2407         * WebCore.pro:
2408         * WebCore.vcproj/WebCore.vcproj:
2409
2410 2007-06-27  Sam Weinig  <sam@webkit.org>
2411
2412         Reviewed by Geoff.
2413
2414         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
2415         Move the Selection object out of the JS bindings
2416
2417         - Renames JS Object Selection to DOMSelection to avoid a name
2418           conflict.
2419
2420         * DerivedSources.make:
2421         * WebCore.xcodeproj/project.pbxproj:
2422         * bindings/js/kjs_window.cpp:
2423         (KJS::WindowPrivate::WindowPrivate):
2424         (KJS::Window::mark):
2425         (KJS::Window::clearHelperObjectProperties):
2426         (KJS::WindowFunc::callAsFunction):
2427         (KJS::Window::disconnectFrame):
2428         * bindings/js/kjs_window.h:
2429         (KJS::Window::):
2430         * page/DOMSelection.cpp: Added.
2431         (WebCore::DOMSelection::DOMSelection):
2432         (WebCore::DOMSelection::frame):
2433         (WebCore::DOMSelection::disconnectFrame):
2434         (WebCore::DOMSelection::anchorNode):
2435         (WebCore::DOMSelection::baseNode):
2436         (WebCore::DOMSelection::anchorOffset):
2437         (WebCore::DOMSelection::baseOffset):
2438         (WebCore::DOMSelection::focusNode):
2439         (WebCore::DOMSelection::extentNode):
2440         (WebCore::DOMSelection::focusOffset):
2441         (WebCore::DOMSelection::extentOffset):
2442         (WebCore::DOMSelection::isCollapsed):
2443         (WebCore::DOMSelection::type):
2444         (WebCore::DOMSelection::rangeCount):
2445         (WebCore::DOMSelection::collapse):
2446         (WebCore::DOMSelection::collapseToEnd):
2447         (WebCore::DOMSelection::collapseToStart):
2448         (WebCore::DOMSelection::empty):
2449         (WebCore::DOMSelection::setBaseAndExtent):
2450         (WebCore::DOMSelection::setPosition):
2451         (WebCore::DOMSelection::modify):
2452         (WebCore::DOMSelection::getRangeAt):
2453         (WebCore::DOMSelection::removeAllRanges):
2454         (WebCore::DOMSelection::addRange):
2455         (WebCore::DOMSelection::toString):
2456         * page/DOMSelection.h: Added.
2457         * page/DOMSelection.idl: Added.
2458         * page/DOMWindow.cpp:
2459         (WebCore::DOMWindow::disconnectFrame):
2460         (WebCore::DOMWindow::getSelection):
2461         * page/DOMWindow.h:
2462         * page/DOMWindow.idl:
2463
2464 2007-06-27  Sam Weinig  <sam@webkit.org>
2465
2466         Reviewed by Maciej.
2467
2468         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
2469         Autogenerate Event JS binding
2470
2471         - Cleanup kjs_events
2472
2473         * bindings/js/kjs_events.cpp:
2474         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
2475         (WebCore::JSAbstractEventListener::handleEvent):
2476         (WebCore::JSAbstractEventListener::isHTMLEventListener):
2477         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
2478         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
2479         (WebCore::JSUnprotectedEventListener::listenerObj):
2480         (WebCore::JSUnprotectedEventListener::windowObj):
2481         (WebCore::JSUnprotectedEventListener::clearWindowObj):
2482         (WebCore::JSUnprotectedEventListener::mark):
2483         (WebCore::JSEventListener::JSEventListener):
2484         (WebCore::JSEventListener::~JSEventListener):
2485         (WebCore::JSEventListener::listenerObj):
2486         (WebCore::JSEventListener::windowObj):
2487         (WebCore::JSEventListener::clearWindowObj):
2488         (WebCore::JSLazyEventListener::JSLazyEventListener):
2489         (WebCore::JSLazyEventListener::listenerObj):
2490         (WebCore::JSLazyEventListener::parseCode):
2491         (WebCore::getNodeEventListener):
2492         (WebCore::JSClipboard::JSClipboard):
2493         (WebCore::JSClipboard::getValueProperty):
2494         (WebCore::JSClipboard::putValueProperty):
2495         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
2496         (WebCore::toJS):
2497         (WebCore::toClipboard):
2498         * bindings/js/kjs_events.h:
2499         (WebCore::JSClipboard::classInfo):
2500         (WebCore::JSClipboard::impl):
2501         * bindings/js/kjs_window.h:
2502         * ksvg2/events/JSSVGLazyEventListener.h:
2503
2504 2007-06-27  Sam Weinig  <sam@webkit.org>
2505
2506         Reviewed by Adam Roben.
2507
2508         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
2509         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
2510         <rdar://problem/5286670>
2511
2512         Test: fast/forms/thumbslider-no-parent-slider.html
2513         Test: fast/forms/thumbslider-crash.html
2514
2515         * rendering/RenderObject.h:
2516         (WebCore::RenderObject::isSlider):
2517         * rendering/RenderSlider.h:
2518         (WebCore::RenderSlider::isSlider):
2519         * rendering/RenderTheme.cpp:
2520         (WebCore::RenderTheme::paint): Only paint thumbslider
2521         if the parent renderer is a RenderSlider.
2522         * rendering/RenderThemeMac.mm:
2523         (WebCore::RenderThemeMac::paintSliderThumb):
2524         * rendering/RenderThemeSafari.cpp:
2525         (WebCore::RenderThemeSafari::paintSliderThumb):
2526
2527 2007-06-27  George Staikos  <staikos@kde.org>
2528
2529         Make Qt builds link when XSLT is turned off.
2530
2531         * WebCore.pro:
2532
2533 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
2534
2535         Turn on static code analysis (Windows only).
2536
2537         Affects only folks that have Visual Studio Team Suite installed,
2538         or who have replaced their compiler with the version shipping in the
2539         Vista SDK.
2540         
2541         Reviewed by Oliver.
2542
2543         * WebCore.vcproj/WebCore.vcproj:
2544
2545 2007-06-27  George Staikos  <staikos@kde.org>
2546
2547         Remove old commented out files that no-longer exist.
2548
2549         * WebCore.pro:
2550
2551 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
2552
2553         Reviewed by John.
2554
2555         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
2556         
2557         Pasting with a trailing interchange newline doesn't work when pasting
2558         into an empty line.  Code that handles removing brs at the insertion
2559         position tries to also handle trailing interchange newlines by re-using
2560         those brs and fails.  Removed that code and handle all interchange
2561         newlines with code later in doApply().
2562
2563         * editing/ReplaceSelectionCommand.cpp:
2564         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
2565         endBR when there's a trailing interchange newline.
2566         
2567 2007-06-27  Anders Carlsson  <andersca@apple.com>
2568
2569         Reviewed by Oliver.
2570
2571         <rdar://problem/5253950>
2572         When Shockwave plugin has been loaded, exiting crashes Safari
2573         
2574         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
2575         
2576         * plugins/win/PluginPackageWin.cpp:
2577         (WebCore::PluginPackageWin::PluginPackageWin):
2578         (WebCore::PluginPackageWin::load):
2579         (WebCore::PluginPackageWin::unload):
2580         (WebCore::PluginPackageWin::unloadWithoutShutdown):
2581         * plugins/win/PluginPackageWin.h:
2582         
2583         * plugins/win/PluginViewWin.cpp:
2584         (WebCore::PluginViewWin::~PluginViewWin):
2585         Make sure to unload the plugin package and clear any references to plugin script objects.
2586
2587 2007-06-27  George Staikos  <staikos@kde.org>
2588
2589         This was succeeding compile by luck.  Setup dependencies properly.
2590
2591         * WebCore.pro:
2592
2593 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
2594
2595         Reviewed by John.
2596
2597         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
2598         
2599         When a quoted numbered list is broken in half, it's cloned
2600         to make the second list. That second list needs its start attribute
2601         set so that the numbers of the list items in it will be preserved.
2602
2603         * editing/BreakBlockquoteCommand.cpp:
2604         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
2605         of a cloned list to be the original number of the first list item in it.
2606
2607 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
2608
2609         Reviewed by Geoff.
2610
2611         http://bugs.webkit.org/show_bug.cgi?id=14413
2612         GIF animation throttling is different from MSIE
2613
2614         * platform/graphics/cg/ImageSourceCG.cpp:
2615         (WebCore::ImageSource::frameDurationAtIndex):
2616         Change the cut-off value to 50ms to match MSIE.
2617
2618 2007-06-27  Sam Weinig  <sam@webkit.org>
2619
2620         Reviewed by Darin.
2621
2622         First pass at fixing implicit 64-32 bit conversion errors.
2623         <rdar://problem/5292262>
2624
2625         - Add 'f' suffix where necessary.
2626
2627         * bridge/mac/WebCoreAXObject.mm:
2628         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
2629         * css/csshelper.h:
2630         * css/cssstyleselector.cpp:
2631         (WebCore::):
2632         (WebCore::CSSStyleSelector::largerFontSize):
2633         (WebCore::CSSStyleSelector::smallerFontSize):
2634         * html/CanvasGradient.cpp:
2635         (WebCore::CanvasGradient::addColorStop):
2636         * html/CanvasPattern.cpp:
2637         (WebCore::CanvasPattern::createPattern):
2638         * ksvg2/css/SVGCSSStyleSelector.cpp:
2639         (WebCore::CSSStyleSelector::applySVGProperty):
2640         * ksvg2/css/SVGRenderStyle.h:
2641         * ksvg2/events/SVGZoomEvent.cpp:
2642         (WebCore::SVGZoomEvent::SVGZoomEvent):
2643         * ksvg2/svg/SVGLength.cpp:
2644         (WebCore::SVGLength::SVGLength):
2645         (WebCore::SVGLength::value):
2646         (WebCore::SVGLength::setValue):
2647         (WebCore::SVGLength::valueAsPercentage):
2648         (WebCore::SVGLength::PercentageOfViewport):
2649         * ksvg2/svg/SVGSVGElement.cpp:
2650         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
2651         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
2652         (WebCore::SVGSVGElement::getScreenCTM):
2653         * ksvg2/svg/SVGTextContentElement.cpp:
2654         (WebCore::SVGTextContentElement::getComputedTextLength):
2655         (WebCore::SVGTextContentElement::getSubStringLength):
2656         (WebCore::SVGTextContentElement::getRotationOfChar):
2657         * ksvg2/svg/SVGTransformDistance.cpp:
2658         (WebCore::SVGTransformDistance::SVGTransformDistance):
2659         (WebCore::SVGTransformDistance::distance):
2660         * page/InspectorController.cpp:
2661         (WebCore::InspectorResource::InspectorResource):
2662         * platform/graphics/FloatPoint3D.cpp:
2663         (WebCore::FloatPoint3D::normalize):
2664         * platform/graphics/Path.cpp:
2665         (WebCore::pathLengthApplierFunction):
2666         (WebCore::Path::createRoundedRectangle):
2667         * platform/graphics/cg/GraphicsContextCG.cpp:
2668         (WebCore::GraphicsContext::drawLine):
2669         (WebCore::GraphicsContext::strokeArc):
2670         * platform/graphics/cg/ImageCG.cpp:
2671         (WebCore::FrameData::clear):
2672         * platform/graphics/cg/ImageSourceCG.cpp:
2673         (WebCore::ImageSource::frameDurationAtIndex):
2674         * platform/graphics/cg/PDFDocumentImage.cpp:
2675         (WebCore::PDFDocumentImage::setCurrentPage):
2676         * platform/graphics/svg/SVGPaintServerPattern.cpp:
2677         (WebCore::SVGPaintServerPattern::externalRepresentation):
2678         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
2679         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
2680         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
2681         (WebCore::cgGradientCallback):
2682         (WebCore::CGShadingRefForRadialGradient):
2683         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
2684         * platform/mac/FontDataMac.mm:
2685         (WebCore::webFallbackFontFamily):
2686         * platform/mac/PopupMenuMac.mm:
2687         (WebCore::PopupMenu::show):
2688         * rendering/InlineFlowBox.cpp:
2689         (WebCore::InlineFlowBox::placeBoxesHorizontally):
2690         * rendering/RenderSlider.cpp:
2691         (WebCore::RenderSlider::setValueForPosition):
2692         (WebCore::RenderSlider::setPositionFromValue):
2693
2694 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
2695
2696         Reviewed by Geoff.
2697
2698         http://bugs.webkit.org/show_bug.cgi?id=14288
2699         XMLHttpRequest doesn't use a correct content type for file:// URLs
2700
2701         Test: fast/dom/xmlhttprequest-html-response-encoding.html
2702
2703         * xml/xmlhttprequest.cpp:
2704         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
2705         the network layer, since it provides it even for non-HTTP responses.
2706
2707 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
2708
2709         Reviewed by Sam Weinig.
2710
2711         http://bugs.webkit.org/show_bug.cgi?id=14061
2712         Implement more of FrameLoaderClientGdk
2713
2714         Make FrameLoaderClientGdk work properly when the MIME type is set.
2715
2716         * loader/gdk/FrameLoaderClientGdk.cpp:
2717         (WebCore::FrameLoaderClientGdk::objectContentType):
2718         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
2719
2720 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
2721
2722         Reviewed by Maciej.
2723
2724         http://bugs.webkit.org/show_bug.cgi?id=14058
2725         Gdk font backend cleanup
2726
2727         * platform/FontData.h: Remove obsolete function.
2728         * platform/gdk/FontDataGdk.cpp:
2729         (WebCore::FontData::containsCharacters): Lock/unlock only once.
2730         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
2731         * platform/gdk/FontPlatformData.h: Remove obsolete function.
2732         * platform/gdk/FontPlatformDataGdk.cpp:
2733         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
2734         not the pixel size.
2735         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
2736         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
2737         (WebCore::GlyphPage::fill): Lock/unlock only once.
2738
2739 2007-06-26  Mitz Pettel  <mitz@webkit.org>
2740
2741         Reviewed by Hyatt.
2742
2743         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
2744           <colgroup>'s borders are ignored when it has <col> children
2745
2746         Covered by existing tests.
2747
2748         * rendering/RenderTableCell.cpp:
2749         (WebCore::RenderTableCell::collapsedLeftBorder):
2750         (WebCore::RenderTableCell::collapsedRightBorder):
2751         (WebCore::RenderTableCell::collapsedTopBorder):
2752         (WebCore::RenderTableCell::collapsedBottomBorder):
2753
2754 2007-06-26  Mitz Pettel  <mitz@webkit.org>
2755
2756         Reviewed by Oliver.
2757
2758         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
2759           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
2760
2761         Test: fast/repaint/text-selection-rect-in-overflow-2.html
2762
2763         * rendering/RenderObject.cpp:
2764         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
2765         for overflow scroll and columns.
2766         * rendering/RenderText.cpp:
2767         (WebCore::RenderText::selectionRect): Adjust for columns only in the
2768         non-clipped case, since RenderObject::absolutePosition() does not.
2769
2770 2007-06-26  Mitz Pettel  <mitz@webkit.org>
2771
2772         Reviewed by Sam.
2773
2774         - http://bugs.webkit.org/show_bug.cgi?id=14415
2775           Remove the unused method RenderObject::setTable()
2776
2777         * rendering/RenderObject.h:
2778
2779 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
2780
2781         Reviewed by Maciej.
2782
2783         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
2784         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
2785
2786         This change moves the bulk of ResourceRequest into a base class named
2787         ResourceRequestBase with all platform-specific bits pushed into
2788         ResourceRequest.  This allows ports to easily add new members to a
2789         ResourceRequest without having to #ifdef the code that is shared
2790         between ports.
2791
2792         * WebCore.exp:
2793         * WebCore.pro:
2794         * WebCore.vcproj/WebCore.vcproj:
2795         * WebCore.xcodeproj/project.pbxproj:
2796         * platform/network/ResourceRequest.cpp: Removed.
2797         * platform/network/ResourceRequest.h: Removed.
2798         * platform/network/ResourceRequestBase.cpp: Added.
2799         (WebCore::ResourceRequestBase::asResourceRequest):
2800         (WebCore::ResourceRequestBase::isEmpty):
2801         (WebCore::ResourceRequestBase::isNull):
2802         (WebCore::ResourceRequestBase::url):
2803         (WebCore::ResourceRequestBase::setURL):
2804         (WebCore::ResourceRequestBase::cachePolicy):
2805         (WebCore::ResourceRequestBase::setCachePolicy):
2806         (WebCore::ResourceRequestBase::timeoutInterval):
2807         (WebCore::ResourceRequestBase::setTimeoutInterval):
2808         (WebCore::ResourceRequestBase::mainDocumentURL):
2809         (WebCore::ResourceRequestBase::setMainDocumentURL):
2810         (WebCore::ResourceRequestBase::httpMethod):
2811         (WebCore::ResourceRequestBase::setHTTPMethod):
2812         (WebCore::ResourceRequestBase::httpHeaderFields):
2813         (WebCore::ResourceRequestBase::httpHeaderField):
2814         (WebCore::ResourceRequestBase::setHTTPHeaderField):
2815         (WebCore::ResourceRequestBase::httpBody):
2816         (WebCore::ResourceRequestBase::setHTTPBody):
2817         (WebCore::ResourceRequestBase::allowHTTPCookies):
2818         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
2819         (WebCore::ResourceRequestBase::addHTTPHeaderField):
2820         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
2821         (WebCore::operator==):
2822         (WebCore::ResourceRequestBase::isConditional):
2823         (WebCore::ResourceRequestBase::updatePlatformRequest):
2824         (WebCore::ResourceRequestBase::updateResourceRequest):
2825         * platform/network/ResourceRequestBase.h: Added.
2826         (WebCore::):
2827         (WebCore::ResourceRequestBase::httpContentType):
2828         (WebCore::ResourceRequestBase::setHTTPContentType):
2829         (WebCore::ResourceRequestBase::httpReferrer):
2830         (WebCore::ResourceRequestBase::setHTTPReferrer):
2831         (WebCore::ResourceRequestBase::clearHTTPReferrer):
2832         (WebCore::ResourceRequestBase::httpUserAgent):
2833         (WebCore::ResourceRequestBase::setHTTPUserAgent):
2834         (WebCore::ResourceRequestBase::httpAccept):
2835         (WebCore::ResourceRequestBase::setHTTPAccept):
2836         (WebCore::ResourceRequestBase::ResourceRequestBase):
2837         (WebCore::operator!=):
2838         * platform/network/cf/ResourceRequest.h: Added.
2839         (WebCore::ResourceRequest::ResourceRequest):
2840         * platform/network/curl/ResourceRequest.h: Added.
2841         (WebCore::ResourceRequest::ResourceRequest):
2842         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2843         (WebCore::ResourceRequest::doUpdateResourceRequest):
2844         * platform/network/mac/ResourceRequest.h: Added.
2845         (WebCore::ResourceRequest::ResourceRequest):
2846         * platform/network/qt/ResourceRequest.h: Added.
2847         (WebCore::ResourceRequest::ResourceRequest):
2848         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2849         (WebCore::ResourceRequest::doUpdateResourceRequest):
2850
2851 2007-06-26  Adam Roben  <aroben@apple.com>
2852
2853         Add ChangeLog entries from the Windows merge.
2854
2855         Reviewed by Maciej.
2856
2857         * ChangeLog:
2858
2859 2007-06-26  Sam Weinig  <sam@webkit.org>
2860
2861         Reviewed by Maciej.
2862
2863         Make sure not to enumerate the toString() function.
2864         <rdar://problem/5297118>
2865
2866         * bindings/js/kjs_window.cpp:
2867         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
2868         * html/HTMLAnchorElement.idl:
2869
2870 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
2871
2872         Reviewed by Mitz, landed by Anders.
2873
2874         http://bugs.webkit.org/show_bug.cgi?id=14421
2875         Implement GraphicsContext::clearRect()
2876
2877         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2878         (WebCore::GraphicsContext::clearRect):
2879
2880 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
2881
2882         Reviewed and landed by Anders.
2883
2884         http://bugs.webkit.org/show_bug.cgi?id=14416
2885         Content does not render fully in some cases
2886
2887         Fix mismatched calls to cairo_save/restore due to an early method return.
2888
2889         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2890         (WebCore::GraphicsContext::drawLine):
2891
2892 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
2893
2894         Reviewed by John Sullivan.
2895
2896         Added two accessor functions for <rdar://problem/4119138>
2897
2898         * bindings/objc/DOMHTML.mm:
2899         (-[DOMHTMLInputElement _isEdited]):
2900         (-[DOMHTMLTextAreaElement _isEdited]):
2901         Added an accessor to the isEdited value of a DOM node's render object
2902
2903         * bindings/objc/DOMPrivate.h:
2904         Added header definitions for _isEdited
2905
2906 2007-06-26  Sam Weinig  <sam@webkit.org>
2907
2908         Fix Win32 build.
2909
2910         * WebCore.vcproj/WebCore.vcproj:
2911
2912 2007-06-26  Sam Weinig  <sam@webkit.org>
2913
2914         Fix Qt and Gdk builds.
2915
2916         * WebCore.pro:
2917
2918 2007-06-26  Sam Weinig  <sam@webkit.org>
2919
2920         Reviewed by Geoff.
2921
2922         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
2923         Autogenerate Event JS binding
2924
2925         - Moves the dataTransfer method into MouseEvent where it should be.
2926
2927         * WebCore.xcodeproj/project.pbxproj:
2928         * bindings/js/JSEventCustom.cpp: Added.
2929         (WebCore::JSEvent::clipboardData):
2930         (WebCore::toJS):
2931         * bindings/js/JSEventTargetNode.cpp:
2932         * bindings/js/JSXMLHttpRequest.cpp:
2933         * bindings/js/kjs_events.cpp:
2934         * bindings/js/kjs_events.h:
2935         * bindings/objc/DOMUtility.mm:
2936         (KJS::createDOMWrapper):
2937         * bindings/scripts/CodeGeneratorJS.pm:
2938         * dom/Event.h:
2939         (WebCore::Event::returnValue):
2940         (WebCore::Event::setReturnValue):
2941         (WebCore::Event::clipboardData):
2942         * dom/Event.idl:
2943         * dom/MouseEvent.h:
2944         (WebCore::MouseEvent::dataTransfer):
2945         * dom/MouseEvent.idl:
2946
2947 2007-06-26  Timothy Hatcher  <timothy@apple.com>
2948
2949         Reviewed by Mark Rowe.
2950
2951         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
2952         http://bugs.webkit.org/show_bug.cgi?id=14385
2953
2954         Correctly remember the "Show implicit properties" setting as you switch nodes.
2955
2956         * page/inspector/ResourcePanel.js:
2957
2958 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
2959
2960         Reviewed by John.
2961
2962         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
2963         
2964         Editing removed a node that was part of a search field's internal
2965         structure that should not be removed.
2966
2967         * editing/DeleteSelectionCommand.cpp:
2968         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
2969         selection to delete ends at [container, x], where x is the number
2970         of children in container, don't remove container.  Special case
2971         code elsewhere in this function will remove it if necessary.
2972
2973 2007-06-25  Sam Weinig  <sam@webkit.org>
2974
2975         Reviewed by Maciej.
2976
2977         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
2978         Mutating document.constructor.prototype mutates Object.prototype
2979
2980         Test: fast/js/constructor.html
2981
2982         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
2983         classes with constructors.  It is an non-enumeratable, non-deletable,
2984         readonly attribute.
2985
2986 2007-06-26  George Staikos  <staikos@kde.org>
2987
2988         Repair the OS X build.
2989
2990         * WebCore.exp:
2991
2992 2007-06-26  Adam Treat  <adam@staikos.net>
2993
2994         Reviewed by Adam Roben.
2995
2996         Make the SQLite icon database optional.
2997
2998         * loader/icon/IconDatabase.cpp:
2999         (WebCore::IconDatabase::isOpen):
3000         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
3001         (WebCore::IconDatabase::enabled):
3002         * loader/icon/IconDatabase.h:
3003
3004 2007-06-25  Sam Weinig  <sam@webkit.org>
3005
3006         Reviewed by Adam Roben.
3007
3008         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
3009         HTML syntax highlighting colors and DOM tree colors should be the same
3010
3011         * css/view-source.css:
3012         * page/inspector/ResourcePanel.js:
3013         * page/inspector/inspector.css:
3014         * page/inspector/inspector.js:
3015         * page/inspector/utilities.js:
3016
3017 2007-06-25  Adam Roben  <aroben@apple.com>
3018
3019         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
3020         http://bugs.webkit.org/show_bug.cgi?id=14402
3021
3022         The solution was to make KURL::lastPathComponent ignore trailing
3023         slashes, which is what -[NSURL lastPathComponent] does, too.
3024
3025         Reviewed by Oliver.
3026
3027         * platform/KURL.cpp:
3028         (WebCore::KURL::lastPathComponent):
3029
3030 2007-06-25  Sam Weinig  <sam@webkit.org>
3031
3032         Reviewed by Adam Roben.
3033
3034         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
3035         Web Inspector lists favicon.ico as "other" instead of "image"
3036
3037         * page/InspectorController.cpp:
3038         (WebCore::InspectorResource::type):
3039
3040 2007-06-25  Adele Peterson  <adele@apple.com>
3041
3042         Reviewed by Hyatt.
3043
3044         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
3045         http://bugs.webkit.org/show_bug.cgi?id=14297
3046
3047         Test: fast/overflow/hidden-scrollbar-resize.html
3048
3049         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
3050         Updated our shouldPaint check to consider visibility.
3051
3052 2007-06-25  Oliver Hunt  <oliver@apple.com>
3053
3054         Reviewed by Darin.
3055
3056         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
3057
3058         Fixing logic error in DragController
3059
3060         * manual-tests/drop-text-acquires-style.html: Added.
3061         * page/DragController.cpp:
3062         (WebCore::documentFragmentFromDragData):
3063
3064 2007-06-25  Sam Weinig  <sam@webkit.org>
3065
3066         Reviewed by Adam Roben.
3067
3068         Annotate prototypes by adding "Prototype" subtitle.
3069
3070         * page/inspector/ResourcePanel.js:
3071
3072 2007-06-25  George Staikos  <staikos@kde.org>
3073
3074         Reviewed by Zack.
3075
3076         Start to add proxy and SSL support to WebKitQt.  Proxying works.
3077
3078         * platform/network/ResourceHandleInternal.h:
3079         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
3080         * platform/network/qt/ResourceHandleQt.cpp:
3081         (WebCore::ResourceHandle::start):
3082
3083 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
3084
3085         Reviewed by Adam Roben.
3086
3087         http://bugs.webkit.org/show_bug.cgi?id=14386
3088         Gdk build fix
3089
3090         * WebCore.pro: Fix gtk/gdk typo.
3091
3092 2007-06-25  Timothy Hatcher  <timothy@apple.com>
3093
3094         Reviewed by Anders.
3095
3096         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
3097         http://bugs.webkit.org/show_bug.cgi?id=14385
3098
3099         Add a toggle to show implict computed properties.
3100
3101         * page/inspector/ResourcePanel.js:
3102         * page/inspector/inspector.css:
3103         * page/inspector/inspector.js:
3104
3105 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
3106
3107         Reviewed by Mark.
3108
3109         http://bugs.webkit.org/show_bug.cgi?id=13975
3110         Use system-provided libjpeg and libpng
3111
3112         * WebCore.pro: Remove bundled libjpeg and libpng sources.
3113         * platform/image-decoders/jpeg: Remove sources.
3114         * platform/image-decoders/png: Remove sources.
3115
3116 2007-06-25  Mitz Pettel  <mitz@webkit.org>
3117
3118         Reviewed by Darin.
3119
3120         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
3121           Table caption renders too narrow sometimes
3122
3123         Test: fast/table/caption-relayout.html
3124
3125         * rendering/RenderTable.cpp:
3126         (WebCore::RenderTable::layout): Mark the caption for layout if the table
3127         width changed.
3128
3129 2007-06-25  Mitz Pettel  <mitz@webkit.org>
3130
3131         Reviewed by Darin.
3132
3133         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
3134           Underline painted under <br>, not repainted properly
3135
3136         Test: fast/inline/br-text-decoration.html
3137
3138         * platform/graphics/cg/GraphicsContextCG.cpp:
3139         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
3140         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
3141         than their thickness paint correctly.
3142
3143 2007-06-25  Mitz Pettel  <mitz@webkit.org>
3144
3145         Reviewed by Maciej.
3146
3147         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
3148           rules="none" ignored in certain cases
3149
3150         Covered by existing tests.
3151
3152         * html/HTMLTableElement.cpp:
3153         (WebCore::HTMLTableElement::getSharedCellDecl):
3154
3155 2007-06-24  Sam Weinig  <sam@webkit.org>
3156
3157         Reviewed by Mitz.
3158
3159         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
3160         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
3161
3162         * page/inspector/ResourcePanel.js: make sure not to call an overriden
3163         toString() by using Object.prototype.toString.call().
3164
3165 2007-06-24  Adam Roben  <aroben@apple.com>
3166
3167         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
3168         Bug 14374: Computed Style section should be expanded by default
3169
3170         Reviewed by Sam.
3171
3172         No regression test possible.
3173
3174         * page/inspector/ResourcePanel.js: Expand all style sections.
3175
3176 2007-06-24  Adam Roben  <aroben@apple.com>
3177
3178         Unify the style of enums in the Inspector JS
3179
3180         All our enums are now represented by an object with a property for
3181         each enum value.
3182
3183         Reviewed by Sam.
3184
3185         No regression test possible.
3186
3187         * page/inspector/ConsolePanel.js:
3188         * page/inspector/Resource.js:
3189         * page/inspector/ResourcePanel.js:
3190         * page/inspector/inspector.js:
3191
3192 2007-06-23  Sam Weinig  <sam@webkit.org>
3193
3194         Reviewed by Mitz.
3195
3196         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
3197         getComputedStyle(...).zIndex returns string "normal"
3198
3199         Test: fast/css/getComputedStyle-zIndex-auto.html
3200
3201         * css/CSSComputedStyleDeclaration.cpp:
3202         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
3203
3204 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
3205
3206         Reviewed by Tim Hatcher.
3207
3208         Bug 14265: Cannot resize columns in webinspector
3209         http://bugs.webkit.org/show_bug.cgi?id=14265
3210
3211         * page/inspector/inspector.css:
3212         * page/inspector/inspector.html:
3213         * page/inspector/inspector.js:
3214
3215 2007-06-23  Adam Roben  <aroben@apple.com>
3216
3217         Silence a build warning about not finding `num-cpus`
3218
3219         Reviewed by Mark Rowe.
3220
3221         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
3222         location.
3223
3224 2007-06-22  Anders Carlsson  <andersca@apple.com>
3225
3226         Reviewed by Darin.
3227
3228         * plugins/win/PluginStreamWin.cpp:
3229         (WebCore::PluginStreamWin::didFinishLoading):
3230         No need to fetch the size from resourceData.
3231
3232 2007-06-22  Anders Carlsson  <andersca@apple.com>
3233
3234         Reviewed by Darin.
3235
3236         <rdar://problem/5288617>
3237         Crash playing a very large QuickTime movie inside Safari.
3238
3239         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
3240         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
3241         
3242         * plugins/win/PluginStreamWin.cpp:
3243         (WebCore::PluginStreamWin::PluginStreamWin):
3244         (WebCore::PluginStreamWin::~PluginStreamWin):
3245         (WebCore::PluginStreamWin::didReceiveData):
3246         (WebCore::PluginStreamWin::didFinishLoading):
3247         * plugins/win/PluginStreamWin.h:
3248
3249 2007-06-22  Beth Dakin  <bdakin@apple.com>
3250
3251         Reviewed by Oliver and Darin.
3252
3253         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
3254         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
3255
3256         We already have code that tries to prevent allocating too-large 
3257         rowspans. The rowspan in this test, however, was small enough that 
3258         we thought it was okay in that code, even though clearly it was 
3259         still too large. I did a bunch of testing in Firefox, and it seems 
3260         that they set a hard limit on the maximum rowspan right in the DOM 
3261         -- 8k. So that is what this patch implements. 
3262
3263         * html/HTMLTableCellElement.cpp:
3264         (WebCore::HTMLTableCellElement::parseMappedAttribute):
3265
3266 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
3267
3268         Reviewed by Darin.
3269         
3270         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
3271         
3272         Deletion inserts a placeholder after it removes full paragraphs if
3273         one doesn't already exist.  The code that looked for a pre-existing
3274         placeholder didn't work because of a bug in enclosingNodeOfType.
3275
3276         * editing/htmlediting.cpp:
3277         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
3278         but don't go above an editing root.
3279
3280 2007-06-22  Anders Carlsson  <andersca@apple.com>
3281
3282         Reviewed by Maciej and Geoff.
3283
3284         <rdar://problem/5244734>
3285         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
3286         
3287         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
3288         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
3289         argument to a bunch of classes).
3290         
3291         * loader/Cache.cpp:
3292         (WebCore::createResource):
3293         (WebCore::Cache::requestResource):
3294         * loader/Cache.h:
3295         * loader/CachedCSSStyleSheet.cpp:
3296         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
3297         * loader/CachedCSSStyleSheet.h:
3298         * loader/CachedResource.cpp:
3299         (WebCore::CachedResource::CachedResource):
3300         * loader/CachedResource.h:
3301         (WebCore::CachedResource::sendResourceLoadCallbacks):
3302         * loader/DocLoader.cpp:
3303         (WebCore::DocLoader::requestCSSStyleSheet):
3304         (WebCore::DocLoader::requestResource):
3305         (WebCore::DocLoader::checkCacheObjectStatus):
3306         * loader/DocLoader.h:
3307         * loader/MainResourceLoader.cpp:
3308         (WebCore::MainResourceLoader::MainResourceLoader):
3309         * loader/Request.cpp:
3310         (WebCore::Request::Request):
3311         * loader/Request.h:
3312         (WebCore::Request::sendResourceLoadCallbacks):
3313         * loader/ResourceLoader.cpp:
3314         (WebCore::ResourceLoader::ResourceLoader):
3315         (WebCore::ResourceLoader::willSendRequest):
3316         (WebCore::ResourceLoader::didReceiveResponse):
3317         (WebCore::ResourceLoader::didReceiveData):
3318         (WebCore::ResourceLoader::didFinishLoadingOnePart):
3319         (WebCore::ResourceLoader::didFail):
3320         (WebCore::ResourceLoader::didCancel):
3321         * loader/ResourceLoader.h:
3322         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
3323         * loader/SubresourceLoader.cpp:
3324         (WebCore::SubresourceLoader::SubresourceLoader):
3325         (WebCore::SubresourceLoader::create):
3326         * loader/SubresourceLoader.h:
3327         * loader/loader.cpp:
3328         (WebCore::Loader::load):
3329         (WebCore::Loader::servePendingRequests):
3330         * loader/loader.h:
3331         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
3332         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
3333
3334 2007-06-21  Richard Connamacher  <rich@indieimage.com>
3335
3336         Reviewed by Tim Hatcher.
3337
3338         Bug 14305: Web Inspector marks local files with server-side compression tip
3339         http://bugs.webkit.org/show_bug.cgi?id=14305
3340
3341         * page/inspector/Resource.js:
3342         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
3343         from being given to local files
3344
3345 2007-06-21  Mark Rowe  <mrowe@apple.com>
3346
3347         Reviewed by Darin.
3348
3349         Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
3350
3351         * platform/StringImpl.cpp:
3352         (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
3353         a length of zero when the string is collapsed to empty by whitespace simplification.
3354
3355 2007-06-21  Dave Hyatt  <hyatt@apple.com>
3356
3357         Fix for <rdar://problem/5286978>, large font sizes crash Windows.
3358         
3359         Limit the maximum font size to 1,000,000 to avoid crashes and issues with platforms that
3360         start failing to do anything useful if the font size is too big.
3361         
3362         Reviewed by olliej
3363
3364         * css/cssstyleselector.cpp:
3365         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
3366         
3367 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
3368
3369         Reviewed by Timothy.
3370
3371         Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
3372
3373         * page/inspector/inspector.css: Set body margin to 0
3374
3375 2007-06-21  Adam Treat  <adam@staikos.net>
3376
3377         Reviewed by George Staikos.
3378
3379         Implement the default resources on Qt.
3380
3381         * platform/graphics/BitmapImage.h:
3382         * platform/graphics/Image.h:
3383         * platform/graphics/qt/ImageQt.cpp:
3384         (WebCore::Image::loadPlatformResource):
3385         (WebCore::BitmapImage::BitmapImage):
3386         (WebCore::BitmapImage::initPlatformData):
3387         (WebCore::BitmapImage::invalidatePlatformData):
3388         (WebCore::BitmapImage::getPixmap):
3389         * platform/qt/TemporaryLinkStubs.cpp:
3390
3391 2007-06-21  Oliver Hunt  <oliver@apple.com>
3392
3393         Reviewed by Darin.
3394
3395         Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
3396         and makes reference handling simpler in advance of IME refactoring.
3397
3398         * WebCore.xcodeproj/project.pbxproj:
3399         * page/mac/EventHandlerMac.mm:
3400         (WebCore::currentEvent):
3401         (WebCore::EventHandler::currentNSEvent):
3402         (WebCore::EventHandler::wheelEvent):
3403         (WebCore::EventHandler::keyEvent):
3404         (WebCore::lastEventIsMouseUp):
3405         (WebCore::EventHandler::passMouseDownEventToWidget):
3406         (WebCore::EventHandler::eventLoopHandleMouseDragged):
3407         (WebCore::EventHandler::eventLoopHandleMouseUp):
3408         (WebCore::EventHandler::passSubframeEventToSubframe):
3409         (WebCore::EventHandler::passWheelEventToWidget):
3410         (WebCore::EventHandler::mouseDown):
3411         (WebCore::EventHandler::mouseDragged):
3412         (WebCore::EventHandler::mouseUp):
3413         (WebCore::EventHandler::mouseMoved):
3414
3415 2007-06-21  George Staikos  <staikos@kde.org>
3416
3417         Reviewed by George & Marius.
3418
3419         Patch by me, revision by Marius, minor rev by me.  Adds rendered
3420         and stylable scrollbars.
3421
3422         * page/qt/EventHandlerQt.cpp:
3423         (WebCore::EventHandler::passMousePressEventToScrollbar):
3424         * platform/Widget.h:
3425         * platform/qt/PlatformScrollBar.h:
3426         (WebCore::PlatformScrollbar::isWidget):
3427         * platform/qt/PlatformScrollBarQt.cpp:
3428         (WebCore::PlatformScrollbar::PlatformScrollbar):
3429         (WebCore::PlatformScrollbar::~PlatformScrollbar):
3430         (WebCore::PlatformScrollbar::updateThumbPosition):
3431         (WebCore::PlatformScrollbar::updateThumbProportion):
3432         (WebCore::PlatformScrollbar::width):
3433         (WebCore::PlatformScrollbar::height):
3434         (WebCore::PlatformScrollbar::setRect):
3435         (WebCore::PlatformScrollbar::isEnabled):
3436         (WebCore::PlatformScrollbar::setEnabled):
3437         (WebCore::PlatformScrollbar::paint):
3438         (WebCore::PlatformScrollbar::thumbPosition):
3439         (WebCore::PlatformScrollbar::thumbLength):
3440         (WebCore::PlatformScrollbar::trackLength):
3441         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
3442         (WebCore::PlatformScrollbar::handleMouseOutEvent):
3443         (WebCore::PlatformScrollbar::handleMousePressEvent):
3444         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
3445         (WebCore::PlatformScrollbar::startTimerIfNeeded):
3446         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
3447         (WebCore::PlatformScrollbar::autoscrollPressedPart):
3448         (WebCore::PlatformScrollbar::autoscrollTimerFired):
3449         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
3450         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
3451         (WebCore::PlatformScrollbar::thumbUnderMouse):
3452         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
3453         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
3454         (WebCore::PlatformScrollbar::windowClipRect):
3455         * platform/qt/ScrollViewQt.cpp:
3456         (WebCore::ScrollView::addChild):
3457         (WebCore::ScrollView::removeChild):
3458         * platform/qt/WidgetQt.cpp:
3459         (WebCore::WidgetPrivate::WidgetPrivate):
3460         (WebCore::Widget::setQWidget):
3461         (WebCore::Widget::invalidate):
3462         (WebCore::Widget::invalidateRect):
3463         (WebCore::Widget::setParent):
3464         (WebCore::Widget::parent):
3465
3466 2007-06-21  Geoffrey Garen  <ggaren@apple.com>
3467
3468         Reviewed by Dave Hyatt.
3469         
3470         Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
3471         REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML 
3472         effects when clicking on its links (12646)
3473         
3474         I'm rolling our r7703 for these reasons:
3475
3476         1. It broke RapidWeaver.
3477         
3478         2. WebKit is now orders of magnitude faster when handling deep nesting
3479         (5 seconds vs 3 minutes on my MBP in this particular case).
3480
3481         3. Firefox, IE, and HTML5 all allow nested heading tags.
3482         
3483         4. Hyatt said so.
3484
3485         * html/HTMLParser.cpp:
3486         (WebCore::HTMLParser::parseToken):
3487
3488 2007-06-21  Sam Weinig  <sam@webkit.org>
3489
3490         Reviewed by Tim Hatcher.
3491
3492         http://bugs.webkit.org/show_bug.cgi?id=14260
3493         ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page
3494
3495         Remove assert for now as it is causing the back button to not
3496         work in debug builds.
3497
3498         * page/InspectorController.cpp:
3499         (WebCore::InspectorController::didCommitLoad):
3500
3501 2007-06-21  Lars Knoll <lars@trolltech.com>
3502
3503         Remove some debug output.
3504
3505         * platform/qt/FontQt.cpp:
3506         (WebCore::generateComponents):
3507         (WebCore::Font::width):
3508
3509 2007-06-21  George Staikos  <staikos@kde.org>
3510
3511         Repair Qt/Mac OS X build.
3512
3513         * WebCore.pro:
3514
3515 2007-06-21  Alexey Proskuryakov  <ap@webkit.org>
3516
3517         Reviewed by Anders.
3518
3519         http://bugs.webkit.org/show_bug.cgi?id=13905
3520         REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
3521
3522         Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
3523         (regardless of the actual response MIME type). This was corrected a while ago to match other 
3524         browsers and the draft XHR spec.
3525
3526         Now restoring this functionality for "text/html", with spec editor's blessing.
3527
3528         * xml/xmlhttprequest.cpp:
3529         (WebCore::XMLHttpRequest::responseMIMEType):
3530         (WebCore::XMLHttpRequest::responseIsXML):
3531         (WebCore::XMLHttpRequest::didReceiveData):
3532         * xml/xmlhttprequest.h:
3533
3534 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
3535
3536         Mac build fix.
3537
3538         * platform/Font.h:
3539
3540 2007-06-21  Lars Knoll  <lars@trolltech.com>
3541
3542         Reviewed by Simon.
3543
3544         another small fix for letter spacing
3545
3546         * platform/qt/FontQt.cpp:
3547         (WebCore::generateComponents):
3548
3549 2007-06-21  Lars Knoll  <lars@trolltech.com>
3550
3551         Reviewed by Simon.
3552
3553         fix word-spacing
3554
3555         * platform/qt/FontQt.cpp:
3556         (WebCore::generateComponents):
3557         (WebCore::Font::width):
3558
3559 2007-06-21  Lars Knoll  <lars@trolltech.com>
3560
3561         Reviewed by Simon.
3562
3563         fix letterspacing and small caps.
3564
3565         * platform/Font.h:
3566         * platform/graphics/qt/GraphicsContextQt.cpp:
3567         (WebCore::GraphicsContext::setPlatformFont):
3568         * platform/qt/FileChooserQt.cpp:
3569         * platform/qt/FontQt.cpp:
3570         (WebCore::TextRunComponent::TextRunComponent):
3571         (WebCore::Font::Font):
3572         (WebCore::Font::operator=):
3573         (WebCore::Font::update):
3574         (WebCore::generateComponents):
3575         (WebCore::Font::selectionRectForText):
3576         * platform/qt/RenderThemeQt.cpp:
3577
3578 2007-06-21  Lars Knoll  <lars@trolltech.com>
3579
3580         Reviewed by Simon.
3581
3582         store the metrics and space width in the Font object
3583
3584         * platform/Font.h:
3585         * platform/qt/FontQt.cpp:
3586         (WebCore::Font::Font):
3587         (WebCore::Font::drawText):
3588         (WebCore::Font::width):
3589         (WebCore::Font::isFixedPitch):
3590         (WebCore::Font::ascent):
3591         (WebCore::Font::descent):
3592         (WebCore::Font::lineSpacing):
3593
3594 2007-06-21  Lars Knoll  <lars@trolltech.com>
3595
3596         Reviewed by Simon.
3597
3598         simplify some codepaths
3599
3600         * platform/qt/FontQt.cpp:
3601         (WebCore::Font::drawText):
3602         (WebCore::Font::width):
3603
3604 2007-06-21  Lars Knoll  <lars@trolltech.com>
3605
3606         Reviewed by Simon.
3607
3608         fix copyright header
3609
3610         * platform/qt/FontQt.cpp:
3611
3612 2007-06-21  Lars Knoll  <lars@trolltech.com>
3613
3614         Reviewed by Simon.
3615
3616         correctly load fonts when a list of font families is given
3617
3618         * platform/qt/FontQt.cpp:
3619         (WebCore::Font::Font):
3620
3621 2007-06-21  Lars Knoll  <lars@trolltech.com>
3622
3623         Reviewed by Simon.
3624
3625         fix some more of the font support
3626
3627         * platform/qt/FontQt.cpp:
3628         (WebCore::Font::drawText):
3629         (WebCore::Font::width):
3630
3631 2007-06-21  Lars Knoll  <lars@trolltech.com>
3632
3633         Reviewed by Simon.
3634
3635         Compile fixes
3636
3637         * platform/Font.h:
3638         (WebCore::Font::isRoundingHackCharacter):
3639         * platform/qt/FontQt.cpp:
3640         (WebCore::Font::drawText):
3641
3642 2007-06-21  Lars Knoll  <lars@trolltech.com>
3643
3644         Reviewed by Simon.
3645
3646         Some more work on the implementation of FontQt.
3647
3648         * platform/qt/FontQt.cpp:
3649         (WebCore::Font::Font):
3650         (WebCore::Font::~Font):
3651         (WebCore::Font::operator=):
3652
3653 2007-06-21  Lars Knoll  <lars@trolltech.com>
3654
3655         Reviewed by Simon.
3656
3657         Started work on the new font infrastructure for the Qt port.
3658
3659         * WebCore.pro:
3660         * editing/Editor.cpp:
3661         (WebCore::Editor::fontForSelection):
3662         * platform/Font.h:
3663         (WebCore::Font::treatAsSpace):
3664         (WebCore::Font::treatAsZeroWidthSpace):
3665         (WebCore::Font::isRoundingHackCharacter):
3666         * platform/qt/FontQt.cpp:
3667         (WebCore::Font::operator QFont):
3668         * platform/qt/TemporaryLinkStubs.cpp:
3669
3670 2007-06-21  Adam Roben  <aroben@apple.com>
3671
3672         More Gdk build fixes.
3673
3674         * page/gdk/ContextMenuClientGdk.cpp:
3675         (WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
3676         * page/gdk/ContextMenuClientGdk.h:
3677         * platform/gdk/TemporaryLinkStubs.cpp:
3678
3679 2007-06-21  Adam Roben  <aroben@apple.com>
3680
3681         Speculative Gdk build fix.
3682
3683         * page/InspectorController.h: Only include the JS headers we really
3684         need to avoid pulling in ones like JSStringRefCF.h.
3685
3686 2007-06-20  Adam Roben  <aroben@apple.com>
3687
3688         Speculative Gdk build fix.
3689
3690         * WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
3691
3692 2007-06-20  Adam Roben  <aroben@apple.com>
3693
3694         Windows build fix.
3695
3696         * WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
3697         everything but $WebKitLibrariesDir so that we will pick up
3698         JavaScriptCore headers directly.
3699
3700 2007-06-15  George Staikos  <staikos@kde.org>
3701
3702         Add missing symbol.
3703
3704         * platform/qt/TemporaryLinkStubs.cpp:
3705         (WebCore::contextMenuItemTagInspectElement):
3706
3707 2007-06-20  Steve Falkenburg  <sfalken@apple.com>
3708
3709         Reviewed by Maciej, Anders.
3710         
3711         <rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/
3712
3713         Keep a reference to the Page (via the main frame) for the
3714         load deferred pages.
3715         
3716         Reference is held via the frame since Page isn't refcounted.
3717
3718         * page/Chrome.cpp:
3719         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
3720         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
3721
3722 2007-06-15  Adam Treat <adam@staikos.net>
3723
3724         Reviewed by George Staikos.
3725
3726         Add ICO support to the Qt build.
3727
3728         * WebCore.pro:
3729         * platform/graphics/qt/ImageDecoderQt.cpp:
3730         (Q_IMPORT_PLUGIN):
3731
3732 2007-06-15  George Staikos  <staikos@kde.org>
3733
3734         Fixing Qt build.
3735
3736         * ForwardingHeaders/JavaScriptCore/APICast.h: Added.
3737         * WebCore.pro:
3738         * page/InspectorController.h:
3739
3740 2007-06-20  Adam Roben  <aroben@apple.com>
3741
3742         More speculative Qt/Gdk build fixes.
3743
3744         * WebCore.pro: Add new files.
3745
3746 2007-06-20  Adam Roben  <aroben@apple.com>
3747
3748         Speculative Qt/Gdk build fix.
3749
3750         Added forwarding headers for JavaScriptCore. We may eventually move
3751         InspectorController off of the JSC API, but for now this is the
3752         quickest way to a working build.
3753
3754         * ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
3755         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
3756         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
3757         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
3758         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
3759         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
3760         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
3761
3762 2007-06-20  Sam Weinig  <sam@webkit.org>
3763
3764         Rubber stamped by Adam Roben.
3765
3766         Add licenses.
3767
3768         * page/inspector/ConsolePanel.js:
3769         * page/inspector/NetworkPanel.js:
3770         * page/inspector/Resource.js:
3771         * page/inspector/ResourceCategory.js:
3772         * page/inspector/ResourcePanel.js:
3773
3774 2007-06-20  Mark Rowe  <mrowe@apple.com>
3775
3776         Reviewed by Adam.
3777
3778         * WebCore.exp: Export InspectorController::inspect so WebKit can see it.
3779
3780 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
3781
3782         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
3783
3784         Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
3785         Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
3786         returning nil instead of "")
3787
3788         I'm basically rolling out the change for <rdar://problem/4782422> because
3789         my testing shows that it was backwards.
3790         
3791         * html/HTMLElement.cpp:
3792         (dumpInnerHTML): New debug-only function to work around gdb being 
3793         perpetually suck-tastic.
3794
3795         * page/mac/WebCoreFrameBridge.mm:
3796         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
3797         
3798         Return "", not nil. This function never used to return nil, so let's not
3799         start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
3800
3801 2007-06-20  Adam Roben  <aroben@apple.com>
3802
3803         Addressed some of Geoff's comments.
3804
3805         * page/ContextMenuController.cpp:
3806         (WebCore::ContextMenuController::handleContextMenuEvent): Added a
3807         FIXME.
3808         * platform/ContextMenu.cpp:
3809         (WebCore::ContextMenu::addInspectElementItem): Null-check
3810         frame->page().
3811
3812 2007-06-20  Adam Roben  <aroben@apple.com>
3813
3814         Fix crash in fast/dom/dir-no-body.html
3815
3816         Reviewed by Mark.
3817
3818         * html/HTMLDocument.cpp:
3819         (WebCore::HTMLDocument::createTokenizer): Don't assume we have a
3820         Frame, since we won't if someone creates an HTMLDocument from JS.
3821
3822 2007-06-20  Adam Roben  <aroben@apple.com>
3823
3824         Land the new Inspector.
3825
3826         Co-written with Tim Hatcher.
3827
3828         Reviewed by Anders, Adele, Hyatt, and Sam.
3829
3830         No regression tests possible.
3831
3832         Add a new InspectorController that is in charge of the Inspector. It
3833         has an InspectorClient that controls the Inspector's window and node
3834         highlight.
3835
3836         * page/InspectorClient.h: Added.
3837         (WebCore::InspectorClient::~InspectorClient):
3838         * page/InspectorController.cpp: Added.
3839         (WebCore::ConsoleMessage::ConsoleMessage):
3840         (WebCore::InspectorResource::): Represents a single resource that the
3841         Inspector knows about.
3842         (WebCore::InspectorResource::InspectorResource):
3843         (WebCore::InspectorResource::~InspectorResource):
3844         (WebCore::InspectorResource::type):
3845         (WebCore::InspectorResource::setScriptObject):
3846         (WebCore::addSourceToFrame): Callback available from JS.
3847         (WebCore::getResourceDocumentNode): Ditto.
3848         (WebCore::highlightDOMNode): Ditto.
3849         (WebCore::hideDOMNodeHighlight): Ditto.
3850         (WebCore::loaded): Ditto.
3851         (WebCore::unloading): Ditto.
3852         (WebCore::attach): Ditto.
3853         (WebCore::detach): Ditto.
3854         (WebCore::log): Ditto.
3855         (WebCore::search): Ditto.
3856         (WebCore::inspectedWindow): Ditto.
3857         (WebCore::InspectorController::InspectorController):
3858         (WebCore::InspectorController::~InspectorController):
3859         (WebCore::InspectorController::inspect): Called by
3860         ContextMenuController to inspect a node.
3861         (WebCore::InspectorController::focusNode):
3862         (WebCore::InspectorController::highlight):
3863         (WebCore::InspectorController::hideHighlight):
3864         (WebCore::InspectorController::windowVisible):
3865         (WebCore::InspectorController::setWindowVisible):
3866         (WebCore::InspectorController::addMessageToConsole):
3867         (WebCore::InspectorController::attachWindow):
3868         (WebCore::InspectorController::detachWindow):
3869         (WebCore::InspectorController::windowScriptObjectAvailable):
3870         (WebCore::InspectorController::scriptObjectReady):
3871         (WebCore::InspectorController::windowUnloading):
3872         (WebCore::addHeaders): Static helper function.
3873         (WebCore::objectForRequest): Ditto.
3874         (WebCore::objectForResponse): Ditto.
3875         (WebCore::InspectorController::addScriptResource):
3876         (WebCore::InspectorController::addAndUpdateScriptResource):
3877         (WebCore::InspectorController::removeScriptResource):
3878         (WebCore::InspectorController::updateScriptResource):
3879         (WebCore::InspectorController::populateScriptResources):
3880         (WebCore::InspectorController::addScriptConsoleMessage):
3881         (WebCore::callClearFunction): Static helper function.
3882         (WebCore::InspectorController::clearScriptResources):
3883         (WebCore::InspectorController::clearScriptConsoleMessages):
3884         (WebCore::InspectorController::clearNetworkTimeline):
3885         (WebCore::InspectorController::pruneResources):
3886         (WebCore::InspectorController::didCommitLoad): Callback from
3887         FrameLoader.
3888         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
3889         (WebCore::InspectorController::addResource): Ditto.
3890         (WebCore::InspectorController::removeResource): Ditto.
3891         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
3892         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
3893         (WebCore::InspectorController::willSendRequest): Ditto.
3894         (WebCore::InspectorController::didReceiveResponse): Ditto.
3895         (WebCore::InspectorController::didReceiveContentLength): Ditto.
3896         (WebCore::InspectorController::didFinishLoading): Ditto.
3897         (WebCore::InspectorController::didFailLoading): Ditto.
3898         * page/InspectorController.h: Added.
3899         (WebCore::InspectorController::inspectedPage):
3900         (WebCore::InspectorController::scriptContext):
3901         (WebCore::InspectorController::setScriptContext):
3902         (WebCore::InspectorController::resources):
3903         (WebCore::InspectorController::removeAllResources):
3904
3905         Add the JavaScript that defines most of the behavior of the Inspector.
3906         
3907         * page/inspector/ConsolePanel.js: Added.
3908         * page/inspector/NetworkPanel.js: Added.
3909         * page/inspector/Resource.js: Added.
3910         * page/inspector/ResourceCategory.js: Added.
3911         * page/inspector/ResourcePanel.js: Added.
3912         * page/inspector/inspector.js: Added.
3913         * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
3914         * page/inspector/utilities.js: Added.
3915
3916         Add the Inspector's CSS and HTML.
3917
3918         * page/inspector/inspector.css: Added.
3919         * page/inspector/inspector.html: Added.
3920
3921         Hang the InspectorController off of Page. We only create an
3922         InspectorController if an InspectorClient is given to the Page.
3923
3924         * page/Page.cpp:
3925         (WebCore::Page::Page):
3926         * page/Page.h:
3927         (WebCore::Page::inspectorController):
3928
3929         Use FrameLoader to notify the InspectorController of resource loads.
3930
3931         * loader/FrameLoader.cpp:
3932         (WebCore::FrameLoader::begin):
3933         (WebCore::FrameLoader::transitionToCommitted):
3934         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
3935         (WebCore::FrameLoader::detachFromParent):
3936         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
3937         (WebCore::FrameLoader::willSendRequest):
3938         (WebCore::FrameLoader::didReceiveResponse):
3939         (WebCore::FrameLoader::didReceiveData):
3940         (WebCore::FrameLoader::sendRemainingDelegateMessages):
3941         (WebCore::FrameLoader::requestFromDelegate):
3942         (WebCore::FrameLoader::didFinishLoad):
3943         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
3944         (WebCore::FrameLoader::dispatchDidCommitLoad):
3945         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
3946         (WebCore::FrameLoader::dispatchWillSendRequest):
3947         (WebCore::FrameLoader::dispatchDidReceiveResponse):
3948         (WebCore::FrameLoader::dispatchDidReceiveContentLength):
3949         (WebCore::FrameLoader::dispatchDidFinishLoading):
3950         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
3951         * loader/FrameLoader.h:
3952
3953         Send console messages to the InspectorController.
3954
3955         * page/Chrome.cpp:
3956         (WebCore::Chrome::addMessageToConsole): Send all console messages to
3957         the InspectorController.
3958         * page/Chrome.h: Add a new MessageLevel and MessageSource that are
3959         used in the Inspector JS.
3960
3961         Report HTML errors when the Inspector window is open.
3962         We don't report errors when the window is closed because we don't want
3963         to slow down the HTMLTokenizer.
3964
3965         * html/HTMLDocument.cpp:
3966         (WebCore::HTMLDocument::createTokenizer):
3967         * html/HTMLParser.cpp:
3968         (WebCore::HTMLParser::HTMLParser):
3969         * html/HTMLParser.h:
3970         * html/HTMLTokenizer.cpp:
3971         (WebCore::HTMLTokenizer::HTMLTokenizer):
3972         * html/HTMLTokenizer.h:
3973
3974         Append the "Inspect Element" context menu item after passing the
3975         context menu to the ContextMenuClient. This work used to be done in
3976         WebKit.
3977
3978         * page/ContextMenuClient.h:
3979         * page/ContextMenuController.cpp:
3980         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
3981         "Inspect Element" item.
3982         (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
3983         "Inspect Element" item.
3984         * platform/ContextMenu.cpp:
3985         (WebCore::ContextMenu::addInspectElementItem):
3986         (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
3987         Element" item.
3988         * platform/ContextMenu.h:
3989         * platform/ContextMenuItem.h:
3990         (WebCore::): Add ContextMenuItemTagInspectElement.
3991         * platform/graphics/svg/SVGImageEmptyClients.h:
3992         * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
3993         string.
3994         * platform/LocalizedStrings.h: Ditto.
3995         * platform/mac/LocalizedStringsMac.mm:
3996         (WebCore::contextMenuItemTagInspectElement): Ditto.
3997
3998         Miscellaneous changes:
3999
4000         * css/view-source.css: Add message bubble styles.
4001         * loader/DocumentLoader.h: Add a frame getter.
4002         * platform/win/ScrollViewWin.cpp:
4003         (WebCore::ScrollView::updateScrollbars): Respect
4004         Frame::prohibitsScrolling.
4005
4006         Add new images needed for the Inspector.
4007
4008         * page/inspector/Images/attachedShadow.png: Added.
4009         * page/inspector/Images/bottomShadow.png: Added.
4010         * page/inspector/Images/breadcrumbBackground.png: Added.
4011         * page/inspector/Images/checker.png: Added.
4012         * page/inspector/Images/console.png: Added.
4013         * page/inspector/Images/darkShadow.png: Added.
4014         * page/inspector/Images/disclosureDownPressed.png: Added.
4015         * page/inspector/Images/disclosureRightDown.png: Added.
4016         * page/inspector/Images/disclosureRightPressed.png: Added.
4017         * page/inspector/Images/document.png: Added.
4018         * page/inspector/Images/domViewButton.png: Added.
4019         * page/inspector/Images/domViewButtonSelected.png: Added.
4020         * page/inspector/Images/downTriangle.png: Added.
4021         * page/inspector/Images/errorIcon.png: Added.
4022         * page/inspector/Images/errorMediumIcon.png: Added.
4023         * page/inspector/Images/folder.png: Added.
4024         * page/inspector/Images/goArrow.png: Added.
4025         * page/inspector/Images/gradient.png: Added.
4026         * page/inspector/Images/gradientHighlight.png: Added.
4027         * page/inspector/Images/gradientHighlightBottom.png: Added.
4028         * page/inspector/Images/hideStatusWidget.png: Added.
4029         * page/inspector/Images/hideStatusWidgetPressed.png: Added.
4030         * page/inspector/Images/network.png: Added.
4031         * page/inspector/Images/paneBottomGrow.png: Added.
4032         * page/inspector/Images/paneBottomGrowActive.png: Added.
4033         * page/inspector/Images/paneGrowHandleLine.png: Added.
4034         * page/inspector/Images/paneHeader.png: Added.
4035         * page/inspector/Images/paneHeaderActive.png: Added.
4036         * page/inspector/Images/plainDocument.png: Added.
4037         * page/inspector/Images/popupArrows.png: Added.
4038         * page/inspector/Images/rightTriangle.png: Added.
4039         * page/inspector/Images/segment.png: Added.
4040         * page/inspector/Images/segmentEnd.png: Added.
4041         * page/inspector/Images/segmentHover.png: Added.
4042         * page/inspector/Images/segmentHoverEnd.png: Added.
4043         * page/inspector/Images/segmentSelected.png: Added.
4044         * page/inspector/Images/segmentSelectedEnd.png: Added.
4045         * page/inspector/Images/showStatusWidget.png: Added.
4046         * page/inspector/Images/showStatusWidgetPressed.png: Added.
4047         * page/inspector/Images/sidbarItemBackground.png: Added.
4048         * page/inspector/Images/sidebarActionWidget.png: Added.
4049         * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
4050         * page/inspector/Images/sidebarAttachWidget.png: Added.
4051         * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
4052         * page/inspector/Images/sidebarDetachWidget.png: Added.
4053         * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
4054         * page/inspector/Images/sidebarResizeWidget.png: Added.
4055         * page/inspector/Images/sidebarSelection.png: Added.
4056         * page/inspector/Images/sidebarSelectionBlurred.png: Added.
4057         * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
4058         * page/inspector/Images/sidebarSelectionGray.png: Added.
4059         * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
4060         * page/inspector/Images/sidebarSelectionTall.png: Added.
4061         * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
4062         * page/inspector/Images/sourceViewButton.png: Added.
4063         * page/inspector/Images/sourceViewButtonSelected.png: Added.
4064         * page/inspector/Images/splitviewDimple.png: Added.
4065         * page/inspector/Images/splitviewDividerBackground.png: Added.
4066         * page/inspector/Images/tab.png: Added.
4067         * page/inspector/Images/tabSelected.png: Added.
4068         * page/inspector/Images/timelinePillBlue.png: Added.
4069         * page/inspector/Images/timelinePillGray.png: Added.
4070         * page/inspector/Images/timelinePillGreen.png: Added.
4071         * page/inspector/Images/timelinePillOrange.png: Added.
4072         * page/inspector/Images/timelinePillPurple.png: Added.
4073         * page/inspector/Images/timelinePillRed.png: Added.
4074         * page/inspector/Images/timelinePillYellow.png: Added.
4075         * page/inspector/Images/tipBalloon.png: Added.
4076         * page/inspector/Images/tipBalloonBottom.png: Added.
4077         * page/inspector/Images/tipIcon.png: Added.
4078         * page/inspector/Images/tipIconPressed.png: Added.
4079         * page/inspector/Images/toggleDown.png: Added.
4080         * page/inspector/Images/toggleUp.png: Added.
4081         * page/inspector/Images/toolbarBackground.png: Added.
4082         * page/inspector/Images/toolbarBackgroundInactive.png: Added.
4083         * page/inspector/Images/toolbarButton.png: Added.
4084         * page/inspector/Images/toolbarButtonInactive.png: Added.
4085         * page/inspector/Images/toolbarButtonPressed.png: Added.
4086         * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
4087         * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
4088         * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
4089         * page/inspector/Images/treeDownTriangleBlack.png: Added.
4090         * page/inspector/Images/treeDownTriangleWhite.png: Added.
4091         * page/inspector/Images/treeLeftTriangleBlack.png: Added.
4092         * page/inspector/Images/treeRightTriangleBlack.png: Added.
4093         * page/inspector/Images/treeRightTriangleWhite.png: Added.
4094         * page/inspector/Images/warningIcon.png: Added.
4095         * page/inspector/Images/warningMediumIcon.png: Added.
4096         * page/inspector/Images/warningsErrors.png: Added.
4097
4098         Build-fu:
4099
4100         * WebCore.exp: Added new symbols.
4101         * WebCore.xcodeproj/project.pbxproj: Added new source files and
4102         resources.
4103         * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
4104         $WebKitOutputDir.
4105
4106         Windows build fixes:
4107
4108         * history/HistoryItem.h: ResourceRequest is a struct.
4109         * loader/FrameLoaderClient.h: Ditto.
4110
4111 2007-06-20  Mitz Pettel  <mitz@webkit.org>
4112
4113         Reviewed by Beth.
4114
4115         - fix http://bugs.webkit.org/show_bug.cgi?id=14056
4116           REGRESSION (r21113-21143): TR background not repainted via style class change
4117
4118         Test: fast/repaint/table-row.html
4119
4120         * rendering/RenderTableRow.cpp:
4121         (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
4122         table row also needs layout, so it doesn't get a repaint in setStyle().
4123
4124 2007-06-20  Mitz Pettel  <mitz@webkit.org>
4125
4126         Reviewed by Adele.
4127
4128         - fix http://bugs.webkit.org/show_bug.cgi?id=14040
4129           Top and bottom border images flipped when using -webkit-border-image when border end up tiled
4130
4131         Test: fast/borders/border-image-01.html
4132
4133         Correctly account for the fact that "pattern space" is flipped.
4134
4135         * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
4136         * platform/graphics/cg/ImageCG.cpp:
4137         (WebCore::Image::drawPatternCallback):
4138         (WebCore::Image::drawPattern):
4139
4140 2007-06-20  Anders Carlsson  <andersca@apple.com>
4141
4142         Reviewed by Darin.
4143
4144         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
4145         
4146         Check for either '\r' or '\n' in the header value.
4147         
4148         * xml/xmlhttprequest.cpp:
4149         (WebCore::isValidHeaderValue):
4150
4151 2007-06-20  Patti Hoa  <patti@apple.com>
4152
4153         Reviewed by Geoffrey Garen.
4154
4155         <rdar://problem/4882527> VO should speak URL of image links that lack tags
4156         Add additional change from review
4157         
4158         * bridge/mac/WebCoreAXObject.mm:
4159         (-[WebCoreAXObject accessibilityAttributeValue:]):
4160         Check if the element has imgTag before asking for its url
4161         
4162 2007-06-20  Patti Hoa  <patti@apple.com>
4163
4164         Reviewed by Tristan O'Tierney.
4165
4166         <rdar://problem/4882527> VO should speak URL of image links that lack tags
4167         
4168         * bridge/mac/WebCoreAXObject.mm:
4169         (-[WebCoreAXObject accessibilityAttributeNames]):
4170         (-[WebCoreAXObject accessibilityAttributeValue:]):
4171         Return the url of images.
4172
4173 2007-06-19  Anders Carlsson  <andersca@apple.com>
4174
4175         Reviewed by Kevin Decker.
4176
4177         <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
4178         
4179         Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
4180         
4181         * loader/DocumentLoader.cpp:
4182         (WebCore::DocumentLoader::DocumentLoader):
4183         * loader/DocumentLoader.h:
4184         (WebCore::DocumentLoader::deferMainResourceDataLoad):
4185         * loader/MainResourceLoader.cpp:
4186         (WebCore::MainResourceLoader::handleDataLoadSoon):
4187         (WebCore::MainResourceLoader::loadNow):
4188         (WebCore::MainResourceLoader::setDefersLoading):
4189
4190 2007-06-19  Patti Hoa <patti@apple.com>
4191
4192         Reviewed by Justin Garcia.
4193         
4194         <rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
4195         
4196         * editing/visible_units.cpp:
4197         (WebCore::startPositionForLine):
4198         (WebCore::startOfLine):
4199         (WebCore::endPositionForLine):
4200         (WebCore::endOfLine):
4201         Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
4202         An example would be when lineStart/lineEnd at different line than the input position.
4203         This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
4204         specifically a line without webkit-line-break:after-white-space style.
4205
4206 2007-06-19  Patti Hoa  <patti@apple.com>
4207
4208         Reviewed by Justin Garcia.
4209         
4210         <rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap
4211         
4212         * bridge/mac/WebCoreAXObject.mm:
4213         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
4214         Improve the accuracy of the bounds for a given range
4215         
4216 2007-06-19  Anders Carlsson  <andersca@apple.com>
4217
4218         Reviewed by Darin.
4219
4220         <rdar://problem/5130630>
4221         XPath fails LayoutTests on Windows
4222         
4223         * xml/XPathPredicate.cpp:
4224         Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
4225         
4226         * xml/XPathValue.cpp:
4227         (WebCore::XPath::Value::toNumber):
4228         Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
4229         
4230 2007-06-19  Geoffrey Garen  <ggaren@apple.com>
4231
4232         Reviewed by Darin Adler.
4233
4234         Fixed cross-frame access. <rdar://problem/5251309>. 
4235
4236         * bindings/js/kjs_window.cpp:
4237         (KJS::Window::getValueProperty):
4238         * bindings/scripts/CodeGeneratorJS.pm:
4239         * page/DOMWindow.idl:
4240
4241 2007-06-19  Anders Carlsson  <andersca@apple.com>
4242
4243         Build fix.
4244         
4245         * platform/win/PopupMenuWin.cpp:
4246
4247 2007-06-19  Lars Knoll <lars@trolltech.com>
4248
4249         Reviewed by Zack
4250
4251         Implement these methods correctly.
4252
4253         * platform/qt/PlatformScreenQt.cpp:
4254         (WebCore::screenRect):
4255         (WebCore::screenAvailableRect):
4256
4257 2007-06-19  Sam Weinig  <sam@webkit.org>
4258
4259         Reviewed by Geoff.
4260
4261         Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
4262         Move the History object out of the JS bindings
4263
4264         - Autogenerate JSHistory.
4265
4266         * DerivedSources.make:
4267         * WebCore.pro:
4268         * WebCore.vcproj/WebCore.vcproj:
4269         * WebCore.xcodeproj/project.pbxproj:
4270         * bindings/js/kjs_window.cpp:
4271         (KJS::WindowPrivate::WindowPrivate):
4272         (KJS::Window::mark):
4273         (KJS::Window::getValueProperty):
4274         (KJS::Window::clearHelperObjectProperties):
4275         (KJS::Window::disconnectFrame):
4276         * bindings/js/kjs_window.h:
4277         (KJS::Window::):
4278         * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
4279         * bridge/History.h: Removed.
4280         * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
4281         * bridge/mac/HistoryMac.mm: Removed.
4282         * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
4283         * bridge/win/HistoryWin.cpp: Removed.
4284         * css/cssstyleselector.cpp:
4285         * page/DOMWindow.cpp:
4286         (WebCore::DOMWindow::disconnectFrame):
4287         (WebCore::DOMWindow::history):
4288         * page/DOMWindow.h:
4289         * page/DOMWindow.idl:
4290         * page/History.cpp: Added.
4291         (WebCore::History::History):
4292         (WebCore::History::frame):
4293         (WebCore::History::disconnectFrame):
4294         (WebCore::History::length):
4295         (WebCore::History::back):
4296         (WebCore::History::forward):
4297         (WebCore::History::go):
4298         * page/History.h: Added.
4299         * page/History.idl: Added.
4300         * platform/gdk/TemporaryLinkStubs.cpp:
4301         * platform/qt/TemporaryLinkStubs.cpp:
4302         * platform/wx/TemporaryLinkStubs.cpp:
4303
4304 2007-06-18  Sam Weinig  <sam@webkit.org>
4305
4306         Qt build fix.
4307
4308         * platform/qt/PlatformScreenQt.cpp:
4309         (WebCore::screenDepth):
4310         (WebCore::screenDepthPerComponent):
4311         (WebCore::screenIsMonochrome):
4312         (WebCore::screenRect):
4313         (WebCore::screenAvailableRect):
4314
4315 2007-06-18  Sam Weinig  <sam@webkit.org>