WebCore/ChangeLog

   1 2006-10-06  Mitz Pettel  <mitz@webkit.org>
   2
   3         http://bugs.webkit.org/show_bug.cgi?id=8276
   4         Fix broken manual test added back in r13990.
   5
   6         Add resource forks for test resources.
   7
   8         * manual-tests/resources/plain-text-paste/._1.textClipping: Added.
   9         * manual-tests/resources/plain-text-paste/._2.textClipping: Added.
  10         * manual-tests/resources/plain-text-paste/._4.txt: Added.
  11         * manual-tests/resources/plain-text-paste/._5.webloc: Added.
  12
  13 2006-10-05  David Hyatt  <hyatt@apple.com>
  14
  15         Rename addClip to clip.
  16
  17         Reviewed by darin
  18
  19         * kcanvas/RenderForeignObject.cpp:
  20         (WebCore::RenderForeignObject::paint):
  21         * kcanvas/RenderSVGContainer.cpp:
  22         (WebCore::RenderSVGContainer::paint):
  23         * kcanvas/RenderSVGImage.cpp:
  24         (WebCore::RenderSVGImage::paint):
  25         * platform/GraphicsContext.h:
  26         * platform/cairo/GraphicsContextCairo.cpp:
  27         (WebCore::GraphicsContext::clip):
  28         * platform/cg/GraphicsContextCG.cpp:
  29         (WebCore::GraphicsContext::savePlatformState):
  30         (WebCore::GraphicsContext::restorePlatformState):
  31         (WebCore::GraphicsContext::clip):
  32         (WebCore::GraphicsContext::addRoundedRectClip):
  33         (WebCore::GraphicsContext::addInnerRoundedRectClip):
  34         (WebCore::GraphicsContext::scale):
  35         (WebCore::GraphicsContext::rotate):
  36         (WebCore::GraphicsContext::translate):
  37         (WebCore::GraphicsContext::concatCTM):
  38         * platform/cg/GraphicsContextPlatformPrivate.h:
  39         (WebCore::GraphicsContextPlatformPrivate::save):
  40         (WebCore::GraphicsContextPlatformPrivate::restore):
  41         (WebCore::GraphicsContextPlatformPrivate::clip):
  42         (WebCore::GraphicsContextPlatformPrivate::scale):
  43         (WebCore::GraphicsContextPlatformPrivate::rotate):
  44         (WebCore::GraphicsContextPlatformPrivate::translate):
  45         (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  46         * platform/qt/GraphicsContextQt.cpp:
  47         (WebCore::GraphicsContext::clip):
  48         (WebCore::GraphicsContext::addInnerRoundedRectClip):
  49         (WebCore::GraphicsContext::addRoundedRectClip):
  50         * rendering/InlineFlowBox.cpp:
  51         (WebCore::InlineFlowBox::paintBackground):
  52         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  53         * rendering/InlineTextBox.cpp:
  54         (WebCore::InlineTextBox::paintSelection):
  55         (WebCore::InlineTextBox::paintTextMatchMarker):
  56         * rendering/RenderBox.cpp:
  57         (WebCore::RenderBox::paintBackgroundExtended):
  58         * rendering/RenderButton.cpp:
  59         (WebCore::RenderButton::paintObject):
  60         * rendering/RenderFileUploadControl.cpp:
  61         (WebCore::RenderFileUploadControl::paintObject):
  62         * rendering/RenderLayer.cpp:
  63         (WebCore::RenderLayer::beginTransparencyLayers):
  64         (WebCore::setClip):
  65         * rendering/RenderListBox.cpp:
  66         (WebCore::RenderListBox::paintObject):
  67         * rendering/RenderMenuList.cpp:
  68         (WebCore::RenderMenuList::paintObject):
  69         * rendering/RenderTableCell.cpp:
  70         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  71
  72 2006-10-05  Mitz Pettel  <mitz@webkit.org>
  73
  74         Reviewed by Darin.
  75
  76         - http://bugs.webkit.org/show_bug.cgi?id=10386
  77           Delete RenderImageButton.* and remove references from .vcproj and .bkl files
  78
  79         * CMakeLists.txt:
  80         * WebCore.vcproj/WebCore/WebCore.vcproj:
  81         * WebCoreSources.bkl:
  82         * rendering/RenderImageButton.cpp: Removed.
  83         * rendering/RenderImageButton.h: Removed.
  84
  85 2006-10-05  Mitz Pettel  <opendarwin.org@mitzpettel.com>
  86
  87         Reviewed by Darin.
  88
  89         - http://bugs.webkit.org/show_bug.cgi?id=11067
  90           manual-tests/scrollbar-hittest2.html is invalid
  91
  92         * manual-tests/scrollbar-hittest2.html:
  93
  94 2006-10-05  David Carson  <dacarson@gmail.com>
  95
  96         Reviewed by Darin.
  97
  98         http://bugs.webkit.org/show_bug.cgi?id=11152
  99         Adjust the tokenizer chunk size to be smaller for
 100         mobile devices, and also decrease the yield timer
 101         for the tokenizer so that it can resume earlier.
 102
 103         * html/HTMLTokenizer.cpp:
 104         * config.h:
 105
 106 2006-10-05  Adam Roben  <aroben@apple.com>
 107
 108         Removing accidentally-checked-in do-nothing code.
 109
 110         * html/HTMLInputElement.cpp:
 111         (WebCore::HTMLInputElement::defaultEventHandler):
 112
 113 2006-10-05  David Carson  <dacarson@gmail.com>
 114
 115         Reviewed by Mitz.
 116
 117         http://bugs.webkit.org/show_bug.cgi?id=11158
 118         Initialize class variables
 119
 120         * rendering/RenderLayer.cpp:
 121         (WebCore::RenderLayer::RenderLayer):
 122
 123 2006-10-05  Don Gibson  <dgibson77@gmail.com>
 124
 125         Reviewed by Darin, landed by Adam.
 126
 127         http://bugs.webkit.org/show_bug.cgi?id=11176
 128         Fix win32 build, adapt to Maciej's ResourceLoader changes.
 129
 130         * platform/win/ResourceLoaderWin.cpp:
 131         (WebCore::ResourceLoader::start):
 132
 133 2006-10-05  Marvin Decker  <marv.decker@gmail.com>
 134
 135         Reviewed by Darin.
 136
 137         http://bugs.webkit.org/show_bug.cgi?id=10989
 138         Provide a way for embedders to implement BrowserExtensionWin
 139
 140         * WebCore.vcproj/WebCore/WebCore.vcproj:
 141         * bridge/win/BrowserExtensionWin.cpp: Added.
 142         (BrowserExtensionWin::BrowserExtensionWin):
 143         (BrowserExtensionWin::setTypedIconURL):
 144         (BrowserExtensionWin::setIconURL):
 145         (BrowserExtensionWin::getHistoryLength):
 146         (BrowserExtensionWin::canRunModal):
 147         (BrowserExtensionWin::createNewWindow):
 148         (BrowserExtensionWin::canRunModalNow):
 149         (BrowserExtensionWin::runModal):
 150         (BrowserExtensionWin::goBackOrForward):
 151         (BrowserExtensionWin::historyURL):
 152         * bridge/win/BrowserExtensionWin.h:
 153         * bridge/win/FrameWin.cpp:
 154         (WebCore::FrameWin::createNewWindow):
 155         * bridge/win/FrameWin.h:
 156         * platform/win/TemporaryLinkStubs.cpp:
 157
 158 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
 159
 160         Reviewed by Darin.
 161
 162         Fixed <rdar://problem/4766987>
 163
 164         - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
 165         except for file names.
 166
 167         - fixed RenderLayer to properly tear down scrollbars, removing them from
 168         their parents.
 169
 170         * bindings/js/kjs_window.cpp:
 171         (KJS::showModalDialog):
 172         (KJS::setWindowFeature):
 173         (KJS::parseWindowFeatures):
 174         * bridge/BrowserExtension.h:
 175         * dom/Document.cpp:
 176         (WebCore::Document::setInPageCache):
 177         * html/HTMLFrameElement.cpp:
 178         (WebCore::HTMLFrameElement::init):
 179         (WebCore::HTMLFrameElement::parseMappedAttribute):
 180         * html/HTMLFrameElement.h:
 181         (WebCore::HTMLFrameElement::scrollingMode):
 182         * page/Frame.cpp:
 183         (WebCore::Frame::finishedParsing):
 184         (WebCore::Frame::scrollbarsVisible):
 185         * page/FrameView.cpp:
 186         (WebCore::FrameViewPrivate::FrameViewPrivate):
 187         (WebCore::FrameViewPrivate::reset):
 188         (WebCore::FrameView::~FrameView):
 189         (WebCore::FrameView::resetScrollbars):
 190         (WebCore::FrameView::clear):
 191         (WebCore::FrameView::initScrollbars):
 192         (WebCore::FrameView::applyOverflowToViewport):
 193         (WebCore::FrameView::layout):
 194         (WebCore::FrameView::handleMousePressEvent):
 195         (WebCore::selectCursor):
 196         (WebCore::FrameView::handleMouseMoveEvent):
 197         (WebCore::FrameView::setScrollbarsMode):
 198         (WebCore::FrameView::setVScrollbarMode):
 199         (WebCore::FrameView::setHScrollbarMode):
 200         (WebCore::FrameView::restoreScrollbar):
 201         (WebCore::FrameView::dispatchMouseEvent):
 202         (WebCore::FrameView::scrollbarMoved):
 203         * page/FrameView.h:
 204         * page/MouseEventWithHitTestResults.cpp:
 205         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
 206         * page/MouseEventWithHitTestResults.h:
 207         (WebCore::MouseEventWithHitTestResults::scrollbar):
 208         * platform/ScrollBar.cpp:
 209         (WebCore::Scrollbar::Scrollbar):
 210         (WebCore::Scrollbar::setValue):
 211         (WebCore::Scrollbar::setProportion):
 212         (WebCore::Scrollbar::setSteps):
 213         (WebCore::Scrollbar::scroll):
 214         * platform/ScrollBar.h:
 215         (WebCore::):
 216         (WebCore::ScrollbarClient::~ScrollbarClient):
 217         (WebCore::Scrollbar::~Scrollbar):
 218         (WebCore::Scrollbar::orientation):
 219         (WebCore::Scrollbar::controlSize):
 220         (WebCore::Scrollbar::hasPlatformScrollbars):
 221         (WebCore::Scrollbar::client):
 222         * platform/ScrollBarMode.h:
 223         (WebCore::):
 224         * platform/ScrollView.h:
 225         * rendering/RenderBlock.cpp:
 226         (WebCore::RenderBlock::isPointInScrollbar):
 227         * rendering/RenderLayer.cpp:
 228         (WebCore::RenderLayer::RenderLayer):
 229         (WebCore::RenderLayer::~RenderLayer):
 230         (WebCore::RenderLayer::scrollToOffset):
 231         (WebCore::RenderLayer::horizontaScrollbarWidget):
 232         (WebCore::RenderLayer::verticalScrollbarWidget):
 233         (WebCore::RenderLayer::valueChanged):
 234         (WebCore::RenderLayer::createScrollbar):
 235         (WebCore::RenderLayer::destroyScrollbar):
 236         (WebCore::RenderLayer::setHasHorizontalScrollbar):
 237         (WebCore::RenderLayer::setHasVerticalScrollbar):
 238         (WebCore::RenderLayer::verticalScrollbarWidth):
 239         (WebCore::RenderLayer::horizontalScrollbarHeight):
 240         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
 241         * rendering/RenderLayer.h:
 242         (WebCore::RenderLayer::horizontalScrollbar):
 243         (WebCore::RenderLayer::verticalScrollbar):
 244         * rendering/RenderListBox.cpp:
 245         (WebCore::RenderListBox::~RenderListBox):
 246         (WebCore::RenderListBox::calcMinMaxWidth):
 247         (WebCore::RenderListBox::isPointInScrollbar):
 248         (WebCore::RenderListBox::optionAtPoint):
 249         (WebCore::RenderListBox::valueChanged):
 250         * rendering/RenderListBox.h:
 251         * rendering/RenderObject.h:
 252         (WebCore::RenderObject::NodeInfo::scrollbar):
 253         (WebCore::RenderObject::NodeInfo::setScrollbar):
 254
 255 2006-10-05  Don Gibson  <dgibson77@gmail.com>
 256
 257         Reviewed by Adam.
 258
 259         http://bugs.webkit.org/show_bug.cgi?id=11138
 260         Incorrect mouse event generation on Windows
 261
 262         * platform/win/MouseEventWin.cpp:
 263         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
 264         (1) Set mouse button even for non-click-related messages.
 265         (2) Track clicks correctly for all buttons, not just the left button.
 266
 267 2006-10-05  Nikolas Zimmermann  <zimmermann@kde.org>
 268
 269         Reviewed and landed by ap.
 270
 271         Fix Qt/Linux build, adapt to Eric's quartz changes and to Maciej's ResourceLoader changes.
 272
 273         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
 274         (WebCore::KRenderingPaintServerLinearGradientQt::renderPath):
 275         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
 276         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
 277         (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
 278         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
 279         (WebCore::KRenderingPaintServerPatternQt::renderPath):
 280         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
 281         (WebCore::KRenderingPaintServerQt::setPenProperties):
 282         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
 283         (WebCore::KRenderingPaintServerSolidQt::setup):
 284         (WebCore::KRenderingPaintServerSolidQt::renderPath):
 285         * kcanvas/device/qt/RenderPathQt.cpp:
 286         (WebCore::getPathStroke):
 287
 288 2006-10-05  Alexey Proskuryakov  <ap@nypop.com>
 289
 290         Reviewed by Darin.
 291
 292         http://bugs.webkit.org/show_bug.cgi?id=11054
 293         REGRESSION: Traditional Chinese encoding in login authentication
 294
 295         1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
 296         2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding
 297         for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
 298
 299         * platform/StreamingTextDecoderICU.cpp:
 300         (WebCore::TextCodecICU::registerEncodingNames):
 301
 302 2006-10-05  Eric Seidel  <eric@eseidel.com>
 303
 304         Reviewed by mjs.
 305
 306         Removed dead code.
 307         Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
 308
 309         * WebCore.xcodeproj/project.pbxproj:
 310         * ksvg2/ecma/GlobalObject.cpp: Removed.
 311         * ksvg2/ecma/GlobalObject.h: Removed.
 312
 313 2006-10-05  Adam Roben  <aroben@apple.com>
 314
 315         Reviewed by Maciej.
 316
 317         Small ResourceLoaderInternal tweak.
 318
 319         * platform/ResourceLoaderInternal.h:
 320         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
 321
 322 2006-10-05  Eric Seidel  <eric@eseidel.com>
 323
 324         Reviewed by mjs.
 325
 326         More incremental KCanvas cleanup and optimization.
 327         Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
 328         Optimized dash array usage to not malloc.
 329         Also removed un-needed KSVGRenderingStyle includes.
 330
 331         * kcanvas/KCanvasTreeDebug.cpp:
 332         (WebCore::operator<<):
 333         * kcanvas/RenderPath.cpp:
 334         (WebCore::RenderPath::nodeAtPoint):
 335         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
 336         (WebCore::RenderPath::strokeBBox):
 337         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
 338         (WebCore::KRenderingPaintServerGradientQuartz::setup):
 339         (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
 340         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
 341         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
 342         (WebCore::KRenderingPaintServerSolidQuartz::setup):
 343         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
 344         (WebCore::KRenderingPaintServerPatternQuartz::setup):
 345         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
 346         * kcanvas/device/quartz/QuartzSupport.mm:
 347         (WebCore::applyStrokeStyleToContext):
 348         * ksvg2/css/SVGRenderStyle.h:
 349         (WebCore::SVGRenderStyle::hasStroke):
 350         (WebCore::SVGRenderStyle::hasFill):
 351         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 352         (WebCore::KSVGPainterFactory::fillPaintServer):
 353         (WebCore::KSVGPainterFactory::strokePaintServer):
 354         * ksvg2/misc/KCanvasRenderingStyle.h:
 355
 356 2006-10-05  Maciej Stachowiak  <mjs@apple.com>
 357
 358         Reviewed by Adam.
 359
 360         - changed ResourceLoader to be refcounted
 361
 362         It keeps a ref on itself while loading as well. This makes
 363         for a much saner memory management model than the previous.
 364
 365         * bridge/mac/WebCoreResourceLoaderImp.mm:
 366         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
 367         * dom/XMLTokenizer.cpp:
 368         (WebCore::openFunc):
 369         * loader/icon/IconLoader.cpp:
 370         (IconLoader::IconLoader):
 371         (IconLoader::~IconLoader):
 372         (IconLoader::startLoading):
 373         (IconLoader::stopLoading):
 374         (IconLoader::receivedData):
 375         * loader/icon/IconLoader.h:
 376         * loader/loader.cpp:
 377         (WebCore::Loader::servePendingRequests):
 378         * platform/ResourceLoader.cpp:
 379         (WebCore::ResourceLoader::create):
 380         (WebCore::ResourceLoader::kill):
 381         * platform/ResourceLoader.h:
 382         * platform/ResourceLoaderInternal.h:
 383         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
 384         * platform/mac/ResourceLoaderMac.mm:
 385         (WebCore::ResourceLoader::start):
 386         * xml/XSLTProcessor.cpp:
 387         (WebCore::docLoaderFunc):
 388         * xml/xmlhttprequest.cpp:
 389         (WebCore::XMLHttpRequest::send):
 390         * xml/xmlhttprequest.h:
 391
 392 2006-10-05  Eric Seidel  <eric@eseidel.com>
 393
 394         Reviewed by mjs.
 395
 396         Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
 397         http://bugs.webkit.org/show_bug.cgi?id=11163
 398
 399         No SVG performance tests yet.
 400
 401         * kcanvas/RenderForeignObject.cpp:
 402         (WebCore::RenderForeignObject::paint):
 403         * kcanvas/RenderSVGContainer.cpp:
 404         (WebCore::RenderSVGContainer::paint):
 405         * kcanvas/RenderSVGImage.cpp:
 406         (WebCore::RenderSVGImage::paint):
 407         * kcanvas/RenderSVGText.cpp:
 408         (WebCore::RenderSVGText::paint):
 409
 410 2006-10-05  Dave Hyatt  <hyatt@apple.com>
 411
 412         Stub out some stuff for widget focusability.
 413
 414         Reviewed by maciej
 415
 416         * page/FrameView.cpp:
 417         (WebCore::FrameView::dispatchMouseEvent):
 418         * platform/ScrollView.h:
 419         * platform/Widget.h:
 420
 421 2006-10-05  Adam Roben  <aroben@apple.com>
 422
 423         Reviewed by Maciej and Tim H.
 424
 425         Copy some WebKit frame lifetime logic into WebCore -- just a step
 426         along the path to frame lifetime being handled completely in WebCore.
 427
 428         * bridge/mac/FrameMac.mm:
 429         (WebCore::FrameMac::setView): Move platform-independent parts of this
 430         method into Frame.
 431         * page/Frame.cpp:
 432         (WebCore::Frame::setView): Adding platform-independent parts of
 433         FrameMac::setView
 434         (WebCore::Frame::detachChildren): New method to accomplish what
 435         -[WebFrameBridge _detachChildren] currently does.
 436         (WebCore::Frame::clear): Call detachChildren
 437         * page/Frame.h: Add declaration for detachChildren
 438
 439 2006-10-04  Alice Liu  <alice.liu@apple.com>
 440
 441         Reviewed by Darin.
 442
 443         Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query
 444
 445         * xml/xmlhttprequest.cpp:
 446         (WebCore::XMLHttpRequest::setRequestHeader):
 447         removed exception set when the request is not open yet
 448
 449 2006-10-04  Anders Carlsson  <acarlsson@apple.com>
 450
 451         Reviewed by John Sullivan.
 452
 453         <rdar://problem/4654328>
 454         Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
 455
 456         * loader/PluginDocument.cpp:
 457         (WebCore::PluginTokenizer::writeRawData):
 458         Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
 459
 460 2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
 461
 462         Reviewed by Tim H.
 463
 464         http://bugs.webkit.org/show_bug.cgi?id=11130
 465         Convert "undefined" to AE missing value
 466
 467         * bridge/mac/WebCoreFrameBridge.mm:
 468         (aeDescFromJSValue): return missing value for UndefinedType.
 469
 470 2006-10-03  Dave Hyatt  <hyatt@apple.com>
 471
 472         Scrolling work.  Eliminate convertTo/FromContainingWindow as cross-platform functions.  Add back in
 473         the windowToContents/contentsToWindow functions.
 474
 475         Reviewed by anders
 476
 477         * bridge/mac/FrameMac.mm:
 478         (WebCore::FrameMac::eventMayStartDrag):
 479         (WebCore::FrameMac::dragHysteresisExceeded):
 480         (WebCore::FrameMac::mouseDown):
 481         (WebCore::FrameMac::shouldDragAutoNode):
 482         (WebCore::FrameMac::sendContextMenuEvent):
 483         * bridge/mac/FrameViewMac.mm:
 484         (WebCore::FrameView::passMousePressEventToScrollbar):
 485         * bridge/mac/WebCoreFrameBridge.mm:
 486         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
 487         * dom/EventTargetNode.cpp:
 488         (WebCore::EventTargetNode::dispatchMouseEvent):
 489         (WebCore::EventTargetNode::dispatchWheelEvent):
 490         * page/Frame.cpp:
 491         (WebCore::Frame::selectClosestWordFromMouseEvent):
 492         (WebCore::Frame::handleMousePressEventTripleClick):
 493         (WebCore::Frame::handleMousePressEventSingleClick):
 494         (WebCore::Frame::handleMouseMoveEvent):
 495         (WebCore::Frame::handleMouseReleaseEvent):
 496         * page/FrameView.cpp:
 497         (WebCore::FrameView::handleMousePressEvent):
 498         (WebCore::FrameView::handleMouseDoubleClickEvent):
 499         (WebCore::selectCursor):
 500         (WebCore::FrameView::handleMouseMoveEvent):
 501         (WebCore::FrameView::handleMouseReleaseEvent):
 502         (WebCore::FrameView::dispatchDragEvent):
 503         (WebCore::FrameView::prepareMouseEvent):
 504         (WebCore::FrameView::handleWheelEvent):
 505         * page/FrameView.h:
 506         * platform/ScrollBar.cpp:
 507         (WebCore::ScrollBar::setValue):
 508         * platform/ScrollView.h:
 509         * platform/Widget.h:
 510         (WebCore::Widget::scrolled):
 511         * platform/mac/ScrollViewMac.mm:
 512         (WebCore::ScrollView::contentsToWindow):
 513         (WebCore::ScrollView::windowToContents):
 514         (WebCore::ScrollView::scrollbarUnderMouse):
 515         * platform/mac/WidgetMac.mm:
 516         * rendering/RenderLayer.cpp:
 517         (WebCore::RenderLayer::resize):
 518         (WebCore::RenderLayer::positionScrollbars):
 519         * rendering/RenderReplaced.cpp:
 520         (WebCore::RenderReplaced::shouldPaint):
 521         * rendering/RenderView.cpp:
 522         * rendering/RenderView.h:
 523         * rendering/RenderWidget.cpp:
 524         (WebCore::RenderWidget::setWidget):
 525
 526 2006-09-26  David Smith  <catfish.man@gmail.com>
 527
 528         Reviewed by Timothy.
 529
 530         http://bugs.webkit.org/show_bug.cgi?id=3723
 531         Add -scrollDOMRangeToVisible:
 532
 533         No automated tests are possible as this code path isn't reachable from JavaScript.
 534
 535         * bridge/mac/WebCoreFrameBridge.h:
 536         * bridge/mac/WebCoreFrameBridge.mm:
 537         (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
 538
 539 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
 540
 541         Reviewed by Timothy.
 542
 543         <http://bugs.webkit.org/show_bug.cgi?id=10338>
 544         When contentEditable, cursor doesn't change to hand
 545
 546         Allow the behaviour of editable links to be specified by a WebPreference
 547         The preference WebKitEditableLinkBehavior has four options:
 548          - AlwaysLive: Safari 2.0 behaviour
 549          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
 550          - LiveWhenNotFocused: Editable links are live only when their editable block is not
 551              focused, or when the shift key is pressed
 552          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
 553
 554         No layout tests, just a modification of a manual-test as it isn't possible to test
 555         this automatically.
 556
 557         * bridge/mac/WebCoreSettings.h:
 558         * bridge/mac/WebCoreSettings.mm:
 559         (-[WebCoreSettings setEditableLinkBehavior:]):
 560         (-[WebCoreSettings editableLinkBehavior]):
 561         * html/HTMLAnchorElement.cpp:
 562         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
 563         (WebCore::HTMLAnchorElement::defaultEventHandler):
 564         (WebCore::HTMLAnchorElement::setActive):
 565         * html/HTMLAnchorElement.h:
 566         * manual-tests/contenteditable-link.html:
 567         * page/FrameView.cpp:
 568         (WebCore::nodeIsNotBeingEdited):
 569         (WebCore::selectCursor):
 570         * page/Settings.h:
 571         (WebCore::Settings::):
 572         (WebCore::Settings::Settings):
 573         (WebCore::Settings::editableLinkBehavior):
 574         (WebCore::Settings::setEditableLinkBehavior):
 575
 576 2006-10-03  Beth Dakin  <bdakin@apple.com>
 577
 578         Reviewed Darin.
 579
 580         No test cases needed.
 581
 582         Implemented a version of StringImpl::append that takes a UChar* and
 583         a length.
 584
 585         * platform/StringImpl.cpp:
 586         (WebCore::StringImpl::append):
 587         (WebCore::StringImpl::insert): Call new append instead of making a
 588         new StringImpl.
 589         * platform/StringImpl.h:
 590
 591 2006-10-03  MorganL  <morganl.webkit@yahoo.com>
 592
 593         Reviewed by Darin.
 594
 595         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
 596         HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
 597
 598         * platform/win/ResourceLoaderWin.cpp:
 599         (WebCore::ResourceLoader::onHandleCreated):
 600
 601 2006-10-02  Geoffrey Garen  <ggaren@apple.com>
 602
 603         Feared, loathed, reviewed by Darin.
 604
 605         More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach
 606         into FRAME, plus other cleanup.
 607
 608         No new behavior, so no new test. Layout tests pass. Basic browsing and
 609         Mail editing seem to work.
 610
 611         * dom/Node.cpp:
 612         (WebCore::Node::detach): Removed random commented-out code.
 613         * html/HTMLFrameElement.cpp:
 614         (WebCore::HTMLFrameElement::isURLAllowed):
 615         (1) Removed reference to FrameView, to dissociate frame loading from rendering.
 616         (2) Renamed newURL to completeURL because the difference between newURL
 617         and URLString is that newURL is a KURL that is the complete version of URLString,
 618         not that it is new.
 619         (WebCore::HTMLFrameElement::willRemove):
 620         (1) Removed close() call and moved close() code into willRemove(), also removing
 621         close() call from detach(), since willRemove is the well-defined place
 622         from DOM tear-down, not detach().
 623         (2) Removed manual renderer detach code because the DOM is not responsible
 624         for managing the render tree. I confirmed that this change not
 625         regress <rdar://problem/4132581>.
 626         (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
 627         lost their content frames after being removed from the DOM. That's our
 628         current behavior, but it's going to change in future rounds of refactoring.
 629         This also fixes <rdar://problem/4750835>.
 630         (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
 631         attach/detach, because the render tree should not be in charge of deciding
 632         when to load.
 633         * html/HTMLFrameElement.h:
 634         * html/HTMLIFrameElement.cpp:
 635         (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
 636         because the renderer is a renderPartObject, not a renderPart.
 637         * html/HTMLIFrameElement.h:
 638
 639 2006-10-03  Mark Rowe  <bdash@webkit.org>
 640
 641         Reviewed by Mitz.
 642
 643         http://bugs.webkit.org/show_bug.cgi?id=11137
 644         Bug 11137: GdkLauncher dies with "pure virtual method called" if
 645         window is closed while page still loading
 646
 647         * platform/gdk/FrameGdk.cpp:
 648         (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
 649         methods to be called before the FrameGdk portion of "this" is torn down.
 650
 651 2006-10-03  Adam Roben  <aroben@apple.com>
 652
 653         Reviewed by Darin.
 654
 655         Handle tab key presses in the DOM.
 656
 657         * dom/EventTargetNode.cpp:
 658         (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
 659         * page/FrameView.cpp:
 660         (WebCore::FrameView::advanceFocus): Rename and reimplement
 661         focusNextPrevNode. Now we just call Element::focus().
 662         * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
 663         it public.
 664
 665 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
 666
 667         Reviewed by mjs
 668
 669         <rdar://problem/4760612>
 670         TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
 671
 672         No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
 673
 674         * dom/Range.cpp:
 675         (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming
 676         positions are non-null since most of it's callers would be in a bad state if the positions
 677         were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.
 678         Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it
 679         from entering compareBoundaryPoints and hitting the assert.
 680
 681 2006-10-03  Adele Peterson  <adele@apple.com>
 682
 683         Reviewed by Geoff.
 684
 685         Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
 686
 687         * html/HTMLSelectElement.cpp:
 688         (WebCore::HTMLSelectElement::recalcStyle):
 689         (WebCore::HTMLSelectElement::isKeyboardFocusable):
 690         (WebCore::HTMLSelectElement::isMouseFocusable):
 691         (WebCore::HTMLSelectElement::createRenderer):
 692         (WebCore::HTMLSelectElement::setRecalcListItems):
 693         (WebCore::HTMLSelectElement::notifyOptionSelected):
 694         (WebCore::HTMLSelectElement::defaultEventHandler):
 695
 696 2006-10-04  Darin Adler  <darin@apple.com>
 697
 698         Reviewed by Geoff.
 699
 700         - fix http://bugs.webkit.org/show_bug.cgi?id=11132
 701           Caret disappears when you're typing
 702
 703         * editing/SelectionController.cpp:
 704         (WebCore::SelectionController::setSelection): Remove unnecessary call to
 705         clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
 706         (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
 707         to false so we can get the old caret repaint rect. Later we need to change the
 708         design so getting the rect doesn't have a side effect of causing a layout without
 709         invalidation.
 710
 711 2006-10-03  David Harrison  <harrison@apple.com>
 712
 713         Reviewed by Maciej.
 714
 715         <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
 716
 717         Updated test:
 718         * fast/text/justified-text-rect.html
 719
 720         * bridge/mac/WebCoreFrameBridge.mm:
 721         (-[WebCoreFrameBridge convertToNSRange:]):
 722         (-[WebCoreFrameBridge convertToDOMRange:]):
 723         Make the selection's root editable element (or the document itself) be
 724         the basis for NSRange conversions. This supports "shadow DOM" like
 725         that for text fields and text areas.
 726
 727         * editing/CompositeEditCommand.cpp:
 728         (WebCore::CompositeEditCommand::moveParagraphs):
 729         Pass the document element as the scope.
 730
 731         * editing/TextIterator.cpp:
 732         (WebCore::TextIterator::rangeFromLocationAndLength):
 733         Make the first parameter the scope.
 734
 735         * editing/TextIterator.h:
 736         Make the first parameter of rangeFromLocationAndLength() the scope.
 737
 738 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
 739
 740         Reviewed by Eric.
 741
 742         Fix Qt/Linux build.
 743
 744         * CMakeLists.txt: Add counter related files.
 745
 746 2006-10-03  Mark Rowe  <bdash@webkit.org>
 747
 748         Reviewed by Eric.
 749
 750         http://bugs.webkit.org/show_bug.cgi?id=10981
 751         Linux/GDK build fixes
 752
 753         Based on a patch by Krzysztof Kowalczyk.
 754
 755         * WebCoreSources.bkl:
 756         * platform/gdk/FrameGdk.cpp:
 757         (WebCore::doScroll):
 758         (WebCore::FrameGdk::handleGdkEvent):
 759         * platform/gdk/PlatformScrollBar.h: Added.
 760         (WebCore::PlatformScrollBar::isWidget):
 761         * platform/gdk/ScrollViewGdk.cpp:
 762         * platform/gdk/TemporaryLinkStubs.cpp:
 763         (FrameView::passMousePressEventToScrollbar):
 764         (FrameView::passMousePressEventToSubframe):
 765         (FrameView::passMouseReleaseEventToSubframe):
 766         (FrameView::passMouseMoveEventToSubframe):
 767         (FrameView::passWheelEventToSubframe):
 768         (Cursor::Cursor):
 769         (Widget::invalidate):
 770         (Widget::invalidateRect):
 771         (ScrollView::wheelEvent):
 772         (ScrollView::convertToContainingWindow):
 773         (ScrollView::convertFromContainingWindow):
 774         (GraphicsContext::clip):
 775         (PlatformScrollBar::PlatformScrollBar):
 776         (PlatformScrollBar::updateThumbPosition):
 777         (PlatformScrollBar::updateThumbProportion):
 778         (ScrollBar::ScrollBar):
 779         (ScrollBar::setProportion):
 780         (WebCore::supportedKeySizes):
 781         (WebCore::signedPublicKeyAndChallengeString):
 782         * platform/gdk/WheelEventGdk.cpp:
 783         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
 784         * platform/gdk/WidgetGdk.cpp:
 785         (WebCore::Widget::convertToContainingWindow):
 786         (WebCore::Widget::convertFromContainingWindow):
 787
 788 2006-10-02  Adam Roben  <aroben@apple.com>
 789
 790         Reviewed by Maciej.
 791
 792         Let Windows determine which mouse button is pressed.
 793
 794         * platform/PlatformMouseEvent.h: Add message parameter to constructor.
 795         * platform/win/MouseEventWin.cpp:
 796         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
 797         parameter to determine which mouse button is pressed.
 798
 799 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
 800
 801         Reviewed by anders
 802
 803         Build fix
 804
 805         * editing/SelectionController.cpp:
 806         (WebCore::SelectionController::empty):
 807         * editing/SelectionController.h:
 808
 809 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
 810
 811         Reviewed by john
 812
 813         <rdar://problem/4755287>
 814         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
 815
 816         * editing/markup.cpp:
 817         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced
 818         elements).  Don't skip blocks that aren't containers (like horizontal rules).
 819
 820 2006-10-03  Darin Adler  <darin@apple.com>
 821
 822         Reviewed by Justin Garcia.
 823
 824         - correct mistaken code that would restart blinking every
 825           time "invalidateSelection" is called even if the caret
 826           has not moved
 827
 828         * editing/SelectionController.h:
 829         * editing/SelectionController.cpp:
 830         (WebCore::SelectionController::setSelection): Update for name change.
 831         (WebCore::SelectionController::recomputeCaretRect): New function.
 832         Computes caret rect and does any necessary invalidation if the rect
 833         changes.
 834         (WebCore::SelectionController::invalidateCaretRect): Renamed from
 835         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
 836         calls recomputeCaretRect as a side effect.
 837
 838         * page/Frame.cpp:
 839         (WebCore::Frame::invalidateSelection): Remove unneeded call to
 840         clearCaretRectIfNeeded.
 841         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
 842         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
 843         recomputeCaretRect function and not restart blinking if caret has
 844         not changed position.
 845         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
 846         are not needed since selectionLayoutChanged already checks these.
 847
 848         * page/FramePrivate.h: Removed unused m_blinkCaret.
 849
 850 2006-10-02  Beth Dakin  <bdakin@apple.com>
 851
 852         Reviewed by Adam.
 853
 854         Build fix. Add counters to vcproj.
 855
 856         * WebCore.vcproj/WebCore/WebCore.vcproj:
 857
 858 2006-10-02  Brady Eidson  <beidson@apple.com>
 859
 860         Reviewed by Adele
 861
 862         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
 863         icon data out because we don't correctly check SQL error conditions.
 864
 865         * loader/icon/IconDataCache.cpp:
 866         (WebCore::IconDataCache::writeToDatabase):
 867
 868 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
 869
 870         Reviewed by Hyatt.
 871
 872         Added method to find out whether a layout has occurred.
 873
 874         * page/FrameView.cpp:
 875         (WebCore::FrameView::didFirstLayout):
 876         * page/FrameView.h:
 877
 878 2006-10-02  Beth Dakin  <bdakin@apple.com>
 879
 880         Reviewed by Darin.
 881
 882         Initial implementation of CSS2 counters. See http://
 883         bugs.webkit.org/show_bug.cgi?id=4980 for more details.
 884
 885         * WebCore.xcodeproj/project.pbxproj:
 886         * css/CSSComputedStyleDeclaration.cpp:
 887         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return
 888         the increment/reset list now that this is implemented.
 889         * css/CSSPrimitiveValue.cpp:
 890         (WebCore::CSSPrimitiveValue::cssText):
 891         * css/Counter.h:
 892         (WebCore::Counter::Counter):
 893         (WebCore::Counter::~Counter):
 894         (WebCore::Counter::identifier):
 895         (WebCore::Counter::listStyle):
 896         (WebCore::Counter::separator):
 897         (WebCore::Counter::listStyleNumber):
 898         (WebCore::Counter::setIdentifier):
 899         (WebCore::Counter::setListStyle):
 900         (WebCore::Counter::setSeparator):
 901         * css/cssparser.cpp:
 902         (WebCore::CSSParser::addProperty): Take care of reset/increment
 903         (WebCore::CSSParser::parseValue):
 904         (WebCore::CSSParser::parseContent): content can now take counters
 905         (WebCore::CSSParser::parseCounterContent): Parse counter() and
 906         counters()
 907         (WebCore::CSSParser::parseCounter): Parse counter-reset and
 908         counter-increment
 909         * css/cssparser.h:
 910         * css/cssstyleselector.cpp:
 911         (WebCore::CSSStyleSelector::matchUARules):
 912         (WebCore::CSSStyleSelector::applyProperty):
 913         * platform/PlatformString.h:
 914         * platform/String.cpp:
 915         (WebCore::String::insert): Implemented a version of insert that
 916         accepts a UChar* and a length.
 917         * platform/StringImpl.cpp:
 918         (WebCore::StringImpl::insert): Same as above.
 919         * platform/StringImpl.h:
 920         * rendering/CounterListItem.h: Added.
 921         * rendering/CounterNode.cpp: Added.
 922         (WebCore::CounterNode::CounterNode):
 923         (WebCore::CounterNode::insertAfter):
 924         (WebCore::CounterNode::removeChild):
 925         (WebCore::CounterNode::remove):
 926         (WebCore::CounterNode::setUsesSeparator):
 927         (WebCore::CounterNode::recountAndGetNext):
 928         (WebCore::CounterNode::recountTree):
 929         (WebCore::CounterNode::setSelfDirty):
 930         (WebCore::CounterNode::setParentDirty):
 931         * rendering/CounterNode.h: Added.
 932         (WebCore::CounterNode::~CounterNode):
 933         (WebCore::CounterNode::parent):
 934         (WebCore::CounterNode::previousSibling):
 935         (WebCore::CounterNode::nextSibling):
 936         (WebCore::CounterNode::firstChild):
 937         (WebCore::CounterNode::lastChild):
 938         (WebCore::CounterNode::value):
 939         (WebCore::CounterNode::setValue):
 940         (WebCore::CounterNode::count):
 941         (WebCore::CounterNode::setCount):
 942         (WebCore::CounterNode::setHasSeparator):
 943         (WebCore::CounterNode::isReset):
 944         (WebCore::CounterNode::hasSeparator):
 945         (WebCore::CounterNode::willNeedLayout):
 946         (WebCore::CounterNode::setWillNeedLayout):
 947         (WebCore::CounterNode::isRoot):
 948         (WebCore::CounterNode::setRenderer):
 949         (WebCore::CounterNode::renderer):
 950         * rendering/CounterResetNode.cpp: Added.
 951         (WebCore::CounterResetNode::CounterResetNode):
 952         (WebCore::CounterResetNode::insertAfter):
 953         (WebCore::CounterResetNode::removeChild):
 954         (WebCore::CounterResetNode::recountAndGetNext):
 955         (WebCore::CounterResetNode::setParentDirty):
 956         (WebCore::CounterResetNode::updateTotal):
 957         * rendering/CounterResetNode.h: Added.
 958         (WebCore::CounterResetNode::firstChild):
 959         (WebCore::CounterResetNode::lastChild):
 960         (WebCore::CounterResetNode::isReset):
 961         (WebCore::CounterResetNode::total):
 962         * rendering/RenderContainer.cpp:
 963         (WebCore::RenderContainer::updatePseudoChildForObject): Account for
 964         counter content.
 965         * rendering/RenderCounter.cpp: Added.
 966         (WebCore::RenderCounter::RenderCounter):
 967         (WebCore::RenderCounter::layout):
 968         (WebCore::toRoman):
 969         (WebCore::toLetterString):
 970         (WebCore::toHebrew):
 971         (WebCore::RenderCounter::convertValueToType):
 972         (WebCore::RenderCounter::calcMinMaxWidth):
 973         * rendering/RenderCounter.h: Added.
 974         (WebCore::RenderCounter::renderName):
 975         (WebCore::RenderCounter::isCounter):
 976         * rendering/RenderObject.cpp:
 977         (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to
 978         maps of CounterNodes
 979         (WebCore::RenderObject::RenderObject):
 980         (WebCore::RenderObject::destroy): Destroy the maps.
 981         (WebCore::RenderObject::findCounter): Finds/creates counters.
 982         * rendering/RenderObject.h:
 983         (WebCore::RenderObject::isCounter):
 984         * rendering/RenderStyle.cpp:
 985         (WebCore::StyleVisualData::StyleVisualData):
 986         (WebCore::RenderStyle::arenaDelete):
 987         (WebCore::RenderStyle::RenderStyle):
 988         (WebCore::RenderStyle::diff):
 989         (WebCore::RenderStyle::setContent):
 990         (WebCore::ContentData::clearContent):
 991         (WebCore::RenderStyle::counterDataEquivalent):
 992         (WebCore::hasCounter):
 993         (WebCore::RenderStyle::hasCounterReset):
 994         (WebCore::RenderStyle::hasCounterIncrement):
 995         (WebCore::readCounter):
 996         (WebCore::RenderStyle::counterReset):
 997         (WebCore::RenderStyle::counterIncrement):
 998         * rendering/RenderStyle.h:
 999         (WebCore::StyleVisualData::operator==):
1000         (WebCore::CounterData::CounterData):
1001         (WebCore::CounterData::identifier):
1002         (WebCore::CounterData::listStyle):
1003         (WebCore::CounterData::separator):
1004         (WebCore::ContentData::contentCounter):
1005         (WebCore::ContentData::):
1006         (WebCore::RenderStyle::counterIncrement):
1007         (WebCore::RenderStyle::counterReset):
1008         (WebCore::RenderStyle::setCounterIncrement):
1009         (WebCore::RenderStyle::setCounterReset):
1010         (WebCore::RenderStyle::setCounterResetList):
1011         (WebCore::RenderStyle::setCounterIncrementList):
1012         (WebCore::RenderStyle::counterResetValueList):
1013         (WebCore::RenderStyle::counterIncrementValueList):
1014
1015 2006-10-02  Adele Peterson  <adele@apple.com>
1016
1017         Reviewed by Adam.
1018
1019         - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
1020
1021         There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
1022         by using "-webkit-appearance:none".
1023
1024         * css/html4.css:
1025
1026 2006-10-02  David Harrison  <harrison@apple.com>
1027
1028         Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
1029         addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
1030         Left the layout test.
1031
1032         * rendering/bidi.cpp:
1033         (WebCore::checkMidpoints):
1034
1035 2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>
1036
1037         Reviewed by eseidel.  Landed by eseidel.
1038
1039         Fix Qt/Linux build.
1040
1041         * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
1042         (WebCore::supportedKeySizes):
1043
1044 2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>
1045
1046         Reviewed by eseidel & mjs.  Landed by eseidel.
1047
1048         Fix Qt/Linux build with older gcc 3.3.4.
1049         http://bugs.webkit.org/show_bug.cgi?id=11116
1050
1051         As discussed with Maciej, the GCC_ROOT_NS_HACK
1052         can be completely removed, as well as the friendship
1053         between cacheGlobalObject & the JS* objects.
1054
1055         * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
1056         * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
1057         (png_read_filter_row_mmx_avg):
1058         * platform/image-decoders/png/pngvcrd.c: Ditto.
1059         (png_mmx_support):
1060         (png_read_filter_row_mmx_avg):
1061
1062 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
1063
1064         Rubber stamped by Alexey.
1065
1066         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes
1067
1068         * css/CSSGrammar.y:
1069
1070 2006-10-01  Eric Seidel  <eric@webkit.org>
1071
1072         Reviewed by mjs.
1073
1074         Eliminate a few more hotspots in SVG drawing code.
1075
1076         No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)
1077
1078         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1079         (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
1080         * platform/mac/ColorMac.mm:
1081         (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance
1082
1083 2006-10-01  Geoffrey Garen  <ggaren@apple.com>
1084
1085         Reviewed by Maciej.
1086
1087         More frame/iframe merging.
1088
1089         - Removed needWidgetUpdate and related code. needWidgetUpdate is always
1090         false, so this was dead code.
1091         - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
1092         than attach(), is the correct place for setInViewSourceMode, because
1093         openURL() is the function that creates our frame.
1094         - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
1095         code that did the same thing in other places.
1096         - Made FRAME's attach() method suffuciently generic so that IFRAME could
1097         call up to it, rather than skipping its superclass and calling up directly
1098         to ELEMENT.
1099         - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
1100         - Replaced ad hoc frame loading code in FRAME::attach() with call to
1101         openURL(), the designated frame loading function.
1102
1103         Layout tests pass. I added a layout test for viewsource mode, since I
1104         broke it in the course of writing this patch.
1105
1106 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
1107
1108         Reviewed by Geoff.
1109
1110         * dom/Document.cpp:
1111         (WebCore::Document::recalcStyleSelector):
1112         * dom/Document.h:
1113         Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
1114
1115         * dom/Node.h:
1116         Remove DeprecatedStringList class forward declaration.
1117
1118         * editing/markup.cpp:
1119         Include DeprecatedStringList.h here since it's not included by Document.h anymore.
1120
1121         * kcanvas/KCanvasTreeDebug.cpp:
1122         * kcanvas/KCanvasTreeDebug.h:
1123         Remove unused functions.
1124
1125         * loader/loader.cpp:
1126         * page/Frame.cpp:
1127         * page/Frame.h:
1128         * page/FrameView.h:
1129         Fixup DeprecatedStringList.h includes.
1130
1131 2006-09-30  David Harrison  <harrison@apple.com>
1132
1133         Reviewed by John Sullivan.
1134
1135         <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
1136
1137         Problem was that the decision to trim was based only on whether the character
1138         is a soft hyphen, which caused pretty much any Japanese character to go.
1139         Changed to decide based on whether the character is ignorable whitespace.
1140
1141         Test:
1142         * fast/text/international/wrap-CJK-001.html
1143
1144         * rendering/bidi.cpp:
1145         (WebCore::isTrimmableChar):
1146         New. Checks whether character is whitespace that can be ignored
1147         according to the text node's style.
1148         trimmed from the end of wrapped line.
1149         (WebCore::checkMidpoints):
1150         Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
1151
1152 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
1153
1154         Reviewed by Mitz Pettel.
1155
1156         Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
1157
1158         * ksvg2/svg/SVGColor.cpp:
1159         (WebCore::SVGColor::setRGBColor):
1160         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1161         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1162         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
1163         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1164         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
1165         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1166         (SVGFESpecularLightingElement::parseMappedAttribute):
1167         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1168         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
1169         * ksvg2/svg/SVGLengthList.cpp:
1170         * ksvg2/svg/SVGNumberList.cpp:
1171         (SVGNumberList::parse):
1172         * ksvg2/svg/SVGNumberList.h:
1173         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
1174         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
1175         * ksvg2/svg/SVGStringList.cpp:
1176         (WebCore::SVGStringList::reset):
1177         * ksvg2/svg/SVGStringList.h:
1178         * ksvg2/svg/SVGTransformable.cpp:
1179         (SVGTransformable::parseTransformAttribute):
1180
1181 2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>
1182
1183         Reviewed by Eric, tweaked and landed by ap.
1184
1185         Fix Qt/Linux build.
1186
1187         * CMakeLists.txt:
1188         * platform/qt/PlatformScrollBar.h:
1189         * platform/qt/TemporaryLinkStubs.cpp:
1190         (WebCore::ScrollBar::ScrollBar):
1191         (WebCore::PlatformScrollBar::PlatformScrollBar):
1192         (FrameView::passMousePressEventToSubframe):
1193         (FrameView::passMouseMoveEventToSubframe):
1194         (FrameView::passMouseReleaseEventToSubframe):
1195         (FrameView::passWheelEventToSubframe):
1196         (FrameView::passMousePressEventToScrollbar):
1197         * ksvg2/svg/SVGDocument.h:
1198
1199 2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>
1200
1201         Reviewed by Darin.
1202
1203         Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
1204         REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
1205
1206         No test case added (probably requires new DumpRenderTree functionality)
1207
1208         * rendering/RenderImage.cpp:
1209         (WebCore::RenderImage::imageChanged): Added early return if the document is
1210         being destroyed.
1211
1212 2006-10-01  Graham Dennis  <graham.dennis@gmail.com>
1213
1214         Reviewed by Hyatt.
1215
1216         Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
1217         REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
1218
1219         Make sure we only break after a space (and not any other valid line-break) if
1220         the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
1221         I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
1222         twice in quick succession.
1223
1224         * rendering/bidi.cpp:
1225         (WebCore::RenderBlock::findNextLineBreak):
1226
1227 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
1228
1229         Reviewed by Maciej and Darin.
1230
1231         http://bugs.webkit.org/show_bug.cgi?id=4372
1232         JavaScript document.write page form does not submit in Safari
1233
1234         Test: fast/forms/document-write.html
1235
1236         * page/Frame.cpp:
1237         (WebCore::Frame::submitForm): Don't check for parsing().
1238
1239 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
1240
1241         Build fix.
1242
1243         * bridge/mac/FrameViewMac.mm: Add missing #imports.
1244
1245 2006-10-01  Dave Hyatt  <hyatt@apple.com>
1246
1247         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
1248
1249         Reviewed by mitz
1250
1251         * bridge/mac/FrameMac.mm:
1252         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
1253         * bridge/mac/FrameViewMac.mm:
1254         (WebCore::FrameView::passMousePressEventToScrollbar):
1255         * page/FrameView.cpp:
1256         (WebCore::FrameView::handleMousePressEvent):
1257         (WebCore::FrameView::setMousePressed):
1258         * page/FrameView.h:
1259         * platform/win/TemporaryLinkStubs.cpp:
1260         (FrameView::passMousePressEventToScrollbar):
1261
1262 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
1263
1264         Reviewed by Darin.
1265
1266         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
1267         Add more SVG Objective-C DOM bindings
1268
1269         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
1270           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
1271           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
1272           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
1273           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument,
1274           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
1275
1276         * DerivedSources.make:
1277         * WebCore.xcodeproj/project.pbxproj:
1278         * bindings/objc/DOMInternal.h:
1279         * bindings/objc/DOMSVG.h:
1280         * bindings/scripts/CodeGeneratorObjC.pm:
1281         * ksvg2/svg/SVGAElement.idl:
1282         * ksvg2/svg/SVGAnimateColorElement.idl:
1283         * ksvg2/svg/SVGAnimateElement.idl:
1284         * ksvg2/svg/SVGAnimateTransformElement.idl:
1285         * ksvg2/svg/SVGAnimatedPathData.idl:
1286         * ksvg2/svg/SVGAnimatedPoints.idl:
1287         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
1288         * ksvg2/svg/SVGAnimationElement.idl:
1289         * ksvg2/svg/SVGCircleElement.idl:
1290         * ksvg2/svg/SVGClipPathElement.idl:
1291         * ksvg2/svg/SVGColor.idl:
1292         * ksvg2/svg/SVGCursorElement.idl:
1293         * ksvg2/svg/SVGDefsElement.idl:
1294         * ksvg2/svg/SVGDescElement.idl:
1295         * ksvg2/svg/SVGDocument.idl:
1296         * ksvg2/svg/SVGEllipseElement.idl:
1297         * ksvg2/svg/SVGPointList.idl:
1298         * ksvg2/svg/SVGPreserveAspectRatio.idl:
1299         * ksvg2/svg/SVGRect.idl:
1300         * ksvg2/svg/SVGSVGElement.idl:
1301
1302 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
1303
1304         Reviewed by Adele.
1305
1306         - fix build
1307
1308         * platform/FloatRect.h:
1309         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
1310         but more appropriate for path-type stuff.
1311         * platform/cg/PathCG.cpp:
1312         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
1313
1314 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
1315
1316         Reviewed by Darin.
1317
1318         http://bugs.webkit.org/show_bug.cgi?id=11011
1319         External CSS is parsed as iso-8859-1 even though the main document is utf-8
1320
1321         Test: fast/encoding/css-charset-default.xhtml
1322
1323         * loader/CachedResourceClient.h:
1324         (WebCore::CachedResourceClient::setCSSStyleSheet):
1325         (WebCore::CachedResourceClient::setXSLStyleSheet):
1326         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
1327         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
1328
1329         * css/CSSImportRule.cpp:
1330         (WebCore::CSSImportRule::setCSSStyleSheet):
1331         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
1332         * css/CSSImportRule.h:
1333
1334         * css/CSSStyleSheet.cpp:
1335         (WebCore::CSSStyleSheet::CSSStyleSheet):
1336         * css/CSSStyleSheet.h:
1337         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
1338         member. Changed some String parameters to const String&.
1339
1340         * css/StyleSheet.cpp:
1341         (WebCore::StyleSheet::StyleSheet):
1342         * css/StyleSheet.h:
1343         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
1344
1345         * css/StyleSheetList.cpp:
1346         (WebCore::StyleSheetList::length):
1347         (WebCore::StyleSheetList::item):
1348         * css/StyleSheetList.h:
1349         Special-casing implicit stylesheets seemed to be dead code, removed.
1350
1351         * dom/Document.cpp:
1352         (WebCore::Document::setCSSStyleSheet):
1353         (WebCore::Document::recalcStyleSelector):
1354         * dom/Document.h:
1355         Renamed setStyleSheet() to setCSSStyleSheet().
1356
1357         * dom/ProcessingInstruction.cpp:
1358         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
1359         (WebCore::ProcessingInstruction::setCSSStyleSheet):
1360         (WebCore::ProcessingInstruction::setXSLStyleSheet):
1361         (WebCore::ProcessingInstruction::parseStyleSheet):
1362         * dom/ProcessingInstruction.h:
1363
1364         * html/HTMLLinkElement.cpp:
1365         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute
1366         is not specified.
1367         (WebCore::HTMLLinkElement::setCSSStyleSheet):
1368         * html/HTMLLinkElement.h:
1369
1370         * html/HTMLStyleElement.cpp:
1371         (WebCore::HTMLStyleElement::childrenChanged):
1372         * ksvg2/svg/SVGStyleElement.cpp:
1373         (WebCore::SVGStyleElement::childrenChanged):
1374         Inherit URL and charset from the document.
1375
1376         * loader/Cache.cpp:
1377         (WebCore::Cache::requestCSSStyleSheet):
1378         * loader/Cache.h:
1379         Adjust for setStyleSheet() renaming.
1380
1381         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
1382         * loader/CachedCSSStyleSheet.cpp:
1383         (WebCore::CachedCSSStyleSheet::ref):
1384         (WebCore::CachedCSSStyleSheet::deref):
1385         (WebCore::CachedCSSStyleSheet::checkNotify):
1386         Pass the encoding to setCSSStyleSheet().
1387
1388         * loader/CachedXSLStyleSheet.cpp:
1389         (WebCore::CachedXSLStyleSheet::ref):
1390         (WebCore::CachedXSLStyleSheet::checkNotify):
1391         * loader/DocLoader.cpp:
1392         (WebCore::DocLoader::requestCSSStyleSheet):
1393         * loader/DocLoader.h:
1394         * page/Frame.cpp:
1395         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
1396         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
1397         * xml/XSLImportRule.cpp:
1398         (WebCore::XSLImportRule::setXSLStyleSheet):
1399         (WebCore::XSLImportRule::loadSheet):
1400         * xml/XSLImportRule.h:
1401         Adjust for setStyleSheet() renaming.
1402
1403 2006-09-30  Rob Buis  <buis@kde.org>
1404
1405         Reviewed by eseidel.
1406
1407         http://bugs.webkit.org/show_bug.cgi?id=11096
1408         Hit testing for polylines fails
1409
1410         Fix Path::contains so it handles filled, non-closed paths too.
1411
1412         * platform/cg/PathCG.cpp:
1413         (WebCore::Path::contains):
1414
1415 2006-09-30  Dave Hyatt  <hyatt@apple.com>
1416
1417         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
1418         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
1419         subframes while the mouse is down.
1420
1421         Reviewed by mitzpettel
1422
1423         * bridge/mac/FrameMac.h:
1424         * bridge/mac/FrameMac.mm:
1425         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
1426         (WebCore::FrameMac::passWheelEventToWidget):
1427         * bridge/mac/FrameViewMac.mm:
1428         (WebCore::FrameView::passMousePressEventToSubframe):
1429         (WebCore::FrameView::passMouseMoveEventToSubframe):
1430         (WebCore::FrameView::passMouseReleaseEventToSubframe):
1431         (WebCore::FrameView::passWheelEventToSubframe):
1432         * page/Frame.cpp:
1433         * page/Frame.h:
1434         * page/FrameView.cpp:
1435         (WebCore::subframeForTargetNode):
1436         (WebCore::FrameView::handleMousePressEvent):
1437         (WebCore::FrameView::handleMouseDoubleClickEvent):
1438         (WebCore::FrameView::handleMouseMoveEvent):
1439         (WebCore::FrameView::handleMouseReleaseEvent):
1440         (WebCore::FrameView::handleWheelEvent):
1441         * page/FrameView.h:
1442         * platform/ScrollBar.h:
1443         (WebCore::ScrollBar::handleMouseMoveEvent):
1444         (WebCore::ScrollBar::handleMouseOutEvent):
1445         * platform/Widget.h:
1446         (WebCore::Widget::handleMouseMoveEvent):
1447         (WebCore::Widget::handleMouseReleaseEvent):
1448         * platform/win/TemporaryLinkStubs.cpp:
1449         (FrameView::passMousePressEventToSubframe):
1450         (FrameView::passMouseMoveEventToSubframe):
1451         (FrameView::passMouseReleaseEventToSubframe):
1452         (FrameView::passWheelEventToSubframe):
1453         (Widget::capturingMouse):
1454         (Widget::setCapturingMouse):
1455         (Widget::capturingTarget):
1456         (Widget::capturingChild):
1457         (Widget::setCapturingChild):
1458         * rendering/RenderView.cpp:
1459         (WebCore::RenderView::paintBoxDecorations):
1460
1461 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
1462
1463         Reviewed by Adele.
1464
1465         Fixes windows bustage:
1466         http://bugs.webkit.org/show_bug.cgi?id=11093
1467
1468         * platform/win/PlatformScrollBar.h:
1469         * platform/win/TemporaryLinkStubs.cpp:
1470         (PlatformScrollBar::PlatformScrollBar):
1471         (ScrollBar::ScrollBar):
1472
1473 2006-09-29  David Hyatt  <hyatt@apple.com>
1474
1475         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
1476         in RenderObject::NodeInfo (and then propagating that Widget to
1477         MouseEventWithHitTestResults).
1478
1479         This allows RenderListBox and RenderBlock to do the same thing when the
1480         mouse is over the scrollbar.
1481
1482         Also land fix to support font-size: 0.
1483
1484         Reviewed by mjs (scrollbar), eric (font-size)
1485
1486         * dom/Document.cpp:
1487         (WebCore::Document::prepareMouseEvent):
1488         * page/Frame.cpp:
1489         (WebCore::Frame::passWidgetMouseDownEventToWidget):
1490         * page/FrameView.cpp:
1491         (WebCore::selectCursor):
1492         (WebCore::FrameView::handleMouseMoveEvent):
1493         (WebCore::FrameView::dispatchMouseEvent):
1494         * page/MouseEventWithHitTestResults.cpp:
1495         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
1496         * page/MouseEventWithHitTestResults.h:
1497         (WebCore::MouseEventWithHitTestResults::scrollbar):
1498         * rendering/RenderBlock.cpp:
1499         (WebCore::RenderBlock::isPointInScrollbar):
1500         (WebCore::RenderBlock::nodeAtPoint):
1501         * rendering/RenderBlock.h:
1502         * rendering/RenderLayer.cpp:
1503         (WebCore::RenderLayer::hitTest):
1504         * rendering/RenderLayer.h:
1505         (WebCore::RenderLayer::getHiddenBehavior):
1506         * rendering/RenderListBox.cpp:
1507         (WebCore::RenderListBox::RenderListBox):
1508         (WebCore::RenderListBox::~RenderListBox):
1509         (WebCore::RenderListBox::isPointInScrollbar):
1510         * rendering/RenderListBox.h:
1511         * rendering/RenderObject.h:
1512         (WebCore::RenderObject::NodeInfo::NodeInfo):
1513         (WebCore::RenderObject::NodeInfo::scrollbar):
1514         (WebCore::RenderObject::NodeInfo::setScrollbar):
1515
1516 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
1517
1518         Reviewed by Adele.
1519
1520         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
1521
1522         * platform/win/ScrollViewWin.cpp:
1523         (WebCore::ScrollView::convertToContainingWindow):
1524         (WebCore::ScrollView::convertFromContainingWindow):
1525         * platform/win/WidgetWin.cpp:
1526         (WebCore::Widget::convertToContainingWindow):
1527         (WebCore::Widget::convertFromContainingWindow):
1528
1529 2006-09-29  Adele Peterson  <adele@apple.com>
1530
1531         Updated with new argument for PlatformScrollBar.
1532
1533         * platform/win/TemporaryLinkStubs.cpp:
1534         (PlatformScrollBar::PlatformScrollBar):
1535
1536 2006-09-29  Adele Peterson  <adele@apple.com>
1537
1538         Reviewed by Hyatt.
1539
1540         Fixing build bustage with cast to int.
1541
1542         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
1543
1544 2006-09-29  Adele Peterson  <adele@apple.com>
1545
1546         Fixing accidental include.
1547
1548         * rendering/RenderListBox.cpp:
1549
1550 2006-09-29  Adele Peterson  <adele@apple.com>
1551
1552         Adding RenderListBox files.
1553
1554         * WebCore.vcproj/WebCore/WebCore.vcproj:
1555
1556 2006-09-29  Adele Peterson  <adele@apple.com>
1557
1558         Reviewed by Adam.
1559
1560         Initial implementation of engine-based list box control.
1561
1562         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
1563
1564         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
1565         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
1566         (WebCore::FrameMac::FrameMac):
1567         (WebCore::FrameMac::handleMousePressEvent):
1568         (WebCore::FrameMac::handleMouseMoveEvent):
1569         (WebCore::FrameMac::mouseDown):
1570
1571         * page/Frame.cpp:
1572         (WebCore::Frame::handleMouseMoveEvent):
1573         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
1574         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
1575         (WebCore::Frame::autoscrollTimerFired): ditto.
1576         (WebCore::Frame::stopAutoscrollTimer): ditto.
1577         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
1578         * page/Frame.h:
1579         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
1580
1581         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
1582         (WebCore::FrameViewPrivate::reset):
1583         (WebCore::FrameView::currentMousePosition):
1584         (WebCore::FrameView::handleMousePressEvent):
1585         (WebCore::FrameView::handleMouseDoubleClickEvent):
1586         (WebCore::selectCursor):
1587         (WebCore::FrameView::handleMouseMoveEvent):
1588         (WebCore::FrameView::handleMouseReleaseEvent):
1589         * page/FrameView.h:
1590
1591         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
1592         * platform/ScrollBar.h:
1593         (WebCore::):
1594         (WebCore::ScrollBar::controlSize):
1595         * platform/mac/PlatformScrollBar.h:
1596         * platform/mac/PlatformScrollBarMac.mm:
1597         (NSControlSizeForScrollBarControlSize):
1598         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
1599         (WebCore::PlatformScrollBar::PlatformScrollBar):
1600
1601         * rendering/RenderBlock.h:
1602         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
1603         * rendering/RenderLayer.h:
1604         * rendering/RenderObject.cpp:
1605         (WebCore::RenderObject::shouldAutoscroll):
1606         (WebCore::RenderObject::autoscroll):
1607         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
1608
1609         * css/html4.css: Added properties for new list boxes.
1610
1611         * html/HTMLOptionElement.cpp:
1612         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
1613         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
1614         * html/HTMLOptionElement.h: Added disabled method.
1615
1616         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
1617         (WebCore::HTMLSelectElement::recalcStyle):
1618         (WebCore::HTMLSelectElement::lastSelectedListIndex):
1619         (WebCore::HTMLSelectElement::deselectItems):
1620         (WebCore::HTMLSelectElement::setSelectedIndex):
1621         (WebCore::HTMLSelectElement::isKeyboardFocusable):
1622         (WebCore::HTMLSelectElement::isMouseFocusable):
1623         (WebCore::HTMLSelectElement::createRenderer):
1624         (WebCore::HTMLSelectElement::recalcListItems):
1625         (WebCore::HTMLSelectElement::setRecalcListItems):
1626         (WebCore::HTMLSelectElement::reset):
1627         (WebCore::HTMLSelectElement::notifyOptionSelected):
1628         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
1629         (WebCore::HTMLSelectElement::nextSelectableListIndex):
1630         (WebCore::HTMLSelectElement::previousSelectableListIndex):
1631         * html/HTMLSelectElement.h:
1632
1633         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
1634         (WebCore::RenderTheme::paint):
1635         (WebCore::RenderTheme::paintBorderOnly):
1636         (WebCore::RenderTheme::paintDecorations):
1637         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
1638         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
1639         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
1640         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
1641         (WebCore::RenderTheme::isControlStyled):
1642         (WebCore::RenderTheme::supportsFocusRing):
1643         * rendering/RenderTheme.h:
1644         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
1645
1646         * rendering/RenderListBox.cpp: Added.
1647         (WebCore::RenderListBox::RenderListBox):
1648         (WebCore::RenderListBox::~RenderListBox):
1649         (WebCore::RenderListBox::setStyle):
1650         (WebCore::RenderListBox::updateFromElement):
1651         (WebCore::RenderListBox::calcMinMaxWidth):
1652         (WebCore::RenderListBox::size):
1653         (WebCore::RenderListBox::numItems):
1654         (WebCore::RenderListBox::calcHeight):
1655         (WebCore::RenderListBox::baselinePosition):
1656         (WebCore::RenderListBox::itemBoundingBoxRect):
1657         (WebCore::RenderListBox::paintObject):
1658         (WebCore::RenderListBox::paintScrollbar):
1659         (WebCore::RenderListBox::paintItemForeground):
1660         (WebCore::RenderListBox::paintItemBackground):
1661         (WebCore::RenderListBox::scrollBarTarget):
1662         (WebCore::RenderListBox::isPointInScrollbar):
1663         (WebCore::RenderListBox::optionAtPoint):
1664         (WebCore::RenderListBox::autoscroll):
1665         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
1666         (WebCore::RenderListBox::scroll):
1667         (WebCore::RenderListBox::valueChanged):
1668         * rendering/RenderListBox.h: Added.
1669         (WebCore::RenderListBox::isListBox):
1670         (WebCore::RenderListBox::selectionChanged):
1671         (WebCore::RenderListBox::setSelectionChanged):
1672         (WebCore::RenderListBox::canHaveChildren):
1673         (WebCore::RenderListBox::renderName):
1674         (WebCore::RenderListBox::setOptionsChanged):
1675         (WebCore::RenderListBox::shouldAutoscroll):
1676         (WebCore::RenderListBox::listIndexIsVisible):
1677
1678 2006-09-29  Beth Dakin  <bdakin@apple.com>
1679
1680         Reviewed by Darin.
1681
1682         We had a bug where html4.css was ignoring Media Queries. In the end
1683         the problem was that we were trying to send a char* to the
1684         MediaQueryEvaluator constructor that expects a String, but the
1685         char* got interpreted as a bool, the wrong constructor was called,
1686         and the media type was never set.
1687
1688         No test case possible since this only affects html4.css
1689
1690         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a
1691         char*
1692         (WebCore::MediaQueryEvaluator):
1693         * css/MediaQueryEvaluator.h: Same.
1694
1695 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
1696
1697         Reviewed by John, Maciej.
1698
1699         Integrated some frame and iframe code. I'm trying to fix up frame ownership
1700         and loading. Reducing the number of different code paths involved
1701         seemed like a good first step.
1702
1703         As a side effect, I fixed a bug where FRAME elements would report their
1704         src attributes as relative, rather than compelete, URLs. (IFRAME elements
1705         had the correct complete URL behavior.)
1706
1707         * html/HTMLFrameElement.cpp:
1708         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
1709         (WebCore::HTMLFrameElement::openURL):
1710             (1) Removed checks that requestFrame does for us
1711             (2) Added isURLAllowed check, to have one clear bottleneck for it
1712             (3) Added viewsource check, to have one clear bottleneck for it
1713         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
1714         method, instead of finding our content frame in our own unique way.
1715         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
1716         since openURL does this for us now.
1717         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
1718         This is what FF does, and it made no sense to have different behaviors
1719         for FRAME and IFRAME elements.
1720         * html/HTMLIFrameElement.cpp:
1721         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
1722         code.
1723         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
1724         HTMLFrameElement now does everything we need.
1725
1726 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
1727
1728         Reviewed by Hyatt.
1729
1730         Fix Qt/Linux build.
1731
1732         * CMakeLists.txt:
1733         * platform/qt/ScrollViewQt.cpp:
1734         (WebCore::ScrollView::convertToContainingWindow):
1735         (WebCore::ScrollView::convertFromContainingWindow):
1736         * platform/qt/TemporaryLinkStubs.cpp:
1737         (WebCore::signedPublicKeyAndChallengeString):
1738         * platform/qt/WidgetQt.cpp:
1739         (WebCore::Widget::convertToContainingWindow):
1740         (WebCore::Widget::convertFromContainingWindow):
1741
1742 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
1743
1744         Reviewed by Tim H.
1745
1746         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
1747         Simplify Internal methods for the auto-generated Objective-C DOM code
1748
1749         - Auto-generate the internal methods for more Objective-C classes.
1750
1751         * WebCore.xcodeproj/project.pbxproj:
1752         * bindings/objc/DOM.mm:
1753         * bindings/objc/DOMCSS.mm:
1754         (-[DOMStyleSheet WebCore::]):
1755         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
1756         (-[DOMCSSRule WebCore::]):
1757         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
1758         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
1759         (-[DOMCSSValue WebCore::]):
1760         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
1761         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1762         * bindings/objc/DOMHTMLAppletElement.mm:
1763         (-[DOMHTMLAppletElement WebCore::]):
1764         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
1765         * bindings/objc/DOMHTMLEmbedElement.mm:
1766         (-[DOMHTMLEmbedElement WebCore::]):
1767         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
1768         * bindings/objc/DOMInternal.h:
1769         * bindings/objc/DOMInternal.mm:
1770         * bindings/scripts/CodeGeneratorObjC.pm:
1771         * css/CSSCharsetRule.idl:
1772         * css/CSSFontFaceRule.idl:
1773         * css/CSSImportRule.idl:
1774         * css/CSSMediaRule.idl:
1775         * css/CSSPageRule.idl:
1776         * css/CSSPrimitiveValue.idl:
1777         * css/CSSStyleRule.idl:
1778         * css/CSSStyleSheet.idl:
1779         * css/CSSUnknownRule.idl:
1780         * css/CSSValueList.idl:
1781         * dom/KeyboardEvent.idl:
1782         * dom/MouseEvent.idl:
1783         * dom/MutationEvent.idl:
1784         * dom/NodeIterator.idl:
1785         * dom/OverflowEvent.idl:
1786         * dom/UIEvent.idl:
1787         * dom/WheelEvent.idl:
1788
1789 2006-09-29  David Harrison  <harrison@apple.com>
1790
1791         Reviewed by John Sullivan.
1792
1793         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
1794         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
1795
1796         Test added
1797         * fast/text/attributed-substring-from-range-001.html
1798
1799         * bridge/mac/FrameMac.mm:
1800         (WebCore::FrameMac::attributedString):
1801         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
1802         Also, add validation of the range.
1803
1804 2006-09-29  Rob Buis  <buis@kde.org>
1805
1806         Reviewed by Maciej.
1807
1808         http://bugs.webkit.org/show_bug.cgi?id=10893
1809         InsertRule can not handle @import statements
1810
1811         Allow @import as part of a css rule.
1812
1813         * css/CSSGrammar.y:
1814
1815 2006-09-28  David Hyatt  <hyatt@apple.com>
1816
1817         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
1818
1819         * bridge/mac/FrameMac.mm:
1820         (WebCore::FrameMac::eventMayStartDrag):
1821         (WebCore::FrameMac::dragHysteresisExceeded):
1822         (WebCore::FrameMac::mouseDown):
1823         (WebCore::FrameMac::shouldDragAutoNode):
1824         (WebCore::FrameMac::sendContextMenuEvent):
1825         * bridge/mac/WebCoreFrameBridge.mm:
1826         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
1827
1828 2006-09-28  Dave Hyatt  <hyatt@apple.com>
1829
1830         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
1831         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
1832         view.
1833
1834         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
1835         the patch after review, once I realized that these new functions essentially do the same thing.)
1836
1837         * dom/EventTargetNode.cpp:
1838         (WebCore::EventTargetNode::dispatchMouseEvent):
1839         (WebCore::EventTargetNode::dispatchWheelEvent):
1840         * page/Frame.cpp:
1841         (WebCore::Frame::selectClosestWordFromMouseEvent):
1842         (WebCore::Frame::handleMousePressEventTripleClick):
1843         (WebCore::Frame::handleMousePressEventSingleClick):
1844         (WebCore::Frame::handleMouseMoveEvent):
1845         (WebCore::Frame::handleMouseReleaseEvent):
1846         * page/FrameView.cpp:
1847         (WebCore::FrameView::handleMousePressEvent):
1848         (WebCore::selectCursor):
1849         (WebCore::FrameView::dispatchDragEvent):
1850         (WebCore::FrameView::prepareMouseEvent):
1851         (WebCore::FrameView::handleWheelEvent):
1852         * platform/ScrollView.h:
1853         * platform/Widget.cpp:
1854         (WebCore::Widget::convertToContainingWindow):
1855         * platform/Widget.h:
1856         * platform/mac/ScrollViewMac.mm:
1857         (WebCore::ScrollView::convertToContainingWindow):
1858         (WebCore::ScrollView::convertFromContainingWindow):
1859         * platform/mac/WidgetMac.mm:
1860         (WebCore::Widget::convertToContainingWindow):
1861         (WebCore::Widget::convertFromContainingWindow):
1862         * platform/win/ScrollViewWin.cpp:
1863         (WebCore::ScrollView::convertToContainingWindow):
1864         (WebCore::ScrollView::convertFromContainingWindow):
1865         * rendering/RenderLayer.cpp:
1866         (WebCore::RenderLayer::resize):
1867
1868 2006-09-28  Alice Liu  <alice.liu@apple.com>
1869
1870         Build fix by adding missing files for CommandByName
1871
1872         * WebCore.xcodeproj/project.pbxproj:
1873
1874 2006-09-28  Alice Liu  <alice.liu@apple.com>
1875
1876         Adding CommandByName files to the vcproj
1877
1878         * WebCore.vcproj/WebCore/WebCore.vcproj:
1879
1880 2006-09-28  Alice Liu  <alice.liu@apple.com>
1881
1882         Reviewed by Adam Roben.
1883
1884         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc.
1885         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
1886         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
1887
1888         * editing/CommandByName.cpp: Added.
1889         Added a command class that hangs off the frame so the frame can call commands more easily.
1890         (WebCore::Frame::commandImp):
1891         (WebCore::Frame::execCopy):
1892         (WebCore::Frame::execCut):
1893         (WebCore::Frame::execDelete):
1894         (WebCore::Frame::execForwardDelete):
1895         (WebCore::Frame::execPaste):
1896         (WebCore::Frame::execMoveLeft):
1897         (WebCore::Frame::execMoveRight):
1898         (WebCore::Frame::execMoveUp):
1899         (WebCore::Frame::execMoveDown):
1900         (WebCore::Frame::execSelectAll):
1901         (WebCore::Frame::execSelectLeft):
1902         (WebCore::Frame::execSelectRight):
1903         (WebCore::Frame::execSelectUp):
1904         (WebCore::Frame::execSelectDown):
1905         (WebCore::Frame::enabled):
1906         (WebCore::Frame::enabledAnySelection):
1907         (WebCore::Frame::enabledAnyEditableSelection):
1908         (WebCore::Frame::enabledPaste):
1909         (WebCore::Frame::enabledAnyRangeSelection):
1910         (WebCore::Frame::enabledAnyEditableRangeSelection):
1911         (WebCore::Frame::createCommandDictionary):
1912         (WebCore::Frame::Command::):
1913         (WebCore:::m_frame):
1914         (WebCore::CommandByName::execCommand):
1915         * editing/CommandByName.h: Added.
1916         * page/Frame.cpp:
1917         Added implementation of accessor for CommandByName member
1918         (WebCore::Frame::command):
1919         * page/Frame.h:
1920         Added accessor for CommandByName member
1921         * page/FramePrivate.h:
1922         Added a CommandByName member
1923         (WebCore::FramePrivate::FramePrivate):
1924         * platform/PlatformMouseEvent.h:
1925         Changed constructor prototype
1926         * platform/StringImpl.cpp:
1927         Exposing getWordBreakIterator to be used elsewhere
1928         (WebCore::getWordBreakIterator):
1929         * platform/StringImpl.h:
1930         Exposing getWordBreakIterator to be used elsewhere
1931         * platform/win/MouseEventWin.cpp:
1932         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
1933         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1934
1935 2006-09-28  Adam Roben  <aroben@apple.com>
1936
1937         Reviewed by Adele.
1938
1939         Remove no-longer-used PopUpButton.
1940
1941         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
1942         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
1943         PopUpButtonMac.mm
1944         * platform/PopUpButton.h: Removed.
1945         * platform/mac/PopUpButtonMac.mm: Removed.
1946         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
1947         * rendering/DeprecatedRenderSelect.cpp: Change #include of
1948         PopUpButton.h to ListBox.h
1949
1950 2006-09-28  Darin Adler  <darin@apple.com>
1951
1952         Reviewed by Alice.
1953
1954         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
1955           10% perf. regression (copying strings while decoding)
1956
1957         Use Vector<UChar> instead of String when building up the decoded string in
1958         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
1959         String grows the buffer every single time that append is called. Using
1960         Vector::append instead of String::append also avoids constructing a string
1961         each time just to append and a questionable copy that is done inside the
1962         String::append function which also contributed to the slowness.
1963
1964         * platform/PlatformString.h:
1965         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
1966         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
1967         allocation.
1968         * platform/StringImpl.h:
1969         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
1970
1971         * platform/StreamingTextDecoder.h:
1972         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
1973         Change to use a Vector<UChar> instead of a String, since vectors have better
1974         resizing performance (they store a separate capacity).
1975
1976         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
1977         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
1978         Change to use Vector<UChar> instead of String and then create a string at
1979         the end of the process using the new adopt function.
1980
1981 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
1982
1983         Reviewed by Tim H.
1984
1985         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
1986         Auto-generate more SVG Objective-C bindings
1987
1988         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean,
1989           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
1990           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
1991           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
1992           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
1993           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests,
1994           and DOMSVGTransformable.
1995
1996         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
1997           parent interfaces and the SVG animated classes.
1998
1999         - Corrects CodeGenerator.pm to only skip the first parent for the main
2000           interface.
2001
2002         * DerivedSources.make:
2003         * WebCore.xcodeproj/project.pbxproj:
2004         * bindings/objc/DOMInternal.h:
2005         * bindings/objc/DOMSVG.h:
2006         * bindings/scripts/CodeGenerator.pm:
2007         * bindings/scripts/CodeGeneratorObjC.pm:
2008         * ksvg2/svg/SVGAnimatedAngle.idl:
2009         * ksvg2/svg/SVGAnimatedBoolean.idl:
2010         * ksvg2/svg/SVGAnimatedEnumeration.idl:
2011         * ksvg2/svg/SVGAnimatedInteger.idl:
2012         * ksvg2/svg/SVGAnimatedLength.idl:
2013         * ksvg2/svg/SVGAnimatedLengthList.idl:
2014         * ksvg2/svg/SVGAnimatedNumber.idl:
2015         * ksvg2/svg/SVGAnimatedPathData.idl:
2016         * ksvg2/svg/SVGAnimatedString.idl:
2017         * ksvg2/svg/SVGAnimatedTransformList.idl:
2018         * ksvg2/svg/SVGExternalResourcesRequired.idl:
2019         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
2020         * ksvg2/svg/SVGFitToViewBox.idl:
2021         * ksvg2/svg/SVGLangSpace.idl:
2022         * ksvg2/svg/SVGLocatable.idl:
2023         * ksvg2/svg/SVGMetadataElement.idl:
2024         * ksvg2/svg/SVGStringList.idl:
2025         * ksvg2/svg/SVGStylable.idl:
2026         * ksvg2/svg/SVGStyleElement.idl:
2027         * ksvg2/svg/SVGTests.idl:
2028         * ksvg2/svg/SVGTransformable.idl:
2029         * ksvg2/svg/SVGURIReference.idl:
2030         * ksvg2/svg/SVGUnitTypes.idl:
2031         * ksvg2/svg/SVGZoomAndPan.idl:
2032
2033 2006-09-28  Brady Eidson  <beidson@apple.com>
2034
2035         Reviewed by Mitz Pettel!!!
2036
2037         Change the error code check for common functions from SQLResultOk to SQLResultDone
2038
2039         * loader/icon/IconDatabase.cpp:
2040         (WebCore::IconDatabase::forgetPageURLQuery):
2041         (WebCore::IconDatabase::setIconIDForPageURLQuery):
2042         (WebCore::IconDatabase::addIconForIconURLQuery):
2043
2044 2006-09-28  Dave Hyatt  <hyatt@apple.com>
2045
2046         Just eliminate MapWindowPoints usage and use the HWND as
2047         the viewport.
2048
2049         * platform/win/MouseEventWin.cpp:
2050         (WebCore::positionForEvent):
2051         * platform/win/ScrollViewWin.cpp:
2052         (WebCore::ScrollView::viewportToContents):
2053         (WebCore::ScrollView::contentsToViewport):
2054
2055 2006-09-27  David Hyatt  <hyatt@apple.com>
2056
2057         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
2058         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
2059         scrollbars to provide hover feedback if needed.
2060
2061         Reviewed by Eric
2062
2063         * page/FrameView.cpp:
2064         (WebCore::selectCursor):
2065         (WebCore::FrameView::handleMouseMoveEvent):
2066         * platform/ScrollBar.h:
2067         (WebCore::ScrollBar::mouseMoved):
2068
2069 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
2070
2071         Reviewed by Maciej and Adam, landed by Adam
2072
2073         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
2074         Windows build is busted
2075
2076         * platform/win/TemporaryLinkStubs.cpp:
2077         (ScrollView::paint):
2078         (ScrollView::themeChanged):
2079
2080 2006-09-27  Eric Seidel  <eric@eseidel.com>
2081
2082         Reviewed by mitz.
2083
2084         paths with no fill specified default to black but do not recieve paint-related mouse events
2085         http://bugs.webkit.org/show_bug.cgi?id=11069
2086         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
2087
2088         Test: svg/custom/hover-default-fill.svg
2089
2090         * kcanvas/RenderPath.cpp:
2091         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
2092         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
2093         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2094         (WebCore::KSVGPainterFactory::isFilled): remove null check
2095         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
2096         (WebCore::KSVGPainterFactory::isStroked): remove null check
2097         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
2098         * ksvg2/svg/SVGPaint.cpp:
2099         (WebCore::SVGPaint::defaultFill): added.
2100         (WebCore::SVGPaint::defaultStroke): added.
2101         * ksvg2/svg/SVGPaint.h:
2102
2103 2006-09-27  Rob Buis  <buis@kde.org>
2104
2105         Reviewed by eseidel.
2106
2107         http://bugs.webkit.org/show_bug.cgi?id=11015
2108         SVG handles em units incorrectly
2109
2110         Calculate viewport coordinates at layout time, since
2111         at this point the font size is known and lengths depending
2112         on font sizes can be calculated correctly.
2113
2114         * kcanvas/RenderSVGContainer.cpp:
2115         (WebCore::RenderSVGContainer::layout):
2116         (WebCore::RenderSVGContainer::viewport):
2117         (WebCore::RenderSVGContainer::calcViewport):
2118         * kcanvas/RenderSVGContainer.h:
2119         * ksvg2/svg/SVGLength.cpp:
2120         (WebCore::SVGLength::updateValue):
2121         * ksvg2/svg/SVGMarkerElement.cpp:
2122         (WebCore::SVGMarkerElement::createRenderer):
2123         * ksvg2/svg/SVGSVGElement.cpp:
2124         (WebCore::SVGSVGElement::createRenderer):
2125         (WebCore::SVGSVGElement::attributeChanged):
2126         * ksvg2/svg/SVGSVGElement.h:
2127
2128 2006-09-27  Eric Seidel  <eric@eseidel.com>
2129
2130         Reviewed by darin.
2131
2132         Change our invalid-fill error behavior to match Opera (and soon Firefox)
2133         http://bugs.webkit.org/show_bug.cgi?id=11017
2134
2135         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2136         (WebCore::KSVGPainterFactory::isFilled):
2137         (WebCore::KSVGPainterFactory::fillPaintServer):
2138         (WebCore::KSVGPainterFactory::isStroked):
2139         (WebCore::KSVGPainterFactory::strokePaintServer):
2140
2141 2006-09-27  Brady Eidson  <beidson@apple.com>
2142
2143         Build fix
2144
2145         * loader/icon/IconDatabase.cpp:
2146         (WebCore::readySQLStatement):
2147
2148 2006-09-27  Brady Eidson  <beidson@apple.com>
2149
2150         Reviewed by Adam
2151
2152         In very specific circumstances, prepared SQLStatements can become invalid without
2153         any warning.  This checks for that state and re-prepares the statement and also
2154         adds more aggressive error-checking everywhere these statements are used.
2155
2156         * loader/icon/IconDatabase.cpp:
2157         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
2158         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
2159         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
2160         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
2161         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
2162         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
2163         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
2164         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
2165         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
2166         * loader/icon/SQLStatement.cpp:
2167         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
2168         * loader/icon/SQLStatement.h:
2169
2170 2006-09-26  Darin Adler  <darin@apple.com>
2171
2172         Reviewed by Steve.
2173
2174         - clean up options for font code path
2175
2176         * platform/Font.h:
2177         * platform/Font.cpp:
2178         (WebCore::Font::setCodePath): Added. Replaces boolean version.
2179         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
2180
2181         * platform/mac/WebCoreTextRenderer.mm:
2182         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
2183
2184 2006-09-26  John Sullivan  <sullivan@apple.com>
2185
2186         Reviewed by Darin
2187
2188         * bridge/mac/WebCoreFrameBridge.h:
2189         * bridge/mac/WebCoreFrameBridge.mm:
2190         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
2191         Added limit parameter, passed down to Frame
2192
2193         * page/Frame.h:
2194         * page/Frame.cpp:
2195         (WebCore::Frame::markAllMatchesForText):
2196         Added limit parameter. Stop the search if it hits limit.
2197
2198 2006-09-26  Sean Gies  <seangies@apple.com>
2199
2200         Reviewed by Brady Eidson.
2201
2202         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
2203
2204 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
2205
2206         Reviewed by john
2207
2208         <rdar://problem/4747695>
2209         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
2210
2211         * editing/DeleteSelectionCommand.cpp:
2212         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
2213         to select special elements that are fully selected after expansion
2214         moves to positions that are visually distinct from the originals.
2215         * editing/InsertListCommand.cpp:
2216         (WebCore::InsertListCommand::doApply): If the content of the list
2217         item will be moved into another list, put it in a list item.
2218
2219 2006-09-26  Geoffrey Garen <ggaren@apple.com>
2220
2221         Reviewed by Darin.
2222
2223         Temporary work-around for frame lifetime issue.
2224
2225         * page/Frame.cpp:
2226         (WebCore::Frame::clear):
2227         (WebCore::Frame::disconnectOwnerElement):
2228
2229 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
2230
2231         Reviewed by Tim H.
2232
2233         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
2234         Auto-generate DOMSVGElement for the Objective-C bindings
2235
2236         - Auto-generates DOMSVGElement.
2237
2238         - Make SVGExceptions work like all the other ExceptionCode
2239           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
2240           and SVGExceptionMax.
2241
2242         * DerivedSources.make:
2243         * WebCore.xcodeproj/project.pbxproj:
2244         * bindings/js/kjs_binding.cpp:
2245         (KJS::):
2246         (KJS::setDOMException):
2247         * bindings/objc/DOMInternal.h:
2248         * bindings/objc/DOMInternal.mm:
2249         (raiseDOMException):
2250         * bindings/objc/DOMSVG.h:
2251         * bindings/objc/DOMSVGExecption.h: Added.
2252         * ksvg2/ksvg.h:
2253         * ksvg2/svg/SVGElement.cpp:
2254         (WebCore::SVGElement::setId):
2255         (WebCore::SVGElement::setXmlbase):
2256         * ksvg2/svg/SVGElement.h:
2257         * ksvg2/svg/SVGElement.idl:
2258         * ksvg2/svg/SVGException.h: Added.
2259         (WebCore::):
2260
2261 2006-09-26  Eric Seidel  <eric@eseidel.com>
2262
2263         Reviewed by Tim H.
2264
2265         viewbox parser does not allow <tab> as a delimiter
2266         http://bugs.webkit.org/show_bug.cgi?id=11014
2267
2268         Test: svg/hixie/viewbox/003.xml
2269
2270         * ksvg2/svg/svgpathparser.cpp:
2271         (WebCore::isWhitespace): new function
2272         (WebCore::skipOptionalSpaces):
2273         (WebCore::skipOptionalSpacesOrComma):
2274
2275 2006-09-26  Eric Seidel  <eric@eseidel.com>
2276
2277         Reviewed by Tim H.
2278
2279         SVGDocument::createElement does not create elements in the SVG namespace
2280         http://bugs.webkit.org/show_bug.cgi?id=10932
2281
2282         Test: svg/custom/createelement.svg
2283
2284         * ksvg2/svg/SVGDocument.cpp:
2285         (WebCore::SVGDocument::createElement):
2286         * ksvg2/svg/SVGDocument.h:
2287
2288 2006-09-26  Eric Seidel  <eric@eseidel.com>
2289
2290         Reviewed by Tim H.
2291
2292         RenderPath::nodeAtPoint does not respect stroke width
2293         http://bugs.webkit.org/show_bug.cgi?id=10829
2294
2295         Test: svg/custom/stroke-width-click.svg
2296
2297         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
2298         (WebCore::RenderPath::strokeContains):
2299         * kcanvas/device/quartz/QuartzSupport.h:
2300         * kcanvas/device/quartz/QuartzSupport.mm:
2301
2302 2006-09-26  Eric Seidel  <eric@eseidel.com>
2303
2304         Reviewed by mitz.
2305
2306         Bring animation back to life
2307         http://bugs.webkit.org/show_bug.cgi?id=11021
2308
2309         Register/unregister SVGSVGElements as time containers on insertion/removal.
2310         Replace uses of DeprecatedString with String in SVGAnimationElement
2311         Various whitespace clean-up.
2312
2313         * ksvg2/misc/KSVGTimeScheduler.cpp:
2314         (WebCore::SVGTimer::notifyAll):
2315         * ksvg2/misc/SVGDocumentExtensions.cpp:
2316         (WebCore::SVGDocumentExtensions::startAnimations):
2317         (WebCore::SVGDocumentExtensions::pauseAnimations):
2318         (WebCore::SVGDocumentExtensions::unpauseAnimations):
2319         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2320         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2321         (WebCore::SVGAnimateTransformElement::parseTransformValue):
2322         * ksvg2/svg/SVGAnimateTransformElement.h:
2323         * ksvg2/svg/SVGAnimationElement.cpp:
2324         (WebCore::SVGAnimationElement::SVGAnimationElement):
2325         (WebCore::SVGAnimationElement::parseMappedAttribute):
2326         (WebCore::SVGAnimationElement::parseClockValue):
2327         (WebCore::SVGAnimationElement::targetAttribute):
2328         (WebCore::SVGAnimationElement::setTargetAttribute):
2329         (WebCore::SVGAnimationElement::attributeName):
2330         * ksvg2/svg/SVGAnimationElement.h:
2331         (WebCore::SVGAnimationElement::rendererIsNeeded):
2332         * ksvg2/svg/SVGSVGElement.cpp:
2333         (WebCore::SVGSVGElement::getScreenCTM):
2334         (WebCore::SVGSVGElement::createRenderer):
2335         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
2336         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
2337         * ksvg2/svg/SVGSVGElement.h:
2338         * ksvg2/svg/SVGSetElement.cpp:
2339         (WebCore::SVGSetElement::handleTimerEvent):
2340         * ksvg2/svg/SVGURIReference.cpp:
2341         (WebCore::SVGURIReference::getTarget):
2342         * ksvg2/svg/SVGURIReference.h:
2343
2344 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
2345
2346         Reviewed by mitzpettel.
2347
2348         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
2349         No-SVG build broken since r16549
2350
2351         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
2352
2353         * css/cssparser.cpp:
2354         (WebCore::CSSParser::parseValue):
2355         * css/cssstyleselector.cpp:
2356         (WebCore::CSSStyleSelector::applyProperty):
2357         * page/FrameView.cpp:
2358         (WebCore::selectCursor):
2359         * platform/qt/GraphicsContextQt.cpp:
2360
2361 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
2362
2363         Reviewed by Maciej.
2364
2365         http://bugs.webkit.org/show_bug.cgi?id=10820
2366         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
2367
2368         (Originally written by Eric Seidel).
2369
2370         * bindings/js/kjs_window.cpp:
2371         (KJS::floatFeature):
2372         * ksvg2/svg/SVGAngle.cpp:
2373         (SVGAngle::setValueAsString):
2374         * ksvg2/svg/SVGAnimationElement.cpp:
2375         (SVGAnimationElement::parseMappedAttribute):
2376         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2377         (SVGComponentTransferFunctionElement::parseMappedAttribute):
2378         * ksvg2/svg/SVGFECompositeElement.cpp:
2379         (WebCore::SVGFECompositeElement::parseMappedAttribute):
2380         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2381         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
2382         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2383         (SVGFEDisplacementMapElement::parseMappedAttribute):
2384         * ksvg2/svg/SVGFELightElement.cpp:
2385         (SVGFELightElement::parseMappedAttribute):
2386         * ksvg2/svg/SVGFEOffsetElement.cpp:
2387         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
2388         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
2389         (SVGFESpecularLightingElement::parseMappedAttribute):
2390         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2391         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
2392         * ksvg2/svg/SVGStopElement.cpp:
2393         (SVGStopElement::parseMappedAttribute):
2394         * platform/AtomicString.h:
2395         (WebCore::AtomicString::toDouble):
2396         * platform/PlatformString.h:
2397         * platform/String.cpp:
2398         (WebCore::String::toDouble):
2399         * platform/StringImpl.cpp:
2400         (WebCore::StringImpl::toDouble):
2401         * platform/StringImpl.h:
2402         * rendering/DeprecatedSlider.cpp:
2403         (WebCore::DeprecatedSlider::updateFromElement):
2404         * xml/XPathGrammar.y:
2405
2406 2006-09-25  David Harrison  <harrison@apple.com>
2407
2408         Reviewed by Tim Omernick and Tim Hatcher.
2409
2410         <rdar://problem/4717965> Text Field text parameterized attributes should work
2411         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
2412
2413         * bridge/mac/WebCoreAXObject.mm:
2414         (-[WebCoreAXObject accessibilityAttributeValue:]):
2415         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
2416
2417         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
2418         Cleaned up. Added text field and text area parameterzed attributes.
2419
2420         (-[WebCoreAXObject doAXLineForTextMarker:]):
2421         Fixed to be zero-based and to deal with the first position properly.
2422
2423         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
2424         Minor formatting.
2425
2426         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
2427         (-[WebCoreAXObject indexForTextMarker:]):
2428         (-[WebCoreAXObject textMarkerRangeForRange:]):
2429         (-[WebCoreAXObject rangeForTextMarkerRange:]):
2430         New utility methods.
2431
2432         (-[WebCoreAXObject doAXLineForIndex:]):
2433         (-[WebCoreAXObject doAXRangeForLine:]):
2434         (-[WebCoreAXObject doAXStringForRange:]):
2435         (-[WebCoreAXObject doAXRangeForPosition:]):
2436         (-[WebCoreAXObject doAXRangeForIndex:]):
2437         (-[WebCoreAXObject doAXBoundsForRange:]):
2438         (-[WebCoreAXObject doAXAttributedStringForRange:]):
2439         (-[WebCoreAXObject doAXRTFForRange:]):
2440         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
2441         Implement text field and text area parameterized attributes.
2442
2443         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
2444         Added text field and text area parameterzed attributes.
2445
2446         * rendering/RenderTextControl.h:
2447         Made indexForVisiblePosition() and visiblePositionForIndex() public.
2448
2449 2006-09-25  Adam Roben  <aroben@apple.com>
2450
2451         Reviewed by Brady.
2452
2453         Build fixes.
2454
2455         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
2456         * platform/ResourceLoader.h: Store whether a particular job
2457         has received a response within the ResourceLoader object itself, since
2458         it's possible that we will enter the InternetReadFileExA while loop
2459         twice for the same job.
2460         * platform/ResourceLoaderInternal.h: Add private instance variable to
2461         store whether we've received a response.
2462         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2463         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
2464         directives.
2465         * platform/win/ResourceLoaderWin.cpp:
2466         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
2467         whether it has received a response instead of assuming it hasn't.
2468         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
2469         (WebCore::ResourceLoader::hasReceivedResponse): Added.
2470         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
2471         setProportion
2472         (ScrollBar::setProportion):
2473
2474 2006-09-25  Brady Eidson  <beidson@apple.com>
2475
2476         Requested by ggaren
2477
2478         Disabled IconDatabase logging by default
2479
2480         * platform/Logging.cpp:
2481         (WebCore::):
2482
2483 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
2484
2485         Build fix
2486
2487         * platform/cf/ResourceLoaderCFNet.cpp:
2488         (WebCore::willCacheResponse):
2489
2490 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
2491
2492         Reviewed by john
2493
2494         <http://bugs.webkit.org/show_bug.cgi?id=11002>
2495         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
2496
2497         * editing/IndentOutdentCommand.cpp:
2498         (WebCore::IndentOutdentCommand::indentRegion): Special case
2499         an empty root editable element.
2500
2501 2006-09-25  Brady Eidson  <beidson@apple.com>
2502
2503         Reviewed by Steve
2504
2505         Math error in SystemTimeWin
2506
2507         * platform/win/SystemTimeWin.cpp:
2508         (WebCore::currentTime):
2509
2510 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
2511
2512         Reviewed by Eric.
2513
2514         Whitespace cleanup; rename *job variables to *loader.
2515
2516         * bindings/js/JSXMLHttpRequest.cpp:
2517         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
2518         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
2519         (KJS::JSXMLHttpRequestConstructorImp::construct):
2520         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
2521         (KJS::JSXMLHttpRequest::getValueProperty):
2522         (KJS::JSXMLHttpRequest::put):
2523         (KJS::JSXMLHttpRequest::putValueProperty):
2524         (KJS::JSXMLHttpRequest::mark):
2525         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
2526         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
2527         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
2528         * bindings/js/JSXMLHttpRequest.h:
2529         (KJS::JSXMLHttpRequest::toBoolean):
2530         * xml/xmlhttprequest.cpp:
2531         (WebCore::XMLHttpRequest::XMLHttpRequest):
2532         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
2533         (WebCore::XMLHttpRequest::send):
2534         (WebCore::XMLHttpRequest::abort):
2535         (WebCore::XMLHttpRequest::receivedAllData):
2536         (WebCore::XMLHttpRequest::receivedData):
2537         * xml/xmlhttprequest.h:
2538         (WebCore::):
2539
2540 2006-09-25  Timothy Hatcher  <timothy@apple.com>
2541
2542         Reviewed by Brady.
2543
2544         - Deprecate the rest of the old-style methods that are not generated.
2545         - Add @property syntax to DOMRange.
2546
2547         * WebCore.xcodeproj/project.pbxproj:
2548         * bindings/objc/DOM.mm:
2549         (-[DOMRange setStart:offset:]):
2550         (-[DOMRange setEnd:offset:]):
2551         (-[DOMRange compareBoundaryPoints:sourceRange:]):
2552         (-[DOMRange setStart::]):
2553         (-[DOMRange setEnd::]):
2554         (-[DOMRange compareBoundaryPoints::]):
2555         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2556         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2557         (-[DOMDocument createNodeIterator::::]):
2558         (-[DOMDocument createTreeWalker::::]):
2559         * bindings/objc/DOMCSS.h:
2560         * bindings/objc/DOMCSS.mm:
2561         (-[DOMDocument getComputedStyle:pseudoElement:]):
2562         (-[DOMDocument getComputedStyle::]):
2563         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
2564         * bindings/objc/DOMExtensions.h:
2565         * bindings/objc/DOMHTML.h:
2566         * bindings/objc/DOMRange.h:
2567         * bindings/objc/DOMTraversal.h:
2568
2569 2006-09-25  Eric Seidel  <eric@eseidel.com>
2570
2571         Reviewed by mjs.
2572
2573         Outermost <svg> element should clip to viewport
2574         http://bugs.webkit.org/show_bug.cgi?id=11007
2575
2576         Test: svg/custom/viewport-clip.svg
2577
2578         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
2579
2580 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
2581
2582         Reviewed by Maciej.
2583
2584         * css/MediaList.cpp:
2585         Remove unused header.
2586
2587         * dom/Document.cpp:
2588         (WebCore::Document::clear):
2589         Use clear instead of iterating through the list of event listeners, removing each one.
2590         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
2591
2592         * html/HTMLKeygenElement.cpp:
2593         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
2594         (WebCore::HTMLKeygenElement::appendFormData):
2595         Update due to changes in the SSL key generator.
2596
2597         * ksvg2/svg/SVGAngle.cpp:
2598         Remove unused header.
2599
2600         * ksvg2/svg/SVGAnimationElement.cpp:
2601         (SVGAnimationElement::parseMappedAttribute):
2602         Rename methods and pass Strings instead of DeprecatedStrings to
2603         parseSeparatedList.
2604
2605         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2606         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2607         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2608         * ksvg2/svg/SVGFEMergeElement.cpp:
2609         * ksvg2/svg/SVGFEOffsetElement.cpp:
2610         Remove unused headers.
2611
2612         * ksvg2/svg/SVGHelper.cpp:
2613         (WebCore::SVGHelper::parseSeparatedList):
2614         * ksvg2/svg/SVGHelper.h:
2615         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
2616         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
2617
2618         * ksvg2/svg/SVGLengthList.cpp:
2619         (WebCore::SVGLengthList::parse):
2620         * ksvg2/svg/SVGLengthList.h:
2621         Use Vector<String> instead of DeprecatedStringList.
2622
2623         * loader/Cache.cpp:
2624         (WebCore::Cache::requestImage):
2625         (WebCore::Cache::requestStyleSheet):
2626         (WebCore::Cache::requestScript):
2627         (WebCore::Cache::requestXSLStyleSheet):
2628         (WebCore::Cache::requestXBLDocument):
2629         (WebCore::Cache::remove):
2630         (WebCore::Cache::get):
2631         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
2632
2633         * loader/DocLoader.cpp:
2634         (WebCore::DocLoader::needReload):
2635         * loader/DocLoader.h:
2636         Use a HashSet instead of DeprecatedStringList.
2637
2638         * page/FrameView.h:
2639         Remove declarations that have no functions.
2640
2641         * platform/SSLKeyGenerator.h:
2642         * platform/mac/SSLKeyGeneratorMac.mm:
2643         (WebCore::supportedKeySizes):
2644         (WebCore::signedPublicKeyAndChallengeString):
2645         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
2646         DeprecatedString.
2647
2648 2006-09-25  Dave Hyatt  <hyatt@apple.com>
2649
2650         Shunt the RenderTheme world transform adoption between
2651         Cairo and Windows into getWindowsContext and move the method
2652         out of GraphicsContextCairo and into GraphicsContextWin.
2653
2654         * ChangeLog:
2655         * WebCore.vcproj/WebCore/WebCore.vcproj:
2656         * platform/cairo/GraphicsContextCairo.cpp:
2657         * platform/win/GraphicsContextWin.cpp: Added.
2658         (WebCore::GraphicsContext::getWindowsContext):
2659         (WebCore::GraphicsContext::releaseWindowsContext):
2660         * rendering/RenderThemeWin.cpp:
2661         (WebCore::prepareForDrawing):
2662
2663 2006-09-24  Eric Seidel  <eric@eseidel.com>
2664
2665         Reviewed by hyatt.
2666
2667         <svg:a> cannot be styled with a:hover
2668         http://bugs.webkit.org/show_bug.cgi?id=11005
2669
2670         Test: svg/hixie/cascade/002.xml
2671
2672         * css/cssstyleselector.cpp:
2673         (WebCore::checkPseudoState):
2674
2675 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
2676
2677         Reviewed by Tim H.
2678
2679         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
2680         SVG needs Obj-C DOM bindings
2681
2682         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
2683           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
2684           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
2685           DOMSVGTransformList.
2686
2687         * DerivedSources.make:
2688         * WebCore.xcodeproj/project.pbxproj:
2689         * bindings/objc/DOMInternal.h:
2690         * bindings/objc/DOMSVG.h: Added.
2691         * ksvg2/svg/SVGAngle.idl:
2692         * ksvg2/svg/SVGLength.idl:
2693         * ksvg2/svg/SVGLengthList.idl:
2694         * ksvg2/svg/SVGMatrix.idl:
2695         * ksvg2/svg/SVGPathSeg.idl:
2696         * ksvg2/svg/SVGPathSegList.idl:
2697         * ksvg2/svg/SVGTransform.idl:
2698         * ksvg2/svg/SVGTransformList.idl:
2699
2700 2006-09-24  Rob Buis  <buis@kde.org>
2701
2702         Reviewed by eseidel.
2703
2704         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
2705         WebKit does not handle fallback custom cursors
2706         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
2707         WebKit does not properly handle SVG <cursor> element
2708
2709         Add support for svg cursor images. Also make sure hotspot
2710         settings are handled correctly. Add tests for handling of css3
2711         cursor syntax with hotspots in strict and quirks mode. Finally
2712         implement fallback.
2713
2714         * WebCore.xcodeproj/project.pbxproj:
2715         * css/CSSComputedStyleDeclaration.cpp:
2716         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2717         * css/CSSCursorImageValue.cpp: Added.
2718         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
2719         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
2720         * css/CSSCursorImageValue.h: Added.
2721         (WebCore::CSSCursorImageValue::hotspot):
2722         * css/cssparser.cpp:
2723         (WebCore::CSSParser::parseValue):
2724         * css/cssstyleselector.cpp:
2725         (WebCore::CSSStyleSelector::applyProperty):
2726         * ksvg2/svg/SVGCursorElement.cpp:
2727         * manual-tests/css3-cursor-fallback-quirks.html: Added.
2728         * manual-tests/css3-cursor-fallback-strict.html: Added.
2729         * manual-tests/cursorfallback.xml: Added.
2730         * page/FrameView.cpp:
2731         (WebCore::selectCursor):
2732         * platform/Cursor.h:
2733         * platform/mac/CursorMac.mm:
2734         (WebCore::createCustomCursor):
2735         (WebCore::Cursor::Cursor):
2736         * platform/qt/CursorQt.cpp:
2737         (WebCore::Cursor::Cursor):
2738         * rendering/RenderStyle.cpp:
2739         (WebCore::StyleInheritedData::StyleInheritedData):
2740         (WebCore::StyleInheritedData::operator==):
2741         (WebCore::RenderStyle::diff):
2742         (WebCore::RenderStyle::addCursor):
2743         (WebCore::RenderStyle::addSVGCursor):
2744         (WebCore::RenderStyle::setCursorList):
2745         (WebCore::RenderStyle::clearCursorList):
2746         * rendering/RenderStyle.h:
2747         (WebCore::CursorData::CursorData):
2748         (WebCore::CursorList::operator[]):
2749         (WebCore::CursorList::size):
2750         (WebCore::CursorList::append):
2751         (WebCore::RenderStyle::cursors):
2752
2753 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
2754
2755         Reviewed by Tim H.
2756
2757         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
2758         Auto-generate the internal methods interfaces for the Objective-C bindings
2759
2760         - Auto-generate the internal method declarations into their own files
2761           named in the form DOMFooBarInternal.h for class DOMFooBar.
2762
2763         - Remove all use of DOM_cast from code.
2764
2765         - Assorted cleanups.
2766
2767         * WebCore.xcodeproj/project.pbxproj:
2768         * bindings/objc/DOM.mm:
2769         (-[DOMNode _initWithNode:WebCore::]):
2770         (-[DOMNode WebCore::]):
2771         (-[DOMRange dealloc]):
2772         (-[DOMRange finalize]):
2773         (-[DOMRange _initWithRange:WebCore::]):
2774         (-[DOMRange WebCore::]):
2775         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
2776         (-[DOMNodeFilter WebCore::]):
2777         (-[DOMNodeFilter dealloc]):
2778         (-[DOMNodeFilter finalize]):
2779         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
2780         (-[DOMNodeIterator WebCore::]):
2781         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
2782         (-[DOMTreeWalker WebCore::]):
2783         * bindings/objc/DOMAbstractView.mm:
2784         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
2785         * bindings/objc/DOMCSS.mm:
2786         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2787         (-[DOMCSSRule _initWithRule:WebCore::]):
2788         (-[DOMCSSValue _initWithValue:WebCore::]):
2789         * bindings/objc/DOMEvents.mm:
2790         (-[DOMEvent _initWithEvent:WebCore::]):
2791         * bindings/objc/DOMHTMLAppletElement.mm:
2792         (-[DOMHTMLAppletElement align]):
2793         (-[DOMHTMLAppletElement setAlign:]):
2794         (-[DOMHTMLAppletElement alt]):
2795         (-[DOMHTMLAppletElement setAlt:]):
2796         (-[DOMHTMLAppletElement archive]):
2797         (-[DOMHTMLAppletElement setArchive:]):
2798         (-[DOMHTMLAppletElement code]):
2799         (-[DOMHTMLAppletElement setCode:]):
2800         (-[DOMHTMLAppletElement codeBase]):
2801         (-[DOMHTMLAppletElement setCodeBase:]):
2802         (-[DOMHTMLAppletElement height]):
2803         (-[DOMHTMLAppletElement setHeight:]):
2804         (-[DOMHTMLAppletElement hspace]):
2805         (-[DOMHTMLAppletElement setHspace:]):
2806         (-[DOMHTMLAppletElement name]):
2807         (-[DOMHTMLAppletElement setName:]):
2808         (-[DOMHTMLAppletElement object]):
2809         (-[DOMHTMLAppletElement setObject:]):
2810         (-[DOMHTMLAppletElement vspace]):
2811         (-[DOMHTMLAppletElement setVspace:]):
2812         (-[DOMHTMLAppletElement width]):
2813         (-[DOMHTMLAppletElement setWidth:]):
2814         * bindings/objc/DOMInternal.h:
2815         (getDOMWrapper):
2816         (addDOMWrapper):
2817         (raiseOnDOMError):
2818         * bindings/objc/DOMXPath.mm:
2819         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
2820         * bindings/scripts/CodeGeneratorObjC.pm:
2821
2822 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
2823
2824         Reviewed by eseidel.
2825
2826         Fix Qt/Linux build after Dave's Scrollbar changes.
2827
2828         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
2829         * platform/qt/TemporaryLinkStubs.cpp:
2830         (WebCore::ScrollBar::setProportion):
2831         (WebCore::PlatformScrollBar::updateThumbPosition):
2832         (WebCore::PlatformScrollBar::updateThumbProportion):
2833
2834 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
2835
2836         Reviewed by eseidel.
2837
2838         Qt/Linux build system changes: enable xpath/xslt by default.
2839         Offer possibility to change all of these using 'ccmake'.
2840
2841         * CMakeLists.txt:
2842
2843 2006-09-24  Dave Hyatt  <hyatt@apple.com>
2844
2845         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
2846         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
2847         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
2848
2849         * platform/ScrollBar.cpp:
2850         (WebCore::ScrollBar::setValue):
2851         (WebCore::ScrollBar::setProportion):
2852         * platform/ScrollBar.h:
2853         (WebCore::ScrollBar::value):
2854         * platform/mac/PlatformScrollBar.h:
2855         * platform/mac/PlatformScrollBarMac.mm:
2856         (WebCore::PlatformScrollBar::updateThumbPosition):
2857         (WebCore::PlatformScrollBar::updateThumbProportion):
2858         * platform/win/PlatformScrollBar.h:
2859         * platform/win/TemporaryLinkStubs.cpp:
2860         (PlatformScrollBar::updateThumbPosition):
2861         (PlatformScrollBar::updateThumbProportion):
2862         * rendering/RenderLayer.cpp:
2863         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
2864
2865 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
2866
2867         Reviewed by Eric.
2868
2869         http://bugs.webkit.org/show_bug.cgi?id=4872
2870         XMLHttpRequest fails to throw an exception when there is a security violation
2871         (mismatching domains)
2872
2873         Raise an exception if there is a security violation, and also in cases required by
2874         the current draft of XHR specification.
2875
2876         * bindings/js/JSXMLHttpRequest.cpp:
2877         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
2878         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
2879         reports one, and also if there were too few arguments passed.
2880
2881         * bindings/js/kjs_binding.cpp:
2882         (KJS::setDOMException): Added support for custom XHR exceptions.
2883
2884         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
2885         exception code range for XHR exceptions.
2886
2887         * xml/xmlhttprequest.cpp:
2888         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
2889         (WebCore::XMLHttpRequest::send):
2890         (WebCore::XMLHttpRequest::setRequestHeader):
2891         (WebCore::XMLHttpRequest::getStatus):
2892         (WebCore::XMLHttpRequest::getStatusText):
2893         (WebCore::XMLHttpRequest::processSyncLoadResults):
2894         (WebCore::XMLHttpRequest::receivedAllData):
2895         (WebCore::XMLHttpRequest::receivedData):
2896
2897 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
2898
2899         Reviewed by Jeff Jenkins.
2900
2901         Tweak CF types.
2902
2903         * platform/cf/ResourceLoaderCFNet.cpp:
2904         (WebCore::willCacheResponse):
2905
2906 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
2907
2908         Reviewed by darin
2909
2910         <http://bugs.webkit.org/show_bug.cgi?id=8029>
2911         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
2912
2913         * dom/Document.cpp:
2914         (WebCore::Document::clearSelectionIfNeeded):
2915         * dom/Element.cpp:
2916         (WebCore::Element::contains):
2917         * dom/Node.cpp:
2918         (WebCore::Node::traverseNextNode):
2919         (WebCore::Node::traverseNextSibling):
2920         (WebCore::Node::traversePreviousNodePostOrder):
2921         (WebCore::Node::checkAddChild):
2922         (WebCore::Node::isDescendantOf):
2923         * dom/Node.h:
2924         * dom/NodeIterator.cpp:
2925         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
2926         * editing/ApplyStyleCommand.cpp:
2927         (WebCore::ApplyStyleCommand::applyBlockStyle):
2928         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
2929         (WebCore::ApplyStyleCommand::applyInlineStyle):
2930         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
2931         * editing/CompositeEditCommand.cpp:
2932         (WebCore::CompositeEditCommand::mergeIdenticalElements):
2933         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
2934         * editing/DeleteSelectionCommand.cpp:
2935         (WebCore::updatePositionForNodeRemoval):
2936         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2937         (WebCore::DeleteSelectionCommand::mergeParagraphs):
2938         * editing/FormatBlockCommand.cpp:
2939         (WebCore::FormatBlockCommand::doApply):
2940         * editing/IndentOutdentCommand.cpp:
2941         (WebCore::enclosingListOrBlockquote):
2942         * editing/Selection.cpp:
2943         (WebCore::Selection::validate):
2944         * editing/SelectionController.cpp:
2945         (WebCore::SelectionController::nodeWillBeRemoved):
2946         * editing/TextIterator.cpp:
2947         (WebCore::SimplifiedBackwardsTextIterator::advance):
2948         * editing/VisiblePosition.cpp:
2949         (WebCore::VisiblePosition::next):
2950         (WebCore::VisiblePosition::previous):
2951         (WebCore::VisiblePosition::canonicalPosition):
2952         (WebCore::isFirstVisiblePositionInNode):
2953         (WebCore::isLastVisiblePositionInNode):
2954         * editing/htmlediting.cpp:
2955         (WebCore::firstEditablePositionAfterPositionInRoot):
2956         (WebCore::lastEditablePositionBeforePositionInRoot):
2957         (WebCore::enclosingNodeWithTag):
2958         (WebCore::enclosingList):
2959         (WebCore::enclosingListChild):
2960         * editing/markup.cpp:
2961         (WebCore::createMarkup):
2962
2963 2006-09-22  Timothy Hatcher  <timothy@apple.com>
2964
2965         Reviewed by Darin.
2966
2967         - Added @property syntax to non-generated headers
2968           inside #ifndef BUILDING_ON_TIGER.
2969         - Changed the DOMEventTarget protocol to have have new versions
2970           of addEventListener and removeEventListener with named parameters.
2971           These old style methods can be removed once Mail changes to use
2972           the new methods <rdar://problem/4746649>.
2973
2974         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
2975         * bindings/objc/DOM.mm:
2976         (-[DOMNode addEventListener:listener:useCapture:]):
2977         (-[DOMNode addEventListener:::]): call the new method
2978         (-[DOMNode removeEventListener:listener:useCapture:]):
2979         (-[DOMNode removeEventListener:::]): call the new method
2980         * bindings/objc/DOMAbstractView.h:
2981         * bindings/objc/DOMEventTarget.h:
2982         * bindings/objc/DOMHTMLAppletElement.h:
2983         * bindings/objc/DOMHTMLEmbedElement.h:
2984         * bindings/objc/DOMHTMLOptionElement.h:
2985         * bindings/objc/DOMObject.h:
2986         * bindings/objc/DOMRGBColor.h:
2987
2988 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
2989
2990         Reviewed by Eric.
2991
2992         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
2993
2994         * platform/qt/FrameQt.cpp:
2995         * platform/qt/GraphicsContextQt.cpp:
2996         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
2997         (WebCore::GraphicsContext::origin):
2998         * platform/qt/PlatformScrollBar.h: Added.
2999         (WebCore::PlatformScrollBar::isWidget):
3000         * platform/qt/WidgetQt.cpp:
3001         (WebCore::Widget::invalidate):
3002         (WebCore::Widget::invalidateRect):
3003
3004 2006-09-22  Dave Hyatt <hyatt@apple.com>
3005
3006         Super-minor tweaks to the systemFont function on Mac.
3007         Set the generic family to None rather than to Serif, and
3008         don't waste time setting the computed size, since that is
3009         set from the specified size over in CSSStyleSelector anyway.
3010
3011         * rendering/RenderThemeMac.mm:
3012         (WebCore::RenderThemeMac::systemFont):
3013
3014 2006-09-22  Timothy Hatcher  <timothy@apple.com>
3015
3016         Reviewed by Brady.
3017
3018         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
3019         take floats. There was already an implicit conversion to float/double
3020         when calling CGContextTranslateCTM or cairo_translate.
3021
3022         * platform/GraphicsContext.h:
3023         * platform/cairo/GraphicsContextCairo.cpp:
3024         (WebCore::GraphicsContext::translate):
3025         * platform/cg/GraphicsContextCG.cpp:
3026         (WebCore::GraphicsContext::translate):
3027
3028 2006-09-22  Brady Eidson  <beidson@apple.com>
3029
3030         Reviewed by Sfalken
3031
3032         Add redirect and other cleanup to ResourceLoaderWin.cpp
3033         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10927
3034         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10744
3035
3036         * WebCore.xcodeproj/project.pbxproj:
3037         * platform/ResourceLoader.h:
3038         * platform/win/ResourceLoaderWin.cpp:
3039         (WebCore::ResourceLoaderWndProc):
3040         (WebCore::initializeOffScreenResourceLoaderWindow):
3041         (WebCore::ResourceLoader::onHandleCreated):
3042         (WebCore::ResourceLoader::onRequestRedirected):
3043         (WebCore::ResourceLoader::onRequestComplete):
3044         (WebCore::transferJobStatusCallback):
3045
3046 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
3047
3048         Reviewed by Geoff.
3049
3050         http://bugs.webkit.org/show_bug.cgi?id=10803
3051         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
3052
3053         * page/FrameView.cpp:
3054         (WebCore::FrameView::hoverTimerFired): Use the current event.
3055
3056 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
3057
3058         Reviewed by Anders.
3059
3060         Fix (last) svg memory leak.
3061
3062         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
3063         (SVGTransformable::parseTransformAttribute):
3064
3065 2006-09-22  Eric Seidel  <eric@eseidel.com>
3066
3067         No review necessary, just removing a dead file.
3068
3069         Remove unused file (added previously by mistake) to make room for real implementation.
3070
3071         * platform/mac/BitmapImageMac.mm: Removed.
3072
3073 2006-09-22  Dave Hyatt <hyatt@apple.com>
3074
3075         Move PlatformScrollBar.h down into the platforms.
3076
3077         Reviewed by andersca
3078
3079         * platform/PlatformScrollBar.h: Removed.
3080         * platform/win/PlatformScrollBar.h: Added.
3081         * platform/mac/PlatformScrollBar.h: Added.
3082
3083 2006-09-22   Dave Hyatt  <hyatt@apple.com>
3084
3085         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
3086         any widget subsystems that don't have any underlying native objects backing the widgets.
3087
3088         Reviewed by anders
3089
3090         * platform/Widget.h:
3091         * platform/mac/WidgetMac.mm:
3092         (WebCore::Widget::invalidate):
3093         (WebCore::Widget::invalidateRect):
3094         * platform/win/TemporaryLinkStubs.cpp:
3095         (Widget::invalidate):
3096         (Widget::invalidateRect):
3097
3098 2006-09-22  Rob Buis  <buis@kd.org>
3099
3100         Reviewed by eseidel.
3101
3102         http://bugs.webkit.org/show_bug.cgi?id=10901
3103         Merge build fixes from unity
3104
3105         * CMakeLists.txt:
3106
3107 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
3108
3109         Reviewed by eseidel.
3110
3111         http://bugs.webkit.org/show_bug.cgi?id=10977
3112         SVGDocument does not expose 'rootElement' property
3113
3114         Enable 'rootElement' property.
3115
3116         * ksvg2/svg/SVGDocument.idl:
3117
3118 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
3119
3120         Tweak includes.
3121
3122         * platform/ResourceLoaderInternal.h:
3123
3124 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
3125
3126         build fixed. band happy.
3127
3128         * platform/cg/GraphicsContextCG.cpp:
3129         (WebCore::GraphicsContext::translate):
3130         * platform/mac/WidgetMac.mm:
3131
3132 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
3133
3134         Reviewed by Maciej.
3135
3136         Some Widget refactoring.
3137
3138         * WebCore.vcproj/WebCore/WebCore.vcproj:
3139         * bridge/mac/FrameMac.mm:
3140         * bridge/win/FrameWin.cpp:
3141         (WebCore::FrameWin::runJavaScriptAlert):
3142         (WebCore::FrameWin::runJavaScriptConfirm):
3143         * bridge/win/PageWin.cpp:
3144         (WebCore::Page::Page):
3145         (WebCore::rootWindowForFrame):
3146         * html/CanvasRenderingContext2D.cpp:
3147         (WebCore::CanvasRenderingContext2D::translate):
3148         * page/FrameView.cpp:
3149         (WebCore::FrameView::isFrameView):
3150         * page/Page.h:
3151         (WebCore::Page::setInstanceHandle):
3152         (WebCore::Page::instanceHandle):
3153         * platform/GraphicsContext.h:
3154         * platform/ScrollView.h:
3155         * platform/Widget.h:
3156         * platform/cairo/GraphicsContextCairo.cpp:
3157         (WebCore::GraphicsContext::translate):
3158         (WebCore::GraphicsContext::origin):
3159         * platform/mac/WidgetMac.mm:
3160         (WebCore::Widget::clearFocus):
3161         * platform/win/ResourceLoaderWin.cpp:
3162         (WebCore::initializeOffScreenResourceLoaderWindow):
3163         * platform/win/ScreenWin.cpp:
3164         (WebCore::monitorInfo):
3165         * platform/win/ScrollViewWin.cpp:
3166         (WebCore::ScrollView::updateContents):
3167         (WebCore::ScrollView::visibleWidth):
3168         (WebCore::ScrollView::visibleHeight):
3169         (WebCore::ScrollView::visibleContentRect):
3170         (WebCore::ScrollView::viewportToContents):
3171         (WebCore::ScrollView::contentsToViewport):
3172         (WebCore::ScrollView::scrollBy):
3173         (WebCore::ScrollView::updateScrollInfo):
3174         (WebCore::ScrollView::updateScrollBars):
3175         * platform/win/SharedTimerWin.cpp:
3176         (WebCore::initializeOffScreenTimerWindow):
3177         * platform/win/TemporaryLinkStubs.cpp:
3178         (FrameView::updateBorder):
3179         (ScrollView::paint):
3180         (GraphicsContext::clip):
3181         * platform/win/WidgetWin.cpp:
3182         (WebCore::Widget::Widget):
3183         (WebCore::Widget::parentWindow):
3184         (WebCore::Widget::setParentWindow):
3185         (WebCore::Widget::frameGeometry):
3186         (WebCore::Widget::hasFocus):
3187         (WebCore::Widget::setFocus):
3188         (WebCore::Widget::show):
3189         (WebCore::Widget::hide):
3190         (WebCore::Widget::setFrameGeometry):
3191
3192 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
3193
3194         Reviewed by Tim H.
3195
3196         * platform/TextEncoding.cpp:
3197         (WebCore::TextEncoding::backslashAsCurrencySymbol):
3198         Add comment clarifying why backslashAsCurrencySymbol is needed.
3199
3200 2006-09-21  Sean Gies  <seangies@apple.com>
3201
3202         Reviewed by Adam Roben.
3203
3204         Add utility functions to get and release HDC from GraphicsContext.
3205
3206         * platform/GraphicsContext.h: Add utilities to get and release HDC.
3207         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
3208         * rendering/RenderThemeWin.cpp: Switch to new utilities.
3209
3210 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
3211
3212         Reviewed by anders
3213
3214         <rdar://problem/4426622>
3215         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
3216
3217         * editing/htmlediting.cpp:
3218         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
3219         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
3220         Got rid of uses of DepricatedString.
3221
3222 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
3223
3224         Reviewed by eseidel.
3225
3226         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
3227
3228         * page/Frame.cpp:
3229         (WebCore::Frame::endIfNotLoading):
3230
3231 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
3232
3233         Reviewed by eseidel.
3234
3235         Fix Qt/Linux build.
3236
3237         * CMakeLists.txt:
3238         * kcanvas/device/qt/KCanvasClipperQt.h:
3239         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
3240         * platform/qt/FrameQt.cpp:
3241         (WebCore::FrameQt::isLoadTypeReload):
3242         (WebCore::FrameQt::originalRequestURL):
3243         * platform/qt/FrameQt.h:
3244         * platform/qt/GraphicsContextQt.cpp:
3245         (WebCore::GraphicsContext::concatCTM):
3246         * platform/qt/ScrollViewQt.cpp:
3247         (WebCore::ScrollView::wheelEvent):
3248         * platform/qt/TemporaryLinkStubs.cpp:
3249         (WebCore::IconDatabase::setIconURLForPageURL):
3250
3251 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
3252
3253         Reviewed by john
3254
3255         <http://bugs.webkit.org/show_bug.cgi?id=7165>
3256         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
3257
3258         * editing/MoveSelectionCommand.cpp:
3259         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
3260         to the position-to-move-to's document, not the fragment's document.  The
3261         fragment's document is the document used to create the fragment and is irrelavant.
3262
3263 === Safari-521.27 ===
3264
3265 2006-09-21  Brady Eidson  <beidson@apple.com>
3266
3267         Reviewed by Anders
3268
3269         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
3270         This fixes Spinneret so it won't crash on its first load!
3271
3272         * page/Frame.cpp:
3273         (WebCore::Frame::endIfNotLoading):
3274
3275 2006-09-21  Brady Eidson  <beidson@apple.com>
3276
3277         Build fix
3278
3279         * platform/win/TemporaryLinkStubs.cpp:
3280         (ScrollView::wheelEvent):
3281
3282 2006-09-20  Rob Buis  <buis@kde.org>
3283
3284         Reviewed by eseidel.
3285
3286         http://bugs.webkit.org/show_bug.cgi?id=10946
3287         new marker code draws end-marker in wrong place
3288
3289         Keep track of the start of the subpath so we can handle
3290         closeTo/moveTo correctly.
3291
3292         * kcanvas/RenderPath.cpp:
3293         (WebCore::DrawMarkersData::DrawMarkersData):
3294         (WebCore::updateMarkerDataForElement):
3295
3296 2006-09-21  David Hyatt <hyatt@apple.com>
3297
3298         Wheel scrolling prep for Win32.
3299
3300         WARNING: NO TEST CASES ADDED OR CHANGED
3301
3302         * platform/PlatformWheelEvent.h:
3303         * platform/ScrollBar.h:
3304         * platform/ScrollView.h:
3305         * platform/mac/ScrollViewMac.mm:
3306         (WebCore::ScrollView::wheelEvent):
3307         * rendering/RenderLayer.cpp:
3308
3309 2006-09-20  Timothy Hatcher  <timothy@apple.com>
3310
3311         Reviewed by Hyatt.
3312
3313         Bug 10917: REGRESSION (r16027): iFrame transparency broken
3314         http://bugs.webkit.org/show_bug.cgi?id=10917
3315
3316         Don't paint the base background color if we transparent.
3317
3318         * rendering/RenderBox.cpp:
3319         (WebCore::RenderBox::paintBackgroundExtended):
3320
3321 2006-09-20  Adam Roben  <aroben@apple.com>
3322
3323         Reviewed by andersca.
3324
3325         * platform/FileChooser.h: Remove no-longer-necessary namespace std
3326
3327 2006-09-20  Eric Seidel  <eric@eseidel.com>
3328
3329         Reviewed by beth.
3330
3331         Cleanup style in KCanvas.
3332         Remove extra white-space, unneeded arguments, etc.
3333
3334         * WebCore.xcodeproj/project.pbxproj:
3335         * kcanvas/KCanvasClipper.cpp:
3336         (WebCore::operator<<):
3337         (WebCore::KCanvasClipper::externalRepresentation):
3338         * kcanvas/KCanvasClipper.h:
3339         * kcanvas/KCanvasFilters.cpp:
3340         (WebCore::KCanvasFilter::externalRepresentation):
3341         (WebCore::operator<<):
3342         (WebCore::KCanvasFilterEffect::externalRepresentation):
3343         (WebCore::KCPointLightSource::externalRepresentation):
3344         (WebCore::KCSpotLightSource::externalRepresentation):
3345         (WebCore::KCDistantLightSource::externalRepresentation):
3346         (WebCore::KCanvasFEBlend::externalRepresentation):
3347         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
3348         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
3349         (WebCore::KCanvasFEComposite::externalRepresentation):
3350         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
3351         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
3352         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
3353         (WebCore::KCanvasFEFlood::externalRepresentation):
3354         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
3355         (WebCore::KCanvasFEImage::externalRepresentation):
3356         (WebCore::KCanvasFEMerge::externalRepresentation):
3357         (WebCore::KCanvasFEMorphology::externalRepresentation):
3358         (WebCore::KCanvasFEOffset::externalRepresentation):
3359         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
3360         (WebCore::KCanvasFETile::externalRepresentation):
3361         (WebCore::KCanvasFETurbulence::externalRepresentation):
3362         * kcanvas/KCanvasFilters.h:
3363         (WebCore::KCanvasFEDiffuseLighting::lightSource):
3364         (WebCore::KCanvasFESpecularLighting::lightSource):
3365         * kcanvas/KCanvasImage.h:
3366         * kcanvas/KCanvasMarker.cpp:
3367         (WebCore::KCanvasMarker::externalRepresentation):
3368         * kcanvas/KCanvasMarker.h:
3369         * kcanvas/KCanvasResource.cpp:
3370         (WebCore::operator<<):
3371         * kcanvas/KCanvasResource.h:
3372         * kcanvas/KCanvasTreeDebug.cpp:
3373         (WebCore::operator<<):
3374         (WebCore::writeIndent):
3375         (WebCore::writeStyle):
3376         (WebCore::write):
3377         (WebCore::writeRenderResources):
3378         * kcanvas/KCanvasTreeDebug.h:
3379         (WebCore::operator<<):
3380         * kcanvas/RenderForeignObject.cpp:
3381         (WebCore::RenderForeignObject::paint):
3382         * kcanvas/RenderPath.cpp:
3383         (WebCore::RenderPath::paint):
3384         (WebCore::drawStartAndMidMarkers):
3385         * kcanvas/RenderSVGContainer.cpp:
3386         (WebCore::RenderSVGContainer::paint):
3387         * kcanvas/RenderSVGImage.cpp:
3388         (WebCore::RenderSVGImage::translateForAttributes):
3389         * kcanvas/RenderSVGImage.h:
3390         * kcanvas/device/KRenderingDevice.cpp:
3391         (WebCore::KRenderingDevice::currentContext):
3392         (WebCore::KRenderingDevice::popContext):
3393         (WebCore::KRenderingDevice::pushContext):
3394         * kcanvas/device/KRenderingDevice.h:
3395         * kcanvas/device/KRenderingFillPainter.h:
3396         * kcanvas/device/KRenderingPaintServer.h:
3397         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
3398         (WebCore::KRenderingPaintServer::activeClient):
3399         (WebCore::KRenderingPaintServer::setActiveClient):
3400         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3401         (WebCore::operator<<):
3402         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
3403         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
3404         (WebCore::KRenderingPaintServerGradient::listener):
3405         (WebCore::KRenderingPaintServerGradient::setListener):
3406         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
3407         * kcanvas/device/KRenderingPaintServerGradient.h:
3408         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3409         (WebCore::KRenderingPaintServerPattern::tile):
3410         (WebCore::KRenderingPaintServerPattern::setTile):
3411         (WebCore::KRenderingPaintServerPattern::listener):
3412         (WebCore::KRenderingPaintServerPattern::setListener):
3413         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
3414         * kcanvas/device/KRenderingPaintServerPattern.h:
3415         * kcanvas/device/KRenderingPaintServerSolid.cpp:
3416         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
3417         * kcanvas/device/KRenderingPaintServerSolid.h:
3418         * kcanvas/device/KRenderingStrokePainter.cpp:
3419         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
3420         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
3421         * kcanvas/device/KRenderingStrokePainter.h:
3422         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
3423         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3424         (WebCore::KCanvasFilterQuartz::prepareFilter):
3425         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
3426         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
3427         (WebCore::KCanvasMaskerQuartz::applyMask):
3428         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
3429         (WebCore::KCanvasImageQuartz::init):
3430         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
3431         (WebCore::KCanvasClipperQuartz::applyClip):
3432         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
3433         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
3434         (WebCore::KRenderingDeviceQuartz::quartzContext):
3435         (WebCore::KRenderingDeviceQuartz::contextForImage):
3436         (WebCore::KRenderingDeviceQuartz::createPaintServer):
3437         (WebCore::KRenderingDeviceQuartz::createResource):
3438         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
3439         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3440         (WebCore::CGShadingRefForLinearGradient):
3441         (WebCore::CGShadingRefForRadialGradient):
3442         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
3443         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
3444         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
3445         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3446         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
3447         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
3448         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
3449         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
3450         (WebCore::KRenderingPaintServerSolidQuartz::draw):
3451         (WebCore::KRenderingPaintServerSolidQuartz::setup):
3452         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
3453         (WebCore::KRenderingPaintServerPatternQuartz::setup):
3454         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
3455         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
3456         * kcanvas/device/quartz/QuartzSupport.h:
3457         * kcanvas/device/quartz/QuartzSupport.mm:
3458         (WebCore::applyStrokeStyleToContext):
3459
3460 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
3461
3462         Reviewed by Dave Hyatt.
3463
3464         * dom/WheelEvent.cpp:
3465         (WebCore::WheelEvent::WheelEvent):
3466         Use lroundf instead of lround since deltas are floats.
3467
3468 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
3469
3470         Reviewed by eseidel.  Landed by eseidel.
3471
3472         Test: svg/custom/pattern-y-offset.svg
3473
3474         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3475         (WebCore::KRenderingPaintServerPatternQuartz::setup):
3476
3477 2006-09-20  David Hyatt  <hyatt@apple.com>
3478
3479         Add a new wheelEvent method to ScrollView.  Platforms that wish
3480         to handle the wheel event for the scroll view themselves can then
3481         do so there.  (Mac lets the underlying NSScrollView do it for now.)
3482
3483         * page/FrameView.cpp:
3484         (WebCore::FrameView::handleWheelEvent):
3485         * platform/ScrollView.h:
3486         (WebCore::ScrollView::wheelEvent):
3487
3488 2006-09-20  Brady Eidson  <beidson@apple.com>
3489
3490         Reviewed by Tim Omernick
3491
3492         Part of fixing a crash Tim O showed me that I missed in a release build.
3493         WebKit should be able to call through the bridge to WebCore no matter what -
3494         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
3495
3496         * bridge/mac/WebCoreIconDatabaseBridge.h:
3497         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3498         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
3499         (-[WebCoreIconDatabaseBridge isOpen]):
3500         (-[WebCoreIconDatabaseBridge removeAllIcons]):
3501         (-[WebCoreIconDatabaseBridge _isEmpty]):
3502         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
3503         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
3504         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
3505         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
3506         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
3507         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
3508         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
3509         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
3510         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
3511         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
3512         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
3513         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
3514         (-[WebCoreIconDatabaseBridge _setEnabled:]):
3515         (-[WebCoreIconDatabaseBridge _isEnabled]):
3516
3517 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
3518
3519         Reviewed by Darin.
3520
3521         Add String::split which returns a Vector of Strings and use it instead of
3522         DeprecatedStringList.
3523
3524         * bindings/js/kjs_events.cpp:
3525         (KJS::Clipboard::getValueProperty):
3526         * bindings/js/kjs_window.cpp:
3527         (KJS::parseModalDialogFeatures):
3528         * css/MediaList.cpp:
3529         (WebCore::MediaList::setMediaText):
3530         * dom/Clipboard.h:
3531         * html/HTMLFormElement.cpp:
3532         (WebCore::HTMLFormElement::formData):
3533         * html/HTMLLinkElement.cpp:
3534         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
3535         * platform/PlatformString.h:
3536         * platform/String.cpp:
3537         (WebCore::String::split):
3538         * platform/StringImpl.cpp:
3539         * platform/StringImpl.h:
3540         * platform/mac/ClipboardMac.h:
3541         * platform/mac/ClipboardMac.mm:
3542         (WebCore::ClipboardMac::types):
3543
3544 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
3545
3546         Reviewed by harrison
3547
3548         * css/cssstyleselector.cpp:
3549         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
3550         HTMLElement::isContentEditable just to check the Frame's editability, since
3551         it calls updateRenderering, which can get us into infinite recursion.
3552
3553 2006-09-20  Brady Eidson  <beidson@apple.com>
3554
3555         Reviewed by Darin
3556
3557         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
3558
3559         * loader/icon/IconDatabase.cpp:
3560         (WebCore::IconDatabase::IconDatabase): Disabled by default
3561         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
3562         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
3563         (WebCore::IconDatabase::iconForPageURL): Ditto
3564         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
3565         (WebCore::IconDatabase::iconURLForPageURL): Ditto
3566         (WebCore::IconDatabase::retainIconForPageURL): Ditto
3567         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
3568         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
3569         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
3570         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
3571         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
3572
3573 2006-09-20  Adam Roben  <aroben@apple.com>
3574
3575         Reviewed by Adele.
3576
3577         Fixes http://bugs.webkit.org/show_bug.cgi?id=10935
3578         REGRESSION: file upload control with direction:rtl or text-align:right
3579         draws button on top of filename/icon
3580
3581         * rendering/RenderFileUploadControl.cpp:
3582         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
3583         match direction
3584         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
3585         the filename and icon in RTL
3586
3587 2006-09-20  Alice Liu  <alice.liu@apple.com>
3588
3589         Reviewed by Adam Roben.
3590
3591         fixed windows build
3592
3593         * dom/WheelEvent.cpp:
3594         (WebCore::WheelEvent::WheelEvent):
3595         changed lrint to lround
3596
3597 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
3598
3599         Build Fix.  Adds isHorizontal attribute back to WheelEvent
3600         for the Objective-C bindings.  If it is found that isHorizontal
3601         is not used, we should remove it again but also remove it's
3602         declaration from PublicDOMInterfaces.h
3603
3604         * dom/WheelEvent.h:
3605         (WebCore::WheelEvent::isHorizontal):
3606         * dom/WheelEvent.idl:
3607
3608 2006-09-20  David Hyatt  <hyatt@apple.com>
3609
3610         Fix for 10945, WheelEvent should support two dimensions at once, since
3611         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
3612         to allow for diagonal scrolling.
3613
3614         Reviewed by Eric
3615
3616         * dom/EventTargetNode.cpp:
3617         (WebCore::EventTargetNode::dispatchWheelEvent):
3618         * dom/WheelEvent.cpp:
3619         (WebCore::WheelEvent::WheelEvent):
3620         (WebCore::WheelEvent::initWheelEvent):