WebCore/ChangeLog

   1 2006-09-26  John Sullivan  <sullivan@apple.com>
   2
   3         Reviewed by Darin
   4
   5         * bridge/mac/WebCoreFrameBridge.h:
   6         * bridge/mac/WebCoreFrameBridge.mm:
   7         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
   8         Added limit parameter, passed down to Frame
   9
  10         * page/Frame.h:
  11         * page/Frame.cpp:
  12         (WebCore::Frame::markAllMatchesForText):
  13         Added limit parameter. Stop the search if it hits limit.
  14
  15 2006-09-26  Sean Gies  <seangies@apple.com>
  16
  17         Reviewed by Brady Eidson.
  18
  19         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
  20
  21 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
  22
  23         Reviewed by john
  24
  25         <rdar://problem/4747695>
  26         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
  27
  28         * editing/DeleteSelectionCommand.cpp:
  29         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
  30         to select special elements that are fully selected after expansion
  31         moves to positions that are visually distinct from the originals.
  32         * editing/InsertListCommand.cpp:
  33         (WebCore::InsertListCommand::doApply): If the content of the list
  34         item will be moved into another list, put it in a list item.
  35
  36 2006-09-26  Geoffrey Garen <ggaren@apple.com>
  37
  38         Reviewed by Darin.
  39
  40         Temporary work-around for frame lifetime issue.
  41
  42         * page/Frame.cpp:
  43         (WebCore::Frame::clear):
  44         (WebCore::Frame::disconnectOwnerElement):
  45
  46 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
  47
  48         Reviewed by Tim H.
  49
  50         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11038
  51         Auto-generate DOMSVGElement for the Objective-C bindings
  52
  53         - Auto-generates DOMSVGElement.
  54
  55         - Make SVGExceptions work like all the other ExceptionCode
  56           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
  57           and SVGExceptionMax.
  58
  59         * DerivedSources.make:
  60         * WebCore.xcodeproj/project.pbxproj:
  61         * bindings/js/kjs_binding.cpp:
  62         (KJS::):
  63         (KJS::setDOMException):
  64         * bindings/objc/DOMInternal.h:
  65         * bindings/objc/DOMInternal.mm:
  66         (raiseDOMException):
  67         * bindings/objc/DOMSVG.h:
  68         * bindings/objc/DOMSVGExecption.h: Added.
  69         * ksvg2/ksvg.h:
  70         * ksvg2/svg/SVGElement.cpp:
  71         (WebCore::SVGElement::setId):
  72         (WebCore::SVGElement::setXmlbase):
  73         * ksvg2/svg/SVGElement.h:
  74         * ksvg2/svg/SVGElement.idl:
  75         * ksvg2/svg/SVGException.h: Added.
  76         (WebCore::):
  77
  78 2006-09-26  Eric Seidel  <eric@eseidel.com>
  79
  80         Reviewed by Tim H.
  81
  82         viewbox parser does not allow <tab> as a delimiter
  83         http://bugzilla.opendarwin.org/show_bug.cgi?id=11014
  84
  85         Test: svg/hixie/viewbox/003.xml
  86
  87         * ksvg2/svg/svgpathparser.cpp:
  88         (WebCore::isWhitespace): new function
  89         (WebCore::skipOptionalSpaces):
  90         (WebCore::skipOptionalSpacesOrComma):
  91
  92 2006-09-26  Eric Seidel  <eric@eseidel.com>
  93
  94         Reviewed by Tim H.
  95
  96         SVGDocument::createElement does not create elements in the SVG namespace
  97         http://bugzilla.opendarwin.org/show_bug.cgi?id=10932
  98
  99         Test: svg/custom/createelement.svg
 100
 101         * ksvg2/svg/SVGDocument.cpp:
 102         (WebCore::SVGDocument::createElement):
 103         * ksvg2/svg/SVGDocument.h:
 104
 105 2006-09-26  Eric Seidel  <eric@eseidel.com>
 106
 107         Reviewed by Tim H.
 108
 109         RenderPath::nodeAtPoint does not respect stroke width
 110         http://bugzilla.opendarwin.org/show_bug.cgi?id=10829
 111
 112         Test: svg/custom/stroke-width-click.svg
 113
 114         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
 115         (WebCore::RenderPath::strokeContains):
 116         * kcanvas/device/quartz/QuartzSupport.h:
 117         * kcanvas/device/quartz/QuartzSupport.mm:
 118
 119 2006-09-26  Eric Seidel  <eric@eseidel.com>
 120
 121         Reviewed by mitz.
 122
 123         Bring animation back to life
 124         http://bugzilla.opendarwin.org/show_bug.cgi?id=11021
 125
 126         Register/unregister SVGSVGElements as time containers on insertion/removal.
 127         Replace uses of DeprecatedString with String in SVGAnimationElement
 128         Various whitespace clean-up.
 129
 130         * ksvg2/misc/KSVGTimeScheduler.cpp:
 131         (WebCore::SVGTimer::notifyAll):
 132         * ksvg2/misc/SVGDocumentExtensions.cpp:
 133         (WebCore::SVGDocumentExtensions::startAnimations):
 134         (WebCore::SVGDocumentExtensions::pauseAnimations):
 135         (WebCore::SVGDocumentExtensions::unpauseAnimations):
 136         * ksvg2/svg/SVGAnimateTransformElement.cpp:
 137         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
 138         (WebCore::SVGAnimateTransformElement::parseTransformValue):
 139         * ksvg2/svg/SVGAnimateTransformElement.h:
 140         * ksvg2/svg/SVGAnimationElement.cpp:
 141         (WebCore::SVGAnimationElement::SVGAnimationElement):
 142         (WebCore::SVGAnimationElement::parseMappedAttribute):
 143         (WebCore::SVGAnimationElement::parseClockValue):
 144         (WebCore::SVGAnimationElement::targetAttribute):
 145         (WebCore::SVGAnimationElement::setTargetAttribute):
 146         (WebCore::SVGAnimationElement::attributeName):
 147         * ksvg2/svg/SVGAnimationElement.h:
 148         (WebCore::SVGAnimationElement::rendererIsNeeded):
 149         * ksvg2/svg/SVGSVGElement.cpp:
 150         (WebCore::SVGSVGElement::getScreenCTM):
 151         (WebCore::SVGSVGElement::createRenderer):
 152         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
 153         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
 154         * ksvg2/svg/SVGSVGElement.h:
 155         * ksvg2/svg/SVGSetElement.cpp:
 156         (WebCore::SVGSetElement::handleTimerEvent):
 157         * ksvg2/svg/SVGURIReference.cpp:
 158         (WebCore::SVGURIReference::getTarget):
 159         * ksvg2/svg/SVGURIReference.h:
 160
 161 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
 162
 163         Reviewed by mitzpettel.
 164
 165         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=11020
 166         No-SVG build broken since r16549
 167
 168         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
 169
 170         * css/cssparser.cpp:
 171         (WebCore::CSSParser::parseValue):
 172         * css/cssstyleselector.cpp:
 173         (WebCore::CSSStyleSelector::applyProperty):
 174         * page/FrameView.cpp:
 175         (WebCore::selectCursor):
 176         * platform/qt/GraphicsContextQt.cpp:
 177
 178 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
 179
 180         Reviewed by Maciej.
 181
 182         http://bugzilla.opendarwin.org/show_bug.cgi?id=10820
 183         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
 184
 185         (Originally written by Eric Seidel).
 186
 187         * bindings/js/kjs_window.cpp:
 188         (KJS::floatFeature):
 189         * ksvg2/svg/SVGAngle.cpp:
 190         (SVGAngle::setValueAsString):
 191         * ksvg2/svg/SVGAnimationElement.cpp:
 192         (SVGAnimationElement::parseMappedAttribute):
 193         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
 194         (SVGComponentTransferFunctionElement::parseMappedAttribute):
 195         * ksvg2/svg/SVGFECompositeElement.cpp:
 196         (WebCore::SVGFECompositeElement::parseMappedAttribute):
 197         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
 198         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
 199         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
 200         (SVGFEDisplacementMapElement::parseMappedAttribute):
 201         * ksvg2/svg/SVGFELightElement.cpp:
 202         (SVGFELightElement::parseMappedAttribute):
 203         * ksvg2/svg/SVGFEOffsetElement.cpp:
 204         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
 205         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
 206         (SVGFESpecularLightingElement::parseMappedAttribute):
 207         * ksvg2/svg/SVGFETurbulenceElement.cpp:
 208         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
 209         * ksvg2/svg/SVGStopElement.cpp:
 210         (SVGStopElement::parseMappedAttribute):
 211         * platform/AtomicString.h:
 212         (WebCore::AtomicString::toDouble):
 213         * platform/PlatformString.h:
 214         * platform/String.cpp:
 215         (WebCore::String::toDouble):
 216         * platform/StringImpl.cpp:
 217         (WebCore::StringImpl::toDouble):
 218         * platform/StringImpl.h:
 219         * rendering/DeprecatedSlider.cpp:
 220         (WebCore::DeprecatedSlider::updateFromElement):
 221         * xml/XPathGrammar.y:
 222
 223 2006-09-25  David Harrison  <harrison@apple.com>
 224
 225         Reviewed by Tim Omernick and Tim Hatcher.
 226
 227         <rdar://problem/4717965> Text Field text parameterized attributes should work
 228         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
 229
 230         * bridge/mac/WebCoreAXObject.mm:
 231         (-[WebCoreAXObject accessibilityAttributeValue:]):
 232         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
 233
 234         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
 235         Cleaned up. Added text field and text area parameterzed attributes.
 236
 237         (-[WebCoreAXObject doAXLineForTextMarker:]):
 238         Fixed to be zero-based and to deal with the first position properly.
 239
 240         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
 241         Minor formatting.
 242
 243         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
 244         (-[WebCoreAXObject indexForTextMarker:]):
 245         (-[WebCoreAXObject textMarkerRangeForRange:]):
 246         (-[WebCoreAXObject rangeForTextMarkerRange:]):
 247         New utility methods.
 248
 249         (-[WebCoreAXObject doAXLineForIndex:]):
 250         (-[WebCoreAXObject doAXRangeForLine:]):
 251         (-[WebCoreAXObject doAXStringForRange:]):
 252         (-[WebCoreAXObject doAXRangeForPosition:]):
 253         (-[WebCoreAXObject doAXRangeForIndex:]):
 254         (-[WebCoreAXObject doAXBoundsForRange:]):
 255         (-[WebCoreAXObject doAXAttributedStringForRange:]):
 256         (-[WebCoreAXObject doAXRTFForRange:]):
 257         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
 258         Implement text field and text area parameterized attributes.
 259
 260         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
 261         Added text field and text area parameterzed attributes.
 262
 263         * rendering/RenderTextControl.h:
 264         Made indexForVisiblePosition() and visiblePositionForIndex() public.
 265
 266 2006-09-25  Adam Roben  <aroben@apple.com>
 267
 268         Reviewed by Brady.
 269
 270         Build fixes.
 271
 272         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
 273         * platform/ResourceLoader.h: Store whether a particular job
 274         has received a response within the ResourceLoader object itself, since
 275         it's possible that we will enter the InternetReadFileExA while loop
 276         twice for the same job.
 277         * platform/ResourceLoaderInternal.h: Add private instance variable to
 278         store whether we've received a response.
 279         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
 280         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
 281         directives.
 282         * platform/win/ResourceLoaderWin.cpp:
 283         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
 284         whether it has received a response instead of assuming it hasn't.
 285         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
 286         (WebCore::ResourceLoader::hasReceivedResponse): Added.
 287         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
 288         setProportion
 289         (ScrollBar::setProportion):
 290
 291 2006-09-25  Brady Eidson  <beidson@apple.com>
 292
 293         Requested by ggaren
 294
 295         Disabled IconDatabase logging by default
 296
 297         * platform/Logging.cpp:
 298         (WebCore::):
 299
 300 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
 301
 302         Build fix
 303
 304         * platform/cf/ResourceLoaderCFNet.cpp:
 305         (WebCore::willCacheResponse):
 306
 307 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
 308
 309         Reviewed by john
 310
 311         <http://bugzilla.opendarwin.org/show_bug.cgi?id=11002>
 312         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
 313
 314         * editing/IndentOutdentCommand.cpp:
 315         (WebCore::IndentOutdentCommand::indentRegion): Special case
 316         an empty root editable element.
 317
 318 2006-09-25  Brady Eidson  <beidson@apple.com>
 319
 320         Reviewed by Steve
 321
 322         Math error in SystemTimeWin
 323
 324         * platform/win/SystemTimeWin.cpp:
 325         (WebCore::currentTime):
 326
 327 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
 328
 329         Reviewed by Eric.
 330
 331         Whitespace cleanup; rename *job variables to *loader.
 332
 333         * bindings/js/JSXMLHttpRequest.cpp:
 334         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
 335         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
 336         (KJS::JSXMLHttpRequestConstructorImp::construct):
 337         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
 338         (KJS::JSXMLHttpRequest::getValueProperty):
 339         (KJS::JSXMLHttpRequest::put):
 340         (KJS::JSXMLHttpRequest::putValueProperty):
 341         (KJS::JSXMLHttpRequest::mark):
 342         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
 343         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
 344         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
 345         * bindings/js/JSXMLHttpRequest.h:
 346         (KJS::JSXMLHttpRequest::toBoolean):
 347         * xml/xmlhttprequest.cpp:
 348         (WebCore::XMLHttpRequest::XMLHttpRequest):
 349         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
 350         (WebCore::XMLHttpRequest::send):
 351         (WebCore::XMLHttpRequest::abort):
 352         (WebCore::XMLHttpRequest::receivedAllData):
 353         (WebCore::XMLHttpRequest::receivedData):
 354         * xml/xmlhttprequest.h:
 355         (WebCore::):
 356
 357 2006-09-25  Timothy Hatcher  <timothy@apple.com>
 358
 359         Reviewed by Brady.
 360
 361         - Deprecate the rest of the old-style methods that are not generated.
 362         - Add @property syntax to DOMRange.
 363
 364         * WebCore.xcodeproj/project.pbxproj:
 365         * bindings/objc/DOM.mm:
 366         (-[DOMRange setStart:offset:]):
 367         (-[DOMRange setEnd:offset:]):
 368         (-[DOMRange compareBoundaryPoints:sourceRange:]):
 369         (-[DOMRange setStart::]):
 370         (-[DOMRange setEnd::]):
 371         (-[DOMRange compareBoundaryPoints::]):
 372         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
 373         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
 374         (-[DOMDocument createNodeIterator::::]):
 375         (-[DOMDocument createTreeWalker::::]):
 376         * bindings/objc/DOMCSS.h:
 377         * bindings/objc/DOMCSS.mm:
 378         (-[DOMDocument getComputedStyle:pseudoElement:]):
 379         (-[DOMDocument getComputedStyle::]):
 380         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
 381         * bindings/objc/DOMExtensions.h:
 382         * bindings/objc/DOMHTML.h:
 383         * bindings/objc/DOMRange.h:
 384         * bindings/objc/DOMTraversal.h:
 385
 386 2006-09-25  Eric Seidel  <eric@eseidel.com>
 387
 388         Reviewed by mjs.
 389
 390         Outermost <svg> element should clip to viewport
 391         http://bugzilla.opendarwin.org/show_bug.cgi?id=11007
 392
 393         Test: svg/custom/viewport-clip.svg
 394
 395         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
 396
 397 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
 398
 399         Reviewed by Maciej.
 400
 401         * css/MediaList.cpp:
 402         Remove unused header.
 403
 404         * dom/Document.cpp:
 405         (WebCore::Document::clear):
 406         Use clear instead of iterating through the list of event listeners, removing each one.
 407         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
 408
 409         * html/HTMLKeygenElement.cpp:
 410         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
 411         (WebCore::HTMLKeygenElement::appendFormData):
 412         Update due to changes in the SSL key generator.
 413
 414         * ksvg2/svg/SVGAngle.cpp:
 415         Remove unused header.
 416
 417         * ksvg2/svg/SVGAnimationElement.cpp:
 418         (SVGAnimationElement::parseMappedAttribute):
 419         Rename methods and pass Strings instead of DeprecatedStrings to
 420         parseSeparatedList.
 421
 422         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
 423         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
 424         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
 425         * ksvg2/svg/SVGFEMergeElement.cpp:
 426         * ksvg2/svg/SVGFEOffsetElement.cpp:
 427         Remove unused headers.
 428
 429         * ksvg2/svg/SVGHelper.cpp:
 430         (WebCore::SVGHelper::parseSeparatedList):
 431         * ksvg2/svg/SVGHelper.h:
 432         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
 433         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
 434
 435         * ksvg2/svg/SVGLengthList.cpp:
 436         (WebCore::SVGLengthList::parse):
 437         * ksvg2/svg/SVGLengthList.h:
 438         Use Vector<String> instead of DeprecatedStringList.
 439
 440         * loader/Cache.cpp:
 441         (WebCore::Cache::requestImage):
 442         (WebCore::Cache::requestStyleSheet):
 443         (WebCore::Cache::requestScript):
 444         (WebCore::Cache::requestXSLStyleSheet):
 445         (WebCore::Cache::requestXBLDocument):
 446         (WebCore::Cache::remove):
 447         (WebCore::Cache::get):
 448         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
 449
 450         * loader/DocLoader.cpp:
 451         (WebCore::DocLoader::needReload):
 452         * loader/DocLoader.h:
 453         Use a HashSet instead of DeprecatedStringList.
 454
 455         * page/FrameView.h:
 456         Remove declarations that have no functions.
 457
 458         * platform/SSLKeyGenerator.h:
 459         * platform/mac/SSLKeyGeneratorMac.mm:
 460         (WebCore::supportedKeySizes):
 461         (WebCore::signedPublicKeyAndChallengeString):
 462         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
 463         DeprecatedString.
 464
 465 2006-09-25  Dave Hyatt  <hyatt@apple.com>
 466
 467         Shunt the RenderTheme world transform adoption between
 468         Cairo and Windows into getWindowsContext and move the method
 469         out of GraphicsContextCairo and into GraphicsContextWin.
 470
 471         * ChangeLog:
 472         * WebCore.vcproj/WebCore/WebCore.vcproj:
 473         * platform/cairo/GraphicsContextCairo.cpp:
 474         * platform/win/GraphicsContextWin.cpp: Added.
 475         (WebCore::GraphicsContext::getWindowsContext):
 476         (WebCore::GraphicsContext::releaseWindowsContext):
 477         * rendering/RenderThemeWin.cpp:
 478         (WebCore::prepareForDrawing):
 479
 480 2006-09-24  Eric Seidel  <eric@eseidel.com>
 481
 482         Reviewed by hyatt.
 483
 484         <svg:a> cannot be styled with a:hover
 485         http://bugzilla.opendarwin.org/show_bug.cgi?id=11005
 486
 487         Test: svg/hixie/cascade/002.xml
 488
 489         * css/cssstyleselector.cpp:
 490         (WebCore::checkPseudoState):
 491
 492 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
 493
 494         Reviewed by Tim H.
 495
 496         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10882
 497         SVG needs Obj-C DOM bindings
 498
 499         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
 500           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
 501           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
 502           DOMSVGTransformList.
 503
 504         * DerivedSources.make:
 505         * WebCore.xcodeproj/project.pbxproj:
 506         * bindings/objc/DOMInternal.h:
 507         * bindings/objc/DOMSVG.h: Added.
 508         * ksvg2/svg/SVGAngle.idl:
 509         * ksvg2/svg/SVGLength.idl:
 510         * ksvg2/svg/SVGLengthList.idl:
 511         * ksvg2/svg/SVGMatrix.idl:
 512         * ksvg2/svg/SVGPathSeg.idl:
 513         * ksvg2/svg/SVGPathSegList.idl:
 514         * ksvg2/svg/SVGTransform.idl:
 515         * ksvg2/svg/SVGTransformList.idl:
 516
 517 2006-09-24  Rob Buis  <buis@kde.org>
 518
 519         Reviewed by eseidel.
 520
 521         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6001
 522         WebKit does not handle fallback custom cursors
 523         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6002
 524         WebKit does not properly handle SVG <cursor> element
 525
 526         Add support for svg cursor images. Also make sure hotspot
 527         settings are handled correctly. Add tests for handling of css3
 528         cursor syntax with hotspots in strict and quirks mode. Finally
 529         implement fallback.
 530
 531         * WebCore.xcodeproj/project.pbxproj:
 532         * css/CSSComputedStyleDeclaration.cpp:
 533         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
 534         * css/CSSCursorImageValue.cpp: Added.
 535         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
 536         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
 537         * css/CSSCursorImageValue.h: Added.
 538         (WebCore::CSSCursorImageValue::hotspot):
 539         * css/cssparser.cpp:
 540         (WebCore::CSSParser::parseValue):
 541         * css/cssstyleselector.cpp:
 542         (WebCore::CSSStyleSelector::applyProperty):
 543         * ksvg2/svg/SVGCursorElement.cpp:
 544         * manual-tests/css3-cursor-fallback-quirks.html: Added.
 545         * manual-tests/css3-cursor-fallback-strict.html: Added.
 546         * manual-tests/cursorfallback.xml: Added.
 547         * page/FrameView.cpp:
 548         (WebCore::selectCursor):
 549         * platform/Cursor.h:
 550         * platform/mac/CursorMac.mm:
 551         (WebCore::createCustomCursor):
 552         (WebCore::Cursor::Cursor):
 553         * platform/qt/CursorQt.cpp:
 554         (WebCore::Cursor::Cursor):
 555         * rendering/RenderStyle.cpp:
 556         (WebCore::StyleInheritedData::StyleInheritedData):
 557         (WebCore::StyleInheritedData::operator==):
 558         (WebCore::RenderStyle::diff):
 559         (WebCore::RenderStyle::addCursor):
 560         (WebCore::RenderStyle::addSVGCursor):
 561         (WebCore::RenderStyle::setCursorList):
 562         (WebCore::RenderStyle::clearCursorList):
 563         * rendering/RenderStyle.h:
 564         (WebCore::CursorData::CursorData):
 565         (WebCore::CursorList::operator[]):
 566         (WebCore::CursorList::size):
 567         (WebCore::CursorList::append):
 568         (WebCore::RenderStyle::cursors):
 569
 570 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
 571
 572         Reviewed by Tim H.
 573
 574         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11009
 575         Auto-generate the internal methods interfaces for the Objective-C bindings
 576
 577         - Auto-generate the internal method declarations into their own files
 578           named in the form DOMFooBarInternal.h for class DOMFooBar.
 579
 580         - Remove all use of DOM_cast from code.
 581
 582         - Assorted cleanups.
 583
 584         * WebCore.xcodeproj/project.pbxproj:
 585         * bindings/objc/DOM.mm:
 586         (-[DOMNode _initWithNode:WebCore::]):
 587         (-[DOMNode WebCore::]):
 588         (-[DOMRange dealloc]):
 589         (-[DOMRange finalize]):
 590         (-[DOMRange _initWithRange:WebCore::]):
 591         (-[DOMRange WebCore::]):
 592         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
 593         (-[DOMNodeFilter WebCore::]):
 594         (-[DOMNodeFilter dealloc]):
 595         (-[DOMNodeFilter finalize]):
 596         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
 597         (-[DOMNodeIterator WebCore::]):
 598         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
 599         (-[DOMTreeWalker WebCore::]):
 600         * bindings/objc/DOMAbstractView.mm:
 601         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
 602         * bindings/objc/DOMCSS.mm:
 603         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
 604         (-[DOMCSSRule _initWithRule:WebCore::]):
 605         (-[DOMCSSValue _initWithValue:WebCore::]):
 606         * bindings/objc/DOMEvents.mm:
 607         (-[DOMEvent _initWithEvent:WebCore::]):
 608         * bindings/objc/DOMHTMLAppletElement.mm:
 609         (-[DOMHTMLAppletElement align]):
 610         (-[DOMHTMLAppletElement setAlign:]):
 611         (-[DOMHTMLAppletElement alt]):
 612         (-[DOMHTMLAppletElement setAlt:]):
 613         (-[DOMHTMLAppletElement archive]):
 614         (-[DOMHTMLAppletElement setArchive:]):
 615         (-[DOMHTMLAppletElement code]):
 616         (-[DOMHTMLAppletElement setCode:]):
 617         (-[DOMHTMLAppletElement codeBase]):
 618         (-[DOMHTMLAppletElement setCodeBase:]):
 619         (-[DOMHTMLAppletElement height]):
 620         (-[DOMHTMLAppletElement setHeight:]):
 621         (-[DOMHTMLAppletElement hspace]):
 622         (-[DOMHTMLAppletElement setHspace:]):
 623         (-[DOMHTMLAppletElement name]):
 624         (-[DOMHTMLAppletElement setName:]):
 625         (-[DOMHTMLAppletElement object]):
 626         (-[DOMHTMLAppletElement setObject:]):
 627         (-[DOMHTMLAppletElement vspace]):
 628         (-[DOMHTMLAppletElement setVspace:]):
 629         (-[DOMHTMLAppletElement width]):
 630         (-[DOMHTMLAppletElement setWidth:]):
 631         * bindings/objc/DOMInternal.h:
 632         (getDOMWrapper):
 633         (addDOMWrapper):
 634         (raiseOnDOMError):
 635         * bindings/objc/DOMXPath.mm:
 636         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
 637         * bindings/scripts/CodeGeneratorObjC.pm:
 638
 639 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
 640
 641         Reviewed by eseidel.
 642
 643         Fix Qt/Linux build after Dave's Scrollbar changes.
 644
 645         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
 646         * platform/qt/TemporaryLinkStubs.cpp:
 647         (WebCore::ScrollBar::setProportion):
 648         (WebCore::PlatformScrollBar::updateThumbPosition):
 649         (WebCore::PlatformScrollBar::updateThumbProportion):
 650
 651 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
 652
 653         Reviewed by eseidel.
 654
 655         Qt/Linux build system changes: enable xpath/xslt by default.
 656         Offer possibility to change all of these using 'ccmake'.
 657
 658         * CMakeLists.txt:
 659
 660 2006-09-24  Dave Hyatt  <hyatt@apple.com>
 661
 662         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
 663         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
 664         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
 665
 666         * platform/ScrollBar.cpp:
 667         (WebCore::ScrollBar::setValue):
 668         (WebCore::ScrollBar::setProportion):
 669         * platform/ScrollBar.h:
 670         (WebCore::ScrollBar::value):
 671         * platform/mac/PlatformScrollBar.h:
 672         * platform/mac/PlatformScrollBarMac.mm:
 673         (WebCore::PlatformScrollBar::updateThumbPosition):
 674         (WebCore::PlatformScrollBar::updateThumbProportion):
 675         * platform/win/PlatformScrollBar.h:
 676         * platform/win/TemporaryLinkStubs.cpp:
 677         (PlatformScrollBar::updateThumbPosition):
 678         (PlatformScrollBar::updateThumbProportion):
 679         * rendering/RenderLayer.cpp:
 680         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
 681
 682 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
 683
 684         Reviewed by Eric.
 685
 686         http://bugzilla.opendarwin.org/show_bug.cgi?id=4872
 687         XMLHttpRequest fails to throw an exception when there is a security violation
 688         (mismatching domains)
 689
 690         Raise an exception if there is a security violation, and also in cases required by
 691         the current draft of XHR specification.
 692
 693         * bindings/js/JSXMLHttpRequest.cpp:
 694         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
 695         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
 696         reports one, and also if there were too few arguments passed.
 697
 698         * bindings/js/kjs_binding.cpp:
 699         (KJS::setDOMException): Added support for custom XHR exceptions.
 700
 701         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
 702         exception code range for XHR exceptions.
 703
 704         * xml/xmlhttprequest.cpp:
 705         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
 706         (WebCore::XMLHttpRequest::send):
 707         (WebCore::XMLHttpRequest::setRequestHeader):
 708         (WebCore::XMLHttpRequest::getStatus):
 709         (WebCore::XMLHttpRequest::getStatusText):
 710         (WebCore::XMLHttpRequest::processSyncLoadResults):
 711         (WebCore::XMLHttpRequest::receivedAllData):
 712         (WebCore::XMLHttpRequest::receivedData):
 713
 714 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
 715
 716         Reviewed by Jeff Jenkins.
 717
 718         Tweak CF types.
 719
 720         * platform/cf/ResourceLoaderCFNet.cpp:
 721         (WebCore::willCacheResponse):
 722
 723 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
 724
 725         Reviewed by darin
 726
 727         <http://bugzilla.opendarwin.org/show_bug.cgi?id=8029>
 728         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
 729
 730         * dom/Document.cpp:
 731         (WebCore::Document::clearSelectionIfNeeded):
 732         * dom/Element.cpp:
 733         (WebCore::Element::contains):
 734         * dom/Node.cpp:
 735         (WebCore::Node::traverseNextNode):
 736         (WebCore::Node::traverseNextSibling):
 737         (WebCore::Node::traversePreviousNodePostOrder):
 738         (WebCore::Node::checkAddChild):
 739         (WebCore::Node::isDescendantOf):
 740         * dom/Node.h:
 741         * dom/NodeIterator.cpp:
 742         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
 743         * editing/ApplyStyleCommand.cpp:
 744         (WebCore::ApplyStyleCommand::applyBlockStyle):
 745         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
 746         (WebCore::ApplyStyleCommand::applyInlineStyle):
 747         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
 748         * editing/CompositeEditCommand.cpp:
 749         (WebCore::CompositeEditCommand::mergeIdenticalElements):
 750         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
 751         * editing/DeleteSelectionCommand.cpp:
 752         (WebCore::updatePositionForNodeRemoval):
 753         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
 754         (WebCore::DeleteSelectionCommand::mergeParagraphs):
 755         * editing/FormatBlockCommand.cpp:
 756         (WebCore::FormatBlockCommand::doApply):
 757         * editing/IndentOutdentCommand.cpp:
 758         (WebCore::enclosingListOrBlockquote):
 759         * editing/Selection.cpp:
 760         (WebCore::Selection::validate):
 761         * editing/SelectionController.cpp:
 762         (WebCore::SelectionController::nodeWillBeRemoved):
 763         * editing/TextIterator.cpp:
 764         (WebCore::SimplifiedBackwardsTextIterator::advance):
 765         * editing/VisiblePosition.cpp:
 766         (WebCore::VisiblePosition::next):
 767         (WebCore::VisiblePosition::previous):
 768         (WebCore::VisiblePosition::canonicalPosition):
 769         (WebCore::isFirstVisiblePositionInNode):
 770         (WebCore::isLastVisiblePositionInNode):
 771         * editing/htmlediting.cpp:
 772         (WebCore::firstEditablePositionAfterPositionInRoot):
 773         (WebCore::lastEditablePositionBeforePositionInRoot):
 774         (WebCore::enclosingNodeWithTag):
 775         (WebCore::enclosingList):
 776         (WebCore::enclosingListChild):
 777         * editing/markup.cpp:
 778         (WebCore::createMarkup):
 779
 780 2006-09-22  Timothy Hatcher  <timothy@apple.com>
 781
 782         Reviewed by Darin.
 783
 784         - Added @property syntax to non-generated headers
 785           inside #ifndef BUILDING_ON_TIGER.
 786         - Changed the DOMEventTarget protocol to have have new versions
 787           of addEventListener and removeEventListener with named parameters.
 788           These old style methods can be removed once Mail changes to use
 789           the new methods <rdar://problem/4746649>.
 790
 791         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
 792         * bindings/objc/DOM.mm:
 793         (-[DOMNode addEventListener:listener:useCapture:]):
 794         (-[DOMNode addEventListener:::]): call the new method
 795         (-[DOMNode removeEventListener:listener:useCapture:]):
 796         (-[DOMNode removeEventListener:::]): call the new method
 797         * bindings/objc/DOMAbstractView.h:
 798         * bindings/objc/DOMEventTarget.h:
 799         * bindings/objc/DOMHTMLAppletElement.h:
 800         * bindings/objc/DOMHTMLEmbedElement.h:
 801         * bindings/objc/DOMHTMLOptionElement.h:
 802         * bindings/objc/DOMObject.h:
 803         * bindings/objc/DOMRGBColor.h:
 804
 805 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
 806
 807         Reviewed by Eric.
 808
 809         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
 810
 811         * platform/qt/FrameQt.cpp:
 812         * platform/qt/GraphicsContextQt.cpp:
 813         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
 814         (WebCore::GraphicsContext::origin):
 815         * platform/qt/PlatformScrollBar.h: Added.
 816         (WebCore::PlatformScrollBar::isWidget):
 817         * platform/qt/WidgetQt.cpp:
 818         (WebCore::Widget::invalidate):
 819         (WebCore::Widget::invalidateRect):
 820
 821 2006-09-22  Dave Hyatt <hyatt@apple.com>
 822
 823         Super-minor tweaks to the systemFont function on Mac.
 824         Set the generic family to None rather than to Serif, and
 825         don't waste time setting the computed size, since that is
 826         set from the specified size over in CSSStyleSelector anyway.
 827
 828         * rendering/RenderThemeMac.mm:
 829         (WebCore::RenderThemeMac::systemFont):
 830
 831 2006-09-22  Timothy Hatcher  <timothy@apple.com>
 832
 833         Reviewed by Brady.
 834
 835         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
 836         take floats. There was already an implicit conversion to float/double
 837         when calling CGContextTranslateCTM or cairo_translate.
 838
 839         * platform/GraphicsContext.h:
 840         * platform/cairo/GraphicsContextCairo.cpp:
 841         (WebCore::GraphicsContext::translate):
 842         * platform/cg/GraphicsContextCG.cpp:
 843         (WebCore::GraphicsContext::translate):
 844
 845 2006-09-22  Brady Eidson  <beidson@apple.com>
 846
 847         Reviewed by Sfalken
 848
 849         Add redirect and other cleanup to ResourceLoaderWin.cpp
 850         Fixes bug http://bugzilla.opendarwin.org/show_bug.cgi?id=10927
 851         Fixes bug http://bugzilla.opendarwin.org/show_bug.cgi?id=10744
 852
 853         * WebCore.xcodeproj/project.pbxproj:
 854         * platform/ResourceLoader.h:
 855         * platform/win/ResourceLoaderWin.cpp:
 856         (WebCore::ResourceLoaderWndProc):
 857         (WebCore::initializeOffScreenResourceLoaderWindow):
 858         (WebCore::ResourceLoader::onHandleCreated):
 859         (WebCore::ResourceLoader::onRequestRedirected):
 860         (WebCore::ResourceLoader::onRequestComplete):
 861         (WebCore::transferJobStatusCallback):
 862
 863 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
 864
 865         Reviewed by Geoff.
 866
 867         http://bugzilla.opendarwin.org/show_bug.cgi?id=10803
 868         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
 869
 870         * page/FrameView.cpp:
 871         (WebCore::FrameView::hoverTimerFired): Use the current event.
 872
 873 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
 874
 875         Reviewed by Anders.
 876
 877         Fix (last) svg memory leak.
 878
 879         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
 880         (SVGTransformable::parseTransformAttribute):
 881
 882 2006-09-22  Eric Seidel  <eric@eseidel.com>
 883
 884         No review necessary, just removing a dead file.
 885
 886         Remove unused file (added previously by mistake) to make room for real implementation.
 887
 888         * platform/mac/BitmapImageMac.mm: Removed.
 889
 890 2006-09-22  Dave Hyatt <hyatt@apple.com>
 891
 892         Move PlatformScrollBar.h down into the platforms.
 893
 894         Reviewed by andersca
 895
 896         * platform/PlatformScrollBar.h: Removed.
 897         * platform/win/PlatformScrollBar.h: Added.
 898         * platform/mac/PlatformScrollBar.h: Added.
 899
 900 2006-09-22   Dave Hyatt  <hyatt@apple.com>
 901
 902         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
 903         any widget subsystems that don't have any underlying native objects backing the widgets.
 904
 905         Reviewed by anders
 906
 907         * platform/Widget.h:
 908         * platform/mac/WidgetMac.mm:
 909         (WebCore::Widget::invalidate):
 910         (WebCore::Widget::invalidateRect):
 911         * platform/win/TemporaryLinkStubs.cpp:
 912         (Widget::invalidate):
 913         (Widget::invalidateRect):
 914
 915 2006-09-22  Rob Buis  <buis@kd.org>
 916
 917         Reviewed by eseidel.
 918
 919         http://bugzilla.opendarwin.org/show_bug.cgi?id=10901
 920         Merge build fixes from unity
 921
 922         * CMakeLists.txt:
 923
 924 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
 925
 926         Reviewed by eseidel.
 927
 928         http://bugzilla.opendarwin.org/show_bug.cgi?id=10977
 929         SVGDocument does not expose 'rootElement' property
 930
 931         Enable 'rootElement' property.
 932
 933         * ksvg2/svg/SVGDocument.idl:
 934
 935 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
 936
 937         Tweak includes.
 938
 939         * platform/ResourceLoaderInternal.h:
 940
 941 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
 942
 943         build fixed. band happy.
 944
 945         * platform/cg/GraphicsContextCG.cpp:
 946         (WebCore::GraphicsContext::translate):
 947         * platform/mac/WidgetMac.mm:
 948
 949 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
 950
 951         Reviewed by Maciej.
 952
 953         Some Widget refactoring.
 954
 955         * WebCore.vcproj/WebCore/WebCore.vcproj:
 956         * bridge/mac/FrameMac.mm:
 957         * bridge/win/FrameWin.cpp:
 958         (WebCore::FrameWin::runJavaScriptAlert):
 959         (WebCore::FrameWin::runJavaScriptConfirm):
 960         * bridge/win/PageWin.cpp:
 961         (WebCore::Page::Page):
 962         (WebCore::rootWindowForFrame):
 963         * html/CanvasRenderingContext2D.cpp:
 964         (WebCore::CanvasRenderingContext2D::translate):
 965         * page/FrameView.cpp:
 966         (WebCore::FrameView::isFrameView):
 967         * page/Page.h:
 968         (WebCore::Page::setInstanceHandle):
 969         (WebCore::Page::instanceHandle):
 970         * platform/GraphicsContext.h:
 971         * platform/ScrollView.h:
 972         * platform/Widget.h:
 973         * platform/cairo/GraphicsContextCairo.cpp:
 974         (WebCore::GraphicsContext::translate):
 975         (WebCore::GraphicsContext::origin):
 976         * platform/mac/WidgetMac.mm:
 977         (WebCore::Widget::clearFocus):
 978         * platform/win/ResourceLoaderWin.cpp:
 979         (WebCore::initializeOffScreenResourceLoaderWindow):
 980         * platform/win/ScreenWin.cpp:
 981         (WebCore::monitorInfo):
 982         * platform/win/ScrollViewWin.cpp:
 983         (WebCore::ScrollView::updateContents):
 984         (WebCore::ScrollView::visibleWidth):
 985         (WebCore::ScrollView::visibleHeight):
 986         (WebCore::ScrollView::visibleContentRect):
 987         (WebCore::ScrollView::viewportToContents):
 988         (WebCore::ScrollView::contentsToViewport):
 989         (WebCore::ScrollView::scrollBy):
 990         (WebCore::ScrollView::updateScrollInfo):
 991         (WebCore::ScrollView::updateScrollBars):
 992         * platform/win/SharedTimerWin.cpp:
 993         (WebCore::initializeOffScreenTimerWindow):
 994         * platform/win/TemporaryLinkStubs.cpp:
 995         (FrameView::updateBorder):
 996         (ScrollView::paint):
 997         (GraphicsContext::clip):
 998         * platform/win/WidgetWin.cpp:
 999         (WebCore::Widget::Widget):
1000         (WebCore::Widget::parentWindow):
1001         (WebCore::Widget::setParentWindow):
1002         (WebCore::Widget::frameGeometry):
1003         (WebCore::Widget::hasFocus):
1004         (WebCore::Widget::setFocus):
1005         (WebCore::Widget::show):
1006         (WebCore::Widget::hide):
1007         (WebCore::Widget::setFrameGeometry):
1008
1009 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
1010
1011         Reviewed by Tim H.
1012
1013         * platform/TextEncoding.cpp:
1014         (WebCore::TextEncoding::backslashAsCurrencySymbol):
1015         Add comment clarifying why backslashAsCurrencySymbol is needed.
1016
1017 2006-09-21  Sean Gies  <seangies@apple.com>
1018
1019         Reviewed by Adam Roben.
1020
1021         Add utility functions to get and release HDC from GraphicsContext.
1022
1023         * platform/GraphicsContext.h: Add utilities to get and release HDC.
1024         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
1025         * rendering/RenderThemeWin.cpp: Switch to new utilities.
1026
1027 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
1028
1029         Reviewed by anders
1030
1031         <rdar://problem/4426622>
1032         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
1033
1034         * editing/htmlediting.cpp:
1035         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
1036         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
1037         Got rid of uses of DepricatedString.
1038
1039 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1040
1041         Reviewed by eseidel.
1042
1043         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
1044
1045         * page/Frame.cpp:
1046         (WebCore::Frame::endIfNotLoading):
1047
1048 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1049
1050         Reviewed by eseidel.
1051
1052         Fix Qt/Linux build.
1053
1054         * CMakeLists.txt:
1055         * kcanvas/device/qt/KCanvasClipperQt.h:
1056         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1057         * platform/qt/FrameQt.cpp:
1058         (WebCore::FrameQt::isLoadTypeReload):
1059         (WebCore::FrameQt::originalRequestURL):
1060         * platform/qt/FrameQt.h:
1061         * platform/qt/GraphicsContextQt.cpp:
1062         (WebCore::GraphicsContext::concatCTM):
1063         * platform/qt/ScrollViewQt.cpp:
1064         (WebCore::ScrollView::wheelEvent):
1065         * platform/qt/TemporaryLinkStubs.cpp:
1066         (WebCore::IconDatabase::setIconURLForPageURL):
1067
1068 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
1069
1070         Reviewed by john
1071
1072         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
1073         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
1074
1075         * editing/MoveSelectionCommand.cpp:
1076         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
1077         to the position-to-move-to's document, not the fragment's document.  The
1078         fragment's document is the document used to create the fragment and is irrelavant.
1079
1080 === Safari-521.27 ===
1081
1082 2006-09-21  Brady Eidson  <beidson@apple.com>
1083
1084         Reviewed by Anders
1085
1086         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
1087         This fixes Spinneret so it won't crash on its first load!
1088
1089         * page/Frame.cpp:
1090         (WebCore::Frame::endIfNotLoading):
1091
1092 2006-09-21  Brady Eidson  <beidson@apple.com>
1093
1094         Build fix
1095
1096         * platform/win/TemporaryLinkStubs.cpp:
1097         (ScrollView::wheelEvent):
1098
1099 2006-09-20  Rob Buis  <buis@kde.org>
1100
1101         Reviewed by eseidel.
1102
1103         http://bugzilla.opendarwin.org/show_bug.cgi?id=10946
1104         new marker code draws end-marker in wrong place
1105
1106         Keep track of the start of the subpath so we can handle
1107         closeTo/moveTo correctly.
1108
1109         * kcanvas/RenderPath.cpp:
1110         (WebCore::DrawMarkersData::DrawMarkersData):
1111         (WebCore::updateMarkerDataForElement):
1112
1113 2006-09-21  David Hyatt <hyatt@apple.com>
1114
1115         Wheel scrolling prep for Win32.
1116
1117         WARNING: NO TEST CASES ADDED OR CHANGED
1118
1119         * platform/PlatformWheelEvent.h:
1120         * platform/ScrollBar.h:
1121         * platform/ScrollView.h:
1122         * platform/mac/ScrollViewMac.mm:
1123         (WebCore::ScrollView::wheelEvent):
1124         * rendering/RenderLayer.cpp:
1125
1126 2006-09-20  Timothy Hatcher  <timothy@apple.com>
1127
1128         Reviewed by Hyatt.
1129
1130         Bug 10917: REGRESSION (r16027): iFrame transparency broken
1131         http://bugzilla.opendarwin.org/show_bug.cgi?id=10917
1132
1133         Don't paint the base background color if we transparent.
1134
1135         * rendering/RenderBox.cpp:
1136         (WebCore::RenderBox::paintBackgroundExtended):
1137
1138 2006-09-20  Adam Roben  <aroben@apple.com>
1139
1140         Reviewed by andersca.
1141
1142         * platform/FileChooser.h: Remove no-longer-necessary namespace std
1143
1144 2006-09-20  Eric Seidel  <eric@eseidel.com>
1145
1146         Reviewed by beth.
1147
1148         Cleanup style in KCanvas.
1149         Remove extra white-space, unneeded arguments, etc.
1150
1151         * WebCore.xcodeproj/project.pbxproj:
1152         * kcanvas/KCanvasClipper.cpp:
1153         (WebCore::operator<<):
1154         (WebCore::KCanvasClipper::externalRepresentation):
1155         * kcanvas/KCanvasClipper.h:
1156         * kcanvas/KCanvasFilters.cpp:
1157         (WebCore::KCanvasFilter::externalRepresentation):
1158         (WebCore::operator<<):
1159         (WebCore::KCanvasFilterEffect::externalRepresentation):
1160         (WebCore::KCPointLightSource::externalRepresentation):
1161         (WebCore::KCSpotLightSource::externalRepresentation):
1162         (WebCore::KCDistantLightSource::externalRepresentation):
1163         (WebCore::KCanvasFEBlend::externalRepresentation):
1164         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
1165         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
1166         (WebCore::KCanvasFEComposite::externalRepresentation):
1167         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
1168         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
1169         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
1170         (WebCore::KCanvasFEFlood::externalRepresentation):
1171         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
1172         (WebCore::KCanvasFEImage::externalRepresentation):
1173         (WebCore::KCanvasFEMerge::externalRepresentation):
1174         (WebCore::KCanvasFEMorphology::externalRepresentation):
1175         (WebCore::KCanvasFEOffset::externalRepresentation):
1176         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
1177         (WebCore::KCanvasFETile::externalRepresentation):
1178         (WebCore::KCanvasFETurbulence::externalRepresentation):
1179         * kcanvas/KCanvasFilters.h:
1180         (WebCore::KCanvasFEDiffuseLighting::lightSource):
1181         (WebCore::KCanvasFESpecularLighting::lightSource):
1182         * kcanvas/KCanvasImage.h:
1183         * kcanvas/KCanvasMarker.cpp:
1184         (WebCore::KCanvasMarker::externalRepresentation):
1185         * kcanvas/KCanvasMarker.h:
1186         * kcanvas/KCanvasResource.cpp:
1187         (WebCore::operator<<):
1188         * kcanvas/KCanvasResource.h:
1189         * kcanvas/KCanvasTreeDebug.cpp:
1190         (WebCore::operator<<):
1191         (WebCore::writeIndent):
1192         (WebCore::writeStyle):
1193         (WebCore::write):
1194         (WebCore::writeRenderResources):
1195         * kcanvas/KCanvasTreeDebug.h:
1196         (WebCore::operator<<):
1197         * kcanvas/RenderForeignObject.cpp:
1198         (WebCore::RenderForeignObject::paint):
1199         * kcanvas/RenderPath.cpp:
1200         (WebCore::RenderPath::paint):
1201         (WebCore::drawStartAndMidMarkers):
1202         * kcanvas/RenderSVGContainer.cpp:
1203         (WebCore::RenderSVGContainer::paint):
1204         * kcanvas/RenderSVGImage.cpp:
1205         (WebCore::RenderSVGImage::translateForAttributes):
1206         * kcanvas/RenderSVGImage.h:
1207         * kcanvas/device/KRenderingDevice.cpp:
1208         (WebCore::KRenderingDevice::currentContext):
1209         (WebCore::KRenderingDevice::popContext):
1210         (WebCore::KRenderingDevice::pushContext):
1211         * kcanvas/device/KRenderingDevice.h:
1212         * kcanvas/device/KRenderingFillPainter.h:
1213         * kcanvas/device/KRenderingPaintServer.h:
1214         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1215         (WebCore::KRenderingPaintServer::activeClient):
1216         (WebCore::KRenderingPaintServer::setActiveClient):
1217         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1218         (WebCore::operator<<):
1219         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
1220         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
1221         (WebCore::KRenderingPaintServerGradient::listener):
1222         (WebCore::KRenderingPaintServerGradient::setListener):
1223         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
1224         * kcanvas/device/KRenderingPaintServerGradient.h:
1225         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1226         (WebCore::KRenderingPaintServerPattern::tile):
1227         (WebCore::KRenderingPaintServerPattern::setTile):
1228         (WebCore::KRenderingPaintServerPattern::listener):
1229         (WebCore::KRenderingPaintServerPattern::setListener):
1230         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
1231         * kcanvas/device/KRenderingPaintServerPattern.h:
1232         * kcanvas/device/KRenderingPaintServerSolid.cpp:
1233         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
1234         * kcanvas/device/KRenderingPaintServerSolid.h:
1235         * kcanvas/device/KRenderingStrokePainter.cpp:
1236         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
1237         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
1238         * kcanvas/device/KRenderingStrokePainter.h:
1239         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
1240         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1241         (WebCore::KCanvasFilterQuartz::prepareFilter):
1242         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
1243         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1244         (WebCore::KCanvasMaskerQuartz::applyMask):
1245         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1246         (WebCore::KCanvasImageQuartz::init):
1247         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1248         (WebCore::KCanvasClipperQuartz::applyClip):
1249         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1250         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1251         (WebCore::KRenderingDeviceQuartz::quartzContext):
1252         (WebCore::KRenderingDeviceQuartz::contextForImage):
1253         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1254         (WebCore::KRenderingDeviceQuartz::createResource):
1255         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
1256         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1257         (WebCore::CGShadingRefForLinearGradient):
1258         (WebCore::CGShadingRefForRadialGradient):
1259         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
1260         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1261         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1262         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1263         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
1264         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
1265         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
1266         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
1267         (WebCore::KRenderingPaintServerSolidQuartz::draw):
1268         (WebCore::KRenderingPaintServerSolidQuartz::setup):
1269         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
1270         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1271         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
1272         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
1273         * kcanvas/device/quartz/QuartzSupport.h:
1274         * kcanvas/device/quartz/QuartzSupport.mm:
1275         (WebCore::applyStrokeStyleToContext):
1276
1277 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1278
1279         Reviewed by Dave Hyatt.
1280
1281         * dom/WheelEvent.cpp:
1282         (WebCore::WheelEvent::WheelEvent):
1283         Use lroundf instead of lround since deltas are floats.
1284
1285 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
1286
1287         Reviewed by eseidel.  Landed by eseidel.
1288
1289         Test: svg/custom/pattern-y-offset.svg
1290
1291         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1292         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1293
1294 2006-09-20  David Hyatt  <hyatt@apple.com>
1295
1296         Add a new wheelEvent method to ScrollView.  Platforms that wish
1297         to handle the wheel event for the scroll view themselves can then
1298         do so there.  (Mac lets the underlying NSScrollView do it for now.)
1299
1300         * page/FrameView.cpp:
1301         (WebCore::FrameView::handleWheelEvent):
1302         * platform/ScrollView.h:
1303         (WebCore::ScrollView::wheelEvent):
1304
1305 2006-09-20  Brady Eidson  <beidson@apple.com>
1306
1307         Reviewed by Tim Omernick
1308
1309         Part of fixing a crash Tim O showed me that I missed in a release build.
1310         WebKit should be able to call through the bridge to WebCore no matter what -
1311         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
1312
1313         * bridge/mac/WebCoreIconDatabaseBridge.h:
1314         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1315         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
1316         (-[WebCoreIconDatabaseBridge isOpen]):
1317         (-[WebCoreIconDatabaseBridge removeAllIcons]):
1318         (-[WebCoreIconDatabaseBridge _isEmpty]):
1319         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
1320         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
1321         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
1322         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
1323         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
1324         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
1325         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
1326         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
1327         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
1328         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
1329         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
1330         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
1331         (-[WebCoreIconDatabaseBridge _setEnabled:]):
1332         (-[WebCoreIconDatabaseBridge _isEnabled]):
1333
1334 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1335
1336         Reviewed by Darin.
1337
1338         Add String::split which returns a Vector of Strings and use it instead of
1339         DeprecatedStringList.
1340
1341         * bindings/js/kjs_events.cpp:
1342         (KJS::Clipboard::getValueProperty):
1343         * bindings/js/kjs_window.cpp:
1344         (KJS::parseModalDialogFeatures):
1345         * css/MediaList.cpp:
1346         (WebCore::MediaList::setMediaText):
1347         * dom/Clipboard.h:
1348         * html/HTMLFormElement.cpp:
1349         (WebCore::HTMLFormElement::formData):
1350         * html/HTMLLinkElement.cpp:
1351         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
1352         * platform/PlatformString.h:
1353         * platform/String.cpp:
1354         (WebCore::String::split):
1355         * platform/StringImpl.cpp:
1356         * platform/StringImpl.h:
1357         * platform/mac/ClipboardMac.h:
1358         * platform/mac/ClipboardMac.mm:
1359         (WebCore::ClipboardMac::types):
1360
1361 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
1362
1363         Reviewed by harrison
1364
1365         * css/cssstyleselector.cpp:
1366         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
1367         HTMLElement::isContentEditable just to check the Frame's editability, since
1368         it calls updateRenderering, which can get us into infinite recursion.
1369
1370 2006-09-20  Brady Eidson  <beidson@apple.com>
1371
1372         Reviewed by Darin
1373
1374         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
1375
1376         * loader/icon/IconDatabase.cpp:
1377         (WebCore::IconDatabase::IconDatabase): Disabled by default
1378         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
1379         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
1380         (WebCore::IconDatabase::iconForPageURL): Ditto
1381         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
1382         (WebCore::IconDatabase::iconURLForPageURL): Ditto
1383         (WebCore::IconDatabase::retainIconForPageURL): Ditto
1384         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
1385         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
1386         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
1387         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
1388         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
1389
1390 2006-09-20  Adam Roben  <aroben@apple.com>
1391
1392         Reviewed by Adele.
1393
1394         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
1395         REGRESSION: file upload control with direction:rtl or text-align:right
1396         draws button on top of filename/icon
1397
1398         * rendering/RenderFileUploadControl.cpp:
1399         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
1400         match direction
1401         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
1402         the filename and icon in RTL
1403
1404 2006-09-20  Alice Liu  <alice.liu@apple.com>
1405
1406         Reviewed by Adam Roben.
1407
1408         fixed windows build
1409
1410         * dom/WheelEvent.cpp:
1411         (WebCore::WheelEvent::WheelEvent):
1412         changed lrint to lround
1413
1414 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
1415
1416         Build Fix.  Adds isHorizontal attribute back to WheelEvent
1417         for the Objective-C bindings.  If it is found that isHorizontal
1418         is not used, we should remove it again but also remove it's
1419         declaration from PublicDOMInterfaces.h
1420
1421         * dom/WheelEvent.h:
1422         (WebCore::WheelEvent::isHorizontal):
1423         * dom/WheelEvent.idl:
1424
1425 2006-09-20  David Hyatt  <hyatt@apple.com>
1426
1427         Fix for 10945, WheelEvent should support two dimensions at once, since
1428         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
1429         to allow for diagonal scrolling.
1430
1431         Reviewed by Eric
1432
1433         * dom/EventTargetNode.cpp:
1434         (WebCore::EventTargetNode::dispatchWheelEvent):
1435         * dom/WheelEvent.cpp:
1436         (WebCore::WheelEvent::WheelEvent):
1437         (WebCore::WheelEvent::initWheelEvent):
1438         * dom/WheelEvent.h:
1439         (WebCore::WheelEvent::wheelDelta):
1440         (WebCore::WheelEvent::wheelDeltaX):
1441         (WebCore::WheelEvent::wheelDeltaY):
1442         * dom/WheelEvent.idl:
1443         * page/FrameView.cpp:
1444         (WebCore::FrameView::handleWheelEvent):
1445         * platform/PlatformWheelEvent.h:
1446         (WebCore::PlatformWheelEvent::deltaX):
1447         (WebCore::PlatformWheelEvent::deltaY):
1448         (WebCore::PlatformWheelEvent::normalize):
1449         * platform/mac/WheelEventMac.mm:
1450         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1451
1452 2006-09-19  Eric Seidel  <eric@eseidel.com>
1453
1454         Reviewed by hyatt.
1455
1456         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
1457
1458         No tests were harmed in the making of this patch.
1459
1460         * WebCore.xcodeproj/project.pbxproj:
1461         * kcanvas/KCanvasClipper.cpp: Added.
1462         (WebCore::operator<<):
1463         * kcanvas/KCanvasClipper.h: Added.
1464         * kcanvas/KCanvasFilters.h:
1465         * kcanvas/KCanvasImage.h:
1466         * kcanvas/KCanvasMarker.cpp: Added.
1467         * kcanvas/KCanvasMarker.h: Added.
1468         * kcanvas/KCanvasMasker.cpp: Added.
1469         (WebCore::KCanvasMasker::KCanvasMasker):
1470         (WebCore::KCanvasMasker::setMask):
1471         (WebCore::KCanvasMasker::externalRepresentation):
1472         (WebCore::getMaskerById):
1473         * kcanvas/KCanvasMasker.h: Added.
1474         * kcanvas/KCanvasResource.cpp: Added.
1475         (WebCore::KCanvasResource::invalidate):
1476         (WebCore::KCanvasResource::externalRepresentation):
1477         (WebCore::getResourceById):
1478         (WebCore::getPaintServerById):
1479         * kcanvas/KCanvasResource.h: Added.
1480         * kcanvas/KCanvasResources.cpp: Removed.
1481         * kcanvas/KCanvasResources.h: Removed.
1482         * kcanvas/RenderPath.cpp:
1483         * kcanvas/RenderSVGContainer.cpp:
1484         * kcanvas/RenderSVGImage.cpp:
1485         * kcanvas/RenderSVGText.cpp:
1486         * kcanvas/device/KRenderingPaintServer.h:
1487         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1488         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1489         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1490         * ksvg2/svg/SVGClipPathElement.h:
1491         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1492         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
1493         * ksvg2/svg/SVGFECompositeElement.cpp:
1494         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1495         * ksvg2/svg/SVGFELightElement.cpp:
1496         * ksvg2/svg/SVGFEOffsetElement.cpp:
1497         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1498         * ksvg2/svg/SVGFilterElement.cpp:
1499         * ksvg2/svg/SVGLinearGradientElement.cpp:
1500         * ksvg2/svg/SVGMarkerElement.h:
1501         * ksvg2/svg/SVGMaskElement.h:
1502
1503 2006-09-19  Brady Eidson <beidson@apple.com>
1504
1505         Reviewed by Sarge Decker
1506
1507         <rdar://problem/4739892> and <rdar://problem/4729797>
1508         - WebCore::IconDatabase needs to have and respect an enabled() flag
1509         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
1510
1511         * bridge/mac/WebCoreIconDatabaseBridge.h:
1512         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1513         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
1514         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
1515         * loader/icon/IconDatabase.cpp:
1516         (WebCore::IconDatabase::IconDatabase):
1517         (WebCore::IconDatabase::open): Don't open if disabled
1518         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
1519         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
1520         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
1521         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
1522         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
1523         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
1524         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
1525         (WebCore::IconDatabase::releaseIconURL):
1526         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
1527         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
1528         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
1529         (WebCore::IconDatabase::setEnabled): Added
1530         * loader/icon/IconDatabase.h:
1531         (WebCore::IconDatabase::enabled): Added
1532         * page/Frame.cpp:
1533         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
1534         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
1535
1536 2006-09-20  David Hyatt  <hyatt@apple.com>
1537
1538         Massage mouse wheel handling so that it is more cross-platform.  Make
1539         all the work happen in handleWheelEvent on the FrameView.
1540
1541         Reviewed by bradee-oh
1542
1543         * bridge/mac/FrameMac.mm:
1544         (WebCore::FrameMac::wheelEvent):
1545         * page/FrameView.cpp:
1546         (WebCore::FrameView::handleWheelEvent):
1547         * platform/PlatformWheelEvent.h:
1548         (WebCore::PlatformWheelEvent::platformDelta):
1549         (WebCore::PlatformWheelEvent::delta):
1550         * platform/mac/WheelEventMac.mm:
1551         (WebCore::platformDeltaForEvent):
1552         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1553         * rendering/RenderLayer.cpp:
1554         (WebCore::RenderLayer::scroll):
1555         * rendering/RenderObject.cpp:
1556         (WebCore::RenderObject::scroll):
1557
1558 2006-09-19  Eric Seidel  <eric@eseidel.com>
1559
1560         Reviewed by adele.
1561
1562         Improve test output for filters with bounding-box relative sizes.
1563         http://bugzilla.opendarwin.org/show_bug.cgi?id=8585
1564
1565         Many test results updated.
1566
1567         * kcanvas/KCanvasFilters.cpp:
1568         (WebCore::KCanvasFilter::externalRepresentation):
1569
1570 2006-09-19  Eric Seidel  <eric@eseidel.com>
1571
1572         Reviewed by adele.
1573
1574         Markers should clip to their viewport.
1575         http://bugzilla.opendarwin.org/show_bug.cgi?id=5967
1576
1577         Test: svg/custom/marker-overflow-clip.svg
1578
1579         * kcanvas/KCanvasResources.cpp:
1580         (WebCore::KCanvasMarker::KCanvasMarker):
1581         (WebCore::KCanvasMarker::setMarker):
1582         (WebCore::KCanvasMarker::draw):
1583         * kcanvas/KCanvasResources.h:
1584         (WebCore::KCanvasMasker::mask):
1585         * ksvg2/svg/SVGMarkerElement.cpp:
1586         (WebCore::SVGMarkerElement::SVGMarkerElement):
1587         (WebCore::SVGMarkerElement::parseMappedAttribute):
1588         (WebCore::SVGMarkerElement::canvasResource):
1589         (WebCore::SVGMarkerElement::createRenderer):
1590
1591 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1592
1593         Reviewed by eseidel
1594
1595         Backing out my recent change.
1596
1597         * css/cssstyleselector.cpp:
1598         (WebCore::CSSStyleSelector::adjustRenderStyle):
1599
1600 2006-09-19  Brady Eidson  <beidson@apple.com>
1601
1602         Reviewed by Kevin McCullough
1603
1604         http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
1605         Opening a PDF in a new tab/window creates a documentless-frame
1606         and we deref the document without checking its validity
1607
1608         * page/Frame.cpp:
1609         (WebCore::Frame::iconURL):
1610
1611 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1612
1613         Reviewed by harrison
1614
1615         <rdar://problem/4735272>
1616         Can not click into link in programmatically editable content
1617
1618         * css/cssstyleselector.cpp:
1619         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
1620         userModify to implement document wide editability.
1621
1622 2006-09-19  MorganL  <morlmor@yahoo.com>
1623
1624         Reviewed by Darin and landed by Brady
1625
1626         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10939
1627         Build broken when SVG is not enabled.
1628
1629         * dom/XMLTokenizer.cpp:
1630         (WebCore::XMLTokenizer::startElementNs):
1631
1632 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1633
1634         Reviewed by harrison
1635
1636         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
1637
1638         Pasting plain text results in a match style paste, and the insertion
1639         position is whitespace normal, which clobbers the whitespace:pre on
1640         tab spans.  Skip changes to the whitespace mode when computing a style
1641         change for tab spans or the text nodes inside tab spans.
1642
1643         * editing/ApplyStyleCommand.cpp:
1644         (WebCore::StyleChange::init): Don't change the whitespace mode inside
1645         tab spans.
1646
1647 2006-09-19  David Hyatt  <hyatt@apple.com>
1648
1649         Fix for bug 5298, shape=default not supported for image maps.  Implement
1650         support for it.
1651
1652         Reviewed by timo
1653
1654         * html/HTMLAreaElement.cpp:
1655         (WebCore::HTMLAreaElement::getRegion):
1656         * html/HTMLMapElement.cpp:
1657         (WebCore::HTMLMapElement::mapMouseEvent):
1658
1659 2006-09-19  Adam Roben  <aroben@apple.com>
1660
1661         Reviewed by Adele.
1662
1663         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10824
1664         "no file selected" placeholder text missing from file upload control
1665
1666         * WebCore.xcodeproj/project.pbxproj:
1667         * rendering/RenderFileUploadControl.cpp: Remove class
1668         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
1669         defaultWidthNumChars
1670         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
1671         RenderBlock constructor instead of RenderFlexibleBox,
1672         (WebCore::RenderFileUploadControl::setStyle): Remove references to
1673         m_fileBox.
1674         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
1675         instead of updateIconAndFileName() (which has been removed)
1676         (WebCore::RenderFileUploadControl::updateFromElement): Remove
1677         references to m_fileBox, don't call updateIconAndFilename()
1678         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
1679         without using m_fileBox
1680         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
1681         now-unnecessary display:box rule.
1682         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
1683         to paintingDisabled() now that Icon::paint() does it, and add code to
1684         paint the filename directly.
1685         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
1686         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
1687         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
1688         subclass of RenderBlock instead of RenderFlexibleBox, remove
1689         updateIconAndFilename() method, remove m_fileBox instance variable.
1690
1691 2006-09-19  Eric Seidel  <eric@eseidel.com>
1692
1693         Reviewed by hyatt.
1694
1695         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
1696         http://bugzilla.opendarwin.org/show_bug.cgi?id=10846
1697
1698         No automated test case possible until http://bugzilla.opendarwin.org/show_bug.cgi?id=10905 is resolved.
1699
1700         * dom/XMLTokenizer.cpp:
1701         (WebCore::XMLTokenizer::XMLTokenizer):
1702         (WebCore::XMLTokenizer::startElementNs):
1703         (WebCore::XMLTokenizer::endElementNs):
1704
1705 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
1706
1707         Reviewed by eseidel.  Landed by eseidel.
1708
1709         Build fix only, no tests affected.
1710
1711         * platform/gdk/FontPlatformDataGdk.cpp:
1712         (WebCore::FontPlatformData::FontPlatformData):
1713         (WebCore::FontPlatformData::~FontPlatformData):
1714         * platform/gdk/FrameGdk.h:
1715         * platform/gdk/TemporaryLinkStubs.cpp:
1716         (FrameGdk::isLoadTypeReload):
1717         (FrameGdk::originalRequestURL):
1718         (IconDatabase::setIconURLForPageURL):
1719
1720 2006-09-19  David Hyatt  <hyatt@apple.com>
1721
1722         Refine the fix for 9805 to really get all the complex cases right.
1723
1724         Reviewed by Eric
1725
1726         * rendering/RenderBlock.cpp:
1727         (WebCore::RenderBlock::clearFloatsIfNeeded):
1728         (WebCore::RenderBlock::handleBottomOfBlock):
1729
1730 2006-09-18  David Hyatt  <hyatt@apple.com>
1731
1732         Fix for 9805, <hr> not positioned properly following a previous empty sibling
1733         that had clear:both set on it.  Update self-collapsing block clearance
1734         behavior to match what is specified in the latest draft of CSS2.1.
1735
1736         Reviewed by Eric
1737
1738         Added fast/block/margin-collapse/empty-clear-blocks.html
1739
1740         * rendering/RenderBlock.cpp:
1741         (WebCore::RenderBlock::clearFloatsIfNeeded):
1742         (WebCore::RenderBlock::handleBottomOfBlock):
1743
1744 2006-09-18  MorganL  <morlmor@yahoo.com>
1745
1746         Reviewed by Brady, landed by Brady
1747
1748         Send receivedResponse callback to ResourceLoaderClient when loading
1749         file URLs.
1750
1751         See http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
1752
1753         * platform/win/ResourceLoaderWin.cpp:
1754         (WebCore::ResourceLoader::fileLoadTimer):
1755
1756 2006-09-18  Brady Eidson  <beidson@apple.com>
1757
1758         Reviewed by Anders
1759
1760         <rdar://problem/3028061> - WebKit never updates favicon
1761         The WebKit enforced expiration date for icons has worked for some time, but the
1762         move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
1763         functionality.  This patch fixes that up, along with some other architectural improvements,
1764         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
1765
1766         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
1767         * bridge/mac/FrameMac.mm:
1768         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
1769         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
1770         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
1771         * dom/Document.h: Added m_iconURL
1772         (WebCore::Document::iconURL): Added
1773         (WebCore::Document::setIconURL): Ditto
1774         * html/HTMLLinkElement.cpp:
1775         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
1776         * page/Frame.cpp:
1777         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
1778         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
1779         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
1780         * page/FramePrivate.h: Nuked IconURL
1781         * platform/win/TemporaryLinkStubs.cpp:
1782         (FrameWin::isLoadTypeReload):
1783
1784 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
1785
1786         Reviewed by Tim H.
1787
1788         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
1789           it is it turns out that AppKit uses it.
1790
1791         * bindings/objc/DOMPrivate.h:
1792         * bindings/objc/DOMRGBColor.mm:
1793         (-[DOMRGBColor _color]):
1794
1795 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
1796
1797         Reviewed by Tim H.
1798
1799         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
1800         Yet Another Objective-C Bindings Patch
1801
1802         - Whitespace cleanup for IDLParser.pm
1803
1804         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
1805           and DOMAbstractView into their own files.
1806
1807         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
1808           it is not used and a public method is available now.
1809
1810         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
1811           as it not used.
1812
1813         - Auto-generate method isContentEditable for DOMNode.
1814
1815         - General cleanup of bindings code including removing unneeded #imports
1816           and whitespace cleanup
1817
1818         * WebCore.xcodeproj/project.pbxproj:
1819         * bindings/objc/DOM.mm:
1820         (addElementClass):
1821         (elementClass):
1822         (-[DOMNode _initWithNode:WebCore::]):
1823         (+[DOMNode _nodeWith:WebCore::]):
1824         (-[DOMNode WebCore::]):
1825         (-[DOMNode KJS::Bindings::]):
1826         (-[DOMNode addEventListener:::]):
1827         (-[DOMNode removeEventListener:::]):
1828         (-[DOMNode dispatchEvent:]):
1829         (-[DOMElement image]):
1830         (-[DOMElement _font]):
1831         (-[DOMElement _imageTIFFRepresentation]):
1832         (-[DOMElement _getURLAttribute:]):
1833         (-[DOMElement _NPObject]):
1834         (-[DOMElement isFocused]):
1835         (-[DOMRange dealloc]):
1836         (-[DOMRange finalize]):
1837         (-[DOMRange description]):
1838         (-[DOMRange startContainer]):
1839         (-[DOMRange startOffset]):
1840         (-[DOMRange endContainer]):
1841         (-[DOMRange endOffset]):
1842         (-[DOMRange collapsed]):
1843         (-[DOMRange commonAncestorContainer]):
1844         (-[DOMRange setStart::]):
1845         (-[DOMRange setEnd::]):
1846         (-[DOMRange setStartBefore:]):
1847         (-[DOMRange setStartAfter:]):
1848         (-[DOMRange setEndBefore:]):
1849         (-[DOMRange setEndAfter:]):
1850         (-[DOMRange collapse:]):
1851         (-[DOMRange selectNode:]):
1852         (-[DOMRange selectNodeContents:]):
1853         (-[DOMRange compareBoundaryPoints::]):
1854         (-[DOMRange deleteContents]):
1855         (-[DOMRange extractContents]):
1856         (-[DOMRange cloneContents]):
1857         (-[DOMRange insertNode:]):
1858         (-[DOMRange surroundContents:]):
1859         (-[DOMRange cloneRange]):
1860         (-[DOMRange toString]):
1861         (-[DOMRange detach]):
1862         (-[DOMRange _initWithRange:WebCore::]):
1863         (+[DOMRange _rangeWith:WebCore::]):
1864         (-[DOMRange WebCore::]):
1865         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1866         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
1867         (-[DOMNodeFilter WebCore::]):
1868         (-[DOMNodeFilter dealloc]):
1869         (-[DOMNodeFilter finalize]):
1870         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
1871         (-[DOMNodeIterator WebCore::]):
1872         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
1873         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
1874         (-[DOMTreeWalker WebCore::]):
1875         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
1876         (ObjCNodeFilterCondition::acceptNode):
1877         (-[DOMDocument createNodeIterator::::]):
1878         (-[DOMDocument createTreeWalker::::]):
1879         (ObjCEventListener::find):
1880         (ObjCEventListener::create):
1881         (ObjCEventListener::handleEvent):
1882         * bindings/objc/DOMAbstractView.h: Added.
1883         * bindings/objc/DOMAbstractView.mm: Added.
1884         (-[DOMAbstractView document]):
1885         (-[DOMAbstractView WebCore::]):
1886         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
1887         (+[DOMAbstractView _abstractViewWith:WebCore::]):
1888         * bindings/objc/DOMCSS.mm:
1889         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1890         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
1891         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
1892         (-[DOMCSSRule _initWithRule:WebCore::]):
1893         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
1894         (-[DOMCSSValue _initWithValue:WebCore::]):
1895         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1896         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
1897         (-[DOMDocument getComputedStyle::]):
1898         (-[DOMDocument getMatchedCSSRules::]):
1899         * bindings/objc/DOMCore.h:
1900         * bindings/objc/DOMEventException.h: Added.
1901         * bindings/objc/DOMEvents.h:
1902         * bindings/objc/DOMEvents.mm:
1903         * bindings/objc/DOMException.h: Added.
1904         * bindings/objc/DOMHTML.mm:
1905         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
1906         (viewForElement):
1907         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
1908         (-[DOMHTMLInputElement _selectedRange]):
1909         (-[DOMHTMLInputElement _setAutofilled:]):
1910         * bindings/objc/DOMInternal.h:
1911         * bindings/objc/DOMObject.h:
1912         * bindings/objc/DOMPrivate.h:
1913         * bindings/objc/DOMRange.h:
1914         * bindings/objc/DOMRangeException.h: Added.
1915         * bindings/objc/DOMViews.h:
1916         * bindings/objc/DOMViews.mm: Removed.
1917         * bindings/objc/DOMXPath.h:
1918         * bindings/objc/DOMXPathException.h: Added.
1919         * bindings/scripts/IDLParser.pm:
1920         * dom/Node.idl:
1921
1922 2006-09-18  Brady Eidson  <beidson@apple.com>
1923
1924         Windows build fix
1925
1926         * platform/win/TemporaryLinkStubs.cpp:
1927         (IconDatabase::setIconURLForPageURL):
1928
1929 2006-09-18  David Hyatt  <hyatt@apple.com>
1930
1931         Fix for bug 3969, hr width doesn't update when it clears a float.  This
1932         was also a problem with tables and overflow sections.
1933
1934         Reviewed by Eric
1935
1936         Added fast/block/float/width-update-after-clear.html
1937
1938         * rendering/RenderBlock.cpp:
1939         (WebCore::RenderBlock::collapseMargins):
1940         (WebCore::RenderBlock::clearFloatsIfNeeded):
1941
1942 2006-09-18  Brady Eidson  <beidson@apple.com>
1943
1944         Reviewed by John
1945
1946         http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
1947         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
1948
1949         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
1950         * bridge/win/FrameWin.h: Added originalRequestURL()
1951         * loader/icon/IconLoader.cpp:
1952         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
1953         * page/Frame.cpp:
1954         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
1955         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
1956         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
1957         * page/Frame.h: Added pure virtual originalRequestURL()
1958         * platform/win/TemporaryLinkStubs.cpp:
1959         (FrameWin::originalRequestURL): Added
1960
1961 2006-09-18  Rob Buis  <buis@kde.org>
1962
1963         Reviewed by Maciej.
1964
1965         http://bugzilla.opendarwin.org/show_bug.cgi?id=10807
1966         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
1967
1968         Make sure the paint method is not exited without popping
1969         context and transparency layer.
1970
1971         WARNING: NO TEST CASES ADDED OR CHANGED
1972
1973         * kcanvas/RenderSVGImage.cpp:
1974         (WebCore::RenderSVGImage::paint):
1975
1976 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
1977
1978         Reviewed by Eric.
1979
1980         - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10896
1981         REGRESSION: WebKit can't be built with SVG disabled
1982
1983         * bindings/scripts/CodeGeneratorObjC.pm:
1984         For each file generated add a #ifdef <something>_SUPPORT / #endif
1985         pair if the idl file has a Conditional extended attribute
1986
1987 2006-09-17  Eric Seidel  <eric@eseidel.com>
1988
1989         Reviewed by ap.
1990
1991         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
1992         http://bugzilla.opendarwin.org/show_bug.cgi?id=10813
1993
1994         * bridge/mac/WebCoreFrameBridge.mm:
1995         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
1996
1997 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
1998
1999         Reviewed by Hyatt.
2000
2001         http://bugzilla.opendarwin.org/show_bug.cgi?id=10779
2002         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
2003
2004         No test possible.
2005
2006         * platform/Image.cpp:
2007         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
2008         maybe the rest just hasn't been loaded yet.
2009         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
2010         to start animating before we get at least two frames.
2011
2012 2006-09-17  Brady Eidson <beidson@apple.com>
2013
2014         Reviewed by Sarge
2015
2016         IconLoader now gracefully handles the condition where there's no document in the frame
2017         (ie. PDFs)
2018
2019         * loader/icon/IconLoader.cpp:
2020         (IconLoader::startLoading):
2021
2022 2006-09-17  David Hyatt  <hyatt@apple.com>
2023
2024         Fix for bug 10899, rework how CSS keywords work to be smarter about
2025         using the correct size when generic families change (e.g., monospace to
2026         serif and vice versa).
2027
2028         Reviewed by aroben
2029
2030         Added fast/text/basic/generic-family-changes.html
2031
2032         * css/cssstyleselector.cpp:
2033         (WebCore::CSSStyleSelector::applyProperty):
2034         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
2035         (WebCore::CSSStyleSelector::fontSizeForKeyword):
2036         * css/cssstyleselector.h:
2037         * dom/Document.cpp:
2038         (WebCore::Document::recalcStyle):
2039         * platform/FontDescription.h:
2040         (WebCore::FontDescription::FontDescription):
2041         (WebCore::FontDescription::keywordSize):
2042         (WebCore::FontDescription::setKeywordSize):
2043         (WebCore::FontDescription::operator==):
2044
2045 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
2046
2047         Reviewed by Brady.
2048
2049         http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
2050         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
2051
2052         Test: http/tests/xmlhttprequest/xhr-onunload.html
2053
2054         * xml/xmlhttprequest.cpp:
2055         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
2056
2057         * loader/icon/IconLoader.cpp:
2058         (IconLoader::startLoading): Fix a similar latent bug here.
2059
2060 2006-09-17  Adam Roben  <aroben@apple.com>
2061
2062         Build fix.
2063
2064         * loader/icon/IconDatabase.cpp:
2065
2066 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
2067
2068         Reviewed by Brady.
2069
2070         Add simplifyWhiteSpace and stripWhiteSpace to the String class.
2071         Change the XSLT Parameter Map to use Strings instead of StringImpls.
2072         General cleanup.
2073
2074         * bindings/js/JSXSLTProcessor.cpp:
2075         (KJS::XSLTProcessorProtoFunc::callAsFunction):
2076         * bindings/js/kjs_events.cpp:
2077         (KJS::JSAbstractEventListener::handleEvent):
2078         * bindings/js/kjs_window.cpp:
2079         (KJS::ScheduledAction::execute):
2080         * css/MediaList.cpp:
2081         (WebCore::MediaList::setMediaText):
2082         * dom/Document.cpp:
2083         (WebCore::Document::processHttpEquiv):
2084         * editing/ApplyStyleCommand.cpp:
2085         (WebCore::StyleChange::init):
2086         * html/HTMLDocument.cpp:
2087         (WebCore::parseDocTypeDeclaration):
2088         * html/HTMLLinkElement.cpp:
2089         (WebCore::HTMLLinkElement::parseMappedAttribute):
2090         * html/HTMLObjectElement.cpp:
2091         (WebCore::HTMLObjectElement::HTMLObjectElement):
2092         (WebCore::HTMLObjectElement::parseMappedAttribute):
2093         (WebCore::HTMLObjectElement::attach):
2094         (WebCore::HTMLObjectElement::setComplete):
2095         (WebCore::HTMLObjectElement::detach):
2096         (WebCore::HTMLObjectElement::recalcStyle):
2097         (WebCore::HTMLObjectElement::childrenChanged):
2098         (WebCore::HTMLObjectElement::isImageType):
2099         * html/HTMLObjectElement.h:
2100         * html/HTMLOptionElement.cpp:
2101         (WebCore::HTMLOptionElement::value):
2102         * html/HTMLSelectElement.cpp:
2103         (WebCore::HTMLSelectElement::appendFormData):
2104         * html/HTMLTokenizer.cpp:
2105         (WebCore::HTMLTokenizer::parseTag):
2106         * ksvg2/svg/SVGColor.cpp:
2107         (WebCore::SVGColor::setRGBColor):
2108         * ksvg2/svg/SVGDescElement.cpp:
2109         (WebCore::SVGDescElement::description):
2110         * platform/PlatformString.h:
2111         * platform/String.cpp:
2112         (WebCore::String::stripWhiteSpace):
2113         (WebCore::String::simplifyWhiteSpace):
2114         * platform/StringImpl.cpp:
2115         (WebCore::isSpace):
2116         (WebCore::parseLength):
2117         (WebCore::StringImpl::stripWhiteSpace):
2118         (WebCore::StringImpl::simplifyWhiteSpace):
2119         (WebCore::StringImpl::toInt):
2120         * platform/StringImpl.h:
2121         * platform/mac/ClipboardMac.mm:
2122         (WebCore::cocoaTypeFromMIMEType):
2123         * rendering/RenderPartObject.cpp:
2124         (WebCore::RenderPartObject::updateWidget):
2125         * xml/XPathFunctions.cpp:
2126         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
2127         * xml/XPathGrammar.y:
2128         * xml/XPathStep.cpp:
2129         (WebCore::XPath::Step::nodeTestMatches):
2130         * xml/XSLStyleSheet.cpp:
2131         (WebCore::XSLStyleSheet::loadChildSheets):
2132         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
2133         * xml/XSLTProcessor.cpp:
2134         (WebCore::xsltParamArrayFromParameterMap):
2135         (WebCore::XSLTProcessor::setParameter):
2136         (WebCore::XSLTProcessor::getParameter):
2137         (WebCore::XSLTProcessor::removeParameter):
2138         * xml/XSLTProcessor.h:
2139         * xml/xmlhttprequest.cpp:
2140         (WebCore::XMLHttpRequest::getStatusText):
2141
2142 2006-09-17  David Hyatt  <hyatt@apple.com>
2143
2144         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
2145         are declared right before the fieldsets.  It turns out fieldsets in other
2146         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
2147         adding that behavior to fieldset fixes the bug.
2148
2149         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
2150         and fieldsets all subclass.
2151
2152         Reviewed by anders
2153
2154         Added fast/forms/float-before-fieldset.html
2155
2156         * rendering/RenderFieldset.h:
2157         (WebCore::RenderFieldset::avoidsFloats):
2158         * rendering/RenderFlexibleBox.h:
2159         (WebCore::RenderFlexibleBox::avoidsFloats):
2160         * rendering/RenderObject.cpp:
2161         (WebCore::RenderObject::avoidsFloats):
2162         * rendering/RenderObject.h:
2163         * rendering/RenderTable.h:
2164         (WebCore::RenderTable::avoidsFloats):
2165
2166 2006-09-17  David Hyatt  <hyatt@apple.com>
2167
2168         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
2169         "rules" attributes on tables.
2170
2171         Reviewed by bradee-oh
2172
2173         Well-covered by existing layout tests.
2174
2175         * html/HTMLTableCellElement.cpp:
2176         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
2177         * html/HTMLTableColElement.cpp:
2178         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
2179         * html/HTMLTableColElement.h:
2180         * html/HTMLTableElement.cpp:
2181         (WebCore::HTMLTableElement::HTMLTableElement):
2182         (WebCore::HTMLTableElement::~HTMLTableElement):
2183         (WebCore::HTMLTableElement::setCaption):
2184         (WebCore::HTMLTableElement::setTHead):
2185         (WebCore::HTMLTableElement::setTFoot):
2186         (WebCore::HTMLTableElement::setTBody):
2187         (WebCore::HTMLTableElement::createTHead):
2188         (WebCore::HTMLTableElement::deleteTHead):
2189         (WebCore::HTMLTableElement::createTFoot):
2190         (WebCore::HTMLTableElement::deleteTFoot):
2191         (WebCore::HTMLTableElement::createCaption):
2192         (WebCore::HTMLTableElement::deleteCaption):
2193         (WebCore::HTMLTableElement::insertRow):
2194         (WebCore::HTMLTableElement::deleteRow):
2195         (WebCore::HTMLTableElement::addChild):
2196         (WebCore::HTMLTableElement::childrenChanged):
2197         (WebCore::HTMLTableElement::mapToEntry):
2198         (WebCore::HTMLTableElement::parseMappedAttribute):
2199         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
2200         (WebCore::HTMLTableElement::getSharedCellDecl):
2201         (WebCore::HTMLTableElement::getSharedGroupDecl):
2202         (WebCore::HTMLTableElement::attach):
2203         * html/HTMLTableElement.h:
2204         (WebCore::HTMLTableElement::caption):
2205         (WebCore::HTMLTableElement::tHead):
2206         (WebCore::HTMLTableElement::tFoot):
2207         (WebCore::HTMLTableElement::):
2208         * html/HTMLTableRowElement.h:
2209         * html/HTMLTableSectionElement.cpp:
2210         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
2211         * html/HTMLTableSectionElement.h:
2212
2213 2006-09-17  David Hyatt  <hyatt@apple.com>
2214
2215         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
2216         specify their own new font-family list.  Make sure to always
2217         reset the generic family along with the family list when mapping in
2218         new font-family values.
2219
2220         Reviewed by bradee-oh
2221
2222         fast/text/basic/generic-family-reset.html
2223
2224         * css/cssstyleselector.cpp:
2225         (WebCore::CSSStyleSelector::applyProperty):
2226
2227 2006-09-16  Brady Eidson <beidson@apple.com>
2228
2229         Reviewed by Hyatt
2230
2231         Pruning code relating to WebKit's icon loader
2232
2233         * bridge/mac/WebCoreIconDatabaseBridge.h:
2234         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2235         * loader/icon/IconDatabase.h:
2236         * page/Frame.cpp:
2237         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to
2238         its new home
2239
2240 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
2241
2242         Reviewed by Tim H.
2243
2244         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10885
2245         Auto-generate DOMHTMLDocument for the Objective-C bindings
2246
2247         * DerivedSources.make:
2248         * WebCore.xcodeproj/project.pbxproj:
2249         * bindings/objc/DOMExtensions.h:
2250         * bindings/objc/DOMHTML.mm:
2251         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
2252         * bindings/objc/DOMHTMLDocument.h: Removed.
2253         * bindings/objc/DOMHTMLDocument.mm: Removed.
2254         * bindings/objc/PublicDOMInterfaces.h:
2255         * bindings/scripts/CodeGeneratorObjC.pm:
2256         * html/HTMLDocument.idl:
2257         * platform/DeprecatedString.h:
2258         (WebCore::DeprecatedString::operator NSString*):
2259
2260 2006-09-16  Rob Buis  <buis@kde.org>
2261
2262         Reviewed by Eric.
2263
2264         http://bugzilla.opendarwin.org/show_bug.cgi?id=10866
2265         Code in kcanvas/ should not use Private
2266
2267         Remove Private classes and tweak coding style.
2268
2269         WARNING: NO TEST CASES ADDED OR CHANGED
2270
2271         * kcanvas/RenderPath.cpp:
2272         (WebCore::RenderPath::RenderPath):
2273         (WebCore::RenderPath::~RenderPath):
2274         (WebCore::RenderPath::localTransform):
2275         (WebCore::RenderPath::setLocalTransform):
2276         (WebCore::RenderPath::fillContains):
2277         (WebCore::RenderPath::relativeBBox):
2278         (WebCore::RenderPath::setPath):
2279         (WebCore::RenderPath::path):
2280         (WebCore::RenderPath::layout):
2281         * kcanvas/RenderPath.h:
2282         * kcanvas/RenderSVGContainer.cpp:
2283         (WebCore::RenderSVGContainer::RenderSVGContainer):
2284         (WebCore::RenderSVGContainer::~RenderSVGContainer):
2285         (WebCore::RenderSVGContainer::drawsContents):
2286         (WebCore::RenderSVGContainer::setDrawsContents):
2287         (WebCore::RenderSVGContainer::localTransform):
2288         (WebCore::RenderSVGContainer::setLocalTransform):
2289         (WebCore::RenderSVGContainer::layout):
2290         (WebCore::RenderSVGContainer::paint):
2291         (WebCore::RenderSVGContainer::setViewport):
2292         (WebCore::RenderSVGContainer::viewport):
2293         (WebCore::RenderSVGContainer::setViewBox):
2294         (WebCore::RenderSVGContainer::viewBox):
2295         (WebCore::RenderSVGContainer::setAlign):
2296         (WebCore::RenderSVGContainer::align):
2297         (WebCore::RenderSVGContainer::fillContains):
2298         (WebCore::RenderSVGContainer::strokeContains):
2299         (WebCore::RenderSVGContainer::setSlice):
2300         (WebCore::RenderSVGContainer::slice):
2301         * kcanvas/RenderSVGContainer.h:
2302         * kcanvas/device/KRenderingFillPainter.cpp:
2303         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
2304         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
2305         (WebCore::KRenderingFillPainter::fillRule):
2306         (WebCore::KRenderingFillPainter::setFillRule):
2307         (WebCore::KRenderingFillPainter::opacity):
2308         (WebCore::KRenderingFillPainter::setOpacity):
2309         * kcanvas/device/KRenderingFillPainter.h:
2310         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2311         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
2312         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
2313         (WebCore::KRenderingPaintServerGradient::gradientStops):
2314         (WebCore::KRenderingPaintServerGradient::setGradientStops):
2315         (WebCore::KRenderingPaintServerGradient::spreadMethod):
2316         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
2317         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
2318         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
2319         (WebCore::KRenderingPaintServerGradient::gradientTransform):
2320         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
2321         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
2322         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
2323         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
2324         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
2325         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
2326         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
2327         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
2328         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
2329         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
2330         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
2331         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
2332         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
2333         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
2334         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
2335         (WebCore::KRenderingPaintServerGradient::listener):
2336         (WebCore::KRenderingPaintServerGradient::setListener):
2337         * kcanvas/device/KRenderingPaintServerGradient.h:
2338         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2339         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
2340         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
2341         (WebCore::KRenderingPaintServerPattern::setBbox):
2342         (WebCore::KRenderingPaintServerPattern::bbox):
2343         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
2344         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
2345         (WebCore::KRenderingPaintServerPattern::tile):
2346         (WebCore::KRenderingPaintServerPattern::setTile):
2347         (WebCore::KRenderingPaintServerPattern::patternTransform):
2348         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
2349         (WebCore::KRenderingPaintServerPattern::listener):
2350         (WebCore::KRenderingPaintServerPattern::setListener):
2351         * kcanvas/device/KRenderingPaintServerPattern.h:
2352         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2353         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
2354         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
2355         (WebCore::KRenderingPaintServerSolid::color):
2356         (WebCore::KRenderingPaintServerSolid::setColor):
2357         * kcanvas/device/KRenderingPaintServerSolid.h:
2358         * kcanvas/device/KRenderingStrokePainter.cpp:
2359         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
2360         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
2361         (WebCore::KRenderingStrokePainter::strokeWidth):
2362         (WebCore::KRenderingStrokePainter::setStrokeWidth):
2363         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2364         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2365         (WebCore::KRenderingStrokePainter::strokeCapStyle):
2366         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
2367         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
2368         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
2369         (WebCore::KRenderingStrokePainter::dashOffset):
2370         (WebCore::KRenderingStrokePainter::setDashOffset):
2371         (WebCore::KRenderingStrokePainter::dashArray):
2372         (WebCore::KRenderingStrokePainter::setDashArray):
2373         (WebCore::KRenderingStrokePainter::opacity):
2374         (WebCore::KRenderingStrokePainter::setOpacity):
2375         (WebCore::KRenderingStrokePainter::dirty):
2376         (WebCore::KRenderingStrokePainter::setDirty):
2377         * kcanvas/device/KRenderingStrokePainter.h:
2378
2379 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
2380
2381         Reviewed by Anders.
2382
2383         http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
2384         Fix build error
2385
2386         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
2387
2388 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
2389
2390         Reviewed by Anders.
2391
2392         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10886
2393         REGRESSION (r16387): Reproducible crash when mousing over HTML document
2394
2395         - Special case method [DOMNode ownerDocument] to call document() instead
2396           or ownerDocument() to return to the old behavior.
2397
2398         * WebCore.xcodeproj/project.pbxproj:
2399         * bindings/scripts/CodeGeneratorObjC.pm:
2400
2401 2006-09-15  Brady Eidson  <beidson@apple.com>
2402
2403         Reviewed by Tim Hatcher
2404
2405         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
2406         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
2407
2408         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
2409         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
2410         (WebCore::IconDatabase::open): Make sure the directory exists
2411
2412 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2413
2414         Reviewed by Brady.
2415
2416         Make new style ObjC methods public API.
2417
2418         * WebCore.xcodeproj/project.pbxproj:
2419         * bindings/objc/DOMPrivate.h:
2420         * bindings/objc/PublicDOMInterfaces.h:
2421
2422 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
2423
2424         Reviewed by Tim H.
2425
2426         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
2427         Auto-generate DOMNode for the Objective-C bindings
2428
2429         * DerivedSources.make:
2430         * WebCore.xcodeproj/project.pbxproj:
2431         * bindings/objc/DOM.mm:
2432         (-[DOMNode boundingBox]):
2433         (-[DOMNode lineBoxRects]):
2434         * bindings/objc/DOMEvents.h:
2435         * bindings/objc/DOMExtensions.h:
2436         * bindings/objc/DOMNode.h: Removed.
2437         * bindings/objc/DOMNode.mm: Removed.
2438         * bindings/objc/PublicDOMInterfaces.h:
2439         * bindings/scripts/CodeGeneratorObjC.pm:
2440         * dom/Node.idl:
2441
2442 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2443
2444         Reviewed by Justin.
2445
2446         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
2447
2448         * bridge/mac/WebCoreFrameBridge.h:
2449         * bridge/mac/WebCoreFrameBridge.mm:
2450         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
2451         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
2452         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
2453         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
2454         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
2455         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
2456         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2457         (-[WebCoreFrameBridge increaseSelectionListLevel]):
2458         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
2459         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
2460         (-[WebCoreFrameBridge decreaseSelectionListLevel]):
2461         (-[WebCoreFrameBridge insertLineBreak]):
2462         (-[WebCoreFrameBridge insertParagraphSeparator]):
2463         (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
2464         (-[WebCoreFrameBridge insertText:selectInsertedText:]):
2465         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
2466         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
2467         (createMouseEventFromDraggingInfo):
2468         * editing/SelectionController.cpp:
2469         (WebCore::SelectionController::moveTo):
2470         (WebCore::SelectionController::setSelection):
2471         (WebCore::SelectionController::modify):
2472         (WebCore::SelectionController::setBase):
2473         (WebCore::SelectionController::setExtent):
2474         * editing/SelectionController.h:
2475         * page/Frame.cpp:
2476         (WebCore::Frame::revealSelection):
2477         (WebCore::Frame::revealCaret):
2478         * page/Frame.h:
2479
2480 2006-09-15  Brady Eidson  <beidson@apple.com>
2481
2482         Reviewed by Anders
2483
2484         Added the ability to get a mutable char* from a CString, which will copy the internal
2485         buffer if the ref count is greater than 1 so your mutable char* won't affect any other
2486         referrer of that buffer.
2487
2488         * platform/CString.cpp:
2489         (WebCore::CString::mutableData):
2490         (WebCore::CString::copyBufferIfNeeded):
2491         * platform/CString.h:
2492
2493 2006-09-15  Justin Garcia  <justin.garcia@apple.com>
2494
2495         Reviewed by harrison
2496
2497         <rdar://problem/4674869>
2498         REGRESSION: selecting text to write over results in cursor jumping to middle of next line
2499
2500         * editing/SelectionController.cpp:
2501         (WebCore::SelectionController::modify): Added lineBoundary to test fix.
2502         * editing/visible_units.cpp:
2503         (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
2504         position before it, not after it.
2505
2506 2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2507
2508         Reviewed by Adam.
2509
2510         http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
2511         Bug 10864: Linux\GDK build fixes
2512
2513         * Projects/gdk/webcore-gdk.bkl:
2514         * WebCoreSources.bkl:
2515         * platform/gdk/FontCacheGdk.cpp:
2516         * platform/gdk/FontDataGdk.cpp:
2517         (WebCore::FontData::platformInit):
2518         * platform/gdk/FontGdk.cpp:
2519         (WebCore::Font::drawGlyphs):
2520         * platform/gdk/FrameGdk.cpp:
2521         (WebCore::FrameGdk::handleGdkEvent):
2522         * platform/gdk/FrameGdk.h:
2523         * platform/gdk/ImageGdk.cpp: Added.
2524         (WebCore::Image::initPlatformData):
2525         (WebCore::Image::invalidatePlatformData):
2526         (WebCore::Image::loadPlatformResource):
2527         (WebCore::Image::supportsType):
2528         * platform/gdk/RenderPopupMenuGdk.cpp:
2529         (WebCore::RenderPopupMenuGdk::hidePopup):
2530         * platform/gdk/RenderPopupMenuGdk.h:
2531         * platform/gdk/ScreenGdk.cpp:
2532         (WebCore::drawableForPage):
2533         (WebCore::screenRect):
2534         (WebCore::screenDepth):
2535         (WebCore::usableScreenRect):
2536         (WebCore::scaleFactor):
2537         * platform/gdk/SystemTimeLinux.cpp:
2538         (WebCore::currentTime):
2539         * platform/gdk/TemporaryLinkStubs.cpp:
2540         (FrameGdk::bindingRootObject):
2541         (FrameGdk::markMisspellings):
2542         (WebCore::screenDepthPerComponent):
2543         (WebCore::screenIsMonochrome):
2544         (WebCore::fileButtonChooseFileLabel):
2545         (WebCore::fileButtonNoFileSelectedLabel):
2546         (FrameGdk::shouldChangeSelection):
2547         (FrameGdk::respondToChangedSelection):
2548         (FrameGdk::respondToChangedContents):
2549         (Path::contains):
2550         (PlatformScrollBar::PlatformScrollBar):
2551         (PlatformScrollBar::~PlatformScrollBar):
2552         (PlatformScrollBar::width):
2553         (PlatformScrollBar::height):
2554         (PlatformScrollBar::setEnabled):
2555         (PlatformScrollBar::paint):
2556         (PlatformScrollBar::setScrollBarValue):
2557         (PlatformScrollBar::setKnobProportion):
2558         (PlatformScrollBar::setRect):
2559         (ScrollBar::ScrollBar):
2560         (FileChooser::FileChooser):
2561         (FileChooser::~FileChooser):
2562         (FileChooser::openFileChooser):
2563         (FileChooser::basenameForWidth):
2564         (FileChooser::uploadControlDetaching):
2565         (FileChooser::chooseFile):
2566         (Icon::Icon):
2567         (Icon::~Icon):
2568         (Icon::newIconForFile):
2569         (Icon::paint):
2570         (IconLoader::stopLoading):
2571         (IconLoader::startLoading):
2572         (IconLoader::createForFrame):
2573         (IconDatabase::isIconExpiredForIconURL):
2574         (IconDatabase::hasEntryForIconURL):
2575         (IconDatabase::sharedIconDatabase):
2576         * platform/gdk/WidgetGdk.cpp:
2577         * webcore-base.bkl:
2578
2579 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
2580
2581         Reviewed by Eric.
2582
2583         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
2584         Fix svg memory leaks.
2585
2586         Reworked SVGList to deal with RefPtr's for ptr types
2587         which makes manual refcounting unnecessary, and is much safer.
2588
2589         Removing all virtual functions (nullItem) from SVGList, and
2590         also remove SVGListBase. Switch to a similar concept like
2591         Vector/VectorTraits (see new file SVGListTraits.h).
2592
2593         Credits go to Eric/Maciej for the inspiration.
2594
2595         * CMakeLists.txt: Add SVGListTraits.cpp to build
2596         * WebCore.xcodeproj/project.pbxproj: Ditto.
2597         * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
2598         * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
2599         (WebCore::RenderSVGText::translationForAttributes):
2600         * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
2601         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2602         * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
2603         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
2604         * ksvg2/svg/SVGElementInstanceList.h:
2605         * ksvg2/svg/SVGLengthList.cpp: Ditto.
2606         (WebCore::SVGLengthList::SVGLengthList):
2607         * ksvg2/svg/SVGLengthList.h: Ditto.
2608         * ksvg2/svg/SVGList.h: Rewrote, as described above.
2609         (WebCore::SVGListTypeOperations::nullItem):
2610         (WebCore::SVGList::SVGList):
2611         (WebCore::SVGList::~SVGList):
2612         (WebCore::SVGList::clear):
2613         (WebCore::SVGList::getFirst):
2614         (WebCore::SVGList::getLast):
2615         (WebCore::SVGList::getItem):
2616         (WebCore::SVGList::replaceItem):
2617         (WebCore::SVGList::removeItem):
2618         * ksvg2/svg/SVGListTraits.cpp: Added.
2619         * ksvg2/svg/SVGListTraits.h: Added.
2620         (WebCore::):
2621         * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
2622         (WebCore::SVGPathElement::toPathData):
2623         * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
2624         (WebCore::SVGPathSegList::SVGPathSegList):
2625         * ksvg2/svg/SVGPathSegList.h: Ditto.
2626         * ksvg2/svg/SVGTransform.cpp: Style cleanup.
2627         (SVGTransform::SVGTransform):
2628         * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
2629         (SVGTransformList::SVGTransformList):
2630         (SVGTransformList::createSVGTransformFromMatrix):
2631         (SVGTransformList::consolidate):
2632         * ksvg2/svg/SVGTransformList.h: Ditto.
2633         * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
2634         (SVGTransformable::parseTransformAttribute):
2635
2636 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
2637
2638         Reviewed by eseidel.  Landed by eseidel.
2639
2640         Fix build on Qt/Linux and implement Frame::addMessageToConsole to
2641         be able to see javascript errors for instance.
2642
2643         * CMakeLists.txt:
2644         * platform/qt/FrameQt.h:
2645         * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
2646         (WebCore::FrameQt::bindingRootObject):
2647         * platform/qt/TemporaryLinkStubs.cp
2648         (WebCore::IconDatabase::hasEntryForIconURL):
2649         (WebCore::IconDatabase::sharedIconDatabase):
2650
2651 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
2652
2653         Reviewed by Tim H.
2654
2655         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10869
2656         Auto-generate the internal methods for the Objective-C bindings
2657
2658         - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
2659           implementations where standard.  For cases where a custom implementation was
2660           needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
2661
2662         - Some general cleanup of some of the non-generated bindings, to bring them in-
2663           line with what the generated bindings look like.
2664
2665         * bindings/objc/DOM.mm:
2666         (-[DOMNode description]):
2667         * bindings/objc/DOMCSS.mm:
2668         (-[DOMCSSPrimitiveValue WebCore::]):
2669         (-[DOMDocument getComputedStyle::]):
2670         (-[DOMDocument getMatchedCSSRules::]):
2671         * bindings/objc/DOMEvents.mm:
2672         (-[DOMEvent WebCore::]):
2673         * bindings/objc/DOMHTML.mm:
2674         * bindings/objc/DOMHTMLDocument.mm:
2675         (-[DOMHTMLDocument title]):
2676         (-[DOMHTMLDocument setTitle:]):
2677         (-[DOMHTMLDocument referrer]):
2678         (-[DOMHTMLDocument domain]):
2679         (-[DOMHTMLDocument URL]):
2680         (-[DOMHTMLDocument body]):
2681         (-[DOMHTMLDocument setBody:]):
2682         (-[DOMHTMLDocument images]):
2683         (-[DOMHTMLDocument applets]):
2684         (-[DOMHTMLDocument links]):
2685         (-[DOMHTMLDocument forms]):
2686         (-[DOMHTMLDocument anchors]):
2687         (-[DOMHTMLDocument cookie]):
2688         (-[DOMHTMLDocument setCookie:]):
2689         (-[DOMHTMLDocument open]):
2690         (-[DOMHTMLDocument close]):
2691         (-[DOMHTMLDocument write:]):
2692         (-[DOMHTMLDocument writeln:]):
2693         (-[DOMHTMLDocument getElementById:]):
2694         (-[DOMHTMLDocument getElementsByName:]):
2695         (-[DOMHTMLDocument WebCore::]):
2696         (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
2697         * bindings/objc/DOMHTMLOptionElement.mm:
2698         (-[DOMHTMLOptionElement form]):
2699         (-[DOMHTMLOptionElement defaultSelected]):
2700         (-[DOMHTMLOptionElement setDefaultSelected:]):
2701         (-[DOMHTMLOptionElement text]):
2702         (-[DOMHTMLOptionElement index]):
2703         (-[DOMHTMLOptionElement disabled]):
2704         (-[DOMHTMLOptionElement setDisabled:]):
2705         (-[DOMHTMLOptionElement label]):
2706         (-[DOMHTMLOptionElement setLabel:]):
2707         (-[DOMHTMLOptionElement selected]):
2708         (-[DOMHTMLOptionElement setSelected:]):
2709         (-[DOMHTMLOptionElement value]):
2710         (-[DOMHTMLOptionElement setValue:]):
2711         (-[DOMHTMLOptionElement WebCore::]):
2712         (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
2713         * bindings/objc/DOMInternal.h:
2714         * bindings/objc/DOMNode.mm:
2715         (-[DOMNode dealloc]):
2716         (-[DOMNode finalize]):
2717         (-[DOMNode nodeName]):
2718         (-[DOMNode nodeValue]):
2719         (-[DOMNode setNodeValue:]):
2720         (-[DOMNode nodeType]):
2721         (-[DOMNode parentNode]):
2722         (-[DOMNode childNodes]):
2723         (-[DOMNode firstChild]):
2724         (-[DOMNode lastChild]):
2725         (-[DOMNode previousSibling]):
2726         (-[DOMNode nextSibling]):
2727         (-[DOMNode attributes]):
2728         (-[DOMNode ownerDocument]):
2729         (-[DOMNode insertBefore::]):
2730         (-[DOMNode replaceChild::]):
2731         (-[DOMNode removeChild:]):
2732         (-[DOMNode appendChild:]):
2733         (-[DOMNode hasChildNodes]):
2734         (-[DOMNode cloneNode:]):
2735         (-[DOMNode normalize]):
2736         (-[DOMNode isSupported::]):
2737         (-[DOMNode namespaceURI]):
2738         (-[DOMNode prefix]):
2739         (-[DOMNode setPrefix:]):
2740         (-[DOMNode localName]):
2741         (-[DOMNode hasAttributes]):
2742         (-[DOMNode isSameNode:]):
2743         (-[DOMNode isEqualNode:]):
2744         (-[DOMNode isDefaultNamespace:]):
2745         (-[DOMNode lookupPrefix:]):
2746         (-[DOMNode lookupNamespaceURI:]):
2747         (-[DOMNode textContent]):
2748         (-[DOMNode setTextContent:]):
2749         (-[DOMNode boundingBox]):
2750         (-[DOMNode lineBoxRects]):
2751         * bindings/objc/DOMObject.mm:
2752         (-[DOMObject _init]):
2753         * bindings/objc/DOMXPath.mm:
2754         (-[DOMNativeXPathNSResolver dealloc]):
2755         (-[DOMNativeXPathNSResolver finalize]):
2756         (-[DOMNativeXPathNSResolver WebCore::]):
2757         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
2758         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
2759         (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
2760         * bindings/scripts/CodeGeneratorObjC.pm:
2761         * bridge/mac/WebCoreFrameBridge.mm:
2762         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2763         (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
2764         * css/CSSCharsetRule.idl:
2765         * css/CSSFontFaceRule.idl:
2766         * css/CSSImportRule.idl:
2767         * css/CSSMediaRule.idl:
2768         * css/CSSPageRule.idl:
2769         * css/CSSPrimitiveValue.idl:
2770         * css/CSSRule.idl:
2771         * css/CSSStyleRule.idl:
2772         * css/CSSStyleSheet.idl:
2773         * css/CSSUnknownRule.idl:
2774         * css/CSSValue.idl:
2775         * css/CSSValueList.idl:
2776         * css/StyleSheet.idl:
2777         * dom/Event.idl:
2778         * dom/KeyboardEvent.idl:
2779         * dom/MouseEvent.idl:
2780         * dom/MutationEvent.idl:
2781         * dom/NodeIterator.idl:
2782         * dom/OverflowEvent.idl:
2783         * dom/TreeWalker.idl:
2784         * dom/UIEvent.idl:
2785         * dom/WheelEvent.idl:
2786
2787 2006-09-15  Adam Roben  <aroben@apple.com>
2788
2789         Reviewed by timothy.
2790
2791         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
2792         New file upload control should match the width of the old one
2793
2794         Make width of new file upload control match the old one as closely as
2795         possible.
2796
2797         * rendering/RenderFileUploadControl.cpp:
2798
2799 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2800
2801         Reviewed by Eric.
2802
2803         Remove the SVG IDL files from the Copy Resources phase.
2804
2805         * WebCore.xcodeproj/project.pbxproj:
2806
2807 2006-09-15  Brady Eidson  <beidson@apple.com>
2808
2809         Reviewed by Eric Siedel
2810
2811         Dumped the use of CGColorRef and directly use the floating point data from
2812         WebCore::Color
2813
2814         This fixes the performance regression found between 16285 and 16286
2815
2816         * platform/mac/FontMac.mm:
2817         (WebCore::Font::drawComplexText):
2818         (WebCore::Font::drawGlyphs):
2819
2820 2006-09-14  Mark Rowe  <opendarwin.org@bdash.net.nz>
2821
2822         Reviewed by Adam.
2823
2824         http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
2825         Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate
2826
2827         FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
2828         Frame::cleanupPluginObjects method is called from Frame's destructor, which results
2829         in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.
2830
2831         * bridge/mac/FrameMac.mm:
2832         (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
2833         will be called from Frame::clear
2834         * page/Frame.cpp:
2835         (WebCore::Frame::~Frame): Use cancelAndClear.
2836         (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
2837         FrameMac can use.
2838         * page/Frame.h:
2839
2840 2006-09-14  Brady Eidson  <beidson@apple.com>
2841
2842         Reviewed by Maciej's rubber stamp
2843
2844         Exact same fix I just made, but in the other method I horked up
2845         Also added a reference to the bugzilla in comments
2846
2847         * page/Frame.cpp:
2848         (WebCore::Frame::endIfNotLoading):
2849         (WebCore::Frame::stop):
2850
2851 2006-09-14  Brady Eidson  <beidson@apple.com>
2852
2853         Reviewed by Maciej
2854
2855         Fixed a bad iFrame crash, resolving some of the layout test badness
2856
2857         * page/Frame.cpp:
2858         (WebCore::Frame::endIfNotLoading):
2859         - Added a RefPtr to protect the frame itself to prevent its destruction during this method
2860
2861 2006-09-14  Justin Garcia  <justin.garcia@apple.com>
2862
2863         Reviewed by harrison
2864
2865         <rdar://problem/4655880> Up/Down arrows skip over To Do
2866
2867         * bridge/mac/WebCoreFrameBridge.mm:
2868         (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
2869         * dom/Node.cpp: Removed the unused inSameRootEditableElement.
2870         * dom/Node.h:
2871         * editing/SelectionController.cpp:
2872         (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
2873         * editing/visible_units.cpp:
2874         (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
2875         editable content into editable content that's embedded in non-editable content.
2876         (WebCore::nextLinePosition): Ditto.
2877         (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
2878         This is the behavior that callers desire.  This fixes Command + Up/Down.
2879         (WebCore::endOfEditableContent): Ditto.
2880         * editing/visible_units.h:
2881
2882 2006-09-14  Karthik Kumar  <karthikkumar@gmail.com>
2883
2884         Reviewed by timothy. Landed by aroben.
2885
2886         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
2887         Windows build fixes after r16360
2888
2889         * WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to
2890         AdditionalIncludeDirectories
2891         * platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader,
2892         IconDatabase
2893         (IconLoader::stopLoading):
2894         (IconLoader::startLoading):
2895         (IconLoader::createForFrame):
2896         (IconDatabase::isIconExpiredForIconURL):
2897         (IconDatabase::hasEntryForIconURL):
2898         (IconDatabase::sharedIconDatabase):
2899
2900 2006-09-14  Brady Eidson  <beidson@apple.com>
2901
2902         Part of a build fix for Windows - rest will be working out a mess of temporary link stubs
2903
2904         * loader/icon/IconLoader.cpp:
2905         (IconLoader::receivedAllData):
2906         * page/Frame.cpp:
2907         * page/FramePrivate.h:
2908
2909 2006-09-14  Graham Dennis  <graham.dennis@gmail.com>
2910
2911         Reviewed by Justin Garcia.
2912
2913         - http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
2914           Crash in ApplyStyleCommand::applyRelativeFontStyleChange
2915
2916         * editing/ApplyStyleCommand.cpp:
2917         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by
2918         makeing sure that the 'beyondEnd' node is after the start node.
2919
2920 2006-09-14  MorganL  <morlmor@yahoo.com>
2921
2922         Reviewed by Brady.
2923
2924         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
2925         Various bugs/crashes in ResourceLoaderWin with local files.
2926
2927         * platform/ResourceLoaderInternal.h:
2928         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2929         * platform/win/ResourceLoaderWin.cpp:
2930         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
2931         (WebCore::ResourceLoader::fileLoadTimer):
2932
2933 2006-09-13  Brady Eidson <beidson@apple.com>
2934
2935         Reviewed by Maciej
2936
2937         Icon loads now take place in WebCore
2938
2939         * WebCore.xcodeproj/project.pbxproj:
2940         * bridge/BrowserExtension.h:
2941         * bridge/mac/BrowserExtensionMac.h:
2942         * bridge/mac/BrowserExtensionMac.mm:
2943         - Moved enforcement of a Mozilla Favicon extension elsewhere
2944
2945         * bridge/mac/FrameMac.h:
2946         * bridge/mac/FrameMac.mm:
2947         (WebCore::FrameMac::originalRequestURL):
2948         - Added accessor to "original request URL"
2949
2950         * bridge/mac/WebCoreFrameBridge.h:
2951         - Removed methods to set the iconURL as all loading is now done in WebCore
2952         - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL
2953
2954         * html/HTMLLinkElement.cpp:
2955         (WebCore::HTMLLinkElement::process):
2956         - Moved enforcement of a Mozilla Favicon extension elsewhere
2957
2958         * loader/icon/IconDatabase.cpp:
2959         (WebCore::IconDatabase::setIconURLForPageURL):
2960         - Changed an ASSERT to correctly handle a sketchy (invalid) situation
2961
2962         * loader/icon/IconLoader.h: Added.
2963         * loader/icon/IconLoader.cpp: Added.
2964         (IconLoader::IconLoader):
2965         (IconLoader::createForFrame):
2966         - Static factory method with a private constructor to enforce
2967           "you MUST have a Frame to create an IconLoader" semantics
2968         (IconLoader::~IconLoader):
2969         (IconLoader::startLoading):
2970         (IconLoader::stopLoading):
2971         (IconLoader::receivedData):
2972         - ResourceLoaderClient delegate
2973         (IconLoader::receivedAllData):
2974         - Ditto
2975
2976         * loader/mac/IconLoaderMac.mm: Added.
2977         (IconLoader::receivedResponse):
2978         (IconLoader::notifyIconChanged):
2979         - For now, these are platform specific methods
2980         - One to get the HTTP response code of an icon load
2981         - The other to call through to the app when the icon has changed (loaded)
2982
2983         * page/Frame.h:
2984         * page/Frame.cpp:
2985         (WebCore::Frame::iconURL):
2986         (WebCore::Frame::setIconURL):
2987         - Frame objects now have an inherent icon URL and a way to calculate/access it
2988         (WebCore::Frame::endIfNotLoading):
2989         - This is where we actually kick off the IconLoader
2990         (WebCore::Frame::stop):
2991         - Added call to stop loading the icon
2992
2993         * page/FramePrivate.h:
2994         (WebCore::FramePrivate::FramePrivate):
2995         (WebCore::FramePrivate::~FramePrivate):
2996         - Added the icon URL as a private member
2997         - Added the IconLoader as a private member, and clean it up on deletion
2998
2999         * platform/mac/ResourceLoaderMac.mm:
3000         (WebCore::ResourceLoader::start):  Added a valuable ASSERT
3001
3002 2006-09-13  David Hyatt  <hyatt@apple.com>
3003
3004         Fix for 10841, unable to check checkboxes inside labels.
3005
3006         Reviewed by xenon, bradee-oh
3007
3008         * css/html4.css:
3009         * dom/Element.cpp:
3010         (WebCore::Element::contains):
3011         * dom/Element.h:
3012         * html/HTMLLabelElement.cpp:
3013         (WebCore::HTMLLabelElement::defaultEventHandler):
3014
3015 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
3016
3017         Reviewed by Adam.
3018
3019         http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
3020         Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller
3021
3022         * platform/mac/FileChooserMac.mm:
3023         (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
3024
3025 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
3026
3027         Reviewed by Eric.
3028
3029         http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
3030         Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef
3031
3032         * platform/mac/FontMac.mm:
3033         (WebCore::Font::drawComplexText): Release CGColorRef after use.
3034         (WebCore::Font::drawGlyphs): Ditto.
3035
3036 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
3037
3038         Try fixing the Win32 build.
3039
3040         * bridge/win/FrameWin.h:
3041         * platform/win/TemporaryLinkStubs.cpp:
3042         (FrameWin::bindingRootObject):
3043
3044 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
3045
3046         Reviewed by Tim O.
3047
3048         Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.
3049
3050         * bindings/js/kjs_binding.cpp:
3051         (KJS::ScriptInterpreter::createLanguageInstanceForValue):
3052         * bindings/js/kjs_dom.cpp:
3053         (KJS::getRuntimeObject):
3054         * bridge/mac/FrameMac.h:
3055         * config.h:
3056         * html/HTMLAppletElement.cpp:
3057         (WebCore::HTMLAppletElement::~HTMLAppletElement):
3058         (WebCore::HTMLAppletElement::detach):
3059         * html/HTMLAppletElement.h:
3060         * html/HTMLEmbedElement.cpp:
3061         (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
3062         (WebCore::HTMLEmbedElement::detach):
3063         * html/HTMLEmbedElement.h:
3064         * html/HTMLObjectElement.cpp:
3065         (WebCore::HTMLObjectElement::~HTMLObjectElement):
3066         (WebCore::HTMLObjectElement::detach):
3067         * html/HTMLObjectElement.h:
3068         * html/HTMLPlugInElement.cpp:
3069         (WebCore::HTMLPlugInElement::HTMLPlugInElement):
3070         (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
3071         (WebCore::HTMLPlugInElement::createNPObject):
3072         * html/HTMLPlugInElement.h:
3073         * page/Frame.h:
3074
3075 2006-09-13  David Hyatt  <hyatt@apple.com>
3076
3077         Clean up the XBL and XSLT ifdefs to be consistent with the SVG
3078         and XPath ifdefs.  KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
3079         KHTML_XSLT is now XSLT_SUPPORT.
3080
3081         * WebCore.xcodeproj/project.pbxproj:
3082         * bindings/js/JSXSLTProcessor.cpp:
3083         * bindings/js/JSXSLTProcessor.h:
3084         * bindings/js/kjs_window.cpp:
3085         (KJS::Window::getValueProperty):
3086         * config.h:
3087         * css/CSSComputedStyleDeclaration.cpp:
3088         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3089         * css/cssparser.cpp:
3090         (WebCore::CSSParser::parseValue):
3091         * css/cssstyleselector.cpp:
3092         (WebCore::CSSStyleSelector::applyProperty):
3093         * dom/Document.cpp:
3094         (WebCore::Document::Document):
3095         (WebCore::Document::~Document):
3096         (WebCore::Document::recalcStyleSelector):
3097         * dom/Document.h:
3098         (WebCore::Document::bindingManager):
3099         * dom/Node.cpp:
3100         (WebCore::Node::createRendererIfNeeded):
3101         * dom/ProcessingInstruction.cpp:
3102         (WebCore::ProcessingInstruction::ProcessingInstruction):
3103         (WebCore::ProcessingInstruction::checkStyleSheet):
3104         (WebCore::ProcessingInstruction::setStyleSheet):
3105         * dom/ProcessingInstruction.h:
3106         * dom/XMLTokenizer.cpp:
3107         (WebCore::XMLTokenizer::processingInstruction):
3108         (WebCore::XMLTokenizer::insertErrorMessageBlock):
3109         * dom/XMLTokenizer.h:
3110         * loader/Cache.cpp:
3111         (WebCore::Cache::getStatistics):
3112         * loader/Cache.h:
3113         * loader/CachedResource.h:
3114         (WebCore::CachedResource::):
3115         * loader/CachedResourceClient.h:
3116         * loader/CachedXBLDocument.cpp:
3117         * loader/CachedXBLDocument.h:
3118         * loader/CachedXSLStyleSheet.cpp:
3119         * loader/CachedXSLStyleSheet.h:
3120         * loader/DocLoader.cpp:
3121         * loader/DocLoader.h:
3122         * rendering/RenderStyle.cpp:
3123         (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
3124         (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData):
3125         (WebCore::StyleCSS3NonInheritedData::operator==):
3126         * rendering/RenderStyle.h:
3127         * xml/XSLImportRule.cpp:
3128         * xml/XSLImportRule.h:
3129         * xml/XSLStyleSheet.cpp:
3130         * xml/XSLStyleSheet.h:
3131         * xml/XSLTProcessor.cpp:
3132         * xml/XSLTProcessor.h:
3133
3134 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
3135
3136         Reviewed by eseidel.  Landed by eseidel.
3137
3138         Fix newly introduced memory leaks in SVG.
3139         http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
3140
3141         * ksvg2/svg/SVGList.h:
3142         (WebCore::SVGListBase::~SVGListBase):
3143         (WebCore::SVGListBase::clearVector):
3144         (WebCore::SVGListBase::clear):
3145         (WebCore::SVGList::clearVector):
3146         (WebCore::):
3147         * ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that!
3148         (SVGNumberList::SVGNumberList):
3149         * ksvg2/svg/SVGNumberList.h: Ditto.
3150
3151 2006-09-13  MorganL  <morlmor@yahoo.com>
3152
3153         Reviewed/landed by aroben.
3154
3155         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
3156         Windows build needs fixed after move to engine-rendered file upload widget
3157
3158         * WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files,
3159         remove RenderFileButton files
3160         * platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon
3161         (FileChooser::FileChooser):
3162         (FileChooser::~FileChooser):
3163         (FileChooser::openFileChooser):
3164         (FileChooser::basenameForWidth):
3165         (FileChooser::uploadControlDetaching):
3166         (FileChooser::chooseFile):
3167         (WebCore::fileButtonChooseFileLabel):
3168         (WebCore::fileButtonNoFileSelectedLabel):
3169         (Icon::Icon):
3170         (Icon::~Icon):
3171         (Icon::newIconForFile):
3172         (Icon::paint):
3173
3174 2006-09-13  MorganL  <morlmor@yahoo.com>
3175
3176         Reviewed/landed by aroben.
3177
3178         Fixes http://bugzilla.opendarwin.org/attachment.cgi?id=10537
3179         Webkit WebCore build fails on Windows
3180
3181         * WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT
3182         variable
3183
3184 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
3185
3186         Reviewed by Tim H.
3187
3188         Fix Qt/Linux build.
3189
3190         * CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
3191         * platform/Icon.h: Add wtf/Platform.h include
3192         * platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though.
3193         (WebCore::FileChooser::FileChooser):
3194         (WebCore::FileChooser::~FileChooser):
3195         (WebCore::FileChooser::openFileChooser):
3196         (WebCore::FileChooser::basenameForWidth):
3197         (WebCore::FileChooser::uploadControlDetaching):
3198         (WebCore::FileChooser::chooseFile):
3199         * platform/qt/IconQt.cpp: Added as stub.
3200         (WebCore::Icon::Icon):
3201         (WebCore::Icon::~Icon):
3202         (WebCore::Icon::newIconForFile):
3203         (WebCore::Icon::paint):
3204         * platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed
3205         (searchableIndexIntroduction):
3206         (fileButtonChooseFileLabel):
3207         (fileButtonNoFileSelectedLabel):
3208
3209 2006-09-12  Adam Roben  <aroben@apple.com>
3210
3211         Reviewed by eseidel.
3212
3213         Switch back to passing relative paths to generate-bindings.pl when
3214         generating JS bindings.
3215
3216         * DerivedSources.make: Pass in relative paths to generate-bindings.pl
3217         * bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call
3218         chdir and always construct absolute paths instead.
3219
3220 2006-09-12  David Hyatt  <hyatt@apple.com>
3221
3222         Fix for bug 3244, implement html4 label support.
3223
3224         Reviewed by mjs, aroben
3225
3226         Added fast/events/label-focus.html
3227
3228         * css/html4.css:
3229         * html/HTMLLabelElement.cpp:
3230         (WebCore::HTMLLabelElement::formElement):
3231         (WebCore::HTMLLabelElement::setActive):
3232         (WebCore::HTMLLabelElement::setHovered):
3233         (WebCore::HTMLLabelElement::defaultEventHandler):
3234         * html/HTMLLabelElement.h:
3235
3236 2006-09-12  Julien Palmas  <julien.palmas@gmail.com>
3237
3238         Reviewed by darin.  Landed by eseidel.
3239
3240         * ksvg2/svg/svgpathparser.cpp:
3241         (WebCore::SVGPolyParser::parsePoints):
3242
3243 2006-09-11  Kevin McCullough  <KMcCullough@apple.com>
3244
3245         Reviewed by Andersca, Maciej, Brady.
3246
3247         - Implemented intersectsNode in the Range Class
3248           to be compliant with Mozilla standard
3249
3250         * dom/Range.cpp:
3251         (WebCore::Range::intersectsNode):
3252         * dom/Range.h:
3253         * dom/Range.idl:
3254
3255 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>
3256
3257         Reviewed by eseidel.  Landed by eseidel.
3258
3259         Test: svg/W3C-SVG-1.1/struct-dom-01-b.svg (fixed)
3260         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10826
3261
3262         Also finally fixes some long outstanding bugs:
3263         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9190
3264         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9229
3265         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10413
3266
3267         Enable all JavaScript SVG bindings. Builds on Qt/Linux & OSX.
3268
3269         * CMakeLists.txt:
3270         * DerivedSources.make:
3271         * WebCore.xcodeproj/project.pbxproj:
3272         * bindings/scripts/CodeGenerator.pm:
3273         * bindings/scripts/CodeGeneratorJS.pm:
3274         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
3275         * ksvg2/svg/SVGAElement.idl: Added.
3276         * ksvg2/svg/SVGAngle.idl:
3277         * ksvg2/svg/SVGAnimateColorElement.idl: Added.
3278         * ksvg2/svg/SVGAnimateElement.idl: Added.
3279         * ksvg2/svg/SVGAnimateTransformElement.idl: Added.
3280         * ksvg2/svg/SVGAnimatedLengthList.idl: Added.
3281         * ksvg2/svg/SVGAnimatedNumberList.idl: Added.
3282         * ksvg2/svg/SVGAnimatedTransformList.idl: Added.
3283         * ksvg2/svg/SVGAnimationElement.idl: Added.
3284         * ksvg2/svg/SVGCircleElement.idl: Added.
3285         * ksvg2/svg/SVGClipPathElement.idl: Added.
3286         * ksvg2/svg/SVGColor.idl:
3287         * ksvg2/svg/SVGComponentTransferFunctionElement.idl: Added.
3288         * ksvg2/svg/SVGCursorElement.idl: Added.
3289         * ksvg2/svg/SVGDefsElement.idl: Added.
3290         * ksvg2/svg/SVGDescElement.idl: Added.
3291         * ksvg2/svg/SVGEllipseElement.idl: Added.
3292         * ksvg2/svg/SVGEvent.idl:
3293         * ksvg2/svg/SVGExternalResourcesRequired.idl: Added.
3294         * ksvg2/svg/SVGFEBlendElement.idl: Added.
3295         * ksvg2/svg/SVGFEColorMatrixElement.idl: Added.
3296         * ksvg2/svg/SVGFEComponentTransferElement.idl: Added.
3297         * ksvg2/svg/SVGFECompositeElement.idl: Added.
3298         * ksvg2/svg/SVGFEDiffuseLightingElement.idl: Added.
3299         * ksvg2/svg/SVGFEDisplacementMapElement.idl: Added.
3300         * ksvg2/svg/SVGFEDistantLightElement.idl: Added.
3301         * ksvg2/svg/SVGFEFloodElement.idl: Added.
3302         * ksvg2/svg/SVGFEFuncAElement.idl: Added.
3303         * ksvg2/svg/SVGFEFuncBElement.idl: Added.
3304         * ksvg2/svg/SVGFEFuncGElement.idl: Added.
3305         * ksvg2/svg/SVGFEFuncRElement.idl: Added.
3306         * ksvg2/svg/SVGFEGaussianBlurElement.idl: Added.
3307         * ksvg2/svg/SVGFEImageElement.idl: Added.
3308         * ksvg2/svg/SVGFEMergeElement.idl: Added.
3309         * ksvg2/svg/SVGFEMergeNodeElement.idl: Added.
3310         * ksvg2/svg/SVGFEOffsetElement.idl: Added.
3311         * ksvg2/svg/SVGFEPointLightElement.idl: Added.
3312         * ksvg2/svg/SVGFESpecularLightingElement.idl: Added.
3313         * ksvg2/svg/SVGFESpotLightElement.idl: Added.
3314         * ksvg2/svg/SVGFETileElement.idl: Added.
3315         * ksvg2/svg/SVGFETurbulenceElement.idl: Added.
3316         * ksvg2/svg/SVGFilterElement.idl: Added.
3317         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
3318         * ksvg2/svg/SVGFitToViewBox.idl: Added.
3319         * ksvg2/svg/SVGForeignObjectElement.idl: Added.
3320         * ksvg2/svg/SVGGElement.idl: Added.
3321         * ksvg2/svg/SVGGradientElement.idl: Added.
3322         * ksvg2/svg/SVGImageElement.idl: Added.
3323         * ksvg2/svg/SVGLangSpace.idl: Added.
3324         * ksvg2/svg/SVGLength.idl:
3325         * ksvg2/svg/SVGLengthList.idl: Added.
3326         * ksvg2/svg/SVGLineElement.idl: Added.
3327         * ksvg2/svg/SVGLinearGradientElement.idl: Added.
3328         * ksvg2/svg/SVGLocatable.idl: Added.
3329         * ksvg2/svg/SVGMarkerElement.idl: Added.
3330         * ksvg2/svg/SVGMaskElement.idl: Added.
3331         * ksvg2/svg/SVGNumberList.idl: Added.
3332         * ksvg2/svg/SVGPaint.idl: Added.
3333         * ksvg2/svg/SVGPathElement.idl:
3334         * ksvg2/svg/SVGPathSeg.idl:
3335         * ksvg2/svg/SVGPatternElement.idl: Added.
3336         * ksvg2/svg/SVGPointList.idl: Added.
3337         * ksvg2/svg/SVGPolygonElement.idl: Added.
3338         * ksvg2/svg/SVGPolylineElement.idl: Added.
3339         * ksvg2/svg/SVGPreserveAspectRatio.idl:
3340         * ksvg2/svg/SVGRadialGradientElement.idl: Added.
3341         * ksvg2/svg/SVGRectElement.idl: Added.
3342         * ksvg2/svg/SVGRenderingIntent.idl: Added.
3343         * ksvg2/svg/SVGSVGElement.idl:
3344         * ksvg2/svg/SVGScriptElement.idl: Added.
3345         * ksvg2/svg/SVGSetElement.idl: Added.
3346         * ksvg2/svg/SVGStopElement.idl: Added.
3347         * ksvg2/svg/SVGStringList.idl: Added.
3348         * ksvg2/svg/SVGStylable.idl: Added.
3349         * ksvg2/svg/SVGStyleElement.idl: Added.
3350         * ksvg2/svg/SVGSwitchElement.idl: Added.
3351         * ksvg2/svg/SVGSymbolElement.idl: Added.
3352         * ksvg2/svg/SVGTRefElement.idl: Added.
3353         * ksvg2/svg/SVGTSpanElement.idl: Added.
3354         * ksvg2/svg/SVGTests.idl: Added.
3355         * ksvg2/svg/SVGTextContentElement.idl: Added.
3356         * ksvg2/svg/SVGTextElement.idl: Added.
3357         * ksvg2/svg/SVGTextPositioningElement.idl: Added.
3358         * ksvg2/svg/SVGTitleElement.idl: Added.
3359         * ksvg2/svg/SVGTransform.idl:
3360         * ksvg2/svg/SVGTransformList.idl: Added.
3361         * ksvg2/svg/SVGTransformable.idl: Added.
3362         * ksvg2/svg/SVGURIReference.idl: Added.
3363         * ksvg2/svg/SVGUnitTypes.idl: Added.
3364         * ksvg2/svg/SVGUseElement.idl: Added.
3365         * ksvg2/svg/SVGViewElement.idl: Added.
3366         * ksvg2/svg/SVGZoomAndPan.idl: Added.
3367         * ksvg2/svg/SVGZoomEvent.idl: Added.
3368
3369 2006-09-12  Adam Roben  <aroben@apple.com>
3370
3371         Reviewed by timo, ggaren.
3372
3373         Make Icon ref-counted.
3374
3375         * platform/FileChooser.h: Store m_icon as a RefPtr instead of
3376         auto_ptr.
3377         * platform/Icon.h: Inherit from Shared<Icon>
3378         * platform/mac/FileChooserMac.mm:
3379         (WebCore::FileChooser::chooseFile): Update m_icon usage
3380         * platform/mac/IconMac.mm:
3381         (WebCore::Icon::newIconForFile): Return a RefPtr instead of an
3382         auto_ptr
3383
3384 === Safari-521.26 ===
3385
3386 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>
3387
3388         Reviewed by Anders.
3389
3390         Add exception codes to SVGList functions, adjust all code using it.
3391
3392         Move SVGPaintType enums from ksvg.h into SVGPaint (needed for js generation)
3393         Move SVGUnitTypes enums from ksvg.h into it's own file SVGUnitType.h (ditto)
3394         Move SVGRenderingIntent enums from ksvg.h into it's own file SVGRenderingIntent.h (ditto)
3395         Move SVGZoomAndPan enums from ksvg.h into SVGSVGElement (ditto)
3396         Move SVGFE* related enums into their respecitive classes.
3397
3398         Fix JSSVGNumber to operator on doubles, instead of floats.
3399
3400         * ksvg2/bindings/js/JSSVGNumber.cpp:
3401         (WebCore::getJSSVGNumber):
3402         * ksvg2/bindings/js/JSSVGNumber.h:
3403         (WebCore::JSSVGNumber::JSSVGNumber):
3404         * ksvg2/css/SVGCSSParser.cpp:
3405         (WebCore::CSSParser::parseSVGValue):
3406         (WebCore::CSSParser::parseSVGPaint):
3407         * ksvg2/css/SVGRenderStyleDefs.cpp:
3408         (StyleFillData::operator==):
3409         * ksvg2/ksvg.h:
3410         * ksvg2/misc/KCanvasRenderingStyle.cpp:
3411         (WebCore::KSVGPainterFactory::isFilled):
3412         (WebCore::KSVGPainterFactory::fillPaintServer):
3413         (WebCore::KSVGPainterFactory::isStroked):
3414         (WebCore::KSVGPainterFactory::strokePaintServer):
3415         * ksvg2/misc/KSVGTimeScheduler.cpp:
3416         (WebCore::SVGTimer::notifyAll):
3417         * ksvg2/svg/SVGAnimateColorElement.cpp:
3418         (WebCore::SVGAnimateColorElement::handleTimerEvent):
3419         * ksvg2/svg/SVGAnimateTransformElement.cpp:
3420         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
3421         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
3422         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
3423         (WebCore::SVGAnimateTransformElement::parseTransformValue):
3424         * ksvg2/svg/SVGAnimateTransformElement.h:
3425         * ksvg2/svg/SVGAnimatedTemplate.h:
3426         * ksvg2/svg/SVGAnimationElement.cpp:
3427         (SVGAnimationElement::getSimpleDuration):
3428         (SVGAnimationElement::parseMappedAttribute):
3429         (SVGAnimationElement::setTargetAttribute):
3430         * ksvg2/svg/SVGAnimationElement.h:
3431         * ksvg2/svg/SVGClipPathElement.cpp:
3432         (SVGClipPathElement::SVGClipPathElement):
3433         (SVGClipPathElement::parseMappedAttribute):
3434         (SVGClipPathElement::canvasResource):
3435         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
3436         (SVGComponentTransferFunctionElement::transferFunction):
3437         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
3438         (WebCore::SVGComponentTransferFunctionElement::):
3439         * ksvg2/svg/SVGDocument.cpp:
3440         (WebCore::SVGDocument::dispatchZoomEvent):
3441         (WebCore::SVGDocument::dispatchScrollEvent):
3442         * ksvg2/svg/SVGFEBlendElement.cpp:
3443         (WebCore::SVGFEBlendElement::parseMappedAttribute):
3444         (WebCore::SVGFEBlendElement::filterEffect):
3445         * ksvg2/svg/SVGFEBlendElement.h:
3446         (WebCore::SVGFEBlendElement::):
3447         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3448         (SVGFEColorMatrixElement::parseMappedAttribute):
3449         (SVGFEColorMatrixElement::filterEffect):
3450         * ksvg2/svg/SVGFEColorMatrixElement.h:
3451         (WebCore::SVGFEColorMatrixElement::):
3452         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
3453         (WebCore::SVGFEComponentTransferElement::parseMappedAttribute):
3454         (WebCore::SVGFEComponentTransferElement::filterEffect):
3455         * ksvg2/svg/SVGFEComponentTransferElement.h:
3456         * ksvg2/svg/SVGFECompositeElement.cpp:
3457         (SVGFECompositeElement::parseMappedAttribute):
3458         (SVGFECompositeElement::filterEffect):
3459         * ksvg2/svg/SVGFECompositeElement.h:
3460         (WebCore::SVGFECompositeElement::):
3461         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3462         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
3463         (WebCore::SVGFEDiffuseLightingElement::filterEffect):
3464         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
3465         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3466         (SVGFEDisplacementMapElement::parseMappedAttribute):
3467         (SVGFEDisplacementMapElement::filterEffect):
3468         * ksvg2/svg/SVGFEDisplacementMapElement.h:
3469         (WebCore::SVGFEDisplacementMapElement::):
3470         * ksvg2/svg/SVGFEFloodElement.cpp:
3471         (WebCore::SVGFEFloodElement::parseMappedAttribute):
3472         (WebCore::SVGFEFloodElement::filterEffect):
3473         * ksvg2/svg/SVGFEFloodElement.h:
3474         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
3475         (SVGFEGaussianBlurElement::parseMappedAttribute):
3476         (SVGFEGaussianBlurElement::filterEffect):
3477         * ksvg2/svg/SVGFEGaussianBlurElement.h:
3478         * ksvg2/svg/SVGFEMergeElement.cpp:
3479         (SVGFEMergeElement::filterEffect):
3480         * ksvg2/svg/SVGFEMergeNodeElement.cpp:
3481         (SVGFEMergeNodeElement::parseMappedAttribute):
3482         * ksvg2/svg/SVGFEMergeNodeElement.h:
3483         * ksvg2/svg/SVGFEOffsetElement.cpp:
3484         (SVGFEOffsetElement::parseMappedAttribute):
3485         (SVGFEOffsetElement::filterEffect):
3486         * ksvg2/svg/SVGFEOffsetElement.h:
3487         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
3488         (SVGFESpecularLightingElement::parseMappedAttribute):
3489         (SVGFESpecularLightingElement::filterEffect):
3490         * ksvg2/svg/SVGFESpecularLightingElement.h:
3491         * ksvg2/svg/SVGFETileElement.cpp:
3492         (WebCore::SVGFETileElement::parseMappedAttribute):
3493         (WebCore::SVGFETileElement::filterEffect):
3494         * ksvg2/svg/SVGFETileElement.h:
3495         * ksvg2/svg/SVGFETurbulenceElement.h:
3496         (WebCore::SVGFETurbulenceElement::):
3497         * ksvg2/svg/SVGFilterElement.cpp:
3498         (SVGFilterElement::SVGFilterElement):
3499         (SVGFilterElement::parseMappedAttribute):
3500         (SVGFilterElement::canvasResource):
3501         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
3502         (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
3503         * ksvg2/svg/SVGGradientElement.cpp:
3504         (SVGGradientElement::SVGGradientElement):
3505         (SVGGradientElement::parseMappedAttribute):
3506         * ksvg2/svg/SVGGradientElement.h:
3507         (WebCore::SVGGradientElement::):
3508         * ksvg2/svg/SVGHelper.cpp:
3509         (WebCore::SVGHelper::ParseSeperatedList):
3510         * ksvg2/svg/SVGLengthList.cpp:
3511         (WebCore::SVGLengthList::parse):
3512         * ksvg2/svg/SVGLinearGradientElement.cpp:
3513         (SVGLinearGradientElement::buildGradient):
3514         * ksvg2/svg/SVGList.h:
3515         (WebCore::SVGListBase::clear):
3516         (WebCore::SVGListBase::initialize):
3517         (WebCore::SVGListBase::getItem):
3518         (WebCore::SVGListBase::insertItemBefore):
3519         (WebCore::SVGListBase::replaceItem):
3520         (WebCore::SVGListBase::removeItem):
3521         (WebCore::SVGListBase::appendItem):
3522         * ksvg2/svg/SVGLocatable.cpp:
3523         * ksvg2/svg/SVGLocatable.h:
3524         * ksvg2/svg/SVGMarkerElement.h:
3525         (WebCore::SVGMarkerElement::):
3526         * ksvg2/svg/SVGNumberList.cpp:
3527         (SVGNumberList::parse):
3528         * ksvg2/svg/SVGPaint.cpp:
3529         (WebCore::SVGPaint::SVGPaint):
3530         (WebCore::SVGPaint::uri):
3531         (WebCore::SVGPaint::setUri):
3532         (WebCore::SVGPaint::setPaint):
3533         * ksvg2/svg/SVGPaint.h:
3534         (WebCore::SVGPaint::):
3535         * ksvg2/svg/SVGPathElement.cpp:
3536         (WebCore::SVGPathElement::svgMoveTo):
3537         (WebCore::SVGPathElement::svgLineTo):
3538         (WebCore::SVGPathElement::svgLineToHorizontal):
3539         (WebCore::SVGPathElement::svgLineToVertical):
3540         (WebCore::SVGPathElement::svgCurveToCubic):
3541         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
3542         (WebCore::SVGPathElement::svgCurveToQuadratic):
3543         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
3544         (WebCore::SVGPathElement::svgArcTo):
3545         (WebCore::SVGPathElement::svgClosePath):
3546         (WebCore::SVGPathElement::parseMappedAttribute):
3547         (WebCore::SVGPathElement::toPathData):
3548         * ksvg2/svg/SVGPatternElement.cpp:
3549         (WebCore::SVGPatternElement::SVGPatternElement):
3550         (WebCore::SVGPatternElement::parseMappedAttribute):
3551         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
3552         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
3553         * ksvg2/svg/SVGPolyElement.cpp:
3554         (SVGPolyElement::parseMappedAttribute):
3555         (SVGPolyElement::svgPolyTo):
3556         (SVGPolyElement::notifyAttributeChange):
3557         * ksvg2/svg/SVGPolygonElement.cpp:
3558         (SVGPolygonElement::toPathData):
3559         * ksvg2/svg/SVGPolylineElement.cpp:
3560         (SVGPolylineElement::toPathData):
3561         * ksvg2/svg/SVGRadialGradientElement.cpp:
3562         (WebCore::SVGRadialGradientElement::buildGradient):
3563         * ksvg2/svg/SVGRenderingIntent.h: Added.
3564         (WebCore::SVGRenderingIntent::):
3565         (WebCore::SVGRenderingIntent::SVGRenderingIntent):
3566         (WebCore::SVGRenderingIntent::~SVGRenderingIntent):
3567         * ksvg2/svg/SVGSVGElement.h:
3568         (WebCore::SVGSVGElement::):
3569         * ksvg2/svg/SVGScriptElement.cpp:
3570         (WebCore::SVGScriptElement::type):
3571         (WebCore::SVGScriptElement::setType):
3572         (WebCore::SVGScriptElement::parseMappedAttribute):
3573         * ksvg2/svg/SVGScriptElement.h:
3574         * ksvg2/svg/SVGStringList.cpp:
3575         (WebCore::SVGStringList::reset):
3576         * ksvg2/svg/SVGStyledLocatableElement.cpp:
3577         (SVGStyledLocatableElement::getTransformToElement):
3578         * ksvg2/svg/SVGStyledLocatableElement.h:
3579         * ksvg2/svg/SVGStyledTransformableElement.cpp:
3580         (SVGStyledTransformableElement::parseMappedAttribute):
3581         (SVGStyledTransformableElement::getTransformToElement):
3582         * ksvg2/svg/SVGStyledTransformableElement.h:
3583         * ksvg2/svg/SVGTests.cpp:
3584         (WebCore::SVGTests::hasExtension):
3585         (WebCore::SVGTests::isValid):
3586         * ksvg2/svg/SVGTests.h:
3587         * ksvg2/svg/SVGTextContentElement.cpp:
3588         (SVGTextContentElement::getSubStringLength):
3589         (SVGTextContentElement::getStartPositionOfChar):
3590         (SVGTextContentElement::getEndPositionOfChar):
3591         (SVGTextContentElement::getExtentOfChar):
3592         (SVGTextContentElement::getRotationOfChar):
3593         (SVGTextContentElement::selectSubString):
3594         * ksvg2/svg/SVGTextContentElement.h:
3595         (WebCore::SVGTextContentElement::):
3596         * ksvg2/svg/SVGTextElement.cpp:
3597         (WebCore::SVGTextElement::parseMappedAttribute):
3598         * ksvg2/svg/SVGTextElement.h:
3599         (WebCore::SVGTextElement::getTransformToElement):
3600         * ksvg2/svg/SVGTransform.h:
3601         * ksvg2/svg/SVGTransformList.cpp:
3602         (SVGTransformList::consolidate):
3603         (SVGTransformList::concatenate):
3604         * ksvg2/svg/SVGTransformable.cpp:
3605         (SVGTransformable::parseTransformAttribute):
3606         * ksvg2/svg/SVGUnitTypes.h: Added.
3607         (WebCore::SVGUnitTypes::):
3608         (WebCore::SVGUnitTypes::SVGUnitTypes):
3609         (WebCore::SVGUnitTypes::~SVGUnitTypes):
3610         * ksvg2/svg/SVGUseElement.cpp:
3611         (SVGUseElement::closeRenderer):
3612         * ksvg2/svg/SVGViewElement.h:
3613         (WebCore::SVGViewElement::):