2009-03-05 Xan Lopez <xan@gnome.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-03-05  Xan Lopez  <xan@gnome.org>
2
3         Reviewed by Mark Rowe.
4
5         https://bugs.webkit.org/show_bug.cgi?id=24377
6         [GTK] Comply better with coding style guidelines in ResourceHandleSoup
7
8         Use C++ booleans, 0 instead of NULL, prefix boolean variables with
9         'is', do not use 'else if' if the previous if had a return, delete
10         trailing whitespace, etc.
11
12         * platform/network/ResourceHandleInternal.h:
13         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
14         * platform/network/soup/ResourceHandleSoup.cpp:
15         (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
16         (WebCore::fillResponseFromMessage):
17         (WebCore::restartedCallback):
18         (WebCore::finishedCallback):
19         (WebCore::parseDataUrl):
20         (WebCore::ensureSessionIsInitialized):
21         (WebCore::ResourceHandle::startHttp):
22         (WebCore::reportUnknownProtocolError):
23         (WebCore::ResourceHandle::start):
24         (WebCore::cleanupGioOperation):
25         (WebCore::closeCallback):
26         (WebCore::readCallback):
27         (WebCore::openCallback):
28         (WebCore::queryInfoCallback):
29         (WebCore::ResourceHandle::startGio):
30
31 2009-03-04  Simon Fraser  <simon.fraser@apple.com>
32
33         Reviewed by Eric Seidel
34
35         https://bugs.webkit.org/show_bug.cgi?id=24328
36         
37         If an element has backface-visibility: hidden, hit testing should not
38         hit the back sides of elements. Test for that by inverting the accumulated
39         transform and looking at the z vector.
40
41         Tested by transforms/3d/hit-testing/backface-hit-test.html
42         
43         * rendering/RenderLayer.cpp:
44         (WebCore::RenderLayer::hitTestLayer):
45
46 2009-03-04  Adam Langley  <agl@google.com>
47
48         Reviewed by Darin Fisher.
49
50         r41362 mistakenly added functions "RenderThemeWin::" into
51         RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
52         them to void return types. This patch switches them back to ints.
53
54         https://bugs.webkit.org/show_bug.cgi?id=24360
55
56         * rendering/RenderThemeChromiumLinux.cpp:
57         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft):
58         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight):
59         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop):
60         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):
61
62 2009-03-04  Adam Langley  <agl@google.com>
63
64         Reviewed by Darin Fisher.
65
66         Chromium Linux: change some metrics to better match Windows after
67         r41416. Aesthetically this may be worse, but web-compat is king.
68
69         Also, the previous code had an off by one error when drawing
70         scrollbars which caused the scrollbar to overflow it's bounds by 1px
71         at the right and bottom edges.
72
73         https://bugs.webkit.org/show_bug.cgi?id=24369
74
75         * rendering/RenderThemeChromiumLinux.cpp:
76         (WebCore::):
77         (WebCore::RenderThemeChromiumLinux::systemFont):
78         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
79         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
80
81 2009-03-04  Eric Seidel  <eric@webkit.org>
82
83         Reviewed by Adam Roben.
84
85         Add an ASSERT to better demonstrate the cause of the crash in
86         https://bugs.webkit.org/show_bug.cgi?id=23736
87
88         * loader/DocLoader.cpp:
89         (WebCore::DocLoader::~DocLoader):
90
91 2009-03-04  David Levin  <levin@chromium.org>
92
93         Reviewed by Alexey Proskuryakov.
94
95         Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
96         <https://bugs.webkit.org/show_bug.cgi?id=24337>
97
98         Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
99                http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html
100
101         * loader/mac/ResourceLoaderMac.mm:
102         (WebCore::ResourceLoader::willCacheResponse):
103         An identifier is only asssigned if resource load callbacks are done.  So don't send
104         willCacheResponse which uses identifier if resource load callbacks aren't being sent.
105
106 2009-03-04  David Levin  <levin@chromium.org>
107
108         Reviewed by Alexey Proskuryakov.
109
110         Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
111         <https://bugs.webkit.org/show_bug.cgi?id=24330>
112
113         Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html
114
115         * dom/ExceptionCode.cpp:
116         (WebCore::xmlHttpRequestExceptionNames):
117         Added missing ABORT_ERR whose absence caused an assert.
118
119         * loader/WorkerThreadableLoader.cpp:
120         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
121         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
122         Add more logic to handle the termination case for sync xhr.
123
124 2009-03-04  Eric Carlson  <eric.carlson@apple.com>
125
126         Reviewed by Antti Koivisto.
127
128         https://bugs.webkit.org/show_bug.cgi?id=24364
129         Add support for HTMLMediaElement canPlayType method. Make
130         MediaPlayer::supportsType take a ContentType instead of a
131         separate mime type and codecs parameter.
132
133         Test: media/video-can-play-type.html
134
135         * dom/DOMImplementation.cpp:
136         (WebCore::DOMImplementation::createDocument):
137         * html/HTMLMediaElement.cpp:
138         (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method.
139         (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType.
140         (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type.
141         (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
142         * html/HTMLMediaElement.h: Add prototype.
143         * html/HTMLMediaElement.idl: Ditto.
144         * platform/graphics/MediaPlayer.cpp:
145         (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type.
146         (WebCore::MediaPlayer::supportsType): Ditto.
147         * platform/graphics/MediaPlayer.h:
148
149 2009-03-04  Antti Koivisto  <antti@apple.com>
150
151         Reviewed by Dave Hyatt.
152
153         https://bugs.webkit.org/show_bug.cgi?id=24359
154         Repaint throttling mechanism
155         
156         Excessive repainting can slow down page loadind. This implements a timer
157         based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not 
158         enabled by default.
159
160         * loader/FrameLoader.cpp:
161         (WebCore::FrameLoader::checkCompleted):
162         * page/EventHandler.cpp:
163         (WebCore::EventHandler::dispatchDragEvent):
164         (WebCore::EventHandler::dispatchMouseEvent):
165         (WebCore::EventHandler::keyEvent):
166         (WebCore::EventHandler::handleTextInputEvent):
167         * page/FrameView.cpp:
168         (WebCore::FrameView::FrameView):
169         (WebCore::FrameView::reset):
170         (WebCore::FrameView::repaintContentRectangle):
171         (WebCore::FrameView::beginDeferredRepaints):
172         (WebCore::FrameView::endDeferredRepaints):
173         (WebCore::FrameView::checkStopDelayingDeferredRepaints):
174         (WebCore::FrameView::doDeferredRepaints):
175         (WebCore::FrameView::updateDeferredRepaintDelay):
176         (WebCore::FrameView::resetDeferredRepaintDelay):
177         (WebCore::FrameView::adjustedDeferredRepaintDelay):
178         (WebCore::FrameView::deferredRepaintTimerFired):
179         (WebCore::FrameView::paintContents):
180         * page/FrameView.h:
181
182 2009-03-04  Sam Weinig  <sam@webkit.org>
183
184         Rubber-stamped by Antti Koivisto.
185
186         Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.
187
188         * dom/Document.cpp:
189         (WebCore::Document::Document):
190         * dom/Document.h:
191         (WebCore::Document::haveStylesheetsLoaded):
192         * html/HTMLTokenizer.cpp:
193         (WebCore::HTMLTokenizer::scriptHandler):
194         * loader/Cache.cpp:
195         (WebCore::Cache::requestResource):
196         * loader/CachedCSSStyleSheet.cpp:
197         (WebCore::CachedCSSStyleSheet::checkNotify):
198         * loader/DocLoader.h:
199         * loader/FrameLoader.cpp:
200         (WebCore::FrameLoader::FrameLoader):
201         (WebCore::FrameLoader::requestFrame):
202         (WebCore::FrameLoader::stopLoading):
203         (WebCore::FrameLoader::begin):
204         (WebCore::FrameLoader::write):
205         (WebCore::FrameLoader::endIfNotLoadingMainResource):
206         (WebCore::FrameLoader::checkCompleted):
207         (WebCore::FrameLoader::requestObject):
208         (WebCore::FrameLoader::loadItem):
209         * loader/FrameLoader.h:
210
211 2009-03-02  Xan Lopez  <xan@gnome.org>
212
213         Reviewed by Mark Rowe.
214
215         https://bugs.webkit.org/show_bug.cgi?id=24287
216         [GTK] Move auth dialog feature to WebKit/
217
218         Remove WebKitSoupAuthDialog files from build and stop using it.
219
220         * GNUmakefile.am:
221         * platform/network/soup/ResourceHandleSoup.cpp:
222         (WebCore::ensureSessionIsInitialized):
223         * platform/network/soup/webkit-soup-auth-dialog.c: Removed.
224         * platform/network/soup/webkit-soup-auth-dialog.h: Removed.
225
226 2009-03-04  Simon Fraser  <simon.fraser@apple.com>
227
228         Reviewed by Dave Hyatt
229         
230         https://bugs.webkit.org/show_bug.cgi?id=24361
231         
232         Reinstate code that sets result.innerNode when hitTest() returns true,
233         but never filled in the innerNode. Fixes hit testing of generated content.
234
235         Test: fast/css-generated-content/hit-test-generated-content.html
236
237         * rendering/RenderLayer.cpp:
238         (WebCore::RenderLayer::hitTestContents):
239
240 2009-03-04  Adam Barth  <abath@webkit.org>
241
242         Reviewed by Alexey Proskuryakov.
243
244         https://bugs.webkit.org/show_bug.cgi?id=24356
245
246         Fix WebKit style for allowUniversalAccessFromFileURLs.
247
248         * WebCore.base.exp:
249         * dom/Document.cpp:
250         (WebCore::Document::initSecurityContext):
251         * page/Settings.cpp:
252         (WebCore::Settings::Settings):
253         (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
254         * page/Settings.h:
255         (WebCore::Settings::allowUniversalAccessFromFileURLs):
256
257 2009-03-04  Brady Eidson  <beidson@apple.com>
258
259         Reviewed by Darin Adler
260
261         <rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.
262
263         I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
264         consolidated some of the various decision making pieces of the Cache into the new method
265         FrameLoader::cachePolicy().
266
267         Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader 
268         is reloading.  If it is, we'd evict any existing resource then recreate it.  Quick looks uses the
269         same URL for this image every time and expects it to be reloaded with each new card.
270
271         The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
272         is "ReloadIgnoringCacheData".  This check was lost in the consolidation to the new method.  
273
274         * loader/FrameLoader.cpp:
275         (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible
276           condition for returning CachePolicyReload.
277
278 2009-03-04  Timothy Hatcher  <timothy@apple.com>
279
280         * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
281         "LOCAL STORAGE" and "SESSION STORAGE".
282
283 2009-03-04  Timothy Hatcher  <timothy@apple.com>
284
285         Fix a regression where the Web Inspector console would not animate
286         in or out correctly.
287
288         Reviewed by Anders Carlsson.
289
290         * inspector/front-end/inspector.css: Move a z-index to a child element
291         to get the correct stacking order during the animation.
292
293 2009-03-03  David Hyatt  <hyatt@apple.com>
294
295         https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.
296
297         Make sure to factor clear deltas into y position estimates.  Also avoid doing the comparison of
298         the final position against the y position estimate until after the clear has happened.  This gets rid
299         of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.
300
301         Reviewed by Dan Bernstein
302
303         Added fast/block/float/nested-clearance.html
304
305         * rendering/RenderBlock.cpp:
306         (WebCore::RenderBlock::collapseMargins):
307         (WebCore::RenderBlock::clearFloatsIfNeeded):
308         (WebCore::RenderBlock::estimateVerticalPosition):
309         (WebCore::RenderBlock::layoutBlockChildren):
310         (WebCore::RenderBlock::getClearDelta):
311         * rendering/RenderBlock.h:
312
313 2009-03-02  Kim Grönholm  <kim.gronholm@nomovok.com>
314
315         Reviewed by Simon Hausmann.
316
317         Improvement to 3d transformations rendering in QtWebKit. QTransform is used
318         instead of QMatrix. This allows perspective transformations since QTransform is
319         a true 3x3 matrix.
320
321         * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere.
322         (WebCore::GraphicsContext::getCTM):
323         (WebCore::GraphicsContext::restorePlatformState):
324         (WebCore::GraphicsContext::fillPath):
325         (WebCore::GraphicsContext::strokePath):
326         (WebCore::GraphicsContext::fillRect):
327         (WebCore::GraphicsContext::translate):
328         (WebCore::GraphicsContext::rotate):
329         (WebCore::GraphicsContext::scale):
330         (WebCore::GraphicsContext::concatCTM):
331         * platform/graphics/qt/ImageQt.cpp:
332         (WebCore::Image::drawPattern):
333         * platform/graphics/qt/PathQt.cpp:
334         (WebCore::Path::translate):
335         (WebCore::Path::transform):
336         * platform/graphics/qt/PatternQt.cpp:
337         (WebCore::Pattern::createPlatformPattern):
338         * platform/graphics/qt/TransformationMatrixQt.cpp:
339         (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator
340         to QMatrix with one to QTransform.
341         * platform/graphics/transforms/TransformationMatrix.h:
342         * platform/graphics/qt/FontQt.cpp:
343
344 2009-02-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
345
346         Reviewed by Simon Hausmann.
347
348         https://bugs.webkit.org/show_bug.cgi?id=24151
349         Fix Qt/S60 build break
350
351         * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds
352         * platform/qt/FileSystemQt.cpp: Ditto
353         (WebCore::unloadModule):
354
355 2009-03-03  Mike Belshe  <mike@belshe.com>
356
357         Reviewed by Alexey Proskuryakov.
358
359         https://bugs.webkit.org/show_bug.cgi?id=21939
360         Uninitialized ExceptionCode in DOMWindow::postMessage
361
362         * dom/MessagePort.cpp:
363         (WebCore::MessagePort::postMessage):
364
365 2009-03-03  David Kilzer  <ddkilzer@apple.com>
366
367         <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
368
369         Reviewed by Mark Rowe.
370
371         The fix is to add INSTALLHDRS_COPY_PHASE = YES and
372         INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
373         sure various build phase scripts work with the installhdrs build
374         phase.
375
376         * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
377         based on PLATFORM_NAME to work around the missing definition on
378         Tiger.
379         * Configurations/WebCore.xcconfig: Added
380         JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
381         the "Generate Derived Sources" script.  Added
382         INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
383
384         * WebCore.xcodeproj/project.pbxproj:
385         - Added shell code to prevent running "Check For Global
386           Initializers", "Check For Exit Time Destructors" and "Check
387           For Weak VTables" scripts during the installhdrs build phase.
388         - Made "Generate Derived Sources" work for the installhdrs build
389           phase.  Also simplified setting of CREATE_HASH_TABLE by using
390           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
391
392 2009-03-02  Adam Langley  <agl@google.com>
393
394         Reviewed by Darin Fisher.
395
396         Chromium Linux: Switch to using Skia to render widgets.
397
398         In order to sandbox the Chromium renderer on Linux we need to remove
399         the X connection. GTK cannot render without an X connection so, for
400         now, we render widgets ourselves.
401
402         Previously didn't use anti-alias fonts in order to match Windows font
403         rendering exactly. This was helpful when bootstrapping our layout
404         tests. Now, however, we are ready to enable it.
405
406         https://bugs.webkit.org/show_bug.cgi?id=24244
407
408         * platform/chromium/ScrollbarThemeChromium.cpp:
409         (WebCore::ScrollbarThemeChromium::buttonSize):
410         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
411         (WebCore::ScrollbarThemeChromium::scrollbarThickness):
412         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
413         (WebCore::ScrollbarThemeChromium::paintButton):
414         (WebCore::ScrollbarThemeChromium::paintThumb):
415         * platform/graphics/chromium/FontPlatformDataLinux.cpp:
416         (WebCore::FontPlatformData::setupPaint):
417         * platform/graphics/skia/PlatformContextSkia.cpp:
418         (PlatformContextSkia::PlatformContextSkia):
419         (PlatformContextSkia::~PlatformContextSkia):
420         * platform/graphics/skia/PlatformContextSkia.h:
421         * rendering/RenderThemeChromiumGtk.cpp: Removed.
422         * rendering/RenderThemeChromiumGtk.h: Removed.
423         * rendering/RenderThemeChromiumLinux.cpp: Added.
424         * rendering/RenderThemeChromiumLinux.h: Added.
425
426 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
427
428         Reviewed by Darin Fisher.
429
430         https://bugs.webkit.org/show_bug.cgi?id=24261
431         Fix return types.
432
433         Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
434
435         * bindings/v8/V8Binding.h:
436         (WebCore::toInt32): change return type to int
437         (WebCore::toFloat): change return type to float.
438
439 2009-03-03  Anders Carlsson  <andersca@apple.com>
440
441         Reviewed by John Sullivan.
442
443         https://bugs.webkit.org/show_bug.cgi?id=22884
444         <rdar://problem/6449783>
445         modified layout test crashes Safari
446
447         Null check NPStream before dereferencing it.
448         
449         * plugins/PluginView.cpp:
450         (WebCore::PluginView::destroyStream):
451
452 2009-03-03  Eric Carlson  <eric.carlson@apple.com>
453
454         Reviewed by Simon Fraser.
455
456         Fix for <rdar://problem/6641045>
457         Don't call QTKit to get movie properties until movie metadata has been loaded.
458
459         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
460         (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
461         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
462         (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
463         (WebCore::MediaPlayerPrivate::play): Ditto.
464         (WebCore::MediaPlayerPrivate::pause): Ditto.
465         (WebCore::MediaPlayerPrivate::duration): Ditto.
466         (WebCore::MediaPlayerPrivate::currentTime): Ditto.
467         (WebCore::MediaPlayerPrivate::seek): Ditto.
468         (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
469         (WebCore::MediaPlayerPrivate::paused): Ditto.
470         (WebCore::MediaPlayerPrivate::seeking): Ditto.
471         (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
472         (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
473         (WebCore::MediaPlayerPrivate::setVolume): Ditto.
474         (WebCore::MediaPlayerPrivate::setRate): Ditto.
475         (WebCore::MediaPlayerPrivate::dataRate): Ditto.
476         (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
477         (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
478
479 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
480
481         - Spelling fix.
482
483         * page/Console.cpp:
484         (WebCore::Console::profile):
485
486 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
487
488         Reviewed by Darin Fisher.
489
490         https://bugs.webkit.org/show_bug.cgi?id=23657
491         Remove Database API callback IDLs from the project. 
492         They were removed in r40633.
493
494         * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
495
496 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
497
498         Reviewed by Oliver Hunt.
499
500         <rdar://problem/6639110> console.profile() doesn't work without a title
501
502         * page/Console.cpp:
503         (WebCore::Console::profile): If there is no title assume this is a user
504         initiated profile and give it the next incremented title name.
505
506 2009-03-03  Timothy Hatcher  <timothy@apple.com>
507
508         Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
509         the console code and refactored things to have fewer code paths and duplication.
510
511         rdar://problem/6367127
512         https://bugs.webkit.org/show_bug.cgi?id=24329
513
514         Reviewed by Kevin McCullough.
515
516         Test: manual-tests/inspector/console-dir.html
517
518         * bindings/js/JSInspectedObjectWrapper.cpp:
519         (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
520         to fix an ASSERT about using a wrapper from the wrong ExecState.
521         * bindings/js/JSQuarantinedObjectWrapper.cpp:
522         (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
523         (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
524         * inspector/front-end/Console.js:
525         (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
526         When forceObjectFormat is true, the only formatter used is _formatobject.
527         (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
528         (WebInspector.Console.prototype._formatstring): Ditto.
529         (WebInspector.Console.prototype._formatregexp): Ditto.
530         (WebInspector.Console.prototype._formatarray): Ditto.
531         (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
532         (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
533         (WebInspector.Console.prototype._formaterror): Remove the inline argument.
534         (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
535         simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
536         (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
537         (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
538         (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
539         (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
540         * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
541         * inspector/front-end/utilities.js:
542         (Object.type): Return "node" for Node objects.
543         (Object.describe): Handle the "node" type.
544         * page/Console.cpp:
545         (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
546         (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
547         * page/Console.h:
548         (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
549
550 2009-03-03  Scott Violet  <sky@google.com>
551
552         Reviewed by Eric Seidel.
553
554         https://bugs.webkit.org/show_bug.cgi?id=24325
555         Crash on replacing document contents during drop.
556
557         Makes sure a node is in the document during a move before using it.
558
559         Test: fast/events/crash-on-mutate-during-drop.html
560
561         * editing/MoveSelectionCommand.cpp:
562         (WebCore::MoveSelectionCommand::doApply):
563
564 2009-03-03  Jungshik Shin <jshin@chromium.org>
565
566         Reviewed by Eric Seidel.
567
568         https://bugs.webkit.org/show_bug.cgi?id=23028
569         Enable dynamic web font support to Chromium on Windows.
570         Files that were omitted by mistake in the latest patch
571         that was landed.
572
573         * loader/CachedFont.cpp:
574         (WebCore::CachedFont::~CachedFont):
575         (WebCore::CachedFont::ensureCustomFontData):
576         (WebCore::CachedFont::platformDataFromCustomData):
577         (WebCore::CachedFont::allClientsRemoved):
578         * platform/graphics/chromium/FontCustomPlatformData.cpp:
579         (WebCore::EOTStream::EOTStream):
580         (WebCore::createFontCustomPlatformData):
581         * platform/graphics/win/FontCustomPlatformData.cpp:
582         (WebCore::EOTStream::EOTStream):
583         (WebCore::createFontCustomPlatformData):
584
585 2009-03-03  Gustavo Noronha Silva  <gns@gnome.org>
586
587         Reviewed by Alexey Proskuryakov.
588
589         https://bugs.webkit.org/show_bug.cgi?id=16826
590         [Gtk] Implement WebKitDownload
591
592         Make the Soup backend able to handle requests without a frame,
593         since we may have such things now that we support downloads.
594
595         * platform/network/ResourceHandleInternal.h:
596         * platform/network/soup/ResourceHandleSoup.cpp:
597         (WebCore::ResourceHandle::start):
598
599 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
600
601         Reviewed by Eric Seidel.
602
603         https://bugs.webkit.org/show_bug.cgi?id=24331
604         Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
605
606         * bindings/v8/custom/V8AttrCustom.cpp: Added.
607         * bindings/v8/custom/V8CustomBinding.cpp: Added.
608         * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
609         * bindings/v8/custom/V8ElementCustom.cpp: Added.
610         * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
611         * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
612
613 2009-03-03  Brady Eidson  <beidson@apple.com>
614
615         Reviewed by Darin Adler
616
617         <rdar://problem/6616664> - Quick looks of various file types is broken
618
619         In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
620         for non-HTTP loads when the underlying ResourceRequest changed.  Unfortunately it was a little
621         overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
622
623         Partially reverted behavior to always set the mainDocumentURL in situations when we would've
624         before that patch.
625
626         * loader/FrameLoader.cpp:
627         (WebCore::FrameLoader::addExtraFieldsToRequest):
628
629         * platform/network/ResourceRequestBase.cpp:
630         (WebCore::ResourceRequestBase::setMainDocumentURL):
631
632 2009-03-03  Chris Marrin  <cmarrin@apple.com>
633
634         Reviewed by Simon Fraser.
635
636         https://bugs.webkit.org/show_bug.cgi?id=24256
637
638         Added a WebCoreForceSoftwareAnimation flag.
639
640         * platform/graphics/mac/GraphicsLayerCA.mm:
641         (WebCore::forceSoftwareAnimation):
642         (WebCore::GraphicsLayerCA::setOpacity):
643         (WebCore::GraphicsLayerCA::animateTransform):
644         (WebCore::GraphicsLayerCA::animateFloat):
645
646 2009-03-02  Chris Marrin  <cmarrin@apple.com>
647
648         Reviewed by Sam Weinig.
649
650         https://bugs.webkit.org/show_bug.cgi?id=24257
651
652         Added prototype properties for several classes with constructors that
653         were missing them, including the one mentioned in the bug.
654
655         Test: fast/dom/Window/custom-constructors.html
656
657         * bindings/js/JSAudioConstructor.cpp:
658         (WebCore::JSAudioConstructor::JSAudioConstructor):
659         * bindings/js/JSDOMWindowBase.cpp:
660         (jsDOMWindowBaseWebKitCSSMatrix):
661         * bindings/js/JSImageConstructor.cpp:
662         (WebCore::JSImageConstructor::JSImageConstructor):
663         * bindings/js/JSOptionConstructor.cpp:
664         (WebCore::JSOptionConstructor::JSOptionConstructor):
665         * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
666         (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
667         * bindings/js/JSWebKitCSSMatrixConstructor.h:
668         * bindings/js/JSWebKitPointConstructor.cpp:
669         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
670         * bindings/js/JSWorkerConstructor.cpp:
671         (WebCore::JSWorkerConstructor::JSWorkerConstructor):
672
673 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
674
675         Reviewed by Darin Fisher.
676
677         https://bugs.webkit.org/show_bug.cgi?id=24321
678         Add V8 bindings headers.
679
680         * bindings/v8/V8Binding.h: Added.
681         * bindings/v8/V8Proxy.h: Added.
682         * bindings/v8/custom/V8CustomBinding.h: Added.
683         * bindings/v8/custom/V8CustomEventListener.h: Added.
684
685 2009-03-03  Jungshik Shin <jshin@chromium.org>
686
687         Reviewed by Eric Seidel.
688
689         https://bugs.webkit.org/show_bug.cgi?id=23803
690         Fix an 'off-by-1' error in ChromiumWin's font fallback.
691
692         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
693         (WebCore::FontCache::getFontDataForCharacters):
694
695 2009-03-03  Jungshik Shin  <jshin@chromium.org>
696
697         Reviewed by Eric Seidel.
698
699         http://bugs.webkit.org/show_bug.cgi?id=23028
700         Enable dynamic web font support to Chromium on Windows: Part 1
701         - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
702           from platform/graphics/win because both Windows port and Chromium Windows
703           port will use them.
704         - Adjust WebCore.vcproj accordingly.
705
706         * WebCore.vcproj/WebCore.vcproj:
707         * platform/graphics/opentype: Added.
708         * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
709         * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
710         * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
711         * platform/graphics/win/OpenTypeUtilities.h: Removed.
712
713 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
714
715         Reviewed by Dave Hyatt
716
717         https://bugs.webkit.org/show_bug.cgi?id=24312
718         
719         Take 3D transforms into account when hit testing:
720         
721         1. Maintain a bit on each RenderLayer that is set when the layer
722            has 3d descendants, so that we know when to fall into the slow
723            hit testing path.
724            
725         2. Make a ref-counted HitTestingTransformState, which is used to store
726            an accumulated transform, and the hit test point, and hitTestRect
727            in the plane of the ancestor non-3d ('flattening') layer.
728            
729            It's ref-counted so we can heap allocate it (to avoid stack bloat),
730            and avoid copying when hitTestLayer calls itself after applying the transform.
731            
732         3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
733            3D transforms, or to do deep depth-testing when traversing a preserves-3d
734            hierarchy. When hit, layers compute a z-offset from the ancestor flattening
735            layer, which allows for correct depth testing.
736            
737            The existing early-return codepath is unaffected when there are no 3d transforms
738            and no preserve-3d.
739
740         * rendering/RenderLayer.cpp:
741         (WebCore::RenderLayer::RenderLayer):
742         (WebCore::RenderLayer::updateTransform):
743         (WebCore::RenderLayer::dirty3DTransformedDescendantStatus):
744         (WebCore::RenderLayer::update3DTransformedDescendantStatus):
745         (WebCore::RenderLayer::hitTest):
746         (WebCore::computeZOffset):
747         (WebCore::RenderLayer::createLocalTransformState):
748         (WebCore::RenderLayer::hitTestLayer):
749         (WebCore::RenderLayer::hitTestContents):
750         * rendering/RenderLayer.h:
751         (WebCore::RenderLayer::preserves3D):
752         (WebCore::RenderLayer::has3DTransform):
753         (WebCore::RenderLayer::setHas3DTransformedDescendant):
754         (WebCore::RenderLayer::has3DTransformedDescendant):
755         * rendering/RenderLayerBacking.cpp:
756         * rendering/TransformState.cpp:
757         (WebCore::TransformState::flatten):
758         (WebCore::TransformState::mappedPoint):
759         (WebCore::HitTestingTransformState::move):
760         (WebCore::HitTestingTransformState::applyTransform):
761         (WebCore::HitTestingTransformState::flatten):
762         (WebCore::HitTestingTransformState::mappedPoint):
763         (WebCore::HitTestingTransformState::mappedQuad):
764         * rendering/TransformState.h:
765         (WebCore::TransformState::TransformState):
766         (WebCore::HitTestingTransformState::create):
767         (WebCore::HitTestingTransformState::move):
768         (WebCore::HitTestingTransformState::HitTestingTransformState):
769
770 2009-03-03  Brett Wilson  <brettw@chromium.org>
771
772         Fix uninitialized memory reads in the Chromium Windows transparency
773         code that were identified by Purify,
774
775         Reviewed by Darin Fisher.
776
777         * platform/graphics/chromium/TransparencyWin.cpp:
778         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
779         (WebCore::TransparencyWin::initializeNewContext):
780
781 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
782
783         Reviewed by Dave Hyatt
784
785         https://bugs.webkit.org/show_bug.cgi?id=24312
786         
787         Factor the code that compute a transform relative to the container
788         into RenderObject::transformFromContainer().
789         
790         * rendering/RenderBox.cpp:
791         (WebCore::RenderBox::mapLocalToAbsolutePoint):
792         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
793         * rendering/RenderObject.cpp:
794         (WebCore::RenderObject::transformFromContainer):
795         * rendering/RenderObject.h:
796
797 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
798
799         Reviewed by Dave Hyatt
800
801         https://bugs.webkit.org/show_bug.cgi?id=24317
802         
803         Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
804         the superclass found a node, otherwise we set the innerNode of the
805         HitTestResult, but don't actually report that we found a hit.
806
807         * rendering/RenderTextControlMultiLine.cpp:
808         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
809
810 2009-03-03  Onne Gorter  <onne.gorter@avinity.net>
811
812         Reviewed by Anders Carlsson.
813
814         https://bugs.webkit.org/show_bug.cgi?id=23707
815         resizing plugins does not work, because the plugin never gets informed
816
817         Make gtk plugins resize correctly, by sending them the setwindow event
818         correctly. Also ensure that all plugin eventing is done with correct
819         locking/calling. Mostly copied from mac implementation.
820
821         manual test: manual-tests/gtk/plugin-resize-scroll.html
822
823         * plugins/PluginView.h:
824         * plugins/gtk/PluginViewGtk.cpp:
825         (WebCore::PluginView::dispatchNPEvent):
826         ensure locking/calling for NPEvents
827         (WebCore::PluginView::updatePluginWidget):
828         if something changed, let setNPWindowIfNeeded handle it
829         (WebCore::PluginView::paint):
830         (WebCore::PluginView::handleKeyboardEvent):
831         (WebCore::PluginView::handleMouseEvent):
832         ensure calling conventions
833         (WebCore::PluginView::setNPWindowRect):
834         just pass control to setNPWindowIfNeeded
835         (WebCore::PluginView::setNPWindowIfNeeded):
836         event the plugin correctly of new window
837         (WebCore::PluginView::init):
838         init through the new setup
839
840 2009-03-03  Mike Belshe  <mike@belshe.com>
841
842         Reviewed by Darin Fisher.
843
844         https://bugs.webkit.org/show_bug.cgi?id=24311
845         Make IDL returning DOMObject use [V8Custom]
846
847         * dom/Document.idl:
848         * html/HTMLCanvasElement.idl:
849
850 2009-03-02  Simon Fraser  <simon.fraser@apple.com>
851
852         Reviewed by Adele Peterson
853
854         https://bugs.webkit.org/show_bug.cgi?id=24313
855         
856         If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
857         HitTestResult, then it had better well return |true|. And m_innerBlock
858         could never have been set as the hit node by the superclass, because
859         the superclass knows nothing about m_innerBlock.
860         
861         Test: fast/forms/input-hit-test-border.html
862
863         * rendering/RenderTextControlSingleLine.cpp:
864         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
865
866 2009-03-02  Sam Weinig  <sam@webkit.org>
867
868         Reviewed by Mark Rowe.
869
870         Enable Geolocation (except on Tiger and Leopard).
871
872         * Configurations/WebCore.xcconfig:
873
874 2009-03-02  Ojan Vafai  <ojan@chromium.org>
875
876         Reviewed by Adele Peterson.
877
878         Fix https://bugs.webkit.org/show_bug.cgi?id=24307
879         Null out m_highlightedNode on hideHighlight().
880         Ran WebCore/manual-tests/inspector/highlight-nodes.html.
881
882         * inspector/InspectorController.cpp:
883         (WebCore::InspectorController::hideHighlight):
884
885 2009-03-02  Sam Weinig  <sam@webkit.org>
886
887         Reviewed by Geoffrey Garen.
888
889         Fix for <rdar://problem/6507404> Add Geolocation support.
890
891         This is not yet turned on for any Mac platform.
892
893         * WebCore.xcodeproj/project.pbxproj:
894         * page/Chrome.cpp:
895         (WebCore::Chrome::shouldAllowGeolocationForFrame):
896         * page/Chrome.h:
897         * page/ChromeClient.h:
898         (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
899         * page/Geolocation.cpp:
900         (WebCore::Geolocation::Geolocation):
901         (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
902         will not be alive at this point.
903         (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
904         return a PERMISSION_DENIED if not.
905         (WebCore::Geolocation::watchPosition): Ditto.
906         (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
907         to allow geolocation and cache the result. 
908         * page/Geolocation.h:
909         (WebCore::Geolocation::):
910         * platform/GeolocationService.cpp:
911         * platform/GeolocationService.h:
912         (WebCore::GeolocationService::~GeolocationService):
913         (WebCore::GeolocationService::stopUpdating):
914         * platform/mac/GeolocationServiceMac.h: Added.
915         (WebCore::GeolocationServiceMac::lastPosition):
916         (WebCore::GeolocationServiceMac::lastError):
917         * platform/mac/GeolocationServiceMac.mm: Added.
918         (WebCore::GeolocationService::create):
919         (WebCore::GeolocationServiceMac::GeolocationServiceMac):
920         (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
921         (WebCore::GeolocationServiceMac::startUpdating):
922         (WebCore::GeolocationServiceMac::stopUpdating):
923         (WebCore::GeolocationServiceMac::suspend):
924         (WebCore::GeolocationServiceMac::resume):
925         (WebCore::GeolocationServiceMac::positionChanged):
926         (WebCore::GeolocationServiceMac::errorOccurred):
927         (-[WebCoreCoreLocationObserver initWithCallback:]):
928         (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
929         (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
930
931 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
932
933         Build fixes for wxWidgets Mac trunk build.
934
935         * platform/wx/wxcode/mac/carbon/fontprops.cpp:
936         (wxFontProperties::wxFontProperties):
937         (GetTextExtent):
938         * webcore-wx.bkl:
939
940 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
941
942         wxGTK missing header build fix.
943
944         * platform/wx/wxcode/gtk/fontprops.cpp:
945
946 2009-03-02  Dan Bernstein  <mitz@apple.com>
947
948         Reviewed by Adam Roben.
949
950         - fix https://bugs.webkit.org/show_bug.cgi?id=21811
951           REGRESSION: Windows Build Not Selecting Proper Font
952
953         * platform/graphics/win/FontCacheWin.cpp:
954         (WebCore::createGDIFont): Added back code to verify that the created
955         HFONT has the requested face name.
956
957 2009-03-02  Timothy Hatcher  <timothy@apple.com>
958
959         Fixes a regression caused by splitting the input and output of console commands.
960
961         https://bugs.webkit.org/show_bug.cgi?id=24293
962
963         Reviewed by Kevin McCullough.
964
965         * inspector/front-end/Console.js:
966         (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
967         normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
968
969 2009-03-02  Timothy Hatcher  <timothy@apple.com>
970
971         Make exception messages and logged Error objects display consistently.
972
973         https://bugs.webkit.org/show_bug.cgi?id=18983
974
975         Reviewed by Adam Roben.
976
977         * English.lproj/localizedStrings.js: Remove a string for line numbers.
978         * inspector/front-end/Console.js:
979         (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
980         boolean to the ConsoleCommandResult constructor and don't pass level.
981         (WebInspector.Console.prototype._formatnode): Fix a className typo.
982         (WebInspector.Console.prototype._formaterror): Add an error-message
983         classed span around the message to show in red and remove the
984         console-message-url class from the link so it doesn't float right.
985         Instead enclose the link in parentheses and use displayNameForURL
986         to shorten the URL in the link.
987         (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
988         how line numbers are shown since link underlining a string with
989         parentheses looks bad.
990         (WebInspector.ConsoleCommandResult): Take an exception boolean flag
991         instead of a level and get line and URL based on that flag.
992         * inspector/front-end/inspector.css: Tweaks to the styles.
993
994 2009-03-02  Ojan Vafai  <ojan@chromium.org>
995
996         Reviewed by Adele Peterson.
997
998         Bug 24048: extra windows button padding doesn't apply when there's no appearance
999         <https://bugs.webkit.org/show_bug.cgi?id=24048>
1000
1001         Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
1002
1003         No tests added as existing tests already cover this behavior.
1004
1005         * rendering/RenderButton.cpp:
1006         (WebCore::RenderButton::setupInnerStyle):
1007         * rendering/RenderTheme.cpp:
1008         * rendering/RenderTheme.h:
1009         (WebCore::RenderTheme::buttonInternalPaddingLeft):
1010         (WebCore::RenderTheme::buttonInternalPaddingRight):
1011         (WebCore::RenderTheme::buttonInternalPaddingTop):
1012         * rendering/RenderThemeChromiumGtk.cpp:
1013         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
1014         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
1015         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
1016         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
1017         * rendering/RenderThemeChromiumGtk.h:
1018         * rendering/RenderThemeChromiumWin.cpp:
1019         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
1020         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
1021         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
1022         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
1023         * rendering/RenderThemeChromiumWin.h:
1024         * rendering/RenderThemeWin.cpp:
1025         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
1026         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
1027         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
1028         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
1029         * rendering/RenderThemeWin.h:
1030
1031 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
1032
1033         Build fix for Qt port.  Remove unnecessary assert.
1034
1035         * platform/graphics/qt/ImageBufferQt.cpp:
1036         (WebCore::ImageBuffer::putImageData):
1037
1038 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
1039
1040         Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
1041
1042         https://bugs.webkit.org/show_bug.cgi?id=24227
1043         Ensure that the checkForSolidColor() optimization is correctly triggered
1044         for all cases of drawPattern.  Currently, the optimization was not triggered
1045         when the check had not been previously performed via a request for the
1046         image's NativeImagePtr.
1047
1048         Implement the Qt version of the checkForSolidColor() method.  Combined with
1049         the bug fix this reduces the time it takes to draw a repeating background
1050         of a 1x1 image from ~50msecs to ~0msecs on my machine.
1051
1052         * platform/graphics/BitmapImage.cpp:
1053         (WebCore::BitmapImage::BitmapImage):
1054         * platform/graphics/BitmapImage.h:
1055         (WebCore::BitmapImage::mayFillWithSolidColor):
1056         * platform/graphics/Image.h:
1057         (WebCore::Image::mayFillWithSolidColor):
1058         * platform/graphics/cairo/ImageCairo.cpp:
1059         (WebCore::BitmapImage::BitmapImage):
1060         (WebCore::BitmapImage::checkForSolidColor):
1061         * platform/graphics/cg/ImageCG.cpp:
1062         (WebCore::BitmapImage::BitmapImage):
1063         (WebCore::BitmapImage::checkForSolidColor):
1064         * platform/graphics/qt/ImageQt.cpp:
1065         (WebCore::BitmapImage::checkForSolidColor):
1066         * platform/graphics/skia/ImageSkia.cpp:
1067         (WebCore::BitmapImage::checkForSolidColor):
1068         * platform/graphics/wx/ImageWx.cpp:
1069         (WebCore::BitmapImage::checkForSolidColor):
1070
1071 2009-03-02  Gustavo Noronha Silva  <gns@gnome.org>
1072
1073         Unreviewed build fix; adding missing files to EXTRA_DIST, so that
1074         they show up in the tarball.
1075
1076         * GNUmakefile.am:
1077
1078 2009-03-02  Dirk Schulze  <krit@webkit.org>
1079
1080         Reviewed by Holger Freyther.
1081
1082         Added putImageData to Qt. Discussed with Ariya Hidayat.
1083
1084         [Qt] lacks putImageData support in Canvas
1085         https://bugs.webkit.org/show_bug.cgi?id=22186
1086
1087         * platform/graphics/qt/ImageBufferQt.cpp:
1088         (WebCore::ImageBuffer::putImageData):
1089
1090 2009-03-02  Timothy Hatcher  <timothy@apple.com>
1091
1092         Show exception messages again when evaluating bad expressions in the
1093         Web Inspector's console.
1094
1095         https://bugs.webkit.org/show_bug.cgi?id=19890
1096
1097         Reviewed by Oliver Hunt.
1098
1099         * bindings/js/JSQuarantinedObjectWrapper.cpp:
1100         (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
1101         Fix the order in which the exception is set and cleared now that the
1102         exception is stored in the shared GlobalData, not per ExecState.
1103
1104 2009-02-28  Timothy Hatcher  <timothy@apple.com>
1105
1106         Make input in the Web Inspector console print before any output
1107         that might be added by the called function.
1108
1109         https://bugs.webkit.org/show_bug.cgi?id=19931
1110
1111         Reviewed by Oliver Hunt.
1112
1113         * inspector/front-end/Console.js:
1114         (WebInspector.Console.prototype._enterKeyPressed): Add the command
1115         message before evaluating the result. Associate the originating
1116         command to the result, so if they are adjacent there is no divider.
1117         (WebInspector.ConsoleCommand): No longer take a result.
1118         (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
1119         code removed since it isn't used now.
1120         (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
1121         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
1122         Call the ConsoleMessage toMessageElement and add a style class.
1123         * inspector/front-end/inspector.css: Add a new style class for
1124         adjacent results to hide the divider. Also tweak the position of
1125         the disclosure triangle for objects to not use the left margin.
1126
1127 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
1128
1129         Reviewed by Oliver Hunt.
1130
1131         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
1132         <https://bugs.webkit.org/show_bug.cgi?id=24282>
1133
1134         When fetching an array of elements with a range, attachment views need to be returned
1135         instead of the actual attachment.
1136
1137         * page/mac/AccessibilityObjectWrapper.mm:
1138         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
1139         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
1140
1141 2009-03-01  Ojan Vafai  <ojan@chromium.org>
1142
1143         Reviewed by Eric Seidel.
1144
1145         Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
1146         <https://bugs.webkit.org/show_bug.cgi?id=24251>
1147         
1148         Make RenderObject::positionForCoordinate non-virtual and
1149         RenderObject::positionForPoint virtual in preparation for
1150         removing positionFor* from RenderObject/RenderText.
1151
1152         * page/Frame.cpp:
1153         (WebCore::Frame::visiblePositionForPoint):
1154         * rendering/RenderBR.cpp:
1155         (WebCore::RenderBR::positionForPoint):
1156         * rendering/RenderBR.h:
1157         * rendering/RenderBlock.cpp:
1158         (WebCore::RenderBlock::positionForPoint):
1159         * rendering/RenderBlock.h:
1160         * rendering/RenderBox.cpp:
1161         (WebCore::RenderBox::positionForPoint):
1162         * rendering/RenderBox.h:
1163         * rendering/RenderInline.cpp:
1164         (WebCore::RenderInline::positionForPoint):
1165         * rendering/RenderInline.h:
1166         * rendering/RenderObject.cpp:
1167         (WebCore::RenderObject::positionForCoordinates):
1168         (WebCore::RenderObject::positionForPoint):
1169         * rendering/RenderObject.h:
1170         * rendering/RenderReplaced.cpp:
1171         (WebCore::RenderReplaced::positionForPoint):
1172         * rendering/RenderReplaced.h:
1173         * rendering/RenderSVGInlineText.cpp:
1174         (WebCore::RenderSVGInlineText::positionForPoint):
1175         * rendering/RenderSVGInlineText.h:
1176         * rendering/RenderText.cpp:
1177         (WebCore::RenderText::positionForPoint):
1178         * rendering/RenderText.h:
1179
1180 2009-03-01  Larry Ewing  <lewing@novell.com>
1181
1182         Reviewed by Alexey Proskuryakov.
1183
1184         https://bugs.webkit.org/show_bug.cgi?id=24080
1185         NPN_GetValue casting to the wrong type and writing outside bounds
1186
1187         Make sure to cast the value to the correct type so that only
1188         memory owned by the value is written to.
1189
1190         * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic): 
1191         * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
1192         * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): 
1193         (PluginView::getValue):
1194
1195 2009-03-01  Jeremy Moskovich  <jeremy@chromium.org>
1196
1197         Reviewed by Simon Fraser.
1198
1199         https://bugs.webkit.org/show_bug.cgi?id=24197 and
1200         https://bugs.webkit.org/show_bug.cgi?id=23512
1201
1202         The Windows version of cgColor() is conditionally compiled using
1203         !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
1204         can use the OS X version instead of the Windows version.
1205
1206         Also rename cgColor() -> createCGColor()
1207
1208         No observable change in behavior, so no test.
1209
1210         * platform/graphics/Color.h:
1211         * platform/graphics/cg/ColorCG.cpp:
1212         (WebCore::createCGColor):
1213         * platform/graphics/cg/GraphicsContextCG.cpp:
1214         (WebCore::GraphicsContext::setPlatformShadow):
1215         * platform/graphics/mac/ColorMac.mm:
1216         (WebCore::createCGColor):
1217         * platform/graphics/mac/GraphicsContextMac.mm:
1218         (WebCore::GraphicsContext::drawFocusRing):
1219         * platform/graphics/mac/GraphicsLayerCA.mm:
1220         (WebCore::setLayerBorderColor):
1221         (WebCore::setLayerBackgroundColor):
1222         (WebCore::GraphicsLayerCA::setBackgroundColor):
1223         * platform/graphics/win/GraphicsContextCGWin.cpp:
1224         (WebCore::GraphicsContext::drawFocusRing):
1225         * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
1226         (WebCore::ciColor):
1227
1228 2009-03-01  David Levin  <levin@chromium.org>
1229
1230         Reviewed by Alexey Proskuryakov.
1231
1232         Bug 24271: XMLHttpRequest needs js bindings for Workers.
1233         <https://bugs.webkit.org/show_bug.cgi?id=24271>
1234
1235         Tests: http/tests/xmlhttprequest/workers/methods-async.html
1236                http/tests/xmlhttprequest/workers/methods.html
1237
1238         * bindings/js/JSWorkerContextBase.cpp:
1239         (WebCore::JSWorkerContextBase::getOwnPropertySlot):
1240         (jsWorkerContextBaseXMLHttpRequest):
1241         (setJSWorkerContextBaseXMLHttpRequest):
1242         Expose XMLHttpRequest to Workers.
1243
1244         * bindings/js/JSWorkerContextBase.h:
1245
1246         * bindings/js/JSXMLHttpRequestConstructor.cpp:
1247         (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
1248         (WebCore::constructXMLHttpRequest):
1249         (WebCore::JSXMLHttpRequestConstructor::mark):
1250         Removed the dependencies on Document.
1251
1252         * bindings/js/JSXMLHttpRequestConstructor.h:
1253         (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
1254         * dom/EventException.idl:
1255         * dom/EventListener.idl:
1256         Change to have the NoStaticTables attribute since they are used from XHR.
1257
1258         * loader/WorkerThreadableLoader.cpp:
1259         (WebCore::workerContextDidFinishLoading):
1260         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
1261         Fixed identifier to be unsigned long.
1262
1263         * loader/WorkerThreadableLoader.h:
1264         * workers/WorkerThread.cpp:
1265         (WebCore::WorkerThread::workerThread):
1266         Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
1267
1268         * xml/XMLHttpRequestUpload.cpp:
1269
1270         * xml/XMLHttpRequest.idl:
1271         * xml/XMLHttpRequestException.idl:
1272         * xml/XMLHttpRequestProgressEvent.idl:
1273         * xml/XMLHttpRequestUpload.idl:
1274         Change to have the NoStaticTables attribute since they are used from XHR.
1275
1276 2009-03-01  Horia Olaru  <olaru@adobe.com>
1277
1278         Adding manual debugger test cases for bug.
1279
1280         https://bugs.webkit.org/show_bug.cgi?id=21073
1281
1282         Reviewed by Kevin McCullough.
1283
1284         * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
1285         * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
1286         * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
1287         * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
1288         * manual-tests/inspector/resources/loop-statements.js: Added.
1289
1290 2009-03-01  Dan Bernstein  <mitz@apple.com>
1291
1292         Reviewed by Darin Adler.
1293
1294         - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
1295
1296         Test: fast/events/scroll-during-zoom-change.html
1297
1298         * dom/Document.cpp:
1299         (WebCore::Document::recalcStyle): Pause scheduled events during style
1300         reclaculation. Changes to the zoom property result in scroll events
1301         being generated during style recalc, and those events need to be
1302         deferred until the render tree is consistent.
1303         * page/FrameView.cpp:
1304         (WebCore::FrameView::layout): Changed to account for a case in which the
1305         post-layout tasks trigger a nested layout, which reactivates the
1306         post-layout task timer.
1307
1308 2009-03-01  Ross Boucher  <rboucher@gmail.com>
1309
1310         Alphabetically sort scripts in the Script's panel file popup menu.
1311
1312         https://bugs.webkit.org/show_bug.cgi?id=23395
1313
1314         Reviewed by Timothy Hatcher.
1315
1316         * inspector/front-end/ScriptsPanel.js:
1317         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
1318         * inspector/front-end/utilities.js:
1319         (insertionIndexForObjectInListSortedByFunction):
1320         (indexOfObjectInListSortedByFunction):
1321
1322 2009-03-01  Yael Aharon  <yael.aharon@nokia.com>
1323
1324         Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
1325         when creating databases, localStorage or sessionStorage. Changing document.domain
1326         should have no affect on databases, localStorage and sessionStorage in Web Inspector.
1327
1328         https://bugs.webkit.org/show_bug.cgi?id=23844
1329
1330         Reviewed by Timothy Hatcher.
1331
1332         * inspector/InspectorController.cpp:
1333         (WebCore::InspectorController::addDOMStorageScriptResource):
1334         (WebCore::InspectorController::didUseDOMStorage):
1335         * storage/Database.cpp:
1336         (WebCore::Database::openDatabase):
1337
1338 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1339
1340         Reviewed by Holger Freyther.
1341
1342         Avoid leaking errors when reporting GIO errors.
1343
1344         * platform/network/soup/ResourceHandleSoup.cpp:
1345         (WebCore::readCallback):
1346         (WebCore::openCallback):
1347         (WebCore::queryInfoCallback):
1348
1349 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1350
1351         Reviewed by Holger Freyther.
1352
1353         Fixes crash when the GIO backend is given the URI for a directory.
1354
1355         * platform/network/soup/ResourceHandleSoup.cpp:
1356         (WebCore::networkErrorForFile):
1357
1358 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1359
1360         Reviewed by Darin Fisher.
1361
1362         https://bugs.webkit.org/show_bug.cgi?id=24261
1363         Fix V8 custom binding scrubbing error.
1364
1365         Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
1366         Test: traversal/exception-forwarding.html
1367         TesT: traversal/stay-within-root.html
1368
1369         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1370         * bindings/v8/custom/V8NodeIteratorCustom.cpp:
1371         (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
1372         * bindings/v8/custom/V8TreeWalkerCustom.cpp:
1373         (WebCore::toV8): Ditto.
1374
1375 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1376
1377         Reviewed by Darin Fisher.
1378
1379         https://bugs.webkit.org/show_bug.cgi?id=24261
1380         Fix V8 custom binding scrubbing error.
1381
1382         Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
1383
1384         * WebCore.xcodeproj/project.pbxproj:
1385         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1386         (WebCore::cssPropertyName):  Remove dubious checks, left over from
1387             incomplete conversion of parameter from pointer to pass-by-ref.
1388         (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
1389         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
1390
1391 2009-02-28  Xan Lopez  <xan@gnome.org>
1392
1393         Reviewed by Holger Freyther.
1394
1395         https://bugs.webkit.org/show_bug.cgi?id=24263
1396         [GTK] ref ResourceHandle until we are finished with it
1397
1398         Add a ref to the ResourceHandle in startHttp so we can keep it
1399         alive untill all callbacks have been executed, and unref it when
1400         soup tells us it's done with the SoupMessage (in
1401         finishedCallback). Fixes a number of crashes when calling
1402         didReceiveData whould crash because of the handle dying.
1403
1404         * platform/network/soup/ResourceHandleSoup.cpp:
1405         (WebCore::finishedCallback):
1406         (WebCore::ResourceHandle::startHttp):
1407
1408 2009-02-28  Adam Bergkvist <adam.bergkvist@ericsson.com>
1409
1410         Reviewed by Alexey Proskuryakov.
1411
1412         https://bugs.webkit.org/show_bug.cgi?id=24226
1413         [SOUP] HTTP status text is never set
1414
1415         Set HTTP status text to SoupMessage reason_phrase.
1416
1417         * platform/network/soup/ResourceHandleSoup.cpp:
1418         (WebCore::fillResponseFromMessage):
1419
1420 2009-02-28  Dan Bernstein  <mitz@apple.com>
1421
1422         - fix malformed project file
1423
1424         * WebCore.xcodeproj/project.pbxproj:
1425
1426 2009-02-28  Dan Bernstein  <mitz@apple.com>
1427
1428         Reviewed by Oliver Hunt.
1429
1430         - fix https://bugs.webkit.org/show_bug.cgi?id=23848
1431           <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
1432
1433         Test: fast/layers/inline-dirty-z-order-lists.html
1434
1435         * rendering/RenderBox.cpp:
1436         (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
1437         layer's and its stacking context's z-order lists when the layer's
1438         z-index or visibility change from here...
1439         * rendering/RenderBoxModelObject.cpp:
1440         (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
1441         it will apply to RenderInline too.
1442
1443 2009-02-27  Alexey Proskuryakov  <ap@webkit.org>
1444
1445         Reviewed by David Hyatt.
1446
1447         Don't include TextResourceDecoder.h in Document.h
1448
1449         This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
1450         when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
1451
1452         * dom/Document.cpp:
1453         (WebCore::Document::displayStringModifiedByEncoding):
1454         (WebCore::Document::displayBufferModifiedByEncoding):
1455         * dom/Document.h:
1456         * WebCore.base.exp:
1457
1458 2009-02-27  Matt Pennig  <pennig@apple.com>
1459
1460         Reviewed by David Hyatt.
1461
1462         Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
1463         "Fixed elements have 0 as an offsetLeft property"
1464         
1465         Code also brings offsetLeft/Top in full conformance with the spec.
1466         Added two tests, one for fixed-position elements, and one for <html>.
1467         
1468         Tests: fast/dom/Element/fixed-position-offset-parent.html
1469                fast/dom/Element/offsetLeft-offsetTop-html.html
1470
1471         * rendering/RenderBoxModelObject.cpp:
1472         (WebCore::RenderBoxModelObject::offsetLeft):
1473         (WebCore::RenderBoxModelObject::offsetTop):
1474
1475 2009-02-27  Dean Jackson  <dino@apple.com>
1476
1477         Reviewed by Simon Fraser.
1478
1479         renderer()->hasTransform() returns true for elements
1480         with perspective, but no transform, so test for transform
1481         when hit testing. This fixes ASSERT from
1482         https://bugs.webkit.org/show_bug.cgi?id=24252
1483
1484         Test: transforms/no_transform_hit_testing.html
1485
1486         * rendering/RenderLayer.cpp:
1487         (WebCore::RenderLayer::hitTestLayer):
1488
1489 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1490
1491         Reviewed by Darin Fisher.
1492
1493         Fix scrubbing error -- a reversed condition.
1494
1495         * bindings/v8/ScriptValue.h:
1496         (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
1497
1498 2009-02-27  Jian Li  <jianli@chromium.org>
1499
1500         Reviewed by Alexey Proskuryakov.
1501
1502         Add confirmMessageFromWorkerObject to WorkerObjectProxy.
1503         https://bugs.webkit.org/show_bug.cgi?id=24152
1504
1505         * workers/WorkerMessagingProxy.cpp:
1506         (WebCore::MessageWorkerContextTask::performTask):
1507         (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
1508         * workers/WorkerMessagingProxy.h:
1509         * workers/WorkerObjectProxy.h:
1510
1511 2009-02-27  Anders Carlsson  <andersca@apple.com>
1512
1513         Reviewed by David Hyatt.
1514
1515         Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227 
1516         because it leads to assertion failures in the Mac port.
1517         
1518         * platform/graphics/BitmapImage.cpp:
1519         (WebCore::BitmapImage::BitmapImage):
1520         * platform/graphics/BitmapImage.h:
1521         (WebCore::BitmapImage::mayFillWithSolidColor):
1522         * platform/graphics/Image.h:
1523         (WebCore::Image::mayFillWithSolidColor):
1524         * platform/graphics/cairo/ImageCairo.cpp:
1525         (WebCore::BitmapImage::BitmapImage):
1526         * platform/graphics/cg/ImageCG.cpp:
1527         (WebCore::BitmapImage::BitmapImage):
1528         (WebCore::BitmapImage::checkForSolidColor):
1529         * platform/graphics/qt/ImageQt.cpp:
1530         (WebCore::BitmapImage::checkForSolidColor):
1531         * platform/graphics/skia/ImageSkia.cpp:
1532         (WebCore::BitmapImage::checkForSolidColor):
1533         * platform/graphics/wx/ImageWx.cpp:
1534         (WebCore::BitmapImage::checkForSolidColor):
1535
1536 2009-02-27  Adam Barth  <abarth@webkit.org>
1537
1538         Reviewed by Eric Seidel.
1539
1540         https://bugs.webkit.org/show_bug.cgi?id=20249
1541
1542         Add a preference to allow universal access from local URLs to mitigate
1543         some attacks.  Some clients still want to allow this access, so we
1544         expose this as a preference.
1545
1546         * WebCore.base.exp:
1547         * dom/Document.cpp:
1548         (WebCore::Document::initSecurityContext):
1549         * page/SecurityOrigin.cpp:
1550         (WebCore::SecurityOrigin::SecurityOrigin):
1551         * page/Settings.cpp:
1552         (WebCore::Settings::Settings):
1553         (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
1554         * page/Settings.h:
1555         (WebCore::Settings::allowUniversalAccessFromFileUrls):
1556
1557 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1558
1559         Reviewed by Eric Seidel.
1560
1561         https://bugs.webkit.org/show_bug.cgi?id=24229
1562         If an image has no alpha channel there is no reason to use SourceOver.
1563
1564         * platform/graphics/qt/ImageQt.cpp:
1565         (WebCore::Image::drawPattern):
1566         (WebCore::BitmapImage::draw):
1567
1568 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1569
1570         Reviewed by Eric Seidel and Simon Fraser.
1571
1572         https://bugs.webkit.org/show_bug.cgi?id=24227
1573         Ensure that the checkForSolidColor() optimization is correctly triggered
1574         for all cases of drawPattern.  Currently, the optimization was not triggered
1575         when the check had not been previously performed via a request for the
1576         image's NativeImagePtr.
1577
1578         Implement the Qt version of the checkForSolidColor() method.  Combined with
1579         the bug fix this reduces the time it takes to draw a repeating background
1580         of a 1x1 image from ~50msecs to ~0msecs on my machine.
1581
1582         * platform/graphics/BitmapImage.cpp:
1583         (WebCore::BitmapImage::BitmapImage):
1584         * platform/graphics/BitmapImage.h:
1585         (WebCore::BitmapImage::mayFillWithSolidColor):
1586         * platform/graphics/Image.h:
1587         (WebCore::Image::mayFillWithSolidColor):
1588         * platform/graphics/cairo/ImageCairo.cpp:
1589         (WebCore::BitmapImage::BitmapImage):
1590         * platform/graphics/cg/ImageCG.cpp:
1591         (WebCore::BitmapImage::BitmapImage):
1592         (WebCore::BitmapImage::checkForSolidColor):
1593         * platform/graphics/qt/ImageQt.cpp:
1594         (WebCore::BitmapImage::checkForSolidColor):
1595         * platform/graphics/skia/ImageSkia.cpp:
1596         (WebCore::BitmapImage::checkForSolidColor):
1597         * platform/graphics/wx/ImageWx.cpp:
1598         (WebCore::BitmapImage::checkForSolidColor):
1599
1600 2009-02-27  Dirk Schulze  <krit@webkit.org>
1601
1602         Reviewed by Zack Rusin.
1603
1604         Added support for gradients and pattern on Fonts for Qt.
1605
1606         [Qt] gradients and patterns for FontQt
1607         https://bugs.webkit.org/show_bug.cgi?id=24243
1608
1609         * platform/graphics/qt/FontQt.cpp:
1610         (WebCore::Font::drawComplexText):
1611
1612 2009-02-27  Jian Li  <jianli@chromium.org>
1613
1614         Reviewed by Alexey Proskuryakov.
1615
1616         WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
1617         https://bugs.webkit.org/show_bug.cgi?id=24113
1618
1619         * workers/WorkerMessagingProxy.cpp:
1620
1621 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1622
1623         Added a refresh button to storage views.
1624
1625         https://bugs.webkit.org/show_bug.cgi?id=24040
1626
1627         Reviewed by Timothy Hatcher.
1628
1629         * inspector/front-end/DOMStorageItemsView.js:
1630         (WebInspector.DOMStorageItemsView):
1631         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1632         (WebInspector.DOMStorageItemsView.prototype.update):
1633         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
1634         * inspector/front-end/DatabaseTableView.js:
1635         (WebInspector.DatabaseTableView):
1636         (WebInspector.DatabaseTableView.prototype.get statusBarItems):
1637         (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
1638         * inspector/front-end/DatabasesPanel.js:
1639         (WebInspector.DatabasesPanel):
1640         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1641         (WebInspector.DatabasesPanel.prototype.reset):
1642         (WebInspector.DatabasesPanel.prototype.showDatabase):
1643         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1644         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1645         * inspector/front-end/inspector.css:
1646
1647 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1648
1649         Added support for editing/deleting localStorage and sessionStorage items
1650         directly from Web Inspector.
1651
1652         https://bugs.webkit.org/show_bug.cgi?id=23866.
1653
1654         Reviewed by Timothy Hatcher.
1655
1656         * WebCore.vcproj/WebCore.vcproj:
1657         * inspector/front-end/DOMStorageDataGrid.js: Added.
1658         (WebInspector.DOMStorageDataGrid):
1659         (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
1660         (WebInspector.DOMStorageDataGrid.prototype._startEditing):
1661         (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
1662         (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
1663         (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
1664         * inspector/front-end/DOMStorageItemsView.js:
1665         (WebInspector.DOMStorageItemsView):
1666         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1667         (WebInspector.DOMStorageItemsView.prototype.hide):
1668         (WebInspector.DOMStorageItemsView.prototype.update):
1669         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
1670         * inspector/front-end/DatabasesPanel.js:
1671         (WebInspector.DatabasesPanel):
1672         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1673         (WebInspector.DatabasesPanel.prototype.reset):
1674         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1675         (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
1676         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1677         * inspector/front-end/WebKit.qrc:
1678         * inspector/front-end/inspector.css:
1679         * inspector/front-end/inspector.html:
1680
1681 2009-02-26  Brett Wilson  <brettw@chromium.org>
1682
1683         Fix Windows transparency for the Chromium port. Implement a helper
1684         class for handling transparency on Windows. It allows semitransparent
1685         ClearType and semitransparent form controls by making new layers in the
1686         background.
1687
1688         It also replaces the "ThemeHelper" which allows better
1689         scaling and transforms on Windows form controls. In addition to the
1690         functionality that the ThemeHelper did, but additionally handles the
1691         antialiasing properly so that the form controls aren't composited on a
1692         white square.
1693
1694         https://bugs.webkit.org/show_bug.cgi?id=24101
1695
1696         Reviewed by Eric Seidel.
1697
1698         * platform/graphics/chromium/FontChromiumWin.cpp:
1699         (WebCore::):
1700         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
1701         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1702         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
1703         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
1704         (WebCore::Font::drawGlyphs):
1705         * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
1706         * platform/graphics/chromium/ThemeHelperChromiumWin.h:
1707         * platform/graphics/chromium/TransparencyWin.cpp: Added.
1708         (WebCore::):
1709         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
1710         (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
1711         (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
1712         (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
1713         (WebCore::TransparencyWin::TransparencyWin):
1714         (WebCore::TransparencyWin::~TransparencyWin):
1715         (WebCore::TransparencyWin::init):
1716         (WebCore::TransparencyWin::computeLayerSize):
1717         (WebCore::TransparencyWin::setupLayer):
1718         (WebCore::TransparencyWin::setupLayerForNoLayer):
1719         (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
1720         (WebCore::TransparencyWin::setupLayerForTextComposite):
1721         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1722         (WebCore::TransparencyWin::setupTransform):
1723         (WebCore::TransparencyWin::setupTransformForKeepTransform):
1724         (WebCore::TransparencyWin::setupTransformForUntransform):
1725         (WebCore::TransparencyWin::setupTransformForScaleTransform):
1726         (WebCore::TransparencyWin::setTextCompositeColor):
1727         (WebCore::TransparencyWin::initializeNewContext):
1728         (WebCore::TransparencyWin::compositeOpaqueComposite):
1729         (WebCore::TransparencyWin::compositeTextComposite):
1730         (WebCore::TransparencyWin::makeLayerOpaque):
1731         * platform/graphics/chromium/TransparencyWin.h: Added.
1732         (WebCore::TransparencyWin::):
1733         (WebCore::TransparencyWin::context):
1734         (WebCore::TransparencyWin::platformContext):
1735         (WebCore::TransparencyWin::drawRect):
1736         * platform/graphics/skia/GraphicsContextSkia.cpp:
1737         (WebCore::GraphicsContext::endTransparencyLayer):
1738         * platform/graphics/skia/ImageSkia.cpp:
1739         (WebCore::paintSkBitmap):
1740         * rendering/RenderThemeChromiumWin.cpp:
1741         (WebCore::):
1742         (WebCore::RenderThemeChromiumWin::paintButton):
1743         (WebCore::RenderThemeChromiumWin::paintMenuList):
1744         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1745
1746 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1747
1748         Reviewed by Eric Seidel.
1749
1750         https://bugs.webkit.org/show_bug.cgi?id=24211
1751         Add ScheduledAction for V8.
1752
1753         * bindings/v8/ScheduledAction.cpp: Added.
1754         (WebCore::ScheduledAction::ScheduledAction):
1755         (WebCore::ScheduledAction::~ScheduledAction):
1756         (WebCore::ScheduledAction::execute):
1757         * bindings/v8/ScheduledAction.h: Added.
1758         (WebCore::ScheduledAction::ScheduledAction):
1759
1760 2009-02-27  Zack Rusin  <zack@kde.org>
1761
1762         Reviewed by Nikolas Zimmermann.
1763
1764         Qt: be more reasonable about scrolled lines
1765
1766         cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
1767         match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
1768         irritating. so lets scroll vertically by the Qt set number of lines * Qt default
1769         single step scroll
1770
1771         * platform/qt/WheelEventQt.cpp:
1772
1773 2009-02-27  Xan Lopez  <xan@gnome.org>
1774
1775         Rubber-stamped by Alexey Proskuryakov.
1776
1777         https://bugs.webkit.org/show_bug.cgi?id=24222
1778         [GTK] Remove checks for old glib versions
1779
1780         libsoup, which is a hard dependency, needs at least glib 2.15.3,
1781         so remove all glib checks for versions older than that.
1782
1783         * platform/gtk/ContextMenuGtk.cpp:
1784         (WebCore::ContextMenu::ContextMenu):
1785         * platform/gtk/ContextMenuItemGtk.cpp:
1786         (WebCore::ContextMenuItem::setSubMenu):
1787         * platform/gtk/PopupMenuGtk.cpp:
1788         (WebCore::PopupMenu::show):
1789         * platform/gtk/WidgetGtk.cpp:
1790         (WebCore::Widget::retainPlatformWidget):
1791         * platform/network/soup/ResourceHandleSoup.cpp:
1792
1793 2009-02-26  Dirk Schulze  <krit@webkit.org>
1794
1795         Reviewed by Oliver Hunt.
1796
1797         Added support for Gradients and Patterns on filled or stroked Fonts
1798         in Cairo. I also added support for globalAlpha on FontCairo.
1799
1800         [CAIRO] SVG/Canvas fonts miss gradients/pattern support
1801         https://bugs.webkit.org/show_bug.cgi?id=18617
1802
1803         * html/CanvasRenderingContext2D.cpp:
1804         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1805         * platform/graphics/cairo/FontCairo.cpp:
1806         (WebCore::Font::drawGlyphs):
1807
1808 2009-02-26  Stephen White  <senorblanco@chromium.org>
1809
1810         Reviewed by Eric Seidel.
1811
1812         https://bugs.webkit.org/show_bug.cgi?id=23957
1813
1814         Fix for SVG gradient and pattern text for Chromium/skia. 
1815         Added accessors for the fill and stroke gradients to
1816         GraphicsContext.  Changed the paintSkiaText function to take a
1817         GraphicsContext, so we can check for gradients/patterns. 
1818         Changed the skiaDrawText function to set the SkPaint shader
1819         correctly, and to scale up the gradient shader matrix to
1820         encompass the entire text string.  Also offset each glyph
1821         separately, rather than transforming the canvas, so that the
1822         gradient/pattern stays fixed relative to the text origin.
1823
1824         * platform/graphics/GraphicsContext.cpp:
1825         (WebCore::GraphicsContext::getFillGradient):
1826         (WebCore::GraphicsContext::getStrokeGradient):
1827         (WebCore::GraphicsContext::getFillPattern):
1828         (WebCore::GraphicsContext::getStrokePattern):
1829         * platform/graphics/GraphicsContext.h:
1830         * platform/graphics/chromium/FontChromiumWin.cpp:
1831         (WebCore::Font::drawGlyphs):
1832         * platform/graphics/chromium/UniscribeHelper.cpp:
1833         (WebCore::UniscribeHelper::draw):
1834         * platform/graphics/skia/SkiaFontWin.cpp:
1835         (WebCore::windowsCanHandleTextDrawing):
1836         (WebCore::skiaDrawText):
1837         (WebCore::paintSkiaText):
1838         * platform/graphics/skia/SkiaFontWin.h:
1839
1840 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1841
1842         Reviewed by Eric Seidel.
1843
1844         https://bugs.webkit.org/show_bug.cgi?id=24208
1845         Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
1846
1847         * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
1848         (WebCore::ACCESSOR_GETTER):
1849         (WebCore::CALLBACK_FUNC_DECL):
1850         * bindings/v8/custom/V8DocumentCustom.cpp: Added.
1851         (WebCore::CALLBACK_FUNC_DECL):
1852         * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
1853         (WebCore::ACCESSOR_GETTER):
1854         * bindings/v8/custom/V8NodeCustom.cpp: Added.
1855         (WebCore::CALLBACK_FUNC_DECL):
1856
1857 2009-02-26  Gustavo Noronha Silva  <gns@gnome.org>
1858
1859         Unreviewed build fix for building with GNOME Keyring enabled.
1860
1861         * platform/network/soup/webkit-soup-auth-dialog.c:
1862         (show_auth_dialog):
1863
1864 2009-02-26  Xan Lopez  <xan@gnome.org>
1865
1866         Reviewed by Holger Freyther.
1867
1868         https://bugs.webkit.org/show_bug.cgi?id=16947
1869         [GTK] Missing HTTP Auth challenge
1870
1871         Add HTTP authentication dialog with optional GNOME Keyring
1872         storage.
1873
1874         * GNUmakefile.am:
1875         * platform/network/ResourceHandleInternal.h:
1876         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1877         * platform/network/soup/ResourceHandleSoup.cpp:
1878         (WebCore::currentToplevelCallback):
1879         (WebCore::ResourceHandle::startHttp):
1880         (WebCore::ResourceHandle::start):
1881         * platform/network/soup/webkit-soup-auth-dialog.c: Added.
1882         (webkit_soup_auth_dialog_class_init):
1883         (webkit_soup_auth_dialog_init):
1884         (webkit_soup_auth_dialog_session_feature_init):
1885         (free_authData):
1886         (set_password_callback):
1887         (response_callback):
1888         (show_auth_dialog):
1889         (find_password_callback):
1890         (session_authenticate):
1891         (attach):
1892         * platform/network/soup/webkit-soup-auth-dialog.h: Added.
1893
1894 2009-02-25  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
1895
1896         Reviewed by Dave Hyatt.
1897
1898         After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
1899         svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
1900         started failing because Ojan's new code was now *correctly* calling through to
1901         SVG asking for the closest text offset in the last line box, instead of
1902         just returning the offset at the end of the last line box when clicking below a box.
1903
1904         But!  The SVG code was wrong, in that it returned the character offset of the last
1905         character when you asked for a character offset after the end of the box, instead
1906         it should return the offset *after* the last character.  This patch fixes
1907         that behavior by reordering the last two clauses in svgCharacterHitsPosition.
1908
1909         The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
1910         to document what's wrong.  I've also cleaned up the code a bit so it's clearer
1911         what it is doing (which also makes more obvious what's wrong with it).
1912
1913         * rendering/RenderSVGInlineText.cpp:
1914         (WebCore::RenderSVGInlineText::positionForCoordinates):
1915         * rendering/SVGInlineTextBox.cpp:
1916         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
1917         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
1918         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
1919         (WebCore::SVGInlineTextBox::closestCharacterToPosition):
1920         (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
1921
1922 2009-02-26  Darin Fisher  <darin@chromium.org>
1923
1924         Reviewed by Eric Seidel.
1925
1926         Minor cleanup of ChromiumBridge:
1927         Removing unused matchesMIMEType method and s/Javascript/JavaScript/
1928
1929         * platform/chromium/ChromiumBridge.h:
1930         * platform/chromium/MimeTypeRegistryChromium.cpp:
1931         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
1932         (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
1933         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
1934
1935 2009-02-26  David Hyatt  <hyatt@apple.com>
1936
1937         Reviewed by Sam Weinig
1938
1939         Fix text-bottom vertical alignment.  It was incorrectly aligning the bottom of the descent instead of including
1940         the line-height below the descent.
1941
1942         Added fast/inline/vertical-align-text-bottom.html
1943
1944         * rendering/RenderBoxModelObject.cpp:
1945         (WebCore::RenderBoxModelObject::verticalPosition):
1946
1947 2009-02-26  Dirk Schulze  <krit@webkit.org>
1948
1949         Reviewed by Eric Seidel.
1950
1951         Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
1952         ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
1953         just to implement this three methods to support SVG Masking now.
1954  
1955         Make SVG Masking platform aware
1956         https://bugs.webkit.org/show_bug.cgi?id=19243
1957
1958         * GNUmakefile.am:
1959         * WebCore.pro:
1960         * WebCore.vcproj/WebCore.vcproj:
1961         * WebCore.xcodeproj/project.pbxproj:
1962         * svg/graphics/SVGResourceMasker.cpp:
1963         (WebCore::SVGResourceMasker::applyMask):
1964         * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
1965         * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
1966         * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
1967         * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
1968         * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
1969
1970 2009-02-26  Yong Li  <yong.li@torchmobile.com>
1971
1972         Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
1973
1974         Test: http/tests/misc/slow-preload-cancel.html
1975
1976         https://bugs.webkit.org/show_bug.cgi?id=24133
1977         Clear all pending preloads in the DocLoader object when we decide to
1978         cancel its all requests.
1979
1980         * loader/DocLoader.cpp:
1981         (WebCore::DocLoader::clearPendingPreloads):
1982         * loader/DocLoader.h:
1983         * loader/loader.cpp:
1984         (WebCore::Loader::cancelRequests):
1985
1986 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1987
1988         Reviewed by Eric Seidel.
1989
1990         https://bugs.webkit.org/show_bug.cgi?id=24182
1991         Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
1992
1993         * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
1994         (WebCore::CALLBACK_FUNC_DECL):
1995         * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
1996         (WebCore::toV8):
1997         (WebCore::CALLBACK_FUNC_DECL):
1998         * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
1999         (WebCore::toV8):
2000         (WebCore::CALLBACK_FUNC_DECL):
2001
2002 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
2003
2004         Reviewed by Darin Adler.
2005
2006         https://bugs.webkit.org/show_bug.cgi?id=23500
2007         KURL::parse() incorrectly compares its result to original string
2008
2009         * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
2010
2011 2009-02-26  Ojan Vafai  <ojan@chromium.org>
2012
2013         Reviewed by Kevin McCullough.
2014
2015         Manual test for inspector node highlighting.
2016
2017         * manual-tests/inspector/highlight-nodes.html: Added.
2018
2019 2009-02-16  Anantanarayanan Iyengar  <ananta@chromium.org>
2020
2021         Reviewed by Darin Fisher.
2022
2023         https://bugs.webkit.org/show_bug.cgi?id=23973
2024         ScrollView::scrollContents can be invoked during view shutdown.  In
2025         this scenario the FrameView::hostWindow method can return NULL, which
2026         indicates that the frame/page is being destroyed. This causes a crash
2027         when we try to dereference a NULL hostWindow pointer.  Fix is to add a
2028         NULL check for this.  
2029
2030         * platform/ScrollView.cpp:
2031         (WebCore::ScrollView::scrollContents):
2032
2033 2009-02-26  Rahul Kuchhal  <kuchhal@chromium.org>
2034
2035         Reviewed by Dave Hyatt.
2036
2037         https://bugs.webkit.org/show_bug.cgi?id=24003
2038         Fix a crash caused by unsafe type conversion.
2039
2040         Test: fast/block/positioning/absolute-in-inline-rtl-4.html
2041
2042         * rendering/RenderBox.cpp:
2043         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
2044
2045 2009-02-26  Ojan Vafai  <ojan@chromium.org>
2046
2047         Reviewed by Adam Roben.
2048
2049         https://bugs.webkit.org/show_bug.cgi?id=24202
2050         Have drawNodeHighlight clip instead of clearing. This makes it work for
2051         both Safari and Chromium since Chromium draws the inspector highlighting
2052         in the same buffer as the page.
2053
2054         * inspector/InspectorController.cpp:
2055         (WebCore::quadToPath):
2056         (WebCore::drawOutlinedQuad):
2057         (WebCore::drawOutlinedQuadWithClip):
2058         (WebCore::drawHighlightForBox):
2059
2060 2009-02-26  David Hyatt  <hyatt@apple.com>
2061
2062         Reviewed by Dan Bernstein & Darin Adler
2063
2064         Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
2065         
2066         Added fast/inline/inline-continuation-borders.html
2067
2068         * rendering/InlineFlowBox.cpp:
2069         (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
2070
2071 2009-02-26  Simon Fraser  <simon.fraser@apple.com>
2072
2073         Build fix, no review.
2074         
2075         Try to fix the wx build after r41218.
2076
2077         * WebCoreSources.bkl:
2078
2079 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
2080
2081         Reviewed by Darin Adler.
2082
2083         https://bugs.webkit.org/show_bug.cgi?id=19527
2084         ASSERTION FAILED: containerA && containerB
2085
2086         Test: fast/dom/Range/bug-19527.html
2087
2088         * dom/Range.cpp:
2089         (WebCore::Range::isPointInRange):
2090         (WebCore::Range::comparePoint):
2091         Bring the behavior in line with current Firefox, making it impossible for these methods
2092         to pass a null container to compareBoundaryPoints().
2093
2094 2009-02-26  Jonathon Jongsma  <jonathon@quotidian.org>
2095
2096         Reviewed by Holger Freyther.
2097
2098         https://bugs.webkit.org/show_bug.cgi?id=20358
2099
2100         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
2101         (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
2102         should set the computed size rather than the specified size, otherwise
2103         the caps just get rendered normal size.
2104
2105 2009-02-26  Benjamin Meyer  <benjamin.meyer@torchmobile.com>
2106
2107         Reviewed by George Staikos.
2108
2109         https://bugs.webkit.org/show_bug.cgi?id=24062
2110         QNetworkCookieJar expects the url and not the policy url.  Sending the
2111         policy url will cause QNetworkCookieJar to behave incorrectly.  One
2112         example would be a cookie that does not have a path or domain.
2113         QNetworkCookieJar will use the url it is given to fill in default values.
2114         This allows setting cookies on the url of the main frame from an iFrame
2115         when the cookie should be set on the url of the iFrame.
2116
2117         Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
2118
2119         * platform/qt/CookieJarQt.cpp:
2120         (WebCore::setCookies):
2121
2122 2009-02-26  Charles Wei  <charles.wei@torchmobile.com.cn>
2123
2124         Reviewed by George Staikos.
2125
2126         make WebKit/Qt compile with SVG disabled
2127
2128         * WebCore.pro:
2129         * platform/graphics/qt/FontPlatformDataQt.cpp:
2130
2131 2009-02-25  Gustavo Noronha Silva  <gns@gnome.org>
2132
2133         Unreviewed build fix. Add WebCore/workers to the list of paths
2134         searched by the bindings generator perl script.
2135
2136         * GNUmakefile.am:
2137
2138 2009-02-25  Sam Weinig  <sam@webkit.org>
2139
2140         Reviewed by Geoffrey Garen.
2141
2142         Add canvas to the list of RenderObjects that can mark a page as
2143         visually not empty.
2144
2145         * rendering/RenderHTMLCanvas.cpp:
2146         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
2147
2148 2009-02-25  Eric Carlson  <eric.carlson@apple.com>
2149
2150         Reviewed by Dave Hyatt.
2151
2152         * rendering/RenderBox.cpp:
2153         (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
2154         as RenderMedia with controls always has a layer.
2155
2156 2009-02-25  Dan Bernstein  <mitz@apple.com>
2157
2158         Reviewed by Simon Fraser.
2159
2160         - fix https://bugs.webkit.org/show_bug.cgi?id=24130
2161           <rdar://problem/6618196> Paint very slow when horizontally resizing
2162
2163         Test: fast/gradients/background-clipped.html
2164
2165         * rendering/RenderBoxModelObject.cpp:
2166         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
2167         destination rectangle passed to drawTiledImage() with the dirty
2168         rectangle. This makes it more likely for the destination rect to be
2169         contained in a single tile rect, which results in a faster code path
2170         being taken down the road (just drawing a single tile instead of
2171         tiling).
2172
2173 2009-02-25  Ojan Vafai  <ojan@chromium.org>
2174
2175         Reviewed by Eric Seidel.
2176
2177         Fix test regressions from positionForCoordinates patch.
2178         https://bugs.webkit.org/show_bug.cgi?id=24148
2179
2180         * rendering/RenderBlock.cpp:
2181         (WebCore::positionForPointWithInlineChildren):
2182         Remove ASSERT that placeholder text codepath is hitting.
2183
2184 2009-02-25  Chris Fleizach  <cfleizach@apple.com>
2185
2186         Reviewed by Beth Dakin.
2187
2188         Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
2189         https://bugs.webkit.org/show_bug.cgi?id=24143
2190
2191         When an AX object is marked dirty, do not create AX elements while going up the parent chain.
2192         Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
2193         Make sure the AXObjectWrapper's have an object before calling them
2194         In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
2195
2196         Test: platform/mac-snowleopard/accessibility/table-updating.html
2197
2198         * WebCore.base.exp:
2199         * page/AXObjectCache.cpp:
2200         (WebCore::AXObjectCache::~AXObjectCache):
2201         (WebCore::AXObjectCache::get):
2202         (WebCore::AXObjectCache::getOrCreate):
2203         (WebCore::AXObjectCache::removeAXID):
2204         (WebCore::AXObjectCache::handleActiveDescendantChanged):
2205         (WebCore::AXObjectCache::handleAriaRoleChanged):
2206         * page/AXObjectCache.h:
2207         * page/AccessibilityImageMapLink.cpp:
2208         (WebCore::AccessibilityImageMapLink::parentObject):
2209         * page/AccessibilityListBox.cpp:
2210         (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
2211         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
2212         * page/AccessibilityListBoxOption.cpp:
2213         (WebCore::AccessibilityListBoxOption::elementRect):
2214         (WebCore::AccessibilityListBoxOption::parentObject):
2215         * page/AccessibilityObject.cpp:
2216         (WebCore::AccessibilityObject::detach):
2217         (WebCore::AccessibilityObject::parentObjectIfExists):
2218         (WebCore::replacedNodeNeedsCharacter):
2219         (WebCore::AccessibilityObject::accessibilityObjectForPosition):
2220         * page/AccessibilityObject.h:
2221         * page/AccessibilityRenderObject.cpp:
2222         (WebCore::AccessibilityRenderObject::firstChild):
2223         (WebCore::AccessibilityRenderObject::lastChild):
2224         (WebCore::AccessibilityRenderObject::previousSibling):
2225         (WebCore::AccessibilityRenderObject::nextSibling):
2226         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
2227         (WebCore::AccessibilityRenderObject::parentObject):
2228         (WebCore::AccessibilityRenderObject::isAttachment):
2229         (WebCore::AccessibilityRenderObject::headingLevel):
2230         (WebCore::AccessibilityRenderObject::anchorElement):
2231         (WebCore::AccessibilityRenderObject::menuForMenuButton):
2232         (WebCore::AccessibilityRenderObject::menuButtonForMenu):
2233         (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
2234         (WebCore::AccessibilityRenderObject::internalLinkElement):
2235         (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
2236         (WebCore::AccessibilityRenderObject::titleUIElement):
2237         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2238         (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
2239         (WebCore::AccessibilityRenderObject::getDocumentLinks):
2240         (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
2241         (WebCore::AccessibilityRenderObject::focusedUIElement):
2242         (WebCore::AccessibilityRenderObject::activeDescendant):
2243         (WebCore::AccessibilityRenderObject::observableObject):
2244         (WebCore::AccessibilityRenderObject::childrenChanged):
2245         (WebCore::AccessibilityRenderObject::addChildren):
2246         * page/AccessibilityRenderObject.h:
2247         (WebCore::AccessibilityRenderObject::setRenderObject):
2248         * page/AccessibilityTable.cpp:
2249         (WebCore::AccessibilityTable::addChildren):
2250         (WebCore::AccessibilityTable::headerContainer):
2251         (WebCore::AccessibilityTable::cellForColumnAndRow):
2252         * page/AccessibilityTableCell.cpp:
2253         (WebCore::AccessibilityTableCell::isTableCell):
2254         (WebCore::AccessibilityTableCell::titleUIElement):
2255         * page/AccessibilityTableColumn.cpp:
2256         (WebCore::AccessibilityTableColumn::headerObjectForSection):
2257         * page/AccessibilityTableRow.cpp:
2258         (WebCore::AccessibilityTableRow::isTableRow):
2259         * page/gtk/AccessibilityObjectWrapperAtk.cpp:
2260         * page/mac/AXObjectCacheMac.mm:
2261         (WebCore::AXObjectCache::postNotification):
2262         (WebCore::AXObjectCache::postNotificationToElement):
2263         * page/mac/AccessibilityObjectWrapper.mm:
2264         (textMarkerForVisiblePosition):
2265         (AXLinkElementForNode):
2266         (nsStringForReplacedNode):
2267         (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
2268         (-[AccessibilityObjectWrapper accessibilityActionNames]):
2269         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2270         (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
2271         (-[AccessibilityObjectWrapper accessibilityHitTest:]):
2272         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
2273         (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
2274         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
2275         (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
2276         (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
2277         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
2278         (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
2279         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
2280         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
2281         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
2282
2283 2009-02-25  Beth Dakin  <bdakin@apple.com>
2284
2285         Reviewed by Geoff Garen.
2286
2287         Re-working of <rdar://problem/6487249> repro crash in 
2288         WebCore::CSSParser::parseFillImage copying entire contents of this 
2289         page
2290         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2291
2292         Fixes a bunch of layout test failures I caused!
2293
2294         * css/CSSParser.cpp:
2295         (WebCore::CSSParser::parseValue):
2296         (WebCore::CSSParser::parseContent):
2297         (WebCore::CSSParser::parseFillImage):
2298         (WebCore::CSSParser::parseFontFaceSrc):
2299         (WebCore::CSSParser::parseBorderImage):
2300
2301 2009-02-25  Dimitri Glazkov  <dglazkov@chromium.org>
2302
2303         Reviewed by Eric Seidel.
2304
2305         https://bugs.webkit.org/show_bug.cgi?id=24174
2306         Add more V8 custom bindings.
2307
2308         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
2309         (WebCore::hasCSSPropertyNamePrefix):
2310         (WebCore::cssPropertyName):
2311         (WebCore::NAMED_PROPERTY_GETTER):
2312         (WebCore::NAMED_PROPERTY_SETTER):
2313         * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
2314         (WebCore::INDEXED_PROPERTY_GETTER):
2315         (WebCore::CALLBACK_FUNC_DECL):
2316         * bindings/v8/custom/V8EventCustom.cpp: Added.
2317         (WebCore::ACCESSOR_SETTER):
2318         (WebCore::ACCESSOR_GETTER):
2319         * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
2320         (WebCore::NAMED_PROPERTY_DELETER):
2321         (WebCore::NAMED_PROPERTY_SETTER):
2322         (WebCore::NAMED_PROPERTY_GETTER):
2323         * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
2324         (WebCore::NAMED_PROPERTY_GETTER):
2325         * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
2326         (WebCore::INDEXED_PROPERTY_GETTER):
2327         (WebCore::NAMED_PROPERTY_GETTER):
2328         * bindings/v8/custom/V8NodeListCustom.cpp: Added.
2329         (WebCore::NAMED_PROPERTY_GETTER):
2330         * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
2331         (WebCore::NAMED_PROPERTY_GETTER):
2332
2333 2009-02-25  Scott Violet  <sky@google.com>
2334
2335         Reviewed by Dave Hyatt.
2336
2337         https://bugs.webkit.org/show_bug.cgi?id=24171
2338         Provides a RenderTheme method for getting the scroll bar size and
2339         changes RenderListBox to use it. RenderTheme returns a size of regular,
2340         and Mac's override to return small. Changes ScrollbarThemeChromium to
2341         use the scrollbarsize of the scrollbar when getting the size
2342         instead of passing in no-args.
2343
2344         * platform/chromium/ScrollbarThemeChromium.cpp:
2345         (WebCore::ScrollbarThemeChromium::trackRect):
2346         (WebCore::ScrollbarThemeChromium::buttonSize):
2347         * rendering/RenderListBox.cpp:
2348         (WebCore::RenderListBox::createScrollbar):
2349         * rendering/RenderTheme.h:
2350         (WebCore::RenderTheme::scrollbarControlSizeForPart):
2351         * rendering/RenderThemeChromiumMac.h:
2352         (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
2353         * rendering/RenderThemeMac.h:
2354         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
2355
2356 2009-02-25  Beth Dakin  <bdakin@apple.com>
2357
2358         Reviewed by Darin Adler.
2359
2360         Fix for <rdar://problem/6487249> repro crash in 
2361         WebCore::CSSParser::parseFillImage copying entire contents of this 
2362         page
2363         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2364
2365         * css/CSSParser.cpp:
2366         (WebCore::CSSParser::parseValue): Null-check m_styleSheet
2367
2368 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
2369
2370         Fix the Qt build.
2371
2372         * WebCore.pro:
2373
2374 2009-02-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2375
2376         Gtk build fix. Not reviewed.
2377
2378         Add files to the build per r41218.
2379         Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp
2380
2381         * GNUmakefile.am:
2382         * page/DOMWindow.cpp:
2383
2384 2009-02-25  Zan Dobersek  <zandobersek@gmail.com>
2385
2386         Reviewed by Alexey Proskuryakov.
2387
2388         https://bugs.webkit.org/show_bug.cgi?id=24043
2389         When faced with URLs with unsupported protocol on Gtk port,
2390         report the error through an idle function and return true, so
2391         a proper resource handle is created.
2392
2393         * platform/network/soup/ResourceHandleSoup.cpp:
2394         (WebCore::reportUnknownProtocolError):
2395         (WebCore::ResourceHandle::start):
2396
2397 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2398
2399         Windows build fix.
2400         Use struct to forward declare ResourceRequest.
2401
2402         * history/HistoryItem.h:
2403         * inspector/InspectorController.h:
2404         * loader/DocumentThreadableLoader.h:
2405         * loader/FrameLoaderClient.h:
2406         * loader/MainResourceLoader.h:
2407         * loader/SubresourceLoader.h:
2408         * loader/SubresourceLoaderClient.h:
2409         * loader/ThreadableLoader.h:
2410         * loader/WorkerThreadableLoader.h:
2411         * platform/CrossThreadCopier.h:
2412         * platform/network/ResourceHandle.h:
2413         * platform/network/ResourceHandleClient.h:
2414         * platform/network/ResourceRequestBase.h:
2415         * platform/network/cf/ResourceRequestCFNet.h:
2416         * xml/XMLHttpRequest.h:
2417
2418 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2419
2420         Partial Windows build fix.
2421         
2422         * DerivedSources.cpp:
2423         * WebCore.vcproj/WebCore.vcproj:
2424
2425 2009-02-25  Dirk Schulze  <krit@webkit.org>
2426
2427         Reviewed by Oliver Hunt.
2428
2429         Ported arcTo to Qt. Qt has no native support for arcTo. This changes
2430         calculate the behavior of arcTo and draws it with lineTo and arc.
2431
2432         [QT] implement Canvas arcTo
2433         https://bugs.webkit.org/show_bug.cgi?id=23873
2434
2435         * platform/graphics/qt/PathQt.cpp:
2436         (WebCore::Path::addArcTo):
2437
2438 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
2439
2440         Reviewed by Dan Bernstein
2441
2442         Remove idl files from Resources, and sort.
2443         
2444         * WebCore.xcodeproj/project.pbxproj:
2445
2446 2009-02-25  Chris Marrin  <cmarrin@apple.com>
2447
2448         Reviewed by Simon Fraser.
2449
2450         https://bugs.webkit.org/show_bug.cgi?id=23943
2451
2452         Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
2453         the window object. Also added WebKitPoint object, which is passed in and out
2454         of these functions.
2455
2456         Test: fast/dom/Window/webkitConvertPoint.html
2457
2458         * DerivedSources.make:
2459         * WebCore.pro:
2460         * WebCore.vcproj/WebCore.vcproj:
2461         * WebCore.xcodeproj/project.pbxproj:
2462         * WebCoreSources.bkl:
2463         * bindings/js/JSDOMWindowBase.cpp:
2464         (jsDOMWindowBaseWebKitPoint):
2465         (setJSDOMWindowBaseWebKitPoint):
2466         * bindings/js/JSWebKitPointConstructor.cpp: Added.
2467         (WebCore::):
2468         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
2469         (WebCore::constructWebKitPoint):
2470         (WebCore::JSWebKitPointConstructor::getConstructData):
2471         * bindings/js/JSWebKitPointConstructor.h: Added.
2472         (WebCore::JSWebKitPointConstructor::classInfo):
2473         * dom/Node.cpp:
2474         (WebCore::Node::convertToPage):
2475         (WebCore::Node::convertFromPage):
2476         * dom/Node.h:
2477         * page/DOMWindow.cpp:
2478         (WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
2479         (WebCore::DOMWindow::webkitConvertPointFromPageToNode):
2480         * page/DOMWindow.h:
2481         * page/DOMWindow.idl:
2482         * page/WebKitPoint.h: Added.
2483         (WebCore::WebKitPoint::create):
2484         (WebCore::WebKitPoint::x):
2485         (WebCore::WebKitPoint::y):
2486         (WebCore::WebKitPoint::setX):
2487         (WebCore::WebKitPoint::setY):
2488         (WebCore::WebKitPoint::WebKitPoint):
2489         * page/WebKitPoint.idl: Added.
2490
2491 2009-02-25  Jian Li  <jianli@chromium.org>
2492
2493         Reviewed by Alexey Proskuryakov.
2494
2495         Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
2496         https://bugs.webkit.org/show_bug.cgi?id=24145
2497
2498         * platform/CrossThreadCopier.cpp:
2499         * platform/CrossThreadCopier.h:
2500
2501 2009-02-25  David Levin  <levin@chromium.org>
2502
2503         Reviewed by Alexey Proskuryakov.
2504
2505         Bug 23688: ThreadableLoader needs a sync implementation for Workers.
2506         <https://bugs.webkit.org/show_bug.cgi?id=23688>
2507
2508         No observable change in behavior, so no test.
2509
2510         * loader/ThreadableLoader.cpp:
2511         (WebCore::ThreadableLoader::loadResourceSynchronously):
2512         * loader/ThreadableLoaderClientWrapper.h:
2513         (WebCore::ThreadableLoaderClientWrapper::clearClient):
2514         (WebCore::ThreadableLoaderClientWrapper::done):
2515         (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
2516         (WebCore::ThreadableLoaderClientWrapper::didFail):
2517         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
2518         (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
2519         Expose whether the loader is done (based on what callbacks were done).
2520
2521         * loader/WorkerThreadableLoader.cpp:
2522         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
2523         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
2524         Each loader is given its own mode so that only its callbacks get through the run loop.
2525
2526         The xhr spec says that the readystatechange events are synchronous, so in the case of a
2527         nested sync xhr no readystatechange events should be fired for the outer xhr.
2528
2529         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
2530
2531         * loader/WorkerThreadableLoader.h:
2532         (WebCore::WorkerThreadableLoader::create):
2533         (WebCore::WorkerThreadableLoader::done):
2534
2535         * workers/WorkerRunLoop.cpp:
2536         (WebCore::WorkerRunLoop::WorkerRunLoop):
2537         * workers/WorkerRunLoop.h:
2538         (WebCore::WorkerRunLoop::createUniqueId):
2539         Simple method to create a uniqueId on demand with respect to the run loop.
2540
2541         * workers/WorkerThread.h:
2542
2543 2009-02-25  David Levin  <levin@chromium.org>
2544
2545         Reviewed by Alexey Proskuryakov.
2546
2547         Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
2548         <https://bugs.webkit.org/show_bug.cgi?id=24089>
2549
2550         Make threadable loader callbacks to happen during the sync load call.
2551
2552         Changes the behavior of sync xhr for insecure redirects in two ways:
2553         + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
2554         + Throws a network exception which is what other browsers do and what the spec
2555         says to do (http://www.w3.org/TR/XMLHttpRequest/).
2556
2557         * loader/DocumentThreadableLoader.cpp:
2558         (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
2559         * loader/DocumentThreadableLoader.h:
2560         * loader/ThreadableLoader.cpp:
2561         (WebCore::ThreadableLoader::loadResourceSynchronously):
2562         * loader/ThreadableLoader.h:
2563         * xml/XMLHttpRequest.cpp:
2564         (WebCore::XMLHttpRequest::XMLHttpRequest):
2565         (WebCore::XMLHttpRequest::loadRequestSynchronously):
2566         (WebCore::XMLHttpRequest::loadRequestAsynchronously):
2567         (WebCore::XMLHttpRequest::didFail):
2568         (WebCore::XMLHttpRequest::didFailRedirectCheck):
2569         * xml/XMLHttpRequest.h:
2570
2571 2009-02-24  Chris Marrin  <cmarrin@apple.com>
2572
2573         Reviewed by David Hyatt.
2574
2575         https://bugs.webkit.org/show_bug.cgi?id=23368
2576
2577         Added logic to correctly hit test accelerated layers.
2578
2579         Tests: animations/animation-hit-test-transform.html
2580                animations/animation-hit-test.html
2581                transitions/transition-hit-test-transform.html
2582                transitions/transition-hit-test.html
2583
2584         * page/animation/KeyframeAnimation.cpp:
2585         (WebCore::KeyframeAnimation::animate):
2586         * rendering/RenderLayer.cpp:
2587         (WebCore::RenderLayer::hitTestLayer):
2588         (WebCore::RenderLayer::updateClipRects):
2589         * rendering/RenderLayerBacking.cpp:
2590         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2591
2592 2009-02-25  Alexey Proskuryakov  <ap@webkit.org>
2593
2594         Reviewed by Darin Adler.
2595
2596         https://bugs.webkit.org/show_bug.cgi?id=24067
2597         REGRESSION: Crash in WebCore::Document::initSecurityContext
2598
2599         The crash started to happen when we removed a check for frame->document() being null.
2600         However, the original document shouldn't be null here, because it is needed to alias
2601         security origins. So, this patch fixes the crash by correcting security origin behavior.
2602
2603         Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
2604         This tests for not crashing, and for inheriting the domain from the document being replaced.
2605         Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
2606         domain to remove a prefix from.
2607
2608         * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
2609         clearing the frame, so that Document::initSecurityContext() could access the old one.
2610
2611 2009-02-25  Jay Campan  <jcampan@google.com>
2612
2613         Reviewed by Darin Fisher.
2614
2615         https://bugs.webkit.org/show_bug.cgi?id=24066
2616
2617         Items in drop-downs were not painted correctly.  Makes sure the
2618         PopupListBox invalidates in the coordinates of the window as this is
2619         FramelessScrollView::invalidateRect paints to.
2620
2621         * platform/chromium/PopupMenuChromium.cpp:
2622         (WebCore::PopupListBox::invalidateRow):
2623
2624 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2625
2626         Reviewed by Anders Carlsson
2627
2628         https://bugs.webkit.org/show_bug.cgi?id=15081
2629         
2630         Make display:none work for applet, emebed and object elements
2631         by calling rendererIsNeeded() on superclasses.
2632
2633         Tests: fast/replaced/applet-display-none.html
2634                fast/replaced/embed-display-none.html
2635                fast/replaced/object-display-none.html
2636
2637         * html/HTMLAppletElement.cpp:
2638         (WebCore::HTMLAppletElement::rendererIsNeeded):
2639         * html/HTMLElement.cpp:
2640         (WebCore::HTMLElement::rendererIsNeeded):
2641         * html/HTMLEmbedElement.cpp:
2642         (WebCore::HTMLEmbedElement::rendererIsNeeded):
2643         * html/HTMLObjectElement.cpp:
2644         (WebCore::HTMLObjectElement::rendererIsNeeded):
2645
2646 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2647
2648         Reviewed by Dave Hyatt
2649
2650         https://bugs.webkit.org/show_bug.cgi?id=24137
2651         
2652         Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
2653         taking perspective and transform-style: preserve-3d into account.
2654         
2655         In order to support transform-style: preserve-3d, which keeps elements in a
2656         3d space, we have to carry along an accumulated matrix in TransformState.
2657         We also need to apply the perspective from the parent, if any, with the
2658         appropriate origin.
2659
2660         * GNUmakefile.am:
2661         * WebCore.base.exp:
2662         * WebCore.pro:
2663         * WebCore.scons:
2664         * WebCore.vcproj/WebCore.vcproj:
2665         * WebCore.xcodeproj/project.pbxproj:
2666         * WebCoreSources.bkl:
2667         * css/CSSComputedStyleDeclaration.cpp:
2668         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2669         * platform/graphics/transforms/TransformationMatrix.cpp:
2670         (WebCore::TransformationMatrix::translate):
2671         (WebCore::TransformationMatrix::translate3d):
2672         (WebCore::TransformationMatrix::translateRight3d):
2673         * platform/graphics/transforms/TransformationMatrix.h:
2674         * rendering/RenderBox.cpp:
2675         (WebCore::RenderBox::mapLocalToAbsolutePoint):
2676         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
2677         * rendering/RenderBox.h:
2678         * rendering/RenderLayer.cpp:
2679         (WebCore::RenderLayer::updateTransform):
2680         (WebCore::RenderLayer::perspectiveTransform):
2681         (WebCore::RenderLayer::perspectiveOrigin):
2682         * rendering/RenderLayer.h:
2683         * rendering/RenderLayerBacking.cpp:
2684         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2685         * rendering/RenderLayerCompositor.cpp:
2686         (WebCore::requiresCompositingLayerForTransform):
2687         (WebCore::RenderLayerCompositor::layerHas3DContent):
2688         * rendering/RenderObject.cpp:
2689         (WebCore::RenderObject::localToAbsolute):
2690         (WebCore::RenderObject::absoluteToLocal):
2691         (WebCore::RenderObject::mapLocalToAbsolutePoint):
2692         (WebCore::RenderObject::mapAbsoluteToLocalPoint):
2693         * rendering/RenderObject.h:
2694         * rendering/RenderTableCell.cpp:
2695         (WebCore::RenderTableCell::mapLocalToAbsolutePoint):
2696         (WebCore::RenderTableCell::mapAbsoluteToLocalPoint):
2697         * rendering/RenderTableCell.h:
2698         * rendering/RenderView.cpp:
2699         (WebCore::RenderView::mapLocalToAbsolutePoint):
2700         (WebCore::RenderView::mapAbsoluteToLocalPoint):
2701         * rendering/RenderView.h:
2702         * rendering/TransformState.cpp: Added.
2703         (WebCore::TransformState::move):
2704         (WebCore::TransformState::applyTransform):
2705         (WebCore::TransformState::flatten):
2706         * rendering/TransformState.h: Added.
2707         (WebCore::TransformState::):
2708         (WebCore::TransformState::TransformState):
2709         (WebCore::TransformState::move):
2710         * rendering/style/RenderStyle.h:
2711         (WebCore::InheritedFlags::hasPerspective):
2712
2713 2009-02-24  Sam Weinig  <sam@webkit.org>
2714
2715         Reviewed by David Hyatt.
2716
2717         Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
2718         Regression (r40837): JavaScript image popup doesn't work
2719
2720         Make the getClientRects and getBoundingClientRect methods return rects
2721         relative to the viewport.
2722
2723         Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
2724
2725         * dom/Element.cpp:
2726         (WebCore::Element::getClientRects):
2727         (WebCore::Element::getBoundingClientRect):
2728
2729 2009-02-24  Ojan Vafai  <ojan@chromium.org>
2730
2731         Reviewed by Eric Seidel.
2732
2733         SVG pages don't have a body or an html element! 
2734         Don't return early if there is no body.
2735
2736         * editing/VisiblePosition.cpp:
2737         (WebCore::VisiblePosition::canonicalPosition):
2738
2739 2009-02-23  David Hyatt  <hyatt@apple.com>
2740
2741         Reviewed by Eric Seidel
2742
2743         https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden
2744         
2745         This patch reworks the painting of overflow.  There is now the concept of a "self-painting layer."  All
2746         layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
2747         reflections or masks).
2748         
2749         If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
2750         The only difference is that the clip has to be pushed and popped when painting the object's children.
2751         
2752         The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case.  With
2753         the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
2754         use the new functions.
2755         
2756         Hit testing has also been patched to check the overflow clip rect first before recurring into children.
2757         
2758         Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
2759         yet, and scrollbar hit testing was already there anyway.  Now the two code paths are more symmetrical.
2760         
2761         Masks are now treated like normal flow layers (just like reflections).
2762
2763         A couple of test cases have been added to fast/overflow to test the stacking order. 
2764
2765         * rendering/InlineFlowBox.cpp:
2766         (WebCore::InlineFlowBox::nodeAtPoint):
2767         (WebCore::InlineFlowBox::paint):
2768         * rendering/RenderBlock.cpp:
2769         (WebCore::RenderBlock::repaintOverhangingFloats):
2770         (WebCore::RenderBlock::paint):
2771         (WebCore::RenderBlock::paintChildren):
2772         (WebCore::RenderBlock::paintObject):
2773         (WebCore::RenderBlock::paintFloats):
2774         (WebCore::RenderBlock::insertFloatingObject):
2775         (WebCore::RenderBlock::floatRect):
2776         (WebCore::RenderBlock::lowestPosition):
2777         (WebCore::RenderBlock::rightmostPosition):
2778         (WebCore::RenderBlock::leftmostPosition):
2779         (WebCore::RenderBlock::addOverhangingFloats):
2780         (WebCore::RenderBlock::nodeAtPoint):
2781         (WebCore::RenderBlock::hitTestContents):
2782         * rendering/RenderBox.cpp:
2783         (WebCore::RenderBox::nodeAtPoint):
2784         (WebCore::RenderBox::pushContentsClip):
2785         (WebCore::RenderBox::popContentsClip):
2786         * rendering/RenderBox.h:
2787         (WebCore::RenderBox::paintObject):
2788         * rendering/RenderBoxModelObject.cpp:
2789         (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
2790         * rendering/RenderBoxModelObject.h:
2791         * rendering/RenderLayer.cpp:
2792         (WebCore::RenderLayer::paintLayer):
2793         (WebCore::RenderLayer::hitTestLayer):
2794         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
2795         (WebCore::RenderLayer::isSelfPaintingLayer):
2796         * rendering/RenderLayer.h:
2797         * rendering/RenderTable.cpp:
2798         (WebCore::RenderTable::paint):
2799         (WebCore::RenderTable::paintObject):
2800         (WebCore::RenderTable::nodeAtPoint):
2801         * rendering/RenderTable.h:
2802         * rendering/RenderTableCell.cpp:
2803         (WebCore::RenderTableCell::paint):
2804         * rendering/RenderTableRow.cpp:
2805         (WebCore::RenderTableRow::nodeAtPoint):
2806         (WebCore::RenderTableRow::paint):
2807         * rendering/RenderTableRow.h:
2808         * rendering/RenderTableSection.cpp:
2809         (WebCore::RenderTableSection::paint):
2810         (WebCore::RenderTableSection::paintObject):
2811         (WebCore::RenderTableSection::nodeAtPoint):
2812         * rendering/RenderTableSection.h:
2813         * rendering/RenderTreeAsText.cpp:
2814         (WebCore::write):
2815         (WebCore::writeLayers):
2816
2817 2009-02-24  David Levin  <levin@chromium.org>
2818
2819         Reviewed by NOBODY (build fix).
2820
2821         Attempted build fix for wx-mac.
2822
2823         * WebCoreSources.bkl:
2824
2825 2009-02-24  David Levin  <levin@chromium.org>
2826
2827         Reviewed by NOBODY (build fix).
2828
2829         Attempted build fixes for qt-linux and wx-mac.
2830
2831         * WebCore.pro:
2832         * webcore-base.bkl:
2833
2834 2009-02-24  Ojan Vafai  <ojan@dhcp-172-31-134-214.sfo.corp.google.com>
2835
2836         Reviewed by Sam Weinig.
2837
2838         Fix null pointer error. If the node is the Document, then ownerDocument() 
2839         returns null, document() does not.
2840
2841         * editing/VisiblePosition.cpp:
2842         (WebCore::VisiblePosition::canonicalPosition):
2843
2844 2009-02-24  Jian Li  <jianli@chromium.org>
2845
2846         Reviewed by NOBODY (attempted build fixes).
2847
2848         Fix build break for Windows and Linux.
2849
2850         * GNUmakefile.am:
2851         * WebCore.vcproj/WebCore.vcproj:
2852
2853 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2854
2855         Reviewed by Eric Seidel.
2856
2857         https://bugs.webkit.org/show_bug.cgi?id=24131
2858         Fix-up COM/RefCounted dichotomy in Chromium port.
2859
2860         * page/chromium/AccessibilityObjectWrapper.h:
2861         (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
2862         explicit setting of recount.
2863
2864 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2865
2866         Reviewed by Eric Seidel.
2867
2868         https://bugs.webkit.org/show_bug.cgi?id=24141
2869         Add clarity to V8 interceptor helper function.
2870
2871         * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
2872         (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
2873         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
2874         (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
2875         (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
2876
2877 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2878
2879         Reviewed by Eric Seidel
2880
2881         Minor numeric cleanup: convert float literals to doubles.
2882         
2883         * platform/graphics/transforms/RotateTransformOperation.cpp:
2884         (WebCore::RotateTransformOperation::blend):
2885
2886 2009-02-24  Mark Mentovai  <mark@chromium.org>
2887
2888         Reviewed by Eric Seidel.
2889
2890         https://bugs.webkit.org/show_bug.cgi?id=24139
2891         Add missing include.
2892
2893         * bindings/v8/ScriptInstance.h:
2894
2895 2009-02-24  Jian Li  <jianli@chromium.org>
2896
2897         Reviewed by Alexey Proskuryakov.
2898
2899         Move worker related files from dom directory to worker directory under WebCore.
2900         https://bugs.webkit.org/show_bug.cgi?id=24123
2901
2902         * DerivedSources.make:
2903         * GNUmakefile.am:
2904         * WebCore.pro:
2905         * WebCore.scons:
2906         * WebCore.vcproj/MigrateIDLAndScripts:
2907         * WebCore.vcproj/WebCore.vcproj:
2908         * WebCore.xcodeproj/project.pbxproj:
2909         * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
2910         * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
2911         * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
2912         * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
2913         * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
2914         * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
2915         * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
2916         * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
2917         * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
2918         * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
2919         * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
2920         * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
2921         * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
2922         * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
2923         * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
2924         * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
2925         * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
2926         * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
2927         * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
2928         * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
2929
2930 2009-02-05  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
2931
2932         Reviewed by Dave Hyatt.
2933
2934         Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
2935         around divs inside editable regions.
2936         https://bugs.webkit.org/show_bug.cgi?id=23605
2937
2938         Fix clicks outside editable regions from focusing the editable region.
2939         https://bugs.webkit.org/show_bug.cgi?id=23607
2940
2941         Removed editing/selection/contenteditable-click-outside.html as it's
2942         not as useful as our new tests.
2943
2944         Clean up RenderBlock::positionForCoordinates to remove dead code,
2945         duplicate code, and generally make it more readable.
2946
2947         Tests: editing/selection/click-in-margins-inside-editable-div.html
2948                editing/selection/click-in-padding-with-multiple-line-boxes.html
2949                editing/selection/click-outside-editable-div.html
2950
2951         * editing/VisiblePosition.cpp:
2952         (WebCore::VisiblePosition::canonicalPosition):
2953         * rendering/RenderBlock.cpp:
2954         (WebCore::positionForPointRespectingEditingBoundaries):
2955         (WebCore::positionForPointWithInlineChildren):
2956         (WebCore::RenderBlock::positionForCoordinates):
2957         (WebCore::RenderBlock::updateFirstLetter):
2958
2959 2009-02-24  Sam Weinig  <sam@webkit.org>
2960
2961         Reviewed by Geoffrey Garen.
2962
2963         Related to <rdar://problem/6590295>
2964         Allow disabling javascript: urls.
2965
2966         * WebCore.base.exp:
2967         * html/HTMLAnchorElement.cpp:
2968         (WebCore::HTMLAnchorElement::parseMappedAttribute):
2969         * loader/FrameLoader.cpp:
2970         (WebCore::FrameLoader::executeIfJavaScriptURL):
2971         * page/Page.cpp:
2972         (WebCore::Page::Page):
2973         (WebCore::Page::setJavaScriptURLsAreAllowed):
2974         (WebCore::Page::javaScriptURLsAreAllowed):
2975         * page/Page.h:
2976
2977 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2978
2979         Fix build when ACCELERATED_COMPOSITING is turned on
2980         (overflowList() -> normalFlowList()).
2981     
2982         * rendering/RenderLayerBacking.cpp:
2983         (WebCore::RenderLayerBacking::hasNonCompositingContent):
2984         (WebCore::RenderLayerBacking::paintIntoLayer):
2985         * rendering/RenderLayerCompositor.cpp:
2986         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
2987         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2988         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
2989         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
2990         (WebCore::RenderLayerCompositor::layerHas3DContent):
2991
2992 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2993
2994         Reviewed by Darin Adler
2995         
2996         https://bugs.webkit.org/show_bug.cgi?id=24135
2997         
2998         Round the FloatPoint returned by absoluteToLocal(), rather than
2999         truncating it.
3000
3001         * dom/MouseRelatedEvent.cpp:
3002         (WebCore::MouseRelatedEvent::receivedTarget):
3003
3004 2009-02-24  Beth Dakin  <bdakin@apple.com>
3005
3006         Reviewed by Sam Weinig.
3007
3008         Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION: 
3009         Ordered list item marker misaligned when line height is not 1.2 
3010         -and corresponding <rdar://problem/6602506>
3011
3012         This is a regression from http://trac.webkit.org/changeset/40880 
3013         where createInlineBox was taken off of RenderObject and moved to 
3014         RenderBox. The problem was that the RenderBox version still needs 
3015         to be virtual because there is still an existing implementation in 
3016         RenderListMarker. 
3017
3018         * rendering/RenderBox.h:
3019         * rendering/RenderListMarker.cpp:
3020         (WebCore::RenderListMarker::createInlineBox):
3021         * rendering/RenderListMarker.h:
3022
3023 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
3024
3025         Reviewed by Eric Seidel.
3026
3027         https://bugs.webkit.org/show_bug.cgi?id=24128
3028         Upstream more V8 custom bindings: constructors, XSLTProcessor.
3029
3030         * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
3031         (WebCore::CALLBACK_FUNC_DECL):
3032         * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
3033         (WebCore::CALLBACK_FUNC_DECL):
3034         * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
3035         (WebCore::CALLBACK_FUNC_DECL):
3036         * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
3037         (WebCore::CALLBACK_FUNC_DECL):
3038         * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
3039         (WebCore::CALLBACK_FUNC_DECL):
3040         * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
3041         (WebCore::CALLBACK_FUNC_DECL):
3042
3043 2009-02-24  David Levin  <levin@chromium.org>
3044
3045         Reviewed by Alexey Proskuryakov.
3046
3047         Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
3048         <https://bugs.webkit.org/show_bug.cgi?id=24090>
3049
3050         No observable change in behavior, so no test.
3051
3052         * dom/WorkerMessagingProxy.cpp:
3053         (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
3054         (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
3055         Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.
3056
3057         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
3058
3059         * dom/WorkerMessagingProxy.h:
3060         * loader/ThreadableLoader.cpp:
3061         (WebCore::ThreadableLoader::create):
3062         * loader/WorkerThreadableLoader.cpp:
3063         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
3064         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
3065         (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
3066         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
3067         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
3068         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
3069         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
3070         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
3071         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
3072         Changed these methods to post task using a mode.
3073
3074         * loader/WorkerThreadableLoader.h:
3075         (WebCore::WorkerThreadableLoader::create):
3076
3077 2009-02-24  Alexey Proskuryakov  <ap@webkit.org>
3078
3079         Reviewed by Darin Adler.
3080
3081         https://bugs.webkit.org/show_bug.cgi?id=24091
3082         <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache
3083
3084         Test: http/tests/appcache/access-via-redirect.php
3085
3086         * loader/appcache/ApplicationCacheGroup.cpp:
3087         (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
3088         not the original one.
3089
3090 2009-02-24  Jian Li  <jianli@chromium.org>
3091
3092         Reviewed by Alexey Proskuryakov.
3093
3094         Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
3095         https://bugs.webkit.org/show_bug.cgi?id=24112
3096
3097         * bindings/js/WorkerScriptController.cpp:
3098         * dom/WorkerContext.cpp:
3099
3100 2009-02-23  Antti Koivisto  <antti@apple.com>
3101
3102         Reviewed by Oliver Hunt.
3103
3104         <rdar://problem/6613796> Extended text codecs registered on webview creation
3105
3106         Comparing a text encoding with string "GBK" ended up constructing
3107         TextEncoding("GBK") which in turn initialized all extended
3108         text codecs.
3109
3110         * platform/text/TextCodecICU.cpp:
3111         (WebCore::TextCodecICU::decode):
3112
3113 2009-02-23  Sam Weinig  <sam@webkit.org>
3114
3115         Fix Qt build.
3116
3117         * bridge/qt/qt_runtime.cpp:
3118         (JSC::Bindings::valueRealType):
3119
3120 2009-02-23  Julien Chaffraix  <jchaffraix@webkit.org>
3121
3122         Reviewed by Darin Adler.
3123
3124         Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)
3125
3126         The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
3127         element created with createElement could have a wrong nodeName (createElement sets the string as the
3128         localName without checking for a prefix).
3129
3130         The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
3131         and will always succeed.
3132         Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
3133         to ensure that).
3134
3135         Test: fast/dom/cloneNode.html
3136
3137         * dom/Element.cpp:
3138         (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
3139         always return an element.
3140
3141         * html/HTMLElement.cpp:
3142         * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.
3143
3144 2009-02-23  Dimitri Glazkov  <dglazkov@chromium.org>
3145
3146         Reviewed by Eric Seidel.
3147
3148         https://bugs.webkit.org/show_bug.cgi?id=24109
3149         Upstream V8 Script abstractions, all except ScriptController.
3150
3151         * bindings/v8/ScriptCachedFrameData.h: Added.
3152         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
3153         (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
3154         (WebCore::ScriptCachedFrameData::restore):
3155         (WebCore::ScriptCachedFrameData::clear):
3156         (WebCore::ScriptCachedFrameData::domWindow):
3157         * bindings/v8/ScriptCallFrame.cpp: Added.
3158         (WebCore::ScriptCallFrame::ScriptCallFrame):
3159         (WebCore::ScriptCallFrame::~ScriptCallFrame):
3160         (WebCore::ScriptCallFrame::argumentAt):
3161         * bindings/v8/ScriptCallFrame.h: Added.
3162         (WebCore::ScriptCallFrame::functionName):
3163         (WebCore::ScriptCallFrame::sourceURL):
3164         (WebCore::ScriptCallFrame::lineNumber):
3165         (WebCore::ScriptCallFrame::argumentCount):
3166         * bindings/v8/ScriptCallStack.cpp: Added.
3167         (WebCore::ScriptCallStack::ScriptCallStack):
3168         (WebCore::ScriptCallStack::~ScriptCallStack):
3169         (WebCore::ScriptCallStack::at):
3170         * bindings/v8/ScriptCallStack.h: Added.
3171         (WebCore::ScriptCallStack::size):
3172         * bindings/v8/ScriptInstance.cpp: Added.
3173         (WebCore::V8ScriptInstance::V8ScriptInstance):
3174         (WebCore::V8ScriptInstance::~V8ScriptInstance):
3175         (WebCore::V8ScriptInstance::instance):
3176         (WebCore::V8ScriptInstance::clear):
3177         (WebCore::V8ScriptInstance::set):
3178         * bindings/v8/ScriptInstance.h: Added.
3179         (WebCore::V8ScriptInstance::create):
3180         * bindings/v8/ScriptSourceCode.h: Added.
3181         (WebCore::ScriptSourceCode::ScriptSourceCode):
3182         (WebCore::ScriptSourceCode::isEmpty):
3183         (WebCore::ScriptSourceCode::source):
3184         (WebCore::ScriptSourceCode::url):
3185         (WebCore::ScriptSourceCode::startLine):
3186         * bindings/v8/ScriptState.h: Added.
3187         (WebCore::ScriptState::hadException):
3188         (WebCore::ScriptState::setException):
3189         (WebCore::ScriptState::exception):
3190         * bindings/v8/ScriptString.h: Added.
3191         (WebCore::ScriptString::ScriptString):
3192         (WebCore::ScriptString::operator String):
3193         (WebCore::ScriptString::isNull):
3194         (WebCore::ScriptString::size):
3195         (WebCore::ScriptString::operator=):
3196         (WebCore::ScriptString::operator+=):
3197         * bindings/v8/ScriptValue.cpp: Added.
3198         (WebCore::ScriptValue::getString):
3199         * bindings/v8/ScriptValue.h: Added.
3200         (WebCore::ScriptValue::ScriptValue):
3201         (WebCore::ScriptValue::operator=):
3202         (WebCore::ScriptValue::operator==):
3203         (WebCore::ScriptValue::operator!=):
3204         (WebCore::ScriptValue::isNull):
3205         (WebCore::ScriptValue::isUndefined):
3206         (WebCore::ScriptValue::clear):
3207         (WebCore::ScriptValue::~ScriptValue):
3208         (WebCore::ScriptValue::v8Value):
3209
3210 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3211
3212         Reviewed by Timothy Hatcher.
3213
3214         https://bugs.webkit.org/show_bug.cgi?id=24106
3215         The Qt port is crashing on exit because the tear down procedure involves
3216         the WebCore::InspectorController trying to access the JS execution context
3217         for a page that is being deleted.  This patch amends the inspector so
3218         that it does not try and access the execution context of the WebCore::Page
3219         in the midst of deletion.
3220
3221         * inspector/InspectorController.cpp:
3222         (WebCore::InspectorController::inspectedPageDestroyed):
3223         (WebCore::InspectorController::stopUserInitiatedProfiling):
3224
3225 2009-02-23  David Levin  <levin@chromium.org>
3226
3227         Reviewed by Alexey Proskuryakov.
3228
3229         Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
3230         <https://bugs.webkit.org/show_bug.cgi?id=24088>
3231
3232         No observable change in behavior, so no test.
3233
3234         * loader/DocumentThreadableLoader.cpp:
3235         (WebCore::DocumentThreadableLoader::create):
3236         * loader/ThreadableLoaderClient.h:
3237         (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
3238         * loader/ThreadableLoaderClientWrapper.h:
3239         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
3240         * loader/WorkerThreadableLoader.cpp:
3241         (WebCore::workerContextDidFailRedirectCheck):
3242         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
3243         * loader/WorkerThreadableLoader.h:
3244         * xml/XMLHttpRequest.cpp:
3245         (WebCore::XMLHttpRequest::didFinishLoading):
3246         * xml/XMLHttpRequest.h:
3247
3248 2009-02-23  David Levin  <levin@chromium.org>
3249
3250         Reviewed by Alexey Proskuryakov.
3251
3252         Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
3253         <https://bugs.webkit.org/show_bug.cgi?id=24047>
3254
3255         Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
3256         using only MessageQueue::waitForMessageFilteredWithTimeout instead
3257         of three different MessageQueue methods.
3258
3259         No observable change in behavior, so no test.
3260
3261         * dom/WorkerRunLoop.cpp:
3262         (WebCore::ModePredicate::operator()):
3263         Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
3264         (WebCore::WorkerRunLoop::runInMode):
3265         * dom/WorkerRunLoop.h:
3266
3267 2009-02-23  David Hyatt  <hyatt@apple.com>
3268
3269         In preparation for making layers for multicol objects (so that they can properly split child layers
3270         into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
3271         of RenderLayer to use the term "normal flow" instead.
3272
3273         Reviewed by Cameron Zwarich
3274
3275         * rendering/RenderLayer.cpp:
3276         (WebCore::RenderLayer::RenderLayer):
3277         (WebCore::RenderLayer::~RenderLayer):
3278         (WebCore::RenderLayer::setHasVisibleContent):
3279         (WebCore::RenderLayer::enclosingCompositingLayer):
3280         (WebCore::RenderLayer::addChild):
3281         (WebCore::RenderLayer::removeChild):
3282         (WebCore::RenderLayer::paintLayer):
3283         (WebCore::RenderLayer::hitTestLayer):
3284         (WebCore::RenderLayer::dirtyNormalFlowList):
3285         (WebCore::RenderLayer::updateNormalFlowList):
3286         (WebCore::RenderLayer::collectLayers):
3287         (WebCore::RenderLayer::updateLayerListsIfNeeded):
3288         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
3289         (WebCore::RenderLayer::styleChanged):
3290         * rendering/RenderLayer.h:
3291         (WebCore::RenderLayer::isNormalFlowOnly):
3292         (WebCore::RenderLayer::normalFlowList):
3293         * rendering/RenderTreeAsText.cpp:
3294         (WebCore::writeLayers):
3295
3296 2009-02-23  David Hyatt  <hyatt@apple.com>
3297
3298         Fix the stacking order for column rules in multi-column layout.  Column rules should paint as part of the background of an element, just
3299         after all other components of the background have been painted.  This allows negative z-index children to still paint on top of the
3300         column rules (rather than ending up above the background of the box but behind the column rules).
3301
3302         Reviewed by Eric Seidel
3303
3304         Added fast/multicol/column-rules-stacking.html
3305
3306         * rendering/RenderBlock.cpp:
3307         (WebCore::RenderBlock::paintColumnRules):
3308         (WebCore::RenderBlock::paintColumnContents):
3309         (WebCore::RenderBlock::paintObject):
3310         * rendering/RenderBlock.h:
3311
3312 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3313
3314         Reviewed by David Hyatt.
3315
3316         No testcases have been added or modified since this patch should not result in
3317         a behavior change for ports that have layout tests enabled.
3318
3319         Currently, the implementation of GraphicsContext::drawLineForText amongst
3320         the various ports differ in that some of them are honoring the context's
3321         strokeStyle when drawing a text-decoration and some of them are not.
3322         For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
3323         but the Cairo implementation does and has an explicit workaround that
3324         sets the strokeStyle() temporarily.
3325
3326         This patch fixes so that all ports are consistent by explicitly making sure
3327         to set the GraphicsContext strokeStyle to SolidStroke whenever
3328         painting the text-decoration of an InlineFlowBox or InlineTextBox as these
3329         should always use a solid stroke.
3330
3331         This patch addresses these bugs:
3332         https://bugs.webkit.org/show_bug.cgi?id=19364
3333         https://bugs.webkit.org/show_bug.cgi?id=15659
3334
3335         * rendering/InlineFlowBox.cpp:
3336         (WebCore::InlineFlowBox::paintTextDecorations):
3337         * rendering/InlineTextBox.cpp:
3338         (WebCore::InlineTextBox::paintDecoration):
3339
3340 2009-02-23  Scott Violet  <sky@google.com>
3341
3342         Reviewed by Eric Seidel.
3343
3344         https://bugs.webkit.org/show_bug.cgi?id=24098
3345         Bugs in ClipboardChromium
3346
3347         Fixes the following bugs in ClipboardChromium:
3348         * It's possible for the extension to be empty, resulting in a bad file
3349           name, for example, 'foo.' or just '.'.
3350         * We weren't restricting the size of the file to MAX_PATH.
3351         * We weren't removing characters that are invalid for file system names.
3352
3353         * platform/chromium/ClipboardChromium.cpp:
3354         (WebCore::writeImageToDataObject):
3355         * platform/chromium/ClipboardChromium.h:
3356         * platform/chromium/ClipboardChromiumLinux.cpp: Added.
3357         (WebCore::ClipboardChromium::validateFileName):
3358         * platform/chromium/ClipboardChromiumMac.cpp: Added.
3359         (WebCore::ClipboardChromium::validateFileName):
3360         * platform/chromium/ClipboardChromiumWin.cpp: Added.
3361         (WebCore::isInvalidFileCharacter):
3362         (WebCore::ClipboardChromium::validateFileName):
3363
3364 2009-02-23  Thiago Macieira  <thiago.macieira@nokia.com>
3365
3366         Reviewed by Simon Hausmann.
3367
3368         Fix the Copyright notices in a few files
3369
3370         * platform/qt/RenderThemeQt.h:
3371
3372 2009-02-23  Xan Lopez  <xan@gnome.org>
3373
3374         Reviewed by Alexey Proskuryakov.
3375
3376         https://bugs.webkit.org/show_bug.cgi?id=22624
3377         [SOUP][GTK] Need API to get SoupSession from WebKit.
3378
3379         Allow to retrieve the Soup session and modify the code to take
3380         into account users changing features on it.
3381
3382         * platform/network/ResourceHandle.h:
3383         * platform/network/soup/CookieJarSoup.cpp:
3384         (WebCore::defaultCookieJar):
3385         (WebCore::setDefaultCookieJar):
3386         * platform/network/soup/CookieJarSoup.h:
3387         * platform/network/soup/ResourceHandleSoup.cpp:
3388         (WebCore::createSoupSession):
3389         (WebCore::ensureSessionIsInitialized):
3390         (WebCore::ResourceHandle::startHttp):
3391         (WebCore::ResourceHandle::cancel):
3392         (WebCore::ResourceHandle::defaultSession):
3393
3394 2009-02-23  Xan Lopez  <xan@gnome.org>
3395
3396         Reviewed by Alexey Proskuryakov.
3397
3398         https://bugs.webkit.org/show_bug.cgi?id=22624
3399         [SOUP][GTK] Need API to get SoupSession from WebKit.
3400
3401         Remove CURL support.
3402
3403         * GNUmakefile.am:
3404
3405 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3406
3407         Reviewed by Mark Rowe.
3408
3409         Test: fast/dom/empty-hash-and-search.html
3410
3411         https://bugs.webkit.org/show_bug.cgi?id=21147
3412         hash property returns incorrect value for links w/o hash
3413
3414         Make hash() and search() behavior for empty and missing parts match IE and Firefox.
3415
3416         * platform/KURL.cpp:
3417         (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
3418         (WebCore::KURL::prettyURL): Append the query with the question mark.
3419
3420         * page/Location.cpp:
3421         (WebCore::Location::search): Return an empty string if query is empty or missing.
3422         (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
3423
3424         * dom/WorkerLocation.cpp:
3425         (WebCore::WorkerLocation::search):
3426         (WebCore::WorkerLocation::hash):
3427         Match document.location fixes above.
3428
3429         * html/HTMLAnchorElement.cpp:
3430         (WebCore::HTMLAnchorElement::hash):
3431         (WebCore::HTMLAnchorElement::search):
3432         Return an empty string for empty and missing parts.
3433
3434 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3435
3436         Reviewed by Darin Adler.
3437
3438         https://bugs.webkit.org/show_bug.cgi?id=20184
3439         SELECT with no name generates invalid query string
3440
3441         Test: fast/forms/select-no-name.html
3442
3443         * html/HTMLSelectElement.cpp:
3444         (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
3445
3446 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3447
3448         Apply review comments for the previous check-in (forgot to save the file, oops).
3449
3450         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
3451
3452 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3453
3454         Reviewed by Darin Adler.
3455
3456         https://bugs.webkit.org/show_bug.cgi?id=15707
3457         Crash when manipulating document from within an iframe onload function
3458
3459         Test: fast/dom/onload-open.html
3460
3461         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
3462         the current node, because anything can happen when dispatching events.
3463
3464 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3465
3466         Reviewed by Darin Adler.
3467
3468         https://bugs.webkit.org/show_bug.cgi?id=18970
3469         Numerically named input fields cause document.forms loop problems
3470
3471         Test: fast/forms/numeric-input-name.html
3472
3473         * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
3474         latter overrides properties.
3475
3476 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3477
3478         Reviewed by Sam Weinig.
3479
3480         https://bugs.webkit.org/show_bug.cgi?id=24059
3481         Tokenizer::write() return value is never used
3482
3483         * dom/Tokenizer.h:
3484         * dom/XMLTokenizer.cpp:
3485         (WebCore::XMLTokenizer::write):
3486         * dom/XMLTokenizer.h:
3487         * html/HTMLTokenizer.cpp:
3488         (WebCore::HTMLTokenizer::write):
3489         * html/HTMLTokenizer.h:
3490         * loader/FTPDirectoryDocument.cpp:
3491         (WebCore::FTPDirectoryTokenizer::write):
3492         * loader/ImageDocument.cpp:
3493         (WebCore::ImageTokenizer::write):
3494         * loader/MediaDocument.cpp:
3495         (WebCore::MediaTokenizer::write):
3496         * loader/PluginDocument.cpp:
3497         (WebCore::PluginTokenizer::write):
3498         * loader/TextDocument.cpp:
3499         (WebCore::TextTokenizer::write):
3500         Made write() return void, not bool.
3501
3502 2009-02-20  Geoffrey Garen  <ggaren@apple.com>
3503
3504         Reviewed by Sam Weinig.
3505
3506         Updated for JavaScriptCore changes to timeout checking.
3507
3508         * bindings/js/JSCustomPositionCallback.cpp:
3509         (WebCore::JSCustomPositionCallback::handleEvent):
3510         * bindings/js/JSCustomPositionErrorCallback.cpp:
3511         (WebCore::JSCustomPositionErrorCallback::handleEvent):
3512         * bindings/js/JSCustomSQLStatementCallback.cpp:
3513         (WebCore::JSCustomSQLStatementCallback::handleEvent):
3514         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3515         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
3516         * bindings/js/JSCustomSQLTransactionCallback.cpp:
3517         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
3518         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
3519         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
3520         * bindings/js/JSCustomVoidCallback.cpp:
3521         (WebCore::JSCustomVoidCallback::handleEvent):
3522         * bindings/js/JSCustomXPathNSResolver.cpp:
3523         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
3524         * bindings/js/JSDOMWindowBase.cpp:
3525         (WebCore::JSDOMWindowBase::JSDOMWindowBase):
3526         (WebCore::JSDOMWindowBase::commonJSGlobalData):
3527         * bindings/js/JSEventListener.cpp:
3528         (WebCore::JSAbstractEventListener::handleEvent):
3529         * bindings/js/ScheduledAction.cpp:
3530         (WebCore::ScheduledAction::executeFunctionInContext):
3531         * bindings/js/ScriptController.cpp:
3532         (WebCore::ScriptController::evaluate):
3533         * bindings/js/WorkerScriptController.cpp:
3534         (WebCore::WorkerScriptController::evaluate):
3535         (WebCore::WorkerScriptController::forbidExecution):
3536         * bindings/objc/WebScriptObject.mm:
3537         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3538         (-[WebScriptObject evaluateWebScript:]):
3539         * bridge/NP_jsobject.cpp:
3540         (_NPN_InvokeDefault):
3541         (_NPN_Invoke):
3542         (_NPN_Evaluate):
3543         (_NPN_Construct):
3544         * bridge/jni/jni_jsobject.mm:
3545         (JavaJSObject::call):
3546         (JavaJSObject::eval):
3547
3548 2009-02-21  Hironori Bono  <hbono@chromium.org>
3549
3550         Reviewed by Alexey Proskuryakov.
3551
3552         https://bugs.webkit.org/show_bug.cgi?id=23786
3553         [Chromium] line-break characters in a complex text are treated as zero-width spaces
3554
3555         This change prevents the UniscribeHelper class from treating the line-break characters
3556         as whitespaces.
3557
3558         Tests: fast/text/international/bidi-linebreak-001.html
3559                fast/text/international/bidi-linebreak-002.html
3560                fast/text/international/bidi-linebreak-003.html
3561
3562         * platform/graphics/chromium/UniscribeHelper.cpp:
3563         (WebCore::UniscribeHelper::adjustSpaceAdvances):
3564         Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in
3565         the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces,
3566         so does when Chromium renders a simple text.
3567
3568 2009-02-20  Julien Chaffraix  <jchaffraix@webkit.org>
3569
3570         Reviewed by Alexey Proskuryakov.
3571
3572         Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
3573
3574         Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
3575         or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
3576         unneeded.
3577
3578         It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
3579         enables us to use some generated QualifiedName.
3580
3581         * bindings/js/JSOptionConstructor.cpp:
3582         (WebCore::constructHTMLOptionElement):
3583         * dom/Document.cpp:
3584         (WebCore::Document::setTitle):
3585         * dom/XMLTokenizer.cpp:
3586         (WebCore::createXHTMLParserErrorHeader):
3587         (WebCore::XMLTokenizer::insertErrorMessageBlock):
3588         * editing/CompositeEditCommand.cpp:
3589         (WebCore::createBlockPlaceholderElement):
3590         * editing/htmlediting.cpp:
3591         (WebCore::createTabSpanElement):
3592         * html/HTMLSelectElement.cpp:
3593         (WebCore::HTMLSelectElement::setLength):
3594         * loader/FTPDirectoryDocument.cpp:
3595         (WebCore::FTPDirectoryTokenizer::appendEntry):
3596         (WebCore::FTPDirectoryTokenizer::createTDForFilename):
3597         (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
3598         (WebCore::FTPDirectoryTokenizer::createBasicDocument):
3599         * loader/ImageDocument.cpp:
3600         (WebCore::ImageDocument::createDocumentStructure):
3601         * loader/MediaDocument.cpp:
3602         (WebCore::MediaTokenizer::createDocumentStructure):
3603         * loader/PluginDocument.cpp:
3604         (WebCore::PluginTokenizer::createDocumentStructure):
3605         * loader/TextDocument.cpp:
3606         (WebCore::TextTokenizer::write):
3607         * page/Frame.cpp:
3608         (WebCore::Frame::selectionComputedStyle):
3609         (WebCore::Frame::styleForSelectionStart):
3610         Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
3611
3612         * xml/XPathFunctions.cpp: