9ff94de629313f1ab67d585effebe46cfb38026b
[WebKit-https.git] / WebCore / ChangeLog
1 2009-12-08  Steve Block  <steveblock@google.com>
2
3         Reviewed by Adam Barth.
4
5         [Android] Adds Makefiles for Android port.
6         https://bugs.webkit.org/show_bug.cgi?id=31325
7
8         Build system change only. No tests possible.
9
10         * Android.derived.jscbindings.mk: Added.
11         * Android.derived.mk: Added.
12         * Android.jscbindings.mk: Added.
13         * Android.mk: Added.
14         * WebCorePrefix.h: Modified. Sets up some flags and adds a header required for building on Android.
15
16 2009-12-08  Christian Dywan  <christian@twotoasts.de>
17
18         Reviewed by Xan Lopez.
19
20         * platform/network/soup/DNSSoup.cpp:
21         (WebCore::prefetchDNS): Conditionalize prefetching on
22         the libSoup version.
23
24 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
25
26         Rubber-stamped by Maciej Stachowiak.
27
28         Turn on (SVG) Filters for Win.
29         https://bugs.webkit.org/show_bug.cgi?id=32224
30
31         * WebCore.vcproj/WebCoreCommon.vsprops:
32         * WebCore.vcproj/build-generated-files.sh:
33         * bindings/scripts/CodeGeneratorCOM.pm: Touch file to assure a world rebuild. Hopefully.
34
35 2009-12-08  Carol Szabo  <carol.szabo@nokia.com>
36
37         Reviewed by Darin Adler.
38
39         CSS Counter Nesting still does not work according to the spec.
40         https://bugs.webkit.org/show_bug.cgi?id=31723
41
42         Test: fast/css/counters/nesting.html
43
44         * rendering/RenderCounter.cpp:
45         (WebCore::findPlaceForCounter):
46         Replaced the faulty counter insertion algorithm with one that works.
47
48 2009-12-08  John Sullivan  <sullivan@apple.com>
49
50         Add isAutofilled getter to match existing setter.
51
52         Reviewed by Ada Chan.
53
54         * bindings/objc/DOMHTML.mm:
55         (-[DOMHTMLInputElement _isAutofilled]):
56         Implemented new cover function.
57         
58         * bindings/objc/DOMPrivate.h:
59         Declared new cover function.
60
61 2009-12-08  Dominik Röttsches  <dominik.roettsches@access-company.com>
62
63         Reviewed by Gustavo Noronha Silva.
64
65         [Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
66         https://bugs.webkit.org/show_bug.cgi?id=31469
67
68         Added a TextBreakIterator implementation based on GLib and pango,
69         which allows compiling WebCore without ICU.
70
71         * GNUmakefile.am:
72         * platform/text/gtk/TextBreakIteratorGtk.cpp: Added.
73         (WebCore::):
74         (WebCore::setUpIterator):
75         (WebCore::characterBreakIterator):
76         (WebCore::cursorMovementIterator):
77         (WebCore::wordBreakIterator):
78         (WebCore::lineBreakIterator):
79         (WebCore::sentenceBreakIterator):
80         (WebCore::textBreakFirst):
81         (WebCore::textBreakLast):
82         (WebCore::textBreakNext):
83         (WebCore::textBreakPrevious):
84         (WebCore::textBreakPreceding):
85         (WebCore::textBreakFollowing):
86         (WebCore::textBreakCurrent):
87         (WebCore::isTextBreak):
88
89 2009-12-08  Alexander Pavlov  <apavlov@chromium.org>
90
91         Reviewed by Pavel Feldman.
92
93         Change the way cookies are retrieved in the WebInspector frontend.
94
95         Moved the cookie filtering from the native code into the frontend so that
96         all cookies can be retrieved regardless of the associated domain
97         (required for certain audits to run.)
98         https://bugs.webkit.org/show_bug.cgi?id=32160
99
100         Test: inspector/cookie-resource-match.html
101
102         * inspector/InspectorBackend.cpp:
103         (WebCore::InspectorBackend::getCookies):
104         * inspector/InspectorBackend.h:
105         * inspector/InspectorBackend.idl:
106         * inspector/InspectorController.cpp:
107         (WebCore::InspectorController::getCookies):
108         * inspector/InspectorController.h:
109         * inspector/front-end/CookieItemsView.js:
110         (WebInspector.CookieItemsView.prototype.update.callback):
111         (WebInspector.CookieItemsView.prototype.update):
112         (WebInspector.CookieItemsView.prototype._cookiesForDomain):
113         * inspector/front-end/DOMAgent.js:
114         (WebInspector.Cookies.getCookiesAsync):
115         (WebInspector.Cookies.cookieMatchesResourceURL):
116         (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
117         * inspector/front-end/Resource.js:
118         (WebInspector.Resource):
119         (WebInspector.Resource.prototype.get documentURL):
120         (WebInspector.Resource.prototype.set documentURL):
121         * inspector/front-end/inspector.js:
122         (WebInspector.addResource):
123
124 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
125
126         Not reviewed. Touch svgtags.in, in order to force SVGNames.* regeneration. Praying for gtk bot to be fixed :-)
127
128         * svg/svgtags.in:
129
130 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
131
132         Not reviewed. Trying to force a rebuild on the Gtk slave. If that doesn't work, someone must force a rebuild from scratch.
133
134         * bindings/scripts/CodeGeneratorJS.pm:
135
136 2009-12-06  Pavel Feldman  <pfeldman@chromium.org>
137
138         Reviewed by Timothy Hatcher.
139
140         Web Inspector: provide custom context menu in the front-end window.
141
142         https://bugs.webkit.org/show_bug.cgi?id=32200
143
144         * English.lproj/localizedStrings.js:
145         * GNUmakefile.am:
146         * WebCore.gypi:
147         * WebCore.pro:
148         * WebCore.vcproj/WebCore.vcproj:
149         * WebCore.xcodeproj/project.pbxproj:
150         * bindings/js/JSInspectorFrontendHostCustom.cpp:
151         (WebCore::JSInspectorFrontendHost::showContextMenu):
152         * inspector/InspectorFrontend.cpp:
153         (WebCore::InspectorFrontend::contextMenuItemSelected):
154         (WebCore::InspectorFrontend::contextMenuCleared):
155         * inspector/InspectorFrontend.h:
156         * inspector/InspectorFrontendHost.cpp:
157         (WebCore::InspectorFrontendHost::InspectorFrontendHost):
158         (WebCore::InspectorFrontendHost::~InspectorFrontendHost):
159         (WebCore::InspectorFrontendHost::showContextMenu):
160         (WebCore::InspectorFrontendHost::contextMenuItemSelected):
161         (WebCore::InspectorFrontendHost::contextMenuCleared):
162         * inspector/InspectorFrontendHost.h:
163         (WebCore::InspectorFrontendHost::MenuSelectionHandler::create):
164         (WebCore::InspectorFrontendHost::MenuSelectionHandler::~MenuSelectionHandler):
165         (WebCore::InspectorFrontendHost::MenuSelectionHandler::disconnect):
166         (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuItemSelected):
167         (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuCleared):
168         (WebCore::InspectorFrontendHost::MenuSelectionHandler::MenuSelectionHandler):
169         * inspector/InspectorFrontendHost.idl:
170         * inspector/front-end/ContextMenu.js: Added.
171         * inspector/front-end/WebKit.qrc:
172         * inspector/front-end/inspector.html:
173         * inspector/front-end/inspector.js:
174         (WebInspector.loaded):
175         (WebInspector.documentContextMenu):
176         * page/ContextMenuController.cpp:
177         (WebCore::ContextMenuController::ContextMenuController):
178         (WebCore::ContextMenuController::clearContextMenu):
179         (WebCore::ContextMenuController::handleContextMenuEvent):
180         (WebCore::ContextMenuController::showContextMenu):
181         (WebCore::ContextMenuController::createContextMenu):
182         (WebCore::ContextMenuController::contextMenuItemSelected):
183         * page/ContextMenuController.h:
184         * page/ContextMenuSelectionHandler.h: Added.
185         (WebCore::ContextMenuSelectionHandler::ContextMenuSelectionHandler):
186         (WebCore::ContextMenuSelectionHandler::~ContextMenuSelectionHandler):
187         * platform/ContextMenu.cpp:
188         (WebCore::ContextMenu::checkOrEnableIfNeeded):
189         * platform/ContextMenuItem.h:
190
191 2009-12-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
192
193         Rubber-stamped by Kenneth Rohde Christiansen.
194
195         [Qt] Build fix of duplicated platform/graphics/filters/FEGaussianBlur.cpp in WebCore.pro after enabled svg filters.
196
197         No new tests needed.
198         * WebCore.pro:
199
200 2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>
201
202         Reviewed by Darin Adler.
203
204         Add a function to show render tree for debugging
205         https://bugs.webkit.org/show_bug.cgi?id=31288
206
207         No new tests because this just adds a function for debugging.
208
209         * rendering/RenderObject.cpp:
210         (WebCore::RenderObject::showRenderObject):
211         (WebCore::RenderObject::showRenderTreeAndMark):
212         (showRenderTree):
213         * rendering/RenderObject.h:
214
215 2009-12-07  Victor Wang  <victorw@chromium.org>
216
217         Reviewed by Dimitri Glazkov.
218
219         Implement NamedPropertyEnumerator and IndexedPropertyEnumerator for
220         V8 NPObject. This should make the object enumerable and fix the
221         enumeration issue in layout test plugins/netscape-enumerate.html.
222
223         Also fix some existing style issues per webkit style guidelines.
224
225         https://bugs.webkit.org/show_bug.cgi?id=32254
226
227         Test: plugins/netscape-enumerate.html
228
229         * bindings/v8/V8NPObject.cpp:
230         (npObjectInvokeImpl):
231         (npObjectInvokeDefaultHandler):
232         (npObjectGetProperty):
233         (npObjectPropertyEnumerator):
234         (npObjectNamedPropertyEnumerator):
235         (npObjectIndexedPropertyEnumerator):
236         (createV8ObjectForNPObject):
237
238 2009-12-07  Fumitoshi Ukai  <ukai@chromium.org>
239
240         Reviewed by Alexey Proskuryakov.
241
242         Fragments now make WebSocket URL parsing fail.
243         https://bugs.webkit.org/show_bug.cgi?id=32144
244
245         * websockets/WebSocket.cpp:
246         (WebCore::WebSocket::connect):
247
248 2009-12-07  Fumitoshi Ukai  <ukai@chromium.org>
249
250         Reviewed by Darin Adler.
251
252         Fix wrong length parsing in WebSocket.
253         https://bugs.webkit.org/show_bug.cgi?id=32203
254
255         * websockets/WebSocketChannel.cpp:
256         (WebCore::WebSocketChannel::didReceiveData):
257
258 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
259
260         Rubber-stamped by Maciej Stachowiak.
261
262         Turn on (SVG) Filters for Qt.
263         https://bugs.webkit.org/show_bug.cgi?id=32224
264
265         * WebCore.pro:
266
267 2009-12-07  Evan Martin  <evan@chromium.org>
268
269         Reviewed by Eric Seidel.
270
271         Chromium: theme scrollbars to match GTK theme.
272         Add functions to RenderThemeChromiumLinux to change the scrollbar
273         color.
274
275         Since the change is to the Chromium WebKit API layer, testing will
276         be in Chromium's test shell.
277         http://bugs.webkit.org/show_bug.cgi?id=32048
278
279         Patch from Markus Gutschke <markus@chromium.org>.
280
281         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
282         (WebCore::saturateAndBrighten):
283         (WebCore::outlineColor):
284         (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
285         (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
286         * rendering/RenderThemeChromiumLinux.cpp:
287         (WebCore::RenderThemeChromiumLinux::setScrollbarColors):
288         * rendering/RenderThemeChromiumLinux.h:
289         (WebCore::RenderThemeChromiumLinux::thumbInactiveColor):
290         (WebCore::RenderThemeChromiumLinux::thumbActiveColor):
291         (WebCore::RenderThemeChromiumLinux::trackColor):
292
293 2009-12-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
294
295         Reviewed by Xan Lopez.
296
297         [GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
298         https://bugs.webkit.org/show_bug.cgi?id=32247
299
300         Allow creating a ResourceResponse from a SoupMessage.
301
302         Covered by API test.
303
304         * platform/network/soup/ResourceResponse.h:
305         (WebCore::ResourceResponse::ResourceResponse):
306         * platform/network/soup/ResourceResponseSoup.cpp:
307         (WebCore::ResourceResponse::updateFromSoupMessage):
308
309 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
310
311         Not reviewed. Reverting problematic patch, causing errors.
312
313         Revert r51789 (Avoid zero division during SVGPaintServerPattern::setup()). Crashes on all Windows slaves.
314         Reopen bug https://bugs.webkit.org/show_bug.cgi?id=29912.
315
316         * svg/graphics/SVGPaintServerPattern.cpp:
317         (WebCore::SVGPaintServerPattern::setup):
318
319 2009-12-07  Kent Tamura  <tkent@chromium.org>
320
321         Reviewed by Darin Adler.
322
323         Add support for HTMLInputElement::stepUp() and stepDown() for
324         type=number and type=range.
325         https://bugs.webkit.org/show_bug.cgi?id=27451
326
327         Our implementation of stepUp() and stepDown() rounds the resultant
328         value to conform to the step value.
329         Change the number-string conversion method for RenderSlider to be
330         consistent with type=number.
331
332         Tests: fast/forms/input-step-number.html
333                fast/forms/input-step-range.html
334                fast/forms/input-step-unsupported.html
335
336         * html/HTMLInputElement.cpp:
337         (WebCore::HTMLInputElement::rangeUnderflow): Unify the code for NUMBER and RANGE.
338         (WebCore::HTMLInputElement::rangeOverflow): Unify the code for NUMBER and RANGE.
339         (WebCore::HTMLInputElement::minimum): Renamed from rangeMinimum(), and support for NUMBER.
340         (WebCore::HTMLInputElement::maximum): Renamed from rangeMaximum(), and support for NUMBER.
341         (WebCore::HTMLInputElement::stepBase):
342         (WebCore::HTMLInputElement::stepMismatch): Use stepBase().
343         (WebCore::HTMLInputElement::applyStepForNumberOrRange):
344         (WebCore::HTMLInputElement::stepUp):
345         (WebCore::HTMLInputElement::stepDown):
346         (WebCore::HTMLInputElement::formStringFromDouble):
347         * html/HTMLInputElement.h:
348         (WebCore::HTMLInputElement::stepUp):
349         (WebCore::HTMLInputElement::stepDown):
350         * html/HTMLInputElement.idl: Add stepUp() and stepDown().
351         * rendering/RenderSlider.cpp:
352         (WebCore::SliderRange::SliderRange): Sync with rangeMinimum()/rangeMaximum() renaming.
353         (WebCore::RenderSlider::updateFromElement): Use formStringFromDouble().
354         (WebCore::RenderSlider::setValueForPosition): Use formStringFromDouble().
355
356 2009-12-07  Albert J. Wong  <ajwong@chromium.org>
357
358         Not reviewed: Chromium build fix try 2 (dumb error).
359
360         * bindings/v8/ScriptValue.h:
361         (WebCore::ScriptValue::getString):
362
363 2009-12-07  Albert J. Wong  <ajwong@chromium.org>
364
365         Not reviewed: Chromium build fix.
366
367         Fix Chromium build break caused by an added dependency from
368         ScriptControllerBase to JSDOMWindowShell, and an API change in
369         ScriptValue.
370
371         * bindings/ScriptControllerBase.cpp:
372         (WebCore::ScriptController::executeIfJavaScriptURL):
373         * bindings/v8/ScriptValue.h:
374         (WebCore::ScriptValue::getString):
375
376 2009-12-07  Enrica Casucci  <enrica@apple.com>
377
378         Reviewed by Darin Adler.
379
380         REGRESSION(4.0.4-42a12): Indent does not work for twice modified with background text in gmail.
381         <rdar://problem/7442387>
382         https://bugs.webkit.org/show_bug.cgi?id=32233
383         
384         Fixes problem in re-creating the correct hierarchy under the new block.
385         Added extensive testing to cover all the cases.
386
387         Test: editing/execCommand/indent-with-style2.html
388
389         * editing/CompositeEditCommand.cpp:
390         (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
391
392 2009-12-07  Dmitry Titov  <dimich@chromium.org>
393
394         Rubber-stamped by Darin Adler.
395
396         Remove ENABLE_SHARED_SCRIPT flags
397         https://bugs.webkit.org/show_bug.cgi?id=32245
398         This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
399
400         * Configurations/FeatureDefines.xcconfig:
401         * GNUmakefile.am:
402         * WebCore.pro:
403
404 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
405
406         Not reviewed. Force JS binding regeneration, eventually fixing the broken tests on the bots.
407
408         * bindings/scripts/CodeGeneratorJS.pm:
409
410 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
411
412         Not reviewed. Try to fix mac builds by touching svgtags.in - I only tried from-scratch builds.
413
414         * svg/svgtags.in:
415
416 2009-12-07  Gavin Barraclough  <barraclough@apple.com>
417
418         Reviewed by Oliver Hunt.
419
420         https://bugs.webkit.org/show_bug.cgi?id=32184
421         Handle out-of-memory conditions with JSC Ropes with a JS exception, rather than crashing.
422         Switch from using fastMalloc to tryFastMalloc, pass an ExecState to record the exception on.
423
424         * bindings/ScriptControllerBase.cpp:
425         (WebCore::ScriptController::executeIfJavaScriptURL):
426         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
427         (WebCore::toHTMLCanvasStyle):
428         (WebCore::JSCanvasRenderingContext2D::setFillColor):
429         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
430         (WebCore::JSCanvasRenderingContext2D::setShadow):
431         * bindings/js/ScriptCallStack.cpp:
432         (WebCore::ScriptCallStack::ScriptCallStack):
433         (WebCore::ScriptCallStack::initialize):
434         * bindings/js/ScriptValue.cpp:
435         (WebCore::ScriptValue::getString):
436         * bindings/js/ScriptValue.h:
437         * bindings/js/SerializedScriptValue.cpp:
438         (WebCore::SerializingTreeWalker::convertIfTerminal):
439         * bindings/objc/WebScriptObject.mm:
440         (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
441         * page/Console.cpp:
442         (WebCore::Console::addMessage):
443
444 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
445
446         Reviewed by Holger Hans Peter Freyther.
447
448         Turn on (SVG) Filters support, by default.
449         https://bugs.webkit.org/show_bug.cgi?id=32224
450
451         Only enable filters on mac for now, skipped all affected tests on the other platforms.
452         Will enable them one after another, to minimize breakage.
453
454         * Configurations/FeatureDefines.xcconfig: Enable FILTERS build flag.
455
456 2009-12-07  Kent Tamura  <tkent@chromium.org>
457
458         Reviewed by Darin Adler.
459
460         Fix a bug that KURL rejects a host name which has an IPv4 address
461         inside an IPv6 form like [::127.0.0.1].
462         https://bugs.webkit.org/show_bug.cgi?id=29913
463
464         * platform/KURL.cpp:
465         (WebCore::characterClassTable): Add IPv6Char to '.'.
466
467 2009-12-07  Brady Eidson  <beidson@apple.com>
468
469         Reviewed by Sam Weinig.
470
471         <rdar://problem/7443417> - Closing a window opened with "New windows open with: Same Page" results in crash in ::~HistoryItem
472
473         The HistoryItem copy constructor has one very specific use case - to support the feature of a WebView copying another WebView's
474         BackForwardList.  That constructor wasn't initializing its m_document pointer, leading to this crash in the destructor.
475
476         * history/HistoryItem.cpp:
477         (WebCore::HistoryItem::~HistoryItem): Change the setDocument(0) to an ASSERT that the document is already 0. A HistoryItem cannot
478           outlive its Document and Documents will always clear the back-pointer in their ::detach() method.
479         (WebCore::HistoryItem::HistoryItem): Missed the m_document initializer in the copy constructor. Also remove an invalid assertion
480           about the original items m_cachedPage object (which is irrelevant to the copy).
481
482 2009-12-07  Dmitry Titov  <dimich@chromium.org>
483
484         Reviewed by Darin Adler.
485
486         Remove partial SharedScript implementation.
487         https://bugs.webkit.org/show_bug.cgi?id=32237
488         The patch was obtained by running "git revert" command and then un-reverting WebCore/ChangeLog.
489
490         * DerivedSources.make:
491         * SharedScript/SharedScriptContext.cpp: Removed.
492         * SharedScript/SharedScriptContext.h: Removed.
493         * SharedScript/SharedScriptContext.idl: Removed.
494         * SharedScript/SharedScriptController.h: Removed.
495         * SharedScript/WebKitSharedScript.cpp: Removed.
496         * SharedScript/WebKitSharedScript.h: Removed.
497         * SharedScript/WebKitSharedScript.idl: Removed.
498         * SharedScript/WebKitSharedScriptRepository.cpp: Removed.
499         * SharedScript/WebKitSharedScriptRepository.h: Removed.
500         * WebCore.vcproj/WebCore.vcproj:
501         * WebCore.xcodeproj/project.pbxproj:
502         * dom/Document.cpp:
503         (WebCore::Document::detach):
504         * dom/EventTarget.cpp:
505         * dom/EventTarget.h:
506         * dom/ScriptExecutionContext.h:
507
508 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
509
510         Reviewed by Nikolas Zimmermann.
511
512         https://bugs.webkit.org/show_bug.cgi?id=32226
513         Random crashes in WebSocket tests on Leopard Debug builbot
514
515         * platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::close):
516         Make sure the object still exists when setting m_state.
517
518 2009-12-07  Shiki Okasaka  <shiki@google.com>
519
520         Reviewed by Dirk Schulze.
521
522         Avoid zero division during SVGPaintServerPattern::setup()
523         https://bugs.webkit.org/show_bug.cgi?id=29912
524
525         Fix zero division bugs in SVGPaintServerPattern::setup() that occurred
526         if the tile of a pattern was bigger than the pattern and the pattern
527         size was < 0.5, and if the attribute overflow was set to visible.
528
529         Test: svg/custom/small-pattern.html
530
531         * svg/graphics/SVGPaintServerPattern.cpp:
532         (WebCore::SVGPaintServerPattern::setup):
533
534 2009-12-07  Kenneth Russell  <kbr@google.com>
535
536         Reviewed by Dimitri Glazkov.
537
538         [v8] WebCore::WebGLArrayBufferInternal::byteLengthAttrGetter NULL pointer
539         https://bugs.webkit.org/show_bug.cgi?id=31889
540
541         Fixed bug in handling of zero-argument constructor call.
542
543         Test: fast/canvas/webgl/bug-31889.html
544
545         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
546         (WebCore::CALLBACK_FUNC_DECL):
547
548 2009-12-07  Gyuyoung Kim  <gyuyoung@gmail.com>
549
550         Reviewed by Eric Seidel.
551
552         https://bugs.webkit.org/show_bug.cgi?id=32024
553         [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER
554
555         Fix build errors when javascript-debugger is disabled on GTK
556
557         * GNUmakefile.am:
558
559 2009-12-07  Dan Bernstein  <mitz@apple.com>
560
561         Reviewed by Darin Adler.
562
563         Fixed <rdar://problem/7437820> Weird selection artifacts
564
565         Tests: fast/repaint/block-selection-gap-stale-cache-2.html
566                fast/repaint/block-selection-gap-stale-cache.html
567
568         Instead of caching the block selection gaps’ bounds in the RenderView at setSelection()
569         time, cache them in each RenderLayer at paint time. This prevents the cache from getting
570         stale due to layout changes and overflow scrolling.
571
572         * rendering/RenderBlock.cpp:
573         (WebCore::RenderBlock::selectionGapRectsForRepaint): Account for overflow scroll.
574         (WebCore::RenderBlock::paintSelection): Update the enclosing layer’s selection gaps bounds.
575         * rendering/RenderLayer.cpp:
576         (WebCore::RenderLayer::addBlockSelectionGapsBounds): Added. Updates the selection gaps
577         bounds to include the given rect.
578         (WebCore::RenderLayer::clearBlockSelectionGapsBounds): Added. Recursively clears the cached
579         selection gaps bounds.
580         (WebCore::RenderLayer::repaintBlockSelectionGaps): Added. Recursively invalidates the
581         selection gaps bounds.
582         * rendering/RenderLayer.h:
583         * rendering/RenderView.cpp:
584         (WebCore::RenderView::setSelection): Clear the layer-level selection gaps bounds instead
585         of the view-level cache.
586         (WebCore::RenderView::clearSelection): Changed to call repaintBlockSelectionGaps().
587         * rendering/RenderView.h:
588
589 2009-12-07  Philippe Normand  <pnormand@igalia.com>
590
591         Reviewed by Gustavo Noronha.
592
593         Fixed whitelist comment and removed useless (tags, sdp) mimetypes
594         from it. Also, GStreamer doesn't handle directly SMIL.
595
596         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
597         (WebCore::mimeTypeCache):
598
599 2009-12-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
600
601         Reviewed by Xan Lopez.
602
603         https://bugs.webkit.org/show_bug.cgi?id=25415
604         [GTK][ATK] Please implement support for get_text_at_offset
605
606         Eliminate the segfaults which occur when accessing the text interface now
607         implemented by text controls.
608
609         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
610         (getPangoLayoutForAtk):
611
612 2009-12-07  Gustavo Noronha Silva  <gns@gnome.org>
613
614         Reviewed by Xan Lopez.
615
616         Turn the MediaPlayer supported types blacklist into a whitelist
617
618         [GTK] REGRESSION: webkit thinks it can render PDFs
619         https://bugs.webkit.org/show_bug.cgi?id=32183
620
621         Covered by API test.
622
623         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
624         (WebCore::mimeTypeCache):
625
626 2009-12-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
627
628         Reviewed by Xan Lopez.
629
630         https://bugs.webkit.org/show_bug.cgi?id=25524
631         [Gtk] Expose the title attribute to assistive technologies
632
633         Expose 'alt' attribute from images as accessible name.
634         Expose the 'title' core HTML attribute as accessible description.
635         This is a modified version of the original fix submitted by Mario Sanchez Prada,
636         adjusted so that it doesn't impact other platforms.
637
638         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
639         (webkit_accessible_get_name):
640         (webkit_accessible_get_description):
641
642 2009-12-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
643
644         Reviewed by Simon Hausmann.
645
646         [Qt] Fix support for generic font families
647
648         By not propagating the resolved font family in FontCacheQt and
649         only concidering the font description we ended up passing the
650         generic font families to Qt directly. Since most systems don't
651         have a mapping for these font families we ended up using the
652         default font in most cases.
653
654         * platform/graphics/qt/FontCacheQt.cpp:
655         * platform/graphics/qt/FontPlatformData.h:
656         * platform/graphics/qt/FontPlatformDataQt.cpp:
657
658 2009-12-06  Oliver Hunt  <oliver@apple.com>
659
660         Reviewed by Maciej Stachowiak.
661
662         Object.getOwnPropertyDescriptor() allows cross-frame access
663         https://bugs.webkit.org/show_bug.cgi?id=32119
664
665         Make all implementations of getOwnPropertyDescriptor that have
666         cross domain restrictions simply fail immediately on cross domain
667         access, rather than trying to mimic the behaviour of normal
668         property access.
669
670         Test: http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html
671
672         * bindings/js/JSDOMWindowCustom.cpp:
673         (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
674         * bindings/js/JSHistoryCustom.cpp:
675         (WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
676         * bindings/js/JSLocationCustom.cpp:
677         (WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
678         * bindings/scripts/CodeGeneratorJS.pm:
679
680 2009-12-07  Steve Block  <steveblock@google.com>
681
682         Reviewed by Adam Barth.
683
684         Moves JSC-specific functions from jni_utility and moves them to new jsc/jni_utility_private files.
685         https://bugs.webkit.org/show_bug.cgi?id=32157
686
687         Build fix only, no new tests.
688
689         * WebCore.xcodeproj/project.pbxproj: Modified. Add jni_utility_private.[cpp|h].
690         * bridge/jni/jni_instance.cpp: Modified. Include jni_utility_private.h for JSC.
691         * bridge/jni/jni_jsobject.mm: Modified. Include jni_utility_private.h for JSC.
692         * bridge/jni/jni_objc.mm: Modified. Include jni_utility_private.h for JSC.
693         * bridge/jni/jni_runtime.cpp: Modified. Include jni_utility_private.h for JSC.
694         * bridge/jni/jni_utility.cpp: Modified. Removed convertValueToJValue and convertArrayInstanceToJavaArray.
695         * bridge/jni/jni_utility.h: Modified. Removed convertValueToJValue and dispatchJNICall.
696         * bridge/jni/jsc: Added.
697         * bridge/jni/jsc/jni_utility_private.cpp: Added.
698         (JSC::Bindings::convertArrayInstanceToJavaArray):
699         (JSC::Bindings::convertValueToJValue):
700         * bridge/jni/jsc/jni_utility_private.h: Added. Header for convertValueToJValue and dispatchJNICall.
701         * platform/android/TemporaryLinkStubs.cpp: Modified. Include jni_utility_private.h for JSC.
702
703 2009-12-06  Oliver Hunt  <oliver@apple.com>
704
705         Reviewed by Maciej Stachowiak.
706
707         texImage2D pixel junk for transparency
708         https://bugs.webkit.org/show_bug.cgi?id=32188
709
710         Use kCGBlendModeCopy when drawing an image to the intermediate context
711         used to create a GL texture.
712
713         No test as we don't currently have any mechanism to retrieve pixel data
714         from the webgl context.
715
716         * platform/graphics/mac/GraphicsContext3DMac.cpp:
717         (WebCore::imageToTexture):
718
719 2009-12-03  Philippe Normand  <pnormand@igalia.com>
720
721         Reviewed by Gustavo Noronha.
722
723         Advertize audio/ogg correctly and refactored mime-type cache
724         building.
725
726         [GTK] Recognize oga as audio/ogg
727         https://bugs.webkit.org/show_bug.cgi?id=31990
728
729         Test: media/media-can-play-ogg.html
730
731         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
732         (WebCore::mimeTypeCache):
733
734 2009-12-05  Alexey Proskuryakov  <ap@apple.com>
735
736         Reviewed by Eric Seidel.
737
738         https://bugs.webkit.org/show_bug.cgi?id=32175
739         REGRESSION: websocket/tests/url-parsing.html is crashing on Leopard Bot
740
741         * platform/network/cf/SocketStreamHandleCFNet.cpp:
742         (WebCore::SocketStreamHandle::readStreamCallback): Call platformClose() to unschedule both
743         streams, guaranteeing that there will be no callbacks after SocketStreamHandle is destroyed.
744         (WebCore::SocketStreamHandle::writeStreamCallback): Edited a comment a bit.
745
746 2009-12-05  Adam Langley  <agl@google.com>
747
748         Reviewed by Adam Barth.
749
750         Check that a CSS format() argument is of a valid type.
751
752         https://bugs.webkit.org/show_bug.cgi?id=31815
753         http://code.google.com/p/chromium/issues/detail?id=28582
754
755         Test: fast/css/url-format-non-string.html
756
757         * css/CSSParser.cpp:
758         (WebCore::CSSParser::parseFontFaceSrc):
759
760 2009-12-04  Adam Langley  <agl@google.com>
761
762         Reviewed by Eric Seidel.
763
764         Chromium: make rounded borders heavier.
765
766         Skia draws its rounded corners differently from the other ports.
767         Whereas they have anti-aliased clipping regions, Skia only has 1-bit
768         regions. (Which is technically more correct, but somewhat unhelpful
769         for us.) Instead, with Skia we use a layer and collect all the
770         clipping paths in effect. When the state is popped, we paint
771         transparency outside the clipping paths and merge the layer down.
772
773         This appears to cause rounded borders to look a little thin, which is
774         addressed in this patch.
775
776         This is well covered by existing tests but will require new baselines
777         in the Chromium tree.
778
779         https://bugs.webkit.org/show_bug.cgi?id=31778
780
781         * platform/graphics/skia/GraphicsContextSkia.cpp:
782         (WebCore::GraphicsContext::addInnerRoundedRectClip):
783
784 2009-12-04  Simon Fraser  <simon.fraser@apple.com>
785
786         Reviewed by Dan Bernstein.
787
788         <rdar://problem/7441571> Hardware-backed layers are skipped when printing
789         
790         When printing, set the PaintBehaviorFlattenCompositingLayers flag so that compositing layers
791         paint. This also causes 3D transforms to be flattened to 2D.
792
793         Test: printing/compositing-layer-printing.html
794
795         * page/FrameView.cpp:
796         (WebCore::FrameView::paintContents):
797
798 2009-12-04  Oliver Hunt  <oliver@apple.com>
799
800         Reviewed by Beth Dakin.
801
802         Fix up some issues in my SVGListTraits change from yesterday.
803
804         * svg/SVGListTraits.h:
805         (WebCore::):
806
807 2009-12-04  Albert J. Wong  <ajwong@chromium.org>
808
809         Not reviewed: chromium build fix.
810
811         Fix Chromium build break caused by moving of isDefaultPortForProtocol() and
812         portAllowed() into KURL.h/KURL.cpp.  Cloning code.
813
814         * platform/KURLGoogle.cpp:
815         (WebCore::isDefaultPortForProtocol):
816         (WebCore::portAllowed):
817
818 2009-12-04  Pavel Feldman  <pfeldman@chromium.org>
819
820         Reviewed by Timothy Hatcher.
821
822         Web Inspector: Remove suppress highlight when restoring selected node.
823
824         https://bugs.webkit.org/show_bug.cgi?id=32152
825
826         * inspector/front-end/ElementsPanel.js:
827         (WebInspector.ElementsPanel.prototype.setDocument.selectNode):
828         (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode):
829         (WebInspector.ElementsPanel.prototype.setDocument):
830
831 2009-12-04  Dirk Schulze  <krit@webkit.org>
832
833         Reviewed by Nikolas Zimmermann.
834
835         Gradient SVG animation demonstrates tearing at animation extremes
836         https://bugs.webkit.org/show_bug.cgi?id=11929
837
838         The focalPoint of a radial gradient is temporarly substracted by
839         the centralPoint, if the focalPoint is not in the radius of the
840         gradient. This is needed to calculate a new postion of the focalPoint
841         according to the specification. But the new focalPoint needs to be
842         moved by the centralPoint after this calculation, which is not the case
843         at the moment. This patch fixes this issue. It was also introduced a
844         deviation of maximal 0.2% for Cairo to get around the fixed point numbers
845         in Cairo.
846
847         W3C-SVG-1.1/pservers-grad-13-b needed an update. The missing adjustment
848         of the new focalPoint caused wrong results for the last three tests.
849
850         Test: svg/custom/radial-gradient-with-outstanding-focalPoint.svg
851
852         * svg/SVGRadialGradientElement.cpp:
853         (WebCore::SVGRadialGradientElement::buildGradient):
854
855 2009-12-04  Anton Muhin  <antonm@chromium.org>
856
857         Reviewed by Dmitry Titov.
858
859         Do not use WebCore::String::String(const UChar*, int length) to convert
860         short v8 strings.
861
862         Plus added string traits.
863         https://bugs.webkit.org/show_bug.cgi?id=31415
864
865         * bindings/v8/V8Binding.cpp:
866         (WebCore::):
867         (WebCore::v8StringToWebCoreString):
868
869 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
870
871         Reviewed by Darin Adler.
872
873         REGRESSION: AX: buttons now extremely repetitive
874         https://bugs.webkit.org/show_bug.cgi?id=32164
875
876         Test: platform/mac/accessibility/button-shouldnot-have-axvalue.html
877
878         * accessibility/AccessibilityObject.h:
879         (WebCore::AccessibilityObject::isButton):
880         * accessibility/mac/AccessibilityObjectWrapper.mm:
881         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
882
883 2009-12-04  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
884
885         Reviewed by Darin Adler.
886
887         Check whether the right side of a string append is non-empty
888         https://bugs.webkit.org/show_bug.cgi?id=32151
889
890         Especially beneficial for CachedScript::script() method
891         which usually appends an empty string returned by flush()
892         to its m_script member. m_script is often hundreds of kbytes
893         which is duplated without reason.
894
895         * platform/text/String.cpp:
896         (WebCore::String::append):
897
898 2009-12-04  Enrica Casucci  <enrica@apple.com>
899
900         Reviewed by John Sullivan.
901
902         Mail.app crashes when indenting table pasted from Numbers.app.
903         <rdar://problem/7209507>
904         https://bugs.webkit.org/show_bug.cgi?id=32166
905
906         Test: LayoutTests/editing/execCommand/indent-partial-table.html
907         
908         * editing/IndentOutdentCommand.cpp:
909         (WebCore::IndentOutdentCommand::indentRegion): Added test to verify that the end of the paragraph
910         after the selection has not been moved.
911
912 2009-12-04  Alexey Proskuryakov  <ap@apple.com>
913
914         Reviewed by Darin Adler.
915
916         https://bugs.webkit.org/show_bug.cgi?id=32085
917         WebSocket should block the same ports that are blocked for resource loading
918
919         Test: websocket/tests/url-parsing.html
920
921         * page/SecurityOrigin.cpp:
922         (WebCore::SecurityOrigin::SecurityOrigin):
923         (WebCore::SecurityOrigin::localURLSchemes):
924         * page/SecurityOrigin.h:
925         Move isDefaultPortForProtocol() to KURL, because that's a better place for it (SecurityOrigin
926         is not even in WebCore/platform directory).
927
928         * html/HTMLAnchorElement.cpp:
929         (WebCore::HTMLAnchorElement::host):
930         (WebCore::HTMLAnchorElement::setHost):
931         (WebCore::HTMLAnchorElement::setPort):
932         Updated for the new location of isDefaultPortForProtocol().
933
934         * platform/KURL.cpp:
935         (WebCore::KURL::protocolIs): In an assertion, compare to "javascript" case-insensitively,
936         since the function doesn't require lower case input.
937         (WebCore::isDefaultPortForProtocol): Moved from SecurityOrigin.
938         (WebCore::portAllowed): Moved from ResourceHandle.
939         * platform/KURL.h:
940
941         * platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): Updated for the
942         new location of portAllowed().
943
944         * websockets/WebSocket.cpp: (WebCore::WebSocket::connect): Per the spec, raise a SECURITY_ERR
945         if trying to connect to a blocked port.
946
947 2009-12-04  Benjamin Poulain  <benjamin.poulain@nokia.com>
948
949         Reviewed by Kenneth Rohde Christiansen.
950
951         [Qt] WebKit crashes when loading certain SVG images
952         https://bugs.webkit.org/show_bug.cgi?id=29443
953
954         Remove FontFallbackListQt and rely on the common FontFallbackList
955         to handle the fonts. FontCache and FontPlatformData have been
956         updated to work with the common FontFallbackList.
957
958         In the previous implementation, FontPlatformDataCacheKey
959         was a clone of FontPlatformData with the hashing
960         capabilities added in order to use it as a key in the cache's
961         hashmap. FontPlatformData has been modified to handle the hashing
962         function directly so the data are not copied twice in memory.
963
964         FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
965         code from FontCache::getFontData() and FontFallbackList::fontDataAt().
966         The behavior is similar except currFamily->family().length() was
967         not tested and the fallback fonts selector were not used.
968
969         Existing tests cover the change.
970
971         * WebCore.pro:
972         * platform/graphics/qt/FontCacheQt.cpp:
973         (WebCore::FontCache::platformInit):
974         (WebCore::FontCache::getFontDataForCharacters):
975         (WebCore::FontCache::getSimilarFontPlatformData):
976         (WebCore::FontCache::getLastResortFallbackFont):
977         (WebCore::FontCache::getTraitsInFamily):
978         (WebCore::FontCache::createFontPlatformData):
979         * platform/graphics/qt/FontCustomPlatformData.cpp:
980         (WebCore::FontCustomPlatformData::fontPlatformData):
981         * platform/graphics/qt/FontFallbackListQt.cpp:
982         Removed. We now use the implementation from FontFallbackList.cpp
983         * platform/graphics/qt/FontPlatformData.h:
984         Add hashing capabilities to be able to use the data with the FontCache.
985         This was previously done in FontCacheQt.cpp
986         (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
987         (WebCore::FontPlatformData::FontPlatformData):
988         (WebCore::FontPlatformData::isHashTableDeletedValue):
989         (WebCore::FontPlatformData::font):
990         (WebCore::FontPlatformData::size):
991         (WebCore::FontPlatformData::family):
992         (WebCore::FontPlatformData::bold):
993         (WebCore::FontPlatformData::italic):
994         (WebCore::FontPlatformData::smallCaps):
995         (WebCore::FontPlatformData::pixelSize):
996         * platform/graphics/qt/FontPlatformDataQt.cpp:
997         (WebCore::FontPlatformData::FontPlatformData):
998         (WebCore::FontPlatformData::~FontPlatformData):
999         (WebCore::FontPlatformData::operator=):
1000         (WebCore::FontPlatformData::operator==):
1001         (WebCore::FontPlatformData::hash):
1002
1003 2009-12-04  Adam Treat  <atreat@rim.com>
1004
1005         Reviewed by Dan Bernstein.
1006
1007         Fix wrong assert that was only working through sheer luck.
1008         https://bugs.webkit.org/show_bug.cgi?id=32162
1009
1010         * platform/text/BidiContext.cpp:
1011         (WebCore::BidiContext::create):
1012
1013 2009-12-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1014
1015         Reviewed by Simon Hausmann.
1016
1017         [Qt] Allow removing 'qrc' as a local security origin scheme
1018
1019         * page/SecurityOrigin.cpp:
1020
1021 2009-12-04  Zoltan Horvath  <zoltan@webkit.org>
1022
1023         Reviewed by Eric Seidel.
1024
1025         Allow custom memory allocation control for WebCore's CollectionCache
1026         https://bugs.webkit.org/show_bug.cgi?id=32109
1027
1028         Inherits the following class from FastAllocBase because it is
1029         instantiated by 'new':
1030
1031         struct name            - instantiated at: WebCore/'location'
1032
1033         struct CollectionCache - dom/Document.cpp:4029
1034
1035         * html/CollectionCache.h:
1036
1037 2009-12-04  Steve Block  <steveblock@google.com>
1038
1039         Reviewed by Darin Adler.
1040
1041         Fixes a crashing bug in Geolocation when a watch is cleared from some callbacks. 
1042         https://bugs.webkit.org/show_bug.cgi?id=32111
1043
1044         In Geolocation::GeoNotifier::timerFired, a JS callback may be invoked if a
1045         fatal error was registered on this GeoNotifier or if this request has timed
1046         out. If the request is a watch, and is cleared by a call to clearWatch in the
1047         callback, the GeoNotifier object will be destroyed. We must therefore cache the
1048         m_geolocation member to allow us to call Geolocation::fatalErrorOccurred or
1049         Geolocation::requestTimedOut.
1050
1051         Tests: fast/dom/Geolocation/permission-denied-already-clear-watch.html
1052                fast/dom/Geolocation/timeout-clear-watch.html
1053
1054         * page/Geolocation.cpp: Modified.
1055         (WebCore::Geolocation::GeoNotifier::timerFired): Modified. Cache the m_geolocation member before invoking the JS callback.
1056
1057 2009-12-04  Zoltan Horvath  <zoltan@webkit.org>
1058
1059         Reviewed by Eric Seidel.
1060
1061         Allow custom memory allocation control for 2 classes of the platform directory in WebCore
1062         https://bugs.webkit.org/show_bug.cgi?id=
1063
1064         Inherits the following class from Noncopyable because it is instantiated
1065         by 'new' and no need to be copyable:
1066
1067         class/struct name         - instantiated at: WebCore/'location'
1068
1069         class SharedTimer         - (its child class) workers/WorkerRunLoop.cpp:91
1070
1071         Inherits the following class from FastAllocBase because it is
1072         instantiated by 'new':
1073
1074         class TransformOperations - rendering/style/RenderStyle.h:1175
1075
1076         Noncopyable.h's include added to SharedTimer.h.
1077
1078         * platform/SharedTimer.h:
1079         * platform/graphics/transforms/TransformOperations.h:
1080
1081 2009-12-04  Xan Lopez  <xlopez@igalia.com>
1082
1083         Reviewed by Gustavo Noronha.
1084
1085         [GTK]Enable DNS prefetching
1086         https://bugs.webkit.org/show_bug.cgi?id=23846
1087
1088         Enable DNS prefetching.
1089
1090         Based on a patch by José Millán.
1091
1092         * platform/network/soup/DNSSoup.cpp:
1093         (WebCore::prefetchDNS):
1094
1095 2009-12-04  Zoltan Horvath  <zoltan@webkit.org>
1096
1097         Reviewed by Eric Seidel.
1098
1099         Allow custom memory allocation control for the svg directory in WebCore
1100         https://bugs.webkit.org/show_bug.cgi?id=
1101
1102         Inherits the following classes from Noncopyable because these are instantiated
1103         by 'new' and no need to be copyable:
1104
1105         class/struct name           - instantiated at: WebCore/'location'
1106
1107         struct ResourceSet          - svg/graphics/SVGResource.cpp:148
1108         class SVGFontData           - css/CSSFontFaceSource.cpp:156
1109         class SVGDocumentExtensions - dom/Document.cpp:3962
1110         class SVGViewSpec           - svg/SVGSVGElement.cpp:191
1111
1112         * svg/SVGDocumentExtensions.h:
1113         * svg/SVGFontData.h:
1114         * svg/SVGViewSpec.h:
1115         * svg/graphics/SVGResource.cpp:
1116
1117 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
1118
1119         Reviewed by Beth Dakin.
1120
1121         WAI-ARIA: aria-activedescendant doesn't work as intended
1122         https://bugs.webkit.org/show_bug.cgi?id=32100
1123
1124         Fixes a number of issues regarding the "tree" role and aria-activedescendant.
1125         1. The indexes were being reported incorrectly by treeitems.
1126         2. aria-activedescendant changes were not being sent to the containing item.
1127         3. The tree's selected rows need to consult aria-activedescendant.
1128         4. Since a tree changes what it returns as its children (it returns its rows)
1129            the mac-specific array indexing methods need to correctly handle the tree case.
1130
1131         Tests: platform/mac/accessibility/aria-tree-activedescendant.html
1132                platform/mac/accessibility/aria-tree-index-of-items.html
1133
1134         * accessibility/AXObjectCache.h:
1135         (WebCore::AXObjectCache::):
1136         * accessibility/AccessibilityRenderObject.cpp:
1137         (WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
1138         (WebCore::AccessibilityRenderObject::activeDescendant):
1139         (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
1140         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
1141         * accessibility/mac/AXObjectCacheMac.mm:
1142         (WebCore::AXObjectCache::postPlatformNotification):
1143         * accessibility/mac/AccessibilityObjectWrapper.mm:
1144         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1145         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
1146         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
1147         * accessibility/win/AXObjectCacheWin.cpp:
1148         (WebCore::AXObjectCache::postPlatformNotification):
1149
1150 2009-12-03  Zoltan Horvath  <zoltan@webkit.org>
1151
1152         Reviewed by Eric Seidel.
1153
1154         Allow custom memory allocation control for the xml directory in WebCore
1155         https://bugs.webkit.org/show_bug.cgi?id=
1156
1157         Inherits the following class from Noncopyable because it is instantiated 
1158         by 'new' and no need to be copyable:
1159
1160         class/struct name               - instantiated at: WebCore/'location'
1161
1162         struct XMLHttpRequestStaticData - xml/XMLHttpRequest.cpp:134
1163
1164         Inherits the following classes from FastAllocBase because these are instantiated by 'new':
1165
1166         class NodeTest                  - xml/XPathGrammar.y:258
1167         class NodeSet                   - xml/XPathValue.cpp:52
1168         struct EvaluationContext        - xml/XPathExpressionNode.cpp:40
1169
1170         * xml/XMLHttpRequest.cpp:
1171         * xml/XPathExpressionNode.h:
1172         * xml/XPathNodeSet.h:
1173         * xml/XPathStep.h:
1174
1175 2009-12-03  Drew Wilson  <atwilson@chromium.org>
1176
1177         Reviewed by Adam Barth.
1178
1179         New History changes do not compile for Chromium/V8
1180         https://bugs.webkit.org/show_bug.cgi?id=32148
1181
1182         Existing tests suffice (just trying to get code to compile).
1183
1184         * WebCore.gypi:
1185         Added V8HistoryCustom.cpp and other missing files.
1186         * bindings/v8/custom/V8CustomBinding.h:
1187         Added custom handlers for History.pushState()/replaceState().
1188         * bindings/v8/custom/V8HistoryCustom.cpp: Added.
1189         Added custom handlers for History.pushState()/replaceState().
1190         * history/BackForwardListChromium.cpp:
1191         (WebCore::BackForwardList::pushStateItem):
1192         Stubbed out this routine for now - will implement in the future.
1193
1194 2009-12-03  Adam Barth  <abarth@webkit.org>
1195
1196         Reviewed by Eric Seidel.
1197
1198         OwnPtr<XBLBindingManager> Document::m_bindingManager;
1199         https://bugs.webkit.org/show_bug.cgi?id=32147
1200
1201         The document actually owns the bindingManager.  That's what the code
1202         should say.
1203
1204         * dom/Document.cpp:
1205         (WebCore::Document::~Document):
1206         * dom/Document.h:
1207         (WebCore::Document::bindingManager):
1208
1209 2009-12-03  Adam Barth  <abarth@webkit.org>
1210
1211         Reviewed by Eric Seidel.
1212
1213         OwnPtr<Tokenizer> Document::m_tokenizer;
1214         https://bugs.webkit.org/show_bug.cgi?id=32145
1215
1216         The document actually owns the tokenizer.  That's what the code should say.
1217
1218         * dom/Document.cpp:
1219         (WebCore::Document::removedLastRef):
1220         (WebCore::Document::~Document):
1221         (WebCore::Document::cancelParsing):
1222         (WebCore::Document::implicitOpen):
1223         (WebCore::Document::implicitClose):
1224         * dom/Document.h:
1225         (WebCore::Document::tokenizer):
1226
1227 2009-12-03  Adam Barth  <abarth@webkit.org>
1228
1229         Reviewed by Eric Seidel.
1230
1231         OwnPtr<RenderArena> Document::m_renderArena;
1232         https://bugs.webkit.org/show_bug.cgi?id=32146
1233
1234         The document owns the renderArena.  That's what the code should say.
1235
1236         * dom/Document.cpp:
1237         (WebCore::Document::Document): Also, removed a redundant initialization
1238         of the tokenizer that I missed in my previous patch.
1239         (WebCore::Document::~Document):
1240         (WebCore::Document::attach):
1241         (WebCore::Document::detach):
1242         * dom/Document.h:
1243         (WebCore::Document::renderArena):
1244
1245 2009-12-03  Drew Wilson  <atwilson@chromium.org>
1246
1247         Rolling back r51633 because it causes a chromium perf regression.
1248
1249         * platform/graphics/SimpleFontData.h:
1250         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
1251
1252 2009-12-03  Adam Barth  <abarth@webkit.org>
1253
1254         Reviewed by Eric Seidel.
1255
1256         The code should say that Document owns DocLoader
1257         https://bugs.webkit.org/show_bug.cgi?id=32143
1258
1259         It's the truth.
1260
1261         * dom/Document.cpp:
1262         (WebCore::Document::~Document):
1263         * dom/Document.h:
1264         (WebCore::Document::docLoader):
1265
1266 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
1267
1268         Reviewed by Eric Seidel.
1269
1270         AX: VO just says "term" on many web sites
1271         https://bugs.webkit.org/show_bug.cgi?id=32139
1272
1273         Test: platform/mac/accessibility/definition-list-term.html
1274
1275         * accessibility/AccessibilityRenderObject.cpp:
1276         (WebCore::AccessibilityRenderObject::accessibilityDescription):
1277         * accessibility/mac/AccessibilityObjectWrapper.mm:
1278         (-[AccessibilityObjectWrapper subrole]):
1279         (-[AccessibilityObjectWrapper roleDescription]):
1280
1281 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
1282
1283         Reviewed by Beth Dakin.
1284
1285         Implement WAI-ARIA scrollbar role and related property aria-orientation
1286         https://bugs.webkit.org/show_bug.cgi?id=32126
1287
1288         Test: accessibility/aria-scrollbar-role.html
1289
1290         * accessibility/AccessibilityObject.cpp:
1291         (WebCore::createARIARoleMap):
1292         * accessibility/AccessibilityObject.h:
1293         (WebCore::AccessibilityObject::isScrollbar):
1294         * accessibility/AccessibilityRenderObject.cpp:
1295         (WebCore::AccessibilityRenderObject::valueForRange):
1296         (WebCore::AccessibilityRenderObject::orientation):
1297         (WebCore::AccessibilityRenderObject::canHaveChildren):
1298         * accessibility/AccessibilityRenderObject.h:
1299         * accessibility/mac/AccessibilityObjectWrapper.mm:
1300         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
1301         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1302         * html/HTMLAttributeNames.in:
1303
1304 2009-12-03  Dan Bernstein  <mitz@apple.com>
1305
1306         Reviewed by Darin Adler.
1307
1308         Fixed <rdar://problem/7401617> Selection painting issue in hardware-
1309         accelerated layers
1310         which is another part of https://bugs.webkit.org/show_bug.cgi?id=23628
1311         Fix selection painting to do container-relative repaints
1312
1313         Test: fast/repaint/block-selection-gap-in-composited-layer.html
1314
1315         * rendering/RenderBlock.cpp:
1316         (WebCore::RenderBlock::selectionGapRectsForRepaint): Compute and paint
1317         gap rects in the coordinate space of the repaint container.
1318         * rendering/RenderLayerCompositor.cpp:
1319         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): Added a
1320         FIXME.
1321         * rendering/RenderView.cpp:
1322         (WebCore::RenderView::setSelection): Map block selection gap rects from
1323         the repaint container’s coordinate space to the view’s coordinate space
1324         before adding them to the cached selection bounds.
1325         (WebCore::RenderView::clearSelection): Changed to use
1326         repaintRectangleInViewAndCompositedLayers() so that the selection rect
1327         is invalidated in composited layers as well.
1328
1329 2009-12-03  Jonathan Dixon  <joth@chromium.org>
1330
1331         Reviewed by Dimitri Glazkov.
1332
1333         Bug 32066 - Add enable geolocation flag to WebCore::Settings for Chromium
1334         https://bugs.webkit.org/show_bug.cgi?id=32066
1335
1336         Adds geolocationEnabled in Settings for runtime control of geolocaiton features. This defaults to ON
1337         as it is intended as a development and testing aid, not a user control. To completely remove geolocation
1338         from a given port, the compile time ENABLE_GEOLOCATION should still be used.
1339         Adding placeholder GeolocationServiceChromium implementation, as this is required to allows
1340         ENABLE_GEOLOCATION to be defined (in turn required for testing), even though this patch does not
1341         make that the default just yet.
1342
1343         * WebCore.gypi:
1344         * page/Settings.cpp:
1345         (WebCore::Settings::Settings): Add new m_geolocationEnabled flag default value
1346         (WebCore::Settings::setGeolocationEnabled): Setter for  m_geolocationEnabled flag
1347         * page/Settings.h:
1348         (WebCore::Settings::geolocationEnabled):  Add m_geolocationEnabled flag
1349         * platform/chromium/GeolocationServiceChromium.cpp: Added.
1350         (WebCore::GeolocationServiceChromium::GeolocationServiceChromium): Place holder GeolocationServiceChromium)
1351         (WebCore::createGeolocationService): factory function, only required when ENABLED(GEOLOCATION) is true
1352
1353 2009-12-03  Enrica Casucci  <enrica@apple.com>
1354
1355         Reviewed by John Sullivan.
1356
1357         SpinTracer: 349 spins in Mail at WebCore::Editor::advanceToNextMisspelling(bool)
1358         <rdar://problem/7198592>
1359         https://bugs.webkit.org/show_bug.cgi?id=32129
1360
1361         Fixed the way the next paragraph is calculated.
1362         I've added a repro case in Safari and attached it to the Bugzilla bug.
1363
1364         * editing/Editor.cpp:
1365         (WebCore::findFirstMisspellingOrBadGrammarInRange): Changed the way we move to the
1366         next paragraph in the loop.
1367
1368 2009-12-03  Oliver Hunt  <oliver@apple.com>
1369
1370         Build fix
1371
1372         * svg/SVGListTraits.h:
1373         (WebCore::):
1374
1375 2009-12-03  Oliver Hunt  <oliver@apple.com>
1376
1377         Build fix
1378
1379         * svg/SVGListTraits.h:
1380         (WebCore::):
1381
1382 2009-12-03  Brady Eidson  <beidson@apple.com>
1383
1384         No wonder editing WebCore.exp repeatedly while I worked on this patch never seemed to stick.
1385
1386         Long live our auto-generated overlords that I didn't know about...  
1387
1388         * WebCore.base.exp:
1389
1390 2009-12-03  Oliver Hunt  <oliver@apple.com>
1391
1392         Reviewed by Dan Bernstein.
1393
1394         REGRESSION (r51627): 3 SVG tests are failing
1395         https://bugs.webkit.org/show_bug.cgi?id=32117
1396
1397         Null checking Items in the SVGList is insufficient as items may
1398         be floats, etc so add SVGListTraits::isNull and add appropriate
1399         specializations.
1400
1401         Test: svg/dom/svglist-exception-on-out-bounds-error.html
1402
1403         * svg/SVGList.h:
1404         (WebCore::SVGListTypeOperations::isNull):
1405         (WebCore::SVGList::initialize):
1406         (WebCore::SVGList::insertItemBefore):
1407         (WebCore::SVGList::replaceItem):
1408         (WebCore::SVGList::appendItem):
1409         * svg/SVGListTraits.h:
1410         (WebCore::):
1411
1412 2009-12-03  Brady Eidson  <beidson@apple.com>
1413
1414         No review - release build fix.
1415
1416         * history/HistoryItem.cpp:
1417         (WebCore::HistoryItem::documentDetached):
1418
1419 2009-12-03  Brady Eidson  <beidson@apple.com>
1420
1421         No review - release build fix.
1422
1423         * loader/HistoryController.cpp:
1424         (WebCore::HistoryController::pushState):
1425
1426 2009-12-03  Enrica Casucci  <enrica@apple.com>
1427
1428         Reviewed by Adele Peterson.
1429
1430         Multiple Undos removes the last posted comment and/or the ones before it.
1431         <rdar://problem/6557066>
1432         https://bugs.webkit.org/show_bug.cgi?id=32079
1433         
1434         The fix consists in preventing Undos and Redos to be applied to elements that
1435         are no longer editable. We do not attempt to remove the commands from the queue.
1436         It is a relatively simple fix that comes with a little extra overhead for the apply
1437         and unapply methods where we are now performing the editability check.
1438
1439         Test: editing/undo/undo-indent-noneditable.html
1440
1441         * editing/AppendNodeCommand.cpp:
1442         (WebCore::AppendNodeCommand::doApply):
1443         (WebCore::AppendNodeCommand::doUnapply):
1444         * editing/DeleteFromTextNodeCommand.cpp:
1445         (WebCore::DeleteFromTextNodeCommand::doApply):
1446         (WebCore::DeleteFromTextNodeCommand::doUnapply):
1447         * editing/InsertIntoTextNodeCommand.cpp:
1448         (WebCore::InsertIntoTextNodeCommand::doApply):
1449         (WebCore::InsertIntoTextNodeCommand::doUnapply):
1450         * editing/InsertNodeBeforeCommand.cpp:
1451         (WebCore::InsertNodeBeforeCommand::doApply):
1452         (WebCore::InsertNodeBeforeCommand::doUnapply):
1453         * editing/JoinTextNodesCommand.cpp:
1454         (WebCore::JoinTextNodesCommand::doApply):
1455         (WebCore::JoinTextNodesCommand::doUnapply):
1456         * editing/MergeIdenticalElementsCommand.cpp:
1457         (WebCore::MergeIdenticalElementsCommand::doApply):
1458         (WebCore::MergeIdenticalElementsCommand::doUnapply):
1459         * editing/RemoveNodeCommand.cpp:
1460         (WebCore::RemoveNodeCommand::doApply):
1461         (WebCore::RemoveNodeCommand::doUnapply):
1462         * editing/SplitElementCommand.cpp:
1463         (WebCore::SplitElementCommand::executeApply):
1464         (WebCore::SplitElementCommand::doUnapply):
1465         * editing/SplitTextNodeCommand.cpp:
1466         (WebCore::SplitTextNodeCommand::doApply):
1467         (WebCore::SplitTextNodeCommand::doUnapply):
1468         * editing/WrapContentsInDummySpanCommand.cpp:
1469         (WebCore::WrapContentsInDummySpanCommand::doUnapply):
1470         (WebCore::WrapContentsInDummySpanCommand::doReapply):
1471
1472 2009-12-03  Brady Eidson  <beidson@apple.com>
1473
1474         Reviewed by Sam Weinig.
1475
1476         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
1477
1478         Tests: fast/loader/stateobjects/document-destroyed-navigate-back.html
1479                fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html
1480                fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html
1481                fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html
1482                fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html
1483                fast/loader/stateobjects/pushstate-object-types.html
1484                fast/loader/stateobjects/pushstate-then-replacestate.html
1485                fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html
1486                fast/loader/stateobjects/replacestate-then-pushstate.html
1487                http/tests/loading/state-object-security-exception.html
1488
1489         Derived sources and project file changes:
1490         * DerivedSources.cpp:
1491         * DerivedSources.make:
1492         * GNUmakefile.am
1493         * WebCore.pro
1494         * WebCore.vcproj/WebCore.vcproj:
1495         * WebCore.xcodeproj/project.pbxproj:
1496
1497         Add the new PopStateEvent:
1498         * dom/PopStateEvent.cpp: Added.
1499         (WebCore::PopStateEvent::PopStateEvent):
1500         (WebCore::PopStateEvent::initPopStateEvent):
1501         * dom/PopStateEvent.h: Added.
1502         (WebCore::PopStateEvent::create):
1503         (WebCore::PopStateEvent::isPopStateEvent):
1504         (WebCore::PopStateEvent::state):
1505         * dom/PopStateEvent.idl: Added.
1506         * bindings/js/JSPopStateEventCustom.cpp: Added.
1507         (WebCore::JSPopStateEvent::initPopStateEvent):
1508         (WebCore::JSPopStateEvent::state):
1509         * bindings/js/JSEventCustom.cpp:
1510         (WebCore::toJS):
1511         * dom/Event.cpp:
1512         (WebCore::Event::isPopStateEvent):
1513         * dom/Event.h:
1514         * dom/EventNames.h:
1515
1516         Add the "onpopstate" attribute:
1517         * html/HTMLAttributeNames.in:
1518         * html/HTMLBodyElement.cpp:
1519         (WebCore::HTMLBodyElement::parseMappedAttribute):
1520         * html/HTMLBodyElement.idl:
1521         * html/HTMLFrameSetElement.cpp:
1522         (WebCore::HTMLFrameSetElement::parseMappedAttribute):
1523         * html/HTMLFrameSetElement.h:
1524         * html/HTMLFrameSetElement.idl:
1525         * page/DOMWindow.h:
1526         * page/DOMWindow.idl:
1527
1528         Add pushState and replaceState management to the loader and history machinery:
1529         * bindings/js/JSHistoryCustom.cpp:
1530         (WebCore::JSHistory::pushState):
1531         (WebCore::JSHistory::replaceState):
1532         * loader/HistoryController.cpp:
1533         (WebCore::HistoryController::updateForSameDocumentNavigation): Augmented from "scrollToAnchor()", combining
1534           both the same-document fragment scroll case with the new same-document state object activation case.
1535         (WebCore::HistoryController::pushState):
1536         (WebCore::HistoryController::replaceState):
1537         * loader/HistoryController.h:
1538         * history/BackForwardList.cpp:
1539         (WebCore::BackForwardList::addItem): Use insertItemAfterCurrent.
1540         (WebCore::BackForwardList::insertItemAfterCurrent): Optionally insert the item without clearing the forward
1541           list, as pushStateItem might've selectively cleared only certain items, with the bulk of the forward list
1542           meant to remain.
1543         (WebCore::BackForwardList::pushStateItem): Clear the forward list *only* for the state item's document, then 
1544           insert the new item.
1545         (WebCore::BackForwardList::removeItem):
1546         * history/BackForwardList.h:
1547         * page/History.cpp:
1548         (WebCore::History::urlForState):
1549         (WebCore::History::stateObjectAdded):
1550         * page/History.h:
1551         * page/History.idl:
1552
1553         Let HistoryItems and Documents associate with each other, as well as letting HistoryItems contain state objects:
1554         * history/HistoryItem.cpp:
1555         (WebCore::HistoryItem::HistoryItem):
1556         (WebCore::HistoryItem::~HistoryItem):
1557         (WebCore::HistoryItem::setStateObject):
1558         (WebCore::HistoryItem::setDocument):
1559         (WebCore::HistoryItem::documentDetached):
1560         * history/HistoryItem.h:
1561         (WebCore::HistoryItem::stateObject):
1562         (WebCore::HistoryItem::document):
1563         * dom/Document.cpp:
1564         (WebCore::Document::detach): Notify all back/forward history items owned by this Document that it
1565           is going away.
1566         (WebCore::Document::registerHistoryItem): Manage the list of back/forward history items this document owns.
1567         (WebCore::Document::unregisterHistoryItem): Ditto.
1568         * dom/Document.h:
1569
1570         Add the ability for Documents, DocumentLoaders, and FrameLoaderClients to be notified when a Documents
1571         URL changes as the result of pushState(), replaceState(), or a popstate navigation:
1572         * dom/Document.cpp:
1573         (WebCore::Document::implicitClose): If there's a pending state object, dispatch the popstate event.
1574         (WebCore::Document::updateURLForPushOrReplaceState):
1575         (WebCore::Document::statePopped): If loading is complete, dispatch the popstate event. Otherwise, set 
1576           the pending state object.
1577         * loader/DocumentLoader.cpp:
1578         (WebCore::DocumentLoader::replaceRequestURLForSameDocumentNavigation):
1579         * loader/DocumentLoader.h:
1580         * loader/FrameLoaderClient.h:
1581         * loader/EmptyClients.h:
1582         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeStateObjectForPageForFrame):
1583
1584         Change handling of "loading a HistoryItem" to distinguish between new-Document navigations and same-Document
1585         navigations, combining the old concept of anchor scrolls with the new concept of state object navigations:
1586         * loader/FrameLoader.cpp:
1587         (WebCore::FrameLoader::loadInSameDocument):
1588         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
1589         (WebCore::FrameLoader::navigateWithinDocument):
1590         (WebCore::FrameLoader::navigateToDifferentDocument):
1591         (WebCore::FrameLoader::loadItem):
1592         * loader/FrameLoader.h:
1593         * page/Page.cpp:
1594         (WebCore::Page::goToItem): Changed to allow state object activations to pass through without the load stopping.
1595
1596 2009-12-03  Pavel Feldman  <pfeldman@chromium.org>
1597
1598         Not reviewed: chromium build fix.
1599         r51621 changed JS bindings only, broke v8's.
1600
1601         * bindings/v8/ScriptFunctionCall.cpp:
1602         (WebCore::ScriptFunctionCall::appendArgument):
1603         * bindings/v8/ScriptFunctionCall.h:
1604
1605 2009-12-03  Dimitri Glazkov  <dglazkov@chromium.org>
1606
1607         Reviewed by Adam Barth.
1608
1609         [V8] Attributes and NamedNodeMaps aren't tracked correctly and may be prematurely garbage-collected.
1610         https://bugs.webkit.org/show_bug.cgi?id=32094
1611
1612         Covered by existing test: LayoutTests/fast/dom/Attr/access-after-element-destruction.html
1613
1614         * bindings/v8/DOMObjectsInclude.h:
1615         * bindings/v8/V8DOMWrapper.cpp:
1616         (WebCore::V8DOMWrapper::getTemplate):
1617         (WebCore::V8DOMWrapper::convertToV8Object):
1618         (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
1619         * bindings/v8/V8DOMWrapper.h:
1620         * bindings/v8/V8GCController.cpp:
1621         (WebCore::ObjectGrouperVisitor::visitDOMWrapper):
1622         * bindings/v8/custom/V8CustomBinding.h:
1623
1624 2009-12-03  Pavel Feldman  <pfeldman@chromium.org>
1625
1626         Reviewed by Timothy Hatcher.
1627
1628         Chromium: Add support for settings containing ":"
1629
1630         https://bugs.webkit.org/show_bug.cgi?id=32118
1631
1632         * inspector/front-end/WatchExpressionsSidebarPane.js:
1633         (WebInspector.WatchExpressionsSection):
1634
1635 2009-12-03  Rafael Antognolli  <antognolli@profusion.mobi>, Kenneth Christiansen <kenneth@webkit.org>
1636
1637         Reviewed by Simon Fraser.
1638
1639         repaint events from outside the viewport aren't received
1640         https://bugs.webkit.org/show_bug.cgi?id=32081
1641
1642         When using a tiled backing store for painting, you need to receive
1643         event from outside the viewport. Setting the viewport to the size
1644         of the contents is not an option if you want to make use of WebCore's
1645         infrastructure for drawing scrollbars etc.
1646
1647         A new property, paintsEntireContents, has been introduced for the
1648         above use-case. It is settable, as tiling will be optional for Qt,
1649         and for the not yet upstreamed EFL port, there will be two different
1650         views, where only one of them are tiled.
1651
1652         No change in behavior, so no new tests added.
1653
1654         * page/FrameView.cpp:
1655         (WebCore::FrameView::repaintContentRectangle):
1656         * platform/ScrollView.cpp:
1657         (WebCore::ScrollView::ScrollView):
1658         (WebCore::ScrollView::setPaintsEntireContents):
1659         (WebCore::ScrollView::wheelEvent):
1660         * platform/ScrollView.h:
1661         (WebCore::ScrollView::paintsEntireContents):
1662
1663 2009-11-23  Jeremy Moskovich  <jeremy@chromium.org>
1664
1665         Reviewed by Eric Seidel.
1666
1667         Switch Chrome/Mac to use Core Text APIs rather than ATSUI APIs.
1668         https://bugs.webkit.org/show_bug.cgi?id=31802
1669
1670         No test since this is already covered by existing pixel tests.
1671
1672         * platform/graphics/SimpleFontData.h: Change #ifdef to define getNSFont() on Chrome/Mac .
1673         * platform/graphics/mac/ComplexTextControllerCoreText.cpp: Provide forward declarations
1674         of Core Text functions that are public on 10.6 but SPI on 10.5.
1675
1676 2009-12-03  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
1677
1678         Reviewed by Timothy Hatcher.
1679
1680         Web Inspector: Simplify the settings support in inspector controller.
1681
1682         https://bugs.webkit.org/show_bug.cgi?id=32076
1683
1684         Test: inspector/settings-set-get.html
1685
1686         * WebCore.Inspector.exp:
1687         * bindings/js/JSInspectorFrontendHostCustom.cpp:
1688         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
1689         * inspector/InspectorClient.h:
1690         * inspector/InspectorController.cpp:
1691         (WebCore::InspectorController::~InspectorController):
1692         (WebCore::InspectorController::setting):
1693         (WebCore::InspectorController::setSetting):
1694         (WebCore::InspectorController::setWindowVisible):
1695         (WebCore::InspectorController::attachWindow):
1696         (WebCore::InspectorController::setAttachedWindowHeight):
1697         (WebCore::InspectorController::storeLastActivePanel):
1698         (WebCore::InspectorController::scriptObjectReady):
1699         (WebCore::InspectorController::showWindow):
1700         (WebCore::InspectorController::enableResourceTracking):
1701         (WebCore::InspectorController::disableResourceTracking):
1702         (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded):
1703         (WebCore::InspectorController::enableProfiler):
1704         (WebCore::InspectorController::disableProfiler):
1705         (WebCore::InspectorController::enableDebuggerFromFrontend):
1706         (WebCore::InspectorController::disableDebugger):
1707         * inspector/InspectorController.h:
1708         * inspector/InspectorFrontendHost.cpp:
1709         (WebCore::InspectorFrontendHost::setting):
1710         (WebCore::InspectorFrontendHost::setSetting):
1711         * inspector/InspectorFrontendHost.h:
1712         * inspector/InspectorFrontendHost.idl:
1713         * loader/EmptyClients.h:
1714         (WebCore::EmptyInspectorClient::populateSetting):
1715         (WebCore::EmptyInspectorClient::storeSetting):
1716
1717 2009-12-03  Ben Murdoch  <benm@google.com>
1718
1719         Reviewed by Brady Eidson.
1720
1721         [Android] notifyHistoryItemChanged() should pass a pointer to the HistoryItem that changed.
1722         https://bugs.webkit.org/show_bug.cgi?id=31915
1723
1724         No change in functionality so no new tests required.
1725
1726         * history/HistoryItem.cpp:
1727         (WebCore::defaultNotifyHistoryItemChanged): Update this function to pass the HistoryItem that is being changed.
1728         (WebCore::HistoryItem::setAlternateTitle): Update call to notifyHistoryItemChanged to include the new parameter.
1729         (WebCore::HistoryItem::setURLString): ditto.
1730         (WebCore::HistoryItem::setOriginalURLString): ditto.
1731         (WebCore::HistoryItem::setReferrer): ditto.
1732         (WebCore::HistoryItem::setTitle): ditto.
1733         (WebCore::HistoryItem::setTarget): ditto.
1734         (WebCore::HistoryItem::setDocumentState): On Android, add a call to notifyHistoryItemChanged. See bug for a discussion of why this is needed.
1735         (WebCore::HistoryItem::clearDocumentState): ditto.
1736         (WebCore::HistoryItem::setIsTargetItem): ditto.
1737         (WebCore::HistoryItem::addChildItem): ditto.
1738         (WebCore::HistoryItem::setFormInfoFromRequest): ditto.
1739         * history/HistoryItem.h: Update signature of notifyHistoryItemChanged.
1740
1741 2009-12-03  Ben Murdoch  <benm@google.com>
1742
1743         Reviewed by Brady Eidson.
1744
1745         [Android] The FrameLoaderClient is unaware of BackForwardList changes.
1746         https://bugs.webkit.org/show_bug.cgi?id=31914
1747
1748         This change adds three new methods on the FrameLoaderClient interface to receive notifications when the BackForwardList changes.
1749
1750         No new tests required. Functionality on all platforms upstream remains the same. Android is the first platform to make use of these callbacks.
1751
1752         * history/BackForwardList.cpp:
1753         (WebCore::BackForwardList::addItem): Execute the callback.
1754         (WebCore::BackForwardList::goBack): ditto.
1755         (WebCore::BackForwardList::goForward): ditto.
1756         (WebCore::BackForwardList::goToItem): ditto.
1757         (WebCore::BackForwardList::setCapacity): dito.
1758         * loader/EmptyClients.h:
1759         (WebCore::EmptyFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation for the callback that does nothing.
1760         (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
1761         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
1762         * loader/FrameLoaderClient.h:
1763
1764 2009-12-03  Ben Murdoch  <benm@google.com>
1765
1766         Reviewed by Brady Eidson.
1767
1768         [Android] Upstream WebCore/history/android: Require some platform specific state attached to HistoryItem.
1769         https://bugs.webkit.org/show_bug.cgi?id=31913
1770
1771         Android stores information such as the zoom scale factor and bridge back to the Java counterpart with HistoryItem.
1772
1773         No new tests required as this is Android specific code.
1774
1775         * history/HistoryItem.h: Add Android specific member data to HistoryItem.
1776         * history/android: Added.
1777         * history/android/AndroidWebHistoryBridge.h: Added.
1778         * history/android/HistoryItemAndroid.cpp: Added, provides implementation for Android specific member functions in HistoryItem.
1779         (WebCore::HistoryItem::bridge): Added.
1780         (WebCore::HistoryItem::setBridge): Added.
1781
1782 2009-12-03  Oliver Hunt  <oliver@apple.com>
1783
1784         Reviewed by Maciej Stachowiak.
1785
1786         NULL ptr in SVGPathSegList::getPathSegAtLength()
1787         https://bugs.webkit.org/show_bug.cgi?id=30313
1788
1789         Add exception checks to SVGPathSegList's implementation to catch (and propagate) exceptions.
1790         Add null checks to SVGList's content manipulation functions to prevent
1791         null values from entering the list in the first place.
1792
1793         Test: svg/dom/svgpath-out-of-bounds-getPathSeg.html
1794
1795         * svg/SVGList.h:
1796         (WebCore::SVGList::initialize):
1797         (WebCore::SVGList::insertItemBefore):
1798         (WebCore::SVGList::replaceItem):
1799         (WebCore::SVGList::appendItem):
1800         * svg/SVGPathElement.cpp:
1801         (WebCore::SVGPathElement::getPathSegAtLength):
1802         * svg/SVGPathElement.h:
1803         * svg/SVGPathElement.idl:
1804         * svg/SVGPathSegList.cpp:
1805         (WebCore::SVGPathSegList::getPathSegAtLength):
1806         (WebCore::SVGPathSegList::toPathData):
1807         (WebCore::SVGPathSegList::createAnimated):
1808         * svg/SVGPathSegList.h:
1809
1810 2009-12-02  Yusuke Sato  <yusukes@chromium.org>
1811
1812         Reviewed by Eric Seidel.
1813
1814         Sanitize web fonts using the OTS library 
1815         https://bugs.webkit.org/show_bug.cgi?id=31106
1816
1817         Add support for OpenType sanitizer (OTS). It parses OpenType files (from @font-face)
1818         and attempts to validate and sanitize them. We hope this reduces the attack surface
1819         of the system font libraries.
1820
1821         * WebCore.gyp/WebCore.gyp: Added dependency to (chromium_src_dir)/third_party/ots/ library.
1822         * WebCore.gypi: Added new files below.
1823         * WebCore.xcodeproj/project.pbxproj: Ditto.
1824         * platform/graphics/chromium/FontCustomPlatformData.cpp: Validate and transcode a web font.
1825         (WebCore::createFontCustomPlatformData):
1826         * platform/graphics/mac/FontCustomPlatformData.cpp: Ditto.
1827         (WebCore::createFontCustomPlatformData):
1828         * platform/graphics/opentype/OpenTypeSanitizer.cpp: Added.
1829         (WebCore::OpenTypeSanitizer::sanitize):
1830         * platform/graphics/opentype/OpenTypeSanitizer.h: Added.
1831         (WebCore::OpenTypeSanitizer::OpenTypeSanitizer):
1832
1833 2009-12-02  Oliver Hunt  <oliver@apple.com>
1834
1835         Reviewed by Sam Weinig.
1836
1837         Web Inspector frontend heap allocates ScriptFunctionCall which is unsafe
1838         https://bugs.webkit.org/show_bug.cgi?id=32098
1839
1840         Fix is simply to make the ScriptFunctionCall stack allocated as nature intended.
1841         Doing this required adding an appendArgument(char*) to ScriptFunctionCall so
1842         that an explicit String cast would not be necessary.
1843
1844         To prevent something like this happening again in future i've added private
1845         operator new implementations to ScriptFunctionCall making this type of mistake
1846         produce errors when compiling.
1847
1848         Test case: Inspector tests now pass with GC on every alloc enabled.
1849
1850         * bindings/js/ScriptFunctionCall.cpp:
1851         (WebCore::ScriptFunctionCall::appendArgument):
1852         * bindings/js/ScriptFunctionCall.h:
1853         (WebCore::ScriptFunctionCall::operator new):
1854         (WebCore::ScriptFunctionCall::operator new[]):
1855         * inspector/InspectorFrontend.cpp:
1856         (WebCore::InspectorFrontend::addConsoleMessage):
1857         (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount):
1858         (WebCore::InspectorFrontend::addResource):
1859         (WebCore::InspectorFrontend::updateResource):
1860         (WebCore::InspectorFrontend::removeResource):
1861         (WebCore::InspectorFrontend::updateFocusedNode):
1862         (WebCore::InspectorFrontend::setAttachedWindow):
1863         (WebCore::InspectorFrontend::addRecordToTimeline):
1864         (WebCore::InspectorFrontend::parsedScriptSource):
1865         (WebCore::InspectorFrontend::failedToParseScriptSource):
1866         (WebCore::InspectorFrontend::addProfileHeader):
1867         (WebCore::InspectorFrontend::setRecordingProfile):
1868         (WebCore::InspectorFrontend::didGetProfileHeaders):
1869         (WebCore::InspectorFrontend::didGetProfile):
1870         (WebCore::InspectorFrontend::pausedScript):
1871         (WebCore::InspectorFrontend::setDocument):
1872         (WebCore::InspectorFrontend::setDetachedRoot):
1873         (WebCore::InspectorFrontend::setChildNodes):
1874         (WebCore::InspectorFrontend::childNodeCountUpdated):
1875         (WebCore::InspectorFrontend::childNodeInserted):
1876         (WebCore::InspectorFrontend::childNodeRemoved):
1877         (WebCore::InspectorFrontend::attributesUpdated):
1878         (WebCore::InspectorFrontend::didRemoveNode):
1879         (WebCore::InspectorFrontend::didGetChildNodes):
1880         (WebCore::InspectorFrontend::didApplyDomChange):
1881         (WebCore::InspectorFrontend::didGetEventListenersForNode):
1882         (WebCore::InspectorFrontend::didGetCookies):
1883         (WebCore::InspectorFrontend::didDispatchOnInjectedScript):
1884         (WebCore::InspectorFrontend::addDatabase):
1885         (WebCore::InspectorFrontend::selectDatabase):
1886         (WebCore::InspectorFrontend::didGetDatabaseTableNames):
1887         (WebCore::InspectorFrontend::addDOMStorage):
1888         (WebCore::InspectorFrontend::selectDOMStorage):
1889         (WebCore::InspectorFrontend::didGetDOMStorageEntries):
1890         (WebCore::InspectorFrontend::didSetDOMStorageItem):
1891         (WebCore::InspectorFrontend::didRemoveDOMStorageItem):
1892         (WebCore::InspectorFrontend::updateDOMStorage):
1893         (WebCore::InspectorFrontend::addNodesToSearchResult):
1894         (WebCore::InspectorFrontend::evaluateForTestInFrontend):
1895         * inspector/InspectorFrontend.h:
1896
1897 2009-12-02  Dave Hyatt  <hyatt@apple.com>
1898
1899         Reviewed by Darin Adler.
1900
1901         https://bugs.webkit.org/show_bug.cgi?id=32072, clean up invalid @-rule error handling so that we
1902         pass more CSS test suite stuff.  Make the grammar stop enforcing the ordering of @namespace vs.
1903         @variables vs. @import.  Just let the parser handle that instead.  This simplifies the grammar and
1904         makes error handling deal with more cases correctly.
1905
1906         Added fast/css/namespaces/namespaces-invalid-at-rules.xml
1907
1908         * css/CSSGrammar.y:
1909         * css/CSSParser.cpp:
1910         (WebCore::CSSParser::CSSParser):
1911         (WebCore::CSSParser::parseRule):
1912         (WebCore::CSSParser::createCharsetRule):
1913         (WebCore::CSSParser::createImportRule):
1914         (WebCore::CSSParser::createMediaRule):
1915         (WebCore::CSSParser::createKeyframesRule):
1916         (WebCore::CSSParser::createStyleRule):
1917         (WebCore::CSSParser::createFontFaceRule):
1918         (WebCore::CSSParser::addNamespace):
1919         (WebCore::CSSParser::createVariablesRule):
1920         * css/CSSParser.h:
1921
1922 2009-12-02  Yusuke Sato  <yusukes@chromium.org>
1923
1924         Reviewed by Dan Bernstein.
1925
1926         Safari/Chromium for Windows fails to load CJK WebFonts
1927         https://bugs.webkit.org/show_bug.cgi?id=31804
1928         
1929         * platform/graphics/opentype/OpenTypeUtilities.cpp:
1930         (WebCore::renameAndActivateFont): Load a remote font even if the font has 2 or more faces.
1931
1932 2009-12-02  Avi Drissman  <avi@chromium.org>
1933
1934         Reviewed by Darin Fisher.
1935
1936         Chromium: Need tickmarks in scrollbar
1937         https://bugs.webkit.org/show_bug.cgi?id=32069
1938
1939         * WebCore.gyp/WebCore.gyp:
1940         * WebCore.gypi:
1941         * platform/chromium/ScrollbarThemeChromiumMac.h: Added.
1942         * platform/chromium/ScrollbarThemeChromiumMac.mm: Added.
1943
1944 2009-11-13  Timothy Hatcher  <timothy@apple.com>
1945
1946         Expose a function to set the value of an input element on behalf of the user.
1947         This function will dispatch the change event so the page is notified when autofill
1948         happens. Also dispatch a change event when a select element is changed by autofill.
1949
1950         <rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript
1951
1952         Reviewed by Darin Adler.
1953
1954         * WebCore.xcodeproj/project.pbxproj: Added the DOMHTMLInputElementPrivate.h header.
1955         * bindings/objc/DOMHTML.mm:
1956         (-[DOMHTMLSelectElement _activateItemAtIndex:]): Call setSelectedIndexByUser instead so
1957         a change event is fired. This method is called by Safari autofill.
1958         * dom/Document.cpp:
1959         (WebCore::Document::setFocusedNode): Use dispatchFormControlChangeEvent instead
1960         of dispatching the change event directly to be consistent.
1961         * html/HTMLFormControlElement.cpp:
1962         (WebCore::HTMLInputElement::setValueForUser): Added. Calls setValue with the sendChangeEvent
1963         (WebCore::HTMLInputElement::setValue): Added the optional sendChangeEvent argument. Mimics setChecked.
1964         * html/HTMLInputElement.h:
1965         * html/HTMLInputElement.idl: Added setValueForUser for non-JS languages.
1966         * html/InputElement.h: Added setValueForUser.
1967
1968 2009-12-02  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
1969
1970         Reviewed by Timothy Hatcher.
1971
1972         Web Inspector: DOM tree selection disappears upon page refresh.
1973
1974         https://bugs.webkit.org/show_bug.cgi?id=31142
1975
1976         Test: inspector/elements-panel-selection-on-refresh.html
1977
1978         * inspector/InjectedScriptHost.cpp:
1979         (WebCore::InjectedScriptHost::pushNodeByPathToFrontend):
1980         * inspector/InjectedScriptHost.h:
1981         * inspector/InjectedScriptHost.idl:
1982         * inspector/InspectorBackend.h:
1983         * inspector/InspectorController.cpp:
1984         (WebCore::InspectorController::close):
1985         (WebCore::InspectorController::releaseDOMAgent):
1986         (WebCore::InspectorController::resetScriptObjects):
1987         * inspector/InspectorDOMAgent.cpp:
1988         (WebCore::InspectorDOMAgent::~InspectorDOMAgent):
1989         (WebCore::InspectorDOMAgent::reset):
1990         (WebCore::InspectorDOMAgent::setDocument):
1991         (WebCore::InspectorDOMAgent::pushDocumentToFrontend):
1992         (WebCore::InspectorDOMAgent::nodeForPath):
1993         (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
1994         * inspector/InspectorDOMAgent.h:
1995         * inspector/front-end/DOMAgent.js:
1996         (WebInspector.DOMNode.prototype._renumber):
1997         (WebInspector.DOMAgent.prototype._setDocument):
1998         * inspector/front-end/ElementsPanel.js:
1999         (WebInspector.ElementsPanel.prototype.reset):
2000         (WebInspector.ElementsPanel.prototype.setDocument.selectDefaultNode):
2001         (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode):
2002         (WebInspector.ElementsPanel.prototype.setDocument):
2003         * inspector/front-end/InjectedScript.js:
2004         (InjectedScript.pushNodeByPathToFrontend):
2005         * inspector/front-end/InjectedScriptAccess.js:
2006
2007 2009-12-01  Dave Hyatt  <hyatt@apple.com>
2008
2009         Reviewed by Dan Bernstein.
2010
2011         https://bugs.webkit.org/show_bug.cgi?id=32045, make sure escape sequences work with
2012         all the @-rules we support.  When escape sequences are present, the lexical scanner
2013         just returns a generic token name: ATKEYWORD.  We have to process the escape sequences
2014         and then recheck against the rules we support with the final processed name.  If we
2015         find a match, we mutate the token value to the appropriate rule name token, e.g.,
2016         NAMESPACE_SYM.
2017
2018         Added fast/css/namespaces/namespaces-escapes.xml
2019
2020         * css/CSSParser.cpp:
2021         (WebCore::CSSParser::lex):
2022         (WebCore::CSSParser::recheckAtKeyword):
2023         (WebCore::CSSParser::text):
2024         * css/CSSParser.h:
2025
2026 2009-12-02  Anton Muhin  <antonm@chromium.org>
2027
2028         Reviewed by Adam Barth.:w
2029
2030         Allow to skip thread checks when accessing DOMDataStore for processes
2031         which run V8 in single thread mode.
2032         https://bugs.webkit.org/show_bug.cgi?id=31877
2033
2034         Should be covered by buildbots.
2035
2036         * bindings/v8/V8DOMMap.cpp:
2037         (WebCore::getDOMDataStore):
2038         (WebCore::enableFasterDOMStoreAccess):
2039         (WebCore::getDOMNodeMap):
2040         (WebCore::getDOMObjectMap):
2041         (WebCore::getActiveDOMObjectMap):
2042         (WebCore::getDOMSVGElementInstanceMap):
2043         (WebCore::getDOMSVGObjectWithContextMap):
2044         * bindings/v8/V8DOMMap.h:
2045
2046 2009-12-02  Yury Semikhatsky  <yurys@chromium.org>
2047
2048         Reviewed by Pavel Feldman.
2049
2050         Code clean up: remove ScriptObjectQuarantine.* as a whole.
2051
2052         https://bugs.webkit.org/show_bug.cgi?id=32060
2053
2054         * GNUmakefile.am:
2055         * WebCore.gypi:
2056         * WebCore.pro:
2057         * WebCore.vcproj/WebCore.vcproj:
2058         * WebCore.xcodeproj/project.pbxproj:
2059         * WebCoreSources.bkl:
2060         * bindings/js/JSBindingsAllInOne.cpp:
2061         * bindings/js/ScriptObjectQuarantine.cpp: Removed.
2062         * bindings/js/ScriptObjectQuarantine.h: Removed.
2063         * bindings/js/ScriptValue.cpp:
2064         (WebCore::ScriptValue::quarantineValue):
2065         * bindings/js/ScriptValue.h:
2066         * bindings/v8/ScriptObjectQuarantine.cpp: Removed.
2067         * bindings/v8/ScriptObjectQuarantine.h: Removed.
2068         * bindings/v8/ScriptValue.h:
2069         (WebCore::ScriptValue::quarantineValue):
2070         * inspector/ConsoleMessage.cpp:
2071         (WebCore::ConsoleMessage::ConsoleMessage):
2072         * inspector/InspectorController.cpp:
2073         * inspector/InspectorDatabaseResource.cpp:
2074         (WebCore::InspectorDatabaseResource::bind):
2075         * inspector/InspectorFrontend.cpp:
2076
2077 2009-12-02  Fumitoshi Ukai  <ukai@chromium.org>
2078
2079         Reviewed by Alexey Proskuryakov.
2080
2081         WebSocket handshake check query component of URL
2082         https://bugs.webkit.org/show_bug.cgi?id=31617
2083
2084         Tests: websocket/tests/url-with-credential.html
2085                websocket/tests/url-with-empty-query.html
2086                websocket/tests/url-with-fragment.html
2087                websocket/tests/url-with-query-for-no-query.html
2088                websocket/tests/url-with-query.html
2089
2090         * platform/KURLGoogle.cpp:
2091         (WebCore::KURL::query): returns a null if query is not specified and returns an empty if query is specified but empty.
2092         * websockets/WebSocketHandshake.cpp:
2093         (WebCore::resourceName): added. add query component to path if specified.
2094         (WebCore::WebSocketHandshake::clientLocation):
2095         (WebCore::WebSocketHandshake::clientHandshakeMessage):
2096
2097 2009-12-01  David Levin  <levin@chromium.org>
2098
2099         Reviewed by Eric Seidel.
2100
2101         Incorrect code in WebGLRenderingContext.cpp
2102         https://bugs.webkit.org/show_bug.cgi?id=32046
2103
2104         Fix incorrect code that happened to work. != has higher precendence than &.
2105         The simplest fix is to remove the "!= 0" which violates WebKit style
2106         guidelines anyway.
2107
2108         Also added periods to few comments in the same function.
2109
2110         * html/canvas/WebGLRenderingContext.cpp:
2111         (WebCore::WebGLRenderingContext::validateIndexArray):
2112
2113 2009-12-01  Kent Tamura  <tkent@chromium.org>
2114
2115         Reviewed by Darin Adler.
2116
2117         Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
2118         pattern and step attributes of HTMLInputElement.
2119         https://bugs.webkit.org/show_bug.cgi?id=31708
2120
2121         * html/HTMLInputElement.idl:
2122
2123 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
2124
2125         Reviewed by Darin Adler.
2126
2127         WAI-ARIA: implement support for ARIA drag and drop
2128         https://bugs.webkit.org/show_bug.cgi?id=32007
2129
2130         Test: platform/mac/accessibility/aria-drag-drop.html
2131
2132         * accessibility/AccessibilityObject.h:
2133         (WebCore::AccessibilityObject::supportsARIADropping):
2134         (WebCore::AccessibilityObject::supportsARIADragging):
2135         (WebCore::AccessibilityObject::isARIAGrabbed):
2136         (WebCore::AccessibilityObject::setARIAGrabbed):
2137         (WebCore::AccessibilityObject::determineARIADropEffects):
2138         * accessibility/AccessibilityRenderObject.cpp:
2139         (WebCore::AccessibilityRenderObject::supportsARIADropping):
2140         (WebCore::AccessibilityRenderObject::supportsARIADragging):
2141         (WebCore::AccessibilityRenderObject::isARIAGrabbed):
2142         (WebCore::AccessibilityRenderObject::setARIAGrabbed):
2143         (WebCore::AccessibilityRenderObject::determineARIADropEffects):
2144         * accessibility/AccessibilityRenderObject.h:
2145         * accessibility/mac/AccessibilityObjectWrapper.mm:
2146         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
2147         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
2148         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
2149         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
2150         * html/HTMLAttributeNames.in:
2151
2152 2009-12-01  Adam Barth  <abarth@webkit.org>
2153
2154         https://bugs.webkit.org/show_bug.cgi?id=21288
2155
2156         Unreviewed port of @sandbox to V8.
2157
2158         * bindings/v8/ScriptController.cpp:
2159         (WebCore::ScriptController::isEnabled):
2160         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2161         (WebCore::createWindow):
2162
2163 2009-12-01  Patrik Persson  <patrik.j.persson@ericsson.com>
2164
2165         Reviewed by Darin Adler.
2166
2167         Implement HTML5 sandbox attribute for iframes.
2168         http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
2169         https://bugs.webkit.org/show_bug.cgi?id=21288
2170
2171         Tests: fast/frames/sandboxed-iframe-attribute-parsing.html
2172                fast/frames/sandboxed-iframe-forms.html
2173                fast/frames/sandboxed-iframe-navigation-allowed.html
2174                fast/frames/sandboxed-iframe-navigation-parent.html
2175                fast/frames/sandboxed-iframe-navigation-targetlink.html
2176                fast/frames/sandboxed-iframe-navigation-windowopen.html
2177                fast/frames/sandboxed-iframe-plugins.html
2178                fast/frames/sandboxed-iframe-scripting.html
2179                fast/frames/sandboxed-iframe-storage.html
2180                http/tests/security/sandboxed-iframe-document-cookie.html
2181                http/tests/security/sandboxed-iframe-modify-self.html
2182                http/tests/security/xss-DENIED-sandboxed-iframe.html
2183                http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html
2184                http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html
2185                http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html
2186
2187         * bindings/js/JSDOMWindowCustom.cpp: sandboxing navigation
2188         (WebCore::createWindow):
2189         * bindings/js/ScriptController.cpp: sandboxing scripts
2190         (WebCore::ScriptController::isEnabled):
2191         * dom/Document.cpp:
2192         (WebCore::Document::processHttpEquiv):
2193         (WebCore::Document::cookie): raise exception when accessed from sandbox
2194         (WebCore::Document::setCookie): raise exception when accessed from sandbox
2195         (WebCore::Document::initSecurityContext): updae sandbox status
2196         (WebCore::Document::updateSandboxFlags):
2197         * dom/Document.h:
2198         * dom/Document.idl:
2199         * html/HTMLAppletElement.cpp: sandboxing applets
2200         (WebCore::HTMLAppletElement::createRenderer):
2201         (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
2202         (WebCore::HTMLAppletElement::canEmbedJava):
2203         * html/HTMLAppletElement.h:
2204         * html/HTMLAttributeNames.in:
2205         * html/HTMLFrameOwnerElement.cpp: management of sandbox flags as stated in attribute
2206         (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
2207         (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
2208         * html/HTMLFrameOwnerElement.h:
2209         (WebCore::HTMLFrameOwnerElement::sandboxFlags):
2210         * html/HTMLIFrameElement.cpp: sandbox attribute parsing
2211         (WebCore::parseSandboxAttribute):
2212         (WebCore::HTMLIFrameElement::parseMappedAttribute):
2213         * html/HTMLIFrameElement.idl:
2214         * inspector/InspectorController.cpp:
2215         (WebCore::InspectorController::getCookies):
2216         * loader/CrossOriginAccessControl.cpp:
2217         (WebCore::passesAccessControlCheck):
2218         * loader/FrameLoader.cpp:
2219         (WebCore::FrameLoader::FrameLoader):
2220         (WebCore::FrameLoader::init):
2221         (WebCore::FrameLoader::submitForm): sandboxing forms
2222         (WebCore::FrameLoader::requestObject): sandboxing plugins
2223         (WebCore::FrameLoader::shouldAllowNavigation): sandboxing navigation
2224         (WebCore::FrameLoader::updateSandboxFlags): propagation of sandbox flags
2225         * loader/FrameLoader.h:
2226         (WebCore::FrameLoader::ownerElementSandboxFlagsChanged):
2227         (WebCore::FrameLoader::isSandboxed):
2228         (WebCore::FrameLoader::sandboxFlags):
2229         * loader/FrameLoaderTypes.h:
2230         (WebCore::):
2231         * page/DOMWindow.cpp: disable storage and databases in sandboxed frames
2232         (WebCore::DOMWindow::sessionStorage):
2233         (WebCore::DOMWindow::localStorage):
2234         (WebCore::DOMWindow::openDatabase):
2235         * page/SecurityOrigin.cpp: added sandboxing status
2236         (WebCore::SecurityOrigin::SecurityOrigin):
2237         (WebCore::SecurityOrigin::canAccess):
2238         (WebCore::SecurityOrigin::canRequest):
2239         (WebCore::SecurityOrigin::toString):
2240         * page/SecurityOrigin.h:
2241         (WebCore::SecurityOrigin::setSandboxFlags):
2242         (WebCore::SecurityOrigin::isSandboxed):
2243         (WebCore::SecurityOrigin::canAccessDatabase):
2244         (WebCore::SecurityOrigin::canAccessStorage):
2245         * websockets/WebSocketChannel.cpp:
2246         (WebCore::WebSocketChannel::didReceiveData):
2247
2248 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
2249
2250         Reviewed by David Kilzer.
2251
2252         ARIA: support a way to create a static text object
2253         https://bugs.webkit.org/show_bug.cgi?id=32030
2254
2255         Test: accessibility/aria-text-role.html
2256
2257         * accessibility/AccessibilityObject.cpp:
2258         (WebCore::createARIARoleMap):
2259         * accessibility/AccessibilityRenderObject.cpp:
2260         (WebCore::AccessibilityRenderObject::stringValue):
2261         (WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent):
2262         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2263         (WebCore::AccessibilityRenderObject::text):
2264         * accessibility/AccessibilityRenderObject.h:
2265
2266 2009-12-01  Oliver Hunt  <oliver@apple.com>
2267
2268         Reviewed by Maciej Stachowiak.
2269
2270         Inspector crashes when collecting on every allocation
2271         https://bugs.webkit.org/show_bug.cgi?id=32044
2272
2273         The crash is caused by the prototype wrapper object getting collected
2274         when allocating the object that is going to use it as a prototype.
2275         Because the only reference to the prototype wrapper is through the
2276         new object's Structure it does not get marked automatically.
2277
2278         * bindings/js/JSInspectedObjectWrapper.cpp:
2279         (WebCore::JSInspectedObjectWrapper::wrap):
2280         * bindings/js/JSInspectorCallbackWrapper.cpp:
2281         (WebCore::JSInspectorCallbackWrapper::wrap):
2282
2283 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
2284
2285         Reviewed by Simon Fraser.
2286
2287         Add SVG animation test framework with 'snapshot' functionality
2288         https://bugs.webkit.org/show_bug.cgi?id=31897
2289
2290         Add 'sampleSVGAnimationForElementAtTime' method to the LayoutTestController,
2291         for the use within the new SVG animation test framework (LayoutTests/svg/animations/)
2292
2293         layoutTestController.sampleAnimationAtTime(<svg animation id>, <absolute time>, <svg element id>);
2294         to sample a svg animateMotion/animateColor/animate/set element at certain times.
2295
2296         After the desired SVG animation starts and calling the method above, it's immediately forwarded to
2297         the desired sampling time. After JS returns from the 'sampleSVGAnimationForElementAtTime' method
2298         a callback is fired used to sample the animation value at the target time. It's modelled similar
2299         to the CSS animation/transition testing framework, inspired by
2300         LayoutTests/animations/animation-test-helpers.js.
2301
2302         Though it has been extended to integrate within the fast/js/js-test-* framework, that's used for
2303         the SVG dynamic-updates tests, to simplify test creation, by utilizing script-tests/* only.
2304
2305         Adding a simple testcase testing the DRT methods, it will soon be extended to test animVal/baseVal
2306         interaction, while animating.
2307
2308         Test: svg/animations/animVal-basics.html
2309
2310         * WebCore.base.exp:
2311         * WebCore.xcodeproj/project.pbxproj:
2312         * svg/SVGDocumentExtensions.cpp:
2313         (WebCore::SVGDocumentExtensions::sampleAnimationAtTime):
2314         * svg/SVGDocumentExtensions.h:
2315         * svg/animation/SMILTimeContainer.cpp:
2316         (WebCore::SMILTimeContainer::SMILTimeContainer):
2317         (WebCore::SMILTimeContainer::sampleAnimationAtTime):
2318         (WebCore::SMILTimeContainer::updateAnimations):
2319         * svg/animation/SMILTimeContainer.h:
2320
2321 2009-12-01  Jens Alfke  <snej@chromium.org>
2322
2323         Reviewed by Darin Adler.
2324
2325         Add convenience methods to Element and QualifiedName that take
2326         char* instead of AtomicString, in preparation for removing the
2327         implicit conversion between the two types (30187).
2328         https://bugs.webkit.org/show_bug.cgi?id=31749
2329
2330         * dom/Element.cpp:
2331         (WebCore::Element::setCStringAttribute):  Equivalent to setAttribute.
2332         * dom/Element.h:
2333         * dom/QualifiedName.cpp:
2334         (WebCore::QualifiedName::init):  Shared impl of both constructors
2335         (WebCore::QualifiedName::QualifiedName):  New c'tor taking char*.
2336         * dom/QualifiedName.h:
2337         * platform/network/HTTPHeaderMap.cpp:
2338         (WebCore::CaseFoldingCStringTranslator):  Enables lookup by C string
2339         (WebCore::HTTPHeaderMap::get):  New variant that takes C string
2340         (WebCore::HTTPHeaderMap::contains):  New variant that takes C string
2341         (WebCore::HTTPHeaderMap::add):  New variant that takes C string
2342         * platform/network/HTTPHeaderMap.h:
2343         (WebCore::HTTPHeaderMap::get):
2344         (WebCore::HTTPHeaderMap::add):
2345         * platform/network/ResourceRequestBase.cpp:
2346         (WebCore::ResourceRequestBase::httpHeaderField):  New variant that takes C string
2347         * platform/network/ResourceRequestBase.h:
2348         (WebCore::ResourceRequestBase::setHTTPHeaderField):  Use symbolic names for headers
2349         * platform/network/ResourceResponseBase.cpp:
2350         (WebCore::ResourceResponseBase::httpHeaderField):  New variant that takes C string
2351         * platform/network/ResourceResponseBase.h:
2352
2353 2009-12-01  Alexey Proskuryakov  <ap@apple.com>
2354
2355         More Windows build fix.
2356
2357         * platform/network/cf/CredentialStorageCFNet.cpp:
2358         (WebCore::CredentialStorage::getFromPersistentStorage):
2359
2360 2009-12-01  Alexey Proskuryakov  <ap@apple.com>
2361
2362         Windows build fix.
2363
2364         * platform/network/cf/CredentialStorageCFNet.cpp: Include RetainPtr.h.
2365
2366 2009-12-01  Alexey Proskuryakov  <ap@apple.com>
2367
2368         Reviewed by Darin Adler.
2369
2370         https://bugs.webkit.org/show_bug.cgi?id=32036
2371         Implement CredentialStorage::getFromPersistentStorage for CFNetwork
2372
2373         * platform/network/cf/CredentialStorageCFNet.cpp:
2374         (WebCore::CredentialStorage::getFromPersistentStorage):
2375
2376 2009-12-01  Daniel Bates  <dbates@webkit.org>
2377
2378         Reviewed by Pavel Feldman.
2379
2380         https://bugs.webkit.org/show_bug.cgi?id=32001
2381
2382         Added missing localized strings (that I left out of the patch for bug #21554):
2383         %d × %d pixels
2384         %d × %d pixels (Natural: %d × %d pixels)
2385
2386         Also, changed formatting of these stings to conform with existing ones (added
2387         a space on both sides of the multiply sign).
2388
2389         * English.lproj/localizedStrings.js: Added stings.
2390         * inspector/front-end/ElementsTreeOutline.js:
2391         (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
2392
2393 2009-12-01  Dave Hyatt  <hyatt@apple.com>
2394
2395         Reviewed by Simon Fraser.
2396
2397         Fix for bug 32032, empty namespaces should be allowed in @namespace directives in CSS.
2398
2399         Added fast/css/namespaces/namespaces-empty.xml
2400
2401         * css/CSSStyleSheet.cpp:
2402         (WebCore::CSSStyleSheet::addNamespace):
2403         (WebCore::CSSStyleSheet::determineNamespace):
2404
2405 2009-12-01  Joseph Pecoraro  <joepeck@webkit.org>
2406
2407         Reviewed by Timothy Hatcher.
2408
2409         Web Inspector: Escape key in the Search Field should be more User Friendly
2410         https://bugs.webkit.org/show_bug.cgi?id=32005
2411
2412         * inspector/front-end/inspector.js:
2413         (WebInspector.loaded): add mousedown listener on the search field
2414         (WebInspector.searchFieldManualFocus): user clicked to focus on the search field
2415         (WebInspector.searchKeyDown): handle escape
2416
2417 2009-12-01  Dave Hyatt  <hyatt@apple.com>
2418
2419         Reviewed by David Kilzer.
2420
2421         @namespace directives need to use "maybe_space" in the "maybe_ns_prefix" portion of the grammar to match
2422         the spec.  Not doing so prevent comments from being used immmediately after the namespace prefix.
2423
2424         Added fast/css/namespaces-comments.xml
2425
2426         * css/CSSGrammar.y:
2427
2428 2009-12-01  Yael Aharon  <yael.aharon@nokia.com>
2429
2430         Reviewed by Timothy Hatcher.
2431
2432         Reloading WebInspector from context menu is closing it instead of reloading.
2433         https://bugs.webkit.org/show_bug.cgi?id=32004
2434
2435         When reloading WebInspector, don't delete its m_page.
2436
2437         * inspector/InspectorController.cpp:
2438         (WebCore::InspectorController::close):
2439
2440 2009-12-01  Steve Block  <steveblock@google.com>
2441
2442         Reviewed by Dimitri Glazkov.
2443
2444         Adds V8 bindings for Geolocation.
2445         https://bugs.webkit.org/show_bug.cgi?id=30206
2446
2447         Also adds Geolocation files to Chrome build files.
2448
2449         * WebCore.gyp/WebCore.gyp: Modified. Corrects list of Geolocation IDL files.
2450         * WebCore.gypi: Modified. Adds Geolocation files.
2451         * bindings/v8/DOMObjectsInclude.h: Modified. Adds Geolocation includes.
2452         * bindings/v8/DerivedSourcesAllInOne.cpp: Modified. Adds Geolocation files.
2453         * bindings/v8/V8Index.cpp: Modified. Includes Geolocation generated headers.
2454         * bindings/v8/V8Index.h: Modified. Adds Geolocation types to DOM_OBJECT_TYPES.
2455         * bindings/v8/custom/V8CoordinatesCustom.cpp: Added. Handles optional properties.
2456         * bindings/v8/custom/V8CustomBinding.h: Modified. Declares callbacks and getters.
2457         * bindings/v8/custom/V8CustomPositionCallback.cpp: Added.
2458         (WebCore::V8CustomPositionCallback::V8CustomPositionCallback): Added. Constructor.
2459         (WebCore::V8CustomPositionCallback::~V8CustomPositionCallback): Added. Destructor.
2460         (WebCore::V8CustomPositionCallback::handleEvent): Added. Invokes callback.
2461         * bindings/v8/custom/V8CustomPositionCallback.h: Added.
2462         (WebCore::V8CustomPositionCallback::create): Added. Factory method.
2463         * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Added.
2464         (WebCore::V8CustomPositionErrorCallback::V8CustomPositionErrorCallback): Added. Constructor.
2465         (WebCore::V8CustomPositionErrorCallback::~V8CustomPositionErrorCallback): Added. Destructor.
2466         (WebCore::V8CustomPositionErrorCallback::handleEvent): Added. Invokes callback.
2467         * bindings/v8/custom/V8CustomPositionErrorCallback.h: Added.
2468         (WebCore::V8CustomPositionErrorCallback::create): Added. Factory method.
2469         * bindings/v8/custom/V8GeolocationCustom.cpp: Added.
2470         (WebCore::throwTypeMismatchException): Added. Throws a type mismatch error.
2471         (WebCore::createPositionCallback): Added. Handles type checking for successCallback argument.
2472         (WebCore::createPositionErrorCallback): Added. Handles type checking for errorCallback argument.
2473         (WebCore::createPositionOptions): Added. Handles type checking for positionOptions argument.
2474
2475 2009-12-01  Yury Semikhatsky  <yurys@chromium.org>
2476
2477         Reviewed by Adam Barth.
2478
2479         Provide a way to get ScriptState for the inspected page.
2480
2481         https://bugs.webkit.org/show_bug.cgi?id=32020
2482
2483         * bindings/v8/ScriptController.cpp:
2484         (WebCore::ScriptController::mainWorldScriptState):
2485         * bindings/v8/ScriptController.h:
2486         * bindings/v8/ScriptState.cpp:
2487         (WebCore::scriptStateFromPage):
2488
2489 2009-12-01  Chris Marrin  <cmarrin@apple.com>
2490
2491         Reviewed by Adam Roben.
2492
2493         Changed mallocs to fastMallocs and frees to fastFrees in GraphicsContext3D. Also added error returns
2494         https://bugs.webkit.org/show_bug.cgi?id=30778
2495
2496         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2497         (WebCore::GraphicsContext3D::getProgramInfoLog):
2498         (WebCore::GraphicsContext3D::getShaderInfoLog):
2499         (WebCore::GraphicsContext3D::getShaderSource):
2500         (WebCore::imageToTexture):
2501
2502 2009-12-01  Mads Ager  <ager@chromium.org>
2503
2504         Reviewed by Eric Seidel.
2505
2506         [V8] Don't crash in DOMWindow event getter in OOM situations
2507         https://bugs.webkit.org/show_bug.cgi?id=32017
2508
2509         Add missing null handle checks in DOMWindow event property
2510         accessors.  V8Proxy::context(frame) can return a null handle in
2511         OOM situations either if failing to initialize a context or if an
2512         OOM is handled gracefully and javascript is disabled.
2513
2514         No new tests because we don't have a good way to test
2515         out-of-memory bugs.
2516
2517         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2518         (WebCore::ACCESSOR_GETTER):
2519         (WebCore::ACCESSOR_SETTER):
2520
2521 2009-12-01  Chris Marrin  <cmarrin@apple.com>
2522
2523         Reviewed by Oliver Hunt.
2524
2525         Updated HTMLCanvasElement to accept "experimental-webgl" as the context name.
2526         https://bugs.webkit.org/show_bug.cgi?id=31672
2527
2528         * html/HTMLCanvasElement.cpp:
2529         (WebCore::HTMLCanvasElement::getContext):
2530
2531 2009-12-01  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
2532
2533         Not reviewed: chromium build fix, added missing import.
2534
2535         * inspector/InspectorFrontendHost.cpp:
2536
2537 2009-12-01  Pavel Feldman  <pfeldman@chromium.org>
2538
2539         Not reviewed: fix windows build via unexcluding generated files from
2540         project.
2541
2542         * WebCore.vcproj/WebCore.vcproj:
2543
2544 2009-12-01  Mark Rowe  <mrowe@apple.com>
2545
2546         Stop copying IDL files in to the WebCore framework wrapper.
2547
2548         * WebCore.xcodeproj/project.pbxproj:
2549
2550 2009-12-01  Mark Rowe  <mrowe@apple.com>
2551
2552         Fix the Tiger build by making the Xcode project compatible with Xcode 2.4.
2553
2554         This was probably broken by hand-editing the project file as Xcode itself
2555         knows how to keep project files to a backwards-compatible subset of its format.
2556
2557         * WebCore.xcodeproj/project.pbxproj:
2558
2559 2009-12-01  Pavel Feldman  <pfeldman@chromium.org>
2560
2561         Not reviewed: windows build fix (bad vcproj in r51528).
2562
2563         * WebCore.vcproj/WebCore.vcproj:
2564
2565 2009-11-27  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
2566
2567         Reviewed by Timothy Hatcher.
2568
2569         Web Inspector: Split InspectorBackend into three parts: backend,
2570         injected script host and frontend host.
2571         
2572         https://bugs.webkit.org/show_bug.cgi?id=31888
2573
2574         * DerivedSources.make:
2575         * GNUmakefile.am:
2576         * WebCore.gypi:
2577         * WebCore.pro:
2578         * WebCore.vcproj/WebCore.vcproj:
2579         * WebCore.xcodeproj/project.pbxproj:
2580         * WebCoreSources.bkl:
2581         * bindings/js/JSBindingsAllInOne.cpp:
2582         * bindings/js/JSInspectorBackendCustom.cpp: Removed.
2583         * bindings/js/JSInspectorFrontendHostCustom.cpp: Added.
2584         (WebCore::JSInspectorFrontendHost::search):
2585         (WebCore::JSInspectorFrontendHost::setting):
2586         (WebCore::JSInspectorFrontendHost::setSetting):
2587         * bindings/js/ScriptObject.cpp:
2588         (WebCore::ScriptGlobalObject::set):
2589         * bindings/js/ScriptObject.h:
2590         * bindings/v8/DOMObjectsInclude.h:
2591         * bindings/v8/DerivedSourcesAllInOne.cpp:
2592         * bindings/v8/ScriptObject.cpp:
2593         (WebCore::ScriptGlobalObject::set):
2594         * bindings/v8/ScriptObject.h:
2595         * bindings/v8/V8Index.cpp:
2596         * bindings/v8/V8Index.h:
2597         * bindings/v8/custom/V8CustomBinding.h:
2598         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: Added.
2599         (WebCore::CALLBACK_FUNC_DECL):
2600         * bindings/v8/custom/V8InspectorBackendCustom.cpp: Removed.
2601         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: Added.
2602         (WebCore::CALLBACK_FUNC_DECL):
2603         * inspector/InjectedScriptHost.cpp: Added.
2604         (WebCore::InjectedScriptHost::InjectedScriptHost):
2605         (WebCore::InjectedScriptHost::~InjectedScriptHost):
2606         (WebCore::InjectedScriptHost::copyText):
2607         (WebCore::InjectedScriptHost::nodeForId):
2608         (WebCore::InjectedScriptHost::wrapObject):
2609         (WebCore::InjectedScriptHost::unwrapObject):
2610         (WebCore::InjectedScriptHost::pushNodePathToFrontend):
2611         (WebCore::InjectedScriptHost::addNodesToSearchResult):
2612         (WebCore::InjectedScriptHost::currentCallFrame):
2613         (WebCore::InjectedScriptHost::databaseForId):
2614         (WebCore::InjectedScriptHost::selectDatabase):
2615         (WebCore::InjectedScriptHost::selectDOMStorage):
2616         (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
2617         (WebCore::InjectedScriptHost::inspectorDOMAgent):
2618         (WebCore::InjectedScriptHost::inspectorFrontend):
2619         * inspector/InjectedScriptHost.h: Added.
2620         (WebCore::InjectedScriptHost::create):
2621         (WebCore::InjectedScriptHost::inspectorController):
2622         (WebCore::InjectedScriptHost::disconnectController):
2623         * inspector/InjectedScriptHost.idl: Added.
2624         * inspector/InspectorBackend.cpp:
2625         (WebCore::InspectorBackend::InspectorBackend):
2626         (WebCore::InspectorBackend::storeLastActivePanel):
2627         (WebCore::InspectorBackend::toggleNodeSearch):
2628         (WebCore::InspectorBackend::resourceTrackingEnabled):
2629         (WebCore::InspectorBackend::debuggerEnabled):
2630         (WebCore::InspectorBackend::enableDebugger):
2631         (WebCore::InspectorBackend::disableDebugger):
2632         (WebCore::InspectorBackend::addBreakpoint):
2633         (WebCore::InspectorBackend::updateBreakpoint):
2634         (WebCore::InspectorBackend::removeBreakpoint):
2635         (WebCore::InspectorBackend::pauseInDebugger):
2636         (WebCore::InspectorBackend::resumeDebugger):
2637         (WebCore::InspectorBackend::stepOverStatementInDebugger):
2638         (WebCore::InspectorBackend::stepIntoStatementInDebugger):
2639         (WebCore::InspectorBackend::stepOutOfFunctionInDebugger):
2640         (WebCore::InspectorBackend::pauseOnExceptions):
2641         (WebCore::InspectorBackend::setPauseOnExceptions):
2642         (WebCore::InspectorBackend::profilerEnabled):
2643         (WebCore::InspectorBackend::enableProfiler):
2644         (WebCore::InspectorBackend::disableProfiler):
2645         (WebCore::InspectorBackend::startProfiling):
2646         (WebCore::InspectorBackend::stopProfiling):
2647         (WebCore::InspectorBackend::getProfileHeaders):
2648         (WebCore::InspectorBackend::getProfile):
2649         (WebCore::InspectorBackend::currentCallFrame):
2650         (WebCore::InspectorBackend::highlightDOMNode):
2651         (WebCore::InspectorBackend::hideDOMNodeHighlight):
2652         (WebCore::InspectorBackend::getCookies):
2653         (WebCore::InspectorBackend::deleteCookie):
2654         (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
2655         (WebCore::InspectorBackend::nodeForId):
2656         * inspector/InspectorBackend.h:
2657         (WebCore::InspectorBackend::create):
2658         * inspector/InspectorBackend.idl:
2659         * inspector/InspectorController.cpp:
2660         (WebCore::InspectorController::InspectorController):
2661         (WebCore::InspectorController::~InspectorController):
2662         (WebCore::InspectorController::inspectedPageDestroyed):
2663         (WebCore::InspectorController::windowScriptObjectAvailable):
2664         * inspector/InspectorController.h:
2665         (WebCore::InspectorController::inspectorFrontendHost):
2666         (WebCore::InspectorController::injectedScriptHost):
2667         * inspector/InspectorFrontendHost.cpp: Added.
2668         (WebCore::InspectorFrontendHost::InspectorFrontendHost):
2669         (WebCore::InspectorFrontendHost::~InspectorFrontendHost):
2670         (WebCore::InspectorFrontendHost::loaded):
2671         (WebCore::InspectorFrontendHost::attach):
2672         (WebCore::InspectorFrontendHost::detach):
2673         (WebCore::InspectorFrontendHost::closeWindow):
2674         (WebCore::InspectorFrontendHost::windowUnloading):
2675         (WebCore::InspectorFrontendHost::setAttachedWindowHeight):
2676         (WebCore::InspectorFrontendHost::moveWindowBy):
2677         (WebCore::InspectorFrontendHost::localizedStringsURL):
2678         (WebCore::InspectorFrontendHost::hiddenPanels):
2679         (WebCore::InspectorFrontendHost::platform):
2680         (WebCore::InspectorFrontendHost::port):
2681         (WebCore::InspectorFrontendHost::addResourceSourceToFrame):
2682         (WebCore::InspectorFrontendHost::addSourceToFrame):
2683         * inspector/InspectorFrontendHost.h: Added.
2684         (WebCore::InspectorFrontendHost::create):
2685         (WebCore::InspectorFrontendHost::inspectorController):
2686         (WebCore::InspectorFrontendHost::disconnectController):
2687         * inspector/InspectorFrontendHost.idl: Added.
2688         * inspector/front-end/Breakpoint.js:
2689         (WebInspector.Breakpoint.prototype.set condition):
2690         * inspector/front-end/BreakpointsSidebarPane.js:
2691         (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
2692         (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
2693         (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
2694         * inspector/front-end/ConsoleView.js:
2695         (WebInspector.ConsoleView.prototype.clearMessages):
2696         * inspector/front-end/CookieItemsView.js:
2697         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2698         * inspector/front-end/DOMAgent.js:
2699         (WebInspector.DOMAgent.prototype.getChildNodesAsync):
2700         (WebInspector.DOMAgent.prototype.setAttributeAsync):
2701         (WebInspector.DOMAgent.prototype.removeAttributeAsync):
2702         (WebInspector.DOMAgent.prototype.setTextNodeValueAsync):
2703         (WebInspector.Cookies.getCookiesAsync):
2704         (WebInspector.EventListeners.getEventListenersForNodeAsync):
2705         * inspector/front-end/DOMStorage.js:
2706         (WebInspector.DOMStorage.prototype.getEntries):
2707         (WebInspector.DOMStorage.prototype.setItem):
2708         (WebInspector.DOMStorage.prototype.removeItem):
2709         * inspector/front-end/Database.js:
2710         (WebInspector.Database.prototype.getTableNames):
2711         * inspector/front-end/ElementsPanel.js:
2712         (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
2713         (WebInspector.ElementsPanel.prototype.hide):
2714         (WebInspector.ElementsPanel.prototype.reset):
2715         (WebInspector.ElementsPanel.prototype.handleCopyEvent):
2716         (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
2717         * inspector/front-end/ElementsTreeOutline.js:
2718         (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode):
2719         (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
2720         ():
2721         * inspector/front-end/EventListenersSidebarPane.js:
2722         (WebInspector.EventListenersSidebarPane.prototype):
2723         * inspector/front-end/InjectedScript.js:
2724         (InjectedScript._evaluateAndWrap):
2725         (InjectedScript.performSearch.addNodesToResults):
2726         (InjectedScript.getCallFrames):
2727         (InjectedScript._callFrameForId):
2728         (InjectedScript._clearConsoleMessages):
2729         (InjectedScript._inspectObject):
2730         (InjectedScript._copy):
2731         (InjectedScript._ensureCommandLineAPIInstalled):
2732         (InjectedScript._window):
2733         (InjectedScript._nodeForId):
2734         (InjectedScript._objectForId):
2735         (InjectedScript.pushNodeToFrontend):
2736         (InjectedScript.executeSql):
2737         (InjectedScript.executeSql.errorCallback):
2738         (InjectedScript.executeSql.queryTransaction):
2739         * inspector/front-end/InjectedScriptAccess.js:
2740         (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName):
2741         (InjectedScriptAccess._installHandler):
2742         * inspector/front-end/InspectorBackendStub.js: Added.
2743         (.WebInspector.InspectorBackendStub):
2744         (.WebInspector.InspectorBackendStub.prototype.wrapCallback):
2745         (.WebInspector.InspectorBackendStub.prototype.platform):
2746         (.WebInspector.InspectorBackendStub.prototype.port):
2747         (.WebInspector.InspectorBackendStub.prototype.closeWindow):
2748         (.WebInspector.InspectorBackendStub.prototype.attach):
2749         (.WebInspector.InspectorBackendStub.prototype.detach):
2750         (.WebInspector.InspectorBackendStub.prototype.storeLastActivePanel):
2751         (.WebInspector.InspectorBackendStub.prototype.clearMessages):
2752         (.WebInspector.InspectorBackendStub.prototype.searchingForNode):
2753         (.WebInspector.InspectorBackendStub.prototype.search):
2754         (.WebInspector.InspectorBackendStub.prototype.toggleNodeSearch):
2755         (.WebInspector.InspectorBackendStub.prototype.setAttachedWindowHeight):
2756         (.WebInspector.InspectorBackendStub.prototype.moveByUnrestricted):
2757         (.WebInspector.InspectorBackendStub.prototype.addResourceSourceToFrame):
2758         (.WebInspector.InspectorBackendStub.prototype.addSourceToFrame):
2759         (.WebInspector.InspectorBackendStub.prototype.getResourceDocumentNode):
2760         (.WebInspector.InspectorBackendStub.prototype.highlightDOMNode):
2761         (.WebInspector.InspectorBackendStub.prototype.hideDOMNodeHighlight):
2762         (.WebInspector.InspectorBackendStub.prototype.inspectedWindow):
2763         (.WebInspector.InspectorBackendStub.prototype.loaded):
2764         (.WebInspector.InspectorBackendStub.prototype.localizedStringsURL):
2765         (.WebInspector.InspectorBackendStub.prototype.windowUnloading):
2766         (.WebInspector.InspectorBackendStub.prototype.hiddenPanels):
2767         (.WebInspector.InspectorBackendStub.prototype.debuggerEnabled):
2768         (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking):
2769         (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking):
2770         (.WebInspector.InspectorBackendStub.prototype.resourceTrackingEnabled):
2771         (.WebInspector.InspectorBackendStub.prototype.enableDebugger):
2772         (.WebInspector.InspectorBackendStub.prototype.disableDebugger):
2773         (.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
2774         (.WebInspector.InspectorBackendStub.prototype.removeBreakpoint):
2775         (.WebInspector.InspectorBackendStub.prototype.updateBreakpoint):
2776         (.WebInspector.InspectorBackendStub.prototype.pauseInDebugger):
2777         (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptions):
2778         (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptions):
2779         (.WebInspector.InspectorBackendStub.prototype.resumeDebugger):
2780         (.WebInspector.InspectorBackendStub.prototype.profilerEnabled):
2781         (.WebInspector.InspectorBackendStub.prototype.enableProfiler):
2782         (.WebInspector.InspectorBackendStub.prototype.disableProfiler):
2783         (.WebInspector.InspectorBackendStub.prototype.startProfiling):
2784         (.WebInspector.InspectorBackendStub.prototype.stopProfiling):
2785         (.WebInspector.InspectorBackendStub.prototype.getProfileHeaders):
2786         (.WebInspector.InspectorBackendStub.prototype.getProfile):
2787         (.WebInspector.InspectorBackendStub.prototype.takeHeapSnapshot):
2788         (.WebInspector.InspectorBackendStub.prototype.databaseTableNames):
2789         (.WebInspector.InspectorBackendStub.prototype.stepIntoStatementInDebugger):
2790         (.WebInspector.InspectorBackendStub.prototype.stepOutOfFunctionInDebugger):
2791         (.WebInspector.InspectorBackendStub.prototype.stepOverStatementInDebugger):
2792         (.WebInspector.InspectorBackendStub.prototype.setSetting):
2793         (.WebInspector.InspectorBackendStub.prototype.dispatchOnInjectedScript):
2794         (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
2795         (.WebInspector.InspectorBackendStub.prototype.setting):
2796         * inspector/front-end/InspectorControllerStub.js:
2797         * inspector/front-end/InspectorFrontendHostStub.js: Added.
2798         (.WebInspector.InspectorFrontendHostStub):
2799         (.WebInspector.InspectorFrontendHostStub.prototype.platform):
2800         (.WebInspector.InspectorFrontendHostStub.prototype.port):
2801         (.WebInspector.InspectorFrontendHostStub.prototype.closeWindow):
2802         (.WebInspector.InspectorFrontendHostStub.prototype.attach):
2803         (.WebInspector.InspectorFrontendHostStub.prototype.detach):
2804         (.WebInspector.InspectorFrontendHostStub.prototype.search):
2805         (.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight):
2806         (.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy):
2807         (.WebInspector.InspectorFrontendHostStub.prototype.addResourceSourceToFrame):
2808         (.WebInspector.InspectorFrontendHostStub.prototype.addSourceToFrame):
2809         (.WebInspector.InspectorFrontendHostStub.prototype.loaded):
2810         (.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL):
2811         (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
2812         (.WebInspector.InspectorFrontendHostStub.prototype.setSetting):
2813         (.WebInspector.InspectorFrontendHostStub.prototype.setting):
2814         * inspector/front-end/ProfileView.js:
2815         (WebInspector.CPUProfileView):
2816         (WebInspector.CPUProfileType.prototype.buttonClicked):
2817         * inspector/front-end/ProfilesPanel.js:
2818         (WebInspector.ProfilesPanel.prototype._updateInterface):
2819         (WebInspector.ProfilesPanel.prototype._enableProfiling):
2820         (WebInspector.ProfilesPanel.prototype._toggleProfiling):
2821         * inspector/front-end/ResourcesPanel.js:
2822         (WebInspector.ResourcesPanel.prototype.reset):
2823         (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
2824         (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
2825         (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
2826         * inspector/front-end/ScriptView.js:
2827         (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
2828         * inspector/front-end/ScriptsPanel.js:
2829         (WebInspector.ScriptsPanel.prototype.show):
2830         (WebInspector.ScriptsPanel.prototype.addScript):
2831         (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
2832         (WebInspector.ScriptsPanel.prototype.reset):
2833         (WebInspector.ScriptsPanel.prototype.canShowResource):
2834         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
2835         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
2836         (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
2837         (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
2838         (WebInspector.ScriptsPanel.prototype._enableDebugging):
2839         (WebInspector.ScriptsPanel.prototype._toggleDebugging):
2840         (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
2841         (WebInspector.ScriptsPanel.prototype._togglePause):
2842         (WebInspector.ScriptsPanel.prototype._stepOverClicked):
2843         (WebInspector.ScriptsPanel.prototype._stepIntoClicked):
2844         (WebInspector.ScriptsPanel.prototype._stepOutClicked):
2845         * inspector/front-end/SourceView.js:
2846         (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
2847         (WebInspector.SourceView.prototype.performSearch.findSearchMatches):
2848         (WebInspector.SourceView.prototype.performSearch):
2849         * inspector/front-end/StylesSidebarPane.js:
2850         (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
2851         * inspector/front-end/TestController.js:
2852         (WebInspector.TestController.prototype.notifyDone):
2853         * inspector/front-end/TimelinePanel.js:
2854         (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
2855         * inspector/front-end/WatchExpressionsSidebarPane.js:
2856         (WebInspector.WatchExpressionsSection.prototype.update):
2857         (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions):
2858         (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
2859         * inspector/front-end/WebKit.qrc:
2860         * inspector/front-end/inspector.html:
2861         * inspector/front-end/inspector.js:
2862         (WebInspector.pendingDispatches.0.get platform):
2863         (WebInspector.get port):
2864         (WebInspector.set currentPanel):
2865         (WebInspector._createPanels):
2866         (WebInspector._loadPreferences):
2867         (WebInspector.set attached):
2868         (WebInspector._updateHoverHighlight):
2869         (WebInspector.loaded):
2870         (windowLoaded):
2871         (WebInspector.windowUnload):
2872         (WebInspector.close):
2873         (WebInspector.toolbarDrag):
2874         (WebInspector.UIString):
2875
2876 2009-11-30  Shinichiro Hamaji  <hamaji@chromium.org>
2877
2878         Reviewed by Dan Bernstein.
2879
2880         css2.1/t1205-c566-list-stl-00-e-ag.html is failing
2881         https://bugs.webkit.org/show_bug.cgi?id=23264
2882         css2.1/t1205-c565-list-pos-00-b.html is failing
2883         https://bugs.webkit.org/show_bug.cgi?id=23263
2884
2885         Ignore whitespaces after list markers.
2886         Rendering of this was already done for the case where inside=false.
2887         This fixes the rendering of inside=true case and calcInlinePrefWidths.
2888
2889         Test: fast/lists/calc-width-with-space.html
2890
2891         * rendering/RenderBlock.cpp:
2892         (WebCore::RenderBlock::calcInlinePrefWidths):
2893         * rendering/RenderBlockLineLayout.cpp:
2894         (WebCore::RenderBlock::findNextLineBreak):
2895
2896 2009-11-30  Fumitoshi Ukai  <ukai@chromium.org>
2897
2898         Unreviewed Chromium build fix introduced by r51212
2899
2900         Fix scriptStateFromNode and ScriptStateFromPage to take DOMWrapperWorld
2901         as the first argument.
2902         Move mainThreadNormalWorld() to ScriptState.{h,cpp}.
2903         Add debuggerWorld() and pluginWorld() in ScriptState.h.
2904
2905         * bindings/v8/ScriptController.cpp:
2906         * bindings/v8/ScriptController.h:
2907         * bindings/v8/ScriptState.cpp:
2908         (WebCore::scriptStateFromNode):
2909         (WebCore::scriptStateFromPage):
2910         (WebCore::mainThreadNormalWorld):
2911         * bindings/v8/ScriptState.h:
2912         (WebCore::debuggerWorld):
2913         (WebCore::pluginWorld):
2914
2915 2009-11-30  Enrica Casucci  <enrica@apple.com>
2916
2917         Reviewed by Darin Adler.
2918
2919         Can focus but not type into content editable block that contains only non-editable content.
2920         <rdar://problem/5982901>
2921         https://bugs.webkit.org/show_bug.cgi?id=31750
2922         
2923         The goal is to change the way we choose a visible position
2924         after hit detection, by preferring a visually equivalent editable
2925         position if available. By doing this, it is possible to add content
2926         to an editable block that initially contains only non editable elements.
2927
2928         Test: editing/selection/mixed-editability-10.html
2929
2930         * WebCore.base.exp: Changed to match the new signature of downstream
2931         and upstream in the Position class.
2932         * dom/Position.cpp:
2933         (WebCore::Position::atEditingBoundary): Added.
2934         (WebCore::Position::upstream): Modified to allow to cross the boundary
2935         between editable and non editable content if required.
2936         (WebCore::Position::downstream): Modified to allow to cross the boundary
2937         between editable and non editable content if required.
2938         (WebCore::Position::isCandidate): Modified to qualify as candidates positions
2939         that are at the editability boundary.
2940         (WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
2941         to be used in calculating the caret rectangle.
2942         * dom/Position.h:
2943         (WebCore::Position::):
2944         * dom/PositionIterator.cpp:
2945         (WebCore::PositionIterator::atEditingBoundary): Added.
2946         (WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
2947         that are at the editability boundary.
2948         * dom/PositionIterator.h:
2949         * editing/htmlediting.cpp:
2950         (WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
2951         descendants of the editable container, but the container itself.
2952         (WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
2953         descendants of the editable container, but the container itself.
2954         * rendering/RenderObject.cpp:
2955         (WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
2956         if available.
2957         * rendering/RenderText.cpp:
2958         (WebCore::RenderText::isAllCollapsibleWhitespace): Added.
2959         * rendering/RenderText.h:
2960
2961 2009-11-30  Kevin Ollivier  <kevino@theolliviers.com>
2962
2963         wx build fix, add header needed for wx build.
2964
2965         * css/CSSFontFaceSrcValue.cpp:
2966
2967 2009-11-30  Mark Rowe  <mrowe@apple.com>
2968
2969         Reviewed by David Kilzer.
2970
2971         <rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from a machine that cannot run x86_64 binaries
2972
2973         The check for whether WTF_USE_PLUGIN_HOST_PROCESS is defined occurs under the native architecture of the build machine.
2974         If that is 32-bit then WTF_USE_PLUGIN_HOST_PROCESS will not be defined.  We work around this by forcing the check to
2975         be performed against the x86_64 architecture.
2976
2977         * DerivedSources.make:
2978
2979 2009-11-30  Beth Dakin  <bdakin@apple.com>
2980
2981         Reviewed by Oliver Hunt.
2982
2983         Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in 
2984         Safari caused by extreme column-gap and column-width values 
2985         -and corresponding-
2986         <rdar://problem/7425433>
2987
2988         Prevent desiredColumnCount from being less than 1 since it is used 
2989         as a divisor.
2990         * rendering/RenderBlock.cpp:
2991         (WebCore::RenderBlock::calcColumnWidth):
2992
2993 2009-11-30  Alexey Proskuryakov  <ap@apple.com>
2994
2995         Reviewed by Oliver Hunt.
2996
2997         https://bugs.webkit.org/show_bug.cgi?id=31659
2998         Connection must be closed in case of Web Socket handshake error
2999
3000         The network connection was closed, but the close event wasn't dispatched.
3001
3002         Tested by websocket/tests/handshake-error.html, which is un-skipped now.
3003
3004         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
3005         Call client didHandle() method. This looks strange in CFNetwork implementation, because
3006         it's the client that asked to close the stream, so it shouldn't need the callback. It makes
3007         more sense in cross-process implementation, because closing is async there.
3008
3009 2009-11-30  Gavin Barraclough  <barraclough@apple.com>
3010
3011         Reviewed by Geoff Garen.
3012
3013         Bug 31859 - Make world selection for JSC IsolatedWorlds automagical.
3014
3015         WebCore presently has to explicitly specify the world before entering into JSC,
3016         which is a little fragile (particularly since property access via a
3017         getter/setter might invoke execution). Instead derive the current world from
3018         the lexical global object.
3019
3020         Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
3021         currentWorld().  Switch this to obtain the world from the ExecsState's lexical global
3022         object instead.  Remove the call/construct/evaluate 'InWorld' methods, since these
3023         are no longer necessary.
3024
3025         * WebCore.base.exp:
3026         * bindings/js/JSCallbackData.cpp:
3027         (WebCore::JSCallbackData::invokeCallback):
3028         * bindings/js/JSCallbackData.h:
3029         (WebCore::JSCallbackData::JSCallbackData):
3030         * bindings/js/JSCustomXPathNSResolver.cpp:
3031         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
3032         * bindings/js/JSDOMBinding.cpp:
3033         (WebCore::currentWorld):
3034         (WebCore::mainThreadNormalWorld):
3035         * bindings/js/JSDOMBinding.h:
3036         (WebCore::WebCoreJSClientData::WebCoreJSClientData):
3037         * bindings/js/JSDOMWindowBase.cpp:
3038         (WebCore::JSDOMWindowBase::updateDocument):
3039         * bindings/js/JSDOMWindowBase.h:
3040         * bindings/js/JSEventListener.cpp:
3041         (WebCore::JSEventListener::handleEvent):
3042         (WebCore::JSEventListener::reportError):
3043         * bindings/js/JSHTMLDocumentCustom.cpp:
3044         (WebCore::JSHTMLDocument::open):
3045         * bindings/js/JSNodeFilterCondition.cpp:
3046         (WebCore::JSNodeFilterCondition::acceptNode):
3047         * bindings/js/JSQuarantinedObjectWrapper.cpp:
3048         (WebCore::JSQuarantinedObjectWrapper::construct):
3049         (WebCore::JSQuarantinedObjectWrapper::call):
3050         * bindings/js/ScheduledAction.cpp:
3051         (WebCore::ScheduledAction::executeFunctionInContext):
3052         * bindings/js/ScriptController.cpp:
3053         (WebCore::ScriptController::evaluateInWorld):
3054         (WebCore::ScriptController::initScript):
3055         (WebCore::ScriptController::updateDocument):
3056         * bindings/js/ScriptFunctionCall.cpp:
3057         (WebCore::ScriptFunctionCall::call):
3058         (WebCore::ScriptFunctionCall::construct):
3059         * bindings/js/ScriptObjectQuarantine.cpp:
3060         (WebCore::getQuarantinedScriptObject):
3061         * bindings/js/ScriptState.cpp:
3062         (WebCore::scriptStateFromNode):
3063         (WebCore::scriptStateFromPage):
3064         * bindings/js/ScriptState.h:
3065         * bindings/js/WorkerScriptController.cpp:
3066         (WebCore::WorkerScriptController::evaluate):
3067         * bindings/objc/WebScriptObject.mm:
3068         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3069         (-[WebScriptObject evaluateWebScript:]):
3070         * bridge/NP_jsobject.cpp:
3071         (_NPN_InvokeDefault):
3072         (_NPN_Invoke):
3073         (_NPN_Evaluate):
3074         (_NPN_Construct):
3075         * bridge/jni/jni_jsobject.mm:
3076         (JavaJSObject::call):
3077         (JavaJSObject::eval):
3078         * dom/NodeFilter.h:
3079         (WebCore::NodeFilter::acceptNode):
3080         * dom/NodeIterator.h:
3081         (WebCore::NodeIterator::nextNode):
3082         (WebCore::NodeIterator::previousNode):
3083         * dom/TreeWalker.h:
3084         (WebCore::TreeWalker::parentNode):
3085         (WebCore::TreeWalker::firstChild):
3086         (WebCore::TreeWalker::lastChild):
3087         (WebCore::TreeWalker::previousSibling):
3088         (WebCore::TreeWalker::nextSibling):
3089         (WebCore::TreeWalker::previousNode):
3090         (WebCore::TreeWalker::nextNode):
3091         * inspector/InspectorController.cpp:
3092         (WebCore::InspectorController::windowScriptObjectAvailable):
3093         (WebCore::InspectorController::didEvaluateForTestInFrontend):
3094         * inspector/JavaScriptCallFrame.cpp:
3095         (WebCore::JavaScriptCallFrame::evaluate):
3096
3097 2009-11-30  Eric Carlson  <eric.carlson@apple.com>
3098
3099         Reviewed by Simon Fraser.
3100
3101         All HTML5 media element events should be regular events
3102         https://bugs.webkit.org/show_bug.cgi?id=30513
3103
3104         * html/HTMLMediaElement.cpp:
3105         (WebCore::HTMLMediaElement::selectMediaResource):
3106         (WebCore::HTMLMediaElement::noneSupported):
3107         (WebCore::HTMLMediaElement::mediaEngineError):
3108         (WebCore::HTMLMediaElement::setNetworkState):
3109         (WebCore::HTMLMediaElement::userCancelledLoad):
3110             Call scheduleEvent instead of scheduleProgressEvent.
3111         (WebCore::HTMLMediaElement::progressEventTimerFired):
3112             Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
3113             after scheduling a 'progress' event so the controller will update download
3114             progress indicator.
3115         * html/HTMLMediaElement.h:
3116             Remove scheduleProgressEvent prototype.
3117
3118 2009-11-30  Joseph Pecoraro  <joepeck@webkit.org>
3119
3120         Reviewed by Pavel Feldman.
3121
3122         Web Inspector: Wrong console output for Regexp escape sequence
3123         https://bugs.webkit.org/show_bug.cgi?id=31538
3124
3125         Updated inspector/console-format.html
3126
3127         * inspector/front-end/ConsoleView.js:
3128         (WebInspector.ConsoleView.createDividerElement): style issues.
3129         (WebInspector.ConsoleView.createFilterElement): style issues.
3130         (WebInspector.ConsoleView): added _customFormatters table.
3131         (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses.
3132         (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues.
3133         (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic.
3134         (WebInspector.ConsoleView.prototype._formatobject):
3135         (WebInspector.ConsoleView.prototype._formatnode):
3136         (WebInspector.ConsoleView.prototype._printArray):
3137         (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts.
3138         (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting.
3139         (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting.
3140         (WebInspector.ConsoleCommandResult):
3141         * inspector/front-end/InjectedScript.js: simplified regex formatting.
3142         * inspector/front-end/inspector.js:
3143         (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
3144         * inspector/front-end/utilities.js: 
3145         (Element.prototype.hasStyleClass): update inaccurate comment.
3146         (String.prototype.trimURL): converted new RegExp to literal for performance benefits.
3147
3148 2009-11-30  Erik Arvidsson  <arv@chromium.org>
3149
3150         Reviewed by Adam Barth.
3151
3152         Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
3153         https://bugs.webkit.org/show_bug.cgi?id=31895
3154
3155         No new tests. This is already covered by:
3156                 fast/dom/CSSStyleDeclaration/css-computed-style-item.html
3157                 fast/dom/CSSStyleDeclaration/css-style-item.html
3158
3159         * bindings/v8/V8Collection.h:
3160         (WebCore::collectionStringIndexedPropertyGetter):
3161         (WebCore::setCollectionStringIndexedGetter):
3162         * bindings/v8/V8DOMWrapper.cpp:
3163         (WebCore::V8DOMWrapper::getTemplate):
3164
3165 2009-11-30  Steve Block  <steveblock@google.com>
3166
3167         Reviewed by Eric Seidel.
3168
3169         Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
3170         https://bugs.webkit.org/show_bug.cgi?id=31932
3171
3172         Build fix only, no new tests.
3173
3174         * bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.
3175
3176 2009-11-30  Steve Block  <steveblock@google.com>
3177
3178         Reviewed by Eric Seidel.
3179
3180         Adds PassOwnPtr include to ScriptExecutionContext.h.
3181         https://bugs.webkit.org/show_bug.cgi?id=31929
3182
3183         Build fix only, no new tests.
3184
3185         * dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.
3186
3187 2009-11-30  Dirk Schulze  <krit@webkit.org>
3188
3189         Reviewed by Nikolas Zimmermann.
3190
3191         REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
3192         [https://bugs.webkit.org/show_bug.cgi?id=31980]
3193
3194         It turns out, that we did not handle maskUnits="userSpaceOnUse"
3195         correctly. We just need to move the context of the maskImage
3196         if maskContentUnits="objectBoundingBox". The context gets scaled
3197         on this unit combination, so we have to substract the position of
3198         the targetRect. On userSpaceOnUse the position just depends on the
3199         position of the mask element.
3200         I added a test with some senseless and reasonable values for size
3201         and postion of the mask and it's contents. I also used every
3202         combination of maskUnits and maskContentUnits to be sure, that it
3203         is fixed this time.
3204
3205         Test: svg/custom/mask-with-all-units.svg
3206
3207         * svg/SVGMaskElement.cpp:
3208         (WebCore::SVGMaskElement::drawMaskerContent):
3209
3210 2009-11-30  Steve Block  <steveblock@google.com>
3211
3212         Reviewed by Eric Seidel.
3213
3214         Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
3215         https://bugs.webkit.org/show_bug.cgi?id=31928
3216
3217         Build fix only, no new tests.
3218
3219         * page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
3220
3221 2009-11-30  Steve Block  <steveblock@google.com>
3222
3223         Reviewed by Eric Seidel.
3224
3225         Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
3226         https://bugs.webkit.org/show_bug.cgi?id=31926
3227
3228         Build fix only, no new tests.
3229
3230         * bindings/v8/WorkerContextExecutionProxy.cpp:
3231         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
3232         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
3233         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
3234
3235 2009-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
3236
3237         Reviewed by Kenneth Rohde Christiansen.
3238
3239         Chrome::contentsSizeChanged() is called when the content size has not changed
3240         https://bugs.webkit.org/show_bug.cgi?id=31978
3241
3242         Do not trigger contentsSizeChaned() is the new size is the same as the old one.
3243
3244         * page/FrameView.cpp:
3245         (WebCore::FrameView::setContentsSize):
3246
3247 2009-11-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3248
3249         Reviewed by Kenneth Rohde Christiansen.
3250
3251         [Qt] Fix some compiler warnings seen on QtWebKit/Mac
3252         https://bugs.webkit.org/show_bug.cgi?id=31962
3253
3254         No new tests as there is no functional change.
3255
3256         * platform/network/ResourceHandle.h: Make destructor virtual as 
3257         after r50772 ResourceHandle has virtual functions.
3258
3259         * plugins/mac/PluginPackageMac.cpp: 
3260         (WebCore::PluginPackage::fetchInfo): Fix typo WTF is a namespace
3261         not a label
3262
3263         * plugins/mac/PluginViewMac.cpp:
3264         (WebCore::PluginView::setNPWindowIfNeeded): Add l to the format
3265         specifier
3266
3267 2009-11-30  Xan Lopez  <xlopez@igalia.com>
3268
3269         Reviewed by Gustavo Noronha.
3270
3271         Add new headers to sources list.
3272
3273         * GNUmakefile.am:
3274
3275 2009-11-30  Girish Ramakrishnan  <girish@forwardbias.in>
3276
3277         Reviewed by Holger Freyther.
3278
3279         [Qt] Mac Plugins : Get context menu to work in QGraphicsView
3280         
3281         Flash expects the value in record.where to be the global position for
3282         displaying the context menu.
3283         
3284         https://bugs.webkit.org/show_bug.cgi?id=31979
3285
3286         * plugins/mac/PluginViewMac.cpp:
3287         (WebCore::PluginView::handleMouseEvent):
3288
3289 2009-11-30  Steve Block  <steveblock@google.com>
3290
3291         Reviewed by Eric Seidel.
3292
3293         Adds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController.
3294         https://bugs.webkit.org/show_bug.cgi?id=31925
3295
3296         This code uses ChromiumBridge and Chromium-specific constant values not
3297         appropriate for other platforms such as Android.
3298
3299         Build fix only, no new tests.
3300
3301         * bindings/v8/V8GCController.cpp: Modified. Adds PLATFORM(CHROMIUM) around Chromium-specific code.
3302
3303 2009-11-29  Brent Fulgham  <bfulgham@webkit.org>
3304
3305         Build fix.
3306
3307         Correct draw signature used in ImageCairoWin.cpp.
3308
3309         * platform/graphics/win/ImageCairoWin.cpp:
3310         (WebCore::BitmapImage::getHBITMAPOfSize):
3311         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
3312
3313 2009-11-28  Oliver Hunt  <oliver@apple.com>
3314
3315         Reviewed by Sam Weinig.
3316
3317         postMessage should serialize File objects
3318         https://bugs.webkit.org/show_bug.cgi?id=31955
3319
3320         Update SerializedScriptValue to include support for
3321         File objects in the serialized object graph.
3322
3323         * bindings/js/SerializedScriptValue.cpp:
3324         (WebCore::SerializedScriptValueData::SerializedScriptValueData):
3325         (WebCore::SerializingTreeWalker::convertIfTerminal):
3326         (WebCore::DeserializingTreeWalker::convertIfTerminal):
3327         * bindings/js/SerializedScriptValue.h:
3328         (WebCore::SerializedScriptValueData::):
3329         (WebCore::SerializedScriptValueData::asString):
3330
3331 2009-11-29  Simon Fraser  <simon.fraser@apple.com>
3332
3333         Reviewed by Dan Bernstein.
3334
3335         Optimize the hierarchy rebuilding of compositing layers
3336         https://bugs.webkit.org/show_bug.cgi?id=31879
3337         
3338         When updating the compositing layer hierarchy, instead of removing all
3339         child layers and then re-adding them one by one, build a vector of child
3340         layers, and set them in one go.
3341         
3342         * platform/graphics/GraphicsLayer.h:
3343         * platform/graphics/GraphicsLayer.cpp:
3344         (WebCore::GraphicsLayer::setChildren): New method that takes a Vector of child
3345         GraphicsLayers.
3346         
3347         * platform/graphics/mac/GraphicsLayerCA.h: Override setChildren().
3348         * platform/graphics/win/GraphicsLayerCACF.h: Ditto.
3349         * platform/graphics/mac/GraphicsLayerCA.mm: 
3350         (WebCore::GraphicsLayerCA::setChildren): Implement setChildren() to 
3351         set the bit that notes that sublayers changed.
3352         * platform/graphics/win/GraphicsLayerCACF.cpp:
3353         (WebCore::GraphicsLayerCACF::setChildren): Implement setChildren() to 
3354         udpate sublayers, with a note that this is not efficient.
3355         
3356         * rendering/RenderLayerCompositor.h:
3357         * rendering/RenderLayerCompositor.cpp:
3358         (WebCore::RenderLayerCompositor::updateCompositingLayers):
3359         When updating compositing layers, use the faster updateLayerTreeGeometry() if
3360         we know that no layer hierarchy changes are needed, and, at the root, use
3361         the vector returned from rebuildCompositingLayerTree() to attach the root
3362         layer.
3363         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Changed to
3364         collect child layers into Vectors of GraphicsLayers, which can be set as
3365         layer children in one go.
3366         (WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Split out from
3367         rebuildCompositingLayerTree() for simplicity, and called when we just need to
3368         update layer geometry, without doing any reparenting.
3369
3370 2009-11-29  Daniel Bates  <dbates@webkit.org>
3371
3372         Reviewed by Adam Barth.
3373
3374         https://bugs.webkit.org/show_bug.cgi?id=31971
3375
3376         Updated comment to reflect latest XSSAuditor bindings.
3377
3378         No functionality was changed. So, no new tests.
3379
3380         * page/XSSAuditor.h:
3381
3382 2009-11-29  Daniel Bates  <dbates@webkit.org>
3383
3384         Reviewed by Eric Seidel.
3385
3386         https://bugs.webkit.org/show_bug.cgi?id=31969
3387
3388         Removes unnecessary #include files.
3389
3390         No functionality was changed. So, no new tests.
3391
3392         * css/CSSComputedStyleDeclaration.cpp: Removed include CachedImage.h, and
3393         Pair.h
3394         * css/CSSCursorImageValue.cpp: Removed include RenderStyle.h
3395         * css/CSSFontFaceSrcValue.cpp: Removed include Node.h
3396         * css/CSSFontSelector.cpp: Removed include NodeList.h
3397         * css/CSSGradientValue.cpp: Removed include GraphicsContext.h, ImageBuffer.h
3398         * css/CSSImageValue.cpp: Removed include RenderStyle.h
3399         * css/CSSImportRule.cpp: Removed include MediaList.h
3400         * css/CSSMutableStyleDeclaration.cpp: Removed include CSSProperty.h
3401         * css/CSSRule.cpp: Removed include CSSStyleSheet.h
3402         * css/CSSStyleSelector.cpp: Removed include CSSFontFace.h,
3403         CSSFontFaceSource.h, and CSSProperty.h
3404         * page/EventSource.h: Removed include EventListener.h
3405
3406 2009-11-29  Daniel Bates  <dbates@webkit.org>
3407
3408         Reviewed by Eric Seidel.
3409
3410         https://bugs.webkit.org/show_bug.cgi?id=31965
3411
3412         Removed #include KeyframeList.h from CSSStyleSelector.h. Instead,
3413         forward declared it.
3414
3415         As a side effect, we need to #include KeyframeList.h in
3416         RenderLayerBacking.cpp.
3417
3418         No functionality was changed. So, no new tests.
3419
3420         * css/CSSStyleSelector.cpp:
3421         * css/CSSStyleSelector.h: Removed #include KeyframeList.h
3422         * rendering/RenderLayerBacking.cpp: Added #include KeyframeList.h
3423
3424 2009-11-29  Shu Chang  <Chang.Shu@nokia.com>
3425
3426         Reviewed by Eric Seidel.
3427
3428         Continue to search for matching node in the case where multiple nodes
3429         have the same id.
3430         https://bugs.webkit.org/show_bug.cgi?id=31428
3431
3432         Test: fast/dom/Element/id-in-node-list-index01.html
3433
3434         * dom/DynamicNodeList.cpp:
3435         (WebCore::DynamicNodeList::itemWithName):
3436
3437 2009-11-29  Daniel Bates  <dbates@webkit.org>
3438
3439         Reviewed by Eric Seidel.
3440
3441         https://bugs.webkit.org/show_bug.cgi?id=31966
3442
3443         Removed #include RenderStyle.h from file KeyframeAnimation.h. Instead,
3444         forward declared it.
3445
3446         No functionality was changed. So, no new tests.
3447
3448         * page/animation/KeyframeAnimation.cpp:
3449         * page/animation/KeyframeAnimation.h:
3450
3451 2009-11-29  Daniel Bates  <dbates@webkit.org>
3452
3453         Unreviewed, fix change log entry date.
3454
3455         For some reason, bugzilla-tool did not update the date in the change
3456         log entry for my last commit (r51468). So, this commit fixes the date
3457         of that entry.
3458
3459 2009-11-29  Daniel Bates  <dbates@webkit.org>
3460
3461         Reviewed by Dan Bernstein.
3462
3463         https://bugs.webkit.org/show_bug.cgi?id=31964
3464
3465         Removed #include StringImpl, StyleImage. Instead, forward declared them.
3466         Also, we can substitute #include <wtf/PassRefPtr.h> for #include PlatformString.h,
3467         since it seems we only really used it to include PassRefPtr.h.
3468
3469         No functionality was changed. So, no new tests.
3470
3471         * rendering/style/ContentData.h:
3472
3473 2009-11-29  Zoltan Horvath  <zoltan@webkit.org>
3474
3475         Reviewed by Eric Seidel.
3476
3477         Allow custom memory allocation control for classes of the rendering and storage directory in WebCore
3478         https://bugs.webkit.org/show_bug.cgi?id=31906
3479
3480         Inherits the following classes from Noncopyable because these are instantiated
3481         by 'new' and no need to be copyable:
3482
3483         class/struct name               - instantiated at: WebCore/'location'
3484
3485         class SQLTransactionClient      - storage/DatabaseThread.cpp:45
3486         class SQLTransactionCoordinator - storage/DatabaseThread.cpp:46
3487         class OriginUsageRecord         - storage/OriginQuotaManager.cpp:66
3488         class DatabaseTracker           - storage/DatabaseTracker.cpp:62
3489         class ScrollbarTheme            - (its child class) rendering/RenderScrollbarTheme.cpp:35
3490         class RenderSelectionInfoBase   - (its child class) rendering/RenderView.cpp:310
3491         class RenderOverflow            - rendering/RenderBox.cpp:2846
3492
3493         Inherits the following classes from FastAllocBase because these are instantiated by 'new':
3494
3495         struct FillLayer                - css/CSSStyleSelector.cpp:197
3496         struct ShadowData               - rendering/style/ShadowData.cpp:35
3497         class CounterContent            - css/CSSStyleSelector.cpp:4111
3498
3499         * platform/ScrollbarTheme.h:
3500         * rendering/RenderOverflow.h:
3501         * rendering/RenderSelectionInfo.h:
3502         * rendering/style/CounterContent.h:
3503         * rendering/style/FillLayer.h:
3504         * rendering/style/ShadowData.h:
3505         * storage/DatabaseTracker.h:
3506         * storage/OriginUsageRecord.h:
3507         * storage/SQLTransactionClient.h:
3508         * storage/SQLTransactionCoordinator.h:
3509
3510 2009-11-28  Adam Barth  <abarth@webkit.org>
3511
3512         Reviewed by Dimitri Glazkov.
3513
3514         [Chromium] Sify compose button alerts error
3515         https://bugs.webkit.org/show_bug.cgi?id=31394
3516
3517         Test: http/tests/security/calling-versus-current.html
3518
3519         We're supposed to use the calling context for security checks.  In JSC
3520         land, this is the lexicalGlobalObject.
3521
3522         * bindings/v8/V8Proxy.cpp:
3523         (WebCore::V8Proxy::canAccessPrivate):
3524
3525 2009-11-27  Shinichiro Hamaji  <hamaji@chromium.org>
3526
3527         Unreviewed Chromium build fix introduced by r51428.
3528
3529         [Chromium] Ignore line-height CSS property for PushButton
3530         https://bugs.webkit.org/show_bug.cgi?id=31712
3531
3532         * rendering/RenderThemeChromiumSkia.cpp:
3533         (WebCore::RenderThemeChromiumSkia::adjustButtonStyle):
3534
3535 2009-11-27  Shinichiro Hamaji  <hamaji@chromium.org>
3536
3537         Unreviewed Chromium test fix by reverting r51413.
3538
3539         [v8] Do not check the thread when accessing DOMDataStore
3540         https://bugs.webkit.org/show_bug.cgi?id=31877
3541
3542         * bindings/v8/V8DOMMap.cpp:
3543         (WebCore::getDOMNodeMap):
3544         (WebCore::getDOMObjectMap):
3545         (WebCore::getActiveDOMObjectMap):
3546         (WebCore::getDOMSVGElementInstanceMap):
3547         (WebCore::getDOMSVGObjectWithContextMap):
3548
3549 2009-11-27  Daniel Bates  <dbates@webkit.org>
3550
3551         Unreviewed, comment fix.
3552
3553         Corrected misspelling of the word "implemented".
3554
3555         * inspector/front-end/InjectedScriptAccess.js:
3556
3557 2009-11-27  Daniel Bates  <dbates@webkit.org>
3558
3559         Reviewed by Adam Barth.
3560
3561         https://bugs.webkit.org/show_bug.cgi?id=31940
3562
3563         Makes the error messages more descriptive when we refuse to load an object/embed or
3564         refuse to load from the document base URL.
3565
3566         * page/XSSAuditor.cpp:
3567         (WebCore::XSSAuditor::canLoadObject): Changed console message to be more descriptive.
3568         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
3569
3570 2009-11-27  Yury Semikhatsky  <yurys@chromium.org>
3571
3572         Reviewed by Pavel Feldman.
3573
3574         This is a WebCore part of the fix that allows to view plugin
3575         resources loaded by plugins.
3576
3577         https://bugs.webkit.org/show_bug.cgi?id=31832
3578
3579         * inspector/InspectorController.cpp:
3580         (WebCore::InspectorController::willSendRequest):
3581         (WebCore::InspectorController::didReceiveResponse):
3582         (WebCore::InspectorController::didReceiveContentLength):
3583         (WebCore::InspectorController::didFinishLoading):
3584         (WebCore::InspectorController::didFailLoading):
3585         * inspector/InspectorController.h:
3586         * inspector/InspectorResource.cpp:
3587         (WebCore::InspectorResource::addLength):
3588         * loader/ResourceLoadNotifier.cpp: