9f8d97257c663e08d19a5213d655934a5aa3ea5a
[WebKit-https.git] / WebCore / ChangeLog
1 2011-01-04  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Xan Lopez.
4
5         [GTK] Port stock icon painting to GtkStyleContext
6         https://bugs.webkit.org/show_bug.cgi?id=51764
7
8         Port stock icon painting for media and search input elements to
9         GtkStyleContext. Also create the initial machinery for accessing
10         style contexts for all GTK+ 3.x based widgets.
11
12         No new tests. This should not change functionality.
13
14         * platform/gtk/RenderThemeGtk.cpp:
15         (WebCore::paintGdkPixbuf):
16         (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
17         (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
18         (WebCore::RenderThemeGtk::paintMediaButton):
19         * platform/gtk/RenderThemeGtk.h:
20         * platform/gtk/RenderThemeGtk2.cpp:
21         (WebCore::RenderThemeGtk::getStockIcon):
22         * platform/gtk/RenderThemeGtk3.cpp:
23         (WebCore::gtkStyleChangedCallback):
24         (WebCore::styleContextMap):
25         (WebCore::getStyleContext):
26         (WebCore::RenderThemeGtk::paintMenuList):
27
28 2010-12-31  Antti Koivisto  <antti@apple.com>
29
30         Reviewed by Dave Hyatt.
31
32         Scripts should not be executed before preceding stylesheets are loaded
33         https://bugs.webkit.org/show_bug.cgi?id=8852
34
35         Block inline script execution on pending stylesheet loads. This matches
36         other browsers and HTML5.
37
38         Tests: fast/tokenizer/inline-script-stylesheet-write.html
39                fast/tokenizer/inline-script-stylesheet.html
40
41         * dom/PendingScript.cpp:
42         (WebCore::PendingScript::releaseElementAndClear):
43         * dom/PendingScript.h:
44         (WebCore::PendingScript::PendingScript):
45         (WebCore::PendingScript::operator=):
46         (WebCore::PendingScript::startingPosition):
47         (WebCore::PendingScript::setStartingPosition):
48         * html/HTMLLinkElement.cpp:
49         (WebCore::HTMLLinkElement::process):
50         
51         This fixes an unrelated bug with beforeload events that was exposed by the other
52         changes (fast/dom/beforeload/remove-link-in-beforeload-listener.html).
53         
54         * html/parser/HTMLScriptRunner.cpp:
55         (WebCore::HTMLScriptRunner::sourceFromPendingScript):
56         (WebCore::HTMLScriptRunner::runScript):
57
58 2011-01-04  Xianzhu Wang  <wangxianzhu@google.com>
59
60         Reviewed by Darin Adler.
61
62         Let DataView.getInt8() and DataView.setInt8() use int8_t instead of
63         ambiguous 'char' to fix fast/canvas/webgl/data-view-test.html failure
64         on ARM.
65         https://bugs.webkit.org/show_bug.cgi?id=51861
66
67         By the way, changed other getIntXX() and setIntXX() methods to use
68         more precise integer types.
69
70         * bindings/js/JSDataViewCustom.cpp:
71         (WebCore::setDataViewMember):
72         * bindings/v8/custom/V8DataViewCustom.cpp:
73         (WebCore::V8DataView::getInt8Callback):
74         (WebCore::V8DataView::setInt8Callback):
75         * html/canvas/DataView.cpp:
76         (WebCore::DataView::getInt8):
77         (WebCore::DataView::setInt8):
78         * html/canvas/DataView.h:
79         * html/canvas/DataView.idl:
80
81 2011-01-04  Yong Li  <yoli@rim.com>
82
83         Reviewed by Adam Barth.
84
85         Suspend HTMLParserScheduler when page load is deferred to
86         avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
87         from an external script or by events, and is blocked by a modal dialog,
88         WebKit can parse more HTML source and also start another JS execution.
89         
90         https://bugs.webkit.org/show_bug.cgi?id=48077
91
92         Test case: WebCore/manual-tests/bugzilla-48077.html.
93
94         * dom/DocumentParser.cpp:
95         (WebCore::DocumentParser::suspendScheduledTasks):
96         (WebCore::DocumentParser::resumeScheduledTasks):
97         * dom/DocumentParser.h:
98         * html/parser/HTMLDocumentParser.cpp:
99         (WebCore::HTMLDocumentParser::suspendScheduledTasks):
100         (WebCore::HTMLDocumentParser::resumeScheduledTasks):
101         * html/parser/HTMLParserScheduler.cpp:
102         (WebCore::HTMLParserScheduler::HTMLParserScheduler):
103         (WebCore::HTMLParserScheduler::suspend):
104         (WebCore::HTMLParserScheduler::resume):
105         * html/parser/HTMLParserScheduler.h:
106         (WebCore::HTMLParserScheduler::isScheduledForResume):
107         * page/PageGroupLoadDeferrer.cpp:
108         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
109         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
110
111 2011-01-04  Tony Gentilcore  <tonyg@chromium.org>
112
113         Unreviewed build fix.
114
115         Include glib-object.h for GObject
116         https://bugs.webkit.org/show_bug.cgi?id=51876
117
118         * bindings/gobject/DOMObjectCache.cpp:
119
120 2011-01-04  Ryosuke Niwa  <rniwa@webkit.org>
121
122         Reviewed by Dan Bernstein.
123
124         Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
125         https://bugs.webkit.org/show_bug.cgi?id=50992
126
127         Fixed the bug by interchanging the offset when the direction of inline text box and the containing block
128         does not match. Reused the code added by http://trac.webkit.org/changeset/73553.
129
130         Test: editing/selection/caret-bidi-first-and-last-letters.html
131
132         * rendering/InlineTextBox.cpp:
133         (WebCore::InlineTextBox::offsetForPosition):
134
135 2010-12-29  Tony Gentilcore  <tonyg@chromium.org>
136
137         Reviewed by Darin Adler.
138
139         Remove 2 unnecessary includes from Document.h
140         https://bugs.webkit.org/show_bug.cgi?id=51727
141
142         No new tests because no changed functionality.
143
144         * dom/Document.cpp:
145         * dom/Document.h:
146         * editing/Editor.cpp:
147         * editing/SpellChecker.h:
148         * editing/SplitTextNodeCommand.cpp:
149         * editing/TextCheckingHelper.cpp:
150         * page/FrameView.cpp:
151         * page/Page.cpp:
152         * rendering/HitTestResult.cpp:
153         * rendering/InlineTextBox.cpp:
154         * rendering/InlineTextBox.h:
155         * rendering/svg/SVGInlineFlowBox.cpp:
156
157 2011-01-04  Patrick Gansterer  <paroga@webkit.org>
158
159         Unreviewed WinCE build fix.
160
161         * CMakeListsWinCE.txt: Added missing include directories, files and libraries.
162
163 2011-01-04  Yi Shen  <yi.4.shen@nokia.com>
164
165         Reviewed by Simon Hausmann.
166
167         Provide an interface to require using fullscreen mediaplayer
168         https://bugs.webkit.org/show_bug.cgi?id=51133
169
170         Only video should be displayed in fullscreen when 
171         requiresFullscreenForVideoPlayback is specified.
172
173         No new tests because no client implements requiresFullscreenForVideoPlayback yet.
174
175         * html/HTMLMediaElement.cpp:
176         (WebCore::HTMLMediaElement::updatePlayState):
177
178 2011-01-04  Benjamin Poulain  <benjamin.poulain@nokia.com>
179
180         Reviewed by Kenneth Rohde Christiansen.
181
182         [Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
183         https://bugs.webkit.org/show_bug.cgi?id=51825
184
185         Implement contextMenuItemVector() for Qt, this method is used in WebKit 2 to get the
186         platform independent menu informations.
187
188         * platform/qt/ContextMenuQt.cpp:
189         (WebCore::contextMenuItemVector):
190
191 2011-01-04  Sheriff Bot  <webkit.review.bot@gmail.com>
192
193         Unreviewed, rolling out r74960.
194         http://trac.webkit.org/changeset/74960
195         https://bugs.webkit.org/show_bug.cgi?id=51868
196
197         Rollout since we hit an assert after this patch. (Requested by
198         krit on #webkit).
199
200         * svg/SVGUseElement.cpp:
201         (WebCore::SVGUseElement::buildInstanceTree):
202
203 2011-01-04  Sheriff Bot  <webkit.review.bot@gmail.com>
204
205         Unreviewed, rolling out r74961.
206         http://trac.webkit.org/changeset/74961
207         https://bugs.webkit.org/show_bug.cgi?id=51867
208
209         breaks 32/64-bits debug bots build (Requested by philn-tp on
210         #webkit).
211
212         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
213         (WebCore::GStreamerGWorld::setWindowOverlay):
214
215 2011-01-03  Philippe Normand  <pnormand@igalia.com>
216
217         Rubber-stamped by Eric Seidel.
218
219         [GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
220         https://bugs.webkit.org/show_bug.cgi?id=51810
221
222         Based on a patch by Mart Raudsepp.
223
224         No new tests, build fix only.
225
226         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
227         (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay
228         API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was
229         introduced in same version as the xoverlay API change.
230
231 2011-01-04  Leo Yang  <leo.yang@torchmobile.com.cn>
232
233         Reviewed by Dirk Schulze.
234
235         Malformed SVG causes crash in updateContainerOffset
236         https://bugs.webkit.org/show_bug.cgi?id=44610
237
238         We should check recursive <use> at the begining of
239         WebCore::SVGUseElement::buildInstanceTree instead
240         of at the end of it because the target element's
241         children may cause infinite recursive <use>.
242
243         Test: svg/custom/recursive-use.svg
244
245         * svg/SVGUseElement.cpp:
246         (WebCore::SVGUseElement::buildInstanceTree):
247
248 2011-01-04  Kent Tamura  <tkent@chromium.org>
249
250         Unreviewed, build fix.
251
252         Try to fix Clang build.
253
254         * css/CSSParser.cpp:
255         (WebCore::valueFromSideKeyword):
256         (WebCore::CSSParser::parseLinearGradient):
257
258 2011-01-03  Julie-Jeongeun-Kim  <Jeongeun.Kim@obigo.com>
259
260         Reviewed by Darin Adler.
261
262         HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
263         https://bugs.webkit.org/show_bug.cgi?id=48596
264         
265         border attribute was not parsed in HTMLObjectElement.
266         I added code for it as HTMLImageElement handled.
267
268         new test:fast/html/object-border.html
269
270         * html/HTMLObjectElement.cpp:
271         (WebCore::HTMLObjectElement::parseMappedAttribute):
272
273 2011-01-03  Darin Adler  <darin@apple.com>
274
275         Try to fix Chromium build.
276
277         * history/HistoryItem.cpp:
278         (WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here.
279         Not sure this ever will be used with V8.
280         (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
281
282 2011-01-03  Darin Adler  <darin@apple.com>
283
284         Try to fix Leopard build.
285
286         * history/HistoryItem.cpp: Use a consistent type, uint64_t, for the
287         size variable.
288
289 2011-01-03  Abhishek Arya  <inferno@chromium.org>
290
291         Reviewed by Darin Adler.
292
293         Fixes before child calculation when adding anonymous childs to table parts.
294         https://bugs.webkit.org/show_bug.cgi?id=50932
295
296         Fix in r74364 was incomplete. When before child is equal to the table part(to
297         which the new child is getting added), it confuses the table part to add it
298         incorrectly as an after child. The patch fixes by passing the before child as
299         the table part's first child.
300
301         Tests: fast/css-generated-content/table-before-after-child-add.html
302                fast/css-generated-content/table-cell-before-after-child-add.html
303                fast/css-generated-content/table-row-before-after-child-add.html
304                fast/css-generated-content/table-row-before-after-child-add.html
305
306         * rendering/RenderTable.cpp:
307         (WebCore::RenderTable::addChild):
308         * rendering/RenderTableRow.cpp:
309         (WebCore::RenderTableRow::addChild):
310         * rendering/RenderTableSection.cpp:
311         (WebCore::RenderTableSection::addChild):
312
313 2011-01-03  Dan Bernstein  <mitz@apple.com>
314
315         Reviewed by Simon Fraser.
316
317         Shrink HTMLTableCellElement
318         https://bugs.webkit.org/show_bug.cgi?id=51858
319
320         * html/HTMLTableCellElement.cpp:
321         (WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
322         m_col.
323         * html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.
324
325 2011-01-03  Darin Adler  <darin@apple.com>
326
327         Fix build.
328
329         * platform/network/FormData.cpp:
330         (WebCore::FormData::create): Roll back uint8_t change.
331         (WebCore::FormData::flatten): Ditto.
332         (WebCore::FormData::flattenToString): Ditto.
333         (WebCore::encode): Ditto.
334         (WebCore::decode): Ditto.
335         (WebCore::FormData::encodeForBackForward):
336         * platform/network/FormData.h: Ditto.
337         * platform/network/mac/FormDataStreamMac.mm:
338         (WebCore::advanceCurrentStream): Ditto.
339
340 2011-01-03  Darin Adler  <darin@apple.com>
341
342         Reviewed by Brady Eidson.
343
344         Add code to encode/decode the back/forward tree
345         https://bugs.webkit.org/show_bug.cgi?id=51853
346
347         * history/HistoryItem.cpp:
348         (WebCore::HistoryItem::encodeBackForwardTree): Added.
349         (WebCore::HistoryItem::encodeBackForwardTreeNode): Added.
350         (WebCore::HistoryItem::decodeBackForwardTree): Added.
351         * history/HistoryItem.h: Added functions above.
352
353         * platform/network/FormData.cpp:
354         (WebCore::FormData::create): Changed type to Vector<uint8_t> instead of
355         Vector<char>. This type is used in our newer code for vectors of bytes.
356         (WebCore::FormData::flatten): Ditto.
357         (WebCore::FormData::flattenToString): Ditto. Had to add a cast here.
358         (WebCore::FormData::encodeForBackForward): Added.
359         (WebCore::FormData::decodeForBackForward): Added.
360         * platform/network/FormData.h: Changed type to Vector<uint8_t> instead of
361         Vector<char>. Also made some single-argument constructors explicit.
362         Also added the new functions.
363
364         * platform/network/mac/FormDataStreamMac.mm:
365         (WebCore::advanceCurrentStream): Changed to use uint8_t to match above.
366
367 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
368
369         Attempt to fix GTK build.
370
371         * platform/graphics/gtk/FontGtk.cpp:
372         (WebCore::drawGlyphsShadow):
373
374 2011-01-03  Helder Correia  <helder@sencha.com>
375
376         Reviewed by Simon Fraser.
377
378         ContextShadow can avoid code duplication for getting the CTM
379         https://bugs.webkit.org/show_bug.cgi?id=51799
380
381         ContextShadow defines its own getTransformationMatrixFromContext()
382         which does exactly the same as GraphicsContext::getCTM().
383
384         Existing tests: fast/canvas/canvas*shadow*html
385
386         * platform/graphics/ContextShadow.cpp:
387         (WebCore::ContextShadow::mustUseContextShadow):
388         (WebCore::ContextShadow::adjustBlurDistance):
389         (WebCore::ContextShadow::calculateLayerBoundingRect):
390         * platform/graphics/ContextShadow.h:
391         * platform/graphics/cairo/ContextShadowCairo.cpp:
392         (WebCore::ContextShadow::beginShadowLayer):
393         (WebCore::ContextShadow::endShadowLayer):
394         (WebCore::ContextShadow::drawRectShadowWithoutTiling):
395         * platform/graphics/cairo/FontCairo.cpp:
396         (WebCore::drawGlyphsShadow):
397         * platform/graphics/cairo/GraphicsContextCairo.cpp:
398         (WebCore::drawPathShadow):
399         * platform/graphics/cairo/ImageCairo.cpp:
400         (WebCore::BitmapImage::draw):
401         * platform/graphics/gtk/FontGtk.cpp:
402         (WebCore::drawGlyphsShadow):
403         * platform/graphics/qt/ContextShadowQt.cpp:
404         (WebCore::ContextShadow::beginShadowLayer):
405         (WebCore::ContextShadow::endShadowLayer):
406         * platform/graphics/qt/FontQt.cpp:
407         (WebCore::drawTextCommon):
408         * platform/graphics/qt/GraphicsContextQt.cpp:
409         (WebCore::GraphicsContext::fillPath):
410         (WebCore::GraphicsContext::strokePath):
411         (WebCore::GraphicsContext::fillRect):
412         (WebCore::GraphicsContext::fillRoundedRect):
413         * platform/graphics/qt/ImageQt.cpp:
414         (WebCore::BitmapImage::draw):
415         * platform/graphics/qt/StillImageQt.cpp:
416         (WebCore::StillImage::draw):
417
418 2011-01-03  Darin Adler  <darin@apple.com>
419
420         Reviewed by Dan Bernstein.
421
422         InsertTextCommand::m_charactersAdded is unused
423         https://bugs.webkit.org/show_bug.cgi?id=51849
424
425         * editing/InsertTextCommand.cpp:
426         (WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded.
427         (WebCore::InsertTextCommand::input): Don't update m_charactersAdded.
428         * editing/InsertTextCommand.h: Removed charactersAdded function and
429         m_charactersAdded data member.
430
431 2011-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
432
433         Reviewed by Martin Robinson.
434
435         [GTK] Move paintMenuListButton() to RenderThemeGtk.cpp
436         https://bugs.webkit.org/show_bug.cgi?id=51832
437
438         Method paintMenuListButton() contains code common to both gtk 2
439         and 3, so it can be moved to RenderThemeGtk.cpp instead of
440         duplicating it.
441
442         * platform/gtk/RenderThemeGtk.cpp:
443         (WebCore::RenderThemeGtk::paintMenuListButton):
444         * platform/gtk/RenderThemeGtk2.cpp:
445         * platform/gtk/RenderThemeGtk3.cpp:
446
447 2011-01-03  Pratik Solanki  <psolanki@apple.com>
448
449         Reviewed by Darin Adler.
450
451         https://bugs.webkit.org/show_bug.cgi?id=51850
452         Put CFNetwork loader code inside USE(CFNETWORK)
453
454         Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
455         files to the WebCore Xcode project.
456
457         * WebCore.xcodeproj/project.pbxproj:
458         * loader/cf/ResourceLoaderCFNet.cpp:
459         * loader/mac/ResourceLoaderMac.mm:
460         * platform/network/cf/AuthenticationCF.cpp:
461         * platform/network/cf/AuthenticationCF.h:
462         * platform/network/cf/CookieJarCFNet.cpp:
463         * platform/network/cf/CookieStorageCFNet.cpp:
464         * platform/network/cf/CookieStorageCFNet.h:
465         * platform/network/cf/CredentialStorageCFNet.cpp:
466         * platform/network/cf/FormDataStreamCFNet.cpp:
467         * platform/network/cf/FormDataStreamCFNet.h:
468         * platform/network/cf/LoaderRunLoopCF.cpp:
469         * platform/network/cf/LoaderRunLoopCF.h:
470         * platform/network/cf/ResourceError.h:
471         * platform/network/cf/ResourceHandleCFNet.cpp:
472         * platform/network/cf/ResourceRequest.h:
473         * platform/network/cf/ResourceRequestCFNet.cpp:
474         * platform/network/cf/ResourceRequestCFNet.h:
475         * platform/network/cf/ResourceResponse.h:
476         * platform/network/cf/ResourceResponseCFNet.cpp:
477         * platform/network/mac/AuthenticationMac.h:
478         * platform/network/mac/AuthenticationMac.mm:
479         * platform/network/mac/FormDataStreamMac.h:
480         * platform/network/mac/FormDataStreamMac.mm:
481         * platform/network/mac/ResourceError.h:
482         * platform/network/mac/ResourceHandleMac.mm:
483         * platform/network/mac/ResourceRequest.h:
484         * platform/network/mac/ResourceRequestMac.mm:
485         * platform/network/mac/ResourceResponse.h:
486         * platform/network/mac/ResourceResponseMac.mm:
487
488 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
489
490         Reviewed by Adam Barth.
491
492         [Qt] Add SelectAll option to the context menu for the editor
493         https://bugs.webkit.org/show_bug.cgi?id=50049
494
495         Enable SelectAll for the Qt context menu.
496
497         * page/ContextMenuController.cpp:
498         (WebCore::ContextMenuController::populate):
499         * platform/ContextMenuItem.h:
500         * platform/LocalizationStrategy.h:
501         * platform/LocalizedStrings.cpp:
502         (WebCore::contextMenuItemTagSelectAll):
503         * platform/LocalizedStrings.h:
504
505 2011-01-03  Dan Bernstein  <mitz@apple.com>
506
507         Reviewed by Darin Adler.
508
509         Shrink RootInlineBox
510         https://bugs.webkit.org/show_bug.cgi?id=51847
511
512         * rendering/RootInlineBox.cpp:
513         (WebCore::RootInlineBox::alignBoxesInBlockDirection): Changed to use the baselineType()
514         accessor.
515         * rendering/RootInlineBox.h: Rolled m_baselineType into a bitfield. Changed its type to
516         unsigned because otherwise MSVC treats it as signed.
517         (WebCore::RootInlineBox::baselineType): Added a cast.
518
519 2011-01-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
520
521         Reviewed by Martin Robinson.
522
523         [GTK] Split webkitprivate.{cpp,h} in more manageable chunks
524         https://bugs.webkit.org/show_bug.cgi?id=50698
525
526         Fix DOM bindings generation to no longer include the now-gone
527         webkitprivate.h header, including the appropriate replacements
528         instead.
529
530         * bindings/scripts/CodeGeneratorGObject.pm:
531
532 2011-01-03  Brady Eidson  <beidson@apple.com>
533
534         Reviewed by Darin Adler.
535
536         Add Encode/Decode machinery Darin and I plan to work with for back/forward stuff in WebKit2.
537
538         * ForwardingHeaders/wtf/Decoder.h: Added.
539         * ForwardingHeaders/wtf/Encoder.h: Added.
540
541 2011-01-03  Chris Fleizach  <cfleizach@apple.com>
542
543         Reviewed by Darin Adler.
544
545         AX: Regression: WebKit no longer auto-scrolls with VoiceOver navigation
546         https://bugs.webkit.org/show_bug.cgi?id=51833
547
548         Make sure the web area returns the contentsSize, not the same size as what is displayed.
549
550         Test: platform/mac/accessibility/webarea-size-equals-content-size.html
551
552         * accessibility/AccessibilityRenderObject.cpp:
553         (WebCore::AccessibilityRenderObject::boundingBoxRect):
554
555 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
556
557         Fix warning in 32-bit builds.
558
559         * css/CSSGradientValue.cpp:
560         (WebCore::CSSLinearGradientValue::createGradient):
561
562 2011-01-03  Benjamin C Meyer  <bmeyer@rim.com>
563
564         Reviewed by Daniel Bates.
565
566         In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.
567         https://bugs.webkit.org/show_bug.cgi?id=51827
568
569         * CMakeLists.txt:
570
571 2011-01-03  Dan Bernstein  <mitz@apple.com>
572
573         Reviewed by Simon Fraser.
574
575         Remove the unused RenderTableCell::m_percentageHeight
576         https://bugs.webkit.org/show_bug.cgi?id=51837
577
578         * rendering/RenderTableCell.cpp:
579         (WebCore::RenderTableCell::RenderTableCell): Removed initialization of m_percentageHeight.
580         * rendering/RenderTableCell.h: Removed m_percentageHeight.
581
582 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
583
584         Reviewed by David Hyatt.
585
586         Implement -webkit-linear-gradient and -webkit-radial-gradient
587         https://bugs.webkit.org/show_bug.cgi?id=28152
588
589         Add support for -webkit-radial-gradients.
590
591         Tests: fast/gradients/css3-radial-gradients.html
592                fast/gradients/css3-radial-gradients2.html
593
594         * css/CSSGradientValue.cpp:
595         (WebCore::blend): Used to blend colors, which is necessary when truncating
596         the start of radial gradients.
597         (WebCore::GradientStop): Small struct to aid gradient stop processing.
598         (WebCore::CSSGradientValue::addStops): Rename 'positions' to 'stops', and store
599         the color so that we can blend it when truncating radial gradients. Changed
600         to handle both linear and radial gradients.
601         (WebCore::CSSRadialGradientValue::cssText): Update to follow the spec.
602         (WebCore::CSSRadialGradientValue::resolveRadius): Stylistic change.
603         (WebCore::distanceToClosestCorner): New utility method.
604         (WebCore::distanceToFarthestCorner): Ditto.
605         (WebCore::CSSRadialGradientValue::createGradient): New logic to deal with shape and
606         fill rules.
607
608         * css/CSSGradientValue.h:
609         (WebCore::CSSGradientValue::isLinearGradient): Color-stop processing needs to know what
610         kind of gradient it's dealing with, so add new isFooGradient methods.
611         (WebCore::CSSGradientValue::isRadialGradient): Ditto.
612         (WebCore::CSSLinearGradientValue::isLinearGradient):
613         (WebCore::CSSRadialGradientValue::setShape): New setters for shape, size etc.
614         (WebCore::CSSRadialGradientValue::setSizingBehavior):
615         (WebCore::CSSRadialGradientValue::setEndHorizontalSize):
616         (WebCore::CSSRadialGradientValue::setEndVerticalSize):
617         (WebCore::CSSRadialGradientValue::isRadialGradient):
618
619         * css/CSSParser.h:
620         * css/CSSParser.h: Pass a CSSParserValueList* into parseFillPositionXY() and parseFillPosition()
621         so we can use parseFillPosition() when parsing a gradient function.
622         * css/CSSParser.cpp:
623         (WebCore::CSSParser::parseFillPositionXY): Pass in a CSSParserValueList*
624         (WebCore::CSSParser::parseFillPosition): Ditto
625         (WebCore::CSSParser::parseFillProperty): Pass m_valueList to parseFillPosition.
626         (WebCore::CSSParser::parseTransformOriginShorthand): Ditto
627         (WebCore::CSSParser::parseRadialGradient): Flesh out radial gradient parsing.
628         (WebCore::CSSParser::parseTransformOrigin): Pass m_valueList to parseFillPosition.
629         (WebCore::CSSParser::parsePerspectiveOrigin): Ditto
630
631         * css/CSSValueKeywords.in: New keywords for radial gradient shape and fill behaviors.
632
633         * platform/graphics/Gradient.cpp:
634         (WebCore::Gradient::Gradient): Pass aspect ratio for elliptical gradients.
635         * platform/graphics/Gradient.h: Add aspect ratio for elliptical gradients.
636         (WebCore::Gradient::create):
637         (WebCore::Gradient::startRadius): Expose radii.
638         (WebCore::Gradient::endRadius):
639         (WebCore::Gradient::setStartRadius): Setters are required for when we need to scale color stops.
640         (WebCore::Gradient::setEndRadius):
641         (WebCore::Gradient::aspectRatio):
642         * platform/graphics/cg/GradientCG.cpp:
643         (WebCore::Gradient::paint): For elliptical gradients, scale the CTM.
644         * platform/graphics/wince/GraphicsContextWinCE.cpp:
645         (WebCore::GraphicsContext::fillRect): Use start/endRadius() rather than r0() and r1().
646
647 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
648
649         Reviewed by David Hyatt.
650
651         Implement -webkit-linear-gradient and -webkit-radial-gradient
652         https://bugs.webkit.org/show_bug.cgi?id=28152
653         
654         Add support for the parsing and rendering of non-repeating CSS3 linear gradients,
655         according to <http://dev.w3.org/csswg/css3-images/#linear-gradients>.
656
657         Tests: fast/gradients/css3-color-stop-units.html
658                fast/gradients/css3-color-stops.html
659                fast/gradients/css3-gradient-parsing.html
660                fast/gradients/css3-linear-angle-gradients.html
661
662         * css/CSSGradientValue.h:
663         Add subclasses of CSSGradientValue for linear and radial gradients.
664         
665         * css/CSSGradientValue.cpp:
666         (WebCore::CSSGradientValue::image): Add FIXME comment about why we can't cache
667         the gradient sometimes.
668         (WebCore::compareStops): positions are CSSValues now.
669         (WebCore::CSSGradientValue::sortStopsIfNeeded): Add assertion that this is only called
670         for old-style gradients.
671         (WebCore::CSSGradientValue::addStops): New method that handles the spec rules about
672         missing positions, ensuring that stop position is ordered, and spacing out stops
673         without positions. Also normalize gradients which use stops outside the 0-1 range
674         so that platforms can render them correctly.
675         (WebCore::positionFromValue): Determin the position on the gradient line for percentage,
676         number and length values.
677         (WebCore::CSSGradientValue::computeEndPoint):
678         (WebCore::CSSLinearGradientValue::cssText):
679         (WebCore::endPointsFromAngle): Compute endpoints for a gradient which covers the rectangle
680         given an angle.
681         (WebCore::CSSLinearGradientValue::createGradient):
682         (WebCore::CSSRadialGradientValue::cssText):
683         (WebCore::CSSRadialGradientValue::resolveRadius):
684         (WebCore::CSSRadialGradientValue::createGradient):
685
686         * css/CSSParser.cpp:
687         (WebCore::CSSParser::parseValue): Style fix.
688         (WebCore::CSSParser::parseContent): Use isGeneratedImageValue() and parseGeneratedImage()
689         (WebCore::CSSParser::parseFillImage): Use isGeneratedImageValue() and parseGeneratedImage()
690         (WebCore::CSSParser::parseBorderImage): Use isGeneratedImageValue() and parseGeneratedImage()
691         (WebCore::parseDeprecatedGradientPoint): Renamed to indicate that it's only used for -webkit-gradient.
692         (WebCore::parseDeprecatedGradientColorStop): Renamed to indicate that it's only used for -webkit-gradient,
693         and fixed to store CSSValues for the stop position.
694         (WebCore::CSSParser::parseDeprecatedGradient): Renamed to indicate that it's only used for -webkit-gradient,
695         and create CSSLinearGradientValue and CSSRadialGradientValue as appropriate.
696         (WebCore::valueFromSideKeyword):
697         (WebCore::parseGradientColorOrKeyword): Color parsing utility.
698         (WebCore::CSSParser::parseLinearGradient): New method to parse linear gradients.
699         (WebCore::CSSParser::parseRadialGradient): Stub for new method to parse radial gradients.
700         (WebCore::CSSParser::isGeneratedImageValue): Detect gradients and CSS canvas.
701         (WebCore::CSSParser::parseGeneratedImage): Parser for generated images like gradients
702         and CSS canvas.
703         * css/CSSParser.h:
704         * platform/graphics/Gradient.h:
705         (WebCore::Gradient::setP0): We need to be able to change the points when normalizing gradients.
706         (WebCore::Gradient::setP1): Ditto.
707
708 2011-01-03  Noam Rosenthal  <noam.rosenthal@nokia.com>
709
710         Reviewed by Andreas Kling.
711
712         [Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
713         https://bugs.webkit.org/show_bug.cgi?id=51464
714
715         Added a way to bind any QObject created as a plugin to JavaScript, 
716         by adding a custom member (qtObject) to WebCore::Widget. 
717         Added a test to tst_qwebpage to make sure plugins created 
718         as QGraphicsWidget are accessible through JavaScript.
719
720         * bindings/js/ScriptControllerQt.cpp:
721         (WebCore::ScriptController::createScriptInstanceForWidget):
722         * platform/Widget.h:
723         * platform/qt/WidgetQt.cpp:
724         (WebCore::Widget::Widget):
725         (WebCore::Widget::setBindingObject):
726         (WebCore::Widget::bindingObject):
727
728 2011-01-03  David Hyatt  <hyatt@apple.com>
729
730         Reviewed by Simon Fraser.
731
732         https://bugs.webkit.org/show_bug.cgi?id=51328
733
734         Printing on a page with body { height: 100% } clips out the overflow contents.  This happened
735         because the computePageRects function was never correct.  It was using the layer's width and height
736         for the document's width and height, and the layer no longer includes overflow in its width and
737         height.  It was also incorrectly assuming the first page would begin at (0,0), and this is an invalid
738         assumption in RTL or vertical text environments.
739
740         Added printing/page-count-percentage-height.html
741
742         * page/PrintContext.cpp:
743         (WebCore::PrintContext::computePageRects):
744         (WebCore::PrintContext::computePageRectsWithPageSizeInternal):
745
746 2011-01-03  Csaba Osztrogon√°c  <ossy@webkit.org>
747
748         [Qt] Unreviewed buildfix for --minimal build after r74895.
749
750         * html/InputType.cpp: Missing include added.
751         * html/NumberInputType.cpp: Missing include added.
752
753 2011-01-02  Darin Adler  <darin@apple.com>
754
755         Reviewed by Kent Tamura.
756
757         Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
758         https://bugs.webkit.org/show_bug.cgi?id=51791
759
760         * dom/InputElement.h: Make sanitizeValueForTextField public so it can
761         be called by InputType.
762
763         * html/BaseButtonInputType.cpp:
764         (WebCore::BaseButtonInputType::accessKeyAction): Added.
765         (WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added.
766         * html/BaseButtonInputType.h: Ditto.
767
768         * html/BaseCheckableInputType.cpp:
769         (WebCore::BaseCheckableInputType::canSetStringValue): Added.
770         (WebCore::BaseCheckableInputType::accessKeyAction): Added.
771         (WebCore::BaseCheckableInputType::fallbackValue): Added.
772         (WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added.
773         (WebCore::BaseCheckableInputType::isCheckable): Added.
774         * html/BaseCheckableInputType.h: Ditto.
775
776         * html/BaseDateAndTimeInputType.cpp:
777         (WebCore::BaseDateAndTimeInputType::hasSpinButton): Added.
778         * html/BaseDateAndTimeInputType.h: Ditto.
779
780         * html/BaseTextInputType.h: Made more functions private.
781
782         * html/ButtonInputType.cpp:
783         (WebCore::ButtonInputType::isTextButton): Added.
784         * html/ButtonInputType.h: Ditto.
785
786         * html/CheckboxInputType.cpp:
787         (WebCore::CheckboxInputType::willDispatchClick): Added.
788         (WebCore::CheckboxInputType::didDispatchClick): Added.
789         (WebCore::CheckboxInputType::isCheckbox): Added.
790         * html/CheckboxInputType.h: Ditto.
791
792         * html/DateTimeInputType.cpp:
793         (WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed
794         typo in name of this function.
795         * html/DateTimeInputType.h: Ditto.
796         * html/DateTimeLocalInputType.cpp:
797         (WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto.
798         * html/DateTimeLocalInputType.h: Ditto.
799
800         * html/EmailInputType.cpp:
801         (WebCore::EmailInputType::isEmailField): Added.
802         * html/EmailInputType.h: Ditto.
803
804         * html/FileInputType.cpp:
805         (WebCore::FileInputType::FileInputType): Added.
806         (WebCore::FileInputType::canSetStringValue): Added.
807         (WebCore::FileInputType::canChangeFromAnotherType): Added.
808         (WebCore::FileInputType::files): Added.
809         (WebCore::FileInputType::canSetValue): Added.
810         (WebCore::FileInputType::getTypeSpecificValue): Added.
811         (WebCore::FileInputType::storesValueSeparateFromAttribute): Added.
812         (WebCore::FileInputType::setFileList): Added.
813         (WebCore::FileInputType::isFileUpload): Added.
814         * html/FileInputType.h: Ditto.
815
816         * html/HTMLInputElement.cpp:
817         (WebCore::HTMLInputElement::HTMLInputElement): Updated for data member
818         renaming and removal.
819         (WebCore::HTMLInputElement::isValidValue): Call canSetStringValue
820         instead of checking specific type numbers.
821         (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces):
822         Use fastGetAttribute and fixed typo in the name of the
823         scaledStepValueShouldBeInteger function.
824         (WebCore::HTMLInputElement::isKeyboardFocusable): Call
825         InputType::isKeyboardFocusable; moved most of the type-specific
826         logic there.
827         (WebCore::HTMLInputElement::shouldUseInputMethod): Call
828         InputType::shouldUseInputMethod; moved the type-specific logic there.
829         (WebCore::HTMLInputElement::handleBlurEvent): Call
830         InputType::handleBlurEvent; moved the type-specific logic there.
831         (WebCore::HTMLInputElement::setType): Tweak the names and types
832         in this function.
833         (WebCore::HTMLInputElement::updateType): Removed the code that
834         set m_deprecatedTypeNumber. Compare types by comparing the value
835         from formControlType. Removed file-specific logic and instead call
836         InputType::canChangeFromAnotherType. Streamlined the logic for
837         activation callbacks.
838         (WebCore::HTMLInputElement::accessKeyAction): Call
839         InputType::accessKeyAction; moved the type-specific logic there.
840         (WebCore::HTMLInputElement::mapToEntry): Call
841         InputType::shouldRespectHeightAndWidthAttributes and
842         InputType::shouldRespectAlignAttribute.
843         (WebCore::HTMLInputElement::parseMappedAttribute): Updated
844         for name changes and the removal of m_defaultChecked. Changed the
845         alt attribute logic to be based on the class of the renderer.
846         Call InputType::srcAttributeChanged and moved the type-specific
847         logic there. Call shouldRespectAlignAttribute and
848         shouldRespectHeightAndWidthAttributes rather than having
849         type-specific logic here. Call minOrMaxAttributeChanged.
850         (WebCore::HTMLInputElement::rendererIsNeeded): Call
851         InputType::rendererIsNeeded; moved the type-specific logic there.
852         (WebCore::HTMLInputElement::attach): Removed the unneeded m_inited
853         flag, which was redundant with the m_haveType flag. Call
854         InputType::attach; moved the type-specific logic there.
855         (WebCore::HTMLInputElement::altText): Use fastGetAttribute.
856         (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call
857         InputType::canBeSuccessfulSubmitButton; moved the type-specific
858         logic there.
859         (WebCore::HTMLInputElement::isActivatedSubmit): Updated for
860         name changes.
861         (WebCore::HTMLInputElement::setActivatedSubmit): Ditto.
862         (WebCore::HTMLInputElement::reset): Updated to use
863         InputType::storesValueSeparateFromAttribute. Also use
864         hasAttribute(checkedAttr) rather than m_defaultChecked,
865         since both are the same. Also updated for name change.
866         (WebCore::HTMLInputElement::setChecked): Updated for name
867         changes. Also added call to
868         InputType::shouldSendChangeEventAfterCheckedChanged and
869         moved the type-specific logic there.
870         (WebCore::HTMLInputElement::setIndeterminate): Call
871         isCheckable to see if indeterminate is allowed.
872         Also updated for name changes.
873         (WebCore::HTMLInputElement::copyNonAttributeProperties):
874         Updated for name changes and removed data members.
875         (WebCore::HTMLInputElement::value): Call
876         InputType::getTypeSpecificValue and InputType::fallbackValue.
877         Moved the type-specific logic there.
878         (WebCore::HTMLInputElement::valueWithDefault): Call
879         InputType::defaultValue. Moved the type-specific logic there.
880         (WebCore::HTMLInputElement::setSuggestedValue): Call
881         InputType::canSetSuggestedValue. Moved the type-specific logic
882         there.
883         (WebCore::HTMLInputElement::setValue): Call
884         InputType::canSetValue. Moved the type-specific logic there.
885         Clear the file list if it exists rather than checking the
886         type explicitly. We could probably do that a more elegant way.
887         (WebCore::HTMLInputElement::placeholder): Use fastGetAttribute.
888         (WebCore::HTMLInputElement::setValueFromRenderer): Use the
889         isFileUpload function in the assertion.
890         (WebCore::HTMLInputElement::setFileListFromRenderer): Put most
891         of the code from this function into FileInputType::setFileList.
892         (WebCore::HTMLInputElement::preDispatchEventHandler): Changed
893         to call InputType::willDispatchClick, which does the type-specific
894         work. Still need to use a single struct for all types, because
895         the type of the element could change during the event handling.
896         (WebCore::HTMLInputElement::postDispatchEventHandler): Changed
897         to call InputType::didDispatchClick.
898         (WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute.
899         (WebCore::HTMLInputElement::accept): Use fastGetAttribute.
900         (WebCore::HTMLInputElement::alt): Use fastGetAttribute.
901         (WebCore::HTMLInputElement::src): Use fastGetAttribute.
902         (WebCore::HTMLInputElement::setAutofilled): Updated for name
903         changes.
904         (WebCore::HTMLInputElement::files): Use InputType::files.
905         (WebCore::HTMLInputElement::isAcceptableValue): Use
906         InputType::isAcceptableValue.
907         (WebCore::HTMLInputElement::sanitizeValue): Use
908         InputType::sanitizeValue.
909         (WebCore::HTMLInputElement::hasUnacceptableValue): Use
910         InputType::hasUnacceptableValue.
911         (WebCore::HTMLInputElement::needsActivationCallback): Use
912         InputType::shouldResetOnDocumentActivation.
913         (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use
914         InputType::willMoveToNewOwnerDocument.
915         (WebCore::HTMLInputElement::dataList): Use
916         InputType::shouldRespectListAttribute.
917         (WebCore::HTMLInputElement::selectedOption): Tweaked logic
918         and naming a bit.
919         (WebCore::HTMLInputElement::stepUpFromRenderer): Use
920         fastGetAttribute.
921         (WebCore::HTMLInputElement::isSpeechEnabled): Use
922         InputType::shouldRespectSpeechAttribute.
923         (WebCore::HTMLInputElement::isTextButton): No longer inline.
924         Calls through to InputType.
925         (WebCore::HTMLInputElement::isRadioButton): Ditto.
926         (WebCore::HTMLInputElement::isSearchField): Ditto.
927         (WebCore::HTMLInputElement::isInputTypeHidden): Ditto.
928         (WebCore::HTMLInputElement::isPasswordField): Ditto.
929         (WebCore::HTMLInputElement::isCheckbox): Ditto.
930         (WebCore::HTMLInputElement::isText): Ditto.
931         (WebCore::HTMLInputElement::isEmailField): Ditto.
932         (WebCore::HTMLInputElement::isFileUpload): Ditto.
933         (WebCore::HTMLInputElement::isImageButton): Ditto.
934         (WebCore::HTMLInputElement::isNumberField): Ditto.
935         (WebCore::HTMLInputElement::isSubmitButton): Ditto.
936         (WebCore::HTMLInputElement::isTelephoneField): Ditto.
937         (WebCore::HTMLInputElement::isURLField): Ditto.
938         (WebCore::HTMLInputElement::isEnumeratable): Ditto.
939         (WebCore::HTMLInputElement::isChecked): No longer inline.
940         Calls InputType::isCheckable.
941         (WebCore::HTMLInputElement::hasSpinButton): No longer inline.
942         Calls through to InputType.
943         (WebCore::HTMLInputElement::supportsPlaceholder): No longer
944         inline. Calls isTextType as before, but with no special case
945         for ISINDEX. That special case was unneeded since it returns
946         true from isTextType.
947         (WebCore::HTMLInputElement::checkedRadioButtons): No longer
948         inline.
949         (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
950         No longer inline.
951
952         * html/HTMLInputElement.h: Removed multiple unneeded includes.
953         The big one is probably InputType.h, but also HTMLFormElement.h.
954         Removed unneeded forward declarations. Made many functions
955         no longer inline since they now need to make virtual function
956         dispatches. Removed the unneeded defaultChecked and
957         webkitdirectory functions. Both are handled by HTML attribute
958         reflection for DOM bindings, and the callers instead can get
959         at the attribute. Made updateCheckedRadioButtons public so it
960         can be called by an InputType class. Removed
961         DeprecatedInputType, InputTypeMap, createTypeMap,
962         deprecatedInputType, allowsIndeterminate,
963         respectHeightAndWidthAttrs, storesValueSeparateFromAttribute,
964         m_imageLoader, m_fileList, m_deprecatedTypeNumber,
965         m_defaultChecked, and m_inited. Renamed m_checked to
966         m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute,
967         m_indeterminate tom_isIndeterminate, m_haveType to m_hasType,
968         m_activeSubmit to m_isActivatedSubmit, and m_autofilled to
969         m_isAutofilled.
970         
971         * html/HiddenInputType.cpp:
972         (WebCore::HiddenInputType::accessKeyAction): Added.
973         (WebCore::HiddenInputType::rendererIsNeeded) Added.:
974         (WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added.
975         (WebCore::HiddenInputType::isHiddenType): Added.
976         (WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added.
977         * html/HiddenInputType.h: Ditto.
978
979         * html/ImageInputType.cpp:
980         (WebCore::ImageInputType::ImageInputType): Moved out of the header file.
981         (WebCore::ImageInputType::srcAttributeChanged): Added.
982         (WebCore::ImageInputType::attach): Added.
983         (WebCore::ImageInputType::willMoveToNewOwnerDocument): Added.
984         (WebCore::ImageInputType::shouldRespectAlignAttribute): Added.
985         (WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added.
986         (WebCore::ImageInputType::isImageButton): Added.
987         (WebCore::ImageInputType::isEnumeratable): Added.
988         (WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added.
989         * html/ImageInputType.h: Ditto.
990
991         * html/InputType.cpp:
992         (WebCore::InputType::create): Changed argument type to String. There
993         is no value in taking an AtomicString here.
994         (WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in
995         this function name.
996         (WebCore::InputType::canSetStringValue): Added.
997         (WebCore::InputType::isKeyboardFocusable): Added.
998         (WebCore::InputType::shouldUseInputMethod): Added.
999         (WebCore::InputType::handleBlurEvent): Added.
1000         (WebCore::InputType::accessKeyAction): Added.
1001         (WebCore::InputType::attach): Added.
1002         (WebCore::InputType::srcAttributeChanged): Added.
1003         (WebCore::InputType::willMoveToNewOwnerDocument): Added.
1004         (WebCore::InputType::shouldRespectAlignAttribute): Added.
1005         (WebCore::InputType::canChangeFromAnotherType): Added.
1006         (WebCore::InputType::minOrMaxAttributeChanged): Added.
1007         (WebCore::InputType::canBeSuccessfulSubmitButton): Added.
1008         (WebCore::InputType::rendererIsNeeded): Added.
1009         (WebCore::InputType::files): Added.
1010         (WebCore::InputType::getTypeSpecificValue): Added.
1011         (WebCore::InputType::fallbackValue): Added.
1012         (WebCore::InputType::defaultValue): Added.
1013         (WebCore::InputType::canSetSuggestedValue): Added.
1014         (WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added.
1015         (WebCore::InputType::storesValueSeparateFromAttribute): Added.
1016         (WebCore::InputType::canSetValue): Added.
1017         (WebCore::InputType::willDispatchClick): Added.
1018         (WebCore::InputType::didDispatchClick): Added.
1019         (WebCore::InputType::isAcceptableValue): Added.
1020         (WebCore::InputType::sanitizeValue): Added.
1021         (WebCore::InputType::hasUnacceptableValue): Added.
1022         (WebCore::InputType::setFileList): Added.
1023         (WebCore::InputType::shouldResetOnDocumentActivation): Added.
1024         (WebCore::InputType::shouldRespectListAttribute): Added.
1025         (WebCore::InputType::shouldRespectSpeechAttribute): Added.
1026         (WebCore::InputType::isTextButton): Added.
1027         (WebCore::InputType::isRadioButton): Added.
1028         (WebCore::InputType::isSearchField): Added.
1029         (WebCore::InputType::isHiddenType): Added.
1030         (WebCore::InputType::isPasswordField): Added.
1031         (WebCore::InputType::isCheckbox): Added.
1032         (WebCore::InputType::isEmailField): Added.
1033         (WebCore::InputType::isFileUpload): Added.
1034         (WebCore::InputType::isImageButton): Added.
1035         (WebCore::InputType::isNumberField): Added.
1036         (WebCore::InputType::isSubmitButton): Added.
1037         (WebCore::InputType::isTelephoneField): Added.
1038         (WebCore::InputType::isURLField): Added.
1039         (WebCore::InputType::isEnumeratable): Added.
1040         (WebCore::InputType::isCheckable): Added.
1041         (WebCore::InputType::hasSpinButton): Added.
1042         (WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added.
1043
1044         * html/InputType.h: Removed unneeded ExceptionCode.h include and
1045         used a typedef instead as we do when we want for forward declare it.
1046         Added includes and forward declarations needed for new functions.
1047         Added ClickHandlingState structure. Changed the argument to create
1048         to a String rather than AtomicString. Added many virtual functions.
1049         
1050         * html/IsIndexInputType.cpp:
1051         (WebCore::IsIndexInputType::shouldRespectListAttribute): Added.
1052         * html/IsIndexInputType.h: Ditto.
1053
1054         * html/NumberInputType.cpp:
1055         (WebCore::NumberInputType::handleBlurEvent): Added.
1056         (WebCore::NumberInputType::isAcceptableValue): Added.
1057         (WebCore::NumberInputType::sanitizeValue): Added.
1058         (WebCore::NumberInputType::hasUnacceptableValue): Added.
1059         (WebCore::NumberInputType::shouldRespectSpeechAttribute): Added.
1060         (WebCore::NumberInputType::isNumberField): Added.
1061         (WebCore::NumberInputType::hasSpinButton): Added.
1062         * html/NumberInputType.h: Ditto.
1063
1064         * html/PasswordInputType.cpp:
1065         (WebCore::PasswordInputType::shouldUseInputMethod): Added.
1066         (WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added.
1067         (WebCore::PasswordInputType::shouldRespectListAttribute): Added.
1068         (WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added.
1069         (WebCore::PasswordInputType::isPasswordField): Added.
1070         * html/PasswordInputType.h: Ditto.
1071
1072         * html/RadioInputType.cpp:
1073         (WebCore::RadioInputType::isKeyboardFocusable): Added.
1074         (WebCore::RadioInputType::attach): Added.
1075         (WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added.
1076         (WebCore::RadioInputType::willDispatchClick): Added.
1077         (WebCore::RadioInputType::didDispatchClick): Added.
1078         (WebCore::RadioInputType::isRadioButton): Added.
1079         * html/RadioInputType.h: Ditto.
1080
1081         * html/RangeInputType.cpp:
1082         (WebCore::RangeInputType::accessKeyAction): Added.
1083         (WebCore::RangeInputType::minOrMaxAttributeChanged): Added.
1084         (WebCore::RangeInputType::fallbackValue): Added.
1085         (WebCore::RangeInputType::sanitizeValue): Added.
1086         (WebCore::RangeInputType::shouldRespectListAttribute): Added.
1087         * html/RangeInputType.h: Ditto.
1088
1089         * html/ResetInputType.cpp:
1090         (WebCore::ResetInputType::defaultValue): Added.
1091         (WebCore::ResetInputType::isTextButton): Added.
1092         * html/ResetInputType.h: Ditto.
1093
1094         * html/SearchInputType.cpp:
1095         (WebCore::SearchInputType::shouldRespectSpeechAttribute): Added.
1096         (WebCore::SearchInputType::isSearchField): Added.
1097         * html/SearchInputType.h: Ditto.
1098
1099         * html/SubmitInputType.cpp:
1100         (WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added.
1101         (WebCore::SubmitInputType::defaultValue): Added.
1102         (WebCore::SubmitInputType::isSubmitButton): Added.
1103         (WebCore::SubmitInputType::isTextButton): Added.
1104         * html/SubmitInputType.h: Ditto.
1105
1106         * html/TelephoneInputType.cpp:
1107         (WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added.
1108         (WebCore::TelephoneInputType::isTelephoneField): Added.
1109         * html/TelephoneInputType.h: Ditto.
1110
1111         * html/TextFieldInputType.cpp:
1112         (WebCore::TextFieldInputType::shouldUseInputMethod): Added.
1113         (WebCore::TextFieldInputType::sanitizeValue): Added.
1114         (WebCore::TextFieldInputType::shouldRespectListAttribute): Added.
1115         * html/TextFieldInputType.h: Ditto.
1116
1117         * html/TextInputType.cpp:
1118         (WebCore::TextInputType::canSetSuggestedValue): Added.
1119         (WebCore::TextInputType::shouldRespectSpeechAttribute): Added.
1120         * html/TextInputType.h: Ditto.
1121
1122         * html/TimeInputType.cpp:
1123         (WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed
1124         typo in the name of this function.
1125         * html/TimeInputType.h: Ditto.
1126
1127         * html/URLInputType.cpp:
1128         (WebCore::URLInputType::isURLField): Added.
1129         * html/URLInputType.h: Ditto.
1130
1131 2011-01-03  Mihai Parparita  <mihaip@chromium.org>
1132
1133         Unreviewed.
1134
1135         NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
1136         https://bugs.webkit.org/show_bug.cgi?id=51151
1137
1138         Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
1139         so that it can match Safari's (and thus use the same baselines).
1140
1141         No new tests, should be covered by layout tests (which will need
1142         expectation changes)
1143
1144         * platform/chromium/ScrollbarThemeChromiumMac.mm:
1145
1146 2011-01-03  Antonio Gomes  <agomes@rim.com>
1147
1148         Unreviewed build fix for WebKit/Gtk+.
1149
1150         RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be
1151         guarded by ENABLE(VIDEO), as it is in its header.
1152
1153         No new tests.
1154
1155         * platform/gtk/RenderThemeGtk2.cpp:
1156
1157 2011-01-02  Dan Bernstein  <mitz@apple.com>
1158
1159         Rubber-stamped by Simon Fraser.
1160
1161         <rdar://problem/8812159> Update copyright strings
1162
1163         * Info.plist:
1164
1165 2011-01-02  Dan Bernstein  <mitz@apple.com>
1166
1167         Reviewed by Sam Weinig.
1168
1169         <rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field
1170         https://bugs.webkit.org/show_bug.cgi?id=51623
1171
1172         * editing/Editor.cpp:
1173         (WebCore::Editor::countMatchesForText): Actually remember the original search range end
1174         container and offset and restore them when needed, instead of using two references to the
1175         same Range.
1176         * manual-tests/find-count-matches-after-text-control.html: Added.
1177
1178 2011-01-02  Benjamin Poulain  <benjamin.poulain@nokia.com>
1179
1180         Reviewed by Csaba Osztrogon√°c.
1181
1182         WebKit 2 does not build on 64bits with a recent GCC
1183         https://bugs.webkit.org/show_bug.cgi?id=51754
1184
1185         Use explicitely 64 bits types for the attributes of DatabaseDetails.
1186
1187         * storage/DatabaseDetails.h:
1188         (WebCore::DatabaseDetails::expectedUsage):
1189         (WebCore::DatabaseDetails::currentUsage):
1190
1191 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1192
1193         Unreviewed WinCE build fix for r74868.
1194
1195         * platform/graphics/wince/ImageBufferWinCE.cpp:
1196         (WebCore::getImageData):
1197
1198 2011-01-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1199
1200         Unreviewed, rolling out r74847.
1201         http://trac.webkit.org/changeset/74847
1202         https://bugs.webkit.org/show_bug.cgi?id=51803
1203
1204         "Preprocessor guards should be in header files" (Requested by
1205         ap on #webkit).
1206
1207         * bindings/js/JSDOMWindowBase.cpp:
1208         * dom/Document.cpp:
1209         (WebCore::Document::recalcStyle):
1210         * html/HTMLDocument.cpp:
1211         * loader/FrameLoader.cpp:
1212         * loader/ResourceLoadNotifier.cpp:
1213         * page/Chrome.cpp:
1214         * page/Console.cpp:
1215         * page/ContextMenuController.cpp:
1216         * page/DOMWindow.cpp:
1217         (WebCore::DOMWindow::dispatchEvent):
1218         * page/EventHandler.cpp:
1219         * page/Page.cpp:
1220         * storage/Database.cpp:
1221         * workers/AbstractWorker.cpp:
1222         * workers/DefaultSharedWorkerRepository.cpp:
1223         * workers/SharedWorker.cpp:
1224         * workers/Worker.cpp:
1225         * workers/WorkerContext.cpp:
1226         * workers/WorkerMessagingProxy.cpp:
1227         * xml/XMLHttpRequest.cpp:
1228         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
1229
1230 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1231
1232         [CMake] Unreviewed build fix.
1233
1234         * CMakeLists.txt:
1235
1236 2011-01-02  Dirk Schulze  <krit@webkit.org>
1237
1238         Reviewed by Simon Fraser.
1239
1240         Clarify ImageBuffer and ImageData relationship
1241         https://bugs.webkit.org/show_bug.cgi?id=51297
1242
1243         Remove references to ImageData and CanvasPixelArray from ImageBuffer and SVG filter/masker code,
1244         since this was a layering violation, and replaced it by ByteArray.
1245
1246         No change of functionality, so no new test added.
1247
1248         * html/ImageData.cpp:
1249         (WebCore::ImageData::create):
1250         (WebCore::ImageData::ImageData):
1251         * html/ImageData.h: Added new constructor with ByteArray input.
1252         (WebCore::ImageData::width):
1253         (WebCore::ImageData::height):
1254         (WebCore::ImageData::data):
1255         * html/canvas/CanvasPixelArray.cpp:
1256         (WebCore::CanvasPixelArray::create):
1257         (WebCore::CanvasPixelArray::CanvasPixelArray):
1258         * html/canvas/CanvasPixelArray.h: New conctructor with ByteArray input, used by HTML Canvas.
1259         (WebCore::CanvasPixelArray::data):
1260         (WebCore::CanvasPixelArray::length):
1261         (WebCore::CanvasPixelArray::set):
1262         (WebCore::CanvasPixelArray::get):
1263         * html/canvas/CanvasRenderingContext2D.cpp:
1264         (WebCore::CanvasRenderingContext2D::getImageData):
1265         (WebCore::CanvasRenderingContext2D::putImageData):
1266         * platform/graphics/ImageBuffer.h:
1267         * platform/graphics/cairo/ImageBufferCairo.cpp:
1268         (WebCore::getImageData):
1269         (WebCore::ImageBuffer::getUnmultipliedImageData):
1270         (WebCore::ImageBuffer::getPremultipliedImageData):
1271         (WebCore::putImageData):
1272         (WebCore::ImageBuffer::putUnmultipliedImageData):
1273         (WebCore::ImageBuffer::putPremultipliedImageData):
1274         * platform/graphics/cg/ImageBufferCG.cpp:
1275         (WebCore::getImageData):
1276         (WebCore::ImageBuffer::getUnmultipliedImageData):
1277         (WebCore::ImageBuffer::getPremultipliedImageData):
1278         (WebCore::putImageData):
1279         (WebCore::ImageBuffer::putUnmultipliedImageData):
1280         (WebCore::ImageBuffer::putPremultipliedImageData):
1281         * platform/graphics/filters/FEBlend.cpp:
1282         (WebCore::FEBlend::apply):
1283         * platform/graphics/filters/FEColorMatrix.cpp:
1284         (WebCore::FEColorMatrix::apply):
1285         * platform/graphics/filters/FEComponentTransfer.cpp:
1286         (WebCore::FEComponentTransfer::apply):
1287         * platform/graphics/filters/FEComposite.cpp:
1288         (WebCore::FEComposite::apply):
1289         * platform/graphics/filters/FEConvolveMatrix.cpp:
1290         (WebCore::setDestinationPixels):
1291         (WebCore::FEConvolveMatrix::apply):
1292         * platform/graphics/filters/FEConvolveMatrix.h:
1293         * platform/graphics/filters/FEDisplacementMap.cpp:
1294         (WebCore::FEDisplacementMap::apply):
1295         * platform/graphics/filters/FEGaussianBlur.cpp:
1296         (WebCore::FEGaussianBlur::apply):
1297         * platform/graphics/filters/FELighting.cpp:
1298         (WebCore::FELighting::apply):
1299         * platform/graphics/filters/FEMorphology.cpp:
1300         (WebCore::FEMorphology::apply):
1301         * platform/graphics/filters/FETurbulence.cpp:
1302         (WebCore::FETurbulence::apply):
1303         * platform/graphics/filters/FilterEffect.cpp:
1304         (WebCore::FilterEffect::asImageBuffer):
1305         (WebCore::FilterEffect::asUnmultipliedImage):
1306         (WebCore::FilterEffect::asPremultipliedImage):
1307         (WebCore::FilterEffect::copyImageBytes):
1308         (WebCore::FilterEffect::copyUnmultipliedImage):
1309         (WebCore::FilterEffect::copyPremultipliedImage):
1310         (WebCore::FilterEffect::createUnmultipliedImageResult):
1311         (WebCore::FilterEffect::createPremultipliedImageResult):
1312         * platform/graphics/filters/FilterEffect.h:
1313         * platform/graphics/qt/ImageBufferQt.cpp:
1314         (WebCore::getImageData):
1315         (WebCore::ImageBuffer::getUnmultipliedImageData):
1316         (WebCore::ImageBuffer::getPremultipliedImageData):
1317         (WebCore::putImageData):
1318         (WebCore::ImageBuffer::putUnmultipliedImageData):
1319         (WebCore::ImageBuffer::putPremultipliedImageData):
1320         * platform/graphics/skia/ImageBufferSkia.cpp:
1321         (WebCore::getImageData):
1322         (WebCore::ImageBuffer::getUnmultipliedImageData):
1323         (WebCore::ImageBuffer::getPremultipliedImageData):
1324         (WebCore::putImageData):
1325         (WebCore::ImageBuffer::putUnmultipliedImageData):
1326         (WebCore::ImageBuffer::putPremultipliedImageData):
1327         * platform/graphics/wince/ImageBufferWinCE.cpp:
1328         (WebCore::getImageData):
1329         (WebCore::ImageBuffer::getUnmultipliedImageData):
1330         (WebCore::ImageBuffer::getPremultipliedImageData):
1331         (WebCore::putImageData):
1332         (WebCore::ImageBuffer::putUnmultipliedImageData):
1333         (WebCore::ImageBuffer::putPremultipliedImageData):
1334         * platform/graphics/wx/ImageBufferWx.cpp:
1335         (WebCore::ImageBuffer::getUnmultipliedImageData):
1336         (WebCore::ImageBuffer::getPremultipliedImageData):
1337         (WebCore::ImageBuffer::putUnmultipliedImageData):
1338         (WebCore::ImageBuffer::putPremultipliedImageData):
1339         * rendering/RenderSVGResourceMasker.cpp:
1340         (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
1341
1342 2011-01-01  Adam Barth  <abarth@webkit.org>
1343
1344         Reviewed by Eric Seidel.
1345
1346         Move JavaScriptCore to Source
1347         https://bugs.webkit.org/show_bug.cgi?id=51604
1348
1349         Update references to JavaScriptCore.
1350
1351         * Android.derived.jscbindings.mk:
1352         * Android.v8bindings.mk:
1353         * CMakeLists.txt:
1354         * WebCore.gyp/WebCore.gyp:
1355         * WebCore.pro:
1356           - These changes are subtle and might not be 100% correct.
1357         * move-js-headers.sh:
1358
1359 2011-01-01  Adam Barth  <abarth@webkit.org>
1360
1361         Reviewed by Eric Seidel.
1362
1363         forbid sandboxed frames to call top.close() when allow-same-origin is not setted
1364         https://bugs.webkit.org/show_bug.cgi?id=38340
1365
1366         We now pass the ScriptExecutionContext to window.close so it can find
1367         the Frame and check whether navigation is allowed.  This check will
1368         almost always pass because you can only close top-level frames, but the
1369         check will fail when the calling script is sandboxed.
1370
1371         Tests: fast/frames/sandboxed-iframe-close-top-noclose.html
1372                fast/frames/sandboxed-iframe-close-top.html
1373
1374         * page/DOMWindow.cpp:
1375         (WebCore::DOMWindow::close):
1376         * page/DOMWindow.h:
1377         * page/DOMWindow.idl:
1378
1379 2011-01-01  Adam Barth  <abarth@webkit.org>
1380
1381         Reviewed by Eric Seidel.
1382
1383         sandbox iframes have access to top.history methods
1384         https://bugs.webkit.org/show_bug.cgi?id=38152
1385
1386         To enforce the sandbox restrictions on History, we need to pass the
1387         ScriptExecutionContext to WebCore.  This patch leaves the original
1388         History methods in place because they are used directly by folks who
1389         don't care about security checks.
1390
1391         Test: fast/frames/sandboxed-iframe-history-denied.html
1392
1393         * page/History.cpp:
1394         (WebCore::History::back):
1395         (WebCore::History::forward):
1396         (WebCore::History::go):
1397         * page/History.h:
1398         * page/History.idl:
1399
1400 2011-01-01  Adam Barth  <abarth@webkit.org>
1401
1402         Remove empty file.
1403
1404         * Android.mk:
1405         * CMakeLists.txt:
1406         * GNUmakefile.am:
1407         * WebCore.gypi:
1408         * WebCore.pro:
1409         * WebCore.vcproj/WebCore.vcproj:
1410         * WebCore.xcodeproj/project.pbxproj:
1411         * dom/DOMAllInOne.cpp:
1412         * dom/Entity.cpp: Removed.
1413
1414 2011-01-01  Adam Barth  <abarth@webkit.org>
1415
1416         Remove empty file.
1417
1418         * CMakeLists.txt:
1419         * GNUmakefile.am:
1420         * WebCore.pro:
1421         * WebCore.vcproj/WebCore.vcproj:
1422         * WebCore.xcodeproj/project.pbxproj:
1423         * bindings/js/JSBindingsAllInOne.cpp:
1424         * bindings/js/JSPopStateEventCustom.cpp: Removed.
1425
1426 2011-01-01  Adam Barth  <abarth@webkit.org>
1427
1428         Remove empty files.
1429
1430         * GNUmakefile.am:
1431         * WebCore.gypi:
1432         * WebCore.vcproj/WebCore.vcproj:
1433         * WebCore.xcodeproj/project.pbxproj:
1434         * bindings/generic/BindingFrame.h: Removed.
1435         * bindings/generic/BindingLocation.h: Removed.
1436
1437 2011-01-01  Konstantin Tokarev  <annulen@yandex.ru>
1438
1439         Reviewed by Darin Adler.
1440
1441         Don't include Inspector headers when Inspector is disabled
1442         https://bugs.webkit.org/show_bug.cgi?id=51789
1443
1444         * bindings/js/JSDOMWindowBase.cpp: Include Inspector headers when
1445         Inspector is enabled
1446         * dom/Document.cpp: Include Inspector headers when
1447         Inspector is enabled
1448         (WebCore::Document::recalcStyle): Disabled InspectorInstrumentationCookie
1449         handling
1450         * html/HTMLDocument.cpp: Include Inspector headers when
1451         Inspector is enabled
1452         * loader/FrameLoader.cpp: Include Inspector headers when
1453         Inspector is enabled
1454         * loader/ResourceLoadNotifier.cpp: Include Inspector headers when
1455         Inspector is enabled
1456         * page/Chrome.cpp: Include Inspector headers when
1457         Inspector is enabled
1458         * page/Console.cpp: Include Inspector headers when
1459         Inspector is enabled
1460         * page/ContextMenuController.cpp: Include Inspector headers when
1461         Inspector is enabled
1462         * page/DOMWindow.cpp: Include Inspector headers when
1463         Inspector is enabled
1464         (WebCore::DOMWindow::dispatchEvent): Disabled InspectorInstrumentationCookie
1465         handling
1466         * page/EventHandler.cpp: Include Inspector headers when
1467         Inspector is enabled
1468         * page/Page.cpp: Include Inspector headers when
1469         Inspector is enabled
1470         * storage/Database.cpp: Include Inspector headers when
1471         Inspector is enabled
1472         * workers/AbstractWorker.cpp: Include Inspector headers when
1473         Inspector is enabled
1474         * workers/DefaultSharedWorkerRepository.cpp: Include Inspector headers when
1475         Inspector is enabled
1476         * workers/SharedWorker.cpp: Include Inspector headers when
1477         Inspector is enabled
1478         * workers/Worker.cpp: Include Inspector headers when
1479         Inspector is enabled
1480         * workers/WorkerContext.cpp: Include Inspector headers when
1481         Inspector is enabled
1482         * workers/WorkerMessagingProxy.cpp: Include Inspector headers when
1483         Inspector is enabled
1484         * xml/XMLHttpRequest.cpp: Include Inspector headers when
1485         Inspector is enabled
1486         (WebCore::XMLHttpRequest::callReadyStateChangeListener): Disabled
1487         InspectorInstrumentationCookie handling
1488
1489 2010-12-31  Adam Barth  <abarth@webkit.org>
1490
1491         Reviewed by Darin Adler.
1492
1493         fast/loader/about-blank-hash-change.html fails on Chromium
1494         https://bugs.webkit.org/show_bug.cgi?id=51788
1495
1496         I'm unable to reproduce the failure locally, so this patch is slightly
1497         speculative.  We need to be slighly more careful how we compare the
1498         fragment identifiers for Chromium because Chromium uses a URL parser
1499         that is more agressive about canonicalization.
1500
1501         * page/Location.cpp:
1502         (WebCore::Location::setHash):
1503
1504 2010-12-31  Martin Robinson  <mrobinson@igalia.com>
1505
1506         Reviewed by Xan Lopez.
1507
1508         [GTK] Use GLib/GIO API for FileSystemGtk implementation
1509         https://bugs.webkit.org/show_bug.cgi?id=51617
1510
1511         Complete implementation of FileSystem platform code for GLib. This
1512         converts remaining API points using POSIX calls to platform-independent
1513         GLib calls and fixes other compilation errors.
1514
1515         No new tests. This code will be tested when an implementation
1516         of beginDragWithFiles is complete.
1517
1518         (WebCore::JSDirectoryEntry::getFile):
1519         (WebCore::JSDirectoryEntry::getDirectory):
1520         * platform/FileSystem.h: Added forward declarations for GLib types to
1521         avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
1522         * platform/gtk/FileSystemGtk.cpp:
1523         (WebCore::openTemporaryFile): Reimplement using only GLib calls.
1524         (WebCore::openFile): Ditto.
1525         (WebCore::closeFile): Ditto.
1526         (WebCore::seekFile): Added implementation.
1527         (WebCore::writeToFile): Reimplement using only GLib calls.
1528         (WebCore::readFromFile): Ditto.
1529
1530 2010-12-31  Darin Adler  <darin@apple.com>
1531
1532         Reviewed by Dan Bernstein.
1533
1534         Some renaming and refactoring of form element code
1535         https://bugs.webkit.org/show_bug.cgi?id=51784
1536
1537         * bindings/js/JSHTMLSelectElementCustom.cpp:
1538         (WebCore::JSHTMLSelectElement::remove): Call new overload of remove
1539         for option elements instead of putting the logic in the binding.
1540
1541         * html/HTMLButtonElement.cpp:
1542         (WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes.
1543         (WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to
1544         "event" instead of "evt". Also updated for name changes.
1545         (WebCore::HTMLButtonElement::isActivatedSubmit): Ditto.
1546         (WebCore::HTMLButtonElement::setActivatedSubmit): Ditto.
1547         (WebCore::HTMLButtonElement::appendFormData): Ditto.
1548         * html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit
1549         to match the getter function name. The name still doesn't seem great.
1550
1551         * html/HTMLFormElement.cpp:
1552         (WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes.
1553         (WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function
1554         instead of m_autocomplete data member.
1555         (WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member
1556         instead of otherwise-unused isDemoted function.
1557         (WebCore::HTMLFormElement::submitImplicitly): Updated for name changes.
1558         (WebCore::HTMLFormElement::validateInteractively): Removed code to clear
1559         m_insubmit. This is now handled by the caller, prepareForSubmission.
1560         (WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for
1561         name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission
1562         here from validateInteractively. Removed unneeded check of m_doingsubmit
1563         boolean before setting it.
1564         (WebCore::HTMLFormElement::submit): Factored this function into two.
1565         One for JavaScript and one for non-JavaScript. Neither function needs a frame
1566         argument, because the question being asked, anyPageIsProcessingUserGesture,
1567         is a question asked of an entire page group, not a specific frame or page,
1568         so it's not important which is the active frame.
1569         (WebCore::HTMLFormElement::submitFromJavaScript): Ditto.
1570         (WebCore::HTMLFormElement::reset): Updated for name changes.
1571         (WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse
1572         acceptAttr and got rid of code to set m_autocomplete.
1573         (WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw
1574         pointer.
1575         (WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer
1576         and the vector find function. Added a FIXME about the comment.
1577         (WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete
1578         function instead of m_autocomplete data member.
1579         (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto.
1580         (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
1581         (WebCore::HTMLFormElement::autoComplete): Ditto.
1582         * html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete
1583         function. Renamed prepareSubmit to prepareForSubmission. Got rid of the
1584         frame argument from the submit function and added a new submitFromJavaScript
1585         variant. Removed the unneeded isDemoted function. Changed the return type
1586         of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed
1587         m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to
1588         m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed,
1589         m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
1590
1591         * html/HTMLFormElement.idl: Use the function named submitFromJavaScript
1592         instead of using CallWith=DynamicFrame because we don't need to know
1593         what frame is calling. If we did, it's not clear that the "dynamic"
1594         frame would be the right one anyway.
1595
1596         * html/HTMLSelectElement.cpp:
1597         (WebCore::HTMLSelectElement::remove): Added an overload that takes an option
1598         element, since the JavaScript binding supports this.
1599         * html/HTMLSelectElement.h: Ditto.
1600
1601         * html/ImageInputType.cpp:
1602         (WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
1603         * html/ImageInputType.h: Ditto.
1604         * html/SubmitInputType.cpp:
1605         (WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
1606
1607 2010-12-31  Daniel Bates  <dbates@rim.com>
1608
1609         Reviewed by Darin Adler.
1610
1611         Pass style for <area> instead of associated <img> when querying whether
1612         the theme draws the focus ring for an <area>
1613         https://bugs.webkit.org/show_bug.cgi?id=51632
1614
1615         Fixes an issue where the style for the associated <img> of an <area>
1616         was passed when considering whether the theme should draw a focus ring
1617         for the <area>. Instead, we should pass the theme the style for the <area>.
1618
1619         It's not possible to test this at this time since there are no themes
1620         that override focus ring drawing for <area>s.
1621
1622         * rendering/RenderImage.cpp:
1623         (WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing()
1624         such that it's called with respect to the focused <area>.
1625
1626 2010-12-31  Darin Adler  <darin@apple.com>
1627
1628         * WebCore.xcodeproj/project.pbxproj: Added back the language.
1629         Developers should be using Xcode 3.2.5 or newer.
1630
1631 2010-12-31  Adam Barth  <abarth@webkit.org>
1632
1633         Reviewed by Eric Seidel.
1634
1635         Move V8 to WebCore Location implementation
1636         https://bugs.webkit.org/show_bug.cgi?id=51768
1637
1638         * bindings/generic/BindingFrame.h:
1639         * bindings/generic/BindingLocation.h:
1640         * bindings/v8/V8Binding.h:
1641         * bindings/v8/V8DOMWindowShell.cpp:
1642         (WebCore::V8DOMWindowShell::setLocation):
1643         * bindings/v8/V8Utilities.cpp:
1644         * bindings/v8/V8Utilities.h:
1645         * bindings/v8/custom/V8LocationCustom.cpp:
1646         (WebCore::V8Location::hashAccessorSetter):
1647         (WebCore::V8Location::hostAccessorSetter):
1648         (WebCore::V8Location::hostnameAccessorSetter):
1649         (WebCore::V8Location::hrefAccessorSetter):
1650         (WebCore::V8Location::pathnameAccessorSetter):
1651         (WebCore::V8Location::portAccessorSetter):
1652         (WebCore::V8Location::protocolAccessorSetter):
1653         (WebCore::V8Location::searchAccessorSetter):
1654         (WebCore::V8Location::reloadCallback):
1655         (WebCore::V8Location::replaceCallback):
1656         (WebCore::V8Location::assignCallback):
1657
1658 2010-12-31  Yi Shen  <yi.4.shen@nokia.com>
1659
1660         Reviewed by Eric Seidel.
1661
1662         Make retrieving extraMediaControlsStyleSheet be page dependent.
1663         https://bugs.webkit.org/show_bug.cgi?id=51752
1664
1665         Use themeForPage to retrieve extraMediaControlsStyleSheet for media
1666         controls.
1667
1668         No new tests because no platform-specific theme implementation uses
1669         the passed page pointer yet.
1670
1671         * css/CSSStyleSelector.cpp:
1672         (WebCore::CSSStyleSelector::styleForElement):
1673
1674 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1675
1676         Reviewed by Pavel Feldman.
1677
1678         Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.
1679
1680         https://bugs.webkit.org/show_bug.cgi?id=51709
1681
1682         * inspector/front-end/ResourcesPanel.js:
1683         (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
1684
1685 2010-12-31  Patrick Gansterer  <paroga@webkit.org>
1686
1687         Unreviewed build fix after r74800.
1688
1689         * bindings/js/JSDOMWindowCustom.cpp: Add missing header.
1690         * bindings/js/JSLocationCustom.cpp: Ditto.
1691
1692 2010-12-31  Adam Barth  <abarth@webkit.org>
1693
1694         Rubber-stamped by Eric Seidel.
1695
1696         Move HTML and XML parser benchmarks into PerformanceTests/Parser
1697         https://bugs.webkit.org/show_bug.cgi?id=51772
1698
1699         Remove the benchmarks folder now that it's empty.  Future benchmarks
1700         should go in the PerformanceTests directory.
1701
1702         * benchmarks: Removed.
1703         * benchmarks/parser: Removed.
1704         * benchmarks/parser/html-parser.html: Removed.
1705         * benchmarks/parser/resources: Removed.
1706         * benchmarks/parser/resources/html5.html: Removed.
1707         * benchmarks/parser/resources/runner.js: Removed.
1708         * benchmarks/parser/xml-parser.html: Removed.
1709
1710 2010-12-31  Patrick Gansterer  <paroga@webkit.org>
1711
1712         Reviewed by Adam Barth.
1713
1714         Add XML parser benchmark
1715         https://bugs.webkit.org/show_bug.cgi?id=51612
1716
1717         Move the JavaScript code of html parser into a separate file to share it with xml parser.
1718
1719         * benchmarks/parser/html-parser.html:
1720         * benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html.
1721         (runFunction):
1722         (run):
1723         (start):
1724         * benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
1725
1726 2010-12-29  Zhenyao Mo  <zmo@google.com>
1727
1728         Reviewed by Kenneth Russell.
1729
1730         Update validation of stencil mask and ref values
1731         https://bugs.webkit.org/show_bug.cgi?id=50716
1732
1733         * html/canvas/WebGLRenderingContext.cpp:
1734         (WebCore::WebGLRenderingContext::initializeNewContext): Initialize cached stencil settings.
1735         (WebCore::WebGLRenderingContext::drawArrays): Validate stencil settings.
1736         (WebCore::WebGLRenderingContext::drawElements): Ditto.
1737         (WebCore::WebGLRenderingContext::stencilFunc): Cache stencil settings, but generate no error.
1738         (WebCore::WebGLRenderingContext::stencilFuncSeparate): Ditto.
1739         (WebCore::WebGLRenderingContext::stencilMask): Ditto.
1740         (WebCore::WebGLRenderingContext::stencilMaskSeparate): Ditto.
1741         (WebCore::WebGLRenderingContext::validateStencilSettings): Helper function to validate stencil settings.
1742         * html/canvas/WebGLRenderingContext.h: Declare stencil setting members.
1743
1744 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1745
1746         Reviewed by Xan Lopez.
1747
1748         [GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3
1749         https://bugs.webkit.org/show_bug.cgi?id=51755
1750
1751         Split out pieces of RenderThemeGtk into RenderThemeGtk2 and RenderThemeGtk3
1752         if they are going to differ between GTK+ 2.x and GTK+ 3.x. This is the preliminary
1753         step to landing support for the new GTK+ 3.x theming API.
1754
1755         No new tests. This should not change functionality.
1756
1757         * GNUmakefile.am: Add RenderThemeGtk2 and RenderThemeGtk3 to the sources list.
1758         * platform/gtk/RenderThemeGtk.cpp:
1759         (WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the setTextInputBorders static method.
1760         (WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto.
1761         (WebCore::RenderThemeGtk::paintMediaButton): Ditto.
1762         (WebCore::RenderThemeGtk::adjustProgressBarStyle): ditto.
1763         * platform/gtk/RenderThemeGtk.h: Make setTextInputBorders a method, so that
1764         it can be exist in RenderThemeGtk{2,3} and be called from RenderThemeGtk.
1765         * platform/gtk/RenderThemeGtk2.cpp: Added. A fork of the bits of RenderThemeGtk
1766         that will eventually be platform-dependent.
1767         * platform/gtk/RenderThemeGtk3.cpp: Added. Ditto.
1768
1769 2010-12-30  Justin Schuh  <jschuh@chromium.org>
1770
1771         Reviewed by James Robinson.
1772
1773         Reverting r74292 because it introduced a crash with ruby text.
1774         https://bugs.webkit.org/show_bug.cgi?id=51637
1775
1776         Test: fast/css/counters/counter-ruby-text-cleared.html
1777
1778         * rendering/RenderCounter.cpp:
1779         (WebCore::findPlaceForCounter):
1780         * rendering/RenderObject.cpp:
1781         (WebCore::RenderObject::addChild):
1782         * rendering/RenderObjectChildList.cpp:
1783         (WebCore::RenderObjectChildList::appendChildNode):
1784         (WebCore::RenderObjectChildList::insertChildNode):
1785
1786 2010-12-30  Darin Adler  <darin@apple.com>
1787
1788         Reviewed by David Kilzer.
1789
1790         Remove unused JSBinding source files
1791         https://bugs.webkit.org/show_bug.cgi?id=51762
1792
1793         * bindings/js/JSBinding.h: Removed.
1794         * bindings/js/specialization: Removed.
1795         * bindings/js/specialization/JSBindingState.cpp: Removed.
1796         * bindings/js/specialization/JSBindingState.h: Removed.
1797
1798         * CMakeLists.txt: Removed references to files.
1799         * GNUmakefile.am: Ditto.
1800         * WebCore.gypi: Ditto.
1801         * WebCore.pro: Ditto.
1802         * WebCore.vcproj/WebCore.vcproj: Ditto.
1803         * bindings/js/JSBindingsAllInOne.cpp: Ditto.
1804
1805 2010-12-30  Tony Gentilcore  <tonyg@chromium.org>
1806
1807         Reviewed by Darin Adler.
1808
1809         Remove Document.h include from some headers where it isn't necessary
1810         https://bugs.webkit.org/show_bug.cgi?id=51730
1811
1812         No new tests because no new functionality.
1813
1814         * editing/EditingStyle.cpp:
1815         * editing/EditingStyle.h:
1816         * editing/SelectionController.h:
1817         * editing/visible_units.h:
1818         * html/HTMLAudioElement.h:
1819         * html/HTMLBodyElement.h:
1820         * inspector/InspectorCSSAgent.h:
1821         * inspector/InspectorDOMAgent.h:
1822         * inspector/InspectorInstrumentation.h:
1823         * xml/DOMParser.cpp:
1824         * xml/DOMParser.h:
1825         (WebCore::DOMParser::create):
1826         (WebCore::DOMParser::DOMParser):
1827
1828 2010-12-30  Benjamin C Meyer  <bmeyer@rim.com>
1829
1830         Reviewed by Darin Adler.
1831
1832         bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
1833         which is required when NOTIFICATIONS is enabled.
1834
1835         https://bugs.webkit.org/show_bug.cgi?id=51761
1836
1837         * CMakeLists.txt:
1838
1839 2010-12-30  Antti Koivisto  <antti@apple.com>
1840
1841         Not reviewed.
1842
1843         Revert accidental project file change.
1844
1845         * WebCore.xcodeproj/project.pbxproj:
1846
1847 2010-12-30  Antti Koivisto  <antti@apple.com>
1848
1849         Reviewed by Darin Adler.
1850
1851         https://bugs.webkit.org/show_bug.cgi?id=51134
1852         Move loading related code from MemoryCache to CachedResourceLoader
1853
1854         - Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
1855         - Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
1856         - Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
1857         - Add MemoryCache::add
1858         - Refactor the decision on whether to reload, revalidate or use the existing resource to 
1859           a single function, CachedResourceLoader::determineRevalidationPolicy
1860
1861         * css/CSSImageValue.cpp:
1862         (WebCore::CSSImageValue::cachedImage):
1863             
1864             Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
1865             if ever taken (since it passes null CachedResourceLoader pointer).
1866             
1867         * loader/ImageLoader.cpp:
1868         (WebCore::ImageLoader::updateFromElement):
1869         * loader/cache/CachedImage.cpp:
1870         * loader/cache/CachedResource.cpp:
1871         (WebCore::CachedResource::CachedResource):
1872         (WebCore::CachedResource::~CachedResource):
1873         (WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
1874         
1875             Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.
1876         
1877         (WebCore::CachedResource::setLoadPriority):
1878         
1879             Check for Unresolved value before setting.
1880         
1881         * loader/cache/CachedResource.h:
1882         (WebCore::CachedResource::setOwningCachedResourceLoader):
1883         
1884             Rename to be bit less mysterious.
1885         
1886         * loader/cache/CachedResourceLoader.cpp:
1887         (WebCore::createResource):
1888         
1889             This was moved from MemoryCache.
1890         
1891         (WebCore::CachedResourceLoader::~CachedResourceLoader):
1892         (WebCore::CachedResourceLoader::determineRevalidationPolicy):
1893         (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
1894         
1895             This was moved/merged from MemoryCache.
1896         
1897         (WebCore::CachedResourceLoader::canRequest):
1898         (WebCore::CachedResourceLoader::requestResource):
1899         
1900             This combines MemoryCache::requestResource and the existing method.
1901         
1902         (WebCore::CachedResourceLoader::revalidateResource):
1903         
1904             This was moved from MemoryCache.
1905         
1906         (WebCore::CachedResourceLoader::loadResource):
1907         
1908             New method for initiating loading.
1909         
1910         (WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):
1911         
1912             Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus
1913         
1914         * loader/cache/CachedResourceLoader.h:
1915         * loader/cache/MemoryCache.cpp:
1916         (WebCore::MemoryCache::add):
1917         * loader/cache/MemoryCache.h:
1918         (WebCore::MemoryCache::remove):
1919
1920 2010-12-30  Steve Block  <steveblock@google.com>
1921
1922         Reviewed by Gavin Barraclough.
1923
1924         Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
1925         https://bugs.webkit.org/show_bug.cgi?id=51740
1926
1927         This is a policy decision for Android.
1928
1929         No new tests, simply enabling existing, tested code on Android.
1930
1931         * bindings/js/JSDOMWindowBase.cpp:
1932         (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
1933
1934 2010-12-30  Yael Aharon  <yael.aharon@nokia.com>
1935
1936         Reviewed by Adam Barth.
1937
1938         REGRESSION: fast/dom/cssTarget-crash.html fails
1939         https://bugs.webkit.org/show_bug.cgi?id=20342
1940
1941         Do not reload the page when submitting a form, using "GET" method, and the
1942         form action url matches the location url, except for the fragment.
1943       
1944         Test: fast/forms/submit-change-fragment.html
1945
1946         * loader/FrameLoader.cpp:
1947         (WebCore::FrameLoader::loadURL):
1948         (WebCore::FrameLoader::loadWithDocumentLoader):
1949         (WebCore::FrameLoader::shouldScrollToAnchor):
1950         * loader/FrameLoader.h:
1951
1952 2010-12-30  Darin Adler  <darin@apple.com>
1953
1954         Reviewed by Adam Barth.
1955
1956         Move security logic out of the JavaScript binding for location into the DOM class
1957         https://bugs.webkit.org/show_bug.cgi?id=51714
1958
1959         * WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h,
1960         and JSBinding.h. Later, we'll remove them from other project files and delete
1961         the source files.
1962
1963         * bindings/js/JSBinding.h: Emptied out, marked for later deletion.
1964
1965         * bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull
1966         function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL
1967         function, unused toLexicalFrame function, unused completeURL function, unused
1968         getCachedDOMStructure and cacheDOMStructure overloads, and unused
1969         getCachedDOMConstructor and cacheDOMConstruction functions.
1970         (WebCore::activeDOMWindow): Added.
1971         (WebCore::firstDOMWindow): Added.
1972         (WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through
1973         JSBindingState, since the latter is an unneeded abstraction.
1974         (WebCore::processingUserGesture): Changed to call ScriptController's function
1975         rather than calling through JSBindingState, which is an unneeded abstraction
1976
1977         * bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added
1978         activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly
1979         named allowsAccessFromFrame functions, which answer the question of whether
1980         script is allowed access *to* a frame.
1981
1982         * bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes.
1983         (WebCore::JSDOMWindow::setLocation): Streamlined by using the new
1984         activeDOMWindow and firstDOMWindow functions.
1985         (WebCore::JSDOMWindow::open): Ditto.
1986         (WebCore::JSDOMWindow::showModalDialog): Ditto.
1987         (WebCore::JSDOMWindow::postMessage): Ditto.
1988
1989         * bindings/js/JSLocationCustom.cpp:
1990         (WebCore::JSLocation::setHref): Changed to pass the active and first windows through
1991         to the Location::setHref function, with it doing the rest of the work. This moves
1992         work out of the DOM binding that belongs in the DOM itself. Eventually such functions
1993         could even be automatically generated by the bindings script.
1994         (WebCore::JSLocation::setProtocol): Ditto.
1995         (WebCore::JSLocation::setHost): Ditto.
1996         (WebCore::JSLocation::setHostname): Ditto.
1997         (WebCore::JSLocation::setPort): Ditto.
1998         (WebCore::JSLocation::setPathname): Ditto.
1999         (WebCore::JSLocation::setSearch): Ditto.
2000         (WebCore::JSLocation::setHash): Ditto.
2001         (WebCore::JSLocation::replace): Ditto.
2002         (WebCore::JSLocation::reload): Ditto.
2003         (WebCore::JSLocation::assign): Ditto.
2004
2005         * bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
2006         * bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
2007
2008         * page/DOMWindow.cpp:
2009         (WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us
2010         to use this function for Location::replace, which is the same as setLocation except that
2011         it locks both history and the back/forward list.
2012         * page/DOMWindow.h: Ditto.
2013
2014         * page/Location.cpp:
2015         (WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security
2016         logic there does not have to be repeated or even refactored.
2017         (WebCore::Location::setProtocol): Ditto.
2018         (WebCore::Location::setHost): Ditto.
2019         (WebCore::Location::setHostname): Ditto.
2020         (WebCore::Location::setPort): Ditto.
2021         (WebCore::Location::setPathname): Ditto.
2022         (WebCore::Location::setSearch): Ditto.
2023         (WebCore::Location::setHash): Ditto.
2024         (WebCore::Location::assign): Ditto.
2025         (WebCore::Location::replace): Ditto.
2026         (WebCore::Location::reload): Added. Security logic was refactored from the code in
2027         JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems
2028         possibly unneeded.
2029
2030         * page/Location.h: Fixed indentation on the whole file. Added the new functions above.
2031         (WebCore::Location::create):
2032         (WebCore::Location::frame):
2033
2034 2010-12-30  Alexander Pavlov  <apavlov@chromium.org>
2035
2036         Reviewed by Pavel Feldman.
2037
2038         Web Inspector: Pasting a style property with value should automatically split it into prop/value
2039         https://bugs.webkit.org/show_bug.cgi?id=51581
2040
2041         The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
2042         of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
2043         and the edit focus is transferred to the value field.
2044
2045         * inspector/front-end/StylesSidebarPane.js:
2046         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
2047         (WebInspector.StylePropertyTreeElement.prototype):
2048         * inspector/front-end/inspector.js:
2049         (WebInspector.completeURL): Drive-by: return full URLs as-is.
2050         (WebInspector.startEditing.cleanUpAfterEditing):
2051         (WebInspector.startEditing):
2052         (WebInspector.startEditing.pasteEventListener):
2053         (WebInspector.startEditing.keyDownEventListener):
2054
2055 2010-12-30  Pavel Podivilov  <podivilov@chromium.org>
2056
2057         Reviewed by Pavel Feldman.
2058
2059         Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
2060         https://bugs.webkit.org/show_bug.cgi?id=51745
2061
2062         * inspector/front-end/Breakpoint.js:
2063         (WebInspector.Breakpoint.prototype.set enabled):
2064
2065 2010-12-30  Pavel Podivilov  <podivilov@chromium.org>
2066
2067         Reviewed by Pavel Feldman.
2068
2069         Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
2070         https://bugs.webkit.org/show_bug.cgi?id=51748
2071
2072         * inspector/front-end/CallStackSidebarPane.js:
2073         (WebInspector.CallStackSidebarPane.prototype.update):
2074         (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
2075         (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
2076         (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
2077
2078 2010-12-30  Mikhail Naganov  <mnaganov@chromium.org>
2079
2080         Reviewed by Pavel Feldman.
2081
2082         Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).
2083
2084         https://bugs.webkit.org/show_bug.cgi?id=51713
2085
2086         * WebCore.gypi:
2087         * WebCore.pro:
2088         * bindings/v8/custom/V8ConsoleCustom.cpp:
2089         (WebCore::V8Console::memoryAccessorGetter):
2090         * bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp.
2091         (WebCore::V8Performance::memoryAccessorGetter):
2092         * page/Console.idl:
2093         * page/Performance.idl:
2094
2095 2010-12-30  Steve Block  <steveblock@google.com>
2096
2097         Reviewed by Sam Weinig.
2098
2099         Visiting macnn.com often causes SQL spew via geolocation database
2100         https://bugs.webkit.org/show_bug.cgi?id=51557
2101
2102         If the Geolocation position cache database path has not been set, early-out
2103         rather than using an empty path and thus failing to open the database.
2104         This avoids SQL log spew.
2105
2106         Also, avoid starting the database thread until the path has been set, and
2107         shorten the thread name to avoid warnings due to exceeding 30 characters.
2108
2109         No new tests, implementation clean-up only.
2110
2111         * page/GeolocationPositionCache.cpp:
2112         (WebCore::GeolocationPositionCache::addUser):
2113         (WebCore::GeolocationPositionCache::removeUser):
2114         (WebCore::GeolocationPositionCache::setDatabasePath):
2115         (WebCore::GeolocationPositionCache::startBackgroundThread):
2116
2117 2010-12-29  Philippe Normand  <pnormand@igalia.com>
2118
2119         Reviewed by Martin Robinson.
2120
2121         [GTK] minimal build fails at link time due to missing sqlite3 symbols
2122         https://bugs.webkit.org/show_bug.cgi?id=51327
2123
2124         Guard the code calling sqlite3 with the ENABLE(DATABASE) check.
2125
2126         No new tests, build fix only.
2127
2128         * platform/sql/SQLiteAuthorizer.cpp:
2129         * platform/sql/SQLiteDatabase.cpp:
2130         * platform/sql/SQLiteFileSystem.cpp:
2131         * platform/sql/SQLiteStatement.cpp:
2132         * platform/sql/SQLiteTransaction.cpp:
2133
2134 2010-12-30  Justin Schuh  <jschuh@chromium.org>
2135
2136         Reviewed by Dirk Schulze.
2137
2138         Prevent stringToLengthType() from skipping past end-of-string on invalid length unit. 
2139         https://bugs.webkit.org/show_bug.cgi?id=51692
2140
2141         * svg/SVGLength.cpp:
2142         (WebCore::stringToLengthType):
2143         (WebCore::SVGLength::setValueAsString):
2144
2145 2010-12-30  Abhishek Arya  <inferno@chromium.org>
2146
2147         Reviewed by Eric Seidel.
2148
2149         Create a helper function for finding descendent video elements for a node.
2150         https://bugs.webkit.org/show_bug.cgi?id=51696
2151
2152         Test: media/video-element-other-namespace-crash.html
2153
2154         * html/MediaDocument.cpp:
2155         (WebCore::descendentVideoElement): helper function.
2156         (WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions.
2157         (WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.
2158
2159 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
2160
2161         Reviewed by Yury Semikhatsky.
2162
2163         Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
2164         https://bugs.webkit.org/show_bug.cgi?id=51707
2165
2166         This change brushes up storage agents + removes redundant InspectorBackend class.
2167
2168         * CMakeLists.txt:
2169         * GNUmakefile.am:
2170         * WebCore.gypi:
2171         * WebCore.pro:
2172         * WebCore.vcproj/WebCore.vcproj:
2173         * WebCore.xcodeproj/project.pbxproj:
2174         * inspector/CodeGeneratorInspector.pm:
2175         * inspector/InjectedScriptHost.cpp:
2176         (WebCore::InjectedScriptHost::databaseForId):
2177         (WebCore::InjectedScriptHost::selectDatabase):
2178         (WebCore::InjectedScriptHost::selectDOMStorage):
2179         (WebCore::InjectedScriptHost::inspectorDOMAgent):
2180         * inspector/Inspector.idl:
2181         * inspector/InspectorBackend.cpp: Removed.
2182         * inspector/InspectorBackend.h: Removed.
2183         * inspector/InspectorController.cpp:
2184         (WebCore::InspectorController::InspectorController):
2185         (WebCore::InspectorController::~InspectorController):
2186         (WebCore::InspectorController::connectFrontend):
2187         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
2188         (WebCore::InspectorController::didUseDOMStorage):
2189         (WebCore::InspectorController::setInjectedScriptSource):
2190         (WebCore::InspectorController::dispatchOnInjectedScript):
2191         (WebCore::InspectorController::releaseWrapperObjectGroup):
2192         * inspector/InspectorController.h:
2193         * inspector/InspectorDOMStorageAgent.cpp: Added.
2194         (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
2195         (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
2196         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
2197         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
2198         (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
2199         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2200         (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
2201         * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
2202         (WebCore::InspectorDOMStorageAgent::create):
2203         (WebCore::InspectorDOMStorageAgent::frontend):
2204         * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
2205         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
2206         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
2207         (WebCore::InspectorDatabaseAgent::executeSQL):
2208         (WebCore::InspectorDatabaseAgent::databaseForId):
2209         (WebCore::InspectorDatabaseAgent::selectDatabase):
2210         (WebCore::InspectorDatabaseAgent::clearFrontend):
2211         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
2212         * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
2213         (WebCore::InspectorDatabaseAgent::create):
2214         (WebCore::InspectorDatabaseAgent::frontend):
2215         * inspector/front-end/ScriptsPanel.js:
2216         (WebInspector.ScriptsPanel.prototype.show):
2217         (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
2218         (WebInspector.ScriptsPanel.prototype._toggleDebugging):
2219
2220 2010-12-29  Dirk Schulze  <krit@webkit.org>
2221
2222         Reviewed by Darin Adler.
2223
2224         Cleanup SVG code according to the webkit style rules 3
2225         https://bugs.webkit.org/show_bug.cgi?id=51490
2226
2227         Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
2228         Just one file can't be fixed for check-webkit-style.
2229         * SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning
2230
2231         No changes of functionality, so no new tests. 
2232
2233         * svg/SVGAllInOne.cpp:
2234         * svg/SVGImage.cpp:
2235         * svg/SVGLength.cpp:
2236         (WebCore::SVGLength::setValue):
2237         * svg/SVGPolygonElement.h:
2238         * svg/SVGPolylineElement.h:
2239         * svg/SVGPreserveAspectRatio.cpp:
2240         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
2241         (WebCore::SVGPreserveAspectRatio::transformRect):
2242         * svg/SVGSVGElement.cpp:
2243         (WebCore::SVGSVGElement::viewport):
2244         * svg/SVGSetElement.h:
2245         * svg/SVGStylable.h:
2246         (WebCore::SVGStylable::~SVGStylable):
2247         * svg/SVGStyledLocatableElement.h:
2248         (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
2249         (WebCore::SVGStyledLocatableElement::isStyledLocatable):
2250         * svg/SVGStyledTransformableElement.cpp:
2251         (WebCore::SVGStyledTransformableElement::isKnownAttribute):
2252         * svg/SVGSwitchElement.cpp:
2253         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
2254         * svg/SVGTests.cpp:
2255         (WebCore::SVGTests::parseMappedAttribute):
2256         * svg/SVGTextContentElement.cpp:
2257         (WebCore::SVGTextContentElement::isKnownAttribute):
2258         * svg/SVGTextPathElement.cpp:
2259         * svg/SVGTextPathElement.h:
2260         * svg/SVGTitleElement.h:
2261         (WebCore::SVGTitleElement::rendererIsNeeded):
2262         * svg/SVGTransformDistance.cpp:
2263         (WebCore::SVGTransformDistance::SVGTransformDistance):
2264         (WebCore::SVGTransformDistance::scaledDistance):
2265         (WebCore::SVGTransformDistance::addSVGTransforms):
2266         (WebCore::SVGTransformDistance::addSVGTransform):
2267         (WebCore::SVGTransformDistance::addToSVGTransform):
2268         (WebCore::SVGTransformDistance::isZero):
2269         * svg/SVGTransformList.cpp:
2270         * svg/SVGURIReference.cpp:
2271         (WebCore::SVGURIReference::getTarget):
2272         * svg/SVGVKernElement.h:
2273         * svg/SVGViewSpec.cpp:
2274         (WebCore::SVGViewSpec::parseViewSpec):
2275         * svg/SVGZoomAndPan.h:
2276         (WebCore::SVGZoomAndPan::SVGZoomAndPan):
2277         (WebCore::SVGZoomAndPan::~SVGZoomAndPan):
2278         (WebCore::SVGZoomAndPan::zoomAndPan):
2279         * svg/SVGZoomEvent.h:
2280         (WebCore::SVGZoomEvent::create):
2281         * svg/animation/SMILTime.cpp:
2282         (WebCore::operator*):
2283         * svg/animation/SMILTime.h:
2284         (WebCore::SMILTime::SMILTime):
2285         (WebCore::SMILTime::unresolved):
2286         (WebCore::SMILTime::indefinite):
2287         (WebCore::SMILTime::operator=):
2288         (WebCore::SMILTime::value):
2289         (WebCore::SMILTime::isFinite):
2290         (WebCore::SMILTime::isIndefinite):
2291         (WebCore::SMILTime::isUnresolved):
2292         (WebCore::operator==):
2293         (WebCore::operator!): new operator checks for 0 or infinite values.
2294         (WebCore::operator!=):
2295         (WebCore::operator>):
2296         (WebCore::operator<):
2297         (WebCore::operator>=):
2298         (WebCore::operator<=):
2299         * svg/animation/SMILTimeContainer.h:
2300         (WebCore::SMILTimeContainer::create):
2301         (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
2302         * svg/animation/SVGSMILElement.cpp:
2303         (WebCore::ConditionEventListener::operator==):
2304         (WebCore::SVGSMILElement::repeatingDuration):
2305         (WebCore::SVGSMILElement::resolveInterval):
2306         (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
2307         * svg/animation/SVGSMILElement.h:
2308         (WebCore::SVGSMILElement::timeContainer):
2309         (WebCore::SVGSMILElement::intervalBegin):
2310         (WebCore::SVGSMILElement::intervalEnd):
2311         (WebCore::SVGSMILElement::previousIntervalBegin):
2312         (WebCore::SVGSMILElement::documentOrderIndex):
2313         (WebCore::SVGSMILElement::setDocumentOrderIndex):
2314         * svg/graphics/SVGImage.h:
2315         (WebCore::SVGImage::create):
2316         (WebCore::SVGImage::destroyDecodedData):
2317         (WebCore::SVGImage::decodedSize):
2318         (WebCore::SVGImage::frameAtIndex):
2319         * svg/graphics/filters/SVGFilterBuilder.h:
2320         (WebCore::SVGFilterBuilder::create):
2321         (WebCore::SVGFilterBuilder::lastEffect):
2322         (WebCore::SVGFilterBuilder::getEffectReferences):
2323         (WebCore::SVGFilterBuilder::addBuiltinEffects):
2324
2325 2010-12-29  Abhishek Arya  <inferno@chromium.org>
2326
2327         Reviewed by Darin Adler.
2328
2329         ASSERT(oldchild->parent() == owner) fails.
2330         https://bugs.webkit.org/show_bug.cgi?id=50480
2331
2332         In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
2333         is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
2334         assertion failure when removeChildNode executes on the child(equal to prev or next).
2335         Fix a typo in canMergeContiguousAnonymousBlocks.
2336
2337         Test: fast/multicol/span/double-merge-anonymous-block-crash.html
2338
2339         * rendering/RenderBlock.cpp:
2340         (WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next.
2341         (WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.
2342
2343 2010-12-29  Justin Schuh  <jschuh@chromium.org>
2344
2345         Reviewed by Darin Adler.
2346
2347         Check SVG element type in FrameView::scrollToAnchor
2348         https://bugs.webkit.org/show_bug.cgi?id=51718
2349
2350         Test: svg/custom/scroll-to-anchor-in-symbol.svg
2351
2352         * page/FrameView.cpp:
2353         (WebCore::FrameView::scrollToAnchor):
2354
2355 2010-12-29  Anton Muhin  <antonm@chromium.org>
2356
2357         Reviewed by Eric Seidel.
2358
2359         [v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
2360         https://bugs.webkit.org/show_bug.cgi?id=51704
2361
2362         * bindings/v8/V8DOMWindowShell.cpp:
2363         * bindings/v8/V8DOMWindowShell.h:
2364
2365 2010-12-29  Kenichi Ishibashi  <bashi@google.com>
2366
2367         Reviewed by Darin Adler.
2368
2369         Use a HashMap for m_continuation to save memory
2370         https://bugs.webkit.org/show_bug.cgi?id=43716
2371
2372         Saving memory consumption by applying a HashMap convention to
2373         continuation pointers of RenderInline and RenderBlock classes.
2374
2375         * rendering/RenderBlock.cpp: Removed m_continuation.
2376         (WebCore::RenderBlock::RenderBlock):
2377         (WebCore::RenderBlock::destroy):
2378         (WebCore::RenderBlock::inlineElementContinuation):
2379         (WebCore::RenderBlock::blockElementContinuation):
2380         * rendering/RenderBlock.h: Removed m_continuation.
2381         * rendering/RenderBoxModelObject.cpp: Added a hash map for continuations.
2382         (WebCore::RenderBoxModelObject::destroy): Added an assertion.
2383         (WebCore::RenderBoxModelObject::continuation): Added.
2384         (WebCore::RenderBoxModelObject::setContinuation): Added.
2385         * rendering/RenderBoxModelObject.h:
2386         * rendering/RenderInline.cpp: Removed m_continuation.
2387         (WebCore::RenderInline::RenderInline):
2388         (WebCore::RenderInline::destroy):
2389         (WebCore::RenderInline::inlineElementContinuation):
2390         * rendering/RenderInline.h: Removed m_continuation.
2391
2392 2010-12-27  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2393
2394         Reviewed by Martin Robinson.
2395
2396         [GTK] Enable building whatever already exists of WebKit2
2397         https://bugs.webkit.org/show_bug.cgi?id=37369
2398
2399         No new functionality added or deleted. Only makefile change. Hence, no tests added.
2400
2401         * GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and
2402         added them to WebKit/gtk/GNUmakefile.am
2403         * platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h>
2404         and declare WEBKIT_API directly
2405
2406 2010-12-29  Eric Seidel  <eric@webkit.org>
2407
2408         Unreviewed.
2409
2410         Simplify make-hash-tools.pl
2411         https://bugs.webkit.org/show_bug.cgi?id=49922
2412
2413         Added HashTools.h to the project file now that its not autogenerated.
2414         I also sorted the project file using sort-xcode-project-file
2415
2416         * WebCore.xcodeproj/project.pbxproj:
2417
2418 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
2419
2420         Not reviewed: revert r74755 and 74757.
2421
2422 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2423
2424         Reviewed by Sam Weinig.
2425
2426         JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
2427         https://bugs.webkit.org/show_bug.cgi?id=51722
2428
2429         Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
2430         methods the fastcall calling convention, which leads to runtime errors when they are
2431         called from C++. Also remove a bit of unnecessary code duplication.
2432
2433         No new tests. This is covered by fast/canvas/webgl/data-view-test.html.
2434
2435         * bindings/js/JSDataViewCustom.cpp:
2436         (WebCore::getDataViewMember): Remove duplicated code.
2437         (WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL.
2438         (WebCore::JSDataView::getUint8): Ditto.
2439         (WebCore::JSDataView::getFloat32): Ditto.
2440         (WebCore::JSDataView::getFloat64): Ditto.
2441         (WebCore::setDataViewMember): Remove duplicated code.
2442         (WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL.
2443         (WebCore::JSDataView::setUint8): Ditto.
2444
2445 2010-12-29  Dan Bernstein  <mitz@apple.com>
2446
2447         Reviewed by Kenneth Russel.
2448
2449         A more robust fix for https://bugs.webkit.org/show_bug.cgi?id=51681
2450
2451         * html/HTMLCanvasElement.cpp:
2452         (WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
2453         CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
2454         attach-type style recalc.
2455         * html/HTMLCanvasElement.h:
2456         * html/canvas/CanvasRenderingContext2D.cpp:
2457         (WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
2458         r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
2459         (WebCore::CanvasRenderingContext2D::accessFont): Added a call to
2460         Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
2461         and update the font if it is invalid.
2462         * platform/graphics/Font.h:
2463         (WebCore::Font::loadingCustomFonts): Made this private.
2464
2465 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
2466
2467         Not reviewed: Qt build fix.
2468
2469         * inspector/InspectorController.cpp:
2470
2471 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
2472
2473         Reviewed by Yury Semikhatsky.
2474
2475         Web Inspector: extract Database & DOM Storage
2476         agents; remove InspectorBackend.
2477         https://bugs.webkit.org/show_bug.cgi?id=51707
2478
2479         This change brushes up storage agents + removes redundant
2480         InspectorBackend class.
2481
2482         * CMakeLists.txt:
2483         * GNUmakefile.am:
2484         * WebCore.gypi:
2485         * WebCore.pro:
2486         * WebCore.vcproj/WebCore.vcproj:
2487         * WebCore.xcodeproj/project.pbxproj:
2488         * inspector/CodeGeneratorInspector.pm:
2489         * inspector/InjectedScriptHost.cpp:
2490         (WebCore::InjectedScriptHost::databaseForId):
2491         (WebCore::InjectedScriptHost::selectDatabase):
2492         (WebCore::InjectedScriptHost::selectDOMStorage):
2493         (WebCore::InjectedScriptHost::inspectorDOMAgent):
2494         * inspector/Inspector.idl:
2495         * inspector/InspectorBackend.cpp: Removed.
2496         * inspector/InspectorBackend.h: Removed.
2497         * inspector/InspectorController.cpp:
2498         (WebCore::InspectorController::InspectorController):
2499         (WebCore::InspectorController::~InspectorController):
2500         (WebCore::InspectorController::connectFrontend):
2501         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
2502         (WebCore::InspectorController::didUseDOMStorage):
2503         (WebCore::InspectorController::setInjectedScriptSource):
2504         (WebCore::InspectorController::dispatchOnInjectedScript):
2505         (WebCore::InspectorController::releaseWrapperObjectGroup):
2506         * inspector/InspectorController.h:
2507         * inspector/InspectorDOMStorageAgent.cpp: Added.
2508         (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
2509         (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
2510         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
2511         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
2512         (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
2513         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2514         (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
2515         * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
2516         (WebCore::InspectorDOMStorageAgent::create):
2517         (WebCore::InspectorDOMStorageAgent::frontend):
2518         * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
2519         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
2520         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
2521         (WebCore::InspectorDatabaseAgent::executeSQL):
2522         (WebCore::InspectorDatabaseAgent::databaseForId):
2523         (WebCore::InspectorDatabaseAgent::selectDatabase):
2524         (WebCore::InspectorDatabaseAgent::clearFrontend):
2525         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
2526         * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
2527         (WebCore::InspectorDatabaseAgent::create):
2528         (WebCore::InspectorDatabaseAgent::frontend):
2529         * inspector/InspectorFrontendClientLocal.cpp:
2530         * inspector/InspectorFrontendClientLocal.h:
2531         * inspector/front-end/ScriptsPanel.js:
2532         (WebInspector.ScriptsPanel.prototype.show):
2533
2534 2010-12-29  Tony Gentilcore  <tonyg@chromium.org>
2535
2536         Reviewed by Eric Seidel.
2537
2538         Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
2539         https://bugs.webkit.org/show_bug.cgi?id=51067
2540
2541         Typically when a script element is removed from the document, the cached script
2542         client is removed. However, during the before load event, the cached script client
2543         hasn't been created yet so it can't be removed.
2544
2545         This patch handles that case by explicitly checking if the script element was
2546         removed during the beforeload event. Also, it avoids caching the Document references
2547         over the arbitrary script execution in the before load event.
2548
2549         Test: fast/dom/HTMLScriptElement/move-in-beforeload.html
2550               fast/dom/HTMLScriptElement/remove-in-beforeload.html
2551
2552         * dom/ScriptElement.cpp:
2553         (WebCore::ScriptElement::requestScript):
2554
2555 2010-12-29  Alexander Pavlov  <apavlov@chromium.org>
2556
2557         Reviewed by Yury Semikhatsky.
2558
2559         Web Inspector: Element highlight tooltip displays wrong element size when zoomed in
2560         https://bugs.webkit.org/show_bug.cgi?id=51703
2561
2562         * inspector/InspectorController.cpp:
2563         (WebCore::InspectorController::drawElementTitle):
2564
2565 2010-12-29  Yael Aharon  <yael.aharon@nokia.com>
2566
2567         Reviewed by Kent Tamura.
2568
2569         [HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
2570         https://bugs.webkit.org/show_bug.cgi?id=29071
2571
2572         Use InputType::rangeUnderflow() and InputType::rangeOverflow()
2573         to determine if a control is in-range or out-of-range.
2574
2575         Tests: fast/css/pseudo-in-range-invalid-value.html
2576                fast/css/pseudo-in-range.html
2577                fast/css/pseudo-out-of-range.html
2578
2579         * css/CSSSelector.cpp:
2580         (WebCore::CSSSelector::pseudoId):
2581         (WebCore::nameToPseudoTypeMap):
2582         (WebCore::CSSSelector::extractPseudoType):
2583         * css/CSSSelector.h:
2584         * css/CSSStyleSelector.cpp:
2585         (WebCore::CSSStyleSelector::canShareStyleWithElement):
2586         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
2587         * dom/Element.h:
2588         (WebCore::Element::isInRange):
2589         (WebCore::Element::isOutOfRange):
2590         * html/BaseDateAndTimeInputType.cpp:
2591         (WebCore::BaseDateAndTimeInputType::supportsRangeLimitation):
2592         * html/BaseDateAndTimeInputType.h:
2593         * html/HTMLInputElement.cpp:
2594         (WebCore::HTMLInputElement::isInRange):
2595         (WebCore::HTMLInputElement::isOutOfRange):
2596         * html/HTMLInputElement.h:
2597         * html/InputType.cpp:
2598         (WebCore::InputType::supportsRangeLimitation):
2599         * html/InputType.h:
2600         * html/NumberInputType.cpp:
2601         (WebCore::NumberInputType::supportsRangeLimitation):
2602         * html/NumberInputType.h:
2603         * html/RangeInputType.cpp:
2604         (WebCore::RangeInputType::supportsRangeLimitation):
2605         * html/RangeInputType.h:
2606
2607 2010-12-29  Abhishek Arya  <inferno@chromium.org>
2608
2609         Reviewed by Eric Seidel.
2610
2611         When cloning an anonymous block, make sure to set the childrenInline flag based
2612         on the state of the block to be cloned.
2613         https://bugs.webkit.org/show_bug.cgi?id=51489
2614
2615         Test: fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html
2616
2617         * rendering/RenderBlock.cpp:
2618         (WebCore::RenderBlock::clone): add code to handle cloning of anonymous blocks.
2619         (WebCore::RenderBlock::splitBlocks): remove anonymous block creation calls since it is now handled by clone().
2620
2621 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2622
2623         Unreviewed build fix for WinCE after r73802.
2624
2625         Reapply parts from r72585:
2626         Port ContextMenuWin.cpp to WinCE
2627         https://bugs.webkit.org/show_bug.cgi?id=48408
2628
2629         * CMakeLists.txt:
2630         * platform/ContextMenu.h:
2631         * platform/win/ContextMenuWin.cpp:
2632         (WebCore::ContextMenu::getContextMenuItems):
2633         (WebCore::ContextMenu::createNativeMenuFromItems):
2634
2635 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2636
2637         Reviewed by Simon Hausmann.
2638
2639         [Qt] Fix compilation with Qt in namespace
2640         https://bugs.webkit.org/show_bug.cgi?id=51701
2641
2642         * platform/graphics/ContextShadow.h:
2643         * platform/graphics/GraphicsContext3D.h:
2644         * platform/network/NetworkingContext.h:
2645         * platform/network/qt/QtNAMThreadSafeProxy.h:
2646         * plugins/PluginView.h:
2647
2648 2010-12-28  Alexander Pavlov  <apavlov@chromium.org>
2649
2650         Reviewed by Pavel Feldman.
2651
2652         Web Inspector: A disabled style property should get enabled when edited
2653         https://bugs.webkit.org/show_bug.cgi?id=51679
2654
2655         Test: inspector/styles-disable-then-change.html
2656
2657         * inspector/front-end/CSSStyleModel.js:
2658         (WebInspector.CSSProperty.prototype.setText):
2659         (WebInspector.CSSProperty.prototype.setText.callback):
2660
2661 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2662
2663         Reviewed by Andreas Kling.
2664
2665         [CMake] Remove WebKitGenerators
2666         https://bugs.webkit.org/show_bug.cgi?id=50445
2667
2668         * CMakeLists.txt: Pass preprocessor to generate-bindings.pl.
2669
2670 2010-12-28  Pratik Solanki  <psolanki@apple.com>
2671
2672         Reviewed by Eric Seidel.
2673
2674         https://bugs.webkit.org/show_bug.cgi?id=51522
2675         Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()
2676
2677         * page/win/FrameCGWin.cpp:
2678         (WebCore::imageFromRect):
2679         * platform/graphics/cg/GradientCG.cpp:
2680         (WebCore::Gradient::platformGradient):
2681         * platform/graphics/cg/GraphicsContext3DCG.cpp:
2682         (WebCore::GraphicsContext3D::paintToCanvas):
2683         * platform/graphics/cg/ImageCG.cpp:
2684         (WebCore::BitmapImage::checkForSolidColor):
2685         * platform/graphics/gstreamer/ImageGStreamerCG.mm:
2686         (ImageGStreamer::ImageGStreamer):
2687         * platform/graphics/win/GraphicsContextCGWin.cpp:
2688         (WebCore::CGContextWithHDC):
2689         (WebCore::GraphicsContext::releaseWindowsContext):
2690         (WebCore::GraphicsContext::drawWindowsBitmap):
2691         * platform/graphics/win/ImageCGWin.cpp:
2692         (WebCore::BitmapImage::create):
2693         (WebCore::BitmapImage::getHBITMAPOfSize):
2694         * platform/image-decoders/cg/ImageDecoderCG.cpp:
2695         (WebCore::createColorSpace):
2696         * platform/win/DragImageCGWin.cpp:
2697         (WebCore::allocImage):
2698         (WebCore::createCgContextFromBitmap):
2699         * rendering/RenderThemeMac.mm:
2700         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
2701         (WebCore::RenderThemeMac::paintSliderTrack):
2702         * rendering/RenderThemeSafari.cpp:
2703         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
2704         (WebCore::RenderThemeSafari::paintSliderTrack):
2705
2706 2010-12-28  Daniel Bates  <dbates@rim.com>
2707
2708         Reviewed by Sam Weinig.
2709
2710         Substitute // MARK: for compiler-specific #pragma mark
2711         https://bugs.webkit.org/show_bug.cgi?id=51657
2712
2713         Fix compilation warnings about "#pragma mark" on GTK+ bots by
2714         substituting  "// MARK:" for "#pragma mark", which provides
2715         analogous code-bookmarking functionality under Xcode.
2716
2717         * platform/graphics/cg/PathCG.cpp:
2718         * platform/graphics/mac/WebLayer.mm:
2719
2720 2010-12-28  Jan Erik Hanssen  <jhanssen@sencha.com>
2721
2722         Reviewed by Eric Seidel.
2723
2724         [Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
2725         https://bugs.webkit.org/show_bug.cgi?id=51687
2726
2727         Use a const reference instead of a copy of QPainter::combinedTransform() 
2728         in GraphicsContext::getCTM()
2729
2730         * platform/graphics/qt/GraphicsContextQt.cpp:
2731         (WebCore::GraphicsContext::getCTM):
2732
2733 2010-12-28  Takashi Toyoshima  <toyoshim@google.com>
2734
2735         Reviewed by Eric Seidel.
2736
2737         gcc detected 'control reaches end of non-void function' with
2738         -finstrument-functions option.
2739         https://bugs.webkit.org/show_bug.cgi?id=51669
2740
2741         No new tests. These fixes are trivial.
2742
2743         * dom/Element.cpp:
2744         (WebCore::Element::childTypeAllowed):
2745         * inspector/InspectorResourceAgent.cpp:
2746         (WebCore::cachedResourceTypeString):
2747
2748 2010-12-28  Tony Gentilcore  <tonyg@chromium.org>
2749
2750         Reviewed by Eric Seidel.
2751
2752         Remove unused member of PendingScript
2753         https://bugs.webkit.org/show_bug.cgi?id=51684
2754
2755         This was used when HTMLScriptRunner::runScript created a PendingScript
2756         for inline scripts. But now it just calls executeScript() directly.
2757         External scripts always have the minimum starting line number.
2758
2759         No new tests because no changed functionality.
2760
2761         * dom/PendingScript.cpp:
2762         (WebCore::PendingScript::releaseElementAndClear):
2763         * dom/PendingScript.h:
2764         (WebCore::PendingScript::PendingScript):
2765         (WebCore::PendingScript::operator=):
2766         * html/parser/HTMLScriptRunner.cpp:
2767         (WebCore::HTMLScriptRunner::sourceFromPendingScript):
2768
2769 2010-12-20  Antonio Gomes  <agomes@rim.com>
2770
2771         Reviewed by Daniel Bates.
2772
2773         Spatial Navigation: code clean up (Part VI)
2774         https://bugs.webkit.org/show_bug.cgi?id=50666
2775
2776         No new tests needed.
2777
2778         * page/FocusController.cpp:
2779         (WebCore::updatFocusCandidateIfNeeded): Assert renderer() and
2780         isElementNode() now that we are bailing out earlier in both the
2781         FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
2782         * page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection
2783         and virtualRectForAreaElementAndDirection functions.
2784         (WebCore::FocusController::findFocusCandidateInContainer):
2785         (WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted callsites
2786         of canScrollInDirection(), and added an early return if !isElementNode().
2787         (WebCore::FocusController::advanceFocusDirectionally): Adjusted callsite of
2788         virtualRectForAreaElementAndDirection();
2789         * page/SpatialNavigation.cpp:
2790         (WebCore::FocusCandidate::FocusCandidate): Assert if node is not a element node;
2791         (WebCore::isScrollableNode): Renamed from isScrollableContainerNode;
2792         (WebCore::scrollInDirection): Adjusted callsite after function name change;
2793         (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is
2794         a documentNode.
2795         (WebCore::canScrollInDirection): Signature changed.
2796         (WebCore::canBeScrolledIntoView): Ditto.
2797         (WebCore::virtualRectForAreaElementAndDirection): Ditto.
2798
2799 2010-12-28  Adrienne Walker  <enne@google.com>
2800
2801         Reviewed by Kenneth Russell.
2802
2803         [chromium] Fix tiled compositor assertion after GPU process recovery.
2804         https://bugs.webkit.org/show_bug.cgi?id=51682
2805
2806         After the GPU process recovers, the layer size is set to IntSize(),
2807         but IntRect::unite() has a special case for empty rects.  This
2808         behavior was causing the layer size to be too small, causing an
2809         out-of-bounds array access elsewhere.
2810
2811         No new tests.
2812
2813         * platform/graphics/chromium/LayerTilerChromium.cpp:
2814         (WebCore::LayerTilerChromium::growLayerToContain):
2815
2816 2010-12-23  Zhenyao Mo  <zmo@google.com>
2817
2818         Reviewed by Kenneth Russell.
2819
2820         Initialize to 0 for undefined values in CopyTexImage2D
2821         https://bugs.webkit.org/show_bug.cgi?id=51421
2822
2823         * html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer.
2824         (WebCore::WebGLFramebuffer::WebGLFramebuffer):
2825         (WebCore::WebGLFramebuffer::setAttachment):
2826         (WebCore::WebGLFramebuffer::getWidth):
2827         (WebCore::WebGLFramebuffer::getHeight):
2828         (WebCore::WebGLFramebuffer::getColorBufferFormat):
2829         * html/canvas/WebGLFramebuffer.h:
2830         * html/canvas/WebGLRenderingContext.cpp:
2831         (WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0.
2832         (WebCore::WebGLRenderingContext::copyTexSubImage2D):
2833         (WebCore::WebGLRenderingContext::framebufferTexture2D):
2834         (WebCore::WebGLRenderingContext::renderbufferStorage):
2835         (WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
2836         (WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
2837         * html/canvas/WebGLRenderingContext.h:
2838         * html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level.
2839         (WebCore::WebGLTexture::getInternalFormat):
2840         (WebCore::WebGLTexture::getWidth):
2841         (WebCore::WebGLTexture::getHeight):
2842         (WebCore::WebGLTexture::mapTargetToIndex):
2843         (WebCore::WebGLTexture::getLevelInfo):
2844         * html/canvas/WebGLTexture.h:
2845         (WebCore::WebGLTexture::isTexture):
2846         * platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
2847         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
2848         (WebCore::GraphicsContext3D::getInternalFramebufferSize):
2849         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2850         (WebCore::GraphicsContext3D::getInternalFramebufferSize):
2851
2852 2010-12-23  Zhenyao Mo  <zmo@google.com>
2853
2854         Reviewed by Kenneth Russell.
2855
2856         Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
2857         https://bugs.webkit.org/show_bug.cgi?id=39855
2858
2859         * html/canvas/WebGLRenderingContext.cpp:
2860         (WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long.
2861         (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
2862         (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
2863         (WebCore::WebGLRenderingContext::scissor): Ditto.
2864         (WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
2865         (WebCore::WebGLRenderingContext::texImage2D): Ditto.
2866         (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto.
2867         (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
2868         (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
2869         (WebCore::WebGLRenderingContext::viewport): Ditto.
2870         (WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
2871         * html/canvas/WebGLRenderingContext.h:
2872         * html/canvas/WebGLRenderingContext.idl:
2873
2874 2010-12-28  Abhishek Arya  <inferno@chromium.org>
2875
2876         Reviewed by Kenneth Russell.
2877
2878         Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
2879         process of loading.
2880         https://bugs.webkit.org/show_bug.cgi?id=51681
2881
2882         Test: canvas/philip/tests/2d.text-custom-font-load-crash.html
2883
2884         * html/canvas/CanvasRenderingContext2D.cpp:
2885         (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
2886         * platform/graphics/Font.cpp:
2887         (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts()
2888         (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts()
2889         (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
2890         * platform/graphics/Font.h:
2891         (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.
2892
2893 2010-12-28  Dimitri Glazkov  <dglazkov@chromium.org>
2894
2895         Reviewed by Eric Seidel.
2896
2897         Combine setShadowRoot and clearShadowRoot into a simpler API
2898         https://bugs.webkit.org/show_bug.cgi?id=50971
2899
2900         No change in behavior, and API is not used yet.
2901
2902         * dom/Element.cpp:
2903         (WebCore::Element::setShadowRoot): Combined clearing and setting of
2904             the shadowRoot, also hooked up with setting and clearing of the
2905             corresponding shadowHost values.
2906         * dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it
2907             private.
2908         * dom/Node.h: Made shadow host-related functions public so that
2909             Element::setShadowRoot can access setShadowHost. It seems logical
2910             to make shadowHost public as well to keep the defs together.
2911
2912 2010-12-28  Andrey Kosyakov  <caseq@chromium.org>
2913
2914         Reviewed by Pavel Feldman.
2915
2916         Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
2917         Do not request content for resources with non-numeric identifiers.
2918         https://bugs.webkit.org/show_bug.cgi?id=49727
2919
2920         Test: http/tests/inspector/extensions-resources-redirect.html
2921
2922         * inspector/front-end/NetworkManager.js:
2923         (WebInspector.NetworkManager.prototype._appendRedirect):
2924
2925 2010-12-28  Ilya Tikhonovsky  <loislo@chromium.org>
2926
2927         Unreviewed build fix for Qt.
2928
2929         ResourceTreeModel.js was added.
2930
2931         * inspector/front-end/WebKit.qrc:
2932
2933 2010-12-28  Mikhail Naganov  <mnaganov@chromium.org>
2934
2935         Reviewed by Pavel Feldman.
2936
2937         [Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.
2938
2939         https://bugs.webkit.org/show_bug.cgi?id=51680
2940
2941         * inspector/front-end/ProfilesPanel.js:
2942         (WebInspector.ProfilesPanel.prototype._reset):
2943
2944 2010-12-28  Alexander Pavlov  <apavlov@chromium.org>
2945
2946         Reviewed by Pavel Feldman.
2947
2948         Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
2949         https://bugs.webkit.org/show_bug.cgi?id=51663
2950
2951         The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
2952         optional quotes/apostrophes and spaces are now allowed inside uri(...).
2953
2954         Test: inspector/styles-url-linkify.html
2955
2956         * inspector/front-end/StylesSidebarPane.js:
2957         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
2958         (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
2959
2960 2010-12-21  Ilya Tikhonovsky  <loislo@chromium.org>
2961
2962         Reviewed by Pavel Feldman.
2963
2964         Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.
2965
2966         Domain was changed for Resources, FileSystem etc. related methods.
2967         ResourcesManager was renamed to NetworkManager.
2968         ResourceTreeModel was extracted as separate file.
2969         FileSystem, Database, DOMStorage and ApplicationCache methods were
2970         removed from NetworkManager and added to corresponding classes.
2971
2972         https://bugs.webkit.org/show_bug.cgi?id=51334
2973
2974         * WebCore.gypi:
2975         * WebCore.vcproj/WebCore.vcproj:
2976         * inspector/CodeGeneratorInspector.pm:
2977         * inspector/Inspector.idl:
2978         * inspector/front-end/AuditRules.js:
2979         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
2980         * inspector/front-end/CSSStyleModel.js:
2981         (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
2982         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
2983         * inspector/front-end/ConsoleView.js:
2984         (WebInspector.ConsoleView.prototype.addMessage):
2985         (WebInspector.ConsoleView.prototype.clearMessages):
2986         * inspector/front-end/DOMAgent.js:
2987         (WebInspector.ApplicationCache.updateApplicationCacheStatus):
2988         (WebInspector.ApplicationCache.updateNetworkState):
2989         * inspector/front-end/DOMStorage.js:
2990         (WebInspector.DOMStorage.addDOMStorage):
2991         (WebInspector.DOMStorage.selectDOMStorage):
2992         (WebInspector.DOMStorage.updateDOMStorage):
2993         * inspector/front-end/Database.js:
2994         (WebInspector.Database.prototype.executeSql):
2995         (WebInspector.Database.addDatabase):
2996         (WebInspector.Database.selectDatabase):
2997         (WebInspector.Database.sqlTransactionSucceeded):
2998         (WebInspector.Database.sqlTransactionFailed):
2999         * inspector/front-end/FileSystemView.js:
3000         (WebInspector.FileSystem.didGetFileSystemPath):
3001         (WebInspector.FileSystem.didGetFileSystemError):
3002         (WebInspector.FileSystem.didGetFileSystemDisabled):
3003         * inspector/front-end/NetworkItemView.js:
3004         (WebInspector.NetworkItemView):
3005         * inspector/front-end/NetworkManager.js: Added.
3006         (WebInspector.NetworkManager):
3007         (WebInspector.NetworkManager.prototype._createResource):
3008         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
3009         (WebInspector.NetworkManager.prototype.willSendRequest):
3010         (WebInspector.NetworkManager.prototype._updateResourceWithRequest):
3011         (WebInspector.NetworkManager.prototype._appendRedirect):
3012         (WebInspector.NetworkManager.prototype.markResourceAsCached):
3013         (WebInspector.NetworkManager.prototype.didReceiveResponse):
3014         (WebInspector.NetworkManager.prototype._updateResourceWithResponse):
3015         (WebInspector.NetworkManager.prototype.didReceiveContentLength):
3016         (WebInspector.NetworkManager.prototype.didFinishLoading):
3017         (WebInspector.NetworkManager.prototype.didFailLoading):
3018         (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
3019         (WebInspector.NetworkManager.prototype._updateResourceWithCachedResource):
3020         (WebInspector.NetworkManager.prototype.setInitialContent):
3021         (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
3022         (WebInspector.NetworkManager.prototype.frameDetachedFromParent):
3023         (WebInspector.NetworkManager.prototype.didCreateWebSocket):
3024         (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
3025         (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
3026         (WebInspector.NetworkManager.prototype.didCloseWebSocket):
3027         (WebInspector.NetworkManager.prototype._processCachedResources):
3028         (WebInspector.NetworkManager.prototype._addFramesRecursively):
3029         (WebInspector.NetworkManager.requestContent):
3030         * inspector/front-end/NetworkPanel.js:
3031         (WebInspector.NetworkPanel.prototype.refreshResource):
3032         * inspector/front-end/Resource.js:
3033         (WebInspector.Resource.prototype._innerRequestContent):
3034         * inspector/front-end/ResourceManager.js: Removed.
3035         * inspector/front-end/ResourceTreeModel.js: Added.
3036         (WebInspector.ResourceTreeModel):
3037         (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
3038         (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
3039         (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent):
3040         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
3041         (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
3042         (WebInspector.ResourceTreeModel.prototype._clearResources):
3043         (WebInspector.ResourceTreeModel.prototype.forAllResources):
3044         (WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
3045         (WebInspector.ResourceTreeModel.prototype.clearConsoleMessages):
3046         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
3047         (WebInspector.ResourceTreeModel.prototype.resourceForURL):
3048         (WebInspector.ResourceTreeModel.prototype.bindResourceURL):
3049         (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
3050         (WebInspector.ResourceTreeModel.createResource):
3051         * inspector/front-end/ResourceView.js:
3052         (WebInspector.ResourceView.createResourceView):
3053         (WebInspector.ResourceView.resourceViewTypeMatchesResource):
3054         (WebInspector.ResourceView.resourceViewForResource):
3055         (WebInspector.ResourceView.recreateResourceView):
3056         (WebInspector.ResourceView.existingResourceViewForResource):
3057         * inspector/front-end/ResourcesPanel.js:
3058         (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
3059         (WebInspector.ResourcesPanel.prototype.showSourceLine):
3060         (WebInspector.ResourcesPanel.prototype.showResource):
3061         (WebInspector.ResourcesPanel.prototype.get searchableViews.callback):
3062         (WebInspector.ResourcesPanel.prototype.get searchableViews):
3063         (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
3064         (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
3065         * inspector/front-end/ScriptsPanel.js:
3066         (WebInspector.ScriptsPanel.prototype._addScript):
3067         (WebInspector.ScriptsPanel.prototype.reset):
3068         (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
3069         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
3070         * inspector/front-end/WebKit.qrc:
3071         * inspector/front-end/inspector.html:
3072         * inspector/front-end/inspector.js:
3073         (WebInspector.forAllResources):
3074         (WebInspector.resourceForURL):
3075
3076 2010-12-27  Helder Correia  <helder@sencha.com>
3077
3078         Reviewed by Ariya Hidayat.
3079
3080         ContextShadow should use AffineTransform instead of TransformationMatrix
3081         https://bugs.webkit.org/show_bug.cgi?id=51661
3082
3083         ContextShadow needs the CTM to make sure shadows are not affected by
3084         transformations when drawing on a canvas. AffineTransform is sufficient
3085         in this case.
3086
3087         Existing tests: fast/canvas/canvas*shadow*html
3088
3089         * platform/graphics/ContextShadow.cpp:
3090         (WebCore::ContextShadow::mustUseContextShadow):
3091         (WebCore::ContextShadow::adjustBlurDistance):
3092         (WebCore::ContextShadow::calculateLayerBoundingRect):
3093         * platform/graphics/ContextShadow.h:
3094         * platform/graphics/cairo/ContextShadowCairo.cpp:
3095         (WebCore::ContextShadow::getTransformationMatrixFromContext):
3096         * platform/graphics/qt/ContextShadowQt.cpp:
3097         (WebCore::ContextShadow::getTransformationMatrixFromContext):
3098
3099 2010-12-27  Daniel Bates  <dbates@rim.com>
3100
3101         Reviewed by Antonio Gomes.
3102
3103         Clean up: Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
3104         https://bugs.webkit.org/show_bug.cgi?id=51634
3105
3106         Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
3107         to HTMLFrameElementBase::marginWidth() and HTMLFrameElementBase::marginHeight(), respectively.
3108         This will make the names of these getters consistent with the naming convention we use for
3109         getters.
3110
3111         * html/HTMLBodyElement.cpp:
3112         (WebCore::HTMLBodyElement::insertedIntoDocument):
3113         * html/HTMLFrameElementBase.h:
3114         (WebCore::HTMLFrameElementBase::marginWidth): Renamed; Formerly getMarginWidth().
3115         (WebCore::HTMLFrameElementBase::marginHeight): Renamed; Formerly getMarginHeight().
3116         * loader/SubframeLoader.cpp:
3117         (WebCore::SubframeLoader::loadSubframe):
3118         * page/FrameView.cpp:
3119         (WebCore::FrameView::init):
3120         * rendering/RenderEmbeddedObject.cpp:
3121         (WebCore::RenderEmbeddedObject::viewCleared): Also renamed variables marginw and marginh
3122         to marginWidth and marginHeight, respectively. This makes the names of these variables
3123         consistent with the names of similar variables in SubframeLoader::loadSubframe() and FrameView::init().
3124         * rendering/RenderFrame.cpp:
3125         (WebCore::RenderFrame::viewCleared): Ditto.
3126
3127 2010-12-27  Martin Robinson  <mrobinson@igalia.com>
3128
3129         Reviewed by Daniel Bates.
3130
3131         [GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
3132         https://bugs.webkit.org/show_bug.cgi?id=51654
3133
3134         Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
3135         on some debug configurations.
3136
3137         No new tests. This is already covered by current slider tests. It isn't crashing on
3138         the bots, but it does crash locally.
3139
3140         * platform/gtk/RenderThemeGtk.cpp:
3141         (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
3142
3143 2010-12-27  Anton Muhin  <antonm@chromium.org>
3144
3145         Reviewed by David Levin.
3146
3147         [v8] Remove unused methods to protect/unprotect wrappers during garbage collection
3148         https://bugs.webkit.org/show_bug.cgi?id=51648
3149
3150         * bindings/v8/ScriptController.cpp:
3151         * bindings/v8/ScriptController.h:
3152         * bindings/v8/V8GCController.cpp:
3153         (WebCore::V8GCController::gcEpilogue):
3154         * bindings/v8/V8GCController.h:
3155
3156 2010-12-27  Yury Semikhatsky  <yurys@chromium.org>
3157
3158         Unreviewed. Removed trailing spaces from a localized
3159         string to make it the same as the one used in the code.
3160
3161         * English.lproj/localizedStrings.js:
3162
3163 2010-12-27  Yael Aharon  <yael.aharon@nokia.com>
3164
3165         Reviewed by Eric Seidel.
3166
3167         Browser is failing 16 baseline test from Selector API Test Suite
3168         https://bugs.webkit.org/show_bug.cgi?id=42968
3169
3170         Throw an exception if there is no argument to querySelector or 
3171         querySelectorAll. This replaces the current behavior of passing the string
3172         "undefined" as the argument.
3173
3174         No new tests, just updating the existing results for 
3175         fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.
3176
3177         * dom/Document.idl:
3178         * dom/DocumentFragment.idl:
3179         * dom/Element.idl:
3180
3181 2010-12-26  MORITA Hajime  <morrita@google.com>
3182
3183         Reviewed by Dan Bernstein.
3184
3185         For box-shadow, non-primary shadows should have specified radii.
3186         https://bugs.webkit.org/show_bug.cgi?id=51386
3187
3188         On paintBoxShadow(), the spread value accidentally accumulated accidentally
3189         during the loop, which should be applied individually for radius of each shadow. 
3190         This change makes the radii for rects computed for each shadow.
3191         
3192         Test: fast/box-shadow/spread-multiple-normal.html
3193
3194         * rendering/RenderBoxModelObject.cpp:
3195         (WebCore::RenderBoxModelObject::paintBoxShadow):
3196
3197 2010-12-26  Patrick Gansterer  <paroga@webkit.org>
3198
3199         Reviewed by Eric Seidel.
3200
3201         Improve output of HTML parser benchmark
3202         https://bugs.webkit.org/show_bug.cgi?id=51611
3203
3204         Calculate and show median, min and max values.
3205
3206         * benchmarks/parser/html-parser.html:
3207
3208 2010-12-26  Abhishek Arya  <inferno@chromium.org>
3209
3210         Reviewed by Simon Fraser.
3211
3212         Remove the bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer. 
3213         https://bugs.webkit.org/show_bug.cgi?id=48772
3214
3215         Test: fast/multicol/renderer-positioned-assert-crash.html
3216
3217         * rendering/RenderLayer.cpp:
3218         (WebCore::RenderLayer::paintPaginatedChildLayer):
3219         (WebCore::RenderLayer::hitTestPaginatedChildLayer):
3220
3221 2010-12-25  Peter Rybin  <peter.rybin@gmail.com>
3222
3223         Reviewed by Adam Barth.
3224
3225         Adds currentColumn (and currentLine) to SegmentedString. Switches
3226         HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
3227         needs position for a <script> tag.
3228
3229         SegmentedString should provide column position
3230         https://bugs.webkit.org/show_bug.cgi?id=51311
3231
3232         * html/parser/HTMLDocumentParser.cpp:
3233         (WebCore::HTMLDocumentParser::HTMLDocumentParser):
3234         (WebCore::HTMLDocumentParser::textPosition):
3235         * html/parser/HTMLInputStream.h:
3236         (WebCore::HTMLInputStream::current):
3237         (WebCore::InsertionPointRecord::InsertionPointRecord):
3238         (WebCore::InsertionPointRecord::~InsertionPointRecord):
3239         * html/parser/HTMLTreeBuilder.cpp:
3240         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
3241         (WebCore::HTMLTreeBuilder::processScriptStartTag):
3242         * html/parser/HTMLTreeBuilder.h:
3243         (WebCore::HTMLTreeBuilder::create):
3244         * platform/text/SegmentedString.cpp:
3245         (WebCore::SegmentedString::operator=):
3246         (WebCore::SegmentedString::numberOfCharactersConsumedSlow):
3247         (WebCore::SegmentedString::advanceSlowCase):
3248         (WebCore::SegmentedString::currentLine):
3249         (WebCore::SegmentedString::currentColumn):
3250         (WebCore::SegmentedString::setCurrentPosition):
3251         * platform/text/SegmentedString.h:
3252         (WebCore::SegmentedString::SegmentedString):
3253         (WebCore::SegmentedString::advancePastNewline):
3254         (WebCore::SegmentedString::advance):
3255         (WebCore::SegmentedString::numberOfCharactersConsumed):
3256
3257 2010-12-25  Andreas Kling  <kling@webkit.org>
3258
3259         Reviewed by Kenneth Rohde Christiansen.
3260
3261         GraphicsContext: Don't pass StrokeStyle (enum) as const reference
3262         https://bugs.webkit.org/show_bug.cgi?id=51608
3263
3264         * platform/graphics/GraphicsContext.cpp:
3265         (WebCore::GraphicsContext::setStrokeStyle):
3266         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3267         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
3268         * platform/graphics/GraphicsContext.h:
3269         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3270         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3271         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
3272         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3273         * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
3274         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3275         * platform/graphics/openvg/PainterOpenVG.cpp:
3276         (WebCore::PainterOpenVG::setStrokeStyle):
3277         * platform/graphics/openvg/PainterOpenVG.h:
3278         * platform/graphics/qt/GraphicsContextQt.cpp:
3279         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3280         * platform/graphics/skia/GraphicsContextSkia.cpp:
3281         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3282
3283 2010-12-24  Dan Bernstein  <mitz@apple.com>
3284
3285         Reviewed by Alexey Proskuryakov.
3286
3287         REGRESSION (r74648): XHR layout test failures
3288         https://bugs.webkit.org/show_bug.cgi?id=51603
3289
3290         Reverted r74648.
3291
3292         * WebCore.exp.in:
3293
3294 2010-12-24  Dan Bernstein  <mitz@apple.com>
3295
3296         Try to fix the Qt build after r74648.
3297
3298         * WebCore.gypi:
3299         * WebCore.pro:
3300         * platform/network/qt/CredentialStorageQt.cpp: Added.
3301         (WebCore::CredentialStorage::getFromPersistentStorage):
3302
3303 2010-12-24  Simon Fraser  <simon.fraser@apple.com>
3304
3305         Reviewed by Dan Bernstein.
3306
3307         CSSStyleSelector cleanup
3308         https://bugs.webkit.org/show_bug.cgi?id=51597
3309
3310         Make some methods const. Add assertion to checkOneSelector, with the
3311         intention of later removing the if (!e) check (this is hot code).
3312
3313         * css/CSSStyleSelector.cpp:
3314         (WebCore::CSSStyleSelector::locateCousinList):
3315         (WebCore::CSSStyleSelector::canShareStyleWithElement):
3316         (WebCore::CSSStyleSelector::locateSharedStyle):
3317         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
3318         (WebCore::CSSStyleSelector::mmLength):
3319         (WebCore::CSSStyleSelector::inchLength):
3320         (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
3321         (WebCore::CSSStyleSelector::hasSelectorForAttribute):
3322         * css/CSSStyleSelector.h:
3323         (WebCore::CSSStyleSelector::fontSelector):
3324
3325 2010-12-24  Dan Bernstein  <mitz@apple.com>
3326
3327         Reviewed by Anders Carlsson.
3328
3329         <rdar://problem/8758386> The web process uses its own credential storage
3330         https://bugs.webkit.org/show_bug.cgi?id=51599
3331
3332         * WebCore.exp.in: Export CredentialStorage::getFromPersistentStorage(), Credential::hasPassword(),
3333         and Credential::isEmpty().
3334
3335 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
3336
3337         Reviewed by Darin Adler.
3338
3339         [V8] Rename V8CustomEventListener.{h,cpp} to V8EventListener.{h,cpp}
3340         https://bugs.webkit.org/show_bug.cgi?id=51595
3341
3342         * WebCore.gypi:
3343         * bindings/v8/V8DOMWrapper.cpp:
3344         * bindings/v8/V8EventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.cpp.
3345         (WebCore::V8EventListener::V8EventListener):
3346         (WebCore::V8EventListener::getListenerFunction):
3347         (WebCore::V8EventListener::callListenerFunction):
3348         * bindings/v8/V8EventListener.h: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.h.
3349         (WebCore::V8EventListener::create):
3350         * bindings/v8/V8EventListenerList.h:
3351         * bindings/v8/V8WorkerContextEventListener.h:
3352         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3353         * bindings/v8/custom/V8LocationCustom.cpp:
3354         * bindings/v8/custom/V8NodeCustom.cpp:
3355         * bindings/v8/custom/V8NotificationCenterCustom.cpp:
3356
3357 2010-12-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3358
3359         Reviewed by Xan Lopez.
3360
3361         [GTK] Show current time / total in media player
3362         https://bugs.webkit.org/show_bug.cgi?id=51535
3363
3364         * css/mediaControlsGtk.css:
3365         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
3366         * platform/gtk/RenderThemeGtk.cpp:
3367         (WebCore::RenderThemeGtk::formatMediaControlsCurrentTime):
3368         (WebCore::RenderThemeGtk::paintMediaCurrentTime):
3369         * platform/gtk/RenderThemeGtk.h:
3370
3371 2010-12-24  Jan Erik Hanssen  <jhanssen@sencha.com>
3372
3373         Reviewed by Eric Seidel.
3374
3375         Clean up CSSRuleData in CSSStyleSelector.h
3376         https://bugs.webkit.org/show_bug.cgi?id=27753
3377
3378         Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.
3379
3380         * css/CSSStyleSelector.cpp:
3381         (WebCore::CSSRuleData::CSSRuleData):
3382         (WebCore::CSSRuleData::~CSSRuleData):
3383         (WebCore::CSSRuleData::position):
3384         (WebCore::CSSRuleData::rule):
3385         (WebCore::CSSRuleData::selector):
3386         (WebCore::CSSRuleData::next):
3387         (WebCore::CSSRuleDataList::CSSRuleDataList):
3388         (WebCore::CSSRuleDataList::~CSSRuleDataList):
3389         (WebCore::CSSRuleDataList::first):
3390         (WebCore::CSSRuleDataList::last):
3391         (WebCore::CSSRuleDataList::append):
3392         * css/CSSStyleSelector.h:
3393
3394 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
3395
3396         Unreviewed. Fix compilation on Windows.
3397
3398         * inspector/InspectorStyleSheet.cpp:
3399         (WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
3400         * inspector/InspectorStyleSheet.h:
3401
3402 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
3403
3404         Reviewed by Darin Adler.
3405
3406         inspector/debugger-step-out.html crashing intermittently in the bots
3407         https://bugs.webkit.org/show_bug.cgi?id=50868
3408
3409         Use RefPtr rather instead of raw pointers when keeping references
3410         to refcounted objects.
3411
3412         * inspector/InspectorCSSAgent.cpp:
3413         (WebCore::InspectorCSSAgent::getStylesForNode2):
3414         (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
3415         * inspector/InspectorStyleSheet.cpp:
3416         (WebCore::InspectorStyle::create):
3417         (WebCore::InspectorStyle::InspectorStyle):
3418         (WebCore::InspectorStyle::buildObjectForStyle):
3419         (WebCore::InspectorStyle::setPropertyText):
3420         (WebCore::InspectorStyle::toggleProperty):
3421         (WebCore::InspectorStyle::styleText):
3422         (WebCore::InspectorStyle::populateAllProperties):
3423         (WebCore::InspectorStyle::replacePropertyInStyleText):
3424         (WebCore::InspectorStyleSheet::create):
3425         (WebCore::InspectorStyleSheet::InspectorStyleSheet):
3426         (WebCore::InspectorStyleSheetForInlineStyle::create):
3427         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
3428         (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
3429         * inspector/InspectorStyleSheet.h:
3430         (WebCore::InspectorStyle::cssStyle):
3431         (WebCore::InspectorStyleSheet::pageStyleSheet):
3432
3433 2010-12-24  Justin Schuh  <jschuh@chromium.org>
3434
3435         Reviewed by Nikolas Zimmermann.
3436
3437         SVGElementInstance::m_useElement should be cleared when use element is removed from document
3438         https://bugs.webkit.org/show_bug.cgi?id=51486
3439
3440         Test: svg/custom/use-instanceRoot-with-use-removed.svg
3441
3442         * svg/SVGElementInstance.cpp:
3443         (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
3444         * svg/SVGElementInstance.h:
3445         (WebCore::SVGElementInstance::clearUseElement):
3446         * svg/SVGUseElement.cpp:
3447         (WebCore::SVGUseElement::removedFromDocument):
3448         (WebCore::ShadowTreeUpdateBlocker::if):
3449         (WebCore::SVGUseElement::detachInstance):
3450         (WebCore::SVGUseElement::detach):
3451         * svg/SVGUseElement.h:
3452
3453 2010-12-23  Joseph Pecoraro  <joepeck@webkit.org>
3454
3455         Reviewed by Yury Semikhatsky.
3456
3457         Web Inspector: Missing Localized Strings
3458         https://bugs.webkit.org/show_bug.cgi?id=51542
3459
3460         Added missing strings: "WebSocket",  "Frames", "Text", "Transfer",
3461         "Preserve Log upon Navigation", and "Go to Line".
3462
3463         * English.lproj/localizedStrings.js:
3464
3465 2010-12-24  Alexander Pavlov  <apavlov@chromium.org>
3466
3467         Reviewed by Yury Semikhatsky.
3468
3469         Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
3470         https://bugs.webkit.org/show_bug.cgi?id=51478
3471
3472         Now the element attribute modifications (including "style") are tracked, which results in the
3473         source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
3474         on the "style" attribute modification through the Elements tree. Also, it appears that
3475         a complete "style" attribute removal destroys the inline style declaration
3476         (StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).
3477
3478         Test: inspector/elements-delete-inline-style.html
3479
3480         * inspector/InspectorCSSAgent.cpp:
3481         (WebCore::InspectorCSSAgent::didModifyDOMAttr):
3482         * inspector/InspectorCSSAgent.h:
3483         * inspector/InspectorDOMAgent.cpp:
3484         (WebCore::InspectorDOMAgent::didModifyDOMAttr):
3485         * inspector/InspectorDOMAgent.h:
3486         * inspector/InspectorStyleSheet.cpp:
3487         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
3488         (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
3489         (WebCore::InspectorStyleSheetForInlineStyle::text):
3490         (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
3491         (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
3492         * inspector/InspectorStyleSheet.h:
3493         * inspector/front-end/ElementsTreeOutline.js:
3494         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
3495
3496 2010-12-24  Noel Gordon  <noel.gordon@gmail.com>
3497
3498         Reviewed by Andreas Kling.
3499
3500         [chromium] Fix a style nit in the JPEG encoder
3501         https://bugs.webkit.org/show_bug.cgi?id=51574
3502
3503         * platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.
3504
3505 2010-12-23  Alexander Pavlov  <apavlov@chromium.org>
3506
3507         Reviewed by Maciej Stachowiak.
3508
3509         Web Inspector: CSS shorthand properties expand unnecessarily
3510         https://bugs.webkit.org/show_bug.cgi?id=36304
3511
3512         "border-radius" is a shorthand property that has a "non-standard" format and longhands, see
3513         http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
3514         standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
3515         This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
3516         appropriately when adding implicit longhands, thus they were added as normal properties
3517         found in the CSS (neither implicit, nor longhands). This is now fixed.
3518
3519         * css/CSSParser.cpp:
3520         (WebCore::CSSParser::parseBorderRadius):
3521
3522 2010-12-24  Justin Schuh  <jschuh@chromium.org>
3523
3524         Reviewed by Darin Adler.
3525
3526         setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
3527         https://bugs.webkit.org/show_bug.cgi?id=51576
3528
3529         Disallowed elements may be pruned from the shadow tree, leaving a null
3530         shadowTreeElement. We should check for that before setting attributes.
3531
3532         Test: svg/custom/animate-disallowed-use-element.svg
3533
3534         * svg/SVGAnimationElement.cpp:
3535         (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
3536
3537 2010-12-24  Evan Martin  <evan@chromium.org>
3538
3539         Reviewed by Darin Adler.
3540
3541         TextMetrics::width is an integer, but the member is a float
3542         https://bugs.webkit.org/show_bug.cgi?id=51566
3543
3544         Change the return type to a float.
3545
3546         No tests, fixing a compiler warning.
3547         (I was unable to produce a difference in the values exposed to pages
3548         with a float versus the previous conversion to an integer.)
3549
3550         * html/TextMetrics.h:
3551         (WebCore::TextMetrics::width):
3552
3553 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3554
3555         Reviewed by Kenneth Rohde Christiansen.
3556
3557         [EFL] Add option to enable Touch Events.
3558         https://bugs.webkit.org/show_bug.cgi?id=49125
3559
3560         Add files for EFL to support TOUCH_EVENTS.
3561
3562         * CMakeLists.txt:
3563         * CMakeListsEfl.txt:
3564         * platform/PlatformTouchEvent.h: Add EFL related constructor.
3565         * platform/PlatformTouchPoint.h: ditto.
3566         * platform/efl/PlatformTouchEventEfl.cpp: Added.
3567         (WebCore::PlatformTouchEvent::PlatformTouchEvent):
3568         * platform/efl/PlatformTouchPointEfl.cpp: Added.
3569         (WebCore::PlatformTouchPoint::PlatformTouchPoint):
3570
3571 2010-12-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3572
3573         Reviewed by Kenneth Rohde Christiansen.
3574
3575         [EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()
3576         https://bugs.webkit.org/show_bug.cgi?id=51457
3577
3578         WebKit EFL can't play html5 audio because of wrong mime type checking.
3579         So, 'application/octet-stream' is changed with an empty string.
3580
3581         * platform/efl/MIMETypeRegistryEfl.cpp:
3582         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
3583         Returns an empty string instead of application/octet-stream when it can't find proper mime type.
3584
3585 2010-12-24  Justin Schuh  <jschuh@chromium.org>
3586
3587         Reviewed by Darin Adler.
3588
3589         SVGFontFaceElement::rebuildFontFace() should exit when not in document
3590         https://bugs.webkit.org/show_bug.cgi?id=51571
3591
3592         We were hitting a NULL deref crash. Since most of the callers checked
3593         inDocument() anyway, I moved it into the start of rebuildFontFace.
3594
3595         Test: svg/custom/use-invalid-font-face.svg
3596
3597         * svg/SVGFontFaceElement.cpp:
3598         (WebCore::SVGFontFaceElement::parseMappedAttribute):
3599         (WebCore::SVGFontFaceElement::rebuildFontFace):
3600         (WebCore::SVGFontFaceElement::childrenChanged):
3601
3602 2010-12-24  Justin Schuh  <jschuh@chromium.org>
3603
3604         Reviewed by Darin Adler.
3605
3606         Remove unnecessary check in CSSCanvasValue::canvasDestroyed().
3607         https://bugs.webkit.org/show_bug.cgi?id=51564
3608
3609         This check was duplicating an ASSERT for a case fixed in r73927.
3610         Now that the bug is fixed the check is no longer necessary.
3611
3612         Removing dead code, so no new tests needed.
3613
3614         * css/CSSCanvasValue.cpp:
3615         (WebCore::CSSCanvasValue::canvasDestroyed):
3616
3617 2010-12-23  Evan Martin  <evan@chromium.org>
3618
3619         Reviewed by Darin Adler.
3620
3621         ViewportArguments.h uses an enum to intialize a bool
3622         https://bugs.webkit.org/show_bug.cgi?id=50982
3623
3624         Initialize userScalable to true, rather than -1.
3625         No tests; fixes a compiler warning.
3626
3627         * dom/ViewportArguments.h:
3628         (WebCore::ViewportArguments::ViewportArguments):
3629
3630 2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>
3631
3632         Reviewed by Adam Barth.
3633
3634         [Qt] User name/password stripped from URLs
3635         https://bugs.webkit.org/show_bug.cgi?id=36232
3636
3637         If a username but no password or no username but a password is present
3638         in a URL, QtWebKit won't send any authentication information down to Qt
3639         as it should.
3640
3641         Tests: http/tests/xmlhttprequest/basic-auth-nopassword.html
3642                http/tests/xmlhttprequest/basic-auth-nouser.html
3643
3644         * platform/network/qt/ResourceHandleQt.cpp:
3645         (WebCore::ResourceHandle::start):
3646         (WebCore::ResourceHandle::loadResourceSynchronously):
3647
3648 2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>
3649
3650         Reviewed by Darin Adler.
3651
3652         queryCommandValue("FormatBlock") does not respect editing boundaries
3653         https://bugs.webkit.org/show_bug.cgi?id=51219
3654
3655         Fixed the bug by checking the element we found in elementForFormatBlockCommand
3656         does not contain the editable root.
3657
3658         * editing/FormatBlockCommand.cpp:
3659         (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
3660
3661 2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>
3662
3663         Reviewed by Darin Adler.
3664
3665         FormatBlock doesn't preserve typing style but it should
3666         https://bugs.webkit.org/show_bug.cgi?id=51140
3667
3668         Fixed the bug by making preserveTypingStyle return true.
3669
3670         Test: editing/execCommand/format-block-typing-style.html
3671
3672         * editing/FormatBlockCommand.h:
3673         (WebCore::FormatBlockCommand::preservesTypingStyle):
3674
3675 2010-12-23  Jessie Berlin  <jberlin@apple.com>
3676
3677         Reviewed by Sam Weinig.
3678
3679         Need WebKit2 API to create a SecurityOrigin from protocol, host, and port
3680         https://bugs.webkit.org/show_bug.cgi?id=51563
3681
3682         Add SecurityOrigin::create(const String& protocol, const String& host, int port).
3683
3684         * WebCore.exp.in:
3685         Export the symbols for WebCore::SecurityOrigin::create(String, String, int).
3686
3687         * page/SecurityOrigin.cpp:
3688         (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
3689         Use the constant MaxAllowedPort.
3690         (WebCore::SecurityOrigin::create):
3691         Sanitizing based off of that done in createFromDatabaseIdentifier.
3692         * page/SecurityOrigin.h:
3693
3694 2010-12-23  Patrick Gansterer  <paroga@webkit.org>
3695
3696         Unreviewed build fix for WinCE after r73802.
3697
3698         Reapply r70812:
3699         Port ContextMenuItemWin.cpp to WinCE
3700         https://bugs.webkit.org/show_bug.cgi?id=48407
3701
3702         * platform/win/ContextMenuItemWin.cpp:
3703
3704 2010-12-23  Adam Barth  <abarth@webkit.org>
3705
3706         Remove include of non-existant file.
3707
3708         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3709
3710 2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>
3711
3712         Reviewed by Darin Adler.
3713
3714         Selection becomes stale when CharacterData is manipulated directly
3715         https://bugs.webkit.org/show_bug.cgi?id=51389
3716
3717         The bug was caused by SelectionController's not adjusting selection when CharacterData's
3718         m_data is modified by its API.
3719
3720         Fixed the bug by adding textWillBeReplaced to SelectionController and calling it in
3721         CharacterData::textWillBeReplaced. Added newLength to setDataAndUpdate, which is passed to
3722         textWillBeReplaced because inserting, replacing, or removing data may require moving
3723         the offset of the selection end points (done by shouldRemovePositionAfterAdoptingTextReplacement).
3724
3725         Also fixed the condition for determining whether or not a node intersects the selection
3726         in respondToNodeModification, which is extracted from nodeWillBeRemoved. The old condition
3727         failed to recognize certain cases when selection started and ended with non-zero offsets.
3728
3729         Tests: editing/selection/character-data-mutation-crash.html
3730                editing/selection/character-data-mutation.html
3731
3732         * dom/CharacterData.cpp:
3733         (WebCore::CharacterData::setData): Passes newLegnth to setDataAndUpdate.
3734         (WebCore::CharacterData::appendData): Ditto.
3735         (WebCore::CharacterData::insertData): Ditto.
3736         (WebCore::CharacterData::deleteData): Ditto.
3737         (WebCore::CharacterData::replaceData): Ditto.
3738         (WebCore::CharacterData::setDataAndUpdate): Added newLegnth to the argument list,
3739         and renamed lengthOfReplacedData to oldLength; calls textWillBeReplaced.
3740         * dom/CharacterData.h:
3741         * editing/SelectionController.cpp:
3742         (WebCore::removingNodeRemovesPosition): Removed indentations from blank lines.
3743         (WebCore::SelectionController::nodeWillBeRemoved): Calls nodeWillBeRemoved.
3744         (WebCore::SelectionController::respondToNodeModification): Extracted from nodeWillBeRemoved;
3745         fixed the logic to figure out whether a node is inside the range or not.
3746         (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): Added.
3747         (WebCore::SelectionController::textWillBeReplaced): Added.
3748         * editing/SelectionController.h:
3749
3750 2010-12-23  Adam Barth  <abarth@webkit.org>
3751
3752         Reviewed by Darin Adler.
3753
3754         Remove unneeded V8 bindings files
3755         https://bugs.webkit.org/show_bug.cgi?id=51570
3756
3757         * WebCore.gypi:
3758         * bindings/generic/BindingDOMWindow.h: Removed.
3759         * bindings/v8/specialization/V8BindingDOMWindow.h: Removed.
3760
3761 2010-12-23  Dan Bernstein  <mitz@apple.com>
3762
3763         Build fix.
3764
3765         * editing/EditorCommand.cpp:
3766         (WebCore::enabledDismissCorrectionPanel):
3767
3768 2010-12-23  Darin Adler  <darin@apple.com>
3769
3770         Try to fix crash seen on GTK bot.
3771
3772         * editing/EditorCommand.cpp:
3773         (WebCore::internalCommand): Add back empty string check I accidentally deleted in r74580.
3774
3775         * WebCore.xcodeproj/project.pbxproj: Let Xcode edit the file.
3776
3777 2010-12-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3778
3779         Unreviewed, rolling out r74561.
3780         http://trac.webkit.org/changeset/74561
3781         https://bugs.webkit.org/show_bug.cgi?id=51565
3782
3783         "Broke Chromium UI tests on Vista" (Requested by kbr_google on
3784         #webkit).
3785
3786         * platform/graphics/chromium/ImageLayerChromium.cpp:
3787         (WebCore::ImageLayerChromium::updateContentsIfDirty):
3788         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
3789         (WebCore::GraphicsContext3D::getImageData):
3790
3791 2010-12-23  Mihai Parparita  <mihaip@chromium.org>
3792
3793         Reviewed by Kent Tamura.
3794
3795         [Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
3796         https://bugs.webkit.org/show_bug.cgi?id=51507
3797         
3798         Adds WebThemeEngine for the Mac (it already has parallel definitions for
3799         Windows and Linux) so that scrollbar thumb rendering can be overridden
3800         for the DRT (to be consistent with the NSScroller-based rendering
3801         used by the Mac port).
3802
3803         No new tests since the functionality is not exposed yet. Eventually will
3804         result in the Chromium/Mac port being able to use the same pixel
3805         baselines for layout tests as the Mac port.
3806
3807         * platform/chromium/ChromiumBridge.h:
3808         * platform/chromium/ScrollbarThemeChromiumMac.mm:
3809         (WebCore::scrollbarStateToThemeState):
3810         (WebCore::ScrollbarThemeChromiumMac::paint):
3811
3812 2010-12-23  Darin Adler  <darin@apple.com>
3813
3814         Reviewed by Sam Weinig.
3815
3816         WKView should not try to do asynchronous validation for selectors that are not editor commands
3817         https://bugs.webkit.org/show_bug.cgi?id=51555
3818
3819         * WebCore.exp.in: Added commandIsSupportedFromMenuOrKeyBinding.
3820         * editing/Editor.h: Reordered arguments in the Editor::Command constructor
3821         and the data members too so the frame is last. Added
3822         commandIsSupportedFromMenuOrKeyBinding.
3823
3824         * editing/EditorCommand.cpp:
3825         (WebCore::supported): Removed the EditorCommandSource argument. These
3826         functions are now only used when called from DOM.
3827         (WebCore::supportedFromMenuOrKeyBinding): Ditto.
3828         (WebCore::supportedCopyCut): Ditto.
3829         (WebCore::supportedPaste): Ditto.
3830         (WebCore::enabledDismissCorrectionPanel): Changed the supported function to
3831         an enabled function. It was incorrect to say that this is "supported" only
3832         when the correction panel is up. Correct to say that it is "enabled" only
3833         then. And also probably OK to enable it even when the selection is not in
3834         editable text, as long as the panel is up.
3835         (WebCore::createCommandMap): Moved conditional commands out of the main
3836         array into a separate section at the end.
3837         (WebCore::internalCommand): Added.
3838         (WebCore::Editor::command): Changed to use the new internalCommand function
3839         and simplified by relying on the null check in the Command constructor.
3840         (WebCore::Editor::commandIsSupportedFromMenuOrKeyBinding): Added.
3841         (WebCore::Editor::Command::Command): Removed unneeded initialization of
3842         m_source, which is never looked at if m_command is 0. Added feature of
3843         passing a null command pointer to the non-default constructor.
3844         (WebCore::Editor::Command::isSupported): Changed to only call the
3845         per-command isSupported function when the command source is DOM.
3846         Accordingly that function is now called isSupportedFromDOM.
3847
3848 2010-12-23  Matthew Delaney  <mdelaney@apple.com>
3849
3850         Reviewed by Simon Fraser.
3851
3852         Incorrect layer property used noted as changed in GraphicsLayerCA::setAcceleratesDrawing
3853         https://bugs.webkit.org/show_bug.cgi?id=51560
3854
3855         No new tests.
3856
3857         * platform/graphics/ca/GraphicsLayerCA.cpp:
3858         (WebCore::GraphicsLayerCA::setAcceleratesDrawing):
3859
3860 2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>
3861
3862         Reviewed by Andreas Kling.
3863
3864         [Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
3865         https://bugs.webkit.org/show_bug.cgi?id=35635
3866
3867         Explicitly set text/html data on QClipboard as UTF-8 and also include a <meta>
3868         tag informing the OS that the data is in UTF-8 format.
3869
3870         * platform/qt/PasteboardQt.cpp:
3871         (WebCore::Pasteboard::writeSelection):
3872
3873 2010-12-23  Justin Schuh  <jschuh@chromium.org>
3874
3875         Reviewed by Eric Seidel.
3876
3877         CSSCursorImageValue destructor should clear referenced element.
3878         https://bugs.webkit.org/show_bug.cgi?id=51417
3879
3880         Calls correct method to clear image and renames method to avoid future confusion.
3881
3882         Test: svg/css/cursor-image-replace.svg
3883
3884         * css/CSSCursorImageValue.cpp:
3885         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
3886         * svg/SVGElement.cpp:
3887         (WebCore::SVGElement::cursorImageValueRemoved):
3888         * svg/SVGElement.h:
3889
3890 2010-12-22  Sam Weinig  <sam@webkit.org>
3891
3892         Reviewed by Darin Adler.
3893
3894         WebKit2 needs to mirror the frame tree in the UIProcess
3895         https://bugs.webkit.org/show_bug.cgi?id=51546
3896
3897         - Add client functions to notify that a frame has been added or
3898           removed from the page cache.
3899
3900         * history/CachedFrame.cpp:
3901         (WebCore::CachedFrameBase::restore):
3902         (WebCore::CachedFrame::CachedFrame):
3903         * history/CachedFrame.h:
3904         * loader/EmptyClients.h:
3905         (WebCore::EmptyFrameLoaderClient::didSaveToPageCache):
3906         (WebCore::EmptyFrameLoaderClient::didRestoreFromPageCache):
3907         * loader/FrameLoaderClient.h:
3908
3909 2010-12-22  Matthew Delaney  <mdelaney@apple.com>
3910
3911         Reviewed by Simon Fraser.
3912
3913         Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces
3914         This patch also changes USE_IOSURFACE to instead follow USE(IOSURFACE)
3915         https://bugs.webkit.org/show_bug.cgi?id=51279
3916
3917         * html/HTMLCanvasElement.cpp: For IOSurface, use setNeedsStyleRecalc
3918         * html/canvas/CanvasRenderingContext2D.cpp: Use new flag
3919         * platform/graphics/ImageBuffer.h: Use new flag
3920         * platform/graphics/cg/ImageBufferCG.cpp: Use new flag
3921
3922 2010-12-20  Adrienne Walker  <enne@google.com>
3923
3924         Reviewed by Kenneth Russell.
3925
3926         [chromium] Tile root layer of the compositor.
3927         https://bugs.webkit.org/show_bug.cgi?id=49947
3928
3929         Refactor root layer update and drawing from LayerRendererChromium into
3930         LayerTilerChromium.  The root layer is now drawn as multiple tiles
3931         rather than as one single large texture.  Scrollbars are now drawn
3932         separately rather than as part of the root layer.
3933
3934         Test: LayoutTests/compositing/
3935
3936         * WebCore.gypi:
3937         * page/FrameView.cpp:
3938         (WebCore::FrameView::repaintContentRectangle):
3939         * platform/ScrollView.cpp:
3940         (WebCore::ScrollView::ScrollView):
3941         (WebCore::ScrollView::setClipsRepaints):
3942         * platform/ScrollView.h:
3943         (WebCore::ScrollView::clipsRepaints):
3944         * platform/graphics/chromium/LayerChromium.h:
3945         * platform/graphics/chromium/LayerRendererChromium.cpp:
3946         (WebCore::LayerRendererChromium::LayerRendererChromium):
3947         (WebCore::LayerRendererChromium::~LayerRendererChromium):
3948         (WebCore::LayerRendererChromium::useShader):
3949         (WebCore::LayerRendererChromium::verticalScrollbarRect):
3950         (WebCore::LayerRendererChromium::horizontalScrollbarRect):
3951         (WebCore::LayerRendererChromium::invalidateRootLayerRect):
3952         (WebCore::LayerRendererChromium::updateAndDrawRootLayer):
3953         (WebCore::LayerRendererChromium::drawLayers):
3954         (WebCore::LayerRendererChromium::setRootLayer):
3955         (WebCore::LayerRendererChromium::initializeSharedObjects):
3956         (WebCore::LayerRendererChromium::cleanupSharedObjects):
3957         * platform/graphics/chromium/LayerRendererChromium.h:
3958         * platform/graphics/chromium/LayerTilerChromium.cpp: Added.
3959         (WebCore::LayerTilerChromium::create):
3960         (WebCore::LayerTilerChromium::LayerTilerChromium):
3961         (WebCore::LayerTilerChromium::~LayerTilerChromium):
3962         (WebCore::LayerTilerChromium::layerRendererContext):
3963         (WebCore::LayerTilerChromium::setTileSize):
3964         (WebCore::LayerTilerChromium::reset):
3965         (WebCore::LayerTilerChromium::createTile):
3966         (WebCore::LayerTilerChromium::invalidateTiles):
3967         (WebCore::LayerTilerChromium::contentRectToTileIndices):
3968         (WebCore::LayerTilerChromium::contentRectToLayerRect):
3969         (WebCore::LayerTilerChromium::layerRectToContentRect):
3970         (WebCore::LayerTilerChromium::tileIndex):
3971         (WebCore::LayerTilerChromium::tileContentRect):
3972         (WebCore::LayerTilerChromium::tileLayerRect):
3973         (WebCore::LayerTilerChromium::invalidateRect):
3974         (WebCore::LayerTilerChromium::invalidateEntireLayer):
3975         (WebCore::LayerTilerChromium::update):
3976         (WebCore::LayerTilerChromium::setLayerPosition):
3977         (WebCore::LayerTilerChromium::draw):
3978         (WebCore::LayerTilerChromium::resizeLayer):
3979         (WebCore::LayerTilerChromium::growLayerToContain):
3980         (WebCore::LayerTilerChromium::Tile::~Tile):
3981         (WebCore::LayerTilerChromium::Tile::releaseTextureId):
3982         * platform/graphics/chromium/LayerTilerChromium.h: Added.
3983         (WebCore::LayerTilerChromium::Tile::Tile):
3984         (WebCore::LayerTilerChromium::Tile::textureId):
3985         (WebCore::LayerTilerChromium::Tile::dirty):
3986         (WebCore::LayerTilerChromium::Tile::clearDirty):
3987         (WebCore::LayerTilerChromium::layerRenderer):
3988
3989 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3990
3991         Reviewed by Eric Seidel.
3992
3993         Editor.h doesn't need to include SelectionController.h
3994         https://bugs.webkit.org/show_bug.cgi?id=51441
3995
3996         Removed #include <Selection.h> from Editor.h.
3997         Also extracted WritingDirection.h from EditingStyle.h and renamed SelectionController::EDirection
3998         to SelectionDirection and moved its declaration from SelectionController.h to VisibleSelection.h
3999
4000         * WebCore.exp.in: Signature changes.
4001         * WebCore.xcodeproj/project.pbxproj: Added WritingDirection.h
4002         * accessibility/AccessibilityRenderObject.cpp:
4003         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): Change due to SelectionDirection.
4004         * editing/EditingStyle.h: Removed WritingDirection and included WritingDirection.h
4005         * editing/Editor.cpp:
4006         (WebCore::Editor::deleteWithDirection): Change due to SelectionDirection.
4007         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
4008         (WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto.
4009         * editing/Editor.h: Removed SelectionController.h; added DocumentMarker.h, Timer.h, VisibleSelection.h
4010         and WritingDirection.h; forward declared CSSMutableStyleDeclaration.
4011         * editing/EditorCommand.cpp:
4012         (WebCore::executeDeleteBackward): Change due to SelectionDirection.
4013         (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto.
4014         (WebCore::executeDeleteForward): Ditto.
4015         (WebCore::executeDeleteToBeginningOfLine): Ditto.
4016         (WebCore::executeDeleteToBeginningOfParagraph): Ditto.
4017         (WebCore::executeDeleteToEndOfLine): Ditto.
4018         (WebCore::executeDeleteToEndOfParagraph): Ditto.
4019         (WebCore::executeDeleteWordBackward): Ditto.
4020         (WebCore::executeDeleteWordForward): Ditto.
4021         (WebCore::executeForwardDelete): Ditto.
4022         (WebCore::executeMoveBackward): Ditto.
4023         (WebCore::executeMoveBackwardAndModifySelection): Ditto.
4024         (WebCore::executeMoveDown): Ditto.
4025         (WebCore::executeMoveDownAndModifySelection): Ditto.
4026         (WebCore::executeMoveForward): Ditto.
4027         (WebCore::executeMoveForwardAndModifySelection): Ditto.
4028         (WebCore::executeMoveLeft): Ditto.
4029         (WebCore::executeMoveLeftAndModifySelection): Ditto.
4030         (WebCore::executeMoveRight): Ditto.
4031         (WebCore::executeMoveRightAndModifySelection): Ditto.
4032         (WebCore::executeMoveToBeginningOfDocument): Ditto.
4033         (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): Ditto.
4034         (WebCore::executeMoveToBeginningOfLine): Ditto.
4035         (WebCore::executeMoveToBeginningOfLineAndModifySelection): Ditto.
4036         (WebCore::executeMoveToBeginningOfParagraph): Ditto.
4037         (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): Ditto.
4038         (WebCore::executeMoveToBeginningOfSentence): Ditto.
4039         (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): Ditto.
4040         (WebCore::executeMoveToEndOfDocument): Ditto.
4041         (WebCore::executeMoveToEndOfDocumentAndModifySelection): Ditto.
4042         (WebCore::executeMoveToEndOfSentence): Ditto.
4043         (WebCore::executeMoveToEndOfSentenceAndModifySelection): Ditto.
4044         (WebCore::executeMoveToEndOfLine): Ditto.
4045         (WebCore::executeMoveToEndOfLineAndModifySelection): Ditto.
4046         (WebCore::executeMoveToEndOfParagraph): Ditto.
4047         (WebCore::executeMoveToEndOfParagraphAndModifySelection): Ditto.
4048         (WebCore::executeMoveParagraphBackwardAndModifySelection): Ditto.
4049         (WebCore::executeMoveParagraphForwardAndModifySelection): Ditto.
4050         (WebCore::executeMoveUp): Ditto.
4051         (WebCore::executeMoveUpAndModifySelection): Ditto.
4052         (WebCore::executeMoveWordBackward): Ditto.
4053         (WebCore::executeMoveWordBackwardAndModifySelection): Ditto.
4054         (WebCore::executeMoveWordForward): Ditto.
4055         (WebCore::executeMoveWordForwardAndModifySelection): Ditto.
4056         (WebCore::executeMoveWordLeft): Ditto.
4057         (WebCore::executeMoveWordLeftAndModifySelection): Ditto.
4058         (WebCore::executeMoveWordRight): Ditto.
4059         (WebCore::executeMoveWordRightAndModifySelection): Ditto.
4060         (WebCore::executeMoveToLeftEndOfLine): Ditto.
4061         (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Ditto.
4062         (WebCore::executeMoveToRightEndOfLine): Ditto.
4063         (WebCore::executeMoveToRightEndOfLineAndModifySelection): Ditto.
4064         * editing/SelectionController.cpp:
4065         (WebCore::SelectionController::willBeModified): Takes SelectionDirection instead of EDirection.
4066         (WebCore::SelectionController::modify): Ditto.
4067         * editing/SelectionController.h: Change due to SelectionDirection.
4068         * editing/TypingCommand.cpp:
4069         (WebCore::TypingCommand::deleteKeyPressed): Ditto.
4070         (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
4071         * editing/VisibleSelection.h: Added SelectionDirection, renamed and moved from EDirection
4072         in SelectionController.h
4073         * editing/WritingDirection.h: Added.
4074         * page/DOMSelection.cpp:
4075         (WebCore::DOMSelection::modify): Change due to SelectionDirection.
4076         (WebCore::DOMSelection::deleteFromDocument): Ditto.
4077         * page/EventHandler.cpp:
4078         (WebCore::EventHandler::handleKeyboardSelectionMovement): Ditto.
4079         * page/Frame.h: Includes SelectionController.h.
4080
4081 2010-12-23  Adam Barth  <abarth@webkit.org>
4082
4083         Reviewed by Darin Adler.
4084
4085         Move V8 to WebCore's implementation of showModalDialog
4086         https://bugs.webkit.org/show_bug.cgi?id=51527
4087
4088         This code is basically verbatim translation from the JavaScriptCore
4089         bindings.  The only intentional difference is in the world selection
4090         for the dialog's frame.  I suspect JavaScriptCore's bindings have a
4091         subtle bug there.
4092
4093         In this patch, I also remove a bunch of now-unneeded code in the
4094         generic bindings.
4095
4096         * bindings/generic/BindingDOMWindow.h:
4097         * bindings/js/JSDOMWindowCustom.cpp:
4098         (WebCore::DialogHandler::dialogCreated):
4099         (WebCore::setUpDialog):
4100         * bindings/v8/custom/V8DOMWindowCustom.cpp:
4101         (WebCore::DialogHandler::DialogHandler):
4102         (WebCore::DialogHandler::dialogCreated):
4103         (WebCore::DialogHandler::returnValue):
4104         (WebCore::setUpDialog):
4105         (WebCore::V8DOMWindow::showModalDialogCallback):
4106         (WebCore::V8DOMWindow::openCallback):
4107         * bindings/v8/specialization/V8BindingDOMWindow.h:
4108
4109 2010-12-23  Alexander Pavlov  <apavlov@chromium.org>
4110
4111         Reviewed by Joseph Pecoraro.
4112
4113         Web Inspector: Can't backspace from CSS value to CSS key field
4114         https://bugs.webkit.org/show_bug.cgi?id=51476
4115
4116         * inspector/front-end/StylesSidebarPane.js:
4117         (WebInspector.StylePropertyTreeElement.prototype.):
4118         (WebInspector.StylePropertyTreeElement.prototype):
4119
4120 2010-12-23  W. James MacLean  <wjmaclean@chromium.org>
4121
4122         Reviewed by Kenneth Russell.
4123
4124         [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
4125         https://bugs.webkit.org/show_bug.cgi?id=51186
4126
4127         No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.
4128
4129         * platform/graphics/chromium/ImageLayerChromium.cpp:
4130         (WebCore::ImageLayerChromium::updateContentsIfDirty):
4131         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
4132         (WebCore::GraphicsContext3D::getImageData):
4133
4134 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
4135
4136         Reviewed by Kenneth Rohde Christiansen.
4137
4138         Fix check by undefined macro
4139         https://bugs.webkit.org/show_bug.cgi?id=51531
4140
4141         Fix check by undefined macro
4142
4143         When building EFL port with libsoup, BUILDING_GTK__ is not defined,
4144         leading to warnings during compile. We actually have to use an #ifdef
4145         instead of an #if.
4146
4147         No change in functionality so no new tests.
4148
4149         * platform/network/soup/cache/webkit/soup-cache.h:
4150
4151 2010-12-23  Jonathan Dixon  <joth@chromium.org>
4152
4153         Reviewed by Steve Block.
4154
4155         TouchEvents does not support multi-touch on a page with multiple touch targets
4156         https://bugs.webkit.org/show_bug.cgi?id=51258
4157
4158         Test: fast/events/touch/multi-touch-grouped-targets.html
4159
4160         * page/EventHandler.cpp:
4161         (WebCore::eventNameForTouchPointState):
4162         (WebCore::EventHandler::handleTouchEvent):
4163         Redesigned event handler to ensure all event targets involved in a given
4164         multitouch event get the appropriate event(s) fired.
4165
4166         * platform/PlatformTouchPoint.h: Added end-stop marker for State enum.
4167
4168 2010-12-23  Philippe Normand  <pnormand@igalia.com>
4169
4170         Reviewed by Xan Lopez.
4171
4172         [GTK] media/audio-data-url.html fails since r75504
4173         https://bugs.webkit.org/show_bug.cgi?id=51525
4174
4175         Make the GStreamer media-player advertize 3gpp mime-types as
4176         supported if the 3gp caps are in the typefind factories.
4177
4178         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
4179         (WebCore::mimeTypeCache):
4180
4181 2010-12-23  Kent Tamura  <tkent@chromium.org>
4182
4183         Reviewed by Dimitri Glazkov.
4184
4185         Refactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler()
4186         to InputTypes.
4187         https://bugs.webkit.org/show_bug.cgi?id=51093
4188
4189         Move BeforeTextInserted and Wheel event handling, event forwarding to
4190         renderers, and the isindex form submission quirk code to InputTypes.
4191         Also, change the return types of InputType event handlers from 'bool'
4192         to 'void'. We use Event::defaultHandled() to decide whether event
4193         handling should be stopped.
4194
4195         No new tests because this is just a refactoring.
4196
4197         * html/BaseButtonInputType.cpp: bool->void changes
4198         (WebCore::BaseButtonInputType::handleKeydownEvent):
4199         (WebCore::BaseButtonInputType::handleKeypressEvent):
4200         (WebCore::BaseButtonInputType::handleKeyupEvent):
4201         * html/BaseButtonInputType.h: ditto.
4202         * html/BaseCheckableInputType.cpp: ditto.
4203         (WebCore::BaseCheckableInputType::handleKeydownEvent):
4204         (WebCore::Base