WebCore/ChangeLog

   1 2006-10-17  Steve Falkenburg  <sfalken@apple.com>
   2
   3         Build fixes
   4
   5         * bridge/win/BrowserExtensionWin.cpp:
   6         (WebCore::BrowserExtensionWin::createNewWindow):
   7         * bridge/win/BrowserExtensionWin.h:
   8         * bridge/win/FrameWin.cpp:
   9         (WebCore::FrameWin::createNewWindow):
  10         * bridge/win/FrameWin.h:
  11         * platform/gdk/BrowserExtensionGdk.h:
  12         * platform/gdk/TemporaryLinkStubs.cpp:
  13         (BrowserExtensionGdk::createNewWindow):
  14         * platform/qt/BrowserExtensionQt.cpp:
  15         (WebCore::BrowserExtensionQt::createNewWindow):
  16         * platform/qt/BrowserExtensionQt.h:
  17
  18 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
  19
  20         Reviewed by Anders.
  21
  22         Renamed WindowArgs to WindowFeatures, and moved it into its own header.
  23         ("Features" is the term of art in IE documentation. "Args" is pirate
  24         talk.)
  25
  26         * WebCore.xcodeproj/project.pbxproj:
  27         * bindings/js/kjs_window.cpp:
  28         (KJS::createNewWindow):
  29         (KJS::showModalDialog):
  30         (KJS::setWindowFeature):
  31         (KJS::parseWindowFeatures):
  32         (KJS::constrainToVisible):
  33         (KJS::WindowFunc::callAsFunction):
  34         * bridge/BrowserExtension.h:
  35         * bridge/WindowFeatures.h: Added.
  36         * bridge/mac/BrowserExtensionMac.h:
  37         * bridge/mac/BrowserExtensionMac.mm:
  38         (WebCore::BrowserExtensionMac::createNewWindow):
  39
  40 2006-10-17  Sam Weinig  <sam.weinig@gmail.com>
  41
  42         Reviewed by Tim H.
  43
  44         Patch for http://bugs.webkit.org/show_bug.cgi?id=11268
  45         Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint
  46
  47         - Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.
  48
  49         - Moves the contents of ksvg/bindings/js/ to bindings/js/.
  50
  51         - Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.
  52
  53         - Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching
  54           the other CSSValue classing, and allowing the bindings to allocate
  55           appropriately.
  56
  57         - Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing
  58           generation for Objective-C.
  59
  60         - Assorted style cleanups.
  61
  62         * DerivedSources.make:
  63         * WebCore.xcodeproj/project.pbxproj:
  64         * bindings/objc/DOMCSS.mm:
  65         (+[DOMCSSValue _CSSValueWith:WebCore::]):
  66         * bindings/objc/DOMEvents.mm:
  67         (+[DOMEvent _eventWith:WebCore::]):
  68         * bindings/objc/DOMSVG.h:
  69         * bindings/objc/DOMSVGNumber.mm:
  70         (-[DOMSVGNumber dealloc]):
  71         (-[DOMSVGNumber finalize]):
  72         (-[DOMSVGNumber value]):
  73         (-[DOMSVGNumber setValue:]):
  74         (-[DOMSVGNumber _SVGNumber]):
  75         (-[DOMSVGNumber _initWithFloat:]):
  76         (+[DOMSVGNumber _SVGNumberWith:]):
  77         * bindings/objc/DOMSVGPoint.mm:
  78         (-[DOMSVGPoint dealloc]):
  79         (-[DOMSVGPoint finalize]):
  80         (-[DOMSVGPoint x]):
  81         (-[DOMSVGPoint setX:]):
  82         (-[DOMSVGPoint y]):
  83         (-[DOMSVGPoint setY:]):
  84         (-[DOMSVGPoint WebCore::]):
  85         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
  86         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
  87         * bindings/objc/DOMSVGRect.mm:
  88         (-[DOMSVGRect dealloc]):
  89         (-[DOMSVGRect finalize]):
  90         (-[DOMSVGRect x]):
  91         (-[DOMSVGRect setX:]):
  92         (-[DOMSVGRect y]):
  93         (-[DOMSVGRect setY:]):
  94         (-[DOMSVGRect width]):
  95         (-[DOMSVGRect setWidth:]):
  96         (-[DOMSVGRect height]):
  97         (-[DOMSVGRect setHeight:]):
  98         (-[DOMSVGRect WebCore::]):
  99         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
 100         (+[DOMSVGRect _SVGRectWith:WebCore::]):
 101         * bindings/scripts/CodeGeneratorObjC.pm:
 102         * css/StyleBase.h:
 103         (WebCore::StyleBase::isSVGColor):
 104         (WebCore::StyleBase::isSVGPaint):
 105         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
 106         * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
 107         * ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
 108         * ksvg2/bindings/js/JSSVGNumber.h: Removed.
 109         * ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
 110         * ksvg2/bindings/js/JSSVGPoint.h: Removed.
 111         * ksvg2/bindings/js/JSSVGRect.cpp: Removed.
 112         * ksvg2/bindings/js/JSSVGRect.h: Removed.
 113         * ksvg2/svg/SVGColor.h:
 114         (WebCore::SVGColor::isSVGColor):
 115         * ksvg2/svg/SVGFECompositeElement.idl:
 116         * ksvg2/svg/SVGFEFloodElement.idl:
 117         * ksvg2/svg/SVGLocatable.idl:
 118         * ksvg2/svg/SVGMarkerElement.idl:
 119         * ksvg2/svg/SVGPaint.h:
 120         (WebCore::SVGPaint::isSVGPaint):
 121         * ksvg2/svg/SVGRectElement.idl:
 122         * ksvg2/svg/SVGZoomEvent.idl: Removed.
 123
 124 2006-10-17  David Hyatt  <hyatt@apple.com>
 125
 126         Prepare for the elimination of the RenderLayer for <html> elements.  The layer is still present,
 127         but this patch makes everything work without a root layer being around.
 128
 129         Reviewed by beth
 130
 131         * rendering/RenderBlock.cpp:
 132         (WebCore::RenderBlock::paint):
 133         (WebCore::RenderBlock::paintChildren):
 134         (WebCore::RenderBlock::nodeAtPoint):
 135         * rendering/RenderLayer.cpp:
 136         (WebCore::frameVisibleRect):
 137         (WebCore::RenderLayer::hitTest):
 138         (WebCore::RenderLayer::hitTestLayer):
 139         (WebCore::RenderLayer::intersectsDamageRect):
 140         * rendering/RenderObject.cpp:
 141         (WebCore::RenderObject::setInnerNode):
 142         * rendering/RenderView.cpp:
 143         (WebCore::RenderView::paint):
 144
 145 2006-10-17  David Hyatt  <hyatt@apple.com>
 146
 147         Back out my previous patch to the WebCore memory cache.
 148
 149         * loader/Cache.cpp:
 150         (WebCore::Cache::flush):
 151         (WebCore::Cache::setSize):
 152         (WebCore::Cache::getLRUListFor):
 153         (WebCore::Cache::removeFromLRUList):
 154         (WebCore::Cache::insertInLRUList):
 155         * loader/Cache.h:
 156         * loader/CachedCSSStyleSheet.cpp:
 157         (WebCore::CachedCSSStyleSheet::deref):
 158         * loader/CachedCSSStyleSheet.h:
 159         * loader/CachedImage.cpp:
 160         (WebCore::CachedImage::deref):
 161         * loader/CachedImage.h:
 162         * loader/CachedResource.cpp:
 163         (WebCore::CachedResource::setRequest):
 164         (WebCore::CachedResource::deref):
 165         * loader/CachedResource.h:
 166         (WebCore::CachedResource::allowInLRUList):
 167         * loader/CachedScript.cpp:
 168         (WebCore::CachedScript::deref):
 169         * loader/CachedScript.h:
 170         * loader/CachedXBLDocument.cpp:
 171         (WebCore::CachedXBLDocument::deref):
 172         * loader/CachedXBLDocument.h:
 173         * loader/CachedXSLStyleSheet.cpp:
 174         (WebCore::CachedXSLStyleSheet::deref):
 175         * loader/CachedXSLStyleSheet.h:
 176
 177 2006-10-17  Oliver Hunt  <oliver@apple.com>
 178
 179         Reviewed by Anders.
 180
 181         Make north and east resize cursors use correct image
 182
 183         * platform/win/CursorWin.cpp:
 184         (WebCore::eastResizeCursor):
 185         (WebCore::northResizeCursor):
 186
 187 2006-10-17  Oliver Hunt  <oliver@apple.com>
 188
 189         Reviewed by Brady
 190
 191         Various cursor fixes
 192
 193         * page/FrameView.cpp:
 194         (WebCore::FrameView::handleMouseMoveEvent):
 195         * platform/Cursor.h:
 196         * platform/mac/CursorMac.mm:
 197         (WebCore::pointerCursor):
 198         * platform/win/CursorWin.cpp:
 199         (WebCore::supportsAlphaCursors):
 200         (WebCore::Cursor::Cursor):
 201         (WebCore::Cursor::~Cursor):
 202         (WebCore::pointerCursor):
 203
 204 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
 205
 206         Reviewed by harrison
 207
 208         <rdar://problem/4776665>
 209         REGRESSION: In Mail, caret is visible when the message body isn't focused
 210
 211         * page/Frame.cpp:
 212         (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error
 213         (like when the frame that contains the caret isn't focused) then we don't
 214         want to paint the caret.  We should eventually move to using a single bool
 215         for caret painting.
 216
 217 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
 218
 219         Reviewed by harrison
 220
 221         <rdar://problem/4774354>
 222         REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
 223
 224         Functions call recomputCaretRect to see if the caret rect has changed,
 225         and, if it has, they invalidate (repaint) it.  recomputeCaretRect was
 226         returning false if the caret turned into a range selection or was blown
 227         away.
 228
 229         * editing/SelectionController.cpp:
 230         (WebCore::SelectionController::recomputeCaretRect): Don't early return if
 231         !isCaret().  Obtain the FrameView* using the m_frame pointer, because m_sel
 232         may now be null.
 233
 234 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
 235
 236         Reviewed by Brady.
 237
 238         BrowserExtension cleanup.
 239
 240         - Removed unnecessary #include of BrowserExtension in Frame.h, added
 241         #includes to compensate in other files.
 242
 243         - Removed unused versions of createNewWindow.
 244
 245         * bindings/js/kjs_window.cpp:
 246         * bridge/BrowserExtension.h:
 247         * bridge/mac/BrowserExtensionMac.h:
 248         * bridge/mac/BrowserExtensionMac.mm:
 249         (WebCore::BrowserExtensionMac::createNewWindow):
 250         * bridge/mac/WebCoreFrameBridge.mm:
 251         * html/HTMLFormElement.cpp:
 252         * loader/mac/LoaderFunctionsMac.mm:
 253         * page/Frame.h:
 254         * page/FramePrivate.h:
 255
 256 2006-10-15  Geoffrey Garen  <ggaren@apple.com>
 257
 258         Reviewed by Adam.
 259
 260         - Fixed "FIXME: Violates Liskov Substitution principle."
 261
 262         IFRAME was never a true subclass of FRAME, since they disagreed on a
 263         number of behaviors, which, confusingly, IFRAME just overrode and contradicted.
 264
 265         The fix here is to factor out things common to IFRAME and FRAME into a
 266         common base class, HTMLFrameElementBase.
 267
 268         I also changed some " *" to "* " and added #includes in files that implicitly
 269         assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.
 270
 271 2006-10-16  Justin Garcia  <justin.garcia@apple.com>
 272
 273         Reviewed by sullivan
 274
 275         <rdar://problem/4776765>
 276         REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
 277
 278         We set m_needsLayout to false and call caretRect() in the hopes that it will give us
 279         the old caret rect.  It in fact corrects the caret rect for an offset that it
 280         believes is due to scrolling but which is actually due to a change in selection
 281         without an accompanying layout.  So it returns the new caret rect regardless of
 282         what m_needsLayout is set to.
 283
 284         * editing/SelectionController.cpp:
 285         (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that
 286         adds a one pixel slop to this new function.
 287         (WebCore::SelectionController::caretRepaintRect): Moved this code to
 288         repaintRectForCaret.
 289         (WebCore::SelectionController::recomputeCaretRect): Compare the old
 290         caret rect to the new one that's computed with a fresh layout.  If
 291         they are different, invalidate both repaint rects.
 292
 293 2006-10-17  David Harrison  <harrison@apple.com>
 294
 295         Reviewed by Adele.
 296
 297         <rdar://problem/4770453> VO not honoring secure edit fields in web pages
 298
 299         * bridge/mac/WebCoreAXObject.mm:
 300         (-[WebCoreAXObject isPasswordField]):
 301         New. Checks for input with inputType() of PASSWORD.
 302
 303         (-[WebCoreAXObject subrole]):
 304         Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].
 305
 306         (-[WebCoreAXObject roleDescription]):
 307         Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.
 308
 309         (-[WebCoreAXObject value]):
 310         Return nil if [self isPasswordField].
 311
 312         (-[WebCoreAXObject accessibilityAttributeNames]):
 313         Return generic attributes if [self isPasswordField].
 314
 315         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
 316         Return empty array if [self isPasswordField].
 317
 318 2006-10-17  David Hyatt  <hyatt@apple.com>
 319
 320         Fix "flash to white' problem on yahoo.com as it finishes loading.  Refine the FOUC suppression
 321         code so that it will only run if the body still has no renderer.
 322
 323         * dom/Document.cpp:
 324         (WebCore::Document::updateLayoutIgnorePendingStylesheets):
 325
 326 2006-10-17  David Hyatt  <hyatt@apple.com>
 327
 328         Fix a bug where the WebCore memory cache could grow without bound during extended browsing
 329         sessions.
 330
 331         Reviewed by mjs
 332
 333         * loader/Cache.cpp:
 334         (WebCore::Cache::flush):
 335         (WebCore::Cache::setSize):
 336         (WebCore::Cache::getLRUListFor):
 337         (WebCore::Cache::removeFromLRUList):
 338         (WebCore::Cache::insertInLRUList):
 339         * loader/Cache.h:
 340         * loader/CachedCSSStyleSheet.cpp:
 341         * loader/CachedCSSStyleSheet.h:
 342         * loader/CachedImage.cpp:
 343         * loader/CachedImage.h:
 344         * loader/CachedResource.cpp:
 345         (WebCore::CachedResource::setRequest):
 346         (WebCore::CachedResource::deref):
 347         * loader/CachedResource.h:
 348         (WebCore::CachedResource::allowInLRUList):
 349         * loader/CachedScript.cpp:
 350         * loader/CachedScript.h:
 351         * loader/CachedXBLDocument.cpp:
 352         * loader/CachedXBLDocument.h:
 353         * loader/CachedXSLStyleSheet.cpp:
 354         * loader/CachedXSLStyleSheet.h:
 355
 356 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
 357
 358         Reviewed by harrison
 359
 360         <rdar://problem/3655385>
 361         Editing: -indent: method unimplemented
 362
 363         Added Frame and bridge methods.
 364
 365         * bridge/mac/WebCoreFrameBridge.h:
 366         * bridge/mac/WebCoreFrameBridge.mm:
 367         (-[WebCoreFrameBridge indent]):
 368         (-[WebCoreFrameBridge outdent]):
 369         * page/Frame.cpp:
 370         (WebCore::Frame::indent):
 371         (WebCore::Frame::outdent):
 372         * page/Frame.h:
 373
 374 2006-10-16  Adam Roben  <aroben@apple.com>
 375
 376         Reviewed by John.
 377
 378         More menulist cleanup/tweaking.
 379
 380         * html/HTMLSelectElement.cpp:
 381         (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index'
 382         parameter to 'optionIndex' for clarity.
 383         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over
 384         items that are not enabled <option> elements when using arrow keys, and
 385         make sure we pass an option index to setSelectedIndex.
 386         * platform/PopupMenu.h:
 387         (WebCore::PopupMenu::setWasClicked): Specify default argument.
 388         * rendering/RenderMenuList.cpp:
 389         (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from
 390         option text before setting the control text so that options within
 391         <optgroup>s don't appear indented in the actual control.
 392
 393 2006-10-16  Sam Weinig  <sam.weinig@gmail.com>
 394
 395         Reviewed by Adam.
 396
 397         Win32 build fix.
 398
 399         * WebCore.vcproj/WebCore/WebCore.vcproj:
 400         * bridge/win/BrowserExtensionWin.cpp:
 401         (WebCore::BrowserExtensionWin::createNewWindow):
 402         * bridge/win/FrameWin.cpp:
 403         (WebCore::FrameWin::urlSelected):
 404         (WebCore::FrameWin::submitForm):
 405         (WebCore::FrameWin::createNewWindow):
 406         * bridge/win/FrameWin.h:
 407         * loader/loader.cpp:
 408         (WebCore::Loader::receivedResponse):
 409         * platform/win/GraphicsContextWin.cpp:
 410         (WebCore::GraphicsContext::getWindowsContext):
 411         (WebCore::GraphicsContext::releaseWindowsContext):
 412         * platform/win/TemporaryLinkStubs.cpp:
 413         (FrameWin::openURLRequest):
 414         (WebCore::ServeSynchronousRequest):
 415         (WebCore::CheckIfReloading):
 416         (WebCore::IsResponseURLEqualToURL):
 417         (WebCore::ResponseMIMEType):
 418         (WebCore::ResponseIsMultipart):
 419         (WebCore::CacheObjectExpiresTime):
 420         (CachedResource::setResponse):
 421         (CachedResource::setAllData):
 422         * rendering/RenderThemeWin.cpp:
 423         (WebCore::doneDrawing):
 424         (WebCore::RenderThemeWin::paintButton):
 425         (WebCore::RenderThemeWin::paintTextField):
 426
 427 2006-10-16  David Hyatt  <hyatt@apple.com>
 428
 429         Fix for bug 9347, positioned elements have the wrong containing block.  This is a change from CSS2 to
 430         CSS2.1.  In the absence of any other enclosing positioned elements, the containing block for a positioned
 431         element is the initial containing block (our RenderView).
 432
 433         Reviewed by mjs
 434
 435         Test cases added to fast/block/positioning for quirks and strict modes.
 436
 437         * rendering/RenderBlock.cpp:
 438         (WebCore::RenderBlock::lowestPosition):
 439         (WebCore::RenderBlock::rightmostPosition):
 440         (WebCore::RenderBlock::leftmostPosition):
 441         * rendering/RenderBox.cpp:
 442         (WebCore::RenderBox::containingBlockHeightForPositioned):
 443         (WebCore::RenderBox::calcAbsoluteVertical):
 444         * rendering/RenderObject.cpp:
 445         (WebCore::RenderObject::containingBlock):
 446         (WebCore::RenderObject::container):
 447
 448 2006-10-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
 449
 450         Reviewed by Anders.
 451
 452         Misc Gdk/Linux build fixes.
 453
 454         * platform/gdk/BrowserExtensionGdk.h:
 455         * platform/gdk/FrameGdk.cpp:
 456         (WebCore::FrameGdk::submitForm):
 457         (WebCore::FrameGdk::urlSelected):
 458         * platform/gdk/FrameGdk.h:
 459         * platform/gdk/RenderPopupMenuGdk.cpp:
 460         (WebCore::PopupMenu::PopupMenu):
 461         (WebCore::PopupMenu::~PopupMenu):
 462         (WebCore::PopupMenu::clear):
 463         (WebCore::PopupMenu::populate):
 464         (WebCore::PopupMenu::show):
 465         (WebCore::PopupMenu::hide):
 466         (WebCore::PopupMenu::addSeparator):
 467         (WebCore::PopupMenu::addGroupLabel):
 468         (WebCore::PopupMenu::addOption):
 469         * platform/gdk/RenderPopupMenuGdk.h:
 470         * platform/gdk/RenderThemeGdk.cpp:
 471         * platform/gdk/RenderThemeGdk.h:
 472         (WebCore::RenderThemeGdk::RenderThemeGdk):
 473         * platform/gdk/TemporaryLinkStubs.cpp:
 474         (BrowserExtensionGdk::createNewWindow):
 475         (BrowserExtensionGdk::BrowserExtensionGdk):
 476         (BrowserExtensionGdk::setTypedIconURL):
 477         (BrowserExtensionGdk::setIconURL):
 478         (BrowserExtensionGdk::getHistoryLength):
 479         (WebCore::CheckIfReloading):
 480         (WebCore::CacheObjectExpiresTime):
 481         (WebCore::ResponseURL):
 482         (WebCore::IsResponseURLEqualToURL):
 483         (WebCore::ResponseIsMultipart):
 484         (WebCore::ResponseMIMEType):
 485         (WebCore::CachedResource::setResponse):
 486         (WebCore::CachedResource::setAllData):
 487         (FileChooser::disconnectUploadControl):
 488         * rendering/RenderTheme.h:
 489         * rendering/RenderThemeMac.h:
 490
 491 2006-10-15  Sam Weinig  <sam.weinig@gmail.com>
 492
 493         Reviewed by Mitz.
 494
 495         Fix for http://bugs.webkit.org/show_bug.cgi?id=11294
 496         Add getModifierState method to KeyboardEvent
 497
 498         * bindings/objc/DOMEvents.h:
 499         * bindings/objc/DOMEvents.mm:
 500         * bindings/objc/PublicDOMInterfaces.h:
 501         * dom/KeyboardEvent.cpp:
 502         (WebCore::KeyboardEvent::getModifierState):
 503         * dom/KeyboardEvent.h:
 504         * dom/KeyboardEvent.idl:
 505
 506 2006-10-15  Nikolas Zimmermann  <zimmermann@kde.org>
 507
 508         Reviewed and landed by ap.
 509
 510         Changed PlatformResponse handling for Qt. Don't just store
 511         a QString object containing the data but a new PlatformResponseQt struct
 512         containing data and url, and store it as pointer. This is compatible
 513         to the OS X handling and removes the Qt plaform specific hacks from
 514         CachedCSSStyleSheet, CachedResource & loader.
 515
 516         Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move
 517         all methods from TemporaryLinkStubs related to loading in there, and implement
 518         some like ServeSynchronousRequest (yay for xslt handling!).
 519
 520         * CMakeLists.txt:
 521         * loader/CachedCSSStyleSheet.cpp:
 522         (WebCore::CachedCSSStyleSheet::checkNotify):
 523         * loader/CachedResource.h:
 524         (WebCore::CachedResource::CachedResource):
 525         * loader/loader.cpp:
 526         (WebCore::Loader::receivedResponse):
 527         * platform/ResourceLoaderClient.h:
 528         * platform/ResourceLoaderInternal.h:
 529         * platform/qt/FrameQt.cpp:
 530         (WebCore::FrameQt::~FrameQt):
 531         (WebCore::FrameQt::createEmptyDocument):
 532         * platform/qt/FrameQt.h:
 533         (WebCore::QtFrame):
 534         * platform/qt/FrameQtClient.cpp:
 535         (WebCore::FrameQtClientDefault::setFrame):
 536         (WebCore::FrameQtClientDefault::openURL):
 537         (WebCore::FrameQtClientDefault::loadFinished):
 538         (WebCore::FrameQtClientDefault::receivedAllData):
 539         * platform/qt/FrameQtClient.h:
 540         * platform/qt/LoaderFunctionsQt.cpp: Added.
 541         (WebCore::ServeSynchronousRequest):
 542         (WebCore::NumberOfPendingOrLoadingRequests):
 543         (WebCore::CheckIfReloading):
 544         (WebCore::CheckCacheObjectStatus):
 545         (WebCore::IsResponseURLEqualToURL):
 546         (WebCore::ResponseURL):
 547         (WebCore::ResponseMIMEType):
 548         (WebCore::ResponseIsMultipart):
 549         (WebCore::CacheObjectExpiresTime):
 550         (WebCore::CachedResource::setResponse):
 551         (WebCore::CachedResource::setAllData):
 552         * platform/qt/ResourceLoaderManager.cpp:
 553         (WebCore::ResourceLoaderManager::remove):
 554         * platform/qt/ResourceLoaderQt.cpp:
 555         (WebCore::ResourceLoader::~ResourceLoader):
 556         (WebCore::ResourceLoader::start):
 557         (WebCore::ResourceLoader::assembleResponseHeaders):
 558         (WebCore::ResourceLoader::receivedResponse):
 559         * platform/qt/TemporaryLinkStubs.cpp:
 560
 561 2006-10-14  Rob Buis  <buis@kde.org>
 562
 563         Reviewed by Mitz.
 564
 565         http://bugs.webkit.org/show_bug.cgi?id=11217
 566         Cleanup svg coding style
 567
 568         Cleanup coding style in svg basic datastructure classes.
 569
 570         * ksvg2/svg/SVGAngle.cpp:
 571         (WebCore::SVGAngle::valueAsString):
 572         (WebCore::SVGAngle::context):
 573         (WebCore::SVGAngle::setContext):
 574         * ksvg2/svg/SVGAngle.h:
 575         * ksvg2/svg/SVGColor.cpp:
 576         * ksvg2/svg/SVGColor.h:
 577         * ksvg2/svg/SVGElement.cpp:
 578         (WebCore::SVGElement::ownerSVGElement):
 579         (WebCore::SVGElement::viewportElement):
 580         (WebCore::SVGElement::parseMappedAttribute):
 581         (WebCore::SVGElement::childShouldCreateRenderer):
 582         * ksvg2/svg/SVGElement.h:
 583         (WebCore::svg_dynamic_cast):
 584         * ksvg2/svg/SVGFitToViewBox.cpp:
 585         (WebCore::SVGFitToViewBox::parseViewBox):
 586         * ksvg2/svg/SVGFitToViewBox.h:
 587         * ksvg2/svg/SVGLangSpace.cpp:
 588         (WebCore::SVGLangSpace::parseMappedAttribute):
 589         * ksvg2/svg/SVGLangSpace.h:
 590         * ksvg2/svg/SVGLength.cpp:
 591         (WebCore::SVGLength::SVGLength):
 592         (WebCore::SVGLength::setValueAsString):
 593         (WebCore::SVGLength::dpi):
 594         (WebCore::SVGLength::updateValue):
 595         (WebCore::SVGLength::updateValueInSpecifiedUnits):
 596         (WebCore::SVGLength::context):
 597         (WebCore::SVGLength::setContext):
 598         * ksvg2/svg/SVGLength.h:
 599         * ksvg2/svg/SVGLengthList.cpp:
 600         * ksvg2/svg/SVGLengthList.h:
 601         * ksvg2/svg/SVGLocatable.cpp:
 602         (WebCore::SVGLocatable::nearestViewportElement):
 603         (WebCore::SVGLocatable::farthestViewportElement):
 604         (WebCore::SVGLocatable::getBBox):
 605         (WebCore::SVGLocatable::getCTM):
 606         (WebCore::SVGLocatable::getScreenCTM):
 607         * ksvg2/svg/SVGNumberList.cpp:
 608         * ksvg2/svg/SVGNumberList.h:
 609         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
 610         (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
 611         (WebCore::SVGPreserveAspectRatio::getCTM):
 612         * ksvg2/svg/SVGPreserveAspectRatio.h:
 613         * ksvg2/svg/SVGStringList.cpp:
 614         (WebCore::SVGStringList::reset):
 615         * ksvg2/svg/SVGStringList.h:
 616         * ksvg2/svg/SVGStylable.cpp:
 617         * ksvg2/svg/SVGStylable.h:
 618         * ksvg2/svg/SVGTests.cpp:
 619         (WebCore::SVGTests::requiredFeatures):
 620         (WebCore::SVGTests::requiredExtensions):
 621         (WebCore::SVGTests::systemLanguage):
 622         (WebCore::SVGTests::isValid):
 623         (WebCore::SVGTests::parseMappedAttribute):
 624         * ksvg2/svg/SVGTests.h:
 625         * ksvg2/svg/SVGTransformable.cpp:
 626         (WebCore::SVGTransformable::parseTransformAttribute):
 627         * ksvg2/svg/SVGTransformable.h:
 628         * ksvg2/svg/SVGURIReference.cpp:
 629         (WebCore::SVGURIReference::parseMappedAttribute):
 630         * ksvg2/svg/SVGZoomAndPan.cpp:
 631         (WebCore::SVGZoomAndPan::parseMappedAttribute):
 632         * ksvg2/svg/SVGZoomAndPan.h:
 633
 634 2006-10-15  Nikolas Zimmermann  <zimmermann@kde.org>
 635
 636         Reviewed by Oliver.
 637
 638         Implement some functions in FrameQt / ScrollViewQt.
 639
 640         Added comments what needs to be done in quite some places,
 641         marked some functions as no-ops.
 642
 643         * CMakeLists.txt:
 644         * platform/qt/FrameQt.cpp:
 645         (WebCore::FrameQt::FrameQt):
 646         (WebCore::FrameQt::runJavaScriptConfirm):
 647         (WebCore::FrameQt::locationbarVisible):
 648         (WebCore::FrameQt::createFrame):
 649         (WebCore::FrameQt::passSubframeEventToSubframe):
 650         (WebCore::FrameQt::menubarVisible):
 651         (WebCore::FrameQt::personalbarVisible):
 652         (WebCore::FrameQt::statusbarVisible):
 653         (WebCore::FrameQt::toolbarVisible):
 654         (WebCore::FrameQt::markedTextRange):
 655         (WebCore::FrameQt::lastEventIsMouseUp):
 656         (WebCore::FrameQt::openURLRequest):
 657         (WebCore::FrameQt::scheduleClose):
 658         (WebCore::FrameQt::unfocusWindow):
 659         (WebCore::FrameQt::focusWindow):
 660         (WebCore::FrameQt::overrideMediaType):
 661         (WebCore::FrameQt::runJavaScriptPrompt):
 662         (WebCore::FrameQt::bindingRootObject):
 663         (WebCore::FrameQt::addPluginRootObject):
 664         (WebCore::FrameQt::registerCommandForUndo):
 665         (WebCore::FrameQt::registerCommandForRedo):
 666         (WebCore::FrameQt::clearUndoRedoOperations):
 667         (WebCore::FrameQt::respondToChangedSelection):
 668         (WebCore::FrameQt::respondToChangedContents):
 669         (WebCore::FrameQt::shouldChangeSelection):
 670         (WebCore::FrameQt::canGoBackOrForward):
 671         (WebCore::FrameQt::canPaste):
 672         (WebCore::FrameQt::canRedo):
 673         (WebCore::FrameQt::canUndo):
 674         * platform/qt/FrameQt.h:
 675         * platform/qt/FrameQtClient.cpp:
 676         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
 677         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
 678         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
 679         (WebCore::FrameQtClientDefault::menubarVisible):
 680         (WebCore::FrameQtClientDefault::toolbarVisible):
 681         (WebCore::FrameQtClientDefault::statusbarVisible):
 682         (WebCore::FrameQtClientDefault::personalbarVisible):
 683         (WebCore::FrameQtClientDefault::locationbarVisible):
 684         * platform/qt/FrameQtClient.h:
 685         * platform/qt/ImageSourceQt.cpp:
 686         * platform/qt/RenderThemeQt.cpp:
 687         * platform/qt/ScrollViewQt.cpp:
 688         (WebCore::ScrollView::scrollPointRecursively):
 689         * platform/qt/TemporaryLinkStubs.cpp:
 690         (WebCore::CachedResource::setResponse):
 691         (WebCore::CachedResource::setAllData):
 692
 693 2006-10-14  David Harrison  <harrison@apple.com>
 694
 695         Reviewed by Geoff.
 696
 697         <rdar://problem/4775213> REGRESSION: Can't from tab from last link on the page to URL address field
 698         <rdar://problem/4783926> REGRESSION: Typing tab key enters no text
 699
 700         The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless
 701         of whether frame->view()->advanceFocus() actually changed the focus.
 702
 703         Trivial fix is to preventDefault() only if advanceFocus() returns true.
 704
 705         * No test is possible because DumpRenderTree sets the WebView preference to
 706         tab to links, and that preference cannot be changed dynamically after
 707         the webview is initialized. Also, the "tab from last link" is not testable
 708         because DumpRenderTree uses the WebView for the whole window, so tabs can't
 709         shift focus out of the WebView regardless.
 710
 711         * dom/EventTargetNode.cpp:
 712         (WebCore::EventTargetNode::defaultEventHandler):
 713
 714 2006-10-14  Nikolas Zimmermann  <zimmermann@kde.org>
 715
 716         Reviewed by Mitz.
 717
 718         Fix Qt/Linux build & some little fixes:
 719
 720         - Adapt to Maciej's FrameLoadRequest changes.
 721         - Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
 722         - Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
 723         - Fix CacheObjectExpiresTime/ResponseIsMultipart signature.
 724
 725         * loader/CachedCSSStyleSheet.cpp:
 726         (WebCore::CachedCSSStyleSheet::checkNotify):
 727         * loader/CachedResource.h:
 728         (WebCore::CachedResource::CachedResource):
 729         * loader/loader.cpp:
 730         (WebCore::Loader::receivedAllData):
 731         (WebCore::Loader::receivedResponse):
 732         * platform/qt/BrowserExtensionQt.cpp:
 733         (WebCore::BrowserExtensionQt::createNewWindow):
 734         * platform/qt/BrowserExtensionQt.h:
 735         * platform/qt/FrameQt.cpp:
 736         (WebCore::FrameQt::submitForm):
 737         (WebCore::FrameQt::urlSelected):
 738         (WebCore::FrameQt::openURLRequest):
 739         * platform/qt/FrameQt.h:
 740         * platform/qt/GraphicsContextQt.cpp:
 741         (WebCore::GraphicsContext::setURLForRect):
 742         * platform/qt/TemporaryLinkStubs.cpp:
 743         (WebCore::CacheObjectExpiresTime):
 744         (WebCore::ResponseIsMultipart):
 745         (WebCore::CachedResource::setResponse):
 746         (WebCore::CachedResource::setAllData):
 747
 748 2006-10-14  David Carson  <dacarson@gmail.com>
 749
 750         Reviewed by Maciej.
 751
 752         Fix: http://bugs.webkit.org/show_bug.cgi?id=11257
 753         Removed Mac platform dependance, changed WebCore functions to
 754         use PlatformResponse/PlatformData rather than NSURLResponse/
 755         NSData.
 756
 757         * loader/CachedCSSStyleSheet.cpp:
 758         (WebCore::CachedCSSStyleSheet::checkNotify):
 759         * loader/CachedImage.cpp:
 760         (WebCore::CachedImage::createImage):
 761         * loader/CachedResource.cpp:
 762         (WebCore::CachedResource::~CachedResource):
 763         * loader/CachedResource.h:
 764         (WebCore::CachedResource::CachedResource):
 765         (WebCore::CachedResource::response):
 766         (WebCore::CachedResource::allData):
 767         * loader/LoaderFunctions.h:
 768         * loader/loader.cpp:
 769         (WebCore::Loader::receivedResponse):
 770         * loader/mac/LoaderFunctionsMac.mm:
 771         (WebCore::ResponseMIMEType):
 772         (WebCore::ResponseIsMultipart):
 773         (WebCore::CacheObjectExpiresTime):
 774         (WebCore::CachedResource::setResponse):
 775         (WebCore::CachedResource::setAllData):
 776         * platform/qt/TemporaryLinkStubs.cpp:
 777         (WebCore::CacheObjectExpiresTime):
 778         (WebCore::ResponseIsMultipart):
 779         (WebCore::ResponseMIMEType):
 780         (WebCore::CachedResource::setResponse):
 781         (WebCore::CachedResource::setAllData):
 782         * platform/win/TemporaryLinkStubs.cpp:
 783         (WebCore::CacheObjectExpiresTime):
 784         (WebCore::ResponseIsMultipart):
 785         (WebCore::ResponseMIMEType):
 786         (WebCore::CachedResource::setResponse):
 787         (WebCore::CachedResource::setAllData):
 788
 789 2006-10-14  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
 790
 791         Reviewed by Maciej.
 792
 793         Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
 794         Pure virtual classes require non-pure destructor, who knew.
 795
 796         Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
 797         so that other platforms can also use CURL, if they wish.
 798
 799         Silence compiler warning about unused variable in SharedTimerLinux.cpp
 800
 801         * platform/ResourceLoaderInternal.h:
 802         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
 803         * platform/gdk/FrameGdk.h:
 804         (WebCore::FrameGdkClient::~FrameGdkClient):
 805         * platform/gdk/ResourceLoaderManager.cpp:
 806         (WebCore::ResourceLoaderManager::downloadTimerCallback):
 807         * platform/gdk/SharedTimerLinux.cpp:
 808         (WebCore::stopSharedTimer):
 809
 810 2006-10-13  Beth Dakin  <bdakin@apple.com>
 811
 812         Reviewed by Geoff.
 813
 814         Build fix from my last check-in. Make hasOutlineAnnotation() non-
 815         inline so that we don't have to include Document.h in
 816         RenderObject.h
 817         Doing so causes a build failure in WebKit, and it probably isn't a
 818         good idea anyway.
 819
 820         * rendering/RenderObject.cpp:
 821         (WebCore::RenderObject::hasOutlineAnnotation):
 822         * rendering/RenderObject.h:
 823         (WebCore::RenderObject::hasOutline):
 824
 825 2006-10-13  Beth Dakin  <bdakin@apple.com>
 826
 827         Patch written mostly by Ken Kraisler, but also by me.
 828
 829         Reviewed by Hyatt.
 830
 831         Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
 832         problem/3391162> PDF created by printing should have live
 833         hyperlinks
 834
 835         * platform/GraphicsContext.cpp:
 836         (WebCore::GraphicsContext::focusRingBoundingRect):
 837         * platform/GraphicsContext.h:
 838         * platform/cairo/GraphicsContextCairo.cpp:
 839         (WebCore::GraphicsContext::setURLForRect):
 840         * platform/cg/GraphicsContextCG.cpp:
 841         (WebCore::GraphicsContext::setURLForRect): Implement method to add
 842         URL link to PDF document.
 843         * rendering/InlineFlowBox.cpp:
 844         (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of
 845         querying the outline width
 846         * rendering/RenderBlock.cpp:
 847         (WebCore::RenderBlock::paintObject): Same as above.
 848         * rendering/RenderFlow.cpp:
 849         (WebCore::RenderFlow::paintLines): Call the new paintOutline()
 850         (WebCore::RenderFlow::paintOutline): Take care of focus ring and
 851         pdf url rects, and outline painting.
 852         * rendering/RenderFlow.h:
 853         * rendering/RenderObject.cpp:
 854         (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF
 855         link to a rectanglular region.
 856         (WebCore::RenderObject::paintOutline): Take care of pdf rects as
 857         well as focus ring painting.
 858         * rendering/RenderObject.h:
 859         (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the
 860         element is a link and we are printing.
 861         (WebCore::RenderObject::hasOutline): Returns true is the style has
 862         an outline and hasOutlineAnnotation() is true.
 863         * rendering/RenderStyle.h:
 864         (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is
 865         greater than 0 and outlineStyle is greater than BHIDDEN.
 866
 867 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
 868
 869         Reviewed by ggaren and harrison
 870
 871         <rdar://problem/4744008>
 872         9A270: Mail crashes when I try to paste large items from Safari
 873
 874         * editing/ReplaceSelectionCommand.cpp:
 875         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
 876         Even though we put nodes in the hash map in pre-order, they don't necessary
 877         come out of the iterator that way.  If a node is a redundant style span
 878         and one of its pruned ancestors comes off the hash map after it, and that
 879         ancestor is a redundant style span or font tag, we will try to remove it
 880         even though it has already been removed and we'll crash.
 881         The test case added with the fix depends on our hash map implementation
 882         because it requires that a particular redundant style span come out of
 883         the iterator before its parent. So, it may eventually not provide
 884         coverage for the fix.
 885
 886 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
 887
 888         Reviewed by Darin.
 889
 890         - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
 891
 892         * WebCore.xcodeproj/project.pbxproj:
 893         * bindings/js/kjs_window.cpp:
 894         (KJS::createNewWindow):
 895         (KJS::WindowFunc::callAsFunction):
 896         * bridge/BrowserExtension.h:
 897         * bridge/mac/BrowserExtensionMac.h:
 898         * bridge/mac/BrowserExtensionMac.mm:
 899         (WebCore::BrowserExtensionMac::createNewWindow):
 900         * bridge/mac/FrameMac.h:
 901         * bridge/mac/FrameMac.mm:
 902         (WebCore::FrameMac::submitForm):
 903         (WebCore::FrameMac::openURLRequest):
 904         (WebCore::FrameMac::urlSelected):
 905         * bridge/win/BrowserExtensionWin.h:
 906         * page/Frame.cpp:
 907         (WebCore::Frame::changeLocation):
 908         (WebCore::Frame::urlSelected):
 909         (WebCore::Frame::requestFrame):
 910         (WebCore::Frame::submitForm):
 911         * page/Frame.h:
 912         * page/FrameLoadRequest.h: Added.
 913         (WebCore::FrameLoadRequest::FrameLoadRequest):
 914         (WebCore::FrameLoadRequest::lockHistory):
 915         (WebCore::FrameLoadRequest::setLockHistory):
 916         * page/ResourceRequest.h:
 917         (WebCore::ResourceRequest::ResourceRequest):
 918
 919 2006-10-13  John Sullivan  <sullivan@apple.com>
 920
 921         Reviewed by Maciej
 922
 923         * loader/mac/WebFrameLoader.mm:
 924         (-[WebFrameLoader loadDocumentLoader:]):
 925         Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can
 926         happen when loading a page during a decidePolicyForNavigationAction callback.
 927
 928 2006-10-13  Dave Hyatt  <hyatt@apple.com>
 929
 930         Transparency layer work.
 931
 932         Reviewed by aroben
 933
 934         * platform/GraphicsContext.h:
 935         * platform/cg/GraphicsContextCG.cpp:
 936         (WebCore::GraphicsContext::beginTransparencyLayer):
 937         (WebCore::GraphicsContext::endTransparencyLayer):
 938         * platform/cg/GraphicsContextPlatformPrivate.h:
 939         (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
 940         (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
 941
 942 2006-10-13  Rob Buis  <buis@kde.org>
 943
 944         Reviewed by Mitz.
 945
 946         http://bugs.webkit.org/show_bug.cgi?id=11217
 947         Cleanup svg coding style
 948
 949         Cleanup coding style in svg paint server classes.
 950
 951         * ksvg2/svg/SVGGradientElement.cpp:
 952         (WebCore::SVGGradientElement::SVGGradientElement):
 953         (WebCore::SVGGradientElement::parseMappedAttribute):
 954         (WebCore::SVGGradientElement::notifyAttributeChange):
 955         (WebCore::SVGGradientElement::canvasResource):
 956         (WebCore::SVGGradientElement::rebuildStops):
 957         * ksvg2/svg/SVGGradientElement.h:
 958         * ksvg2/svg/SVGLinearGradientElement.cpp:
 959         (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
 960         (WebCore::SVGLinearGradientElement::parseMappedAttribute):
 961         (WebCore::SVGLinearGradientElement::buildGradient):
 962         * ksvg2/svg/SVGLinearGradientElement.h:
 963         * ksvg2/svg/SVGPatternElement.cpp:
 964         (WebCore::SVGPatternElement::SVGPatternElement):
 965         (WebCore::SVGPatternElement::parseMappedAttribute):
 966         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
 967         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
 968         (WebCore::SVGPatternElement::notifyClientsToRepaint):
 969         (WebCore::SVGPatternElement::notifyAttributeChange):
 970         (WebCore::SVGPatternElement::canvasResource):
 971         (WebCore::SVGPatternElement::getCTM):
 972         * ksvg2/svg/SVGPatternElement.h:
 973         (WebCore::SVGPatternElement::rendererIsNeeded):
 974         * ksvg2/svg/SVGRadialGradientElement.cpp:
 975         (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
 976         (WebCore::SVGRadialGradientElement::parseMappedAttribute):
 977         (WebCore::SVGRadialGradientElement::buildGradient):
 978         * ksvg2/svg/SVGRadialGradientElement.h:
 979         * ksvg2/svg/SVGStopElement.cpp:
 980         (WebCore::SVGStopElement::SVGStopElement):
 981         (WebCore::SVGStopElement::parseMappedAttribute):
 982         * ksvg2/svg/SVGStopElement.h:
 983
 984 2006-10-13  Geoffrey Garen  <ggaren@apple.com>
 985
 986         Reviewed by Darin, John.
 987
 988         - Merged more frame and iframe code
 989         - Fixed a bug where iframes returned incorrect values for renderer-dependent
 990         properties during javascript: loads because they didn't have renderers at
 991         load time
 992
 993         PLT insists this is a small performance win. Don't believe its lies.
 994
 995         * bindings/js/kjs_html.cpp:
 996         (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to
 997         width and height, for consistency with the rest of the DOM.
 998         * dom/ContainerNode.cpp:
 999         (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback
1000         queue that gets drained after the render tree is fully constructed. Currently,
1001         this is only used for frame loading.
1002         (WebCore::ContainerNode::attach):
1003         * dom/ContainerNode.h:
1004         * html/HTMLFrameElement.cpp:
1005         (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from
1006         attach() because loading iframes during attach() causes a crash.
1007         Moved frame loading logic into insertedIntoDocument(). That's a more
1008         logical place for it because  document insertion is what
1009         triggers frame loading. Made frame loading a post-attach callback, instead
1010         of an immediate action, to fix the incorrect values bug.
1011         (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be
1012         in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon
1013         require this call, once I remove the call from WebKit.
1014         (WebCore::HTMLFrameElement::setLocation):
1015         (WebCore::HTMLFrameElement::width):
1016         (WebCore::HTMLFrameElement::height):
1017         * html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary
1018         killing of puppies.
1019         * html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement
1020         (WebCore::HTMLIFrameElement::rendererIsNeeded):
1021         (WebCore::HTMLIFrameElement::createRenderer):
1022         (WebCore::HTMLIFrameElement::insertedIntoDocument):
1023         (WebCore::HTMLIFrameElement::removedFromDocument):
1024         (WebCore::HTMLIFrameElement::attach):
1025         * page/FrameView.h: Removed unused method.
1026
1027 2006-10-13  David Harrison  <harrison@apple.com>
1028
1029         Reviewed by Justin.
1030
1031         <rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
1032
1033         Tests added or changed:
1034         * editing/style/style-boundary-005.html: Added. Matches steps from bug.
1035         * editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
1036         * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
1037         * editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
1038         * editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
1039
1040         * dom/Text.cpp:
1041         (WebCore::Text::splitText):
1042         Comment changes.
1043
1044         * editing/ApplyStyleCommand.cpp:
1045         (WebCore::isUnstyledStyleSpan):
1046         Renamed from isEmptyStyleSpan.
1047
1048         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
1049         Rename emptySpans local to unstyledSpans.
1050
1051         (WebCore::dummySpanAncestorForNode):
1052         New. To locate Apple style span created when splitting a text node.
1053
1054         (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
1055         Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
1056         of dummy span's parents, rather than traversing up from start and
1057         end locations. Old algorithm would miss empty spans in the bug case.
1058
1059         (WebCore::ApplyStyleCommand::applyInlineStyle):
1060         Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().
1061
1062         (WebCore::ApplyStyleCommand::removeCSSStyle):
1063         Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().
1064
1065         (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
1066         Comment changes.
1067
1068         * editing/ApplyStyleCommand.h:
1069         Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().
1070
1071         * editing/ReplaceSelectionCommand.cpp:
1072         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
1073         Allow for Apple style span to be unstyled, because old email may have this in the DOM.
1074         Use !node->hasChildNodes() instead of !node->firstChild().
1075
1076         * editing/SplitTextNodeCommand.cpp:
1077         (WebCore::SplitTextNodeCommand::doApply):
1078         Comment changes.
1079
1080         * rendering/RenderTreeAsText.cpp:
1081         (WebCore::isEmptyOrUnstyledAppleStyleSpan):
1082         (WebCore::operator<<):
1083         Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM
1084
1085 2006-10-13  Nikolas Zimmermann  <zimmermann@kde.org>
1086
1087         Reviewed by Eric.
1088
1089         Fix Qt/Linux build after Adele's popup menu changes.
1090
1091         * CMakeLists.txt:
1092         * platform/qt/FileChooserQt.cpp:
1093         (WebCore::FileChooser::disconnectUploadControl):
1094         * platform/qt/PopupMenuQt.cpp: Added.
1095         (WebCore::PopupMenu::PopupMenu):
1096         (WebCore::PopupMenu::~PopupMenu):
1097         (WebCore::PopupMenu::clear):
1098         (WebCore::PopupMenu::populate):
1099         (WebCore::PopupMenu::show):
1100         (WebCore::PopupMenu::hide):
1101         (WebCore::PopupMenu::addSeparator):
1102         (WebCore::PopupMenu::addGroupLabel):
1103         (WebCore::PopupMenu::addOption):
1104         * platform/qt/RenderPopupMenuQt.cpp: Removed.
1105         * platform/qt/RenderPopupMenuQt.h: Removed.
1106         * platform/qt/RenderThemeQt.cpp:
1107
1108 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
1109
1110         Reviewed by Darin.
1111
1112         fixed build failure
1113
1114         * WebCore.xcodeproj/project.pbxproj:
1115         * loader/mac/WebFrameLoader.mm:
1116
1117 2006-10-13  Darin Adler  <darin@apple.com>
1118
1119         Reviewed by Adele.
1120
1121         - converted WebFormState from Objective-C to C++
1122
1123         * WebCore.exp: Added a new symbol, changed one symbol from C to C++.
1124
1125         * WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project".
1126         Added UChar.h and FrameLoaderTypes.h.
1127
1128         * loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.
1129
1130         * loader/mac/WebFormState.h: Converted class to C++.
1131         * loader/mac/WebFormState.mm: Ditto.
1132
1133         * loader/mac/WebFrameLoader.h:
1134         * loader/mac/WebFrameLoader.mm:
1135         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
1136         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
1137         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
1138         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
1139         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
1140         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
1141         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
1142         (-[WebFrameLoader continueAfterNavigationPolicy:]):
1143         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
1144         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
1145         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
1146         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
1147         Changed Objective-C WebFormState uses to C++ WebCore::FormState.
1148
1149 2006-10-13  Adele Peterson  <adele@apple.com>
1150
1151         Reviewed by Maciej.
1152
1153         - Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color
1154
1155         * rendering/RenderListBox.cpp:
1156         (WebCore::RenderListBox::paintItemForeground):
1157         * rendering/RenderTheme.cpp:
1158         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
1159         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
1160         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
1161         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
1162         * rendering/RenderThemeMac.h:
1163         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
1164
1165 2006-10-13  Rob Buis  <buis@kde.org>
1166
1167         Reviewed by Mitz.
1168
1169         http://bugs.webkit.org/show_bug.cgi?id=11217
1170         Cleanup svg coding style
1171
1172         Cleanup coding style in svg structure classes.
1173
1174         * ksvg2/svg/SVGDefsElement.cpp:
1175         (WebCore::SVGDefsElement::SVGDefsElement):
1176         * ksvg2/svg/SVGDefsElement.h:
1177         * ksvg2/svg/SVGDescElement.cpp:
1178         (WebCore::SVGDescElement::SVGDescElement):
1179         * ksvg2/svg/SVGDescElement.h:
1180         * ksvg2/svg/SVGDocument.cpp:
1181         * ksvg2/svg/SVGDocument.h:
1182         * ksvg2/svg/SVGElementInstance.cpp:
1183         (WebCore::SVGElementInstance::SVGElementInstance):
1184         (WebCore::SVGElementInstance::correspondingElement):
1185         (WebCore::SVGElementInstance::correspondingUseElement):
1186         (WebCore::SVGElementInstance::parentNode):
1187         (WebCore::SVGElementInstance::childNodes):
1188         (WebCore::SVGElementInstance::previousSibling):
1189         (WebCore::SVGElementInstance::nextSibling):
1190         (WebCore::SVGElementInstance::firstChild):
1191         (WebCore::SVGElementInstance::lastChild):
1192         * ksvg2/svg/SVGElementInstance.h:
1193         * ksvg2/svg/SVGElementInstanceList.cpp:
1194         * ksvg2/svg/SVGElementInstanceList.h:
1195         * ksvg2/svg/SVGGElement.cpp:
1196         (WebCore::SVGGElement::SVGGElement):
1197         (WebCore::SVGGElement::parseMappedAttribute):
1198         (WebCore::SVGDummyElement::SVGDummyElement):
1199         * ksvg2/svg/SVGGElement.h:
1200         (WebCore::SVGGElement::rendererIsNeeded):
1201         * ksvg2/svg/SVGImageElement.cpp:
1202         (WebCore::SVGImageElement::createRenderer):
1203         * ksvg2/svg/SVGImageElement.h:
1204         * ksvg2/svg/SVGSVGElement.cpp:
1205         (WebCore::SVGSVGElement::SVGSVGElement):
1206         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
1207         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
1208         (WebCore::SVGSVGElement::currentScale):
1209         (WebCore::SVGSVGElement::setCurrentScale):
1210         (WebCore::SVGSVGElement::currentTranslate):
1211         (WebCore::SVGSVGElement::parseMappedAttribute):
1212         (WebCore::SVGSVGElement::suspendRedraw):
1213         (WebCore::SVGSVGElement::unsuspendRedraw):
1214         (WebCore::SVGSVGElement::unsuspendRedrawAll):
1215         (WebCore::SVGSVGElement::forceRedraw):
1216         (WebCore::SVGSVGElement::getIntersectionList):
1217         (WebCore::SVGSVGElement::getEnclosureList):
1218         (WebCore::SVGSVGElement::checkIntersection):
1219         (WebCore::SVGSVGElement::checkEnclosure):
1220         (WebCore::SVGSVGElement::deselectAll):
1221         (WebCore::SVGSVGElement::createSVGLength):
1222         (WebCore::SVGSVGElement::createSVGAngle):
1223         (WebCore::SVGSVGElement::createSVGMatrix):
1224         (WebCore::SVGSVGElement::createSVGTransform):
1225         (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
1226         (WebCore::SVGSVGElement::getCTM):
1227         (WebCore::SVGSVGElement::getScreenCTM):
1228         (WebCore::SVGSVGElement::setCurrentTime):
1229         * ksvg2/svg/SVGSVGElement.h:
1230         (WebCore::SVGSVGElement::rendererIsNeeded):
1231         * ksvg2/svg/SVGSwitchElement.cpp:
1232         (WebCore::SVGSwitchElement::SVGSwitchElement):
1233         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
1234         * ksvg2/svg/SVGSwitchElement.h:
1235         (WebCore::SVGSwitchElement::rendererIsNeeded):
1236         * ksvg2/svg/SVGSymbolElement.cpp:
1237         (WebCore::SVGSymbolElement::SVGSymbolElement):
1238         (WebCore::SVGSymbolElement::parseMappedAttribute):
1239         * ksvg2/svg/SVGSymbolElement.h:
1240         (WebCore::SVGSymbolElement::shouldAttachChild):
1241         * ksvg2/svg/SVGTitleElement.cpp:
1242         (WebCore::SVGTitleElement::SVGTitleElement):
1243         * ksvg2/svg/SVGTitleElement.h:
1244         * ksvg2/svg/SVGUseElement.cpp:
1245         (WebCore::SVGUseElement::parseMappedAttribute):
1246         (WebCore::SVGUseElement::closeRenderer):
1247         * ksvg2/svg/SVGUseElement.h:
1248         (WebCore::SVGUseElement::rendererIsNeeded):
1249
1250 2006-10-12  Adele Peterson  <adele@apple.com>
1251
1252         Reviewed by Anders.
1253
1254         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11172
1255           REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
1256
1257          Test: fast/forms/listbox-width-change.html
1258
1259         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
1260           When the options change, call setNeedsLayoutAndMinMaxRecalc.
1261
1262 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
1263
1264         Reviewed by Oliver.
1265
1266         - moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies
1267
1268         * WebCore.xcodeproj/project.pbxproj:
1269         * bridge/mac/WebCoreFrameBridge.h:
1270         * bridge/mac/WebCoreFrameBridge.mm:
1271         (stringByCollapsingNonPrintingCharacters):
1272         (-[WebCoreFrameBridge setTitle:]):
1273         (-[WebCoreFrameBridge didFirstLayout]):
1274         (-[WebCoreFrameBridge notifyIconChanged:]):
1275         (-[WebCoreFrameBridge originalRequestURL]):
1276         (-[WebCoreFrameBridge isLoadTypeReload]):
1277         (-[WebCoreFrameBridge frameDetached]):
1278         (-[WebCoreFrameBridge tokenizerProcessedData]):
1279         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
1280         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
1281         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
1282         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
1283         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
1284         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
1285         (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
1286         (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
1287         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
1288         (-[WebCoreFrameBridge incomingReferrer]):
1289         (-[WebCoreFrameBridge isReloading]):
1290         (-[WebCoreFrameBridge handledOnloadEvents]):
1291         (-[WebCoreFrameBridge mainResourceURLResponse]):
1292         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
1293         * loader/mac/LoaderNSURLExtras.h:
1294         * loader/mac/LoaderNSURLRequestExtras.h: Added.
1295         * loader/mac/LoaderNSURLRequestExtras.m: Added.
1296         (isConditionalRequest):
1297         (setHTTPReferrer):
1298         * loader/mac/WebFrameLoader.mm:
1299         * loader/mac/WebSubresourceLoader.mm:
1300
1301 2006-10-12  Adele Peterson  <adele@apple.com>
1302
1303         RS by Geoff.
1304
1305         Renamed menuListIsDetaching to disconnectMenuList,
1306         uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.
1307         These names match similar methods in WebCore a little better.
1308
1309         * platform/FileChooser.h:
1310         * platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
1311         * platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]):
1312         (WebCore::FileChooser::disconnectUploadControl):
1313         * platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
1314         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1315         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):
1316
1317 2006-10-12  Adele Peterson  <adele@apple.com>
1318
1319         Reviewed by Maciej.
1320
1321         WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
1322
1323         Added private delegate method for clients that want access to a PopupMenu's NSMenu.
1324
1325         * bridge/mac/FrameMac.h:
1326         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
1327         * bridge/mac/WebCoreFrameBridge.h:
1328
1329         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.
1330
1331 2006-10-12  Adele Peterson  <adele@apple.com>
1332
1333         Reviewed by Alice.
1334
1335         - Fix for <rdar://problem/4707372>
1336           After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu
1337
1338         * platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
1339         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
1340         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up,
1341           in case the RenderMenuList goes away.  Also, checks the pointer to the menu list immediately afterwards.
1342
1343 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
1344
1345         Reviewed by Maciej.
1346
1347         Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
1348         document.open(); document.write(..); and NO document.close(). On the Qt platform this
1349         leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
1350         DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.
1351
1352         Hmpf, this took me nine hours to debug today.
1353         Result: Couldn't find the real fix, going for a workaround for now.
1354
1355         540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.
1356
1357         * platform/qt/FrameQt.cpp:
1358         (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
1359         * platform/qt/FrameQtClient.cpp:
1360         (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().
1361
1362 2006-10-12  Adam Roben  <aroben@apple.com>
1363
1364         Reviewed by Adele.
1365
1366         Move popup menu code out of rendering/ and into platform/.
1367         RenderPopupMenu becomes PopupMenu, the
1368         RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
1369         virtual methods go away, RenderTheme gets to stop worrying about popup
1370         menus, PopupMenu becomes ref-counted, and everyone becomes happy.
1371
1372         * WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
1373         * WebCore.xcodeproj/project.pbxproj: Ditto.
1374         * html/HTMLSelectElement.cpp: Remove unnecessary #include.
1375         * platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp.
1376         Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate
1377         from RenderMenuList::showPopup/hidePopup.
1378         (WebCore::PopupMenu::create): New static creation method to hand back a
1379         PassRefPtr<PopupMenu>.
1380         (WebCore::PopupMenu::addItems): This platform-independent method should
1381         be called by PopupMenu::populate when the platform-specific
1382         implementation is ready to receive the menu items. Fixed an ASSERT
1383         while I was at it.
1384         * platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more
1385         need for virtual methods.
1386         (WebCore::PopupMenu::wasClicked):
1387         (WebCore::PopupMenu::setWasClicked):
1388         (WebCore::PopupMenu::popupHandle):
1389         * platform/mac/PopupMenuMac.mm: Moved from
1390         rendering/RenderPopupMenuMac.mm. Much renaming ensues.
1391         (WebCore::PopupMenu::PopupMenu):
1392         (WebCore::PopupMenu::~PopupMenu):
1393         (WebCore::PopupMenu::clear):
1394         (WebCore::PopupMenu::populate):
1395         (WebCore::PopupMenu::show):
1396         (WebCore::PopupMenu::hide):
1397         (WebCore::PopupMenu::addSeparator):
1398         (WebCore::PopupMenu::addGroupLabel): Since we don't have our own
1399         RenderStyle anymore, just pick up the style from our RenderMenuList.
1400         (WebCore::PopupMenu::addOption): Ditto.
1401         * platform/win/TemporaryLinkStubs.cpp: Rename-fest.
1402         (PopupMenu::PopupMenu):
1403         (PopupMenu::~PopupMenu):
1404         (PopupMenu::clear):
1405         (PopupMenu::populate):
1406         (PopupMenu::show):
1407         (PopupMenu::hide):
1408         (PopupMenu::addSeparator):
1409         (PopupMenu::addGroupLabel):
1410         (PopupMenu::addOption):
1411         * rendering/RenderMenuList.cpp:
1412         (WebCore::RenderMenuList::~RenderMenuList):
1413         (WebCore::RenderMenuList::showPopup): Use nice new simple
1414         PopupMenu::create to make the popup.
1415         (WebCore::RenderMenuList::hidePopup):
1416         * rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a
1417         RenderPopupMenu*.
1418         (WebCore::RenderMenuList::popup):
1419         * rendering/RenderPopupMenu.cpp: Removed.
1420         * rendering/RenderPopupMenu.h: Removed.
1421         * rendering/RenderPopupMenuMac.h: Removed.
1422         * rendering/RenderPopupMenuMac.mm: Removed.
1423         * rendering/RenderPopupMenuWin.h: Removed.
1424         * rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
1425         * rendering/RenderTheme.h: Ditto.
1426         * rendering/RenderThemeMac.h: Ditto.
1427         * rendering/RenderThemeMac.mm: Ditto.
1428         * rendering/RenderThemeWin.cpp: Ditto.
1429         * rendering/RenderThemeWin.h: Ditto.
1430
1431 2006-10-12  Adele Peterson  <adele@apple.com>
1432
1433         Reviewed by Dave Harrison.
1434
1435         - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
1436
1437         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
1438         Make subtree layouts work for textareas as well as text fields.
1439
1440 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
1441
1442         Reviewed by MacDome.
1443
1444         Finally found a way to remove our begin() trickery in FrameQt.
1445         The (probably misnamed) Frame::setEncoding() function automatically
1446         calls Frame::receivedFirstData() which calls being on the working
1447         url, which has been passed to didOpenUrl(). Took me some hours
1448         to figure out that the missing charset logic, forced us to do hacks.
1449
1450         * platform/ResourceLoader.h:
1451         * platform/ResourceLoaderInternal.h:
1452         * platform/qt/FrameQt.cpp:
1453         (WebCore::FrameQt::tokenizerProcessedData):
1454         * platform/qt/FrameQt.h:
1455         * platform/qt/FrameQtClient.cpp:
1456         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1457         (WebCore::FrameQtClientDefault::openURL):
1458         (WebCore::FrameQtClientDefault::submitForm):
1459         (WebCore::FrameQtClientDefault::receivedData):
1460         (WebCore::FrameQtClientDefault::receivedAllData):
1461         * platform/qt/FrameQtClient.h:
1462         * platform/qt/ResourceLoaderManager.cpp:
1463         (WebCore::ResourceLoaderManager::slotData):
1464         (WebCore::ResourceLoaderManager::slotMimetype):
1465         (WebCore::ResourceLoaderManager::slotResult):
1466         (WebCore::ResourceLoaderManager::remove):
1467         * platform/qt/ResourceLoaderQt.cpp:
1468         (WebCore::ResourceLoader::retrieveCharset):
1469         (WebCore::ResourceLoader::extractCharsetFromHeaders):
1470
1471 2006-10-12  Adam Roben  <aroben@apple.com>
1472
1473         Reviewed by Hyatt.
1474
1475         Bandaid-ing a null-dereference crash until a real fix is made.
1476
1477         * page/FrameView.cpp:
1478         (WebCore::FrameView::windowClipRect):
1479
1480 2006-10-12  Rob Buis  <buis@kde.org>
1481
1482         Reviewed by Mitz.
1483
1484         http://bugs.webkit.org/show_bug.cgi?id=11217
1485         Cleanup svg coding style
1486
1487         Cleanup coding style in svg text classes.
1488
1489         * ksvg2/svg/SVGTRefElement.cpp:
1490         (WebCore::SVGTRefElement::SVGTRefElement):
1491         (WebCore::SVGTRefElement::updateReferencedText):
1492         (WebCore::SVGTRefElement::parseMappedAttribute):
1493         (WebCore::SVGTRefElement::childShouldCreateRenderer):
1494         (WebCore::SVGTRefElement::createRenderer):
1495         * ksvg2/svg/SVGTRefElement.h:
1496         (WebCore::SVGTRefElement::rendererIsNeeded):
1497         * ksvg2/svg/SVGTSpanElement.cpp:
1498         (WebCore::SVGTSpanElement::SVGTSpanElement):
1499         (WebCore::SVGTSpanElement::childShouldCreateRenderer):
1500         (WebCore::SVGTSpanElement::createRenderer):
1501         * ksvg2/svg/SVGTSpanElement.h:
1502         (WebCore::SVGTSpanElement::rendererIsNeeded):
1503         * ksvg2/svg/SVGTextContentElement.cpp:
1504         (WebCore::SVGTextContentElement::SVGTextContentElement):
1505         (WebCore::SVGTextContentElement::parseMappedAttribute):
1506         * ksvg2/svg/SVGTextContentElement.h:
1507         * ksvg2/svg/SVGTextElement.cpp:
1508         (WebCore::SVGTextElement::SVGTextElement):
1509         (WebCore::SVGTextElement::localMatrix):
1510         (WebCore::SVGTextElement::parseMappedAttribute):
1511         (WebCore::SVGTextElement::updateLocalTransform):
1512         (WebCore::SVGTextElement::nearestViewportElement):
1513         (WebCore::SVGTextElement::farthestViewportElement):
1514         (WebCore::SVGTextElement::getScreenCTM):
1515         (WebCore::SVGTextElement::getCTM):
1516         (WebCore::SVGTextElement::createRenderer):
1517         (WebCore::SVGTextElement::childShouldCreateRenderer):
1518         * ksvg2/svg/SVGTextElement.h:
1519         (WebCore::SVGTextElement::getTransformToElement):
1520         (WebCore::SVGTextElement::rendererIsNeeded):
1521         * ksvg2/svg/SVGTextPositioningElement.cpp:
1522         (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
1523         (WebCore::SVGTextPositioningElement::parseMappedAttribute):
1524         * ksvg2/svg/SVGTextPositioningElement.h:
1525
1526 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
1527
1528         Reviewed by Maciej.
1529
1530         Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.
1531
1532         * platform/qt/FrameQt.cpp:
1533         (WebCore::FrameQt::runJavaScriptAlert): Move runJavaScriptAlert functionality to FrameQtClientDefault.
1534         * platform/qt/FrameQtClient.cpp:
1535         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
1536         * platform/qt/FrameQtClient.h:
1537
1538 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
1539
1540         Reviewed by Eric.
1541
1542         - move m_responseMIMEType out of ResourceRequest, where it doesn't belong
1543
1544         * page/FramePrivate.h: Add m_responseMIMEType
1545         * page/ResourceRequest.h: Remove m_responseMIMEType
1546         * page/Frame.cpp:
1547         (WebCore::Frame::setResponseMIMEType): added
1548         (WebCore::Frame::responseMIMEType): added
1549         (WebCore::Frame::begin): get MIME type from the right place
1550         (WebCore::Frame::write): ditto
1551         * page/Frame.h:
1552         * bindings/js/kjs_window.cpp:
1553         (KJS::createNewWindow): updated to use new Frame methods
1554         (KJS::WindowFunc::callAsFunction): ditto
1555         * bridge/mac/WebCoreFrameBridge.mm:
1556         (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto
1557         (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
1558         * loader/PluginDocument.cpp:
1559         (WebCore::PluginTokenizer::createDocumentStructure): ditto
1560
1561 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
1562
1563         Reviewed by Eric.
1564
1565         <rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image
1566
1567         We really need some way to test loadHTMLString since it keeps breaking!
1568
1569         * loader/mac/WebFrameLoader.mm:
1570         (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.
1571
1572 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
1573
1574         Reviewed by Eric.
1575
1576         Fix Qt/Linux build.
1577
1578         * CMakeLists.txt:
1579         * platform/qt/FileChooserQt.cpp:
1580         (WebCore::FileChooser::create):
1581
1582 2006-10-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1583
1584         Reviewed by Maciej.
1585
1586         Update Gdk\Linux build for recent changes, based on Qt code
1587
1588         * platform/gdk/FrameGdk.cpp:
1589         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
1590         (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault):
1591         (WebCore::FrameGdkClientDefault::setFrame):
1592         (WebCore::FrameGdkClientDefault::openURL):
1593         (WebCore::FrameGdkClientDefault::submitForm):
1594         (WebCore::FrameGdkClientDefault::receivedResponse):
1595         (WebCore::FrameGdkClientDefault::receivedData):
1596         (WebCore::FrameGdkClientDefault::receivedAllData):
1597         (WebCore::FrameGdk::FrameGdk):
1598         (WebCore::FrameGdk::openURL):
1599         (WebCore::FrameGdk::submitForm):
1600         (WebCore::FrameGdk::urlSelected):
1601         * platform/gdk/FrameGdk.h:
1602         * platform/gdk/TemporaryLinkStubs.cpp:
1603         (FrameGdk::createJavaAppletWidget):
1604         (FileChooser::create):
1605
1606 2006-10-12  Dave Hyatt  <hyatt@apple.com>
1607
1608         Patch to add more clipping retrieval functionality for widgets.
1609
1610         Reviewed by mjs
1611
1612         * page/Frame.h:
1613         Remove windowResizerRect.  This is in the wrong place.
1614
1615         * page/FrameView.cpp:
1616         (WebCore::FrameView::windowClipRect):
1617         (WebCore::FrameView::windowClipRectForLayer):
1618         Break out windowClipRect into helper functions that can be called separately (to make
1619         it easier for scrollbars in overflow sections and list boxes to get to an enclosing
1620         layer and get the right clip.
1621
1622         * page/FrameView.h:
1623         Add the new windowClipRect helper methods.
1624
1625         * platform/ScrollBar.h:
1626         Add a new interface to ScrollbarClient so that scrollbars can hand back proper
1627         clip rects for themselves depending on how they are used.
1628
1629         * platform/ScrollView.h:
1630         Stub out methods for talking to a double buffer backing store on Win32.
1631
1632         * platform/Widget.h:
1633         Add the ability to query for invalidation suppression.
1634
1635         * rendering/RenderLayer.cpp:
1636         (WebCore::RenderLayer::windowClipRect):
1637         (WebCore::RenderLayer::paintOverflowControls):
1638         (WebCore::RenderLayer::calculateRects):
1639         (WebCore::RenderLayer::childrenClipRect):
1640         (WebCore::RenderLayer::selfClipRect):
1641         * rendering/RenderLayer.h:
1642         Enhance layers so that they can return either their foreground or background
1643         document clip rects.  Make sure a layer scrollbar can return a proper clip.
1644
1645         * rendering/RenderListBox.cpp:
1646         (WebCore::RenderListBox::windowClipRect):
1647         * rendering/RenderListBox.h:
1648         Make sure a list box scrollbar can return a proper clip.
1649
1650         * rendering/RenderObject.cpp:
1651         (WebCore::RenderObject::enclosingLayer):
1652         * rendering/RenderObject.h:
1653         Make enclosingLayer const.
1654
1655 2006-10-11  Darin Adler  <darin@apple.com>
1656
1657         Reviewed by John.
1658
1659         - some changes to prepare for converting more code to C++
1660
1661         * bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is
1662         self-sufficient.
1663
1664         * bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class.
1665         Needed since the class is used in this header (for some work I have not landed yet).
1666
1667         * loader/mac/LoaderNSURLExtras.h:
1668         * loader/mac/WebFormDataStream.h:
1669         Added extern "C" so this code can be used from C++.
1670
1671         * loader/mac/LoaderNSURLExtras.m:
1672         * loader/mac/WebDataProtocol.mm:
1673         * loader/mac/WebDocumentLoader.mm:
1674         * loader/mac/WebFormDataStream.m:
1675         * loader/mac/WebLoader.mm:
1676         * loader/mac/WebMainResourceLoader.mm:
1677         * loader/mac/WebNetscapePlugInStreamLoader.mm:
1678         * loader/mac/WebPolicyDecider.mm:
1679         * loader/mac/WebSubresourceLoader.mm:
1680         Added missing includes of config.h.
1681
1682 2006-10-11  John Sullivan  <sullivan@apple.com>
1683
1684         Darin wrote this code; we tested it; I give it the thumbs up.
1685
1686         - fixed regression from svn revision 16982 that was generating the wrong Obj-C classes
1687
1688         The hash table to look up an element class given a QualifiedName was
1689         not working at all.
1690
1691         * dom/QualifiedName.h:
1692         (WebCore::QualifiedName::impl):
1693         Added. This new accessor method for impl is needed if we want to use
1694         a QualifiedName as a hash table key without doing the kind of specialization
1695         we do for String. Maybe later we can do the String thing.
1696
1697         * bindings/objc/DOM.mm:
1698         (WebCore::addElementClass):
1699         Use QualifiedName.impl instead of the QualifiedName pointer itself.
1700         The QualifiedName pointer is *not* unique so almost nothing would be found
1701         in this hash table!
1702         (WebCore::elementClass):
1703         ditto
1704
1705 2006-10-11  Adam Roben  <aroben@apple.com>
1706
1707         Rubberstamped by Anders.
1708
1709         Clean up FileChooser::create and Icon::newIconForFile.
1710
1711         * WebCore.xcodeproj/project.pbxproj:
1712         * platform/mac/FileChooserMac.mm:
1713         (WebCore::FileChooser::create):
1714         * platform/mac/IconMac.mm:
1715         (WebCore::Icon::newIconForFile):
1716
1717 2006-10-11  Oliver Hunt  <oliver@apple.com>
1718
1719         Reviewed by Adam.
1720
1721         Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
1722         Corrects canvas tag to not throw JS exception when drawing
1723         zero sized rects, arcs, etc
1724
1725         * html/CanvasRenderingContext2D.cpp:
1726         (WebCore::CanvasRenderingContext2D::arcTo):
1727         (WebCore::CanvasRenderingContext2D::arc):
1728         (WebCore::CanvasRenderingContext2D::rect):
1729         (WebCore::CanvasRenderingContext2D::clearRect):
1730         (WebCore::CanvasRenderingContext2D::fillRect):
1731         (WebCore::CanvasRenderingContext2D::strokeRect):
1732
1733 2006-10-11  Rob Buis  <buis@kde.org>
1734
1735         Reviewed by Mitz.
1736
1737         http://bugs.webkit.org/show_bug.cgi?id=11221
1738         REGRESSION: iExploder crash due to style="cursor: url()"
1739
1740         Take better care of empty cursor lists.
1741
1742         Test: fast/css/invalid-cursor-property-crash.html
1743
1744         * css/cssparser.cpp:
1745         (WebCore::CSSParser::parseValue):
1746
1747 2006-10-11  Adam Roben  <aroben@apple.com>
1748
1749         Fixing Windows for real this time.
1750
1751         * platform/win/TemporaryLinkStubs.cpp:
1752         (FileChooser::create):
1753
1754 2006-10-11  Adam Roben  <aroben@apple.com>
1755
1756         Fix Windows build.
1757
1758         * platform/win/TemporaryLinkStubs.cpp:
1759         (FileChooser::create):
1760
1761 2006-10-11  Antti Koivisto  <koivisto@iki.fi>
1762
1763         Reviewed by Hyatt.
1764
1765         http://bugs.webkit.org/show_bug.cgi?id=4377
1766
1767         Respect css visibility semantics for layers too
1768
1769         * rendering/RenderContainer.cpp:
1770         (WebCore::RenderContainer::removeChildNode):
1771         (WebCore::RenderContainer::appendChildNode):
1772         (WebCore::RenderContainer::insertChildNode):
1773         * rendering/RenderLayer.cpp:
1774         (WebCore::RenderLayer::RenderLayer):
1775         (WebCore::RenderLayer::updateLayerPositions):
1776         (WebCore::RenderLayer::setHasVisibleContent):
1777         (WebCore::RenderLayer::dirtyVisibleContentStatus):
1778         (WebCore::RenderLayer::childVisibilityChanged):
1779         (WebCore::RenderLayer::dirtyVisibleDescendantStatus):
1780         (WebCore::RenderLayer::updateVisibilityStatus):
1781         (WebCore::RenderLayer::addChild):
1782         (WebCore::RenderLayer::removeChild):
1783         (WebCore::RenderLayer::updateZOrderLists):
1784         (WebCore::RenderLayer::collectLayers):
1785         * rendering/RenderLayer.h:
1786         (WebCore::RenderLayer::hasVisibleContent):
1787         * rendering/RenderObject.cpp:
1788         (WebCore::RenderObject::setStyle):
1789
1790 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1791
1792         Reviewed by Oliver.
1793
1794         - added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
1795
1796         * WebCore.xcodeproj/project.pbxproj:
1797         * platform/cf/RetainPtr.h: Added.
1798         (WTF::):
1799         (WTF::RetainPtr::RetainPtr):
1800         (WTF::RetainPtr::~RetainPtr):
1801         (WTF::RetainPtr::get):
1802         (WTF::RetainPtr::operator*):
1803         (WTF::RetainPtr::operator->):
1804         (WTF::RetainPtr::operator!):
1805         (WTF::RetainPtr::operator UnspecifiedBoolType):
1806         (WTF::::operator):
1807         (WTF::::swap):
1808         (WTF::swap):
1809         (WTF::operator==):
1810         (WTF::operator!=):
1811         (WTF::static_pointer_cast):
1812         (WTF::const_pointer_cast):
1813         (WTF::getPtr):
1814
1815         - use it in WidgetMac so it gets tested in at least one place
1816
1817         * platform/mac/WidgetMac.mm:
1818         (WebCore::Widget::Widget):
1819         (WebCore::Widget::~Widget):
1820         (WebCore::Widget::setEnabled):
1821         (WebCore::Widget::isEnabled):
1822         (WebCore::Widget::setCursor):
1823         (WebCore::Widget::getView):
1824         (WebCore::Widget::setView):
1825         (WebCore::Widget::getOuterView):
1826
1827 2006-10-10  Brady Eidson  <beidson@apple.com>
1828
1829         Reviewed by Maciej.
1830
1831         Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge
1832
1833         * bridge/mac/WebCoreFrameBridge.h:
1834         * bridge/mac/WebCoreFrameBridge.mm:
1835         (-[WebCoreFrameBridge initMainFrameWithPage:]):
1836         (-[WebCoreFrameBridge initSubframeWithOwnerElement:]):
1837         (-[WebCoreFrameBridge dealloc]):
1838         (-[WebCoreFrameBridge close]):
1839         (-[WebCoreFrameBridge setFrameLoaderClient:]):
1840         (-[WebCoreFrameBridge frameLoader]):
1841         * loader/mac/WebFrameLoader.h:
1842         * loader/mac/WebFrameLoader.mm:
1843         (-[WebFrameLoader initWithFrameBridge:]):
1844         (-[WebFrameLoader setFrameLoaderClient:]):
1845
1846 2006-10-10  Adam Roben  <aroben@apple.com>
1847
1848         Reviewed by Oliver.
1849
1850         Make FileChooser ref-counted.
1851
1852         * platform/FileChooser.h:
1853         * platform/mac/FileChooserMac.mm:
1854         (WebCore::FileChooser::create):
1855         * rendering/RenderFileUploadControl.cpp:
1856         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
1857         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1858         * rendering/RenderFileUploadControl.h:
1859
1860 2006-10-10  Sam Weinig  <sam.weinig@gmail.com>
1861
1862         Reviewed by Tim H.
1863
1864         Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
1865         Even More auto-generated Objective-C DOM bindings changes
1866
1867         - Auto-generate DOMSVGPathElement.
1868
1869         - Auto-generate the internal interfaces even for classes that have
1870           custom internal implementations.  Change IDL property from ObjCNoInternal
1871           to ObjCCustomInternalImpl to indicate the change.
1872
1873         - Add SVG classes to DOMNode and DOMEvent internal interfaces.
1874
1875         - Add isSVGZoomEvent() method to Event class to match other Event subclasses
1876           and make DOM binding possible.
1877
1878         - Assorted cleanups.
1879
1880         * DerivedSources.make:
1881         * WebCore.xcodeproj/project.pbxproj:
1882         * bindings/objc/DOM.mm:
1883         (WebCore::addElementClass):
1884         (WebCore::createElementClassMap):
1885         (WebCore::elementClass):
1886         (-[DOMNode description]):
1887         (+[DOMNode _nodeWith:WebCore::]):
1888         (-[DOMNode addEventListener:listener:useCapture:]):
1889         (-[DOMNode removeEventListener:listener:useCapture:]):
1890         (-[DOMElement _NPObject]):
1891         (WebCore::ObjCEventListener::handleEvent):
1892         * bindings/objc/DOMEvents.mm:
1893         (+[DOMEvent _eventWith:WebCore::]):
1894         * bindings/objc/DOMInternal.h:
1895         * bindings/objc/DOMRGBColor.mm:
1896         (-[DOMRGBColor WebCore::]):
1897         * bindings/objc/DOMSVGPathSegInternal.h: Removed.
1898         * bindings/scripts/CodeGeneratorObjC.pm:
1899         * css/CSSRule.idl:
1900         * css/CSSValue.idl:
1901         * css/StyleSheet.idl:
1902         * dom/Event.cpp:
1903         (WebCore::Event::isSVGZoomEvent):
1904         * dom/Event.h:
1905         * dom/Event.idl:
1906         * dom/Node.idl:
1907         * ksvg2/events/SVGZoomEvent.cpp:
1908         (WebCore::SVGZoomEvent::isSVGZoomEvent):
1909         * ksvg2/events/SVGZoomEvent.h:
1910         * ksvg2/svg/SVGAnimatedAngle.idl:
1911         * ksvg2/svg/SVGCircleElement.idl:
1912         * ksvg2/svg/SVGClipPathElement.idl:
1913         * ksvg2/svg/SVGPathElement.idl:
1914         * ksvg2/svg/SVGPathSeg.idl:
1915
1916 2006-10-10  Oliver Hunt  <oliver@apple.com>
1917
1918         rubber stamped by Anders.
1919
1920         More buildbot bustage
1921
1922         * kcanvas/SVGInlineFlowBox.cpp:
1923         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1924
1925 2006-10-10  Oliver Hunt  <oliver@apple.com>
1926
1927         Reviewed by Anders
1928
1929         Unbreak build bots
1930
1931         * dom/Text.cpp:
1932         * kcanvas/RenderSVGText.cpp:
1933         (WebCore::RenderSVGText::layout):
1934         * kcanvas/SVGInlineFlowBox.cpp:
1935         (WebCore::placePositionedBoxesHorizontally):
1936         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1937
1938 2006-10-10  Oliver Hunt  <oliver@apple.com>
1939
1940         Reviewed by hyatt.
1941
1942         Fixes bugs #6423, #6559, #10380 and #10839
1943
1944         * WebCore.xcodeproj/project.pbxproj:
1945         * css/svg.css:
1946         * dom/Text.cpp:
1947         (WebCore::Text::createRenderer):
1948         * kcanvas/RenderSVGInline.cpp: Added.
1949         (WebCore::RenderSVGInline::RenderSVGInline):
1950         (WebCore::RenderSVGInline::createInlineBox):
1951         * kcanvas/RenderSVGInline.h: Added.
1952         (WebCore::RenderSVGInline::renderName):
1953         (WebCore::RenderSVGInline::requiresLayer):
1954         * kcanvas/RenderSVGInlineText.cpp: Added.
1955         (WebCore::RenderSVGInlineText::RenderSVGInlineText):
1956         (WebCore::RenderSVGInlineText::absoluteRects):
1957         (WebCore::RenderSVGInlineText::selectionRect):
1958         * kcanvas/RenderSVGInlineText.h: Added.
1959         (WebCore::RenderSVGInlineText::renderName):
1960         (WebCore::RenderSVGInlineText::requiresLayer):
1961         * kcanvas/RenderSVGTSpan.cpp: Added.
1962         (WebCore::RenderSVGTSpan::RenderSVGTSpan):
1963         (WebCore::RenderSVGTSpan::absoluteRects):
1964         * kcanvas/RenderSVGTSpan.h: Added.
1965         (WebCore::RenderSVGTSpan::renderName):
1966         * kcanvas/RenderSVGText.cpp:
1967         (WebCore::RenderSVGText::RenderSVGText):
1968         (WebCore::RenderSVGText::computeAbsoluteRepaintRect):
1969         (WebCore::RenderSVGText::layout):
1970         (WebCore::RenderSVGText::createInlineBox):
1971         (WebCore::RenderSVGText::nodeAtPoint):
1972         (WebCore::RenderSVGText::absoluteRects):
1973         (WebCore::RenderSVGText::paint):
1974         (WebCore::RenderSVGText::relativeBBox):
1975         * kcanvas/RenderSVGText.h:
1976         (WebCore::RenderSVGText::renderName):
1977         * kcanvas/SVGInlineFlowBox.cpp: Added.
1978         (WebCore::SVGInlineFlowBox::paint):
1979         (WebCore::SVGInlineFlowBox::placeBoxesHorizontally):
1980         (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
1981         (WebCore::paintSVGInlineFlow):
1982         (WebCore::translateBox):
1983         (WebCore::placePositionedBoxesHorizontally):
1984         (WebCore::placeSVGFlowHorizontally):
1985         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1986         (WebCore::placeSVGFlowVertically):
1987         * kcanvas/SVGInlineFlowBox.h: Added.
1988         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
1989         * kcanvas/SVGRootInlineBox.cpp: Added.
1990         (WebCore::SVGRootInlineBox::paint):
1991         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
1992         (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
1993         * kcanvas/SVGRootInlineBox.h: Added.
1994         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
1995         * ksvg2/svg/SVGTRefElement.cpp:
1996         (SVGTRefElement::createRenderer):
1997         * ksvg2/svg/SVGTSpanElement.cpp:
1998         (SVGTSpanElement::createRenderer):
1999         * rendering/InlineFlowBox.h:
2000
2001 2006-10-10  Adam Roben  <aroben@apple.com>
2002
2003         Reviewed by Adele.
2004
2005         Improve popup menu behavior.
2006
2007         * html/HTMLSelectElement.cpp:
2008         (WebCore::HTMLSelectElement::HTMLSelectElement): Cache
2009         m_lastOnChangeIndex so we know when to fire onChange.
2010         (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to
2011         specify whether we should fire onChange.
2012         (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur.
2013         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire
2014         onChange when using the Enter key to change the selection.
2015         * html/HTMLSelectElement.h:
2016         * rendering/RenderMenuList.cpp:
2017         (WebCore::RenderMenuList::updateFromElement): Extract setText logic
2018         into its own method.
2019         (WebCore::RenderMenuList::setTextFromOption): New method.
2020         (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call
2021         onChange instead of calling it directly here.
2022         * rendering/RenderMenuList.h:
2023
2024 2006-10-10  Adele Peterson  <adele@apple.com>
2025
2026         Reviewed by Beth.
2027
2028
2029         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text>
2030           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
2031
2032         Moved autoscroll code to the Frame class
2033
2034         * bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
2035         * bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags.  Moved autoscroll code to Frame::handleMouseMoveEvent.
2036         (WebCore::FrameMac::FrameMac):
2037         (WebCore::FrameMac::handleMousePressEvent):
2038         (WebCore::FrameMac::eventMayStartDrag):
2039         (WebCore::FrameMac::handleMouseMoveEvent):
2040         (WebCore::FrameMac::mouseDown):
2041
2042         * bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us.
2043         Now we scroll our views in WebCore.
2044
2045         * page/Frame.cpp:
2046         (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag.
2047         (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate.  Moved from FrameMac.
2048         (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too.
2049         (WebCore::Frame::mouseDownMayStartAutoscroll): Added.
2050         (WebCore::Frame::setMouseDownMayStartAutoscroll): Added.
2051         (WebCore::Frame::mouseDownMayStartDrag): Added.
2052         (WebCore::Frame::setMouseDownMayStartDrag): Added.
2053         (WebCore::Frame::autoscrollRenderer): Added
2054         (WebCore::Frame::setAutoscrollRenderer): Added.
2055         (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter.
2056         (WebCore::Frame::autoscrollTimerFired): ditto.
2057         (WebCore::Frame::stopAutoscrollTimer): ditto.
2058         * page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.
2059
2060         * page/FramePrivate.h:
2061         (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags.  Moved from FrameMac.
2062
2063         * page/FrameView.cpp: Store the current mouse position in window coordinates.  The callers can convert to their own coordinate space.
2064         (WebCore::FrameView::handleMousePressEvent):
2065         (WebCore::FrameView::handleMouseDoubleClickEvent):
2066         (WebCore::FrameView::handleMouseMoveEvent):
2067         (WebCore::FrameView::handleMouseReleaseEvent):
2068
2069         * rendering/RenderLayer.cpp:
2070         (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection).
2071          We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.
2072
2073         * rendering/RenderListBox.cpp:
2074         (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.
2075
2076         * rendering/RenderObject.cpp:
2077         (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too)
2078         (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.
2079
2080 2006-10-10  Darin Adler  <darin@apple.com>
2081
2082         Rubber stamped by Maciej.
2083
2084         - convert many of the loader source files to Objective-C++ to prepare
2085           to convert some of them to C++
2086
2087         * WebCore.xcodeproj/project.pbxproj:
2088         * loader/mac/WebDataProtocol.m: Removed.
2089         * loader/mac/WebDocumentLoader.m: Removed.
2090         * loader/mac/WebFormState.m: Removed.
2091         * loader/mac/WebFrameLoader.m: Removed.
2092         * loader/mac/WebLoader.m: Removed.
2093         * loader/mac/WebMainResourceLoader.m: Removed.
2094         * loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
2095         * loader/mac/WebPolicyDecider.m: Removed.
2096         * loader/mac/WebSubresourceLoader.m: Removed.
2097         * loader/mac/WebDataProtocol.mm: Added.
2098         * loader/mac/WebDocumentLoader.mm: Added.
2099         * loader/mac/WebFormState.mm: Added.
2100         * loader/mac/WebFrameLoader.mm: Added.
2101         * loader/mac/WebLoader.mm: Added.
2102         * loader/mac/WebMainResourceLoader.mm: Added.
2103         * loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
2104         * loader/mac/WebPolicyDecider.mm: Added.
2105         * loader/mac/WebSubresourceLoader.mm: Added.
2106
2107 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2108
2109         Reviewed by Mitz.
2110
2111         - fixed REGRESSION (r16960): crash on navigating to site
2112         http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE
2113
2114         * loader/mac/WebFrameLoader.m:
2115         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2116         Add back a mistakenly removed retain.
2117
2118 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2119
2120         Not reviewed, build fix.
2121
2122         - fixed release build
2123
2124         * WebCore.xcodeproj/project.pbxproj:
2125
2126 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2127
2128         Rubber stamped by Eric.
2129
2130         - moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile
2131
2132         * WebCore.exp:
2133         * WebCore.xcodeproj/project.pbxproj:
2134         * loader/mac/LoaderNSURLExtras.m: Added.
2135         * loader/mac/WebDataProtocol.m: Added.
2136         * loader/mac/WebDocumentLoader.m: Added.
2137         * loader/mac/WebFormDataStream.m: Added.
2138         * loader/mac/WebFrameLoader.m: Added.
2139         * loader/mac/WebLoader.m: Added.
2140         (-[NSURLProtocol didReceiveResponse:]):
2141         (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
2142         * loader/mac/WebMainResourceLoader.m: Added.
2143         (-[WebMainResourceLoader didReceiveResponse:]):
2144         * loader/mac/WebPolicyDecider.m: Added.
2145         * loader/mac/WebSubresourceLoader.h: Added.
2146         * loader/mac/WebSubresourceLoader.m: Added.
2147
2148 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2149
2150         Reviewed by Oliver (sort of?)
2151
2152         - WebCore part of moving down NSURL extras
2153
2154         * WebCore.exp:
2155         * platform/mac/WebCoreSystemInterface.h:
2156         * platform/mac/WebCoreSystemInterface.mm:
2157
2158 2006-10-09  Rob Buis  <buis@kde.org>
2159
2160         Reviewed by Mitz.
2161
2162         http://bugs.webkit.org/show_bug.cgi?id=11217
2163         Cleanup svg coding style
2164
2165         Cleanup coding style in svg animation classes.
2166
2167         * ksvg2/svg/SVGAnimateColorElement.cpp:
2168         (WebCore::SVGAnimateColorElement::handleTimerEvent):
2169         * ksvg2/svg/SVGAnimateElement.cpp:
2170         (WebCore::SVGAnimateElement::SVGAnimateElement):
2171         (WebCore::SVGAnimateElement::handleTimerEvent):
2172         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2173         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
2174         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
2175         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2176         (WebCore::SVGAnimateTransformElement::parseTransformValue):
2177         (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):
2178         (WebCore::SVGAnimateTransformElement::initialMatrix):
2179         (WebCore::SVGAnimateTransformElement::transformMatrix):
2180         * ksvg2/svg/SVGAnimateTransformElement.h:
2181         * ksvg2/svg/SVGAnimatedPathData.cpp:
2182         * ksvg2/svg/SVGAnimatedPathData.h:
2183         * ksvg2/svg/SVGAnimatedPoints.cpp:
2184         * ksvg2/svg/SVGAnimatedPoints.h:
2185         * ksvg2/svg/SVGAnimationElement.cpp:
2186         (WebCore::SVGAnimationElement::targetElement):
2187
2188 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2189
2190         Reviewed by Oliver.
2191
2192         - added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion
2193
2194         * bridge/mac/WebCoreFrameBridge.h:
2195         * bridge/mac/WebCoreFrameBridge.mm:
2196         (-[WebCoreFrameBridge isMainFrame]):
2197
2198 2006-10-09  Adam Roben  <aroben@apple.com>
2199
2200         Backing out accidental commit.
2201
2202         * page/Frame.cpp:
2203         (WebCore::Frame::finishedParsing):
2204
2205 2006-10-09  Adam Roben  <aroben@apple.com>
2206
2207         Reviewed by Darin.
2208
2209         Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
2210         this could cause recursive calls to the destructor. RefPtr now also
2211         inherits from Noncopyable.
2212
2213         * dom/NodeFilter.h:
2214         * dom/Traversal.h:
2215         * page/DOMWindow.h:
2216         * page/Frame.cpp:
2217         (WebCore::Frame::finishedParsing):
2218         * page/Frame.h:
2219         * page/Plugin.h:
2220         * platform/FontFallbackList.h:
2221         * platform/Icon.h:
2222         * platform/Shared.h:
2223         (WebCore::Shared::Shared):
2224         (WebCore::Shared::ref):
2225         (WebCore::Shared::deref):
2226         (WebCore::Shared::hasOneRef):
2227         (WebCore::Shared::refCount):
2228         * platform/StringImpl.h:
2229
2230 2006-10-09  Oliver Hunt <ohunt@apple.com>
2231
2232         Reviewed by Anders.
2233
2234         Correcting ifdef's
2235
2236         * html/CanvasGradient.cpp:
2237         (WebCore::CanvasGradient::CanvasGradient):
2238         (WebCore::CanvasGradient::~CanvasGradient):
2239         (WebCore::CanvasGradient::addColorStop):
2240         * html/CanvasGradient.h:
2241         * html/CanvasPattern.cpp:
2242         (WebCore::CanvasPattern::CanvasPattern):
2243         (WebCore::CanvasPattern::~CanvasPattern):
2244         * html/CanvasPattern.h:
2245         * html/CanvasRenderingContext2D.cpp:
2246         (WebCore::CanvasRenderingContext2D::fill):
2247         (WebCore::CanvasRenderingContext2D::stroke):
2248         (WebCore::CanvasRenderingContext2D::fillRect):
2249         (WebCore::CanvasRenderingContext2D::setShadow):
2250         (WebCore::CanvasRenderingContext2D::applyShadow):
2251         (WebCore::CanvasRenderingContext2D::drawImage):
2252         (WebCore::CanvasRenderingContext2D::createPattern):
2253         (WebCore::CanvasRenderingContext2D::applyStrokePattern):
2254         (WebCore::CanvasRenderingContext2D::applyFillPattern):
2255         * html/CanvasRenderingContext2D.h:
2256         * html/CanvasStyle.cpp:
2257         (WebCore::CanvasStyle::applyStrokeColor):
2258         (WebCore::CanvasStyle::applyFillColor):
2259         * html/HTMLCanvasElement.cpp:
2260         (WebCore::HTMLCanvasElement::paint):
2261         (WebCore::HTMLCanvasElement::createDrawingContext):
2262         * html/HTMLCanvasElement.h:
2263
2264 2006-10-09  Adam Roben  <aroben@apple.com>
2265
2266         Reviewed by Maciej.
2267
2268         Fix a possible recursive destructor call.
2269
2270         * page/Frame.cpp:
2271         (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor.
2272         (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if
2273         we're already being destroyed.
2274
2275 2006-10-09  Sam Weinig  <sam.weinig@gmail.com>
2276
2277         Reviewed by Tim H.
2278
2279         Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
2280         Assorted Objective-C bindings changes
2281
2282         - Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath,
2283           DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel,
2284           DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel,
2285           DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel,
2286           DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel,
2287           DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs,
2288           DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel,
2289           DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel,
2290           DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.
2291
2292         - Auto-generate absoluteImageURL method for DOMHTMLInputElement and
2293           DOMHTMLObjectElement.
2294
2295         - Auto-generate the internal methods for classes with ivars (notably
2296           DOMNodeIterator and DOMTreeWalker)
2297
2298         - Put more methods in the WebCore namespace and factor out the
2299           displayString method into DOMInternal.h as done by Darin in his
2300           patch for http://bugs.webkit.org/show_bug.cgi?id=11219.
2301
2302         * DerivedSources.make:
2303         * WebCore.xcodeproj/project.pbxproj:
2304         * bindings/objc/DOM.mm:
2305         (-[DOMNode _initWithNode:WebCore::]):
2306         (+[DOMNode _nodeWith:WebCore::]):
2307         (-[DOMNode addEventListener:listener:useCapture:]):
2308         (-[DOMNode removeEventListener:listener:useCapture:]):
2309         (-[DOMNode dispatchEvent:]):
2310         (-[DOMElement _imageTIFFRepresentation]):
2311         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
2312         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
2313         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2314         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2315         * bindings/objc/DOMCSS.mm:
2316         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2317         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
2318         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
2319         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
2320         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
2321         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2322         * bindings/objc/DOMEvents.mm:
2323         (-[DOMEvent _initWithEvent:WebCore::]):
2324         (+[DOMEvent _eventWith:WebCore::]):
2325         * bindings/objc/DOMExtensions.h:
2326         * bindings/objc/DOMHTML.mm:
2327         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
2328         * bindings/objc/DOMInternal.h:
2329         (-[DOMNodeFilter WebCore::]):
2330         * bindings/objc/DOMInternal.mm:
2331         (-[WebScriptObject _init]):
2332         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2333         (WebCore::displayString):
2334         * bindings/objc/DOMObject.mm:
2335         (-[DOMObject dealloc]):
2336         (-[DOMObject finalize]):
2337         * bindings/objc/DOMRGBColor.mm:
2338         (-[DOMRGBColor dealloc]):
2339         (-[DOMRGBColor finalize]):
2340         (-[DOMRGBColor color]):
2341         (-[DOMRGBColor _initWithRGB:WebCore::]):
2342         (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
2343         * bindings/objc/DOMSVG.h:
2344         * bindings/objc/DOMSVGPathSegInternal.h: Added.
2345         * bindings/objc/DOMSVGPathSegInternal.mm: Added.
2346         (-[DOMSVGPathSeg WebCore::]):
2347         (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]):
2348         (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
2349         * bindings/objc/DOMXPath.mm:
2350         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
2351         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
2352         * bindings/objc/PublicDOMInterfaces.h:
2353         * bindings/scripts/CodeGeneratorObjC.pm:
2354         * dom/NodeIterator.idl:
2355         * dom/TreeWalker.idl:
2356         * html/HTMLInputElement.idl:
2357         * html/HTMLObjectElement.idl:
2358         * ksvg2/svg/SVGDocument.idl:
2359         * ksvg2/svg/SVGElement.idl:
2360         * ksvg2/svg/SVGPathSeg.idl:
2361         * ksvg2/svg/SVGPathSegArcAbs.idl:
2362         * ksvg2/svg/SVGPathSegArcRel.idl:
2363         * ksvg2/svg/SVGPathSegClosePath.idl:
2364         * ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
2365         * ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
2366         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
2367         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
2368         * ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
2369         * ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
2370         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
2371         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
2372         * ksvg2/svg/SVGPathSegLinetoAbs.idl:
2373         * ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
2374         * ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
2375         * ksvg2/svg/SVGPathSegLinetoRel.idl:
2376         * ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
2377         * ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
2378         * ksvg2/svg/SVGPathSegMovetoAbs.idl:
2379         * ksvg2/svg/SVGPathSegMovetoRel.idl:
2380
2381 2006-10-09  Don Gibson  <dgibson77@gmail.com>
2382
2383         Unreviewed build fix.
2384
2385         Fix windows build bustage.
2386
2387         * platform/win/TemporaryLinkStubs.cpp:
2388
2389 2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2390
2391         Reviewed by Geoff.
2392
2393         Fix memory leaks discovered via valgrind. Gdk build fixes.
2394
2395         * Projects/gdk/webcore-gdk.bkl:
2396         * make-generated-sources.sh:
2397         * platform/cairo/ImageCairo.cpp:
2398         (WebCore::Image::draw):
2399         * platform/gdk/FrameGdk.cpp:
2400         (WebCore::FrameGdk::handleGdkEvent):
2401         * platform/gdk/FrameGdk.h:
2402         * platform/gdk/PlatformScrollBar.h:
2403         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
2404         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
2405
2406 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
2407
2408         Reviewed by Beth.
2409
2410         Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.
2411
2412         * platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly
2413         (WebCore::GlyphMap::fillPage):
2414
2415 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
2416
2417         Unreviewed build fix.
2418
2419         Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.
2420
2421         * platform/qt/FrameQt.cpp:
2422         (WebCore::FrameQt::createJavaAppletWidget):
2423         * platform/qt/FrameQt.h:
2424         * platform/qt/TemporaryLinkStubs.cpp:
2425
2426 2006-10-09  Brady Eidson  <beidson@apple.com>
2427
2428         Reviewed by Maciej
2429
2430         Tiny changes to help reorganize WebFrameLoader code in WebKit
2431
2432         * bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
2433         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2434         (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side
2435
2436 2006-10-09  Adam Roben  <aroben@apple.com>
2437
2438         Reviewed by Adele.
2439
2440         Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
2441         already called frome ~FrameMac.
2442
2443         * page/Frame.cpp:
2444         (WebCore::Frame::~Frame):
2445
2446 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
2447
2448         * bridge/win/FrameWin.h:
2449         Add function declaration.
2450
2451 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
2452
2453         * platform/win/TemporaryLinkStubs.cpp:
2454         (FrameWin::createJavaAppletWidget):
2455         Try fixing the Win32 build.
2456
2457 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
2458
2459         Reviewed by Adam.
2460
2461         Move applet widget creation to Frame and get rid of JavaAppletWidget.
2462         * WebCore.xcodeproj/project.pbxproj:
2463         * bridge/JavaAppletWidget.h: Removed.
2464         * bridge/mac/FrameMac.h:
2465         * bridge/mac/FrameMac.mm:
2466         (WebCore::FrameMac::createJavaAppletWidget):
2467         * bridge/mac/JavaAppletWidget.mm: Removed.
2468         * page/Frame.h:
2469         * rendering/RenderApplet.cpp:
2470         (WebCore::RenderApplet::createWidgetIfNecessary):
2471
2472 2006-10-09  Mitz Pettel  <mitz@webkit.org>
2473
2474         Reviewed by Darin.
2475
2476         - http://bugs.webkit.org/show_bug.cgi?id=11220
2477           Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276
2478
2479         Subversion does not support resource forks and HFS metadata, so
2480         the resources for this test need to be on a disk image.
2481
2482         * manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
2483         * manual-tests/resources/plain-text-paste.dmg: Added.
2484         * manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
2485         * manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
2486         * manual-tests/resources/plain-text-paste/._4.txt: Removed.
2487         * manual-tests/resources/plain-text-paste/._5.webloc: Removed.
2488         * manual-tests/resources/plain-text-paste/1.textClipping: Removed.
2489         * manual-tests/resources/plain-text-paste/2.textClipping: Removed.
2490         * manual-tests/resources/plain-text-paste/3.gif: Removed.
2491         * manual-tests/resources/plain-text-paste/4.txt: Removed.
2492         * manual-tests/resources/plain-text-paste/5.webloc: Removed.
2493
2494 2006-10-09  Rob Buis  <buis@kde.org>
2495
2496         Reviewed by Darin.
2497
2498         http://bugs.webkit.org/show_bug.cgi?id=11217
2499         Cleanup svg coding style
2500
2501         Cleanup coding style in filter classes.
2502
2503         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2504         (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
2505         (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
2506         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
2507         * ksvg2/svg/SVGFEBlendElement.cpp:
2508         (WebCore::SVGFEBlendElement::SVGFEBlendElement):
2509         (WebCore::SVGFEBlendElement::parseMappedAttribute):
2510         (WebCore::SVGFEBlendElement::filterEffect):
2511         * ksvg2/svg/SVGFEBlendElement.h:
2512         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2513         (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
2514         (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
2515         (WebCore::SVGFEColorMatrixElement::filterEffect):
2516         * ksvg2/svg/SVGFEColorMatrixElement.h:
2517         * ksvg2/svg/SVGFECompositeElement.cpp:
2518         (WebCore::SVGFECompositeElement::parseMappedAttribute):
2519         * ksvg2/svg/SVGFECompositeElement.h:
2520         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2521         (WebCore::SVGFEDisplacementMapElement::stringToChannel):
2522         * ksvg2/svg/SVGFEDisplacementMapElement.h:
2523         * ksvg2/svg/SVGFEFloodElement.cpp:
2524         (WebCore::SVGFEFloodElement::filterEffect):
2525         * ksvg2/svg/SVGFEFuncAElement.cpp:
2526         (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
2527         * ksvg2/svg/SVGFEFuncBElement.cpp:
2528         (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
2529         * ksvg2/svg/SVGFEFuncGElement.cpp:
2530         (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
2531         * ksvg2/svg/SVGFEFuncRElement.cpp:
2532         (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
2533         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2534         (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
2535         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
2536         (WebCore::SVGFEGaussianBlurElement::filterEffect):
2537         * ksvg2/svg/SVGFEGaussianBlurElement.h:
2538         * ksvg2/svg/SVGFELightElement.cpp:
2539         (WebCore::SVGFELightElement::SVGFELightElement):
2540         (WebCore::SVGFELightElement::parseMappedAttribute):
2541         * ksvg2/svg/SVGFELightElement.h:
2542         * ksvg2/svg/SVGFEMergeElement.cpp:
2543         (WebCore::SVGFEMergeElement::SVGFEMergeElement):
2544
2545 2006-10-09  Rob Buis  <buis@kde.org>
2546
2547         Reviewed by olliej.
2548
2549         http://bugs.webkit.org/show_bug.cgi?id=11217
2550         Cleanup svg coding style
2551
2552         Cleanup coding style in SVGPath* classes.
2553
2554         * ksvg2/svg/SVGPathElement.cpp:
2555         (WebCore::SVGPathElement::SVGPathElement):
2556         (WebCore::SVGPathElement::getPointAtLength):
2557         (WebCore::SVGPathElement::createSVGPathSegClosePath):
2558         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
2559         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
2560         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
2561         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
2562         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
2563         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
2564         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
2565         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
2566         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
2567         (WebCore::SVGPathElement::createSVGPathSegArcRel):
2568         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
2569         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
2570         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
2571         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
2572         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
2573         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
2574         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
2575         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
2576         (WebCore::SVGPathElement::svgMoveTo):
2577         (WebCore::SVGPathElement::svgLineTo):
2578         (WebCore::SVGPathElement::svgLineToHorizontal):
2579         (WebCore::SVGPathElement::svgLineToVertical):
2580         (WebCore::SVGPathElement::svgCurveToCubic):
2581         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
2582         (WebCore::SVGPathElement::svgCurveToQuadratic):
2583         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
2584         (WebCore::SVGPathElement::svgArcTo):
2585         (WebCore::SVGPathElement::parseMappedAttribute):
2586         (WebCore::SVGPathElement::pathSegList):
2587         (WebCore::SVGPathElement::normalizedPathSegList):
2588         (WebCore::SVGPathElement::animatedPathSegList):
2589         (WebCore::SVGPathElement::animatedNormalizedPathSegList):
2590         (WebCore::SVGPathElement::toPathData):
2591         * ksvg2/svg/SVGPathElement.h:
2592         (WebCore::SVGPathElement::rendererIsNeeded):
2593         * ksvg2/svg/SVGPathSeg.h:
2594         * ksvg2/svg/SVGPathSegArc.cpp:
2595
2596 2006-10-09  Rob Buis  <buis@kde.org>
2597
2598         Reviewed by aroben.
2599
2600         http://bugs.webkit.org/show_bug.cgi?id=11217
2601         Cleanup svg coding style
2602
2603         Cleanup coding style in svg shape classes.
2604
2605         * ksvg2/svg/SVGCircleElement.cpp:
2606         (WebCore::SVGCircleElement::SVGCircleElement):
2607         (WebCore::SVGCircleElement::parseMappedAttribute):
2608         (WebCore::SVGCircleElement::pushAttributeContext):
2609         * ksvg2/svg/SVGCircleElement.h:
2610         (WebCore::SVGCircleElement::rendererIsNeeded):
2611         * ksvg2/svg/SVGEllipseElement.cpp:
2612         * ksvg2/svg/SVGEllipseElement.h:
2613         (WebCore::SVGEllipseElement::rendererIsNeeded):
2614         * ksvg2/svg/SVGLineElement.cpp:
2615         (WebCore::SVGLineElement::parseMappedAttribute):
2616         (WebCore::SVGLineElement::pushAttributeContext):
2617         * ksvg2/svg/SVGLineElement.h:
2618         (WebCore::SVGLineElement::rendererIsNeeded):
2619         * ksvg2/svg/SVGPolyElement.cpp:
2620         (WebCore::SVGPolyElement::SVGPolyElement):
2621         (WebCore::SVGPolyElement::points):
2622         (WebCore::SVGPolyElement::animatedPoints):
2623         (WebCore::SVGPolyElement::parseMappedAttribute):
2624         (WebCore::SVGPolyElement::notifyAttributeChange):
2625         * ksvg2/svg/SVGPolyElement.h:
2626         (WebCore::SVGPolyElement::rendererIsNeeded):
2627         * ksvg2/svg/SVGPolygonElement.cpp:
2628         (WebCore::SVGPolygonElement::SVGPolygonElement):
2629         (WebCore::SVGPolygonElement::toPathData):
2630         * ksvg2/svg/SVGPolygonElement.h:
2631         * ksvg2/svg/SVGPolylineElement.cpp:
2632         (WebCore::SVGPolylineElement::SVGPolylineElement):
2633         (WebCore::SVGPolylineElement::toPathData):
2634         * ksvg2/svg/SVGPolylineElement.h:
2635         * ksvg2/svg/SVGRectElement.cpp:
2636         (WebCore::SVGRectElement::parseMappedAttribute):
2637         (WebCore::SVGRectElement::pushAttributeContext):
2638         * ksvg2/svg/SVGRectElement.h:
2639         (WebCore::SVGRectElement::rendererIsNeeded):
2640
2641 2006-10-08  Darin Adler  <darin@apple.com>
2642
2643         Reviewed by Maciej.
2644
2645         - added a bit more WebCoreSystemInterface
2646
2647             wkGetNSURLResponseCalculatedExpiration
2648             wkGetNSURLResponseLastModifiedDate
2649             wkGetNSURLResponseMustRevalidate
2650
2651         * WebCore.exp: Added the new symbols.
2652         * platform/mac/WebCoreSystemInterface.h: Ditto.
2653         * platform/mac/WebCoreSystemInterface.mm: Ditto.
2654
2655         - quiet down the code generation script
2656
2657         * bindings/scripts/CodeGenerator.pm:
2658
2659 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2660
2661         Reviewed by Darin.
2662
2663         - more code laundering - add wkSupportsMultipartXMixedReplace
2664
2665         * WebCore.exp:
2666         * platform/mac/WebCoreSystemInterface.h:
2667         * platform/mac/WebCoreSystemInterface.mm:
2668
2669 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
2670
2671         Reviewed by Darin and Oliver.
2672
2673         Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.
2674
2675         * platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage.
2676         (WebCore::GraphicsContext::drawConvexPolygon):
2677
2678 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
2679
2680         Reviewed by Darin.
2681
2682         * page/Frame.cpp:
2683         (WebCore::Frame::submitForm):
2684         No need to use latin1() here.
2685
2686 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
2687
2688         Reviewed by Darin.
2689
2690         Kill warnings when generating IDL files on Qt/Linux, as the
2691         SOURCE_ROOT environment variable is not defined (and not needed) for us.
2692
2693         * bindings/scripts/CodeGenerator.pm:
2694
2695 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2696
2697         Reviewed by Darin.
2698
2699         - split didNotOpenURL: into general and page-cache-specific parts
2700
2701         * bridge/mac/WebCoreFrameBridge.h:
2702         * bridge/mac/WebCoreFrameBridge.mm:
2703         (-[WebCoreFrameBridge didNotOpenURL:]):
2704         (-[WebCoreFrameBridge invalidatePageCache:]):
2705
2706 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
2707
2708         Reviewed by Darin.
2709
2710         * loader/loader.cpp:
2711         Remove DeprecatedStringList.h include.
2712
2713         * page/Frame.cpp:
2714         (WebCore::Frame::submitForm):
2715         Don't remove "attach" from mailto URLs, we don't do it anywhere else.
2716
2717 2006-10-08  Sam Weinig  <sam.weinig@gmail.com>
2718
2719         Reviewed by Darin.
2720
2721         Patch for http://bugs.webkit.org/show_bug.cgi?id=11215
2722         Yet another round of Objective-C SVG DOM bindings auto-generation
2723
2724         - Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement,
2725           DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent,
2726           DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement,
2727           DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement,
2728           DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement,
2729           DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement,
2730           DOMSVGZoomAndPan and DOMSVGZoomEvent.
2731
2732         - Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement
2733           using the new [ConvertFromString] property.
2734
2735         - Add forward declarations for NS* types to auto-generated classes.
2736
2737         * DerivedSources.make:
2738         * WebCore.xcodeproj/project.pbxproj:
2739         * bindings/objc/DOMHTMLAppletElement.mm: Removed.
2740         * bindings/objc/DOMHTMLEmbedElement.mm: Removed.
2741         * bindings/objc/DOMInternal.h:
2742         * bindings/objc/DOMSVG.h:
2743         * bindings/scripts/CodeGeneratorObjC.pm:
2744         * html/HTMLAppletElement.idl:
2745         * html/HTMLEmbedElement.idl:
2746         * ksvg2/svg/SVGPatternElement.idl:
2747         * ksvg2/svg/SVGPolygonElement.idl:
2748         * ksvg2/svg/SVGPolylineElement.idl:
2749         * ksvg2/svg/SVGRadialGradientElement.idl:
2750         * ksvg2/svg/SVGRenderingIntent.idl:
2751         * ksvg2/svg/SVGScriptElement.idl:
2752         * ksvg2/svg/SVGSetElement.idl:
2753         * ksvg2/svg/SVGStopElement.idl:
2754         * ksvg2/svg/SVGSwitchElement.idl:
2755         * ksvg2/svg/SVGSymbolElement.idl:
2756         * ksvg2/svg/SVGTRefElement.idl:
2757         * ksvg2/svg/SVGTSpanElement.idl:
2758         * ksvg2/svg/SVGTextContentElement.idl:
2759         * ksvg2/svg/SVGTextElement.idl:
2760         * ksvg2/svg/SVGTextPositioningElement.idl:
2761         * ksvg2/svg/SVGTitleElement.idl:
2762         * ksvg2/svg/SVGUseElement.idl:
2763         * ksvg2/svg/SVGViewElement.idl:
2764         * ksvg2/svg/SVGZoomEvent.idl:
2765
2766 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
2767
2768         Reviewed by Maciej.
2769
2770         Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.
2771         * loader/loader.cpp:
2772         (WebCore::Loader::servePendingRequests):
2773
2774 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
2775
2776         Reviewed by Darin.
2777
2778         Convert a bunch of RefPtr<StringImpl> to String.
2779
2780         * bridge/mac/FrameMac.h:
2781         * bridge/mac/FrameMac.mm:
2782         (WebCore::FrameMac::didTellBridgeAboutLoad):
2783         (WebCore::FrameMac::haveToldBridgeAboutLoad):
2784         * dom/BeforeUnloadEvent.cpp:
2785         (WebCore::BeforeUnloadEvent::storeResult):
2786         * dom/BeforeUnloadEvent.h:
2787         (WebCore::BeforeUnloadEvent::result):
2788         * dom/Document.cpp:
2789         (WebCore::Document::createEntityReference):
2790         * dom/Entity.cpp:
2791         (WebCore::Entity::Entity):
2792         (WebCore::Entity::nodeName):
2793         (WebCore::Entity::toString):
2794         * dom/Entity.h:
2795         (WebCore::Entity::publicId):
2796         (WebCore::Entity::systemId):
2797         (WebCore::Entity::notationName):
2798         * dom/EntityReference.cpp:
2799         (WebCore::EntityReference::EntityReference):
2800         (WebCore::EntityReference::nodeName):
2801         (WebCore::EntityReference::cloneNode):
2802         (WebCore::EntityReference::toString):
2803         * dom/EntityReference.h:
2804         * dom/KeyboardEvent.cpp:
2805         (WebCore::KeyboardEvent::KeyboardEvent):
2806         (WebCore::KeyboardEvent::initKeyboardEvent):
2807         * dom/KeyboardEvent.h:
2808         (WebCore::KeyboardEvent::keyIdentifier):
2809         * dom/MutationEvent.cpp:
2810         (WebCore::MutationEvent::MutationEvent):
2811         (WebCore::MutationEvent::initMutationEvent):
2812         * dom/MutationEvent.h:
2813         (WebCore::MutationEvent::prevValue):
2814         (WebCore::MutationEvent::newValue):
2815         (WebCore::MutationEvent::attrName):
2816         * dom/Notation.cpp:
2817         (WebCore::Notation::Notation):
2818         (WebCore::Notation::nodeName):
2819         * dom/Notation.h:
2820         (WebCore::Notation::publicId):
2821         (WebCore::Notation::systemId):
2822         * dom/ProcessingInstruction.cpp:
2823         (WebCore::ProcessingInstruction::ProcessingInstruction):
2824         (WebCore::ProcessingInstruction::setData):
2825         (WebCore::ProcessingInstruction::nodeName):
2826         (WebCore::ProcessingInstruction::nodeValue):
2827         (WebCore::ProcessingInstruction::cloneNode):
2828         (WebCore::ProcessingInstruction::checkStyleSheet):
2829         (WebCore::ProcessingInstruction::toString):
2830         * dom/ProcessingInstruction.h:
2831         (WebCore::ProcessingInstruction::target):
2832         (WebCore::ProcessingInstruction::data):
2833         (WebCore::ProcessingInstruction::localHref):
2834
2835 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
2836
2837         Reviewed by Tim H.
2838
2839         Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
2840         10 more SVG Objective-C auto-generated bindings
2841
2842         - Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox,
2843           DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement,
2844           DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement,
2845           DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
2846
2847         - Auto-generate the text method for DOMRange.
2848
2849         * DerivedSources.make:
2850         * WebCore.xcodeproj/project.pbxproj:
2851         * bindings/objc/DOM.mm:
2852         * bindings/objc/DOMExtensions.h:
2853         * bindings/objc/DOMInternal.h:
2854         * bindings/objc/DOMPrivate.h:
2855         * bindings/objc/DOMRGBColor.mm:
2856         * bindings/objc/DOMSVG.h:
2857         * bindings/objc/PublicDOMInterfaces.h:
2858         * bindings/scripts/CodeGeneratorObjC.pm:
2859         * dom/Range.idl:
2860         * ksvg2/svg/SVGFilterElement.cpp:
2861         * ksvg2/svg/SVGFilterElement.h:
2862         * ksvg2/svg/SVGFilterElement.idl:
2863         * ksvg2/svg/SVGForeignObjectElement.idl:
2864         * ksvg2/svg/SVGGElement.idl:
2865         * ksvg2/svg/SVGGradientElement.idl:
2866         * ksvg2/svg/SVGImageElement.idl:
2867         * ksvg2/svg/SVGLineElement.idl:
2868         * ksvg2/svg/SVGLinearGradientElement.idl:
2869         * ksvg2/svg/SVGMarkerElement.idl:
2870         * ksvg2/svg/SVGMaskElement.idl:
2871         * ksvg2/svg/SVGPaint.idl:
2872
2873 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
2874
2875         Reviewed by Tim H.
2876
2877         Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
2878         Auto-generate a few more Objective-C DOM interfaces
2879
2880         - Fully auto-generate DOMAbstractView and DOMRange.
2881
2882         - Auto-generate just the interface for DOMRGBColor.
2883
2884         - Add DOMRanges.h as the new top level file for Ranges
2885           module.
2886
2887         - Add DOMRanges.h and DOMXPath.h to DOM.mm
2888
2889         * DerivedSources.make:
2890         * WebCore.xcodeproj/project.pbxproj:
2891         * bindings/objc/DOM.h:
2892         * bindings/objc/DOM.mm:
2893         * bindings/objc/DOMAbstractView.h: Removed.
2894         * bindings/objc/DOMAbstractView.mm: Removed.
2895         * bindings/objc/DOMInternal.h:
2896         * bindings/objc/DOMPrivate.h:
2897         * bindings/objc/DOMRGBColor.h: Removed.
2898         * bindings/objc/DOMRGBColor.mm:
2899         * bindings/objc/DOMRange.h: Removed.
2900         * bindings/objc/DOMRanges.h: Added.
2901         * bindings/objc/PublicDOMInterfaces.h:
2902         * bindings/scripts/CodeGeneratorObjC.pm:
2903         * css/RGBColor.idl:
2904         * dom/Range.idl:
2905         * page/AbstractView.idl: Added.
2906
2907 2006-10-07  Andrew Wellington  <proton@wiretapped.net>
2908
2909         Reviewed by Eric.
2910
2911         Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
2912         http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
2913
2914         Return null when there is no frame. This matches Firefox.
2915
2916         * bindings/js/kjs_html.cpp:
2917         (KJS::JSHTMLDocument::getValueProperty):
2918
2919 2006-10-07  David Hyatt  <hyatt@apple.com>
2920
2921         Implement scroll corner painting (a white rect fill) for overflow areas to cover up
2922         scrollbar joins properly.
2923
2924         Refactor painting of scrollbars and resizers into common functions.  Eliminate the
2925         extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
2926
2927         Reviewed by mitz
2928
2929         * page/FrameView.cpp:
2930         (WebCore::selectCursor):
2931         (WebCore::FrameView::handleMouseMoveEvent):
2932         * platform/mac/PlatformScrollBar.h:
2933         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
2934         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
2935         * rendering/RenderLayer.cpp:
2936         (WebCore::RenderLayer::RenderLayer):
2937         (WebCore::RenderLayer::~RenderLayer):
2938         (WebCore::RenderLayer::updateLayerPositions):
2939         (WebCore::scrollCornerRect):
2940         (WebCore::RenderLayer::positionOverflowControls):
2941         (WebCore::RenderLayer::paintOverflowControls):
2942         (WebCore::RenderLayer::isPointInResizeControl):
2943         (WebCore::RenderLayer::paintLayer):
2944         * rendering/RenderLayer.h:
2945
2946 2006-10-07  Mark Rowe  <bdash@webkit.org>
2947
2948         Reviewed by Mitz.
2949
2950         Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
2951         matching recent ResourceLoader changes.
2952
2953         * platform/gdk/FrameGdk.cpp:
2954         (WebCore::FrameGdk::openURL):
2955         (WebCore::FrameGdk::urlSelected):
2956         * platform/gdk/PlatformScrollBar.h:
2957         * platform/gdk/ResourceLoaderCurl.cpp:
2958         (WebCore::ResourceLoader::start):
2959         * platform/gdk/ScrollViewGdk.cpp:
2960         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
2961         (WebCore::ScrollView::resizeContents):
2962         (WebCore::ScrollView::scrollBy):
2963         (WebCore::ScrollView::hScrollbarMode):
2964         (WebCore::ScrollView::vScrollbarMode):
2965         (WebCore::ScrollView::suppressScrollbars):
2966         (WebCore::ScrollView::setHScrollbarMode):
2967         (WebCore::ScrollView::setVScrollbarMode):
2968         (WebCore::ScrollView::setScrollbarsMode):
2969         * platform/gdk/TemporaryLinkStubs.cpp:
2970         (FrameView::passMousePressEventToScrollbar):
2971         (Widget::removeFromParent):
2972         (ScrollView::addChild):
2973         (ScrollView::updateScrollbars):
2974         (ScrollView::scrollbarUnderMouse):
2975         (PlatformScrollbar::PlatformScrollbar):
2976         (PlatformScrollbar::~PlatformScrollbar):
2977         (PlatformScrollbar::width):
2978         (PlatformScrollbar::height):
2979         (PlatformScrollbar::setEnabled):
2980         (PlatformScrollbar::paint):
2981         (PlatformScrollbar::updateThumbPosition):
2982         (PlatformScrollbar::updateThumbProportion):
2983         (PlatformScrollbar::setRect):
2984         (Scrollbar::Scrollbar):
2985         (Scrollbar::setSteps):
2986         (Scrollbar::scroll):
2987         (Scrollbar::setValue):
2988         (Scrollbar::setProportion):
2989
2990 2006-10-06  Dave Hyatt  <hyatt@apple.com>
2991
2992         Implement a new method for obtaining accurate clip rectangles that can be used by plugins to properly clip.
2993
2994         * page/FrameView.cpp:
2995         (WebCore::FrameView::windowClipRect):
2996         * page/FrameView.h:
2997         * platform/ScrollView.h:
2998         * platform/Widget.cpp:
2999         (WebCore::Widget::windowClipRect):
3000         * platform/Widget.h:
3001         (WebCore::Widget::geometryChanged):
3002         (WebCore::Widget::handleMouseMoveEvent):
3003         (WebCore::Widget::handleMouseReleaseEvent):
3004         * platform/mac/ScrollViewMac.mm:
3005         (WebCore::ScrollView::addChild):
3006         * rendering/RenderLayer.cpp:
3007         (WebCore::RenderLayer::documentClipRect):
3008         * rendering/RenderLayer.h:
3009
3010 2006-10-06  Steve Falkenburg  <sfalken@apple.com>
3011
3012         Reviewed by Adam.
3013
3014         Add another method we'll need for scrollbar dodging
3015
3016         * platform/ScrollView.h:
3017         * platform/win/TemporaryLinkStubs.cpp:
3018         (ScrollView::resizerOverlapsContent):
3019
3020 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
3021
3022         Reviewed by Tim H.
3023
3024         Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
3025         Auto-generate the interfaces even for Objective-C DOM
3026         bindings that need custom implementations
3027
3028         - Fully auto-generate DOMEventTarget, DOMNodeFilter and
3029           DOMHTMLOptionElement.
3030
3031         - Auto-generate just the interface for DOMHTMLAppletElement,
3032           DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect
3033           using the new IDL property ObjCCustomImplementation.
3034
3035         * DerivedSources.make:
3036         * WebCore.xcodeproj/project.pbxproj:
3037         * bindings/objc/DOMEventTarget.h: Removed.
3038         * bindings/objc/DOMHTMLAppletElement.h: Removed.
3039         * bindings/objc/DOMHTMLEmbedElement.h: Removed.
3040         * bindings/objc/DOMHTMLOptionElement.h: Removed.
3041         * bindings/objc/DOMHTMLOptionElement.mm: Removed.
3042         * bindings/objc/DOMInternal.h:
3043         * bindings/objc/DOMNodeFilter.h: Removed.
3044         * bindings/objc/DOMSVGNumber.h: Removed.
3045         * bindings/objc/DOMSVGPoint.h: Removed.
3046         * bindings/objc/DOMSVGPoint.mm:
3047         (-[DOMSVGPoint matrixTransform:]):
3048         * bindings/objc/DOMSVGRect.h: Removed.
3049         * bindings/objc/PublicDOMInterfaces.h:
3050         * bindings/scripts/CodeGeneratorObjC.pm:
3051         * dom/EventTarget.idl:
3052         * html/HTMLAppletElement.idl:
3053         * html/HTMLEmbedElement.idl:
3054         * html/HTMLOptionElement.idl:
3055         * ksvg2/svg/SVGNumber.idl:
3056         * ksvg2/svg/SVGPoint.idl:
3057         * ksvg2/svg/SVGRect.idl:
3058
3059 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
3060
3061         Reviewed by Tim H.
3062
3063         Make Qt/Linux compile again completly.
3064
3065         * platform/qt/WidgetQt.cpp:
3066         (WebCore::Widget::removeFromParent):
3067
3068 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
3069
3070         Reviewed by Tim H.
3071
3072         Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.
3073
3074         * platform/qt/PlatformScrollBar.h:
3075         * platform/qt/ScrollViewQt.cpp:
3076         (WebCore::ScrollView::hScrollbarMode):
3077         (WebCore::ScrollView::vScrollbarMode):
3078         (WebCore::ScrollView::suppressScrollbars):
3079         (WebCore::ScrollView::setHScrollbarMode):
3080         (WebCore::ScrollView::setVScrollbarMode):
3081         (WebCore::ScrollView::setScrollbarsMode):
3082         (WebCore::ScrollView::scrollbarUnderMouse):
3083         * platform/qt/TemporaryLinkStubs.cpp:
3084         (WebCore::Scrollbar::Scrollbar):
3085         (WebCore::Scrollbar::setSteps):
3086         (WebCore::Scrollbar::scroll):
3087         (WebCore::Scrollbar::setValue):
3088         (WebCore::Scrollbar::setProportion):
3089         (WebCore::PlatformScrollbar::PlatformScrollbar):
3090         (WebCore::PlatformScrollbar::~PlatformScrollbar):
3091         (WebCore::PlatformScrollbar::width):
3092         (WebCore::PlatformScrollbar::height):
3093         (WebCore::PlatformScrollbar::setEnabled):
3094         (WebCore::PlatformScrollbar::paint):
3095         (WebCore::PlatformScrollbar::updateThumbPosition):
3096         (WebCore::PlatformScrollbar::updateThumbProportion):
3097         (WebCore::PlatformScrollbar::setRect):
3098         (FrameView::passMousePressEventToScrollbar):
3099
3100 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
3101
3102         Reviewed by Tim H.
3103
3104         Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
3105         Another round of Objective-C SVG DOM bindings auto-generation
3106
3107         - Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect,
3108           DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement,
3109           DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement,
3110           DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement,
3111           DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement,
3112           DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement,
3113           DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement,
3114           DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement,
3115           DOMSVGFEOffsetElement, DOMSVGFEPointLightElement,
3116           DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement,
3117           DOMSVGFETileElement, DOMSVGFETurbulenceElement,
3118           DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList.
3119
3120         - Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint
3121           and DOMSVGRect.
3122
3123         - IDL clean up.
3124
3125         - Make numOctaves in SVGFETurbulenceElement use a long instead of an int
3126           in it's macro declaration and definition.
3127
3128         * DerivedSources.make:
3129         * WebCore.xcodeproj/project.pbxproj:
3130         * bindings/objc/DOMCSS.mm:
3131         (+[DOMCSSValue _CSSValueWith:WebCore::]):
3132         * bindings/objc/DOMInternal.h:
3133         * bindings/objc/DOMSVG.h:
3134         * bindings/objc/DOMSVGNumber.h: Added.
3135         * bindings/objc/DOMSVGNumber.mm: Added.
3136         (-[DOMSVGNumber dealloc]):
3137         (-[DOMSVGNumber finalize]):
3138         (-[DOMSVGNumber value]):
3139         (-[DOMSVGNumber setValue:]):
3140         (-[DOMSVGNumber _SVGNumber]):
3141         (-[DOMSVGNumber _initWithFloat:]):
3142         (+[DOMSVGNumber _SVGNumberWith:]):
3143         * bindings/objc/DOMSVGPoint.h: Added.
3144         * bindings/objc/DOMSVGPoint.mm: Added.
3145         (-[DOMSVGPoint dealloc]):
3146         (-[DOMSVGPoint finalize]):
3147         (-[DOMSVGPoint x]):
3148         (-[DOMSVGPoint setX:]):
3149         (-[DOMSVGPoint y]):
3150         (-[DOMSVGPoint setY:]):
3151         (-[DOMSVGPoint WebCore::]):
3152         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
3153         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
3154         * bindings/objc/DOMSVGRect.h: Added.
3155         * bindings/objc/DOMSVGRect.mm: Added.
3156         (-[DOMSVGRect dealloc]):
3157         (-[DOMSVGRect finalize]):
3158         (-[DOMSVGRect x]):
3159         (-[DOMSVGRect setX:]):
3160         (-[DOMSVGRect y]):
3161         (-[DOMSVGRect setY:]):
3162         (-[DOMSVGRect width]):
3163         (-[DOMSVGRect setWidth:]):
3164         (-[DOMSVGRect height]):
3165         (-[DOMSVGRect setHeight:]):
3166         (-[DOMSVGRect WebCore::]):
3167         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
3168         (+[DOMSVGRect _SVGRectWith:WebCore::]):
3169         * bindings/scripts/CodeGeneratorObjC.pm:
3170         * ksvg2/svg/SVGAnimatedNumberList.idl:
3171         * ksvg2/svg/SVGAnimatedRect.idl:
3172         * ksvg2/svg/SVGComponentTransferFunctionElement.idl:
3173         * ksvg2/svg/SVGCursorElement.idl:
3174         * ksvg2/svg/SVGFEBlendElement.idl:
3175         * ksvg2/svg/SVGFEColorMatrixElement.idl:
3176         * ksvg2/svg/SVGFEComponentTransferElement.idl:
3177         * ksvg2/svg/SVGFECompositeElement.idl:
3178         * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
3179         * ksvg2/svg/SVGFEDisplacementMapElement.idl:
3180         * ksvg2/svg/SVGFEDistantLightElement.idl:
3181         * ksvg2/svg/SVGFEFloodElement.idl:
3182         * ksvg2/svg/SVGFEFuncAElement.idl:
3183         * ksvg2/svg/SVGFEFuncBElement.idl:
3184         * ksvg2/svg/SVGFEFuncGElement.idl:
3185         * ksvg2/svg/SVGFEFuncRElement.idl:
3186         * ksvg2/svg/SVGFEGaussianBlurElement.idl:
3187         * ksvg2/svg/SVGFEImageElement.idl:
3188         * ksvg2/svg/SVGFEMergeElement.idl:
3189         * ksvg2/svg/SVGFEMergeNodeElement.idl:
3190         * ksvg2/svg/SVGFEOffsetElement.idl:
3191         * ksvg2/svg/SVGFEPointLightElement.idl:
3192         * ksvg2/svg/SVGFESpecularLightingElement.idl:
3193         * ksvg2/svg/SVGFESpotLightElement.idl:
3194         * ksvg2/svg/SVGFETileElement.idl:
3195         * ksvg2/svg/SVGFETurbulenceElement.cpp:
3196         * ksvg2/svg/SVGFETurbulenceElement.h:
3197         * ksvg2/svg/SVGFETurbulenceElement.idl:
3198         * ksvg2/svg/SVGNumberList.idl:
3199
3200 2006-10-06  Adam Roben  <aroben@apple.com>
3201
3202         Backing out my previous change.
3203
3204         * WebCore.xcodeproj/project.pbxproj:
3205         * page/FrameView.cpp:
3206         (WebCore::FrameView::adjustViewSize):
3207
3208 2006-10-06  Adam Roben  <aroben@apple.com>
3209
3210         Build fix.
3211
3212         * WebCore.xcodeproj/project.pbxproj:
3213         * page/FrameView.cpp:
3214         (WebCore::FrameView::windowResizerRect):
3215
3216 2006-10-06  Adam Roben  <aroben@apple.com>
3217
3218         Reviewed by Maciej.
3219
3220         More loader tweaks.
3221
3222         * platform/ResourceLoader.h:
3223         * platform/ResourceLoaderInternal.h:
3224         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3225         * platform/win/TemporaryLinkStubs.cpp:
3226         (WebCore::ResourceLoader::newHTTPRequest):
3227
3228 2006-10-05  Steve Falkenburg  <sfalken@apple.com>
3229
3230         Reviewed by aroben.
3231
3232         Stub out some methods that we'll be able to use to dodge a window resizer.
3233
3234         * bridge/win/FrameWin.h:
3235         * page/Frame.h:
3236         (WebCore::Frame::windowResizerRect):
3237         * page/FrameView.h:
3238         * platform/ScrollView.h:
3239         (WebCore::ScrollView::windowResizerRect):
3240         * platform/Widget.h:
3241         * platform/win/TemporaryLinkStubs.cpp:
3242         (FrameView::windowResizerRect):
3243         (Widget::setParent):
3244         (Widget::parent):
3245         (FrameWin::windowResizerRect):
3246
3247 2006-10-05  Dave Hyatt  <hyatt@apple.com>
3248
3249         Stub out setFrameGeometry.
3250
3251         * platform/ScrollView.h:
3252
3253 2006-10-05  Adele Peterson  <adele@apple.com>
3254
3255         Reverting autoscroll fix.  I need to rework this a little.
3256
3257         * page/Frame.cpp:
3258         (WebCore::Frame::handleAutoscroll):
3259         (WebCore::Frame::autoscrollTimerFired):
3260         (WebCore::Frame::stopAutoscrollTimer):
3261         * page/Frame.h:
3262         * rendering/RenderLayer.cpp:
3263         (WebCore::RenderLayer::~RenderLayer):
3264         * rendering/RenderListBox.cpp:
3265         (WebCore::RenderListBox::~RenderListBox):
3266
3267 2006-10-05  Alice  <alice.liu@apple.com>
3268
3269         Reviewed by Adam.
3270
3271         Fixed <rdar://problem/4731778>
3272
3273         * editing/CommandByName.cpp:
3274         (WebCore::Frame::Command::):
3275         was calling the wrong enabledFn for arrow selection and navigation
3276
3277 2006-10-05  Adele Peterson  <adele@apple.com>
3278
3279         Reviewed by Maciej.
3280
3281         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text">
3282           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
3283
3284         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
3285         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
3286
3287         * page/Frame.cpp: Added getter and setter for the renderer being autoscrolled.
3288         (WebCore::Frame::handleAutoscroll):
3289         (WebCore::Frame::autoscrollTimerFired):
3290         (WebCore::Frame::autoscrollRenderer):
3291         (WebCore::Frame::setAutoscrollRenderer):
3292         (WebCore::Frame::stopAutoscrollTimer):
3293         * page/Frame.h:
3294
3295 2006-10-05  Don Gibson  <dgibson77@gmail.com>
3296
3297         Reviewed by Eric.
3298
3299         Fix win32 build bustage after ggaren's Scrollbar renaming changes.
3300         Properly include PlatformScrollBar.h in WbCore.vcproj.
3301         Clean up WidgetWin.cpp a bit.
3302
3303         * WebCore.vcproj/WebCore/WebCore.vcproj:
3304         * platform/Widget.h:
3305         * platform/win/PlatformScrollBar.h:
3306         * platform/win/ScrollViewWin.cpp:
3307         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
3308         (WebCore::ScrollView::resizeContents):
3309         (WebCore::ScrollView::scrollBy):
3310         (WebCore::ScrollView::hScrollbarMode):
3311         (WebCore::ScrollView::vScrollbarMode):
3312         (WebCore::ScrollView::suppressScrollbars):
3313         (WebCore::ScrollView::setHScrollbarMode):
3314         (WebCore::ScrollView::setVScrollbarMode):
3315         (WebCore::ScrollView::setScrollbarsMode):
3316         (WebCore::ScrollView::updateScrollbars):
3317         * platform/win/TemporaryLinkStubs.cpp:
3318         (FrameView::passMousePressEventToScrollbar):
3319         (Widget::removeFromParent):
3320         (ScrollView::scrollbarUnderMouse):
3321         (PlatformScrollbar::PlatformScrollbar):
3322         (PlatformScrollbar::~PlatformScrollbar):
3323         (PlatformScrollbar::width):
3324         (PlatformScrollbar::height):
3325         (PlatformScrollbar::setEnabled):
3326         (PlatformScrollbar::paint):
3327         (PlatformScrollbar::updateThumbPosition):
3328         (PlatformScrollbar::updateThumbProportion):
3329         (PlatformScrollbar::setRect):
3330         (Scrollbar::Scrollbar):
3331         (Scrollbar::setSteps):
3332         (Scrollbar::scroll):
3333         (Scrollbar::setValue):
3334         (Scrollbar::setProportion):
3335         * platform/win/WidgetWin.cpp:
3336         (WebCore::WidgetPrivate::WidgetPrivate):
3337         (WebCore::Widget::Widget):
3338         (WebCore::Widget::setContainingWindow):
3339         (WebCore::Widget::containingWindow):
3340
3341 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
3342
3343         build fix.
3344
3345         * WebCore.xcodeproj/project.pbxproj:
3346         * bridge/mac/BrowserExtensionMac.mm:
3347         (WebCore::BrowserExtensionMac::createNewWindow):
3348         * bridge/mac/FrameMac.mm:
3349         (WebCore::FrameMac::createFrame):
3350         * bridge/mac/FrameViewMac.mm:
3351         (WebCore::FrameView::passMousePressEventToScrollbar):
3352         * bridge/mac/WebCoreFrameBridge.mm:
3353         (-[WebCoreFrameBridge installInFrame:]):
3354         * bridge/mac/WebCoreFrameView.h:
3355         * platform/ScrollBar.cpp:
3356         * platform/Widget.h:
3357         * platform/mac/PlatformScrollBar.h:
3358         * platform/mac/PlatformScrollBarMac.mm:
3359         (NSControlSizeForScrollBarControlSize):
3360         (-[WebCoreScrollBar initWithPlatformScrollbar:]):
3361         (-[WebCoreScrollBar detachPlatformScrollbar]):
3362         (-[WebCoreScrollBar scroll:]):
3363         (-[WebCoreScrollBar widget]):
3364         (WebCore::PlatformScrollbar::PlatformScrollbar):
3365         (WebCore::PlatformScrollbar::~PlatformScrollbar):
3366         (WebCore::PlatformScrollbar::updateThumbPosition):
3367         (WebCore::PlatformScrollbar::updateThumbProportion):
3368         (WebCore::PlatformScrollbar::scrollbarHit):
3369         (WebCore::PlatformScrollbar::width):
3370         (WebCore::PlatformScrollbar::height):
3371         (WebCore::PlatformScrollbar::setRect):
3372         (WebCore::PlatformScrollbar::setEnabled):
3373         (WebCore::PlatformScrollbar::paint):
3374         * platform/mac/ScrollViewMac.mm:
3375         (WebCore::ScrollView::setVScrollbarMode):
3376         (WebCore::ScrollView::setHScrollbarMode):
3377         (WebCore::ScrollView::setScrollbarsMode):
3378         (WebCore::ScrollView::vScrollbarMode):
3379         (WebCore::ScrollView::hScrollbarMode):
3380         (WebCore::ScrollView::suppressScrollbars):
3381         (WebCore::ScrollView::scrollbarUnderMouse):
3382         * platform/mac/WidgetMac.mm:
3383         (WebCore::Widget::removeFromParent):
3384         * rendering/RenderLayer.cpp:
3385         (WebCore::RenderLayer::destroyScrollbar):
3386
3387 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
3388
3389         build fix.
3390
3391         * platform/Widget.h:
3392         * rendering/RenderLayer.cpp:
3393         (WebCore::RenderLayer::destroyScrollbar):
3394
3395 2006-10-06  Mitz Pettel  <mitz@webkit.org>
3396
3397         http://bugs.webkit.org/show_bug.cgi?id=8276
3398         Fix broken manual test added back in r13990.
3399
3400         Add resource forks for test resources.
3401
3402         * manual-tests/resources/plain-text-paste/._1.textClipping: Added.
3403         * manual-tests/resources/plain-text-paste/._2.textClipping: Added.
3404         * manual-tests/resources/plain-text-paste/._4.txt: Added.
3405         * manual-tests/resources/plain-text-paste/._5.webloc: Added.
3406
3407 2006-10-05  David Hyatt  <hyatt@apple.com>
3408
3409         Rename addClip to clip.
3410
3411         Reviewed by darin
3412
3413         * kcanvas/RenderForeignObject.cpp:
3414         (WebCore::RenderForeignObject::paint):
3415         * kcanvas/RenderSVGContainer.cpp:
3416         (WebCore::RenderSVGContainer::paint):
3417         * kcanvas/RenderSVGImage.cpp:
3418         (WebCore::RenderSVGImage::paint):
3419         * platform/GraphicsContext.h:
3420         * platform/cairo/GraphicsContextCairo.cpp:
3421         (WebCore::GraphicsContext::clip):
3422         * platform/cg/GraphicsContextCG.cpp:
3423         (WebCore::GraphicsContext::savePlatformState):
3424         (WebCore::GraphicsContext::restorePlatformState):
3425         (WebCore::GraphicsContext::clip):
3426         (WebCore::GraphicsContext::addRoundedRectClip):
3427         (WebCore::GraphicsContext::addInnerRoundedRectClip):
3428         (WebCore::GraphicsContext::scale):
3429         (WebCore::GraphicsContext::rotate):
3430         (WebCore::GraphicsContext::translate):
3431         (WebCore::GraphicsContext::concatCTM):
3432         * platform/cg/GraphicsContextPlatformPrivate.h:
3433         (WebCore::GraphicsContextPlatformPrivate::save):
3434         (WebCore::GraphicsContextPlatformPrivate::restore):
3435         (WebCore::GraphicsContextPlatformPrivate::clip):
3436         (WebCore::GraphicsContextPlatformPrivate::scale):
3437         (WebCore::GraphicsContextPlatformPrivate::rotate):
3438         (WebCore::GraphicsContextPlatformPrivate::translate):
3439         (WebCore::GraphicsContextPlatformPrivate::concatCTM):
3440         * platform/qt/GraphicsContextQt.cpp:
3441         (WebCore::GraphicsContext::clip):
3442         (WebCore::GraphicsContext::addInnerRoundedRectClip):
3443         (WebCore::GraphicsContext::addRoundedRectClip):
3444         * rendering/InlineFlowBox.cpp:
3445         (WebCore::InlineFlowBox::paintBackground):
3446         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
3447         * rendering/InlineTextBox.cpp:
3448         (WebCore::InlineTextBox::paintSelection):
3449         (WebCore::InlineTextBox::paintTextMatchMarker):
3450         * rendering/RenderBox.cpp:
3451         (WebCore::RenderBox::paintBackgroundExtended):
3452         * rendering/RenderButton.cpp:
3453         (WebCore::RenderButton::paintObject):
3454         * rendering/RenderFileUploadControl.cpp:
3455         (WebCore::RenderFileUploadControl::paintObject):
3456         * rendering/RenderLayer.cpp:
3457         (WebCore::RenderLayer::beginTransparencyLayers):
3458         (WebCore::setClip):
3459         * rendering/RenderListBox.cpp:
3460         (WebCore::RenderListBox::paintObject):
3461         * rendering/RenderMenuList.cpp:
3462         (WebCore::RenderMenuList::paintObject):
3463         * rendering/RenderTableCell.cpp:
3464         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
3465
3466 2006-10-05  Mitz Pettel  <mitz@webkit.org>
3467
3468         Reviewed by Darin.
3469
3470         - http://bugs.webkit.org/show_bug.cgi?id=10386
3471           Delete RenderImageButton.* and remove references from .vcproj and .bkl files
3472
3473         * CMakeLists.txt:
3474         * WebCore.vcproj/WebCore/WebCore.vcproj:
3475         * WebCoreSources.bkl:
3476         * rendering/RenderImageButton.cpp: Removed.
3477         * rendering/RenderImageButton.h: Removed.
3478
3479 2006-10-05  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3480
3481         Reviewed by Darin.
3482
3483         - http://bugs.webkit.org/show_bug.cgi?id=11067
3484           manual-tests/scrollbar-hittest2.html is invalid
3485
3486         * manual-tests/scrollbar-hittest2.html:
3487
3488 2006-10-05  David Carson  <dacarson@gmail.com>
3489
3490         Reviewed by Darin.
3491
3492         http://bugs.webkit.org/show_bug.cgi?id=11152
3493         Adjust the tokenizer chunk size to be smaller for
3494         mobile devices, and also decrease the yield timer
3495         for the tokenizer so that it can resume earlier.
3496
3497         * html/HTMLTokenizer.cpp:
3498         * config.h:
3499
3500 2006-10-05  Adam Roben  <aroben@apple.com>
3501
3502         Removing accidentally-checked-in do-nothing code.
3503
3504         * html/HTMLInputElement.cpp:
3505         (WebCore::HTMLInputElement::defaultEventHandler):
3506
3507 2006-10-05  David Carson  <dacarson@gmail.com>
3508
3509         Reviewed by Mitz.
3510
3511         http://bugs.webkit.org/show_bug.cgi?id=11158
3512         Initialize class variables
3513
3514         * rendering/RenderLayer.cpp:
3515         (WebCore::RenderLayer::RenderLayer):
3516
3517 2006-10-05  Don Gibson  <dgibson77@gmail.com>
3518
3519         Reviewed by Darin, landed by Adam.
3520
3521         http://bugs.webkit.org/show_bug.cgi?id=11176
3522         Fix win32 build, adapt to Maciej's ResourceLoader changes.
3523
3524         * platform/win/ResourceLoaderWin.cpp:
3525         (WebCore::ResourceLoader::start):
3526
3527 2006-10-05  Marvin Decker  <marv.decker@gmail.com>
3528
3529         Reviewed by Darin.
3530
3531         http://bugs.webkit.org/show_bug.cgi?id=10989
3532         Provide a way for embedders to implement BrowserExtensionWin
3533
3534         * WebCore.vcproj/WebCore/WebCore.vcproj:
3535         * bridge/win/BrowserExtensionWin.cpp: Added.
3536         (BrowserExtensionWin::BrowserExtensionWin):
3537         (BrowserExtensionWin::setTypedIconURL):
3538         (BrowserExtensionWin::setIconURL):
3539         (BrowserExtensionWin::getHistoryLength):
3540         (BrowserExtensionWin::canRunModal):
3541         (BrowserExtensionWin::createNewWindow):
3542         (BrowserExtensionWin::canRunModalNow):
3543         (BrowserExtensionWin::runModal):
3544         (BrowserExtensionWin::goBackOrForward):
3545         (BrowserExtensionWin::historyURL):
3546         * bridge/win/BrowserExtensionWin.h:
3547         * bridge/win/FrameWin.cpp:
3548         (WebCore::FrameWin::createNewWindow):
3549         * bridge/win/FrameWin.h:
3550         * platform/win/TemporaryLinkStubs.cpp:
3551
3552 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
3553
3554         Reviewed by Darin.
3555
3556         Fixed <rdar://problem/4766987>
3557
3558         - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
3559         except for file names.
3560
3561         - fixed RenderLayer to properly tear down scrollbars, removing them from
3562         their parents.
3563
3564         * bindings/js/kjs_window.cpp:
3565         (KJS::showModalDialog):
3566         (KJS::setWindowFeature):
3567         (KJS::parseWindowFeatures):
3568         * bridge/BrowserExtension.h:
3569         * dom/Document.cpp:
3570         (WebCore::Document::setInPageCache):
3571         * html/HTMLFrameElement.cpp:
3572         (WebCore::HTMLFrameElement::init):
3573         (WebCore::HTMLFrameElement::parseMappedAttribute):
3574         * html/HTMLFrameElement.h:
3575         (WebCore::HTMLFrameElement::scrollingMode):
3576         * page/Frame.cpp:
3577         (WebCore::Frame::finishedParsing):
3578         (WebCore::Frame::scrollbarsVisible):
3579         * page/FrameView.cpp:
3580         (WebCore::FrameViewPrivate::FrameViewPrivate):
3581         (WebCore::FrameViewPrivate::reset):
3582         (WebCore::FrameView::~FrameView):
3583         (WebCore::FrameView::resetScrollbars):
3584         (WebCore::FrameView::clear):
3585         (WebCore::FrameView::initScrollbars):
3586         (WebCore::FrameView::applyOverflowToViewport):
3587         (WebCore::FrameView::layout):
3588         (WebCore::FrameView::handleMousePressEvent):
3589         (WebCore::selectCursor):
3590         (WebCore::FrameView::handleMouseMoveEvent):
3591         (WebCore::FrameView::setScrollbarsMode):
3592         (WebCore::FrameView::setVScrollbarMode):
3593         (WebCore::FrameView::setHScrollbarMode):
3594         (WebCore::FrameView::restoreScrollbar):
3595         (WebCore::FrameView::dispatchMouseEvent):
3596         (WebCore::FrameView::scrollbarMoved):
3597         * page/FrameView.h:
3598         * page/MouseEventWithHitTestResults.cpp:
3599         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
3600         * page/MouseEventWithHitTestResults.h:
3601         (WebCore::MouseEventWithHitTestResults::scrollbar):
3602         * platform/ScrollBar.cpp:
3603         (WebCore::Scrollbar::Scrollbar):
3604         (WebCore::Scrollbar::setValue):