2011-01-03 Mihai Parparita <mihaip@chromium.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2011-01-03  Mihai Parparita  <mihaip@chromium.org>
2
3         Unreviewed.
4
5         NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
6         https://bugs.webkit.org/show_bug.cgi?id=51151
7
8         Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
9         so that it can match Safari's (and thus use the same baselines).
10
11         No new tests, should be covered by layout tests (which will need
12         expectation changes)
13
14         * platform/chromium/ScrollbarThemeChromiumMac.mm:
15
16 2011-01-03  Antonio Gomes  <agomes@rim.com>
17
18         Unreviewed build fix for WebKit/Gtk+.
19
20         RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be
21         guarded by ENABLE(VIDEO), as it is in its header.
22
23         No new tests.
24
25         * platform/gtk/RenderThemeGtk2.cpp:
26
27 2011-01-02  Dan Bernstein  <mitz@apple.com>
28
29         Rubber-stamped by Simon Fraser.
30
31         <rdar://problem/8812159> Update copyright strings
32
33         * Info.plist:
34
35 2011-01-02  Dan Bernstein  <mitz@apple.com>
36
37         Reviewed by Sam Weinig.
38
39         <rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field
40         https://bugs.webkit.org/show_bug.cgi?id=51623
41
42         * editing/Editor.cpp:
43         (WebCore::Editor::countMatchesForText): Actually remember the original search range end
44         container and offset and restore them when needed, instead of using two references to the
45         same Range.
46         * manual-tests/find-count-matches-after-text-control.html: Added.
47
48 2011-01-02  Benjamin Poulain  <benjamin.poulain@nokia.com>
49
50         Reviewed by Csaba Osztrogon√°c.
51
52         WebKit 2 does not build on 64bits with a recent GCC
53         https://bugs.webkit.org/show_bug.cgi?id=51754
54
55         Use explicitely 64 bits types for the attributes of DatabaseDetails.
56
57         * storage/DatabaseDetails.h:
58         (WebCore::DatabaseDetails::expectedUsage):
59         (WebCore::DatabaseDetails::currentUsage):
60
61 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
62
63         Unreviewed WinCE build fix for r74868.
64
65         * platform/graphics/wince/ImageBufferWinCE.cpp:
66         (WebCore::getImageData):
67
68 2011-01-02  Sheriff Bot  <webkit.review.bot@gmail.com>
69
70         Unreviewed, rolling out r74847.
71         http://trac.webkit.org/changeset/74847
72         https://bugs.webkit.org/show_bug.cgi?id=51803
73
74         "Preprocessor guards should be in header files" (Requested by
75         ap on #webkit).
76
77         * bindings/js/JSDOMWindowBase.cpp:
78         * dom/Document.cpp:
79         (WebCore::Document::recalcStyle):
80         * html/HTMLDocument.cpp:
81         * loader/FrameLoader.cpp:
82         * loader/ResourceLoadNotifier.cpp:
83         * page/Chrome.cpp:
84         * page/Console.cpp:
85         * page/ContextMenuController.cpp:
86         * page/DOMWindow.cpp:
87         (WebCore::DOMWindow::dispatchEvent):
88         * page/EventHandler.cpp:
89         * page/Page.cpp:
90         * storage/Database.cpp:
91         * workers/AbstractWorker.cpp:
92         * workers/DefaultSharedWorkerRepository.cpp:
93         * workers/SharedWorker.cpp:
94         * workers/Worker.cpp:
95         * workers/WorkerContext.cpp:
96         * workers/WorkerMessagingProxy.cpp:
97         * xml/XMLHttpRequest.cpp:
98         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
99
100 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
101
102         [CMake] Unreviewed build fix.
103
104         * CMakeLists.txt:
105
106 2011-01-02  Dirk Schulze  <krit@webkit.org>
107
108         Reviewed by Simon Fraser.
109
110         Clarify ImageBuffer and ImageData relationship
111         https://bugs.webkit.org/show_bug.cgi?id=51297
112
113         Remove references to ImageData and CanvasPixelArray from ImageBuffer and SVG filter/masker code,
114         since this was a layering violation, and replaced it by ByteArray.
115
116         No change of functionality, so no new test added.
117
118         * html/ImageData.cpp:
119         (WebCore::ImageData::create):
120         (WebCore::ImageData::ImageData):
121         * html/ImageData.h: Added new constructor with ByteArray input.
122         (WebCore::ImageData::width):
123         (WebCore::ImageData::height):
124         (WebCore::ImageData::data):
125         * html/canvas/CanvasPixelArray.cpp:
126         (WebCore::CanvasPixelArray::create):
127         (WebCore::CanvasPixelArray::CanvasPixelArray):
128         * html/canvas/CanvasPixelArray.h: New conctructor with ByteArray input, used by HTML Canvas.
129         (WebCore::CanvasPixelArray::data):
130         (WebCore::CanvasPixelArray::length):
131         (WebCore::CanvasPixelArray::set):
132         (WebCore::CanvasPixelArray::get):
133         * html/canvas/CanvasRenderingContext2D.cpp:
134         (WebCore::CanvasRenderingContext2D::getImageData):
135         (WebCore::CanvasRenderingContext2D::putImageData):
136         * platform/graphics/ImageBuffer.h:
137         * platform/graphics/cairo/ImageBufferCairo.cpp:
138         (WebCore::getImageData):
139         (WebCore::ImageBuffer::getUnmultipliedImageData):
140         (WebCore::ImageBuffer::getPremultipliedImageData):
141         (WebCore::putImageData):
142         (WebCore::ImageBuffer::putUnmultipliedImageData):
143         (WebCore::ImageBuffer::putPremultipliedImageData):
144         * platform/graphics/cg/ImageBufferCG.cpp:
145         (WebCore::getImageData):
146         (WebCore::ImageBuffer::getUnmultipliedImageData):
147         (WebCore::ImageBuffer::getPremultipliedImageData):
148         (WebCore::putImageData):
149         (WebCore::ImageBuffer::putUnmultipliedImageData):
150         (WebCore::ImageBuffer::putPremultipliedImageData):
151         * platform/graphics/filters/FEBlend.cpp:
152         (WebCore::FEBlend::apply):
153         * platform/graphics/filters/FEColorMatrix.cpp:
154         (WebCore::FEColorMatrix::apply):
155         * platform/graphics/filters/FEComponentTransfer.cpp:
156         (WebCore::FEComponentTransfer::apply):
157         * platform/graphics/filters/FEComposite.cpp:
158         (WebCore::FEComposite::apply):
159         * platform/graphics/filters/FEConvolveMatrix.cpp:
160         (WebCore::setDestinationPixels):
161         (WebCore::FEConvolveMatrix::apply):
162         * platform/graphics/filters/FEConvolveMatrix.h:
163         * platform/graphics/filters/FEDisplacementMap.cpp:
164         (WebCore::FEDisplacementMap::apply):
165         * platform/graphics/filters/FEGaussianBlur.cpp:
166         (WebCore::FEGaussianBlur::apply):
167         * platform/graphics/filters/FELighting.cpp:
168         (WebCore::FELighting::apply):
169         * platform/graphics/filters/FEMorphology.cpp:
170         (WebCore::FEMorphology::apply):
171         * platform/graphics/filters/FETurbulence.cpp:
172         (WebCore::FETurbulence::apply):
173         * platform/graphics/filters/FilterEffect.cpp:
174         (WebCore::FilterEffect::asImageBuffer):
175         (WebCore::FilterEffect::asUnmultipliedImage):
176         (WebCore::FilterEffect::asPremultipliedImage):
177         (WebCore::FilterEffect::copyImageBytes):
178         (WebCore::FilterEffect::copyUnmultipliedImage):
179         (WebCore::FilterEffect::copyPremultipliedImage):
180         (WebCore::FilterEffect::createUnmultipliedImageResult):
181         (WebCore::FilterEffect::createPremultipliedImageResult):
182         * platform/graphics/filters/FilterEffect.h:
183         * platform/graphics/qt/ImageBufferQt.cpp:
184         (WebCore::getImageData):
185         (WebCore::ImageBuffer::getUnmultipliedImageData):
186         (WebCore::ImageBuffer::getPremultipliedImageData):
187         (WebCore::putImageData):
188         (WebCore::ImageBuffer::putUnmultipliedImageData):
189         (WebCore::ImageBuffer::putPremultipliedImageData):
190         * platform/graphics/skia/ImageBufferSkia.cpp:
191         (WebCore::getImageData):
192         (WebCore::ImageBuffer::getUnmultipliedImageData):
193         (WebCore::ImageBuffer::getPremultipliedImageData):
194         (WebCore::putImageData):
195         (WebCore::ImageBuffer::putUnmultipliedImageData):
196         (WebCore::ImageBuffer::putPremultipliedImageData):
197         * platform/graphics/wince/ImageBufferWinCE.cpp:
198         (WebCore::getImageData):
199         (WebCore::ImageBuffer::getUnmultipliedImageData):
200         (WebCore::ImageBuffer::getPremultipliedImageData):
201         (WebCore::putImageData):
202         (WebCore::ImageBuffer::putUnmultipliedImageData):
203         (WebCore::ImageBuffer::putPremultipliedImageData):
204         * platform/graphics/wx/ImageBufferWx.cpp:
205         (WebCore::ImageBuffer::getUnmultipliedImageData):
206         (WebCore::ImageBuffer::getPremultipliedImageData):
207         (WebCore::ImageBuffer::putUnmultipliedImageData):
208         (WebCore::ImageBuffer::putPremultipliedImageData):
209         * rendering/RenderSVGResourceMasker.cpp:
210         (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
211
212 2011-01-01  Adam Barth  <abarth@webkit.org>
213
214         Reviewed by Eric Seidel.
215
216         Move JavaScriptCore to Source
217         https://bugs.webkit.org/show_bug.cgi?id=51604
218
219         Update references to JavaScriptCore.
220
221         * Android.derived.jscbindings.mk:
222         * Android.v8bindings.mk:
223         * CMakeLists.txt:
224         * WebCore.gyp/WebCore.gyp:
225         * WebCore.pro:
226           - These changes are subtle and might not be 100% correct.
227         * move-js-headers.sh:
228
229 2011-01-01  Adam Barth  <abarth@webkit.org>
230
231         Reviewed by Eric Seidel.
232
233         forbid sandboxed frames to call top.close() when allow-same-origin is not setted
234         https://bugs.webkit.org/show_bug.cgi?id=38340
235
236         We now pass the ScriptExecutionContext to window.close so it can find
237         the Frame and check whether navigation is allowed.  This check will
238         almost always pass because you can only close top-level frames, but the
239         check will fail when the calling script is sandboxed.
240
241         Tests: fast/frames/sandboxed-iframe-close-top-noclose.html
242                fast/frames/sandboxed-iframe-close-top.html
243
244         * page/DOMWindow.cpp:
245         (WebCore::DOMWindow::close):
246         * page/DOMWindow.h:
247         * page/DOMWindow.idl:
248
249 2011-01-01  Adam Barth  <abarth@webkit.org>
250
251         Reviewed by Eric Seidel.
252
253         sandbox iframes have access to top.history methods
254         https://bugs.webkit.org/show_bug.cgi?id=38152
255
256         To enforce the sandbox restrictions on History, we need to pass the
257         ScriptExecutionContext to WebCore.  This patch leaves the original
258         History methods in place because they are used directly by folks who
259         don't care about security checks.
260
261         Test: fast/frames/sandboxed-iframe-history-denied.html
262
263         * page/History.cpp:
264         (WebCore::History::back):
265         (WebCore::History::forward):
266         (WebCore::History::go):
267         * page/History.h:
268         * page/History.idl:
269
270 2011-01-01  Adam Barth  <abarth@webkit.org>
271
272         Remove empty file.
273
274         * Android.mk:
275         * CMakeLists.txt:
276         * GNUmakefile.am:
277         * WebCore.gypi:
278         * WebCore.pro:
279         * WebCore.vcproj/WebCore.vcproj:
280         * WebCore.xcodeproj/project.pbxproj:
281         * dom/DOMAllInOne.cpp:
282         * dom/Entity.cpp: Removed.
283
284 2011-01-01  Adam Barth  <abarth@webkit.org>
285
286         Remove empty file.
287
288         * CMakeLists.txt:
289         * GNUmakefile.am:
290         * WebCore.pro:
291         * WebCore.vcproj/WebCore.vcproj:
292         * WebCore.xcodeproj/project.pbxproj:
293         * bindings/js/JSBindingsAllInOne.cpp:
294         * bindings/js/JSPopStateEventCustom.cpp: Removed.
295
296 2011-01-01  Adam Barth  <abarth@webkit.org>
297
298         Remove empty files.
299
300         * GNUmakefile.am:
301         * WebCore.gypi:
302         * WebCore.vcproj/WebCore.vcproj:
303         * WebCore.xcodeproj/project.pbxproj:
304         * bindings/generic/BindingFrame.h: Removed.
305         * bindings/generic/BindingLocation.h: Removed.
306
307 2011-01-01  Konstantin Tokarev  <annulen@yandex.ru>
308
309         Reviewed by Darin Adler.
310
311         Don't include Inspector headers when Inspector is disabled
312         https://bugs.webkit.org/show_bug.cgi?id=51789
313
314         * bindings/js/JSDOMWindowBase.cpp: Include Inspector headers when
315         Inspector is enabled
316         * dom/Document.cpp: Include Inspector headers when
317         Inspector is enabled
318         (WebCore::Document::recalcStyle): Disabled InspectorInstrumentationCookie
319         handling
320         * html/HTMLDocument.cpp: Include Inspector headers when
321         Inspector is enabled
322         * loader/FrameLoader.cpp: Include Inspector headers when
323         Inspector is enabled
324         * loader/ResourceLoadNotifier.cpp: Include Inspector headers when
325         Inspector is enabled
326         * page/Chrome.cpp: Include Inspector headers when
327         Inspector is enabled
328         * page/Console.cpp: Include Inspector headers when
329         Inspector is enabled
330         * page/ContextMenuController.cpp: Include Inspector headers when
331         Inspector is enabled
332         * page/DOMWindow.cpp: Include Inspector headers when
333         Inspector is enabled
334         (WebCore::DOMWindow::dispatchEvent): Disabled InspectorInstrumentationCookie
335         handling
336         * page/EventHandler.cpp: Include Inspector headers when
337         Inspector is enabled
338         * page/Page.cpp: Include Inspector headers when
339         Inspector is enabled
340         * storage/Database.cpp: Include Inspector headers when
341         Inspector is enabled
342         * workers/AbstractWorker.cpp: Include Inspector headers when
343         Inspector is enabled
344         * workers/DefaultSharedWorkerRepository.cpp: Include Inspector headers when
345         Inspector is enabled
346         * workers/SharedWorker.cpp: Include Inspector headers when
347         Inspector is enabled
348         * workers/Worker.cpp: Include Inspector headers when
349         Inspector is enabled
350         * workers/WorkerContext.cpp: Include Inspector headers when
351         Inspector is enabled
352         * workers/WorkerMessagingProxy.cpp: Include Inspector headers when
353         Inspector is enabled
354         * xml/XMLHttpRequest.cpp: Include Inspector headers when
355         Inspector is enabled
356         (WebCore::XMLHttpRequest::callReadyStateChangeListener): Disabled
357         InspectorInstrumentationCookie handling
358
359 2010-12-31  Adam Barth  <abarth@webkit.org>
360
361         Reviewed by Darin Adler.
362
363         fast/loader/about-blank-hash-change.html fails on Chromium
364         https://bugs.webkit.org/show_bug.cgi?id=51788
365
366         I'm unable to reproduce the failure locally, so this patch is slightly
367         speculative.  We need to be slighly more careful how we compare the
368         fragment identifiers for Chromium because Chromium uses a URL parser
369         that is more agressive about canonicalization.
370
371         * page/Location.cpp:
372         (WebCore::Location::setHash):
373
374 2010-12-31  Martin Robinson  <mrobinson@igalia.com>
375
376         Reviewed by Xan Lopez.
377
378         [GTK] Use GLib/GIO API for FileSystemGtk implementation
379         https://bugs.webkit.org/show_bug.cgi?id=51617
380
381         Complete implementation of FileSystem platform code for GLib. This
382         converts remaining API points using POSIX calls to platform-independent
383         GLib calls and fixes other compilation errors.
384
385         No new tests. This code will be tested when an implementation
386         of beginDragWithFiles is complete.
387
388         (WebCore::JSDirectoryEntry::getFile):
389         (WebCore::JSDirectoryEntry::getDirectory):
390         * platform/FileSystem.h: Added forward declarations for GLib types to
391         avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
392         * platform/gtk/FileSystemGtk.cpp:
393         (WebCore::openTemporaryFile): Reimplement using only GLib calls.
394         (WebCore::openFile): Ditto.
395         (WebCore::closeFile): Ditto.
396         (WebCore::seekFile): Added implementation.
397         (WebCore::writeToFile): Reimplement using only GLib calls.
398         (WebCore::readFromFile): Ditto.
399
400 2010-12-31  Darin Adler  <darin@apple.com>
401
402         Reviewed by Dan Bernstein.
403
404         Some renaming and refactoring of form element code
405         https://bugs.webkit.org/show_bug.cgi?id=51784
406
407         * bindings/js/JSHTMLSelectElementCustom.cpp:
408         (WebCore::JSHTMLSelectElement::remove): Call new overload of remove
409         for option elements instead of putting the logic in the binding.
410
411         * html/HTMLButtonElement.cpp:
412         (WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes.
413         (WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to
414         "event" instead of "evt". Also updated for name changes.
415         (WebCore::HTMLButtonElement::isActivatedSubmit): Ditto.
416         (WebCore::HTMLButtonElement::setActivatedSubmit): Ditto.
417         (WebCore::HTMLButtonElement::appendFormData): Ditto.
418         * html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit
419         to match the getter function name. The name still doesn't seem great.
420
421         * html/HTMLFormElement.cpp:
422         (WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes.
423         (WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function
424         instead of m_autocomplete data member.
425         (WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member
426         instead of otherwise-unused isDemoted function.
427         (WebCore::HTMLFormElement::submitImplicitly): Updated for name changes.
428         (WebCore::HTMLFormElement::validateInteractively): Removed code to clear
429         m_insubmit. This is now handled by the caller, prepareForSubmission.
430         (WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for
431         name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission
432         here from validateInteractively. Removed unneeded check of m_doingsubmit
433         boolean before setting it.
434         (WebCore::HTMLFormElement::submit): Factored this function into two.
435         One for JavaScript and one for non-JavaScript. Neither function needs a frame
436         argument, because the question being asked, anyPageIsProcessingUserGesture,
437         is a question asked of an entire page group, not a specific frame or page,
438         so it's not important which is the active frame.
439         (WebCore::HTMLFormElement::submitFromJavaScript): Ditto.
440         (WebCore::HTMLFormElement::reset): Updated for name changes.
441         (WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse
442         acceptAttr and got rid of code to set m_autocomplete.
443         (WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw
444         pointer.
445         (WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer
446         and the vector find function. Added a FIXME about the comment.
447         (WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete
448         function instead of m_autocomplete data member.
449         (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto.
450         (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
451         (WebCore::HTMLFormElement::autoComplete): Ditto.
452         * html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete
453         function. Renamed prepareSubmit to prepareForSubmission. Got rid of the
454         frame argument from the submit function and added a new submitFromJavaScript
455         variant. Removed the unneeded isDemoted function. Changed the return type
456         of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed
457         m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to
458         m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed,
459         m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
460
461         * html/HTMLFormElement.idl: Use the function named submitFromJavaScript
462         instead of using CallWith=DynamicFrame because we don't need to know
463         what frame is calling. If we did, it's not clear that the "dynamic"
464         frame would be the right one anyway.
465
466         * html/HTMLSelectElement.cpp:
467         (WebCore::HTMLSelectElement::remove): Added an overload that takes an option
468         element, since the JavaScript binding supports this.
469         * html/HTMLSelectElement.h: Ditto.
470
471         * html/ImageInputType.cpp:
472         (WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
473         * html/ImageInputType.h: Ditto.
474         * html/SubmitInputType.cpp:
475         (WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
476
477 2010-12-31  Daniel Bates  <dbates@rim.com>
478
479         Reviewed by Darin Adler.
480
481         Pass style for <area> instead of associated <img> when querying whether
482         the theme draws the focus ring for an <area>
483         https://bugs.webkit.org/show_bug.cgi?id=51632
484
485         Fixes an issue where the style for the associated <img> of an <area>
486         was passed when considering whether the theme should draw a focus ring
487         for the <area>. Instead, we should pass the theme the style for the <area>.
488
489         It's not possible to test this at this time since there are no themes
490         that override focus ring drawing for <area>s.
491
492         * rendering/RenderImage.cpp:
493         (WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing()
494         such that it's called with respect to the focused <area>.
495
496 2010-12-31  Darin Adler  <darin@apple.com>
497
498         * WebCore.xcodeproj/project.pbxproj: Added back the language.
499         Developers should be using Xcode 3.2.5 or newer.
500
501 2010-12-31  Adam Barth  <abarth@webkit.org>
502
503         Reviewed by Eric Seidel.
504
505         Move V8 to WebCore Location implementation
506         https://bugs.webkit.org/show_bug.cgi?id=51768
507
508         * bindings/generic/BindingFrame.h:
509         * bindings/generic/BindingLocation.h:
510         * bindings/v8/V8Binding.h:
511         * bindings/v8/V8DOMWindowShell.cpp:
512         (WebCore::V8DOMWindowShell::setLocation):
513         * bindings/v8/V8Utilities.cpp:
514         * bindings/v8/V8Utilities.h:
515         * bindings/v8/custom/V8LocationCustom.cpp:
516         (WebCore::V8Location::hashAccessorSetter):
517         (WebCore::V8Location::hostAccessorSetter):
518         (WebCore::V8Location::hostnameAccessorSetter):
519         (WebCore::V8Location::hrefAccessorSetter):
520         (WebCore::V8Location::pathnameAccessorSetter):
521         (WebCore::V8Location::portAccessorSetter):
522         (WebCore::V8Location::protocolAccessorSetter):
523         (WebCore::V8Location::searchAccessorSetter):
524         (WebCore::V8Location::reloadCallback):
525         (WebCore::V8Location::replaceCallback):
526         (WebCore::V8Location::assignCallback):
527
528 2010-12-31  Yi Shen  <yi.4.shen@nokia.com>
529
530         Reviewed by Eric Seidel.
531
532         Make retrieving extraMediaControlsStyleSheet be page dependent.
533         https://bugs.webkit.org/show_bug.cgi?id=51752
534
535         Use themeForPage to retrieve extraMediaControlsStyleSheet for media
536         controls.
537
538         No new tests because no platform-specific theme implementation uses
539         the passed page pointer yet.
540
541         * css/CSSStyleSelector.cpp:
542         (WebCore::CSSStyleSelector::styleForElement):
543
544 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
545
546         Reviewed by Pavel Feldman.
547
548         Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.
549
550         https://bugs.webkit.org/show_bug.cgi?id=51709
551
552         * inspector/front-end/ResourcesPanel.js:
553         (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
554
555 2010-12-31  Patrick Gansterer  <paroga@webkit.org>
556
557         Unreviewed build fix after r74800.
558
559         * bindings/js/JSDOMWindowCustom.cpp: Add missing header.
560         * bindings/js/JSLocationCustom.cpp: Ditto.
561
562 2010-12-31  Adam Barth  <abarth@webkit.org>
563
564         Rubber-stamped by Eric Seidel.
565
566         Move HTML and XML parser benchmarks into PerformanceTests/Parser
567         https://bugs.webkit.org/show_bug.cgi?id=51772
568
569         Remove the benchmarks folder now that it's empty.  Future benchmarks
570         should go in the PerformanceTests directory.
571
572         * benchmarks: Removed.
573         * benchmarks/parser: Removed.
574         * benchmarks/parser/html-parser.html: Removed.
575         * benchmarks/parser/resources: Removed.
576         * benchmarks/parser/resources/html5.html: Removed.
577         * benchmarks/parser/resources/runner.js: Removed.
578         * benchmarks/parser/xml-parser.html: Removed.
579
580 2010-12-31  Patrick Gansterer  <paroga@webkit.org>
581
582         Reviewed by Adam Barth.
583
584         Add XML parser benchmark
585         https://bugs.webkit.org/show_bug.cgi?id=51612
586
587         Move the JavaScript code of html parser into a separate file to share it with xml parser.
588
589         * benchmarks/parser/html-parser.html:
590         * benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html.
591         (runFunction):
592         (run):
593         (start):
594         * benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
595
596 2010-12-29  Zhenyao Mo  <zmo@google.com>
597
598         Reviewed by Kenneth Russell.
599
600         Update validation of stencil mask and ref values
601         https://bugs.webkit.org/show_bug.cgi?id=50716
602
603         * html/canvas/WebGLRenderingContext.cpp:
604         (WebCore::WebGLRenderingContext::initializeNewContext): Initialize cached stencil settings.
605         (WebCore::WebGLRenderingContext::drawArrays): Validate stencil settings.
606         (WebCore::WebGLRenderingContext::drawElements): Ditto.
607         (WebCore::WebGLRenderingContext::stencilFunc): Cache stencil settings, but generate no error.
608         (WebCore::WebGLRenderingContext::stencilFuncSeparate): Ditto.
609         (WebCore::WebGLRenderingContext::stencilMask): Ditto.
610         (WebCore::WebGLRenderingContext::stencilMaskSeparate): Ditto.
611         (WebCore::WebGLRenderingContext::validateStencilSettings): Helper function to validate stencil settings.
612         * html/canvas/WebGLRenderingContext.h: Declare stencil setting members.
613
614 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
615
616         Reviewed by Xan Lopez.
617
618         [GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3
619         https://bugs.webkit.org/show_bug.cgi?id=51755
620
621         Split out pieces of RenderThemeGtk into RenderThemeGtk2 and RenderThemeGtk3
622         if they are going to differ between GTK+ 2.x and GTK+ 3.x. This is the preliminary
623         step to landing support for the new GTK+ 3.x theming API.
624
625         No new tests. This should not change functionality.
626
627         * GNUmakefile.am: Add RenderThemeGtk2 and RenderThemeGtk3 to the sources list.
628         * platform/gtk/RenderThemeGtk.cpp:
629         (WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the setTextInputBorders static method.
630         (WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto.
631         (WebCore::RenderThemeGtk::paintMediaButton): Ditto.
632         (WebCore::RenderThemeGtk::adjustProgressBarStyle): ditto.
633         * platform/gtk/RenderThemeGtk.h: Make setTextInputBorders a method, so that
634         it can be exist in RenderThemeGtk{2,3} and be called from RenderThemeGtk.
635         * platform/gtk/RenderThemeGtk2.cpp: Added. A fork of the bits of RenderThemeGtk
636         that will eventually be platform-dependent.
637         * platform/gtk/RenderThemeGtk3.cpp: Added. Ditto.
638
639 2010-12-30  Justin Schuh  <jschuh@chromium.org>
640
641         Reviewed by James Robinson.
642
643         Reverting r74292 because it introduced a crash with ruby text.
644         https://bugs.webkit.org/show_bug.cgi?id=51637
645
646         Test: fast/css/counters/counter-ruby-text-cleared.html
647
648         * rendering/RenderCounter.cpp:
649         (WebCore::findPlaceForCounter):
650         * rendering/RenderObject.cpp:
651         (WebCore::RenderObject::addChild):
652         * rendering/RenderObjectChildList.cpp:
653         (WebCore::RenderObjectChildList::appendChildNode):
654         (WebCore::RenderObjectChildList::insertChildNode):
655
656 2010-12-30  Darin Adler  <darin@apple.com>
657
658         Reviewed by David Kilzer.
659
660         Remove unused JSBinding source files
661         https://bugs.webkit.org/show_bug.cgi?id=51762
662
663         * bindings/js/JSBinding.h: Removed.
664         * bindings/js/specialization: Removed.
665         * bindings/js/specialization/JSBindingState.cpp: Removed.
666         * bindings/js/specialization/JSBindingState.h: Removed.
667
668         * CMakeLists.txt: Removed references to files.
669         * GNUmakefile.am: Ditto.
670         * WebCore.gypi: Ditto.
671         * WebCore.pro: Ditto.
672         * WebCore.vcproj/WebCore.vcproj: Ditto.
673         * bindings/js/JSBindingsAllInOne.cpp: Ditto.
674
675 2010-12-30  Tony Gentilcore  <tonyg@chromium.org>
676
677         Reviewed by Darin Adler.
678
679         Remove Document.h include from some headers where it isn't necessary
680         https://bugs.webkit.org/show_bug.cgi?id=51730
681
682         No new tests because no new functionality.
683
684         * editing/EditingStyle.cpp:
685         * editing/EditingStyle.h:
686         * editing/SelectionController.h:
687         * editing/visible_units.h:
688         * html/HTMLAudioElement.h:
689         * html/HTMLBodyElement.h:
690         * inspector/InspectorCSSAgent.h:
691         * inspector/InspectorDOMAgent.h:
692         * inspector/InspectorInstrumentation.h:
693         * xml/DOMParser.cpp:
694         * xml/DOMParser.h:
695         (WebCore::DOMParser::create):
696         (WebCore::DOMParser::DOMParser):
697
698 2010-12-30  Benjamin C Meyer  <bmeyer@rim.com>
699
700         Reviewed by Darin Adler.
701
702         bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
703         which is required when NOTIFICATIONS is enabled.
704
705         https://bugs.webkit.org/show_bug.cgi?id=51761
706
707         * CMakeLists.txt:
708
709 2010-12-30  Antti Koivisto  <antti@apple.com>
710
711         Not reviewed.
712
713         Revert accidental project file change.
714
715         * WebCore.xcodeproj/project.pbxproj:
716
717 2010-12-30  Antti Koivisto  <antti@apple.com>
718
719         Reviewed by Darin Adler.
720
721         https://bugs.webkit.org/show_bug.cgi?id=51134
722         Move loading related code from MemoryCache to CachedResourceLoader
723
724         - Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
725         - Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
726         - Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
727         - Add MemoryCache::add
728         - Refactor the decision on whether to reload, revalidate or use the existing resource to 
729           a single function, CachedResourceLoader::determineRevalidationPolicy
730
731         * css/CSSImageValue.cpp:
732         (WebCore::CSSImageValue::cachedImage):
733             
734             Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
735             if ever taken (since it passes null CachedResourceLoader pointer).
736             
737         * loader/ImageLoader.cpp:
738         (WebCore::ImageLoader::updateFromElement):
739         * loader/cache/CachedImage.cpp:
740         * loader/cache/CachedResource.cpp:
741         (WebCore::CachedResource::CachedResource):
742         (WebCore::CachedResource::~CachedResource):
743         (WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
744         
745             Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.
746         
747         (WebCore::CachedResource::setLoadPriority):
748         
749             Check for Unresolved value before setting.
750         
751         * loader/cache/CachedResource.h:
752         (WebCore::CachedResource::setOwningCachedResourceLoader):
753         
754             Rename to be bit less mysterious.
755         
756         * loader/cache/CachedResourceLoader.cpp:
757         (WebCore::createResource):
758         
759             This was moved from MemoryCache.
760         
761         (WebCore::CachedResourceLoader::~CachedResourceLoader):
762         (WebCore::CachedResourceLoader::determineRevalidationPolicy):
763         (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
764         
765             This was moved/merged from MemoryCache.
766         
767         (WebCore::CachedResourceLoader::canRequest):
768         (WebCore::CachedResourceLoader::requestResource):
769         
770             This combines MemoryCache::requestResource and the existing method.
771         
772         (WebCore::CachedResourceLoader::revalidateResource):
773         
774             This was moved from MemoryCache.
775         
776         (WebCore::CachedResourceLoader::loadResource):
777         
778             New method for initiating loading.
779         
780         (WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):
781         
782             Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus
783         
784         * loader/cache/CachedResourceLoader.h:
785         * loader/cache/MemoryCache.cpp:
786         (WebCore::MemoryCache::add):
787         * loader/cache/MemoryCache.h:
788         (WebCore::MemoryCache::remove):
789
790 2010-12-30  Steve Block  <steveblock@google.com>
791
792         Reviewed by Gavin Barraclough.
793
794         Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
795         https://bugs.webkit.org/show_bug.cgi?id=51740
796
797         This is a policy decision for Android.
798
799         No new tests, simply enabling existing, tested code on Android.
800
801         * bindings/js/JSDOMWindowBase.cpp:
802         (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
803
804 2010-12-30  Yael Aharon  <yael.aharon@nokia.com>
805
806         Reviewed by Adam Barth.
807
808         REGRESSION: fast/dom/cssTarget-crash.html fails
809         https://bugs.webkit.org/show_bug.cgi?id=20342
810
811         Do not reload the page when submitting a form, using "GET" method, and the
812         form action url matches the location url, except for the fragment.
813       
814         Test: fast/forms/submit-change-fragment.html
815
816         * loader/FrameLoader.cpp:
817         (WebCore::FrameLoader::loadURL):
818         (WebCore::FrameLoader::loadWithDocumentLoader):
819         (WebCore::FrameLoader::shouldScrollToAnchor):
820         * loader/FrameLoader.h:
821
822 2010-12-30  Darin Adler  <darin@apple.com>
823
824         Reviewed by Adam Barth.
825
826         Move security logic out of the JavaScript binding for location into the DOM class
827         https://bugs.webkit.org/show_bug.cgi?id=51714
828
829         * WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h,
830         and JSBinding.h. Later, we'll remove them from other project files and delete
831         the source files.
832
833         * bindings/js/JSBinding.h: Emptied out, marked for later deletion.
834
835         * bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull
836         function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL
837         function, unused toLexicalFrame function, unused completeURL function, unused
838         getCachedDOMStructure and cacheDOMStructure overloads, and unused
839         getCachedDOMConstructor and cacheDOMConstruction functions.
840         (WebCore::activeDOMWindow): Added.
841         (WebCore::firstDOMWindow): Added.
842         (WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through
843         JSBindingState, since the latter is an unneeded abstraction.
844         (WebCore::processingUserGesture): Changed to call ScriptController's function
845         rather than calling through JSBindingState, which is an unneeded abstraction
846
847         * bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added
848         activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly
849         named allowsAccessFromFrame functions, which answer the question of whether
850         script is allowed access *to* a frame.
851
852         * bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes.
853         (WebCore::JSDOMWindow::setLocation): Streamlined by using the new
854         activeDOMWindow and firstDOMWindow functions.
855         (WebCore::JSDOMWindow::open): Ditto.
856         (WebCore::JSDOMWindow::showModalDialog): Ditto.
857         (WebCore::JSDOMWindow::postMessage): Ditto.
858
859         * bindings/js/JSLocationCustom.cpp:
860         (WebCore::JSLocation::setHref): Changed to pass the active and first windows through
861         to the Location::setHref function, with it doing the rest of the work. This moves
862         work out of the DOM binding that belongs in the DOM itself. Eventually such functions
863         could even be automatically generated by the bindings script.
864         (WebCore::JSLocation::setProtocol): Ditto.
865         (WebCore::JSLocation::setHost): Ditto.
866         (WebCore::JSLocation::setHostname): Ditto.
867         (WebCore::JSLocation::setPort): Ditto.
868         (WebCore::JSLocation::setPathname): Ditto.
869         (WebCore::JSLocation::setSearch): Ditto.
870         (WebCore::JSLocation::setHash): Ditto.
871         (WebCore::JSLocation::replace): Ditto.
872         (WebCore::JSLocation::reload): Ditto.
873         (WebCore::JSLocation::assign): Ditto.
874
875         * bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
876         * bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
877
878         * page/DOMWindow.cpp:
879         (WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us
880         to use this function for Location::replace, which is the same as setLocation except that
881         it locks both history and the back/forward list.
882         * page/DOMWindow.h: Ditto.
883
884         * page/Location.cpp:
885         (WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security
886         logic there does not have to be repeated or even refactored.
887         (WebCore::Location::setProtocol): Ditto.
888         (WebCore::Location::setHost): Ditto.
889         (WebCore::Location::setHostname): Ditto.
890         (WebCore::Location::setPort): Ditto.
891         (WebCore::Location::setPathname): Ditto.
892         (WebCore::Location::setSearch): Ditto.
893         (WebCore::Location::setHash): Ditto.
894         (WebCore::Location::assign): Ditto.
895         (WebCore::Location::replace): Ditto.
896         (WebCore::Location::reload): Added. Security logic was refactored from the code in
897         JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems
898         possibly unneeded.
899
900         * page/Location.h: Fixed indentation on the whole file. Added the new functions above.
901         (WebCore::Location::create):
902         (WebCore::Location::frame):
903
904 2010-12-30  Alexander Pavlov  <apavlov@chromium.org>
905
906         Reviewed by Pavel Feldman.
907
908         Web Inspector: Pasting a style property with value should automatically split it into prop/value
909         https://bugs.webkit.org/show_bug.cgi?id=51581
910
911         The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
912         of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
913         and the edit focus is transferred to the value field.
914
915         * inspector/front-end/StylesSidebarPane.js:
916         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
917         (WebInspector.StylePropertyTreeElement.prototype):
918         * inspector/front-end/inspector.js:
919         (WebInspector.completeURL): Drive-by: return full URLs as-is.
920         (WebInspector.startEditing.cleanUpAfterEditing):
921         (WebInspector.startEditing):
922         (WebInspector.startEditing.pasteEventListener):
923         (WebInspector.startEditing.keyDownEventListener):
924
925 2010-12-30  Pavel Podivilov  <podivilov@chromium.org>
926
927         Reviewed by Pavel Feldman.
928
929         Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
930         https://bugs.webkit.org/show_bug.cgi?id=51745
931
932         * inspector/front-end/Breakpoint.js:
933         (WebInspector.Breakpoint.prototype.set enabled):
934
935 2010-12-30  Pavel Podivilov  <podivilov@chromium.org>
936
937         Reviewed by Pavel Feldman.
938
939         Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
940         https://bugs.webkit.org/show_bug.cgi?id=51748
941
942         * inspector/front-end/CallStackSidebarPane.js:
943         (WebInspector.CallStackSidebarPane.prototype.update):
944         (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
945         (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
946         (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
947
948 2010-12-30  Mikhail Naganov  <mnaganov@chromium.org>
949
950         Reviewed by Pavel Feldman.
951
952         Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).
953
954         https://bugs.webkit.org/show_bug.cgi?id=51713
955
956         * WebCore.gypi:
957         * WebCore.pro:
958         * bindings/v8/custom/V8ConsoleCustom.cpp:
959         (WebCore::V8Console::memoryAccessorGetter):
960         * bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp.
961         (WebCore::V8Performance::memoryAccessorGetter):
962         * page/Console.idl:
963         * page/Performance.idl:
964
965 2010-12-30  Steve Block  <steveblock@google.com>
966
967         Reviewed by Sam Weinig.
968
969         Visiting macnn.com often causes SQL spew via geolocation database
970         https://bugs.webkit.org/show_bug.cgi?id=51557
971
972         If the Geolocation position cache database path has not been set, early-out
973         rather than using an empty path and thus failing to open the database.
974         This avoids SQL log spew.
975
976         Also, avoid starting the database thread until the path has been set, and
977         shorten the thread name to avoid warnings due to exceeding 30 characters.
978
979         No new tests, implementation clean-up only.
980
981         * page/GeolocationPositionCache.cpp:
982         (WebCore::GeolocationPositionCache::addUser):
983         (WebCore::GeolocationPositionCache::removeUser):
984         (WebCore::GeolocationPositionCache::setDatabasePath):
985         (WebCore::GeolocationPositionCache::startBackgroundThread):
986
987 2010-12-29  Philippe Normand  <pnormand@igalia.com>
988
989         Reviewed by Martin Robinson.
990
991         [GTK] minimal build fails at link time due to missing sqlite3 symbols
992         https://bugs.webkit.org/show_bug.cgi?id=51327
993
994         Guard the code calling sqlite3 with the ENABLE(DATABASE) check.
995
996         No new tests, build fix only.
997
998         * platform/sql/SQLiteAuthorizer.cpp:
999         * platform/sql/SQLiteDatabase.cpp:
1000         * platform/sql/SQLiteFileSystem.cpp:
1001         * platform/sql/SQLiteStatement.cpp:
1002         * platform/sql/SQLiteTransaction.cpp:
1003
1004 2010-12-30  Justin Schuh  <jschuh@chromium.org>
1005
1006         Reviewed by Dirk Schulze.
1007
1008         Prevent stringToLengthType() from skipping past end-of-string on invalid length unit. 
1009         https://bugs.webkit.org/show_bug.cgi?id=51692
1010
1011         * svg/SVGLength.cpp:
1012         (WebCore::stringToLengthType):
1013         (WebCore::SVGLength::setValueAsString):
1014
1015 2010-12-30  Abhishek Arya  <inferno@chromium.org>
1016
1017         Reviewed by Eric Seidel.
1018
1019         Create a helper function for finding descendent video elements for a node.
1020         https://bugs.webkit.org/show_bug.cgi?id=51696
1021
1022         Test: media/video-element-other-namespace-crash.html
1023
1024         * html/MediaDocument.cpp:
1025         (WebCore::descendentVideoElement): helper function.
1026         (WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions.
1027         (WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.
1028
1029 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
1030
1031         Reviewed by Yury Semikhatsky.
1032
1033         Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
1034         https://bugs.webkit.org/show_bug.cgi?id=51707
1035
1036         This change brushes up storage agents + removes redundant InspectorBackend class.
1037
1038         * CMakeLists.txt:
1039         * GNUmakefile.am:
1040         * WebCore.gypi:
1041         * WebCore.pro:
1042         * WebCore.vcproj/WebCore.vcproj:
1043         * WebCore.xcodeproj/project.pbxproj:
1044         * inspector/CodeGeneratorInspector.pm:
1045         * inspector/InjectedScriptHost.cpp:
1046         (WebCore::InjectedScriptHost::databaseForId):
1047         (WebCore::InjectedScriptHost::selectDatabase):
1048         (WebCore::InjectedScriptHost::selectDOMStorage):
1049         (WebCore::InjectedScriptHost::inspectorDOMAgent):
1050         * inspector/Inspector.idl:
1051         * inspector/InspectorBackend.cpp: Removed.
1052         * inspector/InspectorBackend.h: Removed.
1053         * inspector/InspectorController.cpp:
1054         (WebCore::InspectorController::InspectorController):
1055         (WebCore::InspectorController::~InspectorController):
1056         (WebCore::InspectorController::connectFrontend):
1057         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
1058         (WebCore::InspectorController::didUseDOMStorage):
1059         (WebCore::InspectorController::setInjectedScriptSource):
1060         (WebCore::InspectorController::dispatchOnInjectedScript):
1061         (WebCore::InspectorController::releaseWrapperObjectGroup):
1062         * inspector/InspectorController.h:
1063         * inspector/InspectorDOMStorageAgent.cpp: Added.
1064         (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
1065         (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
1066         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
1067         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
1068         (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
1069         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
1070         (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
1071         * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
1072         (WebCore::InspectorDOMStorageAgent::create):
1073         (WebCore::InspectorDOMStorageAgent::frontend):
1074         * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
1075         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
1076         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
1077         (WebCore::InspectorDatabaseAgent::executeSQL):
1078         (WebCore::InspectorDatabaseAgent::databaseForId):
1079         (WebCore::InspectorDatabaseAgent::selectDatabase):
1080         (WebCore::InspectorDatabaseAgent::clearFrontend):
1081         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
1082         * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
1083         (WebCore::InspectorDatabaseAgent::create):
1084         (WebCore::InspectorDatabaseAgent::frontend):
1085         * inspector/front-end/ScriptsPanel.js:
1086         (WebInspector.ScriptsPanel.prototype.show):
1087         (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
1088         (WebInspector.ScriptsPanel.prototype._toggleDebugging):
1089
1090 2010-12-29  Dirk Schulze  <krit@webkit.org>
1091
1092         Reviewed by Darin Adler.
1093
1094         Cleanup SVG code according to the webkit style rules 3
1095         https://bugs.webkit.org/show_bug.cgi?id=51490
1096
1097         Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
1098         Just one file can't be fixed for check-webkit-style.
1099         * SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning
1100
1101         No changes of functionality, so no new tests. 
1102
1103         * svg/SVGAllInOne.cpp:
1104         * svg/SVGImage.cpp:
1105         * svg/SVGLength.cpp:
1106         (WebCore::SVGLength::setValue):
1107         * svg/SVGPolygonElement.h:
1108         * svg/SVGPolylineElement.h:
1109         * svg/SVGPreserveAspectRatio.cpp:
1110         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
1111         (WebCore::SVGPreserveAspectRatio::transformRect):
1112         * svg/SVGSVGElement.cpp:
1113         (WebCore::SVGSVGElement::viewport):
1114         * svg/SVGSetElement.h:
1115         * svg/SVGStylable.h:
1116         (WebCore::SVGStylable::~SVGStylable):
1117         * svg/SVGStyledLocatableElement.h:
1118         (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
1119         (WebCore::SVGStyledLocatableElement::isStyledLocatable):
1120         * svg/SVGStyledTransformableElement.cpp:
1121         (WebCore::SVGStyledTransformableElement::isKnownAttribute):
1122         * svg/SVGSwitchElement.cpp:
1123         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
1124         * svg/SVGTests.cpp:
1125         (WebCore::SVGTests::parseMappedAttribute):
1126         * svg/SVGTextContentElement.cpp:
1127         (WebCore::SVGTextContentElement::isKnownAttribute):
1128         * svg/SVGTextPathElement.cpp:
1129         * svg/SVGTextPathElement.h:
1130         * svg/SVGTitleElement.h:
1131         (WebCore::SVGTitleElement::rendererIsNeeded):
1132         * svg/SVGTransformDistance.cpp:
1133         (WebCore::SVGTransformDistance::SVGTransformDistance):
1134         (WebCore::SVGTransformDistance::scaledDistance):
1135         (WebCore::SVGTransformDistance::addSVGTransforms):
1136         (WebCore::SVGTransformDistance::addSVGTransform):
1137         (WebCore::SVGTransformDistance::addToSVGTransform):
1138         (WebCore::SVGTransformDistance::isZero):
1139         * svg/SVGTransformList.cpp:
1140         * svg/SVGURIReference.cpp:
1141         (WebCore::SVGURIReference::getTarget):
1142         * svg/SVGVKernElement.h:
1143         * svg/SVGViewSpec.cpp:
1144         (WebCore::SVGViewSpec::parseViewSpec):
1145         * svg/SVGZoomAndPan.h:
1146         (WebCore::SVGZoomAndPan::SVGZoomAndPan):
1147         (WebCore::SVGZoomAndPan::~SVGZoomAndPan):
1148         (WebCore::SVGZoomAndPan::zoomAndPan):
1149         * svg/SVGZoomEvent.h:
1150         (WebCore::SVGZoomEvent::create):
1151         * svg/animation/SMILTime.cpp:
1152         (WebCore::operator*):
1153         * svg/animation/SMILTime.h:
1154         (WebCore::SMILTime::SMILTime):
1155         (WebCore::SMILTime::unresolved):
1156         (WebCore::SMILTime::indefinite):
1157         (WebCore::SMILTime::operator=):
1158         (WebCore::SMILTime::value):
1159         (WebCore::SMILTime::isFinite):
1160         (WebCore::SMILTime::isIndefinite):
1161         (WebCore::SMILTime::isUnresolved):
1162         (WebCore::operator==):
1163         (WebCore::operator!): new operator checks for 0 or infinite values.
1164         (WebCore::operator!=):
1165         (WebCore::operator>):
1166         (WebCore::operator<):
1167         (WebCore::operator>=):
1168         (WebCore::operator<=):
1169         * svg/animation/SMILTimeContainer.h:
1170         (WebCore::SMILTimeContainer::create):
1171         (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
1172         * svg/animation/SVGSMILElement.cpp:
1173         (WebCore::ConditionEventListener::operator==):
1174         (WebCore::SVGSMILElement::repeatingDuration):
1175         (WebCore::SVGSMILElement::resolveInterval):
1176         (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
1177         * svg/animation/SVGSMILElement.h:
1178         (WebCore::SVGSMILElement::timeContainer):
1179         (WebCore::SVGSMILElement::intervalBegin):
1180         (WebCore::SVGSMILElement::intervalEnd):
1181         (WebCore::SVGSMILElement::previousIntervalBegin):
1182         (WebCore::SVGSMILElement::documentOrderIndex):
1183         (WebCore::SVGSMILElement::setDocumentOrderIndex):
1184         * svg/graphics/SVGImage.h:
1185         (WebCore::SVGImage::create):
1186         (WebCore::SVGImage::destroyDecodedData):
1187         (WebCore::SVGImage::decodedSize):
1188         (WebCore::SVGImage::frameAtIndex):
1189         * svg/graphics/filters/SVGFilterBuilder.h:
1190         (WebCore::SVGFilterBuilder::create):
1191         (WebCore::SVGFilterBuilder::lastEffect):
1192         (WebCore::SVGFilterBuilder::getEffectReferences):
1193         (WebCore::SVGFilterBuilder::addBuiltinEffects):
1194
1195 2010-12-29  Abhishek Arya  <inferno@chromium.org>
1196
1197         Reviewed by Darin Adler.
1198
1199         ASSERT(oldchild->parent() == owner) fails.
1200         https://bugs.webkit.org/show_bug.cgi?id=50480
1201
1202         In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
1203         is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
1204         assertion failure when removeChildNode executes on the child(equal to prev or next).
1205         Fix a typo in canMergeContiguousAnonymousBlocks.
1206
1207         Test: fast/multicol/span/double-merge-anonymous-block-crash.html
1208
1209         * rendering/RenderBlock.cpp:
1210         (WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next.
1211         (WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.
1212
1213 2010-12-29  Justin Schuh  <jschuh@chromium.org>
1214
1215         Reviewed by Darin Adler.
1216
1217         Check SVG element type in FrameView::scrollToAnchor
1218         https://bugs.webkit.org/show_bug.cgi?id=51718
1219
1220         Test: svg/custom/scroll-to-anchor-in-symbol.svg
1221
1222         * page/FrameView.cpp:
1223         (WebCore::FrameView::scrollToAnchor):
1224
1225 2010-12-29  Anton Muhin  <antonm@chromium.org>
1226
1227         Reviewed by Eric Seidel.
1228
1229         [v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
1230         https://bugs.webkit.org/show_bug.cgi?id=51704
1231
1232         * bindings/v8/V8DOMWindowShell.cpp:
1233         * bindings/v8/V8DOMWindowShell.h:
1234
1235 2010-12-29  Kenichi Ishibashi  <bashi@google.com>
1236
1237         Reviewed by Darin Adler.
1238
1239         Use a HashMap for m_continuation to save memory
1240         https://bugs.webkit.org/show_bug.cgi?id=43716
1241
1242         Saving memory consumption by applying a HashMap convention to
1243         continuation pointers of RenderInline and RenderBlock classes.
1244
1245         * rendering/RenderBlock.cpp: Removed m_continuation.
1246         (WebCore::RenderBlock::RenderBlock):
1247         (WebCore::RenderBlock::destroy):
1248         (WebCore::RenderBlock::inlineElementContinuation):
1249         (WebCore::RenderBlock::blockElementContinuation):
1250         * rendering/RenderBlock.h: Removed m_continuation.
1251         * rendering/RenderBoxModelObject.cpp: Added a hash map for continuations.
1252         (WebCore::RenderBoxModelObject::destroy): Added an assertion.
1253         (WebCore::RenderBoxModelObject::continuation): Added.
1254         (WebCore::RenderBoxModelObject::setContinuation): Added.
1255         * rendering/RenderBoxModelObject.h:
1256         * rendering/RenderInline.cpp: Removed m_continuation.
1257         (WebCore::RenderInline::RenderInline):
1258         (WebCore::RenderInline::destroy):
1259         (WebCore::RenderInline::inlineElementContinuation):
1260         * rendering/RenderInline.h: Removed m_continuation.
1261
1262 2010-12-27  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
1263
1264         Reviewed by Martin Robinson.
1265
1266         [GTK] Enable building whatever already exists of WebKit2
1267         https://bugs.webkit.org/show_bug.cgi?id=37369
1268
1269         No new functionality added or deleted. Only makefile change. Hence, no tests added.
1270
1271         * GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and
1272         added them to WebKit/gtk/GNUmakefile.am
1273         * platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h>
1274         and declare WEBKIT_API directly
1275
1276 2010-12-29  Eric Seidel  <eric@webkit.org>
1277
1278         Unreviewed.
1279
1280         Simplify make-hash-tools.pl
1281         https://bugs.webkit.org/show_bug.cgi?id=49922
1282
1283         Added HashTools.h to the project file now that its not autogenerated.
1284         I also sorted the project file using sort-xcode-project-file
1285
1286         * WebCore.xcodeproj/project.pbxproj:
1287
1288 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
1289
1290         Not reviewed: revert r74755 and 74757.
1291
1292 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1293
1294         Reviewed by Sam Weinig.
1295
1296         JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
1297         https://bugs.webkit.org/show_bug.cgi?id=51722
1298
1299         Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
1300         methods the fastcall calling convention, which leads to runtime errors when they are
1301         called from C++. Also remove a bit of unnecessary code duplication.
1302
1303         No new tests. This is covered by fast/canvas/webgl/data-view-test.html.
1304
1305         * bindings/js/JSDataViewCustom.cpp:
1306         (WebCore::getDataViewMember): Remove duplicated code.
1307         (WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL.
1308         (WebCore::JSDataView::getUint8): Ditto.
1309         (WebCore::JSDataView::getFloat32): Ditto.
1310         (WebCore::JSDataView::getFloat64): Ditto.
1311         (WebCore::setDataViewMember): Remove duplicated code.
1312         (WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL.
1313         (WebCore::JSDataView::setUint8): Ditto.
1314
1315 2010-12-29  Dan Bernstein  <mitz@apple.com>
1316
1317         Reviewed by Kenneth Russel.
1318
1319         A more robust fix for https://bugs.webkit.org/show_bug.cgi?id=51681
1320
1321         * html/HTMLCanvasElement.cpp:
1322         (WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
1323         CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
1324         attach-type style recalc.
1325         * html/HTMLCanvasElement.h:
1326         * html/canvas/CanvasRenderingContext2D.cpp:
1327         (WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
1328         r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
1329         (WebCore::CanvasRenderingContext2D::accessFont): Added a call to
1330         Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
1331         and update the font if it is invalid.
1332         * platform/graphics/Font.h:
1333         (WebCore::Font::loadingCustomFonts): Made this private.
1334
1335 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
1336
1337         Not reviewed: Qt build fix.
1338
1339         * inspector/InspectorController.cpp:
1340
1341 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
1342
1343         Reviewed by Yury Semikhatsky.
1344
1345         Web Inspector: extract Database & DOM Storage
1346         agents; remove InspectorBackend.
1347         https://bugs.webkit.org/show_bug.cgi?id=51707
1348
1349         This change brushes up storage agents + removes redundant
1350         InspectorBackend class.
1351
1352         * CMakeLists.txt:
1353         * GNUmakefile.am:
1354         * WebCore.gypi:
1355         * WebCore.pro:
1356         * WebCore.vcproj/WebCore.vcproj:
1357         * WebCore.xcodeproj/project.pbxproj:
1358         * inspector/CodeGeneratorInspector.pm:
1359         * inspector/InjectedScriptHost.cpp:
1360         (WebCore::InjectedScriptHost::databaseForId):
1361         (WebCore::InjectedScriptHost::selectDatabase):
1362         (WebCore::InjectedScriptHost::selectDOMStorage):
1363         (WebCore::InjectedScriptHost::inspectorDOMAgent):
1364         * inspector/Inspector.idl:
1365         * inspector/InspectorBackend.cpp: Removed.
1366         * inspector/InspectorBackend.h: Removed.
1367         * inspector/InspectorController.cpp:
1368         (WebCore::InspectorController::InspectorController):
1369         (WebCore::InspectorController::~InspectorController):
1370         (WebCore::InspectorController::connectFrontend):
1371         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
1372         (WebCore::InspectorController::didUseDOMStorage):
1373         (WebCore::InspectorController::setInjectedScriptSource):
1374         (WebCore::InspectorController::dispatchOnInjectedScript):
1375         (WebCore::InspectorController::releaseWrapperObjectGroup):
1376         * inspector/InspectorController.h:
1377         * inspector/InspectorDOMStorageAgent.cpp: Added.
1378         (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
1379         (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
1380         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
1381         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
1382         (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
1383         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
1384         (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
1385         * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
1386         (WebCore::InspectorDOMStorageAgent::create):
1387         (WebCore::InspectorDOMStorageAgent::frontend):
1388         * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
1389         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
1390         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
1391         (WebCore::InspectorDatabaseAgent::executeSQL):
1392         (WebCore::InspectorDatabaseAgent::databaseForId):
1393         (WebCore::InspectorDatabaseAgent::selectDatabase):
1394         (WebCore::InspectorDatabaseAgent::clearFrontend):
1395         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
1396         * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
1397         (WebCore::InspectorDatabaseAgent::create):
1398         (WebCore::InspectorDatabaseAgent::frontend):
1399         * inspector/InspectorFrontendClientLocal.cpp:
1400         * inspector/InspectorFrontendClientLocal.h:
1401         * inspector/front-end/ScriptsPanel.js:
1402         (WebInspector.ScriptsPanel.prototype.show):
1403
1404 2010-12-29  Tony Gentilcore  <tonyg@chromium.org>
1405
1406         Reviewed by Eric Seidel.
1407
1408         Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
1409         https://bugs.webkit.org/show_bug.cgi?id=51067
1410
1411         Typically when a script element is removed from the document, the cached script
1412         client is removed. However, during the before load event, the cached script client
1413         hasn't been created yet so it can't be removed.
1414
1415         This patch handles that case by explicitly checking if the script element was
1416         removed during the beforeload event. Also, it avoids caching the Document references
1417         over the arbitrary script execution in the before load event.
1418
1419         Test: fast/dom/HTMLScriptElement/move-in-beforeload.html
1420               fast/dom/HTMLScriptElement/remove-in-beforeload.html
1421
1422         * dom/ScriptElement.cpp:
1423         (WebCore::ScriptElement::requestScript):
1424
1425 2010-12-29  Alexander Pavlov  <apavlov@chromium.org>
1426
1427         Reviewed by Yury Semikhatsky.
1428
1429         Web Inspector: Element highlight tooltip displays wrong element size when zoomed in
1430         https://bugs.webkit.org/show_bug.cgi?id=51703
1431
1432         * inspector/InspectorController.cpp:
1433         (WebCore::InspectorController::drawElementTitle):
1434
1435 2010-12-29  Yael Aharon  <yael.aharon@nokia.com>
1436
1437         Reviewed by Kent Tamura.
1438
1439         [HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
1440         https://bugs.webkit.org/show_bug.cgi?id=29071
1441
1442         Use InputType::rangeUnderflow() and InputType::rangeOverflow()
1443         to determine if a control is in-range or out-of-range.
1444
1445         Tests: fast/css/pseudo-in-range-invalid-value.html
1446                fast/css/pseudo-in-range.html
1447                fast/css/pseudo-out-of-range.html
1448
1449         * css/CSSSelector.cpp:
1450         (WebCore::CSSSelector::pseudoId):
1451         (WebCore::nameToPseudoTypeMap):
1452         (WebCore::CSSSelector::extractPseudoType):
1453         * css/CSSSelector.h:
1454         * css/CSSStyleSelector.cpp:
1455         (WebCore::CSSStyleSelector::canShareStyleWithElement):
1456         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
1457         * dom/Element.h:
1458         (WebCore::Element::isInRange):
1459         (WebCore::Element::isOutOfRange):
1460         * html/BaseDateAndTimeInputType.cpp:
1461         (WebCore::BaseDateAndTimeInputType::supportsRangeLimitation):
1462         * html/BaseDateAndTimeInputType.h:
1463         * html/HTMLInputElement.cpp:
1464         (WebCore::HTMLInputElement::isInRange):
1465         (WebCore::HTMLInputElement::isOutOfRange):
1466         * html/HTMLInputElement.h:
1467         * html/InputType.cpp:
1468         (WebCore::InputType::supportsRangeLimitation):
1469         * html/InputType.h:
1470         * html/NumberInputType.cpp:
1471         (WebCore::NumberInputType::supportsRangeLimitation):
1472         * html/NumberInputType.h:
1473         * html/RangeInputType.cpp:
1474         (WebCore::RangeInputType::supportsRangeLimitation):
1475         * html/RangeInputType.h:
1476
1477 2010-12-29  Abhishek Arya  <inferno@chromium.org>
1478
1479         Reviewed by Eric Seidel.
1480
1481         When cloning an anonymous block, make sure to set the childrenInline flag based
1482         on the state of the block to be cloned.
1483         https://bugs.webkit.org/show_bug.cgi?id=51489
1484
1485         Test: fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html
1486
1487         * rendering/RenderBlock.cpp:
1488         (WebCore::RenderBlock::clone): add code to handle cloning of anonymous blocks.
1489         (WebCore::RenderBlock::splitBlocks): remove anonymous block creation calls since it is now handled by clone().
1490
1491 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1492
1493         Unreviewed build fix for WinCE after r73802.
1494
1495         Reapply parts from r72585:
1496         Port ContextMenuWin.cpp to WinCE
1497         https://bugs.webkit.org/show_bug.cgi?id=48408
1498
1499         * CMakeLists.txt:
1500         * platform/ContextMenu.h:
1501         * platform/win/ContextMenuWin.cpp:
1502         (WebCore::ContextMenu::getContextMenuItems):
1503         (WebCore::ContextMenu::createNativeMenuFromItems):
1504
1505 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1506
1507         Reviewed by Simon Hausmann.
1508
1509         [Qt] Fix compilation with Qt in namespace
1510         https://bugs.webkit.org/show_bug.cgi?id=51701
1511
1512         * platform/graphics/ContextShadow.h:
1513         * platform/graphics/GraphicsContext3D.h:
1514         * platform/network/NetworkingContext.h:
1515         * platform/network/qt/QtNAMThreadSafeProxy.h:
1516         * plugins/PluginView.h:
1517
1518 2010-12-28  Alexander Pavlov  <apavlov@chromium.org>
1519
1520         Reviewed by Pavel Feldman.
1521
1522         Web Inspector: A disabled style property should get enabled when edited
1523         https://bugs.webkit.org/show_bug.cgi?id=51679
1524
1525         Test: inspector/styles-disable-then-change.html
1526
1527         * inspector/front-end/CSSStyleModel.js:
1528         (WebInspector.CSSProperty.prototype.setText):
1529         (WebInspector.CSSProperty.prototype.setText.callback):
1530
1531 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1532
1533         Reviewed by Andreas Kling.
1534
1535         [CMake] Remove WebKitGenerators
1536         https://bugs.webkit.org/show_bug.cgi?id=50445
1537
1538         * CMakeLists.txt: Pass preprocessor to generate-bindings.pl.
1539
1540 2010-12-28  Pratik Solanki  <psolanki@apple.com>
1541
1542         Reviewed by Eric Seidel.
1543
1544         https://bugs.webkit.org/show_bug.cgi?id=51522
1545         Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()
1546
1547         * page/win/FrameCGWin.cpp:
1548         (WebCore::imageFromRect):
1549         * platform/graphics/cg/GradientCG.cpp:
1550         (WebCore::Gradient::platformGradient):
1551         * platform/graphics/cg/GraphicsContext3DCG.cpp:
1552         (WebCore::GraphicsContext3D::paintToCanvas):
1553         * platform/graphics/cg/ImageCG.cpp:
1554         (WebCore::BitmapImage::checkForSolidColor):
1555         * platform/graphics/gstreamer/ImageGStreamerCG.mm:
1556         (ImageGStreamer::ImageGStreamer):
1557         * platform/graphics/win/GraphicsContextCGWin.cpp:
1558         (WebCore::CGContextWithHDC):
1559         (WebCore::GraphicsContext::releaseWindowsContext):
1560         (WebCore::GraphicsContext::drawWindowsBitmap):
1561         * platform/graphics/win/ImageCGWin.cpp:
1562         (WebCore::BitmapImage::create):
1563         (WebCore::BitmapImage::getHBITMAPOfSize):
1564         * platform/image-decoders/cg/ImageDecoderCG.cpp:
1565         (WebCore::createColorSpace):
1566         * platform/win/DragImageCGWin.cpp:
1567         (WebCore::allocImage):
1568         (WebCore::createCgContextFromBitmap):
1569         * rendering/RenderThemeMac.mm:
1570         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
1571         (WebCore::RenderThemeMac::paintSliderTrack):
1572         * rendering/RenderThemeSafari.cpp:
1573         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
1574         (WebCore::RenderThemeSafari::paintSliderTrack):
1575
1576 2010-12-28  Daniel Bates  <dbates@rim.com>
1577
1578         Reviewed by Sam Weinig.
1579
1580         Substitute // MARK: for compiler-specific #pragma mark
1581         https://bugs.webkit.org/show_bug.cgi?id=51657
1582
1583         Fix compilation warnings about "#pragma mark" on GTK+ bots by
1584         substituting  "// MARK:" for "#pragma mark", which provides
1585         analogous code-bookmarking functionality under Xcode.
1586
1587         * platform/graphics/cg/PathCG.cpp:
1588         * platform/graphics/mac/WebLayer.mm:
1589
1590 2010-12-28  Jan Erik Hanssen  <jhanssen@sencha.com>
1591
1592         Reviewed by Eric Seidel.
1593
1594         [Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
1595         https://bugs.webkit.org/show_bug.cgi?id=51687
1596
1597         Use a const reference instead of a copy of QPainter::combinedTransform() 
1598         in GraphicsContext::getCTM()
1599
1600         * platform/graphics/qt/GraphicsContextQt.cpp:
1601         (WebCore::GraphicsContext::getCTM):
1602
1603 2010-12-28  Takashi Toyoshima  <toyoshim@google.com>
1604
1605         Reviewed by Eric Seidel.
1606
1607         gcc detected 'control reaches end of non-void function' with
1608         -finstrument-functions option.
1609         https://bugs.webkit.org/show_bug.cgi?id=51669
1610
1611         No new tests. These fixes are trivial.
1612
1613         * dom/Element.cpp:
1614         (WebCore::Element::childTypeAllowed):
1615         * inspector/InspectorResourceAgent.cpp:
1616         (WebCore::cachedResourceTypeString):
1617
1618 2010-12-28  Tony Gentilcore  <tonyg@chromium.org>
1619
1620         Reviewed by Eric Seidel.
1621
1622         Remove unused member of PendingScript
1623         https://bugs.webkit.org/show_bug.cgi?id=51684
1624
1625         This was used when HTMLScriptRunner::runScript created a PendingScript
1626         for inline scripts. But now it just calls executeScript() directly.
1627         External scripts always have the minimum starting line number.
1628
1629         No new tests because no changed functionality.
1630
1631         * dom/PendingScript.cpp:
1632         (WebCore::PendingScript::releaseElementAndClear):
1633         * dom/PendingScript.h:
1634         (WebCore::PendingScript::PendingScript):
1635         (WebCore::PendingScript::operator=):
1636         * html/parser/HTMLScriptRunner.cpp:
1637         (WebCore::HTMLScriptRunner::sourceFromPendingScript):
1638
1639 2010-12-20  Antonio Gomes  <agomes@rim.com>
1640
1641         Reviewed by Daniel Bates.
1642
1643         Spatial Navigation: code clean up (Part VI)
1644         https://bugs.webkit.org/show_bug.cgi?id=50666
1645
1646         No new tests needed.
1647
1648         * page/FocusController.cpp:
1649         (WebCore::updatFocusCandidateIfNeeded): Assert renderer() and
1650         isElementNode() now that we are bailing out earlier in both the
1651         FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
1652         * page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection
1653         and virtualRectForAreaElementAndDirection functions.
1654         (WebCore::FocusController::findFocusCandidateInContainer):
1655         (WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted callsites
1656         of canScrollInDirection(), and added an early return if !isElementNode().
1657         (WebCore::FocusController::advanceFocusDirectionally): Adjusted callsite of
1658         virtualRectForAreaElementAndDirection();
1659         * page/SpatialNavigation.cpp:
1660         (WebCore::FocusCandidate::FocusCandidate): Assert if node is not a element node;
1661         (WebCore::isScrollableNode): Renamed from isScrollableContainerNode;
1662         (WebCore::scrollInDirection): Adjusted callsite after function name change;
1663         (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is
1664         a documentNode.
1665         (WebCore::canScrollInDirection): Signature changed.
1666         (WebCore::canBeScrolledIntoView): Ditto.
1667         (WebCore::virtualRectForAreaElementAndDirection): Ditto.
1668
1669 2010-12-28  Adrienne Walker  <enne@google.com>
1670
1671         Reviewed by Kenneth Russell.
1672
1673         [chromium] Fix tiled compositor assertion after GPU process recovery.
1674         https://bugs.webkit.org/show_bug.cgi?id=51682
1675
1676         After the GPU process recovers, the layer size is set to IntSize(),
1677         but IntRect::unite() has a special case for empty rects.  This
1678         behavior was causing the layer size to be too small, causing an
1679         out-of-bounds array access elsewhere.
1680
1681         No new tests.
1682
1683         * platform/graphics/chromium/LayerTilerChromium.cpp:
1684         (WebCore::LayerTilerChromium::growLayerToContain):
1685
1686 2010-12-23  Zhenyao Mo  <zmo@google.com>
1687
1688         Reviewed by Kenneth Russell.
1689
1690         Initialize to 0 for undefined values in CopyTexImage2D
1691         https://bugs.webkit.org/show_bug.cgi?id=51421
1692
1693         * html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer.
1694         (WebCore::WebGLFramebuffer::WebGLFramebuffer):
1695         (WebCore::WebGLFramebuffer::setAttachment):
1696         (WebCore::WebGLFramebuffer::getWidth):
1697         (WebCore::WebGLFramebuffer::getHeight):
1698         (WebCore::WebGLFramebuffer::getColorBufferFormat):
1699         * html/canvas/WebGLFramebuffer.h:
1700         * html/canvas/WebGLRenderingContext.cpp:
1701         (WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0.
1702         (WebCore::WebGLRenderingContext::copyTexSubImage2D):
1703         (WebCore::WebGLRenderingContext::framebufferTexture2D):
1704         (WebCore::WebGLRenderingContext::renderbufferStorage):
1705         (WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
1706         (WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
1707         * html/canvas/WebGLRenderingContext.h:
1708         * html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level.
1709         (WebCore::WebGLTexture::getInternalFormat):
1710         (WebCore::WebGLTexture::getWidth):
1711         (WebCore::WebGLTexture::getHeight):
1712         (WebCore::WebGLTexture::mapTargetToIndex):
1713         (WebCore::WebGLTexture::getLevelInfo):
1714         * html/canvas/WebGLTexture.h:
1715         (WebCore::WebGLTexture::isTexture):
1716         * platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
1717         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
1718         (WebCore::GraphicsContext3D::getInternalFramebufferSize):
1719         * platform/graphics/qt/GraphicsContext3DQt.cpp:
1720         (WebCore::GraphicsContext3D::getInternalFramebufferSize):
1721
1722 2010-12-23  Zhenyao Mo  <zmo@google.com>
1723
1724         Reviewed by Kenneth Russell.
1725
1726         Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
1727         https://bugs.webkit.org/show_bug.cgi?id=39855
1728
1729         * html/canvas/WebGLRenderingContext.cpp:
1730         (WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long.
1731         (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
1732         (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
1733         (WebCore::WebGLRenderingContext::scissor): Ditto.
1734         (WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
1735         (WebCore::WebGLRenderingContext::texImage2D): Ditto.
1736         (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto.
1737         (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
1738         (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
1739         (WebCore::WebGLRenderingContext::viewport): Ditto.
1740         (WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
1741         * html/canvas/WebGLRenderingContext.h:
1742         * html/canvas/WebGLRenderingContext.idl:
1743
1744 2010-12-28  Abhishek Arya  <inferno@chromium.org>
1745
1746         Reviewed by Kenneth Russell.
1747
1748         Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
1749         process of loading.
1750         https://bugs.webkit.org/show_bug.cgi?id=51681
1751
1752         Test: canvas/philip/tests/2d.text-custom-font-load-crash.html
1753
1754         * html/canvas/CanvasRenderingContext2D.cpp:
1755         (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
1756         * platform/graphics/Font.cpp:
1757         (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts()
1758         (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts()
1759         (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
1760         * platform/graphics/Font.h:
1761         (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.
1762
1763 2010-12-28  Dimitri Glazkov  <dglazkov@chromium.org>
1764
1765         Reviewed by Eric Seidel.
1766
1767         Combine setShadowRoot and clearShadowRoot into a simpler API
1768         https://bugs.webkit.org/show_bug.cgi?id=50971
1769
1770         No change in behavior, and API is not used yet.
1771
1772         * dom/Element.cpp:
1773         (WebCore::Element::setShadowRoot): Combined clearing and setting of
1774             the shadowRoot, also hooked up with setting and clearing of the
1775             corresponding shadowHost values.
1776         * dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it
1777             private.
1778         * dom/Node.h: Made shadow host-related functions public so that
1779             Element::setShadowRoot can access setShadowHost. It seems logical
1780             to make shadowHost public as well to keep the defs together.
1781
1782 2010-12-28  Andrey Kosyakov  <caseq@chromium.org>
1783
1784         Reviewed by Pavel Feldman.
1785
1786         Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
1787         Do not request content for resources with non-numeric identifiers.
1788         https://bugs.webkit.org/show_bug.cgi?id=49727
1789
1790         Test: http/tests/inspector/extensions-resources-redirect.html
1791
1792         * inspector/front-end/NetworkManager.js:
1793         (WebInspector.NetworkManager.prototype._appendRedirect):
1794
1795 2010-12-28  Ilya Tikhonovsky  <loislo@chromium.org>
1796
1797         Unreviewed build fix for Qt.
1798
1799         ResourceTreeModel.js was added.
1800
1801         * inspector/front-end/WebKit.qrc:
1802
1803 2010-12-28  Mikhail Naganov  <mnaganov@chromium.org>
1804
1805         Reviewed by Pavel Feldman.
1806
1807         [Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.
1808
1809         https://bugs.webkit.org/show_bug.cgi?id=51680
1810
1811         * inspector/front-end/ProfilesPanel.js:
1812         (WebInspector.ProfilesPanel.prototype._reset):
1813
1814 2010-12-28  Alexander Pavlov  <apavlov@chromium.org>
1815
1816         Reviewed by Pavel Feldman.
1817
1818         Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
1819         https://bugs.webkit.org/show_bug.cgi?id=51663
1820
1821         The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
1822         optional quotes/apostrophes and spaces are now allowed inside uri(...).
1823
1824         Test: inspector/styles-url-linkify.html
1825
1826         * inspector/front-end/StylesSidebarPane.js:
1827         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
1828         (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
1829
1830 2010-12-21  Ilya Tikhonovsky  <loislo@chromium.org>
1831
1832         Reviewed by Pavel Feldman.
1833
1834         Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.
1835
1836         Domain was changed for Resources, FileSystem etc. related methods.
1837         ResourcesManager was renamed to NetworkManager.
1838         ResourceTreeModel was extracted as separate file.
1839         FileSystem, Database, DOMStorage and ApplicationCache methods were
1840         removed from NetworkManager and added to corresponding classes.
1841
1842         https://bugs.webkit.org/show_bug.cgi?id=51334
1843
1844         * WebCore.gypi:
1845         * WebCore.vcproj/WebCore.vcproj:
1846         * inspector/CodeGeneratorInspector.pm:
1847         * inspector/Inspector.idl:
1848         * inspector/front-end/AuditRules.js:
1849         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
1850         * inspector/front-end/CSSStyleModel.js:
1851         (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
1852         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
1853         * inspector/front-end/ConsoleView.js:
1854         (WebInspector.ConsoleView.prototype.addMessage):
1855         (WebInspector.ConsoleView.prototype.clearMessages):
1856         * inspector/front-end/DOMAgent.js:
1857         (WebInspector.ApplicationCache.updateApplicationCacheStatus):
1858         (WebInspector.ApplicationCache.updateNetworkState):
1859         * inspector/front-end/DOMStorage.js:
1860         (WebInspector.DOMStorage.addDOMStorage):
1861         (WebInspector.DOMStorage.selectDOMStorage):
1862         (WebInspector.DOMStorage.updateDOMStorage):
1863         * inspector/front-end/Database.js:
1864         (WebInspector.Database.prototype.executeSql):
1865         (WebInspector.Database.addDatabase):
1866         (WebInspector.Database.selectDatabase):
1867         (WebInspector.Database.sqlTransactionSucceeded):
1868         (WebInspector.Database.sqlTransactionFailed):
1869         * inspector/front-end/FileSystemView.js:
1870         (WebInspector.FileSystem.didGetFileSystemPath):
1871         (WebInspector.FileSystem.didGetFileSystemError):
1872         (WebInspector.FileSystem.didGetFileSystemDisabled):
1873         * inspector/front-end/NetworkItemView.js:
1874         (WebInspector.NetworkItemView):
1875         * inspector/front-end/NetworkManager.js: Added.
1876         (WebInspector.NetworkManager):
1877         (WebInspector.NetworkManager.prototype._createResource):
1878         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
1879         (WebInspector.NetworkManager.prototype.willSendRequest):
1880         (WebInspector.NetworkManager.prototype._updateResourceWithRequest):
1881         (WebInspector.NetworkManager.prototype._appendRedirect):
1882         (WebInspector.NetworkManager.prototype.markResourceAsCached):
1883         (WebInspector.NetworkManager.prototype.didReceiveResponse):
1884         (WebInspector.NetworkManager.prototype._updateResourceWithResponse):
1885         (WebInspector.NetworkManager.prototype.didReceiveContentLength):
1886         (WebInspector.NetworkManager.prototype.didFinishLoading):
1887         (WebInspector.NetworkManager.prototype.didFailLoading):
1888         (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
1889         (WebInspector.NetworkManager.prototype._updateResourceWithCachedResource):
1890         (WebInspector.NetworkManager.prototype.setInitialContent):
1891         (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
1892         (WebInspector.NetworkManager.prototype.frameDetachedFromParent):
1893         (WebInspector.NetworkManager.prototype.didCreateWebSocket):
1894         (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
1895         (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
1896         (WebInspector.NetworkManager.prototype.didCloseWebSocket):
1897         (WebInspector.NetworkManager.prototype._processCachedResources):
1898         (WebInspector.NetworkManager.prototype._addFramesRecursively):
1899         (WebInspector.NetworkManager.requestContent):
1900         * inspector/front-end/NetworkPanel.js:
1901         (WebInspector.NetworkPanel.prototype.refreshResource):
1902         * inspector/front-end/Resource.js:
1903         (WebInspector.Resource.prototype._innerRequestContent):
1904         * inspector/front-end/ResourceManager.js: Removed.
1905         * inspector/front-end/ResourceTreeModel.js: Added.
1906         (WebInspector.ResourceTreeModel):
1907         (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
1908         (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
1909         (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent):
1910         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
1911         (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
1912         (WebInspector.ResourceTreeModel.prototype._clearResources):
1913         (WebInspector.ResourceTreeModel.prototype.forAllResources):
1914         (WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
1915         (WebInspector.ResourceTreeModel.prototype.clearConsoleMessages):
1916         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
1917         (WebInspector.ResourceTreeModel.prototype.resourceForURL):
1918         (WebInspector.ResourceTreeModel.prototype.bindResourceURL):
1919         (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
1920         (WebInspector.ResourceTreeModel.createResource):
1921         * inspector/front-end/ResourceView.js:
1922         (WebInspector.ResourceView.createResourceView):
1923         (WebInspector.ResourceView.resourceViewTypeMatchesResource):
1924         (WebInspector.ResourceView.resourceViewForResource):
1925         (WebInspector.ResourceView.recreateResourceView):
1926         (WebInspector.ResourceView.existingResourceViewForResource):
1927         * inspector/front-end/ResourcesPanel.js:
1928         (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
1929         (WebInspector.ResourcesPanel.prototype.showSourceLine):
1930         (WebInspector.ResourcesPanel.prototype.showResource):
1931         (WebInspector.ResourcesPanel.prototype.get searchableViews.callback):
1932         (WebInspector.ResourcesPanel.prototype.get searchableViews):
1933         (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
1934         (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
1935         * inspector/front-end/ScriptsPanel.js:
1936         (WebInspector.ScriptsPanel.prototype._addScript):
1937         (WebInspector.ScriptsPanel.prototype.reset):
1938         (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
1939         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
1940         * inspector/front-end/WebKit.qrc:
1941         * inspector/front-end/inspector.html:
1942         * inspector/front-end/inspector.js:
1943         (WebInspector.forAllResources):
1944         (WebInspector.resourceForURL):
1945
1946 2010-12-27  Helder Correia  <helder@sencha.com>
1947
1948         Reviewed by Ariya Hidayat.
1949
1950         ContextShadow should use AffineTransform instead of TransformationMatrix
1951         https://bugs.webkit.org/show_bug.cgi?id=51661
1952
1953         ContextShadow needs the CTM to make sure shadows are not affected by
1954         transformations when drawing on a canvas. AffineTransform is sufficient
1955         in this case.
1956
1957         Existing tests: fast/canvas/canvas*shadow*html
1958
1959         * platform/graphics/ContextShadow.cpp:
1960         (WebCore::ContextShadow::mustUseContextShadow):
1961         (WebCore::ContextShadow::adjustBlurDistance):
1962         (WebCore::ContextShadow::calculateLayerBoundingRect):
1963         * platform/graphics/ContextShadow.h:
1964         * platform/graphics/cairo/ContextShadowCairo.cpp:
1965         (WebCore::ContextShadow::getTransformationMatrixFromContext):
1966         * platform/graphics/qt/ContextShadowQt.cpp:
1967         (WebCore::ContextShadow::getTransformationMatrixFromContext):
1968
1969 2010-12-27  Daniel Bates  <dbates@rim.com>
1970
1971         Reviewed by Antonio Gomes.
1972
1973         Clean up: Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
1974         https://bugs.webkit.org/show_bug.cgi?id=51634
1975
1976         Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
1977         to HTMLFrameElementBase::marginWidth() and HTMLFrameElementBase::marginHeight(), respectively.
1978         This will make the names of these getters consistent with the naming convention we use for
1979         getters.
1980
1981         * html/HTMLBodyElement.cpp:
1982         (WebCore::HTMLBodyElement::insertedIntoDocument):
1983         * html/HTMLFrameElementBase.h:
1984         (WebCore::HTMLFrameElementBase::marginWidth): Renamed; Formerly getMarginWidth().
1985         (WebCore::HTMLFrameElementBase::marginHeight): Renamed; Formerly getMarginHeight().
1986         * loader/SubframeLoader.cpp:
1987         (WebCore::SubframeLoader::loadSubframe):
1988         * page/FrameView.cpp:
1989         (WebCore::FrameView::init):
1990         * rendering/RenderEmbeddedObject.cpp:
1991         (WebCore::RenderEmbeddedObject::viewCleared): Also renamed variables marginw and marginh
1992         to marginWidth and marginHeight, respectively. This makes the names of these variables
1993         consistent with the names of similar variables in SubframeLoader::loadSubframe() and FrameView::init().
1994         * rendering/RenderFrame.cpp:
1995         (WebCore::RenderFrame::viewCleared): Ditto.
1996
1997 2010-12-27  Martin Robinson  <mrobinson@igalia.com>
1998
1999         Reviewed by Daniel Bates.
2000
2001         [GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
2002         https://bugs.webkit.org/show_bug.cgi?id=51654
2003
2004         Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
2005         on some debug configurations.
2006
2007         No new tests. This is already covered by current slider tests. It isn't crashing on
2008         the bots, but it does crash locally.
2009
2010         * platform/gtk/RenderThemeGtk.cpp:
2011         (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
2012
2013 2010-12-27  Anton Muhin  <antonm@chromium.org>
2014
2015         Reviewed by David Levin.
2016
2017         [v8] Remove unused methods to protect/unprotect wrappers during garbage collection
2018         https://bugs.webkit.org/show_bug.cgi?id=51648
2019
2020         * bindings/v8/ScriptController.cpp:
2021         * bindings/v8/ScriptController.h:
2022         * bindings/v8/V8GCController.cpp:
2023         (WebCore::V8GCController::gcEpilogue):
2024         * bindings/v8/V8GCController.h:
2025
2026 2010-12-27  Yury Semikhatsky  <yurys@chromium.org>
2027
2028         Unreviewed. Removed trailing spaces from a localized
2029         string to make it the same as the one used in the code.
2030
2031         * English.lproj/localizedStrings.js:
2032
2033 2010-12-27  Yael Aharon  <yael.aharon@nokia.com>
2034
2035         Reviewed by Eric Seidel.
2036
2037         Browser is failing 16 baseline test from Selector API Test Suite
2038         https://bugs.webkit.org/show_bug.cgi?id=42968
2039
2040         Throw an exception if there is no argument to querySelector or 
2041         querySelectorAll. This replaces the current behavior of passing the string
2042         "undefined" as the argument.
2043
2044         No new tests, just updating the existing results for 
2045         fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.
2046
2047         * dom/Document.idl:
2048         * dom/DocumentFragment.idl:
2049         * dom/Element.idl:
2050
2051 2010-12-26  MORITA Hajime  <morrita@google.com>
2052
2053         Reviewed by Dan Bernstein.
2054
2055         For box-shadow, non-primary shadows should have specified radii.
2056         https://bugs.webkit.org/show_bug.cgi?id=51386
2057
2058         On paintBoxShadow(), the spread value accidentally accumulated accidentally
2059         during the loop, which should be applied individually for radius of each shadow. 
2060         This change makes the radii for rects computed for each shadow.
2061         
2062         Test: fast/box-shadow/spread-multiple-normal.html
2063
2064         * rendering/RenderBoxModelObject.cpp:
2065         (WebCore::RenderBoxModelObject::paintBoxShadow):
2066
2067 2010-12-26  Patrick Gansterer  <paroga@webkit.org>
2068
2069         Reviewed by Eric Seidel.
2070
2071         Improve output of HTML parser benchmark
2072         https://bugs.webkit.org/show_bug.cgi?id=51611
2073
2074         Calculate and show median, min and max values.
2075
2076         * benchmarks/parser/html-parser.html:
2077
2078 2010-12-26  Abhishek Arya  <inferno@chromium.org>
2079
2080         Reviewed by Simon Fraser.
2081
2082         Remove the bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer. 
2083         https://bugs.webkit.org/show_bug.cgi?id=48772
2084
2085         Test: fast/multicol/renderer-positioned-assert-crash.html
2086
2087         * rendering/RenderLayer.cpp:
2088         (WebCore::RenderLayer::paintPaginatedChildLayer):
2089         (WebCore::RenderLayer::hitTestPaginatedChildLayer):
2090
2091 2010-12-25  Peter Rybin  <peter.rybin@gmail.com>
2092
2093         Reviewed by Adam Barth.
2094
2095         Adds currentColumn (and currentLine) to SegmentedString. Switches
2096         HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
2097         needs position for a <script> tag.
2098
2099         SegmentedString should provide column position
2100         https://bugs.webkit.org/show_bug.cgi?id=51311
2101
2102         * html/parser/HTMLDocumentParser.cpp:
2103         (WebCore::HTMLDocumentParser::HTMLDocumentParser):
2104         (WebCore::HTMLDocumentParser::textPosition):
2105         * html/parser/HTMLInputStream.h:
2106         (WebCore::HTMLInputStream::current):
2107         (WebCore::InsertionPointRecord::InsertionPointRecord):
2108         (WebCore::InsertionPointRecord::~InsertionPointRecord):
2109         * html/parser/HTMLTreeBuilder.cpp:
2110         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
2111         (WebCore::HTMLTreeBuilder::processScriptStartTag):
2112         * html/parser/HTMLTreeBuilder.h:
2113         (WebCore::HTMLTreeBuilder::create):
2114         * platform/text/SegmentedString.cpp:
2115         (WebCore::SegmentedString::operator=):
2116         (WebCore::SegmentedString::numberOfCharactersConsumedSlow):
2117         (WebCore::SegmentedString::advanceSlowCase):
2118         (WebCore::SegmentedString::currentLine):
2119         (WebCore::SegmentedString::currentColumn):
2120         (WebCore::SegmentedString::setCurrentPosition):
2121         * platform/text/SegmentedString.h:
2122         (WebCore::SegmentedString::SegmentedString):
2123         (WebCore::SegmentedString::advancePastNewline):
2124         (WebCore::SegmentedString::advance):
2125         (WebCore::SegmentedString::numberOfCharactersConsumed):
2126
2127 2010-12-25  Andreas Kling  <kling@webkit.org>
2128
2129         Reviewed by Kenneth Rohde Christiansen.
2130
2131         GraphicsContext: Don't pass StrokeStyle (enum) as const reference
2132         https://bugs.webkit.org/show_bug.cgi?id=51608
2133
2134         * platform/graphics/GraphicsContext.cpp:
2135         (WebCore::GraphicsContext::setStrokeStyle):
2136         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2137         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
2138         * platform/graphics/GraphicsContext.h:
2139         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2140         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2141         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
2142         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2143         * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
2144         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2145         * platform/graphics/openvg/PainterOpenVG.cpp:
2146         (WebCore::PainterOpenVG::setStrokeStyle):
2147         * platform/graphics/openvg/PainterOpenVG.h:
2148         * platform/graphics/qt/GraphicsContextQt.cpp:
2149         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2150         * platform/graphics/skia/GraphicsContextSkia.cpp:
2151         (WebCore::GraphicsContext::setPlatformStrokeStyle):
2152
2153 2010-12-24  Dan Bernstein  <mitz@apple.com>
2154
2155         Reviewed by Alexey Proskuryakov.
2156
2157         REGRESSION (r74648): XHR layout test failures
2158         https://bugs.webkit.org/show_bug.cgi?id=51603
2159
2160         Reverted r74648.
2161
2162         * WebCore.exp.in:
2163
2164 2010-12-24  Dan Bernstein  <mitz@apple.com>
2165
2166         Try to fix the Qt build after r74648.
2167
2168         * WebCore.gypi:
2169         * WebCore.pro:
2170         * platform/network/qt/CredentialStorageQt.cpp: Added.
2171         (WebCore::CredentialStorage::getFromPersistentStorage):
2172
2173 2010-12-24  Simon Fraser  <simon.fraser@apple.com>
2174
2175         Reviewed by Dan Bernstein.
2176
2177         CSSStyleSelector cleanup
2178         https://bugs.webkit.org/show_bug.cgi?id=51597
2179
2180         Make some methods const. Add assertion to checkOneSelector, with the
2181         intention of later removing the if (!e) check (this is hot code).
2182
2183         * css/CSSStyleSelector.cpp:
2184         (WebCore::CSSStyleSelector::locateCousinList):
2185         (WebCore::CSSStyleSelector::canShareStyleWithElement):
2186         (WebCore::CSSStyleSelector::locateSharedStyle):
2187         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
2188         (WebCore::CSSStyleSelector::mmLength):
2189         (WebCore::CSSStyleSelector::inchLength):
2190         (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
2191         (WebCore::CSSStyleSelector::hasSelectorForAttribute):
2192         * css/CSSStyleSelector.h:
2193         (WebCore::CSSStyleSelector::fontSelector):
2194
2195 2010-12-24  Dan Bernstein  <mitz@apple.com>
2196
2197         Reviewed by Anders Carlsson.
2198
2199         <rdar://problem/8758386> The web process uses its own credential storage
2200         https://bugs.webkit.org/show_bug.cgi?id=51599
2201
2202         * WebCore.exp.in: Export CredentialStorage::getFromPersistentStorage(), Credential::hasPassword(),
2203         and Credential::isEmpty().
2204
2205 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
2206
2207         Reviewed by Darin Adler.
2208
2209         [V8] Rename V8CustomEventListener.{h,cpp} to V8EventListener.{h,cpp}
2210         https://bugs.webkit.org/show_bug.cgi?id=51595
2211
2212         * WebCore.gypi:
2213         * bindings/v8/V8DOMWrapper.cpp:
2214         * bindings/v8/V8EventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.cpp.
2215         (WebCore::V8EventListener::V8EventListener):
2216         (WebCore::V8EventListener::getListenerFunction):
2217         (WebCore::V8EventListener::callListenerFunction):
2218         * bindings/v8/V8EventListener.h: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.h.
2219         (WebCore::V8EventListener::create):
2220         * bindings/v8/V8EventListenerList.h:
2221         * bindings/v8/V8WorkerContextEventListener.h:
2222         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2223         * bindings/v8/custom/V8LocationCustom.cpp:
2224         * bindings/v8/custom/V8NodeCustom.cpp:
2225         * bindings/v8/custom/V8NotificationCenterCustom.cpp:
2226
2227 2010-12-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2228
2229         Reviewed by Xan Lopez.
2230
2231         [GTK] Show current time / total in media player
2232         https://bugs.webkit.org/show_bug.cgi?id=51535
2233
2234         * css/mediaControlsGtk.css:
2235         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
2236         * platform/gtk/RenderThemeGtk.cpp:
2237         (WebCore::RenderThemeGtk::formatMediaControlsCurrentTime):
2238         (WebCore::RenderThemeGtk::paintMediaCurrentTime):
2239         * platform/gtk/RenderThemeGtk.h:
2240
2241 2010-12-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2242
2243         Reviewed by Eric Seidel.
2244
2245         Clean up CSSRuleData in CSSStyleSelector.h
2246         https://bugs.webkit.org/show_bug.cgi?id=27753
2247
2248         Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.
2249
2250         * css/CSSStyleSelector.cpp:
2251         (WebCore::CSSRuleData::CSSRuleData):
2252         (WebCore::CSSRuleData::~CSSRuleData):
2253         (WebCore::CSSRuleData::position):
2254         (WebCore::CSSRuleData::rule):
2255         (WebCore::CSSRuleData::selector):
2256         (WebCore::CSSRuleData::next):
2257         (WebCore::CSSRuleDataList::CSSRuleDataList):
2258         (WebCore::CSSRuleDataList::~CSSRuleDataList):
2259         (WebCore::CSSRuleDataList::first):
2260         (WebCore::CSSRuleDataList::last):
2261         (WebCore::CSSRuleDataList::append):
2262         * css/CSSStyleSelector.h:
2263
2264 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
2265
2266         Unreviewed. Fix compilation on Windows.
2267
2268         * inspector/InspectorStyleSheet.cpp:
2269         (WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
2270         * inspector/InspectorStyleSheet.h:
2271
2272 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
2273
2274         Reviewed by Darin Adler.
2275
2276         inspector/debugger-step-out.html crashing intermittently in the bots
2277         https://bugs.webkit.org/show_bug.cgi?id=50868
2278
2279         Use RefPtr rather instead of raw pointers when keeping references
2280         to refcounted objects.
2281
2282         * inspector/InspectorCSSAgent.cpp:
2283         (WebCore::InspectorCSSAgent::getStylesForNode2):
2284         (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
2285         * inspector/InspectorStyleSheet.cpp:
2286         (WebCore::InspectorStyle::create):
2287         (WebCore::InspectorStyle::InspectorStyle):
2288         (WebCore::InspectorStyle::buildObjectForStyle):
2289         (WebCore::InspectorStyle::setPropertyText):
2290         (WebCore::InspectorStyle::toggleProperty):
2291         (WebCore::InspectorStyle::styleText):
2292         (WebCore::InspectorStyle::populateAllProperties):
2293         (WebCore::InspectorStyle::replacePropertyInStyleText):
2294         (WebCore::InspectorStyleSheet::create):
2295         (WebCore::InspectorStyleSheet::InspectorStyleSheet):
2296         (WebCore::InspectorStyleSheetForInlineStyle::create):
2297         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
2298         (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
2299         * inspector/InspectorStyleSheet.h:
2300         (WebCore::InspectorStyle::cssStyle):
2301         (WebCore::InspectorStyleSheet::pageStyleSheet):
2302
2303 2010-12-24  Justin Schuh  <jschuh@chromium.org>
2304
2305         Reviewed by Nikolas Zimmermann.
2306
2307         SVGElementInstance::m_useElement should be cleared when use element is removed from document
2308         https://bugs.webkit.org/show_bug.cgi?id=51486
2309
2310         Test: svg/custom/use-instanceRoot-with-use-removed.svg
2311
2312         * svg/SVGElementInstance.cpp:
2313         (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
2314         * svg/SVGElementInstance.h:
2315         (WebCore::SVGElementInstance::clearUseElement):
2316         * svg/SVGUseElement.cpp:
2317         (WebCore::SVGUseElement::removedFromDocument):
2318         (WebCore::ShadowTreeUpdateBlocker::if):
2319         (WebCore::SVGUseElement::detachInstance):
2320         (WebCore::SVGUseElement::detach):
2321         * svg/SVGUseElement.h:
2322
2323 2010-12-23  Joseph Pecoraro  <joepeck@webkit.org>
2324
2325         Reviewed by Yury Semikhatsky.
2326
2327         Web Inspector: Missing Localized Strings
2328         https://bugs.webkit.org/show_bug.cgi?id=51542
2329
2330         Added missing strings: "WebSocket",  "Frames", "Text", "Transfer",
2331         "Preserve Log upon Navigation", and "Go to Line".
2332
2333         * English.lproj/localizedStrings.js:
2334
2335 2010-12-24  Alexander Pavlov  <apavlov@chromium.org>
2336
2337         Reviewed by Yury Semikhatsky.
2338
2339         Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
2340         https://bugs.webkit.org/show_bug.cgi?id=51478
2341
2342         Now the element attribute modifications (including "style") are tracked, which results in the
2343         source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
2344         on the "style" attribute modification through the Elements tree. Also, it appears that
2345         a complete "style" attribute removal destroys the inline style declaration
2346         (StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).
2347
2348         Test: inspector/elements-delete-inline-style.html
2349
2350         * inspector/InspectorCSSAgent.cpp:
2351         (WebCore::InspectorCSSAgent::didModifyDOMAttr):
2352         * inspector/InspectorCSSAgent.h:
2353         * inspector/InspectorDOMAgent.cpp:
2354         (WebCore::InspectorDOMAgent::didModifyDOMAttr):
2355         * inspector/InspectorDOMAgent.h:
2356         * inspector/InspectorStyleSheet.cpp:
2357         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
2358         (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
2359         (WebCore::InspectorStyleSheetForInlineStyle::text):
2360         (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
2361         (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
2362         * inspector/InspectorStyleSheet.h:
2363         * inspector/front-end/ElementsTreeOutline.js:
2364         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
2365
2366 2010-12-24  Noel Gordon  <noel.gordon@gmail.com>
2367
2368         Reviewed by Andreas Kling.
2369
2370         [chromium] Fix a style nit in the JPEG encoder
2371         https://bugs.webkit.org/show_bug.cgi?id=51574
2372
2373         * platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.
2374
2375 2010-12-23  Alexander Pavlov  <apavlov@chromium.org>
2376
2377         Reviewed by Maciej Stachowiak.
2378
2379         Web Inspector: CSS shorthand properties expand unnecessarily
2380         https://bugs.webkit.org/show_bug.cgi?id=36304
2381
2382         "border-radius" is a shorthand property that has a "non-standard" format and longhands, see
2383         http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
2384         standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
2385         This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
2386         appropriately when adding implicit longhands, thus they were added as normal properties
2387         found in the CSS (neither implicit, nor longhands). This is now fixed.
2388
2389         * css/CSSParser.cpp:
2390         (WebCore::CSSParser::parseBorderRadius):
2391
2392 2010-12-24  Justin Schuh  <jschuh@chromium.org>
2393
2394         Reviewed by Darin Adler.
2395
2396         setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
2397         https://bugs.webkit.org/show_bug.cgi?id=51576
2398
2399         Disallowed elements may be pruned from the shadow tree, leaving a null
2400         shadowTreeElement. We should check for that before setting attributes.
2401
2402         Test: svg/custom/animate-disallowed-use-element.svg
2403
2404         * svg/SVGAnimationElement.cpp:
2405         (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
2406
2407 2010-12-24  Evan Martin  <evan@chromium.org>
2408
2409         Reviewed by Darin Adler.
2410
2411         TextMetrics::width is an integer, but the member is a float
2412         https://bugs.webkit.org/show_bug.cgi?id=51566
2413
2414         Change the return type to a float.
2415
2416         No tests, fixing a compiler warning.
2417         (I was unable to produce a difference in the values exposed to pages
2418         with a float versus the previous conversion to an integer.)
2419
2420         * html/TextMetrics.h:
2421         (WebCore::TextMetrics::width):
2422
2423 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2424
2425         Reviewed by Kenneth Rohde Christiansen.
2426
2427         [EFL] Add option to enable Touch Events.
2428         https://bugs.webkit.org/show_bug.cgi?id=49125
2429
2430         Add files for EFL to support TOUCH_EVENTS.
2431
2432         * CMakeLists.txt:
2433         * CMakeListsEfl.txt:
2434         * platform/PlatformTouchEvent.h: Add EFL related constructor.
2435         * platform/PlatformTouchPoint.h: ditto.
2436         * platform/efl/PlatformTouchEventEfl.cpp: Added.
2437         (WebCore::PlatformTouchEvent::PlatformTouchEvent):
2438         * platform/efl/PlatformTouchPointEfl.cpp: Added.
2439         (WebCore::PlatformTouchPoint::PlatformTouchPoint):
2440
2441 2010-12-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2442
2443         Reviewed by Kenneth Rohde Christiansen.
2444
2445         [EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()
2446         https://bugs.webkit.org/show_bug.cgi?id=51457
2447
2448         WebKit EFL can't play html5 audio because of wrong mime type checking.
2449         So, 'application/octet-stream' is changed with an empty string.
2450
2451         * platform/efl/MIMETypeRegistryEfl.cpp:
2452         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
2453         Returns an empty string instead of application/octet-stream when it can't find proper mime type.
2454
2455 2010-12-24  Justin Schuh  <jschuh@chromium.org>
2456
2457         Reviewed by Darin Adler.
2458
2459         SVGFontFaceElement::rebuildFontFace() should exit when not in document
2460         https://bugs.webkit.org/show_bug.cgi?id=51571
2461
2462         We were hitting a NULL deref crash. Since most of the callers checked
2463         inDocument() anyway, I moved it into the start of rebuildFontFace.
2464
2465         Test: svg/custom/use-invalid-font-face.svg
2466
2467         * svg/SVGFontFaceElement.cpp:
2468         (WebCore::SVGFontFaceElement::parseMappedAttribute):
2469         (WebCore::SVGFontFaceElement::rebuildFontFace):
2470         (WebCore::SVGFontFaceElement::childrenChanged):
2471
2472 2010-12-24  Justin Schuh  <jschuh@chromium.org>
2473
2474         Reviewed by Darin Adler.
2475
2476         Remove unnecessary check in CSSCanvasValue::canvasDestroyed().
2477         https://bugs.webkit.org/show_bug.cgi?id=51564
2478
2479         This check was duplicating an ASSERT for a case fixed in r73927.
2480         Now that the bug is fixed the check is no longer necessary.
2481
2482         Removing dead code, so no new tests needed.
2483
2484         * css/CSSCanvasValue.cpp:
2485         (WebCore::CSSCanvasValue::canvasDestroyed):
2486
2487 2010-12-23  Evan Martin  <evan@chromium.org>
2488
2489         Reviewed by Darin Adler.
2490
2491         ViewportArguments.h uses an enum to intialize a bool
2492         https://bugs.webkit.org/show_bug.cgi?id=50982
2493
2494         Initialize userScalable to true, rather than -1.
2495         No tests; fixes a compiler warning.
2496
2497         * dom/ViewportArguments.h:
2498         (WebCore::ViewportArguments::ViewportArguments):
2499
2500 2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>
2501
2502         Reviewed by Adam Barth.
2503
2504         [Qt] User name/password stripped from URLs
2505         https://bugs.webkit.org/show_bug.cgi?id=36232
2506
2507         If a username but no password or no username but a password is present
2508         in a URL, QtWebKit won't send any authentication information down to Qt
2509         as it should.
2510
2511         Tests: http/tests/xmlhttprequest/basic-auth-nopassword.html
2512                http/tests/xmlhttprequest/basic-auth-nouser.html
2513
2514         * platform/network/qt/ResourceHandleQt.cpp:
2515         (WebCore::ResourceHandle::start):
2516         (WebCore::ResourceHandle::loadResourceSynchronously):
2517
2518 2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>
2519
2520         Reviewed by Darin Adler.
2521
2522         queryCommandValue("FormatBlock") does not respect editing boundaries
2523         https://bugs.webkit.org/show_bug.cgi?id=51219
2524
2525         Fixed the bug by checking the element we found in elementForFormatBlockCommand
2526         does not contain the editable root.
2527
2528         * editing/FormatBlockCommand.cpp:
2529         (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
2530
2531 2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>
2532
2533         Reviewed by Darin Adler.
2534
2535         FormatBlock doesn't preserve typing style but it should
2536         https://bugs.webkit.org/show_bug.cgi?id=51140
2537
2538         Fixed the bug by making preserveTypingStyle return true.
2539
2540         Test: editing/execCommand/format-block-typing-style.html
2541
2542         * editing/FormatBlockCommand.h:
2543         (WebCore::FormatBlockCommand::preservesTypingStyle):
2544
2545 2010-12-23  Jessie Berlin  <jberlin@apple.com>
2546
2547         Reviewed by Sam Weinig.
2548
2549         Need WebKit2 API to create a SecurityOrigin from protocol, host, and port
2550         https://bugs.webkit.org/show_bug.cgi?id=51563
2551
2552         Add SecurityOrigin::create(const String& protocol, const String& host, int port).
2553
2554         * WebCore.exp.in:
2555         Export the symbols for WebCore::SecurityOrigin::create(String, String, int).
2556
2557         * page/SecurityOrigin.cpp:
2558         (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
2559         Use the constant MaxAllowedPort.
2560         (WebCore::SecurityOrigin::create):
2561         Sanitizing based off of that done in createFromDatabaseIdentifier.
2562         * page/SecurityOrigin.h:
2563
2564 2010-12-23  Patrick Gansterer  <paroga@webkit.org>
2565
2566         Unreviewed build fix for WinCE after r73802.
2567
2568         Reapply r70812:
2569         Port ContextMenuItemWin.cpp to WinCE
2570         https://bugs.webkit.org/show_bug.cgi?id=48407
2571
2572         * platform/win/ContextMenuItemWin.cpp:
2573
2574 2010-12-23  Adam Barth  <abarth@webkit.org>
2575
2576         Remove include of non-existant file.
2577
2578         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2579
2580 2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>
2581
2582         Reviewed by Darin Adler.
2583
2584         Selection becomes stale when CharacterData is manipulated directly
2585         https://bugs.webkit.org/show_bug.cgi?id=51389
2586
2587         The bug was caused by SelectionController's not adjusting selection when CharacterData's
2588         m_data is modified by its API.
2589
2590         Fixed the bug by adding textWillBeReplaced to SelectionController and calling it in
2591         CharacterData::textWillBeReplaced. Added newLength to setDataAndUpdate, which is passed to
2592         textWillBeReplaced because inserting, replacing, or removing data may require moving
2593         the offset of the selection end points (done by shouldRemovePositionAfterAdoptingTextReplacement).
2594
2595         Also fixed the condition for determining whether or not a node intersects the selection
2596         in respondToNodeModification, which is extracted from nodeWillBeRemoved. The old condition
2597         failed to recognize certain cases when selection started and ended with non-zero offsets.
2598
2599         Tests: editing/selection/character-data-mutation-crash.html
2600                editing/selection/character-data-mutation.html
2601
2602         * dom/CharacterData.cpp:
2603         (WebCore::CharacterData::setData): Passes newLegnth to setDataAndUpdate.
2604         (WebCore::CharacterData::appendData): Ditto.
2605         (WebCore::CharacterData::insertData): Ditto.
2606         (WebCore::CharacterData::deleteData): Ditto.
2607         (WebCore::CharacterData::replaceData): Ditto.
2608         (WebCore::CharacterData::setDataAndUpdate): Added newLegnth to the argument list,
2609         and renamed lengthOfReplacedData to oldLength; calls textWillBeReplaced.
2610         * dom/CharacterData.h:
2611         * editing/SelectionController.cpp:
2612         (WebCore::removingNodeRemovesPosition): Removed indentations from blank lines.
2613         (WebCore::SelectionController::nodeWillBeRemoved): Calls nodeWillBeRemoved.
2614         (WebCore::SelectionController::respondToNodeModification): Extracted from nodeWillBeRemoved;
2615         fixed the logic to figure out whether a node is inside the range or not.
2616         (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): Added.
2617         (WebCore::SelectionController::textWillBeReplaced): Added.
2618         * editing/SelectionController.h:
2619
2620 2010-12-23  Adam Barth  <abarth@webkit.org>
2621
2622         Reviewed by Darin Adler.
2623
2624         Remove unneeded V8 bindings files
2625         https://bugs.webkit.org/show_bug.cgi?id=51570
2626
2627         * WebCore.gypi:
2628         * bindings/generic/BindingDOMWindow.h: Removed.
2629         * bindings/v8/specialization/V8BindingDOMWindow.h: Removed.
2630
2631 2010-12-23  Dan Bernstein  <mitz@apple.com>
2632
2633         Build fix.
2634
2635         * editing/EditorCommand.cpp:
2636         (WebCore::enabledDismissCorrectionPanel):
2637
2638 2010-12-23  Darin Adler  <darin@apple.com>
2639
2640         Try to fix crash seen on GTK bot.
2641
2642         * editing/EditorCommand.cpp:
2643         (WebCore::internalCommand): Add back empty string check I accidentally deleted in r74580.
2644
2645         * WebCore.xcodeproj/project.pbxproj: Let Xcode edit the file.
2646
2647 2010-12-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2648
2649         Unreviewed, rolling out r74561.
2650         http://trac.webkit.org/changeset/74561
2651         https://bugs.webkit.org/show_bug.cgi?id=51565
2652
2653         "Broke Chromium UI tests on Vista" (Requested by kbr_google on
2654         #webkit).
2655
2656         * platform/graphics/chromium/ImageLayerChromium.cpp:
2657         (WebCore::ImageLayerChromium::updateContentsIfDirty):
2658         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
2659         (WebCore::GraphicsContext3D::getImageData):
2660
2661 2010-12-23  Mihai Parparita  <mihaip@chromium.org>
2662
2663         Reviewed by Kent Tamura.
2664
2665         [Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
2666         https://bugs.webkit.org/show_bug.cgi?id=51507
2667         
2668         Adds WebThemeEngine for the Mac (it already has parallel definitions for
2669         Windows and Linux) so that scrollbar thumb rendering can be overridden
2670         for the DRT (to be consistent with the NSScroller-based rendering
2671         used by the Mac port).
2672
2673         No new tests since the functionality is not exposed yet. Eventually will
2674         result in the Chromium/Mac port being able to use the same pixel
2675         baselines for layout tests as the Mac port.
2676
2677         * platform/chromium/ChromiumBridge.h:
2678         * platform/chromium/ScrollbarThemeChromiumMac.mm:
2679         (WebCore::scrollbarStateToThemeState):
2680         (WebCore::ScrollbarThemeChromiumMac::paint):
2681
2682 2010-12-23  Darin Adler  <darin@apple.com>
2683
2684         Reviewed by Sam Weinig.
2685
2686         WKView should not try to do asynchronous validation for selectors that are not editor commands
2687         https://bugs.webkit.org/show_bug.cgi?id=51555
2688
2689         * WebCore.exp.in: Added commandIsSupportedFromMenuOrKeyBinding.
2690         * editing/Editor.h: Reordered arguments in the Editor::Command constructor
2691         and the data members too so the frame is last. Added
2692         commandIsSupportedFromMenuOrKeyBinding.
2693
2694         * editing/EditorCommand.cpp:
2695         (WebCore::supported): Removed the EditorCommandSource argument. These
2696         functions are now only used when called from DOM.
2697         (WebCore::supportedFromMenuOrKeyBinding): Ditto.
2698         (WebCore::supportedCopyCut): Ditto.
2699         (WebCore::supportedPaste): Ditto.
2700         (WebCore::enabledDismissCorrectionPanel): Changed the supported function to
2701         an enabled function. It was incorrect to say that this is "supported" only
2702         when the correction panel is up. Correct to say that it is "enabled" only
2703         then. And also probably OK to enable it even when the selection is not in
2704         editable text, as long as the panel is up.
2705         (WebCore::createCommandMap): Moved conditional commands out of the main
2706         array into a separate section at the end.
2707         (WebCore::internalCommand): Added.
2708         (WebCore::Editor::command): Changed to use the new internalCommand function
2709         and simplified by relying on the null check in the Command constructor.
2710         (WebCore::Editor::commandIsSupportedFromMenuOrKeyBinding): Added.
2711         (WebCore::Editor::Command::Command): Removed unneeded initialization of
2712         m_source, which is never looked at if m_command is 0. Added feature of
2713         passing a null command pointer to the non-default constructor.
2714         (WebCore::Editor::Command::isSupported): Changed to only call the
2715         per-command isSupported function when the command source is DOM.
2716         Accordingly that function is now called isSupportedFromDOM.
2717
2718 2010-12-23  Matthew Delaney  <mdelaney@apple.com>
2719
2720         Reviewed by Simon Fraser.
2721
2722         Incorrect layer property used noted as changed in GraphicsLayerCA::setAcceleratesDrawing
2723         https://bugs.webkit.org/show_bug.cgi?id=51560
2724
2725         No new tests.
2726
2727         * platform/graphics/ca/GraphicsLayerCA.cpp:
2728         (WebCore::GraphicsLayerCA::setAcceleratesDrawing):
2729
2730 2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>
2731
2732         Reviewed by Andreas Kling.
2733
2734         [Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
2735         https://bugs.webkit.org/show_bug.cgi?id=35635
2736
2737         Explicitly set text/html data on QClipboard as UTF-8 and also include a <meta>
2738         tag informing the OS that the data is in UTF-8 format.
2739
2740         * platform/qt/PasteboardQt.cpp:
2741         (WebCore::Pasteboard::writeSelection):
2742
2743 2010-12-23  Justin Schuh  <jschuh@chromium.org>
2744
2745         Reviewed by Eric Seidel.
2746
2747         CSSCursorImageValue destructor should clear referenced element.
2748         https://bugs.webkit.org/show_bug.cgi?id=51417
2749
2750         Calls correct method to clear image and renames method to avoid future confusion.
2751
2752         Test: svg/css/cursor-image-replace.svg
2753
2754         * css/CSSCursorImageValue.cpp:
2755         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
2756         * svg/SVGElement.cpp:
2757         (WebCore::SVGElement::cursorImageValueRemoved):
2758         * svg/SVGElement.h:
2759
2760 2010-12-22  Sam Weinig  <sam@webkit.org>
2761
2762         Reviewed by Darin Adler.
2763
2764         WebKit2 needs to mirror the frame tree in the UIProcess
2765         https://bugs.webkit.org/show_bug.cgi?id=51546
2766
2767         - Add client functions to notify that a frame has been added or
2768           removed from the page cache.
2769
2770         * history/CachedFrame.cpp:
2771         (WebCore::CachedFrameBase::restore):
2772         (WebCore::CachedFrame::CachedFrame):
2773         * history/CachedFrame.h:
2774         * loader/EmptyClients.h:
2775         (WebCore::EmptyFrameLoaderClient::didSaveToPageCache):
2776         (WebCore::EmptyFrameLoaderClient::didRestoreFromPageCache):
2777         * loader/FrameLoaderClient.h:
2778
2779 2010-12-22  Matthew Delaney  <mdelaney@apple.com>
2780
2781         Reviewed by Simon Fraser.
2782
2783         Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces
2784         This patch also changes USE_IOSURFACE to instead follow USE(IOSURFACE)
2785         https://bugs.webkit.org/show_bug.cgi?id=51279
2786
2787         * html/HTMLCanvasElement.cpp: For IOSurface, use setNeedsStyleRecalc
2788         * html/canvas/CanvasRenderingContext2D.cpp: Use new flag
2789         * platform/graphics/ImageBuffer.h: Use new flag
2790         * platform/graphics/cg/ImageBufferCG.cpp: Use new flag
2791
2792 2010-12-20  Adrienne Walker  <enne@google.com>
2793
2794         Reviewed by Kenneth Russell.
2795
2796         [chromium] Tile root layer of the compositor.
2797         https://bugs.webkit.org/show_bug.cgi?id=49947
2798
2799         Refactor root layer update and drawing from LayerRendererChromium into
2800         LayerTilerChromium.  The root layer is now drawn as multiple tiles
2801         rather than as one single large texture.  Scrollbars are now drawn
2802         separately rather than as part of the root layer.
2803
2804         Test: LayoutTests/compositing/
2805
2806         * WebCore.gypi:
2807         * page/FrameView.cpp:
2808         (WebCore::FrameView::repaintContentRectangle):
2809         * platform/ScrollView.cpp:
2810         (WebCore::ScrollView::ScrollView):
2811         (WebCore::ScrollView::setClipsRepaints):
2812         * platform/ScrollView.h:
2813         (WebCore::ScrollView::clipsRepaints):
2814         * platform/graphics/chromium/LayerChromium.h:
2815         * platform/graphics/chromium/LayerRendererChromium.cpp:
2816         (WebCore::LayerRendererChromium::LayerRendererChromium):
2817         (WebCore::LayerRendererChromium::~LayerRendererChromium):
2818         (WebCore::LayerRendererChromium::useShader):
2819         (WebCore::LayerRendererChromium::verticalScrollbarRect):
2820         (WebCore::LayerRendererChromium::horizontalScrollbarRect):
2821         (WebCore::LayerRendererChromium::invalidateRootLayerRect):
2822         (WebCore::LayerRendererChromium::updateAndDrawRootLayer):
2823         (WebCore::LayerRendererChromium::drawLayers):
2824         (WebCore::LayerRendererChromium::setRootLayer):
2825         (WebCore::LayerRendererChromium::initializeSharedObjects):
2826         (WebCore::LayerRendererChromium::cleanupSharedObjects):
2827         * platform/graphics/chromium/LayerRendererChromium.h:
2828         * platform/graphics/chromium/LayerTilerChromium.cpp: Added.
2829         (WebCore::LayerTilerChromium::create):
2830         (WebCore::LayerTilerChromium::LayerTilerChromium):
2831         (WebCore::LayerTilerChromium::~LayerTilerChromium):
2832         (WebCore::LayerTilerChromium::layerRendererContext):
2833         (WebCore::LayerTilerChromium::setTileSize):
2834         (WebCore::LayerTilerChromium::reset):
2835         (WebCore::LayerTilerChromium::createTile):
2836         (WebCore::LayerTilerChromium::invalidateTiles):
2837         (WebCore::LayerTilerChromium::contentRectToTileIndices):
2838         (WebCore::LayerTilerChromium::contentRectToLayerRect):
2839         (WebCore::LayerTilerChromium::layerRectToContentRect):
2840         (WebCore::LayerTilerChromium::tileIndex):
2841         (WebCore::LayerTilerChromium::tileContentRect):
2842         (WebCore::LayerTilerChromium::tileLayerRect):
2843         (WebCore::LayerTilerChromium::invalidateRect):
2844         (WebCore::LayerTilerChromium::invalidateEntireLayer):
2845         (WebCore::LayerTilerChromium::update):
2846         (WebCore::LayerTilerChromium::setLayerPosition):
2847         (WebCore::LayerTilerChromium::draw):
2848         (WebCore::LayerTilerChromium::resizeLayer):
2849         (WebCore::LayerTilerChromium::growLayerToContain):
2850         (WebCore::LayerTilerChromium::Tile::~Tile):
2851         (WebCore::LayerTilerChromium::Tile::releaseTextureId):
2852         * platform/graphics/chromium/LayerTilerChromium.h: Added.
2853         (WebCore::LayerTilerChromium::Tile::Tile):
2854         (WebCore::LayerTilerChromium::Tile::textureId):
2855         (WebCore::LayerTilerChromium::Tile::dirty):
2856         (WebCore::LayerTilerChromium::Tile::clearDirty):
2857         (WebCore::LayerTilerChromium::layerRenderer):
2858
2859 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2860
2861         Reviewed by Eric Seidel.
2862
2863         Editor.h doesn't need to include SelectionController.h
2864         https://bugs.webkit.org/show_bug.cgi?id=51441
2865
2866         Removed #include <Selection.h> from Editor.h.
2867         Also extracted WritingDirection.h from EditingStyle.h and renamed SelectionController::EDirection
2868         to SelectionDirection and moved its declaration from SelectionController.h to VisibleSelection.h
2869
2870         * WebCore.exp.in: Signature changes.
2871         * WebCore.xcodeproj/project.pbxproj: Added WritingDirection.h
2872         * accessibility/AccessibilityRenderObject.cpp:
2873         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): Change due to SelectionDirection.
2874         * editing/EditingStyle.h: Removed WritingDirection and included WritingDirection.h
2875         * editing/Editor.cpp:
2876         (WebCore::Editor::deleteWithDirection): Change due to SelectionDirection.
2877         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
2878         (WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto.
2879         * editing/Editor.h: Removed SelectionController.h; added DocumentMarker.h, Timer.h, VisibleSelection.h
2880         and WritingDirection.h; forward declared CSSMutableStyleDeclaration.
2881         * editing/EditorCommand.cpp:
2882         (WebCore::executeDeleteBackward): Change due to SelectionDirection.
2883         (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto.
2884         (WebCore::executeDeleteForward): Ditto.
2885         (WebCore::executeDeleteToBeginningOfLine): Ditto.
2886         (WebCore::executeDeleteToBeginningOfParagraph): Ditto.
2887         (WebCore::executeDeleteToEndOfLine): Ditto.
2888         (WebCore::executeDeleteToEndOfParagraph): Ditto.
2889         (WebCore::executeDeleteWordBackward): Ditto.
2890         (WebCore::executeDeleteWordForward): Ditto.
2891         (WebCore::executeForwardDelete): Ditto.
2892         (WebCore::executeMoveBackward): Ditto.
2893         (WebCore::executeMoveBackwardAndModifySelection): Ditto.
2894         (WebCore::executeMoveDown): Ditto.
2895         (WebCore::executeMoveDownAndModifySelection): Ditto.
2896         (WebCore::executeMoveForward): Ditto.
2897         (WebCore::executeMoveForwardAndModifySelection): Ditto.
2898         (WebCore::executeMoveLeft): Ditto.
2899         (WebCore::executeMoveLeftAndModifySelection): Ditto.
2900         (WebCore::executeMoveRight): Ditto.
2901         (WebCore::executeMoveRightAndModifySelection): Ditto.
2902         (WebCore::executeMoveToBeginningOfDocument): Ditto.
2903         (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): Ditto.
2904         (WebCore::executeMoveToBeginningOfLine): Ditto.
2905         (WebCore::executeMoveToBeginningOfLineAndModifySelection): Ditto.
2906         (WebCore::executeMoveToBeginningOfParagraph): Ditto.
2907         (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): Ditto.
2908         (WebCore::executeMoveToBeginningOfSentence): Ditto.
2909         (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): Ditto.
2910         (WebCore::executeMoveToEndOfDocument): Ditto.
2911         (WebCore::executeMoveToEndOfDocumentAndModifySelection): Ditto.
2912         (WebCore::executeMoveToEndOfSentence): Ditto.
2913         (WebCore::executeMoveToEndOfSentenceAndModifySelection): Ditto.
2914         (WebCore::executeMoveToEndOfLine): Ditto.
2915         (WebCore::executeMoveToEndOfLineAndModifySelection): Ditto.
2916         (WebCore::executeMoveToEndOfParagraph): Ditto.
2917         (WebCore::executeMoveToEndOfParagraphAndModifySelection): Ditto.
2918         (WebCore::executeMoveParagraphBackwardAndModifySelection): Ditto.
2919         (WebCore::executeMoveParagraphForwardAndModifySelection): Ditto.
2920         (WebCore::executeMoveUp): Ditto.
2921         (WebCore::executeMoveUpAndModifySelection): Ditto.
2922         (WebCore::executeMoveWordBackward): Ditto.
2923         (WebCore::executeMoveWordBackwardAndModifySelection): Ditto.
2924         (WebCore::executeMoveWordForward): Ditto.
2925         (WebCore::executeMoveWordForwardAndModifySelection): Ditto.
2926         (WebCore::executeMoveWordLeft): Ditto.
2927         (WebCore::executeMoveWordLeftAndModifySelection): Ditto.
2928         (WebCore::executeMoveWordRight): Ditto.
2929         (WebCore::executeMoveWordRightAndModifySelection): Ditto.
2930         (WebCore::executeMoveToLeftEndOfLine): Ditto.
2931         (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Ditto.
2932         (WebCore::executeMoveToRightEndOfLine): Ditto.
2933         (WebCore::executeMoveToRightEndOfLineAndModifySelection): Ditto.
2934         * editing/SelectionController.cpp:
2935         (WebCore::SelectionController::willBeModified): Takes SelectionDirection instead of EDirection.
2936         (WebCore::SelectionController::modify): Ditto.
2937         * editing/SelectionController.h: Change due to SelectionDirection.
2938         * editing/TypingCommand.cpp:
2939         (WebCore::TypingCommand::deleteKeyPressed): Ditto.
2940         (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
2941         * editing/VisibleSelection.h: Added SelectionDirection, renamed and moved from EDirection
2942         in SelectionController.h
2943         * editing/WritingDirection.h: Added.
2944         * page/DOMSelection.cpp:
2945         (WebCore::DOMSelection::modify): Change due to SelectionDirection.
2946         (WebCore::DOMSelection::deleteFromDocument): Ditto.
2947         * page/EventHandler.cpp:
2948         (WebCore::EventHandler::handleKeyboardSelectionMovement): Ditto.
2949         * page/Frame.h: Includes SelectionController.h.
2950
2951 2010-12-23  Adam Barth  <abarth@webkit.org>
2952
2953         Reviewed by Darin Adler.
2954
2955         Move V8 to WebCore's implementation of showModalDialog
2956         https://bugs.webkit.org/show_bug.cgi?id=51527
2957
2958         This code is basically verbatim translation from the JavaScriptCore
2959         bindings.  The only intentional difference is in the world selection
2960         for the dialog's frame.  I suspect JavaScriptCore's bindings have a
2961         subtle bug there.
2962
2963         In this patch, I also remove a bunch of now-unneeded code in the
2964         generic bindings.
2965
2966         * bindings/generic/BindingDOMWindow.h:
2967         * bindings/js/JSDOMWindowCustom.cpp:
2968         (WebCore::DialogHandler::dialogCreated):
2969         (WebCore::setUpDialog):
2970         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2971         (WebCore::DialogHandler::DialogHandler):
2972         (WebCore::DialogHandler::dialogCreated):
2973         (WebCore::DialogHandler::returnValue):
2974         (WebCore::setUpDialog):
2975         (WebCore::V8DOMWindow::showModalDialogCallback):
2976         (WebCore::V8DOMWindow::openCallback):
2977         * bindings/v8/specialization/V8BindingDOMWindow.h:
2978
2979 2010-12-23  Alexander Pavlov  <apavlov@chromium.org>
2980
2981         Reviewed by Joseph Pecoraro.
2982
2983         Web Inspector: Can't backspace from CSS value to CSS key field
2984         https://bugs.webkit.org/show_bug.cgi?id=51476
2985
2986         * inspector/front-end/StylesSidebarPane.js:
2987         (WebInspector.StylePropertyTreeElement.prototype.):
2988         (WebInspector.StylePropertyTreeElement.prototype):
2989
2990 2010-12-23  W. James MacLean  <wjmaclean@chromium.org>
2991
2992         Reviewed by Kenneth Russell.
2993
2994         [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
2995         https://bugs.webkit.org/show_bug.cgi?id=51186
2996
2997         No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.
2998
2999         * platform/graphics/chromium/ImageLayerChromium.cpp:
3000         (WebCore::ImageLayerChromium::updateContentsIfDirty):
3001         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
3002         (WebCore::GraphicsContext3D::getImageData):
3003
3004 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3005
3006         Reviewed by Kenneth Rohde Christiansen.
3007
3008         Fix check by undefined macro
3009         https://bugs.webkit.org/show_bug.cgi?id=51531
3010
3011         Fix check by undefined macro
3012
3013         When building EFL port with libsoup, BUILDING_GTK__ is not defined,
3014         leading to warnings during compile. We actually have to use an #ifdef
3015         instead of an #if.
3016
3017         No change in functionality so no new tests.
3018
3019         * platform/network/soup/cache/webkit/soup-cache.h:
3020
3021 2010-12-23  Jonathan Dixon  <joth@chromium.org>
3022
3023         Reviewed by Steve Block.
3024
3025         TouchEvents does not support multi-touch on a page with multiple touch targets
3026         https://bugs.webkit.org/show_bug.cgi?id=51258
3027
3028         Test: fast/events/touch/multi-touch-grouped-targets.html
3029
3030         * page/EventHandler.cpp:
3031         (WebCore::eventNameForTouchPointState):
3032         (WebCore::EventHandler::handleTouchEvent):
3033         Redesigned event handler to ensure all event targets involved in a given
3034         multitouch event get the appropriate event(s) fired.
3035
3036         * platform/PlatformTouchPoint.h: Added end-stop marker for State enum.
3037
3038 2010-12-23  Philippe Normand  <pnormand@igalia.com>
3039
3040         Reviewed by Xan Lopez.
3041
3042         [GTK] media/audio-data-url.html fails since r75504
3043         https://bugs.webkit.org/show_bug.cgi?id=51525
3044
3045         Make the GStreamer media-player advertize 3gpp mime-types as
3046         supported if the 3gp caps are in the typefind factories.
3047
3048         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3049         (WebCore::mimeTypeCache):
3050
3051 2010-12-23  Kent Tamura  <tkent@chromium.org>
3052
3053         Reviewed by Dimitri Glazkov.
3054
3055         Refactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler()
3056         to InputTypes.
3057         https://bugs.webkit.org/show_bug.cgi?id=51093
3058
3059         Move BeforeTextInserted and Wheel event handling, event forwarding to
3060         renderers, and the isindex form submission quirk code to InputTypes.
3061         Also, change the return types of InputType event handlers from 'bool'
3062         to 'void'. We use Event::defaultHandled() to decide whether event
3063         handling should be stopped.
3064
3065         No new tests because this is just a refactoring.
3066
3067         * html/BaseButtonInputType.cpp: bool->void changes
3068         (WebCore::BaseButtonInputType::handleKeydownEvent):
3069         (WebCore::BaseButtonInputType::handleKeypressEvent):
3070         (WebCore::BaseButtonInputType::handleKeyupEvent):
3071         * html/BaseButtonInputType.h: ditto.
3072         * html/BaseCheckableInputType.cpp: ditto.
3073         (WebCore::BaseCheckableInputType::handleKeydownEvent):
3074         (WebCore::BaseCheckableInputType::handleKeypressEvent):
3075         * html/BaseCheckableInputType.h: ditto.
3076         * html/BaseDateAndTimeInputType.cpp:
3077         (WebCore::BaseDateAndTimeInputType::handleKeydownEvent): ditto.
3078         (WebCore::BaseDateAndTimeInputType::handleWheelEvent): Just calls handleWheelEventForSpinButton().
3079         * html/BaseDateAndTimeInputType.h: bool->void change and handleWhellEvent() addition.
3080         * html/CheckboxInputType.cpp: bool->void change
3081         (WebCore::CheckboxInputType::handleKeyupEvent):
3082         * html/CheckboxInputType.h: ditto.
3083         * html/FileInputType.cpp: ditto.
3084         (WebCore::FileInputType::handleDOMActivateEvent):
3085         * html/FileInputType.h: ditto.
3086         * html/HTMLInputElement.cpp:
3087         (WebCore::HTMLInputElement::defaultEventHandler):
3088          - Change return-value handling of InputType event handlers
3089          - Move out beforeTextInserted/wheel event handling and isindex form quirk.
3090         * html/HTMLInputElement.h:
3091         (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
3092          Added so that InputType can call InputElement::handleBeforeTextInsertedEvent().
3093         * html/ImageInputType.cpp: bool->void change
3094         (WebCore::ImageInputType::handleDOMActivateEvent):
3095         * html/ImageInputType.h: ditto.
3096         * html/InputType.cpp: ditto.
3097         (WebCore::InputType::handleClickEvent):
3098         (WebCore::InputType::handleDOMActivateEvent):
3099         (WebCore::InputType::handleKeydownEvent):
3100         (WebCore::InputType::handleKeypressEvent):
3101         (WebCore::InputType::handleKeyupEvent):
3102         (WebCore::InputType::handleBeforeTextInsertedEvent):
3103         (WebCore::InputType::handleWheelEvent): Added default implementation.
3104         (WebCore::InputType::forwardEvent): ditto.
3105         (WebCore::InputType::formForSubmission): ditto.
3106         * html/InputType.h:
3107         * html/IsIndexInputType.cpp:
3108         (WebCore::IsIndexInputType::formForSubmission): Moved from HTMLInputElement.cpp.
3109         * html/IsIndexInputType.h:
3110         * html/NumberInputType.cpp:
3111         (WebCore::isNumberCharacter): Moved from HTMLInputElement.cpp.
3112         (WebCore::NumberInputType::handleKeydownEvent): bool->void change.
3113         (WebCore::NumberInputType::handleBeforeTextInsertedEvent): Moved from HTMInputElement.cpp.
3114         (WebCore::NumberInputType::handleWheelEvent): Added. Just calls handleWheelEventForSpinButton().
3115         * html/NumberInputType.h:
3116         * html/RadioInputType.cpp: bool->void changes.
3117         (WebCore::RadioInputType::handleClickEvent):
3118         (WebCore::RadioInputType::handleKeydownEvent):
3119         (WebCore::RadioInputType::handleKeyupEvent):
3120         * html/RadioInputType.h:
3121         * html/RangeInputType.cpp:
3122         (WebCore::RangeInputType::handleKeydownEvent): ditto.
3123         (WebCore::RangeInputType::forwardEvent): Moved from HTMLInputElement.cpp.
3124         * html/RangeInputType.h:
3125         * html/ResetInputType.cpp: bool->void change.
3126         (WebCore::ResetInputType::handleDOMActivateEvent):
3127         * html/ResetInputType.h: ditto.
3128         * html/SubmitInputType.cpp: ditto.
3129         (WebCore::SubmitInputType::handleDOMActivateEvent):
3130         * html/SubmitInputType.h: ditto.
3131         * html/TextFieldInputType.cpp:
3132         (WebCore::TextFieldInputType::handleKeydownEvent): bool->void change.
3133         (WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto.
3134         (WebCore::TextFieldInputType::handleWheelEventForSpinButton): Moved from HTMLInputElement.cpp.
3135         (WebCore::TextFieldInputType::forwardEvent): ditto.
3136         * html/TextFieldInputType.h:
3137
3138 2010-12-23  Alexander Pavlov  <apavlov@chromium.org>
3139
3140         Reviewed by Joseph Pecoraro.
3141
3142         Web Inspector: After scrolling new property value and cancelling, removed property remains active in page style
3143         https://bugs.webkit.org/show_bug.cgi?id=51390
3144
3145         * inspector/front-end/StylesSidebarPane.js:
3146         (WebInspector.StylePropertyTreeElement.prototype):
3147
3148 2010-12-23  Noel Gordon  <noel.gordon@gmail.com>
3149
3150         Reviewed by Adam Barth.
3151
3152         [chromium] Reduce canvas.toDataURL("image/png") run-time costs 300%
3153         https://bugs.webkit.org/show_bug.cgi?id=51455
3154
3155         Chromium uses the libpng compression defaults.  Good compression results,
3156         but at much larger run-time cost compared to other browsers.  Chrome is 2
3157         times slower than Mozilla 3.6.12 and 3-4 times slower than Safari 5.0.3.
3158
3159         libpng has supported alternative compression methods for some time, they
3160         better meet the dual goals of good compression and run-time cost for the
3161         on-line case, and are well-documented.  Here use Huffman encoding.  It's
3162         2-20% faster than other encodings (Z_RLE, Z_FILTERED) and the compressed
3163         size is within 1% of the Safari 5.0.3 result independent of image size.
3164
3165         No change in behaviour, so no new tests.
3166
3167         * platform/image-encoders/skia/PNGImageEncoder.cpp:
3168         (WebCore::PNGImageEncoder::encode): Apply Huffman image encoding.
3169
3170 2010-12-22  Noel Gordon  <noel.gordon@gmail.com>
3171
3172         Reviewed by Darin Fisher.
3173
3174         [chromium] Optimize canvas.toDataURL("image/png") unpremultiplication loop
3175         https://bugs.webkit.org/show_bug.cgi?id=51321
3176
3177         Follow on from r73890, unroll the SkUnPreMultiply::PMColorToColor() call for
3178         the "image/png" encoder case viz., compute the unpremultiplication in-place.
3179         See https://bugs.webkit.org/show_bug.cgi?id=50804 for reference.
3180
3181         No new tests: canvas.toDataURL() is covered by existing tests.
3182
3183         * platform/image-encoders/skia/PNGImageEncoder.cpp:
3184         (WebCore::preMultipliedBGRAtoRGBA):
3185
3186 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3187
3188         Reviewed by Simon Fraser.
3189
3190         Implement skewX() and skewY() for CSSMatrix.
3191         https://bugs.webkit.org/show_bug.cgi?id=38335
3192
3193         * css/WebKitCSSMatrix.cpp:
3194         (WebCore::WebKitCSSMatrix::skew): Implemented skewX() and skewY().
3195         * css/WebKitCSSMatrix.h: Added skewX() and skewY().
3196         * css/WebKitCSSMatrix.idl: Added skewX() and skewY().
3197
3198 2010-12-22  Simon Fraser  <simon.fraser@apple.com>
3199
3200         Reviewed by Dan Bernstein.
3201
3202         Support unprefixed box-shadow property
3203         https://bugs.webkit.org/show_bug.cgi?id=51448
3204         
3205         Add support for the box-shadow CSS property. We'll currently render this
3206         similarly to -webkit-box-shadow, but a later fix will adjust the blur radius
3207         handling to match the spec.
3208
3209         Test: fast/css/box-shadow.html
3210
3211         * css/CSSComputedStyleDeclaration.cpp:
3212         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implement getComputedStyle
3213         for box-shadow
3214         
3215         * css/CSSParser.cpp:
3216         (WebCore::CSSParser::parseValue):
3217         (WebCore::ShadowParseContext::ShadowParseContext):
3218         (WebCore::ShadowParseContext::commitValue):
3219         (WebCore::ShadowParseContext::commitLength):
3220         (WebCore::ShadowParseContext::commitColor): Support CSSPropertyBoxShadow
3221
3222         * css/CSSPropertyNames.in: add box-shadow
3223
3224         * css/CSSStyleSelector.cpp:
3225         (WebCore::CSSStyleSelector::applyProperty): Add CSSPropertyBoxShadow, and
3226         store in the ShadowData if this is -webkit-box-shadow or not. We'll use this
3227         to adjust radii later.
3228
3229         * css/SVGCSSStyleSelector.cpp:
3230         (WebCore::CSSStyleSelector::applySVGProperty): Add CSSPropertyBoxShadow.
3231         
3232         * page/animation/AnimationBase.cpp:
3233         (WebCore::blendFunc):
3234         (WebCore::PropertyWrapperShadow::blend):
3235         (WebCore::AnimationBase::ensurePropertyMap): Support animations of box-shadow.
3236         
3237         * rendering/style/ShadowData.cpp: Store a flag to say if this is a -webkit-box-shadow.
3238         (WebCore::ShadowData::ShadowData):
3239         (WebCore::ShadowData::operator==):
3240         * rendering/style/ShadowData.h:
3241         (WebCore::ShadowData::ShadowData):
3242         (WebCore::ShadowData::isWebkitBoxShadow):
3243
3244 2010-12-22  Michael Saboff  <msaboff@apple.com>
3245
3246         Reviewed by Sam Weinig.
3247
3248         REGRESSION: Can't shadow/overwrite window.constructor 
3249         (causes TypeError exception)
3250         https://bugs.webkit.org/show_bug.cgi?id=48953
3251
3252         Added code in the javascript code generator to create a setter for
3253         a constructor if the new extended attribute ReplaceableConstructor
3254         is present for the interface.
3255
3256         * bindings/scripts/CodeGeneratorJS.pm:
3257         * page/DOMWindow.idl:
3258
3259 2010-12-22  Steve Lacey  <sjl@chromium.org>
3260
3261         Reviewed by David Levin.
3262
3263         Change css for chromium media controls to deal with the timeline
3264         not expanding when the current time disappears. This happens when
3265         the width of the control drops below 240px.
3266
3267         This change results in a minor pixel difference - the timebar now
3268         aligns better with the time and when the time is not displayed is
3269         now perfectly centered. Disabling the affected tests for now
3270         and will rebaseline.
3271
3272         https://bugs.webkit.org/show_bug.cgi?id=51500
3273
3274         * css/mediaControlsChromium.css:
3275         (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
3276         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
3277         (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
3278         (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
3279
3280 2010-12-22  Mihai Parparita  <mihaip@chromium.org>
3281
3282         Reviewed by Simon Fraser.
3283
3284         the shadow direction is negated in canvas context shadowOffsetY.
3285         https://bugs.webkit.org/show_bug.cgi?id=25619
3286         
3287         Invert shadow offset Y direction in 0-blur path in FontMac::drawGlyps
3288         if we're not transforming shadows (i.e. are rendering in a canvas). Also
3289         use CG shadows if there's a non-translate/flip transform applied
3290         (shadow offsets are supposed to ignore transforms, but the naive/simple
3291         implementation was taking them into account).
3292         
3293         Also does the equivalent changes to FontCGWin.
3294
3295         Test: fast/canvas/fillText-shadow.html
3296
3297         * platform/graphics/GraphicsContext.cpp:
3298         (WebCore::GraphicsContext::shadowsIgnoreTransforms):
3299         * platform/graphics/GraphicsContext.h:
3300         * platform/graphics/mac/FontMac.mm:
3301         (WebCore::Font::drawGlyphs):
3302         * platform/graphics/win/FontCGWin.cpp:
3303         (WebCore::Font::drawGlyphs):
3304
3305 2010-12-22  Sheriff Bot  <webkit.review.bot@gmail.com>
3306
3307         Unreviewed, rolling out r74503.
3308         http://trac.webkit.org/changeset/74503
3309         https://bugs.webkit.org/show_bug.cgi?id=51513
3310
3311         breaks chromium mac debug compile (Requested by tonyg-cr on
3312         #webkit).
3313
3314         * platform/graphics/chromium/ImageLayerChromium.cpp:
3315         (WebCore::ImageLayerChromium::updateContentsIfDirty):
3316         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
3317         (WebCore::GraphicsContext3D::getImageData):
3318
3319 2010-12-22  Dan Bernstein  <mitz@apple.com>
3320
3321         Reviewed by Darin Adler.
3322
3323         Replace runtime checks for hyphenation API availability with compile-time checks.
3324
3325         * platform/text/cf/HyphenationCF.cpp:
3326         (WebCore::::createValueForNullKey): Changed to use CFLocaleCopyCurrent() instead of using the
3327         search locale, which is empty on Windows. On Mac, this is equivalent to using the search locale.
3328         (WebCore::canHyphenate): Added this implementation for when the hyphenation API is not available.
3329         It is identical to the implementation in Hyphenation.cpp.
3330         (WebCore::lastHyphenLocation): Ditto.
3331
3332 2010-12-22  Simon Fraser  <simon.fraser@apple.com>
3333
3334         Reviewed by Darin Adler.
3335
3336         Cache snapshots of plug-ins before painting, to avoid script running during painting
3337         https://bugs.webkit.org/show_bug.cgi?id=51493
3338         
3339         When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
3340         or when printing), plug-ins which otherwise use the CA rendering model
3341         are sent a paint event. Some plug-ins may run script while handling this event,
3342         or out of process plug-ins may process queued requests at this time. Running
3343         script while inside layout or painting can have bad consequences, because it
3344         can result in arbitrary changes to the render tree.
3345         
3346         This patch avoids sending plug-ins paint events inside of painting. Instead,
3347         we ask the plug-ins to cache a snapshot before we paint, and then the software
3348         paint simply draws that snapshot.
3349         
3350         Requires manual test, because the bug happens when Safari does
3351         a page snapshot. It's not possible to tell the Test Netscape Plug-in
3352         to paint without laying out, making an automated test impossible.
3353
3354         * manual-tests/plugins/plugin-paint-causes-layout.html: Added.
3355
3356         * page/FrameView.h:
3357         * page/FrameView.cpp:
3358         (WebCore::FrameView::paintContents): Notify all enclosed widgets
3359         that a flattening paint is going to happen.
3360         (WebCore::FrameView::notifyWidgetsInAllFrames): Utility method 
3361         that tells the RenderView in all subframes to notify their widgets.
3362
3363         * platform/Widget.h:
3364         (WebCore::Widget::notifyWidget): Generic method that can be used
3365         to send messages to widgets. Current messages are just 'before flattening paint'
3366         and 'after flattening paint'. Message has no payload.
3367
3368         * rendering/RenderView.h:
3369         * rendering/RenderView.cpp:
3370         (WebCore::RenderView::getRetainedWidgets):
3371         (WebCore::RenderView::releaseWidgets): Factor code out of updateWidgetPositions(),
3372         since we use it in two places now.
3373         
3374         (WebCore::RenderView::updateWidgetPositions): Use getRetainedWidgets() etc.
3375         (WebCore::RenderView::notifyWidgets): Retain all the widgets, then send
3376         them all the message.
3377
3378         * rendering/RenderWidget.h:
3379         * rendering/RenderWidget.cpp:
3380         (WebCore::RenderWidget::notifyWidget): Pass the message to the widget.
3381
3382 2010-12-22  Adrienne Walker  <enne@google.com>
3383
3384         Reviewed by Kenneth Russell.
3385
3386         Fix null pointer deref when restoring a lost WebGL context.
3387         https://bugs.webkit.org/show_bug.cgi?id=51494
3388
3389         No new tests, as context restored events are not currently testable.
3390
3391         * html/canvas/WebGLRenderingContext.cpp:
3392         (WebCore::WebGLRenderingContext::initializeNewContext):
3393         (WebCore::WebGLRenderingContext::restoreContext):
3394
3395 2010-12-22  Adam Bergkvist  <adam.bergkvist@ericsson.com>
3396
3397         Reviewed by Martin Robinson.
3398
3399         [GTK] Building with Blob support fails again
3400         https://bugs.webkit.org/show_bug.cgi?id=51392
3401
3402         Build fix.
3403
3404         * GNUmakefile.am:
3405
3406 2010-12-22  Dan Bernstein  <mitz@apple.com>
3407
3408         Reviewed by Anders Carlsson.
3409
3410         canHyphenate() always returns true for the default locale
3411         https://bugs.webkit.org/show_bug.cgi?id=51506
3412
3413         No test, since this change only affects performance.
3414
3415         * platform/text/cf/HyphenationCF.cpp:
3416         (WebCore::::createValueForNullKey): Return 0 if hyphenation is not supported for the default locale.
3417         (WebCore::::createValueForKey): Removed whitespace.
3418
3419 2010-12-22  Yury Semikhatsky  <yurys@chromium.org>
3420
3421         Reviewed by Joseph Pecoraro.
3422
3423         Web Inspector: script name gets parsed as HTML in Call stack panel
3424         https://bugs.webkit.org/show_bug.cgi?id=51468
3425
3426         * inspector/front-end/Placard.js:
3427         (WebInspector.Placard.prototype.set subtitle):
3428
3429 2010-12-22  Eric Carlson  <eric.carlson@apple.com>
3430
3431         Reviewed by Darin Adler.
3432
3433         MediaPlayer should look for MIME type in data: URL
3434         https://bugs.webkit.org/show_bug.cgi?id=51195
3435
3436         If no MIME type is passed from the media element for a data: URL, try to get it from
3437         the URL itself.
3438
3439         No new tests are possible because the MIME type is just passed to the media engine.
3440
3441         * platform/graphics/MediaPlayer.cpp:
3442         (WebCore::MediaPlayer::load):
3443
3444 2010-12-22  W. James MacLean  <wjmaclean@chromium.org>
3445
3446         Reviewed by Kenneth Russell.
3447
3448         [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
3449         https://bugs.webkit.org/show_bug.cgi?id=51186
3450
3451         No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.
3452
3453         * platform/graphics/chromium/ImageLayerChromium.cpp:
3454         (WebCore::ImageLayerChromium::updateContentsIfDirty):
3455         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
3456         (WebCore::GraphicsContext3D::getImageData):
3457
3458 2010-12-22  Chris Fleizach  <cfleizach@apple.com>
3459
3460         Reviewed by Darin Adler.
3461
3462         WAI-ARIA menubar role mapped to AXGroup, should be AXMenuBar
3463         https://bugs.webkit.org/show_bug.cgi?id=51488
3464
3465         Test: platform/mac/accessibility/aria-menubar.html
3466
3467         * accessibility/AccessibilityObject.cpp:
3468         (WebCore::createARIARoleMap):
3469
3470 2010-12-22  Zhenyao Mo  <zmo@google.com>
3471
3472         Reviewed by Kenneth Russell.
3473
3474         CopyTex{Sub}Image2D check always if the bound fbo's internal color format is compatible
3475         https://bugs.webkit.org/show_bug.cgi?id=51423
3476
3477         * html/canvas/WebGLRenderingContext.cpp:
3478         (WebCore::WebGLRenderingContext::copyTexImage2D): Remove the isGLES2Compliant flag around format compatibility checking.
3479         (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
3480         (WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat): Helper function to get bound framebuffer's color format; deal with the case of webgl's internal fbo.
3481         * html/canvas/WebGLRenderingContext.h:
3482
3483 2010-12-22  Xan Lopez  <xlopez@igalia.com>
3484
3485         Reviewed by Gustavo Noronha.
3486
3487         [GTK] Compilation fixes with GTK+ 2.91.7
3488         https://bugs.webkit.org/show_bug.cgi?id=51487
3489
3490         * platform/gtk/GtkVersioning.h: do not define GDK_DISPLAY for
3491         backwards compatibility, it's now defined again in GTK+ 3.x.
3492         * platform/gtk/PasteboardHelper.cpp: do not call GDK functions to
3493         initialize global static variables (!). These are called when the
3494         .so is loaded, and they now require GType to be initialized and
3495         will crash. Initialize them once from the ctor, which is a more
3496         common pattern anyway.
3497         (WebCore::initGdkAtoms): new method to initialize static variables.
3498         (WebCore::PasteboardHelper::PasteboardHelper): call it.
3499         * plugins/gtk/PluginViewGtk.cpp: do not include gdkconfig.h when
3500         using GTK+ 3.x, since it's no longer installed.
3501
3502 2010-12-22  Dirk Schulze  <krit@wbekit.org>
3503
3504         Reviewed by Nikolas Zimmermann.
3505
3506         Cleanup SVG code according to the webkit style rules 2
3507         https://bugs.webkit.org/show_bug.cgi?id=51461
3508
3509         Second patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
3510
3511         No changes of functionality, so no new tests. 
3512
3513         * svg/SVGFEDisplacementMapElement.cpp:
3514         (WebCore::SVGFEDisplacementMapElement::stringToChannel):
3515         * svg/SVGFEDistantLightElement.h:
3516         * svg/SVGFEFuncAElement.h:
3517         * svg/SVGFEFuncBElement.h:
3518         * svg/SVGFEFuncGElement.h:
3519         * svg/SVGFEFuncRElement.h:
3520         * svg/SVGFEMergeElement.cpp:
3521         (WebCore::SVGFEMergeElement::build):
3522         * svg/SVGFEMorphologyElement.cpp:
3523         * svg/SVGFEPointLightElement.h:
3524         * svg/SVGFESpecularLightingElement.cpp:
3525         (WebCore::SVGFESpecularLightingElement::findLights):
3526         * svg/SVGFESpotLightElement.h:
3527         * svg/SVGFitToViewBox.cpp:
3528         (WebCore::SVGFitToViewBox::parseViewBox):
3529         (WebCore::SVGFitToViewBox::isKnownAttribute):
3530         * svg/SVGFontFaceElement.cpp:
3531         (WebCore::cssPropertyIdForSVGAttributeName):
3532         * svg/SVGFontFaceElement.h:
3533         (WebCore::SVGFontFaceElement::associatedFontElement):
3534         * svg/SVGFontFaceNameElement.h:
3535         * svg/SVGFontFaceSrcElement.cpp:
3536         * svg/SVGFontFaceSrcElement.h:
3537         * svg/SVGFontFaceUriElement.h:
3538         * svg/SVGForeignObjectElement.h:
3539         * svg/SVGGlyphElement.cpp:
3540         (WebCore::parseArabicForm):
3541         (WebCore::parseOrientation):
3542         * svg/SVGGlyphElement.h:
3543         (WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
3544         (WebCore::SVGGlyphIdentifier::inheritedValue):
3545         (WebCore::SVGGlyphIdentifier::operator==):
3546         (WebCore::SVGGlyphElement::rendererIsNeeded):
3547         * svg/SVGGlyphMap.h:
3548         (WebCore::GlyphMapNode::GlyphMapNode):
3549         (WebCore::GlyphMapNode::create):
3550         (WebCore::SVGGlyphMap::SVGGlyphMap):
3551         (WebCore::SVGGlyphMap::add):
3552         (WebCore::SVGGlyphMap::compareGlyphPriority):
3553         (WebCore::SVGGlyphMap::get):
3554         (WebCore::SVGGlyphMap::clear):
3555         * svg/SVGGradientElement.cpp:
3556         * svg/SVGHKernElement.cpp:
3557         * svg/SVGHKernElement.h:
3558         (WebCore::SVGHKernElement::rendererIsNeeded):
3559         * svg/SVGImageElement.h:
3560         * svg/SVGImageLoader.cpp:
3561         * svg/SVGImageLoader.h:
3562         * svg/SVGLangSpace.cpp:
3563         (WebCore::SVGLangSpace::parseMappedAttribute):
3564         (WebCore::SVGLangSpace::isKnownAttribute):
3565         * svg/SVGLangSpace.h:
3566         (WebCore::SVGLangSpace::xmllang):
3567         * svg/SVGMetadataElement.h:
3568         * svg/SVGMissingGlyphElement.h:
3569         (WebCore::SVGMissingGlyphElement::rendererIsNeeded):
3570         * svg/SVGPaint.cpp:
3571         (WebCore::SVGPaint::cssText):
3572         * svg/SVGPaint.h:
3573         (WebCore::SVGPaint::create):
3574         (WebCore::SVGPaint::paintType):
3575         (WebCore::SVGPaint::isSVGPaint):
3576         * svg/SVGParserUtilities.cpp: