WebCore/ChangeLog

   1 2006-11-08  Darin Adler  <darin@apple.com>
   2
   3         Reviewed by Anders.
   4
   5         - added event parameters to focus-related functions so we can
   6           implement the "option-tab to all links" behavior without relying
   7           on a global "current event" -- also makes it work with DOM events
   8
   9         * page/Frame.h: Removed unneeded includes. Moved some functions
  10         that were misplaced into the appropriate sections.
  11         * page/Frame.cpp:
  12         (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
  13         PlatformKeyboardEvent to the DOM keyboard event class.
  14         (WebCore::Frame::tabsToLinks): Added event parameter.
  15         (WebCore::Frame::tabsToAllControls): Ditto.
  16         (WebCore::scanForForm): Fixed code that incorrectly assumes
  17         that an iframe is an HTMLFrameElement (no longer true since Geoff
  18         changed the class hierarchy a bit).
  19         (WebCore::Frame::hitTestResultAtPoint): Ditto.
  20
  21         * bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
  22         that were misplaced into the appropriate sections.
  23         * bridge/mac/FrameMac.mm:
  24         (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
  25         a PlatformKeyboardEvent.
  26         (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
  27         and pass event into next/previousFocusNode.
  28         (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
  29         the AppKit current event, if it's a keyboard event. Really just a hack that's
  30         needed to preserve some code we can remove once we deal with the last NSView-
  31         based form control.
  32         (WebCore::isKeyboardOptionTab): Added.
  33         (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
  34         option (alt) key is down.
  35         (WebCore::FrameMac::tabsToAllControls): Ditto.
  36         (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
  37         call resetMultipleFormSubmissionProtection() explicitly instead.
  38         (WebCore::FrameMac::mouseDown): Ditto.
  39
  40         * bridge/mac/WebCoreAXObject.mm:
  41         (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
  42         assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
  43         changed the class hierarchy a bit).
  44         (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
  45         prepareForUserAction() to call resetMultipleFormSubmissionProtection()
  46         explicitly instead.
  47
  48         * page/FrameView.h:
  49         * page/FrameView.cpp:
  50         (WebCore::FrameView::advanceFocus): Changed function to take an
  51         event parameter, and decide the direction based on the shift key
  52         modifier instead of a passed-in boolean.
  53
  54         * dom/Document.h:
  55         * dom/Document.cpp:
  56         (WebCore::Document::nextFocusNode): Added event parameter.
  57         (WebCore::Document::previousFocusNode): Ditto.
  58         * dom/Node.h:
  59         * dom/Node.cpp:
  60         (WebCore::Node::isKeyboardFocusable): Ditto.
  61         * html/HTMLAnchorElement.h:
  62         * html/HTMLAnchorElement.cpp:
  63         (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
  64         * html/HTMLGenericFormElement.h:
  65         * html/HTMLGenericFormElement.cpp:
  66         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
  67         * html/HTMLInputElement.h:
  68         * html/HTMLInputElement.cpp:
  69         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
  70         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
  71         * html/HTMLSelectElement.h:
  72         * html/HTMLSelectElement.cpp:
  73         (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
  74         * html/HTMLTextAreaElement.h:
  75         * html/HTMLTextAreaElement.cpp:
  76         (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
  77
  78         * dom/EventTargetNode.cpp:
  79         (WebCore::EventTargetNode::defaultEventHandler): Pass event to the
  80         advanceFocus function.
  81
  82         * platform/TextField.h:
  83         * platform/mac/TextFieldMac.mm: Removed the non-search field code.
  84
  85         * platform/mac/WebCoreTextField.h:
  86         * platform/mac/WebCoreTextField.mm: Removed the non-search field code.
  87         (-[WebCoreTextFieldController controlTextDidChange:]): Removed the
  88         call to FrameMac::handleKeyboardOptionTabInView, which is no longer
  89         needed since the default handler in HTMLInputElement takes care of
  90         option-tab.
  91
  92         * platform/mac/SliderMac.mm:
  93         (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
  94         and pass event into tabsToAllControls.
  95         (Slider::focusPolicy): Ditto.
  96
  97         * rendering/RenderLineEdit.cpp:
  98         (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
  99         (WebCore::RenderLineEdit::updateFromElement): Ditto.
 100
 101 2006-11-08  Brady Eidson  <beidson@apple.com>
 102
 103         Reviewed by Dave Harrison, Oliver, and Darin
 104         (oh my!  where was superkevin on this one?)
 105
 106         <rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
 107
 108         More "free nil checking" we lost in the transition from ObjC to C++
 109
 110         * loader/mac/FrameLoaderMac.mm:
 111         (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
 112         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
 113
 114 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
 115
 116         Reviewed by Adam.
 117
 118         Move more code into editor.
 119
 120         * WebCore.exp:
 121         * bridge/EditorClient.h:
 122         * bridge/mac/FrameMac.h:
 123         * bridge/mac/FrameMac.mm:
 124         * bridge/mac/WebCoreFrameBridge.h:
 125         * dom/Document.cpp:
 126         (WebCore::Document::relinquishesEditingFocus):
 127         (WebCore::Document::acceptsEditingFocus):
 128         (WebCore::Document::didBeginEditing):
 129         (WebCore::Document::didEndEditing):
 130         * editing/Editor.cpp:
 131         (WebCore::Editor::indent):
 132         (WebCore::Editor::outdent):
 133         * editing/Editor.h:
 134         * page/Frame.cpp:
 135         * page/Frame.h:
 136
 137 2006-11-08  Beth Dakin  <bdakin@apple.com>
 138
 139         Reviewed by Adam.
 140
 141         Add ability to HitTestResult to ask if the inner non-shared node is
 142         content editable.
 143
 144         * WebCore.exp: Export HitTestResult::isContentEditable()
 145         * rendering/HitTestResult.cpp:
 146         (WebCore::HitTestResult::isContentEditable):
 147         * rendering/HitTestResult.h:
 148
 149 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
 150
 151         Build fix.
 152
 153         * WebCore.xcodeproj/project.pbxproj:
 154         Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
 155
 156 2006-11-08  Timothy Hatcher  <timothy@apple.com>
 157
 158         Reviewed by Darin.
 159
 160         <rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
 161         <rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
 162
 163         Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
 164
 165         * bindings/objc/DOM.mm:
 166         (WebCore::kit):
 167         (-[DOMNode lineBoxRects]):
 168         (-[DOMRange boundingBox]):
 169         (-[DOMRange lineBoxRects]):
 170         * bindings/objc/DOMPrivate.h:
 171         * dom/Range.cpp:
 172         (WebCore::Range::boundingBox):
 173         (WebCore::Range::addLineBoxRects):
 174         * dom/Range.h:
 175         * rendering/RenderContainer.cpp:
 176         (WebCore::RenderContainer::addLineBoxRects):
 177         * rendering/RenderContainer.h:
 178         * rendering/RenderObject.cpp:
 179         (WebCore::RenderObject::addLineBoxRects):
 180         * rendering/RenderObject.h:
 181         * rendering/RenderText.cpp:
 182         (WebCore::RenderText::addLineBoxRects):
 183         * rendering/RenderText.h:
 184
 185 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
 186
 187         Reviewed by Oliver.
 188
 189         Move methods from the bridge and frame into editor.
 190
 191         * WebCore.exp:
 192         * bridge/EditorClient.h:
 193         * bridge/mac/WebCoreFrameBridge.h:
 194         * bridge/mac/WebCoreFrameBridge.mm:
 195         * editing/Editor.cpp:
 196         (WebCore::Editor::removeFormattingAndStyle):
 197         (WebCore::Editor::applyStyle):
 198         (WebCore::Editor::applyParagraphStyle):
 199         (WebCore::Editor::applyStyleToSelection):
 200         (WebCore::Editor::applyParagraphStyleToSelection):
 201         (WebCore::Editor::toggleBold):
 202         (WebCore::Editor::toggleItalic):
 203         (WebCore::Editor::selectionStartHasStyle):
 204         * editing/Editor.h:
 205         * editing/JSEditor.cpp:
 206         * page/Frame.cpp:
 207         * page/Frame.h:
 208
 209 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
 210
 211         Reviewed by Beth.
 212
 213         Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
 214         be able to dispatch user events even when off-screen, so we have to support
 215         off-screen windows when handling mouse events.
 216
 217         * platform/Screen.h:
 218         * platform/mac/PlatformMouseEventMac.mm:
 219         (WebCore::globalPoint): Grab the best screen instead of the screen you're
 220         on, since you might be off-screen.
 221         * platform/mac/ScreenMac.mm:
 222         (WebCore::screenForWindow):
 223
 224 2006-11-08  Darin Adler  <darin@apple.com>
 225
 226         - fix bug caused by last-minute change to my check-in last night
 227           that is causing layout tests to hang
 228
 229         * dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
 230         * loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn
 231         a null string into an empty string before calling completeURL.
 232
 233 2006-11-08  Brady Eidson <beidson@apple.com>
 234
 235         Reviewed by Maciej
 236
 237         If the request has already been aborted, bail out of didFinishLoading()
 238         immediately.  This prevents state change notifications that aren't
 239         needed.
 240
 241         * xml/xmlhttprequest.cpp:
 242         (WebCore::XMLHttpRequest::didFinishLoading):
 243
 244 2006-11-08  Darin Adler  <darin@apple.com>
 245
 246         - another attempt to fix Qt build
 247
 248         * loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
 249
 250 2006-11-08  Darin Adler  <darin@apple.com>
 251
 252         Reviewed by Geoff.
 253
 254         - stray bits of my FrameLoader patch that I left out by accident
 255
 256         * loader/FrameLoader.cpp:
 257         (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer()
 258         inside the FrameLoader class.
 259         (WebCore::FrameLoader::requestFrame): Use less DeprecatedString.
 260         (WebCore::FrameLoader::clear): Stop the redirection timer.
 261         (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the
 262         entire function in an if statement. Use less DeprecatedString.
 263         (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator.
 264         (WebCore::FrameLoader::scheduleRefresh): Ditto.
 265         (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer()
 266         inside the FrameLoader class.
 267         * loader/mac/FrameLoaderMac.mm:
 268         (WebCore::FrameLoader::load): Ditto.
 269         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
 270
 271 2006-11-07  Beth Dakin  <bdakin@apple.com>
 272
 273         Reviewed by Hyatt.
 274
 275         Another go at fix for <rdar://problem/4820814> A crash occurs at
 276         WebCore::HitTestResult::spellingToolTip() when mousing down on
 277         iframe at www.macsurfer.com
 278
 279         The fix from yesterday caused a layout test regression which
 280         exposed an existing bug. The existing bug was that we allowed text
 281         nodes to stay in the head tag, but other browsers move them to the
 282         body. The previous fix also caused a performance regression, which
 283         was seemingly easy to fix by moving the new clause in
 284         HTMLParser::handleError() to be below the HTMLElement case.
 285
 286         * html/HTMLDocument.cpp:
 287         (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to
 288         be the child of the document.
 289         * html/HTMLHeadElement.cpp:
 290         (WebCore::HTMLHeadElement::childAllowed): Do not allow non-
 291         whitespace text nodes to be children of the head.
 292         * html/HTMLHeadElement.h:
 293         * html/HTMLParser.cpp:
 294         (WebCore::HTMLParser::handleError): Error case for comment nodes.
 295         * page/FrameView.cpp:
 296         (WebCore::FrameView::handleMousePressEvent): Safety-net null check
 297         for the original crash.
 298
 299 2006-11-07  Darin Adler  <darin@apple.com>
 300
 301         - another attempt to fix Qt build
 302
 303         * loader/icon/IconLoader.h: Added missing include.
 304
 305 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
 306
 307         Reviewed by Tim Hatcher.
 308
 309         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
 310
 311         None of Screen's responsibilities require up-calls to WebKit or delegates,
 312         so WebCore can handle it all.
 313
 314         Moved Screen back from page/ to platform/ because it's a platform
 315         abstraction again.
 316
 317         Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
 318         since the two were always used together.
 319
 320         Changed pixel depth queries to query the deepest screen. Darin mentioned
 321         that it might have been a feature, not a bug, to use the main/menubar screen
 322         regardless of the screen you were on. For scaling and flipping that's not
 323         the case, but for querying pixel depth I think it is. You want to know
 324         about the highest pixel depth your content may display on.
 325
 326         Tests still pass.
 327
 328         * WebCore.exp:
 329         * WebCore.xcodeproj/project.pbxproj:
 330         * page/Page.cpp:
 331         (WebCore::Page::Page):
 332         * page/Page.h:
 333         * page/Screen.cpp: Removed.
 334         * page/Screen.h: Removed.
 335         * page/ScreenClient.h: Removed.
 336         * platform/mac/PlatformMouseEventMac.mm:
 337         (WebCore::globalPoint):
 338         * platform/mac/ScreenMac.mm:
 339         (WebCore::window):
 340         (WebCore::bestScreen):
 341         (WebCore::Screen::depth):
 342         (WebCore::Screen::depthPerComponent):
 343         (WebCore::Screen::isMonochrome):
 344         (WebCore::Screen::rect):
 345         (WebCore::Screen::usableRect):
 346         (WebCore::toUserSpace):
 347         (WebCore::toDeviceSpace):
 348
 349 2006-11-07  Darin Adler  <darin@apple.com>
 350
 351         - try to fix Qt build
 352
 353         * CMakeLists.txt: Updated for some file changes.
 354         * WebCoreSources.bkl: Ditto.
 355
 356 2006-11-07  Darin Adler  <darin@apple.com>
 357
 358         Reviewed by Geoff.
 359
 360         - moved loader code from Frame/FrameMac to FrameLoader
 361
 362         * WebCore.exp:
 363         * WebCore.xcodeproj/project.pbxproj:
 364         * bindings/js/JSXSLTProcessor.h:
 365         * bindings/js/kjs_events.cpp:
 366         (KJS::JSLazyEventListener::parseCode):
 367         * bindings/js/kjs_html.cpp:
 368         (KJS::JSHTMLDocument::putValueProperty):
 369         * bindings/js/kjs_navigator.cpp:
 370         (KJS::Navigator::getValueProperty):
 371         * bindings/js/kjs_proxy.cpp:
 372         (WebCore::KJSProxy::initScriptIfNeeded):
 373         * bindings/js/kjs_window.cpp:
 374         (KJS::Screen::Screen):
 375         (KJS::createNewWindow):
 376         (KJS::Window::getValueProperty):
 377         (KJS::Window::put):
 378         (KJS::Window::isSafeScript):
 379         (KJS::WindowFunc::callAsFunction):
 380         (KJS::ScheduledAction::execute):
 381         (KJS::Location::getValueProperty):
 382         (KJS::Location::put):
 383         (KJS::Location::toString):
 384         (KJS::LocationFunc::callAsFunction):
 385         (KJS::History::getValueProperty):
 386         (KJS::HistoryFunc::callAsFunction):
 387         * bindings/objc/DOM.mm:
 388         (+[DOMNode _nodeWith:WebCore::]):
 389         * bridge/mac/FrameMac.h:
 390         * bridge/mac/FrameMac.mm:
 391         (WebCore::FrameMac::~FrameMac):
 392         (WebCore::FrameMac::setView):
 393         (WebCore::FrameMac::setStatusBarText):
 394         * bridge/mac/WebCoreFrameBridge.h:
 395         * bridge/mac/WebCoreFrameBridge.mm:
 396         (-[WebCoreFrameBridge close]):
 397         (-[WebCoreFrameBridge addData:]):
 398         (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
 399         (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
 400         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
 401         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
 402         (-[WebCoreFrameBridge baseURL]):
 403         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
 404         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
 405         (-[WebCoreFrameBridge canProvideDocumentSource]):
 406         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
 407         * css/cssparser.cpp:
 408         (WebCore::CSSParser::parseContent):
 409         * dom/DOMImplementation.cpp:
 410         (WebCore::DOMImplementation::createDocument):
 411         (WebCore::DOMImplementation::createHTMLDocument):
 412         * dom/DOMImplementation.h:
 413         * dom/Document.cpp:
 414         (WebCore::Document::readyState):
 415         (WebCore::Document::updateTitle):
 416         (WebCore::Document::open):
 417         (WebCore::Document::close):
 418         (WebCore::Document::implicitClose):
 419         (WebCore::Document::processHttpEquiv):
 420         (WebCore::Document::referrer):
 421         (WebCore::Document::finishedParsing):
 422         * dom/ProcessingInstruction.cpp:
 423         (WebCore::ProcessingInstruction::checkStyleSheet):
 424         * dom/XMLTokenizer.cpp:
 425         (WebCore::XMLTokenizer::endElementNs):
 426         (WebCore::ignorableWhitespaceHandler):
 427         (WebCore::XMLTokenizer::notifyFinished):
 428         * editing/TextIterator.cpp:
 429         (WebCore::TextIterator::rangeFromLocationAndLength):
 430         * html/HTMLAnchorElement.cpp:
 431         (WebCore::HTMLAnchorElement::defaultEventHandler):
 432         * html/HTMLBaseElement.cpp:
 433         (WebCore::HTMLBaseElement::process):
 434         * html/HTMLDocument.cpp:
 435         (WebCore::HTMLDocument::lastModified):
 436         * html/HTMLFormElement.cpp:
 437         (WebCore::HTMLFormElement::formData):
 438         (WebCore::HTMLFormElement::submit):
 439         * html/HTMLFrameElementBase.cpp:
 440         (WebCore::HTMLFrameElementBase::isURLAllowed):
 441         (WebCore::HTMLFrameElementBase::openURL):
 442         (WebCore::HTMLFrameElementBase::willRemove):
 443         * html/HTMLInputElement.cpp:
 444         (WebCore::HTMLInputElement::setValueFromRenderer):
 445         * html/HTMLLinkElement.cpp:
 446         (WebCore::HTMLLinkElement::process):
 447         * html/HTMLParser.cpp:
 448         (WebCore::HTMLParser::handleError):
 449         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
 450         * html/HTMLPreElement.idl:
 451         * html/HTMLScriptElement.cpp:
 452         (WebCore::HTMLScriptElement::parseMappedAttribute):
 453         (WebCore::HTMLScriptElement::insertedIntoDocument):
 454         * html/HTMLTokenizer.cpp:
 455         (WebCore::HTMLTokenizer::scriptExecution):
 456         (WebCore::HTMLTokenizer::parseTag):
 457         (WebCore::HTMLTokenizer::write):
 458         (WebCore::HTMLTokenizer::stopParsing):
 459         (WebCore::HTMLTokenizer::timerFired):
 460         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
 461         (WebCore::KCanvasFilterQuartz::prepareFilter):
 462         * ksvg2/svg/SVGAElement.cpp:
 463         (WebCore::SVGAElement::defaultEventHandler):
 464         * ksvg2/svg/SVGElement.cpp:
 465         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
 466         * loader/DocLoader.cpp:
 467         (WebCore::DocLoader::setLoadInProgress):
 468         * loader/FrameLoader.cpp:
 469         (WebCore::FormSubmission::FormSubmission):
 470         (WebCore::ScheduledRedirection::):
 471         (WebCore::ScheduledRedirection::ScheduledRedirection):
 472         (WebCore::cancelAll):
 473         (WebCore::getString):
 474         (WebCore::isBackForwardLoadType):
 475         (WebCore::numRequests):
 476         (WebCore::FrameLoader::FrameLoader):
 477         (WebCore::FrameLoader::~FrameLoader):
 478         (WebCore::FrameLoader::createWindow):
 479         (WebCore::FrameLoader::changeLocation):
 480         (WebCore::FrameLoader::urlSelected):
 481         (WebCore::FrameLoader::requestFrame):
 482         (WebCore::FrameLoader::loadSubframe):
 483         (WebCore::FrameLoader::submitFormAgain):
 484         (WebCore::FrameLoader::submitForm):
 485         (WebCore::FrameLoader::stopLoading):
 486         (WebCore::FrameLoader::stop):
 487         (WebCore::FrameLoader::closeURL):
 488         (WebCore::FrameLoader::cancelRedirection):
 489         (WebCore::FrameLoader::iconURL):
 490         (WebCore::FrameLoader::didOpenURL):
 491         (WebCore::FrameLoader::didExplicitOpen):
 492         (WebCore::FrameLoader::replaceContentsWithScriptResult):
 493         (WebCore::FrameLoader::executeScript):
 494         (WebCore::FrameLoader::cancelAndClear):
 495         (WebCore::FrameLoader::clear):
 496         (WebCore::FrameLoader::receivedFirstData):
 497         (WebCore::FrameLoader::responseMIMEType):
 498         (WebCore::FrameLoader::setResponseMIMEType):
 499         (WebCore::FrameLoader::begin):
 500         (WebCore::FrameLoader::write):
 501         (WebCore::FrameLoader::end):
 502         (WebCore::FrameLoader::endIfNotLoading):
 503         (WebCore::FrameLoader::startIconLoader):
 504         (WebCore::FrameLoader::commitIconURLToIconDatabase):
 505         (WebCore::FrameLoader::gotoAnchor):
 506         (WebCore::FrameLoader::finishedParsing):
 507         (WebCore::FrameLoader::loadDone):
 508         (WebCore::FrameLoader::checkCompleted):
 509         (WebCore::FrameLoader::checkEmitLoadEvent):
 510         (WebCore::FrameLoader::baseURL):
 511         (WebCore::FrameLoader::baseTarget):
 512         (WebCore::FrameLoader::completeURL):
 513         (WebCore::FrameLoader::scheduleRedirection):
 514         (WebCore::FrameLoader::scheduleLocationChange):
 515         (WebCore::FrameLoader::scheduleRefresh):
 516         (WebCore::FrameLoader::isScheduledLocationChangePending):
 517         (WebCore::FrameLoader::scheduleHistoryNavigation):
 518         (WebCore::FrameLoader::redirectionTimerFired):
 519         (WebCore::FrameLoader::encoding):
 520         (WebCore::FrameLoader::requestObject):
 521         (WebCore::FrameLoader::shouldUsePlugin):
 522         (WebCore::FrameLoader::loadPlugin):
 523         (WebCore::FrameLoader::clearRecordedFormValues):
 524         (WebCore::FrameLoader::recordFormValue):
 525         (WebCore::FrameLoader::parentCompleted):
 526         (WebCore::FrameLoader::outgoingReferrer):
 527         (WebCore::FrameLoader::lastModified):
 528         (WebCore::FrameLoader::opener):
 529         (WebCore::FrameLoader::setOpener):
 530         (WebCore::FrameLoader::openedByJavaScript):
 531         (WebCore::FrameLoader::setOpenedByJavaScript):
 532         (WebCore::FrameLoader::handleFallbackContent):
 533         (WebCore::FrameLoader::provisionalLoadStarted):
 534         (WebCore::FrameLoader::userGestureHint):
 535         (WebCore::FrameLoader::didNotOpenURL):
 536         (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
 537         (WebCore::FrameLoader::setEncoding):
 538         (WebCore::FrameLoader::addData):
 539         (WebCore::FrameLoader::canCachePage):
 540         (WebCore::FrameLoader::updatePolicyBaseURL):
 541         (WebCore::FrameLoader::setPolicyBaseURL):
 542         (WebCore::FrameLoader::scrollToAnchor):
 543         (WebCore::FrameLoader::isComplete):
 544         (WebCore::FrameLoader::isLoadingMainResource):
 545         (WebCore::FrameLoader::url):
 546         (WebCore::FrameLoader::startRedirectionTimer):
 547         (WebCore::FrameLoader::stopRedirectionTimer):
 548         (WebCore::FrameLoader::updateBaseURLForEmptyDocument):
 549         (WebCore::FrameLoader::completed):
 550         (WebCore::FrameLoader::started):
 551         (WebCore::FrameLoader::containsPlugins):
 552         (WebCore::FrameLoader::prepareForLoadStart):
 553         (WebCore::FrameLoader::setupForReplace):
 554         (WebCore::FrameLoader::setupForReplaceByMIMEType):
 555         (WebCore::FrameLoader::finalSetupForReplace):
 556         (WebCore::FrameLoader::load):
 557         (WebCore::FrameLoader::canTarget):
 558         (WebCore::FrameLoader::stopLoadingPlugIns):
 559         (WebCore::FrameLoader::stopLoadingSubresources):
 560         (WebCore::FrameLoader::stopLoadingSubframes):
 561         (WebCore::FrameLoader::stopAllLoaders):
 562         (WebCore::FrameLoader::cancelMainResourceLoad):
 563         (WebCore::FrameLoader::cancelPendingArchiveLoad):
 564         (WebCore::FrameLoader::activeDocumentLoader):
 565         (WebCore::FrameLoader::addPlugInStreamLoader):
 566         (WebCore::FrameLoader::removePlugInStreamLoader):
 567         (WebCore::FrameLoader::hasMainResourceLoader):
 568         (WebCore::FrameLoader::isLoadingSubresources):
 569         (WebCore::FrameLoader::isLoadingPlugIns):
 570         (WebCore::FrameLoader::isLoading):
 571         (WebCore::FrameLoader::addSubresourceLoader):
 572         (WebCore::FrameLoader::removeSubresourceLoader):
 573         (WebCore::FrameLoader::releaseMainResourceLoader):
 574         (WebCore::FrameLoader::setDocumentLoader):
 575         (WebCore::FrameLoader::documentLoader):
 576         (WebCore::FrameLoader::setPolicyDocumentLoader):
 577         (WebCore::FrameLoader::provisionalDocumentLoader):
 578         (WebCore::FrameLoader::setProvisionalDocumentLoader):
 579         (WebCore::FrameLoader::state):
 580         (WebCore::FrameLoader::timeOfLastCompletedLoad):
 581         (WebCore::FrameLoader::setState):
 582         (WebCore::FrameLoader::clearProvisionalLoad):
 583         (WebCore::FrameLoader::markLoadComplete):
 584         (WebCore::FrameLoader::commitProvisionalLoad):
 585         (WebCore::FrameLoader::privateBrowsingEnabled):
 586         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
 587         (WebCore::FrameLoader::clientRedirected):
 588         (WebCore::FrameLoader::shouldReload):
 589         (WebCore::FrameLoader::closeOldDataSources):
 590         (WebCore::FrameLoader::open):
 591         (WebCore::FrameLoader::isStopping):
 592         (WebCore::FrameLoader::finishedLoading):
 593         (WebCore::FrameLoader::URL):
 594         (WebCore::FrameLoader::isArchiveLoadPending):
 595         (WebCore::FrameLoader::isHostedByObjectElement):
 596         (WebCore::FrameLoader::isLoadingMainFrame):
 597         (WebCore::FrameLoader::canShowMIMEType):
 598         (WebCore::FrameLoader::representationExistsForURLScheme):
 599         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
 600         (WebCore::FrameLoader::cancelContentPolicyCheck):
 601         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
 602         (WebCore::FrameLoader::finishedLoadingDocument):
 603         (WebCore::FrameLoader::isReplacing):
 604         (WebCore::FrameLoader::setReplacing):
 605         (WebCore::FrameLoader::revertToProvisional):
 606         (WebCore::FrameLoader::subframeIsLoading):
 607         (WebCore::FrameLoader::willChangeTitle):
 608         (WebCore::FrameLoader::loadType):
 609         (WebCore::FrameLoader::stopPolicyCheck):
 610         (WebCore::FrameLoader::continueAfterContentPolicy):
 611         (WebCore::FrameLoader::continueAfterWillSubmitForm):
 612         (WebCore::FrameLoader::didFirstLayout):
 613         (WebCore::FrameLoader::frameLoadCompleted):
 614         (WebCore::FrameLoader::firstLayoutDone):
 615         (WebCore::FrameLoader::isQuickRedirectComing):
 616         (WebCore::FrameLoader::closeDocument):
 617         (WebCore::FrameLoader::detachChildren):
 618         (WebCore::FrameLoader::checkLoadComplete):
 619         (WebCore::FrameLoader::numPendingOrLoadingRequests):
 620         (WebCore::FrameLoader::setClient):
 621         (WebCore::FrameLoader::client):
 622         (WebCore::FrameLoader::userAgent):
 623         (WebCore::FrameLoader::createEmptyDocument):
 624         (WebCore::FrameLoader::tokenizerProcessedData):
 625         (WebCore::FrameLoader::didTellBridgeAboutLoad):
 626         (WebCore::FrameLoader::haveToldBridgeAboutLoad):
 627         (WebCore::FrameLoader::handledOnloadEvents):
 628         (WebCore::FrameLoader::frameDetached):
 629         (WebCore::FrameLoader::setTitle):
 630         (WebCore::FrameLoaderClient::~FrameLoaderClient):
 631         * loader/FrameLoader.h:
 632         (WebCore::):
 633         * loader/FrameLoaderClient.h:
 634         * loader/PluginDocument.cpp:
 635         (WebCore::PluginTokenizer::createDocumentStructure):
 636         (WebCore::PluginTokenizer::writeRawData):
 637         * loader/ResourceLoader.h:
 638         * loader/TextResourceDecoder.cpp:
 639         (WebCore::TextResourceDecoder::checkForHeadCharset):
 640         * loader/icon/IconLoader.cpp:
 641         (WebCore::IconLoader::startLoading):
 642         (WebCore::IconLoader::finishLoading):
 643         * loader/loader.cpp:
 644         (WebCore::Loader::didReceiveResponse):
 645         * loader/mac/DocumentLoaderMac.mm:
 646         (WebCore::DocumentLoader::~DocumentLoader):
 647         (WebCore::DocumentLoader::stopLoading):
 648         (WebCore::DocumentLoader::finishedLoading):
 649         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
 650         (WebCore::DocumentLoader::setPrimaryLoadComplete):
 651         * loader/mac/FrameLoaderMac.mm:
 652         (WebCore::FrameLoader::load):
 653         (WebCore::FrameLoader::startLoading):
 654         (WebCore::FrameLoader::cancelMainResourceLoad):
 655         (WebCore::FrameLoader::receivedMainResourceError):
 656         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
 657         (WebCore::FrameLoader::commitProvisionalLoad):
 658         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
 659         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
 660         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
 661         (WebCore::FrameLoader::detachFromParent):
 662         (WebCore::FrameLoader::addExtraFieldsToRequest):
 663         (WebCore::FrameLoader::loadResourceSynchronously):
 664         (WebCore::FrameLoader::createFrame):
 665         (WebCore::FrameLoader::objectContentType):
 666         (WebCore::nsArray):
 667         (WebCore::FrameLoader::createPlugin):
 668         (WebCore::FrameLoader::redirectDataToPlugin):
 669         (WebCore::FrameLoader::createJavaAppletWidget):
 670         (WebCore::FrameLoader::partClearedInBegin):
 671         (WebCore::FrameLoader::saveDocumentState):
 672         (WebCore::FrameLoader::restoreDocumentState):
 673         (WebCore::FrameLoader::overrideMediaType):
 674         (WebCore::FrameLoader::mainResourceData):
 675         (WebCore::FrameLoader::canGoBackOrForward):
 676         (WebCore::FrameLoader::originalRequestURL):
 677         (WebCore::FrameLoader::getHistoryLength):
 678         (WebCore::FrameLoader::goBackOrForward):
 679         (WebCore::FrameLoader::historyURL):
 680         (WebCore::FrameLoader::didFinishLoad):
 681         * loader/mac/LoaderFunctionsMac.mm:
 682         (WebCore::ServeSynchronousRequest):
 683         (WebCore::CheckCacheObjectStatus):
 684         * loader/mac/ResourceLoaderMac.mm:
 685         (WebCore::ResourceLoader::cancel):
 686         * loader/mac/SubresourceLoaderMac.mm:
 687         (WebCore::SubresourceLoader::create):
 688         * loader/qt/FrameLoaderQt.cpp: Added.
 689         (WebCore::FrameLoader::submitForm):
 690         (WebCore::FrameLoader::urlSelected):
 691         (WebCore::FrameLoader::setTitle):
 692         (WebCore::FrameLoader::createFrame):
 693         (WebCore::FrameLoader::objectContentType):
 694         (WebCore::FrameLoader::createPlugin):
 695         (WebCore::FrameLoader::createJavaAppletWidget):
 696         (WebCore::FrameLoader::originalRequestURL):
 697         * page/DOMWindow.cpp:
 698         (WebCore::DOMWindow::document):
 699         * page/Frame.cpp:
 700         (WebCore::Frame::~Frame):
 701         (WebCore::Frame::reparseConfiguration):
 702         (WebCore::Frame::shouldDragAutoNode):
 703         (WebCore::Frame::prepareForUserAction):
 704         (WebCore::FramePrivate::FramePrivate):
 705         (WebCore::FramePrivate::~FramePrivate):
 706         * page/Frame.h:
 707         * page/FramePrivate.h:
 708         * page/FrameView.cpp:
 709         (WebCore::FrameView::layout):
 710         (WebCore::FrameView::mediaType):
 711         * page/FrameView.h:
 712         * page/PageState.cpp:
 713         (WebCore::PageState::PageState):
 714         (WebCore::PageState::restoreJavaScriptState):
 715         * platform/mac/CookieJar.mm:
 716         (WebCore::setCookies):
 717         * platform/mac/TextCodecMac.cpp:
 718         * platform/mac/WebFontCache.mm:
 719         (+[WebFontCache fontWithFamily:traits:size:]):
 720         * platform/network/cf/ResourceHandleCFNet.cpp:
 721         (WebCore::ResourceHandle::start):
 722         * platform/network/mac/ResourceHandleMac.mm:
 723         (WebCore::ResourceHandle::start):
 724         * platform/qt/FrameQt.cpp:
 725         * platform/qt/FrameQt.h:
 726         * rendering/RenderApplet.cpp:
 727         (WebCore::RenderApplet::createWidgetIfNecessary):
 728         * rendering/RenderBlock.h:
 729         * rendering/RenderPartObject.cpp:
 730         (WebCore::isURLAllowed):
 731         (WebCore::RenderPartObject::updateWidget):
 732         * xml/DOMParser.cpp:
 733         (WebCore::DOMParser::parseFromString):
 734         * xml/XSLTProcessor.cpp:
 735         (WebCore::XSLTProcessor::createDocumentFromSource):
 736         * xml/xmlhttprequest.cpp:
 737         (WebCore::XMLHttpRequest::getResponseXML):
 738
 739 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
 740
 741         Reviewed by Geoff.
 742
 743         Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.
 744
 745         * bridge/mac/FrameMac.mm:
 746         (WebCore::FrameMac::registerCommandForUndoOrRedo):
 747         * bridge/mac/WebCoreFrameBridge.h:
 748         * bridge/mac/WebCoreFrameBridge.mm:
 749         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
 750         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
 751         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]):
 752         (-[WebCoreFrameBridge selectionGranularity]):
 753         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
 754         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
 755         (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
 756         (-[WebCoreFrameBridge applyStyle:withUndoAction:]):
 757         (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
 758         * editing/SelectionController.cpp:
 759         (WebCore::SelectionController::setModifyBias):
 760         (WebCore::SelectionController::modify):
 761         * editing/SelectionController.h:
 762         (WebCore::SelectionController::):
 763         * editing/TextGranularity.h:
 764
 765 2006-11-07  Brady Eidson  <beidson@apple.com>
 766
 767         Reviewed by Maciej
 768
 769         Changed the check for "top level frame" to something much more valid
 770
 771         * page/Frame.cpp:
 772         (WebCore::Frame::endIfNotLoading):
 773
 774 2006-11-07  Beth Dakin  <bdakin@apple.com>
 775
 776         Reviewed by Hyatt (yesterday).
 777
 778         Here is part of my patch from yesterday that is safe to roll back
 779         in. It will make the BuildBot happy.
 780
 781         * rendering/HitTestResult.cpp:
 782         (WebCore::HitTestResult::spellingToolTip): Null-check
 783         m_innerNonSharedNode.
 784
 785 2006-11-07  Darin Adler  <darin@apple.com>
 786
 787         * loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse):
 788         Comment grammar fix.
 789
 790 2006-11-07  Darin Adler  <darin@apple.com>
 791
 792         Rolled out change for <rdar://problem/4820814>.
 793
 794         Beth's planning on landing a new change for it soon, but in the mean time
 795         we need layout tests succeeding again.
 796
 797 2006-11-07  Darin Adler  <darin@apple.com>
 798
 799         Reviewed by Brady.
 800
 801         - fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher
 802           crashes on launch in WebCore::ResourceLoader::start
 803
 804         No layout test, because this depends on cached icons, although there's
 805         perhaps a way to write a test for it with some further ingenuity.
 806
 807         * loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable
 808         to make explicit the fact that it can't be successfully copied.
 809         Remove notifyIconChanged function and put the contents in the caller.
 810         This eliminates the need for IconLoaderMac.mm. Added finishedLoading
 811         and clearLoadingState functions to share code. Removed m_url, since the
 812         resource handle already stores the URL. Renamed m_resourceLoader to
 813         m_handle to reflect the class's name change. Removed the 4096-byte
 814         inline buffer from m_data, since the malloc savings is not sufficient
 815         to offset the additional memory use. Removed m_httpStatusCode because
 816         we can instead cancel the load when we get a status code that reflects
 817         failure. Added m_loadIsInProgress boolean because we need to detect
 818         loads that complete during the ResourceHandle::create function call.
 819
 820         * loader/icon/IconLoader.cpp:
 821         (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress.
 822         Don't initialize m_httpStatusCode.
 823         (WebCore::IconLoader::~IconLoader): Updated for name change.
 824         (WebCore::IconLoader::startLoading): Added code to use the
 825         m_loadIsInProgress flag to detect if the load completed while inside
 826         the ResourceHandle::create function. Removed code to set m_url.
 827         (WebCore::IconLoader::stopLoading): Call clearLoadingState to share
 828         more code.
 829         (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle
 830         and finish loading if the HTTP status code indicates failure.
 831         (WebCore::IconLoader::didReceiveData): Removed assertion that checks
 832         the ResourceHandle, since we can't do that any more.
 833         (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading
 834         so we can share code with the new didReceiveResponse code path.
 835         (WebCore::IconLoader::finishLoading): Moved code here from the
 836         didFinishLoading callback. Pass a URL when calling
 837         commitIconURLToIconDatabase. Call notifyIconChanged directly here
 838         instead of using a separate function. Call clearLoadingState to
 839         share more code with stopLoading.
 840         (WebCore::IconLoader::clearLoadingState): Added.
 841
 842         * loader/mac/IconLoaderMac.mm: Removed.
 843         * WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
 844
 845 2006-11-06  David Harrison  <harrison@apple.com>
 846
 847         Reviewed by Darin.
 848
 849         <rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
 850
 851         * editing/pasteboard/3976872-expected.txt:
 852         * editing/pasteboard/4076267-2-expected.txt:
 853         * editing/pasteboard/4076267-3-expected.txt:
 854         * editing/pasteboard/4076267-expected.txt:
 855         * editing/pasteboard/8145-1-expected.txt:
 856         * editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
 857         * editing/pasteboard/paste-match-style-001-expected.txt:
 858         * editing/pasteboard/paste-match-style-002-expected.txt:
 859         * editing/pasteboard/paste-text-019-expected.txt:
 860         * editing/pasteboard/pasting-tabs-expected.txt:
 861         Updated because pasting text with no newlines does not use intermediate div.
 862
 863         * editing/markup.cpp:
 864         (WebCore::fillContainerFromString):
 865         First parameter is now a Container so a fragment can be passed.
 866
 867         (WebCore::createFragmentFromText):
 868         A string with no newlines gets added inline, rather than being put into a paragraph.
 869
 870 2006-11-06  Beth Dakin  <bdakin@apple.com>
 871
 872         Reviewed by Hyatt.
 873
 874         Fix for <rdar://problem/4820814> A crash occurs at
 875         WebCore::HitTestResult::spellingToolTip() when mousing down on
 876         iframe at www.macsurfer.com
 877
 878         The bug here is that the source of the iframe is only a comment,
 879         and we were not properly constructing the frame because it was
 880         sort-of empty but not.
 881
 882         * html/HTMLDocument.cpp:
 883         (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if
 884         it is a comment node.
 885         * html/HTMLParser.cpp:
 886         (WebCore::HTMLParser::handleError): if n is a comment node and
 887         there is no head, we create a head, insert in the document, and add
 888         the comment node as a child. This is what Firefox does too.
 889         * page/FrameView.cpp:
 890         (WebCore::FrameView::handleMousePressEvent): Safe-guard for the
 891         fix. It is possible to get a mouse event without a target node, so
 892         we null check it. (Of course, in the case of this bug, it should
 893         not have been null, but it is a good thing to check for anyway.
 894         * rendering/HitTestResult.cpp:
 895         (WebCore::HitTestResult::spellingToolTip): Null-check
 896         m_innerNonSharedNode.
 897
 898 2006-11-06  Justin Garcia  <justin.garcia@apple.com>
 899
 900         Reviewed by harrison
 901
 902         <rdar://problem/4641880>
 903         Setting bullets to existing text grabs subsequent paragraph
 904
 905         When a selection ends at the start of a paragraph, we rarely paint
 906         the selection gap before that paragraph, because there often is no gap.
 907         In a case like this, it's not obvious to the user that the selection
 908         ends "inside" that paragraph, so it would be confusing if
 909         InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.
 910
 911         * editing/FormatBlockCommand.cpp:
 912         (WebCore::FormatBlockCommand::doApply): Moved the check for editability of
 913         the selection to a more appropriate place.  Change the endingSelection
 914         if it ends at the start of a paragraph.
 915         * editing/IndentOutdentCommand.cpp:
 916         (WebCore::IndentOutdentCommand::doApply): Ditto.
 917         * editing/InsertListCommand.cpp:
 918         (WebCore::InsertListCommand::doApply): Ditto.
 919
 920 2006-11-06  Brady Eidson  <beidson@apple.com>
 921
 922         Reviewed by Sarge
 923
 924         <rdar://problem/4822911> - ASSERTION was a little overzealous.
 925         Toned it down a bit.
 926
 927         * xml/xmlhttprequest.cpp:
 928         (WebCore::XMLHttpRequest::didFinishLoading):  Toned down assertion
 929
 930 2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
 931
 932         Reviewed by Maciej.
 933
 934         Linux\Gdk build fixes.
 935
 936         * loader/icon/IconDatabase.cpp:
 937         * loader/icon/SQLStatement.h:
 938         * platform/gdk/ChromeClientGdk.h: Added.
 939         (WebCore::ChromeClientGdk::~ChromeClientGdk):
 940         * platform/gdk/CursorGdk.cpp:
 941         (WebCore::pointerCursor):
 942         * platform/gdk/FrameGdk.cpp:
 943         (WebCore::doScroll):
 944         (WebCore::FrameGdk::FrameGdk):
 945         (WebCore::FrameGdk::submitForm):
 946         (WebCore::FrameGdk::urlSelected):
 947         (WebCore::FrameGdk::openURL):
 948         (WebCore::FrameGdk::handleGdkEvent):
 949         * platform/gdk/FrameGdk.h:
 950         (WebCore::FrameGdk::client):
 951         * platform/gdk/RenderPopupMenuGdk.cpp:
 952         (WebCore::PopupMenu::updateFromElement):
 953         * platform/gdk/ScreenGdk.cpp:
 954         * platform/gdk/TemporaryLinkStubs.cpp:
 955         (Slider::focusPolicy):
 956         (WebCore::ServeSynchronousRequest):
 957         (FrameGdk::goBackOrForward):
 958         (FrameGdk::getHistoryLength):
 959         (FrameGdk::historyURL):
 960         (ChromeClientGdk::canRunModal):
 961         (ChromeClientGdk::runModal):
 962         (WebCore::systemBeep):
 963         (WebCore::CachedResource::setPlatformResponse):
 964         (Path::transform):
 965         (ResourceLoader::loadsBlocked):
 966         (IconLoader::notifyIconChanged):
 967         * platform/network/gdk/ResourceHandleManager.cpp:
 968         (WebCore::writeCallback):
 969         (WebCore::ResourceHandleManager::downloadTimerCallback):
 970         (WebCore::ResourceHandleManager::remove):
 971         (WebCore::ResourceHandleManager::add):
 972
 973 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
 974
 975         build fix.
 976
 977         * WebCore.xcodeproj/project.pbxproj:
 978
 979 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
 980
 981         Reviewed by Maciej, Anders, Darin.
 982
 983         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
 984         Fixed a minor where WebCore would always assume it was displayed on the
 985         monitor containing the menubar. window.open and window.showModalDialog
 986         are now cross-platform.
 987
 988         Layout tests, manual-tests/show-modal-dialog, and manual-tests/
 989         window-open-features-parsing all pass. I verified the new screen functionality
 990         by running in DRT, and checking whether WebCore knew it was off-screen.
 991
 992         Some refactoring remains, as all were not pleased by this design. I see
 993         in my future another patch.
 994
 995         * bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
 996         client, to encapsulate asking the platform questions about the screen occupied by
 997         the page. (Previously, we always assumed we were on screen 0, which was a bug.)
 998         * bridge/mac/WebCoreFrameBridge.mm:
 999         (createMouseEventFromDraggingInfo): Reversed argument order, to match other
1000         functions.
1001         (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
1002         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
1003         * bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
1004         * bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
1005         * bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
1006         * bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
1007         * manual-tests/window-open-features-parsing.html: Updated for accuracy.
1008         (In this case, neither size nor position is specified, so you should
1009         get the default window size and position.)
1010         * page/Screen.cpp: Added. Includes screen-related helper functions used
1011         in WebCore and WebKit.
1012         * platform/PlatformMouseEvent.h: Exported common code so it doesn't have
1013         to be duplicated. Renamed "position" to "point" since both were used,
1014         and "point" seemed clearer.
1015         * platform/Screen.h: Removed. Dead Code.
1016         * platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
1017         initialization.
1018
1019 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
1020
1021         Reviewed by Tim Hatcher.
1022
1023         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
1024         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
1025
1026         No layout tests added as this must be tested manually by the test
1027         WebCore/manual-tests/contenteditable-link.html
1028
1029         * WebCore.exp: Exported HitTestResult::isLiveLink().
1030         * html/HTMLAnchorElement.cpp:
1031         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
1032         (WebCore::HTMLAnchorElement::defaultEventHandler):
1033         (WebCore::HTMLAnchorElement::isLiveLink):
1034         * html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
1035         to track shift key status.
1036         * manual-tests/contenteditable-link.html: Added description about link
1037         dragging behaviour.
1038         * rendering/HitTestResult.cpp:
1039         (WebCore::HitTestResult::isLiveLink): Added.
1040         * rendering/HitTestResult.h:
1041
1042 2006-11-06  Brady Eidson  <beidson@apple.com>
1043
1044         Reviewed by Oliver
1045
1046         Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
1047         For now, we have to not load favicons when we have no Document - linking directly
1048         to PDFs being the common case
1049
1050         * loader/icon/IconLoader.cpp:
1051         (WebCore::IconLoader::startLoading): Check for the document and return if none
1052
1053 2006-11-06  Brady Eidson  <beidson@apple.com>
1054
1055         Reviewed by Dave Harrison
1056
1057         <rdar://problem/4801066>
1058         Added a critical null frameLoader() check
1059
1060         * loader/mac/MainResourceLoaderMac.mm:
1061         (WebCore::MainResourceLoader::loadNow):
1062
1063 2006-11-06  David Harrison  <harrison@apple.com>
1064
1065         Reviewed by Darin.
1066
1067         <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
1068
1069         Test:
1070         * editing/deleting/delete-br-012.html
1071
1072         * editing/DeleteSelectionCommand.cpp:
1073         (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
1074         Update m_endingPosition when preventing merge.
1075         Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
1076
1077 2006-11-06  Mark Rowe  <bdash@webkit.org>
1078
1079         Reviewed by Maciej.
1080
1081         http://bugs.webkit.org/show_bug.cgi?id=11526
1082         Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
1083
1084         Update DOMNode::toString to always use className rather than preferring nodeName.
1085
1086         * bindings/js/kjs_dom.cpp:
1087         (KJS::DOMNode::toString): Match the format returned by valueOf.
1088
1089 2006-11-06  Oliver Hunt  <oliver@apple.com>
1090
1091         Reviewed by Maciej.
1092
1093         Fix RTL text in SVG to have correct positioning
1094
1095         * rendering/SVGRootInlineBox.cpp:
1096         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
1097
1098 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
1099
1100         Reviewed by Maciej.
1101
1102         http://bugs.webkit.org/show_bug.cgi?id=11517
1103         REGRESSION: Flash clicks/interactivity not working properly
1104
1105         * bridge/mac/FrameMac.mm:
1106         (WebCore::FrameMac::handleMouseMoveEvent):
1107         (WebCore::FrameMac::handleMouseReleaseEvent):
1108         Restore parts of event dispatching that were removed when fixing
1109         bug 7323 - just bypass those for subframes.
1110
1111 2006-11-05  Darin Adler  <darin@apple.com>
1112
1113         - quick attempt to fix the no-SVG build
1114
1115         * platform/graphics/svg/SVGResource.cpp:
1116         * platform/graphics/svg/SVGResource.h:
1117         * platform/graphics/svg/SVGResourceClipper.cpp:
1118         * platform/graphics/svg/SVGResourceClipper.h:
1119         * platform/graphics/svg/SVGResourceImage.h:
1120         * platform/graphics/svg/SVGResourceMarker.cpp:
1121         * platform/graphics/svg/SVGResourceMarker.h:
1122         * platform/graphics/svg/SVGResourceMasker.cpp:
1123         * platform/graphics/svg/SVGResourceMasker.h:
1124         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
1125         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
1126         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
1127         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
1128         Added #ifdef SVG_SUPPORT to these files.
1129
1130 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
1131
1132         Reviewed & landed by Maciej.
1133
1134         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
1135
1136         * platform/win/ResourceLoaderWin.cpp:
1137         (WebCore::transferJobStatusCallback):
1138         (WebCore::ResourceLoader::start):
1139
1140 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
1141
1142         Reviewed by Oliver.
1143
1144         - moved FormData and FormDataStream to platform/network directory
1145
1146         * WebCore.xcodeproj/project.pbxproj:
1147         * bridge/mac/WebCoreFrameBridge.mm:
1148         * loader/FormData.cpp: Removed.
1149         * loader/FormData.h: Removed.
1150         * loader/mac/FormDataStream.h: Removed.
1151         * loader/mac/FormDataStream.m: Removed.
1152         * loader/mac/FrameLoaderMac.mm:
1153         * loader/mac/SubresourceLoaderMac.mm:
1154         * platform/network/mac/FormDataStreamMac.h: Added.
1155         * platform/network/mac/FormDataStreamMac.mm: Added.
1156         * platform/network/mac/ResourceRequestMac.mm:
1157
1158 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
1159
1160         Fix build breaks
1161
1162         * loader/DocumentLoader.h:
1163         * platform/win/ScreenWin.cpp:
1164
1165 2006-11-05  Darin Adler  <darin@apple.com>
1166
1167         Reviewed by Geoff.
1168
1169         - more preparation for splitting up Frame into sub-pieces
1170         - removed unnecessary includes from Frame.h
1171
1172         * page/Frame.h: Removed unneeded includes and forward declarations.
1173         Added additional forward declarations. Removed the constant
1174         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
1175         Created sections of functions to be moved into Chrome, Editor,
1176         EventHandler, FrameLoader, SelectionController, and the Platform
1177         directory, as well as marking one function for deletion.
1178
1179         * page/FramePrivate.h: Removed the definition of the constructor and
1180         destructor and removed unnecessary includes.
1181
1182         * page/FrameView.h: Removed unneeded forward declarations and friend
1183         declarations. Created a section of functions and data to be moved into
1184         EventHandler.
1185
1186         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
1187         Created sections of functions and data to be moved into Chrome,
1188         Editor, EventHandler, FrameLoader, and the Platform directory.
1189
1190         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
1191         Removed unused methods areScrollbarsVisible,
1192         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
1193
1194         * page/Frame.cpp:
1195         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
1196         to include KURL.h just for the KURL default constructor.
1197         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
1198         (WebCore::FramePrivate::~FramePrivate): Ditto.
1199
1200         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
1201         booleans, scrollbarMoved and cleared funcitons.
1202         (WebCore::FrameView::clear): Moved the code from the cleared
1203         function in here.
1204         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
1205
1206         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
1207         for changes to header.
1208
1209         * editing/SelectionController.cpp:
1210         (WebCore::SelectionController::setSelection):
1211         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
1212         Moved NoXPosForVerticalArrowNavigation into this file.
1213
1214         * bindings/js/kjs_events.cpp:
1215         * bindings/js/kjs_html.cpp:
1216         * bindings/js/kjs_window.cpp:
1217         * bridge/mac/WebCoreAXObject.mm:
1218         * bridge/mac/WebCoreFrameBridge.mm:
1219         * css/cssstyleselector.cpp:
1220         * dom/Document.cpp:
1221         * dom/Element.cpp:
1222         * dom/EventTargetNode.cpp:
1223         * dom/MouseRelatedEvent.cpp:
1224         * dom/XMLTokenizer.cpp:
1225         * html/HTMLBaseElement.cpp:
1226         * html/HTMLDocument.cpp:
1227         * html/HTMLEmbedElement.cpp:
1228         * html/HTMLFrameElementBase.cpp:
1229         * html/HTMLGenericFormElement.cpp:
1230         * html/HTMLObjectElement.cpp:
1231         * html/HTMLTokenizer.cpp:
1232         * loader/mac/FrameLoaderMac.mm:
1233         * page/PageState.cpp:
1234         * rendering/RenderApplet.cpp:
1235         * rendering/RenderBlock.cpp:
1236         * rendering/RenderLayer.cpp:
1237         * rendering/RenderObject.cpp:
1238         * rendering/RenderPartObject.cpp:
1239         * rendering/RenderTreeAsText.cpp:
1240         * xml/XSLTProcessor.cpp:
1241         Added includes as needed to keep compiling, since there are fewer
1242         includes in Frame.h.
1243
1244 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
1245
1246         Reviewed by Dave Harrison.
1247
1248         http://bugs.webkit.org/show_bug.cgi?id=11402
1249         REGRESSION: onChange does not work anymore for 1st item in popup
1250
1251         * html/HTMLSelectElement.cpp:
1252         (WebCore::HTMLSelectElement::HTMLSelectElement):
1253         (WebCore::HTMLSelectElement::reset):
1254         Set m_lastOnChangeIndex to -1.
1255
1256 2006-11-04  Darin Adler  <darin@apple.com>
1257
1258         Reviewed by Anders.
1259
1260         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
1261           REGRESSION: Status bar always shows cancelled opening the page
1262
1263         * platform/network/mac/ResourceHandleMac.mm:
1264         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
1265         Since the subresource owns the resource handle, there's no need to cancel.
1266         This arrangement is only temporary, anyway, since Maciej will soon change
1267         things so that the subresource loader uses the resource handle and the
1268         resource handle doesn't know anything about the subresource loader.
1269
1270 2006-11-04  Darin Adler  <darin@apple.com>
1271
1272         Reviewed by Maciej.
1273
1274         - converted more of the loader machinery to work with cross-platform
1275           data structures instead of Macintosh-specific ones
1276
1277           converted most uses of NSURL to KURL and NSEvent to DOM Event in
1278           loader classes
1279
1280           moved download function out of FrameLoader.h to avoid reference to
1281           NSURLConnection
1282
1283           added DOM Event parameters to various functions so that the handlers
1284           can use the DOM Event instead of the global "current NSEvent";
1285           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
1286           HTMLFormElement::submit, FrameLoader::load
1287
1288           moved the setMainFrame call that hands ownership to the Page
1289           into one of the Frame constructors, and removed it from all
1290           the clients
1291
1292           removed const from Event parameter to the urlSelected function
1293           (we rarely use const with DOM elements)
1294
1295           removed some redundant includes and declarations from various
1296           header files
1297
1298           removed NSURL parameter from userAgent function -- if we need it we
1299           can add it back, but converting from NSURL to KURL and back is
1300           inefficient enough that it's best to have it out for now (since it's
1301           been unused for years) -- if we add it back, we can choose an
1302           appropriate parameter type that's always inexpensive to pass
1303
1304           did some basic cleanup in the IconLoader class, including removing
1305           an unnecessary loop that added icon data a byte at a time
1306
1307           renamed safeLoad to load, since it's no different from the other
1308           FrameLoader load functions, safety-wise
1309
1310           fixed some code that was trying to distinguish null frame name from
1311           empty string frame name -- both should be handled the same, but callers
1312           were doing it by checking for empty and turning it into null (in a way
1313           that was causing extra round trips between NSString and WebCore::String)
1314
1315           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
1316           and got rid of case-insensitive compares of methods
1317
1318         * WebCore.exp:
1319         * WebCore.xcodeproj/project.pbxproj:
1320         * bindings/js/kjs_navigator.cpp:
1321         (KJS::Navigator::getValueProperty):
1322         * bridge/mac/FrameMac.h:
1323         * bridge/mac/FrameMac.mm:
1324         (WebCore::FrameMac::submitForm):
1325         (WebCore::FrameMac::urlSelected):
1326         (WebCore::FrameMac::userAgent):
1327         * bridge/mac/FrameViewMac.mm:
1328         * bridge/mac/WebCoreAXObject.mm:
1329         (-[WebCoreAXObject rendererForView:]):
1330         * bridge/mac/WebCorePageBridge.h:
1331         * bridge/mac/WebCorePageBridge.mm:
1332         * bridge/mac/WebCoreSettings.mm:
1333         * bridge/win/FrameWin.cpp:
1334         (WebCore::FrameWin::urlSelected):
1335         (WebCore::FrameWin::submitForm):
1336         * bridge/win/FrameWin.h:
1337         * dom/MouseRelatedEvent.cpp:
1338         * dom/MouseRelatedEvent.h:
1339         * dom/UIEvent.cpp:
1340         (WebCore::UIEvent::~UIEvent):
1341         * dom/UIEvent.h:
1342         * dom/UIEventWithKeyState.h:
1343         * dom/XMLTokenizer.cpp:
1344         (WebCore::openFunc):
1345         * html/HTMLAnchorElement.cpp:
1346         (WebCore::HTMLAnchorElement::defaultEventHandler):
1347         * html/HTMLButtonElement.cpp:
1348         (WebCore::HTMLButtonElement::defaultEventHandler):
1349         * html/HTMLFormElement.cpp:
1350         (WebCore::HTMLFormElement::submitClick):
1351         (WebCore::HTMLFormElement::prepareSubmit):
1352         (WebCore::HTMLFormElement::submit):
1353         * html/HTMLFormElement.h:
1354         * html/HTMLInputElement.cpp:
1355         (WebCore::HTMLInputElement::defaultEventHandler):
1356         * html/HTMLSelectElement.cpp:
1357         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
1358         * loader/DocumentLoader.h:
1359         * loader/FrameLoader.h:
1360         * loader/FrameLoaderClient.h:
1361         * loader/NavigationAction.h:
1362         (WebCore::NavigationAction::event):
1363         * loader/icon/IconLoader.cpp:
1364         (WebCore::IconLoader::create):
1365         (WebCore::IconLoader::startLoading):
1366         (WebCore::IconLoader::didReceiveData):
1367         (WebCore::IconLoader::didFinishLoading):
1368         * loader/icon/IconLoader.h:
1369         * loader/loader.cpp:
1370         * loader/mac/DocumentLoaderMac.mm:
1371         (WebCore::DocumentLoader::URL):
1372         (WebCore::DocumentLoader::unreachableURL):
1373         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
1374         (WebCore::DocumentLoader::URLForHistory):
1375         * loader/mac/FrameLoaderMac.mm:
1376         (WebCore::FrameLoader::load):
1377         (WebCore::FrameLoader::willSendRequest):
1378         (WebCore::FrameLoader::clientRedirected):
1379         (WebCore::FrameLoader::shouldReload):
1380         (WebCore::FrameLoader::notifyIconChanged):
1381         (WebCore::FrameLoader::URL):
1382         (WebCore::FrameLoader::reloadAllowingStaleData):
1383         (WebCore::FrameLoader::reload):
1384         (WebCore::FrameLoader::didChangeTitle):
1385         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
1386         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1387         (WebCore::FrameLoader::post):
1388         (WebCore::FrameLoader::addExtraFieldsToRequest):
1389         (WebCore::FrameLoader::loadResourceSynchronously):
1390         * loader/mac/IconLoaderMac.mm:
1391         (WebCore::IconLoader::notifyIconChanged):
1392         * loader/mac/LoaderFunctionsMac.mm:
1393         * loader/mac/MainResourceLoaderMac.mm:
1394         (WebCore::shouldLoadAsEmptyDocument):
1395         (WebCore::MainResourceLoader::continueAfterContentPolicy):
1396         * loader/mac/NavigationActionMac.mm:
1397         (WebCore::navigationType):
1398         (WebCore::NavigationAction::NavigationAction):
1399         * loader/mac/ResourceLoaderMac.mm:
1400         * loader/mac/SubresourceLoaderMac.mm:
1401         * page/Frame.cpp:
1402         (WebCore::Frame::Frame):
1403         (WebCore::Frame::urlSelected):
1404         (WebCore::Frame::submitFormAgain):
1405         (WebCore::Frame::submitForm):
1406         (WebCore::Frame::endIfNotLoading):
1407         (WebCore::Frame::hitTestResultAtPoint):
1408         * page/Frame.h:
1409         * page/FramePrivate.h:
1410         * platform/gdk/FrameGdk.cpp:
1411         (WebCore::FrameGdk::FrameGdk):
1412         (WebCore::FrameGdk::submitForm):
1413         (WebCore::FrameGdk::urlSelected):
1414         * platform/gdk/FrameGdk.h:
1415         * platform/mac/TextFieldMac.mm:
1416         * platform/network/HTTPHeaderMap.h:
1417         * platform/network/ResourceHandle.h:
1418         * platform/network/ResourceHandleClient.h:
1419         * platform/network/ResourceHandleInternal.h:
1420         * platform/network/mac/ResourceHandleMac.mm:
1421         * platform/network/mac/ResourceResponseMac.h:
1422         * platform/network/mac/ResourceResponseMac.mm:
1423         (-[NSURLResponse WebCore]):
1424         * platform/network/win/ResourceHandleWin.cpp:
1425         * platform/qt/FrameQt.cpp:
1426         (WebCore::FrameQt::submitForm):
1427         (WebCore::FrameQt::urlSelected):
1428         * platform/qt/FrameQt.h:
1429         * rendering/RenderLineEdit.cpp:
1430         (WebCore::RenderLineEdit::returnPressed):
1431         * xml/XSLTProcessor.cpp:
1432         (WebCore::docLoaderFunc):
1433         * xml/xmlhttprequest.cpp:
1434
1435 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
1436
1437         Reviewed by Adele.
1438
1439         - replaced receivedRedirect with new willSendRequest delegate
1440         - removed most mac-specific loader functions
1441         - use ResourceResponse more in loader code
1442
1443         * WebCore.xcodeproj/project.pbxproj: Add new files.
1444         * bridge/mac/WebCoreFrameBridge.mm:
1445         (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
1446         for CachedResource method renames.
1447         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
1448         Ditto.
1449         * loader/CachedCSSStyleSheet.cpp:
1450         (WebCore::CachedCSSStyleSheet::checkNotify): simplified
1451         based on ResourceResponse
1452         * loader/CachedImage.cpp:
1453         (WebCore::CachedImage::createImage): adapt for ResourceResponse
1454         * loader/CachedResource.cpp:
1455         (WebCore::CachedResource::CachedResource): store a ResourceResponse;
1456         platform response is now called platformResponse and expiration date
1457         is removed.
1458         (WebCore::CachedResource::~CachedResource): ditto
1459         (WebCore::CachedResource::isExpired): ditto
1460         * loader/CachedResource.h:
1461         (WebCore::CachedResource::platformResponse): ditto
1462         (WebCore::CachedResource::setResponse): ditto
1463         (WebCore::CachedResource::canDelete): ditto
1464         * loader/LoaderFunctions.h:
1465         * loader/loader.cpp:
1466         (WebCore::Loader::receivedResponse): Adjusted for renames.
1467         (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
1468         in the CachedResource.
1469         * loader/loader.h:
1470         * loader/mac/FormDataStream.h:
1471         * loader/mac/FormDataStream.m:
1472         (WebCore::getStreamFormDatas): Rearranged things so it's
1473         possible to get a FormData back out of a form data stream.
1474         (WebCore::formCreate): ditto
1475         (WebCore::formFinalize): ditto
1476         (WebCore::httpBodyFromStream): ditto
1477         * loader/mac/ImageDocumentMac.mm:
1478         (WebCore::finishImageLoad): s/response/platformResponse/
1479         * loader/mac/LoaderFunctionsMac.mm:
1480         (WebCore::CheckCacheObjectStatus): ditto
1481         (WebCore::CachedResource::setPlatformResponse): ditto
1482         * loader/mac/SubresourceLoaderMac.mm:
1483         (WebCore::SubresourceLoader::willSendRequest): send redirect
1484         to client appropriately
1485         * platform/network/ResourceHandle.h:
1486         * platform/network/ResourceHandleClient.h:
1487         (WebCore::ResourceHandleClient::willSendRequest): new entry
1488         point for SubresourceLoader, dispatch to client.
1489         * platform/network/ResourceRequest.h:
1490         (WebCore::ResourceRequest::allowHTTPCookies): implemented
1491         (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
1492         * platform/network/ResourceResponse.h:
1493         (WebCore::ResourceResponse::ResourceResponse): initialize expiration
1494         date(!)
1495         * platform/network/cf/FormDataStreamCFNet.cpp: Added.
1496         (WebCore::getStreamFormDatas): Added this, ported from NSURL version.
1497         (WebCore::openNextStream): ditto
1498         (WebCore::formCreate): ditto
1499         (WebCore::formFinalize): ditto
1500         (WebCore::formCanRead): ditto
1501         (WebCore::formEventCallback): ditto
1502         (WebCore::setHTTPBody): ditto
1503         (WebCore::httpBodyFromStream): ditto
1504         * platform/network/cf/FormDataStreamCFNet.h: Added.
1505         * platform/network/cf/ResourceHandleCFNet.cpp:
1506         (WebCore::willSendRequest): implemented
1507         (WebCore::ResourceHandle::start): use new ResourceRequest stuff
1508         * platform/network/cf/ResourceResponseCFNet.cpp:
1509         (WebCore::getResourceResponse): do nothing for a null response
1510         * platform/network/mac/ResourceHandleMac.mm:
1511         (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
1512         * platform/network/mac/ResourceRequestMac.h: Added.
1513         * platform/network/mac/ResourceRequestMac.mm: Added.
1514         (WebCore::getResourceRequest): Added way to convert an NSURLRequest
1515         to a ResourceRequest.
1516         (WebCore::nsURLRequest): Opposite of the above.
1517         * platform/network/cf/ResourceRequestCFNet.h: Added.
1518         * platform/network/cf/ResourceRequestCFNet.cpp: Added.
1519         (WebCore::getResourceRequest): Added way to convert an CFURLRequest
1520         to a ResourceRequest.
1521         (WebCore::cfURLRequest): Opposite of the above.
1522         * xml/xmlhttprequest.cpp:
1523         (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
1524         adjusted.
1525         * xml/xmlhttprequest.h:
1526
1527 2006-11-04  Darin Adler  <darin@apple.com>
1528
1529         Change suggested by Mitz.
1530
1531         - fix http://bugs.webkit.org/show_bug.cgi?id=11514
1532           REGRESSION (r17438): Repro crash when opening a web archive
1533
1534         * bridge/mac/WebCorePageState.mm:
1535         (-[WebCorePageState dealloc]): Add null check.
1536         (-[WebCorePageState finalize]): Ditto.
1537
1538 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
1539
1540         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
1541
1542         http://bugs.webkit.org/show_bug.cgi?id=11433
1543         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
1544
1545         * WebCore.vcproj/WebCore/WebCore.vcproj:
1546         Added platform/graphics platform/network and platform/network/win to headers search paths
1547         Created platform/graphics and platform/network filters in hierarchy
1548         Moved GraphicsContext and GraphicsTypes to their respective filters
1549         Added EditorClient.h
1550         Added FrameLoader* files in loader/
1551         Added HitTest* files in rendering/
1552         Added Editor.* files in editing/
1553         Added DeleteButton.* and DeleteButtonController.* in editing/
1554
1555         * bridge/win/ChromeClientWin.h: Added.
1556         (WebCore::ChromeClientWin::~ChromeClientWin):
1557         * bridge/win/EditorClientWin.h: Added.
1558         (WebCore::EditorClientWin::~EditorClientWin):
1559
1560         * bridge/win/FrameWin.cpp:
1561         (WebCore::FrameWin::FrameWin):
1562         (WebCore::FrameWin::urlSelected):
1563         (WebCore::FrameWin::submitForm):
1564         (WebCore::FrameWin::createNewWindow):
1565         * bridge/win/FrameWin.h:
1566         Added EditorClient parameter to constructor
1567         Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
1568         Removed openURL() and openURLRequest from class definition
1569
1570         * bridge/win/PageWin.cpp:
1571         * platform/AffineTransform.h:
1572         * platform/cairo/AffineTransformCairo.cpp: Added.
1573         (WebCore::AffineTransform::AffineTransform):
1574         (WebCore::AffineTransform::setMatrix):
1575         (WebCore::AffineTransform::map):
1576         (WebCore::AffineTransform::mapRect):
1577         (WebCore::AffineTransform::isIdentity):
1578         (WebCore::AffineTransform::m11):
1579         (WebCore::AffineTransform::m12):
1580         (WebCore::AffineTransform::m21):
1581         (WebCore::AffineTransform::m22):
1582         (WebCore::AffineTransform::dx):
1583         (WebCore::AffineTransform::dy):
1584         (WebCore::AffineTransform::reset):
1585         (WebCore::AffineTransform::scale):
1586         (WebCore::AffineTransform::rotate):
1587         (WebCore::AffineTransform::translate):
1588         (WebCore::AffineTransform::shear):
1589         (WebCore::AffineTransform::det):
1590         (WebCore::AffineTransform::invert):
1591         (WebCore::AffineTransform::operator cairo_matrix_t):
1592         (WebCore::AffineTransform::operator== ):
1593         (WebCore::AffineTransform::operator*= ):
1594         (WebCore::AffineTransform::operator* ):
1595         * platform/cairo/GraphicsContextCairo.cpp:
1596         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
1597         * platform/network/win/ResourceHandleWin.cpp:
1598         (WebCore::ResourceHandle::onHandleCreated):
1599         (WebCore::ResourceHandle::start):
1600         (WebCore::ResourceHandle::fileLoadTimer):
1601         (WebCore::ResourceHandle::cancel):
1602         * platform/win/TemporaryLinkStubs.cpp:
1603         (WebCore::FrameWin::goBackOrForward):
1604         (WebCore::FrameWin::getHistoryLength):
1605         (WebCore::FrameWin::historyURL):
1606         (WebCore::ServeSynchronousRequest):
1607         (WebCore::ChromeClientWin::canRunModal):
1608         (WebCore::ChromeClientWin::runModal):
1609         (WebCore::EditorClientWin::shouldDeleteRange):
1610         (WebCore::EditorClientWin::shouldShowDeleteInterface):
1611         (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
1612         (WebCore::EditorClientWin::isGrammarCheckingEnabled):
1613         (WebCore::EditorClientWin::spellCheckerDocumentTag):
1614         (WebCore::Path::transform):
1615         (WebCore::PopupMenu::updateFromElement):
1616         (WebCore::ResourceLoader::loadsBlocked):
1617         (WebCore::systemBeep):
1618         * rendering/RenderThemeWin.cpp:
1619         (WebCore::RenderThemeWin::paintButton):
1620         (WebCore::RenderThemeWin::paintTextField):
1621
1622 2006-11-04  Alexey Proskuryakov  <ap@nypop.com>
1623
1624         Reviewed by Maciej.
1625
1626         http://bugs.webkit.org/show_bug.cgi?id=11448
1627         &lang; and &rang; entities are mapped to the incorrect Unicode codepoint
1628
1629         * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
1630
1631 2006-11-03  Mark Rowe  <bdash@webkit.org>
1632
1633         Reviewed by Oliver.
1634
1635         Update Windows and Qt project files for file removals in r17585.
1636
1637         * CMakeLists.txt:
1638         * WebCore.vcproj/WebCore/WebCore.vcproj:
1639
1640 2006-11-03  Zack Rusin  <zack@kde.org>
1641
1642         Reviewed by Maciej.
1643
1644         The patch fixes text field drawing on the Qt platform.
1645
1646         * platform/qt/RenderThemeQt.cpp:
1647         (WebCore::RenderThemeQt::paintTextField): Use the style to correctly
1648         render the text field
1649
1650 2006-11-03  Oliver Hunt  <oliver@apple.com>
1651
1652         Reviewed by Tim.
1653
1654         Correct incorrect call to SetCursor
1655
1656         * rendering/RenderFrameSet.cpp:
1657         (WebCore::RenderFrameSet::userResize):
1658
1659 2006-11-03  Adele Peterson  <adele@apple.com>
1660
1661         Reviewed by Oliver.
1662
1663         Removed DeprecatedRenderSelect and ListBox classes.
1664
1665         * WebCore.xcodeproj/project.pbxproj:
1666         * css/html4.css:
1667         * html/HTMLOptionElement.h:
1668         * html/HTMLSelectElement.cpp:
1669         (WebCore::HTMLSelectElement::recalcStyle):
1670         (WebCore::HTMLSelectElement::isKeyboardFocusable):
1671         (WebCore::HTMLSelectElement::isMouseFocusable):
1672         (WebCore::HTMLSelectElement::createRenderer):
1673         (WebCore::HTMLSelectElement::setRecalcListItems):
1674         (WebCore::HTMLSelectElement::notifyOptionSelected):
1675         (WebCore::HTMLSelectElement::defaultEventHandler):
1676         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
1677         (WebCore::HTMLSelectElement::updateListBoxSelection):
1678         * html/HTMLSelectElement.h:
1679         * platform/ListBox.h: Removed.
1680         * platform/mac/FontCacheMac.mm:
1681         * platform/mac/ListBoxMac.mm: Removed.
1682         * platform/win/TemporaryLinkStubs.cpp:
1683         * rendering/DeprecatedRenderSelect.cpp: Removed.
1684         * rendering/DeprecatedRenderSelect.h: Removed.
1685
1686 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
1687
1688         Not reviewed, fix for accidental commit.
1689
1690         - rolled back more of the accidentall commit that I forgot.
1691
1692         * platform/network/mac/ResourceRequestMac.h: Removed.
1693         * platform/network/mac/ResourceRequestMac.mm: Removed.
1694
1695 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
1696
1697         Not reviewed, fix for accidental commit.
1698
1699         - roll back some network changes accidentally committed with a previous patch.
1700
1701         * WebCore.xcodeproj/project.pbxproj:
1702         * bridge/mac/WebCoreFrameBridge.mm:
1703         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
1704         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
1705         * loader/CachedCSSStyleSheet.cpp:
1706         (WebCore::CachedCSSStyleSheet::checkNotify):
1707         * loader/CachedImage.cpp:
1708         (WebCore::CachedImage::createImage):
1709         * loader/CachedResource.cpp:
1710         (WebCore::CachedResource::CachedResource):
1711         (WebCore::CachedResource::~CachedResource):
1712         (WebCore::CachedResource::setExpireDate):
1713         (WebCore::CachedResource::isExpired):
1714         * loader/CachedResource.h:
1715         (WebCore::CachedResource::response):
1716         * loader/LoaderFunctions.h:
1717         * loader/loader.cpp:
1718         (WebCore::Loader::receivedResponse):
1719         (WebCore::Loader::didReceivedResponse):
1720         * loader/loader.h:
1721         * loader/mac/FormDataStream.h:
1722         * loader/mac/FormDataStream.m:
1723         (WebCore::formCreate):
1724         (WebCore::formFinalize):
1725         * loader/mac/ImageDocumentMac.mm:
1726         (WebCore::finishImageLoad):
1727         * loader/mac/LoaderFunctionsMac.mm:
1728         (WebCore::CheckCacheObjectStatus):
1729         (WebCore::CachedResource::setResponse):
1730         * loader/mac/SubresourceLoaderMac.mm:
1731         (WebCore::SubresourceLoader::willSendRequest):
1732         * platform/network/ResourceHandle.h:
1733         * platform/network/ResourceHandleClient.h:
1734         (WebCore::ResourceHandleClient::receivedRedirect):
1735         * platform/network/ResourceRequest.h:
1736         * platform/network/ResourceResponse.h:
1737         (WebCore::ResourceResponse::ResourceResponse):
1738         * platform/network/mac/ResourceHandleMac.mm:
1739         (WebCore::ResourceHandle::redirectedToURL):
1740         * xml/xmlhttprequest.cpp:
1741         (WebCore::XMLHttpRequest::receivedRedirect):
1742         * xml/xmlhttprequest.h:
1743
1744 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
1745
1746         Rubber-stamped by Oliver.
1747
1748         Remove these, they have been merged with SVGRenderTreeAsText.
1749
1750         * rendering/SVGRenderAsText.cpp: Removed.
1751         * rendering/SVGRenderAsText.h: Removed.
1752
1753 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
1754
1755         Build fix.
1756
1757         * platform/network/cf/ResourceHandleCFNet.cpp:
1758         (WebCore::willSendRequest):
1759
1760 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
1761
1762         Reviewed by Darin, Beth.
1763
1764         First cut at factoring Page's UIDelegate-related functions into Chrome
1765         and ChromeClient.
1766
1767         Layout tests pass.
1768
1769         * bridge/mac/PageMac.mm: Removed platform-specific constructor, added
1770         setBridge method to replace it.
1771         (WebCore::Page::setBridge):
1772
1773         * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact
1774         that WebCorePageBridge.h doesn't need to be included by ObjC-only files,
1775         and, now that it uses PassRefPtr, can't be.
1776
1777         * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
1778
1779         * page/Page.h:
1780         (WebCore::Page::dragCaretController): Made this function non-const so that
1781         m_dragCaretController doesn't have to be mutable.
1782
1783 2006-11-03  Alexey Proskuryakov  <ap@nypop.com>
1784
1785         Reviewed by Adele.
1786
1787         http://bugs.webkit.org/show_bug.cgi?id=7323
1788         REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
1789
1790         * bridge/mac/FrameMac.h: Moved drag source information to a static variable
1791         in FrameMac.mm. There can be only one drag active at any moment, and having
1792         this information here was making sharing this information between
1793         subframes hard.
1794
1795         * bridge/mac/FrameMac.mm:
1796         (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo.
1797         (WebCore::FrameMac::freeClipboard):
1798         (WebCore::FrameMac::dragHysteresisExceeded):
1799         (WebCore::FrameMac::handleMouseMoveEvent):
1800         (WebCore::FrameMac::handleMouseReleaseEvent):
1801         (WebCore::FrameMac::mouseDown):
1802         (WebCore::FrameMac::dragSourceMovedTo):
1803         (WebCore::FrameMac::dragSourceEndedAt):
1804         (WebCore::FrameMac::dispatchDragSrcEvent):
1805         Access drag source info via sharedDragInfo - this fixes drag source even dispatching.
1806         Also removed some old code that was forwarding mouse events to subviews to make
1807         HTML editing work in subframes.
1808
1809         * page/FrameView.cpp:
1810         (WebCore::FrameView::updateDragAndDrop):
1811         (WebCore::FrameView::cancelDragAndDrop):
1812         (WebCore::FrameView::performDragAndDrop):
1813         Forward events to subframes for dispatching - this fixes drag target events.
1814
1815 2006-11-03  Zack Rusin  <zack@kde.org>
1816
1817         Reviewed by Tim.
1818
1819         Fixing compile.
1820
1821         * platform/qt/LoaderFunctionsQt.cpp:
1822         (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
1823
1824 2006-11-01  Zack Rusin  <zack@kde.org>
1825
1826         Reviewed by Maciej.
1827
1828         Moving the word/sentence seperators into a file of their own
1829         and implementing findWordBoundary.
1830
1831         * CMakeLists.txt:
1832         * platform/qt/TemporaryLinkStubs.cpp:
1833         * platform/qt/TextBoundaries.cpp: Added.
1834         (WebCore::findNextSentenceFromIndex):
1835         (WebCore::findSentenceBoundary):
1836         (WebCore::findNextWordFromIndex):
1837         (WebCore::findWordBoundary):
1838
1839 2006-11-03  Zack Rusin  <zack@kde.org>
1840
1841         Reviewed by Maciej.
1842
1843         Compile on both KDE and Qt platforms
1844
1845         * CMakeLists.txt: add zlib explicitly
1846         * platform/network/qt/ResourceHandleManager.cpp:
1847         (WebCore::ResourceHandleManager::self):
1848         (WebCore::QtJob::QtJob):
1849         (WebCore::QtJob::timerEvent): Integrate both implementations
1850         so that moc can parse it
1851         (WebCore::ResourceHandleManager::deliverJobData):
1852         (WebCore::ResourceHandleManager::remove):
1853         * platform/network/qt/ResourceHandleManager.h:
1854
1855 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
1856
1857         No review, suggested by Mitz.
1858
1859         - fix a #if to be #ifdef
1860
1861         * platform/graphics/svg/cg/SVGResourceImageCg.cpp:
1862
1863 2006-11-03  Zack Rusin  <zack@kde.org>
1864
1865         Reviewed and landed by Maciej.
1866
1867         Compile on the Qt platform.
1868
1869         * ksvg2/misc/KCanvasRenderingStyle.h:
1870         * platform/qt/RenderThemeQt.cpp:
1871         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
1872
1873 2006-11-03  Zack Rusin  <zack@kde.org>
1874
1875         Reviewed by Hyatt. Landed by Maciej.
1876
1877         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
1878         to graphics context to be able to set consistant state
1879         on the platform specific painter without having to change
1880         fill/stroke/font on every operation. This fixes color/stroke/fill
1881         and font handling in the Qt port.
1882
1883         * platform/graphics/GraphicsContext.cpp:
1884         (WebCore::GraphicsContext::setFont):
1885         (WebCore::GraphicsContext::setPen):
1886         (WebCore::GraphicsContext::setFillColor):
1887         (WebCore::GraphicsContext::setPlatformPen):
1888         (WebCore::GraphicsContext::setPlatformFillColor):
1889         (WebCore::GraphicsContext::setPlatformFont):
1890         * platform/graphics/GraphicsContext.h:
1891         * platform/qt/GraphicsContextQt.cpp:
1892         (WebCore::toQtCompositionMode):
1893         (WebCore::toQtLineCap):
1894         (WebCore::toQtLineJoin):
1895         (WebCore::toQPenStyle):
1896         (WebCore::penToQPen):
1897         (WebCore::TransparencyLayer::TransparencyLayer):
1898         (WebCore::GraphicsContext::addRoundedRectClip):
1899         (WebCore::GraphicsContext::setPlatformFont):
1900         (WebCore::GraphicsContext::setPlatformPen):
1901         (WebCore::GraphicsContext::setPlatformFillColor):
1902         * platform/qt/ScrollViewCanvasQt.cpp:
1903         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
1904         (WebCore::ScrollViewCanvasQt::paintEvent):
1905         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
1906         * platform/qt/ScrollViewCanvasQt.h:
1907
1908 2006-11-02  Adele Peterson  <adele@apple.com>
1909
1910         Reviewed by Anders.
1911
1912         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
1913         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
1914
1915         Test: fast/forms/textarea-no-scroll-on-blur.html
1916
1917         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
1918           On blur, only scroll back to the start for text fields.
1919
1920 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
1921
1922         Another build fix.
1923
1924         * rendering/RenderFileUploadControl.cpp:
1925         (WebCore::RenderFileUploadControl::paintObject):
1926
1927 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
1928
1929         Build fix.
1930
1931         * page/FramePrivate.h:
1932         (WebCore::FramePrivate::FramePrivate):
1933
1934 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
1935
1936         Reviewed by Geoff, landed by Anders.
1937
1938         Fix dependency problems caused when running move-js-headers.sh
1939
1940         * move-js-headers.sh:
1941         Use cp -p instead of just cp so that the modification time
1942         of the original files are used.
1943
1944 2006-11-02  Adam Roben  <aroben@apple.com>
1945
1946         Reviewed by Tim H, landed by Anders.
1947
1948         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
1949         REGRESSION: Shadow of file upload button is clipped
1950
1951         * rendering/RenderFileUploadControl.cpp:
1952         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
1953         height to keep from clipping in the shadow
1954
1955 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
1956
1957         Reviewed by Maciej, landed by Anders.
1958
1959         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
1960         content and window. ScrollViewQt already receives correct content
1961         coordinates from QScrollArea.
1962         (WebCore::ScrollView::contentsToWindow):
1963         (WebCore::ScrollView::windowToContents):
1964
1965 2006-11-02  Simon Hausmann  <hausmann@kde.org>
1966
1967         Reviewed by Maciej, landed by Anders
1968
1969         * CMakeLists.txt: Make linkage against KDE libraries conditional
1970         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
1971           Qt base resource handler that supports only requests to the
1972           local filesystem. Used when compiling without KDE support.
1973           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
1974           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
1975         (WebCore::QtJob::QtJob):
1976         (WebCore::QtJob::timerEvent):
1977         (WebCore::ResourceHandleManager::ResourceHandleManager):
1978         (WebCore::ResourceHandleManager::~ResourceHandleManager):
1979         (WebCore::ResourceHandleManager::self):
1980         (WebCore::ResourceHandleManager::remove):
1981         (WebCore::ResourceHandleManager::add):
1982         (WebCore::ResourceHandleManager::cancel):
1983         (WebCore::ResourceHandleManager::deliverJobData):
1984         * platform/network/qt/ResourceHandleManager.h:
1985         * platform/qt/FrameQtClient.cpp:
1986         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
1987         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
1988         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
1989         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
1990           input dialog functions when compiling without KDE support
1991         (WebCore::ServeSynchronousRequest):
1992
1993 2006-11-02  David Carson  <dacarson@gmail.com>
1994
1995         Reviewed by Geoff, landed by Anders.
1996
1997         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
1998         Initializing variable in constructor.
1999
2000         * page/FramePrivate.h:
2001         (WebCore::FramePrivate::FramePrivate):
2002
2003 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
2004
2005         Reviewed by Geoff.
2006
2007         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
2008
2009         * platform/network/cf/ResourceHandleCFNet.cpp:
2010         (WebCore::addHeadersFromHashMap):
2011         Don't set all headers at once since that clears any previous headers set.
2012
2013         (WebCore::ResourceHandle::start):
2014
2015 2006-11-02  Adele Peterson  <adele@apple.com>
2016
2017         Reviewed by Mitz and Geoff.
2018
2019         - Fix for:
2020         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
2021         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
2022         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
2023
2024         Test: fast/forms/textarea-scrollbar.html
2025
2026         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
2027         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
2028
2029         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
2030         * rendering/RenderTextControl.cpp:
2031         (WebCore::RenderTextControl::RenderTextControl):
2032         (WebCore::RenderTextControl::setStyle):
2033         (WebCore::RenderTextControl::createDivStyle):
2034         (WebCore::RenderTextControl::updateFromElement):
2035         (WebCore::RenderTextControl::calcHeight):
2036         (WebCore::RenderTextControl::baselinePosition):
2037         (WebCore::RenderTextControl::nodeAtPoint):
2038         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
2039         (WebCore::RenderTextControl::scrollWidth):
2040         (WebCore::RenderTextControl::scrollHeight):
2041         (WebCore::RenderTextControl::scrollLeft):
2042         (WebCore::RenderTextControl::scrollTop):
2043
2044         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
2045
2046 2006-11-02  John Sullivan  <sullivan@apple.com>
2047
2048         Reviewed by Geoff Garen
2049
2050         * editing/Selection.cpp:
2051         (WebCore::Selection::showTreeForThis):
2052         this debugging method now displays start offset and end offset, at Darin's suggestion
2053
2054 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
2055
2056         Reviewed by darin
2057
2058         <rdar://problem/4062865>
2059         Copy/paste of a select element fails to include the options
2060
2061         * editing/SelectionController.cpp:
2062         (WebCore::SelectionController::modify): Added paragraphBoundary.
2063         * editing/htmlediting.cpp:
2064         (WebCore::canHaveChildrenForEditing): Added checks for input elements
2065         and textareas.  Insertion operations would fail when performed just
2066         before/after one of these elements b/c the content would be put inside
2067         the element.
2068         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
2069         editable content, and made the code to stop at an root faster (don't check
2070         isDescendantOf on every iteration).
2071         (WebCore::enclosingNodeOfType): Ditto.
2072         (WebCore::enclosingList): Ditto.
2073         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
2074         inappropriately named.
2075         * editing/markup.cpp:
2076         (WebCore::startMarkup): Use the text node's value instead of its rendered
2077         content for text nodes inside select elements.  One might also turn off
2078         annotation when createMarkup enters a select element, but createMarkup
2079         is iterative, not recursive, so doing so would be complicated.
2080         (WebCore::createMarkup): Add markup for unrendered nodes if they are
2081         descendants of a select element.
2082         * editing/visible_units.cpp:
2083         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
2084         where various replaced elements can't be copied when they are the only
2085         thing selected.
2086         (WebCore::endOfParagraph): Ditto.
2087
2088 2006-11-01  Oliver Hunt  <oliver@apple.com>
2089
2090         Reviewed by Adam.
2091
2092         Converting more or kcanvas/quartz from Obj-C to C++
2093         Minor SVG updates
2094         compatibility fixes
2095
2096         * WebCore.xcodeproj/project.pbxproj:
2097         * kcanvas/device/KRenderingPaintServer.h:
2098         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
2099         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
2100         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
2101         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
2102         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
2103         * kcanvas/device/quartz/QuartzSupport.h:
2104         * ksvg2/css/SVGCSSStyleSelector.cpp:
2105         * ksvg2/misc/KCanvasRenderingStyle.h:
2106         * ksvg2/scripts/cssmakeprops:
2107         * ksvg2/scripts/cssmakevalues:
2108         * ksvg2/scripts/make_names.pl:
2109         * ksvg2/svg/SVGAnimateColorElement.cpp:
2110         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2111         * ksvg2/svg/SVGAnimationElement.cpp:
2112         * ksvg2/svg/SVGMaskElement.cpp:
2113         * ksvg2/svg/SVGPatternElement.cpp:
2114         * ksvg2/svg/svgpathparser.cpp:
2115         * platform/Path.cpp:
2116         * platform/graphics/svg/SVGResourceImage.h:
2117         * rendering/RenderPath.cpp:
2118         * rendering/SVGRenderAsText.cpp:
2119
2120 2006-11-02  Mitz Pettel  <mitz@webkit.org>
2121
2122         Reviewed by Adele.
2123
2124         - Fix a regression from r17521: painting of and crash caused by tables
2125           with collapsed borders
2126
2127         * rendering/RenderTable.cpp:
2128         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
2129         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
2130         and 'paintInfo' is the parameter, which we were accidently modifying.
2131
2132 2006-11-01  Adele Peterson  <adele@apple.com>
2133
2134         Reviewed by Mitz.
2135
2136         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
2137         REGRESSION: Incomplete repaint of overflow areas when deleting
2138
2139         Restrict the repaint rect for overflow blocks after the height has been fully computed.
2140         Also, adjust the repaint rect coordinates for the scroll offset.
2141
2142         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
2143         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
2144
2145 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
2146
2147         Reviewed by Mitz.
2148
2149         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
2150         Rename the "p" member variable of the PaintInfo struct to "context"
2151
2152         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
2153           'context' and 'rect' respectively.
2154
2155         - Assorted surrounding cleanups.
2156
2157         * rendering/EllipsisBox.cpp:
2158         (WebCore::EllipsisBox::paint):
2159         * rendering/EllipsisBox.h:
2160         * rendering/InlineBox.cpp:
2161         (WebCore::InlineBox::paint):
2162         * rendering/InlineFlowBox.cpp:
2163         (WebCore::InlineFlowBox::paint):
2164         (WebCore::InlineFlowBox::paintBackground):
2165         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
2166         (WebCore::InlineFlowBox::paintDecorations):
2167         * rendering/InlineFlowBox.h:
2168         * rendering/InlineRunBox.h:
2169         * rendering/InlineTextBox.cpp:
2170         (WebCore::InlineTextBox::paint):
2171         * rendering/InlineTextBox.h:
2172         * rendering/RenderBlock.cpp:
2173         (WebCore::RenderBlock::paint):
2174         (WebCore::RenderBlock::paintChildren):
2175         (WebCore::RenderBlock::paintCaret):
2176         (WebCore::RenderBlock::paintObject):
2177         (WebCore::RenderBlock::paintFloats):
2178         (WebCore::RenderBlock::paintEllipsisBoxes):
2179         (WebCore::RenderBlock::paintSelection):
2180         (WebCore::RenderBlock::fillSelectionGaps):
2181         (WebCore::RenderBlock::fillInlineSelectionGaps):
2182         (WebCore::RenderBlock::fillBlockSelectionGaps):
2183         (WebCore::RenderBlock::fillHorizontalSelectionGap):
2184         (WebCore::RenderBlock::fillVerticalSelectionGap):
2185         (WebCore::RenderBlock::fillLeftSelectionGap):
2186         (WebCore::RenderBlock::fillRightSelectionGap):
2187         * rendering/RenderBox.cpp:
2188         (WebCore::RenderBox::paint):
2189         (WebCore::RenderBox::paintRootBoxDecorations):
2190         (WebCore::RenderBox::paintBoxDecorations):
2191         * rendering/RenderBox.h:
2192         * rendering/RenderButton.cpp:
2193         (WebCore::RenderButton::paintObject):
2194         * rendering/RenderFieldset.cpp:
2195         (WebCore::RenderFieldset::paintBoxDecorations):
2196         * rendering/RenderFileUploadControl.cpp:
2197         (WebCore::RenderFileUploadControl::paintObject):
2198         * rendering/RenderFlow.cpp:
2199         (WebCore::RenderFlow::continuationBefore):
2200         (WebCore::RenderFlow::addChildWithContinuation):
2201         (WebCore::RenderFlow::addChild):
2202         (WebCore::RenderFlow::attachLineBox):
2203         (WebCore::RenderFlow::destroy):
2204         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
2205         (WebCore::RenderFlow::dirtyLineBoxes):
2206         (WebCore::RenderFlow::createInlineBox):
2207         (WebCore::RenderFlow::paintLines):
2208         (WebCore::RenderFlow::getAbsoluteRepaintRect):
2209         (WebCore::RenderFlow::lowestPosition):
2210         (WebCore::RenderFlow::rightmostPosition):
2211         (WebCore::RenderFlow::leftmostPosition):
2212         (WebCore::RenderFlow::caretRect):
2213         (WebCore::RenderFlow::addFocusRingRects):
2214         (WebCore::RenderFlow::paintOutline):
2215         (WebCore::RenderFlow::paintOutlineForLine):
2216         * rendering/RenderForeignObject.cpp:
2217         (WebCore::RenderForeignObject::paint):
2218         * rendering/RenderHTMLCanvas.cpp:
2219         (WebCore::RenderHTMLCanvas::paint):
2220         * rendering/RenderImage.cpp:
2221         (WebCore::RenderImage::paint):
2222         * rendering/RenderLayer.cpp:
2223         (WebCore::RenderLayer::paintLayer):
2224         * rendering/RenderListBox.cpp:
2225         (WebCore::RenderListBox::paintObject):
2226         (WebCore::RenderListBox::paintScrollbar):
2227         (WebCore::RenderListBox::paintItemForeground):
2228         (WebCore::RenderListBox::paintItemBackground):
2229         * rendering/RenderListMarker.cpp:
2230         (WebCore::RenderListMarker::paint):
2231         * rendering/RenderMenuList.cpp:
2232         (WebCore::RenderMenuList::paintObject):
2233         * rendering/RenderObject.cpp:
2234         (WebCore::RenderObject::paint):
2235         * rendering/RenderObject.h:
2236         (WebCore::RenderObject::PaintInfo::PaintInfo):
2237         (WebCore::RenderObject::paintBoxDecorations):
2238         (WebCore::RenderObject::paintingRootForChildren):
2239         (WebCore::RenderObject::shouldPaintWithinRoot):
2240         (WebCore::RenderObject::printBoxDecorations):
2241         * rendering/RenderPath.cpp:
2242         (WebCore::RenderPath::paint):
2243         * rendering/RenderReplaced.cpp:
2244         (WebCore::RenderReplaced::shouldPaint):
2245         * rendering/RenderSVGContainer.cpp:
2246         (WebCore::RenderSVGContainer::paint):
2247         * rendering/RenderSVGContainer.h:
2248         * rendering/RenderSVGImage.cpp:
2249         (WebCore::RenderSVGImage::paint):
2250         * rendering/RenderSVGText.cpp:
2251         (WebCore::RenderSVGText::paint):
2252         * rendering/RenderSVGText.h:
2253         (WebCore::RenderSVGText::renderName):
2254         * rendering/RenderTable.cpp:
2255         (WebCore::RenderTable::paint):
2256         (WebCore::RenderTable::paintBoxDecorations):
2257         * rendering/RenderTable.h:
2258         * rendering/RenderTableCell.cpp:
2259         (WebCore::RenderTableCell::paint):
2260         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
2261         (WebCore::RenderTableCell::paintBoxDecorations):
2262         * rendering/RenderTableCell.h:
2263         * rendering/RenderTableRow.cpp:
2264         (WebCore::RenderTableRow::paint):
2265         * rendering/RenderTableRow.h:
2266         * rendering/RenderTableSection.cpp:
2267         (WebCore::RenderTableSection::paint):
2268         * rendering/RenderTableSection.h:
2269         (WebCore::RenderTableSection::getBaseline):
2270         (WebCore::RenderTableSection::setNeedCellRecalc):
2271         * rendering/RenderText.h:
2272         (WebCore::RenderText::renderName):
2273         (WebCore::RenderText::paint):
2274         (WebCore::RenderText::element):
2275         * rendering/RenderTheme.cpp:
2276         (WebCore::RenderTheme::paint):
2277         (WebCore::RenderTheme::paintBorderOnly):
2278         (WebCore::RenderTheme::paintDecorations):
2279         * rendering/RenderTheme.h:
2280         (WebCore::RenderTheme::RenderTheme):
2281         (WebCore::RenderTheme::~RenderTheme):
2282         (WebCore::RenderTheme::controlSupportsTints):
2283         (WebCore::RenderTheme::adjustRepaintRect):
2284         (WebCore::RenderTheme::themeChanged):
2285         (WebCore::RenderTheme::supportsHover):
2286         (WebCore::RenderTheme::paintCheckbox):
2287         (WebCore::RenderTheme::setCheckboxSize):
2288         (WebCore::RenderTheme::paintRadio):
2289         (WebCore::RenderTheme::setRadioSize):
2290         (WebCore::RenderTheme::paintButton):
2291         (WebCore::RenderTheme::setButtonSize):
2292         (WebCore::RenderTheme::paintTextField):
2293         (WebCore::RenderTheme::paintTextArea):
2294         (WebCore::RenderTheme::paintMenuList):
2295         (WebCore::RenderTheme::paintMenuListButton):
2296         * rendering/RenderThemeMac.mm:
2297         (WebCore::RenderThemeMac::paintCheckbox):
2298         (WebCore::RenderThemeMac::paintRadio):
2299         (WebCore::RenderThemeMac::paintButton):
2300         (WebCore::RenderThemeMac::paintTextField):
2301         (WebCore::RenderThemeMac::paintTextArea):
2302         (WebCore::RenderThemeMac::paintMenuList):
2303         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
2304         (WebCore::RenderThemeMac::paintMenuListButton):
2305         * rendering/RenderView.cpp:
2306         (WebCore::RenderView::paint):
2307         (WebCore::RenderView::paintBoxDecorations):
2308         * rendering/RenderView.h:
2309         * rendering/RenderWidget.cpp:
2310         (WebCore::RenderWidget::paint):
2311         * rendering/RenderWidget.h:
2312         (WebCore::RenderWidget::isWidget):
2313         * rendering/RootInlineBox.cpp:
2314         (WebCore::RootInlineBox::paintEllipsisBox):
2315         (WebCore::RootInlineBox::paintCustomHighlight):
2316         (WebCore::RootInlineBox::paint):
2317         (WebCore::RootInlineBox::fillLineSelectionGap):
2318         * rendering/RootInlineBox.h:
2319         * rendering/SVGInlineFlowBox.cpp:
2320         (WebCore::paintSVGInlineFlow):
2321
2322 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
2323
2324         Reviewed by Oliver, Brady.
2325
2326         * platform/network/ResourceResponse.h:
2327         (WebCore::ResourceResponse::setLastModifiedDate):
2328         (WebCore::ResourceResponse::lastModifiedDate):
2329         Add getters and setters for last modified dadte.
2330
2331         * platform/network/cf/ResourceResponseCFNet.cpp:
2332         (WebCore::getResourceResponse):
2333         Fetch the last modified date. Add correct offset to expired date.
2334
2335 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
2336
2337         Reviewed by Mitz.
2338
2339         Added missing "break;" statement in switch statement from r17493.
2340
2341         Bug 11442: [CSS 3] support for cursor: all-scroll
2342         http://bugs.webkit.org/show_bug.cgi?id=11442
2343
2344         * css/CSSComputedStyleDeclaration.cpp:
2345         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2346
2347 2006-10-31  Mitz Pettel  <mitz@webkit.org>
2348
2349         Reviewed by Maciej.
2350
2351         - fix image dragging
2352
2353         This is covered by editing/selection/drag-to-contenteditable-iframe.html
2354
2355         * rendering/HitTestResult.cpp:
2356         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
2357         HTML IMG elements.
2358         (WebCore::HitTestResult::absoluteImageURL): Ditto.
2359
2360 2006-10-31  Beth Dakin  <bdakin@apple.com>
2361
2362         Reviewed by Maciej.
2363
2364         This adds the back-end of the remaining WebElementDictionary
2365         functions into HitTestResult.
2366
2367         * WebCore.exp:
2368         * rendering/HitTestResult.cpp:
2369         (WebCore::HitTestResult::title):
2370         (WebCore::displayString): This is nearly identical to the
2371         displayString() defined in DOMInternal.mm except that it returns a
2372         String instead of an NSString. The old code path used the
2373         DOMInternal method, so I made a new one here for the new code path.
2374         (WebCore::HitTestResult::altDisplayString):
2375         (WebCore::HitTestResult::image):
2376         (WebCore::HitTestResult::absoluteImageURL):
2377         (WebCore::HitTestResult::absoluteLinkURL):
2378         (WebCore::HitTestResult::titleDisplayString):
2379         (WebCore::HitTestResult::textContent):
2380         * rendering/HitTestResult.h:
2381
2382 2006-10-31  John Sullivan  <sullivan@apple.com>
2383
2384         * bridge/mac/FrameMac.mm:
2385         (WebCore::FrameMac::markMisspellings):
2386         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
2387
2388 2006-10-31  John Sullivan  <sullivan@apple.com>
2389
2390         Reviewed by Maciej
2391
2392         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
2393
2394         The foundation of this was in my last checkin. This checkin is all about displaying
2395         the correct string in the toolTip.
2396
2397         * dom/DocumentMarker.h:
2398         New description field in this struct.
2399
2400         * bridge/mac/FrameMac.mm:
2401         (WebCore::FrameMac::advanceToNextMisspelling):
2402         When adding a grammar marker, supply the appropriate description. Also, added a comment
2403         about the remaining work to make grammar checking return sensible answers.
2404         (WebCore::FrameMac::markMisspellings):
2405         ditto (yes, still needs some refactoring to minimize duplicated code)
2406
2407         * dom/Document.h:
2408         * dom/Document.cpp:
2409         (WebCore::Document::addMarker):
2410         Now takes an optional description string
2411         (WebCore::Document::markerContainingPoint):
2412         New function, returns a pointer to the (first) marker of the specified type whose rect
2413         contains the specified point, or 0 if none.
2414
2415         * rendering/HitTestResult.cpp:
2416         (WebCore::HitTestResult::spellingToolTip):
2417         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
2418         and gets the description from the marker.
2419
2420 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
2421
2422         Reviewed by Maciej.
2423
2424         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
2425
2426         * loader/mac/FrameLoaderMac.mm:
2427         (WebCore::FrameLoader::createWindow):
2428         * manual-tests/window-open-features-parsing.html: Updated for clarity.
2429
2430 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
2431
2432         Reviewed by Alice.
2433
2434         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
2435         to WebCore::Editor.
2436
2437         Layout tests pass.
2438
2439         Renamed "may*" to "can*" because "can" is more accurate (these functions
2440         aren't just about permission) and it matches WebKit.
2441
2442         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a
2443         password field. Now that WebCore fully implements canCopy(), it doesn't just
2444         mean "the selection is not in a password field" anymore.
2445         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code.
2446         The fact that it's not called anymore may represent a security issue, but I
2447         don't see how commented-out code will help reveal the issue, and the
2448         bridge is going away, anyway.
2449         * editing/SelectionController.h: Changed selection() calls to references
2450         to m_sel, to match the rest of the file.
2451
2452 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
2453
2454         Reviewed by harrison
2455
2456         <rdar://problem/4711063>
2457         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
2458
2459         * editing/ReplaceSelectionCommand.cpp:
2460         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
2461         insertion and plain text string creation unless we need the string
2462         for a BeforeTextInserted event handler or for a plain text only region.
2463         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
2464         code here from ReplacementFragment's constructor.
2465         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
2466         FIXME.
2467         * editing/ReplaceSelectionCommand.h:
2468
2469 2006-10-31  Ada Chan  <adachan@apple.com>
2470
2471         Reviewed by Adam
2472
2473         Correct forward declarations of the HitTestRequest struct.
2474
2475         * rendering/EllipsisBox.h:
2476         * rendering/InlineBox.h:
2477         * rendering/InlineFlowBox.h:
2478         * rendering/RenderLayer.h:
2479         * rendering/RenderObject.h:
2480
2481 2006-10-31  John Sullivan  <sullivan@apple.com>
2482
2483         Reviewed by Beth and Adam
2484
2485         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip;
2486         next I'll make it use a string that's relevant for a specific grammar error.
2487
2488         * WebCore.exp:
2489         export symbol for spellingToolTip function
2490
2491         * rendering/HitTestResult.h:
2492         * rendering/HitTestResult.cpp:
2493         (WebCore::HitTestResult::spellingToolTip):
2494         new function, returns the string to be used in a tool tip that describes the questionable grammar
2495
2496         * rendering/InlineTextBox.h:
2497         * rendering/InlineTextBox.cpp:
2498         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
2499         now takes a style and font, needed to compute the rect representing the range containing
2500         questionable grammar. Computes the rect and associates it with the marker.
2501         (WebCore::InlineTextBox::paintDocumentMarkers):
2502         Pass in the style and font now needed by paintSpellingOrGrammarMarker
2503
2504 2006-10-31  Adele Peterson  <adele@apple.com>
2505
2506         Removed commented out variable from last checkin.
2507
2508         * html/HTMLSelectElement.cpp:
2509         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
2510
2511 2006-10-31  Brady Eidson  <beidson@apple.com>
2512
2513         Build fix (unused variable in release builds)
2514
2515         * html/HTMLSelectElement.cpp:
2516         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
2517
2518 2006-10-31  Adele Peterson  <adele@apple.com>
2519
2520         Reviewed by Adam.
2521
2522         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
2523         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
2524         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
2525
2526         Tests:
2527         * LayoutTests/fast/forms/listbox-selection.html
2528         * LayoutTests/fast/forms/listbox-onchange.html
2529
2530         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
2531           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
2532           And one for onChange, that is updated after onChange is fired.
2533           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
2534
2535         * html/HTMLSelectElement.cpp:
2536         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
2537         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
2538         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
2539         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
2540         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
2541         (WebCore::HTMLSelectElement::setExtent): Added.
2542         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
2543         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
2544
2545         * rendering/RenderListBox.cpp:
2546         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
2547         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
2548         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
2549         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
2550          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
2551          notify the select element from here.
2552         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
2553         (WebCore::RenderListBox::listIndexIsVisible): Added.
2554         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
2555
2556         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction,
2557         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
2558         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
2559         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
2560         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
2561
2562 2006-10-31  Beth Dakin  <bdakin@apple.com>
2563
2564         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
2565
2566         * rendering/HitTestRequest.h: Added.
2567         (WebCore::HitTestRequest::HitTestRequest):
2568
2569 2006-10-31  Beth Dakin  <bdakin@apple.com>
2570
2571         Reviewed by Maciej.
2572
2573         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult
2574         should be split into HitTestRequest and HitTestResult
2575
2576         This patch creates a new struct called HitTestRequest that holds
2577         the three boolean values (readonly, active, and mouseMove) that
2578         were formerly a part of HitTestResult. All hitTest() and
2579         nodeAtPoint() functions now take a HitTestRequest in addition to
2580         the HitTestResult.
2581
2582         * WebCore.exp:
2583         * WebCore.xcodeproj/project.pbxproj:
2584         * bridge/mac/FrameMac.mm:
2585         (WebCore::FrameMac::eventMayStartDrag):
2586         (WebCore::FrameMac::handleMouseMoveEvent):
2587         * bridge/mac/WebCoreAXObject.mm:
2588         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
2589         (-[WebCoreAXObject accessibilityHitTest:]):
2590         * dom/Document.cpp:
2591         (WebCore::Document::elementFromPoint):
2592         (WebCore::Document::prepareMouseEvent):
2593         * editing/SelectionController.cpp:
2594         (WebCore::SelectionController::contains):
2595         * page/Frame.cpp:
2596         (WebCore::Frame::hitTestResultAtPoint):
2597         * page/FrameView.cpp:
2598         (WebCore::FrameView::handleWheelEvent):
2599         * rendering/EllipsisBox.cpp:
2600         (WebCore::EllipsisBox::nodeAtPoint):
2601         * rendering/EllipsisBox.h:
2602         * rendering/HitTestResult.cpp:
2603         (WebCore::HitTestResult::HitTestResult):
2604         (WebCore::HitTestResult::operator=):
2605         * rendering/HitTestResult.h:
2606         * rendering/InlineBox.cpp:
2607         (WebCore::InlineBox::nodeAtPoint):
2608         * rendering/InlineBox.h:
2609         * rendering/InlineFlowBox.cpp:
2610         (WebCore::InlineFlowBox::nodeAtPoint):
2611         * rendering/InlineFlowBox.h:
2612         * rendering/InlineTextBox.cpp:
2613         (WebCore::InlineTextBox::nodeAtPoint):
2614         * rendering/InlineTextBox.h:
2615         * rendering/RenderBlock.cpp:
2616         (WebCore::RenderBlock::nodeAtPoint):
2617         * rendering/RenderBlock.h:
2618         * rendering/RenderBox.cpp:
2619         (WebCore::RenderBox::nodeAtPoint):
2620         * rendering/RenderBox.h:
2621         * rendering/RenderFlow.cpp:
2622         (WebCore::RenderFlow::hitTestLines):
2623         * rendering/RenderFlow.h:
2624         * rendering/RenderForeignObject.cpp:
2625         (WebCore::RenderForeignObject::nodeAtPoint):
2626         * rendering/RenderForeignObject.h:
2627         * rendering/RenderFrameSet.cpp:
2628         (WebCore::RenderFrameSet::nodeAtPoint):
2629         * rendering/RenderFrameSet.h:
2630         * rendering/RenderImage.cpp:
2631         (WebCore::RenderImage::nodeAtPoint):
2632         * rendering/RenderImage.h:
2633         * rendering/RenderInline.cpp:
2634         (WebCore::RenderInline::nodeAtPoint):
2635         * rendering/RenderInline.h:
2636         * rendering/RenderLayer.cpp:
2637         (WebCore::RenderLayer::autoscroll):
2638         (WebCore::RenderLayer::hitTest):
2639         (WebCore::RenderLayer::hitTestLayer):
2640         (WebCore::RenderLayer::updateHoverActiveState):
2641         * rendering/RenderLayer.h:
2642         * rendering/RenderObject.cpp:
2643         (WebCore::RenderObject::hitTest):
2644         (WebCore::RenderObject::nodeAtPoint):
2645         * rendering/RenderObject.h:
2646         * rendering/RenderPath.cpp:
2647         (WebCore::RenderPath::nodeAtPoint):
2648         * rendering/RenderPath.h:
2649         * rendering/RenderSVGImage.cpp:
2650         (WebCore::RenderSVGImage::nodeAtPoint):
2651         * rendering/RenderSVGImage.h:
2652         * rendering/RenderSVGText.cpp:
2653         (WebCore::RenderSVGText::nodeAtPoint):
2654         * rendering/RenderSVGText.h:
2655         * rendering/RenderTableRow.cpp:
2656         (WebCore::RenderTableRow::nodeAtPoint):
2657         * rendering/RenderTableRow.h:
2658         * rendering/RenderTableSection.cpp:
2659         (WebCore::RenderTableSection::nodeAtPoint):
2660         * rendering/RenderTableSection.h:
2661         * rendering/RenderText.h:
2662         (WebCore::RenderText::nodeAtPoint):
2663         * rendering/RenderTextControl.cpp:
2664         (WebCore::RenderTextControl::nodeAtPoint):
2665         * rendering/RenderTextControl.h:
2666         * rendering/RootInlineBox.cpp:
2667         (WebCore::RootInlineBox::nodeAtPoint):
2668         * rendering/RootInlineBox.h:
2669
2670 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
2671
2672         Reviewed by Maciej.
2673
2674         Bug 11442: [CSS 3] support for cursor: all-scroll
2675         http://bugs.webkit.org/show_bug.cgi?id=11442
2676
2677         * css/CSSComputedStyleDeclaration.cpp:
2678         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2679         * css/CSSValueKeywords.in:
2680         * css/cssparser.cpp:
2681         (WebCore::CSSParser::parseValue):
2682         * page/FrameView.cpp:
2683         (WebCore::selectCursor):
2684         * rendering/RenderStyle.h:
2685
2686 2006-10-31  Oliver Hunt  <oliver@apple.com>
2687
2688         Reviewed by Geoff.
2689
2690         Converting Obj-C++ to C++ in kcanvas
2691
2692         * WebCore.xcodeproj/project.pbxproj:
2693         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
2694         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2695         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
2696         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
2697         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
2698         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2699         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
2700         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2701         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
2702         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
2703         * kcanvas/device/quartz/QuartzSupport.h:
2704         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
2705         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
2706         (WebCore::SVGResourceClipper::applyClip):
2707         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
2708         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
2709         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
2710
2711 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
2712
2713         Reviewed by harrison
2714
2715         <rdar://problem/4808375>
2716         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
2717
2718         Completely back out r17276 because of performance issues.
2719
2720         * editing/TextIterator.cpp:
2721         (WebCore::TextIterator::TextIterator):
2722         (WebCore::TextIterator::advance):
2723         (WebCore::TextIterator::handleTextNode):
2724         (WebCore::TextIterator::handleTextBox):
2725         (WebCore::TextIterator::handleReplacedElement):
2726         (WebCore::TextIterator::handleNonTextNode):
2727         (WebCore::TextIterator::exitNode):
2728         (WebCore::TextIterator::emitCharacter):
2729         (WebCore::TextIterator::range):
2730         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
2731         (WebCore::SimplifiedBackwardsTextIterator::advance):
2732         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
2733         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
2734         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
2735         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
2736         (WebCore::SimplifiedBackwardsTextIterator::range):
2737         (WebCore::CharacterIterator::range):
2738         (WebCore::TextIterator::rangeFromLocationAndLength):
2739         * editing/TextIterator.h:
2740         (WebCore::TextIterator::atEnd):
2741         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
2742
2743 2006-10-31  Darin Adler  <darin@apple.com>
2744
2745         Reviewed by Brady.
2746
2747         - got "action dictionary" code out of FrameLoader,
2748           replacing with a class called NavigationAction
2749
2750         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
2751         * loader/mac/DocumentLoaderMac.mm:
2752         (WebCore::DocumentLoader::triggeringAction): Ditto.
2753         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
2754
2755         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
2756
2757         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
2758         Removed elementForEvent.
2759         * loader/mac/FrameLoaderMac.mm:
2760         (WebCore::FrameLoader::load): Ditto.
2761         (WebCore::FrameLoader::reload): Ditto.
2762         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
2763         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
2764         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
2765         (WebCore::FrameLoader::post): Ditto.
2766
2767         * loader/NavigationAction.h: Added.
2768         * loader/NavigationAction.cpp: Added.
2769         * loader/mac/NavigationActionMac.mm: Added.
2770
2771         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
2772
2773         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
2774         * WebCore.exp: Updated.
2775
2776 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
2777
2778         Reviewed by Adam.
2779
2780         Build fix
2781
2782         * platform/win/CookieJarWin.cpp:
2783         (WebCore::cookies):
2784
2785 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
2786
2787         Reviewed by Maciej. Landed by Adam.
2788
2789         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
2790
2791         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
2792         as dicussed with Dave. Also kill the outdated DESIGN document.
2793
2794         * CMakeLists.txt:
2795         * WebCore.xcodeproj/project.pbxproj:
2796         * kcanvas/DESIGN: Removed.
2797         * kcanvas/KCanvasFilters.cpp:
2798         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
2799         * kcanvas/KCanvasTreeDebug.h: Ditto.
2800         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2801         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2802         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2803         * platform/graphics/svg/SVGResourceClipper.cpp:
2804         * rendering/RenderTreeAsText.cpp:
2805         * rendering/SVGRenderTreeAsText.cpp: Added.
2806         * rendering/SVGRenderTreeAsText.h: Added.
2807         (WebCore::operator<<):
2808
2809 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
2810
2811         Reviewed by Maciej.
2812
2813         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
2814         Includes some CRLF -> LF fixups.
2815
2816         * platform/win/CookieJarWin.cpp:
2817         (WebCore::cookies):
2818
2819 2006-10-31  Adam Roben  <aroben@apple.com>
2820
2821         Reviewed by Steve.
2822
2823         Fix some incorrect forward declarations.
2824
2825         * loader/FrameLoader.h:
2826         * page/Frame.h:
2827
2828 2006-10-31  Darin Adler  <darin@apple.com>
2829
2830         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
2831         try to fix the build on the buildbot.
2832
2833 2006-10-31  Darin Adler  <darin@apple.com>
2834
2835         * bridge/mac/FrameMac.mm:
2836         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
2837         (WebCore::FrameMac::markMisspellings): Ditto.
2838
2839 2006-10-31  John Sullivan  <sullivan@apple.com>
2840
2841         * bridge/mac/FrameMac.mm:
2842         (WebCore::FrameMac::advanceToNextMisspelling):
2843         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
2844
2845 2006-10-30  John Sullivan  <sullivan@apple.com>
2846
2847         Reviewed by Adam Roben
2848
2849         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
2850
2851         This patch introduces much of the guts of grammar checking, though still not enough to actually
2852         check grammar sensibly, due to:
2853
2854         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient
2855         context passed to grammar checker
2856
2857         * platform/Logging.h:
2858         * platform/Logging.cpp:
2859         new log channel SpellingAndGrammar
2860
2861         * bridge/mac/WebCorePageBridge.mm:
2862         (initializeLoggingChannelsIfNecessary):
2863         initialize new log channel
2864
2865         * bridge/mac/FrameMac.mm:
2866         (WebCore::FrameMac::advanceToNextMisspelling):
2867         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
2868         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
2869         in the event of a tie), and do further processing with that one (select range; create marker that
2870         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
2871         (WebCore::FrameMac::markMisspellings):
2872         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just
2873         differently enough to make sharing code between these two functions a little tricky, so I decided to
2874         save that for a later patch.
2875
2876         (WebCore::FrameMac::respondToChangedSelection):
2877         remove grammar markers when we remove spelling markers
2878
2879 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
2880
2881         Reviewed by Mitz.
2882
2883         Fix Qt/Linux build with older gcc3.3.4.
2884
2885         * bindings/js/kjs_window.cpp:
2886         (KJS::WindowFunc::callAsFunction):
2887
2888 2006-10-31  Zack Rusin  <zack@kde.org>
2889
2890         Reviewed by Mitz.
2891
2892         Fix the Qt build after last nights changes.
2893
2894         * WebCore/platform/qt/FrameQt.cpp:
2895         * WebCore/platform/qt/EditorClientQt.h:
2896         * WebCore/platform/qt/EditorClientQt.cpp:
2897         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
2898         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
2899         * WebCore/CMakeLists.txt:
2900         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
2901         * WebKitQt/QtLauncher/CMakeLists.txt:
2902         * WebKitQt/WebKitPart/CMakeLists.txt:
2903
2904 2006-10-30  Darin Adler  <darin@apple.com>
2905
2906         Reviewed by Anders.
2907
2908         - remove BrowserExtension
2909
2910         * WebCore.vcproj/WebCore/WebCore.vcproj:
2911         * WebCore.xcodeproj/project.pbxproj:
2912         * bindings/js/kjs_window.cpp:
2913         (KJS::createNewWindow):
2914         (KJS::WindowFunc::callAsFunction):
2915         * bridge/BrowserExtension.h: Removed.
2916         * bridge/mac/BrowserExtensionMac.h: Removed.
2917         * bridge/mac/BrowserExtensionMac.mm: Removed.
2918         * bridge/mac/FrameMac.mm:
2919         (WebCore::FrameMac::FrameMac):
2920         (WebCore::FrameMac::submitForm):
2921         (WebCore::FrameMac::urlSelected):
2922         * bridge/win/BrowserExtensionWin.cpp: Removed.
2923         * bridge/win/BrowserExtensionWin.h: Removed.
2924         * bridge/win/FrameWin.cpp:
2925         (WebCore::FrameWin::FrameWin):
2926         * loader/FrameLoader.cpp:
2927         (WebCore::FrameLoader::createWindow):
2928         * loader/FrameLoader.h:
2929         * loader/icon/IconLoader.cpp:
2930         * loader/mac/FrameLoaderMac.mm:
2931         (WebCore::FrameLoader::safeLoad):
2932         (WebCore::FrameLoader::load):
2933         (WebCore::FrameLoader::createWindow):
2934         * page/Frame.cpp:
2935         (WebCore::Frame::urlSelected):
2936         (WebCore::Frame::requestFrame):
2937         (WebCore::Frame::submitForm):
2938         (WebCore::Frame::scheduleHistoryNavigation):
2939         (WebCore::Frame::redirectionTimerFired):
2940         * page/Frame.h:
2941         * page/FrameLoadRequest.h:
2942         (WebCore::FrameLoadRequest::FrameLoadRequest):
2943         (WebCore::FrameLoadRequest::isEmpty):
2944         (WebCore::FrameLoadRequest::resourceRequest):
2945         (WebCore::FrameLoadRequest::frameName):
2946         (WebCore::FrameLoadRequest::setFrameName):
2947         * page/FramePrivate.h:
2948         (WebCore::FramePrivate::FramePrivate):
2949         (WebCore::FramePrivate::~FramePrivate):
2950         * platform/gdk/BrowserExtensionGdk.h: Removed.
2951         * platform/gdk/FrameGdk.cpp:
2952         (WebCore::FrameGdk::FrameGdk):
2953         * platform/gdk/TemporaryLinkStubs.cpp:
2954         * platform/network/ResourceRequest.h:
2955         (WebCore::ResourceRequest::isEmpty):
2956
2957 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
2958
2959         Reviewed by Oliver.
2960
2961         Modified from original due to earlier reversion
2962
2963         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
2964
2965         Better SVG integration in WebKit, Part I.
2966
2967         The patch is mostly about creating a new platform/graphics directory, and
2968         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
2969         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
2970         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
2971
2972         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
2973         All details of the patch, and upcoming patches can be found in the bug report.
2974
2975         * CMakeLists.txt:
2976         * WebCore.xcodeproj/project.pbxproj:
2977         * graphics/svg/SVGResource.cpp: Removed.
2978         * graphics/svg/SVGResourceClipper.cpp: Removed.
2979         * graphics/svg/SVGResourceClipper.h: Removed.
2980         * graphics/svg/SVGResourceImage.h: Removed.
2981         * graphics/svg/SVGResourceListener.h: Removed.
2982         * graphics/svg/SVGResourceMarker.cpp: Removed.
2983         * graphics/svg/SVGResourceMarker.h: Removed.
2984         * graphics/svg/SVGResourceMasker.cpp: Removed.
2985         * graphics/svg/SVGResourceMasker.h: Removed.
2986         * kcanvas/KCanvasClipper.cpp: Removed.
2987         * kcanvas/KCanvasClipper.h: Removed.
2988         * kcanvas/KCanvasCreator.cpp: Removed.
2989         * kcanvas/KCanvasCreator.h: Removed.
2990         * kcanvas/KCanvasFilters.cpp:
2991         (WebCore::getFilterById):
2992         * kcanvas/KCanvasFilters.h:
2993         * kcanvas/KCanvasImage.h: Removed.
2994         * kcanvas/KCanvasMarker.cpp: Removed.
2995         * kcanvas/KCanvasMarker.h: Removed.
2996         * kcanvas/KCanvasMasker.cpp: Removed.
2997         * kcanvas/KCanvasMasker.h: Removed.
2998         * kcanvas/KCanvasResource.cpp: Removed.
2999         * kcanvas/KCanvasResource.h: Removed.
3000         * kcanvas/KCanvasResourceListener.h: Removed.
3001         * kcanvas/KCanvasTreeDebug.cpp:
3002         (WebCore::writeRenderResources):
3003         * kcanvas/device/KRenderingDevice.h:
3004         * kcanvas/device/KRenderingPaintServer.h:
3005         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
3006         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3007         (WebCore::KRenderingPaintServerGradient::listener):
3008         (WebCore::KRenderingPaintServerGradient::setListener):
3009         * kcanvas/device/KRenderingPaintServerGradient.h:
3010         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3011         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
3012         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
3013         (WebCore::KRenderingPaintServerPattern::tile):
3014         (WebCore::KRenderingPaintServerPattern::setTile):
3015         (WebCore::KRenderingPaintServerPattern::listener):
3016         (WebCore::KRenderingPaintServerPattern::setListener):
3017         * kcanvas/device/KRenderingPaintServerPattern.h:
3018         * kcanvas/device/KRenderingPaintServerSolid.h:
3019         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
3020         * kcanvas/device/qt/KCanvasClipperQt.h:
3021         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
3022         (WebCore::KRenderingDeviceQt::contextForImage):
3023         (WebCore::KRenderingDeviceQt::createResource):
3024         (WebCore::KRenderingDeviceQt::createPaintServer):
3025         * kcanvas/device/qt/KRenderingDeviceQt.h:
3026         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
3027         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
3028         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
3029         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
3030         * kcanvas/device/qt/RenderPathQt.h: Removed.
3031         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3032         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
3033         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
3034         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
3035         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
3036         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
3037         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
3038         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
3039         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
3040         (WebCore::KRenderingDeviceQuartz::contextForImage):
3041         (WebCore::KRenderingDeviceQuartz::createPaintServer):
3042         (WebCore::KRenderingDeviceQuartz::createResource):
3043         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3044         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
3045         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
3046         (WebCore::KRenderingPaintServerGradientQuartz::setup):
3047         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
3048         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
3049         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3050         (WebCore::patternCallback):
3051         (WebCore::KRenderingPaintServerPatternQuartz::setup):
3052         * kcanvas/device/quartz/QuartzSupport.mm:
3053         * ksvg2/misc/KCanvasRenderingStyle.cpp:
3054         (WebCore::sharedSolidPaintServer):
3055         * ksvg2/svg/SVGClipPathElement.cpp:
3056         (WebCore::SVGClipPathElement::SVGClipPathElement):
3057         (WebCore::SVGClipPathElement::~SVGClipPathElement):
3058         (WebCore::SVGClipPathElement::canvasResource):
3059         * ksvg2/svg/SVGClipPathElement.h:
3060         * ksvg2/svg/SVGFEImageElement.cpp:
3061         * ksvg2/svg/SVGFilterElement.cpp:
3062         (WebCore::SVGFilterElement::SVGFilterElement):
3063         (WebCore::SVGFilterElement::~SVGFilterElement):
3064         (WebCore::SVGFilterElement::canvasResource):
3065         * ksvg2/svg/SVGFilterElement.h:
3066         * ksvg2/svg/SVGGradientElement.cpp:
3067         (WebCore::SVGGradientElement::SVGGradientElement):
3068         (WebCore::SVGGradientElement::~SVGGradientElement):
3069         (WebCore::SVGGradientElement::canvasResource):
3070         (WebCore::SVGGradientElement::resourceNotification):
3071         * ksvg2/svg/SVGGradientElement.h:
3072         * ksvg2/svg/SVGImageElement.cpp:
3073         * ksvg2/svg/SVGLinearGradientElement.cpp:
3074         (WebCore::SVGLinearGradientElement::buildGradient):
3075         * ksvg2/svg/SVGLinearGradientElement.h:
3076         * ksvg2/svg/SVGMarkerElement.cpp:
3077         (WebCore::SVGMarkerElement::SVGMarkerElement):
3078         (WebCore::SVGMarkerElement::~SVGMarkerElement):
3079         (WebCore::SVGMarkerElement::canvasResource):
3080         * ksvg2/svg/SVGMarkerElement.h:
3081         * ksvg2/svg/SVGMaskElement.cpp:
3082         (WebCore::SVGMaskElement::SVGMaskElement):
3083         (WebCore::SVGMaskElement::~SVGMaskElement):
3084         (WebCore::SVGMaskElement::drawMaskerContent):
3085         (WebCore::SVGMaskElement::canvasResource):
3086         * ksvg2/svg/SVGMaskElement.h:
3087         * ksvg2/svg/SVGPatternElement.cpp:
3088         (WebCore::SVGPatternElement::SVGPatternElement):
3089         (WebCore::SVGPatternElement::~SVGPatternElement):
3090         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
3091         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
3092         (WebCore::SVGPatternElement::canvasResource):
3093         * ksvg2/svg/SVGPatternElement.h:
3094         * ksvg2/svg/SVGRadialGradientElement.cpp:
3095         (WebCore::SVGRadialGradientElement::buildGradient):
3096         * ksvg2/svg/SVGRadialGradientElement.h:
3097         * ksvg2/svg/SVGStyledElement.h:
3098         (WebCore::SVGStyledElement::canvasResource):
3099         * platform/GraphicsContext.cpp: Removed.
3100         * platform/GraphicsContext.h: Removed.
3101         * platform/GraphicsTypes.cpp: Removed.
3102         * platform/GraphicsTypes.h: Removed.
3103         * platform/graphics/GraphicsContext.cpp:
3104         (WebCore::GraphicsContextState::GraphicsContextState):
3105         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
3106         (WebCore::GraphicsContext::createGraphicsContextPrivate):
3107         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
3108         (WebCore::GraphicsContext::save):
3109         (WebCore::GraphicsContext::restore):
3110         (WebCore::GraphicsContext::font):
3111         (WebCore::GraphicsContext::setFont):
3112         (WebCore::GraphicsContext::pen):
3113         (WebCore::GraphicsContext::setPen):
3114         (WebCore::GraphicsContext::setFillColor):
3115         (WebCore::GraphicsContext::fillColor):
3116         (WebCore::GraphicsContext::updatingControlTints):
3117         (WebCore::GraphicsContext::setUpdatingControlTints):
3118         (WebCore::GraphicsContext::setPaintingDisabled):
3119         (WebCore::GraphicsContext::paintingDisabled):
3120         (WebCore::GraphicsContext::drawImage):
3121         (WebCore::GraphicsContext::drawText):
3122         (WebCore::GraphicsContext::drawHighlightForText):
3123         (WebCore::GraphicsContext::initFocusRing):
3124         (WebCore::GraphicsContext::clearFocusRing):
3125         (WebCore::GraphicsContext::focusRingBoundingRect):
3126         (WebCore::GraphicsContext::addFocusRingRect):
3127         (WebCore::GraphicsContext::focusRingWidth):
3128         (WebCore::GraphicsContext::focusRingOffset):
3129         (WebCore::GraphicsContext::focusRingRects):
3130         (WebCore::GraphicsContext::drawTiledImage):
3131         * platform/graphics/GraphicsContext.h:
3132         * platform/graphics/GraphicsTypes.cpp:
3133         (WebCore::):
3134         (WebCore::parseCompositeOperator):
3135         (WebCore::compositeOperatorName):
3136         (WebCore::parseLineCap):
3137         (WebCore::lineCapName):
3138         (WebCore::parseLineJoin):
3139         (WebCore::lineJoinName):
3140         * platform/graphics/GraphicsTypes.h:
3141         (WebCore::):
3142         * platform/graphics/svg/SVGResource.cpp: Added.
3143         (WebCore::SVGResource::SVGResource):
3144         (WebCore::SVGResource::~SVGResource):
3145         (WebCore::SVGResource::invalidate):
3146         (WebCore::SVGResource::addClient):
3147         (WebCore::SVGResource::clients):
3148         (WebCore::SVGResource::idInRegistry):
3149         (WebCore::SVGResource::setIdInRegistry):
3150         (WebCore::SVGResource::externalRepresentation):
3151         (WebCore::getResourceById):
3152         (WebCore::getPaintServerById):
3153         (WebCore::operator<<):
3154         * platform/graphics/svg/SVGResource.h: Added.
3155         (WebCore::):
3156         (WebCore::SVGResource::isPaintServer):
3157         (WebCore::SVGResource::isFilter):
3158         (WebCore::SVGResource::isClipper):
3159         (WebCore::SVGResource::isMarker):
3160         (WebCore::SVGResource::isMasker):
3161         (WebCore::SVGResourceListener::~SVGResourceListener):
3162         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
3163         (WebCore::SVGResourceClipper::SVGResourceClipper):
3164         (WebCore::SVGResourceClipper::~SVGResourceClipper):
3165         (WebCore::SVGResourceClipper::resetClipData):
3166         (WebCore::SVGResourceClipper::addClipData):
3167         (WebCore::SVGResourceClipper::clipData):
3168         (WebCore::SVGResourceClipper::externalRepresentation):
3169         (WebCore::operator<<):
3170         (WebCore::getClipperById):
3171         * platform/graphics/svg/SVGResourceClipper.h: Added.
3172         (WebCore::ClipDataList::addPath):
3173         (WebCore::SVGResourceClipper::isClipper):
3174         * platform/graphics/svg/SVGResourceImage.h: Added.
3175         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
3176         (WebCore::SVGResourceMarker::SVGResourceMarker):
3177         (WebCore::SVGResourceMarker::~SVGResourceMarker):
3178         (WebCore::SVGResourceMarker::setMarker):
3179         (WebCore::SVGResourceMarker::setRef):
3180         (WebCore::SVGResourceMarker::draw):
3181         (WebCore::SVGResourceMarker::externalRepresentation):
3182         (WebCore::getMarkerById):
3183         * platform/graphics/svg/SVGResourceMarker.h: Added.
3184         (WebCore::SVGResourceMarker::refX):
3185         (WebCore::SVGResourceMarker::refY):
3186         (WebCore::SVGResourceMarker::setAngle):
3187         (WebCore::SVGResourceMarker::setAutoAngle):
3188         (WebCore::SVGResourceMarker::angle):
3189         (WebCore::SVGResourceMarker::setUseStrokeWidth):
3190         (WebCore::SVGResourceMarker::useStrokeWidth):
3191         (WebCore::SVGResourceMarker::isMarker):
3192         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
3193         (WebCore::SVGResourceMasker::SVGResourceMasker):
3194         (WebCore::SVGResourceMasker::~SVGResourceMasker):
3195         (WebCore::SVGResourceMasker::setMask):
3196         (WebCore::SVGResourceMasker::mask):
3197         (WebCore::SVGResourceMasker::externalRepresentation):
3198         (WebCore::getMaskerById):
3199         * platform/graphics/svg/SVGResourceMasker.h: Added.
3200         (WebCore::SVGResourceMasker::isMasker):
3201         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
3202         (WebCore::SVGResourceClipper::applyClip):
3203         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
3204         (WebCore::SVGResourceImage::SVGResourceImage):
3205         (WebCore::SVGResourceImage::~SVGResourceImage):
3206         (WebCore::SVGResourceImage::init):
3207         (WebCore::SVGResourceImage::size):
3208         (WebCore::SVGResourceImage::cgLayer):
3209         (WebCore::SVGResourceImage::setCGLayer):
3210         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
3211         (WebCore::applyLuminanceToAlphaFilter):
3212         (WebCore::applyExpandAlphatoGrayscaleFilter):
3213         (WebCore::transformImageIntoGrayscaleMask):
3214         (WebCore::SVGResourceMasker::applyMask):
3215         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
3216         (WebCore::SVGResourceClipper::applyClip):
3217         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
3218         (WebCore::SVGResourceImage::init):
3219         (WebCore::SVGResourceImage::size):
3220         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
3221         (WebCore::SVGResourceMasker::applyMask):
3222         * platform/qt/GraphicsContextQt.cpp:
3223         * rendering/RenderPath.cpp:
3224         (WebCore::RenderPath::paint):
3225         (WebCore::DrawMarkersData::DrawMarkersData):
3226         (WebCore::RenderPath::drawMarkersIfNeeded):
3227         * rendering/RenderSVGContainer.cpp:
3228         (WebCore::RenderSVGContainer::paint):
3229         * rendering/RenderSVGImage.cpp:
3230         (WebCore::RenderSVGImage::paint):
3231         * rendering/SVGInlineFlowBox.cpp:
3232         (WebCore::paintSVGInlineFlow):
3233
3234 2006-10-30  John Sullivan  <sullivan@apple.com>
3235
3236         Reviewed by Brady
3237
3238         - minor cleanup to make future patches clearer
3239
3240         * bridge/mac/FrameMac.mm:
3241         (WebCore::FrameMac::advanceToNextMisspelling):
3242         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
3243         with "continue" to better match structure of similar code in markMisspellings; a few
3244         other style tweaks.
3245
3246         (WebCore::FrameMac::markMisspellings):
3247         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
3248         a block just after a break and outdented accordingly.
3249
3250 2006-10-30  John Sullivan  <sullivan@apple.com>
3251
3252         Reviewed by Geoff Garen
3253
3254         WebCore part of change to push the code that updates the spelling panel
3255         into WebCore, in preparation for some grammar-checking stuff.
3256
3257         * bridge/mac/FrameMac.h:
3258         * bridge/mac/FrameMac.mm:
3259         (WebCore::FrameMac::advanceToNextMisspelling):
3260         no more return value for this method, and update the spelling panel with
3261         the misspelled word here rather than in the WebKit callers.
3262
3263 2006-10-30  Oliver Hunt  <oliver@apple.com>
3264
3265         Reviewed by Anders.
3266
3267         Roll out last patch
3268
3269         * CMakeLists.txt:
3270         * ChangeLog:
3271         * WebCore.xcodeproj/project.pbxproj:
3272         * graphics/svg/SVGResource.cpp:
3273         * graphics/svg/SVGResourceClipper.cpp:
3274         * graphics/svg/SVGResourceClipper.h:
3275         * graphics/svg/SVGResourceImage.h:
3276         * graphics/svg/SVGResourceListener.h:
3277         * graphics/svg/SVGResourceMarker.cpp:
3278         * graphics/svg/SVGResourceMarker.h:
3279         * graphics/svg/SVGResourceMasker.cpp:
3280         * graphics/svg/SVGResourceMasker.h:
3281         * kcanvas/KCanvasClipper.cpp: Added.
3282         (WebCore::operator<<):
3283         (WebCore::KCanvasClipper::KCanvasClipper):
3284         (WebCore::KCanvasClipper::~KCanvasClipper):
3285         (WebCore::KCanvasClipper::resetClipData):
3286         (WebCore::KCanvasClipper::addClipData):
3287         (WebCore::KCanvasClipper::clipData):
3288         (WebCore::KCanvasClipper::externalRepresentation):
3289         (WebCore::getClipperById):
3290         * kcanvas/KCanvasClipper.h: Added.
3291         (WebCore::KCClipData::windRule):
3292         (WebCore::KCClipDataList::KCClipDataList):
3293         (WebCore::KCClipDataList::addPath):
3294         (WebCore::KCanvasClipper::isClipper):
3295         * kcanvas/KCanvasFilters.cpp:
3296         (WebCore::getFilterById):
3297         * kcanvas/KCanvasFilters.h:
3298         * kcanvas/KCanvasImage.h: Added.
3299         (WebCore::KCanvasImage::KCanvasImage):
3300         (WebCore::KCanvasImage::~KCanvasImage):
3301         * kcanvas/KCanvasMarker.cpp: Added.
3302         (WebCore::KCanvasMarker::KCanvasMarker):
3303         (WebCore::KCanvasMarker::~KCanvasMarker):
3304         (WebCore::KCanvasMarker::setMarker):
3305         (WebCore::KCanvasMarker::setRef):
3306         (WebCore::KCanvasMarker::refX):
3307         (WebCore::KCanvasMarker::refY):
3308         (WebCore::KCanvasMarker::setAngle):
3309         (WebCore::KCanvasMarker::angle):
3310         (WebCore::KCanvasMarker::setAutoAngle):
3311         (WebCore::KCanvasMarker::setUseStrokeWidth):
3312         (WebCore::KCanvasMarker::useStrokeWidth):
3313         (WebCore::KCanvasMarker::draw):
3314         (WebCore::KCanvasMarker::externalRepresentation):
3315         (WebCore::getMarkerById):
3316         * kcanvas/KCanvasMarker.h: Added.
3317         (WebCore::KCanvasMarker::isMarker):
3318         * kcanvas/KCanvasMasker.cpp: Added.
3319         (WebCore::KCanvasMasker::KCanvasMasker):
3320         (WebCore::KCanvasMasker::~KCanvasMasker):
3321         (WebCore::KCanvasMasker::setMask):
3322         (WebCore::KCanvasMasker::externalRepresentation):
3323         (WebCore::getMaskerById):
3324         * kcanvas/KCanvasMasker.h: Added.
3325         (WebCore::KCanvasMasker::isMasker):
3326         (WebCore::KCanvasMasker::mask):
3327         * kcanvas/KCanvasResource.cpp: Added.
3328         (WebCore::operator<<):
3329         (WebCore::KCanvasResource::KCanvasResource):
3330         (WebCore::KCanvasResource::~KCanvasResource):
3331         (WebCore::KCanvasResource::addClient):
3332         (WebCore::KCanvasResource::clients):
3333         (WebCore::KCanvasResource::invalidate):
3334         (WebCore::KCanvasResource::idInRegistry):
3335         (WebCore::KCanvasResource::setIdInRegistry):
3336         (WebCore::KCanvasResource::externalRepresentation):
3337         (WebCore::getResourceById):
3338         (WebCore::getPaintServerById):
3339         * kcanvas/KCanvasResource.h:
3340         (WebCore::):
3341         (WebCore::KCanvasResource::isPaintServer):
3342         (WebCore::KCanvasResource::isFilter):
3343         (WebCore::KCanvasResource::isClipper):
3344         (WebCore::KCanvasResource::isMarker):
3345         (WebCore::KCanvasResource::isMasker):
3346         * kcanvas/KCanvasResourceListener.h: Added.
3347         (KCanvasResourceListener::KCanvasResourceListener):
3348         (KCanvasResourceListener::~KCanvasResourceListener):
3349         * kcanvas/KCanvasTreeDebug.cpp:
3350         (WebCore::writeRenderResources):
3351         * kcanvas/device/KRenderingDevice.h:
3352         * kcanvas/device/KRenderingPaintServer.h:
3353         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
3354         (WebCore::KRenderingPaintServer::idInRegistry):
3355         (WebCore::KRenderingPaintServer::setIdInRegistry):
3356         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3357         (WebCore::KRenderingPaintServerGradient::listener):
3358         (WebCore::KRenderingPaintServerGradient::setListener):
3359         * kcanvas/device/KRenderingPaintServerGradient.h:
3360         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3361         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
3362         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
3363         (WebCore::KRenderingPaintServerPattern::tile):
3364         (WebCore::KRenderingPaintServerPattern::setTile):
3365         (WebCore::KRenderingPaintServerPattern::listener):
3366         (WebCore::KRenderingPaintServerPattern::setListener):
3367         * kcanvas/device/KRenderingPaintServerPattern.h:
3368         * kcanvas/device/KRenderingPaintServerSolid.h:
3369         * kcanvas/device/qt/KCanvasClipperQt.cpp:
3370         (WebCore::KCanvasClipperQt::applyClip):
3371         * kcanvas/device/qt/KCanvasClipperQt.h:
3372         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
3373         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
3374         (WebCore::KRenderingDeviceQt::contextForImage):
3375         (WebCore::KRenderingDeviceQt::createResource):
3376         (WebCore::KRenderingDeviceQt::createPaintServer):
3377         * kcanvas/device/qt/KRenderingDeviceQt.h:
3378         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
3379         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
3380         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
3381         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
3382         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3383         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
3384         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
3385         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
3386         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
3387         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
3388         (WebCore::applyLuminanceToAlphaFilter):
3389         (WebCore::applyExpandAlphatoGrayscaleFilter):
3390         (WebCore::transformImageIntoGrayscaleMask):
3391         (WebCore::KCanvasMaskerQuartz::applyMask):
3392         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
3393         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
3394         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
3395         (WebCore::KCanvasImageQuartz::init):
3396         (WebCore::KCanvasImageQuartz::size):
3397         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
3398         (WebCore::KCanvasClipperQuartz::applyClip):
3399         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
3400         (WebCore::KCanvasImageQuartz::cgLayer):
3401         (WebCore::KCanvasImageQuartz::setCGLayer):
3402         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
3403         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
3404         (WebCore::KRenderingDeviceQuartz::contextForImage):
3405         (WebCore::KRenderingDeviceQuartz::createPaintServer):
3406         (WebCore::KRenderingDeviceQuartz::createResource):
3407         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3408         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
3409         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
3410         (WebCore::KRenderingPaintServerGradientQuartz::setup):
3411         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
3412         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
3413         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3414         (WebCore::patternCallback):
3415         (WebCore::KRenderingPaintServerPatternQuartz::setup):
3416         * kcanvas/device/quartz/QuartzSupport.mm:
3417         * ksvg2/misc/KCanvasRenderingStyle.cpp:
3418         (WebCore::sharedSolidPaintServer):
3419         * ksvg2/svg/SVGClipPathElement.cpp:
3420         (WebCore::SVGClipPathElement::SVGClipPathElement):
3421         (WebCore::SVGClipPathElement::~SVGClipPathElement):
3422         (WebCore::SVGClipPathElement::canvasResource):
3423         * ksvg2/svg/SVGClipPathElement.h:
3424         * ksvg2/svg/SVGFEImageElement.cpp:
3425         * ksvg2/svg/SVGFilterElement.cpp:
3426         (WebCore::SVGFilterElement::SVGFilterElement):
3427         (WebCore::SVGFilterElement::~SVGFilterElement):
3428         (WebCore::SVGFilterElement::canvasResource):
3429         * ksvg2/svg/SVGFilterElement.h:
3430         * ksvg2/svg/SVGGradientElement.cpp:
3431         (WebCore::SVGGradientElement::SVGGradientElement):
3432         (WebCore::SVGGradientElement::~SVGGradientElement):
3433         (WebCore::SVGGradientElement::canvasResource):
3434         (WebCore::SVGGradientElement::resourceNotification):
3435         * ksvg2/svg/SVGGradientElement.h:
3436         * ksvg2/svg/SVGImageElement.cpp:
3437         * ksvg2/svg/SVGLinearGradientElement.cpp:
3438         (WebCore::SVGLinearGradientElement::buildGradient):
3439         * ksvg2/svg/SVGLinearGradientElement.h:
3440         * ksvg2/svg/SVGMarkerElement.cpp:
3441         (WebCore::SVGMarkerElement::SVGMarkerElement):
3442         (WebCore::SVGMarkerElement::~SVGMarkerElement):
3443         (WebCore::SVGMarkerElement::canvasResource):
3444         * ksvg2/svg/SVGMarkerElement.h:
3445         * ksvg2/svg/SVGMaskElement.cpp:
3446         (WebCore::SVGMaskElement::SVGMaskElement):
3447         (WebCore::SVGMaskElement::~SVGMaskElement):
3448         (WebCore::SVGMaskElement::drawMaskerContent):
3449         (WebCore::SVGMaskElement::canvasResource):
3450         * ksvg2/svg/SVGMaskElement.h:
3451         * ksvg2/svg/SVGPatternElement.cpp:
3452         (WebCore::SVGPatternElement::SVGPatternElement):
3453         (WebCore::SVGPatternElement::~SVGPatternElement):
3454         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
3455         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
3456         (WebCore::SVGPatternElement::canvasResource):
3457         * ksvg2/svg/SVGPatternElement.h:
3458         * ksvg2/svg/SVGRadialGradientElement.cpp:
3459         (WebCore::SVGRadialGradientElement::buildGradient):
3460         * ksvg2/svg/SVGRadialGradientElement.h:
3461         * ksvg2/svg/SVGStyledElement.h:
3462         (WebCore::SVGStyledElement::canvasResource):
3463         * platform/GraphicsContext.cpp: Added.
3464         (WebCore::GraphicsContextState::GraphicsContextState):
3465         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
3466         (WebCore::GraphicsContext::createGraphicsContextPrivate):
3467         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
3468         (WebCore::GraphicsContext::save):
3469         (WebCore::GraphicsContext::restore):
3470         (WebCore::GraphicsContext::font):
3471         (WebCore::GraphicsContext::setFont):
3472         (WebCore::GraphicsContext::pen):
3473         (WebCore::GraphicsContext::setPen):
3474         (WebCore::GraphicsContext::setFillColor):
3475         (WebCore::GraphicsContext::fillColor):
3476         (WebCore::GraphicsContext::updatingControlTints):
3477         (WebCore::GraphicsContext::setUpdatingControlTints):
3478         (WebCore::GraphicsContext::setPaintingDisabled):
3479         (WebCore::GraphicsContext::paintingDisabled):
3480         (WebCore::GraphicsContext::drawImage):
3481         (WebCore::GraphicsContext::drawText):
3482         (WebCore::GraphicsContext::drawHighlightForText):
3483         (WebCore::GraphicsContext::initFocusRing):
3484         (WebCore::GraphicsContext::clearFocusRing):
3485         (WebCore::GraphicsContext::focusRingBoundingRect):
3486         (WebCore::GraphicsContext::addFocusRingRect):
3487         (WebCore::GraphicsContext::focusRingWidth):
3488         (WebCore::GraphicsContext::focusRingOffset):
3489         (WebCore::GraphicsContext::focusRingRects):
3490         (WebCore::GraphicsContext::drawTiledImage):
3491         * platform/GraphicsContext.h: Added.
3492         * platform/GraphicsTypes.cpp: Added.
3493         (WebCore::):
3494         (WebCore::parseCompositeOperator):
3495         (WebCore::compositeOperatorName):
3496         (WebCore::parseLineCap):
3497         (WebCore::lineCapName):
3498         (WebCore::parseLineJoin):
3499         (WebCore::lineJoinName):
3500         * platform/GraphicsTypes.h: Added.
3501         (WebCore::):
3502         * platform/graphics/GraphicsContext.cpp:
3503         * platform/graphics/GraphicsContext.h:
3504         * platform/graphics/GraphicsTypes.cpp:
3505         * platform/graphics/GraphicsTypes.h:
3506         * platform/qt/GraphicsContextQt.cpp:
3507         * rendering/RenderPath.cpp:
3508         (WebCore::RenderPath::paint):
3509         (WebCore::DrawMarkersData::DrawMarkersData):
3510         (WebCore::RenderPath::drawMarkersIfNeeded):
3511         * rendering/RenderSVGContainer.cpp:
3512         (WebCore::RenderSVGContainer::paint):
3513         * rendering/RenderSVGImage.cpp:
3514         (WebCore::RenderSVGImage::paint):
3515         * rendering/SVGInlineFlowBox.cpp:
3516         (WebCore::paintSVGInlineFlow):
3517
3518 2006-10-30  John Sullivan  <sullivan@apple.com>
3519
3520         Reviewed by Geoff Garen.
3521
3522         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
3523         grammar-related method.
3524
3525         * bridge/EditorClient.h:
3526         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
3527         isGrammarCheckingEnabled()
3528
3529         * bridge/mac/WebCoreFrameBridge.h:
3530         removed bridge equivalents
3531
3532         * bridge/mac/FrameMac.mm:
3533         (WebCore::FrameMac::advanceToNextMisspelling):
3534         convert bridge-using code to editor()->client()-using code
3535         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
3536         ditto
3537         (WebCore::FrameMac::markMisspellings):
3538         ditto
3539         (WebCore::FrameMac::respondToChangedSelection):
3540      &nb