LayoutTests:
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-23  Justin Garcia  <justin.garcia@apple.com>
2
3         Reviewed by mjs
4
5         <http://bugs.webkit.org/show_bug.cgi?id=11334>
6         Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons
7
8         * WebCore.xcodeproj/project.pbxproj:
9         * editing/Editor.cpp:
10         (WebCore::Editor::selectionUnorderedListState): Added.
11         (WebCore::Editor::selectionOrderedListState): Added.
12         * editing/Editor.h:
13         * editing/JSEditor.cpp:
14         * page/Frame.cpp:
15         * page/Frame.h:
16
17 2006-10-23  John Sullivan  <sullivan@apple.com>
18
19         Reviewed by Tim H
20
21         * WebCore.xcodeproj/project.pbxproj:
22         Include WebCorePrefix.h in Xcode project for convenience and for consistency with WebKit
23
24 2006-10-23  Sam Weinig  <sam.weinig@gmail.com>
25
26         Reviewed by Tim H.
27
28         Patch for http://bugs.webkit.org/show_bug.cgi?id=11291
29         PNG as cursor image format instead of TIFF
30
31         Original patch by Lars Naesbye Christensen (larsnaesbye@stud.ku.dk)
32
33         - Convert cursor images from TIFF to PNG.
34
35         * Resources/eastResizeCursor.png: Added.
36         * Resources/eastResizeCursor.tiff: Removed.
37         * Resources/eastWestResizeCursor.png: Added.
38         * Resources/eastWestResizeCursor.tiff: Removed.
39         * Resources/helpCursor.png: Added.
40         * Resources/helpCursor.tiff: Removed.
41         * Resources/linkCursor.png: Added.
42         * Resources/linkCursor.tiff: Removed.
43         * Resources/moveCursor.png: Added.
44         * Resources/moveCursor.tiff: Removed.
45         * Resources/northEastResizeCursor.png: Added.
46         * Resources/northEastResizeCursor.tiff: Removed.
47         * Resources/northEastSouthWestResizeCursor.png: Added.
48         * Resources/northEastSouthWestResizeCursor.tiff: Removed.
49         * Resources/northResizeCursor.png: Added.
50         * Resources/northResizeCursor.tiff: Removed.
51         * Resources/northSouthResizeCursor.png: Added.
52         * Resources/northSouthResizeCursor.tiff: Removed.
53         * Resources/northWestResizeCursor.png: Added.
54         * Resources/northWestResizeCursor.tiff: Removed.
55         * Resources/northWestSouthEastResizeCursor.png: Added.
56         * Resources/northWestSouthEastResizeCursor.tiff: Removed.
57         * Resources/southEastResizeCursor.png: Added.
58         * Resources/southEastResizeCursor.tiff: Removed.
59         * Resources/southResizeCursor.png: Added.
60         * Resources/southResizeCursor.tiff: Removed.
61         * Resources/southWestResizeCursor.png: Added.
62         * Resources/southWestResizeCursor.tiff: Removed.
63         * Resources/waitCursor.png: Added.
64         * Resources/waitCursor.tiff: Removed.
65         * Resources/westResizeCursor.png: Added.
66         * Resources/westResizeCursor.tiff: Removed.
67         * WebCore.xcodeproj/project.pbxproj:
68         * platform/mac/CursorMac.mm:
69         (WebCore::leakNamedCursor):
70
71 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
72
73         Not reviewed.
74
75         - fixed build from last change.
76
77         * bridge/mac/FrameMac.h:
78         * bridge/mac/FrameMac.mm:
79         (WebCore::FrameMac::loadRequest):
80         (WebCore::FrameMac::openURL):
81
82 2006-10-23  Adam Roben  <aroben@apple.com>
83
84         Reviewed by Adele.
85
86         Move border-radius rule for <select>s into RenderThemeMac, as this is
87         really a platform-specific look.
88
89         * css/html4.css:
90         * rendering/RenderThemeMac.mm:
91         (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
92
93 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
94
95         Reviewed by Brady.
96
97         - moved things around so loadURL:... is only called from one place
98
99         * bridge/mac/FrameMac.h:
100         * bridge/mac/FrameMac.mm:
101         (WebCore::FrameMac::frameDetached):
102         (WebCore::FrameMac::loadRequest):
103         (WebCore::FrameMac::submitForm):
104         (WebCore::FrameMac::openURL):
105         (WebCore::FrameMac::openURLRequest):
106         (WebCore::FrameMac::urlSelected):
107
108 2006-10-23  Justin Garcia  <justin.garcia@apple.com>
109
110         Reviewed by john
111         
112         <http://bugs.webkit.org/show_bug.cgi?id=11333>
113         Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document
114         
115         Added special cases in InsertLineBreakCommand for inserting before
116         and after tables and horizontal rules.  Also, perform InsertLineBreak
117         instead of InsertParagraphSeparator at these positions.
118
119         * editing/InsertLineBreakCommand.cpp:
120         (WebCore::InsertLineBreakCommand::doApply):  Use the canonical form
121         of the caret position when we check for the new special cases because 
122         we know that we canonicalize VisiblePositions to those positions.
123         Added code to handle inserting before/after tables and horizontal rules.  
124         Fixed a bug when inserting at the end of a block (it checked for a collapse
125         of the inserted br by looking for the absence of a br, but the line break 
126         might have been a '\n' in white-space:pre text).  Removed unused LOGs.
127         * editing/InsertParagraphSeparatorCommand.cpp:
128         (WebCore::InsertParagraphSeparatorCommand::doApply): Perform an 
129         InsertLineBreakCommand when before/after a table or a horizontal rule
130         so that we don't have to maintain two pieces of special case code.
131         Migrated to enclosingBlock.
132         * editing/htmlediting.cpp: Added a FIXME.
133         * editing/visible_units.cpp:
134         (WebCore::startOfParagraph): Added a workaround for 8622.
135         
136 2006-10-23  Adam Roben  <aroben@apple.com>
137
138         Reviewed by Adele.
139
140         Make popups a little more flexible.
141
142         * platform/PopupMenu.h:
143
144 2006-10-23  Sam Weinig  <sam.weinig@gmail.com>
145
146         Reviewed by Tim H.
147
148         Cleanup CodeGeneratorJS.pm
149
150         * bindings/scripts/CodeGeneratorJS.pm:
151
152 2006-10-23  Adam Roben  <aroben@apple.com>
153
154         Rubberstamped by Brady.
155
156         * loader/icon/IconLoader.h: Changed angle-brackets to quotes for
157         #include of ResourceLoader.h, since it's a WebCore header.
158
159 2006-10-23  Darin Adler  <darin@apple.com>
160
161         - fixed mistake that was preventing any loading from happening
162
163         * platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData):
164         Changed parameter back to int. Perhaps we want to move to "long long" consistently, but
165         I'll leave that up to Maciej.
166
167 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
168
169         Reviewed by Anders.
170
171         - start converting ResourceLoaderClient to new API
172
173         Did the bits I could do without introducing new types:
174         
175         - renamed receivedData to didReceiveData
176         - renamed version of receivedAllData that doesn't pass any data to didFinishLoading
177
178         * bridge/mac/WebCoreResourceLoaderImp.mm:
179         (-[WebCoreResourceLoaderImp addData:]):
180         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
181         * loader/icon/IconLoader.cpp:
182         (IconLoader::didReceiveData):
183         (IconLoader::didFinishLoading):
184         * loader/icon/IconLoader.h:
185         * loader/loader.cpp:
186         (WebCore::Loader::didReceiveData):
187         * loader/loader.h:
188         * platform/gdk/FrameGdk.cpp:
189         (WebCore::FrameGdkClientDefault::didReceiveData):
190         * platform/gdk/FrameGdk.h:
191         * platform/network/ResourceLoaderClient.h:
192         (WebCore::ResourceLoaderClient::didReceiveData):
193         (WebCore::ResourceLoaderClient::didFinishLoading):
194         (WebCore::ResourceLoaderClient::receivedResponse):
195         * platform/network/cf/ResourceLoaderCFNet.cpp:
196         (WebCore::didReceiveData):
197         (WebCore::didFinishLoading):
198         (WebCore::didFail):
199         (WebCore::ResourceLoader::cancel):
200         * platform/network/gdk/ResourceLoaderManager.cpp:
201         (WebCore::writeCallback):
202         (WebCore::ResourceLoaderManager::downloadTimerCallback):
203         (WebCore::ResourceLoaderManager::remove):
204         * platform/network/qt/ResourceLoaderManager.cpp:
205         (WebCore::ResourceLoaderManager::slotData):
206         (WebCore::ResourceLoaderManager::remove):
207         * platform/network/win/ResourceLoaderWin.cpp:
208         (WebCore::ResourceLoader::onRequestComplete):
209         (WebCore::ResourceLoader::fileLoadTimer):
210         (WebCore::ResourceLoader::cancel):
211         * platform/qt/FrameQtClient.cpp:
212         (WebCore::FrameQtClientDefault::didReceiveData):
213         * platform/qt/FrameQtClient.h:
214         * xml/xmlhttprequest.cpp:
215         (WebCore::XMLHttpRequest::processSyncLoadResults):
216         (WebCore::XMLHttpRequest::didFinishLoading):
217         (WebCore::XMLHttpRequest::didReceiveData):
218         * xml/xmlhttprequest.h:
219
220 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
221
222         Rubber stamped by Anders.
223
224         - marked files executable
225         
226         * ksvg2/scripts/csscssmakeprops:
227         * ksvg2/scripts/csscssmakevalues:
228
229 2006-10-22  Maciej Stachowiak  <mjs@apple.com>
230
231         Reviewed by Anders.
232
233         - moved ResourceLoader and related files to platform/network
234         in preparation for building out this API.
235
236         I tried to update all the build systems but I'm not sure they are
237         all fixed properly
238
239         * page/ResourceRequest.h: Moved to platform/network.
240         * platform/ResourceLoader.cpp: Moved to platform/network.
241         * platform/ResourceLoader.h: Moved to platform/network.
242         * platform/ResourceLoaderClient.h: Moved to platform/network.
243         * platform/ResourceLoaderInternal.h: Moved to platform/network.
244         * platform/cf/ResourceLoaderCFNet.cpp: Moved to platform/network/cf.
245         * platform/gdk/ResourceLoaderCurl.cpp: Moved to platform/network/gdk.
246         * platform/gdk/ResourceLoaderManager.cpp: Moved to platform/network/gdk.
247         * platform/gdk/ResourceLoaderManager.h: Moved to platform/network/gdk.
248         * platform/mac/ResourceLoaderMac.mm: Moved to platform/network/mac.
249         * platform/qt/ResourceLoaderManager.cpp: Moved to platform/network/qt.
250         * platform/qt/ResourceLoaderManager.h: Moved to platform/network/qt.
251         * platform/qt/ResourceLoaderQt.cpp: Moved to platform/network/qt.
252         * platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win.
253         * platform/win/ResourceLoaderWin.h: Moved to platform/network/win.
254         * webcore-base.bkl: Updated for new paths.
255         * CMakeLists.txt: ditto
256         * Projects/gdk/webcore-gdk.bkl: ditto
257         * WebCore.xcodeproj/project.pbxproj: ditto
258         * WebCoreSources.bkl: ditto
259
260 2006-10-22  Sam Weinig  <sam.weinig@gmail.com>
261
262         Reviewed by Tim H.
263
264         - Add DOMHTMLFormElementPrivate.h to the project.
265
266         * WebCore.xcodeproj/project.pbxproj:
267         * bindings/objc/DOMPrivate.h:
268
269 2006-10-22  Darin Adler  <darin@apple.com>
270
271         - another try at fixing Qt
272
273         * CMakeLists.txt: Added DeleteButton.cpp and DeleteButtonController.cpp.
274
275         - and fix a couple warnings while I'm at it
276
277         * platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::setRGBA):
278         Don't do unsigned *= float.
279
280         * rendering/break_lines.cpp: (WebCore::nextBreakablePosition): Move unused variable
281         inside #if so it's consistent.
282
283 2006-10-21  Darin Adler  <darin@apple.com>
284
285         - fix the Qt build
286
287         * platform/qt/EditorClientQt.cpp:
288         (WebCore::EditorClientQt::shouldShowDeleteInterface):
289         * platform/qt/EditorClientQt.h:
290         * platform/qt/FrameQt.cpp:
291
292 2006-10-21  Darin Adler  <darin@apple.com>
293
294         Reviewed by Adele.
295
296         - convert WebLoader and its 3 subclasses to C++ (this time with a leak fixed)
297
298         Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
299         there's currently another class with that name).
300         Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
301         Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
302         Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
303
304         Converted the classes to C++ and added Objective-C delegates to forward from
305         API that still requires Objective-C.
306
307         Did not yet rename the source files.
308
309         * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader
310         classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader
311         classes.
312
313         * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
314
315         * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
316
317         * loader/mac/WebLoader.h:
318         * loader/mac/WebLoader.mm:
319         * loader/mac/WebMainResourceLoader.h:
320         * loader/mac/WebMainResourceLoader.mm:
321         * loader/mac/WebNetscapePlugInStreamLoader.h:
322         * loader/mac/WebNetscapePlugInStreamLoader.mm:
323         * loader/mac/WebSubresourceLoader.h:
324         * loader/mac/WebSubresourceLoader.mm:
325         Translate to C++.
326
327         * bridge/mac/WebCoreFrameBridge.mm:
328         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
329         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
330         * loader/mac/WebFrameLoader.h:
331         * loader/mac/WebFrameLoader.mm:
332         (isCaseInsensitiveEqual):
333         (isBackForwardLoadType):
334         (-[WebFrameLoader dealloc]):
335         (-[WebFrameLoader addPlugInStreamLoader:]):
336         (-[WebFrameLoader removePlugInStreamLoader:]):
337         (-[WebFrameLoader setDefersCallbacks:]):
338         (-[WebFrameLoader stopLoadingPlugIns]):
339         (-[WebFrameLoader isLoadingMainResource]):
340         (-[WebFrameLoader isLoadingSubresources]):
341         (-[WebFrameLoader isLoadingPlugIns]):
342         (-[WebFrameLoader stopLoadingSubresources]):
343         (-[WebFrameLoader addSubresourceLoader:]):
344         (-[WebFrameLoader removeSubresourceLoader:]):
345         (-[WebFrameLoader mainResourceData]):
346         (-[WebFrameLoader releaseMainResourceLoader]):
347         (-[WebFrameLoader cancelMainResourceLoad]):
348         (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
349         (-[WebFrameLoader stopLoadingWithError:]):
350         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
351         (-[WebFrameLoader archiveLoadPendingForLoader:]):
352         (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
353         * loader/mac/WebFrameLoaderClient.h:
354         Call the new C++ API.
355
356 2006-10-21  Adam Roben  <aroben@apple.com>
357
358         Reviewed by Anders.
359
360         Popup tweaks.
361
362         * platform/PopupMenu.h:
363
364 2006-10-21  Darin Adler  <darin@apple.com>
365
366         * editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableTable):
367         Oops, edited this before landing it and introduced a null-deref! This fixes it.
368
369 2006-10-21  Darin Adler  <darin@apple.com>
370
371         Reviewed by Anders.
372
373         - fix http://bugs.webkit.org/show_bug.cgi?id=11379
374           assertion failure seen in editing tests (in new DeleteButtonController)
375
376         I cleaned up the relationship between the Frame, Editor, EditorClient, and
377         DeleteButtonController a bit while also making the simple change to fix the
378         assertion failure.
379
380         * bridge/mac/FrameMac.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
381         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
382
383         * page/Frame.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
384         * page/Frame.cpp:
385         (WebCore::Frame::Frame): Ditto.
386         (WebCore::Frame::appliedEditing): Removed unneeded parameter to the respondToChangedContents
387         function, and moved it to Editor rather than right on the DeleteButtonController.
388         (WebCore::Frame::unappliedEditing): Ditto.
389         (WebCore::Frame::reappliedEditing): Ditto.
390         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): More of the same.
391
392         * editing/DeleteButtonController.h:
393         * editing/DeleteButtonController.cpp:
394         (WebCore::DeleteButtonController::DeleteButtonController): Replaced Editor* with a Frame*.
395         The general pattern is that we always use the Frame* as the frame identifier. See FrameTree,
396         for example.
397         (WebCore::enclosingDeletableTable): Added. Helper function used by the respondToChangedSelection
398         function. Includes an additional check for whether the container is contentEditable, which
399         was missing from the old version. This prevents the assertion failure. Also added a check that
400         the table itself is editable.
401         (WebCore::DeleteButtonController::respondToChangedSelection): Rewrote to use the helper.
402         (WebCore::DeleteButtonController::respondToChangedContents): Removed the unnecessary
403         selection parameter. No need to pass in the state of the frame since we can get it if we need it.
404         (WebCore::DeleteButtonController::show): Updated to use frame pointer rather than editor pointer.
405
406         * editing/Editor.cpp: Fixed formatting. Even the temporary placeholder functions should be
407         formatted on multiple lines as usual.
408         (WebCore::Editor::respondToChangedSelection): Added. Forwards to the delete button controller.
409         (WebCore::Editor::respondToChangedContents): Ditto.
410         (WebCore::Editor::Editor): Changed EditorClient parameter to a PassRefPtr since we take ownership.
411
412         * editing/Editor.h: Changed the DeleteButtonController to use an OwnPtr instead of being
413         defined inline to decouple so that we don't have to include DeleteButtonController.h. That way
414         changes to DeleteButtonController.h cause very little to recompile.
415
416         * editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
417         Updated to call the editor instead of the delete button controller for the selection change.
418
419 2006-10-21  Anders Carlsson  <acarlsson@apple.com>
420
421         Reviewed by Darin.
422
423         * loader/mac/LoaderFunctionsMac.mm:
424         (WebCore::ServeSynchronousRequest):
425         * platform/mac/ResourceLoaderMac.mm:
426         (WebCore::ResourceLoader::start):
427         Don't leak the header dictionary.
428
429 2006-10-21  Darin Adler  <darin@apple.com>
430
431         Reviewed by Adam.
432
433         - http://bugs.webkit.org/show_bug.cgi?id=11376
434           build scripts should invoke make with "-j" option for multiple processors
435
436         * WebCore.xcodeproj/project.pbxproj: Pass -j `sysctl -n hw.ncpu` to make.
437
438 2006-10-21  Timothy Hatcher  <timothy@apple.com>
439
440         Reviewed by Geoff.
441
442         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
443
444         Initial implementaltion of table deletion user interface:
445         * Interface shows up on the nearest table containing the entire selection.
446         * Shows a Dashboard style close button in the top left corner.
447         * Shows a 60% opaque black outline around the table.
448         * Adds a new EditorClient function shouldShowDeleteInterface.
449
450         Also adds a new constructor CachedImage and setter functions on
451         HTMLImageElement and HTMLImageLoader allowing an Image object to be set
452         and image element in the page. This change also paves the way to allow an
453         NSImage setter on DOMHTMLImageElement. 
454
455         * Resources/deleteButton.tiff: Added.
456         * Resources/deleteButtonPressed.tiff: Added.
457         * WebCore.xcodeproj/project.pbxproj:
458         * bridge/EditorClient.h:
459         * editing/DeleteButton.cpp: Added.
460         (WebCore::DeleteButton::DeleteButton):
461         (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click
462         * editing/DeleteButton.h: Added.
463         * editing/DeleteButtonController.cpp: Added.
464         (WebCore::DeleteButtonController::DeleteButtonController):
465         (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide
466         (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle
467         (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size
468         (WebCore::DeleteButtonController::show): shows the interface on a new element
469         (WebCore::DeleteButtonController::hide): hides the existing interface
470         (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element
471         * editing/DeleteButtonController.h: Added.
472         (WebCore::DeleteButtonController::target): getter for the current target
473         * editing/Editor.cpp:
474         (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function
475         (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client
476         (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client
477         * editing/Editor.h:
478         (WebCore::Editor::frame): new getter
479         (WebCore::Editor::deleteButtonController): ditto
480         * editing/SelectionController.cpp:
481         (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection
482         * html/HTMLImageElement.h:
483         (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage
484         * html/HTMLImageLoader.cpp:
485         (WebCore::HTMLImageLoader::setImage): ditto
486         * html/HTMLImageLoader.h:
487         * loader/CachedImage.cpp:
488         (WebCore::CachedImage::CachedImage): new constructor that takes an Image
489         * loader/CachedImage.h: ditto
490         * page/Frame.cpp:
491         (WebCore::Frame::selectionController): cleanup coding style
492         (WebCore::Frame::editor): ditto
493         (WebCore::Frame::command): ditto
494         (WebCore::Frame::appliedEditing): tell the delete button outline to update
495         (WebCore::Frame::unappliedEditing): ditto
496         (WebCore::Frame::reappliedEditing): ditto
497         * rendering/RenderTable.cpp:
498         (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed
499
500 2006-10-21  Sam Weinig  <sam.weinig@gmail.com>
501
502         Reviewed by Tim H.
503
504         Cleanup bindings generation a little through re-factoring 
505         and general style cleanup.
506
507         * bindings/scripts/CodeGenerator.pm:
508         * bindings/scripts/CodeGeneratorJS.pm:
509         * bindings/scripts/CodeGeneratorObjC.pm:
510
511 2006-10-21  Nikolas Zimmermann  <zimmermann@kde.org>
512
513         Reviewed by Mitz.
514
515         Fix crashes on Qt/Linux. Offer a default EditorClient and pass it down to Frame ctor.
516
517         * CMakeLists.txt:
518         * platform/qt/EditorClientQt.cpp: Added.
519         (WebCore::EditorClientQt::shouldDeleteRange):
520         * platform/qt/EditorClientQt.h: Added.
521         (WebCore::EditorClientQt::~EditorClientQt):
522         * platform/qt/FrameQt.cpp:
523         (WebCore::FrameQt::FrameQt):
524         * platform/qt/FrameQt.h:
525
526 2006-10-21  Sam Weinig  <sam.weinig@gmail.com>
527
528         Reviewed by Tim H.
529
530         Fix for http://bugs.webkit.org/show_bug.cgi?id=11372
531         Auto-generate a few more Objective-C DOM methods.
532
533         - Auto-generate getMatchedCSSRules and getComputedStyle methods.
534
535         * bindings/objc/DOMCSS.h:
536         * bindings/objc/DOMCSS.mm:
537         * bindings/objc/DOMExtensions.h:
538         * bindings/objc/PublicDOMInterfaces.h:
539         * bindings/scripts/CodeGeneratorObjC.pm:
540         * dom/Document.idl:
541         * page/DOMWindow.idl:
542
543 2006-10-21  Nikolas Zimmermann  <zimmermann@kde.org>
544
545         Reviewed by aliu, landed by aliu.
546
547         Fix Qt/Linux build.
548
549         * CMakeLists.txt:
550         * platform/qt/FrameQt.cpp:
551         (WebCore::FrameQt::FrameQt):
552         * platform/qt/SoundQt.cpp: Added.
553         (WebCore::systemBeep):
554
555 2006-10-21  Nikolas Zimmermann  <zimmermann@kde.org>
556
557         Reviewed by Mitz, landed by ap.
558
559         Fix obscure crashes in RenderTableSection on Rob's musicdb file.
560         The problem was a missing layout() call on the frame view.
561         Thanks go to Mitz Pettel for the initial hint!
562
563         * platform/qt/ScrollViewCanvasQt.cpp:
564         (WebCore::ScrollViewCanvasQt::paintEvent):
565
566 2006-10-20  Steve Falkenburg  <sfalken@apple.com>
567
568         Reviewed by Anders.
569
570         Send User-Agent on requests.
571         Send custom request headers properly.
572
573         * platform/cf/ResourceLoaderCFNet.cpp:
574         (WebCore::addHeadersFromHashMap): Switch over to HashMap iteration from string parsing
575         (WebCore::ResourceLoader::start): Send proper User-Agent, change call to add headers
576
577 2006-10-20  Timothy Hatcher  <timothy@apple.com>
578
579         Reviewed by Hyatt.
580
581         Fix some bad formatting.
582
583         * css/cssstyleselector.cpp:
584         (WebCore::CSSStyleSelector::checkOneSelector):
585
586 2006-10-20  Darin Adler  <darin@apple.com>
587
588         Reviewed by John.
589
590         - fixed <rdar://problem/4795716> REGRESSION: User names and passwords aren't being saved (.Mac, etc.) -- WebKit formState passing empty strings
591
592         * loader/mac/WebFormState.mm: (WebCore::FormState::FormState): Fix typo -- need to pass "key"
593         as the key, not the dictionary itself.
594
595 2006-10-20  Alice Liu  <alice.liu@apple.com>
596
597         Reviewed by Maciej.
598
599         This is the initial foundation for the EditingController class and
600         everything else it needs to work.  The idea is that the Frame has an
601         EditingController object that it calls to handle editing commands, the
602         most simple examples being copy/paste.  This controller will handle
603         these editing commands in WebCore, and only hand off to WebKit to call
604         editing delegates (to the let the app intercept editing actions if it
605         wants to).  Thus we need a platform-specific client to which the
606         EditingController hands off the delegate calls, 
607         WebCoreEditingControllerClient.  On the WebCore side this is an 
608         abstract base class, and on the WebKit(Mac) side this is an ObjC++
609         subclass, WebEditingControllerClient.  How does the EditingController
610         get a handle to its platform-specific client?  In WebKit, the creator
611         of a platform-specific Frame creates the client (which is ref-counted)
612         and passes it down the chain of constructors until it gets back to the
613         EditingController, which then refs it in its constructor and derefs in
614         its destructor.
615         
616         No Layout tests needed.
617         
618         * WebCore.xcodeproj/project.pbxproj:
619         Added files and made DomRangeInternal.h and EditingClient.h private headers, necessary for WebKit to compile
620
621         * bridge/EditorClient.h: Added.
622         (WebCore::EditorClient::~EditorClient):
623
624         * bridge/mac/FrameMac.h:
625         Added an EditingClient to the constructor, to pass down to Frame constructor
626
627         * bridge/mac/FrameMac.mm:
628         (WebCore::FrameMac::FrameMac):
629         Passed client down to Frame constructor
630         
631         * bridge/mac/WebCoreFrameBridge.h:
632         Added an EditingClient to the constructor, to pass down to FrameMac constructor
633         
634         * bridge/mac/WebCoreFrameBridge.mm:
635         (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]):
636         (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]):
637         Passed client down to FrameMac constructor
638         
639         * editing/Editor.cpp: Added.
640         Mostly stuf implementations of the following functions, except for a couple.  These are all needed by cut, copy, paste, delete.
641         (WebCore::generalPasteboard):
642         (WebCore::Editor::canCopy):
643         (WebCore::Editor::canCut):
644         (WebCore::Editor::canDelete):
645         (WebCore::Editor::canDeleteRange):
646         (WebCore::Editor::canPaste):
647         (WebCore::Editor::canSmartCopyOrDelete):
648         (WebCore::Editor::deleteSelection):
649         (WebCore::Editor::deleteSelectionWithSmartDelete):
650         (WebCore::Editor::isSelectionRichlyEditable):
651         (WebCore::Editor::pasteAsPlainTextWithPasteboard):
652         (WebCore::Editor::pasteWithPasteboard):
653         (WebCore::Editor::selectedRange):
654         (WebCore::Editor::shouldDeleteRange):
655         (WebCore::Editor::tryDHTMLCopy):
656         (WebCore::Editor::tryDHTMLCut):
657         (WebCore::Editor::tryDHTMLPaste):
658         (WebCore::Editor::writeSelectionToPasteboard):
659         (WebCore::Editor::Editor):
660         (WebCore::Editor::~Editor):
661         (WebCore::Editor::cut):
662         (WebCore::Editor::copy):
663         (WebCore::Editor::paste):
664         (WebCore::Editor::performDelete):
665         
666         * editing/Editor.h: Added.
667         
668         * page/Frame.h:
669         Added an EditingClient to the constructor, to pass down to Editor constructor
670
671         * page/Frame.cpp:
672         (WebCore::Frame::Frame):
673         Passed down to Editor constructor
674         (WebCore::Frame::editor):
675         Accessfor for Editor stored in FramePrivate
676         
677         * page/FramePrivate.h:
678         (WebCore::FramePrivate::FramePrivate):
679         Added an Editor object to the FramePrivate data
680         
681         * platform/Sound.h: Added.
682         Made a platform-independent accessor to a beep function
683         
684         * platform/mac/SoundMac.mm: Added.
685         (WebCore::systemBeep):
686         calls mac system beep
687         
688 2006-10-20  David Hyatt  <hyatt@apple.com>
689
690         Make sure to support the "encoding" property on form elements for
691         legacy compatibility.
692
693         Reviewed by darin/john
694
695         No test cases added.  Not sure how to do a form submission of
696         various encodings as a layout test.
697
698         * html/HTMLFormElement.h:
699         (WebCore::HTMLFormElement::encoding):
700         (WebCore::HTMLFormElement::setEncoding):
701         * html/HTMLFormElement.idl:
702
703 2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>
704
705         Reviewed and by Anders.
706
707         Fix warnings in JS generation by killing the whole isRefPtr logic,
708         and just using WTF::getPtr as Sam Weinig suggested. Also kill some
709         places using get() where getPtr() is cleaner - not for m_impl.get().
710
711         * CMakeLists.txt: Tiny cleanup + add deps for CodeGenerator(JS).pm on all IDLs.
712         * bindings/scripts/CodeGeneratorJS.pm:
713
714 2006-10-20  Darin Adler  <darin@apple.com>
715
716         - rolled out my loader change; caused world leak and possibly a plug-in crash
717
718 2006-10-20  Anders Carlsson  <acarlsson@apple.com>
719
720         Reviewed by Tim H
721
722         * loader/mac/LoaderFunctionsMac.mm:
723         Autorelease the header NSDictionary.
724         
725 2006-10-20  Anders Carlsson  <acarlsson@apple.com>
726
727         Reviewed by Geoff.
728
729         * bindings/js/kjs_window.cpp:
730         (KJS::Window::timerFired):
731         Check if the timeout id is still in the table before trying to access it. If it isn't in the table
732         it has been deleted inside of the execute method.
733
734 2006-10-20  Anders Carlsson  <acarlsson@apple.com>
735
736         Reviewed by Darin and Geoff.
737
738         Remove debugging output.
739         * xml/xmlhttprequest.cpp:
740         (WebCore::XMLHttpRequest::send):
741
742 2006-10-20  David Harrison  <harrison@apple.com>
743
744         Reviewed by John.
745
746         <rdar://problem/4792755> REGRESSON: Drag selecting is erratic
747
748         No test because it would require autoscrolling, which is not available to layout tests.
749
750         * rendering/RenderLayer.cpp:
751         (WebCore::RenderLayer::autoscroll):
752         Use hitTest() to find the correct node.
753         
754         (WebCore::RenderLayer::hitTest):
755         Trivial source formatting.
756
757 2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>
758
759         Reviewed and landed by Anders.
760
761         Fix regression introduced during the ResourceLoader transition (Maciej's rewrite).
762
763         * platform/qt/ResourceLoaderManager.cpp:
764         (WebCore::ResourceLoaderManager::add):
765
766 2006-10-20  Darin Adler  <darin@apple.com>
767
768         Reviewed by Adele.
769
770         - convert WebLoader and its 3 subclasses to C++
771
772         Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
773         there's currently another class with that name).
774         Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
775         Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
776         Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
777
778         Converted the classes to C++ and added Objective-C delegates to forward from
779         API that still requires Objective-C.
780
781         Did not yet rename the source files.
782
783         * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader
784         classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader
785         classes.
786
787         * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
788
789         * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
790
791         * loader/mac/WebLoader.h:
792         * loader/mac/WebLoader.mm:
793         * loader/mac/WebMainResourceLoader.h:
794         * loader/mac/WebMainResourceLoader.mm:
795         * loader/mac/WebNetscapePlugInStreamLoader.h:
796         * loader/mac/WebNetscapePlugInStreamLoader.mm:
797         * loader/mac/WebSubresourceLoader.h:
798         * loader/mac/WebSubresourceLoader.mm:
799         Translate to C++.
800
801         * bridge/mac/WebCoreFrameBridge.mm:
802         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
803         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
804         * loader/mac/WebFrameLoader.h:
805         * loader/mac/WebFrameLoader.mm:
806         (isCaseInsensitiveEqual):
807         (isBackForwardLoadType):
808         (-[WebFrameLoader dealloc]):
809         (-[WebFrameLoader addPlugInStreamLoader:]):
810         (-[WebFrameLoader removePlugInStreamLoader:]):
811         (-[WebFrameLoader setDefersCallbacks:]):
812         (-[WebFrameLoader stopLoadingPlugIns]):
813         (-[WebFrameLoader isLoadingMainResource]):
814         (-[WebFrameLoader isLoadingSubresources]):
815         (-[WebFrameLoader isLoadingPlugIns]):
816         (-[WebFrameLoader stopLoadingSubresources]):
817         (-[WebFrameLoader addSubresourceLoader:]):
818         (-[WebFrameLoader removeSubresourceLoader:]):
819         (-[WebFrameLoader mainResourceData]):
820         (-[WebFrameLoader releaseMainResourceLoader]):
821         (-[WebFrameLoader cancelMainResourceLoad]):
822         (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
823         (-[WebFrameLoader stopLoadingWithError:]):
824         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
825         (-[WebFrameLoader archiveLoadPendingForLoader:]):
826         (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
827         * loader/mac/WebFrameLoaderClient.h:
828         Call the new C++ API.
829
830 2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>
831
832         Reviewed and landed by Anders.
833
834         Offer a way for WebKitPart to be able to detect when
835         the webpage has been completly loaded (including subresources).
836
837         Also fix Qt/Linux build by removing PopupMenu.cpp from CMakeLists.txt
838         and removing some functions from PopupMenuQt.cpp, and alter FrameQt.cpp.
839
840         * CMakeLists.txt:
841         * platform/qt/FrameQt.cpp:
842         (WebCore::FrameQt::submitForm):
843         (WebCore::FrameQt::client):
844         * platform/qt/FrameQt.h:
845         * platform/qt/FrameQtClient.cpp:
846         (WebCore::FrameQtClientDefault::setFrame):
847         (WebCore::FrameQtClientDefault::openURL):
848         (WebCore::FrameQtClientDefault::submitForm):
849         (WebCore::FrameQtClientDefault::checkLoaded):
850         (WebCore::FrameQtClientDefault::traverseNextFrameStayWithin):
851         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
852         (WebCore::FrameQtClientDefault::receivedAllData):
853         * platform/qt/FrameQtClient.h:
854         * platform/qt/LoaderFunctionsQt.cpp:
855         (WebCore::CheckCacheObjectStatus):
856         * platform/qt/PopupMenuQt.cpp:
857         * platform/qt/ResourceLoaderManager.cpp:
858         (WebCore::ResourceLoaderManager::ResourceLoaderManager):
859         (WebCore::ResourceLoaderManager::slotResult):
860         (WebCore::ResourceLoaderManager::add):
861         * platform/qt/ResourceLoaderManager.h:
862         * platform/qt/ResourceLoaderQt.cpp:
863         (WebCore::ResourceLoader::start):
864
865 2006-10-20  Steve Falkenburg  <sfalken@apple.com>
866
867         Reviewed by Geoff.
868
869         Fix compiler warnings
870
871         * platform/ResourceLoaderClient.h:
872
873 2006-10-20  Sam Weinig  <sam.weinig@gmail.com>
874
875         Reviewed by Mitz.
876
877         Win32 build fix and cleanup.
878
879         * WebCore.vcproj/WebCore/WebCore.vcproj:
880         * bridge/win/FrameWin.cpp:
881         (WebCore::FrameWin::FrameWin):
882         (WebCore::FrameWin::submitForm):
883         * page/ResourceRequest.h:
884         (WebCore::ResourceRequest::addHTTPHeaderField):
885         * platform/win/TemporaryLinkStubs.cpp:
886         (WebCore::Slider::~Slider):
887         (WebCore::Slider::setMinValue):
888         (WebCore::searchableIndexIntroduction):
889         (WebCore::findNextSentenceFromIndex):
890         (WebCore::findSentenceBoundary):
891         (WebCore::findNextWordFromIndex):
892         (WebCore::FrameWin::getObjectInstanceForWidget):
893         (WebCore::FrameWin::getEmbedInstanceForWidget):
894         (WebCore::FrameWin::runJavaScriptPrompt):
895         (WebCore::FrameWin::restoreDocumentState):
896         (WebCore::FrameWin::partClearedInBegin):
897         (WebCore::FrameWin::createEmptyDocument):
898         (WebCore::FrameWin::overrideMediaType):
899         (WebCore::FrameWin::markedTextRange):
900         (WebCore::FrameWin::passSubframeEventToSubframe):
901         (WebCore::FrameWin::lastEventIsMouseUp):
902         (WebCore::FrameWin::addMessageToConsole):
903         (WebCore::FrameWin::shouldChangeSelection):
904         (WebCore::FrameWin::respondToChangedSelection):
905         (WebCore::FrameWin::createFrame):
906         (WebCore::FrameWin::saveDocumentState):
907         (WebCore::FrameWin::clearUndoRedoOperations):
908         (WebCore::FrameWin::incomingReferrer):
909         (WebCore::FrameWin::markMisspellingsInAdjacentWords):
910         (WebCore::FrameWin::respondToChangedContents):
911         (WebCore::FrameWin::handledOnloadEvents):
912         (WebCore::FrameWin::createPlugin):
913         (WebCore::FrameWin::objectContentType):
914         (WebCore::screenDepthPerComponent):
915         (WebCore::screenIsMonochrome):
916         (WebCore::historyContains):
917         (WebCore::submitButtonDefaultLabel):
918         (WebCore::inputElementAltText):
919         (WebCore::resetButtonDefaultLabel):
920         (WebCore::fileButtonChooseFileLabel):
921         (WebCore::fileButtonNoFileSelectedLabel):
922         (WebCore::defaultLanguage):
923         (WebCore::findWordBoundary):
924         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
925         (WebCore::PlugInInfoStore::supportsMIMEType):
926         (WebCore::refreshPlugins):
927         (WebCore::ResourceLoader::assembleResponseHeaders):
928         (WebCore::ResourceLoader::retrieveResponseEncoding):
929         (WebCore::ResourceLoader::startHTTPRequest):
930         (WebCore::TextField::TextField):
931         (WebCore::focusRingColor):
932         (WebCore::setFocusRingColorChangeFunction):
933         (WebCore::PopupMenu::~PopupMenu):
934         (WebCore::PopupMenu::hide):
935
936 2006-10-20  Rob Buis  <buis@kde.org>
937
938         Reviewed by Darin.
939
940         http://bugs.webkit.org/show_bug.cgi?id=11303
941         Path::transform() should be implemented on Qt build
942
943         Use QPainterPath API to implement Path::transform.
944         This fixes svg/custom/clip-path-with-transform.svg on
945         the qt build.
946
947         * platform/qt/PathQt.cpp:
948         (WebCore::Path::transform):
949
950 2006-10-20  Rob Buis  <buis@kde.org>
951
952         Reviewed by Mitz.
953
954         http://bugs.webkit.org/show_bug.cgi?id=11217
955         Cleanup svg coding style
956
957         Cleanup coding style in svg clipping and painting classes.
958
959         * ksvg2/svg/SVGClipPathElement.cpp:
960         (WebCore::SVGClipPathElement::parseMappedAttribute):
961         (WebCore::SVGClipPathElement::canvasResource):
962         * ksvg2/svg/SVGClipPathElement.h:
963         * ksvg2/svg/SVGMarkerElement.cpp:
964         (WebCore::SVGMarkerElement::SVGMarkerElement):
965         (WebCore::SVGMarkerElement::parseMappedAttribute):
966         (WebCore::SVGMarkerElement::setOrientToAngle):
967         (WebCore::SVGMarkerElement::canvasResource):
968         * ksvg2/svg/SVGMarkerElement.h:
969         (WebCore::SVGMarkerElement::rendererIsNeeded):
970         * ksvg2/svg/SVGMaskElement.cpp:
971         (WebCore::SVGMaskElement::SVGMaskElement):
972         (WebCore::SVGMaskElement::parseMappedAttribute):
973         (WebCore::SVGMaskElement::drawMaskerContent):
974         (WebCore::SVGMaskElement::canvasResource):
975         * ksvg2/svg/SVGMaskElement.h:
976         (WebCore::SVGMaskElement::rendererIsNeeded):
977         * ksvg2/svg/SVGPaint.cpp:
978         (WebCore::SVGPaint::setPaint):
979         (WebCore::SVGPaint::cssText):
980         * ksvg2/svg/SVGPaint.h:
981
982 2006-10-20  David Hyatt  <hyatt@apple.com>
983
984         Make sure to do the code that checks the repeatInterval before the timer has been
985         deleted. (Duh.)
986
987         Reviewed by andersca
988
989         * bindings/js/kjs_window.cpp:
990         (KJS::DOMWindowTimer::setNestingLevel):
991         (KJS::Window::timerFired):
992         (KJS::DOMWindowTimer::fired):
993         * platform/Timer.h:
994
995 2006-10-20  David Hyatt  <hyatt@apple.com>
996
997         Honor tiny timer intervals for JS timeouts as they are nested until a cutoff point is reached.
998         At that point clamp to 10ms to prevent excessive CPU usage.
999
1000         Reviewed by anders
1001
1002         * bindings/js/kjs_window.cpp:
1003         (KJS::DOMWindowTimer::DOMWindowTimer):
1004         (KJS::DOMWindowTimer::nestingLevel):
1005         (KJS::Window::installTimeout):
1006         (KJS::Window::pauseTimeouts):
1007         (KJS::Window::resumeTimeouts):
1008         (KJS::DOMWindowTimer::fired):
1009         * platform/Timer.h:
1010         (WebCore::TimerBase::startRepeating):
1011         (WebCore::TimerBase::startOneShot):
1012         (WebCore::TimerBase::repeatInterval):
1013         (WebCore::TimerBase::augmentRepeatInterval):
1014         (WebCore::TimerBase::inHeap):
1015         (WebCore::Timer::Timer):
1016         (WebCore::Timer::fired):
1017
1018 2006-10-20  Steve Falkenburg  <sfalken@apple.com>
1019
1020         Build fix
1021
1022         * ksvg2/svg/SVGAElement.cpp:
1023         (WebCore::SVGAElement::defaultEventHandler):
1024
1025 2006-10-19  Steve Falkenburg  <sfalken@apple.com>
1026
1027         Reviewed by Adam.
1028
1029         Use GetKeyState rather than GetAsyncKeyState since we're
1030         calling in these cases in direct response to an event, and want the
1031         key state associated with that event.
1032         
1033         Pass triggering event to url selection method.
1034         
1035         * bridge/mac/FrameMac.h: Add triggeringEvent parameter
1036         * bridge/mac/FrameMac.mm:
1037         (WebCore::FrameMac::urlSelected): Add triggeringEvent parameter
1038         * bridge/win/FrameWin.cpp:
1039         (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
1040         * bridge/win/FrameWin.h: Add triggeringEvent parameter
1041         * html/HTMLAnchorElement.cpp:
1042         (WebCore::HTMLAnchorElement::defaultEventHandler): Pass triggering event to URL selection method
1043         * page/Frame.cpp:
1044         (WebCore::Frame::changeLocation): Add 0 as triggeringEvent
1045         (WebCore::Frame::urlSelected): Pass through triggeringEvent
1046         * page/Frame.h: Add triggeringEvent parameter to urlSelected methods
1047         * platform/win/KeyEventWin.cpp:
1048         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use GetKeyState instead of GetAsyncKeyState
1049         * platform/win/MouseEventWin.cpp: Use GetKeyState instead of GetAsyncKeyState
1050         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1051
1052 2006-10-19  David Hyatt  <hyatt@apple.com>
1053
1054         Correct typos from changing "flush" to "prune" using automated search/replace.
1055
1056         Change the cache heuristic for flushing to allow a higher watermark before initiating an
1057         aggressive prune.  This ensures that small cache sizes are no worse in terms of performance
1058         than the old buggy cache.
1059
1060         Make sizes unsigned instead of ints in the cache's APIs and member variables.
1061
1062         * loader/Cache.cpp:
1063         (WebCore::Cache::prune):
1064         (WebCore::Cache::setMaximumSize):
1065         * loader/Cache.h:
1066         (WebCore::Cache::maximumSize):
1067
1068 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
1069
1070         Reviewed by Daddy Hyatt.
1071
1072         Use a real hash map for the headers.
1073
1074         * loader/LoaderFunctions.h:
1075         * loader/mac/LoaderFunctionsMac.mm:
1076         (WebCore::ServeSynchronousRequest):
1077         * platform/ResourceLoader.cpp:
1078         (WebCore::ResourceLoader::setRequestHeaders):
1079         (WebCore::ResourceLoader::requestHeaders):
1080         * platform/ResourceLoader.h:
1081         * platform/ResourceLoaderInternal.h:
1082         * platform/mac/ResourceLoaderMac.mm:
1083         (WebCore::ResourceLoader::start):
1084         * xml/xmlhttprequest.cpp:
1085         (WebCore::XMLHttpRequest::open):
1086         (WebCore::XMLHttpRequest::send):
1087         (WebCore::XMLHttpRequest::setRequestHeader):
1088         (WebCore::XMLHttpRequest::getRequestHeader):
1089         * xml/xmlhttprequest.h:
1090
1091 2006-10-19  Adam Roben  <aroben@apple.com>
1092
1093         Reviewed by Ada.
1094
1095         Pippity-poppity popup tweaks.
1096
1097         * WebCore.xcodeproj/project.pbxproj: Removed PopupMenu.cpp from project.
1098         * html/HTMLSelectElement.cpp:
1099         (WebCore::HTMLSelectElement::setSelectedIndex): Only fire onChange if
1100         requested and the new index is actually different than the old one.
1101         * platform/IntPoint.h: Added another casting operator.
1102         * platform/PopupMenu.cpp: Removed. The code in here, while
1103         platform-independent, was only useful for the NSPopUpButtonCell
1104         implementation of popup menus, so I've moved it to PopupMenuMac.mm.
1105         * platform/PopupMenu.h: Moved the definition of PopupMenu::create into
1106         the header since it's fairly simple. Made some more methods private now
1107         that we don't have subclasses and virtual methods anymore.
1108         (WebCore::PopupMenu::create):
1109         (WebCore::PopupMenu::menuList):
1110         (WebCore::PopupMenu::itemHeight):
1111         (WebCore::PopupMenu::windowRect):
1112         (WebCore::PopupMenu::listIndexAtPoint):
1113         (WebCore::PopupMenu::focusedIndex):
1114         (WebCore::PopupMenu::setWasClicked):
1115         (WebCore::PopupMenu::wasClicked):
1116         (WebCore::PopupMenu::setScrollOffset):
1117         (WebCore::PopupMenu::scrollOffset):
1118         (WebCore::PopupMenu::wheelDelta):
1119         * platform/mac/PopupMenuMac.mm: Added the code from PopupMenu.cpp.
1120         (WebCore::PopupMenu::populate): Call our own clear() method to clear
1121         the menu.
1122         * platform/win/IntPointWin.cpp: New casting operator.
1123         (WebCore::IntPoint::IntPoint):
1124         (WebCore::IntPoint::operator POINTS):
1125
1126 2006-10-19  Adam Roben  <aroben@apple.com>
1127
1128         Reviewed by Darin.
1129
1130         Cleaning up Document::nextFocusNode and Document::previousFocusNode.
1131
1132         * dom/Document.cpp:
1133         (WebCore::Document::nextFocusNode):
1134         (WebCore::Document::previousFocusNode):
1135
1136 2006-10-19  Maciej Stachowiak  <mjs@apple.com>
1137
1138         Reviewed by Geoff.
1139
1140         - implement new ResourceRequest API and fix up code as appropriate
1141         
1142         * bindings/js/kjs_window.cpp:
1143         (KJS::createNewWindow):
1144         (KJS::WindowFunc::callAsFunction):
1145         * bridge/mac/BrowserExtensionMac.mm:
1146         (WebCore::BrowserExtensionMac::createNewWindow):
1147         * bridge/mac/FrameMac.mm:
1148         (WebCore::FrameMac::submitForm):
1149         (WebCore::FrameMac::openURLRequest):
1150         (WebCore::FrameMac::urlSelected):
1151         * bridge/mac/WebCoreFrameBridge.mm:
1152         (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
1153         * dom/DOMImplementation.cpp:
1154         (WebCore::addString):
1155         (WebCore::isSVG10Feature):
1156         (WebCore::isSVG11Feature):
1157         * dom/Document.h:
1158         * editing/CommandByName.cpp:
1159         * editing/JSEditor.cpp:
1160         * page/Frame.cpp:
1161         (WebCore::Frame::changeLocation):
1162         (WebCore::Frame::urlSelected):
1163         (WebCore::Frame::requestFrame):
1164         (WebCore::Frame::submitForm):
1165         * page/Frame.h:
1166         * page/FramePrivate.h:
1167         * page/ResourceRequest.h:
1168         (WebCore::):
1169         (WebCore::ResourceRequest::ResourceRequest):
1170         (WebCore::ResourceRequest::cachePolicy):
1171         (WebCore::ResourceRequest::setCachePolicy):
1172         (WebCore::ResourceRequest::timeoutInterval):
1173         (WebCore::ResourceRequest::setTimeoutInterval):
1174         (WebCore::ResourceRequest::mainDocumentURL):
1175         (WebCore::ResourceRequest::setMainDocumentURL):
1176         (WebCore::ResourceRequest::httpMethod):
1177         (WebCore::ResourceRequest::setHTTPMethod):
1178         (WebCore::ResourceRequest::httpHeaderField):
1179         (WebCore::ResourceRequest::setHTTPHeaderField):
1180         (WebCore::ResourceRequest::httpContentType):
1181         (WebCore::ResourceRequest::setHTTPContentType):
1182         (WebCore::ResourceRequest::httpReferrer):
1183         (WebCore::ResourceRequest::setHTTPReferrer):
1184         (WebCore::ResourceRequest::httpUserAgent):
1185         (WebCore::ResourceRequest::setHTTPUserAgent):
1186         (WebCore::ResourceRequest::httpBody):
1187         (WebCore::ResourceRequest::setHTTPBody):
1188         (WebCore::ResourceRequest::addHTTPHeaderField):
1189         * platform/FontCache.cpp:
1190         (WebCore::computeHash):
1191         * platform/StringHash.h:
1192         (WTF::):
1193         * platform/StringImpl.cpp:
1194         (WebCore::equalIgnoringCase):
1195         * rendering/RenderPartObject.cpp:
1196         (WebCore::RenderPartObject::updateWidget):
1197
1198 2006-10-19  Justin Garcia  <justin.garcia@apple.com>
1199
1200         Reviewed by levi
1201         
1202         <rdar://problem/4447885>
1203         API: WebView should have a method something like incrementLeftMarginBy: or indentBy:
1204         
1205         Fixed indent/outdent to only increment the left margin, to match other browsers.
1206         Used blockquote class="webkit-indent-blockquote" to do this.  Mail can now
1207         implement indent/outdent by customizing the appearance of these blockquotes,
1208         instead of using a new API.
1209         
1210         * css/html4.css: Added margin: 0 0 0 40px for webkit-indent-blockquotes.
1211         * editing/IndentOutdentCommand.cpp:
1212         (WebCore::indentBlockquoteString): Added.
1213         (WebCore::createIndentBlockquoteElement): Added.
1214         (WebCore::isIndentBlockquote): Added.
1215         (WebCore::isListOrBlockquote): Added.
1216         (WebCore::IndentOutdentCommand::IndentOutdentCommand):
1217         (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Fixed
1218         a bug in the code that added an extra br if the placeholder collapsed upon insertion.
1219         Used the new indentBlockquote checks and enclosing element getters.  
1220         (WebCore::IndentOutdentCommand::indentRegion): Ditto.
1221         (WebCore::IndentOutdentCommand::outdentParagraph): Ditto.  Cleaned up the
1222         logic to pull the selection out of a list a bit.
1223         * editing/htmlediting.cpp:
1224         (WebCore::enclosingNodeOfType): Added this generic enclosing element getter.
1225         * editing/htmlediting.h:
1226
1227 2006-10-19  Timothy Hatcher  <timothy@apple.com>
1228
1229         Rolling out the this change since it caused a bad regression:
1230         <rdar://problem/4788524> REGRESSION: Incomplete repaint of text area when deleting (11277)
1231
1232 2006-10-12  Adele Peterson  <adele@apple.com>
1233           
1234         Reviewed by Dave Harrison.
1235           
1236         - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
1237           
1238         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
1239         Make subtree layouts work for textareas as well as text fields.
1240
1241 2006-10-19  Nikolas Zimmermann  <zimmermann@kde.org>
1242
1243         Reviewed and landed by Anders.
1244
1245         Fix Qt/Linux build.
1246
1247         * CMakeLists.txt:
1248         * loader/Cache.h:
1249         * platform/qt/BrowserExtensionQt.cpp:
1250         * platform/qt/BrowserExtensionQt.h:
1251         * platform/qt/CursorQt.cpp:
1252         (WebCore::pointerCursor):
1253         * platform/qt/LoaderFunctionsQt.cpp:
1254         (WebCore::NumberOfPendingOrLoadingRequests):
1255         (WebCore::CheckCacheObjectStatus):
1256         * platform/qt/ResourceLoaderQt.cpp:
1257         (WebCore::ResourceLoader::retrieveResponseEncoding):
1258         (WebCore::ResourceLoader::receivedResponse):
1259
1260 2006-10-19  Sam Weinig  <sam.weinig@gmail.com>
1261
1262         Reviewed by ap.
1263
1264         Win32 build fix.
1265
1266         * bridge/win/FrameWin.cpp:
1267         * bridge/win/FrameWin.h:
1268         * platform/win/TemporaryLinkStubs.cpp:
1269         (WebCore::ResourceLoader::retrieveResponseEncoding):
1270
1271 2006-10-19  Alexey Proskuryakov  <ap@nypop.com>
1272
1273         Reviewed by Mitz.
1274
1275         http://bugs.webkit.org/show_bug.cgi?id=11141
1276         REGRESSION(r16681-r16691): CSS '@import' doesn't respect HTML Base element
1277
1278         Undo one misguided change made in bug 11011 - stop setting inline stylesheet's href
1279         to document URL. This matches WinIE and partially matches Firefox - although the latter
1280         reports the href as if it were inherited, it still doesn't use it when resolving URIs in
1281         @import rules.
1282
1283         Test: http/tests/uri/css-href.php
1284
1285         * html/HTMLStyleElement.cpp:
1286         (WebCore::HTMLStyleElement::childrenChanged):
1287         * ksvg2/svg/SVGStyleElement.cpp:
1288         (WebCore::SVGStyleElement::childrenChanged):
1289
1290 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
1291
1292         * loader/Cache.cpp:
1293         Get rid of #include "loader.h", Cache.h already includes this and it breaks on operating systems
1294         with case-sensitive file systems.
1295
1296 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
1297
1298         Reviewed by Maciej, Brady.
1299
1300         Remove "charset" from the ResourceLoader metadata map and use 
1301         a getter function instead. Also, rename charset to encoding in a couple of places.
1302         
1303         * loader/CachedCSSStyleSheet.cpp:
1304         (WebCore::CachedCSSStyleSheet::setEncoding):
1305         * loader/CachedCSSStyleSheet.h:
1306         * loader/CachedResource.h:
1307         (WebCore::CachedResource::setEncoding):
1308         * loader/CachedScript.cpp:
1309         (WebCore::CachedScript::setEncoding):
1310         * loader/CachedScript.h:
1311         * loader/CachedXBLDocument.cpp:
1312         (WebCore::CachedXBLDocument::setEncoding):
1313         * loader/CachedXBLDocument.h:
1314         * loader/CachedXSLStyleSheet.cpp:
1315         (WebCore::CachedXSLStyleSheet::setEncoding):
1316         * loader/CachedXSLStyleSheet.h:
1317         * loader/loader.cpp:
1318         (WebCore::Loader::receivedResponse):
1319         * platform/ResourceLoader.cpp:
1320         (WebCore::ResourceLoader::responseEncoding):
1321         (WebCore::ResourceLoader::queryMetaData):
1322         * platform/ResourceLoader.h:
1323         * platform/ResourceLoaderInternal.h:
1324         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1325         * platform/mac/ResourceLoaderMac.mm:
1326         (WebCore::ResourceLoader::retrieveResponseEncoding):
1327         (WebCore::ResourceLoader::receivedResponse):
1328         * xml/xmlhttprequest.cpp:
1329         (WebCore::XMLHttpRequest::receivedData):
1330
1331 2006-10-19  David Hyatt  <hyatt@apple.com>
1332
1333         Rewrite of the WebCore memory cache.  The following changes have been made (along with many more):
1334
1335         (1) Referenced objects are now also cached.
1336
1337         (2) Pruning of the cache will occur once the cache is both full and in addition
1338         more than half full with unreferenced objects.
1339
1340         (3) The prune is much more aggressive now, since referenced objects are counted when
1341         pruning.  The cache will therefore often prune out every unreferenced object if lots of
1342         windows/tabs are open.
1343
1344         (4) Consolidated the request methods for various types of resources to go through a single
1345         requestResource bottleneck function.
1346
1347         (5) deref on CachedResource is no longer virtual, since the implementation in every subclass was
1348         identical.
1349
1350         (6) Changed "object" to "resource" everywhere.
1351
1352         (7) The Cache is now an actual object, obtained via cache().
1353
1354         (8) Fixed bugs with the autoload images preference so that it would really work properly when disabled
1355         and enabled.
1356
1357         (9) Tweaked ImageDocuments to set up the status properly for the CachedResource that they use.
1358
1359         (10) Fixed the LRU-SP algorithm so that the LRU aspect really kicks in (by leaving the live objects
1360         in the LRU lists).  Also fixed a bug with the "-SP" part of the algorithm where the access count was
1361         being incorrectly weighted too much due to a math error.
1362
1363         (11) Fixed a bug where the old cache could grow without bound because it didn't know anything about
1364         the size of referenced resources.
1365
1366         Reviewed by Maciej, bradee-oh
1367
1368         * bridge/mac/WebCoreCache.mm:
1369         (+[WebCoreCache statistics]):
1370         (+[WebCoreCache empty]):
1371         (+[WebCoreCache setDisabled:]):
1372         * bridge/mac/WebCoreFrameBridge.mm:
1373         (-[WebCoreFrameBridge initMainFrameWithPage:]):
1374         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
1375         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
1376         * css/CSSImageValue.cpp:
1377         (WebCore::CSSImageValue::image):
1378         * dom/XMLTokenizer.cpp:
1379         (WebCore::openFunc):
1380         * html/HTMLImageLoader.cpp:
1381         (WebCore::HTMLImageLoader::updateFromElement):
1382         * loader/Cache.cpp:
1383         (WebCore::cache):
1384         (WebCore::Cache::Cache):
1385         (WebCore::createResource):
1386         (WebCore::Cache::requestResource):
1387         (WebCore::Cache::resourceForURL):
1388         (WebCore::Cache::prune):
1389         (WebCore::Cache::setMaximumSize):
1390         (WebCore::Cache::remove):
1391         (WebCore::Cache::addDocLoader):
1392         (WebCore::Cache::removeDocLoader):
1393         (WebCore::fastLog2):
1394         (WebCore::Cache::lruListFor):
1395         (WebCore::Cache::removeFromLRUList):
1396         (WebCore::Cache::insertInLRUList):
1397         (WebCore::Cache::resourceAccessed):
1398         (WebCore::Cache::adjustSize):
1399         (WebCore::Cache::getStatistics):
1400         (WebCore::Cache::setDisabled):
1401         * loader/Cache.h:
1402         (WebCore::LRUList::LRUList):
1403         (WebCore::Cache::loader):
1404         (WebCore::Cache::maximumSize):
1405         (WebCore::Cache::disabled):
1406         (WebCore::Cache::addToLiveObjectSize):
1407         (WebCore::Cache::removeFromLiveObjectSize):
1408         (WebCore::Cache::TypeStatistic::TypeStatistic):
1409         * loader/CachedCSSStyleSheet.cpp:
1410         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1411         * loader/CachedCSSStyleSheet.h:
1412         * loader/CachedImage.cpp:
1413         (WebCore::CachedImage::CachedImage):
1414         (WebCore::CachedImage::~CachedImage):
1415         (WebCore::brokenImage):
1416         (WebCore::nullImage):
1417         (WebCore::CachedImage::image):
1418         (WebCore::CachedImage::data):
1419         * loader/CachedImage.h:
1420         (WebCore::CachedImage::stillNeedsLoad):
1421         * loader/CachedResource.cpp:
1422         (WebCore::CachedResource::CachedResource):
1423         (WebCore::CachedResource::~CachedResource):
1424         (WebCore::CachedResource::finish):
1425         (WebCore::CachedResource::setExpireDate):
1426         (WebCore::CachedResource::isExpired):
1427         (WebCore::CachedResource::setRequest):
1428         (WebCore::CachedResource::ref):
1429         (WebCore::CachedResource::deref):
1430         (WebCore::CachedResource::setSize):
1431         * loader/CachedResource.h:
1432         (WebCore::CachedResource::):
1433         (WebCore::CachedResource::setCharset):
1434         (WebCore::CachedResource::url):
1435         (WebCore::CachedResource::type):
1436         (WebCore::CachedResource::referenced):
1437         (WebCore::CachedResource::count):
1438         (WebCore::CachedResource::status):
1439         (WebCore::CachedResource::size):
1440         (WebCore::CachedResource::isLoaded):
1441         (WebCore::CachedResource::setLoading):
1442         (WebCore::CachedResource::isImage):
1443         (WebCore::CachedResource::accessCount):
1444         (WebCore::CachedResource::increaseAccessCount):
1445         (WebCore::CachedResource::setInCache):
1446         (WebCore::CachedResource::inCache):
1447         (WebCore::CachedResource::cachePolicy):
1448         (WebCore::CachedResource::response):
1449         (WebCore::CachedResource::allData):
1450         (WebCore::CachedResource::canDelete):
1451         (WebCore::CachedResource::schedule):
1452         (WebCore::CachedResource::accept):
1453         (WebCore::CachedResource::setAccept):
1454         * loader/CachedScript.cpp:
1455         (WebCore::CachedScript::CachedScript):
1456         * loader/CachedScript.h:
1457         * loader/CachedXBLDocument.cpp:
1458         * loader/CachedXBLDocument.h:
1459         * loader/CachedXSLStyleSheet.cpp:
1460         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
1461         * loader/CachedXSLStyleSheet.h:
1462         * loader/DocLoader.cpp:
1463         (WebCore::DocLoader::DocLoader):
1464         (WebCore::DocLoader::~DocLoader):
1465         (WebCore::DocLoader::checkForReload):
1466         (WebCore::DocLoader::requestImage):
1467         (WebCore::DocLoader::requestCSSStyleSheet):
1468         (WebCore::DocLoader::requestScript):
1469         (WebCore::DocLoader::requestXSLStyleSheet):
1470         (WebCore::DocLoader::requestXBLDocument):
1471         (WebCore::DocLoader::requestResource):
1472         (WebCore::DocLoader::setAutoLoadImages):
1473         (WebCore::DocLoader::removeCachedResource):
1474         * loader/DocLoader.h:
1475         (WebCore::DocLoader::cachedResource):
1476         (WebCore::DocLoader::allCachedResources):
1477         (WebCore::DocLoader::autoLoadImages):
1478         (WebCore::DocLoader::cachePolicy):
1479         (WebCore::DocLoader::expireDate):
1480         (WebCore::DocLoader::frame):
1481         (WebCore::DocLoader::doc):
1482         (WebCore::DocLoader::loadInProgress):
1483         * loader/ImageDocument.cpp:
1484         (WebCore::ImageTokenizer::finish):
1485         * loader/loader.cpp:
1486         (WebCore::Loader::receivedAllData):
1487         (WebCore::Loader::cancelRequests):
1488         * loader/mac/LoaderFunctionsMac.mm:
1489         (WebCore::NumberOfPendingOrLoadingRequests):
1490         (WebCore::CheckCacheObjectStatus):
1491         * page/Frame.cpp:
1492         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
1493         (WebCore::Frame::Frame):
1494         (WebCore::Frame::stopLoading):
1495         (WebCore::Frame::setAutoLoadImages):
1496         (WebCore::Frame::autoLoadImages):
1497         (WebCore::Frame::begin):
1498         (WebCore::Frame::checkCompleted):
1499         (WebCore::Frame::reparseConfiguration):
1500         * page/Frame.h:
1501         * xml/XSLTProcessor.cpp:
1502         (WebCore::docLoaderFunc):
1503         * xml/xmlhttprequest.cpp:
1504         (WebCore::XMLHttpRequest::send):
1505
1506 2006-10-18  Maciej Stachowiak  <mjs@apple.com>
1507
1508         Reviewed by Geoff.
1509
1510         - remove vestiges of KXMLCore name (former name of WTF).
1511
1512         * config.h:
1513
1514 2006-10-18  Geoffrey Garen  <ggaren@apple.com>
1515
1516         Reviewed by Beth.
1517         
1518         Fixed http://bugs.webkit.org/show_bug.cgi?id=11222
1519
1520         Some global JS objects lacked references to their property hashtables,
1521         so for-in enumeration didn't work. I added the references, and then removed
1522         a few bogus properties from the tables. The bogus ones got in there through
1523         bit rot.
1524         
1525         We should come up with some solution to these hand-written bindings bugs.
1526         Maybe we could use a script to autogenerate them or something.
1527
1528         * bindings/js/kjs_window.cpp:
1529         (KJS::):
1530         (KJS::History::getValueProperty):
1531
1532 2006-10-18  Adam Roben  <aroben@apple.com>
1533
1534         Reviewed by Brady.
1535
1536         Change Shift-Tab to generate keyIdentifier U+000009 (Tab) instead of
1537         U+000019 (Backtab). This matches our windowsKeyCode for this key
1538         combination.
1539
1540         * platform/mac/KeyEventMac.mm:
1541         (WebCore::keyIdentifierForKeyEvent):
1542
1543 2006-10-18  Steve Falkenburg  <sfalken@apple.com>
1544
1545         Reviewed by Adam, Brady.
1546
1547         Loader tweaks.
1548
1549         * platform/cf/ResourceLoaderCFNet.cpp:
1550         (WebCore::didFinishLoading):
1551         (WebCore::didFail):
1552         (WebCore::didReceiveChallenge):
1553         (WebCore::runLoaderThread):
1554         (WebCore::ResourceLoader::start):
1555         (WebCore::ResourceLoader::cancel):
1556
1557 2006-10-18  Timothy Hatcher  <timothy@apple.com>
1558
1559         Reviewed by Darin.
1560
1561         <rdar://problem/4752138> Manipulating popup in HTML page crashed Xcode
1562
1563         - Store the Mac popup button cell as a RetainPtr to prevent GC collection.
1564         - Convert more ObjC local statics and member variables to use RetainPtr.
1565         - Convert more CFRetain/CFRelease to HardRetain/HardRelease.
1566
1567         * bindings/objc/DOM.mm:
1568         (ObjCNodeFilterCondition::ObjCNodeFilterCondition): use HardRetain and not CFRetain
1569         (ObjCNodeFilterCondition::~ObjCNodeFilterCondition): use HardRelease and not CFRelease
1570         * bridge/mac/AXObjectCacheMac.mm:
1571         (WebCore::AXObjectCache::~AXObjectCache): use HardRelease and not CFRelease
1572         (WebCore::AXObjectCache::get): use HardRetain and not CFRetain
1573         (WebCore::AXObjectCache::remove): use HardRelease and not CFRelease
1574         * bridge/mac/WebCoreFrameBridge.mm:
1575         (+[WebCoreFrameBridge supportedImageResourceMIMETypes]): use RetainPtr
1576         (+[WebCoreFrameBridge supportedImageMIMETypes]): ditto
1577         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1578         (+[WebCoreIconDatabaseBridge sharedInstance]): use RetainPtr
1579         * platform/PopupMenu.h: renamed popup to m_popup and switched to RetainPtr<NSPopUpButtonCell>
1580         * platform/cf/RetainPtr.h:
1581         (WTF::::operator): implement a missing operator= template function
1582         * platform/mac/PopupMenuMac.mm:
1583         (WebCore::PopupMenu::PopupMenu): remove nil initialization
1584         (WebCore::PopupMenu::~PopupMenu): use .get(), remove release message and rename to m_popup
1585         (WebCore::PopupMenu::clear): use .get() when sending a message and rename to m_popup
1586         (WebCore::PopupMenu::populate): ditto 
1587         (WebCore::PopupMenu::show): ditto
1588         (WebCore::PopupMenu::hide): ditto
1589         (WebCore::PopupMenu::addSeparator): ditto
1590         (WebCore::PopupMenu::addGroupLabel): ditto
1591         (WebCore::PopupMenu::addOption): ditto
1592
1593 2006-10-18  Geoffrey Garen  <ggaren@apple.com>
1594
1595         Reviewed by Adele.
1596
1597         Fixed <rdar://problem/3673233> JavaScript timers do not fire if controls
1598         are tracking or menus are down (run loop modes)
1599
1600         I spent a few hours trying to write an automated test, but DRT doesn't
1601         seem to support it. Manual tests attached to related bugs.
1602         
1603         * bridge/mac/FrameMac.mm:
1604         (WebCore::FrameMac::passMouseDownEventToWidget):
1605         * platform/mac/SharedTimerMac.cpp:
1606         (WebCore::setSharedTimerFireTime):
1607
1608 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
1609
1610         Reviewed by Maciej.
1611
1612         More Win32 buildfix.
1613
1614         * bridge/win/FrameWin.h:
1615
1616 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
1617
1618         Reviewed by Mitz
1619
1620         Win32 build fix.
1621
1622         * bridge/win/BrowserExtensionWin.cpp:
1623         (WebCore::BrowserExtensionWin::BrowserExtensionWin):
1624         (WebCore::BrowserExtensionWin::createNewWindow):
1625         * bridge/win/BrowserExtensionWin.h:
1626         * bridge/win/FrameWin.cpp:
1627         (WebCore::FrameWin::createNewWindow):
1628         * bridge/win/FrameWin.h:
1629         * platform/win/CursorWin.cpp:
1630         * platform/win/TemporaryLinkStubs.cpp:
1631         (Image::getHBITMAP):
1632
1633 2006-10-18  Justin Garcia  <justin.garcia@apple.com>
1634
1635         Reviewed by harrison
1636         
1637         <rdar://problem/4784823>
1638         GMail Editor: Hang occurs when removing list styling on text in a rich text message
1639
1640         List removal moves the contents of every list item out of the list it's 
1641         in. When the code tried to move the contents of an empty list item (an li 
1642         with no child nodes, not even a placeholder br), moveParagraph didn't prune 
1643         the li, like it would if the li had a placeholder inside it.  So the list 
1644         removal code went into an infinite loop, continually attempting to de-list 
1645         an empty list item.
1646
1647         * editing/CompositeEditCommand.cpp:
1648         (WebCore::CompositeEditCommand::moveParagraphs): If the selection
1649         to move was empty and in an empty block that doesn't require a 
1650         placeholder to prop itself open (like a bordered div or an li), 
1651         remove it during the move.
1652
1653 2006-10-18  Adele Peterson  <adele@apple.com>
1654
1655         Reviewed by Beth.
1656
1657         - Fixed http://bugs.webkit.org/show_bug.cgi?id=11343
1658           REGRESSION (r16975): fast/events/objc-event-api is failing
1659
1660           When I moved the autoscroll code from FrameMac to Frame, I mistakingly changed the order of
1661           a call to invalidateClick.  This change moves it back to the sequence that existed before.  This allows
1662           the click count to get properly reset during a selection.
1663
1664         * page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent):
1665
1666 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
1667         
1668         Reviewed by Anders.
1669         
1670         Factored common scaling code into a helper function.
1671
1672         * platform/mac/ScreenMac.mm:
1673         (WebCore::scale):
1674         (WebCore::scaleScreenRectToPageCoordinates):
1675         (WebCore::scalePageRectToScreenCoordinates):
1676
1677 2006-10-17  Steve Falkenburg  <sfalken@apple.com>
1678
1679         Build fixes
1680
1681         * bridge/win/BrowserExtensionWin.cpp:
1682         (WebCore::BrowserExtensionWin::createNewWindow):
1683         * bridge/win/BrowserExtensionWin.h:
1684         * bridge/win/FrameWin.cpp:
1685         (WebCore::FrameWin::createNewWindow):
1686         * bridge/win/FrameWin.h:
1687         * platform/gdk/BrowserExtensionGdk.h:
1688         * platform/gdk/TemporaryLinkStubs.cpp:
1689         (BrowserExtensionGdk::createNewWindow):
1690         * platform/qt/BrowserExtensionQt.cpp:
1691         (WebCore::BrowserExtensionQt::createNewWindow):
1692         * platform/qt/BrowserExtensionQt.h:
1693
1694 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
1695
1696         Reviewed by Anders.
1697         
1698         Renamed WindowArgs to WindowFeatures, and moved it into its own header.
1699         ("Features" is the term of art in IE documentation. "Args" is pirate
1700         talk.)
1701
1702         * WebCore.xcodeproj/project.pbxproj:
1703         * bindings/js/kjs_window.cpp:
1704         (KJS::createNewWindow):
1705         (KJS::showModalDialog):
1706         (KJS::setWindowFeature):
1707         (KJS::parseWindowFeatures):
1708         (KJS::constrainToVisible):
1709         (KJS::WindowFunc::callAsFunction):
1710         * bridge/BrowserExtension.h:
1711         * bridge/WindowFeatures.h: Added.
1712         * bridge/mac/BrowserExtensionMac.h:
1713         * bridge/mac/BrowserExtensionMac.mm:
1714         (WebCore::BrowserExtensionMac::createNewWindow):
1715
1716 2006-10-17  Sam Weinig  <sam.weinig@gmail.com>
1717
1718         Reviewed by Tim H.
1719
1720         Patch for http://bugs.webkit.org/show_bug.cgi?id=11268
1721         Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint
1722
1723         - Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.
1724
1725         - Moves the contents of ksvg/bindings/js/ to bindings/js/.
1726
1727         - Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.
1728
1729         - Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching 
1730           the other CSSValue classing, and allowing the bindings to allocate
1731           appropriately.
1732
1733         - Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing
1734           generation for Objective-C.
1735
1736         - Assorted style cleanups.
1737
1738         * DerivedSources.make:
1739         * WebCore.xcodeproj/project.pbxproj:
1740         * bindings/objc/DOMCSS.mm:
1741         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1742         * bindings/objc/DOMEvents.mm:
1743         (+[DOMEvent _eventWith:WebCore::]):
1744         * bindings/objc/DOMSVG.h:
1745         * bindings/objc/DOMSVGNumber.mm:
1746         (-[DOMSVGNumber dealloc]):
1747         (-[DOMSVGNumber finalize]):
1748         (-[DOMSVGNumber value]):
1749         (-[DOMSVGNumber setValue:]):
1750         (-[DOMSVGNumber _SVGNumber]):
1751         (-[DOMSVGNumber _initWithFloat:]):
1752         (+[DOMSVGNumber _SVGNumberWith:]):
1753         * bindings/objc/DOMSVGPoint.mm:
1754         (-[DOMSVGPoint dealloc]):
1755         (-[DOMSVGPoint finalize]):
1756         (-[DOMSVGPoint x]):
1757         (-[DOMSVGPoint setX:]):
1758         (-[DOMSVGPoint y]):
1759         (-[DOMSVGPoint setY:]):
1760         (-[DOMSVGPoint WebCore::]):
1761         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
1762         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
1763         * bindings/objc/DOMSVGRect.mm:
1764         (-[DOMSVGRect dealloc]):
1765         (-[DOMSVGRect finalize]):
1766         (-[DOMSVGRect x]):
1767         (-[DOMSVGRect setX:]):
1768         (-[DOMSVGRect y]):
1769         (-[DOMSVGRect setY:]):
1770         (-[DOMSVGRect width]):
1771         (-[DOMSVGRect setWidth:]):
1772         (-[DOMSVGRect height]):
1773         (-[DOMSVGRect setHeight:]):
1774         (-[DOMSVGRect WebCore::]):
1775         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
1776         (+[DOMSVGRect _SVGRectWith:WebCore::]):
1777         * bindings/scripts/CodeGeneratorObjC.pm:
1778         * css/StyleBase.h:
1779         (WebCore::StyleBase::isSVGColor):
1780         (WebCore::StyleBase::isSVGPaint):
1781         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
1782         * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
1783         * ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
1784         * ksvg2/bindings/js/JSSVGNumber.h: Removed.
1785         * ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
1786         * ksvg2/bindings/js/JSSVGPoint.h: Removed.
1787         * ksvg2/bindings/js/JSSVGRect.cpp: Removed.
1788         * ksvg2/bindings/js/JSSVGRect.h: Removed.
1789         * ksvg2/svg/SVGColor.h:
1790         (WebCore::SVGColor::isSVGColor):
1791         * ksvg2/svg/SVGFECompositeElement.idl:
1792         * ksvg2/svg/SVGFEFloodElement.idl:
1793         * ksvg2/svg/SVGLocatable.idl:
1794         * ksvg2/svg/SVGMarkerElement.idl:
1795         * ksvg2/svg/SVGPaint.h:
1796         (WebCore::SVGPaint::isSVGPaint):
1797         * ksvg2/svg/SVGRectElement.idl:
1798         * ksvg2/svg/SVGZoomEvent.idl: Removed.
1799
1800 2006-10-17  David Hyatt  <hyatt@apple.com>
1801
1802         Prepare for the elimination of the RenderLayer for <html> elements.  The layer is still present,
1803         but this patch makes everything work without a root layer being around.
1804
1805         Reviewed by beth
1806
1807         * rendering/RenderBlock.cpp:
1808         (WebCore::RenderBlock::paint):
1809         (WebCore::RenderBlock::paintChildren):
1810         (WebCore::RenderBlock::nodeAtPoint):
1811         * rendering/RenderLayer.cpp:
1812         (WebCore::frameVisibleRect):
1813         (WebCore::RenderLayer::hitTest):
1814         (WebCore::RenderLayer::hitTestLayer):
1815         (WebCore::RenderLayer::intersectsDamageRect):
1816         * rendering/RenderObject.cpp:
1817         (WebCore::RenderObject::setInnerNode):
1818         * rendering/RenderView.cpp:
1819         (WebCore::RenderView::paint):
1820
1821 2006-10-17  David Hyatt  <hyatt@apple.com>
1822
1823         Back out my previous patch to the WebCore memory cache.
1824
1825         * loader/Cache.cpp:
1826         (WebCore::Cache::flush):
1827         (WebCore::Cache::setSize):
1828         (WebCore::Cache::getLRUListFor):
1829         (WebCore::Cache::removeFromLRUList):
1830         (WebCore::Cache::insertInLRUList):
1831         * loader/Cache.h:
1832         * loader/CachedCSSStyleSheet.cpp:
1833         (WebCore::CachedCSSStyleSheet::deref):
1834         * loader/CachedCSSStyleSheet.h:
1835         * loader/CachedImage.cpp:
1836         (WebCore::CachedImage::deref):
1837         * loader/CachedImage.h:
1838         * loader/CachedResource.cpp:
1839         (WebCore::CachedResource::setRequest):
1840         (WebCore::CachedResource::deref):
1841         * loader/CachedResource.h:
1842         (WebCore::CachedResource::allowInLRUList):
1843         * loader/CachedScript.cpp:
1844         (WebCore::CachedScript::deref):
1845         * loader/CachedScript.h:
1846         * loader/CachedXBLDocument.cpp:
1847         (WebCore::CachedXBLDocument::deref):
1848         * loader/CachedXBLDocument.h:
1849         * loader/CachedXSLStyleSheet.cpp:
1850         (WebCore::CachedXSLStyleSheet::deref):
1851         * loader/CachedXSLStyleSheet.h:
1852
1853 2006-10-17  Oliver Hunt  <oliver@apple.com>
1854
1855         Reviewed by Anders.
1856
1857         Make north and east resize cursors use correct image
1858
1859         * platform/win/CursorWin.cpp:
1860         (WebCore::eastResizeCursor):
1861         (WebCore::northResizeCursor):
1862
1863 2006-10-17  Oliver Hunt  <oliver@apple.com>
1864
1865         Reviewed by Brady
1866
1867         Various cursor fixes
1868
1869         * page/FrameView.cpp:
1870         (WebCore::FrameView::handleMouseMoveEvent):
1871         * platform/Cursor.h:
1872         * platform/mac/CursorMac.mm:
1873         (WebCore::pointerCursor):
1874         * platform/win/CursorWin.cpp:
1875         (WebCore::supportsAlphaCursors):
1876         (WebCore::Cursor::Cursor):
1877         (WebCore::Cursor::~Cursor):
1878         (WebCore::pointerCursor):
1879
1880 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
1881
1882         Reviewed by harrison
1883         
1884         <rdar://problem/4776665>
1885         REGRESSION: In Mail, caret is visible when the message body isn't focused
1886
1887         * page/Frame.cpp:
1888         (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error
1889         (like when the frame that contains the caret isn't focused) then we don't 
1890         want to paint the caret.  We should eventually move to using a single bool
1891         for caret painting.
1892
1893 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
1894
1895         Reviewed by harrison
1896         
1897         <rdar://problem/4774354>
1898         REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
1899
1900         Functions call recomputCaretRect to see if the caret rect has changed, 
1901         and, if it has, they invalidate (repaint) it.  recomputeCaretRect was 
1902         returning false if the caret turned into a range selection or was blown 
1903         away.
1904
1905         * editing/SelectionController.cpp:
1906         (WebCore::SelectionController::recomputeCaretRect): Don't early return if
1907         !isCaret().  Obtain the FrameView* using the m_frame pointer, because m_sel 
1908         may now be null.
1909
1910 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
1911
1912         Reviewed by Brady.
1913
1914         BrowserExtension cleanup.
1915         
1916         - Removed unnecessary #include of BrowserExtension in Frame.h, added
1917         #includes to compensate in other files.
1918         
1919         - Removed unused versions of createNewWindow.
1920         
1921         * bindings/js/kjs_window.cpp:
1922         * bridge/BrowserExtension.h:
1923         * bridge/mac/BrowserExtensionMac.h:
1924         * bridge/mac/BrowserExtensionMac.mm:
1925         (WebCore::BrowserExtensionMac::createNewWindow):
1926         * bridge/mac/WebCoreFrameBridge.mm:
1927         * html/HTMLFormElement.cpp:
1928         * loader/mac/LoaderFunctionsMac.mm:
1929         * page/Frame.h:
1930         * page/FramePrivate.h:
1931
1932 2006-10-15  Geoffrey Garen  <ggaren@apple.com>
1933
1934         Reviewed by Adam.
1935         
1936         - Fixed "FIXME: Violates Liskov Substitution principle."
1937         
1938         IFRAME was never a true subclass of FRAME, since they disagreed on a
1939         number of behaviors, which, confusingly, IFRAME just overrode and contradicted. 
1940
1941         The fix here is to factor out things common to IFRAME and FRAME into a
1942         common base class, HTMLFrameElementBase.
1943         
1944         I also changed some " *" to "* " and added #includes in files that implicitly
1945         assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.
1946
1947 2006-10-16  Justin Garcia  <justin.garcia@apple.com>
1948
1949         Reviewed by sullivan
1950         
1951         <rdar://problem/4776765>
1952         REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
1953
1954         We set m_needsLayout to false and call caretRect() in the hopes that it will give us 
1955         the old caret rect.  It in fact corrects the caret rect for an offset that it 
1956         believes is due to scrolling but which is actually due to a change in selection
1957         without an accompanying layout.  So it returns the new caret rect regardless of
1958         what m_needsLayout is set to.
1959         
1960         * editing/SelectionController.cpp:
1961         (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that
1962         adds a one pixel slop to this new function.
1963         (WebCore::SelectionController::caretRepaintRect): Moved this code to
1964         repaintRectForCaret.
1965         (WebCore::SelectionController::recomputeCaretRect): Compare the old
1966         caret rect to the new one that's computed with a fresh layout.  If
1967         they are different, invalidate both repaint rects.
1968
1969 2006-10-17  David Harrison  <harrison@apple.com>
1970
1971         Reviewed by Adele.
1972
1973         <rdar://problem/4770453> VO not honoring secure edit fields in web pages
1974
1975         * bridge/mac/WebCoreAXObject.mm:
1976         (-[WebCoreAXObject isPasswordField]):
1977         New. Checks for input with inputType() of PASSWORD.
1978         
1979         (-[WebCoreAXObject subrole]):
1980         Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].
1981         
1982         (-[WebCoreAXObject roleDescription]):
1983         Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.
1984         
1985         (-[WebCoreAXObject value]):
1986         Return nil if [self isPasswordField].
1987         
1988         (-[WebCoreAXObject accessibilityAttributeNames]):
1989         Return generic attributes if [self isPasswordField].
1990
1991         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
1992         Return empty array if [self isPasswordField].
1993
1994 2006-10-17  David Hyatt  <hyatt@apple.com>
1995
1996         Fix "flash to white' problem on yahoo.com as it finishes loading.  Refine the FOUC suppression
1997         code so that it will only run if the body still has no renderer.
1998
1999         * dom/Document.cpp:
2000         (WebCore::Document::updateLayoutIgnorePendingStylesheets):
2001
2002 2006-10-17  David Hyatt  <hyatt@apple.com>
2003
2004         Fix a bug where the WebCore memory cache could grow without bound during extended browsing
2005         sessions.
2006
2007         Reviewed by mjs
2008
2009         * loader/Cache.cpp:
2010         (WebCore::Cache::flush):
2011         (WebCore::Cache::setSize):
2012         (WebCore::Cache::getLRUListFor):
2013         (WebCore::Cache::removeFromLRUList):
2014         (WebCore::Cache::insertInLRUList):
2015         * loader/Cache.h:
2016         * loader/CachedCSSStyleSheet.cpp:
2017         * loader/CachedCSSStyleSheet.h:
2018         * loader/CachedImage.cpp:
2019         * loader/CachedImage.h:
2020         * loader/CachedResource.cpp:
2021         (WebCore::CachedResource::setRequest):
2022         (WebCore::CachedResource::deref):
2023         * loader/CachedResource.h:
2024         (WebCore::CachedResource::allowInLRUList):
2025         * loader/CachedScript.cpp:
2026         * loader/CachedScript.h:
2027         * loader/CachedXBLDocument.cpp:
2028         * loader/CachedXBLDocument.h:
2029         * loader/CachedXSLStyleSheet.cpp:
2030         * loader/CachedXSLStyleSheet.h:
2031
2032 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
2033
2034         Reviewed by harrison
2035         
2036         <rdar://problem/3655385>
2037         Editing: -indent: method unimplemented
2038
2039         Added Frame and bridge methods.
2040
2041         * bridge/mac/WebCoreFrameBridge.h:
2042         * bridge/mac/WebCoreFrameBridge.mm:
2043         (-[WebCoreFrameBridge indent]):
2044         (-[WebCoreFrameBridge outdent]):
2045         * page/Frame.cpp:
2046         (WebCore::Frame::indent): 
2047         (WebCore::Frame::outdent):
2048         * page/Frame.h:
2049
2050 2006-10-16  Adam Roben  <aroben@apple.com>
2051
2052         Reviewed by John.
2053
2054         More menulist cleanup/tweaking.
2055
2056         * html/HTMLSelectElement.cpp:
2057         (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index'
2058         parameter to 'optionIndex' for clarity.
2059         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over
2060         items that are not enabled <option> elements when using arrow keys, and
2061         make sure we pass an option index to setSelectedIndex.
2062         * platform/PopupMenu.h:
2063         (WebCore::PopupMenu::setWasClicked): Specify default argument.
2064         * rendering/RenderMenuList.cpp:
2065         (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from
2066         option text before setting the control text so that options within
2067         <optgroup>s don't appear indented in the actual control.
2068
2069 2006-10-16  Sam Weinig  <sam.weinig@gmail.com>
2070
2071         Reviewed by Adam.
2072
2073         Win32 build fix.
2074
2075         * WebCore.vcproj/WebCore/WebCore.vcproj:
2076         * bridge/win/BrowserExtensionWin.cpp:
2077         (WebCore::BrowserExtensionWin::createNewWindow):
2078         * bridge/win/FrameWin.cpp:
2079         (WebCore::FrameWin::urlSelected):
2080         (WebCore::FrameWin::submitForm):
2081         (WebCore::FrameWin::createNewWindow):
2082         * bridge/win/FrameWin.h:
2083         * loader/loader.cpp:
2084         (WebCore::Loader::receivedResponse):
2085         * platform/win/GraphicsContextWin.cpp:
2086         (WebCore::GraphicsContext::getWindowsContext):
2087         (WebCore::GraphicsContext::releaseWindowsContext):
2088         * platform/win/TemporaryLinkStubs.cpp:
2089         (FrameWin::openURLRequest):
2090         (WebCore::ServeSynchronousRequest):
2091         (WebCore::CheckIfReloading):
2092         (WebCore::IsResponseURLEqualToURL):
2093         (WebCore::ResponseMIMEType):
2094         (WebCore::ResponseIsMultipart):
2095         (WebCore::CacheObjectExpiresTime):
2096         (CachedResource::setResponse):
2097         (CachedResource::setAllData):
2098         * rendering/RenderThemeWin.cpp:
2099         (WebCore::doneDrawing):
2100         (WebCore::RenderThemeWin::paintButton):
2101         (WebCore::RenderThemeWin::paintTextField):
2102
2103 2006-10-16  David Hyatt  <hyatt@apple.com>
2104
2105         Fix for bug 9347, positioned elements have the wrong containing block.  This is a change from CSS2 to
2106         CSS2.1.  In the absence of any other enclosing positioned elements, the containing block for a positioned
2107         element is the initial containing block (our RenderView).
2108
2109         Reviewed by mjs
2110
2111         Test cases added to fast/block/positioning for quirks and strict modes.
2112
2113         * rendering/RenderBlock.cpp:
2114         (WebCore::RenderBlock::lowestPosition):
2115         (WebCore::RenderBlock::rightmostPosition):
2116         (WebCore::RenderBlock::leftmostPosition):
2117         * rendering/RenderBox.cpp:
2118         (WebCore::RenderBox::containingBlockHeightForPositioned):
2119         (WebCore::RenderBox::calcAbsoluteVertical):
2120         * rendering/RenderObject.cpp:
2121         (WebCore::RenderObject::containingBlock):
2122         (WebCore::RenderObject::container):
2123
2124 2006-10-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2125
2126         Reviewed by Anders.
2127
2128         Misc Gdk/Linux build fixes.
2129
2130         * platform/gdk/BrowserExtensionGdk.h:
2131         * platform/gdk/FrameGdk.cpp:
2132         (WebCore::FrameGdk::submitForm):
2133         (WebCore::FrameGdk::urlSelected):
2134         * platform/gdk/FrameGdk.h:
2135         * platform/gdk/RenderPopupMenuGdk.cpp:
2136         (WebCore::PopupMenu::PopupMenu):
2137         (WebCore::PopupMenu::~PopupMenu):
2138         (WebCore::PopupMenu::clear):
2139         (WebCore::PopupMenu::populate):
2140         (WebCore::PopupMenu::show):
2141         (WebCore::PopupMenu::hide):
2142         (WebCore::PopupMenu::addSeparator):
2143         (WebCore::PopupMenu::addGroupLabel):
2144         (WebCore::PopupMenu::addOption):
2145         * platform/gdk/RenderPopupMenuGdk.h:
2146         * platform/gdk/RenderThemeGdk.cpp:
2147         * platform/gdk/RenderThemeGdk.h:
2148         (WebCore::RenderThemeGdk::RenderThemeGdk):
2149         * platform/gdk/TemporaryLinkStubs.cpp:
2150         (BrowserExtensionGdk::createNewWindow):
2151         (BrowserExtensionGdk::BrowserExtensionGdk):
2152         (BrowserExtensionGdk::setTypedIconURL):
2153         (BrowserExtensionGdk::setIconURL):
2154         (BrowserExtensionGdk::getHistoryLength):
2155         (WebCore::CheckIfReloading):
2156         (WebCore::CacheObjectExpiresTime):
2157         (WebCore::ResponseURL):
2158         (WebCore::IsResponseURLEqualToURL):
2159         (WebCore::ResponseIsMultipart):
2160         (WebCore::ResponseMIMEType):
2161         (WebCore::CachedResource::setResponse):
2162         (WebCore::CachedResource::setAllData):
2163         (FileChooser::disconnectUploadControl):
2164         * rendering/RenderTheme.h:
2165         * rendering/RenderThemeMac.h:
2166
2167 2006-10-15  Sam Weinig  <sam.weinig@gmail.com>
2168
2169         Reviewed by Mitz.
2170
2171         Fix for http://bugs.webkit.org/show_bug.cgi?id=11294
2172         Add getModifierState method to KeyboardEvent
2173
2174         * bindings/objc/DOMEvents.h:
2175         * bindings/objc/DOMEvents.mm:
2176         * bindings/objc/PublicDOMInterfaces.h:
2177         * dom/KeyboardEvent.cpp:
2178         (WebCore::KeyboardEvent::getModifierState):
2179         * dom/KeyboardEvent.h:
2180         * dom/KeyboardEvent.idl:
2181
2182 2006-10-15  Nikolas Zimmermann  <zimmermann@kde.org>
2183
2184         Reviewed and landed by ap.
2185
2186         Changed PlatformResponse handling for Qt. Don't just store
2187         a QString object containing the data but a new PlatformResponseQt struct
2188         containing data and url, and store it as pointer. This is compatible
2189         to the OS X handling and removes the Qt plaform specific hacks from
2190         CachedCSSStyleSheet, CachedResource & loader.
2191
2192         Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move
2193         all methods from TemporaryLinkStubs related to loading in there, and implement
2194         some like ServeSynchronousRequest (yay for xslt handling!).
2195
2196         * CMakeLists.txt:
2197         * loader/CachedCSSStyleSheet.cpp:
2198         (WebCore::CachedCSSStyleSheet::checkNotify):
2199         * loader/CachedResource.h:
2200         (WebCore::CachedResource::CachedResource):
2201         * loader/loader.cpp:
2202         (WebCore::Loader::receivedResponse):
2203         * platform/ResourceLoaderClient.h:
2204         * platform/ResourceLoaderInternal.h:
2205         * platform/qt/FrameQt.cpp:
2206         (WebCore::FrameQt::~FrameQt):
2207         (WebCore::FrameQt::createEmptyDocument):
2208         * platform/qt/FrameQt.h:
2209         (WebCore::QtFrame):
2210         * platform/qt/FrameQtClient.cpp:
2211         (WebCore::FrameQtClientDefault::setFrame):
2212         (WebCore::FrameQtClientDefault::openURL):
2213         (WebCore::FrameQtClientDefault::loadFinished):
2214         (WebCore::FrameQtClientDefault::receivedAllData):
2215         * platform/qt/FrameQtClient.h:
2216         * platform/qt/LoaderFunctionsQt.cpp: Added.
2217         (WebCore::ServeSynchronousRequest):
2218         (WebCore::NumberOfPendingOrLoadingRequests):
2219         (WebCore::CheckIfReloading):
2220         (WebCore::CheckCacheObjectStatus):
2221         (WebCore::IsResponseURLEqualToURL):
2222         (WebCore::ResponseURL):
2223         (WebCore::ResponseMIMEType):
2224         (WebCore::ResponseIsMultipart):
2225         (WebCore::CacheObjectExpiresTime):
2226         (WebCore::CachedResource::setResponse):
2227         (WebCore::CachedResource::setAllData):
2228         * platform/qt/ResourceLoaderManager.cpp:
2229         (WebCore::ResourceLoaderManager::remove):
2230         * platform/qt/ResourceLoaderQt.cpp:
2231         (WebCore::ResourceLoader::~ResourceLoader):
2232         (WebCore::ResourceLoader::start):
2233         (WebCore::ResourceLoader::assembleResponseHeaders):
2234         (WebCore::ResourceLoader::receivedResponse):
2235         * platform/qt/TemporaryLinkStubs.cpp:
2236
2237 2006-10-14  Rob Buis  <buis@kde.org>
2238
2239         Reviewed by Mitz.
2240
2241         http://bugs.webkit.org/show_bug.cgi?id=11217
2242         Cleanup svg coding style
2243
2244         Cleanup coding style in svg basic datastructure classes.
2245
2246         * ksvg2/svg/SVGAngle.cpp:
2247         (WebCore::SVGAngle::valueAsString):
2248         (WebCore::SVGAngle::context):
2249         (WebCore::SVGAngle::setContext):
2250         * ksvg2/svg/SVGAngle.h:
2251         * ksvg2/svg/SVGColor.cpp:
2252         * ksvg2/svg/SVGColor.h:
2253         * ksvg2/svg/SVGElement.cpp:
2254         (WebCore::SVGElement::ownerSVGElement):
2255         (WebCore::SVGElement::viewportElement):
2256         (WebCore::SVGElement::parseMappedAttribute):
2257         (WebCore::SVGElement::childShouldCreateRenderer):
2258         * ksvg2/svg/SVGElement.h:
2259         (WebCore::svg_dynamic_cast):
2260         * ksvg2/svg/SVGFitToViewBox.cpp:
2261         (WebCore::SVGFitToViewBox::parseViewBox):
2262         * ksvg2/svg/SVGFitToViewBox.h:
2263         * ksvg2/svg/SVGLangSpace.cpp:
2264         (WebCore::SVGLangSpace::parseMappedAttribute):
2265         * ksvg2/svg/SVGLangSpace.h:
2266         * ksvg2/svg/SVGLength.cpp:
2267         (WebCore::SVGLength::SVGLength):
2268         (WebCore::SVGLength::setValueAsString):
2269         (WebCore::SVGLength::dpi):
2270         (WebCore::SVGLength::updateValue):
2271         (WebCore::SVGLength::updateValueInSpecifiedUnits):
2272         (WebCore::SVGLength::context):
2273         (WebCore::SVGLength::setContext):
2274         * ksvg2/svg/SVGLength.h:
2275         * ksvg2/svg/SVGLengthList.cpp:
2276         * ksvg2/svg/SVGLengthList.h:
2277         * ksvg2/svg/SVGLocatable.cpp:
2278         (WebCore::SVGLocatable::nearestViewportElement):
2279         (WebCore::SVGLocatable::farthestViewportElement):
2280         (WebCore::SVGLocatable::getBBox):
2281         (WebCore::SVGLocatable::getCTM):
2282         (WebCore::SVGLocatable::getScreenCTM):
2283         * ksvg2/svg/SVGNumberList.cpp:
2284         * ksvg2/svg/SVGNumberList.h:
2285         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
2286         (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
2287         (WebCore::SVGPreserveAspectRatio::getCTM):
2288         * ksvg2/svg/SVGPreserveAspectRatio.h:
2289         * ksvg2/svg/SVGStringList.cpp:
2290         (WebCore::SVGStringList::reset):
2291         * ksvg2/svg/SVGStringList.h:
2292         * ksvg2/svg/SVGStylable.cpp:
2293         * ksvg2/svg/SVGStylable.h:
2294         * ksvg2/svg/SVGTests.cpp:
2295         (WebCore::SVGTests::requiredFeatures):
2296         (WebCore::SVGTests::requiredExtensions):
2297         (WebCore::SVGTests::systemLanguage):
2298         (WebCore::SVGTests::isValid):
2299         (WebCore::SVGTests::parseMappedAttribute):
2300         * ksvg2/svg/SVGTests.h:
2301         * ksvg2/svg/SVGTransformable.cpp:
2302         (WebCore::SVGTransformable::parseTransformAttribute):
2303         * ksvg2/svg/SVGTransformable.h:
2304         * ksvg2/svg/SVGURIReference.cpp:
2305         (WebCore::SVGURIReference::parseMappedAttribute):
2306         * ksvg2/svg/SVGZoomAndPan.cpp:
2307         (WebCore::SVGZoomAndPan::parseMappedAttribute):
2308         * ksvg2/svg/SVGZoomAndPan.h:
2309
2310 2006-10-15  Nikolas Zimmermann  <zimmermann@kde.org>
2311
2312         Reviewed by Oliver.
2313
2314         Implement some functions in FrameQt / ScrollViewQt.
2315
2316         Added comments what needs to be done in quite some places,
2317         marked some functions as no-ops.
2318
2319         * CMakeLists.txt:
2320         * platform/qt/FrameQt.cpp:
2321         (WebCore::FrameQt::FrameQt):
2322         (WebCore::FrameQt::runJavaScriptConfirm):
2323         (WebCore::FrameQt::locationbarVisible):
2324         (WebCore::FrameQt::createFrame):
2325         (WebCore::FrameQt::passSubframeEventToSubframe):
2326         (WebCore::FrameQt::menubarVisible):
2327         (WebCore::FrameQt::personalbarVisible):
2328         (WebCore::FrameQt::statusbarVisible):
2329         (WebCore::FrameQt::toolbarVisible):
2330         (WebCore::FrameQt::markedTextRange):
2331         (WebCore::FrameQt::lastEventIsMouseUp):
2332         (WebCore::FrameQt::openURLRequest):
2333         (WebCore::FrameQt::scheduleClose):
2334         (WebCore::FrameQt::unfocusWindow):
2335         (WebCore::FrameQt::focusWindow):
2336         (WebCore::FrameQt::overrideMediaType):
2337         (WebCore::FrameQt::runJavaScriptPrompt):
2338         (WebCore::FrameQt::bindingRootObject):
2339         (WebCore::FrameQt::addPluginRootObject):
2340         (WebCore::FrameQt::registerCommandForUndo):
2341         (WebCore::FrameQt::registerCommandForRedo):
2342         (WebCore::FrameQt::clearUndoRedoOperations):
2343         (WebCore::FrameQt::respondToChangedSelection):
2344         (WebCore::FrameQt::respondToChangedContents):
2345         (WebCore::FrameQt::shouldChangeSelection):
2346         (WebCore::FrameQt::canGoBackOrForward):
2347         (WebCore::FrameQt::canPaste):
2348         (WebCore::FrameQt::canRedo):
2349         (WebCore::FrameQt::canUndo):
2350         * platform/qt/FrameQt.h:
2351         * platform/qt/FrameQtClient.cpp:
2352         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
2353         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
2354         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
2355         (WebCore::FrameQtClientDefault::menubarVisible):
2356         (WebCore::FrameQtClientDefault::toolbarVisible):
2357         (WebCore::FrameQtClientDefault::statusbarVisible):
2358         (WebCore::FrameQtClientDefault::personalbarVisible):
2359         (WebCore::FrameQtClientDefault::locationbarVisible):
2360         * platform/qt/FrameQtClient.h:
2361         * platform/qt/ImageSourceQt.cpp:
2362         * platform/qt/RenderThemeQt.cpp:
2363         * platform/qt/ScrollViewQt.cpp:
2364         (WebCore::ScrollView::scrollPointRecursively):
2365         * platform/qt/TemporaryLinkStubs.cpp:
2366         (WebCore::CachedResource::setResponse):
2367         (WebCore::CachedResource::setAllData):
2368
2369 2006-10-14  David Harrison  <harrison@apple.com>
2370
2371         Reviewed by Geoff.
2372
2373         <rdar://problem/4775213> REGRESSION: Can't from tab from last link on the page to URL address field
2374         <rdar://problem/4783926> REGRESSION: Typing tab key enters no text
2375
2376         The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless
2377         of whether frame->view()->advanceFocus() actually changed the focus.
2378
2379         Trivial fix is to preventDefault() only if advanceFocus() returns true.
2380
2381         * No test is possible because DumpRenderTree sets the WebView preference to
2382         tab to links, and that preference cannot be changed dynamically after
2383         the webview is initialized. Also, the "tab from last link" is not testable
2384         because DumpRenderTree uses the WebView for the whole window, so tabs can't
2385         shift focus out of the WebView regardless.
2386
2387         * dom/EventTargetNode.cpp:
2388         (WebCore::EventTargetNode::defaultEventHandler):
2389
2390 2006-10-14  Nikolas Zimmermann  <zimmermann@kde.org>
2391
2392         Reviewed by Mitz.
2393
2394         Fix Qt/Linux build & some little fixes:
2395
2396         - Adapt to Maciej's FrameLoadRequest changes.
2397         - Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
2398         - Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
2399         - Fix CacheObjectExpiresTime/ResponseIsMultipart signature.
2400
2401         * loader/CachedCSSStyleSheet.cpp:
2402         (WebCore::CachedCSSStyleSheet::checkNotify):
2403         * loader/CachedResource.h:
2404         (WebCore::CachedResource::CachedResource):
2405         * loader/loader.cpp:
2406         (WebCore::Loader::receivedAllData):
2407         (WebCore::Loader::receivedResponse):
2408         * platform/qt/BrowserExtensionQt.cpp:
2409         (WebCore::BrowserExtensionQt::createNewWindow):
2410         * platform/qt/BrowserExtensionQt.h:
2411         * platform/qt/FrameQt.cpp:
2412         (WebCore::FrameQt::submitForm):
2413         (WebCore::FrameQt::urlSelected):
2414         (WebCore::FrameQt::openURLRequest):
2415         * platform/qt/FrameQt.h:
2416         * platform/qt/GraphicsContextQt.cpp:
2417         (WebCore::GraphicsContext::setURLForRect):
2418         * platform/qt/TemporaryLinkStubs.cpp:
2419         (WebCore::CacheObjectExpiresTime):
2420         (WebCore::ResponseIsMultipart):
2421         (WebCore::CachedResource::setResponse):
2422         (WebCore::CachedResource::setAllData):
2423
2424 2006-10-14  David Carson  <dacarson@gmail.com>
2425
2426         Reviewed by Maciej.
2427
2428         Fix: http://bugs.webkit.org/show_bug.cgi?id=11257
2429         Removed Mac platform dependance, changed WebCore functions to
2430         use PlatformResponse/PlatformData rather than NSURLResponse/
2431         NSData. 
2432
2433         * loader/CachedCSSStyleSheet.cpp:
2434         (WebCore::CachedCSSStyleSheet::checkNotify):
2435         * loader/CachedImage.cpp:
2436         (WebCore::CachedImage::createImage):
2437         * loader/CachedResource.cpp:
2438         (WebCore::CachedResource::~CachedResource):
2439         * loader/CachedResource.h:
2440         (WebCore::CachedResource::CachedResource):
2441         (WebCore::CachedResource::response):
2442         (WebCore::CachedResource::allData):
2443         * loader/LoaderFunctions.h:
2444         * loader/loader.cpp:
2445         (WebCore::Loader::receivedResponse):
2446         * loader/mac/LoaderFunctionsMac.mm:
2447         (WebCore::ResponseMIMEType):
2448         (WebCore::ResponseIsMultipart):
2449         (WebCore::CacheObjectExpiresTime):
2450         (WebCore::CachedResource::setResponse):
2451         (WebCore::CachedResource::setAllData):
2452         * platform/qt/TemporaryLinkStubs.cpp:
2453         (WebCore::CacheObjectExpiresTime):
2454         (WebCore::ResponseIsMultipart):
2455         (WebCore::ResponseMIMEType):
2456         (WebCore::CachedResource::setResponse):
2457         (WebCore::CachedResource::setAllData):
2458         * platform/win/TemporaryLinkStubs.cpp:
2459         (WebCore::CacheObjectExpiresTime):
2460         (WebCore::ResponseIsMultipart):
2461         (WebCore::ResponseMIMEType):
2462         (WebCore::CachedResource::setResponse):
2463         (WebCore::CachedResource::setAllData):
2464
2465 2006-10-14  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2466
2467         Reviewed by Maciej.
2468
2469         Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
2470         Pure virtual classes require non-pure destructor, who knew.
2471
2472         Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
2473         so that other platforms can also use CURL, if they wish.
2474
2475         Silence compiler warning about unused variable in SharedTimerLinux.cpp
2476
2477         * platform/ResourceLoaderInternal.h:
2478         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2479         * platform/gdk/FrameGdk.h:
2480         (WebCore::FrameGdkClient::~FrameGdkClient):
2481         * platform/gdk/ResourceLoaderManager.cpp:
2482         (WebCore::ResourceLoaderManager::downloadTimerCallback):
2483         * platform/gdk/SharedTimerLinux.cpp:
2484         (WebCore::stopSharedTimer):
2485
2486 2006-10-13  Beth Dakin  <bdakin@apple.com>
2487
2488         Reviewed by Geoff.
2489
2490         Build fix from my last check-in. Make hasOutlineAnnotation() non-
2491         inline so that we don't have to include Document.h in 
2492         RenderObject.h
2493         Doing so causes a build failure in WebKit, and it probably isn't a 
2494         good idea anyway.
2495
2496         * rendering/RenderObject.cpp:
2497         (WebCore::RenderObject::hasOutlineAnnotation):
2498         * rendering/RenderObject.h:
2499         (WebCore::RenderObject::hasOutline):
2500
2501 2006-10-13  Beth Dakin  <bdakin@apple.com>
2502
2503         Patch written mostly by Ken Kraisler, but also by me.
2504
2505         Reviewed by Hyatt.
2506
2507         Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
2508         problem/3391162> PDF created by printing should have live 
2509         hyperlinks
2510
2511         * platform/GraphicsContext.cpp:
2512         (WebCore::GraphicsContext::focusRingBoundingRect):
2513         * platform/GraphicsContext.h:
2514         * platform/cairo/GraphicsContextCairo.cpp:
2515         (WebCore::GraphicsContext::setURLForRect):
2516         * platform/cg/GraphicsContextCG.cpp:
2517         (WebCore::GraphicsContext::setURLForRect): Implement method to add 
2518         URL link to PDF document.
2519         * rendering/InlineFlowBox.cpp:
2520         (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of 
2521         querying the outline width
2522         * rendering/RenderBlock.cpp:
2523         (WebCore::RenderBlock::paintObject): Same as above.
2524         * rendering/RenderFlow.cpp:
2525         (WebCore::RenderFlow::paintLines): Call the new paintOutline()
2526         (WebCore::RenderFlow::paintOutline): Take care of focus ring and 
2527         pdf url rects, and outline painting.
2528         * rendering/RenderFlow.h:
2529         * rendering/RenderObject.cpp:
2530         (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF 
2531         link to a rectanglular region.
2532         (WebCore::RenderObject::paintOutline): Take care of pdf rects as 
2533         well as focus ring painting.
2534         * rendering/RenderObject.h:
2535         (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the 
2536         element is a link and we are printing.
2537         (WebCore::RenderObject::hasOutline): Returns true is the style has 
2538         an outline and hasOutlineAnnotation() is true.
2539         * rendering/RenderStyle.h:
2540         (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is 
2541         greater than 0 and outlineStyle is greater than BHIDDEN.
2542
2543 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
2544
2545         Reviewed by ggaren and harrison
2546         
2547         <rdar://problem/4744008>
2548         9A270: Mail crashes when I try to paste large items from Safari
2549
2550         * editing/ReplaceSelectionCommand.cpp:
2551         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
2552         Even though we put nodes in the hash map in pre-order, they don't necessary
2553         come out of the iterator that way.  If a node is a redundant style span
2554         and one of its pruned ancestors comes off the hash map after it, and that
2555         ancestor is a redundant style span or font tag, we will try to remove it
2556         even though it has already been removed and we'll crash.
2557         The test case added with the fix depends on our hash map implementation
2558         because it requires that a particular redundant style span come out of 
2559         the iterator before its parent. So, it may eventually not provide 
2560         coverage for the fix.
2561
2562 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
2563
2564         Reviewed by Darin.
2565
2566         - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
2567
2568         * WebCore.xcodeproj/project.pbxproj:
2569         * bindings/js/kjs_window.cpp:
2570         (KJS::createNewWindow):
2571         (KJS::WindowFunc::callAsFunction):
2572         * bridge/BrowserExtension.h:
2573         * bridge/mac/BrowserExtensionMac.h:
2574         * bridge/mac/BrowserExtensionMac.mm:
2575         (WebCore::BrowserExtensionMac::createNewWindow):
2576         * bridge/mac/FrameMac.h:
2577         * bridge/mac/FrameMac.mm:
2578         (WebCore::FrameMac::submitForm):
2579         (WebCore::FrameMac::openURLRequest):
2580         (WebCore::FrameMac::urlSelected):
2581         * bridge/win/BrowserExtensionWin.h:
2582         * page/Frame.cpp:
2583         (WebCore::Frame::changeLocation):
2584         (WebCore::Frame::urlSelected):
2585         (WebCore::Frame::requestFrame):
2586         (WebCore::Frame::submitForm):
2587         * page/Frame.h:
2588         * page/FrameLoadRequest.h: Added.
2589         (WebCore::FrameLoadRequest::FrameLoadRequest):
2590         (WebCore::FrameLoadRequest::lockHistory):
2591         (WebCore::FrameLoadRequest::setLockHistory):
2592         * page/ResourceRequest.h:
2593         (WebCore::ResourceRequest::ResourceRequest):
2594
2595 2006-10-13  John Sullivan  <sullivan@apple.com>
2596
2597         Reviewed by Maciej
2598
2599         * loader/mac/WebFrameLoader.mm:
2600         (-[WebFrameLoader loadDocumentLoader:]):
2601         Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can
2602         happen when loading a page during a decidePolicyForNavigationAction callback.
2603
2604 2006-10-13  Dave Hyatt  <hyatt@apple.com>
2605
2606         Transparency layer work.
2607
2608         Reviewed by aroben
2609
2610         * platform/GraphicsContext.h:
2611         * platform/cg/GraphicsContextCG.cpp:
2612         (WebCore::GraphicsContext::beginTransparencyLayer):
2613         (WebCore::GraphicsContext::endTransparencyLayer):
2614         * platform/cg/GraphicsContextPlatformPrivate.h:
2615         (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
2616         (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
2617
2618 2006-10-13  Rob Buis  <buis@kde.org>
2619
2620         Reviewed by Mitz.
2621
2622         http://bugs.webkit.org/show_bug.cgi?id=11217
2623         Cleanup svg coding style
2624
2625         Cleanup coding style in svg paint server classes.
2626
2627         * ksvg2/svg/SVGGradientElement.cpp:
2628         (WebCore::SVGGradientElement::SVGGradientElement):
2629         (WebCore::SVGGradientElement::parseMappedAttribute):
2630         (WebCore::SVGGradientElement::notifyAttributeChange):
2631         (WebCore::SVGGradientElement::canvasResource):
2632         (WebCore::SVGGradientElement::rebuildStops):
2633         * ksvg2/svg/SVGGradientElement.h:
2634         * ksvg2/svg/SVGLinearGradientElement.cpp:
2635         (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
2636         (WebCore::SVGLinearGradientElement::parseMappedAttribute):
2637         (WebCore::SVGLinearGradientElement::buildGradient):
2638         * ksvg2/svg/SVGLinearGradientElement.h:
2639         * ksvg2/svg/SVGPatternElement.cpp:
2640         (WebCore::SVGPatternElement::SVGPatternElement):
2641         (WebCore::SVGPatternElement::parseMappedAttribute):
2642         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
2643         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
2644         (WebCore::SVGPatternElement::notifyClientsToRepaint):
2645         (WebCore::SVGPatternElement::notifyAttributeChange):
2646         (WebCore::SVGPatternElement::canvasResource):
2647         (WebCore::SVGPatternElement::getCTM):
2648         * ksvg2/svg/SVGPatternElement.h:
2649         (WebCore::SVGPatternElement::rendererIsNeeded):
2650         * ksvg2/svg/SVGRadialGradientElement.cpp:
2651         (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
2652         (WebCore::SVGRadialGradientElement::parseMappedAttribute):
2653         (WebCore::SVGRadialGradientElement::buildGradient):
2654         * ksvg2/svg/SVGRadialGradientElement.h:
2655         * ksvg2/svg/SVGStopElement.cpp:
2656         (WebCore::SVGStopElement::SVGStopElement):
2657         (WebCore::SVGStopElement::parseMappedAttribute):
2658         * ksvg2/svg/SVGStopElement.h:
2659
2660 2006-10-13  Geoffrey Garen  <ggaren@apple.com>
2661
2662         Reviewed by Darin, John.
2663
2664         - Merged more frame and iframe code
2665         - Fixed a bug where iframes returned incorrect values for renderer-dependent 
2666         properties during javascript: loads because they didn't have renderers at 
2667         load time
2668         
2669         PLT insists this is a small performance win. Don't believe its lies.
2670
2671         * bindings/js/kjs_html.cpp:
2672         (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to
2673         width and height, for consistency with the rest of the DOM.
2674         * dom/ContainerNode.cpp:
2675         (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback
2676         queue that gets drained after the render tree is fully constructed. Currently,
2677         this is only used for frame loading.
2678         (WebCore::ContainerNode::attach):
2679         * dom/ContainerNode.h:
2680         * html/HTMLFrameElement.cpp:
2681         (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from
2682         attach() because loading iframes during attach() causes a crash. 
2683         Moved frame loading logic into insertedIntoDocument(). That's a more 
2684         logical place for it because  document insertion is what 
2685         triggers frame loading. Made frame loading a post-attach callback, instead
2686         of an immediate action, to fix the incorrect values bug.
2687         (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be
2688         in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon 
2689         require this call, once I remove the call from WebKit.
2690         (WebCore::HTMLFrameElement::setLocation):
2691         (WebCore::HTMLFrameElement::width):
2692         (WebCore::HTMLFrameElement::height):
2693         * html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary
2694         killing of puppies.
2695         * html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement
2696         (WebCore::HTMLIFrameElement::rendererIsNeeded):
2697         (WebCore::HTMLIFrameElement::createRenderer):
2698         (WebCore::HTMLIFrameElement::insertedIntoDocument):
2699         (WebCore::HTMLIFrameElement::removedFromDocument):
2700         (WebCore::HTMLIFrameElement::attach):
2701         * page/FrameView.h: Removed unused method.
2702
2703 2006-10-13  David Harrison  <harrison@apple.com>
2704
2705         Reviewed by Justin.
2706
2707         <rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
2708
2709         Tests added or changed:
2710         * editing/style/style-boundary-005.html: Added. Matches steps from bug.
2711         * editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
2712         * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
2713         * editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
2714         * editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
2715
2716         * dom/Text.cpp:
2717         (WebCore::Text::splitText):
2718         Comment changes.
2719         
2720         * editing/ApplyStyleCommand.cpp:
2721         (WebCore::isUnstyledStyleSpan):
2722         Renamed from isEmptyStyleSpan.
2723         
2724         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
2725         Rename emptySpans local to unstyledSpans.
2726         
2727         (WebCore::dummySpanAncestorForNode):
2728         New. To locate Apple style span created when splitting a text node.
2729         
2730         (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
2731         Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
2732         of dummy span's parents, rather than traversing up from start and
2733         end locations. Old algorithm would miss empty spans in the bug case.
2734         
2735         (WebCore::ApplyStyleCommand::applyInlineStyle):
2736         Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().
2737         
2738         (WebCore::ApplyStyleCommand::removeCSSStyle):
2739         Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().
2740         
2741         (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
2742         Comment changes.
2743         
2744         * editing/ApplyStyleCommand.h:
2745         Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().
2746           
2747         * editing/ReplaceSelectionCommand.cpp:
2748         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
2749         Allow for Apple style span to be unstyled, because old email may have this in the DOM.
2750         Use !node->hasChildNodes() instead of !node->firstChild().
2751         
2752         * editing/SplitTextNodeCommand.cpp:
2753         (WebCore::SplitTextNodeCommand::doApply):
2754         Comment changes.
2755         
2756         * rendering/RenderTreeAsText.cpp:
2757         (WebCore::isEmptyOrUnstyledAppleStyleSpan):
2758         (WebCore::operator<<):
2759         Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM
2760
2761 2006-10-13  Nikolas Zimmermann  <zimmermann@kde.org>
2762
2763         Reviewed by Eric.
2764
2765         Fix Qt/Linux build after Adele's popup menu changes.
2766
2767         * CMakeLists.txt:
2768         * platform/qt/FileChooserQt.cpp:
2769         (WebCore::FileChooser::disconnectUploadControl):
2770         * platform/qt/PopupMenuQt.cpp: Added.
2771         (WebCore::PopupMenu::PopupMenu):
2772         (WebCore::PopupMenu::~PopupMenu):
2773         (WebCore::PopupMenu::clear):
2774         (WebCore::PopupMenu::populate):
2775         (WebCore::PopupMenu::show):
2776         (WebCore::PopupMenu::hide):
2777         (WebCore::PopupMenu::addSeparator):
2778         (WebCore::PopupMenu::addGroupLabel):
2779         (WebCore::PopupMenu::addOption):
2780         * platform/qt/RenderPopupMenuQt.cpp: Removed.
2781         * platform/qt/RenderPopupMenuQt.h: Removed.
2782         * platform/qt/RenderThemeQt.cpp:
2783
2784 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
2785
2786         Reviewed by Darin.
2787
2788         fixed build failure 
2789
2790         * WebCore.xcodeproj/project.pbxproj:
2791         * loader/mac/WebFrameLoader.mm:
2792
2793 2006-10-13  Darin Adler  <darin@apple.com>
2794
2795         Reviewed by Adele.
2796
2797         - converted WebFormState from Objective-C to C++
2798
2799         * WebCore.exp: Added a new symbol, changed one symbol from C to C++.
2800
2801         * WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project".
2802         Added UChar.h and FrameLoaderTypes.h.
2803
2804         * loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.
2805
2806         * loader/mac/WebFormState.h: Converted class to C++.
2807         * loader/mac/WebFormState.mm: Ditto.
2808
2809         * loader/mac/WebFrameLoader.h:
2810         * loader/mac/WebFrameLoader.mm:
2811         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2812         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
2813         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
2814         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
2815         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
2816         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
2817         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
2818         (-[WebFrameLoader continueAfterNavigationPolicy:]):
2819         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2820         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2821         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2822         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2823         Changed Objective-C WebFormState uses to C++ WebCore::FormState.
2824
2825 2006-10-13  Adele Peterson  <adele@apple.com>
2826
2827         Reviewed by Maciej.
2828
2829         - Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color
2830
2831         * rendering/RenderListBox.cpp:
2832         (WebCore::RenderListBox::paintItemForeground):
2833         * rendering/RenderTheme.cpp:
2834         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
2835         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
2836         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
2837         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
2838         * rendering/RenderThemeMac.h:
2839         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
2840
2841 2006-10-13  Rob Buis  <buis@kde.org>
2842
2843         Reviewed by Mitz.
2844
2845         http://bugs.webkit.org/show_bug.cgi?id=11217
2846         Cleanup svg coding style
2847
2848         Cleanup coding style in svg structure classes.
2849
2850         * ksvg2/svg/SVGDefsElement.cpp:
2851         (WebCore::SVGDefsElement::SVGDefsElement):
2852         * ksvg2/svg/SVGDefsElement.h:
2853         * ksvg2/svg/SVGDescElement.cpp:
2854         (WebCore::SVGDescElement::SVGDescElement):
2855         * ksvg2/svg/SVGDescElement.h:
2856         * ksvg2/svg/SVGDocument.cpp:
2857         * ksvg2/svg/SVGDocument.h:
2858         * ksvg2/svg/SVGElementInstance.cpp:
2859         (WebCore::SVGElementInstance::SVGElementInstance):
2860         (WebCore::SVGElementInstance::correspondingElement):
2861         (WebCore::SVGElementInstance::correspondingUseElement):
2862         (WebCore::SVGElementInstance::parentNode):
2863         (WebCore::SVGElementInstance::childNodes):
2864         (WebCore::SVGElementInstance::previousSibling):
2865         (WebCore::SVGElementInstance::nextSibling):
2866         (WebCore::SVGElementInstance::firstChild):
2867         (WebCore::SVGElementInstance::lastChild):
2868         * ksvg2/svg/SVGElementInstance.h:
2869         * ksvg2/svg/SVGElementInstanceList.cpp:
2870         * ksvg2/svg/SVGElementInstanceList.h:
2871         * ksvg2/svg/SVGGElement.cpp:
2872         (WebCore::SVGGElement::SVGGElement):
2873         (WebCore::SVGGElement::parseMappedAttribute):
2874         (WebCore::SVGDummyElement::SVGDummyElement):
2875         * ksvg2/svg/SVGGElement.h:
2876         (WebCore::SVGGElement::rendererIsNeeded):
2877         * ksvg2/svg/SVGImageElement.cpp:
2878         (WebCore::SVGImageElement::createRenderer):
2879         * ksvg2/svg/SVGImageElement.h:
2880         * ksvg2/svg/SVGSVGElement.cpp:
2881         (WebCore::SVGSVGElement::SVGSVGElement):
2882         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
2883         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
2884         (WebCore::SVGSVGElement::currentScale):
2885         (WebCore::SVGSVGElement::setCurrentScale):
2886         (WebCore::SVGSVGElement::currentTranslate):
2887         (WebCore::SVGSVGElement::parseMappedAttribute):
2888         (WebCore::SVGSVGElement::suspendRedraw):
2889         (WebCore::SVGSVGElement::unsuspendRedraw):
2890         (WebCore::SVGSVGElement::unsuspendRedrawAll):
2891         (WebCore::SVGSVGElement::forceRedraw):
2892         (WebCore::SVGSVGElement::getIntersectionList):
2893         (WebCore::SVGSVGElement::getEnclosureList):
2894         (WebCore::SVGSVGElement::checkIntersection):
2895         (WebCore::SVGSVGElement::checkEnclosure):
2896         (WebCore::SVGSVGElement::deselectAll):
2897         (WebCore::SVGSVGElement::createSVGLength):
2898         (WebCore::SVGSVGElement::createSVGAngle):
2899         (WebCore::SVGSVGElement::createSVGMatrix):
2900         (WebCore::SVGSVGElement::createSVGTransform):
2901         (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
2902         (WebCore::SVGSVGElement::getCTM):
2903         (WebCore::SVGSVGElement::getScreenCTM):
2904         (WebCore::SVGSVGElement::setCurrentTime):
2905         * ksvg2/svg/SVGSVGElement.h:
2906         (WebCore::SVGSVGElement::rendererIsNeeded):
2907         * ksvg2/svg/SVGSwitchElement.cpp:
2908         (WebCore::SVGSwitchElement::SVGSwitchElement):
2909         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
2910         * ksvg2/svg/SVGSwitchElement.h:
2911         (WebCore::SVGSwitchElement::rendererIsNeeded):
2912         * ksvg2/svg/SVGSymbolElement.cpp:
2913         (WebCore::SVGSymbolElement::SVGSymbolElement):
2914         (WebCore::SVGSymbolElement::parseMappedAttribute):
2915         * ksvg2/svg/SVGSymbolElement.h:
2916         (WebCore::SVGSymbolElement::shouldAttachChild):
2917         * ksvg2/svg/SVGTitleElement.cpp:
2918         (WebCore::SVGTitleElement::SVGTitleElement):
2919         * ksvg2/svg/SVGTitleElement.h:
2920         * ksvg2/svg/SVGUseElement.cpp:
2921         (WebCore::SVGUseElement::parseMappedAttribute):
2922         (WebCore::SVGUseElement::closeRenderer):
2923         * ksvg2/svg/SVGUseElement.h:
2924         (WebCore::SVGUseElement::rendererIsNeeded):
2925
2926 2006-10-12  Adele Peterson  <adele@apple.com>
2927
2928         Reviewed by Anders.
2929
2930         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11172
2931           REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
2932         
2933          Test: fast/forms/listbox-width-change.html
2934
2935         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
2936           When the options change, call setNeedsLayoutAndMinMaxRecalc.
2937
2938 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
2939
2940         Reviewed by Oliver.
2941
2942         - moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies
2943
2944         * WebCore.xcodeproj/project.pbxproj:
2945         * bridge/mac/WebCoreFrameBridge.h:
2946         * bridge/mac/WebCoreFrameBridge.mm:
2947         (stringByCollapsingNonPrintingCharacters):
2948         (-[WebCoreFrameBridge setTitle:]):
2949         (-[WebCoreFrameBridge didFirstLayout]):
2950         (-[WebCoreFrameBridge notifyIconChanged:]):
2951         (-[WebCoreFrameBridge originalRequestURL]):
2952         (-[WebCoreFrameBridge isLoadTypeReload]):
2953         (-[WebCoreFrameBridge frameDetached]):
2954         (-[WebCoreFrameBridge tokenizerProcessedData]):
2955         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
2956         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
2957         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
2958         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
2959         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
2960         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
2961         (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
2962         (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2963         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2964         (-[WebCoreFrameBridge incomingReferrer]):
2965         (-[WebCoreFrameBridge isReloading]):
2966         (-[WebCoreFrameBridge handledOnloadEvents]):
2967         (-[WebCoreFrameBridge mainResourceURLResponse]):
2968         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
2969         * loader/mac/LoaderNSURLExtras.h:
2970         * loader/mac/LoaderNSURLRequestExtras.h: Added.
2971         * loader/mac/LoaderNSURLRequestExtras.m: Added.
2972         (isConditionalRequest):
2973         (setHTTPReferrer):
2974         * loader/mac/WebFrameLoader.mm:
2975         * loader/mac/WebSubresourceLoader.mm:
2976
2977 2006-10-12  Adele Peterson  <adele@apple.com>
2978
2979         RS by Geoff.
2980
2981         Renamed menuListIsDetaching to disconnectMenuList, 
2982         uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.  
2983         These names match similar methods in WebCore a little better.
2984
2985         * platform/FileChooser.h:
2986         * platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
2987         * platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]):
2988         (WebCore::FileChooser::disconnectUploadControl):
2989         * platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
2990         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
2991         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):
2992
2993 2006-10-12  Adele Peterson  <adele@apple.com>
2994
2995         Reviewed by Maciej.
2996
2997         WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
2998
2999         Added private delegate method for clients that want access to a PopupMenu's NSMenu.
3000
3001         * bridge/mac/FrameMac.h:
3002         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
3003         * bridge/mac/WebCoreFrameBridge.h:
3004
3005         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.
3006
3007 2006-10-12  Adele Peterson  <adele@apple.com>
3008
3009         Reviewed by Alice.
3010
3011         - Fix for <rdar://problem/4707372> 
3012           After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu
3013
3014         * platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
3015         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
3016         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up,
3017           in case the RenderMenuList goes away.  Also, checks the pointer to the menu list immediately afterwards.
3018
3019 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
3020
3021         Reviewed by Maciej.
3022
3023         Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
3024         document.open(); document.write(..); and NO document.close(). On the Qt platform this
3025         leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
3026         DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.
3027
3028         Hmpf, this took me nine hours to debug today.
3029         Result: Couldn't find the real fix, going for a workaround for now.
3030         
3031         540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.
3032
3033         * platform/qt/FrameQt.cpp:
3034         (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
3035         * platform/qt/FrameQtClient.cpp:
3036         (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().
3037
3038 2006-10-12  Adam Roben  <aroben@apple.com>
3039
3040         Reviewed by Adele.
3041
3042         Move popup menu code out of rendering/ and into platform/.
3043         RenderPopupMenu becomes PopupMenu, the
3044         RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
3045         virtual methods go away, RenderTheme gets to stop worrying about popup
3046         menus, PopupMenu becomes ref-counted, and everyone becomes happy.
3047
3048         * WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
3049         * WebCore.xcodeproj/project.pbxproj: Ditto.
3050         * html/HTMLSelectElement.cpp: Remove unnecessary #include.
3051         * platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp.
3052         Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate
3053         from RenderMenuList::showPopup/hidePopup.
3054         (WebCore::PopupMenu::create): New static creation method to hand back a
3055         PassRefPtr<PopupMenu>.
3056         (WebCore::PopupMenu::addItems): This platform-independent method should
3057         be called by PopupMenu::populate when the platform-specific
3058         implementation is ready to receive the menu items. Fixed an ASSERT
3059         while I was at it.
3060         * platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more
3061         need for virtual methods.
3062         (WebCore::PopupMenu::wasClicked):
3063         (WebCore::PopupMenu::setWasClicked):
3064         (WebCore::PopupMenu::popupHandle):
3065         * platform/mac/PopupMenuMac.mm: Moved from
3066         rendering/RenderPopupMenuMac.mm. Much renaming ensues.
3067         (WebCore::PopupMenu::PopupMenu):
3068         (WebCore::PopupMenu::~PopupMenu):
3069         (WebCore::PopupMenu::clear):
3070         (WebCore::PopupMenu::populate):
3071         (WebCore::PopupMenu::show):
3072         (WebCore::PopupMenu::hide):
3073         (WebCore::PopupMenu::addSeparator):
3074         (WebCore::PopupMenu::addGroupLabel): Since we don't have our own
3075         RenderStyle anymore, just pick up the style from our RenderMenuList.
3076         (WebCore::PopupMenu::addOption): Ditto.
3077         * platform/win/TemporaryLinkStubs.cpp: Rename-fest.
3078         (PopupMenu::PopupMenu):
3079         (PopupMenu::~PopupMenu):
3080         (PopupMenu::clear):
3081         (PopupMenu::populate):
3082         (PopupMenu::show):
3083         (PopupMenu::hide):
3084         (PopupMenu::addSeparator):
3085         (PopupMenu::addGroupLabel):
3086         (PopupMenu::addOption):
3087         * rendering/RenderMenuList.cpp:
3088         (WebCore::RenderMenuList::~RenderMenuList):
3089         (WebCore::RenderMenuList::showPopup): Use nice new simple
3090         PopupMenu::create to make the popup.
3091         (WebCore::RenderMenuList::hidePopup):
3092         * rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a
3093         RenderPopupMenu*.
3094         (WebCore::RenderMenuList::popup):
3095         * rendering/RenderPopupMenu.cpp: Removed.
3096         * rendering/RenderPopupMenu.h: Removed.
3097         * rendering/RenderPopupMenuMac.h: Removed.
3098         * rendering/RenderPopupMenuMac.mm: Removed.
3099         * rendering/RenderPopupMenuWin.h: Removed.
3100         * rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
3101         * rendering/RenderTheme.h: Ditto.
3102         * rendering/RenderThemeMac.h: Ditto.
3103         * rendering/RenderThemeMac.mm: Ditto.
3104         * rendering/RenderThemeWin.cpp: Ditto.
3105         * rendering/RenderThemeWin.h: Ditto.
3106
3107 2006-10-12  Adele Peterson  <adele@apple.com>
3108
3109         Reviewed by Dave Harrison.
3110
3111         - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
3112
3113         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
3114         Make subtree layouts work for textareas as well as text fields.
3115
3116 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
3117
3118         Reviewed by MacDome.
3119
3120         Finally found a way to remove our begin() trickery in FrameQt.
3121         The (probably misnamed) Frame::setEncoding() function automatically
3122         calls Frame::receivedFirstData() which calls being on the working
3123         url, which has been passed to didOpenUrl(). Took me some hours
3124         to figure out that the missing charset logic, forced us to do hacks.
3125
3126         * platform/ResourceLoader.h:
3127         * platform/ResourceLoaderInternal.h:
3128         * platform/qt/FrameQt.cpp:
3129         (WebCore::FrameQt::tokenizerProcessedData):
3130         * platform/qt/FrameQt.h:
3131         * platform/qt/FrameQtClient.cpp:
3132         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
3133         (WebCore::FrameQtClientDefault::openURL):
3134         (WebCore::FrameQtClientDefault::submitForm):
3135         (WebCore::FrameQtClientDefault::receivedData):
3136         (WebCore::FrameQtClientDefault::receivedAllData):
3137         * platform/qt/FrameQtClient.h:
3138         * platform/qt/ResourceLoaderManager.cpp:
3139         (WebCore::ResourceLoaderManager::slotData):
3140         (WebCore::ResourceLoaderManager::slotMimetype):
3141         (WebCore::ResourceLoaderManager::slotResult):
3142         (WebCore::ResourceLoaderManager::remove):
3143         * platform/qt/ResourceLoaderQt.cpp:
3144         (WebCore::ResourceLoader::retrieveCharset):
3145         (WebCore::ResourceLoader::extractCharsetFromHeaders):
3146
3147 2006-10-12  Adam Roben  <aroben@apple.com>
3148
3149         Reviewed by Hyatt.
3150
3151         Bandaid-ing a null-dereference crash until a real fix is made.
3152
3153         * page/FrameView.cpp:
3154         (WebCore::FrameView::windowClipRect):
3155
3156 2006-10-12  Rob Buis  <buis@kde.org>
3157
3158         Reviewed by Mitz.
3159
3160         http://bugs.webkit.org/show_bug.cgi?id=11217
3161         Cleanup svg coding style
3162
3163         Cleanup coding style in svg text classes.
3164
3165         * ksvg2/svg/SVGTRefElement.cpp:
3166         (WebCore::SVGTRefElement::SVGTRefElement):
3167         (WebCore::SVGTRefElement::updateReferencedText):
3168         (WebCore::SVGTRefElement::parseMappedAttribute):
3169         (WebCore::SVGTRefElement::childShouldCreateRenderer):
3170         (WebCore::SVGTRefElement::createRenderer):
3171         * ksvg2/svg/SVGTRefElement.h:
3172         (WebCore::SVGTRefElement::rendererIsNeeded):
3173         * ksvg2/svg/SVGTSpanElement.cpp:
3174         (WebCore::SVGTSpanElement::SVGTSpanElement):
3175         (WebCore::SVGTSpanElement::childShouldCreateRenderer):
3176         (WebCore::SVGTSpanElement::createRenderer):
3177         * ksvg2/svg/SVGTSpanElement.h:
3178         (WebCore::SVGTSpanElement::rendererIsNeeded):
3179         * ksvg2/svg/SVGTextContentElement.cpp:
3180         (WebCore::SVGTextContentElement::SVGTextContentElement):
3181         (WebCore::SVGTextContentElement::parseMappedAttribute):
3182         * ksvg2/svg/SVGTextContentElement.h:
3183         * ksvg2/svg/SVGTextElement.cpp:
3184         (WebCore::SVGTextElement::SVGTextElement):
3185         (WebCore::SVGTextElement::localMatrix):
3186         (WebCore::SVGTextElement::parseMappedAttribute):
3187         (WebCore::SVGTextElement::updateLocalTransform):
3188         (WebCore::SVGTextElement::nearestViewportElement):
3189         (WebCore::SVGTextElement::farthestViewportElement):
3190         (WebCore::SVGTextElement::getScreenCTM):
3191         (WebCore::SVGTextElement::getCTM):
3192         (WebCore::SVGTextElement::createRenderer):
3193         (WebCore::SVGTextElement::childShouldCreateRenderer):
3194         * ksvg2/svg/SVGTextElement.h:
3195         (WebCore::SVGTextElement::getTransformToElement):
3196         (WebCore::SVGTextElement::rendererIsNeeded):
3197         * ksvg2/svg/SVGTextPositioningElement.cpp:
3198         (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
3199         (WebCore::SVGTextPositioningElement::parseMappedAttribute):
3200         * ksvg2/svg/SVGTextPositioningElement.h:
3201
3202 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
3203
3204         Reviewed by Maciej.
3205
3206         Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.
3207
3208         * platform/qt/FrameQt.cpp:
3209         (WebCore::FrameQt::runJavaScriptAlert): Move runJavaScriptAlert functionality to FrameQtClientDefault.
3210         * platform/qt/FrameQtClient.cpp:
3211         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
3212         * platform/qt/FrameQtClient.h:
3213
3214 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
3215
3216         Reviewed by Eric.
3217
3218         - move m_responseMIMEType out of ResourceRequest, where it doesn't belong
3219
3220         * page/FramePrivate.h: Add m_responseMIMEType
3221         * page/ResourceRequest.h: Remove m_responseMIMEType
3222         * page/Frame.cpp:
3223         (WebCore::Frame::setResponseMIMEType): added
3224         (WebCore::Frame::responseMIMEType): added
3225         (WebCore::Frame::begin): get MIME type from the right place
3226         (WebCore::Frame::write): ditto
3227         * page/Frame.h:
3228         * bindings/js/kjs_window.cpp:
3229         (KJS::createNewWindow): updated to use new Frame methods
3230         (KJS::WindowFunc::callAsFunction): ditto
3231         * bridge/mac/WebCoreFrameBridge.mm:
3232         (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto
3233         (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
3234         * loader/PluginDocument.cpp:
3235         (WebCore::PluginTokenizer::createDocumentStructure): ditto
3236
3237 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
3238
3239         Reviewed by Eric.
3240         
3241         <rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image
3242
3243         We really need some way to test loadHTMLString since it keeps breaking!
3244         
3245         * loader/mac/WebFrameLoader.mm:
3246         (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.
3247
3248 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
3249
3250         Reviewed by Eric.
3251
3252         Fix Qt/Linux build.
3253
3254         * CMakeLists.txt:
3255         * platform/qt/FileChooserQt.cpp:
3256         (WebCore::FileChooser::create):
3257
3258 2006-10-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3259
3260         Reviewed by Maciej.
3261
3262         Update Gdk\Linux build for recent changes, based on Qt code
3263
3264         * platform/gdk/FrameGdk.cpp:
3265         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
3266         (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault):
3267         (WebCore::FrameGdkClientDefault::setFrame):
3268         (WebCore::FrameGdkClientDefault::openURL):
3269         (WebCore::FrameGdkClientDefault::submitForm):
3270         (WebCore::FrameGdkClientDefault::receivedResponse):
3271         (WebCore::FrameGdkClientDefault::receivedData):
3272         (WebCore::FrameGdkClientDefault::receivedAllData):
3273         (WebCore::FrameGdk::FrameGdk):
3274         (WebCore::FrameGdk::openURL):
3275         (WebCore::FrameGdk::submitForm):
3276         (WebCore::FrameGdk::urlSelected):
3277         * platform/gdk/FrameGdk.h:
3278         * platform/gdk/TemporaryLinkStubs.cpp:
3279         (FrameGdk::createJavaAppletWidget):
3280         (FileChooser::create):
3281
3282 2006-10-12  Dave Hyatt  <hyatt@apple.com>
3283
3284         Patch to add more clipping retrieval functionality for widgets.
3285        
3286         Reviewed by mjs
3287
3288         * page/Frame.h:
3289         Remove windowResizerRect.  This is in the wrong place.
3290         
3291         * page/FrameView.cpp:
3292         (WebCore::FrameView::windowClipRect):
3293         (WebCore::FrameView::windowClipRectForLayer):
3294         Break out windowClipRect into helper functions that can be called separately (to make
3295         it easier for scrollbars in overflow sections and list boxes to get to an enclosing
3296         layer and get the right clip.
3297         
3298         * page/FrameView.h:
3299         Add the new windowClipRect helper methods.
3300         
3301         * platform/ScrollBar.h:
3302         Add a new interface to ScrollbarClient so that scrollbars can hand back proper
3303         clip rects for themselves depending on how they are used.
3304         
3305         * platform/ScrollView.h:
3306         Stub out methods for talking to a double buffer backing store on Win32.
3307         
3308         * platform/Widget.h:
3309         Add the ability to query for invalidation suppression.
3310         
3311         * rendering/RenderLayer.cpp:
3312         (WebCore::RenderLayer::windowClipRect):
3313         (WebCore::RenderLayer::paintOverflowControls):
3314         (WebCore::RenderLayer::calculateRects):
3315         (WebCore::RenderLayer::childrenClipRect):
3316         (WebCore::RenderLayer::selfClipRect):
3317         * rendering/RenderLayer.h:
3318         Enhance layers so that they can return either their foreground or background
3319         document clip rects.  Make sure a layer scrollbar can return a proper clip.
3320         
3321         * rendering/RenderListBox.cpp:
3322         (WebCore::RenderListBox::windowClipRect):
3323         * rendering/RenderListBox.h:
3324         Make sure a list box scrollbar can return a proper clip.
3325         
3326         * rendering/RenderObject.cpp:
3327         (WebCore::RenderObject::enclosingLayer):
3328         * rendering/RenderObject.h:
3329         Make enclosingLayer const.
3330         
3331 2006-10-11  Darin Adler  <darin@apple.com>
3332
3333         Reviewed by John.
3334
3335         - some changes to prepare for converting more code to C++
3336
3337         * bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is
3338         self-sufficient.
3339
3340         * bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class.
3341         Needed since the class is used in this header (for some work I have not landed yet).
3342
3343         * loader/mac/LoaderNSURLExtras.h:
3344         * loader/mac/WebFormDataStream.h:
3345         Added extern "C" so this code can be used from C++.
3346
3347         * loader/mac/LoaderNSURLExtras.m:
3348         * loader/mac/WebDataProtocol.mm:
3349         * loader/mac/WebDocumentLoader.mm:
3350         * loader/mac/WebFormDataStream.m:
3351         * loader/mac/WebLoader.mm:
3352         * loader/mac/WebMainResourceLoader.mm:
3353         * loader/mac/WebNetscapePlugInStreamLoader.mm:
3354         * loader/mac/WebPolicyDecider.mm:
3355         * loader/mac/WebSubresourceLoader.mm:
3356         Added missing includes of config.h.
3357
3358 2006-10-11  John Sullivan  <sullivan@apple.com>
3359         
3360         Darin wrote this code; we tested it; I give it the thumbs up.
3361         
3362         - fixed regression from svn revision 16982 that was generating the wrong Obj-C classes
3363
3364         The hash table to look up an element class given a QualifiedName was
3365         not working at all.
3366
3367         * dom/QualifiedName.h:
3368         (WebCore::QualifiedName::impl):
3369         Added. This new accessor method for impl is needed if we want to use
3370         a QualifiedName as a hash table key without doing the kind of specialization
3371         we do for String. Maybe later we can do the String thing.
3372
3373         * bindings/objc/DOM.mm:
3374         (WebCore::addElementClass):
3375         Use QualifiedName.impl instead of the QualifiedName pointer itself.
3376         The QualifiedName pointer is *not* unique so almost nothing would be found
3377         in this hash table!
3378         (WebCore::elementClass):
3379         ditto
3380         
3381 2006-10-11  Adam Roben  <aroben@apple.com>
3382
3383         Rubberstamped by Anders.
3384
3385         Clean up FileChooser::create and Icon::newIconForFile.
3386
3387         * WebCore.xcodeproj/project.pbxproj:
3388         * platform/mac/FileChooserMac.mm:
3389         (WebCore::FileChooser::create):
3390         * platform/mac/IconMac.mm:
3391         (WebCore::Icon::newIconForFile):
3392
3393 2006-10-11  Oliver Hunt  <oliver@apple.com>
3394
3395         Reviewed by Adam.
3396
3397         Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
3398         Corrects canvas tag to not throw JS exception when drawing
3399         zero sized rects, arcs, etc
3400
3401         * html/CanvasRenderingContext2D.cpp:
3402         (WebCore::CanvasRenderingContext2D::arcTo):
3403         (WebCore::CanvasRenderingContext2D::arc):
3404         (WebCore::CanvasRenderingContext2D::rect):
3405         (WebCore::CanvasRenderingContext2D::clearRect):
3406         (WebCore::CanvasRenderingContext2D::fillRect):
3407         (WebCore::CanvasRenderingContext2D::strokeRect):
3408
3409 2006-10-11  Rob Buis  <buis@kde.org>
3410
3411         Reviewed by Mitz.
3412
3413         http://bugs.webkit.org/show_bug.cgi?id=11221
3414         REGRESSION: iExploder crash due to style="cursor: url()"
3415
3416         Take better care of empty cursor lists.
3417
3418         Test: fast/css/invalid-cursor-property-crash.html
3419
3420         * css/cssparser.cpp:
3421         (WebCore::CSSParser::parseValue):
3422
3423 2006-10-11  Adam Roben  <aroben@apple.com>
3424
3425         Fixing Windows for real this time.
3426
3427         * platform/win/TemporaryLinkStubs.cpp:
3428         (FileChooser::create):
3429
3430 2006-10-11  Adam Roben  <aroben@apple.com>
3431
3432         Fix Windows build.
3433
3434         * platform/win/TemporaryLinkStubs.cpp:
3435         (FileChooser::create):
3436
3437 2006-10-11  Antti Koivisto  <koivisto@iki.fi>
3438
3439         Reviewed by Hyatt.
3440         
3441         http://bugs.webkit.org/show_bug.cgi?id=4377
3442         
3443         Respect css visibility semantics for layers too
3444
3445         * rendering/RenderContainer.cpp:
3446         (WebCore::RenderContainer::removeChildNode):
3447         (WebCore::RenderContainer::appendChildNode):
3448         (WebCore::RenderContainer::insertChildNode):
3449         * rendering/RenderLayer.cpp:
3450         (WebCore::RenderLayer::RenderLayer):
3451         (WebCore::RenderLayer::updateLayerPositions):
3452         (WebCore::RenderLayer::setHasVisibleContent):
3453         (WebCore::RenderLayer::dirtyVisibleContentStatus):
3454         (WebCore::RenderLayer::childVisibilityChanged):
3455         (WebCore::RenderLayer::dirtyVisibleDescendantStatus):
3456         (WebCore::RenderLayer::updateVisibilityStatus):
3457         (WebCore::RenderLayer::addChild):
3458         (WebCore::RenderLayer::removeChild):
3459         (WebCore::RenderLayer::updateZOrderLists):
3460         (WebCore::RenderLayer::collectLayers):
3461         * rendering/RenderLayer.h:
3462         (WebCore::RenderLayer::hasVisibleContent):
3463         * rendering/RenderObject.cpp:
3464         (WebCore::RenderObject::setStyle):
3465
3466 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
3467
3468         Reviewed by Oliver.
3469
3470         - added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
3471
3472         * WebCore.xcodeproj/project.pbxproj:
3473         * platform/cf/RetainPtr.h: Added.
3474         (WTF::):
3475         (WTF::RetainPtr::RetainPtr):
3476         (WTF::RetainPtr::~RetainPtr):
3477         (WTF::RetainPtr::get):
3478         (WTF::RetainPtr::operator*):
3479         (WTF::RetainPtr::operator->):
3480         (WTF::RetainPtr::operator!):
3481         (WTF::RetainPtr::operator UnspecifiedBoolType):
3482         (WTF::::operator):
3483         (WTF::::swap):
3484         (WTF::swap):
3485         (WTF::operator==):
3486         (WTF::operator!=):
3487         (WTF::static_pointer_cast):
3488         (WTF::const_pointer_cast):
3489         (WTF::getPtr):
3490         
3491         - use it in WidgetMac so it gets tested in at least one place
3492         
3493         * platform/mac/WidgetMac.mm:
3494         (WebCore::Widget::Widget):
3495         (WebCore::Widget::~Widget):
3496         (WebCore::Widget::setEnabled):
3497         (WebCore::Widget::isEnabled):
3498         (WebCore::Widget::setCursor):
3499         (WebCore::Widget::getView):
3500         (WebCore::Widget::setView):
3501         (WebCore::Widget::getOuterView):
3502
3503 2006-10-10  Brady Eidson  <beidson@apple.com>
3504
3505         Reviewed by Maciej.
3506
3507         Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge
3508
3509         * bridge/mac/WebCoreFrameBridge.h:
3510         * bridge/mac/WebCoreFrameBridge.mm:
3511         (-[WebCoreFrameBridge initMainFrameWithPage:]):
3512         (-[WebCoreFrameBridge initSubframeWithOwnerElement:]):
3513         (-[WebCoreFrameBridge dealloc]):
3514         (-[WebCoreFrameBridge close]):
3515         (-[WebCoreFrameBridge setFrameLoaderClient:]):
3516         (-[WebCoreFrameBridge frameLoader]):
3517         * loader/mac/WebFrameLoader.h:
3518         * loader/mac/WebFrameLoader.mm:
3519         (-[WebFrameLoader initWithFrameBridge:]):
3520         (-[WebFrameLoader setFrameLoaderClient:]):
3521
3522 2006-10-10  Adam Roben  <aroben@apple.com>
3523
3524         Reviewed by Oliver.
3525
3526         Make FileChooser ref-counted.
3527
3528         * platform/FileChooser.h:
3529         * platform/mac/FileChooserMac.mm:
3530         (WebCore::FileChooser::create):
3531         * rendering/RenderFileUploadControl.cpp:
3532         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
3533         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
3534         * rendering/RenderFileUploadControl.h:
3535
3536 2006-10-10  Sam Weinig  <sam.weinig@gmail.com>
3537
3538         Reviewed by Tim H.
3539
3540         Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
3541         Even More auto-generated Objective-C DOM bindings changes
3542
3543         - Auto-generate DOMSVGPathElement.
3544
3545         - Auto-generate the internal interfaces even for classes that have
3546           custom internal implementations.  Change IDL property from ObjCNoInternal
3547           to ObjCCustomInternalImpl to indicate the change.
3548
3549         - Add SVG classes to DOMNode and DOMEvent internal interfaces.
3550
3551         - Add isSVGZoomEvent() method to Event class to match other Event subclasses
3552           and make DOM binding possible.
3553
3554         - Assorted cleanups.
3555
3556         * DerivedSources.make:
3557         * WebCore.xcodeproj/project.pbxproj:
3558         * bindings/objc/DOM.mm:
3559         (WebCore::addElementClass):
3560         (WebCore::createElementClassMap):
3561         (WebCore::elementClass):
3562         (-[DOMNode description]):
3563         (+[DOMNode _nodeWith:WebCore::]):
3564         (-[DOMNode addEventListener:listener:useCapture:]):
3565         (-[DOMNode removeEventListener:listener:useCapture:]):
3566         (-[DOMElement _NPObject]):
3567         (WebCore::ObjCEventListener::handleEvent):
3568         * bindings/objc/DOMEvents.mm:
3569         (+[DOMEvent _eventWith:WebCore::]):
3570         * bindings/objc/DOMInternal.h:
3571         * bindings/objc/DOMRGBColor.mm:
3572         (-[DOMRGBColor WebCore::]):
3573         * bindings/objc/DOMSVGPathSegInternal.h: Removed.
3574         * bindings/scripts/CodeGeneratorObjC.pm:
3575         * css/CSSRule.idl:
3576         * css/CSSValue.idl:
3577         * css/StyleSheet.idl:
3578         * dom/Event.cpp:
3579         (WebCore::Event::isSVGZoomEvent):
3580