9acaadfb51ffc060ab6e6bb4d2630d8c427decd4
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
2
3         Reviewed by Oliver Hunt.
4
5         ARIA: support aria-flowto
6         https://bugs.webkit.org/show_bug.cgi?id=31762
7
8         Test: platform/mac/accessibility/aria-flowto.html
9
10         * accessibility/AccessibilityObject.h:
11         (WebCore::AccessibilityObject::ariaOwnsElements):
12         (WebCore::AccessibilityObject::supportsARIAFlowTo):
13         (WebCore::AccessibilityObject::ariaFlowToElements):
14         * accessibility/AccessibilityRenderObject.cpp:
15         (WebCore::AccessibilityRenderObject::linkedUIElements):
16         (WebCore::AccessibilityRenderObject::supportsARIAFlowTo):
17         (WebCore::AccessibilityRenderObject::ariaFlowToElements):
18         * accessibility/AccessibilityRenderObject.h:
19         * html/HTMLAttributeNames.in:
20
21 2009-11-22  Nikolas Zimmermann  <nzimmermann@rim.com>
22
23         Not reviewed. Build fix for WML enabled builds.
24         Adopt WebCore API changes.
25
26         * wml/WMLAElement.cpp:
27         (WebCore::WMLAElement::defaultEventHandler):
28         * wml/WMLInputElement.cpp:
29         (WebCore::WMLInputElement::defaultEventHandler):
30
31 2009-11-22  Pavel Feldman  <pfeldman@chromium.org>
32
33         Reviewed by Timothy Hatcher.
34
35         Web Inspector: Introduce sidebar background on timeline panel in order
36         to prevent it from flickering on scroll.
37
38         https://bugs.webkit.org/show_bug.cgi?id=31789
39
40         * inspector/front-end/TimelinePanel.js:
41         (WebInspector.TimelinePanel):
42         (WebInspector.TimelinePanel.prototype.setSidebarWidth):
43         (WebInspector.TimelinePanel.prototype._onScroll):
44         (WebInspector.TimelinePanel.prototype._scheduleRefresh):
45         * inspector/front-end/inspector.css:
46
47 2009-11-22  Pavel Feldman  <pfeldman@chromium.org>
48
49         Reviewed by Timothy Hatcher.
50
51         Web Inspector: Reimplement TimelinePanel to make it fast:
52         - Extract grid and overview into separate files
53         - Make timeline create only divs for visible rows
54
55         https://bugs.webkit.org/show_bug.cgi?id=31784
56
57         * WebCore.gypi:
58         * WebCore.vcproj/WebCore.vcproj:
59         * inspector/front-end/AbstractTimelinePanel.js:
60         (WebInspector.AbstractTimelinePanel.prototype.createInterface):
61         (WebInspector.AbstractTimelinePanel.prototype.refresh):
62         (WebInspector.AbstractTimelinePanel.prototype.set calculator):
63         * inspector/front-end/TimelineGrid.js: Added.
64         (WebInspector.TimelineGrid):
65         (WebInspector.TimelineGrid.prototype.get itemsGraphsElement):
66         (WebInspector.TimelineGrid.prototype.updateDividers):
67         (WebInspector.TimelineGrid.prototype.addEventDivider):
68         (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
69         * inspector/front-end/TimelineOverviewPane.js: Added.
70         (WebInspector.TimelineOverviewPane):
71         (WebInspector.TimelineOverviewPane.prototype._onCheckboxClicked):
72         (WebInspector.TimelineOverviewPane.prototype.update):
73         (WebInspector.TimelineOverviewPane.prototype.setSidebarWidth):
74         (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
75         (WebInspector.TimelineOverviewPane.prototype.reset):
76         (WebInspector.TimelineOverviewPane.prototype._resizeWindow):
77         (WebInspector.TimelineOverviewPane.prototype._windowResizeDragging):
78         (WebInspector.TimelineOverviewPane.prototype._dragWindow):
79         (WebInspector.TimelineOverviewPane.prototype._windowDragging):
80         (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft):
81         (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
82         (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
83         (WebInspector.TimelineOverviewPane.prototype._endWindowDragging):
84         (WebInspector.TimelineOverviewCalculator):
85         (WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages):
86         (WebInspector.TimelineOverviewCalculator.prototype.reset):
87         (WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries):
88         (WebInspector.TimelineOverviewCalculator.prototype.get boundarySpan):
89         (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
90         (WebInspector.TimelineCategoryTreeElement):
91         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
92         (WebInspector.TimelineCategoryGraph):
93         (WebInspector.TimelineCategoryGraph.prototype.get graphElement):
94         (WebInspector.TimelineCategoryGraph.prototype.addChunk):
95         (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
96         (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
97         * inspector/front-end/TimelinePanel.js:
98         (WebInspector.TimelinePanel):
99         (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
100         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
101         (WebInspector.TimelinePanel.prototype._formatRecord):
102         (WebInspector.TimelinePanel.prototype.setSidebarWidth):
103         (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
104         (WebInspector.TimelinePanel.prototype.resize):
105         (WebInspector.TimelinePanel.prototype.reset):
106         (WebInspector.TimelinePanel.prototype.show):
107         (WebInspector.TimelinePanel.prototype._onScroll):
108         (WebInspector.TimelinePanel.prototype._scheduleRefresh):
109         (WebInspector.TimelinePanel.prototype._refresh):
110         (WebInspector.TimelinePanel.prototype._refreshRecords):
111         (WebInspector.TimelinePanel.prototype._adjustScrollPosition):
112         (WebInspector.TimelineCategory):
113         (WebInspector.TimelineCalculator):
114         (WebInspector.TimelineCalculator.prototype.get boundarySpan):
115         (WebInspector.TimelineRecordListRow):
116         (WebInspector.TimelineRecordListRow.prototype.update):
117         (WebInspector.TimelineRecordGraphRow):
118         (WebInspector.TimelineRecordGraphRow.prototype.update):
119         * inspector/front-end/WebKit.qrc:
120         * inspector/front-end/inspector.css:
121         * inspector/front-end/inspector.html:
122
123 2009-11-22  Chris Evans  <cevans@chromium.org>
124
125         Reviewed by Adam Barth.
126
127         Disable access to file:/// directory listings
128         https://bugs.webkit.org/show_bug.cgi?id=31329
129
130         Deny access to directory listings. This needs doing in WebKit for
131         WebKit clients that do permit top-level navigation to file:///dir.
132         This matches Firefox, plus the existing Safari implementation (which
133         does not support any directory access at all). It will fix the
134         LayoutTest named below for Chromium.
135
136         Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
137
138         * page/SecurityOrigin.cpp: Deny access to directory listings.
139         (WebCore::SecurityOrigin::SecurityOrigin):
140         (WebCore::SecurityOrigin::canRequest):
141
142 2009-11-20  Joseph Pecoraro  <joepeck@webkit.org>
143
144         Reviewed by Timothy Hatcher.
145
146         Web Inspector: Support Ctrl+P and Ctrl+N, Readline keyboard shortcuts in the Console
147         https://bugs.webkit.org/show_bug.cgi?id=31400
148
149         Handle the following when on a Mac:
150
151           Ctrl+P = Previous (like Up arrow)
152           Ctrl+N = Next (like Down arrow)
153
154         No longer rerun autocompletion when just pushing a modifier key
155         like Control, Alt, Shift, or Meta.
156
157         Improved arrow key behavior with Multiline code in the Console, with the following behavior:
158
159           Up   = Previous Command if on First Line (caret moves to the end of the first line)
160                  otherwise default caret movement in text.
161           Down = Next Command if on Last Line (caret naturally moves to the end)
162                  otherwise default caret movement in text.
163
164         * inspector/front-end/TextPrompt.js:
165         (WebInspector.TextPrompt.prototype.handleKeyEvent): handle new keyboard shortcuts
166         (WebInspector.TextPrompt.prototype.isCaretOnFirstLine): check if the caret is on the top line
167         (WebInspector.TextPrompt.prototype.isCaretOnLastLine): check if the caret is on the bottom line
168         (WebInspector.TextPrompt.prototype._upKeyPressed):
169         (WebInspector.TextPrompt.prototype._downKeyPressed):
170         (WebInspector.TextPrompt.prototype._moveBackInHistory):
171         (WebInspector.TextPrompt.prototype._moveForwardInHistory):
172
173 2009-11-21  Jessie Berlin  <jberlin@webkit.org>
174
175         Reviewed by Timothy Hatcher.
176
177         Adds a tooltip containing the full url of the resource to each element
178         in the Resources panel so that it is possible to quickly see the query
179         parameters.
180         https://bugs.webkit.org/show_bug.cgi?id=19103
181
182         * inspector/front-end/ResourcesPanel.js:
183         (WebInspector.ResourceSidebarTreeElement.prototype.refresh):
184         Set the tooltip to be the resource's url.
185
186 2009-11-21  Simon Fraser  <simon.fraser@apple.com>
187
188         Reviewed by Dan Bernstein.
189
190         CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
191         https://bugs.webkit.org/show_bug.cgi?id=31588
192         
193         In WebKitCSSKeyframesRule::findRuleIndex(), map 'from' to 0% an 'to' to 100%
194         so that findRule() and deleteRule() work with these keywords.
195
196         * css/WebKitCSSKeyframesRule.cpp:
197         (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
198
199 2009-11-21  Daniel Bates  <dbates@webkit.org>
200
201         Reviewed by Eric Seidel.
202
203         https://bugs.webkit.org/show_bug.cgi?id=31647
204
205         Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.
206
207         No functionality was changed. So, no new tests.
208
209         * dom/KeyboardEvent.cpp:
210         (WebCore::KeyboardEvent::~KeyboardEvent):
211         * dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr.
212         (WebCore::KeyboardEvent::keyEvent):
213
214 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
215
216         Reviewed by Beth Dakin.
217
218         WAI-ARIA: add support for aria-owns
219         https://bugs.webkit.org/show_bug.cgi?id=31702
220
221         Re-organized how accessibilityAttributeNames are returned so 
222         that it's possible for an element to add an attribute based on 
223         a dynamic value. In this case, we only want to add AXOwn if the 
224         element actually supports aria-owns.
225   
226         Test: platform/mac/accessibility/aria-owns.html
227
228         * accessibility/AccessibilityObject.h:
229         (WebCore::AccessibilityObject::supportsARIAOwns):
230         (WebCore::AccessibilityObject::ariaOwnsElements):
231         * accessibility/AccessibilityRenderObject.cpp:
232         (WebCore::AccessibilityRenderObject::ariaOwnsElements):
233         (WebCore::AccessibilityRenderObject::supportsARIAOwns):
234         * accessibility/AccessibilityRenderObject.h:
235         * accessibility/mac/AccessibilityObjectWrapper.mm:
236         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
237         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
238         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
239         * html/HTMLAttributeNames.in:
240
241 2009-11-20  Eric Carlson  <eric.carlson@apple.com>
242
243         Reviewed by Simon Fraser.
244
245         <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
246
247         * css/mediaControls.css:
248             Define closed caption toggle button.
249
250         * rendering/RenderMedia.cpp:
251         (WebCore::RenderMedia::updateControls):
252             Create closed caption toggle button in display order.
253
254         * rendering/RenderThemeMac.mm:
255         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
256             Don't require MediaControllerThemeQuickTime theme for captions toggle button.
257             No need to check if the movie has video, a closed captions track is a video
258             track.
259
260 2009-11-20  Joseph Pecoraro  <joepeck@webkit.org>
261
262         Reviewed by Timothy Hatcher.
263
264         Web Inspector: Running code in the Console that ends with a
265         single line comment no longer produces a parse error.
266
267         * inspector/front-end/InjectedScript.js:
268         (InjectedScript._evaluateOn):
269
270 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
271
272         Reviewed by Beth Dakin.
273
274         WAI-ARIA: add support for 'math' role
275         https://bugs.webkit.org/show_bug.cgi?id=31706
276
277         * accessibility/AccessibilityObject.cpp:
278         * accessibility/AccessibilityObject.h:
279         * accessibility/mac/AccessibilityObjectWrapper.mm:
280
281 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
282
283         Reviewed by Kenneth Rohde Christiansen.
284
285         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
286         https://bugs.webkit.org/show_bug.cgi?id=30460
287
288         Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
289         It already refreshes plugins and reloads pages when necessary.
290
291         Tests: plugins/reloadplugins-and-pages.html
292                plugins/reloadplugins-no-pages.html
293
294         * plugins/PluginInfoStore.cpp:
295         (WebCore::refreshPlugins):
296
297 2009-11-20  Oliver Hunt  <oliver@apple.com>
298
299         Reviewed by Dave Hyatt.
300
301         <rdar://7409188> WebKit needs to be able to serialize and deserialize objects.
302
303         Expose WebCore object serialization to WebKit.
304
305         * WebCore.base.exp:
306         * bindings/js/SerializedScriptValue.cpp:
307         (WebCore::SerializedScriptValue::~SerializedScriptValue):
308         (WebCore::SerializedScriptValue::create):
309         (WebCore::SerializedScriptValue::deserialize):
310         * bindings/js/SerializedScriptValue.h:
311
312 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
313
314         Reviewed by Tim Hatcher.
315
316         Fixes <http://webkit.org/b/31741>.
317         Web Inspector: User Entered Data on the console should show up no matter what filters.
318         
319         Always show .console-user-command-result, no matter what the filter say
320         we should do with the other classes.
321
322         * inspector/front-end/inspector.css:
323
324 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
325
326         Reviewed by Tim Hatcher.
327
328         Fixes <http://webkit.org/b/31700>.
329         Web Inspector: isMac should be in one central location + Cached.
330         
331         We should cache the value of isMac, and make the indexOf call in one
332         single location, because we are calling it from multiple places, and saving
333         the result can save us time, and make the call sites simpler.
334
335         * inspector/front-end/AbstractTimelinePanel.js:
336         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
337         * inspector/front-end/ConsoleView.js:
338         (WebInspector.ConsoleView.prototype._updateFilter):
339         * inspector/front-end/ElementsPanel.js:
340         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
341         * inspector/front-end/ScriptsPanel.js:
342         (WebInspector.ScriptsPanel):
343         * inspector/front-end/SourceFrame.js:
344         (WebInspector.SourceFrame.prototype._loaded):
345         * inspector/front-end/inspector.js:
346         (WebInspector.documentKeyDown):
347         (WebInspector.isMac):
348
349 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
350
351         Removed .DS_Store accidentally added in last (r51245).
352
353 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
354
355         Reviewed by Timothy Hatcher.
356
357         Web Inspector: Add Console Only Layout Mode
358         https://bugs.webkit.org/show_bug.cgi?id=30282
359
360         Adds a Console Panel, which allows for a Full size Console. This
361         extends the Drawer to the size of a Panel. This also fixes previous
362         resize issues with the Drawer.
363
364         * inspector/front-end/ConsolePanel.js: added.
365         (WebInspector.ConsolePanel):
366         (WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel):
367         (WebInspector.ConsolePanel.prototype.show):
368         (WebInspector.ConsolePanel.prototype.hide):
369         * inspector/front-end/Drawer.js:
370         (WebInspector.Drawer):
371         (WebInspector.Drawer.prototype.set visibleView):
372         (WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console.
373         (WebInspector.Drawer.prototype.show.animationFinished):
374         (WebInspector.Drawer.prototype.show):
375         (WebInspector.Drawer.prototype.hide.animationFinished):
376         (WebInspector.Drawer.prototype.hide):
377         (WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full
378         (WebInspector.Drawer.prototype.enterPanelMode):
379         (WebInspector.Drawer.prototype.exitPanelMode):
380         (WebInspector.Drawer.prototype.immediatelyExitPanelMode):
381         (WebInspector.Drawer.prototype._cancelAnimationIfNeeded):
382         (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
383         (WebInspector.Drawer.prototype._animateDrawerHeight):
384         (WebInspector.Drawer.prototype._animationDuration):
385         (WebInspector.Drawer.prototype._startStatusBarDragging):
386         (WebInspector.Drawer.prototype._statusBarDragging):
387         (WebInspector.Drawer.prototype._endStatusBarDragging):
388
389         Miscellaneous changes and cleanup.
390
391         * English.lproj/localizedStrings.js: "Console" toolbar title.
392         * inspector/front-end/ConsoleView.js: removed unnecessary element reordering  
393         * inspector/front-end/Images/consoleIcon.png: added.
394         * inspector/front-end/inspector.css: added icon.
395         * inspector/front-end/inspector.html:
396         * inspector/front-end/inspector.js:
397         (WebInspector._createPanels): create console panel
398         (WebInspector.windowResize): resize drawer if necessary
399         (WebInspector.documentKeyDown): esc should not toggle the console when in panel mode
400         (WebInspector.animateStyle): start animation interval, returns the interval key
401         (WebInspector.toggleAttach): resize drawer if necessary
402         (WebInspector.showConsolePanel): restore the panel when the inspector restarts
403         (WebInspector.showProfileForURL): style fix
404
405         Restore the panel when the inspector restarts.
406
407         * inspector/InspectorController.cpp:
408         (WebCore::InspectorController::setWindowVisible):
409         (WebCore::InspectorController::specialPanelForJSName):
410         * inspector/InspectorFrontend.cpp:
411         (WebCore::InspectorFrontend::showPanel):
412
413         Build files.
414
415         * WebCore.gypi:
416         * WebCore.vcproj/WebCore.vcproj:
417         * inspector/front-end/WebKit.qrc:
418
419 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
420
421         Reviewed by Tim Hatcher.
422
423         Fixes <http://webkit.org/b/31699>.
424         Web Inspector: Should Cache Values of InspectorController.platform() and port().
425
426         Refactor the Inspector to cache the value of InspectorController.platform
427         and InspectorController.port, because those need to call into C++, they are
428         being called more and more as we add platform specific keyboard shortcuts, and
429         they shouldn't change in the lifecycle of the Web Inspector.
430
431         * inspector/front-end/AbstractTimelinePanel.js:
432         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
433         * inspector/front-end/ConsoleView.js:
434         (WebInspector.ConsoleView.prototype._updateFilter):
435         * inspector/front-end/ElementsPanel.js:
436         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
437         * inspector/front-end/ScriptsPanel.js:
438         (WebInspector.ScriptsPanel):
439         * inspector/front-end/SourceFrame.js:
440         (WebInspector.SourceFrame.prototype._loaded):
441         * inspector/front-end/inspector.js:
442         (WebInspector.get platform):
443         (WebInspector.get port):
444         (WebInspector.loaded):
445         (WebInspector.documentKeyDown):
446         (WebInspector.toolbarDragStart):
447
448 2009-11-20  Dirk Schulze  <krit@webkit.org>
449
450         Unreviewed build fix for filters enabled builds.
451
452         * platform/graphics/filters/FEColorMatrix.cpp:
453         (WebCore::FEColorMatrix::apply):
454         * platform/graphics/filters/FEComposite.cpp:
455         (WebCore::FEComposite::apply):
456         * platform/graphics/filters/SourceGraphic.cpp:
457         (WebCore::SourceGraphic::apply):
458         * svg/graphics/SVGResourceFilter.cpp:
459         (WebCore::SVGResourceFilter::applyFilter):
460         * svg/graphics/filters/SVGFEMerge.cpp:
461         (WebCore::FEMerge::apply):
462         * svg/graphics/filters/SVGFEOffset.cpp:
463         (WebCore::FEOffset::apply):
464         * svg/graphics/filters/SVGFETile.cpp:
465         (WebCore::FETile::apply):
466
467 2009-11-20  Eric Carlson  <eric.carlson@apple.com>
468
469         Reviewed by Simon Fraser.
470
471         <rdar://problem/7389945> QTKit based media engine should not claim to support 
472         fullscreen on Leopard
473
474         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
475         (WebCore::MediaPlayerPrivate::supportsFullscreen):
476             Only return true on SnowLeopard for now.
477
478         * rendering/RenderThemeMac.mm:
479         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
480             No need to special case MediaFullscreenButtonPart as the default implementation 
481             asks the media engine if it supports fullscreen.
482
483 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
484
485         Reviewed by Simon Hausmann.
486
487         Patch by Yongjun Zhang <yongjun.zhang@nokia.com> and
488                  Girish Ramakrishnan <girish@forwardbias.in>
489         
490         [Qt] Implement support for rendering plugins on Qt/Mac when a page is used
491         without a QWebView or when inside QGraphicsWebView.
492         
493         Currently, the code provides the cgcontext of the PlatformPluginWidget to
494         the plugin. This approach does not work when we are printing, or using
495         QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
496         up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
497         of the QPaintDevice's context.
498         
499         To solve all cases and keep the code simple, we render the plugin to an
500         offscreen pixmap in all cases. This way, the plugin always renders to the
501         CGContext of the pixmap and we then use QPainter to blit the pixmap into
502         the QPaintDevice. We also create a fake window and set it's WindowRef in
503         NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.
504         
505         Now, that's the theory. In practice, ATM, mouse events do not work when using
506         the fake window. So, setPlatformPluginWidget() is still called when using QWebView
507         so that there are no regressions after this patch. Once we get mouse events
508         working, setPlatformPluginWidget will be removed.
509         
510         https://bugs.webkit.org/show_bug.cgi?id=31183
511
512         * plugins/PluginView.cpp:
513         (WebCore::PluginView::PluginView):
514         * plugins/PluginView.h:
515         * plugins/mac/PluginViewMac.cpp:
516         (WebCore::PluginView::platformStart):
517         (WebCore::PluginView::platformDestroy):
518         (WebCore::PluginView::setNPWindowIfNeeded):
519         (WebCore::PluginView::updatePluginWidget):
520         (WebCore::PluginView::paint):
521         (WebCore::PluginView::invalidateRect):
522
523 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
524
525         Reviewed by Timothy Hatcher.
526
527         Web Inspector: Resync Resources Backend and Frontend
528         https://bugs.webkit.org/show_bug.cgi?id=31705
529
530         * inspector/front-end/Resource.js: resync enum values with backend
531         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases
532
533 2009-11-19  Steve Block  <steveblock@google.com>
534
535         Reviewed by Darin Fisher.
536
537         Android port lacks configuration in Platform.h and config.h.
538         https://bugs.webkit.org/show_bug.cgi?id=31671
539
540         Build change only. No new tests possible.
541
542         * config.h: Modified. Added Android-specific configuration.
543
544 2009-11-20  Roland Steiner  <rolandsteiner@chromium.org>
545
546         Reviewed by Darin Adler.
547
548         Change default stylesheet to reset text indentation for ruby elements by default.
549         (https://bugs.webkit.org/show_bug.cgi?id=31247)
550
551         Test: fast/ruby/ruby-text-indent.html
552
553         * css/html.css: reset text-indent on <ruby> and <rt> elements
554
555 2009-11-19  Brian Weinstein  <bweinstein@apple.com>
556
557         Reviewed by Darin Adler.
558
559         Fixes <http://webkit.org/b/22754>.
560         Web Inspector: Keyboard shortcut for Element finder.
561
562         Use Command + Shift + C as a shortcut for Node Search, to 
563         match the Firebug shortcut to do the same thing.
564
565         * inspector/front-end/ElementsPanel.js:
566         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
567
568 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
569
570         Reviewed by Darin Adler.
571
572         https://bugs.webkit.org/show_bug.cgi?id=31690
573         Make SocketStreamHandleCFNet work on Windows
574
575         * WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.
576
577         * platform/network/ResourceHandle.h: Removed loaderRunLoop().
578
579         * platform/network/cf/LoaderRunLoopCF.cpp: Added.
580         (WebCore::emptyPerform):
581         (WebCore::runLoaderThread):
582         (WebCore::loaderRunLoop):
583         * platform/network/cf/LoaderRunLoopCF.h: Added.
584         Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because
585         it's needed for more than just resource loading.
586
587         * platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.
588
589         * platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.
590
591         * platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to
592         main thread.
593         * platform/network/cf/SocketStreamHandleCFNet.cpp:
594         (WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of
595         inoperable main run loop.
596
597         (WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo): 
598         (WebCore::SocketStreamHandle::readStreamCallback):
599         (WebCore::SocketStreamHandle::writeStreamCallback):
600         (WebCore::SocketStreamHandle::readStreamCallbackMainThread):
601         (WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
602         Forward stream events to main thread on Windows.
603
604 2009-11-19  Avi Drissman  <avi@chromium.org>
605
606         Reviewed by Darin Adler.
607
608         Quick style fix.
609         https://bugs.webkit.org/show_bug.cgi?id=27777
610
611         * platform/graphics/cg/PDFDocumentImage.cpp:
612
613 2009-11-19  Beth Dakin  <bdakin@apple.com>
614
615        Build fix. No review needed.
616
617         * platform/chromium/ScrollbarThemeChromium.cpp:
618         (WebCore::ScrollbarThemeChromium::paintTickmarks):
619         * rendering/RenderMediaControlsChromium.cpp:
620         (WebCore::paintMediaButton):
621
622 2009-11-19  Beth Dakin  <bdakin@apple.com>
623       
624        Build fix. No review needed.
625
626         * rendering/RenderThemeChromiumSkia.cpp:
627         (WebCore::RenderThemeChromiumSkia::paintCheckbox):
628         (WebCore::RenderThemeChromiumSkia::paintRadio):
629         (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
630         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
631         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
632
633 2009-11-19  Beth Dakin  <bdakin@apple.com>
634
635        Build fix. No review needed.
636
637         * platform/graphics/qt/StillImageQt.cpp:
638         (WebCore::StillImage::draw):
639         * platform/graphics/qt/StillImageQt.h:
640
641 2009-11-19  Beth Dakin  <bdakin@apple.com>
642
643        Build fix. No review needed.
644
645         * rendering/RenderThemeWin.cpp:
646         (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
647         (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
648         (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
649
650 2009-11-19  Beth Dakin  <bdakin@apple.com>
651
652        Build fix. No review needed.
653
654         * plugins/PluginView.cpp:
655         (WebCore::PluginView::paintMissingPluginIcon):
656
657 2009-11-19  Beth Dakin  <bdakin@apple.com>
658
659         Build fix. No review needed.
660
661         * platform/graphics/win/ImageCGWin.cpp:
662         (WebCore::BitmapImage::getHBITMAPOfSize):
663         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
664
665 2009-11-19  Beth Dakin  <bdakin@apple.com>
666
667         Reviewed by Darin Adler.
668
669         Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
670         color-correction work with untagged images
671
672         Image's draw(), drawPattern(), and fillWithSolidColor() functions 
673         now take a ColorSpace. A bunch of classes inherit from Image, so 
674         draw() and drawPattern() functions there must also take a 
675         ColorSpace.
676         * platform/graphics/Image.cpp:
677         (WebCore::Image::fillWithSolidColor):
678         (WebCore::Image::drawTiled):
679         * platform/graphics/Image.h:
680         * platform/graphics/BitmapImage.h:
681         * platform/graphics/GeneratedImage.cpp:
682         (WebCore::GeneratedImage::draw):
683         (WebCore::GeneratedImage::drawPattern):
684         * platform/graphics/GeneratedImage.h:
685         * platform/graphics/cg/PDFDocumentImage.cpp:
686         (WebCore::PDFDocumentImage::draw):
687         * platform/graphics/cg/PDFDocumentImage.h:
688         * svg/graphics/SVGImage.cpp:
689         (WebCore::SVGImage::draw):
690         * svg/graphics/SVGImage.h:
691
692         All of the drawImage() functions and drawTiled() functions of 
693         GraphicsContext now take a ColorSpace.
694         * platform/graphics/GraphicsContext.cpp:
695         (WebCore::GraphicsContext::drawImage):
696         (WebCore::GraphicsContext::drawTiledImage):
697         * platform/graphics/GraphicsContext.h:
698
699         This is where the actual work is done.
700         * platform/graphics/cg/ImageCG.cpp:
701         (WebCore::imageWithColorSpace): New static function that returns a 
702         copy of the given image in the given ColorSpace *IF* we should use 
703         the given ColorSpace. We will ignore the color space if the image 
704         is tagged and return 0. 
705         (WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to 
706         call imageWithColorSpace(). 
707         (WebCore::Image::drawPattern): Same.
708
709         Attempt to keep all ports building. 
710         * platform/graphics/cairo/ImageCairo.cpp:
711         (WebCore::BitmapImage::draw):
712         (WebCore::Image::drawPattern):
713         * platform/graphics/haiku/ImageHaiku.cpp:
714         (WebCore::BitmapImage::draw):
715         (WebCore::Image::drawPattern):
716         * platform/graphics/qt/ImageQt.cpp:
717         (WebCore::Image::drawPattern):
718         (WebCore::BitmapImage::draw):
719         * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
720         * platform/graphics/skia/ImageSkia.cpp:
721         (WebCore::Image::drawPattern):
722         (WebCore::BitmapImage::draw):
723         (WebCore::BitmapImageSingleFrameSkia::draw):
724         * platform/graphics/wx/ImageWx.cpp:
725         (WebCore::BitmapImage::draw):
726         (WebCore::BitmapImage::drawPattern):
727
728         Callers of GraphicsContext's drawImage() and drawTiled() functions 
729         now need to send a ColorSpace.
730         * html/HTMLCanvasElement.cpp:
731         (WebCore::HTMLCanvasElement::paint):
732         * html/canvas/CanvasRenderingContext2D.cpp:
733         (WebCore::CanvasRenderingContext2D::drawImage):
734         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
735         * platform/ScrollView.cpp:
736         (WebCore::ScrollView::wheelEvent):
737         * platform/graphics/filters/FEColorMatrix.cpp:
738         (WebCore::FEColorMatrix::apply):
739         * platform/graphics/filters/FEComposite.cpp:
740         (WebCore::FEComposite::apply):
741         * platform/graphics/filters/SourceGraphic.cpp:
742         (WebCore::SourceGraphic::apply):
743         * platform/mac/ScrollbarThemeMac.mm:
744         (WebCore::ScrollbarThemeMac::paint):
745         * rendering/RenderBoxModelObject.cpp:
746         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
747         (WebCore::RenderBoxModelObject::paintNinePieceImage):
748         * rendering/RenderImage.cpp:
749         (WebCore::RenderImage::paintReplaced):
750         * rendering/RenderLayer.cpp:
751         (WebCore::RenderLayer::paintResizer):
752         * rendering/RenderListMarker.cpp:
753         (WebCore::RenderListMarker::paint):
754         * rendering/RenderSVGImage.cpp:
755         (WebCore::RenderSVGImage::paint):
756         * rendering/RenderWidget.cpp:
757         (WebCore::RenderWidget::paint):
758         * svg/graphics/SVGPaintServerPattern.cpp:
759         (WebCore::SVGPaintServerPattern::setup):
760         * svg/graphics/SVGResourceFilter.cpp:
761         (WebCore::SVGResourceFilter::applyFilter):
762         * svg/graphics/filters/SVGFEMerge.cpp:
763         (WebCore::FEMerge::apply):
764         * svg/graphics/filters/SVGFEOffset.cpp:
765         (WebCore::FEOffset::apply):
766         * svg/graphics/filters/SVGFETile.cpp:
767         (WebCore::FETile::apply):
768
769 2009-11-19  Avi Drissman  <avi@chromium.org>
770
771         Reviewed by Darin Adler.
772
773         Properly create a CGImageRef on non-PLATFORM(MAC).
774         https://bugs.webkit.org/show_bug.cgi?id=27777
775
776         * platform/graphics/cg/ImageSourceCG.cpp:
777         (WebCore::sharedBufferGetBytesAtPosition):
778         (WebCore::sharedBufferRelease):
779         (WebCore::ImageSource::setData):
780         * platform/graphics/cg/ImageSourceCG.h:
781         * platform/graphics/cg/PDFDocumentImage.cpp:
782         (WebCore::PDFDocumentImage::dataChanged):
783
784 2009-11-19  Oliver Hunt  <oliver@apple.com>
785
786         Reviewed by Dave Hyatt.
787
788         -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
789         https://bugs.webkit.org/show_bug.cgi?id=31656
790
791         Make sure we're a child of the painting root before drawing overflow features.
792
793         * manual-tests/user-drag-with-decorations.html: Added.
794         * rendering/RenderBlock.cpp:
795         (WebCore::RenderBlock::paint):
796
797 2009-11-19  Dmitry Titov  <dimich@chromium.org>
798
799         Not reviewed, attempt to fix Chromium build.
800
801         * rendering/RenderMediaControlsChromium.cpp:
802         (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.
803
804 2009-11-19  Rahul Kuchhal  <kuchhal@chromium.org>
805
806         Reviewed by Darin Adler.
807
808         Do not assert when a high number is used for roman numerals in lists.
809         https://bugs.webkit.org/show_bug.cgi?id=31652
810
811         Test: fast/lists/ol-start-roman.html
812
813         * rendering/RenderListMarker.cpp:
814         (WebCore::toRoman): Increase the char array size.
815
816 2009-11-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
817
818         Rubber-stamped by Oliver Hunt.
819
820         Add translatable strings to cover validationMessage, after
821         r51172. Already covered by existing test.
822
823         * platform/gtk/LocalizedStringsGtk.cpp:
824         (WebCore::validationMessageValueMissingText):
825         (WebCore::validationMessageTypeMismatchText):
826         (WebCore::validationMessagePatternMismatchText):
827         (WebCore::validationMessageTooLongText):
828         (WebCore::validationMessageRangeUnderflowText):
829         (WebCore::validationMessageRangeOverflowText):
830         (WebCore::validationMessageStepMismatchText):
831
832 2009-11-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
833
834         Reviewed by Darin Adler.
835
836         Remove HAVE(FLOAT_H) guard
837         https://bugs.webkit.org/show_bug.cgi?id=31661
838
839         WebCore has a dependency on float.h, there is
840         no need to guard float.h.
841
842         No new tests as there is no functional change.
843
844         * html/HTMLInputElement.cpp: Remove include directive
845         for float.h as it is included in MathExtras.h already.
846
847 2009-11-19  Simon Fraser  <simon.fraser@apple.com>
848
849         Reviewed by Pavel Feldman.
850
851         Instrumentation should account for painting in compositing layers
852         https://bugs.webkit.org/show_bug.cgi?id=31674
853
854         Add calls to InspectorTimelineAgent for painting into compositing layers,
855         which is not accounted for in FrameView::paintContents().
856
857         * rendering/RenderLayerBacking.cpp:
858         (WebCore::RenderLayerBacking::paintIntoLayer):
859         Avoid fetching the FrameView multiple times.
860         
861         (WebCore::inspectorTimelineAgent):
862         (WebCore::RenderLayerBacking::paintContents):
863
864 2009-11-19  Eric Carlson  <eric.carlson@apple.com>
865
866         Reviewed by Dan Bernstein.
867
868         <rdar://problem/7035231>
869         Support closed caption in <video> element
870
871         Test: media/media-captions.html
872
873         * WebCore.base.exp:
874         * accessibility/AccessibilityMediaControls.cpp:
875         (WebCore::AccessibilityMediaControl::controlTypeName):
876             Define ShowClosedCaptionsButton and HideClosedCaptionsButton.
877
878         * css/CSSPrimitiveValueMappings.h:
879         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
880             Add MediaToggleClosedCaptionsButtonPart.
881
882         * css/CSSSelector.cpp:
883         (WebCore::CSSSelector::extractPseudoType):
884             Define and match mediaControlsToggleClosedCaptionsButton.
885
886         * css/CSSSelector.h:
887         (WebCore::CSSSelector::):
888         * css/CSSStyleSelector.cpp:
889         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
890             Define and match PseudoMediaControlsToggleClosedCaptions.
891
892         * css/CSSValueKeywords.in:
893             Define and use media-toggle-closed-captions-button.
894
895         * css/mediaControls.css:
896         * css/mediaControlsQuickTime.css:
897             Add webkit-media-controls-toggle-closed-captions-button.
898
899         * html/HTMLMediaElement.cpp:
900         (WebCore::HTMLMediaElement::HTMLMediaElement): 
901             Initialize m_closedCaptionsVisible.
902         (WebCore::HTMLMediaElement::loadInternal): 
903             Set m_closedCaptionsVisible to false.
904         (WebCore::HTMLMediaElement::hasClosedCaptions): 
905         (WebCore::HTMLMediaElement::closedCaptionsVisible): 
906         (WebCore::HTMLMediaElement::setClosedCaptionsVisible): 
907             New, captions internal methods.
908         (WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): 
909         (WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): 
910         (WebCore::HTMLMediaElement::webkitHasClosedCaptions): 
911             New, captions DOM API.
912
913         * html/HTMLMediaElement.h:
914         * html/HTMLMediaElement.idl:
915             Declare methods needed for captions API.
916
917         * platform/ThemeTypes.h:
918             Add MediaToggleClosedCaptionsButtonPart.
919
920         * platform/android/LocalizedStringsAndroid.cpp:
921         (WebCore::localizedMediaControlElementString):
922         (WebCore::localizedMediaControlElementHelpText):
923         (WebCore::localizedMediaTimeDescription):
924             Add empty implmentations.
925
926         * platform/graphics/MediaPlayer.cpp:
927         (WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
928         (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
929             New, empty implementations of media engine closed caption functions.
930         (WebCore::MediaPlayer::hasClosedCaptions):
931         (WebCore::MediaPlayer::setClosedCaptionsVisible):
932             New, call media engine closed caption functions.
933
934         * platform/graphics/MediaPlayer.h:
935         * platform/graphics/MediaPlayerPrivate.h:
936         (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions):
937         (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):
938             Declare new media engine methods.
939
940         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
941         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
942         (WebCore::MediaPlayerPrivate::hasClosedCaptions):
943         (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
944             New, QTKit implementation of closed caption methods.
945
946         * platform/gtk/LocalizedStringsGtk.cpp:
947         (WebCore::localizedMediaControlElementString):
948         (WebCore::localizedMediaControlElementHelpText):
949             Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.
950
951         * platform/mac/WebCoreSystemInterface.h:
952         * platform/mac/WebCoreSystemInterface.mm:
953             Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.
954
955         * rendering/MediaControlElements.cpp:
956         (WebCore::MediaControlInputElement::MediaControlInputElement):
957             Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
958         (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
959         (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
960         (WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
961             New, implement the closed caption toggle button,
962
963         * rendering/MediaControlElements.h:
964             Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
965             declare MediaControlToggleClosedCaptionsButtonElement.
966
967         * rendering/RenderMedia.cpp:
968         (WebCore::RenderMedia::styleDidChange):
969         (WebCore::RenderMedia::createToggleClosedCaptionsButton):
970         (WebCore::RenderMedia::createStatusDisplay):
971         (WebCore::RenderMedia::updateControls):
972         (WebCore::RenderMedia::forwardEvent):
973         * rendering/RenderMedia.h:
974             Deal with m_toggleClosedCaptionsButton.
975
976         * rendering/RenderTheme.cpp:
977         (WebCore::RenderTheme::paint):
978             Deal with MediaToggleClosedCaptionsButtonPart.
979
980         * rendering/RenderTheme.h:
981         * rendering/RenderThemeMac.h:
982             Declare paintMediaToggleClosedCaptionsButton.
983
984         * rendering/RenderThemeMac.mm:
985         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
986             New.
987         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
988             Don't render captions toggle button unless we are using the new theme, the
989             movie has captions, and the movie is in a <video> element since we currently
990             rely on QTKit to render the captions.
991
992         * rendering/style/RenderStyleConstants.h:
993             Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
994
995 2009-11-19  Kevin Ollivier  <kevino@theolliviers.com>
996
997         wx build fix. Add missing header.
998
999         * platform/wx/LocalizedStringsWx.cpp:
1000
1001 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
1002
1003         Reviewed by Darin Adler.
1004
1005         https://bugs.webkit.org/show_bug.cgi?id=31634
1006         Ignore realm for proxy protection spaces
1007
1008         Only affects WebSocket proxy authentication, cannot be tested in DRT.
1009
1010         * platform/network/ProtectionSpace.cpp:
1011         (WebCore::operator==):
1012         * platform/network/ProtectionSpaceHash.h:
1013         (WebCore::ProtectionSpaceHash::hash):
1014
1015 2009-11-19  Olivier Goffart  <ogoffart@trolltech.com>
1016
1017         Reviewed by Simon Hausmann.
1018
1019         [Qt] Normalize signal and slot signatures.
1020
1021         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
1022         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
1023
1024 2009-11-19  Alexander Pavlov  <apavlov@chromium.org>
1025
1026         Reviewed by Pavel Feldman.
1027
1028         Store cookie domains in the WebInspector object
1029
1030         The cookie domains have been moved from StoragePanel into WebInspector.
1031         Also, the document URLs are now passed inside the WebInspector.addResource()
1032         payload rather than pushed directly from InspectorController.
1033         https://bugs.webkit.org/show_bug.cgi?id=31627
1034
1035         * inspector/InspectorController.cpp:
1036         (WebCore::InspectorController::populateScriptObjects):
1037         (WebCore::InspectorController::didFinishLoading):
1038         * inspector/InspectorFrontend.cpp:
1039         * inspector/InspectorFrontend.h:
1040         * inspector/InspectorResource.cpp:
1041         (WebCore::InspectorResource::createScriptObject):
1042         (WebCore::InspectorResource::updateScriptObject):
1043         * inspector/front-end/StoragePanel.js:
1044         (WebInspector.StoragePanel.prototype.reset):
1045         (WebInspector.StoragePanel.prototype.addCookieDomain):
1046         * inspector/front-end/inspector.js:
1047         (WebInspector.addResource):
1048         (WebInspector.addCookieDomain):
1049         (WebInspector.reset):
1050
1051 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1052
1053         Reviewed by Darin Adler.
1054
1055         Allow custom memory allocation control for the other part of platform directory in WebCore
1056         https://bugs.webkit.org/show_bug.cgi?id=31585
1057
1058         Inherits the following classes from FastAllocBase because these are
1059         instantiated by 'new':
1060
1061         class RegularExpression    - instantiated at: WebCore/page/Frame.cpp:415
1062         class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
1063         class Path                 - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
1064         class FontPlatformData     - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188
1065
1066         Inherits the following classes from Noncopyable because these are
1067         instantiated by 'new' and no need to be copyable:
1068
1069         class Cursors                         - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
1070         class NetworkStateNotifier            - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
1071         struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71
1072
1073         class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
1074         class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119
1075
1076         * platform/graphics/MediaPlayerPrivate.h:
1077         * platform/graphics/Path.h:
1078         * platform/graphics/qt/FontPlatformData.h:
1079         * platform/graphics/transforms/TransformationMatrix.h:
1080         * platform/image-decoders/ImageDecoder.h:
1081         * platform/network/NetworkStateNotifier.h:
1082         * platform/network/ResourceRequestBase.h:
1083         * platform/qt/CursorQt.cpp:
1084         * platform/text/RegularExpression.h:
1085
1086 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1087
1088         Unreviewed.
1089
1090         [Qt] Build fix for QtWebKit after r51172.
1091
1092         * platform/qt/Localizations.cpp:
1093         (WebCore::validationMessageValueMissingText):
1094         (WebCore::validationMessageTypeMismatchText):
1095         (WebCore::validationMessagePatternMismatchText):
1096         (WebCore::validationMessageTooLongText):
1097         (WebCore::validationMessageRangeUnderflowText):
1098         (WebCore::validationMessageRangeOverflowText):
1099         (WebCore::validationMessageStepMismatchText):
1100
1101 2009-11-18  Dan Bernstein  <mitz@apple.com>
1102
1103         Reviewed by Simon Fraser.
1104
1105         Fixed <rdar://problem/7398987> Assertion failure in
1106         RenderLayer::updateClipRects when a plug-in’s enclosing layer is
1107         enclosed by a transformed layer
1108
1109         Tests: fast/layers/clip-rects-transformed-2.html
1110                fast/layers/clip-rects-transformed.html
1111
1112         * rendering/RenderLayer.cpp:
1113         (WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
1114         that is either transformed or composited. During painting and hit
1115         testing, when a transformed or composited layer is hit, it becomes the
1116         new root layer, which ultimately gets passed to calculateRects().
1117         (WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
1118         root layer to calculateRects(), and return the bounding box of the
1119         transformed rectangle.
1120         (WebCore::RenderLayer::selfClipRect): Ditto.
1121         * rendering/RenderLayer.h:
1122
1123 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1124
1125         Reviewed by Kenneth Rohde Christiansen.
1126
1127         [Qt] Remove support for Qt v4.3 or older versions
1128         https://bugs.webkit.org/show_bug.cgi?id=29469
1129
1130         No new tests as there is no change if compiled with 
1131         Qt v4.4 or later version.
1132
1133         * WebCore.pro:
1134         * dom/XMLTokenizerQt.cpp:
1135         (WebCore::EntityResolver::resolveUndeclaredEntity):
1136         (WebCore::XMLTokenizer::XMLTokenizer):
1137         (WebCore::XMLTokenizer::~XMLTokenizer):
1138         (WebCore::XMLTokenizer::doWrite):
1139         (WebCore::XMLTokenizer::startDocument):
1140         (WebCore::XMLTokenizer::parseDtd):
1141         * platform/graphics/qt/FontQt.cpp:
1142         * platform/graphics/qt/FontQt43.cpp: Removed.
1143         * platform/graphics/qt/ImageQt.cpp:
1144         * platform/network/ResourceHandleInternal.h:
1145         * platform/network/qt/QNetworkReplyHandler.cpp:
1146         * platform/network/qt/QNetworkReplyHandler.h:
1147         * platform/network/qt/ResourceHandleQt.cpp:
1148         (WebCore::ResourceHandle::start):
1149         (WebCore::ResourceHandle::cancel):
1150         (WebCore::ResourceHandle::loadResourceSynchronously):
1151         (WebCore::ResourceHandle::setDefersLoading):
1152         * platform/network/qt/ResourceRequest.h:
1153         * platform/network/qt/ResourceRequestQt.cpp:
1154         * platform/qt/ClipboardQt.cpp:
1155         (WebCore::ClipboardQt::clearData):
1156         * platform/qt/CookieJarQt.cpp:
1157         (WebCore::cookieJar):
1158         (WebCore::setCookies):
1159         (WebCore::cookies):
1160         (WebCore::cookiesEnabled):
1161         * platform/qt/PlatformKeyboardEventQt.cpp:
1162         (WebCore::keyIdentifierForQtKeyCode):
1163         (WebCore::windowsKeyCodeForKeyEvent):
1164         * platform/text/qt/TextBoundaries.cpp:
1165         * platform/text/qt/TextBreakIteratorQt.cpp:
1166         * plugins/qt/PluginDataQt.cpp:
1167         (WebCore::PluginData::initPlugins):
1168
1169 2009-11-18  Michelangelo De Simone  <micdesim@gmail.com>
1170
1171         Reviewed by Darin Adler.
1172
1173         Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
1174         Support for validationMessage attribute, as per HTML5 specs.
1175
1176         Test: fast/forms/validationMessage.html
1177
1178         * html/HTMLButtonElement.idl: validationMessage attribute
1179         * html/HTMLFieldSetElement.idl: validationMessage attribute
1180         * html/HTMLFormControlElement.cpp:
1181         * html/HTMLFormControlElement.h:
1182         * html/HTMLInputElement.idl: validationMessage attribute
1183         * html/HTMLSelectElement.idl: validationMessage attribute
1184         * html/HTMLTextAreaElement.idl: validationMessage attribute
1185         * html/ValidityState.cpp: new method to retrieve pertinent localized text
1186         * html/ValidityState.h:
1187         * page/mac/WebCoreViewFactory.h:
1188         * platform/LocalizedStrings.h:
1189         * platform/android/LocalizedStringsAndroid.cpp:
1190         * platform/gtk/LocalizedStringsGtk.cpp:
1191         * platform/haiku/LocalizedStringsHaiku.cpp:
1192         * platform/mac/LocalizedStringsMac.mm:
1193         * platform/wx/LocalizedStringsWx.cpp:
1194
1195 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1196
1197         Unreviewed.
1198
1199         Fix a typo. Remove the trailing semicolon
1200         from an include directive after r51137.
1201
1202         No new tests as there is no functional change.
1203
1204         * platform/qt/QWebPageClient.h:
1205
1206 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1207
1208         Unreviewed.
1209
1210         [Qt] Build fix for QtWebKit after r51159.
1211
1212         Include float.h for DBL_MANT_DIG. Not sure why this
1213         is not a problem for other ports.
1214
1215         * html/HTMLInputElement.cpp:
1216
1217 2009-11-19  Roland Steiner  <rolandsteiner@chromium.org>
1218
1219         Reviewed by Darin Adler.
1220
1221         Bug 31574 -  Crashing bug when removing <ruby> element
1222         (https://bugs.webkit.org/show_bug.cgi?id=31574)
1223
1224         Cause of the bug:
1225         1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
1226         2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
1227         3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
1228         4.) this triggers the special handling of child removal in RenderRubyRun that
1229             causes it to destroy itself
1230         5.) On returning from all this the renderer crashes when accessing a member
1231             or virtual function on this now illegal object.
1232
1233         I therefore added a flag that tracks if the ruby run is being destroyed.
1234         If so, avoid doing the special handling in removeChild that caused this.
1235         It's not the most elegant solution, but the easiest to implement without
1236         touching unrelated code. Also, it's self-documenting.
1237
1238         Test: fast/ruby/ruby-remove.html
1239
1240         * rendering/RenderRubyRun.cpp:
1241         (WebCore::RenderRubyRun::RenderRubyRun):
1242         (WebCore::RenderRubyRun::destroy):
1243         (WebCore::RenderRubyRun::removeChild):
1244         * rendering/RenderRubyRun.h:
1245
1246 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1247
1248         Reviewed by Kenneth Rohde Christiansen.
1249
1250         [Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
1251         https://bugs.webkit.org/show_bug.cgi?id=31643
1252
1253         No new tests as there is no functional change.
1254
1255         * WebCore.pro:
1256
1257 2009-11-18  Yong Li  <yong.li@torchmobile.com>
1258
1259         Reviewed by Eric Seidel.
1260
1261         Implement TextBoundaries for WINCE port.
1262         https://bugs.webkit.org/show_bug.cgi?id=27371
1263
1264         * platform/text/wince/TextBoundariesWince.cpp: Added.
1265
1266 2009-11-18  Yong Li  <yong.li@torchmobile.com>
1267
1268         Reviewed by Eric Seidel.
1269
1270         Implement TextBreakIterator for WINCE port.
1271         https://bugs.webkit.org/show_bug.cgi?id=27371
1272
1273         * platform/text/wince/TextBreakIteratorWince.cpp: Added.
1274
1275 2009-11-18  Kent Tamura  <tkent@chromium.org>
1276
1277         Reviewed by Darin Adler.
1278
1279         Add support for ValidityState.typeMismatch for the following INPUT types:
1280           date datetime datetime-local month time week
1281         https://bugs.webkit.org/show_bug.cgi?id=31342
1282
1283         Tests: fast/forms/ValidityState-typeMismatch-date.html
1284                fast/forms/ValidityState-typeMismatch-datetime.html
1285                fast/forms/ValidityState-typeMismatch-datetimelocal.html
1286                fast/forms/ValidityState-typeMismatch-month.html
1287                fast/forms/ValidityState-typeMismatch-time.html
1288                fast/forms/ValidityState-typeMismatch-week.html
1289
1290         * html/HTMLInputElement.cpp:
1291         (WebCore::HTMLInputElement::formStringToISODateTime): Check the type
1292           validity of the specified type and string using the ISODateTime class.
1293         * html/HTMLInputElement.h:
1294         * html/ValidityState.cpp:
1295         (WebCore::ValidityState::typeMismatch): Check the type validity
1296           for date, datetime, datetime-local, month, time and week with
1297           HTMLInputElemtn::formStringToISODateTime()
1298
1299 2009-11-18  Maciej Stachowiak  <mjs@apple.com>
1300
1301         Reviewed by Oliver Hunt.
1302
1303         Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
1304         https://bugs.webkit.org/show_bug.cgi?id=31237
1305         
1306         Also speeds up Dromaeo DOM Core tests by 1.31x.
1307
1308         * bindings/js/JSNodeCustom.cpp:
1309         (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N^2) behavior. The subtree
1310         mark bit was no longer effective; instead I changed things so only a node that has no ancestors
1311         with wrappers would do marking; there should be only one in the typical case (the root of the
1312         detached subtree).
1313         * dom/Node.cpp:
1314         (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
1315         * dom/Node.h: ditto
1316
1317 2009-11-18  Darin Adler  <darin@apple.com>
1318
1319         Reviewed by Sam Weinig.
1320
1321         Get rid of the redundant strokeType and fillType data members on
1322         a GraphicsContext as well as the FillOrStrokeType enum. Use
1323         null pointers instead.
1324
1325         * platform/graphics/GraphicsContext.cpp:
1326         (WebCore::GraphicsContext::setStrokeColor): Null out the pattern
1327         and gradient.
1328         (WebCore::GraphicsContext::setFillColor): Ditto.
1329         (WebCore::GraphicsContext::setStrokePattern): Null out the graident.
1330         (WebCore::GraphicsContext::setFillPattern): Ditto.
1331         (WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
1332         (WebCore::GraphicsContext::setFillGradient): Ditto.
1333
1334         * platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
1335
1336         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1337         (WebCore::setPlatformFill): Use null checks on fillPattern and
1338         fillGraident instead of a switch statement.
1339         (WebCore::setPlatformStroke): Ditto.
1340
1341         * platform/graphics/cg/GraphicsContextCG.cpp:
1342         (WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
1343         (WebCore::GraphicsContext::applyFillPattern): Ditto.
1344         (WebCore::calculateDrawingMode): Use fillPattern and strokePattern
1345         to see if there is a pattern instead of fillType and strokeType.
1346         (WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
1347         fillPattern, and strokePattern instead of fillType and strokeType.
1348         (WebCore::GraphicsContext::fillPath): Added FIXME about color space that
1349         is used in the pattern and gradient case probably erroneously. Moved
1350         gradient code inside an if statement. Streamlined pattern code and
1351         use an if statement. No switch any more.
1352         (WebCore::GraphicsContext::strokePath): Ditto.
1353         (WebCore::GraphicsContext::fillRect): Ditto.
1354         (WebCore::GraphicsContext::strokeRect): Ditto.
1355
1356         * platform/graphics/qt/GraphicsContextQt.cpp:
1357         (WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
1358         fillGraident instead of a switch statement.
1359         (WebCore::GraphicsContext::strokePath): Ditto.
1360         (WebCore::GraphicsContext::fillRect): Ditto.
1361
1362         * platform/graphics/wince/GraphicsContextWince.cpp:
1363         (WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
1364         (WebCore::GraphicsContext::fillRect): Ditto.
1365
1366 2009-11-18  Kent Tamura  <tkent@chromium.org>
1367
1368         Reviewed by Darin Adler.
1369
1370         Support for step attribute and ValidityStae.stepMismatch for
1371         type=number and range.  stepMismatch will be false if the
1372         difference between the current value and a multiple of the step
1373         value is very small.
1374
1375         Change the behavior of RenderSlider so that it always has a value
1376         rounded to the step attribute value.
1377
1378         https://bugs.webkit.org/show_bug.cgi?id=31331
1379
1380         Tests: fast/forms/ValidityState-stepMismatch-number.html
1381                fast/forms/ValidityState-stepMismatch-range.html
1382                fast/forms/ValidityState-stepMismatch-unsupported.html
1383                fast/forms/input-step.html
1384
1385         * html/HTMLAttributeNames.in: Add "step".
1386         * html/HTMLInputElement.cpp:
1387         (WebCore::HTMLInputElement::stepMismatch):
1388         (WebCore::HTMLInputElement::getStepParameters):
1389         (WebCore::HTMLInputElement::getAllowedValueStep):
1390         * html/HTMLInputElement.h:
1391         * html/HTMLInputElement.idl: Add "step".
1392         * html/ValidityState.cpp:
1393         (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
1394         * html/ValidityState.h:
1395         * rendering/RenderSlider.cpp:
1396         (WebCore::SliderRange::SliderRange):
1397         (WebCore::SliderRange::clampValue):
1398
1399 2009-11-18  Dmitry Titov  <dimich@chromium.org>
1400
1401         Reviewed by Darin Adler.
1402
1403         Need to ASSERT(isMainThread()) in ThreadShared methods.
1404         https://bugs.webkit.org/show_bug.cgi?id=31637
1405
1406         Added ASSERT(IsMainThread()) to all following methods:
1407         * platform/TreeShared.h:
1408         (WebCore::TreeShared::TreeShared):
1409         (WebCore::TreeShared::~TreeShared):
1410         (WebCore::TreeShared::ref):
1411         (WebCore::TreeShared::deref):
1412         (WebCore::TreeShared::setParent):
1413         (WebCore::TreeShared::parent):
1414
1415 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
1416
1417         Reviewed by Eric Seidel.
1418
1419         Add plugin visibility manual test
1420
1421         https://bugs.webkit.org/show_bug.cgi?id=31542
1422
1423         * manual-tests/plugins/windowed.html:
1424         * manual-tests/plugins/windowless.html:
1425
1426 2009-11-18  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
1427
1428         Reviewed by Pavel Feldman.
1429
1430         Web Inspector - remember last script displayed in Scripts panel
1431         https://bugs.webkit.org/show_bug.cgi?id=27552
1432
1433         Manual test added
1434         
1435         * inspector/front-end/ScriptsPanel.js:
1436         (WebInspector.ScriptsPanel.prototype.showScript):
1437         (WebInspector.ScriptsPanel.prototype.showResource):
1438         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
1439         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
1440         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
1441         (WebInspector.ScriptsPanel.prototype._goBack):
1442         (WebInspector.ScriptsPanel.prototype._goForward):
1443         * manual-tests/inspector/remember-last-script.html: Added.
1444
1445 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1446
1447         Reviewed by Dimitri Glazkov.
1448
1449         Win chromium is slow to draw transparent texts
1450         https://bugs.webkit.org/show_bug.cgi?id=31258
1451
1452         Create bounded transparency layers instead of just clipping.
1453
1454         No new tests because this is just a performance improvement.
1455
1456         * platform/graphics/chromium/FontChromiumWin.cpp:
1457         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1458
1459 2009-11-18  Shu Chang  <Chang.Shu@nokia.com>
1460
1461         Reviewed by Eric Seidel.
1462
1463         [Qt] Add support for displaying deleteButton.
1464         https://bugs.webkit.org/show_bug.cgi?id=31560
1465
1466         Test: LayoutTests/editing/deleting/5408255.html
1467
1468         * WebCore.qrc:
1469         * platform/graphics/qt/ImageQt.cpp:
1470         (loadResourcePixmap):
1471
1472 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
1473
1474         Reviewed by Eric Seidel.
1475
1476         Fix Qt build without JavaScript debugger.
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=31575
1479
1480         * page/Console.idl:
1481
1482 2009-11-18  Daniel Bates  <dbates@webkit.org>
1483
1484         Reviewed by Dave Hyatt.
1485
1486         https://bugs.webkit.org/show_bug.cgi?id=24971
1487         And
1488         <rdar://problem/7138265>
1489
1490         Fixes an issue where setting the height of a table row programmatically
1491         (via JavaScript) causes the table to be improperly rendered because the
1492         height of each row in the table is not recalculated with respect to the
1493         CSS height property.
1494
1495         In particular, programmatically setting the height of some table row causes
1496         the rows of that table to be rendered with a height equal to the minimum
1497         height required by the cells in that row, regardless of any specified cell
1498         heights. Instead, when RenderTableSection::recalcCells is called, the height
1499         of each row should be set to the CSS height property just as we do in
1500         RenderTableSection::addChild.
1501
1502         Test: fast/table/row-height-recalc2.html
1503
1504         * rendering/RenderTableSection.cpp:
1505         (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added.
1506         (WebCore::RenderTableSection::addChild): Moved code that set row height into
1507         method WebCore::setRowHeightToRowStyleHeightIfNotRelative.
1508         (WebCore::RenderTableSection::recalcCells): Modified to call
1509         WebCore::setRowHeightToRowStyleHeightIfNotRelative.
1510
1511 2009-11-18  Zoltan Horvath  <zoltan@webkit.org>
1512
1513         Reviewed by Darin Adler.
1514
1515         Allow custom memory allocation control for the part of platform directory in WebCore
1516         https://bugs.webkit.org/show_bug.cgi?id=31473
1517
1518         Inherits the following classes from FastAllocBase because these are
1519         instantiated by 'new':
1520
1521         class  AnimationList         - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
1522         class  Color                 - instantiated at WebCore/rendering/RenderTheme.cpp:48
1523         struct Length                - instantiated at WebCore/platform/Length.cpp:103
1524         class  PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
1525         class  ContextMenuItem       - instantiated at WebCore/platform/ContextMenu.cpp:70
1526         class  DeprecatedPtrList     - instantiated at WebCore/rendering/RenderBlock.cpp:2284
1527
1528         Inherits the following classes from Noncopyable because these are
1529         instantiated by 'new' and no need to be copyable:
1530
1531         class  GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
1532         class  FontCache              - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
1533         struct MediaPlayerFactory     - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
1534         class  DeprecatedPtrListNode  - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53
1535
1536         * platform/ContextMenuItem.h:
1537         * platform/DeprecatedPtrList.h:
1538         * platform/DeprecatedPtrListImpl.cpp:
1539         * platform/Length.h:
1540         * platform/PlatformKeyboardEvent.h:
1541         * platform/animation/AnimationList.h:
1542         * platform/graphics/Color.h:
1543         * platform/graphics/FontCache.h:
1544         * platform/graphics/GraphicsContextPrivate.h:
1545         * platform/graphics/MediaPlayer.cpp:
1546
1547 2009-11-18  Daniel Bates  <dbates@webkit.org>
1548
1549         Reviewed by Darin Adler.
1550
1551         https://bugs.webkit.org/show_bug.cgi?id=31186
1552
1553         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
1554         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
1555         These are more descriptive names so as to clear an ambiguity surrounding
1556         their usage. Also, renames associated setters and getters so that they
1557         coincide with the renamed fields.
1558
1559         No functionality was changed. So, no tests were included.
1560
1561         * bindings/objc/DOMHTML.mm:
1562         (-[DOMHTMLInputElement _isEdited]):
1563         (-[DOMHTMLTextAreaElement _isEdited]):
1564         * dom/Document.cpp:
1565         (WebCore::Document::setFocusedNode):
1566         * html/HTMLInputElement.cpp:
1567         (WebCore::HTMLInputElement::defaultEventHandler):
1568         * rendering/RenderTextControl.cpp:
1569         (WebCore::RenderTextControl::RenderTextControl):
1570         (WebCore::RenderTextControl::setInnerTextValue):
1571         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
1572         (WebCore::RenderTextControl::subtreeHasChanged):
1573         * rendering/RenderTextControl.h:
1574         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
1575         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
1576         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
1577         * rendering/RenderTextControlSingleLine.cpp:
1578         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
1579         * wml/WMLInputElement.cpp:
1580         (WebCore::WMLInputElement::defaultEventHandler):
1581
1582 2009-11-18  Tony Chang  <tony@chromium.org>
1583
1584         Reviewed by Adam Barth.
1585
1586         Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
1587         https://bugs.webkit.org/show_bug.cgi?id=31499
1588
1589         No new tests, just a build cleanup.
1590
1591         * WebCore.gypi:
1592         * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
1593         * bindings/v8/custom/V8CustomBinding.h:
1594
1595 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1596
1597         Reviewed by Kevin Ollivier.
1598
1599         Enable wx plugin support using the Windows implementation as a base.
1600         
1601         https://bugs.webkit.org/show_bug.cgi?id=31636
1602
1603         * platform/graphics/GraphicsContext.h:
1604         (WebCore::GraphicsContext::inTransparencyLayer):
1605         * platform/graphics/wx/GraphicsContextWx.cpp:
1606         (WebCore::GraphicsContext::getWindowsContext):
1607         (WebCore::GraphicsContext::releaseWindowsContext):
1608         * platform/wx/FileSystemWx.cpp:
1609         (WebCore::unloadModule):
1610         (WebCore::listDirectory):
1611         * plugins/PluginDatabase.cpp:
1612         * plugins/PluginView.cpp:
1613         (WebCore::PluginView::stop):
1614         (WebCore::PluginView::PluginView):
1615         * plugins/PluginView.h:
1616         * plugins/win/PluginViewWin.cpp:
1617         (windowHandleForPageClient):
1618         (WebCore::PluginView::handleMouseEvent):
1619         (WebCore::PluginView::platformStart):
1620         (WebCore::PluginView::snapshot):
1621         * wscript:
1622
1623 2009-11-18  Andrei Popescu  <andreip@google.com>
1624
1625         Reviewed by Dimitri Glazkov.
1626
1627         [Android] Add shared timer and sound utilities to platform/android
1628         https://bugs.webkit.org/show_bug.cgi?id=31584
1629
1630         No new tests required, this is platform specific code.
1631
1632         * platform/android/SharedTimerAndroid.cpp: Added.
1633         (WebCore::setSharedTimerFiredFunction):
1634         (WebCore::setSharedTimerFireTime):
1635         (WebCore::stopSharedTimer):
1636         * platform/android/SoundAndroid.cpp: Added.
1637         (WebCore::systemBeep):
1638
1639 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
1640
1641         Reviewed by Timothy Hatcher.
1642
1643         Fix profile tree nodes loss after focus / restore actions.
1644
1645         Focusing on a node is currently implemented via nodes reattaching
1646         with some caching involved. It seems that not all code was updated
1647         to handle this scenario correctly.
1648
1649         https://bugs.webkit.org/show_bug.cgi?id=31553
1650
1651         * inspector/front-end/BottomUpProfileDataGridTree.js:
1652         (WebInspector.BottomUpProfileDataGridNode):
1653         (WebInspector.BottomUpProfileDataGridNode.prototype._restore):
1654         (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
1655         (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
1656         * inspector/front-end/DataGrid.js:
1657         (WebInspector.DataGrid.prototype.insertChild):
1658         (WebInspector.DataGridNode.prototype._detach):
1659         (WebInspector.DataGridNode.prototype.savePosition):
1660         (WebInspector.DataGridNode.prototype.restorePosition):
1661         * inspector/front-end/TopDownProfileDataGridTree.js:
1662         (WebInspector.TopDownProfileDataGridTree.prototype.focus):
1663         (WebInspector.TopDownProfileDataGridTree.prototype.restore):
1664
1665 2009-11-18  Carol Szabo  <carol.szabo@nokia.com>
1666
1667         Reviewed by Kenneth Rohde Christiansen.
1668
1669         [Qt] QWebPageClient.h needs in some cases QCursor, but it does not
1670         include it 
1671         https://bugs.webkit.org/show_bug.cgi?id=31527
1672
1673         No new tests as this is just a coding style fix that affects the 
1674         build of some not yet submitted patches (i.e. for bug 30173).
1675
1676         * platform/qt/QWebPageClient.h:
1677
1678 2009-11-18  Nicolas Roard   <nicolas@roard.com>
1679
1680         Reviewed by Dimitri Glazkov.
1681
1682         InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
1683         https://bugs.webkit.org/show_bug.cgi?id=31504
1684
1685         * inspector/InspectorTimelineAgent.h:Added the guard.
1686
1687 2009-11-18  Jens Alfke  <snej@chromium.org>
1688
1689         Build fix to my previous checkin, for Windows Chromium
1690
1691         * svg/SVGAnimatedProperty.h:
1692         (WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.
1693
1694 2009-11-18  Joseph Pecoraro  <joepeck@webkit.org>
1695
1696         Reviewed by Pavel Feldman.
1697
1698         Web Inspector: Directly Access <head> Instead of Searching for It
1699         https://bugs.webkit.org/show_bug.cgi?id=31641
1700         
1701         Changed old access of the head element (document.getElementsByTagName)
1702         to just use the document.head accessor.
1703
1704         * inspector/front-end/FontView.js:
1705         (WebInspector.FontView):
1706         * inspector/front-end/InjectedScript.js:
1707         (InjectedScript.addStyleSelector):
1708         * inspector/front-end/SourceFrame.js:
1709         (WebInspector.SourceFrame.prototype._loaded):
1710         * inspector/front-end/inspector.js:
1711         (windowLoaded):
1712
1713 2009-11-18  Sam Weinig  <sam@webkit.org>
1714
1715         Reviewed by Anders Carlsson.
1716
1717         Fix two Geolocation assertions.
1718
1719         * page/Chrome.cpp:
1720         (WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
1721         is not called from JS. 
1722         * page/Geolocation.cpp:
1723         (WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
1724         a RefPtr first.
1725
1726 2009-11-18  Alexey Proskuryakov  <ap@apple.com>
1727
1728         Case sensitive file system build fix.
1729
1730         * platform/network/Credential.h: It's not WTF, just wtf.
1731
1732 2009-11-18  Aaron Golden  <agolden@apple.com>
1733
1734         Reviewed by Alexey Proskuryakov.
1735
1736         Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
1737         objects and WebCore::Credential objects without losing certificate information.
1738
1739         * platform/network/Credential.cpp:
1740         (WebCore::Credential::Credential):  Adding a constructor that takes an identity argument and a certificate chain argument
1741         (WebCore::Credential::isEmpty):  Modifying isEmpty to support certificate based credentials (which don't have a username or password)
1742         (WebCore::Credential::identity): Accessor for the m_identity property
1743         (WebCore::Credential::certificates): Accessor for the m_certificates property
1744         (WebCore::Credential::type):  Accessor for the m_type property
1745         (WebCore::operator==):  Modifying == to compare the identity and certificate chains of certificate based credentials.
1746         * platform/network/Credential.h:  Adding new fields to WebCore::Credential to support certificate based credentials.
1747         * platform/network/mac/AuthenticationMac.mm:
1748         (WebCore::mac):  Modifying the mac() conversion method to correctly convert certificate based WebCore::Credential objects.
1749         (WebCore::core):  Modifying the core() conversion method to correctly convert certificate based NSURLCredential objects.
1750
1751 2009-11-18  Dmitry Titov  <dimich@chromium.org>
1752
1753         Reviewed by Eric Seidel.
1754
1755         Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
1756         https://bugs.webkit.org/show_bug.cgi?id=31615
1757
1758         * dom/Document.cpp:
1759         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
1760         (WebCore::ScriptExecutionContextTaskTimer::fired):
1761         (WebCore::PerformTaskContext::PerformTaskContext):
1762         (WebCore::performTask):
1763         (WebCore::Document::postTask):
1764         * dom/ScriptExecutionContext.cpp:
1765         * dom/ScriptExecutionContext.h:
1766
1767 2009-11-18  Jens Alfke  <snej@chromium.org>
1768
1769         Reviewed by Darin Adler.
1770
1771         Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
1772         by causing the right v8-to-WebCore conversion function to be called for every parameter.
1773         This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
1774         To enforce correctness, I added a mode that disables implicit
1775         String-->AtomicString conversions while compiling the generated bindings.
1776         https://bugs.webkit.org/show_bug.cgi?id=31168
1777
1778         * bindings/scripts/CodeGeneratorV8.pm:  Generate usage of V8Parameter class.
1779         * bindings/v8/DerivedSourcesAllInOne.cpp:  Enable NO_IMPLICIT_ATOMICSTRING.
1780         * bindings/v8/V8Binding.h:  Add V8Parameter class.
1781         * css/WebKitCSSKeyframesRule.h:  Make AtomicString conversions explicit.
1782         * dom/Document.idl:  Remove obsolete [HintAtomic] annotation.
1783         * platform/text/AtomicString.h:  Added NO_IMPLICIT_ATOMICSTRING option.
1784         * svg/SVGAnimatedTemplate.h:  Change some return types to String to avoid implicit conversion.
1785         * svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.
1786
1787 2009-11-18  Darin Adler  <darin@apple.com>
1788
1789         Reviewed by Dan Bernstein.
1790
1791         Move FillOrStrokeType out of public header.
1792
1793         * platform/graphics/GraphicsContext.h: Updated copyright date to cover
1794         some years we published Apple changes, sorted forward declarations,
1795         removed FillOrStrokeType enum.
1796         * platform/graphics/GraphicsContextPrivate.h: Updated copyright date
1797         to cover some years we published Apple changes, sorted includes,
1798         moved FillOrStrokeType enum here.
1799
1800 2009-11-18  Chris Marrin  <cmarrin@apple.com>
1801
1802         Reviewed by Simon Fraser.
1803
1804         Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
1805         https://bugs.webkit.org/show_bug.cgi?id=31601
1806
1807         These are used to debug accelerated compositing layers. I removed
1808         the platform specific code from GraphicsLayerCA.mm and added calls
1809         to GraphicsLayerClient to get it from the higher levels. The values 
1810         now get cached in RenderLayerCompositing and are queried from there
1811         by RenderLayerBacking (which implements the GraphicsLayerClient interface).
1812
1813         * WebCore.base.exp:
1814         * page/FrameView.cpp:
1815         (WebCore::FrameView::updateCompositingLayers):
1816         * page/Settings.cpp:
1817         (WebCore::Settings::Settings):
1818         (WebCore::Settings::setShowDebugBorders):
1819         (WebCore::Settings::setShowRepaintCounter):
1820         * page/Settings.h:
1821         (WebCore::Settings::showDebugBorders):
1822         (WebCore::Settings::showRepaintCounter):
1823         * platform/graphics/GraphicsLayer.h:
1824         (WebCore::GraphicsLayer::showDebugBorders):
1825         (WebCore::GraphicsLayer::showRepaintCounter):
1826         * platform/graphics/GraphicsLayerClient.h:
1827         * platform/graphics/mac/GraphicsLayerCA.mm:
1828         * rendering/RenderLayerBacking.cpp:
1829         (WebCore::RenderLayerBacking::showDebugBorders):
1830         (WebCore::RenderLayerBacking::showRepaintCounter):
1831         * rendering/RenderLayerBacking.h:
1832         * rendering/RenderLayerCompositor.cpp:
1833         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
1834         (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
1835         * rendering/RenderLayerCompositor.h:
1836         (WebCore::RenderLayerCompositor::showDebugBorders):
1837         (WebCore::RenderLayerCompositor::showRepaintCounter):
1838
1839 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1840
1841         Reviewed by Timothy Hatcher.
1842
1843         Web Inspector: Get rid of metrics and properties sidebars'
1844         flickering.
1845
1846         https://bugs.webkit.org/show_bug.cgi?id=31629
1847
1848         * inspector/front-end/MetricsSidebarPane.js:
1849         * inspector/front-end/PropertiesSidebarPane.js:
1850
1851 2009-11-17  Brian Weinstein  <bweinstein@apple.com>
1852
1853         Reviewed by Pavel Feldman.
1854
1855         Fixes <http://webkit.org/b/31606>.
1856         Web Inspector: Enter/Return key should enter edit mode for Editable Fields.
1857         
1858         This implements Enter starting editing mode in an editable DataGrid. If the
1859         DataGrid is editable and the user hits return, startEditing the first child
1860         of the selected node. Also refactored some editing functions to take an 
1861         event target instead of the event itself, because the functions only needed
1862         the target. Lastly, added had return in editing mode stop propogation, because
1863         when enter was hit to confirm text, it would propagate back to the datagrid
1864         and try to start editing again.
1865
1866         * inspector/front-end/DataGrid.js:
1867         (WebInspector.DataGrid.prototype._ondblclick):
1868         (WebInspector.DataGrid.prototype._startEditing):
1869         (WebInspector.DataGrid.prototype.handleKeyEvent):
1870         (WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
1871         (WebInspector.DataGrid.prototype._mouseDownInDataTable):
1872         (WebInspector.DataGrid.prototype._clickInDataTable):
1873         * inspector/front-end/inspector.js:
1874         (WebInspector.startEditing.element.handleKeyEvent):
1875         (WebInspector.startEditing):
1876
1877 2009-11-18  Ben Murdoch  <benm@google.com>
1878
1879         Reviewed by Darin Adler.
1880
1881         HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
1882         https://bugs.webkit.org/show_bug.cgi?id=31593
1883
1884         Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html
1885
1886         * html/HTMLAnchorElement.cpp:
1887         (WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.
1888
1889 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1890
1891         Not reviewed. Touch InspectorController so that frontend
1892         JS files are deployed on Windows.
1893
1894         * inspector/InspectorController.cpp:
1895
1896 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1897
1898         Reviewed by Timothy Hatcher.
1899
1900         Web Inspector: clone timeline records array instead of
1901         copying reference on invalidate all.
1902
1903         https://bugs.webkit.org/show_bug.cgi?id=31596
1904
1905         * inspector/front-end/AbstractTimelinePanel.js:
1906         (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
1907
1908 2009-11-18  Simon Fraser  <simon.fraser@apple.com>
1909
1910         Reviewed by Dan Bernstein.
1911
1912         Elements don't drop out of compositing layers when animation ends
1913         https://bugs.webkit.org/show_bug.cgi?id=31613
1914         <rdar://problem/7402913>
1915
1916         Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
1917         are compositing anyway for other reasons. Doing so can cause those layers
1918         to stay in compositing mode even after animations finish, because needsToBeComposited()
1919         continues to return true.
1920         
1921         No new tests because it's not possible to determine which elements are in
1922         compositing layers from DRT output.
1923
1924         * rendering/RenderLayerCompositor.cpp:
1925         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
1926
1927 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
1928
1929         Reviewed by Tor Arne Vestbø.
1930
1931         [Qt] Mac Plugins: Remove null timer
1932         
1933         A null timer was used to send mouse move events. Instead, we now use
1934         move events to send nullEvent. This brings down CPU usage by 20-30%.
1935         
1936         https://bugs.webkit.org/show_bug.cgi?id=31624
1937
1938         * plugins/PluginView.h:
1939         * plugins/mac/PluginViewMac.cpp:
1940         (WebCore::PluginView::platformStart):
1941         (WebCore::PluginView::handleMouseEvent):
1942
1943 2009-11-18  Benjamin Poulain  <benjamin.poulain@nokia.com>
1944
1945         Reviewed by Simon Hausmann.
1946
1947         [Qt] WebKit crashes when loading certain SVG images
1948
1949         Check if the familly exist before creating the PlatformData from it.
1950
1951         https://bugs.webkit.org/show_bug.cgi?id=29443
1952
1953         Test: svg/text/text-font-invalid.html
1954
1955         * platform/graphics/qt/FontFallbackListQt.cpp:
1956         (WebCore::FontFallbackList::fontDataAt):
1957
1958 2009-11-17  Nicolas Weber  <thakis@chromium.org>
1959
1960         Reviewed by Darin Fisher.
1961
1962         Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
1963         after navigation.
1964         https://bugs.webkit.org/show_bug.cgi?id=31609
1965
1966         * platform/chromium/PopupMenuChromium.cpp:
1967         (WebCore::PopupContainer::showExternal): Set parent for external
1968         dropdowns, so that |PopupListBox::hidePopup()| can successfully notify
1969         its parent's client.
1970
1971 2009-11-17  Hayato Ito  <hayato@google.com>
1972
1973         Reviewed by Darin Adler.
1974
1975         Avoid infinite mutual recursion when deeply nested tags are loaded
1976         https://bugs.webkit.org/show_bug.cgi?id=30651
1977
1978         Test: fast/parser/block-nesting-cap-table.html
1979
1980         * html/HTMLParser.cpp:
1981         (WebCore::HTMLParser::parseToken):
1982         (WebCore::tagPriorityOfNode):
1983         (WebCore::HTMLParser::limitBlockDepth):
1984         (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth):
1985         (WebCore::HTMLParser::insertNode):
1986         * html/HTMLParser.h:
1987
1988 2009-11-17  Brent Fulgham  <bfulgham@webkit.org>
1989
1990         Rubber-stamped by Alexey Proskuryakov.
1991
1992         Final clean-ups for minor coding standard violations.
1993         https://bugs.webkit.org/show_bug.cgi?id=26102.
1994
1995         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1996
1997 2009-11-17  Johnny Ding  <jnd@chromium.org>
1998
1999         Reviewed by Darin Adler.
2000
2001         In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
2002         https://bugs.webkit.org/show_bug.cgi?id=31567
2003
2004         * dom/ScriptElement.cpp:
2005         (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
2006
2007 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
2008
2009         Reviewed by Timothy Hatcher.
2010
2011         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
2012         - Updated DRT to show/close inspector for all tests under /inspector
2013         - Introduced LayoutTestController::setTimelineProfilingEnabled and
2014           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
2015         - Removed reload on each inspector test
2016         - Renamed fast/inspector to fast/inspector-support in order not to trigger
2017         inspector for those.
2018         - Reimplemented timeline tests in order to get rid of reload there.
2019         - Moved tests that don't require harness into the fast group.
2020
2021         https://bugs.webkit.org/show_bug.cgi?id=31472
2022
2023         * WebCore.Inspector.exp:
2024         * inspector/front-end/TimelinePanel.js:
2025         (WebInspector.TimelinePanel.prototype._formatRecord):
2026
2027 2009-11-17  Andrei Popescu  <andreip@google.com>
2028
2029         Reviewed by Dimitri Glazkov.
2030
2031         [Android] Android is missing the implementation of the GeolocationService iface.
2032         https://bugs.webkit.org/show_bug.cgi?id=31554
2033
2034         No new tests required as this is platform specific code.
2035
2036         * platform/android/GeolocationServiceAndroid.cpp: Added.
2037         (WebCore::GeolocationServiceAndroid::create):
2038         (WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
2039         (WebCore::GeolocationServiceAndroid::startUpdating):
2040         (WebCore::GeolocationServiceAndroid::stopUpdating):
2041         (WebCore::GeolocationServiceAndroid::suspend):
2042         (WebCore::GeolocationServiceAndroid::resume):
2043         (WebCore::GeolocationServiceAndroid::newPositionAvailable):
2044         (WebCore::GeolocationServiceAndroid::newErrorAvailable):
2045         (WebCore::GeolocationServiceAndroid::timerFired):
2046         (WebCore::GeolocationServiceAndroid::isPositionMovement):
2047         (WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
2048         (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):
2049         * platform/android/GeolocationServiceAndroid.h: Added.
2050         (WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
2051         (WebCore::GeolocationServiceAndroid::lastPosition):
2052         (WebCore::GeolocationServiceAndroid::lastError):
2053         * platform/android/GeolocationServiceBridge.cpp: Added.
2054         (WebCore::):
2055         (WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
2056         (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
2057         (WebCore::GeolocationServiceBridge::start):
2058         (WebCore::GeolocationServiceBridge::stop):
2059         (WebCore::GeolocationServiceBridge::setEnableGps):
2060         (WebCore::GeolocationServiceBridge::newLocationAvailable):
2061         (WebCore::GeolocationServiceBridge::newErrorAvailable):
2062         (WebCore::GeolocationServiceBridge::toGeoposition):
2063         (WebCore::GeolocationServiceBridge::startJavaImplementation):
2064         (WebCore::GeolocationServiceBridge::stopJavaImplementation):
2065         * platform/android/GeolocationServiceBridge.h: Added.
2066
2067 2009-11-16  Kent Tamura  <tkent@chromium.org>
2068
2069         Unreviewd build fix.
2070
2071         - Fix typo in WebCore.vcproj.
2072         - Intlude limits.h for INT_MAX.
2073         - Enclose with parenthesis to suspress warning.
2074
2075         * WebCore.vcproj/WebCore.vcproj:
2076         * html/ISODateTime.cpp:
2077         (WebCore::ISODateTime::addDay):
2078
2079 2009-11-16  Robin Dunn  <robin@alldunn.com>
2080
2081         Reviewed by Kevin Ollivier.
2082
2083         Make sure wx scrollbar drawing code factors in transforms when switching backends,
2084         fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.
2085         
2086         https://bugs.webkit.org/show_bug.cgi?id=31570
2087
2088         * platform/wx/ScrollbarThemeWx.cpp:
2089         (WebCore::ScrollbarThemeWx::minimumThumbLength):
2090         (WebCore::ScrollbarThemeWx::splitTrack):
2091         (WebCore::ScrollbarThemeWx::forwardButtonRect):
2092         * platform/wx/ScrollbarThemeWx.h:
2093         * platform/wx/wxcode/gtk/scrollbar_render.cpp:
2094         (wxRenderer_DrawScrollbar):
2095         * platform/wx/wxcode/scrollbar_render.h:
2096         (calcThumbStartAndLength):
2097         * platform/wx/wxcode/win/scrollbar_render.cpp:
2098         (wxRenderer_DrawScrollbar):
2099
2100 2009-11-16  Kent Tamura  <tkent@chromium.org>
2101
2102         Reviewed by David Levin.
2103
2104         Introduce WebCore::ISODateTime class.
2105         https://bugs.webkit.org/show_bug.cgi?id=31340
2106
2107         This class represents a value of date/time types of the HTML5 INPUT
2108         element, and has some parsing methods for ISO 8601.
2109
2110         This change has no tests because the class is not used yet.
2111
2112         * GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
2113         * WebCore.gypi: ditto.
2114         * WebCore.pro: ditto.
2115         * WebCore.vcproj/WebCore.vcproj: ditto.
2116         * WebCore.xcodeproj/project.pbxproj: ditto.
2117         * WebCoreSources.bkl: ditto.
2118         * html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class.
2119         (WebCore::isLeapYear):
2120         (WebCore::maxDayOfMonth):
2121         (WebCore::dayOfWeek):
2122         (WebCore::ISODateTime::maxWeekNumberInYear):
2123         (WebCore::countDigits):
2124         (WebCore::toInt):
2125         (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek().
2126         (WebCore::ISODateTime::addDay): Private helper for parseTimeZone().
2127         (WebCore::ISODateTime::addMinute): ditto.
2128         (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime().
2129         (WebCore::ISODateTime::parseMonth): Parser for <input type=month>.
2130         (WebCore::ISODateTime::parseDate): Parser for <input type=date>.
2131         (WebCore::ISODateTime::parseWeek): Parser for <input type=week>.
2132         (WebCore::ISODateTime::parseTime): Parser for <input type=time>.
2133         (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>.
2134         (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
2135         * html/ISODateTime.h: Added.  Declare WebCore::ISODateTime class.
2136         (WebCore::ISODateTime::ISODateTime):
2137         (WebCore::ISODateTime::millisecond):
2138         (WebCore::ISODateTime::second):
2139         (WebCore::ISODateTime::minute):
2140         (WebCore::ISODateTime::hour):
2141         (WebCore::ISODateTime::monthDay):
2142         (WebCore::ISODateTime::month):
2143         (WebCore::ISODateTime::fullYear):
2144         (WebCore::ISODateTime::week):
2145
2146 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2147
2148         Fix a typo in previous commit.
2149
2150         * platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.
2151
2152 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2153
2154         Fix a typo in previous commit.
2155
2156         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2157
2158 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2159
2160         Tiger build fix.
2161
2162         * platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named
2163         differently in Tiger CFNetwork.
2164
2165 2009-11-16  Dimitri Glazkov  <dglazkov@chromium.org>
2166
2167         Reviewed by Darin Fisher.
2168
2169         [KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.
2170
2171         Fix a bug in the code that was dormant until http://trac.webkit.org/changeset/50784.
2172
2173         Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html
2174
2175         * platform/KURLGoogle.cpp:
2176         (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.
2177
2178 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2179
2180         Rubber-stamped by Jon Honeycutt.
2181
2182         A better Windows build fix
2183
2184         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
2185         Use a macro that inserts __declspec(dllimport) when appropriate for CFNetwork imports.
2186
2187 2009-11-16  Yael Aharon  <yael.aharon@nokia.com>
2188
2189         Reviewed by Darin Adler.
2190
2191         Rename protocolIsValid to isValidProtocol.
2192         https://bugs.webkit.org/show_bug.cgi?id=31503
2193
2194         This name change was suggested in https://bugs.webkit.org/show_bug.cgi?id=29972#c19.
2195
2196         No new tests since no new functionality was introduced.
2197
2198         * html/HTMLAnchorElement.cpp:
2199         (WebCore::HTMLAnchorElement::setProtocol):
2200         * platform/KURL.cpp:
2201         (WebCore::isValidProtocol):
2202         * platform/KURL.h:
2203         * platform/KURLGoogle.cpp:
2204         (WebCore::isValidProtocol):
2205
2206 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
2207
2208         Reviewed by Beth Dakin.
2209
2210         AX: aria-labelledby duplicates some of its WAI-ARIA label
2211         https://bugs.webkit.org/show_bug.cgi?id=31565
2212
2213         Test: accessibility/aria-labelledby-overrides-label.html
2214
2215         * accessibility/AccessibilityRenderObject.cpp:
2216         (WebCore::AccessibilityRenderObject::hasTextAlternative):
2217         (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
2218         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2219         * accessibility/AccessibilityRenderObject.h:
2220
2221 2009-11-16  Nate Chapin  <japhet@chromium.org>
2222
2223         Reviewed by Darin Fisher.
2224
2225         Handle the case of a null NPObject* in NPN_SetException in
2226         the V8 bindings.  This allow out of process plugins calling
2227         NPN_SetException to just send null instead of sending an
2228         NPObject* that would be an address in a different 
2229         process's memory space.
2230
2231         https://bugs.webkit.org/show_bug.cgi?id=31561
2232
2233         * bindings/v8/NPV8Object.cpp:
2234         (_NPN_SetException): Allow null NPObject* and just throw a general error.
2235
2236 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2237
2238         Windows build fix.
2239
2240         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
2241         Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.
2242
2243 2009-11-14  Yael Aharon  <yael.aharon@nokia.com>
2244
2245         Reviewed by Kenneth Rohde Christiansen.
2246
2247         [Qt] ASSERT failure while running DRT
2248         https://bugs.webkit.org/show_bug.cgi?id=30978
2249
2250         Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
2251         These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.
2252
2253         * bridge/qt/qt_instance.cpp:
2254         (JSC::Bindings::QtRuntimeObjectImp::createStructure):
2255         * bridge/qt/qt_runtime.h:
2256         (JSC::Bindings::QtRuntimeMethod::createStructure):
2257
2258 2009-11-16  Mark Rowe  <mrowe@apple.com>
2259
2260         Attempt to fix the build.  Land a file that was missing from r51049.
2261
2262         * bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.
2263         (WebCore::setWebGLArrayFromArray):
2264
2265 2009-11-16  Kenneth Russell  <kbr@google.com>
2266
2267         Reviewed by Oliver Hunt.
2268
2269         Update API of WebGLArray and friends
2270         https://bugs.webkit.org/show_bug.cgi?id=31175
2271
2272         * bindings/js/JSWebGLArrayCustom.cpp:
2273         (WebCore::toJS):
2274         * bindings/js/JSWebGLArrayHelper.h: Added.
2275         (WebCore::setWebGLArrayFromArray):
2276         * bindings/js/JSWebGLByteArrayCustom.cpp:
2277         (WebCore::JSWebGLByteArray::set):
2278         * bindings/js/JSWebGLFloatArrayCustom.cpp:
2279         (WebCore::JSWebGLFloatArray::set):
2280         * bindings/js/JSWebGLIntArrayCustom.cpp:
2281         (WebCore::JSWebGLIntArray::set):
2282         * bindings/js/JSWebGLShortArrayCustom.cpp:
2283         (WebCore::JSWebGLShortArray::set):
2284         * bindings/js/JSWebGLUnsignedByteArrayCustom.cpp:
2285         (WebCore::JSWebGLUnsignedByteArray::set):
2286         * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
2287         (WebCore::JSWebGLUnsignedIntArray::set):
2288         * bindings/js/JSWebGLUnsignedShortArrayCustom.cpp:
2289         (WebCore::JSWebGLUnsignedShortArray::set):
2290         * bindings/scripts/CodeGeneratorV8.pm:
2291         * bindings/v8/V8DOMWrapper.cpp:
2292         (WebCore::V8DOMWrapper::convertToV8Object):
2293         * bindings/v8/custom/V8CustomBinding.h:
2294         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2295         (WebCore::CALLBACK_FUNC_DECL):
2296         * bindings/v8/custom/V8WebGLArrayCustom.h:
2297         (WebCore::constructWebGLArray):
2298         (WebCore::getWebGLArrayElement):
2299         (WebCore::setWebGLArrayFromArray):
2300         (WebCore::setWebGLArray):
2301         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2302         (WebCore::CALLBACK_FUNC_DECL):
2303         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2304         (WebCore::CALLBACK_FUNC_DECL):
2305         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2306         (WebCore::CALLBACK_FUNC_DECL):
2307         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2308         (WebCore::CALLBACK_FUNC_DECL):
2309         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2310         (WebCore::CALLBACK_FUNC_DECL):
2311         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2312         (WebCore::CALLBACK_FUNC_DECL):
2313         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2314         (WebCore::CALLBACK_FUNC_DECL):
2315         * html/canvas/WebGLArray.cpp:
2316         (WebCore::WebGLArray::WebGLArray):
2317         (WebCore::WebGLArray::~WebGLArray):
2318         (WebCore::WebGLArray::setImpl):
2319         * html/canvas/WebGLArray.h:
2320         (WebCore::WebGLArray::isByteArray):
2321         (WebCore::WebGLArray::isUnsignedByteArray):
2322         (WebCore::WebGLArray::isShortArray):
2323         (WebCore::WebGLArray::isUnsignedShortArray):
2324         (WebCore::WebGLArray::isIntArray):
2325         (WebCore::WebGLArray::isUnsignedIntArray):
2326         (WebCore::WebGLArray::isFloatArray):
2327         (WebCore::WebGLArray::buffer):
2328         (WebCore::WebGLArray::baseAddress):
2329         (WebCore::WebGLArray::byteOffset):
2330         * html/canvas/WebGLArray.idl:
2331         * html/canvas/WebGLArrayBuffer.cpp:
2332         (WebCore::WebGLArrayBuffer::create):
2333         (WebCore::WebGLArrayBuffer::WebGLArrayBuffer):
2334         (WebCore::WebGLArrayBuffer::data):
2335         (WebCore::WebGLArrayBuffer::byteLength):
2336         (WebCore::WebGLArrayBuffer::~WebGLArrayBuffer):
2337         * html/canvas/WebGLArrayBuffer.h:
2338         * html/canvas/WebGLByteArray.cpp:
2339         (WebCore::WebGLByteArray::create):
2340         (WebCore::WebGLByteArray::byteLength):
2341         (WebCore::WebGLByteArray::slice):
2342         (WebCore::WebGLByteArray::set):
2343         * html/canvas/WebGLByteArray.h:
2344         (WebCore::WebGLByteArray::isByteArray):
2345         (WebCore::WebGLByteArray::data):
2346         (WebCore::WebGLByteArray::set):
2347         (WebCore::WebGLByteArray::get):
2348         (WebCore::WebGLByteArray::item):
2349         * html/canvas/WebGLByteArray.idl:
2350         * html/canvas/WebGLFloatArray.cpp:
2351         (WebCore::WebGLFloatArray::create):
2352         (WebCore::WebGLFloatArray::WebGLFloatArray):
2353         (WebCore::WebGLFloatArray::length):
2354         (WebCore::WebGLFloatArray::byteLength):
2355         (WebCore::WebGLFloatArray::slice):
2356         (WebCore::WebGLFloatArray::set):
2357         * html/canvas/WebGLFloatArray.h:
2358         (WebCore::WebGLFloatArray::isFloatArray):
2359         (WebCore::WebGLFloatArray::data):
2360         (WebCore::WebGLFloatArray::set):
2361         (WebCore::WebGLFloatArray::get):
2362         (WebCore::WebGLFloatArray::item):
2363         * html/canvas/WebGLFloatArray.idl:
2364         * html/canvas/WebGLIntArray.cpp:
2365         (WebCore::WebGLIntArray::create):
2366         (WebCore::WebGLIntArray::WebGLIntArray):
2367         (WebCore::WebGLIntArray::length):
2368         (WebCore::WebGLIntArray::byteLength):
2369         (WebCore::WebGLIntArray::slice):
2370         (WebCore::WebGLIntArray::set):
2371         * html/canvas/WebGLIntArray.h:
2372         (WebCore::WebGLIntArray::isIntArray):
2373         (WebCore::WebGLIntArray::data):
2374         (WebCore::WebGLIntArray::set):
2375         (WebCore::WebGLIntArray::get):
2376         (WebCore::WebGLIntArray::item):
2377         * html/canvas/WebGLIntArray.idl:
2378         * html/canvas/WebGLShortArray.cpp:
2379         (WebCore::WebGLShortArray::create):
2380         (WebCore::WebGLShortArray::WebGLShortArray):
2381         (WebCore::WebGLShortArray::length):
2382         (WebCore::WebGLShortArray::byteLength):
2383         (WebCore::WebGLShortArray::slice):
2384         (WebCore::WebGLShortArray::set):
2385         * html/canvas/WebGLShortArray.h:
2386         (WebCore::WebGLShortArray::isShortArray):
2387         (WebCore::WebGLShortArray::data):
2388         (WebCore::WebGLShortArray::set):
2389         (WebCore::WebGLShortArray::get):
2390         (WebCore::WebGLShortArray::item):
2391         * html/canvas/WebGLShortArray.idl:
2392         * html/canvas/WebGLUnsignedByteArray.cpp:
2393         (WebCore::WebGLUnsignedByteArray::create):
2394         (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
2395         (WebCore::WebGLUnsignedByteArray::length):
2396         (WebCore::WebGLUnsignedByteArray::byteLength):
2397         (WebCore::WebGLUnsignedByteArray::slice):
2398         (WebCore::WebGLUnsignedByteArray::set):
2399         * html/canvas/WebGLUnsignedByteArray.h:
2400         (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
2401         (WebCore::WebGLUnsignedByteArray::data):
2402         (WebCore::WebGLUnsignedByteArray::set):
2403         (WebCore::WebGLUnsignedByteArray::get):
2404         (WebCore::WebGLUnsignedByteArray::item):
2405         * html/canvas/WebGLUnsignedByteArray.idl:
2406         * html/canvas/WebGLUnsignedIntArray.cpp:
2407         (WebCore::WebGLUnsignedIntArray::create):
2408         (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
2409         (WebCore::WebGLUnsignedIntArray::length):
2410         (WebCore::WebGLUnsignedIntArray::byteLength):
2411         (WebCore::WebGLUnsignedIntArray::slice):
2412         (WebCore::WebGLUnsignedIntArray::set):
2413         * html/canvas/WebGLUnsignedIntArray.h:
2414         (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
2415         (WebCore::WebGLUnsignedIntArray::data):
2416         (WebCore::WebGLUnsignedIntArray::set):
2417         (WebCore::WebGLUnsignedIntArray::get):
2418         (WebCore::WebGLUnsignedIntArray::item):
2419         * html/canvas/WebGLUnsignedIntArray.idl:
2420         * html/canvas/WebGLUnsignedShortArray.cpp:
2421         (WebCore::WebGLUnsignedShortArray::create):
2422         (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
2423         (WebCore::WebGLUnsignedShortArray::length):
2424         (WebCore::WebGLUnsignedShortArray::byteLength):
2425         (WebCore::WebGLUnsignedShortArray::slice):
2426         (WebCore::WebGLUnsignedShortArray::set):
2427         * html/canvas/WebGLUnsignedShortArray.h:
2428         (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
2429         (WebCore::WebGLUnsignedShortArray::data):
2430         (WebCore::WebGLUnsignedShortArray::set):
2431         (WebCore::WebGLUnsignedShortArray::get):
2432         (WebCore::WebGLUnsignedShortArray::item):
2433         * html/canvas/WebGLUnsignedShortArray.idl:
2434         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2435         (WebCore::GraphicsContext3D::bufferData):
2436         (WebCore::GraphicsContext3D::bufferSubData):
2437
2438 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2439
2440         Windows build fix.
2441
2442         * platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".
2443
2444 2009-11-15  Brent Fulgham  <bfulgham@webkit.org>
2445
2446         Reviewed by Oliver Hunt.
2447
2448         Enable support for webkit-box-shadow in Cairo builds.
2449         https://bugs.webkit.org/show_bug.cgi?id=26102.
2450
2451         Covered by existing fast/box-shadow tests.
2452
2453         * platform/graphics/cairo/GraphicsContextCairo.cpp:  Add
2454           support for fillRect shadows.
2455
2456 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2457
2458         Windows build fix.
2459
2460         * platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not
2461         in WebKitSupportLibrary.
2462
2463 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2464
2465         Reviewed by Darin Adler.
2466
2467         https://bugs.webkit.org/show_bug.cgi?id=31494
2468         Add unauthenticated proxy support to SocketStreamHandleCFNet
2469
2470         Cannot be tested in DRT.
2471
2472         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2473         (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS.
2474         (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.
2475
2476 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2477
2478         Reviewed by Antti Koivisto.
2479
2480         [Qt] Broken back/forward after using ErrorPageExtension to set error page
2481         https://bugs.webkit.org/show_bug.cgi?id=30573
2482
2483         Make FrameLoader::checkLoadCompleteForThisFrame method
2484         to check for any working DocumentLoader instance (through
2485         activeDocumentLoader()) instead of only checking for
2486         'm_provisionalDocumentLoader' in order to decide to if
2487         it is going to reset of not the back and forward history.
2488         after an error page has been loaded.
2489
2490         Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html
2491
2492         * loader/FrameLoader.cpp:
2493         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2494
2495 2009-11-14  Chris Fleizach  <cfleizach@apple.com>
2496
2497         Reviewed by Darin Adler.
2498
2499         Need to implement ARIA role="directory"
2500         https://bugs.webkit.org/show_bug.cgi?id=31516
2501
2502         Test: platform/mac/accessibility/aria-directory.html
2503
2504         * accessibility/AXObjectCache.cpp:
2505         (WebCore::AXObjectCache::getOrCreate):
2506         * accessibility/AccessibilityList.cpp:
2507         (WebCore::AccessibilityList::isOrderedList):
2508         * accessibility/AccessibilityRenderObject.cpp:
2509         (WebCore::createARIARoleMap):
2510
2511 2009-11-15  Dave Tapuska  <dtapuska@rim.com>
2512
2513         Reviewed by George Staikos.
2514         
2515         Compare UChars single unit at a time as opposed to the uint32_t
2516         approach as casting to unaligned addresses may cause a bus failure
2517         on ARMv5 and below. This change replicates the same defines that
2518         exists in AtomicString.cpp
2519
2520         https://bugs.webkit.org/show_bug.cgi?id=31475
2521         
2522         * platform/text/StringHash.h:
2523         (WebCore::StringHash::equal):
2524
2525 2009-11-15  Evan Martin  <evan@chromium.org>
2526
2527         Reviewed by Adam Barth.
2528
2529         Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.
2530
2531         https://bugs.webkit.org/show_bug.cgi?id=31490
2532
2533         * bindings/v8/V8DOMWrapper.cpp:
2534
2535 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
2536
2537         Reviewed by Adam Barth.
2538
2539         [Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.
2540
2541         * platform/haiku/FileChooserHaiku.cpp:
2542
2543 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
2544
2545         Reviewed by Adam Barth.
2546
2547         [Haiku] Build fix. ColorSpace name had a wrong CamelCase.
2548
2549         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
2550         (WebCore::GraphicsContext::setPlatformStrokeColor):
2551
2552 2009-11-15  Daniel Bates  <dbates@webkit.org>
2553
2554         No review, rolling out r50999.
2555         http://trac.webkit.org/changeset/50999
2556
2557         Need to fix some issues in the Windows build. Missed some places where
2558         RenderTextControl::isEdited is called.
2559
2560         * bindings/objc/DOMHTML.mm:
2561         (-[DOMHTMLInputElement _isEdited]):
2562         (-[DOMHTMLTextAreaElement _isEdited]):
2563         * dom/Document.cpp:
2564         (WebCore::Document::setFocusedNode):
2565         * html/HTMLInputElement.cpp:
2566         (WebCore::HTMLInputElement::defaultEventHandler):
2567         * rendering/RenderTextControl.cpp:
2568         (WebCore::RenderTextControl::RenderTextControl):
2569         (WebCore::RenderTextControl::setInnerTextValue):
2570         (WebCore::RenderTextControl::setUserEdited):
2571         (WebCore::RenderTextControl::subtreeHasChanged):
2572         * rendering/RenderTextControl.h:
2573         (WebCore::RenderTextControl::isEdited):
2574         (WebCore::RenderTextControl::setEdited):
2575         (WebCore::RenderTextControl::isUserEdited):
2576         * rendering/RenderTextControlSingleLine.cpp:
2577         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2578         * wml/WMLInputElement.cpp:
2579         (WebCore::WMLInputElement::defaultEventHandler):
2580
2581 2009-11-15  Daniel Bates  <dbates@webkit.org>
2582
2583         Reviewed by Darin Adler.
2584
2585         https://bugs.webkit.org/show_bug.cgi?id=31186
2586
2587         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
2588         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
2589         These are more descriptive names so as to clear an ambiguity surrounding
2590         their usage. Also, renames associated setters and getters so that they
2591         coincide with the renamed fields.
2592
2593         No functionality was changed. So, no tests were included.
2594
2595         * bindings/objc/DOMHTML.mm:
2596         (-[DOMHTMLInputElement _isEdited]):
2597         (-[DOMHTMLTextAreaElement _isEdited]):
2598         * dom/Document.cpp:
2599         (WebCore::Document::setFocusedNode):
2600         * html/HTMLInputElement.cpp:
2601         (WebCore::HTMLInputElement::defaultEventHandler):
2602         * rendering/RenderTextControl.cpp:
2603         (WebCore::RenderTextControl::RenderTextControl):
2604         (WebCore::RenderTextControl::setInnerTextValue):
2605         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
2606         (WebCore::RenderTextControl::subtreeHasChanged):
2607         * rendering/RenderTextControl.h:
2608         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
2609         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
2610         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
2611         * rendering/RenderTextControlSingleLine.cpp:
2612         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2613         * wml/WMLInputElement.cpp:
2614         (WebCore::WMLInputElement::defaultEventHandler):
2615
2616 2009-11-14  Adele Peterson  <adele@apple.com>
2617
2618         Reviewed by Dan Bernstein.
2619
2620         Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
2621
2622         Test: fast/overflow/line-clamp.html
2623
2624         * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
2625         * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
2626         * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
2627
2628         * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
2629         Use the line count value if available.  Otherwise, convert the percentage to the line count, as we did before.  Also,
2630         if there is anchor as the last child box, still allow adding the ellipsis.
2631
2632         * rendering/RenderLayer.cpp:
2633         (WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
2634         (WebCore::RenderLayer::scrollRectToVisible): ditto.
2635
2636         * WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
2637         * rendering/style/LineClampValue.h: Added.
2638         (WebCore::LineClampValue::LineClampValue):
2639         (WebCore::LineClampValue::value):
2640         (WebCore::LineClampValue::isPercentage):
2641         (WebCore::LineClampValue::isNone):
2642         (WebCore::LineClampValue::operator==):
2643         (WebCore::LineClampValue::operator!=):
2644         * rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
2645
2646         * rendering/style/RenderStyle.h: Use LineClampValue.
2647         (WebCore::InheritedFlags::lineClamp):
2648         (WebCore::InheritedFlags::setLineClamp):
2649         (WebCore::InheritedFlags::initialLineClamp):
2650         * rendering/style/StyleRareNonInheritedData.h:
2651
2652 2009-11-14  Eric Carlson  <eric.carlson@apple.com>
2653
2654         Reviewed by Oliver Hunt.
2655
2656         <rdar://problem/7287487> 
2657         Do not use QuickTime version to detect media controller theme
2658
2659         * WebCore.base.exp: Export wkMediaControllerThemeAvailable
2660         * platform/mac/WebCoreSystemInterface.h: Ditto.
2661         * platform/mac/WebCoreSystemInterface.mm: Ditto.
2662
2663         * rendering/RenderThemeMac.mm:
2664         (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the
2665         QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.
2666
2667 2009-11-14  Kent Tamura  <tkent@chromium.org>
2668
2669         Reviewed by Darin Adler.
2670
2671         - Recognizes date/datetime/datetime-local/month/time/week types of INPUT element.
2672           They have no dedicated UI and no type validation for now.
2673         - Clean up setInputType() and formControlType() of HTMLInputElement.
2674         https://bugs.webkit.org/show_bug.cgi?id=29004
2675
2676         Test: fast/forms/input-type-change3.html
2677
2678         * html/HTMLInputElement.cpp:
2679         (WebCore::HTMLInputElement::valueMissing):
2680         (WebCore::HTMLInputElement::patternMismatch):
2681         (WebCore::HTMLInputElement::tooLong):
2682         (WebCore::createTypeMap):
2683         (WebCore::HTMLInputElement::setInputType):
2684         (WebCore::createFormControlTypes):
2685         (WebCore::HTMLInputElement::formControlType):
2686         (WebCore::HTMLInputElement::saveFormControlState):
2687         (WebCore::HTMLInputElement::restoreFormControlState):
2688         (WebCore::HTMLInputElement::accessKeyAction):
2689         (WebCore::HTMLInputElement::rendererIsNeeded):
2690         (WebCore::HTMLInputElement::createRenderer):
2691         (WebCore::HTMLInputElement::appendFormData):
2692         (WebCore::HTMLInputElement::isTextField):
2693         (WebCore::HTMLInputElement::valueWithDefault):
2694         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
2695         (WebCore::HTMLInputElement::defaultEventHandler):
2696         (WebCore::HTMLInputElement::isRequiredFormControl):
2697         (WebCore::HTMLInputElement::dataList):
2698         * html/HTMLInputElement.h:
2699         (WebCore::HTMLInputElement::):
2700
2701 2009-11-13  Chris Fleizach  <cfleizach@apple.com>
2702
2703         Reviewed by Darin Adler.
2704
2705         WAI-ARIA: checkbox does not determine its label from text content
2706         https://bugs.webkit.org/show_bug.cgi?id=31456
2707
2708         Test: accessibility/aria-checkbox-text.html
2709
2710         * accessibility/AccessibilityRenderObject.cpp:
2711         (WebCore::AccessibilityRenderObject::title):
2712
2713 2009-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2714
2715         Unreviewed, build fix.
2716
2717         [Chromium] Fix build to catch up with http://trac.webkit.org/changeset/50973.
2718         This is just enough changes to unbreak the port.
2719
2720         * bindings/v8/ScriptController.cpp:
2721         (WebCore::mainThreadNormalWorld):
2722         * bindings/v8/V8Proxy.cpp:
2723         (WebCore::V8Proxy::initContextIfNeeded):
2724         * loader/FrameLoaderClient.h:
2725
2726 2009-11-13  Aaron Boodman  <aa@chromium.org>
2727
2728         Unreviewed fix for Chromium build.
2729
2730         * loader/FrameLoaderClient.h:
2731         (WebCore::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
2732         Provide an empty implementation of this method because I don't know
2733         what it is supposed to do on Chromium.
2734
2735 2009-11-13  Aaron Boodman  <aa@chromium.org>
2736
2737         Unreviewed fix for Chromium build.
2738
2739         * loader/FrameLoader.h: Make dispatchDidClearWindowObjectsInAllWorlds()
2740         public, as Chromium's V8Proxy calls it.
2741
2742 2009-11-13  Aaron Boodman  <aa@chromium.org>
2743
2744         Unreviewed fix to Chromium build.
2745
2746         * bindings/v8/ScriptController.cpp:
2747         (WebCore::ScriptController::getAllWorlds): 
2748
2749 2009-11-13  Aaron Boodman  <aa@chromium.org>
2750
2751         Unreviewed fix for Chromium build.
2752
2753         * platform/text/TextBoundaries.cpp: Use longer path to refer to Unicode.h.
2754
2755 2009-11-13  Adam Barth  <abarth@webkit.org>
2756
2757         Unreviewed partial build fix for Chromium.  Should fix failure #4.
2758
2759         * bindings/v8/ScriptController.cpp:
2760         (WebCore::ScriptController::getAllWorlds):
2761         * bindings/v8/ScriptController.h:
2762         * bindings/v8/V8Proxy.cpp:
2763         (WebCore::V8Proxy::initContextIfNeeded):
2764
2765 2009-11-13  Adam Barth  <abarth@webkit.org>
2766
2767         Unreviewed partial build fix for Chromium.
2768
2769         * bindings/v8/ScriptController.h:
2770         (WebCore::ScriptController::getAllWorlds):
2771
2772 2009-11-13  Eric Seidel  <eric@webkit.org>
2773
2774         No review, build fix only.
2775
2776         Fix Windows and Chromium builds after http://trac.webkit.org/changeset/50977.
2777
2778         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
2779         https://bugs.webkit.org/show_bug.cgi?id=31468
2780
2781         * WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
2782         * WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries
2783
2784 2009-11-12  Jeremy Orlow  <jorlow@chromium.org>
2785
2786         Reviewed by Dmitry Titov.
2787
2788         LocalStorage quota should include key sizes in its count
2789         https://bugs.webkit.org/show_bug.cgi?id=31451
2790
2791         * storage/StorageMap.cpp:
2792         (WebCore::StorageMap::setItem):
2793             Count keys in the quota when adding a new item.
2794         (WebCore::StorageMap::removeItem):
2795             Remove the key's length from the quota if we're removing the item.
2796         (WebCore::StorageMap::importItem):
2797             Assume that we're adding things for the first time.
2798             Count keys in the quota.
2799
2800 2009-11-13  Dominik Röttsches  <dominik.roettsches@access-company.com>
2801
2802         Reviewed by Eric Seidel.
2803
2804         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
2805         https://bugs.webkit.org/show_bug.cgi?id=31468
2806
2807         Moving TextBoundariesICU.cpp to TextBoundaries.cpp
2808         by removing the direct ICU dependency and replacing it
2809         with WTF functions and WebCore's own TextBreakIterator
2810         abstractions.
2811
2812         * GNUmakefile.am:
2813         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
2814         * platform/text/TextBoundaries.cpp: Added.
2815         (WebCore::findNextWordFromIndex):
2816         (WebCore::findWordBoundary):
2817         * platform/text/TextBoundariesICU.cpp: Removed.
2818         * platform/text/TextBreakIterator.h:
2819         * platform/text/TextBreakIteratorICU.cpp:
2820         (WebCore::textBreakLast):
2821         (WebCore::textBreakPrevious):
2822
2823 2009-11-13  Shinichiro Hamaji  <hamaji@chromium.org>
2824
2825         Reviewed by Darin Adler.
2826
2827         WebCore::externalRepresentation should update layout before getting render object
2828         https://bugs.webkit.org/show_bug.cgi?id=31459
2829
2830         * rendering/RenderTreeAsText.cpp:
2831         (WebCore::externalRepresentation):
2832
2833 2009-11-13  Adam Roben  <aroben@apple.com>
2834
2835         Tell FrameLoaderClient when window objects in isolated worlds are
2836         cleared
2837
2838         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2839         window objects in isolated worlds are cleared
2840
2841         Test: http/tests/security/isolatedWorld/didClearWindowObject.html
2842
2843         Reviewed by Dave Hyatt.
2844
2845         * bindings/js/JSDOMBinding.h:
2846         (WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
2847         worlds in m_worldSet to the passed-in Vector.
2848
2849         * bindings/js/ScriptController.cpp:
2850         (WebCore::ScriptController::getAllWorlds): Added. Calls through to
2851         WebCoreJSClientData.
2852         (WebCore::ScriptController::initScript): Changed to call
2853         FrameLoader::dispatchDidClearWindowObjectInWorld.
2854
2855         * bindings/js/ScriptController.h: Added getAllWorlds.
2856
2857         * loader/EmptyClients.h:
2858         (WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
2859         Updated for FrameLoaderClient change.
2860
2861         * loader/FrameLoader.cpp:
2862         (WebCore::FrameLoader::receivedFirstData):
2863         (WebCore::FrameLoader::begin):
2864         Changed to call dispatchDidClearWindowObjectsInAllWorlds.
2865
2866         (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
2867         Added. Retrieves all the worlds, then calls through to
2868         dispatchDidClearWindowObjectInWorld for each one.
2869         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
2870         dispatchWindowObjectAvailable. Calls up to the client, then, if the
2871         world is the mainThreadNormalWorld(), tells the Inspector about it,
2872         too.
2873
2874         * loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with
2875         dispatchDidClearWindowObjectInWorld. Added
2876         dispatchDidClearWindowObjectsInAllWorlds.
2877
2878         * loader/FrameLoaderClient.h: Replaced windowObjectCleared with
2879         dispatchDidClearWindowObjectForWorld.
2880
2881 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
2882
2883         Reviewed by Dimitri Glazkov.
2884
2885         [V8] Fix SVG context assignment for pod types.
2886         https://bugs.webkit.org/show_bug.cgi?id=31497
2887
2888         I broke this in r50958.
2889
2890         Tested by svg/custom/viewport-update2.svg.
2891
2892         * bindings/scripts/CodeGeneratorV8.pm:
2893
2894 2009-11-13  Andrei Popescu  <andreip@google.com>
2895
2896         Reviewed by Dmitry Titov.
2897
2898         Bring the platform/android files inline with Android 2.0
2899         https://bugs.webkit.org/show_bug.cgi?id=31423
2900
2901         No new tests required: these are all Android-specific files.
2902
2903         * platform/android/ClipboardAndroid.cpp:
2904         (WebCore::ClipboardAndroid::files):
2905         * platform/android/ClipboardAndroid.h:
2906         * platform/android/FileChooserAndroid.cpp:
2907         (WebCore::FileChooser::basenameForWidth):
2908         (WebCore::fileButtonChooseFileLabel):
2909         * platform/android/KeyEventAndroid.cpp:
2910         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2911         * platform/android/LocalizedStringsAndroid.cpp:
2912         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
2913         (WebCore::contextMenuItemTagDownloadLinkToDisk):
2914         (WebCore::contextMenuItemTagCopyLinkToClipboard):
2915         (WebCore::contextMenuItemTagOpenImageInNewWindow):
2916         (WebCore::contextMenuItemTagDownloadImageToDisk):
2917         (WebCore::contextMenuItemTagCopyImageToClipboard):
2918         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
2919         (WebCore::contextMenuItemTagCopy):
2920         (WebCore::contextMenuItemTagGoBack):
2921         (WebCore::contextMenuItemTagGoForward):
2922         (WebCore::contextMenuItemTagStop):
2923         (WebCore::contextMenuItemTagReload):
2924         (WebCore::contextMenuItemTagCut):
2925         (WebCore::contextMenuItemTagPaste):
2926         (WebCore::contextMenuItemTagNoGuessesFound):
2927         (WebCore::contextMenuItemTagIgnoreSpelling):
2928         (WebCore::contextMenuItemTagLearnSpelling):
2929         (WebCore::contextMenuItemTagSearchWeb):
2930         (WebCore::contextMenuItemTagLookUpInDictionary):
2931         (WebCore::contextMenuItemTagOpenLink):
2932         (WebCore::contextMenuItemTagIgnoreGrammar):
2933         (WebCore::contextMenuItemTagSpellingMenu):
2934         (WebCore::contextMenuItemTagShowSpellingPanel):
2935         (WebCore::contextMenuItemTagCheckSpelling):
2936         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
2937         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2938         (WebCore::contextMenuItemTagFontMenu):
2939         (WebCore::contextMenuItemTagBold):
2940         (WebCore::contextMenuItemTagItalic):
2941         (WebCore::contextMenuItemTagUnderline):
2942         (WebCore::contextMenuItemTagOutline):
2943         (WebCore::contextMenuItemTagWritingDirectionMenu):
2944         (WebCore::contextMenuItemTagTextDirectionMenu):
2945         (WebCore::contextMenuItemTagDefaultDirection):
2946         (WebCore::contextMenuItemTagLeftToRight):
2947         (WebCore::contextMenuItemTagRightToLeft):
2948         (WebCore::mediaElementLoadingStateText):
2949         (WebCore::mediaElementLiveBroadcastStateText):
2950         (WebCore::searchableIndexIntroduction):
2951         (WebCore::resetButtonDefaultLabel):
2952         (WebCore::submitButtonDefaultLabel):
2953         (WebCore::inputElementAltText):
2954         * platform/android/RenderThemeAndroid.cpp:
2955         (WebCore::RenderTheme::themeForPage):
2956         (WebCore::RenderThemeAndroid::baselinePosition):
2957         (WebCore::RenderThemeAndroid::paintButton):
2958         (WebCore::adjustMenuListStyleCommon):
2959         (WebCore::RenderThemeAndroid::paintCombo):
2960         * platform/android/ScreenAndroid.cpp:
2961         * platform/android/ScrollViewAndroid.cpp:
2962         (WebCore::ScrollView::platformOffscreenContentRectangle):
2963         * platform/android/TemporaryLinkStubs.cpp:
2964         (JSC::Bindings::dispatchJNICall):
2965         * platform/android/WidgetAndroid.cpp:
2966         (WebCore::Widget::setFrameRect):
2967
2968 2009-11-13  Norbert Leser  <norbert.leser&nokia.com>
2969
2970         Reviewed by Eric Seidel.
2971
2972         Added macros for USERINCLUDE paths within symbian blocks
2973         to guarantee inclusion of respective header files from local path
2974         first (to avoid clashes with same names of header files in system include path).
2975
2976         * WebCore.pro:
2977
2978 2009-11-13  Hironori Bono  <hbono@chromium.org>
2979
2980         Reviewed by Oliver Hunt.
2981
2982         Implement composition events introduced in DOM Level 3.
2983         This change adds a new IDL which defines the composition events, adds a class which
2984         implements the composition events, and sends the composition events according to
2985         the specification.
2986         https://bugs.webkit.org/show_bug.cgi?id=26310
2987
2988         Test: fast/events/ime-composition-events-001.html
2989
2990         * DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
2991         * GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
2992         * WebCore.gypi: ditto.
2993         * WebCore.pro: ditto
2994         * WebCore.vcproj/WebCore.vcproj: ditto.
2995         * WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
2996         * WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
2997         * bindings/js/JSEventCustom.cpp:
2998         (WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
2999         * bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
3000         * bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
3001         * bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
3002         (WebCore::V8DOMWrapper::convertEventToV8Object):
3003         * bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
3004         * bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
3005         * dom/CompositionEvent.cpp: Implements the CompositionEvent class.
3006         (WebCore::CompositionEvent::CompositionEvent):
3007         (WebCore::CompositionEvent::~CompositionEvent):
3008         (WebCore::CompositionEvent::initCompositionEvent):
3009         (WebCore::CompositionEvent::isCompositionEvent):
3010         * dom/CompositionEvent.h: Declares the CompositionEvent class.
3011         (WebCore::CompositionEvent::create):
3012         (WebCore::CompositionEvent::data):
3013         * dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
3014         * dom/Event.cpp:
3015         (WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
3016         * dom/Event.h:
3017         * dom/EventNames.h: Added composition{start,update,end} to eventNames.
3018         * editing/Editor.cpp:
3019         (WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
3020         (WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
3021
3022 2009-11-13  Jens Alfke  <snej@chromium.org>
3023
3024         Reviewed by Dimitri Glazkov.
3025
3026         Fix a link error in unofficial GCC 4.4 builds on Linux.
3027         https://bugs.webkit.org/show_bug.cgi?id=31477
3028
3029         * bindings/v8/V8Binding.cpp:  Add explicit instantiations of v8StringToWebCoreString template.
3030
3031 2009-11-13  Eric Seidel  <eric@webkit.org>
3032
3033         No review, build fix only.
3034
3035         Fix Debug build after http://trac.webkit.org/changeset/50960.
3036
3037         The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
3038         https://bugs.webkit.org/show_bug.cgi?id=31213
3039
3040         * rendering/CounterNode.cpp:
3041         (WebCore::showTreeAndMark):
3042         * rendering/RenderCounter.cpp:
3043         (WebCore::destroyCounterNodeChildren):
3044
3045 2009-11-13  Dirk Schulze  <krit@webkit.org>
3046
3047         Reviewed by Gustavo Noronha.
3048
3049         [CAIRO] shadow support for Canvas and SVG
3050         [https://bugs.webkit.org/show_bug.cgi?id=30960]
3051
3052         We currently fill a path with solid color instead of filling
3053         a clipping path. This causes problems on some composite operators,
3054         since Cairo modifies the area outside the path.
3055         This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
3056
3057         Thanks to Benjamin Otte for tracking the bug down.
3058
3059         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3060         (WebCore::setPlatformFill):
3061
3062 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
3063
3064         Reviewed by Dimitri Glazkov.
3065
3066         Adding Chromium's DatabaseTracker implementation.
3067
3068         https://bugs.webkit.org/show_bug.cgi?id=31440
3069
3070         * WebCore.gyp/WebCore.gyp:
3071         * WebCore.gypi:
3072         * storage/DatabaseTracker.h:
3073         * storage/chromium/DatabaseTrackerChromium.cpp:
3074         (WebCore::DatabaseTracker::fullPathForDatabase):
3075         (WebCore::DatabaseTracker::getMaxSizeForDatabase):
3076         * storage/chromium/QuotaTracker.cpp:
3077         (WebCore::QuotaTracker::updateDatabaseSize):
3078         * storage/chromium/QuotaTracker.h:
3079
3080 2009-11-13  Carol Szabo  <carol.szabo@nokia.com>
3081
3082         Reviewed by Darin Adler.
3083
3084         The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
3085         https://bugs.webkit.org/show_bug.cgi?id=31213
3086         Added tree navigation methods that permit full implementation of CSS2.1
3087         counter feature without using recursion proportional to the counter
3088         tree depth.
3089         No new tests because I did not find any bug that is fixed by this
3090         commit yet, this just reduces the size of the patch for 11031 and
3091         helps respond to some concerns regarding that patch.
3092
3093         * rendering/CounterNode.cpp:
3094         (WebCore::CounterNode::CounterNode):
3095
3096         (WebCore::CounterNode::nextInPreOrderAfterChildren):
3097         (WebCore::CounterNode::nextInPreOrder):
3098         Added to support non-recursive tree traversal necessary for
3099         efficient full implementation of CSS2.1 counters.
3100
3101         (WebCore::CounterNode::lastDescendant):
3102         (WebCore::CounterNode::previousInPreOrder):
3103         Moved this methods such that they occupy a place similar to that of
3104         identically named methods on the render tree. This allows for their
3105         broader use needed in full implementation of CSS2.1 counters.
3106
3107         (WebCore::CounterNode::resetRenderer):
3108         (WebCore::CounterNode::resetRenderers):
3109         (WebCore::CounterNode::recount):
3110         (WebCore::CounterNode::insertAfter):
3111         (WebCore::CounterNode::removeChild):
3112         Changed such that insertion/removal of a counter, triggers not only
3113         recalculation of PrefixWidths, but also reassesment of values in
3114         counter nodes. This is the basis full implementation of CSS2.1
3115         counters. It does not change current behavior by much because of
3116         changes needed to the recalculation algorithm, but those are comming
3117         in the patch for 11031.
3118         (WebCore::showTreeAndMark):
3119         * rendering/CounterNode.h:
3120         * rendering/RenderCounter.cpp:
3121         (WebCore::counter):
3122         Only changed argument type to prepare for implementation of Darin
3123         Adler's recommendation for the patch to 11031.
3124
3125         (WebCore::RenderCounter::invalidate):
3126         (WebCore::destroyCounterNodeChildren):
3127         (WebCore::RenderCounter::destroyCounterNodes):
3128         * rendering/RenderCounter.h:
3129         * rendering/RenderObjectChildList.cpp:
3130         (WebCore::invalidateCountersInContainer):
3131         (WebCore::RenderObjectChildList::invalidateCounters):
3132         * rendering/RenderObjectChildList.h:
3133         Added the ability to restrict invalidation to counters with a given
3134         identifier.
3135         Also invalidated counters that are on the child container itself
3136         which were missed by the previous algorithm, but were a valid case.
3137
3138 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
3139
3140         Reviewed by Dimitri Glazkov.
3141
3142         [V8] Protect SVG animated properties from destruction in bindings.
3143         https://bugs.webkit.org/show_bug.cgi?id=31474
3144
3145         See http://crbug.com/26719.
3146
3147         Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
3148         under Valgrind.
3149
3150         Made sure we keep a reference to SVG properties while setting a
3151         context:
3152         * bindings/scripts/CodeGeneratorV8.pm:
3153         * bindings/v8/V8Proxy.h:
3154         (WebCore::V8Proxy::withSVGContext):
3155
3156 2009-11-13  Brent Fulgham  <bfulgham@webkit.org>
3157
3158         Reviewed by Alexey Proskuryakov.
3159
3160         [CAIRO] shadow support for Canvas and SVG.
3161         [https://bugs.webkit.org/show_bug.cgi?id=30960]
3162
3163         Incorporate Benjamin Otte's recommendations to avoid
3164         a buffer overrun, and small performance improvement.
3165
3166         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3167         (WebCore::copyContextProperties): Correctly size output
3168          storage for cairo_get_dash to avoid buffer overrun.
3169         (WebCore::drawPathShadow): Prefer cairo_fill_extents
3170          to slower cairo_stroke_extents when not drawing shadows.
3171
3172 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
3173
3174         Reviewed by Dimitri Glazkov.
3175
3176         Do not register Chromium's HTML5 DB VFS as the default
3177         VFS. Otherwise, other sqlite DB users in the same process will
3178         stop working.
3179
3180         https://bugs.webkit.org/show_bug.cgi?id=31462
3181
3182         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
3183         (WebCore::SQLiteFileSystem::openDatabase):
3184         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3185         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
3186         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
3187         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
3188
3189 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
3190
3191         Windows build fix
3192
3193         * platform/network/cf/SocketStreamHandleCFNet.cpp:
3194         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
3195         avoiding a sign mismatch warning.
3196
3197 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
3198
3199         Release build fix.
3200
3201         * platform/network/cf/SocketStreamHandleCFNet.cpp:
3202         (WebCore::SocketStreamHandle::readStreamCallback):
3203         (WebCore::SocketStreamHandle::writeStreamCallback):
3204         Use ASSERT_UNUSED for unused stream parameter.
3205
3206 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
3207
3208         Reviewed by Darin Adler.
3209
3210         https://bugs.webkit.org/show_bug.cgi?id=31441
3211         Implement SocketStreamHandleCFNet
3212
3213         Existing WebSocket tests now pass on Mac. No proxy support yet.
3214
3215         * platform/network/SocketStreamHandleClient.h:
3216         * platform/network/cf/SocketStreamHandle.h:
3217         (WebCore::SocketStreamHandle::shouldUseSSL):
3218         (WebCore::SocketStreamHandle::refAuthenticationClient):
3219         (WebCore::SocketStreamHandle::derefAuthenticationClient):
3220         (WebCore::SocketStreamHandle::):
3221         * platform/network/cf/SocketStreamHandleCFNet.cpp:
3222         (WebCore::SocketStreamHandle::SocketStreamHandle):
3223         (WebCore::SocketStreamHandle::chooseProxy):
3224         (WebCore::SocketStreamHandle::createStreams):
3225         (WebCore::SocketStreamHandle::copyCFStreamDescription):
3226         (WebCore::SocketStreamHandle::readStreamCallback):
3227         (WebCore::SocketStreamHandle::writeStreamCallback):
3228         (WebCore::SocketStreamHandle::~SocketStreamHandle):
3229         (WebCore::SocketStreamHandle::platformSend):
3230         (WebCore::SocketStreamHandle::platformClose):
3231         (WebCore::SocketStreamHandle::receivedCredential):
3232         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
3233         (WebCore::SocketStreamHandle::receivedCancellation):
3234
3235 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3236
3237         Reviewed by Timothy Hatcher.
3238
3239         Web Inspector: preload status bar button glyphs
3240         in order to prevent them from flickering (take 2).
3241
3242         https://bugs.webkit.org/show_bug.cgi?id=31439
3243
3244         * inspector/front-end/inspector.js:
3245         (preloadImages):
3246
3247 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
3248
3249         Reviewed by Adam Barth.
3250
3251         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
3252         Rolling back r50890.
3253
3254         https://bugs.webkit.org/show_bug.cgi?id=31467
3255
3256         * bindings/v8/V8Proxy.cpp:
3257         (WebCore::V8Proxy::canAccessPrivate):
3258
3259 2009-11-13  Dirk Schulze  <krit@webkit.org>
3260
3261         Reviewed by Gustavo Noronha.
3262
3263         [CAIRO] shadow support for Canvas and SVG
3264         [https://bugs.webkit.org/show_bug.cgi?id=30960]
3265         
3266         This is the fix of a regression, caused by the shadow patch
3267         from the bug above. Reinserted the save and restore calls
3268         that were accidently removed by the previous patch.
3269
3270         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3271         (WebCore::setPlatformFill):
3272         (WebCore::setPlatformStroke):
3273
3274 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
3275
3276         Not reviewed. Reverting r50908 since it makes inspector tests
3277         time out.
3278
3279         https://bugs.webkit.org/show_bug.cgi?id=31439
3280
3281         * inspector/front-end/inspector.js:
3282
3283 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
3284
3285         Reviewed by Timothy Hatcher.
3286
3287         Enable 'console.profile()' and 'console.profileEnd()'
3288         regardless of JAVASCRIPT_DEBUGGER.
3289
3290         https://bugs.webkit.org/show_bug.cgi?id=31293
3291
3292         * WebCore.gypi:
3293         * bindings/js/JSConsoleCustom.cpp:
3294         (WebCore::JSConsole::profile):
3295         (WebCore::JSConsole::profileEnd):
3296         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
3297         (WebCore::CALLBACK_FUNC_DECL):
3298         * bindings/v8/custom/V8CustomBinding.h:
3299         * page/Console.idl:
3300
3301 2009-11-12  David Levin  <levin@chromium.org>
3302
3303         Reviewed by NOBODY.
3304
3305         Chromium build fix.
3306
3307         * bindings/v8/ScriptController.h:
3308         (WebCore::ScriptController::evaluateInWorld): Add a dummy
3309          method which isn't called in chromium to make things compile.
3310
3311 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
3312
3313         Reviewed by Adam Barth.
3314         
3315         The document-open.html test was flaky at times. The test invokes the layout test plugin
3316         which in its destroy stream handler opens a new document. This basically tears down the
3317         stream and the associated plugin instance, which causes a crash when the plugin stream
3318         dereferences an invalid m_client pointer which points to the PluginView instance which
3319         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
3320         and check for the same.
3321        
3322         https://bugs.webkit.org/show_bug.cgi?id=31067
3323
3324         * plugins/PluginStream.cpp:
3325         (WebCore::PluginStream::stop):
3326         (WebCore::PluginStream::destroyStream):
3327
3328 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
3329
3330         Reviewed by Dimitri Glazkov.
3331
3332         Renaming some parameters passed to DB-related methods to better
3333         indicate their purpose.
3334
3335         https://bugs.webkit.org/show_bug.cgi?id=31449
3336
3337         * platform/chromium/ChromiumBridge.h:
3338
3339 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
3340
3341         Reviewed by Dan Bernstein.
3342
3343         Transformed reflected elements are clipped inside element with opacity
3344         https://bugs.webkit.org/show_bug.cgi?id=30957
3345         
3346         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
3347         each clip rect into painting space before taking the unions. This, however, did not work
3348         correctly with combinations of reflections and transforms. Fixed by unioning the
3349         clipRect and mapping through transforms along the way.
3350         
3351         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
3352         where the transparency layers are.
3353
3354         Test: fast/reflections/opacity-reflection-transform.html
3355
3356         * rendering/RenderLayer.cpp:
3357         (WebCore::expandClipRectForDescendantsAndReflection):
3358         (WebCore::transparencyClipBox):
3359         (WebCore::RenderLayer::beginTransparencyLayers):
3360
3361 2009-11-12  Adam Barth  <abarth@webkit.org>
3362
3363         Reviewed by Darin Fisher.
3364
3365         Improve SecurityOrigin::toString comment
3366         https://bugs.webkit.org/show_bug.cgi?id=31041
3367
3368         * page/SecurityOrigin.h:
3369
3370 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
3371
3372         Reviewed by Darin Adler.
3373
3374         externalRepresentation should take Frame as the argument
3375         https://bugs.webkit.org/show_bug.cgi?id=31393
3376
3377         No new tests as this is just a refactoring.
3378
3379         * WebCore.base.exp:
3380         * rendering/RenderTreeAsText.cpp:
3381         (WebCore::externalRepresentation):
3382         * rendering/RenderTreeAsText.h:
3383
3384 2009-11-12  Ben Murdoch  <benm@google.com>
3385
3386         Reviewed by Dimitri Glazkov.
3387
3388         [Android] The Android specific files in page/Android are out of date.
3389         https://bugs.webkit.org/show_bug.cgi?id=31437
3390
3391         No tests required.
3392
3393         * page/android/DragControllerAndroid.cpp:
3394         (WebCore::DragController::dragOperation): Added.
3395         (WebCore::DragController::cleanupAfterSystemDrag):
3396         * page/android/EventHandlerAndroid.cpp:
3397         (WebCore::EventHandler::accessKeyModifiers): Added.
3398         * page/android/InspectorControllerAndroid.cpp: Removed.
3399
3400 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
3401
3402         Reviewed by Simon Fraser.
3403
3404         [CAIRO] shadow support for Canvas and SVG.
3405         [https://bugs.webkit.org/show_bug.cgi?id=30960]
3406
3407         Implement Canvas/SVG shadow support for Cairo.  This patch
3408         uses the filter code from SVG Filters.  That means that it is
3409         necessary to activate filters to see the shadows.
3410
3411         Test: fast/canvas/canvas-shadow.html
3412
3413         * GNUmakefile.am:
3414         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
3415         * platform/graphics/GraphicsContext.h:
3416         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3417         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
3418         (WebCore::setPlatformFill):
3419         (WebCore::setPlatformStroke):
3420         (WebCore::copyContextProperties):
3421         (WebCore::drawPathShadow):
3422         (WebCore::GraphicsContext::fillPath):
3423         (WebCore::GraphicsContext::strokePath):
3424         (WebCore::GraphicsContext::drawPath):
3425         (WebCore::GraphicsContext::setPlatformShadow):
3426         (WebCore::GraphicsContext::createPlatformShadow):
3427         * platform/graphics/cairo/ImageCairo.cpp:
3428         (WebCore::BitmapImage::draw): Add filter effect.
3429         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
3430         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
3431         * platform/graphics/filters/ImageBufferFilter.h: Added.
3432         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
3433         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
3434
3435 2009-11-12  Dmitry Titov  <dimich@chromium.org>
3436
3437         Reviewed by Alexey Proskuryakov.
3438
3439         Add postTaskToMainThread to ScriptExecutionContext.
3440         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
3441         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
3442         contexts that live on the main thread.
3443         https://bugs.webkit.org/show_bug.cgi?id=31427
3444
3445         No new tests - simply moving the code.
3446
3447         * dom/Document.cpp:
3448         (WebCore::Document::postTask):
3449         * dom/ScriptExecutionContext.cpp:
3450         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
3451         (WebCore::ScriptExecutionContextTaskTimer::fired):
3452         (WebCore::PerformTaskData::PerformTaskData):
3453         (WebCore::PerformTaskData::performTask):
3454         (WebCore::ScriptExecutionContext::postTaskToMainThread):
3455         * dom/ScriptExecutionContext.h:
3456
3457 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
3458
3459         Reviewed by Darin Adler.
3460
3461         Fix crash when removing compositing layers when GC is enabled
3462         https://bugs.webkit.org/show_bug.cgi?id=31429
3463
3464         Workaround <rdar://problem/7390716> by special-casing the removal
3465         of all sublayers when GC is enabled.
3466
3467         * platform/graphics/mac/GraphicsLayerCA.mm:
3468         (WebCore::safeSetSublayers):
3469         (WebCore::GraphicsLayerCA::updateSublayerList):
3470         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
3471
3472 2009-11-12  Jens Alfke  <snej@chromium.org>
3473
3474         Reviewed by Dimitri Glazkov.
3475
3476         The last of the V8 binding optimizations.
3477         - Replace string-valued element accessors with a shared getter/setter function.
3478         - Change error handling flow of control to avoid extra branches and function calls.
3479         https://bugs.webkit.org/show_bug.cgi?id=31443
3480         
3481         * bindings/scripts/CodeGeneratorV8.pm:
3482         * bindings/v8/V8Binding.cpp:
3483         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
3484         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
3485         * bindings/v8/V8Binding.h:
3486
3487 2009-11-12  Sam Weinig  <sam@webkit.org>
3488
3489         Reviewed by Oliver Hunt.
3490
3491         Fix for <rdar://problem/7267951>
3492         Canvas methods should reject uses of NaN and Infinity.
3493
3494         Test: fast/canvas/canvas-with-illegal-args.html
3495
3496         * html/canvas/CanvasRenderingContext2D.cpp:
3497         (WebCore::CanvasRenderingContext2D::scale):
3498         (WebCore::CanvasRenderingContext2D::rotate):
3499         (WebCore::CanvasRenderingContext2D::translate):
3500         (WebCore::CanvasRenderingContext2D::transform):
3501         (WebCore::CanvasRenderingContext2D::setTransform):
3502
3503 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3504
3505         Reviewed by Timothy Hatcher.
3506
3507         Web Inspector: profile timeline panel, fix obvious problems.
3508
3509         https://bugs.webkit.org/show_bug.cgi?id=31432
3510
3511         * inspector/front-end/AbstractTimelinePanel.js:
3512         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
3513         * inspector/front-end/TimelinePanel.js:
3514         (WebInspector.TimelinePanel.prototype._setWindowPosition):
3515         (WebInspector.TimelineCalculator):
3516         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
3517         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
3518         (WebInspector.TimelineCalculator.prototype.reset):
3519         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
3520         (WebInspector.TimelineCalculator.prototype.formatValue):
3521         (WebInspector.TimelineGraph):
3522         (WebInspector.TimelineGraph.prototype.refresh):
3523         * inspector/front-end/utilities.js:
3524         (Element.prototype.hasStyleClass):
3525
3526 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3527
3528         Reviewed by Timothy Hatcher.
3529
3530         Web Inspector: preload status bar button glyphs
3531         in order to prevent them from flickering.
3532
3533         https://bugs.webkit.org/show_bug.cgi?id=31439
3534
3535         * inspector/front-end/inspector.js:
3536         (preloadImages):
3537
3538 2009-11-12  Adam Roben  <aroben@apple.com>
3539
3540         Replace worldIDs with world objects
3541
3542         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
3543         user scripts/stylesheets and isolated worlds
3544
3545         Reviewed by Sam Weinig.
3546
3547         Covered by existing tests.
3548
3549         * WebCore.base.exp: Update exported symbols to match what now exists
3550         and is needed by WebKit.
3551
3552         * bindings/js/ScheduledAction.cpp:
3553         (WebCore::ScheduledAction::execute): Updated for function rename.
3554
3555         * bindings/js/ScriptController.cpp: Removed code that dealt with
3556         worldIDs.
3557         (WebCore::ScriptController::createWorld): Added. Returns a new world
3558         suitable for use on the main thread.
3559         (WebCore::ScriptController::executeScriptInWorld): Renamed from
3560         executeScriptInIsolatedWorld, since this works just fine with a
3561         "normal" world.
3562
3563         * bindings/js/ScriptController.h: Added createWorld, removed functions
3564         that took worldIDs, renamed executeScriptInIsolatedWorld to
3565         executeScriptInWorld.
3566
3567         * page/Frame.cpp:
3568         (WebCore::Frame::injectUserScripts):
3569         (WebCore::Frame::injectUserScriptsForWorld):
3570         Updated for changes to UserScriptMap and ScriptController.
3571
3572         * page/Frame.h: Changed injectUserScriptsForWorld to take a
3573         DOMWrapperWorld* instead of a worldID.
3574
3575         * page/PageGroup.cpp:
3576         (WebCore::PageGroup::addUserScriptToWorld):
3577         (WebCore::PageGroup::addUserStyleSheetToWorld):
3578         (WebCore::PageGroup::removeUserScriptFromWorld):
3579         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
3580         (WebCore::PageGroup::removeUserScriptsFromWorld):
3581         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
3582         * page/PageGroup.h:
3583         Changed these functions to take a DOMWrapperWorld* instead of a
3584         worldID. Also updated for changes to UserScript and UserStyleSheet.
3585
3586         * page/UserScript.h:
3587         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
3588         never used.
3589
3590         * page/UserScriptTypes.h:
3591         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
3592         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
3593         worldID as their key type.
3594
3595
3596 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
3597
3598         Reviewed by Tim Hatcher.
3599
3600         Fixes <http://webkit.org/b/31260>.
3601         Web Inspector: Main Resources Other than HTML are mis-detected.
3602         
3603         Even if the resource is a main resource, look at its CachedResource type, 
3604         because it might be an image, stylesheet, or JavaScript file, and we
3605         want to show them all correctly.
3606
3607         * inspector/InspectorResource.cpp:
3608         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
3609         (WebCore::InspectorResource::type): 
3610         * inspector/InspectorResource.h:
3611
3612 2009-11-12  Jens Alfke  <snej@chromium.org>
3613
3614         Reviewed by Dimitri Glazkov.
3615
3616         Table-driven setup for V8 binding template callback functions. 100k in code savings.
3617         https://bugs.webkit.org/show_bug.cgi?id=31420
3618
3619         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
3620             to call configureTemplate().
3621         * bindings/v8/V8Binding.cpp:
3622         (WebCore::configureTemplate):  New function; does all the standard configuration work.
3623         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
3624         * bindings/v8/V8Binding.h:
3625         * bindings/v8/V8Proxy.cpp:
3626         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
3627         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
3628         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
3629         * bindings/v8/V8Proxy.h:
3630
3631 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
3632
3633         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
3634
3635         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3636
3637 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
3638
3639         Reviewed by Dan Bernstein.
3640
3641         <rdar://problem/7388969> Add DOM API for fullscreen video
3642         
3643         DOM API for fullscreen <video>.
3644
3645         Tests: media/media-fullscreen-inline.html
3646                media/media-fullscreen-not-in-document.html
3647
3648         * dom/EventNames.h:
3649             Add webkitbeginfullscreen and webkitendfullscreen.
3650
3651         * html/HTMLAttributeNames.in:
3652             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
3653
3654         * html/HTMLMediaElement.cpp:
3655         (WebCore::HTMLMediaElement::parseMappedAttribute):
3656             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
3657         (WebCore::HTMLMediaElement::enterFullscreen):
3658             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
3659             actually do enter fullscreen.
3660         (WebCore::HTMLMediaElement::exitFullscreen):
3661             Schedule webkitendfullscreenEvent event.
3662         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
3663         (WebCore::HTMLMediaElement::webkitExitFullScreen):
3664         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
3665         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
3666             New, access to fullscreen properties and methods.
3667
3668         * html/HTMLMediaElement.h:
3669         * html/HTMLMediaElement.idl:
3670             Declare methods needed for fullscreen API.
3671
3672         * html/HTMLVideoElement.cpp:
3673         (WebCore::HTMLVideoElement::supportsFullscreen):
3674             Return false if a movie does not have video.
3675
3676         * page/DOMWindow.h:
3677             Add webkitbeginfullscreen and webkitendfullscreen.
3678
3679 2009-11-12  Adam Barth  <abarth@webkit.org>
3680
3681         Reviewed by Dimitri Glazkov.
3682
3683         [Chromium] Sify compose button alerts error
3684         https://bugs.webkit.org/show_bug.cgi?id=31394
3685
3686         Test: http/tests/security/calling-versus-current.html
3687
3688         We're supposed to use the calling context for security checks.  In JSC
3689         land, this is the lexicalGlobalObject.
3690
3691         * bindings/v8/V8Proxy.cpp:
3692         (WebCore::V8Proxy::canAccessPrivate):
3693
3694 2009-11-12  Daniel Bates  <dbates@webkit.org>
3695
3696         Reviewed by Darin Adler.
3697
3698         https://bugs.webkit.org/show_bug.cgi?id=30291
3699
3700         Fixes an issue where the returned drop effect is incorrect when
3701         effectAllowed == "uninitialized".
3702
3703         According to section 7.9.2 of the HTML 5 spec.
3704         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
3705         when effectAllowed = "uninitialized" the resulting dropEffect should be the
3706         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
3707         other case.
3708         
3709         No test cases are included because we have an existing test case from
3710         bug #24731.
3711
3712         * dom/Clipboard.cpp:
3713         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
3714
3715 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3716
3717         Reviewed by Timothy Hatcher.
3718
3719         Web Inspector: Do not highlight node on refresh.
3720
3721         https://bugs.webkit.org/show_bug.cgi?id=31419
3722
3723         * inspector/front-end/ElementsPanel.js:
3724         (WebInspector.ElementsPanel.prototype.reset):
3725
3726 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3727
3728         Reviewed by Timothy Hatcher.
3729
3730         Web Inspector: Minor timeline fixes.
3731
3732         https://bugs.webkit.org/show_bug.cgi?id=31417
3733
3734         * inspector/front-end/TimelinePanel.js:
3735         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3736         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3737         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
3738         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
3739
3740 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
3741
3742         SnowLeopard build fix.
3743
3744         Renamed initWithClient to initWithAuthenticationClient.
3745
3746         * platform/network/mac/AuthenticationMac.mm:
3747         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
3748         (WebCore::AuthenticationChallenge::setAuthenticationClient):
3749
3750 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
3751
3752         Reviewed by Darin Adler.
3753
3754         ARIA: add alert type roles
3755         https://bugs.webkit.org/show_bug.cgi?id=31392
3756
3757         Test: platform/mac/accessibility/aria-alerts.html
3758
3759         * accessibility/AccessibilityObject.h:
3760         * accessibility/AccessibilityRenderObject.cpp:
3761         * accessibility/mac/AccessibilityObjectWrapper.mm:
3762
3763 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
3764
3765         Reviewed by Darin Adler.
3766
3767         https://bugs.webkit.org/show_bug.cgi?id=31386
3768         Make Mac AuthenticationChallenge usable from cross-platform code
3769
3770         No change in behavior, so no tests.
3771
3772         * platform/network/ResourceHandle.cpp:
3773         (WebCore::ResourceHandle::clearAuthentication):
3774         * platform/network/ResourceHandleInternal.h:
3775         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
3776         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
3777         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
3778         is identical.
3779
3780         * platform/network/cf/AuthenticationChallenge.h:
3781         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
3782         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
3783
3784         * platform/network/cf/ResourceHandleCFNet.cpp:
3785         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
3786         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
3787         be already set.
3788
3789         * platform/network/mac/AuthenticationChallenge.h:
3790         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
3791         best of my understanding.
3792         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
3793         confusion with "mac" and "web" challenges in ResourceHandleInternal.
3794
3795         * platform/network/mac/AuthenticationMac.mm:
3796         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
3797         making it possible to use the latter with NSURLAuthenticationChallenge.
3798         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
3799         m_nsChallenge renaming.
3800         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
3801         set it as sender (or unset, if client is null).
3802
3803         * platform/network/mac/ResourceHandleMac.mm:
3804         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
3805         authentication challenge sender.
3806         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
3807         authentication sheet.
3808         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
3809         using the new setAuthenticationClient() method.
3810         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
3811         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
3812         the original Mac one, not the one we created for use with authentication sheet. I don't
3813         know when a connection would cancel authentication in practice, so I haven't tested this.
3814
3815 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3816
3817         Reviewed by Timothy Hatcher.
3818
3819         Web Inspector: breakpoint sidebar entries should allow click over entire list item
3820         https://bugs.webkit.org/show_bug.cgi?id=31411
3821
3822         No new tests; no new functionality, small usability change. 
3823
3824         * inspector/front-end/BreakpointsSidebarPane.js:
3825         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
3826         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
3827
3828 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3829
3830         Reviewed by Timothy Hatcher.
3831
3832         Web Inspector: breakpoints in named evals are not restored after a reload
3833         https://bugs.webkit.org/show_bug.cgi?id=31375
3834
3835         Manual test added
3836
3837         * inspector/front-end/ScriptsPanel.js:
3838         (WebInspector.ScriptsPanel.prototype.addScript):
3839         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
3840
3841 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
3842
3843         Reviewed by Kenneth Rohde Christiansen.
3844
3845         Custom printing shrink factors
3846         https://bugs.webkit.org/show_bug.cgi?id=29042
3847
3848         This reverts commit r49769. The public API for this needs to be reviewed
3849         before its inclusion in Qt.
3850
3851         * page/PrintContext.cpp:
3852         (WebCore::PrintContext::begin):
3853         * page/Settings.cpp:
3854         (WebCore::Settings::Settings):
3855         * page/Settings.h:
3856
3857 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
3858
3859         Reviewed by Pavel Feldman.
3860
3861         Web Inspector: Resource errors/warnings not shown in the Resource tree.
3862
3863         Error/Warning bubbles are not displayed next to the resource in the 
3864         Resources panel if those occur before the resource is attached to the tree.
3865         https://bugs.webkit.org/show_bug.cgi?id=31404
3866
3867         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
3868
3869         * inspector/front-end/AbstractTimelinePanel.js:
3870         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3871         * inspector/front-end/ResourcesPanel.js:
3872         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
3873
3874 2009-11-12  Philippe Normand  <pnormand@igalia.com>
3875
3876         Reviewed by Jan Alonzo.
3877
3878         https://bugs.webkit.org/show_bug.cgi?id=31047
3879         [GTK] Failing test media/video-played-ranges-1.html
3880
3881         Follow-up of r50726, don't block the UI thread when calling
3882         gst_element_get_state(). Also fixed a compilation warning and some
3883         static casts.
3884
3885         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3886         (WebCore::playbackPosition):
3887         (WebCore::MediaPlayerPrivate::seek):
3888         (WebCore::MediaPlayerPrivate::setRate):
3889
3890 2009-11-12  Philippe Normand  <pnormand@igalia.com>
3891
3892         Reviewed by Jan Alonzo.
3893
3894         https://bugs.webkit.org/show_bug.cgi?id=31047
3895         [GTK] Failing test media/video-played-ranges-1.html
3896
3897         don't pause pipeline if already paused, same for play()
3898
3899         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3900         (WebCore::MediaPlayerPrivate::play):
3901         (WebCore::MediaPlayerPrivate::pause):
3902
3903 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
3904
3905         Reviewed by David Levin.
3906
3907         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
3908         Chromium too.
3909         https://bugs.webkit.org/show_bug.cgi?id=31292
3910
3911         No new tests. (Corresponding test for Gtk+ is
3912         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
3913
3914         * page/EventHandler.cpp:
3915         * page/chromium/EventHandlerChromium.cpp:
3916
3917 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
3918
3919         Reviewed by Eric Seidel.
3920
3921         Prevent text inside a multi-column block from being split into columns.
3922         
3923         If the tentative height of a multi-column block was too small, we need to
3924         expand the block height and try to layout again, in order to prevent text
3925         from being split into different columns.
3926
3927         CSS Multicolumn text is split awkwardly
3928         https://bugs.webkit.org/show_bug.cgi?id=22249
3929
3930         Test: fast/multicol/single-line.html
3931
3932         * rendering/RenderBlock.cpp:
3933         (WebCore::RenderBlock::layoutColumns):
3934         * rendering/RenderBlock.h:
3935         * rendering/RenderLineBoxList.cpp:
3936         (WebCore::RenderLineBoxList::paint):
3937         * rendering/RenderView.h:
3938         (WebCore::RenderView::setTruncatedAt):
3939         (WebCore::RenderView::setMinimumColumnHeight):
3940         (WebCore::RenderView::minimumColumnHeight):
3941
3942 2009-11-11  Kent Tamura  <tkent@chromium.org>
3943
3944         Reviewed by Darin Adler.
3945
3946         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
3947         https://bugs.webkit.org/show_bug.cgi?id=31195
3948
3949         Test: fast/forms/input-file-re-render.html
3950
3951         * rendering/RenderFileUploadControl.cpp:
3952         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
3953
3954 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
3955
3956         Reviewed by Dimitri Glazkov.
3957
3958         Fixing Chromium's POSIX VFS implementation, by adding the required
3959         "used file descriptors" logic.
3960
3961         https://bugs.webkit.org/show_bug.cgi?id=31275
3962
3963         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3964
3965 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
3966
3967         Reviewed by Oliver Hunt.
3968
3969         need to implement aria tree roles
3970         https://bugs.webkit.org/show_bug.cgi?id=31284
3971
3972         Tests: platform/mac/accessibility/aria-multiselectable.html
3973                platform/mac/accessibility/aria-tree.html
3974
3975         * accessibility/AccessibilityList.cpp:
3976         (WebCore::AccessibilityList::accessibilityIsIgnored):
3977         * accessibility/AccessibilityObject.cpp:
3978         (WebCore::AccessibilityObject::ariaTreeRows):
3979         (WebCore::AccessibilityObject::ariaTreeItemContent):
3980         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
3981         * accessibility/AccessibilityObject.h:
3982         (WebCore::):
3983         (WebCore::AccessibilityObject::isTree):
3984         (WebCore::AccessibilityObject::isTreeItem):
3985         (WebCore::AccessibilityObject::setIsExpanded):
3986         (WebCore::AccessibilityObject::canSetExpandedAttribute):
3987         (WebCore::AccessibilityObject::hierarchicalLevel):
3988         (WebCore::AccessibilityObject::setSelectedRows):
3989         (WebCore::AccessibilityObject::performDefaultAction):
3990         * accessibility/AccessibilityRenderObject.cpp:
3991         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
3992         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
3993         (WebCore::AccessibilityRenderObject::isExpanded):
3994         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
3995         (WebCore::AccessibilityRenderObject::elementAttributeValue):
3996         (WebCore::AccessibilityRenderObject::setIsExpanded):
3997         (WebCore::AccessibilityRenderObject::isSelected):
3998         (WebCore::AccessibilityRenderObject::setSelected):
3999         (WebCore::AccessibilityRenderObject::setSelectedRows):
4000         (WebCore::createARIARoleMap):
4001         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
4002         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
4003         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
4004         (WebCore::AccessibilityRenderObject::selectedChildren):
4005         * accessibility/AccessibilityRenderObject.h:
4006         * accessibility/mac/AccessibilityObjectMac.mm:
4007         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
4008         * accessibility/mac/AccessibilityObjectWrapper.mm:
4009         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
4010         (RoleEntry::):
4011         (-[AccessibilityObjectWrapper subrole]):
4012         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
4013         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
4014         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
4015         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
4016         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
4017         * html/HTMLAttributeNames.in:
4018
4019 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
4020
4021         Build fix after @r50760 with ENABLE_FILTERS.
4022
4023         * platform/graphics/filters/SourceAlpha.cpp:
4024         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
4025         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
4026           to fillRect.
4027
4028 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
4029
4030         Reviewed by Alexey Proskuryakov.
4031
4032         Fix WebSocket frame parser of frame_type with high-order bit set.
4033         https://bugs.webkit.org/show_bug.cgi?id=30668
4034
4035         If buffer is smaller than frame's length, it should break the loop
4036         instead of reading next byte.
4037
4038         Tests: websocket/tests/frame-length-longer-than-buffer.html
4039                websocket/tests/frame-length-skip.html
4040
4041         * websockets/WebSocketChannel.cpp:
4042         (WebCore::WebSocketChannel::didReceiveData):
4043
4044 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
4045
4046         Reviewed by Adam Barth.
4047
4048         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
4049         https://bugs.webkit.org/show_bug.cgi?id=31345
4050
4051         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
4052
4053         * platform/graphics/chromium/FontCustomPlatformData.cpp:
4054         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
4055         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
4056         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
4057
4058 2009-11-11  Beth Dakin  <bdakin@apple.com>
4059
4060         Build fix. No review needed.
4061
4062         * platform/graphics/gtk/FontGtk.cpp:
4063         (WebCore::Font::drawComplexText):
4064
4065 2009-11-11  Beth Dakin  <bdakin@apple.com>
4066
4067         Build fix. No review needed.
4068
4069         * platform/graphics/cairo/FontCairo.cpp:
4070         (WebCore::Font::drawGlyphs):
4071
4072 2009-11-11  Beth Dakin  <bdakin@apple.com>
4073
4074         Windows build fix. No review needed. 
4075
4076         * platform/graphics/win/FontCGWin.cpp:
4077         (WebCore::Font::drawGlyphs):
4078
4079 2009-11-11  Beth Dakin  <bdakin@apple.com>
4080
4081         Reviewed by Simon Fraser.
4082
4083         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
4084         Make -webkit-color-correction work with shadows
4085
4086         From canvas, just send DeviceColorSpace to setShadow() for now. 
4087         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
4088         * html/canvas/CanvasRenderingContext2D.cpp:
4089         (WebCore::CanvasRenderingContext2D::setShadow):
4090         (WebCore::CanvasRenderingContext2D::applyShadow):
4091
4092         setShadow() and setPlatformShadow() now take a ColorSpace.
4093         * platform/graphics/GraphicsContext.cpp:
4094         (WebCore::GraphicsContext::setShadow):
4095         * platform/graphics/GraphicsContext.h:
4096         * platform/graphics/cg/GraphicsContextCG.cpp:
4097         (WebCore::createCGColorWithColorSpace): New helper to create a 
4098         color in a ColorSpace.
4099         (WebCore::setCGFillColor): Call new helper.
4100         (WebCore::setCGStrokeColor): Call new helper.
4101         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
4102         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
4103         (WebCore::GraphicsContext::setPlatformShadow):
4104
4105         Send appropriate ColorSpace to setShadow().
4106         * platform/graphics/mac/FontMac.mm:
4107         (WebCore::Font::drawGlyphs):
4108         * rendering/EllipsisBox.cpp:
4109         (WebCore::EllipsisBox::paint):
4110         * rendering/InlineFlowBox.cpp:
4111         (WebCore::InlineFlowBox::paintTextDecorations):
4112         * rendering/InlineTextBox.cpp:
4113         (WebCore::paintTextWithShadows):
4114         (WebCore::InlineTextBox::paintDecoration):
4115         * rendering/RenderBoxModelObject.cpp:
4116         (WebCore::RenderBoxModelObject::paintBoxShadow):
4117         * rendering/SVGInlineTextBox.cpp:
4118         (WebCore::SVGInlineTextBox::paintCharacters):
4119         * rendering/SVGRenderSupport.cpp:
4120         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
4121
4122         Attempt to keep ports building.
4123         * platform/graphics/cairo/GraphicsContextCairo.cpp:
4124         (WebCore::GraphicsContext::setPlatformShadow):
4125         * platform/graphics/qt/GraphicsContextQt.cpp:
4126         (WebCore::GraphicsContext::setPlatformShadow):
4127         * platform/graphics/skia/GraphicsContextSkia.cpp:
4128         (WebCore::GraphicsContext::setPlatformShadow):
4129         * platform/graphics/wince/GraphicsContextWince.cpp:
4130         (WebCore::GraphicsContext::setPlatformShadow):
4131         * platform/graphics/wx/GraphicsContextWx.cpp:
4132         (WebCore::GraphicsContext::setPlatformShadow):
4133
4134 2009-11-11  Kent Tamura  <tkent@chromium.org>
4135
4136         Reviewed by Darin Adler.
4137
4138         Print the file text of a file upload control in DumpRenderTree for ease of tests.
4139         https://bugs.webkit.org/show_bug.cgi?id=31195
4140
4141         * rendering/RenderFileUploadControl.cpp:
4142         (WebCore::RenderFileUploadControl::paintObject):
4143         (WebCore::RenderFileUploadControl::fileTextValue):
4144         * rendering/RenderFileUploadControl.h:
4145         (WebCore::RenderFileUploadControl::isFileUploadControl):
4146         (WebCore::toRenderFileUploadControl):
4147         * rendering/RenderObject.h:
4148         (WebCore::RenderObject::isFileUploadControl):
4149         * rendering/RenderTreeAsText.cpp:
4150         (WebCore::operator<<):
4151
4152 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
4153
4154         Reviewed by Sam Weinig.
4155
4156         DOM Wrappers for some nodes may not be marked.
4157         https://bugs.webkit.org/show_bug.cgi?id=31380
4158
4159         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
4160         the wrapper for the current world only.  This means that wrappers may be GC'ed
4161         prematurely, and properties lost.
4162
4163         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
4164
4165         * bindings/js/JSAttrCustom.cpp:
4166         (WebCore::JSAttr::markChildren):
4167         * bindings/js/JSDOMBinding.cpp:
4168         (WebCore::markDOMNodeWrapper):
4169         * bindings/js/JSDOMBinding.h:
4170         * bindings/js/JSNamedNodeMapCustom.cpp:
4171         (WebCore::JSNamedNodeMap::markChildren):
4172         * bindings/js/JSNodeCustom.cpp:
4173         (WebCore::JSNode::markChildren):
4174         * bindings/js/JSSVGElementInstanceCustom.cpp:
4175         (WebCore::JSSVGElementInstance::markChildren):
4176         * bindings/js/JSStyleSheetCustom.cpp:
4177         (WebCore::JSStyleSheet::markChildren):
4178
4179 2009-11-11  Ben Murdoch  <benm@google.com>
4180
4181         Reviewed by Darin Adler.
4182
4183         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
4184         https://bugs.webkit.org/show_bug.cgi?id=31384
4185
4186         No functionality change so no tests required.
4187
4188         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
4189
4190 2009-11-11  Jens Alfke  <snej@chromium.org>
4191
4192         Reviewed by Dimitri Glazkov.
4193
4194         The Big De-Inlining. 450k code size reduction (32-bit x86.)
4195         - Various inline functions in V8Binding.h made non-inline.
4196         - Some renaming for consistency.
4197         - New function createRawTemplate().
4198         https://bugs.webkit.org/show_bug.cgi?id=31383
4199
4200         * bindings/scripts/CodeGeneratorV8.pm:
4201         * bindings/v8/V8Binding.cpp:
4202         (WebCore::v8DOMWrapperToNative):
4203         (WebCore::v8ValueToWebCoreString):
4204         (WebCore::v8ValueToAtomicWebCoreString):
4205         (WebCore::toInt32):
4206         (WebCore::toWebCoreString):
4207         (WebCore::toWebCoreStringWithNullCheck):
4208         (WebCore::toAtomicWebCoreStringWithNullCheck):
4209         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
4210         (WebCore::isUndefinedOrNull):
4211         (WebCore::v8Boolean):
4212         (WebCore::v8UndetectableString):
4213         (WebCore::v8StringOrNull):
4214         (WebCore::v8StringOrUndefined):
4215         (WebCore::v8StringOrFalse):
4216         (WebCore::v8StringToWebCoreString):
4217         (WebCore::v8ExternalString):
4218         (WebCore::createRawTemplate):  New function.
4219         * bindings/v8/V8Binding.h:
4220         (WebCore::v8DOMWrapperTo):
4221         (WebCore::v8DOMWrapperToNode):
4222         (WebCore::v8StringToWebCoreString):
4223         (WebCore::v8StringToAtomicWebCoreString):
4224
4225 2009-11-11  Jens Alfke  <snej@chromium.org>
4226
4227         Reviewed by Dimitri Glazkov.
4228
4229         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
4230         event-listener setter into a new subroutine transferHiddenDependency().
4231         https://bugs.webkit.org/show_bug.cgi?id=31377
4232
4233         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
4234         * bindings/v8/V8Utilities.cpp:
4235         (WebCore::transferHiddenDependency):  New.
4236         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
4237
4238 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
4239
4240         Reviewed by Beth Dakin.
4241
4242         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
4243         because there is a CG bug preventing this from working.
4244
4245         * platform/graphics/cg/GraphicsContextCG.cpp:
4246         (WebCore::sRGBColorSpaceRef):
4247
4248 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
4249
4250         Reviewed by Timothy Hatcher.
4251
4252         Check that if Storage panel exists before calling its methods
4253
4254         https://bugs.webkit.org/show_bug.cgi?id=31343
4255
4256         * inspector/front-end/inspector.js:
4257         (WebInspector.addDatabase):
4258         (WebInspector.addCookieDomain):
4259         (WebInspector.addDOMStorage):
4260         (WebInspector.updateDOMStorage):
4261
4262 2009-11-11  Jens Alfke  <snej@chromium.org>
4263
4264         Reviewed by Dimitri Glazkov.
4265
4266         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
4267         times in the generated V8 bindings.
4268         https://bugs.webkit.org/show_bug.cgi?id=31368
4269