2006-10-14 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-14  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2
3         Reviewed by Maciej.
4
5         Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
6         Pure virtual classes require non-pure destructor, who knew.
7
8         Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
9         so that other platforms can also use CURL, if they wish.
10
11         Silence compiler warning about unused variable in SharedTimerLinux.cpp
12
13         * platform/ResourceLoaderInternal.h:
14         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
15         * platform/gdk/FrameGdk.h:
16         (WebCore::FrameGdkClient::~FrameGdkClient):
17         * platform/gdk/ResourceLoaderManager.cpp:
18         (WebCore::ResourceLoaderManager::downloadTimerCallback):
19         * platform/gdk/SharedTimerLinux.cpp:
20         (WebCore::stopSharedTimer):
21
22 2006-10-13  Beth Dakin  <bdakin@apple.com>
23
24         Reviewed by Geoff.
25
26         Build fix from my last check-in. Make hasOutlineAnnotation() non-
27         inline so that we don't have to include Document.h in 
28         RenderObject.h
29         Doing so causes a build failure in WebKit, and it probably isn't a 
30         good idea anyway.
31
32         * rendering/RenderObject.cpp:
33         (WebCore::RenderObject::hasOutlineAnnotation):
34         * rendering/RenderObject.h:
35         (WebCore::RenderObject::hasOutline):
36
37 2006-10-13  Beth Dakin  <bdakin@apple.com>
38
39         Patch written mostly by Ken Kraisler, but also by me.
40
41         Reviewed by Hyatt.
42
43         Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
44         problem/3391162> PDF created by printing should have live 
45         hyperlinks
46
47         * platform/GraphicsContext.cpp:
48         (WebCore::GraphicsContext::focusRingBoundingRect):
49         * platform/GraphicsContext.h:
50         * platform/cairo/GraphicsContextCairo.cpp:
51         (WebCore::GraphicsContext::setURLForRect):
52         * platform/cg/GraphicsContextCG.cpp:
53         (WebCore::GraphicsContext::setURLForRect): Implement method to add 
54         URL link to PDF document.
55         * rendering/InlineFlowBox.cpp:
56         (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of 
57         querying the outline width
58         * rendering/RenderBlock.cpp:
59         (WebCore::RenderBlock::paintObject): Same as above.
60         * rendering/RenderFlow.cpp:
61         (WebCore::RenderFlow::paintLines): Call the new paintOutline()
62         (WebCore::RenderFlow::paintOutline): Take care of focus ring and 
63         pdf url rects, and outline painting.
64         * rendering/RenderFlow.h:
65         * rendering/RenderObject.cpp:
66         (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF 
67         link to a rectanglular region.
68         (WebCore::RenderObject::paintOutline): Take care of pdf rects as 
69         well as focus ring painting.
70         * rendering/RenderObject.h:
71         (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the 
72         element is a link and we are printing.
73         (WebCore::RenderObject::hasOutline): Returns true is the style has 
74         an outline and hasOutlineAnnotation() is true.
75         * rendering/RenderStyle.h:
76         (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is 
77         greater than 0 and outlineStyle is greater than BHIDDEN.
78
79 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
80
81         Reviewed by ggaren and harrison
82         
83         <rdar://problem/4744008>
84         9A270: Mail crashes when I try to paste large items from Safari
85
86         * editing/ReplaceSelectionCommand.cpp:
87         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
88         Even though we put nodes in the hash map in pre-order, they don't necessary
89         come out of the iterator that way.  If a node is a redundant style span
90         and one of its pruned ancestors comes off the hash map after it, and that
91         ancestor is a redundant style span or font tag, we will try to remove it
92         even though it has already been removed and we'll crash.
93         The test case added with the fix depends on our hash map implementation
94         because it requires that a particular redundant style span come out of 
95         the iterator before its parent. So, it may eventually not provide 
96         coverage for the fix.
97
98 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
99
100         Reviewed by Darin.
101
102         - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
103
104         * WebCore.xcodeproj/project.pbxproj:
105         * bindings/js/kjs_window.cpp:
106         (KJS::createNewWindow):
107         (KJS::WindowFunc::callAsFunction):
108         * bridge/BrowserExtension.h:
109         * bridge/mac/BrowserExtensionMac.h:
110         * bridge/mac/BrowserExtensionMac.mm:
111         (WebCore::BrowserExtensionMac::createNewWindow):
112         * bridge/mac/FrameMac.h:
113         * bridge/mac/FrameMac.mm:
114         (WebCore::FrameMac::submitForm):
115         (WebCore::FrameMac::openURLRequest):
116         (WebCore::FrameMac::urlSelected):
117         * bridge/win/BrowserExtensionWin.h:
118         * page/Frame.cpp:
119         (WebCore::Frame::changeLocation):
120         (WebCore::Frame::urlSelected):
121         (WebCore::Frame::requestFrame):
122         (WebCore::Frame::submitForm):
123         * page/Frame.h:
124         * page/FrameLoadRequest.h: Added.
125         (WebCore::FrameLoadRequest::FrameLoadRequest):
126         (WebCore::FrameLoadRequest::lockHistory):
127         (WebCore::FrameLoadRequest::setLockHistory):
128         * page/ResourceRequest.h:
129         (WebCore::ResourceRequest::ResourceRequest):
130
131 2006-10-13  John Sullivan  <sullivan@apple.com>
132
133         Reviewed by Maciej
134
135         * loader/mac/WebFrameLoader.mm:
136         (-[WebFrameLoader loadDocumentLoader:]):
137         Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can
138         happen when loading a page during a decidePolicyForNavigationAction callback.
139
140 2006-10-13  Dave Hyatt  <hyatt@apple.com>
141
142         Transparency layer work.
143
144         Reviewed by aroben
145
146         * platform/GraphicsContext.h:
147         * platform/cg/GraphicsContextCG.cpp:
148         (WebCore::GraphicsContext::beginTransparencyLayer):
149         (WebCore::GraphicsContext::endTransparencyLayer):
150         * platform/cg/GraphicsContextPlatformPrivate.h:
151         (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
152         (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
153
154 2006-10-13  Rob Buis  <buis@kde.org>
155
156         Reviewed by Mitz.
157
158         http://bugs.webkit.org/show_bug.cgi?id=11217
159         Cleanup svg coding style
160
161         Cleanup coding style in svg paint server classes.
162
163         * ksvg2/svg/SVGGradientElement.cpp:
164         (WebCore::SVGGradientElement::SVGGradientElement):
165         (WebCore::SVGGradientElement::parseMappedAttribute):
166         (WebCore::SVGGradientElement::notifyAttributeChange):
167         (WebCore::SVGGradientElement::canvasResource):
168         (WebCore::SVGGradientElement::rebuildStops):
169         * ksvg2/svg/SVGGradientElement.h:
170         * ksvg2/svg/SVGLinearGradientElement.cpp:
171         (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
172         (WebCore::SVGLinearGradientElement::parseMappedAttribute):
173         (WebCore::SVGLinearGradientElement::buildGradient):
174         * ksvg2/svg/SVGLinearGradientElement.h:
175         * ksvg2/svg/SVGPatternElement.cpp:
176         (WebCore::SVGPatternElement::SVGPatternElement):
177         (WebCore::SVGPatternElement::parseMappedAttribute):
178         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
179         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
180         (WebCore::SVGPatternElement::notifyClientsToRepaint):
181         (WebCore::SVGPatternElement::notifyAttributeChange):
182         (WebCore::SVGPatternElement::canvasResource):
183         (WebCore::SVGPatternElement::getCTM):
184         * ksvg2/svg/SVGPatternElement.h:
185         (WebCore::SVGPatternElement::rendererIsNeeded):
186         * ksvg2/svg/SVGRadialGradientElement.cpp:
187         (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
188         (WebCore::SVGRadialGradientElement::parseMappedAttribute):
189         (WebCore::SVGRadialGradientElement::buildGradient):
190         * ksvg2/svg/SVGRadialGradientElement.h:
191         * ksvg2/svg/SVGStopElement.cpp:
192         (WebCore::SVGStopElement::SVGStopElement):
193         (WebCore::SVGStopElement::parseMappedAttribute):
194         * ksvg2/svg/SVGStopElement.h:
195
196 2006-10-13  Geoffrey Garen  <ggaren@apple.com>
197
198         Reviewed by Darin, John.
199
200         - Merged more frame and iframe code
201         - Fixed a bug where iframes returned incorrect values for renderer-dependent 
202         properties during javascript: loads because they didn't have renderers at 
203         load time
204         
205         PLT insists this is a small performance win. Don't believe its lies.
206
207         * bindings/js/kjs_html.cpp:
208         (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to
209         width and height, for consistency with the rest of the DOM.
210         * dom/ContainerNode.cpp:
211         (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback
212         queue that gets drained after the render tree is fully constructed. Currently,
213         this is only used for frame loading.
214         (WebCore::ContainerNode::attach):
215         * dom/ContainerNode.h:
216         * html/HTMLFrameElement.cpp:
217         (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from
218         attach() because loading iframes during attach() causes a crash. 
219         Moved frame loading logic into insertedIntoDocument(). That's a more 
220         logical place for it because  document insertion is what 
221         triggers frame loading. Made frame loading a post-attach callback, instead
222         of an immediate action, to fix the incorrect values bug.
223         (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be
224         in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon 
225         require this call, once I remove the call from WebKit.
226         (WebCore::HTMLFrameElement::setLocation):
227         (WebCore::HTMLFrameElement::width):
228         (WebCore::HTMLFrameElement::height):
229         * html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary
230         killing of puppies.
231         * html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement
232         (WebCore::HTMLIFrameElement::rendererIsNeeded):
233         (WebCore::HTMLIFrameElement::createRenderer):
234         (WebCore::HTMLIFrameElement::insertedIntoDocument):
235         (WebCore::HTMLIFrameElement::removedFromDocument):
236         (WebCore::HTMLIFrameElement::attach):
237         * page/FrameView.h: Removed unused method.
238
239 2006-10-13  David Harrison  <harrison@apple.com>
240
241         Reviewed by Justin.
242
243         <rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
244
245         Tests added or changed:
246         * editing/style/style-boundary-005.html: Added. Matches steps from bug.
247         * editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
248         * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
249         * editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
250         * editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
251
252         * dom/Text.cpp:
253         (WebCore::Text::splitText):
254         Comment changes.
255         
256         * editing/ApplyStyleCommand.cpp:
257         (WebCore::isUnstyledStyleSpan):
258         Renamed from isEmptyStyleSpan.
259         
260         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
261         Rename emptySpans local to unstyledSpans.
262         
263         (WebCore::dummySpanAncestorForNode):
264         New. To locate Apple style span created when splitting a text node.
265         
266         (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
267         Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
268         of dummy span's parents, rather than traversing up from start and
269         end locations. Old algorithm would miss empty spans in the bug case.
270         
271         (WebCore::ApplyStyleCommand::applyInlineStyle):
272         Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().
273         
274         (WebCore::ApplyStyleCommand::removeCSSStyle):
275         Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().
276         
277         (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
278         Comment changes.
279         
280         * editing/ApplyStyleCommand.h:
281         Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().
282           
283         * editing/ReplaceSelectionCommand.cpp:
284         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
285         Allow for Apple style span to be unstyled, because old email may have this in the DOM.
286         Use !node->hasChildNodes() instead of !node->firstChild().
287         
288         * editing/SplitTextNodeCommand.cpp:
289         (WebCore::SplitTextNodeCommand::doApply):
290         Comment changes.
291         
292         * rendering/RenderTreeAsText.cpp:
293         (WebCore::isEmptyOrUnstyledAppleStyleSpan):
294         (WebCore::operator<<):
295         Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM
296
297 2006-10-13  Nikolas Zimmermann  <zimmermann@kde.org>
298
299         Reviewed by Eric.
300
301         Fix Qt/Linux build after Adele's popup menu changes.
302
303         * CMakeLists.txt:
304         * platform/qt/FileChooserQt.cpp:
305         (WebCore::FileChooser::disconnectUploadControl):
306         * platform/qt/PopupMenuQt.cpp: Added.
307         (WebCore::PopupMenu::PopupMenu):
308         (WebCore::PopupMenu::~PopupMenu):
309         (WebCore::PopupMenu::clear):
310         (WebCore::PopupMenu::populate):
311         (WebCore::PopupMenu::show):
312         (WebCore::PopupMenu::hide):
313         (WebCore::PopupMenu::addSeparator):
314         (WebCore::PopupMenu::addGroupLabel):
315         (WebCore::PopupMenu::addOption):
316         * platform/qt/RenderPopupMenuQt.cpp: Removed.
317         * platform/qt/RenderPopupMenuQt.h: Removed.
318         * platform/qt/RenderThemeQt.cpp:
319
320 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
321
322         Reviewed by Darin.
323
324         fixed build failure 
325
326         * WebCore.xcodeproj/project.pbxproj:
327         * loader/mac/WebFrameLoader.mm:
328
329 2006-10-13  Darin Adler  <darin@apple.com>
330
331         Reviewed by Adele.
332
333         - converted WebFormState from Objective-C to C++
334
335         * WebCore.exp: Added a new symbol, changed one symbol from C to C++.
336
337         * WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project".
338         Added UChar.h and FrameLoaderTypes.h.
339
340         * loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.
341
342         * loader/mac/WebFormState.h: Converted class to C++.
343         * loader/mac/WebFormState.mm: Ditto.
344
345         * loader/mac/WebFrameLoader.h:
346         * loader/mac/WebFrameLoader.mm:
347         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
348         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
349         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
350         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
351         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
352         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
353         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
354         (-[WebFrameLoader continueAfterNavigationPolicy:]):
355         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
356         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
357         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
358         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
359         Changed Objective-C WebFormState uses to C++ WebCore::FormState.
360
361 2006-10-13  Adele Peterson  <adele@apple.com>
362
363         Reviewed by Maciej.
364
365         - Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color
366
367         * rendering/RenderListBox.cpp:
368         (WebCore::RenderListBox::paintItemForeground):
369         * rendering/RenderTheme.cpp:
370         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
371         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
372         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
373         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
374         * rendering/RenderThemeMac.h:
375         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
376
377 2006-10-13  Rob Buis  <buis@kde.org>
378
379         Reviewed by Mitz.
380
381         http://bugs.webkit.org/show_bug.cgi?id=11217
382         Cleanup svg coding style
383
384         Cleanup coding style in svg structure classes.
385
386         * ksvg2/svg/SVGDefsElement.cpp:
387         (WebCore::SVGDefsElement::SVGDefsElement):
388         * ksvg2/svg/SVGDefsElement.h:
389         * ksvg2/svg/SVGDescElement.cpp:
390         (WebCore::SVGDescElement::SVGDescElement):
391         * ksvg2/svg/SVGDescElement.h:
392         * ksvg2/svg/SVGDocument.cpp:
393         * ksvg2/svg/SVGDocument.h:
394         * ksvg2/svg/SVGElementInstance.cpp:
395         (WebCore::SVGElementInstance::SVGElementInstance):
396         (WebCore::SVGElementInstance::correspondingElement):
397         (WebCore::SVGElementInstance::correspondingUseElement):
398         (WebCore::SVGElementInstance::parentNode):
399         (WebCore::SVGElementInstance::childNodes):
400         (WebCore::SVGElementInstance::previousSibling):
401         (WebCore::SVGElementInstance::nextSibling):
402         (WebCore::SVGElementInstance::firstChild):
403         (WebCore::SVGElementInstance::lastChild):
404         * ksvg2/svg/SVGElementInstance.h:
405         * ksvg2/svg/SVGElementInstanceList.cpp:
406         * ksvg2/svg/SVGElementInstanceList.h:
407         * ksvg2/svg/SVGGElement.cpp:
408         (WebCore::SVGGElement::SVGGElement):
409         (WebCore::SVGGElement::parseMappedAttribute):
410         (WebCore::SVGDummyElement::SVGDummyElement):
411         * ksvg2/svg/SVGGElement.h:
412         (WebCore::SVGGElement::rendererIsNeeded):
413         * ksvg2/svg/SVGImageElement.cpp:
414         (WebCore::SVGImageElement::createRenderer):
415         * ksvg2/svg/SVGImageElement.h:
416         * ksvg2/svg/SVGSVGElement.cpp:
417         (WebCore::SVGSVGElement::SVGSVGElement):
418         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
419         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
420         (WebCore::SVGSVGElement::currentScale):
421         (WebCore::SVGSVGElement::setCurrentScale):
422         (WebCore::SVGSVGElement::currentTranslate):
423         (WebCore::SVGSVGElement::parseMappedAttribute):
424         (WebCore::SVGSVGElement::suspendRedraw):
425         (WebCore::SVGSVGElement::unsuspendRedraw):
426         (WebCore::SVGSVGElement::unsuspendRedrawAll):
427         (WebCore::SVGSVGElement::forceRedraw):
428         (WebCore::SVGSVGElement::getIntersectionList):
429         (WebCore::SVGSVGElement::getEnclosureList):
430         (WebCore::SVGSVGElement::checkIntersection):
431         (WebCore::SVGSVGElement::checkEnclosure):
432         (WebCore::SVGSVGElement::deselectAll):
433         (WebCore::SVGSVGElement::createSVGLength):
434         (WebCore::SVGSVGElement::createSVGAngle):
435         (WebCore::SVGSVGElement::createSVGMatrix):
436         (WebCore::SVGSVGElement::createSVGTransform):
437         (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
438         (WebCore::SVGSVGElement::getCTM):
439         (WebCore::SVGSVGElement::getScreenCTM):
440         (WebCore::SVGSVGElement::setCurrentTime):
441         * ksvg2/svg/SVGSVGElement.h:
442         (WebCore::SVGSVGElement::rendererIsNeeded):
443         * ksvg2/svg/SVGSwitchElement.cpp:
444         (WebCore::SVGSwitchElement::SVGSwitchElement):
445         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
446         * ksvg2/svg/SVGSwitchElement.h:
447         (WebCore::SVGSwitchElement::rendererIsNeeded):
448         * ksvg2/svg/SVGSymbolElement.cpp:
449         (WebCore::SVGSymbolElement::SVGSymbolElement):
450         (WebCore::SVGSymbolElement::parseMappedAttribute):
451         * ksvg2/svg/SVGSymbolElement.h:
452         (WebCore::SVGSymbolElement::shouldAttachChild):
453         * ksvg2/svg/SVGTitleElement.cpp:
454         (WebCore::SVGTitleElement::SVGTitleElement):
455         * ksvg2/svg/SVGTitleElement.h:
456         * ksvg2/svg/SVGUseElement.cpp:
457         (WebCore::SVGUseElement::parseMappedAttribute):
458         (WebCore::SVGUseElement::closeRenderer):
459         * ksvg2/svg/SVGUseElement.h:
460         (WebCore::SVGUseElement::rendererIsNeeded):
461
462 2006-10-12  Adele Peterson  <adele@apple.com>
463
464         Reviewed by Anders.
465
466         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11172
467           REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
468         
469          Test: fast/forms/listbox-width-change.html
470
471         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
472           When the options change, call setNeedsLayoutAndMinMaxRecalc.
473
474 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
475
476         Reviewed by Oliver.
477
478         - moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies
479
480         * WebCore.xcodeproj/project.pbxproj:
481         * bridge/mac/WebCoreFrameBridge.h:
482         * bridge/mac/WebCoreFrameBridge.mm:
483         (stringByCollapsingNonPrintingCharacters):
484         (-[WebCoreFrameBridge setTitle:]):
485         (-[WebCoreFrameBridge didFirstLayout]):
486         (-[WebCoreFrameBridge notifyIconChanged:]):
487         (-[WebCoreFrameBridge originalRequestURL]):
488         (-[WebCoreFrameBridge isLoadTypeReload]):
489         (-[WebCoreFrameBridge frameDetached]):
490         (-[WebCoreFrameBridge tokenizerProcessedData]):
491         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
492         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
493         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
494         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
495         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
496         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
497         (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
498         (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
499         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
500         (-[WebCoreFrameBridge incomingReferrer]):
501         (-[WebCoreFrameBridge isReloading]):
502         (-[WebCoreFrameBridge handledOnloadEvents]):
503         (-[WebCoreFrameBridge mainResourceURLResponse]):
504         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
505         * loader/mac/LoaderNSURLExtras.h:
506         * loader/mac/LoaderNSURLRequestExtras.h: Added.
507         * loader/mac/LoaderNSURLRequestExtras.m: Added.
508         (isConditionalRequest):
509         (setHTTPReferrer):
510         * loader/mac/WebFrameLoader.mm:
511         * loader/mac/WebSubresourceLoader.mm:
512
513 2006-10-12  Adele Peterson  <adele@apple.com>
514
515         RS by Geoff.
516
517         Renamed menuListIsDetaching to disconnectMenuList, 
518         uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.  
519         These names match similar methods in WebCore a little better.
520
521         * platform/FileChooser.h:
522         * platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
523         * platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]):
524         (WebCore::FileChooser::disconnectUploadControl):
525         * platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
526         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
527         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):
528
529 2006-10-12  Adele Peterson  <adele@apple.com>
530
531         Reviewed by Maciej.
532
533         WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
534
535         Added private delegate method for clients that want access to a PopupMenu's NSMenu.
536
537         * bridge/mac/FrameMac.h:
538         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
539         * bridge/mac/WebCoreFrameBridge.h:
540
541         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.
542
543 2006-10-12  Adele Peterson  <adele@apple.com>
544
545         Reviewed by Alice.
546
547         - Fix for <rdar://problem/4707372> 
548           After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu
549
550         * platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
551         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
552         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up,
553           in case the RenderMenuList goes away.  Also, checks the pointer to the menu list immediately afterwards.
554
555 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
556
557         Reviewed by Maciej.
558
559         Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
560         document.open(); document.write(..); and NO document.close(). On the Qt platform this
561         leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
562         DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.
563
564         Hmpf, this took me nine hours to debug today.
565         Result: Couldn't find the real fix, going for a workaround for now.
566         
567         540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.
568
569         * platform/qt/FrameQt.cpp:
570         (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
571         * platform/qt/FrameQtClient.cpp:
572         (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().
573
574 2006-10-12  Adam Roben  <aroben@apple.com>
575
576         Reviewed by Adele.
577
578         Move popup menu code out of rendering/ and into platform/.
579         RenderPopupMenu becomes PopupMenu, the
580         RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
581         virtual methods go away, RenderTheme gets to stop worrying about popup
582         menus, PopupMenu becomes ref-counted, and everyone becomes happy.
583
584         * WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
585         * WebCore.xcodeproj/project.pbxproj: Ditto.
586         * html/HTMLSelectElement.cpp: Remove unnecessary #include.
587         * platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp.
588         Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate
589         from RenderMenuList::showPopup/hidePopup.
590         (WebCore::PopupMenu::create): New static creation method to hand back a
591         PassRefPtr<PopupMenu>.
592         (WebCore::PopupMenu::addItems): This platform-independent method should
593         be called by PopupMenu::populate when the platform-specific
594         implementation is ready to receive the menu items. Fixed an ASSERT
595         while I was at it.
596         * platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more
597         need for virtual methods.
598         (WebCore::PopupMenu::wasClicked):
599         (WebCore::PopupMenu::setWasClicked):
600         (WebCore::PopupMenu::popupHandle):
601         * platform/mac/PopupMenuMac.mm: Moved from
602         rendering/RenderPopupMenuMac.mm. Much renaming ensues.
603         (WebCore::PopupMenu::PopupMenu):
604         (WebCore::PopupMenu::~PopupMenu):
605         (WebCore::PopupMenu::clear):
606         (WebCore::PopupMenu::populate):
607         (WebCore::PopupMenu::show):
608         (WebCore::PopupMenu::hide):
609         (WebCore::PopupMenu::addSeparator):
610         (WebCore::PopupMenu::addGroupLabel): Since we don't have our own
611         RenderStyle anymore, just pick up the style from our RenderMenuList.
612         (WebCore::PopupMenu::addOption): Ditto.
613         * platform/win/TemporaryLinkStubs.cpp: Rename-fest.
614         (PopupMenu::PopupMenu):
615         (PopupMenu::~PopupMenu):
616         (PopupMenu::clear):
617         (PopupMenu::populate):
618         (PopupMenu::show):
619         (PopupMenu::hide):
620         (PopupMenu::addSeparator):
621         (PopupMenu::addGroupLabel):
622         (PopupMenu::addOption):
623         * rendering/RenderMenuList.cpp:
624         (WebCore::RenderMenuList::~RenderMenuList):
625         (WebCore::RenderMenuList::showPopup): Use nice new simple
626         PopupMenu::create to make the popup.
627         (WebCore::RenderMenuList::hidePopup):
628         * rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a
629         RenderPopupMenu*.
630         (WebCore::RenderMenuList::popup):
631         * rendering/RenderPopupMenu.cpp: Removed.
632         * rendering/RenderPopupMenu.h: Removed.
633         * rendering/RenderPopupMenuMac.h: Removed.
634         * rendering/RenderPopupMenuMac.mm: Removed.
635         * rendering/RenderPopupMenuWin.h: Removed.
636         * rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
637         * rendering/RenderTheme.h: Ditto.
638         * rendering/RenderThemeMac.h: Ditto.
639         * rendering/RenderThemeMac.mm: Ditto.
640         * rendering/RenderThemeWin.cpp: Ditto.
641         * rendering/RenderThemeWin.h: Ditto.
642
643 2006-10-12  Adele Peterson  <adele@apple.com>
644
645         Reviewed by Dave Harrison.
646
647         - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
648
649         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
650         Make subtree layouts work for textareas as well as text fields.
651
652 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
653
654         Reviewed by MacDome.
655
656         Finally found a way to remove our begin() trickery in FrameQt.
657         The (probably misnamed) Frame::setEncoding() function automatically
658         calls Frame::receivedFirstData() which calls being on the working
659         url, which has been passed to didOpenUrl(). Took me some hours
660         to figure out that the missing charset logic, forced us to do hacks.
661
662         * platform/ResourceLoader.h:
663         * platform/ResourceLoaderInternal.h:
664         * platform/qt/FrameQt.cpp:
665         (WebCore::FrameQt::tokenizerProcessedData):
666         * platform/qt/FrameQt.h:
667         * platform/qt/FrameQtClient.cpp:
668         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
669         (WebCore::FrameQtClientDefault::openURL):
670         (WebCore::FrameQtClientDefault::submitForm):
671         (WebCore::FrameQtClientDefault::receivedData):
672         (WebCore::FrameQtClientDefault::receivedAllData):
673         * platform/qt/FrameQtClient.h:
674         * platform/qt/ResourceLoaderManager.cpp:
675         (WebCore::ResourceLoaderManager::slotData):
676         (WebCore::ResourceLoaderManager::slotMimetype):
677         (WebCore::ResourceLoaderManager::slotResult):
678         (WebCore::ResourceLoaderManager::remove):
679         * platform/qt/ResourceLoaderQt.cpp:
680         (WebCore::ResourceLoader::retrieveCharset):
681         (WebCore::ResourceLoader::extractCharsetFromHeaders):
682
683 2006-10-12  Adam Roben  <aroben@apple.com>
684
685         Reviewed by Hyatt.
686
687         Bandaid-ing a null-dereference crash until a real fix is made.
688
689         * page/FrameView.cpp:
690         (WebCore::FrameView::windowClipRect):
691
692 2006-10-12  Rob Buis  <buis@kde.org>
693
694         Reviewed by Mitz.
695
696         http://bugs.webkit.org/show_bug.cgi?id=11217
697         Cleanup svg coding style
698
699         Cleanup coding style in svg text classes.
700
701         * ksvg2/svg/SVGTRefElement.cpp:
702         (WebCore::SVGTRefElement::SVGTRefElement):
703         (WebCore::SVGTRefElement::updateReferencedText):
704         (WebCore::SVGTRefElement::parseMappedAttribute):
705         (WebCore::SVGTRefElement::childShouldCreateRenderer):
706         (WebCore::SVGTRefElement::createRenderer):
707         * ksvg2/svg/SVGTRefElement.h:
708         (WebCore::SVGTRefElement::rendererIsNeeded):
709         * ksvg2/svg/SVGTSpanElement.cpp:
710         (WebCore::SVGTSpanElement::SVGTSpanElement):
711         (WebCore::SVGTSpanElement::childShouldCreateRenderer):
712         (WebCore::SVGTSpanElement::createRenderer):
713         * ksvg2/svg/SVGTSpanElement.h:
714         (WebCore::SVGTSpanElement::rendererIsNeeded):
715         * ksvg2/svg/SVGTextContentElement.cpp:
716         (WebCore::SVGTextContentElement::SVGTextContentElement):
717         (WebCore::SVGTextContentElement::parseMappedAttribute):
718         * ksvg2/svg/SVGTextContentElement.h:
719         * ksvg2/svg/SVGTextElement.cpp:
720         (WebCore::SVGTextElement::SVGTextElement):
721         (WebCore::SVGTextElement::localMatrix):
722         (WebCore::SVGTextElement::parseMappedAttribute):
723         (WebCore::SVGTextElement::updateLocalTransform):
724         (WebCore::SVGTextElement::nearestViewportElement):
725         (WebCore::SVGTextElement::farthestViewportElement):
726         (WebCore::SVGTextElement::getScreenCTM):
727         (WebCore::SVGTextElement::getCTM):
728         (WebCore::SVGTextElement::createRenderer):
729         (WebCore::SVGTextElement::childShouldCreateRenderer):
730         * ksvg2/svg/SVGTextElement.h:
731         (WebCore::SVGTextElement::getTransformToElement):
732         (WebCore::SVGTextElement::rendererIsNeeded):
733         * ksvg2/svg/SVGTextPositioningElement.cpp:
734         (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
735         (WebCore::SVGTextPositioningElement::parseMappedAttribute):
736         * ksvg2/svg/SVGTextPositioningElement.h:
737
738 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
739
740         Reviewed by Maciej.
741
742         Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.
743
744         * platform/qt/FrameQt.cpp:
745         (WebCore::FrameQt::runJavaScriptAlert): Move runJavaScriptAlert functionality to FrameQtClientDefault.
746         * platform/qt/FrameQtClient.cpp:
747         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
748         * platform/qt/FrameQtClient.h:
749
750 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
751
752         Reviewed by Eric.
753
754         - move m_responseMIMEType out of ResourceRequest, where it doesn't belong
755
756         * page/FramePrivate.h: Add m_responseMIMEType
757         * page/ResourceRequest.h: Remove m_responseMIMEType
758         * page/Frame.cpp:
759         (WebCore::Frame::setResponseMIMEType): added
760         (WebCore::Frame::responseMIMEType): added
761         (WebCore::Frame::begin): get MIME type from the right place
762         (WebCore::Frame::write): ditto
763         * page/Frame.h:
764         * bindings/js/kjs_window.cpp:
765         (KJS::createNewWindow): updated to use new Frame methods
766         (KJS::WindowFunc::callAsFunction): ditto
767         * bridge/mac/WebCoreFrameBridge.mm:
768         (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto
769         (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
770         * loader/PluginDocument.cpp:
771         (WebCore::PluginTokenizer::createDocumentStructure): ditto
772
773 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
774
775         Reviewed by Eric.
776         
777         <rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image
778
779         We really need some way to test loadHTMLString since it keeps breaking!
780         
781         * loader/mac/WebFrameLoader.mm:
782         (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.
783
784 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
785
786         Reviewed by Eric.
787
788         Fix Qt/Linux build.
789
790         * CMakeLists.txt:
791         * platform/qt/FileChooserQt.cpp:
792         (WebCore::FileChooser::create):
793
794 2006-10-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
795
796         Reviewed by Maciej.
797
798         Update Gdk\Linux build for recent changes, based on Qt code
799
800         * platform/gdk/FrameGdk.cpp:
801         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
802         (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault):
803         (WebCore::FrameGdkClientDefault::setFrame):
804         (WebCore::FrameGdkClientDefault::openURL):
805         (WebCore::FrameGdkClientDefault::submitForm):
806         (WebCore::FrameGdkClientDefault::receivedResponse):
807         (WebCore::FrameGdkClientDefault::receivedData):
808         (WebCore::FrameGdkClientDefault::receivedAllData):
809         (WebCore::FrameGdk::FrameGdk):
810         (WebCore::FrameGdk::openURL):
811         (WebCore::FrameGdk::submitForm):
812         (WebCore::FrameGdk::urlSelected):
813         * platform/gdk/FrameGdk.h:
814         * platform/gdk/TemporaryLinkStubs.cpp:
815         (FrameGdk::createJavaAppletWidget):
816         (FileChooser::create):
817
818 2006-10-12  Dave Hyatt  <hyatt@apple.com>
819
820         Patch to add more clipping retrieval functionality for widgets.
821        
822         Reviewed by mjs
823
824         * page/Frame.h:
825         Remove windowResizerRect.  This is in the wrong place.
826         
827         * page/FrameView.cpp:
828         (WebCore::FrameView::windowClipRect):
829         (WebCore::FrameView::windowClipRectForLayer):
830         Break out windowClipRect into helper functions that can be called separately (to make
831         it easier for scrollbars in overflow sections and list boxes to get to an enclosing
832         layer and get the right clip.
833         
834         * page/FrameView.h:
835         Add the new windowClipRect helper methods.
836         
837         * platform/ScrollBar.h:
838         Add a new interface to ScrollbarClient so that scrollbars can hand back proper
839         clip rects for themselves depending on how they are used.
840         
841         * platform/ScrollView.h:
842         Stub out methods for talking to a double buffer backing store on Win32.
843         
844         * platform/Widget.h:
845         Add the ability to query for invalidation suppression.
846         
847         * rendering/RenderLayer.cpp:
848         (WebCore::RenderLayer::windowClipRect):
849         (WebCore::RenderLayer::paintOverflowControls):
850         (WebCore::RenderLayer::calculateRects):
851         (WebCore::RenderLayer::childrenClipRect):
852         (WebCore::RenderLayer::selfClipRect):
853         * rendering/RenderLayer.h:
854         Enhance layers so that they can return either their foreground or background
855         document clip rects.  Make sure a layer scrollbar can return a proper clip.
856         
857         * rendering/RenderListBox.cpp:
858         (WebCore::RenderListBox::windowClipRect):
859         * rendering/RenderListBox.h:
860         Make sure a list box scrollbar can return a proper clip.
861         
862         * rendering/RenderObject.cpp:
863         (WebCore::RenderObject::enclosingLayer):
864         * rendering/RenderObject.h:
865         Make enclosingLayer const.
866         
867 2006-10-11  Darin Adler  <darin@apple.com>
868
869         Reviewed by John.
870
871         - some changes to prepare for converting more code to C++
872
873         * bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is
874         self-sufficient.
875
876         * bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class.
877         Needed since the class is used in this header (for some work I have not landed yet).
878
879         * loader/mac/LoaderNSURLExtras.h:
880         * loader/mac/WebFormDataStream.h:
881         Added extern "C" so this code can be used from C++.
882
883         * loader/mac/LoaderNSURLExtras.m:
884         * loader/mac/WebDataProtocol.mm:
885         * loader/mac/WebDocumentLoader.mm:
886         * loader/mac/WebFormDataStream.m:
887         * loader/mac/WebLoader.mm:
888         * loader/mac/WebMainResourceLoader.mm:
889         * loader/mac/WebNetscapePlugInStreamLoader.mm:
890         * loader/mac/WebPolicyDecider.mm:
891         * loader/mac/WebSubresourceLoader.mm:
892         Added missing includes of config.h.
893
894 2006-10-11  John Sullivan  <sullivan@apple.com>
895         
896         Darin wrote this code; we tested it; I give it the thumbs up.
897         
898         - fixed regression from svn revision 16982 that was generating the wrong Obj-C classes
899
900         The hash table to look up an element class given a QualifiedName was
901         not working at all.
902
903         * dom/QualifiedName.h:
904         (WebCore::QualifiedName::impl):
905         Added. This new accessor method for impl is needed if we want to use
906         a QualifiedName as a hash table key without doing the kind of specialization
907         we do for String. Maybe later we can do the String thing.
908
909         * bindings/objc/DOM.mm:
910         (WebCore::addElementClass):
911         Use QualifiedName.impl instead of the QualifiedName pointer itself.
912         The QualifiedName pointer is *not* unique so almost nothing would be found
913         in this hash table!
914         (WebCore::elementClass):
915         ditto
916         
917 2006-10-11  Adam Roben  <aroben@apple.com>
918
919         Rubberstamped by Anders.
920
921         Clean up FileChooser::create and Icon::newIconForFile.
922
923         * WebCore.xcodeproj/project.pbxproj:
924         * platform/mac/FileChooserMac.mm:
925         (WebCore::FileChooser::create):
926         * platform/mac/IconMac.mm:
927         (WebCore::Icon::newIconForFile):
928
929 2006-10-11  Oliver Hunt  <oliver@apple.com>
930
931         Reviewed by Adam.
932
933         Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
934         Corrects canvas tag to not throw JS exception when drawing
935         zero sized rects, arcs, etc
936
937         * html/CanvasRenderingContext2D.cpp:
938         (WebCore::CanvasRenderingContext2D::arcTo):
939         (WebCore::CanvasRenderingContext2D::arc):
940         (WebCore::CanvasRenderingContext2D::rect):
941         (WebCore::CanvasRenderingContext2D::clearRect):
942         (WebCore::CanvasRenderingContext2D::fillRect):
943         (WebCore::CanvasRenderingContext2D::strokeRect):
944
945 2006-10-11  Rob Buis  <buis@kde.org>
946
947         Reviewed by Mitz.
948
949         http://bugs.webkit.org/show_bug.cgi?id=11221
950         REGRESSION: iExploder crash due to style="cursor: url()"
951
952         Take better care of empty cursor lists.
953
954         Test: fast/css/invalid-cursor-property-crash.html
955
956         * css/cssparser.cpp:
957         (WebCore::CSSParser::parseValue):
958
959 2006-10-11  Adam Roben  <aroben@apple.com>
960
961         Fixing Windows for real this time.
962
963         * platform/win/TemporaryLinkStubs.cpp:
964         (FileChooser::create):
965
966 2006-10-11  Adam Roben  <aroben@apple.com>
967
968         Fix Windows build.
969
970         * platform/win/TemporaryLinkStubs.cpp:
971         (FileChooser::create):
972
973 2006-10-11  Antti Koivisto  <koivisto@iki.fi>
974
975         Reviewed by Hyatt.
976         
977         http://bugs.webkit.org/show_bug.cgi?id=4377
978         
979         Respect css visibility semantics for layers too
980
981         * rendering/RenderContainer.cpp:
982         (WebCore::RenderContainer::removeChildNode):
983         (WebCore::RenderContainer::appendChildNode):
984         (WebCore::RenderContainer::insertChildNode):
985         * rendering/RenderLayer.cpp:
986         (WebCore::RenderLayer::RenderLayer):
987         (WebCore::RenderLayer::updateLayerPositions):
988         (WebCore::RenderLayer::setHasVisibleContent):
989         (WebCore::RenderLayer::dirtyVisibleContentStatus):
990         (WebCore::RenderLayer::childVisibilityChanged):
991         (WebCore::RenderLayer::dirtyVisibleDescendantStatus):
992         (WebCore::RenderLayer::updateVisibilityStatus):
993         (WebCore::RenderLayer::addChild):
994         (WebCore::RenderLayer::removeChild):
995         (WebCore::RenderLayer::updateZOrderLists):
996         (WebCore::RenderLayer::collectLayers):
997         * rendering/RenderLayer.h:
998         (WebCore::RenderLayer::hasVisibleContent):
999         * rendering/RenderObject.cpp:
1000         (WebCore::RenderObject::setStyle):
1001
1002 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1003
1004         Reviewed by Oliver.
1005
1006         - added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
1007
1008         * WebCore.xcodeproj/project.pbxproj:
1009         * platform/cf/RetainPtr.h: Added.
1010         (WTF::):
1011         (WTF::RetainPtr::RetainPtr):
1012         (WTF::RetainPtr::~RetainPtr):
1013         (WTF::RetainPtr::get):
1014         (WTF::RetainPtr::operator*):
1015         (WTF::RetainPtr::operator->):
1016         (WTF::RetainPtr::operator!):
1017         (WTF::RetainPtr::operator UnspecifiedBoolType):
1018         (WTF::::operator):
1019         (WTF::::swap):
1020         (WTF::swap):
1021         (WTF::operator==):
1022         (WTF::operator!=):
1023         (WTF::static_pointer_cast):
1024         (WTF::const_pointer_cast):
1025         (WTF::getPtr):
1026         
1027         - use it in WidgetMac so it gets tested in at least one place
1028         
1029         * platform/mac/WidgetMac.mm:
1030         (WebCore::Widget::Widget):
1031         (WebCore::Widget::~Widget):
1032         (WebCore::Widget::setEnabled):
1033         (WebCore::Widget::isEnabled):
1034         (WebCore::Widget::setCursor):
1035         (WebCore::Widget::getView):
1036         (WebCore::Widget::setView):
1037         (WebCore::Widget::getOuterView):
1038
1039 2006-10-10  Brady Eidson  <beidson@apple.com>
1040
1041         Reviewed by Maciej.
1042
1043         Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge
1044
1045         * bridge/mac/WebCoreFrameBridge.h:
1046         * bridge/mac/WebCoreFrameBridge.mm:
1047         (-[WebCoreFrameBridge initMainFrameWithPage:]):
1048         (-[WebCoreFrameBridge initSubframeWithOwnerElement:]):
1049         (-[WebCoreFrameBridge dealloc]):
1050         (-[WebCoreFrameBridge close]):
1051         (-[WebCoreFrameBridge setFrameLoaderClient:]):
1052         (-[WebCoreFrameBridge frameLoader]):
1053         * loader/mac/WebFrameLoader.h:
1054         * loader/mac/WebFrameLoader.mm:
1055         (-[WebFrameLoader initWithFrameBridge:]):
1056         (-[WebFrameLoader setFrameLoaderClient:]):
1057
1058 2006-10-10  Adam Roben  <aroben@apple.com>
1059
1060         Reviewed by Oliver.
1061
1062         Make FileChooser ref-counted.
1063
1064         * platform/FileChooser.h:
1065         * platform/mac/FileChooserMac.mm:
1066         (WebCore::FileChooser::create):
1067         * rendering/RenderFileUploadControl.cpp:
1068         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
1069         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1070         * rendering/RenderFileUploadControl.h:
1071
1072 2006-10-10  Sam Weinig  <sam.weinig@gmail.com>
1073
1074         Reviewed by Tim H.
1075
1076         Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
1077         Even More auto-generated Objective-C DOM bindings changes
1078
1079         - Auto-generate DOMSVGPathElement.
1080
1081         - Auto-generate the internal interfaces even for classes that have
1082           custom internal implementations.  Change IDL property from ObjCNoInternal
1083           to ObjCCustomInternalImpl to indicate the change.
1084
1085         - Add SVG classes to DOMNode and DOMEvent internal interfaces.
1086
1087         - Add isSVGZoomEvent() method to Event class to match other Event subclasses
1088           and make DOM binding possible.
1089
1090         - Assorted cleanups.
1091
1092         * DerivedSources.make:
1093         * WebCore.xcodeproj/project.pbxproj:
1094         * bindings/objc/DOM.mm:
1095         (WebCore::addElementClass):
1096         (WebCore::createElementClassMap):
1097         (WebCore::elementClass):
1098         (-[DOMNode description]):
1099         (+[DOMNode _nodeWith:WebCore::]):
1100         (-[DOMNode addEventListener:listener:useCapture:]):
1101         (-[DOMNode removeEventListener:listener:useCapture:]):
1102         (-[DOMElement _NPObject]):
1103         (WebCore::ObjCEventListener::handleEvent):
1104         * bindings/objc/DOMEvents.mm:
1105         (+[DOMEvent _eventWith:WebCore::]):
1106         * bindings/objc/DOMInternal.h:
1107         * bindings/objc/DOMRGBColor.mm:
1108         (-[DOMRGBColor WebCore::]):
1109         * bindings/objc/DOMSVGPathSegInternal.h: Removed.
1110         * bindings/scripts/CodeGeneratorObjC.pm:
1111         * css/CSSRule.idl:
1112         * css/CSSValue.idl:
1113         * css/StyleSheet.idl:
1114         * dom/Event.cpp:
1115         (WebCore::Event::isSVGZoomEvent):
1116         * dom/Event.h:
1117         * dom/Event.idl:
1118         * dom/Node.idl:
1119         * ksvg2/events/SVGZoomEvent.cpp:
1120         (WebCore::SVGZoomEvent::isSVGZoomEvent):
1121         * ksvg2/events/SVGZoomEvent.h:
1122         * ksvg2/svg/SVGAnimatedAngle.idl:
1123         * ksvg2/svg/SVGCircleElement.idl:
1124         * ksvg2/svg/SVGClipPathElement.idl:
1125         * ksvg2/svg/SVGPathElement.idl:
1126         * ksvg2/svg/SVGPathSeg.idl:
1127
1128 2006-10-10  Oliver Hunt  <oliver@apple.com>
1129
1130         rubber stamped by Anders.
1131
1132         More buildbot bustage
1133
1134         * kcanvas/SVGInlineFlowBox.cpp:
1135         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1136
1137 2006-10-10  Oliver Hunt  <oliver@apple.com>
1138
1139         Reviewed by Anders 
1140
1141         Unbreak build bots
1142
1143         * dom/Text.cpp:
1144         * kcanvas/RenderSVGText.cpp:
1145         (WebCore::RenderSVGText::layout):
1146         * kcanvas/SVGInlineFlowBox.cpp:
1147         (WebCore::placePositionedBoxesHorizontally):
1148         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1149
1150 2006-10-10  Oliver Hunt  <oliver@apple.com>
1151
1152         Reviewed by hyatt.
1153
1154         Fixes bugs #6423, #6559, #10380 and #10839 
1155
1156         * WebCore.xcodeproj/project.pbxproj:
1157         * css/svg.css:
1158         * dom/Text.cpp:
1159         (WebCore::Text::createRenderer):
1160         * kcanvas/RenderSVGInline.cpp: Added.
1161         (WebCore::RenderSVGInline::RenderSVGInline):
1162         (WebCore::RenderSVGInline::createInlineBox):
1163         * kcanvas/RenderSVGInline.h: Added.
1164         (WebCore::RenderSVGInline::renderName):
1165         (WebCore::RenderSVGInline::requiresLayer):
1166         * kcanvas/RenderSVGInlineText.cpp: Added.
1167         (WebCore::RenderSVGInlineText::RenderSVGInlineText):
1168         (WebCore::RenderSVGInlineText::absoluteRects):
1169         (WebCore::RenderSVGInlineText::selectionRect):
1170         * kcanvas/RenderSVGInlineText.h: Added.
1171         (WebCore::RenderSVGInlineText::renderName):
1172         (WebCore::RenderSVGInlineText::requiresLayer):
1173         * kcanvas/RenderSVGTSpan.cpp: Added.
1174         (WebCore::RenderSVGTSpan::RenderSVGTSpan):
1175         (WebCore::RenderSVGTSpan::absoluteRects):
1176         * kcanvas/RenderSVGTSpan.h: Added.
1177         (WebCore::RenderSVGTSpan::renderName):
1178         * kcanvas/RenderSVGText.cpp:
1179         (WebCore::RenderSVGText::RenderSVGText):
1180         (WebCore::RenderSVGText::computeAbsoluteRepaintRect):
1181         (WebCore::RenderSVGText::layout):
1182         (WebCore::RenderSVGText::createInlineBox):
1183         (WebCore::RenderSVGText::nodeAtPoint):
1184         (WebCore::RenderSVGText::absoluteRects):
1185         (WebCore::RenderSVGText::paint):
1186         (WebCore::RenderSVGText::relativeBBox):
1187         * kcanvas/RenderSVGText.h:
1188         (WebCore::RenderSVGText::renderName):
1189         * kcanvas/SVGInlineFlowBox.cpp: Added.
1190         (WebCore::SVGInlineFlowBox::paint):
1191         (WebCore::SVGInlineFlowBox::placeBoxesHorizontally):
1192         (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
1193         (WebCore::paintSVGInlineFlow):
1194         (WebCore::translateBox):
1195         (WebCore::placePositionedBoxesHorizontally):
1196         (WebCore::placeSVGFlowHorizontally):
1197         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1198         (WebCore::placeSVGFlowVertically):
1199         * kcanvas/SVGInlineFlowBox.h: Added.
1200         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
1201         * kcanvas/SVGRootInlineBox.cpp: Added.
1202         (WebCore::SVGRootInlineBox::paint):
1203         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
1204         (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
1205         * kcanvas/SVGRootInlineBox.h: Added.
1206         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
1207         * ksvg2/svg/SVGTRefElement.cpp:
1208         (SVGTRefElement::createRenderer):
1209         * ksvg2/svg/SVGTSpanElement.cpp:
1210         (SVGTSpanElement::createRenderer):
1211         * rendering/InlineFlowBox.h:
1212
1213 2006-10-10  Adam Roben  <aroben@apple.com>
1214
1215         Reviewed by Adele.
1216
1217         Improve popup menu behavior.
1218
1219         * html/HTMLSelectElement.cpp:
1220         (WebCore::HTMLSelectElement::HTMLSelectElement): Cache
1221         m_lastOnChangeIndex so we know when to fire onChange.
1222         (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to
1223         specify whether we should fire onChange.
1224         (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur.
1225         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire
1226         onChange when using the Enter key to change the selection.
1227         * html/HTMLSelectElement.h:
1228         * rendering/RenderMenuList.cpp:
1229         (WebCore::RenderMenuList::updateFromElement): Extract setText logic
1230         into its own method.
1231         (WebCore::RenderMenuList::setTextFromOption): New method.
1232         (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call
1233         onChange instead of calling it directly here.
1234         * rendering/RenderMenuList.h:
1235
1236 2006-10-10  Adele Peterson  <adele@apple.com>
1237
1238         Reviewed by Beth. 
1239
1240
1241         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text>
1242           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
1243
1244         Moved autoscroll code to the Frame class
1245
1246         * bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
1247         * bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags.  Moved autoscroll code to Frame::handleMouseMoveEvent.
1248         (WebCore::FrameMac::FrameMac):
1249         (WebCore::FrameMac::handleMousePressEvent):
1250         (WebCore::FrameMac::eventMayStartDrag):
1251         (WebCore::FrameMac::handleMouseMoveEvent):
1252         (WebCore::FrameMac::mouseDown):
1253
1254         * bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us.
1255         Now we scroll our views in WebCore.
1256
1257         * page/Frame.cpp:
1258         (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag.
1259         (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate.  Moved from FrameMac.
1260         (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too.
1261         (WebCore::Frame::mouseDownMayStartAutoscroll): Added.
1262         (WebCore::Frame::setMouseDownMayStartAutoscroll): Added.
1263         (WebCore::Frame::mouseDownMayStartDrag): Added.
1264         (WebCore::Frame::setMouseDownMayStartDrag): Added.
1265         (WebCore::Frame::autoscrollRenderer): Added
1266         (WebCore::Frame::setAutoscrollRenderer): Added.
1267         (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter.
1268         (WebCore::Frame::autoscrollTimerFired): ditto.
1269         (WebCore::Frame::stopAutoscrollTimer): ditto. 
1270         * page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.
1271
1272         * page/FramePrivate.h:
1273         (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags.  Moved from FrameMac.
1274
1275         * page/FrameView.cpp: Store the current mouse position in window coordinates.  The callers can convert to their own coordinate space.
1276         (WebCore::FrameView::handleMousePressEvent):
1277         (WebCore::FrameView::handleMouseDoubleClickEvent):
1278         (WebCore::FrameView::handleMouseMoveEvent):
1279         (WebCore::FrameView::handleMouseReleaseEvent):
1280
1281         * rendering/RenderLayer.cpp:
1282         (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection).  
1283          We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.
1284
1285         * rendering/RenderListBox.cpp:
1286         (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.
1287
1288         * rendering/RenderObject.cpp:
1289         (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too)
1290         (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.
1291
1292 2006-10-10  Darin Adler  <darin@apple.com>
1293
1294         Rubber stamped by Maciej.
1295
1296         - convert many of the loader source files to Objective-C++ to prepare
1297           to convert some of them to C++
1298
1299         * WebCore.xcodeproj/project.pbxproj:
1300         * loader/mac/WebDataProtocol.m: Removed.
1301         * loader/mac/WebDocumentLoader.m: Removed.
1302         * loader/mac/WebFormState.m: Removed.
1303         * loader/mac/WebFrameLoader.m: Removed.
1304         * loader/mac/WebLoader.m: Removed.
1305         * loader/mac/WebMainResourceLoader.m: Removed.
1306         * loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
1307         * loader/mac/WebPolicyDecider.m: Removed.
1308         * loader/mac/WebSubresourceLoader.m: Removed.
1309         * loader/mac/WebDataProtocol.mm: Added.
1310         * loader/mac/WebDocumentLoader.mm: Added.
1311         * loader/mac/WebFormState.mm: Added.
1312         * loader/mac/WebFrameLoader.mm: Added.
1313         * loader/mac/WebLoader.mm: Added.
1314         * loader/mac/WebMainResourceLoader.mm: Added.
1315         * loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
1316         * loader/mac/WebPolicyDecider.mm: Added.
1317         * loader/mac/WebSubresourceLoader.mm: Added.
1318
1319 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1320
1321         Reviewed by Mitz.
1322
1323         - fixed REGRESSION (r16960): crash on navigating to site
1324         http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE
1325         
1326         * loader/mac/WebFrameLoader.m:
1327         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
1328         Add back a mistakenly removed retain.
1329
1330 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1331
1332         Not reviewed, build fix.
1333
1334         - fixed release build
1335
1336         * WebCore.xcodeproj/project.pbxproj:
1337
1338 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1339
1340         Rubber stamped by Eric.
1341
1342         - moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile
1343
1344         * WebCore.exp:
1345         * WebCore.xcodeproj/project.pbxproj:
1346         * loader/mac/LoaderNSURLExtras.m: Added.
1347         * loader/mac/WebDataProtocol.m: Added.
1348         * loader/mac/WebDocumentLoader.m: Added.
1349         * loader/mac/WebFormDataStream.m: Added.
1350         * loader/mac/WebFrameLoader.m: Added.
1351         * loader/mac/WebLoader.m: Added.
1352         (-[NSURLProtocol didReceiveResponse:]):
1353         (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
1354         * loader/mac/WebMainResourceLoader.m: Added.
1355         (-[WebMainResourceLoader didReceiveResponse:]):
1356         * loader/mac/WebPolicyDecider.m: Added.
1357         * loader/mac/WebSubresourceLoader.h: Added.
1358         * loader/mac/WebSubresourceLoader.m: Added.
1359
1360 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1361
1362         Reviewed by Oliver (sort of?)
1363
1364         - WebCore part of moving down NSURL extras
1365
1366         * WebCore.exp:
1367         * platform/mac/WebCoreSystemInterface.h:
1368         * platform/mac/WebCoreSystemInterface.mm:
1369
1370 2006-10-09  Rob Buis  <buis@kde.org>
1371
1372         Reviewed by Mitz.
1373
1374         http://bugs.webkit.org/show_bug.cgi?id=11217
1375         Cleanup svg coding style
1376
1377         Cleanup coding style in svg animation classes.
1378
1379         * ksvg2/svg/SVGAnimateColorElement.cpp:
1380         (WebCore::SVGAnimateColorElement::handleTimerEvent):
1381         * ksvg2/svg/SVGAnimateElement.cpp:
1382         (WebCore::SVGAnimateElement::SVGAnimateElement):
1383         (WebCore::SVGAnimateElement::handleTimerEvent):
1384         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1385         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
1386         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
1387         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
1388         (WebCore::SVGAnimateTransformElement::parseTransformValue):
1389         (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):
1390         (WebCore::SVGAnimateTransformElement::initialMatrix):
1391         (WebCore::SVGAnimateTransformElement::transformMatrix):
1392         * ksvg2/svg/SVGAnimateTransformElement.h:
1393         * ksvg2/svg/SVGAnimatedPathData.cpp:
1394         * ksvg2/svg/SVGAnimatedPathData.h:
1395         * ksvg2/svg/SVGAnimatedPoints.cpp:
1396         * ksvg2/svg/SVGAnimatedPoints.h:
1397         * ksvg2/svg/SVGAnimationElement.cpp:
1398         (WebCore::SVGAnimationElement::targetElement):
1399
1400 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
1401
1402         Reviewed by Oliver.
1403
1404         - added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion
1405
1406         * bridge/mac/WebCoreFrameBridge.h:
1407         * bridge/mac/WebCoreFrameBridge.mm:
1408         (-[WebCoreFrameBridge isMainFrame]):
1409
1410 2006-10-09  Adam Roben  <aroben@apple.com>
1411
1412         Backing out accidental commit.
1413
1414         * page/Frame.cpp:
1415         (WebCore::Frame::finishedParsing):
1416
1417 2006-10-09  Adam Roben  <aroben@apple.com>
1418
1419         Reviewed by Darin.
1420
1421         Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
1422         this could cause recursive calls to the destructor. RefPtr now also
1423         inherits from Noncopyable.
1424
1425         * dom/NodeFilter.h:
1426         * dom/Traversal.h:
1427         * page/DOMWindow.h:
1428         * page/Frame.cpp:
1429         (WebCore::Frame::finishedParsing):
1430         * page/Frame.h:
1431         * page/Plugin.h:
1432         * platform/FontFallbackList.h:
1433         * platform/Icon.h:
1434         * platform/Shared.h:
1435         (WebCore::Shared::Shared):
1436         (WebCore::Shared::ref):
1437         (WebCore::Shared::deref):
1438         (WebCore::Shared::hasOneRef):
1439         (WebCore::Shared::refCount):
1440         * platform/StringImpl.h:
1441
1442 2006-10-09  Oliver Hunt <ohunt@apple.com>
1443
1444         Reviewed by Anders.
1445
1446         Correcting ifdef's
1447
1448         * html/CanvasGradient.cpp:
1449         (WebCore::CanvasGradient::CanvasGradient):
1450         (WebCore::CanvasGradient::~CanvasGradient):
1451         (WebCore::CanvasGradient::addColorStop):
1452         * html/CanvasGradient.h:
1453         * html/CanvasPattern.cpp:
1454         (WebCore::CanvasPattern::CanvasPattern):
1455         (WebCore::CanvasPattern::~CanvasPattern):
1456         * html/CanvasPattern.h:
1457         * html/CanvasRenderingContext2D.cpp:
1458         (WebCore::CanvasRenderingContext2D::fill):
1459         (WebCore::CanvasRenderingContext2D::stroke):
1460         (WebCore::CanvasRenderingContext2D::fillRect):
1461         (WebCore::CanvasRenderingContext2D::setShadow):
1462         (WebCore::CanvasRenderingContext2D::applyShadow):
1463         (WebCore::CanvasRenderingContext2D::drawImage):
1464         (WebCore::CanvasRenderingContext2D::createPattern):
1465         (WebCore::CanvasRenderingContext2D::applyStrokePattern):
1466         (WebCore::CanvasRenderingContext2D::applyFillPattern):
1467         * html/CanvasRenderingContext2D.h:
1468         * html/CanvasStyle.cpp:
1469         (WebCore::CanvasStyle::applyStrokeColor):
1470         (WebCore::CanvasStyle::applyFillColor):
1471         * html/HTMLCanvasElement.cpp:
1472         (WebCore::HTMLCanvasElement::paint):
1473         (WebCore::HTMLCanvasElement::createDrawingContext):
1474         * html/HTMLCanvasElement.h:
1475
1476 2006-10-09  Adam Roben  <aroben@apple.com>
1477
1478         Reviewed by Maciej.
1479
1480         Fix a possible recursive destructor call.
1481
1482         * page/Frame.cpp:
1483         (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor.
1484         (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if
1485         we're already being destroyed.
1486
1487 2006-10-09  Sam Weinig  <sam.weinig@gmail.com>
1488
1489         Reviewed by Tim H.
1490
1491         Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
1492         Assorted Objective-C bindings changes
1493
1494         - Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, 
1495           DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, 
1496           DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, 
1497           DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, 
1498           DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, 
1499           DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, 
1500           DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, 
1501           DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, 
1502           DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.
1503
1504         - Auto-generate absoluteImageURL method for DOMHTMLInputElement and
1505           DOMHTMLObjectElement.
1506
1507         - Auto-generate the internal methods for classes with ivars (notably 
1508           DOMNodeIterator and DOMTreeWalker)
1509
1510         - Put more methods in the WebCore namespace and factor out the  
1511           displayString method into DOMInternal.h as done by Darin in his 
1512           patch for http://bugs.webkit.org/show_bug.cgi?id=11219.
1513
1514         * DerivedSources.make:
1515         * WebCore.xcodeproj/project.pbxproj:
1516         * bindings/objc/DOM.mm:
1517         (-[DOMNode _initWithNode:WebCore::]):
1518         (+[DOMNode _nodeWith:WebCore::]):
1519         (-[DOMNode addEventListener:listener:useCapture:]):
1520         (-[DOMNode removeEventListener:listener:useCapture:]):
1521         (-[DOMNode dispatchEvent:]):
1522         (-[DOMElement _imageTIFFRepresentation]):
1523         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1524         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
1525         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1526         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1527         * bindings/objc/DOMCSS.mm:
1528         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1529         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
1530         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
1531         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
1532         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
1533         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1534         * bindings/objc/DOMEvents.mm:
1535         (-[DOMEvent _initWithEvent:WebCore::]):
1536         (+[DOMEvent _eventWith:WebCore::]):
1537         * bindings/objc/DOMExtensions.h:
1538         * bindings/objc/DOMHTML.mm:
1539         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
1540         * bindings/objc/DOMInternal.h:
1541         (-[DOMNodeFilter WebCore::]):
1542         * bindings/objc/DOMInternal.mm:
1543         (-[WebScriptObject _init]):
1544         (-[WebScriptObject _initializeScriptDOMNodeImp]):
1545         (WebCore::displayString):
1546         * bindings/objc/DOMObject.mm:
1547         (-[DOMObject dealloc]):
1548         (-[DOMObject finalize]):
1549         * bindings/objc/DOMRGBColor.mm:
1550         (-[DOMRGBColor dealloc]):
1551         (-[DOMRGBColor finalize]):
1552         (-[DOMRGBColor color]):
1553         (-[DOMRGBColor _initWithRGB:WebCore::]):
1554         (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
1555         * bindings/objc/DOMSVG.h:
1556         * bindings/objc/DOMSVGPathSegInternal.h: Added.
1557         * bindings/objc/DOMSVGPathSegInternal.mm: Added.
1558         (-[DOMSVGPathSeg WebCore::]):
1559         (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]):
1560         (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
1561         * bindings/objc/DOMXPath.mm:
1562         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
1563         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
1564         * bindings/objc/PublicDOMInterfaces.h:
1565         * bindings/scripts/CodeGeneratorObjC.pm:
1566         * dom/NodeIterator.idl:
1567         * dom/TreeWalker.idl:
1568         * html/HTMLInputElement.idl:
1569         * html/HTMLObjectElement.idl:
1570         * ksvg2/svg/SVGDocument.idl:
1571         * ksvg2/svg/SVGElement.idl:
1572         * ksvg2/svg/SVGPathSeg.idl:
1573         * ksvg2/svg/SVGPathSegArcAbs.idl:
1574         * ksvg2/svg/SVGPathSegArcRel.idl:
1575         * ksvg2/svg/SVGPathSegClosePath.idl:
1576         * ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
1577         * ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
1578         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
1579         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
1580         * ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
1581         * ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
1582         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
1583         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
1584         * ksvg2/svg/SVGPathSegLinetoAbs.idl:
1585         * ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
1586         * ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
1587         * ksvg2/svg/SVGPathSegLinetoRel.idl:
1588         * ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
1589         * ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
1590         * ksvg2/svg/SVGPathSegMovetoAbs.idl:
1591         * ksvg2/svg/SVGPathSegMovetoRel.idl:
1592
1593 2006-10-09  Don Gibson  <dgibson77@gmail.com>
1594
1595         Unreviewed build fix.
1596
1597         Fix windows build bustage.
1598
1599         * platform/win/TemporaryLinkStubs.cpp:
1600
1601 2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1602
1603         Reviewed by Geoff.
1604
1605         Fix memory leaks discovered via valgrind. Gdk build fixes.
1606
1607         * Projects/gdk/webcore-gdk.bkl:
1608         * make-generated-sources.sh:
1609         * platform/cairo/ImageCairo.cpp:
1610         (WebCore::Image::draw):
1611         * platform/gdk/FrameGdk.cpp:
1612         (WebCore::FrameGdk::handleGdkEvent):
1613         * platform/gdk/FrameGdk.h:
1614         * platform/gdk/PlatformScrollBar.h:
1615         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
1616         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
1617
1618 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
1619
1620         Reviewed by Beth.
1621
1622         Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.
1623
1624         * platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly
1625         (WebCore::GlyphMap::fillPage):
1626
1627 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
1628
1629         Unreviewed build fix.
1630
1631         Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.
1632
1633         * platform/qt/FrameQt.cpp:
1634         (WebCore::FrameQt::createJavaAppletWidget):
1635         * platform/qt/FrameQt.h:
1636         * platform/qt/TemporaryLinkStubs.cpp:
1637
1638 2006-10-09  Brady Eidson  <beidson@apple.com>
1639
1640         Reviewed by Maciej
1641
1642         Tiny changes to help reorganize WebFrameLoader code in WebKit
1643
1644         * bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
1645         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1646         (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side
1647
1648 2006-10-09  Adam Roben  <aroben@apple.com>
1649
1650         Reviewed by Adele.
1651
1652         Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
1653         already called frome ~FrameMac.
1654
1655         * page/Frame.cpp:
1656         (WebCore::Frame::~Frame):
1657
1658 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
1659
1660         * bridge/win/FrameWin.h:
1661         Add function declaration.
1662         
1663 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
1664
1665         * platform/win/TemporaryLinkStubs.cpp:
1666         (FrameWin::createJavaAppletWidget):
1667         Try fixing the Win32 build.
1668
1669 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
1670
1671         Reviewed by Adam.
1672
1673         Move applet widget creation to Frame and get rid of JavaAppletWidget.
1674         * WebCore.xcodeproj/project.pbxproj:
1675         * bridge/JavaAppletWidget.h: Removed.
1676         * bridge/mac/FrameMac.h:
1677         * bridge/mac/FrameMac.mm:
1678         (WebCore::FrameMac::createJavaAppletWidget):
1679         * bridge/mac/JavaAppletWidget.mm: Removed.
1680         * page/Frame.h:
1681         * rendering/RenderApplet.cpp:
1682         (WebCore::RenderApplet::createWidgetIfNecessary):
1683
1684 2006-10-09  Mitz Pettel  <mitz@webkit.org>
1685
1686         Reviewed by Darin.
1687
1688         - http://bugs.webkit.org/show_bug.cgi?id=11220
1689           Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276
1690
1691         Subversion does not support resource forks and HFS metadata, so
1692         the resources for this test need to be on a disk image.
1693
1694         * manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
1695         * manual-tests/resources/plain-text-paste.dmg: Added.
1696         * manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
1697         * manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
1698         * manual-tests/resources/plain-text-paste/._4.txt: Removed.
1699         * manual-tests/resources/plain-text-paste/._5.webloc: Removed.
1700         * manual-tests/resources/plain-text-paste/1.textClipping: Removed.
1701         * manual-tests/resources/plain-text-paste/2.textClipping: Removed.
1702         * manual-tests/resources/plain-text-paste/3.gif: Removed.
1703         * manual-tests/resources/plain-text-paste/4.txt: Removed.
1704         * manual-tests/resources/plain-text-paste/5.webloc: Removed.
1705
1706 2006-10-09  Rob Buis  <buis@kde.org>
1707
1708         Reviewed by Darin.
1709
1710         http://bugs.webkit.org/show_bug.cgi?id=11217
1711         Cleanup svg coding style
1712
1713         Cleanup coding style in filter classes.
1714
1715         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1716         (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
1717         (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
1718         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
1719         * ksvg2/svg/SVGFEBlendElement.cpp:
1720         (WebCore::SVGFEBlendElement::SVGFEBlendElement):
1721         (WebCore::SVGFEBlendElement::parseMappedAttribute):
1722         (WebCore::SVGFEBlendElement::filterEffect):
1723         * ksvg2/svg/SVGFEBlendElement.h:
1724         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1725         (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
1726         (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
1727         (WebCore::SVGFEColorMatrixElement::filterEffect):
1728         * ksvg2/svg/SVGFEColorMatrixElement.h:
1729         * ksvg2/svg/SVGFECompositeElement.cpp:
1730         (WebCore::SVGFECompositeElement::parseMappedAttribute):
1731         * ksvg2/svg/SVGFECompositeElement.h:
1732         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1733         (WebCore::SVGFEDisplacementMapElement::stringToChannel):
1734         * ksvg2/svg/SVGFEDisplacementMapElement.h:
1735         * ksvg2/svg/SVGFEFloodElement.cpp:
1736         (WebCore::SVGFEFloodElement::filterEffect):
1737         * ksvg2/svg/SVGFEFuncAElement.cpp:
1738         (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
1739         * ksvg2/svg/SVGFEFuncBElement.cpp:
1740         (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
1741         * ksvg2/svg/SVGFEFuncGElement.cpp:
1742         (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
1743         * ksvg2/svg/SVGFEFuncRElement.cpp:
1744         (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
1745         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1746         (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
1747         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
1748         (WebCore::SVGFEGaussianBlurElement::filterEffect):
1749         * ksvg2/svg/SVGFEGaussianBlurElement.h:
1750         * ksvg2/svg/SVGFELightElement.cpp:
1751         (WebCore::SVGFELightElement::SVGFELightElement):
1752         (WebCore::SVGFELightElement::parseMappedAttribute):
1753         * ksvg2/svg/SVGFELightElement.h:
1754         * ksvg2/svg/SVGFEMergeElement.cpp:
1755         (WebCore::SVGFEMergeElement::SVGFEMergeElement):
1756
1757 2006-10-09  Rob Buis  <buis@kde.org>
1758
1759         Reviewed by olliej.
1760
1761         http://bugs.webkit.org/show_bug.cgi?id=11217
1762         Cleanup svg coding style
1763
1764         Cleanup coding style in SVGPath* classes.
1765
1766         * ksvg2/svg/SVGPathElement.cpp:
1767         (WebCore::SVGPathElement::SVGPathElement):
1768         (WebCore::SVGPathElement::getPointAtLength):
1769         (WebCore::SVGPathElement::createSVGPathSegClosePath):
1770         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
1771         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
1772         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
1773         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
1774         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
1775         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
1776         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
1777         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
1778         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
1779         (WebCore::SVGPathElement::createSVGPathSegArcRel):
1780         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
1781         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
1782         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
1783         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
1784         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
1785         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
1786         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
1787         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
1788         (WebCore::SVGPathElement::svgMoveTo):
1789         (WebCore::SVGPathElement::svgLineTo):
1790         (WebCore::SVGPathElement::svgLineToHorizontal):
1791         (WebCore::SVGPathElement::svgLineToVertical):
1792         (WebCore::SVGPathElement::svgCurveToCubic):
1793         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
1794         (WebCore::SVGPathElement::svgCurveToQuadratic):
1795         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
1796         (WebCore::SVGPathElement::svgArcTo):
1797         (WebCore::SVGPathElement::parseMappedAttribute):
1798         (WebCore::SVGPathElement::pathSegList):
1799         (WebCore::SVGPathElement::normalizedPathSegList):
1800         (WebCore::SVGPathElement::animatedPathSegList):
1801         (WebCore::SVGPathElement::animatedNormalizedPathSegList):
1802         (WebCore::SVGPathElement::toPathData):
1803         * ksvg2/svg/SVGPathElement.h:
1804         (WebCore::SVGPathElement::rendererIsNeeded):
1805         * ksvg2/svg/SVGPathSeg.h:
1806         * ksvg2/svg/SVGPathSegArc.cpp:
1807
1808 2006-10-09  Rob Buis  <buis@kde.org>
1809
1810         Reviewed by aroben.
1811
1812         http://bugs.webkit.org/show_bug.cgi?id=11217
1813         Cleanup svg coding style
1814
1815         Cleanup coding style in svg shape classes.
1816
1817         * ksvg2/svg/SVGCircleElement.cpp:
1818         (WebCore::SVGCircleElement::SVGCircleElement):
1819         (WebCore::SVGCircleElement::parseMappedAttribute):
1820         (WebCore::SVGCircleElement::pushAttributeContext):
1821         * ksvg2/svg/SVGCircleElement.h:
1822         (WebCore::SVGCircleElement::rendererIsNeeded):
1823         * ksvg2/svg/SVGEllipseElement.cpp:
1824         * ksvg2/svg/SVGEllipseElement.h:
1825         (WebCore::SVGEllipseElement::rendererIsNeeded):
1826         * ksvg2/svg/SVGLineElement.cpp:
1827         (WebCore::SVGLineElement::parseMappedAttribute):
1828         (WebCore::SVGLineElement::pushAttributeContext):
1829         * ksvg2/svg/SVGLineElement.h:
1830         (WebCore::SVGLineElement::rendererIsNeeded):
1831         * ksvg2/svg/SVGPolyElement.cpp:
1832         (WebCore::SVGPolyElement::SVGPolyElement):
1833         (WebCore::SVGPolyElement::points):
1834         (WebCore::SVGPolyElement::animatedPoints):
1835         (WebCore::SVGPolyElement::parseMappedAttribute):
1836         (WebCore::SVGPolyElement::notifyAttributeChange):
1837         * ksvg2/svg/SVGPolyElement.h:
1838         (WebCore::SVGPolyElement::rendererIsNeeded):
1839         * ksvg2/svg/SVGPolygonElement.cpp:
1840         (WebCore::SVGPolygonElement::SVGPolygonElement):
1841         (WebCore::SVGPolygonElement::toPathData):
1842         * ksvg2/svg/SVGPolygonElement.h:
1843         * ksvg2/svg/SVGPolylineElement.cpp:
1844         (WebCore::SVGPolylineElement::SVGPolylineElement):
1845         (WebCore::SVGPolylineElement::toPathData):
1846         * ksvg2/svg/SVGPolylineElement.h:
1847         * ksvg2/svg/SVGRectElement.cpp:
1848         (WebCore::SVGRectElement::parseMappedAttribute):
1849         (WebCore::SVGRectElement::pushAttributeContext):
1850         * ksvg2/svg/SVGRectElement.h:
1851         (WebCore::SVGRectElement::rendererIsNeeded):
1852
1853 2006-10-08  Darin Adler  <darin@apple.com>
1854
1855         Reviewed by Maciej.
1856
1857         - added a bit more WebCoreSystemInterface
1858
1859             wkGetNSURLResponseCalculatedExpiration
1860             wkGetNSURLResponseLastModifiedDate
1861             wkGetNSURLResponseMustRevalidate
1862
1863         * WebCore.exp: Added the new symbols.
1864         * platform/mac/WebCoreSystemInterface.h: Ditto.
1865         * platform/mac/WebCoreSystemInterface.mm: Ditto.
1866
1867         - quiet down the code generation script
1868
1869         * bindings/scripts/CodeGenerator.pm:
1870
1871 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
1872
1873         Reviewed by Darin.
1874
1875         - more code laundering - add wkSupportsMultipartXMixedReplace
1876
1877         * WebCore.exp:
1878         * platform/mac/WebCoreSystemInterface.h:
1879         * platform/mac/WebCoreSystemInterface.mm:
1880
1881 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
1882
1883         Reviewed by Darin and Oliver.
1884
1885         Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.
1886
1887         * platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage.
1888         (WebCore::GraphicsContext::drawConvexPolygon):
1889
1890 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
1891
1892         Reviewed by Darin.
1893
1894         * page/Frame.cpp:
1895         (WebCore::Frame::submitForm):
1896         No need to use latin1() here.
1897
1898 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
1899
1900         Reviewed by Darin.
1901
1902         Kill warnings when generating IDL files on Qt/Linux, as the
1903         SOURCE_ROOT environment variable is not defined (and not needed) for us.
1904
1905         * bindings/scripts/CodeGenerator.pm:
1906
1907 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
1908
1909         Reviewed by Darin.
1910
1911         - split didNotOpenURL: into general and page-cache-specific parts
1912
1913         * bridge/mac/WebCoreFrameBridge.h:
1914         * bridge/mac/WebCoreFrameBridge.mm:
1915         (-[WebCoreFrameBridge didNotOpenURL:]):
1916         (-[WebCoreFrameBridge invalidatePageCache:]):
1917
1918 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
1919
1920         Reviewed by Darin.
1921
1922         * loader/loader.cpp:
1923         Remove DeprecatedStringList.h include.
1924         
1925         * page/Frame.cpp:
1926         (WebCore::Frame::submitForm):
1927         Don't remove "attach" from mailto URLs, we don't do it anywhere else.
1928
1929 2006-10-08  Sam Weinig  <sam.weinig@gmail.com>
1930
1931         Reviewed by Darin.
1932
1933         Patch for http://bugs.webkit.org/show_bug.cgi?id=11215
1934         Yet another round of Objective-C SVG DOM bindings auto-generation
1935
1936         - Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement, 
1937           DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent,
1938           DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement, 
1939           DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement, 
1940           DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement, 
1941           DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement, 
1942           DOMSVGZoomAndPan and DOMSVGZoomEvent.
1943
1944         - Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement
1945           using the new [ConvertFromString] property.
1946
1947         - Add forward declarations for NS* types to auto-generated classes.
1948
1949         * DerivedSources.make:
1950         * WebCore.xcodeproj/project.pbxproj:
1951         * bindings/objc/DOMHTMLAppletElement.mm: Removed.
1952         * bindings/objc/DOMHTMLEmbedElement.mm: Removed.
1953         * bindings/objc/DOMInternal.h:
1954         * bindings/objc/DOMSVG.h:
1955         * bindings/scripts/CodeGeneratorObjC.pm:
1956         * html/HTMLAppletElement.idl:
1957         * html/HTMLEmbedElement.idl:
1958         * ksvg2/svg/SVGPatternElement.idl:
1959         * ksvg2/svg/SVGPolygonElement.idl:
1960         * ksvg2/svg/SVGPolylineElement.idl:
1961         * ksvg2/svg/SVGRadialGradientElement.idl:
1962         * ksvg2/svg/SVGRenderingIntent.idl:
1963         * ksvg2/svg/SVGScriptElement.idl:
1964         * ksvg2/svg/SVGSetElement.idl:
1965         * ksvg2/svg/SVGStopElement.idl:
1966         * ksvg2/svg/SVGSwitchElement.idl:
1967         * ksvg2/svg/SVGSymbolElement.idl:
1968         * ksvg2/svg/SVGTRefElement.idl:
1969         * ksvg2/svg/SVGTSpanElement.idl:
1970         * ksvg2/svg/SVGTextContentElement.idl:
1971         * ksvg2/svg/SVGTextElement.idl:
1972         * ksvg2/svg/SVGTextPositioningElement.idl:
1973         * ksvg2/svg/SVGTitleElement.idl:
1974         * ksvg2/svg/SVGUseElement.idl:
1975         * ksvg2/svg/SVGViewElement.idl:
1976         * ksvg2/svg/SVGZoomEvent.idl:
1977
1978 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
1979
1980         Reviewed by Maciej.
1981
1982         Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.        
1983         * loader/loader.cpp:
1984         (WebCore::Loader::servePendingRequests):
1985         
1986 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
1987
1988         Reviewed by Darin.
1989
1990         Convert a bunch of RefPtr<StringImpl> to String.
1991         
1992         * bridge/mac/FrameMac.h:
1993         * bridge/mac/FrameMac.mm:
1994         (WebCore::FrameMac::didTellBridgeAboutLoad):
1995         (WebCore::FrameMac::haveToldBridgeAboutLoad):
1996         * dom/BeforeUnloadEvent.cpp:
1997         (WebCore::BeforeUnloadEvent::storeResult):
1998         * dom/BeforeUnloadEvent.h:
1999         (WebCore::BeforeUnloadEvent::result):
2000         * dom/Document.cpp:
2001         (WebCore::Document::createEntityReference):
2002         * dom/Entity.cpp:
2003         (WebCore::Entity::Entity):
2004         (WebCore::Entity::nodeName):
2005         (WebCore::Entity::toString):
2006         * dom/Entity.h:
2007         (WebCore::Entity::publicId):
2008         (WebCore::Entity::systemId):
2009         (WebCore::Entity::notationName):
2010         * dom/EntityReference.cpp:
2011         (WebCore::EntityReference::EntityReference):
2012         (WebCore::EntityReference::nodeName):
2013         (WebCore::EntityReference::cloneNode):
2014         (WebCore::EntityReference::toString):
2015         * dom/EntityReference.h:
2016         * dom/KeyboardEvent.cpp:
2017         (WebCore::KeyboardEvent::KeyboardEvent):
2018         (WebCore::KeyboardEvent::initKeyboardEvent):
2019         * dom/KeyboardEvent.h:
2020         (WebCore::KeyboardEvent::keyIdentifier):
2021         * dom/MutationEvent.cpp:
2022         (WebCore::MutationEvent::MutationEvent):
2023         (WebCore::MutationEvent::initMutationEvent):
2024         * dom/MutationEvent.h:
2025         (WebCore::MutationEvent::prevValue):
2026         (WebCore::MutationEvent::newValue):
2027         (WebCore::MutationEvent::attrName):
2028         * dom/Notation.cpp:
2029         (WebCore::Notation::Notation):
2030         (WebCore::Notation::nodeName):
2031         * dom/Notation.h:
2032         (WebCore::Notation::publicId):
2033         (WebCore::Notation::systemId):
2034         * dom/ProcessingInstruction.cpp:
2035         (WebCore::ProcessingInstruction::ProcessingInstruction):
2036         (WebCore::ProcessingInstruction::setData):
2037         (WebCore::ProcessingInstruction::nodeName):
2038         (WebCore::ProcessingInstruction::nodeValue):
2039         (WebCore::ProcessingInstruction::cloneNode):
2040         (WebCore::ProcessingInstruction::checkStyleSheet):
2041         (WebCore::ProcessingInstruction::toString):
2042         * dom/ProcessingInstruction.h:
2043         (WebCore::ProcessingInstruction::target):
2044         (WebCore::ProcessingInstruction::data):
2045         (WebCore::ProcessingInstruction::localHref):
2046
2047 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
2048
2049         Reviewed by Tim H.
2050
2051         Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
2052         10 more SVG Objective-C auto-generated bindings
2053
2054         - Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, 
2055           DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement,
2056           DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, 
2057           DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
2058
2059         - Auto-generate the text method for DOMRange.
2060
2061         * DerivedSources.make:
2062         * WebCore.xcodeproj/project.pbxproj:
2063         * bindings/objc/DOM.mm:
2064         * bindings/objc/DOMExtensions.h:
2065         * bindings/objc/DOMInternal.h:
2066         * bindings/objc/DOMPrivate.h:
2067         * bindings/objc/DOMRGBColor.mm:
2068         * bindings/objc/DOMSVG.h:
2069         * bindings/objc/PublicDOMInterfaces.h:
2070         * bindings/scripts/CodeGeneratorObjC.pm:
2071         * dom/Range.idl:
2072         * ksvg2/svg/SVGFilterElement.cpp:
2073         * ksvg2/svg/SVGFilterElement.h:
2074         * ksvg2/svg/SVGFilterElement.idl:
2075         * ksvg2/svg/SVGForeignObjectElement.idl:
2076         * ksvg2/svg/SVGGElement.idl:
2077         * ksvg2/svg/SVGGradientElement.idl:
2078         * ksvg2/svg/SVGImageElement.idl:
2079         * ksvg2/svg/SVGLineElement.idl:
2080         * ksvg2/svg/SVGLinearGradientElement.idl:
2081         * ksvg2/svg/SVGMarkerElement.idl:
2082         * ksvg2/svg/SVGMaskElement.idl:
2083         * ksvg2/svg/SVGPaint.idl:
2084
2085 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
2086
2087         Reviewed by Tim H.
2088
2089         Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
2090         Auto-generate a few more Objective-C DOM interfaces
2091
2092         - Fully auto-generate DOMAbstractView and DOMRange.
2093
2094         - Auto-generate just the interface for DOMRGBColor.
2095
2096         - Add DOMRanges.h as the new top level file for Ranges
2097           module.
2098
2099         - Add DOMRanges.h and DOMXPath.h to DOM.mm
2100
2101         * DerivedSources.make:
2102         * WebCore.xcodeproj/project.pbxproj:
2103         * bindings/objc/DOM.h:
2104         * bindings/objc/DOM.mm:
2105         * bindings/objc/DOMAbstractView.h: Removed.
2106         * bindings/objc/DOMAbstractView.mm: Removed.
2107         * bindings/objc/DOMInternal.h:
2108         * bindings/objc/DOMPrivate.h:
2109         * bindings/objc/DOMRGBColor.h: Removed.
2110         * bindings/objc/DOMRGBColor.mm:
2111         * bindings/objc/DOMRange.h: Removed.
2112         * bindings/objc/DOMRanges.h: Added.
2113         * bindings/objc/PublicDOMInterfaces.h:
2114         * bindings/scripts/CodeGeneratorObjC.pm:
2115         * css/RGBColor.idl:
2116         * dom/Range.idl:
2117         * page/AbstractView.idl: Added.
2118
2119 2006-10-07  Andrew Wellington  <proton@wiretapped.net>
2120
2121         Reviewed by Eric.
2122
2123         Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
2124         http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
2125
2126         Return null when there is no frame. This matches Firefox.
2127
2128         * bindings/js/kjs_html.cpp:
2129         (KJS::JSHTMLDocument::getValueProperty):
2130
2131 2006-10-07  David Hyatt  <hyatt@apple.com>
2132
2133         Implement scroll corner painting (a white rect fill) for overflow areas to cover up
2134         scrollbar joins properly.
2135
2136         Refactor painting of scrollbars and resizers into common functions.  Eliminate the
2137         extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
2138
2139         Reviewed by mitz
2140
2141         * page/FrameView.cpp:
2142         (WebCore::selectCursor):
2143         (WebCore::FrameView::handleMouseMoveEvent):
2144         * platform/mac/PlatformScrollBar.h:
2145         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
2146         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
2147         * rendering/RenderLayer.cpp:
2148         (WebCore::RenderLayer::RenderLayer):
2149         (WebCore::RenderLayer::~RenderLayer):
2150         (WebCore::RenderLayer::updateLayerPositions):
2151         (WebCore::scrollCornerRect):
2152         (WebCore::RenderLayer::positionOverflowControls):
2153         (WebCore::RenderLayer::paintOverflowControls):
2154         (WebCore::RenderLayer::isPointInResizeControl):
2155         (WebCore::RenderLayer::paintLayer):
2156         * rendering/RenderLayer.h:
2157
2158 2006-10-07  Mark Rowe  <bdash@webkit.org>
2159
2160         Reviewed by Mitz.
2161
2162         Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
2163         matching recent ResourceLoader changes.
2164
2165         * platform/gdk/FrameGdk.cpp:
2166         (WebCore::FrameGdk::openURL):
2167         (WebCore::FrameGdk::urlSelected):
2168         * platform/gdk/PlatformScrollBar.h:
2169         * platform/gdk/ResourceLoaderCurl.cpp:
2170         (WebCore::ResourceLoader::start):
2171         * platform/gdk/ScrollViewGdk.cpp:
2172         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
2173         (WebCore::ScrollView::resizeContents):
2174         (WebCore::ScrollView::scrollBy):
2175         (WebCore::ScrollView::hScrollbarMode):
2176         (WebCore::ScrollView::vScrollbarMode):
2177         (WebCore::ScrollView::suppressScrollbars):
2178         (WebCore::ScrollView::setHScrollbarMode):
2179         (WebCore::ScrollView::setVScrollbarMode):
2180         (WebCore::ScrollView::setScrollbarsMode):
2181         * platform/gdk/TemporaryLinkStubs.cpp:
2182         (FrameView::passMousePressEventToScrollbar):
2183         (Widget::removeFromParent):
2184         (ScrollView::addChild):
2185         (ScrollView::updateScrollbars):
2186         (ScrollView::scrollbarUnderMouse):
2187         (PlatformScrollbar::PlatformScrollbar):
2188         (PlatformScrollbar::~PlatformScrollbar):
2189         (PlatformScrollbar::width):
2190         (PlatformScrollbar::height):
2191         (PlatformScrollbar::setEnabled):
2192         (PlatformScrollbar::paint):
2193         (PlatformScrollbar::updateThumbPosition):
2194         (PlatformScrollbar::updateThumbProportion):
2195         (PlatformScrollbar::setRect):
2196         (Scrollbar::Scrollbar):
2197         (Scrollbar::setSteps):
2198         (Scrollbar::scroll):
2199         (Scrollbar::setValue):
2200         (Scrollbar::setProportion):
2201
2202 2006-10-06  Dave Hyatt  <hyatt@apple.com>
2203
2204         Implement a new method for obtaining accurate clip rectangles that can be used by plugins to properly clip.
2205
2206         * page/FrameView.cpp:
2207         (WebCore::FrameView::windowClipRect):
2208         * page/FrameView.h:
2209         * platform/ScrollView.h:
2210         * platform/Widget.cpp:
2211         (WebCore::Widget::windowClipRect):
2212         * platform/Widget.h:
2213         (WebCore::Widget::geometryChanged):
2214         (WebCore::Widget::handleMouseMoveEvent):
2215         (WebCore::Widget::handleMouseReleaseEvent):
2216         * platform/mac/ScrollViewMac.mm:
2217         (WebCore::ScrollView::addChild):
2218         * rendering/RenderLayer.cpp:
2219         (WebCore::RenderLayer::documentClipRect):
2220         * rendering/RenderLayer.h:
2221
2222 2006-10-06  Steve Falkenburg  <sfalken@apple.com>
2223
2224         Reviewed by Adam.
2225
2226         Add another method we'll need for scrollbar dodging
2227
2228         * platform/ScrollView.h:
2229         * platform/win/TemporaryLinkStubs.cpp:
2230         (ScrollView::resizerOverlapsContent):
2231
2232 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
2233
2234         Reviewed by Tim H.
2235
2236         Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
2237         Auto-generate the interfaces even for Objective-C DOM 
2238         bindings that need custom implementations
2239
2240         - Fully auto-generate DOMEventTarget, DOMNodeFilter and 
2241           DOMHTMLOptionElement.
2242
2243         - Auto-generate just the interface for DOMHTMLAppletElement,
2244           DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect
2245           using the new IDL property ObjCCustomImplementation.
2246
2247         * DerivedSources.make:
2248         * WebCore.xcodeproj/project.pbxproj:
2249         * bindings/objc/DOMEventTarget.h: Removed.
2250         * bindings/objc/DOMHTMLAppletElement.h: Removed.
2251         * bindings/objc/DOMHTMLEmbedElement.h: Removed.
2252         * bindings/objc/DOMHTMLOptionElement.h: Removed.
2253         * bindings/objc/DOMHTMLOptionElement.mm: Removed.
2254         * bindings/objc/DOMInternal.h:
2255         * bindings/objc/DOMNodeFilter.h: Removed.
2256         * bindings/objc/DOMSVGNumber.h: Removed.
2257         * bindings/objc/DOMSVGPoint.h: Removed.
2258         * bindings/objc/DOMSVGPoint.mm:
2259         (-[DOMSVGPoint matrixTransform:]):
2260         * bindings/objc/DOMSVGRect.h: Removed.
2261         * bindings/objc/PublicDOMInterfaces.h:
2262         * bindings/scripts/CodeGeneratorObjC.pm:
2263         * dom/EventTarget.idl:
2264         * html/HTMLAppletElement.idl:
2265         * html/HTMLEmbedElement.idl:
2266         * html/HTMLOptionElement.idl:
2267         * ksvg2/svg/SVGNumber.idl:
2268         * ksvg2/svg/SVGPoint.idl:
2269         * ksvg2/svg/SVGRect.idl:
2270
2271 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
2272
2273         Reviewed by Tim H.
2274
2275         Make Qt/Linux compile again completly.
2276
2277         * platform/qt/WidgetQt.cpp:
2278         (WebCore::Widget::removeFromParent):
2279
2280 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
2281
2282         Reviewed by Tim H.
2283
2284         Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.
2285
2286         * platform/qt/PlatformScrollBar.h:
2287         * platform/qt/ScrollViewQt.cpp:
2288         (WebCore::ScrollView::hScrollbarMode):
2289         (WebCore::ScrollView::vScrollbarMode):
2290         (WebCore::ScrollView::suppressScrollbars):
2291         (WebCore::ScrollView::setHScrollbarMode):
2292         (WebCore::ScrollView::setVScrollbarMode):
2293         (WebCore::ScrollView::setScrollbarsMode):
2294         (WebCore::ScrollView::scrollbarUnderMouse):
2295         * platform/qt/TemporaryLinkStubs.cpp:
2296         (WebCore::Scrollbar::Scrollbar):
2297         (WebCore::Scrollbar::setSteps):
2298         (WebCore::Scrollbar::scroll):
2299         (WebCore::Scrollbar::setValue):
2300         (WebCore::Scrollbar::setProportion):
2301         (WebCore::PlatformScrollbar::PlatformScrollbar):
2302         (WebCore::PlatformScrollbar::~PlatformScrollbar):
2303         (WebCore::PlatformScrollbar::width):
2304         (WebCore::PlatformScrollbar::height):
2305         (WebCore::PlatformScrollbar::setEnabled):
2306         (WebCore::PlatformScrollbar::paint):
2307         (WebCore::PlatformScrollbar::updateThumbPosition):
2308         (WebCore::PlatformScrollbar::updateThumbProportion):
2309         (WebCore::PlatformScrollbar::setRect):
2310         (FrameView::passMousePressEventToScrollbar):
2311
2312 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
2313
2314         Reviewed by Tim H.
2315
2316         Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
2317         Another round of Objective-C SVG DOM bindings auto-generation
2318
2319         - Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect, 
2320           DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement, 
2321           DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement, 
2322           DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement,
2323           DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement, 
2324           DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement, 
2325           DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement, 
2326           DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement, 
2327           DOMSVGFEOffsetElement, DOMSVGFEPointLightElement, 
2328           DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement, 
2329           DOMSVGFETileElement, DOMSVGFETurbulenceElement, 
2330           DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList. 
2331
2332         - Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint
2333           and DOMSVGRect.
2334
2335         - IDL clean up.
2336
2337         - Make numOctaves in SVGFETurbulenceElement use a long instead of an int
2338           in it's macro declaration and definition.
2339
2340         * DerivedSources.make:
2341         * WebCore.xcodeproj/project.pbxproj:
2342         * bindings/objc/DOMCSS.mm:
2343         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2344         * bindings/objc/DOMInternal.h:
2345         * bindings/objc/DOMSVG.h:
2346         * bindings/objc/DOMSVGNumber.h: Added.
2347         * bindings/objc/DOMSVGNumber.mm: Added.
2348         (-[DOMSVGNumber dealloc]):
2349         (-[DOMSVGNumber finalize]):
2350         (-[DOMSVGNumber value]):
2351         (-[DOMSVGNumber setValue:]):
2352         (-[DOMSVGNumber _SVGNumber]):
2353         (-[DOMSVGNumber _initWithFloat:]):
2354         (+[DOMSVGNumber _SVGNumberWith:]):
2355         * bindings/objc/DOMSVGPoint.h: Added.
2356         * bindings/objc/DOMSVGPoint.mm: Added.
2357         (-[DOMSVGPoint dealloc]):
2358         (-[DOMSVGPoint finalize]):
2359         (-[DOMSVGPoint x]):
2360         (-[DOMSVGPoint setX:]):
2361         (-[DOMSVGPoint y]):
2362         (-[DOMSVGPoint setY:]):
2363         (-[DOMSVGPoint WebCore::]):
2364         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
2365         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
2366         * bindings/objc/DOMSVGRect.h: Added.
2367         * bindings/objc/DOMSVGRect.mm: Added.
2368         (-[DOMSVGRect dealloc]):
2369         (-[DOMSVGRect finalize]):
2370         (-[DOMSVGRect x]):
2371         (-[DOMSVGRect setX:]):
2372         (-[DOMSVGRect y]):
2373         (-[DOMSVGRect setY:]):
2374         (-[DOMSVGRect width]):
2375         (-[DOMSVGRect setWidth:]):
2376         (-[DOMSVGRect height]):
2377         (-[DOMSVGRect setHeight:]):
2378         (-[DOMSVGRect WebCore::]):
2379         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
2380         (+[DOMSVGRect _SVGRectWith:WebCore::]):
2381         * bindings/scripts/CodeGeneratorObjC.pm:
2382         * ksvg2/svg/SVGAnimatedNumberList.idl:
2383         * ksvg2/svg/SVGAnimatedRect.idl:
2384         * ksvg2/svg/SVGComponentTransferFunctionElement.idl:
2385         * ksvg2/svg/SVGCursorElement.idl:
2386         * ksvg2/svg/SVGFEBlendElement.idl:
2387         * ksvg2/svg/SVGFEColorMatrixElement.idl:
2388         * ksvg2/svg/SVGFEComponentTransferElement.idl:
2389         * ksvg2/svg/SVGFECompositeElement.idl:
2390         * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
2391         * ksvg2/svg/SVGFEDisplacementMapElement.idl:
2392         * ksvg2/svg/SVGFEDistantLightElement.idl:
2393         * ksvg2/svg/SVGFEFloodElement.idl:
2394         * ksvg2/svg/SVGFEFuncAElement.idl:
2395         * ksvg2/svg/SVGFEFuncBElement.idl:
2396         * ksvg2/svg/SVGFEFuncGElement.idl:
2397         * ksvg2/svg/SVGFEFuncRElement.idl:
2398         * ksvg2/svg/SVGFEGaussianBlurElement.idl:
2399         * ksvg2/svg/SVGFEImageElement.idl:
2400         * ksvg2/svg/SVGFEMergeElement.idl:
2401         * ksvg2/svg/SVGFEMergeNodeElement.idl:
2402         * ksvg2/svg/SVGFEOffsetElement.idl:
2403         * ksvg2/svg/SVGFEPointLightElement.idl:
2404         * ksvg2/svg/SVGFESpecularLightingElement.idl:
2405         * ksvg2/svg/SVGFESpotLightElement.idl:
2406         * ksvg2/svg/SVGFETileElement.idl:
2407         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2408         * ksvg2/svg/SVGFETurbulenceElement.h:
2409         * ksvg2/svg/SVGFETurbulenceElement.idl:
2410         * ksvg2/svg/SVGNumberList.idl:
2411
2412 2006-10-06  Adam Roben  <aroben@apple.com>
2413
2414         Backing out my previous change.
2415
2416         * WebCore.xcodeproj/project.pbxproj:
2417         * page/FrameView.cpp:
2418         (WebCore::FrameView::adjustViewSize):
2419
2420 2006-10-06  Adam Roben  <aroben@apple.com>
2421
2422         Build fix.
2423
2424         * WebCore.xcodeproj/project.pbxproj:
2425         * page/FrameView.cpp:
2426         (WebCore::FrameView::windowResizerRect):
2427
2428 2006-10-06  Adam Roben  <aroben@apple.com>
2429
2430         Reviewed by Maciej.
2431
2432         More loader tweaks.
2433
2434         * platform/ResourceLoader.h:
2435         * platform/ResourceLoaderInternal.h:
2436         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2437         * platform/win/TemporaryLinkStubs.cpp:
2438         (WebCore::ResourceLoader::newHTTPRequest):
2439
2440 2006-10-05  Steve Falkenburg  <sfalken@apple.com>
2441
2442         Reviewed by aroben.
2443
2444         Stub out some methods that we'll be able to use to dodge a window resizer.
2445
2446         * bridge/win/FrameWin.h:
2447         * page/Frame.h:
2448         (WebCore::Frame::windowResizerRect):
2449         * page/FrameView.h:
2450         * platform/ScrollView.h:
2451         (WebCore::ScrollView::windowResizerRect):
2452         * platform/Widget.h:
2453         * platform/win/TemporaryLinkStubs.cpp:
2454         (FrameView::windowResizerRect):
2455         (Widget::setParent):
2456         (Widget::parent):
2457         (FrameWin::windowResizerRect):
2458
2459 2006-10-05  Dave Hyatt  <hyatt@apple.com>
2460
2461         Stub out setFrameGeometry.
2462         
2463         * platform/ScrollView.h:
2464
2465 2006-10-05  Adele Peterson  <adele@apple.com>
2466
2467         Reverting autoscroll fix.  I need to rework this a little.
2468
2469         * page/Frame.cpp:
2470         (WebCore::Frame::handleAutoscroll):
2471         (WebCore::Frame::autoscrollTimerFired):
2472         (WebCore::Frame::stopAutoscrollTimer):
2473         * page/Frame.h:
2474         * rendering/RenderLayer.cpp:
2475         (WebCore::RenderLayer::~RenderLayer):
2476         * rendering/RenderListBox.cpp:
2477         (WebCore::RenderListBox::~RenderListBox):
2478
2479 2006-10-05  Alice  <alice.liu@apple.com>
2480
2481         Reviewed by Adam.
2482
2483         Fixed <rdar://problem/4731778>
2484
2485         * editing/CommandByName.cpp:
2486         (WebCore::Frame::Command::):
2487         was calling the wrong enabledFn for arrow selection and navigation
2488
2489 2006-10-05  Adele Peterson  <adele@apple.com>
2490
2491         Reviewed by Maciej.
2492
2493         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text">
2494           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
2495
2496         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
2497         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
2498
2499         * page/Frame.cpp: Added getter and setter for the renderer being autoscrolled.
2500         (WebCore::Frame::handleAutoscroll):
2501         (WebCore::Frame::autoscrollTimerFired):
2502         (WebCore::Frame::autoscrollRenderer):
2503         (WebCore::Frame::setAutoscrollRenderer):
2504         (WebCore::Frame::stopAutoscrollTimer):
2505         * page/Frame.h:
2506
2507 2006-10-05  Don Gibson  <dgibson77@gmail.com>
2508
2509         Reviewed by Eric.
2510
2511         Fix win32 build bustage after ggaren's Scrollbar renaming changes.
2512         Properly include PlatformScrollBar.h in WbCore.vcproj.
2513         Clean up WidgetWin.cpp a bit.
2514
2515         * WebCore.vcproj/WebCore/WebCore.vcproj:
2516         * platform/Widget.h:
2517         * platform/win/PlatformScrollBar.h:
2518         * platform/win/ScrollViewWin.cpp:
2519         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
2520         (WebCore::ScrollView::resizeContents):
2521         (WebCore::ScrollView::scrollBy):
2522         (WebCore::ScrollView::hScrollbarMode):
2523         (WebCore::ScrollView::vScrollbarMode):
2524         (WebCore::ScrollView::suppressScrollbars):
2525         (WebCore::ScrollView::setHScrollbarMode):
2526         (WebCore::ScrollView::setVScrollbarMode):
2527         (WebCore::ScrollView::setScrollbarsMode):
2528         (WebCore::ScrollView::updateScrollbars):
2529         * platform/win/TemporaryLinkStubs.cpp:
2530         (FrameView::passMousePressEventToScrollbar):
2531         (Widget::removeFromParent):
2532         (ScrollView::scrollbarUnderMouse):
2533         (PlatformScrollbar::PlatformScrollbar):
2534         (PlatformScrollbar::~PlatformScrollbar):
2535         (PlatformScrollbar::width):
2536         (PlatformScrollbar::height):
2537         (PlatformScrollbar::setEnabled):
2538         (PlatformScrollbar::paint):
2539         (PlatformScrollbar::updateThumbPosition):
2540         (PlatformScrollbar::updateThumbProportion):
2541         (PlatformScrollbar::setRect):
2542         (Scrollbar::Scrollbar):
2543         (Scrollbar::setSteps):
2544         (Scrollbar::scroll):
2545         (Scrollbar::setValue):
2546         (Scrollbar::setProportion):
2547         * platform/win/WidgetWin.cpp:
2548         (WebCore::WidgetPrivate::WidgetPrivate):
2549         (WebCore::Widget::Widget):
2550         (WebCore::Widget::setContainingWindow):
2551         (WebCore::Widget::containingWindow):
2552
2553 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
2554
2555         build fix.
2556         
2557         * WebCore.xcodeproj/project.pbxproj:
2558         * bridge/mac/BrowserExtensionMac.mm:
2559         (WebCore::BrowserExtensionMac::createNewWindow):
2560         * bridge/mac/FrameMac.mm:
2561         (WebCore::FrameMac::createFrame):
2562         * bridge/mac/FrameViewMac.mm:
2563         (WebCore::FrameView::passMousePressEventToScrollbar):
2564         * bridge/mac/WebCoreFrameBridge.mm:
2565         (-[WebCoreFrameBridge installInFrame:]):
2566         * bridge/mac/WebCoreFrameView.h:
2567         * platform/ScrollBar.cpp:
2568         * platform/Widget.h:
2569         * platform/mac/PlatformScrollBar.h:
2570         * platform/mac/PlatformScrollBarMac.mm:
2571         (NSControlSizeForScrollBarControlSize):
2572         (-[WebCoreScrollBar initWithPlatformScrollbar:]):
2573         (-[WebCoreScrollBar detachPlatformScrollbar]):
2574         (-[WebCoreScrollBar scroll:]):
2575         (-[WebCoreScrollBar widget]):
2576         (WebCore::PlatformScrollbar::PlatformScrollbar):
2577         (WebCore::PlatformScrollbar::~PlatformScrollbar):
2578         (WebCore::PlatformScrollbar::updateThumbPosition):
2579         (WebCore::PlatformScrollbar::updateThumbProportion):
2580         (WebCore::PlatformScrollbar::scrollbarHit):
2581         (WebCore::PlatformScrollbar::width):
2582         (WebCore::PlatformScrollbar::height):
2583         (WebCore::PlatformScrollbar::setRect):
2584         (WebCore::PlatformScrollbar::setEnabled):
2585         (WebCore::PlatformScrollbar::paint):
2586         * platform/mac/ScrollViewMac.mm:
2587         (WebCore::ScrollView::setVScrollbarMode):
2588         (WebCore::ScrollView::setHScrollbarMode):
2589         (WebCore::ScrollView::setScrollbarsMode):
2590         (WebCore::ScrollView::vScrollbarMode):
2591         (WebCore::ScrollView::hScrollbarMode):
2592         (WebCore::ScrollView::suppressScrollbars):
2593         (WebCore::ScrollView::scrollbarUnderMouse):
2594         * platform/mac/WidgetMac.mm:
2595         (WebCore::Widget::removeFromParent):
2596         * rendering/RenderLayer.cpp:
2597         (WebCore::RenderLayer::destroyScrollbar):
2598
2599 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
2600
2601         build fix.
2602         
2603         * platform/Widget.h:
2604         * rendering/RenderLayer.cpp:
2605         (WebCore::RenderLayer::destroyScrollbar):
2606
2607 2006-10-06  Mitz Pettel  <mitz@webkit.org>
2608
2609         http://bugs.webkit.org/show_bug.cgi?id=8276
2610         Fix broken manual test added back in r13990.
2611
2612         Add resource forks for test resources.
2613
2614         * manual-tests/resources/plain-text-paste/._1.textClipping: Added.
2615         * manual-tests/resources/plain-text-paste/._2.textClipping: Added.
2616         * manual-tests/resources/plain-text-paste/._4.txt: Added.
2617         * manual-tests/resources/plain-text-paste/._5.webloc: Added.
2618
2619 2006-10-05  David Hyatt  <hyatt@apple.com>
2620
2621         Rename addClip to clip.
2622
2623         Reviewed by darin
2624
2625         * kcanvas/RenderForeignObject.cpp:
2626         (WebCore::RenderForeignObject::paint):
2627         * kcanvas/RenderSVGContainer.cpp:
2628         (WebCore::RenderSVGContainer::paint):
2629         * kcanvas/RenderSVGImage.cpp:
2630         (WebCore::RenderSVGImage::paint):
2631         * platform/GraphicsContext.h:
2632         * platform/cairo/GraphicsContextCairo.cpp:
2633         (WebCore::GraphicsContext::clip):
2634         * platform/cg/GraphicsContextCG.cpp:
2635         (WebCore::GraphicsContext::savePlatformState):
2636         (WebCore::GraphicsContext::restorePlatformState):
2637         (WebCore::GraphicsContext::clip):
2638         (WebCore::GraphicsContext::addRoundedRectClip):
2639         (WebCore::GraphicsContext::addInnerRoundedRectClip):
2640         (WebCore::GraphicsContext::scale):
2641         (WebCore::GraphicsContext::rotate):
2642         (WebCore::GraphicsContext::translate):
2643         (WebCore::GraphicsContext::concatCTM):
2644         * platform/cg/GraphicsContextPlatformPrivate.h:
2645         (WebCore::GraphicsContextPlatformPrivate::save):
2646         (WebCore::GraphicsContextPlatformPrivate::restore):
2647         (WebCore::GraphicsContextPlatformPrivate::clip):
2648         (WebCore::GraphicsContextPlatformPrivate::scale):
2649         (WebCore::GraphicsContextPlatformPrivate::rotate):
2650         (WebCore::GraphicsContextPlatformPrivate::translate):
2651         (WebCore::GraphicsContextPlatformPrivate::concatCTM):
2652         * platform/qt/GraphicsContextQt.cpp:
2653         (WebCore::GraphicsContext::clip):
2654         (WebCore::GraphicsContext::addInnerRoundedRectClip):
2655         (WebCore::GraphicsContext::addRoundedRectClip):
2656         * rendering/InlineFlowBox.cpp:
2657         (WebCore::InlineFlowBox::paintBackground):
2658         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
2659         * rendering/InlineTextBox.cpp:
2660         (WebCore::InlineTextBox::paintSelection):
2661         (WebCore::InlineTextBox::paintTextMatchMarker):
2662         * rendering/RenderBox.cpp:
2663         (WebCore::RenderBox::paintBackgroundExtended):
2664         * rendering/RenderButton.cpp:
2665         (WebCore::RenderButton::paintObject):
2666         * rendering/RenderFileUploadControl.cpp:
2667         (WebCore::RenderFileUploadControl::paintObject):
2668         * rendering/RenderLayer.cpp:
2669         (WebCore::RenderLayer::beginTransparencyLayers):
2670         (WebCore::setClip):
2671         * rendering/RenderListBox.cpp:
2672         (WebCore::RenderListBox::paintObject):
2673         * rendering/RenderMenuList.cpp:
2674         (WebCore::RenderMenuList::paintObject):
2675         * rendering/RenderTableCell.cpp:
2676         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
2677
2678 2006-10-05  Mitz Pettel  <mitz@webkit.org>
2679
2680         Reviewed by Darin.
2681
2682         - http://bugs.webkit.org/show_bug.cgi?id=10386
2683           Delete RenderImageButton.* and remove references from .vcproj and .bkl files
2684
2685         * CMakeLists.txt:
2686         * WebCore.vcproj/WebCore/WebCore.vcproj:
2687         * WebCoreSources.bkl:
2688         * rendering/RenderImageButton.cpp: Removed.
2689         * rendering/RenderImageButton.h: Removed.
2690
2691 2006-10-05  Mitz Pettel  <opendarwin.org@mitzpettel.com>
2692
2693         Reviewed by Darin.
2694
2695         - http://bugs.webkit.org/show_bug.cgi?id=11067
2696           manual-tests/scrollbar-hittest2.html is invalid
2697
2698         * manual-tests/scrollbar-hittest2.html:
2699
2700 2006-10-05  David Carson  <dacarson@gmail.com>
2701
2702         Reviewed by Darin.
2703
2704         http://bugs.webkit.org/show_bug.cgi?id=11152
2705         Adjust the tokenizer chunk size to be smaller for
2706         mobile devices, and also decrease the yield timer
2707         for the tokenizer so that it can resume earlier.
2708
2709         * html/HTMLTokenizer.cpp:
2710         * config.h:
2711
2712 2006-10-05  Adam Roben  <aroben@apple.com>
2713
2714         Removing accidentally-checked-in do-nothing code.
2715
2716         * html/HTMLInputElement.cpp:
2717         (WebCore::HTMLInputElement::defaultEventHandler):
2718
2719 2006-10-05  David Carson  <dacarson@gmail.com>
2720
2721         Reviewed by Mitz.
2722
2723         http://bugs.webkit.org/show_bug.cgi?id=11158
2724         Initialize class variables
2725
2726         * rendering/RenderLayer.cpp:
2727         (WebCore::RenderLayer::RenderLayer):
2728
2729 2006-10-05  Don Gibson  <dgibson77@gmail.com>
2730
2731         Reviewed by Darin, landed by Adam.
2732
2733         http://bugs.webkit.org/show_bug.cgi?id=11176
2734         Fix win32 build, adapt to Maciej's ResourceLoader changes.
2735
2736         * platform/win/ResourceLoaderWin.cpp:
2737         (WebCore::ResourceLoader::start):
2738
2739 2006-10-05  Marvin Decker  <marv.decker@gmail.com>
2740
2741         Reviewed by Darin.
2742
2743         http://bugs.webkit.org/show_bug.cgi?id=10989
2744         Provide a way for embedders to implement BrowserExtensionWin
2745
2746         * WebCore.vcproj/WebCore/WebCore.vcproj:
2747         * bridge/win/BrowserExtensionWin.cpp: Added.
2748         (BrowserExtensionWin::BrowserExtensionWin):
2749         (BrowserExtensionWin::setTypedIconURL):
2750         (BrowserExtensionWin::setIconURL):
2751         (BrowserExtensionWin::getHistoryLength):
2752         (BrowserExtensionWin::canRunModal):
2753         (BrowserExtensionWin::createNewWindow):
2754         (BrowserExtensionWin::canRunModalNow):
2755         (BrowserExtensionWin::runModal):
2756         (BrowserExtensionWin::goBackOrForward):
2757         (BrowserExtensionWin::historyURL):
2758         * bridge/win/BrowserExtensionWin.h:
2759         * bridge/win/FrameWin.cpp:
2760         (WebCore::FrameWin::createNewWindow):
2761         * bridge/win/FrameWin.h:
2762         * platform/win/TemporaryLinkStubs.cpp:
2763
2764 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
2765
2766         Reviewed by Darin.
2767         
2768         Fixed <rdar://problem/4766987>
2769         
2770         - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
2771         except for file names.
2772         
2773         - fixed RenderLayer to properly tear down scrollbars, removing them from
2774         their parents.
2775
2776         * bindings/js/kjs_window.cpp:
2777         (KJS::showModalDialog):
2778         (KJS::setWindowFeature):
2779         (KJS::parseWindowFeatures):
2780         * bridge/BrowserExtension.h:
2781         * dom/Document.cpp:
2782         (WebCore::Document::setInPageCache):
2783         * html/HTMLFrameElement.cpp:
2784         (WebCore::HTMLFrameElement::init):
2785         (WebCore::HTMLFrameElement::parseMappedAttribute):
2786         * html/HTMLFrameElement.h:
2787         (WebCore::HTMLFrameElement::scrollingMode):
2788         * page/Frame.cpp:
2789         (WebCore::Frame::finishedParsing):
2790         (WebCore::Frame::scrollbarsVisible):
2791         * page/FrameView.cpp:
2792         (WebCore::FrameViewPrivate::FrameViewPrivate):
2793         (WebCore::FrameViewPrivate::reset):
2794         (WebCore::FrameView::~FrameView):
2795         (WebCore::FrameView::resetScrollbars):
2796         (WebCore::FrameView::clear):
2797         (WebCore::FrameView::initScrollbars):
2798         (WebCore::FrameView::applyOverflowToViewport):
2799         (WebCore::FrameView::layout):
2800         (WebCore::FrameView::handleMousePressEvent):
2801         (WebCore::selectCursor):
2802         (WebCore::FrameView::handleMouseMoveEvent):
2803         (WebCore::FrameView::setScrollbarsMode):
2804         (WebCore::FrameView::setVScrollbarMode):
2805         (WebCore::FrameView::setHScrollbarMode):
2806         (WebCore::FrameView::restoreScrollbar):
2807         (WebCore::FrameView::dispatchMouseEvent):
2808         (WebCore::FrameView::scrollbarMoved):
2809         * page/FrameView.h:
2810         * page/MouseEventWithHitTestResults.cpp:
2811         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2812         * page/MouseEventWithHitTestResults.h:
2813         (WebCore::MouseEventWithHitTestResults::scrollbar):
2814         * platform/ScrollBar.cpp:
2815         (WebCore::Scrollbar::Scrollbar):
2816         (WebCore::Scrollbar::setValue):
2817         (WebCore::Scrollbar::setProportion):
2818         (WebCore::Scrollbar::setSteps):
2819         (WebCore::Scrollbar::scroll):
2820         * platform/ScrollBar.h:
2821         (WebCore::):
2822         (WebCore::ScrollbarClient::~ScrollbarClient):
2823         (WebCore::Scrollbar::~Scrollbar):
2824         (WebCore::Scrollbar::orientation):
2825         (WebCore::Scrollbar::controlSize):
2826         (WebCore::Scrollbar::hasPlatformScrollbars):
2827         (WebCore::Scrollbar::client):
2828         * platform/ScrollBarMode.h:
2829         (WebCore::):
2830         * platform/ScrollView.h:
2831         * rendering/RenderBlock.cpp:
2832         (WebCore::RenderBlock::isPointInScrollbar):
2833         * rendering/RenderLayer.cpp:
2834         (WebCore::RenderLayer::RenderLayer):
2835         (WebCore::RenderLayer::~RenderLayer):
2836         (WebCore::RenderLayer::scrollToOffset):
2837         (WebCore::RenderLayer::horizontaScrollbarWidget):
2838         (WebCore::RenderLayer::verticalScrollbarWidget):
2839         (WebCore::RenderLayer::valueChanged):
2840         (WebCore::RenderLayer::createScrollbar):
2841         (WebCore::RenderLayer::destroyScrollbar):
2842         (WebCore::RenderLayer::setHasHorizontalScrollbar):
2843         (WebCore::RenderLayer::setHasVerticalScrollbar):
2844         (WebCore::RenderLayer::verticalScrollbarWidth):
2845         (WebCore::RenderLayer::horizontalScrollbarHeight):
2846         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
2847         * rendering/RenderLayer.h:
2848         (WebCore::RenderLayer::horizontalScrollbar):
2849         (WebCore::RenderLayer::verticalScrollbar):
2850         * rendering/RenderListBox.cpp:
2851         (WebCore::RenderListBox::~RenderListBox):
2852         (WebCore::RenderListBox::calcMinMaxWidth):
2853         (WebCore::RenderListBox::isPointInScrollbar):
2854         (WebCore::RenderListBox::optionAtPoint):
2855         (WebCore::RenderListBox::valueChanged):
2856         * rendering/RenderListBox.h:
2857         * rendering/RenderObject.h:
2858         (WebCore::RenderObject::NodeInfo::scrollbar):
2859         (WebCore::RenderObject::NodeInfo::setScrollbar):
2860
2861 2006-10-05  Don Gibson  <dgibson77@gmail.com>
2862
2863         Reviewed by Adam.
2864
2865         http://bugs.webkit.org/show_bug.cgi?id=11138
2866         Incorrect mouse event generation on Windows
2867
2868         * platform/win/MouseEventWin.cpp:
2869         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2870         (1) Set mouse button even for non-click-related messages.
2871         (2) Track clicks correctly for all buttons, not just the left button.
2872
2873 2006-10-05  Nikolas Zimmermann  <zimmermann@kde.org>
2874
2875         Reviewed and landed by ap.
2876
2877         Fix Qt/Linux build, adapt to Eric's quartz changes and to Maciej's ResourceLoader changes.
2878
2879         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
2880         (WebCore::KRenderingPaintServerLinearGradientQt::renderPath):
2881         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
2882         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
2883         (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
2884         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
2885         (WebCore::KRenderingPaintServerPatternQt::renderPath):
2886         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
2887         (WebCore::KRenderingPaintServerQt::setPenProperties):
2888         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
2889         (WebCore::KRenderingPaintServerSolidQt::setup):
2890         (WebCore::KRenderingPaintServerSolidQt::renderPath):
2891         * kcanvas/device/qt/RenderPathQt.cpp:
2892         (WebCore::getPathStroke):
2893
2894 2006-10-05  Alexey Proskuryakov  <ap@nypop.com>
2895
2896         Reviewed by Darin.
2897
2898         http://bugs.webkit.org/show_bug.cgi?id=11054
2899         REGRESSION: Traditional Chinese encoding in login authentication
2900
2901         1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
2902         2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding
2903         for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
2904
2905         * platform/StreamingTextDecoderICU.cpp:
2906         (WebCore::TextCodecICU::registerEncodingNames):
2907
2908 2006-10-05  Eric Seidel  <eric@eseidel.com>
2909
2910         Reviewed by mjs.
2911
2912         Removed dead code.
2913         Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
2914
2915         * WebCore.xcodeproj/project.pbxproj:
2916         * ksvg2/ecma/GlobalObject.cpp: Removed.
2917         * ksvg2/ecma/GlobalObject.h: Removed.
2918
2919 2006-10-05  Adam Roben  <aroben@apple.com>
2920
2921         Reviewed by Maciej.
2922
2923         Small ResourceLoaderInternal tweak.
2924
2925         * platform/ResourceLoaderInternal.h:
2926         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2927
2928 2006-10-05  Eric Seidel  <eric@eseidel.com>
2929
2930         Reviewed by mjs.
2931
2932         More incremental KCanvas cleanup and optimization.
2933         Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
2934         Optimized dash array usage to not malloc.
2935         Also removed un-needed KSVGRenderingStyle includes.
2936
2937         * kcanvas/KCanvasTreeDebug.cpp:
2938         (WebCore::operator<<):
2939         * kcanvas/RenderPath.cpp:
2940         (WebCore::RenderPath::nodeAtPoint):
2941         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
2942         (WebCore::RenderPath::strokeBBox):
2943         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2944         (WebCore::KRenderingPaintServerGradientQuartz::setup):
2945         (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
2946         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
2947         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2948         (WebCore::KRenderingPaintServerSolidQuartz::setup):
2949         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
2950         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2951         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
2952         * kcanvas/device/quartz/QuartzSupport.mm:
2953         (WebCore::applyStrokeStyleToContext):
2954         * ksvg2/css/SVGRenderStyle.h:
2955         (WebCore::SVGRenderStyle::hasStroke):
2956         (WebCore::SVGRenderStyle::hasFill):
2957         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2958         (WebCore::KSVGPainterFactory::fillPaintServer):
2959         (WebCore::KSVGPainterFactory::strokePaintServer):
2960         * ksvg2/misc/KCanvasRenderingStyle.h:
2961
2962 2006-10-05  Maciej Stachowiak  <mjs@apple.com>
2963
2964         Reviewed by Adam.
2965
2966         - changed ResourceLoader to be refcounted
2967
2968         It keeps a ref on itself while loading as well. This makes
2969         for a much saner memory management model than the previous.
2970
2971         * bridge/mac/WebCoreResourceLoaderImp.mm:
2972         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
2973         * dom/XMLTokenizer.cpp:
2974         (WebCore::openFunc):
2975         * loader/icon/IconLoader.cpp:
2976         (IconLoader::IconLoader):
2977         (IconLoader::~IconLoader):
2978         (IconLoader::startLoading):
2979         (IconLoader::stopLoading):
2980         (IconLoader::receivedData):
2981         * loader/icon/IconLoader.h:
2982         * loader/loader.cpp:
2983         (WebCore::Loader::servePendingRequests):
2984         * platform/ResourceLoader.cpp:
2985         (WebCore::ResourceLoader::create):
2986         (WebCore::ResourceLoader::kill):
2987         * platform/ResourceLoader.h:
2988         * platform/ResourceLoaderInternal.h:
2989         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2990         * platform/mac/ResourceLoaderMac.mm:
2991         (WebCore::ResourceLoader::start):
2992         * xml/XSLTProcessor.cpp:
2993         (WebCore::docLoaderFunc):
2994         * xml/xmlhttprequest.cpp:
2995         (WebCore::XMLHttpRequest::send):
2996         * xml/xmlhttprequest.h:
2997
2998 2006-10-05  Eric Seidel  <eric@eseidel.com>
2999
3000         Reviewed by mjs.
3001
3002         Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
3003         http://bugs.webkit.org/show_bug.cgi?id=11163
3004         
3005         No SVG performance tests yet.
3006
3007         * kcanvas/RenderForeignObject.cpp:
3008         (WebCore::RenderForeignObject::paint):
3009         * kcanvas/RenderSVGContainer.cpp:
3010         (WebCore::RenderSVGContainer::paint):
3011         * kcanvas/RenderSVGImage.cpp:
3012         (WebCore::RenderSVGImage::paint):
3013         * kcanvas/RenderSVGText.cpp:
3014         (WebCore::RenderSVGText::paint):
3015
3016 2006-10-05  Dave Hyatt  <hyatt@apple.com>
3017
3018         Stub out some stuff for widget focusability.
3019
3020         Reviewed by maciej
3021  
3022         * page/FrameView.cpp:
3023         (WebCore::FrameView::dispatchMouseEvent):
3024         * platform/ScrollView.h:
3025         * platform/Widget.h:
3026
3027 2006-10-05  Adam Roben  <aroben@apple.com>
3028
3029         Reviewed by Maciej and Tim H.
3030
3031         Copy some WebKit frame lifetime logic into WebCore -- just a step
3032         along the path to frame lifetime being handled completely in WebCore.
3033
3034         * bridge/mac/FrameMac.mm:
3035         (WebCore::FrameMac::setView): Move platform-independent parts of this
3036         method into Frame.
3037         * page/Frame.cpp:
3038         (WebCore::Frame::setView): Adding platform-independent parts of
3039         FrameMac::setView
3040         (WebCore::Frame::detachChildren): New method to accomplish what
3041         -[WebFrameBridge _detachChildren] currently does.
3042         (WebCore::Frame::clear): Call detachChildren
3043         * page/Frame.h: Add declaration for detachChildren
3044
3045 2006-10-04  Alice Liu  <alice.liu@apple.com>
3046
3047         Reviewed by Darin.
3048
3049         Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query
3050
3051         * xml/xmlhttprequest.cpp:
3052         (WebCore::XMLHttpRequest::setRequestHeader):
3053         removed exception set when the request is not open yet
3054
3055 2006-10-04  Anders Carlsson  <acarlsson@apple.com>
3056
3057         Reviewed by John Sullivan.
3058
3059         <rdar://problem/4654328>
3060         Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
3061         
3062         * loader/PluginDocument.cpp:
3063         (WebCore::PluginTokenizer::writeRawData):
3064         Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
3065
3066 2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
3067
3068         Reviewed by Tim H.
3069
3070         http://bugs.webkit.org/show_bug.cgi?id=11130
3071         Convert "undefined" to AE missing value
3072
3073         * bridge/mac/WebCoreFrameBridge.mm:
3074         (aeDescFromJSValue): return missing value for UndefinedType.
3075
3076 2006-10-03  Dave Hyatt  <hyatt@apple.com>
3077
3078         Scrolling work.  Eliminate convertTo/FromContainingWindow as cross-platform functions.  Add back in
3079         the windowToContents/contentsToWindow functions.
3080         
3081         Reviewed by anders
3082
3083         * bridge/mac/FrameMac.mm:
3084         (WebCore::FrameMac::eventMayStartDrag):
3085         (WebCore::FrameMac::dragHysteresisExceeded):
3086         (WebCore::FrameMac::mouseDown):
3087         (WebCore::FrameMac::shouldDragAutoNode):
3088         (WebCore::FrameMac::sendContextMenuEvent):
3089         * bridge/mac/FrameViewMac.mm:
3090         (WebCore::FrameView::passMousePressEventToScrollbar):
3091         * bridge/mac/WebCoreFrameBridge.mm:
3092         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
3093         * dom/EventTargetNode.cpp:
3094         (WebCore::EventTargetNode::dispatchMouseEvent):
3095         (WebCore::EventTargetNode::dispatchWheelEvent):
3096         * page/Frame.cpp:
3097         (WebCore::Frame::selectClosestWordFromMouseEvent):
3098         (WebCore::Frame::handleMousePressEventTripleClick):
3099         (WebCore::Frame::handleMousePressEventSingleClick):
3100         (WebCore::Frame::handleMouseMoveEvent):
3101         (WebCore::Frame::handleMouseReleaseEvent):
3102         * page/FrameView.cpp:
3103         (WebCore::FrameView::handleMousePressEvent):
3104         (WebCore::FrameView::handleMouseDoubleClickEvent):
3105         (WebCore::selectCursor):
3106         (WebCore::FrameView::handleMouseMoveEvent):
3107         (WebCore::FrameView::handleMouseReleaseEvent):
3108         (WebCore::FrameView::dispatchDragEvent):
3109         (WebCore::FrameView::prepareMouseEvent):
3110         (WebCore::FrameView::handleWheelEvent):
3111         * page/FrameView.h:
3112         * platform/ScrollBar.cpp:
3113         (WebCore::ScrollBar::setValue):
3114         * platform/ScrollView.h:
3115         * platform/Widget.h:
3116         (WebCore::Widget::scrolled):
3117         * platform/mac/ScrollViewMac.mm:
3118         (WebCore::ScrollView::contentsToWindow):
3119         (WebCore::ScrollView::windowToContents):
3120         (WebCore::ScrollView::scrollbarUnderMouse):
3121         * platform/mac/WidgetMac.mm:
3122         * rendering/RenderLayer.cpp:
3123         (WebCore::RenderLayer::resize):
3124         (WebCore::RenderLayer::positionScrollbars):
3125         * rendering/RenderReplaced.cpp:
3126         (WebCore::RenderReplaced::shouldPaint):
3127         * rendering/RenderView.cpp:
3128         * rendering/RenderView.h:
3129         * rendering/RenderWidget.cpp:
3130         (WebCore::RenderWidget::setWidget):
3131
3132 2006-09-26  David Smith  <catfish.man@gmail.com>
3133
3134         Reviewed by Timothy.
3135
3136         http://bugs.webkit.org/show_bug.cgi?id=3723
3137         Add -scrollDOMRangeToVisible:
3138
3139         No automated tests are possible as this code path isn't reachable from JavaScript.
3140
3141         * bridge/mac/WebCoreFrameBridge.h:
3142         * bridge/mac/WebCoreFrameBridge.mm:
3143         (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
3144
3145 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
3146
3147         Reviewed by Timothy.
3148
3149         <http://bugs.webkit.org/show_bug.cgi?id=10338>
3150         When contentEditable, cursor doesn't change to hand
3151         
3152         Allow the behaviour of editable links to be specified by a WebPreference
3153         The preference WebKitEditableLinkBehavior has four options:
3154          - AlwaysLive: Safari 2.0 behaviour
3155          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
3156          - LiveWhenNotFocused: Editable links are live only when their editable block is not
3157              focused, or when the shift key is pressed
3158          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
3159          
3160         No layout tests, just a modification of a manual-test as it isn't possible to test
3161         this automatically.
3162
3163         * bridge/mac/WebCoreSettings.h:
3164         * bridge/mac/WebCoreSettings.mm:
3165         (-[WebCoreSettings setEditableLinkBehavior:]):
3166         (-[WebCoreSettings editableLinkBehavior]):
3167         * html/HTMLAnchorElement.cpp:
3168         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
3169         (WebCore::HTMLAnchorElement::defaultEventHandler):
3170         (WebCore::HTMLAnchorElement::setActive):
3171         * html/HTMLAnchorElement.h:
3172         * manual-tests/contenteditable-link.html:
3173         * page/FrameView.cpp:
3174         (WebCore::nodeIsNotBeingEdited):
3175         (WebCore::selectCursor):
3176         * page/Settings.h:
3177         (WebCore::Settings::):
3178         (WebCore::Settings::Settings):
3179         (WebCore::Settings::editableLinkBehavior):
3180         (WebCore::Settings::setEditableLinkBehavior):
3181
3182 2006-10-03  Beth Dakin  <bdakin@apple.com>
3183
3184         Reviewed Darin.
3185
3186         No test cases needed.
3187
3188         Implemented a version of StringImpl::append that takes a UChar* and 
3189         a length.
3190
3191         * platform/StringImpl.cpp:
3192         (WebCore::StringImpl::append):
3193         (WebCore::StringImpl::insert): Call new append instead of making a 
3194         new StringImpl.
3195         * platform/StringImpl.h:
3196
3197 2006-10-03  MorganL  <morganl.webkit@yahoo.com>
3198
3199         Reviewed by Darin.
3200
3201         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
3202         HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
3203
3204         * platform/win/ResourceLoaderWin.cpp:
3205         (WebCore::ResourceLoader::onHandleCreated):
3206
3207 2006-10-02  Geoffrey Garen  <ggaren@apple.com>
3208
3209         Feared, loathed, reviewed by Darin.
3210
3211         More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach 
3212         into FRAME, plus other cleanup.
3213         
3214         No new behavior, so no new test. Layout tests pass. Basic browsing and
3215         Mail editing seem to work.
3216         
3217         * dom/Node.cpp:
3218         (WebCore::Node::detach): Removed random commented-out code.
3219         * html/HTMLFrameElement.cpp:
3220         (WebCore::HTMLFrameElement::isURLAllowed): 
3221         (1) Removed reference to FrameView, to dissociate frame loading from rendering.
3222         (2) Renamed newURL to completeURL because the difference between newURL
3223         and URLString is that newURL is a KURL that is the complete version of URLString,
3224         not that it is new.
3225         (WebCore::HTMLFrameElement::willRemove): 
3226         (1) Removed close() call and moved close() code into willRemove(), also removing 
3227         close() call from detach(), since willRemove is the well-defined place 
3228         from DOM tear-down, not detach().
3229         (2) Removed manual renderer detach code because the DOM is not responsible
3230         for managing the render tree. I confirmed that this change not
3231         regress <rdar://problem/4132581>.
3232         (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
3233         lost their content frames after being removed from the DOM. That's our 
3234         current behavior, but it's going to change in future rounds of refactoring.
3235         This also fixes <rdar://problem/4750835>.
3236         (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
3237         attach/detach, because the render tree should not be in charge of deciding
3238         when to load.
3239         * html/HTMLFrameElement.h:
3240         * html/HTMLIFrameElement.cpp:
3241         (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
3242         because the renderer is a renderPartObject, not a renderPart.
3243         * html/HTMLIFrameElement.h:
3244
3245 2006-10-03  Mark Rowe  <bdash@webkit.org>
3246
3247         Reviewed by Mitz.
3248
3249         http://bugs.webkit.org/show_bug.cgi?id=11137
3250         Bug 11137: GdkLauncher dies with "pure virtual method called" if
3251         window is closed while page still loading
3252
3253         * platform/gdk/FrameGdk.cpp:
3254         (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
3255         methods to be called before the FrameGdk portion of "this" is torn down.
3256
3257 2006-10-03  Adam Roben  <aroben@apple.com>
3258
3259         Reviewed by Darin.
3260
3261         Handle tab key presses in the DOM.
3262
3263         * dom/EventTargetNode.cpp:
3264         (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
3265         * page/FrameView.cpp:
3266         (WebCore::FrameView::advanceFocus): Rename and reimplement
3267         focusNextPrevNode. Now we just call Element::focus().
3268         * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
3269         it public.
3270
3271 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
3272
3273         Reviewed by mjs
3274         
3275         <rdar://problem/4760612>
3276         TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
3277         
3278         No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
3279         
3280         * dom/Range.cpp:
3281         (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming 
3282         positions are non-null since most of it's callers would be in a bad state if the positions 
3283         were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.  
3284         Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it 
3285         from entering compareBoundaryPoints and hitting the assert.
3286
3287 2006-10-03  Adele Peterson  <adele@apple.com>
3288
3289         Reviewed by Geoff.
3290
3291         Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
3292
3293         * html/HTMLSelectElement.cpp:
3294         (WebCore::HTMLSelectElement::recalcStyle):
3295         (WebCore::HTMLSelectElement::isKeyboardFocusable):
3296         (WebCore::HTMLSelectElement::isMouseFocusable):
3297         (WebCore::HTMLSelectElement::createRenderer):
3298         (WebCore::HTMLSelectElement::setRecalcListItems):
3299         (WebCore::HTMLSelectElement::notifyOptionSelected):
3300         (WebCore::HTMLSelectElement::defaultEventHandler):
3301
3302 2006-10-04  Darin Adler  <darin@apple.com>
3303
3304         Reviewed by Geoff.
3305
3306         - fix http://bugs.webkit.org/show_bug.cgi?id=11132
3307           Caret disappears when you're typing
3308
3309         * editing/SelectionController.cpp:
3310         (WebCore::SelectionController::setSelection): Remove unnecessary call to
3311         clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
3312         (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
3313         to false so we can get the old caret repaint rect. Later we need to change the
3314         design so getting the rect doesn't have a side effect of causing a layout without
3315         invalidation.
3316
3317 2006-10-03  David Harrison  <harrison@apple.com>
3318
3319         Reviewed by Maciej.
3320
3321         <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
3322
3323         Updated test:
3324         * fast/text/justified-text-rect.html
3325
3326         * bridge/mac/WebCoreFrameBridge.mm:
3327         (-[WebCoreFrameBridge convertToNSRange:]):
3328         (-[WebCoreFrameBridge convertToDOMRange:]):
3329         Make the selection's root editable element (or the document itself) be
3330         the basis for NSRange conversions. This supports "shadow DOM" like
3331         that for text fields and text areas.
3332         
3333         * editing/CompositeEditCommand.cpp:
3334         (WebCore::CompositeEditCommand::moveParagraphs):
3335         Pass the document element as the scope.
3336         
3337         * editing/TextIterator.cpp:
3338         (WebCore::TextIterator::rangeFromLocationAndLength):
3339         Make the first parameter the scope.
3340         
3341         * editing/TextIterator.h:
3342         Make the first parameter of rangeFromLocationAndLength() the scope.
3343
3344 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
3345
3346         Reviewed by Eric.
3347
3348         Fix Qt/Linux build.
3349
3350         * CMakeLists.txt: Add counter related files.
3351
3352 2006-10-03  Mark Rowe  <bdash@webkit.org>
3353
3354         Reviewed by Eric.
3355
3356         http://bugs.webkit.org/show_bug.cgi?id=10981
3357         Linux/GDK build fixes
3358
3359         Based on a patch by Krzysztof Kowalczyk.
3360
3361         * WebCoreSources.bkl:
3362         * platform/gdk/FrameGdk.cpp:
3363         (WebCore::doScroll):
3364         (WebCore::FrameGdk::handleGdkEvent):
3365         * platform/gdk/PlatformScrollBar.h: Added.
3366         (WebCore::PlatformScrollBar::isWidget):
3367         * platform/gdk/ScrollViewGdk.cpp:
3368         * platform/gdk/TemporaryLinkStubs.cpp:
3369         (FrameView::passMousePressEventToScrollbar):
3370         (FrameView::passMousePressEventToSubframe):
3371         (FrameView::passMouseReleaseEventToSubframe):
3372         (FrameView::passMouseMoveEventToSubframe):
3373         (FrameView::passWheelEventToSubframe):
3374         (Cursor::Cursor):
3375         (Widget::invalidate):
3376         (Widget::invalidateRect):
3377         (ScrollView::wheelEvent):
3378         (ScrollView::convertToContainingWindow):
3379         (ScrollView::convertFromContainingWindow):
3380         (GraphicsContext::clip):
3381         (PlatformScrollBar::PlatformScrollBar):
3382         (PlatformScrollBar::updateThumbPosition):
3383         (PlatformScrollBar::updateThumbProportion):
3384         (ScrollBar::ScrollBar):
3385         (ScrollBar::setProportion):
3386         (WebCore::supportedKeySizes):
3387         (WebCore::signedPublicKeyAndChallengeString):
3388         * platform/gdk/WheelEventGdk.cpp:
3389         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3390         * platform/gdk/WidgetGdk.cpp:
3391         (WebCore::Widget::convertToContainingWindow):
3392         (WebCore::Widget::convertFromContainingWindow):
3393
3394 2006-10-02  Adam Roben  <aroben@apple.com>
3395
3396         Reviewed by Maciej.
3397
3398         Let Windows determine which mouse button is pressed.
3399
3400         * platform/PlatformMouseEvent.h: Add message parameter to constructor.
3401         * platform/win/MouseEventWin.cpp:
3402         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
3403         parameter to determine which mouse button is pressed.
3404
3405 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
3406
3407         Reviewed by anders
3408         
3409         Build fix
3410         
3411         * editing/SelectionController.cpp:
3412         (WebCore::SelectionController::empty):
3413         * editing/SelectionController.h:
3414
3415 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
3416
3417         Reviewed by john
3418         
3419         <rdar://problem/4755287>
3420         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
3421
3422         * editing/markup.cpp:
3423         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced 
3424         elements).  Don't skip blocks that aren't containers (like horizontal rules).
3425
3426 2006-10-03  Darin Adler  <darin@apple.com>
3427
3428         Reviewed by Justin Garcia.
3429
3430         - correct mistaken code that would restart blinking every
3431           time "invalidateSelection" is called even if the caret
3432           has not moved
3433
3434         * editing/SelectionController.h:
3435         * editing/SelectionController.cpp:
3436         (WebCore::SelectionController::setSelection): Update for name change.
3437         (WebCore::SelectionController::recomputeCaretRect): New function.
3438         Computes caret rect and does any necessary invalidation if the rect
3439         changes.
3440         (WebCore::SelectionController::invalidateCaretRect): Renamed from
3441         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
3442         calls recomputeCaretRect as a side effect.
3443
3444         * page/Frame.cpp:
3445         (WebCore::Frame::invalidateSelection): Remove unneeded call to
3446         clearCaretRectIfNeeded.
3447         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
3448         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
3449         recomputeCaretRect function and not restart blinking if caret has
3450         not changed position.
3451         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
3452         are not needed since selectionLayoutChanged already checks these.
3453
3454         * page/FramePrivate.h: Removed unused m_blinkCaret.
3455
3456 2006-10-02  Beth Dakin  <bdakin@apple.com>
3457
3458         Reviewed by Adam.
3459
3460         Build fix. Add counters to vcproj.
3461
3462         * WebCore.vcproj/WebCore/WebCore.vcproj:
3463
3464 2006-10-02  Brady Eidson  <beidson@apple.com>
3465
3466         Reviewed by Adele
3467
3468         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
3469         icon data out because we don't correctly check SQL error conditions.
3470
3471         * loader/icon/IconDataCache.cpp:
3472         (WebCore::IconDataCache::writeToDatabase):
3473
3474 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
3475
3476         Reviewed by Hyatt.
3477
3478         Added method to find out whether a layout has occurred.
3479
3480         * page/FrameView.cpp:
3481         (WebCore::FrameView::didFirstLayout):
3482         * page/FrameView.h:
3483
3484 2006-10-02  Beth Dakin  <bdakin@apple.com>
3485
3486         Reviewed by Darin.
3487
3488         Initial implementation of CSS2 counters. See http://
3489         bugs.webkit.org/show_bug.cgi?id=4980 for more details.
3490
3491         * WebCore.xcodeproj/project.pbxproj:
3492         * css/CSSComputedStyleDeclaration.cpp: 
3493         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 
3494         the increment/reset list now that this is implemented.
3495         * css/CSSPrimitiveValue.cpp:
3496         (WebCore::CSSPrimitiveValue::cssText): 
3497         * css/Counter.h:
3498         (WebCore::Counter::Counter):
3499         (WebCore::Counter::~Counter):
3500         (WebCore::Counter::identifier):
3501         (WebCore::Counter::listStyle):
3502         (WebCore::Counter::separator):
3503         (WebCore::Counter::listStyleNumber):
3504         (WebCore::Counter::setIdentifier):
3505         (WebCore::Counter::setListStyle):
3506         (WebCore::Counter::setSeparator):
3507         * css/cssparser.cpp:
3508         (WebCore::CSSParser::addProperty): Take care of reset/increment
3509         (WebCore::CSSParser::parseValue):
3510         (WebCore::CSSParser::parseContent): content can now take counters
3511         (WebCore::CSSParser::parseCounterContent): Parse counter() and 
3512         counters()
3513         (WebCore::CSSParser::parseCounter): Parse counter-reset and 
3514         counter-increment
3515         * css/cssparser.h:
3516         * css/cssstyleselector.cpp:
3517         (WebCore::CSSStyleSelector::matchUARules):
3518         (WebCore::CSSStyleSelector::applyProperty):
3519         * platform/PlatformString.h:
3520         * platform/String.cpp:
3521         (WebCore::String::insert): Implemented a version of insert that 
3522         accepts a UChar* and a length.
3523         * platform/StringImpl.cpp:
3524         (WebCore::StringImpl::insert): Same as above.
3525         * platform/StringImpl.h:
3526         * rendering/CounterListItem.h: Added.
3527         * rendering/CounterNode.cpp: Added.
3528         (WebCore::CounterNode::CounterNode):
3529         (WebCore::CounterNode::insertAfter):
3530         (WebCore::CounterNode::removeChild):
3531         (WebCore::CounterNode::remove):
3532         (WebCore::CounterNode::setUsesSeparator):
3533         (WebCore::CounterNode::recountAndGetNext):
3534         (WebCore::CounterNode::recountTree):
3535         (WebCore::CounterNode::setSelfDirty):
3536         (WebCore::CounterNode::setParentDirty):
3537         * rendering/CounterNode.h: Added.
3538         (WebCore::CounterNode::~CounterNode):
3539         (WebCore::CounterNode::parent):
3540         (WebCore::CounterNode::previousSibling):
3541         (WebCore::CounterNode::nextSibling):
3542         (WebCore::CounterNode::firstChild):
3543         (WebCore::CounterNode::lastChild):
3544         (WebCore::CounterNode::value):
3545         (WebCore::CounterNode::setValue):
3546         (WebCore::CounterNode::count):
3547         (WebCore::CounterNode::setCount):
3548         (WebCore::CounterNode::setHasSeparator):
3549         (WebCore::CounterNode::isReset):
3550         (WebCore::CounterNode::hasSeparator):
3551         (WebCore::CounterNode::willNeedLayout):
3552         (WebCore::CounterNode::setWillNeedLayout):
3553         (WebCore::CounterNode::isRoot):
3554         (WebCore::CounterNode::setRenderer):
3555         (WebCore::CounterNode::renderer):
3556         * rendering/CounterResetNode.cpp: Added.
3557         (WebCore::CounterResetNode::CounterResetNode):
3558         (WebCore::CounterResetNode::insertAfter):
3559         (WebCore::CounterResetNode::removeChild):
3560         (WebCore::CounterResetNode::recountAndGetNext):
3561         (WebCore::CounterResetNode::setParentDirty):
3562         (WebCore::CounterResetNode::updateTotal):
3563         * rendering/CounterResetNode.h: Added.
3564         (WebCore::CounterResetNode::firstChild):
3565         (WebCore::CounterResetNode::lastChild):
3566         (WebCore::CounterResetNode::isReset):
3567         (WebCore::CounterResetNode::total):
3568         * rendering/RenderContainer.cpp:
3569         (WebCore::RenderContainer::updatePseudoChildForObject): Account for 
3570         counter content.
3571         * rendering/RenderCounter.cpp: Added.
3572         (WebCore::RenderCounter::RenderCounter):
3573         (WebCore::RenderCounter::layout):
3574         (WebCore::toRoman):
3575         (WebCore::toLetterString):
3576         (WebCore::toHebrew):
3577         (WebCore::RenderCounter::convertValueToType):
3578         (WebCore::RenderCounter::calcMinMaxWidth):
3579         * rendering/RenderCounter.h: Added.
3580         (WebCore::RenderCounter::renderName):
3581         (WebCore::RenderCounter::isCounter):
3582         * rendering/RenderObject.cpp:
3583         (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to 
3584         maps of CounterNodes
3585         (WebCore::RenderObject::RenderObject):
3586         (WebCore::RenderObject::destroy): Destroy the maps.
3587         (WebCore::RenderObject::findCounter): Finds/creates counters.
3588         * rendering/RenderObject.h:
3589         (WebCore::RenderObject::isCounter):
3590         * rendering/RenderStyle.cpp:
3591         (WebCore::StyleVisualData::StyleVisualData):
3592         (WebCore::RenderStyle::arenaDelete):
3593         (WebCore::RenderStyle::RenderStyle):
3594         (WebCore::RenderStyle::diff):
3595         (WebCore::RenderStyle::setContent):
3596         (WebCore::ContentData::clearContent):
3597         (WebCore::RenderStyle::counterDataEquivalent):
3598         (WebCore::hasCounter):
3599         (WebCore::RenderStyle::hasCounterReset):
3600         (WebCore::RenderStyle::hasCounterIncrement):
3601         (WebCore::readCounter):
3602         (WebCore::RenderStyle::counterReset):
3603    &nbs