parallel build fix
[WebKit-https.git] / WebCore / ChangeLog
1 2007-01-18  Simon Hausmann  <hausmann@kde.org>
2
3         Reviewed by Zack.
4
5         * WebCore.pro: Ha^H^HFix to support massive parallel builds.
6
7 2007-01-18  David Kilzer  <ddkilzer@kilzer.net>
8
9         Reviewed by Darin and Mitz.
10
11         - fix http://bugs.webkit.org/show_bug.cgi?id=12305
12           REGRESSION: Images do not load in video sections on CNN.com homepage
13
14         <rdar://problem/4931480> REGRESSION: Images do not load in video sections on CNN.com homepage (12305)
15
16         Test: fast/dom/HTMLImageElement/image-lowsrc-getset.html
17
18         * html/HTMLAttributeNames.in: Added lowsrc.
19         * html/HTMLImageElement.cpp:
20         (WebCore::HTMLImageElement::isURLAttribute): Added lowsrc.
21         (WebCore::HTMLImageElement::lowsrc): Added.
22         (WebCore::HTMLImageElement::setLowsrc): Added.
23         * html/HTMLImageElement.h: Added lowsrc and setLowsrc.
24         * html/HTMLImageElement.idl: Added lowsrc.
25
26 2007-01-18  Simon Hausmann  <hausmann@kde.org>
27
28         Reviewed by Zack.
29
30         * WebCore.pro: Remove generated files on make clean.
31
32 2007-01-17  Alice Liu  <alice.liu@apple.com>
33
34         Reviewed by Harrison.
35
36         Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste
37
38         Migration of some editing code from WebHTMView to WebCore::Editor
39         resulted in not calling pasteboardTypesForSelection, which Mail was
40         overriding for the special purpose of adding a type to the
41         pasteboard after WebKit did.  This patch adds 2 separate code paths
42         for Tiger and Leopard.  On Tiger we give in and call the WebView's
43         pasteboardTypesForSelection.  On Leopard we call a delegate after
44         the pasteboard types are set. 
45
46         * bridge/EditorClient.h:
47         * editing/Editor.h:
48         * platform/Pasteboard.h:
49         * platform/graphics/svg/SVGImageEmptyClients.h:
50         (WebCore::SVGEmptyEditorClient::didSetSelectionTypesForPasteboard):
51         (WebCore::SVGEmptyEditorClient::pasteboardTypesForSelection):
52         * platform/mac/PasteboardMac.mm:
53         (WebCore::Pasteboard::Pasteboard):
54         (WebCore::Pasteboard::clear):
55         (WebCore::Pasteboard::writeSelection):
56         (WebCore::Pasteboard::writeURL):
57         (WebCore::Pasteboard::plainText):
58         (WebCore::Pasteboard::documentFragment):
59
60 2007-01-17  John Sullivan  <sullivan@apple.com>
61
62         Reviewed by Darin
63
64         - WebCore part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during 
65           Replace All if the replacement string contains the search string
66         
67         * page/Frame.h:
68         * page/Frame.cpp:
69         (WebCore::Frame::findString):
70         new startInSelection parameter -- if true, search starts looking in selection; if false,
71         search starts looking after the selection
72         
73         * page/mac/WebCoreFrameBridge.h:
74         * page/mac/WebCoreFrameBridge.mm:
75         (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:startInSelection:]):
76         new startInSelection parameter, passed through to Frame::findString()
77
78         * editing/JSEditor.cpp:
79         pass false for new findString parameter, to match old behavior
80
81 2007-01-17  Beth Dakin  <bdakin@apple.com>
82
83         Rubber stamped by Darin.
84
85         * rendering/HitTestResult.cpp: Just added a comment.
86
87 2007-01-17  Justin Garcia  <justin.garcia@apple.com>
88
89         Reviewed by darin
90         
91         <rdar://problem/4920488>
92         REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link)
93
94         * dom/Range.cpp:
95         (WebCore::Range::commonAncestorContainer): Return null if the nodes
96         don't have a common ancestor.  As a side effect, the public 
97         commonAncestorContainer now sets an exception if the Range starts
98         in one document and ends in another, or starts or ends in a tree
99         that's been removed from the document.  The spec doesn't cover
100         this and there is no precedent in other browsers for this case because
101         they don't allow invalid Ranges (you can create one with WebCore
102         by removing a node that contains the start/end of a Range).
103         (WebCore::Range::compareBoundaryPoints): If the the two positions
104         are in nodes that have no common ancestor, return null.  This doesn't
105         change the behavior of the public compareBoundaryPoints: it already
106         throws an exception if the two positions are in nodes that don't have
107         a common ancestor.  This follows the spec.
108
109 2007-01-17  John Sullivan  <sullivan@apple.com>
110
111         The one word was typed by me, but only after debugging for a long time with Darin.
112
113         - fixed <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word
114
115         * editing/TextIterator.cpp:
116         (WebCore::WordAwareIterator::WordAwareIterator):
117         We were creating a TextIterator with the default kind, but WordAwareIterator is designed to work
118         in concert with CharacterIterator, so they need to use the same kind. CharacterIterator uses
119         kind RUNFINDER, so WordAwareIterator needs to do so also.
120
121 2007-01-17  Adele Peterson  <adele@apple.com>
122
123         Reviewed by Brady.
124
125         Fix for <rdar://problem/4900895> REGRESSION: onChange doesn't always fire for popups that have had value changed by JS
126
127         No test case since you need to open up the menu to fire onChange.
128
129         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex):
130           Keep track of m_lastOnChangeIndex even when we're not firing onChange.  Since
131           the selected index has changed, we still want the m_lastOnChangeIndex to be up to date when we compare
132           it later.  This matches our behavior in Safari 2.0.
133
134 2007-01-17  Adele Peterson  <adele@apple.com>
135
136         Reviewed by Darin and John.
137
138         - Fix for <rdar://problem/4816550> REGRESSION: autoscrolling doesn't work after double-click
139
140         * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set swallowEvent bool instead
141           of returning early for double and triple clicks.
142
143 2007-01-17  Darin Adler  <darin@apple.com>
144
145         Reviewed by Hyatt.
146
147         * rendering/RenderObject.h: Removed unused nextEditable and previousEditable.
148         * rendering/RenderObject.cpp: Ditto.
149
150 2007-01-17  Darin Adler  <darin@apple.com>
151
152         Reviewed by Maciej.
153
154         - fix http://bugs.webkit.org/show_bug.cgi?id=12278
155           <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278)
156
157         * WebCore.exp: Added HitTestResult::imageRect,
158         removed HitTestResult::boundingBox.
159
160         * rendering/HitTestResult.h:
161         * rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect):
162         Added. Returns the content rectangle of the image.
163
164         * rendering/RenderObject.h:
165         * rendering/RenderObject.cpp:
166         (WebCore::RenderObject::absolutePosition): Made const.
167         (WebCore::RenderObject::contentBox): Added.
168         (WebCore::RenderObject::absoluteContentBox): Added.
169
170         * rendering/RenderBox.h:
171         * rendering/RenderBox.cpp:
172         (WebCore::RenderBox::absolutePosition): Made const.
173
174         * rendering/RenderTableCell.h:
175         * rendering/RenderTableCell.cpp:
176         (WebCore::RenderTableCell::absolutePosition): Made const.
177
178         * rendering/RenderView.h:
179         * rendering/RenderView.cpp:
180         (WebCore::RenderView::absolutePosition): Made const.
181
182 2007-01-17  Adele Peterson  <adele@apple.com>
183
184         Reviewed by Beth.
185
186         Fix for  http://bugs.webkit.org/show_bug.cgi?id=10139
187         <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle
188
189         Test: fast/css/pseudostyle-anonymous-text.html
190
191         * rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Nil check the node.
192
193 2007-01-17  Adele Peterson  <adele@apple.com>
194
195         Reviewed by Anders and John.
196
197         Fix for http://bugs.webkit.org/show_bug.cgi?id=11278
198         <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options
199
200         Test: fast/forms/menulist-width-change.html
201
202         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
203           When the options change, call setNeedsLayoutAndMinMaxRecalc.
204
205 2007-01-16  Alexey Proskuryakov  <ap@webkit.org>
206
207         Reviewed by Maciej.
208
209         http://bugs.webkit.org/show_bug.cgi?id=12268
210         Give object prototypes their own names
211
212         * bindings/js/kjs_html.cpp: Changed the names of KJS:HTMLElement and KJS::HTMLElement to 
213         not match the names of their WebCore counterparts. The "DOM" prefix I gave them doesn't 
214         seem to carry much sense, but matches some other kjs_html object names.
215
216         * bindings/scripts/CodeGeneratorJS.pm: Append "Proto" to interface name for the prototype's ClassInfo.
217
218         * bindings/js/JSHTMLInputElementBase.cpp:
219         (WebCore::JSHTMLInputElementBasePrototypeFunction::callAsFunction):
220         (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
221         * bindings/js/JSHTMLInputElementBase.h:
222         * bindings/js/JSXMLHttpRequest.cpp:
223         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
224         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
225         (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
226         * bindings/js/JSXMLHttpRequest.h:
227         * bindings/js/JSXSLTProcessor.cpp:
228         (KJS::JSXSLTProcessor::JSXSLTProcessor):
229         (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
230         (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
231         * bindings/js/kjs_css.cpp:
232         (KJS::DOMCSSStyleDeclaration::DOMCSSStyleDeclaration):
233         (KJS::DOMCSSStyleDeclarationPrototypeFunction::callAsFunction):
234         (KJS::DOMMediaList::DOMMediaList):
235         (KJS::KJS::DOMMediaListPrototypeFunction::callAsFunction):
236         (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet):
237         (KJS::DOMCSSStyleSheetPrototypeFunction::callAsFunction):
238         (KJS::DOMCSSValue::DOMCSSValue):
239         (KJS::DOMCSSValuePrototypeFunction::callAsFunction):
240         * bindings/js/kjs_css.h:
241         * bindings/js/kjs_dom.cpp:
242         (KJS::DOMNode::DOMNode):
243         (KJS::DOMNodePrototypeFunction::callAsFunction):
244         (KJS::DOMEventTargetNode::DOMEventTargetNode):
245         (KJS::DOMEventTargetNodePrototypeFunction::callAsFunction):
246         (KJS::DOMNamedNodeMap::DOMNamedNodeMap):
247         (KJS::DOMNamedNodeMapPrototypeFunction::callAsFunction):
248         * bindings/js/kjs_dom.h:
249         * bindings/js/kjs_domnode.h:
250         * bindings/js/kjs_events.cpp:
251         (KJS::DOMEvent::DOMEvent):
252         (KJS::DOMEventPrototypeFunction::callAsFunction):
253         (KJS::Clipboard::Clipboard):
254         (KJS::ClipboardPrototypeFunction::callAsFunction):
255         * bindings/js/kjs_events.h:
256         * bindings/js/kjs_html.cpp:
257         (KJS::JSHTMLDocumentPrototypeFunction::callAsFunction):
258         (KJS::):
259         (KJS::JSHTMLDocument::JSHTMLDocument):
260         (KJS::JSHTMLElementPrototypeFunction::callAsFunction):
261         (KJS::JSHTMLElement::JSHTMLElement):
262         (KJS::JSHTMLCollection::JSHTMLCollection):
263         (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):
264         * bindings/js/kjs_html.h:
265         * bindings/js/kjs_navigator.cpp:
266         * bindings/js/kjs_traversal.cpp:
267         (KJS::DOMNodeFilter::DOMNodeFilter):
268         (KJS::DOMNodeFilterPrototypeFunction::callAsFunction):
269         * bindings/js/kjs_window.cpp:
270         (KJS::Window::clear):
271         Changed Proto to Prototype, and ProtoFunc to PrototypeFunction.
272
273 2007-01-17  Lars Knoll <lars@trolltech.com>
274
275         Reviewed by Zack and Darin
276
277         Fix the Qt build again after the latest Image changes.
278         Also make some of the methods implemented in ImageCG 
279         crossplatform.
280
281         * platform/graphics/BitmapImage.h:
282         * platform/graphics/Image.cpp:
283         (WebCore::Image::fillWithSolidColor):
284         (WebCore::calculatePatternScale):
285         (WebCore::Image::drawTiled):
286         * platform/graphics/Image.h:
287         * platform/graphics/cg/ImageCG.cpp:
288         (WebCore::BitmapImage::draw):
289         * platform/graphics/qt/ImageQt.cpp:
290         (WebCore::Image::loadPlatformResource):
291         (WebCore::Image::drawPattern):
292         (WebCore::BitmapImage::initPlatformData):
293         (WebCore::BitmapImage::invalidatePlatformData):
294         (WebCore::BitmapImage::draw):
295         (WebCore::BitmapImage::drawPattern):
296         * platform/qt/TemporaryLinkStubs.cpp:
297
298 2007-01-17  Darin Adler  <darin@apple.com>
299
300         - quick attempt to fix the Qt build
301
302         * platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::drawTiled):
303         Remove obsolete parameters from this stub.
304
305 2007-01-17  Eric Seidel  <eric@webkit.org>
306
307         Reviewed by rwlbuis.
308
309         Test: svg/custom/inner-svg-hit-test.svg
310
311         * rendering/RenderSVGContainer.cpp:
312         (WebCore::RenderSVGContainer::nodeAtPoint): never allow containers to be hit.
313
314 2007-01-17  Lars Knoll <lars@trolltech.com>
315
316         Reviewed by Zack
317
318         Don't call receivedResponse twice for file: URLs.
319         Never call back into the ResourceHandleClient once
320         cancel() has been called on the ResourceHandle.
321
322         * WebCore.pro:
323         * platform/network/qt/ResourceHandleManagerQt.cpp:
324         (WebCore::ResourceHandleManager::cancel):
325         (WebCore::ResourceHandleManager::receivedResponse):
326         (WebCore::ResourceHandleManager::receivedData):
327         (WebCore::ResourceHandleManager::receivedFinished):
328         (WebCore::FileLoader::request):
329         (WebCore::FileLoader::parseDataUrl):
330         (WebCore::WebCoreHttp::scheduleNextRequest):
331         * platform/network/qt/ResourceHandleManagerQt.h:
332
333 2007-01-17  Eric Seidel  <eric@webkit.org>
334
335         No review, build fix only.
336
337         * platform/graphics/cg/ImageCG.cpp: correct drawPatternCombined to drawPattern
338         (WebCore::Image::drawPattern):
339         (WebCore::Image::drawTiled):
340
341 2007-01-17  Eric Seidel  <eric@webkit.org>
342
343         Reviewed by mitz and rwlbuis.
344         
345         SVGs do not work as background images:
346         http://bugs.webkit.org/show_bug.cgi?id=12096
347
348         Tests updated:
349         - fast/images/svg-as-background.svg: now passes
350         - fast/images/svg-as-tiled-background.svg: now passes
351
352         * platform/graphics/BitmapImage.h:
353         (WebCore::BitmapImage::nativeImageForCurrentFrame):
354         (WebCore::BitmapImage::mayFillWithSolidColor):
355         (WebCore::BitmapImage::solidColor):
356         * platform/graphics/Image.h:
357         (WebCore::Image::mayFillWithSolidColor):
358         (WebCore::Image::solidColor):
359         (WebCore::Image::nativeImageForCurrentFrame):
360         (WebCore::Image::startAnimation):
361         * platform/graphics/cg/ImageCG.cpp:
362         (WebCore::Image::drawPatternCallback):
363         (WebCore::Image::drawPatternCombined):
364         (WebCore::caculatePatternScale):
365         (WebCore::Image::drawTiled):
366         * platform/graphics/cg/PDFDocumentImage.cpp:
367         * platform/graphics/cg/PDFDocumentImage.h:
368         * platform/graphics/svg/SVGImage.cpp:
369         (WebCore::SVGImage::nativeImageForCurrentFrame):
370         * platform/graphics/svg/SVGImage.h:
371
372 2007-01-17  Rob Buis  <buis@kde.org>
373
374         Reviewed by Eric
375
376         Add proper condition for rx attribute negative check.
377
378         * ksvg2/svg/SVGRectElement.cpp:
379         (WebCore::SVGRectElement::parseMappedAttribute):
380
381 2007-01-17  Lars Knoll <lars@trolltech.com>
382
383         Reviewed by Zack
384
385         change all notImplemented() macros to use qDebug
386         instead of fprintf(stder, ...)
387
388         * loader/qt/DocumentLoaderQt.cpp:
389         * loader/qt/FrameLoaderQt.cpp:
390         * page/qt/EventHandlerQt.cpp:
391         * page/qt/FrameQt.cpp:
392         * platform/graphics/qt/GraphicsContextQt.cpp:
393         * platform/graphics/qt/IconQt.cpp:
394         * platform/network/qt/ResourceHandleManagerQt.cpp:
395         * platform/network/qt/ResourceHandleQt.cpp:
396         * platform/qt/CursorQt.cpp:
397         * platform/qt/FileChooserQt.cpp:
398         * platform/qt/MimeTypeRegistryQt.cpp:
399         * platform/qt/PageQt.cpp: Removed.
400         * platform/qt/PopupMenuQt.cpp:
401         * platform/qt/ScrollViewQt.cpp:
402         * platform/qt/TemporaryLinkStubs.cpp:
403         * platform/qt/TextBoundaries.cpp:
404         * platform/qt/WidgetQt.cpp:
405
406 2007-01-16  Brady Eidson  <beidson@apple.com>
407
408         Reviewed by Oliver
409
410         A few enhancements to the HTTP Auth architecture
411
412         * platform/network/ProtectionSpace.cpp:
413         (WebCore::ProtectionSpace::isProxy):
414         (WebCore::ProtectionSpace::receivesCredentialSecurely):
415         * platform/network/ProtectionSpace.h:
416
417 2007-01-16  Alice Liu  <alice.liu@apple.com>
418
419         Reviewed by harrison.
420
421         Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard
422
423         * WebCore.xcodeproj/project.pbxproj:
424         * bridge/EditorClient.h:
425         * editing/Editor.cpp:
426         (WebCore::Editor::copy):
427         (WebCore::Editor::didWriteSelectionToPasteboard):
428         * editing/Editor.h:
429         * platform/graphics/svg/SVGImageEmptyClients.h:
430         (WebCore::SVGEmptyEditorClient::didWriteSelectionToPasteboard):
431
432 2007-01-16  Justin Garcia  <justin.garcia@apple.com>
433
434         Reviewed by harrison
435         
436         <rdar://problem/4747450>
437         Gmail Editor: Caret doesn't always position itself after list marker
438         <rdar://problem/4917055>
439         GMail Editor: A hang can occur when attempting to apply list styling to selected indented text
440
441         * editing/TextIterator.cpp:
442         (WebCore::TextIterator::rangeFromLocationAndLength): Use VisiblePositions
443         to compute the end of a run for emitted '\n's, because it's often wrong
444         in that case.
445
446 2007-01-16  Darin Adler  <darin@apple.com>
447
448         - quick lame attempt to get Qt compiling again
449
450         * platform/qt/ContextMenuQt.cpp: Removed show() function.
451
452 2007-01-17  Nicholas Shanks  <contact@nickshanks.com>
453
454         Reviewed by Darin.
455
456         * platform/network/ResourceRequest.h:
457         (WebCore::ResourceRequest::setHTTPAccept): Correct argument name.
458
459 2007-01-16  Beth Dakin  <bdakin@apple.com>
460
461         Reviewed by Adam.
462
463         Get rid of show() and hide() since they don't do anything.
464
465         * page/ContextMenuController.cpp:
466         (WebCore::ContextMenuController::handleContextMenuEvent):
467         * platform/ContextMenu.h:
468         * platform/mac/ContextMenuMac.mm:
469
470 2007-01-16  Lars Knoll <lars@trolltech.com>
471
472         Reviewed by Zack
473
474         Cleaned up the way we create native widgets. They are
475         now not created in WebCore anymore, but in the new
476         Qt API to WebKit.
477
478         Fix a compile issue in the ResourceHandleManager.
479
480         * WebCore.pro:
481         * platform/ScrollView.h:
482         * platform/Widget.h:
483         (WebCore::ResourceHandleManager::cancel):
484         * platform/qt/ScrollViewCanvasQt.cpp:
485         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
486         (WebCore::ScrollViewCanvasQt::paintEvent):
487         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
488         (WebCore::ScrollViewCanvasQt::mousePressEvent):
489         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
490         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
491         * platform/qt/ScrollViewCanvasQt.h:
492         * platform/qt/ScrollViewQt.cpp:
493         (WebCore::ScrollView::ScrollView):
494         (WebCore::ScrollView::setScrollArea):
495         (WebCore::ScrollView::addChild):
496         * platform/qt/WidgetQt.cpp:
497         * platform/network/qt/ResourceHandleManagerQt.cpp:
498
499 2007-01-16  Lars Knoll <lars@trolltech.com>
500
501         Reviewed by Zack
502
503         Looks like ResourceHandle _has_ to do everything
504         asynchronously if we don't want to run into
505         lots of trouble in the loader.
506
507         Implement support data: URLs.
508
509         Remove some unused Qt only code in ResourceHandleClient.h
510
511         * platform/network/ResourceHandleClient.h:
512         * platform/network/qt/ResourceHandleManagerQt.cpp:
513         (WebCore::RequestQt::setURL):
514         (WebCore::ResourceHandleManager::add):
515         (WebCore::ResourceHandleManager::cancel):
516         (WebCore::ResourceHandleManager::receivedFinished):
517         (WebCore::LoaderThread::run):
518         (WebCore::FileLoader::request):
519         (WebCore::FileLoader::sendData):
520         (WebCore::FileLoader::parseDataUrl):
521         * platform/network/qt/ResourceHandleManagerQt.h:
522
523 2007-01-16  Eric Seidel  <eric@webkit.org>
524
525         Reviewed by mitz.
526
527         Refactor drawTiled implementations in preparation for combining them.
528         Removed unused RoundTile code path.
529
530         * platform/graphics/cg/ImageCG.cpp:
531         (WebCore::drawPattern):
532         (WebCore::BitmapImage::drawTiled):
533         (WebCore::caculatePatternScale):
534
535 2007-01-16  Darin Adler  <darin@apple.com>
536
537         Reviewed by Mark Rowe.
538
539         - removed unused field from loader
540
541         * loader/loader.cpp:
542         (WebCore::Loader::numRequests):
543         (WebCore::Loader::cancelRequests):
544         * loader/loader.h:
545
546 2007-01-15  Rob Buis  <buis@kde.org>
547
548         Reviewed by Eric.
549
550         http://bugs.webkit.org/show_bug.cgi?id=12272
551         SVG picture is clipped (edges not visible)
552
553         Expose css dpi constant and use it for svg, making
554         1in amount to 96 pixels like for html.
555
556         * css/CSSPrimitiveValue.cpp:
557         (WebCore::CSSPrimitiveValue::computeLengthFloat):
558         (WebCore::scaleFactorForConversion):
559         * css/csshelper.h:
560         * ksvg2/svg/SVGLength.cpp:
561         (WebCore::SVGLength::value):
562         (WebCore::SVGLength::setValue):
563         * ksvg2/svg/SVGLength.h:
564
565 2007-01-15  Brady Eidson  <beidson@apple.com>
566
567         Reviewed by Adam
568         
569         CFNet additions
570
571         * platform/network/AuthenticationChallenge.cpp:
572         (WebCore::operator==):
573         * platform/network/AuthenticationChallenge.h:
574         (WebCore::AuthenticationChallenge::sourceHandle):
575         (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
576         * platform/network/ResourceError.h:
577         * platform/network/ResourceHandle.h:
578         * platform/network/ResourceHandleInternal.h:
579         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
580
581 2007-01-15  Eric Seidel  <eric@webkit.org>
582
583         Reviewed by hyatt.
584
585         Don't map attributes in namespaces other than null to CSS properties.
586         
587         Test: svg/custom/attribute-namespace-check.svg
588
589         * ksvg2/svg/SVGStyledElement.cpp:
590         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
591
592 2007-01-15  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
593
594         Reviewed by Darin.
595
596         - http://bugs.webkit.org/show_bug.cgi?id=11112
597           add a drop shadow to the hand cursor used for links
598
599         * Resources/linkCursor.png: Added a drop shadow.
600
601 2007-01-15  Darin Adler  <darin@apple.com>
602
603         Reviewed by Adam.
604
605         - fix http://bugs.webkit.org/show_bug.cgi?id=12190
606           REGRESSION: Placeholder text does not reflect dynamic updates
607
608         Test: fast/forms/placeholder-set-attribute.html
609
610         * html/HTMLTextFieldInnerElement.cpp:
611         (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
612         Call onSearch on the element since I removed it from the renderer.
613
614         * rendering/RenderTextControl.h: Added explicit virtual keywords for overrides
615         of virtual functions. Removed the unneeded onSearch function. Made the inheritance
616         from PopupMenuClient be private, and made the overrides all private. Replaced the
617         showPlaceholderIfNeeded and hidePlaceholderIfNeeded functions with updatePlaceholder.
618         * rendering/RenderTextControl.cpp:
619         (WebCore::RenderTextControl::createResultsButtonStyle): Added an assertion.
620         (WebCore::RenderTextControl::updatePlaceholder): Added. Replaces the two
621         functions, showPlaceholderIfNeeded and hidePlaceholderIfNeeded.
622         (WebCore::RenderTextControl::updateFromElement): Added call to
623         updatePlaceholder before updating the value. Also improved the structure
624         of the function and corrected incorrect use of copy and replace.
625         (WebCore::RenderTextControl::updateCancelButtonVisibility): Added an
626         assertion and removed an unneeded local variable.
627         (WebCore::RenderTextControl::subtreeHasChanged): Removed an unneeded
628         null check and virtual function calls.
629         (WebCore::RenderTextControl::forwardEvent): Replaced calls to the old
630         functions with calls to updatePlaceholder.
631         (WebCore::RenderTextControl::selectionChanged): Changed code to dispatch
632         the select event directly -- I plan to remove the onSelect function, which
633         was only called here.
634         (WebCore::RenderTextControl::autosaveName): Removed too-specific cast and
635         local variable.
636         (WebCore::RenderTextControl::addSearchResult): Added assertion and changed
637         variable name for clarity.
638         (WebCore::RenderTextControl::valueChanged): Changed code to check for empty
639         autosave name instead of null for consistency with other call sites that
640         manage the autosave name. Also changed the code that dispatches an event
641         to call onSearch on the input element so we don't need our own function.
642
643 2007-01-15  Eric Seidel  <eric@webkit.org>
644
645         Reviewed by hyatt.
646
647         Fix SVGStyledElement::parseMappedAttribute to only map SVG-allowed CSS properties
648         (i.e. width is no longer mapped to CSS for SVG)
649         Add SVGStyledElement::mapToEntry to allow RenderStyle-sharing
650         http://bugs.webkit.org/show_bug.cgi?id=12060
651
652         * dom/MappedAttributeEntry.h:
653         (WebCore::):
654         * ksvg2/svg/SVGStyledElement.cpp:
655         (WebCore::cssPropertyIdForName): new helper
656         (WebCore::mapAttributeToCSSProperty): new helper
657         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): new helper
658         (WebCore::SVGStyledElement::mapToEntry): added.
659         (WebCore::SVGStyledElement::parseMappedAttribute): use cssPropertyIdForSVGAttributeName
660         * ksvg2/svg/SVGStyledElement.h:
661
662 2007-01-15  Eric Seidel  <eric@webkit.org>
663
664         Reviewed by bdash.
665
666         Update header guards to follow new style guidelines using new clean-header-guards script.
667
668         * bindings/js/JSHTMLElementWrapperFactory.h:
669         * bindings/js/JSHTMLInputElementBase.h:
670         * bindings/js/JSHTMLOptionElementConstructor.h:
671         * bindings/js/JSSVGElementWrapperFactory.h:
672         * bindings/js/JSSVGPODTypeWrapper.h:
673         * bindings/js/JSXMLHttpRequest.h:
674         * bindings/js/JSXSLTProcessor.h:
675         * bindings/js/kjs_binding.h:
676         * bindings/js/kjs_css.h:
677         * bindings/js/kjs_dom.h:
678         * bindings/js/kjs_domnode.h:
679         * bindings/js/kjs_events.h:
680         * bindings/js/kjs_html.h:
681         * bindings/js/kjs_navigator.h:
682         * bindings/js/kjs_proxy.h:
683         * bindings/js/kjs_traversal.h:
684         * bindings/js/kjs_window.h:
685         * bridge/EditorClient.h:
686         * bridge/History.h:
687         * css/CSSStyleSheet.h:
688         * css/CSSValue.h:
689         * css/CSSValueList.h:
690         * css/DashboardRegion.h:
691         * css/FontFamilyValue.h:
692         * css/FontValue.h:
693         * css/MediaFeatureNames.h:
694         * css/MediaList.h:
695         * css/Pair.h:
696         * css/RectImpl.h:
697         * css/ShadowValue.h:
698         * css/StyleBase.h:
699         * css/StyleList.h:
700         * css/StyleSheet.h:
701         * css/StyleSheetList.h:
702         * css/cssstyleselector.h:
703         * dom/BeforeTextInsertedEvent.h:
704         * dom/CDATASection.h:
705         * dom/CharacterData.h:
706         * dom/ChildNodeList.h:
707         * dom/Comment.h:
708         * dom/DOMImplementation.h:
709         * dom/DocPtr.h:
710         * dom/Document.h:
711         * dom/DocumentFragment.h:
712         * dom/DocumentMarker.h:
713         * dom/DocumentType.h:
714         * dom/EditingText.h:
715         * dom/Entity.h:
716         * dom/EntityReference.h:
717         * dom/EventNames.h:
718         * dom/EventTargetNode.h:
719         * dom/NameNodeList.h:
720         * dom/NamedNodeMap.h:
721         * dom/Node.h:
722         * dom/NodeList.h:
723         * dom/Notation.h:
724         * dom/Position.h:
725         * dom/ProcessingInstruction.h:
726         * dom/Range.h:
727         * dom/StyleElement.h:
728         * dom/Text.h:
729         * editing/AppendNodeCommand.h:
730         * editing/ApplyStyleCommand.h:
731         * editing/BreakBlockquoteCommand.h:
732         * editing/CommandByName.h:
733         * editing/CompositeEditCommand.h:
734         * editing/DeleteButton.h:
735         * editing/DeleteButtonController.h:
736         * editing/DeleteFromTextNodeCommand.h:
737         * editing/DeleteSelectionCommand.h:
738         * editing/InsertIntoTextNodeCommand.h:
739         * editing/InsertLineBreakCommand.h:
740         * editing/InsertNodeBeforeCommand.h:
741         * editing/InsertParagraphSeparatorCommand.h:
742         * editing/InsertTextCommand.h:
743         * editing/JoinTextNodesCommand.h:
744         * editing/MergeIdenticalElementsCommand.h:
745         * editing/ModifySelectionListLevel.h:
746         * editing/MoveSelectionCommand.h:
747         * editing/RemoveCSSPropertyCommand.h:
748         * editing/RemoveNodeAttributeCommand.h:
749         * editing/RemoveNodeCommand.h:
750         * editing/RemoveNodePreservingChildrenCommand.h:
751         * editing/ReplaceSelectionCommand.h:
752         * editing/SetNodeAttributeCommand.h:
753         * editing/SplitElementCommand.h:
754         * editing/SplitTextNodeCommand.h:
755         * editing/SplitTextNodeContainingElementCommand.h:
756         * editing/TextGranularity.h:
757         * editing/TypingCommand.h:
758         * editing/WrapContentsInDummySpanCommand.h:
759         * history/BackForwardList.h:
760         * history/HistoryItem.h:
761         * history/HistoryItemTimer.h:
762         * history/PageCache.h:
763         * html/CanvasGradient.h:
764         * html/CanvasPattern.h:
765         * html/CanvasRenderingContext2D.h:
766         * html/CanvasStyle.h:
767         * html/FormDataList.h:
768         * html/HTMLAnchorElement.h:
769         * html/HTMLAppletElement.h:
770         * html/HTMLAreaElement.h:
771         * html/HTMLBRElement.h:
772         * html/HTMLBaseElement.h:
773         * html/HTMLBaseFontElement.h:
774         * html/HTMLBlockquoteElement.h:
775         * html/HTMLBodyElement.h:
776         * html/HTMLButtonElement.h:
777         * html/HTMLCanvasElement.h:
778         * html/HTMLCollection.h:
779         * html/HTMLDListElement.h:
780         * html/HTMLDirectoryElement.h:
781         * html/HTMLDivElement.h:
782         * html/HTMLElement.h:
783         * html/HTMLElementFactory.h:
784         * html/HTMLEmbedElement.h:
785         * html/HTMLFieldSetElement.h:
786         * html/HTMLFontElement.h:
787         * html/HTMLFormCollection.h:
788         * html/HTMLFormElement.h:
789         * html/HTMLFrameSetElement.h:
790         * html/HTMLGenericFormElement.h:
791         * html/HTMLHRElement.h:
792         * html/HTMLHeadElement.h:
793         * html/HTMLHeadingElement.h:
794         * html/HTMLHtmlElement.h:
795         * html/HTMLImageElement.h:
796         * html/HTMLImageLoader.h:
797         * html/HTMLInputElement.h:
798         * html/HTMLIsIndexElement.h:
799         * html/HTMLKeygenElement.h:
800         * html/HTMLLIElement.h:
801         * html/HTMLLabelElement.h:
802         * html/HTMLLegendElement.h:
803         * html/HTMLLinkElement.h:
804         * html/HTMLMapElement.h:
805         * html/HTMLMarqueeElement.h:
806         * html/HTMLMenuElement.h:
807         * html/HTMLMetaElement.h:
808         * html/HTMLModElement.h:
809         * html/HTMLNameCollection.h:
810         * html/HTMLOListElement.h:
811         * html/HTMLObjectElement.h:
812         * html/HTMLOptGroupElement.h:
813         * html/HTMLOptionElement.h:
814         * html/HTMLOptionsCollection.h:
815         * html/HTMLParagraphElement.h:
816         * html/HTMLParamElement.h:
817         * html/HTMLParser.h:
818         * html/HTMLPlugInElement.h:
819         * html/HTMLPreElement.h:
820         * html/HTMLQuoteElement.h:
821         * html/HTMLScriptElement.h:
822         * html/HTMLSelectElement.h:
823         * html/HTMLStyleElement.h:
824         * html/HTMLTableCaptionElement.h:
825         * html/HTMLTableCellElement.h:
826         * html/HTMLTableColElement.h:
827         * html/HTMLTableElement.h:
828         * html/HTMLTablePartElement.h:
829         * html/HTMLTableRowElement.h:
830         * html/HTMLTableSectionElement.h:
831         * html/HTMLTextAreaElement.h:
832         * html/HTMLTextFieldInnerElement.h:
833         * html/HTMLTitleElement.h:
834         * html/HTMLUListElement.h:
835         * ksvg2/css/SVGRenderStyle.h:
836         * ksvg2/css/SVGRenderStyleDefs.h:
837         * ksvg2/events/JSSVGLazyEventListener.h:
838         * ksvg2/events/SVGZoomEvent.h:
839         * ksvg2/misc/KCanvasRenderingStyle.h:
840         * ksvg2/misc/PointerEventsHitRules.h:
841         * ksvg2/misc/SVGDocumentExtensions.h:
842         * ksvg2/misc/SVGImageLoader.h:
843         * ksvg2/misc/TimeScheduler.h:
844         * ksvg2/svg/GradientAttributes.h:
845         * ksvg2/svg/LinearGradientAttributes.h:
846         * ksvg2/svg/PatternAttributes.h:
847         * ksvg2/svg/RadialGradientAttributes.h:
848         * ksvg2/svg/SVGAElement.h:
849         * ksvg2/svg/SVGAngle.h:
850         * ksvg2/svg/SVGAnimateColorElement.h:
851         * ksvg2/svg/SVGAnimateElement.h:
852         * ksvg2/svg/SVGAnimateMotionElement.h:
853         * ksvg2/svg/SVGAnimateTransformElement.h:
854         * ksvg2/svg/SVGAnimatedPathData.h:
855         * ksvg2/svg/SVGAnimatedPoints.h:
856         * ksvg2/svg/SVGAnimatedTemplate.h:
857         * ksvg2/svg/SVGAnimationElement.h:
858         * ksvg2/svg/SVGCircleElement.h:
859         * ksvg2/svg/SVGClipPathElement.h:
860         * ksvg2/svg/SVGColor.h:
861         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
862         * ksvg2/svg/SVGCursorElement.h:
863         * ksvg2/svg/SVGDOMImplementation.h:
864         * ksvg2/svg/SVGDefsElement.h:
865         * ksvg2/svg/SVGDescElement.h:
866         * ksvg2/svg/SVGDocument.h:
867         * ksvg2/svg/SVGElement.h:
868         * ksvg2/svg/SVGElementInstance.h:
869         * ksvg2/svg/SVGElementInstanceList.h:
870         * ksvg2/svg/SVGEllipseElement.h:
871         * ksvg2/svg/SVGExternalResourcesRequired.h:
872         * ksvg2/svg/SVGFEBlendElement.h:
873         * ksvg2/svg/SVGFEColorMatrixElement.h:
874         * ksvg2/svg/SVGFEComponentTransferElement.h:
875         * ksvg2/svg/SVGFECompositeElement.h:
876         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
877         * ksvg2/svg/SVGFEDisplacementMapElement.h:
878         * ksvg2/svg/SVGFEDistantLightElement.h:
879         * ksvg2/svg/SVGFEFloodElement.h:
880         * ksvg2/svg/SVGFEFuncAElement.h:
881         * ksvg2/svg/SVGFEFuncBElement.h:
882         * ksvg2/svg/SVGFEFuncGElement.h:
883         * ksvg2/svg/SVGFEFuncRElement.h:
884         * ksvg2/svg/SVGFEGaussianBlurElement.h:
885         * ksvg2/svg/SVGFEImageElement.h:
886         * ksvg2/svg/SVGFELightElement.h:
887         * ksvg2/svg/SVGFEMergeElement.h:
888         * ksvg2/svg/SVGFEMergeNodeElement.h:
889         * ksvg2/svg/SVGFEOffsetElement.h:
890         * ksvg2/svg/SVGFEPointLightElement.h:
891         * ksvg2/svg/SVGFESpecularLightingElement.h:
892         * ksvg2/svg/SVGFESpotLightElement.h:
893         * ksvg2/svg/SVGFETileElement.h:
894         * ksvg2/svg/SVGFETurbulenceElement.h:
895         * ksvg2/svg/SVGFilterElement.h:
896         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
897         * ksvg2/svg/SVGFitToViewBox.h:
898         * ksvg2/svg/SVGForeignObjectElement.h:
899         * ksvg2/svg/SVGGElement.h:
900         * ksvg2/svg/SVGGradientElement.h:
901         * ksvg2/svg/SVGImageElement.h:
902         * ksvg2/svg/SVGLangSpace.h:
903         * ksvg2/svg/SVGLength.h:
904         * ksvg2/svg/SVGLengthList.h:
905         * ksvg2/svg/SVGLineElement.h:
906         * ksvg2/svg/SVGLinearGradientElement.h:
907         * ksvg2/svg/SVGList.h:
908         * ksvg2/svg/SVGListTraits.h:
909         * ksvg2/svg/SVGLocatable.h:
910         * ksvg2/svg/SVGMarkerElement.h:
911         * ksvg2/svg/SVGMaskElement.h:
912         * ksvg2/svg/SVGMetadataElement.h:
913         * ksvg2/svg/SVGNumberList.h:
914         * ksvg2/svg/SVGPaint.h:
915         * ksvg2/svg/SVGParserUtilities.h:
916         * ksvg2/svg/SVGPathElement.h:
917         * ksvg2/svg/SVGPathSeg.h:
918         * ksvg2/svg/SVGPathSegArc.h:
919         * ksvg2/svg/SVGPathSegClosePath.h:
920         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
921         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
922         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
923         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
924         * ksvg2/svg/SVGPathSegLineto.h:
925         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
926         * ksvg2/svg/SVGPathSegLinetoVertical.h:
927         * ksvg2/svg/SVGPathSegList.h:
928         * ksvg2/svg/SVGPathSegMoveto.h:
929         * ksvg2/svg/SVGPatternElement.h:
930         * ksvg2/svg/SVGPointList.h:
931         * ksvg2/svg/SVGPolyElement.h:
932         * ksvg2/svg/SVGPolygonElement.h:
933         * ksvg2/svg/SVGPolylineElement.h:
934         * ksvg2/svg/SVGPreserveAspectRatio.h:
935         * ksvg2/svg/SVGRadialGradientElement.h:
936         * ksvg2/svg/SVGRectElement.h:
937         * ksvg2/svg/SVGRenderingIntent.h:
938         * ksvg2/svg/SVGSVGElement.h:
939         * ksvg2/svg/SVGScriptElement.h:
940         * ksvg2/svg/SVGSetElement.h:
941         * ksvg2/svg/SVGStopElement.h:
942         * ksvg2/svg/SVGStringList.h:
943         * ksvg2/svg/SVGStylable.h:
944         * ksvg2/svg/SVGStyleElement.h:
945         * ksvg2/svg/SVGStyledElement.h:
946         * ksvg2/svg/SVGStyledLocatableElement.h:
947         * ksvg2/svg/SVGStyledTransformableElement.h:
948         * ksvg2/svg/SVGSwitchElement.h:
949         * ksvg2/svg/SVGSymbolElement.h:
950         * ksvg2/svg/SVGTRefElement.h:
951         * ksvg2/svg/SVGTSpanElement.h:
952         * ksvg2/svg/SVGTests.h:
953         * ksvg2/svg/SVGTextContentElement.h:
954         * ksvg2/svg/SVGTextElement.h:
955         * ksvg2/svg/SVGTextPositioningElement.h:
956         * ksvg2/svg/SVGTitleElement.h:
957         * ksvg2/svg/SVGTransform.h:
958         * ksvg2/svg/SVGTransformList.h:
959         * ksvg2/svg/SVGTransformable.h:
960         * ksvg2/svg/SVGURIReference.h:
961         * ksvg2/svg/SVGUnitTypes.h:
962         * ksvg2/svg/SVGUseElement.h:
963         * ksvg2/svg/SVGViewElement.h:
964         * ksvg2/svg/SVGZoomAndPan.h:
965         * loader/CachedCSSStyleSheet.h:
966         * loader/CachedImage.h:
967         * loader/CachedXSLStyleSheet.h:
968         * loader/DocumentLoader.h:
969         * loader/Request.h:
970         * loader/SubresourceLoader.h:
971         * loader/icon/IconDataCache.h:
972         * loader/icon/IconDatabase.h:
973         * loader/icon/IconLoader.h:
974         * loader/icon/SQLDatabase.h:
975         * loader/icon/SQLStatement.h:
976         * loader/icon/SQLTransaction.h:
977         * page/Frame.h:
978         * page/FrameLoadRequest.h:
979         * page/FrameTree.h:
980         * page/FrameView.h:
981         * page/PageState.h:
982         * page/Plugin.h:
983         * page/qt/FrameQt.h:
984         * page/qt/FrameQtClient.h:
985         * platform/Arena.h:
986         * platform/ArrayImpl.h:
987         * platform/Cursor.h:
988         * platform/DeprecatedArray.h:
989         * platform/DeprecatedCString.h:
990         * platform/FileChooser.h:
991         * platform/Font.h:
992         * platform/FontCache.h:
993         * platform/FontData.h:
994         * platform/FontDescription.h:
995         * platform/FontFamily.h:
996         * platform/GlyphBuffer.h:
997         * platform/GlyphMap.h:
998         * platform/GlyphWidthMap.h:
999         * platform/Logging.h:
1000         * platform/Pasteboard.h:
1001         * platform/PlatformString.h:
1002         * platform/PlugInInfoStore.h:
1003         * platform/PopupMenu.h:
1004         * platform/PopupMenuClient.h:
1005         * platform/ScrollBar.h:
1006         * platform/ScrollView.h:
1007         * platform/SearchPopupMenu.h:
1008         * platform/Shared.h:
1009         * platform/Sound.h:
1010         * platform/SystemTime.h:
1011         * platform/Timer.h:
1012         * platform/Widget.h:
1013         * platform/cf/RetainPtr.h:
1014         * platform/gdk/ChromeClientGdk.h:
1015         * platform/gdk/FontPlatformData.h:
1016         * platform/gdk/FrameGdk.h:
1017         * platform/gdk/KeyboardCodes.h:
1018         * platform/gdk/RenderPopupMenuGdk.h:
1019         * platform/gdk/RenderThemeGdk.h:
1020         * platform/graphics/BitmapImage.h:
1021         * platform/graphics/Color.h:
1022         * platform/graphics/FloatPoint.h:
1023         * platform/graphics/FloatPoint3D.h:
1024         * platform/graphics/FloatRect.h:
1025         * platform/graphics/Icon.h:
1026         * platform/graphics/Image.h:
1027         * platform/graphics/ImageAnimationObserver.h:
1028         * platform/graphics/ImageBuffer.h:
1029         * platform/graphics/ImageSource.h:
1030         * platform/graphics/IntPoint.h:
1031         * platform/graphics/IntRect.h:
1032         * platform/graphics/IntSize.h:
1033         * platform/graphics/IntSizeHash.h:
1034         * platform/graphics/PathTraversalState.h:
1035         * platform/graphics/Pen.h:
1036         * platform/graphics/qt/ImageDecoderQt.h:
1037         * platform/graphics/svg/SVGImage.h:
1038         * platform/graphics/svg/SVGImageEmptyClients.h:
1039         * platform/graphics/svg/SVGPaintServer.h:
1040         * platform/graphics/svg/SVGPaintServerGradient.h:
1041         * platform/graphics/svg/SVGPaintServerLinearGradient.h:
1042         * platform/graphics/svg/SVGPaintServerPattern.h:
1043         * platform/graphics/svg/SVGPaintServerRadialGradient.h:
1044         * platform/graphics/svg/SVGPaintServerSolid.h:
1045         * platform/graphics/svg/SVGResource.h:
1046         * platform/graphics/svg/SVGResourceClipper.h:
1047         * platform/graphics/svg/SVGResourceFilter.h:
1048         * platform/graphics/svg/SVGResourceMarker.h:
1049         * platform/graphics/svg/SVGResourceMasker.h:
1050         * platform/graphics/svg/cg/CgSupport.h:
1051         * platform/graphics/svg/filters/SVGDistantLightSource.h:
1052         * platform/graphics/svg/filters/SVGFEBlend.h:
1053         * platform/graphics/svg/filters/SVGFEColorMatrix.h:
1054         * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
1055         * platform/graphics/svg/filters/SVGFEComposite.h:
1056         * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
1057         * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
1058         * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
1059         * platform/graphics/svg/filters/SVGFEFlood.h:
1060         * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
1061         * platform/graphics/svg/filters/SVGFEImage.h:
1062         * platform/graphics/svg/filters/SVGFEMerge.h:
1063         * platform/graphics/svg/filters/SVGFEMorphology.h:
1064         * platform/graphics/svg/filters/SVGFEOffset.h:
1065         * platform/graphics/svg/filters/SVGFESpecularLighting.h:
1066         * platform/graphics/svg/filters/SVGFETile.h:
1067         * platform/graphics/svg/filters/SVGFETurbulence.h:
1068         * platform/graphics/svg/filters/SVGFilterEffect.h:
1069         * platform/graphics/svg/filters/SVGLightSource.h:
1070         * platform/graphics/svg/filters/SVGPointLightSource.h:
1071         * platform/graphics/svg/filters/SVGSpotLightSource.h:
1072         * platform/mac/FontPlatformData.h:
1073         * platform/mac/PlatformScrollBar.h:
1074         * platform/network/AuthenticationChallenge.h:
1075         * platform/network/Credential.h:
1076         * platform/network/HTTPHeaderMap.h:
1077         * platform/network/ProtectionSpace.h:
1078         * platform/network/ResourceError.h:
1079         * platform/network/ResourceRequest.h:
1080         * platform/network/ResourceResponse.h:
1081         * platform/network/cf/FormDataStreamCFNet.h:
1082         * platform/network/cf/ResourceRequestCFNet.h:
1083         * platform/network/cf/ResourceResponseCFNet.h:
1084         * platform/network/gdk/ResourceHandleManager.h:
1085         * platform/network/mac/AuthenticationMac.h:
1086         * platform/network/mac/FormDataStreamMac.h:
1087         * platform/network/qt/ResourceHandleManagerKDE.h:
1088         * platform/network/qt/ResourceHandleManagerQt.h:
1089         * platform/network/win/ResourceHandleWin.h:
1090         * platform/qt/FontPlatformData.h:
1091         * platform/qt/KeyboardCodes.h:
1092         * platform/qt/PlatformScrollBar.h:
1093         * platform/qt/ScrollViewCanvasQt.h:
1094         * platform/qt/SharedTimerQt.h:
1095         * platform/win/FontPlatformData.h:
1096         * platform/win/PlatformScrollBar.h:
1097         * rendering/AutoTableLayout.h:
1098         * rendering/HitTestRequest.h:
1099         * rendering/HitTestResult.h:
1100         * rendering/InlineBox.h:
1101         * rendering/InlineFlowBox.h:
1102         * rendering/Length.h:
1103         * rendering/ListMarkerBox.h:
1104         * rendering/RenderBox.h:
1105         * rendering/RenderMenuList.h:
1106         * rendering/RenderPart.h:
1107         * rendering/RenderPartObject.h:
1108         * rendering/RenderPath.h:
1109         * rendering/RenderReplaced.h:
1110         * rendering/RenderSVGContainer.h:
1111         * rendering/RenderSVGImage.h:
1112         * rendering/RenderSVGInline.h:
1113         * rendering/RenderSVGInlineText.h:
1114         * rendering/RenderSVGTSpan.h:
1115         * rendering/RenderSVGText.h:
1116         * rendering/RenderStyle.h:
1117         * rendering/RenderTableCol.h:
1118         * rendering/RenderThemeWin.h:
1119         * rendering/bidi.h:
1120         * xml/DOMParser.h:
1121         * xml/XPathEvaluator.h:
1122         * xml/XPathExpression.h:
1123         * xml/XPathExpressionNode.h:
1124         * xml/XPathFunctions.h:
1125         * xml/XPathNSResolver.h:
1126         * xml/XPathNamespace.h:
1127         * xml/XPathParser.h:
1128         * xml/XPathPath.h:
1129         * xml/XPathPredicate.h:
1130         * xml/XPathResult.h:
1131         * xml/XPathStep.h:
1132         * xml/XPathUtil.h:
1133         * xml/XPathValue.h:
1134         * xml/XPathVariableReference.h:
1135         * xml/XSLImportRule.h:
1136         * xml/XSLStyleSheet.h:
1137         * xml/XSLTProcessor.h:
1138         * xml/xmlhttprequest.h:
1139
1140 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
1141
1142         Build fix.
1143         
1144         * loader/ProgressTracker.cpp:
1145
1146 2007-01-15  Lars Knoll <lars@trolltech.com>
1147
1148         Fix the Qt build
1149
1150         * WebCore.pro:
1151
1152 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
1153
1154         Reviewed by Darin.
1155
1156         * loader/ProgressTracker.cpp:
1157         Set finalProgressValue to its value explicitly instead of calculating it 
1158         (which causes a global initializer to be generated).
1159
1160 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
1161
1162         Reviewed by Darin and Adam.
1163
1164         Move progress tracking down to WebCore.
1165         
1166         * WebCore.exp:
1167         Add ProgressTracker::estimatedProgress() to be used by WebKit.
1168         
1169         * WebCore.xcodeproj/project.pbxproj:
1170         Add ProgressTracker.[cpp|h]
1171         
1172         * loader/FrameLoader.cpp:
1173         (WebCore::FrameLoader::prepareForLoadStart):
1174         (WebCore::FrameLoader::clearProvisionalLoad):
1175         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1176         (WebCore::FrameLoader::startLoading):
1177         (WebCore::FrameLoader::didReceiveResponse):
1178         (WebCore::FrameLoader::didReceiveData):
1179         (WebCore::FrameLoader::didFailToLoad):
1180         (WebCore::FrameLoader::requestFromDelegate):
1181         (WebCore::FrameLoader::didFinishLoad):
1182         Call directly to the progress tracker instead of through the frame loader client.
1183         
1184         * loader/FrameLoaderClient.h:
1185         Get rid of the old methods and add new methods for tracking progress.
1186         
1187         * loader/ProgressTracker.cpp: Added.
1188         (WebCore::ProgressItem::ProgressItem):
1189         (WebCore::ProgressTracker::ProgressTracker):
1190         (WebCore::ProgressTracker::~ProgressTracker):
1191         (WebCore::ProgressTracker::estimatedProgress):
1192         (WebCore::ProgressTracker::reset):
1193         (WebCore::ProgressTracker::progressStarted):
1194         (WebCore::ProgressTracker::progressCompleted):
1195         (WebCore::ProgressTracker::finalProgressComplete):
1196         (WebCore::ProgressTracker::incrementProgress):
1197         (WebCore::ProgressTracker::completeProgress):
1198         (WebCore::ProgressTracker::createUniqueIdentifier):
1199         * loader/ProgressTracker.h: Added.
1200         New per page class which tracks progress.
1201         
1202         * loader/ResourceLoader.cpp:
1203         (WebCore::ResourceLoader::willSendRequest):
1204         * page/Page.cpp:
1205         (WebCore::Page::Page):
1206         * page/Page.h:
1207         (WebCore::Page::progress):
1208         Move createUniqueIdentifier to ProgressTracker, add ProgressTracker object to Page.
1209         
1210         * platform/graphics/svg/SVGImageEmptyClients.h:
1211         (WebCore::SVGEmptyFrameLoaderClient::willChangeEstimatedProgress):
1212         (WebCore::SVGEmptyFrameLoaderClient::didChangeEstimatedProgress):
1213         (WebCore::SVGEmptyFrameLoaderClient::postProgressStartedNotification):
1214         (WebCore::SVGEmptyFrameLoaderClient::postProgressEstimateChangedNotification):
1215         (WebCore::SVGEmptyFrameLoaderClient::postProgressFinishedNotification):
1216         Add new methods, get rid of the old ones.
1217
1218 2007-01-15  Adam Roben  <aroben@apple.com>
1219
1220         Reviewed by Anders.
1221
1222         Fix comment.
1223
1224         * html/HTMLScriptElement.cpp:
1225         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
1226
1227 2007-01-15  John Sullivan  <sullivan@apple.com>
1228
1229         * platform/ContextMenu.cpp:
1230         (WebCore::ContextMenu::checkOrEnableIfNeeded):
1231         Leopard build fix; don't declare one of the case values twice
1232
1233 2007-01-15  Mitz Pettel  <mitz@webkit.org>
1234
1235         Reviewed by Darin.
1236
1237         - fix http://bugs.webkit.org/show_bug.cgi?id=8604
1238           rowspan does not work when set through javascript
1239
1240         Covered by existing tests.
1241
1242         * rendering/RenderTableCell.cpp:
1243         (WebCore::RenderTableCell::updateFromElement): Mark the section for grid recalc
1244         if row span or column span change.
1245
1246 2007-01-15  Adam Roben  <aroben@apple.com>
1247
1248         Reviewed by Darin.
1249
1250         Small context menu fixes.
1251
1252         * platform/ContextMenu.cpp:
1253         (WebCore::ContextMenu::populate): Fix typo.
1254         (WebCore::ContextMenu::checkOrEnableIfNeeded): Disabled "No Guesses
1255         Found", and added all enum values explicitly.
1256
1257 2007-01-15  Alexey Proskuryakov  <ap@webkit.org>
1258
1259         Reviewed by Darin.
1260
1261         http://bugs.webkit.org/show_bug.cgi?id=6272
1262         XMLHttpRequest freezes on getting a missing document with overridden Content-Length
1263
1264         http://bugs.webkit.org/show_bug.cgi?id=6212
1265         Investigate disallowing some XMLHttpRequest headers from being set via setRequestHeader.
1266
1267         Tests:
1268         - http/tests/xmlhttprequest/connection-error-sync.html
1269         - http/tests/xmlhttprequest/set-dangerous-headers.html
1270
1271         * bindings/js/kjs_binding.cpp:
1272         (KJS::):
1273         (KJS::setDOMException): Added support for NETWORK_ERR. Changed the temporary 
1274         PERMISSION_DENIED error into a special case.
1275
1276         * loader/FrameLoader.cpp:
1277         (WebCore::FrameLoader::loadResourceSynchronously):
1278         * loader/FrameLoader.h:
1279         Return the error object to the caller. Removed an extra local variable for error, 
1280         which shadowed the one from enclosing block.
1281
1282         * dom/XMLTokenizer.cpp:
1283         (WebCore::openFunc): 
1284         * xml/XSLTProcessor.cpp:
1285         (WebCore::docLoaderFunc): 
1286         Updated to pass an error object (currently ignored).
1287
1288         * xml/xmlhttprequest.cpp:
1289         (WebCore::canSetRequestHeader): Added. The headers to block include the ones from 
1290         the current XMLHttpRequest draft plus "Via", which is blocked by Firefox.
1291         (WebCore::XMLHttpRequest::send): Raise an exception if a sync request results in 
1292         an error.
1293         (WebCore::XMLHttpRequest::setRequestHeader): Call canSetRequestHeader().
1294         * xml/xmlhttprequest.h:
1295         (WebCore::): Added NETWORK_ERR and a comment about PERMISSION_DENIED.
1296
1297 2007-01-15  Zack Rusin  <zack@kde.org>
1298
1299         Optimizing rendering on the Qt platform. Mainly
1300         switching from client side QImage to QPixmap's.
1301         Also cleaning the the ScrollViewCanvasQt code
1302         quite a bit.
1303
1304         * platform/graphics/ImageSource.h: use QPixmap
1305         * platform/graphics/qt/GraphicsContextQt.cpp:
1306         (WebCore::TransparencyLayer::TransparencyLayer):
1307         (WebCore::GraphicsContext::clip): clip rects when you can
1308         * platform/graphics/qt/ImageDecoderQt.cpp:
1309         (WebCore::ImageDecoderQt::ImageData::ImageData):
1310         (WebCore::ImageDecoderQt::ReadContext::read):
1311         (WebCore::ImageDecoderQt::ReadContext::readImageLines):
1312         (WebCore::ImageDecoderQt::imageAtIndex):
1313         * platform/graphics/qt/ImageDecoderQt.h: use QPixmap
1314         * platform/graphics/qt/ImageQt.cpp: QPixmap instead of QImage
1315         (WebCore::BitmapImage::draw):
1316         (WebCore::BitmapImage::drawTiled):
1317         * platform/graphics/qt/ImageSourceQt.cpp:
1318         (WebCore::):
1319         (WebCore::ImageSource::createFrameAtIndex):
1320         (WebCore::ImageSource::frameHasAlphaAtIndex):
1321         * platform/qt/ScrollViewCanvasQt.cpp: clean up
1322         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
1323         (WebCore::ScrollViewCanvasQt::updateFrameView):
1324         (WebCore::ScrollViewCanvasQt::paintEvent):
1325         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
1326         (WebCore::ScrollViewCanvasQt::mousePressEvent):
1327         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
1328         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
1329         * platform/qt/ScrollViewCanvasQt.h:
1330         * platform/qt/ScrollViewQt.cpp: remove hacks
1331         (WebCore::ScrollView::ScrollView):
1332         (WebCore::ScrollView::setParentWidget):
1333         (WebCore::ScrollView::updateContents):
1334
1335 2007-01-15  Lars Knoll <lars@trolltech.com>
1336
1337         Reviewed by Zack
1338
1339         Fix weird crashes when running the layout tests. The
1340         reason was that I used KURL (and thus DeprecatedString)
1341         in a thread. Unfortunately that class is not threadsafe
1342         at all.
1343
1344         * platform/network/qt/ResourceHandleManagerQt.cpp:
1345         (WebCore::RequestQt::RequestQt):
1346         (WebCore::RequestQt::setURL):
1347         (WebCore::ResourceHandleManager::add):
1348         (WebCore::ResourceHandleManager::cancel):
1349         (WebCore::ResourceHandleManager::receivedResponse):
1350         (WebCore::FileLoader::request):
1351         (WebCore::HostInfo::HostInfo):
1352         (WebCore::NetworkLoader::request):
1353         (WebCore::NetworkLoader::cancel):
1354         * platform/network/qt/ResourceHandleManagerQt.h:
1355         (WebCore::HostInfo::HostInfo):
1356         (WebCore::HostInfo::isLocalFile):
1357
1358 2007-01-15  Eric Seidel  <eric@webkit.org>
1359
1360         Reviewed by rwlbuis.
1361
1362         Make isValid check not malloc 3 SVGStringLists for every element.
1363         
1364         No test possible, performance fix only.
1365
1366         * ksvg2/svg/SVGTests.cpp:
1367         (WebCore::SVGTests::isValid):
1368
1369 2007-01-15  Rob Buis  <buis@kde.org>
1370
1371         Reviewed by Eric.
1372
1373         Remove unused member var.
1374
1375         * ksvg2/svg/SVGStyledElement.h:
1376
1377 2007-01-15  Rob Buis  <buis@kde.org>
1378
1379         Reviewed by Eric.
1380
1381         http://bugs.webkit.org/show_bug.cgi?id=12069
1382         Hit detection fails under some viewbox constraints
1383
1384         Do not take viewBox into account when hit testing svg container.
1385
1386         * rendering/RenderSVGContainer.cpp:
1387         (WebCore::RenderSVGContainer::nodeAtPoint):
1388
1389 2007-01-15  David Hyatt  <hyatt@apple.com>
1390
1391         Fix  for 12275, negative margins confuse page breaks.
1392
1393         Reviewed by Eric
1394
1395         * rendering/RenderBlock.cpp:
1396         (WebCore::RenderBlock::paintChildren):
1397
1398 2007-01-15  Eric Seidel  <eric@webkit.org>
1399
1400         Reviewed by mjs.
1401         
1402         SVG gradients do not notice stop additions
1403         http://bugs.webkit.org/show_bug.cgi?id=12192
1404
1405         Test: svg/custom/gradient-add-stops.svg
1406
1407         * ksvg2/svg/SVGGradientElement.cpp:
1408         (WebCore::SVGGradientElement::childrenChanged):
1409         * ksvg2/svg/SVGGradientElement.h:
1410
1411 2007-01-14  David Hyatt  <hyatt@apple.com>
1412
1413         Fix for bug 10356, positioning doesn't work with <svg> elements in XHTML.  Change the requiresLayer
1414         check to use the DOM, since the old check would fail if the parent block had no element.
1415
1416         Reviewed by Eric
1417
1418         Added svg/custom/relative-positioning.html (absolute/fixed too)
1419
1420         * rendering/RenderSVGContainer.cpp:
1421         (WebCore::RenderSVGContainer::requiresLayer):
1422
1423 2007-01-14  Eric Seidel  <eric@webkit.org>
1424
1425         Reviewed by hyatt.
1426         
1427         SVG does not correctly handle float: left
1428         http://bugs.webkit.org/show_bug.cgi?id=12210
1429
1430         Test: svg/custom/svg-float-border-padding.xml
1431
1432         * rendering/RenderSVGContainer.cpp:
1433         (WebCore::RenderSVGContainer::paint):
1434
1435 2007-01-14  David Hyatt  <hyatt@apple.com>
1436
1437         More work to fix 10145, regression where form elements don't break properly.  Make sure to really use
1438         the parent of the replaced element's whitespace value everywhere.
1439
1440         Reviewed by olliej
1441
1442         fast/replaced/three-selects-break.html
1443
1444         * rendering/bidi.cpp:
1445         (WebCore::RenderBlock::findNextLineBreak):
1446
1447 2007-01-14  Sam Weinig  <sam@webkit.org>
1448
1449         Reviewed by Darin and then by Mitz.
1450
1451         Patch for http://bugs.webkit.org/show_bug.cgi?id=12228
1452         Cleanup assorted CSS classes
1453
1454         * css/CSSBorderImageValue.cpp:
1455         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
1456         (WebCore::CSSBorderImageValue::cssText):
1457         * css/CSSBorderImageValue.h:
1458         * css/CSSComputedStyleDeclaration.cpp:
1459         (WebCore::valueForLength):
1460         (WebCore::valueForBorderStyle):
1461         (WebCore::valueForTextAlign):
1462         (WebCore::valueForShadow):
1463         (WebCore::getPositionOffsetValue):
1464         (WebCore::CSSComputedStyleDeclaration::cssText):
1465         (WebCore::primitiveValueFromLength):
1466         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1467         (WebCore::CSSComputedStyleDeclaration::getPropertyPriority):
1468         (WebCore::CSSComputedStyleDeclaration::removeProperty):
1469         (WebCore::CSSComputedStyleDeclaration::setProperty):
1470         (WebCore::CSSComputedStyleDeclaration::length):
1471         (WebCore::CSSComputedStyleDeclaration::item):
1472         * css/CSSComputedStyleDeclaration.h:
1473         * css/CSSCursorImageValue.cpp:
1474         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1475         * css/CSSCursorImageValue.h:
1476         * css/CSSGrammar.y:
1477         * css/CSSImageValue.cpp:
1478         * css/CSSImageValue.h:
1479         * css/CSSInheritedValue.cpp:
1480         * css/CSSInheritedValue.h:
1481         * css/CSSInitialValue.cpp:
1482         * css/CSSInitialValue.h:
1483         * css/CSSMutableStyleDeclaration.cpp:
1484         (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
1485         (WebCore::CSSMutableStyleDeclaration::operator=):
1486         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
1487         (WebCore::CSSMutableStyleDeclaration::get4Values):
1488         (WebCore::CSSMutableStyleDeclaration::getShorthandValue):
1489         (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
1490         (WebCore::CSSMutableStyleDeclaration::removeProperty):
1491         (WebCore::CSSMutableStyleDeclaration::setChanged):
1492         (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
1493         (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
1494         (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
1495         (WebCore::CSSMutableStyleDeclaration::setProperty):
1496         (WebCore::CSSMutableStyleDeclaration::setImageProperty):
1497         (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
1498         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
1499         (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
1500         (WebCore::CSSMutableStyleDeclaration::cssText):
1501         (WebCore::CSSMutableStyleDeclaration::merge):
1502         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
1503         * css/CSSMutableStyleDeclaration.h:
1504         (WebCore::CSSMutableStyleDeclaration::setProperty):
1505         (WebCore::CSSMutableStyleDeclaration::removeProperty):
1506         * css/CSSNamespace.h:
1507         (WebCore::CSSNamespace::CSSNamespace):
1508         * css/CSSPrimitiveValue.cpp:
1509         (WebCore::isCSSTokenizerIdentifier):
1510         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1511         (WebCore::CSSPrimitiveValue::cleanup):
1512         (WebCore::CSSPrimitiveValue::computeLengthInt):
1513         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
1514         (WebCore::CSSPrimitiveValue::computeLengthShort):
1515         (WebCore::CSSPrimitiveValue::computeLengthFloat):
1516         (WebCore::CSSPrimitiveValue::setFloatValue):
1517         (WebCore::scaleFactorForConversion):
1518         (WebCore::CSSPrimitiveValue::getFloatValue):
1519         (WebCore::CSSPrimitiveValue::setStringValue):
1520         (WebCore::CSSPrimitiveValue::getStringValue):
1521         (WebCore::CSSPrimitiveValue::parseString):
1522         (WebCore::CSSPrimitiveValue::getIdent):
1523         (WebCore::CSSPrimitiveValue::cssText):
1524         * css/CSSPrimitiveValue.h:
1525         (WebCore::CSSPrimitiveValue::getCounterValue):
1526         (WebCore::CSSPrimitiveValue::getRectValue):
1527         (WebCore::CSSPrimitiveValue::getRGBColorValue):
1528         (WebCore::CSSPrimitiveValue::getPairValue):
1529         (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
1530         * css/CSSProperty.cpp:
1531         (WebCore::operator==):
1532         * css/CSSProperty.h:
1533         (WebCore::CSSProperty::operator=):
1534         * css/CSSQuirkPrimitiveValue.h:
1535         (WebCore::CSSQuirkPrimitiveValue::CSSQuirkPrimitiveValue):
1536         * css/CSSRuleList.cpp:
1537         (WebCore::CSSRuleList::CSSRuleList):
1538         (WebCore::CSSRuleList::deleteRule):
1539         (WebCore::CSSRuleList::insertRule):
1540         * css/CSSRuleList.h:
1541         (WebCore::CSSRuleList::item):
1542         * css/CSSSelector.cpp:
1543         (WebCore::CSSSelector::print):
1544         (WebCore::CSSSelector::specificity):
1545         (WebCore::CSSSelector::extractPseudoType):
1546         (WebCore::CSSSelector::operator==):
1547         (WebCore::CSSSelector::selectorText):
1548         * css/CSSSelector.h:
1549         (WebCore::CSSSelector::CSSSelector):
1550         (WebCore::CSSSelector::~CSSSelector):
1551         (WebCore::CSSSelector::append):
1552         (WebCore::CSSSelector::next):
1553         (WebCore::CSSSelector::pseudoType):
1554         (WebCore::CSSSelector::hasTag):
1555         (WebCore::CSSSelector::hasAttribute):
1556         * css/CSSStyleDeclaration.cpp:
1557         (WebCore::propertyID):
1558         (WebCore::CSSStyleDeclaration::getPropertyPriority):
1559         (WebCore::CSSStyleDeclaration::getPropertyShorthand):
1560         (WebCore::CSSStyleDeclaration::isPropertyImplicit):
1561         (WebCore::CSSStyleDeclaration::setProperty):
1562         (WebCore::CSSStyleDeclaration::isPropertyName):
1563         (WebCore::CSSStyleDeclaration::parentRule):
1564         (WebCore::CSSStyleDeclaration::diff):
1565         (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
1566         * css/CSSStyleDeclaration.h:
1567         * css/Counter.h:
1568         (WebCore::Counter::Counter):
1569         (WebCore::Counter::listStyleNumber):
1570         * css/csshelper.cpp:
1571         (WebCore::parseURL):
1572         * css/csshelper.h:
1573         * css/cssparser.h:
1574         (WebCore::domString):
1575         (WebCore::atomicString):
1576         (WebCore::CSSParser::operator|):
1577         * css/cssstyleselector.cpp:
1578         (WebCore::CSSStyleSelector::matchRulesForList):
1579         (WebCore::CSSStyleSelector::checkSelector):
1580         (WebCore::CSSStyleSelector::checkOneSelector):
1581         (WebCore::CSSRuleSet::addRule):
1582
1583 2007-01-14  Mitz Pettel  <mitz@webkit.org>
1584
1585         Reviewed by Adam.
1586
1587         - fix http://bugs.webkit.org/show_bug.cgi?id=12264
1588           REGRESSION (r18843): Webkit crashes on 43Folders.com home page
1589
1590         Test: fast/tokenizer/ignore-tags-in-iframe.html
1591
1592         * html/HTMLParser.cpp:
1593         (WebCore::HTMLParser::reset): Removed unused inSelect member variable.
1594         (WebCore::HTMLParser::selectCreateErrorCheck): Ditto.
1595         (WebCore::HTMLParser::processCloseTag): Ditto.
1596         * html/HTMLParser.h: Ditto.
1597         * html/HTMLTokenizer.cpp:
1598         (WebCore::HTMLTokenizer::parseTag): Changed not to process <pre>, <listing>,
1599         <script>, <style>, <title>, <textarea> and <xmp> if the parser is in skip mode
1600         (waiting for a close tag of an element whose contents are not parsed,
1601         such as iframe).
1602         * html/HTMLTokenizer.h:
1603         (WebCore::HTMLTokenizer::State::setInStyle): Removed unused bit.
1604         (WebCore::HTMLTokenizer::State::): Ditto.
1605
1606 2007-01-14  Alexey Proskuryakov  <ap@webkit.org>
1607
1608         Reviewed by Darin.
1609
1610         http://bugs.webkit.org/show_bug.cgi?id=12258
1611         fast/tokenizer/002 test broken
1612
1613         * loader/FrameLoader.h: Added a flush parameter to write().
1614         * loader/FrameLoader.cpp:
1615         (WebCore::FrameLoader::write): Ditto.
1616         (WebCore::FrameLoader::endIfNotLoading): Instead of poorly duplicating the logic in write(),
1617         call it directly.
1618
1619 2007-01-14  Adam Roben  <aroben@apple.com>
1620
1621         Reviewed by Maciej.
1622
1623         Make sure our whitelisting of the type and language attributes of the
1624         <script> element is enforced in all HTMLTokenizer/HTMLScriptElement
1625         code paths.
1626
1627         All layout tests pass.
1628
1629         * html/HTMLScriptElement.cpp:
1630         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): New method to
1631         determine whether the script should be executed, given its type and
1632         language attributes.
1633         (WebCore::HTMLScriptElement::evaluateScript): Check type/language
1634         before executing.
1635         * html/HTMLScriptElement.h: Added new declarations.
1636         * html/HTMLTokenizer.cpp:
1637         (WebCore::HTMLTokenizer::begin): Made scriptSrc a String. 
1638         (WebCore::HTMLTokenizer::scriptHandler): Check
1639         shouldExecuteAsJavaScript before executing.
1640         (WebCore::HTMLTokenizer::notifyFinished): Ditto.
1641         (WebCore::HTMLTokenizer::parseTag): Moved type/language checking from
1642         here to HTMLScriptElement::shouldExecuteAsJavaScript.
1643         * html/HTMLTokenizer.h: Made scriptSrc a String, and removed the
1644         javascript member.
1645
1646 2007-01-14  David Hyatt  <hyatt@apple.com>
1647
1648         Make sure floats are avoided if you have non-auto column property values.  Fixes the crazy layout
1649         on http://weblogs.mozillazine.org/roc.
1650
1651         Reviewed by mitz
1652
1653         Added fast/multicol/float-avoidance.html
1654
1655         * rendering/RenderBlock.cpp:
1656         (WebCore::RenderBlock::avoidsFloats):
1657
1658 2007-01-14  David Hyatt  <hyatt@apple.com>
1659
1660         Fix for 10145, regression where line breaks are not being honored between adjacent replaced elements.
1661         When checking for break opportunities where replaced elements are involved, we ignore their white-space
1662         values and use their parents' instead.  The assumption/idea behind this change is that because the element
1663         is replaced, its white-space value is irrelevant except as a means of applying style to its interior.
1664
1665         The CSS spec does not cover this situation, so we're implementing this based off what other browsers seem to
1666         do.
1667
1668         Reviewed by aroben
1669
1670         * css/CSSComputedStyleDeclaration.cpp:
1671         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1672         * css/CSSValueKeywords.in:
1673         * css/cssparser.cpp:
1674         (WebCore::CSSParser::parseValue):
1675         * css/cssstyleselector.cpp:
1676         (WebCore::CSSStyleSelector::applyProperty):
1677         * page/EventHandler.cpp:
1678         (WebCore::EventHandler::EventHandler):
1679         (WebCore::EventHandler::clear):
1680         (WebCore::EventHandler::handleWheelEvent):
1681         * page/EventHandler.h:
1682         * rendering/RenderBox.cpp:
1683         (WebCore::RenderBox::calcHeight):
1684         * rendering/RenderLayer.cpp:
1685         (WebCore::Marquee::Marquee):
1686         (WebCore::Marquee::start):
1687         (WebCore::Marquee::updateMarqueePosition):
1688         (WebCore::Marquee::updateMarqueeStyle):
1689         (WebCore::Marquee::timerFired):
1690         * rendering/RenderLayer.h:
1691         * rendering/RenderPartObject.cpp:
1692         (WebCore::RenderPartObject::viewCleared):
1693         * rendering/RenderStyle.h:
1694         (WebCore::):
1695         * rendering/bidi.cpp:
1696         (WebCore::RenderBlock::findNextLineBreak):
1697
1698 2007-01-13  David Hyatt  <hyatt@apple.com>
1699
1700         While optimizing form controls and fixing their clipping, I caused this text zoom regression.  The layout
1701         of text is necessary because it needs to recalc minmaxwidth.  This is still a really unfortunate
1702         bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
1703         as dirty when we don't have to.
1704
1705         Reviewed by mitz
1706
1707         * rendering/RenderObject.cpp:
1708         (WebCore::RenderObject::setStyle):
1709
1710 2007-01-13  Lars Knoll <lars@trolltech.com>
1711
1712         Reviewed by Alexey
1713
1714         String::format() was relying on undefined behaviour, which
1715         happened to work on lots of systems (Mac and 32bit Linux at least)
1716         but broke badly on 64bit Linux.
1717         
1718         * platform/String.cpp:
1719         (WebCore::String::format):
1720
1721 2007-01-13  Martin Reddy  <reddy@pixar.com>
1722
1723         Fix for bug 11924: WebCore would crash on any HTML content
1724         with a non-empty <table> tag in it on a 64-bit machine. The
1725         size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
1726         and the clients of this function have been updated to check
1727         for a false return code.
1728
1729         Reviewed by Darin, landed by Lars
1730
1731         * rendering/RenderTableSection.cpp:
1732         (WebCore::RenderTableSection::addChild):
1733         (WebCore::RenderTableSection::ensureRows):
1734         (WebCore::RenderTableSection::recalcCells):
1735
1736 2007-01-13  Alexey Proskuryakov  <ap@webkit.org>
1737
1738         Reviewed by Darin.
1739
1740         http://bugs.webkit.org/show_bug.cgi?id=12165
1741         REGRESSION: text encoding problem at jn.sapo.pt
1742
1743         Test: fast/encoding/script-in-head.html
1744
1745         * loader/TextResourceDecoder.cpp:
1746         (WebCore::TextResourceDecoder::checkForHeadCharset):
1747         Ignore tags within <script> elements in head, just like we do for <title>.
1748
1749 2007-01-13  Lars Knoll <lars@trolltech.com>
1750
1751         Reviewed by Maciej
1752
1753         Don't crash when constructing a GraphicsContext with a 0
1754         PlatformGraphicsContext and don't do anything if painting
1755         is disabled.
1756
1757         * platform/graphics/qt/GraphicsContextQt.cpp:
1758         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
1759         (WebCore::GraphicsContext::origin):
1760         (WebCore::GraphicsContext::setPlatformFont):
1761         (WebCore::GraphicsContext::setPlatformStrokeColor):
1762         (WebCore::GraphicsContext::setPlatformStrokeStyle):
1763         (WebCore::GraphicsContext::setPlatformStrokeThickness):
1764         (WebCore::GraphicsContext::setPlatformFillColor):
1765
1766 2007-01-13  Eric Seidel  <eric@webkit.org>
1767
1768         Reviewed by hyatt.
1769
1770         RichDraw demo does not live-update in Safari
1771         (SVG elements should ignore CSS position)
1772         http://bugs.webkit.org/show_bug.cgi?id=10364
1773
1774         * css/cssstyleselector.cpp:
1775         (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
1776         * ksvg2/svg/SVGStyledElement.cpp:
1777         (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
1778         * rendering/RenderContainer.cpp:
1779         (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
1780         * rendering/RenderPath.cpp:
1781         (WebCore::RenderPath::layout): move path generation into layout()
1782         * rendering/RenderSVGContainer.cpp:
1783         (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout
1784
1785 2007-01-12  David Hyatt  <hyatt@apple.com>
1786
1787         Add support for column rules.
1788
1789         Reviewed by bdash
1790
1791         fast/multicol/column-rules.html
1792
1793         * rendering/RenderBlock.cpp:
1794         (WebCore::RenderBlock::paintColumns):
1795         * rendering/RenderStyle.h:
1796         (WebCore::RenderStyle::columnRuleIsTransparent):
1797
1798 2007-01-12  David Hyatt  <hyatt@apple.com>
1799
1800         Make multicolumn layout work with floats.
1801
1802         Reviewed by andersca
1803
1804         Added fast/multicol/float-multicol.html
1805
1806         * rendering/RenderBlock.cpp:
1807         (WebCore::RenderBlock::layoutBlock):
1808         (WebCore::RenderBlock::paintColumns):
1809         (WebCore::RenderBlock::paintObject):
1810         * rendering/RenderBlock.h:
1811
1812 2007-01-12  David Kilzer  <ddkilzer@kilzer.net>
1813
1814         Reviewed by Maciej.
1815
1816         - fix http://bugs.webkit.org/show_bug.cgi?id=12239
1817           REGRESSION (r18816-r18818): Assertion failure in 
1818           WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
1819
1820         Test: fast/css/line-height.html
1821
1822         * rendering/RenderTextControl.cpp:
1823         (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.
1824
1825 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
1826
1827         Reviewed by Darin.
1828
1829         Use unsigned long for identifiers instead of Objective-C objects.
1830         
1831         * loader/FrameLoader.cpp:
1832         (WebCore::FrameLoader::loadResourceSynchronously):
1833         (WebCore::FrameLoader::startLoadingMainResource):
1834         (WebCore::FrameLoader::startLoading):
1835         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
1836         (WebCore::FrameLoader::opened):
1837         (WebCore::FrameLoader::sendRemainingDelegateMessages):
1838         (WebCore::FrameLoader::requestFromDelegate):
1839         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
1840         * loader/FrameLoader.h:
1841         * loader/FrameLoaderClient.h:
1842         * loader/ResourceLoader.cpp:
1843         (WebCore::ResourceLoader::ResourceLoader):
1844         (WebCore::ResourceLoader::willSendRequest):
1845         * loader/ResourceLoader.h:
1846         (WebCore::ResourceLoader::setIdentifier):
1847         (WebCore::ResourceLoader::identifier):
1848         * page/Page.cpp:
1849         (WebCore::Page::Page):
1850         (WebCore::Page::createUniqueIdentifier):
1851         * page/Page.h:
1852         * platform/graphics/svg/SVGImageEmptyClients.h:
1853         (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest):
1854         (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
1855         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1856         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1857         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse):
1858         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength):
1859         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading):
1860         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading):
1861         (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
1862         (WebCore::SVGEmptyFrameLoaderClient::completeProgress):
1863
1864 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1865
1866         Reviewed by Darin.
1867
1868         - fix http://bugs.webkit.org/show_bug.cgi?id=12235
1869           REGRESSION (r18815): Marquees do not scroll
1870
1871         * css/cssstyleselector.cpp:
1872         (WebCore::CSSStyleSelector::applyProperty): Apply the '-webkit-marquee' value
1873         of 'overflow-x' and 'overflow-y'.
1874
1875 2007-01-12  Justin Garcia  <justin.garcia@apple.com>
1876
1877         Reviewed by hyatt
1878         
1879         <rdar://problem/4875425>
1880         EBay, GMail, and GoogleDocs RTEs font size popups don't work
1881
1882         Changed execCommand("FontSize", ...) to match the spec 
1883         and the behavior of other browsers.  It expects a number, 
1884         n, which, the spec says can be 1 through 7.  Other browsers 
1885         perform the font size change by creating a font element 
1886         wrapper with size="n".  We convert n into one of the absolute 
1887         size CSS keywords (x-small, medium, etc.).
1888
1889         * editing/JSEditor.cpp: Call cssValueFromFontSizeNumber.  If
1890         successful, perform the style change.
1891         * html/HTMLFontElement.cpp:
1892         (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):  Added.
1893         Moved this code from parsedMappedAttribute so that it could be
1894         called from the Editor.
1895         (WebCore::HTMLFontElement::parseMappedAttribute): Moved code into
1896         cssValueFromFontSizeNumber.
1897         * html/HTMLFontElement.h:
1898
1899 2007-01-12  David Hyatt  <hyatt@apple.com>
1900
1901         Fix for bug 11598, implement lightweight control clipping mechanism for
1902         buttons, list boxes, and dropdown lists.  Make sure list box respects
1903         scrollLeft/Top/Width/Height as well as clientWidth/Height.
1904
1905         Fix bugs in RenderStyle::diff.  CursorData was not being compared properly.
1906         vertical-align had a non-inline display check that was wrong (preventing
1907         dynamic changes to keyword-based vertical-align from working).
1908
1909         Reviewed by mitz
1910
1911         * page/EventHandler.cpp:
1912         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
1913         * rendering/RenderBlock.cpp:
1914         (WebCore::RenderBlock::layout):
1915         (WebCore::RenderBlock::layoutBlock):
1916         (WebCore::RenderBlock::determineHorizontalPosition):
1917         (WebCore::RenderBlock::layoutBlockChildren):
1918         (WebCore::RenderBlock::paint):
1919         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1920         (WebCore::RenderBlock::nodeAtPoint):
1921         (WebCore::RenderBlock::layoutColumns):
1922         * rendering/RenderBox.cpp:
1923         (WebCore::RenderBox::computeAbsoluteRepaintRect):
1924         * rendering/RenderBox.h:
1925         * rendering/RenderButton.cpp:
1926         (WebCore::RenderButton::setStyle):
1927         (WebCore::RenderButton::controlClipRect):
1928         * rendering/RenderButton.h:
1929         (WebCore::RenderButton::hasControlClip):
1930         * rendering/RenderFlexibleBox.cpp:
1931         (WebCore::RenderFlexibleBox::layoutBlock):
1932         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
1933         (WebCore::RenderFlexibleBox::layoutVerticalBox):
1934         * rendering/RenderFlow.cpp:
1935         (WebCore::RenderFlow::addFocusRingRects):
1936         * rendering/RenderListBox.cpp:
1937         (WebCore::RenderListBox::itemBoundingBoxRect):
1938         (WebCore::RenderListBox::paintObject):
1939         (WebCore::RenderListBox::itemHeight):
1940         (WebCore::RenderListBox::verticalScrollbarWidth):
1941         (WebCore::RenderListBox::scrollWidth):
1942         (WebCore::RenderListBox::scrollHeight):
1943         (WebCore::RenderListBox::scrollLeft):
1944         (WebCore::RenderListBox::setScrollLeft):
1945         (WebCore::RenderListBox::scrollTop):
1946         (WebCore::RenderListBox::setScrollTop):
1947         (WebCore::RenderListBox::controlClipRect):
1948         * rendering/RenderListBox.h:
1949         (WebCore::RenderListBox::hasControlClip):
1950         * rendering/RenderMenuList.cpp:
1951         (WebCore::RenderMenuList::setStyle):
1952         (WebCore::RenderMenuList::controlClipRect):
1953         * rendering/RenderMenuList.h:
1954         (WebCore::RenderMenuList::hasControlClip):
1955         * rendering/RenderObject.cpp:
1956         (WebCore::RenderObject::verticalScrollbarWidth):
1957         (WebCore::RenderObject::horizontalScrollbarHeight):
1958         (WebCore::RenderObject::clientWidth):
1959         (WebCore::RenderObject::clientHeight):
1960         (WebCore::RenderObject::setStyle):
1961         * rendering/RenderObject.h:
1962         (WebCore::RenderObject::hasControlClip):
1963         (WebCore::RenderObject::controlClipRect):
1964         (WebCore::RenderObject::contentWidth):
1965         (WebCore::RenderObject::contentHeight):
1966         * rendering/RenderStyle.cpp:
1967         (WebCore::StyleVisualData::StyleVisualData):
1968         (WebCore::cursorDataEqvuialent):
1969         (WebCore::StyleInheritedData::operator==):
1970         (WebCore::CursorList::operator==):
1971         (WebCore::RenderStyle::diff):
1972         * rendering/RenderStyle.h:
1973         (WebCore::LengthBox::operator!=):
1974         (WebCore::StyleVisualData::operator==):
1975         (WebCore::CursorData::operator==):
1976         (WebCore::CursorData::operator!=):
1977         (WebCore::CursorList::operator!=):
1978         (WebCore::RenderStyle::setTableLayout):
1979         * rendering/bidi.cpp:
1980         (WebCore::RenderBlock::layoutInlineChildren):
1981
1982 2007-01-12  David Hyatt  <hyatt@apple.com>
1983
1984         Fix for bug 9934, smaller line heights should not be allowed on
1985         text fields.
1986
1987         Reviewed by darin
1988
1989         * rendering/RenderTextControl.cpp:
1990         (WebCore::RenderTextControl::createInnerTextStyle):
1991
1992 2007-01-12  Mitz Pettel  <mitz@webkit.org>
1993
1994         Reviewed by Hyatt.
1995
1996         - http://bugs.webkit.org/show_bug.cgi?id=12215
1997           Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and
1998           when removing.
1999
2000         Test: fast/css/remove-shorthand.html (updated)
2001
2002         * css/CSSMutableStyleDeclaration.cpp:
2003         (WebCore::initShorthandMap):
2004         * css/cssparser.cpp:
2005         (WebCore::CSSParser::parseValue):
2006
2007 2007-01-12  Rob Buis  <buis@kde.org>
2008
2009         Reviewed by Mitz.
2010
2011         Do not mix up JSSVGPolygonElement and JSSVGPolylineElement.
2012
2013         * bindings/js/JSSVGElementWrapperFactory.cpp:
2014
2015 2007-01-12  Kevin Decker <kdecker@apple.com>
2016
2017         Reviewed by andersca.
2018
2019         Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]
2020
2021         * dom/DOMImplementation.cpp:
2022         (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the 
2023         loader plumbing was moved to WebCore.  Pinging the plug-in database to ask it if it supports a given mime type has the side 
2024         effect of reading from disk on first call, therefore such a check should be a last resort.  
2025
2026 2007-01-12  Mitz Pettel  <mitz@webkit.org>
2027
2028         Reviewed by Darin.
2029
2030         - fix http://bugs.webkit.org/show_bug.cgi?id=12223
2031           REGRESSION: Leaks under CSSStyleSelector::applyProperty
2032
2033         No test possible (no change to functionality).
2034
2035         * rendering/RenderObject.h: Removed unused forward declaration.
2036         * rendering/RenderStyle.cpp:
2037         (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
2038         Delete shadow data.
2039
2040 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
2041
2042         Build fix.
2043         
2044         * WebCore.xcodeproj/project.pbxproj:
2045         Remove SubresourceLoaderMac.mm.
2046         
2047 2007-01-12  Lars Knoll <lars@trolltech.com>
2048
2049         Reviewed by Darin and Anders.
2050
2051         Make some more of the loader code platform independent.
2052
2053         * loader/FrameLoader.cpp:
2054         (WebCore::FrameLoader::clear):
2055         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2056         (WebCore::FrameLoader::urlSelected):
2057         (WebCore::FrameLoader::createEmptyDocument):
2058         (WebCore::FrameLoader::setTitle):
2059         (WebCore::FrameLoader::originalRequestURL):
2060         (WebCore::FrameLoader::referrer):
2061         * loader/SubresourceLoader.cpp:
2062         (WebCore::SubresourceLoader::SubresourceLoader):
2063         (WebCore::SubresourceLoader::load):
2064         (WebCore::SubresourceLoader::create):
2065         (WebCore::SubresourceLoader::willSendRequest):
2066         (WebCore::SubresourceLoader::didReceiveResponse):
2067         (WebCore::SubresourceLoader::didReceiveData):
2068         (WebCore::SubresourceLoader::didFinishLoading):
2069         (WebCore::SubresourceLoader::didFail):
2070         (WebCore::SubresourceLoader::didCancel):
2071         (WebCore::SubresourceLoader::stopLoading):
2072         * loader/SubresourceLoader.h:
2073         * loader/mac/FrameLoaderMac.mm:
2074         * loader/mac/SubresourceLoaderMac.mm: Removed.
2075         * loader/qt/FrameLoaderQt.cpp:
2076
2077 2007-01-12  Lars Knoll <lars@trolltech.com>
2078
2079         Reviewed by Zack
2080
2081         Valgrind reported uninitialized variable.
2082
2083         * platform/network/qt/ResourceHandleManagerQt.cpp:
2084         (WebCore::FileLoader::request):
2085
2086 2007-01-12  Mitz Pettel  <mitz@webkit.org>
2087
2088         Reviewed by rwlbuis.
2089
2090         - add missing null check in new fixed table layout code
2091
2092         * rendering/FixedTableLayout.cpp:
2093         (WebCore::FixedTableLayout::calcWidthArray):
2094
2095 2007-01-12  Lars Knoll <lars@trolltech.com>
2096
2097         Fix the Qt build after the Authenitcation changes.
2098
2099         * WebCore.pro:
2100         * platform/network/ResourceHandleInternal.h:
2101
2102 2007-01-12  David Hyatt  <hyatt@apple.com>
2103
2104         Fix for bug 9569.  Make sure the selection offset for selection roots excludes border and padding.
2105
2106         Reviewed by Eric
2107
2108         * rendering/RenderBlock.cpp:
2109         (WebCore::RenderBlock::leftSelectionOffset):
2110         (WebCore::RenderBlock::rightSelectionOffset):
2111
2112 2007-01-11  David Hyatt  <hyatt@apple.com>
2113
2114         Fix for bug 8705, readonly text fields should not get focus rings.  Add a rule to that effect to
2115         html4.css and then also add readonly as a special case for style sharing so that we can retain the
2116         performance boost from sharing styles on inputs.
2117
2118         Reviewed by bdash
2119
2120         * css/cssstyleselector.cpp:
2121         (WebCore::CSSStyleSelector::canShareStyleWithElement):
2122         (WebCore::CSSStyleSelector::checkOneSelector):
2123         * css/html4.css:
2124
2125 2007-01-11  David Hyatt  <hyatt@apple.com>
2126
2127         Fix for bug 11595.  Autoscrolling of layers didn't really work at all unless the layer was coincidentally
2128         in the root layer's coordinate space.  The event point was an absolute position within the document, but
2129         the layer's rect was only local coords.  This patch makes sure to use absolute bounds for the layer
2130         when comparing it with the point.
2131
2132         This is covered by the scrollRevealButton test case already in the tree... the results change to be more
2133         correct.
2134
2135         Reviewed by ggaren
2136
2137         * rendering/RenderLayer.cpp:
2138         (WebCore::RenderLayer::scrollRectToVisible):
2139
2140 2007-01-11  Brady Eidson  <beidson@apple.com>
2141
2142         Reviewed by Oliver
2143
2144         -Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
2145         -Make more of ResourceLoader cross-platform
2146
2147         * loader/ResourceLoader.cpp:
2148         (WebCore::ResourceLoader::ResourceLoader):
2149         (WebCore::ResourceLoader::releaseResources):
2150         (WebCore::ResourceLoader::didCancel):
2151         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2152         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2153         (WebCore::ResourceLoader::receivedCancellation):
2154         * loader/ResourceLoader.h:
2155         (WebCore::ResourceLoader::willStopBufferingData):
2156         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2157         (WebCore::ResourceLoader::willCacheResponse):
2158         * loader/mac/ResourceLoaderMac.mm:
2159         * platform/network/ResourceHandle.h:
2160         * platform/network/ResourceHandleClient.h:
2161         (WebCore::ResourceHandleClient::willStopBufferingData):
2162         * platform/network/ResourceHandleInternal.h:
2163         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2164         * platform/network/mac/ResourceHandleMac.mm:
2165         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
2166         (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
2167         (WebCore::ResourceHandle::receivedCredential):
2168         (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
2169         (WebCore::ResourceHandle::receivedCancellation):
2170         (WebCore::ResourceHandle::clearAuthentication):
2171         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
2172         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
2173         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
2174         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
2175         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
2176
2177 2007-01-11  David Hyatt  <hyatt@apple.com>
2178
2179         A hit test is returning a null renderer.  Make sure to null-check it in the autoscroll code.
2180         This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
2181         on the front page of yahoo.com!
2182
2183         Reviewed by mark
2184
2185         * rendering/RenderLayer.cpp:
2186         (WebCore::RenderLayer::autoscroll):
2187
2188 2007-01-11  David Hyatt  <hyatt@apple.com>
2189
2190         Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
2191         shorthand (it can be mistaken for column-count otherwise).
2192
2193         Reviewed by Mark
2194
2195         fast/multicol/columns-shorthand-parsing.html
2196
2197         * css/cssparser.cpp:
2198         (WebCore::CSSParser::parseValue):
2199
2200 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2201
2202         Reviewed by Hyatt.
2203
2204         - fix http://bugs.webkit.org/show_bug.cgi?id=12124
2205           RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}
2206
2207         * rendering/RenderTable.cpp:
2208         (WebCore::resetSectionPointerIfNotBefore): Added this function to help with
2209         checking if a section being inserted is the going to be the first of its kind.
2210         (WebCore::RenderTable::addChild): Changed to maintain the pointers to the
2211         header, the footer, the caption and the first table body properly when objects
2212         are inserted in the middle. Also changed to make the first caption win over
2213         any other captions. This matches Firefox and what already used to happen when a
2214         section recalc took place.
2215         (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating
2216         over the sections from top to bottom.
2217         (WebCore::RenderTable::calcBorderLeft): Changed to really find the section
2218         containing the first row.
2219         (WebCore::RenderTable::calcBorderRight): Ditto.
2220         (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was
2221         skipped if the input was the footer.
2222         (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header"
2223         respectively.
2224
2225 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2226
2227         Reviewed by Hyatt.
2228
2229         - fix http://bugs.webkit.org/show_bug.cgi?id=12115
2230           RTL text is jumbled on display
2231
2232         Fixed fixed table layout. Implemented an algorithm that matches the behavior
2233         of Firefox, up to rounding errors.
2234
2235         Fixes three existing table tests.
2236
2237         * rendering/FixedTableLayout.cpp:
2238         Undid accidental search-and-replace of "width" to "m_width" in the comments.
2239         Removed an outdated comment, since WebKit no longer honors table-layout:fixed
2240         for variable-width tables.
2241         (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the
2242         first row. Changed to divide the width specified for a cell that spans multiple
2243         columns between the columns rather than assign its entire width to each column.
2244         (WebCore::FixedTableLayout::calcMinMaxWidth):
2245         (WebCore::FixedTableLayout::layout): Implemented the behavior observed in
2246         Firefox.
2247         * rendering/FixedTableLayout.h:
2248
2249 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2250
2251         Reviewed by Hyatt.
2252
2253         - fix http://bugs.webkit.org/show_bug.cgi?id=8438
2254           iExploder(#460): Assertion failure in RenderObject::drawBorder()
2255
2256         Test: fast/block/basic/fieldset-stretch-to-legend.html
2257
2258         * rendering/RenderBox.cpp:
2259         (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic
2260         width if the object requires it.
2261         (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup.
2262         (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum
2263         intrinsic width if the object requires it.
2264         * rendering/RenderBox.h:
2265         (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
2266         * rendering/RenderFieldset.cpp:
2267         (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's
2268         implementation to ensure that the legend's will fit in the fieldset's
2269         minimum intrinsic width.
2270         (WebCore::RenderFieldset::findLegend): Made const.
2271         (WebCore::RenderFieldset::paintBoxDecorations):
2272         (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when
2273         the legend does overflow the fieldset. This is the part of the fix that
2274         prevents the assertion failure. If the legend intersects with a corner of
2275         the fieldset's border, that corner will not be painted, even if it is not
2276         completely occluded. This edge case can be improved with clipping in the
2277         future. Added FIXME to implement border-radius.
2278         * rendering/RenderFieldset.h:
2279         (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to
2280         return true.
2281
2282 2007-01-11  Brady Eidson  <beidson@apple.com>
2283
2284         Reviewed by Build Fix Karma
2285
2286         I broke the release build (debug build passed)
2287
2288         * platform/network/mac/AuthenticationMac.mm:
2289         (WebCore::core):
2290
2291 2007-01-11  Brady Eidson  <beidson@apple.com>
2292
2293         Reviewed by Anders
2294
2295         Rewrites HTTP Authentication setting up a more platform-independent structure
2296
2297         * WebCore.exp:
2298         * WebCore.xcodeproj/project.pbxproj:
2299         * loader/FrameLoader.cpp:
2300         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2301         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2302         * loader/FrameLoader.h:
2303         * loader/FrameLoaderClient.h:
2304         * loader/ResourceLoader.cpp:
2305         (WebCore::ResourceLoader::ResourceLoader):
2306         (WebCore::ResourceLoader::didCancel):
2307         * loader/ResourceLoader.h:
2308         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2309         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2310         (WebCore::ResourceLoader::receivedCredential):
2311         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2312         (WebCore::ResourceLoader::receivedCancellation):
2313         * loader/mac/FrameLoaderMac.mm:
2314         * loader/mac/ResourceLoaderMac.mm:
2315         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2316         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2317         (WebCore::ResourceLoader::receivedCredential):
2318         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2319         (WebCore::ResourceLoader::receivedCancellation):
2320         * platform/graphics/svg/SVGImageEmptyClients.h:
2321         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2322         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
2323         * platform/network/ResourceHandleClient.h:
2324         (WebCore::ResourceHandleClient::willSendRequest):
2325         (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge):
2326         (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge):
2327         (WebCore::ResourceHandleClient::receivedCredential):
2328         (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential):
2329         (WebCore::ResourceHandleClient::receivedCancellation):
2330         (WebCore::ResourceHandleClient::willCacheResponse):
2331         * platform/network/ResourceResponse.h:
2332         (WebCore::operator!=):
2333         * platform/network/URLAuthenticationChallenge.cpp: Added.
2334         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
2335         (WebCore::URLAuthenticationChallenge::previousFailureCount):
2336         (WebCore::URLAuthenticationChallenge::proposedCredential):
2337         (WebCore::URLAuthenticationChallenge::protectionSpace):
2338         (WebCore::URLAuthenticationChallenge::failureResponse):
2339         (WebCore::URLAuthenticationChallenge::error):
2340         (WebCore::URLAuthenticationChallenge::isNull):
2341         (WebCore::URLAuthenticationChallenge::nullify):
2342         (WebCore::operator==):
2343         (WebCore::operator!=):
2344         * platform/network/URLAuthenticationChallenge.h: Added.
2345         (WebCore::URLAuthenticationChallenge::sender):
2346         (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
2347         * platform/network/URLCredential.cpp: Added.
2348         (WebCore::URLCredential::URLCredential):
2349         (WebCore::URLCredential::user):
2350         (WebCore::URLCredential::password):
2351         (WebCore::URLCredential::hasPassword):
2352         (WebCore::URLCredential::persistence):
2353         (WebCore::operator==):
2354         * platform/network/URLCredential.h: Added.
2355         (WebCore::):
2356         (WebCore::operator!=):
2357         * platform/network/URLProtectionSpace.cpp: Added.
2358         (WebCore::URLProtectionSpace::URLProtectionSpace):
2359         (WebCore::URLProtectionSpace::host):
2360         (WebCore::URLProtectionSpace::port):
2361         (WebCore::URLProtectionSpace::serverType):
2362         (WebCore::URLProtectionSpace::realm):
2363         (WebCore::URLProtectionSpace::authenticationScheme):
2364         (WebCore::operator==):
2365         * platform/network/URLProtectionSpace.h: Added.
2366         (WebCore::):
2367         (WebCore::operator!=):
2368         * platform/network/mac/AuthenticationMac.h: Added.
2369         * platform/network/mac/AuthenticationMac.mm: Added.
2370         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
2371         (WebCore::mac):
2372         (WebCore::core):
2373         * platform/network/mac/ResourceHandleMac.mm:
2374         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
2375         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
2376         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
2377         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
2378         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
2379         * platform/network/mac/ResourceResponseMac.mm:
2380         (WebCore::operator==):
2381
2382 2007-01-11  Geoffrey Garen  <ggaren@apple.com>
2383
2384         Reviewed by Anders Carlsson.
2385         
2386         Even more cleanup in preparation for fixing <rdar://problem/4608404> 
2387         WebScriptObject's _executionContext lack of ownership policy causes 
2388         crashes (e.g., in Dashcode)
2389         
2390         Layout tests pass.
2391         
2392         Renames:
2393             findRootObjectForNativeHandleFunction => createRootObject
2394             FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
2395             rootForView => createRootObject
2396             getInstanceForView => getPluginInstanceForWidget
2397
2398         * page/mac/FrameMac.mm:
2399         (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void*
2400         variable named "nativeHandle" to be more explicit about the fact that JavaScript's
2401         "nativeHandle" is just an NSView *.
2402
2403         (WebCore::getPluginInstanceForWidget): This function now does the NSView *
2404         fetching that its callers used to do.
2405         (WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
2406         (WebCore::FrameMac::getObjectInstanceForWidget): ditto
2407
2408         * page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category,
2409         which was really more of a shmategory.
2410         (createRootObject): Removed rootObjectForView, folding it into its only
2411         caller, the similarly named rootForView. Renamed the pair to "createRootObject"
2412         because that's what they do.
2413
2414         (-[WebCoreFrameBridge init]): Updated for renames
2415
2416 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2417
2418         Reviewed by Darin.
2419
2420         Fix crash on platforms that don't use the new loader yet.
2421         
2422         * loader/DocLoader.cpp:
2423         (WebCore::DocLoader::requestResource):
2424
2425 2007-01-11  Mitz Pettel  <mitz@webkit.org>
2426
2427         Reviewed by Adam.
2428
2429         - fix http://bugs.webkit.org/show_bug.cgi?id=11449
2430           Type-to-select in unopened popups doesn't work with Hebrew
2431
2432         Test: fast/forms/select-type-ahead-non-latin.html
2433
2434         * html/HTMLSelectElement.cpp:
2435         (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific
2436         isprint() condition to a Unicode isPrintableChar().
2437
2438 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
2439
2440         Reviewed by geoff
2441         
2442         <rdar://problem/4889140>
2443         GMail Editor: List creation fails in new message
2444
2445         * editing/InsertListCommand.cpp:
2446         (WebCore::InsertListCommand::doApply): Inserting the list
2447         into an empty paragraph not held open by a br or a '\n', 
2448         will invalidate start and end.  Insert a placeholder and 
2449         then recompute start and end.
2450
2451 2007-01-11  Lars Knoll <lars@trolltech.com>
2452
2453         Rubberstamped by Anders
2454
2455         This one is not needed any longer neither.
2456
2457         * ChangeLog:
2458         * WebCore.pro:
2459         * loader/qt/NavigationActionQt.cpp: Removed.
2460
2461 2007-01-11  Lars Knoll <lars@trolltech.com>
2462
2463         Reviewed by Anders
2464
2465         Remove now unused file
2466
2467         * WebCore.pro:
2468         * loader/qt/LoaderFunctionsQt.cpp: Removed.
2469
2470 2007-01-11  David Kilzer  <ddkilzer@webkit.org>
2471
2472         Reviewed by NOBODY (build fix).
2473
2474         * loader/mac/FrameLoaderMac.mm:  Removed import of LoaderNSURLRequestExtras.h.
2475         * loader/mac/SubresourceLoaderMac.mm:  Ditto.
2476
2477 2007-01-11  George Staikos  <staikos@kde.org>
2478
2479         Fix compile.
2480
2481         * page/qt/FrameQtClient.cpp:
2482
2483 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2484
2485         Fix build.
2486         
2487         * dom/XMLTokenizer.cpp:
2488         * loader/CachedCSSStyleSheet.cpp:
2489         * loader/CachedImage.cpp:
2490         * loader/DocLoader.cpp:
2491         * loader/loader.cpp:
2492         * xml/XSLTProcessor.cpp:
2493         * xml/xmlhttprequest.cpp:
2494
2495 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
2496
2497         Reviewed by Adam.
2498
2499         Loader cleanup, get rid of unused code.
2500         
2501         * WebCore.xcodeproj/project.pbxproj:
2502         * loader/CachedResource.h:
2503         * loader/DocLoader.cpp:
2504         (WebCore::DocLoader::requestResource):
2505         (WebCore::DocLoader::checkCacheObjectStatus):
2506         * loader/DocLoader.h:
2507         * loader/LoaderFunctions.h: Removed.
2508         * loader/mac/CachedResourceMac.mm: Removed.
2509         * loader/mac/LoaderFunctionsMac.mm: Removed.
2510         * loader/mac/LoaderNSURLRequestExtras.h: Removed.
2511         * loader/mac/LoaderNSURLRequestExtras.m: Removed.
2512         * loader/mac/SubresourceLoaderMac.mm:
2513         * page/mac/WebCoreFrameBridge.mm:
2514         * platform/network/ResourceHandle.cpp:
2515
2516 2007-01-11  Beth Dakin  <bdakin@apple.com>
2517
2518         Reviewed by Adam.
2519
2520         Fix for http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION: 
2521         <input> and <textarea> not focused on right click (4908884 in 
2522         Radar)
2523
2524         * page/EventHandler.cpp:
2525         (WebCore::EventHandler::sendContextMenuEvent): Since WebcCore now 
2526         handles the context menu event, we want to ask if we *have* 
2527         swallowed the event instead of if we *haven't* when deciding to 
2528         perform a selection. In the past, WebKit handled the event, so 
2529         swallowEvent was false in the case where we want to pop up a menu. 
2530
2531 2007-01-11  Darin Adler  <darin@apple.com>
2532
2533         Reviewed by Anders.
2534
2535         - fix http://bugs.webkit.org/show_bug.cgi?id=12189
2536           REGRESSION(r18614-18640): Crash in WebCore::SharedBuffer::hasPlatformData()
2537
2538         * loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
2539         Added null check.
2540
2541 2007-01-11  Darin Adler  <darin@apple.com>
2542
2543         * platform/CharacterNames.h: Oops! horizontalEllipsis != zeroWidthSpace!
2544
2545 2007-01-11  Lars Knoll <lars@trolltech.com>
2546
2547         Reviewed by Darin.
2548
2549         Start using the loader in the Qt port.
2550
2551         * loader/FrameLoader.cpp:
2552         (WebCore::FrameLoader::clear):
2553         (WebCore::FrameLoader::URL):
2554         (WebCore::FrameLoader::createEmptyDocument):
2555         * loader/qt/FrameLoaderQt.cpp:
2556         (WebCore::FrameLoader::setTitle):
2557         (WebCore::FrameLoader::originalRequestURL):
2558         (WebCore::FrameLoader::referrer):
2559         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2560         * page/qt/FrameQtClient.cpp:
2561         (WebCore::FrameQtClient::openURL):
2562
2563 2007-01-11  Darin Adler  <darin@apple.com>
2564
2565         Reviewed by Hyatt.
2566
2567         - removed a couple Mac bridging classes; put the code in WebKit instead
2568
2569         * WebCore.exp: Updated for new WebKit uses.
2570
2571         * WebCore.xcodeproj/project.pbxproj: Removed files.
2572         * bridge/mac/WebCoreEncodings.h: Removed.
2573         * bridge/mac/WebCoreEncodings.mm: Removed.
2574         * bridge/mac/WebMimeTypeRegistryBridge.h: Removed.
2575         * bridge/mac/WebMimeTypeRegistryBridge.mm: Removed.
2576         * platform/mac/WebNSAttributedStringExtras.h: Removed.
2577         * platform/mac/WebNSAttributedStringExtras.mm: Removed.
2578
2579         * platform/mac/PasteboardMac.mm:
2580         (WebCore::stripAttachmentCharacters): Added. Moved code from
2581         WebNSAttributedStringExtras.mm, and fixed a garbage collection problem
2582         (a global with a plain old retain rather than HardRetain).
2583         (WebCore::Pasteboard::writeSelection): Updated to use stripAttachmentCharacters.
2584
2585         - removed some DeprecatedCString use
2586
2587         * loader/FrameLoader.cpp: Changed to use String more to eliminate use of
2588         DeprecatedCString here in the mailto form support. But maybe we can remove
2589         this entirely. Do we really care about mailto forms any more?
2590
2591         * platform/Pasteboard.h: Removed unneeded DeprecatedCString declaration.
2592
2593         * platform/PlatformString.h: Added replace that takes two strings.
2594         * platform/StringImpl.h: Ditto.
2595         * platform/StringImpl.cpp: (WebCore::StringImpl::replace): Ditto.
2596
2597         * platform/TextStream.h: Remove DeprecatedCString case.
2598         * platform/TextStream.cpp: Ditto.
2599
2600         - made a few more files use CharacterNames.h
2601
2602         * platform/CharacterNames.h: Added some more character names and
2603         sorted alphabetically.
2604
2605         * bridge/mac/WebCoreStringTruncator.mm:
2606         (centerTruncateToBuffer): Use character name from CharacterNames.h.
2607         (rightTruncateToBuffer): Ditto.
2608         (truncateString): Ditto.
2609         * platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): Ditto.
2610         * rendering/RenderFlexibleBox.cpp:
2611         (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
2612         * rendering/bidi.cpp:
2613         (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto.
2614
2615 2007-01-11  David Hyatt  <hyatt@apple.com>
2616
2617         Fix two bugs in positionForCoordinates.  (Make it work when you have a margin in between your border and
2618         your first child block.)
2619
2620         Rewrite column rebalancing to have two modes: constrained and unconstrained.  In unconstrained mode,
2621         the system will dynamically rebalance as it loses space to breaks and compute a final intrinsic height
2622         for the overall block.  In constrained mode, columns flow into the fixed height block, and extra columns
2623         spill out horizontally in the appropriate direction (RTL/LTR).
2624
2625         Make columns work properly with both LTR and RTL overflow blocks.
2626
2627         Initial column test suite coming soon now that the basic layout is right.
2628
2629         Reviewed by darin
2630
2631         * rendering/RenderBlock.cpp:
2632         (WebCore:::RenderFlow):
2633         (WebCore::RenderBlock::layoutBlock):
2634         (WebCore::RenderBlock::paintColumns):
2635         (WebCore::RenderBlock::lowestPosition):
2636         (WebCore::RenderBlock::rightmostPosition):
2637         (WebCore::RenderBlock::leftmostPosition):
2638         (WebCore::RenderBlock::hitTestColumns):
2639         (WebCore::RenderBlock::positionForCoordinates):
2640         (WebCore::RenderBlock::availableWidth):
2641         (WebCore::RenderBlock::calcColumnWidth):
2642         (WebCore::RenderBlock::layoutColumns):
2643         (WebCore::RenderBlock::adjustPointToColumnContents):
2644         * rendering/RenderBlock.h:
2645         (WebCore::RenderBlock::hasColumns):
2646
2647 2007-01-10  Rob Buis  <buis@kde.org>
2648
2649         Reviewed by Eric.
2650
2651         http://bugs.webkit.org/show_bug.cgi?id=12201
2652         Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg
2653
2654         Fix calculation of absolute transform so that viewport x,y
2655         translation is always done, also when viewBox is set.     
2656
2657         * rendering/RenderSVGContainer.cpp:
2658         (WebCore::RenderSVGContainer::paint):
2659         (WebCore::RenderSVGContainer::viewportTransform):
2660         (WebCore::RenderSVGContainer::absoluteTransform):
2661
2662 2007-01-10  David Hyatt  <hyatt@apple.com>
2663
2664         Rework positionForCoordinates to be more efficient and to handle multi-column content.  This entailed
2665         adding a new field to HitTestResult called localPoint that cached the mouse coordinate in the coordinate
2666         space of the renderer.
2667
2668         positionForCoordinates now takes local coordinates and so no longer needs to waste time recomputing
2669         absolute positions over and over again.
2670
2671         Reviewed by darin
2672
2673         * bridge/mac/WebCoreAXObject.mm:
2674         (-[WebCoreAXObject value]):
2675         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
2676         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
2677         * dom/Document.cpp:
2678         (WebCore::Document::prepareMouseEvent):
2679         * editing/SelectionController.cpp:
2680         (WebCore::SelectionController::contains):
2681         * editing/visible_units.cpp:
2682         (WebCore::previousLinePosition):
2683         (WebCore::nextLinePosition):
2684         * page/EventHandler.cpp:
2685         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
2686         (WebCore::EventHandler::handleMousePressEventDoubleClick):
2687         (WebCore::EventHandler::handleMousePressEventTripleClick):
2688         (WebCore::EventHandler::handleMousePressEventSingleClick):
2689         (WebCore::EventHandler::handleMouseMoveEvent):
2690         (WebCore::EventHandler::handleMouseReleaseEvent):
2691         (WebCore::EventHandler::sendContextMenuEvent):
2692         * page/EventHandler.h:
2693         * page/MouseEventWithHitTestResults.cpp:
2694         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2695         * page/MouseEventWithHitTestResults.h:
2696         (WebCore::MouseEventWithHitTestResults::localPoint):
2697         * page/mac/WebCoreFrameBridge.mm:
2698         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
2699         * rendering/EllipsisBox.cpp:
2700         (WebCore::EllipsisBox::nodeAtPoint):
2701         * rendering/HitTestResult.h:
2702         (WebCore::HitTestResult::localPoint):
2703         (WebCore::HitTestResult::setLocalPoint):
2704         * rendering/InlineFlowBox.cpp:
2705         (WebCore::InlineFlowBox::nodeAtPoint):
2706         * rendering/InlineTextBox.cpp:
2707         (WebCore::InlineTextBox::nodeAtPoint):
2708         * rendering/RenderBlock.cpp:
2709         (WebCore::RenderBlock::nodeAtPoint):
2710         (WebCore::RenderBlock::hitTestContents):
2711         (WebCore::RenderBlock::positionForCoordinates):
2712         * rendering/RenderBox.cpp:
2713         (WebCore::RenderBox::nodeAtPoint):
2714         * rendering/RenderContainer.cpp:
2715         (WebCore::RenderContainer::positionForCoordinates):
2716         * rendering/RenderFlow.cpp:
2717         (WebCore::RenderFlow::hitTestLines):
2718         * rendering/RenderInline.cpp:
2719         (WebCore::RenderInline::positionForCoordinates):
2720         * rendering/RenderLayer.cpp:
2721         (WebCore::RenderLayer::autoscroll):
2722         (WebCore::RenderLayer::hitTestLayer):
2723         * rendering/RenderObject.cpp:
2724         (WebCore::RenderObject::updateHitTestResult):
2725         * rendering/RenderObject.h:
2726         * rendering/RenderPath.cpp:
2727         (WebCore::RenderPath::nodeAtPoint):
2728         * rendering/RenderReplaced.cpp:
2729         (WebCore::RenderReplaced::positionForCoordinates):
2730         * rendering/RenderTableRow.cpp:
2731         (WebCore::RenderTableRow::nodeAtPoint):
2732         * rendering/RenderTableSection.cpp:
2733         (WebCore::RenderTableSection::nodeAtPoint):
2734         * rendering/RenderText.cpp:
2735         (WebCore::RenderText::positionForCoordinates):
2736         * rendering/RootInlineBox.cpp:
2737         (WebCore::RootInlineBox::nodeAtPoint):
2738         (WebCore::RootInlineBox::closestLeafChildForXPos):
2739         * rendering/RootInlineBox.h:
2740
2741 2007-01-11  George Staikos  <staikos@kde.org>
2742
2743         Reviewed by Maciej.
2744
2745         Fix Qt Build.
2746
2747         * loader/qt/DocumentLoaderQt.cpp:
2748         (WebCore::DocumentLoader::getResponseModifiedHeader):
2749
2750 2007-01-10  Kirby White  <KWhiteRight@gmail.com>
2751
2752         Reviewed by Darin.
2753
2754         Fixes for http://bugs.webkit.org/show_bug.cgi?id=11841
2755
2756         Set image size to fit alt text when image or input-image element
2757         has no src attribute, so that those images show their alt text instead
2758         of showing nothing at all.
2759
2760         * html/HTMLImageElement.cpp:
2761         (WebCore::HTMLImageElement::attach):
2762         * html/HTMLInputElement.cpp:
2763         (WebCore::HTMLInputElement::attach):
2764         * rendering/RenderImage.cpp:
2765         (WebCore::RenderImage::setImageSizeForAltText):
2766         (WebCore::RenderImage::imageChanged):
2767         * rendering/RenderImage.h:
2768
2769 2007-01-11  Mark Rowe  <mrowe@apple.com>
2770
2771         Build fix.
2772
2773         * rendering/RenderView.cpp:
2774         (WebCore::RenderView::printing):
2775
2776 2007-01-10  Mitz Pettel  <mitz@webkit.org>
2777
2778         Reviewed by Darin.
2779
2780         - fix http://bugs.webkit.org/show_bug.cgi?id=9284
2781           Quirksmode (CSS1): Removing inline border styles is impossible
2782
2783         Test: fast/css/remove-shorthand.html
2784
2785         * css/CSSMutableStyleDeclaration.cpp:
2786         (WebCore::PropertyLonghand::PropertyLonghand): Added this structure
2787         containing a pointer to an array if properties and the array's length.
2788         (WebCore::PropertyLonghand::properties):
2789         (WebCore::PropertyLonghand::length):
2790         (WebCore::initShorthandMap): Initialize the mapping from shorthand
2791         properties to their dependent properties.
2792         (WebCore::CSSMutableStyleDeclaration::removeProperty): Changed to check
2793         if the property being removed is a shorthand, and if so, to remove all
2794         of its dependent properties.
2795         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): Added a
2796         'notifyChanged' boolean parameter which controls whether this method
2797         calls setChanged() if it actually removes any property.
2798         * css/CSSMutableStyleDeclaration.h:
2799
2800 2007-01-10  Steve Falkenburg  <sfalken@apple.com>
2801
2802         Reviewed by Kevin.
2803
2804         Removed unnecessary printing state
2805
2806         * page/FrameView.cpp:
2807         (WebCore::FrameView::layout):
2808         * page/mac/WebCoreFrameBridge.mm:
2809         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
2810         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
2811         (-[WebCoreFrameBridge drawRect:]):
2812         (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
2813         (-[WebCoreFrameBridge adjustPageHeightNew:top:bottom:limit:]):
2814         * rendering/RenderLayer.cpp:
2815         (WebCore::RenderLayer::updateLayerPositions):
2816         * rendering/RenderObject.cpp:
2817         (WebCore::RenderObject::repaint):
2818         (WebCore::RenderObject::repaintRectangle):
2819         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
2820         * rendering/RenderView.cpp:
2821         (WebCore::RenderView::RenderView):
2822         (WebCore::RenderView::calcHeight):
2823         (WebCore::RenderView::calcWidth):
2824         (WebCore::RenderView::layout):
2825         (WebCore::RenderView::paint):
2826         (WebCore::RenderView::repaintViewRectangle):
2827         (WebCore::RenderView::computeAbsoluteRepaintRect):
2828         (WebCore::RenderView::printing):
2829         (WebCore::RenderView::viewRect):
2830         (WebCore::RenderView::docHeight):
2831         (WebCore::RenderView::docWidth):
2832         * rendering/RenderView.h:
2833         * rendering/RenderWidget.cpp:
2834         (WebCore::RenderWidget::updateWidgetPosition):
2835         * rendering/bidi.cpp:
2836         (WebCore::RenderBlock::layoutInlineChildren):
2837
2838 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2839
2840         Reviewed by Maciej.
2841
2842         Get the Refresh header directly from the ResourceResponse.
2843         
2844         * loader/DocumentLoader.h:
2845         * loader/FrameLoader.cpp:
2846         (WebCore::FrameLoader::commitProvisionalLoad):
2847         * loader/mac/DocumentLoaderMac.mm:
2848         (WebCore::DocumentLoader::getResponseModifiedHeader):
2849
2850 2007-01-10  Beth Dakin  <bdakin@apple.com>
2851
2852         Reviewed by John.
2853
2854         Fix for <rdar://problem/4914258> REGRESSION: Search in Google now 
2855         operates on the current WebView instead of invoking Safari's 
2856         service
2857
2858         * page/ContextMenuClient.h: New call to the client to search in 
2859         google.
2860         * page/ContextMenuController.cpp:
2861         (WebCore::ContextMenuController::contextMenuItemSelected): Call 
2862         into the client instead of forming a new url string and loading it.
2863         * platform/graphics/svg/SVGImageEmptyClients.h:
2864         (WebCore::SVGEmptyContextMenuClient::searchWithGoogle): New call.
2865
2866 2007-01-10  Adam Roben  <aroben@apple.com>
2867
2868         Rubberstamped by Darin.
2869
2870         * page/ContextMenuController.cpp:
2871         (WebCore::ContextMenuController::contextMenuItemSelected): Pass 0
2872         instead of an empty Event to FrameLoader::load and
2873         FrameLoader::urlSelected.
2874
2875 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2876
2877         * loader/ResourceLoader.cpp:
2878         (WebCore::ResourceLoader::~ResourceLoader):
2879         Disable assertion (I forgot to do this even though I added the comment!)
2880
2881 2007-01-10  Ross Burton  <ross@burtonini.com>
2882
2883         Reviewed and landed by Anders.
2884
2885         Fix case in vcproj file (the GTK+ port uses the vcproj file).
2886
2887         * WebCore.vcproj/WebCore/WebCore.vcproj:
2888
2889 2007-01-10  Lars Knoll  <lars@trolltech.com>
2890
2891         Make the Qt build compile again after 
2892         the ResourceLoader was made platform
2893         independent. 
2894
2895         * WebCore.pro:
2896         * loader/FrameLoader.cpp:
2897         (WebCore::FrameLoader::didFirstLayout):
2898         * loader/qt/FrameLoaderQt.cpp:
2899         * loader/qt/MainResourceLoaderQt.cpp: Removed.
2900         * loader/qt/ResourceLoaderQt.cpp: Removed.
2901         * page/qt/FrameQtClient.cpp:
2902         (WebCore::FrameQtClient::openURL):
2903         * platform/network/qt/ResourceHandleQt.cpp:
2904         (WebCore::ResourceHandle::setDefersLoading):
2905
2906 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
2907
2908         Rubber-stamped by Maciej.
2909         
2910         Move most of ResourceLoader and MainResourceLoader into the platform-independent files.
2911         
2912         * WebCore.xcodeproj/project.pbxproj:
2913         * loader/FrameLoader.cpp:
2914         (WebCore::FrameLoader::didFinishLoad):
2915         * loader/MainResourceLoader.cpp:
2916         (WebCore::MainResourceLoader::MainResourceLoader):
2917         (WebCore::MainResourceLoader::~MainResourceLoader):
2918         (WebCore::MainResourceLoader::create):
2919         (WebCore::MainResourceLoader::receivedError):
2920         (WebCore::MainResourceLoader::didCancel):
2921         (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
2922         (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
2923         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2924         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2925         (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
2926         (WebCore::MainResourceLoader::addData):
2927         (WebCore::MainResourceLoader::willSendRequest):
2928         (WebCore::shouldLoadAsEmptyDocument):
2929         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2930         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2931         (WebCore::MainResourceLoader::didReceiveResponse):
2932         (WebCore::MainResourceLoader::didReceiveData):
2933         (WebCore::MainResourceLoader::didFinishLoading):
2934         (WebCore::MainResourceLoader::didFail):
2935         (WebCore::MainResourceLoader::loadNow):
2936         (WebCore::MainResourceLoader::load):
2937         (WebCore::MainResourceLoader::setDefersLoading):
2938         * loader/MainResourceLoader.h:
2939         * loader/ResourceLoader.cpp:
2940         (WebCore::ResourceLoader::ResourceLoader):
2941         (WebCore::ResourceLoader::~ResourceLoader):
2942         (WebCore::ResourceLoader::releaseResources):
2943         (WebCore::ResourceLoader::load):
2944         (WebCore::ResourceLoader::setDefersLoading):
2945         (WebCore::ResourceLoader::frameLoader):
2946         (WebCore::ResourceLoader::addData):
2947         (WebCore::ResourceLoader::clearResourceData):
2948         (WebCore::ResourceLoader::willSendRequest):
2949         (WebCore::ResourceLoader::didReceiveResponse):
2950         (WebCore::ResourceLoader::didReceiveData):
2951         (WebCore::ResourceLoader::willStopBufferingData):
2952         (WebCore::ResourceLoader::didFinishLoading):
2953         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2954         (WebCore::ResourceLoader::didFail):
2955         (WebCore::ResourceLoader::didCancel):
2956         (WebCore::ResourceLoader::cancel):
2957         (WebCore::ResourceLoader::response):
2958         (WebCore::ResourceLoader::cancelledError):
2959         * loader/ResourceLoader.h:
2960         (WebCore::ResourceLoader::willStopBufferingData):
2961         (WebCore::ResourceLoader::setRequest):
2962         * loader/mac/FrameLoaderMac.mm:
2963         * loader/mac/MainResourceLoaderMac.mm: Removed.
2964         * loader/mac/ResourceLoaderMac.mm:
2965
2966 2007-01-10  Lars Knoll <lars@trolltech.com>
2967
2968         Move files to the correct location,
2969         and remove a few unused methods from 
2970         LoaderFunctionsQt.cpp
2971
2972         * WebCore.pro:
2973         * loader/qt/LoaderFunctionsQt.cpp: Added.
2974         (WebCore::CheckCacheObjectStatus):
2975         * page/qt/FrameQt.cpp: Added.
2976         (WebCore::doScroll):
2977         (WebCore::FrameQt::FrameQt):
2978         (WebCore::FrameQt::~FrameQt):
2979         (WebCore::FrameQt::passMouseDownEventToWidget):
2980         (WebCore::FrameQt::isLoadTypeReload):
2981         (WebCore::FrameQt::markedTextRange):
2982         (WebCore::FrameQt::mimeTypeForFileName):
2983         (WebCore::FrameQt::unfocusWindow):
2984         (WebCore::FrameQt::focusWindow):
2985         (WebCore::FrameQt::getEmbedInstanceForWidget):
2986         (WebCore::FrameQt::getObjectInstanceForWidget):
2987         (WebCore::FrameQt::getAppletInstanceForWidget):
2988         (WebCore::FrameQt::issueCutCommand):
2989         (WebCore::FrameQt::issueCopyCommand):
2990         (WebCore::FrameQt::issuePasteCommand):
2991         (WebCore::FrameQt::issuePasteAndMatchStyleCommand):
2992         (WebCore::FrameQt::issueTransposeCommand):
2993         (WebCore::FrameQt::respondToChangedSelection):
2994         (WebCore::FrameQt::shouldChangeSelection):
2995         (WebCore::FrameQt::print):
2996         (WebCore::FrameQt::shouldInterruptJavaScript):
2997         (WebCore::FrameQt::keyEvent):
2998         (WebCore::FrameQt::setFrameGeometry):
2999         (WebCore::FrameQt::client):
3000         (WebCore::FrameQt::createNewWindow):
3001         (WebCore::FrameQt::goBackOrForward):
3002         (WebCore::FrameQt::historyURL):
3003         (WebCore::FrameQt::runJavaScriptAlert):
3004         (WebCore::FrameQt::runJavaScriptConfirm):
3005         (WebCore::FrameQt::runJavaScriptPrompt):
3006         (WebCore::FrameQt::bindingRootObject):
3007         (WebCore::FrameQt::addPluginRootObject):
3008         * page/qt/FrameQt.h: Added.
3009         (WebCore::QtFrame):
3010         * page/qt/FrameQtClient.cpp: Added.
3011         (WebCore::FrameQtClient::FrameQtClient):
3012         (WebCore::FrameQtClient::~FrameQtClient):
3013         (WebCore::FrameQtClient::setFrame):
3014         (WebCore::FrameQtClient::openURL):
3015         (WebCore::FrameQtClient::submitForm):
3016         (WebCore::FrameQtClient::didReceiveResponse):
3017         (WebCore::FrameQtClient::didFinishLoading):
3018         (WebCore::FrameQtClient::didFail):
3019         (WebCore::FrameQtClient::didReceiveData):
3020         (WebCore::FrameQtClient::traverseNextFrameStayWithin):
3021         (WebCore::numRequests):
3022         (WebCore::FrameQtClient::numPendingOrLoadingRequests):
3023         * page/qt/FrameQtClient.h: Added.
3024         * platform/qt/FrameQt.cpp: Removed.
3025         * platform/qt/FrameQt.h: Removed.
3026         * platform/qt/FrameQtClient.cpp: Removed.
3027         * platform/qt/FrameQtClient.h: Removed.
3028         * platform/qt/LoaderFunctionsQt.cpp: Removed.
3029
3030 2007-01-10  Adam Roben  <aroben@apple.com>
3031
3032         Reviewed by Geoff.
3033
3034         Fix: <rdar://problem/4917054> ContextMenuController leaks Events
3035
3036         No layout tests possible.
3037
3038         * page/ContextMenuController.cpp:
3039         (WebCore::ContextMenuController::contextMenuItemSelected): Use RefPtr
3040         to manage the lifetime of Shared objects.
3041
3042 2007-01-10  Rob Buis  <buis@kde.org>
3043
3044         Reviewed by Sam.
3045
3046         http://bugs.webkit.org/show_bug.cgi?id=12196
3047         SVGPatternElement should not be locatable
3048
3049         Replace SVGStyledLocatableElement derivation with
3050         SVGStyledElement.
3051
3052         * ksvg2/svg/SVGPatternElement.cpp:
3053         (WebCore::SVGPatternElement::SVGPatternElement):
3054         * ksvg2/svg/SVGPatternElement.h:
3055
3056 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
3057
3058         Build fix, not reviewed.
3059
3060         * rendering/RenderSVGText.cpp: Use correct method name.
3061         (WebCore::RenderSVGText::relativeBBox):
3062
3063 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
3064
3065         Reviewed by Eric.
3066
3067         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10262 (SVG fails to redraw top 20 pixels)
3068         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10263 (SVG seems to repaint way too many times during load)
3069         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10404 (Invalidation issues with text skew)
3070         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10407 (bad SVG text invalidation issues on mouseover/mouseout)
3071         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10806 (failing manual-tests/svg-repaint-group.svg)
3072         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10913 (SVG charts from plotkit fail to render unless you scroll them offscreen)
3073         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10964 (inclusion of svg into svg leave a ghost invisible rectangle)
3074         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11680 (DojoKit SVG test chart fails to render (clipping issue?))
3075         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11883 (SVG Text has updating/repainting issues)
3076         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11907 (RenderSVGContainer does not mark itself for repaint after setting viewBox, slice or align) 
3077         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11913 (Invalidation issues in SVG javascript-based animation example)
3078         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11979 (SVG text does not respect font-size scaling in bbox calculation)
3079         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11984 (SVG <text> does not calculate the correct absoluteRepaintRect)
3080         Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=10745 (SVG layout needs to move out of DOM and into rendering tree during layout() call)
3081
3082         Fixes text redrawing issues seen in svg/carto.net (when actually playing with those files, manually)
3083         Fixes svg/carto.net/window.svg (moving "Navigation Window" caused artefacts)
3084         Fixes svg/W3C-SVG-1.1/types-basicDOM-01-b.svg (bbox calculations had one pixel offset)
3085
3086         Large SVG dynamic update rework/optimization. Also fixes SVG printing.
3087
3088         Rename updateCanvasItem() to rebuildRenderer(), as this is what it really does.
3089
3090         Do NOT call rebuildRenderer() in notifyAttributeChange() anymore,
3091         but override notifyAttributeChange() in SVGPathElement/SVGCircleElement/etc..
3092         (as only primitives using RenderPath as rendering object need this logic!)
3093
3094         This should clarify what really happens, as discussed with Eric.
3095
3096         Remove the invocations of notifyAttributeChange() in SVGLength. It's already
3097         handled by the JS bindings, and we do double updating work. Fixed.
3098
3099         Because SVG dynamic updates have been flaky in the past, there was a hack introduced
3100         in RenderPath causing the updateCanvasItem() function to be called _on every layout_ (!!!).
3101         Finally this hack is gone. Offer RenderSVGContainer::absoluteRects() function to be able
3102         to use WebInspector for <g> elements (very handy!).
3103
3104         Remove the unneeded "m_updateVectorial" bool from SVGStyledElement.
3105         Remove computeAbsoluteRepaintRect() from RenderSVGContainer/RenderSVGImage/RenderSVGText,
3106         as dicussed with David (we only need to reimplement getAbsoluteRepaintRect there).
3107
3108         Make RenderSVGText::absoluteRects just use the getAbsoluteRepaintRect() function, instead of
3109         code duplication. Remove unneeded RenderSVGImage::layout() function (RenderImage does the same).
3110
3111         Add new function SVGStyledElement::renderStyleForElement, which centralizes the manual style
3112         resolving needed for gradient stops.
3113
3114         * ksvg2/svg/SVGCircleElement.cpp:
3115         (WebCore::SVGCircleElement::notifyAttributeChange):
3116         (WebCore::SVGCircleElement::hasRelativeValues):
3117         * ksvg2/svg/SVGCircleElement.h:
3118         * ksvg2/svg/SVGEllipseElement.cpp:
3119         (WebCore::SVGEllipseElement::notifyAttributeChange):
3120         (WebCore::SVGEllipseElement::hasRelativeValues):
3121         * ksvg2/svg/SVGEllipseElement.h:
3122         * ksvg2/svg/SVGImageElement.cpp:
3123         (WebCore::SVGImageElement::notifyAttributeChange):
3124         * ksvg2/svg/SVGImageElement.h:
3125         * ksvg2/svg/SVGLength.cpp:
3126         (WebCore::SVGLength::setValue):
3127         (WebCore::SVGLength::setValueInSpecifiedUnits):
3128         * ksvg2/svg/SVGLength.h:
3129         (WebCore::SVGLength::isRelative):
3130         * ksvg2/svg/SVGLineElement.cpp:
3131         (WebCore::SVGLineElement::notifyAttributeChange):
3132         (WebCore::SVGLineElement::hasRelativeValues):
3133         * ksvg2/svg/SVGLineElement.h:
3134         * ksvg2/svg/SVGLocatable.cpp:
3135         (WebCore::SVGLocatable::getBBox):
3136         * ksvg2/svg/SVGPathElement.cpp:
3137         (WebCore::SVGPathElement::notifyAttributeChange):
3138         * ksvg2/svg/SVGPathElement.h:
3139         * ksvg2/svg/SVGPolyElement.cpp:
3140         (WebCore::SVGPolyElement::notifyAttributeChange):
3141         * ksvg2/svg/SVGPolyElement.h:
3142         (WebCore::SVGPolyElement::rendererIsNeeded):
3143         * ksvg2/svg/SVGRectElement.cpp:
3144         (WebCore::SVGRectElement::notifyAttributeChange):
3145         (WebCore::SVGRectElement::hasRelativeValues):
3146         * ksvg2/svg/SVGRectElement.h:
3147         * ksvg2/svg/SVGSVGElement.cpp:
3148         (WebCore::SVGSVGElement::hasRelativeValues):
3149         * ksvg2/svg/SVGSVGElement.h:
3150         * ksvg2/svg/SVGStyledElement.cpp:
3151         (WebCore::SVGStyledElement::SVGStyledElement):
3152         (WebCore::SVGStyledElement::createRenderer):
3153         (WebCore::SVGStyledElement::notifyAttributeChange):
3154         (WebCore::SVGStyledElement::rebuildRenderer):
3155         * ksvg2/svg/SVGStyledElement.h:
3156         (WebCore::SVGStyledElement::hasRelativeValues):
3157         * rendering/RenderPath.cpp:
3158         (WebCore::RenderPath::setLocalTransform):
3159         (WebCore::RenderPath::fillContains):
3160         (WebCore::RenderPath::relativeBBox):
3161         (WebCore::RenderPath::layout):
3162         (WebCore::RenderPath::getAbsoluteRepaintRect):
3163         (WebCore::RenderPath::paint):
3164         (WebCore::RenderPath::nodeAtPoint):
3165         (WebCore::drawMarkerWithData):
3166         (WebCore::updateMarkerDataForElement):
3167         (WebCore::drawStartAndMidMarkers):
3168         (WebCore::RenderPath::drawMarkersIfNeeded):
3169         (WebCore::RenderPath::hasRelativeValues):
3170         * rendering/RenderPath.h:
3171         * rendering/RenderSVGContainer.cpp:
3172         (WebCore::RenderSVGContainer::layout):
3173         (WebCore::RenderSVGContainer::paint):
3174         (WebCore::RenderSVGContainer::calcViewport):
3175         (WebCore::RenderSVGContainer::setViewBox):
3176         (WebCore::RenderSVGContainer::setAlign):
3177         (WebCore::RenderSVGContainer::viewportTransform):
3178         (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
3179         (WebCore::RenderSVGContainer::absoluteRects):
3180         (WebCore::RenderSVGContainer::fillContains):
3181         (WebCore::RenderSVGContainer::strokeContains):
3182         (WebCore::RenderSVGContainer::relativeBBox):
3183         (WebCore::RenderSVGContainer::setSlice):
3184         * rendering/RenderSVGContainer.h:
3185         * rendering/RenderSVGImage.cpp:
3186         (WebCore::RenderSVGImage::RenderSVGImage):
3187         (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
3188         (WebCore::RenderSVGImage::relativeBBox):
3189         (WebCore::RenderSVGImage::imageChanged):
3190         (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
3191         (WebCore::RenderSVGImage::absoluteRects):
3192         * rendering/RenderSVGImage.h:
3193         * rendering/RenderSVGText.cpp:
3194         (WebCore::RenderSVGText::getAbsoluteRepaintRect):
3195         (WebCore::RenderSVGText::layout):
3196         (WebCore::RenderSVGText::createInlineBox):
3197         (WebCore::RenderSVGText::absoluteRects):
3198         (WebCore::RenderSVGText::relativeBBox):
3199         * rendering/RenderSVGText.h:
3200         * rendering/SVGInlineFlowBox.cpp:
3201         (WebCore::placePositionedBoxesHorizontally):
3202
3203 2007-01-10  David Hyatt  <hyatt@apple.com>
3204
3205         Make the selectionRect() method of RenderText better by reusing computeAbsoluteRepaintRect.  This enables
3206         the method to be multi-column aware and also to understand when the selection is clipped out by overflow.
3207
3208         Reviewed by bdash
3209
3210         * rendering/RenderText.cpp:
3211         (WebCore::RenderText::selectionRect):
3212
3213 2007-01-10  David Hyatt  <hyatt@apple.com>
3214
3215         Make the absolutePosition method multi-column aware.  Note that there is now a real problem with the
3216         absoluteRects method, since an object can split across multiple columns and break into multiple rects.
3217         absolutePosition just returns the top-left corner of the element's box in the first column in which it
3218         appears.
3219
3220         Reviewed by bdash
3221
3222         * rendering/RenderBlock.cpp:
3223         (WebCore::RenderBlock::adjustRectForColumns):
3224         * rendering/RenderBlock.h:
3225         * rendering/RenderBox.cpp:
3226         (WebCore::RenderBox::absolutePosition):
3227         (WebCore::RenderBox::computeAbsoluteRepaintRect):
3228         * rendering/RenderFlow.cpp:
3229         (WebCore::RenderFlow::getAbsoluteRepaintRect):
3230
3231 2007-01-09  David Hyatt  <hyatt@apple.com>
3232
3233         Avoid crashing when repainting multiple columns... make sure to use the current vector's size and
3234         not the newly-computed column count.
3235
3236         * rendering/RenderBlock.cpp:
3237         (WebCore::RenderBlock::layoutColumns):
3238         (WebCore::RenderBlock::adjustRepaintRectForColumns):
3239
3240 2007-01-09  David Hyatt  <hyatt@apple.com>
3241
3242         Break up painting and hit testing of children into helper methods and add multi-column versions for both.
3243         
3244         Make incremental repainting able to invalidate the right spot in multiple column layouts so that e.g., link
3245         hover works.
3246
3247         Turn off selection gap filling in columns for now until it can be made to work correctly.
3248
3249         Improve the column balancing heuristic by adding in the block's lineHeight/2 to each column initially to
3250         account for column break adjustments that shrink the columns slightly.  Avoid clipping of the last column's
3251         contents by ensuring it gets all the remaining available height.
3252
3253         Reviewed by mitz
3254
3255         * rendering/RenderBlock.cpp:
3256         (WebCore::RenderBlock::paintColumns):
3257         (WebCore::RenderBlock::paintContents):
3258         (WebCore::RenderBlock::paintObject):
3259         (WebCore::RenderBlock::fillSelectionGaps):
3260         (WebCore::RenderBlock::nodeAtPoint):
3261         (WebCore::RenderBlock::hitTestColumns):
3262         (WebCore::RenderBlock::layoutColumns):
3263         (WebCore::RenderBlock::adjustRepaintRectForColumns):
3264         * rendering/RenderBlock.h:
3265         * rendering/RenderBox.cpp:
3266         (WebCore::RenderBox::computeAbsoluteRepaintRect):
3267         * rendering/RenderFlow.cpp:
3268         (WebCore::RenderFlow::getAbsoluteRepaintRect):
3269
3270 2007-01-09  Remi Zara  <remi_zara@mac.com>
3271
3272         Reviewed by Darin and Eric.
3273
3274         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
3275
3276         Don't use memset to set float to 0
3277
3278         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
3279         (WebCore::cgGradientCallback):
3280
3281 2007-01-09  Anders Carlsson  <acarlsson@apple.com>
3282
3283         Reviewed by Brady.
3284
3285         Add default constructor to SharedBuffer.
3286
3287         * platform/SharedBuffer.cpp:
3288         (WebCore::SharedBuffer::SharedBuffer):
3289         * platform/SharedBuffer.h:
3290
3291 2007-01-09  David Hyatt  <hyatt@apple.com>
3292
3293         This patch gets rudimentary column layout working.  Normal flow content only gets laid out into
3294         columns properly and painted correctly initially.  What doesn't work: hit testing, incremental repainting,
3295         column rule painting, child layers.
3296
3297         Some work needs to be done on the render tree dumper before column tests will be
3298         meaningful.
3299
3300         Also reworked overflow and fixed a bunch of bugs with the computation of overflow.  These include an error
3301         in the height calculations caused by not adding in the horizontal scrollbar height and other errors caused
3302         by not checking overflow in lowest/rightmostPosition.  Existing tests improve their rendering to match
3303         Firefox with this change.
3304
3305         Fixed a bug where a table cell incorrectly expanded to encompass floats inside an overflow:auto block.
3306         This should not have happened.  Covered by new test fast/overflow/table-overflow-float.html.
3307
3308         Reviewed by mitz
3309
3310         * page/Frame.cpp:
3311         * rendering/RenderBlock.cpp:
3312         (WebCore:::RenderFlow):
3313         (WebCore::RenderBlock::layoutBlock):
3314         (WebCore::RenderBlock::paintContents):
3315         (WebCore::RenderBlock::paintChildren):
3316         (WebCore::RenderBlock::paintObject):
3317         (WebCore::RenderBlock::lowestPosition):
3318         (WebCore::RenderBlock::rightmostPosition):
3319         (WebCore::RenderBlock::leftmostPosition):
3320         (WebCore::RenderBlock::avoidsFloats):
3321         (WebCore::RenderBlock::nodeAtPoint):
3322         (WebCore::RenderBlock::hitTestContents):
3323         (WebCore::RenderBlock::layoutColumns):
3324         * rendering/RenderBlock.h:
3325         (WebCore::RenderBlock::hasOverhangingFloats):
3326         (WebCore::RenderBlock::hasColumns):
3327         * rendering/RenderFlexibleBox.cpp:
3328         (WebCore::RenderFlexibleBox::layoutBlock):
3329         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
3330         (WebCore::RenderFlexibleBox::layoutVerticalBox):
3331         * rendering/RenderFlow.cpp:
3332         (WebCore::RenderFlow::paintLines):
3333         (WebCore::RenderFlow::lowestPosition):
3334         (WebCore::RenderFlow::rightmostPosition):
3335         (WebCore::RenderFlow::leftmostPosition):
3336         * rendering/RenderFlow.h:
3337         (WebCore::RenderFlow::hasColumns):
3338         * rendering/RenderListMarker.cpp:
3339         (WebCore::RenderListMarker::paint):
3340         * rendering/RenderObject.h:
3341         (WebCore::RenderObject::expandsToEncloseOverflow):
3342         * rendering/RenderTableCell.h:
3343         (WebCore::RenderTableCell::expandsToEncloseOverflow):
3344         * rendering/RenderView.cpp:
3345         (WebCore::RenderView::paint):
3346
3347 2007-01-09  Darin Adler  <darin@apple.com>
3348
3349         - update all 2007 Apple copyrights for the new company name
3350
3351         * css/cssstyleselector.cpp:
3352         * html/HTMLLIElement.cpp:
3353         * platform/CharacterNames.h:
3354         * platform/TextBreakIterator.h:
3355         * platform/TextBreakIteratorICU.cpp:
3356         * platform/graphics/ImageBuffer.h:
3357         * rendering/CounterNode.cpp:
3358         * rendering/CounterNode.h:
3359         * rendering/RenderBox.h:
3360         * rendering/RenderContainer.cpp:
3361         * rendering/RenderCounter.cpp:
3362         * rendering/RenderCounter.h:
3363         * rendering/RenderImage.h:
3364         * rendering/RenderListItem.h:
3365         * rendering/RenderListMarker.h:
3366         * rendering/RenderObject.cpp:
3367         * rendering/RenderObject.h:
3368         * rendering/RenderStyle.cpp:
3369         * rendering/RenderStyle.h:
3370         * rendering/RenderTable.cpp:
3371         * rendering/RenderTableCell.cpp:
3372         * rendering/RenderTableCell.h:
3373         * rendering/RenderText.cpp:
3374         * rendering/RenderText.h:
3375         * rendering/RenderTreeAsText.cpp:
3376         * rendering/SVGRenderTreeAsText.cpp:
3377         * rendering/break_lines.cpp:
3378
3379 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
3380
3381         Reviewed by john
3382
3383         <rdar://problem/4840662>
3384         REGRESSION: Mail crash when dragging text into a link
3385         
3386         moveParagraphs fails to move content into a display:block 
3387         anchor because of code in positionAvoidingSpecialElementBoundary,
3388         and so it infinitely recurs.
3389         
3390         * editing/htmlediting.cpp:
3391         (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors
3392         that have display:block so that content is inserted in the expected
3393         paragraph.  This fixes the bug and weird behavior when typing before/after
3394         anchors with display:block.
3395
3396 2007-01-09  Rob Buis  <buis@kde.org>
3397
3398         Reviewed by Darin.
3399
3400         http://bugs.webkit.org/show_bug.cgi?id=12145
3401         Color parsing is too relaxed in strict mode
3402         http://bugs.webkit.org/show_bug.cgi?id=12166
3403         REGRESSION (r18480): "336633" is not parsed as a color
3404
3405         Fix a regression by using String::format return value.
3406         Also make strict mode more strict for cases where hexcolors
3407         lack a #.
3408
3409         * css/cssparser.cpp:
3410         (WebCore::CSSParser::parseColor):
3411         (WebCore::CSSParser::parseColorFromValue):
3412         * css/cssparser.h:
3413
3414 2007-01-09  Darin Adler  <darin@apple.com>
3415
3416         Reviewed by Maciej.
3417
3418         - fixed regression where redirects did not have user-agent any more
3419
3420         Showed up as a failure in one of the http tests, so no new test needed.
3421
3422         * loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest):
3423         Don't use a copy of the ResourceRequest; pass the original so it can be modified.
3424
3425 2007-01-09  Mitz Pettel  <mitz@webkit.org>
3426
3427         Reviewed by Darin.
3428
3429         - fix http://bugs.webkit.org/show_bug.cgi?id=11078
3430           Forms Don't Submit (ASP Pages)
3431
3432         Test: fast/dom/collection-namedItem-via-item.html
3433
3434         * bindings/js/kjs_html.cpp:
3435         (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back
3436         to namedItem() if its argument does not convert to a number.
3437
3438 2007-01-09  Darin Adler  <darin@apple.com>
3439
3440         Reviewed by Maciej.
3441
3442         - fix http://bugs.webkit.org/show_bug.cgi?id=12174
3443           improve Unicode use (less WTF::Unicode:: prefix, centralized character names)
3444
3445         - got rid of namespace prefixes from most uses of WTF::Unicode
3446
3447         - updated for removal of WTF::Unicode::memcmp
3448         - updated for renaming of WTF::Unicode::strcasecmp to umemcasecmp.
3449
3450         - unified constants for special Unicode characters in a new
3451           CharacterNames.h header
3452
3453         * WebCore.xcodeproj/project.pbxproj:
3454         * css/cssparser.cpp:
3455         (WebCore::ParseString::lower):
3456         * dom/Document.cpp:
3457         (WebCore::isValidNameStart):
3458         (WebCore::isValidNamePart):
3459         * dom/Position.cpp:
3460         (WebCore::Position::leadingWhitespacePosition):
3461         (WebCore::Position::trailingWhitespacePosition):
3462         * editing/CompositeEditCommand.cpp:
3463         (WebCore::isWhitespace):
3464         * editing/HTMLInterchange.cpp:
3465         * editing/TextIterator.cpp:
3466         (WebCore::CircularSearchBuffer::CircularSearchBuffer):
3467         (WebCore::CircularSearchBuffer::append):
3468         * editing/htmlediting.cpp:
3469         (WebCore::stringWithRebalancedWhitespace):
3470         (WebCore::nonBreakingSpaceString):
3471         * editing/htmlediting.h:
3472         * html/HTMLFontElement.cpp:
3473         (WebCore::parseFontSizeNumber):
3474         * html/HTMLParser.cpp:
3475         (WebCore::HTMLParser::handleError):
3476         * html/HTMLSelectElement.cpp:
3477         (WebCore::stripLeadingWhiteSpace):
3478         * platform/Font.cpp:
3479         (WebCore::WidthIterator::advance):
3480         (WebCore::WidthIterator::normalizeVoicingMarks):
3481         * platform/GlyphMap.cpp:
3482         (WebCore::GlyphMap::locatePage):
3483         * platform/MimeTypeRegistry.h:
3484         * platform/StringHash.h:
3485         * platform/StringImpl.cpp:
3486         (WebCore::isSpace):
3487         (WebCore::StringImpl::append):
3488         (WebCore::StringImpl::insert):
3489         (WebCore::StringImpl::truncate):
3490         (WebCore::StringImpl::remove):
3491         (WebCore::parseLength):
3492         (WebCore::StringImpl::isLower):
3493         (WebCore::StringImpl::lower):
3494         (WebCore::StringImpl::upper):
3495         (WebCore::StringImpl::secure):
3496         (WebCore::StringImpl::foldCase):
3497         (WebCore::StringImpl::capitalize):t
3498         (WebCore::StringImpl::toInt):
3499         (WebCore::equalIgnoringCase):
3500         (WebCore::StringImpl::find):
3501         * platform/TextBoundaries.h:
3502         * platform/TextCodec.h:
3503         * platform/TextCodecLatin1.cpp:
3504         * platform/TextEncoding.h:
3505         * platform/TextEncodingRegistry.h:
3506         * platform/mac/PasteboardMac.mm:
3507         (WebCore::Pasteboard::writeSelection):
3508         * platform/mac/TextCodecMac.cpp:
3509         (WebCore::TextCodecMac::decode):
3510         * rendering/RenderBlock.cpp:
3511         (WebCore::RenderBlock::updateFirstLetter):
3512         * rendering/RenderListMarker.cpp:
3513         (WebCore::listMarkerText):
3514         (WebCore::RenderListMarker::paint):
3515         * rendering/RenderText.cpp:
3516         (WebCore::RenderText::widthFromCache):
3517         (WebCore::isSpaceAccordingToStyle):
3518         (WebCore::RenderText::setInternalString):
3519         * rendering/RenderTreeAsText.cpp:
3520         (WebCore::quoteAndEscapeNonPrintables):
3521         (WebCore::operator<<):
3522         * rendering/bidi.cpp:
3523         (WebCore::BidiState::BidiState):
3524         (WebCore::BidiContext::BidiContext):
3525         (WebCore::bidiNext):
3526         (WebCore::bidiFirst):
3527         (WebCore::BidiIterator::direction):
3528         (WebCore::appendRun):
3529         (WebCore::embed):
3530         (WebCore::RenderBlock::bidiReorderLine):
3531         (WebCore::RenderBlock::layoutInlineChildren):
3532         (WebCore::skipNonBreakingSpace):
3533         (WebCore::RenderBlock::findNextLineBreak):
3534         * rendering/break_lines.cpp:
3535         (WebCore::nextBreakablePosition):
3536         * rendering/break_lines.h:
3537         * xml/XPathParser.cpp:
3538         (WebCore::XPath::charCat):
3539
3540 2007-01-09  Dex Deacon  <occupant4@gmail.com>
3541
3542         Reviewed by Darin.
3543
3544         - fix http://bugs.webkit.org/show_bug.cgi?id=12170
3545           RenderView holds dangling reference to RenderObjects as selection markers
3546
3547         This fixes the crash seen on Windows -- the underlying problem
3548         may still exist.
3549
3550         * rendering/RenderText.h:
3551         (WebCore::RenderText::selectionState):
3552         Change the m_selectionState enum-bitfield to an unsigned-bitfield,
3553         because enums on Windows are signed, which caused it to become
3554         negative (whereas the valid values are all positive).
3555
3556 2007-01-09  Darin Adler  <darin@apple.com>
3557
3558         Reviewed by Hyatt.
3559
3560         - http://bugs.webkit.org/show_bug.cgi?id=12175
3561           port break_lines.cpp to be platform independent
3562
3563         * platform/TextBreakIterator.h: Added lineBreakIterator.
3564         Removed ICU-specific stuff from the header.
3565
3566         * platform/TextBreakIteratorICU.cpp:
3567         (WebCore::setUpIterator): Added helper to be shared by the three different
3568         creation functions.
3569         (WebCore::characterBreakIterator): Changed to use setUpIterator.
3570         (WebCore::wordBreakIterator): Ditto.
3571         (WebCore::lineBreakIterator): Added.
3572
3573         * platform/qt/TextBreakIteratorQt.cpp:
3574         (WebCore::lineBreakIterator): Added a stub.
3575
3576         * rendering/break_lines.cpp:
3577         (WebCore::isBreakableSpace): Added.
3578         (WebCore::shouldBreakAfter): Added.
3579         (WebCore::needsAdvancedBreakAnalysis): Added.
3580         (WebCore::nextBreakablePosition): Changed to use TextBreakIterator on platforms
3581         other than Mac.
3582
3583 2007-01-09  Maciej Stachowiak  <mjs@apple.com>
3584
3585         Reviewed by Darin.
3586
3587         - move WebDataProtocol load handling from ResourceLoader to MainResourceLoader
3588         
3589         (it's only ever used for main resources)
3590
3591         * loader/ResourceLoader.h:
3592         (WebCore::ResourceLoader::setRequest):
3593         * loader/mac/MainResourceLoaderMac.mm:
3594         (WebCore::MainResourceLoader::willSendRequest):
3595         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3596         * loader/mac/ResourceLoaderMac.mm:
3597         (WebCore::ResourceLoader::willSendRequest):
3598         (WebCore::ResourceLoader::didReceiveResponse):
3599
3600 2007-01-09  Rob Buis  <buis@kde.org>