WebCore/ChangeLog

   1 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
   2
   3         Reviewed by Maciej.
   4
   5         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
   6         Includes some CRLF -> LF fixups.
   7
   8         * platform/win/CookieJarWin.cpp:
   9         (WebCore::cookies):
  10
  11 2006-10-31  Adam Roben  <aroben@apple.com>
  12
  13         Reviewed by Steve.
  14
  15         Fix some incorrect forward declarations.
  16
  17         * loader/FrameLoader.h:
  18         * page/Frame.h:
  19
  20 2006-10-31  Darin Adler  <darin@apple.com>
  21
  22         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
  23         try to fix the build on the buildbot.
  24
  25 2006-10-31  Darin Adler  <darin@apple.com>
  26
  27         * bridge/mac/FrameMac.mm:
  28         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
  29         (WebCore::FrameMac::markMisspellings): Ditto.
  30
  31 2006-10-31  John Sullivan  <sullivan@apple.com>
  32
  33         * bridge/mac/FrameMac.mm:
  34         (WebCore::FrameMac::advanceToNextMisspelling):
  35         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
  36
  37 2006-10-30  John Sullivan  <sullivan@apple.com>
  38
  39         Reviewed by Adam Roben
  40
  41         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
  42
  43         This patch introduces much of the guts of grammar checking, though still not enough to actually
  44         check grammar sensibly, due to:
  45
  46         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient
  47         context passed to grammar checker
  48
  49         * platform/Logging.h:
  50         * platform/Logging.cpp:
  51         new log channel SpellingAndGrammar
  52
  53         * bridge/mac/WebCorePageBridge.mm:
  54         (initializeLoggingChannelsIfNecessary):
  55         initialize new log channel
  56
  57         * bridge/mac/FrameMac.mm:
  58         (WebCore::FrameMac::advanceToNextMisspelling):
  59         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
  60         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
  61         in the event of a tie), and do further processing with that one (select range; create marker that
  62         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
  63         (WebCore::FrameMac::markMisspellings):
  64         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just
  65         differently enough to make sharing code between these two functions a little tricky, so I decided to
  66         save that for a later patch.
  67
  68         (WebCore::FrameMac::respondToChangedSelection):
  69         remove grammar markers when we remove spelling markers
  70
  71 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
  72
  73         Reviewed by Mitz.
  74
  75         Fix Qt/Linux build with older gcc3.3.4.
  76
  77         * bindings/js/kjs_window.cpp:
  78         (KJS::WindowFunc::callAsFunction):
  79
  80 2006-10-31  Zack Rusin  <zack@kde.org>
  81
  82         Reviewed by Mitz.
  83
  84         Fix the Qt build after last nights changes.
  85
  86         * WebCore/platform/qt/FrameQt.cpp:
  87         * WebCore/platform/qt/EditorClientQt.h:
  88         * WebCore/platform/qt/EditorClientQt.cpp:
  89         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
  90         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
  91         * WebCore/CMakeLists.txt:
  92         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
  93         * WebKitQt/QtLauncher/CMakeLists.txt:
  94         * WebKitQt/WebKitPart/CMakeLists.txt:
  95
  96 2006-10-30  Darin Adler  <darin@apple.com>
  97
  98         Reviewed by Anders.
  99
 100         - remove BrowserExtension
 101
 102         * WebCore.vcproj/WebCore/WebCore.vcproj:
 103         * WebCore.xcodeproj/project.pbxproj:
 104         * bindings/js/kjs_window.cpp:
 105         (KJS::createNewWindow):
 106         (KJS::WindowFunc::callAsFunction):
 107         * bridge/BrowserExtension.h: Removed.
 108         * bridge/mac/BrowserExtensionMac.h: Removed.
 109         * bridge/mac/BrowserExtensionMac.mm: Removed.
 110         * bridge/mac/FrameMac.mm:
 111         (WebCore::FrameMac::FrameMac):
 112         (WebCore::FrameMac::submitForm):
 113         (WebCore::FrameMac::urlSelected):
 114         * bridge/win/BrowserExtensionWin.cpp: Removed.
 115         * bridge/win/BrowserExtensionWin.h: Removed.
 116         * bridge/win/FrameWin.cpp:
 117         (WebCore::FrameWin::FrameWin):
 118         * loader/FrameLoader.cpp:
 119         (WebCore::FrameLoader::createWindow):
 120         * loader/FrameLoader.h:
 121         * loader/icon/IconLoader.cpp:
 122         * loader/mac/FrameLoaderMac.mm:
 123         (WebCore::FrameLoader::safeLoad):
 124         (WebCore::FrameLoader::load):
 125         (WebCore::FrameLoader::createWindow):
 126         * page/Frame.cpp:
 127         (WebCore::Frame::urlSelected):
 128         (WebCore::Frame::requestFrame):
 129         (WebCore::Frame::submitForm):
 130         (WebCore::Frame::scheduleHistoryNavigation):
 131         (WebCore::Frame::redirectionTimerFired):
 132         * page/Frame.h:
 133         * page/FrameLoadRequest.h:
 134         (WebCore::FrameLoadRequest::FrameLoadRequest):
 135         (WebCore::FrameLoadRequest::isEmpty):
 136         (WebCore::FrameLoadRequest::resourceRequest):
 137         (WebCore::FrameLoadRequest::frameName):
 138         (WebCore::FrameLoadRequest::setFrameName):
 139         * page/FramePrivate.h:
 140         (WebCore::FramePrivate::FramePrivate):
 141         (WebCore::FramePrivate::~FramePrivate):
 142         * platform/gdk/BrowserExtensionGdk.h: Removed.
 143         * platform/gdk/FrameGdk.cpp:
 144         (WebCore::FrameGdk::FrameGdk):
 145         * platform/gdk/TemporaryLinkStubs.cpp:
 146         * platform/network/ResourceRequest.h:
 147         (WebCore::ResourceRequest::isEmpty):
 148
 149 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
 150
 151         Reviewed by Oliver.
 152
 153         Modified from original due to earlier reversion
 154
 155         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
 156
 157         Better SVG integration in WebKit, Part I.
 158
 159         The patch is mostly about creating a new platform/graphics directory, and
 160         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
 161         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
 162         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
 163
 164         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
 165         All details of the patch, and upcoming patches can be found in the bug report.
 166
 167         * CMakeLists.txt:
 168         * WebCore.xcodeproj/project.pbxproj:
 169         * graphics/svg/SVGResource.cpp: Removed.
 170         * graphics/svg/SVGResourceClipper.cpp: Removed.
 171         * graphics/svg/SVGResourceClipper.h: Removed.
 172         * graphics/svg/SVGResourceImage.h: Removed.
 173         * graphics/svg/SVGResourceListener.h: Removed.
 174         * graphics/svg/SVGResourceMarker.cpp: Removed.
 175         * graphics/svg/SVGResourceMarker.h: Removed.
 176         * graphics/svg/SVGResourceMasker.cpp: Removed.
 177         * graphics/svg/SVGResourceMasker.h: Removed.
 178         * kcanvas/KCanvasClipper.cpp: Removed.
 179         * kcanvas/KCanvasClipper.h: Removed.
 180         * kcanvas/KCanvasCreator.cpp: Removed.
 181         * kcanvas/KCanvasCreator.h: Removed.
 182         * kcanvas/KCanvasFilters.cpp:
 183         (WebCore::getFilterById):
 184         * kcanvas/KCanvasFilters.h:
 185         * kcanvas/KCanvasImage.h: Removed.
 186         * kcanvas/KCanvasMarker.cpp: Removed.
 187         * kcanvas/KCanvasMarker.h: Removed.
 188         * kcanvas/KCanvasMasker.cpp: Removed.
 189         * kcanvas/KCanvasMasker.h: Removed.
 190         * kcanvas/KCanvasResource.cpp: Removed.
 191         * kcanvas/KCanvasResource.h: Removed.
 192         * kcanvas/KCanvasResourceListener.h: Removed.
 193         * kcanvas/KCanvasTreeDebug.cpp:
 194         (WebCore::writeRenderResources):
 195         * kcanvas/device/KRenderingDevice.h:
 196         * kcanvas/device/KRenderingPaintServer.h:
 197         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
 198         * kcanvas/device/KRenderingPaintServerGradient.cpp:
 199         (WebCore::KRenderingPaintServerGradient::listener):
 200         (WebCore::KRenderingPaintServerGradient::setListener):
 201         * kcanvas/device/KRenderingPaintServerGradient.h:
 202         * kcanvas/device/KRenderingPaintServerPattern.cpp:
 203         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
 204         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
 205         (WebCore::KRenderingPaintServerPattern::tile):
 206         (WebCore::KRenderingPaintServerPattern::setTile):
 207         (WebCore::KRenderingPaintServerPattern::listener):
 208         (WebCore::KRenderingPaintServerPattern::setListener):
 209         * kcanvas/device/KRenderingPaintServerPattern.h:
 210         * kcanvas/device/KRenderingPaintServerSolid.h:
 211         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
 212         * kcanvas/device/qt/KCanvasClipperQt.h:
 213         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
 214         (WebCore::KRenderingDeviceQt::contextForImage):
 215         (WebCore::KRenderingDeviceQt::createResource):
 216         (WebCore::KRenderingDeviceQt::createPaintServer):
 217         * kcanvas/device/qt/KRenderingDeviceQt.h:
 218         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
 219         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
 220         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
 221         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
 222         * kcanvas/device/qt/RenderPathQt.h: Removed.
 223         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
 224         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
 225         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
 226         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
 227         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
 228         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
 229         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
 230         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
 231         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
 232         (WebCore::KRenderingDeviceQuartz::contextForImage):
 233         (WebCore::KRenderingDeviceQuartz::createPaintServer):
 234         (WebCore::KRenderingDeviceQuartz::createResource):
 235         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
 236         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
 237         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
 238         (WebCore::KRenderingPaintServerGradientQuartz::setup):
 239         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
 240         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
 241         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
 242         (WebCore::patternCallback):
 243         (WebCore::KRenderingPaintServerPatternQuartz::setup):
 244         * kcanvas/device/quartz/QuartzSupport.mm:
 245         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 246         (WebCore::sharedSolidPaintServer):
 247         * ksvg2/svg/SVGClipPathElement.cpp:
 248         (WebCore::SVGClipPathElement::SVGClipPathElement):
 249         (WebCore::SVGClipPathElement::~SVGClipPathElement):
 250         (WebCore::SVGClipPathElement::canvasResource):
 251         * ksvg2/svg/SVGClipPathElement.h:
 252         * ksvg2/svg/SVGFEImageElement.cpp:
 253         * ksvg2/svg/SVGFilterElement.cpp:
 254         (WebCore::SVGFilterElement::SVGFilterElement):
 255         (WebCore::SVGFilterElement::~SVGFilterElement):
 256         (WebCore::SVGFilterElement::canvasResource):
 257         * ksvg2/svg/SVGFilterElement.h:
 258         * ksvg2/svg/SVGGradientElement.cpp:
 259         (WebCore::SVGGradientElement::SVGGradientElement):
 260         (WebCore::SVGGradientElement::~SVGGradientElement):
 261         (WebCore::SVGGradientElement::canvasResource):
 262         (WebCore::SVGGradientElement::resourceNotification):
 263         * ksvg2/svg/SVGGradientElement.h:
 264         * ksvg2/svg/SVGImageElement.cpp:
 265         * ksvg2/svg/SVGLinearGradientElement.cpp:
 266         (WebCore::SVGLinearGradientElement::buildGradient):
 267         * ksvg2/svg/SVGLinearGradientElement.h:
 268         * ksvg2/svg/SVGMarkerElement.cpp:
 269         (WebCore::SVGMarkerElement::SVGMarkerElement):
 270         (WebCore::SVGMarkerElement::~SVGMarkerElement):
 271         (WebCore::SVGMarkerElement::canvasResource):
 272         * ksvg2/svg/SVGMarkerElement.h:
 273         * ksvg2/svg/SVGMaskElement.cpp:
 274         (WebCore::SVGMaskElement::SVGMaskElement):
 275         (WebCore::SVGMaskElement::~SVGMaskElement):
 276         (WebCore::SVGMaskElement::drawMaskerContent):
 277         (WebCore::SVGMaskElement::canvasResource):
 278         * ksvg2/svg/SVGMaskElement.h:
 279         * ksvg2/svg/SVGPatternElement.cpp:
 280         (WebCore::SVGPatternElement::SVGPatternElement):
 281         (WebCore::SVGPatternElement::~SVGPatternElement):
 282         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
 283         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
 284         (WebCore::SVGPatternElement::canvasResource):
 285         * ksvg2/svg/SVGPatternElement.h:
 286         * ksvg2/svg/SVGRadialGradientElement.cpp:
 287         (WebCore::SVGRadialGradientElement::buildGradient):
 288         * ksvg2/svg/SVGRadialGradientElement.h:
 289         * ksvg2/svg/SVGStyledElement.h:
 290         (WebCore::SVGStyledElement::canvasResource):
 291         * platform/GraphicsContext.cpp: Removed.
 292         * platform/GraphicsContext.h: Removed.
 293         * platform/GraphicsTypes.cpp: Removed.
 294         * platform/GraphicsTypes.h: Removed.
 295         * platform/graphics/GraphicsContext.cpp:
 296         (WebCore::GraphicsContextState::GraphicsContextState):
 297         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
 298         (WebCore::GraphicsContext::createGraphicsContextPrivate):
 299         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
 300         (WebCore::GraphicsContext::save):
 301         (WebCore::GraphicsContext::restore):
 302         (WebCore::GraphicsContext::font):
 303         (WebCore::GraphicsContext::setFont):
 304         (WebCore::GraphicsContext::pen):
 305         (WebCore::GraphicsContext::setPen):
 306         (WebCore::GraphicsContext::setFillColor):
 307         (WebCore::GraphicsContext::fillColor):
 308         (WebCore::GraphicsContext::updatingControlTints):
 309         (WebCore::GraphicsContext::setUpdatingControlTints):
 310         (WebCore::GraphicsContext::setPaintingDisabled):
 311         (WebCore::GraphicsContext::paintingDisabled):
 312         (WebCore::GraphicsContext::drawImage):
 313         (WebCore::GraphicsContext::drawText):
 314         (WebCore::GraphicsContext::drawHighlightForText):
 315         (WebCore::GraphicsContext::initFocusRing):
 316         (WebCore::GraphicsContext::clearFocusRing):
 317         (WebCore::GraphicsContext::focusRingBoundingRect):
 318         (WebCore::GraphicsContext::addFocusRingRect):
 319         (WebCore::GraphicsContext::focusRingWidth):
 320         (WebCore::GraphicsContext::focusRingOffset):
 321         (WebCore::GraphicsContext::focusRingRects):
 322         (WebCore::GraphicsContext::drawTiledImage):
 323         * platform/graphics/GraphicsContext.h:
 324         * platform/graphics/GraphicsTypes.cpp:
 325         (WebCore::):
 326         (WebCore::parseCompositeOperator):
 327         (WebCore::compositeOperatorName):
 328         (WebCore::parseLineCap):
 329         (WebCore::lineCapName):
 330         (WebCore::parseLineJoin):
 331         (WebCore::lineJoinName):
 332         * platform/graphics/GraphicsTypes.h:
 333         (WebCore::):
 334         * platform/graphics/svg/SVGResource.cpp: Added.
 335         (WebCore::SVGResource::SVGResource):
 336         (WebCore::SVGResource::~SVGResource):
 337         (WebCore::SVGResource::invalidate):
 338         (WebCore::SVGResource::addClient):
 339         (WebCore::SVGResource::clients):
 340         (WebCore::SVGResource::idInRegistry):
 341         (WebCore::SVGResource::setIdInRegistry):
 342         (WebCore::SVGResource::externalRepresentation):
 343         (WebCore::getResourceById):
 344         (WebCore::getPaintServerById):
 345         (WebCore::operator<<):
 346         * platform/graphics/svg/SVGResource.h: Added.
 347         (WebCore::):
 348         (WebCore::SVGResource::isPaintServer):
 349         (WebCore::SVGResource::isFilter):
 350         (WebCore::SVGResource::isClipper):
 351         (WebCore::SVGResource::isMarker):
 352         (WebCore::SVGResource::isMasker):
 353         (WebCore::SVGResourceListener::~SVGResourceListener):
 354         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
 355         (WebCore::SVGResourceClipper::SVGResourceClipper):
 356         (WebCore::SVGResourceClipper::~SVGResourceClipper):
 357         (WebCore::SVGResourceClipper::resetClipData):
 358         (WebCore::SVGResourceClipper::addClipData):
 359         (WebCore::SVGResourceClipper::clipData):
 360         (WebCore::SVGResourceClipper::externalRepresentation):
 361         (WebCore::operator<<):
 362         (WebCore::getClipperById):
 363         * platform/graphics/svg/SVGResourceClipper.h: Added.
 364         (WebCore::ClipDataList::addPath):
 365         (WebCore::SVGResourceClipper::isClipper):
 366         * platform/graphics/svg/SVGResourceImage.h: Added.
 367         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
 368         (WebCore::SVGResourceMarker::SVGResourceMarker):
 369         (WebCore::SVGResourceMarker::~SVGResourceMarker):
 370         (WebCore::SVGResourceMarker::setMarker):
 371         (WebCore::SVGResourceMarker::setRef):
 372         (WebCore::SVGResourceMarker::draw):
 373         (WebCore::SVGResourceMarker::externalRepresentation):
 374         (WebCore::getMarkerById):
 375         * platform/graphics/svg/SVGResourceMarker.h: Added.
 376         (WebCore::SVGResourceMarker::refX):
 377         (WebCore::SVGResourceMarker::refY):
 378         (WebCore::SVGResourceMarker::setAngle):
 379         (WebCore::SVGResourceMarker::setAutoAngle):
 380         (WebCore::SVGResourceMarker::angle):
 381         (WebCore::SVGResourceMarker::setUseStrokeWidth):
 382         (WebCore::SVGResourceMarker::useStrokeWidth):
 383         (WebCore::SVGResourceMarker::isMarker):
 384         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
 385         (WebCore::SVGResourceMasker::SVGResourceMasker):
 386         (WebCore::SVGResourceMasker::~SVGResourceMasker):
 387         (WebCore::SVGResourceMasker::setMask):
 388         (WebCore::SVGResourceMasker::mask):
 389         (WebCore::SVGResourceMasker::externalRepresentation):
 390         (WebCore::getMaskerById):
 391         * platform/graphics/svg/SVGResourceMasker.h: Added.
 392         (WebCore::SVGResourceMasker::isMasker):
 393         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
 394         (WebCore::SVGResourceClipper::applyClip):
 395         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
 396         (WebCore::SVGResourceImage::SVGResourceImage):
 397         (WebCore::SVGResourceImage::~SVGResourceImage):
 398         (WebCore::SVGResourceImage::init):
 399         (WebCore::SVGResourceImage::size):
 400         (WebCore::SVGResourceImage::cgLayer):
 401         (WebCore::SVGResourceImage::setCGLayer):
 402         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
 403         (WebCore::applyLuminanceToAlphaFilter):
 404         (WebCore::applyExpandAlphatoGrayscaleFilter):
 405         (WebCore::transformImageIntoGrayscaleMask):
 406         (WebCore::SVGResourceMasker::applyMask):
 407         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
 408         (WebCore::SVGResourceClipper::applyClip):
 409         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
 410         (WebCore::SVGResourceImage::init):
 411         (WebCore::SVGResourceImage::size):
 412         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
 413         (WebCore::SVGResourceMasker::applyMask):
 414         * platform/qt/GraphicsContextQt.cpp:
 415         * rendering/RenderPath.cpp:
 416         (WebCore::RenderPath::paint):
 417         (WebCore::DrawMarkersData::DrawMarkersData):
 418         (WebCore::RenderPath::drawMarkersIfNeeded):
 419         * rendering/RenderSVGContainer.cpp:
 420         (WebCore::RenderSVGContainer::paint):
 421         * rendering/RenderSVGImage.cpp:
 422         (WebCore::RenderSVGImage::paint):
 423         * rendering/SVGInlineFlowBox.cpp:
 424         (WebCore::paintSVGInlineFlow):
 425
 426 2006-10-30  John Sullivan  <sullivan@apple.com>
 427
 428         Reviewed by Brady
 429
 430         - minor cleanup to make future patches clearer
 431
 432         * bridge/mac/FrameMac.mm:
 433         (WebCore::FrameMac::advanceToNextMisspelling):
 434         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
 435         with "continue" to better match structure of similar code in markMisspellings; a few
 436         other style tweaks.
 437
 438         (WebCore::FrameMac::markMisspellings):
 439         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
 440         a block just after a break and outdented accordingly.
 441
 442 2006-10-30  John Sullivan  <sullivan@apple.com>
 443
 444         Reviewed by Geoff Garen
 445
 446         WebCore part of change to push the code that updates the spelling panel
 447         into WebCore, in preparation for some grammar-checking stuff.
 448
 449         * bridge/mac/FrameMac.h:
 450         * bridge/mac/FrameMac.mm:
 451         (WebCore::FrameMac::advanceToNextMisspelling):
 452         no more return value for this method, and update the spelling panel with
 453         the misspelled word here rather than in the WebKit callers.
 454
 455 2006-10-30  Oliver Hunt  <oliver@apple.com>
 456
 457         Reviewed by Anders.
 458
 459         Roll out last patch
 460
 461         * CMakeLists.txt:
 462         * ChangeLog:
 463         * WebCore.xcodeproj/project.pbxproj:
 464         * graphics/svg/SVGResource.cpp:
 465         * graphics/svg/SVGResourceClipper.cpp:
 466         * graphics/svg/SVGResourceClipper.h:
 467         * graphics/svg/SVGResourceImage.h:
 468         * graphics/svg/SVGResourceListener.h:
 469         * graphics/svg/SVGResourceMarker.cpp:
 470         * graphics/svg/SVGResourceMarker.h:
 471         * graphics/svg/SVGResourceMasker.cpp:
 472         * graphics/svg/SVGResourceMasker.h:
 473         * kcanvas/KCanvasClipper.cpp: Added.
 474         (WebCore::operator<<):
 475         (WebCore::KCanvasClipper::KCanvasClipper):
 476         (WebCore::KCanvasClipper::~KCanvasClipper):
 477         (WebCore::KCanvasClipper::resetClipData):
 478         (WebCore::KCanvasClipper::addClipData):
 479         (WebCore::KCanvasClipper::clipData):
 480         (WebCore::KCanvasClipper::externalRepresentation):
 481         (WebCore::getClipperById):
 482         * kcanvas/KCanvasClipper.h: Added.
 483         (WebCore::KCClipData::windRule):
 484         (WebCore::KCClipDataList::KCClipDataList):
 485         (WebCore::KCClipDataList::addPath):
 486         (WebCore::KCanvasClipper::isClipper):
 487         * kcanvas/KCanvasFilters.cpp:
 488         (WebCore::getFilterById):
 489         * kcanvas/KCanvasFilters.h:
 490         * kcanvas/KCanvasImage.h: Added.
 491         (WebCore::KCanvasImage::KCanvasImage):
 492         (WebCore::KCanvasImage::~KCanvasImage):
 493         * kcanvas/KCanvasMarker.cpp: Added.
 494         (WebCore::KCanvasMarker::KCanvasMarker):
 495         (WebCore::KCanvasMarker::~KCanvasMarker):
 496         (WebCore::KCanvasMarker::setMarker):
 497         (WebCore::KCanvasMarker::setRef):
 498         (WebCore::KCanvasMarker::refX):
 499         (WebCore::KCanvasMarker::refY):
 500         (WebCore::KCanvasMarker::setAngle):
 501         (WebCore::KCanvasMarker::angle):
 502         (WebCore::KCanvasMarker::setAutoAngle):
 503         (WebCore::KCanvasMarker::setUseStrokeWidth):
 504         (WebCore::KCanvasMarker::useStrokeWidth):
 505         (WebCore::KCanvasMarker::draw):
 506         (WebCore::KCanvasMarker::externalRepresentation):
 507         (WebCore::getMarkerById):
 508         * kcanvas/KCanvasMarker.h: Added.
 509         (WebCore::KCanvasMarker::isMarker):
 510         * kcanvas/KCanvasMasker.cpp: Added.
 511         (WebCore::KCanvasMasker::KCanvasMasker):
 512         (WebCore::KCanvasMasker::~KCanvasMasker):
 513         (WebCore::KCanvasMasker::setMask):
 514         (WebCore::KCanvasMasker::externalRepresentation):
 515         (WebCore::getMaskerById):
 516         * kcanvas/KCanvasMasker.h: Added.
 517         (WebCore::KCanvasMasker::isMasker):
 518         (WebCore::KCanvasMasker::mask):
 519         * kcanvas/KCanvasResource.cpp: Added.
 520         (WebCore::operator<<):
 521         (WebCore::KCanvasResource::KCanvasResource):
 522         (WebCore::KCanvasResource::~KCanvasResource):
 523         (WebCore::KCanvasResource::addClient):
 524         (WebCore::KCanvasResource::clients):
 525         (WebCore::KCanvasResource::invalidate):
 526         (WebCore::KCanvasResource::idInRegistry):
 527         (WebCore::KCanvasResource::setIdInRegistry):
 528         (WebCore::KCanvasResource::externalRepresentation):
 529         (WebCore::getResourceById):
 530         (WebCore::getPaintServerById):
 531         * kcanvas/KCanvasResource.h:
 532         (WebCore::):
 533         (WebCore::KCanvasResource::isPaintServer):
 534         (WebCore::KCanvasResource::isFilter):
 535         (WebCore::KCanvasResource::isClipper):
 536         (WebCore::KCanvasResource::isMarker):
 537         (WebCore::KCanvasResource::isMasker):
 538         * kcanvas/KCanvasResourceListener.h: Added.
 539         (KCanvasResourceListener::KCanvasResourceListener):
 540         (KCanvasResourceListener::~KCanvasResourceListener):
 541         * kcanvas/KCanvasTreeDebug.cpp:
 542         (WebCore::writeRenderResources):
 543         * kcanvas/device/KRenderingDevice.h:
 544         * kcanvas/device/KRenderingPaintServer.h:
 545         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
 546         (WebCore::KRenderingPaintServer::idInRegistry):
 547         (WebCore::KRenderingPaintServer::setIdInRegistry):
 548         * kcanvas/device/KRenderingPaintServerGradient.cpp:
 549         (WebCore::KRenderingPaintServerGradient::listener):
 550         (WebCore::KRenderingPaintServerGradient::setListener):
 551         * kcanvas/device/KRenderingPaintServerGradient.h:
 552         * kcanvas/device/KRenderingPaintServerPattern.cpp:
 553         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
 554         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
 555         (WebCore::KRenderingPaintServerPattern::tile):
 556         (WebCore::KRenderingPaintServerPattern::setTile):
 557         (WebCore::KRenderingPaintServerPattern::listener):
 558         (WebCore::KRenderingPaintServerPattern::setListener):
 559         * kcanvas/device/KRenderingPaintServerPattern.h:
 560         * kcanvas/device/KRenderingPaintServerSolid.h:
 561         * kcanvas/device/qt/KCanvasClipperQt.cpp:
 562         (WebCore::KCanvasClipperQt::applyClip):
 563         * kcanvas/device/qt/KCanvasClipperQt.h:
 564         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
 565         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
 566         (WebCore::KRenderingDeviceQt::contextForImage):
 567         (WebCore::KRenderingDeviceQt::createResource):
 568         (WebCore::KRenderingDeviceQt::createPaintServer):
 569         * kcanvas/device/qt/KRenderingDeviceQt.h:
 570         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
 571         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
 572         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
 573         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
 574         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
 575         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
 576         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
 577         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
 578         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
 579         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
 580         (WebCore::applyLuminanceToAlphaFilter):
 581         (WebCore::applyExpandAlphatoGrayscaleFilter):
 582         (WebCore::transformImageIntoGrayscaleMask):
 583         (WebCore::KCanvasMaskerQuartz::applyMask):
 584         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
 585         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
 586         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
 587         (WebCore::KCanvasImageQuartz::init):
 588         (WebCore::KCanvasImageQuartz::size):
 589         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
 590         (WebCore::KCanvasClipperQuartz::applyClip):
 591         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
 592         (WebCore::KCanvasImageQuartz::cgLayer):
 593         (WebCore::KCanvasImageQuartz::setCGLayer):
 594         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
 595         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
 596         (WebCore::KRenderingDeviceQuartz::contextForImage):
 597         (WebCore::KRenderingDeviceQuartz::createPaintServer):
 598         (WebCore::KRenderingDeviceQuartz::createResource):
 599         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
 600         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
 601         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
 602         (WebCore::KRenderingPaintServerGradientQuartz::setup):
 603         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
 604         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
 605         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
 606         (WebCore::patternCallback):
 607         (WebCore::KRenderingPaintServerPatternQuartz::setup):
 608         * kcanvas/device/quartz/QuartzSupport.mm:
 609         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 610         (WebCore::sharedSolidPaintServer):
 611         * ksvg2/svg/SVGClipPathElement.cpp:
 612         (WebCore::SVGClipPathElement::SVGClipPathElement):
 613         (WebCore::SVGClipPathElement::~SVGClipPathElement):
 614         (WebCore::SVGClipPathElement::canvasResource):
 615         * ksvg2/svg/SVGClipPathElement.h:
 616         * ksvg2/svg/SVGFEImageElement.cpp:
 617         * ksvg2/svg/SVGFilterElement.cpp:
 618         (WebCore::SVGFilterElement::SVGFilterElement):
 619         (WebCore::SVGFilterElement::~SVGFilterElement):
 620         (WebCore::SVGFilterElement::canvasResource):
 621         * ksvg2/svg/SVGFilterElement.h:
 622         * ksvg2/svg/SVGGradientElement.cpp:
 623         (WebCore::SVGGradientElement::SVGGradientElement):
 624         (WebCore::SVGGradientElement::~SVGGradientElement):
 625         (WebCore::SVGGradientElement::canvasResource):
 626         (WebCore::SVGGradientElement::resourceNotification):
 627         * ksvg2/svg/SVGGradientElement.h:
 628         * ksvg2/svg/SVGImageElement.cpp:
 629         * ksvg2/svg/SVGLinearGradientElement.cpp:
 630         (WebCore::SVGLinearGradientElement::buildGradient):
 631         * ksvg2/svg/SVGLinearGradientElement.h:
 632         * ksvg2/svg/SVGMarkerElement.cpp:
 633         (WebCore::SVGMarkerElement::SVGMarkerElement):
 634         (WebCore::SVGMarkerElement::~SVGMarkerElement):
 635         (WebCore::SVGMarkerElement::canvasResource):
 636         * ksvg2/svg/SVGMarkerElement.h:
 637         * ksvg2/svg/SVGMaskElement.cpp:
 638         (WebCore::SVGMaskElement::SVGMaskElement):
 639         (WebCore::SVGMaskElement::~SVGMaskElement):
 640         (WebCore::SVGMaskElement::drawMaskerContent):
 641         (WebCore::SVGMaskElement::canvasResource):
 642         * ksvg2/svg/SVGMaskElement.h:
 643         * ksvg2/svg/SVGPatternElement.cpp:
 644         (WebCore::SVGPatternElement::SVGPatternElement):
 645         (WebCore::SVGPatternElement::~SVGPatternElement):
 646         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
 647         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
 648         (WebCore::SVGPatternElement::canvasResource):
 649         * ksvg2/svg/SVGPatternElement.h:
 650         * ksvg2/svg/SVGRadialGradientElement.cpp:
 651         (WebCore::SVGRadialGradientElement::buildGradient):
 652         * ksvg2/svg/SVGRadialGradientElement.h:
 653         * ksvg2/svg/SVGStyledElement.h:
 654         (WebCore::SVGStyledElement::canvasResource):
 655         * platform/GraphicsContext.cpp: Added.
 656         (WebCore::GraphicsContextState::GraphicsContextState):
 657         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
 658         (WebCore::GraphicsContext::createGraphicsContextPrivate):
 659         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
 660         (WebCore::GraphicsContext::save):
 661         (WebCore::GraphicsContext::restore):
 662         (WebCore::GraphicsContext::font):
 663         (WebCore::GraphicsContext::setFont):
 664         (WebCore::GraphicsContext::pen):
 665         (WebCore::GraphicsContext::setPen):
 666         (WebCore::GraphicsContext::setFillColor):
 667         (WebCore::GraphicsContext::fillColor):
 668         (WebCore::GraphicsContext::updatingControlTints):
 669         (WebCore::GraphicsContext::setUpdatingControlTints):
 670         (WebCore::GraphicsContext::setPaintingDisabled):
 671         (WebCore::GraphicsContext::paintingDisabled):
 672         (WebCore::GraphicsContext::drawImage):
 673         (WebCore::GraphicsContext::drawText):
 674         (WebCore::GraphicsContext::drawHighlightForText):
 675         (WebCore::GraphicsContext::initFocusRing):
 676         (WebCore::GraphicsContext::clearFocusRing):
 677         (WebCore::GraphicsContext::focusRingBoundingRect):
 678         (WebCore::GraphicsContext::addFocusRingRect):
 679         (WebCore::GraphicsContext::focusRingWidth):
 680         (WebCore::GraphicsContext::focusRingOffset):
 681         (WebCore::GraphicsContext::focusRingRects):
 682         (WebCore::GraphicsContext::drawTiledImage):
 683         * platform/GraphicsContext.h: Added.
 684         * platform/GraphicsTypes.cpp: Added.
 685         (WebCore::):
 686         (WebCore::parseCompositeOperator):
 687         (WebCore::compositeOperatorName):
 688         (WebCore::parseLineCap):
 689         (WebCore::lineCapName):
 690         (WebCore::parseLineJoin):
 691         (WebCore::lineJoinName):
 692         * platform/GraphicsTypes.h: Added.
 693         (WebCore::):
 694         * platform/graphics/GraphicsContext.cpp:
 695         * platform/graphics/GraphicsContext.h:
 696         * platform/graphics/GraphicsTypes.cpp:
 697         * platform/graphics/GraphicsTypes.h:
 698         * platform/qt/GraphicsContextQt.cpp:
 699         * rendering/RenderPath.cpp:
 700         (WebCore::RenderPath::paint):
 701         (WebCore::DrawMarkersData::DrawMarkersData):
 702         (WebCore::RenderPath::drawMarkersIfNeeded):
 703         * rendering/RenderSVGContainer.cpp:
 704         (WebCore::RenderSVGContainer::paint):
 705         * rendering/RenderSVGImage.cpp:
 706         (WebCore::RenderSVGImage::paint):
 707         * rendering/SVGInlineFlowBox.cpp:
 708         (WebCore::paintSVGInlineFlow):
 709
 710 2006-10-30  John Sullivan  <sullivan@apple.com>
 711
 712         Reviewed by Geoff Garen.
 713
 714         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
 715         grammar-related method.
 716
 717         * bridge/EditorClient.h:
 718         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
 719         isGrammarCheckingEnabled()
 720
 721         * bridge/mac/WebCoreFrameBridge.h:
 722         removed bridge equivalents
 723
 724         * bridge/mac/FrameMac.mm:
 725         (WebCore::FrameMac::advanceToNextMisspelling):
 726         convert bridge-using code to editor()->client()-using code
 727         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
 728         ditto
 729         (WebCore::FrameMac::markMisspellings):
 730         ditto
 731         (WebCore::FrameMac::respondToChangedSelection):
 732         ditto
 733
 734         * editing/Editor.h:
 735         * editing/Editor.cpp:
 736         (WebCore::Editor::client):
 737         new method, returns EditorClient pointer. In an ideal world all the code that needed to
 738         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
 739         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
 740
 741 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
 742
 743         Reviewed by Darin.
 744
 745         Removed a number of editing and selection methods from the bridge.
 746
 747         I moved cross-platform editing and selection code into Editor and
 748         SelectionController, respecitvely.
 749
 750         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
 751         everything + the kitchen sink.
 752
 753         Specific comments below for interesting things.
 754
 755         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
 756         a new file so that WebKit can use them, too. Added a helper method for
 757         handling exceptions when selecting a Range.
 758         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into
 759         WebKit, since they have to do with creating an NSAttributedString for API
 760         consumption, and not much to do with general Frame functionality.
 761         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
 762         for now) into the Editor. Eventually, the Frame will not have to notify
 763         the Editor of what the lastEditCommand was, since the Editor will perform
 764         all EditCommands.
 765         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
 766         * editing/SelectionController.cpp:
 767         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
 768         and return them. The bridge method to select a DOM range did this implicitly,
 769         since all ObjC DOM operations handle DOM exceptions by throwing them as
 770         ObjC exceptions.
 771         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
 772         The two enumerations are numerically identical, but that's an implementation
 773         detail of TextAffinity that clients shouldn't be required to know about.
 774
 775 2006-10-30  Timothy Hatcher  <timothy@apple.com>
 776
 777         Rolling out the following change because this crash:
 778         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp)
 779
 780         And this regression:
 781         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
 782
 783     2006-09-06  David Harrison  <harrison@apple.com>
 784
 785         Reviewed and tweaked by Tim H.
 786
 787         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation
 788
 789         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
 790         to trigger a search that will include auto activation. No PLT or iBench perf impact.
 791         No layout tests affected. Not testable in an automated way that will work on all systems.
 792
 793         * platform/mac/WebFontCache.mm:
 794         (+[WebFontCache fontWithFamily:traits:size:]):
 795
 796 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
 797
 798         Reviewed by harrison
 799
 800         <rdar://problem/4808375>
 801         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
 802
 803         * editing/TextIterator.cpp:
 804         (WebCore::TextIterator::exitNode): Only create VisiblePositions
 805         when we're going to use them to create a range for an emitted character.
 806         We should further speed TextIterators up by avoiding creating VisiblePositions
 807         for TIs that are only used for the characters they emit (like the one that
 808         plainText uses).
 809
 810 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
 811
 812         Reviewed by Mitz.
 813
 814         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
 815         More rendering code cleaning
 816
 817         * WebCore.xcodeproj/project.pbxproj:
 818         * rendering/RenderApplet.cpp:
 819         (WebCore::RenderApplet::RenderApplet):
 820         (WebCore::RenderApplet::createWidgetIfNecessary):
 821         * rendering/RenderApplet.h:
 822         * rendering/RenderArena.cpp:
 823         (WebCore::):
 824         (WebCore::RenderArena::RenderArena):
 825         (WebCore::RenderArena::allocate):
 826         (WebCore::RenderArena::free):
 827         * rendering/RenderArena.h:
 828         * rendering/RenderBR.cpp:
 829         (WebCore::RenderBR::RenderBR):
 830         (WebCore::RenderBR::baselinePosition):
 831         (WebCore::RenderBR::lineHeight):
 832         (WebCore::RenderBR::setStyle):
 833         (WebCore::RenderBR::caretMinOffset):
 834         (WebCore::RenderBR::positionForCoordinates):
 835         (WebCore::RenderBR::inlineBox):
 836         * rendering/RenderBR.h:
 837         * rendering/RenderBlock.cpp:
 838         * rendering/RenderBlock.h:
 839         (WebCore::RenderBlock::maxTopMargin):
 840         (WebCore::RenderBlock::maxBottomMargin):
 841         (WebCore::RenderBlock::initMaxMarginValues):
 842         (WebCore::RenderBlock::containsFloats):
 843         (WebCore::RenderBlock::setHasMarkupTruncation):
 844         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
 845         (WebCore::RenderBlock::BlockSelectionInfo::block):
 846         (WebCore::RenderBlock::BlockSelectionInfo::state):
 847         (WebCore::RenderBlock::FloatingObject::FloatingObject):
 848         (WebCore::RenderBlock::CompactInfo::clear):
 849         * rendering/RenderButton.cpp:
 850         (WebCore::RenderButton::removeChild):
 851         (WebCore::RenderButton::paintObject):
 852         * rendering/RenderButton.h:
 853         (WebCore::RenderButton::renderName):
 854         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
 855         * rendering/RenderContainer.cpp:
 856         (WebCore::RenderContainer::RenderContainer):
 857         * rendering/RenderContainer.h:
 858         (WebCore::RenderContainer::firstChild):
 859         (WebCore::RenderContainer::lastChild):
 860         (WebCore::RenderContainer::calcMinMaxWidth):
 861         * rendering/RenderCounter.cpp:
 862         (WebCore::RenderCounter::RenderCounter):
 863         (WebCore::toRoman):
 864         (WebCore::toHebrew):
 865         (WebCore::RenderCounter::calcMinMaxWidth):
 866         * rendering/RenderCounter.h:
 867         * rendering/RenderFieldset.cpp:
 868         (WebCore::RenderFieldset::paintBoxDecorations):
 869         (WebCore::RenderFieldset::paintBorderMinusLegend):
 870         (WebCore::RenderFieldset::setStyle):
 871         * rendering/RenderFileUploadControl.cpp:
 872         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
 873         (WebCore::RenderFileUploadControl::setStyle):
 874         (WebCore::RenderFileUploadControl::paintObject):
 875         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
 876         * rendering/RenderFileUploadControl.h:
 877         (WebCore::RenderFileUploadControl::renderName):
 878         * rendering/RenderFlexibleBox.h:
 879         * rendering/RenderFlow.cpp:
 880         * rendering/RenderFlow.h:
 881         * rendering/RenderForeignObject.cpp:
 882         (WebCore::RenderForeignObject::RenderForeignObject):
 883         (WebCore::RenderForeignObject::paint):
 884         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
 885         (WebCore::RenderForeignObject::layout):
 886         (WebCore::RenderForeignObject::nodeAtPoint):
 887         * rendering/RenderForeignObject.h:
 888         (WebCore::RenderForeignObject::renderName):
 889         * rendering/RenderFormElement.cpp:
 890         (WebCore::RenderFormElement::setStyle):
 891         (WebCore::RenderFormElement::layout):
 892         (WebCore::RenderFormElement::textAlignment):
 893         * rendering/RenderFormElement.h:
 894         * rendering/RenderFrame.cpp:
 895         * rendering/RenderFrame.h:
 896         (WebCore::RenderFrame::element):
 897         * rendering/RenderFrameSet.cpp:
 898         * rendering/RenderFrameSet.h:
 899         (WebCore::RenderFrameSet::element):
 900         * rendering/RenderHTMLCanvas.cpp:
 901         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
 902         (WebCore::RenderHTMLCanvas::paint):
 903         * rendering/RenderHTMLCanvas.h:
 904         (WebCore::RenderHTMLCanvas::renderName):
 905         * rendering/RenderImage.cpp:
 906         (WebCore::RenderImage::RenderImage):
 907         (WebCore::RenderImage::setStyle):
 908         (WebCore::RenderImage::setContentObject):
 909         (WebCore::RenderImage::setCachedImage):
 910         (WebCore::RenderImage::imageChanged):
 911         (WebCore::RenderImage::paint):
 912         (WebCore::RenderImage::layout):
 913         (WebCore::RenderImage::updateAltText):
 914         * rendering/RenderImage.h:
 915         (WebCore::RenderImage::element):
 916         * rendering/RenderInline.cpp:
 917         (WebCore::RenderInline::RenderInline):
 918         (WebCore::RenderInline::~RenderInline):
 919         (WebCore::RenderInline::setStyle):
 920         (WebCore::RenderInline::addChildToFlow):
 921         (WebCore::RenderInline::cloneInline):
 922         (WebCore::RenderInline::splitInlines):
 923         (WebCore::RenderInline::splitFlow):
 924         (WebCore::RenderInline::paint):
 925         (WebCore::RenderInline::absoluteRects):
 926         (WebCore::RenderInline::calcMinMaxWidth):
 927         (WebCore::RenderInline::requiresLayer):
 928         (WebCore::RenderInline::width):
 929         (WebCore::RenderInline::height):
 930         (WebCore::RenderInline::renderName):
 931         (WebCore::RenderInline::nodeAtPoint):
 932         (WebCore::RenderInline::positionForCoordinates):
 933         * rendering/RenderInline.h:
 934         (WebCore::RenderInline::layout):
 935         * rendering/RenderLayer.cpp:
 936         * rendering/RenderLayer.h:
 937         (WebCore::ClipRects::ClipRects):
 938         (WebCore::RenderLayer::nextSibling):
 939         (WebCore::RenderLayer::root):
 940         (WebCore::RenderLayer::setPos):
 941         (WebCore::RenderLayer::height):
 942         (WebCore::RenderLayer::relativePositionOffset):
 943         * rendering/RenderLineEdit.cpp:
 944         (WebCore::RenderLineEdit::setStyle):
 945         (WebCore::RenderLineEdit::updateFromElement):
 946         (WebCore::RenderLineEdit::selectionStart):
 947         (WebCore::RenderLineEdit::selectionEnd):
 948         (WebCore::RenderLineEdit::setSelectionStart):
 949         (WebCore::RenderLineEdit::setSelectionEnd):
 950         (WebCore::RenderLineEdit::setSelectionRange):
 951         * rendering/RenderLineEdit.h:
 952         * rendering/RenderListBox.cpp:
 953         * rendering/RenderListBox.h:
 954         (WebCore::RenderListBox::renderName):
 955         * rendering/RenderListItem.cpp:
 956         (WebCore::RenderListItem::setStyle):
 957         (WebCore::getParentOfFirstLineBox):
 958         (WebCore::RenderListItem::updateMarkerLocation):
 959         (WebCore::RenderListItem::positionListMarker):
 960         (WebCore::RenderListItem::paint):
 961         * rendering/RenderListItem.h:
 962         * rendering/RenderListMarker.cpp:
 963         * rendering/RenderListMarker.h:
 964         (WebCore::RenderListMarker::renderName):
 965         (WebCore::RenderListMarker::isListMarker):
 966
 967 2006-10-30  Timothy Hatcher  <timothy@apple.com>
 968
 969         Reviewed by Hyatt.
 970
 971         <rdar://problem/4478625> Basic table editing and culling
 972
 973         Refined the criteria for deletable elements, rely on the renderer more.
 974         Corrected the interface positioning for elements that have borders.
 975
 976         * editing/DeleteButtonController.cpp:
 977         (WebCore::isDeletableElement):
 978         (WebCore::DeleteButtonController::show):
 979
 980 2006-10-30  Darin Adler  <darin@apple.com>
 981
 982         - fix build
 983
 984         * loader/ResourceLoader.h: Added header guard.
 985
 986 2006-10-31  Darin Adler  <darin@apple.com>
 987
 988         Reviewed by Adam.
 989
 990         - fix FrameLoader files so they can be built on non-Mac platforms
 991
 992         * page/FramePrivate.h:
 993         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
 994         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
 995
 996         * page/Page.h:
 997         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
 998         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
 999         the other day.
1000
1001         * bridge/mac/FrameMac.mm:
1002         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1003         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1004
1005         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1006         around the PolicyCheck definition.
1007
1008         * loader/FormState.cpp: Changed import to include.
1009         * loader/FrameLoader.cpp: Ditto.
1010         * loader/MainResourceLoader.h: Ditto.
1011
1012         * loader/FrameLoaderTypes.h: Added a header guard.
1013
1014         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1015         Added #if PLATFORM(MAC) around Mac-specific details.
1016         * loader/SubresourceLoader.h: Ditto.
1017
1018         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1019         m_loader from m_frameLoader.
1020
1021         * CMakeLists.txt: Updated.
1022         * WebCoreSources.bkl: Updated.
1023
1024 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1025
1026         Reviewed and landed by Anders.
1027
1028         Patch by Zack rusin to fix:
1029         http://bugs.webkit.org/show_bug.cgi?id=11429
1030
1031         Fix startup crash.
1032
1033         * platform/qt/FrameQtClient.cpp:
1034         (WebCore::FrameQtClientDefault::openURL):
1035
1036 2006-10-30  Zach Rusin  <zack@kde.org>
1037
1038         Reviewed and landed by Anders.
1039
1040         * platform/network/qt/ResourceHandleQt.cpp:
1041         (WebCore::ResourceHandle::receivedResponse):
1042         * platform/qt/FrameQtClient.cpp:
1043         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1044         * platform/qt/LoaderFunctionsQt.cpp:
1045         (WebCore::ServeSynchronousRequest):
1046         More build fixes.
1047
1048 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1049
1050         Reviewed and landed by Anders.
1051
1052         - fix Qt build
1053         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1054         ResourceHandleClient
1055
1056 2006-10-30  Darin Adler  <darin@apple.com>
1057
1058         Reviewed by John Sullivan.
1059
1060         - work toward removing Objective-C data types from FrameLoader.h:
1061           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1062           and WebCoreResourceHandle
1063         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
1064
1065         * page/PageState.h:
1066         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
1067
1068         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
1069         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
1070         double for the date instead of an NSDate.
1071
1072         * bridge/mac/WebCoreFrameBridge.h:
1073         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
1074         saveDocumentToPageCache methods.
1075
1076         * bridge/mac/WebCorePageState.h:
1077         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
1078         an Objective-C wrapper for PageState.
1079
1080         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
1081         NSDate and WebCorePageState.
1082         * loader/FrameLoaderClient.h: Changed NSDate to double.
1083         * loader/mac/FrameLoaderMac.mm:
1084         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
1085         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
1086         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
1087         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
1088         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
1089         extract the parameters from the response. Changed the open function that takes
1090         a PageState to use the new C++ PageState.
1091         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
1092         function; tightened up logic, removing a few cases that could never happen, as
1093         well as the unused reload boolean.
1094
1095         * ForwardingHeaders/kjs/property_map.h: Added.
1096
1097         * WebCore.exp: Updated.
1098         * WebCore.xcodeproj/project.pbxproj: Updated.
1099
1100 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1101
1102         Reviewed by Anders.
1103
1104         - added ResourceResponse class and didReceiveResponse delegate call
1105
1106         * WebCore.xcodeproj/project.pbxproj: Added new files.
1107         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1108         expiresTimeForResponse: method.
1109         * dom/XMLTokenizer.cpp:
1110         (WebCore::openFunc): Updated to use ResourceResponse.
1111         * loader/FrameLoader.h: Update loadResourceSynchronously to
1112         use ResourceResponse.
1113         * loader/LoaderFunctions.h:
1114         * loader/icon/IconLoader.cpp:
1115         (IconLoader::didReceiveResponse): Updated from receivedResponse
1116         and made cross-platform.
1117         * loader/icon/IconLoader.h: updated for above change
1118         * loader/loader.cpp:
1119         (WebCore::Loader::receivedResponse): reduced to just saving
1120         the PlatformResponse (ideally we'd phase out use of this).
1121         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse
1122         logic.
1123         * loader/loader.h:
1124         * loader/mac/FrameLoaderMac.mm:
1125         (WebCore::FrameLoader::loadResourceSynchronously): Return results
1126         as ResourceResponse.
1127         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
1128         * loader/mac/LoaderFunctionsMac.mm:
1129         (WebCore::ServeSynchronousRequest): take ResourceResponse as
1130         argument.
1131         * platform/network/ResourceHandle.cpp:
1132         * platform/network/ResourceHandle.h: Remove calls for
1133         broken out response pieces.
1134         * platform/network/ResourceHandleClient.h:
1135         (WebCore::ResourceHandleClient::didReceiveResponse): New
1136         delegate method.
1137         * platform/network/ResourceHandleInternal.h:
1138         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
1139         storage of response bits, we're not gonna return them
1140         seprately any more.
1141         * platform/network/ResourceResponse.h: Added.
1142         (WebCore::ResourceResponse::ResourceResponse): Freshly
1143         implemented. Same for below.
1144         (WebCore::ResourceResponse::url):
1145         (WebCore::ResourceResponse::mimeType):
1146         (WebCore::ResourceResponse::expectedContentLength):
1147         (WebCore::ResourceResponse::textEncodingName):
1148         (WebCore::ResourceResponse::suggestedFilename):
1149         (WebCore::ResourceResponse::httpStatusCode):
1150         (WebCore::ResourceResponse::setHTTPStatusCode):
1151         (WebCore::ResourceResponse::httpHeaderField):
1152         (WebCore::ResourceResponse::httpHeaderFields):
1153         (WebCore::ResourceResponse::isMultipart):
1154         (WebCore::ResourceResponse::setExpirationDate):
1155         (WebCore::ResourceResponse::expirationDate):
1156         * platform/network/cf/ResourceHandleCFNet.cpp:
1157         (WebCore::didReceiveResponse): Send didReceiveResponse
1158         client method.
1159         * platform/network/cf/ResourceResponseCFNet.h: Added.
1160         * platform/network/cf/ResourceResponseCFNet.mm: Added.
1161         (getResourceResponse): Helper function to get a ResourceResponse
1162         from CFURLResponseRef.
1163         * platform/network/mac/ResourceHandleMac.mm:
1164         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1165         Don't bother cleaning up fields we no longer have.
1166         (WebCore::ResourceHandle::receivedResponse): Send
1167         didReceiveResponse client method.
1168         * platform/network/mac/ResourceResponseMac.h: Added.
1169         * platform/network/mac/ResourceResponseMac.mm: Added.
1170         (getResourceResponse): Helper function to get a ResourceResponse
1171         from an NSURLResponse*.
1172         * rendering/HitTestResult.cpp:
1173         * xml/XSLTProcessor.cpp:
1174         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
1175         * xml/xmlhttprequest.cpp:
1176         (WebCore::XMLHttpRequest::getResponseText): Store http response
1177         info in the form of a ResourceResponse, change all methods to
1178         account for this.
1179         (WebCore::XMLHttpRequest::getResponseXML):
1180         (WebCore::XMLHttpRequest::XMLHttpRequest):
1181         (WebCore::XMLHttpRequest::open):
1182         (WebCore::XMLHttpRequest::send):
1183         (WebCore::XMLHttpRequest::getAllResponseHeaders):
1184         (WebCore::XMLHttpRequest::getResponseHeader):
1185         (WebCore::XMLHttpRequest::getStatus):
1186         (WebCore::XMLHttpRequest::getStatusText):
1187         (WebCore::XMLHttpRequest::processSyncLoadResults):
1188         (WebCore::XMLHttpRequest::didFinishLoading):
1189         (WebCore::XMLHttpRequest::didReceiveResponse):
1190         (WebCore::XMLHttpRequest::didReceiveData):
1191         * xml/xmlhttprequest.h:
1192
1193 2006-10-29  Darin Adler  <darin@apple.com>
1194
1195         - fix build
1196
1197         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
1198         * loader/NetscapePlugInStreamLoader.h: Ditto.
1199         * loader/ResourceLoader.h: Ditto.
1200
1201 2006-10-29  Darin Adler  <darin@apple.com>
1202
1203         - one last name change -- WebFormState.h to FormState.h
1204         - added more empty placeholder platform-independent files
1205           for currently-Mac-specific loader classes
1206
1207         * loader/FormState.cpp: Updated include.
1208         * loader/FrameLoader.cpp: Updated include.
1209         * loader/mac/FrameLoaderMac.mm: Updated include.
1210
1211         * loader/WebFormState.h: Removed.
1212         * loader/FormState.h: Added.
1213
1214         * loader/DocumentLoader.cpp: Added.
1215         * loader/MainResourceLoader.cpp: Added.
1216         * loader/NetscapePlugInStreamLoader.cpp: Added.
1217         * loader/ResourceLoader.cpp: Added.
1218         * loader/SubresourceLoader.cpp: Added.
1219
1220         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
1221
1222 2006-10-29  Darin Adler  <darin@apple.com>
1223
1224         - did the do-webcore-rename renames, including a number of changes
1225           to the names of loader files (and WebResourceLoader -> ResourceLoader),
1226           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
1227           and improvements to the names of decoder classes and their source
1228           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
1229
1230         * CMakeLists.txt:
1231         * WebCore.exp:
1232         * WebCore.vcproj/WebCore/WebCore.vcproj:
1233         * WebCore.xcodeproj/project.pbxproj:
1234         * WebCoreSources.bkl:
1235         * bindings/js/kjs_binding.cpp:
1236         (KJS::ScriptInterpreter::updateDOMNodeDocument):
1237         * bindings/js/kjs_events.cpp:
1238         (KJS::JSAbstractEventListener::handleEvent):
1239         (KJS::JSLazyEventListener::parseCode):
1240         * bindings/js/kjs_html.cpp:
1241         (KJS::JSHTMLElement::implementsCall):
1242         * bindings/js/kjs_traversal.cpp:
1243         (KJS::JSNodeFilterCondition::acceptNode):
1244         * bindings/js/kjs_window.cpp:
1245         (KJS::Window::interpreter):
1246         (KJS::Window::retrieveWindow):
1247         (KJS::Window::retrieve):
1248         (KJS::ScheduledAction::execute):
1249         * bindings/objc/DOMInternal.mm:
1250         (-[WebScriptObject _initializeScriptDOMNodeImp]):
1251         * bridge/mac/FrameMac.mm:
1252         (WebCore::FrameMac::executionContextForDOM):
1253         (WebCore::FrameMac::bindingRootObject):
1254         (WebCore::FrameMac::windowScriptObject):
1255         (WebCore::FrameMac::windowScriptNPObject):
1256         (WebCore::FrameMac::partClearedInBegin):
1257         * bridge/mac/WebCoreEncodings.mm:
1258         * bridge/mac/WebCoreFrameBridge.mm:
1259         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1260         (-[WebCoreFrameBridge stringWithData:]):
1261         (-[WebCoreFrameBridge executionContextForView:]):
1262         * bridge/win/FrameWin.cpp:
1263         * dom/Document.cpp:
1264         (WebCore::Document::inputEncoding):
1265         (WebCore::Document::setCharset):
1266         (WebCore::Document::createHTMLEventListener):
1267         (WebCore::Document::setDecoder):
1268         * dom/Document.h:
1269         (WebCore::Document::decoder):
1270         * dom/EventTargetNode.cpp:
1271         (WebCore::EventTargetNode::dispatchGenericEvent):
1272         * html/HTMLParser.cpp:
1273         (WebCore::HTMLParser::noscriptCreateErrorCheck):
1274         (WebCore::HTMLParser::canvasCreateErrorCheck):
1275         (WebCore::HTMLParser::isInline):
1276         * html/HTMLPlugInElement.cpp:
1277         (WebCore::HTMLPlugInElement::createNPObject):
1278         * html/HTMLScriptElement.cpp:
1279         (WebCore::HTMLScriptElement::evaluateScript):
1280         * html/HTMLTokenizer.cpp:
1281         (WebCore::HTMLTokenizer::parseTag):
1282         (WebCore::HTMLTokenizer::processToken):
1283         * ksvg2/misc/SVGDocumentExtensions.cpp:
1284         (WebCore::SVGDocumentExtensions::createSVGEventListener):
1285         * loader/CachedCSSStyleSheet.cpp:
1286         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1287         (WebCore::CachedCSSStyleSheet::setEncoding):
1288         * loader/CachedCSSStyleSheet.h:
1289         * loader/CachedXBLDocument.cpp:
1290         (WebCore::CachedXBLDocument::CachedXBLDocument):
1291         (WebCore::CachedXBLDocument::setEncoding):
1292         * loader/CachedXBLDocument.h:
1293         * loader/CachedXSLStyleSheet.cpp:
1294         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
1295         (WebCore::CachedXSLStyleSheet::setEncoding):
1296         * loader/CachedXSLStyleSheet.h:
1297         * loader/Decoder.cpp: Removed.
1298         * loader/Decoder.h: Removed.
1299         * loader/FrameLoader.cpp:
1300         * loader/FrameLoader.h:
1301         * loader/FrameLoaderClient.h:
1302         * loader/MainResourceLoader.h: Added.
1303         * loader/NetscapePlugInStreamLoader.h: Added.
1304         * loader/Request.h:
1305         (WebCore::Request::cachedResource):
1306         * loader/ResourceLoader.h: Added.
1307         * loader/SubresourceLoader.h: Added.
1308         * loader/TextResourceDecoder.cpp: Added.
1309         (WebCore::TextResourceDecoder::determineContentType):
1310         (WebCore::TextResourceDecoder::defaultEncoding):
1311         (WebCore::TextResourceDecoder::TextResourceDecoder):
1312         (WebCore::TextResourceDecoder::~TextResourceDecoder):
1313         (WebCore::TextResourceDecoder::setEncoding):
1314         (WebCore::TextResourceDecoder::checkForBOM):
1315         (WebCore::TextResourceDecoder::checkForCSSCharset):
1316         (WebCore::TextResourceDecoder::checkForHeadCharset):
1317         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
1318         (WebCore::TextResourceDecoder::decode):
1319         (WebCore::TextResourceDecoder::flush):
1320         * loader/TextResourceDecoder.h: Added.
1321         * loader/WebDocumentLoader.h: Removed.
1322         * loader/WebLoader.h: Removed.
1323         * loader/WebMainResourceLoader.h: Removed.
1324         * loader/WebNetscapePlugInStreamLoader.h: Removed.
1325         * loader/WebSubresourceLoader.h: Removed.
1326         * loader/loader.cpp:
1327         (WebCore::Loader::servePendingRequests):
1328         (WebCore::Loader::receivedAllData):
1329         (WebCore::Loader::receivedResponse):
1330         (WebCore::Loader::didReceiveData):
1331         (WebCore::Loader::cancelRequests):
1332         (WebCore::Loader::jobForRequest):
1333         * loader/mac/DocumentLoaderMac.mm:
1334         * loader/mac/FormDataStream.m: Added.
1335         * loader/mac/FrameLoaderMac.mm:
1336         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1337         (WebCore::FrameLoader::addPlugInStreamLoader):
1338         (WebCore::FrameLoader::removePlugInStreamLoader):
1339         (WebCore::FrameLoader::addSubresourceLoader):
1340         (WebCore::FrameLoader::removeSubresourceLoader):
1341         (WebCore::FrameLoader::willSendRequest):
1342         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
1343         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
1344         (WebCore::FrameLoader::didReceiveResponse):
1345         (WebCore::FrameLoader::didReceiveData):
1346         (WebCore::FrameLoader::didFinishLoad):
1347         (WebCore::FrameLoader::didFailToLoad):
1348         (WebCore::FrameLoader::open):
1349         (WebCore::FrameLoader::willUseArchive):
1350         (WebCore::FrameLoader::isArchiveLoadPending):
1351         * loader/mac/ImageDocumentMac.mm:
1352         * loader/mac/LoaderFunctionsMac.mm:
1353         (WebCore::CheckCacheObjectStatus):
1354         * loader/mac/MainResourceLoaderMac.mm:
1355         (WebCore::MainResourceLoader::MainResourceLoader):
1356         (WebCore::MainResourceLoader::releaseDelegate):
1357         (WebCore::MainResourceLoader::didCancel):
1358         (WebCore::MainResourceLoader::addData):
1359         (WebCore::MainResourceLoader::willSendRequest):
1360         (WebCore::MainResourceLoader::continueAfterContentPolicy):
1361         (WebCore::MainResourceLoader::didReceiveData):
1362         (WebCore::MainResourceLoader::didFinishLoading):
1363         (WebCore::MainResourceLoader::setDefersLoading):
1364         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1365         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1366         (WebCore::NetscapePlugInStreamLoader::releaseResources):
1367         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
1368         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
1369         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
1370         (WebCore::NetscapePlugInStreamLoader::didFail):
1371         (WebCore::NetscapePlugInStreamLoader::didCancel):
1372         * loader/mac/ResourceLoaderMac.mm:
1373         (WebCore::ResourceLoader::ResourceLoader):
1374         (WebCore::ResourceLoader::~ResourceLoader):
1375         (WebCore::ResourceLoader::releaseResources):
1376         (WebCore::ResourceLoader::load):
1377         (WebCore::ResourceLoader::setDefersLoading):
1378         (WebCore::ResourceLoader::frameLoader):
1379         (WebCore::ResourceLoader::addData):
1380         (WebCore::ResourceLoader::resourceData):
1381         (WebCore::ResourceLoader::clearResourceData):
1382         (WebCore::ResourceLoader::willSendRequest):
1383         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1384         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1385         (WebCore::ResourceLoader::didReceiveResponse):
1386         (WebCore::ResourceLoader::didReceiveData):
1387         (WebCore::ResourceLoader::willStopBufferingData):
1388         (WebCore::ResourceLoader::didFinishLoading):
1389         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1390         (WebCore::ResourceLoader::didFail):
1391         (WebCore::ResourceLoader::willCacheResponse):
1392         (WebCore::ResourceLoader::didCancel):
1393         (WebCore::ResourceLoader::cancel):
1394         (WebCore::ResourceLoader::setIdentifier):
1395         (WebCore::ResourceLoader::response):
1396         (WebCore::ResourceLoader::inConnectionCallback):
1397         (WebCore::ResourceLoader::cancelledError):
1398         (WebCore::ResourceLoader::receivedCredential):
1399         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
1400         (WebCore::ResourceLoader::receivedCancellation):
1401         (WebCore::ResourceLoader::delegate):
1402         (WebCore::ResourceLoader::releaseDelegate):
1403         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
1404         * loader/mac/SubresourceLoaderMac.mm:
1405         (WebCore::SubresourceLoader::SubresourceLoader):
1406         (WebCore::SubresourceLoader::willSendRequest):
1407         (WebCore::SubresourceLoader::didReceiveResponse):
1408         (WebCore::SubresourceLoader::didReceiveData):
1409         (WebCore::SubresourceLoader::didFinishLoading):
1410         (WebCore::SubresourceLoader::didFail):
1411         (WebCore::SubresourceLoader::didCancel):
1412         * loader/mac/WebFormDataStream.h: Removed.
1413         * loader/mac/WebFormDataStream.m: Removed.
1414         * page/Frame.cpp:
1415         (WebCore::Frame::javaScriptEnabled):
1416         (WebCore::Frame::scriptProxy):
1417         (WebCore::Frame::executeScript):
1418         (WebCore::Frame::write):
1419         (WebCore::Frame::userGestureHint):
1420         (WebCore::Frame::saveInterpreterBuiltins):
1421         (WebCore::Frame::restoreInterpreterBuiltins):
1422         (WebCore::Frame::backslashAsCurrencySymbol):
1423         * page/Frame.h:
1424         * page/FramePrivate.h:
1425         * platform/StreamingTextDecoder.cpp: Removed.
1426         * platform/StreamingTextDecoder.h: Removed.
1427         * platform/StreamingTextDecoderICU.cpp: Removed.
1428         * platform/StreamingTextDecoderICU.h: Removed.
1429         * platform/TextCodec.cpp: Added.
1430         * platform/TextCodec.h: Added.
1431         * platform/TextCodecICU.cpp: Added.
1432         * platform/TextCodecICU.h: Added.
1433         * platform/TextCodecLatin1.h:
1434         * platform/TextCodecUTF16.h:
1435         * platform/TextDecoder.h:
1436         * platform/TextEncoding.cpp:
1437         * platform/TextEncodingRegistry.cpp:
1438         * platform/image-decoders/jpeg/jmorecfg.h:
1439         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
1440         * platform/mac/StreamingTextDecoderMac.h: Removed.
1441         * platform/mac/TextCodecMac.cpp: Added.
1442         * platform/mac/TextCodecMac.h: Added.
1443         * platform/network/ResourceHandleInternal.h:
1444         * platform/network/mac/ResourceHandleMac.mm:
1445         * platform/qt/FrameQt.cpp:
1446         (WebCore::FrameQt::bindingRootObject):
1447         * platform/qt/LoaderFunctionsQt.cpp:
1448         (WebCore::CheckCacheObjectStatus):
1449         * rendering/RenderObject.cpp:
1450         (WebCore::RenderObject::backslashAsCurrencySymbol):
1451         * xml/XSLTProcessor.cpp:
1452         (WebCore::XSLTProcessor::createDocumentFromSource):
1453         * xml/xmlhttprequest.cpp:
1454         (WebCore::XMLHttpRequest::didReceiveData):
1455         * xml/xmlhttprequest.h:
1456
1457 2006-10-29  Darin Adler  <darin@apple.com>
1458
1459         Rubber stamped by Adam (kinda).
1460
1461         - add Mac suffixes and correct filenames inside loader/mac
1462
1463         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
1464
1465         * loader/mac/FrameLoader.mm: Removed.
1466         * loader/mac/WebDocumentLoader.mm: Removed.
1467         * loader/mac/WebLoader.mm: Removed.
1468         * loader/mac/WebMainResourceLoader.mm: Removed.
1469         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
1470         * loader/mac/WebSubresourceLoader.mm: Removed.
1471
1472         * loader/mac/FrameLoaderMac.mm: Added.
1473         * loader/mac/DocumentLoaderMac.mm: Added.
1474         * loader/mac/ResourceLoaderMac.mm: Added.
1475         * loader/mac/MainResourceLoaderMac.mm: Added.
1476         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
1477         * loader/mac/SubresourceLoaderMac.mm: Removed.
1478
1479 2006-10-29  Darin Adler  <darin@apple.com>
1480
1481         Reviewed by Adam.
1482
1483         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
1484           and FrameLoader.cpp mostly ready
1485
1486         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
1487         FormState.cpp. Removed WebFormState.mm.
1488
1489         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
1490         get this header compiling on non-Mac.
1491         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
1492         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
1493
1494         * loader/FrameLoaderClient.h: Added some ifdefs.
1495         * loader/WebDocumentLoader.h: Ditto.
1496         * loader/WebLoader.h: Ditto.
1497         * loader/WebMainResourceLoader.h: Ditto.
1498
1499         * loader/mac/WebDocumentLoader.mm:
1500         (WebCore::DocumentLoader::isLoadingInAPISense):
1501         Rewrote to work without bridge, partly to remove the need for ObjC
1502         bridge type in the header, and also because we're tearing down the bridge.
1503
1504         * loader/mac/WebMainResourceLoader.mm:
1505         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
1506         m_contentLength and m_bytesReceived.
1507         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
1508         (WebCore::MainResourceLoader::didReceiveData): Ditto.
1509
1510         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
1511         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
1512
1513         * loader/mac/FormState.mm: Removed.
1514         * loader/FormState.cpp: Added.
1515
1516 2006-10-29  Darin Adler  <darin@apple.com>
1517
1518         Rubber stamped by Adam.
1519
1520         - moving towards use of FrameLoader cross-platform; move the headers
1521           for the Mac loader from loader/mac into loader, in preparation for
1522           making them useful on non-Mac
1523
1524         * WebCore.xcodeproj/project.pbxproj:
1525
1526         * loader/mac/FrameLoader.h: Removed.
1527         * loader/mac/WebDocumentLoader.h: Removed.
1528         * loader/mac/WebFormState.h: Removed.
1529         * loader/mac/WebLoader.h: Removed.
1530         * loader/mac/WebMainResourceLoader.h: Removed.
1531         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
1532         * loader/mac/WebSubresourceLoader.h: Removed.
1533
1534         * loader/FrameLoader.h: Added.
1535         * loader/WebDocumentLoader.h: Added.
1536         * loader/WebFormState.h: Added.
1537         * loader/WebLoader.h: Added.
1538         * loader/WebMainResourceLoader.h: Added.
1539         * loader/WebNetscapePlugInStreamLoader.h: Added.
1540         * loader/WebSubresourceLoader.h: Added.
1541
1542 2006-10-29  Adam Roben  <aroben@apple.com>
1543
1544         Reviewed by Geoff.
1545
1546         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
1547         r17405.
1548
1549         * platform/DeprecatedString.h:
1550
1551 2006-10-29  Beth Dakin  <bdakin@apple.com>
1552
1553         Rubber stamped by Geoff.
1554
1555         This is a followup to my HitTestResult checkin. Most of the
1556         HitTestResult local variables in the code were named i or info for
1557         when the class was named NodeInfo. This patch renames all of these
1558         local variables to result.
1559
1560         * dom/Document.cpp:
1561         (WebCore::Document::prepareMouseEvent):
1562         * html/HTMLAreaElement.cpp:
1563         (WebCore::HTMLAreaElement::mapMouseEvent):
1564         * html/HTMLMapElement.cpp:
1565         (WebCore::HTMLMapElement::mapMouseEvent):
1566         * rendering/EllipsisBox.cpp:
1567         (WebCore::EllipsisBox::nodeAtPoint):
1568         * rendering/EllipsisBox.h:
1569         * rendering/InlineBox.cpp:
1570         (WebCore::InlineBox::nodeAtPoint):
1571         * rendering/InlineFlowBox.cpp:
1572         (WebCore::InlineFlowBox::nodeAtPoint):
1573         * rendering/InlineTextBox.cpp:
1574         (WebCore::InlineTextBox::nodeAtPoint):
1575         * rendering/RenderBlock.cpp:
1576         (WebCore::RenderBlock::isPointInScrollbar):
1577         (WebCore::RenderBlock::nodeAtPoint):
1578         * rendering/RenderBlock.h:
1579         * rendering/RenderBox.cpp:
1580         (WebCore::RenderBox::nodeAtPoint):
1581         * rendering/RenderBox.h:
1582         * rendering/RenderFlow.cpp:
1583         (WebCore::RenderFlow::hitTestLines):
1584         * rendering/RenderFlow.h:
1585         * rendering/RenderForeignObject.cpp:
1586         (WebCore::RenderForeignObject::nodeAtPoint):
1587         * rendering/RenderFrameSet.cpp:
1588         (WebCore::RenderFrameSet::nodeAtPoint):
1589         * rendering/RenderImage.cpp:
1590         (WebCore::RenderImage::nodeAtPoint):
1591         * rendering/RenderInline.cpp:
1592         (WebCore::RenderInline::nodeAtPoint):
1593         * rendering/RenderInline.h:
1594         * rendering/RenderLayer.cpp:
1595         (WebCore::RenderLayer::autoscroll):
1596         (WebCore::RenderLayer::hitTest):
1597         (WebCore::RenderLayer::hitTestLayer):
1598         (WebCore::RenderLayer::updateHoverActiveState):
1599         * rendering/RenderListBox.cpp:
1600         (WebCore::RenderListBox::isPointInScrollbar):
1601         * rendering/RenderObject.cpp:
1602         (WebCore::RenderObject::hitTest):
1603         (WebCore::RenderObject::setInnerNode):
1604         (WebCore::RenderObject::nodeAtPoint):
1605         * rendering/RenderObject.h:
1606         * rendering/RenderPath.cpp:
1607         (WebCore::RenderPath::nodeAtPoint):
1608         * rendering/RenderSVGImage.cpp:
1609         (WebCore::RenderSVGImage::nodeAtPoint):
1610         * rendering/RenderSVGText.cpp:
1611         (WebCore::RenderSVGText::nodeAtPoint):
1612         * rendering/RenderTableRow.cpp:
1613         (WebCore::RenderTableRow::nodeAtPoint):
1614         * rendering/RenderTableRow.h:
1615         * rendering/RenderTableSection.cpp:
1616         (WebCore::RenderTableSection::nodeAtPoint):
1617         * rendering/RenderTableSection.h:
1618         * rendering/RenderTextControl.cpp:
1619         (WebCore::RenderTextControl::nodeAtPoint):
1620         * rendering/RootInlineBox.cpp:
1621         (WebCore::RootInlineBox::nodeAtPoint):
1622         * rendering/RootInlineBox.h:
1623
1624 2006-10-29  Adam Roben  <aroben@apple.com>
1625
1626         More semi-fixes.
1627
1628         * page/Page.cpp: Forgot to wrap the actual definition of
1629         setDefersLoading() in PLATFORM(MAC).
1630         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
1631
1632 2006-10-29  Adam Roben  <aroben@apple.com>
1633
1634         Build semi-fix.
1635
1636         Move all FrameLoader-related code in Page.{cpp,h} within #if
1637         PLATFORM(MAC), since this class currently only exists on Mac.
1638
1639         * page/Page.cpp:
1640         * page/Page.h:
1641
1642 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
1643
1644         build fix.
1645
1646         * platform/PlatformString.h:
1647         (WebCore::String::operator NSString*):
1648
1649 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
1650
1651         Rolled out accidental commit.
1652
1653         * platform/AtomicString.h:
1654         (WebCore::AtomicString::AtomicString):
1655         (WebCore::AtomicString::operator NSString*):
1656
1657 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
1658
1659         RS by Darin.
1660
1661         Rolled out change to map NULL Strings to nil NSStrings because it caused
1662         even more AppKit crashes. Maybe we should remove the NSString * operator
1663         entirely, since its use is not straight-forward, and require callers to
1664         specify explicitly whether they tolerate NULL.
1665
1666         * platform/AtomicString.h:
1667         * platform/PlatformString.h:
1668         (WebCore::String::operator NSString*):
1669         * platform/mac/TextFieldMac.mm:
1670         (-[NSSearchFieldCell _addStringToRecentSearches:]):
1671
1672 2006-10-29  Darin Adler  <darin@apple.com>
1673
1674         Reviewed by Geoff.
1675
1676         - fixed storage leak showing up on the buildbot
1677
1678         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
1679         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
1680
1681 2006-10-29  Darin Adler  <darin@apple.com>
1682
1683         Rubber stamped by Adam.
1684
1685         - renamed WebFrameLoaderClient to match the class name inside it
1686
1687         * loader/mac/WebFrameLoaderClient.h: Removed.
1688         * loader/FrameLoaderClient.h: Moved it here.
1689
1690         * WebCore.xcodeproj/project.pbxproj: Updated project.
1691
1692         * bridge/mac/FrameMac.mm: Updated includes.
1693         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
1694         * loader/mac/FrameLoader.mm: Ditto.
1695         * loader/mac/WebLoader.h: Ditto.
1696
1697 2006-10-29  Darin Adler  <darin@apple.com>
1698
1699         Reviewed by Mitz.
1700
1701         - fix crash visible on buildbot and also when running the test
1702           anchor-image-scrolled-x-y.html under libgmalloc
1703
1704         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
1705         now that the class is named ResourceHandle.
1706         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
1707         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
1708         a local RefPtr before calling finishJobAndHandle, since we might get
1709         cancelled inside that function, so we should not rely on m_handle to
1710         keep the ResourceHandle alive.
1711         (WebCore::SubresourceLoader::didFail): Ditto.
1712         (WebCore::SubresourceLoader::didCancel): Ditto.
1713
1714 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1715
1716         - build fix
1717
1718         * platform/network/mac/ResourceHandleMac.mm:
1719
1720 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1721
1722         Rubber stamped by Darin.
1723
1724         - renamed ResourceLoader to ResourceHandle (and same for related classes)
1725
1726         * CMakeLists.txt:
1727         * Projects/gdk/webcore-gdk.bkl:
1728         * WebCore.vcproj/WebCore/WebCore.vcproj:
1729         * WebCore.xcodeproj/project.pbxproj:
1730         * WebCoreSources.bkl:
1731         * bridge/mac/FrameMac.mm:
1732         * bridge/win/FrameWin.cpp:
1733         * dom/XMLTokenizer.cpp:
1734         * loader/Cache.cpp:
1735         * loader/CachedResource.h:
1736         * loader/LoaderFunctions.h:
1737         * loader/icon/IconLoader.cpp:
1738         (IconLoader::startLoading):
1739         (IconLoader::didReceiveData):
1740         (IconLoader::didFinishLoading):
1741         * loader/icon/IconLoader.h:
1742         * loader/loader.cpp:
1743         (WebCore::Loader::servePendingRequests):
1744         (WebCore::Loader::receivedAllData):
1745         (WebCore::Loader::receivedResponse):
1746         (WebCore::Loader::didReceiveData):
1747         (WebCore::Loader::cancelRequests):
1748         (WebCore::Loader::jobForRequest):
1749         * loader/loader.h:
1750         * loader/mac/IconLoaderMac.mm:
1751         (IconLoader::receivedResponse):
1752         * loader/mac/LoaderFunctionsMac.mm:
1753         * loader/mac/WebLoader.h:
1754         * loader/mac/WebSubresourceLoader.h:
1755         * loader/mac/WebSubresourceLoader.mm:
1756         (WebCore::SubresourceLoader::SubresourceLoader):
1757         (WebCore::SubresourceLoader::create):
1758         * platform/gdk/FrameGdk.cpp:
1759         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
1760         (WebCore::FrameGdkClientDefault::openURL):
1761         (WebCore::FrameGdkClientDefault::submitForm):
1762         (WebCore::FrameGdkClientDefault::receivedResponse):
1763         (WebCore::FrameGdkClientDefault::didReceiveData):
1764         (WebCore::FrameGdkClientDefault::receivedAllData):
1765         * platform/gdk/FrameGdk.h:
1766         * platform/gdk/TemporaryLinkStubs.cpp:
1767         (WebCore::ServeSynchronousRequest):
1768         (WebCore::ResourceHandle::assembleResponseHeaders):
1769         (WebCore::ResourceHandle::retrieveCharset):
1770         * platform/network/ResourceHandle.cpp: Added.
1771         (WebCore::ResourceHandle::ResourceHandle):
1772         (WebCore::ResourceHandle::create):
1773         (WebCore::ResourceHandle::isErrorPage):
1774         (WebCore::ResourceHandle::error):
1775         (WebCore::ResourceHandle::setError):
1776         (WebCore::ResourceHandle::responseEncoding):
1777         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
1778         (WebCore::ResourceHandle::kill):
1779         (WebCore::ResourceHandle::requestHeaders):
1780         (WebCore::ResourceHandle::url):
1781         (WebCore::ResourceHandle::postData):
1782         (WebCore::ResourceHandle::method):
1783         (WebCore::ResourceHandle::client):
1784         * platform/network/ResourceHandle.h: Added.
1785         (WebCore::ResourceHandle::getInternal):
1786         * platform/network/ResourceHandleClient.h: Added.
1787         (WebCore::ResourceHandleClient::~ResourceHandleClient):
1788         (WebCore::ResourceHandleClient::didReceiveData):
1789         (WebCore::ResourceHandleClient::didFinishLoading):
1790         (WebCore::ResourceHandleClient::receivedRedirect):
1791         (WebCore::ResourceHandleClient::receivedResponse):
1792         (WebCore::ResourceHandleClient::receivedAllData):
1793         * platform/network/ResourceHandleInternal.h: Added.
1794         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1795         * platform/network/ResourceLoader.cpp: Removed.
1796         * platform/network/ResourceLoader.h: Removed.
1797         * platform/network/ResourceLoaderClient.h: Removed.
1798         * platform/network/ResourceLoaderInternal.h: Removed.
1799         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
1800         (WebCore::willSendRequest):
1801         (WebCore::didReceiveResponse):
1802         (WebCore::didReceiveData):
1803         (WebCore::didFinishLoading):
1804         (WebCore::didFail):
1805         (WebCore::willCacheResponse):
1806         (WebCore::didReceiveChallenge):
1807         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1808         (WebCore::ResourceHandle::~ResourceHandle):
1809         (WebCore::ResourceHandle::start):
1810         (WebCore::ResourceHandle::cancel):
1811         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
1812         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
1813         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1814         (WebCore::ResourceHandle::~ResourceHandle):
1815         (WebCore::ResourceHandle::start):
1816         (WebCore::ResourceHandle::cancel):
1817         * platform/network/gdk/ResourceHandleManager.cpp: Added.
1818         (WebCore::ResourceHandleManager::ResourceHandleManager):
1819         (WebCore::ResourceHandleManager::get):
1820         (WebCore::ResourceHandleManager::useSimpleTransfer):
1821         (WebCore::writeCallback):
1822         (WebCore::ResourceHandleManager::downloadTimerCallback):
1823         (WebCore::ResourceHandleManager::remove):
1824         (WebCore::ResourceHandleManager::add):
1825         (WebCore::ResourceHandleManager::cancel):
1826         * platform/network/gdk/ResourceHandleManager.h: Added.
1827         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
1828         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
1829         * platform/network/gdk/ResourceLoaderManager.h: Removed.
1830         * platform/network/mac/ResourceHandleMac.mm: Added.
1831         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1832         (WebCore::ResourceHandle::~ResourceHandle):
1833         (WebCore::ResourceHandle::start):
1834         (WebCore::ResourceHandle::assembleResponseHeaders):
1835         (WebCore::ResourceHandle::retrieveResponseEncoding):
1836         (WebCore::ResourceHandle::receivedResponse):
1837         (WebCore::ResourceHandle::cancel):
1838         (WebCore::ResourceHandle::redirectedToURL):
1839         (WebCore::ResourceHandle::addData):
1840         (WebCore::ResourceHandle::finishJobAndHandle):
1841         (WebCore::ResourceHandle::reportError):
1842         * platform/network/mac/ResourceLoaderMac.mm: Removed.
1843         * platform/network/qt/ResourceHandleManager.cpp: Added.
1844         (WebCore::ResourceHandleManager::ResourceHandleManager):
1845         (WebCore::ResourceHandleManager::~ResourceHandleManager):
1846         (WebCore::ResourceHandleManager::self):
1847         (WebCore::ResourceHandleManager::slotData):
1848         (WebCore::ResourceHandleManager::slotMimetype):
1849         (WebCore::ResourceHandleManager::slotResult):
1850         (WebCore::ResourceHandleManager::remove):
1851         (WebCore::ResourceHandleManager::add):
1852         (WebCore::ResourceHandleManager::cancel):
1853         * platform/network/qt/ResourceHandleManager.h: Added.
1854         * platform/network/qt/ResourceHandleQt.cpp: Added.
1855         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1856         (WebCore::ResourceHandle::~ResourceHandle):
1857         (WebCore::ResourceHandle::start):
1858         (WebCore::ResourceHandle::cancel):
1859         (WebCore::ResourceHandle::assembleResponseHeaders):
1860         (WebCore::ResourceHandle::retrieveResponseEncoding):
1861         (WebCore::ResourceHandle::receivedResponse):
1862         (WebCore::ResourceHandle::extractCharsetFromHeaders):
1863         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
1864         * platform/network/qt/ResourceLoaderManager.h: Removed.
1865         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
1866         * platform/network/win/ResourceHandleWin.cpp: Added.
1867         (WebCore::):
1868         (WebCore::addToOutstandingJobs):
1869         (WebCore::lookupResourceHandle):
1870         (WebCore::ResourceHandleWndProc):
1871         (WebCore::initializeOffScreenResourceHandleWindow):
1872         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1873         (WebCore::ResourceHandle::~ResourceHandle):
1874         (WebCore::ResourceHandle::onHandleCreated):
1875         (WebCore::ResourceHandle::onRequestRedirected):
1876         (WebCore::ResourceHandle::onRequestComplete):
1877         (WebCore::ResourceHandle::start):
1878         (WebCore::ResourceHandle::fileLoadTimer):
1879         (WebCore::ResourceHandle::cancel):
1880         (WebCore::ResourceHandle::setHasReceivedResponse):
1881         (WebCore::ResourceHandle::hasReceivedResponse):
1882         * platform/network/win/ResourceHandleWin.h: Added.
1883         * platform/network/win/ResourceLoaderWin.cpp: Removed.
1884         * platform/network/win/ResourceLoaderWin.h: Removed.
1885         * platform/qt/FrameQt.cpp:
1886         * platform/qt/FrameQtClient.cpp:
1887         (WebCore::FrameQtClientDefault::openURL):
1888         (WebCore::FrameQtClientDefault::submitForm):
1889         (WebCore::FrameQtClientDefault::receivedResponse):
1890         (WebCore::FrameQtClientDefault::didReceiveData):
1891         (WebCore::FrameQtClientDefault::receivedAllData):
1892         * platform/qt/FrameQtClient.h:
1893         * platform/win/TemporaryLinkStubs.cpp:
1894         (WebCore::ResourceHandle::assembleResponseHeaders):
1895         (WebCore::ResourceHandle::retrieveResponseEncoding):
1896         (WebCore::ServeSynchronousRequest):
1897         * xml/XSLTProcessor.cpp:
1898         * xml/xmlhttprequest.cpp:
1899         (WebCore::XMLHttpRequest::send):
1900         (WebCore::XMLHttpRequest::didFinishLoading):
1901         (WebCore::XMLHttpRequest::receivedRedirect):
1902         (WebCore::XMLHttpRequest::didReceiveData):
1903         * xml/xmlhttprequest.h:
1904
1905 t2006-10-29  Darin Adler  <darin@apple.com>
1906
1907         Reviewed by Maciej.
1908
1909         - eliminate use of NSArray to carry form data around
1910
1911         * WebCore.exp:
1912         * WebCore.xcodeproj/project.pbxproj:
1913         * bridge/mac/FormDataMac.h: Removed.
1914         * bridge/mac/FormDataMac.mm: Removed.
1915         * bridge/mac/FrameMac.h:
1916         * bridge/mac/WebCoreFrameBridge.h:
1917         * bridge/mac/WebCoreFrameBridge.mm:
1918         * html/HTMLFormElement.cpp:
1919         (WebCore::HTMLFormElement::submit):
1920         * loader/FormData.h:
1921         (WebCore::FormData::isEmpty):
1922         * loader/mac/FrameLoader.h:
1923         * loader/mac/FrameLoader.mm:
1924         (WebCore::FrameLoader::load):
1925         (WebCore::FrameLoader::post):
1926         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
1927         (WebCore::FrameLoader::loadResourceSynchronously):
1928         * loader/mac/LoaderFunctionsMac.mm:
1929         (WebCore::ServeSynchronousRequest):
1930         * loader/mac/WebFormDataStream.h:
1931         * loader/mac/WebFormDataStream.m:
1932         (WebCore::pairRetain):
1933         (WebCore::pairRelease):
1934         (WebCore::pairEqual):
1935         (WebCore::pairHash):
1936         (WebCore::closeCurrentStream):
1937         (WebCore::scheduleWithPair):
1938         (WebCore::advanceCurrentStream):
1939         (WebCore::openNextStream):
1940         (WebCore::formCreate):
1941         (WebCore::formFinalize):
1942         (WebCore::formOpen):
1943         (WebCore::formRead):
1944         (WebCore::formCanRead):
1945         (WebCore::formClose):
1946         (WebCore::formSchedule):
1947         (WebCore::formUnschedule):
1948         (WebCore::formEventCallback):
1949         (WebCore::setHTTPBody):
1950         * loader/mac/WebSubresourceLoader.h:
1951         * loader/mac/WebSubresourceLoader.mm:
1952         (WebCore::SubresourceLoader::create):
1953         * platform/network/mac/ResourceLoaderMac.mm:
1954
1955 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1956
1957         Reviewed by Darin.
1958
1959         - create SubresourceLoader with a ResourceRequest, not broken out request bits
1960
1961         * loader/mac/WebSubresourceLoader.h:
1962         * loader/mac/WebSubresourceLoader.mm:
1963         (WebCore::SubresourceLoader::create):
1964         * platform/network/mac/ResourceLoaderMac.mm:
1965         (WebCore::ResourceLoader::start):
1966
1967 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1968
1969         Reviewed by Darin.
1970
1971         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
1972
1973         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
1974
1975         * WebCore.xcodeproj/project.pbxproj:
1976         * bridge/mac/WebCoreFrameBridge.h:
1977         * loader/mac/FrameLoader.h:
1978         * loader/mac/FrameLoader.mm:
1979         * loader/mac/LoaderFunctionsMac.mm:
1980         * loader/mac/WebLoader.h:
1981         * loader/mac/WebSubresourceLoader.h:
1982         * loader/mac/WebSubresourceLoader.mm:
1983         (WebCore::SubresourceLoader::SubresourceLoader):
1984         (WebCore::SubresourceLoader::create):
1985         (WebCore::SubresourceLoader::willSendRequest):
1986         (WebCore::SubresourceLoader::didReceiveResponse):
1987         (WebCore::SubresourceLoader::didReceiveData):
1988         (WebCore::SubresourceLoader::didFinishLoading):
1989         (WebCore::SubresourceLoader::didFail):
1990         (WebCore::SubresourceLoader::didCancel):
1991         * platform/network/ResourceLoader.h:
1992         * platform/network/ResourceLoaderInternal.h:
1993         * platform/network/mac/ResourceLoaderMac.mm:
1994         (WebCore::ResourceLoader::~ResourceLoader):
1995         (WebCore::ResourceLoader::start):
1996         (WebCore::ResourceLoader::receivedResponse):
1997         (WebCore::ResourceLoader::cancel):
1998         (WebCore::ResourceLoader::redirectedToURL):
1999         (WebCore::ResourceLoader::addData):
2000         (WebCore::ResourceLoader::finishJobAndHandle):
2001         (WebCore::ResourceLoader::reportError):
2002         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2003         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2004         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2005
2006 2006-10-28  Darin Adler  <darin@apple.com>
2007
2008         Reviewed by Maciej.
2009
2010         - eliminated the use of Objective-C for the policy decider
2011           machinery, obviating the need for WebPolicyDecider,
2012           WebCoreFrameLoaderAsDelegate, and
2013           WebCoreMainResourceLoaderAsPolicyDelegate
2014
2015         - grouped the state related to policy decisions into a PolicyCheck
2016           class to simplify the FrameLoader logic
2017
2018         - removed six methods from the bridge, reducing FrameLoader's use of
2019           the bridge to a single method
2020
2021         - changed form state to always use HashMap instead of NSDictionary
2022
2023         - moved the defersLoading flag from WebView to WebCore::Page
2024           and changed code to consistently call it defersLoading rather
2025           than defersCallbacks
2026
2027         - updated for rename of PassRefPtr::release to releaseRef
2028         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2029         - cleaned up kjs_binding.h a bit
2030         - cleaned up FrameMac.h a bit
2031
2032         * loader/mac/WebPolicyDecider.h: Removed.
2033         * loader/mac/WebPolicyDecider.mm: Removed.
2034         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2035
2036         * WebCore.exp:
2037         * bindings/js/kjs_binding.cpp:
2038         (KJS::ScriptInterpreter::ScriptInterpreter):
2039         (KJS::ScriptInterpreter::wasRunByUserGesture):
2040         * bindings/js/kjs_binding.h:
2041         (KJS::ScriptInterpreter::setCurrentEvent):
2042         (KJS::ScriptInterpreter::setInlineCode):
2043         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2044         (KJS::ScriptInterpreter::getCurrentEvent):
2045         (KJS::cacheDOMObject):
2046         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2047         * bridge/AXObjectCache.h:
2048         * bridge/mac/BrowserExtensionMac.mm:
2049         (WebCore::BrowserExtensionMac::createNewWindow):
2050         * bridge/mac/FrameMac.h:
2051         * bridge/mac/FrameMac.mm:
2052         (WebCore::FrameMac::loadRequest):
2053         (WebCore::FrameMac::submitForm):
2054         (WebCore::FrameMac::urlSelected):
2055         (WebCore::FrameMac::userAgent):
2056         (WebCore::FrameMac::passMouseDownEventToWidget):
2057         (WebCore::FrameMac::handleMouseMoveEvent):
2058         * bridge/mac/PageMac.mm:
2059         (WebCore::Page::Page):
2060         * bridge/mac/WebCoreEditCommand.mm:
2061         * bridge/mac/WebCoreFrameBridge.h:
2062         * bridge/mac/WebCoreFrameBridge.mm:
2063         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2064         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2065         * css/CSSComputedStyleDeclaration.cpp:
2066         (WebCore::):
2067         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2068         * css/CSSPrimitiveValue.cpp:
2069         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2070         (WebCore::CSSPrimitiveValue::cleanup):
2071         (WebCore::CSSPrimitiveValue::cssText):
2072         * css/CSSPrimitiveValue.h:
2073         (WebCore::CSSPrimitiveValue::):
2074         * css/CSSValueList.cpp:
2075         (WebCore::CSSValueList::append):
2076         * css/cssparser.cpp:
2077         (WebCore::CSSParser::parseValue):
2078         * css/cssparser.h:
2079         * css/cssstyleselector.cpp:
2080         (WebCore::CSSStyleSelector::applyProperty):
2081         * dom/Document.cpp:
2082         (WebCore::Document::Document):
2083         (WebCore::Document::updateSelection):
2084         (WebCore::Document::implicitClose):
2085         (WebCore::Document::setFocusNode):
2086         * dom/Document.h:
2087         * editing/ReplaceSelectionCommand.h:
2088         * html/HTMLParser.cpp:
2089         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2090         * loader/mac/FrameLoader.h:
2091         (WebCore::PolicyCheck::request):
2092         * loader/mac/FrameLoader.mm:
2093         (WebCore::FrameLoader::~FrameLoader):
2094         (WebCore::FrameLoader::safeLoad):
2095         (WebCore::FrameLoader::load):
2096         (WebCore::FrameLoader::open):
2097         (WebCore::FrameLoader::stopLoading):
2098         (WebCore::setAllDefersLoading):
2099         (WebCore::FrameLoader::setDefersLoading):
2100         (WebCore::FrameLoader::willSendRequest):
2101         (WebCore::FrameLoader::receivedMainResourceError):
2102         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2103         (WebCore::FrameLoader::commitProvisionalLoad):
2104         (WebCore::FrameLoader::checkNavigationPolicy):
2105         (WebCore::FrameLoader::checkContentPolicy):
2106         (WebCore::FrameLoader::cancelContentPolicyCheck):
2107         (WebCore::FrameLoader::stopPolicyCheck):
2108         (WebCore::FrameLoader::checkNewWindowPolicy):
2109         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2110         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2111         (WebCore::FrameLoader::continueAfterContentPolicy):
2112         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2113         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
2114         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2115         (WebCore::FrameLoader::closeDocument):
2116         (WebCore::FrameLoader::transitionToCommitted):
2117         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
2118         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2119         (WebCore::FrameLoader::post):
2120         (WebCore::FrameLoader::detachFromParent):
2121         (WebCore::FrameLoader::addExtraFieldsToRequest):
2122         (WebCore::PolicyCheck::PolicyCheck):
2123         (WebCore::PolicyCheck::clear):
2124         (WebCore::PolicyCheck::set):
2125         (WebCore::PolicyCheck::call):
2126         (WebCore::PolicyCheck::dropRequest):
2127         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2128         * loader/mac/WebFormState.h:
2129         * loader/mac/WebFormState.mm:
2130         * loader/mac/WebFrameLoaderClient.h:
2131         * loader/mac/WebLoader.h:
2132         (WebCore::WebResourceLoader::defersLoading):
2133         * loader/mac/WebLoader.mm:
2134         (WebCore::WebResourceLoader::WebResourceLoader):
2135         (WebCore::WebResourceLoader::load):
2136         (WebCore::WebResourceLoader::setDefersLoading):
2137         * loader/mac/WebMainResourceLoader.h:
2138         * loader/mac/WebMainResourceLoader.mm:
2139         (WebCore::MainResourceLoader::MainResourceLoader):
2140         (WebCore::MainResourceLoader::releaseDelegate):
2141         (WebCore::MainResourceLoader::didCancel):
2142         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2143         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2144         (WebCore::MainResourceLoader::willSendRequest):
2145         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2146         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2147         (WebCore::MainResourceLoader::didReceiveResponse):
2148         (WebCore::MainResourceLoader::didReceiveData):
2149         (WebCore::MainResourceLoader::didFinishLoading):
2150         (WebCore::MainResourceLoader::didFail):
2151         (WebCore::MainResourceLoader::loadNow):
2152         (WebCore::MainResourceLoader::load):
2153         (WebCore::MainResourceLoader::setDefersLoading):
2154         * page/Frame.cpp:
2155         (WebCore::Frame::paint):
2156         * page/FrameView.cpp:
2157         (WebCore::FrameView::layout):
2158         * page/FrameView.h:
2159         * page/Page.cpp:
2160         (WebCore::Page::setDefersLoading):
2161         * page/Page.h:
2162         (WebCore::Page::defersLoading):
2163         * platform/DeprecatedString.h:
2164         * platform/DeprecatedStringList.h:
2165         * platform/FontFallbackList.h:
2166         * platform/PlatformKeyboardEvent.h:
2167         * platform/PlatformMouseEvent.h:
2168         * platform/PlatformWheelEvent.h:
2169         * platform/mac/ClipboardMac.h:
2170         * platform/mac/ClipboardMac.mm:
2171         (WebCore::ClipboardMac::setDragImage):
2172         (WebCore::ClipboardMac::dragNSImage):
2173         (WebCore::ClipboardMac::sourceOperation):
2174         (WebCore::ClipboardMac::destinationOperation):
2175         * rendering/RenderObject.cpp:
2176         (WebCore::RenderObject::setStyle):
2177         * rendering/break_lines.cpp:
2178         (WebCore::nextBreakablePosition):
2179
2180 2006-10-28  Adam Roben  <aroben@apple.com>
2181
2182         Reviewed by Maciej.
2183
2184         Fix layout tests that broke after r17399. Mitz discovered that the
2185         failures were caused by HitTestResult::m_point being uninitialized
2186         much of the time. HitTestResults are now always constructed with a
2187         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
2188         point instead of being passed one explicitly.
2189
2190         * WebCore.exp: Change constructor symbol.
2191         * bridge/mac/FrameMac.mm:
2192         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
2193         hitTest().
2194         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
2195         * bridge/mac/WebCoreAXObject.mm:
2196         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
2197         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
2198         * dom/Document.cpp:
2199         (WebCore::Document::elementFromPoint): Ditto.
2200         (WebCore::Document::prepareMouseEvent): Ditto.
2201         * page/Frame.cpp:
2202         (WebCore::Frame::isPointInsideSelection): Ditto.
2203         (WebCore::Frame::hitTestResultAtPoint): Ditto.
2204         * page/FrameView.cpp:
2205         (WebCore::FrameView::handleWheelEvent): Ditto.
2206         * rendering/HitTestResult.cpp:
2207         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
2208         passed point.
2209         * rendering/HitTestResult.h: Update constructor declaration.
2210         * rendering/RenderLayer.cpp:
2211         (WebCore::RenderLayer::autoscroll): Update to new constructor and
2212         hitTest().
2213         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
2214         HitTestResult instead of being passed one.
2215         (WebCore::RenderLayer::hitTestLayer): Ditto.
2216         * rendering/RenderLayer.h: Update declarations.
2217
2218 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
2219
2220         Reviewed by Anders.
2221
2222         Fix Qt/Linux build.
2223
2224         * CMakeLists.txt:
2225         * platform/qt/FrameQtClient.cpp:
2226         (WebCore::numRequests):
2227         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
2228         * platform/qt/PopupMenuQt.cpp:
2229         (WebCore::PopupMenu::updateFromElement):
2230
2231 2006-10-28  David Carson  <dacarson@gmail.com>
2232
2233         Tweaked by Sam. Reviewed by Brady.
2234
2235         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
2236         Initialize m_modifyBiasSet to false, as it sometimes gets
2237         used before it has been initalized.
2238
2239         * editing/SelectionController.cpp:
2240         (WebCore::SelectionController::SelectionController):
2241
2242 2006-10-28  Beth Dakin  <bdakin@apple.com>
2243
2244         Reviewed by Darin.
2245
2246         This is the WebCore half of pushing elementAtPoint and the backend
2247         of WebElementDictionary into WebCore. Most of the changes below are
2248         to accommodate one of the following:
2249
2250         -NodeInfo is now a stand-alone class called HitTestResult.
2251                 Previously it was defined in RenderObject.h, but not for
2252                 any particular reason. The WebElementDictionary
2253                 functionality that was pushed into WebCore has been pushed
2254                 specifically into the this class. In fact,
2255                 WebElementDictionary now keeps a HitTestResult as a member
2256                 varibale.
2257
2258         -The enumeration AccessPolicy is now called
2259                 ClipboardAccessPolicy and is defined in its own header. It
2260                 was previously defined in ClipboardMac.h, but is now
2261                 defined independently to avoid including ClipboardMac.h
2262                 from within FrameMac.h since FrameMac.h is now included in
2263                 WebElementDictionary.m in WebKit.
2264
2265         -Element now has a virtual target() for the sake of
2266                 NodeInfo::targetFrame()
2267
2268         * WebCore.exp: Several WebCore functions are newly called from
2269         WebKit, so they have been added here.
2270         * WebCore.xcodeproj/project.pbxproj:
2271         * bindings/objc/DOM.mm: Must include Image.h because of adjustments
2272         to ClipboardMac.
2273         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
2274         * bridge/mac/FrameMac.mm:
2275         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy
2276         and HitTestResult changes.
2277         (WebCore::FrameMac::eventMayStartDrag): Same.
2278         (WebCore::FrameMac::handleMouseMoveEvent): Same.
2279         (WebCore::FrameMac::dispatchCPPEvent): Same.
2280         (WebCore::FrameMac::mayDHTMLCut): Same.
2281         (WebCore::FrameMac::mayDHTMLCopy): Same.
2282         (WebCore::FrameMac::mayDHTMLPaste): Same.
2283         (WebCore::FrameMac::tryDHTMLCut): Same
2284         (WebCore::FrameMac::tryDHTMLCopy): Same.
2285         (WebCore::FrameMac::tryDHTMLPaste): Same.
2286         * bridge/mac/WebCoreAXObject.mm:
2287         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to
2288         HitTestResult changes.
2289         (-[WebCoreAXObject accessibilityHitTest:]): Same.
2290         * bridge/mac/WebCoreFrameBridge.h: Same.
2291         * bridge/mac/WebCoreFrameBridge.mm:
2292         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for
2293         ClipboardAccessPolicy changes.
2294         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
2295         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
2296         * dom/Document.cpp:
2297         (WebCore::Document::elementFromPoint): Adjust for HitTestResult
2298         changes.
2299         (WebCore::Document::prepareMouseEvent): Same.
2300         * dom/Element.h:
2301         (WebCore::Element::target): Now has a virtual target()
2302         * html/HTMLAnchorElement.h: Same.
2303         * html/HTMLAreaElement.cpp:
2304         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult
2305         changes.
2306         * html/HTMLAreaElement.h: Virtual target()
2307         * html/HTMLBaseElement.h:
2308         (WebCore::HTMLBaseElement::target): Same.
2309         * html/HTMLFormElement.h: Same.
2310         * html/HTMLLinkElement.h: Same.
2311         * html/HTMLMapElement.cpp:
2312         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult
2313         changes.
2314         * html/HTMLMapElement.h: Same.
2315         * page/Frame.cpp:
2316         (WebCore::Frame::isPointInsideSelection): Same.
2317         (WebCore::Frame::hitTestResultAtPoint): Same.
2318         * page/Frame.h: Same.
2319         * page/FrameView.cpp:
2320         (WebCore::FrameView::handleWheelEvent): Same.
2321         * platform/mac/ClipboardAccessPolicy.h: Added.
2322         (WebCore::):
2323         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy,
2324         include ClipboardAccessPolicy.h, and rename AccessPolicy to
2325         ClipboardAccessPolicy.
2326         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
2327         (WebCore::ClipboardMac::ClipboardMac):
2328         (WebCore::ClipboardMac::setAccessPolicy):
2329         (WebCore::ClipboardMac::clearData):
2330         (WebCore::ClipboardMac::clearAllData):
2331         (WebCore::ClipboardMac::getData):
2332         (WebCore::ClipboardMac::setData):
2333         (WebCore::ClipboardMac::types):
2334         (WebCore::ClipboardMac::setDragImage):
2335         (WebCore::ClipboardMac::setDropEffect):
2336         (WebCore::ClipboardMac::setEffectAllowed):
2337         * rendering/EllipsisBox.cpp:
2338         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult
2339         changes.
2340         * rendering/EllipsisBox.h:
2341         * rendering/HitTestResult.cpp: Added.
2342         (WebCore::HitTestResult::HitTestResult):
2343         (WebCore::HitTestResult::~HitTestResult):
2344         (WebCore::HitTestResult::operator=):
2345         (WebCore::HitTestResult::setInnerNode):
2346         (WebCore::HitTestResult::setInnerNonSharedNode):
2347         (WebCore::HitTestResult::setURLElement):
2348         (WebCore::HitTestResult::setScrollbar):
2349         (WebCore::HitTestResult::targetFrame):
2350         (WebCore::HitTestResult::boundingBox):
2351         (WebCore::HitTestResult::isSelected):
2352         (WebCore::HitTestResult::title):
2353         * rendering/HitTestResult.h: Added.
2354         (WebCore::HitTestResult::readonly):
2355         (WebCore::HitTestResult::active):
2356         (WebCore::HitTestResult::mouseMove):
2357         (WebCore::HitTestResult::innerNode):
2358         (WebCore::HitTestResult::innerNonSharedNode):
2359         (WebCore::HitTestResult::point):
2360         (WebCore::HitTestResult::URLElement):
2361         (WebCore::HitTestResult::scrollbar):
2362         (WebCore::HitTestResult::setPoint):
2363         (WebCore::HitTestResult::setReadonly):
2364         (WebCore::HitTestResult::setActive):
2365         (WebCore::HitTestResult::setMouseMove):
2366         * rendering/InlineBox.cpp:
2367         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
2368         * rendering/InlineBox.h: Same.
2369         * rendering/InlineFlowBox.cpp:
2370         (WebCore::InlineFlowBox::nodeAtPoint): Same.
2371         * rendering/InlineFlowBox.h: Same.
2372         * rendering/InlineTextBox.cpp:
2373         (WebCore::InlineTextBox::nodeAtPoint): Same.
2374         * rendering/InlineTextBox.h: Same.
2375         * rendering/RenderBlock.cpp:
2376         (WebCore::RenderBlock::isPointInScrollbar): Same.
2377         (WebCore::RenderBlock::nodeAtPoint): Same.
2378         * rendering/RenderBlock.h: Same.
2379         * rendering/RenderBox.cpp:
2380         (WebCore::RenderBox::nodeAtPoint): Same.
2381         * rendering/RenderBox.h: Same.
2382         * rendering/RenderFlow.cpp:
2383         (WebCore::RenderFlow::hitTestLines): Same.
2384         * rendering/RenderFlow.h: Same.
2385         * rendering/RenderForeignObject.cpp:
2386         (WebCore::RenderForeignObject::nodeAtPoint): Same.
2387         * rendering/RenderForeignObject.h: Same.
2388         * rendering/RenderFrameSet.cpp:
2389         (WebCore::RenderFrameSet::nodeAtPoint): Same.
2390         * rendering/RenderFrameSet.h: Same.
2391         * rendering/RenderImage.cpp:
2392         (WebCore::RenderImage::nodeAtPoint): Same.
2393         * rendering/RenderImage.h: Same.
2394         * rendering/RenderInline.cpp:
2395         (WebCore::RenderInline::nodeAtPoint): Same.
2396         * rendering/RenderInline.h: Same.
2397         * rendering/RenderLayer.cpp:
2398         (WebCore::RenderLayer::autoscroll): Same.
2399         (WebCore::RenderLayer::hitTest): Same.
2400         (WebCore::RenderLayer::hitTestLayer): Same.
2401         (WebCore::RenderLayer::updateHoverActiveState): Same.
2402         * rendering/RenderLayer.h: Same.
2403         * rendering/RenderListBox.cpp:
2404         (WebCore::RenderListBox::isPointInScrollbar): Same.
2405         * rendering/RenderListBox.h: Same.
2406         * rendering/RenderObject.cpp:
2407         (WebCore::RenderObject::hitTest): Same.
2408         (WebCore::RenderObject::setInnerNode): Same.
2409         (WebCore::RenderObject::nodeAtPoint): Same.
2410         * rendering/RenderObject.h: Remove NodeInfo class and forward
2411         declare HitTestResult.
2412         * rendering/RenderPath.cpp:
2413         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult
2414         changes.
2415         * rendering/RenderPath.h: Same.
2416         * rendering/RenderSVGImage.cpp:
2417         (WebCore::RenderSVGImage::nodeAtPoint): Same.
2418         * rendering/RenderSVGImage.h: Same
2419         * rendering/RenderSVGText.cpp:
2420         (WebCore::RenderSVGText::nodeAtPoint): Same.
2421         * rendering/RenderSVGText.h: Same.
2422         * rendering/RenderTableRow.cpp:
2423         (WebCore::RenderTableRow::nodeAtPoint): Same.
2424         * rendering/RenderTableRow.h: Same.
2425         * rendering/RenderTableSection.cpp:
2426         (WebCore::RenderTableSection::nodeAtPoint): Same.
2427         * rendering/RenderTableSection.h: Same.
2428         * rendering/RenderText.h: Same.
2429         (WebCore::RenderText::nodeAtPoint): Same.
2430         * rendering/RenderTextControl.cpp:
2431         (WebCore::RenderTextControl::nodeAtPoint): Same.
2432         * rendering/RenderTextControl.h: Same.
2433         * rendering/RootInlineBox.cpp:
2434         (WebCore::RootInlineBox::nodeAtPoint): Same.
2435         * rendering/RootInlineBox.h: Same.
2436
2437 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2438
2439         Reviewed by Anders.
2440
2441         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
2442         impact of fixing it again.
2443
2444         * bridge/mac/FrameMac.mm:
2445         (WebCore::FrameMac::clear):
2446
2447 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2448
2449         Reviewed by John & Adam.
2450
2451         - assorted speedups to fix perf regression from fixing correctness regression
2452
2453         * WebCore.exp: exported new methods.
2454         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
2455         * bridge/mac/WebCoreFrameBridge.h:
2456         * bridge/mac/WebCoreFrameBridge.mm:
2457         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
2458         * loader/CachedResource.h:
2459         * loader/mac/CachedResourceMac.mm: Added.
2460         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
2461         now cached in the CachedObject.
2462         * loader/mac/FrameLoader.h:
2463         * loader/mac/FrameLoader.mm:
2464         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
2465         the WebKit side do faster dispatch for clients that implement the fast path delegate.
2466         * loader/mac/LoaderFunctionsMac.mm:
2467         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
2468         just call loadedResourceFromMemoryCache.
2469         * loader/mac/WebFrameLoaderClient.h:
2470
2471 2006-10-27  Oliver Hunt  <oliver@apple.com>
2472
2473         Reviewed by Maciej.
2474
2475         build fix
2476
2477         * dom/Document.cpp:
2478         (WebCore::Document::referrer):
2479
2480 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
2481
2482         Reviewed by Maciej.
2483
2484         Moved some WebCoreFrameBridge functions into FrameLoader.
2485
2486         I had to make FrameLoader.h capable of compiling in C++-only source files
2487         by adding some forward declarations and __OBJC__ #ifdefs.
2488
2489         * WebCore.exp:
2490         * bridge/mac/FrameMac.h:
2491         * bridge/mac/FrameMac.mm:
2492         (WebCore::FrameMac::createEmptyDocument):
2493         (WebCore::FrameMac::tokenizerProcessedData):
2494         * bridge/mac/WebCoreFrameBridge.h:
2495         * bridge/mac/WebCoreFrameBridge.mm:
2496         * dom/Document.cpp:
2497         (WebCore::Document::processHttpEquiv):
2498         (WebCore::Document::referrer):
2499         * loader/LoaderFunctions.h:
2500         * loader/mac/FrameLoader.h:
2501         * loader/mac/FrameLoader.mm:
2502         (WebCore::numRequests):
2503         (WebCore::FrameLoader::numPendingOrLoadingRequests):
2504         (WebCore::FrameLoader::isReloading):
2505         (WebCore::FrameLoader::referrer):
2506         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2507         (WebCore::FrameLoader::startLoadingResource):
2508         * loader/mac/LoaderFunctionsMac.mm:
2509         (WebCore::CheckIfReloading):
2510         * page/Frame.h:
2511         * page/FrameTree.cpp:
2512         (WebCore::FrameTree::isDescendantOf):
2513         (WebCore::FrameTree::traverseNext):
2514         * page/FrameTree.h:
2515         * platform/network/mac/ResourceLoaderMac.mm:
2516         (WebCore::ResourceLoader::start):
2517
2518 2006-10-27  Timothy Hatcher  <timothy@apple.com>
2519
2520         Reviewed by Darin.
2521
2522         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
2523
2524         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
2525
2526         * editing/DeleteButtonController.cpp:
2527         (WebCore::isDeletableElement):
2528         (WebCore::enclosingDeletableElement):
2529         (WebCore::DeleteButtonController::respondToChangedSelection):
2530
2531 2006-10-27  John Sullivan  <sullivan@apple.com>
2532
2533         Reviewed by Kevin Decker
2534
2535         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
2536         you haven't not finished reading this.
2537
2538         * rendering/InlineTextBox.h:
2539         * rendering/InlineTextBox.cpp:
2540         (WebCore::InlineTextBox::paint):
2541         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
2542         considered also.
2543         (WebCore::InlineTextBox::paintDocumentMarkers):
2544         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
2545         markers should be painted, instead of a marker type. This avoids walking the collection of
2546         markers multiple times back to back. Now handles grammar markers.
2547
2548 2006-10-27  Timothy Hatcher  <timothy@apple.com>
2549
2550         Reviewed by Beth.
2551
2552         Renamed Copy Files to Copy Generated Headers.
2553         Copy 4 DOM*Internal.h headers.
2554
2555         * WebCore.xcodeproj/project.pbxproj:
2556         * bindings/scripts/CodeGeneratorObjC.pm:
2557
2558 2006-10-27  John Sullivan  <sullivan@apple.com>
2559
2560         Reviewed by Anders
2561
2562         * WebCore.exp:
2563         exported symbol for FrameMac->advanceToNextSpelling()
2564
2565         * bridge/mac/WebCoreFrameBridge.h:
2566         * bridge/mac/WebCoreFrameBridge.mm:
2567         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
2568
2569 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
2570
2571         Reviewed by harrison
2572
2573         <http://bugs.webkit.org/show_bug.cgi?id=11423>
2574         REGRESSION: First newline missing from textarea's value
2575
2576         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
2577
2578         Before my change in r17223, return (an InsertLineBreak) would insert a '\n'
2579         (the line break) then a br to prevent the '\n' from collapsing, since the
2580         insertion is being done at the end of a block (the textarea's shadow div).  Then,
2581         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".
2582         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed
2583         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would
2584         serialize as "foobar" because when serializing RenderTextControl intentionally asks
2585         textContent to not convert brs to newlines.  It seems to think that the only brs in
2586         the shadow div will be placeholders or collapsed.
2587
2588         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak
2589         to insert two '\n's when at the end of a block in white-space:pre text.  This alone
2590         would have fixed the bug, but introduced a new one, because foo, return, bar would
2591         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second
2592         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to
2593         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as
2594         a br or '\n' that will collapse (become superfluous) when content is inserted just
2595         before it.
2596
2597         * editing/CompositeEditCommand.cpp:
2598         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
2599         a br or '\n' if content inserted just before it will cause it to collapse.
2600         * editing/CompositeEditCommand.h:
2601         * editing/InsertLineBreakCommand.cpp:
2602         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
2603         to prevent a collapse as was used for the line break.  Fixed comments.
2604         * editing/InsertTextCommand.cpp:
2605         (WebCore::InsertTextCommand::input): Call the renamed function.
2606
2607 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
2608
2609         Reviewed by Brady.
2610
2611         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
2612         String became an empty NSString *, instead of nil. This will become important
2613         as we start using this conversion more.
2614
2615         Added work-around for AppKit crash that semantic accuracy revealed.
2616
2617         No testcase because I don't think there's a way to reflect this change
2618         in a webpage yet.
2619
2620         * platform/PlatformString.h:
2621         (WebCore::String::operator NSString*):
2622         * platform/mac/TextFieldMac.mm:
2623         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2624
2625 2006-10-27  David Harrison  <harrison@apple.com>
2626
2627         Reviewed by Maciej,
2628
2629         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
2630
2631         * bridge/mac/WebCoreAXObject.mm:
2632         (blockquoteLevel):
2633         Calculate and return the blockquote level of the element.
2634
2635         (AXAttributeStringSetBlockquoteLevel):
2636         Add, if non-zero, or clear the block quote level attribute.
2637
2638         (AXAttributedStringAppendText):
2639         Send AXAttributeStringSetBlockquoteLevel.
2640
2641 2006-10-27  Darin Adler  <darin@apple.com>
2642
2643         - fix one error in the Qt build
2644
2645         * platform/qt/GraphicsContextQt.cpp:
2646         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2647         Updated.
2648
2649 2006-10-27  Darin Adler  <darin@apple.com>
2650
2651         Reviewed by Maciej.
2652
2653         * WebCore.exp: Export more symbols needed by WebKit.
2654
2655 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
2656
2657         Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.
2658
2659         Fixed layout test crash. Oops.
2660
2661         * loader/mac/WebDocumentLoader.mm:
2662         (WebCore::canonicalizedTitle):
2663
2664 2006-10-26  John Sullivan  <sullivan@apple.com>
2665
2666         Reviewed by Brady
2667
2668         - fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
2669
2670         This restores some of the nil-handling that was implicit before some of the code was converted from
2671         Objective-C to C++.
2672
2673         * bridge/mac/FrameMac.mm:
2674         (WebCore::FrameMac::loadRequest):
2675         handle nil FrameMac
2676
2677         * bridge/mac/WebCoreFrameBridge.mm:
2678         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
2679         handle nil Frame
2680
2681 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
2682
2683         Reviewed by Darin, Maciej.
2684
2685         Removed many uses of NSString *.
2686         Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing
2687         stringByCollapsingNonPrintingCharacters with a c++ equivalent.
2688
2689         PLT says no performance regression.
2690
2691         * WebCore.exp:
2692         * bridge/mac/WebCoreFrameBridge.mm:
2693         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
2694         * loader/mac/FrameLoader.h:
2695         * loader/mac/FrameLoader.mm:
2696         (WebCore::FrameLoader::setupForReplaceByMIMEType):
2697         (WebCore::FrameLoader::load):
2698         (WebCore::FrameLoader::canShowMIMEType):
2699         (WebCore::FrameLoader::representationExistsForURLScheme):
2700         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
2701         (WebCore::FrameLoader::checkContentPolicy):
2702         (WebCore::FrameLoader::reloadAllowingStaleData):
2703         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
2704         (WebCore::FrameLoader::checkNewWindowPolicy):
2705         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2706         (WebCore::FrameLoader::transitionToCommitted):
2707         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
2708         (WebCore::FrameLoader::post):
2709         * loader/mac/WebDocumentLoader.h:
2710         * loader/mac/WebDocumentLoader.mm:
2711         (WebCore::DocumentLoader::doesProgressiveLoad):
2712         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
2713         (WebCore::DocumentLoader::title):
2714         (WebCore::DocumentLoader::setOverrideEncoding):
2715         (WebCore::DocumentLoader::overrideEncoding):
2716         (WebCore::DocumentLoader::setTitle):
2717         * loader/mac/WebFrameLoaderClient.h:
2718         * loader/mac/WebMainResourceLoader.mm:
2719         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2720
2721 2006-10-26  Timothy Hatcher  <timothy@apple.com>
2722
2723         Reviewed by Adam.
2724
2725         <rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com
2726
2727         The main table at nytimes.com has a fixed width of 874px, but the table ends
2728         up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
2729         this. The other bug was a missing top and left of 0px on the container element,
2730         causing the deletion UI to sometimes be offset below the table.
2731
2732         Now check for the element's renderer at the beginning of show() and
2733         return early if it is null.
2734
2735         * editing/DeleteButtonController.cpp:
2736         (WebCore::DeleteButtonController::updateOutlineStyle):
2737         (WebCore::DeleteButtonController::show):
2738
2739 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
2740
2741         Build fix.
2742
2743         * html/CanvasRenderingContext2D.cpp:
2744         Include MathExtras.h
2745
2746 2006-10-26  John Sullivan  <sullivan@apple.com>
2747
2748         Reviewed by Anders.
2749
2750         Some changes to support new grammar checking code in WebKit.
2751
2752         * WebCore.exp:
2753         added mangled symbol for Document->removeMarkers() so I can call it from WebKit
2754
2755         * WebCore.xcodeproj/project.pbxproj:
2756         Made Document.h and DocumentMarker.h private so I can include them from WebKit.
2757         Made HTMLCollection.h private because Document.h uses it.
2758
2759         * bridge/mac/WebCoreFrameBridge.h:
2760         * bridge/mac/WebCoreFrameBridge.mm:
2761         removed unmarkAllMisspellings(); WebKit now calls through to the Document directly
2762
2763 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
2764
2765         Reviewed by Brady.
2766
2767         Add reverseFind to String and use it instead of findRev.
2768         Use CString instead of DeprecatedCString in one place.
2769
2770         * html/HTMLFormElement.cpp:
2771         (WebCore::HTMLFormElement::formData):
2772         * ksvg2/svg/SVGURIReference.cpp:
2773         (WebCore::SVGURIReference::getTarget):
2774         * loader/Decoder.cpp:
2775         (WebCore::Decoder::checkForCSSCharset):
2776         * platform/PlatformString.h:
2777         (WebCore::String::reverseFind):
2778         * platform/StringImpl.cpp:
2779         (WebCore::StringImpl::reverseFind):
2780         * platform/StringImpl.h:
2781
2782 2006-10-26  John Sullivan  <sullivan@apple.com>
2783
2784         Reviewed by Darin
2785
2786         More plumbing for grammar checking. Still no grammars is checked.
2787
2788         * dom/DocumentMarker.h:
2789         (WebCore::DocumentMarker::):
2790         added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"
2791
2792         * platform/GraphicsContext.h:
2793         renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar;
2794         now takes a bool parameter for whether it represents bad grammar or a misspelling
2795
2796         * platform/mac/GraphicsContextMac.mm:
2797         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2798         Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed
2799         an existing "assert" to "ASSERT".
2800
2801         * rendering/InlineTextBox.h:
2802         renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
2803
2804         * rendering/InlineTextBox.cpp:
2805         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
2806         Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents
2807         bad grammar or a misspelling
2808         (WebCore::InlineTextBox::paintAllMarkersOfType):
2809         now handles markers of type Grammar
2810
2811 === Safari-521.29 ===
2812
2813 2006-10-26  Sam Weinig  <sam.weinig@gmail.com>
2814
2815         Reviewed by Mitz.
2816
2817         Fix for http://bugs.webkit.org/show_bug.cgi?id=11424
2818         Cleanup rendering code
2819
2820         - Assorted code cleanup.
2821
2822         * rendering/AutoTableLayout.cpp:
2823         * rendering/AutoTableLayout.h:
2824         (WebCore::AutoTableLayout::totalPercent):
2825         * rendering/CounterListItem.h:
2826         * rendering/CounterNode.cpp:
2827         * rendering/CounterNode.h:
2828         (WebCore::CounterNode::~CounterNode):
2829         (WebCore::CounterNode::isReset):
2830         * rendering/CounterResetNode.cpp:
2831         * rendering/CounterResetNode.h:
2832         * rendering/DataRef.h:
2833         (WebCore::DataRef::DataRef):
2834         * rendering/DeprecatedRenderSelect.h:
2835         * rendering/DeprecatedSlider.cpp:
2836         * rendering/DeprecatedSlider.h:
2837         * rendering/EllipsisBox.cpp:
2838         * rendering/EllipsisBox.h:
2839         (WebCore::EllipsisBox::EllipsisBox):
2840         * rendering/FixedTableLayout.cpp:
2841         * rendering/FixedTableLayout.h:
2842         * rendering/GapRects.h:
2843         * rendering/InlineBox.cpp:
2844         * rendering/InlineBox.h:
2845         (WebCore::InlineBox::InlineBox):
2846         (WebCore::InlineBox::setConstructed):
2847         (WebCore::InlineBox::clearTruncation):
2848         (WebCore::InlineBox::markDirty):
2849         * rendering/InlineFlowBox.cpp:
2850         * rendering/InlineFlowBox.h:
2851         (WebCore::InlineFlowBox::InlineFlowBox):
2852         (WebCore::InlineFlowBox::setConstructed):
2853         (WebCore::InlineFlowBox::setEdges):
2854         (WebCore::InlineFlowBox::setVerticalOverflowPositions):
2855         (WebCore::InlineFlowBox::setVerticalSelectionPositions):
2856         * rendering/InlineRunBox.h:
2857         (WebCore::InlineRunBox::paintBackgroundAndBorder):
2858         (WebCore::InlineRunBox::paintDecorations):
2859         * rendering/InlineTextBox.cpp:
2860         * rendering/InlineTextBox.h:
2861         (WebCore::InlineTextBox::InlineTextBox):
2862         (WebCore::InlineTextBox::end):
2863         (WebCore::InlineTextBox::textObject):
2864         * rendering/Length.h:
2865         (WebCore::Length::Length):
2866         * rendering/ListMarkerBox.cpp:
2867         * rendering/ListMarkerBox.h:
2868         * rendering/RenderPartObject.h:
2869         * rendering/RootInlineBox.cpp:
2870         * rendering/RootInlineBox.h:
2871         * rendering/SVGInlineFlowBox.cpp:
2872         * rendering/SVGInlineFlowBox.h:
2873         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
2874         * rendering/SVGRootInlineBox.cpp:
2875         * rendering/SVGRootInlineBox.h:
2876         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
2877         * rendering/TableLayout.h:
2878         (WebCore::TableLayout::TableLayout):
2879         (WebCore::TableLayout::~TableLayout):
2880         * rendering/bidi.h:
2881         (WebCore::BidiStatus::BidiStatus):
2882         (WebCore::BidiRun::BidiRun):
2883         * rendering/break_lines.h:
2884
2885 2006-10-26  Justin Garcia  <justin.garcia@apple.com>
2886
2887         Reviewed by john
2888
2889         <http://bugs.webkit.org/show_bug.cgi?id=11329>
2890         Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.
2891
2892         * editing/Editor.cpp:
2893         (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor.
2894         Wrapped the plain text fragment in a style span with the document
2895         default style so that it will appear unstyled regardless of where
2896         it is inserted.  Could have also inserted the plain text fragment
2897         and then applied the document default style to it, but there is not
2898         yet any redundant style prevention in ApplyStyleCommand, so this
2899         is cleaner.
2900         * editing/Editor.h:
2901         * editing/JSEditor.cpp:
2902
2903 2006-10-26  Oliver Hunt  <oliver@apple.com>
2904
2905         Reviewed by Anders.
2906         Fixes <rdar://problem/4800518> -- needed to update existing
2907         canvas path elements when transforms are performed on the
2908         context.
2909
2910         * html/CanvasRenderingContext2D.cpp:
2911         (WebCore::CanvasRenderingContext2D::scale):
2912         (WebCore::CanvasRenderingContext2D::rotate):
2913         (WebCore::CanvasRenderingContext2D::translate):
2914
2915 2006-10-26  Nikolas Zimmermann  <zimmermann@kde.org>
2916
2917         Reviewed by Darin.
2918
2919         Fix Qt/Linux build.
2920
2921         * platform/network/qt/ResourceLoaderManager.cpp:
2922         (WebCore::ResourceLoaderManager::slotData):
2923         (WebCore::ResourceLoaderManager::slotMimetype):
2924         (WebCore::ResourceLoaderManager::remove):
2925         (WebCore::ResourceLoaderManager::add):
2926         * platform/network/qt/ResourceLoaderQt.cpp:
2927         (WebCore::ResourceLoader::receivedResponse):
2928         * platform/qt/FrameQtClient.cpp:
2929         (WebCore::FrameQtClientDefault::openURL):
2930         * platform/qt/LoaderFunctionsQt.cpp:
2931         (WebCore::ServeSynchronousRequest):
2932
2933 2006-10-26  Adam Roben  <aroben@apple.com>
2934
2935         Reviewed by Adele.
2936
2937         Fix: <rdar://problem/3951815> add "type-to-select" feature for list
2938         boxes (<select> elements)
2939         Fix: http://bugs.webkit.org/show_bug.cgi?id=9764 New popup menus
2940         should have type-ahead selection without popping up menu
2941
2942         * WebCore.xcodeproj/project.pbxproj: Version wars.
2943         * html/HTMLSelectElement.h: Add new instance variables for type-ahead
2944         find.
2945         * html/HTMLSelectElement.cpp:
2946         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new
2947         instance variables.
2948         (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead
2949         find on printable character presses.
2950         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove
2951         redundant check that the listIndex has changed (setSelectedIndex does
2952         this for us), and fix indentation.
2953         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if
2954         to an else-if.
2955         (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind()
2956         to strip leading whitespace (including non-breaking spaces) from a
2957         string.
2958         (WebCore::HTMLSelectElement::typeAheadFind): New method to perform
2959         type-ahead find.
2960         * platform/PopupMenu.h: Added new updateFromElement() method to be
2961         called from RenderMenuList::updateFromElement().
2962         * platform/mac/PopupMenuMac.mm:
2963         (WebCore::PopupMenu::updateFromElement): While we are using
2964         NSPopUpButtonCell for our popups, this method can stay empty.
2965         * rendering/RenderListBox.cpp:
2966         (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first
2967         selected element.
2968         * rendering/RenderMenuList.cpp:
2969         (WebCore::RenderMenuList::updateFromElement): Tell the popup to update
2970         if it's visible.
2971
2972 2006-10-26  Darin Adler  <darin@apple.com>
2973
2974         Reviewed by Anders.
2975
2976         - fix http://bugs.webkit.org/show_bug.cgi?id=11360
2977           editing/pasteboard/copy-paste-bidi intermittently fails due to disappearance of anonymous RenderBlock
2978
2979         * editing/ReplaceSelectionCommand.cpp:
2980         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
2981         Use two vectors instead of a hash map: more efficient, deterministic. There was no
2982         reason to use a hash table.
2983
2984 2006-10-26  Maciej Stachowiak  <mjs@apple.com>
2985
2986         Reviewed by Anders.
2987
2988         - .5% speed improvement by avoiding excess CFURLRef allocation
2989
2990         * loader/CachedResource.cpp:
2991         (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL
2992         here for later reuse.
2993         * loader/CachedResource.h:
2994         * loader/mac/LoaderFunctionsMac.mm:
2995         (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
2996
2997 2006-10-25  Darin Adler  <darin@apple.com>
2998
2999         Reviewed by Anders.
3000
3001         - removed 55 methods from WebCoreFrameBridge
3002         - changed callers to use Frame directly instead
3003         - put FrameLoaderTypes.h types into the WebCore namespace
3004         - first steps to get FrameLoader.h ready for cross-platform duty
3005
3006         * WebCore.exp:
3007         * WebCore.xcodeproj/project.pbxproj:
3008         * bridge/mac/BrowserExtensionMac.mm:
3009         (WebCore::BrowserExtensionMac::createNewWindow):
3010         * bridge/mac/FrameMac.h:
3011         * bridge/mac/FrameMac.mm:
3012         (WebCore::FrameMac::loadRequest):
3013         (WebCore::FrameMac::startRedirectionTimer):
3014         (WebCore::FrameMac::stopRedirectionTimer):
3015         (WebCore::FrameMac::passSubframeEventToSubframe):
3016         (WebCore::FrameMac::handledOnloadEvents):
3017         (WebCore::FrameMac::isLoadTypeReload):
3018         * bridge/mac/WebCoreFrameBridge.h:
3019         * bridge/mac/WebCoreFrameBridge.mm:
3020         (-[WebCoreFrameBridge executionContextForView:]):
3021         (updateRenderingForBindings):
3022         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3023         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
3024         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3025         (-[WebCoreFrameBridge installInFrame:]):
3026         (-[WebCoreFrameBridge numPendingOrLoadingRequests]):
3027         (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
3028         (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]):
3029         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
3030         (stringByCollapsingNonPrintingCharacters):
3031         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
3032         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
3033         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3034         * loader/FrameLoaderTypes.h:
3035         * loader/mac/FrameLoader.h:
3036         * loader/mac/FrameLoader.mm:
3037         (WebCore::FrameLoader::FrameLoader):
3038         (WebCore::FrameLoader::setupForReplace):
3039         (WebCore::FrameLoader::load):
3040         (WebCore::FrameLoader::activeDocumentLoader):
3041         (WebCore::FrameLoader::state):
3042         (WebCore::FrameLoader::setState):
3043         (WebCore::FrameLoader::clearProvisionalLoad):
3044         (WebCore::FrameLoader::markLoadComplete):
3045         (WebCore::FrameLoader::commitProvisionalLoad):
3046         (WebCore::FrameLoader::receivedMainResourceError):
3047         (WebCore::FrameLoader::handleFallbackContent):
3048         (WebCore::FrameLoader::isLoadingMainFrame):
3049         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3050         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3051         (WebCore::FrameLoader::continueAfterWillSubmitForm):
3052         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
3053         (WebCore::FrameLoader::transitionToCommitted):
3054         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3055         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3056         (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
3057         (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
3058         (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
3059         * loader/mac/ImageDocumentMac.mm:
3060         (WebCore::finishImageLoad):
3061         * loader/mac/WebDocumentLoader.mm:
3062         (WebCore::DocumentLoader::isLoadingInAPISense):
3063         * loader/mac/WebMainResourceLoader.h:
3064         * loader/mac/WebMainResourceLoader.mm:
3065         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3066         (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
3067         * loader/mac/WebSubresourceLoader.mm:
3068         (-[WebCoreSubresourceHandle initWithLoader:]):
3069         * platform/mac/ListBoxMac.mm:
3070         (-[WebCoreTableView keyDown:]):
3071         (-[WebCoreTableView keyUp:]):
3072         * platform/mac/WebCoreTextField.mm:
3073         (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
3074
3075 2006-10-25  Steve Falkenburg  <sfalken@apple.com>
3076
3077         Reviewed by Darin.
3078
3079         Printing fixes
3080
3081         * page/Frame.cpp:
3082         (WebCore::Frame::adjustPageHeight):
3083         * page/Frame.h:
3084         (WebCore::Frame::setupRootForPrinting):
3085         (WebCore::Frame::computePageRects):
3086
3087 2006-10-25  Anders Carlsson  <acarlsson@apple.com>
3088
3089         Reviewed by Geoff.
3090
3091         <rdar://problem/4799088>
3092         REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.
3093
3094         * loader/mac/WebSubresourceLoader.h:
3095         * loader/mac/WebSubresourceLoader.mm:
3096         (-[WebCoreSubresourceHandle initWithLoader:]):
3097         Set the HTTP method before the HTTP body.
3098
3099 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
3100
3101         Reviewed by Adam.
3102
3103         Renamed WebFrameLoader to FrameLoader, to match class name.
3104
3105         * WebCore.xcodeproj/project.pbxproj:
3106         * bridge/mac/FrameMac.mm:
3107         * bridge/mac/WebCoreFrameBridge.mm:
3108         * loader/mac/FrameLoader.mm: Added.
3109         * loader/mac/IconLoaderMac.mm:
3110         * loader/mac/WebDocumentLoader.mm:
3111         * loader/mac/WebFrameLoader.h: Removed.
3112         * loader/mac/WebFrameLoader.mm: Removed.
3113         * loader/mac/WebLoader.mm:
3114         * loader/mac/WebMainResourceLoader.mm:
3115         * loader/mac/WebNetscapePlugInStreamLoader.mm:
3116         * loader/mac/WebSubresourceLoader.mm:
3117
3118 2006-10-25  Darin Adler  <darin@apple.com>
3119
3120         - fix full builds
3121
3122         * WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.
3123
3124 2006-10-25  David Smith  <catfish.man@gmail.com>
3125
3126         Reviewed by Mitz.
3127
3128         Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
3129         http://bugs.webkit.org/show_bug.cgi?id=11411
3130
3131         * bridge/mac/WebCoreFrameBridge.mm:
3132         (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.
3133
3134 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3135
3136         Rubber stamped by Mitz.
3137
3138         - moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac
3139
3140         * WebCore.xcodeproj/project.pbxproj:
3141         * bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
3142         * bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
3143         * bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.
3144
3145 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3146
3147         Rubber stamped by Mark.
3148
3149         - remove no longer existing symbol that was breaking linking
3150
3151         * WebCore.exp:
3152
3153 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3154
3155         Reviewed by Mitz.
3156
3157         - fixed "REGRESSION: Activity window doesn't always list all files until refresh"
3158         http://bugs.webkit.org/show_bug.cgi?id=11212
3159
3160         I couldn't figure out how to write a test case.
3161
3162         * bindings/js/kjs_window.cpp:
3163         (KJS::Window::clear): Avoid crashing if already detached.
3164         * bridge/mac/FrameMac.h:
3165         * bridge/mac/FrameMac.mm:
3166         (WebCore::FrameMac::clear): Change prototype to make this a proper
3167         overload for Frame::clear once again(!).
3168
3169 2006-10-24  Darin Adler  <darin@apple.com>
3170
3171         Reviewed by Anders.
3172
3173         - converted WebFrameLoaderClient to C++
3174         - renamed frame->frameLoader() function to frame->loader()
3175         - renamed [bridge impl] to [bridge _frame]
3176         - removed some bridge methods
3177
3178         * WebCore.exp: Added more exports.
3179         * WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal
3180         so it can be used in WebKit.
3181
3182         * bridge/mac/BrowserExtensionMac.mm:
3183         (WebCore::BrowserExtensionMac::createNewWindow):
3184         * bridge/mac/FrameMac.mm:
3185         (WebCore::FrameMac::createFrame):
3186         (WebCore::FrameMac::didFirstLayout):
3187         * bridge/mac/WebCoreAXObject.mm:
3188         (-[WebCoreAXObject rendererForView:]):
3189         * bridge/mac/WebCoreFrameBridge.h:
3190         * bridge/mac/WebCoreFrameBridge.mm:
3191         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]):
3192         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3193         (-[WebCoreFrameBridge setOpener:]):
3194         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
3195         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
3196         (-[WebCoreFrameBridge setTitle:]):
3197         (-[WebCoreFrameBridge originalRequestURL]):
3198         (-[WebCoreFrameBridge isLoadTypeReload]):
3199         (-[WebCoreFrameBridge frameDetached]):
3200         (-[WebCoreFrameBridge tokenizerProcessedData]):
3201         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3202         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
3203         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3204         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
3205         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3206         (-[WebCoreFrameBridge incomingReferrer]):
3207         (-[WebCoreFrameBridge isReloading]):
3208         (-[WebCoreFrameBridge handledOnloadEvents]):
3209         (-[WebCoreFrameBridge mainResourceURLResponse]):
3210         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
3211         (-[WebCoreFrameBridge _frame]):
3212         (-[WebCoreFrameBridge executionContextForView:]):
3213         * bridge/mac/WebCorePageBridge.mm:
3214         (-[WebCorePageBridge setMainFrame:]):
3215         * dom/Position.cpp:
3216         (WebCore::Position::upstream):
3217         * loader/mac/IconLoaderMac.mm:
3218         (IconLoader::notifyIconChanged):
3219         * loader/mac/WebDocumentLoader.mm:
3220         (WebCore::DocumentLoader::frameLoader):
3221         (WebCore::DocumentLoader::stopLoading):
3222         (WebCore::DocumentLoader::finishedLoading):
3223         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
3224         * loader/mac/WebFormState.mm:
3225         (WebCore::FormState::FormState):
3226         * loader/mac/WebFrameLoader.h:
3227         * loader/mac/WebFrameLoader.mm:
3228         (WebCore::FrameLoader::~FrameLoader):
3229         (WebCore::FrameLoader::prepareForLoadStart):
3230         (WebCore::FrameLoader::finalSetupForReplace):
3231         (WebCore::FrameLoader::safeLoad):
3232         (WebCore::FrameLoader::load):
3233         (WebCore::FrameLoader::startLoading):
3234         (WebCore::FrameLoader::stopLoadingSubframes):
3235         (WebCore::FrameLoader::stopLoading):
3236         (WebCore::FrameLoader::cancelPendingArchiveLoad):
3237         (WebCore::FrameLoader::defersCallbacksChanged):
3238         (WebCore::FrameLoader::setDefersCallbacks):
3239         (WebCore::FrameLoader::setDocumentLoader):
3240         (WebCore::FrameLoader::provisionalLoadStarted):
3241         (WebCore::FrameLoader::clearProvisionalLoad):
3242         (WebCore::FrameLoader::identifierForInitialRequest):
3243         (WebCore::FrameLoader::willSendRequest):
3244         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
3245         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
3246         (WebCore::FrameLoader::didReceiveResponse):
3247         (WebCore::FrameLoader::didReceiveData):
3248         (WebCore::FrameLoader::didFinishLoad):
3249         (WebCore::FrameLoader::didFailToLoad):
3250         (WebCore::FrameLoader::privateBrowsingEnabled):
3251         (WebCore::FrameLoader::receivedMainResourceError):
3252         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
3253         (WebCore::FrameLoader::clientRedirected):
3254         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
3255         (WebCore::FrameLoader::closeOldDataSources):
3256         (WebCore::FrameLoader::opened):
3257         (WebCore::FrameLoader::commitProvisionalLoad):
3258         (WebCore::FrameLoader::download):
3259         (WebCore::FrameLoader::finishedLoading):
3260         (WebCore::FrameLoader::notifyIconChanged):
3261         (WebCore::FrameLoader::cancelledError):
3262         (WebCore::FrameLoader::fileDoesNotExistError):
3263         (WebCore::FrameLoader::willUseArchive):
3264         (WebCore::FrameLoader::isArchiveLoadPending):
3265         (WebCore::FrameLoader::handleUnimplementablePolicy):
3266         (WebCore::FrameLoader::cannotShowMIMEType):
3267         (WebCore::FrameLoader::interruptionForPolicyChangeError):
3268         (WebCore::FrameLoader::canShowMIMEType):
3269         (WebCore::FrameLoader::representationExistsForURLScheme):
3270         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
3271         (WebCore::FrameLoader::checkContentPolicy):
3272         (WebCore::FrameLoader::reloadAllowingStaleData):
3273         (WebCore::FrameLoader::reload):
3274         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
3275         (WebCore::FrameLoader::finishedLoadingDocument):
3276         (WebCore::FrameLoader::committedLoad):
3277         (WebCore::FrameLoader::revertToProvisional):
3278         (WebCore::FrameLoader::setMainDocumentError):
3279         (WebCore::FrameLoader::mainReceivedCompleteError):
3280         (WebCore::FrameLoader::subframeIsLoading):
3281         (WebCore::FrameLoader::willChangeTitle):
3282         (WebCore::FrameLoader::didChangeTitle):
3283         (WebCore::FrameLoader::checkNewWindowPolicy):
3284         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3285         (WebCore::FrameLoader::checkNavigationPolicy):
3286         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3287         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
3288         (WebCore::FrameLoader::didFirstLayout):
3289         (WebCore::FrameLoader::frameLoadCompleted):
3290         (WebCore::FrameLoader::transitionToCommitted):
3291         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3292         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3293         (WebCore::FrameLoader::sendRemainingDelegateMessages):
3294         (WebCore::FrameLoader::requestFromDelegate):
3295         (WebCore::FrameLoader::post):
3296         (WebCore::FrameLoader::detachChildren):
3297         (WebCore::FrameLoader::detachFromParent):
3298         (WebCore::FrameLoader::addExtraFieldsToRequest):
3299         (WebCore::FrameLoader::actionInformation):
3300         (WebCore::FrameLoader::checkLoadComplete):
3301         (WebCore::FrameLoader::setClient):
3302         (WebCore::FrameLoader::client):
3303         (WebCore::FrameLoaderClient::~FrameLoaderClient):
3304         * loader/mac/WebFrameLoaderClient.h:
3305         * loader/mac/WebLoader.mm:
3306         (WebCore::WebResourceLoader::frameLoader):
3307         * loader/mac/WebSubresourceLoader.mm:
3308         (-[WebCoreSubresourceHandle initWithLoader:]):
3309         * page/Frame.cpp:
3310         (WebCore::Frame::loader):
3311         * page/Frame.h:
3312         * platform/mac/SliderMac.mm:
3313         (Slider::focusPolicy):
3314
3315 2006-10-24  Darin Adler  <darin@apple.com>
3316
3317         Rubber stamped by Anders.
3318
3319         - get rid of the assertion firing while running the layout tests
3320
3321         This does not fix the real problem, which is that we need to map offsets within
3322         possibly-text-transformed text in the render tree to DOM tree offsets and vice
3323         versa -- but it gets the tests running again.
3324
3325         * dom/Position.cpp: (WebCore::Position::upstream): Commented out the assertion.
3326
3327 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
3328
3329         Reviewed by Oliver.
3330
3331         - more ResourceLoader cleanup
3332             - moved HTTPHeaderMap out of ResourceRequest class, so ResourceResponse will be able to use it too
3333             - took out attempts to suppress setting of "HEAD" and "GET" methods, since underlying bugs are now fixed
3334
3335         * loader/LoaderFunctions.h:
3336         * loader/mac/LoaderFunctionsMac.mm:
3337         (WebCore::ServeSynchronousRequest):
3338         * loader/mac/WebSubresourceLoader.mm:
3339         (-[WebCoreSubresourceHandle initWithLoader:]):
3340         * platform/network/HTTPHeaderMap.h: Added.
3341         * platform/network/ResourceLoader.cpp:
3342         (WebCore::ResourceLoader::requestHeaders):
3343         * platform/network/ResourceLoader.h:
3344         * platform/network/ResourceRequest.h:
3345         * platform/network/cf/ResourceLoaderCFNet.cpp:
3346         (WebCore::addHeadersFromHashMap):
3347         * xml/xmlhttprequest.cpp:
3348         (WebCore::XMLHttpRequest::send):
3349         * xml/xmlhttprequest.h:
3350
3351 2006-10-24  Justin Garcia  <justin.garcia@apple.com>
3352
3353         Reviewed by darin
3354
3355         <http://bugs.webkit.org/show_bug.cgi?id=10993>
3356         GMail Editor: Caret doesn't always position itself after list marker
3357
3358         List creation uses moveParagraphs to push content into list items.
3359         moveParagraphs uses a TextIterator to restore selections after moves.
3360         Some characters emitted by the TextIterator had bad ranges associated
3361         with them.  rangeFromLocationAndLength would skip past the range it
3362         should have used when asked for ranges of length 0.
3363
3364         * editing/TextIterator.cpp:
3365         (WebCore::TextIterator::TextIterator): No longer need to initialize a
3366         removed member variable.
3367         (WebCore::TextIterator::advance): An extra newline is emitted when leaving
3368         some blocks.  Use the same range for this newline as for the first newline.
3369         We should remove this code and just emit two '\n's.
3370         (WebCore::TextIterator::handleTextNode): Setup m_range.
3371         (WebCore::TextIterator::handleTextBox): Ditto.
3372         (WebCore::TextIterator::handleReplacedElement): Ditto.
3373         (WebCore::TextIterator::handleNonTextNode): Ditto.
3374         (WebCore::TextIterator::exitNode): Use an m_range from the last VisiblePosition
3375         in the block we're leaving to that VP after that one.
3376         (WebCore::TextIterator::emitCharacter): This function now takes in the start
3377         and the end of the range associated with the emited character, and sets up m_range.
3378         (WebCore::TextIterator::range): Return m_range.  If it is null (we are atEnd),
3379         return the end of the range used to create the iterator, as a convenience to
3380         callers that use call range() on an iterator that is atEnd.
3381         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
3382         Same as the changes made to TextIterator's constructor.
3383         (WebCore::SimplifiedBackwardsTextIterator::advance): Use a null m_range instead of
3384         a null m_positionNode to signal that we're finished.
3385         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
3386         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Similar to changes
3387         made to TextIterator.
3388         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto.
3389         (WebCore::SimplifiedBackwardsTextIterator::emitNewline): Simplified.
3390         (WebCore::SimplifiedBackwardsTextIterator::range): Similar to the changes made to
3391         TextIterator::range.
3392         (WebCore::CharacterIterator::range): This function assumed that an iterator's
3393         range() was safe to modify.
3394         (WebCore::TextIterator::rangeFromLocationAndLength):
3395         If the range we're looking for starts in the current chunk, this function assumed
3396         that if the chunk started in a text node, it would end in the same text node.  This
3397         is no longer the case.
3398         If the range we're looking for starts in the middle of the current chunk, I assume
3399         that the chunk is inside a text node, because those are the only chunks with length
3400         greater than one at the moment.
3401         If the range we're looking for is a zero length range that starts/ends at the end of the
3402         current chunk, we used to return the start of the next chunk, but that's wrong and
3403         is what caused this bug.
3404         * editing/TextIterator.h:
3405         (WebCore::TextIterator::atEnd): The iterator is atEnd when m_range is null.
3406         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
3407         * editing/visible_units.cpp:
3408         (WebCore::previousBoundary): Cleaned up by using a convenience function.
3409         (WebCore::nextBoundary): Ditto.
3410
3411 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3412
3413         Reviewed by Maciej.
3414
3415         * platform/network/mac/ResourceLoaderMac.mm:
3416         (WebCore::ResourceLoader::start):
3417         Don't retain the header dictionary.
3418
3419 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
3420
3421         Reviewed by Anders.
3422
3423         Fixed http://bugs.webkit.org/show_bug.cgi?id=11404
3424         REGRESSION: Reproducible assertion failure in Shared<WebCore::StringImpl>::ref()
3425         running svg/custom/svg/custom/gradient-attr-update.svg
3426
3427         SVGRenderStyle wasn't ref-ing the shared objects it held onto. Oops.
3428
3429         * ksvg2/css/SVGRenderStyle.h:
3430         * ksvg2/css/SVGRenderStyleDefs.h:
3431
3432 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3433
3434         Reviewed by Mitz.
3435
3436         * platform/network/ResourceRequest.h:
3437         (WebCore::ResourceRequest::ResourceRequest):
3438         Set the http method to "GET" in the constructor that takes a String.
3439
3440 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
3441
3442         Reviewed by Tim H.
3443
3444         Move kcanvas/Render* and kcanvas/SVG* to rendering/Render*
3445         and rendering/SVG* respectively.  Fix Xcode project and
3446         CMakeLists.txt to account for the moves.
3447
3448         * CMakeLists.txt:
3449         * WebCore.xcodeproj/project.pbxproj:
3450         * kcanvas/RenderForeignObject.cpp: Removed.
3451         * kcanvas/RenderForeignObject.h: Removed.
3452         * kcanvas/RenderPath.cpp: Removed.
3453         * kcanvas/RenderPath.h: Removed.
3454         * kcanvas/RenderSVGContainer.cpp: Removed.
3455         * kcanvas/RenderSVGContainer.h: Removed.
3456         * kcanvas/RenderSVGImage.cpp: Removed.
3457         * kcanvas/RenderSVGImage.h: Removed.
3458         * kcanvas/RenderSVGInline.cpp: Removed.
3459         * kcanvas/RenderSVGInline.h: Removed.
3460         * kcanvas/RenderSVGInlineText.cpp: Removed.
3461         * kcanvas/RenderSVGInlineText.h: Removed.
3462         * kcanvas/RenderSVGTSpan.cpp: Removed.
3463         * kcanvas/RenderSVGTSpan.h: Removed.
3464         * kcanvas/RenderSVGText.cpp: Removed.
3465         * kcanvas/RenderSVGText.h: Removed.
3466         * kcanvas/SVGInlineFlowBox.cpp: Removed.
3467         * kcanvas/SVGInlineFlowBox.h: Removed.
3468         * kcanvas/SVGRootInlineBox.cpp: Removed.
3469         * kcanvas/SVGRootInlineBox.h: Removed.
3470
3471 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
3472
3473         Rolling back in, now fixed:
3474
3475         Nixed a few more redundant loading functions in Frame. Did my best to update
3476         the non-Mac builds.
3477
3478         * bridge/mac/FrameMac.h:
3479         * bridge/mac/FrameMac.mm:
3480         (WebCore::FrameMac::urlSelected): Kept always 'true' argument for userGesture
3481         always 'true', because changing it broke the world, and testing seems to
3482         indicate that the one caller that might have passed 'false' didn't need to.
3483         * page/Frame.cpp:
3484         (WebCore::Frame::requestFrame):
3485         (WebCore::Frame::frameLoader):
3486         (WebCore::Frame::redirectionTimerFired):
3487         * page/Frame.h:
3488         * platform/gdk/FrameGdk.cpp:
3489         * platform/gdk/FrameGdk.h:
3490         * platform/gdk/TemporaryLinkStubs.cpp:
3491         (FrameGdk::issueCopyCommand):
3492         * platform/qt/FrameQt.cpp:
3493         * platform/qt/FrameQt.h:
3494         * platform/win/TemporaryLinkStubs.cpp:
3495         (WebCore::FrameWin::shouldInterruptJavaScript):
3496         (WebCore::FrameWin::issueCopyCommand):
3497
3498 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3499
3500         Fix the build (Update for changes to ResourceLoader)
3501
3502         * platform/network/cf/ResourceLoaderCFNet.cpp:
3503         (WebCore::addHeadersFromHashMap):
3504         (WebCore::ResourceLoader::start):
3505         (WebCore::ResourceLoader::cancel):
3506
3507 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
3508
3509         Reviewed by Mitz.
3510
3511         Change #includes using <kcanvas/*.h> to use "*.h" instead
3512         to prepare for moving the kcanvas files.
3513
3514         * kcanvas/RenderSVGContainer.h:
3515         * ksvg2/svg/SVGAElement.cpp:
3516         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3517         * ksvg2/svg/SVGFETileElement.cpp:
3518         * ksvg2/svg/SVGStyledLocatableElement.cpp:
3519         * ksvg2/svg/SVGStyledTransformableElement.cpp:
3520
3521 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
3522
3523         Reviewed by Darin.
3524
3525         - More movement towards the final network API.
3526
3527         Changed ResourceLoader::create to take a ResurceRequest and start
3528         the load. Removed methods relating to setting request
3529         headers. Removed methods relating to metaData. Added some more
3530         convenience methods to ResourceRequest.