962ba8ea5e76bb9ce48ffe48d1e62937803ea688
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-02  Chris Marrin  <cmarrin@apple.com>
2
3         Reviewed by Oliver Hunt.
4
5         Exception checks were being too aggressive
6         https://bugs.webkit.org/show_bug.cgi?id=31005
7
8         Several calls in CanvasRenderingContext3D are allowed to
9         have a null value passed, which indicated that the 
10         object is being unbound. Handle this case and the corresponding
11         null handling in GraphicsContext3DMac.
12
13         * html/canvas/CanvasRenderingContext3D.cpp:
14         (WebCore::CanvasRenderingContext3D::bindBuffer):
15         (WebCore::CanvasRenderingContext3D::bindFramebuffer):
16         (WebCore::CanvasRenderingContext3D::bindRenderbuffer):
17         (WebCore::CanvasRenderingContext3D::bindTexture):
18         (WebCore::CanvasRenderingContext3D::framebufferRenderbuffer):
19         (WebCore::CanvasRenderingContext3D::framebufferTexture2D):
20         * platform/graphics/mac/GraphicsContext3DMac.cpp:
21         (WebCore::GraphicsContext3D::framebufferRenderbuffer):
22         (WebCore::GraphicsContext3D::framebufferTexture2D):
23
24 2009-11-02  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
25
26         Reviewed by Timothy Hatcher.
27
28         Each JS execution in console adds extra item into "scripts" combo
29         https://bugs.webkit.org/show_bug.cgi?id=30212
30
31         Added manual test
32
33         * inspector/front-end/ScriptsPanel.js:
34         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
35         * manual-tests/inspector/hidden-evals.html: Added.
36
37 2009-11-02  Kelly Norton  <knorton@google.com>
38
39         Reviewed by Timothy Hatcher.
40
41         Adds a missed case for InspectorTimeline, DOMWindow dispatch of DOM events.
42         https://bugs.webkit.org/show_bug.cgi?id=31030
43
44         * dom/Node.cpp:
45         (WebCore::eventHasListeners): Checks DOMWindow for listeners.
46         (WebCore::Node::dispatchGenericEvent):
47
48 2009-11-02  Dmitry Titov  <dimich@chromium.org>
49
50         Reviewed by David Levin.
51
52         Remove threadsafe refcounting from tasks used with WTF::MessageQueue.
53         https://bugs.webkit.org/show_bug.cgi?id=30612
54
55         No new tests since no new functionality. Storage, MessagePorts and Workers tests cover this.
56
57         There are a lot of files but most changes are simply replace RefPtr and PassRefPtr with
58         OwnPtr and PassOwnPtr when dealing with Tasks.
59
60         ScriptExecutionContext::Task, DatabaseTask and WorkerRunLoop::Task are no longer
61         threadsafe refcounted, but simply Noncopyable.
62
63         * dom/Document.cpp:
64         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
65         (WebCore::PerformTaskContext::PerformTaskContext):
66         (WebCore::Document::postTask):
67         * dom/Document.h:
68         * dom/ScriptExecutionContext.cpp:
69         (WebCore::ProcessMessagesSoonTask::create):
70         * dom/ScriptExecutionContext.h:
71         * dom/default/PlatformMessagePortChannel.cpp:
72         (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
73         * dom/default/PlatformMessagePortChannel.h:
74         (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
75         (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
76         * loader/FrameLoader.cpp:
77         (WebCore::HashChangeEventTask::create):
78         * loader/appcache/ApplicationCacheGroup.cpp:
79         (WebCore::CallCacheListenerTask::create):
80         * storage/Database.cpp:
81         (WebCore::Database::openAndVerifyVersion):
82         (WebCore::Database::markAsDeletedAndClose):
83         (WebCore::Database::scheduleTransaction):
84         (WebCore::Database::scheduleTransactionStep):
85         (WebCore::Database::tableNames):
86         * storage/DatabaseTask.h:
87         (WebCore::DatabaseOpenTask::create):
88         (WebCore::DatabaseCloseTask::create):
89         (WebCore::DatabaseTransactionTask::create):
90         (WebCore::DatabaseTableNamesTask::create):
91         * storage/DatabaseThread.cpp:
92         (WebCore::DatabaseThread::databaseThread):
93         (WebCore::DatabaseThread::scheduleTask):
94         (WebCore::DatabaseThread::scheduleImmediateTask):
95         (WebCore::SameDatabasePredicate::operator()):
96         * storage/DatabaseThread.h:
97         * storage/LocalStorageTask.h:
98         (WebCore::LocalStorageTask::createImport):
99         (WebCore::LocalStorageTask::createSync):
100         (WebCore::LocalStorageTask::createTerminate):
101         * storage/LocalStorageThread.cpp:
102         (WebCore::LocalStorageThread::localStorageThread):
103         * storage/LocalStorageThread.h:
104         * websockets/WebSocket.cpp:
105         (WebCore::ProcessWebSocketEventTask::create):
106         * workers/DefaultSharedWorkerRepository.cpp:
107         (WebCore::SharedWorkerProxy::postTaskToLoader):
108         (WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
109         (WebCore::SharedWorkerConnectTask::create):
110         * workers/GenericWorkerTask.h:
111         (WebCore::GenericWorkerTask1::create):
112         (WebCore::GenericWorkerTask2::create):
113         (WebCore::GenericWorkerTask3::create):
114         (WebCore::GenericWorkerTask4::create):
115         (WebCore::GenericWorkerTask5::create):
116         (WebCore::GenericWorkerTask6::create):
117         (WebCore::GenericWorkerTask7::create):
118         (WebCore::GenericWorkerTask8::create):
119         (WebCore::createCallbackTask):
120         * workers/WorkerContext.cpp:
121         (WebCore::WorkerContext::postTask):
122         * workers/WorkerContext.h:
123         * workers/WorkerLoaderProxy.h:
124         * workers/WorkerMessagingProxy.cpp:
125         (WebCore::MessageWorkerContextTask::create):
126         (WebCore::MessageWorkerTask::create):
127         (WebCore::WorkerExceptionTask::create):
128         (WebCore::WorkerContextDestroyedTask::create):
129         (WebCore::WorkerTerminateTask::create):
130         (WebCore::WorkerThreadActivityReportTask::create):
131         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
132         (WebCore::WorkerMessagingProxy::postTaskToLoader):
133         (WebCore::WorkerMessagingProxy::workerThreadCreated):
134         * workers/WorkerMessagingProxy.h:
135         * workers/WorkerRunLoop.cpp:
136         (WebCore::ModePredicate::operator()):
137         (WebCore::WorkerRunLoop::runInMode):
138         (WebCore::WorkerRunLoop::postTask):
139         (WebCore::WorkerRunLoop::postTaskForMode):
140         (WebCore::WorkerRunLoop::Task::create):
141         (WebCore::WorkerRunLoop::Task::performTask):
142         (WebCore::WorkerRunLoop::Task::Task):
143         * workers/WorkerRunLoop.h:
144         (WebCore::WorkerRunLoop::Task::~Task):
145         (WebCore::WorkerRunLoop::Task::mode):
146
147 2009-11-02  Philippe Normand  <pnormand@igalia.com>
148
149         Reviewed by Jan Alonzo.
150
151         [GTK] Failing media/video-played-reset.html
152         https://bugs.webkit.org/show_bug.cgi?id=30589
153
154         new m_seekTime attribute to keep track of the seek position
155
156         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
157         (WebCore::MediaPlayerPrivate::currentTime):
158         (WebCore::MediaPlayerPrivate::seek):
159         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
160
161 2009-11-02  Xan Lopez  <xlopez@igalia.com>
162
163         Reviewed by Jan Alonzo.
164
165         [GTK] Remove Referer when redirecting to non-secure site
166         https://bugs.webkit.org/show_bug.cgi?id=31021
167
168         Remove referer from HTTP headers when redirecting to a non-secure
169         site.
170
171         * platform/network/soup/ResourceHandleSoup.cpp:
172         (WebCore::restartedCallback):
173
174 2009-11-02  Alexey Proskuryakov  <ap@apple.com>
175
176         Reviewed by Dan Bernstein.
177
178         https://bugs.webkit.org/show_bug.cgi?id=18539
179         multipart/form-data not being parsed correctly on server due to '+' in boundary string
180
181         No test - the characters that the boundary is made of are not deterministic.
182
183         * platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString):
184         Don't ever put a '+' in boundary string, either. Removed a FIXME to bring '/' back once
185         GMail is fixed - I don't think we'll ever want to allow non-alphanumeric characters, as
186         they cause problems on many web sites.
187
188 2009-10-30  Alexey Proskuryakov  <ap@apple.com>
189
190         Reviewed by Darin Adler.
191
192         https://bugs.webkit.org/show_bug.cgi?id=30969
193         A no-prefix XPath node test should not match no-namespace elements in HTML document
194
195         Test: fast/xpath/null-namespace-in-html.html
196
197         * xml/XPathStep.cpp: (WebCore::XPath::nodeMatchesBasicTest): Special case non-HTML elements
198         in HTML documents (as these are the ones that can have null namespace).
199
200 2009-11-02  Pavel Feldman  <pfeldman@chromium.org>
201
202         Reviewed by Timothy Hatcher.
203
204         Web Inspector: [REGRESSION] No timeline marks on resources panel.
205
206         https://bugs.webkit.org/show_bug.cgi?id=31013
207
208         * inspector/front-end/AbstractTimelinePanel.js:
209         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
210
211 2009-11-02  David Levin  <levin@chromium.org>
212
213         Reviewed by Dan Bernstein.
214
215         Possible crash in RenderSlider::layout.
216         https://bugs.webkit.org/show_bug.cgi?id=31016
217
218         Fix out of place line of code.
219
220         Test: scrollbars/overflow-scrollbar-combinations.html
221         This crash only seems to repro when WebKit draws the play controls,
222         so the crash repros in chromium running this test but not WebKit
223         nightlies which use QuickTime to draw the controls.
224
225         * rendering/RenderSlider.cpp:
226         (WebCore::RenderSlider::layout):
227
228 2009-11-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
229
230         Reviewed by Tor Arne Vestbø.
231
232         [Qt] Fix Qt build on Windows.
233         https://bugs.webkit.org/show_bug.cgi?id=30905
234
235         * WebCore.pro:
236         * platform/graphics/BitmapImage.h:
237         * platform/graphics/qt/ImageQt.cpp:
238         (WebCore::BitmapImage::BitmapImage):
239         (WebCore::BitmapImage::create):
240
241 2009-11-02  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
242
243         Reviewed by Adam Barth.
244
245         QWebView crash fix.
246
247         The QWebView should not crash if the stop() method is called from
248         a function triggered by the loadProgress signal.
249
250         A null pointer protection was added in the ProgressTracker::incrementProgress.
251
252         New autotest was created.
253
254         https://bugs.webkit.org/show_bug.cgi?id=29425
255
256         * loader/ProgressTracker.cpp:
257         (WebCore::ProgressTracker::incrementProgress):
258
259 2009-11-02  Mikhail Naganov  <mnaganov@chromium.org>
260
261         Reviewed by Pavel Feldman.
262
263         Fix a leftover from profiles panel generalization.
264
265         https://bugs.webkit.org/show_bug.cgi?id=31010
266
267         * inspector/front-end/ProfilesPanel.js:
268         (WebInspector.ProfilesPanel.prototype.get searchableViews):
269
270 2009-11-02  Kai Koehne  <kai.koehne@nokia.com>
271
272         Reviewed by Holger Freyther.
273
274         Remove implementation of ImageDecocerQt::clearFrameBufferCache.
275         The implementation was buggy, and will visually break repeating
276         animations anyway.
277
278         https://bugs.webkit.org/show_bug.cgi?id=31009
279
280         * platform/graphics/qt/ImageDecoderQt.cpp:
281         (WebCore::ImageDecoderQt::clearFrameBufferCache):
282
283 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
284
285         Reviewed by Jan Alonzo.
286
287         https://bugs.webkit.org/show_bug.cgi?id=30964
288         [Gtk] Implemment AtkDocument
289
290         Provides access to the reported content language.
291
292         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
293         (webkit_accessible_document_get_locale):
294
295 2009-11-02  Keishi Hattori  <casey.hattori@gmail.com>
296
297         Reviewed by Timothy Hatcher.
298
299         Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
300         https://bugs.webkit.org/show_bug.cgi?id=30907
301
302         Test: inspector/css-syntax-highlight.html
303
304         * inspector/front-end/ElementsTreeOutline.js:
305         * inspector/front-end/SourceFrame.js:
306         (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
307         (WebInspector.SourceSyntaxHighlighter):
308         (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk):
309         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine):
310         (WebInspector.SourceSyntaxHighlighter.prototype.process):
311         (WebInspector.SourceSyntaxHighlighter.prototype.lex):
312         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
313         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
314         (WebInspector.CSSSourceSyntaxHighlighter):
315         * inspector/front-end/inspectorSyntaxHighlight.css:
316
317 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
318
319         Reviewed by Beth Dakin.
320
321         Support ARIA "tab" roles
322         https://bugs.webkit.org/show_bug.cgi?id=30842
323
324         Implement support for ARIA "tab", "tabpanel" and "tablist".
325         As a consequence, we also needed to implement aria-selected
326         and aria-controls.
327
328         Tests: accessibility/aria-controls-with-tabs.html
329                accessibility/aria-tab-roles.html
330
331         * accessibility/AXObjectCache.cpp:
332         * accessibility/AccessibilityObject.h:
333         * accessibility/AccessibilityRenderObject.cpp:
334         * accessibility/AccessibilityRenderObject.h:
335         * accessibility/mac/AccessibilityObjectWrapper.mm:
336         * html/HTMLAttributeNames.in:
337
338 2009-10-27  Stephen White  <senorblanco@chromium.org>
339
340         Reviewed by Dmitry Titov.
341
342         This is the WebKit-side change needed to fix canvas.getImageData() for
343         Chromium.  The unpremultiply code in Skia assumes that unpremultiplied
344         values should be rounded, while CG does not.  In addition, the fixed
345         point inversion used by Skia introduces slight inaccuracies that make
346         us fail this test.  This change brings Chromium in line with
347         the CG path.
348         https://bugs.webkit.org/show_bug.cgi?id=30825
349
350         Covered by LayoutTests/fast/canvas/canvas-getImageData.html
351
352         * platform/graphics/skia/ImageBufferSkia.cpp:
353         (WebCore::getImageData):
354
355 2009-11-01  Kelly Norton  <knorton@google.com>
356
357         Reviewed by Timothy Hatcher.
358
359         Adds window event dispatches to InspectorTimelineAgent.
360         https://bugs.webkit.org/show_bug.cgi?id=31002
361
362         * English.lproj/localizedStrings.js:
363         * dom/Node.cpp: Updated call site to willDispatchEvent and didDispatchEvent.
364         (WebCore::Node::dispatchGenericEvent):
365         * inspector/InspectorTimelineAgent.cpp:
366         (WebCore::InspectorTimelineAgent::willDispatchEvent): Renamed.
367         (WebCore::InspectorTimelineAgent::didDispatchEvent): Renamed.
368         * inspector/InspectorTimelineAgent.h:
369         (WebCore::):
370         * inspector/TimelineRecordFactory.cpp:
371         (WebCore::TimelineRecordFactory::createEventDispatchRecord): Renamed.
372         * inspector/TimelineRecordFactory.h:
373         * inspector/front-end/TimelineAgent.js:
374         * inspector/front-end/TimelinePanel.js:
375         (WebInspector.TimelinePanel.prototype._formatRecord):
376         (WebInspector.TimelinePanel.prototype._getRecordDetails):
377         * page/DOMWindow.cpp:
378         (WebCore::DOMWindow::dispatchEvent):
379
380 2009-11-01  Pavel Feldman  <pfeldman@chromium.org>
381
382         Reviewed by Timothy Hatcher.
383
384         Web Inspector: Convert script tag event into a more generic
385         script eval event in timeline.
386
387         https://bugs.webkit.org/show_bug.cgi?id=30999
388
389         * bindings/js/ScriptController.cpp:
390         (WebCore::ScriptController::evaluateInWorld):
391         * bindings/v8/V8Proxy.cpp:
392         (WebCore::V8Proxy::evaluate):
393         * html/HTMLTokenizer.cpp:
394         (WebCore::HTMLTokenizer::scriptExecution):
395         * inspector/InspectorTimelineAgent.cpp:
396         (WebCore::InspectorTimelineAgent::willEvaluateScript):
397         (WebCore::InspectorTimelineAgent::didEvaluateScript):
398         * inspector/InspectorTimelineAgent.h:
399         (WebCore::):
400         * inspector/TimelineRecordFactory.cpp:
401         (WebCore::TimelineRecordFactory::createEvaluateScriptTimelineRecord):
402         * inspector/TimelineRecordFactory.h:
403         * inspector/front-end/TimelineAgent.js:
404         * inspector/front-end/TimelinePanel.js:
405         (WebInspector.TimelinePanel.prototype._formatRecord):
406         (WebInspector.TimelinePanel.prototype._getRecordDetails):
407
408 2009-11-01  Brian Weinstein  <bweinstein@apple.com>
409
410         Rubber-stamped by Mark Rowe.
411
412         Fix for loop to use an size_t instead of unsigned and some spacing
413         style fixes.
414
415         * dom/Node.cpp:
416         (WebCore::eventHasListeners):
417
418 2009-11-01  Kelly Norton  <knorton@google.com>
419
420         Reviewed by Timothy Hatcher.
421
422         Does not send DOM dispatches to the InspectorTimelineAgent if there
423         are no event listeners.
424         https://bugs.webkit.org/show_bug.cgi?id=30995
425
426         * dom/Node.cpp:
427         (WebCore::eventHasListeners):
428         (WebCore::Node::dispatchGenericEvent):
429         * xml/XMLHttpRequest.cpp:
430         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
431
432 2009-11-01  Roland Steiner  <rolandsteiner@chromium.org>
433
434         No review (build fix).
435
436         Add missing files for Ruby implementation to WebCore.vcproj
437         (Fix build break after 50397)
438         https://bugs.webkit.org/show_bug.cgi?id=31001
439
440         No new tests. (No functional change)
441
442         * WebCore.vcproj/WebCore.vcproj:
443
444 2009-11-02  Roland Steiner  <rolandsteiner@chromium.org>
445
446         Reviewed by Dave Hyatt.
447
448         Bug 28420 -  Implement HTML5 <ruby> rendering
449         (https://bugs.webkit.org/show_bug.cgi?id=28420)
450
451         First rudimentary implementation of HTML5 ruby rendering support.
452
453         Following the HTML 5 spec, the box object model for a <ruby> element allows several runs of ruby
454         bases with their respective ruby texts looks as follows:
455
456         1 RenderRuby object, corresponding to the whole <ruby> HTML element
457              1+ RenderRubyRun (anonymous)
458                  0 or 1 RenderRubyText - shuffled to the front in order to re-use existing block layouting
459                      0-n inline object(s)
460                  0 or 1 RenderRubyBase - contains the inline objects that make up the ruby base
461                      1-n inline object(s)
462
463         Note: <rp> elements are defined as having 'display:none' and thus normally are not assigned a renderer.
464         
465         New layout tests will be committed in a follow-up patch under fast/ruby.
466
467         Makefiles, etc.
468         * GNUmakefile.am:
469         * WebCore.gypi:
470         * WebCore.pro:
471         * WebCore.xcodeproj/project.pbxproj:
472
473         CSS
474         * css/html.css: Added <ruby> and <rt>
475
476         Existing render files:
477         * rendering/RenderBlock.cpp: make moveChild a member function moveChildTo
478         (WebCore::RenderBlock::moveChildTo):
479         (WebCore::RenderBlock::makeChildrenNonInline):
480         (WebCore::RenderBlock::removeChild):
481         * rendering/RenderBlock.h:
482         * rendering/RenderObject.cpp:
483         (WebCore::RenderObject::createObject): instantiate ruby renderers based on element name
484         * rendering/RenderObject.h: add query methods for ruby renderers
485         (WebCore::RenderObject::isRuby):
486         (WebCore::RenderObject::isRubyBase):
487         (WebCore::RenderObject::isRubyRun):
488         (WebCore::RenderObject::isRubyText):
489
490         New ruby renderers:
491         * rendering/RenderRuby.cpp: Added.
492         (WebCore::lastRubyRun):
493         (WebCore::findRubyRunParent):
494         (WebCore::RenderRubyAsInline::RenderRubyAsInline):
495         (WebCore::RenderRubyAsInline::~RenderRubyAsInline):
496         (WebCore::RenderRubyAsInline::isChildAllowed):
497         (WebCore::RenderRubyAsInline::addChild):
498         (WebCore::RenderRubyAsInline::removeChild):
499         (WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
500         (WebCore::RenderRubyAsBlock::~RenderRubyAsBlock):
501         (WebCore::RenderRubyAsBlock::isChildAllowed):
502         (WebCore::RenderRubyAsBlock::addChild):
503         (WebCore::RenderRubyAsBlock::removeChild):
504         * rendering/RenderRuby.h: Added.
505         (WebCore::RenderRubyAsInline::renderName):
506         (WebCore::RenderRubyAsInline::isRuby):
507         (WebCore::RenderRubyAsBlock::renderName):
508         (WebCore::RenderRubyAsBlock::isRuby):
509         * rendering/RenderRubyBase.cpp: Added.
510         (WebCore::RenderRubyBase::RenderRubyBase):
511         (WebCore::RenderRubyBase::~RenderRubyBase):
512         (WebCore::RenderRubyBase::isChildAllowed):
513         (WebCore::RenderRubyBase::splitToLeft):
514         (WebCore::RenderRubyBase::mergeWithRight):
515         * rendering/RenderRubyBase.h: Added.
516         (WebCore::RenderRubyBase::renderName):
517         (WebCore::RenderRubyBase::isRubyBase):
518         * rendering/RenderRubyRun.cpp: Added.
519         (WebCore::RenderRubyRun::RenderRubyRun):
520         (WebCore::RenderRubyRun::~RenderRubyRun):
521         (WebCore::RenderRubyRun::hasRubyText):
522         (WebCore::RenderRubyRun::hasRubyBase):
523         (WebCore::RenderRubyRun::isEmpty):
524         (WebCore::RenderRubyRun::rubyText):
525         (WebCore::RenderRubyRun::rubyBase):
526         (WebCore::RenderRubyRun::rubyBaseSafe):
527         (WebCore::RenderRubyRun::firstLineBlock):
528         (WebCore::RenderRubyRun::updateFirstLetter):
529         (WebCore::RenderRubyRun::isChildAllowed):
530         (WebCore::RenderRubyRun::addChild):
531         (WebCore::RenderRubyRun::removeChild):
532         (WebCore::RenderRubyRun::createRubyBase):
533         (WebCore::RenderRubyRun::staticCreateRubyRun):
534         * rendering/RenderRubyRun.h: Added.
535         (WebCore::RenderRubyRun::renderName):
536         (WebCore::RenderRubyRun::isRubyRun):
537         * rendering/RenderRubyText.cpp: Added.
538         (WebCore::RenderRubyText::RenderRubyText):
539         (WebCore::RenderRubyText::~RenderRubyText):
540         (WebCore::RenderRubyText::isChildAllowed):
541         * rendering/RenderRubyText.h: Added.
542         (WebCore::RenderRubyText::renderName):
543         (WebCore::RenderRubyText::isRubyText):
544
545 2009-11-01  Alexey Proskuryakov  <ap@apple.com>
546
547         Reviewed by Dan Bernstein.
548
549         https://bugs.webkit.org/show_bug.cgi?id=30992
550         Node.isDefaultNamespace doesn't convert empty strings to null
551
552         Test: fast/dom/Node/default-namespace-empty-argument.html
553
554         * dom/Node.cpp: (WebCore::Node::isDefaultNamespace): Per DOM 3 Core, treat empty input
555         as null.
556
557 2009-11-01  Yael Aharon  <yael.aharon@nokia.com>
558
559         Reviewed by Darin Adler.
560
561         Don't add '/' to the URL path if the it does not include '/' after the protocol component
562         https://bugs.webkit.org/show_bug.cgi?id=30971
563
564         Match IE8 behaviour, that does not add '/' if there is none after the protocol component.
565
566         * platform/KURL.cpp:
567         (WebCore::KURL::parse):
568
569 2009-10-31  Oliver Hunt  <oliver@apple.com>
570
571         Reviewed by Darin Adler.
572
573         Fix layering violations in GraphicsContext3D
574         https://bugs.webkit.org/show_bug.cgi?id=30986
575
576         Remove uses of HTMLImageElement and HTMLCanvasElement
577
578         * html/canvas/CanvasRenderingContext3D.cpp:
579         (WebCore::CanvasRenderingContext3D::texImage2D):
580         (WebCore::CanvasRenderingContext3D::texSubImage2D):
581         * platform/graphics/GraphicsContext3D.h:
582         * platform/graphics/mac/GraphicsContext3DMac.cpp:
583         (WebCore::GraphicsContext3D::texImage2D):
584         (WebCore::GraphicsContext3D::texSubImage2D):
585
586 2009-11-01  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
587
588         Reviewed by Jan Alonzo.
589
590         https://bugs.webkit.org/show_bug.cgi?id=30964
591         [Gtk] Implemment AtkDocument
592
593         Implements what has been implemented in AT-SPI.
594
595         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
596         (GetAtkInterfaceTypeFromWAIType):
597         (getInterfaceMaskFromObject):
598         (atk_document_interface_init):
599         (webkit_accessible_document_get_document_attribute_value):
600         (webkit_accessible_document_get_document_attributes):
601         (webkit_accessible_document_get_locale):
602
603 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
604
605         Reviewed by Eric Seidel.
606
607         Turn on warnings for QtWebKit for gcc
608         https://bugs.webkit.org/show_bug.cgi?id=30958
609
610         No new tests as there is no functional change.
611
612         * platform/image-decoders/qt/RGBA32BufferQt.cpp:
613         (WebCore::RGBA32Buffer::RGBA32Buffer): Reorder 
614         initialization list to fix compiler warnings.
615
616
617 2009-11-01  Keishi Hattori  <casey.hattori@gmail.com>
618
619         Reviewed by Pavel Feldman.
620
621         [Regression] monitorEvent doesn't work
622
623         * inspector/front-end/InjectedScript.js:
624         (InjectedScript._ensureCommandLineAPIInstalled):
625
626 2009-11-01  Keishi Hattori  <casey.hattori@gmail.com>
627
628         Reviewed by Pavel Feldman.
629
630         Fix Web Inspector: Bug with Message Bubble in Syntax Highlighter
631         https://bugs.webkit.org/show_bug.cgi?id=30990
632
633         * inspector/front-end/SourceFrame.js:
634
635 2009-10-31  Alexey Proskuryakov  <ap@apple.com>
636
637         Reviewed by John Sullivan.
638
639         https://bugs.webkit.org/show_bug.cgi?id=30982
640         createHTMLDocument doesn't escape ampersand and less-than in title
641
642         Test: fast/dom/DOMImplementation/createHTMLDocument-title.html
643
644         * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument):
645         Set document title after creating the document, avoiding parser intricacies.
646
647 2009-11-01  Keishi Hattori  <casey.hattori@gmail.com>
648
649         Reviewed by Timothy Hatcher.
650
651         Web Inspector: Double clicking on a breakpoints should not select text
652         https://bugs.webkit.org/show_bug.cgi?id=30950
653
654         * inspector/front-end/SourceFrame.js:
655         (WebInspector.SourceFrame.prototype._documentMouseDown):
656
657 2009-11-01  Yuta Kitamura  <yutak@chromium.org>
658
659         Reviewed by Darin Adler.
660
661         Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().
662
663         [Crash (debug)] Combination of list-item and :after causes assertion failure
664         https://bugs.webkit.org/show_bug.cgi?id=30944
665
666         Test: fast/css/list-item-pseudo-nocrash.html
667
668         * rendering/RenderObjectChildList.cpp:
669         (WebCore::RenderObjectChildList::updateBeforeAfterContent):
670
671 2009-11-01  Philippe Normand  <pnormand@igalia.com>
672
673         Reviewed by Eric Seidel.
674
675         https://bugs.webkit.org/show_bug.cgi?id=30586
676         [GTK] Failing test media/video-src-empty.html
677
678         Correctly set network/ready state depending on GStreamer errors
679         received on the bus.
680
681         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
682         (WebCore::mediaPlayerPrivateMessageCallback):
683
684 2009-10-31  Oliver Hunt  <oliver@apple.com>
685
686         Build fix
687
688         * platform/graphics/mac/GraphicsContext3DMac.cpp:
689         (WebCore::GraphicsContext3D::attachShader):
690
691 2009-10-31  Oliver Hunt  <oliver@apple.com>
692
693         Reviewed by Darin Adler.
694
695         Remove obsolete null checks from CanvasRenderingContext3DMac
696         https://bugs.webkit.org/show_bug.cgi?id=30983
697
698         * platform/graphics/mac/GraphicsContext3DMac.cpp:
699         (WebCore::GraphicsContext3D::attachShader):
700         (WebCore::GraphicsContext3D::bindAttribLocation):
701         (WebCore::GraphicsContext3D::compileShader):
702         (WebCore::GraphicsContext3D::detachShader):
703         (WebCore::GraphicsContext3D::framebufferRenderbuffer):
704         (WebCore::GraphicsContext3D::framebufferTexture2D):
705         (WebCore::GraphicsContext3D::linkProgram):
706         (WebCore::GraphicsContext3D::shaderSource):
707         (WebCore::GraphicsContext3D::useProgram):
708         (WebCore::GraphicsContext3D::validateProgram):
709         (WebCore::GraphicsContext3D::getProgramInfoLog):
710         (WebCore::GraphicsContext3D::getShaderi):
711         (WebCore::GraphicsContext3D::getShaderiv):
712         (WebCore::GraphicsContext3D::getShaderInfoLog):
713         (WebCore::GraphicsContext3D::getShaderSource):
714         (WebCore::GraphicsContext3D::getUniformLocation):
715
716 2009-10-31  Oliver Hunt  <oliver@apple.com>
717
718         Reviewed by Jon Honeycutt.
719
720         WebGL allows objects to be used with the wrong context
721         https://bugs.webkit.org/show_bug.cgi?id=30981
722
723         Simply add null checks and a few context guards to ensure we don't
724         deref null or attempt to use an object from a different context.
725
726         Tests: fast/canvas/webgl/incorrect-context-object-behaviour.html
727                fast/canvas/webgl/null-object-behaviour.html
728
729         * html/canvas/CanvasRenderingContext3D.cpp:
730         (WebCore::CanvasRenderingContext3D::attachShader):
731         (WebCore::CanvasRenderingContext3D::bindAttribLocation):
732         (WebCore::CanvasRenderingContext3D::bindBuffer):
733         (WebCore::CanvasRenderingContext3D::bindFramebuffer):
734         (WebCore::CanvasRenderingContext3D::bindRenderbuffer):
735         (WebCore::CanvasRenderingContext3D::bindTexture):
736         (WebCore::CanvasRenderingContext3D::compileShader):
737         (WebCore::CanvasRenderingContext3D::detachShader):
738         (WebCore::CanvasRenderingContext3D::framebufferRenderbuffer):
739         (WebCore::CanvasRenderingContext3D::framebufferTexture2D):
740         (WebCore::CanvasRenderingContext3D::getProgrami):
741         (WebCore::CanvasRenderingContext3D::getProgramiv):
742         (WebCore::CanvasRenderingContext3D::getProgramInfoLog):
743         (WebCore::CanvasRenderingContext3D::getShaderi):
744         (WebCore::CanvasRenderingContext3D::getShaderiv):
745         (WebCore::CanvasRenderingContext3D::getShaderInfoLog):
746         (WebCore::CanvasRenderingContext3D::getShaderSource):
747         (WebCore::CanvasRenderingContext3D::getUniformf):
748         (WebCore::CanvasRenderingContext3D::getUniformfv):
749         (WebCore::CanvasRenderingContext3D::getUniformi):
750         (WebCore::CanvasRenderingContext3D::getUniformiv):
751         (WebCore::CanvasRenderingContext3D::getUniformLocation):
752         (WebCore::CanvasRenderingContext3D::isBuffer):
753         (WebCore::CanvasRenderingContext3D::linkProgram):
754         (WebCore::CanvasRenderingContext3D::shaderSource):
755         * html/canvas/CanvasRenderingContext3D.h:
756         * html/canvas/CanvasRenderingContext3D.idl:
757
758 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
759
760         Reviewed by Darin Adler.
761
762         Allow custom memory allocation control for WebCore's MediaQueryResult
763         https://bugs.webkit.org/show_bug.cgi?id=30857
764
765         Inherits MediaQueryResult class from Noncopyable because it is
766         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:5984 and
767         it is no need to be copyable.
768
769         * css/CSSStyleSelector.h:
770
771 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
772
773         Reviewed by Darin Adler.
774
775         Allow custom memory allocation control for WebCore's MediaQueryEvaluator
776         https://bugs.webkit.org/show_bug.cgi?id=30854
777
778         Inherits MediaQueryEvaluator class from Noncopyable because it is
779         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and   
780         it is no need to be copyable.
781
782         * css/MediaQueryEvaluator.h:
783
784 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
785
786         Reviewed by Darin Adler.
787
788         Allow custom memory allocation control for WebCore's CSSRuleSet
789         https://bugs.webkit.org/show_bug.cgi?id=30852
790
791         Inherits CSSRuleSet class from Noncopyable because it is
792         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:455 and
793         it is no need to be copyable.
794
795         * css/CSSStyleSelector.cpp:
796
797 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
798
799         Reviewed by Darin Adler.
800
801         Allow custom memory allocation control for WebCore's CSSRuleData
802         https://bugs.webkit.org/show_bug.cgi?id=30851
803
804         Inherits CSSRuleData class from Noncopyable because it is
805         instantiated by 'new' in WebCore/css/CSSStyleSelector.h:320 and
806         it is no need to be copyable.
807
808         * css/CSSStyleSelector.h:
809
810 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
811
812         Reviewed by Darin Adler.
813
814         Allow custom memory allocation control for WebCore's CSSRuleDataList
815         https://bugs.webkit.org/show_bug.cgi?id=30850
816
817         Inherits CSSRuleDataList class from Noncopyable because it has been
818         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:2715 and
819         it is no need to be copyable.
820
821         * css/CSSStyleSelector.h:
822
823 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
824
825         Reviewed by Darin Adler.
826
827         Allow custom memory allocation control for WebCore's CSSNamespace
828         https://bugs.webkit.org/show_bug.cgi?id=30849
829
830         Inherits CSSNamespace struct from Noncopyable because it is
831         instantiated by 'new' in WebCore/css/CSSStyleSheet.cpp:141 and
832         it is no need to be copyable.
833
834         * css/CSSNamespace.h:
835
836 2009-10-30  Dmitry Titov  <dimich@chromium.org>
837
838         Reviewed by David Levin.
839
840         Refactor DatabaseTask in preparation for removing threadsafe refcounting from it.
841         Move the synchronizer object out of the DatabaseTask so there is no need to keep
842         the pointer to Databasetask around after passing it to MessageQueue.
843         Also pass the references to return parameters to the task so it can update them.
844         https://bugs.webkit.org/show_bug.cgi?id=30941
845
846         No new tests, since this is just moving the code around, no change in functionality.
847
848         * storage/Database.cpp:
849         (WebCore::Database::Database):
850         (WebCore::Database::openAndVerifyVersion): Use new DatabaseTaskSynchronizer to wait for task completion.
851         (WebCore::Database::markAsDeletedAndClose): Ditto.
852         (WebCore::Database::tableNames): Ditto.
853         (WebCore::Database::stop): Use the boolean flag rather then 'killed' flag built into MessageQueue.
854         (WebCore::Database::scheduleTransaction): Transaction queue is a Deque now, change the way to fetch the transaction.
855         * storage/Database.h: Change the SQLTransaction queue to be a Deque rather then a MessageQueue.
856         * storage/DatabaseTask.cpp:
857         (WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
858         (WebCore::DatabaseTaskSynchronizer::waitForTaskCompletion):
859         (WebCore::DatabaseTaskSynchronizer::taskCompleted):
860         (WebCore::DatabaseTask::DatabaseTask): Ctor takes DatabaseTaskSynchronizer which can be 0.
861         (WebCore::DatabaseTask::performTask): Signal completion. m_synchronizer should still be around since main thread is waiting on it.
862         (WebCore::DatabaseOpenTask::DatabaseOpenTask): Pass synchronizer and return parameters via constructor.
863         (WebCore::DatabaseCloseTask::DatabaseCloseTask): Ditto.
864         (WebCore::DatabaseTransactionTask::DatabaseTransactionTask): Ditto.
865         (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): Ditto.
866         * storage/DatabaseTask.h:
867         (WebCore::DatabaseOpenTask::create):
868         (WebCore::DatabaseCloseTask::create):
869         (WebCore::DatabaseTransactionTask::create):
870         (WebCore::DatabaseTableNamesTask::create):
871
872 2009-10-30  Enrica Casucci  <enrica@apple.com>
873
874         Reviewed by Darin Adler.
875
876         REGRESSION: In Mail, Undo does not restore some characters I have deleted at the end of a line
877         https://bugs.webkit.org/show_bug.cgi?id=30955
878         <rdar://problem/7067033>
879         
880         When the command is deleteWordBackward or deleteWordForward
881         we should not add to the open typing command, but
882         create a new one.
883         
884         Test: editing/undo/undo-deleteWord.html
885
886         * editing/TypingCommand.cpp:
887         (WebCore::TypingCommand::deleteKeyPressed): Always start a new command if the granularity is
888         not CharacterGranularity. 
889         (WebCore::TypingCommand::forwardDeleteKeyPressed): Always start a new command if the granularity is
890         not CharacterGranularity. 
891
892 2009-10-30  Eric Carlson  <eric.carlson@apple.com>
893
894         Reviewed by Darin Adler.
895
896         Make MediaPlayer constructor private
897         https://bugs.webkit.org/show_bug.cgi?id=30965
898
899         * html/HTMLMediaElement.cpp:
900         (WebCore::HTMLMediaElement::loadResource): 
901         (WebCore::HTMLMediaElement::finishParsingChildren): Use MediaPlayer::create.
902
903         * platform/graphics/MediaPlayer.h:
904         (WebCore::MediaPlayer::create): New.
905
906 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
907
908         MSAA: Accessibility of headings is not correct
909
910         https://bugs.webkit.org/show_bug.cgi?id=30937
911
912         Reviewed by Alice Liu.
913
914         * accessibility/AccessibilityObject.h:
915         (WebCore::AccessibilityObject::stringRoleForMSAA):
916         (WebCore::AccessibilityObject::descriptionForMSAA):
917
918         * accessibility/AccessibilityRenderObject.cpp:
919         (WebCore::shouldReturnTagNameAsRoleForMSAA):
920         If the element's tag name is one of h1, h2, h3, h4, h5, h6, return
921         true.
922         (WebCore::AccessibilityRenderObject::stringRoleForMSAA):
923         If the element should return its tag name as the role, return the tag
924         name.
925         (WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):
926         If the object is a heading, return the string "L" followed by the
927         heading level.
928         (WebCore::AccessibilityRenderObject::descriptionForMSAA):
929         If the object has a positional description, return it. Otherwise, get
930         the accessibility description, and prefix it with "Description" so that
931         MSAA clients know that it's not a positional description.
932
933         * accessibility/AccessibilityRenderObject.h:
934
935 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
936
937         MSAA: Accessibility of links is wrong
938
939         https://bugs.webkit.org/show_bug.cgi?id=30928
940
941         Reviewed by Darin Adler.
942
943         * accessibility/AccessibilityImageMapLink.cpp:
944         (WebCore::AccessibilityImageMapLink::stringValueForMSAA):
945         Return the URL.
946         (WebCore::AccessibilityImageMapLink::nameForMSAA):
947         Return the alt text.
948
949         * accessibility/AccessibilityImageMapLink.h:
950         (WebCore::AccessibilityImageMapLink::isLinked):
951         Return true.
952
953         * accessibility/AccessibilityObject.h:
954         (WebCore::AccessibilityObject::isLinked):
955         (WebCore::AccessibilityObject::stringValueForMSAA):
956         (WebCore::AccessibilityObject::nameForMSAA):
957
958         * accessibility/AccessibilityRenderObject.cpp:
959         (WebCore::isLinkable):
960         Return true if the element is considered "linkable" with respect to
961         accessibility.
962         (WebCore::AccessibilityRenderObject::stringValueForMSAA):
963         If the element is linkable, check whether it has a parent anchor
964         element. If so, return the anchor element's href.
965         (WebCore::AccessibilityRenderObject::isLinked):
966         Return true if the element is linkable and if it's parent anchor tag's
967         href is non-empty.
968         (WebCore::AccessibilityRenderObject::nameForMSAA):
969         For text nodes, return the text.
970
971         * accessibility/AccessibilityRenderObject.h:
972
973 2009-10-30  Evan Stade  <estade@chromium.org>
974
975         Reviewed by David Levin.
976
977         Notify the chrome when the focused node has changed.
978         https://bugs.webkit.org/show_bug.cgi?id=30832
979
980         This is similar to AX code that is already in place, except that this also informs the
981         chrome when there stops being a focused node. This is needed for a browser to show the
982         anchor for links that have keyboard focus.
983
984         * dom/Document.cpp:
985         (WebCore::Document::setFocusedNode):
986         * loader/EmptyClients.h:
987         (WebCore::EmptyChromeClient::focusedNodeChanged):
988         * page/Chrome.cpp:
989         (WebCore::Chrome::focusedNodeChanged):
990         * page/Chrome.h:
991         * page/ChromeClient.h:
992
993 2009-10-30  Ben Murdoch  <benm@google.com>
994
995         Reviewed by David Kilzer.
996
997         openDatabase() with empty version sets db version up incorrectly
998         https://bugs.webkit.org/show_bug.cgi?id=28417
999
1000         Test: storage/open-database-set-empty-version.html
1001
1002         * storage/Database.cpp:
1003         (WebCore::Database::performOpenAndVerify): Raise an exception if the current database version does not match the expected version when the current version is the empty string.
1004
1005 2009-10-30  John Gregg  <johnnyg@google.com>
1006
1007         Reviewed by David Levin.
1008
1009         Need to turn off notifications properly at runtime
1010         https://bugs.webkit.org/show_bug.cgi?id=30409
1011
1012         Moving the notificationsEnabled bit from NotificationCenter
1013         to the new V8 RuntimeEnabledFeatures object.
1014
1015         Just moving a bit around, so no new tests.
1016
1017         * bindings/v8/RuntimeEnabledFeatures.cpp:
1018         * bindings/v8/RuntimeEnabledFeatures.h:
1019         (WebCore::RuntimeEnabledFeatures::setNotificationsEnabled):
1020         (WebCore::RuntimeEnabledFeatures::notificationsEnabled):
1021         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1022         (WebCore::ACCESSOR_RUNTIME_ENABLER):
1023         * bindings/v8/custom/V8WorkerContextCustom.cpp:
1024         (WebCore::ACCESSOR_RUNTIME_ENABLER):
1025         * notifications/NotificationCenter.cpp:
1026         * notifications/NotificationCenter.h:
1027
1028 2009-10-30  Dmitry Titov  <dimich@chromium.org>
1029
1030         Reviewed by Dimitri Glazkov.
1031
1032         [V8] More cleanup after r49949: remove ListenerGuard.
1033         ListenerGuard is no longer needed since EventListeners do not depend on frame or v8 context.
1034         https://bugs.webkit.org/show_bug.cgi?id=30943
1035
1036         Covered by fast/events/add-event-without-document.html which will now pass in Chromium.
1037
1038         * bindings/v8/V8AbstractEventListener.cpp:
1039         (WebCore::V8AbstractEventListener::V8AbstractEventListener):
1040         (WebCore::V8AbstractEventListener::handleEvent):
1041         * bindings/v8/V8AbstractEventListener.h:
1042         * bindings/v8/V8DOMWrapper.cpp:
1043         (WebCore::V8DOMWrapper::getEventListener):
1044         * bindings/v8/V8EventListenerList.h:
1045         (WebCore::V8EventListenerList::findOrCreateWrapper):
1046         * bindings/v8/V8LazyEventListener.cpp:
1047         (WebCore::V8LazyEventListener::V8LazyEventListener):
1048         * bindings/v8/V8Proxy.cpp:
1049         (WebCore::V8Proxy::V8Proxy):
1050         (WebCore::V8Proxy::disconnectFrame):
1051         (WebCore::V8Proxy::clearForNavigation):
1052         * bindings/v8/V8Proxy.h:
1053         * bindings/v8/V8WorkerContextEventListener.cpp:
1054         (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
1055         (WebCore::V8WorkerContextEventListener::handleEvent):
1056         (WebCore::V8WorkerContextEventListener::reportError):
1057         * bindings/v8/V8WorkerContextEventListener.h:
1058         (WebCore::V8WorkerContextEventListener::create):
1059         * bindings/v8/WorkerContextExecutionProxy.cpp:
1060         (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
1061         (WebCore::WorkerContextExecutionProxy::dispose):
1062         (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
1063         * bindings/v8/WorkerContextExecutionProxy.h:
1064         * bindings/v8/custom/V8CustomEventListener.cpp:
1065         (WebCore::V8EventListener::V8EventListener):
1066         * bindings/v8/custom/V8CustomEventListener.h:
1067         (WebCore::V8EventListener::create):
1068
1069 2009-10-30  Shinichiro Hamaji  <hamaji@chromium.org>
1070
1071         Reviewed by Darin Adler.
1072
1073         counterValueForElementById should return space-separated string for multiple counters
1074         https://bugs.webkit.org/show_bug.cgi?id=30939
1075
1076         Test: fast/css/counters/counterValueForElementById.html
1077
1078         * rendering/RenderTreeAsText.cpp:
1079         (WebCore::writeCounterValuesFromChildren):
1080         (WebCore::counterValueForElement):
1081
1082 2009-10-30  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
1083
1084         Reviewed by Gustavo Noronha.
1085
1086         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1087         (WebCore::MediaPlayerPrivate::paint):
1088         Add some comments to explain what is happening here.
1089
1090 2009-10-30  Alexander Pavlov  <apavlov@chromium.org>
1091
1092         Reviewed by Timothy Hatcher.
1093
1094         Fix Web Inspector crash on the errors/warnings counter click
1095
1096         RenderObject::createVisiblePosition(const Position& position)
1097         understands "null Positions", so we can construct such a Position manually.
1098
1099         https://bugs.webkit.org/show_bug.cgi?id=30499
1100
1101         * rendering/RenderBox.cpp:
1102         (WebCore::RenderBox::positionForPoint):
1103
1104 2009-10-30  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1105
1106         Reviewed by Xan Lopez.
1107
1108         https://bugs.webkit.org/show_bug.cgi?id=25534
1109         [GTK] Objects of ROLE_TABLE should implement the accessible table interface
1110
1111         Third part of the implementation of AtkTable.
1112
1113         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1114         (nameFromChildren):
1115         (webkit_accessible_get_name):
1116         New convenience function to construct an object's name using the name(s) of
1117         any children it has.
1118
1119         (atk_table_interface_init):
1120         (webkit_accessible_table_get_column_description):
1121         (webkit_accessible_table_get_row_description):
1122         Implemented.
1123
1124         (webkit_accessible_table_get_column_header):
1125         Stub function added so that webkit_accessible_table_get_column_description
1126         could be implemented in the meantime.
1127
1128 2009-10-30  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1129
1130         Reviewed by Xan Lopez.
1131
1132         https://bugs.webkit.org/show_bug.cgi?id=25534
1133         [GTK] Objects of ROLE_TABLE should implement the accessible table interface
1134
1135         Second part of the implementation of AtkTable.
1136
1137         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1138         (cellAtIndex):
1139         (webkit_accessible_table_get_column_at_index):
1140         (webkit_accessible_table_get_row_at_index):
1141         (webkit_accessible_table_get_caption):
1142         (atk_table_interface_init):
1143
1144 2009-10-30  Pavel Feldman  <pfeldman@chromium.org>
1145
1146         Reviewed by Timothy Hatcher.
1147
1148         Web Inspector: Add TimelinePanel into the panels enum.
1149
1150         https://bugs.webkit.org/show_bug.cgi?id=30915
1151
1152         * inspector/InspectorFrontend.cpp:
1153         (WebCore::InspectorFrontend::showPanel):
1154         * inspector/front-end/inspector.js:
1155         (WebInspector.showTimelinePanel):
1156
1157 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1158
1159         Reviewed by Holger Hans Peter Freyther.
1160
1161         If the owner widget of the page has a palette set, we
1162         should use that one. This was only working when the
1163         owner was a QWebView. This patch fixes that.
1164
1165         * platform/qt/RenderThemeQt.cpp:
1166         (WebCore::RenderThemeQt::applyTheme):
1167
1168 2009-10-30  Pavel Feldman  <pfeldman@chromium.org>
1169
1170         Not reviewed: Wire CookieJarChromium to the cookies
1171         backend. This is a final step of a 3-steps raw cookies
1172         access implementation in Chromium.
1173
1174         * platform/network/chromium/CookieJarChromium.cpp:
1175         (WebCore::getRawCookies):
1176         (WebCore::deleteCookie):
1177
1178 2009-10-30  Yury Semikhatsky  <yurys@chromium.org>
1179
1180         Reviewed by Pavel Feldman.
1181
1182         Fix Chromium crash in console.log in "deeply recursive" function 
1183
1184         Check that result of 'frameSourceName' is not null handle
1185         before casting it to String. 
1186       
1187         Allow V8Proxy::sourceName/sourceLineNumber() to report
1188         that they have failed due to JavaScript stack overflow.
1189
1190         https://bugs.webkit.org/show_bug.cgi?id=30904
1191
1192         * bindings/scripts/CodeGeneratorV8.pm:
1193         * bindings/v8/ScriptCallStack.cpp:
1194         (WebCore::ScriptCallStack::create):
1195         (WebCore::ScriptCallStack::ScriptCallStack):
1196         * bindings/v8/ScriptCallStack.h:
1197         * bindings/v8/V8Proxy.cpp:
1198         (WebCore::V8Proxy::sourceLineNumber):
1199         (WebCore::V8Proxy::sourceName):
1200         * bindings/v8/V8Proxy.h:
1201         * bindings/v8/custom/V8WorkerContextCustom.cpp:
1202         (WebCore::CALLBACK_FUNC_DECL):
1203
1204 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
1205
1206         Reviewed by Darin Adler.
1207
1208         Allow custom memory allocation control for WebCore's MediaQuery
1209         https://bugs.webkit.org/show_bug.cgi?id=30856
1210
1211         Inherits MediaQuery class from Noncopyable because it is
1212         instantiated by 'new' in WebCore/css/CSSParser.cpp:4905 and
1213         it is no need to be copyable.
1214
1215         * css/CSSStyleSelector.h:
1216
1217 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
1218
1219         Reviewed by Darin Adler.
1220
1221         Allow custom memory allocation control for WebCore's MediaQueryExp
1222         https://bugs.webkit.org/show_bug.cgi?id=30855
1223
1224         Inherits MediaQueryExp class from FastAllocBase because it is
1225         instantiated by 'new' in WebCore/css/CSSParser.cpp:4874.
1226
1227         * css/MediaQueryExp.h:
1228
1229 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1230
1231         Reviewed by Eric Seidel.
1232
1233         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1234
1235         Bug 28420 -  Implement HTML5 <ruby> rendering
1236         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1237
1238         No new tests (no functional change).
1239
1240         * Configurations/FeatureDefines.xcconfig:
1241         * DerivedSources.make:
1242         * GNUmakefile.am:
1243         * WebCore.pro:
1244         * WebCore.vcproj/WebCoreCommon.vsprops:
1245         * WebCore.vcproj/build-generated-files.sh:
1246
1247 2009-10-30  Dan Bernstein  <mitz@apple.com>
1248
1249         Reviewed by Adele Peterson.
1250
1251         Removed test for an impossible condition (a glyph in a right-to-left run not having
1252         the RTL flag 0x800)
1253
1254         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1255         (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation):
1256
1257 2009-10-29  Adam Barth  <abarth@webkit.org>
1258
1259         Reviewed by Dimitri Glazkov.
1260
1261         [V8] Out-of-memory crash in isolated worlds
1262         https://bugs.webkit.org/show_bug.cgi?id=30906
1263
1264         We need to handle the fact that creating a V8:Context might fail.  I
1265         don't know how to test this change because creating a context usually
1266         only fails when V8 decides it's using too much memory.
1267
1268         * bindings/v8/V8IsolatedWorld.cpp:
1269         (WebCore::V8IsolatedWorld::V8IsolatedWorld):
1270         * bindings/v8/V8Proxy.cpp:
1271         (WebCore::V8Proxy::evaluateInIsolatedWorld):
1272         (WebCore::V8Proxy::evaluateInNewContext):
1273
1274 2009-10-29  Erik Arvidsson  <arv@chromium.org>
1275
1276         Reviewed by Eric Seidel.
1277
1278         Make links mouse focusable only on GTK and QT.
1279
1280         Links are now always mouse focusable on GTK and QT. On other platforms
1281         the link needs a tabIndex or it needs to be contentEditable.
1282
1283         https://bugs.webkit.org/show_bug.cgi?id=26856
1284
1285         * html/HTMLAnchorElement.cpp:
1286         (WebCore::HTMLAnchorElement::isMouseFocusable):
1287
1288 2009-10-29  Dan Bernstein  <mitz@apple.com>
1289
1290         Reviewed by Sam Weinig.
1291
1292         Complete the fix for hit-testing and selection highlighting in ligatures for the ATSUI
1293         code path.
1294
1295         * platform/graphics/mac/ComplexTextController.h: Added m_ltr member to ComplexTextRun.
1296         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1297         (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Skip over deleted
1298         glyphs, but update indexes and advances correctly.
1299         (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_ltr.
1300
1301 2009-10-29  Enrica Casucci  <enrica@apple.com>
1302
1303         Reviewed by Darin Adler.
1304
1305         REGRESSION(3.2.3 - 4.0.2): Message composing: when I undo a color change to text in Mail, undo/redo behaves strangely
1306         <rdar://problem/7115041>
1307         https://bugs.webkit.org/show_bug.cgi?id=30892
1308
1309         This problem shows in any scenario where it is necessary to split a text
1310         node to apply a style. SplitElementCommand and WrapContentsInDummySpanCommand both
1311         have member variables initialized in the constructor to keep reference to elements
1312         they need to operate upon. These reference are not updated when reapplying the command.
1313         For this reason it is necessary to guarantee that unapply doesn not delete the references
1314         and that these commands implement doReapply to correctly reuse the existing
1315         elements.
1316
1317         Test: editing/undo/redo-style.html
1318
1319         * editing/SplitElementCommand.cpp:
1320         (WebCore::SplitElementCommand::executeApply): Added.
1321         (WebCore::SplitElementCommand::doApply): Modified to call executeApply. 
1322         (WebCore::SplitElementCommand::doUnapply): Doesn't release m_element1.
1323         (WebCore::SplitElementCommand::doReapply): Added.
1324         * editing/SplitElementCommand.h: Added doReapply and executeApply.
1325         * editing/WrapContentsInDummySpanCommand.cpp:
1326         (WebCore::WrapContentsInDummySpanCommand::executeApply): Added.
1327         (WebCore::WrapContentsInDummySpanCommand::doApply): Modified to call executeApply.
1328         (WebCore::WrapContentsInDummySpanCommand::doUnapply): Doesn't release m_dummySpan.
1329         (WebCore::WrapContentsInDummySpanCommand::doReapply): Added.
1330         * editing/WrapContentsInDummySpanCommand.h: Added doReapply and executeApply.
1331
1332 2009-10-29  Jeremy Orlow  <jorlow@chromium.org>
1333
1334         Reviewed by Darin Fisher.
1335
1336         DOM Storage's condition variable needs to handle spurious wakeups
1337         https://bugs.webkit.org/show_bug.cgi?id=30920
1338
1339         Add a boolean to keep track of whether it's been terminated.  Clean
1340         up the locking code a tiny bit to make it easier to read.  There's
1341         no way to reproduce this reliably in a LayoutTest.
1342
1343         * storage/LocalStorageThread.cpp:
1344         (WebCore::LocalStorageThread::LocalStorageThread):
1345         (WebCore::LocalStorageThread::terminate):
1346         (WebCore::LocalStorageThread::performTerminate):
1347         * storage/LocalStorageThread.h:
1348
1349 2009-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
1350
1351         Unreviewed, build fix.
1352
1353         [Chromium] Include ComplextTextController into Chromium Mac project.
1354
1355         * WebCore.gyp/WebCore.gyp: Added include rule for ComplextText* files.
1356
1357 2009-10-29  Timothy Hatcher  <timothy@apple.com>
1358
1359         Fix tabbing through element attributes in the Web Insector.
1360
1361         https://bugs.webkit.org/show_bug.cgi?id=30429
1362
1363         Reviewed by Pavel Feldman.
1364
1365         * inspector/front-end/ElementsTreeOutline.js:
1366         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): Don't call _updateTitle,
1367         it is called for us when removeAttribute succeeds in the back-end.
1368         (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto except for nodeValue.
1369         (WebInspector.ElementsTreeElement.prototype._editingCancelled): Don't call _updateTitle, editing code reverts.
1370         (WebInspector.ElementsTreeElement.prototype._updateTitle): Return early if we are editing.
1371
1372 2009-10-29  Dan Bernstein  <mitz@apple.com>
1373
1374         Reviewed by Sam Weinig.
1375
1376         Problem editing or selecting text containing ligatures
1377         https://bugs.webkit.org/show_bug.cgi?id=30025
1378
1379         Test: platform/mac/fast/text/ligature-subdivision.html
1380
1381         * platform/graphics/mac/ComplexTextController.cpp:
1382         (WebCore::ComplexTextController::ComplexTextController): Initialize
1383         m_characterInCurrentGlyph.
1384         (WebCore::ComplexTextController::offsetForPosition): If the hit glyph spans multiple
1385         characters, compute the hit character based on dividing the glyph’s total advance into
1386         a number of equal intervals equal to the number of characters and assigning the hit to the
1387         character corresponding to the hit interval.
1388         (WebCore::ComplexTextController::advance): If the final offset occurs mid-glyph, advance
1389         by a fraction of the glyph’s total advance.
1390         * platform/graphics/mac/ComplexTextController.h: Added m_characterInCurrentGlyph.
1391
1392 2009-10-29  Brian Weinstein  <bweinstein@apple.com>
1393
1394         Reviewed by Timothy Hatcher.
1395
1396         Fixes <http://webkit.org/b/30918>.
1397         Web Inspector: Datagrid Rows on Windows not properly aligned.
1398         
1399         Use line-height for the table rows to make sure the height
1400         of our text and the height of the table rows are consistent.
1401
1402         * inspector/front-end/inspector.css:
1403
1404 2009-10-29  Adam Barth  <abarth@webkit.org>
1405
1406         No review, rolling out r50296.
1407         http://trac.webkit.org/changeset/50296
1408
1409         * bindings/v8/V8IsolatedWorld.cpp:
1410         (WebCore::V8IsolatedWorld::V8IsolatedWorld):
1411         * bindings/v8/V8Proxy.cpp:
1412         (WebCore::V8Proxy::evaluateInIsolatedWorld):
1413         (WebCore::V8Proxy::evaluateInNewContext):
1414
1415 2009-10-29  Adam Barth  <abarth@webkit.org>
1416
1417         Reviewed by Dimitri Glazkov.
1418
1419         [V8] Out-of-memory crash in isolated worlds
1420         https://bugs.webkit.org/show_bug.cgi?id=30906
1421
1422         We need to handle the fact that creating a V8:Context might fail.  I
1423         don't know how to test this change because creating a context usually
1424         only fails when V8 decides it's using too much memory.
1425
1426         * bindings/v8/V8IsolatedWorld.cpp:
1427         (WebCore::V8IsolatedWorld::V8IsolatedWorld):
1428         * bindings/v8/V8Proxy.cpp:
1429         (WebCore::V8Proxy::evaluateInIsolatedWorld):
1430         (WebCore::V8Proxy::evaluateInNewContext):
1431
1432 2009-10-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1433
1434         Reviewed by Xan Lopez.
1435
1436         Remove build warning introduced by r50284.
1437
1438         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1439         (WebCore::MediaPlayerPrivate::duration):
1440
1441 2009-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
1442
1443         Reviewed by Adam Barth.
1444
1445         [V8] Remove random crashes by removing retrieval of V8 context during garbage collection.
1446
1447         https://bugs.webkit.org/show_bug.cgi?id=30919
1448
1449         Unfortunately, I haven't been able to trigger this crash explicitly, so no test :(.
1450
1451         * bindings/v8/V8DOMWrapper.cpp:
1452         (WebCore::V8DOMWrapper::jsWrapperForDOMObject): Added new "assume-it's-there" getter.
1453         * bindings/v8/V8DOMWrapper.h: Added getter decl.
1454         * bindings/v8/V8GCController.cpp:
1455         (WebCore::GCPrologueVisitor::visitDOMWrapper): Changed to use explicit getter.
1456
1457 2009-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
1458
1459         Unreviewed, build fix.
1460
1461         [Chromium] Adjust the project files to sync up with
1462         http://trac.webkit.org/changeset/50259
1463
1464         * WebCore.gypi: Renamed and added files.
1465
1466 2009-10-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1467
1468         Reviewed by Tor Arne Vestbø.
1469
1470         [Qt] Implement DELETE HTTP method for XmlHttpRequest
1471         https://bugs.webkit.org/show_bug.cgi?id=30894
1472
1473         No new tests as this functionality is already tested by the 
1474         xmlhttprequest LayoutTests. As this patch depends on an unreleased
1475         version of the dependent QtNetwork library and the tests will be
1476         enabled later once the dependent library is released (and the
1477         buildbot is updated).
1478
1479         * platform/network/qt/QNetworkReplyHandler.cpp:
1480         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
1481         (WebCore::QNetworkReplyHandler::start):
1482
1483 2009-10-29  Brian Weinstein  <bweinstein@apple.com>
1484
1485         Reviewed by Timothy Hatcher.
1486
1487         Part of <http://webkit.org/b/30483>.
1488         Web Inspector: Always show the Local and Session Storage Views.
1489         
1490         Even if the length of the DOM Storage entry array is 0, still
1491         generate the Datagrid because users can add things storage items
1492         through the UI, so we should allow them to even if there isn't
1493         anything there currently.
1494
1495         * English.lproj/localizedStrings.js: Removed "This Storage is Empty".
1496         * inspector/front-end/DOMStorageItemsView.js:
1497         (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
1498
1499 2009-10-29  Pavel Feldman  <pfeldman@chromium.org>
1500
1501         Reviewed by Timothy Hatcher.
1502
1503         Web Inspector: Add TimelinePanel into the panels enum.
1504
1505         https://bugs.webkit.org/show_bug.cgi?id=30915
1506
1507         * inspector/InspectorController.cpp:
1508         (WebCore::InspectorController::specialPanelForJSName):
1509         * inspector/InspectorController.h:
1510         (WebCore::InspectorController::):
1511
1512 2009-10-29  Xan Lopez  <xlopez@igalia.com>
1513
1514         Reviewed by Oliver Hunt.
1515
1516         [GTK] Threading problems with some of the tests
1517         https://bugs.webkit.org/show_bug.cgi?id=30814
1518
1519         Create strings shared among threads with crossThreadString
1520         constructor method.
1521
1522         * storage/Database.cpp:
1523         (WebCore::Database::Database):
1524
1525 2009-10-29  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
1526
1527         Reviewed by Gustavo Noronha.
1528
1529         https://bugs.webkit.org/show_bug.cgi?id=30308
1530         
1531         Add support for ARGB videos.
1532
1533         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1534         (WebCore::MediaPlayerPrivate::paint):
1535         Create the Cairo image surface for ARGB32 or RGB24
1536         depending on the buffer's caps.
1537         
1538         * platform/graphics/gtk/VideoSinkGStreamer.cpp:
1539         (webkit_video_sink_timeout_func):
1540         (webkit_video_sink_render):
1541         Handle ARGB video and convert GStreamer's ARGB to
1542         Cairo's for displaying.
1543
1544 2009-10-29  Anton Muhin  <antonm@chromium.org>
1545
1546         Reviewed by David Levin.
1547
1548         [chromium] expose a method to access memory usage information in ChromiumBridge
1549         Declare a static method to be implemented by http://codereview.chromium.org/332010/
1550         https://bugs.webkit.org/show_bug.cgi?id=30829
1551
1552         * platform/chromium/ChromiumBridge.h:
1553
1554 2009-10-29  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1555
1556         Reviewed by Xan Lopez.
1557
1558         https://bugs.webkit.org/show_bug.cgi?id=25679
1559         [Gtk] Improve accessibility of focusable lists
1560
1561         Implements the AtkSelection interface and enables the corresponding
1562         (and expected) object:selection-changed event.
1563
1564         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1565         (optionFromList):
1566         (optionFromSelection):
1567         (atk_selection_interface_init):
1568         (webkit_accessible_selection_add_selection):
1569         (webkit_accessible_selection_clear_selection):
1570         (webkit_accessible_selection_ref_selection):
1571         (webkit_accessible_selection_get_selection_count):
1572         (webkit_accessible_selection_is_child_selected):
1573         (webkit_accessible_selection_remove_selection):
1574         (webkit_accessible_selection_select_all_selection):
1575         (GetAtkInterfaceTypeFromWAIType):
1576         * accessibility/gtk/AXObjectCacheAtk.cpp:
1577         (AXObjectCache::postPlatformNotification):
1578
1579 2009-10-29  Jian Li  <jianli@chromium.org>
1580
1581         Reviewed by Darin Adler.
1582
1583         Bug 30655 - Only plain text should be copied to clipboard for TextArea.
1584         https://bugs.webkit.org/show_bug.cgi?id=30655
1585
1586         * editing/Editor.cpp:
1587         (WebCore::nodeIsInTextFormControl):
1588         (WebCore::Editor::cut):
1589         (WebCore::Editor::copy):
1590
1591 2009-10-29  Pavel Feldman  <pfeldman@chromium.org>
1592
1593         Reviewed by Timothy Hatcher.
1594
1595         Web Inspector: hide timeline for now - not yet ready.
1596
1597         https://bugs.webkit.org/show_bug.cgi?id=30912
1598
1599         * inspector/front-end/inspector.js:
1600         (WebInspector._createPanels):
1601
1602 2009-10-29  Pavel Feldman  <pfeldman@chromium.org>
1603
1604         Not reviewed: deploy Web Inspector's images in WebCore.gypi.
1605
1606         * WebCore.gypi:
1607
1608 2009-10-29  Pavel Feldman  <pfeldman@chromium.org>
1609
1610         Reviewed by Timothy Hatcher.
1611
1612         Web Inspector: get rid of timelineProfilerEnabled method.
1613
1614         https://bugs.webkit.org/show_bug.cgi?id=30911
1615
1616         * inspector/InspectorBackend.cpp:
1617         * inspector/InspectorBackend.h:
1618         * inspector/InspectorBackend.idl:
1619         * inspector/InspectorController.cpp:
1620         (WebCore::InspectorController::setWindowVisible):
1621         * inspector/InspectorController.h:
1622         * inspector/front-end/TimelinePanel.js:
1623         (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
1624
1625 2009-10-29  Pavel Feldman  <pfeldman@chromium.org>
1626
1627         Reviewed by Darin Fisher.
1628
1629         Create stub methods for raw cookies access in ChromiumBridge.h
1630
1631         https://bugs.webkit.org/show_bug.cgi?id=30910
1632
1633         * platform/chromium/ChromiumBridge.h:
1634
1635 2009-10-29  Zoltan Horvath  <zoltan@webkit.org>
1636
1637         Reviewed by Darin Adler.
1638
1639         Allow custom memory allocation control for WebCore's RareData
1640         https://bugs.webkit.org/show_bug.cgi?id=30858
1641
1642         Inherits RareData struct from Noncopyable because it is
1643         instantiated by 'new' in WebCore/css/CSSSelector.h:259 and 
1644         it is no need to be copyable.
1645
1646         * css/CSSSelector.h:
1647
1648 2009-10-29  Zoltan Horvath  <zoltan@webkit.org>
1649
1650         Reviewed by Darin Adler.
1651
1652         Allow custom memory allocation control for WebCore's ShorthandScope
1653         https://bugs.webkit.org/show_bug.cgi?id=30859
1654
1655         Inherits ShorthandScope class from FastAllocBase because it is 
1656         instantiated by 'new' in WebCore/css/CSSParser.cpp:902 and 
1657         it is no need to be copyable.        
1658
1659         * css/CSSParser.h:
1660
1661 2009-10-29  Zoltan Horvath  <zoltan@webkit.org>
1662
1663         Reviewed by Darin Adler.
1664
1665         Allow custom memory allocation control for WebCore's AXObjectCache
1666         https://bugs.webkit.org/show_bug.cgi?id=30848
1667
1668         Inherits AXObjectCache class from FastAllocBase because it is
1669         instantiated by 'new' in WebCore/dom/Document.cpp:1537 and                                
1670         it is no need to be copyable.
1671
1672         * accessibility/AXObjectCache.h:
1673
1674 2009-10-28  Adam Barth  <abarth@webkit.org>
1675
1676         Reviewed by Eric Seidel.
1677
1678         Don't run JavaScript URLs in view source mode
1679         https://bugs.webkit.org/show_bug.cgi?id=30881
1680
1681         Just say no.
1682
1683         Test: http/tests/security/view-source-no-javascript-url.html
1684
1685         * bindings/ScriptControllerBase.cpp:
1686         (WebCore::ScriptController::executeIfJavaScriptURL):
1687
1688 2009-10-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1689
1690         Unreviewed. Fixes style problems pointed out by Evan Martin.
1691
1692         * platform/gtk/Language.cpp:
1693         (WebCore::defaultLanguage):
1694
1695 2009-10-29  Dan Bernstein  <mitz@apple.com>
1696
1697         Rubber-stamped by Mark Rowe.
1698
1699         64-bit Leopard build fix after r50259
1700         
1701         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1702         Declared ATSUTextInserted in 64-bit.
1703         (WebCore::fontHasMirroringInfo): Use %d format and cast to int.
1704         (WebCore::disableLigatures): Ditto.
1705         (WebCore::initializeATSUStyle): Ditto.
1706         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Ditto.
1707
1708 2009-10-29  Dan Bernstein  <mitz@apple.com>
1709
1710         Tiger build fix after r50259
1711
1712         * platform/graphics/mac/ComplexTextController.h:
1713         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1714
1715 2009-10-29  Dan Bernstein  <mitz@apple.com>
1716
1717         Attempted Tiger build fix after r50259
1718
1719         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1720
1721 2009-10-28  Steve Falkenburg  <sfalken@apple.com>
1722
1723         Rubber stamped by Mark Rowe.
1724
1725         https://bugs.webkit.org/show_bug.cgi?id=30899
1726         WebKit fails to build release on 32-bit Windows systems
1727
1728         * WebCore.vcproj/WebCore.vcproj: Excluded files from project.
1729         * bindings/js/JSBindingsAllInOne.cpp: Added.
1730
1731 2009-10-28  Dan Bernstein  <mitz@apple.com>
1732
1733         Reviewed by Jon Honeycutt.
1734
1735         Fixed typos in color names.
1736
1737         * inspector/front-end/Color.js:
1738
1739 2009-10-28  Dan Bernstein  <mitz@apple.com>
1740
1741         Reviewed by Sam Weinig.
1742
1743         Share code between the ATSUI- and Core Text-based Font implementations by doing the
1744         following:
1745         - Generalize CoreTextController as ComplexTextController, keeping the Core Text-specific
1746           parts in ComplexTextControllerCoreText.cpp.
1747         - Generalize FontMacCoreText as FontComplexTextMac using ComplexTextController
1748         - Implement ATSUI-specific parts of ComplexTextController in ComplexTextControllerATSUI.
1749         - Remove FontMacATSUI.
1750
1751         * WebCore.xcodeproj/project.pbxproj: Removed CoreTextController.{cpp,h}, FontMacATSUI.mm,
1752         and FontMacCoreText.cpp, and added ComplexTextController.{cpp,h},
1753         ComplexTextControllerATSUI.cpp, ComplexTextControllerCoreText.cpp, and
1754         FontComplexTextMac.cpp.
1755
1756         * platform/graphics/mac/ComplexTextController.cpp: Copied from CoreTextController.cpp and
1757         kept the non-Core Text-specific bits.
1758         (WebCore::ComplexTextController::ComplexTextController): Updated for renames, including
1759         its own.
1760         (WebCore::ComplexTextController::offsetForPosition): Updated for renames and for
1761         m_complexTextRuns holding references instead of objects.
1762         (WebCore::ComplexTextController::collectComplexTextRuns): Updated for renames, including
1763         its own.
1764         (WebCore::ComplexTextController::advance): Updated for renames.
1765         (WebCore::ComplexTextController::adjustGlyphsAndAdvances): Updated for renames and for
1766         m_complexTextRuns holding references instead of objects, and changed to use the glyphs()
1767         and advances() accessors.
1768
1769         * platform/graphics/mac/ComplexTextController.h: Copied from CoreTextController.h and
1770         renamed CoreTextController to ComplexTextController and CoreTextRun to ComplexTextRun. Made
1771         the latter RefCounted, added ATSUI-specific members to it, and made some other members
1772         Core Text-specific. Renamed m_coreTextRuns to m_complexTextRuns and made it hold references
1773         rather than objects.
1774         (WebCore::ComplexTextController::ComplexTextRun::create):
1775         (WebCore::ComplexTextController::ComplexTextRun::glyphs):
1776         (WebCore::ComplexTextController::ComplexTextRun::advances):
1777
1778         * platform/graphics/mac/ComplexTextControllerATSUI.cpp: Added. Includes ATSUI-specific
1779         parts of the ComplexTextController implementation. 
1780         (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): This ATSUI
1781         callback populates the ComplexTextRun’s glyphs, advances and indices vectors. It is invoked
1782         when the ComplexTextRun constructor calls ATSUGetGlyphBounds().
1783         (WebCore::isArabicLamWithAlefLigature): Helper function, copied from FontMacATSUI.mm.
1784         (WebCore::shapeArabic): Helper function, adapted from FontMacATSUI.mm.
1785         (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Sets up the
1786         ATSUTextLayout, substituting the text buffer if necessary for things like shaping Arabic,
1787         mirroring glyphs or directionality overrides, then calls ATSUGetGlyphBounds() in order to
1788         get the glyphs, advances and indices vectors populated.
1789         (WebCore::fontHasMirroringInfo): Helper function, copied from FontMacATSUI.mm.
1790         (WebCore::disableLigatures): Ditto.
1791         (WebCore::initializeATSUStyle): Ditto, somewhat cleaned up and simplified.
1792         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Constructs
1793         ComplexTextRuns, either missing-glyphs ones or ATSUTextLayout-based ones.
1794
1795         * platform/graphics/mac/ComplexTextControllerCoreText.cpp: Copied from
1796         CoreTextController.cpp and kept the Core Text-specific bits.
1797         (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Updated for renames,
1798         including its own, and moved the code to initialize m_glyphs and m_advances here. Previously
1799         this was done in adjustGlyphsAndAdvances().
1800         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Updated for renames,
1801         including its own.
1802         * platform/graphics/mac/CoreTextController.cpp: Removed.
1803         * platform/graphics/mac/CoreTextController.h: Removed.
1804         * platform/graphics/mac/FontComplexTextMac.cpp: Renamed FontMacCoreText.cpp to this.
1805         (WebCore::Font::selectionRectForComplexText): Changed to use ComplexTextController instead
1806         of CoreTextController.
1807         (WebCore::Font::drawComplexText): Ditto.
1808         (WebCore::Font::floatWidthForComplexText): Ditto.
1809         (WebCore::Font::offsetForPositionForComplexText): Ditto.
1810         * platform/graphics/mac/FontMacATSUI.mm: Removed.
1811         * platform/graphics/mac/FontMacCoreText.cpp: Removed.
1812
1813 2009-10-27  Chris Fleizach  <cfleizach@apple.com>
1814
1815         Reviewed by Darin Adler.
1816
1817         WAI-ARIA: add support for 'option' role
1818         https://bugs.webkit.org/show_bug.cgi?id=30843
1819
1820         Test: accessibility/aria-option-role.html
1821
1822         * accessibility/AccessibilityListBoxOption.h:
1823         (WebCore::AccessibilityListBoxOption::canHaveChildren):
1824         * accessibility/AccessibilityRenderObject.cpp:
1825         (WebCore::RoleEntry::):
1826         (WebCore::AccessibilityRenderObject::canHaveChildren):
1827
1828 2009-10-28  Jens Alfke  <snej@chromium.org>
1829
1830         Reviewed by Eric Seidel.
1831
1832         Fix GCC compiler warnings in WebCore, and enable -Wall and -Werror for Chromium build.
1833         https://bugs.webkit.org/show_bug.cgi?id=30716
1834
1835         * WebCore.gyp/WebCore.gyp:  Enable "chromium_code" flag, just on Mac build for now.
1836         * accessibility/AccessibilityRenderObject.cpp:
1837         (WebCore::createARIARoleMap):  Fix struct visibiity warning.
1838         * bindings/v8/ScriptCallStack.h:  Fix out-of-order member initialization warning.
1839         * bindings/v8/V8Collection.h:
1840         (WebCore::getV8Object):  Function in header should not be 'static' (fixes unused-static warning.)
1841         * bindings/v8/V8DOMWrapper.cpp:
1842         (WebCore::V8DOMWrapper::convertNewNodeToV8Object):  Fix signed/unsigned comparison warning.
1843         * bindings/v8/V8GCController.cpp:
1844         (WebCore::ObjectGrouperVisitor::applyGrouping):  Fix unused-variable warning.
1845         * css/CSSPrimitiveValueMappings.h:
1846         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):  Enable ListButtonPart case to avoid
1847             warning about missing cases in 'switch' statement.
1848         * editing/EditorCommand.cpp:
1849         (WebCore::createCommandMap):  Fix struct visibiity warning.
1850         * platform/graphics/skia/PlatformContextSkia.cpp:
1851         (PlatformContextSkia::State::State):  Fix out-of-order member initialization warning.
1852         * rendering/RenderMediaControlsChromium.cpp:
1853         (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart):  Add empty 'default' case in
1854             'switch' statement to avoid missing-case warning.
1855         (WebCore::RenderMediaControlsChromium::paintMediaControlsPart):  Ditto.
1856         * xml/XPathFunctions.cpp:
1857         (WebCore::XPath::createFunctionMap):  Fix struct visibiity warning.
1858
1859 2009-10-29  Adam Barth  <abarth@webkit.org>
1860
1861         Reviewed by Darin Adler.
1862
1863         REGRESSION: crashes in WebCore::RedirectScheduler::timerFired(WebCore::Timer<WebCore::RedirectScheduler>*)
1864         https://bugs.webkit.org/show_bug.cgi?id=30839
1865
1866         Added null check for the case when the frame is detached from the page.
1867
1868         * loader/RedirectScheduler.cpp:
1869         (WebCore::RedirectScheduler::timerFired):
1870
1871 2009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1872
1873         Reviewed by Xan Lopez.
1874
1875         https://bugs.webkit.org/show_bug.cgi?id=30817
1876         Use parentObjectUnignored instead of parentObject in webkit_accessible_get_parent
1877
1878         Also removes the hack I had originally added to solve bug 25411, because
1879         the fix here is what I should have done in the first place.
1880
1881         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1882         (webkit_accessible_get_parent):
1883
1884 2009-10-28  Dmitry Titov  <dimich@chromium.org>
1885
1886         Reviewed by David Levin.
1887
1888         https://bugs.webkit.org/show_bug.cgi?id=30805
1889         Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
1890         Existing Database tests cover this, no change in functionality.
1891
1892         * storage/DatabaseThread.cpp:
1893         (WebCore::SameDatabasePredicate::SameDatabasePredicate): Added predicate that flags the tasks belonging to a specified database.
1894         (WebCore::SameDatabasePredicate::operator()):
1895         (WebCore::DatabaseThread::unscheduleDatabaseTasks): changed to use the new removeIf method.
1896
1897 2009-10-28  Pavel Feldman  <pfeldman@chromium.org>
1898
1899         Reviewed by Timothy Hatcher.
1900
1901         Web Inspector: Glue subsequent timeline records with same category
1902         and title together.
1903
1904         https://bugs.webkit.org/show_bug.cgi?id=30885
1905
1906         * English.lproj/localizedStrings.js:
1907         * inspector/front-end/TimelinePanel.js:
1908         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
1909         (WebInspector.TimelinePanel.prototype._formatRecord):
1910         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
1911         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
1912
1913 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1914
1915         Reviewed by Xan Lopez.
1916
1917         [GTK] Fails new test fast/js/navigator-language.html
1918         https://bugs.webkit.org/show_bug.cgi?id=30440
1919
1920         Reimplement WebCore::defaultLanguage to account for changes in
1921         locale done by setLocale.
1922
1923         Already existing test: fast/js/navigator-language.html
1924
1925         * platform/gtk/Language.cpp:
1926         (WebCore::defaultLanguage):
1927
1928 2009-10-28  Eric Carlson  <eric.carlson@apple.com>
1929
1930         Reviewed by Simon Fraser.
1931
1932         <rdar://problem/7303145> 
1933         Can't exit full screen mode or restart movie after pressing command -R.
1934
1935         * html/HTMLMediaElement.cpp:
1936         (WebCore::HTMLMediaElement::removedFromDocument):
1937         (WebCore::HTMLMediaElement::documentWillBecomeInactive):
1938             Exit from fullscreen if necessary.
1939         * html/HTMLMediaElement.h:
1940
1941 2009-10-28  Alexey Proskuryakov  <ap@apple.com>
1942
1943         Unreviewed - a trivial fix to get Windows bots running.
1944
1945         https://bugs.webkit.org/show_bug.cgi?id=30841
1946         <rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site
1947
1948         * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): Don't try to
1949         access empty vector's data.
1950
1951 2009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1952
1953         Reviewed by Xan Lopez.
1954
1955         https://bugs.webkit.org/show_bug.cgi?id=25897
1956         [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
1957
1958         Remove the extraneous object of ROLE_PANEL.
1959
1960         * accessibility/gtk/AccessibilityObjectAtk.cpp:
1961         (AccessibilityObject::accessibilityPlatformIncludesObject):
1962
1963 2009-10-28  Jonathan Dixon  <joth@chromium.org>
1964
1965         Reviewed by Eric Seidel.
1966
1967         Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
1968         https://bugs.webkit.org/show_bug.cgi?id=30547
1969
1970         Test: fast/css/text-input-with-webkit-border-radius.html
1971
1972         * rendering/RenderThemeChromiumWin.cpp:
1973         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1974           Implemented rounded border rendering in Chromium Windows theme renderer.
1975
1976 2009-10-28  Pavel Feldman  <pfeldman@chromium.org>
1977
1978         Reviewed by Timothy Hatcher.
1979
1980         Web Inspector: Pull items collections from resources panel and
1981         timeline panel into AbstractTimelinePanel.
1982
1983         https://bugs.webkit.org/show_bug.cgi?id=30875
1984
1985         * inspector/front-end/AbstractTimelinePanel.js:
1986         (WebInspector.AbstractTimelinePanel):
1987         (WebInspector.AbstractTimelinePanel.prototype.populateSidebar):
1988         (WebInspector.AbstractTimelinePanel.prototype.createItemTreeElement):
1989         (WebInspector.AbstractTimelinePanel.prototype.createItemGraph):
1990         (WebInspector.AbstractTimelinePanel.prototype._showCategory):
1991         (WebInspector.AbstractTimelinePanel.prototype._hideCategory):
1992         (WebInspector.AbstractTimelinePanel.prototype.filter):
1993         (WebInspector.AbstractTimelinePanel.prototype._createGraph):
1994         (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth):
1995         (WebInspector.AbstractTimelinePanel.prototype.refresh):
1996         (WebInspector.AbstractTimelinePanel.prototype.reset):
1997         (WebInspector.AbstractTimelinePanel.prototype.get calculator):
1998         (WebInspector.AbstractTimelinePanel.prototype.set calculator):
1999         (WebInspector.AbstractTimelinePanel.prototype.addItem):
2000         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
2001         (WebInspector.AbstractTimelinePanel.prototype.refreshItem):
2002         (WebInspector.AbstractTimelinePanel.prototype.revealAndSelectItem):
2003         (WebInspector.AbstractTimelinePanel.prototype.sortItems):
2004         (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition):
2005         (WebInspector.AbstractTimelineCategory):
2006         (WebInspector.AbstractTimelineCategory.prototype.toString):
2007         * inspector/front-end/ResourceCategory.js:
2008         (WebInspector.ResourceCategory):
2009         * inspector/front-end/ResourcesPanel.js:
2010         (WebInspector.ResourcesPanel):
2011         (WebInspector.ResourcesPanel.prototype.createItemTreeElement):
2012         (WebInspector.ResourcesPanel.prototype.createItemGraph):
2013         (WebInspector.ResourcesPanel.prototype.isCategoryVisible):
2014         (WebInspector.ResourcesPanel.prototype.populateSidebar):
2015         (WebInspector.ResourcesPanel.prototype.get searchableViews):
2016         (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction.sortFuction):
2017         (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction):
2018         (WebInspector.ResourcesPanel.prototype.searchMatchFound):
2019         (WebInspector.ResourcesPanel.prototype.searchCanceled):
2020         (WebInspector.ResourcesPanel.prototype.performSearch):
2021         (WebInspector.ResourcesPanel.prototype.refresh):
2022         (WebInspector.ResourcesPanel.prototype.reset):
2023         (WebInspector.ResourcesPanel.prototype.removeResource):
2024         (WebInspector.ResourcesPanel.prototype.addMessageToResource):
2025         (WebInspector.ResourcesPanel.prototype.clearMessages):
2026         (WebInspector.ResourcesPanel.prototype.refreshResource):
2027         (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
2028         (WebInspector.ResourcesPanel.prototype.showResource):
2029         (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded):
2030         (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
2031         (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
2032         (WebInspector.ResourcesPanel.prototype.get _resources):
2033         (WebInspector.ResourceTimeCalculator.prototype._upperBound):
2034         * inspector/front-end/TimelinePanel.js:
2035         (WebInspector.TimelinePanel):
2036         (WebInspector.TimelinePanel.prototype.get categories):
2037         (WebInspector.TimelinePanel.prototype.populateSidebar):
2038         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
2039         (WebInspector.TimelinePanel.prototype.createItemTreeElement):
2040         (WebInspector.TimelinePanel.prototype.createItemGraph):
2041         (WebInspector.TimelinePanel.prototype._formatRecord):
2042         (WebInspector.TimelineCategory):
2043         * inspector/front-end/inspector.css:
2044         * inspector/front-end/inspector.html:
2045
2046 2009-10-28  Kelly Norton  <knorton@google.com>
2047
2048         Reviewed by Pavel Feldman.
2049
2050         Resets InspectorFrontend in InspectorTimelineAgent instead of removing it so
2051         that it remains active on refreshs and page transitions.
2052         https://bugs.webkit.org/show_bug.cgi?id=30874
2053
2054         * inspector/InspectorController.cpp:
2055         (WebCore::InspectorController::setFrontendProxyObject):
2056         * inspector/InspectorTimelineAgent.cpp:
2057         (WebCore::InspectorTimelineAgent::resetFrontendProxyObject):
2058         * inspector/InspectorTimelineAgent.h:
2059
2060 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2061
2062         Reviewed by Darin Adler.
2063
2064         Provide a way to get counter values with layoutTestContoller
2065         https://bugs.webkit.org/show_bug.cgi?id=30555
2066
2067         Expose WebCore::counterValueForElement as a WebCore API.
2068
2069         * WebCore.base.exp:
2070         * rendering/RenderTreeAsText.cpp:
2071         (WebCore::writeCounterValuesFromChildren):
2072         (WebCore::counterValueForElement):
2073         * rendering/RenderTreeAsText.h:
2074
2075 2009-10-28  Nate Chapin  <japhet@chromium.org>
2076
2077         Unreviewed, Chromium build fix for r50225.
2078
2079         * loader/FrameLoader.cpp:
2080         (WebCore::FrameLoader::defaultObjectContentType):
2081
2082 2009-10-28  Eric Z. Ayers  <zundel@google.com>
2083
2084         Reviewed by Pavel Feldman.
2085
2086         Adds InspectorTimelineAgent  instrumentation for encountering a
2087         <SCRIPT> tag when parsing an HTML document. 
2088
2089         https://bugs.webkit.org/show_bug.cgi?id=30861
2090
2091         * bindings/js/ScriptSourceCode.h:
2092         (WebCore::ScriptSourceCode::ScriptSourceCode):
2093         (WebCore::ScriptSourceCode::startLine):
2094         (WebCore::ScriptSourceCode::url):
2095         * html/HTMLTokenizer.cpp:
2096         (WebCore::HTMLTokenizer::scriptHandler):
2097         (WebCore::HTMLTokenizer::scriptExecution):
2098         * inspector/InspectorTimelineAgent.cpp:
2099         (WebCore::InspectorTimelineAgent::willLoadXHR):
2100         (WebCore::InspectorTimelineAgent::willScriptTag):
2101         (WebCore::InspectorTimelineAgent::didScriptTag):
2102         * inspector/InspectorTimelineAgent.h:
2103         (WebCore::):
2104         * inspector/TimelineRecordFactory.cpp:
2105         (WebCore::TimelineRecordFactory::createScriptTagTimelineRecord):
2106         * inspector/TimelineRecordFactory.h:
2107         * inspector/front-end/TimelineAgent.js:
2108
2109 2009-10-28  Steve Block  <steveblock@google.com>
2110
2111         Reviewed by Darin Adler.
2112
2113         Makes sure that Geolocation watch IDs remain positive on overflow.
2114         https://bugs.webkit.org/show_bug.cgi?id=30122
2115
2116         No new tests possible.
2117
2118         * page/Geolocation.cpp: Modified.
2119         (WebCore::Geolocation::watchPosition): Modified. Reset the watch ID to 1 on overflow.
2120
2121 2009-10-28  George Staikos  <george.staikos@torchmobile.com>
2122
2123         Attempt to fix the Mac debug build after 50225.
2124
2125         * loader/FrameLoader.cpp:
2126         (WebCore::FrameLoader::defaultObjectContentType):
2127
2128 2009-10-28  Alexey Proskuryakov  <ap@apple.com>
2129
2130         Reviewed by Darin Adler.
2131
2132         https://bugs.webkit.org/show_bug.cgi?id=30841
2133         <rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site
2134
2135         Tests: http/tests/ssl/referer-301.html
2136                http/tests/ssl/referer-303.html
2137
2138         * platform/network/mac/ResourceHandleMac.mm:
2139         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
2140         Remove Referer header if redirecting from https to another protocol.
2141
2142         * platform/network/ResourceRequestBase.cpp:
2143         (WebCore::ResourceRequestBase::clearHTTPReferrer): Update request counterparts, as it is
2144         always done when changing or adding header fields.
2145         (WebCore::ResourceRequestBase::clearHTTPOrigin): Ditto.
2146
2147         * platform/network/ResourceRequestBase.h: clearHTTPReferrer() and clearHTTPOrigin() are
2148         no longer inline, since they have non-trivial implementations.
2149
2150         * platform/network/mac/ResourceRequestMac.mm:
2151         (WebCore::ResourceRequest::doUpdatePlatformRequest): Fixed to synchronize header field removals.
2152         (WebCore::ResourceRequest::doUpdateResourceRequest): Ditto.
2153
2154         * platform/network/cf/ResourceHandleCFNet.cpp:
2155         (WebCore::willSendRequest):
2156         * platform/network/cf/ResourceRequestCFNet.cpp:
2157         (WebCore::setHeaderFields):
2158         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2159         (WebCore::ResourceRequest::doUpdateResourceRequest):
2160         Match Mac changes.
2161         
2162 2009-10-28  Joe Mason  <jmason@rim.com>
2163
2164         Reviewed by Adam Treat.
2165
2166         Add FrameLoader::defaultObjectContentType, containing common code for
2167         implementing FrameLoaderClient::objectContentType.  (Currently the gtk
2168         and win ports have copied this code, and the qt port uses similar code
2169         with a few extra clauses.  Moving this to a utility function cuts down
2170         on copied code.)   This causes no behavioural change.
2171
2172         https://bugs.webkit.org/show_bug.cgi?id=30868
2173
2174         * loader/FrameLoader.cpp:
2175         (WebCore::FrameLoader::defaultObjectContentType):
2176         * loader/FrameLoader.h:
2177
2178 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2179
2180         Reviewed by Tor Arne Vestbø.
2181
2182         [Qt] QWebHistory::saveState() is inconsistent with the Qt API
2183         https://bugs.webkit.org/show_bug.cgi?id=30710
2184
2185         Enforce the versioning, by ignoring any version different
2186         from 1.
2187
2188         * history/qt/HistoryItemQt.cpp:
2189         (WebCore::HistoryItem::restoreState):
2190         (WebCore::HistoryItem::saveState):
2191
2192 2009-10-28  Pavel Feldman  <pfeldman@chromium.org>
2193
2194         Not reviewed: follow up fix to InspectorControllerStub.
2195         Define it after inspector.js due to namespace
2196
2197         https://bugs.webkit.org/show_bug.cgi?id=30866
2198
2199         * inspector/front-end/inspector.html:
2200
2201 2009-10-28  Pavel Feldman  <pfeldman@chromium.org>
2202
2203         Reviewed by Timothy Hatcher.
2204
2205         Web Inspector: Add InspectorController stub in order to
2206         support opening in standalone mode.
2207
2208         https://bugs.webkit.org/show_bug.cgi?id=30866
2209
2210         * WebCore.gypi:
2211         * WebCore.vcproj/WebCore.vcproj:
2212         * inspector/front-end/InspectorControllerStub.js: Added.
2213         (.WebInspector.InspectorControllerStub):
2214         (.WebInspector.InspectorControllerStub.prototype.wrapCallback):
2215         (.WebInspector.InspectorControllerStub.prototype.isWindowVisible):
2216         (.WebInspector.InspectorControllerStub.prototype.platform):
2217         (.WebInspector.InspectorControllerStub.prototype.closeWindow):
2218         (.WebInspector.InspectorControllerStub.prototype.attach):
2219         (.WebInspector.InspectorControllerStub.prototype.detach):
2220         (.WebInspector.InspectorControllerStub.prototype.storeLastActivePanel):
2221         (.WebInspector.InspectorControllerStub.prototype.clearMessages):
2222         (.WebInspector.InspectorControllerStub.prototype.searchingForNode):
2223         (.WebInspector.InspectorControllerStub.prototype.search):
2224         (.WebInspector.InspectorControllerStub.prototype.toggleNodeSearch):
2225         (.WebInspector.InspectorControllerStub.prototype.setAttachedWindowHeight):
2226         (.WebInspector.InspectorControllerStub.prototype.moveByUnrestricted):
2227         (.WebInspector.InspectorControllerStub.prototype.addResourceSourceToFrame):
2228         (.WebInspector.InspectorControllerStub.prototype.addSourceToFrame):
2229         (.WebInspector.InspectorControllerStub.prototype.getResourceDocumentNode):
2230         (.WebInspector.InspectorControllerStub.prototype.highlightDOMNode):
2231         (.WebInspector.InspectorControllerStub.prototype.hideDOMNodeHighlight):
2232         (.WebInspector.InspectorControllerStub.prototype.inspectedWindow):
2233         (.WebInspector.InspectorControllerStub.prototype.loaded):
2234         (.WebInspector.InspectorControllerStub.prototype.localizedStringsURL):
2235         (.WebInspector.InspectorControllerStub.prototype.windowUnloading):
2236         (.WebInspector.InspectorControllerStub.prototype.hiddenPanels):
2237         (.WebInspector.InspectorControllerStub.prototype.debuggerEnabled):
2238         (.WebInspector.InspectorControllerStub.prototype.enableResourceTracking):
2239         (.WebInspector.InspectorControllerStub.prototype.disableResourceTracking):
2240         (.WebInspector.InspectorControllerStub.prototype.resourceTrackingEnabled):
2241         (.WebInspector.InspectorControllerStub.prototype.enableDebugger):
2242         (.WebInspector.InspectorControllerStub.prototype.disableDebugger):
2243         (.WebInspector.InspectorControllerStub.prototype.addBreakpoint):
2244         (.WebInspector.InspectorControllerStub.prototype.removeBreakpoint):
2245         (.WebInspector.InspectorControllerStub.prototype.updateBreakpoint):
2246         (.WebInspector.InspectorControllerStub.prototype.pauseInDebugger):
2247         (.WebInspector.InspectorControllerStub.prototype.pauseOnExceptions):
2248         (.WebInspector.InspectorControllerStub.prototype.setPauseOnExceptions):
2249         (.WebInspector.InspectorControllerStub.prototype.resumeDebugger):
2250         (.WebInspector.InspectorControllerStub.prototype.profilerEnabled):
2251         (.WebInspector.InspectorControllerStub.prototype.enableProfiler):
2252         (.WebInspector.InspectorControllerStub.prototype.disableProfiler):
2253         (.WebInspector.InspectorControllerStub.prototype.startProfiling):
2254         (.WebInspector.InspectorControllerStub.prototype.stopProfiling):
2255         (.WebInspector.InspectorControllerStub.prototype.getProfileHeaders):
2256         (.WebInspector.InspectorControllerStub.prototype.getProfile):
2257         (.WebInspector.InspectorControllerStub.prototype.takeHeapSnapshot):
2258         (.WebInspector.InspectorControllerStub.prototype.databaseTableNames):
2259         (.WebInspector.InspectorControllerStub.prototype.stepIntoStatementInDebugger):
2260         (.WebInspector.InspectorControllerStub.prototype.stepOutOfFunctionInDebugger):
2261         (.WebInspector.InspectorControllerStub.prototype.stepOverStatementInDebugger):
2262         (.WebInspector.InspectorControllerStub.prototype.setSetting):
2263         (.WebInspector.InspectorControllerStub.prototype.dispatchOnInjectedScript):
2264         (.WebInspector.InspectorControllerStub.prototype.releaseWrapperObjectGroup):
2265         (.WebInspector.InspectorControllerStub.prototype.setting):
2266         * inspector/front-end/inspector.html:
2267         * inspector/front-end/inspector.js:
2268         (WebInspector.UIString):
2269
2270 2009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2271
2272         Reviewed by Jan Alonzo.
2273
2274         https://bugs.webkit.org/show_bug.cgi?id=25897
2275         [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
2276
2277         Expands upon the new funtionality which allows platforms to indicate
2278         that a particular object should not be ignored, so that they can
2279         specify that an object should be ignored or that it should be left up
2280         to the default handling to decide.
2281
2282         * accessibility/AccessibilityObject.h:
2283         * accessibility/chromium/AccessibilityObjectChromium.cpp:
2284         * accessibility/gtk/AccessibilityObjectAtk.cpp:
2285         * accessibility/mac/AccessibilityObjectMac.mm:
2286         * accessibility/qt/AccessibilityObjectQt.cpp:
2287         * accessibility/win/AccessibilityObjectWin.cpp:
2288         * accessibility/wx/AccessibilityObjectWx.cpp:
2289         (AccessibilityObject::accessibilityPlatformIncludesObject):
2290         * accessibility/AccessibilityRenderObject.cpp:
2291         (AccessibilityRenderObject::accessibilityIsIgnored):
2292
2293
2294 2009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2295
2296         Reviewed by Jan Alonzo.
2297
2298         https://bugs.webkit.org/show_bug.cgi?id=25534
2299         [GTK] Objects of ROLE_TABLE should implement the accessible table interface
2300
2301         Expose the table summary as the accessible description because there is no summary object.
2302
2303         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2304         (webkit_accessible_get_description):
2305
2306 2009-10-28  Steve Block  <steveblock@google.com>
2307
2308         Reviewed by Eric Seidel.
2309
2310         Adds ScriptController::intializeThreading(), with both JSC and V8 implementations.
2311         https://bugs.webkit.org/show_bug.cgi?id=30678
2312
2313         This new method is used from common code, rather than calling JSC::initializeThreading() (or the V8 equivalent) directly.
2314
2315         Build fix, no new tests required.
2316
2317         * bindings/js/ScriptController.cpp: Modified.
2318         (WebCore::ScriptController::initializeThreading): Added.
2319         * bindings/js/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
2320         * bindings/v8/ScriptController.cpp: Modified.
2321         (WebCore::ScriptController::initializeThreading): Added.
2322         * bindings/v8/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
2323         * loader/icon/IconDatabase.cpp: Modified.
2324         (WebCore::iconDatabase): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().
2325         * storage/Database.cpp: Modified.
2326         (WebCore::Database::Database): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().
2327
2328 2009-10-26  Holger Hans Peter Freyther  <zecke@selfish.org>
2329
2330         Reviewed by Darin Adler.
2331
2332         Document a feature of the m_liveDecodedResources list.
2333         https://bugs.webkit.org/show_bug.cgi?id=30209
2334
2335         The code made the assumption that the list is sorted by
2336         the m_lastDecodedAccessTime property of the CachedResource.
2337         The above is not true when CachedResource::setDecodedSize
2338         is called and the item is inserted the first time. In this
2339         case the m_lastDecodedAccessTime is still zero and the
2340         m_liveDecodedResources list becomes unsorted.
2341
2342         It is impossible that Cache::pruneLiveResources will
2343         stop to process the list too early due this feature and
2344         the alternatives of updating m_lastDecodedAccessTime in
2345         CachedResource::setDecodedSize or changing the insert
2346         to search the right position have a negative impact on
2347         performance. The best solution for now is to document
2348         this feature.
2349
2350         * loader/Cache.cpp:
2351         (WebCore::Cache::pruneLiveResources):
2352         * loader/CachedResource.cpp:
2353         (WebCore::CachedResource::setDecodedSize):
2354
2355 2009-10-28  Xan Lopez  <xlopez@igalia.com>
2356
2357         Reviewed by Jan Alonzo.
2358
2359         [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
2360         https://bugs.webkit.org/show_bug.cgi?id=25897
2361
2362         Make text controls always implement the text interface, and the
2363         editable text interface when they are not read only. This is what
2364         ATK-users expect.
2365
2366         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2367         (getInterfaceMaskFromObject):
2368
2369 2009-10-27  Holger Hans Peter Freyther  <zecke@selfish.org>
2370
2371         Reviewed by Simon Fraser.
2372
2373         Change HitTestResult methods to use (3d) transformation aware methods
2374         https://bugs.webkit.org/show_bug.cgi?id=27347
2375
2376         The current HitTestResult methods are not using the (3d)
2377         transformation aware routines. This can lead to an assertion
2378         SVGRenderBase::mapLocalToContainer method.
2379
2380         Change HitTestResult::imageRect to use the (3d) transformation
2381         aware RenderBox::absoluteContentQuad to avoid running into
2382         an assertion with SVG content.
2383
2384         Remove HitTestResult::boundingBox() as it is only used in
2385         two places and conceptually doesn't belong into a HitTest
2386         which is operating on points.
2387
2388         A classic test case is not possible as the methods are not excercised
2389         from within HTML/SVG but from the WebKit API Layer. A unittest
2390         for Qt/Gtk+/Mac would need to be written but Qt/Gtk+ currently
2391         do not support 3d transformations making it impossible to write
2392         a reliable test case and the Mac port is currently not doing
2393         unit testing.
2394
2395
2396         * rendering/HitTestResult.cpp: Remove boundingBox() method
2397         (WebCore::HitTestResult::imageRect): Use transformation aware method
2398         * rendering/HitTestResult.h: Remove boundingBox()
2399
2400 2009-10-26  Holger Hans Peter Freyther  <zecke@selfish.org>
2401
2402         Reviewed by Eric Seidel.
2403
2404         [Qt] Custom Cursor doesn't use hotspot.
2405         https://bugs.webkit.org/show_bug.cgi?id=30820
2406
2407         Cursors loaded from a QPixmap didn't specifiy the
2408         hotspot. Take the hotspot values from the mac
2409         implementation.
2410
2411         * platform/qt/CursorQt.cpp:
2412
2413 2009-10-27  Pavel Feldman  <pfeldman@chromium.org>
2414
2415         Reviewed by Timothy Hatcher.
2416
2417         Web Inspector: Initial revision of the Timeline grid.
2418
2419         https://bugs.webkit.org/show_bug.cgi?id=30834
2420
2421         * English.lproj/localizedStrings.js:
2422         * WebCore.gypi:
2423         * inspector/front-end/AbstractTimelinePanel.js:
2424         (WebInspector.AbstractTimelinePanel.prototype.populateSidebar):
2425         (WebInspector.AbstractTimelinePanel.prototype.refresh):
2426         (WebInspector.AbstractTimelineCalculator):
2427         * inspector/front-end/Images/timelineBarBlue.png: Added.
2428         * inspector/front-end/Images/timelineBarGray.png: Added.
2429         * inspector/front-end/Images/timelineBarGreen.png: Added.
2430         * inspector/front-end/Images/timelineBarOrange.png: Added.
2431         * inspector/front-end/Images/timelineBarPurple.png: Added.
2432         * inspector/front-end/Images/timelineBarRed.png: Added.
2433         * inspector/front-end/Images/timelineBarYellow.png: Added.
2434         * inspector/front-end/Images/timelineCheckmarks.png: Added.
2435         * inspector/front-end/Images/timelineDots.png: Added.
2436         * inspector/front-end/ResourcesPanel.js:
2437         (WebInspector.ResourceTimeCalculator):
2438         (WebInspector.ResourceTransferSizeCalculator):
2439         * inspector/front-end/TimelineAgent.js:
2440         * inspector/front-end/TimelinePanel.js:
2441         (WebInspector.TimelinePanel):
2442         (WebInspector.TimelinePanel.prototype.get statusBarItems):
2443         (WebInspector.TimelinePanel.prototype.get categories):
2444         (WebInspector.TimelinePanel.prototype.populateSidebar):
2445         (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
2446         (WebInspector.TimelinePanel.prototype.addItemToTimeline):
2447         (WebInspector.TimelinePanel.prototype.refresh):
2448         (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClick):
2449         (WebInspector.TimelinePanel.prototype.reset):
2450         (WebInspector.TimelinePanel.prototype._formatRecord):
2451         (WebInspector.TimelinePanel.prototype.showCategory):
2452         (WebInspector.TimelinePanel.prototype.hideCategory):
2453         (WebInspector.TimelineRecordTreeElement):
2454         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
2455         (WebInspector.TimelineCalculator):
2456         (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
2457         (WebInspector.TimelineCalculator.prototype.computePercentageFromEventTime):
2458         (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels):
2459         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
2460         (WebInspector.TimelineCalculator.prototype.formatValue):
2461         (WebInspector.TimelineGraph):
2462         (WebInspector.TimelineGraph.prototype.get graphElement):
2463         (WebInspector.TimelineGraph.prototype.refreshLabelPositions):
2464         (WebInspector.TimelineGraph.prototype.refresh):
2465         * inspector/front-end/inspector.css:
2466         * inspector/front-end/inspector.js:
2467         (WebInspector._createPanels):
2468
2469 2009-10-27  Joseph Pecoraro  <joepeck@webkit.org>
2470
2471         Reviewed by Pavel Feldman.
2472
2473         Web Inspector: Move runAfterPendingDispatches to TestController for Clarity
2474         https://bugs.webkit.org/show_bug.cgi?id=30844
2475
2476         * inspector/front-end/TestController.js:
2477         (WebInspector.TestController.prototype.runAfterPendingDispatches):
2478         * inspector/front-end/inspector.js: moved runAfterPendingDispatches
2479
2480 2009-10-27  Darin Fisher  <darin@chromium.org>
2481
2482         Reviewed by Dimitri Glazkov.
2483
2484         Add missing forward declaration of FramelessScrollView.
2485         https://bugs.webkit.org/show_bug.cgi?id=30824
2486
2487         * platform/chromium/FramelessScrollViewClient.h:
2488
2489 2009-10-27  Chris Fleizach  <cfleizach@apple.com>
2490
2491         Reviewed by Adele Peterson.
2492
2493         WAI-ARIA: add support for 'presentation' role
2494         https://bugs.webkit.org/show_bug.cgi?id=30806
2495
2496         Test: accessibility/aria-presentational-role.html
2497
2498         * accessibility/AccessibilityObject.h:
2499         (WebCore::):
2500         * accessibility/AccessibilityRenderObject.cpp:
2501         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2502         (WebCore::RoleEntry::):
2503
2504 2009-10-27  Chris Fleizach  <cfleizach@apple.com>
2505
2506         Reviewed by Darin Adler.
2507
2508         ARIA menu/menu item need AXRoleDescription
2509         https://bugs.webkit.org/show_bug.cgi?id=30804
2510
2511         Make sure that role descriptions will default to the system's first, before
2512         returning an unknown role.
2513
2514         Test: platform/mac/accessibility/aria-menu-role-descriptions.html
2515
2516         * accessibility/mac/AccessibilityObjectWrapper.mm:
2517         (-[AccessibilityObjectWrapper roleDescription]):
2518
2519 2009-10-27  Geoffrey Garen  <ggaren@apple.com>
2520
2521         Qt build fix: migrated away from API that no longer exists.
2522
2523         * bridge/qt/qt_runtime.cpp:
2524         (JSC::Bindings::convertQVariantToValue):
2525
2526 2009-10-27  Geoffrey Garen  <ggaren@apple.com>
2527
2528         Qt build fix: migrated away from API that no longer exists.
2529
2530         * bridge/qt/qt_runtime.cpp:
2531         (JSC::Bindings::convertValueToQVariant):
2532
2533 2009-10-27  Oliver Hunt  <oliver@apple.com>
2534
2535         Fix wording in comment.
2536
2537         * bridge/objc/objc_instance.mm:
2538         (allocateAutoReleasePool):
2539
2540 2009-10-27  Oliver Hunt  <oliver@apple.com>
2541
2542         Reviewed by Darin Adler.
2543
2544         Crash occurs after launching Newsfire 1.6 for the first time
2545         https://bugs.webkit.org/show_bug.cgi?id=30807
2546
2547         We allocate an autorelease pool but then store it off the stack. In a
2548         GC environment this led to it being collected, and thus caused badness
2549         to ensue.  To work around this we simply avoid using a pool at all in
2550         a GC environment as it would be a no-op anyway.
2551
2552         * bridge/objc/objc_instance.mm:
2553         (allocateAutoReleasePool):
2554         (ObjcInstance::virtualBegin):
2555
2556 2009-10-27  Steve Block  <steveblock@google.com>
2557
2558         Reviewed by Darin Adler.
2559
2560         When a Geolocation method is called, immediately calls the error calback asynchronously if permissions
2561         have already been denied.
2562         https://bugs.webkit.org/show_bug.cgi?id=27944.
2563
2564         Tests: fast/dom/Geolocation/permission-denied-already-error.html
2565                fast/dom/Geolocation/permission-denied-already-success.html
2566
2567         * page/Geolocation.cpp: Modified.
2568         (WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. GeoNotifier takes Geolocation object as constructor argument.
2569         (WebCore::Geolocation::GeoNotifier::setFatalError): Added. Sets a fatal error for this notifier, causing it to terminate immediately and call the error callback asynchronously.
2570         (WebCore::Geolocation::GeoNotifier::timerFired): Added. Used to call the error callback asynchronously on fatal error.
2571         (WebCore::Geolocation::getCurrentPosition): Modified. Calls startRequest.
2572         (WebCore::Geolocation::watchPosition): Modified. Calls startRequest.
2573         (WebCore::Geolocation::startRequest): Added. Common functionality for starting a one-shot or watch request. Sets a fatal error on the notifier if permissions have already been denied.
2574         (WebCore::Geolocation::fatalErrorOccurred): Added. Registers that a notifier has encountered a fatal error and should be destroyed.
2575         (WebCore::Geolocation::setIsAllowed): Modified. Uses a standard error message for the error callback when permissions are denied.
2576         * page/Geolocation.h: Modified.
2577         (WebCore::Geolocation::isDenied): Added. Determines whether permissions have been denied.
2578
2579 2009-10-27  Chris Marrin  <cmarrin@apple.com>
2580
2581         Reviewed by Oliver Hunt.
2582
2583         Fixed a bug where I was using the wrong Canvas pointer to do a cross-domain check
2584         https://bugs.webkit.org/show_bug.cgi?id=30840
2585
2586         * html/canvas/CanvasRenderingContext2D.cpp:
2587         (WebCore::CanvasRenderingContext2D::drawImage):
2588
2589 2009-10-27  Eric Seidel  <eric@webkit.org>
2590
2591         Reviewed by Nikolas Zimmermann.
2592
2593         SVGStyledElement::getPresentationAttribute() can return a shared CSSValue (some SVG tests randomly fail on the bot, and in release builds)
2594         https://bugs.webkit.org/show_bug.cgi?id=29620
2595
2596         SVG was modifying CSSValues cached of off CSSMappedAttributeDeclarations.
2597         This patch fixes the check to make sure that a new CSSMappedAttributeDeclaration is
2598         created before returning a CSSValue that JavaScript can modify.
2599
2600         Test: svg/dom/getPresentationAttribute-cache-corruption.svg
2601
2602         * svg/SVGStyledElement.cpp:
2603         (WebCore::SVGStyledElement::getPresentationAttribute):
2604
2605 2009-10-27  Dan Bernstein  <mitz@apple.com>
2606
2607         Reviewed by Simon Fraser.
2608
2609         Incomplete repaint of text field in relative positioned inline at imdb.com
2610         https://bugs.webkit.org/show_bug.cgi?id=30047
2611
2612         Test: fast/repaint/inline-relative-positioned.html
2613
2614         Implemented offsetFromContainer(), mapLocalToContainer() and
2615         mapAbsoluteToLocalPoint() in RenderInline.
2616
2617         * rendering/RenderBox.h: Fixed argument names in the declaration of
2618         mapLocalToContainer().
2619         * rendering/RenderInline.cpp:
2620         (WebCore::RenderInline::offsetFromContainer):
2621         (WebCore::RenderInline::mapLocalToContainer):
2622         (WebCore::RenderInline::mapAbsoluteToLocalPoint):
2623         * rendering/RenderInline.h:
2624
2625 2009-10-27  Jeremy Orlow  <jorlow@chromium.org>
2626
2627         Speculative build fix for Chromium.
2628
2629         * platform/graphics/GraphicsContext3D.h:
2630
2631 2009-10-27  Chris Marrin  <cmarrin@apple.com>
2632
2633         Reviewed by Simon Fraser.
2634         
2635         Make WebGL context failure more robust and make it succeed in more cases
2636         https://bugs.webkit.org/show_bug.cgi?id=30349
2637
2638         Bubble a failure to get a CGLContext up to HTMLContextElement so it can
2639         return null from getContext. Also added a more robust pixel format choosing 
2640         mechanism and can render correctly when a SW renderer is chosen.
2641
2642         * html/HTMLCanvasElement.cpp:
2643         (WebCore::HTMLCanvasElement::getContext):
2644         * html/canvas/CanvasRenderingContext.h:
2645         * html/canvas/CanvasRenderingContext2D.cpp:
2646         * html/canvas/CanvasRenderingContext3D.cpp:
2647         * html/canvas/CanvasRenderingContext3D.h:
2648         (WebCore::CanvasRenderingContext3D::graphicsContext3D):
2649         (WebCore::CanvasRenderingContext3D::cleanupAfterGraphicsCall):
2650         * platform/graphics/GraphicsContext3D.h:
2651         * platform/graphics/mac/Canvas3DLayer.mm:
2652         (-[Canvas3DLayer copyCGLPixelFormatForDisplayMask:]):
2653         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2654         (WebCore::setPixelFormat):
2655         (WebCore::GraphicsContext3D::create):
2656         (WebCore::GraphicsContext3D::GraphicsContext3D):
2657         (WebCore::GraphicsContext3D::~GraphicsContext3D):
2658         (WebCore::GraphicsContext3D::reshape):
2659         (WebCore::ensureContext):
2660
2661 2009-10-27  Geoffrey Garen  <ggaren@apple.com>
2662
2663         Mac build fix: a forwarding header.
2664
2665         * ForwardingHeaders/wtf/DateInstanceCache.h: Added.
2666
2667 2009-10-27  Ryosuke Niwa  <rniwa@webkit.org>
2668
2669         No Review.
2670
2671         Making fontWeightIsBold static to fix Snow Leopard build.
2672
2673         * editing/ApplyStyleCommand.cpp:
2674         (WebCore::fontWeightIsBold):
2675
2676 2009-10-27  Ryosuke Niwa  <rniwa@webkit.org>
2677
2678         Reviewed by Eric Seidel.
2679
2680         WebKit cannot remove nested bold tags
2681         https://bugs.webkit.org/show_bug.cgi?id=30784
2682
2683         This patch modifies getPropertiesNotInComputedStyle so that it compares font-weight
2684         more flexibly. Instead of comparing cssText, it uses fontWeightIsBold which converts
2685         all font weights to either bold or unbold state.
2686
2687         * editing/ApplyStyleCommand.cpp:
2688         (WebCore::fontWeightIsBold):
2689         (WebCore::getPropertiesNotInComputedStyle): Removes font-weight property
2690         if two style have the same value under getFontWeightValue
2691
2692 2009-10-27  Carol Szabo  <carol.szabo@nokia.com>
2693
2694         Reviewed by Darin Adler.
2695
2696         Give an ability to WebKit to free statically allocated pointers
2697         before quit.
2698         https://bugs.webkit.org/show_bug.cgi?id=27980
2699
2700         No new tests for this as the change does not affect WebKit
2701         functionality, but only memory usage.
2702
2703         * JavaScriptCore/wtf/StdLibExtras.h:
2704         Allowed for the override of DEFINE_STATIC_LOCAL via compiler 
2705         commandline options or elsewhere in the code. Useful for 
2706         implementing custom builds that free resources allocated via
2707         DEFINE_STATIC_LOCAL.
2708
2709 2009-10-27  Dumitru Daniliuc  <dumi@chromium.org>
2710
2711         Build fix, no review needed.
2712
2713         Fixing the BUILD. m_estimatedSize in Database.h should be of type
2714         'unsigned long' instead of 'unsigned long long'.
2715
2716         No tests required.
2717
2718         * storage/Database.h:
2719
2720 2009-10-27  Dumitru Daniliuc  <dumi@chromium.org>
2721
2722         Reviewed by Adam Barth.
2723
2724         Refactoring the Database class to not depend on
2725         OriginQuotaManager. Also, adding a SecurityOrigin copy to each
2726         Database instance, that is safe to use on the file
2727         thread. Finally, adding new simple fields and getters to the
2728         Database object for storing/getting the display name and estimated
2729         size specified by the user in the openDatabase() call.
2730
2731         https://bugs.webkit.org/show_bug.cgi?id=30548
2732
2733         * page/SecurityOrigin.h:
2734         * storage/Database.cpp:
2735         (WebCore::Database::openDatabase): Storing the display name and
2736         the estimated size in the Database object.
2737         (WebCore::Database::Database): Storing the display name and the
2738         estimated size in the Database object, as well as a SecurityOrigin
2739         instance that is safe to use on the DB thread.
2740         (WebCore::Database::maximumSize): Delegate the call to
2741         DatabaseTracker::getMaxSizeForDatabase().
2742         (WebCore::Database::databaseThreadSecurityOrigin): Return the
2743         SecurityOrigin instance that's safe to use on the DB thread.
2744         (WebCore::Database::threadSafeSecurityOrigin): Return the
2745         SecurityOrigin instance that's safe to use on the current thread.
2746         (WebCore::Database::displayName): Return the display name
2747         specified by the user in the openDatabase() call.
2748         (WebCore::Database::estimatedSize): Return the estimated size
2749         specified by the user in the openDatabase() call.
2750         (WebCore::Database::fileName): Return the name of the file where
2751         the current Database is tored.
2752         * storage/Database.h:
2753         * storage/DatabaseTracker.cpp:
2754         (WebCore::DatabaseTracker::getMaxSizeForDatabase): Returns the
2755         maximum size for a DB file based on the current size of that file
2756         and the space available for that origin.
2757         * storage/DatabaseTracker.h:
2758         * storage/SQLTransaction.cpp:
2759         * storage/SQLTransactionClient.cpp:
2760         (WebCore::SQLTransactionClient::didCommitTransaction): Use the
2761         correct SecurityOrigin instance.
2762
2763 2009-10-27  Joseph Pecoraro  <joepeck@webkit.org>
2764
2765         Reviewed by Timothy Hatcher.
2766
2767         Web Inspector: Pretty Print all HTML Collection Types like we do for NodeList
2768         https://bugs.webkit.org/show_bug.cgi?id=30709
2769
2770         Test: inspector/console-format-collections.html
2771
2772         * inspector/front-end/InjectedScript.js:
2773         (Object.type): check for instances of HTMLCollection like we do for NodeList
2774         * inspector/front-end/inspector.js: added WebInspector.pendingDispatches counter
2775         (WebInspector.dispatch): increment and decrement dispatch counter
2776         (WebInspector.runAfterPendingDispatches): run when there are no more dispatches
2777
2778 2009-10-27  Kelly Norton  <knorton@google.com>
2779
2780         Reviewed by Timothy Hatcher.
2781
2782         Adds XMLHttpRequest support to InspectorTimelineAgent.
2783         https://bugs.webkit.org/show_bug.cgi?id=30578
2784
2785         * inspector/InspectorTimelineAgent.cpp:
2786         (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
2787         (WebCore::InspectorTimelineAgent::didChangeXHRReadyState):
2788         (WebCore::InspectorTimelineAgent::willLoadXHR):
2789         (WebCore::InspectorTimelineAgent::didLoadXHR):
2790         * inspector/InspectorTimelineAgent.h:
2791         (WebCore::):
2792         * inspector/TimelineRecordFactory.cpp:
2793         (WebCore::TimelineRecordFactory::createXHRReadyStateChangeTimelineRecord):
2794         (WebCore::TimelineRecordFactory::createXHRLoadTimelineRecord):
2795         * inspector/TimelineRecordFactory.h:
2796         * inspector/front-end/TimelineAgent.js:
2797         * xml/XMLHttpRequest.cpp:
2798         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
2799
2800 2009-10-27  Enrica Casucci  <enrica@apple.com>
2801
2802         Reviewed by Adele Peterson.
2803
2804         REGRESSION (Safari 4.0.3-ToT): After pressing Shift-PageDown, pressing Shift-Up 
2805         extends the top of the selection upwards (but should shrink the selection instead)
2806         <rdar://problem/7269075>
2807         https://bugs.webkit.org/show_bug.cgi?id=29981
2808
2809         * editing/SelectionController.cpp:
2810         (WebCore::SelectionController::modify): Added setting m_lastChangeWasHorizontalExtension.
2811
2812 2009-10-27  Brian Weinstein  <bweinstein@apple.com>
2813
2814         Rubber-stamped by Tim Hatcher.
2815         
2816         Removed an extra console.log from ElementsTreeOutline.
2817
2818         * inspector/front-end/ElementsTreeOutline.js:
2819
2820 2009-10-27  Keishi Hattori  <casey.hattori@gmail.com>
2821
2822         Reviewed by Timothy Hatcher.
2823
2824         Rewrote JavaScriptSourceSyntaxHighlighter to be more accurate
2825         https://bugs.webkit.org/show_bug.cgi?id=27147
2826
2827         Tests: LayoutTests/inspector/javascript-syntax-highlight.html
2828
2829         * inspector/front-end/ElementsTreeOutline.js:
2830         * inspector/front-end/SourceFrame.js:
2831         (WebInspector.JavaScriptSourceSyntaxHighlighter.process): Added. Processes 100 tokens at a time.
2832         (WebInspector.JavaScriptSourceSyntaxHighlighter.lex): Added. Scans for a token.
2833         (WebInspector.JavaScriptSourceSyntaxHighlighter.appendNonToken): Added. Appends the non-token characters that lex ignored.
2834         (WebInspector.JavaScriptSourceSyntaxHighlighter.syntaxHighlightNode): Added. To syntax highlight node in ElementsTreeOutline.
2835
2836 2009-10-27  Mads Ager  <ager@chromium.org>
2837
2838         Reviewed by Adam Barth.
2839
2840         [V8] Missing null check after string conversion in error reporting
2841         https://bugs.webkit.org/show_bug.cgi?id=30774
2842
2843         Add null check after string conversion in error reporting code.
2844         ToString conversion can fail for instance when an exception is
2845         thrown during conversion.
2846
2847         Test: fast/dom/error-to-string-stack-overflow.html
2848
2849         * bindings/v8/V8Utilities.cpp:
2850         (WebCore::reportException):
2851
2852 2009-10-27  Steve Block  <steveblock@google.com>
2853
2854         Reviewed by Darin Adler.
2855
2856         Use a pair of maps to store Geolocation watchers.
2857         https://bugs.webkit.org/show_bug.cgi?id=29178
2858
2859         The pair of maps allows us to look up a watcher either by its ID or by its GeoNotifier object.
2860         The ability to look up by a watcher by its GeoNotifier object will be required when implementing
2861         Geolocation::fatalErrorOccurred. See https://bugs.webkit.org/show_bug.cgi?id=27944
2862
2863         * page/Geolocation.cpp: Modified.
2864         (WebCore::Geolocation::Watchers::set): Added. Adds a watcher with the given ID.
2865         (WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by ID.
2866         (WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by GeoNotifier object.
2867         (WebCore::Geolocation::Watchers::clear): Added. Removes all watchers.
2868         (WebCore::Geolocation::Watchers::isEmpty): Added. Determines if there are no watchers.
2869         (WebCore::Geolocation::Watchers::getNotifiersVector): Added. Gets a vector of the GeoNotifier objects.
2870         (WebCore::Geolocation::watchPosition): Modified. Rename watcher identifier static variable.
2871         (WebCore::Geolocation::stopTimersForWatchers): Modified. Use Watchers::getNotifiersVector.
2872         (WebCore::Geolocation::handleError): Modified. Use Watchers::getNotifiersVector.
2873         (WebCore::Geolocation::makeSuccessCallbacks): Modified. Use Watchers::getNotifiersVector.
2874         * page/Geolocation.h: Modified. Adds Geolocation::Watchers class.
2875
2876 2009-10-27  Jeremy Orlow  <jorlow@chromium.org>
2877
2878         Reviewed by Dimitri Glazkov.
2879
2880         [V8] DOM Storage runtime flag should default to on
2881         https://bugs.webkit.org/show_bug.cgi?id=30828
2882
2883         The DOM Storage runtime flag was supposed to default to on.  I accidentally
2884         changed the logic to default to false when I moved the flag.
2885
2886         * bindings/v8/RuntimeEnabledFeatures.cpp:
2887
2888 2009-10-27  Fumitoshi Ukai  <ukai@chromium.org>
2889
2890         Reviewed by Dimitri Glazkov.
2891
2892         Fix crash found in chromium test_shell.
2893         https://bugs.webkit.org/show_bug.cgi?id=30808
2894
2895         When WebSocket is deleted without close, webkit would crash
2896         when it handles didClose.
2897
2898         Check scriptExecutionContext before post task for event.
2899         Use WebSocketChannel::disconnect() instead of close() in WebSocket
2900         destructor, so that WebSocketChannel should not call deleted WebSocket
2901         back in didClose().
2902         To make sure WebSocketChannel alive while it is processing WebSocket
2903         protocol over SocketStreamHandle, ref() in connect() and deref() in
2904         didClose().
2905
2906         * websockets/WebSocket.cpp:
2907         (WebCore::WebSocket::~WebSocket):
2908         (WebCore::WebSocket::didConnect):
2909         (WebCore::WebSocket::didReceiveMessage):
2910         (WebCore::WebSocket::didClose):
2911         * websockets/WebSocketChannel.cpp:
2912         (WebCore::WebSocketChannel::connect):
2913         (WebCore::WebSocketChannel::disconnect):
2914         (WebCore::WebSocketChannel::didClose):
2915         (WebCore::WebSocketChannel::didReceiveData):
2916         * websockets/WebSocketChannel.h:
2917
2918 2009-10-27  Dan Bernstein  <mitz@apple.com>
2919
2920         Reviewed by Darin Adler.
2921
2922         Updated Apple license
2923
2924         * LICENSE-APPLE:
2925
2926 2009-10-27  Brady Eidson  <beidson@apple.com>
2927
2928         Rubberstamped by Sam Weinig.
2929
2930         Re-enable the check that disallows pages with unload handlers in the page cache.
2931
2932         <rdar://problem/7196485> and http://webkit.org/b/29021 
2933
2934         * loader/FrameLoader.cpp:
2935         (WebCore::FrameLoader::canCachePageContainingThisFrame):
2936         (WebCore::FrameLoader::logCanCacheFrameDecision):
2937
2938 2009-10-27  Timothy Hatcher  <timothy@apple.com>
2939
2940         Remove more empty files that didn't get removed earlier.
2941
2942         * inspector/DOMDispatchTimelineItem.cpp: Removed.
2943         * inspector/DOMDispatchTimelineItem.h: Removed.
2944
2945 2009-10-27  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2946
2947         Reviewed by Tor Arne Vestbø.
2948
2949         [Qt] Fix assertion crashes introduced by changes made in r50110.
2950
2951         * dom/XMLTokenizerQt.cpp:
2952         (WebCore::XMLTokenizer::parseEndElement): only call popCurrentNode() if there are nodes left in the stack.
2953
2954 2009-10-27  Timothy Hatcher  <timothy@apple.com>
2955
2956         Remove empty files that didn't get removed earlier.
2957
2958         * inspector/TimelineItem.cpp: Removed.
2959         * inspector/TimelineItem.h: Removed.
2960
2961 2009-10-27  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2962
2963         Reviewed by Xan Lopez.
2964
2965         https://bugs.webkit.org/show_bug.cgi?id=25534
2966         [GTK] Objects of ROLE_TABLE should implement the accessible table interface
2967
2968         First part of the implementation of AtkTable.
2969
2970         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2971         (getCell):
2972         (getCellIndex):
2973         (webkit_accessible_table_ref_at):
2974         (webkit_accessible_table_get_index_at):
2975         (webkit_accessible_table_get_n_columns):
2976         (webkit_accessible_table_get_n_rows):
2977         (webkit_accessible_table_get_column_extent_at):
2978         (webkit_accessible_table_get_row_extent_at):
2979         (webkit_accessible_table_get_row_header):
2980         (atk_table_interface_init):
2981         (AtkInterfacesInitFunctions):
2982         (GetAtkInterfaceTypeFromWAIType):
2983
2984 2009-10-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2985
2986         Reviewed by Lars Knoll.
2987
2988         [Qt] Don't lose remainder when computing wheel event deltas
2989
2990         * platform/qt/WheelEventQt.cpp:
2991
2992 2009-10-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2993
2994         Reviewed by Antti Koivisto.
2995
2996         Fix QtWebKit build for WIN_OS if Netscape plug-in support
2997         is turned off and refactor some related code
2998         https://bugs.webkit.org/show_bug.cgi?id=30786
2999
3000         No new tests as there is no new functionality introduced.
3001
3002         * platform/FileSystem.h: Refactor to make sure that each different
3003         type definition is only repeated once.
3004
3005         * plugins/PluginPackage.cpp:
3006         (WebCore::PluginPackage::compareFileVersion): Move it out from the
3007         ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH guard and combine it with the
3008         function body from PluginPackageWin.
3009
3010         * plugins/win/PluginPackageWin.cpp: Remove compareFileVersion as
3011         it is now in PluginPackage.cpp.
3012
3013 2009-10-26  Xan Lopez  <xlopez@igalia.com>
3014
3015         Reviewed by Gustavo Noronha.
3016
3017         https://bugs.webkit.org/show_bug.cgi?id=27011
3018         [Gtk] Implement support for get_index_in_parent
3019
3020         Implement atk_object_get_index_in_parent.
3021
3022         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3023         (webkit_accessible_get_index_in_parent):
3024
3025 2009-10-27  Eric Seidel  <eric@webkit.org>
3026
3027         No review, rolling out r50131.
3028         http://trac.webkit.org/changeset/50131
3029
3030         * bridge/objc/objc_instance.h:
3031         * bridge/objc/objc_instance.mm:
3032         (ObjcInstance::ObjcInstance):
3033         (ObjcInstance::virtualEnd):
3034
3035 2009-10-26  Daniel Bates  <dbates@webkit.org>
3036
3037         Reviewed by Darin Adler.
3038
3039         https://bugs.webkit.org/show_bug.cgi?id=30491
3040
3041         Fixes an issue where pressing return/enter on the keyboard 
3042         in <isindex> does not submit it if is not within a <form>.
3043
3044         According to the HTML 2.0 thru HTML 4.01 spec 
3045         (http://www.w3.org/MarkUp/html-spec/html-spec_7.html#SEC7.5), the 
3046         <isindex> element does not need to be within a <form> element in 
3047         order to submit it. It can submitted on its own. Also, if present,
3048         the href property of the <base> element will dictate where to submit
3049         the value of the <isindex> element (this is analogous to the action 
3050         property of the <form> element).
3051
3052         Tests: http/tests/misc/isindex-with-no-form-base-href.html
3053                http/tests/misc/isindex-with-no-form.html
3054
3055         * html/HTMLInputElement.cpp:
3056         (WebCore::HTMLInputElement::defaultEventHandler): Calls createTemporaryFormForIsIndex()
3057         to create a <form> if none is present and we are an <isindex> element.
3058         (WebCore::HTMLInputElement::createTemporaryFormForIsIndex): Added.
3059         * html/HTMLInputElement.h:
3060
3061 2009-10-26  Oliver Hunt  <oliver@apple.com>
3062
3063         Reviewed by Maciej Stachowiak.
3064
3065         Crash occurs after launching Newsfire 1.6 for the first time
3066         https://bugs.webkit.org/show_bug.cgi?id=30807
3067
3068         Use a RetainPtr in ObjcBinding to ensure that we adequately
3069         protect the autorelease pool from GC in GC'd applications.
3070
3071         * bridge/objc/objc_instance.h:
3072         * bridge/objc/objc_instance.mm:
3073         (ObjcInstance::ObjcInstance):
3074         (ObjcInstance::virtualEnd):
3075
3076 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3077
3078         Unreviewed.
3079
3080         [Qt] Build fix for QtWebKit after r50125.
3081
3082         * WebCore.pro: Rename TimelineItem to TimelineRecord.
3083
3084 2009-10-26  Matt Mueller  <mattm@chromium.org>
3085
3086         Reviewed by Darin Adler.
3087
3088         Refactor synchronizable property handling to store one shouldSynchronize flag per set of properties rather than one per property.
3089
3090         Fixes reading uninitialized memory in SynchronizableProperty hash function as well as simplifying the code.
3091
3092         https://bugs.webkit.org/show_bug.cgi?id=30658
3093
3094         Covered by running various svg tests under valgrind, ex:
3095         LayoutTests/svg/custom/js-late-mask-and-object-creation.svg
3096
3097         * svg/SynchronizablePropertyController.cpp:
3098         (WebCore::SynchronizableProperties::addProperty):
3099         (WebCore::SynchronizableProperties::synchronize):
3100         (WebCore::SynchronizableProperties::startAnimation):
3101         (WebCore::SynchronizableProperties::stopAnimation):
3102         (WebCore::SynchronizablePropertyController::registerProperty):
3103         (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization):
3104         (WebCore::SynchronizablePropertyController::synchronizeProperty):
3105         (WebCore::SynchronizablePropertyController::synchronizeAllProperties):
3106         (WebCore::SynchronizablePropertyController::startAnimation):
3107         (WebCore::SynchronizablePropertyController::stopAnimation):
3108         * svg/SynchronizablePropertyController.h:
3109         (WebCore::SynchronizableProperties::SynchronizableProperties):
3110         (WebCore::SynchronizableProperties::setNeedsSynchronization):
3111
3112 2009-10-26  Kelly Norton  <knorton@google.com>
3113
3114         Reviewed by Timothy Hatcher.
3115
3116         Renames TimelineItem to TimelineRecord and updates all call sites.
3117         https://bugs.webkit.org/show_bug.cgi?id=30785
3118
3119         * GNUmakefile.am: 
3120         * WebCore.gypi:
3121         * WebCore.vcproj/WebCore.vcproj:
3122         * WebCore.xcodeproj/project.pbxproj:
3123         * inspector/InspectorFrontend.cpp:
3124         (WebCore::InspectorFrontend::addRecordToTimeline):
3125         * inspector/InspectorFrontend.h:
3126         * inspector/InspectorTimelineAgent.cpp:
3127         (WebCore::InspectorTimelineAgent::willDispatchDOMEvent):
3128         (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
3129         (WebCore::InspectorTimelineAgent::willLayout):
3130         (WebCore::InspectorTimelineAgent::didLayout):
3131         (WebCore::InspectorTimelineAgent::willRecalculateStyle):
3132         (WebCore::InspectorTimelineAgent::didRecalculateStyle):
3133         (WebCore::InspectorTimelineAgent::willPaint):
3134         (WebCore::InspectorTimelineAgent::didPaint):
3135         (WebCore::InspectorTimelineAgent::willWriteHTML):
3136         (WebCore::InspectorTimelineAgent::didWriteHTML):
3137         (WebCore::InspectorTimelineAgent::didInstallTimer):
3138         (WebCore::InspectorTimelineAgent::didRemoveTimer):
3139         (WebCore::InspectorTimelineAgent::willFireTimer):
3140         (WebCore::InspectorTimelineAgent::didFireTimer):
3141         (WebCore::InspectorTimelineAgent::reset):
3142         (WebCore::InspectorTimelineAgent::addRecordToTimeline):
3143         (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
3144         (WebCore::InspectorTimelineAgent::pushCurrentRecord):
3145         * inspector/InspectorTimelineAgent.h:
3146         (WebCore::):
3147         (WebCore::InspectorTimelineAgent::RecordEntry::RecordEntry):
3148         * inspector/TimelineItemFactory.cpp: Removed.
3149         * inspector/TimelineItemFactory.h: Removed.
3150         * inspector/TimelineRecordFactory.cpp: Added.
3151         (WebCore::TimelineRecordFactory::createGenericRecord):
3152         (WebCore::TimelineRecordFactory::createDOMDispatchRecord):
3153         (WebCore::TimelineRecordFactory::createGenericTimerRecord):
3154         (WebCore::TimelineRecordFactory::createTimerInstallRecord):
3155         * inspector/TimelineRecordFactory.h: Added.
3156         (WebCore::TimelineRecordFactory::TimelineRecordFactory):
3157         * inspector/front-end/TimelineAgent.js:
3158         (WebInspector.addRecordToTimeline):
3159         * inspector/front-end/TimelinePanel.js:
3160         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
3161         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
3162         (WebInspector.TimelinePanel.prototype.getRecordTypeName):
3163         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3164
3165 2009-10-26  Girish Ramakrishnan  <girish@forwardbias.in>
3166
3167         Reviewed by Antti Koivisto.
3168
3169         [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled
3170         
3171         When printing, QPrinter's preview mode uses a QPicture to capture the output. The
3172         QPicture holds a reference to the X Pixmap. As a result, the print preview would
3173         update itself when the X Pixmap changes. To prevent the print preview from updating
3174         whenever m_drawable is updated (i.e when the view updates), we create a copy.
3175         
3176         We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap
3177         regardless of the graphicssystem. This is taken care of by
3178         commit d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6)
3179         
3180         The beauty of this patch is that the newly created X Pixmap is managed by Qt and
3181         it will free the Pixmap whenever the user closes the print preview dialog and
3182         handles the case of displaying multiple preview dialogs nicely.
3183         
3184         All credit to Samuel Rødal for suggesting usage of QPixmap::copy().
3185         
3186         https://bugs.webkit.org/show_bug.cgi?id=30714
3187
3188         * plugins/qt/PluginViewQt.cpp:
3189         (WebCore::PluginView::paint):
3190
3191 2009-10-26  Benjamin Otte  <otte@gnome.org>
3192
3193         Reviewed by Gustavo Noronha.
3194
3195         Don't store properties in the MediaPlayerPrivate class
3196
3197         Access them via the MediaPlayer class instead.
3198         https://bugs.webkit.org/show_bug.cgi?id=30462
3199
3200         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3201         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
3202         (WebCore::MediaPlayerPrivate::seek):
3203         (WebCore::MediaPlayerPrivate::setVolume):
3204         (WebCore::MediaPlayerPrivate::setRate):
3205         (WebCore::MediaPlayerPrivate::setVisible):
3206         (WebCore::MediaPlayerPrivate::paint):
3207         (WebCore::MediaPlayerPrivate::createGSTPlayBin):
3208         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
3209
3210 2009-10-26  Brian Weinstein  <bweinstein@apple.com>
3211
3212         Reviewed by Timothy Hatcher.
3213
3214         Fixes <http://webkit.org/b/30801>.
3215         Web Inspector: Control + ]/[ on Windows doesn't change Panels.
3216         
3217         In my testing, Windows uses "U+00DB" and "U+00DD" to represent
3218         [ and ], so we should honor those as well.
3219
3220         * inspector/front-end/inspector.js:
3221         (WebInspector.documentKeyDown):
3222
3223 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3224
3225         Reviewed by Darin Adler.
3226
3227         Make .rc files compile on Windows without depending on MFC headers
3228         https://bugs.webkit.org/show_bug.cgi?id=30750
3229
3230         * WebCore.vcproj/QTMovieWin.rc: Use winresrc.h because it exists 
3231         even when MFC is not installed, and is all that's needed here.
3232
3233 2009-10-26  Brent Fulgham  <bfulgham@webkit.org>
3234
3235         Reviewed by Darin Adler.
3236
3237         Build corrections for ENABLE_FILTERS in Windows.
3238         https://bugs.webkit.org/show_bug.cgi?id=30797
3239
3240         Build correction for ENABLE_FILTERS feature.  No new tests needed.
3241
3242         * platform/graphics/filters/FEColorMatrix.cpp: Use MathExtras.h and
3243           its piDouble constant.
3244         * platform/graphics/filters/FEGaussianBlur.cpp: Use MathExtras.h and
3245           its piDouble constant.  Remove unnecessary call to floor used in
3246           the division of an unsigned, converting to int.
3247         * platform/graphics/win/SimpleFontDataCairoWin.cpp: Correct include
3248           style for MathExtras.h.
3249
3250 2009-10-26  Brady Eidson  <beidson@apple.com>
3251
3252         Reviewed by Darin Adler.
3253
3254         <rdar://problem/7289467> and http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load.
3255
3256         Test: fast/loader/grandparent-completion-starts-redirect.html
3257
3258         * loader/FrameLoader.cpp:
3259         (WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children.
3260
3261 2009-10-26  Dan Bernstein  <mitz@apple.com>
3262
3263         Reviewed by Beth Dakin.
3264
3265         Re-add CSSPropertyWebkitBackgroundSize in one more place
3266
3267         Fixes transitions/multiple-background-size-transitions.html, transitions/background-transitions.html
3268
3269         * page/animation/AnimationBase.cpp:
3270         (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
3271
3272 2009-10-26  Jeremy Orlow  <jorlow@chromium.org>
3273
3274         Reviewed by Dimitri Glazkov.
3275
3276         [V8] Tidy up the DOM Storage runtime flag stuff
3277         https://bugs.webkit.org/show_bug.cgi?id=30794
3278
3279         Clean up the DOM Storage runtime flag stuff to match the new way of doing
3280         things.  No behavioral changes.
3281
3282         * bindings/v8/RuntimeEnabledFeatures.cpp:
3283         * bindings/v8/RuntimeEnabledFeatures.h:
3284         (WebCore::RuntimeEnabledFeatures::setDatabaseEnabled):
3285         (WebCore::RuntimeEnabledFeatures::databaseEnabled):
3286         (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled):
3287         (WebCore::RuntimeEnabledFeatures::localStorageEnabled):
3288         (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled):
3289         (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
3290         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3291         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3292         * storage/Storage.cpp:
3293         * storage/Storage.h:
3294
3295 2009-10-26  Brady Eidson  <beidson@apple.com>
3296
3297         Reviewed by Darin Adler.
3298
3299         <rdar://problem/7308952> and http://webkit.org/b/30424 - REGRESSION (r48687): Pages on ucas.com appear blank.
3300
3301         Test: fast/loader/history-forward-in-head.html
3302
3303         * loader/RedirectScheduler.cpp:
3304         (WebCore::RedirectScheduler::scheduleHistoryNavigation): Restore the moved canGoBackOrForward() check.
3305           This restores the side effect of an invalid history navigation canceling previous scheduled redirects
3306           and also fixes the bug of scheduling an invalid history navigation canceling parsing of the current document.
3307         (WebCore::RedirectScheduler::timerFired): Removed the canGoBackOrForward() check as it is now made before
3308           the redirect is scheduled.
3309
3310 2009-10-26  Alexey Proskuryakov  <ap@apple.com>
3311
3312         Reviewed by Darin Adler.
3313
3314         https://bugs.webkit.org/show_bug.cgi?id=30049
3315         <rdar://problem/7286002> Manipulating DOM from a script while parsing XHTML can cause a crash
3316
3317         Tests: fast/parser/remove-current-node-parent-x-2.xhtml
3318                fast/parser/remove-current-node-parent-x.xhtml
3319
3320         * dom/XMLTokenizer.h: Store the whole stack of parent nodes - element.parentNode() is
3321         unreliable after DOM manipulation.
3322
3323         * dom/XMLTokenizer.cpp:
3324         (WebCore::XMLTokenizer::pushCurrentNode): Push the new node onto stack.
3325         (WebCore::XMLTokenizer::popCurrentNode): This is now called instead of setCurrentNode when
3326         exiting a node.
3327         (WebCore::XMLTokenizer::clearCurrentNodeStack): We're aborting; or just done parsing. This
3328         replaces setCurrentNode(0).
3329         (WebCore::XMLTokenizer::enterText): Call pushCurrentNode().
3330         (WebCore::XMLTokenizer::exitText): Call popCurrentNode(), removing a long-standing FIXME
3331         (not sure if it was ever practical though - how can a parent become null while adding text?)
3332
3333         * dom/XMLTokenizerLibxml2.cpp:
3334         (WebCore::XMLTokenizer::~XMLTokenizer): Call clearCurrentNodeStack().
3335         (WebCore::XMLTokenizer::startElementNs): Call pushCurrentNode().
3336         (WebCore::XMLTokenizer::endElementNs): Call popCurrentNode() to safely get to a parent. Also
3337         added a check fo script element still being in document - Firefox parses those that aren't,
3338         but doesn't execute them.
3339
3340         * dom/XMLTokenizerQt.cpp:
3341         (WebCore::XMLTokenizer::~XMLTokenizer):
3342         (WebCore::XMLTokenizer::parseStartElement):
3343         (WebCore::XMLTokenizer::parseEndElement):
3344         Match libxml2 version changes.
3345
3346 2009-10-26  Dan Bernstein  <mitz@apple.com>
3347
3348         Reviewed by Beth Dakin.
3349
3350         background-size: X treated as background-size: X X, not background-size: X auto
3351         https://bugs.webkit.org/show_bug.cgi?id=28440
3352
3353         Updated fast/backgrounds/size/resources/parsing-background-size-values.js
3354         and fast/backgrounds/size/resources/parsing-inherit.js
3355
3356         Reinstated -webkit-background-size and kept its behavior of filling in
3357         the second value with the first one; and changed background-size to have
3358         the behavior of filling in the second value with 'auto'.
3359
3360         * css/CSSComputedStyleDeclaration.cpp:
3361         (computedProperties): Re-added CSSPropertyWebkitBackgroundSize.
3362         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
3363         * css/CSSParser.cpp:
3364         (WebCore::CSSParser::parseValue): Ditto.
3365         (WebCore::CSSParser::parseFillSize): Adapted for the new parsing rule.
3366         (WebCore::CSSParser::parseFillProperty): Re-added
3367         CSSPropertyWebkitBackgroundSize.
3368         (WebCore::cssPropertyID): Removed mapping of -webkit-background-size to
3369         background-size.
3370         * css/CSSParser.h:
3371         * css/CSSPropertyNames.in: Re-added -webkit-background-size.
3372         * css/CSSStyleSelector.cpp:
3373         (WebCore::CSSStyleSelector::applyProperty): Re-added
3374         CSSPropertyWebkitBackgroundSize.
3375
3376 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3377
3378         Reviewed by Eric Seidel.
3379
3380         [Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash
3381         https://bugs.webkit.org/show_bug.cgi?id=30777
3382
3383         No new tests as the crash can be reproduced by existing storage
3384         LayoutTests (by hitting an assert in debug mode Webkit on WIN_OS).
3385
3386         * platform/text/String.cpp:
3387         (WebCore::String::number): Qt's QString::vsprintf does not
3388         understand the "%I64u" format string. Always use the "%lli"
3389         format string for Qt port.
3390
3391 2009-10-26  Tony Chang  <tony@chromium.org>
3392
3393         Reviewed by Eric Seidel.
3394
3395         Roll back r50073 because r50041-50043 were reverted.  r50073 was
3396         a chromium side fix for r50041.
3397         https://bugs.webkit.org/show_bug.cgi?id=30789
3398
3399         * bindings/v8/V8Collection.h:
3400         * bindings/v8/custom/V8CustomBinding.h:
3401         * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
3402         (WebCore::getNamedItems):
3403         (WebCore::getItem):
3404         (WebCore::NAMED_PROPERTY_GETTER):
3405         (WebCore::CALLBACK_FUNC_DECL):
3406         * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
3407         (WebCore::getNamedItems):
3408         (WebCore::getItem):
3409         (WebCore::NAMED_PROPERTY_GETTER):
3410         (WebCore::CALLBACK_FUNC_DECL):
3411         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
3412
3413 2009-10-26  Geoffrey Garen  <ggaren@apple.com>
3414
3415         Reviewed by Dimitri Glazkov.
3416
3417         Fixed https://bugs.webkit.org/show_bug.cgi?id=30765
3418         REGRESSION (r48701): Removing an event listener causes the one added just after it not to fire
3419         
3420         and related bugs.
3421
3422         If the event listener being removed is prior to the current firing event
3423         iterator, we need to decrement the current firing event iterator in
3424         addition to the endpoint. (Otherwise, shrinking the event listener vector
3425         by one implicity moves the current firing event iterator forward by one.
3426         It's like relativity, only without the planets.)
3427         
3428         Also took the opportunity to change some pointers to references, since
3429         they can't be null.
3430
3431         * dom/EventTarget.cpp:
3432         (WebCore::EventTarget::removeEventListener):
3433         (WebCore::EventTarget::removeAllEventListeners): Update iterator in addition
3434         to end, if need be.
3435         (WebCore::EventTarget::fireEventListeners): Updated for interface changes.
3436         Added a comment to explain a behavior that was implicit enough to be
3437         confusing.
3438
3439         * dom/EventTarget.h:
3440         (WebCore::FiringEventIterator::FiringEventIterator):
3441         (WebCore::EventTarget::isFiringEventListeners): Updated for interface changes.
3442
3443 2009-10-26  Brian Weinstein  <bweinstein@apple.com>
3444
3445         Reviewed by Timothy Hatcher.
3446
3447         Fixes <http://webkit.org/b/30792>.
3448         Web Inspector: When changing resource scope, resource graph can get in weird state.
3449         
3450         If the user was scrolled down while looking at All resources, and then just
3451         selects Fonts, or something that doesn't have many resources, then the graph
3452         will stay scrolled down, even when there is no content there.
3453         
3454         When the filter is updated, scroll to the top of the graph view, so this won't
3455         happen.
3456
3457         * inspector/front-end/AbstractTimelinePanel.js:
3458         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
3459
3460 2009-10-26  Sam Weinig  <sam@webkit.org>
3461
3462         Fix mac clean build.
3463
3464         * html/HTMLOptionsCollection.idl:
3465
3466 2009-10-26  Pavel Feldman  <pfeldman@chromium.org>
3467
3468         Reviewed by Timothy Hatcher.
3469
3470         Web Inspector: Extract AbstractTimelinePanel that will be a base
3471         class for ResourcesPanel and TimelinePanel.
3472
3473         https://bugs.webkit.org/show_bug.cgi?id=30776
3474
3475         * WebCore.gypi:
3476         * WebCore.vcproj/WebCore.vcproj:
3477         * inspector/front-end/AbstractTimelinePanel.js: Added.
3478         (WebInspector.AbstractTimelinePanel):
3479         (WebInspector.AbstractTimelinePanel.prototype.get categories):
3480         (WebInspector.AbstractTimelinePanel.prototype.showCategory):
3481         (WebInspector.AbstractTimelinePanel.prototype.hideCategory):
3482         (WebInspector.AbstractTimelinePanel.prototype.createTimelinePanels):
3483         (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel.createFilterElement):
3484         (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel):
3485         (WebInspector.AbstractTimelinePanel.prototype.filter):
3486         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
3487         (WebInspector.AbstractTimelinePanel.prototype._createGraph):
3488         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
3489         (WebInspector.AbstractTimelinePanel.prototype._updateSummaryGraph):
3490         (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition):
3491         (WebInspector.AbstractTimelinePanel.prototype.get needsRefresh):
3492         (WebInspector.AbstractTimelinePanel.prototype.set needsRefresh):
3493         (WebInspector.AbstractTimelinePanel.prototype.refreshIfNeeded):
3494         (WebInspector.AbstractTimelinePanel.prototype.show):
3495         (WebInspector.AbstractTimelinePanel.prototype.resize):
3496         (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth):
3497         (WebInspector.TimelineCalculator):
3498         (WebInspector.TimelineCalculator.prototype.computeSummaryValues):
3499         (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
3500         (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels):
3501         (WebInspector.TimelineCalculator.prototype.get boundarySpan):
3502         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
3503         (WebInspector.TimelineCalculator.prototype.reset):
3504         (WebInspector.TimelineCalculator.prototype._value):
3505         (WebInspector.TimelineCalculator.prototype.formatValue):
3506         * inspector/front-end/ResourceCategory.js:
3507         (WebInspector.ResourceCategory):
3508         * inspector/front-end/ResourcesPanel.js:
3509         (WebInspector.ResourcesPanel):
3510         (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get toolbarItemLabel):
3511         (WebInspector.ResourcesPanel.prototype.get statusBarItems):
3512         (WebInspector.ResourcesPanel.prototype.get categories):
3513         (WebInspector.ResourcesPanel.prototype.showCategory):
3514         (WebInspector.ResourcesPanel.prototype.hideCategory):
3515         (WebInspector.ResourcesPanel.prototype.isCategoryVisible):
3516         (WebInspector.ResourcesPanel.prototype.populateSidebar):
3517         (WebInspector.ResourcesPanel.prototype.createPanelEnabler):
3518         (WebInspector.ResourcesPanel.prototype.createStatusbarButtons):
3519         (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime):
3520         (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime):
3521         (WebInspector.ResourcesPanel.prototype.show):
3522         (WebInspector.ResourcesPanel.prototype.resize):
3523         (WebInspector.ResourcesPanel.prototype.reset):
3524         (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
3525         (WebInspector.ResourcesPanel.prototype.updateMainViewWidth):
3526         (WebInspector.ResourceTimeCalculator):
3527         (WebInspector.ResourceTransferSizeCalculator):
3528         (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
3529         * inspector/front-end/SummaryBar.js:
3530         (WebInspector.SummaryBar.prototype.update):
3531         * inspector/front-end/WebKit.qrc:
3532         * inspector/front-end/inspector.html:
3533         * inspector/front-end/inspector.js:
3534         (WebInspector.loaded):
3535
3536 2009-10-26  Avi Drissman  <avi@google.com>
3537
3538         Reviewed by Darin Adler.
3539
3540         Use Helvetica in the Inspector as intended.
3541         https://bugs.webkit.org/show_bug.cgi?id=30787
3542
3543         * inspector/front-end/inspector.css:
3544
3545 2009-10-26  Nate Chapin  <japhet@chromium.org>
3546
3547         Reviewed by Alexey Proskuryakov.
3548
3549         Don't set window.opener to 0 for the current FrameLoader if a noreferrer link was clicked, only suppress opener in a new frame.
3550         https://bugs.webkit.org/show_bug.cgi?id=30781
3551
3552         * loader/FrameLoader.cpp:
3553         (WebCore::FrameLoader::urlSelected): Don't suppress opener in the current frame for noreferrer navigations.
3554
3555 2009-10-26  Ryosuke Niwa  <rniwa@webkit.org>
3556
3557         Reviewed by Eric Seidel.
3558
3559         Data loss occurs when unbolding nested bold tags.
3560         https://bugs.webkit.org/show_bug.cgi?id=30083
3561
3562         Fixes the loop in swapInNodePreservingAttributesAndChildren by saving nextSibling() of child
3563         to a temporary valuable.  It was originally calling nextSibling() after appending the child
3564         to new parent, in which case, nextSibling is always 0.
3565
3566         Test: editing/style/unbolding-nested-b.html
3567
3568         * editing/ReplaceNodeWithSpanCommand.cpp:
3569         (WebCore::swapInNodePreservingAttributesAndChildren):
3570
3571 2009-10-21  Jeremy Orlow  <jorlow@chromium.org>
3572
3573         Reviewed by Darin Adler.
3574
3575         Storage events should use Document::url() rather than documentURI()
3576         https://bugs.webkit.org/show_bug.cgi?id=30535
3577
3578         Storage events should use Document::url() rather than Document::documentURI()
3579         per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html
3580
3581         Test: storage/domstorage/documentURI.html
3582
3583         * storage/StorageEventDispatcher.cpp:
3584         (WebCore::StorageEventDispatcher::dispatch):
3585
3586 2009-10-26  Sam Weinig  <sam@webkit.org>
3587
3588         Rubber-stamped by Darin Adler.
3589
3590         Rollout r50041-50043.  The HTML5 spec changed to make HTMLOptionsCollection
3591         inherit from HTMLCollection.
3592
3593         * GNUmakefile.am:
3594         * WebCore.gypi:
3595         * WebCore.pro:
3596         * WebCore.vcproj/WebCore.vcproj:
3597         * WebCore.xcodeproj/project.pbxproj:
3598         * bindings/js/JSHTMLAllCollectionCustom.cpp:
3599         (WebCore::getNamedItems):
3600         (WebCore::callHTMLAllCollection):
3601         (WebCore::JSHTMLAllCollection::nameGetter):
3602         (WebCore::JSHTMLAllCollection::item):
3603         (WebCore::JSHTMLAllCollection::namedItem):
3604         * bindings/js/JSHTMLCollectionCustom.cpp:
3605         (WebCore::getNamedItems):
3606         (WebCore::callHTMLCollection):
3607         (WebCore::JSHTMLCollection::nameGetter):
3608         (WebCore::JSHTMLCollection::item):
3609         (WebCore::JSHTMLCollection::namedItem):
3610         (WebCore::toJS):
3611         * bindings/js/JSHTMLCollectionFunctions.h: Removed.
3612         * bindings/js/JSHTMLDocumentCustom.cpp:
3613         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
3614         (WebCore::JSHTMLOptionsCollection::length):
3615         (WebCore::JSHTMLOptionsCollection::indexSetter):
3616         * bindings/objc/DOMHTML.mm:
3617         (kitClass):
3618         * bindings/objc/DOMUtility.mm:
3619         (JSC::createDOMWrapper):
3620         * bindings/scripts/CodeGeneratorJS.pm:
3621         * html/HTMLCollection.idl:
3622         * html/HTMLOptionsCollection.idl:
3623
3624 2009-10-26  Brent Fulgham  <bfulgham@webkit.org>
3625
3626         Reviewed by Adam Roben.
3627
3628         Build fix for ENABLE_FILTERS under Windows.
3629         https://bugs.webkit.org/show_bug.cgi?id=30762
3630
3631         Build correction for ENABLE_FILTERS feature.  No new tests needed.
3632
3633         * WebCore.vcproj/WebCore.vcproj:  Make the following changes:
3634           (1) Create a new 'filters' sub-folder of the platform/graphics 
3635               folder to properly show the sources held in this directory.
3636           (2) Move the files that are currently shown in svn/graphics/filters
3637               to platform/graphics/filters (where they actually live on disk).
3638           (3) Add the missing SVGFilter, SVGFilterBuilder, and SVGFETile to
3639               the project so they are built.
3640           (4) Remove SVGFEFloodElement.cpp from the build, since it is already
3641               being compiled by SVGAllInOne.cpp.  Its presence as a separate
3642               entity is causing a linker warning for duplicate symbols.
3643           (5) Add ImageBuffer.cpp to the build to support color space
3644               calculations for non-CG builds.
3645         * WebCore.vcproj/WebCoreCommon.vsprops: Add the platform/graphics/filters
3646           path to the search paths in the project.
3647
3648 2009-10-26  Keishi Hattori  <casey.hattori@gmail.com>
3649
3650         Reviewed by Timothy Hatcher.
3651
3652         console.assert should prefix messages with "Assertion failed: "
3653         https://bugs.webkit.org/show_bug.cgi?id=19135
3654
3655         * English.lproj/localizedStrings.js:
3656         * inspector/front-end/ConsoleView.js:
3657         (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType.
3658         (WebInspector.ConsoleMessage.prototype.toString):
3659         * page/Console.cpp:
3660         (WebCore::Console::assertCondition): Use AssertMessageType.
3661         * page/Console.h:
3662         (WebCore::MessageType): Added AssertMessageType.
3663
3664 2009-10-26  Rahul Kuchhal  <kuchhal@chromium.org>
3665
3666         Reviewed by Eric Seidel.
3667
3668         Prevent crash when optgroup element is empty by adding a NULL check.
3669
3670         https://bugs.webkit.org/show_bug.cgi?id=30365
3671
3672         Test: fast/forms/select-empty-optgroup.html
3673
3674         * dom/SelectElement.cpp:
3675         (WebCore::SelectElement::appendFormData):
3676
3677 2009-10-21  Steven Knight  <sgk@chromium.org>
3678
3679         Reviewed by David Levin.
3680
3681         Refactor gyp for separate webcore_bindings{,_sources} targets.
3682
3683         https://bugs.webkit.org/show_bug.cgi?id=30447
3684
3685         Handle long link lines by building .idl-generated bindings in a
3686         separate webcore_bindings library target.  Avoid Visual Studio
3687         dependency issues by building additional generated .cpp and .h files
3688         in a separate webcore_bindings_sources target.
3689
3690         Chrome should still build and test successfully.
3691
3692         * WebCore.gyp/WebCore.gyp:
3693         * WebCore.gypi:
3694
3695 2009-10-26  Mike Belshe  <mike@belshe.com>
3696
3697         Reviewed by Darin Fisher.
3698
3699         Make the number of connections for chromium controlled by
3700         chromium rather than by ResourceRequestBase.
3701         https://bugs.webkit.org/show_bug.cgi?id=30661
3702
3703         * platform/network/ResourceRequestBase.cpp:
3704         * platform/network/chromium/ResourceRequest.cpp:
3705
3706 2009-10-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3707
3708         Unreviewed. make distcheck build fixes.
3709
3710         * GNUmakefile.am:
3711
3712 2009-10-26  Anton Muhin  <antonm@chromium.org>
3713
3714         Reviewed by Dimitri Glazkov.
3715
3716         Unbreak Chromium build: that requires adding custom implementations
3717         for HTMLOptionsCollection's item and namedItem.  Keep v8 binding
3718         close to JSC bindings as well.
3719         https://bugs.webkit.org/show_bug.cgi?id=30780
3720
3721         * bindings/v8/V8Collection.h:
3722         (WebCore::getNamedItemsFromCollection):
3723         (WebCore::getItemFromCollection):
3724         * bindings/v8/custom/V8CustomBinding.h:
3725         * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
3726         (WebCore::NAMED_PROPERTY_GETTER):
3727         (WebCore::CALLBACK_FUNC_DECL):
3728         * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
3729         (WebCore::NAMED_PROPERTY_GETTER):
3730         (WebCore::CALLBACK_FUNC_DECL):
3731         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
3732         (WebCore::CALLBACK_FUNC_DECL):
3733
3734 2009-10-23  Alexey Proskuryakov  <ap@apple.com>
3735
3736         Reviewed by Adam Barth and Darin Adler.
3737
3738         https://bugs.webkit.org/show_bug.cgi?id=30723
3739         <rdar://problem/6189415> Input names added to multipart/form-data headers need to be escaped.
3740
3741         Test: http/tests/security/escape-form-data-field-names.html
3742
3743         * platform/network/FormDataBuilder.cpp:
3744         (WebCore::appendQuotedString):
3745         (WebCore::FormDataBuilder::beginMultiPartHeader):
3746         (WebCore::FormDataBuilder::addFilenameToMultiPartHeader):
3747         Percent-escape line breaks and quotation marks.
3748
3749 2009-10-26  Kelly Norton  <knorton@google.com>
3750
3751         Reviewed by Pavel Feldman.
3752
3753         Adds DOMTimer support to InspectorTimelineAgent.
3754         https://bugs.webkit.org/show_bug.cgi?id=30467
3755
3756         * inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names.
3757         (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
3758         (WebCore::InspectorTimelineAgent::didLayout):
3759         (WebCore::InspectorTimelineAgent::didRecalculateStyle):
3760         (WebCore::InspectorTimelineAgent::didPaint):
3761         (WebCore::InspectorTimelineAgent::didWriteHTML):
3762         (WebCore::InspectorTimelineAgent::didInstallTimer): Added.
3763         (WebCore::InspectorTimelineAgent::didRemoveTimer): Added.
3764         (WebCore::InspectorTimelineAgent::willFireTimer): Added.
3765         (WebCore::InspectorTimelineAgent::didFireTimer): Added.
3766         (WebCore::InspectorTimelineAgent::addItemToTimeline): Added.
3767         (WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed.
3768         * inspector/InspectorTimelineAgent.h:
3769         (WebCore::):
3770         * inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects.
3771         (WebCore::TimelineItemFactory::createGenericTimerTimelineItem):
3772         (WebCore::TimelineItemFactory::createTimerInstallTimelineItem):
3773         * inspector/TimelineItemFactory.h:
3774         * page/DOMTimer.cpp: Added instrumentation points.
3775         (WebCore::DOMTimer::install):
3776         (WebCore::DOMTimer::removeById):
3777         (WebCore::DOMTimer::fired):
3778
3779 2009-10-26  Simon Fraser  <simon.fraser@apple.com>
3780
3781         Reviewed by Sam Weinig.
3782
3783         <rdar://problem/6988966> Hardware layers do not show up in page snapshots
3784
3785         Add a method that gets called when snapshotting Canvas3DLayers for page snapshots,
3786         that allows the layer to return a CGImageRef of its contents.
3787         
3788         * platform/graphics/mac/Canvas3DLayer.h:
3789         * platform/graphics/mac/Canvas3DLayer.mm:
3790         (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]):
3791
3792 2009-10-26  Yury Semikhatsky  <yurys@chromium.org>
3793
3794         Reviewed by Pavel Feldman.
3795
3796         Pass "console" as object group when evaluating selection.
3797
3798         https://bugs.webkit.org/show_bug.cgi?id=30738
3799
3800         * inspector/front-end/SourceFrame.js:
3801         (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
3802
3803 2009-10-26  Keishi Hattori  <casey.hattori@gmail.com>
3804
3805         Reviewed by Pavel Feldman.
3806
3807         Fix for Console not showing repeat count when repeatedly logging an Event
3808         https://bugs.webkit.org/show_bug.cgi?id=30324
3809
3810         * inspector/ConsoleMessage.cpp:
3811         (WebCore::ConsoleMessage::addToConsole):
3812         (WebCore::ConsoleMessage::updateRepeatCountInConsole): Added.
3813         * inspector/ConsoleMessage.h:
3814         * inspector/InspectorController.cpp:
3815         (WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message.
3816         * inspector/InspectorFrontend.cpp:
3817         (WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole
3818         (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented.
3819         * inspector/InspectorFrontend.h:
3820         * inspector/front-end/ConsoleView.js:
3821         (WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual.
3822         (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added.
3823         (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count.
3824         (WebInspector.ConsoleView.prototype.clearMessages):
3825         (WebInspector.ConsoleMessage):
3826         (WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount
3827         (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
3828         * inspector/front-end/inspector.js:
3829         (WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole.
3830         (WebInspector.updateConsoleMessageRepeatCount): Added.
3831
3832 2009-10-26  Chris Fleizach  <cfleizach@apple.com>
3833
3834         Reviewed by Darin Adler.
3835
3836         crash with AX on when an image map contains an anchor tag
3837         https://bugs.webkit.org/show_bug.cgi?id=30739
3838
3839         Tests: accessibility/crashing-a-tag-in-map.html
3840
3841         * accessibility/AccessibilityRenderObject.cpp:
3842         (WebCore::AccessibilityRenderObject::addChildren):
3843
3844 2009-10-26  Steve Block  <steveblock@google.com>
3845
3846         Reviewed by Eric Seidel.
3847
3848         Adds feature ENABLE guards to V8 bindings.
3849         https://bugs.webkit.org/show_bug.cgi?id=30697
3850
3851         This adds guards for the following features to the V8 bindings,
3852         to allow builds with V8 to succeed when these features are not enabled.
3853         - DATABASE
3854         - WORKERS
3855         - SHARED_WORKERS
3856         - SVG
3857         - XPATH
3858         - XSLT
3859         - INSPECTOR
3860
3861         This is a build fix only, no new tests required.
3862
3863         * bindings/v8/DOMObjectsInclude.h: Modified.
3864         * bindings/v8/DerivedSourcesAllInOne.cpp: Modified.
3865         * bindings/v8/V8Index.cpp: Modified.
3866         * bindings/v8/V8Index.h: Modified.
3867
3868 2009-10-26  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3869
3870         Reviewed by Xan Lopez.
3871
3872         https://bugs.webkit.org/show_bug.cgi?id=25679
3873         [Gtk] Improve accessibility of focusable lists
3874
3875         Fixes the issues with the Atk states exposed for ListBoxOption
3876
3877         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3878         (setAtkStateSetFromCoreObject):
3879
3880 2009-10-26  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3881
3882         Reviewed by Xan Lopez.
3883
3884         https://bugs.webkit.org/show_bug.cgi?id=27085
3885         [Gtk] Incorrect rendering of list
3886
3887         Adds a way for platforms to indicate that a particular object
3888         should not be ignored.
3889
3890         * accessibility/AccessibilityObject.h:
3891         * accessibility/chromium/AccessibilityObjectChromium.cpp:
3892         * accessibility/gtk/AccessibilityObjectAtk.cpp:
3893         * accessibility/mac/AccessibilityObjectMac.mm:
3894         * accessibility/qt/AccessibilityObjectQt.cpp:
3895         * accessibility/win/AccessibilityObjectWin.cpp:
3896         * accessibility/wx/AccessibilityObjectWx.cpp:
3897         (AccessibilityObject::accessibilityPlatformIncludesObject):
3898         * accessibility/AccessibilityRenderObject.cpp:
3899         (AccessibilityRenderObject::accessibilityIsIgnored):
3900
3901 2009-10-26  Kinuko Yasuda  <kinuko@google.com>
3902
3903         Reviewed by Jan Alonzo.
3904
3905         Bug 30619: [Linux] Menu key doesn't work
3906         https://bugs.webkit.org/show_bug.cgi?id=30619
3907
3908         Test: manual-tests/keyboard-menukey-event.html
3909         No new layout tests: testing this will require changes in the test
3910         controller in a platform-specific way.
3911
3912         * platform/chromium/KeyCodeConversionGtk.cpp:
3913         (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
3914         GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
3915         * platform/gtk/KeyEventGtk.cpp:
3916         (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
3917         GDK_Menu to return V_APPS instead of VK_MENU.
3918
3919 2009-10-25  Anton Muhin  <antonm@chromium.org>
3920
3921         Reviewed by Adam Barth.
3922
3923         Reuse already fetched proxy.
3924         https://bugs.webkit.org/show_bug.cgi?id=30747
3925
3926         * bindings/v8/V8DOMWrapper.cpp:
3927         (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
3928
3929 2009-10-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3930
3931         Unreviewed build fix.
3932
3933         Build fix for WIN_OS if Netscape plugin support is turned off
3934         https://bugs.webkit.org/show_bug.cgi?id=30753
3935
3936         * plugins/PluginDatabase.cpp:
3937
3938 2009-10-25  Hironori Bono  <hbono@chromium.org>
3939
3940         Reviewed by Darin Adler.
3941
3942         A quick fix for Bug 29103.
3943         Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
3944         and the option string before calling String::startsWith().
3945         https://bugs.webkit.org/show_bug.cgi?id=29103
3946
3947         Tests: fast/forms/listbox-typeahead-cyrillic.html
3948                fast/forms/listbox-typeahead-greek.html
3949
3950         * dom/SelectElement.cpp:
3951         (WebCore::SelectElement::typeAheadFind):
3952
3953 2009-10-25  Keishi Hattori  <casey.hattori@gmail.com>
3954
3955         Reviewed by Timothy Hatcher.
3956
3957         Web Inspector: Expanding a node in the Console should not show the element in Elements panel
3958         https://bugs.webkit.org/show_bug.cgi?id=30749
3959
3960         * inspector/front-end/ElementsTreeOutline.js:
3961         (WebInspector.ElementsTreeElement.prototype.onmousedown): Check if inside disclosure triangle.
3962
3963 2009-10-25  Sam Weinig  <sam@webkit.org>
3964
3965         Reviewed by Dan Bernstein.
3966
3967         Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
3968         HTMLOptionsCollection should not inherit from HTMLCollection
3969
3970         * GNUmakefile.am:
3971         * WebCore.gypi:
3972         * WebCore.pro:
3973         * WebCore.vcproj/WebCore.vcproj:
3974         * WebCore.xcodeproj/project.pbxproj:
3975         Added JSHTMLCollectionFunctions.h
3976
3977         * bindings/js/JSHTMLAllCollectionCustom.cpp:
3978         (WebCore::callHTMLAllCollection):
3979         (WebCore::JSHTMLAllCollection::nameGetter):
3980         (WebCore::JSHTMLAllCollection::item):
3981         (WebCore::JSHTMLAllCollection::namedItem):
3982         * bindings/js/JSHTMLCollectionCustom.cpp:
3983         (WebCore::callHTMLCollection):
3984         (WebCore::JSHTMLCollection::nameGetter):
3985         (WebCore::JSHTMLCollection::item):
3986         (WebCore::JSHTMLCollection::namedItem):
3987         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
3988         (WebCore::callHTMLCollection):
3989         (WebCore::JSHTMLOptionsCollection::getCallData):
3990         (WebCore::JSHTMLOptionsCollection::canGetItemsForName):
3991         (WebCore::JSHTMLOptionsCollection::nameGetter):
3992         (WebCore::JSHTMLOptionsCollection::indexSetter):
3993         (WebCore::JSHTMLOptionsCollection::item):
3994         (WebCore::JSHTMLOptionsCollection::namedItem):
3995         Refactor to use generic implementation of HTMLCollection bindings functions
3996         from JSHTMLCollectionFunctions.h
3997
3998         * bindings/js/JSHTMLCollectionFunctions.h: Added.
3999         (WebCore::getCollectionNamedItems):
4000         (WebCore::getCollectionItems):
4001         (WebCore::callHTMLCollectionGeneric):
4002         Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
4003         JSHTMLOptionsCollection can all use.
4004
4005         * bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h
4006         for toJS on document.all.
4007
4008         * bindings/objc/DOMHTML.mm:
4009         * bindings/objc/DOMUtility.mm:
4010         (JSC::createDOMWrapper):
4011         Remove special cases for HTMLOptionsCollection.
4012
4013         * bindings/scripts/CodeGeneratorJS.pm:
4014         * html/HTMLAllCollection.idl:
4015         * html/HTMLCollection.idl:
4016         * html/HTMLOptionsCollection.idl:
4017
4018 2009-10-24  Keishi Hattori  <casey.hattori@gmail.com>
4019
4020         Reviewed by Timothy Hatcher.
4021
4022         WebInspector: Fixed issue with IME inside console
4023         https://bugs.webkit.org/show_bug.cgi?id=30660
4024
4025         * inspector/front-end/ConsoleView.js:
4026         (WebInspector.ConsoleView.prototype._promptKeyDown):
4027         * inspector/front-end/DatabaseQueryView.js:
4028         (WebInspector.DatabaseQueryView.prototype._promptKeyDown):
4029         * inspector/front-end/inspector.js:
4030         (WebInspector.loaded):
4031         (WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp.
4032         (WebInspector.startEditing.element.handleKeyEvent):
4033         (WebInspector.startEditing):
4034         * inspector/front-end/utilities.js:
4035         (isEnterKey): Added. Check if in IME.
4036
4037 2009-10-24  Brian Weinstein  <bweinstein@apple.com>
4038
4039         Reviewed by Timothy Hatcher.
4040
4041         Fixes <https://bugs.webkit.org/show_bug.cgi?id=30752>.
4042         Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX.
4043         
4044         Have the scope bars select one scope by default, but if the multiple selection key
4045         is pressed, allow for multiple selection.
4046
4047         * inspector/front-end/ConsoleView.js:
4048         (WebInspector.ConsoleView):
4049         (WebInspector.ConsoleView.prototype._updateFilter):
4050         (WebInspector.ConsoleView.prototype.filter):
4051         * inspector/front-end/ResourcesPanel.js:
4052         (WebInspector.ResourcesPanel):
4053         (WebInspector.ResourcesPanel.prototype.filter):
4054         (WebInspector.ResourcesPanel.prototype._updateFilter):
4055
4056 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4057
4058         Make the scope bars in the Web Inspector match other scope bars in Mac OS X.
4059         Also cleans up the CSS to use classes instead of ID selectors.
4060
4061         https://bugs.webkit.org/show_bug.cgi?id=28186
4062
4063         Reviewed by Dan Bernstein.
4064
4065         * inspector/front-end/ResourcesPanel.js: Add the scope-bar class.
4066         * inspector/front-end/inspector.css: Lots of changes to make it look right.
4067         * inspector/front-end/inspector.html: Add the scope-bar class.
4068
4069 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4070
4071         Fix selecting Resources in the Web Inspector's Resources panel.
4072
4073         https://bugs.webkit.org/show_bug.cgi?id=30743
4074
4075         Reviewed by Pavel Feldman.
4076
4077         * inspector/front-end/ResourcesPanel.js:
4078         (WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added.
4079         (WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call
4080         isCategoryVisible on the ResourcesPanel.
4081
4082 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4083
4084         Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting
4085         All will deselect the other filters.
4086
4087         https://bugs.webkit.org/show_bug.cgi?id=30744
4088
4089         Reviewed by Pavel Feldman.
4090
4091         * inspector/front-end/ResourcesPanel.js:
4092         (WebInspector.ResourcesPanel.createFilterElement): Better syntax.
4093         (WebInspector.ResourcesPanel):
4094         (WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop,
4095         and the child variable instead of target in the loop. Other clean up.
4096
4097 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4098
4099         Make resizing the Web Inspector's Elements panel sidebar work again.
4100         Also makes Resources panel use the sidebar code in Panel.
4101
4102         https://bugs.webkit.org/show_bug.cgi?id=30742
4103
4104         Reviewed by Pavel Feldman.
4105
4106         * inspector/front-end/Panel.js:
4107         (WebInspector.Panel): Don't create the sidebar with an argument.
4108         (WebInspector.Panel.prototype.show): Call updateSidebarWidth.
4109         (WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent.
4110         (WebInspector.Panel.prototype.handleSidebarKeyEvent): Added.
4111         (WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar.
4112         (WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth.
4113         (WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth.
4114         (WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth.
4115         (WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
4116         * inspector/front-end/ProfilesPanel.js:
4117         (WebInspector.ProfilesPanel): Call createSidebar.
4118         (WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
4119         * inspector/front-end/ResourcesPanel.js:
4120         (WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth.
4121         (WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth
4122         (WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto.
4123         (WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added.
4124         (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added.
4125         * inspector/front-end/StoragePanel.js:
4126         (WebInspector.StoragePanel): Call createSidebar.
4127         (WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
4128         * inspector/front-end/TimelinePanel.js:
4129         (WebInspector.TimelinePanel): Call createSidebar.
4130         (WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
4131
4132 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4133
4134         Call updateSelection() in a few places so hovering in the Web Inspector's
4135         Elements panel always has the correct row selection height.
4136
4137         https://bugs.webkit.org/show_bug.cgi?id=30735
4138
4139         Reviewed by Pavel Feldman.
4140
4141         * inspector/front-end/ElementsTreeOutline.js:
4142         (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
4143         (WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.
4144         * inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.
4145
4146 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4147
4148         Remove the re-root tree feature from the Web Inspector's
4149         Elements panel. This feature wasn't super useful and gets
4150         in the way of double-click to edit.
4151
4152         https://bugs.webkit.org/show_bug.cgi?id=30736
4153
4154         Reviewed by Pavel Feldman.
4155
4156         * inspector/front-end/ElementsTreeOutline.js:
4157         (WebInspector.ElementsTreeElement.prototype.ondblclick):
4158
4159 2009-10-24  Anton Muhin  <antonm@chromium.org>
4160
4161         Reviewed by Adam Barth.
4162
4163         Implements ReturnsNew hint for V8 bindings generation code.
4164         https://bugs.webkit.org/show_bug.cgi?id=30745
4165
4166         * bindings/scripts/CodeGeneratorV8.pm:
4167         * bindings/v8/V8DOMWrapper.h:
4168         (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
4169
4170 2009-10-24  Dan Bernstein  <mitz@apple.com>
4171
4172         Reviewed by Sam Weinig.
4173
4174         Missing images at 350.org due to wrong URLs
4175         https://bugs.webkit.org/show_bug.cgi?id=30748
4176
4177         Test: fast/dom/HTMLImageElement/parse-src.html
4178
4179         * dom/Element.cpp:
4180         (WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL().
4181         This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI()
4182         and SVGImageLoader::sourceURI() do.
4183
4184 2009-10-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4185
4186         Unreviewed.
4187
4188         [Qt] Build fix for QtWebKit after r50013.
4189
4190         * WebCore.pro:
4191
4192 2009-10-24  Dimitri Glazkov  <dglazkov@chromium.org>
4193
4194         Unreviewed, build fix.
4195
4196         [V8] Fix up to accommodate for HTMLAllCollection changes in
4197         http://trac.webkit.org/changeset/49998.
4198
4199         * WebCore.gypi:
4200         * bindings/scripts/CodeGeneratorV8.pm:
4201         * bindings/v8/custom/V8CustomBinding.h:
4202         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
4203
4204 2009-10-23  Dan Bernstein  <mitz@apple.com>
4205
4206         Reviewed by Alexey Proskuryakov.
4207
4208         <rdar://problem/7294131> Assertion failure in AuthenticationMac at
4209         mac(const Credential&) after authenticating to MobileMe Gallery movie
4210
4211         * platform/network/Credential.cpp:
4212         (WebCore::Credential::Credential): Initialize m_persistence.
4213         (WebCore::Credential::isEmpty): Made this method const.
4214         * platform/network/Credential.h:
4215         * platform/network/mac/AuthenticationMac.mm:
4216         (WebCore::mac): Return nil if the Credential is empty.
4217
4218 2009-10-23  Brian Weinstein  <bweinstein@apple.com>
4219
4220         Reviewed by Timothy Hatcher.
4221
4222         Fixes <https://bugs.webkit.org/show_bug.cgi?id=30617>.
4223         Web Inspector: Resources Scope Bar Should Allow Combinations.
4224         
4225         Refactor the filtering in ResourcePanel to make it match ConsoleView,
4226         and add a divider between All, and the other choices of Resource types.
4227
4228         * inspector/front-end/ResourcesPanel.js:
4229         (WebInspector.ResourcesPanel):
4230         (WebInspector.ResourcesPanel.prototype.filter):
4231         (WebInspector.ResourcesPanel.prototype._updateFilter):
4232         * inspector/front-end/inspector.css:
4233
4234 2009-10-23  Chris Evans  <cevans@chromium.org>
4235
4236         Reviewed by Adam Barth.
4237
4238         Ignore the Refresh header if we're in view source mode.
4239
4240         https://bugs.webkit.org/show_bug.cgi?id=27239
4241
4242         Test: http/tests/security/view-source-no-refresh.html
4243
4244         * loader/FrameLoader.cpp: ignore Refresh in view-source mode.
4245
4246 2009-10-23  Alexey Proskuryakov  <ap@apple.com>
4247
4248         Reviewed by Sam Weinig.
4249
4250         https://bugs.webkit.org/show_bug.cgi?id=30734
4251         Remove XMLTokenizer::m_currentNodeIsReferenced
4252
4253         No change in behavior, no tests.
4254
4255         * dom/XMLTokenizer.cpp:
4256         (WebCore::XMLTokenizer::setCurrentNode):
4257         * dom/XMLTokenizer.h:
4258         Don't store a boolean for the current node being the document - we can always check for that.
4259
4260         * dom/XMLTokenizerLibxml2.cpp:
4261         (WebCore::XMLTokenizer::XMLTokenizer):
4262         * dom/XMLTokenizerQt.cpp:
4263         (WebCore::XMLTokenizer::XMLTokenizer):
4264         A fragment passed to XMLTokenizer is never null - in fact, the first thing we do is dereference
4265         it unconditionally, and then begin checking it for null, as if it could help.
4266
4267 2009-10-23  Beth Dakin  <bdakin@apple.com>
4268
4269         No review since this is a build fix.
4270
4271         Build fix for the Mac. (Build is only broken when SVG filters are 
4272         enabled.)
4273
4274         Labelled these function static.
4275         * platform/graphics/filters/FEComponentTransfer.cpp:
4276         (WebCore::identity):