9628df79b1734f60739fc88643793d7a3b1171ff
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
2
3         Reviewed by Maciej Stachowiak.
4         
5         Added missing initializer to ResourceRequest -- fixes some loader crashes
6         due to assuming a request always has a non-null httpMethod.
7
8         * platform/network/ResourceRequest.h:
9         (WebCore::ResourceRequest::ResourceRequest):
10
11 2006-11-11  Brady Eidson <beidson@apple.com>
12
13         Reviewed by Maciej
14
15         Fixed header guard
16
17         * loader/FrameLoaderClient.h:
18
19 2006-11-11  Darin Adler  <darin@apple.com>
20
21         - attempt to fix Qt build
22
23         * platform/qt/CursorQt.cpp:
24         (WebCore::verticalTextCursor): Added. Just returns pointer cursor.
25         (WebCore::cellCursor): Ditto.
26         (WebCore::contextMenuCursor): Ditto.
27
28 2006-11-11  Rob Buis  <buis@kde.org>
29
30         Reviewed by hyatt.
31
32         http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
33         InsertRule can not handle @import statements
34
35         Allow @import as part of a css rule.
36
37         * css/CSSGrammar.y:
38         * css/CSSImportRule.cpp:
39         (WebCore::CSSImportRule::insertedIntoParent):
40         * css/CSSStyleSheet.cpp:
41         (WebCore::CSSStyleSheet::CSSStyleSheet):
42         (WebCore::CSSStyleSheet::checkLoaded):
43         * css/CSSStyleSheet.h:
44         (WebCore::CSSStyleSheet::loadCompleted):
45
46 2006-11-11  Alexey Proskuryakov  <ap@webkit.org>
47
48         Attempt to fix Qt build.
49
50         * CMakeLists.txt: PathQt.cpp is in graphics/qt now.
51
52 2006-11-11  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
53
54         Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)
55
56         [CSS 3] support for vertical-text, cell and context-menu cursors
57         http://bugs.webkit.org/show_bug.cgi?id=11494
58
59         * Resources/cellCursor.png: Added.
60         * Resources/contextMenuCursor.png: Added.
61         * Resources/verticalTextCursor.png: Added.
62         * WebCore.xcodeproj/project.pbxproj:
63         * css/CSSComputedStyleDeclaration.cpp:
64         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
65         * css/CSSValueKeywords.in:
66         * manual-tests/cursor.html:
67         * page/FrameView.cpp:
68         (WebCore::selectCursor):
69         * platform/Cursor.h:
70         * platform/mac/CursorMac.mm:
71         (WebCore::verticalTextCursor):
72         (WebCore::cellCursor):
73         (WebCore::contextMenuCursor):
74         * rendering/RenderStyle.h:
75         (WebCore::):
76
77 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
78
79         Reviewed by aroben and ap, landed by ap.
80
81         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468
82
83         Group graphics related files in platform/graphics.
84         Move certain files from certain subdirectories
85         into platform/graphics/{win,mac,cg,gdk,qt}
86
87         * CMakeLists.txt:
88         * WebCore.xcodeproj/project.pbxproj:
89         * platform/AffineTransform.cpp: Removed.
90         * platform/AffineTransform.h: Removed.
91         * platform/Color.cpp: Removed.
92         * platform/Color.h: Removed.
93         * platform/FloatPoint.cpp: Removed.
94         * platform/FloatPoint.h: Removed.
95         * platform/FloatRect.cpp: Removed.
96         * platform/FloatRect.h: Removed.
97         * platform/FloatSize.cpp: Removed.
98         * platform/FloatSize.h: Removed.
99         * platform/Icon.h: Removed.
100         * platform/Image.cpp: Removed.
101         * platform/Image.h: Removed.
102         * platform/ImageSource.h: Removed.
103         * platform/IntPoint.h: Removed.
104         * platform/IntRect.cpp: Removed.
105         * platform/IntRect.h: Removed.
106         * platform/IntSize.h: Removed.
107         * platform/IntSizeHash.h: Removed.
108         * platform/Path.cpp: Removed.
109         * platform/Path.h: Removed.
110         * platform/Pen.cpp: Removed.
111         * platform/Pen.h: Removed.
112         * platform/cairo/AffineTransformCairo.cpp: Removed.
113         * platform/cairo/GraphicsContextCairo.cpp: Removed.
114         * platform/cairo/ImageCairo.cpp: Removed.
115         * platform/cairo/ImageSourceCairo.cpp: Removed.
116         * platform/cairo/cairo/AUTHORS: Removed.
117         * platform/cairo/cairo/COPYING: Removed.
118         * platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
119         * platform/cairo/cairo/COPYING-MPL-1.1: Removed.
120         * platform/cairo/cairo/INSTALL: Removed.
121         * platform/cairo/cairo/NEWS: Removed.
122         * platform/cairo/cairo/README: Removed.
123         * platform/cairo/cairo/TODO: Removed.
124         * platform/cairo/cairo/src/Makefile.in: Removed.
125         * platform/cairo/cairo/src/cairo-arc-private.h: Removed.
126         * platform/cairo/cairo/src/cairo-arc.c: Removed.
127         * platform/cairo/cairo/src/cairo-array.c: Removed.
128         * platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
129         * platform/cairo/cairo/src/cairo-atsui.h: Removed.
130         * platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
131         * platform/cairo/cairo/src/cairo-beos.h: Removed.
132         * platform/cairo/cairo/src/cairo-cache-private.h: Removed.
133         * platform/cairo/cairo/src/cairo-cache.c: Removed.
134         * platform/cairo/cairo/src/cairo-clip-private.h: Removed.
135         * platform/cairo/cairo/src/cairo-clip.c: Removed.
136         * platform/cairo/cairo/src/cairo-color.c: Removed.
137         * platform/cairo/cairo/src/cairo-debug.c: Removed.
138         * platform/cairo/cairo/src/cairo-debug.h: Removed.
139         * platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
140         * platform/cairo/cairo/src/cairo-directfb.h: Removed.
141         * platform/cairo/cairo/src/cairo-features.h: Removed.
142         * platform/cairo/cairo/src/cairo-features.h.in: Removed.
143         * platform/cairo/cairo/src/cairo-fixed.c: Removed.
144         * platform/cairo/cairo/src/cairo-font-options.c: Removed.
145         * platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
146         * platform/cairo/cairo/src/cairo-font-subset.c: Removed.
147         * platform/cairo/cairo/src/cairo-font.c: Removed.
148         * platform/cairo/cairo/src/cairo-ft-font.c: Removed.
149         * platform/cairo/cairo/src/cairo-ft-private.h: Removed.
150         * platform/cairo/cairo/src/cairo-ft.h: Removed.
151         * platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
152         * platform/cairo/cairo/src/cairo-glitz.h: Removed.
153         * platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
154         * platform/cairo/cairo/src/cairo-gstate.c: Removed.
155         * platform/cairo/cairo/src/cairo-hash-private.h: Removed.
156         * platform/cairo/cairo/src/cairo-hash.c: Removed.
157         * platform/cairo/cairo/src/cairo-hull.c: Removed.
158         * platform/cairo/cairo/src/cairo-image-surface.c: Removed.
159         * platform/cairo/cairo/src/cairo-matrix.c: Removed.
160         * platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
161         * platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
162         * platform/cairo/cairo/src/cairo-output-stream.c: Removed.
163         * platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
164         * platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
165         * platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
166         * platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
167         * platform/cairo/cairo/src/cairo-path-data.c: Removed.
168         * platform/cairo/cairo/src/cairo-path-fill.c: Removed.
169         * platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
170         * platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
171         * platform/cairo/cairo/src/cairo-path.c: Removed.
172         * platform/cairo/cairo/src/cairo-pattern.c: Removed.
173         * platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
174         * platform/cairo/cairo/src/cairo-pdf.h: Removed.
175         * platform/cairo/cairo/src/cairo-pen.c: Removed.
176         * platform/cairo/cairo/src/cairo-platform.h: Removed.
177         * platform/cairo/cairo/src/cairo-png.c: Removed.
178         * platform/cairo/cairo/src/cairo-polygon.c: Removed.
179         * platform/cairo/cairo/src/cairo-private.h: Removed.
180         * platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
181         * platform/cairo/cairo/src/cairo-ps.h: Removed.
182         * platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
183         * platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
184         * platform/cairo/cairo/src/cairo-quartz.h: Removed.
185         * platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
186         * platform/cairo/cairo/src/cairo-quartz2.h: Removed.
187         * platform/cairo/cairo/src/cairo-region.c: Removed.
188         * platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
189         * platform/cairo/cairo/src/cairo-slope.c: Removed.
190         * platform/cairo/cairo/src/cairo-spline.c: Removed.
191         * platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
192         * platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
193         * platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
194         * platform/cairo/cairo/src/cairo-surface.c: Removed.
195         * platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
196         * platform/cairo/cairo/src/cairo-svg.h: Removed.
197         * platform/cairo/cairo/src/cairo-traps.c: Removed.
198         * platform/cairo/cairo/src/cairo-unicode.c: Removed.
199         * platform/cairo/cairo/src/cairo-wideint.c: Removed.
200         * platform/cairo/cairo/src/cairo-wideint.h: Removed.
201         * platform/cairo/cairo/src/cairo-win32-font.c: Removed.
202         * platform/cairo/cairo/src/cairo-win32-private.h: Removed.
203         * platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
204         * platform/cairo/cairo/src/cairo-win32.h: Removed.
205         * platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
206         * platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
207         * platform/cairo/cairo/src/cairo-xcb.h: Removed.
208         * platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
209         * platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
210         * platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
211         * platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
212         * platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
213         * platform/cairo/cairo/src/cairo-xlib.h: Removed.
214         * platform/cairo/cairo/src/cairo.c: Removed.
215         * platform/cairo/cairo/src/cairo.h: Removed.
216         * platform/cairo/cairo/src/cairoint.h: Removed.
217         * platform/cairo/cairo/src/test-fallback-surface.c: Removed.
218         * platform/cairo/cairo/src/test-fallback-surface.h: Removed.
219         * platform/cairo/cairo/src/test-meta-surface.c: Removed.
220         * platform/cairo/cairo/src/test-meta-surface.h: Removed.
221         * platform/cairo/cairo/src/test-paginated-surface.c: Removed.
222         * platform/cairo/cairo/src/test-paginated-surface.h: Removed.
223         * platform/cairo/pixman/AUTHORS: Removed.
224         * platform/cairo/pixman/COPYING: Removed.
225         * platform/cairo/pixman/README: Removed.
226         * platform/cairo/pixman/src/Makefile.in: Removed.
227         * platform/cairo/pixman/src/fbcompose.c: Removed.
228         * platform/cairo/pixman/src/fbedge.c: Removed.
229         * platform/cairo/pixman/src/fbedgeimp.h: Removed.
230         * platform/cairo/pixman/src/fbmmx.c: Removed.
231         * platform/cairo/pixman/src/fbmmx.h: Removed.
232         * platform/cairo/pixman/src/fbpict.c: Removed.
233         * platform/cairo/pixman/src/fbpict.h: Removed.
234         * platform/cairo/pixman/src/fbtrap.c: Removed.
235         * platform/cairo/pixman/src/icblt.c: Removed.
236         * platform/cairo/pixman/src/icbltone.c: Removed.
237         * platform/cairo/pixman/src/iccolor.c: Removed.
238         * platform/cairo/pixman/src/icformat.c: Removed.
239         * platform/cairo/pixman/src/icimage.c: Removed.
240         * platform/cairo/pixman/src/icimage.h: Removed.
241         * platform/cairo/pixman/src/icint.h: Removed.
242         * platform/cairo/pixman/src/icpixels.c: Removed.
243         * platform/cairo/pixman/src/icrect.c: Removed.
244         * platform/cairo/pixman/src/icrop.h: Removed.
245         * platform/cairo/pixman/src/icstipple.c: Removed.
246         * platform/cairo/pixman/src/ictransform.c: Removed.
247         * platform/cairo/pixman/src/ictrap.c: Removed.
248         * platform/cairo/pixman/src/ictri.c: Removed.
249         * platform/cairo/pixman/src/icutil.c: Removed.
250         * platform/cairo/pixman/src/pixman-remap.h: Removed.
251         * platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
252         * platform/cairo/pixman/src/pixman.h: Removed.
253         * platform/cairo/pixman/src/pixregion.c: Removed.
254         * platform/cairo/pixman/src/pixregionint.h: Removed.
255         * platform/cairo/pixman/src/renderedge.c: Removed.
256         * platform/cairo/pixman/src/renderedge.h: Removed.
257         * platform/cairo/pixman/src/slim_internal.h: Removed.
258         * platform/cairo/rgb24-hacks.txt: Removed.
259         * platform/cairo/scale-removal.txt: Removed.
260         * platform/cg/AffineTransformCG.cpp: Removed.
261         * platform/cg/FloatPointCG.cpp: Removed.
262         * platform/cg/FloatRectCG.cpp: Removed.
263         * platform/cg/FloatSizeCG.cpp: Removed.
264         * platform/cg/GraphicsContextCG.cpp: Removed.
265         * platform/cg/GraphicsContextPlatformPrivate.h: Removed.
266         * platform/cg/ImageCG.cpp: Removed.
267         * platform/cg/ImageSourceCG.cpp: Removed.
268         * platform/cg/IntPointCG.cpp: Removed.
269         * platform/cg/IntRectCG.cpp: Removed.
270         * platform/cg/IntSizeCG.cpp: Removed.
271         * platform/cg/PDFDocumentImage.cpp: Removed.
272         * platform/cg/PDFDocumentImage.h: Removed.
273         * platform/cg/PathCG.cpp: Removed.
274         * platform/gdk/ImageGdk.cpp: Removed.
275         * platform/mac/ColorMac.mm: Removed.
276         * platform/mac/FloatPointMac.mm: Removed.
277         * platform/mac/FloatRectMac.mm: Removed.
278         * platform/mac/FloatSizeMac.mm: Removed.
279         * platform/mac/GraphicsContextMac.mm:
280         * platform/mac/IconMac.mm: Removed.
281         * platform/mac/ImageMac.mm: Removed.
282         * platform/mac/IntPointMac.mm: Removed.
283         * platform/mac/IntRectMac.mm: Removed.
284         * platform/mac/IntSizeMac.mm: Removed.
285         * platform/qt/AffineTransformQt.cpp: Removed.
286         * platform/qt/ColorQt.cpp: Removed.
287         * platform/qt/FloatPointQt.cpp: Removed.
288         * platform/qt/FloatRectQt.cpp: Removed.
289         * platform/qt/IconQt.cpp: Removed.
290         * platform/qt/ImageQt.cpp: Removed.
291         * platform/qt/ImageSourceQt.cpp: Removed.
292         * platform/qt/IntPointQt.cpp: Removed.
293         * platform/qt/IntRectQt.cpp: Removed.
294         * platform/qt/IntSizeQt.cpp: Removed.
295         * platform/qt/PathQt.cpp: Removed.
296         * platform/win/ImageWin.cpp: Removed.
297         * platform/win/IntPointWin.cpp: Removed.
298         * platform/win/IntRectWin.cpp: Removed.
299         * platform/win/IntSizeWin.cpp: Removed.
300
301 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
302
303         Reviewed by hyatt.
304
305         A layout test was added when this bug was fixed, so none needed now.
306         
307         Cleanup after:
308         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
309         http://bugs.webkit.org/show_bug.cgi?id=11570
310         
311         * rendering/RenderStyle.h:
312         (WebCore::RenderStyle::isSpace): Removed.
313         * rendering/RenderText.cpp:
314         (WebCore::isSpace): Added.
315         (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
316
317 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
318
319         Reviewed by mitz.
320         
321         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
322         http://bugs.webkit.org/show_bug.cgi?id=11570
323
324         * rendering/RenderStyle.h:
325         (WebCore::RenderStyle::isSpace): Added.
326         * rendering/RenderText.cpp:
327         (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, 
328         treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'
329
330 2006-11-10  Zalan Bujtas <zalan.bujtas@nokia.com>
331
332         Reviewed by Maciej.
333
334         Added basic types for symbian platform.
335         http://bugs.webkit.org/show_bug.cgi?id=11540
336
337         * config.h:
338         * platform/AtomicString.h:
339         (WebCore::AtomicString::AtomicString):
340         (WebCore::AtomicString::operator TPtrC):
341         * platform/DeprecatedString.cpp:
342         (WebCore::initializeHandleNodeBlock):
343         * platform/DeprecatedString.h: char _internalBuffer has to be in front of
344           the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with
345           bitfields and breaks byte aligment
346         * platform/FloatPoint.h:
347         * platform/FloatRect.h:
348         * platform/IntPoint.h:
349         * platform/IntRect.h:
350         * platform/IntSize.h:
351         * platform/PlatformString.h:
352         (WebCore::String::operator TPtrC):
353         (WebCore::String::des):
354         * platform/StringImpl.h:
355         * platform/symbian/DeprecatedStringSymbian.cpp: Added.
356         (WebCore::DeprecatedString::setBufferFromDes):
357         (WebCore::DeprecatedString::fromDes):
358         (WebCore::DeprecatedString::des):
359         (WebCore::DeprecatedString::des8):
360         * platform/symbian/FloatPointSymbian.cpp: Added.
361         (WebCore::FloatPoint::FloatPoint):
362         (WebCore::FloatPoint::operator TPoint):
363         * platform/symbian/FloatRectSymbian.cpp: Added.
364         (WebCore::FloatRect::FloatRect):
365         (WebCore::FloatRect::operator TRect):
366         (WebCore::FloatRect::rect):
367         * platform/symbian/IntPointSymbian.cpp: Added.
368         (WebCore::IntPoint::IntPoint):
369         (WebCore::IntPoint::operator TPoint):
370         * platform/symbian/IntRectSymbian.cpp: Added.
371         (WebCore::IntRect::IntRect):
372         (WebCore::IntRect::operator TRect):
373         (WebCore::IntRect::Rect):
374         * platform/symbian/IntSizeSymbian.cpp: Added.
375         (WebCore::IntSize::IntSize):
376         (WebCore::IntSize::operator TSize):
377         * platform/symbian/StringImplSymbian.cpp: Added.
378         (WebCore::StringImpl::StringImpl):
379         (WebCore::StringImpl::des):
380         * platform/symbian/StringSymbian.cpp: Added.
381         (WebCore::String::String):
382
383 2006-11-10  Zack Rusin  <zack@kde.org>
384
385         Reviewed by Anders.
386
387         Adjust to the changes Brady made in the Qt code.
388
389         * loader/qt/FrameLoaderClientQt.cpp:
390         (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
391         * loader/qt/FrameLoaderClientQt.h:
392
393 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
394
395         Reviewed by harrison
396         
397         <rdar://problem/4069359>
398         Deleting hyperlink text, then typing uses link typing style but loses the link itself
399         
400         The removed anchor element needs to stick around temporarily, in the same way
401         that the typing style hangs off the caret until the user moves it.  Also text
402         insertion around anchors didn't match TextEdit.
403
404         * editing/DeleteSelectionCommand.cpp:
405         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added.
406         (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
407         * editing/DeleteSelectionCommand.h:
408         * editing/EditCommand.cpp:
409         (WebCore::EditCommand::apply): Clear the removed anchor after any top level
410         editing command that doesn't preserve the typing style (matches TextEdit).
411         * editing/Editor.cpp:
412         (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call 
413         setSelection with a message telling it to clear the typing style 
414         (and the saved anchor) here.  Save/restore the saved anchor because of this.
415         * editing/Editor.h:
416         (WebCore::Editor::removedAnchor): Getter.
417         (WebCore::Editor::setRemovedAnchor): Setter.
418         * editing/InsertTextCommand.cpp:
419         (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor
420         if one exists.
421         * editing/SelectionController.cpp:
422         (WebCore::SelectionController::setSelection): Clear the removed anchor whenever
423         we make a selection change that clears the typing style.
424         (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
425         * editing/htmlediting.cpp:
426         (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and
427         made some changes to match TextEdit's behavior.  First, insert content
428         inside the anchor when the caret is after it, unless the caret is at the
429         end of the document, or if the caret is before it and at the start of a 
430         paragraph.
431
432 === Safari-521.30 ===
433
434 2006-11-10  Timothy Hatcher  <timothy@apple.com>
435
436         Reviewed by Hyatt.
437
438         Check for BHIDDEN in isVisible() also.
439
440         * rendering/RenderStyle.h:
441         (WebCore::BorderValue::isVisible):
442
443 2006-11-10  Timothy Hatcher  <timothy@apple.com>
444
445         Reviewed by Adam.
446
447         <rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
448
449         Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
450
451         * editing/DeleteButtonController.cpp:
452         (WebCore::isDeletableElement):
453         * rendering/RenderStyle.h:
454         (WebCore::BorderValue::isVisible):
455
456 2006-11-10  Adam Roben  <aroben@apple.com>
457
458         Rubberstamped by Anders.
459
460         Back out some accidentally-committed changes from r17711.
461
462         * page/Frame.cpp:
463         (WebCore::Frame::command):
464         (WebCore::FramePrivate::FramePrivate):
465         * page/Frame.h:
466         * page/FramePrivate.h:
467
468 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
469
470         Reviewed by Geoff.
471
472         Add more commands, make toggleBold and toggleItalic executable commands.
473
474         * WebCore.exp:
475         * editing/Editor.cpp:
476         (WebCore::execCopy):
477         (WebCore::execCut):
478         (WebCore::execDelete):
479         (WebCore::execForwardDelete):
480         (WebCore::execPaste):
481         (WebCore::execSelectAll):
482         (WebCore::execToggleBold):
483         (WebCore::execToggleItalic):
484         (WebCore::enabled):
485         (WebCore::canPaste):
486         (WebCore::hasEditableSelection):
487         (WebCore::hasEditableRangeSelection):
488         (WebCore::hasRangeSelection):
489         (WebCore::hasRichlyEditableSelection):
490         (WebCore::CommandEntry::):
491         * editing/Editor.h:
492
493 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
494
495         Reviewed by Maciej, Geoff.
496
497         Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
498         the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.
499
500         * WebCore.exp:
501         * bridge/mac/WebCoreFrameBridge.h:
502         * bridge/mac/WebCoreFrameBridge.mm:
503         * editing/Editor.cpp:
504         (WebCore::execMoveBackward):
505         (WebCore::execMoveBackwardAndModifySelection):
506         (WebCore::execMoveDown):
507         (WebCore::execMoveDownAndModifySelection):
508         (WebCore::execMoveForward):
509         (WebCore::execMoveForwardAndModifySelection):
510         (WebCore::execMoveLeft):
511         (WebCore::execMoveLeftAndModifySelection):
512         (WebCore::execMoveRight):
513         (WebCore::execMoveRightAndModifySelection):
514         (WebCore::execMoveToBeginningOfDocument):
515         (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
516         (WebCore::execMoveToBeginningOfSentence):
517         (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
518         (WebCore::execMoveToBeginningOfLine):
519         (WebCore::execMoveToBeginningOfLineAndModifySelection):
520         (WebCore::execMoveToBeginningOfParagraph):
521         (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
522         (WebCore::execMoveToEndOfDocument):
523         (WebCore::execMoveToEndOfDocumentAndModifySelection):
524         (WebCore::execMoveToEndOfSentence):
525         (WebCore::execMoveToEndOfSentenceAndModifySelection):
526         (WebCore::execMoveToEndOfLine):
527         (WebCore::execMoveToEndOfLineAndModifySelection):
528         (WebCore::execMoveToEndOfParagraph):
529         (WebCore::execMoveToEndOfParagraphAndModifySelection):
530         (WebCore::execMoveParagraphBackwardAndModifySelection):
531         (WebCore::execMoveParagraphForwardAndModifySelection):
532         (WebCore::execMoveUp):
533         (WebCore::execMoveUpAndModifySelection):
534         (WebCore::execMoveWordBackward):
535         (WebCore::execMoveWordBackwardAndModifySelection):
536         (WebCore::execMoveWordForward):
537         (WebCore::execMoveWordForwardAndModifySelection):
538         (WebCore::execMoveWordLeft):
539         (WebCore::execMoveWordLeftAndModifySelection):
540         (WebCore::execMoveWordRight):
541         (WebCore::execMoveWordRightAndModifySelection):
542         (WebCore::enabledAnySelection):
543         (WebCore::createCommandMap):
544         (WebCore::CommandEntry::):
545         (WebCore::Editor::execCommand):
546         * editing/Editor.h:
547
548 2006-11-10  Brady Eidson  <beidson@apple.com>
549
550         Reviewed by Darin
551
552         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
553
554         * WebCore.exp:
555         * WebCore.xcodeproj/project.pbxproj:
556         * bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
557         * bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
558         * loader/FrameLoaderClient.h:
559         * loader/icon/IconDatabase.cpp:
560         (WebCore::IconDatabase::sharedIconDatabase):
561         (WebCore::IconDatabase::~IconDatabase):
562         * loader/icon/IconDatabase.h:
563         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
564         (WebCore::IconDatabase::enabled):
565         * loader/icon/IconLoader.cpp:
566         (WebCore::IconLoader::finishLoading):
567         * loader/mac/FrameLoaderMac.mm:
568
569 2006-11-10  Zack Rusin  <zack@kde.org>
570
571         Reviewed and landed by Anders.
572
573         Adjust platform Qt/KDE code to the recent loader
574         changes. 
575
576         * CMakeLists.txt:
577         * loader/DocumentLoader.h:
578         * loader/FrameLoader.cpp:
579         (WebCore::FrameLoader::createEmptyDocument):
580         * loader/FrameLoader.h:
581         * loader/FrameLoaderClient.h:
582         * loader/qt/DocumentLoaderQt.cpp: Added.
583         (WebCore::canonicalizedTitle):
584         (WebCore::DocumentLoader::DocumentLoader):
585         (WebCore::DocumentLoader::frameLoader):
586         (WebCore::DocumentLoader::~DocumentLoader):
587         (WebCore::DocumentLoader::URL):
588         (WebCore::DocumentLoader::unreachableURL):
589         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
590         (WebCore::DocumentLoader::isStopping):
591         (WebCore::DocumentLoader::clearErrors):
592         (WebCore::DocumentLoader::stopLoading):
593         (WebCore::DocumentLoader::setupForReplace):
594         (WebCore::DocumentLoader::commitIfReady):
595         (WebCore::DocumentLoader::finishedLoading):
596         (WebCore::DocumentLoader::setCommitted):
597         (WebCore::DocumentLoader::isCommitted):
598         (WebCore::DocumentLoader::setLoading):
599         (WebCore::DocumentLoader::isLoading):
600         (WebCore::DocumentLoader::doesProgressiveLoad):
601         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
602         (WebCore::DocumentLoader::updateLoading):
603         (WebCore::DocumentLoader::setFrame):
604         (WebCore::DocumentLoader::attachToFrame):
605         (WebCore::DocumentLoader::detachFromFrame):
606         (WebCore::DocumentLoader::prepareForLoadStart):
607         (WebCore::DocumentLoader::loadingStartedTime):
608         (WebCore::DocumentLoader::setIsClientRedirect):
609         (WebCore::DocumentLoader::isClientRedirect):
610         (WebCore::DocumentLoader::setPrimaryLoadComplete):
611         (WebCore::DocumentLoader::isLoadingInAPISense):
612         (WebCore::DocumentLoader::stopRecordingResponses):
613         (WebCore::DocumentLoader::title):
614         (WebCore::DocumentLoader::triggeringAction):
615         (WebCore::DocumentLoader::setTriggeringAction):
616         (WebCore::DocumentLoader::setOverrideEncoding):
617         (WebCore::DocumentLoader::overrideEncoding):
618         (WebCore::DocumentLoader::setTitle):
619         (WebCore::DocumentLoader::URLForHistory):
620         * loader/qt/FrameLoaderClientQt.cpp: Added.
621         (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
622         (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt):
623         (WebCore::FrameLoaderClientQt::detachFrameLoader):
624         (WebCore::FrameLoaderClientQt::hasWebView):
625         (WebCore::FrameLoaderClientQt::hasFrameView):
626         (WebCore::FrameLoaderClientQt::hasBackForwardList):
627         (WebCore::FrameLoaderClientQt::resetBackForwardList):
628         (WebCore::FrameLoaderClientQt::provisionalItemIsTarget):
629         (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache):
630         (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache):
631         (WebCore::FrameLoaderClientQt::privateBrowsingEnabled):
632         (WebCore::FrameLoaderClientQt::makeDocumentView):
633         (WebCore::FrameLoaderClientQt::makeRepresentation):
634         (WebCore::FrameLoaderClientQt::forceLayout):
635         (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML):
636         (WebCore::FrameLoaderClientQt::updateHistoryForCommit):
637         (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation):
638         (WebCore::FrameLoaderClientQt::updateHistoryForReload):
639         (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad):
640         (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad):
641         (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect):
642         (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
643         (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset):
644         (WebCore::FrameLoaderClientQt::resetAfterLoadError):
645         (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError):
646         (WebCore::FrameLoaderClientQt::willCloseDocument):
647         (WebCore::FrameLoaderClientQt::detachedFromParent1):
648         (WebCore::FrameLoaderClientQt::detachedFromParent2):
649         (WebCore::FrameLoaderClientQt::detachedFromParent3):
650         (WebCore::FrameLoaderClientQt::detachedFromParent4):
651         (WebCore::FrameLoaderClientQt::loadedFromPageCache):
652         (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
653         (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad):
654         (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect):
655         (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
656         (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
657         (WebCore::FrameLoaderClientQt::dispatchWillClose):
658         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
659         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
660         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
661         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
662         (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
663         (WebCore::FrameLoaderClientQt::dispatchShow):
664         (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
665         (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
666         (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource):
667         (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache):
668         (WebCore::FrameLoaderClientQt::isLoadingFromPageCache):
669         (WebCore::FrameLoaderClientQt::revertToProvisionalState):
670         (WebCore::FrameLoaderClientQt::clearUnarchivingState):
671         (WebCore::FrameLoaderClientQt::progressStarted):
672         (WebCore::FrameLoaderClientQt::progressCompleted):
673         (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
674         (WebCore::FrameLoaderClientQt::willChangeTitle):
675         (WebCore::FrameLoaderClientQt::didChangeTitle):
676         (WebCore::FrameLoaderClientQt::finishedLoading):
677         (WebCore::FrameLoaderClientQt::finalSetupForReplace):
678         (WebCore::FrameLoaderClientQt::setDefersLoading):
679         (WebCore::FrameLoaderClientQt::isArchiveLoadPending):
680         (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad):
681         (WebCore::FrameLoaderClientQt::clearArchivedResources):
682         (WebCore::FrameLoaderClientQt::canShowMIMEType):
683         (WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
684         (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
685         (WebCore::FrameLoaderClientQt::frameLoadCompleted):
686         (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState):
687         (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
688         (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent):
689         (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll):
690         (WebCore::FrameLoaderClientQt::didFinishLoad):
691         (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
692         (WebCore::FrameLoaderClientQt::setTitle):
693         (WebCore::FrameLoaderClientQt::userAgent):
694         * loader/qt/FrameLoaderClientQt.h: Added.
695         * loader/qt/FrameLoaderQt.cpp:
696         (WebCore::FrameLoader::submitForm):
697         (WebCore::FrameLoader::overrideMediaType):
698         (WebCore::FrameLoader::getHistoryLength):
699         (WebCore::FrameLoader::referrer):
700         (WebCore::FrameLoader::detachFromParent):
701         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
702         (WebCore::FrameLoader::goBackOrForward):
703         (WebCore::FrameLoader::historyURL):
704         (WebCore::FrameLoader::didFirstLayout):
705         (WebCore::FrameLoader::canGoBackOrForward):
706         (WebCore::FrameLoader::partClearedInBegin):
707         (WebCore::FrameLoader::saveDocumentState):
708         (WebCore::FrameLoader::restoreDocumentState):
709         (WebCore::FrameLoader::didChangeTitle):
710         (WebCore::FrameLoader::redirectDataToPlugin):
711         (WebCore::PolicyCheck::PolicyCheck):
712         (WebCore::PolicyCheck::clear):
713         (WebCore::PolicyCheck::set):
714         (WebCore::PolicyCheck::call):
715         (WebCore::PolicyCheck::clearRequest):
716         * loader/qt/NavigationActionQt.cpp: Added.
717         (WebCore::navigationType):
718         (WebCore::NavigationAction::NavigationAction):
719         * loader/qt/ResourceLoaderQt.cpp: Added.
720         (WebCore::ResourceLoader::ResourceLoader):
721         (WebCore::ResourceLoader::~ResourceLoader):
722         (WebCore::ResourceLoader::setDefersLoading):
723         (WebCore::ResourceLoader::cancel):
724         (WebCore::ResourceLoader::loadsBlocked):
725         * platform/MimeTypeRegistry.cpp:
726         (WebCore::initialiseSupportedImageMIMETypes):
727         * platform/network/qt/ResourceHandleManager.cpp:
728         (WebCore::ResourceHandleManager::slotResult):
729         (WebCore::ResourceHandleManager::cancel):
730         * platform/qt/ChromeClientQt.cpp: Added.
731         (WebCore::rootWindowForFrame):
732         (WebCore::ChromeClientQt::ChromeClientQt):
733         (WebCore::ChromeClientQt::~ChromeClientQt):
734         (WebCore::ChromeClientQt::setWindowRect):
735         (WebCore::ChromeClientQt::windowRect):
736         (WebCore::ChromeClientQt::pageRect):
737         (WebCore::ChromeClientQt::scaleFactor):
738         (WebCore::ChromeClientQt::focus):
739         (WebCore::ChromeClientQt::unfocus):
740         (WebCore::ChromeClientQt::createWindow):
741         (WebCore::ChromeClientQt::createModalDialog):
742         (WebCore::ChromeClientQt::show):
743         (WebCore::ChromeClientQt::canRunModal):
744         (WebCore::ChromeClientQt::runModal):
745         (WebCore::ChromeClientQt::setToolbarsVisible):
746         (WebCore::ChromeClientQt::toolbarsVisible):
747         (WebCore::ChromeClientQt::setStatusbarVisible):
748         (WebCore::ChromeClientQt::statusbarVisible):
749         (WebCore::ChromeClientQt::setScrollbarsVisible):
750         (WebCore::ChromeClientQt::scrollbarsVisible):
751         (WebCore::ChromeClientQt::setMenubarVisible):
752         (WebCore::ChromeClientQt::menubarVisible):
753         (WebCore::ChromeClientQt::setResizable):
754         * platform/qt/ChromeClientQt.h: Added.
755         * platform/qt/EditorClientQt.cpp:
756         (WebCore::EditorClientQt::shouldBeginEditing):
757         (WebCore::EditorClientQt::shouldEndEditing):
758         (WebCore::EditorClientQt::shouldApplyStyle):
759         (WebCore::EditorClientQt::didBeginEditing):
760         (WebCore::EditorClientQt::respondToChangedContents):
761         (WebCore::EditorClientQt::didEndEditing):
762         * platform/qt/EditorClientQt.h:
763         * platform/qt/FrameQt.cpp:
764         (WebCore::FrameQt::FrameQt):
765         (WebCore::FrameQt::~FrameQt):
766         (WebCore::FrameQt::keyEvent):
767         * platform/qt/FrameQt.h:
768         * platform/qt/FrameQtClient.cpp:
769         (WebCore::FrameQtClientDefault::openURL):
770         (WebCore::FrameQtClientDefault::didReceiveData):
771         (WebCore::FrameQtClientDefault::receivedAllData):
772         * platform/qt/ImageQt.cpp:
773         * platform/qt/MimeTypeRegistryQt.cpp: Added.
774         (WebCore::getMIMETypeForUTI):
775         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
776         * platform/qt/PageQt.cpp:
777         * platform/qt/PlatformKeyboardEventQt.cpp:
778         (WebCore::keyIdentifierForQtKeyCode):
779         * platform/qt/ScreenQt.cpp:
780         * platform/qt/TemporaryLinkStubs.cpp:
781         (WebCore::TextField::TextField):
782         (WebCore::screenDepth):
783         (WebCore::screenDepthPerComponent):
784         (WebCore::screenIsMonochrome):
785         (WebCore::screenRect):
786         (WebCore::screenAvailableRect):
787
788 2006-11-10  Brady Eidson <beidson@apple.com>
789
790         Reviewed by Mitz
791
792         http://bugs.webkit.org/show_bug.cgi?id=11554
793         Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
794         in case the icon load fails after some data has been received. 
795
796         * loader/icon/IconLoader.cpp:
797         (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB
798         on error.  Also, as a loader re-factoring sanity check, added an assertion
799         (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon 
800         is already committed to the DB.  Skip doing that step twice.
801
802 2006-11-09  Oliver Hunt  <oliver@apple.com>
803
804         Reviewed by Brady.
805
806         Pulled MIME type handling out of WebFrameBridge and added
807         a general C++ class to store/query MIME info
808         Added an Obj-C bridge to provide WebKit with access to the
809         MimeTypeRegistry for non-Obj-C++ classes.
810         
811         * WebCore.exp:
812         * WebCore.xcodeproj/project.pbxproj:
813         * bridge/mac/WebCoreFrameBridge.h:
814         * bridge/mac/WebCoreFrameBridge.mm:
815         * bridge/mac/WebMimeTypeRegistryBridge.h: Added.
816         * bridge/mac/WebMimeTypeRegistryBridge.mm: Added.
817         (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]):
818         (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]):
819         (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]):
820         (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]):
821         (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
822         * platform/Image.cpp:
823         (WebCore::Image::supportsType):
824         * platform/Image.h:
825         * platform/MimeTypeRegistry.cpp: Added.
826         (WebCore::initialiseSupportedImageMIMETypes):
827         (WebCore::initialiseSupportedNonImageMimeTypes):
828         (WebCore::initialiseMimeTypeRegistry):
829         (WebCore::MimeTypeRegistry::isSupportedImageMIMEType):
830         (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType):
831         (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType):
832         (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes):
833         (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes):
834         (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
835         * platform/MimeTypeRegistry.h: Added.
836         * platform/mac/ImageMac.mm:
837         * platform/mac/MimeTypeRegistryMac.mm: Added.
838         (WebCore::getMIMETypeForUTI):
839         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
840
841 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
842
843         Reviewed by Oliver.
844
845         - rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search
846         for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size
847         for you and use vsnprintf.
848
849         * bindings/js/kjs_window.cpp:
850         (KJS::Window::isSafeScript):
851         * css/cssparser.cpp:
852         (WebCore::CSSParser::parseColorFromValue):
853         * dom/StyledElement.cpp:
854         (WebCore::StyledElement::addCSSColor):
855         * dom/XMLTokenizer.cpp:
856         (WebCore::XMLTokenizer::handleError):
857         * ksvg2/css/SVGCSSParser.cpp:
858         (WebCore::CSSParser::parseSVGPaint):
859         (WebCore::CSSParser::parseSVGColor):
860         * ksvg2/svg/SVGPathSegArc.h:
861         (WebCore::SVGPathSegArcAbs::toString):
862         (WebCore::SVGPathSegArcRel::toString):
863         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
864         (WebCore::SVGPathSegCurvetoCubicAbs::toString):
865         (WebCore::SVGPathSegCurvetoCubicRel::toString):
866         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
867         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
868         (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
869         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
870         (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
871         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
872         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
873         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
874         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
875         * ksvg2/svg/SVGPathSegLineto.h:
876         (WebCore::SVGPathSegLinetoAbs::toString):
877         (WebCore::SVGPathSegLinetoRel::toString):
878         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
879         (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
880         (WebCore::SVGPathSegLinetoHorizontalRel::toString):
881         * ksvg2/svg/SVGPathSegLinetoVertical.h:
882         (WebCore::SVGPathSegLinetoVerticalAbs::toString):
883         (WebCore::SVGPathSegLinetoVerticalRel::toString):
884         * ksvg2/svg/SVGPathSegMoveto.h:
885         (WebCore::SVGPathSegMovetoAbs::toString):
886         (WebCore::SVGPathSegMovetoRel::toString):
887         * ksvg2/svg/SVGPolyElement.cpp:
888         (WebCore::SVGPolyElement::notifyAttributeChange):
889         * ksvg2/svg/SVGUseElement.cpp:
890         (WebCore::SVGUseElement::closeRenderer):
891         * loader/icon/IconDatabase.cpp:
892         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
893         * loader/icon/SQLDatabase.cpp:
894         (WebCore::SQLDatabase::setSynchronous):
895         * platform/Color.cpp:
896         (WebCore::Color::name):
897         * platform/DeprecatedString.cpp:
898         (WebCore::DeprecatedString::setNum):
899         (WebCore::DeprecatedString::format):
900         * platform/DeprecatedString.h:
901         * platform/PlatformString.h:
902         * platform/String.cpp:
903         (WebCore::String::format):
904         (WebCore::String::number):
905         * platform/mac/KeyEventMac.mm:
906         (WebCore::keyIdentifierForKeyEvent):
907         * platform/win/KeyEventWin.cpp:
908         (WebCore::keyIdentifierForWindowsKeyCode):
909         * rendering/RenderListMarker.cpp:
910         (WebCore::RenderListMarker::calcMinMaxWidth):
911
912 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
913
914         Reviewed by Anders.
915
916         - fixed "Regression: Can't log into gmail.com"
917         - fixed "iBench doesn't report results - tests run but no number is recorded"
918         
919         * platform/network/cf/FormDataStreamCFNet.cpp:
920         (WebCore::setHTTPBody): Removed extra ! character.
921
922 2006-11-09  Beth Dakin  <bdakin@apple.com>
923
924         Reviewed by Hyatt.
925
926         Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in 
927         WebCore::RenderBlock::skipWhitespace
928
929         Note that this will still crash on Debug builds because it will hit 
930         an assertion failure in editing. (One of the reasons there is no 
931         layout test along with this fix.) There is definitely some editing 
932         wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
933         id=10144 for updates on the assertion failure bug.
934
935         * rendering/RootInlineBox.cpp:
936         (WebCore::RootInlineBox::childRemoved): It is possible for a 
937         prevRootBox and its prevRootBox to share a lineBreakObj. So instead 
938         of just clearing the lineBreakObj of the prevRootBox, cycle through 
939         all prevRootBoxs with the same lineBreakObj. 
940
941 2006-11-09  Adam Roben  <aroben@apple.com>
942
943         Reviewed by Geoff.
944
945         Fix the change in behavior I caused in r17680 with my build fix.
946
947         * rendering/RenderObject.cpp:
948         (WebCore::RenderObject::maxTopMargin):
949         (WebCore::RenderObject::maxBottomMargin):
950
951 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
952
953         Reviewed by Adam, Oliver.
954
955         Move more functions to Editor.
956
957         * bridge/EditorClient.h:
958         * bridge/mac/FrameMac.h:
959         * bridge/mac/FrameMac.mm:
960         * bridge/mac/WebCoreFrameBridge.h:
961         * editing/EditCommand.cpp:
962         (WebCore::EditCommand::apply):
963         (WebCore::EditCommand::unapply):
964         (WebCore::EditCommand::reapply):
965         * editing/Editor.cpp:
966         (WebCore::Editor::respondToChangedContents):
967         (WebCore::dispatchEditableContentChangedEvents):
968         (WebCore::Editor::appliedEditing):
969         (WebCore::Editor::unappliedEditing):
970         (WebCore::Editor::reappliedEditing):
971         * editing/Editor.h:
972         * editing/TypingCommand.cpp:
973         (WebCore::TypingCommand::typingAddedToOpenCommand):
974         * page/Frame.cpp:
975         * page/Frame.h:
976
977 2006-11-09  Darin Adler  <darin@apple.com>
978
979         * rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
980
981 2006-11-09  Alice Liu  <alice.liu@apple.com>
982
983         Reviewed by Beth Dakin.
984
985         Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
986         All existing layout tests pass
987
988         * html/HTMLTableElement.cpp:
989         (WebCore::HTMLTableElement::deleteRow):
990         check lastSection before deleting row
991
992 2006-11-09  Darin Adler  <darin@apple.com>
993
994         - improved version of last night's build fix (should not do using namespace in a header)
995
996         * rendering/RenderObject.h:
997         * rendering/RenderObject.cpp:
998         (WebCore::RenderObject::maxTopMargin):
999         (WebCore::RenderObject::maxBottomMargin):
1000
1001 2006-11-08  Maciej Stachowiak  <mjs@apple.com>
1002
1003         Reviewed by Geoff.
1004         
1005         - added ResourceError class and didFailWithError client method
1006
1007         * WebCore.xcodeproj/project.pbxproj:
1008         * loader/icon/IconLoader.cpp:
1009         (WebCore::IconLoader::didFailWithError):
1010         (WebCore::IconLoader::didFinishLoading):
1011         * loader/icon/IconLoader.h:
1012         * loader/loader.cpp:
1013         (WebCore::Loader::receivedAllData):
1014         (WebCore::Loader::didFailWithError):
1015         * loader/loader.h:
1016         * loader/mac/SubresourceLoaderMac.mm:
1017         (WebCore::SubresourceLoader::didFail):
1018         (WebCore::SubresourceLoader::didCancel):
1019         * platform/cf/RetainPtr.h:
1020         (WebCore::):
1021         (WebCore::adoptCFReference):
1022         (WebCore::RetainPtr::RetainPtr):
1023         (WebCore::::adopt):
1024         * platform/network/ResourceError.cpp: Added.
1025         * platform/network/ResourceError.h: Added.
1026         (WebCore::ResourceError::ResourceError):
1027         (WebCore::ResourceError::domain):
1028         (WebCore::ResourceError::errorCode):
1029         (WebCore::ResourceError::failingURL):
1030         (WebCore::ResourceError::localizedDescription):
1031         (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
1032         * platform/network/ResourceHandle.cpp:
1033         * platform/network/ResourceHandle.h:
1034         * platform/network/ResourceHandleClient.h:
1035         (WebCore::ResourceHandleClient::didFailWithError):
1036         * platform/network/cf/ResourceHandleCFNet.cpp:
1037         (WebCore::didFail):
1038         (WebCore::ResourceHandle::cancel):
1039         * platform/network/mac/ResourceErrorMac.mm: Added.
1040         (-[NSError WebCore]):
1041         * platform/network/mac/ResourceHandleMac.mm:
1042         (WebCore::ResourceHandle::reportError):
1043         * xml/xmlhttprequest.cpp:
1044         (WebCore::XMLHttpRequest::didFailWithError):
1045         (WebCore::XMLHttpRequest::didFinishLoading):
1046         * xml/xmlhttprequest.h:
1047
1048 2006-11-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1049
1050         Reviewed by Maciej.
1051
1052         Linux\Gdk fixes.
1053
1054         * platform/gdk/ChromeClientGdk.h:
1055         (WebCore::ChromeClientGdk::~ChromeClientGdk):
1056         * platform/gdk/CursorGdk.cpp:
1057         (WebCore::Cursor::Cursor):
1058         (WebCore::moveCursor):
1059         * platform/gdk/FrameGdk.cpp:
1060         (WebCore::FrameGdk::FrameGdk):
1061         (WebCore::FrameGdk::submitForm):
1062         (WebCore::FrameGdk::urlSelected):
1063         * platform/gdk/PageGdk.cpp:
1064         * platform/gdk/ScreenClientGdk.h: Added.
1065         (WebCore::ScreenClientGdk::~ScreenClientGdk):
1066         * platform/gdk/ScreenGdk.cpp:
1067         (WebCore::ScreenClientGdk::depth):
1068         (WebCore::ScreenClientGdk::depthPerComponent):
1069         (WebCore::ScreenClientGdk::isMonochrome):
1070         (WebCore::ScreenClientGdk::rect):
1071         (WebCore::ScreenClientGdk::usableRect):
1072         * platform/gdk/TemporaryLinkStubs.cpp:
1073         (FrameGdk::historyURL):
1074         (ChromeClientGdk::windowRect):
1075         (ChromeClientGdk::setWindowRect):
1076         (ChromeClientGdk::pageRect):
1077         (ChromeClientGdk::scaleFactor):
1078         (ChromeClientGdk::focus):
1079         (ChromeClientGdk::unfocus):
1080         (ChromeClientGdk::createWindow):
1081         (ChromeClientGdk::createModalDialog):
1082         (ChromeClientGdk::show):
1083         (ChromeClientGdk::canRunModal):
1084         (ChromeClientGdk::runModal):
1085         (ChromeClientGdk::setToolbarsVisible):
1086         (ChromeClientGdk::toolbarsVisible):
1087         (ChromeClientGdk::setStatusbarVisible):
1088         (ChromeClientGdk::statusbarVisible):
1089         (ChromeClientGdk::setScrollbarsVisible):
1090         (ChromeClientGdk::scrollbarsVisible):
1091         (ChromeClientGdk::setMenubarVisible):
1092         (ChromeClientGdk::menubarVisible):
1093         (ChromeClientGdk::setResizable):
1094         * platform/network/ResourceHandleInternal.h:
1095         (WebCore::ResourceHandleInternal::client):
1096         * platform/network/gdk/ResourceHandleManager.cpp:
1097         (WebCore::writeCallback):
1098         (WebCore::ResourceHandleManager::downloadTimerCallback):
1099         (WebCore::ResourceHandleManager::remove):
1100
1101 2006-11-08  Adam Roben  <aroben@apple.com>
1102
1103         Build fix.
1104
1105         * rendering/RenderObject.h:
1106         (WebCore::RenderObject::maxTopMargin):
1107         (WebCore::RenderObject::maxBottomMargin):
1108
1109 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1110
1111         Reviewed by Anders Carlsson.
1112
1113         Made Screen a good platform citizen by removing its reference to Page. This
1114         made a class unnecessary, so all screen fuctions are stand-alone now.
1115
1116         * bindings/js/kjs_window.cpp: Removed unnecessary subtractions
1117         when computing the screen's available dimensions.
1118
1119 2006-11-08  Sam Weinig  <sam.weinig@gmail.com>
1120
1121         Reviewed by Mitz.
1122
1123         Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
1124         Cleanup RenderObject
1125
1126         * rendering/RenderObject.cpp:
1127         (WebCore::RenderObject::operator delete):
1128         (WebCore::RenderObject::createObject):
1129         (WebCore::RenderObjectCounter::~RenderObjectCounter):
1130         (WebCore::RenderObject::RenderObject):
1131         (WebCore::RenderObject::isDescendantOf):
1132         (WebCore::RenderObject::isRoot):
1133         (WebCore::RenderObject::addChild):
1134         (WebCore::RenderObject::removeChildNode):
1135         (WebCore::RenderObject::removeChild):
1136         (WebCore::RenderObject::appendChildNode):
1137         (WebCore::RenderObject::insertChildNode):
1138         (WebCore::RenderObject::nextInPreOrder):
1139         (WebCore::RenderObject::nextInPreOrderAfterChildren):
1140         (WebCore::RenderObject::previousInPreOrder):
1141         (WebCore::RenderObject::isEditable):
1142         (WebCore::RenderObject::nextEditable):
1143         (WebCore::RenderObject::previousEditable):
1144         (WebCore::RenderObject::firstLeafChild):
1145         (WebCore::RenderObject::lastLeafChild):
1146         (WebCore::RenderObject::addLayers):
1147         (WebCore::RenderObject::removeLayers):
1148         (WebCore::RenderObject::moveLayers):
1149         (WebCore::RenderObject::findNextLayer):
1150         (WebCore::RenderObject::enclosingLayer):
1151         (WebCore::RenderObject::updateFirstLetter):
1152         (WebCore::RenderObject::offsetParent):
1153         (WebCore::RenderObject::scroll):
1154         (WebCore::RenderObject::hasStaticX):
1155         (WebCore::RenderObject::setNeedsLayout):
1156         (WebCore::RenderObject::setChildNeedsLayout):
1157         (WebCore::RenderObject::markContainingBlocksForLayout):
1158         (WebCore::RenderObject::containingBlock):
1159         (WebCore::RenderObject::containingBlockWidth):
1160         (WebCore::RenderObject::containingBlockHeight):
1161         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
1162         (WebCore::RenderObject::drawBorderArc):
1163         (WebCore::RenderObject::drawBorder):
1164         (WebCore::RenderObject::paintBorderImage):
1165         (WebCore::RenderObject::paintBorder):
1166         (WebCore::RenderObject::absoluteRects):
1167         (WebCore::RenderObject::addPDFURLRect):
1168         (WebCore::RenderObject::addFocusRingRects):
1169         (WebCore::RenderObject::paintOutline):
1170         (WebCore::RenderObject::repaint):
1171         (WebCore::RenderObject::repaintRectangle):
1172         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
1173         (WebCore::RenderObject::repaintObjectsBeforeLayout):
1174         (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
1175         (WebCore::RenderObject::information):
1176         (WebCore::RenderObject::dump):
1177         (WebCore::selectStartNode):
1178         (WebCore::RenderObject::shouldSelect):
1179         (WebCore::RenderObject::draggableNode):
1180         (WebCore::RenderObject::createAnonymousBlock):
1181         (WebCore::RenderObject::handleDynamicFloatPositionChange):
1182         (WebCore::RenderObject::setStyle):
1183         (WebCore::RenderObject::setStyleInternal):
1184         (WebCore::RenderObject::updateBackgroundImages):
1185         (WebCore::RenderObject::absolutePosition):
1186         (WebCore::RenderObject::caretRect):
1187         (WebCore::RenderObject::paddingTop):
1188         (WebCore::RenderObject::paddingBottom):
1189         (WebCore::RenderObject::paddingLeft):
1190         (WebCore::RenderObject::paddingRight):
1191         (WebCore::RenderObject::tabWidth):
1192         (WebCore::RenderObject::container):
1193         (WebCore::RenderObject::removeFromObjectLists):
1194         (WebCore::RenderObject::destroy):
1195         (WebCore::RenderObject::arenaDelete):
1196         (WebCore::RenderObject::hitTest):
1197         (WebCore::RenderObject::setInnerNode):
1198         (WebCore::RenderObject::nodeAtPoint):
1199         (WebCore::RenderObject::verticalPositionHint):
1200         (WebCore::RenderObject::getVerticalPosition):
1201         (WebCore::RenderObject::lineHeight):
1202         (WebCore::RenderObject::invalidateVerticalPositions):
1203         (WebCore::RenderObject::recalcMinMaxWidths):
1204         (WebCore::RenderObject::scheduleRelayout):
1205         (WebCore::RenderObject::setInlineBoxWrapper):
1206         (WebCore::RenderObject::firstLineStyle):
1207         (WebCore::RenderObject::getPseudoStyle):
1208         (WebCore::RenderObject::getTextDecorationColors):
1209         (WebCore::RenderObject::addDashboardRegions):
1210         (WebCore::RenderObject::collectDashboardRegions):
1211         (WebCore::RenderObject::avoidsFloats):
1212         (WebCore::RenderObject::findCounter):
1213         (WebCore::RenderObject::backslashAsCurrencySymbol):
1214         (WebCore::RenderObject::imageChanged):
1215         (WebCore::RenderObject::previousOffset):
1216         (WebCore::RenderObject::nextOffset):
1217         (WebCore::RenderObject::inlineBox):
1218         * rendering/RenderObject.h:
1219         (WebCore::):
1220         (WebCore::RenderObject::renderName):
1221         (WebCore::RenderObject::parent):
1222         (WebCore::RenderObject::previousSibling):
1223         (WebCore::RenderObject::nextSibling):
1224         (WebCore::RenderObject::firstChild):
1225         (WebCore::RenderObject::lastChild):
1226         (WebCore::RenderObject::getOverflowClipRect):
1227         (WebCore::RenderObject::getClipRect):
1228         (WebCore::RenderObject::getBaselineOfFirstLineBox):
1229         (WebCore::RenderObject::setEdited):
1230         (WebCore::RenderObject::setStaticX):
1231         (WebCore::RenderObject::setStaticY):
1232         (WebCore::RenderObject::setPreviousSibling):
1233         (WebCore::RenderObject::setNextSibling):
1234         (WebCore::RenderObject::setParent):
1235         (WebCore::RenderObject::isInlineBlockOrInlineTable):
1236         (WebCore::RenderObject::isRenderView):
1237         (WebCore::RenderObject::childrenInline):
1238         (WebCore::RenderObject::setChildrenInline):
1239         (WebCore::RenderObject::isAnonymousBlock):
1240         (WebCore::RenderObject::isDragging):
1241         (WebCore::RenderObject::needsLayout):
1242         (WebCore::RenderObject::setMinMaxKnown):
1243         (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
1244         (WebCore::RenderObject::setPositioned):
1245         (WebCore::RenderObject::setRelPositioned):
1246         (WebCore::RenderObject::setFloating):
1247         (WebCore::RenderObject::setInline):
1248         (WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
1249         (WebCore::RenderObject::setReplaced):
1250         (WebCore::RenderObject::PaintInfo::PaintInfo):
1251         (WebCore::RenderObject::paintBackgroundExtended):
1252         (WebCore::RenderObject::calcWidth):
1253         (WebCore::RenderObject::updateFromElement):
1254         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
1255         (WebCore::RenderObject::setOverrideSize):
1256         (WebCore::RenderObject::setPos):
1257         (WebCore::RenderObject::setWidth):
1258         (WebCore::RenderObject::setHeight):
1259         (WebCore::RenderObject::absolutePositionForContent):
1260         (WebCore::RenderObject::overflowHeight):
1261         (WebCore::RenderObject::overflowWidth):
1262         (WebCore::RenderObject::setOverflowHeight):
1263         (WebCore::RenderObject::setOverflowWidth):
1264         (WebCore::RenderObject::overflowLeft):
1265         (WebCore::RenderObject::overflowTop):
1266         (WebCore::RenderObject::overflowRect):
1267         (WebCore::RenderObject::stopAutoscroll):
1268         (WebCore::RenderObject::collapsedMarginTop):
1269         (WebCore::RenderObject::collapsedMarginBottom):
1270         (WebCore::RenderObject::maxTopMargin):
1271         (WebCore::RenderObject::maxBottomMargin):
1272         (WebCore::RenderObject::):
1273         (WebCore::RenderObject::setTable):
1274         (WebCore::RenderObject::isFloatingOrPositioned):
1275         (WebCore::RenderObject::containsFloat):
1276         (WebCore::RenderObject::setSelectionState):
1277         (WebCore::RenderObject::SelectionInfo::SelectionInfo):
1278         (WebCore::RenderObject::lowestPosition):
1279         (WebCore::RenderObject::rightmostPosition):
1280         (WebCore::RenderObject::leftmostPosition):
1281         (WebCore::RenderObject::calcVerticalMargins):
1282         (WebCore::RenderObject::font):
1283
1284 2006-11-08  Darin Adler  <darin@apple.com>
1285
1286         Reviewed by Anders.
1287
1288         - added event parameters to focus-related functions so we can
1289           implement the "option-tab to all links" behavior without relying
1290           on a global "current event" -- also makes it work with DOM events
1291
1292         * page/Frame.h: Removed unneeded includes. Moved some functions
1293         that were misplaced into the appropriate sections.
1294         * page/Frame.cpp:
1295         (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
1296         PlatformKeyboardEvent to the DOM keyboard event class.
1297         (WebCore::Frame::tabsToLinks): Added event parameter.
1298         (WebCore::Frame::tabsToAllControls): Ditto.
1299         (WebCore::scanForForm): Fixed code that incorrectly assumes
1300         that an iframe is an HTMLFrameElement (no longer true since Geoff
1301         changed the class hierarchy a bit).
1302         (WebCore::Frame::hitTestResultAtPoint): Ditto.
1303
1304         * bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
1305         that were misplaced into the appropriate sections.
1306         * bridge/mac/FrameMac.mm:
1307         (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
1308         a PlatformKeyboardEvent.
1309         (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
1310         and pass event into next/previousFocusNode.
1311         (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
1312         the AppKit current event, if it's a keyboard event. Really just a hack that's
1313         needed to preserve some code we can remove once we deal with the last NSView-
1314         based form control.
1315         (WebCore::isKeyboardOptionTab): Added.
1316         (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
1317         option (alt) key is down.
1318         (WebCore::FrameMac::tabsToAllControls): Ditto.
1319         (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
1320         call resetMultipleFormSubmissionProtection() explicitly instead.
1321         (WebCore::FrameMac::mouseDown): Ditto.
1322
1323         * bridge/mac/WebCoreAXObject.mm:
1324         (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
1325         assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
1326         changed the class hierarchy a bit).
1327         (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
1328         prepareForUserAction() to call resetMultipleFormSubmissionProtection()
1329         explicitly instead.
1330
1331         * page/FrameView.h:
1332         * page/FrameView.cpp:
1333         (WebCore::FrameView::advanceFocus): Changed function to take an
1334         event parameter, and decide the direction based on the shift key
1335         modifier instead of a passed-in boolean.
1336
1337         * dom/Document.h:
1338         * dom/Document.cpp:
1339         (WebCore::Document::nextFocusNode): Added event parameter.
1340         (WebCore::Document::previousFocusNode): Ditto.
1341         * dom/Node.h:
1342         * dom/Node.cpp:
1343         (WebCore::Node::isKeyboardFocusable): Ditto.
1344         * html/HTMLAnchorElement.h:
1345         * html/HTMLAnchorElement.cpp:
1346         (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
1347         * html/HTMLGenericFormElement.h:
1348         * html/HTMLGenericFormElement.cpp:
1349         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
1350         * html/HTMLInputElement.h:
1351         * html/HTMLInputElement.cpp:
1352         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
1353         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
1354         * html/HTMLSelectElement.h:
1355         * html/HTMLSelectElement.cpp:
1356         (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
1357         * html/HTMLTextAreaElement.h:
1358         * html/HTMLTextAreaElement.cpp:
1359         (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
1360
1361         * dom/EventTargetNode.cpp:
1362         (WebCore::EventTargetNode::defaultEventHandler): Pass event to the
1363         advanceFocus function.
1364
1365         * platform/TextField.h:
1366         * platform/mac/TextFieldMac.mm: Removed the non-search field code.
1367
1368         * platform/mac/WebCoreTextField.h:
1369         * platform/mac/WebCoreTextField.mm: Removed the non-search field code.
1370         (-[WebCoreTextFieldController controlTextDidChange:]): Removed the
1371         call to FrameMac::handleKeyboardOptionTabInView, which is no longer
1372         needed since the default handler in HTMLInputElement takes care of
1373         option-tab.
1374
1375         * platform/mac/SliderMac.mm:
1376         (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
1377         and pass event into tabsToAllControls.
1378         (Slider::focusPolicy): Ditto.
1379
1380         * rendering/RenderLineEdit.cpp:
1381         (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
1382         (WebCore::RenderLineEdit::updateFromElement): Ditto.
1383
1384 2006-11-08  Brady Eidson  <beidson@apple.com>
1385
1386         Reviewed by Dave Harrison, Oliver, and Darin 
1387         (oh my!  where was superkevin on this one?)
1388
1389         <rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
1390
1391         More "free nil checking" we lost in the transition from ObjC to C++
1392
1393         * loader/mac/FrameLoaderMac.mm:
1394         (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
1395         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
1396
1397 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1398
1399         Reviewed by Adam.
1400
1401         Move more code into editor.
1402         
1403         * WebCore.exp:
1404         * bridge/EditorClient.h:
1405         * bridge/mac/FrameMac.h:
1406         * bridge/mac/FrameMac.mm:
1407         * bridge/mac/WebCoreFrameBridge.h:
1408         * dom/Document.cpp:
1409         (WebCore::Document::relinquishesEditingFocus):
1410         (WebCore::Document::acceptsEditingFocus):
1411         (WebCore::Document::didBeginEditing):
1412         (WebCore::Document::didEndEditing):
1413         * editing/Editor.cpp:
1414         (WebCore::Editor::indent):
1415         (WebCore::Editor::outdent):
1416         * editing/Editor.h:
1417         * page/Frame.cpp:
1418         * page/Frame.h:
1419
1420 2006-11-08  Beth Dakin  <bdakin@apple.com>
1421
1422         Reviewed by Adam.
1423
1424         Add ability to HitTestResult to ask if the inner non-shared node is 
1425         content editable.
1426
1427         * WebCore.exp: Export HitTestResult::isContentEditable()
1428         * rendering/HitTestResult.cpp:
1429         (WebCore::HitTestResult::isContentEditable):
1430         * rendering/HitTestResult.h:
1431
1432 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1433
1434         Build fix.
1435         
1436         * WebCore.xcodeproj/project.pbxproj:
1437         Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
1438
1439 2006-11-08  Timothy Hatcher  <timothy@apple.com>
1440
1441         Reviewed by Darin.
1442
1443         <rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
1444         <rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
1445
1446         Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
1447
1448         * bindings/objc/DOM.mm:
1449         (WebCore::kit):
1450         (-[DOMNode lineBoxRects]):
1451         (-[DOMRange boundingBox]):
1452         (-[DOMRange lineBoxRects]):
1453         * bindings/objc/DOMPrivate.h:
1454         * dom/Range.cpp:
1455         (WebCore::Range::boundingBox):
1456         (WebCore::Range::addLineBoxRects):
1457         * dom/Range.h:
1458         * rendering/RenderContainer.cpp:
1459         (WebCore::RenderContainer::addLineBoxRects):
1460         * rendering/RenderContainer.h:
1461         * rendering/RenderObject.cpp:
1462         (WebCore::RenderObject::addLineBoxRects):
1463         * rendering/RenderObject.h:
1464         * rendering/RenderText.cpp:
1465         (WebCore::RenderText::addLineBoxRects):
1466         * rendering/RenderText.h:
1467
1468 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1469
1470         Reviewed by Oliver.
1471         
1472         Move methods from the bridge and frame into editor.
1473         
1474         * WebCore.exp:
1475         * bridge/EditorClient.h:
1476         * bridge/mac/WebCoreFrameBridge.h:
1477         * bridge/mac/WebCoreFrameBridge.mm:
1478         * editing/Editor.cpp:
1479         (WebCore::Editor::removeFormattingAndStyle):
1480         (WebCore::Editor::applyStyle):
1481         (WebCore::Editor::applyParagraphStyle):
1482         (WebCore::Editor::applyStyleToSelection):
1483         (WebCore::Editor::applyParagraphStyleToSelection):
1484         (WebCore::Editor::toggleBold):
1485         (WebCore::Editor::toggleItalic):
1486         (WebCore::Editor::selectionStartHasStyle):
1487         * editing/Editor.h:
1488         * editing/JSEditor.cpp:
1489         * page/Frame.cpp:
1490         * page/Frame.h:
1491
1492 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1493
1494         Reviewed by Beth.
1495         
1496         Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
1497         be able to dispatch user events even when off-screen, so we have to support
1498         off-screen windows when handling mouse events.
1499
1500         * platform/Screen.h:
1501         * platform/mac/PlatformMouseEventMac.mm:
1502         (WebCore::globalPoint): Grab the best screen instead of the screen you're
1503         on, since you might be off-screen.
1504         * platform/mac/ScreenMac.mm:
1505         (WebCore::screenForWindow):
1506
1507 2006-11-08  Darin Adler  <darin@apple.com>
1508
1509         - fix bug caused by last-minute change to my check-in last night
1510           that is causing layout tests to hang
1511
1512         * dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
1513         * loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn
1514         a null string into an empty string before calling completeURL.
1515
1516 2006-11-08  Brady Eidson <beidson@apple.com>
1517
1518         Reviewed by Maciej
1519
1520         If the request has already been aborted, bail out of didFinishLoading()
1521         immediately.  This prevents state change notifications that aren't
1522         needed.
1523
1524         * xml/xmlhttprequest.cpp:
1525         (WebCore::XMLHttpRequest::didFinishLoading):
1526
1527 2006-11-08  Darin Adler  <darin@apple.com>
1528
1529         - another attempt to fix Qt build
1530
1531         * loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
1532
1533 2006-11-08  Darin Adler  <darin@apple.com>
1534
1535         Reviewed by Geoff.
1536
1537         - stray bits of my FrameLoader patch that I left out by accident
1538
1539         * loader/FrameLoader.cpp:
1540         (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer()
1541         inside the FrameLoader class.
1542         (WebCore::FrameLoader::requestFrame): Use less DeprecatedString.
1543         (WebCore::FrameLoader::clear): Stop the redirection timer.
1544         (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the
1545         entire function in an if statement. Use less DeprecatedString.
1546         (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator.
1547         (WebCore::FrameLoader::scheduleRefresh): Ditto.
1548         (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer()
1549         inside the FrameLoader class.
1550         * loader/mac/FrameLoaderMac.mm:
1551         (WebCore::FrameLoader::load): Ditto.
1552         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
1553
1554 2006-11-07  Beth Dakin  <bdakin@apple.com>
1555
1556         Reviewed by Hyatt.
1557
1558         Another go at fix for <rdar://problem/4820814> A crash occurs at 
1559         WebCore::HitTestResult::spellingToolTip() when mousing down on 
1560         iframe at www.macsurfer.com
1561
1562         The fix from yesterday caused a layout test regression which 
1563         exposed an existing bug. The existing bug was that we allowed text 
1564         nodes to stay in the head tag, but other browsers move them to the 
1565         body. The previous fix also caused a performance regression, which 
1566         was seemingly easy to fix by moving the new clause in 
1567         HTMLParser::handleError() to be below the HTMLElement case.
1568
1569         * html/HTMLDocument.cpp:
1570         (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to 
1571         be the child of the document.
1572         * html/HTMLHeadElement.cpp:
1573         (WebCore::HTMLHeadElement::childAllowed): Do not allow non-
1574         whitespace text nodes to be children of the head.
1575         * html/HTMLHeadElement.h:
1576         * html/HTMLParser.cpp:
1577         (WebCore::HTMLParser::handleError): Error case for comment nodes.
1578         * page/FrameView.cpp:
1579         (WebCore::FrameView::handleMousePressEvent): Safety-net null check 
1580         for the original crash. 
1581
1582 2006-11-07  Darin Adler  <darin@apple.com>
1583
1584         - another attempt to fix Qt build
1585
1586         * loader/icon/IconLoader.h: Added missing include.
1587
1588 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1589
1590         Reviewed by Tim Hatcher.
1591         
1592         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
1593         
1594         None of Screen's responsibilities require up-calls to WebKit or delegates, 
1595         so WebCore can handle it all.
1596         
1597         Moved Screen back from page/ to platform/ because it's a platform
1598         abstraction again.
1599
1600         Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
1601         since the two were always used together.
1602         
1603         Changed pixel depth queries to query the deepest screen. Darin mentioned
1604         that it might have been a feature, not a bug, to use the main/menubar screen
1605         regardless of the screen you were on. For scaling and flipping that's not
1606         the case, but for querying pixel depth I think it is. You want to know
1607         about the highest pixel depth your content may display on.
1608         
1609         Tests still pass.
1610
1611         * WebCore.exp:
1612         * WebCore.xcodeproj/project.pbxproj:
1613         * page/Page.cpp:
1614         (WebCore::Page::Page):
1615         * page/Page.h:
1616         * page/Screen.cpp: Removed.
1617         * page/Screen.h: Removed.
1618         * page/ScreenClient.h: Removed.
1619         * platform/mac/PlatformMouseEventMac.mm:
1620         (WebCore::globalPoint):
1621         * platform/mac/ScreenMac.mm:
1622         (WebCore::window):
1623         (WebCore::bestScreen):
1624         (WebCore::Screen::depth):
1625         (WebCore::Screen::depthPerComponent):
1626         (WebCore::Screen::isMonochrome):
1627         (WebCore::Screen::rect):
1628         (WebCore::Screen::usableRect):
1629         (WebCore::toUserSpace):
1630         (WebCore::toDeviceSpace):
1631
1632 2006-11-07  Darin Adler  <darin@apple.com>
1633
1634         - try to fix Qt build
1635
1636         * CMakeLists.txt: Updated for some file changes.
1637         * WebCoreSources.bkl: Ditto.
1638
1639 2006-11-07  Darin Adler  <darin@apple.com>
1640
1641         Reviewed by Geoff.
1642
1643         - moved loader code from Frame/FrameMac to FrameLoader
1644
1645         * WebCore.exp:
1646         * WebCore.xcodeproj/project.pbxproj:
1647         * bindings/js/JSXSLTProcessor.h:
1648         * bindings/js/kjs_events.cpp:
1649         (KJS::JSLazyEventListener::parseCode):
1650         * bindings/js/kjs_html.cpp:
1651         (KJS::JSHTMLDocument::putValueProperty):
1652         * bindings/js/kjs_navigator.cpp:
1653         (KJS::Navigator::getValueProperty):
1654         * bindings/js/kjs_proxy.cpp:
1655         (WebCore::KJSProxy::initScriptIfNeeded):
1656         * bindings/js/kjs_window.cpp:
1657         (KJS::Screen::Screen):
1658         (KJS::createNewWindow):
1659         (KJS::Window::getValueProperty):
1660         (KJS::Window::put):
1661         (KJS::Window::isSafeScript):
1662         (KJS::WindowFunc::callAsFunction):
1663         (KJS::ScheduledAction::execute):
1664         (KJS::Location::getValueProperty):
1665         (KJS::Location::put):
1666         (KJS::Location::toString):
1667         (KJS::LocationFunc::callAsFunction):
1668         (KJS::History::getValueProperty):
1669         (KJS::HistoryFunc::callAsFunction):
1670         * bindings/objc/DOM.mm:
1671         (+[DOMNode _nodeWith:WebCore::]):
1672         * bridge/mac/FrameMac.h:
1673         * bridge/mac/FrameMac.mm:
1674         (WebCore::FrameMac::~FrameMac):
1675         (WebCore::FrameMac::setView):
1676         (WebCore::FrameMac::setStatusBarText):
1677         * bridge/mac/WebCoreFrameBridge.h:
1678         * bridge/mac/WebCoreFrameBridge.mm:
1679         (-[WebCoreFrameBridge close]):
1680         (-[WebCoreFrameBridge addData:]):
1681         (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
1682         (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
1683         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1684         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1685         (-[WebCoreFrameBridge baseURL]):
1686         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
1687         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
1688         (-[WebCoreFrameBridge canProvideDocumentSource]):
1689         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
1690         * css/cssparser.cpp:
1691         (WebCore::CSSParser::parseContent):
1692         * dom/DOMImplementation.cpp:
1693         (WebCore::DOMImplementation::createDocument):
1694         (WebCore::DOMImplementation::createHTMLDocument):
1695         * dom/DOMImplementation.h:
1696         * dom/Document.cpp:
1697         (WebCore::Document::readyState):
1698         (WebCore::Document::updateTitle):
1699         (WebCore::Document::open):
1700         (WebCore::Document::close):
1701         (WebCore::Document::implicitClose):
1702         (WebCore::Document::processHttpEquiv):
1703         (WebCore::Document::referrer):
1704         (WebCore::Document::finishedParsing):
1705         * dom/ProcessingInstruction.cpp:
1706         (WebCore::ProcessingInstruction::checkStyleSheet):
1707         * dom/XMLTokenizer.cpp:
1708         (WebCore::XMLTokenizer::endElementNs):
1709         (WebCore::ignorableWhitespaceHandler):
1710         (WebCore::XMLTokenizer::notifyFinished):
1711         * editing/TextIterator.cpp:
1712         (WebCore::TextIterator::rangeFromLocationAndLength):
1713         * html/HTMLAnchorElement.cpp:
1714         (WebCore::HTMLAnchorElement::defaultEventHandler):
1715         * html/HTMLBaseElement.cpp:
1716         (WebCore::HTMLBaseElement::process):
1717         * html/HTMLDocument.cpp:
1718         (WebCore::HTMLDocument::lastModified):
1719         * html/HTMLFormElement.cpp:
1720         (WebCore::HTMLFormElement::formData):
1721         (WebCore::HTMLFormElement::submit):
1722         * html/HTMLFrameElementBase.cpp:
1723         (WebCore::HTMLFrameElementBase::isURLAllowed):
1724         (WebCore::HTMLFrameElementBase::openURL):
1725         (WebCore::HTMLFrameElementBase::willRemove):
1726         * html/HTMLInputElement.cpp:
1727         (WebCore::HTMLInputElement::setValueFromRenderer):
1728         * html/HTMLLinkElement.cpp:
1729         (WebCore::HTMLLinkElement::process):
1730         * html/HTMLParser.cpp:
1731         (WebCore::HTMLParser::handleError):
1732         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
1733         * html/HTMLPreElement.idl:
1734         * html/HTMLScriptElement.cpp:
1735         (WebCore::HTMLScriptElement::parseMappedAttribute):
1736         (WebCore::HTMLScriptElement::insertedIntoDocument):
1737         * html/HTMLTokenizer.cpp:
1738         (WebCore::HTMLTokenizer::scriptExecution):
1739         (WebCore::HTMLTokenizer::parseTag):
1740         (WebCore::HTMLTokenizer::write):
1741         (WebCore::HTMLTokenizer::stopParsing):
1742         (WebCore::HTMLTokenizer::timerFired):
1743         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1744         (WebCore::KCanvasFilterQuartz::prepareFilter):
1745         * ksvg2/svg/SVGAElement.cpp:
1746         (WebCore::SVGAElement::defaultEventHandler):
1747         * ksvg2/svg/SVGElement.cpp:
1748         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
1749         * loader/DocLoader.cpp:
1750         (WebCore::DocLoader::setLoadInProgress):
1751         * loader/FrameLoader.cpp:
1752         (WebCore::FormSubmission::FormSubmission):
1753         (WebCore::ScheduledRedirection::):
1754         (WebCore::ScheduledRedirection::ScheduledRedirection):
1755         (WebCore::cancelAll):
1756         (WebCore::getString):
1757         (WebCore::isBackForwardLoadType):
1758         (WebCore::numRequests):
1759         (WebCore::FrameLoader::FrameLoader):
1760         (WebCore::FrameLoader::~FrameLoader):
1761         (WebCore::FrameLoader::createWindow):
1762         (WebCore::FrameLoader::changeLocation):
1763         (WebCore::FrameLoader::urlSelected):
1764         (WebCore::FrameLoader::requestFrame):
1765         (WebCore::FrameLoader::loadSubframe):
1766         (WebCore::FrameLoader::submitFormAgain):
1767         (WebCore::FrameLoader::submitForm):
1768         (WebCore::FrameLoader::stopLoading):
1769         (WebCore::FrameLoader::stop):
1770         (WebCore::FrameLoader::closeURL):
1771         (WebCore::FrameLoader::cancelRedirection):
1772         (WebCore::FrameLoader::iconURL):
1773         (WebCore::FrameLoader::didOpenURL):
1774         (WebCore::FrameLoader::didExplicitOpen):
1775         (WebCore::FrameLoader::replaceContentsWithScriptResult):
1776         (WebCore::FrameLoader::executeScript):
1777         (WebCore::FrameLoader::cancelAndClear):
1778         (WebCore::FrameLoader::clear):
1779         (WebCore::FrameLoader::receivedFirstData):
1780         (WebCore::FrameLoader::responseMIMEType):
1781         (WebCore::FrameLoader::setResponseMIMEType):
1782         (WebCore::FrameLoader::begin):
1783         (WebCore::FrameLoader::write):
1784         (WebCore::FrameLoader::end):
1785         (WebCore::FrameLoader::endIfNotLoading):
1786         (WebCore::FrameLoader::startIconLoader):
1787         (WebCore::FrameLoader::commitIconURLToIconDatabase):
1788         (WebCore::FrameLoader::gotoAnchor):
1789         (WebCore::FrameLoader::finishedParsing):
1790         (WebCore::FrameLoader::loadDone):
1791         (WebCore::FrameLoader::checkCompleted):
1792         (WebCore::FrameLoader::checkEmitLoadEvent):
1793         (WebCore::FrameLoader::baseURL):
1794         (WebCore::FrameLoader::baseTarget):
1795         (WebCore::FrameLoader::completeURL):
1796         (WebCore::FrameLoader::scheduleRedirection):
1797         (WebCore::FrameLoader::scheduleLocationChange):
1798         (WebCore::FrameLoader::scheduleRefresh):
1799         (WebCore::FrameLoader::isScheduledLocationChangePending):
1800         (WebCore::FrameLoader::scheduleHistoryNavigation):
1801         (WebCore::FrameLoader::redirectionTimerFired):
1802         (WebCore::FrameLoader::encoding):
1803         (WebCore::FrameLoader::requestObject):
1804         (WebCore::FrameLoader::shouldUsePlugin):
1805         (WebCore::FrameLoader::loadPlugin):
1806         (WebCore::FrameLoader::clearRecordedFormValues):
1807         (WebCore::FrameLoader::recordFormValue):
1808         (WebCore::FrameLoader::parentCompleted):
1809         (WebCore::FrameLoader::outgoingReferrer):
1810         (WebCore::FrameLoader::lastModified):
1811         (WebCore::FrameLoader::opener):
1812         (WebCore::FrameLoader::setOpener):
1813         (WebCore::FrameLoader::openedByJavaScript):
1814         (WebCore::FrameLoader::setOpenedByJavaScript):
1815         (WebCore::FrameLoader::handleFallbackContent):
1816         (WebCore::FrameLoader::provisionalLoadStarted):
1817         (WebCore::FrameLoader::userGestureHint):
1818         (WebCore::FrameLoader::didNotOpenURL):
1819         (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
1820         (WebCore::FrameLoader::setEncoding):
1821         (WebCore::FrameLoader::addData):
1822         (WebCore::FrameLoader::canCachePage):
1823         (WebCore::FrameLoader::updatePolicyBaseURL):
1824         (WebCore::FrameLoader::setPolicyBaseURL):
1825         (WebCore::FrameLoader::scrollToAnchor):
1826         (WebCore::FrameLoader::isComplete):
1827         (WebCore::FrameLoader::isLoadingMainResource):
1828         (WebCore::FrameLoader::url):
1829         (WebCore::FrameLoader::startRedirectionTimer):
1830         (WebCore::FrameLoader::stopRedirectionTimer):
1831         (WebCore::FrameLoader::updateBaseURLForEmptyDocument):
1832         (WebCore::FrameLoader::completed):
1833         (WebCore::FrameLoader::started):
1834         (WebCore::FrameLoader::containsPlugins):
1835         (WebCore::FrameLoader::prepareForLoadStart):
1836         (WebCore::FrameLoader::setupForReplace):
1837         (WebCore::FrameLoader::setupForReplaceByMIMEType):
1838         (WebCore::FrameLoader::finalSetupForReplace):
1839         (WebCore::FrameLoader::load):
1840         (WebCore::FrameLoader::canTarget):
1841         (WebCore::FrameLoader::stopLoadingPlugIns):
1842         (WebCore::FrameLoader::stopLoadingSubresources):
1843         (WebCore::FrameLoader::stopLoadingSubframes):
1844         (WebCore::FrameLoader::stopAllLoaders):
1845         (WebCore::FrameLoader::cancelMainResourceLoad):
1846         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1847         (WebCore::FrameLoader::activeDocumentLoader):
1848         (WebCore::FrameLoader::addPlugInStreamLoader):
1849         (WebCore::FrameLoader::removePlugInStreamLoader):
1850         (WebCore::FrameLoader::hasMainResourceLoader):
1851         (WebCore::FrameLoader::isLoadingSubresources):
1852         (WebCore::FrameLoader::isLoadingPlugIns):
1853         (WebCore::FrameLoader::isLoading):
1854         (WebCore::FrameLoader::addSubresourceLoader):
1855         (WebCore::FrameLoader::removeSubresourceLoader):
1856         (WebCore::FrameLoader::releaseMainResourceLoader):
1857         (WebCore::FrameLoader::setDocumentLoader):
1858         (WebCore::FrameLoader::documentLoader):
1859         (WebCore::FrameLoader::setPolicyDocumentLoader):
1860         (WebCore::FrameLoader::provisionalDocumentLoader):
1861         (WebCore::FrameLoader::setProvisionalDocumentLoader):
1862         (WebCore::FrameLoader::state):
1863         (WebCore::FrameLoader::timeOfLastCompletedLoad):
1864         (WebCore::FrameLoader::setState):
1865         (WebCore::FrameLoader::clearProvisionalLoad):
1866         (WebCore::FrameLoader::markLoadComplete):
1867         (WebCore::FrameLoader::commitProvisionalLoad):
1868         (WebCore::FrameLoader::privateBrowsingEnabled):
1869         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
1870         (WebCore::FrameLoader::clientRedirected):
1871         (WebCore::FrameLoader::shouldReload):
1872         (WebCore::FrameLoader::closeOldDataSources):
1873         (WebCore::FrameLoader::open):
1874         (WebCore::FrameLoader::isStopping):
1875         (WebCore::FrameLoader::finishedLoading):
1876         (WebCore::FrameLoader::URL):
1877         (WebCore::FrameLoader::isArchiveLoadPending):
1878         (WebCore::FrameLoader::isHostedByObjectElement):
1879         (WebCore::FrameLoader::isLoadingMainFrame):
1880         (WebCore::FrameLoader::canShowMIMEType):
1881         (WebCore::FrameLoader::representationExistsForURLScheme):
1882         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
1883         (WebCore::FrameLoader::cancelContentPolicyCheck):
1884         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
1885         (WebCore::FrameLoader::finishedLoadingDocument):
1886         (WebCore::FrameLoader::isReplacing):
1887         (WebCore::FrameLoader::setReplacing):
1888         (WebCore::FrameLoader::revertToProvisional):
1889         (WebCore::FrameLoader::subframeIsLoading):
1890         (WebCore::FrameLoader::willChangeTitle):
1891         (WebCore::FrameLoader::loadType):
1892         (WebCore::FrameLoader::stopPolicyCheck):
1893         (WebCore::FrameLoader::continueAfterContentPolicy):
1894         (WebCore::FrameLoader::continueAfterWillSubmitForm):
1895         (WebCore::FrameLoader::didFirstLayout):
1896         (WebCore::FrameLoader::frameLoadCompleted):
1897         (WebCore::FrameLoader::firstLayoutDone):
1898         (WebCore::FrameLoader::isQuickRedirectComing):
1899         (WebCore::FrameLoader::closeDocument):
1900         (WebCore::FrameLoader::detachChildren):
1901         (WebCore::FrameLoader::checkLoadComplete):
1902         (WebCore::FrameLoader::numPendingOrLoadingRequests):
1903         (WebCore::FrameLoader::setClient):
1904         (WebCore::FrameLoader::client):
1905         (WebCore::FrameLoader::userAgent):
1906         (WebCore::FrameLoader::createEmptyDocument):
1907         (WebCore::FrameLoader::tokenizerProcessedData):
1908         (WebCore::FrameLoader::didTellBridgeAboutLoad):
1909         (WebCore::FrameLoader::haveToldBridgeAboutLoad):
1910         (WebCore::FrameLoader::handledOnloadEvents):
1911         (WebCore::FrameLoader::frameDetached):
1912         (WebCore::FrameLoader::setTitle):
1913         (WebCore::FrameLoaderClient::~FrameLoaderClient):
1914         * loader/FrameLoader.h:
1915         (WebCore::):
1916         * loader/FrameLoaderClient.h:
1917         * loader/PluginDocument.cpp:
1918         (WebCore::PluginTokenizer::createDocumentStructure):
1919         (WebCore::PluginTokenizer::writeRawData):
1920         * loader/ResourceLoader.h:
1921         * loader/TextResourceDecoder.cpp:
1922         (WebCore::TextResourceDecoder::checkForHeadCharset):
1923         * loader/icon/IconLoader.cpp:
1924         (WebCore::IconLoader::startLoading):
1925         (WebCore::IconLoader::finishLoading):
1926         * loader/loader.cpp:
1927         (WebCore::Loader::didReceiveResponse):
1928         * loader/mac/DocumentLoaderMac.mm:
1929         (WebCore::DocumentLoader::~DocumentLoader):
1930         (WebCore::DocumentLoader::stopLoading):
1931         (WebCore::DocumentLoader::finishedLoading):
1932         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
1933         (WebCore::DocumentLoader::setPrimaryLoadComplete):
1934         * loader/mac/FrameLoaderMac.mm:
1935         (WebCore::FrameLoader::load):
1936         (WebCore::FrameLoader::startLoading):
1937         (WebCore::FrameLoader::cancelMainResourceLoad):
1938         (WebCore::FrameLoader::receivedMainResourceError):
1939         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
1940         (WebCore::FrameLoader::commitProvisionalLoad):
1941         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
1942         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1943         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
1944         (WebCore::FrameLoader::detachFromParent):
1945         (WebCore::FrameLoader::addExtraFieldsToRequest):
1946         (WebCore::FrameLoader::loadResourceSynchronously):
1947         (WebCore::FrameLoader::createFrame):
1948         (WebCore::FrameLoader::objectContentType):
1949         (WebCore::nsArray):
1950         (WebCore::FrameLoader::createPlugin):
1951         (WebCore::FrameLoader::redirectDataToPlugin):
1952         (WebCore::FrameLoader::createJavaAppletWidget):
1953         (WebCore::FrameLoader::partClearedInBegin):
1954         (WebCore::FrameLoader::saveDocumentState):
1955         (WebCore::FrameLoader::restoreDocumentState):
1956         (WebCore::FrameLoader::overrideMediaType):
1957         (WebCore::FrameLoader::mainResourceData):
1958         (WebCore::FrameLoader::canGoBackOrForward):
1959         (WebCore::FrameLoader::originalRequestURL):
1960         (WebCore::FrameLoader::getHistoryLength):
1961         (WebCore::FrameLoader::goBackOrForward):
1962         (WebCore::FrameLoader::historyURL):
1963         (WebCore::FrameLoader::didFinishLoad):
1964         * loader/mac/LoaderFunctionsMac.mm:
1965         (WebCore::ServeSynchronousRequest):
1966         (WebCore::CheckCacheObjectStatus):
1967         * loader/mac/ResourceLoaderMac.mm:
1968         (WebCore::ResourceLoader::cancel):
1969         * loader/mac/SubresourceLoaderMac.mm:
1970         (WebCore::SubresourceLoader::create):
1971         * loader/qt/FrameLoaderQt.cpp: Added.
1972         (WebCore::FrameLoader::submitForm):
1973         (WebCore::FrameLoader::urlSelected):
1974         (WebCore::FrameLoader::setTitle):
1975         (WebCore::FrameLoader::createFrame):
1976         (WebCore::FrameLoader::objectContentType):
1977         (WebCore::FrameLoader::createPlugin):
1978         (WebCore::FrameLoader::createJavaAppletWidget):
1979         (WebCore::FrameLoader::originalRequestURL):
1980         * page/DOMWindow.cpp:
1981         (WebCore::DOMWindow::document):
1982         * page/Frame.cpp:
1983         (WebCore::Frame::~Frame):
1984         (WebCore::Frame::reparseConfiguration):
1985         (WebCore::Frame::shouldDragAutoNode):
1986         (WebCore::Frame::prepareForUserAction):
1987         (WebCore::FramePrivate::FramePrivate):
1988         (WebCore::FramePrivate::~FramePrivate):
1989         * page/Frame.h:
1990         * page/FramePrivate.h:
1991         * page/FrameView.cpp:
1992         (WebCore::FrameView::layout):
1993         (WebCore::FrameView::mediaType):
1994         * page/FrameView.h:
1995         * page/PageState.cpp:
1996         (WebCore::PageState::PageState):
1997         (WebCore::PageState::restoreJavaScriptState):
1998         * platform/mac/CookieJar.mm:
1999         (WebCore::setCookies):
2000         * platform/mac/TextCodecMac.cpp:
2001         * platform/mac/WebFontCache.mm:
2002         (+[WebFontCache fontWithFamily:traits:size:]):
2003         * platform/network/cf/ResourceHandleCFNet.cpp:
2004         (WebCore::ResourceHandle::start):
2005         * platform/network/mac/ResourceHandleMac.mm:
2006         (WebCore::ResourceHandle::start):
2007         * platform/qt/FrameQt.cpp:
2008         * platform/qt/FrameQt.h:
2009         * rendering/RenderApplet.cpp:
2010         (WebCore::RenderApplet::createWidgetIfNecessary):
2011         * rendering/RenderBlock.h:
2012         * rendering/RenderPartObject.cpp:
2013         (WebCore::isURLAllowed):
2014         (WebCore::RenderPartObject::updateWidget):
2015         * xml/DOMParser.cpp:
2016         (WebCore::DOMParser::parseFromString):
2017         * xml/XSLTProcessor.cpp:
2018         (WebCore::XSLTProcessor::createDocumentFromSource):
2019         * xml/xmlhttprequest.cpp:
2020         (WebCore::XMLHttpRequest::getResponseXML):
2021
2022 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
2023
2024         Reviewed by Geoff.
2025
2026         Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.
2027         
2028         * bridge/mac/FrameMac.mm:
2029         (WebCore::FrameMac::registerCommandForUndoOrRedo):
2030         * bridge/mac/WebCoreFrameBridge.h:
2031         * bridge/mac/WebCoreFrameBridge.mm:
2032         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2033         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2034         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]):
2035         (-[WebCoreFrameBridge selectionGranularity]):
2036         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
2037         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
2038         (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
2039         (-[WebCoreFrameBridge applyStyle:withUndoAction:]):
2040         (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
2041         * editing/SelectionController.cpp:
2042         (WebCore::SelectionController::setModifyBias):
2043         (WebCore::SelectionController::modify):
2044         * editing/SelectionController.h:
2045         (WebCore::SelectionController::):
2046         * editing/TextGranularity.h:
2047
2048 2006-11-07  Brady Eidson  <beidson@apple.com>
2049
2050         Reviewed by Maciej
2051
2052         Changed the check for "top level frame" to something much more valid
2053
2054         * page/Frame.cpp:
2055         (WebCore::Frame::endIfNotLoading):
2056
2057 2006-11-07  Beth Dakin  <bdakin@apple.com>
2058
2059         Reviewed by Hyatt (yesterday).
2060
2061         Here is part of my patch from yesterday that is safe to roll back 
2062         in. It will make the BuildBot happy.
2063
2064         * rendering/HitTestResult.cpp:
2065         (WebCore::HitTestResult::spellingToolTip): Null-check 
2066         m_innerNonSharedNode.
2067
2068 2006-11-07  Darin Adler  <darin@apple.com>
2069
2070         * loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse):
2071         Comment grammar fix.
2072
2073 2006-11-07  Darin Adler  <darin@apple.com>
2074
2075         Rolled out change for <rdar://problem/4820814>.
2076
2077         Beth's planning on landing a new change for it soon, but in the mean time
2078         we need layout tests succeeding again.
2079
2080 2006-11-07  Darin Adler  <darin@apple.com>
2081
2082         Reviewed by Brady.
2083
2084         - fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher
2085           crashes on launch in WebCore::ResourceLoader::start
2086
2087         No layout test, because this depends on cached icons, although there's
2088         perhaps a way to write a test for it with some further ingenuity.
2089
2090         * loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable
2091         to make explicit the fact that it can't be successfully copied.
2092         Remove notifyIconChanged function and put the contents in the caller.
2093         This eliminates the need for IconLoaderMac.mm. Added finishedLoading
2094         and clearLoadingState functions to share code. Removed m_url, since the
2095         resource handle already stores the URL. Renamed m_resourceLoader to
2096         m_handle to reflect the class's name change. Removed the 4096-byte
2097         inline buffer from m_data, since the malloc savings is not sufficient
2098         to offset the additional memory use. Removed m_httpStatusCode because
2099         we can instead cancel the load when we get a status code that reflects
2100         failure. Added m_loadIsInProgress boolean because we need to detect
2101         loads that complete during the ResourceHandle::create function call.
2102
2103         * loader/icon/IconLoader.cpp:
2104         (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress.
2105         Don't initialize m_httpStatusCode.
2106         (WebCore::IconLoader::~IconLoader): Updated for name change.
2107         (WebCore::IconLoader::startLoading): Added code to use the
2108         m_loadIsInProgress flag to detect if the load completed while inside
2109         the ResourceHandle::create function. Removed code to set m_url.
2110         (WebCore::IconLoader::stopLoading): Call clearLoadingState to share
2111         more code.
2112         (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle
2113         and finish loading if the HTTP status code indicates failure.
2114         (WebCore::IconLoader::didReceiveData): Removed assertion that checks
2115         the ResourceHandle, since we can't do that any more.
2116         (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading
2117         so we can share code with the new didReceiveResponse code path.
2118         (WebCore::IconLoader::finishLoading): Moved code here from the
2119         didFinishLoading callback. Pass a URL when calling
2120         commitIconURLToIconDatabase. Call notifyIconChanged directly here
2121         instead of using a separate function. Call clearLoadingState to
2122         share more code with stopLoading.
2123         (WebCore::IconLoader::clearLoadingState): Added.
2124
2125         * loader/mac/IconLoaderMac.mm: Removed.
2126         * WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
2127
2128 2006-11-06  David Harrison  <harrison@apple.com>
2129
2130         Reviewed by Darin.
2131
2132         <rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
2133
2134         * editing/pasteboard/3976872-expected.txt:
2135         * editing/pasteboard/4076267-2-expected.txt:
2136         * editing/pasteboard/4076267-3-expected.txt:
2137         * editing/pasteboard/4076267-expected.txt:
2138         * editing/pasteboard/8145-1-expected.txt:
2139         * editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
2140         * editing/pasteboard/paste-match-style-001-expected.txt:
2141         * editing/pasteboard/paste-match-style-002-expected.txt:
2142         * editing/pasteboard/paste-text-019-expected.txt:
2143         * editing/pasteboard/pasting-tabs-expected.txt:
2144         Updated because pasting text with no newlines does not use intermediate div.
2145         
2146         * editing/markup.cpp:
2147         (WebCore::fillContainerFromString):
2148         First parameter is now a Container so a fragment can be passed.
2149         
2150         (WebCore::createFragmentFromText):
2151         A string with no newlines gets added inline, rather than being put into a paragraph.
2152
2153 2006-11-06  Beth Dakin  <bdakin@apple.com>
2154
2155         Reviewed by Hyatt.
2156
2157         Fix for <rdar://problem/4820814> A crash occurs at 
2158         WebCore::HitTestResult::spellingToolTip() when mousing down on 
2159         iframe at www.macsurfer.com
2160
2161         The bug here is that the source of the iframe is only a comment, 
2162         and we were not properly constructing the frame because it was 
2163         sort-of empty but not.
2164
2165         * html/HTMLDocument.cpp:
2166         (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if 
2167         it is a comment node.
2168         * html/HTMLParser.cpp:
2169         (WebCore::HTMLParser::handleError): if n is a comment node and 
2170         there is no head, we create a head, insert in the document, and add 
2171         the comment node as a child. This is what Firefox does too. 
2172         * page/FrameView.cpp:
2173         (WebCore::FrameView::handleMousePressEvent): Safe-guard for the 
2174         fix. It is possible to get a mouse event without a target node, so 
2175         we null check it. (Of course, in the case of this bug, it should 
2176         not have been null, but it is a good thing to check for anyway.
2177         * rendering/HitTestResult.cpp:
2178         (WebCore::HitTestResult::spellingToolTip): Null-check 
2179         m_innerNonSharedNode.
2180
2181 2006-11-06  Justin Garcia  <justin.garcia@apple.com>
2182
2183         Reviewed by harrison
2184         
2185         <rdar://problem/4641880>
2186         Setting bullets to existing text grabs subsequent paragraph
2187         
2188         When a selection ends at the start of a paragraph, we rarely paint 
2189         the selection gap before that paragraph, because there often is no gap.  
2190         In a case like this, it's not obvious to the user that the selection 
2191         ends "inside" that paragraph, so it would be confusing if 
2192         InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.
2193         
2194         * editing/FormatBlockCommand.cpp:
2195         (WebCore::FormatBlockCommand::doApply): Moved the check for editability of
2196         the selection to a more appropriate place.  Change the endingSelection
2197         if it ends at the start of a paragraph.
2198         * editing/IndentOutdentCommand.cpp:
2199         (WebCore::IndentOutdentCommand::doApply): Ditto.
2200         * editing/InsertListCommand.cpp:
2201         (WebCore::InsertListCommand::doApply): Ditto.
2202
2203 2006-11-06  Brady Eidson  <beidson@apple.com>
2204
2205         Reviewed by Sarge
2206
2207         <rdar://problem/4822911> - ASSERTION was a little overzealous.  
2208         Toned it down a bit.
2209
2210         * xml/xmlhttprequest.cpp:
2211         (WebCore::XMLHttpRequest::didFinishLoading):  Toned down assertion
2212
2213 2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2214
2215         Reviewed by Maciej.
2216
2217         Linux\Gdk build fixes.
2218
2219         * loader/icon/IconDatabase.cpp:
2220         * loader/icon/SQLStatement.h:
2221         * platform/gdk/ChromeClientGdk.h: Added.
2222         (WebCore::ChromeClientGdk::~ChromeClientGdk):
2223         * platform/gdk/CursorGdk.cpp:
2224         (WebCore::pointerCursor):
2225         * platform/gdk/FrameGdk.cpp:
2226         (WebCore::doScroll):
2227         (WebCore::FrameGdk::FrameGdk):
2228         (WebCore::FrameGdk::submitForm):
2229         (WebCore::FrameGdk::urlSelected):
2230         (WebCore::FrameGdk::openURL):
2231         (WebCore::FrameGdk::handleGdkEvent):
2232         * platform/gdk/FrameGdk.h:
2233         (WebCore::FrameGdk::client):
2234         * platform/gdk/RenderPopupMenuGdk.cpp:
2235         (WebCore::PopupMenu::updateFromElement):
2236         * platform/gdk/ScreenGdk.cpp:
2237         * platform/gdk/TemporaryLinkStubs.cpp:
2238         (Slider::focusPolicy):
2239         (WebCore::ServeSynchronousRequest):
2240         (FrameGdk::goBackOrForward):
2241         (FrameGdk::getHistoryLength):
2242         (FrameGdk::historyURL):
2243         (ChromeClientGdk::canRunModal):
2244         (ChromeClientGdk::runModal):
2245         (WebCore::systemBeep):
2246         (WebCore::CachedResource::setPlatformResponse):
2247         (Path::transform):
2248         (ResourceLoader::loadsBlocked):
2249         (IconLoader::notifyIconChanged):
2250         * platform/network/gdk/ResourceHandleManager.cpp:
2251         (WebCore::writeCallback):
2252         (WebCore::ResourceHandleManager::downloadTimerCallback):
2253         (WebCore::ResourceHandleManager::remove):
2254         (WebCore::ResourceHandleManager::add):
2255
2256 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
2257
2258         build fix.
2259         
2260         * WebCore.xcodeproj/project.pbxproj:
2261
2262 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
2263
2264         Reviewed by Maciej, Anders, Darin.
2265
2266         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
2267         Fixed a minor where WebCore would always assume it was displayed on the 
2268         monitor containing the menubar. window.open and window.showModalDialog 
2269         are now cross-platform. 
2270         
2271         Layout tests, manual-tests/show-modal-dialog, and manual-tests/
2272         window-open-features-parsing all pass. I verified the new screen functionality
2273         by running in DRT, and checking whether WebCore knew it was off-screen.
2274         
2275         Some refactoring remains, as all were not pleased by this design. I see
2276         in my future another patch.
2277
2278         * bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
2279         client, to encapsulate asking the platform questions about the screen occupied by
2280         the page. (Previously, we always assumed we were on screen 0, which was a bug.)
2281         * bridge/mac/WebCoreFrameBridge.mm:
2282         (createMouseEventFromDraggingInfo): Reversed argument order, to match other
2283         functions.
2284         (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
2285         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
2286         * bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
2287         * bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
2288         * bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
2289         * bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
2290         * manual-tests/window-open-features-parsing.html: Updated for accuracy.
2291         (In this case, neither size nor position is specified, so you should
2292         get the default window size and position.)
2293         * page/Screen.cpp: Added. Includes screen-related helper functions used
2294         in WebCore and WebKit.
2295         * platform/PlatformMouseEvent.h: Exported common code so it doesn't have
2296         to be duplicated. Renamed "position" to "point" since both were used,
2297         and "point" seemed clearer.
2298         * platform/Screen.h: Removed. Dead Code.
2299         * platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
2300         initialization.
2301
2302 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
2303
2304         Reviewed by Tim Hatcher.
2305
2306         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
2307         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
2308         
2309         No layout tests added as this must be tested manually by the test
2310         WebCore/manual-tests/contenteditable-link.html
2311
2312         * WebCore.exp: Exported HitTestResult::isLiveLink().
2313         * html/HTMLAnchorElement.cpp:
2314         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
2315         (WebCore::HTMLAnchorElement::defaultEventHandler):
2316         (WebCore::HTMLAnchorElement::isLiveLink):
2317         * html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
2318         to track shift key status.
2319         * manual-tests/contenteditable-link.html: Added description about link
2320         dragging behaviour.
2321         * rendering/HitTestResult.cpp:
2322         (WebCore::HitTestResult::isLiveLink): Added.
2323         * rendering/HitTestResult.h:
2324
2325 2006-11-06  Brady Eidson  <beidson@apple.com>
2326
2327         Reviewed by Oliver
2328
2329         Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
2330         For now, we have to not load favicons when we have no Document - linking directly 
2331         to PDFs being the common case
2332
2333         * loader/icon/IconLoader.cpp:
2334         (WebCore::IconLoader::startLoading): Check for the document and return if none
2335
2336 2006-11-06  Brady Eidson  <beidson@apple.com>
2337
2338         Reviewed by Dave Harrison
2339
2340         <rdar://problem/4801066>
2341         Added a critical null frameLoader() check
2342
2343         * loader/mac/MainResourceLoaderMac.mm:
2344         (WebCore::MainResourceLoader::loadNow):
2345
2346 2006-11-06  David Harrison  <harrison@apple.com>
2347
2348         Reviewed by Darin.
2349
2350         <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
2351
2352         Test:
2353         * editing/deleting/delete-br-012.html
2354         
2355         * editing/DeleteSelectionCommand.cpp:
2356         (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
2357         Update m_endingPosition when preventing merge.
2358         Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
2359
2360 2006-11-06  Mark Rowe  <bdash@webkit.org>
2361
2362         Reviewed by Maciej.
2363
2364         http://bugs.webkit.org/show_bug.cgi?id=11526
2365         Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
2366
2367         Update DOMNode::toString to always use className rather than preferring nodeName.
2368
2369         * bindings/js/kjs_dom.cpp:
2370         (KJS::DOMNode::toString): Match the format returned by valueOf.
2371
2372 2006-11-06  Oliver Hunt  <oliver@apple.com>
2373
2374         Reviewed by Maciej.
2375
2376         Fix RTL text in SVG to have correct positioning
2377
2378         * rendering/SVGRootInlineBox.cpp:
2379         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
2380
2381 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
2382
2383         Reviewed by Maciej.
2384
2385         http://bugs.webkit.org/show_bug.cgi?id=11517
2386         REGRESSION: Flash clicks/interactivity not working properly
2387
2388         * bridge/mac/FrameMac.mm:
2389         (WebCore::FrameMac::handleMouseMoveEvent):
2390         (WebCore::FrameMac::handleMouseReleaseEvent):
2391         Restore parts of event dispatching that were removed when fixing
2392         bug 7323 - just bypass those for subframes.
2393
2394 2006-11-05  Darin Adler  <darin@apple.com>
2395
2396         - quick attempt to fix the no-SVG build
2397
2398         * platform/graphics/svg/SVGResource.cpp:
2399         * platform/graphics/svg/SVGResource.h:
2400         * platform/graphics/svg/SVGResourceClipper.cpp:
2401         * platform/graphics/svg/SVGResourceClipper.h:
2402         * platform/graphics/svg/SVGResourceImage.h:
2403         * platform/graphics/svg/SVGResourceMarker.cpp:
2404         * platform/graphics/svg/SVGResourceMarker.h:
2405         * platform/graphics/svg/SVGResourceMasker.cpp:
2406         * platform/graphics/svg/SVGResourceMasker.h:
2407         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
2408         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
2409         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
2410         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
2411         Added #ifdef SVG_SUPPORT to these files.
2412
2413 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
2414
2415         Reviewed & landed by Maciej.
2416
2417         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
2418
2419         * platform/win/ResourceLoaderWin.cpp:
2420         (WebCore::transferJobStatusCallback):
2421         (WebCore::ResourceLoader::start):
2422
2423 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
2424
2425         Reviewed by Oliver.
2426
2427         - moved FormData and FormDataStream to platform/network directory
2428
2429         * WebCore.xcodeproj/project.pbxproj:
2430         * bridge/mac/WebCoreFrameBridge.mm:
2431         * loader/FormData.cpp: Removed.
2432         * loader/FormData.h: Removed.
2433         * loader/mac/FormDataStream.h: Removed.
2434         * loader/mac/FormDataStream.m: Removed.
2435         * loader/mac/FrameLoaderMac.mm:
2436         * loader/mac/SubresourceLoaderMac.mm:
2437         * platform/network/mac/FormDataStreamMac.h: Added.
2438         * platform/network/mac/FormDataStreamMac.mm: Added.
2439         * platform/network/mac/ResourceRequestMac.mm:
2440
2441 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
2442
2443         Fix build breaks
2444
2445         * loader/DocumentLoader.h:
2446         * platform/win/ScreenWin.cpp:
2447
2448 2006-11-05  Darin Adler  <darin@apple.com>
2449
2450         Reviewed by Geoff.
2451
2452         - more preparation for splitting up Frame into sub-pieces
2453         - removed unnecessary includes from Frame.h
2454
2455         * page/Frame.h: Removed unneeded includes and forward declarations.
2456         Added additional forward declarations. Removed the constant
2457         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
2458         Created sections of functions to be moved into Chrome, Editor,
2459         EventHandler, FrameLoader, SelectionController, and the Platform
2460         directory, as well as marking one function for deletion.
2461
2462         * page/FramePrivate.h: Removed the definition of the constructor and
2463         destructor and removed unnecessary includes.
2464
2465         * page/FrameView.h: Removed unneeded forward declarations and friend
2466         declarations. Created a section of functions and data to be moved into
2467         EventHandler.
2468
2469         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
2470         Created sections of functions and data to be moved into Chrome,
2471         Editor, EventHandler, FrameLoader, and the Platform directory.
2472
2473         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
2474         Removed unused methods areScrollbarsVisible,
2475         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
2476
2477         * page/Frame.cpp:
2478         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
2479         to include KURL.h just for the KURL default constructor.
2480         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
2481         (WebCore::FramePrivate::~FramePrivate): Ditto.
2482
2483         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
2484         booleans, scrollbarMoved and cleared funcitons.
2485         (WebCore::FrameView::clear): Moved the code from the cleared
2486         function in here.
2487         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
2488
2489         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
2490         for changes to header.
2491
2492         * editing/SelectionController.cpp:
2493         (WebCore::SelectionController::setSelection):
2494         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
2495         Moved NoXPosForVerticalArrowNavigation into this file.
2496
2497         * bindings/js/kjs_events.cpp:
2498         * bindings/js/kjs_html.cpp:
2499         * bindings/js/kjs_window.cpp:
2500         * bridge/mac/WebCoreAXObject.mm:
2501         * bridge/mac/WebCoreFrameBridge.mm:
2502         * css/cssstyleselector.cpp:
2503         * dom/Document.cpp:
2504         * dom/Element.cpp:
2505         * dom/EventTargetNode.cpp:
2506         * dom/MouseRelatedEvent.cpp:
2507         * dom/XMLTokenizer.cpp:
2508         * html/HTMLBaseElement.cpp:
2509         * html/HTMLDocument.cpp:
2510         * html/HTMLEmbedElement.cpp:
2511         * html/HTMLFrameElementBase.cpp:
2512         * html/HTMLGenericFormElement.cpp:
2513         * html/HTMLObjectElement.cpp:
2514         * html/HTMLTokenizer.cpp:
2515         * loader/mac/FrameLoaderMac.mm:
2516         * page/PageState.cpp:
2517         * rendering/RenderApplet.cpp:
2518         * rendering/RenderBlock.cpp:
2519         * rendering/RenderLayer.cpp:
2520         * rendering/RenderObject.cpp:
2521         * rendering/RenderPartObject.cpp:
2522         * rendering/RenderTreeAsText.cpp:
2523         * xml/XSLTProcessor.cpp:
2524         Added includes as needed to keep compiling, since there are fewer
2525         includes in Frame.h.
2526
2527 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
2528
2529         Reviewed by Dave Harrison.
2530
2531         http://bugs.webkit.org/show_bug.cgi?id=11402
2532         REGRESSION: onChange does not work anymore for 1st item in popup
2533
2534         * html/HTMLSelectElement.cpp:
2535         (WebCore::HTMLSelectElement::HTMLSelectElement):
2536         (WebCore::HTMLSelectElement::reset):
2537         Set m_lastOnChangeIndex to -1.
2538
2539 2006-11-04  Darin Adler  <darin@apple.com>
2540
2541         Reviewed by Anders.
2542
2543         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
2544           REGRESSION: Status bar always shows cancelled opening the page
2545
2546         * platform/network/mac/ResourceHandleMac.mm:
2547         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
2548         Since the subresource owns the resource handle, there's no need to cancel.
2549         This arrangement is only temporary, anyway, since Maciej will soon change
2550         things so that the subresource loader uses the resource handle and the
2551         resource handle doesn't know anything about the subresource loader.
2552
2553 2006-11-04  Darin Adler  <darin@apple.com>
2554
2555         Reviewed by Maciej.
2556
2557         - converted more of the loader machinery to work with cross-platform
2558           data structures instead of Macintosh-specific ones
2559
2560           converted most uses of NSURL to KURL and NSEvent to DOM Event in
2561           loader classes
2562
2563           moved download function out of FrameLoader.h to avoid reference to
2564           NSURLConnection
2565
2566           added DOM Event parameters to various functions so that the handlers
2567           can use the DOM Event instead of the global "current NSEvent";
2568           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
2569           HTMLFormElement::submit, FrameLoader::load
2570
2571           moved the setMainFrame call that hands ownership to the Page
2572           into one of the Frame constructors, and removed it from all
2573           the clients
2574
2575           removed const from Event parameter to the urlSelected function
2576           (we rarely use const with DOM elements)
2577
2578           removed some redundant includes and declarations from various
2579           header files
2580
2581           removed NSURL parameter from userAgent function -- if we need it we
2582           can add it back, but converting from NSURL to KURL and back is
2583           inefficient enough that it's best to have it out for now (since it's
2584           been unused for years) -- if we add it back, we can choose an
2585           appropriate parameter type that's always inexpensive to pass
2586
2587           did some basic cleanup in the IconLoader class, including removing
2588           an unnecessary loop that added icon data a byte at a time
2589
2590           renamed safeLoad to load, since it's no different from the other
2591           FrameLoader load functions, safety-wise
2592
2593           fixed some code that was trying to distinguish null frame name from
2594           empty string frame name -- both should be handled the same, but callers
2595           were doing it by checking for empty and turning it into null (in a way
2596           that was causing extra round trips between NSString and WebCore::String)
2597
2598           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
2599           and got rid of case-insensitive compares of methods
2600
2601         * WebCore.exp:
2602         * WebCore.xcodeproj/project.pbxproj:
2603         * bindings/js/kjs_navigator.cpp:
2604         (KJS::Navigator::getValueProperty):
2605         * bridge/mac/FrameMac.h:
2606         * bridge/mac/FrameMac.mm:
2607         (WebCore::FrameMac::submitForm):
2608         (WebCore::FrameMac::urlSelected):
2609         (WebCore::FrameMac::userAgent):
2610         * bridge/mac/FrameViewMac.mm:
2611         * bridge/mac/WebCoreAXObject.mm:
2612         (-[WebCoreAXObject rendererForView:]):
2613         * bridge/mac/WebCorePageBridge.h:
2614         * bridge/mac/WebCorePageBridge.mm:
2615         * bridge/mac/WebCoreSettings.mm:
2616         * bridge/win/FrameWin.cpp:
2617         (WebCore::FrameWin::urlSelected):
2618         (WebCore::FrameWin::submitForm):
2619         * bridge/win/FrameWin.h:
2620         * dom/MouseRelatedEvent.cpp:
2621         * dom/MouseRelatedEvent.h:
2622         * dom/UIEvent.cpp:
2623         (WebCore::UIEvent::~UIEvent):
2624         * dom/UIEvent.h:
2625         * dom/UIEventWithKeyState.h:
2626         * dom/XMLTokenizer.cpp:
2627         (WebCore::openFunc):
2628         * html/HTMLAnchorElement.cpp:
2629         (WebCore::HTMLAnchorElement::defaultEventHandler):
2630         * html/HTMLButtonElement.cpp:
2631         (WebCore::HTMLButtonElement::defaultEventHandler):
2632         * html/HTMLFormElement.cpp:
2633         (WebCore::HTMLFormElement::submitClick):
2634         (WebCore::HTMLFormElement::prepareSubmit):
2635         (WebCore::HTMLFormElement::submit):
2636         * html/HTMLFormElement.h:
2637         * html/HTMLInputElement.cpp:
2638         (WebCore::HTMLInputElement::defaultEventHandler):
2639         * html/HTMLSelectElement.cpp:
2640         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
2641         * loader/DocumentLoader.h:
2642         * loader/FrameLoader.h:
2643         * loader/FrameLoaderClient.h:
2644         * loader/NavigationAction.h:
2645         (WebCore::NavigationAction::event):
2646         * loader/icon/IconLoader.cpp:
2647         (WebCore::IconLoader::create):
2648         (WebCore::IconLoader::startLoading):
2649         (WebCore::IconLoader::didReceiveData):
2650         (WebCore::IconLoader::didFinishLoading):
2651         * loader/icon/IconLoader.h:
2652         * loader/loader.cpp:
2653         * loader/mac/DocumentLoaderMac.mm:
2654         (WebCore::DocumentLoader::URL):
2655         (WebCore::DocumentLoader::unreachableURL):
2656         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
2657         (WebCore::DocumentLoader::URLForHistory):
2658         * loader/mac/FrameLoaderMac.mm:
2659         (WebCore::FrameLoader::load):
2660         (WebCore::FrameLoader::willSendRequest):
2661         (WebCore::FrameLoader::clientRedirected):
2662         (WebCore::FrameLoader::shouldReload):
2663         (WebCore::FrameLoader::notifyIconChanged):
2664         (WebCore::FrameLoader::URL):
2665         (WebCore::FrameLoader::reloadAllowingStaleData):
2666         (WebCore::FrameLoader::reload):
2667         (WebCore::FrameLoader::didChangeTitle):
2668         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2669         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2670         (WebCore::FrameLoader::post):
2671         (WebCore::FrameLoader::addExtraFieldsToRequest):
2672         (WebCore::FrameLoader::loadResourceSynchronously):
2673         * loader/mac/IconLoaderMac.mm:
2674         (WebCore::IconLoader::notifyIconChanged):
2675         * loader/mac/LoaderFunctionsMac.mm:
2676         * loader/mac/MainResourceLoaderMac.mm:
2677         (WebCore::shouldLoadAsEmptyDocument):
2678         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2679         * loader/mac/NavigationActionMac.mm:
2680         (WebCore::navigationType):
2681         (WebCore::NavigationAction::NavigationAction):
2682         * loader/mac/ResourceLoaderMac.mm:
2683         * loader/mac/SubresourceLoaderMac.mm:
2684         * page/Frame.cpp:
2685         (WebCore::Frame::Frame):
2686         (WebCore::Frame::urlSelected):
2687         (WebCore::Frame::submitFormAgain):
2688         (WebCore::Frame::submitForm):
2689         (WebCore::Frame::endIfNotLoading):
2690         (WebCore::Frame::hitTestResultAtPoint):
2691         * page/Frame.h:
2692         * page/FramePrivate.h:
2693         * platform/gdk/FrameGdk.cpp:
2694         (WebCore::FrameGdk::FrameGdk):
2695         (WebCore::FrameGdk::submitForm):
2696         (WebCore::FrameGdk::urlSelected):
2697         * platform/gdk/FrameGdk.h:
2698         * platform/mac/TextFieldMac.mm:
2699         * platform/network/HTTPHeaderMap.h:
2700         * platform/network/ResourceHandle.h:
2701         * platform/network/ResourceHandleClient.h:
2702         * platform/network/ResourceHandleInternal.h:
2703         * platform/network/mac/ResourceHandleMac.mm:
2704         * platform/network/mac/ResourceResponseMac.h:
2705         * platform/network/mac/ResourceResponseMac.mm:
2706         (-[NSURLResponse WebCore]):
2707         * platform/network/win/ResourceHandleWin.cpp:
2708         * platform/qt/FrameQt.cpp:
2709         (WebCore::FrameQt::submitForm):
2710         (WebCore::FrameQt::urlSelected):
2711         * platform/qt/FrameQt.h:
2712         * rendering/RenderLineEdit.cpp:
2713         (WebCore::RenderLineEdit::returnPressed):
2714         * xml/XSLTProcessor.cpp:
2715         (WebCore::docLoaderFunc):
2716         * xml/xmlhttprequest.cpp:
2717
2718 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2719
2720         Reviewed by Adele.
2721
2722         - replaced receivedRedirect with new willSendRequest delegate
2723         - removed most mac-specific loader functions
2724         - use ResourceResponse more in loader code
2725
2726         * WebCore.xcodeproj/project.pbxproj: Add new files.
2727         * bridge/mac/WebCoreFrameBridge.mm:
2728         (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
2729         for CachedResource method renames.
2730         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2731         Ditto.
2732         * loader/CachedCSSStyleSheet.cpp:
2733         (WebCore::CachedCSSStyleSheet::checkNotify): simplified
2734         based on ResourceResponse
2735         * loader/CachedImage.cpp:
2736         (WebCore::CachedImage::createImage): adapt for ResourceResponse
2737         * loader/CachedResource.cpp:
2738         (WebCore::CachedResource::CachedResource): store a ResourceResponse;
2739         platform response is now called platformResponse and expiration date
2740         is removed.
2741         (WebCore::CachedResource::~CachedResource): ditto
2742         (WebCore::CachedResource::isExpired): ditto
2743         * loader/CachedResource.h:
2744         (WebCore::CachedResource::platformResponse): ditto
2745         (WebCore::CachedResource::setResponse): ditto
2746         (WebCore::CachedResource::canDelete): ditto
2747         * loader/LoaderFunctions.h:
2748         * loader/loader.cpp:
2749         (WebCore::Loader::receivedResponse): Adjusted for renames.
2750         (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
2751         in the CachedResource.
2752         * loader/loader.h:
2753         * loader/mac/FormDataStream.h:
2754         * loader/mac/FormDataStream.m:
2755         (WebCore::getStreamFormDatas): Rearranged things so it's
2756         possible to get a FormData back out of a form data stream.
2757         (WebCore::formCreate): ditto
2758         (WebCore::formFinalize): ditto
2759         (WebCore::httpBodyFromStream): ditto
2760         * loader/mac/ImageDocumentMac.mm:
2761         (WebCore::finishImageLoad): s/response/platformResponse/
2762         * loader/mac/LoaderFunctionsMac.mm:
2763         (WebCore::CheckCacheObjectStatus): ditto
2764         (WebCore::CachedResource::setPlatformResponse): ditto
2765         * loader/mac/SubresourceLoaderMac.mm:
2766         (WebCore::SubresourceLoader::willSendRequest): send redirect
2767         to client appropriately
2768         * platform/network/ResourceHandle.h:
2769         * platform/network/ResourceHandleClient.h:
2770         (WebCore::ResourceHandleClient::willSendRequest): new entry
2771         point for SubresourceLoader, dispatch to client.
2772         * platform/network/ResourceRequest.h:
2773         (WebCore::ResourceRequest::allowHTTPCookies): implemented
2774         (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
2775         * platform/network/ResourceResponse.h:
2776         (WebCore::ResourceResponse::ResourceResponse): initialize expiration
2777         date(!)
2778         * platform/network/cf/FormDataStreamCFNet.cpp: Added.
2779         (WebCore::getStreamFormDatas): Added this, ported from NSURL version.
2780         (WebCore::openNextStream): ditto
2781         (WebCore::formCreate): ditto
2782         (WebCore::formFinalize): ditto
2783         (WebCore::formCanRead): ditto
2784         (WebCore::formEventCallback): ditto
2785         (WebCore::setHTTPBody): ditto
2786         (WebCore::httpBodyFromStream): ditto
2787         * platform/network/cf/FormDataStreamCFNet.h: Added.
2788         * platform/network/cf/ResourceHandleCFNet.cpp:
2789         (WebCore::willSendRequest): implemented
2790         (WebCore::ResourceHandle::start): use new ResourceRequest stuff
2791         * platform/network/cf/ResourceResponseCFNet.cpp:
2792         (WebCore::getResourceResponse): do nothing for a null response
2793         * platform/network/mac/ResourceHandleMac.mm:
2794         (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
2795         * platform/network/mac/ResourceRequestMac.h: Added.
2796         * platform/network/mac/ResourceRequestMac.mm: Added.
2797         (WebCore::getResourceRequest): Added way to convert an NSURLRequest
2798         to a ResourceRequest.
2799         (WebCore::nsURLRequest): Opposite of the above.
2800         * platform/network/cf/ResourceRequestCFNet.h: Added.
2801         * platform/network/cf/ResourceRequestCFNet.cpp: Added.
2802         (WebCore::getResourceRequest): Added way to convert an CFURLRequest
2803         to a ResourceRequest.
2804         (WebCore::cfURLRequest): Opposite of the above.
2805         * xml/xmlhttprequest.cpp:
2806         (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
2807         adjusted.
2808         * xml/xmlhttprequest.h:
2809
2810 2006-11-04  Darin Adler  <darin@apple.com>
2811
2812         Change suggested by Mitz.
2813
2814         - fix http://bugs.webkit.org/show_bug.cgi?id=11514
2815           REGRESSION (r17438): Repro crash when opening a web archive
2816
2817         * bridge/mac/WebCorePageState.mm:
2818         (-[WebCorePageState dealloc]): Add null check.
2819         (-[WebCorePageState finalize]): Ditto.
2820
2821 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
2822
2823         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
2824
2825         http://bugs.webkit.org/show_bug.cgi?id=11433
2826         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
2827
2828         * WebCore.vcproj/WebCore/WebCore.vcproj:
2829         Added platform/graphics platform/network and platform/network/win to headers search paths
2830         Created platform/graphics and platform/network filters in hierarchy
2831         Moved GraphicsContext and GraphicsTypes to their respective filters
2832         Added EditorClient.h
2833         Added FrameLoader* files in loader/
2834         Added HitTest* files in rendering/
2835         Added Editor.* files in editing/
2836         Added DeleteButton.* and DeleteButtonController.* in editing/
2837
2838         * bridge/win/ChromeClientWin.h: Added.
2839         (WebCore::ChromeClientWin::~ChromeClientWin):
2840         * bridge/win/EditorClientWin.h: Added.
2841         (WebCore::EditorClientWin::~EditorClientWin):
2842
2843         * bridge/win/FrameWin.cpp:
2844         (WebCore::FrameWin::FrameWin):
2845         (WebCore::FrameWin::urlSelected):
2846         (WebCore::FrameWin::submitForm):
2847         (WebCore::FrameWin::createNewWindow):
2848         * bridge/win/FrameWin.h:
2849         Added EditorClient parameter to constructor
2850         Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
2851         Removed openURL() and openURLRequest from class definition
2852
2853         * bridge/win/PageWin.cpp:
2854         * platform/AffineTransform.h:
2855         * platform/cairo/AffineTransformCairo.cpp: Added.
2856         (WebCore::AffineTransform::AffineTransform):
2857         (WebCore::AffineTransform::setMatrix):
2858         (WebCore::AffineTransform::map):
2859         (WebCore::AffineTransform::mapRect):
2860         (WebCore::AffineTransform::isIdentity):
2861         (WebCore::AffineTransform::m11):
2862         (WebCore::AffineTransform::m12):
2863         (WebCore::AffineTransform::m21):
2864         (WebCore::AffineTransform::m22):
2865         (WebCore::AffineTransform::dx):
2866         (WebCore::AffineTransform::dy):
2867         (WebCore::AffineTransform::reset):
2868         (WebCore::AffineTransform::scale):
2869         (WebCore::AffineTransform::rotate):
2870         (WebCore::AffineTransform::translate):
2871         (WebCore::AffineTransform::shear):
2872         (WebCore::AffineTransform::det):
2873         (WebCore::AffineTransform::invert):
2874         (WebCore::AffineTransform::operator cairo_matrix_t):
2875         (WebCore::AffineTransform::operator== ):
2876         (WebCore::AffineTransform::operator*= ):
2877         (WebCore::AffineTransform::operator* ):
2878         * platform/cairo/GraphicsContextCairo.cpp:
2879         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2880         * platform/network/win/ResourceHandleWin.cpp:
2881         (WebCore::ResourceHandle::onHandleCreated):
2882         (WebCore::ResourceHandle::start):
2883         (WebCore::ResourceHandle::fileLoadTimer):
2884         (WebCore::ResourceHandle::cancel):
2885         * platform/win/TemporaryLinkStubs.cpp:
2886         (WebCore::FrameWin::goBackOrForward):
2887         (WebCore::FrameWin::getHistoryLength):
2888         (WebCore::FrameWin::historyURL):
2889         (WebCore::ServeSynchronousRequest):
2890         (WebCore::ChromeClientWin::canRunModal):
2891         (WebCore::ChromeClientWin::runModal):
2892         (WebCore::EditorClientWin::shouldDeleteRange):
2893         (WebCore::EditorClientWin::shouldShowDeleteInterface):
2894         (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
2895         (WebCore::EditorClientWin::isGrammarCheckingEnabled):
2896         (WebCore::EditorClientWin::spellCheckerDocumentTag):
2897         (WebCore::Path::transform):
2898         (WebCore::PopupMenu::updateFromElement):
2899         (WebCore::ResourceLoader::loadsBlocked):
2900         (WebCore::systemBeep):
2901         * rendering/RenderThemeWin.cpp:
2902         (WebCore::RenderThemeWin::paintButton):
2903         (WebCore::RenderThemeWin::paintTextField):
2904
2905 2006-11-04  Alexey Proskuryakov  <ap@nypop.com>
2906
2907         Reviewed by Maciej.
2908
2909         http://bugs.webkit.org/show_bug.cgi?id=11448
2910         &lang; and &rang; entities are mapped to the incorrect Unicode codepoint
2911
2912         * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
2913
2914 2006-11-03  Mark Rowe  <bdash@webkit.org>
2915
2916         Reviewed by Oliver.
2917
2918         Update Windows and Qt project files for file removals in r17585.
2919
2920         * CMakeLists.txt:
2921         * WebCore.vcproj/WebCore/WebCore.vcproj:
2922
2923 2006-11-03  Zack Rusin  <zack@kde.org>
2924
2925         Reviewed by Maciej.
2926
2927         The patch fixes text field drawing on the Qt platform.
2928
2929         * platform/qt/RenderThemeQt.cpp:
2930         (WebCore::RenderThemeQt::paintTextField): Use the style to correctly
2931         render the text field
2932
2933 2006-11-03  Oliver Hunt  <oliver@apple.com>
2934
2935         Reviewed by Tim.
2936
2937         Correct incorrect call to SetCursor
2938
2939         * rendering/RenderFrameSet.cpp:
2940         (WebCore::RenderFrameSet::userResize):
2941
2942 2006-11-03  Adele Peterson  <adele@apple.com>
2943
2944         Reviewed by Oliver.
2945
2946         Removed DeprecatedRenderSelect and ListBox classes.
2947
2948         * WebCore.xcodeproj/project.pbxproj:
2949         * css/html4.css:
2950         * html/HTMLOptionElement.h:
2951         * html/HTMLSelectElement.cpp:
2952         (WebCore::HTMLSelectElement::recalcStyle):
2953         (WebCore::HTMLSelectElement::isKeyboardFocusable):
2954         (WebCore::HTMLSelectElement::isMouseFocusable):
2955         (WebCore::HTMLSelectElement::createRenderer):
2956         (WebCore::HTMLSelectElement::setRecalcListItems):
2957         (WebCore::HTMLSelectElement::notifyOptionSelected):
2958         (WebCore::HTMLSelectElement::defaultEventHandler):
2959         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
2960         (WebCore::HTMLSelectElement::updateListBoxSelection):
2961         * html/HTMLSelectElement.h:
2962         * platform/ListBox.h: Removed.
2963         * platform/mac/FontCacheMac.mm:
2964         * platform/mac/ListBoxMac.mm: Removed.
2965         * platform/win/TemporaryLinkStubs.cpp:
2966         * rendering/DeprecatedRenderSelect.cpp: Removed.
2967         * rendering/DeprecatedRenderSelect.h: Removed.
2968
2969 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2970
2971         Not reviewed, fix for accidental commit.
2972
2973         - rolled back more of the accidentall commit that I forgot.
2974
2975         * platform/network/mac/ResourceRequestMac.h: Removed.
2976         * platform/network/mac/ResourceRequestMac.mm: Removed.
2977
2978 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2979
2980         Not reviewed, fix for accidental commit.
2981
2982         - roll back some network changes accidentally committed with a previous patch.
2983
2984         * WebCore.xcodeproj/project.pbxproj:
2985         * bridge/mac/WebCoreFrameBridge.mm:
2986         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
2987         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2988         * loader/CachedCSSStyleSheet.cpp:
2989         (WebCore::CachedCSSStyleSheet::checkNotify):
2990         * loader/CachedImage.cpp:
2991         (WebCore::CachedImage::createImage):
2992         * loader/CachedResource.cpp:
2993         (WebCore::CachedResource::CachedResource):
2994         (WebCore::CachedResource::~CachedResource):
2995         (WebCore::CachedResource::setExpireDate):
2996         (WebCore::CachedResource::isExpired):
2997         * loader/CachedResource.h:
2998         (WebCore::CachedResource::response):
2999         * loader/LoaderFunctions.h:
3000         * loader/loader.cpp:
3001         (WebCore::Loader::receivedResponse):
3002         (WebCore::Loader::didReceivedResponse):
3003         * loader/loader.h:
3004         * loader/mac/FormDataStream.h:
3005         * loader/mac/FormDataStream.m:
3006         (WebCore::formCreate):
3007         (WebCore::formFinalize):
3008         * loader/mac/ImageDocumentMac.mm:
3009         (WebCore::finishImageLoad):
3010         * loader/mac/LoaderFunctionsMac.mm:
3011         (WebCore::CheckCacheObjectStatus):
3012         (WebCore::CachedResource::setResponse):
3013         * loader/mac/SubresourceLoaderMac.mm:
3014         (WebCore::SubresourceLoader::willSendRequest):
3015         * platform/network/ResourceHandle.h:
3016         * platform/network/ResourceHandleClient.h:
3017         (WebCore::ResourceHandleClient::receivedRedirect):
3018         * platform/network/ResourceRequest.h:
3019         * platform/network/ResourceResponse.h:
3020         (WebCore::ResourceResponse::ResourceResponse):
3021         * platform/network/mac/ResourceHandleMac.mm:
3022         (WebCore::ResourceHandle::redirectedToURL):
3023         * xml/xmlhttprequest.cpp:
3024         (WebCore::XMLHttpRequest::receivedRedirect):
3025         * xml/xmlhttprequest.h:
3026
3027 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
3028
3029         Rubber-stamped by Oliver.
3030
3031         Remove these, they have been merged with SVGRenderTreeAsText.
3032         
3033         * rendering/SVGRenderAsText.cpp: Removed.
3034         * rendering/SVGRenderAsText.h: Removed.
3035
3036 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
3037
3038         Build fix.
3039         
3040         * platform/network/cf/ResourceHandleCFNet.cpp:
3041         (WebCore::willSendRequest):
3042
3043 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
3044
3045         Reviewed by Darin, Beth.
3046         
3047         First cut at factoring Page's UIDelegate-related functions into Chrome
3048         and ChromeClient.
3049
3050         Layout tests pass.
3051         
3052         * bridge/mac/PageMac.mm: Removed platform-specific constructor, added
3053         setBridge method to replace it.
3054         (WebCore::Page::setBridge):
3055
3056         * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact
3057         that WebCorePageBridge.h doesn't need to be included by ObjC-only files,
3058         and, now that it uses PassRefPtr, can't be.
3059         
3060         * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
3061
3062         * page/Page.h:
3063         (WebCore::Page::dragCaretController): Made this function non-const so that
3064         m_dragCaretController doesn't have to be mutable.
3065
3066 2006-11-03  Alexey Proskuryakov  <ap@nypop.com>
3067
3068         Reviewed by Adele.
3069
3070         http://bugs.webkit.org/show_bug.cgi?id=7323
3071         REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
3072
3073         * bridge/mac/FrameMac.h: Moved drag source information to a static variable
3074         in FrameMac.mm. There can be only one drag active at any moment, and having 
3075         this information here was making sharing this information between 
3076         subframes hard.
3077
3078         * bridge/mac/FrameMac.mm:
3079         (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo.
3080         (WebCore::FrameMac::freeClipboard):
3081         (WebCore::FrameMac::dragHysteresisExceeded):
3082         (WebCore::FrameMac::handleMouseMoveEvent):
3083         (WebCore::FrameMac::handleMouseReleaseEvent):
3084         (WebCore::FrameMac::mouseDown):
3085         (WebCore::FrameMac::dragSourceMovedTo):
3086         (WebCore::FrameMac::dragSourceEndedAt):
3087         (WebCore::FrameMac::dispatchDragSrcEvent):
3088         Access drag source info via sharedDragInfo - this fixes drag source even dispatching.
3089         Also removed some old code that was forwarding mouse events to subviews to make 
3090         HTML editing work in subframes.
3091
3092         * page/FrameView.cpp:
3093         (WebCore::FrameView::updateDragAndDrop):
3094         (WebCore::FrameView::cancelDragAndDrop):
3095         (WebCore::FrameView::performDragAndDrop):
3096         Forward events to subframes for dispatching - this fixes drag target events.
3097
3098 2006-11-03  Zack Rusin  <zack@kde.org>
3099
3100         Reviewed by Tim.
3101
3102         Fixing compile.
3103
3104         * platform/qt/LoaderFunctionsQt.cpp:
3105         (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
3106
3107 2006-11-01  Zack Rusin  <zack@kde.org>
3108
3109         Reviewed by Maciej.
3110
3111         Moving the word/sentence seperators into a file of their own
3112         and implementing findWordBoundary.
3113
3114         * CMakeLists.txt:
3115         * platform/qt/TemporaryLinkStubs.cpp:
3116         * platform/qt/TextBoundaries.cpp: Added.
3117         (WebCore::findNextSentenceFromIndex):
3118         (WebCore::findSentenceBoundary):
3119         (WebCore::findNextWordFromIndex):
3120         (WebCore::findWordBoundary):
3121
3122 2006-11-03  Zack Rusin  <zack@kde.org>
3123
3124         Reviewed by Maciej.
3125
3126         Compile on both KDE and Qt platforms
3127
3128         * CMakeLists.txt: add zlib explicitly
3129         * platform/network/qt/ResourceHandleManager.cpp:
3130         (WebCore::ResourceHandleManager::self):
3131         (WebCore::QtJob::QtJob):
3132         (WebCore::QtJob::timerEvent): Integrate both implementations
3133         so that moc can parse it
3134         (WebCore::ResourceHandleManager::deliverJobData):
3135         (WebCore::ResourceHandleManager::remove):
3136         * platform/network/qt/ResourceHandleManager.h:
3137
3138 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
3139
3140         No review, suggested by Mitz.
3141
3142         - fix a #if to be #ifdef
3143
3144         * platform/graphics/svg/cg/SVGResourceImageCg.cpp:
3145
3146 2006-11-03  Zack Rusin  <zack@kde.org>
3147
3148         Reviewed and landed by Maciej.
3149         
3150         Compile on the Qt platform.
3151
3152         * ksvg2/misc/KCanvasRenderingStyle.h:
3153         * platform/qt/RenderThemeQt.cpp:
3154         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
3155
3156 2006-11-03  Zack Rusin  <zack@kde.org>
3157
3158         Reviewed by Hyatt. Landed by Maciej.
3159
3160         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
3161         to graphics context to be able to set consistant state
3162         on the platform specific painter without having to change
3163         fill/stroke/font on every operation. This fixes color/stroke/fill
3164         and font handling in the Qt port.
3165
3166         * platform/graphics/GraphicsContext.cpp:
3167         (WebCore::GraphicsContext::setFont):
3168         (WebCore::GraphicsContext::setPen):
3169         (WebCore::GraphicsContext::setFillColor):
3170         (WebCore::GraphicsContext::setPlatformPen):
3171         (WebCore::GraphicsContext::setPlatformFillColor):
3172         (WebCore::GraphicsContext::setPlatformFont):
3173         * platform/graphics/GraphicsContext.h:
3174         * platform/qt/GraphicsContextQt.cpp:
3175         (WebCore::toQtCompositionMode):
3176         (WebCore::toQtLineCap):
3177         (WebCore::toQtLineJoin):
3178         (WebCore::toQPenStyle):
3179         (WebCore::penToQPen):
3180         (WebCore::TransparencyLayer::TransparencyLayer):
3181         (WebCore::GraphicsContext::addRoundedRectClip):
3182         (WebCore::GraphicsContext::setPlatformFont):
3183         (WebCore::GraphicsContext::setPlatformPen):
3184         (WebCore::GraphicsContext::setPlatformFillColor):
3185         * platform/qt/ScrollViewCanvasQt.cpp:
3186         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
3187         (WebCore::ScrollViewCanvasQt::paintEvent):
3188         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
3189         * platform/qt/ScrollViewCanvasQt.h:
3190
3191 2006-11-02  Adele Peterson  <adele@apple.com>
3192
3193         Reviewed by Anders.
3194
3195         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
3196         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
3197
3198         Test: fast/forms/textarea-no-scroll-on-blur.html
3199
3200         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
3201           On blur, only scroll back to the start for text fields.
3202
3203 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3204
3205         Another build fix.
3206         
3207         * rendering/RenderFileUploadControl.cpp:
3208         (WebCore::RenderFileUploadControl::paintObject):
3209
3210 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3211
3212         Build fix.
3213         
3214         * page/FramePrivate.h:
3215         (WebCore::FramePrivate::FramePrivate):
3216
3217 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
3218
3219         Reviewed by Geoff, landed by Anders.
3220         
3221         Fix dependency problems caused when running move-js-headers.sh
3222         
3223         * move-js-headers.sh:
3224         Use cp -p instead of just cp so that the modification time
3225         of the original files are used.
3226
3227 2006-11-02  Adam Roben  <aroben@apple.com>
3228
3229         Reviewed by Tim H, landed by Anders.
3230
3231         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
3232         REGRESSION: Shadow of file upload button is clipped
3233
3234         * rendering/RenderFileUploadControl.cpp:
3235         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
3236         height to keep from clipping in the shadow
3237
3238 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
3239
3240         Reviewed by Maciej, landed by Anders.
3241
3242         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
3243         content and window. ScrollViewQt already receives correct content
3244         coordinates from QScrollArea.
3245         (WebCore::ScrollView::contentsToWindow):
3246         (WebCore::ScrollView::windowToContents):
3247
3248 2006-11-02  Simon Hausmann  <hausmann@kde.org>
3249
3250         Reviewed by Maciej, landed by Anders
3251
3252         * CMakeLists.txt: Make linkage against KDE libraries conditional
3253         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
3254           Qt base resource handler that supports only requests to the
3255           local filesystem. Used when compiling without KDE support.
3256           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
3257           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
3258         (WebCore::QtJob::QtJob):
3259         (WebCore::QtJob::timerEvent):
3260         (WebCore::ResourceHandleManager::ResourceHandleManager):
3261         (WebCore::ResourceHandleManager::~ResourceHandleManager):
3262         (WebCore::ResourceHandleManager::self):
3263         (WebCore::ResourceHandleManager::remove):
3264         (WebCore::ResourceHandleManager::add):
3265         (WebCore::ResourceHandleManager::cancel):
3266         (WebCore::ResourceHandleManager::deliverJobData):
3267         * platform/network/qt/ResourceHandleManager.h:
3268         * platform/qt/FrameQtClient.cpp:
3269         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
3270         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
3271         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
3272         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
3273           input dialog functions when compiling without KDE support
3274         (WebCore::ServeSynchronousRequest):
3275
3276 2006-11-02  David Carson  <dacarson@gmail.com>
3277
3278         Reviewed by Geoff, landed by Anders.
3279
3280         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
3281         Initializing variable in constructor.
3282
3283         * page/FramePrivate.h:
3284         (WebCore::FramePrivate::FramePrivate):
3285
3286 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3287
3288         Reviewed by Geoff.
3289
3290         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
3291         
3292         * platform/network/cf/ResourceHandleCFNet.cpp:
3293         (WebCore::addHeadersFromHashMap):
3294         Don't set all headers at once since that clears any previous headers set.
3295         
3296         (WebCore::ResourceHandle::start):
3297
3298 2006-11-02  Adele Peterson  <adele@apple.com>
3299
3300         Reviewed by Mitz and Geoff.
3301
3302         - Fix for:
3303         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
3304         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
3305         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
3306
3307         Test: fast/forms/textarea-scrollbar.html
3308
3309         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
3310         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
3311
3312         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
3313         * rendering/RenderTextControl.cpp: 
3314         (WebCore::RenderTextControl::RenderTextControl):
3315         (WebCore::RenderTextControl::setStyle):
3316         (WebCore::RenderTextControl::createDivStyle):
3317         (WebCore::RenderTextControl::updateFromElement):
3318         (WebCore::RenderTextControl::calcHeight):
3319         (WebCore::RenderTextControl::baselinePosition):
3320         (WebCore::RenderTextControl::nodeAtPoint):
3321         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
3322         (WebCore::RenderTextControl::scrollWidth):
3323         (WebCore::RenderTextControl::scrollHeight):
3324         (WebCore::RenderTextControl::scrollLeft):
3325         (WebCore::RenderTextControl::scrollTop):
3326
3327         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
3328
3329 2006-11-02  John Sullivan  <sullivan@apple.com>
3330
3331         Reviewed by Geoff Garen
3332
3333         * editing/Selection.cpp:
3334         (WebCore::Selection::showTreeForThis):
3335         this debugging method now displays start offset and end offset, at Darin's suggestion
3336
3337 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
3338
3339         Reviewed by darin
3340
3341         <rdar://problem/4062865>
3342         Copy/paste of a select element fails to include the options
3343         
3344         * editing/SelectionController.cpp:
3345         (WebCore::SelectionController::modify): Added paragraphBoundary.
3346         * editing/htmlediting.cpp:
3347         (WebCore::canHaveChildrenForEditing): Added checks for input elements
3348         and textareas.  Insertion operations would fail when performed just 
3349         before/after one of these elements b/c the content would be put inside 
3350         the element.
3351         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
3352         editable content, and made the code to stop at an root faster (don't check
3353         isDescendantOf on every iteration).
3354         (WebCore::enclosingNodeOfType): Ditto.
3355         (WebCore::enclosingList): Ditto.
3356         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
3357         inappropriately named.
3358         * editing/markup.cpp:
3359         (WebCore::startMarkup): Use the text node's value instead of its rendered
3360         content for text nodes inside select elements.  One might also turn off
3361         annotation when createMarkup enters a select element, but createMarkup
3362         is iterative, not recursive, so doing so would be complicated.
3363         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
3364         descendants of a select element.
3365         * editing/visible_units.cpp:
3366         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
3367         where various replaced elements can't be copied when they are the only
3368         thing selected.
3369         (WebCore::endOfParagraph): Ditto.
3370
3371 2006-11-01  Oliver Hunt  <oliver@apple.com>
3372
3373         Reviewed by Adam.
3374
3375         Converting more or kcanvas/quartz from Obj-C to C++
3376         Minor SVG updates
3377         compatibility fixes
3378
3379         * WebCore.xcodeproj/project.pbxproj:
3380         * kcanvas/device/KRenderingPaintServer.h:
3381         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
3382         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
3383         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
3384         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
3385         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
3386         * kcanvas/device/quartz/QuartzSupport.h:
3387         * ksvg2/css/SVGCSSStyleSelector.cpp:
3388         * ksvg2/misc/KCanvasRenderingStyle.h:
3389         * ksvg2/scripts/cssmakeprops:
3390         * ksvg2/scripts/cssmakevalues:
3391         * ksvg2/scripts/make_names.pl:
3392         * ksvg2/svg/SVGAnimateColorElement.cpp:
3393         * ksvg2/svg/SVGAnimateTransformElement.cpp:
3394         * ksvg2/svg/SVGAnimationElement.cpp:
3395         * ksvg2/svg/SVGMaskElement.cpp:
3396         * ksvg2/svg/SVGPatternElement.cpp:
3397         * ksvg2/svg/svgpathparser.cpp:
3398         * platform/Path.cpp:
3399         * platform/graphics/svg/SVGResourceImage.h:
3400         * rendering/RenderPath.cpp:
3401         * rendering/SVGRenderAsText.cpp:
3402
3403 2006-11-02  Mitz Pettel  <mitz@webkit.org>
3404
3405         Reviewed by Adele.
3406
3407         - Fix a regression from r17521: painting of and crash caused by tables
3408           with collapsed borders
3409
3410         * rendering/RenderTable.cpp:
3411         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
3412         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
3413         and 'paintInfo' is the parameter, which we were accidently modifying.
3414
3415 2006-11-01  Adele Peterson  <adele@apple.com>
3416
3417         Reviewed by Mitz.
3418
3419         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
3420         REGRESSION: Incomplete repaint of overflow areas when deleting
3421
3422         Restrict the repaint rect for overflow blocks after the height has been fully computed.
3423         Also, adjust the repaint rect coordinates for the scroll offset.
3424
3425         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
3426         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
3427
3428 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
3429
3430         Reviewed by Mitz.
3431
3432         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
3433         Rename the "p" member variable of the PaintInfo struct to "context"
3434
3435         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
3436           'context' and 'rect' respectively.
3437
3438         - Assorted surrounding cleanups.
3439
3440         * rendering/EllipsisBox.cpp:
3441         (WebCore::EllipsisBox::paint):
3442         * rendering/EllipsisBox.h:
3443         * rendering/InlineBox.cpp:
3444         (WebCore::InlineBox::paint):
3445         * rendering/InlineFlowBox.cpp:
3446         (WebCore::InlineFlowBox::paint):
3447         (WebCore::InlineFlowBox::paintBackground):
3448         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
3449         (WebCore::InlineFlowBox::paintDecorations):
3450         * rendering/InlineFlowBox.h:
3451         * rendering/InlineRunBox.h:
3452         * rendering/InlineTextBox.cpp:
3453         (WebCore::InlineTextBox::paint):
3454         * rendering/InlineTextBox.h:
3455         * rendering/RenderBlock.cpp:
3456         (WebCore::RenderBlock::paint):
3457         (WebCore::RenderBlock::paintChildren):
3458         (WebCore::RenderBlock::paintCaret):
3459         (WebCore::RenderBlock::paintObject):
3460         (WebCore::RenderBlock::paintFloats):
3461         (WebCore::RenderBlock::paintEllipsisBoxes):
3462         (WebCore::RenderBlock::paintSelection):
3463         (WebCore::RenderBlock::fillSelectionGaps):
3464         (WebCore::RenderBlock::fillInlineSelectionGaps):
3465         (WebCore::RenderBlock::fillBlockSelectionGaps):
3466         (WebCore::RenderBlock::fillHorizontalSelectionGap):
3467         (WebCore::RenderBlock::fillVerticalSelectionGap):
3468         (WebCore::RenderBlock::fillLeftSelectionGap):
3469         (WebCore::RenderBlock::fillRightSelectionGap):
3470         * rendering/RenderBox.cpp:
3471         (WebCore::RenderBox::paint):
3472         (WebCore::RenderBox::paintRootBoxDecorations):
3473         (WebCore::RenderBox::paintBoxDecorations):
3474         * rendering/RenderBox.h:
3475         * rendering/RenderButton.cpp:
3476         (WebCore::RenderButton::paintObject):
3477         * rendering/RenderFieldset.cpp:
3478         (WebCore::RenderFieldset::paintBoxDecorations):
3479         * rendering/RenderFileUploadControl.cpp:
3480         (WebCore::RenderFileUploadControl::paintObject):
3481         * rendering/RenderFlow.cpp:
3482         (WebCore::RenderFlow::continuationBefore):
3483         (WebCore::RenderFlow::addChildWithContinuation):
3484         (WebCore::RenderFlow::addChild):
3485         (WebCore::RenderFlow::attachLineBox):
3486         (WebCore::RenderFlow::destroy):
3487         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
3488         (WebCore::RenderFlow::dirtyLineBoxes):
3489         (WebCore::RenderFlow::createInlineBox):
3490         (WebCore::RenderFlow::paintLines):
3491         (WebCore::RenderFlow::getAbsoluteRepaintRect):
3492         (WebCore::RenderFlow::lowestPosition):
3493         (WebCore::RenderFlow::rightmostPosition):
3494         (WebCore::RenderFlow::leftmostPosition):
3495         (WebCore::RenderFlow::caretRect):
3496         (WebCore::RenderFlow::addFocusRingRects):
3497         (WebCore::RenderFlow::paintOutline):
3498         (WebCore::RenderFlow::paintOutlineForLine):
3499         * rendering/RenderForeignObject.cpp:
3500         (WebCore::RenderForeignObject::paint):
3501         * rendering/RenderHTMLCanvas.cpp:
3502         (WebCore::RenderHTMLCanvas::paint):
3503         * rendering/RenderImage.cpp:
3504         (WebCore::RenderImage::paint):
3505         * rendering/RenderLayer.cpp:
3506         (WebCore::RenderLayer::paintLayer):
3507         * rendering/RenderListBox.cpp:
3508         (WebCore::RenderListBox::paintObject):
3509         (WebCore::RenderListBox::paintScrollbar):
3510         (WebCore::RenderListBox::paintItemForeground):
3511         (WebCore::RenderListBox::paintItemBackground):
3512         * rendering/RenderListMarker.cpp:
3513         (WebCore::RenderListMarker::paint):
3514         * rendering/RenderMenuList.cpp:
3515         (WebCore::RenderMenuList::paintObject):
3516         * rendering/RenderObject.cpp:
3517         (WebCore::RenderObject::paint):
3518         * rendering/RenderObject.h:
3519         (WebCore::RenderObject::PaintInfo::PaintInfo):
3520         (WebCore::RenderObject::paintBoxDecorations):
3521         (WebCore::RenderObject::paintingRootForChildren):
3522         (WebCore::RenderObject::shouldPaintWithinRoot):
3523         (WebCore::RenderObject::printBoxDecorations):
3524         * rendering/RenderPath.cpp:
3525         (WebCore::RenderPath::paint):
3526         * rendering/RenderReplaced.cpp:
3527         (WebCore::RenderReplaced::shouldPaint):
3528         * rendering/RenderSVGContainer.cpp:
3529         (WebCore::RenderSVGContainer::paint):
3530         * rendering/RenderSVGContainer.h:
3531         * rendering/RenderSVGImage.cpp:
3532         (WebCore::RenderSVGImage::paint):
3533         * rendering/RenderSVGText.cpp:
3534         (WebCore::RenderSVGText::paint):
3535         * rendering/RenderSVGText.h:
3536         (WebCore::RenderSVGText::renderName):
3537         * rendering/RenderTable.cpp:
3538         (WebCore::RenderTable::paint):
3539         (WebCore::RenderTable::paintBoxDecorations):
3540         * rendering/RenderTable.h:
3541         * rendering/RenderTableCell.cpp:
3542         (WebCore::RenderTableCell::paint):
3543         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
3544         (WebCore::RenderTableCell::paintBoxDecorations):
3545         * rendering/RenderTableCell.h:
3546         * rendering/RenderTableRow.cpp:
3547         (WebCore::RenderTableRow::paint):
3548         * rendering/RenderTableRow.h:
3549         * rendering/RenderTableSection.cpp:
3550         (WebCore::RenderTableSection::paint):
3551         * rendering/RenderTableSection.h:
3552         (WebCore::RenderTableSection::getBaseline):
3553         (WebCore::RenderTableSection::setNeedCellRecalc):
3554         * rendering/RenderText.h:
3555         (WebCore::RenderText::renderName):
3556         (WebCore::RenderText::paint):
3557         (WebCore::RenderText::element):
3558         * rendering/RenderTheme.cpp:
3559         (WebCore::RenderTheme::paint):
3560         (WebCore::RenderTheme::paintBorderOnly):
3561         (WebCore::RenderTheme::paintDecorations):
3562         * rendering/RenderTheme.h:
3563         (WebCore::RenderTheme::RenderTheme):
3564         (WebCore::RenderTheme::~RenderTheme):
3565         (WebCore::RenderTheme::controlSupportsTints):
3566         (WebCore::RenderTheme::adjustRepaintRect):
3567         (WebCore::RenderTheme::themeChanged):
3568         (WebCore::RenderTheme::supportsHover):
3569         (WebCore::RenderTheme::paintCheckbox):
3570         (WebCore::RenderTheme::setCheckboxSize):
3571         (WebCore::RenderTheme::paintRadio):
3572         (WebCore::RenderTheme::setRadioSize):
3573         (WebCore::RenderTheme::paintButton):
3574         (WebCore::RenderTheme::setButtonSize):
3575         (WebCore::RenderTheme::paintTextField):
3576         (WebCore::RenderTheme::paintTextArea):
3577         (WebCore::RenderTheme::paintMenuList):
3578         (WebCore::RenderTheme::paintMenuListButton):
3579         * rendering/RenderThemeMac.mm:
3580         (WebCore::RenderThemeMac::paintCheckbox):
3581         (WebCore::RenderThemeMac::paintRadio):
3582         (WebCore::RenderThemeMac::paintButton):
3583         (WebCore::RenderThemeMac::paintTextField):
3584         (WebCore::RenderThemeMac::paintTextArea):
3585         (WebCore::RenderThemeMac::paintMenuList):
3586         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
3587         (WebCore::RenderThemeMac::paintMenuListButton):
3588         * rendering/RenderView.cpp:
3589         (WebCore::RenderView::paint):
3590         (WebCore::RenderView::paintBoxDecorations):
3591         * rendering/RenderView.h:
3592         * rendering/RenderWidget.cpp:
3593         (WebCore::RenderWidget::paint):
3594         * rendering/RenderWidget.h:
3595         (WebCore::RenderWidget::isWidget):
3596         * rendering/RootInlineBox.cpp:
3597         (WebCore::RootInlineBox::paintEllipsisBox):
3598         (WebCore::RootInlineBox::paintCustomHighlight):
3599         (WebCore::RootInlineBox::paint):
3600         (WebCore::RootInlineBox::fillLineSelectionGap):
3601         * rendering/RootInlineBox.h:
3602         * rendering/SVGInlineFlowBox.cpp:
3603         (WebCore::paintSVGInlineFlow):
3604
3605 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
3606
3607         Reviewed by Oliver, Brady.
3608
3609         * platform/network/ResourceResponse.h:
3610         (WebCore::ResourceResponse::setLastModifiedDate):
3611         (WebCore::ResourceResponse::lastModifiedDate):
3612         Add getters and setters for last modified dadte.
3613         
3614         * platform/network/cf/ResourceResponseCFNet.cpp:
3615         (WebCore::getResourceResponse):
3616         Fetch the last modified date. Add correct offset to expired date.
3617
3618 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
3619
3620         Reviewed by Mitz.
3621
3622         Added missing "break;" statement in switch statement from r17493.
3623
3624         Bug 11442: [CSS 3] support for cursor: all-scroll
3625         http://bugs.webkit.org/show_bug.cgi?id=11442
3626
3627         * css/CSSComputedStyleDeclaration.cpp:
3628         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3629
3630 2006-10-31  Mitz Pettel  <mitz@webkit.org>
3631
3632         Reviewed by Maciej.
3633
3634         - fix image dragging
3635
3636         This is covered by editing/selection/drag-to-contenteditable-iframe.html
3637
3638         * rendering/HitTestResult.cpp:
3639         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
3640         HTML IMG elements.
3641         (WebCore::HitTestResult::absoluteImageURL): Ditto.
3642
3643 2006-10-31  Beth Dakin  <bdakin@apple.com>
3644
3645         Reviewed by Maciej.
3646
3647         This adds the back-end of the remaining WebElementDictionary 
3648         functions into HitTestResult.
3649
3650         * WebCore.exp:
3651         * rendering/HitTestResult.cpp:
3652         (WebCore::HitTestResult::title):
3653         (WebCore::displayString): This is nearly identical to the 
3654         displayString() defined in DOMInternal.mm except that it returns a 
3655         String instead of an NSString. The old code path used the 
3656         DOMInternal method, so I made a new one here for the new code path.
3657         (WebCore::HitTestResult::altDisplayString):
3658         (WebCore::HitTestResult::image):
3659         (WebCore::HitTestResult::absoluteImageURL):
3660         (WebCore::HitTestResult::absoluteLinkURL):
3661         (WebCore::HitTestResult::titleDisplayString):
3662         (WebCore::HitTestResult::textContent):
3663         * rendering/HitTestResult.h:
3664
3665 2006-10-31  John Sullivan  <sullivan@apple.com>
3666
3667         * bridge/mac/FrameMac.mm:
3668         (WebCore::FrameMac::markMisspellings):
3669         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
3670
3671 2006-10-31  John Sullivan  <sullivan@apple.com>
3672
3673         Reviewed by Maciej
3674         
3675         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
3676         
3677         The foundation of this was in my last checkin. This checkin is all about displaying
3678         the correct string in the toolTip.
3679
3680         * dom/DocumentMarker.h:
3681         New description field in this struct.
3682
3683         * bridge/mac/FrameMac.mm:
3684         (WebCore::FrameMac::advanceToNextMisspelling):
3685         When adding a grammar marker, supply the appropriate description. Also, added a comment
3686         about the remaining work to make grammar checking return sensible answers.
3687         (WebCore::FrameMac::markMisspellings):
3688         ditto (yes, still needs some refactoring to minimize duplicated code)
3689         
3690         * dom/Document.h:
3691         * dom/Document.cpp:
3692         (WebCore::Document::addMarker):
3693         Now takes an optional description string
3694         (WebCore::Document::markerContainingPoint):
3695         New function, returns a pointer to the (first) marker of the specified type whose rect 
3696         contains the specified point, or 0 if none.
3697         
3698         * rendering/HitTestResult.cpp:
3699         (WebCore::HitTestResult::spellingToolTip):
3700         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
3701         and gets the description from the marker.
3702
3703 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
3704
3705         Reviewed by Maciej.
3706         
3707         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
3708
3709         * loader/mac/FrameLoaderMac.mm:
3710         (WebCore::FrameLoader::createWindow):
3711         * manual-tests/window-open-features-parsing.html: Updated for clarity.
3712
3713 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
3714
3715         Reviewed by Alice.
3716
3717         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
3718         to WebCore::Editor.
3719         
3720         Layout tests pass.
3721         
3722         Renamed "may*" to "can*" because "can" is more accurate (these functions
3723         aren't just about permission) and it matches WebKit.
3724
3725         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
3726         password field. Now that WebCore fully implements canCopy(), it doesn't just
3727         mean "the selection is not in a password field" anymore.
3728         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
3729         The fact that it's not called anymore may represent a security issue, but I
3730         don't see how commented-out code will help reveal the issue, and the
3731         bridge is going away, anyway.
3732         * editing/SelectionController.h: Changed selection() calls to references
3733         to m_sel, to match the rest of the file.
3734
3735 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
3736
3737         Reviewed by harrison
3738         
3739         <rdar://problem/4711063>
3740         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
3741
3742         * editing/ReplaceSelectionCommand.cpp:
3743         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
3744         insertion and plain text string creation unless we need the string
3745         for a BeforeTextInserted event handler or for a plain text only region.
3746         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
3747         code here from ReplacementFragment's constructor.
3748         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
3749         FIXME.
3750         * editing/ReplaceSelectionCommand.h:
3751
3752 2006-10-31  Ada Chan  <adachan@apple.com>
3753
3754         Reviewed by Adam
3755
3756         Correct forward declarations of the HitTestRequest struct.
3757
3758         * rendering/EllipsisBox.h:
3759         * rendering/InlineBox.h:
3760         * rendering/InlineFlowBox.h:
3761         * rendering/RenderLayer.h:
3762         * rendering/RenderObject.h:
3763
3764 2006-10-31  John Sullivan  <sullivan@apple.com>
3765
3766         Reviewed by Beth and Adam
3767
3768         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
3769         next I'll make it use a string that's relevant for a specific grammar error.
3770
3771         * WebCore.exp:
3772         export symbol for spellingToolTip function
3773         
3774         * rendering/HitTestResult.h:
3775         * rendering/HitTestResult.cpp:
3776         (WebCore::HitTestResult::spellingToolTip):
3777         new function, returns the string to be used in a tool tip that describes the questionable grammar
3778         
3779         * rendering/InlineTextBox.h:
3780         * rendering/InlineTextBox.cpp:
3781         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
3782         now takes a style and font, needed to compute the rect representing the range containing
3783         questionable grammar. Computes the rect and associates it with the marker.
3784         (WebCore::InlineTextBox::paintDocumentMarkers):
3785         Pass in the style and font now needed by paintSpellingOrGrammarMarker
3786
3787 2006-10-31  Adele Peterson  <adele@apple.com>
3788
3789         Removed commented out variable from last checkin.
3790
3791         * html/HTMLSelectElement.cpp:
3792         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
3793
3794 2006-10-31  Brady Eidson  <beidson@apple.com>
3795
3796         Build fix (unused variable in release builds)
3797
3798         * html/HTMLSelectElement.cpp:
3799         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
3800
3801 2006-10-31  Adele Peterson  <adele@apple.com>
3802
3803         Reviewed by Adam.
3804
3805         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
3806         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
3807         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
3808
3809         Tests: 
3810         * LayoutTests/fast/forms/listbox-selection.html
3811         * LayoutTests/fast/forms/listbox-onchange.html
3812
3813         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
3814           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
3815           And one for onChange, that is updated after onChange is fired.
3816           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
3817  
3818         * html/HTMLSelectElement.cpp:
3819         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
3820         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
3821         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
3822         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
3823         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
3824         (WebCore::HTMLSelectElement::setExtent): Added.
3825         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
3826         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
3827
3828         * rendering/RenderListBox.cpp:
3829         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
3830         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
3831         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
3832         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
3833          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
3834          notify the select element from here.
3835         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
3836         (WebCore::RenderListBox::listIndexIsVisible): Added.
3837         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
3838
3839         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
3840         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
3841         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
3842         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
3843         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
3844
3845 2006-10-31  Beth Dakin  <bdakin@apple.com>
3846
3847         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
3848
3849         * rendering/HitTestRequest.h: Added.
3850         (WebCore::HitTestRequest::HitTestRequest):
3851
3852 2006-10-31  Beth Dakin  <bdakin@apple.com>
3853
3854         Reviewed by Maciej.
3855
3856         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
3857         should be split into HitTestRequest and HitTestResult
3858
3859         This patch creates a new struct called HitTestRequest that holds 
3860         the three boolean values (readonly, active, and mouseMove) that 
3861         were formerly a part of HitTestResult. All hitTest() and 
3862         nodeAtPoint() functions now take a HitTestRequest in addition to 
3863         the HitTestResult.
3864
3865         * WebCore.exp:
3866         * WebCore.xcodeproj/project.pbxproj:
3867         * bridge/mac/FrameMac.mm:
3868         (WebCore::FrameMac::eventMayStartDrag):
3869         (WebCore::FrameMac::handleMouseMoveEvent):
3870         * bridge/mac/WebCoreAXObject.mm:
3871         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
3872         (-[WebCoreAXObject accessibilityHitTest:]):
3873         * dom/Document.cpp:
3874         (WebCore::Document::elementFromPoint):
3875         (WebCore::Document::prepareMouseEvent):
3876         * editing/SelectionController.cpp:
3877         (WebCore::SelectionController::contains):
3878         * page/Frame.cpp:
3879         (WebCore::Frame::hitTestResultAtPoint):
3880         * page/FrameView.cpp:
3881         (WebCore::FrameView::handleWheelEvent):
3882         * rendering/EllipsisBox.cpp:
3883         (WebCore::EllipsisBox::nodeAtPoint):
3884         * rendering/EllipsisBox.h:
3885         * rendering/HitTestResult.cpp:
3886         (WebCore::HitTestResult::HitTestResult):
3887         (WebCore::HitTestResult::operator=):
3888         * rendering/HitTestResult.h:
3889         * rendering/InlineBox.cpp:
3890         (WebCore::InlineBox::nodeAtPoint):
3891         * rendering/InlineBox.h:
3892         * rendering/InlineFlowBox.cpp:
3893         (WebCore::InlineFlowBox::nodeAtPoint):
3894         * rendering/InlineFlowBox.h:
3895         * rendering/InlineTextBox.cpp:
3896         (WebCore::InlineTextBox::nodeAtPoint):
3897         * rendering/InlineTextBox.h:
3898         * rendering/RenderBlock.cpp:
3899         (WebCore::RenderBlock::nodeAtPoint):
3900         * rendering/RenderBlock.h:
3901         * rendering/RenderBox.cpp:
3902         (WebCore::RenderBox::nodeAtPoint):
3903         * rendering/RenderBox.h:
3904         * rendering/RenderFlow.cpp:
3905         (WebCore::RenderFlow::hitTestLines):
3906         * rendering/RenderFlow.h:
3907         * rendering/RenderForeignObject.cpp:
3908         (WebCore::RenderForeignObject::nodeAtPoint):
3909         * rendering/RenderForeignObject.h:
3910         * rendering/RenderFrameSet.cpp:
3911         (WebCore::RenderFrameSet::nodeAtPoint):
3912         * rendering/RenderFrameSet.h:
3913         * rendering/RenderImage.cpp:
3914         (WebCore::RenderImage::nodeAtPoint):
3915         * rendering/RenderImage.h:
3916         * rendering/RenderInline.cpp:
3917         (WebCore::RenderInline::nodeAtPoint):
3918         * rendering/RenderInline.h:
3919         * rendering/RenderLayer.cpp:
3920         (WebCore::RenderLayer::autoscroll):
3921         (WebCore::RenderLayer::hitTest):
3922         (WebCore::RenderLayer::hitTestLayer):
3923         (WebCore::RenderLayer::updateHoverActiveState):
3924         * rendering/RenderLayer.h:
3925         * rendering/RenderObject.cpp:
3926         (WebCore::RenderObject::hitTest):
3927         (WebCore::RenderObject::nodeAtPoint):
3928         * rendering/RenderObject.h:
3929         * rendering/RenderPath.cpp:
3930         (WebCore::RenderPath::nodeAtPoint):
3931         * rendering/RenderPath.h:
3932         * rendering/RenderSVGImage.cpp:
3933         (WebCore::RenderSVGImage::nodeAtPoint):
3934         * rendering/RenderSVGImage.h:
3935         * rendering/RenderSVGText.cpp:
3936         (WebCore::RenderSVGText::nodeAtPoint):
3937         * rendering/RenderSVGText.h:
3938         * rendering/RenderTableRow.cpp:
3939         (WebCore::RenderTableRow::nodeAtPoint):
3940         * rendering/RenderTableRow.h:
3941         * rendering/RenderTableSection.cpp:
3942         (WebCore::RenderTableSection::nodeAtPoint):
3943         * rendering/RenderTableSection.h:
3944         * rendering/RenderText.h:
3945         (WebCore::RenderText::nodeAtPoint):
3946         * rendering/RenderTextControl.cpp:
3947         (WebCore::RenderTextControl::nodeAtPoint):
3948         * rendering/RenderTextControl.h:
3949         * rendering/RootInlineBox.cpp:
3950         (WebCore::RootInlineBox::nodeAtPoint):
3951         * rendering/RootInlineBox.h:
3952
3953 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
3954
3955         Reviewed by Maciej.
3956
3957         Bug 11442: [CSS 3] support for cursor: all-scroll
3958         http://bugs.webkit.org/show_bug.cgi?id=11442
3959
3960         * css/CSSComputedStyleDeclaration.cpp:
3961         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3962         * css/CSSValueKeywords.in:
3963         * css/cssparser.cpp:
3964         (WebCore::CSSParser::parseValue):
3965         * page/FrameView.cpp:
3966         (WebCore::selectCursor):
3967         * rendering/RenderStyle.h:
3968
3969 2006-10-31  Oliver Hunt  <oliver@apple.com>
3970
3971         Reviewed by Geoff.
3972
3973         Converting Obj-C++ to C++ in kcanvas
3974
3975         * WebCore.xcodeproj/project.pbxproj:
3976         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
3977         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3978         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
3979         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
3980         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
3981         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
3982         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
3983         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3984         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
3985         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
3986         * kcanvas/device/quartz/QuartzSupport.h:
3987         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
3988         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
3989         (WebCore::SVGResourceClipper::applyClip):
3990         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
3991         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
3992         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
3993
3994 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
3995
3996         Reviewed by harrison
3997         
3998         <rdar://problem/4808375>
3999         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
4000         
4001         Completely back out r17276 because of performance issues.
4002
4003         * editing/TextIterator.cpp:
4004         (WebCore::TextIterator::TextIterator):
4005         (WebCore::TextIterator::advance):
4006         (WebCore::TextIterator::handleTextNode):
4007         (WebCore::TextIterator::handleTextBox):
4008         (WebCore::TextIterator::handleReplacedElement):
4009         (WebCore::TextIterator::handleNonTextNode):
4010         (WebCore::TextIterator::exitNode):
4011         (WebCore::TextIterator::emitCharacter):
4012         (WebCore::TextIterator::range):
4013         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
4014         (WebCore::SimplifiedBackwardsTextIterator::advance):
4015         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
4016         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
4017         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
4018         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
4019         (WebCore::SimplifiedBackwardsTextIterator::range):
4020         (WebCore::CharacterIterator::range):
4021         (WebCore::TextIterator::rangeFromLocationAndLength):
4022         * editing/TextIterator.h:
4023         (WebCore::TextIterator::atEnd):
4024         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
4025
4026 2006-10-31  Darin Adler  <darin@apple.com>
4027
4028         Reviewed by Brady.
4029
4030         - got "action dictionary" code out of FrameLoader,
4031           replacing with a class called NavigationAction
4032
4033         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
4034         * loader/mac/DocumentLoaderMac.mm:
4035         (WebCore::DocumentLoader::triggeringAction): Ditto.
4036         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
4037
4038         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
4039
4040         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
4041         Removed elementForEvent.
4042         * loader/mac/FrameLoaderMac.mm:
4043         (WebCore::FrameLoader::load): Ditto.
4044         (WebCore::FrameLoader::reload): Ditto.
4045         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
4046         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
4047         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
4048         (WebCore::FrameLoader::post): Ditto.
4049
4050         * loader/NavigationAction.h: Added.
4051         * loader/NavigationAction.cpp: Added.
4052         * loader/mac/NavigationActionMac.mm: Added.
4053
4054         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
4055
4056         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
4057         * WebCore.exp: Updated.
4058
4059 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
4060
4061         Reviewed by Adam.
4062
4063         Build fix
4064
4065         * platform/win/CookieJarWin.cpp:
4066         (WebCore::cookies):
4067
4068 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
4069
4070         Reviewed by Maciej. Landed by Adam.
4071
4072         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
4073
4074         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
4075         as dicussed with Dave. Also kill the outdated DESIGN document.
4076
4077         * CMakeLists.txt:
4078         * WebCore.xcodeproj/project.pbxproj:
4079         * kcanvas/DESIGN: Removed.
4080         * kcanvas/KCanvasFilters.cpp:
4081         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
4082         * kcanvas/KCanvasTreeDebug.h: Ditto.
4083         * kcanvas/device/KRenderingPaintServerGradient.cpp:
4084         * kcanvas/device/KRenderingPaintServerPattern.cpp:
4085         * kcanvas/device/KRenderingPaintServerSolid.cpp:
4086         * platform/graphics/svg/SVGResourceClipper.cpp:
4087         * rendering/RenderTreeAsText.cpp:
4088         * rendering/SVGRenderTreeAsText.cpp: Added.
4089         * rendering/SVGRenderTreeAsText.h: Added.
4090         (WebCore::operator<<):
4091
4092 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
4093
4094         Reviewed by Maciej.
4095
4096         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
4097         Includes some CRLF -> LF fixups.
4098
4099         * platform/win/CookieJarWin.cpp:
4100         (WebCore::cookies):
4101
4102 2006-10-31  Adam Roben  <aroben@apple.com>
4103
4104         Reviewed by Steve.
4105
4106         Fix some incorrect forward declarations.
4107
4108         * loader/FrameLoader.h:
4109         * page/Frame.h:
4110
4111 2006-10-31  Darin Adler  <darin@apple.com>
4112
4113         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
4114         try to fix the build on the buildbot.
4115
4116 2006-10-31  Darin Adler  <darin@apple.com>
4117
4118         * bridge/mac/FrameMac.mm:
4119         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
4120         (WebCore::FrameMac::markMisspellings): Ditto.
4121
4122 2006-10-31  John Sullivan  <sullivan@apple.com>
4123
4124         * bridge/mac/FrameMac.mm:
4125         (WebCore::FrameMac::advanceToNextMisspelling):
4126         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
4127
4128 2006-10-30  John Sullivan  <sullivan@apple.com>
4129
4130         Reviewed by Adam Roben
4131         
4132         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
4133         
4134         This patch introduces much of the guts of grammar checking, though still not enough to actually
4135         check grammar sensibly, due to:
4136           
4137         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
4138         context passed to grammar checker
4139
4140         * platform/Logging.h:
4141         * platform/Logging.cpp:
4142         new log channel SpellingAndGrammar
4143
4144         * bridge/mac/WebCorePageBridge.mm:
4145         (initializeLoggingChannelsIfNecessary):
4146         initialize new log channel
4147
4148         * bridge/mac/FrameMac.mm:
4149         (WebCore::FrameMac::advanceToNextMisspelling):
4150         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
4151         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
4152         in the event of a tie), and do further processing with that one (select range; create marker that
4153         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
4154         (WebCore::FrameMac::markMisspellings):
4155         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
4156         differently enough to make sharing code between these two functions a little tricky, so I decided to 
4157         save that for a later patch.
4158         
4159         (WebCore::FrameMac::respondToChangedSelection):
4160         remove grammar markers when we remove spelling markers        
4161
4162 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
4163
4164         Reviewed by Mitz.
4165
4166         Fix Qt/Linux build with older gcc3.3.4.
4167
4168         * bindings/js/kjs_window.cpp: