WebCore/ChangeLog

   1 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
   2
   3         Another build fix.
   4
   5         * rendering/RenderFileUploadControl.cpp:
   6         (WebCore::RenderFileUploadControl::paintObject):
   7
   8 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
   9
  10         Build fix.
  11
  12         * page/FramePrivate.h:
  13         (WebCore::FramePrivate::FramePrivate):
  14
  15 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
  16
  17         Reviewed by Geoff, landed by Anders.
  18
  19         Fix dependency problems caused when running move-js-headers.sh
  20
  21         * move-js-headers.sh:
  22         Use cp -p instead of just cp so that the modification time
  23         of the original files are used.
  24
  25 2006-11-02  Adam Roben  <aroben@apple.com>
  26
  27         Reviewed by Tim H, landed by Anders.
  28
  29         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
  30         REGRESSION: Shadow of file upload button is clipped
  31
  32         * rendering/RenderFileUploadControl.cpp:
  33         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
  34         height to keep from clipping in the shadow
  35
  36 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
  37
  38         Reviewed by Maciej, landed by Anders.
  39
  40         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
  41         content and window. ScrollViewQt already receives correct content
  42         coordinates from QScrollArea.
  43         (WebCore::ScrollView::contentsToWindow):
  44         (WebCore::ScrollView::windowToContents):
  45
  46 2006-11-02  Simon Hausmann  <hausmann@kde.org>
  47
  48         Reviewed by Maciej, landed by Anders
  49
  50         * CMakeLists.txt: Make linkage against KDE libraries conditional
  51         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
  52           Qt base resource handler that supports only requests to the
  53           local filesystem. Used when compiling without KDE support.
  54           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
  55           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
  56         (WebCore::QtJob::QtJob):
  57         (WebCore::QtJob::timerEvent):
  58         (WebCore::ResourceHandleManager::ResourceHandleManager):
  59         (WebCore::ResourceHandleManager::~ResourceHandleManager):
  60         (WebCore::ResourceHandleManager::self):
  61         (WebCore::ResourceHandleManager::remove):
  62         (WebCore::ResourceHandleManager::add):
  63         (WebCore::ResourceHandleManager::cancel):
  64         (WebCore::ResourceHandleManager::deliverJobData):
  65         * platform/network/qt/ResourceHandleManager.h:
  66         * platform/qt/FrameQtClient.cpp:
  67         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
  68         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
  69         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
  70         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
  71           input dialog functions when compiling without KDE support
  72         (WebCore::ServeSynchronousRequest):
  73
  74 2006-11-02  David Carson  <dacarson@gmail.com>
  75
  76         Reviewed by Geoff, landed by Anders.
  77
  78         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
  79         Initializing variable in constructor.
  80
  81         * page/FramePrivate.h:
  82         (WebCore::FramePrivate::FramePrivate):
  83
  84 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
  85
  86         Reviewed by Geoff.
  87
  88         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
  89
  90         * platform/network/cf/ResourceHandleCFNet.cpp:
  91         (WebCore::addHeadersFromHashMap):
  92         Don't set all headers at once since that clears any previous headers set.
  93
  94         (WebCore::ResourceHandle::start):
  95
  96 2006-11-02  Adele Peterson  <adele@apple.com>
  97
  98         Reviewed by Mitz and Geoff.
  99
 100         - Fix for:
 101         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
 102         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
 103         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
 104
 105         Test: fast/forms/textarea-scrollbar.html
 106
 107         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
 108         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
 109
 110         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
 111         * rendering/RenderTextControl.cpp:
 112         (WebCore::RenderTextControl::RenderTextControl):
 113         (WebCore::RenderTextControl::setStyle):
 114         (WebCore::RenderTextControl::createDivStyle):
 115         (WebCore::RenderTextControl::updateFromElement):
 116         (WebCore::RenderTextControl::calcHeight):
 117         (WebCore::RenderTextControl::baselinePosition):
 118         (WebCore::RenderTextControl::nodeAtPoint):
 119         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
 120         (WebCore::RenderTextControl::scrollWidth):
 121         (WebCore::RenderTextControl::scrollHeight):
 122         (WebCore::RenderTextControl::scrollLeft):
 123         (WebCore::RenderTextControl::scrollTop):
 124
 125         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
 126
 127 2006-11-02  John Sullivan  <sullivan@apple.com>
 128
 129         Reviewed by Geoff Garen
 130
 131         * editing/Selection.cpp:
 132         (WebCore::Selection::showTreeForThis):
 133         this debugging method now displays start offset and end offset, at Darin's suggestion
 134
 135 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
 136
 137         Reviewed by darin
 138
 139         <rdar://problem/4062865>
 140         Copy/paste of a select element fails to include the options
 141
 142         * editing/SelectionController.cpp:
 143         (WebCore::SelectionController::modify): Added paragraphBoundary.
 144         * editing/htmlediting.cpp:
 145         (WebCore::canHaveChildrenForEditing): Added checks for input elements
 146         and textareas.  Insertion operations would fail when performed just
 147         before/after one of these elements b/c the content would be put inside
 148         the element.
 149         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
 150         editable content, and made the code to stop at an root faster (don't check
 151         isDescendantOf on every iteration).
 152         (WebCore::enclosingNodeOfType): Ditto.
 153         (WebCore::enclosingList): Ditto.
 154         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
 155         inappropriately named.
 156         * editing/markup.cpp:
 157         (WebCore::startMarkup): Use the text node's value instead of its rendered
 158         content for text nodes inside select elements.  One might also turn off
 159         annotation when createMarkup enters a select element, but createMarkup
 160         is iterative, not recursive, so doing so would be complicated.
 161         (WebCore::createMarkup): Add markup for unrendered nodes if they are
 162         descendants of a select element.
 163         * editing/visible_units.cpp:
 164         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
 165         where various replaced elements can't be copied when they are the only
 166         thing selected.
 167         (WebCore::endOfParagraph): Ditto.
 168
 169 2006-11-01  Oliver Hunt  <oliver@apple.com>
 170
 171         Reviewed by Adam.
 172
 173         Converting more or kcanvas/quartz from Obj-C to C++
 174         Minor SVG updates
 175         compatibility fixes
 176
 177         * WebCore.xcodeproj/project.pbxproj:
 178         * kcanvas/device/KRenderingPaintServer.h:
 179         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
 180         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
 181         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
 182         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
 183         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
 184         * kcanvas/device/quartz/QuartzSupport.h:
 185         * ksvg2/css/SVGCSSStyleSelector.cpp:
 186         * ksvg2/misc/KCanvasRenderingStyle.h:
 187         * ksvg2/scripts/cssmakeprops:
 188         * ksvg2/scripts/cssmakevalues:
 189         * ksvg2/scripts/make_names.pl:
 190         * ksvg2/svg/SVGAnimateColorElement.cpp:
 191         * ksvg2/svg/SVGAnimateTransformElement.cpp:
 192         * ksvg2/svg/SVGAnimationElement.cpp:
 193         * ksvg2/svg/SVGMaskElement.cpp:
 194         * ksvg2/svg/SVGPatternElement.cpp:
 195         * ksvg2/svg/svgpathparser.cpp:
 196         * platform/Path.cpp:
 197         * platform/graphics/svg/SVGResourceImage.h:
 198         * rendering/RenderPath.cpp:
 199         * rendering/SVGRenderAsText.cpp:
 200
 201 2006-11-02  Mitz Pettel  <mitz@webkit.org>
 202
 203         Reviewed by Adele.
 204
 205         - Fix a regression from r17521: painting of and crash caused by tables
 206           with collapsed borders
 207
 208         * rendering/RenderTable.cpp:
 209         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
 210         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
 211         and 'paintInfo' is the parameter, which we were accidently modifying.
 212
 213 2006-11-01  Adele Peterson  <adele@apple.com>
 214
 215         Reviewed by Mitz.
 216
 217         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
 218         REGRESSION: Incomplete repaint of overflow areas when deleting
 219
 220         Restrict the repaint rect for overflow blocks after the height has been fully computed.
 221         Also, adjust the repaint rect coordinates for the scroll offset.
 222
 223         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
 224         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
 225
 226 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
 227
 228         Reviewed by Mitz.
 229
 230         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
 231         Rename the "p" member variable of the PaintInfo struct to "context"
 232
 233         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
 234           'context' and 'rect' respectively.
 235
 236         - Assorted surrounding cleanups.
 237
 238         * rendering/EllipsisBox.cpp:
 239         (WebCore::EllipsisBox::paint):
 240         * rendering/EllipsisBox.h:
 241         * rendering/InlineBox.cpp:
 242         (WebCore::InlineBox::paint):
 243         * rendering/InlineFlowBox.cpp:
 244         (WebCore::InlineFlowBox::paint):
 245         (WebCore::InlineFlowBox::paintBackground):
 246         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
 247         (WebCore::InlineFlowBox::paintDecorations):
 248         * rendering/InlineFlowBox.h:
 249         * rendering/InlineRunBox.h:
 250         * rendering/InlineTextBox.cpp:
 251         (WebCore::InlineTextBox::paint):
 252         * rendering/InlineTextBox.h:
 253         * rendering/RenderBlock.cpp:
 254         (WebCore::RenderBlock::paint):
 255         (WebCore::RenderBlock::paintChildren):
 256         (WebCore::RenderBlock::paintCaret):
 257         (WebCore::RenderBlock::paintObject):
 258         (WebCore::RenderBlock::paintFloats):
 259         (WebCore::RenderBlock::paintEllipsisBoxes):
 260         (WebCore::RenderBlock::paintSelection):
 261         (WebCore::RenderBlock::fillSelectionGaps):
 262         (WebCore::RenderBlock::fillInlineSelectionGaps):
 263         (WebCore::RenderBlock::fillBlockSelectionGaps):
 264         (WebCore::RenderBlock::fillHorizontalSelectionGap):
 265         (WebCore::RenderBlock::fillVerticalSelectionGap):
 266         (WebCore::RenderBlock::fillLeftSelectionGap):
 267         (WebCore::RenderBlock::fillRightSelectionGap):
 268         * rendering/RenderBox.cpp:
 269         (WebCore::RenderBox::paint):
 270         (WebCore::RenderBox::paintRootBoxDecorations):
 271         (WebCore::RenderBox::paintBoxDecorations):
 272         * rendering/RenderBox.h:
 273         * rendering/RenderButton.cpp:
 274         (WebCore::RenderButton::paintObject):
 275         * rendering/RenderFieldset.cpp:
 276         (WebCore::RenderFieldset::paintBoxDecorations):
 277         * rendering/RenderFileUploadControl.cpp:
 278         (WebCore::RenderFileUploadControl::paintObject):
 279         * rendering/RenderFlow.cpp:
 280         (WebCore::RenderFlow::continuationBefore):
 281         (WebCore::RenderFlow::addChildWithContinuation):
 282         (WebCore::RenderFlow::addChild):
 283         (WebCore::RenderFlow::attachLineBox):
 284         (WebCore::RenderFlow::destroy):
 285         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
 286         (WebCore::RenderFlow::dirtyLineBoxes):
 287         (WebCore::RenderFlow::createInlineBox):
 288         (WebCore::RenderFlow::paintLines):
 289         (WebCore::RenderFlow::getAbsoluteRepaintRect):
 290         (WebCore::RenderFlow::lowestPosition):
 291         (WebCore::RenderFlow::rightmostPosition):
 292         (WebCore::RenderFlow::leftmostPosition):
 293         (WebCore::RenderFlow::caretRect):
 294         (WebCore::RenderFlow::addFocusRingRects):
 295         (WebCore::RenderFlow::paintOutline):
 296         (WebCore::RenderFlow::paintOutlineForLine):
 297         * rendering/RenderForeignObject.cpp:
 298         (WebCore::RenderForeignObject::paint):
 299         * rendering/RenderHTMLCanvas.cpp:
 300         (WebCore::RenderHTMLCanvas::paint):
 301         * rendering/RenderImage.cpp:
 302         (WebCore::RenderImage::paint):
 303         * rendering/RenderLayer.cpp:
 304         (WebCore::RenderLayer::paintLayer):
 305         * rendering/RenderListBox.cpp:
 306         (WebCore::RenderListBox::paintObject):
 307         (WebCore::RenderListBox::paintScrollbar):
 308         (WebCore::RenderListBox::paintItemForeground):
 309         (WebCore::RenderListBox::paintItemBackground):
 310         * rendering/RenderListMarker.cpp:
 311         (WebCore::RenderListMarker::paint):
 312         * rendering/RenderMenuList.cpp:
 313         (WebCore::RenderMenuList::paintObject):
 314         * rendering/RenderObject.cpp:
 315         (WebCore::RenderObject::paint):
 316         * rendering/RenderObject.h:
 317         (WebCore::RenderObject::PaintInfo::PaintInfo):
 318         (WebCore::RenderObject::paintBoxDecorations):
 319         (WebCore::RenderObject::paintingRootForChildren):
 320         (WebCore::RenderObject::shouldPaintWithinRoot):
 321         (WebCore::RenderObject::printBoxDecorations):
 322         * rendering/RenderPath.cpp:
 323         (WebCore::RenderPath::paint):
 324         * rendering/RenderReplaced.cpp:
 325         (WebCore::RenderReplaced::shouldPaint):
 326         * rendering/RenderSVGContainer.cpp:
 327         (WebCore::RenderSVGContainer::paint):
 328         * rendering/RenderSVGContainer.h:
 329         * rendering/RenderSVGImage.cpp:
 330         (WebCore::RenderSVGImage::paint):
 331         * rendering/RenderSVGText.cpp:
 332         (WebCore::RenderSVGText::paint):
 333         * rendering/RenderSVGText.h:
 334         (WebCore::RenderSVGText::renderName):
 335         * rendering/RenderTable.cpp:
 336         (WebCore::RenderTable::paint):
 337         (WebCore::RenderTable::paintBoxDecorations):
 338         * rendering/RenderTable.h:
 339         * rendering/RenderTableCell.cpp:
 340         (WebCore::RenderTableCell::paint):
 341         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
 342         (WebCore::RenderTableCell::paintBoxDecorations):
 343         * rendering/RenderTableCell.h:
 344         * rendering/RenderTableRow.cpp:
 345         (WebCore::RenderTableRow::paint):
 346         * rendering/RenderTableRow.h:
 347         * rendering/RenderTableSection.cpp:
 348         (WebCore::RenderTableSection::paint):
 349         * rendering/RenderTableSection.h:
 350         (WebCore::RenderTableSection::getBaseline):
 351         (WebCore::RenderTableSection::setNeedCellRecalc):
 352         * rendering/RenderText.h:
 353         (WebCore::RenderText::renderName):
 354         (WebCore::RenderText::paint):
 355         (WebCore::RenderText::element):
 356         * rendering/RenderTheme.cpp:
 357         (WebCore::RenderTheme::paint):
 358         (WebCore::RenderTheme::paintBorderOnly):
 359         (WebCore::RenderTheme::paintDecorations):
 360         * rendering/RenderTheme.h:
 361         (WebCore::RenderTheme::RenderTheme):
 362         (WebCore::RenderTheme::~RenderTheme):
 363         (WebCore::RenderTheme::controlSupportsTints):
 364         (WebCore::RenderTheme::adjustRepaintRect):
 365         (WebCore::RenderTheme::themeChanged):
 366         (WebCore::RenderTheme::supportsHover):
 367         (WebCore::RenderTheme::paintCheckbox):
 368         (WebCore::RenderTheme::setCheckboxSize):
 369         (WebCore::RenderTheme::paintRadio):
 370         (WebCore::RenderTheme::setRadioSize):
 371         (WebCore::RenderTheme::paintButton):
 372         (WebCore::RenderTheme::setButtonSize):
 373         (WebCore::RenderTheme::paintTextField):
 374         (WebCore::RenderTheme::paintTextArea):
 375         (WebCore::RenderTheme::paintMenuList):
 376         (WebCore::RenderTheme::paintMenuListButton):
 377         * rendering/RenderThemeMac.mm:
 378         (WebCore::RenderThemeMac::paintCheckbox):
 379         (WebCore::RenderThemeMac::paintRadio):
 380         (WebCore::RenderThemeMac::paintButton):
 381         (WebCore::RenderThemeMac::paintTextField):
 382         (WebCore::RenderThemeMac::paintTextArea):
 383         (WebCore::RenderThemeMac::paintMenuList):
 384         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
 385         (WebCore::RenderThemeMac::paintMenuListButton):
 386         * rendering/RenderView.cpp:
 387         (WebCore::RenderView::paint):
 388         (WebCore::RenderView::paintBoxDecorations):
 389         * rendering/RenderView.h:
 390         * rendering/RenderWidget.cpp:
 391         (WebCore::RenderWidget::paint):
 392         * rendering/RenderWidget.h:
 393         (WebCore::RenderWidget::isWidget):
 394         * rendering/RootInlineBox.cpp:
 395         (WebCore::RootInlineBox::paintEllipsisBox):
 396         (WebCore::RootInlineBox::paintCustomHighlight):
 397         (WebCore::RootInlineBox::paint):
 398         (WebCore::RootInlineBox::fillLineSelectionGap):
 399         * rendering/RootInlineBox.h:
 400         * rendering/SVGInlineFlowBox.cpp:
 401         (WebCore::paintSVGInlineFlow):
 402
 403 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
 404
 405         Reviewed by Oliver, Brady.
 406
 407         * platform/network/ResourceResponse.h:
 408         (WebCore::ResourceResponse::setLastModifiedDate):
 409         (WebCore::ResourceResponse::lastModifiedDate):
 410         Add getters and setters for last modified dadte.
 411
 412         * platform/network/cf/ResourceResponseCFNet.cpp:
 413         (WebCore::getResourceResponse):
 414         Fetch the last modified date. Add correct offset to expired date.
 415
 416 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
 417
 418         Reviewed by Mitz.
 419
 420         Added missing "break;" statement in switch statement from r17493.
 421
 422         Bug 11442: [CSS 3] support for cursor: all-scroll
 423         http://bugs.webkit.org/show_bug.cgi?id=11442
 424
 425         * css/CSSComputedStyleDeclaration.cpp:
 426         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
 427
 428 2006-10-31  Mitz Pettel  <mitz@webkit.org>
 429
 430         Reviewed by Maciej.
 431
 432         - fix image dragging
 433
 434         This is covered by editing/selection/drag-to-contenteditable-iframe.html
 435
 436         * rendering/HitTestResult.cpp:
 437         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
 438         HTML IMG elements.
 439         (WebCore::HitTestResult::absoluteImageURL): Ditto.
 440
 441 2006-10-31  Beth Dakin  <bdakin@apple.com>
 442
 443         Reviewed by Maciej.
 444
 445         This adds the back-end of the remaining WebElementDictionary
 446         functions into HitTestResult.
 447
 448         * WebCore.exp:
 449         * rendering/HitTestResult.cpp:
 450         (WebCore::HitTestResult::title):
 451         (WebCore::displayString): This is nearly identical to the
 452         displayString() defined in DOMInternal.mm except that it returns a
 453         String instead of an NSString. The old code path used the
 454         DOMInternal method, so I made a new one here for the new code path.
 455         (WebCore::HitTestResult::altDisplayString):
 456         (WebCore::HitTestResult::image):
 457         (WebCore::HitTestResult::absoluteImageURL):
 458         (WebCore::HitTestResult::absoluteLinkURL):
 459         (WebCore::HitTestResult::titleDisplayString):
 460         (WebCore::HitTestResult::textContent):
 461         * rendering/HitTestResult.h:
 462
 463 2006-10-31  John Sullivan  <sullivan@apple.com>
 464
 465         * bridge/mac/FrameMac.mm:
 466         (WebCore::FrameMac::markMisspellings):
 467         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
 468
 469 2006-10-31  John Sullivan  <sullivan@apple.com>
 470
 471         Reviewed by Maciej
 472
 473         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
 474
 475         The foundation of this was in my last checkin. This checkin is all about displaying
 476         the correct string in the toolTip.
 477
 478         * dom/DocumentMarker.h:
 479         New description field in this struct.
 480
 481         * bridge/mac/FrameMac.mm:
 482         (WebCore::FrameMac::advanceToNextMisspelling):
 483         When adding a grammar marker, supply the appropriate description. Also, added a comment
 484         about the remaining work to make grammar checking return sensible answers.
 485         (WebCore::FrameMac::markMisspellings):
 486         ditto (yes, still needs some refactoring to minimize duplicated code)
 487
 488         * dom/Document.h:
 489         * dom/Document.cpp:
 490         (WebCore::Document::addMarker):
 491         Now takes an optional description string
 492         (WebCore::Document::markerContainingPoint):
 493         New function, returns a pointer to the (first) marker of the specified type whose rect
 494         contains the specified point, or 0 if none.
 495
 496         * rendering/HitTestResult.cpp:
 497         (WebCore::HitTestResult::spellingToolTip):
 498         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
 499         and gets the description from the marker.
 500
 501 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
 502
 503         Reviewed by Maciej.
 504
 505         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
 506
 507         * loader/mac/FrameLoaderMac.mm:
 508         (WebCore::FrameLoader::createWindow):
 509         * manual-tests/window-open-features-parsing.html: Updated for clarity.
 510
 511 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
 512
 513         Reviewed by Alice.
 514
 515         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
 516         to WebCore::Editor.
 517
 518         Layout tests pass.
 519
 520         Renamed "may*" to "can*" because "can" is more accurate (these functions
 521         aren't just about permission) and it matches WebKit.
 522
 523         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a
 524         password field. Now that WebCore fully implements canCopy(), it doesn't just
 525         mean "the selection is not in a password field" anymore.
 526         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code.
 527         The fact that it's not called anymore may represent a security issue, but I
 528         don't see how commented-out code will help reveal the issue, and the
 529         bridge is going away, anyway.
 530         * editing/SelectionController.h: Changed selection() calls to references
 531         to m_sel, to match the rest of the file.
 532
 533 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
 534
 535         Reviewed by harrison
 536
 537         <rdar://problem/4711063>
 538         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
 539
 540         * editing/ReplaceSelectionCommand.cpp:
 541         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
 542         insertion and plain text string creation unless we need the string
 543         for a BeforeTextInserted event handler or for a plain text only region.
 544         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
 545         code here from ReplacementFragment's constructor.
 546         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
 547         FIXME.
 548         * editing/ReplaceSelectionCommand.h:
 549
 550 2006-10-31  Ada Chan  <adachan@apple.com>
 551
 552         Reviewed by Adam
 553
 554         Correct forward declarations of the HitTestRequest struct.
 555
 556         * rendering/EllipsisBox.h:
 557         * rendering/InlineBox.h:
 558         * rendering/InlineFlowBox.h:
 559         * rendering/RenderLayer.h:
 560         * rendering/RenderObject.h:
 561
 562 2006-10-31  John Sullivan  <sullivan@apple.com>
 563
 564         Reviewed by Beth and Adam
 565
 566         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip;
 567         next I'll make it use a string that's relevant for a specific grammar error.
 568
 569         * WebCore.exp:
 570         export symbol for spellingToolTip function
 571
 572         * rendering/HitTestResult.h:
 573         * rendering/HitTestResult.cpp:
 574         (WebCore::HitTestResult::spellingToolTip):
 575         new function, returns the string to be used in a tool tip that describes the questionable grammar
 576
 577         * rendering/InlineTextBox.h:
 578         * rendering/InlineTextBox.cpp:
 579         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
 580         now takes a style and font, needed to compute the rect representing the range containing
 581         questionable grammar. Computes the rect and associates it with the marker.
 582         (WebCore::InlineTextBox::paintDocumentMarkers):
 583         Pass in the style and font now needed by paintSpellingOrGrammarMarker
 584
 585 2006-10-31  Adele Peterson  <adele@apple.com>
 586
 587         Removed commented out variable from last checkin.
 588
 589         * html/HTMLSelectElement.cpp:
 590         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
 591
 592 2006-10-31  Brady Eidson  <beidson@apple.com>
 593
 594         Build fix (unused variable in release builds)
 595
 596         * html/HTMLSelectElement.cpp:
 597         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
 598
 599 2006-10-31  Adele Peterson  <adele@apple.com>
 600
 601         Reviewed by Adam.
 602
 603         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
 604         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
 605         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
 606
 607         Tests:
 608         * LayoutTests/fast/forms/listbox-selection.html
 609         * LayoutTests/fast/forms/listbox-onchange.html
 610
 611         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
 612           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
 613           And one for onChange, that is updated after onChange is fired.
 614           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
 615
 616         * html/HTMLSelectElement.cpp:
 617         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
 618         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
 619         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
 620         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
 621         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
 622         (WebCore::HTMLSelectElement::setExtent): Added.
 623         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
 624         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
 625
 626         * rendering/RenderListBox.cpp:
 627         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
 628         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
 629         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
 630         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
 631          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
 632          notify the select element from here.
 633         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
 634         (WebCore::RenderListBox::listIndexIsVisible): Added.
 635         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
 636
 637         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction,
 638         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
 639         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
 640         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
 641         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
 642
 643 2006-10-31  Beth Dakin  <bdakin@apple.com>
 644
 645         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
 646
 647         * rendering/HitTestRequest.h: Added.
 648         (WebCore::HitTestRequest::HitTestRequest):
 649
 650 2006-10-31  Beth Dakin  <bdakin@apple.com>
 651
 652         Reviewed by Maciej.
 653
 654         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult
 655         should be split into HitTestRequest and HitTestResult
 656
 657         This patch creates a new struct called HitTestRequest that holds
 658         the three boolean values (readonly, active, and mouseMove) that
 659         were formerly a part of HitTestResult. All hitTest() and
 660         nodeAtPoint() functions now take a HitTestRequest in addition to
 661         the HitTestResult.
 662
 663         * WebCore.exp:
 664         * WebCore.xcodeproj/project.pbxproj:
 665         * bridge/mac/FrameMac.mm:
 666         (WebCore::FrameMac::eventMayStartDrag):
 667         (WebCore::FrameMac::handleMouseMoveEvent):
 668         * bridge/mac/WebCoreAXObject.mm:
 669         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
 670         (-[WebCoreAXObject accessibilityHitTest:]):
 671         * dom/Document.cpp:
 672         (WebCore::Document::elementFromPoint):
 673         (WebCore::Document::prepareMouseEvent):
 674         * editing/SelectionController.cpp:
 675         (WebCore::SelectionController::contains):
 676         * page/Frame.cpp:
 677         (WebCore::Frame::hitTestResultAtPoint):
 678         * page/FrameView.cpp:
 679         (WebCore::FrameView::handleWheelEvent):
 680         * rendering/EllipsisBox.cpp:
 681         (WebCore::EllipsisBox::nodeAtPoint):
 682         * rendering/EllipsisBox.h:
 683         * rendering/HitTestResult.cpp:
 684         (WebCore::HitTestResult::HitTestResult):
 685         (WebCore::HitTestResult::operator=):
 686         * rendering/HitTestResult.h:
 687         * rendering/InlineBox.cpp:
 688         (WebCore::InlineBox::nodeAtPoint):
 689         * rendering/InlineBox.h:
 690         * rendering/InlineFlowBox.cpp:
 691         (WebCore::InlineFlowBox::nodeAtPoint):
 692         * rendering/InlineFlowBox.h:
 693         * rendering/InlineTextBox.cpp:
 694         (WebCore::InlineTextBox::nodeAtPoint):
 695         * rendering/InlineTextBox.h:
 696         * rendering/RenderBlock.cpp:
 697         (WebCore::RenderBlock::nodeAtPoint):
 698         * rendering/RenderBlock.h:
 699         * rendering/RenderBox.cpp:
 700         (WebCore::RenderBox::nodeAtPoint):
 701         * rendering/RenderBox.h:
 702         * rendering/RenderFlow.cpp:
 703         (WebCore::RenderFlow::hitTestLines):
 704         * rendering/RenderFlow.h:
 705         * rendering/RenderForeignObject.cpp:
 706         (WebCore::RenderForeignObject::nodeAtPoint):
 707         * rendering/RenderForeignObject.h:
 708         * rendering/RenderFrameSet.cpp:
 709         (WebCore::RenderFrameSet::nodeAtPoint):
 710         * rendering/RenderFrameSet.h:
 711         * rendering/RenderImage.cpp:
 712         (WebCore::RenderImage::nodeAtPoint):
 713         * rendering/RenderImage.h:
 714         * rendering/RenderInline.cpp:
 715         (WebCore::RenderInline::nodeAtPoint):
 716         * rendering/RenderInline.h:
 717         * rendering/RenderLayer.cpp:
 718         (WebCore::RenderLayer::autoscroll):
 719         (WebCore::RenderLayer::hitTest):
 720         (WebCore::RenderLayer::hitTestLayer):
 721         (WebCore::RenderLayer::updateHoverActiveState):
 722         * rendering/RenderLayer.h:
 723         * rendering/RenderObject.cpp:
 724         (WebCore::RenderObject::hitTest):
 725         (WebCore::RenderObject::nodeAtPoint):
 726         * rendering/RenderObject.h:
 727         * rendering/RenderPath.cpp:
 728         (WebCore::RenderPath::nodeAtPoint):
 729         * rendering/RenderPath.h:
 730         * rendering/RenderSVGImage.cpp:
 731         (WebCore::RenderSVGImage::nodeAtPoint):
 732         * rendering/RenderSVGImage.h:
 733         * rendering/RenderSVGText.cpp:
 734         (WebCore::RenderSVGText::nodeAtPoint):
 735         * rendering/RenderSVGText.h:
 736         * rendering/RenderTableRow.cpp:
 737         (WebCore::RenderTableRow::nodeAtPoint):
 738         * rendering/RenderTableRow.h:
 739         * rendering/RenderTableSection.cpp:
 740         (WebCore::RenderTableSection::nodeAtPoint):
 741         * rendering/RenderTableSection.h:
 742         * rendering/RenderText.h:
 743         (WebCore::RenderText::nodeAtPoint):
 744         * rendering/RenderTextControl.cpp:
 745         (WebCore::RenderTextControl::nodeAtPoint):
 746         * rendering/RenderTextControl.h:
 747         * rendering/RootInlineBox.cpp:
 748         (WebCore::RootInlineBox::nodeAtPoint):
 749         * rendering/RootInlineBox.h:
 750
 751 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
 752
 753         Reviewed by Maciej.
 754
 755         Bug 11442: [CSS 3] support for cursor: all-scroll
 756         http://bugs.webkit.org/show_bug.cgi?id=11442
 757
 758         * css/CSSComputedStyleDeclaration.cpp:
 759         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
 760         * css/CSSValueKeywords.in:
 761         * css/cssparser.cpp:
 762         (WebCore::CSSParser::parseValue):
 763         * page/FrameView.cpp:
 764         (WebCore::selectCursor):
 765         * rendering/RenderStyle.h:
 766
 767 2006-10-31  Oliver Hunt  <oliver@apple.com>
 768
 769         Reviewed by Geoff.
 770
 771         Converting Obj-C++ to C++ in kcanvas
 772
 773         * WebCore.xcodeproj/project.pbxproj:
 774         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
 775         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
 776         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
 777         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
 778         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
 779         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
 780         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
 781         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
 782         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
 783         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
 784         * kcanvas/device/quartz/QuartzSupport.h:
 785         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
 786         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
 787         (WebCore::SVGResourceClipper::applyClip):
 788         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
 789         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
 790         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
 791
 792 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
 793
 794         Reviewed by harrison
 795
 796         <rdar://problem/4808375>
 797         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
 798
 799         Completely back out r17276 because of performance issues.
 800
 801         * editing/TextIterator.cpp:
 802         (WebCore::TextIterator::TextIterator):
 803         (WebCore::TextIterator::advance):
 804         (WebCore::TextIterator::handleTextNode):
 805         (WebCore::TextIterator::handleTextBox):
 806         (WebCore::TextIterator::handleReplacedElement):
 807         (WebCore::TextIterator::handleNonTextNode):
 808         (WebCore::TextIterator::exitNode):
 809         (WebCore::TextIterator::emitCharacter):
 810         (WebCore::TextIterator::range):
 811         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
 812         (WebCore::SimplifiedBackwardsTextIterator::advance):
 813         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
 814         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
 815         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
 816         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
 817         (WebCore::SimplifiedBackwardsTextIterator::range):
 818         (WebCore::CharacterIterator::range):
 819         (WebCore::TextIterator::rangeFromLocationAndLength):
 820         * editing/TextIterator.h:
 821         (WebCore::TextIterator::atEnd):
 822         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
 823
 824 2006-10-31  Darin Adler  <darin@apple.com>
 825
 826         Reviewed by Brady.
 827
 828         - got "action dictionary" code out of FrameLoader,
 829           replacing with a class called NavigationAction
 830
 831         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
 832         * loader/mac/DocumentLoaderMac.mm:
 833         (WebCore::DocumentLoader::triggeringAction): Ditto.
 834         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
 835
 836         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
 837
 838         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
 839         Removed elementForEvent.
 840         * loader/mac/FrameLoaderMac.mm:
 841         (WebCore::FrameLoader::load): Ditto.
 842         (WebCore::FrameLoader::reload): Ditto.
 843         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
 844         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
 845         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
 846         (WebCore::FrameLoader::post): Ditto.
 847
 848         * loader/NavigationAction.h: Added.
 849         * loader/NavigationAction.cpp: Added.
 850         * loader/mac/NavigationActionMac.mm: Added.
 851
 852         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
 853
 854         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
 855         * WebCore.exp: Updated.
 856
 857 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
 858
 859         Reviewed by Adam.
 860
 861         Build fix
 862
 863         * platform/win/CookieJarWin.cpp:
 864         (WebCore::cookies):
 865
 866 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
 867
 868         Reviewed by Maciej. Landed by Adam.
 869
 870         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
 871
 872         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
 873         as dicussed with Dave. Also kill the outdated DESIGN document.
 874
 875         * CMakeLists.txt:
 876         * WebCore.xcodeproj/project.pbxproj:
 877         * kcanvas/DESIGN: Removed.
 878         * kcanvas/KCanvasFilters.cpp:
 879         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
 880         * kcanvas/KCanvasTreeDebug.h: Ditto.
 881         * kcanvas/device/KRenderingPaintServerGradient.cpp:
 882         * kcanvas/device/KRenderingPaintServerPattern.cpp:
 883         * kcanvas/device/KRenderingPaintServerSolid.cpp:
 884         * platform/graphics/svg/SVGResourceClipper.cpp:
 885         * rendering/RenderTreeAsText.cpp:
 886         * rendering/SVGRenderTreeAsText.cpp: Added.
 887         * rendering/SVGRenderTreeAsText.h: Added.
 888         (WebCore::operator<<):
 889
 890 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
 891
 892         Reviewed by Maciej.
 893
 894         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
 895         Includes some CRLF -> LF fixups.
 896
 897         * platform/win/CookieJarWin.cpp:
 898         (WebCore::cookies):
 899
 900 2006-10-31  Adam Roben  <aroben@apple.com>
 901
 902         Reviewed by Steve.
 903
 904         Fix some incorrect forward declarations.
 905
 906         * loader/FrameLoader.h:
 907         * page/Frame.h:
 908
 909 2006-10-31  Darin Adler  <darin@apple.com>
 910
 911         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
 912         try to fix the build on the buildbot.
 913
 914 2006-10-31  Darin Adler  <darin@apple.com>
 915
 916         * bridge/mac/FrameMac.mm:
 917         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
 918         (WebCore::FrameMac::markMisspellings): Ditto.
 919
 920 2006-10-31  John Sullivan  <sullivan@apple.com>
 921
 922         * bridge/mac/FrameMac.mm:
 923         (WebCore::FrameMac::advanceToNextMisspelling):
 924         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
 925
 926 2006-10-30  John Sullivan  <sullivan@apple.com>
 927
 928         Reviewed by Adam Roben
 929
 930         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
 931
 932         This patch introduces much of the guts of grammar checking, though still not enough to actually
 933         check grammar sensibly, due to:
 934
 935         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient
 936         context passed to grammar checker
 937
 938         * platform/Logging.h:
 939         * platform/Logging.cpp:
 940         new log channel SpellingAndGrammar
 941
 942         * bridge/mac/WebCorePageBridge.mm:
 943         (initializeLoggingChannelsIfNecessary):
 944         initialize new log channel
 945
 946         * bridge/mac/FrameMac.mm:
 947         (WebCore::FrameMac::advanceToNextMisspelling):
 948         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
 949         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
 950         in the event of a tie), and do further processing with that one (select range; create marker that
 951         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
 952         (WebCore::FrameMac::markMisspellings):
 953         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just
 954         differently enough to make sharing code between these two functions a little tricky, so I decided to
 955         save that for a later patch.
 956
 957         (WebCore::FrameMac::respondToChangedSelection):
 958         remove grammar markers when we remove spelling markers
 959
 960 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
 961
 962         Reviewed by Mitz.
 963
 964         Fix Qt/Linux build with older gcc3.3.4.
 965
 966         * bindings/js/kjs_window.cpp:
 967         (KJS::WindowFunc::callAsFunction):
 968
 969 2006-10-31  Zack Rusin  <zack@kde.org>
 970
 971         Reviewed by Mitz.
 972
 973         Fix the Qt build after last nights changes.
 974
 975         * WebCore/platform/qt/FrameQt.cpp:
 976         * WebCore/platform/qt/EditorClientQt.h:
 977         * WebCore/platform/qt/EditorClientQt.cpp:
 978         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
 979         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
 980         * WebCore/CMakeLists.txt:
 981         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
 982         * WebKitQt/QtLauncher/CMakeLists.txt:
 983         * WebKitQt/WebKitPart/CMakeLists.txt:
 984
 985 2006-10-30  Darin Adler  <darin@apple.com>
 986
 987         Reviewed by Anders.
 988
 989         - remove BrowserExtension
 990
 991         * WebCore.vcproj/WebCore/WebCore.vcproj:
 992         * WebCore.xcodeproj/project.pbxproj:
 993         * bindings/js/kjs_window.cpp:
 994         (KJS::createNewWindow):
 995         (KJS::WindowFunc::callAsFunction):
 996         * bridge/BrowserExtension.h: Removed.
 997         * bridge/mac/BrowserExtensionMac.h: Removed.
 998         * bridge/mac/BrowserExtensionMac.mm: Removed.
 999         * bridge/mac/FrameMac.mm:
1000         (WebCore::FrameMac::FrameMac):
1001         (WebCore::FrameMac::submitForm):
1002         (WebCore::FrameMac::urlSelected):
1003         * bridge/win/BrowserExtensionWin.cpp: Removed.
1004         * bridge/win/BrowserExtensionWin.h: Removed.
1005         * bridge/win/FrameWin.cpp:
1006         (WebCore::FrameWin::FrameWin):
1007         * loader/FrameLoader.cpp:
1008         (WebCore::FrameLoader::createWindow):
1009         * loader/FrameLoader.h:
1010         * loader/icon/IconLoader.cpp:
1011         * loader/mac/FrameLoaderMac.mm:
1012         (WebCore::FrameLoader::safeLoad):
1013         (WebCore::FrameLoader::load):
1014         (WebCore::FrameLoader::createWindow):
1015         * page/Frame.cpp:
1016         (WebCore::Frame::urlSelected):
1017         (WebCore::Frame::requestFrame):
1018         (WebCore::Frame::submitForm):
1019         (WebCore::Frame::scheduleHistoryNavigation):
1020         (WebCore::Frame::redirectionTimerFired):
1021         * page/Frame.h:
1022         * page/FrameLoadRequest.h:
1023         (WebCore::FrameLoadRequest::FrameLoadRequest):
1024         (WebCore::FrameLoadRequest::isEmpty):
1025         (WebCore::FrameLoadRequest::resourceRequest):
1026         (WebCore::FrameLoadRequest::frameName):
1027         (WebCore::FrameLoadRequest::setFrameName):
1028         * page/FramePrivate.h:
1029         (WebCore::FramePrivate::FramePrivate):
1030         (WebCore::FramePrivate::~FramePrivate):
1031         * platform/gdk/BrowserExtensionGdk.h: Removed.
1032         * platform/gdk/FrameGdk.cpp:
1033         (WebCore::FrameGdk::FrameGdk):
1034         * platform/gdk/TemporaryLinkStubs.cpp:
1035         * platform/network/ResourceRequest.h:
1036         (WebCore::ResourceRequest::isEmpty):
1037
1038 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
1039
1040         Reviewed by Oliver.
1041
1042         Modified from original due to earlier reversion
1043
1044         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
1045
1046         Better SVG integration in WebKit, Part I.
1047
1048         The patch is mostly about creating a new platform/graphics directory, and
1049         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
1050         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
1051         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
1052
1053         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
1054         All details of the patch, and upcoming patches can be found in the bug report.
1055
1056         * CMakeLists.txt:
1057         * WebCore.xcodeproj/project.pbxproj:
1058         * graphics/svg/SVGResource.cpp: Removed.
1059         * graphics/svg/SVGResourceClipper.cpp: Removed.
1060         * graphics/svg/SVGResourceClipper.h: Removed.
1061         * graphics/svg/SVGResourceImage.h: Removed.
1062         * graphics/svg/SVGResourceListener.h: Removed.
1063         * graphics/svg/SVGResourceMarker.cpp: Removed.
1064         * graphics/svg/SVGResourceMarker.h: Removed.
1065         * graphics/svg/SVGResourceMasker.cpp: Removed.
1066         * graphics/svg/SVGResourceMasker.h: Removed.
1067         * kcanvas/KCanvasClipper.cpp: Removed.
1068         * kcanvas/KCanvasClipper.h: Removed.
1069         * kcanvas/KCanvasCreator.cpp: Removed.
1070         * kcanvas/KCanvasCreator.h: Removed.
1071         * kcanvas/KCanvasFilters.cpp:
1072         (WebCore::getFilterById):
1073         * kcanvas/KCanvasFilters.h:
1074         * kcanvas/KCanvasImage.h: Removed.
1075         * kcanvas/KCanvasMarker.cpp: Removed.
1076         * kcanvas/KCanvasMarker.h: Removed.
1077         * kcanvas/KCanvasMasker.cpp: Removed.
1078         * kcanvas/KCanvasMasker.h: Removed.
1079         * kcanvas/KCanvasResource.cpp: Removed.
1080         * kcanvas/KCanvasResource.h: Removed.
1081         * kcanvas/KCanvasResourceListener.h: Removed.
1082         * kcanvas/KCanvasTreeDebug.cpp:
1083         (WebCore::writeRenderResources):
1084         * kcanvas/device/KRenderingDevice.h:
1085         * kcanvas/device/KRenderingPaintServer.h:
1086         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1087         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1088         (WebCore::KRenderingPaintServerGradient::listener):
1089         (WebCore::KRenderingPaintServerGradient::setListener):
1090         * kcanvas/device/KRenderingPaintServerGradient.h:
1091         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1092         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1093         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1094         (WebCore::KRenderingPaintServerPattern::tile):
1095         (WebCore::KRenderingPaintServerPattern::setTile):
1096         (WebCore::KRenderingPaintServerPattern::listener):
1097         (WebCore::KRenderingPaintServerPattern::setListener):
1098         * kcanvas/device/KRenderingPaintServerPattern.h:
1099         * kcanvas/device/KRenderingPaintServerSolid.h:
1100         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
1101         * kcanvas/device/qt/KCanvasClipperQt.h:
1102         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1103         (WebCore::KRenderingDeviceQt::contextForImage):
1104         (WebCore::KRenderingDeviceQt::createResource):
1105         (WebCore::KRenderingDeviceQt::createPaintServer):
1106         * kcanvas/device/qt/KRenderingDeviceQt.h:
1107         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1108         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1109         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1110         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1111         * kcanvas/device/qt/RenderPathQt.h: Removed.
1112         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1113         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1114         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1115         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
1116         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
1117         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
1118         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
1119         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1120         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1121         (WebCore::KRenderingDeviceQuartz::contextForImage):
1122         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1123         (WebCore::KRenderingDeviceQuartz::createResource):
1124         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1125         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1126         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1127         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1128         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1129         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1130         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1131         (WebCore::patternCallback):
1132         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1133         * kcanvas/device/quartz/QuartzSupport.mm:
1134         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1135         (WebCore::sharedSolidPaintServer):
1136         * ksvg2/svg/SVGClipPathElement.cpp:
1137         (WebCore::SVGClipPathElement::SVGClipPathElement):
1138         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1139         (WebCore::SVGClipPathElement::canvasResource):
1140         * ksvg2/svg/SVGClipPathElement.h:
1141         * ksvg2/svg/SVGFEImageElement.cpp:
1142         * ksvg2/svg/SVGFilterElement.cpp:
1143         (WebCore::SVGFilterElement::SVGFilterElement):
1144         (WebCore::SVGFilterElement::~SVGFilterElement):
1145         (WebCore::SVGFilterElement::canvasResource):
1146         * ksvg2/svg/SVGFilterElement.h:
1147         * ksvg2/svg/SVGGradientElement.cpp:
1148         (WebCore::SVGGradientElement::SVGGradientElement):
1149         (WebCore::SVGGradientElement::~SVGGradientElement):
1150         (WebCore::SVGGradientElement::canvasResource):
1151         (WebCore::SVGGradientElement::resourceNotification):
1152         * ksvg2/svg/SVGGradientElement.h:
1153         * ksvg2/svg/SVGImageElement.cpp:
1154         * ksvg2/svg/SVGLinearGradientElement.cpp:
1155         (WebCore::SVGLinearGradientElement::buildGradient):
1156         * ksvg2/svg/SVGLinearGradientElement.h:
1157         * ksvg2/svg/SVGMarkerElement.cpp:
1158         (WebCore::SVGMarkerElement::SVGMarkerElement):
1159         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1160         (WebCore::SVGMarkerElement::canvasResource):
1161         * ksvg2/svg/SVGMarkerElement.h:
1162         * ksvg2/svg/SVGMaskElement.cpp:
1163         (WebCore::SVGMaskElement::SVGMaskElement):
1164         (WebCore::SVGMaskElement::~SVGMaskElement):
1165         (WebCore::SVGMaskElement::drawMaskerContent):
1166         (WebCore::SVGMaskElement::canvasResource):
1167         * ksvg2/svg/SVGMaskElement.h:
1168         * ksvg2/svg/SVGPatternElement.cpp:
1169         (WebCore::SVGPatternElement::SVGPatternElement):
1170         (WebCore::SVGPatternElement::~SVGPatternElement):
1171         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1172         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1173         (WebCore::SVGPatternElement::canvasResource):
1174         * ksvg2/svg/SVGPatternElement.h:
1175         * ksvg2/svg/SVGRadialGradientElement.cpp:
1176         (WebCore::SVGRadialGradientElement::buildGradient):
1177         * ksvg2/svg/SVGRadialGradientElement.h:
1178         * ksvg2/svg/SVGStyledElement.h:
1179         (WebCore::SVGStyledElement::canvasResource):
1180         * platform/GraphicsContext.cpp: Removed.
1181         * platform/GraphicsContext.h: Removed.
1182         * platform/GraphicsTypes.cpp: Removed.
1183         * platform/GraphicsTypes.h: Removed.
1184         * platform/graphics/GraphicsContext.cpp:
1185         (WebCore::GraphicsContextState::GraphicsContextState):
1186         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1187         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1188         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1189         (WebCore::GraphicsContext::save):
1190         (WebCore::GraphicsContext::restore):
1191         (WebCore::GraphicsContext::font):
1192         (WebCore::GraphicsContext::setFont):
1193         (WebCore::GraphicsContext::pen):
1194         (WebCore::GraphicsContext::setPen):
1195         (WebCore::GraphicsContext::setFillColor):
1196         (WebCore::GraphicsContext::fillColor):
1197         (WebCore::GraphicsContext::updatingControlTints):
1198         (WebCore::GraphicsContext::setUpdatingControlTints):
1199         (WebCore::GraphicsContext::setPaintingDisabled):
1200         (WebCore::GraphicsContext::paintingDisabled):
1201         (WebCore::GraphicsContext::drawImage):
1202         (WebCore::GraphicsContext::drawText):
1203         (WebCore::GraphicsContext::drawHighlightForText):
1204         (WebCore::GraphicsContext::initFocusRing):
1205         (WebCore::GraphicsContext::clearFocusRing):
1206         (WebCore::GraphicsContext::focusRingBoundingRect):
1207         (WebCore::GraphicsContext::addFocusRingRect):
1208         (WebCore::GraphicsContext::focusRingWidth):
1209         (WebCore::GraphicsContext::focusRingOffset):
1210         (WebCore::GraphicsContext::focusRingRects):
1211         (WebCore::GraphicsContext::drawTiledImage):
1212         * platform/graphics/GraphicsContext.h:
1213         * platform/graphics/GraphicsTypes.cpp:
1214         (WebCore::):
1215         (WebCore::parseCompositeOperator):
1216         (WebCore::compositeOperatorName):
1217         (WebCore::parseLineCap):
1218         (WebCore::lineCapName):
1219         (WebCore::parseLineJoin):
1220         (WebCore::lineJoinName):
1221         * platform/graphics/GraphicsTypes.h:
1222         (WebCore::):
1223         * platform/graphics/svg/SVGResource.cpp: Added.
1224         (WebCore::SVGResource::SVGResource):
1225         (WebCore::SVGResource::~SVGResource):
1226         (WebCore::SVGResource::invalidate):
1227         (WebCore::SVGResource::addClient):
1228         (WebCore::SVGResource::clients):
1229         (WebCore::SVGResource::idInRegistry):
1230         (WebCore::SVGResource::setIdInRegistry):
1231         (WebCore::SVGResource::externalRepresentation):
1232         (WebCore::getResourceById):
1233         (WebCore::getPaintServerById):
1234         (WebCore::operator<<):
1235         * platform/graphics/svg/SVGResource.h: Added.
1236         (WebCore::):
1237         (WebCore::SVGResource::isPaintServer):
1238         (WebCore::SVGResource::isFilter):
1239         (WebCore::SVGResource::isClipper):
1240         (WebCore::SVGResource::isMarker):
1241         (WebCore::SVGResource::isMasker):
1242         (WebCore::SVGResourceListener::~SVGResourceListener):
1243         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
1244         (WebCore::SVGResourceClipper::SVGResourceClipper):
1245         (WebCore::SVGResourceClipper::~SVGResourceClipper):
1246         (WebCore::SVGResourceClipper::resetClipData):
1247         (WebCore::SVGResourceClipper::addClipData):
1248         (WebCore::SVGResourceClipper::clipData):
1249         (WebCore::SVGResourceClipper::externalRepresentation):
1250         (WebCore::operator<<):
1251         (WebCore::getClipperById):
1252         * platform/graphics/svg/SVGResourceClipper.h: Added.
1253         (WebCore::ClipDataList::addPath):
1254         (WebCore::SVGResourceClipper::isClipper):
1255         * platform/graphics/svg/SVGResourceImage.h: Added.
1256         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
1257         (WebCore::SVGResourceMarker::SVGResourceMarker):
1258         (WebCore::SVGResourceMarker::~SVGResourceMarker):
1259         (WebCore::SVGResourceMarker::setMarker):
1260         (WebCore::SVGResourceMarker::setRef):
1261         (WebCore::SVGResourceMarker::draw):
1262         (WebCore::SVGResourceMarker::externalRepresentation):
1263         (WebCore::getMarkerById):
1264         * platform/graphics/svg/SVGResourceMarker.h: Added.
1265         (WebCore::SVGResourceMarker::refX):
1266         (WebCore::SVGResourceMarker::refY):
1267         (WebCore::SVGResourceMarker::setAngle):
1268         (WebCore::SVGResourceMarker::setAutoAngle):
1269         (WebCore::SVGResourceMarker::angle):
1270         (WebCore::SVGResourceMarker::setUseStrokeWidth):
1271         (WebCore::SVGResourceMarker::useStrokeWidth):
1272         (WebCore::SVGResourceMarker::isMarker):
1273         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
1274         (WebCore::SVGResourceMasker::SVGResourceMasker):
1275         (WebCore::SVGResourceMasker::~SVGResourceMasker):
1276         (WebCore::SVGResourceMasker::setMask):
1277         (WebCore::SVGResourceMasker::mask):
1278         (WebCore::SVGResourceMasker::externalRepresentation):
1279         (WebCore::getMaskerById):
1280         * platform/graphics/svg/SVGResourceMasker.h: Added.
1281         (WebCore::SVGResourceMasker::isMasker):
1282         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
1283         (WebCore::SVGResourceClipper::applyClip):
1284         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
1285         (WebCore::SVGResourceImage::SVGResourceImage):
1286         (WebCore::SVGResourceImage::~SVGResourceImage):
1287         (WebCore::SVGResourceImage::init):
1288         (WebCore::SVGResourceImage::size):
1289         (WebCore::SVGResourceImage::cgLayer):
1290         (WebCore::SVGResourceImage::setCGLayer):
1291         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
1292         (WebCore::applyLuminanceToAlphaFilter):
1293         (WebCore::applyExpandAlphatoGrayscaleFilter):
1294         (WebCore::transformImageIntoGrayscaleMask):
1295         (WebCore::SVGResourceMasker::applyMask):
1296         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
1297         (WebCore::SVGResourceClipper::applyClip):
1298         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
1299         (WebCore::SVGResourceImage::init):
1300         (WebCore::SVGResourceImage::size):
1301         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
1302         (WebCore::SVGResourceMasker::applyMask):
1303         * platform/qt/GraphicsContextQt.cpp:
1304         * rendering/RenderPath.cpp:
1305         (WebCore::RenderPath::paint):
1306         (WebCore::DrawMarkersData::DrawMarkersData):
1307         (WebCore::RenderPath::drawMarkersIfNeeded):
1308         * rendering/RenderSVGContainer.cpp:
1309         (WebCore::RenderSVGContainer::paint):
1310         * rendering/RenderSVGImage.cpp:
1311         (WebCore::RenderSVGImage::paint):
1312         * rendering/SVGInlineFlowBox.cpp:
1313         (WebCore::paintSVGInlineFlow):
1314
1315 2006-10-30  John Sullivan  <sullivan@apple.com>
1316
1317         Reviewed by Brady
1318
1319         - minor cleanup to make future patches clearer
1320
1321         * bridge/mac/FrameMac.mm:
1322         (WebCore::FrameMac::advanceToNextMisspelling):
1323         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
1324         with "continue" to better match structure of similar code in markMisspellings; a few
1325         other style tweaks.
1326
1327         (WebCore::FrameMac::markMisspellings):
1328         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
1329         a block just after a break and outdented accordingly.
1330
1331 2006-10-30  John Sullivan  <sullivan@apple.com>
1332
1333         Reviewed by Geoff Garen
1334
1335         WebCore part of change to push the code that updates the spelling panel
1336         into WebCore, in preparation for some grammar-checking stuff.
1337
1338         * bridge/mac/FrameMac.h:
1339         * bridge/mac/FrameMac.mm:
1340         (WebCore::FrameMac::advanceToNextMisspelling):
1341         no more return value for this method, and update the spelling panel with
1342         the misspelled word here rather than in the WebKit callers.
1343
1344 2006-10-30  Oliver Hunt  <oliver@apple.com>
1345
1346         Reviewed by Anders.
1347
1348         Roll out last patch
1349
1350         * CMakeLists.txt:
1351         * ChangeLog:
1352         * WebCore.xcodeproj/project.pbxproj:
1353         * graphics/svg/SVGResource.cpp:
1354         * graphics/svg/SVGResourceClipper.cpp:
1355         * graphics/svg/SVGResourceClipper.h:
1356         * graphics/svg/SVGResourceImage.h:
1357         * graphics/svg/SVGResourceListener.h:
1358         * graphics/svg/SVGResourceMarker.cpp:
1359         * graphics/svg/SVGResourceMarker.h:
1360         * graphics/svg/SVGResourceMasker.cpp:
1361         * graphics/svg/SVGResourceMasker.h:
1362         * kcanvas/KCanvasClipper.cpp: Added.
1363         (WebCore::operator<<):
1364         (WebCore::KCanvasClipper::KCanvasClipper):
1365         (WebCore::KCanvasClipper::~KCanvasClipper):
1366         (WebCore::KCanvasClipper::resetClipData):
1367         (WebCore::KCanvasClipper::addClipData):
1368         (WebCore::KCanvasClipper::clipData):
1369         (WebCore::KCanvasClipper::externalRepresentation):
1370         (WebCore::getClipperById):
1371         * kcanvas/KCanvasClipper.h: Added.
1372         (WebCore::KCClipData::windRule):
1373         (WebCore::KCClipDataList::KCClipDataList):
1374         (WebCore::KCClipDataList::addPath):
1375         (WebCore::KCanvasClipper::isClipper):
1376         * kcanvas/KCanvasFilters.cpp:
1377         (WebCore::getFilterById):
1378         * kcanvas/KCanvasFilters.h:
1379         * kcanvas/KCanvasImage.h: Added.
1380         (WebCore::KCanvasImage::KCanvasImage):
1381         (WebCore::KCanvasImage::~KCanvasImage):
1382         * kcanvas/KCanvasMarker.cpp: Added.
1383         (WebCore::KCanvasMarker::KCanvasMarker):
1384         (WebCore::KCanvasMarker::~KCanvasMarker):
1385         (WebCore::KCanvasMarker::setMarker):
1386         (WebCore::KCanvasMarker::setRef):
1387         (WebCore::KCanvasMarker::refX):
1388         (WebCore::KCanvasMarker::refY):
1389         (WebCore::KCanvasMarker::setAngle):
1390         (WebCore::KCanvasMarker::angle):
1391         (WebCore::KCanvasMarker::setAutoAngle):
1392         (WebCore::KCanvasMarker::setUseStrokeWidth):
1393         (WebCore::KCanvasMarker::useStrokeWidth):
1394         (WebCore::KCanvasMarker::draw):
1395         (WebCore::KCanvasMarker::externalRepresentation):
1396         (WebCore::getMarkerById):
1397         * kcanvas/KCanvasMarker.h: Added.
1398         (WebCore::KCanvasMarker::isMarker):
1399         * kcanvas/KCanvasMasker.cpp: Added.
1400         (WebCore::KCanvasMasker::KCanvasMasker):
1401         (WebCore::KCanvasMasker::~KCanvasMasker):
1402         (WebCore::KCanvasMasker::setMask):
1403         (WebCore::KCanvasMasker::externalRepresentation):
1404         (WebCore::getMaskerById):
1405         * kcanvas/KCanvasMasker.h: Added.
1406         (WebCore::KCanvasMasker::isMasker):
1407         (WebCore::KCanvasMasker::mask):
1408         * kcanvas/KCanvasResource.cpp: Added.
1409         (WebCore::operator<<):
1410         (WebCore::KCanvasResource::KCanvasResource):
1411         (WebCore::KCanvasResource::~KCanvasResource):
1412         (WebCore::KCanvasResource::addClient):
1413         (WebCore::KCanvasResource::clients):
1414         (WebCore::KCanvasResource::invalidate):
1415         (WebCore::KCanvasResource::idInRegistry):
1416         (WebCore::KCanvasResource::setIdInRegistry):
1417         (WebCore::KCanvasResource::externalRepresentation):
1418         (WebCore::getResourceById):
1419         (WebCore::getPaintServerById):
1420         * kcanvas/KCanvasResource.h:
1421         (WebCore::):
1422         (WebCore::KCanvasResource::isPaintServer):
1423         (WebCore::KCanvasResource::isFilter):
1424         (WebCore::KCanvasResource::isClipper):
1425         (WebCore::KCanvasResource::isMarker):
1426         (WebCore::KCanvasResource::isMasker):
1427         * kcanvas/KCanvasResourceListener.h: Added.
1428         (KCanvasResourceListener::KCanvasResourceListener):
1429         (KCanvasResourceListener::~KCanvasResourceListener):
1430         * kcanvas/KCanvasTreeDebug.cpp:
1431         (WebCore::writeRenderResources):
1432         * kcanvas/device/KRenderingDevice.h:
1433         * kcanvas/device/KRenderingPaintServer.h:
1434         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1435         (WebCore::KRenderingPaintServer::idInRegistry):
1436         (WebCore::KRenderingPaintServer::setIdInRegistry):
1437         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1438         (WebCore::KRenderingPaintServerGradient::listener):
1439         (WebCore::KRenderingPaintServerGradient::setListener):
1440         * kcanvas/device/KRenderingPaintServerGradient.h:
1441         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1442         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1443         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1444         (WebCore::KRenderingPaintServerPattern::tile):
1445         (WebCore::KRenderingPaintServerPattern::setTile):
1446         (WebCore::KRenderingPaintServerPattern::listener):
1447         (WebCore::KRenderingPaintServerPattern::setListener):
1448         * kcanvas/device/KRenderingPaintServerPattern.h:
1449         * kcanvas/device/KRenderingPaintServerSolid.h:
1450         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1451         (WebCore::KCanvasClipperQt::applyClip):
1452         * kcanvas/device/qt/KCanvasClipperQt.h:
1453         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1454         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1455         (WebCore::KRenderingDeviceQt::contextForImage):
1456         (WebCore::KRenderingDeviceQt::createResource):
1457         (WebCore::KRenderingDeviceQt::createPaintServer):
1458         * kcanvas/device/qt/KRenderingDeviceQt.h:
1459         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1460         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1461         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1462         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1463         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1464         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1465         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1466         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1467         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1468         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1469         (WebCore::applyLuminanceToAlphaFilter):
1470         (WebCore::applyExpandAlphatoGrayscaleFilter):
1471         (WebCore::transformImageIntoGrayscaleMask):
1472         (WebCore::KCanvasMaskerQuartz::applyMask):
1473         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1474         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1475         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1476         (WebCore::KCanvasImageQuartz::init):
1477         (WebCore::KCanvasImageQuartz::size):
1478         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1479         (WebCore::KCanvasClipperQuartz::applyClip):
1480         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1481         (WebCore::KCanvasImageQuartz::cgLayer):
1482         (WebCore::KCanvasImageQuartz::setCGLayer):
1483         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1484         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1485         (WebCore::KRenderingDeviceQuartz::contextForImage):
1486         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1487         (WebCore::KRenderingDeviceQuartz::createResource):
1488         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1489         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1490         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1491         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1492         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1493         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1494         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1495         (WebCore::patternCallback):
1496         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1497         * kcanvas/device/quartz/QuartzSupport.mm:
1498         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1499         (WebCore::sharedSolidPaintServer):
1500         * ksvg2/svg/SVGClipPathElement.cpp:
1501         (WebCore::SVGClipPathElement::SVGClipPathElement):
1502         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1503         (WebCore::SVGClipPathElement::canvasResource):
1504         * ksvg2/svg/SVGClipPathElement.h:
1505         * ksvg2/svg/SVGFEImageElement.cpp:
1506         * ksvg2/svg/SVGFilterElement.cpp:
1507         (WebCore::SVGFilterElement::SVGFilterElement):
1508         (WebCore::SVGFilterElement::~SVGFilterElement):
1509         (WebCore::SVGFilterElement::canvasResource):
1510         * ksvg2/svg/SVGFilterElement.h:
1511         * ksvg2/svg/SVGGradientElement.cpp:
1512         (WebCore::SVGGradientElement::SVGGradientElement):
1513         (WebCore::SVGGradientElement::~SVGGradientElement):
1514         (WebCore::SVGGradientElement::canvasResource):
1515         (WebCore::SVGGradientElement::resourceNotification):
1516         * ksvg2/svg/SVGGradientElement.h:
1517         * ksvg2/svg/SVGImageElement.cpp:
1518         * ksvg2/svg/SVGLinearGradientElement.cpp:
1519         (WebCore::SVGLinearGradientElement::buildGradient):
1520         * ksvg2/svg/SVGLinearGradientElement.h:
1521         * ksvg2/svg/SVGMarkerElement.cpp:
1522         (WebCore::SVGMarkerElement::SVGMarkerElement):
1523         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1524         (WebCore::SVGMarkerElement::canvasResource):
1525         * ksvg2/svg/SVGMarkerElement.h:
1526         * ksvg2/svg/SVGMaskElement.cpp:
1527         (WebCore::SVGMaskElement::SVGMaskElement):
1528         (WebCore::SVGMaskElement::~SVGMaskElement):
1529         (WebCore::SVGMaskElement::drawMaskerContent):
1530         (WebCore::SVGMaskElement::canvasResource):
1531         * ksvg2/svg/SVGMaskElement.h:
1532         * ksvg2/svg/SVGPatternElement.cpp:
1533         (WebCore::SVGPatternElement::SVGPatternElement):
1534         (WebCore::SVGPatternElement::~SVGPatternElement):
1535         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1536         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1537         (WebCore::SVGPatternElement::canvasResource):
1538         * ksvg2/svg/SVGPatternElement.h:
1539         * ksvg2/svg/SVGRadialGradientElement.cpp:
1540         (WebCore::SVGRadialGradientElement::buildGradient):
1541         * ksvg2/svg/SVGRadialGradientElement.h:
1542         * ksvg2/svg/SVGStyledElement.h:
1543         (WebCore::SVGStyledElement::canvasResource):
1544         * platform/GraphicsContext.cpp: Added.
1545         (WebCore::GraphicsContextState::GraphicsContextState):
1546         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1547         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1548         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1549         (WebCore::GraphicsContext::save):
1550         (WebCore::GraphicsContext::restore):
1551         (WebCore::GraphicsContext::font):
1552         (WebCore::GraphicsContext::setFont):
1553         (WebCore::GraphicsContext::pen):
1554         (WebCore::GraphicsContext::setPen):
1555         (WebCore::GraphicsContext::setFillColor):
1556         (WebCore::GraphicsContext::fillColor):
1557         (WebCore::GraphicsContext::updatingControlTints):
1558         (WebCore::GraphicsContext::setUpdatingControlTints):
1559         (WebCore::GraphicsContext::setPaintingDisabled):
1560         (WebCore::GraphicsContext::paintingDisabled):
1561         (WebCore::GraphicsContext::drawImage):
1562         (WebCore::GraphicsContext::drawText):
1563         (WebCore::GraphicsContext::drawHighlightForText):
1564         (WebCore::GraphicsContext::initFocusRing):
1565         (WebCore::GraphicsContext::clearFocusRing):
1566         (WebCore::GraphicsContext::focusRingBoundingRect):
1567         (WebCore::GraphicsContext::addFocusRingRect):
1568         (WebCore::GraphicsContext::focusRingWidth):
1569         (WebCore::GraphicsContext::focusRingOffset):
1570         (WebCore::GraphicsContext::focusRingRects):
1571         (WebCore::GraphicsContext::drawTiledImage):
1572         * platform/GraphicsContext.h: Added.
1573         * platform/GraphicsTypes.cpp: Added.
1574         (WebCore::):
1575         (WebCore::parseCompositeOperator):
1576         (WebCore::compositeOperatorName):
1577         (WebCore::parseLineCap):
1578         (WebCore::lineCapName):
1579         (WebCore::parseLineJoin):
1580         (WebCore::lineJoinName):
1581         * platform/GraphicsTypes.h: Added.
1582         (WebCore::):
1583         * platform/graphics/GraphicsContext.cpp:
1584         * platform/graphics/GraphicsContext.h:
1585         * platform/graphics/GraphicsTypes.cpp:
1586         * platform/graphics/GraphicsTypes.h:
1587         * platform/qt/GraphicsContextQt.cpp:
1588         * rendering/RenderPath.cpp:
1589         (WebCore::RenderPath::paint):
1590         (WebCore::DrawMarkersData::DrawMarkersData):
1591         (WebCore::RenderPath::drawMarkersIfNeeded):
1592         * rendering/RenderSVGContainer.cpp:
1593         (WebCore::RenderSVGContainer::paint):
1594         * rendering/RenderSVGImage.cpp:
1595         (WebCore::RenderSVGImage::paint):
1596         * rendering/SVGInlineFlowBox.cpp:
1597         (WebCore::paintSVGInlineFlow):
1598
1599 2006-10-30  John Sullivan  <sullivan@apple.com>
1600
1601         Reviewed by Geoff Garen.
1602
1603         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1604         grammar-related method.
1605
1606         * bridge/EditorClient.h:
1607         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1608         isGrammarCheckingEnabled()
1609
1610         * bridge/mac/WebCoreFrameBridge.h:
1611         removed bridge equivalents
1612
1613         * bridge/mac/FrameMac.mm:
1614         (WebCore::FrameMac::advanceToNextMisspelling):
1615         convert bridge-using code to editor()->client()-using code
1616         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1617         ditto
1618         (WebCore::FrameMac::markMisspellings):
1619         ditto
1620         (WebCore::FrameMac::respondToChangedSelection):
1621         ditto
1622
1623         * editing/Editor.h:
1624         * editing/Editor.cpp:
1625         (WebCore::Editor::client):
1626         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1627         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1628         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1629
1630 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1631
1632         Reviewed by Darin.
1633
1634         Removed a number of editing and selection methods from the bridge.
1635
1636         I moved cross-platform editing and selection code into Editor and
1637         SelectionController, respecitvely.
1638
1639         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1640         everything + the kitchen sink.
1641
1642         Specific comments below for interesting things.
1643
1644         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1645         a new file so that WebKit can use them, too. Added a helper method for
1646         handling exceptions when selecting a Range.
1647         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into
1648         WebKit, since they have to do with creating an NSAttributedString for API
1649         consumption, and not much to do with general Frame functionality.
1650         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1651         for now) into the Editor. Eventually, the Frame will not have to notify
1652         the Editor of what the lastEditCommand was, since the Editor will perform
1653         all EditCommands.
1654         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1655         * editing/SelectionController.cpp:
1656         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1657         and return them. The bridge method to select a DOM range did this implicitly,
1658         since all ObjC DOM operations handle DOM exceptions by throwing them as
1659         ObjC exceptions.
1660         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1661         The two enumerations are numerically identical, but that's an implementation
1662         detail of TextAffinity that clients shouldn't be required to know about.
1663
1664 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1665
1666         Rolling out the following change because this crash:
1667         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp)
1668
1669         And this regression:
1670         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1671
1672     2006-09-06  David Harrison  <harrison@apple.com>
1673
1674         Reviewed and tweaked by Tim H.
1675
1676         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation
1677
1678         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
1679         to trigger a search that will include auto activation. No PLT or iBench perf impact.
1680         No layout tests affected. Not testable in an automated way that will work on all systems.
1681
1682         * platform/mac/WebFontCache.mm:
1683         (+[WebFontCache fontWithFamily:traits:size:]):
1684
1685 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1686
1687         Reviewed by harrison
1688
1689         <rdar://problem/4808375>
1690         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1691
1692         * editing/TextIterator.cpp:
1693         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1694         when we're going to use them to create a range for an emitted character.
1695         We should further speed TextIterators up by avoiding creating VisiblePositions
1696         for TIs that are only used for the characters they emit (like the one that
1697         plainText uses).
1698
1699 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1700
1701         Reviewed by Mitz.
1702
1703         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1704         More rendering code cleaning
1705
1706         * WebCore.xcodeproj/project.pbxproj:
1707         * rendering/RenderApplet.cpp:
1708         (WebCore::RenderApplet::RenderApplet):
1709         (WebCore::RenderApplet::createWidgetIfNecessary):
1710         * rendering/RenderApplet.h:
1711         * rendering/RenderArena.cpp:
1712         (WebCore::):
1713         (WebCore::RenderArena::RenderArena):
1714         (WebCore::RenderArena::allocate):
1715         (WebCore::RenderArena::free):
1716         * rendering/RenderArena.h:
1717         * rendering/RenderBR.cpp:
1718         (WebCore::RenderBR::RenderBR):
1719         (WebCore::RenderBR::baselinePosition):
1720         (WebCore::RenderBR::lineHeight):
1721         (WebCore::RenderBR::setStyle):
1722         (WebCore::RenderBR::caretMinOffset):
1723         (WebCore::RenderBR::positionForCoordinates):
1724         (WebCore::RenderBR::inlineBox):
1725         * rendering/RenderBR.h:
1726         * rendering/RenderBlock.cpp:
1727         * rendering/RenderBlock.h:
1728         (WebCore::RenderBlock::maxTopMargin):
1729         (WebCore::RenderBlock::maxBottomMargin):
1730         (WebCore::RenderBlock::initMaxMarginValues):
1731         (WebCore::RenderBlock::containsFloats):
1732         (WebCore::RenderBlock::setHasMarkupTruncation):
1733         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1734         (WebCore::RenderBlock::BlockSelectionInfo::block):
1735         (WebCore::RenderBlock::BlockSelectionInfo::state):
1736         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1737         (WebCore::RenderBlock::CompactInfo::clear):
1738         * rendering/RenderButton.cpp:
1739         (WebCore::RenderButton::removeChild):
1740         (WebCore::RenderButton::paintObject):
1741         * rendering/RenderButton.h:
1742         (WebCore::RenderButton::renderName):
1743         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1744         * rendering/RenderContainer.cpp:
1745         (WebCore::RenderContainer::RenderContainer):
1746         * rendering/RenderContainer.h:
1747         (WebCore::RenderContainer::firstChild):
1748         (WebCore::RenderContainer::lastChild):
1749         (WebCore::RenderContainer::calcMinMaxWidth):
1750         * rendering/RenderCounter.cpp:
1751         (WebCore::RenderCounter::RenderCounter):
1752         (WebCore::toRoman):
1753         (WebCore::toHebrew):
1754         (WebCore::RenderCounter::calcMinMaxWidth):
1755         * rendering/RenderCounter.h:
1756         * rendering/RenderFieldset.cpp:
1757         (WebCore::RenderFieldset::paintBoxDecorations):
1758         (WebCore::RenderFieldset::paintBorderMinusLegend):
1759         (WebCore::RenderFieldset::setStyle):
1760         * rendering/RenderFileUploadControl.cpp:
1761         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1762         (WebCore::RenderFileUploadControl::setStyle):
1763         (WebCore::RenderFileUploadControl::paintObject):
1764         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1765         * rendering/RenderFileUploadControl.h:
1766         (WebCore::RenderFileUploadControl::renderName):
1767         * rendering/RenderFlexibleBox.h:
1768         * rendering/RenderFlow.cpp:
1769         * rendering/RenderFlow.h:
1770         * rendering/RenderForeignObject.cpp:
1771         (WebCore::RenderForeignObject::RenderForeignObject):
1772         (WebCore::RenderForeignObject::paint):
1773         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1774         (WebCore::RenderForeignObject::layout):
1775         (WebCore::RenderForeignObject::nodeAtPoint):
1776         * rendering/RenderForeignObject.h:
1777         (WebCore::RenderForeignObject::renderName):
1778         * rendering/RenderFormElement.cpp:
1779         (WebCore::RenderFormElement::setStyle):
1780         (WebCore::RenderFormElement::layout):
1781         (WebCore::RenderFormElement::textAlignment):
1782         * rendering/RenderFormElement.h:
1783         * rendering/RenderFrame.cpp:
1784         * rendering/RenderFrame.h:
1785         (WebCore::RenderFrame::element):
1786         * rendering/RenderFrameSet.cpp:
1787         * rendering/RenderFrameSet.h:
1788         (WebCore::RenderFrameSet::element):
1789         * rendering/RenderHTMLCanvas.cpp:
1790         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1791         (WebCore::RenderHTMLCanvas::paint):
1792         * rendering/RenderHTMLCanvas.h:
1793         (WebCore::RenderHTMLCanvas::renderName):
1794         * rendering/RenderImage.cpp:
1795         (WebCore::RenderImage::RenderImage):
1796         (WebCore::RenderImage::setStyle):
1797         (WebCore::RenderImage::setContentObject):
1798         (WebCore::RenderImage::setCachedImage):
1799         (WebCore::RenderImage::imageChanged):
1800         (WebCore::RenderImage::paint):
1801         (WebCore::RenderImage::layout):
1802         (WebCore::RenderImage::updateAltText):
1803         * rendering/RenderImage.h:
1804         (WebCore::RenderImage::element):
1805         * rendering/RenderInline.cpp:
1806         (WebCore::RenderInline::RenderInline):
1807         (WebCore::RenderInline::~RenderInline):
1808         (WebCore::RenderInline::setStyle):
1809         (WebCore::RenderInline::addChildToFlow):
1810         (WebCore::RenderInline::cloneInline):
1811         (WebCore::RenderInline::splitInlines):
1812         (WebCore::RenderInline::splitFlow):
1813         (WebCore::RenderInline::paint):
1814         (WebCore::RenderInline::absoluteRects):
1815         (WebCore::RenderInline::calcMinMaxWidth):
1816         (WebCore::RenderInline::requiresLayer):
1817         (WebCore::RenderInline::width):
1818         (WebCore::RenderInline::height):
1819         (WebCore::RenderInline::renderName):
1820         (WebCore::RenderInline::nodeAtPoint):
1821         (WebCore::RenderInline::positionForCoordinates):
1822         * rendering/RenderInline.h:
1823         (WebCore::RenderInline::layout):
1824         * rendering/RenderLayer.cpp:
1825         * rendering/RenderLayer.h:
1826         (WebCore::ClipRects::ClipRects):
1827         (WebCore::RenderLayer::nextSibling):
1828         (WebCore::RenderLayer::root):
1829         (WebCore::RenderLayer::setPos):
1830         (WebCore::RenderLayer::height):
1831         (WebCore::RenderLayer::relativePositionOffset):
1832         * rendering/RenderLineEdit.cpp:
1833         (WebCore::RenderLineEdit::setStyle):
1834         (WebCore::RenderLineEdit::updateFromElement):
1835         (WebCore::RenderLineEdit::selectionStart):
1836         (WebCore::RenderLineEdit::selectionEnd):
1837         (WebCore::RenderLineEdit::setSelectionStart):
1838         (WebCore::RenderLineEdit::setSelectionEnd):
1839         (WebCore::RenderLineEdit::setSelectionRange):
1840         * rendering/RenderLineEdit.h:
1841         * rendering/RenderListBox.cpp:
1842         * rendering/RenderListBox.h:
1843         (WebCore::RenderListBox::renderName):
1844         * rendering/RenderListItem.cpp:
1845         (WebCore::RenderListItem::setStyle):
1846         (WebCore::getParentOfFirstLineBox):
1847         (WebCore::RenderListItem::updateMarkerLocation):
1848         (WebCore::RenderListItem::positionListMarker):
1849         (WebCore::RenderListItem::paint):
1850         * rendering/RenderListItem.h:
1851         * rendering/RenderListMarker.cpp:
1852         * rendering/RenderListMarker.h:
1853         (WebCore::RenderListMarker::renderName):
1854         (WebCore::RenderListMarker::isListMarker):
1855
1856 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1857
1858         Reviewed by Hyatt.
1859
1860         <rdar://problem/4478625> Basic table editing and culling
1861
1862         Refined the criteria for deletable elements, rely on the renderer more.
1863         Corrected the interface positioning for elements that have borders.
1864
1865         * editing/DeleteButtonController.cpp:
1866         (WebCore::isDeletableElement):
1867         (WebCore::DeleteButtonController::show):
1868
1869 2006-10-30  Darin Adler  <darin@apple.com>
1870
1871         - fix build
1872
1873         * loader/ResourceLoader.h: Added header guard.
1874
1875 2006-10-31  Darin Adler  <darin@apple.com>
1876
1877         Reviewed by Adam.
1878
1879         - fix FrameLoader files so they can be built on non-Mac platforms
1880
1881         * page/FramePrivate.h:
1882         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1883         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1884
1885         * page/Page.h:
1886         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1887         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1888         the other day.
1889
1890         * bridge/mac/FrameMac.mm:
1891         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1892         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1893
1894         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1895         around the PolicyCheck definition.
1896
1897         * loader/FormState.cpp: Changed import to include.
1898         * loader/FrameLoader.cpp: Ditto.
1899         * loader/MainResourceLoader.h: Ditto.
1900
1901         * loader/FrameLoaderTypes.h: Added a header guard.
1902
1903         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1904         Added #if PLATFORM(MAC) around Mac-specific details.
1905         * loader/SubresourceLoader.h: Ditto.
1906
1907         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1908         m_loader from m_frameLoader.
1909
1910         * CMakeLists.txt: Updated.
1911         * WebCoreSources.bkl: Updated.
1912
1913 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1914
1915         Reviewed and landed by Anders.
1916
1917         Patch by Zack rusin to fix:
1918         http://bugs.webkit.org/show_bug.cgi?id=11429
1919
1920         Fix startup crash.
1921
1922         * platform/qt/FrameQtClient.cpp:
1923         (WebCore::FrameQtClientDefault::openURL):
1924
1925 2006-10-30  Zach Rusin  <zack@kde.org>
1926
1927         Reviewed and landed by Anders.
1928
1929         * platform/network/qt/ResourceHandleQt.cpp:
1930         (WebCore::ResourceHandle::receivedResponse):
1931         * platform/qt/FrameQtClient.cpp:
1932         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1933         * platform/qt/LoaderFunctionsQt.cpp:
1934         (WebCore::ServeSynchronousRequest):
1935         More build fixes.
1936
1937 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1938
1939         Reviewed and landed by Anders.
1940
1941         - fix Qt build
1942         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1943         ResourceHandleClient
1944
1945 2006-10-30  Darin Adler  <darin@apple.com>
1946
1947         Reviewed by John Sullivan.
1948
1949         - work toward removing Objective-C data types from FrameLoader.h:
1950           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1951           and WebCoreResourceHandle
1952         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
1953
1954         * page/PageState.h:
1955         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
1956
1957         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
1958         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
1959         double for the date instead of an NSDate.
1960
1961         * bridge/mac/WebCoreFrameBridge.h:
1962         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
1963         saveDocumentToPageCache methods.
1964
1965         * bridge/mac/WebCorePageState.h:
1966         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
1967         an Objective-C wrapper for PageState.
1968
1969         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
1970         NSDate and WebCorePageState.
1971         * loader/FrameLoaderClient.h: Changed NSDate to double.
1972         * loader/mac/FrameLoaderMac.mm:
1973         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
1974         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
1975         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
1976         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
1977         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
1978         extract the parameters from the response. Changed the open function that takes
1979         a PageState to use the new C++ PageState.
1980         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
1981         function; tightened up logic, removing a few cases that could never happen, as
1982         well as the unused reload boolean.
1983
1984         * ForwardingHeaders/kjs/property_map.h: Added.
1985
1986         * WebCore.exp: Updated.
1987         * WebCore.xcodeproj/project.pbxproj: Updated.
1988
1989 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1990
1991         Reviewed by Anders.
1992
1993         - added ResourceResponse class and didReceiveResponse delegate call
1994
1995         * WebCore.xcodeproj/project.pbxproj: Added new files.
1996         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1997         expiresTimeForResponse: method.
1998         * dom/XMLTokenizer.cpp:
1999         (WebCore::openFunc): Updated to use ResourceResponse.
2000         * loader/FrameLoader.h: Update loadResourceSynchronously to
2001         use ResourceResponse.
2002         * loader/LoaderFunctions.h:
2003         * loader/icon/IconLoader.cpp:
2004         (IconLoader::didReceiveResponse): Updated from receivedResponse
2005         and made cross-platform.
2006         * loader/icon/IconLoader.h: updated for above change
2007         * loader/loader.cpp:
2008         (WebCore::Loader::receivedResponse): reduced to just saving
2009         the PlatformResponse (ideally we'd phase out use of this).
2010         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse
2011         logic.
2012         * loader/loader.h:
2013         * loader/mac/FrameLoaderMac.mm:
2014         (WebCore::FrameLoader::loadResourceSynchronously): Return results
2015         as ResourceResponse.
2016         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
2017         * loader/mac/LoaderFunctionsMac.mm:
2018         (WebCore::ServeSynchronousRequest): take ResourceResponse as
2019         argument.
2020         * platform/network/ResourceHandle.cpp:
2021         * platform/network/ResourceHandle.h: Remove calls for
2022         broken out response pieces.
2023         * platform/network/ResourceHandleClient.h:
2024         (WebCore::ResourceHandleClient::didReceiveResponse): New
2025         delegate method.
2026         * platform/network/ResourceHandleInternal.h:
2027         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
2028         storage of response bits, we're not gonna return them
2029         seprately any more.
2030         * platform/network/ResourceResponse.h: Added.
2031         (WebCore::ResourceResponse::ResourceResponse): Freshly
2032         implemented. Same for below.
2033         (WebCore::ResourceResponse::url):
2034         (WebCore::ResourceResponse::mimeType):
2035         (WebCore::ResourceResponse::expectedContentLength):
2036         (WebCore::ResourceResponse::textEncodingName):
2037         (WebCore::ResourceResponse::suggestedFilename):
2038         (WebCore::ResourceResponse::httpStatusCode):
2039         (WebCore::ResourceResponse::setHTTPStatusCode):
2040         (WebCore::ResourceResponse::httpHeaderField):
2041         (WebCore::ResourceResponse::httpHeaderFields):
2042         (WebCore::ResourceResponse::isMultipart):
2043         (WebCore::ResourceResponse::setExpirationDate):
2044         (WebCore::ResourceResponse::expirationDate):
2045         * platform/network/cf/ResourceHandleCFNet.cpp:
2046         (WebCore::didReceiveResponse): Send didReceiveResponse
2047         client method.
2048         * platform/network/cf/ResourceResponseCFNet.h: Added.
2049         * platform/network/cf/ResourceResponseCFNet.mm: Added.
2050         (getResourceResponse): Helper function to get a ResourceResponse
2051         from CFURLResponseRef.
2052         * platform/network/mac/ResourceHandleMac.mm:
2053         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2054         Don't bother cleaning up fields we no longer have.
2055         (WebCore::ResourceHandle::receivedResponse): Send
2056         didReceiveResponse client method.
2057         * platform/network/mac/ResourceResponseMac.h: Added.
2058         * platform/network/mac/ResourceResponseMac.mm: Added.
2059         (getResourceResponse): Helper function to get a ResourceResponse
2060         from an NSURLResponse*.
2061         * rendering/HitTestResult.cpp:
2062         * xml/XSLTProcessor.cpp:
2063         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
2064         * xml/xmlhttprequest.cpp:
2065         (WebCore::XMLHttpRequest::getResponseText): Store http response
2066         info in the form of a ResourceResponse, change all methods to
2067         account for this.
2068         (WebCore::XMLHttpRequest::getResponseXML):
2069         (WebCore::XMLHttpRequest::XMLHttpRequest):
2070         (WebCore::XMLHttpRequest::open):
2071         (WebCore::XMLHttpRequest::send):
2072         (WebCore::XMLHttpRequest::getAllResponseHeaders):
2073         (WebCore::XMLHttpRequest::getResponseHeader):
2074         (WebCore::XMLHttpRequest::getStatus):
2075         (WebCore::XMLHttpRequest::getStatusText):
2076         (WebCore::XMLHttpRequest::processSyncLoadResults):
2077         (WebCore::XMLHttpRequest::didFinishLoading):
2078         (WebCore::XMLHttpRequest::didReceiveResponse):
2079         (WebCore::XMLHttpRequest::didReceiveData):
2080         * xml/xmlhttprequest.h:
2081
2082 2006-10-29  Darin Adler  <darin@apple.com>
2083
2084         - fix build
2085
2086         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
2087         * loader/NetscapePlugInStreamLoader.h: Ditto.
2088         * loader/ResourceLoader.h: Ditto.
2089
2090 2006-10-29  Darin Adler  <darin@apple.com>
2091
2092         - one last name change -- WebFormState.h to FormState.h
2093         - added more empty placeholder platform-independent files
2094           for currently-Mac-specific loader classes
2095
2096         * loader/FormState.cpp: Updated include.
2097         * loader/FrameLoader.cpp: Updated include.
2098         * loader/mac/FrameLoaderMac.mm: Updated include.
2099
2100         * loader/WebFormState.h: Removed.
2101         * loader/FormState.h: Added.
2102
2103         * loader/DocumentLoader.cpp: Added.
2104         * loader/MainResourceLoader.cpp: Added.
2105         * loader/NetscapePlugInStreamLoader.cpp: Added.
2106         * loader/ResourceLoader.cpp: Added.
2107         * loader/SubresourceLoader.cpp: Added.
2108
2109         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
2110
2111 2006-10-29  Darin Adler  <darin@apple.com>
2112
2113         - did the do-webcore-rename renames, including a number of changes
2114           to the names of loader files (and WebResourceLoader -> ResourceLoader),
2115           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
2116           and improvements to the names of decoder classes and their source
2117           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
2118
2119         * CMakeLists.txt:
2120         * WebCore.exp:
2121         * WebCore.vcproj/WebCore/WebCore.vcproj:
2122         * WebCore.xcodeproj/project.pbxproj:
2123         * WebCoreSources.bkl:
2124         * bindings/js/kjs_binding.cpp:
2125         (KJS::ScriptInterpreter::updateDOMNodeDocument):
2126         * bindings/js/kjs_events.cpp:
2127         (KJS::JSAbstractEventListener::handleEvent):
2128         (KJS::JSLazyEventListener::parseCode):
2129         * bindings/js/kjs_html.cpp:
2130         (KJS::JSHTMLElement::implementsCall):
2131         * bindings/js/kjs_traversal.cpp:
2132         (KJS::JSNodeFilterCondition::acceptNode):
2133         * bindings/js/kjs_window.cpp:
2134         (KJS::Window::interpreter):
2135         (KJS::Window::retrieveWindow):
2136         (KJS::Window::retrieve):
2137         (KJS::ScheduledAction::execute):
2138         * bindings/objc/DOMInternal.mm:
2139         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2140         * bridge/mac/FrameMac.mm:
2141         (WebCore::FrameMac::executionContextForDOM):
2142         (WebCore::FrameMac::bindingRootObject):
2143         (WebCore::FrameMac::windowScriptObject):
2144         (WebCore::FrameMac::windowScriptNPObject):
2145         (WebCore::FrameMac::partClearedInBegin):
2146         * bridge/mac/WebCoreEncodings.mm:
2147         * bridge/mac/WebCoreFrameBridge.mm:
2148         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2149         (-[WebCoreFrameBridge stringWithData:]):
2150         (-[WebCoreFrameBridge executionContextForView:]):
2151         * bridge/win/FrameWin.cpp:
2152         * dom/Document.cpp:
2153         (WebCore::Document::inputEncoding):
2154         (WebCore::Document::setCharset):
2155         (WebCore::Document::createHTMLEventListener):
2156         (WebCore::Document::setDecoder):
2157         * dom/Document.h:
2158         (WebCore::Document::decoder):
2159         * dom/EventTargetNode.cpp:
2160         (WebCore::EventTargetNode::dispatchGenericEvent):
2161         * html/HTMLParser.cpp:
2162         (WebCore::HTMLParser::noscriptCreateErrorCheck):
2163         (WebCore::HTMLParser::canvasCreateErrorCheck):
2164         (WebCore::HTMLParser::isInline):
2165         * html/HTMLPlugInElement.cpp:
2166         (WebCore::HTMLPlugInElement::createNPObject):
2167         * html/HTMLScriptElement.cpp:
2168         (WebCore::HTMLScriptElement::evaluateScript):
2169         * html/HTMLTokenizer.cpp:
2170         (WebCore::HTMLTokenizer::parseTag):
2171         (WebCore::HTMLTokenizer::processToken):
2172         * ksvg2/misc/SVGDocumentExtensions.cpp:
2173         (WebCore::SVGDocumentExtensions::createSVGEventListener):
2174         * loader/CachedCSSStyleSheet.cpp:
2175         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2176         (WebCore::CachedCSSStyleSheet::setEncoding):
2177         * loader/CachedCSSStyleSheet.h:
2178         * loader/CachedXBLDocument.cpp:
2179         (WebCore::CachedXBLDocument::CachedXBLDocument):
2180         (WebCore::CachedXBLDocument::setEncoding):
2181         * loader/CachedXBLDocument.h:
2182         * loader/CachedXSLStyleSheet.cpp:
2183         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2184         (WebCore::CachedXSLStyleSheet::setEncoding):
2185         * loader/CachedXSLStyleSheet.h:
2186         * loader/Decoder.cpp: Removed.
2187         * loader/Decoder.h: Removed.
2188         * loader/FrameLoader.cpp:
2189         * loader/FrameLoader.h:
2190         * loader/FrameLoaderClient.h:
2191         * loader/MainResourceLoader.h: Added.
2192         * loader/NetscapePlugInStreamLoader.h: Added.
2193         * loader/Request.h:
2194         (WebCore::Request::cachedResource):
2195         * loader/ResourceLoader.h: Added.
2196         * loader/SubresourceLoader.h: Added.
2197         * loader/TextResourceDecoder.cpp: Added.
2198         (WebCore::TextResourceDecoder::determineContentType):
2199         (WebCore::TextResourceDecoder::defaultEncoding):
2200         (WebCore::TextResourceDecoder::TextResourceDecoder):
2201         (WebCore::TextResourceDecoder::~TextResourceDecoder):
2202         (WebCore::TextResourceDecoder::setEncoding):
2203         (WebCore::TextResourceDecoder::checkForBOM):
2204         (WebCore::TextResourceDecoder::checkForCSSCharset):
2205         (WebCore::TextResourceDecoder::checkForHeadCharset):
2206         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
2207         (WebCore::TextResourceDecoder::decode):
2208         (WebCore::TextResourceDecoder::flush):
2209         * loader/TextResourceDecoder.h: Added.
2210         * loader/WebDocumentLoader.h: Removed.
2211         * loader/WebLoader.h: Removed.
2212         * loader/WebMainResourceLoader.h: Removed.
2213         * loader/WebNetscapePlugInStreamLoader.h: Removed.
2214         * loader/WebSubresourceLoader.h: Removed.
2215         * loader/loader.cpp:
2216         (WebCore::Loader::servePendingRequests):
2217         (WebCore::Loader::receivedAllData):
2218         (WebCore::Loader::receivedResponse):
2219         (WebCore::Loader::didReceiveData):
2220         (WebCore::Loader::cancelRequests):
2221         (WebCore::Loader::jobForRequest):
2222         * loader/mac/DocumentLoaderMac.mm:
2223         * loader/mac/FormDataStream.m: Added.
2224         * loader/mac/FrameLoaderMac.mm:
2225         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2226         (WebCore::FrameLoader::addPlugInStreamLoader):
2227         (WebCore::FrameLoader::removePlugInStreamLoader):
2228         (WebCore::FrameLoader::addSubresourceLoader):
2229         (WebCore::FrameLoader::removeSubresourceLoader):
2230         (WebCore::FrameLoader::willSendRequest):
2231         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2232         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2233         (WebCore::FrameLoader::didReceiveResponse):
2234         (WebCore::FrameLoader::didReceiveData):
2235         (WebCore::FrameLoader::didFinishLoad):
2236         (WebCore::FrameLoader::didFailToLoad):
2237         (WebCore::FrameLoader::open):
2238         (WebCore::FrameLoader::willUseArchive):
2239         (WebCore::FrameLoader::isArchiveLoadPending):
2240         * loader/mac/ImageDocumentMac.mm:
2241         * loader/mac/LoaderFunctionsMac.mm:
2242         (WebCore::CheckCacheObjectStatus):
2243         * loader/mac/MainResourceLoaderMac.mm:
2244         (WebCore::MainResourceLoader::MainResourceLoader):
2245         (WebCore::MainResourceLoader::releaseDelegate):
2246         (WebCore::MainResourceLoader::didCancel):
2247         (WebCore::MainResourceLoader::addData):
2248         (WebCore::MainResourceLoader::willSendRequest):
2249         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2250         (WebCore::MainResourceLoader::didReceiveData):
2251         (WebCore::MainResourceLoader::didFinishLoading):
2252         (WebCore::MainResourceLoader::setDefersLoading):
2253         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
2254         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
2255         (WebCore::NetscapePlugInStreamLoader::releaseResources):
2256         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
2257         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
2258         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
2259         (WebCore::NetscapePlugInStreamLoader::didFail):
2260         (WebCore::NetscapePlugInStreamLoader::didCancel):
2261         * loader/mac/ResourceLoaderMac.mm:
2262         (WebCore::ResourceLoader::ResourceLoader):
2263         (WebCore::ResourceLoader::~ResourceLoader):
2264         (WebCore::ResourceLoader::releaseResources):
2265         (WebCore::ResourceLoader::load):
2266         (WebCore::ResourceLoader::setDefersLoading):
2267         (WebCore::ResourceLoader::frameLoader):
2268         (WebCore::ResourceLoader::addData):
2269         (WebCore::ResourceLoader::resourceData):
2270         (WebCore::ResourceLoader::clearResourceData):
2271         (WebCore::ResourceLoader::willSendRequest):
2272         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2273         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2274         (WebCore::ResourceLoader::didReceiveResponse):
2275         (WebCore::ResourceLoader::didReceiveData):
2276         (WebCore::ResourceLoader::willStopBufferingData):
2277         (WebCore::ResourceLoader::didFinishLoading):
2278         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2279         (WebCore::ResourceLoader::didFail):
2280         (WebCore::ResourceLoader::willCacheResponse):
2281         (WebCore::ResourceLoader::didCancel):
2282         (WebCore::ResourceLoader::cancel):
2283         (WebCore::ResourceLoader::setIdentifier):
2284         (WebCore::ResourceLoader::response):
2285         (WebCore::ResourceLoader::inConnectionCallback):
2286         (WebCore::ResourceLoader::cancelledError):
2287         (WebCore::ResourceLoader::receivedCredential):
2288         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2289         (WebCore::ResourceLoader::receivedCancellation):
2290         (WebCore::ResourceLoader::delegate):
2291         (WebCore::ResourceLoader::releaseDelegate):
2292         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
2293         * loader/mac/SubresourceLoaderMac.mm:
2294         (WebCore::SubresourceLoader::SubresourceLoader):
2295         (WebCore::SubresourceLoader::willSendRequest):
2296         (WebCore::SubresourceLoader::didReceiveResponse):
2297         (WebCore::SubresourceLoader::didReceiveData):
2298         (WebCore::SubresourceLoader::didFinishLoading):
2299         (WebCore::SubresourceLoader::didFail):
2300         (WebCore::SubresourceLoader::didCancel):
2301         * loader/mac/WebFormDataStream.h: Removed.
2302         * loader/mac/WebFormDataStream.m: Removed.
2303         * page/Frame.cpp:
2304         (WebCore::Frame::javaScriptEnabled):
2305         (WebCore::Frame::scriptProxy):
2306         (WebCore::Frame::executeScript):
2307         (WebCore::Frame::write):
2308         (WebCore::Frame::userGestureHint):
2309         (WebCore::Frame::saveInterpreterBuiltins):
2310         (WebCore::Frame::restoreInterpreterBuiltins):
2311         (WebCore::Frame::backslashAsCurrencySymbol):
2312         * page/Frame.h:
2313         * page/FramePrivate.h:
2314         * platform/StreamingTextDecoder.cpp: Removed.
2315         * platform/StreamingTextDecoder.h: Removed.
2316         * platform/StreamingTextDecoderICU.cpp: Removed.
2317         * platform/StreamingTextDecoderICU.h: Removed.
2318         * platform/TextCodec.cpp: Added.
2319         * platform/TextCodec.h: Added.
2320         * platform/TextCodecICU.cpp: Added.
2321         * platform/TextCodecICU.h: Added.
2322         * platform/TextCodecLatin1.h:
2323         * platform/TextCodecUTF16.h:
2324         * platform/TextDecoder.h:
2325         * platform/TextEncoding.cpp:
2326         * platform/TextEncodingRegistry.cpp:
2327         * platform/image-decoders/jpeg/jmorecfg.h:
2328         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
2329         * platform/mac/StreamingTextDecoderMac.h: Removed.
2330         * platform/mac/TextCodecMac.cpp: Added.
2331         * platform/mac/TextCodecMac.h: Added.
2332         * platform/network/ResourceHandleInternal.h:
2333         * platform/network/mac/ResourceHandleMac.mm:
2334         * platform/qt/FrameQt.cpp:
2335         (WebCore::FrameQt::bindingRootObject):
2336         * platform/qt/LoaderFunctionsQt.cpp:
2337         (WebCore::CheckCacheObjectStatus):
2338         * rendering/RenderObject.cpp:
2339         (WebCore::RenderObject::backslashAsCurrencySymbol):
2340         * xml/XSLTProcessor.cpp:
2341         (WebCore::XSLTProcessor::createDocumentFromSource):
2342         * xml/xmlhttprequest.cpp:
2343         (WebCore::XMLHttpRequest::didReceiveData):
2344         * xml/xmlhttprequest.h:
2345
2346 2006-10-29  Darin Adler  <darin@apple.com>
2347
2348         Rubber stamped by Adam (kinda).
2349
2350         - add Mac suffixes and correct filenames inside loader/mac
2351
2352         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
2353
2354         * loader/mac/FrameLoader.mm: Removed.
2355         * loader/mac/WebDocumentLoader.mm: Removed.
2356         * loader/mac/WebLoader.mm: Removed.
2357         * loader/mac/WebMainResourceLoader.mm: Removed.
2358         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
2359         * loader/mac/WebSubresourceLoader.mm: Removed.
2360
2361         * loader/mac/FrameLoaderMac.mm: Added.
2362         * loader/mac/DocumentLoaderMac.mm: Added.
2363         * loader/mac/ResourceLoaderMac.mm: Added.
2364         * loader/mac/MainResourceLoaderMac.mm: Added.
2365         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
2366         * loader/mac/SubresourceLoaderMac.mm: Removed.
2367
2368 2006-10-29  Darin Adler  <darin@apple.com>
2369
2370         Reviewed by Adam.
2371
2372         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
2373           and FrameLoader.cpp mostly ready
2374
2375         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
2376         FormState.cpp. Removed WebFormState.mm.
2377
2378         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
2379         get this header compiling on non-Mac.
2380         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
2381         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
2382
2383         * loader/FrameLoaderClient.h: Added some ifdefs.
2384         * loader/WebDocumentLoader.h: Ditto.
2385         * loader/WebLoader.h: Ditto.
2386         * loader/WebMainResourceLoader.h: Ditto.
2387
2388         * loader/mac/WebDocumentLoader.mm:
2389         (WebCore::DocumentLoader::isLoadingInAPISense):
2390         Rewrote to work without bridge, partly to remove the need for ObjC
2391         bridge type in the header, and also because we're tearing down the bridge.
2392
2393         * loader/mac/WebMainResourceLoader.mm:
2394         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
2395         m_contentLength and m_bytesReceived.
2396         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
2397         (WebCore::MainResourceLoader::didReceiveData): Ditto.
2398
2399         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
2400         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2401
2402         * loader/mac/FormState.mm: Removed.
2403         * loader/FormState.cpp: Added.
2404
2405 2006-10-29  Darin Adler  <darin@apple.com>
2406
2407         Rubber stamped by Adam.
2408
2409         - moving towards use of FrameLoader cross-platform; move the headers
2410           for the Mac loader from loader/mac into loader, in preparation for
2411           making them useful on non-Mac
2412
2413         * WebCore.xcodeproj/project.pbxproj:
2414
2415         * loader/mac/FrameLoader.h: Removed.
2416         * loader/mac/WebDocumentLoader.h: Removed.
2417         * loader/mac/WebFormState.h: Removed.
2418         * loader/mac/WebLoader.h: Removed.
2419         * loader/mac/WebMainResourceLoader.h: Removed.
2420         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
2421         * loader/mac/WebSubresourceLoader.h: Removed.
2422
2423         * loader/FrameLoader.h: Added.
2424         * loader/WebDocumentLoader.h: Added.
2425         * loader/WebFormState.h: Added.
2426         * loader/WebLoader.h: Added.
2427         * loader/WebMainResourceLoader.h: Added.
2428         * loader/WebNetscapePlugInStreamLoader.h: Added.
2429         * loader/WebSubresourceLoader.h: Added.
2430
2431 2006-10-29  Adam Roben  <aroben@apple.com>
2432
2433         Reviewed by Geoff.
2434
2435         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
2436         r17405.
2437
2438         * platform/DeprecatedString.h:
2439
2440 2006-10-29  Beth Dakin  <bdakin@apple.com>
2441
2442         Rubber stamped by Geoff.
2443
2444         This is a followup to my HitTestResult checkin. Most of the
2445         HitTestResult local variables in the code were named i or info for
2446         when the class was named NodeInfo. This patch renames all of these
2447         local variables to result.
2448
2449         * dom/Document.cpp:
2450         (WebCore::Document::prepareMouseEvent):
2451         * html/HTMLAreaElement.cpp:
2452         (WebCore::HTMLAreaElement::mapMouseEvent):
2453         * html/HTMLMapElement.cpp:
2454         (WebCore::HTMLMapElement::mapMouseEvent):
2455         * rendering/EllipsisBox.cpp:
2456         (WebCore::EllipsisBox::nodeAtPoint):
2457         * rendering/EllipsisBox.h:
2458         * rendering/InlineBox.cpp:
2459         (WebCore::InlineBox::nodeAtPoint):
2460         * rendering/InlineFlowBox.cpp:
2461         (WebCore::InlineFlowBox::nodeAtPoint):
2462         * rendering/InlineTextBox.cpp:
2463         (WebCore::InlineTextBox::nodeAtPoint):
2464         * rendering/RenderBlock.cpp:
2465         (WebCore::RenderBlock::isPointInScrollbar):
2466         (WebCore::RenderBlock::nodeAtPoint):
2467         * rendering/RenderBlock.h:
2468         * rendering/RenderBox.cpp:
2469         (WebCore::RenderBox::nodeAtPoint):
2470         * rendering/RenderBox.h:
2471         * rendering/RenderFlow.cpp:
2472         (WebCore::RenderFlow::hitTestLines):
2473         * rendering/RenderFlow.h:
2474         * rendering/RenderForeignObject.cpp:
2475         (WebCore::RenderForeignObject::nodeAtPoint):
2476         * rendering/RenderFrameSet.cpp:
2477         (WebCore::RenderFrameSet::nodeAtPoint):
2478         * rendering/RenderImage.cpp:
2479         (WebCore::RenderImage::nodeAtPoint):
2480         * rendering/RenderInline.cpp:
2481         (WebCore::RenderInline::nodeAtPoint):
2482         * rendering/RenderInline.h:
2483         * rendering/RenderLayer.cpp:
2484         (WebCore::RenderLayer::autoscroll):
2485         (WebCore::RenderLayer::hitTest):
2486         (WebCore::RenderLayer::hitTestLayer):
2487         (WebCore::RenderLayer::updateHoverActiveState):
2488         * rendering/RenderListBox.cpp:
2489         (WebCore::RenderListBox::isPointInScrollbar):
2490         * rendering/RenderObject.cpp:
2491         (WebCore::RenderObject::hitTest):
2492         (WebCore::RenderObject::setInnerNode):
2493         (WebCore::RenderObject::nodeAtPoint):
2494         * rendering/RenderObject.h:
2495         * rendering/RenderPath.cpp:
2496         (WebCore::RenderPath::nodeAtPoint):
2497         * rendering/RenderSVGImage.cpp:
2498         (WebCore::RenderSVGImage::nodeAtPoint):
2499         * rendering/RenderSVGText.cpp:
2500         (WebCore::RenderSVGText::nodeAtPoint):
2501         * rendering/RenderTableRow.cpp:
2502         (WebCore::RenderTableRow::nodeAtPoint):
2503         * rendering/RenderTableRow.h:
2504         * rendering/RenderTableSection.cpp:
2505         (WebCore::RenderTableSection::nodeAtPoint):
2506         * rendering/RenderTableSection.h:
2507         * rendering/RenderTextControl.cpp:
2508         (WebCore::RenderTextControl::nodeAtPoint):
2509         * rendering/RootInlineBox.cpp:
2510         (WebCore::RootInlineBox::nodeAtPoint):
2511         * rendering/RootInlineBox.h:
2512
2513 2006-10-29  Adam Roben  <aroben@apple.com>
2514
2515         More semi-fixes.
2516
2517         * page/Page.cpp: Forgot to wrap the actual definition of
2518         setDefersLoading() in PLATFORM(MAC).
2519         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2520
2521 2006-10-29  Adam Roben  <aroben@apple.com>
2522
2523         Build semi-fix.
2524
2525         Move all FrameLoader-related code in Page.{cpp,h} within #if
2526         PLATFORM(MAC), since this class currently only exists on Mac.
2527
2528         * page/Page.cpp:
2529         * page/Page.h:
2530
2531 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2532
2533         build fix.
2534
2535         * platform/PlatformString.h:
2536         (WebCore::String::operator NSString*):
2537
2538 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2539
2540         Rolled out accidental commit.
2541
2542         * platform/AtomicString.h:
2543         (WebCore::AtomicString::AtomicString):
2544         (WebCore::AtomicString::operator NSString*):
2545
2546 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2547
2548         RS by Darin.
2549
2550         Rolled out change to map NULL Strings to nil NSStrings because it caused
2551         even more AppKit crashes. Maybe we should remove the NSString * operator
2552         entirely, since its use is not straight-forward, and require callers to
2553         specify explicitly whether they tolerate NULL.
2554
2555         * platform/AtomicString.h:
2556         * platform/PlatformString.h:
2557         (WebCore::String::operator NSString*):
2558         * platform/mac/TextFieldMac.mm:
2559         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2560
2561 2006-10-29  Darin Adler  <darin@apple.com>
2562
2563         Reviewed by Geoff.
2564
2565         - fixed storage leak showing up on the buildbot
2566
2567         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2568         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2569
2570 2006-10-29  Darin Adler  <darin@apple.com>
2571
2572         Rubber stamped by Adam.
2573
2574         - renamed WebFrameLoaderClient to match the class name inside it
2575
2576         * loader/mac/WebFrameLoaderClient.h: Removed.
2577         * loader/FrameLoaderClient.h: Moved it here.
2578
2579         * WebCore.xcodeproj/project.pbxproj: Updated project.
2580
2581         * bridge/mac/FrameMac.mm: Updated includes.
2582         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2583         * loader/mac/FrameLoader.mm: Ditto.
2584         * loader/mac/WebLoader.h: Ditto.
2585
2586 2006-10-29  Darin Adler  <darin@apple.com>
2587
2588         Reviewed by Mitz.
2589
2590         - fix crash visible on buildbot and also when running the test
2591           anchor-image-scrolled-x-y.html under libgmalloc
2592
2593         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2594         now that the class is named ResourceHandle.
2595         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2596         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2597         a local RefPtr before calling finishJobAndHandle, since we might get
2598         cancelled inside that function, so we should not rely on m_handle to
2599         keep the ResourceHandle alive.
2600         (WebCore::SubresourceLoader::didFail): Ditto.
2601         (WebCore::SubresourceLoader::didCancel): Ditto.
2602
2603 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2604
2605         - build fix
2606
2607         * platform/network/mac/ResourceHandleMac.mm:
2608
2609 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2610
2611         Rubber stamped by Darin.
2612
2613         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2614
2615         * CMakeLists.txt:
2616         * Projects/gdk/webcore-gdk.bkl:
2617         * WebCore.vcproj/WebCore/WebCore.vcproj:
2618         * WebCore.xcodeproj/project.pbxproj:
2619         * WebCoreSources.bkl:
2620         * bridge/mac/FrameMac.mm:
2621         * bridge/win/FrameWin.cpp:
2622         * dom/XMLTokenizer.cpp:
2623         * loader/Cache.cpp:
2624         * loader/CachedResource.h:
2625         * loader/LoaderFunctions.h:
2626         * loader/icon/IconLoader.cpp:
2627         (IconLoader::startLoading):
2628         (IconLoader::didReceiveData):
2629         (IconLoader::didFinishLoading):
2630         * loader/icon/IconLoader.h:
2631         * loader/loader.cpp:
2632         (WebCore::Loader::servePendingRequests):
2633         (WebCore::Loader::receivedAllData):
2634         (WebCore::Loader::receivedResponse):
2635         (WebCore::Loader::didReceiveData):
2636         (WebCore::Loader::cancelRequests):
2637         (WebCore::Loader::jobForRequest):
2638         * loader/loader.h:
2639         * loader/mac/IconLoaderMac.mm:
2640         (IconLoader::receivedResponse):
2641         * loader/mac/LoaderFunctionsMac.mm:
2642         * loader/mac/WebLoader.h:
2643         * loader/mac/WebSubresourceLoader.h:
2644         * loader/mac/WebSubresourceLoader.mm:
2645         (WebCore::SubresourceLoader::SubresourceLoader):
2646         (WebCore::SubresourceLoader::create):
2647         * platform/gdk/FrameGdk.cpp:
2648         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2649         (WebCore::FrameGdkClientDefault::openURL):
2650         (WebCore::FrameGdkClientDefault::submitForm):
2651         (WebCore::FrameGdkClientDefault::receivedResponse):
2652         (WebCore::FrameGdkClientDefault::didReceiveData):
2653         (WebCore::FrameGdkClientDefault::receivedAllData):
2654         * platform/gdk/FrameGdk.h:
2655         * platform/gdk/TemporaryLinkStubs.cpp:
2656         (WebCore::ServeSynchronousRequest):
2657         (WebCore::ResourceHandle::assembleResponseHeaders):
2658         (WebCore::ResourceHandle::retrieveCharset):
2659         * platform/network/ResourceHandle.cpp: Added.
2660         (WebCore::ResourceHandle::ResourceHandle):
2661         (WebCore::ResourceHandle::create):
2662         (WebCore::ResourceHandle::isErrorPage):
2663         (WebCore::ResourceHandle::error):
2664         (WebCore::ResourceHandle::setError):
2665         (WebCore::ResourceHandle::responseEncoding):
2666         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2667         (WebCore::ResourceHandle::kill):
2668         (WebCore::ResourceHandle::requestHeaders):
2669         (WebCore::ResourceHandle::url):
2670         (WebCore::ResourceHandle::postData):
2671         (WebCore::ResourceHandle::method):
2672         (WebCore::ResourceHandle::client):
2673         * platform/network/ResourceHandle.h: Added.
2674         (WebCore::ResourceHandle::getInternal):
2675         * platform/network/ResourceHandleClient.h: Added.
2676         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2677         (WebCore::ResourceHandleClient::didReceiveData):
2678         (WebCore::ResourceHandleClient::didFinishLoading):
2679         (WebCore::ResourceHandleClient::receivedRedirect):
2680         (WebCore::ResourceHandleClient::receivedResponse):
2681         (WebCore::ResourceHandleClient::receivedAllData):
2682         * platform/network/ResourceHandleInternal.h: Added.
2683         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2684         * platform/network/ResourceLoader.cpp: Removed.
2685         * platform/network/ResourceLoader.h: Removed.
2686         * platform/network/ResourceLoaderClient.h: Removed.
2687         * platform/network/ResourceLoaderInternal.h: Removed.
2688         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2689         (WebCore::willSendRequest):
2690         (WebCore::didReceiveResponse):
2691         (WebCore::didReceiveData):
2692         (WebCore::didFinishLoading):
2693         (WebCore::didFail):
2694         (WebCore::willCacheResponse):
2695         (WebCore::didReceiveChallenge):
2696         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2697         (WebCore::ResourceHandle::~ResourceHandle):
2698         (WebCore::ResourceHandle::start):
2699         (WebCore::ResourceHandle::cancel):
2700         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2701         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2702         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2703         (WebCore::ResourceHandle::~ResourceHandle):
2704         (WebCore::ResourceHandle::start):
2705         (WebCore::ResourceHandle::cancel):
2706         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2707         (WebCore::ResourceHandleManager::ResourceHandleManager):
2708         (WebCore::ResourceHandleManager::get):
2709         (WebCore::ResourceHandleManager::useSimpleTransfer):
2710         (WebCore::writeCallback):
2711         (WebCore::ResourceHandleManager::downloadTimerCallback):
2712         (WebCore::ResourceHandleManager::remove):
2713         (WebCore::ResourceHandleManager::add):
2714         (WebCore::ResourceHandleManager::cancel):
2715         * platform/network/gdk/ResourceHandleManager.h: Added.
2716         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2717         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2718         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2719         * platform/network/mac/ResourceHandleMac.mm: Added.
2720         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2721         (WebCore::ResourceHandle::~ResourceHandle):
2722         (WebCore::ResourceHandle::start):
2723         (WebCore::ResourceHandle::assembleResponseHeaders):
2724         (WebCore::ResourceHandle::retrieveResponseEncoding):
2725         (WebCore::ResourceHandle::receivedResponse):
2726         (WebCore::ResourceHandle::cancel):
2727         (WebCore::ResourceHandle::redirectedToURL):
2728         (WebCore::ResourceHandle::addData):
2729         (WebCore::ResourceHandle::finishJobAndHandle):
2730         (WebCore::ResourceHandle::reportError):
2731         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2732         * platform/network/qt/ResourceHandleManager.cpp: Added.
2733         (WebCore::ResourceHandleManager::ResourceHandleManager):
2734         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2735         (WebCore::ResourceHandleManager::self):
2736         (WebCore::ResourceHandleManager::slotData):
2737         (WebCore::ResourceHandleManager::slotMimetype):
2738         (WebCore::ResourceHandleManager::slotResult):
2739         (WebCore::ResourceHandleManager::remove):
2740         (WebCore::ResourceHandleManager::add):
2741         (WebCore::ResourceHandleManager::cancel):
2742         * platform/network/qt/ResourceHandleManager.h: Added.
2743         * platform/network/qt/ResourceHandleQt.cpp: Added.
2744         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2745         (WebCore::ResourceHandle::~ResourceHandle):
2746         (WebCore::ResourceHandle::start):
2747         (WebCore::ResourceHandle::cancel):
2748         (WebCore::ResourceHandle::assembleResponseHeaders):
2749         (WebCore::ResourceHandle::retrieveResponseEncoding):
2750         (WebCore::ResourceHandle::receivedResponse):
2751         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2752         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2753         * platform/network/qt/ResourceLoaderManager.h: Removed.
2754         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2755         * platform/network/win/ResourceHandleWin.cpp: Added.
2756         (WebCore::):
2757         (WebCore::addToOutstandingJobs):
2758         (WebCore::lookupResourceHandle):
2759         (WebCore::ResourceHandleWndProc):
2760         (WebCore::initializeOffScreenResourceHandleWindow):
2761         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2762         (WebCore::ResourceHandle::~ResourceHandle):
2763         (WebCore::ResourceHandle::onHandleCreated):
2764         (WebCore::ResourceHandle::onRequestRedirected):
2765         (WebCore::ResourceHandle::onRequestComplete):
2766         (WebCore::ResourceHandle::start):
2767         (WebCore::ResourceHandle::fileLoadTimer):
2768         (WebCore::ResourceHandle::cancel):
2769         (WebCore::ResourceHandle::setHasReceivedResponse):
2770         (WebCore::ResourceHandle::hasReceivedResponse):
2771         * platform/network/win/ResourceHandleWin.h: Added.
2772         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2773         * platform/network/win/ResourceLoaderWin.h: Removed.
2774         * platform/qt/FrameQt.cpp:
2775         * platform/qt/FrameQtClient.cpp:
2776         (WebCore::FrameQtClientDefault::openURL):
2777         (WebCore::FrameQtClientDefault::submitForm):
2778         (WebCore::FrameQtClientDefault::receivedResponse):
2779         (WebCore::FrameQtClientDefault::didReceiveData):
2780         (WebCore::FrameQtClientDefault::receivedAllData):
2781         * platform/qt/FrameQtClient.h:
2782         * platform/win/TemporaryLinkStubs.cpp:
2783         (WebCore::ResourceHandle::assembleResponseHeaders):
2784         (WebCore::ResourceHandle::retrieveResponseEncoding):
2785         (WebCore::ServeSynchronousRequest):
2786         * xml/XSLTProcessor.cpp:
2787         * xml/xmlhttprequest.cpp:
2788         (WebCore::XMLHttpRequest::send):
2789         (WebCore::XMLHttpRequest::didFinishLoading):
2790         (WebCore::XMLHttpRequest::receivedRedirect):
2791         (WebCore::XMLHttpRequest::didReceiveData):
2792         * xml/xmlhttprequest.h:
2793
2794 t2006-10-29  Darin Adler  <darin@apple.com>
2795
2796         Reviewed by Maciej.
2797
2798         - eliminate use of NSArray to carry form data around
2799
2800         * WebCore.exp:
2801         * WebCore.xcodeproj/project.pbxproj:
2802         * bridge/mac/FormDataMac.h: Removed.
2803         * bridge/mac/FormDataMac.mm: Removed.
2804         * bridge/mac/FrameMac.h:
2805         * bridge/mac/WebCoreFrameBridge.h:
2806         * bridge/mac/WebCoreFrameBridge.mm:
2807         * html/HTMLFormElement.cpp:
2808         (WebCore::HTMLFormElement::submit):
2809         * loader/FormData.h:
2810         (WebCore::FormData::isEmpty):
2811         * loader/mac/FrameLoader.h:
2812         * loader/mac/FrameLoader.mm:
2813         (WebCore::FrameLoader::load):
2814         (WebCore::FrameLoader::post):
2815         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2816         (WebCore::FrameLoader::loadResourceSynchronously):
2817         * loader/mac/LoaderFunctionsMac.mm:
2818         (WebCore::ServeSynchronousRequest):
2819         * loader/mac/WebFormDataStream.h:
2820         * loader/mac/WebFormDataStream.m:
2821         (WebCore::pairRetain):
2822         (WebCore::pairRelease):
2823         (WebCore::pairEqual):
2824         (WebCore::pairHash):
2825         (WebCore::closeCurrentStream):
2826         (WebCore::scheduleWithPair):
2827         (WebCore::advanceCurrentStream):
2828         (WebCore::openNextStream):
2829         (WebCore::formCreate):
2830         (WebCore::formFinalize):
2831         (WebCore::formOpen):
2832         (WebCore::formRead):
2833         (WebCore::formCanRead):
2834         (WebCore::formClose):
2835         (WebCore::formSchedule):
2836         (WebCore::formUnschedule):
2837         (WebCore::formEventCallback):
2838         (WebCore::setHTTPBody):
2839         * loader/mac/WebSubresourceLoader.h:
2840         * loader/mac/WebSubresourceLoader.mm:
2841         (WebCore::SubresourceLoader::create):
2842         * platform/network/mac/ResourceLoaderMac.mm:
2843
2844 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2845
2846         Reviewed by Darin.
2847
2848         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2849
2850         * loader/mac/WebSubresourceLoader.h:
2851         * loader/mac/WebSubresourceLoader.mm:
2852         (WebCore::SubresourceLoader::create):
2853         * platform/network/mac/ResourceLoaderMac.mm:
2854         (WebCore::ResourceLoader::start):
2855
2856 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2857
2858         Reviewed by Darin.
2859
2860         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2861
2862         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2863
2864         * WebCore.xcodeproj/project.pbxproj:
2865         * bridge/mac/WebCoreFrameBridge.h:
2866         * loader/mac/FrameLoader.h:
2867         * loader/mac/FrameLoader.mm:
2868         * loader/mac/LoaderFunctionsMac.mm:
2869         * loader/mac/WebLoader.h:
2870         * loader/mac/WebSubresourceLoader.h:
2871         * loader/mac/WebSubresourceLoader.mm:
2872         (WebCore::SubresourceLoader::SubresourceLoader):
2873         (WebCore::SubresourceLoader::create):
2874         (WebCore::SubresourceLoader::willSendRequest):
2875         (WebCore::SubresourceLoader::didReceiveResponse):
2876         (WebCore::SubresourceLoader::didReceiveData):
2877         (WebCore::SubresourceLoader::didFinishLoading):
2878         (WebCore::SubresourceLoader::didFail):
2879         (WebCore::SubresourceLoader::didCancel):
2880         * platform/network/ResourceLoader.h:
2881         * platform/network/ResourceLoaderInternal.h:
2882         * platform/network/mac/ResourceLoaderMac.mm:
2883         (WebCore::ResourceLoader::~ResourceLoader):
2884         (WebCore::ResourceLoader::start):
2885         (WebCore::ResourceLoader::receivedResponse):
2886         (WebCore::ResourceLoader::cancel):
2887         (WebCore::ResourceLoader::redirectedToURL):
2888         (WebCore::ResourceLoader::addData):
2889         (WebCore::ResourceLoader::finishJobAndHandle):
2890         (WebCore::ResourceLoader::reportError):
2891         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2892         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2893         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2894
2895 2006-10-28  Darin Adler  <darin@apple.com>
2896
2897         Reviewed by Maciej.
2898
2899         - eliminated the use of Objective-C for the policy decider
2900           machinery, obviating the need for WebPolicyDecider,
2901           WebCoreFrameLoaderAsDelegate, and
2902           WebCoreMainResourceLoaderAsPolicyDelegate
2903
2904         - grouped the state related to policy decisions into a PolicyCheck
2905           class to simplify the FrameLoader logic
2906
2907         - removed six methods from the bridge, reducing FrameLoader's use of
2908           the bridge to a single method
2909
2910         - changed form state to always use HashMap instead of NSDictionary
2911
2912         - moved the defersLoading flag from WebView to WebCore::Page
2913           and changed code to consistently call it defersLoading rather
2914           than defersCallbacks
2915
2916         - updated for rename of PassRefPtr::release to releaseRef
2917         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2918         - cleaned up kjs_binding.h a bit
2919         - cleaned up FrameMac.h a bit
2920
2921         * loader/mac/WebPolicyDecider.h: Removed.
2922         * loader/mac/WebPolicyDecider.mm: Removed.
2923         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2924
2925         * WebCore.exp:
2926         * bindings/js/kjs_binding.cpp:
2927         (KJS::ScriptInterpreter::ScriptInterpreter):
2928         (KJS::ScriptInterpreter::wasRunByUserGesture):
2929         * bindings/js/kjs_binding.h:
2930         (KJS::ScriptInterpreter::setCurrentEvent):
2931         (KJS::ScriptInterpreter::setInlineCode):
2932         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2933         (KJS::ScriptInterpreter::getCurrentEvent):
2934         (KJS::cacheDOMObject):
2935         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2936         * bridge/AXObjectCache.h:
2937         * bridge/mac/BrowserExtensionMac.mm:
2938         (WebCore::BrowserExtensionMac::createNewWindow):
2939         * bridge/mac/FrameMac.h:
2940         * bridge/mac/FrameMac.mm:
2941         (WebCore::FrameMac::loadRequest):
2942         (WebCore::FrameMac::submitForm):
2943         (WebCore::FrameMac::urlSelected):
2944         (WebCore::FrameMac::userAgent):
2945         (WebCore::FrameMac::passMouseDownEventToWidget):
2946         (WebCore::FrameMac::handleMouseMoveEvent):
2947         * bridge/mac/PageMac.mm:
2948         (WebCore::Page::Page):
2949         * bridge/mac/WebCoreEditCommand.mm:
2950         * bridge/mac/WebCoreFrameBridge.h:
2951         * bridge/mac/WebCoreFrameBridge.mm:
2952         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2953         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2954         * css/CSSComputedStyleDeclaration.cpp:
2955         (WebCore::):
2956         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2957         * css/CSSPrimitiveValue.cpp:
2958         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2959         (WebCore::CSSPrimitiveValue::cleanup):
2960         (WebCore::CSSPrimitiveValue::cssText):
2961         * css/CSSPrimitiveValue.h:
2962         (WebCore::CSSPrimitiveValue::):
2963         * css/CSSValueList.cpp:
2964         (WebCore::CSSValueList::append):
2965         * css/cssparser.cpp:
2966         (WebCore::CSSParser::parseValue):
2967         * css/cssparser.h:
2968         * css/cssstyleselector.cpp:
2969         (WebCore::CSSStyleSelector::applyProperty):
2970         * dom/Document.cpp:
2971         (WebCore::Document::Document):
2972         (WebCore::Document::updateSelection):
2973         (WebCore::Document::implicitClose):
2974         (WebCore::Document::setFocusNode):
2975         * dom/Document.h:
2976         * editing/ReplaceSelectionCommand.h:
2977         * html/HTMLParser.cpp:
2978         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2979         * loader/mac/FrameLoader.h:
2980         (WebCore::PolicyCheck::request):
2981         * loader/mac/FrameLoader.mm:
2982         (WebCore::FrameLoader::~FrameLoader):
2983         (WebCore::FrameLoader::safeLoad):
2984         (WebCore::FrameLoader::load):
2985         (WebCore::FrameLoader::open):
2986         (WebCore::FrameLoader::stopLoading):
2987         (WebCore::setAllDefersLoading):
2988         (WebCore::FrameLoader::setDefersLoading):
2989         (WebCore::FrameLoader::willSendRequest):
2990         (WebCore::FrameLoader::receivedMainResourceError):
2991         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2992         (WebCore::FrameLoader::commitProvisionalLoad):
2993         (WebCore::FrameLoader::checkNavigationPolicy):
2994         (WebCore::FrameLoader::checkContentPolicy):
2995         (WebCore::FrameLoader::cancelContentPolicyCheck):
2996         (WebCore::FrameLoader::stopPolicyCheck):
2997         (WebCore::FrameLoader::checkNewWindowPolicy):
2998         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2999         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3000         (WebCore::FrameLoader::continueAfterContentPolicy):
3001         (WebCore::FrameLoader::continueAfterWillSubmitForm):
3002         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
3003         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
3004         (WebCore::FrameLoader::closeDocument):
3005         (WebCore::FrameLoader::transitionToCommitted):
3006         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
3007         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
3008         (WebCore::FrameLoader::post):
3009         (WebCore::FrameLoader::detachFromParent):
3010         (WebCore::FrameLoader::addExtraFieldsToRequest):
3011         (WebCore::PolicyCheck::PolicyCheck):
3012         (WebCore::PolicyCheck::clear):
3013         (WebCore::PolicyCheck::set):
3014         (WebCore::PolicyCheck::call):
3015         (WebCore::PolicyCheck::dropRequest):
3016         (WebCore::FrameLoaderClient::~FrameLoaderClient):
3017         * loader/mac/WebFormState.h:
3018         * loader/mac/WebFormState.mm:
3019         * loader/mac/WebFrameLoaderClient.h:
3020         * loader/mac/WebLoader.h:
3021         (WebCore::WebResourceLoader::defersLoading):
3022         * loader/mac/WebLoader.mm:
3023         (WebCore::WebResourceLoader::WebResourceLoader):
3024         (WebCore::WebResourceLoader::load):
3025         (WebCore::WebResourceLoader::setDefersLoading):
3026         * loader/mac/WebMainResourceLoader.h:
3027         * loader/mac/WebMainResourceLoader.mm:
3028         (WebCore::MainResourceLoader::MainResourceLoader):
3029         (WebCore::MainResourceLoader::releaseDelegate):
3030         (WebCore::MainResourceLoader::didCancel):
3031         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
3032         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
3033         (WebCore::MainResourceLoader::willSendRequest):
3034         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
3035         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3036         (WebCore::MainResourceLoader::didReceiveResponse):
3037         (WebCore::MainResourceLoader::didReceiveData):
3038         (WebCore::MainResourceLoader::didFinishLoading):
3039         (WebCore::MainResourceLoader::didFail):
3040         (WebCore::MainResourceLoader::loadNow):
3041         (WebCore::MainResourceLoader::load):
3042         (WebCore::MainResourceLoader::setDefersLoading):
3043         * page/Frame.cpp:
3044         (WebCore::Frame::paint):
3045         * page/FrameView.cpp:
3046         (WebCore::FrameView::layout):
3047         * page/FrameView.h:
3048         * page/Page.cpp:
3049         (WebCore::Page::setDefersLoading):
3050         * page/Page.h:
3051         (WebCore::Page::defersLoading):
3052         * platform/DeprecatedString.h:
3053         * platform/DeprecatedStringList.h:
3054         * platform/FontFallbackList.h:
3055         * platform/PlatformKeyboardEvent.h:
3056         * platform/PlatformMouseEvent.h:
3057         * platform/PlatformWheelEvent.h:
3058         * platform/mac/ClipboardMac.h:
3059         * platform/mac/ClipboardMac.mm:
3060         (WebCore::ClipboardMac::setDragImage):
3061         (WebCore::ClipboardMac::dragNSImage):
3062         (WebCore::ClipboardMac::sourceOperation):
3063         (WebCore::ClipboardMac::destinationOperation):
3064         * rendering/RenderObject.cpp:
3065         (WebCore::RenderObject::setStyle):
3066         * rendering/break_lines.cpp:
3067         (WebCore::nextBreakablePosition):
3068
3069 2006-10-28  Adam Roben  <aroben@apple.com>
3070
3071         Reviewed by Maciej.
3072
3073         Fix layout tests that broke after r17399. Mitz discovered that the
3074         failures were caused by HitTestResult::m_point being uninitialized
3075         much of the time. HitTestResults are now always constructed with a
3076         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
3077         point instead of being passed one explicitly.
3078
3079         * WebCore.exp: Change constructor symbol.
3080         * bridge/mac/FrameMac.mm:
3081         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
3082         hitTest().
3083         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
3084         * bridge/mac/WebCoreAXObject.mm:
3085         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
3086         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
3087         * dom/Document.cpp:
3088         (WebCore::Document::elementFromPoint): Ditto.
3089         (WebCore::Document::prepareMouseEvent): Ditto.
3090         * page/Frame.cpp:
3091         (WebCore::Frame::isPointInsideSelection): Ditto.
3092         (WebCore::Frame::hitTestResultAtPoint): Ditto.
3093         * page/FrameView.cpp:
3094         (WebCore::FrameView::handleWheelEvent): Ditto.
3095         * rendering/HitTestResult.cpp:
3096         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
3097         passed point.
3098         * rendering/HitTestResult.h: Update constructor declaration.
3099         * rendering/RenderLayer.cpp:
3100         (WebCore::RenderLayer::autoscroll): Update to new constructor and
3101         hitTest().
3102         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
3103         HitTestResult instead of being passed one.
3104         (WebCore::RenderLayer::hitTestLayer): Ditto.
3105         * rendering/RenderLayer.h: Update declarations.
3106
3107 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
3108
3109         Reviewed by Anders.
3110
3111         Fix Qt/Linux build.
3112
3113         * CMakeLists.txt:
3114         * platform/qt/FrameQtClient.cpp:
3115         (WebCore::numRequests):
3116         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
3117         * platform/qt/PopupMenuQt.cpp:
3118         (WebCore::PopupMenu::updateFromElement):
3119
3120 2006-10-28  David Carson  <dacarson@gmail.com>
3121
3122         Tweaked by Sam. Reviewed by Brady.
3123
3124         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
3125         Initialize m_modifyBiasSet to false, as it sometimes gets
3126         used before it has been initalized.
3127
3128         * editing/SelectionController.cpp:
3129         (WebCore::SelectionController::SelectionController):
3130
3131 2006-10-28  Beth Dakin  <bdakin@apple.com>
3132
3133         Reviewed by Darin.
3134
3135         This is the WebCore half of pushing elementAtPoint and the backend
3136         of WebElementDictionary into WebCore. Most of the changes below are
3137         to accommodate one of the following:
3138
3139         -NodeInfo is now a stand-alone class called HitTestResult.
3140                 Previously it was defined in RenderObject.h, but not for
3141                 any particular reason. The WebElementDictionary
3142                 functionality that was pushed into WebCore has been pushed
3143                 specifically into the this class. In fact,
3144                 WebElementDictionary now keeps a HitTestResult as a member
3145                 varibale.
3146
3147         -The enumeration AccessPolicy is now called
3148                 ClipboardAccessPolicy and is defined in its own header. It
3149                 was previously defined in ClipboardMac.h, but is now
3150                 defined independently to avoid including ClipboardMac.h
3151                 from within FrameMac.h since FrameMac.h is now included in
3152                 WebElementDictionary.m in WebKit.
3153
3154         -Element now has a virtual target() for the sake of
3155                 NodeInfo::targetFrame()
3156
3157         * WebCore.exp: Several WebCore functions are newly called from
3158         WebKit, so they have been added here.
3159         * WebCore.xcodeproj/project.pbxproj:
3160         * bindings/objc/DOM.mm: Must include Image.h because of adjustments
3161         to ClipboardMac.
3162         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
3163         * bridge/mac/FrameMac.mm:
3164         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy
3165         and HitTestResult changes.
3166         (WebCore::FrameMac::eventMayStartDrag): Same.
3167         (WebCore::FrameMac::handleMouseMoveEvent): Same.
3168         (WebCore::FrameMac::dispatchCPPEvent): Same.
3169         (WebCore::FrameMac::mayDHTMLCut): Same.
3170         (WebCore::FrameMac::mayDHTMLCopy): Same.
3171         (WebCore::FrameMac::mayDHTMLPaste): Same.
3172         (WebCore::FrameMac::tryDHTMLCut): Same
3173         (WebCore::FrameMac::tryDHTMLCopy): Same.
3174         (WebCore::FrameMac::tryDHTMLPaste): Same.
3175         * bridge/mac/WebCoreAXObject.mm:
3176         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to
3177         HitTestResult changes.
3178         (-[WebCoreAXObject accessibilityHitTest:]): Same.
3179         * bridge/mac/WebCoreFrameBridge.h: Same.
3180         * bridge/mac/WebCoreFrameBridge.mm:
3181         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for
3182         ClipboardAccessPolicy changes.
3183         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
3184         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
3185         * dom/Document.cpp:
3186         (WebCore::Document::elementFromPoint): Adjust for HitTestResult
3187         changes.
3188         (WebCore::Document::prepareMouseEvent): Same.
3189         * dom/Element.h:
3190         (WebCore::Element::target): Now has a virtual target()
3191         * html/HTMLAnchorElement.h: Same.
3192         * html/HTMLAreaElement.cpp:
3193         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult
3194         changes.
3195         * html/HTMLAreaElement.h: Virtual target()
3196         * html/HTMLBaseElement.h:
3197         (WebCore::HTMLBaseElement::target): Same.
3198         * html/HTMLFormElement.h: Same.
3199         * html/HTMLLinkElement.h: Same.
3200         * html/HTMLMapElement.cpp:
3201         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult
3202         changes.
3203         * html/HTMLMapElement.h: Same.
3204         * page/Frame.cpp:
3205         (WebCore::Frame::isPointInsideSelection): Same.
3206         (WebCore::Frame::hitTestResultAtPoint): Same.
3207         * page/Frame.h: Same.
3208         * page/FrameView.cpp:
3209         (WebCore::FrameView::handleWheelEvent): Same.
3210         * platform/mac/ClipboardAccessPolicy.h: Added.
3211         (WebCore::):
3212         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy,
3213         include ClipboardAccessPolicy.h, and rename AccessPolicy to
3214         ClipboardAccessPolicy.
3215         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
3216         (WebCore::ClipboardMac::ClipboardMac):
3217         (WebCore::ClipboardMac::setAccessPolicy):
3218         (WebCore::ClipboardMac::clearData):
3219         (WebCore::ClipboardMac::clearAllData):
3220         (WebCore::ClipboardMac::getData):
3221         (WebCore::ClipboardMac::setData):
3222         (WebCore::ClipboardMac::types):
3223         (WebCore::ClipboardMac::setDragImage):
3224         (WebCore::ClipboardMac::setDropEffect):
3225         (WebCore::ClipboardMac::setEffectAllowed):
3226         * rendering/EllipsisBox.cpp:
3227         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult
3228         changes.
3229         * rendering/EllipsisBox.h:
3230         * rendering/HitTestResult.cpp: Added.
3231         (WebCore::HitTestResult::HitTestResult):
3232         (WebCore::HitTestResult::~HitTestResult):
3233         (WebCore::HitTestResult::operator=):
3234         (WebCore::HitTestResult::setInnerNode):
3235         (WebCore::HitTestResult::setInnerNonSharedNode):
3236         (WebCore::HitTestResult::setURLElement):
3237         (WebCore::HitTestResult::setScrollbar):
3238         (WebCore::HitTestResult::targetFrame):
3239         (WebCore::HitTestResult::boundingBox):
3240         (WebCore::HitTestResult::isSelected):
3241         (WebCore::HitTestResult::title):
3242         * rendering/HitTestResult.h: Added.
3243         (WebCore::HitTestResult::readonly):
3244         (WebCore::HitTestResult::active):
3245         (WebCore::HitTestResult::mouseMove):
3246         (WebCore::HitTestResult::innerNode):
3247         (WebCore::HitTestResult::innerNonSharedNode):
3248         (WebCore::HitTestResult::point):
3249         (WebCore::HitTestResult::URLElement):
3250         (WebCore::HitTestResult::scrollbar):
3251         (WebCore::HitTestResult::setPoint):
3252         (WebCore::HitTestResult::setReadonly):
3253         (WebCore::HitTestResult::setActive):
3254         (WebCore::HitTestResult::setMouseMove):
3255         * rendering/InlineBox.cpp:
3256         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
3257         * rendering/InlineBox.h: Same.
3258         * rendering/InlineFlowBox.cpp:
3259         (WebCore::InlineFlowBox::nodeAtPoint): Same.
3260         * rendering/InlineFlowBox.h: Same.
3261         * rendering/InlineTextBox.cpp:
3262         (WebCore::InlineTextBox::nodeAtPoint): Same.
3263         * rendering/InlineTextBox.h: Same.
3264         * rendering/RenderBlock.cpp:
3265         (WebCore::RenderBlock::isPointInScrollbar): Same.
3266         (WebCore::RenderBlock::nodeAtPoint): Same.
3267         * rendering/RenderBlock.h: Same.
3268         * rendering/RenderBox.cpp:
3269         (WebCore::RenderBox::nodeAtPoint): Same.
3270         * rendering/RenderBox.h: Same.
3271         * rendering/RenderFlow.cpp:
3272         (WebCore::RenderFlow::hitTestLines): Same.
3273         * rendering/RenderFlow.h: Same.
3274         * rendering/RenderForeignObject.cpp:
3275         (WebCore::RenderForeignObject::nodeAtPoint): Same.
3276         * rendering/RenderForeignObject.h: Same.
3277         * rendering/RenderFrameSet.cpp:
3278         (WebCore::RenderFrameSet::nodeAtPoint): Same.
3279         * rendering/RenderFrameSet.h: Same.
3280         * rendering/RenderImage.cpp:
3281         (WebCore::RenderImage::nodeAtPoint): Same.
3282         * rendering/RenderImage.h: Same.
3283         * rendering/RenderInline.cpp:
3284         (WebCore::RenderInline::nodeAtPoint): Same.
3285         * rendering/RenderInline.h: Same.
3286         * rendering/RenderLayer.cpp:
3287         (WebCore::RenderLayer::autoscroll): Same.
3288         (WebCore::RenderLayer::hitTest): Same.
3289         (WebCore::RenderLayer::hitTestLayer): Same.
3290         (WebCore::RenderLayer::updateHoverActiveState): Same.
3291         * rendering/RenderLayer.h: Same.
3292         * rendering/RenderListBox.cpp:
3293         (WebCore::RenderListBox::isPointInScrollbar): Same.
3294         * rendering/RenderListBox.h: Same.
3295         * rendering/RenderObject.cpp:
3296         (WebCore::RenderObject::hitTest): Same.
3297         (WebCore::RenderObject::setInnerNode): Same.
3298         (WebCore::RenderObject::nodeAtPoint): Same.
3299         * rendering/RenderObject.h: Remove NodeInfo class and forward
3300         declare HitTestResult.
3301         * rendering/RenderPath.cpp:
3302         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult
3303         changes.
3304         * rendering/RenderPath.h: Same.
3305         * rendering/RenderSVGImage.cpp:
3306         (WebCore::RenderSVGImage::nodeAtPoint): Same.
3307         * rendering/RenderSVGImage.h: Same
3308         * rendering/RenderSVGText.cpp:
3309         (WebCore::RenderSVGText::nodeAtPoint): Same.
3310         * rendering/RenderSVGText.h: Same.
3311         * rendering/RenderTableRow.cpp:
3312         (WebCore::RenderTableRow::nodeAtPoint): Same.
3313         * rendering/RenderTableRow.h: Same.
3314         * rendering/RenderTableSection.cpp:
3315         (WebCore::RenderTableSection::nodeAtPoint): Same.
3316         * rendering/RenderTableSection.h: Same.
3317         * rendering/RenderText.h: Same.
3318         (WebCore::RenderText::nodeAtPoint): Same.
3319         * rendering/RenderTextControl.cpp:
3320         (WebCore::RenderTextControl::nodeAtPoint): Same.
3321         * rendering/RenderTextControl.h: Same.
3322         * rendering/RootInlineBox.cpp:
3323         (WebCore::RootInlineBox::nodeAtPoint): Same.
3324         * rendering/RootInlineBox.h: Same.
3325
3326 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3327
3328         Reviewed by Anders.
3329
3330         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
3331         impact of fixing it again.
3332
3333         * bridge/mac/FrameMac.mm:
3334         (WebCore::FrameMac::clear):
3335
3336 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3337
3338         Reviewed by John & Adam.
3339
3340         - assorted speedups to fix perf regression from fixing correctness regression
3341
3342         * WebCore.exp: exported new methods.
3343         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
3344         * bridge/mac/WebCoreFrameBridge.h:
3345         * bridge/mac/WebCoreFrameBridge.mm:
3346         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
3347         * loader/CachedResource.h:
3348         * loader/mac/CachedResourceMac.mm: Added.
3349         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
3350         now cached in the CachedObject.
3351         * loader/mac/FrameLoader.h:
3352         * loader/mac/FrameLoader.mm:
3353         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
3354         the WebKit side do faster dispatch for clients that implement the fast path delegate.
3355         * loader/mac/LoaderFunctionsMac.mm:
3356         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
3357         just call loadedResourceFromMemoryCache.
3358         * loader/mac/WebFrameLoaderClient.h:
3359
3360 2006-10-27  Oliver Hunt  <oliver@apple.com>
3361
3362         Reviewed by Maciej.
3363
3364         build fix
3365
3366         * dom/Document.cpp:
3367         (WebCore::Document::referrer):
3368
3369 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3370
3371         Reviewed by Maciej.
3372
3373         Moved some WebCoreFrameBridge functions into FrameLoader.
3374
3375         I had to make FrameLoader.h capable of compiling in C++-only source files
3376         by adding some forward declarations and __OBJC__ #ifdefs.
3377
3378         * WebCore.exp:
3379         * bridge/mac/FrameMac.h:
3380         * bridge/mac/FrameMac.mm:
3381         (WebCore::FrameMac::createEmptyDocument):
3382         (WebCore::FrameMac::tokenizerProcessedData):
3383         * bridge/mac/WebCoreFrameBridge.h:
3384         * bridge/mac/WebCoreFrameBridge.mm:
3385         * dom/Document.cpp:
3386         (WebCore::Document::processHttpEquiv):
3387         (WebCore::Document::referrer):
3388         * loader/LoaderFunctions.h:
3389         * loader/mac/FrameLoader.h:
3390         * loader/mac/FrameLoader.mm:
3391         (WebCore::numRequests):
3392         (WebCore::FrameLoader::numPendingOrLoadingRequests):
3393         (WebCore::FrameLoader::isReloading):
3394         (WebCore::FrameLoader::referrer):
3395         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
3396         (WebCore::FrameLoader::startLoadingResource):
3397         * loader/mac/LoaderFunctionsMac.mm:
3398         (WebCore::CheckIfReloading):
3399         * page/Frame.h:
3400         * page/FrameTree.cpp:
3401         (WebCore::FrameTree::isDescendantOf):
3402         (WebCore::FrameTree::traverseNext):
3403         * page/FrameTree.h:
3404         * platform/network/mac/ResourceLoaderMac.mm:
3405         (WebCore::ResourceLoader::start):
3406
3407 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3408
3409         Reviewed by Darin.
3410
3411         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
3412
3413         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
3414
3415         * editing/DeleteButtonController.cpp:
3416         (WebCore::isDeletableElement):
3417         (WebCore::enclosingDeletableElement):
3418         (WebCore::DeleteButtonController::respondToChangedSelection):
3419
3420 2006-10-27  John Sullivan  <sullivan@apple.com>
3421
3422         Reviewed by Kevin Decker
3423
3424         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
3425         you haven't not finished reading this.
3426
3427         * rendering/InlineTextBox.h:
3428         * rendering/InlineTextBox.cpp:
3429         (WebCore::InlineTextBox::paint):
3430         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
3431         considered also.
3432         (WebCore::InlineTextBox::paintDocumentMarkers):
3433         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
3434         markers should be painted, instead of a marker type. This avoids walking the collection of
3435         markers multiple times back to back. Now handles grammar markers.
3436
3437 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3438
3439         Reviewed by Beth.
3440
3441         Renamed Copy Files to Copy Generated Headers.
3442         Copy 4 DOM*Internal.h headers.
3443
3444         * WebCore.xcodeproj/project.pbxproj:
3445         * bindings/scripts/CodeGeneratorObjC.pm:
3446
3447 2006-10-27  John Sullivan  <sullivan@apple.com>
3448
3449         Reviewed by Anders
3450
3451         * WebCore.exp:
3452         exported symbol for FrameMac->advanceToNextSpelling()
3453
3454         * bridge/mac/WebCoreFrameBridge.h:
3455         * bridge/mac/WebCoreFrameBridge.mm:
3456         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
3457
3458 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
3459
3460         Reviewed by harrison
3461
3462         <http://bugs.webkit.org/show_bug.cgi?id=11423>
3463         REGRESSION: First newline missing from textarea's value
3464
3465         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
3466
3467         Before my change in r17223, return (an InsertLineBreak) would insert a '\n'
3468         (the line break) then a br to prevent the '\n' from collapsing, since the
3469         insertion is being done at the end of a block (the textarea's shadow div).  Then,
3470         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".
3471         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed
3472         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would
3473         serialize as "foobar" because when serializing RenderTextControl intentionally asks
3474         textContent to not convert brs to newlines.  It seems to think that the only brs in
3475         the shadow div will be placeholders or collapsed.
3476
3477         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak
3478         to insert two '\n's when at the end of a block in white-space:pre text.  This alone
3479         would have fixed the bug, but introduced a new one, because foo, return, bar would
3480         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second
3481         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to
3482         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as
3483         a br or '\n' that will collapse (become superfluous) when content is inserted just
3484         before it.
3485
3486         * editing/CompositeEditCommand.cpp:
3487         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
3488         a br or '\n' if content inserted just before it will cause it to collapse.
3489         * editing/CompositeEditCommand.h:
3490         * editing/InsertLineBreakCommand.cpp:
3491         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
3492         to prevent a collapse as was used for the line break.  Fixed comments.
3493         * editing/InsertTextCommand.cpp:
3494         (WebCore::InsertTextCommand::input): Call the renamed function.
3495
3496 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3497
3498         Reviewed by Brady.
3499
3500         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
3501         String became an empty NSString *, instead of nil. This will become important
3502         as we start using this conversion more.
3503
3504         Added work-around for AppKit crash that semantic accuracy revealed.
3505
3506         No testcase because I don't think there's a way to reflect this change
3507         in a webpage yet.
3508
3509         * platform/PlatformString.h:
3510         (WebCore::String::operator NSString*):
3511         * platform/mac/TextFieldMac.mm:
3512         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3513
3514 2006-10-27  David Harrison  <harrison@apple.com>
3515
3516         Reviewed by Maciej,
3517
3518         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
3519
3520         * bridge/mac/WebCoreAXObject.mm:
3521         (blockquoteLevel):
3522         Calculate and return the blockquote level of the element.
3523
3524         (AXAttributeStringSetBlockquoteLevel):
3525         Add, if non-zero, or clear the block quote level attribute.
3526
3527         (AXAttributedStringAppendText):