8dc230d3b29e98a8286ef2ee7de19294b6db2384
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-30  Darin Adler  <darin@apple.com>
2
3         Reviewed by Anders.
4
5         - remove BrowserExtension
6
7         * WebCore.vcproj/WebCore/WebCore.vcproj:
8         * WebCore.xcodeproj/project.pbxproj:
9         * bindings/js/kjs_window.cpp:
10         (KJS::createNewWindow):
11         (KJS::WindowFunc::callAsFunction):
12         * bridge/BrowserExtension.h: Removed.
13         * bridge/mac/BrowserExtensionMac.h: Removed.
14         * bridge/mac/BrowserExtensionMac.mm: Removed.
15         * bridge/mac/FrameMac.mm:
16         (WebCore::FrameMac::FrameMac):
17         (WebCore::FrameMac::submitForm):
18         (WebCore::FrameMac::urlSelected):
19         * bridge/win/BrowserExtensionWin.cpp: Removed.
20         * bridge/win/BrowserExtensionWin.h: Removed.
21         * bridge/win/FrameWin.cpp:
22         (WebCore::FrameWin::FrameWin):
23         * loader/FrameLoader.cpp:
24         (WebCore::FrameLoader::createWindow):
25         * loader/FrameLoader.h:
26         * loader/icon/IconLoader.cpp:
27         * loader/mac/FrameLoaderMac.mm:
28         (WebCore::FrameLoader::safeLoad):
29         (WebCore::FrameLoader::load):
30         (WebCore::FrameLoader::createWindow):
31         * page/Frame.cpp:
32         (WebCore::Frame::urlSelected):
33         (WebCore::Frame::requestFrame):
34         (WebCore::Frame::submitForm):
35         (WebCore::Frame::scheduleHistoryNavigation):
36         (WebCore::Frame::redirectionTimerFired):
37         * page/Frame.h:
38         * page/FrameLoadRequest.h:
39         (WebCore::FrameLoadRequest::FrameLoadRequest):
40         (WebCore::FrameLoadRequest::isEmpty):
41         (WebCore::FrameLoadRequest::resourceRequest):
42         (WebCore::FrameLoadRequest::frameName):
43         (WebCore::FrameLoadRequest::setFrameName):
44         * page/FramePrivate.h:
45         (WebCore::FramePrivate::FramePrivate):
46         (WebCore::FramePrivate::~FramePrivate):
47         * platform/gdk/BrowserExtensionGdk.h: Removed.
48         * platform/gdk/FrameGdk.cpp:
49         (WebCore::FrameGdk::FrameGdk):
50         * platform/gdk/TemporaryLinkStubs.cpp:
51         * platform/network/ResourceRequest.h:
52         (WebCore::ResourceRequest::isEmpty):
53
54 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
55
56         Reviewed by Oliver.
57
58         Modified from original due to earlier reversion
59
60         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
61
62         Better SVG integration in WebKit, Part I.
63
64         The patch is mostly about creating a new platform/graphics directory, and
65         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
66         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
67         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
68
69         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
70         All details of the patch, and upcoming patches can be found in the bug report.
71
72         * CMakeLists.txt:
73         * WebCore.xcodeproj/project.pbxproj:
74         * graphics/svg/SVGResource.cpp: Removed.
75         * graphics/svg/SVGResourceClipper.cpp: Removed.
76         * graphics/svg/SVGResourceClipper.h: Removed.
77         * graphics/svg/SVGResourceImage.h: Removed.
78         * graphics/svg/SVGResourceListener.h: Removed.
79         * graphics/svg/SVGResourceMarker.cpp: Removed.
80         * graphics/svg/SVGResourceMarker.h: Removed.
81         * graphics/svg/SVGResourceMasker.cpp: Removed.
82         * graphics/svg/SVGResourceMasker.h: Removed.
83         * kcanvas/KCanvasClipper.cpp: Removed.
84         * kcanvas/KCanvasClipper.h: Removed.
85         * kcanvas/KCanvasCreator.cpp: Removed.
86         * kcanvas/KCanvasCreator.h: Removed.
87         * kcanvas/KCanvasFilters.cpp:
88         (WebCore::getFilterById):
89         * kcanvas/KCanvasFilters.h:
90         * kcanvas/KCanvasImage.h: Removed.
91         * kcanvas/KCanvasMarker.cpp: Removed.
92         * kcanvas/KCanvasMarker.h: Removed.
93         * kcanvas/KCanvasMasker.cpp: Removed.
94         * kcanvas/KCanvasMasker.h: Removed.
95         * kcanvas/KCanvasResource.cpp: Removed.
96         * kcanvas/KCanvasResource.h: Removed.
97         * kcanvas/KCanvasResourceListener.h: Removed.
98         * kcanvas/KCanvasTreeDebug.cpp:
99         (WebCore::writeRenderResources):
100         * kcanvas/device/KRenderingDevice.h:
101         * kcanvas/device/KRenderingPaintServer.h:
102         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
103         * kcanvas/device/KRenderingPaintServerGradient.cpp:
104         (WebCore::KRenderingPaintServerGradient::listener):
105         (WebCore::KRenderingPaintServerGradient::setListener):
106         * kcanvas/device/KRenderingPaintServerGradient.h:
107         * kcanvas/device/KRenderingPaintServerPattern.cpp:
108         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
109         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
110         (WebCore::KRenderingPaintServerPattern::tile):
111         (WebCore::KRenderingPaintServerPattern::setTile):
112         (WebCore::KRenderingPaintServerPattern::listener):
113         (WebCore::KRenderingPaintServerPattern::setListener):
114         * kcanvas/device/KRenderingPaintServerPattern.h:
115         * kcanvas/device/KRenderingPaintServerSolid.h:
116         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
117         * kcanvas/device/qt/KCanvasClipperQt.h:
118         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
119         (WebCore::KRenderingDeviceQt::contextForImage):
120         (WebCore::KRenderingDeviceQt::createResource):
121         (WebCore::KRenderingDeviceQt::createPaintServer):
122         * kcanvas/device/qt/KRenderingDeviceQt.h:
123         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
124         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
125         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
126         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
127         * kcanvas/device/qt/RenderPathQt.h: Removed.
128         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
129         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
130         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
131         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
132         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
133         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
134         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
135         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
136         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
137         (WebCore::KRenderingDeviceQuartz::contextForImage):
138         (WebCore::KRenderingDeviceQuartz::createPaintServer):
139         (WebCore::KRenderingDeviceQuartz::createResource):
140         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
141         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
142         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
143         (WebCore::KRenderingPaintServerGradientQuartz::setup):
144         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
145         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
146         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
147         (WebCore::patternCallback):
148         (WebCore::KRenderingPaintServerPatternQuartz::setup):
149         * kcanvas/device/quartz/QuartzSupport.mm:
150         * ksvg2/misc/KCanvasRenderingStyle.cpp:
151         (WebCore::sharedSolidPaintServer):
152         * ksvg2/svg/SVGClipPathElement.cpp:
153         (WebCore::SVGClipPathElement::SVGClipPathElement):
154         (WebCore::SVGClipPathElement::~SVGClipPathElement):
155         (WebCore::SVGClipPathElement::canvasResource):
156         * ksvg2/svg/SVGClipPathElement.h:
157         * ksvg2/svg/SVGFEImageElement.cpp:
158         * ksvg2/svg/SVGFilterElement.cpp:
159         (WebCore::SVGFilterElement::SVGFilterElement):
160         (WebCore::SVGFilterElement::~SVGFilterElement):
161         (WebCore::SVGFilterElement::canvasResource):
162         * ksvg2/svg/SVGFilterElement.h:
163         * ksvg2/svg/SVGGradientElement.cpp:
164         (WebCore::SVGGradientElement::SVGGradientElement):
165         (WebCore::SVGGradientElement::~SVGGradientElement):
166         (WebCore::SVGGradientElement::canvasResource):
167         (WebCore::SVGGradientElement::resourceNotification):
168         * ksvg2/svg/SVGGradientElement.h:
169         * ksvg2/svg/SVGImageElement.cpp:
170         * ksvg2/svg/SVGLinearGradientElement.cpp:
171         (WebCore::SVGLinearGradientElement::buildGradient):
172         * ksvg2/svg/SVGLinearGradientElement.h:
173         * ksvg2/svg/SVGMarkerElement.cpp:
174         (WebCore::SVGMarkerElement::SVGMarkerElement):
175         (WebCore::SVGMarkerElement::~SVGMarkerElement):
176         (WebCore::SVGMarkerElement::canvasResource):
177         * ksvg2/svg/SVGMarkerElement.h:
178         * ksvg2/svg/SVGMaskElement.cpp:
179         (WebCore::SVGMaskElement::SVGMaskElement):
180         (WebCore::SVGMaskElement::~SVGMaskElement):
181         (WebCore::SVGMaskElement::drawMaskerContent):
182         (WebCore::SVGMaskElement::canvasResource):
183         * ksvg2/svg/SVGMaskElement.h:
184         * ksvg2/svg/SVGPatternElement.cpp:
185         (WebCore::SVGPatternElement::SVGPatternElement):
186         (WebCore::SVGPatternElement::~SVGPatternElement):
187         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
188         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
189         (WebCore::SVGPatternElement::canvasResource):
190         * ksvg2/svg/SVGPatternElement.h:
191         * ksvg2/svg/SVGRadialGradientElement.cpp:
192         (WebCore::SVGRadialGradientElement::buildGradient):
193         * ksvg2/svg/SVGRadialGradientElement.h:
194         * ksvg2/svg/SVGStyledElement.h:
195         (WebCore::SVGStyledElement::canvasResource):
196         * platform/GraphicsContext.cpp: Removed.
197         * platform/GraphicsContext.h: Removed.
198         * platform/GraphicsTypes.cpp: Removed.
199         * platform/GraphicsTypes.h: Removed.
200         * platform/graphics/GraphicsContext.cpp:
201         (WebCore::GraphicsContextState::GraphicsContextState):
202         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
203         (WebCore::GraphicsContext::createGraphicsContextPrivate):
204         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
205         (WebCore::GraphicsContext::save):
206         (WebCore::GraphicsContext::restore):
207         (WebCore::GraphicsContext::font):
208         (WebCore::GraphicsContext::setFont):
209         (WebCore::GraphicsContext::pen):
210         (WebCore::GraphicsContext::setPen):
211         (WebCore::GraphicsContext::setFillColor):
212         (WebCore::GraphicsContext::fillColor):
213         (WebCore::GraphicsContext::updatingControlTints):
214         (WebCore::GraphicsContext::setUpdatingControlTints):
215         (WebCore::GraphicsContext::setPaintingDisabled):
216         (WebCore::GraphicsContext::paintingDisabled):
217         (WebCore::GraphicsContext::drawImage):
218         (WebCore::GraphicsContext::drawText):
219         (WebCore::GraphicsContext::drawHighlightForText):
220         (WebCore::GraphicsContext::initFocusRing):
221         (WebCore::GraphicsContext::clearFocusRing):
222         (WebCore::GraphicsContext::focusRingBoundingRect):
223         (WebCore::GraphicsContext::addFocusRingRect):
224         (WebCore::GraphicsContext::focusRingWidth):
225         (WebCore::GraphicsContext::focusRingOffset):
226         (WebCore::GraphicsContext::focusRingRects):
227         (WebCore::GraphicsContext::drawTiledImage):
228         * platform/graphics/GraphicsContext.h:
229         * platform/graphics/GraphicsTypes.cpp:
230         (WebCore::):
231         (WebCore::parseCompositeOperator):
232         (WebCore::compositeOperatorName):
233         (WebCore::parseLineCap):
234         (WebCore::lineCapName):
235         (WebCore::parseLineJoin):
236         (WebCore::lineJoinName):
237         * platform/graphics/GraphicsTypes.h:
238         (WebCore::):
239         * platform/graphics/svg/SVGResource.cpp: Added.
240         (WebCore::SVGResource::SVGResource):
241         (WebCore::SVGResource::~SVGResource):
242         (WebCore::SVGResource::invalidate):
243         (WebCore::SVGResource::addClient):
244         (WebCore::SVGResource::clients):
245         (WebCore::SVGResource::idInRegistry):
246         (WebCore::SVGResource::setIdInRegistry):
247         (WebCore::SVGResource::externalRepresentation):
248         (WebCore::getResourceById):
249         (WebCore::getPaintServerById):
250         (WebCore::operator<<):
251         * platform/graphics/svg/SVGResource.h: Added.
252         (WebCore::):
253         (WebCore::SVGResource::isPaintServer):
254         (WebCore::SVGResource::isFilter):
255         (WebCore::SVGResource::isClipper):
256         (WebCore::SVGResource::isMarker):
257         (WebCore::SVGResource::isMasker):
258         (WebCore::SVGResourceListener::~SVGResourceListener):
259         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
260         (WebCore::SVGResourceClipper::SVGResourceClipper):
261         (WebCore::SVGResourceClipper::~SVGResourceClipper):
262         (WebCore::SVGResourceClipper::resetClipData):
263         (WebCore::SVGResourceClipper::addClipData):
264         (WebCore::SVGResourceClipper::clipData):
265         (WebCore::SVGResourceClipper::externalRepresentation):
266         (WebCore::operator<<):
267         (WebCore::getClipperById):
268         * platform/graphics/svg/SVGResourceClipper.h: Added.
269         (WebCore::ClipDataList::addPath):
270         (WebCore::SVGResourceClipper::isClipper):
271         * platform/graphics/svg/SVGResourceImage.h: Added.
272         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
273         (WebCore::SVGResourceMarker::SVGResourceMarker):
274         (WebCore::SVGResourceMarker::~SVGResourceMarker):
275         (WebCore::SVGResourceMarker::setMarker):
276         (WebCore::SVGResourceMarker::setRef):
277         (WebCore::SVGResourceMarker::draw):
278         (WebCore::SVGResourceMarker::externalRepresentation):
279         (WebCore::getMarkerById):
280         * platform/graphics/svg/SVGResourceMarker.h: Added.
281         (WebCore::SVGResourceMarker::refX):
282         (WebCore::SVGResourceMarker::refY):
283         (WebCore::SVGResourceMarker::setAngle):
284         (WebCore::SVGResourceMarker::setAutoAngle):
285         (WebCore::SVGResourceMarker::angle):
286         (WebCore::SVGResourceMarker::setUseStrokeWidth):
287         (WebCore::SVGResourceMarker::useStrokeWidth):
288         (WebCore::SVGResourceMarker::isMarker):
289         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
290         (WebCore::SVGResourceMasker::SVGResourceMasker):
291         (WebCore::SVGResourceMasker::~SVGResourceMasker):
292         (WebCore::SVGResourceMasker::setMask):
293         (WebCore::SVGResourceMasker::mask):
294         (WebCore::SVGResourceMasker::externalRepresentation):
295         (WebCore::getMaskerById):
296         * platform/graphics/svg/SVGResourceMasker.h: Added.
297         (WebCore::SVGResourceMasker::isMasker):
298         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
299         (WebCore::SVGResourceClipper::applyClip):
300         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
301         (WebCore::SVGResourceImage::SVGResourceImage):
302         (WebCore::SVGResourceImage::~SVGResourceImage):
303         (WebCore::SVGResourceImage::init):
304         (WebCore::SVGResourceImage::size):
305         (WebCore::SVGResourceImage::cgLayer):
306         (WebCore::SVGResourceImage::setCGLayer):
307         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
308         (WebCore::applyLuminanceToAlphaFilter):
309         (WebCore::applyExpandAlphatoGrayscaleFilter):
310         (WebCore::transformImageIntoGrayscaleMask):
311         (WebCore::SVGResourceMasker::applyMask):
312         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
313         (WebCore::SVGResourceClipper::applyClip):
314         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
315         (WebCore::SVGResourceImage::init):
316         (WebCore::SVGResourceImage::size):
317         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
318         (WebCore::SVGResourceMasker::applyMask):
319         * platform/qt/GraphicsContextQt.cpp:
320         * rendering/RenderPath.cpp:
321         (WebCore::RenderPath::paint):
322         (WebCore::DrawMarkersData::DrawMarkersData):
323         (WebCore::RenderPath::drawMarkersIfNeeded):
324         * rendering/RenderSVGContainer.cpp:
325         (WebCore::RenderSVGContainer::paint):
326         * rendering/RenderSVGImage.cpp:
327         (WebCore::RenderSVGImage::paint):
328         * rendering/SVGInlineFlowBox.cpp:
329         (WebCore::paintSVGInlineFlow):
330
331 2006-10-30  John Sullivan  <sullivan@apple.com>
332
333         Reviewed by Brady
334         
335         - minor cleanup to make future patches clearer
336
337         * bridge/mac/FrameMac.mm:
338         (WebCore::FrameMac::advanceToNextMisspelling):
339         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
340         with "continue" to better match structure of similar code in markMisspellings; a few
341         other style tweaks.
342         
343         (WebCore::FrameMac::markMisspellings):
344         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
345         a block just after a break and outdented accordingly.
346
347 2006-10-30  John Sullivan  <sullivan@apple.com>
348
349         Reviewed by Geoff Garen
350         
351         WebCore part of change to push the code that updates the spelling panel
352         into WebCore, in preparation for some grammar-checking stuff.
353
354         * bridge/mac/FrameMac.h:
355         * bridge/mac/FrameMac.mm:
356         (WebCore::FrameMac::advanceToNextMisspelling):
357         no more return value for this method, and update the spelling panel with
358         the misspelled word here rather than in the WebKit callers.
359
360 2006-10-30  Oliver Hunt  <oliver@apple.com>
361
362         Reviewed by Anders.
363
364         Roll out last patch
365
366         * CMakeLists.txt:
367         * ChangeLog:
368         * WebCore.xcodeproj/project.pbxproj:
369         * graphics/svg/SVGResource.cpp:
370         * graphics/svg/SVGResourceClipper.cpp:
371         * graphics/svg/SVGResourceClipper.h:
372         * graphics/svg/SVGResourceImage.h:
373         * graphics/svg/SVGResourceListener.h:
374         * graphics/svg/SVGResourceMarker.cpp:
375         * graphics/svg/SVGResourceMarker.h:
376         * graphics/svg/SVGResourceMasker.cpp:
377         * graphics/svg/SVGResourceMasker.h:
378         * kcanvas/KCanvasClipper.cpp: Added.
379         (WebCore::operator<<):
380         (WebCore::KCanvasClipper::KCanvasClipper):
381         (WebCore::KCanvasClipper::~KCanvasClipper):
382         (WebCore::KCanvasClipper::resetClipData):
383         (WebCore::KCanvasClipper::addClipData):
384         (WebCore::KCanvasClipper::clipData):
385         (WebCore::KCanvasClipper::externalRepresentation):
386         (WebCore::getClipperById):
387         * kcanvas/KCanvasClipper.h: Added.
388         (WebCore::KCClipData::windRule):
389         (WebCore::KCClipDataList::KCClipDataList):
390         (WebCore::KCClipDataList::addPath):
391         (WebCore::KCanvasClipper::isClipper):
392         * kcanvas/KCanvasFilters.cpp:
393         (WebCore::getFilterById):
394         * kcanvas/KCanvasFilters.h:
395         * kcanvas/KCanvasImage.h: Added.
396         (WebCore::KCanvasImage::KCanvasImage):
397         (WebCore::KCanvasImage::~KCanvasImage):
398         * kcanvas/KCanvasMarker.cpp: Added.
399         (WebCore::KCanvasMarker::KCanvasMarker):
400         (WebCore::KCanvasMarker::~KCanvasMarker):
401         (WebCore::KCanvasMarker::setMarker):
402         (WebCore::KCanvasMarker::setRef):
403         (WebCore::KCanvasMarker::refX):
404         (WebCore::KCanvasMarker::refY):
405         (WebCore::KCanvasMarker::setAngle):
406         (WebCore::KCanvasMarker::angle):
407         (WebCore::KCanvasMarker::setAutoAngle):
408         (WebCore::KCanvasMarker::setUseStrokeWidth):
409         (WebCore::KCanvasMarker::useStrokeWidth):
410         (WebCore::KCanvasMarker::draw):
411         (WebCore::KCanvasMarker::externalRepresentation):
412         (WebCore::getMarkerById):
413         * kcanvas/KCanvasMarker.h: Added.
414         (WebCore::KCanvasMarker::isMarker):
415         * kcanvas/KCanvasMasker.cpp: Added.
416         (WebCore::KCanvasMasker::KCanvasMasker):
417         (WebCore::KCanvasMasker::~KCanvasMasker):
418         (WebCore::KCanvasMasker::setMask):
419         (WebCore::KCanvasMasker::externalRepresentation):
420         (WebCore::getMaskerById):
421         * kcanvas/KCanvasMasker.h: Added.
422         (WebCore::KCanvasMasker::isMasker):
423         (WebCore::KCanvasMasker::mask):
424         * kcanvas/KCanvasResource.cpp: Added.
425         (WebCore::operator<<):
426         (WebCore::KCanvasResource::KCanvasResource):
427         (WebCore::KCanvasResource::~KCanvasResource):
428         (WebCore::KCanvasResource::addClient):
429         (WebCore::KCanvasResource::clients):
430         (WebCore::KCanvasResource::invalidate):
431         (WebCore::KCanvasResource::idInRegistry):
432         (WebCore::KCanvasResource::setIdInRegistry):
433         (WebCore::KCanvasResource::externalRepresentation):
434         (WebCore::getResourceById):
435         (WebCore::getPaintServerById):
436         * kcanvas/KCanvasResource.h:
437         (WebCore::):
438         (WebCore::KCanvasResource::isPaintServer):
439         (WebCore::KCanvasResource::isFilter):
440         (WebCore::KCanvasResource::isClipper):
441         (WebCore::KCanvasResource::isMarker):
442         (WebCore::KCanvasResource::isMasker):
443         * kcanvas/KCanvasResourceListener.h: Added.
444         (KCanvasResourceListener::KCanvasResourceListener):
445         (KCanvasResourceListener::~KCanvasResourceListener):
446         * kcanvas/KCanvasTreeDebug.cpp:
447         (WebCore::writeRenderResources):
448         * kcanvas/device/KRenderingDevice.h:
449         * kcanvas/device/KRenderingPaintServer.h:
450         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
451         (WebCore::KRenderingPaintServer::idInRegistry):
452         (WebCore::KRenderingPaintServer::setIdInRegistry):
453         * kcanvas/device/KRenderingPaintServerGradient.cpp:
454         (WebCore::KRenderingPaintServerGradient::listener):
455         (WebCore::KRenderingPaintServerGradient::setListener):
456         * kcanvas/device/KRenderingPaintServerGradient.h:
457         * kcanvas/device/KRenderingPaintServerPattern.cpp:
458         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
459         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
460         (WebCore::KRenderingPaintServerPattern::tile):
461         (WebCore::KRenderingPaintServerPattern::setTile):
462         (WebCore::KRenderingPaintServerPattern::listener):
463         (WebCore::KRenderingPaintServerPattern::setListener):
464         * kcanvas/device/KRenderingPaintServerPattern.h:
465         * kcanvas/device/KRenderingPaintServerSolid.h:
466         * kcanvas/device/qt/KCanvasClipperQt.cpp:
467         (WebCore::KCanvasClipperQt::applyClip):
468         * kcanvas/device/qt/KCanvasClipperQt.h:
469         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
470         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
471         (WebCore::KRenderingDeviceQt::contextForImage):
472         (WebCore::KRenderingDeviceQt::createResource):
473         (WebCore::KRenderingDeviceQt::createPaintServer):
474         * kcanvas/device/qt/KRenderingDeviceQt.h:
475         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
476         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
477         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
478         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
479         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
480         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
481         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
482         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
483         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
484         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
485         (WebCore::applyLuminanceToAlphaFilter):
486         (WebCore::applyExpandAlphatoGrayscaleFilter):
487         (WebCore::transformImageIntoGrayscaleMask):
488         (WebCore::KCanvasMaskerQuartz::applyMask):
489         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
490         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
491         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
492         (WebCore::KCanvasImageQuartz::init):
493         (WebCore::KCanvasImageQuartz::size):
494         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
495         (WebCore::KCanvasClipperQuartz::applyClip):
496         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
497         (WebCore::KCanvasImageQuartz::cgLayer):
498         (WebCore::KCanvasImageQuartz::setCGLayer):
499         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
500         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
501         (WebCore::KRenderingDeviceQuartz::contextForImage):
502         (WebCore::KRenderingDeviceQuartz::createPaintServer):
503         (WebCore::KRenderingDeviceQuartz::createResource):
504         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
505         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
506         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
507         (WebCore::KRenderingPaintServerGradientQuartz::setup):
508         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
509         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
510         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
511         (WebCore::patternCallback):
512         (WebCore::KRenderingPaintServerPatternQuartz::setup):
513         * kcanvas/device/quartz/QuartzSupport.mm:
514         * ksvg2/misc/KCanvasRenderingStyle.cpp:
515         (WebCore::sharedSolidPaintServer):
516         * ksvg2/svg/SVGClipPathElement.cpp:
517         (WebCore::SVGClipPathElement::SVGClipPathElement):
518         (WebCore::SVGClipPathElement::~SVGClipPathElement):
519         (WebCore::SVGClipPathElement::canvasResource):
520         * ksvg2/svg/SVGClipPathElement.h:
521         * ksvg2/svg/SVGFEImageElement.cpp:
522         * ksvg2/svg/SVGFilterElement.cpp:
523         (WebCore::SVGFilterElement::SVGFilterElement):
524         (WebCore::SVGFilterElement::~SVGFilterElement):
525         (WebCore::SVGFilterElement::canvasResource):
526         * ksvg2/svg/SVGFilterElement.h:
527         * ksvg2/svg/SVGGradientElement.cpp:
528         (WebCore::SVGGradientElement::SVGGradientElement):
529         (WebCore::SVGGradientElement::~SVGGradientElement):
530         (WebCore::SVGGradientElement::canvasResource):
531         (WebCore::SVGGradientElement::resourceNotification):
532         * ksvg2/svg/SVGGradientElement.h:
533         * ksvg2/svg/SVGImageElement.cpp:
534         * ksvg2/svg/SVGLinearGradientElement.cpp:
535         (WebCore::SVGLinearGradientElement::buildGradient):
536         * ksvg2/svg/SVGLinearGradientElement.h:
537         * ksvg2/svg/SVGMarkerElement.cpp:
538         (WebCore::SVGMarkerElement::SVGMarkerElement):
539         (WebCore::SVGMarkerElement::~SVGMarkerElement):
540         (WebCore::SVGMarkerElement::canvasResource):
541         * ksvg2/svg/SVGMarkerElement.h:
542         * ksvg2/svg/SVGMaskElement.cpp:
543         (WebCore::SVGMaskElement::SVGMaskElement):
544         (WebCore::SVGMaskElement::~SVGMaskElement):
545         (WebCore::SVGMaskElement::drawMaskerContent):
546         (WebCore::SVGMaskElement::canvasResource):
547         * ksvg2/svg/SVGMaskElement.h:
548         * ksvg2/svg/SVGPatternElement.cpp:
549         (WebCore::SVGPatternElement::SVGPatternElement):
550         (WebCore::SVGPatternElement::~SVGPatternElement):
551         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
552         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
553         (WebCore::SVGPatternElement::canvasResource):
554         * ksvg2/svg/SVGPatternElement.h:
555         * ksvg2/svg/SVGRadialGradientElement.cpp:
556         (WebCore::SVGRadialGradientElement::buildGradient):
557         * ksvg2/svg/SVGRadialGradientElement.h:
558         * ksvg2/svg/SVGStyledElement.h:
559         (WebCore::SVGStyledElement::canvasResource):
560         * platform/GraphicsContext.cpp: Added.
561         (WebCore::GraphicsContextState::GraphicsContextState):
562         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
563         (WebCore::GraphicsContext::createGraphicsContextPrivate):
564         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
565         (WebCore::GraphicsContext::save):
566         (WebCore::GraphicsContext::restore):
567         (WebCore::GraphicsContext::font):
568         (WebCore::GraphicsContext::setFont):
569         (WebCore::GraphicsContext::pen):
570         (WebCore::GraphicsContext::setPen):
571         (WebCore::GraphicsContext::setFillColor):
572         (WebCore::GraphicsContext::fillColor):
573         (WebCore::GraphicsContext::updatingControlTints):
574         (WebCore::GraphicsContext::setUpdatingControlTints):
575         (WebCore::GraphicsContext::setPaintingDisabled):
576         (WebCore::GraphicsContext::paintingDisabled):
577         (WebCore::GraphicsContext::drawImage):
578         (WebCore::GraphicsContext::drawText):
579         (WebCore::GraphicsContext::drawHighlightForText):
580         (WebCore::GraphicsContext::initFocusRing):
581         (WebCore::GraphicsContext::clearFocusRing):
582         (WebCore::GraphicsContext::focusRingBoundingRect):
583         (WebCore::GraphicsContext::addFocusRingRect):
584         (WebCore::GraphicsContext::focusRingWidth):
585         (WebCore::GraphicsContext::focusRingOffset):
586         (WebCore::GraphicsContext::focusRingRects):
587         (WebCore::GraphicsContext::drawTiledImage):
588         * platform/GraphicsContext.h: Added.
589         * platform/GraphicsTypes.cpp: Added.
590         (WebCore::):
591         (WebCore::parseCompositeOperator):
592         (WebCore::compositeOperatorName):
593         (WebCore::parseLineCap):
594         (WebCore::lineCapName):
595         (WebCore::parseLineJoin):
596         (WebCore::lineJoinName):
597         * platform/GraphicsTypes.h: Added.
598         (WebCore::):
599         * platform/graphics/GraphicsContext.cpp:
600         * platform/graphics/GraphicsContext.h:
601         * platform/graphics/GraphicsTypes.cpp:
602         * platform/graphics/GraphicsTypes.h:
603         * platform/qt/GraphicsContextQt.cpp:
604         * rendering/RenderPath.cpp:
605         (WebCore::RenderPath::paint):
606         (WebCore::DrawMarkersData::DrawMarkersData):
607         (WebCore::RenderPath::drawMarkersIfNeeded):
608         * rendering/RenderSVGContainer.cpp:
609         (WebCore::RenderSVGContainer::paint):
610         * rendering/RenderSVGImage.cpp:
611         (WebCore::RenderSVGImage::paint):
612         * rendering/SVGInlineFlowBox.cpp:
613         (WebCore::paintSVGInlineFlow):
614
615 2006-10-30  John Sullivan  <sullivan@apple.com>
616
617         Reviewed by Geoff Garen.
618         
619         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
620         grammar-related method.
621
622         * bridge/EditorClient.h:
623         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
624         isGrammarCheckingEnabled()
625         
626         * bridge/mac/WebCoreFrameBridge.h:
627         removed bridge equivalents
628
629         * bridge/mac/FrameMac.mm:
630         (WebCore::FrameMac::advanceToNextMisspelling):
631         convert bridge-using code to editor()->client()-using code
632         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
633         ditto
634         (WebCore::FrameMac::markMisspellings):
635         ditto
636         (WebCore::FrameMac::respondToChangedSelection):
637         ditto
638         
639         * editing/Editor.h:
640         * editing/Editor.cpp:
641         (WebCore::Editor::client):
642         new method, returns EditorClient pointer. In an ideal world all the code that needed to
643         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
644         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
645
646 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
647
648         Reviewed by Darin.
649
650         Removed a number of editing and selection methods from the bridge.
651         
652         I moved cross-platform editing and selection code into Editor and 
653         SelectionController, respecitvely.
654
655         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
656         everything + the kitchen sink.
657         
658         Specific comments below for interesting things.
659         
660         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
661         a new file so that WebKit can use them, too. Added a helper method for
662         handling exceptions when selecting a Range.
663         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
664         WebKit, since they have to do with creating an NSAttributedString for API
665         consumption, and not much to do with general Frame functionality.
666         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
667         for now) into the Editor. Eventually, the Frame will not have to notify 
668         the Editor of what the lastEditCommand was, since the Editor will perform
669         all EditCommands.
670         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
671         * editing/SelectionController.cpp:
672         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
673         and return them. The bridge method to select a DOM range did this implicitly,
674         since all ObjC DOM operations handle DOM exceptions by throwing them as
675         ObjC exceptions.
676         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
677         The two enumerations are numerically identical, but that's an implementation
678         detail of TextAffinity that clients shouldn't be required to know about.
679
680 2006-10-30  Timothy Hatcher  <timothy@apple.com>
681
682         Rolling out the following change because this crash:
683         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
684
685         And this regression:
686         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
687
688     2006-09-06  David Harrison  <harrison@apple.com>
689
690         Reviewed and tweaked by Tim H. 
691
692         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
693
694         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
695         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
696         No layout tests affected. Not testable in an automated way that will work on all systems. 
697
698         * platform/mac/WebFontCache.mm: 
699         (+[WebFontCache fontWithFamily:traits:size:]): 
700
701 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
702
703         Reviewed by harrison
704
705         <rdar://problem/4808375>
706         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
707
708         * editing/TextIterator.cpp:
709         (WebCore::TextIterator::exitNode): Only create VisiblePositions
710         when we're going to use them to create a range for an emitted character.
711         We should further speed TextIterators up by avoiding creating VisiblePositions
712         for TIs that are only used for the characters they emit (like the one that 
713         plainText uses).
714
715 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
716
717         Reviewed by Mitz.
718
719         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
720         More rendering code cleaning
721
722         * WebCore.xcodeproj/project.pbxproj:
723         * rendering/RenderApplet.cpp:
724         (WebCore::RenderApplet::RenderApplet):
725         (WebCore::RenderApplet::createWidgetIfNecessary):
726         * rendering/RenderApplet.h:
727         * rendering/RenderArena.cpp:
728         (WebCore::):
729         (WebCore::RenderArena::RenderArena):
730         (WebCore::RenderArena::allocate):
731         (WebCore::RenderArena::free):
732         * rendering/RenderArena.h:
733         * rendering/RenderBR.cpp:
734         (WebCore::RenderBR::RenderBR):
735         (WebCore::RenderBR::baselinePosition):
736         (WebCore::RenderBR::lineHeight):
737         (WebCore::RenderBR::setStyle):
738         (WebCore::RenderBR::caretMinOffset):
739         (WebCore::RenderBR::positionForCoordinates):
740         (WebCore::RenderBR::inlineBox):
741         * rendering/RenderBR.h:
742         * rendering/RenderBlock.cpp:
743         * rendering/RenderBlock.h:
744         (WebCore::RenderBlock::maxTopMargin):
745         (WebCore::RenderBlock::maxBottomMargin):
746         (WebCore::RenderBlock::initMaxMarginValues):
747         (WebCore::RenderBlock::containsFloats):
748         (WebCore::RenderBlock::setHasMarkupTruncation):
749         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
750         (WebCore::RenderBlock::BlockSelectionInfo::block):
751         (WebCore::RenderBlock::BlockSelectionInfo::state):
752         (WebCore::RenderBlock::FloatingObject::FloatingObject):
753         (WebCore::RenderBlock::CompactInfo::clear):
754         * rendering/RenderButton.cpp:
755         (WebCore::RenderButton::removeChild):
756         (WebCore::RenderButton::paintObject):
757         * rendering/RenderButton.h:
758         (WebCore::RenderButton::renderName):
759         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
760         * rendering/RenderContainer.cpp:
761         (WebCore::RenderContainer::RenderContainer):
762         * rendering/RenderContainer.h:
763         (WebCore::RenderContainer::firstChild):
764         (WebCore::RenderContainer::lastChild):
765         (WebCore::RenderContainer::calcMinMaxWidth):
766         * rendering/RenderCounter.cpp:
767         (WebCore::RenderCounter::RenderCounter):
768         (WebCore::toRoman):
769         (WebCore::toHebrew):
770         (WebCore::RenderCounter::calcMinMaxWidth):
771         * rendering/RenderCounter.h:
772         * rendering/RenderFieldset.cpp:
773         (WebCore::RenderFieldset::paintBoxDecorations):
774         (WebCore::RenderFieldset::paintBorderMinusLegend):
775         (WebCore::RenderFieldset::setStyle):
776         * rendering/RenderFileUploadControl.cpp:
777         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
778         (WebCore::RenderFileUploadControl::setStyle):
779         (WebCore::RenderFileUploadControl::paintObject):
780         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
781         * rendering/RenderFileUploadControl.h:
782         (WebCore::RenderFileUploadControl::renderName):
783         * rendering/RenderFlexibleBox.h:
784         * rendering/RenderFlow.cpp:
785         * rendering/RenderFlow.h:
786         * rendering/RenderForeignObject.cpp:
787         (WebCore::RenderForeignObject::RenderForeignObject):
788         (WebCore::RenderForeignObject::paint):
789         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
790         (WebCore::RenderForeignObject::layout):
791         (WebCore::RenderForeignObject::nodeAtPoint):
792         * rendering/RenderForeignObject.h:
793         (WebCore::RenderForeignObject::renderName):
794         * rendering/RenderFormElement.cpp:
795         (WebCore::RenderFormElement::setStyle):
796         (WebCore::RenderFormElement::layout):
797         (WebCore::RenderFormElement::textAlignment):
798         * rendering/RenderFormElement.h:
799         * rendering/RenderFrame.cpp:
800         * rendering/RenderFrame.h:
801         (WebCore::RenderFrame::element):
802         * rendering/RenderFrameSet.cpp:
803         * rendering/RenderFrameSet.h:
804         (WebCore::RenderFrameSet::element):
805         * rendering/RenderHTMLCanvas.cpp:
806         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
807         (WebCore::RenderHTMLCanvas::paint):
808         * rendering/RenderHTMLCanvas.h:
809         (WebCore::RenderHTMLCanvas::renderName):
810         * rendering/RenderImage.cpp:
811         (WebCore::RenderImage::RenderImage):
812         (WebCore::RenderImage::setStyle):
813         (WebCore::RenderImage::setContentObject):
814         (WebCore::RenderImage::setCachedImage):
815         (WebCore::RenderImage::imageChanged):
816         (WebCore::RenderImage::paint):
817         (WebCore::RenderImage::layout):
818         (WebCore::RenderImage::updateAltText):
819         * rendering/RenderImage.h:
820         (WebCore::RenderImage::element):
821         * rendering/RenderInline.cpp:
822         (WebCore::RenderInline::RenderInline):
823         (WebCore::RenderInline::~RenderInline):
824         (WebCore::RenderInline::setStyle):
825         (WebCore::RenderInline::addChildToFlow):
826         (WebCore::RenderInline::cloneInline):
827         (WebCore::RenderInline::splitInlines):
828         (WebCore::RenderInline::splitFlow):
829         (WebCore::RenderInline::paint):
830         (WebCore::RenderInline::absoluteRects):
831         (WebCore::RenderInline::calcMinMaxWidth):
832         (WebCore::RenderInline::requiresLayer):
833         (WebCore::RenderInline::width):
834         (WebCore::RenderInline::height):
835         (WebCore::RenderInline::renderName):
836         (WebCore::RenderInline::nodeAtPoint):
837         (WebCore::RenderInline::positionForCoordinates):
838         * rendering/RenderInline.h:
839         (WebCore::RenderInline::layout):
840         * rendering/RenderLayer.cpp:
841         * rendering/RenderLayer.h:
842         (WebCore::ClipRects::ClipRects):
843         (WebCore::RenderLayer::nextSibling):
844         (WebCore::RenderLayer::root):
845         (WebCore::RenderLayer::setPos):
846         (WebCore::RenderLayer::height):
847         (WebCore::RenderLayer::relativePositionOffset):
848         * rendering/RenderLineEdit.cpp:
849         (WebCore::RenderLineEdit::setStyle):
850         (WebCore::RenderLineEdit::updateFromElement):
851         (WebCore::RenderLineEdit::selectionStart):
852         (WebCore::RenderLineEdit::selectionEnd):
853         (WebCore::RenderLineEdit::setSelectionStart):
854         (WebCore::RenderLineEdit::setSelectionEnd):
855         (WebCore::RenderLineEdit::setSelectionRange):
856         * rendering/RenderLineEdit.h:
857         * rendering/RenderListBox.cpp:
858         * rendering/RenderListBox.h:
859         (WebCore::RenderListBox::renderName):
860         * rendering/RenderListItem.cpp:
861         (WebCore::RenderListItem::setStyle):
862         (WebCore::getParentOfFirstLineBox):
863         (WebCore::RenderListItem::updateMarkerLocation):
864         (WebCore::RenderListItem::positionListMarker):
865         (WebCore::RenderListItem::paint):
866         * rendering/RenderListItem.h:
867         * rendering/RenderListMarker.cpp:
868         * rendering/RenderListMarker.h:
869         (WebCore::RenderListMarker::renderName):
870         (WebCore::RenderListMarker::isListMarker):
871
872 2006-10-30  Timothy Hatcher  <timothy@apple.com>
873
874         Reviewed by Hyatt.
875
876         <rdar://problem/4478625> Basic table editing and culling
877
878         Refined the criteria for deletable elements, rely on the renderer more.
879         Corrected the interface positioning for elements that have borders.
880
881         * editing/DeleteButtonController.cpp:
882         (WebCore::isDeletableElement):
883         (WebCore::DeleteButtonController::show):
884
885 2006-10-30  Darin Adler  <darin@apple.com>
886
887         - fix build
888
889         * loader/ResourceLoader.h: Added header guard.
890
891 2006-10-31  Darin Adler  <darin@apple.com>
892
893         Reviewed by Adam.
894
895         - fix FrameLoader files so they can be built on non-Mac platforms
896
897         * page/FramePrivate.h:
898         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
899         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
900
901         * page/Page.h:
902         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
903         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
904         the other day.
905
906         * bridge/mac/FrameMac.mm:
907         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
908         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
909
910         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
911         around the PolicyCheck definition.
912
913         * loader/FormState.cpp: Changed import to include.
914         * loader/FrameLoader.cpp: Ditto.
915         * loader/MainResourceLoader.h: Ditto.
916
917         * loader/FrameLoaderTypes.h: Added a header guard.
918
919         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
920         Added #if PLATFORM(MAC) around Mac-specific details.
921         * loader/SubresourceLoader.h: Ditto.
922
923         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
924         m_loader from m_frameLoader.
925
926         * CMakeLists.txt: Updated.
927         * WebCoreSources.bkl: Updated.
928
929 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
930
931         Reviewed and landed by Anders.
932
933         Patch by Zack rusin to fix: 
934         http://bugs.webkit.org/show_bug.cgi?id=11429
935
936         Fix startup crash.
937
938         * platform/qt/FrameQtClient.cpp:
939         (WebCore::FrameQtClientDefault::openURL):
940
941 2006-10-30  Zach Rusin  <zack@kde.org>
942
943         Reviewed and landed by Anders.
944
945         * platform/network/qt/ResourceHandleQt.cpp:
946         (WebCore::ResourceHandle::receivedResponse):
947         * platform/qt/FrameQtClient.cpp:
948         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
949         * platform/qt/LoaderFunctionsQt.cpp:
950         (WebCore::ServeSynchronousRequest):
951         More build fixes.
952
953 2006-10-30  Simon Hausmann  <hausmann@kde.org>
954
955         Reviewed and landed by Anders.
956         
957         - fix Qt build
958         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
959         ResourceHandleClient
960
961 2006-10-30  Darin Adler  <darin@apple.com>
962
963         Reviewed by John Sullivan.
964
965         - work toward removing Objective-C data types from FrameLoader.h:
966           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
967           and WebCoreResourceHandle
968         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
969
970         * page/PageState.h:
971         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
972
973         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
974         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
975         double for the date instead of an NSDate.
976
977         * bridge/mac/WebCoreFrameBridge.h:
978         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
979         saveDocumentToPageCache methods.
980
981         * bridge/mac/WebCorePageState.h:
982         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
983         an Objective-C wrapper for PageState.
984
985         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
986         NSDate and WebCorePageState.
987         * loader/FrameLoaderClient.h: Changed NSDate to double.
988         * loader/mac/FrameLoaderMac.mm:
989         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
990         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
991         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
992         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
993         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
994         extract the parameters from the response. Changed the open function that takes
995         a PageState to use the new C++ PageState.
996         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
997         function; tightened up logic, removing a few cases that could never happen, as
998         well as the unused reload boolean.
999
1000         * ForwardingHeaders/kjs/property_map.h: Added.
1001
1002         * WebCore.exp: Updated.
1003         * WebCore.xcodeproj/project.pbxproj: Updated.
1004
1005 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1006
1007         Reviewed by Anders.
1008
1009         - added ResourceResponse class and didReceiveResponse delegate call
1010         
1011         * WebCore.xcodeproj/project.pbxproj: Added new files.
1012         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1013         expiresTimeForResponse: method.
1014         * dom/XMLTokenizer.cpp:
1015         (WebCore::openFunc): Updated to use ResourceResponse.
1016         * loader/FrameLoader.h: Update loadResourceSynchronously to
1017         use ResourceResponse.
1018         * loader/LoaderFunctions.h:
1019         * loader/icon/IconLoader.cpp:
1020         (IconLoader::didReceiveResponse): Updated from receivedResponse
1021         and made cross-platform.
1022         * loader/icon/IconLoader.h: updated for above change
1023         * loader/loader.cpp:
1024         (WebCore::Loader::receivedResponse): reduced to just saving
1025         the PlatformResponse (ideally we'd phase out use of this).
1026         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
1027         logic.
1028         * loader/loader.h:
1029         * loader/mac/FrameLoaderMac.mm:
1030         (WebCore::FrameLoader::loadResourceSynchronously): Return results
1031         as ResourceResponse.
1032         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
1033         * loader/mac/LoaderFunctionsMac.mm:
1034         (WebCore::ServeSynchronousRequest): take ResourceResponse as
1035         argument.
1036         * platform/network/ResourceHandle.cpp:
1037         * platform/network/ResourceHandle.h: Remove calls for
1038         broken out response pieces.
1039         * platform/network/ResourceHandleClient.h:
1040         (WebCore::ResourceHandleClient::didReceiveResponse): New
1041         delegate method.
1042         * platform/network/ResourceHandleInternal.h:
1043         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
1044         storage of response bits, we're not gonna return them
1045         seprately any more.
1046         * platform/network/ResourceResponse.h: Added.
1047         (WebCore::ResourceResponse::ResourceResponse): Freshly
1048         implemented. Same for below.
1049         (WebCore::ResourceResponse::url):
1050         (WebCore::ResourceResponse::mimeType):
1051         (WebCore::ResourceResponse::expectedContentLength):
1052         (WebCore::ResourceResponse::textEncodingName):
1053         (WebCore::ResourceResponse::suggestedFilename):
1054         (WebCore::ResourceResponse::httpStatusCode):
1055         (WebCore::ResourceResponse::setHTTPStatusCode):
1056         (WebCore::ResourceResponse::httpHeaderField):
1057         (WebCore::ResourceResponse::httpHeaderFields):
1058         (WebCore::ResourceResponse::isMultipart):
1059         (WebCore::ResourceResponse::setExpirationDate):
1060         (WebCore::ResourceResponse::expirationDate):
1061         * platform/network/cf/ResourceHandleCFNet.cpp:
1062         (WebCore::didReceiveResponse): Send didReceiveResponse
1063         client method.
1064         * platform/network/cf/ResourceResponseCFNet.h: Added.
1065         * platform/network/cf/ResourceResponseCFNet.mm: Added.
1066         (getResourceResponse): Helper function to get a ResourceResponse 
1067         from CFURLResponseRef.
1068         * platform/network/mac/ResourceHandleMac.mm:
1069         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1070         Don't bother cleaning up fields we no longer have.
1071         (WebCore::ResourceHandle::receivedResponse): Send
1072         didReceiveResponse client method.
1073         * platform/network/mac/ResourceResponseMac.h: Added.
1074         * platform/network/mac/ResourceResponseMac.mm: Added.
1075         (getResourceResponse): Helper function to get a ResourceResponse 
1076         from an NSURLResponse*.
1077         * rendering/HitTestResult.cpp:
1078         * xml/XSLTProcessor.cpp:
1079         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
1080         * xml/xmlhttprequest.cpp:
1081         (WebCore::XMLHttpRequest::getResponseText): Store http response
1082         info in the form of a ResourceResponse, change all methods to
1083         account for this.
1084         (WebCore::XMLHttpRequest::getResponseXML):
1085         (WebCore::XMLHttpRequest::XMLHttpRequest):
1086         (WebCore::XMLHttpRequest::open):
1087         (WebCore::XMLHttpRequest::send):
1088         (WebCore::XMLHttpRequest::getAllResponseHeaders):
1089         (WebCore::XMLHttpRequest::getResponseHeader):
1090         (WebCore::XMLHttpRequest::getStatus):
1091         (WebCore::XMLHttpRequest::getStatusText):
1092         (WebCore::XMLHttpRequest::processSyncLoadResults):
1093         (WebCore::XMLHttpRequest::didFinishLoading):
1094         (WebCore::XMLHttpRequest::didReceiveResponse):
1095         (WebCore::XMLHttpRequest::didReceiveData):
1096         * xml/xmlhttprequest.h:
1097
1098 2006-10-29  Darin Adler  <darin@apple.com>
1099
1100         - fix build
1101
1102         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
1103         * loader/NetscapePlugInStreamLoader.h: Ditto.
1104         * loader/ResourceLoader.h: Ditto.
1105
1106 2006-10-29  Darin Adler  <darin@apple.com>
1107
1108         - one last name change -- WebFormState.h to FormState.h
1109         - added more empty placeholder platform-independent files
1110           for currently-Mac-specific loader classes
1111
1112         * loader/FormState.cpp: Updated include.
1113         * loader/FrameLoader.cpp: Updated include.
1114         * loader/mac/FrameLoaderMac.mm: Updated include.
1115
1116         * loader/WebFormState.h: Removed.
1117         * loader/FormState.h: Added.
1118
1119         * loader/DocumentLoader.cpp: Added.
1120         * loader/MainResourceLoader.cpp: Added.
1121         * loader/NetscapePlugInStreamLoader.cpp: Added.
1122         * loader/ResourceLoader.cpp: Added.
1123         * loader/SubresourceLoader.cpp: Added.
1124
1125         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
1126
1127 2006-10-29  Darin Adler  <darin@apple.com>
1128
1129         - did the do-webcore-rename renames, including a number of changes
1130           to the names of loader files (and WebResourceLoader -> ResourceLoader),
1131           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
1132           and improvements to the names of decoder classes and their source
1133           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
1134
1135         * CMakeLists.txt:
1136         * WebCore.exp:
1137         * WebCore.vcproj/WebCore/WebCore.vcproj:
1138         * WebCore.xcodeproj/project.pbxproj:
1139         * WebCoreSources.bkl:
1140         * bindings/js/kjs_binding.cpp:
1141         (KJS::ScriptInterpreter::updateDOMNodeDocument):
1142         * bindings/js/kjs_events.cpp:
1143         (KJS::JSAbstractEventListener::handleEvent):
1144         (KJS::JSLazyEventListener::parseCode):
1145         * bindings/js/kjs_html.cpp:
1146         (KJS::JSHTMLElement::implementsCall):
1147         * bindings/js/kjs_traversal.cpp:
1148         (KJS::JSNodeFilterCondition::acceptNode):
1149         * bindings/js/kjs_window.cpp:
1150         (KJS::Window::interpreter):
1151         (KJS::Window::retrieveWindow):
1152         (KJS::Window::retrieve):
1153         (KJS::ScheduledAction::execute):
1154         * bindings/objc/DOMInternal.mm:
1155         (-[WebScriptObject _initializeScriptDOMNodeImp]):
1156         * bridge/mac/FrameMac.mm:
1157         (WebCore::FrameMac::executionContextForDOM):
1158         (WebCore::FrameMac::bindingRootObject):
1159         (WebCore::FrameMac::windowScriptObject):
1160         (WebCore::FrameMac::windowScriptNPObject):
1161         (WebCore::FrameMac::partClearedInBegin):
1162         * bridge/mac/WebCoreEncodings.mm:
1163         * bridge/mac/WebCoreFrameBridge.mm:
1164         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1165         (-[WebCoreFrameBridge stringWithData:]):
1166         (-[WebCoreFrameBridge executionContextForView:]):
1167         * bridge/win/FrameWin.cpp:
1168         * dom/Document.cpp:
1169         (WebCore::Document::inputEncoding):
1170         (WebCore::Document::setCharset):
1171         (WebCore::Document::createHTMLEventListener):
1172         (WebCore::Document::setDecoder):
1173         * dom/Document.h:
1174         (WebCore::Document::decoder):
1175         * dom/EventTargetNode.cpp:
1176         (WebCore::EventTargetNode::dispatchGenericEvent):
1177         * html/HTMLParser.cpp:
1178         (WebCore::HTMLParser::noscriptCreateErrorCheck):
1179         (WebCore::HTMLParser::canvasCreateErrorCheck):
1180         (WebCore::HTMLParser::isInline):
1181         * html/HTMLPlugInElement.cpp:
1182         (WebCore::HTMLPlugInElement::createNPObject):
1183         * html/HTMLScriptElement.cpp:
1184         (WebCore::HTMLScriptElement::evaluateScript):
1185         * html/HTMLTokenizer.cpp:
1186         (WebCore::HTMLTokenizer::parseTag):
1187         (WebCore::HTMLTokenizer::processToken):
1188         * ksvg2/misc/SVGDocumentExtensions.cpp:
1189         (WebCore::SVGDocumentExtensions::createSVGEventListener):
1190         * loader/CachedCSSStyleSheet.cpp:
1191         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1192         (WebCore::CachedCSSStyleSheet::setEncoding):
1193         * loader/CachedCSSStyleSheet.h:
1194         * loader/CachedXBLDocument.cpp:
1195         (WebCore::CachedXBLDocument::CachedXBLDocument):
1196         (WebCore::CachedXBLDocument::setEncoding):
1197         * loader/CachedXBLDocument.h:
1198         * loader/CachedXSLStyleSheet.cpp:
1199         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
1200         (WebCore::CachedXSLStyleSheet::setEncoding):
1201         * loader/CachedXSLStyleSheet.h:
1202         * loader/Decoder.cpp: Removed.
1203         * loader/Decoder.h: Removed.
1204         * loader/FrameLoader.cpp:
1205         * loader/FrameLoader.h:
1206         * loader/FrameLoaderClient.h:
1207         * loader/MainResourceLoader.h: Added.
1208         * loader/NetscapePlugInStreamLoader.h: Added.
1209         * loader/Request.h:
1210         (WebCore::Request::cachedResource):
1211         * loader/ResourceLoader.h: Added.
1212         * loader/SubresourceLoader.h: Added.
1213         * loader/TextResourceDecoder.cpp: Added.
1214         (WebCore::TextResourceDecoder::determineContentType):
1215         (WebCore::TextResourceDecoder::defaultEncoding):
1216         (WebCore::TextResourceDecoder::TextResourceDecoder):
1217         (WebCore::TextResourceDecoder::~TextResourceDecoder):
1218         (WebCore::TextResourceDecoder::setEncoding):
1219         (WebCore::TextResourceDecoder::checkForBOM):
1220         (WebCore::TextResourceDecoder::checkForCSSCharset):
1221         (WebCore::TextResourceDecoder::checkForHeadCharset):
1222         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
1223         (WebCore::TextResourceDecoder::decode):
1224         (WebCore::TextResourceDecoder::flush):
1225         * loader/TextResourceDecoder.h: Added.
1226         * loader/WebDocumentLoader.h: Removed.
1227         * loader/WebLoader.h: Removed.
1228         * loader/WebMainResourceLoader.h: Removed.
1229         * loader/WebNetscapePlugInStreamLoader.h: Removed.
1230         * loader/WebSubresourceLoader.h: Removed.
1231         * loader/loader.cpp:
1232         (WebCore::Loader::servePendingRequests):
1233         (WebCore::Loader::receivedAllData):
1234         (WebCore::Loader::receivedResponse):
1235         (WebCore::Loader::didReceiveData):
1236         (WebCore::Loader::cancelRequests):
1237         (WebCore::Loader::jobForRequest):
1238         * loader/mac/DocumentLoaderMac.mm:
1239         * loader/mac/FormDataStream.m: Added.
1240         * loader/mac/FrameLoaderMac.mm:
1241         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1242         (WebCore::FrameLoader::addPlugInStreamLoader):
1243         (WebCore::FrameLoader::removePlugInStreamLoader):
1244         (WebCore::FrameLoader::addSubresourceLoader):
1245         (WebCore::FrameLoader::removeSubresourceLoader):
1246         (WebCore::FrameLoader::willSendRequest):
1247         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
1248         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
1249         (WebCore::FrameLoader::didReceiveResponse):
1250         (WebCore::FrameLoader::didReceiveData):
1251         (WebCore::FrameLoader::didFinishLoad):
1252         (WebCore::FrameLoader::didFailToLoad):
1253         (WebCore::FrameLoader::open):
1254         (WebCore::FrameLoader::willUseArchive):
1255         (WebCore::FrameLoader::isArchiveLoadPending):
1256         * loader/mac/ImageDocumentMac.mm:
1257         * loader/mac/LoaderFunctionsMac.mm:
1258         (WebCore::CheckCacheObjectStatus):
1259         * loader/mac/MainResourceLoaderMac.mm:
1260         (WebCore::MainResourceLoader::MainResourceLoader):
1261         (WebCore::MainResourceLoader::releaseDelegate):
1262         (WebCore::MainResourceLoader::didCancel):
1263         (WebCore::MainResourceLoader::addData):
1264         (WebCore::MainResourceLoader::willSendRequest):
1265         (WebCore::MainResourceLoader::continueAfterContentPolicy):
1266         (WebCore::MainResourceLoader::didReceiveData):
1267         (WebCore::MainResourceLoader::didFinishLoading):
1268         (WebCore::MainResourceLoader::setDefersLoading):
1269         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1270         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1271         (WebCore::NetscapePlugInStreamLoader::releaseResources):
1272         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
1273         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
1274         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
1275         (WebCore::NetscapePlugInStreamLoader::didFail):
1276         (WebCore::NetscapePlugInStreamLoader::didCancel):
1277         * loader/mac/ResourceLoaderMac.mm:
1278         (WebCore::ResourceLoader::ResourceLoader):
1279         (WebCore::ResourceLoader::~ResourceLoader):
1280         (WebCore::ResourceLoader::releaseResources):
1281         (WebCore::ResourceLoader::load):
1282         (WebCore::ResourceLoader::setDefersLoading):
1283         (WebCore::ResourceLoader::frameLoader):
1284         (WebCore::ResourceLoader::addData):
1285         (WebCore::ResourceLoader::resourceData):
1286         (WebCore::ResourceLoader::clearResourceData):
1287         (WebCore::ResourceLoader::willSendRequest):
1288         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1289         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1290         (WebCore::ResourceLoader::didReceiveResponse):
1291         (WebCore::ResourceLoader::didReceiveData):
1292         (WebCore::ResourceLoader::willStopBufferingData):
1293         (WebCore::ResourceLoader::didFinishLoading):
1294         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1295         (WebCore::ResourceLoader::didFail):
1296         (WebCore::ResourceLoader::willCacheResponse):
1297         (WebCore::ResourceLoader::didCancel):
1298         (WebCore::ResourceLoader::cancel):
1299         (WebCore::ResourceLoader::setIdentifier):
1300         (WebCore::ResourceLoader::response):
1301         (WebCore::ResourceLoader::inConnectionCallback):
1302         (WebCore::ResourceLoader::cancelledError):
1303         (WebCore::ResourceLoader::receivedCredential):
1304         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
1305         (WebCore::ResourceLoader::receivedCancellation):
1306         (WebCore::ResourceLoader::delegate):
1307         (WebCore::ResourceLoader::releaseDelegate):
1308         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
1309         * loader/mac/SubresourceLoaderMac.mm:
1310         (WebCore::SubresourceLoader::SubresourceLoader):
1311         (WebCore::SubresourceLoader::willSendRequest):
1312         (WebCore::SubresourceLoader::didReceiveResponse):
1313         (WebCore::SubresourceLoader::didReceiveData):
1314         (WebCore::SubresourceLoader::didFinishLoading):
1315         (WebCore::SubresourceLoader::didFail):
1316         (WebCore::SubresourceLoader::didCancel):
1317         * loader/mac/WebFormDataStream.h: Removed.
1318         * loader/mac/WebFormDataStream.m: Removed.
1319         * page/Frame.cpp:
1320         (WebCore::Frame::javaScriptEnabled):
1321         (WebCore::Frame::scriptProxy):
1322         (WebCore::Frame::executeScript):
1323         (WebCore::Frame::write):
1324         (WebCore::Frame::userGestureHint):
1325         (WebCore::Frame::saveInterpreterBuiltins):
1326         (WebCore::Frame::restoreInterpreterBuiltins):
1327         (WebCore::Frame::backslashAsCurrencySymbol):
1328         * page/Frame.h:
1329         * page/FramePrivate.h:
1330         * platform/StreamingTextDecoder.cpp: Removed.
1331         * platform/StreamingTextDecoder.h: Removed.
1332         * platform/StreamingTextDecoderICU.cpp: Removed.
1333         * platform/StreamingTextDecoderICU.h: Removed.
1334         * platform/TextCodec.cpp: Added.
1335         * platform/TextCodec.h: Added.
1336         * platform/TextCodecICU.cpp: Added.
1337         * platform/TextCodecICU.h: Added.
1338         * platform/TextCodecLatin1.h:
1339         * platform/TextCodecUTF16.h:
1340         * platform/TextDecoder.h:
1341         * platform/TextEncoding.cpp:
1342         * platform/TextEncodingRegistry.cpp:
1343         * platform/image-decoders/jpeg/jmorecfg.h:
1344         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
1345         * platform/mac/StreamingTextDecoderMac.h: Removed.
1346         * platform/mac/TextCodecMac.cpp: Added.
1347         * platform/mac/TextCodecMac.h: Added.
1348         * platform/network/ResourceHandleInternal.h:
1349         * platform/network/mac/ResourceHandleMac.mm:
1350         * platform/qt/FrameQt.cpp:
1351         (WebCore::FrameQt::bindingRootObject):
1352         * platform/qt/LoaderFunctionsQt.cpp:
1353         (WebCore::CheckCacheObjectStatus):
1354         * rendering/RenderObject.cpp:
1355         (WebCore::RenderObject::backslashAsCurrencySymbol):
1356         * xml/XSLTProcessor.cpp:
1357         (WebCore::XSLTProcessor::createDocumentFromSource):
1358         * xml/xmlhttprequest.cpp:
1359         (WebCore::XMLHttpRequest::didReceiveData):
1360         * xml/xmlhttprequest.h:
1361
1362 2006-10-29  Darin Adler  <darin@apple.com>
1363
1364         Rubber stamped by Adam (kinda).
1365
1366         - add Mac suffixes and correct filenames inside loader/mac
1367
1368         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
1369
1370         * loader/mac/FrameLoader.mm: Removed.
1371         * loader/mac/WebDocumentLoader.mm: Removed.
1372         * loader/mac/WebLoader.mm: Removed.
1373         * loader/mac/WebMainResourceLoader.mm: Removed.
1374         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
1375         * loader/mac/WebSubresourceLoader.mm: Removed.
1376
1377         * loader/mac/FrameLoaderMac.mm: Added.
1378         * loader/mac/DocumentLoaderMac.mm: Added.
1379         * loader/mac/ResourceLoaderMac.mm: Added.
1380         * loader/mac/MainResourceLoaderMac.mm: Added.
1381         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
1382         * loader/mac/SubresourceLoaderMac.mm: Removed.
1383
1384 2006-10-29  Darin Adler  <darin@apple.com>
1385
1386         Reviewed by Adam.
1387
1388         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
1389           and FrameLoader.cpp mostly ready
1390
1391         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
1392         FormState.cpp. Removed WebFormState.mm.
1393
1394         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
1395         get this header compiling on non-Mac.
1396         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
1397         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
1398
1399         * loader/FrameLoaderClient.h: Added some ifdefs.
1400         * loader/WebDocumentLoader.h: Ditto.
1401         * loader/WebLoader.h: Ditto.
1402         * loader/WebMainResourceLoader.h: Ditto.
1403
1404         * loader/mac/WebDocumentLoader.mm:
1405         (WebCore::DocumentLoader::isLoadingInAPISense):
1406         Rewrote to work without bridge, partly to remove the need for ObjC
1407         bridge type in the header, and also because we're tearing down the bridge.
1408
1409         * loader/mac/WebMainResourceLoader.mm:
1410         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
1411         m_contentLength and m_bytesReceived.
1412         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
1413         (WebCore::MainResourceLoader::didReceiveData): Ditto.
1414
1415         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
1416         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
1417
1418         * loader/mac/FormState.mm: Removed.
1419         * loader/FormState.cpp: Added.
1420
1421 2006-10-29  Darin Adler  <darin@apple.com>
1422
1423         Rubber stamped by Adam.
1424
1425         - moving towards use of FrameLoader cross-platform; move the headers
1426           for the Mac loader from loader/mac into loader, in preparation for
1427           making them useful on non-Mac
1428
1429         * WebCore.xcodeproj/project.pbxproj:
1430
1431         * loader/mac/FrameLoader.h: Removed.
1432         * loader/mac/WebDocumentLoader.h: Removed.
1433         * loader/mac/WebFormState.h: Removed.
1434         * loader/mac/WebLoader.h: Removed.
1435         * loader/mac/WebMainResourceLoader.h: Removed.
1436         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
1437         * loader/mac/WebSubresourceLoader.h: Removed.
1438
1439         * loader/FrameLoader.h: Added.
1440         * loader/WebDocumentLoader.h: Added.
1441         * loader/WebFormState.h: Added.
1442         * loader/WebLoader.h: Added.
1443         * loader/WebMainResourceLoader.h: Added.
1444         * loader/WebNetscapePlugInStreamLoader.h: Added.
1445         * loader/WebSubresourceLoader.h: Added.
1446
1447 2006-10-29  Adam Roben  <aroben@apple.com>
1448
1449         Reviewed by Geoff.
1450
1451         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
1452         r17405.
1453
1454         * platform/DeprecatedString.h:
1455
1456 2006-10-29  Beth Dakin  <bdakin@apple.com>
1457
1458         Rubber stamped by Geoff.
1459
1460         This is a followup to my HitTestResult checkin. Most of the 
1461         HitTestResult local variables in the code were named i or info for 
1462         when the class was named NodeInfo. This patch renames all of these 
1463         local variables to result.
1464
1465         * dom/Document.cpp:
1466         (WebCore::Document::prepareMouseEvent):
1467         * html/HTMLAreaElement.cpp:
1468         (WebCore::HTMLAreaElement::mapMouseEvent):
1469         * html/HTMLMapElement.cpp:
1470         (WebCore::HTMLMapElement::mapMouseEvent):
1471         * rendering/EllipsisBox.cpp:
1472         (WebCore::EllipsisBox::nodeAtPoint):
1473         * rendering/EllipsisBox.h:
1474         * rendering/InlineBox.cpp:
1475         (WebCore::InlineBox::nodeAtPoint):
1476         * rendering/InlineFlowBox.cpp:
1477         (WebCore::InlineFlowBox::nodeAtPoint):
1478         * rendering/InlineTextBox.cpp:
1479         (WebCore::InlineTextBox::nodeAtPoint):
1480         * rendering/RenderBlock.cpp:
1481         (WebCore::RenderBlock::isPointInScrollbar):
1482         (WebCore::RenderBlock::nodeAtPoint):
1483         * rendering/RenderBlock.h:
1484         * rendering/RenderBox.cpp:
1485         (WebCore::RenderBox::nodeAtPoint):
1486         * rendering/RenderBox.h:
1487         * rendering/RenderFlow.cpp:
1488         (WebCore::RenderFlow::hitTestLines):
1489         * rendering/RenderFlow.h:
1490         * rendering/RenderForeignObject.cpp:
1491         (WebCore::RenderForeignObject::nodeAtPoint):
1492         * rendering/RenderFrameSet.cpp:
1493         (WebCore::RenderFrameSet::nodeAtPoint):
1494         * rendering/RenderImage.cpp:
1495         (WebCore::RenderImage::nodeAtPoint):
1496         * rendering/RenderInline.cpp:
1497         (WebCore::RenderInline::nodeAtPoint):
1498         * rendering/RenderInline.h:
1499         * rendering/RenderLayer.cpp:
1500         (WebCore::RenderLayer::autoscroll):
1501         (WebCore::RenderLayer::hitTest):
1502         (WebCore::RenderLayer::hitTestLayer):
1503         (WebCore::RenderLayer::updateHoverActiveState):
1504         * rendering/RenderListBox.cpp:
1505         (WebCore::RenderListBox::isPointInScrollbar):
1506         * rendering/RenderObject.cpp:
1507         (WebCore::RenderObject::hitTest):
1508         (WebCore::RenderObject::setInnerNode):
1509         (WebCore::RenderObject::nodeAtPoint):
1510         * rendering/RenderObject.h:
1511         * rendering/RenderPath.cpp:
1512         (WebCore::RenderPath::nodeAtPoint):
1513         * rendering/RenderSVGImage.cpp:
1514         (WebCore::RenderSVGImage::nodeAtPoint):
1515         * rendering/RenderSVGText.cpp:
1516         (WebCore::RenderSVGText::nodeAtPoint):
1517         * rendering/RenderTableRow.cpp:
1518         (WebCore::RenderTableRow::nodeAtPoint):
1519         * rendering/RenderTableRow.h:
1520         * rendering/RenderTableSection.cpp:
1521         (WebCore::RenderTableSection::nodeAtPoint):
1522         * rendering/RenderTableSection.h:
1523         * rendering/RenderTextControl.cpp:
1524         (WebCore::RenderTextControl::nodeAtPoint):
1525         * rendering/RootInlineBox.cpp:
1526         (WebCore::RootInlineBox::nodeAtPoint):
1527         * rendering/RootInlineBox.h:
1528
1529 2006-10-29  Adam Roben  <aroben@apple.com>
1530
1531         More semi-fixes.
1532
1533         * page/Page.cpp: Forgot to wrap the actual definition of
1534         setDefersLoading() in PLATFORM(MAC).
1535         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
1536
1537 2006-10-29  Adam Roben  <aroben@apple.com>
1538
1539         Build semi-fix.
1540
1541         Move all FrameLoader-related code in Page.{cpp,h} within #if
1542         PLATFORM(MAC), since this class currently only exists on Mac.
1543
1544         * page/Page.cpp:
1545         * page/Page.h:
1546
1547 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
1548
1549         build fix.
1550         
1551         * platform/PlatformString.h:
1552         (WebCore::String::operator NSString*):
1553
1554 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
1555
1556         Rolled out accidental commit.
1557         
1558         * platform/AtomicString.h:
1559         (WebCore::AtomicString::AtomicString):
1560         (WebCore::AtomicString::operator NSString*):
1561
1562 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
1563
1564         RS by Darin.
1565
1566         Rolled out change to map NULL Strings to nil NSStrings because it caused
1567         even more AppKit crashes. Maybe we should remove the NSString * operator
1568         entirely, since its use is not straight-forward, and require callers to
1569         specify explicitly whether they tolerate NULL.
1570         
1571         * platform/AtomicString.h:
1572         * platform/PlatformString.h:
1573         (WebCore::String::operator NSString*):
1574         * platform/mac/TextFieldMac.mm:
1575         (-[NSSearchFieldCell _addStringToRecentSearches:]):
1576
1577 2006-10-29  Darin Adler  <darin@apple.com>
1578
1579         Reviewed by Geoff.
1580
1581         - fixed storage leak showing up on the buildbot
1582
1583         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
1584         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
1585
1586 2006-10-29  Darin Adler  <darin@apple.com>
1587
1588         Rubber stamped by Adam.
1589
1590         - renamed WebFrameLoaderClient to match the class name inside it
1591
1592         * loader/mac/WebFrameLoaderClient.h: Removed.
1593         * loader/FrameLoaderClient.h: Moved it here.
1594
1595         * WebCore.xcodeproj/project.pbxproj: Updated project.
1596
1597         * bridge/mac/FrameMac.mm: Updated includes.
1598         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
1599         * loader/mac/FrameLoader.mm: Ditto.
1600         * loader/mac/WebLoader.h: Ditto.
1601
1602 2006-10-29  Darin Adler  <darin@apple.com>
1603
1604         Reviewed by Mitz.
1605
1606         - fix crash visible on buildbot and also when running the test
1607           anchor-image-scrolled-x-y.html under libgmalloc
1608
1609         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
1610         now that the class is named ResourceHandle.
1611         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
1612         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
1613         a local RefPtr before calling finishJobAndHandle, since we might get
1614         cancelled inside that function, so we should not rely on m_handle to
1615         keep the ResourceHandle alive.
1616         (WebCore::SubresourceLoader::didFail): Ditto.
1617         (WebCore::SubresourceLoader::didCancel): Ditto.
1618
1619 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1620
1621         - build fix
1622
1623         * platform/network/mac/ResourceHandleMac.mm:
1624
1625 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1626
1627         Rubber stamped by Darin.
1628
1629         - renamed ResourceLoader to ResourceHandle (and same for related classes)
1630
1631         * CMakeLists.txt:
1632         * Projects/gdk/webcore-gdk.bkl:
1633         * WebCore.vcproj/WebCore/WebCore.vcproj:
1634         * WebCore.xcodeproj/project.pbxproj:
1635         * WebCoreSources.bkl:
1636         * bridge/mac/FrameMac.mm:
1637         * bridge/win/FrameWin.cpp:
1638         * dom/XMLTokenizer.cpp:
1639         * loader/Cache.cpp:
1640         * loader/CachedResource.h:
1641         * loader/LoaderFunctions.h:
1642         * loader/icon/IconLoader.cpp:
1643         (IconLoader::startLoading):
1644         (IconLoader::didReceiveData):
1645         (IconLoader::didFinishLoading):
1646         * loader/icon/IconLoader.h:
1647         * loader/loader.cpp:
1648         (WebCore::Loader::servePendingRequests):
1649         (WebCore::Loader::receivedAllData):
1650         (WebCore::Loader::receivedResponse):
1651         (WebCore::Loader::didReceiveData):
1652         (WebCore::Loader::cancelRequests):
1653         (WebCore::Loader::jobForRequest):
1654         * loader/loader.h:
1655         * loader/mac/IconLoaderMac.mm:
1656         (IconLoader::receivedResponse):
1657         * loader/mac/LoaderFunctionsMac.mm:
1658         * loader/mac/WebLoader.h:
1659         * loader/mac/WebSubresourceLoader.h:
1660         * loader/mac/WebSubresourceLoader.mm:
1661         (WebCore::SubresourceLoader::SubresourceLoader):
1662         (WebCore::SubresourceLoader::create):
1663         * platform/gdk/FrameGdk.cpp:
1664         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
1665         (WebCore::FrameGdkClientDefault::openURL):
1666         (WebCore::FrameGdkClientDefault::submitForm):
1667         (WebCore::FrameGdkClientDefault::receivedResponse):
1668         (WebCore::FrameGdkClientDefault::didReceiveData):
1669         (WebCore::FrameGdkClientDefault::receivedAllData):
1670         * platform/gdk/FrameGdk.h:
1671         * platform/gdk/TemporaryLinkStubs.cpp:
1672         (WebCore::ServeSynchronousRequest):
1673         (WebCore::ResourceHandle::assembleResponseHeaders):
1674         (WebCore::ResourceHandle::retrieveCharset):
1675         * platform/network/ResourceHandle.cpp: Added.
1676         (WebCore::ResourceHandle::ResourceHandle):
1677         (WebCore::ResourceHandle::create):
1678         (WebCore::ResourceHandle::isErrorPage):
1679         (WebCore::ResourceHandle::error):
1680         (WebCore::ResourceHandle::setError):
1681         (WebCore::ResourceHandle::responseEncoding):
1682         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
1683         (WebCore::ResourceHandle::kill):
1684         (WebCore::ResourceHandle::requestHeaders):
1685         (WebCore::ResourceHandle::url):
1686         (WebCore::ResourceHandle::postData):
1687         (WebCore::ResourceHandle::method):
1688         (WebCore::ResourceHandle::client):
1689         * platform/network/ResourceHandle.h: Added.
1690         (WebCore::ResourceHandle::getInternal):
1691         * platform/network/ResourceHandleClient.h: Added.
1692         (WebCore::ResourceHandleClient::~ResourceHandleClient):
1693         (WebCore::ResourceHandleClient::didReceiveData):
1694         (WebCore::ResourceHandleClient::didFinishLoading):
1695         (WebCore::ResourceHandleClient::receivedRedirect):
1696         (WebCore::ResourceHandleClient::receivedResponse):
1697         (WebCore::ResourceHandleClient::receivedAllData):
1698         * platform/network/ResourceHandleInternal.h: Added.
1699         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1700         * platform/network/ResourceLoader.cpp: Removed.
1701         * platform/network/ResourceLoader.h: Removed.
1702         * platform/network/ResourceLoaderClient.h: Removed.
1703         * platform/network/ResourceLoaderInternal.h: Removed.
1704         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
1705         (WebCore::willSendRequest):
1706         (WebCore::didReceiveResponse):
1707         (WebCore::didReceiveData):
1708         (WebCore::didFinishLoading):
1709         (WebCore::didFail):
1710         (WebCore::willCacheResponse):
1711         (WebCore::didReceiveChallenge):
1712         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1713         (WebCore::ResourceHandle::~ResourceHandle):
1714         (WebCore::ResourceHandle::start):
1715         (WebCore::ResourceHandle::cancel):
1716         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
1717         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
1718         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1719         (WebCore::ResourceHandle::~ResourceHandle):
1720         (WebCore::ResourceHandle::start):
1721         (WebCore::ResourceHandle::cancel):
1722         * platform/network/gdk/ResourceHandleManager.cpp: Added.
1723         (WebCore::ResourceHandleManager::ResourceHandleManager):
1724         (WebCore::ResourceHandleManager::get):
1725         (WebCore::ResourceHandleManager::useSimpleTransfer):
1726         (WebCore::writeCallback):
1727         (WebCore::ResourceHandleManager::downloadTimerCallback):
1728         (WebCore::ResourceHandleManager::remove):
1729         (WebCore::ResourceHandleManager::add):
1730         (WebCore::ResourceHandleManager::cancel):
1731         * platform/network/gdk/ResourceHandleManager.h: Added.
1732         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
1733         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
1734         * platform/network/gdk/ResourceLoaderManager.h: Removed.
1735         * platform/network/mac/ResourceHandleMac.mm: Added.
1736         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1737         (WebCore::ResourceHandle::~ResourceHandle):
1738         (WebCore::ResourceHandle::start):
1739         (WebCore::ResourceHandle::assembleResponseHeaders):
1740         (WebCore::ResourceHandle::retrieveResponseEncoding):
1741         (WebCore::ResourceHandle::receivedResponse):
1742         (WebCore::ResourceHandle::cancel):
1743         (WebCore::ResourceHandle::redirectedToURL):
1744         (WebCore::ResourceHandle::addData):
1745         (WebCore::ResourceHandle::finishJobAndHandle):
1746         (WebCore::ResourceHandle::reportError):
1747         * platform/network/mac/ResourceLoaderMac.mm: Removed.
1748         * platform/network/qt/ResourceHandleManager.cpp: Added.
1749         (WebCore::ResourceHandleManager::ResourceHandleManager):
1750         (WebCore::ResourceHandleManager::~ResourceHandleManager):
1751         (WebCore::ResourceHandleManager::self):
1752         (WebCore::ResourceHandleManager::slotData):
1753         (WebCore::ResourceHandleManager::slotMimetype):
1754         (WebCore::ResourceHandleManager::slotResult):
1755         (WebCore::ResourceHandleManager::remove):
1756         (WebCore::ResourceHandleManager::add):
1757         (WebCore::ResourceHandleManager::cancel):
1758         * platform/network/qt/ResourceHandleManager.h: Added.
1759         * platform/network/qt/ResourceHandleQt.cpp: Added.
1760         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1761         (WebCore::ResourceHandle::~ResourceHandle):
1762         (WebCore::ResourceHandle::start):
1763         (WebCore::ResourceHandle::cancel):
1764         (WebCore::ResourceHandle::assembleResponseHeaders):
1765         (WebCore::ResourceHandle::retrieveResponseEncoding):
1766         (WebCore::ResourceHandle::receivedResponse):
1767         (WebCore::ResourceHandle::extractCharsetFromHeaders):
1768         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
1769         * platform/network/qt/ResourceLoaderManager.h: Removed.
1770         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
1771         * platform/network/win/ResourceHandleWin.cpp: Added.
1772         (WebCore::):
1773         (WebCore::addToOutstandingJobs):
1774         (WebCore::lookupResourceHandle):
1775         (WebCore::ResourceHandleWndProc):
1776         (WebCore::initializeOffScreenResourceHandleWindow):
1777         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1778         (WebCore::ResourceHandle::~ResourceHandle):
1779         (WebCore::ResourceHandle::onHandleCreated):
1780         (WebCore::ResourceHandle::onRequestRedirected):
1781         (WebCore::ResourceHandle::onRequestComplete):
1782         (WebCore::ResourceHandle::start):
1783         (WebCore::ResourceHandle::fileLoadTimer):
1784         (WebCore::ResourceHandle::cancel):
1785         (WebCore::ResourceHandle::setHasReceivedResponse):
1786         (WebCore::ResourceHandle::hasReceivedResponse):
1787         * platform/network/win/ResourceHandleWin.h: Added.
1788         * platform/network/win/ResourceLoaderWin.cpp: Removed.
1789         * platform/network/win/ResourceLoaderWin.h: Removed.
1790         * platform/qt/FrameQt.cpp:
1791         * platform/qt/FrameQtClient.cpp:
1792         (WebCore::FrameQtClientDefault::openURL):
1793         (WebCore::FrameQtClientDefault::submitForm):
1794         (WebCore::FrameQtClientDefault::receivedResponse):
1795         (WebCore::FrameQtClientDefault::didReceiveData):
1796         (WebCore::FrameQtClientDefault::receivedAllData):
1797         * platform/qt/FrameQtClient.h:
1798         * platform/win/TemporaryLinkStubs.cpp:
1799         (WebCore::ResourceHandle::assembleResponseHeaders):
1800         (WebCore::ResourceHandle::retrieveResponseEncoding):
1801         (WebCore::ServeSynchronousRequest):
1802         * xml/XSLTProcessor.cpp:
1803         * xml/xmlhttprequest.cpp:
1804         (WebCore::XMLHttpRequest::send):
1805         (WebCore::XMLHttpRequest::didFinishLoading):
1806         (WebCore::XMLHttpRequest::receivedRedirect):
1807         (WebCore::XMLHttpRequest::didReceiveData):
1808         * xml/xmlhttprequest.h:
1809
1810 t2006-10-29  Darin Adler  <darin@apple.com>
1811
1812         Reviewed by Maciej.
1813
1814         - eliminate use of NSArray to carry form data around
1815
1816         * WebCore.exp:
1817         * WebCore.xcodeproj/project.pbxproj:
1818         * bridge/mac/FormDataMac.h: Removed.
1819         * bridge/mac/FormDataMac.mm: Removed.
1820         * bridge/mac/FrameMac.h:
1821         * bridge/mac/WebCoreFrameBridge.h:
1822         * bridge/mac/WebCoreFrameBridge.mm:
1823         * html/HTMLFormElement.cpp:
1824         (WebCore::HTMLFormElement::submit):
1825         * loader/FormData.h:
1826         (WebCore::FormData::isEmpty):
1827         * loader/mac/FrameLoader.h:
1828         * loader/mac/FrameLoader.mm:
1829         (WebCore::FrameLoader::load):
1830         (WebCore::FrameLoader::post):
1831         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
1832         (WebCore::FrameLoader::loadResourceSynchronously):
1833         * loader/mac/LoaderFunctionsMac.mm:
1834         (WebCore::ServeSynchronousRequest):
1835         * loader/mac/WebFormDataStream.h:
1836         * loader/mac/WebFormDataStream.m:
1837         (WebCore::pairRetain):
1838         (WebCore::pairRelease):
1839         (WebCore::pairEqual):
1840         (WebCore::pairHash):
1841         (WebCore::closeCurrentStream):
1842         (WebCore::scheduleWithPair):
1843         (WebCore::advanceCurrentStream):
1844         (WebCore::openNextStream):
1845         (WebCore::formCreate):
1846         (WebCore::formFinalize):
1847         (WebCore::formOpen):
1848         (WebCore::formRead):
1849         (WebCore::formCanRead):
1850         (WebCore::formClose):
1851         (WebCore::formSchedule):
1852         (WebCore::formUnschedule):
1853         (WebCore::formEventCallback):
1854         (WebCore::setHTTPBody):
1855         * loader/mac/WebSubresourceLoader.h:
1856         * loader/mac/WebSubresourceLoader.mm:
1857         (WebCore::SubresourceLoader::create):
1858         * platform/network/mac/ResourceLoaderMac.mm:
1859
1860 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1861
1862         Reviewed by Darin.
1863
1864         - create SubresourceLoader with a ResourceRequest, not broken out request bits
1865
1866         * loader/mac/WebSubresourceLoader.h:
1867         * loader/mac/WebSubresourceLoader.mm:
1868         (WebCore::SubresourceLoader::create):
1869         * platform/network/mac/ResourceLoaderMac.mm:
1870         (WebCore::ResourceLoader::start):
1871
1872 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1873
1874         Reviewed by Darin.
1875
1876         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
1877
1878         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
1879         
1880         * WebCore.xcodeproj/project.pbxproj:
1881         * bridge/mac/WebCoreFrameBridge.h:
1882         * loader/mac/FrameLoader.h:
1883         * loader/mac/FrameLoader.mm:
1884         * loader/mac/LoaderFunctionsMac.mm:
1885         * loader/mac/WebLoader.h:
1886         * loader/mac/WebSubresourceLoader.h:
1887         * loader/mac/WebSubresourceLoader.mm:
1888         (WebCore::SubresourceLoader::SubresourceLoader):
1889         (WebCore::SubresourceLoader::create):
1890         (WebCore::SubresourceLoader::willSendRequest):
1891         (WebCore::SubresourceLoader::didReceiveResponse):
1892         (WebCore::SubresourceLoader::didReceiveData):
1893         (WebCore::SubresourceLoader::didFinishLoading):
1894         (WebCore::SubresourceLoader::didFail):
1895         (WebCore::SubresourceLoader::didCancel):
1896         * platform/network/ResourceLoader.h:
1897         * platform/network/ResourceLoaderInternal.h:
1898         * platform/network/mac/ResourceLoaderMac.mm:
1899         (WebCore::ResourceLoader::~ResourceLoader):
1900         (WebCore::ResourceLoader::start):
1901         (WebCore::ResourceLoader::receivedResponse):
1902         (WebCore::ResourceLoader::cancel):
1903         (WebCore::ResourceLoader::redirectedToURL):
1904         (WebCore::ResourceLoader::addData):
1905         (WebCore::ResourceLoader::finishJobAndHandle):
1906         (WebCore::ResourceLoader::reportError):
1907         * platform/network/mac/WebCoreResourceLoader.h: Removed.
1908         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
1909         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
1910
1911 2006-10-28  Darin Adler  <darin@apple.com>
1912
1913         Reviewed by Maciej.
1914
1915         - eliminated the use of Objective-C for the policy decider
1916           machinery, obviating the need for WebPolicyDecider,
1917           WebCoreFrameLoaderAsDelegate, and
1918           WebCoreMainResourceLoaderAsPolicyDelegate
1919
1920         - grouped the state related to policy decisions into a PolicyCheck
1921           class to simplify the FrameLoader logic
1922
1923         - removed six methods from the bridge, reducing FrameLoader's use of
1924           the bridge to a single method
1925
1926         - changed form state to always use HashMap instead of NSDictionary
1927
1928         - moved the defersLoading flag from WebView to WebCore::Page
1929           and changed code to consistently call it defersLoading rather
1930           than defersCallbacks
1931
1932         - updated for rename of PassRefPtr::release to releaseRef
1933         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
1934         - cleaned up kjs_binding.h a bit
1935         - cleaned up FrameMac.h a bit
1936
1937         * loader/mac/WebPolicyDecider.h: Removed.
1938         * loader/mac/WebPolicyDecider.mm: Removed.
1939         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
1940
1941         * WebCore.exp:
1942         * bindings/js/kjs_binding.cpp:
1943         (KJS::ScriptInterpreter::ScriptInterpreter):
1944         (KJS::ScriptInterpreter::wasRunByUserGesture):
1945         * bindings/js/kjs_binding.h:
1946         (KJS::ScriptInterpreter::setCurrentEvent):
1947         (KJS::ScriptInterpreter::setInlineCode):
1948         (KJS::ScriptInterpreter::setProcessingTimerCallback):
1949         (KJS::ScriptInterpreter::getCurrentEvent):
1950         (KJS::cacheDOMObject):
1951         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
1952         * bridge/AXObjectCache.h:
1953         * bridge/mac/BrowserExtensionMac.mm:
1954         (WebCore::BrowserExtensionMac::createNewWindow):
1955         * bridge/mac/FrameMac.h:
1956         * bridge/mac/FrameMac.mm:
1957         (WebCore::FrameMac::loadRequest):
1958         (WebCore::FrameMac::submitForm):
1959         (WebCore::FrameMac::urlSelected):
1960         (WebCore::FrameMac::userAgent):
1961         (WebCore::FrameMac::passMouseDownEventToWidget):
1962         (WebCore::FrameMac::handleMouseMoveEvent):
1963         * bridge/mac/PageMac.mm:
1964         (WebCore::Page::Page):
1965         * bridge/mac/WebCoreEditCommand.mm:
1966         * bridge/mac/WebCoreFrameBridge.h:
1967         * bridge/mac/WebCoreFrameBridge.mm:
1968         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
1969         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
1970         * css/CSSComputedStyleDeclaration.cpp:
1971         (WebCore::):
1972         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1973         * css/CSSPrimitiveValue.cpp:
1974         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1975         (WebCore::CSSPrimitiveValue::cleanup):
1976         (WebCore::CSSPrimitiveValue::cssText):
1977         * css/CSSPrimitiveValue.h:
1978         (WebCore::CSSPrimitiveValue::):
1979         * css/CSSValueList.cpp:
1980         (WebCore::CSSValueList::append):
1981         * css/cssparser.cpp:
1982         (WebCore::CSSParser::parseValue):
1983         * css/cssparser.h:
1984         * css/cssstyleselector.cpp:
1985         (WebCore::CSSStyleSelector::applyProperty):
1986         * dom/Document.cpp:
1987         (WebCore::Document::Document):
1988         (WebCore::Document::updateSelection):
1989         (WebCore::Document::implicitClose):
1990         (WebCore::Document::setFocusNode):
1991         * dom/Document.h:
1992         * editing/ReplaceSelectionCommand.h:
1993         * html/HTMLParser.cpp:
1994         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
1995         * loader/mac/FrameLoader.h:
1996         (WebCore::PolicyCheck::request):
1997         * loader/mac/FrameLoader.mm:
1998         (WebCore::FrameLoader::~FrameLoader):
1999         (WebCore::FrameLoader::safeLoad):
2000         (WebCore::FrameLoader::load):
2001         (WebCore::FrameLoader::open):
2002         (WebCore::FrameLoader::stopLoading):
2003         (WebCore::setAllDefersLoading):
2004         (WebCore::FrameLoader::setDefersLoading):
2005         (WebCore::FrameLoader::willSendRequest):
2006         (WebCore::FrameLoader::receivedMainResourceError):
2007         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2008         (WebCore::FrameLoader::commitProvisionalLoad):
2009         (WebCore::FrameLoader::checkNavigationPolicy):
2010         (WebCore::FrameLoader::checkContentPolicy):
2011         (WebCore::FrameLoader::cancelContentPolicyCheck):
2012         (WebCore::FrameLoader::stopPolicyCheck):
2013         (WebCore::FrameLoader::checkNewWindowPolicy):
2014         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2015         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2016         (WebCore::FrameLoader::continueAfterContentPolicy):
2017         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2018         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
2019         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2020         (WebCore::FrameLoader::closeDocument):
2021         (WebCore::FrameLoader::transitionToCommitted):
2022         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
2023         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2024         (WebCore::FrameLoader::post):
2025         (WebCore::FrameLoader::detachFromParent):
2026         (WebCore::FrameLoader::addExtraFieldsToRequest):
2027         (WebCore::PolicyCheck::PolicyCheck):
2028         (WebCore::PolicyCheck::clear):
2029         (WebCore::PolicyCheck::set):
2030         (WebCore::PolicyCheck::call):
2031         (WebCore::PolicyCheck::dropRequest):
2032         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2033         * loader/mac/WebFormState.h:
2034         * loader/mac/WebFormState.mm:
2035         * loader/mac/WebFrameLoaderClient.h:
2036         * loader/mac/WebLoader.h:
2037         (WebCore::WebResourceLoader::defersLoading):
2038         * loader/mac/WebLoader.mm:
2039         (WebCore::WebResourceLoader::WebResourceLoader):
2040         (WebCore::WebResourceLoader::load):
2041         (WebCore::WebResourceLoader::setDefersLoading):
2042         * loader/mac/WebMainResourceLoader.h:
2043         * loader/mac/WebMainResourceLoader.mm:
2044         (WebCore::MainResourceLoader::MainResourceLoader):
2045         (WebCore::MainResourceLoader::releaseDelegate):
2046         (WebCore::MainResourceLoader::didCancel):
2047         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2048         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2049         (WebCore::MainResourceLoader::willSendRequest):
2050         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2051         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2052         (WebCore::MainResourceLoader::didReceiveResponse):
2053         (WebCore::MainResourceLoader::didReceiveData):
2054         (WebCore::MainResourceLoader::didFinishLoading):
2055         (WebCore::MainResourceLoader::didFail):
2056         (WebCore::MainResourceLoader::loadNow):
2057         (WebCore::MainResourceLoader::load):
2058         (WebCore::MainResourceLoader::setDefersLoading):
2059         * page/Frame.cpp:
2060         (WebCore::Frame::paint):
2061         * page/FrameView.cpp:
2062         (WebCore::FrameView::layout):
2063         * page/FrameView.h:
2064         * page/Page.cpp:
2065         (WebCore::Page::setDefersLoading):
2066         * page/Page.h:
2067         (WebCore::Page::defersLoading):
2068         * platform/DeprecatedString.h:
2069         * platform/DeprecatedStringList.h:
2070         * platform/FontFallbackList.h:
2071         * platform/PlatformKeyboardEvent.h:
2072         * platform/PlatformMouseEvent.h:
2073         * platform/PlatformWheelEvent.h:
2074         * platform/mac/ClipboardMac.h:
2075         * platform/mac/ClipboardMac.mm:
2076         (WebCore::ClipboardMac::setDragImage):
2077         (WebCore::ClipboardMac::dragNSImage):
2078         (WebCore::ClipboardMac::sourceOperation):
2079         (WebCore::ClipboardMac::destinationOperation):
2080         * rendering/RenderObject.cpp:
2081         (WebCore::RenderObject::setStyle):
2082         * rendering/break_lines.cpp:
2083         (WebCore::nextBreakablePosition):
2084
2085 2006-10-28  Adam Roben  <aroben@apple.com>
2086
2087         Reviewed by Maciej.
2088
2089         Fix layout tests that broke after r17399. Mitz discovered that the
2090         failures were caused by HitTestResult::m_point being uninitialized
2091         much of the time. HitTestResults are now always constructed with a
2092         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
2093         point instead of being passed one explicitly.
2094
2095         * WebCore.exp: Change constructor symbol.
2096         * bridge/mac/FrameMac.mm:
2097         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
2098         hitTest().
2099         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
2100         * bridge/mac/WebCoreAXObject.mm:
2101         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
2102         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
2103         * dom/Document.cpp:
2104         (WebCore::Document::elementFromPoint): Ditto.
2105         (WebCore::Document::prepareMouseEvent): Ditto.
2106         * page/Frame.cpp:
2107         (WebCore::Frame::isPointInsideSelection): Ditto.
2108         (WebCore::Frame::hitTestResultAtPoint): Ditto.
2109         * page/FrameView.cpp:
2110         (WebCore::FrameView::handleWheelEvent): Ditto.
2111         * rendering/HitTestResult.cpp:
2112         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
2113         passed point.
2114         * rendering/HitTestResult.h: Update constructor declaration.
2115         * rendering/RenderLayer.cpp:
2116         (WebCore::RenderLayer::autoscroll): Update to new constructor and
2117         hitTest().
2118         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
2119         HitTestResult instead of being passed one.
2120         (WebCore::RenderLayer::hitTestLayer): Ditto.
2121         * rendering/RenderLayer.h: Update declarations.
2122
2123 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
2124
2125         Reviewed by Anders.
2126
2127         Fix Qt/Linux build.
2128
2129         * CMakeLists.txt:
2130         * platform/qt/FrameQtClient.cpp:
2131         (WebCore::numRequests):
2132         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
2133         * platform/qt/PopupMenuQt.cpp:
2134         (WebCore::PopupMenu::updateFromElement):
2135
2136 2006-10-28  David Carson  <dacarson@gmail.com>
2137
2138         Tweaked by Sam. Reviewed by Brady.
2139
2140         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
2141         Initialize m_modifyBiasSet to false, as it sometimes gets 
2142         used before it has been initalized.
2143
2144         * editing/SelectionController.cpp:
2145         (WebCore::SelectionController::SelectionController):
2146
2147 2006-10-28  Beth Dakin  <bdakin@apple.com>
2148
2149         Reviewed by Darin.
2150
2151         This is the WebCore half of pushing elementAtPoint and the backend 
2152         of WebElementDictionary into WebCore. Most of the changes below are 
2153         to accommodate one of the following:
2154                 
2155         -NodeInfo is now a stand-alone class called HitTestResult. 
2156                 Previously it was defined in RenderObject.h, but not for 
2157                 any particular reason. The WebElementDictionary 
2158                 functionality that was pushed into WebCore has been pushed 
2159                 specifically into the this class. In fact, 
2160                 WebElementDictionary now keeps a HitTestResult as a member 
2161                 varibale.
2162                 
2163         -The enumeration AccessPolicy is now called 
2164                 ClipboardAccessPolicy and is defined in its own header. It 
2165                 was previously defined in ClipboardMac.h, but is now 
2166                 defined independently to avoid including ClipboardMac.h 
2167                 from within FrameMac.h since FrameMac.h is now included in 
2168                 WebElementDictionary.m in WebKit.
2169                 
2170         -Element now has a virtual target() for the sake of 
2171                 NodeInfo::targetFrame() 
2172
2173         * WebCore.exp: Several WebCore functions are newly called from 
2174         WebKit, so they have been added here. 
2175         * WebCore.xcodeproj/project.pbxproj:
2176         * bindings/objc/DOM.mm: Must include Image.h because of adjustments 
2177         to ClipboardMac.
2178         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
2179         * bridge/mac/FrameMac.mm:
2180         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy 
2181         and HitTestResult changes.
2182         (WebCore::FrameMac::eventMayStartDrag): Same.
2183         (WebCore::FrameMac::handleMouseMoveEvent): Same.
2184         (WebCore::FrameMac::dispatchCPPEvent): Same.
2185         (WebCore::FrameMac::mayDHTMLCut): Same.
2186         (WebCore::FrameMac::mayDHTMLCopy): Same.
2187         (WebCore::FrameMac::mayDHTMLPaste): Same.
2188         (WebCore::FrameMac::tryDHTMLCut): Same
2189         (WebCore::FrameMac::tryDHTMLCopy): Same.
2190         (WebCore::FrameMac::tryDHTMLPaste): Same.
2191         * bridge/mac/WebCoreAXObject.mm:
2192         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to 
2193         HitTestResult changes.
2194         (-[WebCoreAXObject accessibilityHitTest:]): Same.
2195         * bridge/mac/WebCoreFrameBridge.h: Same.
2196         * bridge/mac/WebCoreFrameBridge.mm:
2197         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for 
2198         ClipboardAccessPolicy changes.
2199         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
2200         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
2201         * dom/Document.cpp:
2202         (WebCore::Document::elementFromPoint): Adjust for HitTestResult 
2203         changes.
2204         (WebCore::Document::prepareMouseEvent): Same.
2205         * dom/Element.h:
2206         (WebCore::Element::target): Now has a virtual target()
2207         * html/HTMLAnchorElement.h: Same.
2208         * html/HTMLAreaElement.cpp:
2209         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult 
2210         changes.
2211         * html/HTMLAreaElement.h: Virtual target()
2212         * html/HTMLBaseElement.h:
2213         (WebCore::HTMLBaseElement::target): Same.
2214         * html/HTMLFormElement.h: Same.
2215         * html/HTMLLinkElement.h: Same.
2216         * html/HTMLMapElement.cpp:
2217         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult 
2218         changes.
2219         * html/HTMLMapElement.h: Same.
2220         * page/Frame.cpp:
2221         (WebCore::Frame::isPointInsideSelection): Same.
2222         (WebCore::Frame::hitTestResultAtPoint): Same. 
2223         * page/Frame.h: Same.
2224         * page/FrameView.cpp:
2225         (WebCore::FrameView::handleWheelEvent): Same.
2226         * platform/mac/ClipboardAccessPolicy.h: Added.
2227         (WebCore::):
2228         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, 
2229         include ClipboardAccessPolicy.h, and rename AccessPolicy to 
2230         ClipboardAccessPolicy.
2231         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
2232         (WebCore::ClipboardMac::ClipboardMac):
2233         (WebCore::ClipboardMac::setAccessPolicy):
2234         (WebCore::ClipboardMac::clearData):
2235         (WebCore::ClipboardMac::clearAllData):
2236         (WebCore::ClipboardMac::getData):
2237         (WebCore::ClipboardMac::setData):
2238         (WebCore::ClipboardMac::types):
2239         (WebCore::ClipboardMac::setDragImage):
2240         (WebCore::ClipboardMac::setDropEffect):
2241         (WebCore::ClipboardMac::setEffectAllowed):
2242         * rendering/EllipsisBox.cpp:
2243         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult 
2244         changes.
2245         * rendering/EllipsisBox.h:
2246         * rendering/HitTestResult.cpp: Added.
2247         (WebCore::HitTestResult::HitTestResult):
2248         (WebCore::HitTestResult::~HitTestResult):
2249         (WebCore::HitTestResult::operator=):
2250         (WebCore::HitTestResult::setInnerNode):
2251         (WebCore::HitTestResult::setInnerNonSharedNode):
2252         (WebCore::HitTestResult::setURLElement):
2253         (WebCore::HitTestResult::setScrollbar):
2254         (WebCore::HitTestResult::targetFrame):
2255         (WebCore::HitTestResult::boundingBox):
2256         (WebCore::HitTestResult::isSelected):
2257         (WebCore::HitTestResult::title):
2258         * rendering/HitTestResult.h: Added.
2259         (WebCore::HitTestResult::readonly):
2260         (WebCore::HitTestResult::active):
2261         (WebCore::HitTestResult::mouseMove):
2262         (WebCore::HitTestResult::innerNode):
2263         (WebCore::HitTestResult::innerNonSharedNode):
2264         (WebCore::HitTestResult::point):
2265         (WebCore::HitTestResult::URLElement):
2266         (WebCore::HitTestResult::scrollbar):
2267         (WebCore::HitTestResult::setPoint):
2268         (WebCore::HitTestResult::setReadonly):
2269         (WebCore::HitTestResult::setActive):
2270         (WebCore::HitTestResult::setMouseMove):
2271         * rendering/InlineBox.cpp:
2272         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
2273         * rendering/InlineBox.h: Same.
2274         * rendering/InlineFlowBox.cpp:
2275         (WebCore::InlineFlowBox::nodeAtPoint): Same.
2276         * rendering/InlineFlowBox.h: Same.
2277         * rendering/InlineTextBox.cpp: 
2278         (WebCore::InlineTextBox::nodeAtPoint): Same.
2279         * rendering/InlineTextBox.h: Same.
2280         * rendering/RenderBlock.cpp:
2281         (WebCore::RenderBlock::isPointInScrollbar): Same.
2282         (WebCore::RenderBlock::nodeAtPoint): Same.
2283         * rendering/RenderBlock.h: Same.
2284         * rendering/RenderBox.cpp:
2285         (WebCore::RenderBox::nodeAtPoint): Same.
2286         * rendering/RenderBox.h: Same.
2287         * rendering/RenderFlow.cpp:
2288         (WebCore::RenderFlow::hitTestLines): Same.
2289         * rendering/RenderFlow.h: Same.
2290         * rendering/RenderForeignObject.cpp:
2291         (WebCore::RenderForeignObject::nodeAtPoint): Same.
2292         * rendering/RenderForeignObject.h: Same.
2293         * rendering/RenderFrameSet.cpp:
2294         (WebCore::RenderFrameSet::nodeAtPoint): Same.
2295         * rendering/RenderFrameSet.h: Same.
2296         * rendering/RenderImage.cpp:
2297         (WebCore::RenderImage::nodeAtPoint): Same.
2298         * rendering/RenderImage.h: Same.
2299         * rendering/RenderInline.cpp:
2300         (WebCore::RenderInline::nodeAtPoint): Same.
2301         * rendering/RenderInline.h: Same.
2302         * rendering/RenderLayer.cpp:
2303         (WebCore::RenderLayer::autoscroll): Same.
2304         (WebCore::RenderLayer::hitTest): Same.
2305         (WebCore::RenderLayer::hitTestLayer): Same.
2306         (WebCore::RenderLayer::updateHoverActiveState): Same.
2307         * rendering/RenderLayer.h: Same.
2308         * rendering/RenderListBox.cpp:
2309         (WebCore::RenderListBox::isPointInScrollbar): Same.
2310         * rendering/RenderListBox.h: Same.
2311         * rendering/RenderObject.cpp:
2312         (WebCore::RenderObject::hitTest): Same.
2313         (WebCore::RenderObject::setInnerNode): Same.
2314         (WebCore::RenderObject::nodeAtPoint): Same.
2315         * rendering/RenderObject.h: Remove NodeInfo class and forward 
2316         declare HitTestResult.
2317         * rendering/RenderPath.cpp:
2318         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult 
2319         changes.
2320         * rendering/RenderPath.h: Same.
2321         * rendering/RenderSVGImage.cpp:
2322         (WebCore::RenderSVGImage::nodeAtPoint): Same.
2323         * rendering/RenderSVGImage.h: Same
2324         * rendering/RenderSVGText.cpp:
2325         (WebCore::RenderSVGText::nodeAtPoint): Same.
2326         * rendering/RenderSVGText.h: Same.
2327         * rendering/RenderTableRow.cpp:
2328         (WebCore::RenderTableRow::nodeAtPoint): Same.
2329         * rendering/RenderTableRow.h: Same.
2330         * rendering/RenderTableSection.cpp:
2331         (WebCore::RenderTableSection::nodeAtPoint): Same.
2332         * rendering/RenderTableSection.h: Same.
2333         * rendering/RenderText.h: Same.
2334         (WebCore::RenderText::nodeAtPoint): Same.
2335         * rendering/RenderTextControl.cpp:
2336         (WebCore::RenderTextControl::nodeAtPoint): Same.
2337         * rendering/RenderTextControl.h: Same.
2338         * rendering/RootInlineBox.cpp:
2339         (WebCore::RootInlineBox::nodeAtPoint): Same.
2340         * rendering/RootInlineBox.h: Same.
2341
2342 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2343
2344         Reviewed by Anders.
2345
2346         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
2347         impact of fixing it again.
2348
2349         * bridge/mac/FrameMac.mm:
2350         (WebCore::FrameMac::clear):
2351
2352 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2353
2354         Reviewed by John & Adam.
2355
2356         - assorted speedups to fix perf regression from fixing correctness regression
2357
2358         * WebCore.exp: exported new methods.
2359         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
2360         * bridge/mac/WebCoreFrameBridge.h:
2361         * bridge/mac/WebCoreFrameBridge.mm:
2362         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
2363         * loader/CachedResource.h:
2364         * loader/mac/CachedResourceMac.mm: Added.
2365         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
2366         now cached in the CachedObject.
2367         * loader/mac/FrameLoader.h:
2368         * loader/mac/FrameLoader.mm:
2369         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
2370         the WebKit side do faster dispatch for clients that implement the fast path delegate. 
2371         * loader/mac/LoaderFunctionsMac.mm:
2372         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
2373         just call loadedResourceFromMemoryCache.
2374         * loader/mac/WebFrameLoaderClient.h:
2375
2376 2006-10-27  Oliver Hunt  <oliver@apple.com>
2377
2378         Reviewed by Maciej.
2379
2380         build fix
2381
2382         * dom/Document.cpp:
2383         (WebCore::Document::referrer):
2384
2385 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
2386
2387         Reviewed by Maciej.
2388
2389         Moved some WebCoreFrameBridge functions into FrameLoader.
2390         
2391         I had to make FrameLoader.h capable of compiling in C++-only source files
2392         by adding some forward declarations and __OBJC__ #ifdefs.
2393
2394         * WebCore.exp:
2395         * bridge/mac/FrameMac.h:
2396         * bridge/mac/FrameMac.mm:
2397         (WebCore::FrameMac::createEmptyDocument):
2398         (WebCore::FrameMac::tokenizerProcessedData):
2399         * bridge/mac/WebCoreFrameBridge.h:
2400         * bridge/mac/WebCoreFrameBridge.mm:
2401         * dom/Document.cpp:
2402         (WebCore::Document::processHttpEquiv):
2403         (WebCore::Document::referrer):
2404         * loader/LoaderFunctions.h:
2405         * loader/mac/FrameLoader.h:
2406         * loader/mac/FrameLoader.mm:
2407         (WebCore::numRequests):
2408         (WebCore::FrameLoader::numPendingOrLoadingRequests):
2409         (WebCore::FrameLoader::isReloading):
2410         (WebCore::FrameLoader::referrer):
2411         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2412         (WebCore::FrameLoader::startLoadingResource):
2413         * loader/mac/LoaderFunctionsMac.mm:
2414         (WebCore::CheckIfReloading):
2415         * page/Frame.h:
2416         * page/FrameTree.cpp:
2417         (WebCore::FrameTree::isDescendantOf):
2418         (WebCore::FrameTree::traverseNext):
2419         * page/FrameTree.h:
2420         * platform/network/mac/ResourceLoaderMac.mm:
2421         (WebCore::ResourceLoader::start):
2422
2423 2006-10-27  Timothy Hatcher  <timothy@apple.com>
2424
2425         Reviewed by Darin.
2426
2427         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
2428
2429         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
2430
2431         * editing/DeleteButtonController.cpp:
2432         (WebCore::isDeletableElement):
2433         (WebCore::enclosingDeletableElement):
2434         (WebCore::DeleteButtonController::respondToChangedSelection):
2435
2436 2006-10-27  John Sullivan  <sullivan@apple.com>
2437
2438         Reviewed by Kevin Decker
2439         
2440         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
2441         you haven't not finished reading this.
2442
2443         * rendering/InlineTextBox.h:
2444         * rendering/InlineTextBox.cpp:
2445         (WebCore::InlineTextBox::paint):
2446         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
2447         considered also.
2448         (WebCore::InlineTextBox::paintDocumentMarkers):
2449         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
2450         markers should be painted, instead of a marker type. This avoids walking the collection of
2451         markers multiple times back to back. Now handles grammar markers.
2452
2453 2006-10-27  Timothy Hatcher  <timothy@apple.com>
2454
2455         Reviewed by Beth.
2456
2457         Renamed Copy Files to Copy Generated Headers.
2458         Copy 4 DOM*Internal.h headers.
2459
2460         * WebCore.xcodeproj/project.pbxproj:
2461         * bindings/scripts/CodeGeneratorObjC.pm:
2462
2463 2006-10-27  John Sullivan  <sullivan@apple.com>
2464
2465         Reviewed by Anders
2466
2467         * WebCore.exp:
2468         exported symbol for FrameMac->advanceToNextSpelling()
2469         
2470         * bridge/mac/WebCoreFrameBridge.h:
2471         * bridge/mac/WebCoreFrameBridge.mm:
2472         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
2473
2474 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
2475
2476         Reviewed by harrison
2477         
2478         <http://bugs.webkit.org/show_bug.cgi?id=11423>
2479         REGRESSION: First newline missing from textarea's value
2480         
2481         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
2482         
2483         Before my change in r17223, return (an InsertLineBreak) would insert a '\n' 
2484         (the line break) then a br to prevent the '\n' from collapsing, since the 
2485         insertion is being done at the end of a block (the textarea's shadow div).  Then, 
2486         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".  
2487         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed 
2488         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would 
2489         serialize as "foobar" because when serializing RenderTextControl intentionally asks 
2490         textContent to not convert brs to newlines.  It seems to think that the only brs in 
2491         the shadow div will be placeholders or collapsed.
2492         
2493         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak 
2494         to insert two '\n's when at the end of a block in white-space:pre text.  This alone 
2495         would have fixed the bug, but introduced a new one, because foo, return, bar would 
2496         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second 
2497         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to 
2498         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as 
2499         a br or '\n' that will collapse (become superfluous) when content is inserted just 
2500         before it.
2501         
2502         * editing/CompositeEditCommand.cpp:
2503         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
2504         a br or '\n' if content inserted just before it will cause it to collapse.
2505         * editing/CompositeEditCommand.h:
2506         * editing/InsertLineBreakCommand.cpp:
2507         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
2508         to prevent a collapse as was used for the line break.  Fixed comments.
2509         * editing/InsertTextCommand.cpp:
2510         (WebCore::InsertTextCommand::input): Call the renamed function.
2511         
2512 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
2513
2514         Reviewed by Brady.
2515
2516         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
2517         String became an empty NSString *, instead of nil. This will become important
2518         as we start using this conversion more.
2519         
2520         Added work-around for AppKit crash that semantic accuracy revealed.
2521         
2522         No testcase because I don't think there's a way to reflect this change
2523         in a webpage yet.
2524
2525         * platform/PlatformString.h:
2526         (WebCore::String::operator NSString*):
2527         * platform/mac/TextFieldMac.mm:
2528         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2529
2530 2006-10-27  David Harrison  <harrison@apple.com>
2531
2532         Reviewed by Maciej,
2533
2534         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
2535
2536         * bridge/mac/WebCoreAXObject.mm:
2537         (blockquoteLevel):
2538         Calculate and return the blockquote level of the element.
2539         
2540         (AXAttributeStringSetBlockquoteLevel):
2541         Add, if non-zero, or clear the block quote level attribute.
2542         
2543         (AXAttributedStringAppendText):
2544         Send AXAttributeStringSetBlockquoteLevel.
2545
2546 2006-10-27  Darin Adler  <darin@apple.com>
2547
2548         - fix one error in the Qt build
2549
2550         * platform/qt/GraphicsContextQt.cpp:
2551         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2552         Updated.
2553
2554 2006-10-27  Darin Adler  <darin@apple.com>
2555
2556         Reviewed by Maciej.
2557
2558         * WebCore.exp: Export more symbols needed by WebKit.
2559
2560 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
2561
2562         Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.
2563
2564         Fixed layout test crash. Oops.
2565         
2566         * loader/mac/WebDocumentLoader.mm:
2567         (WebCore::canonicalizedTitle):
2568
2569 2006-10-26  John Sullivan  <sullivan@apple.com>
2570
2571         Reviewed by Brady
2572         
2573         - fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
2574         
2575         This restores some of the nil-handling that was implicit before some of the code was converted from
2576         Objective-C to C++.
2577
2578         * bridge/mac/FrameMac.mm:
2579         (WebCore::FrameMac::loadRequest):
2580         handle nil FrameMac
2581         
2582         * bridge/mac/WebCoreFrameBridge.mm:
2583         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
2584         handle nil Frame
2585
2586 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
2587
2588         Reviewed by Darin, Maciej.
2589
2590         Removed many uses of NSString *.
2591         Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing 
2592         stringByCollapsingNonPrintingCharacters with a c++ equivalent.
2593         
2594         PLT says no performance regression.
2595         
2596         * WebCore.exp:
2597         * bridge/mac/WebCoreFrameBridge.mm:
2598         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
2599         * loader/mac/FrameLoader.h:
2600         * loader/mac/FrameLoader.mm:
2601         (WebCore::FrameLoader::setupForReplaceByMIMEType):
2602         (WebCore::FrameLoader::load):
2603         (WebCore::FrameLoader::canShowMIMEType):
2604         (WebCore::FrameLoader::representationExistsForURLScheme):
2605         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
2606         (WebCore::FrameLoader::checkContentPolicy):
2607         (WebCore::FrameLoader::reloadAllowingStaleData):
2608         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
2609         (WebCore::FrameLoader::checkNewWindowPolicy):
2610         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2611         (WebCore::FrameLoader::transitionToCommitted):
2612         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
2613         (WebCore::FrameLoader::post):
2614         * loader/mac/WebDocumentLoader.h:
2615         * loader/mac/WebDocumentLoader.mm:
2616         (WebCore::DocumentLoader::doesProgressiveLoad):
2617         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
2618         (WebCore::DocumentLoader::title):
2619         (WebCore::DocumentLoader::setOverrideEncoding):
2620         (WebCore::DocumentLoader::overrideEncoding):
2621         (WebCore::DocumentLoader::setTitle):
2622         * loader/mac/WebFrameLoaderClient.h:
2623         * loader/mac/WebMainResourceLoader.mm:
2624         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2625
2626 2006-10-26  Timothy Hatcher  <timothy@apple.com>
2627
2628         Reviewed by Adam.
2629
2630         <rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com
2631
2632         The main table at nytimes.com has a fixed width of 874px, but the table ends
2633         up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
2634         this. The other bug was a missing top and left of 0px on the container element,
2635         causing the deletion UI to sometimes be offset below the table.
2636
2637         Now check for the element's renderer at the beginning of show() and
2638         return early if it is null.
2639
2640         * editing/DeleteButtonController.cpp:
2641         (WebCore::DeleteButtonController::updateOutlineStyle):
2642         (WebCore::DeleteButtonController::show):
2643
2644 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
2645
2646         Build fix.
2647
2648         * html/CanvasRenderingContext2D.cpp:
2649         Include MathExtras.h
2650         
2651 2006-10-26  John Sullivan  <sullivan@apple.com>
2652
2653         Reviewed by Anders.
2654
2655         Some changes to support new grammar checking code in WebKit.
2656
2657         * WebCore.exp:
2658         added mangled symbol for Document->removeMarkers() so I can call it from WebKit
2659         
2660         * WebCore.xcodeproj/project.pbxproj:
2661         Made Document.h and DocumentMarker.h private so I can include them from WebKit.
2662         Made HTMLCollection.h private because Document.h uses it.
2663         
2664         * bridge/mac/WebCoreFrameBridge.h:
2665         * bridge/mac/WebCoreFrameBridge.mm:
2666         removed unmarkAllMisspellings(); WebKit now calls through to the Document directly
2667
2668 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
2669
2670         Reviewed by Brady.
2671
2672         Add reverseFind to String and use it instead of findRev.
2673         Use CString instead of DeprecatedCString in one place.
2674         
2675         * html/HTMLFormElement.cpp:
2676         (WebCore::HTMLFormElement::formData):
2677         * ksvg2/svg/SVGURIReference.cpp:
2678         (WebCore::SVGURIReference::getTarget):
2679         * loader/Decoder.cpp:
2680         (WebCore::Decoder::checkForCSSCharset):
2681         * platform/PlatformString.h:
2682         (WebCore::String::reverseFind):
2683         * platform/StringImpl.cpp:
2684         (WebCore::StringImpl::reverseFind):
2685         * platform/StringImpl.h:
2686
2687 2006-10-26  John Sullivan  <sullivan@apple.com>
2688
2689         Reviewed by Darin
2690         
2691         More plumbing for grammar checking. Still no grammars is checked.
2692
2693         * dom/DocumentMarker.h:
2694         (WebCore::DocumentMarker::):
2695         added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"
2696         
2697         * platform/GraphicsContext.h:
2698         renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar;
2699         now takes a bool parameter for whether it represents bad grammar or a misspelling 
2700         
2701         * platform/mac/GraphicsContextMac.mm:
2702         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2703         Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed
2704         an existing "assert" to "ASSERT".
2705         
2706         * rendering/InlineTextBox.h:
2707         renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
2708
2709         * rendering/InlineTextBox.cpp:
2710         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
2711         Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents
2712         bad grammar or a misspelling
2713         (WebCore::InlineTextBox::paintAllMarkersOfType):
2714         now handles markers of type Grammar
2715
2716 === Safari-521.29 ===
2717         
2718 2006-10-26  Sam Weinig  <sam.weinig@gmail.com>
2719
2720         Reviewed by Mitz.
2721
2722         Fix for http://bugs.webkit.org/show_bug.cgi?id=11424
2723         Cleanup rendering code
2724
2725         - Assorted code cleanup.
2726
2727         * rendering/AutoTableLayout.cpp:
2728         * rendering/AutoTableLayout.h:
2729         (WebCore::AutoTableLayout::totalPercent):
2730         * rendering/CounterListItem.h:
2731         * rendering/CounterNode.cpp:
2732         * rendering/CounterNode.h:
2733         (WebCore::CounterNode::~CounterNode):
2734         (WebCore::CounterNode::isReset):
2735         * rendering/CounterResetNode.cpp:
2736         * rendering/CounterResetNode.h:
2737         * rendering/DataRef.h:
2738         (WebCore::DataRef::DataRef):
2739         * rendering/DeprecatedRenderSelect.h:
2740         * rendering/DeprecatedSlider.cpp:
2741         * rendering/DeprecatedSlider.h:
2742         * rendering/EllipsisBox.cpp:
2743         * rendering/EllipsisBox.h:
2744         (WebCore::EllipsisBox::EllipsisBox):
2745         * rendering/FixedTableLayout.cpp:
2746         * rendering/FixedTableLayout.h:
2747         * rendering/GapRects.h:
2748         * rendering/InlineBox.cpp:
2749         * rendering/InlineBox.h:
2750         (WebCore::InlineBox::InlineBox):
2751         (WebCore::InlineBox::setConstructed):
2752         (WebCore::InlineBox::clearTruncation):
2753         (WebCore::InlineBox::markDirty):
2754         * rendering/InlineFlowBox.cpp:
2755         * rendering/InlineFlowBox.h:
2756         (WebCore::InlineFlowBox::InlineFlowBox):
2757         (WebCore::InlineFlowBox::setConstructed):
2758         (WebCore::InlineFlowBox::setEdges):
2759         (WebCore::InlineFlowBox::setVerticalOverflowPositions):
2760         (WebCore::InlineFlowBox::setVerticalSelectionPositions):
2761         * rendering/InlineRunBox.h:
2762         (WebCore::InlineRunBox::paintBackgroundAndBorder):
2763         (WebCore::InlineRunBox::paintDecorations):
2764         * rendering/InlineTextBox.cpp:
2765         * rendering/InlineTextBox.h:
2766         (WebCore::InlineTextBox::InlineTextBox):
2767         (WebCore::InlineTextBox::end):
2768         (WebCore::InlineTextBox::textObject):
2769         * rendering/Length.h:
2770         (WebCore::Length::Length):
2771         * rendering/ListMarkerBox.cpp:
2772         * rendering/ListMarkerBox.h:
2773         * rendering/RenderPartObject.h:
2774         * rendering/RootInlineBox.cpp:
2775         * rendering/RootInlineBox.h:
2776         * rendering/SVGInlineFlowBox.cpp:
2777         * rendering/SVGInlineFlowBox.h:
2778         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
2779         * rendering/SVGRootInlineBox.cpp:
2780         * rendering/SVGRootInlineBox.h:
2781         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
2782         * rendering/TableLayout.h:
2783         (WebCore::TableLayout::TableLayout):
2784         (WebCore::TableLayout::~TableLayout):
2785         * rendering/bidi.h:
2786         (WebCore::BidiStatus::BidiStatus):
2787         (WebCore::BidiRun::BidiRun):
2788         * rendering/break_lines.h:
2789
2790 2006-10-26  Justin Garcia  <justin.garcia@apple.com>
2791
2792         Reviewed by john
2793
2794         <http://bugs.webkit.org/show_bug.cgi?id=11329>
2795         Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.
2796         
2797         * editing/Editor.cpp:
2798         (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor.
2799         Wrapped the plain text fragment in a style span with the document 
2800         default style so that it will appear unstyled regardless of where
2801         it is inserted.  Could have also inserted the plain text fragment 
2802         and then applied the document default style to it, but there is not 
2803         yet any redundant style prevention in ApplyStyleCommand, so this
2804         is cleaner.
2805         * editing/Editor.h:
2806         * editing/JSEditor.cpp:
2807
2808 2006-10-26  Oliver Hunt  <oliver@apple.com>
2809
2810         Reviewed by Anders.
2811         Fixes <rdar://problem/4800518> -- needed to update existing
2812         canvas path elements when transforms are performed on the
2813         context.
2814
2815         * html/CanvasRenderingContext2D.cpp:
2816         (WebCore::CanvasRenderingContext2D::scale):
2817         (WebCore::CanvasRenderingContext2D::rotate):
2818         (WebCore::CanvasRenderingContext2D::translate):
2819
2820 2006-10-26  Nikolas Zimmermann  <zimmermann@kde.org>
2821
2822         Reviewed by Darin.
2823
2824         Fix Qt/Linux build.
2825
2826         * platform/network/qt/ResourceLoaderManager.cpp:
2827         (WebCore::ResourceLoaderManager::slotData):
2828         (WebCore::ResourceLoaderManager::slotMimetype):
2829         (WebCore::ResourceLoaderManager::remove):
2830         (WebCore::ResourceLoaderManager::add):
2831         * platform/network/qt/ResourceLoaderQt.cpp:
2832         (WebCore::ResourceLoader::receivedResponse):
2833         * platform/qt/FrameQtClient.cpp:
2834         (WebCore::FrameQtClientDefault::openURL):
2835         * platform/qt/LoaderFunctionsQt.cpp:
2836         (WebCore::ServeSynchronousRequest):
2837
2838 2006-10-26  Adam Roben  <aroben@apple.com>
2839
2840         Reviewed by Adele.
2841
2842         Fix: <rdar://problem/3951815> add "type-to-select" feature for list
2843         boxes (<select> elements)
2844         Fix: http://bugs.webkit.org/show_bug.cgi?id=9764 New popup menus
2845         should have type-ahead selection without popping up menu
2846
2847         * WebCore.xcodeproj/project.pbxproj: Version wars.
2848         * html/HTMLSelectElement.h: Add new instance variables for type-ahead
2849         find.
2850         * html/HTMLSelectElement.cpp:
2851         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new
2852         instance variables.
2853         (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead
2854         find on printable character presses.
2855         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove
2856         redundant check that the listIndex has changed (setSelectedIndex does
2857         this for us), and fix indentation.
2858         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if
2859         to an else-if.
2860         (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind()
2861         to strip leading whitespace (including non-breaking spaces) from a
2862         string.
2863         (WebCore::HTMLSelectElement::typeAheadFind): New method to perform
2864         type-ahead find.
2865         * platform/PopupMenu.h: Added new updateFromElement() method to be
2866         called from RenderMenuList::updateFromElement().
2867         * platform/mac/PopupMenuMac.mm:
2868         (WebCore::PopupMenu::updateFromElement): While we are using
2869         NSPopUpButtonCell for our popups, this method can stay empty.
2870         * rendering/RenderListBox.cpp:
2871         (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first
2872         selected element.
2873         * rendering/RenderMenuList.cpp:
2874         (WebCore::RenderMenuList::updateFromElement): Tell the popup to update
2875         if it's visible.
2876
2877 2006-10-26  Darin Adler  <darin@apple.com>
2878
2879         Reviewed by Anders.
2880
2881         - fix http://bugs.webkit.org/show_bug.cgi?id=11360
2882           editing/pasteboard/copy-paste-bidi intermittently fails due to disappearance of anonymous RenderBlock
2883
2884         * editing/ReplaceSelectionCommand.cpp:
2885         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
2886         Use two vectors instead of a hash map: more efficient, deterministic. There was no
2887         reason to use a hash table.
2888
2889 2006-10-26  Maciej Stachowiak  <mjs@apple.com>
2890
2891         Reviewed by Anders.
2892
2893         - .5% speed improvement by avoiding excess CFURLRef allocation
2894
2895         * loader/CachedResource.cpp:
2896         (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL
2897         here for later reuse.
2898         * loader/CachedResource.h:
2899         * loader/mac/LoaderFunctionsMac.mm:
2900         (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
2901
2902 2006-10-25  Darin Adler  <darin@apple.com>
2903
2904         Reviewed by Anders.
2905
2906         - removed 55 methods from WebCoreFrameBridge
2907         - changed callers to use Frame directly instead
2908         - put FrameLoaderTypes.h types into the WebCore namespace
2909         - first steps to get FrameLoader.h ready for cross-platform duty
2910
2911         * WebCore.exp:
2912         * WebCore.xcodeproj/project.pbxproj:
2913         * bridge/mac/BrowserExtensionMac.mm:
2914         (WebCore::BrowserExtensionMac::createNewWindow):
2915         * bridge/mac/FrameMac.h:
2916         * bridge/mac/FrameMac.mm:
2917         (WebCore::FrameMac::loadRequest):
2918         (WebCore::FrameMac::startRedirectionTimer):
2919         (WebCore::FrameMac::stopRedirectionTimer):
2920         (WebCore::FrameMac::passSubframeEventToSubframe):
2921         (WebCore::FrameMac::handledOnloadEvents):
2922         (WebCore::FrameMac::isLoadTypeReload):
2923         * bridge/mac/WebCoreFrameBridge.h:
2924         * bridge/mac/WebCoreFrameBridge.mm:
2925         (-[WebCoreFrameBridge executionContextForView:]):
2926         (updateRenderingForBindings):
2927         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
2928         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
2929         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
2930         (-[WebCoreFrameBridge installInFrame:]):
2931         (-[WebCoreFrameBridge numPendingOrLoadingRequests]):
2932         (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
2933         (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]):
2934         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2935         (stringByCollapsingNonPrintingCharacters):
2936         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
2937         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
2938         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2939         * loader/FrameLoaderTypes.h:
2940         * loader/mac/FrameLoader.h:
2941         * loader/mac/FrameLoader.mm:
2942         (WebCore::FrameLoader::FrameLoader):
2943         (WebCore::FrameLoader::setupForReplace):
2944         (WebCore::FrameLoader::load):
2945         (WebCore::FrameLoader::activeDocumentLoader):
2946         (WebCore::FrameLoader::state):
2947         (WebCore::FrameLoader::setState):
2948         (WebCore::FrameLoader::clearProvisionalLoad):
2949         (WebCore::FrameLoader::markLoadComplete):
2950         (WebCore::FrameLoader::commitProvisionalLoad):
2951         (WebCore::FrameLoader::receivedMainResourceError):
2952         (WebCore::FrameLoader::handleFallbackContent):
2953         (WebCore::FrameLoader::isLoadingMainFrame):
2954         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2955         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2956         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2957         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
2958         (WebCore::FrameLoader::transitionToCommitted):
2959         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2960         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
2961         (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
2962         (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
2963         (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
2964         * loader/mac/ImageDocumentMac.mm:
2965         (WebCore::finishImageLoad):
2966         * loader/mac/WebDocumentLoader.mm:
2967         (WebCore::DocumentLoader::isLoadingInAPISense):
2968         * loader/mac/WebMainResourceLoader.h:
2969         * loader/mac/WebMainResourceLoader.mm:
2970         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2971         (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
2972         * loader/mac/WebSubresourceLoader.mm:
2973         (-[WebCoreSubresourceHandle initWithLoader:]):
2974         * platform/mac/ListBoxMac.mm:
2975         (-[WebCoreTableView keyDown:]):
2976         (-[WebCoreTableView keyUp:]):
2977         * platform/mac/WebCoreTextField.mm:
2978         (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
2979
2980 2006-10-25  Steve Falkenburg  <sfalken@apple.com>
2981
2982         Reviewed by Darin.
2983
2984         Printing fixes
2985
2986         * page/Frame.cpp:
2987         (WebCore::Frame::adjustPageHeight):
2988         * page/Frame.h:
2989         (WebCore::Frame::setupRootForPrinting):
2990         (WebCore::Frame::computePageRects):
2991
2992 2006-10-25  Anders Carlsson  <acarlsson@apple.com>
2993
2994         Reviewed by Geoff.
2995
2996         <rdar://problem/4799088>
2997         REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.
2998
2999         * loader/mac/WebSubresourceLoader.h:
3000         * loader/mac/WebSubresourceLoader.mm:
3001         (-[WebCoreSubresourceHandle initWithLoader:]):
3002         Set the HTTP method before the HTTP body.
3003
3004 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
3005
3006         Reviewed by Adam.
3007
3008         Renamed WebFrameLoader to FrameLoader, to match class name.
3009
3010         * WebCore.xcodeproj/project.pbxproj:
3011         * bridge/mac/FrameMac.mm:
3012         * bridge/mac/WebCoreFrameBridge.mm:
3013         * loader/mac/FrameLoader.mm: Added.
3014         * loader/mac/IconLoaderMac.mm:
3015         * loader/mac/WebDocumentLoader.mm:
3016         * loader/mac/WebFrameLoader.h: Removed.
3017         * loader/mac/WebFrameLoader.mm: Removed.
3018         * loader/mac/WebLoader.mm:
3019         * loader/mac/WebMainResourceLoader.mm:
3020         * loader/mac/WebNetscapePlugInStreamLoader.mm:
3021         * loader/mac/WebSubresourceLoader.mm:
3022
3023 2006-10-25  Darin Adler  <darin@apple.com>
3024
3025         - fix full builds
3026
3027         * WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.
3028
3029 2006-10-25  David Smith  <catfish.man@gmail.com>
3030
3031         Reviewed by Mitz.
3032
3033         Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
3034         http://bugs.webkit.org/show_bug.cgi?id=11411
3035
3036         * bridge/mac/WebCoreFrameBridge.mm:
3037         (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.
3038
3039 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3040
3041         Rubber stamped by Mitz.
3042
3043         - moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac
3044
3045         * WebCore.xcodeproj/project.pbxproj:
3046         * bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
3047         * bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
3048         * bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.
3049
3050 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3051
3052         Rubber stamped by Mark.
3053
3054         - remove no longer existing symbol that was breaking linking
3055
3056         * WebCore.exp:
3057
3058 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3059
3060         Reviewed by Mitz.
3061         
3062         - fixed "REGRESSION: Activity window doesn't always list all files until refresh"
3063         http://bugs.webkit.org/show_bug.cgi?id=11212
3064
3065         I couldn't figure out how to write a test case.
3066
3067         * bindings/js/kjs_window.cpp:
3068         (KJS::Window::clear): Avoid crashing if already detached.
3069         * bridge/mac/FrameMac.h:
3070         * bridge/mac/FrameMac.mm:
3071         (WebCore::FrameMac::clear): Change prototype to make this a proper
3072         overload for Frame::clear once again(!).
3073
3074 2006-10-24  Darin Adler  <darin@apple.com>
3075
3076         Reviewed by Anders.
3077
3078         - converted WebFrameLoaderClient to C++
3079         - renamed frame->frameLoader() function to frame->loader()
3080         - renamed [bridge impl] to [bridge _frame]
3081         - removed some bridge methods
3082
3083         * WebCore.exp: Added more exports.
3084         * WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal
3085         so it can be used in WebKit.
3086
3087         * bridge/mac/BrowserExtensionMac.mm:
3088         (WebCore::BrowserExtensionMac::createNewWindow):
3089         * bridge/mac/FrameMac.mm:
3090         (WebCore::FrameMac::createFrame):
3091         (WebCore::FrameMac::didFirstLayout):
3092         * bridge/mac/WebCoreAXObject.mm:
3093         (-[WebCoreAXObject rendererForView:]):
3094         * bridge/mac/WebCoreFrameBridge.h:
3095         * bridge/mac/WebCoreFrameBridge.mm:
3096         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]):
3097         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3098         (-[WebCoreFrameBridge setOpener:]):
3099         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
3100         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
3101         (-[WebCoreFrameBridge setTitle:]):
3102         (-[WebCoreFrameBridge originalRequestURL]):
3103         (-[WebCoreFrameBridge isLoadTypeReload]):
3104         (-[WebCoreFrameBridge frameDetached]):
3105         (-[WebCoreFrameBridge tokenizerProcessedData]):
3106         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3107         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
3108         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3109         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
3110         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3111         (-[WebCoreFrameBridge incomingReferrer]):
3112         (-[WebCoreFrameBridge isReloading]):
3113         (-[WebCoreFrameBridge handledOnloadEvents]):
3114         (-[WebCoreFrameBridge mainResourceURLResponse]):
3115         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
3116         (-[WebCoreFrameBridge _frame]):
3117         (-[WebCoreFrameBridge executionContextForView:]):
3118         * bridge/mac/WebCorePageBridge.mm:
3119         (-[WebCorePageBridge setMainFrame:]):
3120         * dom/Position.cpp:
3121         (WebCore::Position::upstream):
3122         * loader/mac/IconLoaderMac.mm:
3123         (IconLoader::notifyIconChanged):
3124         * loader/mac/WebDocumentLoader.mm:
3125         (WebCore::DocumentLoader::frameLoader):
3126         (WebCore::DocumentLoader::stopLoading):
3127         (WebCore::DocumentLoader::finishedLoading):
3128         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
3129         * loader/mac/WebFormState.mm:
3130         (WebCore::FormState::FormState):
3131         * loader/mac/WebFrameLoader.h:
3132         * loader/mac/WebFrameLoader.mm:
3133         (WebCore::FrameLoader::~FrameLoader):
3134         (WebCore::FrameLoader::prepareForLoadStart):
3135         (WebCore::FrameLoader::finalSetupForReplace):
3136         (WebCore::FrameLoader::safeLoad):
3137         (WebCore::FrameLoader::load):
3138         (WebCore::FrameLoader::startLoading):
3139         (WebCore::FrameLoader::stopLoadingSubframes):
3140         (WebCore::FrameLoader::stopLoading):
3141         (WebCore::FrameLoader::cancelPendingArchiveLoad):
3142         (WebCore::FrameLoader::defersCallbacksChanged):
3143         (WebCore::FrameLoader::setDefersCallbacks):
3144         (WebCore::FrameLoader::setDocumentLoader):
3145         (WebCore::FrameLoader::provisionalLoadStarted):
3146         (WebCore::FrameLoader::clearProvisionalLoad):
3147         (WebCore::FrameLoader::identifierForInitialRequest):
3148         (WebCore::FrameLoader::willSendRequest):
3149         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
3150         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
3151         (WebCore::FrameLoader::didReceiveResponse):
3152         (WebCore::FrameLoader::didReceiveData):
3153         (WebCore::FrameLoader::didFinishLoad):
3154         (WebCore::FrameLoader::didFailToLoad):
3155         (WebCore::FrameLoader::privateBrowsingEnabled):
3156         (WebCore::FrameLoader::receivedMainResourceError):
3157         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
3158         (WebCore::FrameLoader::clientRedirected):
3159         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
3160         (WebCore::FrameLoader::closeOldDataSources):
3161         (WebCore::FrameLoader::opened):
3162         (WebCore::FrameLoader::commitProvisionalLoad):
3163         (WebCore::FrameLoader::download):
3164         (WebCore::FrameLoader::finishedLoading):
3165         (WebCore::FrameLoader::notifyIconChanged):
3166         (WebCore::FrameLoader::cancelledError):
3167         (WebCore::FrameLoader::fileDoesNotExistError):
3168         (WebCore::FrameLoader::willUseArchive):
3169         (WebCore::FrameLoader::isArchiveLoadPending):
3170         (WebCore::FrameLoader::handleUnimplementablePolicy):
3171         (WebCore::FrameLoader::cannotShowMIMEType):
3172         (WebCore::FrameLoader::interruptionForPolicyChangeError):
3173         (WebCore::FrameLoader::canShowMIMEType):
3174         (WebCore::FrameLoader::representationExistsForURLScheme):
3175         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
3176         (WebCore::FrameLoader::checkContentPolicy):
3177         (WebCore::FrameLoader::reloadAllowingStaleData):
3178         (WebCore::FrameLoader::reload):
3179         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
3180         (WebCore::FrameLoader::finishedLoadingDocument):
3181         (WebCore::FrameLoader::committedLoad):
3182         (WebCore::FrameLoader::revertToProvisional):
3183         (WebCore::FrameLoader::setMainDocumentError):
3184         (WebCore::FrameLoader::mainReceivedCompleteError):
3185         (WebCore::FrameLoader::subframeIsLoading):
3186         (WebCore::FrameLoader::willChangeTitle):
3187         (WebCore::FrameLoader::didChangeTitle):
3188         (WebCore::FrameLoader::checkNewWindowPolicy):
3189         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3190         (WebCore::FrameLoader::checkNavigationPolicy):
3191         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3192         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
3193         (WebCore::FrameLoader::didFirstLayout):
3194         (WebCore::FrameLoader::frameLoadCompleted):
3195         (WebCore::FrameLoader::transitionToCommitted):
3196         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3197         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3198         (WebCore::FrameLoader::sendRemainingDelegateMessages):
3199         (WebCore::FrameLoader::requestFromDelegate):
3200         (WebCore::FrameLoader::post):
3201         (WebCore::FrameLoader::detachChildren):
3202         (WebCore::FrameLoader::detachFromParent):
3203         (WebCore::FrameLoader::addExtraFieldsToRequest):
3204         (WebCore::FrameLoader::actionInformation):
3205         (WebCore::FrameLoader::checkLoadComplete):
3206         (WebCore::FrameLoader::setClient):
3207         (WebCore::FrameLoader::client):
3208         (WebCore::FrameLoaderClient::~FrameLoaderClient):
3209         * loader/mac/WebFrameLoaderClient.h:
3210         * loader/mac/WebLoader.mm:
3211         (WebCore::WebResourceLoader::frameLoader):
3212         * loader/mac/WebSubresourceLoader.mm:
3213         (-[WebCoreSubresourceHandle initWithLoader:]):
3214         * page/Frame.cpp:
3215         (WebCore::Frame::loader):
3216         * page/Frame.h:
3217         * platform/mac/SliderMac.mm:
3218         (Slider::focusPolicy):
3219
3220 2006-10-24  Darin Adler  <darin@apple.com>
3221
3222         Rubber stamped by Anders.
3223
3224         - get rid of the assertion firing while running the layout tests
3225
3226         This does not fix the real problem, which is that we need to map offsets within
3227         possibly-text-transformed text in the render tree to DOM tree offsets and vice
3228         versa -- but it gets the tests running again.
3229
3230         * dom/Position.cpp: (WebCore::Position::upstream): Commented out the assertion.
3231
3232 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
3233
3234         Reviewed by Oliver.
3235
3236         - more ResourceLoader cleanup
3237             - moved HTTPHeaderMap out of ResourceRequest class, so ResourceResponse will be able to use it too
3238             - took out attempts to suppress setting of "HEAD" and "GET" methods, since underlying bugs are now fixed
3239         
3240         * loader/LoaderFunctions.h:
3241         * loader/mac/LoaderFunctionsMac.mm:
3242         (WebCore::ServeSynchronousRequest):
3243         * loader/mac/WebSubresourceLoader.mm:
3244         (-[WebCoreSubresourceHandle initWithLoader:]):
3245         * platform/network/HTTPHeaderMap.h: Added.
3246         * platform/network/ResourceLoader.cpp:
3247         (WebCore::ResourceLoader::requestHeaders):
3248         * platform/network/ResourceLoader.h:
3249         * platform/network/ResourceRequest.h:
3250         * platform/network/cf/ResourceLoaderCFNet.cpp:
3251         (WebCore::addHeadersFromHashMap):
3252         * xml/xmlhttprequest.cpp:
3253         (WebCore::XMLHttpRequest::send):
3254         * xml/xmlhttprequest.h:
3255
3256 2006-10-24  Justin Garcia  <justin.garcia@apple.com>
3257
3258         Reviewed by darin
3259
3260         <http://bugs.webkit.org/show_bug.cgi?id=10993>
3261         GMail Editor: Caret doesn't always position itself after list marker
3262         
3263         List creation uses moveParagraphs to push content into list items.  
3264         moveParagraphs uses a TextIterator to restore selections after moves.
3265         Some characters emitted by the TextIterator had bad ranges associated
3266         with them.  rangeFromLocationAndLength would skip past the range it
3267         should have used when asked for ranges of length 0.
3268
3269         * editing/TextIterator.cpp:
3270         (WebCore::TextIterator::TextIterator): No longer need to initialize a
3271         removed member variable.
3272         (WebCore::TextIterator::advance): An extra newline is emitted when leaving
3273         some blocks.  Use the same range for this newline as for the first newline.
3274         We should remove this code and just emit two '\n's.
3275         (WebCore::TextIterator::handleTextNode): Setup m_range.
3276         (WebCore::TextIterator::handleTextBox): Ditto.
3277         (WebCore::TextIterator::handleReplacedElement): Ditto.
3278         (WebCore::TextIterator::handleNonTextNode): Ditto.
3279         (WebCore::TextIterator::exitNode): Use an m_range from the last VisiblePosition
3280         in the block we're leaving to that VP after that one.
3281         (WebCore::TextIterator::emitCharacter): This function now takes in the start
3282         and the end of the range associated with the emited character, and sets up m_range.
3283         (WebCore::TextIterator::range): Return m_range.  If it is null (we are atEnd), 
3284         return the end of the range used to create the iterator, as a convenience to
3285         callers that use call range() on an iterator that is atEnd.
3286         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
3287         Same as the changes made to TextIterator's constructor.
3288         (WebCore::SimplifiedBackwardsTextIterator::advance): Use a null m_range instead of
3289         a null m_positionNode to signal that we're finished.
3290         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
3291         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Similar to changes
3292         made to TextIterator.
3293         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto.
3294         (WebCore::SimplifiedBackwardsTextIterator::emitNewline): Simplified.
3295         (WebCore::SimplifiedBackwardsTextIterator::range): Similar to the changes made to
3296         TextIterator::range.
3297         (WebCore::CharacterIterator::range): This function assumed that an iterator's
3298         range() was safe to modify.
3299         (WebCore::TextIterator::rangeFromLocationAndLength):
3300         If the range we're looking for starts in the current chunk, this function assumed
3301         that if the chunk started in a text node, it would end in the same text node.  This
3302         is no longer the case.
3303         If the range we're looking for starts in the middle of the current chunk, I assume
3304         that the chunk is inside a text node, because those are the only chunks with length
3305         greater than one at the moment.
3306         If the range we're looking for is a zero length range that starts/ends at the end of the
3307         current chunk, we used to return the start of the next chunk, but that's wrong and
3308         is what caused this bug.
3309         * editing/TextIterator.h:
3310         (WebCore::TextIterator::atEnd): The iterator is atEnd when m_range is null.
3311         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
3312         * editing/visible_units.cpp:
3313         (WebCore::previousBoundary): Cleaned up by using a convenience function.
3314         (WebCore::nextBoundary): Ditto.
3315
3316 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3317
3318         Reviewed by Maciej.
3319
3320         * platform/network/mac/ResourceLoaderMac.mm:
3321         (WebCore::ResourceLoader::start):
3322         Don't retain the header dictionary.
3323
3324 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
3325
3326         Reviewed by Anders.
3327
3328         Fixed http://bugs.webkit.org/show_bug.cgi?id=11404
3329         REGRESSION: Reproducible assertion failure in Shared<WebCore::StringImpl>::ref() 
3330         running svg/custom/svg/custom/gradient-attr-update.svg
3331         
3332         SVGRenderStyle wasn't ref-ing the shared objects it held onto. Oops.
3333
3334         * ksvg2/css/SVGRenderStyle.h:
3335         * ksvg2/css/SVGRenderStyleDefs.h:
3336
3337 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3338
3339         Reviewed by Mitz.
3340
3341         * platform/network/ResourceRequest.h:
3342         (WebCore::ResourceRequest::ResourceRequest):
3343         Set the http method to "GET" in the constructor that takes a String.
3344
3345 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
3346
3347         Reviewed by Tim H.
3348
3349         Move kcanvas/Render* and kcanvas/SVG* to rendering/Render*
3350         and rendering/SVG* respectively.  Fix Xcode project and
3351         CMakeLists.txt to account for the moves.
3352
3353         * CMakeLists.txt:
3354         * WebCore.xcodeproj/project.pbxproj:
3355         * kcanvas/RenderForeignObject.cpp: Removed.
3356         * kcanvas/RenderForeignObject.h: Removed.
3357         * kcanvas/RenderPath.cpp: Removed.
3358         * kcanvas/RenderPath.h: Removed.
3359         * kcanvas/RenderSVGContainer.cpp: Removed.
3360         * kcanvas/RenderSVGContainer.h: Removed.
3361         * kcanvas/RenderSVGImage.cpp: Removed.
3362         * kcanvas/RenderSVGImage.h: Removed.
3363         * kcanvas/RenderSVGInline.cpp: Removed.
3364         * kcanvas/RenderSVGInline.h: Removed.
3365         * kcanvas/RenderSVGInlineText.cpp: Removed.
3366         * kcanvas/RenderSVGInlineText.h: Removed.
3367         * kcanvas/RenderSVGTSpan.cpp: Removed.
3368         * kcanvas/RenderSVGTSpan.h: Removed.
3369         * kcanvas/RenderSVGText.cpp: Removed.
3370         * kcanvas/RenderSVGText.h: Removed.
3371         * kcanvas/SVGInlineFlowBox.cpp: Removed.
3372         * kcanvas/SVGInlineFlowBox.h: Removed.
3373         * kcanvas/SVGRootInlineBox.cpp: Removed.
3374         * kcanvas/SVGRootInlineBox.h: Removed.
3375
3376 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
3377
3378         Rolling back in, now fixed:
3379         
3380         Nixed a few more redundant loading functions in Frame. Did my best to update
3381         the non-Mac builds.
3382
3383         * bridge/mac/FrameMac.h:
3384         * bridge/mac/FrameMac.mm:
3385         (WebCore::FrameMac::urlSelected): Kept always 'true' argument for userGesture
3386         always 'true', because changing it broke the world, and testing seems to
3387         indicate that the one caller that might have passed 'false' didn't need to.
3388         * page/Frame.cpp:
3389         (WebCore::Frame::requestFrame):
3390         (WebCore::Frame::frameLoader):
3391         (WebCore::Frame::redirectionTimerFired):
3392         * page/Frame.h:
3393         * platform/gdk/FrameGdk.cpp:
3394         * platform/gdk/FrameGdk.h:
3395         * platform/gdk/TemporaryLinkStubs.cpp:
3396         (FrameGdk::issueCopyCommand):
3397         * platform/qt/FrameQt.cpp:
3398         * platform/qt/FrameQt.h:
3399         * platform/win/TemporaryLinkStubs.cpp:
3400         (WebCore::FrameWin::shouldInterruptJavaScript):
3401         (WebCore::FrameWin::issueCopyCommand):
3402
3403 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3404
3405         Fix the build (Update for changes to ResourceLoader)
3406         
3407         * platform/network/cf/ResourceLoaderCFNet.cpp:
3408         (WebCore::addHeadersFromHashMap):
3409         (WebCore::ResourceLoader::start):
3410         (WebCore::ResourceLoader::cancel):
3411
3412 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
3413
3414         Reviewed by Mitz.
3415
3416         Change #includes using <kcanvas/*.h> to use "*.h" instead
3417         to prepare for moving the kcanvas files.
3418
3419         * kcanvas/RenderSVGContainer.h:
3420         * ksvg2/svg/SVGAElement.cpp:
3421         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3422         * ksvg2/svg/SVGFETileElement.cpp:
3423         * ksvg2/svg/SVGStyledLocatableElement.cpp:
3424         * ksvg2/svg/SVGStyledTransformableElement.cpp:
3425
3426 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
3427
3428         Reviewed by Darin.
3429
3430         - More movement towards the final network API.
3431         
3432         Changed ResourceLoader::create to take a ResurceRequest and start
3433         the load. Removed methods relating to setting request
3434         headers. Removed methods relating to metaData. Added some more
3435         convenience methods to ResourceRequest.
3436
3437         * dom/XMLTokenizer.cpp:
3438         (WebCore::openFunc):
3439         * loader/LoaderFunctions.h:
3440         * loader/icon/IconLoader.cpp:
3441         (IconLoader::startLoading):
3442         (IconLoader::didFinishLoading):
3443         * loader/icon/IconLoader.h:
3444         * loader/loader.cpp:
3445         (WebCore::Loader::servePendingRequests):
3446         * loader/mac/LoaderFunctionsMac.mm:
3447         (WebCore::ServeSynchronousRequest):
3448         * platform/gdk/FrameGdk.cpp:
3449         (WebCore::FrameGdkClientDefault::openURL):
3450         (WebCore::FrameGdkClientDefault::submitForm):
3451         * platform/network/ResourceLoader.cpp:
3452         (WebCore::ResourceLoader::ResourceLoader):
3453         (WebCore::ResourceLoader::create):
3454         (WebCore::ResourceLoader::responseHTTPHeadersAsString):
3455         (WebCore::ResourceLoader::url):
3456         (WebCore::ResourceLoader::postData):
3457         (WebCore::ResourceLoader::method):
3458         (WebCore::ResourceLoader::client):
3459         * platform/network/ResourceLoader.h:
3460         * platform/network/ResourceLoaderInternal.h:
3461         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3462         * platform/network/ResourceRequest.h:
3463         (WebCore::ResourceRequest::ResourceRequest):
3464         (WebCore::ResourceRequest::httpAccept):
3465         (WebCore::ResourceRequest::setHTTPAccept):
3466         (WebCore::ResourceRequest::addHTTPHeaderFields):
3467         * platform/network/mac/ResourceLoaderMac.mm:
3468         (WebCore::ResourceLoader::start):
3469         (WebCore::ResourceLoader::receivedResponse):
3470         * platform/qt/FrameQtClient.cpp:
3471         (WebCore::FrameQtClientDefault::openURL):
3472         (WebCore::FrameQtClientDefault::submitForm):
3473         * platform/win/TemporaryLinkStubs.cpp:
3474         (WebCore::ResourceLoader::retrieveResponseEncoding):
3475         * xml/XSLTProcessor.cpp:
3476         (WebCore::docLoaderFunc):
3477         * xml/xmlhttprequest.cpp:
3478         (WebCore::XMLHttpRequest::send):
3479         (WebCore::XMLHttpRequest::didFinishLoading):
3480         (WebCore::XMLHttpRequest::didReceiveData):
3481         * xml/xmlhttprequest.h:
3482
3483 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3484
3485         Reviewed by Geoff.
3486
3487         * loader/FormData.cpp:
3488         (WebCore::FormData::FormData):
3489         * loader/FormData.h:
3490         (WebCore::FormData::FormData):
3491         Add new constructor that takes a void* and a size.
3492
3493 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
3494
3495         Rolling out my last change because it broke the world.
3496
3497         * bridge/mac/FrameMac.h:
3498         * bridge/mac/FrameMac.mm:
3499         (WebCore::FrameMac::openURL):
3500         (WebCore::FrameMac::openURLRequest):
3501         (WebCore::FrameMac::urlSelected):
3502         * page/Frame.cpp:
3503         (WebCore::Frame::openURL):
3504         (WebCore::Frame::frameLoader):
3505         (WebCore::Frame::requestFrame):
3506         (WebCore::Frame::redirectionTimerFired):
3507         * page/Frame.h:
3508         * platform/gdk/FrameGdk.cpp:
3509         (WebCore::FrameGdk::openURL):
3510         * platform/gdk/FrameGdk.h:
3511         * platform/gdk/TemporaryLinkStubs.cpp:
3512         * platform/qt/FrameQt.cpp:
3513         (WebCore::FrameQt::openURL):
3514         (WebCore::FrameQt::openURLRequest):
3515         * platform/qt/FrameQt.h:
3516         * platform/win/TemporaryLinkStubs.cpp:
3517         (WebCore::FrameWin::openURL):
3518         (WebCore::FrameWin::openURLRequest):
3519
3520 2006-10-24  Nikolas Zimmermann  <zimmermann@kde.org>
3521
3522         Reviewed by Adam.
3523
3524         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11396
3525
3526         Kill KRenderingFillPainter/KRenderingStrokePainter. Those are not needed
3527         anymore, since kcanvas/ksvg2 are tightly integrated. No LayoutTests fixed
3528         or broken.
3529
3530         * CMakeLists.txt:
3531         * WebCore.xcodeproj/project.pbxproj:
3532         * kcanvas/KCanvasTreeDebug.cpp:
3533         (WebCore::operator<<):
3534         (WebCore::writeStyle):
3535         * kcanvas/RenderPath.cpp:
3536         (WebCore::RenderPath::fillContains):
3537         * kcanvas/device/KRenderingFillPainter.cpp:
3538         * kcanvas/device/KRenderingFillPainter.h:
3539         * kcanvas/device/KRenderingStrokePainter.cpp:
3540         * kcanvas/device/KRenderingStrokePainter.h:
3541         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
3542         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
3543         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
3544         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
3545         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
3546         (WebCore::KRenderingPaintServerQt::setPenProperties):
3547         * kcanvas/device/qt/KRenderingPaintServerQt.h:
3548         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
3549         (WebCore::KRenderingPaintServerSolidQt::setup):
3550         * kcanvas/device/qt/RenderPathQt.cpp:
3551         (WebCore::getPathStroke):
3552         (WebCore::RenderPath::strokeBBox):
3553         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
3554         (WebCore::RenderPath::strokeBBox):
3555         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
3556         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3557         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3558         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
3559         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
3560         * kcanvas/device/quartz/QuartzSupport.h:
3561         (WebCore::CGLineCapFromKC):
3562         (WebCore::CGLineJoinFromKC):
3563         * kcanvas/device/quartz/QuartzSupport.mm:
3564         (WebCore::applyStrokeStyleToContext):
3565         (WebCore::strokeBoundingBox):
3566         * ksvg2/css/SVGCSSStyleSelector.cpp:
3567         (WebCore::CSSStyleSelector::applySVGProperty):
3568         * ksvg2/css/SVGRenderStyle.h:
3569         (WebCore::SVGRenderStyle::InheritedFlags::):
3570         * ksvg2/css/SVGRenderStyleDefs.h:
3571         * ksvg2/misc/KCanvasRenderingStyle.cpp:
3572         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
3573         * ksvg2/misc/KCanvasRenderingStyle.h:
3574         * ksvg2/svg/SVGFEImageElement.cpp:
3575
3576 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
3577
3578         Reviewed by Anders.
3579
3580         Nixed a few more redundant loading functions in Frame. Did my best to update
3581         the non-Mac builds.
3582
3583         * bridge/mac/FrameMac.h:
3584         * bridge/mac/FrameMac.mm:
3585         (WebCore::FrameMac::urlSelected): Changed always 'true' argument for userGesture
3586         to actually check for a user gesture. New callers rely on this behavior,
3587         and it seems like the previous behavior must have been a bug.
3588         * page/Frame.cpp:
3589         (WebCore::Frame::requestFrame):
3590         (WebCore::Frame::frameLoader):
3591         (WebCore::Frame::redirectionTimerFired):
3592         * page/Frame.h:
3593         * platform/gdk/FrameGdk.cpp:
3594         * platform/gdk/FrameGdk.h:
3595         * platform/gdk/TemporaryLinkStubs.cpp:
3596         (FrameGdk::issueCopyCommand):
3597         * platform/qt/FrameQt.cpp:
3598         * platform/qt/FrameQt.h:
3599         * platform/win/TemporaryLinkStubs.cpp:
3600         (WebCore::FrameWin::shouldInterruptJavaScript):
3601         (WebCore::FrameWin::issueCopyCommand):
3602
3603 2006-10-24  Nikolas Zimmermann  <zimmermann@kde.org>
3604
3605         Reviewed by Maciej.
3606
3607         Fix Qt/Linux build.
3608
3609         - Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
3610         - Fix CMakeLists.txt to include platform/network.
3611
3612         * CMakeLists.txt:
3613         * platform/qt/BrowserExtensionQt.cpp: Removed.
3614         * platform/qt/BrowserExtensionQt.h: Removed.
3615         * platform/qt/FrameQt.cpp:
3616         (WebCore::FrameQt::FrameQt):
3617         (WebCore::FrameQt::createNewWindow):
3618         (WebCore::FrameQt::goBackOrForward):
3619         (WebCore::FrameQt::historyURL):
3620         (WebCore::FrameQt::getHistoryLength):
3621         * platform/qt/FrameQt.h:
3622         * platform/qt/PageQt.cpp:
3623         (WebCore::Page::canRunModal):
3624         (WebCore::Page::canRunModalNow):
3625         (WebCore::Page::runModal):
3626
3627 2006-10-24  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3628
3629         Reviewed by Tim H.
3630
3631         Fix for http://bugs.webkit.org/show_bug.cgi?id=11314
3632         Fix build when XSLT_SUPPORT is not defined
3633
3634         Fix unconditional use of XSLT support.
3635
3636         * dom/XMLTokenizer.cpp:
3637         (WebCore::XMLTokenizer::end):
3638
3639 2006-10-24  Simon Hausmann  <hausmann@kde.org>
3640
3641         Reviewed by Darin.
3642
3643         * CMakeLists.txt: Added project name to kde4_automoc macro, as
3644           required by the latest KDE4 cmake module.
3645
3646 2006-10-24  Mitz Pettel  <mitz@webkit.org>
3647
3648         Reviewed by Tim H.
3649
3650         - fix http://bugs.webkit.org/show_bug.cgi?id=11394
3651           HTMLViewSourceDocuments are leaking
3652
3653         * html/HTMLViewSourceDocument.h: Changed RefPtr to plain pointer to avoid
3654         ref cycle.
3655
3656 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
3657
3658         Reviewed by Darin.
3659
3660         Removed one of Frame's redundant urlSelected methods.
3661
3662         * bridge/mac/FrameMac.h:
3663         * bridge/mac/FrameMac.mm:
3664         (WebCore::FrameMac::urlSelected):
3665         since it's unused.
3666         * html/HTMLAnchorElement.cpp:
3667         (WebCore::HTMLAnchorElement::defaultEventHandler): Changed DeprecatedString
3668         to String because the former is deprecated and its performance is irrelevant
3669         here. Added call to completeURL because Frame no longer does it for us.
3670         Having the call here also improves clarity about the element's behavior.
3671         * ksvg2/svg/SVGAElement.cpp:
3672         (WebCore::SVGAElement::defaultEventHandler): ditto. Also removed bizarre
3673         irrelevent NULL checks on ownerDocument() because I couldn't help myself.
3674         * page/Frame.cpp:
3675         (WebCore::Frame::changeLocation):
3676         (WebCore::Frame::urlSelected):
3677         * page/Frame.h:
3678         * platform/network/ResourceRequest.h: Removed explicit keyword on constructor
3679         because we want to be able to use these constructors instead of helper functions
3680         mimicking their behavior sprinkled across different classes.
3681         (WebCore::ResourceRequest::ResourceRequest):
3682
3683 2006-10-24  Brady Eidson  <beidson@apple.com>
3684
3685         Reviewed by Maciej
3686
3687         Moved FrameLoader from WebCoreFrameBridge to Frame.  Frame.h/cpp have generic accessors to the FrameLoader itself
3688         and creation/deletion is currently managed in FrameMac.mm
3689
3690         Besides explicitly commented-upon methods, most of the touched code simply changes to get the FrameLoader from the 
3691         frame instead of the bridge.
3692
3693         The method [WebCoreFrameBridge frameLoader] remains but only for WebKit's use - No new WebCore code should make 
3694         use of it as its days are numbered!
3695
3696         * bridge/mac/FrameMac.mm:
3697         (WebCore::FrameMac::FrameMac): Create the FrameLoader
3698         (WebCore::FrameMac::~FrameMac): Nuke it
3699         (WebCore::FrameMac::loadRequest):
3700
3701         * bridge/mac/WebCoreFrameBridge.h: No longer holds an m_frameLoader
3702         * bridge/mac/WebCoreFrameBridge.mm:
3703         (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): No longer creates the FrameLoader
3704         (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Ditto
3705         (-[WebCoreFrameBridge clearFrame]): No longer tears down the FrameLoader
3706         (-[WebCoreFrameBridge setFrameLoaderClient:]):
3707         (-[WebCoreFrameBridge frameLoader]):
3708         (-[WebCoreFrameBridge setTitle:]):
3709         (-[WebCoreFrameBridge didFirstLayout]):
3710         (-[WebCoreFrameBridge notifyIconChanged:]):
3711         (-[WebCoreFrameBridge originalRequestURL]):
3712         (-[WebCoreFrameBridge isLoadTypeReload]):
3713         (-[WebCoreFrameBridge frameDetached]):
3714         (-[WebCoreFrameBridge tokenizerProcessedData]):
3715         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3716         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
3717         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3718         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
3719         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3720         (-[WebCoreFrameBridge incomingReferrer]):
3721         (-[WebCoreFrameBridge isReloading]):
3722         (-[WebCoreFrameBridge handledOnloadEvents]):
3723         (-[WebCoreFrameBridge mainResourceURLResponse]):
3724         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
3725
3726         * loader/mac/WebDocumentLoader.mm:
3727         (WebCore::DocumentLoader::frameLoader):
3728
3729         * loader/mac/WebFrameLoader.mm:
3730         (WebCore::FrameLoader::load):
3731         (WebCore::FrameLoader::stopLoadingSubframes):
3732         (WebCore::FrameLoader::defersCallbacksChanged):
3733         (WebCore::FrameLoader::setState):
3734         (WebCore::FrameLoader::closeOldDataSources):
3735         (WebCore::FrameLoader::subframeIsLoading):
3736         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3737         (WebCore::FrameLoader::post):
3738         (WebCore::FrameLoader::detachChildren):
3739         (WebCore::FrameLoader::checkLoadComplete):
3740
3741         * loader/mac/WebLoader.mm:
3742         (WebCore::WebResourceLoader::frameLoader):
3743
3744         * loader/mac/WebSubresourceLoader.mm:
3745         (-[WebCoreSubresourceHandle initWithLoader:]):
3746
3747         * page/Frame.cpp:
3748         (WebCore::Frame::frameLoader):
3749         * page/Frame.h:
3750         * page/FramePrivate.h:
3751         (WebCore::FramePrivate::FramePrivate):
3752
3753 2006-10-24  Darin Adler  <darin@apple.com>
3754
3755         Reviewed by Maciej.
3756
3757         - fixed two crashes in layout tests I just introduced
3758
3759         * loader/mac/WebFrameLoader.mm:
3760         (WebCore::FrameLoader::load): Add null check.
3761         (WebCore::FrameLoader::setState): Ditto.
3762
3763 2006-10-23  Darin Adler  <darin@apple.com>
3764
3765         Reviewed by Geoff.
3766
3767         - converted WebDocumentLoader to C++
3768
3769         * WebCore.exp:
3770         * bridge/mac/WebCoreFrameBridge.mm:
3771         (-[WebCoreFrameBridge setTitle:]):
3772         (-[WebCoreFrameBridge originalRequestURL]):
3773         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3774         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3775         (-[WebCoreFrameBridge incomingReferrer]):
3776         (-[WebCoreFrameBridge isReloading]):
3777         (-[WebCoreFrameBridge mainResourceURLResponse]):
3778         * loader/mac/WebDocumentLoader.h:
3779         * loader/mac/WebDocumentLoader.mm:
3780         (WebCore::DocumentLoader::DocumentLoader):
3781         (WebCore::DocumentLoader::frameLoader):
3782         (WebCore::DocumentLoader::~DocumentLoader):
3783         (WebCore::DocumentLoader::setMainResourceData):
3784         (WebCore::DocumentLoader::mainResourceData):
3785         (WebCore::DocumentLoader::originalRequest):
3786         (WebCore::DocumentLoader::originalRequestCopy):
3787         (WebCore::DocumentLoader::request):
3788         (WebCore::DocumentLoader::initialRequest):
3789         (WebCore::DocumentLoader::actualRequest):
3790         (WebCore::DocumentLoader::URL):
3791         (WebCore::DocumentLoader::unreachableURL):
3792         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
3793         (WebCore::DocumentLoader::setRequest):
3794         (WebCore::DocumentLoader::setResponse):
3795         (WebCore::DocumentLoader::isStopping):
3796         (WebCore::DocumentLoader::bridge):
3797         (WebCore::DocumentLoader::setMainDocumentError):
3798         (WebCore::DocumentLoader::mainDocumentError):
3799         (WebCore::DocumentLoader::clearErrors):
3800         (WebCore::DocumentLoader::mainReceivedError):
3801         (WebCore::DocumentLoader::stopLoading):
3802         (WebCore::DocumentLoader::setupForReplace):
3803         (WebCore::DocumentLoader::commitIfReady):
3804         (WebCore::DocumentLoader::finishedLoading):
3805         (WebCore::DocumentLoader::setCommitted):
3806         (WebCore::DocumentLoader::isCommitted):
3807         (WebCore::DocumentLoader::setLoading):
3808         (WebCore::DocumentLoader::isLoading):
3809         (WebCore::DocumentLoader::commitLoad):
3810         (WebCore::DocumentLoader::doesProgressiveLoad):
3811         (WebCore::DocumentLoader::receivedData):
3812         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
3813         (WebCore::DocumentLoader::updateLoading):
3814         (WebCore::DocumentLoader::response):
3815         (WebCore::DocumentLoader::setFrame):
3816         (WebCore::DocumentLoader::attachToFrame):
3817         (WebCore::DocumentLoader::detachFromFrame):
3818         (WebCore::DocumentLoader::prepareForLoadStart):
3819         (WebCore::DocumentLoader::loadingStartedTime):
3820         (WebCore::DocumentLoader::setIsClientRedirect):
3821         (WebCore::DocumentLoader::isClientRedirect):
3822         (WebCore::DocumentLoader::setPrimaryLoadComplete):
3823         (WebCore::DocumentLoader::isLoadingInAPISense):
3824         (WebCore::DocumentLoader::addResponse):
3825         (WebCore::DocumentLoader::stopRecordingResponses):
3826         (WebCore::DocumentLoader::title):
3827         (WebCore::DocumentLoader::setLastCheckedRequest):
3828         (WebCore::DocumentLoader::lastCheckedRequest):
3829         (WebCore::DocumentLoader::triggeringAction):
3830         (WebCore::DocumentLoader::setTriggeringAction):
3831         (WebCore::DocumentLoader::responses):
3832         (WebCore::DocumentLoader::setOverrideEncoding):
3833         (WebCore::DocumentLoader::overrideEncoding):
3834         (WebCore::DocumentLoader::setTitle):
3835         (WebCore::DocumentLoader::URLForHistory):
3836         * loader/mac/WebFrameLoader.h:
3837         * loader/mac/WebFrameLoader.mm:
3838         (WebCore::FrameLoader::setupForReplaceByMIMEType):
3839         (WebCore::FrameLoader::finalSetupForReplace):
3840         (WebCore::FrameLoader::safeLoad):
3841         (WebCore::FrameLoader::load):
3842         (WebCore::FrameLoader::startLoading):
3843         (WebCore::FrameLoader::stopLoading):
3844         (WebCore::FrameLoader::activeDocumentLoader):
3845         (WebCore::FrameLoader::addPlugInStreamLoader):
3846         (WebCore::FrameLoader::removePlugInStreamLoader):
3847         (WebCore::FrameLoader::addSubresourceLoader):
3848         (WebCore::FrameLoader::removeSubresourceLoader):
3849         (WebCore::FrameLoader::setDocumentLoader):
3850         (WebCore::FrameLoader::documentLoader):
3851         (WebCore::FrameLoader::setPolicyDocumentLoader):
3852         (WebCore::FrameLoader::provisionalDocumentLoader):
3853         (WebCore::FrameLoader::setProvisionalDocumentLoader):
3854         (WebCore::FrameLoader::setState):
3855         (WebCore::FrameLoader::clearProvisionalLoad):
3856         (WebCore::FrameLoader::commitProvisionalLoad):
3857         (WebCore::FrameLoader::didReceiveResponse):
3858         (WebCore::FrameLoader::originalRequest):
3859         (WebCore::FrameLoader::receivedMainResourceError):
3860         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
3861         (WebCore::FrameLoader::opened):
3862         (WebCore::FrameLoader::initialRequest):
3863         (WebCore::FrameLoader::receivedData):
3864         (WebCore::FrameLoader::setRequest):
3865         (WebCore::FrameLoader::isStopping):
3866         (WebCore::FrameLoader::setResponse):
3867         (WebCore::FrameLoader::mainReceivedError):
3868         (WebCore::FrameLoader::finishedLoading):
3869         (WebCore::FrameLoader::notifyIconChanged):
3870         (WebCore::FrameLoader::URL):
3871         (WebCore::FrameLoader::checkContentPolicy):
3872         (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
3873         (WebCore::FrameLoader::reloadAllowingStaleData):
3874         (WebCore::FrameLoader::reload):
3875         (WebCore::FrameLoader::finishedLoadingDocument):
3876         (WebCore::FrameLoader::committedLoad):
3877         (WebCore::FrameLoader::revertToProvisional):
3878         (WebCore::FrameLoader::setMainDocumentError):
3879         (WebCore::FrameLoader::mainReceivedCompleteError):
3880         (WebCore::FrameLoader::subframeIsLoading):
3881         (WebCore::FrameLoader::willChangeTitle):
3882         (WebCore::FrameLoader::didChangeTitle):
3883         (WebCore::FrameLoader::checkNavigationPolicy):
3884         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
3885         (WebCore::FrameLoader::transitionToCommitted):
3886         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3887         (WebCore::FrameLoader::detachFromParent):
3888         * loader/mac/WebFrameLoaderClient.h:
3889
3890 2006-10-23  Brady Eidson  <beidson@apple.com>
3891
3892         Lovingly reviewed by Maciej
3893
3894         Moved loadURL and postURL logic out of WebCoreFrameBridge to FrameMac::loadRequest
3895         This is a big step towards moving FrameLoader out of the Bridge into Frame/Mac itself
3896
3897         * bridge/mac/BrowserExtensionMac.mm:
3898         (WebCore::BrowserExtensionMac::createNewWindow): Use FrameMac::loadRequest
3899
3900         * bridge/mac/FrameMac.mm:
3901         (WebCore::FrameMac::loadRequest): loadURL and postURL logic moved from WebCoreFrameBridge to here
3902
3903         * bridge/mac/WebCoreFrameBridge.h: Nuked loadURL and postURL
3904         * bridge/mac/WebCoreFrameBridge.mm: Ditto
3905         * loader/mac/WebFrameLoader.mm:
3906         (-[WebFrameLoader safeLoadURL:]): Use FrameMac::loadRequest
3907
3908 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
3909
3910         RS by Maciej.
3911
3912         Inside Frame, moved the plethora of load() and stopLoading() functions next 
3913         to each other to facilitate merging and crying.
3914
3915         * bridge/mac/FrameMac.h:
3916         * bridge/mac/FrameMac.mm:
3917         (WebCore::FrameMac::loadRequest):
3918         (WebCore::FrameMac::submitForm):
3919         (WebCore::FrameMac::openURL):
3920         (WebCore::FrameMac::openURLRequest):
3921         (WebCore::FrameMac::urlSelected):
3922         (WebCore::FrameMac::openURLFromPageCache):
3923         (WebCore::FrameMac::createFrame):
3924         * page/Frame.cpp:
3925         (WebCore::Frame::openURL):
3926         (WebCore::Frame::changeLocation):
3927         (WebCore::Frame::urlSelected):
3928         (WebCore::Frame::requestFrame):
3929         (WebCore::Frame::loadSubframe):
3930         (WebCore::Frame::submitFormAgain):
3931         (WebCore::Frame::submitForm):
3932         (WebCore::Frame::stop):
3933         (WebCore::Frame::closeURL):
3934         (WebCore::Frame::cancelRedirection):
3935         (WebCore::Frame::iconURL):
3936         (WebCore::Frame::didOpenURL):
3937         (WebCore::Frame::didExplicitOpen):
3938         * page/Frame.h:
3939
3940 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
3941
3942         RS by Maciej.
3943
3944         Moved our plethora of load() and stopLoading() functions next to each other
3945         to facilitate merging and laughter.
3946
3947         * loader/mac/WebFrameLoader.h:
3948         * loader/mac/WebFrameLoader.mm:
3949         (WebCore::cancelAll):
3950         (WebCore::FrameLoader::prepareForLoadStart):
3951         (WebCore::FrameLoader::setupForReplace):
3952         (WebCore::FrameLoader::setupForReplaceByMIMEType):
3953         (WebCore::FrameLoader::finalSetupForReplace):
3954         (WebCore::FrameLoader::safeLoad):
3955         (WebCore::FrameLoader::load):
3956         (WebCore::FrameLoader::startLoadingMainResource):
3957         (WebCore::FrameLoader::startLoading):
3958         (WebCore::FrameLoader::stopLoadingPlugIns):
3959         (WebCore::FrameLoader::stopLoadingSubresources):
3960         (WebCore::FrameLoader::stopLoading):
3961         (WebCore::FrameLoader::stopLoadingSubframes):
3962         (WebCore::FrameLoader::cancelMainResourceLoad):
3963         (WebCore::FrameLoader::cancelPendingArchiveLoad):
3964         (WebCore::FrameLoader::removeSubresourceLoader):
3965         (WebCore::FrameLoader::mainResourceData):
3966         (WebCore::FrameLoader::releaseMainResourceLoader):
3967
3968 2006-10-23  Darin Adler  <darin@apple.com>
3969
3970         Reviewed by Maciej.
3971
3972         - converted WebFrameLoader to C++
3973
3974         * WebCore.exp: Added many new entry points for WebKit.
3975         * WebCore.xcodeproj/project.pbxproj: Made more files private (SPI).
3976
3977         * bridge/mac/WebCoreFrameBridge.h:
3978         * bridge/mac/WebCoreFrameBridge.mm:
3979         (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]):
3980         (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]):
3981         (-[WebCoreFrameBridge dealloc]):
3982         (-[WebCoreFrameBridge close]):
3983         (-[WebCoreFrameBridge clearFrame]):
3984         (-[WebCoreFrameBridge setFrameLoaderClient:]):
3985         (-[WebCoreFrameBridge frameLoader]):
3986         (-[WebCoreFrameBridge setTitle:]):
3987         (-[WebCoreFrameBridge didFirstLayout]):
3988         (-[WebCoreFrameBridge notifyIconChanged:]):
3989         (-[WebCoreFrameBridge originalRequestURL]):
3990         (-[WebCoreFrameBridge isLoadTypeReload]):
3991         (-[WebCoreFrameBridge frameDetached]):
3992         (-[WebCoreFrameBridge tokenizerProcessedData]):
3993         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3994         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
3995         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
3996         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
3997         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3998         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
3999         (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
4000         (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
4001         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
4002         (-[WebCoreFrameBridge incomingReferrer]):
4003         (-[WebCoreFrameBridge isReloading]):
4004         (-[WebCoreFrameBridge handledOnloadEvents]):
4005         (-[WebCoreFrameBridge mainResourceURLResponse]):
4006         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
4007         * loader/mac/WebDocumentLoader.h:
4008         * loader/mac/WebDocumentLoader.mm:
4009         (-[WebDocumentLoader frameLoader]):
4010         (-[WebDocumentLoader dealloc]):
4011         (-[WebDocumentLoader mainResourceData]):
4012         (-[WebDocumentLoader setRequest:]):
4013         (-[WebDocumentLoader bridge]):
4014         (-[WebDocumentLoader setMainDocumentError:]):
4015         (-[WebDocumentLoader mainReceivedError:complete:]):
4016         (-[WebDocumentLoader stopLoading]):
4017         (-[WebDocumentLoader setupForReplace]):
4018         (-[WebDocumentLoader commitIfReady]):
4019         (-[WebDocumentLoader finishedLoading]):
4020         (-[WebDocumentLoader commitLoadWithData:]):
4021         (-[WebDocumentLoader doesProgressiveLoadWithMIMEType:]):
4022         (-[WebDocumentLoader setupForReplaceByMIMEType:]):
4023         (-[WebDocumentLoader updateLoading]):
4024         (-[WebDocumentLoader setFrame:]):
4025         (-[WebDocumentLoader attachToFrame]):
4026         (-[WebDocumentLoader detachFromFrame]):
4027         (-[WebDocumentLoader prepareForLoadStart]):
4028         (-[WebDocumentLoader setPrimaryLoadComplete:]):
4029         (-[WebDocumentLoader isLoadingInAPISense]):
4030         (-[WebDocumentLoader setTitle:]):
4031         * loader/mac/WebFrameLoader.h:
4032         (WebCore::FrameLoader::frame):
4033         * loader/mac/WebFrameLoader.mm:
4034         (WebCore::FrameLoader::FrameLoader):
4035         (WebCore::FrameLoader::~FrameLoader):
4036         (WebCore::FrameLoader::activeDocumentLoader):
4037         (WebCore::FrameLoader::addPlugInStreamLoader):
4038         (WebCore::FrameLoader::removePlugInStreamLoader):
4039         (WebCore::FrameLoader::defersCallbacksChanged):
4040         (WebCore::FrameLoader::defersCallbacks):
4041         (WebCore::setAllDefersCallbacks):
4042         (WebCore::FrameLoader::setDefersCallbacks):
4043         (WebCore::cancelAll):
4044         (WebCore::FrameLoader::stopLoadingPlugIns):
4045         (WebCore::FrameLoader::isLoadingMainResource):
4046         (WebCore::FrameLoader::isLoadingSubresources):
4047         (WebCore::FrameLoader::isLoadingPlugIns):
4048         (WebCore::FrameLoader::isLoading):
4049         (WebCore::FrameLoader::stopLoadingSubresources):
4050         (WebCore::FrameLoader::addSubresourceLoader):
4051         (WebCore::FrameLoader::removeSubresourceLoader):
4052         (WebCore::FrameLoader::mainResourceData):
4053         (WebCore::FrameLoader::releaseMainResourceLoader):
4054         (WebCore::FrameLoader::cancelMainResourceLoad):
4055         (WebCore::FrameLoader::startLoadingMainResource):
4056         (WebCore::FrameLoader::stopLoading):
4057         (WebCore::FrameLoader::setDocumentLoader):
4058         (WebCore::FrameLoader::documentLoader):
4059         (WebCore::FrameLoader::setPolicyDocumentLoader):
4060         (WebCore::FrameLoader::provisionalDocumentLoader):
4061         (WebCore::FrameLoader::setProvisionalDocumentLoader):
4062         (WebCore::FrameLoader::state):
4063         (WebCore::FrameLoader::timeOfLastCompletedLoad):
4064         (WebCore::FrameLoader::provisionalLoadStarted):
4065         (WebCore::FrameLoader::setState):
4066         (WebCore::FrameLoader::clearProvisionalLoad):
4067         (WebCore::FrameLoader::markLoadComplete):
4068         (WebCore::FrameLoader::commitProvisionalLoad):
4069         (WebCore::FrameLoader::stopLoadingSubframes):
4070         (WebCore::FrameLoader::startLoading):
4071         (WebCore::FrameLoader::setupForReplace):
4072         (WebCore::FrameLoader::identifierForInitialRequest):
4073         (WebCore::FrameLoader::willSendRequest):
4074         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
4075         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
4076         (WebCore::FrameLoader::didReceiveResponse):
4077         (WebCore::FrameLoader::didReceiveData):
4078         (WebCore::FrameLoader::didFinishLoad):
4079         (WebCore::FrameLoader::didFailToLoad):
4080         (WebCore::FrameLoader::privateBrowsingEnabled):
4081         (WebCore::FrameLoader::originalRequest):
4082         (WebCore::FrameLoader::receivedMainResourceError):
4083         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
4084         (WebCore::FrameLoader::clientRedirected):
4085         (WebCore::FrameLoader::shouldReload):
4086         (WebCore::FrameLoader::load):
4087         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
4088         (WebCore::FrameLoader::closeOldDataSources):
4089         (WebCore::FrameLoader::opened):
4090         (WebCore::FrameLoader::initialRequest):
4091         (WebCore::FrameLoader::receivedData):
4092         (WebCore::FrameLoader::setRequest):
4093         (WebCore::FrameLoader::download):
4094         (WebCore::FrameLoader::bridge):
4095         (WebCore::FrameLoader::handleFallbackContent):
4096         (WebCore::FrameLoader::isStopping):
4097         (WebCore::FrameLoader::setupForReplaceByMIMEType):
4098         (WebCore::FrameLoader::setResponse):
4099         (WebCore::FrameLoader::mainReceivedError):
4100         (WebCore::FrameLoader::finishedLoading):
4101         (WebCore::FrameLoader::notifyIconChanged):
4102         (WebCore::FrameLoader::URL):
4103         (WebCore::FrameLoader::cancelledError):
4104         (WebCore::FrameLoader::fileDoesNotExistError):
4105         (WebCore::FrameLoader::willUseArchive):
4106         (WebCore::FrameLoader::isArchiveLoadPending):
4107         (WebCore::FrameLoader::cancelPendingArchiveLoad):
4108         (WebCore::FrameLoader::handleUnimplementablePolicy):
4109         (WebCore::FrameLoader::cannotShowMIMEType):
4110         (WebCore::FrameLoader::interruptionForPolicyChangeError):
4111         (WebCore::FrameLoader::isHostedByObjectElement):
4112         (WebCore::FrameLoader::isLoadingMainFrame):
4113         (WebCore::FrameLoader::canShowMIMEType):
4114         (WebCore::FrameLoader::representationExistsForURLScheme):
4115         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
4116         (WebCore::FrameLoader::checkNavigationPolicy):
4117         (WebCore::FrameLoader::checkContentPolicy):
4118         (WebCore::FrameLoader::cancelContentPolicyCheck):
4119         (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
4120         (WebCore::FrameLoader::reloadAllowingStaleData):
4121         (WebCore::FrameLoader::reload):
4122         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
4123         (WebCore::FrameLoader::finishedLoadingDocument):
4124         (WebCore::FrameLoader::committedLoad):
4125         (WebCore::FrameLoader::isReplacing):
4126         (WebCore::FrameLoader::setReplacing):
4127         (WebCore::FrameLoader::revertToProvisional):
4128         (WebCore::FrameLoader::setMainDocumentError):
4129         (WebCore::FrameLoader::mainReceivedCompleteError):
4130         (WebCore::FrameLoader::finalSetupForReplace):
4131         (WebCore::FrameLoader::prepareForLoadStart):
4132         (WebCore::FrameLoader::subframeIsLoading):
4133         (WebCore::FrameLoader::willChangeTitle):
4134         (WebCore::FrameLoader::didChangeTitle):
4135         (WebCore::FrameLoader::loadType):
4136         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
4137         (WebCore::FrameLoader::checkNewWindowPolicy):
4138         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
4139         (WebCore::FrameLoader::continueAfterNavigationPolicy):
4140         (WebCore::FrameLoader::continueAfterWillSubmitForm):
4141         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
4142         (WebCore::FrameLoader::didFirstLayout):
4143         (WebCore::FrameLoader::frameLoadCompleted):
4144         (WebCore::FrameLoader::firstLayoutDone):
4145         (WebCore::FrameLoader::isQuickRedirectComing):
4146         (WebCore::FrameLoader::transitionToCommitted):
4147         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
4148         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
4149         (WebCore::FrameLoader::sendRemainingDelegateMessages):
4150         (WebCore::FrameLoader::requestFromDelegate):
4151         (WebCore::FrameLoader::post):
4152         (WebCore::FrameLoader::detachChildren):</