8c166433e33502de8e275fcfacbd281fab472f02
[WebKit-https.git] / WebCore / ChangeLog
1 2009-03-12  Xan Lopez  <xlopez@igalia.com>
2
3         Reviewed by Alexey Proskuryakov.
4
5         https://bugs.webkit.org/show_bug.cgi?id=24519
6         [GTK] Use two argument KURL ctor in ResourceHandleSoup
7
8         Use two argument KURL ctor, the single argument ctor expects its
9         input to be the output of a previous KURL::parse call, which is
10         not the case here.
11
12         * platform/network/soup/ResourceHandleSoup.cpp:
13         (WebCore::fillResponseFromMessage):
14         (WebCore::queryInfoCallback):
15
16 2009-03-11  Jon Honeycutt  <jhoneycutt@apple.com>
17
18         Fix for <rdar://6418681>
19         https://bugs.webkit.org/show_bug.cgi?id=22644
20
21         Reviewed by Steve Falkenburg.
22
23         * plugins/win/PluginPackageWin.cpp:
24         (WebCore::PluginPackage::isPluginBlacklisted): Add the Citrix ICA
25         Client plug-in to the blacklist; it requires a Mozilla-based browser.
26
27 2009-03-12  Oliver Hunt  <oliver@apple.com>
28
29         Reviewed by NOBODY (build fix).
30
31         build fix.
32
33         * html/CanvasRenderingContext2D.h:
34
35 2009-03-11  Oliver Hunt  <oliver@apple.com>
36
37         Reviewed by Adele Peterson.
38
39         <rdar://problem/6673852> Widget "Simple World Clock" does not display with Safari 4
40
41         A number of dashboard widgets rely on canvas failing silently when given invalid
42         colors for gradient stops, but both the spec and firefox throw exceptions here.
43         So we work around this by creating a dashboard quirk that will only suppress the
44         exception in dashboard compatibility mode.
45
46         Test: fast/canvas/canvas-gradient-addStop-error.html
47
48         * html/CanvasGradient.cpp:
49         (WebCore::CanvasGradient::CanvasGradient):
50         (WebCore::CanvasGradient::addColorStop):
51         * html/CanvasGradient.h:
52         (WebCore::CanvasGradient::setDashboardCompatibilityMode):
53         * html/CanvasRenderingContext2D.cpp:
54         (WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
55         (WebCore::CanvasRenderingContext2D::createLinearGradient):
56         (WebCore::CanvasRenderingContext2D::createRadialGradient):
57         * html/CanvasRenderingContext2D.h:
58
59 2009-03-11  David Kilzer  <ddkilzer@apple.com>
60
61         Clarify comments regarding order of FEATURE_DEFINES
62
63         Rubber-stamped by Mark Rowe.
64
65         * Configurations/WebCore.xcconfig: Added warning about the
66         consequences when FEATURE_DEFINES are not kept in sync.
67
68 2009-03-11  Gustavo Noronha Silva  <gns@gnome.org>
69
70         Reviewed by Holger Freyther.
71
72         https://bugs.webkit.org/show_bug.cgi?id=24515
73         [GTK] soup backend should use GMappedFile instead of mmap directly
74
75         Rewrite mmap code used to upload files to use GMappedFile, so that
76         it is platform-independent.
77
78         * platform/network/soup/ResourceHandleSoup.cpp:
79         (WebCore::ResourceHandle::startHttp):
80
81 2009-03-11  Dan Bernstein  <mitz@apple.com>
82
83         Reviewed by Darin Adler.
84
85         - WebCore part of fixing <rdar://problem/3919124> Thai text selection
86           in Safari is incorrect
87
88         Test: platform/mac/editing/selection/word-thai.html
89
90         Tested on Mac, but should work on all ICU platforms (or more precisely
91         on all platforms that implement
92         WTF::Unicode::hasLineBreakingPropertyComplexContext() correctly).
93
94         * editing/TextIterator.cpp:
95         (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
96         Added.
97         (WebCore::BackwardsCharacterIterator::range): Added.
98         (WebCore::BackwardsCharacterIterator::advance): Added.
99
100         * editing/TextIterator.h: Added BackwardsCharacterIterator with the
101         minimal functionality required for this patch.
102         (WebCore::BackwardsCharacterIterator::atEnd): Added.
103
104         * editing/visible_units.cpp:
105         (WebCore::firstNonComplexContextLineBreak): Added this helper function
106         that returns the index of the first character in the string whose
107         Unicode line breaking property value is not SA ("Complex Context"), or
108         the length of the string if there is no such character.
109         (WebCore::lastNonComplexContextLineBreak): Added this helper function
110         that returns the index of the last character in the string whose
111         Unicode line breaking property value is not SA ("Complex Context"), or
112         -1 if there is no such character.
113         (WebCore::previousBoundary): Changed the signature of the search
114         function to include an offset parameter. Renamed the 'exception' local
115         variable to 'ec' and changed its type to ExceptionCode. Extend the
116         string forwards until the first character with Unicode line breaking
117         property value other than SA. This gives the boundary search function
118         enough context in the forward direction. Changed to use a
119         BackwardsCharacterIterator for translating the backwards offset into
120         a position.
121         (WebCore::nextBoundary): Changed the signature of the search
122         function to include an offset parameter. Extend the string backwards
123         until the first character with Unicode line breaking property value
124         other than SA. This gives the boundary search function enough context in
125         the backwards direction. Restricted the workaround for <rdar://5192593>
126         only to the line break case, because it was causing an extra character
127         to be selected following a word that ended with a combining mark.
128         (WebCore::startWordBoundary): Added an offset parameter. Check that
129         going backwards from the given offset, there is a character with Unicode
130         line breaking property value other than SA, and otherwise return 0 to
131         request more context.
132         (WebCore::endWordBoundary): Similar, but in reverse.
133         (WebCore::previousWordPositionBoundary): Similar.
134         (WebCore::nextWordPositionBoundary): Similar.
135         (WebCore::startSentenceBoundary): Updated for the new search function
136         signature.
137         (WebCore::endSentenceBoundary): Ditto.
138         (WebCore::previousSentencePositionBoundary): Ditto.
139         (WebCore::nextSentencePositionBoundary): Ditto.
140
141 2009-03-11  Darin Adler  <darin@apple.com>
142
143         Reviewed by Mark Rowe.
144
145         Don't use "::" in thread names because it is ugly!
146
147         * loader/icon/IconDatabase.cpp:
148         (WebCore::IconDatabase::open): Use "WebCore: " instead of "WebCore::".
149         * platform/network/cf/ResourceHandleCFNet.cpp:
150         (WebCore::ResourceHandle::loaderRunLoop): Call this "WebCore: CFNetwork Loader" to make
151         it clear this is a WebCore-created thread.
152         * storage/DatabaseThread.cpp:
153         (WebCore::DatabaseThread::start): Use "WebCore: " instead of "WebCore::".
154         * storage/LocalStorageThread.cpp:
155         (WebCore::LocalStorageThread::start): Use "WebCore: " instead of "WebCore::".
156         * workers/WorkerThread.cpp:
157         (WebCore::WorkerThread::start): Use "WebCore: " instead of "WebCore::".
158
159 2009-03-11  Mark Rowe  <mrowe@apple.com>
160
161         Rubber-stamped by Darin Adler.
162
163         <rdar://problem/6653286> WebCore's implementation of screenIsMonochrome is needlessly complex
164
165         * platform/mac/PlatformScreenMac.mm:
166         (WebCore::screenIsMonochrome): Return false.
167
168 2009-03-11  Beth Dakin  <bdakin@apple.com>
169
170         Reviewed by Dan Bernstein.
171
172         Fix for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage 
173         top value on position:relative child not calculated correctly if 
174         parent has percentage height
175         - and corresponding -
176         <rdar://problem/6172925>
177
178         * rendering/RenderBoxModelObject.cpp:
179         (WebCore::RenderBoxModelObject::relativePositionOffsetY):
180
181 2009-03-11  Jian Li  <jianli@chromium.org>
182
183         Reviewed by Dimitri Glazkov.
184
185         Implement ScriptValue::hasNoValue for V8.
186         https://bugs.webkit.org/show_bug.cgi?id=24507
187
188         * bindings/v8/ScriptValue.h:
189         (WebCore::ScriptValue::hasNoValue):
190
191 2009-03-11  David Levin  <levin@chromium.org>
192
193         Reviewed by Dimitri Glazkov.
194
195         Bug 24459: Add v8 bindings for event.
196         <https://bugs.webkit.org/show_bug.cgi?id=24459>
197
198         Adding custom event bindings.
199
200         * bindings/v8/custom/V8AbstractEventListener.cpp: Added.
201         * bindings/v8/custom/V8AbstractEventListener.h: Added.
202         * bindings/v8/custom/V8AttrCustom.cpp:
203         Fixed messed up copyright header.
204         * bindings/v8/custom/V8CustomEventListener.cpp: Added.
205         * bindings/v8/custom/V8CustomEventListener.h:
206         Replaced forwarding header with the real implementation.
207         * bindings/v8/custom/V8ElementCustom.cpp:
208         * bindings/v8/custom/V8LazyEventListener.cpp: Added.
209         * bindings/v8/custom/V8LazyEventListener.h: Added.
210         * bindings/v8/custom/V8ObjectEventListener.cpp: Added.
211         * bindings/v8/custom/V8ObjectEventListener.h: Added.
212         * bindings/v8/custom/V8WorkerContextEventListener.cpp: Added.
213         * bindings/v8/custom/V8WorkerContextEventListener.h: Added.
214
215 2009-03-11  Darin Fisher  <darin@chromium.org>
216
217         Reviewed by Dimitri Glazkov.
218
219         https://bugs.webkit.org/show_bug.cgi?id=24521
220         Add some missing includes for the non-JSC build.
221
222         * platform/text/PlatformString.h: added OwnPtr.h
223         * xml/XMLHttpRequest.cpp: added SecurityOrigin.h
224
225 2009-03-11  Simon Fraser  <simon.fraser@apple.com>
226
227         Reviewed by Darin Adler
228
229         https://bugs.webkit.org/show_bug.cgi?id=24531
230         
231         Make sure that AnimationControllerPrivate::getAnimatedStyleForRenderer() never
232         returns a null style if it has a valid renderer, which could happen if a
233         CompositeAnimation existed, but wasn't running any animations or transitions.
234
235         * page/animation/AnimationController.cpp:
236         (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
237
238 2009-03-11  Simon Fraser  <simon.fraser@apple.com>
239
240         Fix Scons build. Patch from Alexander Guy.
241
242         * WebCore.scons:
243
244 2009-03-11  Simon Fraser  <simon.fraser@apple.com>
245
246         Reviewed by Dan Bernstein
247        
248         https://bugs.webkit.org/show_bug.cgi?id=23093
249         
250         When the cancel button in the search field is shown or hidden,
251         we need to explicitly setStyle() on the cancel button's renderer,
252         to ensure that repaint happens. Changing the style without telling
253         the renderer won't work.
254
255         Test: fast/repaint/search-field-cancel.html
256
257         * rendering/RenderTextControlSingleLine.cpp:
258         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
259         (WebCore::RenderTextControlSingleLine::updateFromElement):
260         (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
261         (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
262         (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
263         * rendering/RenderTextControlSingleLine.h:
264
265 2009-03-11  Hironori Bono  <hbono@chromium.org>
266
267         Reviewed by Alexey Proskuryakov.
268
269         https://bugs.webkit.org/show_bug.cgi?id=15790
270         Ligatures aren't accounted for when manipulating VisiblePositions
271
272         Changed cursorMovementIterator rules to prevent a cursor from moving in the middle of an
273         Indic ligature which uses a virama sign.
274         
275         Test: editing/deleting/skip-virama-001.html
276
277         * platform/text/TextBreakIteratorICU.cpp:
278         (WebCore::cursorMovementIterator):
279
280 2009-03-11  Alexey Proskuryakov  <ap@webkit.org>
281
282         Reviewed by George Staikos.
283
284         https://bugs.webkit.org/show_bug.cgi?id=24513
285         REGRESSION: Cursor movement doesn't work on Tiger (ICU 3.2)
286
287         Fixes existing tests on Tiger.
288
289         * platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator):
290         Use characterBreakIterator on Tiger (like we used to do).
291
292 2009-03-11  Alexey Proskuryakov  <ap@webkit.org>
293
294         Reviewed by Oliver Hunt.
295
296         <rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
297
298         * platform/network/mac/ResourceRequestMac.mm:
299         (WebCore::ResourceRequest::doUpdatePlatformRequest): Correct selector name
300         in instancesRespondToSelector.
301
302 2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>
303
304         Reviewed by Holger Freyther.
305
306         [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
307         https://bugs.webkit.org/show_bug.cgi?id=2260
308
309         Add missing stdio.h include to get the build going
310
311         * plugins/gtk/PluginPackageGtk.cpp:
312
313 2009-03-10  Justin Garcia  <justin.garcia@apple.com>
314
315         Reviewed by Ken Kocienda.
316
317         * dom/Range.cpp:
318         (WebCore::Range::addLineBoxRects): If the range ended at [div, 0], addLineBoxRects
319         would include rects for the divs contents.  Set the correct RenderObject to stop at.
320
321 2009-03-10  Alexey Proskuryakov  <ap@webkit.org>
322
323         Reviewed by Sam Weinig.
324
325         <rdar://problem/6123770> Restrict access to document.cookie when making a cross-site XHR
326
327         * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Removed an incorrect
328         comment about cookie support. Firefox doesn't expose cookies on responseXML at all, and
329         there are security concerns with exposing them for cross-origin requests, so it's not clear
330         if we want to change anything here.
331
332 2009-03-10  Simon Fraser  <simon.fraser@apple.com>
333
334         Reviewed by Darin Adler
335
336         https://bugs.webkit.org/show_bug.cgi?id=24503
337         
338         Fix hit testing of absolutely positioned single line text controls by
339         ensuring that we set result.innerNode() correctly. If the hit node is
340         a descendant of the inner text element or if it is the <input> itself,
341         then we say we hit the innerTextElement.
342         
343         Rename hitInnerTextBlock() to hitInnerTextElement() to match the
344         'innerTextElement' terminology used elsewhere.
345         
346         Assert that if renderer()->hitTest() returns false, no-one set
347         result.innerNode().
348
349         Test: fast/forms/search-abs-pos-cancel-button.html
350
351         * rendering/RenderLayer.cpp:
352         (WebCore::RenderLayer::hitTestContents):
353         * rendering/RenderTextControl.cpp:
354         (WebCore::RenderTextControl::hitInnerTextElement):
355         * rendering/RenderTextControl.h:
356         * rendering/RenderTextControlMultiLine.cpp:
357         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
358         * rendering/RenderTextControlSingleLine.cpp:
359         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
360
361 2009-03-10  Antti Koivisto  <antti@apple.com>
362
363         Reviewed by Mark Rowe.
364
365         <rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.
366         
367         Another case where we would trigger extended encoding loading needlessly.
368
369         * platform/text/TextEncoding.cpp:
370         (WebCore::TextEncoding::isNonByteBasedEncoding):
371
372 2009-03-10  Beth Dakin  <bdakin@apple.com>
373
374         Reviewed by Darin Adler.
375
376         Fix for <rdar://problem/6624769> REGRESSION (Safari 4 PB): No 
377         scroll bar appears for long line of text with NOWRAP set
378
379         This is a regression from http://trac.webkit.org/changeset/32226
380         I talked with Dan about the original change, and we decided that 
381         the best fix was to remove his small potential-optimization that 
382         only created a separate line box for whitespace under certain 
383         circumstances. This new code will always create a separate line 
384         box.
385
386         * rendering/bidi.cpp:
387         (WebCore::RenderBlock::layoutInlineChildren):
388
389 2009-03-10  Sam Weinig  <sam@webkit.org>
390
391         Reviewed by Geoffrey Garen.
392
393         Fix for <rdar://problem/6166844>
394         https://bugs.webkit.org/show_bug.cgi?id=24495
395
396         Use same rule for loading java applets as we do for images.
397
398         * html/HTMLAppletElement.cpp:
399         (WebCore::HTMLAppletElement::createRenderer):
400         * loader/FrameLoader.cpp:
401         (WebCore::FrameLoader::loadItem):
402
403 2009-03-10  Justin Garcia  <justin.garcia@apple.com>
404
405         Reviewed by David Kilzer.
406
407         Get rid of revealCaret and use revealSelection instead.
408
409         * WebCore.base.exp:
410         * editing/SelectionController.cpp:
411         (WebCore::SelectionController::setSelection):
412         * page/Frame.cpp:
413         (WebCore::Frame::revealSelection):
414         * page/Frame.h:
415
416 2009-03-10  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
417
418         Reviewed by Geoff Garen.
419
420         Bug 23736: WebKit Crashes on http://g-conquest.fr/~server2
421         <https://bugs.webkit.org/show_bug.cgi?id=23736>
422         <rdar://problem/6560278>
423
424         Before replacing the document, FrameLoader::executeIfJavaScriptURL()
425         should call stopAllLoaders(), just like continueLoadAfterNavigationPolicy().
426
427         * loader/FrameLoader.cpp:
428         (WebCore::FrameLoader::executeIfJavaScriptURL):
429
430 2009-03-10  Darin Adler  <darin@apple.com>
431
432         Reviewed by Alexey Proskuryakov.
433
434         Bug 24494: crash when deleting at end of document and merging paragraphs
435         https://bugs.webkit.org/show_bug.cgi?id=24494
436         rdar://problem/6571537
437
438         Test: editing/deleting/merge-at-end-of-document.html
439
440         * dom/Range.cpp:
441         (WebCore::Range::compareBoundaryPoints): Split out assertion. It's better not to
442         use && in assertions since we'd like to know which condition is failing.
443
444         * editing/ApplyStyleCommand.cpp:
445         (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null check before
446         calling compareBoundaryPoints, since a 0 for the node is ambiguous and so the
447         function doesn't know which value to return.
448
449 2009-03-10  Dirk Schulze  <krit@webkit.org>
450
451         Reviewed by Eric Seidel. Math checked by Oliver Hunt.
452
453         Implement the Cairo version of the checkForSolidColor() method. This halfes the
454         time to draw on 1x1 px background images.
455         I added two new calls to Color for the pixel manipulation on cairo_surface's.
456         They are neede to premultiply/unpremultiply the colors of the surface.
457
458         [CAIRO] Introduce single-pixel image optimizations
459         https://bugs.webkit.org/show_bug.cgi?id=17284
460
461         * platform/graphics/Color.cpp:
462         (WebCore::colorFromPremultipliedARGB):
463         (WebCore::premultipliedARGBFromColor):
464         * platform/graphics/Color.h:
465         * platform/graphics/cairo/ImageBufferCairo.cpp:
466         (WebCore::ImageBuffer::getImageData):
467         (WebCore::ImageBuffer::putImageData):
468         * platform/graphics/cairo/ImageCairo.cpp:
469         (WebCore::BitmapImage::checkForSolidColor):
470
471 2009-03-06  Darin Fisher  <darin@chromium.org>
472
473         Reviewed by Sam Weinig.
474
475         https://bugs.webkit.org/show_bug.cgi?id=24437
476
477         Add support for registering noAccess URL schemes:
478         1-  Add FrameLoader::registerURLSchemeAsNoAccess, and have SecurityOrigin check
479         that list upon construction (similar to how isLocal is implemented).
480         2-  Make InspectorController call grantUniversalAccess on its Document's
481         SecurityOrigin at the time when windowScriptObjectAvailable is called.
482
483         This enables content such as the inspector to be loaded from a custom (non-file)
484         URL, which is how Chromium loads the inspector.  It also allows other URL schemes
485         to be treated like data: URLs, which Chromium utilizes for its various HTML-based
486         UI panels.
487
488         * inspector/InspectorController.cpp:
489         (WebCore::InspectorController::windowScriptObjectAvailable):
490         * loader/FrameLoader.cpp:
491         (WebCore::localSchemes):
492         (WebCore::noAccessSchemes):
493         (WebCore::FrameLoader::loadItem):
494         * loader/FrameLoader.h:
495         * page/SecurityOrigin.cpp:
496         (WebCore::SecurityOrigin::SecurityOrigin):
497         (WebCore::SecurityOrigin::isLocal):
498
499 2009-03-10  Xan Lopez  <xlopez@igalia.com>
500
501         Build fix, no review
502
503         * page/mac/AccessibilityObjectWrapper.mm:
504         (textMarkerForVisiblePosition):
505         (visiblePositionForTextMarker):
506
507 2009-03-10  Xan Lopez  <xlopez@igalia.com>
508
509         Reviewed by Darin Adler.
510
511         https://bugs.webkit.org/show_bug.cgi?id=24491
512         Rename posOffset to m_offset, get rid of accessor
513
514         As suggested in dom/Position.h, this patch gets rid of the
515         'offset()' accessor and renames posOffset to m_offset. I've used
516         m_offset instead of offset to follow the style guide lines, since
517         Position is still a class and not a structure. If the long term
518         plan is still to make it a structure it would be pretty easy to
519         just s/m_offset/offset/ globally when that is achieved.
520
521         * dom/Position.cpp:
522         (WebCore::Position::previous):
523         (WebCore::Position::next):
524         (WebCore::Position::atStart):
525         (WebCore::Position::atEnd):
526         (WebCore::Position::renderedOffset):
527         (WebCore::Position::isCandidate):
528         (WebCore::Position::inRenderedText):
529         (WebCore::Position::isRenderedCharacter):
530         (WebCore::Position::rendersInDifferentPosition):
531         (WebCore::Position::leadingWhitespacePosition):
532         (WebCore::Position::debugPosition):
533         (WebCore::Position::formatForDebugger):
534         * dom/Position.h:
535         (WebCore::Position::Position):
536         * dom/PositionIterator.h:
537         (WebCore::PositionIterator::PositionIterator):
538         * dom/Range.cpp:
539         * dom/RangeBoundaryPoint.h:
540         (WebCore::RangeBoundaryPoint::position):
541         (WebCore::RangeBoundaryPoint::set):
542         (WebCore::RangeBoundaryPoint::setOffset):
543         (WebCore::RangeBoundaryPoint::setToChild):
544         (WebCore::RangeBoundaryPoint::setToStart):
545         (WebCore::RangeBoundaryPoint::setToEnd):
546         (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
547         * editing/ApplyStyleCommand.cpp:
548         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
549         (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
550         (WebCore::ApplyStyleCommand::removeInlineStyle):
551         (WebCore::ApplyStyleCommand::nodeFullySelected):
552         (WebCore::ApplyStyleCommand::nodeFullyUnselected):
553         (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
554         (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
555         (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
556         (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
557         (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
558         (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
559         (WebCore::ApplyStyleCommand::joinChildTextNodes):
560         * editing/BreakBlockquoteCommand.cpp:
561         (WebCore::BreakBlockquoteCommand::doApply):
562         * editing/CompositeEditCommand.cpp:
563         (WebCore::CompositeEditCommand::insertNodeAt):
564         (WebCore::CompositeEditCommand::positionOutsideTabSpan):
565         (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
566         (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
567         (WebCore::CompositeEditCommand::deleteInsignificantText):
568         (WebCore::CompositeEditCommand::removePlaceholderAt):
569         (WebCore::CompositeEditCommand::moveParagraphs):
570         (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
571         * editing/DeleteSelectionCommand.cpp:
572         (WebCore::updatePositionForNodeRemoval):
573         (WebCore::updatePositionForTextRemoval):
574         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
575         (WebCore::DeleteSelectionCommand::fixupWhitespace):
576         * editing/Editor.cpp:
577         (WebCore::Editor::setComposition):
578         (WebCore::Editor::advanceToNextMisspelling):
579         (WebCore::Editor::getCompositionSelection):
580         * editing/InsertLineBreakCommand.cpp:
581         (WebCore::InsertLineBreakCommand::doApply):
582         * editing/InsertParagraphSeparatorCommand.cpp:
583         (WebCore::InsertParagraphSeparatorCommand::doApply):
584         * editing/InsertTextCommand.cpp:
585         (WebCore::InsertTextCommand::performTrivialReplace):
586         (WebCore::InsertTextCommand::input):
587         (WebCore::InsertTextCommand::insertTab):
588         * editing/MoveSelectionCommand.cpp:
589         (WebCore::MoveSelectionCommand::doApply):
590         * editing/ReplaceSelectionCommand.cpp:
591         (WebCore::ReplaceSelectionCommand::doApply):
592         * editing/SelectionController.cpp:
593         (WebCore::SelectionController::debugRenderer):
594         * editing/TextIterator.cpp:
595         (WebCore::TextIterator::rangeFromLocationAndLength):
596         * editing/TypingCommand.cpp:
597         (WebCore::TypingCommand::deleteKeyPressed):
598         (WebCore::TypingCommand::forwardDeleteKeyPressed):
599         * editing/VisiblePosition.cpp:
600         (WebCore::VisiblePosition::characterAfter):
601         (WebCore::VisiblePosition::debugPosition):
602         (WebCore::makeRange):
603         (WebCore::setStart):
604         (WebCore::setEnd):
605         * editing/VisibleSelection.cpp:
606         (WebCore::VisibleSelection::toNormalizedRange):
607         (WebCore::makeSearchRange):
608         (WebCore::VisibleSelection::debugPosition):
609         (WebCore::VisibleSelection::showTreeForThis):
610         * editing/htmlediting.cpp:
611         (WebCore::comparePositions):
612         (WebCore::rangeCompliantEquivalent):
613         (WebCore::isFirstPositionAfterTable):
614         (WebCore::isLastPositionBeforeTable):
615         * editing/visible_units.cpp:
616         (WebCore::previousBoundary):
617         (WebCore::nextBoundary):
618         (WebCore::startPositionForLine):
619         (WebCore::startOfLine):
620         (WebCore::endPositionForLine):
621         (WebCore::nextLinePosition):
622         (WebCore::startOfParagraph):
623         (WebCore::endOfParagraph):
624         * page/AccessibilityObject.cpp:
625         (WebCore::updateAXLineStartForVisiblePosition):
626         * page/AccessibilityRenderObject.cpp:
627         (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
628         * page/DOMSelection.cpp:
629         (WebCore::DOMSelection::anchorOffset):
630         (WebCore::DOMSelection::baseOffset):
631         (WebCore::DOMSelection::focusOffset):
632         (WebCore::DOMSelection::extentOffset):
633         * page/EventHandler.cpp:
634         (WebCore::EventHandler::handleMousePressEventSingleClick):
635         * page/Frame.cpp:
636         (WebCore::Frame::selectionLayoutChanged):
637         * rendering/RenderTextControl.cpp:
638         (WebCore::RenderTextControl::indexForVisiblePosition):
639         * rendering/RenderTreeAsText.cpp:
640         (WebCore::writeSelection):
641
642 2009-03-10  Darin Adler  <darin@apple.com>
643
644         Reviewed by Dan Bernstein.
645
646         Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
647         https://bugs.webkit.org/show_bug.cgi?id=23564
648         rdar://problem/6537238
649
650         Test: fast/dom/HTMLElement/innerHTML-selection-crash.html
651
652         * editing/markup.cpp: (WebCore::createMarkup): Added updateLayoutIgnorePendingStylesheets
653         call to the one of the two overloads of this function that wasn't calling it. This fixes
654         this crash and other possible crashes inside innerHTML.
655
656 2009-03-10  Alexey Proskuryakov  <ap@webkit.org>
657
658         Reviewed by Darin Adler.
659
660         https://bugs.webkit.org/show_bug.cgi?id=24285
661         Text resource loading checks for BOM twice
662
663         This removes TextDecoder class, since its only purpose was to check for BOM, which is
664         already done in TextResourceDecoder. Callers that use TextEncoding::decode() won't get
665         BOM checked, but I didn't find any cases where it would significantly change behavior.
666
667         * GNUmakefile.am:
668         * WebCore.pro:
669         * WebCore.scons:
670         * WebCore.vcproj/WebCore.vcproj:
671         * WebCore.xcodeproj/project.pbxproj:
672         * WebCoreSources.bkl:
673         Remove TextDecoder.{h,cpp}.
674
675         * platform/text/TextDecoder.cpp: Removed.
676         * platform/text/TextDecoder.h: Removed.
677
678         * loader/TextResourceDecoder.h: Instead of a TextDecoder object, keep TextEncoding and
679         TextCodec separately.
680
681         * loader/TextResourceDecoder.cpp:
682         (WebCore::TextResourceDecoder::TextResourceDecoder): Updated for m_encoding being a member.
683         (WebCore::TextResourceDecoder::setEncoding): Ditto.
684         (WebCore::TextResourceDecoder::checkForBOM): Removed a FIXME saying that a BOM could override
685         even a user-chosen encoding - this is how it already worked due to TextDecoder checking for
686         BOM again. Made this function return the detected BOM length.
687         (WebCore::TextResourceDecoder::decode): Skip the BOM if it was found at the beginning of
688         a text resource.
689         (WebCore::TextResourceDecoder::flush): Reset m_checkedForBOM, so that re-decoding the same
690         resource again (as frequently done by CachedResource subclasses) will skip the BOM correctly.
691
692         * platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode):
693         Use TextCodec directly without a TextDecoder wrapper. This means that this method no longer
694         checks for BOM, which was a counter-intuitive feature.
695
696         * loader/CachedScript.cpp:
697         (WebCore::CachedScript::CachedScript):
698         (WebCore::CachedScript::setEncoding):
699         (WebCore::CachedScript::encoding):
700         (WebCore::CachedScript::script):
701         * loader/CachedScript.h:
702         * loader/appcache/ManifestParser.cpp:
703         (WebCore::parseManifest):
704         Use TextResourceDecoder, as TextEncoding::decode() no longer checks for BOM.
705         A side effect of this is that these resources will now be subject to encoding auto-detection.
706
707         * loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
708         * page/Page.cpp: (WebCore::Page::userStyleSheet):
709         Be sure to flush TextResourceDecoder, pushing any remaining bytes out, and making the decoder
710         re-usable (for repeated decoding of the same resource).
711
712         * platform/text/TextEncodingRegistry.h: Updated comments for newTextCodec().
713
714 2009-03-10  Alexey Proskuryakov  <ap@webkit.org>
715
716         Reviewed by Darin Adler.
717
718         https://bugs.webkit.org/show_bug.cgi?id=24488
719         An assertion failure when updating an offline application cache after emptying caches
720
721         Emptying appcache cannot be performed automatically, so no test.
722
723         * loader/appcache/ApplicationCacheGroup.cpp:
724         (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk
725         storage, even if the application wasn't updated server side.
726
727 2009-03-10  Oliver Hunt  <oliver@apple.com>
728
729         Reviewed by Alexey Proskuryakov.
730
731         <rdar://problem/6425807> Implement WorkerUtils.importScripts()
732         <https://bugs.webkit.org/show_bug.cgi?id=22721>
733
734         Implement importScripts, currently uses a series of synchronous loads
735         to fetch the scripts, but this is simpler than a synchronous load of
736         multiple loads in parallel.  In future we'll want to switch to parallel
737         loading, but this will do for now.
738         
739         Test: http/tests/workers/worker-importScripts.html
740
741         * GNUmakefile.am:
742         * WebCore.vcproj/WebCore.vcproj:
743         * WebCore.xcodeproj/project.pbxproj:
744         * bindings/js/JSWorkerContextCustom.cpp:
745         (WebCore::JSWorkerContext::importScripts):
746         * bindings/js/ScriptValue.h:
747         (WebCore::ScriptValue::hasNoValue):
748         * bindings/js/WorkerScriptController.cpp:
749         (WebCore::WorkerScriptController::evaluate):
750         (WebCore::WorkerScriptController::setException):
751         * bindings/js/WorkerScriptController.h:
752         * dom/Document.cpp:
753         (WebCore::Document::scriptImported):
754         * dom/Document.h:
755         * dom/ScriptExecutionContext.h:
756         * inspector/InspectorController.cpp:
757         (WebCore::InspectorController::scriptImported):
758         * inspector/InspectorController.h:
759         * inspector/InspectorResource.cpp:
760         (WebCore::InspectorResource::setScriptProperties):
761         * inspector/InspectorResource.h:
762         * workers/WorkerContext.cpp:
763         (WebCore::WorkerContext::scriptImported):
764         (WebCore::WorkerContext::importScripts):
765         * workers/WorkerContext.h:
766         * workers/WorkerContext.idl:
767         * workers/WorkerImportScriptsClient.cpp: Added.
768         (WebCore::WorkerImportScriptsClient::didReceiveResponse):
769         (WebCore::WorkerImportScriptsClient::didReceiveData):
770         (WebCore::WorkerImportScriptsClient::didFinishLoading):
771         (WebCore::WorkerImportScriptsClient::didFail):
772         (WebCore::WorkerImportScriptsClient::didFailRedirectCheck):
773         (WebCore::WorkerImportScriptsClient::didReceiveAuthenticationCancellation):
774         * workers/WorkerImportScriptsClient.h: Added.
775         (WebCore::WorkerImportScriptsClient::WorkerImportScriptsClient):
776         (WebCore::WorkerImportScriptsClient::script):
777         (WebCore::WorkerImportScriptsClient::failed):
778
779 2009-03-10  Alexey Proskuryakov  <ap@webkit.org>
780
781         Reviewed by Darin Adler.
782
783         https://bugs.webkit.org/show_bug.cgi?id=24462
784         Move cross-origin access control code out of XMLHttpRequest
785
786         Step 1: move preflight result cache and access control helper functions.
787
788         No change in behavior, so no test.
789
790         * GNUmakefile.am:
791         * WebCore.pro:
792         * WebCore.scons:
793         * WebCore.vcproj/WebCore.vcproj:
794         * WebCore.xcodeproj/project.pbxproj:
795         * WebCoreSources.bkl:
796         * loader/CrossOriginAccessControl.cpp: Added.
797         (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
798         (WebCore::isSimpleCrossOriginAccessRequest):
799         (WebCore::createAllowedCrossOriginResponseHeadersSet):
800         (WebCore::isOnAccessControlResponseHeaderWhitelist):
801         (WebCore::passesAccessControlCheck):
802         * loader/CrossOriginAccessControl.h: Added.
803         * loader/CrossOriginPreflightResultCache.cpp: Added.
804         (WebCore::parseAccessControlMaxAge):
805         (WebCore::addToAccessControlAllowList):
806         (WebCore::parseAccessControlAllowList):
807         (WebCore::CrossOriginPreflightResultCacheItem::parse):
808         (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod):
809         (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
810         (WebCore::CrossOriginPreflightResultCacheItem::allowsRequest):
811         (WebCore::CrossOriginPreflightResultCache::shared):
812         (WebCore::CrossOriginPreflightResultCache::appendEntry):
813         (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
814         * loader/CrossOriginPreflightResultCache.h: Added.
815         (WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem):
816         (WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
817         * xml/XMLHttpRequest.cpp:
818         (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
819         (WebCore::XMLHttpRequest::createRequest):
820         (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest):
821         (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
822         (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight):
823         (WebCore::XMLHttpRequest::didReceiveResponse):
824         (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
825         * xml/XMLHttpRequest.h:
826
827 2009-03-10  Alexey Proskuryakov  <ap@webkit.org>
828
829         Reviewed by Darin Adler.
830
831         https://bugs.webkit.org/show_bug.cgi?id=19797
832         Bring the list of forbidden headers in sync with XMLHttpRequest spec draft
833
834         Added new checks to http/tests/xmlhttprequest/set-dangerous-headers.html.
835
836         * xml/XMLHttpRequest.cpp:
837         (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Added all headers from
838         XMLHttpRequest 2 draft.
839
840 2009-03-10  Dan Bernstein  <mitz@apple.com>
841
842         Reviewed by Adele Peterson.
843
844         - fix https://bugs.webkit.org/show_bug.cgi?id=23975
845           <rdar://problem/6593610> REGRESSION: Scrollbar arrow not repainted
846
847         * rendering/RenderLayer.cpp:
848         (WebCore::RenderLayer::invalidateScrollbarRect): Corrected the vertical
849         scrollbar rect calculation.
850
851 2009-03-09  Simon Fraser  <simon.fraser@apple.com>
852
853         Reviewed by Dan Bernstein, Oliver Hunt
854
855         https://bugs.webkit.org/show_bug.cgi?id=24475
856         
857         When repainting replaced elements, need to union the selection
858         and overflow rects because either may extend outside the other.
859         
860         Test: fast/repaint/transform-replaced-shadows.html
861
862         * rendering/RenderReplaced.cpp:
863         (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
864
865 2009-03-09  Stephanie Lewis  <slewis@apple.com>
866
867         Fix build.
868
869         * editing/Editor.cpp:
870         (WebCore::Editor::advanceToNextMisspelling):
871         (WebCore::markAllMisspellingsAndBadGrammarInRanges):
872
873 2009-03-09  Kim Christensen  <kimworking@gmail.com>
874
875         Reviewed by Darin Fisher.
876
877         https://bugs.webkit.org/show_bug.cgi?id=24276
878         Dropdown / select boxes do not consider the windows task bar in Chromium.
879
880         * platform/chromium/PopupMenuChromium.cpp:
881         (WebCore::PopupContainer::showPopup):
882
883 2009-03-09  Dan Bernstein  <mitz@apple.com>
884
885         Reviewed by Adele Peterson and Dave Hyatt.
886
887         - fix <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has
888           misaligned edit fields
889
890         Test: fast/forms/legend-display-none.html
891
892         * css/CSSStyleSelector.cpp:
893         (WebCore::CSSStyleSelector::adjustRenderStyle): Change the display
894         property of legend elements to 'block' unless it is 'none'.
895         * css/html4.css: Do not force the display property of legend elements to
896         'block' using CSS, because that prevents style rules from setting it to
897         'none'.
898
899 2009-03-09  Alpha Lam  <hclam@chromium.org>
900
901         Reviewed by Dave Hyatt.
902
903         https://bugs.webkit.org/show_bug.cgi?id=23024
904
905         Fix an incorrect criteria in the if statement that leaves references to
906         deleted floating objects in RenderBlock.
907
908         Test: fast/block/float/crash-on-absolute-positioning.html
909
910         * rendering/RenderBlock.cpp:
911         (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
912
913 2009-03-09  Mike Belshe  <mike@belshe.com>
914
915         Reviewed by Eric Seidel.
916
917         Unify JSC/V8 idl file.
918         https://bugs.webkit.org/show_bug.cgi?id=24424
919
920         * page/Location.idl:
921
922 2009-03-09  Mike Belshe  <mike@belshe.com>
923
924         Reviewed by Eric Seidel.
925
926         Unify JSC/V8 for History.idl.
927
928         * page/History.idl:
929
930 2009-03-09  Mike Belshe  <mike@belshe.com>
931
932         Reviewed by Eric Seidel.
933
934         Unify JSC/V8 implementations of DOMWindow.idl.
935
936         * page/DOMWindow.idl:
937
938 2009-03-09  Simon Fraser  <simon.fraser@apple.com>
939
940         Reviewed by Dave Hyatt
941
942         https://bugs.webkit.org/show_bug.cgi?id=24163
943         
944         Implement mapping of FloatQuads through 3D transforms.
945         
946         Removed the redundant localToContainerQuad() methods, which can now 
947         shared code with the old mapLocalToAbsolutePoint(), which was
948         renamed to mapLocalToContainer(). This can now convert a point,
949         and optionally a FloatQuad, which are carried along in the TransformState.
950         
951         Optimized TransformState to reduce to simple FloatPoint.move()
952         if there are no transforms, and to heap-allocate a transform only if
953         necessary to accumulate transforms (when using preserve-3d).
954         
955         Tested by 3d point mapping tests, and the inspector highlight (which now shows
956         the correct quads for 3d-transformed elements).
957
958         * platform/graphics/transforms/TransformationMatrix.cpp:
959         (WebCore::TransformationMatrix::projectQuad):
960         (WebCore::TransformationMatrix::translateRight):
961         (WebCore::TransformationMatrix::translateRight3d):
962         * platform/graphics/transforms/TransformationMatrix.h:
963         * rendering/RenderBox.cpp:
964         (WebCore::RenderBox::mapLocalToContainer):
965         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
966         * rendering/RenderBox.h:
967         * rendering/RenderObject.cpp:
968         (WebCore::RenderObject::localToAbsolute):
969         (WebCore::RenderObject::absoluteToLocal):
970         (WebCore::RenderObject::mapLocalToContainer):
971         (WebCore::RenderObject::localToContainerQuad):
972         * rendering/RenderObject.h:
973         * rendering/RenderTableCell.cpp:
974         (WebCore::RenderTableCell::mapLocalToContainer):
975         * rendering/RenderTableCell.h:
976         * rendering/RenderView.cpp:
977         (WebCore::RenderView::mapLocalToContainer):
978         * rendering/RenderView.h:
979         * rendering/TransformState.cpp:
980         (WebCore::TransformState::move):
981         (WebCore::TransformState::applyTransform):
982         (WebCore::TransformState::flatten):
983         (WebCore::TransformState::mappedPoint):
984         (WebCore::TransformState::mappedQuad):
985         (WebCore::TransformState::flattenWithTransform):
986         (WebCore::HitTestingTransformState::mappedQuad):
987         * rendering/TransformState.h:
988         (WebCore::TransformState::TransformState):
989         (WebCore::TransformState::move):
990         (WebCore::TransformState::lastPlanarPoint):
991         (WebCore::TransformState::lastPlanarQuad):
992         * rendering/style/RenderStyle.h:
993         (WebCore::InheritedFlags::preserves3D):
994
995 2009-03-09  Simon Fraser  <simon.fraser@apple.com>
996
997         Reviewed by Dave Hyatt
998
999         https://bugs.webkit.org/show_bug.cgi?id=24433
1000         
1001         During hit testing with transforms, if a layer has backface-visibility: hidden,
1002         we need to check for it whether or not the layer has a transform, because it
1003         might be an ancestor that is transformed.
1004
1005         Test: transforms/3d/hit-testing/backface-no-transform-hit-test.html
1006
1007         * rendering/RenderLayer.cpp:
1008         (WebCore::RenderLayer::hitTestLayer):
1009
1010 2009-03-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1011
1012         Reviewed by George Staikos.
1013
1014         https://bugs.webkit.org/show_bug.cgi?id=24353
1015         Allow to overrule default build options for Qt build.
1016
1017         * WebCore.pro: Allow to overrule ENABLE_VIDEO and ENABLE_NETSCAPE_PLUGIN_API
1018
1019 2009-03-09  Adam Treat  <adam.treat@torchmobile.com>
1020
1021         Reviewed by George Staikos.
1022
1023         https://bugs.webkit.org/show_bug.cgi?id=24463
1024         WebCore::qstring is detaching and copying twice for every single
1025         WebCore::TextRun that is processed and drawn.  This elevates this method
1026         to one of the top-ten most expensive methods in all of QtWebKit according
1027         to profiling.  This changes the method so that QString only detaches
1028         when absolutely necessary.
1029
1030         * platform/graphics/qt/FontQt.cpp:
1031         (WebCore::qstring):
1032         (WebCore::fixSpacing):
1033         (WebCore::Font::drawComplexText):
1034         (WebCore::Font::floatWidthForComplexText):
1035         (WebCore::Font::offsetForPositionForComplexText):
1036         (WebCore::Font::selectionRectForComplexText):
1037
1038 2009-03-08  Mark Rowe  <mrowe@apple.com>
1039
1040         Reviewed by Oliver Hunt.
1041
1042         Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
1043         Frame.h no longer needs to include it.  This cuts the size of the symbols
1044         for a debug build by around 3%.
1045
1046         * dom/Element.cpp:
1047         (WebCore::Element::scrollIntoView):
1048         (WebCore::Element::scrollIntoViewIfNeeded):
1049         * editing/Editor.cpp:
1050         (WebCore::Editor::insertTextWithoutSendingTextEvent):
1051         (WebCore::Editor::revealSelectionAfterEditingOperation):
1052         * editing/SelectionController.cpp:
1053         (WebCore::SelectionController::setSelection):
1054         * loader/FrameLoader.cpp:
1055         (WebCore::FrameLoader::gotoAnchor):
1056         * page/ContextMenuController.cpp:
1057         (WebCore::ContextMenuController::contextMenuItemSelected):
1058         * page/Frame.cpp:
1059         (WebCore::Frame::revealSelection):
1060         (WebCore::Frame::revealCaret):
1061         * page/Frame.h:
1062         * rendering/RenderLayer.cpp:
1063         (WebCore::RenderLayer::getRectToExpose):
1064         (WebCore::RenderLayer::autoscroll):
1065         * rendering/RenderLayer.h:
1066         * rendering/ScrollBehavior.cpp: Added.
1067         (WebCore::):
1068         * rendering/ScrollBehavior.h: Added.
1069         (WebCore::):
1070         (WebCore::ScrollAlignment::getVisibleBehavior):
1071         (WebCore::ScrollAlignment::getPartialBehavior):
1072         (WebCore::ScrollAlignment::getHiddenBehavior):
1073
1074         Add the new files to the build systems:
1075         * GNUmakefile.am:
1076         * WebCore.base.exp:
1077         * WebCore.pro:
1078         * WebCore.scons:
1079         * WebCore.vcproj/WebCore.vcproj:
1080         * WebCore.xcodeproj/project.pbxproj:
1081         * WebCoreSources.bkl:
1082
1083         Add includes that were previously pulled in by way of RenderLayer.h from Frame.h:
1084         * dom/Clipboard.cpp:
1085         * editing/EditorCommand.cpp:
1086         * editing/InsertLineBreakCommand.cpp:
1087         * editing/TypingCommand.cpp:
1088         * html/HTMLFormControlElement.cpp:
1089         * loader/archive/cf/LegacyWebArchive.cpp:
1090         * loader/icon/IconLoader.cpp:
1091         * page/animation/AnimationController.cpp:
1092         * rendering/RenderSlider.cpp:
1093         * rendering/RenderTextControl.cpp:
1094
1095
1096 2009-03-08  Mark Rowe  <mrowe@apple.com>
1097
1098         Reviewed Dan Bernstein.
1099
1100         Push the include of Frame.h out of RenderView.h and down to those files
1101         that need it.  This cuts the size of symbols for RenderFoo object files
1102         by around 15% in a debug build.
1103
1104         * bindings/objc/DOM.mm:
1105         * rendering/RenderFileUploadControl.cpp:
1106         * rendering/RenderInline.cpp:
1107         * rendering/RenderObject.cpp:
1108         * rendering/RenderReplaced.cpp:
1109         * rendering/RenderText.cpp:
1110         * rendering/RenderView.cpp:
1111         (WebCore::RenderView::zoomFactor):
1112         * rendering/RenderView.h:
1113
1114 2009-03-08  Mark Rowe  <mrowe@apple.com>
1115
1116         Rubber-stamped by Dan Bernstein.
1117
1118         Remove some unnecessary or redundant includes from files related to the JS bindings.
1119         This cuts the size of the symbols for a debug build by around 3%.
1120
1121         * bindings/js/JSCustomPositionCallback.cpp:
1122         * bindings/js/JSCustomPositionErrorCallback.cpp:
1123         * bindings/js/JSCustomSQLStatementCallback.cpp:
1124         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
1125         * bindings/js/JSCustomSQLTransactionCallback.cpp:
1126         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
1127         * bindings/js/JSCustomVoidCallback.cpp:
1128         * bindings/js/JSCustomXPathNSResolver.cpp:
1129         * bindings/js/JSDocumentCustom.cpp:
1130         * bindings/js/JSPluginElementFunctions.cpp:
1131         * bindings/js/JSSVGPODTypeWrapper.h:
1132
1133 2009-03-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
1134
1135         Reviewed by Oliver Hunt.
1136
1137         Remove the unused methods previousHistoryItem(), setPreviousHistoryItem()
1138         and provisionalHistoryItem() from FrameLoader.
1139
1140         * WebCore.base.exp:
1141         * WebCore.order:
1142         * loader/FrameLoader.cpp:
1143         (WebCore::FrameLoader::frameLoadCompleted):
1144         (WebCore::FrameLoader::loadItem):
1145         * loader/FrameLoader.h:
1146
1147 2009-03-08  Gustavo Noronha Silva  <gns@gnome.org>
1148
1149         Reviewed by Holger Freyther.
1150
1151         Implement proper logging for the GTK+ port, inspired by the one in
1152         Qt. We use the WEBKIT_DEBUG environment variable which was already
1153         being used to decide whether to setup a logger for soup or not.
1154
1155         * platform/gtk/LoggingGtk.cpp:
1156         (WebCore::getChannelFromName):
1157         (WebCore::InitializeLoggingChannelsIfNecessary):
1158         * platform/network/soup/ResourceHandleSoup.cpp:
1159         (WebCore::ensureSessionIsInitialized):
1160
1161 2009-03-07  Dan Bernstein  <mitz@apple.com>
1162
1163         Reviewed by Mark Rowe.
1164
1165         - WebCore part of removing build-time and run-time support for legacy
1166           versions of CFNetwork and Core Graphics
1167
1168         * platform/graphics/win/FontCGWin.cpp:
1169         (WebCore::Font::drawGlyphs):
1170         * platform/graphics/win/FontCustomPlatformData.cpp:
1171         (WebCore::FontCustomPlatformData::fontPlatformData):
1172         * platform/graphics/win/FontPlatformDataCGWin.cpp:
1173         (WebCore::FontPlatformData::platformDataInit):
1174         * platform/network/cf/FormDataStreamCFNet.cpp:
1175         (WebCore::setHTTPBody):
1176         (WebCore::httpBodyFromRequest):
1177         * platform/network/cf/ResourceHandleCFNet.cpp:
1178         (WebCore::didSendBodyData):
1179         (WebCore::shouldUseCredentialStorageCallback):
1180         (WebCore::ResourceHandle::start):
1181         * platform/network/win/CookieJarCFNetWin.cpp:
1182         (WebCore::filterCookies):
1183
1184 2009-03-07  Adele Peterson  <adele@apple.com>
1185
1186         Reviewed by Dan Bernstein.
1187
1188         Fix for https://bugs.webkit.org/show_bug.cgi?id=24444
1189         No multiple JS property for <input type="file" multiple />
1190
1191         * html/HTMLInputElement.cpp:
1192         (WebCore::HTMLInputElement::multiple):
1193         (WebCore::HTMLInputElement::setMultiple):
1194         * html/HTMLInputElement.h:
1195         * html/HTMLInputElement.idl:
1196
1197 2009-03-07  Xan Lopez  <xan@gnome.org>
1198
1199         Reviewed by Holger Freyther.
1200
1201         https://bugs.webkit.org/show_bug.cgi?id=24358
1202         [GTK] Scrollbars not clipped correctly
1203
1204         ScrollView scrollbars in subframes are *not* native, so take that
1205         into account again.
1206
1207         * platform/gtk/ScrollbarGtk.cpp:
1208         (ScrollbarGtk::getLocationInParentWindow):
1209         (ScrollbarGtk::frameRectsChanged):
1210         (ScrollbarGtk::paint):
1211         * platform/gtk/ScrollbarGtk.h:
1212
1213 2009-03-06  Peter Kasting  <pkasting@google.com>
1214
1215         Reviewed by Darin Fisher.
1216
1217         https://bugs.webkit.org/show_bug.cgi?id=24405
1218         Horizontal scrolling on Windows was reversed from Mac (and intuition).
1219
1220         * platform/gtk/WheelEventGtk.cpp:
1221         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1222         * platform/win/WheelEventWin.cpp:
1223         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1224
1225 2009-03-06  Peter Kasting  <pkasting@google.com>
1226
1227         Reviewed by Sam Weinig.
1228
1229         Convert some C-style casts to static_cast<>()s.
1230
1231         * platform/gtk/WheelEventGtk.cpp:
1232         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1233         * platform/mac/WheelEventMac.mm:
1234         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1235         * platform/win/WheelEventWin.cpp:
1236         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1237         * platform/wx/MouseWheelEventWx.cpp:
1238         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1239
1240 2009-03-06  Adele Peterson  <adele@apple.com>
1241
1242         Reviewed by Oliver Hunt.
1243
1244         Fix for <rdar://problem/6607524> REGRESSION (Safari 3-4): I can't tab back to the URL field in an empty window (key loop is broken)
1245
1246         I haven't been able to make a test for this since the problem is not reproducible within an empty iframe.
1247
1248         * page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): We used to ensure that every html document had a body element.
1249           That is no longer true, so we should return the document element for a truly empty document.
1250
1251 2009-03-06  Jay Campan  <jcampan@google.com>
1252
1253         Reviewed by Darin Fisher.
1254
1255         https://bugs.webkit.org/show_bug.cgi?id=24306
1256
1257         Adding a flag to ResourceRequestBase to indicate whether or not upload
1258         progress notifications are needed for a resource. This is useful to
1259         avoid sending these notifications when there are no consumers
1260         (especially in the Chromium case where IPC is involved). 
1261
1262         * platform/network/ResourceRequestBase.h:
1263         (WebCore::ResourceRequestBase::reportUploadProgress):
1264         (WebCore::ResourceRequestBase::setReportUploadProgress):
1265         (WebCore::ResourceRequestBase::ResourceRequestBase):
1266         * xml/XMLHttpRequest.cpp:
1267         (WebCore::XMLHttpRequest::loadRequestAsynchronously):
1268
1269 2009-03-06  Dmitry Titov  <dimich@chromium.org>
1270
1271         Reviewed by Alexey Proskuryakov.
1272
1273         https://bugs.webkit.org/show_bug.cgi?id=24150
1274         Add virtual ScriptExecutionContext::encoding()
1275
1276         Test: http/tests/workers/text-encoding.html
1277
1278         * dom/Document.cpp:
1279         (WebCore::Document::encoding):
1280         * dom/Document.h:
1281         (WebCore::Document::inputEncoding):
1282         (WebCore::Document::charset):
1283         (WebCore::Document::characterSet):
1284         Add new virtual method and route DOM synonym functions on Document through it.
1285
1286         * dom/ScriptExecutionContext.h:
1287         * workers/Worker.cpp:
1288         (WebCore::Worker::Worker):
1289         (WebCore::Worker::notifyFinished):
1290         * workers/WorkerContext.cpp:
1291         (WebCore::WorkerContext::WorkerContext):
1292         (WebCore::WorkerContext::encoding):
1293         (WebCore::WorkerContext::completeURL): Added comment on why this is different from Document::completeURL
1294         * workers/WorkerContext.h:
1295         (WebCore::WorkerContext::create):
1296         * workers/WorkerContextProxy.h:
1297         * workers/WorkerMessagingProxy.cpp:
1298         (WebCore::WorkerMessagingProxy::startWorkerContext):
1299         * workers/WorkerMessagingProxy.h:
1300         * workers/WorkerThread.cpp:
1301         (WebCore::WorkerThreadStartupData::create):
1302         (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
1303         (WebCore::WorkerThread::create):
1304         (WebCore::WorkerThread::WorkerThread):
1305         (WebCore::WorkerThread::workerThread):
1306         * workers/WorkerThread.h:
1307         All of the above route the 'encoding' parameter of parent context to the new
1308         instance of WorkerContext - from Worker::notifyFinished() via WorkerMessagingProxy
1309         through WorkerThread through WorkerThreadStartupData and into constructor of WorkerContext.
1310
1311 2009-03-06  Peter Kasting  <pkasting@google.com>
1312
1313         Build bustage fix.
1314
1315         * dom/Node.cpp:
1316         (WebCore::Node::dispatchWheelEvent):
1317
1318 2009-03-06  Eric Carlson  <eric.carlson@apple.com>
1319
1320         Reviewed by Antti Koivisto.
1321
1322         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1323         (WebCore::MediaPlayerPrivate::createQTMovieView):  Delay callback while setting up movieview.
1324
1325 2009-03-06  Douglas R. Davidson  <ddavidso@apple.com>
1326
1327         Reviewed by Justin Garcia.
1328         
1329         https://bugs.webkit.org/show_bug.cgi?id=24108
1330
1331         Update spelling and grammar checking to use the new combined text 
1332         checking (with automatic language identification) on Snow Leopard. 
1333         Tested manually in Mail and Safari; automated tests to come later. 
1334         
1335         * editing/Editor.cpp:
1336         (WebCore::findFirstMisspellingOrBadGrammarInRange):
1337         (WebCore::Editor::advanceToNextMisspelling):
1338         (WebCore::guessesForMisspelledOrUngrammaticalRange):
1339         (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
1340         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
1341         (WebCore::markAllMisspellingsAndBadGrammarInRanges):
1342         (WebCore::Editor::markMisspellingsAndBadGrammar):
1343         * editing/Editor.h:
1344         * loader/EmptyClients.h:
1345         (WebCore::EmptyEditorClient::checkSpellingAndGrammarOfParagraph):
1346         * page/EditorClient.h:
1347         * page/Frame.cpp:
1348         (WebCore::Frame::respondToChangedSelection):
1349         * platform/ContextMenu.cpp:
1350         (WebCore::ContextMenu::populate):
1351
1352 2009-03-06  Peter Kasting  <pkasting@google.com>
1353
1354         Reviewed by Darin Fisher.
1355
1356         https://bugs.webkit.org/show_bug.cgi?id=24407
1357         Windows scroll amount was too small, and wheel scroll distance
1358         conversion code was overly complex.
1359
1360         * page/EventHandler.cpp:
1361         (WebCore::scrollAndAcceptEvent):
1362         * platform/PlatformWheelEvent.h:
1363         (WebCore::):
1364         * platform/ScrollView.cpp:
1365         (WebCore::ScrollView::wheelEvent):
1366         * platform/Scrollbar.h:
1367         * platform/gtk/WheelEventGtk.cpp:
1368         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1369         * platform/mac/WheelEventMac.mm:
1370         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1371         * platform/qt/WheelEventQt.cpp:
1372         * platform/win/WheelEventWin.cpp:
1373         (WebCore::horizontalScrollChars):
1374         (WebCore::verticalScrollLines):
1375         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1376         * platform/wx/MouseWheelEventWx.cpp:
1377         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1378
1379 2009-03-06  Dimitri Glazkov  <dglazkov@chromium.org>
1380
1381         Reviewed by Adam Roben.
1382
1383         Generate valid bindings with HTML5 database support disabled. 
1384
1385         * inspector/InspectorController.idl: Added feature guard around 
1386         databaseTableNames definition.
1387
1388 2009-03-04  Xan Lopez  <xan@gnome.org>
1389
1390         Reviewed by Holger Freyther.
1391
1392         https://bugs.webkit.org/show_bug.cgi?id=24358
1393         [GTK] Scrollbars not clipped correctly
1394
1395         Do not take into account the case of being a ScrollView scrollbar,
1396         since those are native in our case.
1397
1398         * platform/gtk/ScrollbarGtk.cpp:
1399         (ScrollbarGtk::frameRectsChanged):
1400
1401 2009-03-04  Xan Lopez  <xan@gnome.org>
1402
1403         Reviewed by Holger Freyther.
1404
1405         https://bugs.webkit.org/show_bug.cgi?id=24358
1406         [GTK] Scrollbars not clipped correctly
1407
1408         Move Widget::paint to ScrollbarGtk::paint, since it's scrollbar
1409         specific and it's our only Widget anyway.
1410
1411         * platform/gtk/ScrollbarGtk.cpp:
1412         (ScrollbarGtk::paint):
1413         * platform/gtk/ScrollbarGtk.h:
1414         * platform/gtk/WidgetGtk.cpp:
1415
1416 2009-03-04  Xan Lopez  <xan@gnome.org>
1417
1418         Reviewed by Holger Freyther.
1419
1420         https://bugs.webkit.org/show_bug.cgi?id=24358
1421         [GTK] Scrollbars not clipped correctly
1422
1423         Use correct clip rectangle and apply coordinate translation needed
1424         for non-ScrollView scrollbars.
1425
1426         We were ignoring the clip rectangle passed as parameter, which is
1427         wrong in the case of non coalesced expose events. This, in turn,
1428         uncovers the fact that we were not applying coordinate translation
1429         to our position.
1430
1431         * platform/gtk/WidgetGtk.cpp:
1432         (WebCore::Widget::paint):
1433
1434 2009-03-06  Eric Carlson  <eric.carlson@apple.com>
1435
1436         Build fix, no review
1437
1438         * platform/graphics/chromium/MediaPlayerPrivateChromium.h: fix setSize declaration
1439
1440 2009-03-06  Eric Carlson  <eric.carlson@apple.com>
1441
1442         Reviewed by Simon Fraser.
1443
1444         https://bugs.webkit.org/show_bug.cgi?id=22790
1445         Bug 22790: [Transforms] MediaPlayer::setRect() makes no sense with transforms
1446         Replace media engine setRect with setSize since they don't use about the 
1447         position anyway.
1448
1449         * platform/graphics/MediaPlayer.cpp:
1450         (WebCore::NullMediaPlayerPrivate::setSize): Changed from setRect.
1451         (WebCore::MediaPlayer::setSize): Ditto.
1452         * platform/graphics/MediaPlayer.h:
1453         (WebCore::MediaPlayer::size): Changed from rect().
1454
1455         * platform/graphics/MediaPlayerPrivate.h: Changed setRect to setSize.
1456
1457         * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Ditto.
1458
1459         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: 
1460         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_size instead of m_rect
1461         (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
1462         (WebCore::MediaPlayerPrivate::paint): update comment
1463         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: m_rect -> m_size.
1464
1465         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:  m_rect
1466         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1467         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_rect.
1468         (WebCore::MediaPlayerPrivate::createQTMovieView): setRect-> setSize.
1469         (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
1470         (WebCore::MediaPlayerPrivate::paint): Call view:setFrame: when in a media document so 
1471         the movie is drawn in the correct location.
1472
1473         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
1474         (WebCore::MediaPlayerPrivate::setSize):  Changed from setRect
1475         * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
1476
1477         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
1478         (WebCore::MediaPlayerPrivate::setSize):  Changed from setRect
1479         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
1480
1481         * rendering/RenderVideo.cpp:
1482         (WebCore::RenderVideo::updatePlayer): Call setSize instead of setRect.
1483
1484 2009-03-06  Darin Adler  <darin@apple.com>
1485
1486         Reviewed by Darin Fisher.
1487
1488         Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
1489         https://bugs.webkit.org/show_bug.cgi?id=24422
1490         rdar://problem/6402208
1491
1492         Test: fast/dom/location-new-window-no-crash.html
1493
1494         The issue here is empty (or null) URLs. I picked the "schedule navigation" bottleneck
1495         to add some checks for empty URLs. We could also put the empty URL checks at some
1496         other bottleneck level and add more assertions over time. I tried adding a few more
1497         assertions to functions like loadURL and hit them while running the regression tests,
1498         so it's probably going to be a bit tricky to clean this up throughout the loader.
1499
1500         * loader/FrameLoader.cpp:
1501         (WebCore::ScheduledRedirection::ScheduledRedirection): Explicitly marked this struct
1502         immutable by making all its members const. Added assertions about the arguments,
1503         including that the URL is not empty. Initialized one uninitialized member in one of
1504         the constructors.
1505         (WebCore::FrameLoader::scheduleHTTPRedirection): Added an early exit to make this
1506         a no-op if passed an empty URL.
1507         (WebCore::FrameLoader::scheduleLocationChange): Ditto.
1508         (WebCore::FrameLoader::scheduleRefresh): Ditto.
1509
1510 2009-03-06  Gustavo Noronha Silva  <gns@gnome.org>
1511
1512         Reviewed by Holger Freyther.
1513
1514         https://bugs.webkit.org/show_bug.cgi?id=24423
1515         Use new soup_message_body_set_accumulate API in soup backend
1516
1517         Disable accumulating chunks for request_body on file uploads,
1518         using the new soup API.
1519
1520         * platform/network/soup/ResourceHandleSoup.cpp:
1521         (WebCore::ResourceHandle::startHttp):
1522
1523 2009-03-06  Gustavo Noronha Silva  <gns@gnome.org>
1524
1525         Reviewed by Holger Freyther.
1526
1527         Replace use of deprecated SOUP_MESSAGE_OVERWRITE_CHUNKS flag with
1528         the new soup_message_body_set_accumulate API in soup.
1529
1530         * platform/network/soup/ResourceHandleSoup.cpp:
1531         (WebCore::gotHeadersCallback):
1532         (WebCore::ResourceHandle::startHttp):
1533
1534 2009-03-06  Gustavo Noronha Silva  <gns@gnome.org>
1535
1536         Reviewed by Holger Freyther.
1537
1538         https://bugs.webkit.org/show_bug.cgi?id=24051
1539         Soup backend needs content sniffing capabilities
1540
1541         Perform content sniffing when using soup, so that we have a chance
1542         of figuring out the Content-Type of the file if it's not sent by
1543         the server.
1544
1545         * platform/network/ResourceHandleInternal.h:
1546         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1547         * platform/network/soup/ResourceHandleSoup.cpp:
1548         (WebCore::gotHeadersCallback):
1549         (WebCore::gotChunkCallback):
1550
1551 2009-03-06  Hironori Bono  <hbono@chromium.org>
1552
1553         Reviewed by Alexey Proskuryakov.
1554
1555         https://bugs.webkit.org/show_bug.cgi?id=24342
1556         Cannot insert a Thai character after a Thai prepend character when using ICU 4.0
1557
1558         This change creates a new break iterator "cursorMovementIterator" for
1559         moving cursors and use it when moving an input cursor.
1560         In "TextBreakIteratorICU.cpp", this break iterator uses custom ruleset
1561         based on the one of ICU 3.8.
1562         On the other hand, in "TextBreakIteratorQt.cpp", this break iterator
1563         just calls the characterBreakIterator() function.
1564
1565         Test: editing/inserting/insert-thai-characters-001.html
1566
1567         * platform/text/TextBreakIterator.h: Added a new function cursorMovementIterator().
1568         * platform/text/TextBreakIteratorICU.cpp: Implemented the cursorMovementIterator() function for ICU.
1569         (WebCore::setUpIteratorWithRules): Ditto.
1570         (WebCore::cursorMovementIterator): Ditto.
1571         * platform/text/qt/TextBreakIteratorQt.cpp: Implemented the cursorMovementIterator() function for Qt.
1572         (WebCore::cursorMovementIterator): Ditto.
1573         * rendering/RenderText.cpp: Call the cursorMovementIterator() function when moving an input cursor.
1574         (WebCore::RenderText::previousOffset): Ditto.
1575         (WebCore::RenderText::nextOffset): Ditto.
1576
1577 2009-03-05  Alexey Proskuryakov  <ap@webkit.org>
1578
1579         Reviewed by Oliver Hunt.
1580
1581         <rdar://problem/6621701> Safari 4 Beta Breaks XMLHttpRequest Response Text With Special
1582         Characters (a compatibility issue with widgets).
1583
1584         Test: http/tests/xmlhttprequest/broken-xml-encoding.html
1585
1586         Revert part of an Acid 3 fix - now we are no longer strict when decoding XMLHttpRequest XML
1587         responses.
1588
1589         * loader/TextResourceDecoder.cpp:
1590         (WebCore::TextResourceDecoder::TextResourceDecoder):
1591         (WebCore::TextResourceDecoder::decode):
1592         (WebCore::TextResourceDecoder::flush):
1593         * loader/TextResourceDecoder.h:
1594         (WebCore::TextResourceDecoder::useLenientXMLDecoding):
1595         Don't stop on XML decoding errors if useLenientXMLDecoding() was called.
1596
1597         * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Don't stop on XML
1598         decoding errors. This behavior is now limited to other kinds of XML content.
1599
1600 2009-03-05  Simone Fiorentino  <simone.fiorentino@consulenti.fastweb.it>
1601
1602         Bug 24382: request to add SH4 platform
1603
1604         <https://bugs.webkit.org/show_bug.cgi?id=24382>
1605
1606         Reviewed by David Kilzer.
1607
1608         * platform/text/AtomicString.cpp:
1609         (WebCore::equal): Aligned memory access on SH4 platform.
1610
1611 2009-03-05  Jeremy Moskovich  <jeremy@chromium.org>
1612
1613         Reviewed by Simon Fraser.
1614
1615         Fix for https://bugs.webkit.org/show_bug.cgi?id=24215
1616
1617         Gears expects an object tag with display:none to instantiate the plugin,
1618         so we add a workaround to make this work and fix Gears on WebKit trunk.
1619
1620         * html/HTMLObjectElement.cpp:
1621         (WebCore::HTMLObjectElement::rendererIsNeeded):
1622
1623 2009-03-05  Avi Drissman  <avi@chromium.org>
1624
1625         Reviewed by Darin Fisher.
1626
1627         Need to have Chromium Mac match Safari Mac's accesskey handling
1628         https://bugs.webkit.org/show_bug.cgi?id=24404
1629
1630         * page/chromium/EventHandlerChromium.cpp:
1631         (WebCore::EventHandler::accessKeyModifiers): Share access key modifiers with Mac Safari when building for the Mac.
1632
1633 2009-03-05  Simon Fraser  <simon.fraser@apple.com>
1634
1635         Reviewed by Dave Hyatt
1636
1637         https://bugs.webkit.org/show_bug.cgi?id=24412
1638         
1639         Fix crash when hit-testing elements with -webkit-transform-style: preserve-3d
1640         but no transform. We need to make localTransformState if we see preserve-3d.
1641         Also need to call update3DTransformedDescendantStatus() before we test
1642         m_has3DTransformedDescendant.
1643
1644         Test: transforms/3d/hit-testing/hit-preserves-3d.html
1645
1646         * rendering/RenderLayer.cpp:
1647         (WebCore::RenderLayer::hitTestLayer):
1648
1649 2009-03-05  Eric Seidel  <eric@webkit.org>
1650
1651         Reviewed by David Hyatt.
1652
1653         Changes to RenderLayer destruction to hopefully help catch an elusive crasher
1654         https://bugs.webkit.org/show_bug.cgi?id=24409
1655         
1656         Added a new RenderBoxModelObject::destroyLayer() call which is
1657         now the only way which RenderLayers should ever be destroyed.
1658         This ensures that the pointer to the layer is cleared in the
1659         RenderObject after destruction, allowing us to ASSERT in the
1660         RenderBoxModelObject destructor.
1661
1662         * rendering/RenderBox.cpp:
1663         (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
1664         * rendering/RenderBoxModelObject.cpp:
1665         (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
1666         (WebCore::RenderBoxModelObject::destroyLayer):
1667         (WebCore::RenderBoxModelObject::destroy):
1668         (WebCore::RenderBoxModelObject::styleDidChange):
1669         * rendering/RenderBoxModelObject.h:
1670         * rendering/RenderLayer.cpp:
1671         (WebCore::RenderLayer::stackingContext):
1672         (WebCore::RenderLayer::destroy):
1673         (WebCore::RenderLayer::removeOnlyThisLayer):
1674         * rendering/RenderLayer.h:
1675         * rendering/RenderObject.cpp:
1676         (WebCore::RenderObject::destroy):
1677         * rendering/RenderWidget.cpp:
1678         (WebCore::RenderWidget::destroy):
1679
1680 2009-03-05  Eric Seidel  <eric@webkit.org>
1681
1682         Reviewed by David Hyatt.
1683
1684         Remove old, unused IE 5.5 scrollbar-* CSS properties.
1685         Sort the unimplemented getComputedStyle properties so it's
1686         easier to see which ones actually need implementation.
1687
1688         * css/CSSComputedStyleDeclaration.cpp:
1689         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1690         * css/CSSParser.cpp:
1691         (WebCore::CSSParser::parseValue):
1692         * css/CSSPropertyNames.in:
1693         * css/CSSStyleSelector.cpp:
1694         (WebCore::CSSStyleSelector::applyProperty):
1695
1696 2009-03-05  Justin Garcia  <justin.garcia@apple.com>
1697
1698         Reviewed by Darin Adler.
1699         
1700         WebViewDidChangeSelectionNotifications weren't being sent for commands that change the selection's position
1701         within the document without changing its position in the DOM.  For example, pressing return in (caret marked by ^):
1702         <div contentEditable="true"><div>^Hello</div></div>
1703         Undo was being enabled, shouldDeleteDOMRange called, etc. when doing no-op deletes (a delete in an empty document 
1704         for example). 
1705
1706         Changes to layout tests demonstrate fix.
1707         
1708         * editing/EditCommand.cpp:
1709         (WebCore::EditCommand::apply): Don't call applyEditing for a TypingCommand.  The TypingCommand knows whether or
1710         not it did work that needs to be applied.
1711         * editing/Editor.cpp:
1712         (WebCore::Editor::appliedEditing): Moved code (but did not alter) to changeSelectionAfterCommand.
1713         (WebCore::Editor::unappliedEditing): Ditto.
1714         (WebCore::Editor::reappliedEditing): Ditto.
1715         (WebCore::Editor::changeSelectionAfterCommand): Moved code from *appliedEditing into here.  Also call out to
1716         EditorClient::respondToChangedSelection() for commands that changed the selection's position in the document
1717         even if they did not change it's position in the DOM.  Any TypingCommand that gets this far changed it's position
1718         in the document.
1719         * editing/Editor.h:
1720         * editing/TypingCommand.cpp:
1721         (WebCore::TypingCommand::TypingCommand): Removed unused m_appliedEditing.
1722         (WebCore::TypingCommand::typingAddedToOpenCommand): Always apply editing.  We won't get this far if we don't need to.
1723         (WebCore::TypingCommand::deleteKeyPressed): Don't do any of the things that only make sense for Range selections, like
1724         adding to the killring and responding to a change in selections if the delete was a no-op.
1725         (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
1726         * editing/TypingCommand.h:
1727
1728 2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>
1729
1730         Reviewed by Adam Roben.
1731
1732         Eliminate a ref-counting leak in InspectorController.
1733
1734         * inspector/InspectorController.h: Made constructor private, added static create method.
1735         * page/Page.cpp:
1736         (WebCore::Page::Page): Change initializer to use static create method.
1737
1738 2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>
1739
1740         Reviewed by Timothy Hatcher.
1741
1742         https://bugs.webkit.org/show_bug.cgi?id=24355
1743         Add InspectorController.idl and convert InspectorController.cpp to use
1744         JSC bindings.
1745
1746         * DerivedSources.make: Added InspectorController.idl
1747         * WebCore.xcodeproj/project.pbxproj: Added idl, bindings files.
1748         * bindings/js/JSInspectorControllerCustom.cpp: Added.
1749         * bindings/scripts/CodeGeneratorJS.pm: Added Array to no-header types.
1750         * inspector/InspectorController.cpp: Removed hand-rolled bindings.
1751         * inspector/InspectorController.h: Added platform and addSourceToFrame methods.
1752         * inspector/InspectorController.idl: Added.
1753         * page/Page.h: Changed member to RefPtr since InspectorController is now ref-counted.
1754
1755 2009-03-05  Eric Carlson  <eric.carlson@apple.com>
1756
1757         Reviewed by Simon Fraser.
1758
1759         https://bugs.webkit.org/show_bug.cgi?id=24400
1760         Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount" 
1761         media element attributes
1762
1763         Test: media/video-loop.html
1764
1765         * html/HTMLMediaElement.cpp:
1766         (WebCore::HTMLMediaElement::HTMLMediaElement):
1767         (WebCore::HTMLMediaElement::loadInternal):
1768         (WebCore::HTMLMediaElement::setNetworkState):
1769         (WebCore::HTMLMediaElement::seek):
1770         (WebCore::HTMLMediaElement::playInternal):
1771         (WebCore::HTMLMediaElement::loop):
1772         (WebCore::HTMLMediaElement::setLoop):
1773         (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
1774         (WebCore::HTMLMediaElement::endedPlayback):
1775         (WebCore::HTMLMediaElement::updatePlayState):
1776         * html/HTMLMediaElement.h:
1777         * html/HTMLMediaElement.idl:
1778
1779 2009-03-05  Steve Falkenburg  <sfalken@apple.com>
1780
1781         <rdar://problem/6651112> Safari asks about re-posting a form even when page is cached
1782         
1783         Reviewed by Ada Chan.
1784
1785         * platform/network/cf/ResourceHandleCFNet.cpp:
1786         (WebCore::ResourceHandle::willLoadFromCache): Ported from Mac version.
1787
1788 2009-03-05  David Hyatt  <hyatt@apple.com>
1789
1790         Reviewed by Eric Seidel
1791
1792         https://bugs.webkit.org/show_bug.cgi?id=24248
1793
1794         Make sure painting of overflow controls checks that visibility:visible is set on the block before
1795         painting.  Pixel tests caught this regression.
1796
1797         Make sure resizer painting pushes a clip of the corner rect.  It was relying on the clip layers happened
1798         to do to their bounds (which had nothing to do with overflow).
1799
1800         * rendering/RenderBlock.cpp:
1801         (WebCore::RenderBlock::paint):
1802         * rendering/RenderLayer.cpp:
1803         (WebCore::RenderLayer::paintResizer):
1804
1805 2009-03-05  Yong Li  <yong.li@torchmobile.com>
1806
1807         Reviewed by Simon Fraser.
1808
1809         https://bugs.webkit.org/show_bug.cgi?id=24386
1810         A faster implementation of extractMIMETypeFromMediaType.
1811
1812         * platform/network/HTTPParsers.cpp:
1813         (WebCore::extractMIMETypeFromMediaType):
1814
1815 2009-03-05  Yong Li  <yong.li@torchmobile.com>
1816
1817         Reviewed by Antti Koivisto.
1818
1819         https://bugs.webkit.org/show_bug.cgi?id=24392
1820         Do not get the current time for unless we're doing PRELOAD_DEBUG as this
1821         can be unnecessarily expensive.
1822
1823         * html/PreloadScanner.cpp:
1824         (WebCore::PreloadScanner::write):
1825
1826 2009-03-04  Simon Fraser  <simon.fraser@apple.com>
1827
1828         Reviewed by Dave Hyatt
1829
1830         https://bugs.webkit.org/show_bug.cgi?id=24327
1831         
1832         When mapping points and hit testing through transforms, work
1833         correctly when acclerated animations of transforms are running.
1834         
1835         Tested by LayoutTests/animations/animation-hit-test-transform.html,
1836         which only failed when ACCELERATED_COMPOSITING was turned on.
1837
1838         * rendering/RenderLayer.cpp:
1839         (WebCore::RenderLayer::currentTransform):
1840         * rendering/RenderLayer.h:
1841         * rendering/RenderObject.cpp:
1842         (WebCore::RenderObject::transformFromContainer):
1843
1844 2009-03-05  Mike Belshe  <mike@belshe.com>
1845
1846         Reviewed by Darin Fisher.
1847
1848         https://bugs.webkit.org/show_bug.cgi?id=24391
1849         Frame.cpp uses JSC specific includes
1850
1851         * page/Frame.cpp:
1852
1853 2009-03-05  Gustavo Noronha Silva  <gns@gnome.org>
1854
1855         Reviewed by Alexey Proskuryakov.
1856
1857         https://bugs.webkit.org/show_bug.cgi?id=24389
1858         WebKitGTK+ crashes when cancelling plugin loads
1859
1860         Remove bogus calls to the client's didFinishLoading method from
1861         our ResourceHandle::cancel implementation. Calling
1862         didFinishLoading here is mostly inoffensive for most loads, but
1863         causes crashes when plugin loads are cancelled.
1864
1865         * platform/network/soup/ResourceHandleSoup.cpp:
1866         (WebCore::ResourceHandle::cancel):
1867
1868 2009-03-05  Steve Falkenburg  <sfalken@apple.com>
1869
1870         Windows build fix.
1871         
1872         * WebCore.vcproj/QTMovieWin.vcproj:
1873
1874 2009-03-05  Adam Treat  <adam.treat@torchmobile.com>
1875
1876         Build fix for when ENABLE_NETSCAPE_PLUGIN_API = 0.  The method
1877         ScriptController::jsObjectForPluginElement(HTMLPlugInElement*); is not
1878         protected by an #if and uses HTMLPlugInElement so it must be included.
1879
1880         * bindings/js/ScriptController.cpp:
1881
1882 2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>
1883
1884         GTK Build fix.
1885
1886         * inspector/ConsoleMessage.h: Use proper header.
1887
1888 2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>
1889
1890         Reviewed by Timothy Hatcher.
1891
1892         https://bugs.webkit.org/show_bug.cgi?id=24376
1893         Split InspectorController.cpp file into separate classes.
1894
1895         * GNUmakefile.am: Modified to include new files.
1896         * WebCore.pro: Ditto.
1897         * WebCore.scons: Ditto.
1898         * WebCore.vcproj/WebCore.vcproj: Ditto.
1899         * WebCore.xcodeproj/project.pbxproj: Ditto.
1900         * WebCoreSources.bkl: Ditto.
1901         * inspector/ConsoleMessage.cpp: Added.
1902         * inspector/ConsoleMessage.h: Added.
1903         * inspector/InspectorController.cpp:
1904         * inspector/InspectorDOMStorageResource.cpp: Added.
1905         * inspector/InspectorDOMStorageResource.h: Added.
1906         * inspector/InspectorDatabaseResource.cpp: Added.
1907         * inspector/InspectorDatabaseResource.h: Added.
1908         * inspector/InspectorResource.cpp: Added.
1909         * inspector/InspectorResource.h: Added.
1910
1911 2009-03-05  Eric Carlson  <eric.carlson@apple.com>
1912
1913         Reviewed by Darin Adler
1914
1915         https://bugs.webkit.org/show_bug.cgi?id=24387
1916         Remove media element bufferingRate attribute. No test necessary as there
1917         were none for this attribute.
1918
1919         * html/HTMLMediaElement.cpp:
1920         (WebCore::HTMLMediaElement::HTMLMediaElement): Don't initialize m_bufferingRate.
1921         (WebCore::HTMLMediaElement::loadInternal): Ditto.
1922         (WebCore::HTMLMediaElement::setNetworkState): Ditto.
1923         (WebCore::HTMLMediaElement::progressEventTimerFired): Don't calculate m_bufferingRate.
1924         * html/HTMLMediaElement.h: Remove m_bufferingRate.
1925         * html/HTMLMediaElement.idl: Ditto.
1926
1927 2009-03-05  Xan Lopez  <xan@gnome.org>
1928
1929         Reviewed by Mark Rowe.
1930
1931         https://bugs.webkit.org/show_bug.cgi?id=24377
1932         [GTK] Comply better with coding style guidelines in ResourceHandleSoup
1933
1934         Use C++ booleans, 0 instead of NULL, prefix boolean variables with
1935         'is', do not use 'else if' if the previous if had a return, delete
1936         trailing whitespace, etc.
1937
1938         * platform/network/ResourceHandleInternal.h:
1939         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1940         * platform/network/soup/ResourceHandleSoup.cpp:
1941         (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
1942         (WebCore::fillResponseFromMessage):
1943         (WebCore::restartedCallback):
1944         (WebCore::finishedCallback):
1945         (WebCore::parseDataUrl):
1946         (WebCore::ensureSessionIsInitialized):
1947         (WebCore::ResourceHandle::startHttp):
1948         (WebCore::reportUnknownProtocolError):
1949         (WebCore::ResourceHandle::start):
1950         (WebCore::cleanupGioOperation):
1951         (WebCore::closeCallback):
1952         (WebCore::readCallback):
1953         (WebCore::openCallback):
1954         (WebCore::queryInfoCallback):
1955         (WebCore::ResourceHandle::startGio):
1956
1957 2009-03-04  Simon Fraser  <simon.fraser@apple.com>
1958
1959         Reviewed by Eric Seidel
1960
1961         https://bugs.webkit.org/show_bug.cgi?id=24328
1962         
1963         If an element has backface-visibility: hidden, hit testing should not
1964         hit the back sides of elements. Test for that by inverting the accumulated
1965         transform and looking at the z vector.
1966
1967         Tested by transforms/3d/hit-testing/backface-hit-test.html
1968         
1969         * rendering/RenderLayer.cpp:
1970         (WebCore::RenderLayer::hitTestLayer):
1971
1972 2009-03-04  Adam Langley  <agl@google.com>
1973
1974         Reviewed by Darin Fisher.
1975
1976         r41362 mistakenly added functions "RenderThemeWin::" into
1977         RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
1978         them to void return types. This patch switches them back to ints.
1979
1980         https://bugs.webkit.org/show_bug.cgi?id=24360
1981
1982         * rendering/RenderThemeChromiumLinux.cpp:
1983         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft):
1984         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight):
1985         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop):
1986         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):
1987
1988 2009-03-04  Adam Langley  <agl@google.com>
1989
1990         Reviewed by Darin Fisher.
1991
1992         Chromium Linux: change some metrics to better match Windows after
1993         r41416. Aesthetically this may be worse, but web-compat is king.
1994
1995         Also, the previous code had an off by one error when drawing
1996         scrollbars which caused the scrollbar to overflow it's bounds by 1px
1997         at the right and bottom edges.
1998
1999         https://bugs.webkit.org/show_bug.cgi?id=24369
2000
2001         * rendering/RenderThemeChromiumLinux.cpp:
2002         (WebCore::):
2003         (WebCore::RenderThemeChromiumLinux::systemFont):
2004         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
2005         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
2006
2007 2009-03-04  Eric Seidel  <eric@webkit.org>
2008
2009         Reviewed by Adam Roben.
2010
2011         Add an ASSERT to better demonstrate the cause of the crash in
2012         https://bugs.webkit.org/show_bug.cgi?id=23736
2013
2014         * loader/DocLoader.cpp:
2015         (WebCore::DocLoader::~DocLoader):
2016
2017 2009-03-04  David Levin  <levin@chromium.org>
2018
2019         Reviewed by Alexey Proskuryakov.
2020
2021         Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
2022         <https://bugs.webkit.org/show_bug.cgi?id=24337>
2023
2024         Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
2025                http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html
2026
2027         * loader/mac/ResourceLoaderMac.mm:
2028         (WebCore::ResourceLoader::willCacheResponse):
2029         An identifier is only asssigned if resource load callbacks are done.  So don't send
2030         willCacheResponse which uses identifier if resource load callbacks aren't being sent.
2031
2032 2009-03-04  David Levin  <levin@chromium.org>
2033
2034         Reviewed by Alexey Proskuryakov.
2035
2036         Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
2037         <https://bugs.webkit.org/show_bug.cgi?id=24330>
2038
2039         Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html
2040
2041         * dom/ExceptionCode.cpp:
2042         (WebCore::xmlHttpRequestExceptionNames):
2043         Added missing ABORT_ERR whose absence caused an assert.
2044
2045         * loader/WorkerThreadableLoader.cpp:
2046         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
2047         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
2048         Add more logic to handle the termination case for sync xhr.
2049
2050 2009-03-04  Eric Carlson  <eric.carlson@apple.com>
2051
2052         Reviewed by Antti Koivisto.
2053
2054         https://bugs.webkit.org/show_bug.cgi?id=24364
2055         Add support for HTMLMediaElement canPlayType method. Make
2056         MediaPlayer::supportsType take a ContentType instead of a
2057         separate mime type and codecs parameter.
2058
2059         Test: media/video-can-play-type.html
2060
2061         * dom/DOMImplementation.cpp:
2062         (WebCore::DOMImplementation::createDocument):
2063         * html/HTMLMediaElement.cpp:
2064         (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method.
2065         (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType.
2066         (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type.
2067         (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
2068         * html/HTMLMediaElement.h: Add prototype.
2069         * html/HTMLMediaElement.idl: Ditto.
2070         * platform/graphics/MediaPlayer.cpp:
2071         (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type.
2072         (WebCore::MediaPlayer::supportsType): Ditto.
2073         * platform/graphics/MediaPlayer.h:
2074
2075 2009-03-04  Antti Koivisto  <antti@apple.com>
2076
2077         Reviewed by Dave Hyatt.
2078
2079         https://bugs.webkit.org/show_bug.cgi?id=24359
2080         Repaint throttling mechanism
2081         
2082         Excessive repainting can slow down page loadind. This implements a timer
2083         based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not 
2084         enabled by default.
2085
2086         * loader/FrameLoader.cpp:
2087         (WebCore::FrameLoader::checkCompleted):
2088         * page/EventHandler.cpp:
2089         (WebCore::EventHandler::dispatchDragEvent):
2090         (WebCore::EventHandler::dispatchMouseEvent):
2091         (WebCore::EventHandler::keyEvent):
2092         (WebCore::EventHandler::handleTextInputEvent):
2093         * page/FrameView.cpp:
2094         (WebCore::FrameView::FrameView):
2095         (WebCore::FrameView::reset):
2096         (WebCore::FrameView::repaintContentRectangle):
2097         (WebCore::FrameView::beginDeferredRepaints):
2098         (WebCore::FrameView::endDeferredRepaints):
2099         (WebCore::FrameView::checkStopDelayingDeferredRepaints):
2100         (WebCore::FrameView::doDeferredRepaints):
2101         (WebCore::FrameView::updateDeferredRepaintDelay):
2102         (WebCore::FrameView::resetDeferredRepaintDelay):
2103         (WebCore::FrameView::adjustedDeferredRepaintDelay):
2104         (WebCore::FrameView::deferredRepaintTimerFired):
2105         (WebCore::FrameView::paintContents):
2106         * page/FrameView.h:
2107
2108 2009-03-04  Sam Weinig  <sam@webkit.org>
2109
2110         Rubber-stamped by Antti Koivisto.
2111
2112         Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.
2113
2114         * dom/Document.cpp:
2115         (WebCore::Document::Document):
2116         * dom/Document.h:
2117         (WebCore::Document::haveStylesheetsLoaded):
2118         * html/HTMLTokenizer.cpp:
2119         (WebCore::HTMLTokenizer::scriptHandler):
2120         * loader/Cache.cpp:
2121         (WebCore::Cache::requestResource):
2122         * loader/CachedCSSStyleSheet.cpp:
2123         (WebCore::CachedCSSStyleSheet::checkNotify):
2124         * loader/DocLoader.h:
2125         * loader/FrameLoader.cpp:
2126         (WebCore::FrameLoader::FrameLoader):
2127         (WebCore::FrameLoader::requestFrame):
2128         (WebCore::FrameLoader::stopLoading):
2129         (WebCore::FrameLoader::begin):
2130         (WebCore::FrameLoader::write):
2131         (WebCore::FrameLoader::endIfNotLoadingMainResource):
2132         (WebCore::FrameLoader::checkCompleted):
2133         (WebCore::FrameLoader::requestObject):
2134         (WebCore::FrameLoader::loadItem):
2135         * loader/FrameLoader.h:
2136
2137 2009-03-02  Xan Lopez  <xan@gnome.org>
2138
2139         Reviewed by Mark Rowe.
2140
2141         https://bugs.webkit.org/show_bug.cgi?id=24287
2142         [GTK] Move auth dialog feature to WebKit/
2143
2144         Remove WebKitSoupAuthDialog files from build and stop using it.
2145
2146         * GNUmakefile.am:
2147         * platform/network/soup/ResourceHandleSoup.cpp:
2148         (WebCore::ensureSessionIsInitialized):
2149         * platform/network/soup/webkit-soup-auth-dialog.c: Removed.
2150         * platform/network/soup/webkit-soup-auth-dialog.h: Removed.
2151
2152 2009-03-04  Simon Fraser  <simon.fraser@apple.com>
2153
2154         Reviewed by Dave Hyatt
2155         
2156         https://bugs.webkit.org/show_bug.cgi?id=24361
2157         
2158         Reinstate code that sets result.innerNode when hitTest() returns true,
2159         but never filled in the innerNode. Fixes hit testing of generated content.
2160
2161         Test: fast/css-generated-content/hit-test-generated-content.html
2162
2163         * rendering/RenderLayer.cpp:
2164         (WebCore::RenderLayer::hitTestContents):
2165
2166 2009-03-04  Adam Barth  <abath@webkit.org>
2167
2168         Reviewed by Alexey Proskuryakov.
2169
2170         https://bugs.webkit.org/show_bug.cgi?id=24356
2171
2172         Fix WebKit style for allowUniversalAccessFromFileURLs.
2173
2174         * WebCore.base.exp:
2175         * dom/Document.cpp:
2176         (WebCore::Document::initSecurityContext):
2177         * page/Settings.cpp:
2178         (WebCore::Settings::Settings):
2179         (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
2180         * page/Settings.h:
2181         (WebCore::Settings::allowUniversalAccessFromFileURLs):
2182
2183 2009-03-04  Brady Eidson  <beidson@apple.com>
2184
2185         Reviewed by Darin Adler
2186
2187         <rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.
2188
2189         I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
2190         consolidated some of the various decision making pieces of the Cache into the new method
2191         FrameLoader::cachePolicy().
2192
2193         Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader 
2194         is reloading.  If it is, we'd evict any existing resource then recreate it.  Quick looks uses the
2195         same URL for this image every time and expects it to be reloaded with each new card.
2196
2197         The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
2198         is "ReloadIgnoringCacheData".  This check was lost in the consolidation to the new method.  
2199
2200         * loader/FrameLoader.cpp:
2201         (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible
2202           condition for returning CachePolicyReload.
2203
2204 2009-03-04  Timothy Hatcher  <timothy@apple.com>
2205
2206         * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
2207         "LOCAL STORAGE" and "SESSION STORAGE".
2208
2209 2009-03-04  Timothy Hatcher  <timothy@apple.com>
2210
2211         Fix a regression where the Web Inspector console would not animate
2212         in or out correctly.
2213
2214         Reviewed by Anders Carlsson.
2215
2216         * inspector/front-end/inspector.css: Move a z-index to a child element
2217         to get the correct stacking order during the animation.
2218
2219 2009-03-03  David Hyatt  <hyatt@apple.com>
2220
2221         https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.
2222
2223         Make sure to factor clear deltas into y position estimates.  Also avoid doing the comparison of
2224         the final position against the y position estimate until after the clear has happened.  This gets rid
2225         of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.
2226
2227         Reviewed by Dan Bernstein
2228
2229         Added fast/block/float/nested-clearance.html
2230
2231         * rendering/RenderBlock.cpp:
2232         (WebCore::RenderBlock::collapseMargins):
2233         (WebCore::RenderBlock::clearFloatsIfNeeded):
2234         (WebCore::RenderBlock::estimateVerticalPosition):
2235         (WebCore::RenderBlock::layoutBlockChildren):
2236         (WebCore::RenderBlock::getClearDelta):
2237         * rendering/RenderBlock.h:
2238
2239 2009-03-02  Kim Grönholm  <kim.gronholm@nomovok.com>
2240
2241         Reviewed by Simon Hausmann.
2242
2243         Improvement to 3d transformations rendering in QtWebKit. QTransform is used
2244         instead of QMatrix. This allows perspective transformations since QTransform is
2245         a true 3x3 matrix.
2246
2247         * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere.
2248         (WebCore::GraphicsContext::getCTM):
2249         (WebCore::GraphicsContext::restorePlatformState):
2250         (WebCore::GraphicsContext::fillPath):
2251         (WebCore::GraphicsContext::strokePath):
2252         (WebCore::GraphicsContext::fillRect):
2253         (WebCore::GraphicsContext::translate):
2254         (WebCore::GraphicsContext::rotate):
2255         (WebCore::GraphicsContext::scale):
2256         (WebCore::GraphicsContext::concatCTM):
2257         * platform/graphics/qt/ImageQt.cpp:
2258         (WebCore::Image::drawPattern):
2259         * platform/graphics/qt/PathQt.cpp:
2260         (WebCore::Path::translate):
2261         (WebCore::Path::transform):
2262         * platform/graphics/qt/PatternQt.cpp:
2263         (WebCore::Pattern::createPlatformPattern):
2264         * platform/graphics/qt/TransformationMatrixQt.cpp:
2265         (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator
2266         to QMatrix with one to QTransform.
2267         * platform/graphics/transforms/TransformationMatrix.h:
2268         * platform/graphics/qt/FontQt.cpp:
2269
2270 2009-02-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2271
2272         Reviewed by Simon Hausmann.
2273
2274         https://bugs.webkit.org/show_bug.cgi?id=24151
2275         Fix Qt/S60 build break
2276
2277         * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds
2278         * platform/qt/FileSystemQt.cpp: Ditto
2279         (WebCore::unloadModule):
2280
2281 2009-03-03  Mike Belshe  <mike@belshe.com>
2282
2283         Reviewed by Alexey Proskuryakov.
2284
2285         https://bugs.webkit.org/show_bug.cgi?id=21939
2286         Uninitialized ExceptionCode in DOMWindow::postMessage
2287
2288         * dom/MessagePort.cpp:
2289         (WebCore::MessagePort::postMessage):
2290
2291 2009-03-03  David Kilzer  <ddkilzer@apple.com>
2292
2293         <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
2294
2295         Reviewed by Mark Rowe.
2296
2297         The fix is to add INSTALLHDRS_COPY_PHASE = YES and
2298         INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
2299         sure various build phase scripts work with the installhdrs build
2300         phase.
2301
2302         * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
2303         based on PLATFORM_NAME to work around the missing definition on
2304         Tiger.
2305         * Configurations/WebCore.xcconfig: Added
2306         JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
2307         the "Generate Derived Sources" script.  Added
2308         INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
2309
2310         * WebCore.xcodeproj/project.pbxproj:
2311         - Added shell code to prevent running "Check For Global
2312           Initializers", "Check For Exit Time Destructors" and "Check
2313           For Weak VTables" scripts during the installhdrs build phase.
2314         - Made "Generate Derived Sources" work for the installhdrs build
2315           phase.  Also simplified setting of CREATE_HASH_TABLE by using
2316           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
2317
2318 2009-03-02  Adam Langley  <agl@google.com>
2319
2320         Reviewed by Darin Fisher.
2321
2322         Chromium Linux: Switch to using Skia to render widgets.
2323
2324         In order to sandbox the Chromium renderer on Linux we need to remove
2325         the X connection. GTK cannot render without an X connection so, for
2326         now, we render widgets ourselves.
2327
2328         Previously didn't use anti-alias fonts in order to match Windows font
2329         rendering exactly. This was helpful when bootstrapping our layout
2330         tests. Now, however, we are ready to enable it.
2331
2332         https://bugs.webkit.org/show_bug.cgi?id=24244
2333
2334         * platform/chromium/ScrollbarThemeChromium.cpp:
2335         (WebCore::ScrollbarThemeChromium::buttonSize):
2336         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
2337         (WebCore::ScrollbarThemeChromium::scrollbarThickness):
2338         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
2339         (WebCore::ScrollbarThemeChromium::paintButton):
2340         (WebCore::ScrollbarThemeChromium::paintThumb):
2341         * platform/graphics/chromium/FontPlatformDataLinux.cpp:
2342         (WebCore::FontPlatformData::setupPaint):
2343         * platform/graphics/skia/PlatformContextSkia.cpp:
2344         (PlatformContextSkia::PlatformContextSkia):
2345         (PlatformContextSkia::~PlatformContextSkia):
2346         * platform/graphics/skia/PlatformContextSkia.h:
2347         * rendering/RenderThemeChromiumGtk.cpp: Removed.
2348         * rendering/RenderThemeChromiumGtk.h: Removed.
2349         * rendering/RenderThemeChromiumLinux.cpp: Added.
2350         * rendering/RenderThemeChromiumLinux.h: Added.
2351
2352 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
2353
2354         Reviewed by Darin Fisher.
2355
2356         https://bugs.webkit.org/show_bug.cgi?id=24261
2357         Fix return types.
2358
2359         Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
2360
2361         * bindings/v8/V8Binding.h:
2362         (WebCore::toInt32): change return type to int
2363         (WebCore::toFloat): change return type to float.
2364
2365 2009-03-03  Anders Carlsson  <andersca@apple.com>
2366
2367         Reviewed by John Sullivan.
2368
2369         https://bugs.webkit.org/show_bug.cgi?id=22884
2370         <rdar://problem/6449783>
2371         modified layout test crashes Safari
2372
2373         Null check NPStream before dereferencing it.
2374         
2375         * plugins/PluginView.cpp:
2376         (WebCore::PluginView::destroyStream):
2377
2378 2009-03-03  Eric Carlson  <eric.carlson@apple.com>
2379
2380         Reviewed by Simon Fraser.
2381
2382         Fix for <rdar://problem/6641045>
2383         Don't call QTKit to get movie properties until movie metadata has been loaded.
2384
2385         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
2386         (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
2387         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2388         (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
2389         (WebCore::MediaPlayerPrivate::play): Ditto.
2390         (WebCore::MediaPlayerPrivate::pause): Ditto.
2391         (WebCore::MediaPlayerPrivate::duration): Ditto.
2392         (WebCore::MediaPlayerPrivate::currentTime): Ditto.
2393         (WebCore::MediaPlayerPrivate::seek): Ditto.
2394         (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
2395         (WebCore::MediaPlayerPrivate::paused): Ditto.
2396         (WebCore::MediaPlayerPrivate::seeking): Ditto.
2397         (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
2398         (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
2399         (WebCore::MediaPlayerPrivate::setVolume): Ditto.
2400         (WebCore::MediaPlayerPrivate::setRate): Ditto.
2401         (WebCore::MediaPlayerPrivate::dataRate): Ditto.
2402         (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
2403         (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
2404
2405 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
2406
2407         - Spelling fix.
2408
2409         * page/Console.cpp:
2410         (WebCore::Console::profile):
2411
2412 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
2413
2414         Reviewed by Darin Fisher.
2415
2416         https://bugs.webkit.org/show_bug.cgi?id=23657
2417         Remove Database API callback IDLs from the project. 
2418         They were removed in r40633.
2419
2420         * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
2421
2422 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
2423
2424         Reviewed by Oliver Hunt.
2425
2426         <rdar://problem/6639110> console.profile() doesn't work without a title
2427
2428         * page/Console.cpp:
2429         (WebCore::Console::profile): If there is no title assume this is a user
2430         initiated profile and give it the next incremented title name.
2431
2432 2009-03-03  Timothy Hatcher  <timothy@apple.com>
2433
2434         Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
2435         the console code and refactored things to have fewer code paths and duplication.
2436
2437         rdar://problem/6367127
2438         https://bugs.webkit.org/show_bug.cgi?id=24329
2439
2440         Reviewed by Kevin McCullough.
2441
2442         Test: manual-tests/inspector/console-dir.html
2443
2444         * bindings/js/JSInspectedObjectWrapper.cpp:
2445         (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
2446         to fix an ASSERT about using a wrapper from the wrong ExecState.
2447         * bindings/js/JSQuarantinedObjectWrapper.cpp:
2448         (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
2449         (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
2450         * inspector/front-end/Console.js:
2451         (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
2452         When forceObjectFormat is true, the only formatter used is _formatobject.
2453         (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
2454         (WebInspector.Console.prototype._formatstring): Ditto.
2455         (WebInspector.Console.prototype._formatregexp): Ditto.
2456         (WebInspector.Console.prototype._formatarray): Ditto.
2457         (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
2458         (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
2459         (WebInspector.Console.prototype._formaterror): Remove the inline argument.
2460         (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
2461         simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
2462         (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
2463         (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
2464         (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
2465         (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
2466         * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
2467         * inspector/front-end/utilities.js:
2468         (Object.type): Return "node" for Node objects.
2469         (Object.describe): Handle the "node" type.
2470         * page/Console.cpp:
2471         (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
2472         (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
2473         * page/Console.h:
2474         (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
2475
2476 2009-03-03  Scott Violet  <sky@google.com>
2477
2478         Reviewed by Eric Seidel.
2479
2480         https://bugs.webkit.org/show_bug.cgi?id=24325
2481         Crash on replacing document contents during drop.
2482
2483         Makes sure a node is in the document during a move before using it.
2484
2485         Test: fast/events/crash-on-mutate-during-drop.html
2486
2487         * editing/MoveSelectionCommand.cpp:
2488         (WebCore::MoveSelectionCommand::doApply):
2489
2490 2009-03-03  Jungshik Shin <jshin@chromium.org>
2491
2492         Reviewed by Eric Seidel.
2493
2494         https://bugs.webkit.org/show_bug.cgi?id=23028
2495         Enable dynamic web font support to Chromium on Windows.
2496         Files that were omitted by mistake in the latest patch
2497         that was landed.
2498
2499         * loader/CachedFont.cpp:
2500         (WebCore::CachedFont::~CachedFont):
2501         (WebCore::CachedFont::ensureCustomFontData):
2502         (WebCore::CachedFont::platformDataFromCustomData):
2503         (WebCore::CachedFont::allClientsRemoved):
2504         * platform/graphics/chromium/FontCustomPlatformData.cpp:
2505         (WebCore::EOTStream::EOTStream):
2506         (WebCore::createFontCustomPlatformData):
2507         * platform/graphics/win/FontCustomPlatformData.cpp:
2508         (WebCore::EOTStream::EOTStream):
2509         (WebCore::createFontCustomPlatformData):
2510
2511 2009-03-03  Gustavo Noronha Silva  <gns@gnome.org>
2512
2513         Reviewed by Alexey Proskuryakov.
2514
2515         https://bugs.webkit.org/show_bug.cgi?id=16826
2516         [Gtk] Implement WebKitDownload
2517
2518         Make the Soup backend able to handle requests without a frame,
2519         since we may have such things now that we support downloads.
2520
2521         * platform/network/ResourceHandleInternal.h:
2522         * platform/network/soup/ResourceHandleSoup.cpp:
2523         (WebCore::ResourceHandle::start):
2524
2525 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
2526
2527         Reviewed by Eric Seidel.
2528
2529         https://bugs.webkit.org/show_bug.cgi?id=24331
2530         Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
2531
2532         * bindings/v8/custom/V8AttrCustom.cpp: Added.
2533         * bindings/v8/custom/V8CustomBinding.cpp: Added.
2534         * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
2535         * bindings/v8/custom/V8ElementCustom.cpp: Added.
2536         * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
2537         * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
2538
2539 2009-03-03  Brady Eidson  <beidson@apple.com>
2540
2541         Reviewed by Darin Adler
2542
2543         <rdar://problem/6616664> - Quick looks of various file types is broken
2544
2545         In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
2546         for non-HTTP loads when the underlying ResourceRequest changed.  Unfortunately it was a little
2547         overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
2548
2549         Partially reverted behavior to always set the mainDocumentURL in situations when we would've
2550         before that patch.
2551
2552         * loader/FrameLoader.cpp:
2553         (WebCore::FrameLoader::addExtraFieldsToRequest):
2554
2555         * platform/network/ResourceRequestBase.cpp:
2556         (WebCore::ResourceRequestBase::setMainDocumentURL):
2557
2558 2009-03-03  Chris Marrin  <cmarrin@apple.com>
2559
2560         Reviewed by Simon Fraser.
2561
2562         https://bugs.webkit.org/show_bug.cgi?id=24256
2563
2564         Added a WebCoreForceSoftwareAnimation flag.
2565
2566         * platform/graphics/mac/GraphicsLayerCA.mm:
2567         (WebCore::forceSoftwareAnimation):
2568         (WebCore::GraphicsLayerCA::setOpacity):
2569         (WebCore::GraphicsLayerCA::animateTransform):
2570         (WebCore::GraphicsLayerCA::animateFloat):
2571
2572 2009-03-02  Chris Marrin  <cmarrin@apple.com>
2573
2574         Reviewed by Sam Weinig.
2575
2576         https://bugs.webkit.org/show_bug.cgi?id=24257
2577
2578         Added prototype properties for several classes with constructors that
2579         were missing them, including the one mentioned in the bug.
2580
2581         Test: fast/dom/Window/custom-constructors.html
2582
2583         * bindings/js/JSAudioConstructor.cpp:
2584         (WebCore::JSAudioConstructor::JSAudioConstructor):
2585         * bindings/js/JSDOMWindowBase.cpp:
2586         (jsDOMWindowBaseWebKitCSSMatrix):
2587         * bindings/js/JSImageConstructor.cpp:
2588         (WebCore::JSImageConstructor::JSImageConstructor):
2589         * bindings/js/JSOptionConstructor.cpp:
2590         (WebCore::JSOptionConstructor::JSOptionConstructor):
2591         * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
2592         (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
2593         * bindings/js/JSWebKitCSSMatrixConstructor.h:
2594         * bindings/js/JSWebKitPointConstructor.cpp:
2595         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
2596         * bindings/js/JSWorkerConstructor.cpp:
2597         (WebCore::JSWorkerConstructor::JSWorkerConstructor):
2598
2599 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
2600
2601         Reviewed by Darin Fisher.
2602
2603         https://bugs.webkit.org/show_bug.cgi?id=24321
2604         Add V8 bindings headers.
2605
2606         * bindings/v8/V8Binding.h: Added.
2607         * bindings/v8/V8Proxy.h: Added.
2608         * bindings/v8/custom/V8CustomBinding.h: Added.
2609         * bindings/v8/custom/V8CustomEventListener.h: Added.
2610
2611 2009-03-03  Jungshik Shin <jshin@chromium.org>
2612
2613         Reviewed by Eric Seidel.
2614
2615         https://bugs.webkit.org/show_bug.cgi?id=23803
2616         Fix an 'off-by-1' error in ChromiumWin's font fallback.
2617
2618         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
2619         (WebCore::FontCache::getFontDataForCharacters):
2620
2621 2009-03-03  Jungshik Shin  <jshin@chromium.org>
2622
2623         Reviewed by Eric Seidel.
2624
2625         http://bugs.webkit.org/show_bug.cgi?id=23028
2626         Enable dynamic web font support to Chromium on Windows: Part 1
2627         - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
2628           from platform/graphics/win because both Windows port and Chromium Windows
2629           port will use them.
2630         - Adjust WebCore.vcproj accordingly.
2631
2632         * WebCore.vcproj/WebCore.vcproj:
2633         * platform/graphics/opentype: Added.
2634         * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
2635         * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
2636         * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
2637         * platform/graphics/win/OpenTypeUtilities.h: Removed.
2638
2639 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
2640
2641         Reviewed by Dave Hyatt
2642
2643         https://bugs.webkit.org/show_bug.cgi?id=24312
2644         
2645         Take 3D transforms into account when hit testing:
2646         
2647         1. Maintain a bit on each RenderLayer that is set when the layer
2648            has 3d descendants, so that we know when to fall into the slow
2649            hit testing path.
2650            
2651         2. Make a ref-counted HitTestingTransformState, which is used to store
2652            an accumulated transform, and the hit test point, and hitTestRect
2653            in the plane of the ancestor non-3d ('flattening') layer.
2654            
2655            It's ref-counted so we can heap allocate it (to avoid stack bloat),
2656            and avoid copying when hitTestLayer calls itself after applying the transform.
2657            
2658         3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
2659            3D transforms, or to do deep depth-testing when traversing a preserves-3d
2660            hierarchy. When hit, layers compute a z-offset from the ancestor flattening
2661            layer, which allows for correct depth testing.
2662            
2663            The existing early-return codepath is unaffected when there are no 3d transforms
2664            and no preserve-3d.
2665
2666         * rendering/RenderLayer.cpp:
2667         (WebCore::RenderLayer::RenderLayer):
2668         (WebCore::RenderLayer::updateTransform):
2669         (WebCore::RenderLayer::dirty3DTransformedDescendantStatus):
2670         (WebCore::RenderLayer::update3DTransformedDescendantStatus):
2671         (WebCore::RenderLayer::hitTest):
2672         (WebCore::computeZOffset):
2673         (WebCore::RenderLayer::createLocalTransformState):
2674         (WebCore::RenderLayer::hitTestLayer):
2675         (WebCore::RenderLayer::hitTestContents):
2676         * rendering/RenderLayer.h:
2677         (WebCore::RenderLayer::preserves3D):
2678         (WebCore::RenderLayer::has3DTransform):
2679         (WebCore::RenderLayer::setHas3DTransformedDescendant):
2680         (WebCore::RenderLayer::has3DTransformedDescendant):
2681         * rendering/RenderLayerBacking.cpp:
2682         * rendering/TransformState.cpp:
2683         (WebCore::TransformState::flatten):
2684         (WebCore::TransformState::mappedPoint):
2685         (WebCore::HitTestingTransformState::move):
2686         (WebCore::HitTestingTransformState::applyTransform):
2687         (WebCore::HitTestingTransformState::flatten):
2688         (WebCore::HitTestingTransformState::mappedPoint):
2689         (WebCore::HitTestingTransformState::mappedQuad):
2690         * rendering/TransformState.h:
2691         (WebCore::TransformState::TransformState):
2692         (WebCore::HitTestingTransformState::create):
2693         (WebCore::HitTestingTransformState::move):
2694         (WebCore::HitTestingTransformState::HitTestingTransformState):
2695
2696 2009-03-03  Brett Wilson  <brettw@chromium.org>
2697
2698         Fix uninitialized memory reads in the Chromium Windows transparency
2699         code that were identified by Purify,
2700
2701         Reviewed by Darin Fisher.
2702
2703         * platform/graphics/chromium/TransparencyWin.cpp:
2704         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
2705         (WebCore::TransparencyWin::initializeNewContext):
2706
2707 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
2708
2709         Reviewed by Dave Hyatt
2710
2711         https://bugs.webkit.org/show_bug.cgi?id=24312
2712         
2713         Factor the code that compute a transform relative to the container
2714         into RenderObject::transformFromContainer().
2715         
2716         * rendering/RenderBox.cpp:
2717         (WebCore::RenderBox::mapLocalToAbsolutePoint):
2718         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
2719         * rendering/RenderObject.cpp:
2720         (WebCore::RenderObject::transformFromContainer):
2721         * rendering/RenderObject.h:
2722
2723 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
2724
2725         Reviewed by Dave Hyatt
2726
2727         https://bugs.webkit.org/show_bug.cgi?id=24317
2728         
2729         Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
2730         the superclass found a node, otherwise we set the innerNode of the
2731         HitTestResult, but don't actually report that we found a hit.
2732
2733         * rendering/RenderTextControlMultiLine.cpp:
2734         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2735
2736 2009-03-03  Onne Gorter  <onne.gorter@avinity.net>
2737
2738         Reviewed by Anders Carlsson.
2739
2740         https://bugs.webkit.org/show_bug.cgi?id=23707
2741         resizing plugins does not work, because the plugin never gets informed
2742
2743         Make gtk plugins resize correctly, by sending them the setwindow event
2744         correctly. Also ensure that all plugin eventing is done with correct
2745         locking/calling. Mostly copied from mac implementation.
2746
2747         manual test: manual-tests/gtk/plugin-resize-scroll.html
2748
2749         * plugins/PluginView.h:
2750         * plugins/gtk/PluginViewGtk.cpp:
2751         (WebCore::PluginView::dispatchNPEvent):
2752         ensure locking/calling for NPEvents
2753         (WebCore::PluginView::updatePluginWidget):
2754         if something changed, let setNPWindowIfNeeded handle it
2755         (WebCore::PluginView::paint):
2756         (WebCore::PluginView::handleKeyboardEvent):
2757         (WebCore::PluginView::handleMouseEvent):
2758         ensure calling conventions
2759         (WebCore::PluginView::setNPWindowRect):
2760         just pass control to setNPWindowIfNeeded
2761         (WebCore::PluginView::setNPWindowIfNeeded):
2762         event the plugin correctly of new window
2763         (WebCore::PluginView::init):
2764         init through the new setup
2765
2766 2009-03-03  Mike Belshe  <mike@belshe.com>
2767
2768         Reviewed by Darin Fisher.
2769
2770         https://bugs.webkit.org/show_bug.cgi?id=24311
2771         Make IDL returning DOMObject use [V8Custom]
2772
2773         * dom/Document.idl:
2774         * html/HTMLCanvasElement.idl:
2775
2776 2009-03-02  Simon Fraser  <simon.fraser@apple.com>
2777
2778         Reviewed by Adele Peterson
2779
2780         https://bugs.webkit.org/show_bug.cgi?id=24313
2781         
2782         If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
2783         HitTestResult, then it had better well return |true|. And m_innerBlock
2784         could never have been set as the hit node by the superclass, because
2785         the superclass knows nothing about m_innerBlock.
2786         
2787         Test: fast/forms/input-hit-test-border.html
2788
2789         * rendering/RenderTextControlSingleLine.cpp:
2790         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
2791
2792 2009-03-02  Sam Weinig  <sam@webkit.org>
2793
2794         Reviewed by Mark Rowe.
2795
2796         Enable Geolocation (except on Tiger and Leopard).
2797
2798         * Configurations/WebCore.xcconfig:
2799
2800 2009-03-02  Ojan Vafai  <ojan@chromium.org>
2801
2802         Reviewed by Adele Peterson.
2803
2804         Fix https://bugs.webkit.org/show_bug.cgi?id=24307
2805         Null out m_highlightedNode on hideHighlight().
2806         Ran WebCore/manual-tests/inspector/highlight-nodes.html.
2807
2808         * inspector/InspectorController.cpp:
2809         (WebCore::InspectorController::hideHighlight):
2810
2811 2009-03-02  Sam Weinig  <sam@webkit.org>
2812
2813         Reviewed by Geoffrey Garen.
2814
2815         Fix for <rdar://problem/6507404> Add Geolocation support.
2816
2817         This is not yet turned on for any Mac platform.
2818
2819         * WebCore.xcodeproj/project.pbxproj:
2820         * page/Chrome.cpp:
2821         (WebCore::Chrome::shouldAllowGeolocationForFrame):
2822         * page/Chrome.h:
2823         * page/ChromeClient.h:
2824         (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
2825         * page/Geolocation.cpp:
2826         (WebCore::Geolocation::Geolocation):
2827         (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
2828         will not be alive at this point.
2829         (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
2830         return a PERMISSION_DENIED if not.
2831         (WebCore::Geolocation::watchPosition): Ditto.
2832         (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
2833         to allow geolocation and cache the result. 
2834         * page/Geolocation.h:
2835         (WebCore::Geolocation::):
2836         * platform/GeolocationService.cpp:
2837         * platform/GeolocationService.h:
2838         (WebCore::GeolocationService::~GeolocationService):
2839         (WebCore::GeolocationService::stopUpdating):
2840         * platform/mac/GeolocationServiceMac.h: Added.
2841         (WebCore::GeolocationServiceMac::lastPosition):
2842         (WebCore::GeolocationServiceMac::lastError):
2843         * platform/mac/GeolocationServiceMac.mm: Added.
2844         (WebCore::GeolocationService::create):
2845         (WebCore::GeolocationServiceMac::GeolocationServiceMac):
2846         (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
2847         (WebCore::GeolocationServiceMac::startUpdating):
2848         (WebCore::GeolocationServiceMac::stopUpdating):
2849         (WebCore::GeolocationServiceMac::suspend):
2850         (WebCore::GeolocationServiceMac::resume):
2851         (WebCore::GeolocationServiceMac::positionChanged):
2852         (WebCore::GeolocationServiceMac::errorOccurred):
2853         (-[WebCoreCoreLocationObserver initWithCallback:]):
2854         (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
2855         (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
2856
2857 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
2858
2859         Build fixes for wxWidgets Mac trunk build.
2860
2861         * platform/wx/wxcode/mac/carbon/fontprops.cpp:
2862         (wxFontProperties::wxFontProperties):
2863         (GetTextExtent):
2864         * webcore-wx.bkl:
2865
2866 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
2867
2868         wxGTK missing header build fix.
2869
2870         * platform/wx/wxcode/gtk/fontprops.cpp:
2871
2872 2009-03-02  Dan Bernstein  <mitz@apple.com>
2873
2874         Reviewed by Adam Roben.
2875
2876         - fix https://bugs.webkit.org/show_bug.cgi?id=21811
2877           REGRESSION: Windows Build Not Selecting Proper Font
2878
2879         * platform/graphics/win/FontCacheWin.cpp:
2880         (WebCore::createGDIFont): Added back code to verify that the created
2881         HFONT has the requested face name.
2882
2883 2009-03-02  Timothy Hatcher  <timothy@apple.com>
2884
2885         Fixes a regression caused by splitting the input and output of console commands.
2886
2887         https://bugs.webkit.org/show_bug.cgi?id=24293
2888
2889         Reviewed by Kevin McCullough.
2890
2891         * inspector/front-end/Console.js:
2892         (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
2893         normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
2894
2895 2009-03-02  Timothy Hatcher  <timothy@apple.com>
2896
2897         Make exception messages and logged Error objects display consistently.
2898
2899         https://bugs.webkit.org/show_bug.cgi?id=18983
2900
2901         Reviewed by Adam Roben.
2902
2903         * English.lproj/localizedStrings.js: Remove a string for line numbers.
2904         * inspector/front-end/Console.js:
2905         (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
2906         boolean to the ConsoleCommandResult constructor and don't pass level.
2907         (WebInspector.Console.prototype._formatnode): Fix a className typo.
2908         (WebInspector.Console.prototype._formaterror): Add an error-message
2909         classed span around the message to show in red and remove the
2910         console-message-url class from the link so it doesn't float right.
2911         Instead enclose the link in parentheses and use displayNameForURL
2912         to shorten the URL in the link.
2913         (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
2914         how line numbers are shown since link underlining a string with
2915         parentheses looks bad.
2916         (WebInspector.ConsoleCommandResult): Take an exception boolean flag
2917         instead of a level and get line and URL based on that flag.
2918         * inspector/front-end/inspector.css: Tweaks to the styles.
2919
2920 2009-03-02  Ojan Vafai  <ojan@chromium.org>
2921
2922         Reviewed by Adele Peterson.
2923
2924         Bug 24048: extra windows button padding doesn't apply when there's no appearance
2925         <https://bugs.webkit.org/show_bug.cgi?id=24048>
2926
2927         Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
2928
2929         No tests added as existing tests already cover this behavior.
2930
2931         * rendering/RenderButton.cpp:
2932         (WebCore::RenderButton::setupInnerStyle):
2933         * rendering/RenderTheme.cpp:
2934         * rendering/RenderTheme.h:
2935         (WebCore::RenderTheme::buttonInternalPaddingLeft):
2936         (WebCore::RenderTheme::buttonInternalPaddingRight):
2937         (WebCore::RenderTheme::buttonInternalPaddingTop):
2938         * rendering/RenderThemeChromiumGtk.cpp:
2939         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
2940         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
2941         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
2942         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
2943         * rendering/RenderThemeChromiumGtk.h:
2944         * rendering/RenderThemeChromiumWin.cpp:
2945         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
2946         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
2947         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
2948         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
2949         * rendering/RenderThemeChromiumWin.h:
2950         * rendering/RenderThemeWin.cpp:
2951         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
2952         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
2953         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
2954         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
2955         * rendering/RenderThemeWin.h:
2956
2957 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
2958
2959         Build fix for Qt port.  Remove unnecessary assert.
2960
2961         * platform/graphics/qt/ImageBufferQt.cpp:
2962         (WebCore::ImageBuffer::putImageData):
2963
2964 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
2965
2966         Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
2967
2968         https://bugs.webkit.org/show_bug.cgi?id=24227
2969         Ensure that the checkForSolidColor() optimization is correctly triggered
2970         for all cases of drawPattern.  Currently, the optimization was not triggered
2971         when the check had not been previously performed via a request for the
2972         image's NativeImagePtr.
2973
2974         Implement the Qt version of the checkForSolidColor() method.  Combined with
2975         the bug fix this reduces the time it takes to draw a repeating background
2976         of a 1x1 image from ~50msecs to ~0msecs on my machine.
2977
2978         * platform/graphics/BitmapImage.cpp:
2979         (WebCore::BitmapImage::BitmapImage):
2980         * platform/graphics/BitmapImage.h:
2981         (WebCore::BitmapImage::mayFillWithSolidColor):
2982         * platform/graphics/Image.h:
2983         (WebCore::Image::mayFillWithSolidColor):
2984         * platform/graphics/cairo/ImageCairo.cpp:
2985         (WebCore::BitmapImage::BitmapImage):
2986         (WebCore::BitmapImage::checkForSolidColor):
2987         * platform/graphics/cg/ImageCG.cpp:
2988         (WebCore::BitmapImage::BitmapImage):
2989         (WebCore::BitmapImage::checkForSolidColor):
2990         * platform/graphics/qt/ImageQt.cpp:
2991         (WebCore::BitmapImage::checkForSolidColor):
2992         * platform/graphics/skia/ImageSkia.cpp:
2993         (WebCore::BitmapImage::checkForSolidColor):
2994         * platform/graphics/wx/ImageWx.cpp:
2995         (WebCore::BitmapImage::checkForSolidColor):
2996
2997 2009-03-02  Gustavo Noronha Silva  <gns@gnome.org>
2998
2999         Unreviewed build fix; adding missing files to EXTRA_DIST, so that
3000         they show up in the tarball.
3001
3002         * GNUmakefile.am:
3003
3004 2009-03-02  Dirk Schulze  <krit@webkit.org>
3005
3006         Reviewed by Holger Freyther.
3007
3008         Added putImageData to Qt. Discussed with Ariya Hidayat.
3009
3010         [Qt] lacks putImageData support in Canvas
3011         https://bugs.webkit.org/show_bug.cgi?id=22186
3012
3013         * platform/graphics/qt/ImageBufferQt.cpp:
3014         (WebCore::ImageBuffer::putImageData):
3015
3016 2009-03-02  Timothy Hatcher  <timothy@apple.com>
3017
3018         Show exception messages again when evaluating bad expressions in the
3019         Web Inspector's console.
3020
3021         https://bugs.webkit.org/show_bug.cgi?id=19890
3022
3023         Reviewed by Oliver Hunt.
3024
3025         * bindings/js/JSQuarantinedObjectWrapper.cpp:
3026         (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
3027         Fix the order in which the exception is set and cleared now that the
3028         exception is stored in the shared GlobalData, not per ExecState.
3029
3030 2009-02-28  Timothy Hatcher  <timothy@apple.com>
3031
3032         Make input in the Web Inspector console print before any output
3033         that might be added by the called function.
3034
3035         https://bugs.webkit.org/show_bug.cgi?id=19931
3036
3037         Reviewed by Oliver Hunt.
3038
3039         * inspector/front-end/Console.js:
3040         (WebInspector.Console.prototype._enterKeyPressed): Add the command
3041         message before evaluating the result. Associate the originating
3042         command to the result, so if they are adjacent there is no divider.
3043         (WebInspector.ConsoleCommand): No longer take a result.
3044         (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
3045         code removed since it isn't used now.
3046         (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
3047         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
3048         Call the ConsoleMessage toMessageElement and add a style class.
3049         * inspector/front-end/inspector.css: Add a new style class for
3050         adjacent results to hide the divider. Also tweak the position of
3051         the disclosure triangle for objects to not use the left margin.
3052
3053 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
3054
3055         Reviewed by Oliver Hunt.
3056
3057         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
3058         <https://bugs.webkit.org/show_bug.cgi?id=24282>
3059
3060         When fetching an array of elements with a range, attachment views need to be returned
3061         instead of the actual attachment.
3062
3063         * page/mac/AccessibilityObjectWrapper.mm:
3064         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
3065         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
3066
3067 2009-03-01  Ojan Vafai  <ojan@chromium.org>
3068
3069         Reviewed by Eric Seidel.
3070
3071         Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
3072         <https://bugs.webkit.org/show_bug.cgi?id=24251>
3073         
3074         Make RenderObject::positionForCoordinate non-virtual and
3075         RenderObject::positionForPoint virtual in preparation for
3076         removing positionFor* from RenderObject/RenderText.
3077
3078         * page/Frame.cpp:
3079         (WebCore::Frame::visiblePositionForPoint):
3080         * rendering/RenderBR.cpp:
3081         (WebCore::RenderBR::positionForPoint):
3082         * rendering/RenderBR.h:
3083         * rendering/RenderBlock.cpp:
3084         (WebCore::RenderBlock::positionForPoint):
3085         * rendering/RenderBlock.h:
3086         * rendering/RenderBox.cpp:
3087         (WebCore::RenderBox::positionForPoint):
3088         * rendering/RenderBox.h:
3089         * rendering/RenderInline.cpp:
3090         (WebCore::RenderInline::positionForPoint):
3091         * rendering/RenderInline.h:
3092         * rendering/RenderObject.cpp:
3093         (WebCore::RenderObject::positionForCoordinates):
3094         (WebCore::RenderObject::positionForPoint):
3095         * rendering/RenderObject.h:
3096         * rendering/RenderReplaced.cpp:
3097         (WebCore::RenderReplaced::positionForPoint):
3098         * rendering/RenderReplaced.h:
3099         * rendering/RenderSVGInlineText.cpp:
3100         (WebCore::RenderSVGInlineText::positionForPoint):
3101         * rendering/RenderSVGInlineText.h:
3102         * rendering/RenderText.cpp:
3103         (WebCore::RenderText::positionForPoint):
3104         * rendering/RenderText.h:
3105
3106 2009-03-01  Larry Ewing  <lewing@novell.com>
3107
3108         Reviewed by Alexey Proskuryakov.
3109
3110         https://bugs.webkit.org/show_bug.cgi?id=24080
3111         NPN_GetValue casting to the wrong type and writing outside bounds
3112
3113         Make sure to cast the value to the correct type so that only
3114         memory owned by the value is written to.
3115
3116         * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic): 
3117         * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
3118         * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): 
3119         (PluginView::getValue):
3120
3121 2009-03-01  Jeremy Moskovich  <jeremy@chromium.org>
3122
3123         Reviewed by Simon Fraser.
3124
3125         https://bugs.webkit.org/show_bug.cgi?id=24197 and
3126         https://bugs.webkit.org/show_bug.cgi?id=23512
3127
3128         The Windows version of cgColor() is conditionally compiled using
3129         !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
3130         can use the OS X version instead of the Windows version.
3131
3132         Also rename cgColor() -> createCGColor()
3133
3134         No observable change in behavior, so no test.
3135
3136         * platform/graphics/Color.h:
3137         * platform/graphics/cg/ColorCG.cpp:
3138         (WebCore::createCGColor):
3139         * platform/graphics/cg/GraphicsContextCG.cpp:
3140         (WebCore::GraphicsContext::setPlatformShadow):
3141         * platform/graphics/mac/ColorMac.mm:
3142         (WebCore::createCGColor):
3143         * platform/graphics/mac/GraphicsContextMac.mm:
3144         (WebCore::GraphicsContext::drawFocusRing):
3145         * platform/graphics/mac/GraphicsLayerCA.mm:
3146         (WebCore::setLayerBorderColor):
3147         (WebCore::setLayerBackgroundColor):
3148         (WebCore::GraphicsLayerCA::setBackgroundColor):
3149         * platform/graphics/win/GraphicsContextCGWin.cpp:
3150         (WebCore::GraphicsContext::drawFocusRing):
3151         * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
3152         (WebCore::ciColor):
3153
3154 2009-03-01  David Levin  <levin@chromium.org>
3155
3156         Reviewed by Alexey Proskuryakov.
3157
3158         Bug 24271: XMLHttpRequest needs js bindings for Workers.
3159         <https://bugs.webkit.org/show_bug.cgi?id=24271>
3160
3161         Tests: http/tests/xmlhttprequest/workers/methods-async.html
3162                http/tests/xmlhttprequest/workers/methods.html
3163
3164         * bindings/js/JSWorkerContextBase.cpp:
3165         (WebCore::JSWorkerContextBase::getOwnPropertySlot):
3166         (jsWorkerContextBaseXMLHttpRequest):
3167         (setJSWorkerContextBaseXMLHttpRequest):
3168         Expose XMLHttpRequest to Workers.
3169
3170         * bindings/js/JSWorkerContextBase.h:
3171
3172         * bindings/js/JSXMLHttpRequestConstructor.cpp:
3173         (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
3174         (WebCore::constructXMLHttpRequest):
3175         (WebCore::JSXMLHttpRequestConstructor::mark):
3176         Removed the dependencies on Document.
3177
3178         * bindings/js/JSXMLHttpRequestConstructor.h:
3179         (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
3180         * dom/EventException.idl:
3181         * dom/EventListener.idl:
3182         Change to have the NoStaticTables attribute since they are used from XHR.
3183
3184         * loader/WorkerThreadableLoader.cpp:
3185         (WebCore::workerContextDidFinishLoading):
3186         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
3187         Fixed identifier to be unsigned long.
3188
3189         * loader/WorkerThreadableLoader.h:
3190         * workers/WorkerThread.cpp:
3191         (WebCore::WorkerThread::workerThread):
3192         Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
3193
3194         * xml/XMLHttpRequestUpload.cpp:
3195
3196         * xml/XMLHttpRequest.idl:
3197         * xml/XMLHttpRequestException.idl:
3198         * xml/XMLHttpRequestProgressEvent.idl:
3199         * xml/XMLHttpRequestUpload.idl:
3200         Change to have the NoStaticTables attribute since they are used from XHR.
3201
3202 2009-03-01  Horia Olaru  <olaru@adobe.com>
3203
3204         Adding manual debugger test cases for bug.
3205
3206         https://bugs.webkit.org/show_bug.cgi?id=21073
3207
3208         Reviewed by Kevin McCullough.
3209
3210         * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
3211         * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
3212         * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
3213         * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
3214         * manual-tests/inspector/resources/loop-statements.js: Added.
3215
3216 2009-03-01  Dan Bernstein  <mitz@apple.com>
3217
3218         Reviewed by Darin Adler.
3219
3220         - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
3221
3222         Test: fast/events/scroll-during-zoom-change.html
3223
3224         * dom/Document.cpp:
3225         (WebCore::Document::recalcStyle): Pause scheduled events during style
3226         reclaculation. Changes to the zoom property result in scroll events
3227         being generated during style recalc, and those events need to be
3228         deferred until the render tree is consistent.
3229         * page/FrameView.cpp:
3230         (WebCore::FrameView::layout): Changed to account for a case in which the
3231         post-layout tasks trigger a nested layout, which reactivates the
3232         post-layout task timer.
3233
3234 2009-03-01  Ross Boucher  <rboucher@gmail.com>
3235
3236         Alphabetically sort scripts in the Script's panel file popup menu.
3237
3238         https://bugs.webkit.org/show_bug.cgi?id=23395
3239
3240         Reviewed by Timothy Hatcher.
3241
3242         * inspector/front-end/ScriptsPanel.js:
3243         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
3244         * inspector/front-end/utilities.js:
3245         (insertionIndexForObjectInListSortedByFunction):
3246         (indexOfObjectInListSortedByFunction):
3247
3248 2009-03-01  Yael Aharon  <yael.aharon@nokia.com>
3249
3250         Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
3251         when creating databases, localStorage or sessionStorage. Changing document.domain
3252         should have no affect on databases, localStorage and sessionStorage in Web Inspector.
3253
3254         https://bugs.webkit.org/show_bug.cgi?id=23844
3255
3256         Reviewed by Timothy Hatcher.
3257
3258         * inspector/InspectorController.cpp:
3259         (WebCore::InspectorController::addDOMStorageScriptResource):
3260         (WebCore::InspectorController::didUseDOMStorage):
3261         * storage/Database.cpp:
3262         (WebCore::Database::openDatabase):
3263
3264 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
3265
3266         Reviewed by Holger Freyther.
3267
3268         Avoid leaking errors when reporting GIO errors.
3269
3270         * platform/network/soup/ResourceHandleSoup.cpp:
3271         (WebCore::readCallback):
3272         (WebCore::openCallback):
3273         (WebCore::queryInfoCallback):
3274
3275 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
3276
3277         Reviewed by Holger Freyther.
3278
3279         Fixes crash when the GIO backend is given the URI for a directory.
3280
3281         * platform/network/soup/ResourceHandleSoup.cpp:
3282         (WebCore::networkErrorForFile):
3283
3284 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
3285
3286         Reviewed by Darin Fisher.
3287
3288         https://bugs.webkit.org/show_bug.cgi?id=24261
3289         Fix V8 custom binding scrubbing error.
3290
3291         Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
3292         Test: traversal/exception-forwarding.html
3293         TesT: traversal/stay-within-root.html
3294
3295         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
3296         * bindings/v8/custom/V8NodeIteratorCustom.cpp:
3297         (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
3298         * bindings/v8/custom/V8TreeWalkerCustom.cpp:
3299         (WebCore::toV8): Ditto.
3300
3301 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
3302
3303         Reviewed by Darin Fisher.
3304
3305         https://bugs.webkit.org/show_bug.cgi?id=24261
3306         Fix V8 custom binding scrubbing error.
3307
3308         Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
3309
3310         * WebCore.xcodeproj/project.pbxproj:
3311         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
3312         (WebCore::cssPropertyName):  Remove dubious checks, left over from
3313             incomplete conversion of parameter from pointer to pass-by-ref.
3314         (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
3315         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
3316
3317 2009-02-28  Xan Lopez  <xan@gnome.org>
3318
3319         Reviewed by Holger Freyther.
3320
3321         https://bugs.webkit.org/show_bug.cgi?id=24263
3322         [GTK] ref ResourceHandle until we are finished with it
3323
3324         Add a ref to the ResourceHandle in startHttp so we can keep it
3325         alive untill all callbacks have been executed, and unref it when
3326         soup tells us it's done with the SoupMessage (in
3327         finishedCallback). Fixes a number of crashes when calling
3328         didReceiveData whould crash because of the handle dying.
3329
3330         * platform/network/soup/ResourceHandleSoup.cpp:
3331         (WebCore::finishedCallback):
3332         (WebCore::ResourceHandle::startHttp):
3333
3334 2009-02-28  Adam Bergkvist <adam.bergkvist@ericsson.com>
3335
3336         Reviewed by Alexey Proskuryakov.
3337
3338         https://bugs.webkit.org/show_bug.cgi?id=24226
3339         [SOUP] HTTP status text is never set
3340
3341         Set HTTP status text to SoupMessage reason_phrase.
3342
3343         * platform/network/soup/ResourceHandleSoup.cpp:
3344         (WebCore::fillResponseFromMessage):
3345
3346 2009-02-28  Dan Bernstein  <mitz@apple.com>
3347
3348         - fix malformed project file
3349
3350         * WebCore.xcodeproj/project.pbxproj:
3351
3352 2009-02-28  Dan Bernstein  <mitz@apple.com>
3353
3354         Reviewed by Oliver Hunt.
3355
3356         - fix https://bugs.webkit.org/show_bug.cgi?id=23848
3357           <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
3358
3359         Test: fast/layers/inline-dirty-z-order-lists.html
3360
3361         * rendering/RenderBox.cpp:
3362         (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
3363         layer's and its stacking context's z-order lists when the layer's
3364         z-index or visibility change from here...
3365         * rendering/RenderBoxModelObject.cpp:
3366         (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
3367         it will apply to RenderInline too.
3368
3369 2009-02-27  Alexey Proskuryakov  <ap@webkit.org>
3370
3371         Reviewed by David Hyatt.
3372
3373         Don't include TextResourceDecoder.h in Document.h
3374
3375         This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
3376         when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
3377
3378         * dom/Document.cpp:
3379         (WebCore::Document::displayStringModifiedByEncoding):
3380         (WebCore::Document::displayBufferModifiedByEncoding):
3381         * dom/Document.h:
3382         * WebCore.base.exp:
3383
3384 2009-02-27  Matt Pennig  <pennig@apple.com>
3385
3386         Reviewed by David Hyatt.
3387
3388         Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
3389         "Fixed elements have 0 as an offsetLeft property"
3390         
3391         Code also brings offsetLeft/Top in full conformance with the spec.
3392         Added two tests, one for fixed-position elements, and one for <html>.
3393         
3394         Tests: fast/dom/Element/fixed-position-offset-parent.html
3395                fast/dom/Element/offsetLeft-offsetTop-html.html
3396
3397         * rendering/RenderBoxModelObject.cpp:
3398         (WebCore::RenderBoxModelObject::offsetLeft):
3399         (WebCore::RenderBoxModelObject::offsetTop):
3400
3401 2009-02-27  Dean Jackson  <dino@apple.com>
3402
3403         Reviewed by Simon Fraser.
3404
3405         renderer()->hasTransform() returns true for elements
3406         with perspective, but no transform, so test for transform
3407         when hit testing. This fixes ASSERT from
3408         https://bugs.webkit.org/show_bug.cgi?id=24252
3409
3410         Test: transforms/no_transform_hit_testing.html
3411
3412         * rendering/RenderLayer.cpp:
3413         (WebCore::RenderLayer::hitTestLayer):
3414
3415 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
3416
3417         Reviewed by Darin Fisher.
3418
3419         Fix scrubbing error -- a reversed condition.
3420
3421         * bindings/v8/ScriptValue.h:
3422         (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
3423
3424 2009-02-27  Jian Li  <jianli@chromium.org>
3425
3426         Reviewed by Alexey Proskuryakov.
3427
3428         Add confirmMessageFromWorkerObject to WorkerObjectProxy.
3429         https://bugs.webkit.org/show_bug.cgi?id=24152
3430
3431         * workers/WorkerMessagingProxy.cpp:
3432         (WebCore::MessageWorkerContextTask::performTask):
3433         (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
3434         * workers/WorkerMessagingProxy.h:
3435         * workers/WorkerObjectProxy.h:
3436
3437 2009-02-27  Anders Carlsson  <andersca@apple.com>
3438
3439         Reviewed by David Hyatt.
3440
3441         Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227 
3442         because it leads to assertion failures in the Mac port.
3443         
3444         * platform/graphics/BitmapImage.cpp:
3445         (WebCore::BitmapImage::BitmapImage):
3446         * platform/graphics/BitmapImage.h:
3447         (WebCore::BitmapImage::mayFillWithSolidColor):
3448         * platform/graphics/Image.h:
3449         (WebCore::Image::mayFillWithSolidColor):
3450         * platform/graphics/cairo/ImageCairo.cpp:
3451         (WebCore::BitmapImage::BitmapImage):
3452         * platform/graphics/cg/ImageCG.cpp:
3453         (WebCore::BitmapImage::BitmapImage):
3454         (WebCore::BitmapImage::checkForSolidColor):
3455         * platform/graphics/qt/ImageQt.cpp:
3456         (WebCore::BitmapImage::checkForSolidColor):
3457         * platform/graphics/skia/ImageSkia.cpp:
3458         (WebCore::BitmapImage::checkForSolidColor):
3459         * platform/graphics/wx/ImageWx.cpp:
3460         (WebCore::BitmapImage::checkForSolidColor):
3461
3462 2009-02-27  Adam Barth  <abarth@webkit.org>
3463
3464         Reviewed by Eric Seidel.
3465
3466         https://bugs.webkit.org/show_bug.cgi?id=20249
3467
3468         Add a preference to allow universal access from local URLs to mitigate
3469         some attacks.  Some clients still want to allow this access, so we
3470         expose this as a preference.
3471
3472         * WebCore.base.exp:
3473         * dom/Document.cpp:
3474         (WebCore::Document::initSecurityContext):
3475         * page/SecurityOrigin.cpp:
3476         (WebCore::SecurityOrigin::SecurityOrigin):
3477         * page/Settings.cpp:
3478         (WebCore::Settings::Settings):
3479         (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
3480         * page/Settings.h:
3481         (WebCore::Settings::allowUniversalAccessFromFileUrls):
3482
3483 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
3484
3485         Reviewed by Eric Seidel.
3486
3487         https://bugs.webkit.org/show_bug.cgi?id=24229
3488         If an image has no alpha channel there is no reason to use SourceOver.
3489
3490         * platform/graphics/qt/ImageQt.cpp:
3491         (WebCore::Image::drawPattern):
3492         (WebCore::BitmapImage::draw):
3493
3494 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
3495
3496         Reviewed by Eric Seidel and Simon Fraser.
3497
3498         https://bugs.webkit.org/show_bug.cgi?id=24227
3499         Ensure that the checkForSolidColor() optimization is correctly triggered
3500         for all cases of drawPattern.  Currently, the optimization was not triggered
3501         when the check had not been previously performed via a request for the
3502         image's NativeImagePtr.
3503
3504         Implement the Qt version of the checkForSolidColor() method.  Combined with
3505         the bug fix this reduces the time it takes to draw a repeating background
3506         of a 1x1 image from ~50msecs to ~0msecs on my machine.
3507
3508         * platform/graphics/BitmapImage.cpp:
3509         (WebCore::BitmapImage::BitmapImage):
3510         * platform/graphics/BitmapImage.h:
3511         (WebCore::BitmapImage::mayFillWithSolidColor):
3512         * platform/graphics/Image.h:
3513         (WebCore::Image::mayFillWithSolidColor):
3514         * platform/graphics/cairo/ImageCairo.cpp:
3515         (WebCore::BitmapImage::BitmapImage):
3516         * platform/graphics/cg/ImageCG.cpp:
3517         (WebCore::BitmapImage::BitmapImage):
3518         (WebCore::BitmapImage::checkForSolidColor):
3519         * platform/graphics/qt/ImageQt.cpp:
3520         (WebCore::BitmapImage::checkForSolidColor):
3521         * platform/graphics/skia/ImageSkia.cpp:
3522         (WebCore::BitmapImage::checkForSolidColor):
3523         * platform/graphics/wx/ImageWx.cpp:
3524         (WebCore::BitmapImage::checkForSolidColor):
3525
3526 2009-02-27  Dirk Schulze  <krit@webkit.org>
3527
3528         Reviewed by Zack Rusin.
3529
3530         Added support for gradients and pattern on Fonts for Qt.
3531
3532         [Qt] gradients and patterns for FontQt
3533         https://bugs.webkit.org/show_bug.cgi?id=24243
3534
3535         * platform/graphics/qt/FontQt.cpp:
3536         (WebCore::Font::drawComplexText):
3537
3538 2009-02-27  Jian Li  <jianli@chromium.org>
3539
3540         Reviewed by Alexey Proskuryakov.
3541
3542         WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
3543         https://bugs.webkit.org/show_bug.cgi?id=24113
3544
3545         * workers/WorkerMessagingProxy.cpp:
3546
3547 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
3548
3549         Added a refresh button to storage views.
3550
3551         https://bugs.webkit.org/show_bug.cgi?id=24040
3552
3553         Reviewed by Timothy Hatcher.
3554
3555         * inspector/front-end/DOMStorageItemsView.js:
3556         (WebInspector.DOMStorageItemsView):
3557         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
3558         (WebInspector.DOMStorageItemsView.prototype.update):
3559         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
3560         * inspector/front-end/DatabaseTableView.js:
3561         (WebInspector.DatabaseTableView):
3562         (WebInspector.DatabaseTableView.prototype.get statusBarItems):
3563         (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
3564         * inspector/front-end/DatabasesPanel.js:
3565         (WebInspector.DatabasesPanel):
3566         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
3567         (WebInspector.DatabasesPanel.prototype.reset):
3568         (WebInspector.DatabasesPanel.prototype.showDatabase):
3569         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
3570         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
3571         * inspector/front-end/inspector.css:
3572
3573 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
3574
3575         Added support for editing/deleting localStorage and sessionStorage items
3576         directly from Web Inspector.
3577
3578         https://bugs.webkit.org/show_bug.cgi?id=23866.
3579
3580         Reviewed by Timothy Hatcher.
3581
3582         * WebCore.vcproj/WebCore.vcproj:
3583         * inspector/front-end/DOMStorageDataGrid.js: Added.
3584         (WebInspector.DOMStorageDataGrid):
3585         (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
3586         (WebInspector.DOMStorageDataGrid.prototype._startEditing):
3587         (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
3588         (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
3589         (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
3590         * inspector/front-end/DOMStorageItemsView.js:
3591         (WebInspector.DOMStorageItemsView):
3592         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
3593         (WebInspector.DOMStorageItemsView.prototype.hide):
3594         (WebInspector.DOMStorageItemsView.prototype.update):
3595         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
3596         * inspector/front-end/DatabasesPanel.js:
3597         (WebInspector.DatabasesPanel):
3598         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
3599         (WebInspector.DatabasesPanel.prototype.reset):
3600         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
3601         (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
3602         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
3603         * inspector/front-end/WebKit.qrc:
3604         * inspector/front-end/inspector.css:
3605         * inspector/front-end/inspector.html:
3606
3607 2009-02-26  Brett Wilson  <brettw@chromium.org>
3608
3609         Fix Windows transparency for the Chromium port. Implement a helper
3610         class for handling transparency on Windows. It allows semitransparent
3611         ClearType and semitransparent form controls by making new layers in the
3612         background.
3613
3614         It also replaces the "ThemeHelper" which allows better
3615         scaling and transforms on Windows form controls. In addition to the
3616         functionality that the ThemeHelper did, but additionally handles the
3617         antialiasing properly so that the form controls aren't composited on a
3618         white square.
3619
3620         https://bugs.webkit.org/show_bug.cgi?id=24101
3621
3622         Reviewed by Eric Seidel.
3623
3624         * platform/graphics/chromium/FontChromiumWin.cpp:
3625         (WebCore::):
3626         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
3627         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
3628         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
3629         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
3630         (WebCore::Font::drawGlyphs):
3631         * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
3632         * platform/graphics/chromium/ThemeHelperChromiumWin.h:
3633         * platform/graphics/chromium/TransparencyWin.cpp: Added.
3634         (WebCore::):
3635         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
3636         (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
3637         (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
3638         (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
3639         (WebCore::TransparencyWin::TransparencyWin):
3640         (WebCore::TransparencyWin::~TransparencyWin):
3641         (WebCore::TransparencyWin::init):
3642         (WebCore::TransparencyWin::computeLayerSize):
3643         (WebCore::TransparencyWin::setupLayer):
3644         (WebCore::TransparencyWin::setupLayerForNoLayer):
3645         (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
3646         (WebCore::TransparencyWin::setupLayerForTextComposite):
3647         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
3648         (WebCore::TransparencyWin::setupTransform):
3649         (WebCore::TransparencyWin::setupTransformForKeepTransform):
3650         (WebCore::TransparencyWin::setupTransformForUntransform):
3651         (WebCore::TransparencyWin::setupTransformForScaleTransform):
3652         (WebCore::TransparencyWin::setTextCompositeColor):
3653         (WebCore::TransparencyWin::initializeNewContext):
3654         (WebCore::TransparencyWin::compositeOpaqueComposite):
3655         (WebCore::TransparencyWin::compositeTextComposite):
3656         (WebCore::TransparencyWin::makeLayerOpaque):
3657         * platform/graphics/chromium/TransparencyWin.h: Added.
3658         (WebCore::TransparencyWin::):
3659         (WebCore::TransparencyWin::context):
3660         (WebCore::TransparencyWin::platformContext):
3661         (WebCore::TransparencyWin::drawRect):
3662         * platform/graphics/skia/GraphicsContextSkia.cpp:
3663         (WebCore::GraphicsContext::endTransparencyLayer):
3664         * platform/graphics/skia/ImageSkia.cpp:
3665         (WebCore::paintSkBitmap):
3666         * rendering/RenderThemeChromiumWin.cpp:
3667         (WebCore::):
3668         (WebCore::RenderThemeChromiumWin::paintButton):
3669         (WebCore::RenderThemeChromiumWin::paintMenuList):
3670         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
3671
3672 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
3673
3674         Reviewed by Eric Seidel.
3675
3676         https://bugs.webkit.org/show_bug.cgi?id=24211
3677         Add ScheduledAction for V8.
3678
3679         * bindings/v8/ScheduledAction.cpp: Added.
3680         (WebCore::ScheduledAction::ScheduledAction):
3681         (WebCore::ScheduledAction::~ScheduledAction):
3682         (WebCore::ScheduledAction::execute):
3683         * bindings/v8/ScheduledAction.h: Added.
3684         (WebCore::ScheduledAction::ScheduledAction):
3685
3686 2009-02-27  Zack Rusin  <zack@kde.org>
3687
3688         Reviewed by Nikolas Zimmermann.
3689
3690         Qt: be more reasonable about scrolled lines
3691
3692         cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
3693         match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
3694         irritating. so lets scroll vertically by the Qt set number of lines * Qt default
3695         single step scroll
3696
3697         * platform/qt/WheelEventQt.cpp:
3698
3699 2009-02-27  Xan Lopez  <xan@gnome.org>
3700
3701         Rubber-stamped by Alexey Proskuryakov.
3702
3703         https://bugs.webkit.org/show_bug.cgi?id=24222
3704         [GTK] Remove checks for old glib versions
3705
3706         libsoup, which is a hard dependency, needs at least glib 2.15.3,
3707         so remove all glib checks for versions older than that.
3708
3709         * platform/gtk/ContextMenuGtk.cpp:
3710         (WebCore::ContextMenu::ContextMenu):
3711         * platform/gtk/ContextMenuItemGtk.cpp:
3712         (WebCore::ContextMenuItem::setSubMenu):
3713         * platform/gtk/PopupMenuGtk.cpp:
3714         (WebCore::PopupMenu::show):
3715         * platform/gtk/WidgetGtk.cpp:
3716         (WebCore::Widget::retainPlatformWidget):
3717         * platform/network/soup/ResourceHandleSoup.cpp:
3718
3719 2009-02-26  Dirk Schulze  <krit@webkit.org>
3720
3721         Reviewed by Oliver Hunt.
3722
3723         Added support for Gradients and Patterns on filled or stroked Fonts
3724         in Cairo. I also added support for globalAlpha on FontCairo.
3725
3726         [CAIRO] SVG/Canvas fonts miss gradients/pattern support
3727         https://bugs.webkit.org/show_bug.cgi?id=18617
3728
3729         * html/CanvasRenderingContext2D.cpp:
3730         (WebCore::CanvasRenderingContext2D::drawTextInternal):
3731         * platform/graphics/cairo/FontCairo.cpp:
3732         (WebCore::Font::drawGlyphs):
3733
3734 2009-02-26  Stephen White  <senorblanco@chromium.org>
3735
3736         Reviewed by Eric Seidel.
3737
3738         https://bugs.webkit.org/show_bug.cgi?id=23957
3739
3740         Fix for SVG gradient and pattern text for Chromium/skia. 
3741         Added accessors for the fill and stroke gradients to
3742         GraphicsContext.  Changed the paintSkiaText function to take a
3743         GraphicsContext, so we can check for gradients/patterns. 
3744         Changed the skiaDrawText function to set the SkPaint shader
3745         correctly, and to scale up the gradient shader matrix to
3746         encompass the entire text string.  Also offset each glyph
3747         separately, rather than transforming the canvas, so that the
3748         gradient/pattern stays fixed relative to the text origin.
3749
3750         * platform/graphics/GraphicsContext.cpp:
3751         (WebCore::GraphicsContext::getFillGradient):
3752         (WebCore::GraphicsContext::getStrokeGradient):
3753         (WebCore::GraphicsContext::getFillPattern):
3754         (WebCore::GraphicsContext::getStrokePattern):
3755         * platform/graphics/GraphicsContext.h:
3756         * platform/graphics/chromium/FontChromiumWin.cpp:
3757         (WebCore::Font::drawGlyphs):
3758         * platform/graphics/chromium/UniscribeHelper.cpp:
3759         (WebCore::UniscribeHelper::draw):
3760         * platform/graphics/skia/SkiaFontWin.cpp:
3761         (WebCore::windowsCanHandleTextDrawing):
3762         (WebCore::skiaDrawText):
3763         (WebCore::paintSkiaText):
3764         * platform/graphics/skia/SkiaFontWin.h:
3765
3766 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
3767
3768         Reviewed by Eric Seidel.
3769
3770         https://bugs.webkit.org/show_bug.cgi?id=24208
3771         Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
3772
3773         * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
3774         (WebCore::ACCESSOR_GETTER):
3775         (WebCore::CALLBACK_FUNC_DECL):
3776         * bindings/v8/custom/V8DocumentCustom.cpp: Added.
3777         (WebCore::CALLBACK_FUNC_DECL):
3778         * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
3779         (WebCore::ACCESSOR_GETTER):
3780         * bindings/v8/custom/V8NodeCustom.cpp: Added.
3781         (WebCore::CALLBACK_FUNC_DECL):
3782
3783 2009-02-26  Gustavo Noronha Silva  <gns@gnome.org>
3784
3785         Unreviewed build fix for building with GNOME Keyring enabled.
3786
3787         * platform/network/soup/webkit-soup-auth-dialog.c:
3788         (show_auth_dialog):
3789
3790 2009-02-26  Xan Lopez  <xan@gnome.org>
3791
3792         Reviewed by Holger Freyther.
3793
3794         https://bugs.webkit.org/show_bug.cgi?id=16947
3795         [GTK] Missing HTTP Auth challenge
3796
3797         Add HTTP authentication dialog with optional GNOME Keyring
3798         storage.
3799
3800         * GNUmakefile.am:
3801         * platform/network/ResourceHandleInternal.h:
3802         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
3803         * platform/network/soup/ResourceHandleSoup.cpp:
3804         (WebCore::currentToplevelCallback):
3805         (WebCore::ResourceHandle::startHttp):
3806         (WebCore::ResourceHandle::start):
3807         * platform/network/soup/webkit-soup-auth-dialog.c: Added.
3808         (webkit_soup_auth_dialog_class_init):
3809         (webkit_soup_auth_dialog_init):
3810         (webkit_soup_auth_dialog_session_feature_init):
3811         (free_authData):
3812         (set_password_callback):
3813         (response_callback):
3814         (show_auth_dialog):
3815         (find_password_callback):
3816         (session_authenticate):
3817         (attach):
3818         * platform/network/soup/webkit-soup-auth-dialog.h: Added.
3819
3820 2009-02-25  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
3821
3822         Reviewed by Dave Hyatt.
3823
3824         After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
3825         svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
3826         started failing because Ojan's new code was now *correctly* calling through to
3827         SVG asking for the closest text offset in the last line box, instead of
3828         just returning the offset at the end of the last line box when clicking below a box.
3829
3830         But!  The SVG code was wrong, in that it returned the character offset of the last
3831         character when you asked for a character offset after the end of the box, instead
3832         it should return the offset *after* the last character.  This patch fixes
3833         that behavior by reordering the last two clauses in svgCharacterHitsPosition.
3834
3835         The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
3836         to document what's wrong.  I've also cleaned up the code a bit so it's clearer
3837         what it is doing (which also makes more obvious what's wrong with it).
3838
3839         * rendering/RenderSVGInlineText.cpp:
3840         (WebCore::RenderSVGInlineText::positionForCoordinates):
3841         * rendering/SVGInlineTextBox.cpp:
3842         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
3843         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
3844         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
3845         (WebCore::SVGInlineTextBox::closestCharacterToPosition):
3846         (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
3847
3848 2009-02-26  Darin Fisher  <darin@chromium.org>
3849
3850         Reviewed by Eric Seidel.
3851
3852         Minor cleanup of ChromiumBridge:
3853         Removing unused matchesMIMEType method and s/Javascript/JavaScript/
3854
3855         * platform/chromium/ChromiumBridge.h:
3856         * platform/chromium/MimeTypeRegistryChromium.cpp:
3857         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
3858         (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
3859         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
3860
3861 2009-02-26  David Hyatt  <hyatt@apple.com>
3862
3863         Reviewed by Sam Weinig
3864
3865         Fix text-bottom vertical alignment.  It was incorrectly aligning the bottom of the descent instead of including
3866         the line-height below the descent.
3867
3868         Added fast/inline/vertical-align-text-bottom.html
3869
3870         * rendering/RenderBoxModelObject.cpp:
3871         (WebCore::RenderBoxModelObject::verticalPosition):
3872
3873 2009-02-26  Dirk Schulze  <krit@webkit.org>
3874
3875         Reviewed by Eric Seidel.
3876
3877         Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
3878         ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
3879         just to implement this three methods to support SVG Masking now.
3880  
3881         Make SVG Masking platform aware
3882         https://bugs.webkit.org/show_bug.cgi?id=19243
3883
3884         * GNUmakefile.am:
3885         * WebCore.pro:
3886         * WebCore.vcproj/WebCore.vcproj:
3887         * WebCore.xcodeproj/project.pbxproj:
3888         * svg/graphics/SVGResourceMasker.cpp:
3889         (WebCore::SVGResourceMasker::applyMask):
3890         * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
3891         * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
3892         * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
3893         * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
3894         * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
3895
3896 2009-02-26  Yong Li  <yong.li@torchmobile.com>
3897
3898         Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
3899
3900         Test: http/tests/misc/slow-preload-cancel.html
3901
3902         https://bugs.webkit.org/show_bug.cgi?id=24133
3903         Clear all pending preloads in the DocLoader object when we decide to
3904         cancel its all requests.
3905
3906         * loader/DocLoader.cpp:
3907         (WebCore::DocLoader::clearPendingPreloads):
3908         * loader/DocLoader.h:
3909         * loader/loader.cpp:
3910         (WebCore::Loader::cancelRequests):
3911
3912 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
3913
3914         Reviewed by Eric Seidel.
3915
3916         https://bugs.webkit.org/show_bug.cgi?id=24182
3917         Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
3918
3919         * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
3920         (WebCore::CALLBACK_FUNC_DECL):
3921         * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
3922         (WebCore::toV8):
3923         (WebCore::CALLBACK_FUNC_DECL):
3924         * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
3925         (WebCore::toV8):
3926         (WebCore::CALLBACK_FUNC_DECL):
3927
3928 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
3929
3930         Reviewed by Darin Adler.
3931
3932         https://bugs.webkit.org/show_bug.cgi?id=23500
3933         KURL::parse() incorrectly compares its result to original string
3934
3935         * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
3936
3937 2009-02-26  Ojan Vafai  <ojan@chromium.org>
3938
3939         Reviewed by Kevin McCullough.
3940
3941         Manual test for inspector node highlighting.
3942
3943         * manual-tests/inspector/highlight-nodes.html: Added.
3944
3945 2009-02-16  Anantanarayanan Iyengar  <ananta@chromium.org>
3946
3947         Reviewed by Darin Fisher.
3948
3949         https://bugs.webkit.org/show_bug.cgi?id=23973
3950         ScrollView::scrollContents can be invoked during view shutdown.  In
3951         this scenario the FrameView::hostWindow method can return NULL, which
3952         indicates that the frame/page is being destroyed. This causes a crash
3953         when we try to dereference a NULL hostWindow pointer.  Fix is to add a
3954         NULL check for this.  
3955
3956         * platform/ScrollView.cpp:
3957         (WebCore::ScrollView::scrollContents):
3958
3959 2009-02-26  Rahul Kuchhal  <kuchhal@chromium.org>
3960
3961         Reviewed by Dave Hyatt.
3962
3963         https://bugs.webkit.org/show_bug.cgi?id=24003
3964         Fix a crash caused by unsafe type conversion.
3965
3966         Test: fast/block/positioning/absolute-in-inline-rtl-4.html
3967
3968         * rendering/RenderBox.cpp:
3969         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
3970
3971 2009-02-26  Ojan Vafai  <ojan@chromium.org>
3972
3973         Reviewed by Adam Roben.
3974
3975         https://bugs.webkit.org/show_bug.cgi?id=24202
3976         Have drawNodeHighlight clip instead of clearing. This makes it work for
3977         both Safari and Chromium since Chromium draws the inspector highlighting
3978         in the same buffer as the page.
3979
3980         * inspector/InspectorController.cpp:
3981         (WebCore::quadToPath):
3982         (WebCore::drawOutlinedQuad):
3983         (WebCore::drawOutlinedQuadWithClip):
3984         (WebCore::drawHighlightForBox):
3985
3986 2009-02-26  David Hyatt  <hyatt@apple.com>
3987
3988         Reviewed by Dan Bernstein & Darin Adler
3989
3990         Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
3991         
3992         Added fast/inline/inline-continuation-borders.html
3993
3994         * rendering/InlineFlowBox.cpp:
3995         (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
3996
3997 2009-02-26  Simon Fraser  <simon.fraser@apple.com>
3998
3999         Build fix, no review.
4000         
4001         Try to fix the wx build after r41218.
4002
4003         * WebCoreSources.bkl:
4004
4005 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
4006
4007         Reviewed by Darin Adler.
4008
4009         https://bugs.webkit.org/show_bug.cgi?id=19527
4010         ASSERTION FAILED: containerA && containerB
4011
4012         Test: fast/dom/Range/bug-19527.html
4013
4014         * dom/Range.cpp:
4015         (WebCore::Range::isPointInRange):
4016         (WebCore::Range::comparePoint):
4017         Bring the behavior in line with current Firefox, making it impossible for these methods
4018         to pass a null container to compareBoundaryPoints().
4019
4020 2009-02-26  Jonathon Jongsma  <jonathon@quotidian.org>
4021
4022         Reviewed by Holger Freyther.
4023
4024         https://bugs.webkit.org/show_bug.cgi?id=20358
4025
4026         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
4027         (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
4028         should set the computed size rather than the specified size, otherwise
4029         the caps just get rendered normal size.
4030
4031 2009-02-26  Benjamin Meyer  <benjamin.meyer@torchmobile.com>
4032
4033         Reviewed by George Staikos.
4034
4035         https://bugs.webkit.org/show_bug.cgi?id=24062
4036         QNetworkCookieJar expects the url and not the policy url.  Sending the
4037         policy url will cause QNetworkCookieJar to behave incorrectly.  One
4038         example would be a cookie that does not have a path or domain.
4039         QNetworkCookieJar will use the url it is given to fill in default values.
4040         This allows setting cookies on the url of the main frame from an iFrame
4041         when the cookie should be set on the url of the iFrame.
4042
4043         Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
4044
4045         * platform/qt/CookieJarQt.cpp:
4046         (WebCore::setCookies):
4047
4048 2009-02-26  Charles Wei  <charles.wei@torchmobile.com.cn>
4049
4050         Reviewed by George Staikos.
4051
4052         make WebKit/Qt compile with SVG disabled
4053
4054         * WebCore.pro:
4055         * platform/graphics/qt/FontPlatformDataQt.cpp:
4056
4057 2009-02-25  Gustavo Noronha Silva  <gns@gnome.org>
4058
4059         Unreviewed build fix. Add WebCore/workers to the list of paths
4060         searched by the bindings generator perl script.
4061
4062         * GNUmakefile.am:
4063
4064 2009-02-25  Sam Weinig  <sam@webkit.org>
4065
4066         Reviewed by Geoffrey Garen.
4067
4068         Add canvas to the list of RenderObjects that can mark a page as
4069         visually not empty.
4070
4071         * rendering/RenderHTMLCanvas.cpp:
4072         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
4073
4074 2009-02-25  Eric Carlson  <eric.carlson@apple.com>
4075
4076         Reviewed by Dave Hyatt.
4077
4078         * rendering/RenderBox.cpp:
4079         (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
4080         as RenderMedia with controls always has a layer.
4081
4082 2009-02-25  Dan Bernstein  <mitz@apple.com>
4083
4084         Reviewed by Simon Fraser.
4085
4086         - fix https://bugs.webkit.org/show_bug.cgi?id=24130
4087           <rdar://problem/6618196> Paint very slow when horizontally resizing
4088
4089         Test: fast/gradients/background-clipped.html
4090
4091         * rendering/RenderBoxModelObject.cpp:
4092         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
4093         destination rectangle passed to drawTiledImage() with the dirty
4094         rectangle. This makes it more likely for the destination rect to be
4095         contained in a single tile rect, which results in a faster code path
4096         being taken down the road (just drawing a single tile instead of
4097         tiling).
4098
4099 2009-02-25  Ojan Vafai  <ojan@chromium.org>
4100
4101         Reviewed by Eric Seidel.
4102
4103         Fix test regressions from positionForCoordinates patch.
4104         https://bugs.webkit.org/show_bug.cgi?id=24148
4105
4106         * rendering/RenderBlock.cpp:
4107         (WebCore::positionForPointWithInlineChildren):
4108         Remove ASSERT that placeholder text codepath is hitting.
4109
4110 2009-02-25  Chris Fleizach  <cfleizach@apple.com>
4111
4112         Reviewed by Beth Dakin.
4113
4114         Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
4115         https://bugs.webkit.org/show_bug.cgi?id=24143
4116
4117         When an AX object is marked dirty, do not create AX elements while going up the parent chain.
4118         Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
4119         Make sure the AXObjectWrapper's have an object before calling them
4120         In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
4121
4122         Test: platform/mac-snowleopard/accessibility/table-updating.html
4123
4124         * WebCore.base.exp:
4125         * page/AXObjectCache.cpp:
4126         (WebCore::AXObjectCache::~AXObjectCache):
4127         (WebCore::AXObjectCache::get):
4128         (WebCore::AXObjectCache::getOrCreate):
4129         (WebCore::AXObjectCache::removeAXID):
4130         (WebCore::AXObjectCache::handleActiveDescendantChanged):
4131         (WebCore::AXObjectCache::handleAriaRoleChanged):
4132         * page/AXObjectCache.h:
4133         * page/AccessibilityImageMapLink.cpp:
4134         (WebCore::AccessibilityImageMapLink::parentObject):
4135         * page/AccessibilityListBox.cpp:
4136         (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
4137         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
4138         * page/AccessibilityListBoxOption.cpp:
4139         (WebCore::AccessibilityListBoxOption::elementRect):
4140         (WebCore::AccessibilityListBoxOption::parentObject):
4141         * page/AccessibilityObject.cpp:
4142         (WebCore::AccessibilityObject::detach):
4143         (WebCore::AccessibilityObject::parentObjectIfExists):
4144         (WebCore::replacedNodeNeedsCharacter):
4145         (WebCore::AccessibilityObject::accessibilityObjectForPosition):
4146         * page/AccessibilityObject.h:
4147         * page/AccessibilityRenderObject.cpp:
4148         (WebCore::AccessibilityRenderObject::firstChild):
4149         (WebCore::AccessibilityRenderObject::lastChild):
4150         (WebCore::AccessibilityRenderObject::previousSibling):
4151         (WebCore::AccessibilityRenderObject::nextSibling):
4152         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
4153         (WebCore::AccessibilityRenderObject::parentObject):
4154         (WebCore::AccessibilityRenderObject::isAttachment):
4155         (WebCore::AccessibilityRenderObject::headingLevel):
4156         (WebCore::AccessibilityRenderObject::anchorElement):
4157         (WebCore::AccessibilityRenderObject::menuForMenuButton):
4158         (WebCore::AccessibilityRenderObject::menuButtonForMenu):
4159         (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
4160         (WebCore::AccessibilityRenderObject::internalLinkElement):
4161         (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
4162         (WebCore::AccessibilityRenderObject::titleUIElement):
4163         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
4164         (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
4165         (WebCore::AccessibilityRenderObject::getDocumentLinks):
4166         (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
4167         (WebCore::AccessibilityRenderObject::focusedUIElement):
4168         (WebCore::AccessibilityRenderObject::activeDescendant):
4169         (WebCore::AccessibilityRenderObject::observableObject):
4170         (WebCore::AccessibilityRenderObject::childrenChanged):
4171         (WebCore::AccessibilityRenderObject::addChildren):
4172         * page/AccessibilityRenderObject.h:
4173         (WebCore::AccessibilityRenderObject::setRenderObject):
4174         * page/AccessibilityTable.cpp:
4175         (WebCore::AccessibilityTable::addChildren):
4176         (WebCore::AccessibilityTable::headerContainer):
4177         (WebCore::AccessibilityTable::cellForColumnAndRow):
4178         * page/AccessibilityTableCell.cpp:
4179         (WebCore::AccessibilityTableCell::isTableCell):
4180         (WebCore::AccessibilityTableCell::titleUIElement):
4181         * page/AccessibilityTableColumn.cpp:
4182         (WebCore::AccessibilityTableColumn::headerObjectForSection):
4183         * page/AccessibilityTableRow.cpp:
4184         (WebCore::AccessibilityTableRow::isTableRow):
4185         * page/gtk/AccessibilityObjectWrapperAtk.cpp:
4186         * page/mac/AXObjectCacheMac.mm:
4187         (WebCore::AXObjectCache::postNotification):
4188         (WebCore::AXObjectCache::postNotificationToElement):
4189         * page/mac/AccessibilityObjectWrapper.mm:
4190         (textMarkerForVisiblePosition):
4191         (AXLinkElementForNode):
4192         (nsStringForReplacedNode):
4193         (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
4194         (-[AccessibilityObjectWrapper accessibilityActionNames]):
4195         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
4196         (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
4197         (-[AccessibilityObjectWrapper accessibilityHitTest:]):
4198         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
4199         (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
4200         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
4201         (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
4202         (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
4203         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
4204         (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
4205         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
4206         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
4207         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
4208
4209 2009-02-25  Beth Dakin  <bdakin@apple.com>
4210
4211         Reviewed by Geoff Garen.
4212
4213         Re-working of <rdar://problem/6487249> repro crash in 
4214         WebCore::CSSParser::parseFillImage copying entire contents of this 
4215         page
4216         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
4217
4218         Fixes a bunch of layout test failures I caused!
4219
4220         * css/CSSParser.cpp:
4221         (WebCore::CSSParser::parseValue):
4222         (WebCore::CSSParser::parseContent):
4223         (WebCore::CSSParser::parseFillImage):
4224         (WebCore::CSSParser::parseFontFaceSrc):
4225         (WebCore::CSSParser::parseBorderImage):
4226
4227 2009-02-25  Dimitri Glazkov  <dglazkov@chromium.org>
4228
4229         Reviewed by Eric Seidel.
4230
4231         https://bugs.webkit.org/show_bug.cgi?id=24174
4232         Add more V8 custom bindings.
4233
4234         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
4235         (WebCore::hasCSSPropertyNamePrefix):
4236         (WebCore::cssPropertyName):
4237         (WebCore::NAMED_PROPERTY_GETTER):
4238         (WebCore::NAMED_PROPERTY_SETTER):
4239         * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
4240         (WebCore::INDEXED_PROPERTY_GETTER):
4241         (WebCore::CALLBACK_FUNC_DECL):
4242         * bindings/v8/custom/V8EventCustom.cpp: Added.
4243         (WebCore::ACCESSOR_SETTER):
4244         (WebCore::ACCESSOR_GETTER):
4245         * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
4246         (WebCore::NAMED_PROPERTY_DELETER):
4247         (WebCore::NAMED_PROPERTY_SETTER):
4248         (WebCore::NAMED_PROPERTY_GETTER):
4249         * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
4250         (WebCore::NAMED_PROPERTY_GETTER):
4251         * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
4252         (WebCore::INDEXED_PROPERTY_GETTER):
4253         (WebCore::NAMED_PROPERTY_GETTER):
4254         * bindings/v8/custom/V8NodeListCustom.cpp: Added.
4255         (WebCore::NAMED_PROPERTY_GETTER):
4256         * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
4257         (WebCore::NAMED_PROPERTY_GETTER):
4258
4259 2009-02-25  Scott Violet  <sky@google.com>
4260
4261         Reviewed by Dave Hyatt.
4262
4263         https://bugs.we