WebCore/ChangeLog

   1 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
   2
   3         Reviewed by Mitz.
   4
   5         Added missing "break;" statement in switch statement from r17493.
   6
   7         Bug 11442: [CSS 3] support for cursor: all-scroll
   8         http://bugs.webkit.org/show_bug.cgi?id=11442
   9
  10         * css/CSSComputedStyleDeclaration.cpp:
  11         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  12
  13 2006-10-31  Mitz Pettel  <mitz@webkit.org>
  14
  15         Reviewed by Maciej.
  16
  17         - fix image dragging
  18
  19         This is covered by editing/selection/drag-to-contenteditable-iframe.html
  20
  21         * rendering/HitTestResult.cpp:
  22         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
  23         HTML IMG elements.
  24         (WebCore::HitTestResult::absoluteImageURL): Ditto.
  25
  26 2006-10-31  Beth Dakin  <bdakin@apple.com>
  27
  28         Reviewed by Maciej.
  29
  30         This adds the back-end of the remaining WebElementDictionary
  31         functions into HitTestResult.
  32
  33         * WebCore.exp:
  34         * rendering/HitTestResult.cpp:
  35         (WebCore::HitTestResult::title):
  36         (WebCore::displayString): This is nearly identical to the
  37         displayString() defined in DOMInternal.mm except that it returns a
  38         String instead of an NSString. The old code path used the
  39         DOMInternal method, so I made a new one here for the new code path.
  40         (WebCore::HitTestResult::altDisplayString):
  41         (WebCore::HitTestResult::image):
  42         (WebCore::HitTestResult::absoluteImageURL):
  43         (WebCore::HitTestResult::absoluteLinkURL):
  44         (WebCore::HitTestResult::titleDisplayString):
  45         (WebCore::HitTestResult::textContent):
  46         * rendering/HitTestResult.h:
  47
  48 2006-10-31  John Sullivan  <sullivan@apple.com>
  49
  50         * bridge/mac/FrameMac.mm:
  51         (WebCore::FrameMac::markMisspellings):
  52         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
  53
  54 2006-10-31  John Sullivan  <sullivan@apple.com>
  55
  56         Reviewed by Maciej
  57
  58         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
  59
  60         The foundation of this was in my last checkin. This checkin is all about displaying
  61         the correct string in the toolTip.
  62
  63         * dom/DocumentMarker.h:
  64         New description field in this struct.
  65
  66         * bridge/mac/FrameMac.mm:
  67         (WebCore::FrameMac::advanceToNextMisspelling):
  68         When adding a grammar marker, supply the appropriate description. Also, added a comment
  69         about the remaining work to make grammar checking return sensible answers.
  70         (WebCore::FrameMac::markMisspellings):
  71         ditto (yes, still needs some refactoring to minimize duplicated code)
  72
  73         * dom/Document.h:
  74         * dom/Document.cpp:
  75         (WebCore::Document::addMarker):
  76         Now takes an optional description string
  77         (WebCore::Document::markerContainingPoint):
  78         New function, returns a pointer to the (first) marker of the specified type whose rect
  79         contains the specified point, or 0 if none.
  80
  81         * rendering/HitTestResult.cpp:
  82         (WebCore::HitTestResult::spellingToolTip):
  83         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
  84         and gets the description from the marker.
  85
  86 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
  87
  88         Reviewed by Maciej.
  89
  90         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
  91
  92         * loader/mac/FrameLoaderMac.mm:
  93         (WebCore::FrameLoader::createWindow):
  94         * manual-tests/window-open-features-parsing.html: Updated for clarity.
  95
  96 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
  97
  98         Reviewed by Alice.
  99
 100         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
 101         to WebCore::Editor.
 102
 103         Layout tests pass.
 104
 105         Renamed "may*" to "can*" because "can" is more accurate (these functions
 106         aren't just about permission) and it matches WebKit.
 107
 108         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a
 109         password field. Now that WebCore fully implements canCopy(), it doesn't just
 110         mean "the selection is not in a password field" anymore.
 111         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code.
 112         The fact that it's not called anymore may represent a security issue, but I
 113         don't see how commented-out code will help reveal the issue, and the
 114         bridge is going away, anyway.
 115         * editing/SelectionController.h: Changed selection() calls to references
 116         to m_sel, to match the rest of the file.
 117
 118 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
 119
 120         Reviewed by harrison
 121
 122         <rdar://problem/4711063>
 123         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
 124
 125         * editing/ReplaceSelectionCommand.cpp:
 126         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
 127         insertion and plain text string creation unless we need the string
 128         for a BeforeTextInserted event handler or for a plain text only region.
 129         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
 130         code here from ReplacementFragment's constructor.
 131         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
 132         FIXME.
 133         * editing/ReplaceSelectionCommand.h:
 134
 135 2006-10-31  Ada Chan  <adachan@apple.com>
 136
 137         Reviewed by Adam
 138
 139         Correct forward declarations of the HitTestRequest struct.
 140
 141         * rendering/EllipsisBox.h:
 142         * rendering/InlineBox.h:
 143         * rendering/InlineFlowBox.h:
 144         * rendering/RenderLayer.h:
 145         * rendering/RenderObject.h:
 146
 147 2006-10-31  John Sullivan  <sullivan@apple.com>
 148
 149         Reviewed by Beth and Adam
 150
 151         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip;
 152         next I'll make it use a string that's relevant for a specific grammar error.
 153
 154         * WebCore.exp:
 155         export symbol for spellingToolTip function
 156
 157         * rendering/HitTestResult.h:
 158         * rendering/HitTestResult.cpp:
 159         (WebCore::HitTestResult::spellingToolTip):
 160         new function, returns the string to be used in a tool tip that describes the questionable grammar
 161
 162         * rendering/InlineTextBox.h:
 163         * rendering/InlineTextBox.cpp:
 164         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
 165         now takes a style and font, needed to compute the rect representing the range containing
 166         questionable grammar. Computes the rect and associates it with the marker.
 167         (WebCore::InlineTextBox::paintDocumentMarkers):
 168         Pass in the style and font now needed by paintSpellingOrGrammarMarker
 169
 170 2006-10-31  Adele Peterson  <adele@apple.com>
 171
 172         Removed commented out variable from last checkin.
 173
 174         * html/HTMLSelectElement.cpp:
 175         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
 176
 177 2006-10-31  Brady Eidson  <beidson@apple.com>
 178
 179         Build fix (unused variable in release builds)
 180
 181         * html/HTMLSelectElement.cpp:
 182         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
 183
 184 2006-10-31  Adele Peterson  <adele@apple.com>
 185
 186         Reviewed by Adam.
 187
 188         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
 189         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
 190         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
 191
 192         Tests:
 193         * LayoutTests/fast/forms/listbox-selection.html
 194         * LayoutTests/fast/forms/listbox-onchange.html
 195
 196         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
 197           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
 198           And one for onChange, that is updated after onChange is fired.
 199           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
 200
 201         * html/HTMLSelectElement.cpp:
 202         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
 203         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
 204         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
 205         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
 206         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
 207         (WebCore::HTMLSelectElement::setExtent): Added.
 208         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
 209         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
 210
 211         * rendering/RenderListBox.cpp:
 212         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
 213         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
 214         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
 215         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
 216          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
 217          notify the select element from here.
 218         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
 219         (WebCore::RenderListBox::listIndexIsVisible): Added.
 220         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
 221
 222         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction,
 223         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
 224         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
 225         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
 226         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
 227
 228 2006-10-31  Beth Dakin  <bdakin@apple.com>
 229
 230         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
 231
 232         * rendering/HitTestRequest.h: Added.
 233         (WebCore::HitTestRequest::HitTestRequest):
 234
 235 2006-10-31  Beth Dakin  <bdakin@apple.com>
 236
 237         Reviewed by Maciej.
 238
 239         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult
 240         should be split into HitTestRequest and HitTestResult
 241
 242         This patch creates a new struct called HitTestRequest that holds
 243         the three boolean values (readonly, active, and mouseMove) that
 244         were formerly a part of HitTestResult. All hitTest() and
 245         nodeAtPoint() functions now take a HitTestRequest in addition to
 246         the HitTestResult.
 247
 248         * WebCore.exp:
 249         * WebCore.xcodeproj/project.pbxproj:
 250         * bridge/mac/FrameMac.mm:
 251         (WebCore::FrameMac::eventMayStartDrag):
 252         (WebCore::FrameMac::handleMouseMoveEvent):
 253         * bridge/mac/WebCoreAXObject.mm:
 254         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
 255         (-[WebCoreAXObject accessibilityHitTest:]):
 256         * dom/Document.cpp:
 257         (WebCore::Document::elementFromPoint):
 258         (WebCore::Document::prepareMouseEvent):
 259         * editing/SelectionController.cpp:
 260         (WebCore::SelectionController::contains):
 261         * page/Frame.cpp:
 262         (WebCore::Frame::hitTestResultAtPoint):
 263         * page/FrameView.cpp:
 264         (WebCore::FrameView::handleWheelEvent):
 265         * rendering/EllipsisBox.cpp:
 266         (WebCore::EllipsisBox::nodeAtPoint):
 267         * rendering/EllipsisBox.h:
 268         * rendering/HitTestResult.cpp:
 269         (WebCore::HitTestResult::HitTestResult):
 270         (WebCore::HitTestResult::operator=):
 271         * rendering/HitTestResult.h:
 272         * rendering/InlineBox.cpp:
 273         (WebCore::InlineBox::nodeAtPoint):
 274         * rendering/InlineBox.h:
 275         * rendering/InlineFlowBox.cpp:
 276         (WebCore::InlineFlowBox::nodeAtPoint):
 277         * rendering/InlineFlowBox.h:
 278         * rendering/InlineTextBox.cpp:
 279         (WebCore::InlineTextBox::nodeAtPoint):
 280         * rendering/InlineTextBox.h:
 281         * rendering/RenderBlock.cpp:
 282         (WebCore::RenderBlock::nodeAtPoint):
 283         * rendering/RenderBlock.h:
 284         * rendering/RenderBox.cpp:
 285         (WebCore::RenderBox::nodeAtPoint):
 286         * rendering/RenderBox.h:
 287         * rendering/RenderFlow.cpp:
 288         (WebCore::RenderFlow::hitTestLines):
 289         * rendering/RenderFlow.h:
 290         * rendering/RenderForeignObject.cpp:
 291         (WebCore::RenderForeignObject::nodeAtPoint):
 292         * rendering/RenderForeignObject.h:
 293         * rendering/RenderFrameSet.cpp:
 294         (WebCore::RenderFrameSet::nodeAtPoint):
 295         * rendering/RenderFrameSet.h:
 296         * rendering/RenderImage.cpp:
 297         (WebCore::RenderImage::nodeAtPoint):
 298         * rendering/RenderImage.h:
 299         * rendering/RenderInline.cpp:
 300         (WebCore::RenderInline::nodeAtPoint):
 301         * rendering/RenderInline.h:
 302         * rendering/RenderLayer.cpp:
 303         (WebCore::RenderLayer::autoscroll):
 304         (WebCore::RenderLayer::hitTest):
 305         (WebCore::RenderLayer::hitTestLayer):
 306         (WebCore::RenderLayer::updateHoverActiveState):
 307         * rendering/RenderLayer.h:
 308         * rendering/RenderObject.cpp:
 309         (WebCore::RenderObject::hitTest):
 310         (WebCore::RenderObject::nodeAtPoint):
 311         * rendering/RenderObject.h:
 312         * rendering/RenderPath.cpp:
 313         (WebCore::RenderPath::nodeAtPoint):
 314         * rendering/RenderPath.h:
 315         * rendering/RenderSVGImage.cpp:
 316         (WebCore::RenderSVGImage::nodeAtPoint):
 317         * rendering/RenderSVGImage.h:
 318         * rendering/RenderSVGText.cpp:
 319         (WebCore::RenderSVGText::nodeAtPoint):
 320         * rendering/RenderSVGText.h:
 321         * rendering/RenderTableRow.cpp:
 322         (WebCore::RenderTableRow::nodeAtPoint):
 323         * rendering/RenderTableRow.h:
 324         * rendering/RenderTableSection.cpp:
 325         (WebCore::RenderTableSection::nodeAtPoint):
 326         * rendering/RenderTableSection.h:
 327         * rendering/RenderText.h:
 328         (WebCore::RenderText::nodeAtPoint):
 329         * rendering/RenderTextControl.cpp:
 330         (WebCore::RenderTextControl::nodeAtPoint):
 331         * rendering/RenderTextControl.h:
 332         * rendering/RootInlineBox.cpp:
 333         (WebCore::RootInlineBox::nodeAtPoint):
 334         * rendering/RootInlineBox.h:
 335
 336 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
 337
 338         Reviewed by Maciej.
 339
 340         Bug 11442: [CSS 3] support for cursor: all-scroll
 341         http://bugs.webkit.org/show_bug.cgi?id=11442
 342
 343         * css/CSSComputedStyleDeclaration.cpp:
 344         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
 345         * css/CSSValueKeywords.in:
 346         * css/cssparser.cpp:
 347         (WebCore::CSSParser::parseValue):
 348         * page/FrameView.cpp:
 349         (WebCore::selectCursor):
 350         * rendering/RenderStyle.h:
 351
 352 2006-10-31  Oliver Hunt  <oliver@apple.com>
 353
 354         Reviewed by Geoff.
 355
 356         Converting Obj-C++ to C++ in kcanvas
 357
 358         * WebCore.xcodeproj/project.pbxproj:
 359         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
 360         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
 361         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
 362         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
 363         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
 364         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
 365         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
 366         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
 367         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
 368         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
 369         * kcanvas/device/quartz/QuartzSupport.h:
 370         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
 371         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
 372         (WebCore::SVGResourceClipper::applyClip):
 373         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
 374         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
 375         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
 376
 377 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
 378
 379         Reviewed by harrison
 380
 381         <rdar://problem/4808375>
 382         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
 383
 384         Completely back out r17276 because of performance issues.
 385
 386         * editing/TextIterator.cpp:
 387         (WebCore::TextIterator::TextIterator):
 388         (WebCore::TextIterator::advance):
 389         (WebCore::TextIterator::handleTextNode):
 390         (WebCore::TextIterator::handleTextBox):
 391         (WebCore::TextIterator::handleReplacedElement):
 392         (WebCore::TextIterator::handleNonTextNode):
 393         (WebCore::TextIterator::exitNode):
 394         (WebCore::TextIterator::emitCharacter):
 395         (WebCore::TextIterator::range):
 396         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
 397         (WebCore::SimplifiedBackwardsTextIterator::advance):
 398         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
 399         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
 400         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
 401         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
 402         (WebCore::SimplifiedBackwardsTextIterator::range):
 403         (WebCore::CharacterIterator::range):
 404         (WebCore::TextIterator::rangeFromLocationAndLength):
 405         * editing/TextIterator.h:
 406         (WebCore::TextIterator::atEnd):
 407         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
 408
 409 2006-10-31  Darin Adler  <darin@apple.com>
 410
 411         Reviewed by Brady.
 412
 413         - got "action dictionary" code out of FrameLoader,
 414           replacing with a class called NavigationAction
 415
 416         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
 417         * loader/mac/DocumentLoaderMac.mm:
 418         (WebCore::DocumentLoader::triggeringAction): Ditto.
 419         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
 420
 421         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
 422
 423         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
 424         Removed elementForEvent.
 425         * loader/mac/FrameLoaderMac.mm:
 426         (WebCore::FrameLoader::load): Ditto.
 427         (WebCore::FrameLoader::reload): Ditto.
 428         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
 429         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
 430         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
 431         (WebCore::FrameLoader::post): Ditto.
 432
 433         * loader/NavigationAction.h: Added.
 434         * loader/NavigationAction.cpp: Added.
 435         * loader/mac/NavigationActionMac.mm: Added.
 436
 437         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
 438
 439         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
 440         * WebCore.exp: Updated.
 441
 442 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
 443
 444         Reviewed by Adam.
 445
 446         Build fix
 447
 448         * platform/win/CookieJarWin.cpp:
 449         (WebCore::cookies):
 450
 451 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
 452
 453         Reviewed by Maciej. Landed by Adam.
 454
 455         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
 456
 457         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
 458         as dicussed with Dave. Also kill the outdated DESIGN document.
 459
 460         * CMakeLists.txt:
 461         * WebCore.xcodeproj/project.pbxproj:
 462         * kcanvas/DESIGN: Removed.
 463         * kcanvas/KCanvasFilters.cpp:
 464         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
 465         * kcanvas/KCanvasTreeDebug.h: Ditto.
 466         * kcanvas/device/KRenderingPaintServerGradient.cpp:
 467         * kcanvas/device/KRenderingPaintServerPattern.cpp:
 468         * kcanvas/device/KRenderingPaintServerSolid.cpp:
 469         * platform/graphics/svg/SVGResourceClipper.cpp:
 470         * rendering/RenderTreeAsText.cpp:
 471         * rendering/SVGRenderTreeAsText.cpp: Added.
 472         * rendering/SVGRenderTreeAsText.h: Added.
 473         (WebCore::operator<<):
 474
 475 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
 476
 477         Reviewed by Maciej.
 478
 479         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
 480         Includes some CRLF -> LF fixups.
 481
 482         * platform/win/CookieJarWin.cpp:
 483         (WebCore::cookies):
 484
 485 2006-10-31  Adam Roben  <aroben@apple.com>
 486
 487         Reviewed by Steve.
 488
 489         Fix some incorrect forward declarations.
 490
 491         * loader/FrameLoader.h:
 492         * page/Frame.h:
 493
 494 2006-10-31  Darin Adler  <darin@apple.com>
 495
 496         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
 497         try to fix the build on the buildbot.
 498
 499 2006-10-31  Darin Adler  <darin@apple.com>
 500
 501         * bridge/mac/FrameMac.mm:
 502         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
 503         (WebCore::FrameMac::markMisspellings): Ditto.
 504
 505 2006-10-31  John Sullivan  <sullivan@apple.com>
 506
 507         * bridge/mac/FrameMac.mm:
 508         (WebCore::FrameMac::advanceToNextMisspelling):
 509         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
 510
 511 2006-10-30  John Sullivan  <sullivan@apple.com>
 512
 513         Reviewed by Adam Roben
 514
 515         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
 516
 517         This patch introduces much of the guts of grammar checking, though still not enough to actually
 518         check grammar sensibly, due to:
 519
 520         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient
 521         context passed to grammar checker
 522
 523         * platform/Logging.h:
 524         * platform/Logging.cpp:
 525         new log channel SpellingAndGrammar
 526
 527         * bridge/mac/WebCorePageBridge.mm:
 528         (initializeLoggingChannelsIfNecessary):
 529         initialize new log channel
 530
 531         * bridge/mac/FrameMac.mm:
 532         (WebCore::FrameMac::advanceToNextMisspelling):
 533         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
 534         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
 535         in the event of a tie), and do further processing with that one (select range; create marker that
 536         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
 537         (WebCore::FrameMac::markMisspellings):
 538         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just
 539         differently enough to make sharing code between these two functions a little tricky, so I decided to
 540         save that for a later patch.
 541
 542         (WebCore::FrameMac::respondToChangedSelection):
 543         remove grammar markers when we remove spelling markers
 544
 545 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
 546
 547         Reviewed by Mitz.
 548
 549         Fix Qt/Linux build with older gcc3.3.4.
 550
 551         * bindings/js/kjs_window.cpp:
 552         (KJS::WindowFunc::callAsFunction):
 553
 554 2006-10-31  Zack Rusin  <zack@kde.org>
 555
 556         Reviewed by Mitz.
 557
 558         Fix the Qt build after last nights changes.
 559
 560         * WebCore/platform/qt/FrameQt.cpp:
 561         * WebCore/platform/qt/EditorClientQt.h:
 562         * WebCore/platform/qt/EditorClientQt.cpp:
 563         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
 564         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
 565         * WebCore/CMakeLists.txt:
 566         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
 567         * WebKitQt/QtLauncher/CMakeLists.txt:
 568         * WebKitQt/WebKitPart/CMakeLists.txt:
 569
 570 2006-10-30  Darin Adler  <darin@apple.com>
 571
 572         Reviewed by Anders.
 573
 574         - remove BrowserExtension
 575
 576         * WebCore.vcproj/WebCore/WebCore.vcproj:
 577         * WebCore.xcodeproj/project.pbxproj:
 578         * bindings/js/kjs_window.cpp:
 579         (KJS::createNewWindow):
 580         (KJS::WindowFunc::callAsFunction):
 581         * bridge/BrowserExtension.h: Removed.
 582         * bridge/mac/BrowserExtensionMac.h: Removed.
 583         * bridge/mac/BrowserExtensionMac.mm: Removed.
 584         * bridge/mac/FrameMac.mm:
 585         (WebCore::FrameMac::FrameMac):
 586         (WebCore::FrameMac::submitForm):
 587         (WebCore::FrameMac::urlSelected):
 588         * bridge/win/BrowserExtensionWin.cpp: Removed.
 589         * bridge/win/BrowserExtensionWin.h: Removed.
 590         * bridge/win/FrameWin.cpp:
 591         (WebCore::FrameWin::FrameWin):
 592         * loader/FrameLoader.cpp:
 593         (WebCore::FrameLoader::createWindow):
 594         * loader/FrameLoader.h:
 595         * loader/icon/IconLoader.cpp:
 596         * loader/mac/FrameLoaderMac.mm:
 597         (WebCore::FrameLoader::safeLoad):
 598         (WebCore::FrameLoader::load):
 599         (WebCore::FrameLoader::createWindow):
 600         * page/Frame.cpp:
 601         (WebCore::Frame::urlSelected):
 602         (WebCore::Frame::requestFrame):
 603         (WebCore::Frame::submitForm):
 604         (WebCore::Frame::scheduleHistoryNavigation):
 605         (WebCore::Frame::redirectionTimerFired):
 606         * page/Frame.h:
 607         * page/FrameLoadRequest.h:
 608         (WebCore::FrameLoadRequest::FrameLoadRequest):
 609         (WebCore::FrameLoadRequest::isEmpty):
 610         (WebCore::FrameLoadRequest::resourceRequest):
 611         (WebCore::FrameLoadRequest::frameName):
 612         (WebCore::FrameLoadRequest::setFrameName):
 613         * page/FramePrivate.h:
 614         (WebCore::FramePrivate::FramePrivate):
 615         (WebCore::FramePrivate::~FramePrivate):
 616         * platform/gdk/BrowserExtensionGdk.h: Removed.
 617         * platform/gdk/FrameGdk.cpp:
 618         (WebCore::FrameGdk::FrameGdk):
 619         * platform/gdk/TemporaryLinkStubs.cpp:
 620         * platform/network/ResourceRequest.h:
 621         (WebCore::ResourceRequest::isEmpty):
 622
 623 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
 624
 625         Reviewed by Oliver.
 626
 627         Modified from original due to earlier reversion
 628
 629         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
 630
 631         Better SVG integration in WebKit, Part I.
 632
 633         The patch is mostly about creating a new platform/graphics directory, and
 634         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
 635         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
 636         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
 637
 638         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
 639         All details of the patch, and upcoming patches can be found in the bug report.
 640
 641         * CMakeLists.txt:
 642         * WebCore.xcodeproj/project.pbxproj:
 643         * graphics/svg/SVGResource.cpp: Removed.
 644         * graphics/svg/SVGResourceClipper.cpp: Removed.
 645         * graphics/svg/SVGResourceClipper.h: Removed.
 646         * graphics/svg/SVGResourceImage.h: Removed.
 647         * graphics/svg/SVGResourceListener.h: Removed.
 648         * graphics/svg/SVGResourceMarker.cpp: Removed.
 649         * graphics/svg/SVGResourceMarker.h: Removed.
 650         * graphics/svg/SVGResourceMasker.cpp: Removed.
 651         * graphics/svg/SVGResourceMasker.h: Removed.
 652         * kcanvas/KCanvasClipper.cpp: Removed.
 653         * kcanvas/KCanvasClipper.h: Removed.
 654         * kcanvas/KCanvasCreator.cpp: Removed.
 655         * kcanvas/KCanvasCreator.h: Removed.
 656         * kcanvas/KCanvasFilters.cpp:
 657         (WebCore::getFilterById):
 658         * kcanvas/KCanvasFilters.h:
 659         * kcanvas/KCanvasImage.h: Removed.
 660         * kcanvas/KCanvasMarker.cpp: Removed.
 661         * kcanvas/KCanvasMarker.h: Removed.
 662         * kcanvas/KCanvasMasker.cpp: Removed.
 663         * kcanvas/KCanvasMasker.h: Removed.
 664         * kcanvas/KCanvasResource.cpp: Removed.
 665         * kcanvas/KCanvasResource.h: Removed.
 666         * kcanvas/KCanvasResourceListener.h: Removed.
 667         * kcanvas/KCanvasTreeDebug.cpp:
 668         (WebCore::writeRenderResources):
 669         * kcanvas/device/KRenderingDevice.h:
 670         * kcanvas/device/KRenderingPaintServer.h:
 671         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
 672         * kcanvas/device/KRenderingPaintServerGradient.cpp:
 673         (WebCore::KRenderingPaintServerGradient::listener):
 674         (WebCore::KRenderingPaintServerGradient::setListener):
 675         * kcanvas/device/KRenderingPaintServerGradient.h:
 676         * kcanvas/device/KRenderingPaintServerPattern.cpp:
 677         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
 678         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
 679         (WebCore::KRenderingPaintServerPattern::tile):
 680         (WebCore::KRenderingPaintServerPattern::setTile):
 681         (WebCore::KRenderingPaintServerPattern::listener):
 682         (WebCore::KRenderingPaintServerPattern::setListener):
 683         * kcanvas/device/KRenderingPaintServerPattern.h:
 684         * kcanvas/device/KRenderingPaintServerSolid.h:
 685         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
 686         * kcanvas/device/qt/KCanvasClipperQt.h:
 687         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
 688         (WebCore::KRenderingDeviceQt::contextForImage):
 689         (WebCore::KRenderingDeviceQt::createResource):
 690         (WebCore::KRenderingDeviceQt::createPaintServer):
 691         * kcanvas/device/qt/KRenderingDeviceQt.h:
 692         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
 693         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
 694         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
 695         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
 696         * kcanvas/device/qt/RenderPathQt.h: Removed.
 697         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
 698         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
 699         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
 700         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
 701         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
 702         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
 703         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
 704         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
 705         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
 706         (WebCore::KRenderingDeviceQuartz::contextForImage):
 707         (WebCore::KRenderingDeviceQuartz::createPaintServer):
 708         (WebCore::KRenderingDeviceQuartz::createResource):
 709         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
 710         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
 711         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
 712         (WebCore::KRenderingPaintServerGradientQuartz::setup):
 713         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
 714         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
 715         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
 716         (WebCore::patternCallback):
 717         (WebCore::KRenderingPaintServerPatternQuartz::setup):
 718         * kcanvas/device/quartz/QuartzSupport.mm:
 719         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 720         (WebCore::sharedSolidPaintServer):
 721         * ksvg2/svg/SVGClipPathElement.cpp:
 722         (WebCore::SVGClipPathElement::SVGClipPathElement):
 723         (WebCore::SVGClipPathElement::~SVGClipPathElement):
 724         (WebCore::SVGClipPathElement::canvasResource):
 725         * ksvg2/svg/SVGClipPathElement.h:
 726         * ksvg2/svg/SVGFEImageElement.cpp:
 727         * ksvg2/svg/SVGFilterElement.cpp:
 728         (WebCore::SVGFilterElement::SVGFilterElement):
 729         (WebCore::SVGFilterElement::~SVGFilterElement):
 730         (WebCore::SVGFilterElement::canvasResource):
 731         * ksvg2/svg/SVGFilterElement.h:
 732         * ksvg2/svg/SVGGradientElement.cpp:
 733         (WebCore::SVGGradientElement::SVGGradientElement):
 734         (WebCore::SVGGradientElement::~SVGGradientElement):
 735         (WebCore::SVGGradientElement::canvasResource):
 736         (WebCore::SVGGradientElement::resourceNotification):
 737         * ksvg2/svg/SVGGradientElement.h:
 738         * ksvg2/svg/SVGImageElement.cpp:
 739         * ksvg2/svg/SVGLinearGradientElement.cpp:
 740         (WebCore::SVGLinearGradientElement::buildGradient):
 741         * ksvg2/svg/SVGLinearGradientElement.h:
 742         * ksvg2/svg/SVGMarkerElement.cpp:
 743         (WebCore::SVGMarkerElement::SVGMarkerElement):
 744         (WebCore::SVGMarkerElement::~SVGMarkerElement):
 745         (WebCore::SVGMarkerElement::canvasResource):
 746         * ksvg2/svg/SVGMarkerElement.h:
 747         * ksvg2/svg/SVGMaskElement.cpp:
 748         (WebCore::SVGMaskElement::SVGMaskElement):
 749         (WebCore::SVGMaskElement::~SVGMaskElement):
 750         (WebCore::SVGMaskElement::drawMaskerContent):
 751         (WebCore::SVGMaskElement::canvasResource):
 752         * ksvg2/svg/SVGMaskElement.h:
 753         * ksvg2/svg/SVGPatternElement.cpp:
 754         (WebCore::SVGPatternElement::SVGPatternElement):
 755         (WebCore::SVGPatternElement::~SVGPatternElement):
 756         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
 757         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
 758         (WebCore::SVGPatternElement::canvasResource):
 759         * ksvg2/svg/SVGPatternElement.h:
 760         * ksvg2/svg/SVGRadialGradientElement.cpp:
 761         (WebCore::SVGRadialGradientElement::buildGradient):
 762         * ksvg2/svg/SVGRadialGradientElement.h:
 763         * ksvg2/svg/SVGStyledElement.h:
 764         (WebCore::SVGStyledElement::canvasResource):
 765         * platform/GraphicsContext.cpp: Removed.
 766         * platform/GraphicsContext.h: Removed.
 767         * platform/GraphicsTypes.cpp: Removed.
 768         * platform/GraphicsTypes.h: Removed.
 769         * platform/graphics/GraphicsContext.cpp:
 770         (WebCore::GraphicsContextState::GraphicsContextState):
 771         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
 772         (WebCore::GraphicsContext::createGraphicsContextPrivate):
 773         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
 774         (WebCore::GraphicsContext::save):
 775         (WebCore::GraphicsContext::restore):
 776         (WebCore::GraphicsContext::font):
 777         (WebCore::GraphicsContext::setFont):
 778         (WebCore::GraphicsContext::pen):
 779         (WebCore::GraphicsContext::setPen):
 780         (WebCore::GraphicsContext::setFillColor):
 781         (WebCore::GraphicsContext::fillColor):
 782         (WebCore::GraphicsContext::updatingControlTints):
 783         (WebCore::GraphicsContext::setUpdatingControlTints):
 784         (WebCore::GraphicsContext::setPaintingDisabled):
 785         (WebCore::GraphicsContext::paintingDisabled):
 786         (WebCore::GraphicsContext::drawImage):
 787         (WebCore::GraphicsContext::drawText):
 788         (WebCore::GraphicsContext::drawHighlightForText):
 789         (WebCore::GraphicsContext::initFocusRing):
 790         (WebCore::GraphicsContext::clearFocusRing):
 791         (WebCore::GraphicsContext::focusRingBoundingRect):
 792         (WebCore::GraphicsContext::addFocusRingRect):
 793         (WebCore::GraphicsContext::focusRingWidth):
 794         (WebCore::GraphicsContext::focusRingOffset):
 795         (WebCore::GraphicsContext::focusRingRects):
 796         (WebCore::GraphicsContext::drawTiledImage):
 797         * platform/graphics/GraphicsContext.h:
 798         * platform/graphics/GraphicsTypes.cpp:
 799         (WebCore::):
 800         (WebCore::parseCompositeOperator):
 801         (WebCore::compositeOperatorName):
 802         (WebCore::parseLineCap):
 803         (WebCore::lineCapName):
 804         (WebCore::parseLineJoin):
 805         (WebCore::lineJoinName):
 806         * platform/graphics/GraphicsTypes.h:
 807         (WebCore::):
 808         * platform/graphics/svg/SVGResource.cpp: Added.
 809         (WebCore::SVGResource::SVGResource):
 810         (WebCore::SVGResource::~SVGResource):
 811         (WebCore::SVGResource::invalidate):
 812         (WebCore::SVGResource::addClient):
 813         (WebCore::SVGResource::clients):
 814         (WebCore::SVGResource::idInRegistry):
 815         (WebCore::SVGResource::setIdInRegistry):
 816         (WebCore::SVGResource::externalRepresentation):
 817         (WebCore::getResourceById):
 818         (WebCore::getPaintServerById):
 819         (WebCore::operator<<):
 820         * platform/graphics/svg/SVGResource.h: Added.
 821         (WebCore::):
 822         (WebCore::SVGResource::isPaintServer):
 823         (WebCore::SVGResource::isFilter):
 824         (WebCore::SVGResource::isClipper):
 825         (WebCore::SVGResource::isMarker):
 826         (WebCore::SVGResource::isMasker):
 827         (WebCore::SVGResourceListener::~SVGResourceListener):
 828         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
 829         (WebCore::SVGResourceClipper::SVGResourceClipper):
 830         (WebCore::SVGResourceClipper::~SVGResourceClipper):
 831         (WebCore::SVGResourceClipper::resetClipData):
 832         (WebCore::SVGResourceClipper::addClipData):
 833         (WebCore::SVGResourceClipper::clipData):
 834         (WebCore::SVGResourceClipper::externalRepresentation):
 835         (WebCore::operator<<):
 836         (WebCore::getClipperById):
 837         * platform/graphics/svg/SVGResourceClipper.h: Added.
 838         (WebCore::ClipDataList::addPath):
 839         (WebCore::SVGResourceClipper::isClipper):
 840         * platform/graphics/svg/SVGResourceImage.h: Added.
 841         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
 842         (WebCore::SVGResourceMarker::SVGResourceMarker):
 843         (WebCore::SVGResourceMarker::~SVGResourceMarker):
 844         (WebCore::SVGResourceMarker::setMarker):
 845         (WebCore::SVGResourceMarker::setRef):
 846         (WebCore::SVGResourceMarker::draw):
 847         (WebCore::SVGResourceMarker::externalRepresentation):
 848         (WebCore::getMarkerById):
 849         * platform/graphics/svg/SVGResourceMarker.h: Added.
 850         (WebCore::SVGResourceMarker::refX):
 851         (WebCore::SVGResourceMarker::refY):
 852         (WebCore::SVGResourceMarker::setAngle):
 853         (WebCore::SVGResourceMarker::setAutoAngle):
 854         (WebCore::SVGResourceMarker::angle):
 855         (WebCore::SVGResourceMarker::setUseStrokeWidth):
 856         (WebCore::SVGResourceMarker::useStrokeWidth):
 857         (WebCore::SVGResourceMarker::isMarker):
 858         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
 859         (WebCore::SVGResourceMasker::SVGResourceMasker):
 860         (WebCore::SVGResourceMasker::~SVGResourceMasker):
 861         (WebCore::SVGResourceMasker::setMask):
 862         (WebCore::SVGResourceMasker::mask):
 863         (WebCore::SVGResourceMasker::externalRepresentation):
 864         (WebCore::getMaskerById):
 865         * platform/graphics/svg/SVGResourceMasker.h: Added.
 866         (WebCore::SVGResourceMasker::isMasker):
 867         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
 868         (WebCore::SVGResourceClipper::applyClip):
 869         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
 870         (WebCore::SVGResourceImage::SVGResourceImage):
 871         (WebCore::SVGResourceImage::~SVGResourceImage):
 872         (WebCore::SVGResourceImage::init):
 873         (WebCore::SVGResourceImage::size):
 874         (WebCore::SVGResourceImage::cgLayer):
 875         (WebCore::SVGResourceImage::setCGLayer):
 876         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
 877         (WebCore::applyLuminanceToAlphaFilter):
 878         (WebCore::applyExpandAlphatoGrayscaleFilter):
 879         (WebCore::transformImageIntoGrayscaleMask):
 880         (WebCore::SVGResourceMasker::applyMask):
 881         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
 882         (WebCore::SVGResourceClipper::applyClip):
 883         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
 884         (WebCore::SVGResourceImage::init):
 885         (WebCore::SVGResourceImage::size):
 886         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
 887         (WebCore::SVGResourceMasker::applyMask):
 888         * platform/qt/GraphicsContextQt.cpp:
 889         * rendering/RenderPath.cpp:
 890         (WebCore::RenderPath::paint):
 891         (WebCore::DrawMarkersData::DrawMarkersData):
 892         (WebCore::RenderPath::drawMarkersIfNeeded):
 893         * rendering/RenderSVGContainer.cpp:
 894         (WebCore::RenderSVGContainer::paint):
 895         * rendering/RenderSVGImage.cpp:
 896         (WebCore::RenderSVGImage::paint):
 897         * rendering/SVGInlineFlowBox.cpp:
 898         (WebCore::paintSVGInlineFlow):
 899
 900 2006-10-30  John Sullivan  <sullivan@apple.com>
 901
 902         Reviewed by Brady
 903
 904         - minor cleanup to make future patches clearer
 905
 906         * bridge/mac/FrameMac.mm:
 907         (WebCore::FrameMac::advanceToNextMisspelling):
 908         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
 909         with "continue" to better match structure of similar code in markMisspellings; a few
 910         other style tweaks.
 911
 912         (WebCore::FrameMac::markMisspellings):
 913         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
 914         a block just after a break and outdented accordingly.
 915
 916 2006-10-30  John Sullivan  <sullivan@apple.com>
 917
 918         Reviewed by Geoff Garen
 919
 920         WebCore part of change to push the code that updates the spelling panel
 921         into WebCore, in preparation for some grammar-checking stuff.
 922
 923         * bridge/mac/FrameMac.h:
 924         * bridge/mac/FrameMac.mm:
 925         (WebCore::FrameMac::advanceToNextMisspelling):
 926         no more return value for this method, and update the spelling panel with
 927         the misspelled word here rather than in the WebKit callers.
 928
 929 2006-10-30  Oliver Hunt  <oliver@apple.com>
 930
 931         Reviewed by Anders.
 932
 933         Roll out last patch
 934
 935         * CMakeLists.txt:
 936         * ChangeLog:
 937         * WebCore.xcodeproj/project.pbxproj:
 938         * graphics/svg/SVGResource.cpp:
 939         * graphics/svg/SVGResourceClipper.cpp:
 940         * graphics/svg/SVGResourceClipper.h:
 941         * graphics/svg/SVGResourceImage.h:
 942         * graphics/svg/SVGResourceListener.h:
 943         * graphics/svg/SVGResourceMarker.cpp:
 944         * graphics/svg/SVGResourceMarker.h:
 945         * graphics/svg/SVGResourceMasker.cpp:
 946         * graphics/svg/SVGResourceMasker.h:
 947         * kcanvas/KCanvasClipper.cpp: Added.
 948         (WebCore::operator<<):
 949         (WebCore::KCanvasClipper::KCanvasClipper):
 950         (WebCore::KCanvasClipper::~KCanvasClipper):
 951         (WebCore::KCanvasClipper::resetClipData):
 952         (WebCore::KCanvasClipper::addClipData):
 953         (WebCore::KCanvasClipper::clipData):
 954         (WebCore::KCanvasClipper::externalRepresentation):
 955         (WebCore::getClipperById):
 956         * kcanvas/KCanvasClipper.h: Added.
 957         (WebCore::KCClipData::windRule):
 958         (WebCore::KCClipDataList::KCClipDataList):
 959         (WebCore::KCClipDataList::addPath):
 960         (WebCore::KCanvasClipper::isClipper):
 961         * kcanvas/KCanvasFilters.cpp:
 962         (WebCore::getFilterById):
 963         * kcanvas/KCanvasFilters.h:
 964         * kcanvas/KCanvasImage.h: Added.
 965         (WebCore::KCanvasImage::KCanvasImage):
 966         (WebCore::KCanvasImage::~KCanvasImage):
 967         * kcanvas/KCanvasMarker.cpp: Added.
 968         (WebCore::KCanvasMarker::KCanvasMarker):
 969         (WebCore::KCanvasMarker::~KCanvasMarker):
 970         (WebCore::KCanvasMarker::setMarker):
 971         (WebCore::KCanvasMarker::setRef):
 972         (WebCore::KCanvasMarker::refX):
 973         (WebCore::KCanvasMarker::refY):
 974         (WebCore::KCanvasMarker::setAngle):
 975         (WebCore::KCanvasMarker::angle):
 976         (WebCore::KCanvasMarker::setAutoAngle):
 977         (WebCore::KCanvasMarker::setUseStrokeWidth):
 978         (WebCore::KCanvasMarker::useStrokeWidth):
 979         (WebCore::KCanvasMarker::draw):
 980         (WebCore::KCanvasMarker::externalRepresentation):
 981         (WebCore::getMarkerById):
 982         * kcanvas/KCanvasMarker.h: Added.
 983         (WebCore::KCanvasMarker::isMarker):
 984         * kcanvas/KCanvasMasker.cpp: Added.
 985         (WebCore::KCanvasMasker::KCanvasMasker):
 986         (WebCore::KCanvasMasker::~KCanvasMasker):
 987         (WebCore::KCanvasMasker::setMask):
 988         (WebCore::KCanvasMasker::externalRepresentation):
 989         (WebCore::getMaskerById):
 990         * kcanvas/KCanvasMasker.h: Added.
 991         (WebCore::KCanvasMasker::isMasker):
 992         (WebCore::KCanvasMasker::mask):
 993         * kcanvas/KCanvasResource.cpp: Added.
 994         (WebCore::operator<<):
 995         (WebCore::KCanvasResource::KCanvasResource):
 996         (WebCore::KCanvasResource::~KCanvasResource):
 997         (WebCore::KCanvasResource::addClient):
 998         (WebCore::KCanvasResource::clients):
 999         (WebCore::KCanvasResource::invalidate):
1000         (WebCore::KCanvasResource::idInRegistry):
1001         (WebCore::KCanvasResource::setIdInRegistry):
1002         (WebCore::KCanvasResource::externalRepresentation):
1003         (WebCore::getResourceById):
1004         (WebCore::getPaintServerById):
1005         * kcanvas/KCanvasResource.h:
1006         (WebCore::):
1007         (WebCore::KCanvasResource::isPaintServer):
1008         (WebCore::KCanvasResource::isFilter):
1009         (WebCore::KCanvasResource::isClipper):
1010         (WebCore::KCanvasResource::isMarker):
1011         (WebCore::KCanvasResource::isMasker):
1012         * kcanvas/KCanvasResourceListener.h: Added.
1013         (KCanvasResourceListener::KCanvasResourceListener):
1014         (KCanvasResourceListener::~KCanvasResourceListener):
1015         * kcanvas/KCanvasTreeDebug.cpp:
1016         (WebCore::writeRenderResources):
1017         * kcanvas/device/KRenderingDevice.h:
1018         * kcanvas/device/KRenderingPaintServer.h:
1019         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1020         (WebCore::KRenderingPaintServer::idInRegistry):
1021         (WebCore::KRenderingPaintServer::setIdInRegistry):
1022         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1023         (WebCore::KRenderingPaintServerGradient::listener):
1024         (WebCore::KRenderingPaintServerGradient::setListener):
1025         * kcanvas/device/KRenderingPaintServerGradient.h:
1026         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1027         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1028         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1029         (WebCore::KRenderingPaintServerPattern::tile):
1030         (WebCore::KRenderingPaintServerPattern::setTile):
1031         (WebCore::KRenderingPaintServerPattern::listener):
1032         (WebCore::KRenderingPaintServerPattern::setListener):
1033         * kcanvas/device/KRenderingPaintServerPattern.h:
1034         * kcanvas/device/KRenderingPaintServerSolid.h:
1035         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1036         (WebCore::KCanvasClipperQt::applyClip):
1037         * kcanvas/device/qt/KCanvasClipperQt.h:
1038         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1039         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1040         (WebCore::KRenderingDeviceQt::contextForImage):
1041         (WebCore::KRenderingDeviceQt::createResource):
1042         (WebCore::KRenderingDeviceQt::createPaintServer):
1043         * kcanvas/device/qt/KRenderingDeviceQt.h:
1044         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1045         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1046         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1047         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1048         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1049         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1050         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1051         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1052         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1053         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1054         (WebCore::applyLuminanceToAlphaFilter):
1055         (WebCore::applyExpandAlphatoGrayscaleFilter):
1056         (WebCore::transformImageIntoGrayscaleMask):
1057         (WebCore::KCanvasMaskerQuartz::applyMask):
1058         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1059         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1060         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1061         (WebCore::KCanvasImageQuartz::init):
1062         (WebCore::KCanvasImageQuartz::size):
1063         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1064         (WebCore::KCanvasClipperQuartz::applyClip):
1065         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1066         (WebCore::KCanvasImageQuartz::cgLayer):
1067         (WebCore::KCanvasImageQuartz::setCGLayer):
1068         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1069         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1070         (WebCore::KRenderingDeviceQuartz::contextForImage):
1071         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1072         (WebCore::KRenderingDeviceQuartz::createResource):
1073         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1074         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1075         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1076         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1077         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1078         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1079         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1080         (WebCore::patternCallback):
1081         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1082         * kcanvas/device/quartz/QuartzSupport.mm:
1083         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1084         (WebCore::sharedSolidPaintServer):
1085         * ksvg2/svg/SVGClipPathElement.cpp:
1086         (WebCore::SVGClipPathElement::SVGClipPathElement):
1087         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1088         (WebCore::SVGClipPathElement::canvasResource):
1089         * ksvg2/svg/SVGClipPathElement.h:
1090         * ksvg2/svg/SVGFEImageElement.cpp:
1091         * ksvg2/svg/SVGFilterElement.cpp:
1092         (WebCore::SVGFilterElement::SVGFilterElement):
1093         (WebCore::SVGFilterElement::~SVGFilterElement):
1094         (WebCore::SVGFilterElement::canvasResource):
1095         * ksvg2/svg/SVGFilterElement.h:
1096         * ksvg2/svg/SVGGradientElement.cpp:
1097         (WebCore::SVGGradientElement::SVGGradientElement):
1098         (WebCore::SVGGradientElement::~SVGGradientElement):
1099         (WebCore::SVGGradientElement::canvasResource):
1100         (WebCore::SVGGradientElement::resourceNotification):
1101         * ksvg2/svg/SVGGradientElement.h:
1102         * ksvg2/svg/SVGImageElement.cpp:
1103         * ksvg2/svg/SVGLinearGradientElement.cpp:
1104         (WebCore::SVGLinearGradientElement::buildGradient):
1105         * ksvg2/svg/SVGLinearGradientElement.h:
1106         * ksvg2/svg/SVGMarkerElement.cpp:
1107         (WebCore::SVGMarkerElement::SVGMarkerElement):
1108         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1109         (WebCore::SVGMarkerElement::canvasResource):
1110         * ksvg2/svg/SVGMarkerElement.h:
1111         * ksvg2/svg/SVGMaskElement.cpp:
1112         (WebCore::SVGMaskElement::SVGMaskElement):
1113         (WebCore::SVGMaskElement::~SVGMaskElement):
1114         (WebCore::SVGMaskElement::drawMaskerContent):
1115         (WebCore::SVGMaskElement::canvasResource):
1116         * ksvg2/svg/SVGMaskElement.h:
1117         * ksvg2/svg/SVGPatternElement.cpp:
1118         (WebCore::SVGPatternElement::SVGPatternElement):
1119         (WebCore::SVGPatternElement::~SVGPatternElement):
1120         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1121         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1122         (WebCore::SVGPatternElement::canvasResource):
1123         * ksvg2/svg/SVGPatternElement.h:
1124         * ksvg2/svg/SVGRadialGradientElement.cpp:
1125         (WebCore::SVGRadialGradientElement::buildGradient):
1126         * ksvg2/svg/SVGRadialGradientElement.h:
1127         * ksvg2/svg/SVGStyledElement.h:
1128         (WebCore::SVGStyledElement::canvasResource):
1129         * platform/GraphicsContext.cpp: Added.
1130         (WebCore::GraphicsContextState::GraphicsContextState):
1131         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1132         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1133         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1134         (WebCore::GraphicsContext::save):
1135         (WebCore::GraphicsContext::restore):
1136         (WebCore::GraphicsContext::font):
1137         (WebCore::GraphicsContext::setFont):
1138         (WebCore::GraphicsContext::pen):
1139         (WebCore::GraphicsContext::setPen):
1140         (WebCore::GraphicsContext::setFillColor):
1141         (WebCore::GraphicsContext::fillColor):
1142         (WebCore::GraphicsContext::updatingControlTints):
1143         (WebCore::GraphicsContext::setUpdatingControlTints):
1144         (WebCore::GraphicsContext::setPaintingDisabled):
1145         (WebCore::GraphicsContext::paintingDisabled):
1146         (WebCore::GraphicsContext::drawImage):
1147         (WebCore::GraphicsContext::drawText):
1148         (WebCore::GraphicsContext::drawHighlightForText):
1149         (WebCore::GraphicsContext::initFocusRing):
1150         (WebCore::GraphicsContext::clearFocusRing):
1151         (WebCore::GraphicsContext::focusRingBoundingRect):
1152         (WebCore::GraphicsContext::addFocusRingRect):
1153         (WebCore::GraphicsContext::focusRingWidth):
1154         (WebCore::GraphicsContext::focusRingOffset):
1155         (WebCore::GraphicsContext::focusRingRects):
1156         (WebCore::GraphicsContext::drawTiledImage):
1157         * platform/GraphicsContext.h: Added.
1158         * platform/GraphicsTypes.cpp: Added.
1159         (WebCore::):
1160         (WebCore::parseCompositeOperator):
1161         (WebCore::compositeOperatorName):
1162         (WebCore::parseLineCap):
1163         (WebCore::lineCapName):
1164         (WebCore::parseLineJoin):
1165         (WebCore::lineJoinName):
1166         * platform/GraphicsTypes.h: Added.
1167         (WebCore::):
1168         * platform/graphics/GraphicsContext.cpp:
1169         * platform/graphics/GraphicsContext.h:
1170         * platform/graphics/GraphicsTypes.cpp:
1171         * platform/graphics/GraphicsTypes.h:
1172         * platform/qt/GraphicsContextQt.cpp:
1173         * rendering/RenderPath.cpp:
1174         (WebCore::RenderPath::paint):
1175         (WebCore::DrawMarkersData::DrawMarkersData):
1176         (WebCore::RenderPath::drawMarkersIfNeeded):
1177         * rendering/RenderSVGContainer.cpp:
1178         (WebCore::RenderSVGContainer::paint):
1179         * rendering/RenderSVGImage.cpp:
1180         (WebCore::RenderSVGImage::paint):
1181         * rendering/SVGInlineFlowBox.cpp:
1182         (WebCore::paintSVGInlineFlow):
1183
1184 2006-10-30  John Sullivan  <sullivan@apple.com>
1185
1186         Reviewed by Geoff Garen.
1187
1188         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1189         grammar-related method.
1190
1191         * bridge/EditorClient.h:
1192         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1193         isGrammarCheckingEnabled()
1194
1195         * bridge/mac/WebCoreFrameBridge.h:
1196         removed bridge equivalents
1197
1198         * bridge/mac/FrameMac.mm:
1199         (WebCore::FrameMac::advanceToNextMisspelling):
1200         convert bridge-using code to editor()->client()-using code
1201         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1202         ditto
1203         (WebCore::FrameMac::markMisspellings):
1204         ditto
1205         (WebCore::FrameMac::respondToChangedSelection):
1206         ditto
1207
1208         * editing/Editor.h:
1209         * editing/Editor.cpp:
1210         (WebCore::Editor::client):
1211         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1212         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1213         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1214
1215 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1216
1217         Reviewed by Darin.
1218
1219         Removed a number of editing and selection methods from the bridge.
1220
1221         I moved cross-platform editing and selection code into Editor and
1222         SelectionController, respecitvely.
1223
1224         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1225         everything + the kitchen sink.
1226
1227         Specific comments below for interesting things.
1228
1229         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1230         a new file so that WebKit can use them, too. Added a helper method for
1231         handling exceptions when selecting a Range.
1232         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into
1233         WebKit, since they have to do with creating an NSAttributedString for API
1234         consumption, and not much to do with general Frame functionality.
1235         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1236         for now) into the Editor. Eventually, the Frame will not have to notify
1237         the Editor of what the lastEditCommand was, since the Editor will perform
1238         all EditCommands.
1239         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1240         * editing/SelectionController.cpp:
1241         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1242         and return them. The bridge method to select a DOM range did this implicitly,
1243         since all ObjC DOM operations handle DOM exceptions by throwing them as
1244         ObjC exceptions.
1245         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1246         The two enumerations are numerically identical, but that's an implementation
1247         detail of TextAffinity that clients shouldn't be required to know about.
1248
1249 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1250
1251         Rolling out the following change because this crash:
1252         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp)
1253
1254         And this regression:
1255         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1256
1257     2006-09-06  David Harrison  <harrison@apple.com>
1258
1259         Reviewed and tweaked by Tim H.
1260
1261         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation
1262
1263         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
1264         to trigger a search that will include auto activation. No PLT or iBench perf impact.
1265         No layout tests affected. Not testable in an automated way that will work on all systems.
1266
1267         * platform/mac/WebFontCache.mm:
1268         (+[WebFontCache fontWithFamily:traits:size:]):
1269
1270 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1271
1272         Reviewed by harrison
1273
1274         <rdar://problem/4808375>
1275         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1276
1277         * editing/TextIterator.cpp:
1278         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1279         when we're going to use them to create a range for an emitted character.
1280         We should further speed TextIterators up by avoiding creating VisiblePositions
1281         for TIs that are only used for the characters they emit (like the one that
1282         plainText uses).
1283
1284 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1285
1286         Reviewed by Mitz.
1287
1288         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1289         More rendering code cleaning
1290
1291         * WebCore.xcodeproj/project.pbxproj:
1292         * rendering/RenderApplet.cpp:
1293         (WebCore::RenderApplet::RenderApplet):
1294         (WebCore::RenderApplet::createWidgetIfNecessary):
1295         * rendering/RenderApplet.h:
1296         * rendering/RenderArena.cpp:
1297         (WebCore::):
1298         (WebCore::RenderArena::RenderArena):
1299         (WebCore::RenderArena::allocate):
1300         (WebCore::RenderArena::free):
1301         * rendering/RenderArena.h:
1302         * rendering/RenderBR.cpp:
1303         (WebCore::RenderBR::RenderBR):
1304         (WebCore::RenderBR::baselinePosition):
1305         (WebCore::RenderBR::lineHeight):
1306         (WebCore::RenderBR::setStyle):
1307         (WebCore::RenderBR::caretMinOffset):
1308         (WebCore::RenderBR::positionForCoordinates):
1309         (WebCore::RenderBR::inlineBox):
1310         * rendering/RenderBR.h:
1311         * rendering/RenderBlock.cpp:
1312         * rendering/RenderBlock.h:
1313         (WebCore::RenderBlock::maxTopMargin):
1314         (WebCore::RenderBlock::maxBottomMargin):
1315         (WebCore::RenderBlock::initMaxMarginValues):
1316         (WebCore::RenderBlock::containsFloats):
1317         (WebCore::RenderBlock::setHasMarkupTruncation):
1318         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1319         (WebCore::RenderBlock::BlockSelectionInfo::block):
1320         (WebCore::RenderBlock::BlockSelectionInfo::state):
1321         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1322         (WebCore::RenderBlock::CompactInfo::clear):
1323         * rendering/RenderButton.cpp:
1324         (WebCore::RenderButton::removeChild):
1325         (WebCore::RenderButton::paintObject):
1326         * rendering/RenderButton.h:
1327         (WebCore::RenderButton::renderName):
1328         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1329         * rendering/RenderContainer.cpp:
1330         (WebCore::RenderContainer::RenderContainer):
1331         * rendering/RenderContainer.h:
1332         (WebCore::RenderContainer::firstChild):
1333         (WebCore::RenderContainer::lastChild):
1334         (WebCore::RenderContainer::calcMinMaxWidth):
1335         * rendering/RenderCounter.cpp:
1336         (WebCore::RenderCounter::RenderCounter):
1337         (WebCore::toRoman):
1338         (WebCore::toHebrew):
1339         (WebCore::RenderCounter::calcMinMaxWidth):
1340         * rendering/RenderCounter.h:
1341         * rendering/RenderFieldset.cpp:
1342         (WebCore::RenderFieldset::paintBoxDecorations):
1343         (WebCore::RenderFieldset::paintBorderMinusLegend):
1344         (WebCore::RenderFieldset::setStyle):
1345         * rendering/RenderFileUploadControl.cpp:
1346         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1347         (WebCore::RenderFileUploadControl::setStyle):
1348         (WebCore::RenderFileUploadControl::paintObject):
1349         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1350         * rendering/RenderFileUploadControl.h:
1351         (WebCore::RenderFileUploadControl::renderName):
1352         * rendering/RenderFlexibleBox.h:
1353         * rendering/RenderFlow.cpp:
1354         * rendering/RenderFlow.h:
1355         * rendering/RenderForeignObject.cpp:
1356         (WebCore::RenderForeignObject::RenderForeignObject):
1357         (WebCore::RenderForeignObject::paint):
1358         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1359         (WebCore::RenderForeignObject::layout):
1360         (WebCore::RenderForeignObject::nodeAtPoint):
1361         * rendering/RenderForeignObject.h:
1362         (WebCore::RenderForeignObject::renderName):
1363         * rendering/RenderFormElement.cpp:
1364         (WebCore::RenderFormElement::setStyle):
1365         (WebCore::RenderFormElement::layout):
1366         (WebCore::RenderFormElement::textAlignment):
1367         * rendering/RenderFormElement.h:
1368         * rendering/RenderFrame.cpp:
1369         * rendering/RenderFrame.h:
1370         (WebCore::RenderFrame::element):
1371         * rendering/RenderFrameSet.cpp:
1372         * rendering/RenderFrameSet.h:
1373         (WebCore::RenderFrameSet::element):
1374         * rendering/RenderHTMLCanvas.cpp:
1375         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1376         (WebCore::RenderHTMLCanvas::paint):
1377         * rendering/RenderHTMLCanvas.h:
1378         (WebCore::RenderHTMLCanvas::renderName):
1379         * rendering/RenderImage.cpp:
1380         (WebCore::RenderImage::RenderImage):
1381         (WebCore::RenderImage::setStyle):
1382         (WebCore::RenderImage::setContentObject):
1383         (WebCore::RenderImage::setCachedImage):
1384         (WebCore::RenderImage::imageChanged):
1385         (WebCore::RenderImage::paint):
1386         (WebCore::RenderImage::layout):
1387         (WebCore::RenderImage::updateAltText):
1388         * rendering/RenderImage.h:
1389         (WebCore::RenderImage::element):
1390         * rendering/RenderInline.cpp:
1391         (WebCore::RenderInline::RenderInline):
1392         (WebCore::RenderInline::~RenderInline):
1393         (WebCore::RenderInline::setStyle):
1394         (WebCore::RenderInline::addChildToFlow):
1395         (WebCore::RenderInline::cloneInline):
1396         (WebCore::RenderInline::splitInlines):
1397         (WebCore::RenderInline::splitFlow):
1398         (WebCore::RenderInline::paint):
1399         (WebCore::RenderInline::absoluteRects):
1400         (WebCore::RenderInline::calcMinMaxWidth):
1401         (WebCore::RenderInline::requiresLayer):
1402         (WebCore::RenderInline::width):
1403         (WebCore::RenderInline::height):
1404         (WebCore::RenderInline::renderName):
1405         (WebCore::RenderInline::nodeAtPoint):
1406         (WebCore::RenderInline::positionForCoordinates):
1407         * rendering/RenderInline.h:
1408         (WebCore::RenderInline::layout):
1409         * rendering/RenderLayer.cpp:
1410         * rendering/RenderLayer.h:
1411         (WebCore::ClipRects::ClipRects):
1412         (WebCore::RenderLayer::nextSibling):
1413         (WebCore::RenderLayer::root):
1414         (WebCore::RenderLayer::setPos):
1415         (WebCore::RenderLayer::height):
1416         (WebCore::RenderLayer::relativePositionOffset):
1417         * rendering/RenderLineEdit.cpp:
1418         (WebCore::RenderLineEdit::setStyle):
1419         (WebCore::RenderLineEdit::updateFromElement):
1420         (WebCore::RenderLineEdit::selectionStart):
1421         (WebCore::RenderLineEdit::selectionEnd):
1422         (WebCore::RenderLineEdit::setSelectionStart):
1423         (WebCore::RenderLineEdit::setSelectionEnd):
1424         (WebCore::RenderLineEdit::setSelectionRange):
1425         * rendering/RenderLineEdit.h:
1426         * rendering/RenderListBox.cpp:
1427         * rendering/RenderListBox.h:
1428         (WebCore::RenderListBox::renderName):
1429         * rendering/RenderListItem.cpp:
1430         (WebCore::RenderListItem::setStyle):
1431         (WebCore::getParentOfFirstLineBox):
1432         (WebCore::RenderListItem::updateMarkerLocation):
1433         (WebCore::RenderListItem::positionListMarker):
1434         (WebCore::RenderListItem::paint):
1435         * rendering/RenderListItem.h:
1436         * rendering/RenderListMarker.cpp:
1437         * rendering/RenderListMarker.h:
1438         (WebCore::RenderListMarker::renderName):
1439         (WebCore::RenderListMarker::isListMarker):
1440
1441 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1442
1443         Reviewed by Hyatt.
1444
1445         <rdar://problem/4478625> Basic table editing and culling
1446
1447         Refined the criteria for deletable elements, rely on the renderer more.
1448         Corrected the interface positioning for elements that have borders.
1449
1450         * editing/DeleteButtonController.cpp:
1451         (WebCore::isDeletableElement):
1452         (WebCore::DeleteButtonController::show):
1453
1454 2006-10-30  Darin Adler  <darin@apple.com>
1455
1456         - fix build
1457
1458         * loader/ResourceLoader.h: Added header guard.
1459
1460 2006-10-31  Darin Adler  <darin@apple.com>
1461
1462         Reviewed by Adam.
1463
1464         - fix FrameLoader files so they can be built on non-Mac platforms
1465
1466         * page/FramePrivate.h:
1467         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1468         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1469
1470         * page/Page.h:
1471         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1472         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1473         the other day.
1474
1475         * bridge/mac/FrameMac.mm:
1476         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1477         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1478
1479         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1480         around the PolicyCheck definition.
1481
1482         * loader/FormState.cpp: Changed import to include.
1483         * loader/FrameLoader.cpp: Ditto.
1484         * loader/MainResourceLoader.h: Ditto.
1485
1486         * loader/FrameLoaderTypes.h: Added a header guard.
1487
1488         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1489         Added #if PLATFORM(MAC) around Mac-specific details.
1490         * loader/SubresourceLoader.h: Ditto.
1491
1492         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1493         m_loader from m_frameLoader.
1494
1495         * CMakeLists.txt: Updated.
1496         * WebCoreSources.bkl: Updated.
1497
1498 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1499
1500         Reviewed and landed by Anders.
1501
1502         Patch by Zack rusin to fix:
1503         http://bugs.webkit.org/show_bug.cgi?id=11429
1504
1505         Fix startup crash.
1506
1507         * platform/qt/FrameQtClient.cpp:
1508         (WebCore::FrameQtClientDefault::openURL):
1509
1510 2006-10-30  Zach Rusin  <zack@kde.org>
1511
1512         Reviewed and landed by Anders.
1513
1514         * platform/network/qt/ResourceHandleQt.cpp:
1515         (WebCore::ResourceHandle::receivedResponse):
1516         * platform/qt/FrameQtClient.cpp:
1517         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1518         * platform/qt/LoaderFunctionsQt.cpp:
1519         (WebCore::ServeSynchronousRequest):
1520         More build fixes.
1521
1522 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1523
1524         Reviewed and landed by Anders.
1525
1526         - fix Qt build
1527         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1528         ResourceHandleClient
1529
1530 2006-10-30  Darin Adler  <darin@apple.com>
1531
1532         Reviewed by John Sullivan.
1533
1534         - work toward removing Objective-C data types from FrameLoader.h:
1535           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1536           and WebCoreResourceHandle
1537         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
1538
1539         * page/PageState.h:
1540         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
1541
1542         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
1543         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
1544         double for the date instead of an NSDate.
1545
1546         * bridge/mac/WebCoreFrameBridge.h:
1547         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
1548         saveDocumentToPageCache methods.
1549
1550         * bridge/mac/WebCorePageState.h:
1551         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
1552         an Objective-C wrapper for PageState.
1553
1554         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
1555         NSDate and WebCorePageState.
1556         * loader/FrameLoaderClient.h: Changed NSDate to double.
1557         * loader/mac/FrameLoaderMac.mm:
1558         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
1559         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
1560         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
1561         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
1562         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
1563         extract the parameters from the response. Changed the open function that takes
1564         a PageState to use the new C++ PageState.
1565         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
1566         function; tightened up logic, removing a few cases that could never happen, as
1567         well as the unused reload boolean.
1568
1569         * ForwardingHeaders/kjs/property_map.h: Added.
1570
1571         * WebCore.exp: Updated.
1572         * WebCore.xcodeproj/project.pbxproj: Updated.
1573
1574 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1575
1576         Reviewed by Anders.
1577
1578         - added ResourceResponse class and didReceiveResponse delegate call
1579
1580         * WebCore.xcodeproj/project.pbxproj: Added new files.
1581         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1582         expiresTimeForResponse: method.
1583         * dom/XMLTokenizer.cpp:
1584         (WebCore::openFunc): Updated to use ResourceResponse.
1585         * loader/FrameLoader.h: Update loadResourceSynchronously to
1586         use ResourceResponse.
1587         * loader/LoaderFunctions.h:
1588         * loader/icon/IconLoader.cpp:
1589         (IconLoader::didReceiveResponse): Updated from receivedResponse
1590         and made cross-platform.
1591         * loader/icon/IconLoader.h: updated for above change
1592         * loader/loader.cpp:
1593         (WebCore::Loader::receivedResponse): reduced to just saving
1594         the PlatformResponse (ideally we'd phase out use of this).
1595         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse
1596         logic.
1597         * loader/loader.h:
1598         * loader/mac/FrameLoaderMac.mm:
1599         (WebCore::FrameLoader::loadResourceSynchronously): Return results
1600         as ResourceResponse.
1601         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
1602         * loader/mac/LoaderFunctionsMac.mm:
1603         (WebCore::ServeSynchronousRequest): take ResourceResponse as
1604         argument.
1605         * platform/network/ResourceHandle.cpp:
1606         * platform/network/ResourceHandle.h: Remove calls for
1607         broken out response pieces.
1608         * platform/network/ResourceHandleClient.h:
1609         (WebCore::ResourceHandleClient::didReceiveResponse): New
1610         delegate method.
1611         * platform/network/ResourceHandleInternal.h:
1612         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
1613         storage of response bits, we're not gonna return them
1614         seprately any more.
1615         * platform/network/ResourceResponse.h: Added.
1616         (WebCore::ResourceResponse::ResourceResponse): Freshly
1617         implemented. Same for below.
1618         (WebCore::ResourceResponse::url):
1619         (WebCore::ResourceResponse::mimeType):
1620         (WebCore::ResourceResponse::expectedContentLength):
1621         (WebCore::ResourceResponse::textEncodingName):
1622         (WebCore::ResourceResponse::suggestedFilename):
1623         (WebCore::ResourceResponse::httpStatusCode):
1624         (WebCore::ResourceResponse::setHTTPStatusCode):
1625         (WebCore::ResourceResponse::httpHeaderField):
1626         (WebCore::ResourceResponse::httpHeaderFields):
1627         (WebCore::ResourceResponse::isMultipart):
1628         (WebCore::ResourceResponse::setExpirationDate):
1629         (WebCore::ResourceResponse::expirationDate):
1630         * platform/network/cf/ResourceHandleCFNet.cpp:
1631         (WebCore::didReceiveResponse): Send didReceiveResponse
1632         client method.
1633         * platform/network/cf/ResourceResponseCFNet.h: Added.
1634         * platform/network/cf/ResourceResponseCFNet.mm: Added.
1635         (getResourceResponse): Helper function to get a ResourceResponse
1636         from CFURLResponseRef.
1637         * platform/network/mac/ResourceHandleMac.mm:
1638         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1639         Don't bother cleaning up fields we no longer have.
1640         (WebCore::ResourceHandle::receivedResponse): Send
1641         didReceiveResponse client method.
1642         * platform/network/mac/ResourceResponseMac.h: Added.
1643         * platform/network/mac/ResourceResponseMac.mm: Added.
1644         (getResourceResponse): Helper function to get a ResourceResponse
1645         from an NSURLResponse*.
1646         * rendering/HitTestResult.cpp:
1647         * xml/XSLTProcessor.cpp:
1648         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
1649         * xml/xmlhttprequest.cpp:
1650         (WebCore::XMLHttpRequest::getResponseText): Store http response
1651         info in the form of a ResourceResponse, change all methods to
1652         account for this.
1653         (WebCore::XMLHttpRequest::getResponseXML):
1654         (WebCore::XMLHttpRequest::XMLHttpRequest):
1655         (WebCore::XMLHttpRequest::open):
1656         (WebCore::XMLHttpRequest::send):
1657         (WebCore::XMLHttpRequest::getAllResponseHeaders):
1658         (WebCore::XMLHttpRequest::getResponseHeader):
1659         (WebCore::XMLHttpRequest::getStatus):
1660         (WebCore::XMLHttpRequest::getStatusText):
1661         (WebCore::XMLHttpRequest::processSyncLoadResults):
1662         (WebCore::XMLHttpRequest::didFinishLoading):
1663         (WebCore::XMLHttpRequest::didReceiveResponse):
1664         (WebCore::XMLHttpRequest::didReceiveData):
1665         * xml/xmlhttprequest.h:
1666
1667 2006-10-29  Darin Adler  <darin@apple.com>
1668
1669         - fix build
1670
1671         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
1672         * loader/NetscapePlugInStreamLoader.h: Ditto.
1673         * loader/ResourceLoader.h: Ditto.
1674
1675 2006-10-29  Darin Adler  <darin@apple.com>
1676
1677         - one last name change -- WebFormState.h to FormState.h
1678         - added more empty placeholder platform-independent files
1679           for currently-Mac-specific loader classes
1680
1681         * loader/FormState.cpp: Updated include.
1682         * loader/FrameLoader.cpp: Updated include.
1683         * loader/mac/FrameLoaderMac.mm: Updated include.
1684
1685         * loader/WebFormState.h: Removed.
1686         * loader/FormState.h: Added.
1687
1688         * loader/DocumentLoader.cpp: Added.
1689         * loader/MainResourceLoader.cpp: Added.
1690         * loader/NetscapePlugInStreamLoader.cpp: Added.
1691         * loader/ResourceLoader.cpp: Added.
1692         * loader/SubresourceLoader.cpp: Added.
1693
1694         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
1695
1696 2006-10-29  Darin Adler  <darin@apple.com>
1697
1698         - did the do-webcore-rename renames, including a number of changes
1699           to the names of loader files (and WebResourceLoader -> ResourceLoader),
1700           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
1701           and improvements to the names of decoder classes and their source
1702           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
1703
1704         * CMakeLists.txt:
1705         * WebCore.exp:
1706         * WebCore.vcproj/WebCore/WebCore.vcproj:
1707         * WebCore.xcodeproj/project.pbxproj:
1708         * WebCoreSources.bkl:
1709         * bindings/js/kjs_binding.cpp:
1710         (KJS::ScriptInterpreter::updateDOMNodeDocument):
1711         * bindings/js/kjs_events.cpp:
1712         (KJS::JSAbstractEventListener::handleEvent):
1713         (KJS::JSLazyEventListener::parseCode):
1714         * bindings/js/kjs_html.cpp:
1715         (KJS::JSHTMLElement::implementsCall):
1716         * bindings/js/kjs_traversal.cpp:
1717         (KJS::JSNodeFilterCondition::acceptNode):
1718         * bindings/js/kjs_window.cpp:
1719         (KJS::Window::interpreter):
1720         (KJS::Window::retrieveWindow):
1721         (KJS::Window::retrieve):
1722         (KJS::ScheduledAction::execute):
1723         * bindings/objc/DOMInternal.mm:
1724         (-[WebScriptObject _initializeScriptDOMNodeImp]):
1725         * bridge/mac/FrameMac.mm:
1726         (WebCore::FrameMac::executionContextForDOM):
1727         (WebCore::FrameMac::bindingRootObject):
1728         (WebCore::FrameMac::windowScriptObject):
1729         (WebCore::FrameMac::windowScriptNPObject):
1730         (WebCore::FrameMac::partClearedInBegin):
1731         * bridge/mac/WebCoreEncodings.mm:
1732         * bridge/mac/WebCoreFrameBridge.mm:
1733         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1734         (-[WebCoreFrameBridge stringWithData:]):
1735         (-[WebCoreFrameBridge executionContextForView:]):
1736         * bridge/win/FrameWin.cpp:
1737         * dom/Document.cpp:
1738         (WebCore::Document::inputEncoding):
1739         (WebCore::Document::setCharset):
1740         (WebCore::Document::createHTMLEventListener):
1741         (WebCore::Document::setDecoder):
1742         * dom/Document.h:
1743         (WebCore::Document::decoder):
1744         * dom/EventTargetNode.cpp:
1745         (WebCore::EventTargetNode::dispatchGenericEvent):
1746         * html/HTMLParser.cpp:
1747         (WebCore::HTMLParser::noscriptCreateErrorCheck):
1748         (WebCore::HTMLParser::canvasCreateErrorCheck):
1749         (WebCore::HTMLParser::isInline):
1750         * html/HTMLPlugInElement.cpp:
1751         (WebCore::HTMLPlugInElement::createNPObject):
1752         * html/HTMLScriptElement.cpp:
1753         (WebCore::HTMLScriptElement::evaluateScript):
1754         * html/HTMLTokenizer.cpp:
1755         (WebCore::HTMLTokenizer::parseTag):
1756         (WebCore::HTMLTokenizer::processToken):
1757         * ksvg2/misc/SVGDocumentExtensions.cpp:
1758         (WebCore::SVGDocumentExtensions::createSVGEventListener):
1759         * loader/CachedCSSStyleSheet.cpp:
1760         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1761         (WebCore::CachedCSSStyleSheet::setEncoding):
1762         * loader/CachedCSSStyleSheet.h:
1763         * loader/CachedXBLDocument.cpp:
1764         (WebCore::CachedXBLDocument::CachedXBLDocument):
1765         (WebCore::CachedXBLDocument::setEncoding):
1766         * loader/CachedXBLDocument.h:
1767         * loader/CachedXSLStyleSheet.cpp:
1768         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
1769         (WebCore::CachedXSLStyleSheet::setEncoding):
1770         * loader/CachedXSLStyleSheet.h:
1771         * loader/Decoder.cpp: Removed.
1772         * loader/Decoder.h: Removed.
1773         * loader/FrameLoader.cpp:
1774         * loader/FrameLoader.h:
1775         * loader/FrameLoaderClient.h:
1776         * loader/MainResourceLoader.h: Added.
1777         * loader/NetscapePlugInStreamLoader.h: Added.
1778         * loader/Request.h:
1779         (WebCore::Request::cachedResource):
1780         * loader/ResourceLoader.h: Added.
1781         * loader/SubresourceLoader.h: Added.
1782         * loader/TextResourceDecoder.cpp: Added.
1783         (WebCore::TextResourceDecoder::determineContentType):
1784         (WebCore::TextResourceDecoder::defaultEncoding):
1785         (WebCore::TextResourceDecoder::TextResourceDecoder):
1786         (WebCore::TextResourceDecoder::~TextResourceDecoder):
1787         (WebCore::TextResourceDecoder::setEncoding):
1788         (WebCore::TextResourceDecoder::checkForBOM):
1789         (WebCore::TextResourceDecoder::checkForCSSCharset):
1790         (WebCore::TextResourceDecoder::checkForHeadCharset):
1791         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
1792         (WebCore::TextResourceDecoder::decode):
1793         (WebCore::TextResourceDecoder::flush):
1794         * loader/TextResourceDecoder.h: Added.
1795         * loader/WebDocumentLoader.h: Removed.
1796         * loader/WebLoader.h: Removed.
1797         * loader/WebMainResourceLoader.h: Removed.
1798         * loader/WebNetscapePlugInStreamLoader.h: Removed.
1799         * loader/WebSubresourceLoader.h: Removed.
1800         * loader/loader.cpp:
1801         (WebCore::Loader::servePendingRequests):
1802         (WebCore::Loader::receivedAllData):
1803         (WebCore::Loader::receivedResponse):
1804         (WebCore::Loader::didReceiveData):
1805         (WebCore::Loader::cancelRequests):
1806         (WebCore::Loader::jobForRequest):
1807         * loader/mac/DocumentLoaderMac.mm:
1808         * loader/mac/FormDataStream.m: Added.
1809         * loader/mac/FrameLoaderMac.mm:
1810         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1811         (WebCore::FrameLoader::addPlugInStreamLoader):
1812         (WebCore::FrameLoader::removePlugInStreamLoader):
1813         (WebCore::FrameLoader::addSubresourceLoader):
1814         (WebCore::FrameLoader::removeSubresourceLoader):
1815         (WebCore::FrameLoader::willSendRequest):
1816         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
1817         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
1818         (WebCore::FrameLoader::didReceiveResponse):
1819         (WebCore::FrameLoader::didReceiveData):
1820         (WebCore::FrameLoader::didFinishLoad):
1821         (WebCore::FrameLoader::didFailToLoad):
1822         (WebCore::FrameLoader::open):
1823         (WebCore::FrameLoader::willUseArchive):
1824         (WebCore::FrameLoader::isArchiveLoadPending):
1825         * loader/mac/ImageDocumentMac.mm:
1826         * loader/mac/LoaderFunctionsMac.mm:
1827         (WebCore::CheckCacheObjectStatus):
1828         * loader/mac/MainResourceLoaderMac.mm:
1829         (WebCore::MainResourceLoader::MainResourceLoader):
1830         (WebCore::MainResourceLoader::releaseDelegate):
1831         (WebCore::MainResourceLoader::didCancel):
1832         (WebCore::MainResourceLoader::addData):
1833         (WebCore::MainResourceLoader::willSendRequest):
1834         (WebCore::MainResourceLoader::continueAfterContentPolicy):
1835         (WebCore::MainResourceLoader::didReceiveData):
1836         (WebCore::MainResourceLoader::didFinishLoading):
1837         (WebCore::MainResourceLoader::setDefersLoading):
1838         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1839         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1840         (WebCore::NetscapePlugInStreamLoader::releaseResources):
1841         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
1842         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
1843         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
1844         (WebCore::NetscapePlugInStreamLoader::didFail):
1845         (WebCore::NetscapePlugInStreamLoader::didCancel):
1846         * loader/mac/ResourceLoaderMac.mm:
1847         (WebCore::ResourceLoader::ResourceLoader):
1848         (WebCore::ResourceLoader::~ResourceLoader):
1849         (WebCore::ResourceLoader::releaseResources):
1850         (WebCore::ResourceLoader::load):
1851         (WebCore::ResourceLoader::setDefersLoading):
1852         (WebCore::ResourceLoader::frameLoader):
1853         (WebCore::ResourceLoader::addData):
1854         (WebCore::ResourceLoader::resourceData):
1855         (WebCore::ResourceLoader::clearResourceData):
1856         (WebCore::ResourceLoader::willSendRequest):
1857         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1858         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1859         (WebCore::ResourceLoader::didReceiveResponse):
1860         (WebCore::ResourceLoader::didReceiveData):
1861         (WebCore::ResourceLoader::willStopBufferingData):
1862         (WebCore::ResourceLoader::didFinishLoading):
1863         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1864         (WebCore::ResourceLoader::didFail):
1865         (WebCore::ResourceLoader::willCacheResponse):
1866         (WebCore::ResourceLoader::didCancel):
1867         (WebCore::ResourceLoader::cancel):
1868         (WebCore::ResourceLoader::setIdentifier):
1869         (WebCore::ResourceLoader::response):
1870         (WebCore::ResourceLoader::inConnectionCallback):
1871         (WebCore::ResourceLoader::cancelledError):
1872         (WebCore::ResourceLoader::receivedCredential):
1873         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
1874         (WebCore::ResourceLoader::receivedCancellation):
1875         (WebCore::ResourceLoader::delegate):
1876         (WebCore::ResourceLoader::releaseDelegate):
1877         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
1878         * loader/mac/SubresourceLoaderMac.mm:
1879         (WebCore::SubresourceLoader::SubresourceLoader):
1880         (WebCore::SubresourceLoader::willSendRequest):
1881         (WebCore::SubresourceLoader::didReceiveResponse):
1882         (WebCore::SubresourceLoader::didReceiveData):
1883         (WebCore::SubresourceLoader::didFinishLoading):
1884         (WebCore::SubresourceLoader::didFail):
1885         (WebCore::SubresourceLoader::didCancel):
1886         * loader/mac/WebFormDataStream.h: Removed.
1887         * loader/mac/WebFormDataStream.m: Removed.
1888         * page/Frame.cpp:
1889         (WebCore::Frame::javaScriptEnabled):
1890         (WebCore::Frame::scriptProxy):
1891         (WebCore::Frame::executeScript):
1892         (WebCore::Frame::write):
1893         (WebCore::Frame::userGestureHint):
1894         (WebCore::Frame::saveInterpreterBuiltins):
1895         (WebCore::Frame::restoreInterpreterBuiltins):
1896         (WebCore::Frame::backslashAsCurrencySymbol):
1897         * page/Frame.h:
1898         * page/FramePrivate.h:
1899         * platform/StreamingTextDecoder.cpp: Removed.
1900         * platform/StreamingTextDecoder.h: Removed.
1901         * platform/StreamingTextDecoderICU.cpp: Removed.
1902         * platform/StreamingTextDecoderICU.h: Removed.
1903         * platform/TextCodec.cpp: Added.
1904         * platform/TextCodec.h: Added.
1905         * platform/TextCodecICU.cpp: Added.
1906         * platform/TextCodecICU.h: Added.
1907         * platform/TextCodecLatin1.h:
1908         * platform/TextCodecUTF16.h:
1909         * platform/TextDecoder.h:
1910         * platform/TextEncoding.cpp:
1911         * platform/TextEncodingRegistry.cpp:
1912         * platform/image-decoders/jpeg/jmorecfg.h:
1913         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
1914         * platform/mac/StreamingTextDecoderMac.h: Removed.
1915         * platform/mac/TextCodecMac.cpp: Added.
1916         * platform/mac/TextCodecMac.h: Added.
1917         * platform/network/ResourceHandleInternal.h:
1918         * platform/network/mac/ResourceHandleMac.mm:
1919         * platform/qt/FrameQt.cpp:
1920         (WebCore::FrameQt::bindingRootObject):
1921         * platform/qt/LoaderFunctionsQt.cpp:
1922         (WebCore::CheckCacheObjectStatus):
1923         * rendering/RenderObject.cpp:
1924         (WebCore::RenderObject::backslashAsCurrencySymbol):
1925         * xml/XSLTProcessor.cpp:
1926         (WebCore::XSLTProcessor::createDocumentFromSource):
1927         * xml/xmlhttprequest.cpp:
1928         (WebCore::XMLHttpRequest::didReceiveData):
1929         * xml/xmlhttprequest.h:
1930
1931 2006-10-29  Darin Adler  <darin@apple.com>
1932
1933         Rubber stamped by Adam (kinda).
1934
1935         - add Mac suffixes and correct filenames inside loader/mac
1936
1937         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
1938
1939         * loader/mac/FrameLoader.mm: Removed.
1940         * loader/mac/WebDocumentLoader.mm: Removed.
1941         * loader/mac/WebLoader.mm: Removed.
1942         * loader/mac/WebMainResourceLoader.mm: Removed.
1943         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
1944         * loader/mac/WebSubresourceLoader.mm: Removed.
1945
1946         * loader/mac/FrameLoaderMac.mm: Added.
1947         * loader/mac/DocumentLoaderMac.mm: Added.
1948         * loader/mac/ResourceLoaderMac.mm: Added.
1949         * loader/mac/MainResourceLoaderMac.mm: Added.
1950         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
1951         * loader/mac/SubresourceLoaderMac.mm: Removed.
1952
1953 2006-10-29  Darin Adler  <darin@apple.com>
1954
1955         Reviewed by Adam.
1956
1957         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
1958           and FrameLoader.cpp mostly ready
1959
1960         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
1961         FormState.cpp. Removed WebFormState.mm.
1962
1963         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
1964         get this header compiling on non-Mac.
1965         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
1966         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
1967
1968         * loader/FrameLoaderClient.h: Added some ifdefs.
1969         * loader/WebDocumentLoader.h: Ditto.
1970         * loader/WebLoader.h: Ditto.
1971         * loader/WebMainResourceLoader.h: Ditto.
1972
1973         * loader/mac/WebDocumentLoader.mm:
1974         (WebCore::DocumentLoader::isLoadingInAPISense):
1975         Rewrote to work without bridge, partly to remove the need for ObjC
1976         bridge type in the header, and also because we're tearing down the bridge.
1977
1978         * loader/mac/WebMainResourceLoader.mm:
1979         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
1980         m_contentLength and m_bytesReceived.
1981         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
1982         (WebCore::MainResourceLoader::didReceiveData): Ditto.
1983
1984         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
1985         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
1986
1987         * loader/mac/FormState.mm: Removed.
1988         * loader/FormState.cpp: Added.
1989
1990 2006-10-29  Darin Adler  <darin@apple.com>
1991
1992         Rubber stamped by Adam.
1993
1994         - moving towards use of FrameLoader cross-platform; move the headers
1995           for the Mac loader from loader/mac into loader, in preparation for
1996           making them useful on non-Mac
1997
1998         * WebCore.xcodeproj/project.pbxproj:
1999
2000         * loader/mac/FrameLoader.h: Removed.
2001         * loader/mac/WebDocumentLoader.h: Removed.
2002         * loader/mac/WebFormState.h: Removed.
2003         * loader/mac/WebLoader.h: Removed.
2004         * loader/mac/WebMainResourceLoader.h: Removed.
2005         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
2006         * loader/mac/WebSubresourceLoader.h: Removed.
2007
2008         * loader/FrameLoader.h: Added.
2009         * loader/WebDocumentLoader.h: Added.
2010         * loader/WebFormState.h: Added.
2011         * loader/WebLoader.h: Added.
2012         * loader/WebMainResourceLoader.h: Added.
2013         * loader/WebNetscapePlugInStreamLoader.h: Added.
2014         * loader/WebSubresourceLoader.h: Added.
2015
2016 2006-10-29  Adam Roben  <aroben@apple.com>
2017
2018         Reviewed by Geoff.
2019
2020         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
2021         r17405.
2022
2023         * platform/DeprecatedString.h:
2024
2025 2006-10-29  Beth Dakin  <bdakin@apple.com>
2026
2027         Rubber stamped by Geoff.
2028
2029         This is a followup to my HitTestResult checkin. Most of the
2030         HitTestResult local variables in the code were named i or info for
2031         when the class was named NodeInfo. This patch renames all of these
2032         local variables to result.
2033
2034         * dom/Document.cpp:
2035         (WebCore::Document::prepareMouseEvent):
2036         * html/HTMLAreaElement.cpp:
2037         (WebCore::HTMLAreaElement::mapMouseEvent):
2038         * html/HTMLMapElement.cpp:
2039         (WebCore::HTMLMapElement::mapMouseEvent):
2040         * rendering/EllipsisBox.cpp:
2041         (WebCore::EllipsisBox::nodeAtPoint):
2042         * rendering/EllipsisBox.h:
2043         * rendering/InlineBox.cpp:
2044         (WebCore::InlineBox::nodeAtPoint):
2045         * rendering/InlineFlowBox.cpp:
2046         (WebCore::InlineFlowBox::nodeAtPoint):
2047         * rendering/InlineTextBox.cpp:
2048         (WebCore::InlineTextBox::nodeAtPoint):
2049         * rendering/RenderBlock.cpp:
2050         (WebCore::RenderBlock::isPointInScrollbar):
2051         (WebCore::RenderBlock::nodeAtPoint):
2052         * rendering/RenderBlock.h:
2053         * rendering/RenderBox.cpp:
2054         (WebCore::RenderBox::nodeAtPoint):
2055         * rendering/RenderBox.h:
2056         * rendering/RenderFlow.cpp:
2057         (WebCore::RenderFlow::hitTestLines):
2058         * rendering/RenderFlow.h:
2059         * rendering/RenderForeignObject.cpp:
2060         (WebCore::RenderForeignObject::nodeAtPoint):
2061         * rendering/RenderFrameSet.cpp:
2062         (WebCore::RenderFrameSet::nodeAtPoint):
2063         * rendering/RenderImage.cpp:
2064         (WebCore::RenderImage::nodeAtPoint):
2065         * rendering/RenderInline.cpp:
2066         (WebCore::RenderInline::nodeAtPoint):
2067         * rendering/RenderInline.h:
2068         * rendering/RenderLayer.cpp:
2069         (WebCore::RenderLayer::autoscroll):
2070         (WebCore::RenderLayer::hitTest):
2071         (WebCore::RenderLayer::hitTestLayer):
2072         (WebCore::RenderLayer::updateHoverActiveState):
2073         * rendering/RenderListBox.cpp:
2074         (WebCore::RenderListBox::isPointInScrollbar):
2075         * rendering/RenderObject.cpp:
2076         (WebCore::RenderObject::hitTest):
2077         (WebCore::RenderObject::setInnerNode):
2078         (WebCore::RenderObject::nodeAtPoint):
2079         * rendering/RenderObject.h:
2080         * rendering/RenderPath.cpp:
2081         (WebCore::RenderPath::nodeAtPoint):
2082         * rendering/RenderSVGImage.cpp:
2083         (WebCore::RenderSVGImage::nodeAtPoint):
2084         * rendering/RenderSVGText.cpp:
2085         (WebCore::RenderSVGText::nodeAtPoint):
2086         * rendering/RenderTableRow.cpp:
2087         (WebCore::RenderTableRow::nodeAtPoint):
2088         * rendering/RenderTableRow.h:
2089         * rendering/RenderTableSection.cpp:
2090         (WebCore::RenderTableSection::nodeAtPoint):
2091         * rendering/RenderTableSection.h:
2092         * rendering/RenderTextControl.cpp:
2093         (WebCore::RenderTextControl::nodeAtPoint):
2094         * rendering/RootInlineBox.cpp:
2095         (WebCore::RootInlineBox::nodeAtPoint):
2096         * rendering/RootInlineBox.h:
2097
2098 2006-10-29  Adam Roben  <aroben@apple.com>
2099
2100         More semi-fixes.
2101
2102         * page/Page.cpp: Forgot to wrap the actual definition of
2103         setDefersLoading() in PLATFORM(MAC).
2104         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2105
2106 2006-10-29  Adam Roben  <aroben@apple.com>
2107
2108         Build semi-fix.
2109
2110         Move all FrameLoader-related code in Page.{cpp,h} within #if
2111         PLATFORM(MAC), since this class currently only exists on Mac.
2112
2113         * page/Page.cpp:
2114         * page/Page.h:
2115
2116 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2117
2118         build fix.
2119
2120         * platform/PlatformString.h:
2121         (WebCore::String::operator NSString*):
2122
2123 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2124
2125         Rolled out accidental commit.
2126
2127         * platform/AtomicString.h:
2128         (WebCore::AtomicString::AtomicString):
2129         (WebCore::AtomicString::operator NSString*):
2130
2131 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2132
2133         RS by Darin.
2134
2135         Rolled out change to map NULL Strings to nil NSStrings because it caused
2136         even more AppKit crashes. Maybe we should remove the NSString * operator
2137         entirely, since its use is not straight-forward, and require callers to
2138         specify explicitly whether they tolerate NULL.
2139
2140         * platform/AtomicString.h:
2141         * platform/PlatformString.h:
2142         (WebCore::String::operator NSString*):
2143         * platform/mac/TextFieldMac.mm:
2144         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2145
2146 2006-10-29  Darin Adler  <darin@apple.com>
2147
2148         Reviewed by Geoff.
2149
2150         - fixed storage leak showing up on the buildbot
2151
2152         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2153         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2154
2155 2006-10-29  Darin Adler  <darin@apple.com>
2156
2157         Rubber stamped by Adam.
2158
2159         - renamed WebFrameLoaderClient to match the class name inside it
2160
2161         * loader/mac/WebFrameLoaderClient.h: Removed.
2162         * loader/FrameLoaderClient.h: Moved it here.
2163
2164         * WebCore.xcodeproj/project.pbxproj: Updated project.
2165
2166         * bridge/mac/FrameMac.mm: Updated includes.
2167         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2168         * loader/mac/FrameLoader.mm: Ditto.
2169         * loader/mac/WebLoader.h: Ditto.
2170
2171 2006-10-29  Darin Adler  <darin@apple.com>
2172
2173         Reviewed by Mitz.
2174
2175         - fix crash visible on buildbot and also when running the test
2176           anchor-image-scrolled-x-y.html under libgmalloc
2177
2178         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2179         now that the class is named ResourceHandle.
2180         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2181         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2182         a local RefPtr before calling finishJobAndHandle, since we might get
2183         cancelled inside that function, so we should not rely on m_handle to
2184         keep the ResourceHandle alive.
2185         (WebCore::SubresourceLoader::didFail): Ditto.
2186         (WebCore::SubresourceLoader::didCancel): Ditto.
2187
2188 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2189
2190         - build fix
2191
2192         * platform/network/mac/ResourceHandleMac.mm:
2193
2194 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2195
2196         Rubber stamped by Darin.
2197
2198         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2199
2200         * CMakeLists.txt:
2201         * Projects/gdk/webcore-gdk.bkl:
2202         * WebCore.vcproj/WebCore/WebCore.vcproj:
2203         * WebCore.xcodeproj/project.pbxproj:
2204         * WebCoreSources.bkl:
2205         * bridge/mac/FrameMac.mm:
2206         * bridge/win/FrameWin.cpp:
2207         * dom/XMLTokenizer.cpp:
2208         * loader/Cache.cpp:
2209         * loader/CachedResource.h:
2210         * loader/LoaderFunctions.h:
2211         * loader/icon/IconLoader.cpp:
2212         (IconLoader::startLoading):
2213         (IconLoader::didReceiveData):
2214         (IconLoader::didFinishLoading):
2215         * loader/icon/IconLoader.h:
2216         * loader/loader.cpp:
2217         (WebCore::Loader::servePendingRequests):
2218         (WebCore::Loader::receivedAllData):
2219         (WebCore::Loader::receivedResponse):
2220         (WebCore::Loader::didReceiveData):
2221         (WebCore::Loader::cancelRequests):
2222         (WebCore::Loader::jobForRequest):
2223         * loader/loader.h:
2224         * loader/mac/IconLoaderMac.mm:
2225         (IconLoader::receivedResponse):
2226         * loader/mac/LoaderFunctionsMac.mm:
2227         * loader/mac/WebLoader.h:
2228         * loader/mac/WebSubresourceLoader.h:
2229         * loader/mac/WebSubresourceLoader.mm:
2230         (WebCore::SubresourceLoader::SubresourceLoader):
2231         (WebCore::SubresourceLoader::create):
2232         * platform/gdk/FrameGdk.cpp:
2233         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2234         (WebCore::FrameGdkClientDefault::openURL):
2235         (WebCore::FrameGdkClientDefault::submitForm):
2236         (WebCore::FrameGdkClientDefault::receivedResponse):
2237         (WebCore::FrameGdkClientDefault::didReceiveData):
2238         (WebCore::FrameGdkClientDefault::receivedAllData):
2239         * platform/gdk/FrameGdk.h:
2240         * platform/gdk/TemporaryLinkStubs.cpp:
2241         (WebCore::ServeSynchronousRequest):
2242         (WebCore::ResourceHandle::assembleResponseHeaders):
2243         (WebCore::ResourceHandle::retrieveCharset):
2244         * platform/network/ResourceHandle.cpp: Added.
2245         (WebCore::ResourceHandle::ResourceHandle):
2246         (WebCore::ResourceHandle::create):
2247         (WebCore::ResourceHandle::isErrorPage):
2248         (WebCore::ResourceHandle::error):
2249         (WebCore::ResourceHandle::setError):
2250         (WebCore::ResourceHandle::responseEncoding):
2251         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2252         (WebCore::ResourceHandle::kill):
2253         (WebCore::ResourceHandle::requestHeaders):
2254         (WebCore::ResourceHandle::url):
2255         (WebCore::ResourceHandle::postData):
2256         (WebCore::ResourceHandle::method):
2257         (WebCore::ResourceHandle::client):
2258         * platform/network/ResourceHandle.h: Added.
2259         (WebCore::ResourceHandle::getInternal):
2260         * platform/network/ResourceHandleClient.h: Added.
2261         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2262         (WebCore::ResourceHandleClient::didReceiveData):
2263         (WebCore::ResourceHandleClient::didFinishLoading):
2264         (WebCore::ResourceHandleClient::receivedRedirect):
2265         (WebCore::ResourceHandleClient::receivedResponse):
2266         (WebCore::ResourceHandleClient::receivedAllData):
2267         * platform/network/ResourceHandleInternal.h: Added.
2268         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2269         * platform/network/ResourceLoader.cpp: Removed.
2270         * platform/network/ResourceLoader.h: Removed.
2271         * platform/network/ResourceLoaderClient.h: Removed.
2272         * platform/network/ResourceLoaderInternal.h: Removed.
2273         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2274         (WebCore::willSendRequest):
2275         (WebCore::didReceiveResponse):
2276         (WebCore::didReceiveData):
2277         (WebCore::didFinishLoading):
2278         (WebCore::didFail):
2279         (WebCore::willCacheResponse):
2280         (WebCore::didReceiveChallenge):
2281         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2282         (WebCore::ResourceHandle::~ResourceHandle):
2283         (WebCore::ResourceHandle::start):
2284         (WebCore::ResourceHandle::cancel):
2285         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2286         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2287         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2288         (WebCore::ResourceHandle::~ResourceHandle):
2289         (WebCore::ResourceHandle::start):
2290         (WebCore::ResourceHandle::cancel):
2291         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2292         (WebCore::ResourceHandleManager::ResourceHandleManager):
2293         (WebCore::ResourceHandleManager::get):
2294         (WebCore::ResourceHandleManager::useSimpleTransfer):
2295         (WebCore::writeCallback):
2296         (WebCore::ResourceHandleManager::downloadTimerCallback):
2297         (WebCore::ResourceHandleManager::remove):
2298         (WebCore::ResourceHandleManager::add):
2299         (WebCore::ResourceHandleManager::cancel):
2300         * platform/network/gdk/ResourceHandleManager.h: Added.
2301         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2302         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2303         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2304         * platform/network/mac/ResourceHandleMac.mm: Added.
2305         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2306         (WebCore::ResourceHandle::~ResourceHandle):
2307         (WebCore::ResourceHandle::start):
2308         (WebCore::ResourceHandle::assembleResponseHeaders):
2309         (WebCore::ResourceHandle::retrieveResponseEncoding):
2310         (WebCore::ResourceHandle::receivedResponse):
2311         (WebCore::ResourceHandle::cancel):
2312         (WebCore::ResourceHandle::redirectedToURL):
2313         (WebCore::ResourceHandle::addData):
2314         (WebCore::ResourceHandle::finishJobAndHandle):
2315         (WebCore::ResourceHandle::reportError):
2316         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2317         * platform/network/qt/ResourceHandleManager.cpp: Added.
2318         (WebCore::ResourceHandleManager::ResourceHandleManager):
2319         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2320         (WebCore::ResourceHandleManager::self):
2321         (WebCore::ResourceHandleManager::slotData):
2322         (WebCore::ResourceHandleManager::slotMimetype):
2323         (WebCore::ResourceHandleManager::slotResult):
2324         (WebCore::ResourceHandleManager::remove):
2325         (WebCore::ResourceHandleManager::add):
2326         (WebCore::ResourceHandleManager::cancel):
2327         * platform/network/qt/ResourceHandleManager.h: Added.
2328         * platform/network/qt/ResourceHandleQt.cpp: Added.
2329         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2330         (WebCore::ResourceHandle::~ResourceHandle):
2331         (WebCore::ResourceHandle::start):
2332         (WebCore::ResourceHandle::cancel):
2333         (WebCore::ResourceHandle::assembleResponseHeaders):
2334         (WebCore::ResourceHandle::retrieveResponseEncoding):
2335         (WebCore::ResourceHandle::receivedResponse):
2336         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2337         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2338         * platform/network/qt/ResourceLoaderManager.h: Removed.
2339         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2340         * platform/network/win/ResourceHandleWin.cpp: Added.
2341         (WebCore::):
2342         (WebCore::addToOutstandingJobs):
2343         (WebCore::lookupResourceHandle):
2344         (WebCore::ResourceHandleWndProc):
2345         (WebCore::initializeOffScreenResourceHandleWindow):
2346         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2347         (WebCore::ResourceHandle::~ResourceHandle):
2348         (WebCore::ResourceHandle::onHandleCreated):
2349         (WebCore::ResourceHandle::onRequestRedirected):
2350         (WebCore::ResourceHandle::onRequestComplete):
2351         (WebCore::ResourceHandle::start):
2352         (WebCore::ResourceHandle::fileLoadTimer):
2353         (WebCore::ResourceHandle::cancel):
2354         (WebCore::ResourceHandle::setHasReceivedResponse):
2355         (WebCore::ResourceHandle::hasReceivedResponse):
2356         * platform/network/win/ResourceHandleWin.h: Added.
2357         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2358         * platform/network/win/ResourceLoaderWin.h: Removed.
2359         * platform/qt/FrameQt.cpp:
2360         * platform/qt/FrameQtClient.cpp:
2361         (WebCore::FrameQtClientDefault::openURL):
2362         (WebCore::FrameQtClientDefault::submitForm):
2363         (WebCore::FrameQtClientDefault::receivedResponse):
2364         (WebCore::FrameQtClientDefault::didReceiveData):
2365         (WebCore::FrameQtClientDefault::receivedAllData):
2366         * platform/qt/FrameQtClient.h:
2367         * platform/win/TemporaryLinkStubs.cpp:
2368         (WebCore::ResourceHandle::assembleResponseHeaders):
2369         (WebCore::ResourceHandle::retrieveResponseEncoding):
2370         (WebCore::ServeSynchronousRequest):
2371         * xml/XSLTProcessor.cpp:
2372         * xml/xmlhttprequest.cpp:
2373         (WebCore::XMLHttpRequest::send):
2374         (WebCore::XMLHttpRequest::didFinishLoading):
2375         (WebCore::XMLHttpRequest::receivedRedirect):
2376         (WebCore::XMLHttpRequest::didReceiveData):
2377         * xml/xmlhttprequest.h:
2378
2379 t2006-10-29  Darin Adler  <darin@apple.com>
2380
2381         Reviewed by Maciej.
2382
2383         - eliminate use of NSArray to carry form data around
2384
2385         * WebCore.exp:
2386         * WebCore.xcodeproj/project.pbxproj:
2387         * bridge/mac/FormDataMac.h: Removed.
2388         * bridge/mac/FormDataMac.mm: Removed.
2389         * bridge/mac/FrameMac.h:
2390         * bridge/mac/WebCoreFrameBridge.h:
2391         * bridge/mac/WebCoreFrameBridge.mm:
2392         * html/HTMLFormElement.cpp:
2393         (WebCore::HTMLFormElement::submit):
2394         * loader/FormData.h:
2395         (WebCore::FormData::isEmpty):
2396         * loader/mac/FrameLoader.h:
2397         * loader/mac/FrameLoader.mm:
2398         (WebCore::FrameLoader::load):
2399         (WebCore::FrameLoader::post):
2400         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2401         (WebCore::FrameLoader::loadResourceSynchronously):
2402         * loader/mac/LoaderFunctionsMac.mm:
2403         (WebCore::ServeSynchronousRequest):
2404         * loader/mac/WebFormDataStream.h:
2405         * loader/mac/WebFormDataStream.m:
2406         (WebCore::pairRetain):
2407         (WebCore::pairRelease):
2408         (WebCore::pairEqual):
2409         (WebCore::pairHash):
2410         (WebCore::closeCurrentStream):
2411         (WebCore::scheduleWithPair):
2412         (WebCore::advanceCurrentStream):
2413         (WebCore::openNextStream):
2414         (WebCore::formCreate):
2415         (WebCore::formFinalize):
2416         (WebCore::formOpen):
2417         (WebCore::formRead):
2418         (WebCore::formCanRead):
2419         (WebCore::formClose):
2420         (WebCore::formSchedule):
2421         (WebCore::formUnschedule):
2422         (WebCore::formEventCallback):
2423         (WebCore::setHTTPBody):
2424         * loader/mac/WebSubresourceLoader.h:
2425         * loader/mac/WebSubresourceLoader.mm:
2426         (WebCore::SubresourceLoader::create):
2427         * platform/network/mac/ResourceLoaderMac.mm:
2428
2429 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2430
2431         Reviewed by Darin.
2432
2433         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2434
2435         * loader/mac/WebSubresourceLoader.h:
2436         * loader/mac/WebSubresourceLoader.mm:
2437         (WebCore::SubresourceLoader::create):
2438         * platform/network/mac/ResourceLoaderMac.mm:
2439         (WebCore::ResourceLoader::start):
2440
2441 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2442
2443         Reviewed by Darin.
2444
2445         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2446
2447         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2448
2449         * WebCore.xcodeproj/project.pbxproj:
2450         * bridge/mac/WebCoreFrameBridge.h:
2451         * loader/mac/FrameLoader.h:
2452         * loader/mac/FrameLoader.mm:
2453         * loader/mac/LoaderFunctionsMac.mm:
2454         * loader/mac/WebLoader.h:
2455         * loader/mac/WebSubresourceLoader.h:
2456         * loader/mac/WebSubresourceLoader.mm:
2457         (WebCore::SubresourceLoader::SubresourceLoader):
2458         (WebCore::SubresourceLoader::create):
2459         (WebCore::SubresourceLoader::willSendRequest):
2460         (WebCore::SubresourceLoader::didReceiveResponse):
2461         (WebCore::SubresourceLoader::didReceiveData):
2462         (WebCore::SubresourceLoader::didFinishLoading):
2463         (WebCore::SubresourceLoader::didFail):
2464         (WebCore::SubresourceLoader::didCancel):
2465         * platform/network/ResourceLoader.h:
2466         * platform/network/ResourceLoaderInternal.h:
2467         * platform/network/mac/ResourceLoaderMac.mm:
2468         (WebCore::ResourceLoader::~ResourceLoader):
2469         (WebCore::ResourceLoader::start):
2470         (WebCore::ResourceLoader::receivedResponse):
2471         (WebCore::ResourceLoader::cancel):
2472         (WebCore::ResourceLoader::redirectedToURL):
2473         (WebCore::ResourceLoader::addData):
2474         (WebCore::ResourceLoader::finishJobAndHandle):
2475         (WebCore::ResourceLoader::reportError):
2476         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2477         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2478         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2479
2480 2006-10-28  Darin Adler  <darin@apple.com>
2481
2482         Reviewed by Maciej.
2483
2484         - eliminated the use of Objective-C for the policy decider
2485           machinery, obviating the need for WebPolicyDecider,
2486           WebCoreFrameLoaderAsDelegate, and
2487           WebCoreMainResourceLoaderAsPolicyDelegate
2488
2489         - grouped the state related to policy decisions into a PolicyCheck
2490           class to simplify the FrameLoader logic
2491
2492         - removed six methods from the bridge, reducing FrameLoader's use of
2493           the bridge to a single method
2494
2495         - changed form state to always use HashMap instead of NSDictionary
2496
2497         - moved the defersLoading flag from WebView to WebCore::Page
2498           and changed code to consistently call it defersLoading rather
2499           than defersCallbacks
2500
2501         - updated for rename of PassRefPtr::release to releaseRef
2502         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2503         - cleaned up kjs_binding.h a bit
2504         - cleaned up FrameMac.h a bit
2505
2506         * loader/mac/WebPolicyDecider.h: Removed.
2507         * loader/mac/WebPolicyDecider.mm: Removed.
2508         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2509
2510         * WebCore.exp:
2511         * bindings/js/kjs_binding.cpp:
2512         (KJS::ScriptInterpreter::ScriptInterpreter):
2513         (KJS::ScriptInterpreter::wasRunByUserGesture):
2514         * bindings/js/kjs_binding.h:
2515         (KJS::ScriptInterpreter::setCurrentEvent):
2516         (KJS::ScriptInterpreter::setInlineCode):
2517         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2518         (KJS::ScriptInterpreter::getCurrentEvent):
2519         (KJS::cacheDOMObject):
2520         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2521         * bridge/AXObjectCache.h:
2522         * bridge/mac/BrowserExtensionMac.mm:
2523         (WebCore::BrowserExtensionMac::createNewWindow):
2524         * bridge/mac/FrameMac.h:
2525         * bridge/mac/FrameMac.mm:
2526         (WebCore::FrameMac::loadRequest):
2527         (WebCore::FrameMac::submitForm):
2528         (WebCore::FrameMac::urlSelected):
2529         (WebCore::FrameMac::userAgent):
2530         (WebCore::FrameMac::passMouseDownEventToWidget):
2531         (WebCore::FrameMac::handleMouseMoveEvent):
2532         * bridge/mac/PageMac.mm:
2533         (WebCore::Page::Page):
2534         * bridge/mac/WebCoreEditCommand.mm:
2535         * bridge/mac/WebCoreFrameBridge.h:
2536         * bridge/mac/WebCoreFrameBridge.mm:
2537         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2538         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2539         * css/CSSComputedStyleDeclaration.cpp:
2540         (WebCore::):
2541         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2542         * css/CSSPrimitiveValue.cpp:
2543         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2544         (WebCore::CSSPrimitiveValue::cleanup):
2545         (WebCore::CSSPrimitiveValue::cssText):
2546         * css/CSSPrimitiveValue.h:
2547         (WebCore::CSSPrimitiveValue::):
2548         * css/CSSValueList.cpp:
2549         (WebCore::CSSValueList::append):
2550         * css/cssparser.cpp:
2551         (WebCore::CSSParser::parseValue):
2552         * css/cssparser.h:
2553         * css/cssstyleselector.cpp:
2554         (WebCore::CSSStyleSelector::applyProperty):
2555         * dom/Document.cpp:
2556         (WebCore::Document::Document):
2557         (WebCore::Document::updateSelection):
2558         (WebCore::Document::implicitClose):
2559         (WebCore::Document::setFocusNode):
2560         * dom/Document.h:
2561         * editing/ReplaceSelectionCommand.h:
2562         * html/HTMLParser.cpp:
2563         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2564         * loader/mac/FrameLoader.h:
2565         (WebCore::PolicyCheck::request):
2566         * loader/mac/FrameLoader.mm:
2567         (WebCore::FrameLoader::~FrameLoader):
2568         (WebCore::FrameLoader::safeLoad):
2569         (WebCore::FrameLoader::load):
2570         (WebCore::FrameLoader::open):
2571         (WebCore::FrameLoader::stopLoading):
2572         (WebCore::setAllDefersLoading):
2573         (WebCore::FrameLoader::setDefersLoading):
2574         (WebCore::FrameLoader::willSendRequest):
2575         (WebCore::FrameLoader::receivedMainResourceError):
2576         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2577         (WebCore::FrameLoader::commitProvisionalLoad):
2578         (WebCore::FrameLoader::checkNavigationPolicy):
2579         (WebCore::FrameLoader::checkContentPolicy):
2580         (WebCore::FrameLoader::cancelContentPolicyCheck):
2581         (WebCore::FrameLoader::stopPolicyCheck):
2582         (WebCore::FrameLoader::checkNewWindowPolicy):
2583         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2584         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2585         (WebCore::FrameLoader::continueAfterContentPolicy):
2586         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2587         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
2588         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2589         (WebCore::FrameLoader::closeDocument):
2590         (WebCore::FrameLoader::transitionToCommitted):
2591         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
2592         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2593         (WebCore::FrameLoader::post):
2594         (WebCore::FrameLoader::detachFromParent):
2595         (WebCore::FrameLoader::addExtraFieldsToRequest):
2596         (WebCore::PolicyCheck::PolicyCheck):
2597         (WebCore::PolicyCheck::clear):
2598         (WebCore::PolicyCheck::set):
2599         (WebCore::PolicyCheck::call):
2600         (WebCore::PolicyCheck::dropRequest):
2601         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2602         * loader/mac/WebFormState.h:
2603         * loader/mac/WebFormState.mm:
2604         * loader/mac/WebFrameLoaderClient.h:
2605         * loader/mac/WebLoader.h:
2606         (WebCore::WebResourceLoader::defersLoading):
2607         * loader/mac/WebLoader.mm:
2608         (WebCore::WebResourceLoader::WebResourceLoader):
2609         (WebCore::WebResourceLoader::load):
2610         (WebCore::WebResourceLoader::setDefersLoading):
2611         * loader/mac/WebMainResourceLoader.h:
2612         * loader/mac/WebMainResourceLoader.mm:
2613         (WebCore::MainResourceLoader::MainResourceLoader):
2614         (WebCore::MainResourceLoader::releaseDelegate):
2615         (WebCore::MainResourceLoader::didCancel):
2616         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2617         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2618         (WebCore::MainResourceLoader::willSendRequest):
2619         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2620         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2621         (WebCore::MainResourceLoader::didReceiveResponse):
2622         (WebCore::MainResourceLoader::didReceiveData):
2623         (WebCore::MainResourceLoader::didFinishLoading):
2624         (WebCore::MainResourceLoader::didFail):
2625         (WebCore::MainResourceLoader::loadNow):
2626         (WebCore::MainResourceLoader::load):
2627         (WebCore::MainResourceLoader::setDefersLoading):
2628         * page/Frame.cpp:
2629         (WebCore::Frame::paint):
2630         * page/FrameView.cpp:
2631         (WebCore::FrameView::layout):
2632         * page/FrameView.h:
2633         * page/Page.cpp:
2634         (WebCore::Page::setDefersLoading):
2635         * page/Page.h:
2636         (WebCore::Page::defersLoading):
2637         * platform/DeprecatedString.h:
2638         * platform/DeprecatedStringList.h:
2639         * platform/FontFallbackList.h:
2640         * platform/PlatformKeyboardEvent.h:
2641         * platform/PlatformMouseEvent.h:
2642         * platform/PlatformWheelEvent.h:
2643         * platform/mac/ClipboardMac.h:
2644         * platform/mac/ClipboardMac.mm:
2645         (WebCore::ClipboardMac::setDragImage):
2646         (WebCore::ClipboardMac::dragNSImage):
2647         (WebCore::ClipboardMac::sourceOperation):
2648         (WebCore::ClipboardMac::destinationOperation):
2649         * rendering/RenderObject.cpp:
2650         (WebCore::RenderObject::setStyle):
2651         * rendering/break_lines.cpp:
2652         (WebCore::nextBreakablePosition):
2653
2654 2006-10-28  Adam Roben  <aroben@apple.com>
2655
2656         Reviewed by Maciej.
2657
2658         Fix layout tests that broke after r17399. Mitz discovered that the
2659         failures were caused by HitTestResult::m_point being uninitialized
2660         much of the time. HitTestResults are now always constructed with a
2661         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
2662         point instead of being passed one explicitly.
2663
2664         * WebCore.exp: Change constructor symbol.
2665         * bridge/mac/FrameMac.mm:
2666         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
2667         hitTest().
2668         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
2669         * bridge/mac/WebCoreAXObject.mm:
2670         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
2671         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
2672         * dom/Document.cpp:
2673         (WebCore::Document::elementFromPoint): Ditto.
2674         (WebCore::Document::prepareMouseEvent): Ditto.
2675         * page/Frame.cpp:
2676         (WebCore::Frame::isPointInsideSelection): Ditto.
2677         (WebCore::Frame::hitTestResultAtPoint): Ditto.
2678         * page/FrameView.cpp:
2679         (WebCore::FrameView::handleWheelEvent): Ditto.
2680         * rendering/HitTestResult.cpp:
2681         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
2682         passed point.
2683         * rendering/HitTestResult.h: Update constructor declaration.
2684         * rendering/RenderLayer.cpp:
2685         (WebCore::RenderLayer::autoscroll): Update to new constructor and
2686         hitTest().
2687         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
2688         HitTestResult instead of being passed one.
2689         (WebCore::RenderLayer::hitTestLayer): Ditto.
2690         * rendering/RenderLayer.h: Update declarations.
2691
2692 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
2693
2694         Reviewed by Anders.
2695
2696         Fix Qt/Linux build.
2697
2698         * CMakeLists.txt:
2699         * platform/qt/FrameQtClient.cpp:
2700         (WebCore::numRequests):
2701         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
2702         * platform/qt/PopupMenuQt.cpp:
2703         (WebCore::PopupMenu::updateFromElement):
2704
2705 2006-10-28  David Carson  <dacarson@gmail.com>
2706
2707         Tweaked by Sam. Reviewed by Brady.
2708
2709         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
2710         Initialize m_modifyBiasSet to false, as it sometimes gets
2711         used before it has been initalized.
2712
2713         * editing/SelectionController.cpp:
2714         (WebCore::SelectionController::SelectionController):
2715
2716 2006-10-28  Beth Dakin  <bdakin@apple.com>
2717
2718         Reviewed by Darin.
2719
2720         This is the WebCore half of pushing elementAtPoint and the backend
2721         of WebElementDictionary into WebCore. Most of the changes below are
2722         to accommodate one of the following:
2723
2724         -NodeInfo is now a stand-alone class called HitTestResult.
2725                 Previously it was defined in RenderObject.h, but not for
2726                 any particular reason. The WebElementDictionary
2727                 functionality that was pushed into WebCore has been pushed
2728                 specifically into the this class. In fact,
2729                 WebElementDictionary now keeps a HitTestResult as a member
2730                 varibale.
2731
2732         -The enumeration AccessPolicy is now called
2733                 ClipboardAccessPolicy and is defined in its own header. It
2734                 was previously defined in ClipboardMac.h, but is now
2735                 defined independently to avoid including ClipboardMac.h
2736                 from within FrameMac.h since FrameMac.h is now included in
2737                 WebElementDictionary.m in WebKit.
2738
2739         -Element now has a virtual target() for the sake of
2740                 NodeInfo::targetFrame()
2741
2742         * WebCore.exp: Several WebCore functions are newly called from
2743         WebKit, so they have been added here.
2744         * WebCore.xcodeproj/project.pbxproj:
2745         * bindings/objc/DOM.mm: Must include Image.h because of adjustments
2746         to ClipboardMac.
2747         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
2748         * bridge/mac/FrameMac.mm:
2749         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy
2750         and HitTestResult changes.
2751         (WebCore::FrameMac::eventMayStartDrag): Same.
2752         (WebCore::FrameMac::handleMouseMoveEvent): Same.
2753         (WebCore::FrameMac::dispatchCPPEvent): Same.
2754         (WebCore::FrameMac::mayDHTMLCut): Same.
2755         (WebCore::FrameMac::mayDHTMLCopy): Same.
2756         (WebCore::FrameMac::mayDHTMLPaste): Same.
2757         (WebCore::FrameMac::tryDHTMLCut): Same
2758         (WebCore::FrameMac::tryDHTMLCopy): Same.
2759         (WebCore::FrameMac::tryDHTMLPaste): Same.
2760         * bridge/mac/WebCoreAXObject.mm:
2761         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to
2762         HitTestResult changes.
2763         (-[WebCoreAXObject accessibilityHitTest:]): Same.
2764         * bridge/mac/WebCoreFrameBridge.h: Same.
2765         * bridge/mac/WebCoreFrameBridge.mm:
2766         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for
2767         ClipboardAccessPolicy changes.
2768         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
2769         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
2770         * dom/Document.cpp:
2771         (WebCore::Document::elementFromPoint): Adjust for HitTestResult
2772         changes.
2773         (WebCore::Document::prepareMouseEvent): Same.
2774         * dom/Element.h:
2775         (WebCore::Element::target): Now has a virtual target()
2776         * html/HTMLAnchorElement.h: Same.
2777         * html/HTMLAreaElement.cpp:
2778         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult
2779         changes.
2780         * html/HTMLAreaElement.h: Virtual target()
2781         * html/HTMLBaseElement.h:
2782         (WebCore::HTMLBaseElement::target): Same.
2783         * html/HTMLFormElement.h: Same.
2784         * html/HTMLLinkElement.h: Same.
2785         * html/HTMLMapElement.cpp:
2786         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult
2787         changes.
2788         * html/HTMLMapElement.h: Same.
2789         * page/Frame.cpp:
2790         (WebCore::Frame::isPointInsideSelection): Same.
2791         (WebCore::Frame::hitTestResultAtPoint): Same.
2792         * page/Frame.h: Same.
2793         * page/FrameView.cpp:
2794         (WebCore::FrameView::handleWheelEvent): Same.
2795         * platform/mac/ClipboardAccessPolicy.h: Added.
2796         (WebCore::):
2797         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy,
2798         include ClipboardAccessPolicy.h, and rename AccessPolicy to
2799         ClipboardAccessPolicy.
2800         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
2801         (WebCore::ClipboardMac::ClipboardMac):
2802         (WebCore::ClipboardMac::setAccessPolicy):
2803         (WebCore::ClipboardMac::clearData):
2804         (WebCore::ClipboardMac::clearAllData):
2805         (WebCore::ClipboardMac::getData):
2806         (WebCore::ClipboardMac::setData):
2807         (WebCore::ClipboardMac::types):
2808         (WebCore::ClipboardMac::setDragImage):
2809         (WebCore::ClipboardMac::setDropEffect):
2810         (WebCore::ClipboardMac::setEffectAllowed):
2811         * rendering/EllipsisBox.cpp:
2812         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult
2813         changes.
2814         * rendering/EllipsisBox.h:
2815         * rendering/HitTestResult.cpp: Added.
2816         (WebCore::HitTestResult::HitTestResult):
2817         (WebCore::HitTestResult::~HitTestResult):
2818         (WebCore::HitTestResult::operator=):
2819         (WebCore::HitTestResult::setInnerNode):
2820         (WebCore::HitTestResult::setInnerNonSharedNode):
2821         (WebCore::HitTestResult::setURLElement):
2822         (WebCore::HitTestResult::setScrollbar):
2823         (WebCore::HitTestResult::targetFrame):
2824         (WebCore::HitTestResult::boundingBox):
2825         (WebCore::HitTestResult::isSelected):
2826         (WebCore::HitTestResult::title):
2827         * rendering/HitTestResult.h: Added.
2828         (WebCore::HitTestResult::readonly):
2829         (WebCore::HitTestResult::active):
2830         (WebCore::HitTestResult::mouseMove):
2831         (WebCore::HitTestResult::innerNode):
2832         (WebCore::HitTestResult::innerNonSharedNode):
2833         (WebCore::HitTestResult::point):
2834         (WebCore::HitTestResult::URLElement):
2835         (WebCore::HitTestResult::scrollbar):
2836         (WebCore::HitTestResult::setPoint):
2837         (WebCore::HitTestResult::setReadonly):
2838         (WebCore::HitTestResult::setActive):
2839         (WebCore::HitTestResult::setMouseMove):
2840         * rendering/InlineBox.cpp:
2841         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
2842         * rendering/InlineBox.h: Same.
2843         * rendering/InlineFlowBox.cpp:
2844         (WebCore::InlineFlowBox::nodeAtPoint): Same.
2845         * rendering/InlineFlowBox.h: Same.
2846         * rendering/InlineTextBox.cpp:
2847         (WebCore::InlineTextBox::nodeAtPoint): Same.
2848         * rendering/InlineTextBox.h: Same.
2849         * rendering/RenderBlock.cpp:
2850         (WebCore::RenderBlock::isPointInScrollbar): Same.
2851         (WebCore::RenderBlock::nodeAtPoint): Same.
2852         * rendering/RenderBlock.h: Same.
2853         * rendering/RenderBox.cpp:
2854         (WebCore::RenderBox::nodeAtPoint): Same.
2855         * rendering/RenderBox.h: Same.
2856         * rendering/RenderFlow.cpp:
2857         (WebCore::RenderFlow::hitTestLines): Same.
2858         * rendering/RenderFlow.h: Same.
2859         * rendering/RenderForeignObject.cpp:
2860         (WebCore::RenderForeignObject::nodeAtPoint): Same.
2861         * rendering/RenderForeignObject.h: Same.
2862         * rendering/RenderFrameSet.cpp:
2863         (WebCore::RenderFrameSet::nodeAtPoint): Same.
2864         * rendering/RenderFrameSet.h: Same.
2865         * rendering/RenderImage.cpp:
2866         (WebCore::RenderImage::nodeAtPoint): Same.
2867         * rendering/RenderImage.h: Same.
2868         * rendering/RenderInline.cpp:
2869         (WebCore::RenderInline::nodeAtPoint): Same.
2870         * rendering/RenderInline.h: Same.
2871         * rendering/RenderLayer.cpp:
2872         (WebCore::RenderLayer::autoscroll): Same.
2873         (WebCore::RenderLayer::hitTest): Same.
2874         (WebCore::RenderLayer::hitTestLayer): Same.
2875         (WebCore::RenderLayer::updateHoverActiveState): Same.
2876         * rendering/RenderLayer.h: Same.
2877         * rendering/RenderListBox.cpp:
2878         (WebCore::RenderListBox::isPointInScrollbar): Same.
2879         * rendering/RenderListBox.h: Same.
2880         * rendering/RenderObject.cpp:
2881         (WebCore::RenderObject::hitTest): Same.
2882         (WebCore::RenderObject::setInnerNode): Same.
2883         (WebCore::RenderObject::nodeAtPoint): Same.
2884         * rendering/RenderObject.h: Remove NodeInfo class and forward
2885         declare HitTestResult.
2886         * rendering/RenderPath.cpp:
2887         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult
2888         changes.
2889         * rendering/RenderPath.h: Same.
2890         * rendering/RenderSVGImage.cpp:
2891         (WebCore::RenderSVGImage::nodeAtPoint): Same.
2892         * rendering/RenderSVGImage.h: Same
2893         * rendering/RenderSVGText.cpp:
2894         (WebCore::RenderSVGText::nodeAtPoint): Same.
2895         * rendering/RenderSVGText.h: Same.
2896         * rendering/RenderTableRow.cpp:
2897         (WebCore::RenderTableRow::nodeAtPoint): Same.
2898         * rendering/RenderTableRow.h: Same.
2899         * rendering/RenderTableSection.cpp:
2900         (WebCore::RenderTableSection::nodeAtPoint): Same.
2901         * rendering/RenderTableSection.h: Same.
2902         * rendering/RenderText.h: Same.
2903         (WebCore::RenderText::nodeAtPoint): Same.
2904         * rendering/RenderTextControl.cpp:
2905         (WebCore::RenderTextControl::nodeAtPoint): Same.
2906         * rendering/RenderTextControl.h: Same.
2907         * rendering/RootInlineBox.cpp:
2908         (WebCore::RootInlineBox::nodeAtPoint): Same.
2909         * rendering/RootInlineBox.h: Same.
2910
2911 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2912
2913         Reviewed by Anders.
2914
2915         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
2916         impact of fixing it again.
2917
2918         * bridge/mac/FrameMac.mm:
2919         (WebCore::FrameMac::clear):
2920
2921 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2922
2923         Reviewed by John & Adam.
2924
2925         - assorted speedups to fix perf regression from fixing correctness regression
2926
2927         * WebCore.exp: exported new methods.
2928         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
2929         * bridge/mac/WebCoreFrameBridge.h:
2930         * bridge/mac/WebCoreFrameBridge.mm:
2931         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
2932         * loader/CachedResource.h:
2933         * loader/mac/CachedResourceMac.mm: Added.
2934         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
2935         now cached in the CachedObject.
2936         * loader/mac/FrameLoader.h:
2937         * loader/mac/FrameLoader.mm:
2938         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
2939         the WebKit side do faster dispatch for clients that implement the fast path delegate.
2940         * loader/mac/LoaderFunctionsMac.mm:
2941         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
2942         just call loadedResourceFromMemoryCache.
2943         * loader/mac/WebFrameLoaderClient.h:
2944
2945 2006-10-27  Oliver Hunt  <oliver@apple.com>
2946
2947         Reviewed by Maciej.
2948
2949         build fix
2950
2951         * dom/Document.cpp:
2952         (WebCore::Document::referrer):
2953
2954 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
2955
2956         Reviewed by Maciej.
2957
2958         Moved some WebCoreFrameBridge functions into FrameLoader.
2959
2960         I had to make FrameLoader.h capable of compiling in C++-only source files
2961         by adding some forward declarations and __OBJC__ #ifdefs.
2962
2963         * WebCore.exp:
2964         * bridge/mac/FrameMac.h:
2965         * bridge/mac/FrameMac.mm:
2966         (WebCore::FrameMac::createEmptyDocument):
2967         (WebCore::FrameMac::tokenizerProcessedData):
2968         * bridge/mac/WebCoreFrameBridge.h:
2969         * bridge/mac/WebCoreFrameBridge.mm:
2970         * dom/Document.cpp:
2971         (WebCore::Document::processHttpEquiv):
2972         (WebCore::Document::referrer):
2973         * loader/LoaderFunctions.h:
2974         * loader/mac/FrameLoader.h:
2975         * loader/mac/FrameLoader.mm:
2976         (WebCore::numRequests):
2977         (WebCore::FrameLoader::numPendingOrLoadingRequests):
2978         (WebCore::FrameLoader::isReloading):
2979         (WebCore::FrameLoader::referrer):
2980         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2981         (WebCore::FrameLoader::startLoadingResource):
2982         * loader/mac/LoaderFunctionsMac.mm:
2983         (WebCore::CheckIfReloading):
2984         * page/Frame.h:
2985         * page/FrameTree.cpp:
2986         (WebCore::FrameTree::isDescendantOf):
2987         (WebCore::FrameTree::traverseNext):
2988         * page/FrameTree.h:
2989         * platform/network/mac/ResourceLoaderMac.mm:
2990         (WebCore::ResourceLoader::start):
2991
2992 2006-10-27  Timothy Hatcher  <timothy@apple.com>
2993
2994         Reviewed by Darin.
2995
2996         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
2997
2998         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
2999
3000         * editing/DeleteButtonController.cpp:
3001         (WebCore::isDeletableElement):
3002         (WebCore::enclosingDeletableElement):
3003         (WebCore::DeleteButtonController::respondToChangedSelection):
3004
3005 2006-10-27  John Sullivan  <sullivan@apple.com>
3006
3007         Reviewed by Kevin Decker
3008
3009         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
3010         you haven't not finished reading this.
3011
3012         * rendering/InlineTextBox.h:
3013         * rendering/InlineTextBox.cpp:
3014         (WebCore::InlineTextBox::paint):
3015         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
3016         considered also.
3017         (WebCore::InlineTextBox::paintDocumentMarkers):
3018         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
3019         markers should be painted, instead of a marker type. This avoids walking the collection of
3020         markers multiple times back to back. Now handles grammar markers.
3021
3022 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3023
3024         Reviewed by Beth.
3025
3026         Renamed Copy Files to Copy Generated Headers.
3027         Copy 4 DOM*Internal.h headers.
3028
3029         * WebCore.xcodeproj/project.pbxproj:
3030         * bindings/scripts/CodeGeneratorObjC.pm:
3031
3032 2006-10-27  John Sullivan  <sullivan@apple.com>
3033
3034         Reviewed by Anders
3035
3036         * WebCore.exp:
3037         exported symbol for FrameMac->advanceToNextSpelling()
3038
3039         * bridge/mac/WebCoreFrameBridge.h:
3040         * bridge/mac/WebCoreFrameBridge.mm:
3041         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
3042
3043 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
3044
3045         Reviewed by harrison
3046
3047         <http://bugs.webkit.org/show_bug.cgi?id=11423>
3048         REGRESSION: First newline missing from textarea's value
3049
3050         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
3051
3052         Before my change in r17223, return (an InsertLineBreak) would insert a '\n'
3053         (the line break) then a br to prevent the '\n' from collapsing, since the
3054         insertion is being done at the end of a block (the textarea's shadow div).  Then,
3055         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".
3056         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed
3057         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would
3058         serialize as "foobar" because when serializing RenderTextControl intentionally asks
3059         textContent to not convert brs to newlines.  It seems to think that the only brs in
3060         the shadow div will be placeholders or collapsed.
3061
3062         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak
3063         to insert two '\n's when at the end of a block in white-space:pre text.  This alone
3064         would have fixed the bug, but introduced a new one, because foo, return, bar would
3065         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second
3066         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to
3067         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as
3068         a br or '\n' that will collapse (become superfluous) when content is inserted just
3069         before it.
3070
3071         * editing/CompositeEditCommand.cpp:
3072         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
3073         a br or '\n' if content inserted just before it will cause it to collapse.
3074         * editing/CompositeEditCommand.h:
3075         * editing/InsertLineBreakCommand.cpp:
3076         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
3077         to prevent a collapse as was used for the line break.  Fixed comments.
3078         * editing/InsertTextCommand.cpp:
3079         (WebCore::InsertTextCommand::input): Call the renamed function.
3080
3081 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3082
3083         Reviewed by Brady.
3084
3085         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
3086         String became an empty NSString *, instead of nil. This will become important
3087         as we start using this conversion more.
3088
3089         Added work-around for AppKit crash that semantic accuracy revealed.
3090
3091         No testcase because I don't think there's a way to reflect this change
3092         in a webpage yet.
3093
3094         * platform/PlatformString.h:
3095         (WebCore::String::operator NSString*):
3096         * platform/mac/TextFieldMac.mm:
3097         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3098
3099 2006-10-27  David Harrison  <harrison@apple.com>
3100
3101         Reviewed by Maciej,
3102
3103         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
3104
3105         * bridge/mac/WebCoreAXObject.mm:
3106         (blockquoteLevel):
3107         Calculate and return the blockquote level of the element.
3108
3109         (AXAttributeStringSetBlockquoteLevel):
3110         Add, if non-zero, or clear the block quote level attribute.
3111
3112         (AXAttributedStringAppendText):
3113         Send AXAttributeStringSetBlockquoteLevel.
3114
3115 2006-10-27  Darin Adler  <darin@apple.com>
3116
3117         - fix one error in the Qt build
3118
3119         * platform/qt/GraphicsContextQt.cpp:
3120         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3121         Updated.
3122
3123 2006-10-27  Darin Adler  <darin@apple.com>
3124
3125         Reviewed by Maciej.
3126
3127         * WebCore.exp: Export more symbols needed by WebKit.
3128
3129 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3130
3131         Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.
3132
3133         Fixed layout test crash. Oops.
3134
3135         * loader/mac/WebDocumentLoader.mm:
3136         (WebCore::canonicalizedTitle):
3137
3138 2006-10-26  John Sullivan  <sullivan@apple.com>
3139
3140         Reviewed by Brady
3141
3142         - fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
3143
3144         This restores some of the nil-handling that was implicit before some of the code was converted from
3145         Objective-C to C++.
3146
3147         * bridge/mac/FrameMac.mm:
3148         (WebCore::FrameMac::loadRequest):
3149         handle nil FrameMac
3150
3151         * bridge/mac/WebCoreFrameBridge.mm:
3152         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3153         handle nil Frame
3154
3155 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3156
3157         Reviewed by Darin, Maciej.
3158
3159         Removed many uses of NSString *.
3160         Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing
3161         stringByCollapsingNonPrintingCharacters with a c++ equivalent.
3162
3163         PLT says no performance regression.
3164
3165         * WebCore.exp:
3166         * bridge/mac/WebCoreFrameBridge.mm:
3167         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3168         * loader/mac/FrameLoader.h:
3169         * loader/mac/FrameLoader.mm:
3170         (WebCore::FrameLoader::setupForReplaceByMIMEType):
3171         (WebCore::FrameLoader::load):
3172         (WebCore::FrameLoader::canShowMIMEType):
3173         (WebCore::FrameLoader::representationExistsForURLScheme):
3174         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
3175         (WebCore::FrameLoader::checkContentPolicy):
3176         (WebCore::FrameLoader::reloadAllowingStaleData):
3177         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
3178         (WebCore::FrameLoader::checkNewWindowPolicy):
3179         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3180         (WebCore::FrameLoader::transitionToCommitted):
3181         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3182         (WebCore::FrameLoader::post):
3183         * loader/mac/WebDocumentLoader.h:
3184         * loader/mac/WebDocumentLoader.mm:
3185         (WebCore::DocumentLoader::doesProgressiveLoad):
3186         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
3187         (WebCore::DocumentLoader::title):
3188         (WebCore::DocumentLoader::setOverrideEncoding):
3189         (WebCore::DocumentLoader::overrideEncoding):
3190         (WebCore::DocumentLoader::setTitle):
3191         * loader/mac/WebFrameLoaderClient.h:
3192         * loader/mac/WebMainResourceLoader.mm:
3193         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3194
3195 2006-10-26  Timothy Hatcher  <timothy@apple.com>
3196
3197         Reviewed by Adam.
3198
3199         <rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com
3200
3201         The main table at nytimes.com has a fixed width of 874px, but the table ends
3202         up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
3203         this. The other bug was a missing top and left of 0px on the container element,
3204         causing the deletion UI to sometimes be offset below the table.
3205
3206         Now check for the element's renderer at the beginning of show() and
3207         return early if it is null.
3208
3209         * editing/DeleteButtonController.cpp:
3210         (WebCore::DeleteButtonController::updateOutlineStyle):
3211         (WebCore::DeleteButtonController::show):
3212
3213 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
3214
3215         Build fix.
3216
3217         * html/CanvasRenderingContext2D.cpp:
3218         Include MathExtras.h
3219
3220 2006-10-26  John Sullivan  <sullivan@apple.com>
3221
3222         Reviewed by Anders.
3223
3224         Some changes to support new grammar checking code in WebKit.
3225
3226         * WebCore.exp:
3227         added mangled symbol for Document->removeMarkers() so I can call it from WebKit
3228
3229         * WebCore.xcodeproj/project.pbxproj:
3230         Made Document.h and DocumentMarker.h private so I can include them from WebKit.
3231         Made HTMLCollection.h private because Document.h uses it.
3232
3233         * bridge/mac/WebCoreFrameBridge.h:
3234         * bridge/mac/WebCoreFrameBridge.mm:
3235         removed unmarkAllMisspellings(); WebKit now calls through to the Document directly
3236
3237 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
3238
3239         Reviewed by Brady.
3240
3241         Add reverseFind to String and use it instead of findRev.
3242         Use CString instead of DeprecatedCString in one place.
3243
3244         * html/HTMLFormElement.cpp:
3245         (WebCore::HTMLFormElement::formData):
3246         * ksvg2/svg/SVGURIReference.cpp:
3247         (WebCore::SVGURIReference::getTarget):
3248         * loader/Decoder.cpp:
3249         (WebCore::Decoder::checkForCSSCharset):
3250         * platform/PlatformString.h:
3251         (WebCore::String::reverseFind):
3252         * platform/StringImpl.cpp:
3253         (WebCore::StringImpl::reverseFind):
3254         * platform/StringImpl.h:
3255
3256 2006-10-26  John Sullivan  <sullivan@apple.com>
3257
3258         Reviewed by Darin
3259
3260         More plumbing for grammar checking. Still no grammars is checked.
3261
3262         * dom/DocumentMarker.h:
3263         (WebCore::DocumentMarker::):
3264         added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"
3265
3266         * platform/GraphicsContext.h:
3267         renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar;
3268         now takes a bool parameter for whether it represents bad grammar or a misspelling
3269
3270         * platform/mac/GraphicsContextMac.mm:
3271         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3272         Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed
3273         an existing "assert" to "ASSERT".
3274
3275         * rendering/InlineTextBox.h:
3276         renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
3277
3278         * rendering/InlineTextBox.cpp:
3279         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
3280         Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents
3281         bad grammar or a misspelling
3282         (WebCore::InlineTextBox::paintAllMarkersOfType):
3283         now handles markers of type Grammar
3284
3285 === Safari-521.29 ===
3286
3287 2006-10-26  Sam Weinig  <sam.weinig@gmail.com>
3288
3289         Reviewed by Mitz.
3290
3291         Fix for http://bugs.webkit.org/show_bug.cgi?id=11424
3292         Cleanup rendering code
3293
3294         - Assorted code cleanup.
3295
3296         * rendering/AutoTableLayout.cpp:
3297         * rendering/AutoTableLayout.h:
3298         (WebCore::AutoTableLayout::totalPercent):
3299         * rendering/CounterListItem.h:
3300         * rendering/CounterNode.cpp:
3301         * rendering/CounterNode.h:
3302         (WebCore::CounterNode::~CounterNode):
3303         (WebCore::CounterNode::isReset):
3304         * rendering/CounterResetNode.cpp:
3305         * rendering/CounterResetNode.h:
3306         * rendering/DataRef.h:
3307         (WebCore::DataRef::DataRef):
3308         * rendering/DeprecatedRenderSelect.h:
3309         * rendering/DeprecatedSlider.cpp:
3310         * rendering/DeprecatedSlider.h:
3311         * rendering/EllipsisBox.cpp:
3312         * rendering/EllipsisBox.h:
3313         (WebCore::EllipsisBox::EllipsisBox):
3314         * rendering/FixedTableLayout.cpp:
3315         * rendering/FixedTableLayout.h:
3316         * rendering/GapRects.h:
3317         * rendering/InlineBox.cpp:
3318         * rendering/InlineBox.h:
3319         (WebCore::InlineBox::InlineBox):
3320         (WebCore::InlineBox::setConstructed):
3321         (WebCore::InlineBox::clearTruncation):
3322         (WebCore::InlineBox::markDirty):
3323         * rendering/InlineFlowBox.cpp:
3324         * rendering/InlineFlowBox.h:
3325         (WebCore::InlineFlowBox::InlineFlowBox):
3326         (WebCore::InlineFlowBox::setConstructed):
3327         (WebCore::InlineFlowBox::setEdges):
3328         (WebCore::InlineFlowBox::setVerticalOverflowPositions):
3329         (WebCore::InlineFlowBox::setVerticalSelectionPositions):
3330         * rendering/InlineRunBox.h:
3331         (WebCore::InlineRunBox::paintBackgroundAndBorder):
3332         (WebCore::InlineRunBox::paintDecorations):
3333         * rendering/InlineTextBox.cpp:
3334         * rendering/InlineTextBox.h:
3335         (WebCore::InlineTextBox::InlineTextBox):
3336         (WebCore::InlineTextBox::end):
3337         (WebCore::InlineTextBox::textObject):
3338         * rendering/Length.h:
3339         (WebCore::Length::Length):
3340         * rendering/ListMarkerBox.cpp:
3341         * rendering/ListMarkerBox.h:
3342         * rendering/RenderPartObject.h:
3343         * rendering/RootInlineBox.cpp:
3344         * rendering/RootInlineBox.h:
3345         * rendering/SVGInlineFlowBox.cpp:
3346         * rendering/SVGInlineFlowBox.h:
3347         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
3348         * rendering/SVGRootInlineBox.cpp:
3349         * rendering/SVGRootInlineBox.h:
3350         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
3351         * rendering/TableLayout.h:
3352         (WebCore::TableLayout::TableLayout):
3353         (WebCore::TableLayout::~TableLayout):
3354         * rendering/bidi.h:
3355         (WebCore::BidiStatus::BidiStatus):
3356         (WebCore::BidiRun::BidiRun):
3357         * rendering/break_lines.h:
3358
3359 2006-10-26  Justin Garcia  <justin.garcia@apple.com>
3360
3361         Reviewed by john
3362
3363         <http://bugs.webkit.org/show_bug.cgi?id=11329>
3364         Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.
3365
3366         * editing/Editor.cpp:
3367         (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor.
3368         Wrapped the plain text fragment in a style span with the document
3369         default style so that it will appear unstyled regardless of where
3370         it is inserted.  Could have also inserted the plain text fragment
3371         and then applied the document default style to it, but there is not
3372         yet any redundant style prevention in ApplyStyleCommand, so this
3373         is cleaner.
3374         * editing/Editor.h:
3375         * editing/JSEditor.cpp:
3376
3377 2006-10-26  Oliver Hunt  <oliver@apple.com>
3378
3379         Reviewed by Anders.
3380         Fixes <rdar://problem/4800518> -- needed to update existing
3381         canvas path elements when transforms are performed on the
3382         context.
3383
3384         * html/CanvasRenderingContext2D.cpp:
3385         (WebCore::CanvasRenderingContext2D::scale):
3386         (WebCore::CanvasRenderingContext2D::rotate):
3387         (WebCore::CanvasRenderingContext2D::translate):
3388
3389 2006-10-26  Nikolas Zimmermann  <zimmermann@kde.org>
3390
3391         Reviewed by Darin.
3392
3393         Fix Qt/Linux build.
3394
3395         * platform/network/qt/ResourceLoaderManager.cpp:
3396         (WebCore::ResourceLoaderManager::slotData):
3397         (WebCore::ResourceLoaderManager::slotMimetype):
3398         (WebCore::ResourceLoaderManager::remove):
3399         (WebCore::ResourceLoaderManager::add):
3400         * platform/network/qt/ResourceLoaderQt.cpp:
3401         (WebCore::ResourceLoader::receivedResponse):
3402         * platform/qt/FrameQtClient.cpp:
3403         (WebCore::FrameQtClientDefault::openURL):
3404         * platform/qt/LoaderFunctionsQt.cpp:
3405         (WebCore::ServeSynchronousRequest):
3406
3407 2006-10-26  Adam Roben  <aroben@apple.com>
3408
3409         Reviewed by Adele.
3410
3411         Fix: <rdar://problem/3951815> add "type-to-select" feature for list
3412         boxes (<select> elements)
3413         Fix: http://bugs.webkit.org/show_bug.cgi?id=9764 New popup menus
3414         should have type-ahead selection without popping up menu
3415
3416         * WebCore.xcodeproj/project.pbxproj: Version wars.
3417         * html/HTMLSelectElement.h: Add new instance variables for type-ahead
3418         find.
3419         * html/HTMLSelectElement.cpp:
3420         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new
3421         instance variables.
3422         (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead
3423         find on printable character presses.
3424         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove
3425         redundant check that the listIndex has changed (setSelectedIndex does
3426         this for us), and fix indentation.
3427         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if
3428         to an else-if.
3429         (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind()
3430         to strip leading whitespace (including non-breaking spaces) from a
3431         string.
3432         (WebCore::HTMLSelectElement::typeAheadFind): New method to perform
3433         type-ahead find.
3434         * platform/PopupMenu.h: Added new updateFromElement() method to be
3435         called from RenderMenuList::updateFromElement().
3436         * platform/mac/PopupMenuMac.mm:
3437         (WebCore::PopupMenu::updateFromElement): While we are using
3438         NSPopUpButtonCell for our popups, this method can stay empty.
3439         * rendering/RenderListBox.cpp:
3440         (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first
3441         selected element.
3442         * rendering/RenderMenuList.cpp:
3443         (WebCore::RenderMenuList::updateFromElement): Tell the popup to update
3444         if it's visible.
3445
3446 2006-10-26  Darin Adler  <darin@apple.com>
3447
3448         Reviewed by Anders.
3449
3450         - fix http://bugs.webkit.org/show_bug.cgi?id=11360
3451           editing/pasteboard/copy-paste-bidi intermittently fails due to disappearance of anonymous RenderBlock
3452
3453         * editing/ReplaceSelectionCommand.cpp:
3454         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
3455         Use two vectors instead of a hash map: more efficient, deterministic. There was no
3456         reason to use a hash table.
3457
3458 2006-10-26  Maciej Stachowiak  <mjs@apple.com>
3459
3460         Reviewed by Anders.
3461
3462         - .5% speed improvement by avoiding excess CFURLRef allocation
3463
3464         * loader/CachedResource.cpp:
3465         (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL
3466         here for later reuse.
3467         * loader/CachedResource.h:
3468         * loader/mac/LoaderFunctionsMac.mm:
3469         (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
3470
3471 2006-10-25  Darin Adler  <darin@apple.com>
3472
3473         Reviewed by Anders.
3474
3475         - removed 55 methods from WebCoreFrameBridge
3476         - changed callers to use Frame directly instead
3477         - put FrameLoaderTypes.h types into the WebCore namespace
3478         - first steps to get FrameLoader.h ready for cross-platform duty
3479
3480         * WebCore.exp:
3481         * WebCore.xcodeproj/project.pbxproj:
3482         * bridge/mac/BrowserExtensionMac.mm:
3483         (WebCore::BrowserExtensionMac::createNewWindow):
3484         * bridge/mac/FrameMac.h:
3485         * bridge/mac/FrameMac.mm:
3486         (WebCore::FrameMac::loadRequest):
3487         (WebCore::FrameMac::startRedirectionTimer):
3488         (WebCore::FrameMac::stopRedirectionTimer):
3489         (WebCore::FrameMac::passSubframeEventToSubframe):
3490         (WebCore::FrameMac::handledOnloadEvents):
3491         (WebCore::FrameMac::isLoadTypeReload):
3492         * bridge/mac/WebCoreFrameBridge.h:
3493         * bridge/mac/WebCoreFrameBridge.mm:
3494         (-[WebCoreFrameBridge executionContextForView:]):
3495         (updateRenderingForBindings):
3496         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3497         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
3498         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3499         (-[WebCoreFrameBridge installInFrame:]):
3500         (-[WebCoreFrameBridge numPendingOrLoadingRequests]):
3501         (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
3502         (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]):
3503         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
3504         (stringByCollapsingNonPrintingCharacters):
3505         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
3506         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
3507         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3508         * loader/FrameLoaderTypes.h:
3509         * loader/mac/FrameLoader.h:
3510         * loader/mac/FrameLoader.mm:
3511         (WebCore::FrameLoader::FrameLoader):
3512         (WebCore::FrameLoader::setupForReplace):
3513         (WebCore::FrameLoader::load):
3514         (WebCore::FrameLoader::activeDocumentLoader):
3515         (WebCore::FrameLoader::state):
3516         (WebCore::FrameLoader::setState):
3517         (WebCore::FrameLoader::clearProvisionalLoad):
3518         (WebCore::FrameLoader::markLoadComplete):
3519         (WebCore::FrameLoader::commitProvisionalLoad):
3520         (WebCore::FrameLoader::receivedMainResourceError):
3521         (WebCore::FrameLoader::handleFallbackContent):
3522         (WebCore::FrameLoader::isLoadingMainFrame):
3523         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3524         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3525         (WebCore::FrameLoader::continueAfterWillSubmitForm):
3526         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
3527         (WebCore::FrameLoader::transitionToCommitted):
3528         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3529         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3530         (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):