2006-10-19 Steve Falkenburg <sfalken@apple.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-19  Steve Falkenburg  <sfalken@apple.com>
2
3         Reviewed by Adam.
4
5         Use GetKeyState rather than GetAsyncKeyState since we're
6         calling in these cases in direct response to an event, and want the
7         key state associated with that event.
8         
9         Pass triggering event to url selection method.
10         
11         * bridge/mac/FrameMac.h: Add triggeringEvent parameter
12         * bridge/mac/FrameMac.mm:
13         (WebCore::FrameMac::urlSelected): Add triggeringEvent parameter
14         * bridge/win/FrameWin.cpp:
15         (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
16         * bridge/win/FrameWin.h: Add triggeringEvent parameter
17         * html/HTMLAnchorElement.cpp:
18         (WebCore::HTMLAnchorElement::defaultEventHandler): Pass triggering event to URL selection method
19         * page/Frame.cpp:
20         (WebCore::Frame::changeLocation): Add 0 as triggeringEvent
21         (WebCore::Frame::urlSelected): Pass through triggeringEvent
22         * page/Frame.h: Add triggeringEvent parameter to urlSelected methods
23         * platform/win/KeyEventWin.cpp:
24         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use GetKeyState instead of GetAsyncKeyState
25         * platform/win/MouseEventWin.cpp: Use GetKeyState instead of GetAsyncKeyState
26         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
27
28 2006-10-19  David Hyatt  <hyatt@apple.com>
29
30         Correct typos from changing "flush" to "prune" using automated search/replace.
31
32         Change the cache heuristic for flushing to allow a higher watermark before initiating an
33         aggressive prune.  This ensures that small cache sizes are no worse in terms of performance
34         than the old buggy cache.
35
36         Make sizes unsigned instead of ints in the cache's APIs and member variables.
37
38         * loader/Cache.cpp:
39         (WebCore::Cache::prune):
40         (WebCore::Cache::setMaximumSize):
41         * loader/Cache.h:
42         (WebCore::Cache::maximumSize):
43
44 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
45
46         Reviewed by Daddy Hyatt.
47
48         Use a real hash map for the headers.
49
50         * loader/LoaderFunctions.h:
51         * loader/mac/LoaderFunctionsMac.mm:
52         (WebCore::ServeSynchronousRequest):
53         * platform/ResourceLoader.cpp:
54         (WebCore::ResourceLoader::setRequestHeaders):
55         (WebCore::ResourceLoader::requestHeaders):
56         * platform/ResourceLoader.h:
57         * platform/ResourceLoaderInternal.h:
58         * platform/mac/ResourceLoaderMac.mm:
59         (WebCore::ResourceLoader::start):
60         * xml/xmlhttprequest.cpp:
61         (WebCore::XMLHttpRequest::open):
62         (WebCore::XMLHttpRequest::send):
63         (WebCore::XMLHttpRequest::setRequestHeader):
64         (WebCore::XMLHttpRequest::getRequestHeader):
65         * xml/xmlhttprequest.h:
66
67 2006-10-19  Adam Roben  <aroben@apple.com>
68
69         Reviewed by Ada.
70
71         Pippity-poppity popup tweaks.
72
73         * WebCore.xcodeproj/project.pbxproj: Removed PopupMenu.cpp from project.
74         * html/HTMLSelectElement.cpp:
75         (WebCore::HTMLSelectElement::setSelectedIndex): Only fire onChange if
76         requested and the new index is actually different than the old one.
77         * platform/IntPoint.h: Added another casting operator.
78         * platform/PopupMenu.cpp: Removed. The code in here, while
79         platform-independent, was only useful for the NSPopUpButtonCell
80         implementation of popup menus, so I've moved it to PopupMenuMac.mm.
81         * platform/PopupMenu.h: Moved the definition of PopupMenu::create into
82         the header since it's fairly simple. Made some more methods private now
83         that we don't have subclasses and virtual methods anymore.
84         (WebCore::PopupMenu::create):
85         (WebCore::PopupMenu::menuList):
86         (WebCore::PopupMenu::itemHeight):
87         (WebCore::PopupMenu::windowRect):
88         (WebCore::PopupMenu::listIndexAtPoint):
89         (WebCore::PopupMenu::focusedIndex):
90         (WebCore::PopupMenu::setWasClicked):
91         (WebCore::PopupMenu::wasClicked):
92         (WebCore::PopupMenu::setScrollOffset):
93         (WebCore::PopupMenu::scrollOffset):
94         (WebCore::PopupMenu::wheelDelta):
95         * platform/mac/PopupMenuMac.mm: Added the code from PopupMenu.cpp.
96         (WebCore::PopupMenu::populate): Call our own clear() method to clear
97         the menu.
98         * platform/win/IntPointWin.cpp: New casting operator.
99         (WebCore::IntPoint::IntPoint):
100         (WebCore::IntPoint::operator POINTS):
101
102 2006-10-19  Adam Roben  <aroben@apple.com>
103
104         Reviewed by Darin.
105
106         Cleaning up Document::nextFocusNode and Document::previousFocusNode.
107
108         * dom/Document.cpp:
109         (WebCore::Document::nextFocusNode):
110         (WebCore::Document::previousFocusNode):
111
112 2006-10-19  Maciej Stachowiak  <mjs@apple.com>
113
114         Reviewed by Geoff.
115
116         - implement new ResourceRequest API and fix up code as appropriate
117         
118         * bindings/js/kjs_window.cpp:
119         (KJS::createNewWindow):
120         (KJS::WindowFunc::callAsFunction):
121         * bridge/mac/BrowserExtensionMac.mm:
122         (WebCore::BrowserExtensionMac::createNewWindow):
123         * bridge/mac/FrameMac.mm:
124         (WebCore::FrameMac::submitForm):
125         (WebCore::FrameMac::openURLRequest):
126         (WebCore::FrameMac::urlSelected):
127         * bridge/mac/WebCoreFrameBridge.mm:
128         (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
129         * dom/DOMImplementation.cpp:
130         (WebCore::addString):
131         (WebCore::isSVG10Feature):
132         (WebCore::isSVG11Feature):
133         * dom/Document.h:
134         * editing/CommandByName.cpp:
135         * editing/JSEditor.cpp:
136         * page/Frame.cpp:
137         (WebCore::Frame::changeLocation):
138         (WebCore::Frame::urlSelected):
139         (WebCore::Frame::requestFrame):
140         (WebCore::Frame::submitForm):
141         * page/Frame.h:
142         * page/FramePrivate.h:
143         * page/ResourceRequest.h:
144         (WebCore::):
145         (WebCore::ResourceRequest::ResourceRequest):
146         (WebCore::ResourceRequest::cachePolicy):
147         (WebCore::ResourceRequest::setCachePolicy):
148         (WebCore::ResourceRequest::timeoutInterval):
149         (WebCore::ResourceRequest::setTimeoutInterval):
150         (WebCore::ResourceRequest::mainDocumentURL):
151         (WebCore::ResourceRequest::setMainDocumentURL):
152         (WebCore::ResourceRequest::httpMethod):
153         (WebCore::ResourceRequest::setHTTPMethod):
154         (WebCore::ResourceRequest::httpHeaderField):
155         (WebCore::ResourceRequest::setHTTPHeaderField):
156         (WebCore::ResourceRequest::httpContentType):
157         (WebCore::ResourceRequest::setHTTPContentType):
158         (WebCore::ResourceRequest::httpReferrer):
159         (WebCore::ResourceRequest::setHTTPReferrer):
160         (WebCore::ResourceRequest::httpUserAgent):
161         (WebCore::ResourceRequest::setHTTPUserAgent):
162         (WebCore::ResourceRequest::httpBody):
163         (WebCore::ResourceRequest::setHTTPBody):
164         (WebCore::ResourceRequest::addHTTPHeaderField):
165         * platform/FontCache.cpp:
166         (WebCore::computeHash):
167         * platform/StringHash.h:
168         (WTF::):
169         * platform/StringImpl.cpp:
170         (WebCore::equalIgnoringCase):
171         * rendering/RenderPartObject.cpp:
172         (WebCore::RenderPartObject::updateWidget):
173
174 2006-10-19  Justin Garcia  <justin.garcia@apple.com>
175
176         Reviewed by levi
177         
178         <rdar://problem/4447885>
179         API: WebView should have a method something like incrementLeftMarginBy: or indentBy:
180         
181         Fixed indent/outdent to only increment the left margin, to match other browsers.
182         Used blockquote class="webkit-indent-blockquote" to do this.  Mail can now
183         implement indent/outdent by customizing the appearance of these blockquotes,
184         instead of using a new API.
185         
186         * css/html4.css: Added margin: 0 0 0 40px for webkit-indent-blockquotes.
187         * editing/IndentOutdentCommand.cpp:
188         (WebCore::indentBlockquoteString): Added.
189         (WebCore::createIndentBlockquoteElement): Added.
190         (WebCore::isIndentBlockquote): Added.
191         (WebCore::isListOrBlockquote): Added.
192         (WebCore::IndentOutdentCommand::IndentOutdentCommand):
193         (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Fixed
194         a bug in the code that added an extra br if the placeholder collapsed upon insertion.
195         Used the new indentBlockquote checks and enclosing element getters.  
196         (WebCore::IndentOutdentCommand::indentRegion): Ditto.
197         (WebCore::IndentOutdentCommand::outdentParagraph): Ditto.  Cleaned up the
198         logic to pull the selection out of a list a bit.
199         * editing/htmlediting.cpp:
200         (WebCore::enclosingNodeOfType): Added this generic enclosing element getter.
201         * editing/htmlediting.h:
202
203 2006-10-19  Timothy Hatcher  <timothy@apple.com>
204
205         Rolling out the this change since it caused a bad regression:
206         <rdar://problem/4788524> REGRESSION: Incomplete repaint of text area when deleting (11277)
207
208 2006-10-12  Adele Peterson  <adele@apple.com>
209           
210         Reviewed by Dave Harrison.
211           
212         - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
213           
214         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
215         Make subtree layouts work for textareas as well as text fields.
216
217 2006-10-19  Nikolas Zimmermann  <zimmermann@kde.org>
218
219         Reviewed and landed by Anders.
220
221         Fix Qt/Linux build.
222
223         * CMakeLists.txt:
224         * loader/Cache.h:
225         * platform/qt/BrowserExtensionQt.cpp:
226         * platform/qt/BrowserExtensionQt.h:
227         * platform/qt/CursorQt.cpp:
228         (WebCore::pointerCursor):
229         * platform/qt/LoaderFunctionsQt.cpp:
230         (WebCore::NumberOfPendingOrLoadingRequests):
231         (WebCore::CheckCacheObjectStatus):
232         * platform/qt/ResourceLoaderQt.cpp:
233         (WebCore::ResourceLoader::retrieveResponseEncoding):
234         (WebCore::ResourceLoader::receivedResponse):
235
236 2006-10-19  Sam Weinig  <sam.weinig@gmail.com>
237
238         Reviewed by ap.
239
240         Win32 build fix.
241
242         * bridge/win/FrameWin.cpp:
243         * bridge/win/FrameWin.h:
244         * platform/win/TemporaryLinkStubs.cpp:
245         (WebCore::ResourceLoader::retrieveResponseEncoding):
246
247 2006-10-19  Alexey Proskuryakov  <ap@nypop.com>
248
249         Reviewed by Mitz.
250
251         http://bugs.webkit.org/show_bug.cgi?id=11141
252         REGRESSION(r16681-r16691): CSS '@import' doesn't respect HTML Base element
253
254         Undo one misguided change made in bug 11011 - stop setting inline stylesheet's href
255         to document URL. This matches WinIE and partially matches Firefox - although the latter
256         reports the href as if it were inherited, it still doesn't use it when resolving URIs in
257         @import rules.
258
259         Test: http/tests/uri/css-href.php
260
261         * html/HTMLStyleElement.cpp:
262         (WebCore::HTMLStyleElement::childrenChanged):
263         * ksvg2/svg/SVGStyleElement.cpp:
264         (WebCore::SVGStyleElement::childrenChanged):
265
266 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
267
268         * loader/Cache.cpp:
269         Get rid of #include "loader.h", Cache.h already includes this and it breaks on operating systems
270         with case-sensitive file systems.
271
272 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
273
274         Reviewed by Maciej, Brady.
275
276         Remove "charset" from the ResourceLoader metadata map and use 
277         a getter function instead. Also, rename charset to encoding in a couple of places.
278         
279         * loader/CachedCSSStyleSheet.cpp:
280         (WebCore::CachedCSSStyleSheet::setEncoding):
281         * loader/CachedCSSStyleSheet.h:
282         * loader/CachedResource.h:
283         (WebCore::CachedResource::setEncoding):
284         * loader/CachedScript.cpp:
285         (WebCore::CachedScript::setEncoding):
286         * loader/CachedScript.h:
287         * loader/CachedXBLDocument.cpp:
288         (WebCore::CachedXBLDocument::setEncoding):
289         * loader/CachedXBLDocument.h:
290         * loader/CachedXSLStyleSheet.cpp:
291         (WebCore::CachedXSLStyleSheet::setEncoding):
292         * loader/CachedXSLStyleSheet.h:
293         * loader/loader.cpp:
294         (WebCore::Loader::receivedResponse):
295         * platform/ResourceLoader.cpp:
296         (WebCore::ResourceLoader::responseEncoding):
297         (WebCore::ResourceLoader::queryMetaData):
298         * platform/ResourceLoader.h:
299         * platform/ResourceLoaderInternal.h:
300         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
301         * platform/mac/ResourceLoaderMac.mm:
302         (WebCore::ResourceLoader::retrieveResponseEncoding):
303         (WebCore::ResourceLoader::receivedResponse):
304         * xml/xmlhttprequest.cpp:
305         (WebCore::XMLHttpRequest::receivedData):
306
307 2006-10-19  David Hyatt  <hyatt@apple.com>
308
309         Rewrite of the WebCore memory cache.  The following changes have been made (along with many more):
310
311         (1) Referenced objects are now also cached.
312
313         (2) Pruning of the cache will occur once the cache is both full and in addition
314         more than half full with unreferenced objects.
315
316         (3) The prune is much more aggressive now, since referenced objects are counted when
317         pruning.  The cache will therefore often prune out every unreferenced object if lots of
318         windows/tabs are open.
319
320         (4) Consolidated the request methods for various types of resources to go through a single
321         requestResource bottleneck function.
322
323         (5) deref on CachedResource is no longer virtual, since the implementation in every subclass was
324         identical.
325
326         (6) Changed "object" to "resource" everywhere.
327
328         (7) The Cache is now an actual object, obtained via cache().
329
330         (8) Fixed bugs with the autoload images preference so that it would really work properly when disabled
331         and enabled.
332
333         (9) Tweaked ImageDocuments to set up the status properly for the CachedResource that they use.
334
335         (10) Fixed the LRU-SP algorithm so that the LRU aspect really kicks in (by leaving the live objects
336         in the LRU lists).  Also fixed a bug with the "-SP" part of the algorithm where the access count was
337         being incorrectly weighted too much due to a math error.
338
339         (11) Fixed a bug where the old cache could grow without bound because it didn't know anything about
340         the size of referenced resources.
341
342         Reviewed by Maciej, bradee-oh
343
344         * bridge/mac/WebCoreCache.mm:
345         (+[WebCoreCache statistics]):
346         (+[WebCoreCache empty]):
347         (+[WebCoreCache setDisabled:]):
348         * bridge/mac/WebCoreFrameBridge.mm:
349         (-[WebCoreFrameBridge initMainFrameWithPage:]):
350         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
351         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
352         * css/CSSImageValue.cpp:
353         (WebCore::CSSImageValue::image):
354         * dom/XMLTokenizer.cpp:
355         (WebCore::openFunc):
356         * html/HTMLImageLoader.cpp:
357         (WebCore::HTMLImageLoader::updateFromElement):
358         * loader/Cache.cpp:
359         (WebCore::cache):
360         (WebCore::Cache::Cache):
361         (WebCore::createResource):
362         (WebCore::Cache::requestResource):
363         (WebCore::Cache::resourceForURL):
364         (WebCore::Cache::prune):
365         (WebCore::Cache::setMaximumSize):
366         (WebCore::Cache::remove):
367         (WebCore::Cache::addDocLoader):
368         (WebCore::Cache::removeDocLoader):
369         (WebCore::fastLog2):
370         (WebCore::Cache::lruListFor):
371         (WebCore::Cache::removeFromLRUList):
372         (WebCore::Cache::insertInLRUList):
373         (WebCore::Cache::resourceAccessed):
374         (WebCore::Cache::adjustSize):
375         (WebCore::Cache::getStatistics):
376         (WebCore::Cache::setDisabled):
377         * loader/Cache.h:
378         (WebCore::LRUList::LRUList):
379         (WebCore::Cache::loader):
380         (WebCore::Cache::maximumSize):
381         (WebCore::Cache::disabled):
382         (WebCore::Cache::addToLiveObjectSize):
383         (WebCore::Cache::removeFromLiveObjectSize):
384         (WebCore::Cache::TypeStatistic::TypeStatistic):
385         * loader/CachedCSSStyleSheet.cpp:
386         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
387         * loader/CachedCSSStyleSheet.h:
388         * loader/CachedImage.cpp:
389         (WebCore::CachedImage::CachedImage):
390         (WebCore::CachedImage::~CachedImage):
391         (WebCore::brokenImage):
392         (WebCore::nullImage):
393         (WebCore::CachedImage::image):
394         (WebCore::CachedImage::data):
395         * loader/CachedImage.h:
396         (WebCore::CachedImage::stillNeedsLoad):
397         * loader/CachedResource.cpp:
398         (WebCore::CachedResource::CachedResource):
399         (WebCore::CachedResource::~CachedResource):
400         (WebCore::CachedResource::finish):
401         (WebCore::CachedResource::setExpireDate):
402         (WebCore::CachedResource::isExpired):
403         (WebCore::CachedResource::setRequest):
404         (WebCore::CachedResource::ref):
405         (WebCore::CachedResource::deref):
406         (WebCore::CachedResource::setSize):
407         * loader/CachedResource.h:
408         (WebCore::CachedResource::):
409         (WebCore::CachedResource::setCharset):
410         (WebCore::CachedResource::url):
411         (WebCore::CachedResource::type):
412         (WebCore::CachedResource::referenced):
413         (WebCore::CachedResource::count):
414         (WebCore::CachedResource::status):
415         (WebCore::CachedResource::size):
416         (WebCore::CachedResource::isLoaded):
417         (WebCore::CachedResource::setLoading):
418         (WebCore::CachedResource::isImage):
419         (WebCore::CachedResource::accessCount):
420         (WebCore::CachedResource::increaseAccessCount):
421         (WebCore::CachedResource::setInCache):
422         (WebCore::CachedResource::inCache):
423         (WebCore::CachedResource::cachePolicy):
424         (WebCore::CachedResource::response):
425         (WebCore::CachedResource::allData):
426         (WebCore::CachedResource::canDelete):
427         (WebCore::CachedResource::schedule):
428         (WebCore::CachedResource::accept):
429         (WebCore::CachedResource::setAccept):
430         * loader/CachedScript.cpp:
431         (WebCore::CachedScript::CachedScript):
432         * loader/CachedScript.h:
433         * loader/CachedXBLDocument.cpp:
434         * loader/CachedXBLDocument.h:
435         * loader/CachedXSLStyleSheet.cpp:
436         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
437         * loader/CachedXSLStyleSheet.h:
438         * loader/DocLoader.cpp:
439         (WebCore::DocLoader::DocLoader):
440         (WebCore::DocLoader::~DocLoader):
441         (WebCore::DocLoader::checkForReload):
442         (WebCore::DocLoader::requestImage):
443         (WebCore::DocLoader::requestCSSStyleSheet):
444         (WebCore::DocLoader::requestScript):
445         (WebCore::DocLoader::requestXSLStyleSheet):
446         (WebCore::DocLoader::requestXBLDocument):
447         (WebCore::DocLoader::requestResource):
448         (WebCore::DocLoader::setAutoLoadImages):
449         (WebCore::DocLoader::removeCachedResource):
450         * loader/DocLoader.h:
451         (WebCore::DocLoader::cachedResource):
452         (WebCore::DocLoader::allCachedResources):
453         (WebCore::DocLoader::autoLoadImages):
454         (WebCore::DocLoader::cachePolicy):
455         (WebCore::DocLoader::expireDate):
456         (WebCore::DocLoader::frame):
457         (WebCore::DocLoader::doc):
458         (WebCore::DocLoader::loadInProgress):
459         * loader/ImageDocument.cpp:
460         (WebCore::ImageTokenizer::finish):
461         * loader/loader.cpp:
462         (WebCore::Loader::receivedAllData):
463         (WebCore::Loader::cancelRequests):
464         * loader/mac/LoaderFunctionsMac.mm:
465         (WebCore::NumberOfPendingOrLoadingRequests):
466         (WebCore::CheckCacheObjectStatus):
467         * page/Frame.cpp:
468         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
469         (WebCore::Frame::Frame):
470         (WebCore::Frame::stopLoading):
471         (WebCore::Frame::setAutoLoadImages):
472         (WebCore::Frame::autoLoadImages):
473         (WebCore::Frame::begin):
474         (WebCore::Frame::checkCompleted):
475         (WebCore::Frame::reparseConfiguration):
476         * page/Frame.h:
477         * xml/XSLTProcessor.cpp:
478         (WebCore::docLoaderFunc):
479         * xml/xmlhttprequest.cpp:
480         (WebCore::XMLHttpRequest::send):
481
482 2006-10-18  Maciej Stachowiak  <mjs@apple.com>
483
484         Reviewed by Geoff.
485
486         - remove vestiges of KXMLCore name (former name of WTF).
487
488         * config.h:
489
490 2006-10-18  Geoffrey Garen  <ggaren@apple.com>
491
492         Reviewed by Beth.
493         
494         Fixed http://bugs.webkit.org/show_bug.cgi?id=11222
495
496         Some global JS objects lacked references to their property hashtables,
497         so for-in enumeration didn't work. I added the references, and then removed
498         a few bogus properties from the tables. The bogus ones got in there through
499         bit rot.
500         
501         We should come up with some solution to these hand-written bindings bugs.
502         Maybe we could use a script to autogenerate them or something.
503
504         * bindings/js/kjs_window.cpp:
505         (KJS::):
506         (KJS::History::getValueProperty):
507
508 2006-10-18  Adam Roben  <aroben@apple.com>
509
510         Reviewed by Brady.
511
512         Change Shift-Tab to generate keyIdentifier U+000009 (Tab) instead of
513         U+000019 (Backtab). This matches our windowsKeyCode for this key
514         combination.
515
516         * platform/mac/KeyEventMac.mm:
517         (WebCore::keyIdentifierForKeyEvent):
518
519 2006-10-18  Steve Falkenburg  <sfalken@apple.com>
520
521         Reviewed by Adam, Brady.
522
523         Loader tweaks.
524
525         * platform/cf/ResourceLoaderCFNet.cpp:
526         (WebCore::didFinishLoading):
527         (WebCore::didFail):
528         (WebCore::didReceiveChallenge):
529         (WebCore::runLoaderThread):
530         (WebCore::ResourceLoader::start):
531         (WebCore::ResourceLoader::cancel):
532
533 2006-10-18  Timothy Hatcher  <timothy@apple.com>
534
535         Reviewed by Darin.
536
537         <rdar://problem/4752138> Manipulating popup in HTML page crashed Xcode
538
539         - Store the Mac popup button cell as a RetainPtr to prevent GC collection.
540         - Convert more ObjC local statics and member variables to use RetainPtr.
541         - Convert more CFRetain/CFRelease to HardRetain/HardRelease.
542
543         * bindings/objc/DOM.mm:
544         (ObjCNodeFilterCondition::ObjCNodeFilterCondition): use HardRetain and not CFRetain
545         (ObjCNodeFilterCondition::~ObjCNodeFilterCondition): use HardRelease and not CFRelease
546         * bridge/mac/AXObjectCacheMac.mm:
547         (WebCore::AXObjectCache::~AXObjectCache): use HardRelease and not CFRelease
548         (WebCore::AXObjectCache::get): use HardRetain and not CFRetain
549         (WebCore::AXObjectCache::remove): use HardRelease and not CFRelease
550         * bridge/mac/WebCoreFrameBridge.mm:
551         (+[WebCoreFrameBridge supportedImageResourceMIMETypes]): use RetainPtr
552         (+[WebCoreFrameBridge supportedImageMIMETypes]): ditto
553         * bridge/mac/WebCoreIconDatabaseBridge.mm:
554         (+[WebCoreIconDatabaseBridge sharedInstance]): use RetainPtr
555         * platform/PopupMenu.h: renamed popup to m_popup and switched to RetainPtr<NSPopUpButtonCell>
556         * platform/cf/RetainPtr.h:
557         (WTF::::operator): implement a missing operator= template function
558         * platform/mac/PopupMenuMac.mm:
559         (WebCore::PopupMenu::PopupMenu): remove nil initialization
560         (WebCore::PopupMenu::~PopupMenu): use .get(), remove release message and rename to m_popup
561         (WebCore::PopupMenu::clear): use .get() when sending a message and rename to m_popup
562         (WebCore::PopupMenu::populate): ditto 
563         (WebCore::PopupMenu::show): ditto
564         (WebCore::PopupMenu::hide): ditto
565         (WebCore::PopupMenu::addSeparator): ditto
566         (WebCore::PopupMenu::addGroupLabel): ditto
567         (WebCore::PopupMenu::addOption): ditto
568
569 2006-10-18  Geoffrey Garen  <ggaren@apple.com>
570
571         Reviewed by Adele.
572
573         Fixed <rdar://problem/3673233> JavaScript timers do not fire if controls
574         are tracking or menus are down (run loop modes)
575
576         I spent a few hours trying to write an automated test, but DRT doesn't
577         seem to support it. Manual tests attached to related bugs.
578         
579         * bridge/mac/FrameMac.mm:
580         (WebCore::FrameMac::passMouseDownEventToWidget):
581         * platform/mac/SharedTimerMac.cpp:
582         (WebCore::setSharedTimerFireTime):
583
584 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
585
586         Reviewed by Maciej.
587
588         More Win32 buildfix.
589
590         * bridge/win/FrameWin.h:
591
592 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
593
594         Reviewed by Mitz
595
596         Win32 build fix.
597
598         * bridge/win/BrowserExtensionWin.cpp:
599         (WebCore::BrowserExtensionWin::BrowserExtensionWin):
600         (WebCore::BrowserExtensionWin::createNewWindow):
601         * bridge/win/BrowserExtensionWin.h:
602         * bridge/win/FrameWin.cpp:
603         (WebCore::FrameWin::createNewWindow):
604         * bridge/win/FrameWin.h:
605         * platform/win/CursorWin.cpp:
606         * platform/win/TemporaryLinkStubs.cpp:
607         (Image::getHBITMAP):
608
609 2006-10-18  Justin Garcia  <justin.garcia@apple.com>
610
611         Reviewed by harrison
612         
613         <rdar://problem/4784823>
614         GMail Editor: Hang occurs when removing list styling on text in a rich text message
615
616         List removal moves the contents of every list item out of the list it's 
617         in. When the code tried to move the contents of an empty list item (an li 
618         with no child nodes, not even a placeholder br), moveParagraph didn't prune 
619         the li, like it would if the li had a placeholder inside it.  So the list 
620         removal code went into an infinite loop, continually attempting to de-list 
621         an empty list item.
622
623         * editing/CompositeEditCommand.cpp:
624         (WebCore::CompositeEditCommand::moveParagraphs): If the selection
625         to move was empty and in an empty block that doesn't require a 
626         placeholder to prop itself open (like a bordered div or an li), 
627         remove it during the move.
628
629 2006-10-18  Adele Peterson  <adele@apple.com>
630
631         Reviewed by Beth.
632
633         - Fixed http://bugs.webkit.org/show_bug.cgi?id=11343
634           REGRESSION (r16975): fast/events/objc-event-api is failing
635
636           When I moved the autoscroll code from FrameMac to Frame, I mistakingly changed the order of
637           a call to invalidateClick.  This change moves it back to the sequence that existed before.  This allows
638           the click count to get properly reset during a selection.
639
640         * page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent):
641
642 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
643         
644         Reviewed by Anders.
645         
646         Factored common scaling code into a helper function.
647
648         * platform/mac/ScreenMac.mm:
649         (WebCore::scale):
650         (WebCore::scaleScreenRectToPageCoordinates):
651         (WebCore::scalePageRectToScreenCoordinates):
652
653 2006-10-17  Steve Falkenburg  <sfalken@apple.com>
654
655         Build fixes
656
657         * bridge/win/BrowserExtensionWin.cpp:
658         (WebCore::BrowserExtensionWin::createNewWindow):
659         * bridge/win/BrowserExtensionWin.h:
660         * bridge/win/FrameWin.cpp:
661         (WebCore::FrameWin::createNewWindow):
662         * bridge/win/FrameWin.h:
663         * platform/gdk/BrowserExtensionGdk.h:
664         * platform/gdk/TemporaryLinkStubs.cpp:
665         (BrowserExtensionGdk::createNewWindow):
666         * platform/qt/BrowserExtensionQt.cpp:
667         (WebCore::BrowserExtensionQt::createNewWindow):
668         * platform/qt/BrowserExtensionQt.h:
669
670 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
671
672         Reviewed by Anders.
673         
674         Renamed WindowArgs to WindowFeatures, and moved it into its own header.
675         ("Features" is the term of art in IE documentation. "Args" is pirate
676         talk.)
677
678         * WebCore.xcodeproj/project.pbxproj:
679         * bindings/js/kjs_window.cpp:
680         (KJS::createNewWindow):
681         (KJS::showModalDialog):
682         (KJS::setWindowFeature):
683         (KJS::parseWindowFeatures):
684         (KJS::constrainToVisible):
685         (KJS::WindowFunc::callAsFunction):
686         * bridge/BrowserExtension.h:
687         * bridge/WindowFeatures.h: Added.
688         * bridge/mac/BrowserExtensionMac.h:
689         * bridge/mac/BrowserExtensionMac.mm:
690         (WebCore::BrowserExtensionMac::createNewWindow):
691
692 2006-10-17  Sam Weinig  <sam.weinig@gmail.com>
693
694         Reviewed by Tim H.
695
696         Patch for http://bugs.webkit.org/show_bug.cgi?id=11268
697         Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint
698
699         - Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.
700
701         - Moves the contents of ksvg/bindings/js/ to bindings/js/.
702
703         - Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.
704
705         - Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching 
706           the other CSSValue classing, and allowing the bindings to allocate
707           appropriately.
708
709         - Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing
710           generation for Objective-C.
711
712         - Assorted style cleanups.
713
714         * DerivedSources.make:
715         * WebCore.xcodeproj/project.pbxproj:
716         * bindings/objc/DOMCSS.mm:
717         (+[DOMCSSValue _CSSValueWith:WebCore::]):
718         * bindings/objc/DOMEvents.mm:
719         (+[DOMEvent _eventWith:WebCore::]):
720         * bindings/objc/DOMSVG.h:
721         * bindings/objc/DOMSVGNumber.mm:
722         (-[DOMSVGNumber dealloc]):
723         (-[DOMSVGNumber finalize]):
724         (-[DOMSVGNumber value]):
725         (-[DOMSVGNumber setValue:]):
726         (-[DOMSVGNumber _SVGNumber]):
727         (-[DOMSVGNumber _initWithFloat:]):
728         (+[DOMSVGNumber _SVGNumberWith:]):
729         * bindings/objc/DOMSVGPoint.mm:
730         (-[DOMSVGPoint dealloc]):
731         (-[DOMSVGPoint finalize]):
732         (-[DOMSVGPoint x]):
733         (-[DOMSVGPoint setX:]):
734         (-[DOMSVGPoint y]):
735         (-[DOMSVGPoint setY:]):
736         (-[DOMSVGPoint WebCore::]):
737         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
738         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
739         * bindings/objc/DOMSVGRect.mm:
740         (-[DOMSVGRect dealloc]):
741         (-[DOMSVGRect finalize]):
742         (-[DOMSVGRect x]):
743         (-[DOMSVGRect setX:]):
744         (-[DOMSVGRect y]):
745         (-[DOMSVGRect setY:]):
746         (-[DOMSVGRect width]):
747         (-[DOMSVGRect setWidth:]):
748         (-[DOMSVGRect height]):
749         (-[DOMSVGRect setHeight:]):
750         (-[DOMSVGRect WebCore::]):
751         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
752         (+[DOMSVGRect _SVGRectWith:WebCore::]):
753         * bindings/scripts/CodeGeneratorObjC.pm:
754         * css/StyleBase.h:
755         (WebCore::StyleBase::isSVGColor):
756         (WebCore::StyleBase::isSVGPaint):
757         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
758         * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
759         * ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
760         * ksvg2/bindings/js/JSSVGNumber.h: Removed.
761         * ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
762         * ksvg2/bindings/js/JSSVGPoint.h: Removed.
763         * ksvg2/bindings/js/JSSVGRect.cpp: Removed.
764         * ksvg2/bindings/js/JSSVGRect.h: Removed.
765         * ksvg2/svg/SVGColor.h:
766         (WebCore::SVGColor::isSVGColor):
767         * ksvg2/svg/SVGFECompositeElement.idl:
768         * ksvg2/svg/SVGFEFloodElement.idl:
769         * ksvg2/svg/SVGLocatable.idl:
770         * ksvg2/svg/SVGMarkerElement.idl:
771         * ksvg2/svg/SVGPaint.h:
772         (WebCore::SVGPaint::isSVGPaint):
773         * ksvg2/svg/SVGRectElement.idl:
774         * ksvg2/svg/SVGZoomEvent.idl: Removed.
775
776 2006-10-17  David Hyatt  <hyatt@apple.com>
777
778         Prepare for the elimination of the RenderLayer for <html> elements.  The layer is still present,
779         but this patch makes everything work without a root layer being around.
780
781         Reviewed by beth
782
783         * rendering/RenderBlock.cpp:
784         (WebCore::RenderBlock::paint):
785         (WebCore::RenderBlock::paintChildren):
786         (WebCore::RenderBlock::nodeAtPoint):
787         * rendering/RenderLayer.cpp:
788         (WebCore::frameVisibleRect):
789         (WebCore::RenderLayer::hitTest):
790         (WebCore::RenderLayer::hitTestLayer):
791         (WebCore::RenderLayer::intersectsDamageRect):
792         * rendering/RenderObject.cpp:
793         (WebCore::RenderObject::setInnerNode):
794         * rendering/RenderView.cpp:
795         (WebCore::RenderView::paint):
796
797 2006-10-17  David Hyatt  <hyatt@apple.com>
798
799         Back out my previous patch to the WebCore memory cache.
800
801         * loader/Cache.cpp:
802         (WebCore::Cache::flush):
803         (WebCore::Cache::setSize):
804         (WebCore::Cache::getLRUListFor):
805         (WebCore::Cache::removeFromLRUList):
806         (WebCore::Cache::insertInLRUList):
807         * loader/Cache.h:
808         * loader/CachedCSSStyleSheet.cpp:
809         (WebCore::CachedCSSStyleSheet::deref):
810         * loader/CachedCSSStyleSheet.h:
811         * loader/CachedImage.cpp:
812         (WebCore::CachedImage::deref):
813         * loader/CachedImage.h:
814         * loader/CachedResource.cpp:
815         (WebCore::CachedResource::setRequest):
816         (WebCore::CachedResource::deref):
817         * loader/CachedResource.h:
818         (WebCore::CachedResource::allowInLRUList):
819         * loader/CachedScript.cpp:
820         (WebCore::CachedScript::deref):
821         * loader/CachedScript.h:
822         * loader/CachedXBLDocument.cpp:
823         (WebCore::CachedXBLDocument::deref):
824         * loader/CachedXBLDocument.h:
825         * loader/CachedXSLStyleSheet.cpp:
826         (WebCore::CachedXSLStyleSheet::deref):
827         * loader/CachedXSLStyleSheet.h:
828
829 2006-10-17  Oliver Hunt  <oliver@apple.com>
830
831         Reviewed by Anders.
832
833         Make north and east resize cursors use correct image
834
835         * platform/win/CursorWin.cpp:
836         (WebCore::eastResizeCursor):
837         (WebCore::northResizeCursor):
838
839 2006-10-17  Oliver Hunt  <oliver@apple.com>
840
841         Reviewed by Brady
842
843         Various cursor fixes
844
845         * page/FrameView.cpp:
846         (WebCore::FrameView::handleMouseMoveEvent):
847         * platform/Cursor.h:
848         * platform/mac/CursorMac.mm:
849         (WebCore::pointerCursor):
850         * platform/win/CursorWin.cpp:
851         (WebCore::supportsAlphaCursors):
852         (WebCore::Cursor::Cursor):
853         (WebCore::Cursor::~Cursor):
854         (WebCore::pointerCursor):
855
856 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
857
858         Reviewed by harrison
859         
860         <rdar://problem/4776665>
861         REGRESSION: In Mail, caret is visible when the message body isn't focused
862
863         * page/Frame.cpp:
864         (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error
865         (like when the frame that contains the caret isn't focused) then we don't 
866         want to paint the caret.  We should eventually move to using a single bool
867         for caret painting.
868
869 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
870
871         Reviewed by harrison
872         
873         <rdar://problem/4774354>
874         REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
875
876         Functions call recomputCaretRect to see if the caret rect has changed, 
877         and, if it has, they invalidate (repaint) it.  recomputeCaretRect was 
878         returning false if the caret turned into a range selection or was blown 
879         away.
880
881         * editing/SelectionController.cpp:
882         (WebCore::SelectionController::recomputeCaretRect): Don't early return if
883         !isCaret().  Obtain the FrameView* using the m_frame pointer, because m_sel 
884         may now be null.
885
886 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
887
888         Reviewed by Brady.
889
890         BrowserExtension cleanup.
891         
892         - Removed unnecessary #include of BrowserExtension in Frame.h, added
893         #includes to compensate in other files.
894         
895         - Removed unused versions of createNewWindow.
896         
897         * bindings/js/kjs_window.cpp:
898         * bridge/BrowserExtension.h:
899         * bridge/mac/BrowserExtensionMac.h:
900         * bridge/mac/BrowserExtensionMac.mm:
901         (WebCore::BrowserExtensionMac::createNewWindow):
902         * bridge/mac/WebCoreFrameBridge.mm:
903         * html/HTMLFormElement.cpp:
904         * loader/mac/LoaderFunctionsMac.mm:
905         * page/Frame.h:
906         * page/FramePrivate.h:
907
908 2006-10-15  Geoffrey Garen  <ggaren@apple.com>
909
910         Reviewed by Adam.
911         
912         - Fixed "FIXME: Violates Liskov Substitution principle."
913         
914         IFRAME was never a true subclass of FRAME, since they disagreed on a
915         number of behaviors, which, confusingly, IFRAME just overrode and contradicted. 
916
917         The fix here is to factor out things common to IFRAME and FRAME into a
918         common base class, HTMLFrameElementBase.
919         
920         I also changed some " *" to "* " and added #includes in files that implicitly
921         assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.
922
923 2006-10-16  Justin Garcia  <justin.garcia@apple.com>
924
925         Reviewed by sullivan
926         
927         <rdar://problem/4776765>
928         REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
929
930         We set m_needsLayout to false and call caretRect() in the hopes that it will give us 
931         the old caret rect.  It in fact corrects the caret rect for an offset that it 
932         believes is due to scrolling but which is actually due to a change in selection
933         without an accompanying layout.  So it returns the new caret rect regardless of
934         what m_needsLayout is set to.
935         
936         * editing/SelectionController.cpp:
937         (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that
938         adds a one pixel slop to this new function.
939         (WebCore::SelectionController::caretRepaintRect): Moved this code to
940         repaintRectForCaret.
941         (WebCore::SelectionController::recomputeCaretRect): Compare the old
942         caret rect to the new one that's computed with a fresh layout.  If
943         they are different, invalidate both repaint rects.
944
945 2006-10-17  David Harrison  <harrison@apple.com>
946
947         Reviewed by Adele.
948
949         <rdar://problem/4770453> VO not honoring secure edit fields in web pages
950
951         * bridge/mac/WebCoreAXObject.mm:
952         (-[WebCoreAXObject isPasswordField]):
953         New. Checks for input with inputType() of PASSWORD.
954         
955         (-[WebCoreAXObject subrole]):
956         Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].
957         
958         (-[WebCoreAXObject roleDescription]):
959         Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.
960         
961         (-[WebCoreAXObject value]):
962         Return nil if [self isPasswordField].
963         
964         (-[WebCoreAXObject accessibilityAttributeNames]):
965         Return generic attributes if [self isPasswordField].
966
967         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
968         Return empty array if [self isPasswordField].
969
970 2006-10-17  David Hyatt  <hyatt@apple.com>
971
972         Fix "flash to white' problem on yahoo.com as it finishes loading.  Refine the FOUC suppression
973         code so that it will only run if the body still has no renderer.
974
975         * dom/Document.cpp:
976         (WebCore::Document::updateLayoutIgnorePendingStylesheets):
977
978 2006-10-17  David Hyatt  <hyatt@apple.com>
979
980         Fix a bug where the WebCore memory cache could grow without bound during extended browsing
981         sessions.
982
983         Reviewed by mjs
984
985         * loader/Cache.cpp:
986         (WebCore::Cache::flush):
987         (WebCore::Cache::setSize):
988         (WebCore::Cache::getLRUListFor):
989         (WebCore::Cache::removeFromLRUList):
990         (WebCore::Cache::insertInLRUList):
991         * loader/Cache.h:
992         * loader/CachedCSSStyleSheet.cpp:
993         * loader/CachedCSSStyleSheet.h:
994         * loader/CachedImage.cpp:
995         * loader/CachedImage.h:
996         * loader/CachedResource.cpp:
997         (WebCore::CachedResource::setRequest):
998         (WebCore::CachedResource::deref):
999         * loader/CachedResource.h:
1000         (WebCore::CachedResource::allowInLRUList):
1001         * loader/CachedScript.cpp:
1002         * loader/CachedScript.h:
1003         * loader/CachedXBLDocument.cpp:
1004         * loader/CachedXBLDocument.h:
1005         * loader/CachedXSLStyleSheet.cpp:
1006         * loader/CachedXSLStyleSheet.h:
1007
1008 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
1009
1010         Reviewed by harrison
1011         
1012         <rdar://problem/3655385>
1013         Editing: -indent: method unimplemented
1014
1015         Added Frame and bridge methods.
1016
1017         * bridge/mac/WebCoreFrameBridge.h:
1018         * bridge/mac/WebCoreFrameBridge.mm:
1019         (-[WebCoreFrameBridge indent]):
1020         (-[WebCoreFrameBridge outdent]):
1021         * page/Frame.cpp:
1022         (WebCore::Frame::indent): 
1023         (WebCore::Frame::outdent):
1024         * page/Frame.h:
1025
1026 2006-10-16  Adam Roben  <aroben@apple.com>
1027
1028         Reviewed by John.
1029
1030         More menulist cleanup/tweaking.
1031
1032         * html/HTMLSelectElement.cpp:
1033         (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index'
1034         parameter to 'optionIndex' for clarity.
1035         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over
1036         items that are not enabled <option> elements when using arrow keys, and
1037         make sure we pass an option index to setSelectedIndex.
1038         * platform/PopupMenu.h:
1039         (WebCore::PopupMenu::setWasClicked): Specify default argument.
1040         * rendering/RenderMenuList.cpp:
1041         (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from
1042         option text before setting the control text so that options within
1043         <optgroup>s don't appear indented in the actual control.
1044
1045 2006-10-16  Sam Weinig  <sam.weinig@gmail.com>
1046
1047         Reviewed by Adam.
1048
1049         Win32 build fix.
1050
1051         * WebCore.vcproj/WebCore/WebCore.vcproj:
1052         * bridge/win/BrowserExtensionWin.cpp:
1053         (WebCore::BrowserExtensionWin::createNewWindow):
1054         * bridge/win/FrameWin.cpp:
1055         (WebCore::FrameWin::urlSelected):
1056         (WebCore::FrameWin::submitForm):
1057         (WebCore::FrameWin::createNewWindow):
1058         * bridge/win/FrameWin.h:
1059         * loader/loader.cpp:
1060         (WebCore::Loader::receivedResponse):
1061         * platform/win/GraphicsContextWin.cpp:
1062         (WebCore::GraphicsContext::getWindowsContext):
1063         (WebCore::GraphicsContext::releaseWindowsContext):
1064         * platform/win/TemporaryLinkStubs.cpp:
1065         (FrameWin::openURLRequest):
1066         (WebCore::ServeSynchronousRequest):
1067         (WebCore::CheckIfReloading):
1068         (WebCore::IsResponseURLEqualToURL):
1069         (WebCore::ResponseMIMEType):
1070         (WebCore::ResponseIsMultipart):
1071         (WebCore::CacheObjectExpiresTime):
1072         (CachedResource::setResponse):
1073         (CachedResource::setAllData):
1074         * rendering/RenderThemeWin.cpp:
1075         (WebCore::doneDrawing):
1076         (WebCore::RenderThemeWin::paintButton):
1077         (WebCore::RenderThemeWin::paintTextField):
1078
1079 2006-10-16  David Hyatt  <hyatt@apple.com>
1080
1081         Fix for bug 9347, positioned elements have the wrong containing block.  This is a change from CSS2 to
1082         CSS2.1.  In the absence of any other enclosing positioned elements, the containing block for a positioned
1083         element is the initial containing block (our RenderView).
1084
1085         Reviewed by mjs
1086
1087         Test cases added to fast/block/positioning for quirks and strict modes.
1088
1089         * rendering/RenderBlock.cpp:
1090         (WebCore::RenderBlock::lowestPosition):
1091         (WebCore::RenderBlock::rightmostPosition):
1092         (WebCore::RenderBlock::leftmostPosition):
1093         * rendering/RenderBox.cpp:
1094         (WebCore::RenderBox::containingBlockHeightForPositioned):
1095         (WebCore::RenderBox::calcAbsoluteVertical):
1096         * rendering/RenderObject.cpp:
1097         (WebCore::RenderObject::containingBlock):
1098         (WebCore::RenderObject::container):
1099
1100 2006-10-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1101
1102         Reviewed by Anders.
1103
1104         Misc Gdk/Linux build fixes.
1105
1106         * platform/gdk/BrowserExtensionGdk.h:
1107         * platform/gdk/FrameGdk.cpp:
1108         (WebCore::FrameGdk::submitForm):
1109         (WebCore::FrameGdk::urlSelected):
1110         * platform/gdk/FrameGdk.h:
1111         * platform/gdk/RenderPopupMenuGdk.cpp:
1112         (WebCore::PopupMenu::PopupMenu):
1113         (WebCore::PopupMenu::~PopupMenu):
1114         (WebCore::PopupMenu::clear):
1115         (WebCore::PopupMenu::populate):
1116         (WebCore::PopupMenu::show):
1117         (WebCore::PopupMenu::hide):
1118         (WebCore::PopupMenu::addSeparator):
1119         (WebCore::PopupMenu::addGroupLabel):
1120         (WebCore::PopupMenu::addOption):
1121         * platform/gdk/RenderPopupMenuGdk.h:
1122         * platform/gdk/RenderThemeGdk.cpp:
1123         * platform/gdk/RenderThemeGdk.h:
1124         (WebCore::RenderThemeGdk::RenderThemeGdk):
1125         * platform/gdk/TemporaryLinkStubs.cpp:
1126         (BrowserExtensionGdk::createNewWindow):
1127         (BrowserExtensionGdk::BrowserExtensionGdk):
1128         (BrowserExtensionGdk::setTypedIconURL):
1129         (BrowserExtensionGdk::setIconURL):
1130         (BrowserExtensionGdk::getHistoryLength):
1131         (WebCore::CheckIfReloading):
1132         (WebCore::CacheObjectExpiresTime):
1133         (WebCore::ResponseURL):
1134         (WebCore::IsResponseURLEqualToURL):
1135         (WebCore::ResponseIsMultipart):
1136         (WebCore::ResponseMIMEType):
1137         (WebCore::CachedResource::setResponse):
1138         (WebCore::CachedResource::setAllData):
1139         (FileChooser::disconnectUploadControl):
1140         * rendering/RenderTheme.h:
1141         * rendering/RenderThemeMac.h:
1142
1143 2006-10-15  Sam Weinig  <sam.weinig@gmail.com>
1144
1145         Reviewed by Mitz.
1146
1147         Fix for http://bugs.webkit.org/show_bug.cgi?id=11294
1148         Add getModifierState method to KeyboardEvent
1149
1150         * bindings/objc/DOMEvents.h:
1151         * bindings/objc/DOMEvents.mm:
1152         * bindings/objc/PublicDOMInterfaces.h:
1153         * dom/KeyboardEvent.cpp:
1154         (WebCore::KeyboardEvent::getModifierState):
1155         * dom/KeyboardEvent.h:
1156         * dom/KeyboardEvent.idl:
1157
1158 2006-10-15  Nikolas Zimmermann  <zimmermann@kde.org>
1159
1160         Reviewed and landed by ap.
1161
1162         Changed PlatformResponse handling for Qt. Don't just store
1163         a QString object containing the data but a new PlatformResponseQt struct
1164         containing data and url, and store it as pointer. This is compatible
1165         to the OS X handling and removes the Qt plaform specific hacks from
1166         CachedCSSStyleSheet, CachedResource & loader.
1167
1168         Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move
1169         all methods from TemporaryLinkStubs related to loading in there, and implement
1170         some like ServeSynchronousRequest (yay for xslt handling!).
1171
1172         * CMakeLists.txt:
1173         * loader/CachedCSSStyleSheet.cpp:
1174         (WebCore::CachedCSSStyleSheet::checkNotify):
1175         * loader/CachedResource.h:
1176         (WebCore::CachedResource::CachedResource):
1177         * loader/loader.cpp:
1178         (WebCore::Loader::receivedResponse):
1179         * platform/ResourceLoaderClient.h:
1180         * platform/ResourceLoaderInternal.h:
1181         * platform/qt/FrameQt.cpp:
1182         (WebCore::FrameQt::~FrameQt):
1183         (WebCore::FrameQt::createEmptyDocument):
1184         * platform/qt/FrameQt.h:
1185         (WebCore::QtFrame):
1186         * platform/qt/FrameQtClient.cpp:
1187         (WebCore::FrameQtClientDefault::setFrame):
1188         (WebCore::FrameQtClientDefault::openURL):
1189         (WebCore::FrameQtClientDefault::loadFinished):
1190         (WebCore::FrameQtClientDefault::receivedAllData):
1191         * platform/qt/FrameQtClient.h:
1192         * platform/qt/LoaderFunctionsQt.cpp: Added.
1193         (WebCore::ServeSynchronousRequest):
1194         (WebCore::NumberOfPendingOrLoadingRequests):
1195         (WebCore::CheckIfReloading):
1196         (WebCore::CheckCacheObjectStatus):
1197         (WebCore::IsResponseURLEqualToURL):
1198         (WebCore::ResponseURL):
1199         (WebCore::ResponseMIMEType):
1200         (WebCore::ResponseIsMultipart):
1201         (WebCore::CacheObjectExpiresTime):
1202         (WebCore::CachedResource::setResponse):
1203         (WebCore::CachedResource::setAllData):
1204         * platform/qt/ResourceLoaderManager.cpp:
1205         (WebCore::ResourceLoaderManager::remove):
1206         * platform/qt/ResourceLoaderQt.cpp:
1207         (WebCore::ResourceLoader::~ResourceLoader):
1208         (WebCore::ResourceLoader::start):
1209         (WebCore::ResourceLoader::assembleResponseHeaders):
1210         (WebCore::ResourceLoader::receivedResponse):
1211         * platform/qt/TemporaryLinkStubs.cpp:
1212
1213 2006-10-14  Rob Buis  <buis@kde.org>
1214
1215         Reviewed by Mitz.
1216
1217         http://bugs.webkit.org/show_bug.cgi?id=11217
1218         Cleanup svg coding style
1219
1220         Cleanup coding style in svg basic datastructure classes.
1221
1222         * ksvg2/svg/SVGAngle.cpp:
1223         (WebCore::SVGAngle::valueAsString):
1224         (WebCore::SVGAngle::context):
1225         (WebCore::SVGAngle::setContext):
1226         * ksvg2/svg/SVGAngle.h:
1227         * ksvg2/svg/SVGColor.cpp:
1228         * ksvg2/svg/SVGColor.h:
1229         * ksvg2/svg/SVGElement.cpp:
1230         (WebCore::SVGElement::ownerSVGElement):
1231         (WebCore::SVGElement::viewportElement):
1232         (WebCore::SVGElement::parseMappedAttribute):
1233         (WebCore::SVGElement::childShouldCreateRenderer):
1234         * ksvg2/svg/SVGElement.h:
1235         (WebCore::svg_dynamic_cast):
1236         * ksvg2/svg/SVGFitToViewBox.cpp:
1237         (WebCore::SVGFitToViewBox::parseViewBox):
1238         * ksvg2/svg/SVGFitToViewBox.h:
1239         * ksvg2/svg/SVGLangSpace.cpp:
1240         (WebCore::SVGLangSpace::parseMappedAttribute):
1241         * ksvg2/svg/SVGLangSpace.h:
1242         * ksvg2/svg/SVGLength.cpp:
1243         (WebCore::SVGLength::SVGLength):
1244         (WebCore::SVGLength::setValueAsString):
1245         (WebCore::SVGLength::dpi):
1246         (WebCore::SVGLength::updateValue):
1247         (WebCore::SVGLength::updateValueInSpecifiedUnits):
1248         (WebCore::SVGLength::context):
1249         (WebCore::SVGLength::setContext):
1250         * ksvg2/svg/SVGLength.h:
1251         * ksvg2/svg/SVGLengthList.cpp:
1252         * ksvg2/svg/SVGLengthList.h:
1253         * ksvg2/svg/SVGLocatable.cpp:
1254         (WebCore::SVGLocatable::nearestViewportElement):
1255         (WebCore::SVGLocatable::farthestViewportElement):
1256         (WebCore::SVGLocatable::getBBox):
1257         (WebCore::SVGLocatable::getCTM):
1258         (WebCore::SVGLocatable::getScreenCTM):
1259         * ksvg2/svg/SVGNumberList.cpp:
1260         * ksvg2/svg/SVGNumberList.h:
1261         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
1262         (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
1263         (WebCore::SVGPreserveAspectRatio::getCTM):
1264         * ksvg2/svg/SVGPreserveAspectRatio.h:
1265         * ksvg2/svg/SVGStringList.cpp:
1266         (WebCore::SVGStringList::reset):
1267         * ksvg2/svg/SVGStringList.h:
1268         * ksvg2/svg/SVGStylable.cpp:
1269         * ksvg2/svg/SVGStylable.h:
1270         * ksvg2/svg/SVGTests.cpp:
1271         (WebCore::SVGTests::requiredFeatures):
1272         (WebCore::SVGTests::requiredExtensions):
1273         (WebCore::SVGTests::systemLanguage):
1274         (WebCore::SVGTests::isValid):
1275         (WebCore::SVGTests::parseMappedAttribute):
1276         * ksvg2/svg/SVGTests.h:
1277         * ksvg2/svg/SVGTransformable.cpp:
1278         (WebCore::SVGTransformable::parseTransformAttribute):
1279         * ksvg2/svg/SVGTransformable.h:
1280         * ksvg2/svg/SVGURIReference.cpp:
1281         (WebCore::SVGURIReference::parseMappedAttribute):
1282         * ksvg2/svg/SVGZoomAndPan.cpp:
1283         (WebCore::SVGZoomAndPan::parseMappedAttribute):
1284         * ksvg2/svg/SVGZoomAndPan.h:
1285
1286 2006-10-15  Nikolas Zimmermann  <zimmermann@kde.org>
1287
1288         Reviewed by Oliver.
1289
1290         Implement some functions in FrameQt / ScrollViewQt.
1291
1292         Added comments what needs to be done in quite some places,
1293         marked some functions as no-ops.
1294
1295         * CMakeLists.txt:
1296         * platform/qt/FrameQt.cpp:
1297         (WebCore::FrameQt::FrameQt):
1298         (WebCore::FrameQt::runJavaScriptConfirm):
1299         (WebCore::FrameQt::locationbarVisible):
1300         (WebCore::FrameQt::createFrame):
1301         (WebCore::FrameQt::passSubframeEventToSubframe):
1302         (WebCore::FrameQt::menubarVisible):
1303         (WebCore::FrameQt::personalbarVisible):
1304         (WebCore::FrameQt::statusbarVisible):
1305         (WebCore::FrameQt::toolbarVisible):
1306         (WebCore::FrameQt::markedTextRange):
1307         (WebCore::FrameQt::lastEventIsMouseUp):
1308         (WebCore::FrameQt::openURLRequest):
1309         (WebCore::FrameQt::scheduleClose):
1310         (WebCore::FrameQt::unfocusWindow):
1311         (WebCore::FrameQt::focusWindow):
1312         (WebCore::FrameQt::overrideMediaType):
1313         (WebCore::FrameQt::runJavaScriptPrompt):
1314         (WebCore::FrameQt::bindingRootObject):
1315         (WebCore::FrameQt::addPluginRootObject):
1316         (WebCore::FrameQt::registerCommandForUndo):
1317         (WebCore::FrameQt::registerCommandForRedo):
1318         (WebCore::FrameQt::clearUndoRedoOperations):
1319         (WebCore::FrameQt::respondToChangedSelection):
1320         (WebCore::FrameQt::respondToChangedContents):
1321         (WebCore::FrameQt::shouldChangeSelection):
1322         (WebCore::FrameQt::canGoBackOrForward):
1323         (WebCore::FrameQt::canPaste):
1324         (WebCore::FrameQt::canRedo):
1325         (WebCore::FrameQt::canUndo):
1326         * platform/qt/FrameQt.h:
1327         * platform/qt/FrameQtClient.cpp:
1328         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
1329         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
1330         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
1331         (WebCore::FrameQtClientDefault::menubarVisible):
1332         (WebCore::FrameQtClientDefault::toolbarVisible):
1333         (WebCore::FrameQtClientDefault::statusbarVisible):
1334         (WebCore::FrameQtClientDefault::personalbarVisible):
1335         (WebCore::FrameQtClientDefault::locationbarVisible):
1336         * platform/qt/FrameQtClient.h:
1337         * platform/qt/ImageSourceQt.cpp:
1338         * platform/qt/RenderThemeQt.cpp:
1339         * platform/qt/ScrollViewQt.cpp:
1340         (WebCore::ScrollView::scrollPointRecursively):
1341         * platform/qt/TemporaryLinkStubs.cpp:
1342         (WebCore::CachedResource::setResponse):
1343         (WebCore::CachedResource::setAllData):
1344
1345 2006-10-14  David Harrison  <harrison@apple.com>
1346
1347         Reviewed by Geoff.
1348
1349         <rdar://problem/4775213> REGRESSION: Can't from tab from last link on the page to URL address field
1350         <rdar://problem/4783926> REGRESSION: Typing tab key enters no text
1351
1352         The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless
1353         of whether frame->view()->advanceFocus() actually changed the focus.
1354
1355         Trivial fix is to preventDefault() only if advanceFocus() returns true.
1356
1357         * No test is possible because DumpRenderTree sets the WebView preference to
1358         tab to links, and that preference cannot be changed dynamically after
1359         the webview is initialized. Also, the "tab from last link" is not testable
1360         because DumpRenderTree uses the WebView for the whole window, so tabs can't
1361         shift focus out of the WebView regardless.
1362
1363         * dom/EventTargetNode.cpp:
1364         (WebCore::EventTargetNode::defaultEventHandler):
1365
1366 2006-10-14  Nikolas Zimmermann  <zimmermann@kde.org>
1367
1368         Reviewed by Mitz.
1369
1370         Fix Qt/Linux build & some little fixes:
1371
1372         - Adapt to Maciej's FrameLoadRequest changes.
1373         - Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
1374         - Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
1375         - Fix CacheObjectExpiresTime/ResponseIsMultipart signature.
1376
1377         * loader/CachedCSSStyleSheet.cpp:
1378         (WebCore::CachedCSSStyleSheet::checkNotify):
1379         * loader/CachedResource.h:
1380         (WebCore::CachedResource::CachedResource):
1381         * loader/loader.cpp:
1382         (WebCore::Loader::receivedAllData):
1383         (WebCore::Loader::receivedResponse):
1384         * platform/qt/BrowserExtensionQt.cpp:
1385         (WebCore::BrowserExtensionQt::createNewWindow):
1386         * platform/qt/BrowserExtensionQt.h:
1387         * platform/qt/FrameQt.cpp:
1388         (WebCore::FrameQt::submitForm):
1389         (WebCore::FrameQt::urlSelected):
1390         (WebCore::FrameQt::openURLRequest):
1391         * platform/qt/FrameQt.h:
1392         * platform/qt/GraphicsContextQt.cpp:
1393         (WebCore::GraphicsContext::setURLForRect):
1394         * platform/qt/TemporaryLinkStubs.cpp:
1395         (WebCore::CacheObjectExpiresTime):
1396         (WebCore::ResponseIsMultipart):
1397         (WebCore::CachedResource::setResponse):
1398         (WebCore::CachedResource::setAllData):
1399
1400 2006-10-14  David Carson  <dacarson@gmail.com>
1401
1402         Reviewed by Maciej.
1403
1404         Fix: http://bugs.webkit.org/show_bug.cgi?id=11257
1405         Removed Mac platform dependance, changed WebCore functions to
1406         use PlatformResponse/PlatformData rather than NSURLResponse/
1407         NSData. 
1408
1409         * loader/CachedCSSStyleSheet.cpp:
1410         (WebCore::CachedCSSStyleSheet::checkNotify):
1411         * loader/CachedImage.cpp:
1412         (WebCore::CachedImage::createImage):
1413         * loader/CachedResource.cpp:
1414         (WebCore::CachedResource::~CachedResource):
1415         * loader/CachedResource.h:
1416         (WebCore::CachedResource::CachedResource):
1417         (WebCore::CachedResource::response):
1418         (WebCore::CachedResource::allData):
1419         * loader/LoaderFunctions.h:
1420         * loader/loader.cpp:
1421         (WebCore::Loader::receivedResponse):
1422         * loader/mac/LoaderFunctionsMac.mm:
1423         (WebCore::ResponseMIMEType):
1424         (WebCore::ResponseIsMultipart):
1425         (WebCore::CacheObjectExpiresTime):
1426         (WebCore::CachedResource::setResponse):
1427         (WebCore::CachedResource::setAllData):
1428         * platform/qt/TemporaryLinkStubs.cpp:
1429         (WebCore::CacheObjectExpiresTime):
1430         (WebCore::ResponseIsMultipart):
1431         (WebCore::ResponseMIMEType):
1432         (WebCore::CachedResource::setResponse):
1433         (WebCore::CachedResource::setAllData):
1434         * platform/win/TemporaryLinkStubs.cpp:
1435         (WebCore::CacheObjectExpiresTime):
1436         (WebCore::ResponseIsMultipart):
1437         (WebCore::ResponseMIMEType):
1438         (WebCore::CachedResource::setResponse):
1439         (WebCore::CachedResource::setAllData):
1440
1441 2006-10-14  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1442
1443         Reviewed by Maciej.
1444
1445         Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
1446         Pure virtual classes require non-pure destructor, who knew.
1447
1448         Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
1449         so that other platforms can also use CURL, if they wish.
1450
1451         Silence compiler warning about unused variable in SharedTimerLinux.cpp
1452
1453         * platform/ResourceLoaderInternal.h:
1454         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1455         * platform/gdk/FrameGdk.h:
1456         (WebCore::FrameGdkClient::~FrameGdkClient):
1457         * platform/gdk/ResourceLoaderManager.cpp:
1458         (WebCore::ResourceLoaderManager::downloadTimerCallback):
1459         * platform/gdk/SharedTimerLinux.cpp:
1460         (WebCore::stopSharedTimer):
1461
1462 2006-10-13  Beth Dakin  <bdakin@apple.com>
1463
1464         Reviewed by Geoff.
1465
1466         Build fix from my last check-in. Make hasOutlineAnnotation() non-
1467         inline so that we don't have to include Document.h in 
1468         RenderObject.h
1469         Doing so causes a build failure in WebKit, and it probably isn't a 
1470         good idea anyway.
1471
1472         * rendering/RenderObject.cpp:
1473         (WebCore::RenderObject::hasOutlineAnnotation):
1474         * rendering/RenderObject.h:
1475         (WebCore::RenderObject::hasOutline):
1476
1477 2006-10-13  Beth Dakin  <bdakin@apple.com>
1478
1479         Patch written mostly by Ken Kraisler, but also by me.
1480
1481         Reviewed by Hyatt.
1482
1483         Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
1484         problem/3391162> PDF created by printing should have live 
1485         hyperlinks
1486
1487         * platform/GraphicsContext.cpp:
1488         (WebCore::GraphicsContext::focusRingBoundingRect):
1489         * platform/GraphicsContext.h:
1490         * platform/cairo/GraphicsContextCairo.cpp:
1491         (WebCore::GraphicsContext::setURLForRect):
1492         * platform/cg/GraphicsContextCG.cpp:
1493         (WebCore::GraphicsContext::setURLForRect): Implement method to add 
1494         URL link to PDF document.
1495         * rendering/InlineFlowBox.cpp:
1496         (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of 
1497         querying the outline width
1498         * rendering/RenderBlock.cpp:
1499         (WebCore::RenderBlock::paintObject): Same as above.
1500         * rendering/RenderFlow.cpp:
1501         (WebCore::RenderFlow::paintLines): Call the new paintOutline()
1502         (WebCore::RenderFlow::paintOutline): Take care of focus ring and 
1503         pdf url rects, and outline painting.
1504         * rendering/RenderFlow.h:
1505         * rendering/RenderObject.cpp:
1506         (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF 
1507         link to a rectanglular region.
1508         (WebCore::RenderObject::paintOutline): Take care of pdf rects as 
1509         well as focus ring painting.
1510         * rendering/RenderObject.h:
1511         (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the 
1512         element is a link and we are printing.
1513         (WebCore::RenderObject::hasOutline): Returns true is the style has 
1514         an outline and hasOutlineAnnotation() is true.
1515         * rendering/RenderStyle.h:
1516         (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is 
1517         greater than 0 and outlineStyle is greater than BHIDDEN.
1518
1519 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
1520
1521         Reviewed by ggaren and harrison
1522         
1523         <rdar://problem/4744008>
1524         9A270: Mail crashes when I try to paste large items from Safari
1525
1526         * editing/ReplaceSelectionCommand.cpp:
1527         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
1528         Even though we put nodes in the hash map in pre-order, they don't necessary
1529         come out of the iterator that way.  If a node is a redundant style span
1530         and one of its pruned ancestors comes off the hash map after it, and that
1531         ancestor is a redundant style span or font tag, we will try to remove it
1532         even though it has already been removed and we'll crash.
1533         The test case added with the fix depends on our hash map implementation
1534         because it requires that a particular redundant style span come out of 
1535         the iterator before its parent. So, it may eventually not provide 
1536         coverage for the fix.
1537
1538 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
1539
1540         Reviewed by Darin.
1541
1542         - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
1543
1544         * WebCore.xcodeproj/project.pbxproj:
1545         * bindings/js/kjs_window.cpp:
1546         (KJS::createNewWindow):
1547         (KJS::WindowFunc::callAsFunction):
1548         * bridge/BrowserExtension.h:
1549         * bridge/mac/BrowserExtensionMac.h:
1550         * bridge/mac/BrowserExtensionMac.mm:
1551         (WebCore::BrowserExtensionMac::createNewWindow):
1552         * bridge/mac/FrameMac.h:
1553         * bridge/mac/FrameMac.mm:
1554         (WebCore::FrameMac::submitForm):
1555         (WebCore::FrameMac::openURLRequest):
1556         (WebCore::FrameMac::urlSelected):
1557         * bridge/win/BrowserExtensionWin.h:
1558         * page/Frame.cpp:
1559         (WebCore::Frame::changeLocation):
1560         (WebCore::Frame::urlSelected):
1561         (WebCore::Frame::requestFrame):
1562         (WebCore::Frame::submitForm):
1563         * page/Frame.h:
1564         * page/FrameLoadRequest.h: Added.
1565         (WebCore::FrameLoadRequest::FrameLoadRequest):
1566         (WebCore::FrameLoadRequest::lockHistory):
1567         (WebCore::FrameLoadRequest::setLockHistory):
1568         * page/ResourceRequest.h:
1569         (WebCore::ResourceRequest::ResourceRequest):
1570
1571 2006-10-13  John Sullivan  <sullivan@apple.com>
1572
1573         Reviewed by Maciej
1574
1575         * loader/mac/WebFrameLoader.mm:
1576         (-[WebFrameLoader loadDocumentLoader:]):
1577         Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can
1578         happen when loading a page during a decidePolicyForNavigationAction callback.
1579
1580 2006-10-13  Dave Hyatt  <hyatt@apple.com>
1581
1582         Transparency layer work.
1583
1584         Reviewed by aroben
1585
1586         * platform/GraphicsContext.h:
1587         * platform/cg/GraphicsContextCG.cpp:
1588         (WebCore::GraphicsContext::beginTransparencyLayer):
1589         (WebCore::GraphicsContext::endTransparencyLayer):
1590         * platform/cg/GraphicsContextPlatformPrivate.h:
1591         (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
1592         (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
1593
1594 2006-10-13  Rob Buis  <buis@kde.org>
1595
1596         Reviewed by Mitz.
1597
1598         http://bugs.webkit.org/show_bug.cgi?id=11217
1599         Cleanup svg coding style
1600
1601         Cleanup coding style in svg paint server classes.
1602
1603         * ksvg2/svg/SVGGradientElement.cpp:
1604         (WebCore::SVGGradientElement::SVGGradientElement):
1605         (WebCore::SVGGradientElement::parseMappedAttribute):
1606         (WebCore::SVGGradientElement::notifyAttributeChange):
1607         (WebCore::SVGGradientElement::canvasResource):
1608         (WebCore::SVGGradientElement::rebuildStops):
1609         * ksvg2/svg/SVGGradientElement.h:
1610         * ksvg2/svg/SVGLinearGradientElement.cpp:
1611         (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
1612         (WebCore::SVGLinearGradientElement::parseMappedAttribute):
1613         (WebCore::SVGLinearGradientElement::buildGradient):
1614         * ksvg2/svg/SVGLinearGradientElement.h:
1615         * ksvg2/svg/SVGPatternElement.cpp:
1616         (WebCore::SVGPatternElement::SVGPatternElement):
1617         (WebCore::SVGPatternElement::parseMappedAttribute):
1618         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1619         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1620         (WebCore::SVGPatternElement::notifyClientsToRepaint):
1621         (WebCore::SVGPatternElement::notifyAttributeChange):
1622         (WebCore::SVGPatternElement::canvasResource):
1623         (WebCore::SVGPatternElement::getCTM):
1624         * ksvg2/svg/SVGPatternElement.h:
1625         (WebCore::SVGPatternElement::rendererIsNeeded):
1626         * ksvg2/svg/SVGRadialGradientElement.cpp:
1627         (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
1628         (WebCore::SVGRadialGradientElement::parseMappedAttribute):
1629         (WebCore::SVGRadialGradientElement::buildGradient):
1630         * ksvg2/svg/SVGRadialGradientElement.h:
1631         * ksvg2/svg/SVGStopElement.cpp:
1632         (WebCore::SVGStopElement::SVGStopElement):
1633         (WebCore::SVGStopElement::parseMappedAttribute):
1634         * ksvg2/svg/SVGStopElement.h:
1635
1636 2006-10-13  Geoffrey Garen  <ggaren@apple.com>
1637
1638         Reviewed by Darin, John.
1639
1640         - Merged more frame and iframe code
1641         - Fixed a bug where iframes returned incorrect values for renderer-dependent 
1642         properties during javascript: loads because they didn't have renderers at 
1643         load time
1644         
1645         PLT insists this is a small performance win. Don't believe its lies.
1646
1647         * bindings/js/kjs_html.cpp:
1648         (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to
1649         width and height, for consistency with the rest of the DOM.
1650         * dom/ContainerNode.cpp:
1651         (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback
1652         queue that gets drained after the render tree is fully constructed. Currently,
1653         this is only used for frame loading.
1654         (WebCore::ContainerNode::attach):
1655         * dom/ContainerNode.h:
1656         * html/HTMLFrameElement.cpp:
1657         (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from
1658         attach() because loading iframes during attach() causes a crash. 
1659         Moved frame loading logic into insertedIntoDocument(). That's a more 
1660         logical place for it because  document insertion is what 
1661         triggers frame loading. Made frame loading a post-attach callback, instead
1662         of an immediate action, to fix the incorrect values bug.
1663         (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be
1664         in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon 
1665         require this call, once I remove the call from WebKit.
1666         (WebCore::HTMLFrameElement::setLocation):
1667         (WebCore::HTMLFrameElement::width):
1668         (WebCore::HTMLFrameElement::height):
1669         * html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary
1670         killing of puppies.
1671         * html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement
1672         (WebCore::HTMLIFrameElement::rendererIsNeeded):
1673         (WebCore::HTMLIFrameElement::createRenderer):
1674         (WebCore::HTMLIFrameElement::insertedIntoDocument):
1675         (WebCore::HTMLIFrameElement::removedFromDocument):
1676         (WebCore::HTMLIFrameElement::attach):
1677         * page/FrameView.h: Removed unused method.
1678
1679 2006-10-13  David Harrison  <harrison@apple.com>
1680
1681         Reviewed by Justin.
1682
1683         <rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
1684
1685         Tests added or changed:
1686         * editing/style/style-boundary-005.html: Added. Matches steps from bug.
1687         * editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
1688         * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
1689         * editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
1690         * editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
1691
1692         * dom/Text.cpp:
1693         (WebCore::Text::splitText):
1694         Comment changes.
1695         
1696         * editing/ApplyStyleCommand.cpp:
1697         (WebCore::isUnstyledStyleSpan):
1698         Renamed from isEmptyStyleSpan.
1699         
1700         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
1701         Rename emptySpans local to unstyledSpans.
1702         
1703         (WebCore::dummySpanAncestorForNode):
1704         New. To locate Apple style span created when splitting a text node.
1705         
1706         (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
1707         Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
1708         of dummy span's parents, rather than traversing up from start and
1709         end locations. Old algorithm would miss empty spans in the bug case.
1710         
1711         (WebCore::ApplyStyleCommand::applyInlineStyle):
1712         Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().
1713         
1714         (WebCore::ApplyStyleCommand::removeCSSStyle):
1715         Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().
1716         
1717         (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
1718         Comment changes.
1719         
1720         * editing/ApplyStyleCommand.h:
1721         Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().
1722           
1723         * editing/ReplaceSelectionCommand.cpp:
1724         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
1725         Allow for Apple style span to be unstyled, because old email may have this in the DOM.
1726         Use !node->hasChildNodes() instead of !node->firstChild().
1727         
1728         * editing/SplitTextNodeCommand.cpp:
1729         (WebCore::SplitTextNodeCommand::doApply):
1730         Comment changes.
1731         
1732         * rendering/RenderTreeAsText.cpp:
1733         (WebCore::isEmptyOrUnstyledAppleStyleSpan):
1734         (WebCore::operator<<):
1735         Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM
1736
1737 2006-10-13  Nikolas Zimmermann  <zimmermann@kde.org>
1738
1739         Reviewed by Eric.
1740
1741         Fix Qt/Linux build after Adele's popup menu changes.
1742
1743         * CMakeLists.txt:
1744         * platform/qt/FileChooserQt.cpp:
1745         (WebCore::FileChooser::disconnectUploadControl):
1746         * platform/qt/PopupMenuQt.cpp: Added.
1747         (WebCore::PopupMenu::PopupMenu):
1748         (WebCore::PopupMenu::~PopupMenu):
1749         (WebCore::PopupMenu::clear):
1750         (WebCore::PopupMenu::populate):
1751         (WebCore::PopupMenu::show):
1752         (WebCore::PopupMenu::hide):
1753         (WebCore::PopupMenu::addSeparator):
1754         (WebCore::PopupMenu::addGroupLabel):
1755         (WebCore::PopupMenu::addOption):
1756         * platform/qt/RenderPopupMenuQt.cpp: Removed.
1757         * platform/qt/RenderPopupMenuQt.h: Removed.
1758         * platform/qt/RenderThemeQt.cpp:
1759
1760 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
1761
1762         Reviewed by Darin.
1763
1764         fixed build failure 
1765
1766         * WebCore.xcodeproj/project.pbxproj:
1767         * loader/mac/WebFrameLoader.mm:
1768
1769 2006-10-13  Darin Adler  <darin@apple.com>
1770
1771         Reviewed by Adele.
1772
1773         - converted WebFormState from Objective-C to C++
1774
1775         * WebCore.exp: Added a new symbol, changed one symbol from C to C++.
1776
1777         * WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project".
1778         Added UChar.h and FrameLoaderTypes.h.
1779
1780         * loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.
1781
1782         * loader/mac/WebFormState.h: Converted class to C++.
1783         * loader/mac/WebFormState.mm: Ditto.
1784
1785         * loader/mac/WebFrameLoader.h:
1786         * loader/mac/WebFrameLoader.mm:
1787         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
1788         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
1789         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
1790         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
1791         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
1792         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
1793         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
1794         (-[WebFrameLoader continueAfterNavigationPolicy:]):
1795         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
1796         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
1797         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
1798         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
1799         Changed Objective-C WebFormState uses to C++ WebCore::FormState.
1800
1801 2006-10-13  Adele Peterson  <adele@apple.com>
1802
1803         Reviewed by Maciej.
1804
1805         - Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color
1806
1807         * rendering/RenderListBox.cpp:
1808         (WebCore::RenderListBox::paintItemForeground):
1809         * rendering/RenderTheme.cpp:
1810         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
1811         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
1812         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
1813         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
1814         * rendering/RenderThemeMac.h:
1815         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
1816
1817 2006-10-13  Rob Buis  <buis@kde.org>
1818
1819         Reviewed by Mitz.
1820
1821         http://bugs.webkit.org/show_bug.cgi?id=11217
1822         Cleanup svg coding style
1823
1824         Cleanup coding style in svg structure classes.
1825
1826         * ksvg2/svg/SVGDefsElement.cpp:
1827         (WebCore::SVGDefsElement::SVGDefsElement):
1828         * ksvg2/svg/SVGDefsElement.h:
1829         * ksvg2/svg/SVGDescElement.cpp:
1830         (WebCore::SVGDescElement::SVGDescElement):
1831         * ksvg2/svg/SVGDescElement.h:
1832         * ksvg2/svg/SVGDocument.cpp:
1833         * ksvg2/svg/SVGDocument.h:
1834         * ksvg2/svg/SVGElementInstance.cpp:
1835         (WebCore::SVGElementInstance::SVGElementInstance):
1836         (WebCore::SVGElementInstance::correspondingElement):
1837         (WebCore::SVGElementInstance::correspondingUseElement):
1838         (WebCore::SVGElementInstance::parentNode):
1839         (WebCore::SVGElementInstance::childNodes):
1840         (WebCore::SVGElementInstance::previousSibling):
1841         (WebCore::SVGElementInstance::nextSibling):
1842         (WebCore::SVGElementInstance::firstChild):
1843         (WebCore::SVGElementInstance::lastChild):
1844         * ksvg2/svg/SVGElementInstance.h:
1845         * ksvg2/svg/SVGElementInstanceList.cpp:
1846         * ksvg2/svg/SVGElementInstanceList.h:
1847         * ksvg2/svg/SVGGElement.cpp:
1848         (WebCore::SVGGElement::SVGGElement):
1849         (WebCore::SVGGElement::parseMappedAttribute):
1850         (WebCore::SVGDummyElement::SVGDummyElement):
1851         * ksvg2/svg/SVGGElement.h:
1852         (WebCore::SVGGElement::rendererIsNeeded):
1853         * ksvg2/svg/SVGImageElement.cpp:
1854         (WebCore::SVGImageElement::createRenderer):
1855         * ksvg2/svg/SVGImageElement.h:
1856         * ksvg2/svg/SVGSVGElement.cpp:
1857         (WebCore::SVGSVGElement::SVGSVGElement):
1858         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
1859         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
1860         (WebCore::SVGSVGElement::currentScale):
1861         (WebCore::SVGSVGElement::setCurrentScale):
1862         (WebCore::SVGSVGElement::currentTranslate):
1863         (WebCore::SVGSVGElement::parseMappedAttribute):
1864         (WebCore::SVGSVGElement::suspendRedraw):
1865         (WebCore::SVGSVGElement::unsuspendRedraw):
1866         (WebCore::SVGSVGElement::unsuspendRedrawAll):
1867         (WebCore::SVGSVGElement::forceRedraw):
1868         (WebCore::SVGSVGElement::getIntersectionList):
1869         (WebCore::SVGSVGElement::getEnclosureList):
1870         (WebCore::SVGSVGElement::checkIntersection):
1871         (WebCore::SVGSVGElement::checkEnclosure):
1872         (WebCore::SVGSVGElement::deselectAll):
1873         (WebCore::SVGSVGElement::createSVGLength):
1874         (WebCore::SVGSVGElement::createSVGAngle):
1875         (WebCore::SVGSVGElement::createSVGMatrix):
1876         (WebCore::SVGSVGElement::createSVGTransform):
1877         (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
1878         (WebCore::SVGSVGElement::getCTM):
1879         (WebCore::SVGSVGElement::getScreenCTM):
1880         (WebCore::SVGSVGElement::setCurrentTime):
1881         * ksvg2/svg/SVGSVGElement.h:
1882         (WebCore::SVGSVGElement::rendererIsNeeded):
1883         * ksvg2/svg/SVGSwitchElement.cpp:
1884         (WebCore::SVGSwitchElement::SVGSwitchElement):
1885         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
1886         * ksvg2/svg/SVGSwitchElement.h:
1887         (WebCore::SVGSwitchElement::rendererIsNeeded):
1888         * ksvg2/svg/SVGSymbolElement.cpp:
1889         (WebCore::SVGSymbolElement::SVGSymbolElement):
1890         (WebCore::SVGSymbolElement::parseMappedAttribute):
1891         * ksvg2/svg/SVGSymbolElement.h:
1892         (WebCore::SVGSymbolElement::shouldAttachChild):
1893         * ksvg2/svg/SVGTitleElement.cpp:
1894         (WebCore::SVGTitleElement::SVGTitleElement):
1895         * ksvg2/svg/SVGTitleElement.h:
1896         * ksvg2/svg/SVGUseElement.cpp:
1897         (WebCore::SVGUseElement::parseMappedAttribute):
1898         (WebCore::SVGUseElement::closeRenderer):
1899         * ksvg2/svg/SVGUseElement.h:
1900         (WebCore::SVGUseElement::rendererIsNeeded):
1901
1902 2006-10-12  Adele Peterson  <adele@apple.com>
1903
1904         Reviewed by Anders.
1905
1906         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11172
1907           REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
1908         
1909          Test: fast/forms/listbox-width-change.html
1910
1911         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
1912           When the options change, call setNeedsLayoutAndMinMaxRecalc.
1913
1914 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
1915
1916         Reviewed by Oliver.
1917
1918         - moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies
1919
1920         * WebCore.xcodeproj/project.pbxproj:
1921         * bridge/mac/WebCoreFrameBridge.h:
1922         * bridge/mac/WebCoreFrameBridge.mm:
1923         (stringByCollapsingNonPrintingCharacters):
1924         (-[WebCoreFrameBridge setTitle:]):
1925         (-[WebCoreFrameBridge didFirstLayout]):
1926         (-[WebCoreFrameBridge notifyIconChanged:]):
1927         (-[WebCoreFrameBridge originalRequestURL]):
1928         (-[WebCoreFrameBridge isLoadTypeReload]):
1929         (-[WebCoreFrameBridge frameDetached]):
1930         (-[WebCoreFrameBridge tokenizerProcessedData]):
1931         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
1932         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
1933         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
1934         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
1935         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
1936         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
1937         (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
1938         (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
1939         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
1940         (-[WebCoreFrameBridge incomingReferrer]):
1941         (-[WebCoreFrameBridge isReloading]):
1942         (-[WebCoreFrameBridge handledOnloadEvents]):
1943         (-[WebCoreFrameBridge mainResourceURLResponse]):
1944         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
1945         * loader/mac/LoaderNSURLExtras.h:
1946         * loader/mac/LoaderNSURLRequestExtras.h: Added.
1947         * loader/mac/LoaderNSURLRequestExtras.m: Added.
1948         (isConditionalRequest):
1949         (setHTTPReferrer):
1950         * loader/mac/WebFrameLoader.mm:
1951         * loader/mac/WebSubresourceLoader.mm:
1952
1953 2006-10-12  Adele Peterson  <adele@apple.com>
1954
1955         RS by Geoff.
1956
1957         Renamed menuListIsDetaching to disconnectMenuList, 
1958         uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.  
1959         These names match similar methods in WebCore a little better.
1960
1961         * platform/FileChooser.h:
1962         * platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
1963         * platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]):
1964         (WebCore::FileChooser::disconnectUploadControl):
1965         * platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
1966         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1967         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):
1968
1969 2006-10-12  Adele Peterson  <adele@apple.com>
1970
1971         Reviewed by Maciej.
1972
1973         WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
1974
1975         Added private delegate method for clients that want access to a PopupMenu's NSMenu.
1976
1977         * bridge/mac/FrameMac.h:
1978         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
1979         * bridge/mac/WebCoreFrameBridge.h:
1980
1981         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.
1982
1983 2006-10-12  Adele Peterson  <adele@apple.com>
1984
1985         Reviewed by Alice.
1986
1987         - Fix for <rdar://problem/4707372> 
1988           After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu
1989
1990         * platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
1991         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
1992         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up,
1993           in case the RenderMenuList goes away.  Also, checks the pointer to the menu list immediately afterwards.
1994
1995 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
1996
1997         Reviewed by Maciej.
1998
1999         Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
2000         document.open(); document.write(..); and NO document.close(). On the Qt platform this
2001         leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
2002         DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.
2003
2004         Hmpf, this took me nine hours to debug today.
2005         Result: Couldn't find the real fix, going for a workaround for now.
2006         
2007         540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.
2008
2009         * platform/qt/FrameQt.cpp:
2010         (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
2011         * platform/qt/FrameQtClient.cpp:
2012         (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().
2013
2014 2006-10-12  Adam Roben  <aroben@apple.com>
2015
2016         Reviewed by Adele.
2017
2018         Move popup menu code out of rendering/ and into platform/.
2019         RenderPopupMenu becomes PopupMenu, the
2020         RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
2021         virtual methods go away, RenderTheme gets to stop worrying about popup
2022         menus, PopupMenu becomes ref-counted, and everyone becomes happy.
2023
2024         * WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
2025         * WebCore.xcodeproj/project.pbxproj: Ditto.
2026         * html/HTMLSelectElement.cpp: Remove unnecessary #include.
2027         * platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp.
2028         Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate
2029         from RenderMenuList::showPopup/hidePopup.
2030         (WebCore::PopupMenu::create): New static creation method to hand back a
2031         PassRefPtr<PopupMenu>.
2032         (WebCore::PopupMenu::addItems): This platform-independent method should
2033         be called by PopupMenu::populate when the platform-specific
2034         implementation is ready to receive the menu items. Fixed an ASSERT
2035         while I was at it.
2036         * platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more
2037         need for virtual methods.
2038         (WebCore::PopupMenu::wasClicked):
2039         (WebCore::PopupMenu::setWasClicked):
2040         (WebCore::PopupMenu::popupHandle):
2041         * platform/mac/PopupMenuMac.mm: Moved from
2042         rendering/RenderPopupMenuMac.mm. Much renaming ensues.
2043         (WebCore::PopupMenu::PopupMenu):
2044         (WebCore::PopupMenu::~PopupMenu):
2045         (WebCore::PopupMenu::clear):
2046         (WebCore::PopupMenu::populate):
2047         (WebCore::PopupMenu::show):
2048         (WebCore::PopupMenu::hide):
2049         (WebCore::PopupMenu::addSeparator):
2050         (WebCore::PopupMenu::addGroupLabel): Since we don't have our own
2051         RenderStyle anymore, just pick up the style from our RenderMenuList.
2052         (WebCore::PopupMenu::addOption): Ditto.
2053         * platform/win/TemporaryLinkStubs.cpp: Rename-fest.
2054         (PopupMenu::PopupMenu):
2055         (PopupMenu::~PopupMenu):
2056         (PopupMenu::clear):
2057         (PopupMenu::populate):
2058         (PopupMenu::show):
2059         (PopupMenu::hide):
2060         (PopupMenu::addSeparator):
2061         (PopupMenu::addGroupLabel):
2062         (PopupMenu::addOption):
2063         * rendering/RenderMenuList.cpp:
2064         (WebCore::RenderMenuList::~RenderMenuList):
2065         (WebCore::RenderMenuList::showPopup): Use nice new simple
2066         PopupMenu::create to make the popup.
2067         (WebCore::RenderMenuList::hidePopup):
2068         * rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a
2069         RenderPopupMenu*.
2070         (WebCore::RenderMenuList::popup):
2071         * rendering/RenderPopupMenu.cpp: Removed.
2072         * rendering/RenderPopupMenu.h: Removed.
2073         * rendering/RenderPopupMenuMac.h: Removed.
2074         * rendering/RenderPopupMenuMac.mm: Removed.
2075         * rendering/RenderPopupMenuWin.h: Removed.
2076         * rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
2077         * rendering/RenderTheme.h: Ditto.
2078         * rendering/RenderThemeMac.h: Ditto.
2079         * rendering/RenderThemeMac.mm: Ditto.
2080         * rendering/RenderThemeWin.cpp: Ditto.
2081         * rendering/RenderThemeWin.h: Ditto.
2082
2083 2006-10-12  Adele Peterson  <adele@apple.com>
2084
2085         Reviewed by Dave Harrison.
2086
2087         - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
2088
2089         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
2090         Make subtree layouts work for textareas as well as text fields.
2091
2092 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
2093
2094         Reviewed by MacDome.
2095
2096         Finally found a way to remove our begin() trickery in FrameQt.
2097         The (probably misnamed) Frame::setEncoding() function automatically
2098         calls Frame::receivedFirstData() which calls being on the working
2099         url, which has been passed to didOpenUrl(). Took me some hours
2100         to figure out that the missing charset logic, forced us to do hacks.
2101
2102         * platform/ResourceLoader.h:
2103         * platform/ResourceLoaderInternal.h:
2104         * platform/qt/FrameQt.cpp:
2105         (WebCore::FrameQt::tokenizerProcessedData):
2106         * platform/qt/FrameQt.h:
2107         * platform/qt/FrameQtClient.cpp:
2108         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
2109         (WebCore::FrameQtClientDefault::openURL):
2110         (WebCore::FrameQtClientDefault::submitForm):
2111         (WebCore::FrameQtClientDefault::receivedData):
2112         (WebCore::FrameQtClientDefault::receivedAllData):
2113         * platform/qt/FrameQtClient.h:
2114         * platform/qt/ResourceLoaderManager.cpp:
2115         (WebCore::ResourceLoaderManager::slotData):
2116         (WebCore::ResourceLoaderManager::slotMimetype):
2117         (WebCore::ResourceLoaderManager::slotResult):
2118         (WebCore::ResourceLoaderManager::remove):
2119         * platform/qt/ResourceLoaderQt.cpp:
2120         (WebCore::ResourceLoader::retrieveCharset):
2121         (WebCore::ResourceLoader::extractCharsetFromHeaders):
2122
2123 2006-10-12  Adam Roben  <aroben@apple.com>
2124
2125         Reviewed by Hyatt.
2126
2127         Bandaid-ing a null-dereference crash until a real fix is made.
2128
2129         * page/FrameView.cpp:
2130         (WebCore::FrameView::windowClipRect):
2131
2132 2006-10-12  Rob Buis  <buis@kde.org>
2133
2134         Reviewed by Mitz.
2135
2136         http://bugs.webkit.org/show_bug.cgi?id=11217
2137         Cleanup svg coding style
2138
2139         Cleanup coding style in svg text classes.
2140
2141         * ksvg2/svg/SVGTRefElement.cpp:
2142         (WebCore::SVGTRefElement::SVGTRefElement):
2143         (WebCore::SVGTRefElement::updateReferencedText):
2144         (WebCore::SVGTRefElement::parseMappedAttribute):
2145         (WebCore::SVGTRefElement::childShouldCreateRenderer):
2146         (WebCore::SVGTRefElement::createRenderer):
2147         * ksvg2/svg/SVGTRefElement.h:
2148         (WebCore::SVGTRefElement::rendererIsNeeded):
2149         * ksvg2/svg/SVGTSpanElement.cpp:
2150         (WebCore::SVGTSpanElement::SVGTSpanElement):
2151         (WebCore::SVGTSpanElement::childShouldCreateRenderer):
2152         (WebCore::SVGTSpanElement::createRenderer):
2153         * ksvg2/svg/SVGTSpanElement.h:
2154         (WebCore::SVGTSpanElement::rendererIsNeeded):
2155         * ksvg2/svg/SVGTextContentElement.cpp:
2156         (WebCore::SVGTextContentElement::SVGTextContentElement):
2157         (WebCore::SVGTextContentElement::parseMappedAttribute):
2158         * ksvg2/svg/SVGTextContentElement.h:
2159         * ksvg2/svg/SVGTextElement.cpp:
2160         (WebCore::SVGTextElement::SVGTextElement):
2161         (WebCore::SVGTextElement::localMatrix):
2162         (WebCore::SVGTextElement::parseMappedAttribute):
2163         (WebCore::SVGTextElement::updateLocalTransform):
2164         (WebCore::SVGTextElement::nearestViewportElement):
2165         (WebCore::SVGTextElement::farthestViewportElement):
2166         (WebCore::SVGTextElement::getScreenCTM):
2167         (WebCore::SVGTextElement::getCTM):
2168         (WebCore::SVGTextElement::createRenderer):
2169         (WebCore::SVGTextElement::childShouldCreateRenderer):
2170         * ksvg2/svg/SVGTextElement.h:
2171         (WebCore::SVGTextElement::getTransformToElement):
2172         (WebCore::SVGTextElement::rendererIsNeeded):
2173         * ksvg2/svg/SVGTextPositioningElement.cpp:
2174         (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
2175         (WebCore::SVGTextPositioningElement::parseMappedAttribute):
2176         * ksvg2/svg/SVGTextPositioningElement.h:
2177
2178 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
2179
2180         Reviewed by Maciej.
2181
2182         Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.
2183
2184         * platform/qt/FrameQt.cpp:
2185         (WebCore::FrameQt::runJavaScriptAlert): Move runJavaScriptAlert functionality to FrameQtClientDefault.
2186         * platform/qt/FrameQtClient.cpp:
2187         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
2188         * platform/qt/FrameQtClient.h:
2189
2190 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
2191
2192         Reviewed by Eric.
2193
2194         - move m_responseMIMEType out of ResourceRequest, where it doesn't belong
2195
2196         * page/FramePrivate.h: Add m_responseMIMEType
2197         * page/ResourceRequest.h: Remove m_responseMIMEType
2198         * page/Frame.cpp:
2199         (WebCore::Frame::setResponseMIMEType): added
2200         (WebCore::Frame::responseMIMEType): added
2201         (WebCore::Frame::begin): get MIME type from the right place
2202         (WebCore::Frame::write): ditto
2203         * page/Frame.h:
2204         * bindings/js/kjs_window.cpp:
2205         (KJS::createNewWindow): updated to use new Frame methods
2206         (KJS::WindowFunc::callAsFunction): ditto
2207         * bridge/mac/WebCoreFrameBridge.mm:
2208         (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto
2209         (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
2210         * loader/PluginDocument.cpp:
2211         (WebCore::PluginTokenizer::createDocumentStructure): ditto
2212
2213 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
2214
2215         Reviewed by Eric.
2216         
2217         <rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image
2218
2219         We really need some way to test loadHTMLString since it keeps breaking!
2220         
2221         * loader/mac/WebFrameLoader.mm:
2222         (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.
2223
2224 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
2225
2226         Reviewed by Eric.
2227
2228         Fix Qt/Linux build.
2229
2230         * CMakeLists.txt:
2231         * platform/qt/FileChooserQt.cpp:
2232         (WebCore::FileChooser::create):
2233
2234 2006-10-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2235
2236         Reviewed by Maciej.
2237
2238         Update Gdk\Linux build for recent changes, based on Qt code
2239
2240         * platform/gdk/FrameGdk.cpp:
2241         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2242         (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault):
2243         (WebCore::FrameGdkClientDefault::setFrame):
2244         (WebCore::FrameGdkClientDefault::openURL):
2245         (WebCore::FrameGdkClientDefault::submitForm):
2246         (WebCore::FrameGdkClientDefault::receivedResponse):
2247         (WebCore::FrameGdkClientDefault::receivedData):
2248         (WebCore::FrameGdkClientDefault::receivedAllData):
2249         (WebCore::FrameGdk::FrameGdk):
2250         (WebCore::FrameGdk::openURL):
2251         (WebCore::FrameGdk::submitForm):
2252         (WebCore::FrameGdk::urlSelected):
2253         * platform/gdk/FrameGdk.h:
2254         * platform/gdk/TemporaryLinkStubs.cpp:
2255         (FrameGdk::createJavaAppletWidget):
2256         (FileChooser::create):
2257
2258 2006-10-12  Dave Hyatt  <hyatt@apple.com>
2259
2260         Patch to add more clipping retrieval functionality for widgets.
2261        
2262         Reviewed by mjs
2263
2264         * page/Frame.h:
2265         Remove windowResizerRect.  This is in the wrong place.
2266         
2267         * page/FrameView.cpp:
2268         (WebCore::FrameView::windowClipRect):
2269         (WebCore::FrameView::windowClipRectForLayer):
2270         Break out windowClipRect into helper functions that can be called separately (to make
2271         it easier for scrollbars in overflow sections and list boxes to get to an enclosing
2272         layer and get the right clip.
2273         
2274         * page/FrameView.h:
2275         Add the new windowClipRect helper methods.
2276         
2277         * platform/ScrollBar.h:
2278         Add a new interface to ScrollbarClient so that scrollbars can hand back proper
2279         clip rects for themselves depending on how they are used.
2280         
2281         * platform/ScrollView.h:
2282         Stub out methods for talking to a double buffer backing store on Win32.
2283         
2284         * platform/Widget.h:
2285         Add the ability to query for invalidation suppression.
2286         
2287         * rendering/RenderLayer.cpp:
2288         (WebCore::RenderLayer::windowClipRect):
2289         (WebCore::RenderLayer::paintOverflowControls):
2290         (WebCore::RenderLayer::calculateRects):
2291         (WebCore::RenderLayer::childrenClipRect):
2292         (WebCore::RenderLayer::selfClipRect):
2293         * rendering/RenderLayer.h:
2294         Enhance layers so that they can return either their foreground or background
2295         document clip rects.  Make sure a layer scrollbar can return a proper clip.
2296         
2297         * rendering/RenderListBox.cpp:
2298         (WebCore::RenderListBox::windowClipRect):
2299         * rendering/RenderListBox.h:
2300         Make sure a list box scrollbar can return a proper clip.
2301         
2302         * rendering/RenderObject.cpp:
2303         (WebCore::RenderObject::enclosingLayer):
2304         * rendering/RenderObject.h:
2305         Make enclosingLayer const.
2306         
2307 2006-10-11  Darin Adler  <darin@apple.com>
2308
2309         Reviewed by John.
2310
2311         - some changes to prepare for converting more code to C++
2312
2313         * bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is
2314         self-sufficient.
2315
2316         * bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class.
2317         Needed since the class is used in this header (for some work I have not landed yet).
2318
2319         * loader/mac/LoaderNSURLExtras.h:
2320         * loader/mac/WebFormDataStream.h:
2321         Added extern "C" so this code can be used from C++.
2322
2323         * loader/mac/LoaderNSURLExtras.m:
2324         * loader/mac/WebDataProtocol.mm:
2325         * loader/mac/WebDocumentLoader.mm:
2326         * loader/mac/WebFormDataStream.m:
2327         * loader/mac/WebLoader.mm:
2328         * loader/mac/WebMainResourceLoader.mm:
2329         * loader/mac/WebNetscapePlugInStreamLoader.mm:
2330         * loader/mac/WebPolicyDecider.mm:
2331         * loader/mac/WebSubresourceLoader.mm:
2332         Added missing includes of config.h.
2333
2334 2006-10-11  John Sullivan  <sullivan@apple.com>
2335         
2336         Darin wrote this code; we tested it; I give it the thumbs up.
2337         
2338         - fixed regression from svn revision 16982 that was generating the wrong Obj-C classes
2339
2340         The hash table to look up an element class given a QualifiedName was
2341         not working at all.
2342
2343         * dom/QualifiedName.h:
2344         (WebCore::QualifiedName::impl):
2345         Added. This new accessor method for impl is needed if we want to use
2346         a QualifiedName as a hash table key without doing the kind of specialization
2347         we do for String. Maybe later we can do the String thing.
2348
2349         * bindings/objc/DOM.mm:
2350         (WebCore::addElementClass):
2351         Use QualifiedName.impl instead of the QualifiedName pointer itself.
2352         The QualifiedName pointer is *not* unique so almost nothing would be found
2353         in this hash table!
2354         (WebCore::elementClass):
2355         ditto
2356         
2357 2006-10-11  Adam Roben  <aroben@apple.com>
2358
2359         Rubberstamped by Anders.
2360
2361         Clean up FileChooser::create and Icon::newIconForFile.
2362
2363         * WebCore.xcodeproj/project.pbxproj:
2364         * platform/mac/FileChooserMac.mm:
2365         (WebCore::FileChooser::create):
2366         * platform/mac/IconMac.mm:
2367         (WebCore::Icon::newIconForFile):
2368
2369 2006-10-11  Oliver Hunt  <oliver@apple.com>
2370
2371         Reviewed by Adam.
2372
2373         Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
2374         Corrects canvas tag to not throw JS exception when drawing
2375         zero sized rects, arcs, etc
2376
2377         * html/CanvasRenderingContext2D.cpp:
2378         (WebCore::CanvasRenderingContext2D::arcTo):
2379         (WebCore::CanvasRenderingContext2D::arc):
2380         (WebCore::CanvasRenderingContext2D::rect):
2381         (WebCore::CanvasRenderingContext2D::clearRect):
2382         (WebCore::CanvasRenderingContext2D::fillRect):
2383         (WebCore::CanvasRenderingContext2D::strokeRect):
2384
2385 2006-10-11  Rob Buis  <buis@kde.org>
2386
2387         Reviewed by Mitz.
2388
2389         http://bugs.webkit.org/show_bug.cgi?id=11221
2390         REGRESSION: iExploder crash due to style="cursor: url()"
2391
2392         Take better care of empty cursor lists.
2393
2394         Test: fast/css/invalid-cursor-property-crash.html
2395
2396         * css/cssparser.cpp:
2397         (WebCore::CSSParser::parseValue):
2398
2399 2006-10-11  Adam Roben  <aroben@apple.com>
2400
2401         Fixing Windows for real this time.
2402
2403         * platform/win/TemporaryLinkStubs.cpp:
2404         (FileChooser::create):
2405
2406 2006-10-11  Adam Roben  <aroben@apple.com>
2407
2408         Fix Windows build.
2409
2410         * platform/win/TemporaryLinkStubs.cpp:
2411         (FileChooser::create):
2412
2413 2006-10-11  Antti Koivisto  <koivisto@iki.fi>
2414
2415         Reviewed by Hyatt.
2416         
2417         http://bugs.webkit.org/show_bug.cgi?id=4377
2418         
2419         Respect css visibility semantics for layers too
2420
2421         * rendering/RenderContainer.cpp:
2422         (WebCore::RenderContainer::removeChildNode):
2423         (WebCore::RenderContainer::appendChildNode):
2424         (WebCore::RenderContainer::insertChildNode):
2425         * rendering/RenderLayer.cpp:
2426         (WebCore::RenderLayer::RenderLayer):
2427         (WebCore::RenderLayer::updateLayerPositions):
2428         (WebCore::RenderLayer::setHasVisibleContent):
2429         (WebCore::RenderLayer::dirtyVisibleContentStatus):
2430         (WebCore::RenderLayer::childVisibilityChanged):
2431         (WebCore::RenderLayer::dirtyVisibleDescendantStatus):
2432         (WebCore::RenderLayer::updateVisibilityStatus):
2433         (WebCore::RenderLayer::addChild):
2434         (WebCore::RenderLayer::removeChild):
2435         (WebCore::RenderLayer::updateZOrderLists):
2436         (WebCore::RenderLayer::collectLayers):
2437         * rendering/RenderLayer.h:
2438         (WebCore::RenderLayer::hasVisibleContent):
2439         * rendering/RenderObject.cpp:
2440         (WebCore::RenderObject::setStyle):
2441
2442 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2443
2444         Reviewed by Oliver.
2445
2446         - added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
2447
2448         * WebCore.xcodeproj/project.pbxproj:
2449         * platform/cf/RetainPtr.h: Added.
2450         (WTF::):
2451         (WTF::RetainPtr::RetainPtr):
2452         (WTF::RetainPtr::~RetainPtr):
2453         (WTF::RetainPtr::get):
2454         (WTF::RetainPtr::operator*):
2455         (WTF::RetainPtr::operator->):
2456         (WTF::RetainPtr::operator!):
2457         (WTF::RetainPtr::operator UnspecifiedBoolType):
2458         (WTF::::operator):
2459         (WTF::::swap):
2460         (WTF::swap):
2461         (WTF::operator==):
2462         (WTF::operator!=):
2463         (WTF::static_pointer_cast):
2464         (WTF::const_pointer_cast):
2465         (WTF::getPtr):
2466         
2467         - use it in WidgetMac so it gets tested in at least one place
2468         
2469         * platform/mac/WidgetMac.mm:
2470         (WebCore::Widget::Widget):
2471         (WebCore::Widget::~Widget):
2472         (WebCore::Widget::setEnabled):
2473         (WebCore::Widget::isEnabled):
2474         (WebCore::Widget::setCursor):
2475         (WebCore::Widget::getView):
2476         (WebCore::Widget::setView):
2477         (WebCore::Widget::getOuterView):
2478
2479 2006-10-10  Brady Eidson  <beidson@apple.com>
2480
2481         Reviewed by Maciej.
2482
2483         Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge
2484
2485         * bridge/mac/WebCoreFrameBridge.h:
2486         * bridge/mac/WebCoreFrameBridge.mm:
2487         (-[WebCoreFrameBridge initMainFrameWithPage:]):
2488         (-[WebCoreFrameBridge initSubframeWithOwnerElement:]):
2489         (-[WebCoreFrameBridge dealloc]):
2490         (-[WebCoreFrameBridge close]):
2491         (-[WebCoreFrameBridge setFrameLoaderClient:]):
2492         (-[WebCoreFrameBridge frameLoader]):
2493         * loader/mac/WebFrameLoader.h:
2494         * loader/mac/WebFrameLoader.mm:
2495         (-[WebFrameLoader initWithFrameBridge:]):
2496         (-[WebFrameLoader setFrameLoaderClient:]):
2497
2498 2006-10-10  Adam Roben  <aroben@apple.com>
2499
2500         Reviewed by Oliver.
2501
2502         Make FileChooser ref-counted.
2503
2504         * platform/FileChooser.h:
2505         * platform/mac/FileChooserMac.mm:
2506         (WebCore::FileChooser::create):
2507         * rendering/RenderFileUploadControl.cpp:
2508         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2509         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
2510         * rendering/RenderFileUploadControl.h:
2511
2512 2006-10-10  Sam Weinig  <sam.weinig@gmail.com>
2513
2514         Reviewed by Tim H.
2515
2516         Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
2517         Even More auto-generated Objective-C DOM bindings changes
2518
2519         - Auto-generate DOMSVGPathElement.
2520
2521         - Auto-generate the internal interfaces even for classes that have
2522           custom internal implementations.  Change IDL property from ObjCNoInternal
2523           to ObjCCustomInternalImpl to indicate the change.
2524
2525         - Add SVG classes to DOMNode and DOMEvent internal interfaces.
2526
2527         - Add isSVGZoomEvent() method to Event class to match other Event subclasses
2528           and make DOM binding possible.
2529
2530         - Assorted cleanups.
2531
2532         * DerivedSources.make:
2533         * WebCore.xcodeproj/project.pbxproj:
2534         * bindings/objc/DOM.mm:
2535         (WebCore::addElementClass):
2536         (WebCore::createElementClassMap):
2537         (WebCore::elementClass):
2538         (-[DOMNode description]):
2539         (+[DOMNode _nodeWith:WebCore::]):
2540         (-[DOMNode addEventListener:listener:useCapture:]):
2541         (-[DOMNode removeEventListener:listener:useCapture:]):
2542         (-[DOMElement _NPObject]):
2543         (WebCore::ObjCEventListener::handleEvent):
2544         * bindings/objc/DOMEvents.mm:
2545         (+[DOMEvent _eventWith:WebCore::]):
2546         * bindings/objc/DOMInternal.h:
2547         * bindings/objc/DOMRGBColor.mm:
2548         (-[DOMRGBColor WebCore::]):
2549         * bindings/objc/DOMSVGPathSegInternal.h: Removed.
2550         * bindings/scripts/CodeGeneratorObjC.pm:
2551         * css/CSSRule.idl:
2552         * css/CSSValue.idl:
2553         * css/StyleSheet.idl:
2554         * dom/Event.cpp:
2555         (WebCore::Event::isSVGZoomEvent):
2556         * dom/Event.h:
2557         * dom/Event.idl:
2558         * dom/Node.idl:
2559         * ksvg2/events/SVGZoomEvent.cpp:
2560         (WebCore::SVGZoomEvent::isSVGZoomEvent):
2561         * ksvg2/events/SVGZoomEvent.h:
2562         * ksvg2/svg/SVGAnimatedAngle.idl:
2563         * ksvg2/svg/SVGCircleElement.idl:
2564         * ksvg2/svg/SVGClipPathElement.idl:
2565         * ksvg2/svg/SVGPathElement.idl:
2566         * ksvg2/svg/SVGPathSeg.idl:
2567
2568 2006-10-10  Oliver Hunt  <oliver@apple.com>
2569
2570         rubber stamped by Anders.
2571
2572         More buildbot bustage
2573
2574         * kcanvas/SVGInlineFlowBox.cpp:
2575         (WebCore::placeBoxesVerticallyWithAbsBaseline):
2576
2577 2006-10-10  Oliver Hunt  <oliver@apple.com>
2578
2579         Reviewed by Anders 
2580
2581         Unbreak build bots
2582
2583         * dom/Text.cpp:
2584         * kcanvas/RenderSVGText.cpp:
2585         (WebCore::RenderSVGText::layout):
2586         * kcanvas/SVGInlineFlowBox.cpp:
2587         (WebCore::placePositionedBoxesHorizontally):
2588         (WebCore::placeBoxesVerticallyWithAbsBaseline):
2589
2590 2006-10-10  Oliver Hunt  <oliver@apple.com>
2591
2592         Reviewed by hyatt.
2593
2594         Fixes bugs #6423, #6559, #10380 and #10839 
2595
2596         * WebCore.xcodeproj/project.pbxproj:
2597         * css/svg.css:
2598         * dom/Text.cpp:
2599         (WebCore::Text::createRenderer):
2600         * kcanvas/RenderSVGInline.cpp: Added.
2601         (WebCore::RenderSVGInline::RenderSVGInline):
2602         (WebCore::RenderSVGInline::createInlineBox):
2603         * kcanvas/RenderSVGInline.h: Added.
2604         (WebCore::RenderSVGInline::renderName):
2605         (WebCore::RenderSVGInline::requiresLayer):
2606         * kcanvas/RenderSVGInlineText.cpp: Added.
2607         (WebCore::RenderSVGInlineText::RenderSVGInlineText):
2608         (WebCore::RenderSVGInlineText::absoluteRects):
2609         (WebCore::RenderSVGInlineText::selectionRect):
2610         * kcanvas/RenderSVGInlineText.h: Added.
2611         (WebCore::RenderSVGInlineText::renderName):
2612         (WebCore::RenderSVGInlineText::requiresLayer):
2613         * kcanvas/RenderSVGTSpan.cpp: Added.
2614         (WebCore::RenderSVGTSpan::RenderSVGTSpan):
2615         (WebCore::RenderSVGTSpan::absoluteRects):
2616         * kcanvas/RenderSVGTSpan.h: Added.
2617         (WebCore::RenderSVGTSpan::renderName):
2618         * kcanvas/RenderSVGText.cpp:
2619         (WebCore::RenderSVGText::RenderSVGText):
2620         (WebCore::RenderSVGText::computeAbsoluteRepaintRect):
2621         (WebCore::RenderSVGText::layout):
2622         (WebCore::RenderSVGText::createInlineBox):
2623         (WebCore::RenderSVGText::nodeAtPoint):
2624         (WebCore::RenderSVGText::absoluteRects):
2625         (WebCore::RenderSVGText::paint):
2626         (WebCore::RenderSVGText::relativeBBox):
2627         * kcanvas/RenderSVGText.h:
2628         (WebCore::RenderSVGText::renderName):
2629         * kcanvas/SVGInlineFlowBox.cpp: Added.
2630         (WebCore::SVGInlineFlowBox::paint):
2631         (WebCore::SVGInlineFlowBox::placeBoxesHorizontally):
2632         (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
2633         (WebCore::paintSVGInlineFlow):
2634         (WebCore::translateBox):
2635         (WebCore::placePositionedBoxesHorizontally):
2636         (WebCore::placeSVGFlowHorizontally):
2637         (WebCore::placeBoxesVerticallyWithAbsBaseline):
2638         (WebCore::placeSVGFlowVertically):
2639         * kcanvas/SVGInlineFlowBox.h: Added.
2640         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
2641         * kcanvas/SVGRootInlineBox.cpp: Added.
2642         (WebCore::SVGRootInlineBox::paint):
2643         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
2644         (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
2645         * kcanvas/SVGRootInlineBox.h: Added.
2646         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
2647         * ksvg2/svg/SVGTRefElement.cpp:
2648         (SVGTRefElement::createRenderer):
2649         * ksvg2/svg/SVGTSpanElement.cpp:
2650         (SVGTSpanElement::createRenderer):
2651         * rendering/InlineFlowBox.h:
2652
2653 2006-10-10  Adam Roben  <aroben@apple.com>
2654
2655         Reviewed by Adele.
2656
2657         Improve popup menu behavior.
2658
2659         * html/HTMLSelectElement.cpp:
2660         (WebCore::HTMLSelectElement::HTMLSelectElement): Cache
2661         m_lastOnChangeIndex so we know when to fire onChange.
2662         (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to
2663         specify whether we should fire onChange.
2664         (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur.
2665         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire
2666         onChange when using the Enter key to change the selection.
2667         * html/HTMLSelectElement.h:
2668         * rendering/RenderMenuList.cpp:
2669         (WebCore::RenderMenuList::updateFromElement): Extract setText logic
2670         into its own method.
2671         (WebCore::RenderMenuList::setTextFromOption): New method.
2672         (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call
2673         onChange instead of calling it directly here.
2674         * rendering/RenderMenuList.h:
2675
2676 2006-10-10  Adele Peterson  <adele@apple.com>
2677
2678         Reviewed by Beth. 
2679
2680
2681         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text>
2682           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
2683
2684         Moved autoscroll code to the Frame class
2685
2686         * bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
2687         * bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags.  Moved autoscroll code to Frame::handleMouseMoveEvent.
2688         (WebCore::FrameMac::FrameMac):
2689         (WebCore::FrameMac::handleMousePressEvent):
2690         (WebCore::FrameMac::eventMayStartDrag):
2691         (WebCore::FrameMac::handleMouseMoveEvent):
2692         (WebCore::FrameMac::mouseDown):
2693
2694         * bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us.
2695         Now we scroll our views in WebCore.
2696
2697         * page/Frame.cpp:
2698         (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag.
2699         (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate.  Moved from FrameMac.
2700         (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too.
2701         (WebCore::Frame::mouseDownMayStartAutoscroll): Added.
2702         (WebCore::Frame::setMouseDownMayStartAutoscroll): Added.
2703         (WebCore::Frame::mouseDownMayStartDrag): Added.
2704         (WebCore::Frame::setMouseDownMayStartDrag): Added.
2705         (WebCore::Frame::autoscrollRenderer): Added
2706         (WebCore::Frame::setAutoscrollRenderer): Added.
2707         (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter.
2708         (WebCore::Frame::autoscrollTimerFired): ditto.
2709         (WebCore::Frame::stopAutoscrollTimer): ditto. 
2710         * page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.
2711
2712         * page/FramePrivate.h:
2713         (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags.  Moved from FrameMac.
2714
2715         * page/FrameView.cpp: Store the current mouse position in window coordinates.  The callers can convert to their own coordinate space.
2716         (WebCore::FrameView::handleMousePressEvent):
2717         (WebCore::FrameView::handleMouseDoubleClickEvent):
2718         (WebCore::FrameView::handleMouseMoveEvent):
2719         (WebCore::FrameView::handleMouseReleaseEvent):
2720
2721         * rendering/RenderLayer.cpp:
2722         (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection).  
2723          We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.
2724
2725         * rendering/RenderListBox.cpp:
2726         (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.
2727
2728         * rendering/RenderObject.cpp:
2729         (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too)
2730         (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.
2731
2732 2006-10-10  Darin Adler  <darin@apple.com>
2733
2734         Rubber stamped by Maciej.
2735
2736         - convert many of the loader source files to Objective-C++ to prepare
2737           to convert some of them to C++
2738
2739         * WebCore.xcodeproj/project.pbxproj:
2740         * loader/mac/WebDataProtocol.m: Removed.
2741         * loader/mac/WebDocumentLoader.m: Removed.
2742         * loader/mac/WebFormState.m: Removed.
2743         * loader/mac/WebFrameLoader.m: Removed.
2744         * loader/mac/WebLoader.m: Removed.
2745         * loader/mac/WebMainResourceLoader.m: Removed.
2746         * loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
2747         * loader/mac/WebPolicyDecider.m: Removed.
2748         * loader/mac/WebSubresourceLoader.m: Removed.
2749         * loader/mac/WebDataProtocol.mm: Added.
2750         * loader/mac/WebDocumentLoader.mm: Added.
2751         * loader/mac/WebFormState.mm: Added.
2752         * loader/mac/WebFrameLoader.mm: Added.
2753         * loader/mac/WebLoader.mm: Added.
2754         * loader/mac/WebMainResourceLoader.mm: Added.
2755         * loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
2756         * loader/mac/WebPolicyDecider.mm: Added.
2757         * loader/mac/WebSubresourceLoader.mm: Added.
2758
2759 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2760
2761         Reviewed by Mitz.
2762
2763         - fixed REGRESSION (r16960): crash on navigating to site
2764         http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE
2765         
2766         * loader/mac/WebFrameLoader.m:
2767         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2768         Add back a mistakenly removed retain.
2769
2770 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2771
2772         Not reviewed, build fix.
2773
2774         - fixed release build
2775
2776         * WebCore.xcodeproj/project.pbxproj:
2777
2778 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2779
2780         Rubber stamped by Eric.
2781
2782         - moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile
2783
2784         * WebCore.exp:
2785         * WebCore.xcodeproj/project.pbxproj:
2786         * loader/mac/LoaderNSURLExtras.m: Added.
2787         * loader/mac/WebDataProtocol.m: Added.
2788         * loader/mac/WebDocumentLoader.m: Added.
2789         * loader/mac/WebFormDataStream.m: Added.
2790         * loader/mac/WebFrameLoader.m: Added.
2791         * loader/mac/WebLoader.m: Added.
2792         (-[NSURLProtocol didReceiveResponse:]):
2793         (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
2794         * loader/mac/WebMainResourceLoader.m: Added.
2795         (-[WebMainResourceLoader didReceiveResponse:]):
2796         * loader/mac/WebPolicyDecider.m: Added.
2797         * loader/mac/WebSubresourceLoader.h: Added.
2798         * loader/mac/WebSubresourceLoader.m: Added.
2799
2800 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2801
2802         Reviewed by Oliver (sort of?)
2803
2804         - WebCore part of moving down NSURL extras
2805
2806         * WebCore.exp:
2807         * platform/mac/WebCoreSystemInterface.h:
2808         * platform/mac/WebCoreSystemInterface.mm:
2809
2810 2006-10-09  Rob Buis  <buis@kde.org>
2811
2812         Reviewed by Mitz.
2813
2814         http://bugs.webkit.org/show_bug.cgi?id=11217
2815         Cleanup svg coding style
2816
2817         Cleanup coding style in svg animation classes.
2818
2819         * ksvg2/svg/SVGAnimateColorElement.cpp:
2820         (WebCore::SVGAnimateColorElement::handleTimerEvent):
2821         * ksvg2/svg/SVGAnimateElement.cpp:
2822         (WebCore::SVGAnimateElement::SVGAnimateElement):
2823         (WebCore::SVGAnimateElement::handleTimerEvent):
2824         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2825         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
2826         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
2827         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2828         (WebCore::SVGAnimateTransformElement::parseTransformValue):
2829         (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):
2830         (WebCore::SVGAnimateTransformElement::initialMatrix):
2831         (WebCore::SVGAnimateTransformElement::transformMatrix):
2832         * ksvg2/svg/SVGAnimateTransformElement.h:
2833         * ksvg2/svg/SVGAnimatedPathData.cpp:
2834         * ksvg2/svg/SVGAnimatedPathData.h:
2835         * ksvg2/svg/SVGAnimatedPoints.cpp:
2836         * ksvg2/svg/SVGAnimatedPoints.h:
2837         * ksvg2/svg/SVGAnimationElement.cpp:
2838         (WebCore::SVGAnimationElement::targetElement):
2839
2840 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2841
2842         Reviewed by Oliver.
2843
2844         - added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion
2845
2846         * bridge/mac/WebCoreFrameBridge.h:
2847         * bridge/mac/WebCoreFrameBridge.mm:
2848         (-[WebCoreFrameBridge isMainFrame]):
2849
2850 2006-10-09  Adam Roben  <aroben@apple.com>
2851
2852         Backing out accidental commit.
2853
2854         * page/Frame.cpp:
2855         (WebCore::Frame::finishedParsing):
2856
2857 2006-10-09  Adam Roben  <aroben@apple.com>
2858
2859         Reviewed by Darin.
2860
2861         Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
2862         this could cause recursive calls to the destructor. RefPtr now also
2863         inherits from Noncopyable.
2864
2865         * dom/NodeFilter.h:
2866         * dom/Traversal.h:
2867         * page/DOMWindow.h:
2868         * page/Frame.cpp:
2869         (WebCore::Frame::finishedParsing):
2870         * page/Frame.h:
2871         * page/Plugin.h:
2872         * platform/FontFallbackList.h:
2873         * platform/Icon.h:
2874         * platform/Shared.h:
2875         (WebCore::Shared::Shared):
2876         (WebCore::Shared::ref):
2877         (WebCore::Shared::deref):
2878         (WebCore::Shared::hasOneRef):
2879         (WebCore::Shared::refCount):
2880         * platform/StringImpl.h:
2881
2882 2006-10-09  Oliver Hunt <ohunt@apple.com>
2883
2884         Reviewed by Anders.
2885
2886         Correcting ifdef's
2887
2888         * html/CanvasGradient.cpp:
2889         (WebCore::CanvasGradient::CanvasGradient):
2890         (WebCore::CanvasGradient::~CanvasGradient):
2891         (WebCore::CanvasGradient::addColorStop):
2892         * html/CanvasGradient.h:
2893         * html/CanvasPattern.cpp:
2894         (WebCore::CanvasPattern::CanvasPattern):
2895         (WebCore::CanvasPattern::~CanvasPattern):
2896         * html/CanvasPattern.h:
2897         * html/CanvasRenderingContext2D.cpp:
2898         (WebCore::CanvasRenderingContext2D::fill):
2899         (WebCore::CanvasRenderingContext2D::stroke):
2900         (WebCore::CanvasRenderingContext2D::fillRect):
2901         (WebCore::CanvasRenderingContext2D::setShadow):
2902         (WebCore::CanvasRenderingContext2D::applyShadow):
2903         (WebCore::CanvasRenderingContext2D::drawImage):
2904         (WebCore::CanvasRenderingContext2D::createPattern):
2905         (WebCore::CanvasRenderingContext2D::applyStrokePattern):
2906         (WebCore::CanvasRenderingContext2D::applyFillPattern):
2907         * html/CanvasRenderingContext2D.h:
2908         * html/CanvasStyle.cpp:
2909         (WebCore::CanvasStyle::applyStrokeColor):
2910         (WebCore::CanvasStyle::applyFillColor):
2911         * html/HTMLCanvasElement.cpp:
2912         (WebCore::HTMLCanvasElement::paint):
2913         (WebCore::HTMLCanvasElement::createDrawingContext):
2914         * html/HTMLCanvasElement.h:
2915
2916 2006-10-09  Adam Roben  <aroben@apple.com>
2917
2918         Reviewed by Maciej.
2919
2920         Fix a possible recursive destructor call.
2921
2922         * page/Frame.cpp:
2923         (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor.
2924         (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if
2925         we're already being destroyed.
2926
2927 2006-10-09  Sam Weinig  <sam.weinig@gmail.com>
2928
2929         Reviewed by Tim H.
2930
2931         Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
2932         Assorted Objective-C bindings changes
2933
2934         - Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, 
2935           DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, 
2936           DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, 
2937           DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, 
2938           DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, 
2939           DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, 
2940           DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, 
2941           DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, 
2942           DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.
2943
2944         - Auto-generate absoluteImageURL method for DOMHTMLInputElement and
2945           DOMHTMLObjectElement.
2946
2947         - Auto-generate the internal methods for classes with ivars (notably 
2948           DOMNodeIterator and DOMTreeWalker)
2949
2950         - Put more methods in the WebCore namespace and factor out the  
2951           displayString method into DOMInternal.h as done by Darin in his 
2952           patch for http://bugs.webkit.org/show_bug.cgi?id=11219.
2953
2954         * DerivedSources.make:
2955         * WebCore.xcodeproj/project.pbxproj:
2956         * bindings/objc/DOM.mm:
2957         (-[DOMNode _initWithNode:WebCore::]):
2958         (+[DOMNode _nodeWith:WebCore::]):
2959         (-[DOMNode addEventListener:listener:useCapture:]):
2960         (-[DOMNode removeEventListener:listener:useCapture:]):
2961         (-[DOMNode dispatchEvent:]):
2962         (-[DOMElement _imageTIFFRepresentation]):
2963         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
2964         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
2965         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2966         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2967         * bindings/objc/DOMCSS.mm:
2968         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2969         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
2970         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
2971         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
2972         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
2973         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2974         * bindings/objc/DOMEvents.mm:
2975         (-[DOMEvent _initWithEvent:WebCore::]):
2976         (+[DOMEvent _eventWith:WebCore::]):
2977         * bindings/objc/DOMExtensions.h:
2978         * bindings/objc/DOMHTML.mm:
2979         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
2980         * bindings/objc/DOMInternal.h:
2981         (-[DOMNodeFilter WebCore::]):
2982         * bindings/objc/DOMInternal.mm:
2983         (-[WebScriptObject _init]):
2984         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2985         (WebCore::displayString):
2986         * bindings/objc/DOMObject.mm:
2987         (-[DOMObject dealloc]):
2988         (-[DOMObject finalize]):
2989         * bindings/objc/DOMRGBColor.mm:
2990         (-[DOMRGBColor dealloc]):
2991         (-[DOMRGBColor finalize]):
2992         (-[DOMRGBColor color]):
2993         (-[DOMRGBColor _initWithRGB:WebCore::]):
2994         (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
2995         * bindings/objc/DOMSVG.h:
2996         * bindings/objc/DOMSVGPathSegInternal.h: Added.
2997         * bindings/objc/DOMSVGPathSegInternal.mm: Added.
2998         (-[DOMSVGPathSeg WebCore::]):
2999         (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]):
3000         (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
3001         * bindings/objc/DOMXPath.mm:
3002         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
3003         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
3004         * bindings/objc/PublicDOMInterfaces.h:
3005         * bindings/scripts/CodeGeneratorObjC.pm:
3006         * dom/NodeIterator.idl:
3007         * dom/TreeWalker.idl:
3008         * html/HTMLInputElement.idl:
3009         * html/HTMLObjectElement.idl:
3010         * ksvg2/svg/SVGDocument.idl:
3011         * ksvg2/svg/SVGElement.idl:
3012         * ksvg2/svg/SVGPathSeg.idl:
3013         * ksvg2/svg/SVGPathSegArcAbs.idl:
3014         * ksvg2/svg/SVGPathSegArcRel.idl:
3015         * ksvg2/svg/SVGPathSegClosePath.idl:
3016         * ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
3017         * ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
3018         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
3019         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
3020         * ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
3021         * ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
3022         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
3023         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
3024         * ksvg2/svg/SVGPathSegLinetoAbs.idl:
3025         * ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
3026         * ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
3027         * ksvg2/svg/SVGPathSegLinetoRel.idl:
3028         * ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
3029         * ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
3030         * ksvg2/svg/SVGPathSegMovetoAbs.idl:
3031         * ksvg2/svg/SVGPathSegMovetoRel.idl:
3032
3033 2006-10-09  Don Gibson  <dgibson77@gmail.com>
3034
3035         Unreviewed build fix.
3036
3037         Fix windows build bustage.
3038
3039         * platform/win/TemporaryLinkStubs.cpp:
3040
3041 2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3042
3043         Reviewed by Geoff.
3044
3045         Fix memory leaks discovered via valgrind. Gdk build fixes.
3046
3047         * Projects/gdk/webcore-gdk.bkl:
3048         * make-generated-sources.sh:
3049         * platform/cairo/ImageCairo.cpp:
3050         (WebCore::Image::draw):
3051         * platform/gdk/FrameGdk.cpp:
3052         (WebCore::FrameGdk::handleGdkEvent):
3053         * platform/gdk/FrameGdk.h:
3054         * platform/gdk/PlatformScrollBar.h:
3055         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
3056         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
3057
3058 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
3059
3060         Reviewed by Beth.
3061
3062         Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.
3063
3064         * platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly
3065         (WebCore::GlyphMap::fillPage):
3066
3067 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
3068
3069         Unreviewed build fix.
3070
3071         Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.
3072
3073         * platform/qt/FrameQt.cpp:
3074         (WebCore::FrameQt::createJavaAppletWidget):
3075         * platform/qt/FrameQt.h:
3076         * platform/qt/TemporaryLinkStubs.cpp:
3077
3078 2006-10-09  Brady Eidson  <beidson@apple.com>
3079
3080         Reviewed by Maciej
3081
3082         Tiny changes to help reorganize WebFrameLoader code in WebKit
3083
3084         * bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
3085         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3086         (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side
3087
3088 2006-10-09  Adam Roben  <aroben@apple.com>
3089
3090         Reviewed by Adele.
3091
3092         Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
3093         already called frome ~FrameMac.
3094
3095         * page/Frame.cpp:
3096         (WebCore::Frame::~Frame):
3097
3098 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
3099
3100         * bridge/win/FrameWin.h:
3101         Add function declaration.
3102         
3103 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
3104
3105         * platform/win/TemporaryLinkStubs.cpp:
3106         (FrameWin::createJavaAppletWidget):
3107         Try fixing the Win32 build.
3108
3109 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
3110
3111         Reviewed by Adam.
3112
3113         Move applet widget creation to Frame and get rid of JavaAppletWidget.
3114         * WebCore.xcodeproj/project.pbxproj:
3115         * bridge/JavaAppletWidget.h: Removed.
3116         * bridge/mac/FrameMac.h:
3117         * bridge/mac/FrameMac.mm:
3118         (WebCore::FrameMac::createJavaAppletWidget):
3119         * bridge/mac/JavaAppletWidget.mm: Removed.
3120         * page/Frame.h:
3121         * rendering/RenderApplet.cpp:
3122         (WebCore::RenderApplet::createWidgetIfNecessary):
3123
3124 2006-10-09  Mitz Pettel  <mitz@webkit.org>
3125
3126         Reviewed by Darin.
3127
3128         - http://bugs.webkit.org/show_bug.cgi?id=11220
3129           Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276
3130
3131         Subversion does not support resource forks and HFS metadata, so
3132         the resources for this test need to be on a disk image.
3133
3134         * manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
3135         * manual-tests/resources/plain-text-paste.dmg: Added.
3136         * manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
3137         * manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
3138         * manual-tests/resources/plain-text-paste/._4.txt: Removed.
3139         * manual-tests/resources/plain-text-paste/._5.webloc: Removed.
3140         * manual-tests/resources/plain-text-paste/1.textClipping: Removed.
3141         * manual-tests/resources/plain-text-paste/2.textClipping: Removed.
3142         * manual-tests/resources/plain-text-paste/3.gif: Removed.
3143         * manual-tests/resources/plain-text-paste/4.txt: Removed.
3144         * manual-tests/resources/plain-text-paste/5.webloc: Removed.
3145
3146 2006-10-09  Rob Buis  <buis@kde.org>
3147
3148         Reviewed by Darin.
3149
3150         http://bugs.webkit.org/show_bug.cgi?id=11217
3151         Cleanup svg coding style
3152
3153         Cleanup coding style in filter classes.
3154
3155         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
3156         (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
3157         (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
3158         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
3159         * ksvg2/svg/SVGFEBlendElement.cpp:
3160         (WebCore::SVGFEBlendElement::SVGFEBlendElement):
3161         (WebCore::SVGFEBlendElement::parseMappedAttribute):
3162         (WebCore::SVGFEBlendElement::filterEffect):
3163         * ksvg2/svg/SVGFEBlendElement.h:
3164         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3165         (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
3166         (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
3167         (WebCore::SVGFEColorMatrixElement::filterEffect):
3168         * ksvg2/svg/SVGFEColorMatrixElement.h:
3169         * ksvg2/svg/SVGFECompositeElement.cpp:
3170         (WebCore::SVGFECompositeElement::parseMappedAttribute):
3171         * ksvg2/svg/SVGFECompositeElement.h:
3172         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3173         (WebCore::SVGFEDisplacementMapElement::stringToChannel):
3174         * ksvg2/svg/SVGFEDisplacementMapElement.h:
3175         * ksvg2/svg/SVGFEFloodElement.cpp:
3176         (WebCore::SVGFEFloodElement::filterEffect):
3177         * ksvg2/svg/SVGFEFuncAElement.cpp:
3178         (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
3179         * ksvg2/svg/SVGFEFuncBElement.cpp:
3180         (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
3181         * ksvg2/svg/SVGFEFuncGElement.cpp:
3182         (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
3183         * ksvg2/svg/SVGFEFuncRElement.cpp:
3184         (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
3185         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
3186         (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
3187         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
3188         (WebCore::SVGFEGaussianBlurElement::filterEffect):
3189         * ksvg2/svg/SVGFEGaussianBlurElement.h:
3190         * ksvg2/svg/SVGFELightElement.cpp:
3191         (WebCore::SVGFELightElement::SVGFELightElement):
3192         (WebCore::SVGFELightElement::parseMappedAttribute):
3193         * ksvg2/svg/SVGFELightElement.h:
3194         * ksvg2/svg/SVGFEMergeElement.cpp:
3195         (WebCore::SVGFEMergeElement::SVGFEMergeElement):
3196
3197 2006-10-09  Rob Buis  <buis@kde.org>
3198
3199         Reviewed by olliej.
3200
3201         http://bugs.webkit.org/show_bug.cgi?id=11217
3202         Cleanup svg coding style
3203
3204         Cleanup coding style in SVGPath* classes.
3205
3206         * ksvg2/svg/SVGPathElement.cpp:
3207         (WebCore::SVGPathElement::SVGPathElement):
3208         (WebCore::SVGPathElement::getPointAtLength):
3209         (WebCore::SVGPathElement::createSVGPathSegClosePath):
3210         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
3211         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
3212         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
3213         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
3214         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
3215         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
3216         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
3217         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
3218         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
3219         (WebCore::SVGPathElement::createSVGPathSegArcRel):
3220         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
3221         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
3222         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
3223         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
3224         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
3225         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
3226         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
3227         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
3228         (WebCore::SVGPathElement::svgMoveTo):
3229         (WebCore::SVGPathElement::svgLineTo):
3230         (WebCore::SVGPathElement::svgLineToHorizontal):
3231         (WebCore::SVGPathElement::svgLineToVertical):
3232         (WebCore::SVGPathElement::svgCurveToCubic):
3233         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
3234         (WebCore::SVGPathElement::svgCurveToQuadratic):
3235         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
3236         (WebCore::SVGPathElement::svgArcTo):
3237         (WebCore::SVGPathElement::parseMappedAttribute):
3238         (WebCore::SVGPathElement::pathSegList):
3239         (WebCore::SVGPathElement::normalizedPathSegList):
3240         (WebCore::SVGPathElement::animatedPathSegList):
3241         (WebCore::SVGPathElement::animatedNormalizedPathSegList):
3242         (WebCore::SVGPathElement::toPathData):
3243         * ksvg2/svg/SVGPathElement.h:
3244         (WebCore::SVGPathElement::rendererIsNeeded):
3245         * ksvg2/svg/SVGPathSeg.h:
3246         * ksvg2/svg/SVGPathSegArc.cpp:
3247
3248 2006-10-09  Rob Buis  <buis@kde.org>
3249
3250         Reviewed by aroben.
3251
3252         http://bugs.webkit.org/show_bug.cgi?id=11217
3253         Cleanup svg coding style
3254
3255         Cleanup coding style in svg shape classes.
3256
3257         * ksvg2/svg/SVGCircleElement.cpp:
3258         (WebCore::SVGCircleElement::SVGCircleElement):
3259         (WebCore::SVGCircleElement::parseMappedAttribute):
3260         (WebCore::SVGCircleElement::pushAttributeContext):
3261         * ksvg2/svg/SVGCircleElement.h:
3262         (WebCore::SVGCircleElement::rendererIsNeeded):
3263         * ksvg2/svg/SVGEllipseElement.cpp:
3264         * ksvg2/svg/SVGEllipseElement.h:
3265         (WebCore::SVGEllipseElement::rendererIsNeeded):
3266         * ksvg2/svg/SVGLineElement.cpp:
3267         (WebCore::SVGLineElement::parseMappedAttribute):
3268         (WebCore::SVGLineElement::pushAttributeContext):
3269         * ksvg2/svg/SVGLineElement.h:
3270         (WebCore::SVGLineElement::rendererIsNeeded):
3271         * ksvg2/svg/SVGPolyElement.cpp:
3272         (WebCore::SVGPolyElement::SVGPolyElement):
3273         (WebCore::SVGPolyElement::points):
3274         (WebCore::SVGPolyElement::animatedPoints):
3275         (WebCore::SVGPolyElement::parseMappedAttribute):
3276         (WebCore::SVGPolyElement::notifyAttributeChange):
3277         * ksvg2/svg/SVGPolyElement.h:
3278         (WebCore::SVGPolyElement::rendererIsNeeded):
3279         * ksvg2/svg/SVGPolygonElement.cpp:
3280         (WebCore::SVGPolygonElement::SVGPolygonElement):
3281         (WebCore::SVGPolygonElement::toPathData):
3282         * ksvg2/svg/SVGPolygonElement.h:
3283         * ksvg2/svg/SVGPolylineElement.cpp:
3284         (WebCore::SVGPolylineElement::SVGPolylineElement):
3285         (WebCore::SVGPolylineElement::toPathData):
3286         * ksvg2/svg/SVGPolylineElement.h:
3287         * ksvg2/svg/SVGRectElement.cpp:
3288         (WebCore::SVGRectElement::parseMappedAttribute):
3289         (WebCore::SVGRectElement::pushAttributeContext):
3290         * ksvg2/svg/SVGRectElement.h:
3291         (WebCore::SVGRectElement::rendererIsNeeded):
3292
3293 2006-10-08  Darin Adler  <darin@apple.com>
3294
3295         Reviewed by Maciej.
3296
3297         - added a bit more WebCoreSystemInterface
3298
3299             wkGetNSURLResponseCalculatedExpiration
3300             wkGetNSURLResponseLastModifiedDate
3301             wkGetNSURLResponseMustRevalidate
3302
3303         * WebCore.exp: Added the new symbols.
3304         * platform/mac/WebCoreSystemInterface.h: Ditto.
3305         * platform/mac/WebCoreSystemInterface.mm: Ditto.
3306
3307         - quiet down the code generation script
3308
3309         * bindings/scripts/CodeGenerator.pm:
3310
3311 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
3312
3313         Reviewed by Darin.
3314
3315         - more code laundering - add wkSupportsMultipartXMixedReplace
3316
3317         * WebCore.exp:
3318         * platform/mac/WebCoreSystemInterface.h:
3319         * platform/mac/WebCoreSystemInterface.mm:
3320
3321 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
3322
3323         Reviewed by Darin and Oliver.
3324
3325         Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.
3326
3327         * platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage.
3328         (WebCore::GraphicsContext::drawConvexPolygon):
3329
3330 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
3331
3332         Reviewed by Darin.
3333
3334         * page/Frame.cpp:
3335         (WebCore::Frame::submitForm):
3336         No need to use latin1() here.
3337
3338 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
3339
3340         Reviewed by Darin.
3341
3342         Kill warnings when generating IDL files on Qt/Linux, as the
3343         SOURCE_ROOT environment variable is not defined (and not needed) for us.
3344
3345         * bindings/scripts/CodeGenerator.pm:
3346
3347 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
3348
3349         Reviewed by Darin.
3350
3351         - split didNotOpenURL: into general and page-cache-specific parts
3352
3353         * bridge/mac/WebCoreFrameBridge.h:
3354         * bridge/mac/WebCoreFrameBridge.mm:
3355         (-[WebCoreFrameBridge didNotOpenURL:]):
3356         (-[WebCoreFrameBridge invalidatePageCache:]):
3357
3358 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
3359
3360         Reviewed by Darin.
3361
3362         * loader/loader.cpp:
3363         Remove DeprecatedStringList.h include.
3364         
3365         * page/Frame.cpp:
3366         (WebCore::Frame::submitForm):
3367         Don't remove "attach" from mailto URLs, we don't do it anywhere else.
3368
3369 2006-10-08  Sam Weinig  <sam.weinig@gmail.com>
3370
3371         Reviewed by Darin.
3372
3373         Patch for http://bugs.webkit.org/show_bug.cgi?id=11215
3374         Yet another round of Objective-C SVG DOM bindings auto-generation
3375
3376         - Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement, 
3377           DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent,
3378           DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement, 
3379           DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement, 
3380           DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement, 
3381           DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement, 
3382           DOMSVGZoomAndPan and DOMSVGZoomEvent.
3383
3384         - Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement
3385           using the new [ConvertFromString] property.
3386
3387         - Add forward declarations for NS* types to auto-generated classes.
3388
3389         * DerivedSources.make:
3390         * WebCore.xcodeproj/project.pbxproj:
3391         * bindings/objc/DOMHTMLAppletElement.mm: Removed.
3392         * bindings/objc/DOMHTMLEmbedElement.mm: Removed.
3393         * bindings/objc/DOMInternal.h:
3394         * bindings/objc/DOMSVG.h:
3395         * bindings/scripts/CodeGeneratorObjC.pm:
3396         * html/HTMLAppletElement.idl:
3397         * html/HTMLEmbedElement.idl:
3398         * ksvg2/svg/SVGPatternElement.idl:
3399         * ksvg2/svg/SVGPolygonElement.idl:
3400         * ksvg2/svg/SVGPolylineElement.idl:
3401         * ksvg2/svg/SVGRadialGradientElement.idl:
3402         * ksvg2/svg/SVGRenderingIntent.idl:
3403         * ksvg2/svg/SVGScriptElement.idl:
3404         * ksvg2/svg/SVGSetElement.idl:
3405         * ksvg2/svg/SVGStopElement.idl:
3406         * ksvg2/svg/SVGSwitchElement.idl:
3407         * ksvg2/svg/SVGSymbolElement.idl:
3408         * ksvg2/svg/SVGTRefElement.idl:
3409         * ksvg2/svg/SVGTSpanElement.idl:
3410         * ksvg2/svg/SVGTextContentElement.idl:
3411         * ksvg2/svg/SVGTextElement.idl:
3412         * ksvg2/svg/SVGTextPositioningElement.idl:
3413         * ksvg2/svg/SVGTitleElement.idl:
3414         * ksvg2/svg/SVGUseElement.idl:
3415         * ksvg2/svg/SVGViewElement.idl:
3416         * ksvg2/svg/SVGZoomEvent.idl:
3417
3418 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
3419
3420         Reviewed by Maciej.
3421
3422         Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.        
3423         * loader/loader.cpp:
3424         (WebCore::Loader::servePendingRequests):
3425         
3426 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
3427
3428         Reviewed by Darin.
3429
3430         Convert a bunch of RefPtr<StringImpl> to String.
3431         
3432         * bridge/mac/FrameMac.h:
3433         * bridge/mac/FrameMac.mm:
3434         (WebCore::FrameMac::didTellBridgeAboutLoad):
3435         (WebCore::FrameMac::haveToldBridgeAboutLoad):
3436         * dom/BeforeUnloadEvent.cpp:
3437         (WebCore::BeforeUnloadEvent::storeResult):
3438         * dom/BeforeUnloadEvent.h:
3439         (WebCore::BeforeUnloadEvent::result):
3440         * dom/Document.cpp:
3441         (WebCore::Document::createEntityReference):
3442         * dom/Entity.cpp:
3443         (WebCore::Entity::Entity):
3444         (WebCore::Entity::nodeName):
3445         (WebCore::Entity::toString):
3446         * dom/Entity.h:
3447         (WebCore::Entity::publicId):
3448         (WebCore::Entity::systemId):
3449         (WebCore::Entity::notationName):
3450         * dom/EntityReference.cpp:
3451         (WebCore::EntityReference::EntityReference):
3452         (WebCore::EntityReference::nodeName):
3453         (WebCore::EntityReference::cloneNode):
3454         (WebCore::EntityReference::toString):
3455         * dom/EntityReference.h:
3456         * dom/KeyboardEvent.cpp:
3457         (WebCore::KeyboardEvent::KeyboardEvent):
3458         (WebCore::KeyboardEvent::initKeyboardEvent):
3459         * dom/KeyboardEvent.h:
3460         (WebCore::KeyboardEvent::keyIdentifier):
3461         * dom/MutationEvent.cpp:
3462         (WebCore::MutationEvent::MutationEvent):
3463         (WebCore::MutationEvent::initMutationEvent):
3464         * dom/MutationEvent.h:
3465         (WebCore::MutationEvent::prevValue):
3466         (WebCore::MutationEvent::newValue):
3467         (WebCore::MutationEvent::attrName):
3468         * dom/Notation.cpp:
3469         (WebCore::Notation::Notation):
3470         (WebCore::Notation::nodeName):
3471         * dom/Notation.h:
3472         (WebCore::Notation::publicId):
3473         (WebCore::Notation::systemId):
3474         * dom/ProcessingInstruction.cpp:
3475         (WebCore::ProcessingInstruction::ProcessingInstruction):
3476         (WebCore::ProcessingInstruction::setData):
3477         (WebCore::ProcessingInstruction::nodeName):
3478         (WebCore::ProcessingInstruction::nodeValue):
3479         (WebCore::ProcessingInstruction::cloneNode):
3480         (WebCore::ProcessingInstruction::checkStyleSheet):
3481         (WebCore::ProcessingInstruction::toString):
3482         * dom/ProcessingInstruction.h:
3483         (WebCore::ProcessingInstruction::target):
3484         (WebCore::ProcessingInstruction::data):
3485         (WebCore::ProcessingInstruction::localHref):
3486
3487 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
3488
3489         Reviewed by Tim H.
3490
3491         Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
3492         10 more SVG Objective-C auto-generated bindings
3493
3494         - Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, 
3495           DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement,
3496           DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, 
3497           DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
3498
3499         - Auto-generate the text method for DOMRange.
3500
3501         * DerivedSources.make:
3502         * WebCore.xcodeproj/project.pbxproj:
3503         * bindings/objc/DOM.mm:
3504         * bindings/objc/DOMExtensions.h:
3505         * bindings/objc/DOMInternal.h:
3506         * bindings/objc/DOMPrivate.h:
3507         * bindings/objc/DOMRGBColor.mm:
3508         * bindings/objc/DOMSVG.h:
3509         * bindings/objc/PublicDOMInterfaces.h:
3510         * bindings/scripts/CodeGeneratorObjC.pm:
3511         * dom/Range.idl:
3512         * ksvg2/svg/SVGFilterElement.cpp:
3513         * ksvg2/svg/SVGFilterElement.h:
3514         * ksvg2/svg/SVGFilterElement.idl:
3515         * ksvg2/svg/SVGForeignObjectElement.idl:
3516         * ksvg2/svg/SVGGElement.idl:
3517         * ksvg2/svg/SVGGradientElement.idl:
3518         * ksvg2/svg/SVGImageElement.idl:
3519         * ksvg2/svg/SVGLineElement.idl:
3520         * ksvg2/svg/SVGLinearGradientElement.idl:
3521         * ksvg2/svg/SVGMarkerElement.idl:
3522         * ksvg2/svg/SVGMaskElement.idl:
3523         * ksvg2/svg/SVGPaint.idl:
3524
3525 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
3526
3527         Reviewed by Tim H.
3528
3529         Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
3530         Auto-generate a few more Objective-C DOM interfaces
3531
3532         - Fully auto-generate DOMAbstractView and DOMRange.
3533
3534         - Auto-generate just the interface for DOMRGBColor.
3535
3536         - Add DOMRanges.h as the new top level file for Ranges
3537           module.
3538
3539         - Add DOMRanges.h and DOMXPath.h to DOM.mm
3540
3541         * DerivedSources.make:
3542         * WebCore.xcodeproj/project.pbxproj:
3543         * bindings/objc/DOM.h:
3544         * bindings/objc/DOM.mm:
3545         * bindings/objc/DOMAbstractView.h: Removed.
3546         * bindings/objc/DOMAbstractView.mm: Removed.
3547         * bindings/objc/DOMInternal.h:
3548         * bindings/objc/DOMPrivate.h:
3549         * bindings/objc/DOMRGBColor.h: Removed.
3550         * bindings/objc/DOMRGBColor.mm:
3551         * bindings/objc/DOMRange.h: Removed.
3552         * bindings/objc/DOMRanges.h: Added.
3553         * bindings/objc/PublicDOMInterfaces.h:
3554         * bindings/scripts/CodeGeneratorObjC.pm:
3555         * css/RGBColor.idl:
3556         * dom/Range.idl:
3557         * page/AbstractView.idl: Added.
3558
3559 2006-10-07  Andrew Wellington  <proton@wiretapped.net>
3560
3561         Reviewed by Eric.
3562
3563         Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
3564         http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
3565
3566         Return null when there is no frame. This matches Firefox.
3567
3568         * bindings/js/kjs_html.cpp:
3569         (KJS::JSHTMLDocument::getValueProperty):
3570
3571 2006-10-07  David Hyatt  <hyatt@apple.com>
3572
3573         Implement scroll corner painting (a white rect fill) for overflow areas to cover up
3574         scrollbar joins properly.
3575
3576         Refactor painting of scrollbars and resizers into common functions.  Eliminate the
3577         extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
3578
3579         Reviewed by mitz
3580
3581         * page/FrameView.cpp:
3582         (WebCore::selectCursor):
3583         (WebCore::FrameView::handleMouseMoveEvent):
3584         * platform/mac/PlatformScrollBar.h:
3585         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
3586         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
3587         * rendering/RenderLayer.cpp: