86c5b3e3b17af69625290f3eea0d01a52a1f5a86
[WebKit-https.git] / WebCore / ChangeLog
1 2007-07-11  Anders Carlsson  <andersca@apple.com>
2
3         Fix build.
4         
5         * platform/network/cf/ResourceHandleCFNet.cpp:
6         (WebCore::willSendRequest):
7         (WebCore::didReceiveResponse):
8         (WebCore::didReceiveData):
9         (WebCore::didFinishLoading):
10         (WebCore::didFail):
11         (WebCore::didReceiveChallenge):
12
13 2007-07-12  George Staikos  <staikos@kde.org>
14
15         Repair the build.
16
17         * platform/network/qt/ResourceHandleQt.cpp:
18         (WebCore::ResourceHandle::start):
19
20 2007-07-11  Adele Peterson  <adele@apple.com>
21
22         Reviewed by Darin.
23
24         Fix for <rdar://problem/5230188> REGRESSION: Active/inactive marked text is not distinguished in textfields and textareas
25
26         We were previously trying to leave room for 1px of space between the text and the underline.
27         This change removes that requirement so that if we don't have room for the extra space, we still draw the thick underline
28         touching the text.
29
30         * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextUnderline):
31
32 2007-07-11  Anders Carlsson  <andersca@apple.com>
33
34         Reviewed by Darin and Geoff.
35
36         <rdar://problem/5313508>
37         REGRESSION (Leopard): http/tests/xmlhttprequest/basic-auth.html hangs
38         
39         Leopard Foundation now ignores credentials passed in as part of the URL so we need to pass them ourselves.
40         
41         For the asynchronous case, we simply keep track of the URL and if it has a user name and password, we
42         pass those if we're asked to authenticate.
43                 
44         For the synchronous case, implement a new connection delegate and run it in a separate mode so 
45         no other sources will fire.
46
47         * platform/network/mac/ResourceHandleMac.mm:
48         (WebCore::ResourceHandle::loadResourceSynchronously):
49         (-[WebCoreResourceHandleAsDelegate dealloc]):
50         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
51         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
52         (-[WebCoreSynchronousLoader _isDone]):
53         (-[WebCoreSynchronousLoader dealloc]):
54         (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]):
55         (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):
56         (-[WebCoreSynchronousLoader connection:didReceiveResponse:]):
57         (-[WebCoreSynchronousLoader connection:didReceiveData:]):
58         (-[WebCoreSynchronousLoader connectionDidFinishLoading:]):
59         (-[WebCoreSynchronousLoader connection:didFailWithError:]):
60         (-[WebCoreSynchronousLoader _data]):
61         (-[WebCoreSynchronousLoader _response]):
62         (-[WebCoreSynchronousLoader _error]):
63         (+[WebCoreSynchronousLoader loadRequest:returningResponse:error:]):
64
65 2007-07-11  Darin Adler  <darin@apple.com>
66
67         Reviewed by Sam Weinig.
68
69         - fix <rdar://problem/5315265> REGRESSION: Leopard launch time -
70           there are about 190 stats of icudt36b files during launch
71
72         * platform/TextEncodingRegistry.cpp: (WebCore::atomicCanonicalTextEncodingName):
73         Add a special case for the empty string so we don't load the extended text
74         encodings just so we can return 0 for that case.
75
76 2007-07-11  Anders Carlsson  <andersca@apple.com>
77
78         Reviewed by Darin.
79
80         Remove a bunch of unneeded accessors from ResourceHandle.
81         
82         * loader/icon/IconLoader.cpp:
83         (WebCore::IconLoader::didReceiveResponse):
84         (WebCore::IconLoader::didFail):
85         (WebCore::IconLoader::didFinishLoading):
86         * platform/network/ResourceHandle.cpp:
87         * platform/network/ResourceHandle.h:
88
89 2007-07-09  Justin Garcia  <justin.garcia@apple.com>
90
91         Reviewed by Darin.
92         
93         <rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length
94         
95         The functions for moving the caret to the next/previous sentence boundary
96         were in many cases moving to the beginning/end of the document.  The functions that 
97         should move the caret to an equivalent position in the next/previous sentence behaved
98         like the aforementioned functions ought to.  Put the code from the second two functions
99         in the first and made sure that the second two are properly FIXMEd.  They're rarely 
100         used (filed 5323691).
101         
102         * editing/SelectionController.cpp:
103         (WebCore::SelectionController::modify): Added an option for sentenceBoundary granularity,
104         so that we can test the functions that were broken from JS.
105         * editing/visible_units.cpp:
106         (WebCore::startOfSentence): Removed the FIXME about 5234383.
107         (WebCore::endSentenceBoundary): Make this function do what nextSentencePositionBoundary
108         current does.
109         (WebCore::endOfSentence): Removed the FIXME about 5234383.
110         (WebCore::previousSentencePosition): Removed an incorrect FIXME.
111         (WebCore::nextSentencePositionBoundary): Tweaked FIXME.  This function is
112         identical, not close to endSentenceBoundary.
113         (WebCore::nextSentencePosition): Removed an incorrect FIXME.
114
115 2007-07-11  Rob Buis  <buis@kde.org>
116
117         Reviewed by Darin.
118
119         http://bugs.webkit.org/show_bug.cgi?id=14453
120         REGRESSION: www.nzherald.co.nz almost all the formating is gone
121  
122         Be less strict for the hex color definition.
123
124         * css/CSSGrammar.y:
125         * css/cssparser.cpp:
126         (WebCore::CSSParser::lex):
127         (WebCore::CSSParser::text):
128         * css/tokenizer.flex:
129
130 2007-07-11  Rob Buis  <buis@kde.org>
131
132         Reviewed by Oliver.
133
134         Forgot to commit this as part of commit r24146. Now we are sure
135         createElement creates elements in the xhtml namespace only.
136
137         * ksvg2/svg/SVGDocument.cpp:
138         * ksvg2/svg/SVGDocument.h:
139
140 2007-07-10  Sam Weinig  <sam@webkit.org>
141
142         Reviewed by Oliver.
143
144         Move more attributes from the pure JS bindings in KJS::Window
145         to the implementation in DOMWindow and autogenerate the new bindings
146
147         Test: fast/dom/Window/get-set-properties.html
148
149         * bindings/js/JSDOMWindowCustom.cpp:
150         (WebCore::JSDOMWindow::customGetOwnPropertySlot): Change to use propHashTable in
151         JSDOMWindow instead of KJS::Window
152         * bindings/js/kjs_window.cpp:
153         (KJS::Window::getValueProperty):
154         (KJS::Window::put):
155         * bindings/js/kjs_window.h:
156         (KJS::Window::):
157         * bindings/scripts/CodeGeneratorJS.pm: Cleanup getValueProperty and put generation
158         to reduce code duplication. 
159         * page/DOMWindow.cpp:
160         (WebCore::DOMWindow::closed):
161         (WebCore::DOMWindow::length):
162         (WebCore::DOMWindow::name):
163         (WebCore::DOMWindow::setName):
164         (WebCore::DOMWindow::status):
165         (WebCore::DOMWindow::setStatus):
166         (WebCore::DOMWindow::defaultStatus):
167         (WebCore::DOMWindow::setDefaultStatus):
168         * page/DOMWindow.h:
169         (WebCore::DOMWindow::defaultstatus):
170         (WebCore::DOMWindow::setDefaultstatus):
171         * page/DOMWindow.idl:
172
173 2007-07-10  Sam Weinig  <sam@webkit.org>
174
175         Reviewed by Geoff.
176
177         Fix for <rdar://problem/5326791> XSS vulnerability: ability to set window.defaultStatus,
178         window.defaultstatus and window.status cross domains
179
180         Test: http/tests/security/cross-frame-access-put.html
181
182         * bindings/js/kjs_window.cpp:
183         (KJS::Window::put): Adds isSafeScript check for defaultStatus,
184         defaultstatus and status cases.
185
186 2007-07-10  Sam Weinig  <sam@webkit.org>
187
188         Fix build for BuildBot.
189
190         * page/DOMWindow.cpp:
191         (WebCore::DOMWindow::outerHeight):
192         (WebCore::DOMWindow::outerWidth):
193         (WebCore::DOMWindow::screenX):
194         (WebCore::DOMWindow::screenY):
195
196 2007-07-10  Brady Eidson  <beidson@apple.com>
197
198         Reviewed by Sam
199
200         <rdar://problem/5326653> - REGRESSION: [WebBackForwardList forwardListCount] might return incorrect result
201
202         No layout test because this is an API issue that can't be tested in DRT or the browser
203
204         * history/BackForwardList.cpp:
205         (WebCore::BackForwardList::forwardListCount): If the index is NoCurrentItemIndex, return 0
206
207 2007-07-10  Sam Weinig  <sam@webkit.org>
208
209         Reviewed by Darin.
210
211         Move more readonly attributes from pure JS bindings in KJS::Window
212         to the implementation in DOMWindow and autogenerate the new bindings.
213
214         * bindings/js/kjs_window.cpp:
215         (KJS::Window::getValueProperty):  Sort the hashmap comment into categories
216         to make further migration easier.
217         * bindings/js/kjs_window.h: Sort the enum into categories to make further
218         migration easier.
219         (KJS::Window::):
220         * page/DOMWindow.cpp: Add new methods.
221         (WebCore::DOMWindow::focus):
222         (WebCore::DOMWindow::blur):
223         (WebCore::DOMWindow::offscreenBuffering):
224         (WebCore::DOMWindow::outerHeight):
225         (WebCore::DOMWindow::outerWidth):
226         (WebCore::DOMWindow::innerHeight):
227         (WebCore::DOMWindow::innerWidth):
228         (WebCore::DOMWindow::screenX):
229         (WebCore::DOMWindow::screenY):
230         (WebCore::DOMWindow::scrollX):
231         (WebCore::DOMWindow::scrollY):
232         (WebCore::DOMWindow::getComputedStyle):
233         (WebCore::DOMWindow::getMatchedCSSRules): Add null Document assertion.
234         (WebCore::DOMWindow::devicePixelRatio): Add null Frame and Page checks.
235         * page/DOMWindow.h:
236         (WebCore::DOMWindow::screenLeft):
237         (WebCore::DOMWindow::screenTop):
238         (WebCore::DOMWindow::pageXOffset):
239         (WebCore::DOMWindow::pageYOffset):
240         * page/DOMWindow.idl:
241
242 2007-07-10  Oliver Hunt  <oliver@apple.com>
243
244         Reviewed by Maciej.
245
246         Fix for <rdar://problem/5326417> Editor::unmarkText needs to be crossplatform
247
248         Missed this in earlier patch to make text marking platform independent.
249
250         * editing/Editor.cpp:
251         (WebCore::Editor::unmarkText):
252            Add platform independent impl
253         * editing/mac/EditorMac.mm:
254            Remove the old mac path.
255
256 2007-07-10  Geoffrey Garen  <ggaren@apple.com>
257
258         Reviewed by Tim Hatcher.
259
260         Added a Page counter. This helped me while investigating 
261         <rdar://problem/5314463> 40MB of WebKit memory still allocated after 
262         closing large email in Mail
263
264         * WebCore.xcodeproj/project.pbxproj:
265         * page/Page.cpp:
266         (WebCore::):
267         (WebCore::PageCounter::~PageCounter):
268         (WebCore::Page::Page):
269         (WebCore::Page::~Page):
270
271 2007-07-10  Timothy Hatcher  <timothy@apple.com>
272
273         Reviewed by Geoff.
274
275         <rdar://problem/5326126> InspectorResource holds onto more data than it needs
276
277         Reduces the fixed size of InspectorResource from 630 bytes to 224 bytes. Now
278         selectively pick out parts of the ResourceRequest and ResourceResponse objects
279         for the info needed and store that directly in InspectorResource.
280
281         The ResourceRequest and ResourceResponse objects hold a reference to the original
282         NSURL object, so almost double the data was being kept around. So the struct size
283         reduction is just the tip of the ice burg on what this really saves.
284
285         In a test of 100,000 XMLHTTPRequests using a 85 byte long data URL, I see ~21 MB less
286         RSIZE compared to Safari running without this change.
287
288         * page/InspectorController.cpp:
289         (WebCore::InspectorResource::InspectorResource):
290         (WebCore::InspectorResource::type):
291         (WebCore::addSourceToFrame):
292         (WebCore::scriptObjectForRequest):
293         (WebCore::scriptObjectForResponse):
294         (WebCore::InspectorController::addScriptResource):
295         (WebCore::InspectorController::addAndUpdateScriptResource):
296         (WebCore::updateResourceRequest):
297         (WebCore::updateResourceResponse):
298         (WebCore::InspectorController::updateScriptResourceRequest):
299         (WebCore::InspectorController::updateScriptResourceResponse):
300         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
301         (WebCore::InspectorController::identifierForInitialRequest):
302         (WebCore::InspectorController::willSendRequest):
303         (WebCore::InspectorController::didReceiveResponse):
304         (WebCore::InspectorController::didFailLoading):
305         * page/InspectorController.h:
306
307 2007-07-10  Darin Adler  <darin@apple.com>
308
309         Reviewed by Brady.
310
311         - fix crash introduced by my patch for 5318732, only seen in release builds
312
313         * page/Page.cpp: (WebCore::Page::~Page): Added a missing null check.
314
315 2007-07-10  Andrea Cavalli  <amc82@cam.ac.uk>
316
317         Reviewed by George Staikos.
318
319         Fixed render theme for text field.
320
321         * platform/qt/RenderThemeQt.cpp:
322         (WebCore::RenderThemeQt::paintTextField):
323
324 2007-07-10  Qing Zhao  <qing@staikos.net>
325
326         Reviewed by George Staikos.
327
328         Draw focus rings for nodes that are not rendered by QStyle.
329
330         * platform/graphics/qt/GraphicsContextQt.cpp:
331         (WebCore::focusRingColor):
332         (WebCore::GraphicsContext::drawFocusRing):
333         * platform/qt/RenderThemeQt.cpp:
334         (WebCore::RenderThemeQt::supportsFocusRing):
335         (WebCore::RenderThemeQt::supportsFocus):
336
337 2007-07-10  Nikolas Zimmermann  <zimmermann@kde.org>
338
339         Reviewed by Geoff.
340
341         Fix 'unsigned int' overflow in CodeGeneratorJS.pm.
342         This fixes hashing of "SVG_FEBLEND_MODE_NORMAL". Its hashvalue exceeded 2^32, which
343         is no problem in perl but in the cpp code. Emulate C/C++ behaviour by using "% 2^32" in
344         the perl code. Testcase available in feature-branch soon (js-svg-constructors.svg).
345
346         * bindings/scripts/CodeGeneratorJS.pm:
347
348 2007-07-10  Geoffrey Garen  <ggaren@apple.com>
349
350         Reviewed by Maciej Stachowiak.
351
352         Disabled Arena recycling in RenderArena. PLT shows no regression 
353         (possibly a small speedup), and this can reduce allocated memory in 
354         WebKit clients by about 120K (4K per Arena * 30 Arenas).
355         
356         I happened upon this optimization while investigating 
357         <rdar://problem/5314463> WebKit hangs on to 40MB RAM after closing 
358         large email in Mail (appears to be render tree arena allocator), 
359         although I don't think it will come close to fixing that bug 
360         completely.
361
362         * rendering/RenderArena.cpp:
363         (WebCore::RenderArena::~RenderArena): Use FinishArenaPool, which frees
364         the ArenaPool's Arenas immediately.
365
366 2007-07-10  Mitz Pettel  <mitz@webkit.org>
367
368         Reviewed by Hyatt.
369
370         - fix http://bugs.webkit.org/show_bug.cgi?id=14449
371           REGRESSION (r14345-r14375): Absolutely positioned image does not scale to containing element's height
372
373         Test: fast/replaced/absolute-position-percentage-height.html
374
375         * rendering/RenderBox.cpp:
376         (WebCore::RenderBox::calcReplacedHeightUsing): For positioned elements, evaluate
377         the percentage with respect to the container's final height.
378
379 2007-07-10  Brady Eidson  <beidson@apple.com>
380
381         Reviewed by Mark Rowe
382
383         Add 64-bit integer converters to our string classes for future work
384
385         * platform/DeprecatedString.cpp:
386         (WebCore::DeprecatedString::toInt64):
387         (WebCore::DeprecatedString::toUInt64):
388         * platform/DeprecatedString.h:
389
390         * platform/PlatformString.h:
391         * platform/String.cpp:
392         (WebCore::String::toInt64):
393         (WebCore::String::toUInt64):
394
395         * platform/StringImpl.cpp:
396         (WebCore::StringImpl::toInt64):
397         (WebCore::StringImpl::toUInt64):
398         * platform/StringImpl.h:
399
400 2007-07-10  Darin Adler  <darin@apple.com>
401
402         Reviewed by Anders.
403
404         - fix <rdar://problem/5318732> REGRESSION: In Mail, a crash occurs when attempting to send
405           a HTML based message (nytimes.com, washingtonpost.com, latimes.com)
406
407         Did an audit of calls to get the inspector and most other uses of Page* and added null
408         checks since Frame* can outlast its Page*.
409
410         * loader/FrameLoader.cpp:
411         (WebCore::FrameLoader::createWindow): Added null check.
412         (WebCore::FrameLoader::loadSubframe): Ditto.
413         (WebCore::FrameLoader::load): Ditto.
414         (WebCore::FrameLoader::transitionToCommitted): Ditto.
415         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.
416         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Ditto.
417         (WebCore::FrameLoader::addExtraFieldsToRequest): Ditto.
418         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
419         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto.
420         (WebCore::FrameLoader::requestFromDelegate): Ditto.
421         (WebCore::FrameLoader::canGoBackOrForward): Ditto.
422         (WebCore::FrameLoader::getHistoryLength): Ditto.
423         (WebCore::FrameLoader::historyURL): Ditto.
424         (WebCore::FrameLoader::cachePageForHistoryItem): Ditto.
425         (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Ditto.
426         (WebCore::FrameLoader::goToItem): Ditto.
427         (WebCore::FrameLoader::dispatchWindowObjectAvailable): Ditto.
428         (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto.
429         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto.
430         (WebCore::FrameLoader::dispatchWillSendRequest): Ditto.
431         (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto.
432         (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto.
433         (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto.
434         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
435
436         * page/ContextMenuController.h:
437         * page/ContextMenuController.cpp:
438         (WebCore::ContextMenuController::ContextMenuController): Removed unneeded and
439         unused Page* parameter.
440         (WebCore::openNewWindow): Added null check.
441         (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
442
443         * page/InspectorController.h:
444         (WebCore::InspectorController::pageDestroyed): Added. Since this object is
445         owned by the Page and has a back-pointer to it, it needs an explicit disconnect.
446         There's already a higher-level one, but this is more reliable than that.
447         * page/InspectorController.cpp:
448         (WebCore::InspectorController::windowScriptObjectAvailable): Added null check.
449         (WebCore::InspectorController::windowUnloading): Ditto.
450
451         * page/Page.cpp:
452         (WebCore::Page::Page): Updated for change in parameters of ContextMenuController 
453         constructor.
454         (WebCore::Page::~Page): Added call to InspectorController pageDestroyed().
455
456         * page/Chrome.cpp: Updated includes.
457         * page/DragController.cpp: Ditto.
458
459 2007-07-10  Adam Treat  <adam@staikos.net>
460
461         Reviewed by George Staikos.
462
463         Bring scroll wheel out of Ludicrous Speed.
464
465         * platform/qt/WheelEventQt.cpp:
466         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
467
468 2007-07-09  Geoffrey Garen  <ggaren@apple.com>
469
470         Reviewed by Maciej Stachowiak.
471
472         Fixed http://bugs.webkit.org/show_bug.cgi?id=13241 | <rdar://problem/5126396>
473         onload fires before content is finished loading (woot.com)
474         
475         * dom/Document.cpp:
476         (WebCore::Document::close): Try to go through the normal "Am I done loading?"
477         machinery before dispatching the load event. As the comment indicates, 
478         we can't do this in all cases, so the fix isn't perfect. However, a perfect 
479         solution would require much riskier sweeping changes to the loader, which 
480         are best left for later, I think.
481
482         * xml/XSLTProcessor.cpp:
483         (WebCore::XSLTProcessor::createDocumentFromSource): Removed a slightly
484         worse solution to the same problem.
485
486 2007-07-10  Rob Buis  <buis@kde.org>
487
488         Reviewed by Maciej.
489
490         http://bugs.webkit.org/show_bug.cgi?id=8007
491         createElement() and XHTML (A dynamically created table not rendered as such)
492
493         Follow the HTML5 rules of making the name lowercase and then
494         creating the element in the xhtml namespace.
495
496         * dom/Document.cpp:
497         (WebCore::Document::createElement):
498         * dom/Document.h:
499         * html/HTMLDocument.cpp:
500         * html/HTMLDocument.h:
501
502 2007-07-09  Qing Zhao  <qing@staikos.net>
503
504         Reviewed by George Staikos.
505
506         Add qt context menu support.
507
508         * WebCore.pro:
509         * platform/ContextMenu.h:
510         * platform/ContextMenuItem.h:
511         (WebCore::PlatformMenuItemDescriptionType::PlatformMenuItemDescriptionType):
512         * platform/qt/ContextMenuItemQt.cpp:
513         (WebCore::ContextMenuItem::ContextMenuItem):
514         (WebCore::ContextMenuItem::~ContextMenuItem):
515         (WebCore::ContextMenuItem::releasePlatformDescription):
516         (WebCore::ContextMenuItem::type):
517         (WebCore::ContextMenuItem::setType):
518         (WebCore::ContextMenuItem::action):
519         (WebCore::ContextMenuItem::setAction):
520         (WebCore::ContextMenuItem::title):
521         (WebCore::ContextMenuItem::setTitle):
522         (WebCore::ContextMenuItem::platformSubMenu):
523         (WebCore::ContextMenuItem::setSubMenu):
524         (WebCore::ContextMenuItem::setChecked):
525         (WebCore::ContextMenuItem::setEnabled):
526         (WebCore::ContextMenuItem::enabled):
527         * platform/qt/ContextMenuQt.cpp:
528         (WebCore::ContextMenu::ContextMenu):
529         (WebCore::ContextMenu::~ContextMenu):
530         (WebCore::ContextMenu::appendItem):
531         (WebCore::ContextMenu::itemCount):
532         (WebCore::ContextMenu::insertItem):
533         (WebCore::ContextMenu::setPlatformDescription):
534         (WebCore::ContextMenu::platformDescription):
535
536 2007-07-09  Anders Carlsson  <andersca@apple.com>
537
538         Build fix.
539         
540         * plugins/win/PluginViewWin.cpp:
541         (WebCore::PluginViewWin::performRequest):
542
543 2007-07-09  Anders Carlsson  <andersca@apple.com>
544
545         Reviewed by Geoff.
546
547         Get rid of the node argument in our various script execution functions.
548         
549         * bindings/js/kjs_proxy.cpp:
550         (WebCore::KJSProxy::evaluate):
551         * bindings/js/kjs_proxy.h:
552         * bindings/js/kjs_window.cpp:
553         (KJS::ScheduledAction::execute):
554         * dom/XMLTokenizer.cpp:
555         (WebCore::XMLTokenizer::endElementNs):
556         (WebCore::XMLTokenizer::notifyFinished):
557         * html/HTMLScriptElement.cpp:
558         (WebCore::HTMLScriptElement::evaluateScript):
559         * html/HTMLTokenizer.cpp:
560         (WebCore::HTMLTokenizer::scriptExecution):
561         * loader/FrameLoader.cpp:
562         (WebCore::FrameLoader::changeLocation):
563         (WebCore::FrameLoader::urlSelected):
564         (WebCore::FrameLoader::submitForm):
565         (WebCore::FrameLoader::replaceContentsWithScriptResult):
566         (WebCore::FrameLoader::executeScript):
567         * loader/FrameLoader.h:
568         * page/mac/WebCoreFrameBridge.mm:
569         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
570         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
571
572 2007-07-09  Justin Garcia  <justin.garcia@apple.com>
573
574         Rolling the fix for 5290534 back in now that 5310404 has been fixed in Mail.
575
576         * editing/DeleteSelectionCommand.cpp:
577         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
578
579 2007-07-09  Geoffrey Garen  <ggaren@apple.com>
580
581         Reviewed by Anders Carlsson.
582
583         A little more FrameLoader cleanup while working on <rdar://problem/5126396>.
584         
585         Rename: "checkEmitLoadEvent" => "checkCallImplicitClose" because the function
586         doesn't emit the load event; it just calls implicitClose.
587         
588         Rename: "m_wasLoadEventEmitted" => "m_didCallImplicitClose" because the variable
589         tracks whether implicitClose was called.
590
591         * dom/Document.cpp:
592         (WebCore::Document::implicitClose): Turned 12 lines of code into 6, adding ASSERT.
593         * loader/FrameLoader.h: Removed bogus declaration of non-existent emitLoadEvent().
594
595 2007-07-09  Justin Garcia  <justin.garcia@apple.com>
596
597         Reviewed by John.
598         
599         REGRESSION: Crash when deleting table content in Leopard Mail
600
601         * editing/DeleteSelectionCommand.cpp:
602         (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr
603         for the next node to delete, in case it is destroyed when the
604         current node is deleted.  In the crash reported in the radar, we
605         crash because the next node is the div that holds the delete button
606         and it's destroyed when the node that contains the selection is removed.
607
608 2007-07-09  Adam Treat  <adam@staikos.net>
609
610         Reviewed by George Staikos.
611
612         Convert QWebFrame from a QFrame to a pure QObject to eliminate all
613         traces of widgets.
614
615         * page/qt/EventHandlerQt.cpp:
616         (WebCore::EventHandler::passSubframeEventToSubframe):
617         * platform/ScrollView.h:
618         * platform/Widget.h:
619         * platform/qt/PlatformScrollBarQt.cpp:
620         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
621         (WebCore::PlatformScrollbar::handleMousePressEvent):
622         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
623         * platform/qt/PopupMenuQt.cpp:
624         (WebCore::PopupMenu::show):
625         * platform/qt/ScrollViewQt.cpp:
626         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
627         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
628         (WebCore::ScrollView::ScrollViewPrivate::windowClipRect):
629         (WebCore::ScrollView::updateContents):
630         (WebCore::ScrollView::update):
631         (WebCore::ScrollView::geometryChanged):
632         (WebCore::ScrollView::windowToContents):
633         (WebCore::ScrollView::contentsToWindow):
634         (WebCore::ScrollView::convertChildToSelf):
635         (WebCore::ScrollView::convertSelfToChild):
636         (WebCore::ScrollView::scrollbarUnderMouse):
637         (WebCore::ScrollView::addChild):
638         (WebCore::ScrollView::paint):
639         * platform/qt/WidgetQt.cpp:
640         (WebCore::WidgetPrivate::WidgetPrivate):
641         (WebCore::WidgetPrivate::~WidgetPrivate):
642         (WebCore::WidgetPrivate::setGeometry):
643         (WebCore::WidgetPrivate::geometry):
644         (WebCore::Widget::frameGeometry):
645         (WebCore::Widget::setFocus):
646         (WebCore::Widget::setCursor):
647         (WebCore::Widget::show):
648         (WebCore::Widget::hide):
649         (WebCore::Widget::qwebframe):
650         (WebCore::Widget::setQWebFrame):
651         (WebCore::Widget::qwidget):
652         (WebCore::Widget::setQWidget):
653         (WebCore::Widget::setFrameGeometry):
654         (WebCore::Widget::isEnabled):
655         (WebCore::Widget::setEnabled):
656         (WebCore::Widget::setIsSelected):
657         (WebCore::Widget::invalidate):
658         (WebCore::Widget::invalidateRect):
659         (WebCore::Widget::removeFromParent):
660         (WebCore::Widget::geometryChanged):
661         (WebCore::Widget::convertToContainingWindow):
662         (WebCore::Widget::convertFromContainingWindow):
663         (WebCore::Widget::convertChildToSelf):
664         (WebCore::Widget::convertSelfToChild):
665         (WebCore::Widget::containingWindow):
666
667 2007-07-09  Anders Carlsson  <andersca@apple.com>
668
669         Reviewed by Oliver.
670
671         Add DocumentLoader::isLoadingMainResource.
672
673         * WebCore.exp:
674
675 2007-07-09  John Sullivan  <sullivan@apple.com>
676
677         Reviewed by Darin
678
679         * WebCore.exp:
680         * WebCore.xcodeproj/project.pbxproj:
681         exported String::createCFString, needed for <rdar://problem/5320208>
682
683 2007-07-09  Mitz Pettel  <mitz@webkit.org>
684
685         Reviewed by Maciej.
686
687         Test case for the bug below, which is http://bugs.webkit.org/show_bug.cgi?id=14207
688
689         * manual-tests/flash-unload-tab.html: Added.
690
691 2007-07-09  Maciej Stachowiak  <mjs@apple.com>
692
693         Reviewed by Oliver.
694
695         <rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in
696         WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>,
697         WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11
698         
699         Automated test case is not possible. Did not bother with manual test this time.
700
701         * bindings/js/kjs_dom.cpp:
702         (WebCore::getRuntimeObject): Check that runtime root isn't null, as well as instance;
703         this should cover the case where the plugin is already shut down and onunload time.
704
705 2007-07-08  Maciej Stachowiak  <mjs@apple.com>
706
707         Reviewed by Sam.
708
709         - fixed <rdar://problem/5220706> REGRESSION (TOT): repro crash in -[WebView(WebViewInternal) _addObject:forIdentifier:] [14425]
710         http://bugs.webkit.org/show_bug.cgi?id=14425
711
712         * bindings/js/kjs_window.cpp:
713         (KJS::createWindow): No longer take an immediate argument - always do immediate loads
714         on a newly created Window. Also, do a load of "" to make sure that the right info makes
715         it to the app.
716         (KJS::showModalDialog): Updated for above.
717         (KJS::WindowFunc::callAsFunction): Updated for above.
718         * dom/Document.cpp:
719         (WebCore::Document::shouldBeAllowedToLoadLocalResources): If our URL is about:blank,
720         we're allowed if our opener is (since the opener must have written the contents).
721         * loader/FrameLoader.cpp:
722         (WebCore::FrameLoader::changeLocation): Add a variant which takes a KURL, which it
723         expects to be pre-completed. This is to avoid completing "" to the opener URL.
724         (WebCore::FrameLoader::urlSelected): Allow loading empty URLs.
725         * loader/FrameLoader.h:
726         
727         Test case is manual only, since it takes particular app behavior to reproduce:
728         
729         * manual-tests/new-window-subresource-crash.html: Added.
730
731 2007-07-08  Mitz Pettel  <mitz@webkit.org>
732
733         Reviewed by Maciej.
734
735         - fix leaks introduced in r24099
736
737         * dom/Element.cpp:
738         (WebCore::Element::~Element): Do not delete the cached computed style here.
739         (WebCore::Element::detach): Delete the computed style here instead.
740         (WebCore::Element::computedStyle): Removed a redundant ref() which was
741         causing the leak. Changed to return 0 if the element is not attached,
742         because in that case there is currently no way to tell when to delete the computed
743         style.
744
745 2007-07-08  Mitz Pettel  <mitz@webkit.org>
746
747         Reviewed by Darin.
748
749         - fix http://bugs.webkit.org/show_bug.cgi?id=12384
750           getComputedStyle with td.style.display='none' reports '' for all properties except display
751
752         Test: fast/css/computed-style-without-renderer.html
753
754         Implement rich computed style for elements that do not have a renderer.
755
756         * css/CSSComputedStyleDeclaration.cpp:
757         (WebCore::getPositionOffsetValue): Changed to take a RenderStyle instead of
758         a RenderObject.
759         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to
760         use the computed style returned by the node instead of going through the
761         renderer. Changed properties that compute by measuring the renderer to
762         fall back on returning the length from the RenderStyle if a renderer does
763         not exist.
764         (WebCore::CSSComputedStyleDeclaration::length): Changed to return the number
765         of properties we can compute even if the element has no renderer.
766         (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): Changed
767         to use the computed style returned by the node instead of going through the
768         renderer.
769         * dom/Element.cpp:
770         (WebCore::ElementRareData::ElementRareData): Added a computed style member,
771         used to cache computed style for elements that do not have a renderer.
772         (WebCore::ElementRareData::resetComputedStyle): Added.
773         (WebCore::Element::~Element): Delete the cached computed style.
774         (WebCore::Element::recalcStyle): Added code to delete the cached computed
775         style when necessary.
776         (WebCore::Element::computedStyle): Added. Returns the style used in rendering
777         the element, if available. Otherwise uses the style selector to compute style
778         for the element.
779         * dom/Element.h:
780         * dom/Node.cpp:
781         (WebCore::Node::computedStyle): Added. This method returns either the style
782         used in rendering the node, or the style that would be used if the node
783         had a renderer.
784         * dom/Node.h:
785
786 2007-07-08  Mitz Pettel  <mitz@webkit.org>
787
788         Reviewed by Darin.
789
790         - fix http://bugs.webkit.org/show_bug.cgi?id=14544
791           Scroll wheel events are ignored when the cursor is over an iframe's border
792
793         * page/mac/EventHandlerMac.mm:
794         (WebCore::EventHandler::passWheelEventToWidget): Changed to return false if
795         the event coordinates are not inside the widget's NSView hierarchy.
796
797 2007-07-08  Rob Buis  <buis@kde.org>
798
799         Reviewed by Mitz.
800
801         http://bugs.webkit.org/show_bug.cgi?id=10752
802         The inspector should not respond to Make Text Smaller/Bigger commands
803
804         Use the -webkit-text-size-adjust property to ignore text sizing        
805         and do not take the zoom factor into account for line height when
806         -webkit-text-size-adjust is set to none.
807
808         * css/cssstyleselector.cpp:
809         (WebCore::CSSStyleSelector::applyProperty):
810         * page/inspector/inspector.css:
811
812 2007-07-08  Darin Adler  <darin@apple.com>
813
814         Reviewed by Maciej.
815
816         - fix <rdar://problem/5318994> Integer overflow in WebCore's Base64.cpp:base64Encode
817
818         * platform/Base64.cpp:
819         (WebCore::base64Encode): Check against a maximum size.
820         (WebCore::base64Decode): Ditto.
821
822 2007-07-08  Darin Adler  <darin@apple.com>
823
824         Reviewed by Maciej.
825
826         - fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check
827
828         * platform/ThreadCheck.h: Renamed _WebCoreThreadViolationCheck to reportThreadViolation
829         since it's in the WebCore namespace and also we shouldn't use leading underscores since
830         those are reserved for the compiler and standard library. Added a new function named
831         setDefaultThreadViolationBehavior and an enum for the parameter. Removed the
832         threadViolationIsException parameter from WebCoreReportThreadViolation since we use
833         a global variable for it now. Got rid of the unnecessary use of do while (0) in the
834         WebCoreThreadViolationCheck macro -- since it's only a single function call it's already
835         a statement and doesn't need to be turned into one with the do while (0) trick.
836
837         * platform/mac/ThreadCheck.mm:
838         (WebCore::readThreadViolationBehaviorFromUserDefaults): Moved the code to read from
839         NSUserDefaults into this helper function. Changed it to use stringForKey instead of
840         objectForKey so we don't get a "method not found" if someone puts something other than
841         a string in there. Updated to use the new globals.
842         (WebCore::setDefaultThreadViolationBehavior): Added.
843         (WebCore::reportThreadViolation): Simplified, now that most of the work is in the
844         readThreadViolationBehaviorFromUserDefaults function.
845         (WebCoreReportThreadViolation): Changed to use a global variable instead of parameter
846         to determine how to report a violation. Added LogOnFirstThreadViolation, which will
847         log only once for each function that violates.
848
849         * WebCore.exp: Updated for above changes.
850
851 2007-07-08  Mitz Pettel  <mitz@webkit.org>
852
853         Reviewed by Darin.
854
855         - fix http://bugs.webkit.org/show_bug.cgi?id=14221
856           Repro crash (ASSERTION FAILED: oldText in RenderBlock::updateFirstLetter() during relayout of :before content with first-letter style)
857
858         Test: fast/css-generated-content/before-with-first-letter.html
859
860         * rendering/RenderContainer.cpp:
861         (WebCore::RenderContainer::updateBeforeAfterContentForContainer): If a child
862         of the existing 'before' container is not text, do not assume that it is an
863         image, since it can also be an inline wrapping a first-letter. In that case,
864         do not update its style (so in particular, keep it a FIRST_LETTER type style)
865         and leave it to updateFirstLetter() to take care of.
866
867 2007-07-07  Sam Weinig  <sam@webkit.org>
868
869         Reviewed by Oliver Hunt.
870
871         Bailout early in Window::put() if attribute is readonly to avoid
872         extra calls to isSafeScript().
873
874         * bindings/js/kjs_window.cpp:
875         (KJS::Window::put):
876
877 2007-07-07  Darin Adler  <darin@apple.com>
878
879         Reviewed by Oliver Hunt.
880
881         - fix <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame
882
883         Updated Dashboard quirk so it affects fill, stroke, and clip, rather than just stroke.
884
885         Test: fast/canvas/fill-stroke-clip-reset-path.html
886
887         * html/CanvasRenderingContext2D.h: Added clearPathForDashboardBackwardCompatibilityMode.
888         * html/CanvasRenderingContext2D.cpp:
889         (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode): Added.
890         (WebCore::CanvasRenderingContext2D::fill): Call the new function.
891         (WebCore::CanvasRenderingContext2D::stroke): Replaced in-line code with a call to the new function.
892         (WebCore::CanvasRenderingContext2D::clip): Call the new function.
893
894 2007-07-07  Rob Buis  <buis@kde.org>
895
896         Reviewed and tweaked by Darin.
897
898         http://bugs.webkit.org/show_bug.cgi?id=8994
899         Canvas doesn't reset on resize
900
901         Also reset the rendering context when resetting the canvas.
902
903         * html/HTMLCanvasElement.cpp:
904         (WebCore::HTMLCanvasElement::reset):
905         (WebCore::HTMLCanvasElement::drawingContext):
906
907 2007-07-07  Alexey Proskuryakov  <ap@webkit.org>
908
909         Reviewed by Maciej.
910
911         http://bugs.webkit.org/show_bug.cgi?id=14525
912         Support exslt:node-set()
913
914         Test: fast/xsl/exslt-node-set.xml
915
916         * xml/XSLTExtensions.cpp: Added.
917         (WebCore::exsltNodeSetFunction): A copy of exslt:node-set() implementation
918         from libexslt 1.1.11 (shipped with Tiger).
919         (WebCore::registerXSLTExtensions): This function registers any WebCore-provided
920         extensions on a context. Currently, the only extension is exslt:node-set().
921         * xml/XSLTExtensions.h: Added.
922
923         * xml/XSLTProcessor.cpp:
924         (WebCore::XSLTProcessor::transformToString):
925         Register extensions when creating a context.
926
927         * WebCore.pro:
928         * WebCore.vcproj/WebCore.vcproj:
929         * WebCore.xcodeproj/project.pbxproj:
930         * WebCoreSources.bkl:
931         Add XSLTExtensions.{h,cpp} to projects.
932
933 2007-07-06  Maciej Stachowiak  <mjs@apple.com>
934
935         Reviewed by Oliver.
936
937         - fixed <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message
938         
939         test case: fast/loader/early-load-cancel.html
940
941         * loader/ResourceLoader.cpp:
942         (WebCore::ResourceLoader::didCancel): Don't send cancel-related client callbacks
943         if we never even sent willSendRequest because we were deferred.
944
945 2007-07-06  Oliver Hunt  <oliver@apple.com>
946
947         Reviewed by Maciej.
948
949         Pulled a number of methods from WebKit and WebCoreFrameBridge into 
950         C++ objects.
951
952         * WebCore.exp:
953         * WebCore.xcodeproj/project.pbxproj:
954         * editing/Editor.cpp:
955         (WebCore::Editor::replaceMarkedText):
956             From -[WebCoreFrameBridge replaceMarkedTextWithText:]
957         * editing/Editor.h:
958         * page/Frame.cpp:
959         (WebCore::Frame::setMarkedTextRange):
960             Pulled platform independent logic from Mac specific implementation
961         (WebCore::Frame::selectRangeInMarkedText):
962             Converted from -[WebHTMLView _selectRangeInMarkedText:]
963         * page/Frame.h:
964         * page/mac/FrameMac.mm:
965         (WebCore::Frame::setMarkedTextRange):
966             Now only does Mac specific logic when manipulating initial
967             NSAttributedString
968         * page/mac/WebCoreFrameBridge.h:
969         * page/mac/WebCoreFrameBridge.mm:
970             Removed -[WebCoreFrameBridge replaceMarkedTextWithText:]
971
972 2007-07-06  Mitz Pettel  <mitz@webkit.org>
973
974         Reviewed by Darin.
975
976         - fix http://bugs.webkit.org/show_bug.cgi?id=14545
977           REGRESSION (r21854-r21869): Repro crash in RenderBlock::updateFirstLetter @ nola.com/rose/
978
979         Test: fast/css/first-letter-capitalized.html
980
981         * rendering/RenderBlock.cpp:
982         (WebCore::RenderBlock::updateFirstLetter): Moved the call to setFirstLetter
983         further down so that the first letter is not destroyed if a text transform
984         is applied to the remaining text fragment when it is add to the render tree.
985         * rendering/RenderText.cpp:
986         (WebCore::RenderText::previousCharacter): Factored out of setTextInternal.
987         (WebCore::RenderText::setTextInternal): Changed to call previousCharacter().
988         * rendering/RenderText.h:
989         * rendering/RenderTextFragment.cpp:
990         (WebCore::RenderTextFragment::previousCharacter): Override to return the
991         character in the original string before the start of the fragment. 
992         * rendering/RenderTextFragment.h:
993
994 2007-07-06  Mitz Pettel  <mitz@webkit.org>
995
996         Reviewed by Beth.
997
998         - fix http://bugs.webkit.org/show_bug.cgi?id=14536
999           Unnecessary layout done when mousing down in text field
1000
1001         No test possible because there is no change in functionality.
1002
1003         * rendering/RenderTextControl.cpp:
1004         (WebCore::RenderTextControl::setStyle): Reset the height and the width in
1005         the old style to avoid getting a layout hint as a result of having mutated
1006         the old style during layout.
1007         (WebCore::RenderTextControl::layout): Update children's layout if an inner
1008         block's dimensions should change. This need for layout was previously masked
1009         by the bug.
1010
1011 2007-07-06  Brady Eidson  <beidson@apple.com>
1012
1013         Fix builds that use IconDatabaseNone.cpp - better, this time
1014
1015         * loader/icon/IconDatabaseNone.cpp:
1016         (WebCore::IconDatabase::isOpen):
1017
1018 2007-07-06  Brady Eidson  <beidson@apple.com>
1019
1020         Fix builds that use IconDatabaseNone.cpp
1021
1022         * loader/icon/IconDatabaseNone.cpp:
1023         (WebCore::IconDatabase::databasePath): 
1024
1025 2007-07-06  John Sullivan  <sullivan@apple.com>
1026
1027         Reviewed by Brady
1028         
1029         - WebCore part of fix for: 
1030           <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files
1031         
1032         * loader/icon/IconDatabase.h:
1033         * loader/icon/IconDatabase.cpp:
1034         (WebCore::IconDatabase::isOpen): 
1035         made this method const (necessary to make IconDatabase::databasePath const)
1036         (WebCore::IconDatabase::databasePath): 
1037         new method, returns SQLDatabase's path if open, otherwise empty string
1038         
1039         * loader/icon/SQLDatabase.cpp:
1040         (WebCore::SQLDatabase::open):
1041         don't append a null character to the m_path ivar. The appended null character was making the path()
1042         method return a String with a trailing null, which is bad. However, there were no callers to the
1043         path() method until now. Instead of appending a null character to the ivar, use charactersWithNullTermination()
1044         instead of characters() when opening the database.
1045         
1046         * loader/icon/SQLDatabase.h:
1047         (WebCore::SQLDatabase::isOpen):
1048         made this method const (necessary to make IconDatabase::databasePath const)
1049         (WebCore::SQLDatabase::path):
1050         made this method const (not required for these changes, but seemed worth doing at the same time)
1051
1052         * WebCore.exp:
1053         added symbol for IconDatabase::databasePath
1054
1055 2007-07-06  George Staikos  <staikos@kde.org>
1056
1057         No real functional change - just move the localizations out and
1058         stick some placeholder text in.
1059
1060         * platform/qt/Localizations.cpp: Added.
1061         (WebCore::submitButtonDefaultLabel):
1062         (WebCore::inputElementAltText):
1063         (WebCore::resetButtonDefaultLabel):
1064         (WebCore::defaultLanguage):
1065         (WebCore::searchableIndexIntroduction):
1066         (WebCore::fileButtonChooseFileLabel):
1067         (WebCore::fileButtonNoFileSelectedLabel):
1068         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
1069         (WebCore::contextMenuItemTagDownloadLinkToDisk):
1070         (WebCore::contextMenuItemTagCopyLinkToClipboard):
1071         (WebCore::contextMenuItemTagOpenImageInNewWindow):
1072         (WebCore::contextMenuItemTagDownloadImageToDisk):
1073         (WebCore::contextMenuItemTagCopyImageToClipboard):
1074         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
1075         (WebCore::contextMenuItemTagCopy):
1076         (WebCore::contextMenuItemTagGoBack):
1077         (WebCore::contextMenuItemTagGoForward):
1078         (WebCore::contextMenuItemTagStop):
1079         (WebCore::contextMenuItemTagReload):
1080         (WebCore::contextMenuItemTagCut):
1081         (WebCore::contextMenuItemTagPaste):
1082         (WebCore::contextMenuItemTagNoGuessesFound):
1083         (WebCore::contextMenuItemTagIgnoreSpelling):
1084         (WebCore::contextMenuItemTagLearnSpelling):
1085         (WebCore::contextMenuItemTagSearchWeb):
1086         (WebCore::contextMenuItemTagLookUpInDictionary):
1087         (WebCore::contextMenuItemTagOpenLink):
1088         (WebCore::contextMenuItemTagIgnoreGrammar):
1089         (WebCore::contextMenuItemTagSpellingMenu):
1090         (WebCore::contextMenuItemTagShowSpellingPanel):
1091         (WebCore::contextMenuItemTagCheckSpelling):
1092         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
1093         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
1094         (WebCore::contextMenuItemTagFontMenu):
1095         (WebCore::contextMenuItemTagBold):
1096         (WebCore::contextMenuItemTagItalic):
1097         (WebCore::contextMenuItemTagUnderline):
1098         (WebCore::contextMenuItemTagOutline):
1099         (WebCore::contextMenuItemTagWritingDirectionMenu):
1100         (WebCore::contextMenuItemTagDefaultDirection):
1101         (WebCore::contextMenuItemTagLeftToRight):
1102         (WebCore::contextMenuItemTagRightToLeft):
1103         (WebCore::contextMenuItemTagInspectElement):
1104         (WebCore::searchMenuNoRecentSearchesText):
1105         (WebCore::searchMenuRecentSearchesText):
1106         (WebCore::searchMenuClearRecentSearchesText):
1107         (WebCore::AXWebAreaText):
1108         (WebCore::AXLinkText):
1109         (WebCore::AXListMarkerText):
1110         (WebCore::AXImageMapText):
1111         (WebCore::AXHeadingText):
1112         * platform/qt/TemporaryLinkStubs.cpp:
1113
1114 2007-07-06  Geoffrey Garen  <ggaren@apple.com>
1115
1116         Reviewed by Anders Carlsson.
1117
1118         A little more FrameLoader cleanup while working on <rdar://problem/5126396>.
1119         
1120         Moved url() and URL() methods next to each other to highlight their subtlety.
1121
1122         * loader/FrameLoader.cpp:
1123         (WebCore::FrameLoader::url):
1124         * loader/FrameLoader.h:
1125
1126 2007-07-06  Geoffrey Garen  <ggaren@apple.com>
1127
1128         Reviewed by Anders Carlsson.
1129
1130         A little FrameLoader cleanup while working on <rdar://problem/5126396>.
1131         
1132         Renamed endIfNotLoading() to endIfNotLoadingMainResource() because "loading"
1133         and "loadingMainResource" have distinct meanings and this function
1134         honors the latter.
1135
1136         (WebCore::FrameLoader::endIfNotLoadingMainResource): Protect after the
1137         early return to avoid ref count churn.
1138         * loader/FrameLoader.h:
1139         (WebCore::FrameLoader::isLoadingMainResource): Inlined this function.
1140
1141 2007-07-06  Adam Treat  <adam@staikos.net>
1142
1143         Reviewed by George Staikos.
1144
1145         Convert QWebFrame to a QFrame from a scroll area.
1146
1147         * page/qt/EventHandlerQt.cpp:
1148         (WebCore::EventHandler::passSubframeEventToSubframe):
1149         (WebCore::EventHandler::passWheelEventToWidget):
1150         (WebCore::EventHandler::createDraggingClipboard):
1151         (WebCore::EventHandler::passMousePressEventToScrollbar):
1152         * platform/ScrollView.h:
1153         * platform/Widget.h:
1154         * platform/qt/PlatformScrollBar.h:
1155         * platform/qt/PlatformScrollBarQt.cpp:
1156         (WebCore::PlatformScrollbar::setRect):
1157         (WebCore::PlatformScrollbar::frameGeometry):
1158         (WebCore::PlatformScrollbar::setFrameGeometry):
1159         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
1160         (WebCore::PlatformScrollbar::handleMousePressEvent):
1161         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
1162         * platform/qt/ScrollViewQt.cpp:
1163         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
1164         (WebCore::ScrollView::ScrollViewPrivate::~ScrollViewPrivate):
1165         (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
1166         (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
1167         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
1168         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
1169         (WebCore::ScrollView::ScrollViewPrivate::windowClipRect):
1170         (WebCore::ScrollView::ScrollView):
1171         (WebCore::ScrollView::~ScrollView):
1172         (WebCore::ScrollView::setScrollArea):
1173         (WebCore::ScrollView::horizontalScrollBar):
1174         (WebCore::ScrollView::verticalScrollBar):
1175         (WebCore::ScrollView::updateContents):
1176         (WebCore::ScrollView::update):
1177         (WebCore::ScrollView::visibleWidth):
1178         (WebCore::ScrollView::visibleHeight):
1179         (WebCore::ScrollView::visibleContentRect):
1180         (WebCore::ScrollView::setContentsPos):
1181         (WebCore::ScrollView::resizeContents):
1182         (WebCore::ScrollView::setFrameGeometry):
1183         (WebCore::ScrollView::geometryChanged):
1184         (WebCore::ScrollView::contentsX):
1185         (WebCore::ScrollView::contentsY):
1186         (WebCore::ScrollView::contentsWidth):
1187         (WebCore::ScrollView::contentsHeight):
1188         (WebCore::ScrollView::windowToContents):
1189         (WebCore::ScrollView::contentsToWindow):
1190         (WebCore::ScrollView::scrollOffset):
1191         (WebCore::ScrollView::maximumScroll):
1192         (WebCore::ScrollView::scrollBy):
1193         (WebCore::ScrollView::scrollRectIntoViewRecursively):
1194         (WebCore::ScrollView::hScrollbarMode):
1195         (WebCore::ScrollView::vScrollbarMode):
1196         (WebCore::ScrollView::suppressScrollbars):
1197         (WebCore::ScrollView::setHScrollbarMode):
1198         (WebCore::ScrollView::setVScrollbarMode):
1199         (WebCore::ScrollView::setScrollbarsMode):
1200         (WebCore::ScrollView::setStaticBackground):
1201         (WebCore::ScrollView::inWindow):
1202         (WebCore::ScrollView::updateScrollbars):
1203         (WebCore::ScrollView::scrollbarUnderMouse):
1204         (WebCore::ScrollView::addChild):
1205         (WebCore::ScrollView::removeChild):
1206         (WebCore::ScrollView::paint):
1207         (WebCore::ScrollView::wheelEvent):
1208         (WebCore::ScrollView::scroll):
1209         (WebCore::ScrollView::windowResizerRect):
1210         (WebCore::ScrollView::resizerOverlapsContent):
1211         (WebCore::ScrollView::adjustOverlappingScrollbarCount):
1212         (WebCore::ScrollView::setParent):
1213         (WebCore::ScrollView::addToDirtyRegion):
1214         (WebCore::ScrollView::scrollBackingStore):
1215         (WebCore::ScrollView::updateBackingStore):
1216         * platform/qt/WidgetQt.cpp:
1217         (WebCore::WidgetPrivate::canvas):
1218         (WebCore::WidgetPrivate::setGeometry):
1219         (WebCore::WidgetPrivate::geometry):
1220         (WebCore::Widget::setQWidget):
1221         (WebCore::Widget::paint):
1222         (WebCore::Widget::originalGeometry):
1223         (WebCore::Widget::geometryChanged):
1224
1225 2007-07-06  Anders Carlsson  <andersca@apple.com>
1226
1227         Reviewed by Mitz.
1228
1229         <rdar://problem/5280532> 
1230         REGRESSION: Can't access nested embed by document.name if object is not immediate parent
1231         
1232         Traverse up the tree looking for an object element.
1233         
1234         * html/HTMLEmbedElement.cpp:
1235         (WebCore::HTMLEmbedElement::getInstance):
1236
1237 2007-07-06  George Staikos  <staikos@kde.org>
1238
1239         Qt build fix: Don't clobber qmake variables that are already set.
1240
1241         * WebCore.pro:
1242
1243 2007-07-05  Maciej Stachowiak  <mjs@apple.com>
1244
1245         Reviewed by Antti.
1246
1247         - <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings
1248
1249         * platform/StringHash.h:
1250         (WTF::): Adapt to newer way to do storage types.
1251
1252 2007-07-06  Bernhard Rosenkraenzer  <bero@arklinux.org>
1253
1254         Reviewed by Sam.
1255
1256         Fix for http://bugs.webkit.org/show_bug.cgi?id=13985
1257         Bug 13985: WebCore/rendering/RenderTable.cpp fails to compile with gcc 4.2.x
1258
1259         * rendering/RenderTable.cpp:
1260         (WebKit::RenderTable::calcBorderLeft)
1261         (WebKit::RenderTable::calcBorderRight)
1262
1263 2007-07-06  Maxime Britto  <mbritto@pleyo.com>
1264
1265         Reviewed by Maciej.
1266
1267         Fix http://bugs.webkit.org/show_bug.cgi?id=13038
1268         Bug 13038: ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
1269
1270         Modify an ASSERT in goToItem related to going back/forward in history.  We don't need to check the frameset if the target is _blank.
1271         The attached test case is a manual one since it relies on having pages opened in tabs in Safari.
1272
1273         * manual-tests/goBack-blank-tab-page.html: Added.
1274         * manual-tests/resources/before-go-back.html: Added.
1275         * manual-tests/resources/will-go-back.html: Added.
1276         * page/Page.cpp:
1277         (WebCore::Page::goToItem):
1278
1279 2007-07-06  Mitz Pettel  <mitz@webkit.org>
1280
1281         Reviewed by Maciej.
1282
1283         - fix http://bugs.webkit.org/show_bug.cgi?id=14400
1284           Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube
1285
1286         Test: fast/forms/button-state-restore.html
1287
1288         * dom/Document.h:
1289         (WebCore::Document::isFormElementRegistered): Added.
1290         * html/HTMLGenericFormElement.cpp:
1291         (WebCore::HTMLGenericFormElement::closeRenderer): Restore saved form
1292         element state only if the element is registered with the document to
1293         have its state saved.
1294
1295 2007-07-06  Mitz Pettel  <mitz@webkit.org>
1296
1297         Reviewed by Maciej.
1298
1299         - fix http://bugs.webkit.org/show_bug.cgi?id=14487
1300           Incomplete repaint of background and border of boxes with -webkit-border-fit:lines
1301
1302         Test: fast/repaint/border-fit-lines.html
1303
1304         * rendering/RenderObject.cpp:
1305         (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Do a full repaint if
1306         -webkit-border-fit:lines was specified.
1307
1308 2007-07-06  Tony Chang  <idealisms@gmail.com>
1309
1310         Reviewed by Maciej.
1311
1312         http://bugs.webkit.org/show_bug.cgi?id=14516
1313         Bug 14516: crash loading multipart/x-mixed-replace data on windows safari
1314
1315         NULL check m_resourceData to prevent a crash in Safari on Windows.
1316
1317         * loader/ResourceLoader.cpp:
1318         (WebCore::ResourceLoader::clearResourceData):
1319
1320 2007-07-06  Jungshik Shin  <jungshik.shin@gmail.com>
1321
1322         Reviewed by Alexey.
1323
1324         - Add UTF-32 encoding support 
1325           http://bugs.webkit.org/show_bug.cgi?id=13415
1326
1327         Test:
1328          - fast/encoding/utf-32-big-endian-bom.html
1329          - fast/encoding/utf-32-big-endian-nobom.xml
1330          - fast/encoding/utf-32-little-endian-bom.html
1331          - fast/encoding/utf-32-little-endian-nobom.xml
1332
1333         * loader/TextResourceDecoder.cpp:
1334         (WebCore::TextResourceDecoder::checkForBOM):
1335         (WebCore::TextResourceDecoder::checkForHeadCharset):
1336         * platform/TextDecoder.cpp:
1337         (WebCore::TextDecoder::checkForBOM):
1338         * platform/TextDecoder.h:
1339         * platform/TextEncoding.cpp:
1340         (WebCore::UTF32BigEndianEncoding):
1341         (WebCore::UTF32LittleEndianEncoding):
1342         * platform/TextEncoding.h:
1343
1344 2007-07-06  Holger Hans Peter Freyther  <zecke@selfish.org>
1345
1346         Reviewed by Maciej.
1347
1348         Start implementening RenderThemeGdk/Gtk using GtkStyle. The approach is
1349         to allocate one native control for each widget type. And use margins, spacing,
1350         style properties from the Widget. And for drawing use GtkStyle on the rect supplied.
1351
1352         This should allow nice integration and be relative resource friendly. Mozilla is using
1353         a similiar approach. They seem to share the GdkPixmap among several operations and this
1354         will be an obvious candidate for improvements. Create a normally big enough GdkPixmap and
1355         use that for drawing and then set clip regions for cairo to make sure to not go beyond the
1356         width and height.
1357
1358         The next steps will be to introduce states for the widgets, add more widgets, handle focus,
1359         and various other style attributes, honor the size and margin and use that to propagate this
1360         back to RenderStyle*.
1361
1362         * platform/gdk/RenderThemeGdk.cpp:
1363         (WebCore::RenderThemeGdk::RenderThemeGdk):
1364         (WebCore::RenderThemeGdk::setCheckboxSize):
1365         (WebCore::RenderThemeGdk::paintCheckbox):
1366         (WebCore::RenderThemeGdk::setRadioSize):
1367         (WebCore::RenderThemeGdk::paintRadio):
1368         (WebCore::RenderThemeGdk::paintButton):
1369         (WebCore::RenderThemeGdk::copyToContext):
1370         (WebCore::RenderThemeGdk::gtkButton):
1371         (WebCore::RenderThemeGdk::gtkCheckbox):
1372         (WebCore::RenderThemeGdk::gtkRadioButton):
1373         (WebCore::RenderThemeGdk::gtkWindowContainer):
1374         * platform/gdk/RenderThemeGdk.h:
1375
1376 2007-07-06  Rob Buis  <buis@kde.org>
1377
1378         Reviewed by Adam.
1379
1380         http://bugs.webkit.org/show_bug.cgi?id=14442
1381         Adding a stop with value 1.0 to a gradient that has already been used has no effect
1382
1383         Implement start and end stop handling differently so they are not
1384         in the color stop array.
1385
1386         * html/CanvasGradient.cpp:
1387         (WebCore::compareStops):
1388         (WebCore::CanvasGradient::getColor):
1389         (WebCore::CanvasGradient::findStop):
1390
1391 2007-07-06  Adam Roben  <aroben@apple.com>
1392
1393         Fix <rdar://problem/5301994> Garbled text still showing on some sites
1394
1395         Replace calls to GetGlyphIndices with wkGetGlyphs.
1396
1397         Reviewed by Alice.
1398
1399         * platform/win/GlyphPageTreeNodeWin.cpp:
1400         (WebCore::GlyphPage::fill): Use wkGetGlyphs.
1401         * platform/win/FontDataWin.cpp:
1402         (WebCore::FontData::containsCharacters):
1403
1404 2007-07-06  Matt Lilek  <pewtermoose@gmail.com>
1405
1406         Not reviewed - Windows build fix.
1407
1408         * bridge/win/FrameWin.cpp:
1409         (WebCore::imageFromSelection):
1410
1411 2007-07-06  George Staikos  <staikos@kde.org>
1412
1413         Reviewed by Maciej.
1414
1415         Switch USE(ICONDATABASE) to ENABLE(ICONDATABASE) and activate the
1416         flag via the .pro file
1417
1418         * WebCore.pro:
1419         * loader/icon/IconDatabase.h:
1420
1421 2007-07-05  John Sullivan  <sullivan@apple.com>
1422
1423         Reviewed by Adam
1424
1425         - WebCore part of fix for <rdar://problem/5315033>
1426
1427         * rendering/RenderObject.h:
1428         replaced PaintRestrictionSelectionOnlyWhiteText with PaintRestrictionSelectionOnlyBlackText
1429         (WebCore::RenderObject::PaintInfo::PaintInfo):
1430         replaced forceWhiteText with forceBlackText
1431
1432         * rendering/RenderObject.cpp:
1433         (WebCore::RenderObject::addLineBoxRects):
1434         added a useSelectionHeight parameter, which defaults to false; this method is unimplemented
1435         at this level so this has no effect.
1436
1437         * rendering/RenderText.h:
1438         * rendering/RenderText.cpp:
1439         (WebCore::RenderText::addLineBoxRects):
1440         added a useSelectionHeight parameter, which defaults to false. If true, use the vertical position
1441         and height returned by selectionRect rather than replacing it with the more tight-fitting position
1442         and height of the line box.
1443
1444         * dom/Range.h:
1445         * dom/Range.cpp:
1446         (WebCore::Range::addLineBoxRects):
1447         added a useSelectionHeight parameter, which defaults to false. Passes this along to RenderObject.        
1448
1449         * page/Frame.h:
1450         renamed parameter to selectionImage
1451         * page/Frame.cpp:
1452         (WebCore::Frame::selectionTextRects):
1453         pass true for addLineBoxRects new useSelectionHeight parameter, so the rects returned by this new
1454         method will match the height that the selection would be painted here
1455         (WebCore::Frame::paint):
1456         updated for white->black name changes
1457         
1458         * page/mac/FrameMac.mm:
1459         (WebCore::Frame::selectionImage):
1460         updated for white->black name changes
1461         
1462         * rendering/InlineFlowBox.cpp:
1463         (WebCore::InlineFlowBox::paintTextDecorations):
1464         updated for white->black name changes
1465
1466         * rendering/RenderLayer.cpp:
1467         (WebCore::RenderLayer::paintLayer):
1468         updated for white->black name changes
1469
1470         * rendering/InlineTextBox.cpp:
1471         (WebCore::InlineTextBox::paint):
1472         updated for white->black name changes, and actually use black instead of white. This was the goal
1473         of all the name changes.
1474
1475 2007-07-05  Anders Carlsson  <andersca@apple.com>
1476
1477         Reviewed by Oliver.
1478
1479         Fix layout test failures.
1480         
1481         * loader/FrameLoader.cpp:
1482         (WebCore::FrameLoader::commitProvisionalLoad):
1483         Don't make a representation if we're creating the initial document.
1484
1485 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
1486
1487         Fix Bug 14388: Input in text fields limited to 1024 characters
1488         http://bugs.webkit.org/show_bug.cgi?id=14388
1489
1490         Slightly modified by Adam Roben.
1491
1492         Reviewed by Adele.
1493
1494         Tests: fast/forms/input-implicit-length-limit.html
1495                fast/forms/input-maxlength.html
1496
1497         * html/HTMLInputElement.cpp: Bump limit to 524288.
1498         (WebCore::HTMLInputElement::init):
1499         (WebCore::HTMLInputElement::parseMappedAttribute):
1500         * html/HTMLInputElement.h:
1501
1502 2007-07-05  Anders Carlsson  <andersca@apple.com>
1503
1504         Build fix.
1505         
1506         * loader/FrameLoader.cpp:
1507         (WebCore::FrameLoader::init):
1508
1509 2007-07-05  Sam Weinig  <sam@webkit.org>
1510
1511         Reviewed by Geoff.
1512
1513         Add focus, blur and close functions to DOMWindow implementation class
1514         and move bindings from Window to JSDOMWindow.
1515
1516         * bindings/js/JSDOMWindowCustom.cpp:
1517         (WebCore::JSDOMWindow::customGetOwnPropertySlot):
1518         * bindings/js/kjs_window.cpp:
1519         (KJS::Window::getOwnPropertySlot):
1520         (KJS::WindowFunc::callAsFunction):
1521         * bindings/js/kjs_window.h:
1522         (KJS::Window::):
1523         * bindings/scripts/CodeGeneratorJS.pm: Move prototype function declaration from
1524         the implementation to the header.
1525         * page/DOMWindow.cpp:
1526         (WebCore::DOMWindow::focus):
1527         (WebCore::DOMWindow::blur):
1528         (WebCore::DOMWindow::close):
1529         * page/DOMWindow.h:
1530         * page/DOMWindow.idl:
1531
1532 2007-07-05  Justin Garcia  <justin.garcia@apple.com>
1533
1534         Reviewed by Harrison.
1535
1536         <rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body
1537
1538         * editing/TextIterator.cpp:
1539         (WebCore::TextIterator::exitNode): Previously emitted content shouldn't have
1540         to come from a text node in order to emit a '\n' as we exit block containers.
1541
1542 2007-07-05  Anders Carlsson  <andersca@apple.com>
1543
1544         Reviewed by Geoff.
1545
1546         <rdar://problem/5315284> REGRESSION: Leopard Launch Time - plugins are being accessed at startup.
1547
1548         Set a response that has a MIME type of "text/html" on the document loader so WebKit won't refresh the 
1549         plugin database looking for a plug-in that can handle the document's MIME type (which will be null anyway).
1550                  
1551         * loader/FrameLoader.cpp:
1552         (WebCore::FrameLoader::init):
1553
1554 2007-07-05  Anders Carlsson  <andersca@apple.com>
1555
1556         Reviewed by Oliver.
1557
1558         <rdar://problem/5106788>
1559         WebKit loads user style sheets too late as seen in Mail (breaks DataDetectors; Mail flashes wrong font)
1560
1561         Let the document know when the user style sheet is loading so that it try not to display anything
1562         until the user style sheet has finished loading.
1563         
1564         * page/Frame.cpp:
1565         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
1566         (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader):
1567         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
1568         (WebCore::Frame::setUserStyleSheetLocation):
1569
1570 2007-07-05  Sam Weinig  <sam@webkit.org>
1571
1572         Reviewed by Darin.
1573
1574         Move JSDOMWindow overriding getOwnPropertySlot logic from KJS::Window
1575         up into JSDOMWindow.  No change in functionality so no testcase required. 
1576
1577         * bindings/js/JSDOMWindowCustom.cpp:
1578         (WebCore::JSDOMWindow::customGetOwnPropertySlot):
1579         * bindings/js/kjs_window.cpp:
1580         (KJS::Window::getOwnPropertySlot):
1581         * bindings/js/kjs_window.h:
1582
1583 2007-07-05  Mitz Pettel  <mitz@webkit.org>
1584
1585         Reviewed and Landed by Sam.
1586
1587         - fix bug 14465 for window.showModalDialog
1588
1589         * bindings/js/kjs_window.cpp:
1590         (KJS::parseModalDialogFeatures):
1591         (KJS::showModalDialog):
1592
1593 2007-07-05  Sam Weinig  <sam@webkit.org>
1594
1595         Reviewed by Mitz.
1596
1597         Patch for http://bugs.webkit.org/show_bug.cgi?id=14465
1598         window.open() uses the literal "undefined" as the URL
1599
1600         * bindings/js/kjs_window.cpp:
1601         (KJS::WindowFunc::callAsFunction): add checks for undefined and null values when setting the url.
1602         * manual-tests/open-url-undefined.html: Added.
1603
1604 2007-07-05  Holger Hans Peter Freyther  <zecke@selfish.org>
1605
1606         Reviewed by Rob Buis.
1607
1608         Rework FontData and FontPlatformData for the Gdk work to make valgrind
1609         happy.
1610
1611         Move destroying of FontConfig and Cairo objects held in FontPlatformData
1612         to FontData::platformDestroy. The ownership of these objects is held by
1613         FontData. This is following the Mac and Qt port at least.
1614
1615         Currently it is possible that FontPlatformData will not create cairo resources
1616         in this case at least make sure the variables are initialized to 0.
1617         Initialize x,y of the cairo_glyph_t with zero to avoid extents.x_advance depending
1618         on subtracing with not defined values.
1619
1620         FontPlatformData::hash. Using FontDescription is a bad idea as we don't have a clue
1621         about how it is packed, if holes are present, etc. The FcPattern and the m_fontMatrix
1622         should be good enough to describe the Font. All other objects are created using these
1623         variables
1624
1625         Replace C-style casts with C++ casts, in this case reinterpret_cast.
1626
1627         * platform/gdk/FontDataGdk.cpp:
1628         (WebCore::FontData::platformInit): Don't assert
1629         (WebCore::FontData::platformDestroy): Take over ownership
1630         (WebCore::FontData::platformWidthForGlyph): initialize
1631         (WebCore::FontData::setFont): be paranoid and assert
1632         * platform/gdk/FontPlatformData.h:
1633         (WebCore::FontPlatformData::FontPlatformData): Initialize everything
1634         (WebCore::FontPlatformData::hash): make valgrind happy and don't use m_fontDescription
1635         * platform/gdk/FontPlatformDataGdk.cpp:
1636         (WebCore::FontPlatformData::FontPlatformData):
1637         (WebCore::FontPlatformData::~FontPlatformData): FontData::platformDestroy will do this
1638         (WebCore::FontPlatformData::list): Don't use C-style casts.
1639         (WebCore::FontPlatformData::setFont): m_fontFace, m_fontMatrix, m_options might not be initialized
1640         (WebCore::FontPlatformData::operator==): Don't use C-style casts.
1641
1642 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
1643
1644         Reviewed by Mark Rowe.
1645
1646         http://bugs.webkit.org/show_bug.cgi?id=14445
1647         GraphicsContextCairo code style cleanup
1648
1649         Follow the cr naming convention for cairo_t*.
1650         Remove trailing whitespace.
1651         Replace C casts with C++ casts.
1652         Avoid needless casts.
1653
1654         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1655         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
1656         (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
1657         (WebCore::GraphicsContext::GraphicsContext):
1658         (WebCore::GraphicsContext::platformContext):
1659         (WebCore::GraphicsContext::savePlatformState):
1660         (WebCore::GraphicsContext::restorePlatformState):
1661         (WebCore::GraphicsContext::drawRect):
1662         (WebCore::adjustLineToPixelBoundaries):
1663         (WebCore::GraphicsContext::drawLine):
1664         (WebCore::GraphicsContext::drawEllipse):
1665         (WebCore::GraphicsContext::strokeArc): Save/restore the graphics state.
1666         (WebCore::GraphicsContext::drawConvexPolygon):
1667         (WebCore::GraphicsContext::fillRect):
1668         (WebCore::GraphicsContext::clip):
1669         (WebCore::GraphicsContext::drawFocusRing):
1670         (WebCore::GraphicsContext::roundToDevicePixels):
1671         (WebCore::GraphicsContext::translate):
1672         (WebCore::GraphicsContext::origin):
1673         (WebCore::GraphicsContext::setPlatformStrokeThickness):
1674         (WebCore::GraphicsContext::setPlatformStrokeStyle):
1675         (WebCore::GraphicsContext::setPlatformFont):
1676         (WebCore::GraphicsContext::concatCTM):
1677         (WebCore::GraphicsContext::addInnerRoundedRectClip):
1678         (WebCore::GraphicsContext::beginTransparencyLayer):
1679         (WebCore::GraphicsContext::endTransparencyLayer):
1680         (WebCore::GraphicsContext::clearRect):
1681         (WebCore::GraphicsContext::setLineCap):
1682         (WebCore::GraphicsContext::setLineJoin):
1683         (WebCore::GraphicsContext::setMiterLimit):
1684         (WebCore::GraphicsContext::setCompositeOperation):
1685         (WebCore::GraphicsContext::beginPath):
1686         (WebCore::GraphicsContext::addPath):
1687         (WebCore::GraphicsContext::rotate):
1688         (WebCore::GraphicsContext::scale):
1689         * platform/graphics/cairo/ImageBufferCairo.cpp:
1690         (WebCore::ImageBuffer::ImageBuffer):
1691         * platform/graphics/cairo/ImageCairo.cpp: Avoid the confusing ctxt/context naming scheme.
1692         (WebCore::BitmapImage::draw):
1693         (WebCore::Image::drawPattern):
1694
1695 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
1696
1697         Reviewed by Mark Rowe.
1698
1699         http://bugs.webkit.org/show_bug.cgi?id=14531
1700         Cairo SVGImage::nativeImageForCurrentFrame() has no return
1701
1702         Return the Cairo surface from the frame cache.
1703
1704         Also add a fall-through else macro with notImplemented() so that future
1705         ports do not make the same mistake.
1706
1707         * platform/graphics/svg/SVGImage.cpp:
1708         (WebCore::SVGImage::nativeImageForCurrentFrame):
1709
1710 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
1711
1712         Reviewed by Mark Rowe.
1713
1714         http://bugs.webkit.org/show_bug.cgi?id=14513
1715         Cairo animated GIF support is broken
1716
1717         Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.
1718
1719         * platform/graphics/cairo/ImageSourceCairo.cpp:
1720         (WebCore::ImageSource::frameIsCompleteAtIndex):
1721
1722 2007-07-04  Matt Perry  <mpComplete@gmail.com>
1723
1724         Reviewed by Adam.
1725
1726         Fix for http://bugs.webkit.org/show_bug.cgi?id=13400
1727         Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
1728         <rdar://problem/5153025>
1729
1730         Treat userGesture as always true for setLocation, forcing a back/forward
1731         entry to be created.
1732
1733         * bindings/js/JSHTMLDocumentCustom.cpp:
1734         (WebCore::JSHTMLDocument::setLocation):
1735
1736 2007-07-04  Adam Roben  <aroben@apple.com>
1737
1738         Restore MouseEventWithHitTestResults::targetNode's old behavior
1739
1740         Reviewed by Mark.
1741
1742         Fixes fast/images/imagemap-case and fast/replace/image-map.
1743
1744         * page/MouseEventWithHitTestResults.cpp:
1745         (WebCore::MouseEventWithHitTestResults::targetNode): Use the inner
1746         node, not the inner non-shared node.
1747
1748 2007-07-04  Adam Roben  <aroben@apple.com>
1749
1750         Mac, Qt, and Gdk build fixes.
1751
1752         * page/EventHandler.h:
1753         * page/gdk/EventHandlerGdk.cpp:
1754         * page/mac/EventHandlerMac.mm:
1755         (WebCore::EventHandler::passSubframeEventToSubframe):
1756         * page/qt/EventHandlerQt.cpp:
1757
1758 2007-07-04  Adam Roben  <aroben@apple.com>
1759
1760         Fix the Qt/Gdk builds.
1761
1762         * page/gdk/EventHandlerGdk.cpp:
1763         * page/qt/EventHandlerQt.cpp:
1764
1765 2007-07-04  Adam Roben  <aroben@apple.com>
1766
1767         Move tooltip logic down into WebCore so that it can be shared cross-platform
1768
1769         Reviewed by Sam.
1770
1771         * page/Chrome.cpp:
1772         (WebCore::Chrome::setToolTip): Added.
1773         * page/Chrome.h:
1774         * page/ChromeClient.h:
1775         * page/EventHandler.cpp:
1776         (WebCore::EventHandler::mouseMoved): Call Chrome::setToolTip.
1777         * platform/graphics/svg/SVGImageEmptyClients.h:
1778
1779         Added stubs for Gdk:
1780
1781         * platform/gdk/ChromeClientGdk.h:
1782         * platform/gdk/TemporaryLinkStubs.cpp:
1783         (ChromeClientGdk::setToolTip):
1784
1785 2007-07-04  Adam Roben  <aroben@apple.com>
1786
1787         Add Settings::showsURLsInToolTips
1788
1789         Reviewed by Sam.
1790
1791         * WebCore.exp:
1792         * page/Settings.cpp:
1793         (WebCore::Settings::Settings):
1794         * page/Settings.h:
1795
1796 2007-07-04  Adam Roben  <aroben@apple.com>
1797
1798         Move logic for calling mouseDidMoveOverElement into WebCore
1799
1800         Reviewed by Sam.
1801
1802         * page/EventHandler.cpp:
1803         (WebCore::EventHandler::mouseMoved): Added. Calls Chrome::mouseDidMoveOverElement.
1804         (WebCore::EventHandler::handleMouseMoveEvent): Now takes an optional
1805         HitTestResult* parameter which is used to communicate to the caller the
1806         node the mouse is over.
1807         * page/EventHandler.h:
1808         * page/mac/EventHandlerMac.mm:
1809         (WebCore::EventHandler::mouseMoved): Changed to call the overloaded
1810         mouseMoved().
1811         (WebCore::EventHandler::passMouseMoveEventToSubframe): Pass hoveredNode
1812         through to the subframe so we can get the deepest node hovered, not
1813         just the node's parent frame.
1814         * page/win/EventHandlerWin.cpp:
1815         (WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.
1816
1817 2007-07-04  Adam Roben  <aroben@apple.com>
1818
1819         Add Chrome::mouseDidMoveOverElement
1820
1821         This does the work of calling up to the ChromeClient (which will call
1822         the UI delegate).
1823
1824         Reviewed by Sam.
1825
1826         * page/Chrome.cpp:
1827         (WebCore::Chrome::mouseDidMoveOverElement): Added.
1828         * page/Chrome.h:
1829         * page/ChromeClient.h:
1830         * platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to
1831         ChromeClient.
1832         * platform/gdk/ChromeClientGdk.h:
1833         * platform/gdk/TemporaryLinkStubs.cpp:
1834         (ChromeClientGdk::mouseDidMoveOverElement):
1835
1836 2007-07-04  Adam Roben  <aroben@apple.com>
1837
1838         Changed PlatformMouseEvent to store the modifier flags of the event
1839
1840         Reviewed by Sam.
1841
1842         * platform/PlatformMouseEvent.h:
1843         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1844         * platform/mac/PlatformMouseEventMac.mm:
1845         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1846         * platform/win/PlatformMouseEventWin.cpp:
1847         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1848
1849 2007-07-04  Adam Roben  <aroben@apple.com>
1850
1851         Add HitTestResult::setToNonShadowAncestor
1852
1853         Reviewed by Sam.
1854
1855         * page/EventHandler.cpp:
1856         (WebCore::EventHandler::hitTestResultAtPoint): Moved logic into
1857         HitTestResult::setToNonShadowAncestor.
1858         * rendering/HitTestResult.cpp:
1859         (WebCore::HitTestResult::setToNonShadowAncestor):
1860         * rendering/HitTestResult.h:
1861
1862 2007-07-04  Adam Roben  <aroben@apple.com>
1863
1864         Change MouseEventWithHitTestResults to hold onto a HitTestResult
1865
1866         Reviewed by Sam.
1867
1868         * dom/Document.cpp:
1869         (WebCore::Document::prepareMouseEvent):
1870         * page/MouseEventWithHitTestResults.cpp:
1871         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
1872         (WebCore::MouseEventWithHitTestResults::targetNode):
1873         (WebCore::MouseEventWithHitTestResults::localPoint):
1874         (WebCore::MouseEventWithHitTestResults::scrollbar):
1875         * page/MouseEventWithHitTestResults.h:
1876         (WebCore::MouseEventWithHitTestResults::event):
1877         (WebCore::MouseEventWithHitTestResults::hitTestResult):
1878
1879 2007-07-04  Matt Lilek  <pewtermoose@gmail.com>
1880
1881         Not reviewed, gdk build fix.
1882
1883         * platform/gdk/FrameGdk.cpp:
1884
1885 2007-07-05  Antti Koivisto  <antti@apple.com>
1886
1887         Reviewed by John.
1888         
1889         Fix Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
1890         <rdar://problem/5237811>
1891         
1892         It is possible to add table parts (thead etc) without table ancestor to a document fragment. If a new table element
1893         was added to such a part, as in
1894         
1895         div.innerHTML = '<tbody><table>';
1896         
1897         the parser error handling code would try to pop the previous table as normal. However since
1898         the table does not actually exist nothing would happen and parser would go to infinite recursion.
1899         
1900         Solution here is to pop table parts one by one when handling the error inside a fragment instead of trying to pop
1901         the table straight away (as it might not exist).
1902
1903         * html/HTMLParser.cpp:
1904         (WebCore::HTMLParser::handleError):
1905
1906 2007-07-04  Qing Zhao  <qing@staikos.net>
1907
1908         Reviewed by George Staikos.
1909
1910         Draw menulist (comboboxes) without text overlap on the button.
1911
1912         * platform/qt/RenderThemeQt.cpp:
1913         (WebCore::RenderThemeQt::setPopupPadding):
1914
1915 2007-07-04  George Staikos  <staikos@kde.org>
1916
1917         Compile
1918
1919         * page/qt/FrameQt.cpp:
1920         * WebCore.pro:
1921
1922 2007-07-04  Sam Weinig  <sam@webkit.org>
1923
1924         Reviewed by Mitz.
1925
1926         Patch for http://bugs.webkit.org/show_bug.cgi?id=14504
1927         REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly
1928
1929         - Made it possible (again) to shadow window properties with local variable names.
1930
1931         Test: fast/dom/Window/window-property-shadowing.html
1932
1933         * bindings/js/JSDOMWindowCustom.cpp:
1934         (WebCore::JSDOMWindow::customPut):
1935         * bindings/js/kjs_window.cpp:
1936         (KJS::Window::put):
1937         * bindings/scripts/CodeGeneratorJS.pm:
1938         * page/DOMWindow.idl:
1939
1940 2007-07-03  Alice Liu  <alice.liu@apple.com>
1941
1942         Reviewed by Adam.
1943
1944         Fixed <rdar://problem/5225119> support smart pasting on Windows
1945
1946         * WebCore.vcproj/WebCore.vcproj:
1947         * WebCore.xcodeproj/project.pbxproj:
1948             Added new files
1949         * editing/SmartReplace.cpp: Added.
1950         (WebCore::isCharacterSmartReplaceExempt):
1951             Added non-CF implementation placeholder
1952         * editing/SmartReplace.h: Added.
1953         * editing/SmartReplaceCF.cpp: Added.
1954         (WebCore::getSmartSet):
1955         (WebCore::isCharacterSmartReplaceExempt):
1956             Added new implementation
1957
1958         * bridge/win/FrameWin.cpp:
1959         * page/Frame.h:
1960         * page/mac/FrameMac.mm:
1961             Removed old declaration and implementation
1962
1963         * editing/ReplaceSelectionCommand.cpp:
1964         (WebCore::ReplaceSelectionCommand::doApply):
1965             Changed to call the new function instead of old
1966
1967         * page/mac/WebCoreFrameBridge.h:
1968         * page/mac/WebCoreFrameBridge.mm:
1969             Removed old declaration and implementation
1970         (-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):
1971             Changed to call the new function instead of old
1972
1973         * platform/win/PasteboardWin.cpp:
1974         (WebCore::Pasteboard::Pasteboard):
1975             Register new clipboard format
1976         (WebCore::Pasteboard::writeSelection):
1977             Set data for smartpaste format on clipboard
1978         (WebCore::Pasteboard::canSmartReplace):
1979             Added non-stub implementation
1980
1981 2007-07-04  Qing Zhao  <qing@staikos.net>
1982
1983         Reviewed by George Staikos.
1984
1985         Similar to the PlatformScrollbar fixes, adjust the painter to make the
1986         styler draw all subcontrols, and in this case the focus rect, in the
1987         proper location
1988
1989         * platform/qt/RenderThemeQt.cpp:
1990         (WebCore::RenderThemeQt::paintMenuList):
1991
1992 2007-07-04  Mitz Pettel  <mitz@webkit.org>
1993
1994         Reviewed by Maciej.
1995
1996         - fix http://bugs.webkit.org/show_bug.cgi?id=14495
1997           REGRESSION: Wrong cursor is displayed during drag and drop when text is selected
1998           <rdar://problem/5312384>
1999
2000         No test possible because DumpRenderTree cannot query the current cursor.
2001
2002         * page/EventHandler.cpp:
2003         (WebCore::EventHandler::selectCursor): Changed into a member function and
2004         added that if the last mouse down event could not have started a
2005         selection, then the cursor should not change to an I-beam unconditionally.
2006         (WebCore::EventHandler::handleMouseMoveEvent):
2007         * page/EventHandler.h:
2008
2009 2007-07-04  Holger Hans Peter Freyther  <zecke@selfish.org>
2010
2011         Reviewed by Rob Buis.
2012
2013         A little progress in tracking dependencies.
2014
2015         * WebCore.pro: Add DEPENDPATH for the Gdk port.
2016
2017 2007-07-03  Darin Adler  <darin@apple.com>
2018
2019         Reviewed by Tim Hatcher.
2020
2021         - fix <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
2022
2023         Test: editing/style/font-family-with-space.html
2024
2025         * css/FontFamilyValue.cpp:
2026         (WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does.
2027         (WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just
2028         checking for a leading "#" character.
2029         * editing/markup.cpp:
2030         (WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency.
2031         (WebCore::renderedText): Changed to return a String for better efficiency.
2032         (WebCore::addNamespace): Updated to pass String to escapeTextForMarkup.
2033         (WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call
2034         to escapeTextForMarkup in the special case for the style property.
2035         (WebCore::createMarkup): Changed from single quotes to double quotes and also added missing
2036         call to escapeTextForMarkup in two special cases for the style property.
2037
2038 2007-07-03  Sam Weinig  <sam@webkit.org>
2039
2040         Reviewed by Darin.
2041
2042         Twelfth round of fixes for implicit 64-32 bit conversion errors.
2043         <rdar://problem/5292262>
2044
2045         - Add casts and accompanying FIXMEs to avoid remaining compiler errors.
2046
2047         * WebCore.xcodeproj/project.pbxproj:
2048         * loader/FrameLoader.cpp:
2049         (WebCore::FrameLoader::opened):
2050         (WebCore::FrameLoader::sendRemainingDelegateMessages):
2051         * loader/FrameLoader.h:
2052         * loader/ResourceLoader.cpp:
2053         (WebCore::ResourceLoader::didReceiveData):
2054         * platform/network/mac/ResourceHandleMac.mm:
2055         (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
2056         (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
2057         * platform/network/mac/ResourceResponseMac.mm:
2058         (WebCore::ResourceResponse::nsURLResponse):
2059
2060 2007-07-03  Anders Carlsson  <andersca@apple.com>
2061
2062         Reviewed by Adam.
2063
2064         <rdar://problem/5093862>
2065         Nothing shown in plugin area when trying to play content using the DivX plugin
2066         
2067         Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.
2068                 
2069         * plugins/win/PluginViewWin.cpp:
2070         (WebCore::PluginViewWin::determineQuirks):
2071
2072 2007-07-03  Sam Weinig  <sam@webkit.org>
2073
2074         Reviewed by Brady Eidson.
2075
2076         Ninth round of fixes for implicit 64-32 bit conversion errors.
2077         <rdar://problem/5292262>
2078
2079         - Fix function signature to use unsigned long instead of unsigned long long.
2080
2081         * loader/ProgressTracker.cpp:
2082         (WebCore::ProgressTracker::completeProgress):
2083         * loader/ProgressTracker.h:
2084
2085 2007-07-03  Sam Weinig  <sam@webkit.org>
2086
2087         Reviewed by Oliver.
2088
2089         Eighth round of fixes for implicit 64-32 bit conversion errors.
2090         <rdar://problem/5292262>
2091
2092         - Convert SVG implementation files to use floats instead of doubles
2093           to match the spec/IDLs.
2094
2095         * bindings/scripts/CodeGeneratorJS.pm:
2096         * ksvg2/svg/SVGAngle.cpp:
2097         * ksvg2/svg/SVGAnimatedTemplate.h:
2098         * ksvg2/svg/SVGAnimationElement.cpp:
2099         (WebCore::SVGAnimationElement::getEndTime):
2100         (WebCore::SVGAnimationElement::getStartTime):
2101         (WebCore::SVGAnimationElement::getCurrentTime):
2102         (WebCore::SVGAnimationElement::getSimpleDuration):
2103         * ksvg2/svg/SVGAnimationElement.h:
2104         * ksvg2/svg/SVGFitToViewBox.cpp:
2105         (WebCore::SVGFitToViewBox::parseViewBox):
2106         * ksvg2/svg/SVGLength.cpp:
2107         (WebCore::SVGLength::setValueAsString):
2108         * ksvg2/svg/SVGLinearGradientElement.cpp:
2109         (WebCore::SVGLinearGradientElement::buildGradient):
2110         * ksvg2/svg/SVGMatrix.idl:
2111         * ksvg2/svg/SVGNumber.idl:
2112         * ksvg2/svg/SVGParserUtilities.cpp:
2113         (WebCore::SVGPathParser::parseSVG):
2114         (WebCore::SVGPathParser::calculateArc):
2115         (WebCore::SVGPathParser::svgLineToHorizontal):
2116         (WebCore::SVGPathParser::svgLineToVertical):
2117         (WebCore::SVGPathParser::svgCurveToCubicSmooth):
2118         (WebCore::SVGPathParser::svgCurveToQuadratic):
2119         (WebCore::SVGPathParser::svgCurveToQuadraticSmooth):
2120         (WebCore::SVGPathParser::svgArcTo):
2121         * ksvg2/svg/SVGParserUtilities.h:
2122         * ksvg2/svg/SVGPathElement.cpp:
2123         (WebCore::SVGPathElement::SVGPathElement):
2124         (WebCore::SVGPathElement::getTotalLength):
2125         (WebCore::SVGPathElement::getPointAtLength):
2126         (WebCore::SVGPathElement::getPathSegAtLength):
2127         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
2128         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
2129         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
2130         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
2131         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
2132         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
2133         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
2134         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
2135         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
2136         (WebCore::SVGPathElement::createSVGPathSegArcRel):
2137         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
2138         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
2139         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
2140         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
2141         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
2142         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
2143         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
2144         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
2145         (WebCore::SVGPathElement::svgMoveTo):
2146         (WebCore::SVGPathElement::svgLineTo):
2147         (WebCore::SVGPathElement::svgLineToHorizontal):
2148         (WebCore::SVGPathElement::svgLineToVertical):
2149         (WebCore::SVGPathElement::svgCurveToCubic):
2150         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
2151         (WebCore::SVGPathElement::svgCurveToQuadratic):
2152         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
2153         (WebCore::SVGPathElement::svgArcTo):
2154         (WebCore::SVGPathElement::parseMappedAttribute):
2155         * ksvg2/svg/SVGPathElement.h:
2156         * ksvg2/svg/SVGPathSegArc.cpp:
2157         (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
2158         (WebCore::SVGPathSegArcAbs::setX):
2159         (WebCore::SVGPathSegArcAbs::x):
2160         (WebCore::SVGPathSegArcAbs::setY):
2161         (WebCore::SVGPathSegArcAbs::y):
2162         (WebCore::SVGPathSegArcAbs::setR1):
2163         (WebCore::SVGPathSegArcAbs::r1):
2164         (WebCore::SVGPathSegArcAbs::setR2):
2165         (WebCore::SVGPathSegArcAbs::r2):
2166         (WebCore::SVGPathSegArcAbs::setAngle):
2167         (WebCore::SVGPathSegArcAbs::angle):
2168         (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
2169         (WebCore::SVGPathSegArcRel::setX):
2170         (WebCore::SVGPathSegArcRel::x):
2171         (WebCore::SVGPathSegArcRel::setY):
2172         (WebCore::SVGPathSegArcRel::y):
2173         (WebCore::SVGPathSegArcRel::setR1):
2174         (WebCore::SVGPathSegArcRel::r1):
2175         (WebCore::SVGPathSegArcRel::setR2):
2176         (WebCore::SVGPathSegArcRel::r2):
2177         (WebCore::SVGPathSegArcRel::setAngle):
2178         (WebCore::SVGPathSegArcRel::angle):
2179         * ksvg2/svg/SVGPathSegArc.h:
2180         * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
2181         (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
2182         (WebCore::SVGPathSegCurvetoCubicAbs::setX):
2183         (WebCore::SVGPathSegCurvetoCubicAbs::x):
2184         (WebCore::SVGPathSegCurvetoCubicAbs::setY):
2185         (WebCore::SVGPathSegCurvetoCubicAbs::y):
2186         (WebCore::SVGPathSegCurvetoCubicAbs::setX1):
2187         (WebCore::SVGPathSegCurvetoCubicAbs::x1):
2188         (WebCore::SVGPathSegCurvetoCubicAbs::setY1):
2189         (WebCore::SVGPathSegCurvetoCubicAbs::y1):
2190         (WebCore::SVGPathSegCurvetoCubicAbs::setX2):
2191         (WebCore::SVGPathSegCurvetoCubicAbs::x2):
2192         (WebCore::SVGPathSegCurvetoCubicAbs::setY2):
2193         (WebCore::SVGPathSegCurvetoCubicAbs::y2):
2194         (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
2195         (WebCore::SVGPathSegCurvetoCubicRel::setX):
2196         (WebCore::SVGPathSegCurvetoCubicRel::x):
2197         (WebCore::SVGPathSegCurvetoCubicRel::setY):
2198         (WebCore::SVGPathSegCurvetoCubicRel::y):
2199         (WebCore::SVGPathSegCurvetoCubicRel::setX1):
2200         (WebCore::SVGPathSegCurvetoCubicRel::x1):
2201         (WebCore::SVGPathSegCurvetoCubicRel::setY1):
2202         (WebCore::SVGPathSegCurvetoCubicRel::y1):
2203         (WebCore::SVGPathSegCurvetoCubicRel::setX2):
2204         (WebCore::SVGPathSegCurvetoCubicRel::x2):
2205         (WebCore::SVGPathSegCurvetoCubicRel::setY2):
2206         (WebCore::SVGPathSegCurvetoCubicRel::y2):
2207         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
2208         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
2209         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
2210         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX):
2211         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x):
2212         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY):
2213         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y):
2214         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX2):
2215         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x2):
2216         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY2):
2217         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y2):
2218         (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
2219         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX):
2220         (WebCore::SVGPathSegCurvetoCubicSmoothRel::x):
2221         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY):
2222         (WebCore::SVGPathSegCurvetoCubicSmoothRel::y):
2223         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX2):
2224         (WebCore::SVGPathSegCurvetoCubicSmoothRel::x2):
2225         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY2):
2226         (WebCore::SVGPathSegCurvetoCubicSmoothRel::y2):
2227         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
2228         * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
2229         (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
2230         (WebCore::SVGPathSegCurvetoQuadraticAbs::setX):
2231         (WebCore::SVGPathSegCurvetoQuadraticAbs::x):
2232         (WebCore::SVGPathSegCurvetoQuadraticAbs::setY):
2233         (WebCore::SVGPathSegCurvetoQuadraticAbs::y):
2234         (WebCore::SVGPathSegCurvetoQuadraticAbs::setX1):
2235         (WebCore::SVGPathSegCurvetoQuadraticAbs::x1):
2236         (WebCore::SVGPathSegCurvetoQuadraticAbs::setY1):
2237         (WebCore::SVGPathSegCurvetoQuadraticAbs::y1):
2238         (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
2239         (WebCore::SVGPathSegCurvetoQuadraticRel::setX):
2240         (WebCore::SVGPathSegCurvetoQuadraticRel::x):
2241         (WebCore::SVGPathSegCurvetoQuadraticRel::setY):
2242         (WebCore::SVGPathSegCurvetoQuadraticRel::y):
2243         (WebCore::SVGPathSegCurvetoQuadraticRel::setX1):
2244         (WebCore::SVGPathSegCurvetoQuadraticRel::x1):
2245         (WebCore::SVGPathSegCurvetoQuadraticRel::setY1):
2246         (WebCore::SVGPathSegCurvetoQuadraticRel::y1):
2247         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
2248         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
2249         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
2250         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
2251         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setX):
2252         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::x):
2253         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setY):
2254         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::y):
2255         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
2256         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setX):
2257         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::x):
2258         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setY):
2259         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::y):
2260         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
2261         * ksvg2/svg/SVGPathSegLineto.cpp:
2262         (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
2263         (WebCore::SVGPathSegLinetoAbs::setX):
2264         (WebCore::SVGPathSegLinetoAbs::x):
2265         (WebCore::SVGPathSegLinetoAbs::setY):
2266         (WebCore::SVGPathSegLinetoAbs::y):
2267         (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
2268         (WebCore::SVGPathSegLinetoRel::setX):
2269         (WebCore::SVGPathSegLinetoRel::x):
2270         (WebCore::SVGPathSegLinetoRel::setY):
2271         (WebCore::SVGPathSegLinetoRel::y):
2272         * ksvg2/svg/SVGPathSegLineto.h:
2273         * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
2274         (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
2275         (WebCore::SVGPathSegLinetoHorizontalAbs::setX):
2276         (WebCore::SVGPathSegLinetoHorizontalAbs::x):
2277         (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
2278         (WebCore::SVGPathSegLinetoHorizontalRel::setX):
2279         (WebCore::SVGPathSegLinetoHorizontalRel::x):
2280         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
2281         * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
2282         (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
2283         (WebCore::SVGPathSegLinetoVerticalAbs::setY):
2284         (WebCore::SVGPathSegLinetoVerticalAbs::y):
2285         (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
2286         (WebCore::SVGPathSegLinetoVerticalRel::setY):
2287         (WebCore::SVGPathSegLinetoVerticalRel::y):
2288         * ksvg2/svg/SVGPathSegLinetoVertical.h:
2289         * ksvg2/svg/SVGPathSegList.cpp:
2290         (WebCore::SVGPathSegList::getPathSegAtLength):
2291         * ksvg2/svg/SVGPathSegList.h:
2292         * ksvg2/svg/SVGPathSegMoveto.cpp:
2293         (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
2294         (WebCore::SVGPathSegMovetoAbs::setX):
2295         (WebCore::SVGPathSegMovetoAbs::x):
2296         (WebCore::SVGPathSegMovetoAbs::setY):
2297         (WebCore::SVGPathSegMovetoAbs::y):
2298         (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
2299         (WebCore::SVGPathSegMovetoRel::setX):
2300         (WebCore::SVGPathSegMovetoRel::x):
2301         (WebCore::SVGPathSegMovetoRel::setY):
2302         (WebCore::SVGPathSegMovetoRel::y):
2303         * ksvg2/svg/SVGPathSegMoveto.h:
2304         * ksvg2/svg/SVGPolyElement.cpp:
2305         (WebCore::SVGPolyElement::svgPolyTo):
2306         * ksvg2/svg/SVGRadialGradientElement.cpp:
2307         (WebCore::SVGRadialGradientElement::buildGradient):
2308         * ksvg2/svg/SVGSVGElement.cpp:
2309         (WebCore::SVGSVGElement::viewport):
2310         (WebCore::SVGSVGElement::getCurrentTime):
2311         * ksvg2/svg/SVGStopElement.cpp:
2312         (WebCore::SVGStopElement::SVGStopElement):
2313         (WebCore::SVGStopElement::parseMappedAttribute):
2314         * ksvg2/svg/SVGStopElement.h:
2315         * ksvg2/svg/SVGTransform.cpp:
2316         (SVGTransform::translate):
2317         (SVGTransform::scale):
2318         * ksvg2/svg/SVGTransformDistance.cpp:
2319         (WebCore::SVGTransformDistance::addToSVGTransform):
2320         (WebCore::SVGTransformDistance::distance):
2321         * ksvg2/svg/SVGTransformable.cpp:
2322         (WebCore::SVGTransformable::parseTransformAttribute):
2323
2324 2007-07-03  Anders Carlsson  <andersca@apple.com>
2325
2326         Reviewed by Darin.
2327
2328         <rdar://problem/5289718>
2329         http://bugs.webkit.org/show_bug.cgi?id=14437
2330         CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)
2331         
2332         Based on a patch from Maxime Britto.
2333         
2334         * page/mac/WebCoreFrameBridge.mm:
2335         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2336         If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys
2337         its frame.
2338
2339         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2340         ASSERT that this is only called on the main frame.
2341
2342 2007-07-03  John Sullivan  <sullivan@apple.com>
2343
2344         Written by Darin, reviewed by me
2345         
2346         - fixed <rdar://problem/5249730> REGRESSION (Leopard, around 9A464): Safari opens the same local 
2347           documents more than once due to canonicalization change
2348
2349         * loader/mac/LoaderNSURLExtras.m:
2350         (canonicalURL):
2351         pass URL through KURL so we get KURL's version of canonicalization as well as
2352         NSURLProtocol's version of canonicalization
2353
2354 2007-07-03  Sam Weinig  <sam@webkit.org>
2355
2356         Reviewed by Darin.
2357
2358         Seventh round of fixes for implicit 64-32 bit conversion errors.
2359         <rdar://problem/5292262>
2360
2361         - Adds more narrowPrecision functions to FloatPoint, FloatSize and FloatRect.
2362         - Changes over more implicit conversions to use new functions.
2363
2364         * bindings/js/kjs_window.cpp:
2365         (KJS::WindowFunc::callAsFunction):
2366         * platform/graphics/FloatPoint.cpp:
2367         (WebCore::FloatPoint::matrixTransform):
2368         (WebCore::FloatPoint::narrowPrecision):
2369         * platform/graphics/FloatPoint.h:
2370         * platform/graphics/FloatRect.cpp:
2371         (WebCore::FloatRect::narrowPrecision):
2372         * platform/graphics/FloatRect.h:
2373         * platform/graphics/FloatSize.cpp:
2374         (WebCore::FloatSize::narrowPrecision):
2375         * platform/graphics/FloatSize.h:
2376         * platform/graphics/Path.cpp:
2377         (WebCore::Path::createRoundedRectangle):
2378         (WebCore::Path::createRectangle):
2379         (WebCore::Path::createEllipse):
2380         * platform/graphics/mac/ColorMac.mm:
2381         (WebCore::nsColor):
2382         * platform/graphics/mac/IconMac.mm:
2383         (WebCore::Icon::paint):
2384         * platform/graphics/svg/cg/CgSupport.cpp:
2385         (WebCore::applyStrokeStyleToContext):
2386         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
2387         (WebCore::CGShadingRefForRadialGradient):
2388         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
2389         (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
2390         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
2391         (WebCore::applyLuminanceToAlphaFilter):
2392         (WebCore::applyExpandAlphatoGrayscaleFilter):
2393         (WebCore::transformImageIntoGrayscaleMask):
2394         * platform/mac/WebCoreTextRenderer.mm:
2395         (WebCoreDrawTextAtPoint):
2396         * rendering/RenderPath.cpp:
2397         (WebCore::RenderPath::mapAbsolutePointToLocal):
2398         * rendering/RenderSVGContainer.cpp:
2399         (WebCore::RenderSVGContainer::calcViewport):
2400         * rendering/RenderSVGImage.cpp:
2401         (WebCore::RenderSVGImage::nodeAtPoint):
2402         * rendering/RenderSVGText.cpp:
2403         (WebCore::RenderSVGText::relativeBBox):
2404
2405 2007-07-03  Anders Carlsson  <andersca@apple.com>
2406
2407         Reviewed by Adam.
2408
2409         <rdar://problem/5261523>
2410         Crash playing MP11 on cnbc.com
2411         
2412         The WMP Netscape plugin still creates a window even when windowless mode is turned on. Work around this by
2413         always removing the "windowlessvideo" parameter before passing it to the plugin.
2414         According to http://msdn2.microsoft.com/en-us/library/bb249373.aspx, "The windowlessVideo property is not 
2415         supported for Netscape Navigator. Setting a value for this property in Navigator may yield unexpected results."
2416         
2417         * plugins/win/PluginViewWin.cpp:
2418         (WebCore::PluginViewWndProc):
2419         (WebCore::PluginViewWin::paint):
2420         (WebCore::PluginViewWin::invalidateRect):
2421         (WebCore::PluginViewWin::determineQuirks):
2422         (WebCore::PluginViewWin::setParameters):
2423         (WebCore::PluginViewWin::PluginViewWin):
2424         (WebCore::PluginViewWin::init):
2425         * plugins/win/PluginViewWin.h:
2426         (WebCore::):
2427
2428 2007-07-03  Qing Zhao  <qing@staikos.net>
2429
2430         Reviewed by George Staikos.
2431
2432         Only draw sunken state for appropriate widgets. Not, for example, for
2433         lineedits.
2434
2435         * platform/qt/RenderThemeQt.cpp:
2436         (WebCore::RenderThemeQt::applyTheme):
2437
2438 2007-07-03  Antti Koivisto  <antti@apple.com>
2439
2440         Reviewed by Maciej.
2441         
2442         REGRESSION: misplaced selection ring remains after link is no longer focused.
2443         <rdar://problem/5205580>
2444         
2445         Fix placement of selection ring when part of the ring is in a different layer.
2446
2447         * rendering/RenderFlow.cpp:
2448         (WebCore::RenderFlow::addFocusRingRects): Get coordinates right when moving to a different layer.
2449         * rendering/RenderObject.cpp:
2450         (WebCore::RenderObject::setStyle): 
2451         Don't reset state variables when not necessary.  When repaint() was called at the end of setSyle() it would
2452         get repaint rects wrong in some cases.
2453
2454 2007-07-03  Antti Koivisto  <antti@apple.com>
2455
2456         Reviewed by Maciej.
2457
2458         Blind fix for CrashTracer: [USER] 25 crashes in Safari at com.apple.WebCore: WebCore::Frame::document const + 6
2459         <rdar://problem/5263939>
2460         
2461         No one has managed to reproduce this but it looks like null check is needed here. There are plausible ways
2462         m_frame could be null for a live FrameView object.
2463
2464         * page/FrameView.cpp:
2465         (WebCore::FrameView::needsLayout):
2466
2467 2007-07-02  Oliver Hunt  <oliver@apple.com>
2468
2469         Reviewed by Darin.
2470
2471         Fix for <rdar://problem/5098378> single-pixel image optimization needs to be rewritten to not depend on floating point bitmap
2472         Tested by fast/replaced/image-solid-color-with-alpha.html
2473
2474         Switch from float to byte based bitmap when pulling the color from 1x1 pixel images so
2475         that we can use the single pixel image optimisation in WebKit/win.
2476
2477         * platform/graphics/cg/ImageCG.cpp:
2478         (WebCore::BitmapImage::checkForSolidColor):
2479
2480 2007-07-02  Adam Roben  <aroben@apple.com>
2481
2482         Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
2483         http://bugs.webkit.org/show_bug.cgi?id=14498
2484
2485         There were two bugs:
2486         1) xPos/yPos were flipped
2487         2) + binds tighter than ?:, so the order of operations was incorrect
2488
2489         Reviewed by Darin.
2490
2491         Test: fast/inline-block/14498-positionForCoordinates.html
2492
2493         * rendering/RenderContainer.cpp:
2494         (WebCore::RenderContainer::positionForCoordinates):
2495
2496 2007-07-02  Darin Adler  <darin@apple.com>
2497
2498         Reviewed by Kevin Decker and Tim Hatcher.
2499
2500         - fix <rdar://problem/5307906> some classes need finalize methods because
2501           of non-trivial work done in dealloc methods
2502
2503         * bindings/objc/DOMRGBColor.mm:
2504         (+[DOMRGBColor initialize]): Added. Tells finalizer to run on main thread,
2505         which is needed because we are sharing a CFDictionary here with no locking.
2506
2507         * bridge/mac/WebCoreAXObject.mm:
2508         (+[WebCoreAXObject initialize]): Added. Tells finalizer to run on main thread.
2509         (-[WebCoreAXObject finalize]): Added. Calls detach.
2510
2511         * WebCore.xcodeproj/project.pbxproj: Let Xcode do what it wants to do.
2512
2513 2007-07-02  Sam Weinig  <sam@webkit.org>
2514
2515         Reviewed by Darin.
2516
2517         Sixth round of fixes for implicit 64-32 bit conversion errors.
2518         <rdar://problem/5292262>
2519
2520         Use new narrowPrecisionToFloat() and narrowPrecisionToCGFloat() where
2521         appropriate.
2522
2523         * html/CanvasRenderingContext2D.cpp:
2524         (WebCore::CanvasRenderingContext2D::setShadow):
2525         (WebCore::CanvasRenderingContext2D::applyShadow):
2526         * html/CanvasStyle.cpp:
2527         (WebCore::CanvasStyle::applyStrokeColor):
2528         (WebCore::CanvasStyle::applyFillColor):
2529         * ksvg2/svg/SVGAngle.cpp:
2530         * ksvg2/svg/SVGAnimationElement.cpp:
2531         (WebCore::SVGAnimationElement::parseKeyNumbers):
2532         (WebCore::parseKeySplines):
2533         (WebCore::SVGAnimationElement::handleTimerEvent):
2534         (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
2535         * ksvg2/svg/SVGPatternElement.cpp:
2536         (WebCore::SVGPatternElement::buildPattern):
2537         * ksvg2/svg/SVGRadialGradientElement.cpp:
2538         (WebCore::SVGRadialGradientElement::buildGradient):
2539         * platform/graphics/cg/AffineTransformCG.cpp:
2540         (WebCore::AffineTransform::AffineTransform):
2541         (WebCore::AffineTransform::setMatrix):
2542         (WebCore::AffineTransform::map):
2543         (WebCore::AffineTransform::setA):
2544         (WebCore::AffineTransform::setB):
2545         (WebCore::AffineTransform::setC):
2546         (WebCore::AffineTransform::setD):
2547         (WebCore::AffineTransform::setE):
2548         (WebCore::AffineTransform::setF):
2549         (WebCore::AffineTransform::scale):
2550         (WebCore::AffineTransform::rotate):
2551         (WebCore::AffineTransform::translate):
2552         (WebCore::AffineTransform::shear):
2553
2554 2007-07-02  John Sullivan  <sullivan@apple.com>
2555
2556         * page/mac/WebCoreFrameBridge.mm:
2557         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2558         added a comment
2559
2560 2007-07-02  Sam Weinig  <sam@webkit.org>
2561
2562         Rubberstamped by Darin.
2563
2564         Rename FloatConversionUtilities.h to FloatConversion.h.
2565         Fix Win32 build.
2566
2567         * WebCore.vcproj/WebCore.vcproj:
2568         * WebCore.xcodeproj/project.pbxproj:
2569         * platform/DeprecatedString.cpp:
2570         * platform/FloatConversion.h: Copied from platform/FloatConversionUtilities.h.
2571         * platform/FloatConversionUtilities.h: Removed.
2572         * platform/StringImpl.cpp:
2573
2574 2007-07-02  Sam Weinig  <sam@webkit.org>
2575
2576         Reviewed by Darin.
2577
2578         Fifth round of fixes for implicit 64-32 bit conversion errors.
2579         <rdar://problem/5292262>
2580
2581         Add toFloat() method to string classes and use it where appropriate.
2582
2583         * WebCore.xcodeproj/project.pbxproj:
2584         * css/cssparser.cpp:
2585         (WebCore::CSSParser::lex):
2586         * ksvg2/svg/SVGAngle.cpp:
2587         (WebCore::SVGAngle::setValueAsString):
2588         * platform/AtomicString.h:
2589         (WebCore::AtomicString::toFloat):
2590         * platform/DeprecatedString.cpp:
2591         (WebCore::DeprecatedString::toFloat):
2592         * platform/DeprecatedString.h:
2593         * platform/FloatConversionUtilities.h: Added.
2594         (WebCore::narrowPrecisionToFloat):
2595         (WebCore::narrowPrecisionToCGFloat):
2596         * platform/PlatformString.h:
2597         * platform/String.cpp:
2598         (WebCore::String::toFloat):
2599         * platform/StringImpl.cpp:
2600         (WebCore::StringImpl::toFloat):
2601         * platform/StringImpl.h:
2602
2603 2007-07-02  Sam Weinig  <sam@webkit.org>
2604
2605         Reviewed by Kevin McCullough.
2606
2607         Fourth round of fixes for implicit 64-32 bit conversion errors.
2608         <rdar://problem/5292262>
2609
2610         Use new piDouble and piFloat constants instead of M_PI.
2611
2612         * html/CanvasRenderingContext2D.cpp:
2613         (WebCore::CanvasRenderingContext2D::rotate):
2614         * ksvg2/svg/SVGParserUtilities.cpp:
2615         (WebCore::SVGPathParser::calculateArc):
2616         * platform/graphics/Path.cpp:
2617         (WebCore::pathLengthApplierFunction):
2618         (WebCore::Path::createEllipse):
2619         * platform/graphics/cg/GraphicsContextCG.cpp:
2620         (WebCore::GraphicsContext::drawEllipse):
2621         (WebCore::GraphicsContext::strokeArc):
2622         * platform/graphics/cg/PDFDocumentImage.cpp:
2623         (WebCore::PDFDocumentImage::setCurrentPage):
2624         * platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
2625         * rendering/RenderPath.cpp:
2626         (WebCore::drawMarkerWithData):
2627
2628 2007-07-01  Adam Roben  <aroben@apple.com>
2629
2630         Clarify/fix {Shadow,BorderImage}ParseContext's memory management
2631
2632         Prefast emitted warnings that drew my attention to
2633         {Shadow,BorderImage}ParseContext::failed().  It turned out that these
2634         methods were actually correct, but rather confusing. "failed" really
2635         meant "abort and clean up" rather than "did you fail?", which was
2636         unclear. However, once I figured that out, the "and clean up" part was
2637         still a bit confusing, because all failed() did was to set a flag that
2638         would later cause the ParseContext's members to be deleted in the
2639         destructor. To clear this up, I've gotten rid of the failed() method
2640         altogether. It always returned false, so I've replaced all calls to
2641         it with the value false.
2642
2643         I also noticed that the lifetime management of the ParseContexts'
2644         members was in all cases confusing, and in some cases wrong. The
2645         m_border{Top,Right,Bottom,Left} members of BorderImageParseContext
2646         were leaked whenever a border-image property was successfully parsed.
2647         I fixed that by holding these members in OwnPtrs. The
2648         CSSPrimitiveValue members of {Shadow,BorderImage}ParseContext, which
2649         inherit from Shared, were being explicitly deleted, which is not a
2650         safe way to manage the lifetime of objects that inherit from Shared.
2651         To fix this, I put those members inside RefPtrs. These two changes
2652         allowed me to remove the destructors entirely.
2653
2654         Reviewed by Darin.
2655
2656         All regression tests pass.
2657
2658         * css/cssparser.cpp:
2659         (WebCore::ShadowParseContext::commitValue): Use .release() to avoid
2660         ref-count churn.
2661         (WebCore::ShadowParseContext::commitLength): Use a RefPtr for the new
2662         value to avoid a leak.
2663         (WebCore::CSSParser::parseShadow): Use 'false' instead of
2664         'context.failed()', and use .release() to avoid ref-count churn.
2665         (WebCore::BorderImageParseContext::commitWidth): Updated to use
2666         OwnPtr.
2667         (WebCore::CSSParser::parseBorderImage): Use 'false' instead of
2668         'context.failed'.
2669
2670 2007-07-01  Anders Carlsson  <andersca@apple.com>
2671
2672         Reviewed by John Sullivan.
2673
2674         <rdar://problem/5297146>
2675         Crash in Mail at WebCore::Frame::setUserStyleSheetLocation (reproducible w/ particular message)
2676         
2677         * loader/Cache.cpp:
2678         (WebCore::Cache::requestResource):
2679         Only insert the resource in the LRU list if the cache is enabled.
2680         
2681         (WebCore::Cache::insertInLRUList):
2682         (WebCore::Cache::resourceAccessed):
2683         Assert that the resource is in the cache.
2684
2685 2007-07-01  Darin Adler  <darin@apple.com>
2686
2687         * css/tokenizer.flex: Rolled out the fix for 14453.
2688         The layout test wasn't passing. We'll try again.
2689
2690 2007-07-01  Adam Roben  <aroben@apple.com>
2691
2692         Fix a crash in ~PluginViewWin()
2693
2694         This crash was introduced in r23827.
2695
2696         Reviewed by Anders.
2697
2698         Fixes dom/html/level2/html/HTMLAnchorElement01.html
2699
2700         * plugins/win/PluginViewWin.cpp:
2701         (WebCore::PluginViewWin::~PluginViewWin): Allow m_plugin to be null.
2702
2703 2007-07-01  Rob Buis  <buis@kde.org>
2704
2705         Reviewed by Darin.
2706
2707         http://bugs.webkit.org/show_bug.cgi?id=14453
2708         REGRESSION: www.nzherald.co.nz almost all the formating is gone
2709  
2710         * css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
2711
2712 2007-07-01  Sam Weinig  <sam@webkit.org>
2713
2714         Reviewed by Oliver.
2715
2716         Third round of implicit 64-32 bit conversion errors fixes.
2717         <rdar://problem/5292262>
2718
2719         - Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()
2720           methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
2721
2722         * css/CSSPrimitiveValue.cpp:
2723         (WebCore::CSSPrimitiveValue::computeLengthInt):
2724         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
2725         (WebCore::CSSPrimitiveValue::computeLengthShort):
2726         (WebCore::CSSPrimitiveValue::computeLengthFloat):
2727         (WebCore::CSSPrimitiveValue::computeLengthDouble):
2728         (WebCore::CSSPrimitiveValue::getDoubleValue):
2729         * css/CSSPrimitiveValue.h:
2730         (WebCore::CSSPrimitiveValue::getDoubleValue):
2731         (WebCore::CSSPrimitiveValue::getFloatValue):
2732         (WebCore::CSSPrimitiveValue::getIntValue):
2733         * css/Counter.h:
2734         (WebCore::Counter::listStyleNumber):
2735         * css/MediaQueryEvaluator.cpp:
2736         (WebCore::parseAspectRatio):
2737         * css/cssparser.cpp:
2738         (WebCore::BorderImageParseContext::commitBorderImage):
2739         * css/cssstyleselector.cpp:
2740         (WebCore::convertToLength):
2741         (WebCore::applyCounterList):
2742         (WebCore::CSSStyleSelector::applyProperty):
2743         (WebCore::CSSStyleSelector::mapBackgroundSize):
2744         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
2745         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
2746         * html/HTMLTableElement.cpp:
2747         (WebCore::HTMLTableElement::parseMappedAttribute):
2748         * ksvg2/css/SVGCSSStyleSelector.cpp:
2749         (WebCore::CSSStyleSelector::applySVGProperty):
2750         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2751         (WebCore::KSVGPainterFactory::cssPrimitiveToLength):
2752         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
2753
2754 2007-07-01  Pamela Greene  <pamg.bugs@gmail.com>
2755
2756         Reviewed by Darin.
2757
2758         Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
2759         Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
2760         <rdar://problem/5290084>
2761
2762         Use std::stable_sort() instead of qsort() to sort gradient stops.
2763         Adjust the comparison function accordingly.
2764
2765         * html/CanvasGradient.cpp:
2766         (WebCore::compareStops):
2767         (WebCore::CanvasGradient::findStop):
2768
2769 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
2770
2771         Reviewed by Darin.
2772
2773         m_usesPageCache was not initialized. As the b/f cache is only
2774         implemented in the Mac port and WebView.mm is taking care of calling
2775         Settings::setUsesPageCache I decided to make it false by default.
2776
2777         * page/Settings.cpp:
2778         (WebCore::Settings::Settings): m_usesPageCache was not initialized
2779
2780 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
2781
2782         Reviewed by Darin.
2783
2784         Inherited- and NonInheritedFlags is a bit field. But for comparsion
2785         the other part of the union _iflags/_niflags is used for comparions.
2786         This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
2787         Make sure the unused bits have a specified value.
2788
2789         * ksvg2/css/SVGRenderStyle.h:
2790         (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits
2791         have a value as well.
2792
2793 2007-06-30  Adam Roben  <aroben@apple.com>
2794
2795         Compile WebCore with /W4 on Windows
2796
2797         Some more warnings were disabled globally, including assignment within
2798         a conditional, unused variable, and various warnings related to
2799         inability to instantiate opaque structs.
2800
2801         In addition, the "unreachable code" warning was turned off for
2802         CSSGrammar.cpp and XPathGrammar.cpp.
2803
2804         Reviewed by Oliver.
2805
2806         * WebCore.vcproj/WebCore.vcproj:
2807
2808 2007-06-29  Adam Roben  <aroben@apple.com>
2809
2810         Give CString an equality operator to fix a bug in HTMLFormElement::formData
2811
2812         The bug was spotted by MSVC /W4. The problem was that we were comparing
2813         a CString to a char* using ==, but CString had no equality operator.
2814         The result was that the CString was being cast to a const char* and a
2815         pointer comparison was being done, which would (essentially) always
2816         return false.
2817
2818         There are two parts to the fix: get rid of CString's const char*
2819         casting operator, and add an equality operator. Previous uses of the
2820         casting operator have been changed to use CString::data().
2821
2822         Test: http/misc/isindex-formdata.html
2823
2824         Reviewed by Oliver.
2825
2826         * dom/XMLTokenizer.cpp:
2827         (WebCore::parseXMLDocumentFragment):
2828         * html/HTMLDocument.cpp:
2829         (WebCore::HTMLDocument::determineParseMode):
2830         * html/HTMLFormElement.cpp:
2831         (WebCore::HTMLFormElement::formData):
2832         * loader/TextResourceDecoder.cpp:
2833         (WebCore::TextResourceDecoder::checkForCSSCharset):
2834         * platform/CString.cpp:
2835         (WebCore::operator==):
2836         * platform/CString.h:
2837         * platform/KURL.cpp:
2838         (WebCore::encodeRelativeString):
2839         * platform/StringImpl.cpp:
2840         (WebCore::StringImpl::toDouble):
2841         * platform/network/cf/FormDataStreamCFNet.cpp:
2842         (WebCore::setHTTPBody):
2843         * platform/network/mac/FormDataStreamMac.mm:
2844         (WebCore::setHTTPBody):
2845         * platform/win/ClipboardUtilitiesWin.cpp:
2846         (WebCore::markupToCF_HTML):
2847         * plugins/win/PluginPackageWin.cpp:
2848         (WebCore::splitString):
2849         * plugins/win/PluginStreamWin.cpp:
2850         (WebCore::PluginStreamWin::startStream):
2851         (WebCore::PluginStreamWin::destroyStream):
2852         (WebCore::PluginStreamWin::sendJavaScriptStream):
2853         (WebCore::PluginStreamWin::didFinishLoading):
2854         * plugins/win/PluginViewWin.cpp:
2855         (WebCore::PluginViewWin::start):
2856         (WebCore::createUTF8String):
2857         (WebCore::PluginViewWin::userAgent):
2858         * xml/XSLStyleSheet.cpp:
2859         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
2860         * xml/XSLTProcessor.cpp:
2861         (WebCore::xsltParamArrayFromParameterMap):
2862
2863 2007-06-29  Adam Roben  <aroben@apple.com>
2864
2865         Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
2866
2867         Reviewed by John.
2868
2869         * editing/Editor.cpp:
2870         (WebCore::Editor::advanceToNextMisspelling):
2871         * html/HTMLParser.cpp:
2872
2873 2007-06-29  Adam Roben  <aroben@apple.com>
2874
2875         Fix some possibly unitialized variables found by MSVC /W4
2876
2877         Reviewed by John.
2878
2879         * rendering/bidi.cpp:
2880         (WebCore::RenderBlock::layoutInlineChildren):
2881
2882 2007-06-29  Adam Roben  <aroben@apple.com>
2883
2884         Remove bogus cast found by MSVC /W4
2885
2886         Reviewed by John and Oliver.
2887
2888         * ksvg2/css/SVGCSSParser.cpp:
2889         (WebCore::CSSParser::parseSVGValue):
2890
2891 2007-06-29  Adam Roben  <aroben@apple.com>
2892
2893         Remove unused local functions uncovered by MSVC /W4
2894
2895         Reviewed by John and Oliver.
2896
2897         * platform/win/SearchPopupMenuWin.cpp:
2898         * rendering/RenderText.cpp:
2899
2900 2007-06-29  Adam Roben  <aroben@apple.com>
2901
2902         Don't take the address of temporary values to appease MSVC /W4
2903
2904         Reviewed by Oliver.
2905
2906         No regression test possible.
2907
2908         * platform/win/PopupMenuWin.cpp:
2909         (WebCore::PopupMenu::invalidateItem):
2910         (WebCore::PopupMenu::valueChanged):
2911         (WebCore::PopupWndProc):
2912         * platform/win/ScrollViewWin.cpp:
2913         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
2914         * platform/win/UniscribeController.cpp:
2915         (WebCore::UniscribeController::shapeAndPlaceItem):
2916         * platform/win/WidgetWin.cpp:
2917         (WebCore::Widget::invalidateRect):
2918
2919 2007-06-29  Adam Roben  <aroben@apple.com>
2920
2921         Make an int -> UINT conversion explicit that MSVC /W4 complains about
2922
2923         Reviewed by John and Oliver.
2924
2925         No regression test possible.
2926
2927         * platform/win/SoundWin.cpp:
2928
2929 2007-06-29  Adam Roben  <aroben@apple.com>
2930
2931         Remove unreachable code uncovered by MSVC /W4
2932
2933         Reviewed by Oliver.
2934
2935         No regression test possible.
2936
2937         * html/CanvasRenderingContext2D.cpp:
2938         (WebCore::CanvasRenderingContext2D::createPattern):
2939         * html/HTMLAnchorElement.cpp:
2940         (WebCore::HTMLAnchorElement::isLiveLink):
2941         * html/HTMLElement.cpp:
2942         (WebCore::HTMLElement::contentEditable):
2943         * platform/DeprecatedString.cpp:
2944         (WebCore::allocateHandle):
2945         (WebCore::freeHandle):
2946         * plugins/win/npapi.cpp:
2947         (pluginViewForInstance):
2948         * rendering/RenderImage.cpp:
2949         (WebCore::RenderImage::isWidthSpecified):
2950         (WebCore::RenderImage::isHeightSpecified):
2951         * rendering/RenderTheme.cpp:
2952         (WebCore::RenderTheme::isControlStyled):
2953
2954 2007-06-29  John Sullivan  <sullivan@apple.com>
2955
2956         Reviewed by Oliver Hunt.
2957         
2958         - WebCore support for accessing the set of rectangles that encompass the selected text
2959         
2960         * page/Frame.h:
2961         * page/Frame.cpp:
2962         (WebCore::Frame::selectionTextRects):
2963         new function, fills in a passed Vector with the line box rects that represent the selected range
2964
2965         * rendering/RenderText.cpp:
2966         (WebCore::RenderText::addLineBoxRects):
2967         fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
2968
2969         * WebCore.exp:
2970         exported symbol for this new function
2971
2972 2007-06-29  Justin Garcia  <justin.garcia@apple.com>
2973
2974         Reviewed by Harrison.
2975         
2976         <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
2977         
2978         Rolled out a change made in r23787.
2979         
2980         * editing/DeleteSelectionCommand.cpp:
2981         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2982
2983 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
2984
2985         Reviewed by Darin Adler, Anders Carlsson.
2986         
2987         Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML 
2988         returns NULL if response MIME type is not XML -- breaks Wikipedia widget
2989         
2990         The spec says that responseXML must return null for any HTTP response
2991         with a non-XML MIME type. Technically, that leaves non-HTTP responses
2992         free to do whatever they want.
2993
2994         * xml/xmlhttprequest.cpp:
2995         (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
2996         MIME types if the response was HTTP.
2997
2998 2007-06-29  Sam Weinig  <sam@webkit.org>
2999
3000         Reviewed by Darin.
3001
3002         Second pass at fixing implicit 64-32 bit conversion errors.
3003         <rdar://problem/5292262>
3004
3005         - Use new JSValue::toFloat() method instead of toNumber() where
3006           appropriate.
3007
3008         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3009         (WebCore::JSCanvasRenderingContext2D::setFillColor):
3010         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
3011         (WebCore::JSCanvasRenderingContext2D::strokeRect):
3012         (WebCore::JSCanvasRenderingContext2D::drawImage):
3013         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
3014         (WebCore::JSCanvasRenderingContext2D::setShadow):
3015         * bindings/js/JSHTMLSelectElementCustom.cpp:
3016         (WebCore::JSHTMLSelectElement::remove):
3017         * bindings/js/JSSVGMatrixCustom.cpp:
3018         (WebCore::JSSVGMatrix::rotateFromVector):
3019         * bindings/js/kjs_events.cpp:
3020         (KJS::JSClipboardPrototypeFunction::callAsFunction):
3021         * bindings/scripts/CodeGeneratorJS.pm:
3022         * ksvg2/svg/SVGScriptElement.cpp:
3023         (WebCore::SVGScriptElement::executeScript):
3024
3025 2007-06-29  Adele Peterson  <adele@apple.com>
3026
3027         Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
3028
3029         * html/HTMLInputElement.h:
3030         * html/HTMLTextAreaElement.h:
3031
3032 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
3033
3034         Reviewed by Oliver Hunt.
3035
3036         Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing 
3037         local file throws exception -- breaks Wikipedia widget
3038
3039         * WebCore.xcodeproj/project.pbxproj:
3040         * xml/xmlhttprequest.cpp:
3041         (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
3042
3043 2007-06-29  Ada Chan  <adachan@apple.com>
3044
3045         Reviewed by Adam.
3046
3047         Fixed a previous fix to a signed/unsigned mismatch.
3048
3049         * plugins/win/PluginPackageWin.cpp:
3050         (WebCore::splitString):
3051
3052 2007-06-29  Adele Peterson  <adele@apple.com>
3053
3054         Reviewed by Ada and Kevin McCullough.
3055
3056         Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
3057
3058         Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
3059
3060         Tests:
3061         fast/forms/input-readonly-select-all.html
3062         fast/forms/textarea-readonly-select-all.html
3063
3064         * html/HTMLInputElement.h:
3065         (WebCore::HTMLInputElement::canSelectAll):
3066         (WebCore::HTMLInputElement::selectAll):
3067         * html/HTMLTextAreaElement.h:
3068         (WebCore::HTMLTextAreaElement::canSelectAll):
3069         (WebCore::HTMLTextAreaElement::selectAll):
3070
3071 2007-06-29  Adam Roben  <aroben@apple.com>
3072
3073         Build fix
3074
3075         This is what happens when you test your patch on two OSs and then
3076         commit from the wrong one.
3077
3078         * rendering/RenderTextControl.cpp:
3079         (WebCore::RenderTextControl::valueChanged):
3080         (WebCore::RenderTextControl::itemText):
3081         (WebCore::RenderTextControl::itemIsSeparator):
3082
3083 2007-06-29  Adam Roben  <aroben@apple.com>
3084
3085         Start compiling WebCore with /W3 under MSVC
3086
3087         One warning was globally disabled: implicit conversion of int to bool.
3088
3089         Reviewed by Darin.
3090
3091         * WebCore.vcproj/WebCore.vcproj:
3092
3093 2007-06-29  Adam Roben  <aroben@apple.com>
3094
3095         Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
3096
3097         DeprecatedStringData now has no public copy constructor. The single
3098         call to the old one has been replaced with a call to the new
3099         DeprecatedStringData::createAndAdopt static method.
3100
3101         Reviewed by Darin.
3102
3103         All regression tests pass.
3104
3105         * platform/DeprecatedString.cpp:
3106         (WebCore::DeprecatedStringData::createAndAdopt):
3107         (WebCore::DeprecatedStringData::adopt):
3108         (WebCore::DeprecatedString::detachIfInternal):
3109         * platform/DeprecatedString.h:
3110
3111 2007-06-29  Adam Roben  <aroben@apple.com>
3112
3113         Fix more signed/unsigned mismatches uncovered by MSVC /W3
3114
3115         Reviewed by John.
3116
3117         No regression tests possible.
3118
3119         * platform/network/cf/ResourceResponseCFNet.cpp:
3120         (WebCore::filenameHasSaneExtension):
3121         * platform/win/FontDataWin.cpp:
3122         (WebCore::FontData::containsCharacters):
3123         * platform/win/PlatformScrollBarSafari.cpp:
3124         (WebCore::):
3125         * platform/win/UniscribeController.cpp:
3126         (WebCore::UniscribeController::advance):
3127         (WebCore::UniscribeController::shapeAndPlaceItem):
3128         * platform/win/WebCoreTextRenderer.cpp:
3129         (WebCore::doDrawTextAtPoint):
3130         * plugins/win/PluginDatabaseWin.cpp:
3131         (WebCore::parseVersionString):
3132         * plugins/win/PluginPackageWin.cpp:
3133         (WebCore::splitString):
3134         * plugins/win/PluginViewWin.cpp:
3135         (WebCore::freeStringArray):
3136         (WebCore::PluginViewWin::invalidateTimerFired):
3137
3138 2007-06-29  Adam Roben  <aroben@apple.com>
3139
3140         Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
3141
3142         Reviewed by John.
3143
3144         No regression test possible.
3145
3146         * html/HTMLSelectElement.cpp:
3147         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
3148         * platform/PopupMenuClient.h:
3149         * platform/win/PopupMenuWin.cpp:
3150         (WebCore::PopupMenu::calculatePositionAndSize):
3151         (WebCore::PopupMenu::focusFirst):
3152         (WebCore::PopupMenu::focusLast):
3153         (WebCore::PopupMenu::down):
3154         (WebCore::PopupMenu::up):
3155         (WebCore::PopupMenu::paint):
3156         * rendering/RenderMenuList.cpp:
3157         * rendering/RenderMenuList.h:
3158         * rendering/RenderTextControl.cpp:
3159         * rendering/RenderTextControl.h:
3160
3161 2007-06-29  Adam Roben  <aroben@apple.com>
3162
3163         Fix two typos spotted by MSVC /W3
3164
3165         Both typos were a semicolon following the condition of an if. This
3166         would cause the intended body of the if to always execute.
3167
3168         Unfortunately neither of these fixes are testable.
3169         BackForwardList::goForward is only called from WebBackForwardList, and
3170         the createDragImageFromImage bug would only manifest itself when
3171         CreateCompatibleDC failed.
3172
3173         Reviewed by Mark.
3174
3175         * history/BackForwardList.cpp:
3176         (WebCore::BackForwardList::goForward):
3177         * platform/win/DragImageWin.cpp:
3178         (WebCore::createDragImageFromImage):
3179
3180 2007-06-29  Adam Treat  <adam@staikos.net>
3181
3182         Reviewed by george Staikos.
3183
3184         Support horizontal and vertical scroll, and set the right units.
3185
3186         * platform/qt/WheelEventQt.cpp:
3187         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3188
3189 2007-06-28  Adam Roben  <aroben@apple.com>
3190
3191         Get WebCore compiling with /W2 on Windows
3192
3193         Reviewed by Steve.
3194
3195         No regression tests affected.
3196
3197         * WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
3198         disable two warnings: implicit int <=> float conversion, and class vs.
3199         struct inconsistency.
3200         * dom/CharacterData.cpp:
3201         (WebCore::CharacterData::deleteData): Cast to int before negating.
3202         * loader/Cache.cpp:
3203         (WebCore::Cache::remove): Ditto.
3204         * platform/graphics/Path.cpp:
3205         (WebCore::pathLengthApplierFunction): Consistently use floats.
3206         * platform/graphics/cg/GraphicsContextCG.cpp:
3207         (WebCore::GraphicsContext::drawEllipse): Ditto.
3208         * platform/win/GraphicsContextWin.cpp:
3209         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
3210
3211 2007-06-28  Geoffrey Garen  <ggaren@apple.com>
3212
3213         Reviewed by Maciej Stachowiak.
3214         
3215         Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease 
3216         pool => pathologically high high water mark
3217         
3218         I couldn't measure any performance problems with iBench HTML or PLT.
3219
3220         * WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
3221         * platform/mac/SharedTimerMac.cpp:
3222         (WebCore::timerFired): Added autorelease pool.
3223
3224 2007-06-28  Mitz Pettel  <mitz@webkit.org>
3225
3226         Reviewed by Beth.
3227
3228         - fix http://bugs.webkit.org/show_bug.cgi?id=14118
3229           ASSERTION FAILED: !needsLayout() seen again
3230
3231         Test: fast/dynamic/recursive-layout.html
3232
3233         * page/FrameView.cpp:
3234         (WebCore::FrameView::layout): Removed the midLayout guards around
3235         the calls to invalidateSelection() and updateWidgetPositions(). Those
3236         calls may dirty the layout, but in that case they also update it, so
3237         they should be allowed to do it. Added an ASSERT to make sure that when
3238         they return, the root is not marked for layout.
3239
3240 2007-06-28  Sam Weinig  <sam@webkit.org>
3241
3242         Rubberstamped by Adam Roben.
3243
3244         Roll out r23861.  It caused the buildbot to fail on intel.
3245
3246         * page/Page.cpp:
3247         (WebCore::Page::goToItem):
3248
3249 2007-06-26  Maxime Britto  <mbritto@pleyo.com>
3250
3251         Reviewed by Geoff.
3252
3253         Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
3254         ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
3255
3256         Modification of an ASSERT on goToItem related to go back/forward in
3257         history.Don't need to check the frameset if the target is _blank.
3258
3259          * page/Page.cpp:
3260          (WebCore::Page::goToItem):
3261
3262 2007-06-28  Anders Carlsson  <andersca@apple.com>
3263
3264         Reviewed by Oliver.
3265
3266         <rdar://problem/5234139>
3267         <object> with PNG src rendered as image document.
3268         
3269         Complete the URL before passing it to the frame loader client.
3270         
3271         * html/HTMLObjectElement.cpp:
3272         (WebCore::HTMLObjectElement::isImageType):
3273
3274 2007-06-28  Rob Buis  <buis@kde.org>
3275
3276         Reviewed by Maciej.
3277
3278         http://bugs.webkit.org/show_bug.cgi?id=14373
3279         CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
3280
3281         Make sure the id selector validates against the CSS2.1 identfier
3282         definition, not the hexcolor/HASH definition.
3283
3284         * css/CSSGrammar.y:
3285         * css/cssparser.cpp:
3286         (WebCore::CSSParser::lex):
3287         (WebCore::CSSParser::text):
3288         * css/tokenizer.flex:
3289
3290 2007-06-28  Simon Hausmann  <hausmann@kde.org>
3291
3292         Reviewed by Zack.
3293
3294         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
3295
3296         * platform/qt/PasteboardQt.cpp:
3297         (WebCore::Pasteboard::writeSelection):
3298
3299 2007-06-28  Antti Koivisto  <antti@apple.com>
3300
3301         Reviewed by Mitz.
3302         
3303         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
3304         Bug 14332: REGRESSION (r21145): <td> width ignored
3305         <rdar://problem/5290123>
3306         
3307         Cells in table with non-zero cellpadding are not considered empty.
3308
3309         * rendering/AutoTableLayout.cpp:
3310         (WebCore::AutoTableLayout::recalcColumn):
3311
3312 2007-06-28  Adam Roben  <aroben@apple.com>
3313
3314         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
3315
3316         Reviewed by Hyatt.
3317
3318         No layout test possible, as this bug didn't have any effect since
3319         "bool & bool" has the same value as "bool && bool"
3320
3321         * rendering/RenderBlock.cpp:
3322         (WebCore::RenderBlock::paintObject): Changed & to &&.
3323
3324 2007-06-28  Adam Roben  <aroben@apple.com>
3325
3326         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
3327
3328         The bug was caused by two typos found by prefast.
3329
3330         Reviewed by Hyatt.
3331
3332         * css/cssparser.cpp:
3333         (WebCore::CSSParser::parseValue): Fixed typos.
3334
3335 2007-06-20  Matt Perry  <mpComplete@gmail.com>
3336
3337         Reviewed by Adam.
3338
3339         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
3340           onchange handler for select controls doesn't fire when changing via keyboard
3341
3342         * html/HTMLSelectElement.cpp:
3343         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
3344         a call to saveLastSelection in the "Enter" key handler for select
3345         controls that was preventing onchange from firing.
3346
3347 2007-06-27  Sam Weinig  <sam@webkit.org>
3348
3349         Fix Gdk, Qt, and Win32 builds.
3350
3351         * WebCore.pro:
3352         * WebCore.vcproj/WebCore.vcproj:
3353
3354 2007-06-27  Sam Weinig  <sam@webkit.org>
3355
3356         Reviewed by Geoff.
3357
3358         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
3359         Move the Selection object out of the JS bindings
3360
3361         - Renames JS Object Selection to DOMSelection to avoid a name
3362           conflict.
3363
3364         * DerivedSources.make:
3365         * WebCore.xcodeproj/project.pbxproj:
3366         * bindings/js/kjs_window.cpp:
3367         (KJS::WindowPrivate::WindowPrivate):
3368         (KJS::Window::mark):
3369         (KJS::Window::clearHelperObjectProperties):
3370         (KJS::WindowFunc::callAsFunction):
3371         (KJS::Window::disconnectFrame):
3372         * bindings/js/kjs_window.h:
3373         (KJS::Window::):
3374         * page/DOMSelection.cpp: Added.
3375         (WebCore::DOMSelection::DOMSelection):
3376         (WebCore::DOMSelection::frame):
3377         (WebCore::DOMSelection::disconnectFrame):
3378         (WebCore::DOMSelection::anchorNode):
3379         (WebCore::DOMSelection::baseNode):
3380         (WebCore::DOMSelection::anchorOffset):
3381         (WebCore::DOMSelection::baseOffset):
3382         (WebCore::DOMSelection::focusNode):
3383         (WebCore::DOMSelection::extentNode):
3384         (WebCore::DOMSelection::focusOffset):
3385         (WebCore::DOMSelection::extentOffset):
3386         (WebCore::DOMSelection::isCollapsed):
3387         (WebCore::DOMSelection::type):
3388         (WebCore::DOMSelection::rangeCount):
3389         (WebCore::DOMSelection::collapse):
3390         (WebCore::DOMSelection::collapseToEnd):
3391         (WebCore::DOMSelection::collapseToStart):
3392         (WebCore::DOMSelection::empty):
3393         (WebCore::DOMSelection::setBaseAndExtent):
3394         (WebCore::DOMSelection::setPosition):
3395         (WebCore::DOMSelection::modify):
3396         (WebCore::DOMSelection::getRangeAt):
3397         (WebCore::DOMSelection::removeAllRanges):
3398         (WebCore::DOMSelection::addRange):
3399         (WebCore::DOMSelection::toString):
3400         * page/DOMSelection.h: Added.
3401         * page/DOMSelection.idl: Added.
3402         * page/DOMWindow.cpp:
3403         (WebCore::DOMWindow::disconnectFrame):
3404         (WebCore::DOMWindow::getSelection):
3405         * page/DOMWindow.h:
3406         * page/DOMWindow.idl:
3407
3408 2007-06-27  Sam Weinig  <sam@webkit.org>
3409
3410         Reviewed by Maciej.
3411
3412         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
3413         Autogenerate Event JS binding
3414
3415         - Cleanup kjs_events
3416
3417         * bindings/js/kjs_events.cpp:
3418         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
3419         (WebCore::JSAbstractEventListener::handleEvent):
3420         (WebCore::JSAbstractEventListener::isHTMLEventListener):
3421         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
3422         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
3423         (WebCore::JSUnprotectedEventListener::listenerObj):
3424         (WebCore::JSUnprotectedEventListener::windowObj):
3425         (WebCore::JSUnprotectedEventListener::clearWindowObj):
3426         (WebCore::JSUnprotectedEventListener::mark):
3427         (WebCore::JSEventListener::JSEventListener):
3428         (WebCore::JSEventListener::~JSEventListener):
3429         (WebCore::JSEventListener::listenerObj):
3430         (WebCore::JSEventListener::windowObj):
3431         (WebCore::JSEventListener::clearWindowObj):
3432         (WebCore::JSLazyEventListener::JSLazyEventListener):
3433         (WebCore::JSLazyEventListener::listenerObj):
3434         (WebCore::JSLazyEventListener::parseCode):
3435         (WebCore::getNodeEventListener):
3436         (WebCore::JSClipboard::JSClipboard):
3437         (WebCore::JSClipboard::getValueProperty):
3438         (WebCore::JSClipboard::putValueProperty):
3439         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
3440         (WebCore::toJS):
3441         (WebCore::toClipboard):
3442         * bindings/js/kjs_events.h:
3443         (WebCore::JSClipboard::classInfo):
3444         (WebCore::JSClipboard::impl):
3445         * bindings/js/kjs_window.h:
3446         * ksvg2/events/JSSVGLazyEventListener.h:
3447
3448 2007-06-27  Sam Weinig  <sam@webkit.org>
3449
3450         Reviewed by Adam Roben.
3451
3452         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
3453         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
3454         <rdar://problem/5286670>
3455
3456         Test: fast/forms/thumbslider-no-parent-slider.html
3457         Test: fast/forms/thumbslider-crash.html
3458
3459         * rendering/RenderObject.h:
3460         (WebCore::RenderObject::isSlider):
3461         * rendering/RenderSlider.h:
3462         (WebCore::RenderSlider::isSlider):
3463         * rendering/RenderTheme.cpp:
3464         (WebCore::RenderTheme::paint): Only paint thumbslider
3465         if the parent renderer is a RenderSlider.
3466         * rendering/RenderThemeMac.mm:
3467         (WebCore::RenderThemeMac::paintSliderThumb):
3468         * rendering/RenderThemeSafari.cpp:
3469         (WebCore::RenderThemeSafari::paintSliderThumb):
3470
3471 2007-06-27  George Staikos  <staikos@kde.org>
3472
3473         Make Qt builds link when XSLT is turned off.
3474
3475         * WebCore.pro:
3476
3477 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
3478
3479         Turn on static code analysis (Windows only).
3480
3481         Affects only folks that have Visual Studio Team Suite installed,
3482         or who have replaced their compiler with the version shipping in the
3483         Vista SDK.
3484         
3485         Reviewed by Oliver.
3486
3487         * WebCore.vcproj/WebCore.vcproj:
3488
3489 2007-06-27  George Staikos  <staikos@kde.org>
3490
3491         Remove old commented out files that no-longer exist.
3492
3493         * WebCore.pro:
3494
3495 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
3496
3497         Reviewed by John.
3498
3499         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
3500         
3501         Pasting with a trailing interchange newline doesn't work when pasting
3502         into an empty line.  Code that handles removing brs at the insertion
3503         position tries to also handle trailing interchange newlines by re-using
3504         those brs and fails.  Removed that code and handle all interchange
3505         newlines with code later in doApply().
3506
3507         * editing/ReplaceSelectionCommand.cpp:
3508         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
3509         endBR when there's a trailing interchange newline.
3510         
3511 2007-06-27  Anders Carlsson  <andersca@apple.com>
3512
3513         Reviewed by Oliver.
3514
3515         <rdar://problem/5253950>
3516         When Shockwave plugin has been loaded, exiting crashes Safari
3517         
3518         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
3519         
3520         * plugins/win/PluginPackageWin.cpp:
3521         (WebCore::PluginPackageWin::PluginPackageWin):
3522         (WebCore::PluginPackageWin::load):
3523         (WebCore::PluginPackageWin::unload):
3524         (WebCore::PluginPackageWin::unloadWithoutShutdown):
3525         * plugins/win/PluginPackageWin.h:
3526         
3527         * plugins/win/PluginViewWin.cpp:
3528         (WebCore::PluginViewWin::~PluginViewWin):
3529         Make sure to unload the plugin package and clear any references to plugin script objects.
3530
3531 2007-06-27  George Staikos  <staikos@kde.org>
3532
3533         This was succeeding compile by luck.  Setup dependencies properly.
3534
3535         * WebCore.pro:
3536
3537 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
3538
3539         Reviewed by John.
3540
3541         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
3542         
3543         When a quoted numbered list is broken in half, it's cloned
3544         to make the second list. That second list needs its start attribute
3545         set so that the numbers of the list items in it will be preserved.
3546
3547         * editing/BreakBlockquoteCommand.cpp:
3548         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
3549         of a cloned list to be the original number of the first list item in it.
3550
3551 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
3552
3553         Reviewed by Geoff.
3554
3555         http://bugs.webkit.org/show_bug.cgi?id=14413
3556         GIF animation throttling is different from MSIE
3557
3558         * platform/graphics/cg/ImageSourceCG.cpp:
3559         (WebCore::ImageSource::frameDurationAtIndex):
3560         Change the cut-off value to 50ms to match MSIE.
3561
3562 2007-06-27  Sam Weinig  <sam@webkit.org>
3563
3564         Reviewed by Darin.
3565
3566         First pass at fixing implicit 64-32 bit conversion errors.
3567         <rdar://problem/5292262>
3568
3569         - Add 'f' suffix where necessary.
3570
3571         * bridge/mac/WebCoreAXObject.mm:
3572         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
3573         * css/csshelper.h:
3574         * css/cssstyleselector.cpp:
3575         (WebCore::):
3576         (WebCore::CSSStyleSelector::largerFontSize):
3577         (WebCore::CSSStyleSelector::smallerFontSize):
3578         * html/CanvasGradient.cpp:
3579         (WebCore::CanvasGradient::addColorStop):
3580         * html/CanvasPattern.cpp:
3581         (WebCore::CanvasPattern::createPattern):
3582         * ksvg2/css/SVGCSSStyleSelector.cpp:
3583         (WebCore::CSSStyleSelector::applySVGProperty):
3584         * ksvg2/css/SVGRenderStyle.h:
3585         * ksvg2/events/SVGZoomEvent.cpp:
3586         (WebCore::SVGZoomEvent::SVGZoomEvent):
3587         * ksvg2/svg/SVGLength.cpp:
3588         (WebCore::SVGLength::SVGLength):
3589         (WebCore::SVGLength::value):
3590         (WebCore::SVGLength::setValue):
3591         (WebCore::SVGLength::valueAsPercentage):
3592         (WebCore::SVGLength::PercentageOfViewport):
3593         * ksvg2/svg/SVGSVGElement.cpp:
3594         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
3595         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
3596         (WebCore::SVGSVGElement::getScreenCTM):
3597         * ksvg2/svg/SVGTextContentElement.cpp:
3598         (WebCore::SVGTextContentElement::getComputedTextLength):
3599         (WebCore::SVGTextContentElement::getSubStringLength):
3600         (WebCore::SVGTextContentElement::getRotationOfChar):
3601         * ksvg2/svg/SVGTransformDistance.cpp:
3602         (WebCore::SVGTransformDistance::SVGTransformDistance):
3603         (WebCore::SVGTransformDistance::distance):
3604         * page/InspectorController.cpp:
3605         (WebCore::InspectorResource::InspectorResource):
3606         * platform/graphics/FloatPoint3D.cpp:
3607         (WebCore::FloatPoint3D::normalize):
3608         * platform/graphics/Path.cpp:
3609         (WebCore::pathLengthApplierFunction):
3610         (WebCore::Path::createRoundedRectangle):
3611         * platform/graphics/cg/GraphicsContextCG.cpp:
3612         (WebCore::GraphicsContext::drawLine):
3613         (WebCore::GraphicsContext::strokeArc):
3614         * platform/graphics/cg/ImageCG.cpp:
3615         (WebCore::FrameData::clear):
3616         * platform/graphics/cg/ImageSourceCG.cpp:
3617         (WebCore::ImageSource::frameDurationAtIndex):
3618         * platform/graphics/cg/PDFDocumentImage.cpp:
3619         (WebCore::PDFDocumentImage::setCurrentPage):
3620         * platform/graphics/svg/SVGPaintServerPattern.cpp:
3621         (WebCore::SVGPaintServerPattern::externalRepresentation):
3622         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
3623         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
3624         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
3625         (WebCore::cgGradientCallback):
3626         (WebCore::CGShadingRefForRadialGradient):
3627         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
3628         * platform/mac/FontDataMac.mm:
3629         (WebCore::webFallbackFontFamily):
3630         * platform/mac/PopupMenuMac.mm:
3631         (WebCore::PopupMenu::show):
3632         * rendering/InlineFlowBox.cpp:
3633         (WebCore::InlineFlowBox::placeBoxesHorizontally):
3634         * rendering/RenderSlider.cpp:
3635         (WebCore::RenderSlider::setValueForPosition):
3636         (WebCore::RenderSlider::setPositionFromValue):
3637
3638 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
3639
3640         Reviewed by Geoff.
3641
3642         http://bugs.webkit.org/show_bug.cgi?id=14288
3643         XMLHttpRequest doesn't use a correct content type for file:// URLs
3644
3645         Test: fast/dom/xmlhttprequest-html-response-encoding.html
3646
3647         * xml/xmlhttprequest.cpp:
3648         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
3649         the network layer, since it provides it even for non-HTTP responses.
3650
3651 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
3652
3653         Reviewed by Sam Weinig.
3654
3655         http://bugs.webkit.org/show_bug.cgi?id=14061
3656         Implement more of FrameLoaderClientGdk
3657
3658         Make FrameLoaderClientGdk work properly when the MIME type is set.
3659
3660         * loader/gdk/FrameLoaderClientGdk.cpp:
3661         (WebCore::FrameLoaderClientGdk::objectContentType):
3662         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
3663
3664 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
3665
3666         Reviewed by Maciej.
3667
3668         http://bugs.webkit.org/show_bug.cgi?id=14058
3669         Gdk font backend cleanup
3670
3671         * platform/FontData.h: Remove obsolete function.
3672         * platform/gdk/FontDataGdk.cpp:
3673         (WebCore::FontData::containsCharacters): Lock/unlock only once.
3674         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
3675         * platform/gdk/FontPlatformData.h: Remove obsolete function.
3676         * platform/gdk/FontPlatformDataGdk.cpp:
3677         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
3678         not the pixel size.
3679         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
3680         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
3681         (WebCore::GlyphPage::fill): Lock/unlock only once.
3682
3683 2007-06-26  Mitz Pettel  <mitz@webkit.org>
3684
3685         Reviewed by Hyatt.
3686
3687         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
3688           <colgroup>'s borders are ignored when it has <col> children
3689
3690         Covered by existing tests.
3691
3692         * rendering/RenderTableCell.cpp:
3693         (WebCore::RenderTableCell::collapsedLeftBorder):
3694         (WebCore::RenderTableCell::collapsedRightBorder):
3695         (WebCore::RenderTableCell::collapsedTopBorder):
3696         (WebCore::RenderTableCell::collapsedBottomBorder):
3697
3698 2007-06-26  Mitz Pettel  <mitz@webkit.org>
3699
3700         Reviewed by Oliver.
3701
3702         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
3703           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
3704
3705         Test: fast/repaint/text-selection-rect-in-overflow-2.html
3706
3707         * rendering/RenderObject.cpp:
3708         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
3709         for overflow scroll and columns.
3710         * rendering/RenderText.cpp:
3711         (WebCore::RenderText::selectionRect): Adjust for columns only in the
3712         non-clipped case, since RenderObject::absolutePosition() does not.
3713
3714 2007-06-26  Mitz Pettel  <mitz@webkit.org>
3715
3716         Reviewed by Sam.
3717
3718         - http://bugs.webkit.org/show_bug.cgi?id=14415
3719           Remove the unused method RenderObject::setTable()
3720
3721         * rendering/RenderObject.h:
3722
3723 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
3724
3725         Reviewed by Maciej.
3726
3727         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
3728         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
3729
3730         This change moves the bulk of ResourceRequest into a base class named
3731         ResourceRequestBase with all platform-specific bits pushed into
3732         ResourceRequest.  This allows ports to easily add new members to a
3733         ResourceRequest without having to #ifdef the code that is shared
3734         between ports.
3735
3736         * WebCore.exp:
3737         * WebCore.pro:
3738         * WebCore.vcproj/WebCore.vcproj:
3739         * WebCore.xcodeproj/project.pbxproj:
3740         * platform/network/ResourceRequest.cpp: Removed.
3741         * platform/network/ResourceRequest.h: Removed.
3742         * platform/network/ResourceRequestBase.cpp: Added.
3743         (WebCore::ResourceRequestBase::asResourceRequest):
3744         (WebCore::ResourceRequestBase::isEmpty):
3745         (WebCore::ResourceRequestBase::isNull):
3746         (WebCore::ResourceRequestBase::url):
3747         (WebCore::ResourceRequestBase::setURL):
3748         (WebCore::ResourceRequestBase::cachePolicy):
3749         (WebCore::ResourceRequestBase::setCachePolicy):
3750         (WebCore::ResourceRequestBase::timeoutInterval):
3751         (WebCore::ResourceRequestBase::setTimeoutInterval):
3752         (WebCore::ResourceRequestBase::mainDocumentURL):
3753         (WebCore::ResourceRequestBase::setMainDocumentURL):
3754         (WebCore::ResourceRequestBase::httpMethod):
3755         (WebCore::ResourceRequestBase::setHTTPMethod):
3756         (WebCore::ResourceRequestBase::httpHeaderFields):
3757         (WebCore::ResourceRequestBase::httpHeaderField):
3758         (WebCore::ResourceRequestBase::setHTTPHeaderField):
3759         (WebCore::ResourceRequestBase::httpBody):
3760         (WebCore::ResourceRequestBase::setHTTPBody):
3761         (WebCore::ResourceRequestBase::allowHTTPCookies):
3762         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
3763         (WebCore::ResourceRequestBase::addHTTPHeaderField):
3764         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
3765         (WebCore::operator==):
3766         (WebCore::ResourceRequestBase::isConditional):
3767         (WebCore::ResourceRequestBase::updatePlatformRequest):
3768         (WebCore::ResourceRequestBase::updateResourceRequest):
3769         * platform/network/ResourceRequestBase.h: Added.
3770         (WebCore::):
3771         (WebCore::ResourceRequestBase::httpContentType):
3772         (WebCore::ResourceRequestBase::setHTTPContentType):
3773         (WebCore::ResourceRequestBase::httpReferrer):
3774         (WebCore::ResourceRequestBase::setHTTPReferrer):
3775         (WebCore::ResourceRequestBase::clearHTTPReferrer):
3776         (WebCore::ResourceRequestBase::httpUserAgent):
3777         (WebCore::ResourceRequestBase::setHTTPUserAgent):
3778         (WebCore::ResourceRequestBase::httpAccept):
3779         (WebCore::ResourceRequestBase::setHTTPAccept):
3780         (WebCore::ResourceRequestBase::ResourceRequestBase):
3781         (WebCore::operator!=):
3782         * platform/network/cf/ResourceRequest.h: Added.
3783         (WebCore::ResourceRequest::ResourceRequest):
3784         * platform/network/curl/ResourceRequest.h: Added.
3785         (WebCore::ResourceRequest::ResourceRequest):
3786         (WebCore::ResourceRequest::doUpdatePlatformRequest):
3787         (WebCore::ResourceRequest::doUpdateResourceRequest):
3788         * platform/network/mac/ResourceRequest.h: Added.
3789         (WebCore::ResourceRequest::ResourceRequest):
3790         * platform/network/qt/ResourceRequest.h: Added.
3791         (WebCore::ResourceRequest::ResourceRequest):
3792         (WebCore::ResourceRequest::doUpdatePlatformRequest):
3793         (WebCore::ResourceRequest::doUpdateResourceRequest):
3794
3795 2007-06-26  Adam Roben  <aroben@apple.com>
3796
3797         Add ChangeLog entries from the Windows merge.
3798
3799         Reviewed by Maciej.
3800
3801         * ChangeLog:
3802
3803 2007-06-26  Sam Weinig  <sam@webkit.org>
3804
3805         Reviewed by Maciej.
3806
3807         Make sure not to enumerate the toString() function.
3808         <rdar://problem/5297118>
3809
3810         * bindings/js/kjs_window.cpp:
3811         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
3812         * html/HTMLAnchorElement.idl:
3813
3814 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
3815
3816         Reviewed by Mitz, landed by Anders.
3817
3818         http://bugs.webkit.org/show_bug.cgi?id=14421
3819         Implement GraphicsContext::clearRect()
3820
3821         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3822         (WebCore::GraphicsContext::clearRect):
3823
3824 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
3825
3826         Reviewed and landed by Anders.
3827
3828         http://bugs.webkit.org/show_bug.cgi?id=14416
3829         Content does not render fully in some cases
3830
3831         Fix mismatched calls to cairo_save/restore due to an early method return.
3832
3833         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3834         (WebCore::GraphicsContext::drawLine):
3835
3836 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
3837
3838         Reviewed by John Sullivan.
3839
3840         Added two accessor functions for <rdar://problem/4119138>
3841
3842         * bindings/objc/DOMHTML.mm:
3843         (-[DOMHTMLInputElement _isEdited]):
3844         (-[DOMHTMLTextAreaElement _isEdited]):
3845         Added an accessor to the isEdited value of a DOM node's render object
3846
3847         * bindings/objc/DOMPrivate.h:
3848         Added header definitions for _isEdited
3849
3850 2007-06-26  Sam Weinig  <sam@webkit.org>
3851
3852         Fix Win32 build.
3853
3854         * WebCore.vcproj/WebCore.vcproj:
3855
3856 2007-06-26  Sam Weinig  <sam@webkit.org>
3857
3858         Fix Qt and Gdk builds.
3859
3860         * WebCore.pro:
3861
3862 2007-06-26  Sam Weinig  <sam@webkit.org>
3863
3864         Reviewed by Geoff.
3865
3866         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
3867         Autogenerate Event JS binding
3868
3869         - Moves the dataTransfer method into MouseEvent where it should be.
3870
3871         * WebCore.xcodeproj/project.pbxproj:
3872         * bindings/js/JSEventCustom.cpp: Added.
3873         (WebCore::JSEvent::clipboardData):
3874         (WebCore::toJS):
3875         * bindings/js/JSEventTargetNode.cpp:
3876         * bindings/js/JSXMLHttpRequest.cpp:
3877         * bindings/js/kjs_events.cpp:
3878         * bindings/js/kjs_events.h:
3879         * bindings/objc/DOMUtility.mm:
3880         (KJS::createDOMWrapper):
3881         * bindings/scripts/CodeGeneratorJS.pm:
3882         * dom/Event.h:
3883         (WebCore::Event::returnValue):
3884         (WebCore::Event::setReturnValue):
3885         (WebCore::Event::clipboardData):
3886         * dom/Event.idl:
3887         * dom/MouseEvent.h:
3888         (WebCore::MouseEvent::dataTransfer):
3889         * dom/MouseEvent.idl:
3890
3891 2007-06-26  Timothy Hatcher  <timothy@apple.com>
3892
3893         Reviewed by Mark Rowe.
3894
3895         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
3896         http://bugs.webkit.org/show_bug.cgi?id=14385
3897
3898         Correctly remember the "Show implicit properties" setting as you switch nodes.
3899
3900         * page/inspector/ResourcePanel.js:
3901
3902 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
3903
3904         Reviewed by John.
3905
3906         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
3907         
3908         Editing removed a node that was part of a search field's internal
3909         structure that should not be removed.
3910
3911         * editing/DeleteSelectionCommand.cpp:
3912         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
3913         selection to delete ends at [container, x], where x is the number
3914         of children in container, don't remove container.  Special case
3915         code elsewhere in this function will remove it if necessary.
3916
3917 2007-06-25  Sam Weinig  <sam@webkit.org>
3918
3919         Reviewed by Maciej.
3920
3921         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
3922         Mutating document.constructor.prototype mutates Object.prototype
3923
3924         Test: fast/js/constructor.html
3925
3926         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
3927         classes with constructors.  It is an non-enumeratable, non-deletable,
3928         readonly attribute.
3929
3930 2007-06-26  George Staikos  <staikos@kde.org>
3931
3932         Repair the OS X build.
3933
3934         * WebCore.exp:
3935
3936 2007-06-26  Adam Treat  <adam@staikos.net>
3937
3938         Reviewed by Adam Roben.
3939
3940         Make the SQLite icon database optional.
3941
3942         * loader/icon/IconDatabase.cpp:
3943         (WebCore::IconDatabase::isOpen):
3944         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
3945         (WebCore::IconDatabase::enabled):
3946         * loader/icon/IconDatabase.h:
3947
3948 2007-06-25  Sam Weinig  <sam@webkit.org>
3949
3950         Reviewed by Adam Roben.
3951
3952         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
3953         HTML syntax highlighting colors and DOM tree colors should be the same
3954
3955         * css/view-source.css:
3956         * page/inspector/ResourcePanel.js:
3957         * page/inspector/inspector.css:
3958         * page/inspector/inspector.js:
3959         * page/inspector/utilities.js:
3960
3961 2007-06-25  Adam Roben  <aroben@apple.com>
3962
3963         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
3964         http://bugs.webkit.org/show_bug.cgi?id=14402
3965
3966         The solution was to make KURL::lastPathComponent ignore trailing
3967         slashes, which is what -[NSURL lastPathComponent] does, too.
3968
3969         Reviewed by Oliver.
3970
3971         * platform/KURL.cpp:
3972         (WebCore::KURL::lastPathComponent):
3973
3974 2007-06-25  Sam Weinig  <sam@webkit.org>
3975
3976         Reviewed by Adam Roben.
3977
3978         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
3979         Web Inspector lists favicon.ico as "other" instead of "image"
3980
3981         * page/InspectorController.cpp:
3982         (WebCore::InspectorResource::type):
3983
3984 2007-06-25  Adele Peterson  <adele@apple.com>
3985
3986         Reviewed by Hyatt.
3987
3988         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
3989         http://bugs.webkit.org/show_bug.cgi?id=14297
3990
3991         Test: fast/overflow/hidden-scrollbar-resize.html
3992
3993         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
3994         Updated our shouldPaint check to consider visibility.
3995
3996 2007-06-25  Oliver Hunt  <oliver@apple.com>
3997
3998         Reviewed by Darin.
3999
4000         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
4001
4002         Fixing logic error in DragController
4003
4004         * manual-tests/drop-text-acquires-style.html: Added.
4005         * page/DragController.cpp:
4006         (WebCore::documentFragmentFromDragData):
4007
4008 2007-06-25  Sam Weinig  <sam@webkit.org>
4009
4010         Reviewed by Adam Roben.
4011
4012         Annotate prototypes by adding "Prototype" subtitle.
4013
4014         * page/inspector/ResourcePanel.js:
4015
4016 2007-06-25  George Staikos  <staikos@kde.org>
4017
4018         Reviewed by Zack.
4019
4020         Start to add proxy and SSL support to WebKitQt.  Proxying works.
4021
4022         * platform/network/ResourceHandleInternal.h:
4023         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
4024         * platform/network/qt/ResourceHandleQt.cpp:
4025         (WebCore::ResourceHandle::start):
4026
4027 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
4028
4029         Reviewed by Adam Roben.
4030
4031         http://bugs.webkit.org/show_bug.cgi?id=14386
4032         Gdk build fix
4033
4034         * WebCore.pro: Fix gtk/gdk typo.
4035
4036 2007-06-25  Timothy Hatcher  <timothy@apple.com>
4037
4038         Reviewed by Anders.
4039
4040         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
4041         http://bugs.webkit.org/show_bug.cgi?id=14385
4042
4043         Add a toggle to show implict computed properties.
4044
4045         * page/inspector/ResourcePanel.js:
4046         * page/inspector/inspector.css:
4047         * page/inspector/inspector.js:
4048
4049 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
4050
4051         Reviewed by Mark.
4052
4053         http://bugs.webkit.org/show_bug.cgi?id=13975
4054         Use system-provided libjpeg and libpng
4055
4056         * WebCore.pro: Remove bundled libjpeg and libpng sources.
4057         * platform/image-decoders/jpeg: Remove sources.
4058         * platform/image-decoders/png: Remove sources.
4059
4060 2007-06-25  Mitz Pettel  <mitz@webkit.org>
4061
4062         Reviewed by Darin.
4063
4064         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
4065           Table caption renders too narrow sometimes
4066
4067         Test: fast/table/caption-relayout.html
4068
4069         * rendering/RenderTable.cpp:
4070         (WebCore::RenderTable::layout): Mark the caption for layout if the table
4071         width changed.
4072
4073 2007-06-25  Mitz Pettel  <mitz@webkit.org>
4074
4075         Reviewed by Darin.
4076
4077         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
4078           Underline painted under <br>, not repainted properly
4079
4080         Test: fast/inline/br-text-decoration.html
4081
4082         * platform/graphics/cg/GraphicsContextCG.cpp:
4083         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
4084         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
4085         than their thickness paint correctly.
4086
4087 2007-06-25  Mitz Pettel  <mitz@webkit.org>
4088
4089         Reviewed by Maciej.
4090
4091         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
4092           rules="none" ignored in certain cases
4093
4094         Covered by existing tests.
4095
4096         * html/HTMLTableElement.cpp:
4097         (WebCore::HTMLTableElement::getSharedCellDecl):
4098
4099 2007-06-24  Sam Weinig  <sam@webkit.org>
4100
4101         Reviewed by Mitz.
4102
4103         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
4104         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
4105
4106         * page/inspector/ResourcePanel.js: make sure not to call an overriden
4107         toString() by using Object.prototype.toString.call().
4108
4109 2007-06-24  Adam Roben  <aroben@apple.com>
4110
4111         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
4112         Bug 14374: Computed Style section should be expanded by default
4113
4114         Reviewed by Sam.
4115
4116         No regression test possible.
4117
4118         * page/inspector/ResourcePanel.js: Expand all style sections.
4119
4120 2007-06-24  Adam Roben  <aroben@apple.com>
4121
4122         Unify the style of enums in the Inspector JS
4123
4124         All our enums are now represented by an object with a property for
4125         each enum value.
4126
4127         Reviewed by Sam.
4128
4129         No regression test possible.
4130
4131         * page/inspector/ConsolePanel.js:
4132         * page/inspector/Resource.js:
4133         * page/inspector/ResourcePanel.js:
4134         * page/inspector/inspector.js:
4135
4136 2007-06-23  Sam Weinig  <sam@webkit.org>
4137
4138         Reviewed by Mitz.
4139
4140         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
4141         getComputedStyle(...).zIndex returns string "normal"
4142
4143         Test: fast/css/getComputedStyle-zIndex-auto.html
4144
4145         * css/CSSComputedStyleDeclaration.cpp:
4146         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
4147
4148 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
4149
4150         Reviewed by Tim Hatcher.
4151
4152         Bug 14265: Cannot resize columns in webinspector
4153         http://bugs.webkit.org/show_bug.cgi?id=14265
4154
4155         * page/inspector/inspector.css:
4156         * page/inspector/inspector.html:
4157         * page/inspector/inspector.js:
4158
4159 2007-06-23  Adam Roben  <aroben@apple.com>
4160
4161         Silence a build warning about not finding `num-cpus`
4162
4163         Reviewed by Mark Rowe.
4164
4165         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
4166         location.
4167
4168 2007-06-22  Anders Carlsson  <andersca@apple.com>
4169
4170         Reviewed by Darin.
4171
4172         * plugins/win/PluginStreamWin.cpp:
4173         (WebCore::PluginStreamWin::didFinishLoading):
4174         No need to fetch the size from resourceData.
4175
4176 2007-06-22  Anders Carlsson  <andersca@apple.com>
4177
4178         Reviewed by Darin.
4179
4180         <rdar://problem/5288617>
4181         Crash playing a very large QuickTime movie inside Safari.
4182
4183         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
4184         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
4185         
4186         * plugins/win/PluginStreamWin.cpp:
4187         (WebCore::PluginStreamWin::PluginStreamWin):
4188         (WebCore::PluginStreamWin::~PluginStreamWin):
4189         (WebCore::PluginStreamWin::didReceiveData):
4190         (WebCore::PluginStreamWin::didFinishLoading):
4191         * plugins/win/PluginStreamWin.h:
4192
4193 2007-06-22  Beth Dakin  <bdakin@apple.com>
4194
4195         Reviewed by Oliver and Darin.
4196
4197         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
4198         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
4199
4200         We already have code that tries to prevent allocating too-large 
4201         rowspans. The rowspan in this test, however, was small enough that 
4202         we thought it was okay in that code, even though clearly it was 
4203         still too large. I did a bunch of testing in Firefox, and it seems 
4204         that they set a hard limit on the maximum rowspan right in the DOM 
4205         -- 8k. So that is what this patch implements. 
4206
4207         * html/HTMLTableCellElement.cpp:
4208         (WebCore::HTMLTableCellElement::parseMappedAttribute):
4209
4210 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
4211
4212         Reviewed by Darin.
4213         
4214         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
4215         
4216         Deletion inserts a placeholder after it removes full paragraphs if
4217         one doesn't already exist.  The code that looked for a pre-existing
4218         placeholder didn't work because of a bug in enclosingNodeOfType.
4219
4220         * editing/htmlediting.cpp:
4221         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
4222         but don't go above an editing root.
4223
4224 2007-06-22  Anders Carlsson  <andersca@apple.com>
4225
4226         Reviewed by Maciej and Geoff.
4227
4228         <rdar://problem/5244734>
4229         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
4230         
4231         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
4232         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
4233         argument to a bunch of classes).
4234         
4235         * loader/Cache.cpp:
4236         (WebCore::createResource):
4237         (WebCore::Cache::requestResource):
4238         * loader/Cache.h:
4239         * loader/CachedCSSStyleSheet.cpp:
4240         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
4241         * loader/CachedCSSStyleSheet.h:
4242         * loader/CachedResource.cpp:
4243         (WebCore::CachedResource::CachedResource):
4244         * loader/CachedResource.h:
4245         (WebCore::CachedResource::sendResourceLoadCallbacks):
4246         * loader/DocLoader.cpp:
4247         (WebCore::DocLoader::requestCSSStyleSheet):
4248         (WebCore::DocLoader::requestResource):
4249         (WebCore::DocLoader::checkCacheObjectStatus):
4250         * loader/DocLoader.h:
4251         * loader/MainResourceLoader.cpp:
4252         (WebCore::MainResourceLoader::MainResourceLoader):
4253         * loader/Request.cpp:
4254         (WebCore::Request::Request):
4255         * loader/Request.h:
4256         (WebCore::Request::sendResourceLoadCallbacks):
4257         * loader/ResourceLoader.cpp:
4258         (WebCore::ResourceLoader::ResourceLoader):
4259         (WebCore::ResourceLoader::willSendRequest):
4260         (WebCore::ResourceLoader::didReceiveResponse):
4261         (WebCore::ResourceLoader::didReceiveData):
4262         (WebCore::ResourceLoader::didFinishLoadingOnePart):
4263         (WebCore::ResourceLoader::didFail):
4264         (WebCore::ResourceLoader::didCancel):
4265         * loader/ResourceLoader.h:
4266         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
4267         * loader/SubresourceLoader.cpp:
4268         (WebCore::SubresourceLoader::SubresourceLoader):
4269         (WebCore::SubresourceLoader::create):
4270         * loader/SubresourceLoader.h:
4271         * loader/loader.cpp:
4272         (WebCore::Loader::load):
4273         (WebCore::Loader::servePendingRequests):
4274         * loader/loader.h:
4275         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
4276         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
4277
4278 2007-06-21  Richard Connamacher  <rich@indieimage.com>
4279
4280         Reviewed by Tim Hatcher.
4281
4282         Bug 14305: Web Inspector marks local files with server-side compression tip
4283         http://bugs.webkit.org/show_bug.cgi?id=14305
4284
4285         * page/inspector/Resource.js:
4286         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
4287         from being given to local files
4288
4289 2007-06-21  Mark Rowe &n