2010-10-20 Sheriff Bot <webkit.review.bot@gmail.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2010-10-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r70040.
4         http://trac.webkit.org/changeset/70040
5         https://bugs.webkit.org/show_bug.cgi?id=48042
6
7         "Reverting a performance regression detected by page_cycler"
8         (Requested by hayato on #webkit).
9
10         * css/CSSStyleSelector.cpp:
11         (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
12         (WebCore::CSSStyleSelector::checkSelector):
13         * css/CSSStyleSelector.h:
14
15 2010-10-19  Simon Fraser  <simon.fraser@apple.com>
16
17         Reviewed by Gavin Barraclough.
18
19         https://bugs.webkit.org/show_bug.cgi?id=47851
20         
21         Avoid buffer overflows in CSSPrimitiveValue's use of 
22         DecimalNumber, and pass the buffer size in InspectorBasicValue.
23
24         Test: fast/css/large-value-csstext.html
25
26         * css/CSSPrimitiveValue.cpp:
27         (WebCore::formatNumber):
28         * inspector/InspectorValues.cpp:
29         (WebCore::InspectorBasicValue::writeJSON):
30
31 2010-10-20  Dumitru Daniliuc  <dumi@chromium.org>
32
33         Reviewed by David Levin.
34
35         Add SecurityOrigin::threadsafeCopy() to the list of exported symbols.
36         https://bugs.webkit.org/show_bug.cgi?id=40655
37
38         * WebCore.exp.in:
39
40 2010-10-20  Sheriff Bot  <webkit.review.bot@gmail.com>
41
42         Unreviewed, rolling out r70165.
43         http://trac.webkit.org/changeset/70165
44         https://bugs.webkit.org/show_bug.cgi?id=48007
45
46         It broke tests on Qt bot (Requested by Ossy on #webkit).
47
48         * ForwardingHeaders/wtf/text/TextPosition.h: Removed.
49         * bindings/js/ScriptSourceCode.h:
50         (WebCore::ScriptSourceCode::ScriptSourceCode):
51         * bindings/v8/ScheduledAction.cpp:
52         (WebCore::ScheduledAction::ScheduledAction):
53         * bindings/v8/ScriptController.cpp:
54         (WebCore::ScriptController::eventHandlerLineNumber):
55         (WebCore::ScriptController::eventHandlerColumnNumber):
56         * bindings/v8/ScriptController.h:
57         * bindings/v8/ScriptEventListener.cpp:
58         (WebCore::createAttributeEventListener):
59         * bindings/v8/ScriptSourceCode.h:
60         (WebCore::ScriptSourceCode::ScriptSourceCode):
61         (WebCore::ScriptSourceCode::startLine):
62         * bindings/v8/V8LazyEventListener.cpp:
63         (WebCore::V8LazyEventListener::V8LazyEventListener):
64         (WebCore::V8LazyEventListener::prepareListenerObject):
65         * bindings/v8/V8LazyEventListener.h:
66         (WebCore::V8LazyEventListener::create):
67         * bindings/v8/V8Proxy.cpp:
68         (WebCore::V8Proxy::compileScript):
69         (WebCore::V8Proxy::evaluate):
70         (WebCore::V8Proxy::runScript):
71         * bindings/v8/V8Proxy.h:
72         * bindings/v8/WorkerContextExecutionProxy.cpp:
73         (WebCore::WorkerContextExecutionProxy::evaluate):
74         (WebCore::WorkerContextExecutionProxy::runScript):
75         * bindings/v8/WorkerContextExecutionProxy.h:
76         * bindings/v8/WorkerScriptController.cpp:
77         (WebCore::WorkerScriptController::evaluate):
78         * dom/PendingScript.cpp:
79         (WebCore::PendingScript::releaseElementAndClear):
80         * dom/PendingScript.h:
81         (WebCore::PendingScript::PendingScript):
82         (WebCore::PendingScript::operator=):
83         (WebCore::PendingScript::startingLineNumber):
84         * dom/ScriptableDocumentParser.h:
85         * dom/XMLDocumentParser.h:
86         * dom/XMLDocumentParserLibxml2.cpp:
87         (WebCore::XMLDocumentParser::XMLDocumentParser):
88         (WebCore::XMLDocumentParser::startElementNs):
89         (WebCore::XMLDocumentParser::endElementNs):
90         (WebCore::XMLDocumentParser::lineNumber):
91         (WebCore::XMLDocumentParser::columnNumber):
92         * dom/XMLDocumentParserQt.cpp:
93         (WebCore::XMLDocumentParser::XMLDocumentParser):
94         (WebCore::XMLDocumentParser::parseStartElement):
95         (WebCore::XMLDocumentParser::parseEndElement):
96         * html/parser/HTMLDocumentParser.cpp:
97         (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
98         (WebCore::HTMLDocumentParser::columnNumber):
99         * html/parser/HTMLDocumentParser.h:
100         * html/parser/HTMLScriptRunner.cpp:
101         (WebCore::HTMLScriptRunner::sourceFromPendingScript):
102         (WebCore::HTMLScriptRunner::execute):
103         (WebCore::HTMLScriptRunner::runScript):
104         * html/parser/HTMLScriptRunner.h:
105         * html/parser/HTMLTreeBuilder.cpp:
106         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
107         (WebCore::HTMLTreeBuilder::takeScriptToProcess):
108         (WebCore::HTMLTreeBuilder::processEndTag):
109         (WebCore::HTMLTreeBuilder::processScriptStartTag):
110         * html/parser/HTMLTreeBuilder.h:
111
112 2010-10-20  David Hyatt  <hyatt@apple.com>
113
114         Reviewed by Dan Bernstein.
115
116         https://bugs.webkit.org/show_bug.cgi?id=48001
117
118         Make boxes place themselves properly in the block direction.  Get basic painting working for spans and add a test that
119         verifies that span painting and replaced element painting (like images) works correctly.
120         
121         Added fast/blockflow/basic-vertical-line.html
122
123         * rendering/InlineBox.cpp:
124         (WebCore::InlineBox::logicalHeight):
125         * rendering/InlineFlowBox.cpp:
126         (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
127         (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
128         (WebCore::verticalPositionForBox):
129         (WebCore::InlineFlowBox::computeLogicalBoxHeights):
130         (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
131         (WebCore::InlineFlowBox::flipLinesInBlockDirection):
132         (WebCore::InlineFlowBox::paintBoxDecorations):
133         (WebCore::InlineFlowBox::paintMask):
134         * rendering/InlineFlowBox.h:
135         * rendering/style/RenderStyle.h:
136         (WebCore::InheritedFlags::isFlippedLinesWritingMode):
137
138 2010-10-20  Beth Dakin  <bdakin@apple.com>
139
140         Reviewed by Dave Hyatt.
141
142         Fix for https://bugs.webkit.org/show_bug.cgi?id=47514 CSS 
143         transforms should affect scrolling
144
145         This patch causes topmostPosition, lowestPosition, 
146         leftmostPosition, and rightmostPosition to take transforms into 
147         account.
148
149         Compute the topmost/lowest/leftmost/rightmost position without 
150         factoring in the block's transform until the end.
151         * rendering/RenderBlock.cpp:
152         (WebCore::RenderBlock::topmostPosition):
153         (WebCore::RenderBlock::lowestPosition):
154         (WebCore::RenderBlock::rightmostPosition):
155         (WebCore::RenderBlock::leftmostPosition):
156         * rendering/RenderBlock.h:
157
158         transformedFrameRect() returns the frameRect() transformed to the 
159         layer's transform. applyLayerTransformToRect() does the same thing 
160         for the input rect.
161         * rendering/RenderBox.cpp:
162         (WebCore::RenderBox::applyLayerTransformToRect):
163         (WebCore::RenderBox::transformedFrameRect):
164         (WebCore::RenderBox::topmostPosition):
165         (WebCore::RenderBox::lowestPosition):
166         (WebCore::RenderBox::rightmostPosition):
167         (WebCore::RenderBox::leftmostPosition):
168         * rendering/RenderBox.h:
169         * rendering/RenderMedia.cpp:
170         (WebCore::RenderMedia::topmostPosition):
171         (WebCore::RenderMedia::lowestPosition):
172         (WebCore::RenderMedia::rightmostPosition):
173         (WebCore::RenderMedia::leftmostPosition):
174         * rendering/RenderMedia.h:
175         * rendering/RenderTableSection.cpp:
176         (WebCore::RenderTableSection::topmostPosition):
177         (WebCore::RenderTableSection::lowestPosition):
178         (WebCore::RenderTableSection::rightmostPosition):
179         (WebCore::RenderTableSection::leftmostPosition):
180         * rendering/RenderTableSection.h:
181
182 2010-10-20  Nikolas Zimmermann  <nzimmermann@rim.com>
183
184         Not reviewed.
185
186         Rename SVGAnimatedProperty* -> DeprecatedSVGAnimatedProperty*
187         https://bugs.webkit.org/show_bug.cgi?id=47973
188
189         Copy headers from svg/properties, otherwhise builds from scratch on win are broken.
190
191         * WebCore.vcproj/copyForwardingHeaders.cmd:
192
193 2010-10-20  Peter Rybin  <peter.rybin@gmail.com>
194
195         Reviewed by Adam Barth.
196
197         HTML parser should provide script column position within HTML document to JavaScript engine
198         https://bugs.webkit.org/show_bug.cgi?id=45271
199
200         Replaces line number with TextPosition struct so that script engine
201         gets script starting line/column.
202
203         * ForwardingHeaders/wtf/text/TextPosition.h: Added.
204         * bindings/js/ScriptSourceCode.h:
205         (WebCore::ScriptSourceCode::ScriptSourceCode):
206         * bindings/v8/ScheduledAction.cpp:
207         (WebCore::ScheduledAction::ScheduledAction):
208         * bindings/v8/ScriptController.cpp:
209         (WebCore::ScriptController::eventHandlerPosition):
210         * bindings/v8/ScriptController.h:
211         * bindings/v8/ScriptEventListener.cpp:
212         (WebCore::createAttributeEventListener):
213         * bindings/v8/ScriptSourceCode.h:
214         (WebCore::ScriptSourceCode::ScriptSourceCode):
215         (WebCore::ScriptSourceCode::startLine):
216         (WebCore::ScriptSourceCode::startPosition):
217         * bindings/v8/V8LazyEventListener.cpp:
218         (WebCore::V8LazyEventListener::V8LazyEventListener):
219         (WebCore::V8LazyEventListener::prepareListenerObject):
220         * bindings/v8/V8LazyEventListener.h:
221         (WebCore::V8LazyEventListener::create):
222         * bindings/v8/V8Proxy.cpp:
223         (WebCore::V8Proxy::compileScript):
224         (WebCore::V8Proxy::evaluate):
225         (WebCore::V8Proxy::runScript):
226         * bindings/v8/V8Proxy.h:
227         * bindings/v8/WorkerContextExecutionProxy.cpp:
228         (WebCore::WorkerContextExecutionProxy::evaluate):
229         (WebCore::WorkerContextExecutionProxy::runScript):
230         * bindings/v8/WorkerContextExecutionProxy.h:
231         * bindings/v8/WorkerScriptController.cpp:
232         (WebCore::WorkerScriptController::evaluate):
233         * dom/PendingScript.cpp:
234         (WebCore::PendingScript::releaseElementAndClear):
235         * dom/PendingScript.h:
236         (WebCore::PendingScript::PendingScript):
237         (WebCore::PendingScript::operator=):
238         (WebCore::PendingScript::startingPosition):
239         * dom/ScriptableDocumentParser.h:
240         * dom/XMLDocumentParser.h:
241         * dom/XMLDocumentParserLibxml2.cpp:
242         (WebCore::XMLDocumentParser::XMLDocumentParser):
243         (WebCore::XMLDocumentParser::startElementNs):
244         (WebCore::XMLDocumentParser::endElementNs):
245         (WebCore::XMLDocumentParser::lineNumber):
246         (WebCore::XMLDocumentParser::columnNumber):
247         (WebCore::XMLDocumentParser::textPosition):
248         (WebCore::XMLDocumentParser::textPositionOneBased):
249         * dom/XMLDocumentParserQt.cpp:
250         (WebCore::XMLDocumentParser::XMLDocumentParser):
251         (WebCore::XMLDocumentParser::textPosition):
252         (WebCore::XMLDocumentParser::parseStartElement):
253         (WebCore::XMLDocumentParser::parseEndElement):
254         * html/parser/HTMLDocumentParser.cpp:
255         (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
256         (WebCore::HTMLDocumentParser::textPosition):
257         * html/parser/HTMLDocumentParser.h:
258         * html/parser/HTMLScriptRunner.cpp:
259         (WebCore::HTMLScriptRunner::sourceFromPendingScript):
260         (WebCore::HTMLScriptRunner::execute):
261         (WebCore::HTMLScriptRunner::runScript):
262         * html/parser/HTMLScriptRunner.h:
263         * html/parser/HTMLTreeBuilder.cpp:
264         (WebCore::uninitializedPositionValue1):
265         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
266         (WebCore::HTMLTreeBuilder::takeScriptToProcess):
267         (WebCore::HTMLTreeBuilder::processEndTag):
268         (WebCore::HTMLTreeBuilder::processScriptStartTag):
269         * html/parser/HTMLTreeBuilder.h:
270
271 2010-10-20  David Hyatt  <hyatt@apple.com>
272
273         Reviewed by Simon Fraser.
274
275         https://bugs.webkit.org/show_bug.cgi?id=47994
276         
277         Make computeBlockDirectionPositionsForLine writing-mode-aware.  None of the functions it calls are patched yet.
278
279         * rendering/RenderBlockLineLayout.cpp:
280         (WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
281
282 2010-10-20  John Abd-El-Malek  <jam@chromium.org>
283
284         Reviewed by Darin Fisher.
285
286         [chromium] Fix crash when mousing over scrollview
287         https://bugs.webkit.org/show_bug.cgi?id=47956
288
289         Test: plugins/mouse-move-over-plugin-in-frame.html
290
291         * platform/Widget.h:
292         (WebCore::Widget::isPluginContainer):
293
294 2010-10-20  Sheriff Bot  <webkit.review.bot@gmail.com>
295
296         Unreviewed, rolling out r70149.
297         http://trac.webkit.org/changeset/70149
298         https://bugs.webkit.org/show_bug.cgi?id=47989
299
300         "Build breaks in mac and win" (Requested by satish on
301         #webkit).
302
303         * dom/Element.cpp:
304         (WebCore::Element::computeInheritedLanguage):
305         * page/SpeechInput.cpp:
306         (WebCore::SpeechInput::startRecognition):
307         * page/SpeechInput.h:
308         * page/SpeechInputClient.h:
309         * platform/mock/SpeechInputClientMock.cpp:
310         (WebCore::SpeechInputClientMock::startRecognition):
311         (WebCore::SpeechInputClientMock::setRecognitionResult):
312         (WebCore::SpeechInputClientMock::timerFired):
313         * platform/mock/SpeechInputClientMock.h:
314         * rendering/TextControlInnerElements.cpp:
315         (WebCore::TextControlInnerElement::attachInnerElement):
316         (WebCore::SearchFieldCancelButtonElement::detach):
317         (WebCore::SpinButtonElement::defaultEventHandler):
318         (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
319         (WebCore::InputFieldSpeechButtonElement::detach):
320
321 2010-10-19  Leandro Gracia Gil  <leandrogracia@google.com>
322
323         Reviewed by Jeremy Orlow.
324
325         Patch the current speech input implementation to use and validate the
326         nearest language tag. The language is now passed to the startRecognition
327         methods so that language-specific recognition could be used. Also added
328         a second parameter to setMockSpeechInputResult for the language used in
329         speech recognition.
330         https://bugs.webkit.org/show_bug.cgi?id=47089
331
332         This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
333         details see http://codereview.chromium.org/3615005/show and
334         http://codereview.chromium.org/3595018/show.
335
336         Test: fast/speech/input-text-language-tag.html
337
338         * dom/Element.cpp:
339         (WebCore::Element::computeInheritedLanguage): includes a brief character
340           validation for the BCP 47 language tag.
341         * page/SpeechInput.cpp:
342         (WebCore::SpeechInput::startRecognition):
343         * page/SpeechInput.h:
344         * page/SpeechInputClient.h:
345         * platform/mock/SpeechInputClientMock.cpp:
346         (WebCore::SpeechInputClientMock::startRecognition):
347         (WebCore::SpeechInputClientMock::setRecognitionResult): results are now
348           stored by language using a hash map.
349         (WebCore::SpeechInputClientMock::timerFired):
350         * platform/mock/SpeechInputClientMock.h:
351         * rendering/TextControlInnerElements.cpp:
352         (WebCore::TextControlInnerElement::attachInnerElement):
353         (WebCore::SearchFieldCancelButtonElement::detach):
354         (WebCore::SpinButtonElement::defaultEventHandler):
355         (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
356         (WebCore::InputFieldSpeechButtonElement::detach):
357
358 2010-10-20  Dirk Schulze  <krit@webkit.org>
359
360         Reviewed by Nikolas Zimmermann.
361
362         Merge ColorSpace and ImageColorSpace enums
363         https://bugs.webkit.org/show_bug.cgi?id=47922
364
365         Merging these two enums makes it easier to implement color-interpolation as well as
366         color-interpolation-filter for SVG.
367         Added ColorSpaceLinearRGB to the ColorSpace enum and changed ImageColorSpace to ColorSpace in all related
368         files. Renamed enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
369         to follow webkit style rules.
370         Removed gray scale support in ImageBuffer since it is not used anymore on WebKit.
371
372         * css/CSSPrimitiveValueMappings.h:
373         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
374         (WebCore::CSSPrimitiveValue::operator ColorSpace):
375         * css/CSSStyleSelector.cpp:
376         (WebCore::CSSStyleSelector::applyProperty):
377         * editing/SelectionController.cpp:
378         (WebCore::SelectionController::paintCaret):
379         * html/HTMLCanvasElement.cpp:
380         (WebCore::HTMLCanvasElement::paint):
381         * html/canvas/CanvasRenderingContext2D.cpp:
382         (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault):
383         (WebCore::CanvasRenderingContext2D::setShadow):
384         (WebCore::CanvasRenderingContext2D::applyShadow):
385         (WebCore::CanvasRenderingContext2D::drawImage):
386         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
387         (WebCore::CanvasRenderingContext2D::drawTextInternal):
388         * html/canvas/CanvasStyle.cpp:
389         (WebCore::CanvasStyle::applyStrokeColor):
390         (WebCore::CanvasStyle::applyFillColor):
391         * inspector/InspectorController.cpp:
392         (WebCore::drawOutlinedQuad):
393         (WebCore::InspectorController::drawElementTitle):
394         * mathml/RenderMathMLBlock.cpp:
395         (WebCore::RenderMathMLBlock::paint):
396         * mathml/RenderMathMLFraction.cpp:
397         (WebCore::RenderMathMLFraction::paint):
398         * mathml/RenderMathMLRoot.cpp:
399         (WebCore::RenderMathMLRoot::paint):
400         * mathml/RenderMathMLSquareRoot.cpp:
401         (WebCore::RenderMathMLSquareRoot::paint):
402         * page/FrameView.cpp:
403         (WebCore::FrameView::paintContents):
404         * page/PrintContext.cpp:
405         (WebCore::PrintContext::spoolAllPagesWithBoundaries):
406         * platform/ScrollView.cpp:
407         (WebCore::ScrollView::wheelEvent):
408         * platform/ScrollbarTheme.h:
409         (WebCore::ScrollbarTheme::paintScrollCorner):
410         * platform/ScrollbarThemeComposite.cpp:
411         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
412         * platform/chromium/PopupMenuChromium.cpp:
413         (WebCore::PopupContainer::paintBorder):
414         (WebCore::PopupListBox::paint):
415         (WebCore::PopupListBox::paintRow):
416         * platform/chromium/ScrollbarThemeChromium.cpp:
417         (WebCore::ScrollbarThemeChromium::paintTickmarks):
418         * platform/chromium/ScrollbarThemeChromiumMac.mm:
419         (WebCore::ScrollbarThemeChromiumMac::paint):
420         * platform/graphics/ColorSpace.h:
421         * platform/graphics/GraphicsContext.cpp:
422         (WebCore::GraphicsContext::setStrokePattern):
423         (WebCore::GraphicsContext::setFillPattern):
424         (WebCore::GraphicsContext::setStrokeGradient):
425         (WebCore::GraphicsContext::setFillGradient):
426         * platform/graphics/GraphicsContextPrivate.h:
427         (WebCore::GraphicsContextState::GraphicsContextState):
428         * platform/graphics/ImageBuffer.cpp:
429         (WebCore::ImageBuffer::transformColorSpace):
430         * platform/graphics/ImageBuffer.h:
431         (WebCore::ImageBuffer::create):
432         * platform/graphics/cairo/ImageBufferCairo.cpp:
433         (WebCore::ImageBuffer::ImageBuffer):
434         * platform/graphics/cg/ColorCG.cpp:
435         (WebCore::cachedCGColorSpace):
436         (WebCore::cachedCGColor):
437         * platform/graphics/cg/GraphicsContextCG.cpp:
438         (WebCore::linearRGBColorSpaceRef):
439         * platform/graphics/cg/GraphicsContextCG.h:
440         * platform/graphics/cg/ImageBufferCG.cpp:
441         (WebCore::ImageBuffer::ImageBuffer):
442         (WebCore::cgImage):
443         (WebCore::ImageBuffer::draw):
444         * platform/graphics/cg/ImageBufferData.h:
445         * platform/graphics/cg/ImageCG.cpp:
446         (WebCore::imageWithColorSpace):
447         * platform/graphics/chromium/GLES2Canvas.cpp:
448         (WebCore::GLES2Canvas::clearRect):
449         (WebCore::GLES2Canvas::fillRect):
450         * platform/graphics/chromium/TransparencyWin.cpp:
451         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
452         * platform/graphics/filters/FEColorMatrix.cpp:
453         (WebCore::FEColorMatrix::apply):
454         * platform/graphics/filters/FEComposite.cpp:
455         (WebCore::FEComposite::apply):
456         * platform/graphics/filters/FEFlood.cpp:
457         (WebCore::FEFlood::apply):
458         * platform/graphics/filters/FEMerge.cpp:
459         (WebCore::FEMerge::apply):
460         * platform/graphics/filters/FEOffset.cpp:
461         (WebCore::FEOffset::apply):
462         * platform/graphics/filters/FETile.cpp:
463         (WebCore::FETile::apply):
464         * platform/graphics/filters/FilterEffect.cpp:
465         (WebCore::FilterEffect::effectContext):
466         * platform/graphics/filters/SourceAlpha.cpp:
467         (WebCore::SourceAlpha::apply):
468         * platform/graphics/filters/SourceGraphic.cpp:
469         (WebCore::SourceGraphic::apply):
470         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
471         (WebCore::MediaPlayerPrivateGStreamer::paint):
472         * platform/graphics/gtk/FontGtk.cpp:
473         (WebCore::Font::drawComplexText):
474         * platform/graphics/mac/GraphicsContextMac.mm:
475         (WebCore::GraphicsContext::drawFocusRing):
476         * platform/graphics/mac/GraphicsLayerCA.mm:
477         (WebCore::setLayerBorderColor):
478         (WebCore::setLayerBackgroundColor):
479         * platform/graphics/qt/GraphicsContextQt.cpp:
480         (WebCore::GraphicsContext::GraphicsContext):
481         * platform/graphics/qt/ImageBufferQt.cpp:
482         (WebCore::ImageBuffer::ImageBuffer):
483         (WebCore::ImageBuffer::draw):
484         * platform/graphics/skia/ImageBufferSkia.cpp:
485         (WebCore::ImageBuffer::ImageBuffer):
486         * platform/graphics/skia/PlatformContextSkia.cpp:
487         (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
488         * platform/graphics/win/FontCGWin.cpp:
489         (WebCore::Font::drawGlyphs):
490         * platform/graphics/win/GraphicsContextCGWin.cpp:
491         (WebCore::GraphicsContext::GraphicsContext):
492         (WebCore::GraphicsContext::drawFocusRing):
493         * platform/graphics/win/GraphicsLayerCACF.cpp:
494         (WebCore::setLayerBorderColor):
495         (WebCore::setLayerBackgroundColor):
496         * platform/graphics/win/ImageCGWin.cpp:
497         (WebCore::BitmapImage::getHBITMAPOfSize):
498         * platform/graphics/win/ImageCairoWin.cpp:
499         (WebCore::BitmapImage::getHBITMAPOfSize):
500         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
501         * platform/graphics/win/WebLayer.cpp:
502         (WebCore::WebLayer::drawInContext):
503         * platform/graphics/wince/GraphicsContextWinCE.cpp:
504         (WebCore::GraphicsContext::clearRect):
505         (WebCore::GraphicsContext::fillRect):
506         * platform/graphics/wince/ImageWinCE.cpp:
507         (WebCore::BitmapImage::getHBITMAPOfSize):
508         * platform/graphics/wx/GraphicsContextWx.cpp:
509         (WebCore::GraphicsContext::GraphicsContext):
510         * platform/gtk/RenderThemeGtk.cpp:
511         (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
512         (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
513         (WebCore::paintMediaButton):
514         (WebCore::RenderThemeGtk::paintMediaSliderTrack):
515         (WebCore::RenderThemeGtk::paintMediaSliderThumb):
516         * platform/mac/ScrollbarThemeMac.mm:
517         (WebCore::ScrollbarThemeMac::paint):
518         * platform/win/PopupMenuWin.cpp:
519         (WebCore::PopupMenuWin::paint):
520         * platform/win/WebCoreTextRenderer.cpp:
521         (WebCore::doDrawTextAtPoint):
522         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
523         (WebCore::drawTextWithSpacing):
524         * plugins/PluginView.cpp:
525         (WebCore::PluginView::paintMissingPluginIcon):
526         * rendering/RenderLayer.cpp:
527         (WebCore::RenderLayer::beginTransparencyLayers):
528         (WebCore::RenderLayer::paintResizer):
529         * rendering/RenderListMarker.cpp:
530         (WebCore::RenderListMarker::paint):
531         * rendering/RenderMediaControlsChromium.cpp:
532         (WebCore::paintMediaButton):
533         (WebCore::paintMediaSlider):
534         (WebCore::paintMediaVolumeSlider):
535         (WebCore::paintMediaTimelineContainer):
536         * rendering/RenderSVGImage.cpp:
537         (WebCore::RenderSVGImage::paint):
538         * rendering/RenderSVGResourceClipper.cpp:
539         (WebCore::RenderSVGResourceClipper::applyClippingToContext):
540         * rendering/RenderSVGResourceFilter.cpp:
541         (WebCore::RenderSVGResourceFilter::applyResource):
542         (WebCore::RenderSVGResourceFilter::postApplyResource):
543         * rendering/RenderSVGResourceGradient.cpp:
544         (WebCore::createMaskAndSwapContextForTextGradient):
545         * rendering/RenderSVGResourceMasker.cpp:
546         (WebCore::RenderSVGResourceMasker::applyResource):
547         (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
548         * rendering/RenderSVGResourcePattern.cpp:
549         (WebCore::RenderSVGResourcePattern::createTileImage):
550         * rendering/RenderSVGResourceSolidColor.cpp:
551         (WebCore::RenderSVGResourceSolidColor::applyResource):
552         * rendering/RenderScrollbarTheme.cpp:
553         (WebCore::RenderScrollbarTheme::paintScrollCorner):
554         * rendering/RenderThemeMac.mm:
555         (WebCore::RenderThemeMac::paintProgressBar):
556         (WebCore::RenderThemeMac::paintMenuListButton):
557         * rendering/RenderThemeSafari.cpp:
558         (WebCore::RenderThemeSafari::paintMenuListButton):
559         * rendering/RenderThemeWinCE.cpp:
560         (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
561         (WebCore::RenderThemeWinCE::paintSliderTrack):
562         (WebCore::RenderThemeWinCE::paintSliderThumb):
563         * rendering/SVGImageBufferTools.cpp:
564         (WebCore::SVGImageBufferTools::createImageBuffer):
565         * rendering/SVGImageBufferTools.h:
566         * rendering/style/StyleRareInheritedData.cpp:
567         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
568         * svg/SVGFEImageElement.cpp:
569         (WebCore::SVGFEImageElement::build):
570         * svg/graphics/SVGImage.cpp:
571         (WebCore::SVGImage::nativeImageForCurrentFrame):
572         * svg/graphics/filters/SVGFEImage.cpp:
573         (WebCore::FEImage::apply):
574
575 2010-10-20  Dirk Schulze  <krit@webkit.org>
576
577         Reviewed by Andreas Kling.
578
579         Remove left over code after moving Cairo port to ShadowContext
580         https://bugs.webkit.org/show_bug.cgi?id=47929
581
582         ImageBufferFilter is not needed anymore, since Cairo is using ShadowContext now.
583         Made kernelPosition() in FEGaussianBlur a inline function instead of a static function.
584
585         * CMakeLists.txt:
586         * GNUmakefile.am:
587         * WebCore.gypi:
588         * WebCore.vcproj/WebCore.vcproj:
589         * platform/graphics/filters/FEGaussianBlur.cpp:
590         (WebCore::kernelPosition):
591         * platform/graphics/filters/FEGaussianBlur.h:
592         * platform/graphics/filters/ImageBufferFilter.cpp: Removed.
593         * platform/graphics/filters/ImageBufferFilter.h: Removed.
594
595 2010-10-20  Nikolas Zimmermann  <nzimmermann@rim.com>
596
597         Not reviewed.
598
599         Fix efl build, by adding the new svg/properties include directory.
600
601         * CMakeLists.txt:
602
603 2010-10-19  Andrey Kosyakov  <caseq@chromium.org>
604
605         Reviewed by Pavel Feldman.
606
607         Web Inspector: expose request/response cookies in HAR
608         https://bugs.webkit.org/show_bug.cgi?id=47894
609
610         Test: inspector/cookie-parser.html
611
612         * WebCore.gypi:
613         * WebCore.vcproj/WebCore.vcproj:
614         * inspector/front-end/CookieParser.js: Added.
615         * inspector/front-end/HAREntry.js:
616         (WebInspector.HAREntry.prototype._buildRequest):
617         (WebInspector.HAREntry.prototype._buildResponse):
618         (WebInspector.HAREntry.prototype._buildCookies):
619         (WebInspector.HAREntry.prototype._buildCookie):
620         * inspector/front-end/Resource.js: Parse Cookie/Set-Cookie headers and expose cookies.
621         (WebInspector.Resource.prototype.set requestHeaders):
622         (WebInspector.Resource.prototype.get requestCookies):
623         (WebInspector.Resource.prototype.set responseHeaders):
624         (WebInspector.Resource.prototype.get responseCookies):
625         (WebInspector.Resource.prototype._parseRequestCookies):
626         (WebInspector.Resource.prototype._parseResponseCookies):
627         * inspector/front-end/WebKit.qrc:
628         * inspector/front-end/inspector.html:
629
630 2010-10-20  Nikolas Zimmermann  <nzimmermann@rim.com>
631
632         Not reviewed.
633
634         Fix non-mac builds, by adding the new svg/properties include directory.
635
636         * GNUmakefile.am:
637         * WebCore.gyp/WebCore.gyp:
638         * WebCore.pro:
639         * WebCore.vcproj/WebCoreCommon.vsprops:
640
641 2010-10-20  Nikolas Zimmermann  <nzimmermann@rim.com>
642
643         Reviewed by Adam Roben.
644
645         Rename SVGAnimatedProperty* -> DeprecatedSVGAnimatedProperty*
646         https://bugs.webkit.org/show_bug.cgi?id=47973
647
648         Prepare fixing bug 47905, redesigning SVGAnimatedProperty. As we're going to move type by type
649         to the new animated property concept, keep the old one around, marked deprecated, until the
650         transition is finished.
651
652         * GNUmakefile.am:
653         * WebCore.gypi:
654         * WebCore.pro:
655         * WebCore.vcproj/WebCore.vcproj:
656         * WebCore.xcodeproj/project.pbxproj:
657         * bindings/scripts/CodeGeneratorObjC.pm:
658         * bindings/scripts/CodeGeneratorV8.pm:
659         * svg/DeprecatedSVGAnimatedProperty.h: Copied from svg/SVGAnimatedProperty.h.
660         (WebCore::DeprecatedSVGAnimatedPropertyTearOff::DeprecatedSVGAnimatedPropertyTearOff):
661         (WebCore::DeprecatedSVGAnimatedPropertyTearOff::~DeprecatedSVGAnimatedPropertyTearOff):
662         (WebCore::DeprecatedSVGAnimatedProperty::~DeprecatedSVGAnimatedProperty):
663         (WebCore::DeprecatedSVGAnimatedProperty::DeprecatedSVGAnimatedProperty):
664         (WebCore::DeprecatedSVGAnimatedProperty::value):
665         (WebCore::DeprecatedSVGAnimatedProperty::baseValue):
666         * svg/DeprecatedSVGAnimatedPropertyTraits.h: Copied from svg/SVGAnimatedPropertyTraits.h.
667         * svg/DeprecatedSVGAnimatedTemplate.h: Copied from svg/SVGAnimatedTemplate.h.
668         (WebCore::DeprecatedSVGAnimatedTypeWrapperKey::DeprecatedSVGAnimatedTypeWrapperKey):
669         (WebCore::DeprecatedSVGAnimatedTypeWrapperKey::operator==):
670         (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHash::hash):
671         (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHash::equal):
672         (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHashTraits::constructDeletedValue):
673         (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHashTraits::isDeletedValue):
674         (WebCore::DeprecatedSVGAnimatedTemplate::~DeprecatedSVGAnimatedTemplate):
675         (WebCore::DeprecatedSVGAnimatedTemplate::forgetWrapper):
676         (WebCore::lookupOrCreateWrapper):
677         * svg/SVGAnimatedProperty.h: Removed.
678         * svg/SVGAnimatedPropertySynchronizer.h: Removed.
679         * svg/SVGAnimatedPropertyTraits.h: Removed.
680         * svg/SVGAnimatedTemplate.h: Removed.
681         * svg/SVGElement.h:
682         * svg/SVGExternalResourcesRequired.h:
683         * svg/SVGFitToViewBox.h:
684         * svg/SVGURIReference.h:
685         * svg/properties: Added.
686         * svg/properties/SVGAnimatedPropertySynchronizer.h: Copied from svg/SVGAnimatedPropertySynchronizer.h.
687
688 2010-10-20  Shinichiro Hamaji  <hamaji@chromium.org>
689
690         Reviewed by Kent Tamura.
691
692         absolutely positioned list in inline element crashes
693         https://bugs.webkit.org/show_bug.cgi?id=45095
694
695         Add a NULL check to avoid crash. The rendering result isn't ideal yet.
696
697         Test: fast/lists/positioned-count-crash.html
698
699         * rendering/RenderListItem.cpp:
700         (WebCore::previousListItem):
701
702 2010-10-19  Adam Roben  <aroben@apple.com>
703
704         Remove uses of CACFContextRef and CARender* from WebCore
705
706         These types are now wrapped in a WKCACFContext type exported by
707         WebKitSystemInterface.
708
709         Fixes <http://webkit.org/b/43244>.
710
711         Reviewed by Sam Weinig.
712
713         * platform/graphics/win/WKCACFContextFlusher.cpp:
714         (WebCore::WKCACFContextFlusher::addContext):
715         (WebCore::WKCACFContextFlusher::removeContext):
716         (WebCore::WKCACFContextFlusher::flushAllContexts):
717         * platform/graphics/win/WKCACFContextFlusher.h:
718         Changed to use WKCACFContext. We don't retain/release the context when
719         putting it into/taking it out of the set. WKCACFContext is not a
720         ref-counted type, so we can't retain/release it, but the
721         retain/release was also unnecessary as WKCACFLayerRenderer calls
722         removeContext before the context is destroyed.
723
724         * platform/graphics/win/WKCACFLayer.cpp:
725         (WebCore::WKCACFLayer::becomeRootLayerForContext):
726         * platform/graphics/win/WKCACFLayer.h:
727         Changed to use WKCACFContext.
728
729         * platform/graphics/win/WKCACFLayerRenderer.cpp:
730         (WebCore::WKCACFLayerRenderer::didFlushContext):
731         (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
732         (WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
733         (WebCore::WKCACFLayerRenderer::layerTreeDidChange):
734         (WebCore::WKCACFLayerRenderer::createRenderer):
735         (WebCore::WKCACFLayerRenderer::destroyRenderer):
736         (WebCore::WKCACFLayerRenderer::render): Also replaced uses of
737         CGSRegion with WebKitSystemInterface functions/types.
738         (WebCore::WKCACFLayerRenderer::resetDevice):
739         * platform/graphics/win/WKCACFLayerRenderer.h:
740         Replaced our CACFContextRef, CARenderContext, and CARenderOGLContext
741         with a single WKCACFContext, which wraps all three. We hold a bare
742         pointer to it and destroy it in our destructor.
743
744 2010-10-19  Yongjun Zhang  <yongjun_zhang@apple.com>
745
746         Reviewed by Dan Bernstein.
747
748         Pixel cracks when using background image sprite on transformed element at certain scales.
749         https://bugs.webkit.org/show_bug.cgi?id=47868
750
751         The pixel bleeding happens when the current context has scale and interpolation is kCGInterpolationHigh
752         or kCGInterpolationDefault.  If the source rect size is smaller than the intrinsic image size,  some
753         pixels outside of the clip rect will also be used to interpolate the color value for clip edges, which
754         results in unwanted thin lines around the painted area.  We need to use sub-image patch to get rid of
755         the artifacts in this case.
756
757         Test: fast/images/pixel-crack-image-background-webkit-transform-scale.html
758
759         * platform/graphics/cg/ImageCG.cpp:
760         (WebCore::BitmapImage::draw):
761
762 2010-10-19  Evan Martin  <evan@chromium.org>
763
764         Reviewed by Tony Chang.
765
766         sqlite: remove unused member variable
767         https://bugs.webkit.org/show_bug.cgi?id=47957
768
769         There's no need to save the error code into a member variable
770         because nobody ever looks at it.
771
772         * platform/sql/SQLiteDatabase.cpp:
773         (WebCore::SQLiteDatabase::open):
774         * platform/sql/SQLiteDatabase.h:
775
776 2010-10-19  Jia Pu  <jpu@apple.com>
777
778         Reviewed by James Robinson.
779
780         Moving cursor back to autocorrected word in the same line shouldn't remove the underline
781         https://bugs.webkit.org/show_bug.cgi?id=47629
782         <rdar://problem/8546758>
783         
784         Patch <http://trac.webkit.org/changeset/70071> breaks some Chromium Mac hehavior. This patch
785         fixes that.
786
787         * editing/Editor.cpp:
788         (WebCore::Editor::respondToChangedSelection): Add "!PLATFORM(MAC)" to make sure nothing changes
789           on non-Mac platforms.
790
791 2010-10-19  Alexey Proskuryakov  <ap@apple.com>
792
793         Build fix (EFL, maybe more).
794
795         * CMakeLists.txt: Added platform/Language.cpp here, too.
796
797 2010-10-19  Jian Li  <jianli@chromium.org>
798
799         Reviewed by Darin Fisher.
800
801         Rename createBlobURL to createObjectURL and revokeBlobURL to
802         revokeObjectURL per the latest File API spec.
803         https://bugs.webkit.org/show_bug.cgi?id=47934
804
805         * inspector/front-end/ResourcesPanel.js:
806         (WebInspector.ResourcesPanel.prototype._contextMenu):
807         * inspector/front-end/utilities.js:
808         * page/DOMWindow.cpp:
809         (WebCore::DOMWindow::createObjectURL):
810         (WebCore::DOMWindow::revokeObjectURL):
811         * page/DOMWindow.h:
812         * page/DOMWindow.idl:
813         * workers/WorkerContext.cpp:
814         (WebCore::WorkerContext::createObjectURL):
815         (WebCore::WorkerContext::revokeObjectURL):
816         * workers/WorkerContext.h:
817         * workers/WorkerContext.idl:
818
819 2010-10-19  Alexey Proskuryakov  <ap@apple.com>
820
821         Reviewed by Anders Carlsson.
822
823         https://bugs.webkit.org/show_bug.cgi?id=47933
824         <rdar://problem/8494337> navigator.language doesn't work in WebKit2
825
826         * CMakeListsEfl.txt:
827         * GNUmakefile.am:
828         * WebCore.gypi:
829         * WebCore.pro:
830         * WebCore.vcproj/WebCore.vcproj:
831         * WebCore.xcodeproj/project.pbxproj:
832         * platform/chromium/Language.cpp: Removed.
833         * platform/chromium/LanguageChromium.cpp: Copied from WebCore/platform/chromium/Language.cpp.
834         * platform/efl/Language.cpp: Removed.
835         * platform/efl/LanguageEfl.cpp: Copied from WebCore/platform/efl/Language.cpp.
836         * platform/gtk/Language.cpp: Removed.
837         * platform/gtk/LanguageGtk.cpp: Copied from WebCore/platform/gtk/Language.cpp.
838         * platform/qt/Language.cpp: Removed.
839         * platform/qt/LanguageQt.cpp: Copied from WebCore/platform/qt/Language.cpp.
840         * platform/win/Language.cpp: Removed.
841         * platform/win/LanguageWin.cpp: Copied from WebCore/platform/win/Language.cpp.
842         * platform/Language.cpp: Added.
843         Cross platform code is now in platform/Language.cpp. So, I renamed platform files to match
844         the common pattern.
845
846         * WebCore.exp.in: Exported new functions.
847
848         * platform/Language.h: Added an ability to force the language, and an ability to set up
849         listeners for changes (if the platform implements that). Web process will always use the
850         forced language, as sent to it from UI process.
851
852         * platform/mac/Language.mm: Moved code from WebKit.
853         (WebCore::platformDefaultLanguage): Added code to synchronize user defaults. For some reason,
854         they come unsynchronized in WebKit2 here, unlike WebKit1.
855
856         * page/mac/WebCoreViewFactory.h: Removed defaultLanguageCode. WebCore no longer goes to WebKit
857         to ask for that.
858
859         * platform/mac/WebCoreSystemInterface.h:
860         * platform/mac/WebCoreSystemInterface.mm:
861         Added wkCopyCFLocalizationPreferredName().
862
863 2010-10-19  James Simonsen  <simonjam@chromium.org>
864
865         Reviewed by Adam Barth.
866
867         Add "in select" insertion mode to parser.
868
869         This was added to the spec in:
870         http://html5.org/tools/web-apps-tracker?from=5520&to=5522
871
872         And as a result of:
873         http://www.w3.org/Bugs/Public/show_bug.cgi?id=10314
874
875         https://bugs.webkit.org/show_bug.cgi?id=47706
876
877         No new tests. Open to ideas.
878
879         * html/parser/HTMLElementStack.cpp: Added "in select" mode.
880         (WebCore::HTMLNames::isSelectScopeMarker): Ditto.
881         (WebCore::HTMLElementStack::inSelectScope): Ditto.
882         * html/parser/HTMLElementStack.h: Ditto.
883         * html/parser/HTMLTreeBuilder.cpp:
884         (WebCore::HTMLTreeBuilder::processStartTag): Use "in select" instead of "in table."
885         (WebCore::HTMLTreeBuilder::processEndTag): Ditto.
886
887 2010-10-19  Jeremy Orlow  <jorlow@chromium.org>
888
889         Reviewed by Nate Chapin.
890
891         Fix multiple index support in IndexedDB
892         https://bugs.webkit.org/show_bug.cgi?id=47919
893
894         Fix 2 bugs that caused the IndexData of all but the last index to be
895         properly updated:
896         * The objectStoreDataId is NOT unique if there are multiple indexes. So
897           remove the constraint.
898         * Do not delete all existing entries with that objectStoreDataId before
899           adding an entry for each index. Only do it once at the beginning.
900
901         Test: storage/indexeddb/queued-commands.html
902             + index-basics.html modified
903
904         * storage/IDBFactoryBackendImpl.cpp:
905         (WebCore::createTables):
906         * storage/IDBObjectStoreBackendImpl.cpp:
907         (WebCore::deleteIndexData):
908         (WebCore::putIndexData):
909         (WebCore::IDBObjectStoreBackendImpl::putInternal):
910
911 2010-10-19  Martin Robinson  <mrobinson@igalia.com>
912
913         Fix the GTK+ build after r70072. The logic looks incorrect, but
914         this fix tries to preserves it, even so.
915
916         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
917         (baselinePositionForAccessibilityRenderObject):
918         (getAttributeSetForAccessibilityObject):
919
920 2010-10-06  Jer Noble  <jer.noble@apple.com>
921
922         Reviewed by Eric Carlson.
923
924         Windows: Implement 'preload=none'
925         https://bugs.webkit.org/show_bug.cgi?id=47317
926         <rdar://problem/7718442>
927         
928         Implement the 'preload=none' identically to the mac implementation. Add three new
929         ivars: m_preload, m_delayLoad and m_movieURL; and override the MediaPlayerPrivate
930         functions: prepareToPlay() and setPreload().
931
932         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
933         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
934             Initialize new ivars m_delayLoad and m_preload.
935         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::resumeLoad): Added; new.
936         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::load): Split contents between
937             load and loadInternal.
938         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::loadInternal): Added; new.
939         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::prepareToPlay): Added; overrides MediaPlayerPrivate.
940         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPreload): Added; overrides MediaPlayerPrivate.
941         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
942         
943 2010-10-19  Enrica Casucci  <enrica@apple.com>
944
945         Reviewed by Alexey Proskuryakov.
946
947         Upstream support of KeyCodes for iOS
948         https://bugs.webkit.org/show_bug.cgi?id=47857
949         
950         * platform/cocoa/KeyEventCocoa.mm:
951         (WebCore::windowsKeyCodeForCharCode): Added special handling of keyCodes for iOS.
952
953 2010-10-19  Joseph Pecoraro  <joepeck@webkit.org>
954
955         Reviewed by David Kilzer.
956
957         iOS: ASSERT in Cache::adjustSize running layout tests
958         https://bugs.webkit.org/show_bug.cgi?id=47873
959
960         Inside Cache::pruneDeadResources we loop over the LRU lists and make resources purgeable
961         with Cache::makeResourcePurgeable(). This wasn't taking into account whether the resource
962         was already purgeable or not, and the makeResourcePurgeable call was always calling
963         adjustSize(). Now we make sure makeResourcePurgable only adjusts the size of the Cache's
964         dead sizes when it first marks the resource purgeable. Likewise, if a resource is marked
965         as purgeable and then evicted, we should not adjust the size again.
966
967         The balancing call is when we have a resource that has been marked as purgeable and we
968         successfully mark it as no longer purgeable in Cache::resourceForURL.
969
970         No test added because this requires testing purgeable memory.
971
972         * loader/Cache.cpp:
973         (WebCore::Cache::makeResourcePurgeable):
974         (WebCore::Cache::evict):
975
976 2010-10-19  Vangelis Kokkevis  <vangelis@chromium.org>
977
978         Reviewed by Kenneth Russell.
979
980         [chromium] Disable mipmapping for ImageLayer's to prevent memory use and
981         performance regression.
982         https://bugs.webkit.org/show_bug.cgi?id=47913
983         
984         This patch is a straight revert of the patch committed with issue 46493
985
986         * platform/graphics/chromium/ContentLayerChromium.cpp:
987         (WebCore::ContentLayerChromium::SharedValues::SharedValues):
988         (WebCore::ContentLayerChromium::updateTextureRect):
989         * platform/graphics/chromium/ContentLayerChromium.h:
990         (WebCore::ContentLayerChromium::SharedValues::initialized):
991         * platform/graphics/chromium/ImageLayerChromium.cpp:
992         (WebCore::ImageLayerChromium::updateContents):
993
994 2010-10-18  Zhenyao Mo  <zmo@google.com>
995
996         Reviewed by Kenneth Russell.
997
998         gl-teximage.html fails on chromium webkit mac bot
999         https://bugs.webkit.org/show_bug.cgi?id=47034
1000
1001         * platform/graphics/GraphicsContext3D.cpp: Deal with endians in 16 bit image data.
1002         (WebCore::convertColor16LittleTo8):
1003         (WebCore::convertColor16BigTo8):
1004         (WebCore::doPacking):
1005         * platform/graphics/GraphicsContext3D.h: Ditto.
1006         * platform/graphics/cg/GraphicsContext3DCG.cpp: Ditto.
1007         (WebCore::GraphicsContext3D::getImageData):
1008
1009 2010-10-19  David Hyatt  <hyatt@apple.com>
1010
1011         Reviewed by Dan Bernstein.
1012
1013         https://bugs.webkit.org/show_bug.cgi?id=47841
1014
1015         Rework baselinePosition and lineHeight to be writing-mode-aware.  There's a lot of refactoring here to clean up
1016         the method parameters to be more readable and to simplify the subclassing of the various methods in order to 
1017         keep the horizontal/vertical querying to a minimum.
1018
1019         * WebCore.xcodeproj/project.pbxproj:
1020         * mathml/RenderMathMLFraction.cpp:
1021         (WebCore::RenderMathMLFraction::baselinePosition):
1022         * mathml/RenderMathMLFraction.h:
1023         * mathml/RenderMathMLOperator.cpp:
1024         (WebCore::RenderMathMLOperator::baselinePosition):
1025         * mathml/RenderMathMLOperator.h:
1026         * mathml/RenderMathMLRow.cpp:
1027         (WebCore::RenderMathMLRow::baselinePosition):
1028         * mathml/RenderMathMLRow.h:
1029         * mathml/RenderMathMLSubSup.cpp:
1030         (WebCore::RenderMathMLSubSup::baselinePosition):
1031         * mathml/RenderMathMLSubSup.h:
1032         * mathml/RenderMathMLUnderOver.cpp:
1033         (WebCore::RenderMathMLUnderOver::layout):
1034         (WebCore::RenderMathMLUnderOver::baselinePosition):
1035         * mathml/RenderMathMLUnderOver.h:
1036         * rendering/InlineBox.h:
1037         (WebCore::InlineBox::baselinePosition):
1038         (WebCore::InlineBox::lineHeight):
1039         * rendering/InlineFlowBox.cpp:
1040         (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
1041         (WebCore::InlineFlowBox::computeLogicalBoxHeights):
1042         (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
1043         * rendering/InlineTextBox.cpp:
1044         (WebCore::InlineTextBox::baselinePosition):
1045         (WebCore::InlineTextBox::lineHeight):
1046         * rendering/InlineTextBox.h:
1047         * rendering/RenderBR.cpp:
1048         (WebCore::RenderBR::lineHeight):
1049         * rendering/RenderBR.h:
1050         (WebCore::toRenderBR):
1051         * rendering/RenderBlock.cpp:
1052         (WebCore::RenderBlock::lineHeight):
1053         (WebCore::RenderBlock::baselinePosition):
1054         (WebCore::RenderBlock::firstLineBoxBaseline):
1055         (WebCore::RenderBlock::lastLineBoxBaseline):
1056         (WebCore::RenderBlock::localCaretRect):
1057         * rendering/RenderBlock.h:
1058         * rendering/RenderBlockLineLayout.cpp:
1059         (WebCore::RenderBlock::layoutInlineChildren):
1060         * rendering/RenderBox.cpp:
1061         (WebCore::RenderBox::lineHeight):
1062         (WebCore::RenderBox::baselinePosition):
1063         * rendering/RenderBox.h:
1064         * rendering/RenderBoxModelObject.cpp:
1065         (WebCore::RenderBoxModelObject::verticalPosition):
1066         * rendering/RenderBoxModelObject.h:
1067         * rendering/RenderFileUploadControl.cpp:
1068         (WebCore::RenderFileUploadControl::paintObject):
1069         * rendering/RenderFlexibleBox.cpp:
1070         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
1071         (WebCore::RenderFlexibleBox::layoutVerticalBox):
1072         * rendering/RenderInline.cpp:
1073         (WebCore::RenderInline::lineHeight):
1074         (WebCore::RenderInline::baselinePosition):
1075         * rendering/RenderInline.h:
1076         * rendering/RenderListBox.cpp:
1077         (WebCore::RenderListBox::baselinePosition):
1078         * rendering/RenderListBox.h:
1079         * rendering/RenderListMarker.cpp:
1080         (WebCore::RenderListMarker::lineHeight):
1081         (WebCore::RenderListMarker::baselinePosition):
1082         * rendering/RenderListMarker.h:
1083         * rendering/RenderObject.cpp:
1084         * rendering/RenderObject.h:
1085         * rendering/RenderReplaced.cpp:
1086         * rendering/RenderReplaced.h:
1087         * rendering/RenderSVGRoot.cpp:
1088         * rendering/RenderSVGRoot.h:
1089         * rendering/RenderSlider.cpp:
1090         (WebCore::RenderSlider::baselinePosition):
1091         * rendering/RenderSlider.h:
1092         * rendering/RenderTableCell.cpp:
1093         (WebCore::RenderTableCell::baselinePosition):
1094         * rendering/RenderTableCell.h:
1095         * rendering/RenderTableCol.h:
1096         (WebCore::RenderTableCol::isTableCol):
1097         * rendering/RenderTableRow.h:
1098         * rendering/RenderTableSection.h:
1099         * rendering/RenderText.cpp:
1100         * rendering/RenderText.h:
1101         * rendering/RenderTextControl.cpp:
1102         (WebCore::RenderTextControl::computeLogicalHeight):
1103         * rendering/RenderTextControlMultiLine.cpp:
1104         (WebCore::RenderTextControlMultiLine::baselinePosition):
1105         * rendering/RenderTextControlMultiLine.h:
1106         * rendering/RenderTextControlSingleLine.cpp:
1107         (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
1108         * rendering/RootInlineBox.h:
1109         (WebCore::RootInlineBox::baselinePosition):
1110         (WebCore::RootInlineBox::lineHeight):
1111         * rendering/svg/SVGInlineTextBox.cpp:
1112         (WebCore::SVGInlineTextBox::calculateBoundaries):
1113
1114 2010-10-19  Jia Pu  <jpu@apple.com>
1115
1116         Reviewed by Adele Peterson.
1117
1118         Moving cursor back to autocorrected word in the same line shouldn't remove the underline
1119         https://bugs.webkit.org/show_bug.cgi?id=47629
1120         <rdar://problem/8546758>
1121
1122         Tests: platform/mac/editing/spelling/click-autocorrected-word.html
1123                platform/mac/editing/spelling/delete-into-autocorrected-word.html
1124                platform/mac/editing/spelling/delete-into-misspelled-word.html
1125                platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
1126                platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
1127                platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
1128                platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
1129
1130         * editing/Editor.cpp:
1131         (WebCore::Editor::respondToChangedSelection): Don't remove misspelling or autocorrection
1132           underlines when cursor is moved onto a word.
1133
1134 2010-10-19  Eric Carlson  <eric.carlson@apple.com>
1135
1136         Not reviewed. Build fix.
1137
1138         * html/HTMLMediaElement.cpp:
1139         (WebCore::HTMLMediaElement::selectNextSourceChild): Initialize variable to avoid Windows
1140         "potentially uninitialized local variable" warning.
1141
1142 2010-10-19  Eric Carlson  <eric.carlson@apple.com>
1143
1144         Reviewed by Darin Adler.
1145
1146         https://bugs.webkit.org/show_bug.cgi?id=46763
1147         CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal
1148
1149         Fix crashes caused by moving and deleting <source> element(s) of active media element.
1150
1151         Tests: media/video-source-moved.html
1152                media/video-source-removed.html
1153
1154         * html/HTMLMediaElement.cpp:
1155         (WebCore::HTMLMediaElement::HTMLMediaElement): Add logging. Initialize selectNextSourceChild.
1156         (WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto.
1157         (WebCore::HTMLMediaElement::insertedIntoDocument): Ditto.
1158         (WebCore::HTMLMediaElement::removedFromDocument): Ditto.
1159         (WebCore::HTMLMediaElement::scheduleLoad): Ditto.
1160         (WebCore::HTMLMediaElement::setNetworkState): Deal with m_currentSourceNode being null when
1161         the media engine signals a failure by skipping the error message and continuing as usual.
1162         (WebCore::HTMLMediaElement::setVolume): Fix logging typo.
1163         (WebCore::HTMLMediaElement::havePotentialSourceChild): Save and restore m_nextChildNodeToConsider
1164         around call to selectNextSourceChild because they are both significant.
1165         (WebCore::HTMLMediaElement::selectNextSourceChild): Use m_nextChildNodeToConsider to pick
1166         the first node to consider. Bail immediately if it signals that we have already processed 
1167         every <source> node. Stach the node following the current source element in m_nextChildNodeToConsider
1168         so we can resume the search even if m_currentSourceNode is removed while it is being processed.
1169         (WebCore::HTMLMediaElement::sourceWasAdded): New, move logic from HTMLSourceElement::insertedIntoTree
1170         here and correct it to deal with a <source> node being inserted immediately after the
1171         current <source> node and a new <source> node being inserted at the end of the list after
1172         all candidates have failed.
1173         (WebCore::HTMLMediaElement::sourceWillBeRemoved): New, deal with current source node and next
1174         potential node being removed.
1175         * html/HTMLMediaElement.h:
1176         (WebCore::HTMLMediaElement::sourceChildEndOfListValue): New, define sentinal value used to indicate
1177         that all nodes have been processed.
1178
1179         * html/HTMLSourceElement.cpp:
1180         (WebCore::HTMLSourceElement::HTMLSourceElement): Add logging.
1181         (WebCore::HTMLSourceElement::insertedIntoTree): Call mediaElement->sourceWasAdded instead
1182         of having logic here.
1183         (WebCore::HTMLSourceElement::willRemove): New, call mediaElement->sourceWillBeRemoved
1184         (WebCore::HTMLSourceElement::scheduleErrorEvent): Add logging.
1185         (WebCore::HTMLSourceElement::cancelPendingErrorEvent): Add logging.
1186         * html/HTMLSourceElement.h:
1187
1188 2010-10-19  Luiz Agostini  <luiz.agostini@openbossa.org>
1189
1190         Reviewed by Antti Koivisto.
1191
1192         [Qt] WebKit2 MacOS build fix
1193         https://bugs.webkit.org/show_bug.cgi?id=47897
1194
1195         Qt WebKit2 MacOS build fix.
1196
1197         * bridge/npapi.h:
1198
1199 2010-10-19  Philippe Normand  <pnormand@igalia.com>
1200
1201         Reviewed by Xan Lopez.
1202
1203         [GTK] Soup cache code still has some warnings
1204         https://bugs.webkit.org/show_bug.cgi?id=47733
1205
1206         Fixed some compilation warnings happening with gcc 4.4.5 on
1207         64-bits architecture.
1208
1209         * platform/network/soup/cache/webkit/soup-cache.c:
1210         (webkit_soup_cache_entry_set_freshness):
1211         (close_ready_cb):
1212
1213 2010-10-19  Yury Semikhatsky  <yurys@chromium.org>
1214
1215         Reviewed by Pavel Feldman.
1216
1217         Web Inspector: crash while trying to step over a function using inspector
1218         https://bugs.webkit.org/show_bug.cgi?id=47902
1219
1220         * inspector/front-end/ScriptsPanel.js:
1221         (WebInspector.ScriptsPanel.prototype.reset): reset scripts panel to resumed state on navigation.
1222
1223 2010-10-19  Ryuan Choi  <ryuan.choi@samsung.com>
1224
1225         Unreviewed attempt to remove warning in EFL build.
1226
1227         Fix #if to #ifdef.
1228
1229         No new features, so no tests added.
1230
1231         * platform/efl/WidgetEfl.cpp:
1232         (WebCore::Widget::applyFallbackCursor):
1233
1234 2010-10-19  Andreas Kling  <kling@webkit.org>
1235
1236         Reviewed by Tor Arne Vestbø.
1237
1238         [Qt] getImageData returns wrong data for non-0,0 source offset
1239         https://bugs.webkit.org/show_bug.cgi?id=47898
1240
1241         Test: fast/canvas/canvas-getImageData-negative-source.html
1242
1243         * platform/graphics/qt/ImageBufferQt.cpp:
1244         (WebCore::getImageData): Add missing *4's to get correct pixel offset.
1245
1246 2010-10-19  Andreas Kling  <kling@webkit.org>
1247
1248         Reviewed by Kenneth Rohde Christiansen.
1249
1250         [Qt] Correct initial state of ImageBuffer QPen
1251         https://bugs.webkit.org/show_bug.cgi?id=47804
1252
1253         Have the QPen on ImageBuffers start in Qt::SvgMiterJoin mode.
1254
1255         * platform/graphics/qt/ImageBufferQt.cpp:
1256         (WebCore::ImageBufferData::ImageBufferData):
1257
1258 2010-10-19  Philippe Normand  <pnormand@igalia.com>
1259
1260         Reviewed by Martin Robinson.
1261
1262         GStreamer PlatformVideoWindow needs an API to prepare the widget before applying the overlay
1263         https://bugs.webkit.org/show_bug.cgi?id=46790
1264
1265         Simple API addition to PlatformVideoWindow to allow
1266         implementations to optionally prepare their own PlatformWidget
1267         before applying the GStreamer XOverlay to it. This will likely be
1268         needed on Mac OSX only.
1269
1270         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
1271         (WebCore::GStreamerGWorld::setWindowOverlay):
1272         * platform/graphics/gstreamer/PlatformVideoWindow.h:
1273         * platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:
1274         (PlatformVideoWindow::prepareForOverlay):
1275         * platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp:
1276         (PlatformVideoWindow::prepareForOverlay):
1277
1278 2010-10-19  Ben Murdoch  <benm@google.com>
1279
1280         Reviewed by Steve Block.
1281
1282         Missing support for document.createTouch and document.createTouchList
1283         https://bugs.webkit.org/show_bug.cgi?id=47676
1284
1285         These APIs are used by many sites to detect support for touch events.
1286
1287         Implement the APIs according to the documentation at:
1288         http://developer.apple.com/library/safari/#documentation/UserExperience/Reference/DocumentAdditionsReference/DocumentAdditions/DocumentAdditions.html
1289
1290         Tests: fast/events/touch/document-create-touch-list.html
1291                fast/events/touch/document-create-touch.html
1292
1293         * bindings/js/JSBindingsAllInOne.cpp: Add new files to list.
1294         * bindings/js/JSTouchCustom.cpp: Added.
1295         (WebCore::toJSNewlyCreated):
1296         * bindings/js/JSTouchListCustom.cpp: Added.
1297         (WebCore::toJSNewlyCreated):
1298         * bindings/scripts/CodeGeneratorJS.pm:
1299         * dom/Document.cpp:
1300         (WebCore::Document::createTouch):
1301         (WebCore::Document::createTouchList):
1302         * dom/Document.h:
1303         * dom/Document.idl: Add createTouch and createTouchList functions.
1304         * Android.jscbindings.mk: Update makefiles.
1305         * CMakeLists.txt: Ditto.
1306         * GNUmakefile.am: Ditto.
1307         * WebCore.gypi: Ditto.
1308         * WebCore.pro: Ditto.
1309
1310
1311 2010-10-19  Pavel Feldman  <pfeldman@chromium.org>
1312
1313         Reviewed by Yury Semikhatsky.
1314
1315         Web Inspector: migrate from legacy Object.properties to Object.keys, remove dead code.
1316         https://bugs.webkit.org/show_bug.cgi?id=47890
1317
1318         * inspector/front-end/ConsoleView.js:
1319         (WebInspector.ConsoleView.prototype._reportCompletions):
1320         * inspector/front-end/ElementsPanel.js:
1321         (WebInspector.ElementsPanel):
1322         * inspector/front-end/ExtensionServer.js:
1323         (WebInspector.ExtensionServer.prototype._onGetResources):
1324         * inspector/front-end/HAREntry.js:
1325         (WebInspector.HARLog.prototype.build):
1326         * inspector/front-end/StylesSidebarPane.js:
1327         (WebInspector.StylePropertyTreeElement.prototype.):
1328         (WebInspector.StylePropertyTreeElement.prototype):
1329         * inspector/front-end/utilities.js:
1330
1331 2010-10-19  Pavel Feldman  <pfeldman@chromium.org>
1332
1333         Reviewed by Yury Semikhatsky.
1334
1335         Web Inspector: do not access ResourcePanel from resources directly.
1336         https://bugs.webkit.org/show_bug.cgi?id=47892
1337
1338         * inspector/front-end/Resource.js:
1339         (WebInspector.Resource.prototype.set documentURL):
1340         (WebInspector.Resource.prototype.set startTime):
1341         (WebInspector.Resource.prototype.set responseReceivedTime):
1342         (WebInspector.Resource.prototype.set endTime):
1343         (WebInspector.Resource.prototype.set resourceSize):
1344         (WebInspector.Resource.prototype.set expectedContentLength):
1345         (WebInspector.Resource.prototype.set category):
1346         (WebInspector.Resource.prototype.set cached):
1347         (WebInspector.Resource.prototype.set mimeType):
1348         (WebInspector.Resource.prototype.get requestHeaders):
1349         (WebInspector.Resource.prototype.set requestHeaders):
1350         (WebInspector.Resource.prototype.get responseHeaders):
1351         (WebInspector.Resource.prototype.set responseHeaders):
1352         * inspector/front-end/ResourcesPanel.js:
1353         (WebInspector.ResourcesPanel.prototype.addResource):
1354         (WebInspector.ResourcesPanel.prototype.refreshResource):
1355         (WebInspector.ResourcesPanel.prototype._recreateViewForResourceIfNeeded):
1356         (WebInspector.ResourcesPanel.prototype._resourceViewIsConsistentWithCategory):
1357         (WebInspector.ResourceGraph):
1358         (WebInspector.ResourceGraph.prototype.refresh):
1359         * inspector/front-end/inspector.js:
1360         (WebInspector.updateResource):
1361
1362 2010-10-19  Yuta Kitamura  <yutak@chromium.org>
1363
1364         Reviewed by Pavel Feldman.
1365
1366         Make sure WebSocket resource has the url field when it is created.
1367
1368         Web Inspector: Uncaught TypeError when connection to WebSocket server is refused
1369         https://bugs.webkit.org/show_bug.cgi?id=47891
1370
1371         * inspector/InspectorResource.cpp:
1372         (WebCore::InspectorResource::createWebSocket):
1373
1374 2010-10-19  Hayato Ito  <hayato@chromium.org>
1375
1376         Reviewed by Darin Adler.
1377
1378         Make CSS style selector non-recursive.
1379         https://bugs.webkit.org/show_bug.cgi?id=43783
1380
1381         This change is one of the required changes to fix the following master bug:
1382         https://bugs.webkit.org/show_bug.cgi?id=42806
1383
1384         To avoid recursion, we prepare a call stack and maintain a list of
1385         function call state by ourselves and try matching iteratively.
1386
1387         Test: fast/css/long-css-selector-matches.html
1388
1389         * css/CSSStyleSelector.cpp:
1390         (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
1391         (WebCore::CSSStyleSelector::checkSelector):
1392         * css/CSSStyleSelector.h:
1393
1394 2010-10-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1395
1396         Unreviewed, rolling out r70034.
1397         http://trac.webkit.org/changeset/70034
1398         https://bugs.webkit.org/show_bug.cgi?id=47889
1399
1400         "Gustavo's bot is lame" (Requested by xan_ on #webkit).
1401
1402         * platform/network/soup/CookieJarSoup.cpp:
1403         (WebCore::defaultCookieJar):
1404         (WebCore::setCookies):
1405         * platform/network/soup/ResourceHandleSoup.cpp:
1406         (WebCore::ResourceHandle::prepareForURL):
1407         (WebCore::restartedCallback):
1408         (WebCore::startHttp):
1409         * platform/network/soup/ResourceRequestSoup.cpp:
1410         (WebCore::ResourceRequest::toSoupMessage):
1411         (WebCore::ResourceRequest::updateFromSoupMessage):
1412
1413 2010-10-19  Xan Lopez  <xlopez@igalia.com>
1414
1415         Reviewed by Martin Robinson.
1416
1417         [GTK] Bump minimum requirement for libsoup to 2.30
1418         https://bugs.webkit.org/show_bug.cgi?id=46176
1419
1420         Bump minimum required libsoup version to 2.30.
1421
1422         * platform/network/soup/CookieJarSoup.cpp:
1423         (WebCore::defaultCookieJar):
1424         (WebCore::setCookies):
1425         * platform/network/soup/ResourceHandleSoup.cpp:
1426         (WebCore::ResourceHandle::prepareForURL):
1427         (WebCore::restartedCallback):
1428         (WebCore::startHttp):
1429         * platform/network/soup/ResourceRequestSoup.cpp:
1430         (WebCore::ResourceRequest::toSoupMessage):
1431         (WebCore::ResourceRequest::updateFromSoupMessage):
1432
1433 2010-10-19  Xan Lopez  <xlopez@igalia.com>
1434
1435         Reviewed by Martin Robinson.
1436
1437         Fix distcheck, take 2.
1438
1439         * GNUmakefile.am: also move the generated CSS hash files to the
1440         build dir.
1441
1442 2010-10-18  Kent Tamura  <tkent@chromium.org>
1443
1444         Reviewed by Dimitri Glazkov.
1445
1446         Should not save state of a detached form control.
1447         https://bugs.webkit.org/show_bug.cgi?id=47811
1448
1449         Test: fast/forms/state-save-of-detached-control.html
1450
1451         * html/HTMLFormControlElement.cpp:
1452         (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
1453           If the node is detached, don't save the state.
1454
1455 2010-10-18  Xan Lopez  <xlopez@igalia.com>
1456
1457         Reviewed by Martin Robinson.
1458
1459         * GNUmakefile.am: add missing files.
1460
1461 2010-10-18  Oliver Hunt  <oliver@apple.com>
1462
1463         Reviewed by Sam Weinig.
1464
1465         REGRESSION: Feedly extension crashes Webkit
1466         https://bugs.webkit.org/show_bug.cgi?id=45811
1467
1468         The basic problem was the deserializer was holding a pointer into
1469         the constant pool, but if you were sufficiently unlucky then the
1470         constant pool would be moved while still relying on the pointer,
1471         which leads to badness.
1472
1473         I looked at just making all the sites this could happen extract the
1474         right string/jsstring before any possible allocations, but it seemed
1475         too fragile so i've gone for a forwarding object as the solution.
1476
1477         * bindings/js/SerializedScriptValue.cpp:
1478         (WebCore::CloneDeserializer::CachedStringRef::CachedStringRef):
1479         (WebCore::CloneDeserializer::CachedStringRef::operator->):
1480         (WebCore::CloneDeserializer::readStringData):
1481         (WebCore::CloneDeserializer::readFile):
1482         (WebCore::CloneDeserializer::readTerminal):
1483         (WebCore::CloneDeserializer::deserialize):
1484
1485 2010-10-18  Chris Rogers  <crogers@google.com>
1486
1487         Reviewed by Chris Fleizach.
1488
1489         Add AudioResampler files
1490         https://bugs.webkit.org/show_bug.cgi?id=47623
1491
1492         No new tests since audio API is not yet implemented.
1493
1494         * platform/audio/AudioResampler.cpp: Added.
1495         (WebCore::AudioResampler::AudioResampler):
1496         (WebCore::AudioResampler::configureChannels):
1497         (WebCore::AudioResampler::process):
1498         (WebCore::AudioResampler::setRate):
1499         (WebCore::AudioResampler::reset):
1500         * platform/audio/AudioResampler.h: Added.
1501         (WebCore::AudioResampler::~AudioResampler):
1502         (WebCore::AudioResampler::rate):
1503
1504 2010-10-18  Vangelis Kokkevis  <vangelis@chromium.org>
1505
1506         Reviewed by James Robinson.
1507
1508         [chromium] Prevent the creation of very large textures for layers by switching
1509         to "large layer" mode when a texture is larger than some fixed reasonable size
1510         (set to 2000 pixels for now).
1511         https://bugs.webkit.org/show_bug.cgi?id=47751
1512
1513         The code also changes the large layer logic to use the current scissor rect used
1514         by the compositor instead of the visible rect to determine how to clip large layers.
1515         This will provide additional texture savings. In addition, the various layer rects
1516         have been converted to use integers instead of floats to preserve uniformity in the code.
1517         
1518         Tests: Existing large layer layout tests including huge-layer and huge-layer-img
1519
1520         * platform/graphics/chromium/ContentLayerChromium.cpp:
1521         (WebCore::ContentLayerChromium::requiresClippedUpdateRect):
1522         (WebCore::ContentLayerChromium::calculateClippedUpdateRect):
1523         * platform/graphics/chromium/LayerChromium.cpp:
1524         (WebCore::LayerChromium::getDrawRect):
1525         * platform/graphics/chromium/LayerChromium.h:
1526         * platform/graphics/chromium/LayerRendererChromium.cpp:
1527         (WebCore::LayerRendererChromium::drawLayers):
1528         (WebCore::LayerRendererChromium::drawLayersRecursive):
1529         (WebCore::LayerRendererChromium::scissorToRect):
1530         * platform/graphics/chromium/LayerRendererChromium.h:
1531         (WebCore::LayerRendererChromium::currentScissorRect):
1532
1533 2010-10-18  Jia Pu  <jpu@apple.com>
1534
1535         Reviewed by Stephanie Lewis.
1536
1537         Correct the description of manual test: autocorrection-cancelled-by-typing-1.html
1538         https://bugs.webkit.org/show_bug.cgi?id=47722
1539         <rdar://problem/8556206>
1540
1541         * manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Update description
1542           to match the test content.
1543
1544 2010-10-18  Martin Robinson  <mrobinson@igalia.com>
1545
1546         Build fix for newer versions of GTK+ 2.0. Instead of using GDK_DISPLAY()
1547         use GDK_DRAWABLE_XDISPLAY(gdk_display_get_default()). GDK_DISPLAY() was
1548         recently deprecated and the latter method has been available since GTK+
1549         2.2.
1550
1551         * plugins/gtk/PluginViewGtk.cpp:
1552         (WebCore::PluginView::updatePluginWidget):
1553         (WebCore::PluginView::paint):
1554         (WebCore::PluginView::initXEvent):
1555         (WebCore::PluginView::platformGetValue):
1556         (WebCore::getVisualAndColormap):
1557         (WebCore::PluginView::platformStart):
1558         (WebCore::PluginView::platformDestroy):
1559
1560 2010-10-18  Ryosuke Niwa  <rniwa@webkit.org>
1561
1562         Reviewed by Adam Barth.
1563
1564         elementCannotHaveEndTag should be a member function of MarkupAccumulator
1565         https://bugs.webkit.org/show_bug.cgi?id=47846
1566
1567         Moved elementCannotHaveEndTag into MarkupAccumulator.
1568
1569         No new tests are added since this is a cleanup.
1570
1571         * editing/MarkupAccumulator.cpp:
1572         (WebCore::MarkupAccumulator::elementCannotHaveEndTag): Added.
1573         * editing/MarkupAccumulator.h: Added MarkupAccumulator::elementCannotHaveEndTag.
1574         * editing/markup.cpp: Removed elementCannotHaveEndTag.
1575         * editing/markup.h: Removed elementCannotHaveEndTag.
1576
1577 2010-10-18  Johnny Ding  <jnd@chromium.org>
1578
1579         Reviewed by Adam Barth.
1580
1581         Set the right referent sourceURL for the script with force user gesture.
1582         https://bugs.webkit.org/show_bug.cgi?id=37138
1583
1584         Because empty sourceURL indicates running script with force user gesture,
1585         make WebKit use document.url() as referent sourceURL (Since it uses blank
1586         URL instead empty if the input URL is empty) if WebKit isn't running the
1587         script from a hyper-link.
1588
1589         Test: fast/events/popup-blocked-from-window-open.html
1590
1591         * bindings/ScriptControllerBase.cpp:
1592         (WebCore::ScriptController::executeScript):
1593         * bindings/js/ScriptController.cpp:
1594         (WebCore::ScriptController::executeScriptInWorld):
1595
1596 2010-10-18  Darin Adler  <darin@apple.com>
1597
1598         * dom/Node.h: Fix ancient typo in just-modified comment.
1599
1600 2010-10-18  Darin Adler  <darin@apple.com>
1601
1602         Reviewed by Alexey Proskuryakov.
1603
1604         Remove some functions from class Node and make a few others non-virtual
1605         https://bugs.webkit.org/show_bug.cgi?id=47735
1606
1607         Refactoring. No new tests.
1608
1609         * bindings/js/JSNodeCustom.cpp:
1610         (WebCore::JSNode::markChildren): Added a FIXME about the use of the virtual
1611         ownerDocument function.
1612
1613         * dom/ContainerNode.cpp:
1614         (WebCore::ContainerNode::removeChildren): Removed the unused return value.
1615
1616         * dom/ContainerNode.h: Made insertBefore, replaceChild, removeChild, and
1617         appendChild non-virtual for clarity and performance. Made removeChildren
1618         non-virtual and removed its return value. Moved the inline Node functions
1619         that call through to ContainerNode into this file since the old way involved
1620         an extra level of inline function but otherwise had no advantages.
1621
1622         * dom/Element.h: Moved isMathMLElement here because there is no call site
1623         that needs to call it on a Node*. We can always move it back if we need to,
1624         but it's better to have less in the Node class.
1625
1626         * dom/Node.cpp:
1627         (WebCore::Node::insertBefore): Added an isContainerNode check so this can
1628         be non-virtual. There are very few callers who call this function on Node.
1629         If we want to optimize them further we can make the isContainerNode check
1630         inline in the future.
1631         (WebCore::Node::replaceChild): Ditto.
1632         (WebCore::Node::removeChild): Ditto.
1633         (WebCore::Node::appendChild): Ditto.
1634         (WebCore::Node::remove): Removed unneeded ref/unref because
1635         ContainerNode::removeChild already does this.
1636         (WebCore::Node::createRendererIfNeeded): Removed #if around call to
1637         childShouldCreateRenderer since it's needed even without SVG and XHTMLMP.
1638
1639         * dom/Node.h: Moved definitions of inline functions that depend on
1640         ContainerNode to the ContainerNode.h header. They already required inclusion
1641         of that header, so there is no functional change. Made insertBefore,
1642         replaceChild, removeChild, and appendChild non-virtual. There are very few
1643         callers of these functions on this class. Moved isMathMLElement to Element.
1644         Added a FIXME about the name of eventAncestors. Fixed comment formatting.
1645         Eliminated unused isEditableBlock function. Moved the body of the
1646         enclosingInlineElement function to the editing file that was the only
1647         call site. Removed the previousEditable and nextEditable functions,
1648         incorporating their bodies into the one place they were called.
1649         Took the childShouldCreateRenderer function out of #if since it's
1650         now used by the implementation of the <noscript> element.
1651
1652         * dom/Position.cpp:
1653         (WebCore::nextRenderedEditable): Rewrote the function to use nextLeafNode
1654         instead of nextEditable.
1655         (WebCore::previousRenderedEditable): Rewrote the function to use
1656         previousLeafNode instead of previousEditable.
1657
1658         * editing/ReplaceSelectionCommand.cpp:
1659         (WebCore::enclosingInline): Moved function here from the Node class. Also
1660         fixed an incorrect cast this function did, which assumed the function
1661         result was always an element, which the function does not guarantee.
1662         (WebCore::ReplaceSelectionCommand::doApply): Call the function above.
1663
1664         * history/HistoryItem.cpp: Added include of MathExtras.h.
1665
1666 2010-10-18  Yongjun Zhang  <yongjun_zhang@apple.com>
1667
1668         Reviewed by Darin Adler.
1669
1670         Missing support for document.createEvent("OrientationEvent")
1671         https://bugs.webkit.org/show_bug.cgi?id=32492
1672
1673         Add support for document.createEvent("OrientationEvent") to help unit testing of
1674         onOrientationChange event.
1675
1676         Test: fast/dom/DeviceOrientation/create-event-onorientationchange.html
1677
1678         * dom/Document.cpp:
1679         (WebCore::Document::createEvent):
1680
1681 2010-10-18  Jeremy Orlow  <jorlow@chromium.org>
1682
1683         Reviewed by Darin Adler.
1684
1685         DOMStringList should return null if the index is out of range
1686         https://bugs.webkit.org/show_bug.cgi?id=47829
1687
1688         When item() returns a null string, it needs to be passed to JS as
1689         null. The indexed getter will then magically do the right thing.
1690         So all that's left is having DOMStringList::item() return null when
1691         the index is out of bounds.
1692
1693         * dom/DOMStringList.cpp:
1694         (WebCore::DOMStringList::item):
1695         * dom/DOMStringList.h:
1696         * dom/DOMStringList.idl:
1697
1698 2010-10-18  Girish Ramakrishnan  <girish@forwardbias.in>
1699
1700         Reviewed by Ariya Hidayat.
1701
1702         [Qt] Implement Accelerated Composition for NPAPI Plugins.
1703
1704         https://bugs.webkit.org/show_bug.cgi?id=35524
1705
1706         * plugins/PluginView.h:
1707         (WebCore::PluginView::platformLayer):
1708         * plugins/qt/PluginViewQt.cpp:
1709         (WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt):
1710         (WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt):
1711         (WebCore::PluginGraphicsLayerQt::paint):
1712         (WebCore::PluginView::updatePluginWidget):
1713         (WebCore::PluginView::paint):
1714         (WebCore::PluginView::invalidateRect):
1715         (WebCore::PluginView::invalidateRegion):
1716         (WebCore::PluginView::platformStart):
1717         (WebCore::PluginView::platformLayer):
1718
1719 2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>
1720
1721         Reviewed by Eric Seidel.
1722
1723         Switch to using the new Carbon NPAPI event declarations, and remove
1724         the old ones.
1725
1726         https://bugs.webkit.org/show_bug.cgi?id=40784
1727
1728         * bridge/npapi.h:
1729         * plugins/mac/PluginViewMac.mm:
1730         (WebCore::PluginView::setFocus):
1731         (WebCore::PluginView::handleMouseEvent):
1732
1733 2010-10-18  Pavel Feldman  <pfeldman@chromium.org>
1734
1735         Reviewed by Yury Semikhatsky.
1736
1737         Web Inspector: comment out resource manager instantiation on front-end side.
1738         https://bugs.webkit.org/show_bug.cgi?id=47823
1739
1740         * inspector/front-end/inspector.js:
1741
1742 2010-10-18  Andrei Popescu  <andreip@google.com>
1743
1744         Reviewed by Jeremy Orlow.
1745
1746         The description parameter of IDBFactory::open() should be mandatory.
1747         https://bugs.webkit.org/show_bug.cgi?id=47835
1748
1749         Makes the description parameter mandatory, as per the IndexedDatabase specification.
1750         Modified existing tests to cover this change.
1751
1752         * storage/IDBDatabaseBackendImpl.cpp:
1753         (WebCore::extractMetaData):
1754         (WebCore::setMetaData):
1755         (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
1756         * storage/IDBFactory.cpp:
1757         (WebCore::IDBFactory::open):
1758         * storage/IDBFactory.h:
1759         * storage/IDBFactory.idl:
1760
1761 2010-10-18  Xiaomei Ji  <xji@chromium.org>
1762
1763         Reviewed by David Levin.
1764
1765         Code cleanup: Move most function members in TextRunWorker from inlined.
1766         https://bugs.webkit.org/show_bug.cgi?id=47732
1767
1768         No functionality change, so no tests added.
1769
1770         * platform/graphics/chromium/FontLinux.cpp:
1771         (WebCore::TextRunWalker::setWordSpacingAdjustment):
1772         (WebCore::TextRunWalker::setLetterSpacingAdjustment):
1773         (WebCore::TextRunWalker::setXOffsetToZero):
1774         (WebCore::TextRunWalker::rtl):
1775         (WebCore::TextRunWalker::glyphs):
1776         (WebCore::TextRunWalker::length):
1777         (WebCore::TextRunWalker::xPositions):
1778         (WebCore::TextRunWalker::advances):
1779         (WebCore::TextRunWalker::width):
1780         (WebCore::TextRunWalker::logClusters):
1781         (WebCore::TextRunWalker::numCodePoints):
1782         (WebCore::TextRunWalker::fontPlatformDataForScriptRun):
1783         (WebCore::TextRunWalker::isCodepointSpace):
1784         (WebCore::TextRunWalker::TextRunWalker):
1785         (WebCore::TextRunWalker::~TextRunWalker):
1786         (WebCore::TextRunWalker::isWordBreak):
1787         (WebCore::TextRunWalker::setPadding):
1788         (WebCore::TextRunWalker::reset):
1789         (WebCore::TextRunWalker::setBackwardsIteration):
1790         (WebCore::TextRunWalker::nextScriptRun):
1791         (WebCore::TextRunWalker::widthOfFullRun):
1792         (WebCore::TextRunWalker::getTextRun):
1793         (WebCore::TextRunWalker::getNormalizedTextRun):
1794         (WebCore::TextRunWalker::setupFontForScriptRun):
1795         (WebCore::TextRunWalker::allocHarfbuzzFont):
1796         (WebCore::TextRunWalker::deleteGlyphArrays):
1797         (WebCore::TextRunWalker::createGlyphArrays):
1798         (WebCore::TextRunWalker::resetGlyphArrays):
1799         (WebCore::TextRunWalker::shapeGlyphs):
1800         (WebCore::TextRunWalker::setGlyphXPositions):
1801         (WebCore::TextRunWalker::mirrorCharacters):
1802
1803 2010-10-18  No'am Rosenthal  <noam.rosenthal@nokia.com>
1804
1805         Reviewed by Andreas Kling.
1806
1807         [Qt] AC rendering bugs
1808         There were a few missing connections in Qt AC between GraphicsLayer and plugins, like changing the plugin's geometry to the layer's
1809         contentsRect, and making sure media layers handle ParentChange events and setContentsNeedsDisplay. Now media layers behave correctly.
1810
1811         https://bugs.webkit.org/show_bug.cgi?id=47571
1812
1813         No new tests. This is in preparation for fixing AC+plugins, which already has tests that don't work yet with Qt.
1814
1815         * platform/graphics/qt/GraphicsLayerQt.cpp:
1816         (WebCore::GraphicsLayerQtImpl::flushChanges):
1817         (WebCore::GraphicsLayerQt::setContentsNeedsDisplay):
1818         * platform/graphics/qt/GraphicsLayerQt.h:
1819
1820 2010-10-18  Pavel Feldman  <pfeldman@chromium.org>
1821
1822         Reviewed by Simon Fraser.
1823
1824         Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
1825         https://bugs.webkit.org/show_bug.cgi?id=46224
1826
1827         * CMakeLists.txt:
1828         * GNUmakefile.am:
1829         * WebCore.gypi:
1830         * WebCore.pro:
1831         * WebCore.vcproj/WebCore.vcproj:
1832         * WebCore.xcodeproj/project.pbxproj:
1833         * inspector/InspectorClient.cpp: Added.
1834         (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
1835         * inspector/InspectorClient.h:
1836         (WebCore::InspectorClient::InspectorClient):
1837
1838 2010-10-18  Andrei Popescu  <andreip@google.com>
1839
1840         Reviewed by Jeremy Orlow.
1841
1842         IDBKeyTree.h is no longer used.
1843         https://bugs.webkit.org/show_bug.cgi?id=47824
1844
1845         No new tests, just removing unused files.
1846
1847         * WebCore.gypi:
1848         * WebCore.xcodeproj/project.pbxproj:
1849         * storage/IDBKeyTree.h: Removed.
1850
1851 2010-10-18  Andreas Kling  <kling@webkit.org>
1852
1853         Unreviewed buildfix for Qt + V8.
1854         Add missing <wtf/text/CString.h> include.
1855
1856         * inspector/InspectorInstrumentation.cpp:
1857
1858 2010-10-18  Ilya Tikhonovsky  <loislo@chromium.org>
1859
1860         Reviewed by Yury Semikhatsky.
1861
1862         Web Inspector: toJSON serialization for Numbers should be fixed.
1863         DecimalNumber is used instead of printf.
1864
1865         https://bugs.webkit.org/show_bug.cgi?id=43832
1866
1867         * inspector/InspectorValues.cpp:
1868         (WebCore::InspectorBasicValue::writeJSON):
1869
1870 2010-10-18  Ilya Tikhonovsky  <loislo@chromium.org>
1871
1872         Reviewed by Yury Semikhatsky.
1873
1874         Web Inspector: [REGRESSION] Inspector window visible during run-webkit-tests.
1875         The initial state of an inspector setting should stay untouched
1876         if the profile has no value for it.
1877
1878         https://bugs.webkit.org/show_bug.cgi?id=47785
1879
1880         * inspector/InspectorState.cpp:
1881         (WebCore::InspectorState::loadFromSettings):
1882
1883 2010-10-18  Pavel Feldman  <pfeldman@chromium.org>
1884
1885         Reviewed by Yury Semikhatsky.
1886
1887         Web Inspector: tab headers on resource panel are 1px off on Mac.
1888         https://bugs.webkit.org/show_bug.cgi?id=47798
1889
1890         * inspector/front-end/inspector.css:
1891         (.tabbed-pane-header li):
1892
1893 2010-10-18  Pavel Feldman  <pfeldman@chromium.org>
1894
1895         Not reviewed. Build fix.
1896
1897         * inspector/InspectorResourceAgent.cpp:
1898         (WebCore::cachedResourceTypeString):
1899
1900 2010-10-17  Pavel Feldman  <pfeldman@chromium.org>
1901
1902         Reviewed by Yury Semikhatsky.
1903
1904         Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
1905         fill network panel with data.
1906         https://bugs.webkit.org/show_bug.cgi?id=47779
1907         
1908         InspectorResourceAgent instance / JS part are introduced in this patch. Agent's lifetime is equal
1909         to the front-end's. This new resource agent does not have state, instead it covers two functions:
1910          1) forwards loader client messages to the front-end 2) is capable of building a tree of cached resources.
1911         (1) feeds network panel with data, (2) shows the resource tree in the new ResourcesPanel concept.
1912         This bug is for extracting this new InspectorResourceAgent class and its javascript counterpart.
1913         Once resources panel is refactored for the new concept, InspectorResource, InspectorController's
1914         resource-related routines, inspector.js's code dealing with resources, they all will be gone.
1915
1916         * WebCore.gypi:
1917         * WebCore.vcproj/WebCore.vcproj:
1918         * inspector/CodeGeneratorInspector.pm:
1919         * inspector/Inspector.idl:
1920         * inspector/InspectorApplicationCacheAgent.cpp:
1921         (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
1922         * inspector/InspectorController.cpp:
1923         (WebCore::InspectorController::connectFrontend):
1924         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
1925         (WebCore::InspectorController::didCommitLoad):
1926         (WebCore::InspectorController::frameDetachedFromParent):
1927         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
1928         (WebCore::InspectorController::identifierForInitialRequest):
1929         (WebCore::InspectorController::willSendRequest):
1930         (WebCore::InspectorController::markResourceAsCached):
1931         (WebCore::InspectorController::didReceiveResponse):
1932         (WebCore::InspectorController::didReceiveContentLength):
1933         (WebCore::InspectorController::didFinishLoading):
1934         (WebCore::InspectorController::didFailLoading):
1935         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
1936         (WebCore::InspectorController::scriptImported):
1937         (WebCore::InspectorController::didCreateWebSocket):
1938         (WebCore::InspectorController::willSendWebSocketHandshakeRequest):
1939         (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse):
1940         (WebCore::InspectorController::didCloseWebSocket):
1941         * inspector/InspectorController.h:
1942         * inspector/InspectorResource.cpp:
1943         (WebCore::InspectorResource::updateResponse):
1944         (WebCore::cachedResourceType):
1945         (WebCore::InspectorResource::type):
1946         (WebCore::InspectorResource::sourceString):
1947         (WebCore::InspectorResource::sourceBytes):
1948         (WebCore::InspectorResource::endTiming):
1949         * inspector/InspectorResourceAgent.cpp:
1950         (WebCore::InspectorResourceAgent::resourceContent):
1951         (WebCore::InspectorResourceAgent::resourceContentBase64):
1952         (WebCore::InspectorResourceAgent::resourceData):
1953         (WebCore::InspectorResourceAgent::cachedResource):
1954         (WebCore::buildObjectForHeaders):
1955         (WebCore::buildObjectForTiming):
1956         (WebCore::buildObjectForResourceRequest):
1957         (WebCore::buildObjectForResourceResponse):
1958         (WebCore::buildObjectForMainResource):
1959         (WebCore::cachedResourceTypeString):
1960         (WebCore::buildObjectForCachedResource):
1961         (WebCore::buildObjectForFrameResources):
1962         (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
1963         (WebCore::InspectorResourceAgent::identifierForInitialRequest):
1964         (WebCore::InspectorResourceAgent::willSendRequest):
1965         (WebCore::InspectorResourceAgent::markResourceAsCached):
1966         (WebCore::InspectorResourceAgent::didReceiveResponse):
1967         (WebCore::InspectorResourceAgent::didReceiveContentLength):
1968         (WebCore::InspectorResourceAgent::didFinishLoading):
1969         (WebCore::InspectorResourceAgent::didFailLoading):
1970         (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
1971         (WebCore::InspectorResourceAgent::setOverrideContent):
1972         (WebCore::InspectorResourceAgent::didCommitLoad):
1973         (WebCore::InspectorResourceAgent::frameDetachedFromParent):
1974         (WebCore::createReadableStringFromBinary):
1975         (WebCore::InspectorResourceAgent::didCreateWebSocket):
1976         (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
1977         (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
1978         (WebCore::InspectorResourceAgent::didCloseWebSocket):
1979         (WebCore::InspectorResourceAgent::cachedResources):
1980         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
1981         * inspector/InspectorResourceAgent.h:
1982         (WebCore::InspectorResourceAgent::create):
1983         * inspector/InspectorStyleSheet.cpp:
1984         (WebCore::InspectorStyleSheet::resourceStyleSheetText):
1985         * inspector/front-end/ExtensionServer.js:
1986         (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
1987         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
1988         * inspector/front-end/Resource.js:
1989         (WebInspector.Resource.prototype.get responseReceivedTime):
1990         (WebInspector.Resource.prototype.set endTime):
1991         * inspector/front-end/Settings.js:
1992         * inspector/front-end/SourceView.js:
1993         (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
1994         * inspector/front-end/WebKit.qrc:
1995         * inspector/front-end/inspector.css:
1996         (.tabbed-pane-header li):
1997         * inspector/front-end/inspector.html:
1998         * inspector/front-end/inspector.js:
1999         (WebInspector.updateResource):
2000         * loader/ResourceLoadNotifier.cpp:
2001         (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
2002         * loader/appcache/ApplicationCacheGroup.cpp:
2003         (WebCore::ApplicationCacheGroup::didReceiveResponse):
2004
2005 2010-10-16  Pavel Feldman  <pfeldman@chromium.org>
2006
2007         Reviewed by Yury Semikhatsky.
2008
2009         Web Inspector: brush up URL parsing on the front-end.
2010         https://bugs.webkit.org/show_bug.cgi?id=47772
2011
2012         * inspector/InspectorResource.cpp:
2013         (WebCore::InspectorResource::updateScriptObject):
2014         * inspector/front-end/AuditRules.js:
2015         (WebInspector.AuditRules.getDomainToResourcesMap):
2016         (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
2017         (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
2018         (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
2019         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
2020         (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
2021         (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
2022         * inspector/front-end/CookieItemsView.js:
2023         (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
2024         * inspector/front-end/DOMAgent.js:
2025         (WebInspector.Cookies.cookieMatchesResourceURL):
2026         * inspector/front-end/Resource.js:
2027         (WebInspector.Resource):
2028         (WebInspector.Resource.prototype.set url):
2029         (WebInspector.Resource.prototype.get displayName):
2030         * inspector/front-end/ResourceCategory.js:
2031         (WebInspector.ResourceCategory.prototype.addResource):
2032         * inspector/front-end/ResourceView.js:
2033         (WebInspector.ResourceView):
2034         * inspector/front-end/inspector.js:
2035         (WebInspector.documentClick.followLink):
2036         (WebInspector.documentClick):
2037         (WebInspector.updateResource):
2038         (WebInspector.linkifyStringAsFragment):
2039         (WebInspector.resourceURLForRelatedNode):
2040         (WebInspector.completeURL):
2041         * inspector/front-end/utilities.js:
2042         (String.prototype.asParsedURL):
2043
2044 2010-10-17  Andreas Kling  <kling@webkit.org>
2045
2046         Reviewed by Kenneth Rohde Christiansen.
2047
2048         [Qt] Support custom open() verbs/methods in XMLHttpRequest
2049         https://bugs.webkit.org/show_bug.cgi?id=40476
2050
2051         Fall back to QNetworkAccessManager::CustomOperation for any HTTP verb
2052         that's not specifically supported by QNetworkAccessManager.
2053
2054         This prevents the infinite loop that otherwise occurs after sending
2055         an UnknownOperation request.
2056
2057         This change is covered by existing (skipped) tests that will be
2058         unskipped once the Qt bots are running Qt 4.7.
2059
2060         * platform/network/qt/QNetworkReplyHandler.cpp:
2061         (WebCore::QNetworkReplyHandler::httpMethod):
2062         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
2063         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2064         * platform/network/qt/QNetworkReplyHandler.h:
2065
2066 2010-10-17  Adam Barth  <abarth@webkit.org>
2067
2068         Reviewed by Dimitri Glazkov.
2069
2070         Remove explicit passing of user gesture in NavigationScheduler
2071         https://bugs.webkit.org/show_bug.cgi?id=47786
2072
2073         As requested by Mr. Glazkov, remove more explicit passing of the user
2074         gesture state.  We now use a static to pass this information around.
2075
2076         * bindings/generic/BindingFrame.h:
2077         (WebCore::::navigateIfAllowed):
2078         * bindings/js/JSDOMWindowCustom.cpp:
2079         (WebCore::JSDOMWindow::setLocation):
2080         * bindings/js/JSLocationCustom.cpp:
2081         (WebCore::JSLocation::reload):
2082         * bindings/v8/custom/V8LocationCustom.cpp:
2083         (WebCore::V8Location::reloadCallback):
2084         * inspector/InspectorController.cpp:
2085         (WebCore::InspectorController::setResourceTrackingEnabled):
2086         (WebCore::InspectorController::reloadPage):
2087         * loader/NavigationScheduler.cpp:
2088         (WebCore::ScheduledNavigation::ScheduledNavigation):
2089         (WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
2090         (WebCore::ScheduledRedirect::ScheduledRedirect):
2091         (WebCore::ScheduledLocationChange::ScheduledLocationChange):
2092         (WebCore::ScheduledRefresh::ScheduledRefresh):
2093         (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
2094         (WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
2095         (WebCore::NavigationScheduler::scheduleRedirect):
2096         (WebCore::NavigationScheduler::mustLockBackForwardList):
2097         (WebCore::NavigationScheduler::scheduleLocationChange):
2098         (WebCore::NavigationScheduler::scheduleFormSubmission):
2099         (WebCore::NavigationScheduler::scheduleRefresh):
2100         (WebCore::NavigationScheduler::scheduleHistoryNavigation):
2101         * loader/NavigationScheduler.h:
2102         * loader/SubframeLoader.cpp:
2103         (WebCore::SubframeLoader::loadOrRedirectSubframe):
2104
2105 2010-10-17  Julien Chaffraix  <jchaffraix@codeaurora.org>
2106
2107         Reviewed by Andreas Kling.
2108
2109         'transparent' should be a valid color
2110         https://bugs.webkit.org/show_bug.cgi?id=45482
2111
2112         Test: svg/animations/svg-animate-color-transparent.svg
2113
2114         Based on previous work by Jan Erik Hanssen  <jhanssen@codeaurora.org>
2115
2116         * platform/ColorData.gperf: Added 'transparent' to the list of colors.
2117         Added the alpha to all the colors as it was needed to support the new color.
2118
2119         * platform/graphics/Color.cpp:
2120         (WebCore::Color::Color):
2121         (WebCore::Color::setNamedColor): Avoid setting the alpha as now it is not
2122         always 0xFF.
2123
2124 2010-10-17  Justin Schuh  <jschuh@chromium.org>
2125
2126         Reviewed by Nikolas Zimmermann.
2127
2128         Duplicate use element children in shadow tree.
2129         https://bugs.webkit.org/show_bug.cgi?id=47561
2130
2131         Test: svg/custom/use-nested-children.svg
2132
2133         * svg/SVGUseElement.cpp:
2134         (WebCore::SVGUseElement::expandUseElementsInShadowTree):
2135
2136 2010-10-17  Hyung Song  <beergun@company100.net>
2137
2138         Reviewed by David Levin.
2139
2140         Add !SINGLE_THREADED guard.
2141         https://bugs.webkit.org/show_bug.cgi?id=47608
2142
2143         For SINGLE_THREADED ports LockingMutex.tryLock() returns false.
2144         This will prevent interrupt() from falling into infinite loop.
2145
2146         * platform/sql/SQLiteDatabase.cpp:
2147         (WebCore::SQLiteDatabase::interrupt):
2148
2149 2010-10-17  Simon Fraser  <simon.fraser@apple.com>
2150
2151         Reviewed by Nikolas Zimmermann.
2152
2153         Very large and small numbers fail to round-trip through CSS
2154         https://bugs.webkit.org/show_bug.cgi?id=20674
2155         
2156         Use the new DecimalNumber functionality to convert CSS numberic values to strings
2157         using decimal notation, rather than %g (which can output scientific notation).
2158
2159         Test: fast/css/round-trip-values.html
2160
2161         * css/CSSPrimitiveValue.cpp:
2162         (WebCore::formatNumber):
2163         (WebCore::CSSPrimitiveValue::cssText):
2164
2165 2010-10-17  Cosmin Truta  <ctruta@chromium.org>
2166
2167         Reviewed by Nikolas Zimmermann.
2168
2169         Crash while processing ill-formed SVG with cycles
2170         https://bugs.webkit.org/show_bug.cgi?id=47498
2171
2172         Test: svg/custom/invalid-paint-shape-mask.svg
2173
2174         * rendering/SVGResources.cpp:
2175         (paintingResourceFromSVGPaint): Ensured that the painting resource is
2176         either a pattern resource or a gradient resource.
2177         (SVGResources::setClipper):
2178         (SVGResources::setFilter):
2179         (SVGResources::setMarkerStart):
2180         (SVGResources::setMarkerMid):
2181         (SVGResources::setMarkerEnd):
2182         (SVGResources::setMasker):
2183         (SVGResources::setFill):
2184         (SVGResources::setStroke): Added ASSERT statements for previously-unchecked
2185         preconditions.
2186
2187 2010-10-17  Alex Milowski  <alex@milowski.com>
2188
2189         Reviewed by Kenneth Rohde Christiansen.
2190
2191         Fixed extra whitespace above operators when they aren't stretched
2192         yet the stretch height is large.  Also, the baseline alignment
2193         was changed so that rows and operators interact appropriately now
2194         that operators don't have the extra white space.
2195
2196         * mathml/RenderMathMLOperator.cpp:
2197         * mathml/RenderMathMLRow.cpp:
2198
2199 2010-10-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2200
2201         Reviewed by Antonio Gomes.
2202
2203         [Qt] Fix focusing of control elements on mouse click.
2204         Brings GTK fix to Qt platform.
2205         https://bugs.webkit.org/show_bug.cgi?id=40641
2206                         
2207         Test: fast/events/click-focus-control.html
2208
2209         * html/HTMLFormControlElement.cpp:
2210         (WebCore::HTMLFormControlElement::isMouseFocusable):
2211
2212 2010-10-17  Adam Barth  <abarth@webkit.org>
2213
2214         Reviewed by Dimitri Glazkov.
2215
2216         FrameLoader doesn't need an explicit userGesture parameter
2217         https://bugs.webkit.org/show_bug.cgi?id=47777
2218
2219         We used to pass around the user gesture state explicitly.  Now we use
2220         static state.  Explicitly passing the user gesture state to FrameLoader
2221         in these methods is pretty out-dated.
2222
2223         * bindings/ScriptControllerBase.cpp:
2224         (WebCore::ScriptController::executeIfJavaScriptURL):
2225         * bindings/generic/BindingDOMWindow.h:
2226         (WebCore::::createWindow):
2227         (WebCore::::open):
2228         * bindings/js/JSDOMWindowCustom.cpp:
2229         (WebCore::createWindow):
2230         (WebCore::JSDOMWindow::open):
2231         * bindings/js/JSDocumentCustom.cpp:
2232         (WebCore::JSDocument::setLocation):
2233         * bindings/js/ScriptController.h:
2234         * bindings/v8/ScriptController.h:
2235         * html/HTMLAnchorElement.cpp:
2236         (WebCore::handleLinkClick):
2237         * inspector/InspectorController.cpp:
2238         (WebCore::InspectorController::openInInspectedWindow):
2239         * loader/FrameLoader.cpp:
2240         (WebCore::FrameLoader::changeLocation):
2241         (WebCore::FrameLoader::urlSelected):
2242         (WebCore::FrameLoader::submitForm):
2243         * loader/FrameLoader.h:
2244         * loader/NavigationScheduler.cpp:
2245         (WebCore::ScheduledURLNavigation::fire):
2246         (WebCore::ScheduledRefresh::fire):
2247         (WebCore::ScheduledHistoryNavigation::fire):
2248         (WebCore::NavigationScheduler::scheduleLocationChange):
2249
2250 2010-10-17  Sergey A. Sukiyazov  <sergey.sukiyazov@gmail.com>
2251
2252         Reviewed by Andreas Kling
2253
2254         [Qt] Hovering the mouse over links produce a trail of underlined links (X11 paint engine)
2255         https://bugs.webkit.org/show_bug.cgi?id=42248
2256
2257         The problem will appear because coordinates of points may increase by 0.05f (if line width is odd) inside
2258         method GraphicsContext::adjustLineToPixelBoundaries(...) and become outside of text bounding rect htere,
2259         then the new point coordinates will be passed to Qt graphics engine.
2260
2261         The solution decreases Y cordinates of points inside drawLineForText(...) method only if Qt graphics engine
2262         is X11. The Y coordinates will be increase by 0.5f inside method adjustLineToPixelBoundaries(...),  which
2263         called from drawLine(...), and then inside Qt painting engine will be rounded to next greater integer value.
2264
2265         NOTE: This changes will affect only Qt X11 verision and if only X11 Painting Engine will be used.
2266
2267         No new tests.
2268
2269         * platform/graphics/qt/GraphicsContextQt.cpp:
2270         (WebCore::GraphicsContext::drawLineForText):
2271
2272 2010-10-17  Rob Buis  <rwlbuis@gmail.com>
2273
2274         Reviewed by Dirk Schulze.
2275
2276         Text under nested link dropped
2277         https://bugs.webkit.org/show_bug.cgi?id=46460
2278
2279         Allow links inside of tspan and textPath elements.
2280
2281         * svg/SVGTSpanElement.cpp:
2282         (WebCore::SVGTSpanElement::childShouldCreateRenderer):
2283         * svg/SVGTextPathElement.cpp:
2284         (WebCore::SVGTextPathElement::childShouldCreateRenderer):
2285
2286 2010-10-16  Kwang Yul Seo  <skyul@company100.net>
2287
2288         Reviewed by Kent Tamura.
2289
2290         [BREWMP] Port TextCodec
2291         https://bugs.webkit.org/show_bug.cgi?id=45797
2292
2293         Implement TextCodec with Brew MP's ICharsetConv.
2294         Only UTF-8 is supported for now.
2295
2296         * platform/text/TextEncoding.cpp:
2297         (WebCore::TextEncoding::encode):
2298         * platform/text/TextEncodingRegistry.cpp:
2299         (WebCore::buildBaseTextCodecMaps):
2300         * platform/text/brew/TextCodecBrew.cpp: Added.
2301         (WebCore::newTextCodecBrew):
2302         (WebCore::TextCodecBrew::registerBaseEncodingNames):
2303         (WebCore::TextCodecBrew::registerBaseCodecs):
2304         (WebCore::TextCodecBrew::registerExtendedEncodingNames):
2305         (WebCore::TextCodecBrew::registerExtendedCodecs):
2306         (WebCore::TextCodecBrew::TextCodecBrew):
2307         (WebCore::TextCodecBrew::~TextCodecBrew):
2308         (WebCore::TextCodecBrew::decode):
2309         (WebCore::TextCodecBrew::encode):
2310         * platform/text/brew/TextCodecBrew.h: Added.
2311
2312 2010-10-16  Patrick Gansterer  <paroga@webkit.org>
2313
2314         Unreviewed.
2315
2316         Build fix for !ENABLE(INSPECTOR) after r69844.
2317
2318         * inspector/InspectorState.h: Added ENABLE(INSPECTOR) guard.
2319
2320 2010-10-16  Patrick Gansterer  <paroga@webkit.org>
2321
2322         Unreviewed, build fix.
2323
2324         WinCE build fix for r69798.
2325
2326         * platform/text/wince/TextCodecWinCE.cpp: Added missing include.
2327
2328 2010-10-16  Johnny Ding  <jnd@chromium.org>
2329
2330         Reviewed by Adam Barth.
2331
2332         Requires a user gesture when opening file choose dialog.
2333         https://bugs.webkit.org/show_bug.cgi?id=47593
2334
2335         Test: fast/forms/input-file-not-open-without-gesture.html
2336
2337         * rendering/RenderFileUploadControl.cpp:
2338         (WebCore::RenderFileUploadControl::click):
2339
2340 2010-10-16  Alex Milowski  <alex@milowski.com>
2341
2342         Reviewed by Kenneth Rohde Christiansen.
2343
2344         Changed the vertical alignment within mfenced to baseline to
2345         match the rest of the containers (e.g. mrow) and adjusted the
2346         operator spacing to 0.1em.
2347
2348         Test: mathml/presentation/fenced-mi.xhtml
2349
2350         * css/mathml.css:
2351         * mathml/RenderMathMLFenced.cpp:
2352
2353 2010-10-16  Patrick Gansterer  <paroga@webkit.org>
2354
2355         Reviewed by Adam Barth.
2356
2357         Rename StringHasherFunctions.h to StringHasher.h
2358         https://bugs.webkit.org/show_bug.cgi?id=47200
2359
2360         * ForwardingHeaders/wtf/StringHashFunctions.h: Removed.
2361         * ForwardingHeaders/wtf/StringHasher.h: Copied from WebCore/ForwardingHeaders/wtf/StringHashFunctions.h. 
2362  
2363 2010-10-15  Ryosuke Niwa  <rniwa@webkit.org>
2364
2365         Reviewed by Darin Adler.
2366
2367         unlink removes inline style of anchor elements
2368         https://bugs.webkit.org/show_bug.cgi?id=47424
2369
2370         The bug was caused by our not extracting styles when the anchor element is removed by removeInlineStyle.
2371         Because we removed the element without pushing its inline style down, we lost style information.
2372
2373         Fixed the bug by pushing down styles in removeInlineStyle as done in pushDownInlineStyleAroundNode.
2374         Also fixed a bug in addInlineStyleIfNeeded where StyleChange incorrectly removed styles of the container
2375         node as supposed to that of startNode from the style to apply when startNode is not an element.
2376
2377         Test: editing/execCommand/toggle-unlink.html
2378
2379         * editing/ApplyStyleCommand.cpp:
2380         (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): To prevent a similar bug in the future,
2381         added an assert that extractedStyle is specified whenever we're removing a styled element.
2382         (WebCore::ApplyStyleCommand::removeInlineStyle):
2383         (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
2384
2385 2010-10-15  Ryosuke Niwa  <rniwa@webkit.org>
2386
2387         Reviewed by Tony Chang.
2388
2389         serializeNodesWithNamespaces should be in MarkupAccumulator
2390         https://bugs.webkit.org/show_bug.cgi?id=47749
2391
2392         Moved serializeNodesWithNamespaces to MarkupAccumulator, and renamed it to serializeNodes.
2393         MarkupAccumulator::serializeNode now returns the resultant string instead of having a separate takeResults().
2394         Added several helper functions to MarkupAccumulator.
2395
2396         No new tests are added since this is a cleanup.
2397
2398         * editing/MarkupAccumulator.cpp:
2399         (WebCore::MarkupAccumulator::serializeNodes): Wrapper for serializeNodes and concatenateMarkup.
2400         (WebCore::MarkupAccumulator::serializeNodesWithNamespaces): Moved from markup.cpp
2401         (WebCore::MarkupAccumulator::appendStartTag): Calls appendString instead of appending into m_succeedingMarkup directly.
2402         (WebCore::MarkupAccumulator::appendEndTag): Ditto.
2403         (WebCore::MarkupAccumulator::totalLength): Added; extracted from takeResults.
2404         (WebCore::MarkupAccumulator::concatenateMarkup): Ditto.
2405         * editing/MarkupAccumulator.h:
2406         (WebCore::MarkupAccumulator::length): Added; calls totalLength.
2407         * editing/markup.cpp:
2408         (WebCore::StyledMarkupAccumulator::appendString): Added; calls MarkupAccumulator's appendString.
2409         (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): Calls appendString.
2410         (WebCore::StyledMarkupAccumulator::takeResults): Calls length, totalLength, and concatenateMarkup.
2411         (WebCore::StyledMarkupAccumulator::serializeNodes): Became a member function.
2412         (WebCore::createMarkup): Uses MarkupAccumulator.
2413
2414 2010-10-15  Kinuko Yasuda  <kinuko@google.com>
2415
2416         Reviewed by Jian Li.
2417
2418         Implement FileEntrySync.file() in FileSystem API
2419         https://bugs.webkit.org/show_bug.cgi?id=47310
2420
2421         Tests: fast/filesystem/workers/file-from-file-entry-sync.html
2422                fast/filesystem/workers/file-from-file-entry.html
2423
2424         * fileapi/DOMFileSystem.cpp:
2425         (WebCore::DOMFileSystem::createFile): Added.
2426         * fileapi/DOMFileSystem.h:
2427         * fileapi/DOMFileSystemSync.cpp:
2428         (WebCore::DOMFileSystemSync::createFile): Added.
2429         * fileapi/DOMFileSystemSync.h:
2430         * fileapi/DirectoryReaderBase.h: Added 'virtual path' comment.
2431         * fileapi/EntryBase.h: Added 'virtual path' comment.
2432         * fileapi/FileEntry.cpp:
2433         (WebCore::FileEntry::file): Changed to use DOMFileSystem::createFile.
2434         * fileapi/FileEntrySync.cpp:
2435         (WebCore::FileEntrySync::file): Implemented.
2436         * fileapi/FileEntrySync.h:
2437         * fileapi/FileEntrySync.idl: Added file().
2438
2439 2010-10-15  Nico Weber  <thakis@chromium.org>
2440
2441         Reviewed by Eric Carlson.
2442
2443         Make sure to update the current graphics context when calling out to AppKit.
2444         https://bugs.webkit.org/show_bug.cgi?id=47757
2445
2446         Like r57741, but for the spellchecking highlight
2447
2448         * platform/graphics/mac/GraphicsContextMac.mm:
2449         (WebCore::GraphicsContext::drawLineForTextChecking):
2450
2451 2010-10-15  Brian Weinstein  <bweinstein@apple.com>
2452
2453         Reviewed by Sam Weinig.
2454
2455         REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request.
2456         https://bugs.webkit.org/show_bug.cgi?id=47753
2457         <rdar://problem/8558242>
2458         
2459         r69850 switched over to a different way of concatenating WebCore strings, but ran into an issue
2460         where some Windows calls were returning null terminated strings, and this breaks the new
2461         method of concatenation.
2462         
2463         GetLocaleInfo returns a null-terminated string, but WebCore strings are non-null terminated,
2464         so once we create our WebCore string, we want to trim off the null terminating character before
2465         we return the localeInfo.
2466
2467         Test: fast/dom/navigator-userAgent.html
2468
2469         * platform/win/Language.cpp:
2470         (WebCore::localeInfo):
2471
2472 2010-10-15  Alexey Proskuryakov  <ap@apple.com>
2473
2474         Trying to fix crashes on Leopard buildbot.
2475
2476         * loader/loader.cpp:
2477         (WebCore::Loader::Host::didFinishLoading):
2478         (WebCore::Loader::Host::didFail):
2479         Moved logging higher in the function - it seems that CachedResource can be already destroyed.
2480
2481         * platform/Logging.cpp: (WebCore::getChannelFromName):
2482         * platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
2483         Initialize the new channel (oops).
2484
2485 2010-10-15  Mike Lawther  <mikelawther@chromium.org>
2486
2487         Reviewed by James Robinson.
2488
2489         Prevent scrollbars from appearing in iframes with scrolling=no
2490         when the embedded content has overflow:scroll set on the html
2491         or body tags.
2492
2493         iframes keep getting scrollbars with scrolling="no"
2494         https://bugs.webkit.org/show_bug.cgi?id=29240
2495
2496         Test: fast/frames/iframe-scrolling-attribute-overflowscroll.html
2497
2498         * page/FrameView.cpp:
2499         (WebCore::FrameView::calculateScrollbarModesForLayout)
2500         (WebCore::FrameView::updateCanHaveScrollbars):
2501         (WebCore::FrameView::layout):
2502         * page/FrameView.h:
2503         (WebCore::FrameView::calculateScrollbarModesForLayout)
2504
2505 2010-10-15  Dan Bernstein  <mitz@apple.com>
2506
2507         Reviewed by Adele Peterson.
2508
2509         Clean up RenderFlexibleBox::applyLineClamp()
2510         https://bugs.webkit.org/show_bug.cgi?id=47743
2511
2512         * rendering/RenderFlexibleBox.cpp:
2513         (WebCore::RenderFlexibleBox::applyLineClamp):
2514
2515 2010-10-15  Alexey Proskuryakov  <ap@apple.com>
2516
2517         Reviewed by Darin Adler.
2518
2519         https://bugs.webkit.org/show_bug.cgi?id=47736
2520         <rdar://problem/8429396> WebCore cache gets corrupted if revalidation request starts at an inopportune time
2521
2522         Test: http/tests/cache/stopped-revalidation.html
2523
2524         * loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): Copied logic for
2525         revalidation requests from didFail().
2526
2527 2010-10-15  Alexey Proskuryakov  <ap@apple.com>
2528
2529         Reviewed by Darin Adler in <https://bugs.webkit.org/show_bug.cgi?id=47736>.
2530
2531         Add a logging channel for WebCore cache and resource loading.
2532
2533         Test: http/tests/cache/stopped-revalidation.html
2534
2535         * platform/Logging.cpp:
2536         * platform/Logging.h:
2537         Added a logging channel for Cache and Loader.
2538
2539         * loader/Cache.cpp:
2540         (WebCore::Cache::requestResource):
2541         (WebCore::Cache::revalidateResource):
2542         (WebCore::Cache::revalidationFailed):
2543         (WebCore::Cache::evict):
2544         * loader/CachedResource.cpp:
2545         (WebCore::CachedResource::setResourceToRevalidate):
2546         (WebCore::CachedResource::switchClientsToRevalidatedResource):
2547         (WebCore::CachedResource::mustRevalidate):
2548         Added logging.
2549
2550         * loader/loader.cpp:
2551         (WebCore::Loader::load): Added logging.
2552         (WebCore::Loader::scheduleServePendingRequests): Ditto.
2553         (WebCore::Loader::requestTimerFired): Ditto.
2554         (WebCore::Loader::servePendingRequests): Ditto.
2555         (WebCore::Loader::Host::servePendingRequests):  Changed logging to use the new channel.
2556         (WebCore::Loader::Host::didFinishLoading): Changed logging to use the new channel.
2557         (WebCore::Loader::Host::didFail): Added logging.
2558
2559 2010-10-15  No'am Rosenthal  <noam.rosenthal@nokia.com>
2560
2561         Reviewed by Simon Fraser.
2562
2563         Add public functions to serialize TransformOperations.
2564         https://bugs.webkit.org/show_bug.cgi?id=47728
2565
2566         Added public accessors to the internal data of the TransformOperations.
2567
2568         No new tests. These functions are enablers for WebKit2.
2569
2570         * platform/graphics/transforms/Matrix3DTransformOperation.h:
2571         (WebCore::Matrix3DTransformOperation::matrix):
2572         * platform/graphics/transforms/MatrixTransformOperation.h:
2573         (WebCore::MatrixTransformOperation::matrix):
2574         * platform/graphics/transforms/PerspectiveTransformOperation.h:
2575         (WebCore::PerspectiveTransformOperation::perspective):
2576         * platform/graphics/transforms/RotateTransformOperation.h:
2577         (WebCore::RotateTransformOperation::x):
2578         (WebCore::RotateTransformOperation::y):
2579         (WebCore::RotateTransformOperation::z):
2580         * platform/graphics/transforms/SkewTransformOperation.h:
2581         (WebCore::SkewTransformOperation::angleX):
2582         (WebCore::SkewTransformOperation::angleY):
2583         * platform/graphics/transforms/TranslateTransformOperation.h:
2584         (WebCore::TranslateTransformOperation::x):
2585         (WebCore::TranslateTransformOperation::y):
2586         (WebCore::TranslateTransformOperation::z):
2587
2588 2010-10-15  Jian Li  <jianli@chromium.org>
2589
2590         Reviewed by Dmitry Titov.
2591
2592         FileReader.readAsDataURL should take Blob object
2593         https://bugs.webkit.org/show_bug.cgi?id=47679
2594
2595         Test cases have been added into read-blob-test-cases.js.
2596
2597         * fileapi/FileReader.idl: Update per the latest File API spec.
2598
2599 2010-10-15  Adam Barth  <abarth@webkit.org>
2600
2601         Reviewed by Eric Seidel.
2602
2603         Move MarkupAccumulator from markup.cpp to its own file
2604         https://bugs.webkit.org/show_bug.cgi?id=47734
2605
2606         This patch moves the MarkupAccumulator class into its own file.
2607         There's a lot of clean up left to do, but this patch is a step in the
2608         right direction.
2609
2610         No behavior change.
2611
2612         * Android.mk:
2613         * CMakeLists.txt:
2614         * GNUmakefile.am:
2615         * WebCore.gypi:
2616         * WebCore.pro:
2617         * WebCore.vcproj/WebCore.vcproj:
2618         * WebCore.xcodeproj/project.pbxproj:
2619         * editing/markup.cpp:
2620         (WebCore::elementCannotHaveEndTag):
2621         * editing/markup.h:
2622         * editing/MarkupAccumulator.h: Added.
2623         * editing/MarkupAccumulator.cpp: Added.
2624
2625 2010-10-15  Ryosuke Niwa  <rniwa@webkit.org>
2626
2627         Reviewed by Darin Adler.
2628
2629         Match the elements supported by execCommand('formatBlock') and queryCommandValue('formatBlock')
2630         https://bugs.webkit.org/show_bug.cgi?id=47712
2631
2632         Extended queryCommandValue('formatBlock', false, null) to support article, aside, blockquote, dd, dl,
2633         div, dl, dt, dl, footer, header, hgroup, nav, and section. Because this makes isElementForFormatBlockCommand
2634         in Editor.cpp and FormatBlockCommand::isElementToApplyInFormatBlockCommand identical, they are merged and moved
2635         to FormatBlockCommand.cpp
2636
2637         Tests are added to editing/execCommand/query-format-block.html
2638
2639         * editing/Editor.cpp: Removed isElementForFormatBlockCommand and Editor::elementForFormatBlockCommand.
2640         * editing/Editor.h:
2641         * editing/EditorCommand.cpp:
2642         (WebCore::executeFormatBlock): Removed the check of tag name; the check is moved into FormatBlockCommand.
2643         (WebCore::valueFormatBlock): Calls FormatBlockCommand::elementForFormatBlockCommand.
2644         * editing/FormatBlockCommand.cpp:
2645         (WebCore::isElementForFormatBlock):
2646         (WebCore::FormatBlockCommand::FormatBlockCommand):
2647         (WebCore::FormatBlockCommand::formatSelection): Added to check the tag name. Exit early if the specified tag name
2648         is not what FormatBlock should apply. Set m_didApply true if m_didApply did apply the element.
2649         (WebCore::FormatBlockCommand::formatRange): Moved from Editor.cpp.  Takes Range* instead of accessing selection directly.
2650         (WebCore::FormatBlockCommand::elementForFormatBlockCommand): Moved from Editor.cpp
2651         (WebCore::enclosingBlockToSplitTreeTo): Calls isElementForFormatBlock.
2652         * editing/FormatBlockCommand.h:
2653         (WebCore::FormatBlockCommand::didApply): Added.
2654
2655 2010-10-15  Dirk Schulze  <krit@webkit.org>
2656
2657         Reviewed by Nikolas Zimmermann.
2658
2659         carto.net Dock example redraws *way* too often
2660         https://bugs.webkit.org/show_bug.cgi?id=16090
2661
2662         Setting the attributes x, y, width or height shouldn't cause a repaint if the image boundaries don't change.
2663         Added updateFromElement() to RenderSVGImage that checks if the old boundaries match the new boundaries after
2664         setting one of the attributes of above. Mark renderer for layout (and therefore repaint) if the boundaries
2665         differ, do nothing if not.
2666         Also added caching of the repaint rect to avoid multiple calculations.
2667
2668         Test: svg/custom/repaint-on-constant-size-change.svg
2669
2670         * rendering/RenderSVGImage.cpp:
2671         (WebCore::RenderSVGImage::RenderSVGImage):
2672         (WebCore::RenderSVGImage::layout): Update repaint rect on layout.
2673         (WebCore::RenderSVGImage::updateFromElement): Check SVGImageElement for boundaries update.
2674         * rendering/RenderSVGImage.h:
2675         (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): Return the cached repaint rect.
2676         * svg/SVGImageElement.cpp:
2677         (WebCore::SVGImageElement::svgAttributeChanged): Call updateFromElement() on changes to x, y, width or height.
2678
2679 2010-10-15  Martin Robinson  <mrobinson@igalia.com>
2680
2681         Build fix for GTK+.
2682
2683         * platform/network/soup/cache/webkit/soup-cache.h: Do not use PLATFORM(...) macro
2684         in a file that does not include config.h
2685
2686 2010-10-15  Anders Carlsson  <andersca@apple.com>
2687
2688         Reviewed by Sam Weinig.
2689
2690         Add FindIndicatorWindow class
2691         https://bugs.webkit.org/show_bug.cgi?id=47731
2692
2693         Export symbols needed by the FindIndicator in WebKit2.
2694
2695         * WebCore.exp.in:
2696
2697 2010-10-15  Leandro Pereira  <leandro@profusion.mobi>
2698
2699         [EFL] Unreviewed. Build fix.
2700
2701         Add new files needed by the Soup network backend, and #ifdef a
2702         GTK+-port only include in soup-cache.h.
2703
2704         * CMakeListsEfl.txt:
2705         * platform/network/soup/cache/webkit/soup-cache.h:
2706
2707 2010-10-14  Darin Adler  <darin@apple.com>
2708
2709         Reviewed by Alexey Proskuryakov.
2710
2711         Use more specific types for node pointers, especially when calling node insertion and removal functions
2712         https://bugs.webkit.org/show_bug.cgi?id=47702
2713
2714         Refactoring. No new tests.
2715
2716         While developing this patch I temporarily removed the node insertion and
2717         removal member functions from the Node class and fixed almost all call sites
2718         so they call it directly on the ContainerNode class, which will be important
2719         once we make the functions non-virtual.
2720
2721         * css/CSSStyleSelector.cpp:
2722         (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
2723         * dom/ContainerNode.cpp:
2724         (WebCore::ContainerNode::insertBefore):
2725         (WebCore::ContainerNode::replaceChild):
2726         (WebCore::ContainerNode::appendChild):
2727         * dom/Document.cpp:
2728         (WebCore::Document::caretRangeFromPoint):
2729         * dom/DynamicNodeList.cpp:
2730         (WebCore::DynamicNodeList::itemWithName):
2731         * dom/Position.cpp:
2732         (WebCore::Position::previous):
2733         (WebCore::Position::next):
2734         * dom/Text.cpp:
2735         (WebCore::Text::replaceWholeText):
2736         * dom/TreeWalker.cpp:
2737         (WebCore::TreeWalker::firstChild):
2738         (WebCore::TreeWalker::lastChild):
2739         (WebCore::TreeWalker::previousNode):
2740         * dom/XMLDocumentParserLibxml2.cpp:
2741         (WebCore::XMLDocumentParser::XMLDocumentParser):
2742         * editing/BreakBlockquoteCommand.cpp:
2743         (WebCore::BreakBlockquoteCommand::doApply):
2744         * editing/CompositeEditCommand.h:
2745         * editing/DeleteButtonController.cpp:
2746         (WebCore::isDeletableElement):
2747         * editing/IndentOutdentCommand.cpp:
2748         (WebCore::IndentOutdentCommand::outdentParagraph):
2749         * editing/InsertNodeBeforeCommand.cpp:
2750         (WebCore::InsertNodeBeforeCommand::doApply):
2751         * editing/JoinTextNodesCommand.cpp:
2752         (WebCore::JoinTextNodesCommand::doApply):
2753         (WebCore::JoinTextNodesCommand::doUnapply):
2754         * editing/MergeIdenticalElementsCommand.cpp:
2755         (WebCore::MergeIdenticalElementsCommand::doUnapply):
2756         * editing/RemoveNodeCommand.cpp:
2757         (WebCore::RemoveNodeCommand::doApply):
2758         (WebCore::RemoveNodeCommand::doUnapply):
2759         * editing/RemoveNodeCommand.h:
2760         * editing/SplitElementCommand.cpp:
2761         (WebCore::SplitElementCommand::executeApply):
2762         * editing/SplitTextNodeCommand.cpp:
2763         (WebCore::SplitTextNodeCommand::doApply):
2764         (WebCore::SplitTextNodeCommand::doReapply):
2765         * editing/TextIterator.cpp:
2766         (WebCore::parentCrossingShadowBoundaries):
2767         * editing/htmlediting.cpp:
2768         (WebCore::enclosingList):
2769         * editing/markup.cpp:
2770         (WebCore::serializeNodes):
2771         (WebCore::ancestorToRetainStructureAndAppearance):
2772         (WebCore::createMarkup):
2773         * html/HTMLAreaElement.cpp:
2774         (WebCore::HTMLAreaElement::updateFocusAppearance):
2775         * html/HTMLEmbedElement.cpp:
2776         (WebCore::HTMLEmbedElement::rendererIsNeeded):
2777         * html/HTMLFormElement.cpp:
2778         (WebCore::HTMLFormElement::rendererIsNeeded):
2779         * html/HTMLFrameSetElement.cpp:
2780         (WebCore::HTMLFrameSetElement::attach):
2781         * html/HTMLImageElement.cpp:
2782         (WebCore::HTMLImageElement::insertedIntoTree):
2783         * html/HTMLLegendElement.cpp:
2784         (WebCore::HTMLLegendElement::associatedControl):
2785         * html/HTMLOptGroupElement.cpp:
2786         (WebCore::HTMLOptGroupElement::recalcSelectOptions):
2787         (WebCore::HTMLOptGroupElement::ownerSelectElement):
2788         * html/HTMLOptionElement.cpp:
2789         (WebCore::HTMLOptionElement::ownerSelectElement):
2790         * html/HTMLTableCellElement.cpp:
2791         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
2792         * html/HTMLTableColElement.cpp:
2793         (WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
2794         * html/HTMLTableElement.cpp:
2795         (WebCore::HTMLTableElement::insertRow):
2796         * html/HTMLTableRowElement.cpp:
2797         (WebCore::HTMLTableRowElement::rowIndex):
2798         * html/HTMLTableSectionElement.cpp:
2799         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
2800         * page/DOMSelection.cpp:
2801         (WebCore::DOMSelection::getRangeAt):
2802         (WebCore::DOMSelection::containsNode):
2803         * rendering/RenderSVGGradientStop.cpp:
2804         (WebCore::RenderSVGGradientStop::gradientElement):
2805         * svg/SVGElement.cpp:
2806         (WebCore::SVGElement::ownerSVGElement):
2807         (WebCore::SVGElement::viewportElement):
2808         * svg/SVGFELightElement.cpp:
2809         (WebCore::SVGFELightElement::svgAttributeChanged):
2810         (WebCore::SVGFELightElement::childrenChanged):
2811         * svg/SVGFEMergeNodeElement.cpp:
2812         (WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
2813         * svg/SVGFontFaceFormatElement.cpp:
2814         (WebCore::SVGFontFaceFormatElement::childrenChanged):
2815         * svg/SVGFontFaceUriElement.cpp:
2816         (WebCore::SVGFontFaceUriElement::childrenChanged):
2817         * svg/SVGGlyphElement.cpp:
2818         (WebCore::SVGGlyphElement::invalidateGlyphCache):
2819         * svg/SVGHKernElement.cpp:
2820         (WebCore::SVGHKernElement::insertedIntoDocument):
2821         (WebCore::SVGHKernElement::removedFromDocument):
2822         * svg/SVGLocatable.cpp:
2823         (WebCore::SVGLocatable::nearestViewportElement):
2824         (WebCore::SVGLocatable::farthestViewportElement):
2825         * svg/SVGUseElement.cpp:
2826         (WebCore::SVGUseElement::updateContainerOffsets):
2827         * svg/SVGVKernElement.cpp:
2828         (WebCore::SVGVKernElement::insertedIntoDocument):
2829         (WebCore::SVGVKernElement::removedFromDocument):
2830         * svg/animation/SVGSMILElement.cpp:
2831         (WebCore::SVGSMILElement::targetElement):
2832         * wml/WMLDoElement.cpp:
2833         (WebCore::WMLDoElement::insertedIntoDocument):
2834         (WebCore::WMLDoElement::removedFromDocument):
2835         * wml/WMLNoopElement.cpp:
2836         (WebCore::WMLNoopElement::insertedIntoDocument):
2837         * wml/WMLOptionElement.cpp:
2838         (WebCore::ownerSelectElement):
2839         * wml/WMLPostfieldElement.cpp:
2840         (WebCore::WMLPostfieldElement::insertedIntoDocument):
2841         (WebCore::WMLPostfieldElement::removedFromDocument):
2842         * wml/WMLSetvarElement.cpp:
2843         (WebCore::WMLSetvarElement::insertedIntoDocument):
2844         (WebCore::WMLSetvarElement::removedFromDocument):
2845         * wml/WMLTaskElement.cpp:
2846         (WebCore::WMLTaskElement::insertedIntoDocument):
2847         (WebCore::WMLTaskElement::removedFromDocument):
2848         * wml/WMLTimerElement.cpp:
2849         (WebCore::WMLTimerElement::insertedIntoDocument):
2850         (WebCore::WMLTimerElement::removedFromDocument):
2851         * xml/XPathStep.cpp:
2852         (WebCore::XPath::Step::nodesInAxis):
2853         Use ContainerNode* for the result of the parentNode function now that
2854         it returns a ContainerNode*. In the past it used to return just Node*.
2855
2856         * dom/ContainerNode.h: Added toContainerNode.
2857
2858         * dom/Element.h: Use ContainerNode*. Added toElement.
2859
2860         * dom/Element.cpp:
2861         (WebCore::Element::deprecatedCreateContextualFragment): Explcitly
2862         cast to HTMLElement* in the case that handles <html> and <body>
2863         elements.
2864         (WebCore::Element::baseURI): Use ContainerNode*.
2865
2866         * dom/Node.cpp:
2867         (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Use ContainerNode*.
2868         (WebCore::Node::isDescendantOf): Ditto.
2869         (WebCore::Node::createRendererIfNeeded): Ditto.
2870         (WebCore::Node::setTextContent): Use already-typecast pointer in a call to
2871         appendChild.
2872         (WebCore::Node::ancestorElement): Use ContainerNode*.
2873
2874         * dom/Range.cpp:
2875         (WebCore::Range::compareNode): Use ContainerNode*.
2876         (WebCore::Range::intersectsNode): Ditto.
2877         (WebCore::Range::processContents): Cast to ContainerNode* in a couple cases
2878         where we previously checked that the node in question has a child. Any node
2879         that returns a non-zero value for firstChild is a ContainerNode.
2880         (WebCore::Range::checkNodeBA): Ditto.
2881         (WebCore::Range::selectNode): Ditto.
2882         (WebCore::Range::surroundContents): Ditto.
2883
2884         * dom/XMLDocumentParser.cpp:
2885         (WebCore::XMLDocumentParser::insertErrorMessageBlock): Rewrote code to use
2886         more specific types, document instead of doc, and paragraph instead of par.
2887
2888         * editing/ApplyStyleCommand.cpp:
2889         (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle):
2890         Use ContainerNode*.
2891         (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):
2892         Use replaceElementWithSpanPreservingChildrenAndAttributes; the old function
2893         took a Node argument and had Node in its name.
2894
2895         * editing/CompositeEditCommand.cpp:
2896         (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Use ContainerNode.
2897         (WebCore::CompositeEditCommand::replaceElementWithSpanPreservingChildrenAndAttributes):
2898         Renamed and changed to take HTMLElement. Also use ContainerNode.
2899         (WebCore::CompositeEditCommand::prune): Ditto.
2900         (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
2901         (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Ditto.
2902
2903         * editing/ReplaceNodeWithSpanCommand.cpp:
2904         (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand): Take an
2905         HTMLElement instead of a Node. Call it m_elementToReplace instead of m_node.
2906         (WebCore::swapInNodePreservingAttributesAndChildren): Take HTMLElement.
2907         (WebCore::ReplaceNodeWithSpanCommand::doApply): Updated for name changes.
2908         (WebCore::ReplaceNodeWithSpanCommand::doUnapply): Ditto.
2909         * editing/ReplaceNodeWithSpanCommand.h: Ditto.
2910
2911         * editing/ReplaceSelectionCommand.cpp:
2912         (WebCore::ReplacementFragment::ReplacementFragment): Use StyledElement for result
2913         of insertFragmentForTestRendering since that's what it returns.
2914         (WebCore::ReplacementFragment::removeNode): Use ContainerNode.
2915         (WebCore::ReplacementFragment::insertNodeBefore): Ditto.
2916         (WebCore::ReplacementFragment::insertFragmentForTestRendering): Return StyledElement.
2917         Use HTMLElement for body.
2918         (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): Take
2919         StyledElement.
2920         (WebCore::ReplaceSelectionCommand::handleStyleSpans): Use ContainerNode.
2921         (WebCore::ReplaceSelectionCommand::copyStyleToChildren): Use HTMLElement for
2922         the cloned span, since the clone will be a sspan too.
2923         (WebCore::ReplaceSelectionCommand::insertAsListItems): Use ContainerNode since
2924         the list item has a child, and that proves it is a ContainerNode.
2925
2926         * editing/SelectionController.cpp:
2927         (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
2928         Use ContainerNode and also removed an unnneded local variable.
2929
2930         * html/HTMLElement.cpp:
2931         (WebCore::HTMLElement::setOuterText): Use ContainerNode.
2932         (WebCore::HTMLElement::insertAdjacent): Use ContainerNode and also use && to make
2933         the logic a little simpler.
2934         (WebCore::contextElementForInsertion): Use ContainerNode.
2935         (WebCore::HTMLElement::findFormAncestor): Ditto.
2936
2937         * inspector/InspectorDOMAgent.cpp:
2938         (WebCore::InspectorDOMAgent::removeNode): Use ContainerNode.
2939         (WebCore::InspectorDOMAgent::changeTagName): Ditto.
2940         (WebCore::InspectorDOMAgent::setOuterHTML): Ditto.
2941         (WebCore::InspectorDOMAgent::innerParentNode): Use isDocumentNode instead of
2942         nodeType. We should almost never use nodeType inside the engine.
2943         (WebCore::InspectorDOMAgent::didInsertDOMNode): Use ContainerNode.
2944         (WebCore::InspectorDOMAgent::didRemoveDOMNode): Ditto.
2945
2946         * wml/WMLOptGroupElement.cpp: Removed unneeded overrides of insertBefore,
2947         replaceChild, removeChild, appendChild, and removeChildren functions.
2948         Ths already overrides childrenChanged, that is called by all of the above,
2949         and it does the same thing these functions did.
2950         (WebCore::ownerSelectElement): Use ContainerNode.
2951         * wml/WMLOptGroupElement.h: Ditto.
2952
2953 2010-10-15  Ryosuke Niwa  <rniwa@webkit.org>
2954
2955         Reviewed by Darin Adler.
2956
2957         Crash in WebCore::ApplyStyleCommand::applyBlockStyle
2958         https://bugs.webkit.org/show_bug.cgi?id=47699
2959
2960         The crash was caused by applyBlockStyle's invalidly assuming that visibleStart and visibleEnd always exist.
2961         Added an early exit to the function when either visibleStart or visibleEnd is null or orphaned.
2962
2963         Test: editing/style/block-style-progress-crash.html
2964
2965         * editing/ApplyStyleCommand.cpp:
2966         (WebCore::ApplyStyleCommand::applyBlockStyle):
2967
2968 2010-10-13  Anders Carlsson  <andersca@apple.com>
2969
2970         Reviewed by Sam Weinig.
2971
2972         Add a FindIndicator class
2973         https://bugs.webkit.org/show_bug.cgi?id=47635
2974
2975         Make Gradient.h and Generator.h private headers; they're used by WebKit2.
2976
2977         * WebCore.xcodeproj/project.pbxproj:
2978
2979 2010-10-15  Sergio Villar Senin  <svillar@igalia.com>
2980
2981         Reviewed by Gustavo Noronha Silva.
2982
2983         [Soup] Should not ignore body for redirection responses
2984         https://bugs.webkit.org/show_bug.cgi?id=29299
2985
2986         Body is now provided to WebKitGtk+ in some redirections (like 302)
2987         because it could be used by servers to perform clunky redirections
2988         for example using http-equiv=REFRESH
2989
2990         Test: http/tests/navigation/redirect302-metaredirect.html
2991
2992         * platform/network/soup/ResourceHandleSoup.cpp:
2993         (WebCore::gotHeadersCallback):
2994         (WebCore::finishedCallback):
2995
2996 2010-10-15  Sergio Villar Senin  <svillar@igalia.com>
2997
2998         Reviewed by Martin Robinson.
2999
3000         [GTK] Fix introspection support
3001         https://bugs.webkit.org/show_bug.cgi?id=47723
3002
3003         WebKitSoupCacheType was incorrectly registered twice. Renamed to
3004         WebKitSoupCacheTypeType for the enumerated type.
3005
3006         * platform/network/soup/cache/webkit/soup-cache.c:
3007         (webkit_soup_cache_type_get_type):
3008
3009 2010-10-15  Ilya Tikhonovsky  <loislo@chromium.org>
3010
3011         Reviewed by Yury Semikhatsky.
3012
3013         Web Inspector: extract consoleMessages related stuff from populateScriptObjects into separate function.
3014
3015         This is a part of Inspector protocol sanitization activity.
3016         We want to populate console messages only if it is required by frontend.
3017
3018         https://bugs.webkit.org/show_bug.cgi?id=46802
3019
3020         * inspector/Inspector.idl:
3021         * inspector/InspectorController.cpp:
3022         (WebCore::InspectorController::setConsoleMessagesEnabled):
3023         (WebCore::InspectorController::addConsoleMessage):
3024         (WebCore::InspectorController::disconnectFrontend):
3025         (WebCore::InspectorController::populateScriptObjects):
3026         * inspector/InspectorController.h:
3027         * inspector/InspectorState.cpp:
3028         (WebCore::InspectorState::InspectorState):
3029         * inspector/InspectorState.h:
3030         * inspector/front-end/inspector.js:
3031         (WebInspector.doLoadedDone):
3032
3033 2010-10-15  Ryuan Choi  <ryuan.choi@samsung.com>
3034
3035         Reviewed by Nikolas Zimmermann.
3036
3037         [EFL] REGRESSION(69798) UCHAR can't be converted to String.
3038         https://bugs.webkit.org/show_bug.cgi?id=47698
3039
3040         Create String value using String(const char*, 1) instead of operator[].
3041
3042         No tests. No functionality changed.
3043
3044         * platform/efl/PlatformKeyboardEventEfl.cpp:
3045         (WebCore::createWindowsKeyMap):
3046
3047 2010-10-15  Sergio Villar Senin  <svillar@igalia.com>
3048
3049         Reviewed by Xan Lopez.
3050
3051         [GTK] Do a stricter check for invalid base64 dataURLs
3052         https://bugs.webkit.org/show_bug.cgi?id=47717
3053
3054         Restore the strict base64 decoding we added in
3055         https://bugs.webkit.org/show_bug.cgi?id=44261 and then rolled back
3056         in https://bugs.webkit.org/show_bug.cgi?id=47666 due to a failing
3057         test. The actual issue was that we were not finishing the load of
3058         the resource gracefully when an error happened.
3059
3060         Loading invalid base64-encoded data:// URLs are now handled
3061         properly.
3062
3063         * platform/network/soup/ResourceHandleSoup.cpp:
3064         (WebCore::parseDataUrl):
3065         * platform/network/soup/cache/soup-request-data.c:
3066         (webkit_soup_request_data_send):
3067
3068 2010-10-15  Alejandro G. Castro  <alex@igalia.com>
3069
3070         Reviewed by Martin Robinson.
3071
3072         compile fail with gtk >= 2.22
3073         https://bugs.webkit.org/show_bug.cgi?id=47483
3074
3075         * platform/graphics/gtk/FontGtk.cpp: Removed the shrink operation,
3076         it was added long time ago and currently it is not adding any real
3077         area to the clip vertically, actually the gtk3 shrink version did
3078         not work.
3079         (WebCore::Font::drawComplexText):
3080         * platform/gtk/gtk2drawing.c: Undef the deprecation flags, this
3081         file is full of gtk2 stuff, and it does not seem interesting to
3082         upgrade because we are already creating a new version of the file
3083         for gtk3.
3084
3085 2010-10-14  Ilya Tikhonovsky  <loislo@chromium.org>
3086
3087         Reviewed by Pavel Feldman.
3088
3089         Web Inspector: inspector settings/properties/states management
3090         should be extracted into separate class.
3091
3092         We have a lot of flags/values in InspectorController.
3093         Some flags are persisting into profile.
3094         Others are part of inspector state for frontend.
3095         All these flags should keep their values after navigation.
3096         It'd be better to extract these flags/values into separate
3097         class which will care about theirs lifetime.
3098
3099         https://bugs.webkit.org/show_bug.cgi?id=47275
3100
3101         * CMakeLists.txt:
3102         * GNUmakefile.am:
3103         * WebCore.exp.in:
3104         * WebCore.gypi:
3105         * WebCore.pro:
3106         * WebCore.vcproj/WebCore.vcproj:
3107         * WebCore.xcodeproj/project.pbxproj:
3108         * inspector/InspectorController.cpp:
3109         (WebCore::InspectorController::InspectorController):
3110         (WebCore::InspectorController::inspectorStartsAttached):
3111         (WebCore::InspectorController::setInspectorStartsAttached):
3112         (WebCore::InspectorController::setInspectorAttachedHeight):
3113         (WebCore::InspectorController::inspectorAttachedHeight):
3114         (WebCore::InspectorController::searchingForNodeInPage):
3115         (WebCore::InspectorController::resourceTrackingEnabled):
3116         (WebCore::InspectorController::saveApplicationSettings):
3117         (WebCore::InspectorController::getInspectorState):
3118         (WebCore::InspectorController::restoreInspectorStateFromCookie):
3119         (WebCore::InspectorController::getSettings):
3120         (WebCore::InspectorController::storeLastActivePanel):
3121         (WebCore::InspectorController::mouseDidMoveOverElement):
3122         (WebCore::InspectorController::handleMousePress):
3123         (WebCore::InspectorController::setSearchingForNode):
3124         (WebCore::InspectorController::setMonitoringXHREnabled):
3125         (WebCore::InspectorController::showPanel):
3126         (WebCore::InspectorController::disconnectFrontend):
3127         (WebCore::InspectorController::populateScriptObjects):
3128         (WebCore::InspectorController::restoreDebugger):
3129         (WebCore::InspectorController::restoreProfiler):
3130         (WebCore::InspectorController::getTrackedResource):
3131         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
3132         (WebCore::InspectorController::identifierForInitialRequest):
3133         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
3134         (WebCore::InspectorController::scriptImported):
3135         (WebCore::InspectorController::setResourceTrackingEnabled):
3136         (WebCore::InspectorController::ensureSettingsLoaded):
3137         (WebCore::InspectorController::startTimelineProfiler):
3138         (WebCore::InspectorController::stopTimelineProfiler):
3139         (WebCore::InspectorController::enableProfiler):
3140         (WebCore::InspectorController::disableProfiler):
3141         (WebCore::InspectorController::enableDebuggerFromFrontend):
3142         (WebCore::InspectorController::disableDebugger):
3143         (WebCore::InspectorController::loadBreakpoints):
3144         (WebCore::InspectorController::saveBreakpoints):
3145         * inspector/InspectorController.h:
3146         * inspector/InspectorFrontendClientLocal.cpp:
3147         (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
3148         (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
3149         * inspector/InspectorState.cpp: Added.
3150         (WebCore::InspectorState::InspectorState):
3151         (WebCore::InspectorState::restoreFromInspectorCookie):
3152         (WebCore::InspectorState::generateStateObjectForFrontend):
3153         (WebCore::InspectorState::loadFromSettings):
3154         (WebCore::InspectorState::updateCookie):
3155         (WebCore::InspectorState::setValue):
3156         (WebCore::InspectorState::getBoolean):
3157         (WebCore::InspectorState::getString):
3158         (WebCore::InspectorState::getLong):
3159         (WebCore::InspectorState::registerBoolean):
3160         (WebCore::InspectorState::registerString):
3161         (WebCore::InspectorState::registerLong):
3162         (WebCore::InspectorState::Property::create):
3163         * inspector/InspectorState.h: Added.
3164         (WebCore::InspectorState::setBoolean):
3165         (WebCore::InspectorState::setString):
3166         (WebCore::InspectorState::setLong):
3167
3168 2010-10-14  Jia Pu  <jpu@apple.com>
3169
3170         Reviewed by Adele Peterson.
3171
3172         REGRESSION (r69548): Autocorrections are applied even after typing further characters in the word
3173         https://bugs.webkit.org/show_bug.cgi?id=47689
3174         <rdar://problem/8552250>
3175
3176         The test requires using setTimeout(). So we put it in manual-tests.
3177
3178         * editing/Editor.cpp:
3179         (WebCore::Editor::markMisspellingsAfterTypingToPosition): Relpace release() with clear().
3180         (WebCore::Editor::startCorrectionPanelTimer): Release previously set correction range before
3181           start timer for next autocorrection check.
3182         * manual-tests/autocorrection: Added.
3183         * manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Added.
3184
3185 2010-10-14  Ryosuke Niwa  <rniwa@webkit.org>
3186
3187         Reviewed by Tony Chang and Darin Adler.
3188
3189         execCommand FormatBlock creates lots of blockquotes
3190         https://bugs.webkit.org/show_bug.cgi?id=19795
3191
3192         The bug was caused by WebKit's not reusing the block node added by previous iteration
3193         and its inserting block node at wrong places.
3194
3195         Fixed the bug by rewriting FormatBlockCommand::formatRange.  New code resembles that of
3196         IndentOutdentCommand::indentIntoBlockquote.  The difference between two is that formatRange
3197         avoids the existing block elements when replacing blocks and it also adds a placeholder
3198         when removing the existing block caused paragraphs to collapse.
3199
3200         Also fixed a bug in moveParagraphWithClones where erroneous br is added to the start of
3201         the block element to which the paragraph is moved if the block element is the start of a paragraph
3202         and not the end of a paragraph.
3203
3204         Tests: editing/execCommand/format-block-multiple-paragraphs.html
3205                editing/execCommand/format-block-table.html
3206
3207         * editing/CompositeEditCommand.cpp:
3208         (WebCore::CompositeEditCommand::moveParagraphWithClones): No longer adds erroneous br.
3209         * editing/EditorCommand.cpp:
3210         (WebCore::executeFormatBlock):
3211         * editing/FormatBlockCommand.cpp:
3212         (WebCore::FormatBlockCommand::formatRange): Rewritten; see above.
3213         (WebCore::FormatBlockCommand::isElementToApplyInFormatBlockCommand): Renamed from validBlockElement
3214         and moved from htmlediting.cpp.
3215         (WebCore::enclosingBlockToSplitTreeTo): Added.
3216         * editing/FormatBlockCommand.h:
3217         * editing/VisiblePosition.cpp:
3218         (WebCore::enclosingBlockFlowElement): Changed the return type to Element*
3219         * editing/VisiblePosition.h:
3220
3221 2010-10-14  Justin Schuh  <jschuh@chromium.org>
3222
3223         Reviewed by James Robinson.
3224
3225         Crash in HTMLTextFormControlElement::selection()
3226         https://bugs.webkit.org/show_bug.cgi?id=47522
3227
3228         Patch by Ryosuke Niwa  <rniwa@webkit.org>
3229
3230         The bug was caused by our triggering layout inside RenderTextControl::selection.
3231         Fixed it by changing the return type of RenderTextControl::selection to PassRefPtr<Range> from VisibleSelection.
3232
3233         Test: fast/forms/render-text-crash.html
3234
3235         * editing/Editor.cpp:
3236         (WebCore::Editor::selectionForCommand): Calls HTMLTextFormControlElement::selection.
3237         * html/HTMLFormControlElement.cpp:
3238         (WebCore::HTMLTextFormControlElement::selection): Calls RenderTextControl::selection.
3239         * html/HTMLFormControlElement.h:
3240         * rendering/RenderTextControl.cpp:
3241         (WebCore::RenderTextControl::selection): Changed the return type.
3242         * rendering/RenderTextControl.h:
3243
3244 2010-10-14  James Robinson  <jamesr@chromium.org>
3245
3246         Reviewed by Simon Fraser.
3247
3248         SelectElement should check if its renderer exists after calling Element::focus()
3249         https://bugs.webkit.org/show_bug.cgi?id=47696
3250
3251         Adds null checks for element->renderer() after calling element->focus(), since focus()
3252         can dispatch an event and run arbitrary javascript that may cause the select element
3253         to lose its renderer.
3254
3255         Test: fast/forms/select-listbox-focus-displaynone.html
3256
3257         * dom/SelectElement.cpp:
3258         (WebCore::SelectElement::menuListDefaultEventHandler):
3259         (WebCore::SelectElement::listBoxDefaultEventHandler):
3260
3261 2010-10-14  Beth Dakin  <bdakin@apple.com>
3262
3263         Reviewed by Dave Hyatt.
3264
3265         This patch lays the groundwork for 
3266         https://bugs.webkit.org/show_bug.cgi?id=47514 CSS transforms should 
3267         affect scrolling
3268         by adding topmostPosition().
3269
3270         * rendering/RenderBlock.cpp:
3271         (WebCore::RenderBlock::topmostPosition):
3272         * rendering/RenderBlock.h:
3273         * rendering/RenderBox.cpp:
3274         (WebCore::RenderBox::topmostPosition):
3275         * rendering/RenderBox.h:
3276         * rendering/RenderMedia.cpp:
3277         (WebCore::RenderMedia::topmostPosition):
3278         * rendering/RenderMedia.h:
3279         * rendering/RenderTableSection.cpp:
3280         (WebCore::RenderTableSection::topmostPosition):
3281         * rendering/RenderTableSection.h:
3282
3283 2010-10-14  Sergio Villar Senin  <svillar@igalia.com>
3284
3285         Reviewed by Martin Robinson.
3286
3287         [GTK] fix compilation warnings in imported libsoup code
3288         https://bugs.webkit.org/show_bug.cgi?id=47674
3289
3290         Fixed some warnings caused by comparisons between signed and
3291         unsigned integer expressions
3292
3293         * platform/network/soup/cache/soup-directory-input-stream.c:
3294         (webkit_soup_directory_input_stream_read):
3295         * platform/network/soup/cache/soup-request-data.c:
3296         (webkit_soup_request_data_send):
3297         * platform/network/soup/cache/soup-request-file.c:
3298         (webkit_soup_request_file_ensure_file):
3299         * platform/network/soup/cache/webkit/soup-cache.c:
3300         (webkit_soup_cache_entry_is_fresh_enough):
3301         (webkit_soup_cache_has_response):
3302
3303 2010-10-14  Andreas Kling  <kling@webkit.org>
3304
3305         Unreviewed buildfix, RetainPtr is a mac thing..
3306
3307         * platform/network/soup/ProxyServerSoup.cpp:
3308
3309 2010-10-08  Martin Robinson  <mrobinson@igalia.com>
3310
3311         Reviewed by Xan Lopez.
3312
3313         [GTK] Form controls do not respect GTK+ font size
3314         https://bugs.webkit.org/show_bug.cgi?id=47134
3315
3316         Have form controls use the font specified in GtkSettings. This font is
3317         the default control font in GTK+ applications and Firefox. We need to
3318         pass the string through Pango to get a valid font name and size.
3319
3320         * platform/gtk/RenderThemeGtk.cpp:
3321         (WebCore::getScreenDPI): A helper function which returns
3322         the DPI of the default screen or 96 as a fallback.
3323         (WebCore::RenderThemeGtk::systemFont): Calculate the system font
3324         by looking at the GtkSettings value and pushing it through Pango
3325         to get the font family and font size.
3326
3327 2010-10-14  Andreas Kling  <kling@webkit.org>
3328
3329         Soup buildfix for r69808: add ProxyServer stub.
3330
3331         * GNUmakefile.am:
3332         * platform/network/soup/ProxyServerSoup.cpp: Added.
3333         (WebCore::proxyServersForURL):
3334
3335 2010-10-14  Andreas Kling  <kling@webkit.org>
3336
3337         Fix GTK+ build after r69808.
3338
3339         * GNUmakefile.am:
3340         * platform/network/curl/ProxyServerCurl.cpp:
3341         (WebCore::proxyServersForURL):
3342
3343 2010-10-14  Simon Fraser  <simon.fraser@apple.com>
3344
3345         Another build fix. Export FrameLoader::networkingContext()
3346
3347         * WebCore.exp.in:
3348
3349 2010-10-14  Simon Fraser  <simon.fraser@apple.com>
3350
3351         Fix the build after r69808.
3352         
3353         * WebCore.xcodeproj/project.pbxproj:
3354         * platform/network/cf/ProxyServerCFNet.cpp:
3355         (WebCore::proxyServersForURL):
3356
3357 2010-10-14  Gavin Barraclough  <barraclough@apple.com>
3358
3359         Windows build fix following r69806.
3360
3361         * platform/win/ClipboardUtilitiesWin.cpp:
3362         (WebCore::markupToCFHTML):
3363
3364 2010-10-14  Dawit Alemayehu  <adawit@kde.org>
3365
3366         Reviewed by Andreas Kling
3367
3368         Implemented NPN_GetValueForURL and NPN_SetValueForURL and NPN_GetAuthenticationInfo.
3369         https://bugs.webkit.org/show_bug.cgi?id=34539
3370
3371         These missing NPN functions cause Java applets to crash in ports such
3372         as QtWebkit that rely on webkit for Java applet support.
3373
3374         * plugins/PluginDebug.cpp:
3375         (WebCore::prettyNameForNPNURLVariable):
3376         * plugins/PluginDebug.h:
3377         * plugins/PluginPackage.cpp:
3378         (WebCore::PluginPackage::initializeBrowserFuncs):
3379         * plugins/PluginView.cpp:
3380         (WebCore::PluginView::getValueForURL):
3381         (WebCore::PluginView::setValueForURL):
3382         (WebCore::PluginView::getAuthenticationInfo):
3383         * plugins/PluginView.h:
3384         * plugins/npapi.cpp:
3385         (NPN_GetValueForURL):
3386         (NPN_SetValueForURL):
3387         (NPN_GetAuthenticationInfo):
3388         * platform/network/ProxyServer.h:
3389         * platform/network/cf/ProxyServerCFNet.cpp:
3390         (WebCore::proxyServersForURL):
3391         * platform/network/qt/ProxyServerQt.cpp:
3392         (WebCore::proxyServersForURL):
3393  
3394 2010-10-14  Gavin Barraclough  <barraclough@apple.com>
3395
3396         Windows build fix following r69806.
3397
3398         * platform/win/ClipboardUtilitiesWin.cpp:
3399         (WebCore::markupToCFHTML):
3400
3401 2010-10-14  Zhenyao Mo  <zmo@google.com>
3402
3403         Reviewed by Kenneth Russell.
3404
3405         Cache link status at linkProgram and use it in useProgram instead of querying GPU
3406         https://bugs.webkit.org/show_bug.cgi?id=47685
3407
3408         * html/canvas/WebGLProgram.cpp: Always cache link status at linkStatus and use it upon query.
3409         (WebCore::WebGLProgram::WebGLProgram):
3410         * html/canvas/WebGLProgram.h: Ditto.
3411         (WebCore::WebGLProgram::getLinkStatus):
3412         (WebCore::WebGLProgram::setLinkStatus):
3413         * html/canvas/WebGLRenderingContext.cpp: Ditto.
3414         (WebCore::WebGLRenderingContext::getProgramParameter):
3415         (WebCore::WebGLRenderingContext::linkProgram):
3416         (WebCore::WebGLRenderingContext::useProgram):
3417
3418 2010-10-14  Justin Schuh  <jschuh@chromium.org>
3419
3420         Reviewed by James Robinson.
3421
3422         Style fix for r69735
3423         https://bugs.webkit.org/show_bug.cgi?id=47684
3424
3425         No logic change. Existing tests apply.
3426
3427         * rendering/RootInlineBox.cpp:
3428         (WebCore::RootInlineBox::alignBoxesInBlockDirection):
3429
3430 2010-10-14  Yury Semikhatsky  <yurys@chromium.org>
3431
3432         Reviewed by Pavel Feldman.
3433
3434         Web Inspector: encapsulate ScriptState into ConsoleMessage instead of passing it as additional parameter
3435         https://bugs.webkit.org/show_bug.cgi?id=47675
3436
3437         No new tests. This refactoring is covered by existing inspector tests.
3438
3439         * bindings/js/JSConsoleCustom.cpp:
3440         * bindings/js/ScriptCallFrame.cpp:
3441         * bindings/js/ScriptCallFrame.h:
3442         (WebCore::ScriptCallFrame::functionName):
3443         (WebCore::ScriptCallFrame::sourceURL):
3444         (WebCore::ScriptCallFrame::lineNumber):
3445         (WebCore::ScriptCallFrame::argumentCount):
3446         * inspector/ConsoleMessage.cpp:
3447         (WebCore::ConsoleMessage::isEqual):
3448         * inspector/ConsoleMessage.h:
3449         * inspector/InspectorController.cpp:
3450         (WebCore::InspectorController::addMessageToConsole):
3451         (WebCore::InspectorController::addConsoleMessage):
3452         (WebCore::InspectorController::startGroup):
3453         (WebCore::InspectorController::endGroup):
3454         * inspector/InspectorController.h:
3455
3456 2010-10-14  Nikolas Zimmermann  <nzimmermann@rim.com>
3457
3458         Reviewed by Gavin Barraclough.
3459
3460         Replace lots of String::format() usages by StringConcatenate
3461         https://bugs.webkit.org/show_bug.cgi?id=47664
3462
3463         * ForwardingHeaders/wtf/text/StringConcatenate.h: Added.
3464         * bindings/js/JSDOMWindowBase.cpp:
3465         (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
3466         * bindings/v8/V8Proxy.cpp:
3467         (WebCore::V8Proxy::reportUnsafeAccessTo):
3468         * dom/ExceptionBase.cpp:
3469         (WebCore::ExceptionBase::ExceptionBase):
3470         * dom/XMLDocumentParser.cpp:
3471         (WebCore::XMLDocumentParser::handleError):
3472         * history/PageCache.cpp:
3473         (WebCore::logCanCacheFrameDecision):
3474         * html/FTPDirectoryDocument.cpp:
3475         (WebCore::processFileDateString):
3476         * inspector/CodeGeneratorInspector.pm:
3477         * inspector/InspectorController.cpp:
3478         (WebCore::InspectorController::didReceiveResponse):
3479         (WebCore::InspectorController::count):
3480         * inspector/InspectorDOMAgent.cpp:
3481         (WebCore::InspectorDOMAgent::createBreakpointId):
3482         * inspector/InspectorDebuggerAgent.cpp:
3483         (WebCore::formatBreakpointId):
3484         * inspector/InspectorProfilerAgent.cpp:
3485         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
3486         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
3487         (WebCore::InspectorProfilerAgent::getCurrentUserInitiatedProfileName):
3488         (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
3489         * loader/CachedResourceLoader.cpp:
3490         (WebCore::CachedResourceLoader::printAccessDeniedMessage):
3491         * loader/FrameLoader.cpp:
3492         (WebCore::FrameLoader::checkIfDisplayInsecureContent):
3493         (WebCore::FrameLoader::checkIfRunInsecureContent):
3494         (WebCore::FrameLoader::shouldAllowNavigation):
3495         * loader/archive/cf/LegacyWebArchive.cpp:
3496         (WebCore::LegacyWebArchive::createFromSelection):
3497         * page/DOMWindow.cpp:
3498         (WebCore::DOMWindow::postMessageTimerFired):
3499         * page/PrintContext.cpp:
3500         (WebCore::PrintContext::pageProperty):
3501         (WebCore::PrintContext::pageSizeAndMarginsInPixels):
3502         * page/XSSAuditor.cpp:
3503         (WebCore::XSSAuditor::canLoadObject):
3504         * platform/efl/PlatformKeyboardEventEfl.cpp:
3505         (WebCore::createKeyMap):
3506         (WebCore::createWindowsKeyMap):
3507         * platform/graphics/GraphicsLayer.cpp:
3508         (WebCore::GraphicsLayer::animationNameForTransition):
3509         * platform/graphics/brew/ImageBrew.cpp:
3510         (WebCore::Image::loadPlatformResource):
3511         * platform/graphics/cg/ImageBufferCG.cpp:
3512         (WebCore::ImageBuffer::toDataURL):
3513         * platform/graphics/efl/ImageEfl.cpp:
3514         (WebCore::loadResourceSharedBuffer):
3515         * platform/graphics/gtk/ImageBufferGtk.cpp:
3516         (WebCore::ImageBuffer::toDataURL):
3517         * platform/graphics/haiku/ImageBufferHaiku.cpp:
3518         (WebCore::ImageBuffer::toDataURL):
3519         * platform/graphics/mac/GraphicsLayerCA.mm:
3520         (WebCore::animationIdentifier):
3521         * platform/graphics/qt/ImageBufferQt.cpp:
3522         (WebCore::ImageBuffer::toDataURL):
3523         * platform/graphics/skia/ImageBufferSkia.cpp:
3524         (WebCore::ImageBuffer::toDataURL):
3525         * platform/graphics/win/WebLayer.cpp:
3526         (WebCore::WebLayer::drawInContext):
3527         * platform/network/CredentialStorage.cpp:
3528         (WebCore::originStringFromURL):
3529         * platform/sql/SQLiteDatabase.cpp:
3530         (WebCore::SQLiteDatabase::setSynchronous):
3531         * platform/text/wince/TextCodecWinCE.cpp:
3532         (WebCore::LanguageManager::LanguageManager):
3533         * platform/win/ClipboardUtilitiesWin.cpp:
3534         (WebCore::markupToCFHTML):
3535         * platform/win/Language.cpp:
3536         (WebCore::defaultLanguage):
3537         * plugins/PluginStream.cpp:
3538         (WebCore::PluginStream::startStream):
3539         * svg/SVGUseElement.cpp:
3540         (WebCore::dumpInstanceTree):
3541         * websockets/WebSocket.cpp:
3542         (WebCore::WebSocket::connect):
3543         * websockets/WebSocketChannel.cpp:
3544         (WebCore::WebSocketChannel::appendToBuffer):
3545         * websockets/WebSocketHandshake.cpp:
3546         (WebCore::WebSocketHandshake::readServerHandshake):
3547
3548 2010-10-14  Xan Lopez  <xlopez@igalia.com>
3549
3550         Reviewed by Martin Robinson.
3551
3552         [GTK] Small cleanup in PluginViewGtk
3553         https://bugs.webkit.org/show_bug.cgi?id=47588
3554
3555         Remove some dead code and use PlatformRefPtr for cairo surfaces.
3556
3557         No new tests, only refactoring.
3558
3559         * plugins/gtk/PluginViewGtk.cpp:
3560         (WebCore::PluginView::paint):
3561
3562 2010-10-14  Dawit Alemayehu  <adawit@kde.org>
3563
3564         Reviewed by Andreas Kling.
3565
3566         Fix compile error when bulding webkit's Qt port using the "--v8" option.
3567         https://bugs.webkit.org/show_bug.cgi?id=47455
3568
3569         * platform/qt/PlatformBridge.h:
3570
3571 2010-10-01  Martin Robinson  <mrobinson@igalia.com>
3572
3573         Reviewed by Holger Freyther.
3574
3575         [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
3576         https://bugs.webkit.org/show_bug.cgi?id=47033
3577
3578         Fix logic that merges XSettings defaults and FontConfig settings. If
3579         FontConfig or XSettings specifies a subpixel order, we force subpixel
3580         anti-aliasing on. If anti-aliasing is turned on explicitly, only
3581         override the setting if it was previously off, otherwise we ignore
3582         the user's preference for subpixel or gray antialiasing.
3583