83754ca51888cede92e4f8c4136f6a55854c973c
[WebKit-https.git] / WebCore / ChangeLog
1 2007-07-04  Adam Roben  <aroben@apple.com>
2
3         Restore MouseEventWithHitTestResults::targetNode's old behavior
4
5         Reviewed by Mark.
6
7         Fixes fast/images/imagemap-case and fast/replace/image-map.
8
9         * page/MouseEventWithHitTestResults.cpp:
10         (WebCore::MouseEventWithHitTestResults::targetNode): Use the inner
11         node, not the inner non-shared node.
12
13 2007-07-04  Adam Roben  <aroben@apple.com>
14
15         Mac, Qt, and Gdk build fixes.
16
17         * page/EventHandler.h:
18         * page/gdk/EventHandlerGdk.cpp:
19         * page/mac/EventHandlerMac.mm:
20         (WebCore::EventHandler::passSubframeEventToSubframe):
21         * page/qt/EventHandlerQt.cpp:
22
23 2007-07-04  Adam Roben  <aroben@apple.com>
24
25         Fix the Qt/Gdk builds.
26
27         * page/gdk/EventHandlerGdk.cpp:
28         * page/qt/EventHandlerQt.cpp:
29
30 2007-07-04  Adam Roben  <aroben@apple.com>
31
32         Move tooltip logic down into WebCore so that it can be shared cross-platform
33
34         Reviewed by Sam.
35
36         * page/Chrome.cpp:
37         (WebCore::Chrome::setToolTip): Added.
38         * page/Chrome.h:
39         * page/ChromeClient.h:
40         * page/EventHandler.cpp:
41         (WebCore::EventHandler::mouseMoved): Call Chrome::setToolTip.
42         * platform/graphics/svg/SVGImageEmptyClients.h:
43
44         Added stubs for Gdk:
45
46         * platform/gdk/ChromeClientGdk.h:
47         * platform/gdk/TemporaryLinkStubs.cpp:
48         (ChromeClientGdk::setToolTip):
49
50 2007-07-04  Adam Roben  <aroben@apple.com>
51
52         Add Settings::showsURLsInToolTips
53
54         Reviewed by Sam.
55
56         * WebCore.exp:
57         * page/Settings.cpp:
58         (WebCore::Settings::Settings):
59         * page/Settings.h:
60
61 2007-07-04  Adam Roben  <aroben@apple.com>
62
63         Move logic for calling mouseDidMoveOverElement into WebCore
64
65         Reviewed by Sam.
66
67         * page/EventHandler.cpp:
68         (WebCore::EventHandler::mouseMoved): Added. Calls Chrome::mouseDidMoveOverElement.
69         (WebCore::EventHandler::handleMouseMoveEvent): Now takes an optional
70         HitTestResult* parameter which is used to communicate to the caller the
71         node the mouse is over.
72         * page/EventHandler.h:
73         * page/mac/EventHandlerMac.mm:
74         (WebCore::EventHandler::mouseMoved): Changed to call the overloaded
75         mouseMoved().
76         (WebCore::EventHandler::passMouseMoveEventToSubframe): Pass hoveredNode
77         through to the subframe so we can get the deepest node hovered, not
78         just the node's parent frame.
79         * page/win/EventHandlerWin.cpp:
80         (WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.
81
82 2007-07-04  Adam Roben  <aroben@apple.com>
83
84         Add Chrome::mouseDidMoveOverElement
85
86         This does the work of calling up to the ChromeClient (which will call
87         the UI delegate).
88
89         Reviewed by Sam.
90
91         * page/Chrome.cpp:
92         (WebCore::Chrome::mouseDidMoveOverElement): Added.
93         * page/Chrome.h:
94         * page/ChromeClient.h:
95         * platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to
96         ChromeClient.
97         * platform/gdk/ChromeClientGdk.h:
98         * platform/gdk/TemporaryLinkStubs.cpp:
99         (ChromeClientGdk::mouseDidMoveOverElement):
100
101 2007-07-04  Adam Roben  <aroben@apple.com>
102
103         Changed PlatformMouseEvent to store the modifier flags of the event
104
105         Reviewed by Sam.
106
107         * platform/PlatformMouseEvent.h:
108         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
109         * platform/mac/PlatformMouseEventMac.mm:
110         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
111         * platform/win/PlatformMouseEventWin.cpp:
112         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
113
114 2007-07-04  Adam Roben  <aroben@apple.com>
115
116         Add HitTestResult::setToNonShadowAncestor
117
118         Reviewed by Sam.
119
120         * page/EventHandler.cpp:
121         (WebCore::EventHandler::hitTestResultAtPoint): Moved logic into
122         HitTestResult::setToNonShadowAncestor.
123         * rendering/HitTestResult.cpp:
124         (WebCore::HitTestResult::setToNonShadowAncestor):
125         * rendering/HitTestResult.h:
126
127 2007-07-04  Adam Roben  <aroben@apple.com>
128
129         Change MouseEventWithHitTestResults to hold onto a HitTestResult
130
131         Reviewed by Sam.
132
133         * dom/Document.cpp:
134         (WebCore::Document::prepareMouseEvent):
135         * page/MouseEventWithHitTestResults.cpp:
136         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
137         (WebCore::MouseEventWithHitTestResults::targetNode):
138         (WebCore::MouseEventWithHitTestResults::localPoint):
139         (WebCore::MouseEventWithHitTestResults::scrollbar):
140         * page/MouseEventWithHitTestResults.h:
141         (WebCore::MouseEventWithHitTestResults::event):
142         (WebCore::MouseEventWithHitTestResults::hitTestResult):
143
144 2007-07-04  Matt Lilek  <pewtermoose@gmail.com>
145
146         Not reviewed, gdk build fix.
147
148         * platform/gdk/FrameGdk.cpp:
149
150 2007-07-05  Antti Koivisto  <antti@apple.com>
151
152         Reviewed by John.
153         
154         Fix Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
155         <rdar://problem/5237811>
156         
157         It is possible to add table parts (thead etc) without table ancestor to a document fragment. If a new table element
158         was added to such a part, as in
159         
160         div.innerHTML = '<tbody><table>';
161         
162         the parser error handling code would try to pop the previous table as normal. However since
163         the table does not actually exist nothing would happen and parser would go to infinite recursion.
164         
165         Solution here is to pop table parts one by one when handling the error inside a fragment instead of trying to pop
166         the table straight away (as it might not exist).
167
168         * html/HTMLParser.cpp:
169         (WebCore::HTMLParser::handleError):
170
171 2007-07-04  Qing Zhao  <qing@staikos.net>
172
173         Reviewed by George Staikos.
174
175         Draw menulist (comboboxes) without text overlap on the button.
176
177         * platform/qt/RenderThemeQt.cpp:
178         (WebCore::RenderThemeQt::setPopupPadding):
179
180 2007-07-04  George Staikos  <staikos@kde.org>
181
182         Compile
183
184         * page/qt/FrameQt.cpp:
185         * WebCore.pro:
186
187 2007-07-04  Sam Weinig  <sam@webkit.org>
188
189         Reviewed by Mitz.
190
191         Patch for http://bugs.webkit.org/show_bug.cgi?id=14504
192         REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly
193
194         - Made it possible (again) to shadow window properties with local variable names.
195
196         Test: fast/dom/Window/window-property-shadowing.html
197
198         * bindings/js/JSDOMWindowCustom.cpp:
199         (WebCore::JSDOMWindow::customPut):
200         * bindings/js/kjs_window.cpp:
201         (KJS::Window::put):
202         * bindings/scripts/CodeGeneratorJS.pm:
203         * page/DOMWindow.idl:
204
205 2007-07-03  Alice Liu  <alice.liu@apple.com>
206
207         Reviewed by Adam.
208
209         Fixed <rdar://problem/5225119> support smart pasting on Windows
210
211         * WebCore.vcproj/WebCore.vcproj:
212         * WebCore.xcodeproj/project.pbxproj:
213             Added new files
214         * editing/SmartReplace.cpp: Added.
215         (WebCore::isCharacterSmartReplaceExempt):
216             Added non-CF implementation placeholder
217         * editing/SmartReplace.h: Added.
218         * editing/SmartReplaceCF.cpp: Added.
219         (WebCore::getSmartSet):
220         (WebCore::isCharacterSmartReplaceExempt):
221             Added new implementation
222
223         * bridge/win/FrameWin.cpp:
224         * page/Frame.h:
225         * page/mac/FrameMac.mm:
226             Removed old declaration and implementation
227
228         * editing/ReplaceSelectionCommand.cpp:
229         (WebCore::ReplaceSelectionCommand::doApply):
230             Changed to call the new function instead of old
231
232         * page/mac/WebCoreFrameBridge.h:
233         * page/mac/WebCoreFrameBridge.mm:
234             Removed old declaration and implementation
235         (-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):
236             Changed to call the new function instead of old
237
238         * platform/win/PasteboardWin.cpp:
239         (WebCore::Pasteboard::Pasteboard):
240             Register new clipboard format
241         (WebCore::Pasteboard::writeSelection):
242             Set data for smartpaste format on clipboard
243         (WebCore::Pasteboard::canSmartReplace):
244             Added non-stub implementation
245
246 2007-07-04  Qing Zhao  <qing@staikos.net>
247
248         Reviewed by George Staikos.
249
250         Similar to the PlatformScrollbar fixes, adjust the painter to make the
251         styler draw all subcontrols, and in this case the focus rect, in the
252         proper location
253
254         * platform/qt/RenderThemeQt.cpp:
255         (WebCore::RenderThemeQt::paintMenuList):
256
257 2007-07-04  Mitz Pettel  <mitz@webkit.org>
258
259         Reviewed by Maciej.
260
261         - fix http://bugs.webkit.org/show_bug.cgi?id=14495
262           REGRESSION: Wrong cursor is displayed during drag and drop when text is selected
263           <rdar://problem/5312384>
264
265         No test possible because DumpRenderTree cannot query the current cursor.
266
267         * page/EventHandler.cpp:
268         (WebCore::EventHandler::selectCursor): Changed into a member function and
269         added that if the last mouse down event could not have started a
270         selection, then the cursor should not change to an I-beam unconditionally.
271         (WebCore::EventHandler::handleMouseMoveEvent):
272         * page/EventHandler.h:
273
274 2007-07-04  Holger Hans Peter Freyther  <zecke@selfish.org>
275
276         Reviewed by Rob Buis.
277
278         A little progress in tracking dependencies.
279
280         * WebCore.pro: Add DEPENDPATH for the Gdk port.
281
282 2007-07-03  Darin Adler  <darin@apple.com>
283
284         Reviewed by Tim Hatcher.
285
286         - fix <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
287
288         Test: editing/style/font-family-with-space.html
289
290         * css/FontFamilyValue.cpp:
291         (WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does.
292         (WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just
293         checking for a leading "#" character.
294         * editing/markup.cpp:
295         (WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency.
296         (WebCore::renderedText): Changed to return a String for better efficiency.
297         (WebCore::addNamespace): Updated to pass String to escapeTextForMarkup.
298         (WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call
299         to escapeTextForMarkup in the special case for the style property.
300         (WebCore::createMarkup): Changed from single quotes to double quotes and also added missing
301         call to escapeTextForMarkup in two special cases for the style property.
302
303 2007-07-03  Sam Weinig  <sam@webkit.org>
304
305         Reviewed by Darin.
306
307         Twelfth round of fixes for implicit 64-32 bit conversion errors.
308         <rdar://problem/5292262>
309
310         - Add casts and accompanying FIXMEs to avoid remaining compiler errors.
311
312         * WebCore.xcodeproj/project.pbxproj:
313         * loader/FrameLoader.cpp:
314         (WebCore::FrameLoader::opened):
315         (WebCore::FrameLoader::sendRemainingDelegateMessages):
316         * loader/FrameLoader.h:
317         * loader/ResourceLoader.cpp:
318         (WebCore::ResourceLoader::didReceiveData):
319         * platform/network/mac/ResourceHandleMac.mm:
320         (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
321         (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
322         * platform/network/mac/ResourceResponseMac.mm:
323         (WebCore::ResourceResponse::nsURLResponse):
324
325 2007-07-03  Anders Carlsson  <andersca@apple.com>
326
327         Reviewed by Adam.
328
329         <rdar://problem/5093862>
330         Nothing shown in plugin area when trying to play content using the DivX plugin
331         
332         Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.
333                 
334         * plugins/win/PluginViewWin.cpp:
335         (WebCore::PluginViewWin::determineQuirks):
336
337 2007-07-03  Sam Weinig  <sam@webkit.org>
338
339         Reviewed by Brady Eidson.
340
341         Ninth round of fixes for implicit 64-32 bit conversion errors.
342         <rdar://problem/5292262>
343
344         - Fix function signature to use unsigned long instead of unsigned long long.
345
346         * loader/ProgressTracker.cpp:
347         (WebCore::ProgressTracker::completeProgress):
348         * loader/ProgressTracker.h:
349
350 2007-07-03  Sam Weinig  <sam@webkit.org>
351
352         Reviewed by Oliver.
353
354         Eighth round of fixes for implicit 64-32 bit conversion errors.
355         <rdar://problem/5292262>
356
357         - Convert SVG implementation files to use floats instead of doubles
358           to match the spec/IDLs.
359
360         * bindings/scripts/CodeGeneratorJS.pm:
361         * ksvg2/svg/SVGAngle.cpp:
362         * ksvg2/svg/SVGAnimatedTemplate.h:
363         * ksvg2/svg/SVGAnimationElement.cpp:
364         (WebCore::SVGAnimationElement::getEndTime):
365         (WebCore::SVGAnimationElement::getStartTime):
366         (WebCore::SVGAnimationElement::getCurrentTime):
367         (WebCore::SVGAnimationElement::getSimpleDuration):
368         * ksvg2/svg/SVGAnimationElement.h:
369         * ksvg2/svg/SVGFitToViewBox.cpp:
370         (WebCore::SVGFitToViewBox::parseViewBox):
371         * ksvg2/svg/SVGLength.cpp:
372         (WebCore::SVGLength::setValueAsString):
373         * ksvg2/svg/SVGLinearGradientElement.cpp:
374         (WebCore::SVGLinearGradientElement::buildGradient):
375         * ksvg2/svg/SVGMatrix.idl:
376         * ksvg2/svg/SVGNumber.idl:
377         * ksvg2/svg/SVGParserUtilities.cpp:
378         (WebCore::SVGPathParser::parseSVG):
379         (WebCore::SVGPathParser::calculateArc):
380         (WebCore::SVGPathParser::svgLineToHorizontal):
381         (WebCore::SVGPathParser::svgLineToVertical):
382         (WebCore::SVGPathParser::svgCurveToCubicSmooth):
383         (WebCore::SVGPathParser::svgCurveToQuadratic):
384         (WebCore::SVGPathParser::svgCurveToQuadraticSmooth):
385         (WebCore::SVGPathParser::svgArcTo):
386         * ksvg2/svg/SVGParserUtilities.h:
387         * ksvg2/svg/SVGPathElement.cpp:
388         (WebCore::SVGPathElement::SVGPathElement):
389         (WebCore::SVGPathElement::getTotalLength):
390         (WebCore::SVGPathElement::getPointAtLength):
391         (WebCore::SVGPathElement::getPathSegAtLength):
392         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
393         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
394         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
395         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
396         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
397         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
398         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
399         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
400         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
401         (WebCore::SVGPathElement::createSVGPathSegArcRel):
402         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
403         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
404         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
405         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
406         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
407         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
408         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
409         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
410         (WebCore::SVGPathElement::svgMoveTo):
411         (WebCore::SVGPathElement::svgLineTo):
412         (WebCore::SVGPathElement::svgLineToHorizontal):
413         (WebCore::SVGPathElement::svgLineToVertical):
414         (WebCore::SVGPathElement::svgCurveToCubic):
415         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
416         (WebCore::SVGPathElement::svgCurveToQuadratic):
417         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
418         (WebCore::SVGPathElement::svgArcTo):
419         (WebCore::SVGPathElement::parseMappedAttribute):
420         * ksvg2/svg/SVGPathElement.h:
421         * ksvg2/svg/SVGPathSegArc.cpp:
422         (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
423         (WebCore::SVGPathSegArcAbs::setX):
424         (WebCore::SVGPathSegArcAbs::x):
425         (WebCore::SVGPathSegArcAbs::setY):
426         (WebCore::SVGPathSegArcAbs::y):
427         (WebCore::SVGPathSegArcAbs::setR1):
428         (WebCore::SVGPathSegArcAbs::r1):
429         (WebCore::SVGPathSegArcAbs::setR2):
430         (WebCore::SVGPathSegArcAbs::r2):
431         (WebCore::SVGPathSegArcAbs::setAngle):
432         (WebCore::SVGPathSegArcAbs::angle):
433         (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
434         (WebCore::SVGPathSegArcRel::setX):
435         (WebCore::SVGPathSegArcRel::x):
436         (WebCore::SVGPathSegArcRel::setY):
437         (WebCore::SVGPathSegArcRel::y):
438         (WebCore::SVGPathSegArcRel::setR1):
439         (WebCore::SVGPathSegArcRel::r1):
440         (WebCore::SVGPathSegArcRel::setR2):
441         (WebCore::SVGPathSegArcRel::r2):
442         (WebCore::SVGPathSegArcRel::setAngle):
443         (WebCore::SVGPathSegArcRel::angle):
444         * ksvg2/svg/SVGPathSegArc.h:
445         * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
446         (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
447         (WebCore::SVGPathSegCurvetoCubicAbs::setX):
448         (WebCore::SVGPathSegCurvetoCubicAbs::x):
449         (WebCore::SVGPathSegCurvetoCubicAbs::setY):
450         (WebCore::SVGPathSegCurvetoCubicAbs::y):
451         (WebCore::SVGPathSegCurvetoCubicAbs::setX1):
452         (WebCore::SVGPathSegCurvetoCubicAbs::x1):
453         (WebCore::SVGPathSegCurvetoCubicAbs::setY1):
454         (WebCore::SVGPathSegCurvetoCubicAbs::y1):
455         (WebCore::SVGPathSegCurvetoCubicAbs::setX2):
456         (WebCore::SVGPathSegCurvetoCubicAbs::x2):
457         (WebCore::SVGPathSegCurvetoCubicAbs::setY2):
458         (WebCore::SVGPathSegCurvetoCubicAbs::y2):
459         (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
460         (WebCore::SVGPathSegCurvetoCubicRel::setX):
461         (WebCore::SVGPathSegCurvetoCubicRel::x):
462         (WebCore::SVGPathSegCurvetoCubicRel::setY):
463         (WebCore::SVGPathSegCurvetoCubicRel::y):
464         (WebCore::SVGPathSegCurvetoCubicRel::setX1):
465         (WebCore::SVGPathSegCurvetoCubicRel::x1):
466         (WebCore::SVGPathSegCurvetoCubicRel::setY1):
467         (WebCore::SVGPathSegCurvetoCubicRel::y1):
468         (WebCore::SVGPathSegCurvetoCubicRel::setX2):
469         (WebCore::SVGPathSegCurvetoCubicRel::x2):
470         (WebCore::SVGPathSegCurvetoCubicRel::setY2):
471         (WebCore::SVGPathSegCurvetoCubicRel::y2):
472         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
473         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
474         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
475         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX):
476         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x):
477         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY):
478         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y):
479         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX2):
480         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x2):
481         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY2):
482         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y2):
483         (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
484         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX):
485         (WebCore::SVGPathSegCurvetoCubicSmoothRel::x):
486         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY):
487         (WebCore::SVGPathSegCurvetoCubicSmoothRel::y):
488         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX2):
489         (WebCore::SVGPathSegCurvetoCubicSmoothRel::x2):
490         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY2):
491         (WebCore::SVGPathSegCurvetoCubicSmoothRel::y2):
492         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
493         * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
494         (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
495         (WebCore::SVGPathSegCurvetoQuadraticAbs::setX):
496         (WebCore::SVGPathSegCurvetoQuadraticAbs::x):
497         (WebCore::SVGPathSegCurvetoQuadraticAbs::setY):
498         (WebCore::SVGPathSegCurvetoQuadraticAbs::y):
499         (WebCore::SVGPathSegCurvetoQuadraticAbs::setX1):
500         (WebCore::SVGPathSegCurvetoQuadraticAbs::x1):
501         (WebCore::SVGPathSegCurvetoQuadraticAbs::setY1):
502         (WebCore::SVGPathSegCurvetoQuadraticAbs::y1):
503         (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
504         (WebCore::SVGPathSegCurvetoQuadraticRel::setX):
505         (WebCore::SVGPathSegCurvetoQuadraticRel::x):
506         (WebCore::SVGPathSegCurvetoQuadraticRel::setY):
507         (WebCore::SVGPathSegCurvetoQuadraticRel::y):
508         (WebCore::SVGPathSegCurvetoQuadraticRel::setX1):
509         (WebCore::SVGPathSegCurvetoQuadraticRel::x1):
510         (WebCore::SVGPathSegCurvetoQuadraticRel::setY1):
511         (WebCore::SVGPathSegCurvetoQuadraticRel::y1):
512         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
513         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
514         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
515         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
516         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setX):
517         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::x):
518         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setY):
519         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::y):
520         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
521         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setX):
522         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::x):
523         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setY):
524         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::y):
525         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
526         * ksvg2/svg/SVGPathSegLineto.cpp:
527         (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
528         (WebCore::SVGPathSegLinetoAbs::setX):
529         (WebCore::SVGPathSegLinetoAbs::x):
530         (WebCore::SVGPathSegLinetoAbs::setY):
531         (WebCore::SVGPathSegLinetoAbs::y):
532         (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
533         (WebCore::SVGPathSegLinetoRel::setX):
534         (WebCore::SVGPathSegLinetoRel::x):
535         (WebCore::SVGPathSegLinetoRel::setY):
536         (WebCore::SVGPathSegLinetoRel::y):
537         * ksvg2/svg/SVGPathSegLineto.h:
538         * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
539         (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
540         (WebCore::SVGPathSegLinetoHorizontalAbs::setX):
541         (WebCore::SVGPathSegLinetoHorizontalAbs::x):
542         (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
543         (WebCore::SVGPathSegLinetoHorizontalRel::setX):
544         (WebCore::SVGPathSegLinetoHorizontalRel::x):
545         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
546         * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
547         (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
548         (WebCore::SVGPathSegLinetoVerticalAbs::setY):
549         (WebCore::SVGPathSegLinetoVerticalAbs::y):
550         (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
551         (WebCore::SVGPathSegLinetoVerticalRel::setY):
552         (WebCore::SVGPathSegLinetoVerticalRel::y):
553         * ksvg2/svg/SVGPathSegLinetoVertical.h:
554         * ksvg2/svg/SVGPathSegList.cpp:
555         (WebCore::SVGPathSegList::getPathSegAtLength):
556         * ksvg2/svg/SVGPathSegList.h:
557         * ksvg2/svg/SVGPathSegMoveto.cpp:
558         (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
559         (WebCore::SVGPathSegMovetoAbs::setX):
560         (WebCore::SVGPathSegMovetoAbs::x):
561         (WebCore::SVGPathSegMovetoAbs::setY):
562         (WebCore::SVGPathSegMovetoAbs::y):
563         (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
564         (WebCore::SVGPathSegMovetoRel::setX):
565         (WebCore::SVGPathSegMovetoRel::x):
566         (WebCore::SVGPathSegMovetoRel::setY):
567         (WebCore::SVGPathSegMovetoRel::y):
568         * ksvg2/svg/SVGPathSegMoveto.h:
569         * ksvg2/svg/SVGPolyElement.cpp:
570         (WebCore::SVGPolyElement::svgPolyTo):
571         * ksvg2/svg/SVGRadialGradientElement.cpp:
572         (WebCore::SVGRadialGradientElement::buildGradient):
573         * ksvg2/svg/SVGSVGElement.cpp:
574         (WebCore::SVGSVGElement::viewport):
575         (WebCore::SVGSVGElement::getCurrentTime):
576         * ksvg2/svg/SVGStopElement.cpp:
577         (WebCore::SVGStopElement::SVGStopElement):
578         (WebCore::SVGStopElement::parseMappedAttribute):
579         * ksvg2/svg/SVGStopElement.h:
580         * ksvg2/svg/SVGTransform.cpp:
581         (SVGTransform::translate):
582         (SVGTransform::scale):
583         * ksvg2/svg/SVGTransformDistance.cpp:
584         (WebCore::SVGTransformDistance::addToSVGTransform):
585         (WebCore::SVGTransformDistance::distance):
586         * ksvg2/svg/SVGTransformable.cpp:
587         (WebCore::SVGTransformable::parseTransformAttribute):
588
589 2007-07-03  Anders Carlsson  <andersca@apple.com>
590
591         Reviewed by Darin.
592
593         <rdar://problem/5289718>
594         http://bugs.webkit.org/show_bug.cgi?id=14437
595         CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)
596         
597         Based on a patch from Maxime Britto.
598         
599         * page/mac/WebCoreFrameBridge.mm:
600         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
601         If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys
602         its frame.
603
604         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
605         ASSERT that this is only called on the main frame.
606
607 2007-07-03  John Sullivan  <sullivan@apple.com>
608
609         Written by Darin, reviewed by me
610         
611         - fixed <rdar://problem/5249730> REGRESSION (Leopard, around 9A464): Safari opens the same local 
612           documents more than once due to canonicalization change
613
614         * loader/mac/LoaderNSURLExtras.m:
615         (canonicalURL):
616         pass URL through KURL so we get KURL's version of canonicalization as well as
617         NSURLProtocol's version of canonicalization
618
619 2007-07-03  Sam Weinig  <sam@webkit.org>
620
621         Reviewed by Darin.
622
623         Seventh round of fixes for implicit 64-32 bit conversion errors.
624         <rdar://problem/5292262>
625
626         - Adds more narrowPrecision functions to FloatPoint, FloatSize and FloatRect.
627         - Changes over more implicit conversions to use new functions.
628
629         * bindings/js/kjs_window.cpp:
630         (KJS::WindowFunc::callAsFunction):
631         * platform/graphics/FloatPoint.cpp:
632         (WebCore::FloatPoint::matrixTransform):
633         (WebCore::FloatPoint::narrowPrecision):
634         * platform/graphics/FloatPoint.h:
635         * platform/graphics/FloatRect.cpp:
636         (WebCore::FloatRect::narrowPrecision):
637         * platform/graphics/FloatRect.h:
638         * platform/graphics/FloatSize.cpp:
639         (WebCore::FloatSize::narrowPrecision):
640         * platform/graphics/FloatSize.h:
641         * platform/graphics/Path.cpp:
642         (WebCore::Path::createRoundedRectangle):
643         (WebCore::Path::createRectangle):
644         (WebCore::Path::createEllipse):
645         * platform/graphics/mac/ColorMac.mm:
646         (WebCore::nsColor):
647         * platform/graphics/mac/IconMac.mm:
648         (WebCore::Icon::paint):
649         * platform/graphics/svg/cg/CgSupport.cpp:
650         (WebCore::applyStrokeStyleToContext):
651         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
652         (WebCore::CGShadingRefForRadialGradient):
653         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
654         (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
655         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
656         (WebCore::applyLuminanceToAlphaFilter):
657         (WebCore::applyExpandAlphatoGrayscaleFilter):
658         (WebCore::transformImageIntoGrayscaleMask):
659         * platform/mac/WebCoreTextRenderer.mm:
660         (WebCoreDrawTextAtPoint):
661         * rendering/RenderPath.cpp:
662         (WebCore::RenderPath::mapAbsolutePointToLocal):
663         * rendering/RenderSVGContainer.cpp:
664         (WebCore::RenderSVGContainer::calcViewport):
665         * rendering/RenderSVGImage.cpp:
666         (WebCore::RenderSVGImage::nodeAtPoint):
667         * rendering/RenderSVGText.cpp:
668         (WebCore::RenderSVGText::relativeBBox):
669
670 2007-07-03  Anders Carlsson  <andersca@apple.com>
671
672         Reviewed by Adam.
673
674         <rdar://problem/5261523>
675         Crash playing MP11 on cnbc.com
676         
677         The WMP Netscape plugin still creates a window even when windowless mode is turned on. Work around this by
678         always removing the "windowlessvideo" parameter before passing it to the plugin.
679         According to http://msdn2.microsoft.com/en-us/library/bb249373.aspx, "The windowlessVideo property is not 
680         supported for Netscape Navigator. Setting a value for this property in Navigator may yield unexpected results."
681         
682         * plugins/win/PluginViewWin.cpp:
683         (WebCore::PluginViewWndProc):
684         (WebCore::PluginViewWin::paint):
685         (WebCore::PluginViewWin::invalidateRect):
686         (WebCore::PluginViewWin::determineQuirks):
687         (WebCore::PluginViewWin::setParameters):
688         (WebCore::PluginViewWin::PluginViewWin):
689         (WebCore::PluginViewWin::init):
690         * plugins/win/PluginViewWin.h:
691         (WebCore::):
692
693 2007-07-03  Qing Zhao  <qing@staikos.net>
694
695         Reviewed by George Staikos.
696
697         Only draw sunken state for appropriate widgets. Not, for example, for
698         lineedits.
699
700         * platform/qt/RenderThemeQt.cpp:
701         (WebCore::RenderThemeQt::applyTheme):
702
703 2007-07-03  Antti Koivisto  <antti@apple.com>
704
705         Reviewed by Maciej.
706         
707         REGRESSION: misplaced selection ring remains after link is no longer focused.
708         <rdar://problem/5205580>
709         
710         Fix placement of selection ring when part of the ring is in a different layer.
711
712         * rendering/RenderFlow.cpp:
713         (WebCore::RenderFlow::addFocusRingRects): Get coordinates right when moving to a different layer.
714         * rendering/RenderObject.cpp:
715         (WebCore::RenderObject::setStyle): 
716         Don't reset state variables when not necessary.  When repaint() was called at the end of setSyle() it would
717         get repaint rects wrong in some cases.
718
719 2007-07-03  Antti Koivisto  <antti@apple.com>
720
721         Reviewed by Maciej.
722
723         Blind fix for CrashTracer: [USER] 25 crashes in Safari at com.apple.WebCore: WebCore::Frame::document const + 6
724         <rdar://problem/5263939>
725         
726         No one has managed to reproduce this but it looks like null check is needed here. There are plausible ways
727         m_frame could be null for a live FrameView object.
728
729         * page/FrameView.cpp:
730         (WebCore::FrameView::needsLayout):
731
732 2007-07-02  Oliver Hunt  <oliver@apple.com>
733
734         Reviewed by Darin.
735
736         Fix for <rdar://problem/5098378> single-pixel image optimization needs to be rewritten to not depend on floating point bitmap
737         Tested by fast/replaced/image-solid-color-with-alpha.html
738
739         Switch from float to byte based bitmap when pulling the color from 1x1 pixel images so
740         that we can use the single pixel image optimisation in WebKit/win.
741
742         * platform/graphics/cg/ImageCG.cpp:
743         (WebCore::BitmapImage::checkForSolidColor):
744
745 2007-07-02  Adam Roben  <aroben@apple.com>
746
747         Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
748         http://bugs.webkit.org/show_bug.cgi?id=14498
749
750         There were two bugs:
751         1) xPos/yPos were flipped
752         2) + binds tighter than ?:, so the order of operations was incorrect
753
754         Reviewed by Darin.
755
756         Test: fast/inline-block/14498-positionForCoordinates.html
757
758         * rendering/RenderContainer.cpp:
759         (WebCore::RenderContainer::positionForCoordinates):
760
761 2007-07-02  Darin Adler  <darin@apple.com>
762
763         Reviewed by Kevin Decker and Tim Hatcher.
764
765         - fix <rdar://problem/5307906> some classes need finalize methods because
766           of non-trivial work done in dealloc methods
767
768         * bindings/objc/DOMRGBColor.mm:
769         (+[DOMRGBColor initialize]): Added. Tells finalizer to run on main thread,
770         which is needed because we are sharing a CFDictionary here with no locking.
771
772         * bridge/mac/WebCoreAXObject.mm:
773         (+[WebCoreAXObject initialize]): Added. Tells finalizer to run on main thread.
774         (-[WebCoreAXObject finalize]): Added. Calls detach.
775
776         * WebCore.xcodeproj/project.pbxproj: Let Xcode do what it wants to do.
777
778 2007-07-02  Sam Weinig  <sam@webkit.org>
779
780         Reviewed by Darin.
781
782         Sixth round of fixes for implicit 64-32 bit conversion errors.
783         <rdar://problem/5292262>
784
785         Use new narrowPrecisionToFloat() and narrowPrecisionToCGFloat() where
786         appropriate.
787
788         * html/CanvasRenderingContext2D.cpp:
789         (WebCore::CanvasRenderingContext2D::setShadow):
790         (WebCore::CanvasRenderingContext2D::applyShadow):
791         * html/CanvasStyle.cpp:
792         (WebCore::CanvasStyle::applyStrokeColor):
793         (WebCore::CanvasStyle::applyFillColor):
794         * ksvg2/svg/SVGAngle.cpp:
795         * ksvg2/svg/SVGAnimationElement.cpp:
796         (WebCore::SVGAnimationElement::parseKeyNumbers):
797         (WebCore::parseKeySplines):
798         (WebCore::SVGAnimationElement::handleTimerEvent):
799         (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
800         * ksvg2/svg/SVGPatternElement.cpp:
801         (WebCore::SVGPatternElement::buildPattern):
802         * ksvg2/svg/SVGRadialGradientElement.cpp:
803         (WebCore::SVGRadialGradientElement::buildGradient):
804         * platform/graphics/cg/AffineTransformCG.cpp:
805         (WebCore::AffineTransform::AffineTransform):
806         (WebCore::AffineTransform::setMatrix):
807         (WebCore::AffineTransform::map):
808         (WebCore::AffineTransform::setA):
809         (WebCore::AffineTransform::setB):
810         (WebCore::AffineTransform::setC):
811         (WebCore::AffineTransform::setD):
812         (WebCore::AffineTransform::setE):
813         (WebCore::AffineTransform::setF):
814         (WebCore::AffineTransform::scale):
815         (WebCore::AffineTransform::rotate):
816         (WebCore::AffineTransform::translate):
817         (WebCore::AffineTransform::shear):
818
819 2007-07-02  John Sullivan  <sullivan@apple.com>
820
821         * page/mac/WebCoreFrameBridge.mm:
822         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
823         added a comment
824
825 2007-07-02  Sam Weinig  <sam@webkit.org>
826
827         Rubberstamped by Darin.
828
829         Rename FloatConversionUtilities.h to FloatConversion.h.
830         Fix Win32 build.
831
832         * WebCore.vcproj/WebCore.vcproj:
833         * WebCore.xcodeproj/project.pbxproj:
834         * platform/DeprecatedString.cpp:
835         * platform/FloatConversion.h: Copied from platform/FloatConversionUtilities.h.
836         * platform/FloatConversionUtilities.h: Removed.
837         * platform/StringImpl.cpp:
838
839 2007-07-02  Sam Weinig  <sam@webkit.org>
840
841         Reviewed by Darin.
842
843         Fifth round of fixes for implicit 64-32 bit conversion errors.
844         <rdar://problem/5292262>
845
846         Add toFloat() method to string classes and use it where appropriate.
847
848         * WebCore.xcodeproj/project.pbxproj:
849         * css/cssparser.cpp:
850         (WebCore::CSSParser::lex):
851         * ksvg2/svg/SVGAngle.cpp:
852         (WebCore::SVGAngle::setValueAsString):
853         * platform/AtomicString.h:
854         (WebCore::AtomicString::toFloat):
855         * platform/DeprecatedString.cpp:
856         (WebCore::DeprecatedString::toFloat):
857         * platform/DeprecatedString.h:
858         * platform/FloatConversionUtilities.h: Added.
859         (WebCore::narrowPrecisionToFloat):
860         (WebCore::narrowPrecisionToCGFloat):
861         * platform/PlatformString.h:
862         * platform/String.cpp:
863         (WebCore::String::toFloat):
864         * platform/StringImpl.cpp:
865         (WebCore::StringImpl::toFloat):
866         * platform/StringImpl.h:
867
868 2007-07-02  Sam Weinig  <sam@webkit.org>
869
870         Reviewed by Kevin McCullough.
871
872         Fourth round of fixes for implicit 64-32 bit conversion errors.
873         <rdar://problem/5292262>
874
875         Use new piDouble and piFloat constants instead of M_PI.
876
877         * html/CanvasRenderingContext2D.cpp:
878         (WebCore::CanvasRenderingContext2D::rotate):
879         * ksvg2/svg/SVGParserUtilities.cpp:
880         (WebCore::SVGPathParser::calculateArc):
881         * platform/graphics/Path.cpp:
882         (WebCore::pathLengthApplierFunction):
883         (WebCore::Path::createEllipse):
884         * platform/graphics/cg/GraphicsContextCG.cpp:
885         (WebCore::GraphicsContext::drawEllipse):
886         (WebCore::GraphicsContext::strokeArc):
887         * platform/graphics/cg/PDFDocumentImage.cpp:
888         (WebCore::PDFDocumentImage::setCurrentPage):
889         * platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
890         * rendering/RenderPath.cpp:
891         (WebCore::drawMarkerWithData):
892
893 2007-07-01  Adam Roben  <aroben@apple.com>
894
895         Clarify/fix {Shadow,BorderImage}ParseContext's memory management
896
897         Prefast emitted warnings that drew my attention to
898         {Shadow,BorderImage}ParseContext::failed().  It turned out that these
899         methods were actually correct, but rather confusing. "failed" really
900         meant "abort and clean up" rather than "did you fail?", which was
901         unclear. However, once I figured that out, the "and clean up" part was
902         still a bit confusing, because all failed() did was to set a flag that
903         would later cause the ParseContext's members to be deleted in the
904         destructor. To clear this up, I've gotten rid of the failed() method
905         altogether. It always returned false, so I've replaced all calls to
906         it with the value false.
907
908         I also noticed that the lifetime management of the ParseContexts'
909         members was in all cases confusing, and in some cases wrong. The
910         m_border{Top,Right,Bottom,Left} members of BorderImageParseContext
911         were leaked whenever a border-image property was successfully parsed.
912         I fixed that by holding these members in OwnPtrs. The
913         CSSPrimitiveValue members of {Shadow,BorderImage}ParseContext, which
914         inherit from Shared, were being explicitly deleted, which is not a
915         safe way to manage the lifetime of objects that inherit from Shared.
916         To fix this, I put those members inside RefPtrs. These two changes
917         allowed me to remove the destructors entirely.
918
919         Reviewed by Darin.
920
921         All regression tests pass.
922
923         * css/cssparser.cpp:
924         (WebCore::ShadowParseContext::commitValue): Use .release() to avoid
925         ref-count churn.
926         (WebCore::ShadowParseContext::commitLength): Use a RefPtr for the new
927         value to avoid a leak.
928         (WebCore::CSSParser::parseShadow): Use 'false' instead of
929         'context.failed()', and use .release() to avoid ref-count churn.
930         (WebCore::BorderImageParseContext::commitWidth): Updated to use
931         OwnPtr.
932         (WebCore::CSSParser::parseBorderImage): Use 'false' instead of
933         'context.failed'.
934
935 2007-07-01  Anders Carlsson  <andersca@apple.com>
936
937         Reviewed by John Sullivan.
938
939         <rdar://problem/5297146>
940         Crash in Mail at WebCore::Frame::setUserStyleSheetLocation (reproducible w/ particular message)
941         
942         * loader/Cache.cpp:
943         (WebCore::Cache::requestResource):
944         Only insert the resource in the LRU list if the cache is enabled.
945         
946         (WebCore::Cache::insertInLRUList):
947         (WebCore::Cache::resourceAccessed):
948         Assert that the resource is in the cache.
949
950 2007-07-01  Darin Adler  <darin@apple.com>
951
952         * css/tokenizer.flex: Rolled out the fix for 14453.
953         The layout test wasn't passing. We'll try again.
954
955 2007-07-01  Adam Roben  <aroben@apple.com>
956
957         Fix a crash in ~PluginViewWin()
958
959         This crash was introduced in r23827.
960
961         Reviewed by Anders.
962
963         Fixes dom/html/level2/html/HTMLAnchorElement01.html
964
965         * plugins/win/PluginViewWin.cpp:
966         (WebCore::PluginViewWin::~PluginViewWin): Allow m_plugin to be null.
967
968 2007-07-01  Rob Buis  <buis@kde.org>
969
970         Reviewed by Darin.
971
972         http://bugs.webkit.org/show_bug.cgi?id=14453
973         REGRESSION: www.nzherald.co.nz almost all the formating is gone
974  
975         * css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
976
977 2007-07-01  Sam Weinig  <sam@webkit.org>
978
979         Reviewed by Oliver.
980
981         Third round of implicit 64-32 bit conversion errors fixes.
982         <rdar://problem/5292262>
983
984         - Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()
985           methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
986
987         * css/CSSPrimitiveValue.cpp:
988         (WebCore::CSSPrimitiveValue::computeLengthInt):
989         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
990         (WebCore::CSSPrimitiveValue::computeLengthShort):
991         (WebCore::CSSPrimitiveValue::computeLengthFloat):
992         (WebCore::CSSPrimitiveValue::computeLengthDouble):
993         (WebCore::CSSPrimitiveValue::getDoubleValue):
994         * css/CSSPrimitiveValue.h:
995         (WebCore::CSSPrimitiveValue::getDoubleValue):
996         (WebCore::CSSPrimitiveValue::getFloatValue):
997         (WebCore::CSSPrimitiveValue::getIntValue):
998         * css/Counter.h:
999         (WebCore::Counter::listStyleNumber):
1000         * css/MediaQueryEvaluator.cpp:
1001         (WebCore::parseAspectRatio):
1002         * css/cssparser.cpp:
1003         (WebCore::BorderImageParseContext::commitBorderImage):
1004         * css/cssstyleselector.cpp:
1005         (WebCore::convertToLength):
1006         (WebCore::applyCounterList):
1007         (WebCore::CSSStyleSelector::applyProperty):
1008         (WebCore::CSSStyleSelector::mapBackgroundSize):
1009         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
1010         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
1011         * html/HTMLTableElement.cpp:
1012         (WebCore::HTMLTableElement::parseMappedAttribute):
1013         * ksvg2/css/SVGCSSStyleSelector.cpp:
1014         (WebCore::CSSStyleSelector::applySVGProperty):
1015         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1016         (WebCore::KSVGPainterFactory::cssPrimitiveToLength):
1017         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
1018
1019 2007-07-01  Pamela Greene  <pamg.bugs@gmail.com>
1020
1021         Reviewed by Darin.
1022
1023         Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
1024         Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
1025         <rdar://problem/5290084>
1026
1027         Use std::stable_sort() instead of qsort() to sort gradient stops.
1028         Adjust the comparison function accordingly.
1029
1030         * html/CanvasGradient.cpp:
1031         (WebCore::compareStops):
1032         (WebCore::CanvasGradient::findStop):
1033
1034 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
1035
1036         Reviewed by Darin.
1037
1038         m_usesPageCache was not initialized. As the b/f cache is only
1039         implemented in the Mac port and WebView.mm is taking care of calling
1040         Settings::setUsesPageCache I decided to make it false by default.
1041
1042         * page/Settings.cpp:
1043         (WebCore::Settings::Settings): m_usesPageCache was not initialized
1044
1045 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
1046
1047         Reviewed by Darin.
1048
1049         Inherited- and NonInheritedFlags is a bit field. But for comparsion
1050         the other part of the union _iflags/_niflags is used for comparions.
1051         This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
1052         Make sure the unused bits have a specified value.
1053
1054         * ksvg2/css/SVGRenderStyle.h:
1055         (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits
1056         have a value as well.
1057
1058 2007-06-30  Adam Roben  <aroben@apple.com>
1059
1060         Compile WebCore with /W4 on Windows
1061
1062         Some more warnings were disabled globally, including assignment within
1063         a conditional, unused variable, and various warnings related to
1064         inability to instantiate opaque structs.
1065
1066         In addition, the "unreachable code" warning was turned off for
1067         CSSGrammar.cpp and XPathGrammar.cpp.
1068
1069         Reviewed by Oliver.
1070
1071         * WebCore.vcproj/WebCore.vcproj:
1072
1073 2007-06-29  Adam Roben  <aroben@apple.com>
1074
1075         Give CString an equality operator to fix a bug in HTMLFormElement::formData
1076
1077         The bug was spotted by MSVC /W4. The problem was that we were comparing
1078         a CString to a char* using ==, but CString had no equality operator.
1079         The result was that the CString was being cast to a const char* and a
1080         pointer comparison was being done, which would (essentially) always
1081         return false.
1082
1083         There are two parts to the fix: get rid of CString's const char*
1084         casting operator, and add an equality operator. Previous uses of the
1085         casting operator have been changed to use CString::data().
1086
1087         Test: http/misc/isindex-formdata.html
1088
1089         Reviewed by Oliver.
1090
1091         * dom/XMLTokenizer.cpp:
1092         (WebCore::parseXMLDocumentFragment):
1093         * html/HTMLDocument.cpp:
1094         (WebCore::HTMLDocument::determineParseMode):
1095         * html/HTMLFormElement.cpp:
1096         (WebCore::HTMLFormElement::formData):
1097         * loader/TextResourceDecoder.cpp:
1098         (WebCore::TextResourceDecoder::checkForCSSCharset):
1099         * platform/CString.cpp:
1100         (WebCore::operator==):
1101         * platform/CString.h:
1102         * platform/KURL.cpp:
1103         (WebCore::encodeRelativeString):
1104         * platform/StringImpl.cpp:
1105         (WebCore::StringImpl::toDouble):
1106         * platform/network/cf/FormDataStreamCFNet.cpp:
1107         (WebCore::setHTTPBody):
1108         * platform/network/mac/FormDataStreamMac.mm:
1109         (WebCore::setHTTPBody):
1110         * platform/win/ClipboardUtilitiesWin.cpp:
1111         (WebCore::markupToCF_HTML):
1112         * plugins/win/PluginPackageWin.cpp:
1113         (WebCore::splitString):
1114         * plugins/win/PluginStreamWin.cpp:
1115         (WebCore::PluginStreamWin::startStream):
1116         (WebCore::PluginStreamWin::destroyStream):
1117         (WebCore::PluginStreamWin::sendJavaScriptStream):
1118         (WebCore::PluginStreamWin::didFinishLoading):
1119         * plugins/win/PluginViewWin.cpp:
1120         (WebCore::PluginViewWin::start):
1121         (WebCore::createUTF8String):
1122         (WebCore::PluginViewWin::userAgent):
1123         * xml/XSLStyleSheet.cpp:
1124         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
1125         * xml/XSLTProcessor.cpp:
1126         (WebCore::xsltParamArrayFromParameterMap):
1127
1128 2007-06-29  Adam Roben  <aroben@apple.com>
1129
1130         Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
1131
1132         Reviewed by John.
1133
1134         * editing/Editor.cpp:
1135         (WebCore::Editor::advanceToNextMisspelling):
1136         * html/HTMLParser.cpp:
1137
1138 2007-06-29  Adam Roben  <aroben@apple.com>
1139
1140         Fix some possibly unitialized variables found by MSVC /W4
1141
1142         Reviewed by John.
1143
1144         * rendering/bidi.cpp:
1145         (WebCore::RenderBlock::layoutInlineChildren):
1146
1147 2007-06-29  Adam Roben  <aroben@apple.com>
1148
1149         Remove bogus cast found by MSVC /W4
1150
1151         Reviewed by John and Oliver.
1152
1153         * ksvg2/css/SVGCSSParser.cpp:
1154         (WebCore::CSSParser::parseSVGValue):
1155
1156 2007-06-29  Adam Roben  <aroben@apple.com>
1157
1158         Remove unused local functions uncovered by MSVC /W4
1159
1160         Reviewed by John and Oliver.
1161
1162         * platform/win/SearchPopupMenuWin.cpp:
1163         * rendering/RenderText.cpp:
1164
1165 2007-06-29  Adam Roben  <aroben@apple.com>
1166
1167         Don't take the address of temporary values to appease MSVC /W4
1168
1169         Reviewed by Oliver.
1170
1171         No regression test possible.
1172
1173         * platform/win/PopupMenuWin.cpp:
1174         (WebCore::PopupMenu::invalidateItem):
1175         (WebCore::PopupMenu::valueChanged):
1176         (WebCore::PopupWndProc):
1177         * platform/win/ScrollViewWin.cpp:
1178         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
1179         * platform/win/UniscribeController.cpp:
1180         (WebCore::UniscribeController::shapeAndPlaceItem):
1181         * platform/win/WidgetWin.cpp:
1182         (WebCore::Widget::invalidateRect):
1183
1184 2007-06-29  Adam Roben  <aroben@apple.com>
1185
1186         Make an int -> UINT conversion explicit that MSVC /W4 complains about
1187
1188         Reviewed by John and Oliver.
1189
1190         No regression test possible.
1191
1192         * platform/win/SoundWin.cpp:
1193
1194 2007-06-29  Adam Roben  <aroben@apple.com>
1195
1196         Remove unreachable code uncovered by MSVC /W4
1197
1198         Reviewed by Oliver.
1199
1200         No regression test possible.
1201
1202         * html/CanvasRenderingContext2D.cpp:
1203         (WebCore::CanvasRenderingContext2D::createPattern):
1204         * html/HTMLAnchorElement.cpp:
1205         (WebCore::HTMLAnchorElement::isLiveLink):
1206         * html/HTMLElement.cpp:
1207         (WebCore::HTMLElement::contentEditable):
1208         * platform/DeprecatedString.cpp:
1209         (WebCore::allocateHandle):
1210         (WebCore::freeHandle):
1211         * plugins/win/npapi.cpp:
1212         (pluginViewForInstance):
1213         * rendering/RenderImage.cpp:
1214         (WebCore::RenderImage::isWidthSpecified):
1215         (WebCore::RenderImage::isHeightSpecified):
1216         * rendering/RenderTheme.cpp:
1217         (WebCore::RenderTheme::isControlStyled):
1218
1219 2007-06-29  John Sullivan  <sullivan@apple.com>
1220
1221         Reviewed by Oliver Hunt.
1222         
1223         - WebCore support for accessing the set of rectangles that encompass the selected text
1224         
1225         * page/Frame.h:
1226         * page/Frame.cpp:
1227         (WebCore::Frame::selectionTextRects):
1228         new function, fills in a passed Vector with the line box rects that represent the selected range
1229
1230         * rendering/RenderText.cpp:
1231         (WebCore::RenderText::addLineBoxRects):
1232         fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
1233
1234         * WebCore.exp:
1235         exported symbol for this new function
1236
1237 2007-06-29  Justin Garcia  <justin.garcia@apple.com>
1238
1239         Reviewed by Harrison.
1240         
1241         <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
1242         
1243         Rolled out a change made in r23787.
1244         
1245         * editing/DeleteSelectionCommand.cpp:
1246         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
1247
1248 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
1249
1250         Reviewed by Darin Adler, Anders Carlsson.
1251         
1252         Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML 
1253         returns NULL if response MIME type is not XML -- breaks Wikipedia widget
1254         
1255         The spec says that responseXML must return null for any HTTP response
1256         with a non-XML MIME type. Technically, that leaves non-HTTP responses
1257         free to do whatever they want.
1258
1259         * xml/xmlhttprequest.cpp:
1260         (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
1261         MIME types if the response was HTTP.
1262
1263 2007-06-29  Sam Weinig  <sam@webkit.org>
1264
1265         Reviewed by Darin.
1266
1267         Second pass at fixing implicit 64-32 bit conversion errors.
1268         <rdar://problem/5292262>
1269
1270         - Use new JSValue::toFloat() method instead of toNumber() where
1271           appropriate.
1272
1273         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
1274         (WebCore::JSCanvasRenderingContext2D::setFillColor):
1275         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
1276         (WebCore::JSCanvasRenderingContext2D::strokeRect):
1277         (WebCore::JSCanvasRenderingContext2D::drawImage):
1278         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
1279         (WebCore::JSCanvasRenderingContext2D::setShadow):
1280         * bindings/js/JSHTMLSelectElementCustom.cpp:
1281         (WebCore::JSHTMLSelectElement::remove):
1282         * bindings/js/JSSVGMatrixCustom.cpp:
1283         (WebCore::JSSVGMatrix::rotateFromVector):
1284         * bindings/js/kjs_events.cpp:
1285         (KJS::JSClipboardPrototypeFunction::callAsFunction):
1286         * bindings/scripts/CodeGeneratorJS.pm:
1287         * ksvg2/svg/SVGScriptElement.cpp:
1288         (WebCore::SVGScriptElement::executeScript):
1289
1290 2007-06-29  Adele Peterson  <adele@apple.com>
1291
1292         Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
1293
1294         * html/HTMLInputElement.h:
1295         * html/HTMLTextAreaElement.h:
1296
1297 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
1298
1299         Reviewed by Oliver Hunt.
1300
1301         Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing 
1302         local file throws exception -- breaks Wikipedia widget
1303
1304         * WebCore.xcodeproj/project.pbxproj:
1305         * xml/xmlhttprequest.cpp:
1306         (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
1307
1308 2007-06-29  Ada Chan  <adachan@apple.com>
1309
1310         Reviewed by Adam.
1311
1312         Fixed a previous fix to a signed/unsigned mismatch.
1313
1314         * plugins/win/PluginPackageWin.cpp:
1315         (WebCore::splitString):
1316
1317 2007-06-29  Adele Peterson  <adele@apple.com>
1318
1319         Reviewed by Ada and Kevin McCullough.
1320
1321         Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
1322
1323         Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
1324
1325         Tests:
1326         fast/forms/input-readonly-select-all.html
1327         fast/forms/textarea-readonly-select-all.html
1328
1329         * html/HTMLInputElement.h:
1330         (WebCore::HTMLInputElement::canSelectAll):
1331         (WebCore::HTMLInputElement::selectAll):
1332         * html/HTMLTextAreaElement.h:
1333         (WebCore::HTMLTextAreaElement::canSelectAll):
1334         (WebCore::HTMLTextAreaElement::selectAll):
1335
1336 2007-06-29  Adam Roben  <aroben@apple.com>
1337
1338         Build fix
1339
1340         This is what happens when you test your patch on two OSs and then
1341         commit from the wrong one.
1342
1343         * rendering/RenderTextControl.cpp:
1344         (WebCore::RenderTextControl::valueChanged):
1345         (WebCore::RenderTextControl::itemText):
1346         (WebCore::RenderTextControl::itemIsSeparator):
1347
1348 2007-06-29  Adam Roben  <aroben@apple.com>
1349
1350         Start compiling WebCore with /W3 under MSVC
1351
1352         One warning was globally disabled: implicit conversion of int to bool.
1353
1354         Reviewed by Darin.
1355
1356         * WebCore.vcproj/WebCore.vcproj:
1357
1358 2007-06-29  Adam Roben  <aroben@apple.com>
1359
1360         Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
1361
1362         DeprecatedStringData now has no public copy constructor. The single
1363         call to the old one has been replaced with a call to the new
1364         DeprecatedStringData::createAndAdopt static method.
1365
1366         Reviewed by Darin.
1367
1368         All regression tests pass.
1369
1370         * platform/DeprecatedString.cpp:
1371         (WebCore::DeprecatedStringData::createAndAdopt):
1372         (WebCore::DeprecatedStringData::adopt):
1373         (WebCore::DeprecatedString::detachIfInternal):
1374         * platform/DeprecatedString.h:
1375
1376 2007-06-29  Adam Roben  <aroben@apple.com>
1377
1378         Fix more signed/unsigned mismatches uncovered by MSVC /W3
1379
1380         Reviewed by John.
1381
1382         No regression tests possible.
1383
1384         * platform/network/cf/ResourceResponseCFNet.cpp:
1385         (WebCore::filenameHasSaneExtension):
1386         * platform/win/FontDataWin.cpp:
1387         (WebCore::FontData::containsCharacters):
1388         * platform/win/PlatformScrollBarSafari.cpp:
1389         (WebCore::):
1390         * platform/win/UniscribeController.cpp:
1391         (WebCore::UniscribeController::advance):
1392         (WebCore::UniscribeController::shapeAndPlaceItem):
1393         * platform/win/WebCoreTextRenderer.cpp:
1394         (WebCore::doDrawTextAtPoint):
1395         * plugins/win/PluginDatabaseWin.cpp:
1396         (WebCore::parseVersionString):
1397         * plugins/win/PluginPackageWin.cpp:
1398         (WebCore::splitString):
1399         * plugins/win/PluginViewWin.cpp:
1400         (WebCore::freeStringArray):
1401         (WebCore::PluginViewWin::invalidateTimerFired):
1402
1403 2007-06-29  Adam Roben  <aroben@apple.com>
1404
1405         Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
1406
1407         Reviewed by John.
1408
1409         No regression test possible.
1410
1411         * html/HTMLSelectElement.cpp:
1412         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
1413         * platform/PopupMenuClient.h:
1414         * platform/win/PopupMenuWin.cpp:
1415         (WebCore::PopupMenu::calculatePositionAndSize):
1416         (WebCore::PopupMenu::focusFirst):
1417         (WebCore::PopupMenu::focusLast):
1418         (WebCore::PopupMenu::down):
1419         (WebCore::PopupMenu::up):
1420         (WebCore::PopupMenu::paint):
1421         * rendering/RenderMenuList.cpp:
1422         * rendering/RenderMenuList.h:
1423         * rendering/RenderTextControl.cpp:
1424         * rendering/RenderTextControl.h:
1425
1426 2007-06-29  Adam Roben  <aroben@apple.com>
1427
1428         Fix two typos spotted by MSVC /W3
1429
1430         Both typos were a semicolon following the condition of an if. This
1431         would cause the intended body of the if to always execute.
1432
1433         Unfortunately neither of these fixes are testable.
1434         BackForwardList::goForward is only called from WebBackForwardList, and
1435         the createDragImageFromImage bug would only manifest itself when
1436         CreateCompatibleDC failed.
1437
1438         Reviewed by Mark.
1439
1440         * history/BackForwardList.cpp:
1441         (WebCore::BackForwardList::goForward):
1442         * platform/win/DragImageWin.cpp:
1443         (WebCore::createDragImageFromImage):
1444
1445 2007-06-29  Adam Treat  <adam@staikos.net>
1446
1447         Reviewed by george Staikos.
1448
1449         Support horizontal and vertical scroll, and set the right units.
1450
1451         * platform/qt/WheelEventQt.cpp:
1452         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1453
1454 2007-06-28  Adam Roben  <aroben@apple.com>
1455
1456         Get WebCore compiling with /W2 on Windows
1457
1458         Reviewed by Steve.
1459
1460         No regression tests affected.
1461
1462         * WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
1463         disable two warnings: implicit int <=> float conversion, and class vs.
1464         struct inconsistency.
1465         * dom/CharacterData.cpp:
1466         (WebCore::CharacterData::deleteData): Cast to int before negating.
1467         * loader/Cache.cpp:
1468         (WebCore::Cache::remove): Ditto.
1469         * platform/graphics/Path.cpp:
1470         (WebCore::pathLengthApplierFunction): Consistently use floats.
1471         * platform/graphics/cg/GraphicsContextCG.cpp:
1472         (WebCore::GraphicsContext::drawEllipse): Ditto.
1473         * platform/win/GraphicsContextWin.cpp:
1474         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
1475
1476 2007-06-28  Geoffrey Garen  <ggaren@apple.com>
1477
1478         Reviewed by Maciej Stachowiak.
1479         
1480         Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease 
1481         pool => pathologically high high water mark
1482         
1483         I couldn't measure any performance problems with iBench HTML or PLT.
1484
1485         * WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
1486         * platform/mac/SharedTimerMac.cpp:
1487         (WebCore::timerFired): Added autorelease pool.
1488
1489 2007-06-28  Mitz Pettel  <mitz@webkit.org>
1490
1491         Reviewed by Beth.
1492
1493         - fix http://bugs.webkit.org/show_bug.cgi?id=14118
1494           ASSERTION FAILED: !needsLayout() seen again
1495
1496         Test: fast/dynamic/recursive-layout.html
1497
1498         * page/FrameView.cpp:
1499         (WebCore::FrameView::layout): Removed the midLayout guards around
1500         the calls to invalidateSelection() and updateWidgetPositions(). Those
1501         calls may dirty the layout, but in that case they also update it, so
1502         they should be allowed to do it. Added an ASSERT to make sure that when
1503         they return, the root is not marked for layout.
1504
1505 2007-06-28  Sam Weinig  <sam@webkit.org>
1506
1507         Rubberstamped by Adam Roben.
1508
1509         Roll out r23861.  It caused the buildbot to fail on intel.
1510
1511         * page/Page.cpp:
1512         (WebCore::Page::goToItem):
1513
1514 2007-06-26  Maxime Britto  <mbritto@pleyo.com>
1515
1516         Reviewed by Geoff.
1517
1518         Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
1519         ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
1520
1521         Modification of an ASSERT on goToItem related to go back/forward in
1522         history.Don't need to check the frameset if the target is _blank.
1523
1524          * page/Page.cpp:
1525          (WebCore::Page::goToItem):
1526
1527 2007-06-28  Anders Carlsson  <andersca@apple.com>
1528
1529         Reviewed by Oliver.
1530
1531         <rdar://problem/5234139>
1532         <object> with PNG src rendered as image document.
1533         
1534         Complete the URL before passing it to the frame loader client.
1535         
1536         * html/HTMLObjectElement.cpp:
1537         (WebCore::HTMLObjectElement::isImageType):
1538
1539 2007-06-28  Rob Buis  <buis@kde.org>
1540
1541         Reviewed by Maciej.
1542
1543         http://bugs.webkit.org/show_bug.cgi?id=14373
1544         CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
1545
1546         Make sure the id selector validates against the CSS2.1 identfier
1547         definition, not the hexcolor/HASH definition.
1548
1549         * css/CSSGrammar.y:
1550         * css/cssparser.cpp:
1551         (WebCore::CSSParser::lex):
1552         (WebCore::CSSParser::text):
1553         * css/tokenizer.flex:
1554
1555 2007-06-28  Simon Hausmann  <hausmann@kde.org>
1556
1557         Reviewed by Zack.
1558
1559         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
1560
1561         * platform/qt/PasteboardQt.cpp:
1562         (WebCore::Pasteboard::writeSelection):
1563
1564 2007-06-28  Antti Koivisto  <antti@apple.com>
1565
1566         Reviewed by Mitz.
1567         
1568         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
1569         Bug 14332: REGRESSION (r21145): <td> width ignored
1570         <rdar://problem/5290123>
1571         
1572         Cells in table with non-zero cellpadding are not considered empty.
1573
1574         * rendering/AutoTableLayout.cpp:
1575         (WebCore::AutoTableLayout::recalcColumn):
1576
1577 2007-06-28  Adam Roben  <aroben@apple.com>
1578
1579         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
1580
1581         Reviewed by Hyatt.
1582
1583         No layout test possible, as this bug didn't have any effect since
1584         "bool & bool" has the same value as "bool && bool"
1585
1586         * rendering/RenderBlock.cpp:
1587         (WebCore::RenderBlock::paintObject): Changed & to &&.
1588
1589 2007-06-28  Adam Roben  <aroben@apple.com>
1590
1591         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
1592
1593         The bug was caused by two typos found by prefast.
1594
1595         Reviewed by Hyatt.
1596
1597         * css/cssparser.cpp:
1598         (WebCore::CSSParser::parseValue): Fixed typos.
1599
1600 2007-06-20  Matt Perry  <mpComplete@gmail.com>
1601
1602         Reviewed by Adam.
1603
1604         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
1605           onchange handler for select controls doesn't fire when changing via keyboard
1606
1607         * html/HTMLSelectElement.cpp:
1608         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
1609         a call to saveLastSelection in the "Enter" key handler for select
1610         controls that was preventing onchange from firing.
1611
1612 2007-06-27  Sam Weinig  <sam@webkit.org>
1613
1614         Fix Gdk, Qt, and Win32 builds.
1615
1616         * WebCore.pro:
1617         * WebCore.vcproj/WebCore.vcproj:
1618
1619 2007-06-27  Sam Weinig  <sam@webkit.org>
1620
1621         Reviewed by Geoff.
1622
1623         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
1624         Move the Selection object out of the JS bindings
1625
1626         - Renames JS Object Selection to DOMSelection to avoid a name
1627           conflict.
1628
1629         * DerivedSources.make:
1630         * WebCore.xcodeproj/project.pbxproj:
1631         * bindings/js/kjs_window.cpp:
1632         (KJS::WindowPrivate::WindowPrivate):
1633         (KJS::Window::mark):
1634         (KJS::Window::clearHelperObjectProperties):
1635         (KJS::WindowFunc::callAsFunction):
1636         (KJS::Window::disconnectFrame):
1637         * bindings/js/kjs_window.h:
1638         (KJS::Window::):
1639         * page/DOMSelection.cpp: Added.
1640         (WebCore::DOMSelection::DOMSelection):
1641         (WebCore::DOMSelection::frame):
1642         (WebCore::DOMSelection::disconnectFrame):
1643         (WebCore::DOMSelection::anchorNode):
1644         (WebCore::DOMSelection::baseNode):
1645         (WebCore::DOMSelection::anchorOffset):
1646         (WebCore::DOMSelection::baseOffset):
1647         (WebCore::DOMSelection::focusNode):
1648         (WebCore::DOMSelection::extentNode):
1649         (WebCore::DOMSelection::focusOffset):
1650         (WebCore::DOMSelection::extentOffset):
1651         (WebCore::DOMSelection::isCollapsed):
1652         (WebCore::DOMSelection::type):
1653         (WebCore::DOMSelection::rangeCount):
1654         (WebCore::DOMSelection::collapse):
1655         (WebCore::DOMSelection::collapseToEnd):
1656         (WebCore::DOMSelection::collapseToStart):
1657         (WebCore::DOMSelection::empty):
1658         (WebCore::DOMSelection::setBaseAndExtent):
1659         (WebCore::DOMSelection::setPosition):
1660         (WebCore::DOMSelection::modify):
1661         (WebCore::DOMSelection::getRangeAt):
1662         (WebCore::DOMSelection::removeAllRanges):
1663         (WebCore::DOMSelection::addRange):
1664         (WebCore::DOMSelection::toString):
1665         * page/DOMSelection.h: Added.
1666         * page/DOMSelection.idl: Added.
1667         * page/DOMWindow.cpp:
1668         (WebCore::DOMWindow::disconnectFrame):
1669         (WebCore::DOMWindow::getSelection):
1670         * page/DOMWindow.h:
1671         * page/DOMWindow.idl:
1672
1673 2007-06-27  Sam Weinig  <sam@webkit.org>
1674
1675         Reviewed by Maciej.
1676
1677         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
1678         Autogenerate Event JS binding
1679
1680         - Cleanup kjs_events
1681
1682         * bindings/js/kjs_events.cpp:
1683         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
1684         (WebCore::JSAbstractEventListener::handleEvent):
1685         (WebCore::JSAbstractEventListener::isHTMLEventListener):
1686         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
1687         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
1688         (WebCore::JSUnprotectedEventListener::listenerObj):
1689         (WebCore::JSUnprotectedEventListener::windowObj):
1690         (WebCore::JSUnprotectedEventListener::clearWindowObj):
1691         (WebCore::JSUnprotectedEventListener::mark):
1692         (WebCore::JSEventListener::JSEventListener):
1693         (WebCore::JSEventListener::~JSEventListener):
1694         (WebCore::JSEventListener::listenerObj):
1695         (WebCore::JSEventListener::windowObj):
1696         (WebCore::JSEventListener::clearWindowObj):
1697         (WebCore::JSLazyEventListener::JSLazyEventListener):
1698         (WebCore::JSLazyEventListener::listenerObj):
1699         (WebCore::JSLazyEventListener::parseCode):
1700         (WebCore::getNodeEventListener):
1701         (WebCore::JSClipboard::JSClipboard):
1702         (WebCore::JSClipboard::getValueProperty):
1703         (WebCore::JSClipboard::putValueProperty):
1704         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
1705         (WebCore::toJS):
1706         (WebCore::toClipboard):
1707         * bindings/js/kjs_events.h:
1708         (WebCore::JSClipboard::classInfo):
1709         (WebCore::JSClipboard::impl):
1710         * bindings/js/kjs_window.h:
1711         * ksvg2/events/JSSVGLazyEventListener.h:
1712
1713 2007-06-27  Sam Weinig  <sam@webkit.org>
1714
1715         Reviewed by Adam Roben.
1716
1717         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
1718         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
1719         <rdar://problem/5286670>
1720
1721         Test: fast/forms/thumbslider-no-parent-slider.html
1722         Test: fast/forms/thumbslider-crash.html
1723
1724         * rendering/RenderObject.h:
1725         (WebCore::RenderObject::isSlider):
1726         * rendering/RenderSlider.h:
1727         (WebCore::RenderSlider::isSlider):
1728         * rendering/RenderTheme.cpp:
1729         (WebCore::RenderTheme::paint): Only paint thumbslider
1730         if the parent renderer is a RenderSlider.
1731         * rendering/RenderThemeMac.mm:
1732         (WebCore::RenderThemeMac::paintSliderThumb):
1733         * rendering/RenderThemeSafari.cpp:
1734         (WebCore::RenderThemeSafari::paintSliderThumb):
1735
1736 2007-06-27  George Staikos  <staikos@kde.org>
1737
1738         Make Qt builds link when XSLT is turned off.
1739
1740         * WebCore.pro:
1741
1742 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
1743
1744         Turn on static code analysis (Windows only).
1745
1746         Affects only folks that have Visual Studio Team Suite installed,
1747         or who have replaced their compiler with the version shipping in the
1748         Vista SDK.
1749         
1750         Reviewed by Oliver.
1751
1752         * WebCore.vcproj/WebCore.vcproj:
1753
1754 2007-06-27  George Staikos  <staikos@kde.org>
1755
1756         Remove old commented out files that no-longer exist.
1757
1758         * WebCore.pro:
1759
1760 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
1761
1762         Reviewed by John.
1763
1764         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
1765         
1766         Pasting with a trailing interchange newline doesn't work when pasting
1767         into an empty line.  Code that handles removing brs at the insertion
1768         position tries to also handle trailing interchange newlines by re-using
1769         those brs and fails.  Removed that code and handle all interchange
1770         newlines with code later in doApply().
1771
1772         * editing/ReplaceSelectionCommand.cpp:
1773         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
1774         endBR when there's a trailing interchange newline.
1775         
1776 2007-06-27  Anders Carlsson  <andersca@apple.com>
1777
1778         Reviewed by Oliver.
1779
1780         <rdar://problem/5253950>
1781         When Shockwave plugin has been loaded, exiting crashes Safari
1782         
1783         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
1784         
1785         * plugins/win/PluginPackageWin.cpp:
1786         (WebCore::PluginPackageWin::PluginPackageWin):
1787         (WebCore::PluginPackageWin::load):
1788         (WebCore::PluginPackageWin::unload):
1789         (WebCore::PluginPackageWin::unloadWithoutShutdown):
1790         * plugins/win/PluginPackageWin.h:
1791         
1792         * plugins/win/PluginViewWin.cpp:
1793         (WebCore::PluginViewWin::~PluginViewWin):
1794         Make sure to unload the plugin package and clear any references to plugin script objects.
1795
1796 2007-06-27  George Staikos  <staikos@kde.org>
1797
1798         This was succeeding compile by luck.  Setup dependencies properly.
1799
1800         * WebCore.pro:
1801
1802 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
1803
1804         Reviewed by John.
1805
1806         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
1807         
1808         When a quoted numbered list is broken in half, it's cloned
1809         to make the second list. That second list needs its start attribute
1810         set so that the numbers of the list items in it will be preserved.
1811
1812         * editing/BreakBlockquoteCommand.cpp:
1813         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
1814         of a cloned list to be the original number of the first list item in it.
1815
1816 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
1817
1818         Reviewed by Geoff.
1819
1820         http://bugs.webkit.org/show_bug.cgi?id=14413
1821         GIF animation throttling is different from MSIE
1822
1823         * platform/graphics/cg/ImageSourceCG.cpp:
1824         (WebCore::ImageSource::frameDurationAtIndex):
1825         Change the cut-off value to 50ms to match MSIE.
1826
1827 2007-06-27  Sam Weinig  <sam@webkit.org>
1828
1829         Reviewed by Darin.
1830
1831         First pass at fixing implicit 64-32 bit conversion errors.
1832         <rdar://problem/5292262>
1833
1834         - Add 'f' suffix where necessary.
1835
1836         * bridge/mac/WebCoreAXObject.mm:
1837         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
1838         * css/csshelper.h:
1839         * css/cssstyleselector.cpp:
1840         (WebCore::):
1841         (WebCore::CSSStyleSelector::largerFontSize):
1842         (WebCore::CSSStyleSelector::smallerFontSize):
1843         * html/CanvasGradient.cpp:
1844         (WebCore::CanvasGradient::addColorStop):
1845         * html/CanvasPattern.cpp:
1846         (WebCore::CanvasPattern::createPattern):
1847         * ksvg2/css/SVGCSSStyleSelector.cpp:
1848         (WebCore::CSSStyleSelector::applySVGProperty):
1849         * ksvg2/css/SVGRenderStyle.h:
1850         * ksvg2/events/SVGZoomEvent.cpp:
1851         (WebCore::SVGZoomEvent::SVGZoomEvent):
1852         * ksvg2/svg/SVGLength.cpp:
1853         (WebCore::SVGLength::SVGLength):
1854         (WebCore::SVGLength::value):
1855         (WebCore::SVGLength::setValue):
1856         (WebCore::SVGLength::valueAsPercentage):
1857         (WebCore::SVGLength::PercentageOfViewport):
1858         * ksvg2/svg/SVGSVGElement.cpp:
1859         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
1860         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
1861         (WebCore::SVGSVGElement::getScreenCTM):
1862         * ksvg2/svg/SVGTextContentElement.cpp:
1863         (WebCore::SVGTextContentElement::getComputedTextLength):
1864         (WebCore::SVGTextContentElement::getSubStringLength):
1865         (WebCore::SVGTextContentElement::getRotationOfChar):
1866         * ksvg2/svg/SVGTransformDistance.cpp:
1867         (WebCore::SVGTransformDistance::SVGTransformDistance):
1868         (WebCore::SVGTransformDistance::distance):
1869         * page/InspectorController.cpp:
1870         (WebCore::InspectorResource::InspectorResource):
1871         * platform/graphics/FloatPoint3D.cpp:
1872         (WebCore::FloatPoint3D::normalize):
1873         * platform/graphics/Path.cpp:
1874         (WebCore::pathLengthApplierFunction):
1875         (WebCore::Path::createRoundedRectangle):
1876         * platform/graphics/cg/GraphicsContextCG.cpp:
1877         (WebCore::GraphicsContext::drawLine):
1878         (WebCore::GraphicsContext::strokeArc):
1879         * platform/graphics/cg/ImageCG.cpp:
1880         (WebCore::FrameData::clear):
1881         * platform/graphics/cg/ImageSourceCG.cpp:
1882         (WebCore::ImageSource::frameDurationAtIndex):
1883         * platform/graphics/cg/PDFDocumentImage.cpp:
1884         (WebCore::PDFDocumentImage::setCurrentPage):
1885         * platform/graphics/svg/SVGPaintServerPattern.cpp:
1886         (WebCore::SVGPaintServerPattern::externalRepresentation):
1887         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
1888         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
1889         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
1890         (WebCore::cgGradientCallback):
1891         (WebCore::CGShadingRefForRadialGradient):
1892         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
1893         * platform/mac/FontDataMac.mm:
1894         (WebCore::webFallbackFontFamily):
1895         * platform/mac/PopupMenuMac.mm:
1896         (WebCore::PopupMenu::show):
1897         * rendering/InlineFlowBox.cpp:
1898         (WebCore::InlineFlowBox::placeBoxesHorizontally):
1899         * rendering/RenderSlider.cpp:
1900         (WebCore::RenderSlider::setValueForPosition):
1901         (WebCore::RenderSlider::setPositionFromValue):
1902
1903 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
1904
1905         Reviewed by Geoff.
1906
1907         http://bugs.webkit.org/show_bug.cgi?id=14288
1908         XMLHttpRequest doesn't use a correct content type for file:// URLs
1909
1910         Test: fast/dom/xmlhttprequest-html-response-encoding.html
1911
1912         * xml/xmlhttprequest.cpp:
1913         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
1914         the network layer, since it provides it even for non-HTTP responses.
1915
1916 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1917
1918         Reviewed by Sam Weinig.
1919
1920         http://bugs.webkit.org/show_bug.cgi?id=14061
1921         Implement more of FrameLoaderClientGdk
1922
1923         Make FrameLoaderClientGdk work properly when the MIME type is set.
1924
1925         * loader/gdk/FrameLoaderClientGdk.cpp:
1926         (WebCore::FrameLoaderClientGdk::objectContentType):
1927         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
1928
1929 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1930
1931         Reviewed by Maciej.
1932
1933         http://bugs.webkit.org/show_bug.cgi?id=14058
1934         Gdk font backend cleanup
1935
1936         * platform/FontData.h: Remove obsolete function.
1937         * platform/gdk/FontDataGdk.cpp:
1938         (WebCore::FontData::containsCharacters): Lock/unlock only once.
1939         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
1940         * platform/gdk/FontPlatformData.h: Remove obsolete function.
1941         * platform/gdk/FontPlatformDataGdk.cpp:
1942         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
1943         not the pixel size.
1944         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
1945         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
1946         (WebCore::GlyphPage::fill): Lock/unlock only once.
1947
1948 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1949
1950         Reviewed by Hyatt.
1951
1952         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
1953           <colgroup>'s borders are ignored when it has <col> children
1954
1955         Covered by existing tests.
1956
1957         * rendering/RenderTableCell.cpp:
1958         (WebCore::RenderTableCell::collapsedLeftBorder):
1959         (WebCore::RenderTableCell::collapsedRightBorder):
1960         (WebCore::RenderTableCell::collapsedTopBorder):
1961         (WebCore::RenderTableCell::collapsedBottomBorder):
1962
1963 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1964
1965         Reviewed by Oliver.
1966
1967         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
1968           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
1969
1970         Test: fast/repaint/text-selection-rect-in-overflow-2.html
1971
1972         * rendering/RenderObject.cpp:
1973         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
1974         for overflow scroll and columns.
1975         * rendering/RenderText.cpp:
1976         (WebCore::RenderText::selectionRect): Adjust for columns only in the
1977         non-clipped case, since RenderObject::absolutePosition() does not.
1978
1979 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1980
1981         Reviewed by Sam.
1982
1983         - http://bugs.webkit.org/show_bug.cgi?id=14415
1984           Remove the unused method RenderObject::setTable()
1985
1986         * rendering/RenderObject.h:
1987
1988 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
1989
1990         Reviewed by Maciej.
1991
1992         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
1993         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
1994
1995         This change moves the bulk of ResourceRequest into a base class named
1996         ResourceRequestBase with all platform-specific bits pushed into
1997         ResourceRequest.  This allows ports to easily add new members to a
1998         ResourceRequest without having to #ifdef the code that is shared
1999         between ports.
2000
2001         * WebCore.exp:
2002         * WebCore.pro:
2003         * WebCore.vcproj/WebCore.vcproj:
2004         * WebCore.xcodeproj/project.pbxproj:
2005         * platform/network/ResourceRequest.cpp: Removed.
2006         * platform/network/ResourceRequest.h: Removed.
2007         * platform/network/ResourceRequestBase.cpp: Added.
2008         (WebCore::ResourceRequestBase::asResourceRequest):
2009         (WebCore::ResourceRequestBase::isEmpty):
2010         (WebCore::ResourceRequestBase::isNull):
2011         (WebCore::ResourceRequestBase::url):
2012         (WebCore::ResourceRequestBase::setURL):
2013         (WebCore::ResourceRequestBase::cachePolicy):
2014         (WebCore::ResourceRequestBase::setCachePolicy):
2015         (WebCore::ResourceRequestBase::timeoutInterval):
2016         (WebCore::ResourceRequestBase::setTimeoutInterval):
2017         (WebCore::ResourceRequestBase::mainDocumentURL):
2018         (WebCore::ResourceRequestBase::setMainDocumentURL):
2019         (WebCore::ResourceRequestBase::httpMethod):
2020         (WebCore::ResourceRequestBase::setHTTPMethod):
2021         (WebCore::ResourceRequestBase::httpHeaderFields):
2022         (WebCore::ResourceRequestBase::httpHeaderField):
2023         (WebCore::ResourceRequestBase::setHTTPHeaderField):
2024         (WebCore::ResourceRequestBase::httpBody):
2025         (WebCore::ResourceRequestBase::setHTTPBody):
2026         (WebCore::ResourceRequestBase::allowHTTPCookies):
2027         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
2028         (WebCore::ResourceRequestBase::addHTTPHeaderField):
2029         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
2030         (WebCore::operator==):
2031         (WebCore::ResourceRequestBase::isConditional):
2032         (WebCore::ResourceRequestBase::updatePlatformRequest):
2033         (WebCore::ResourceRequestBase::updateResourceRequest):
2034         * platform/network/ResourceRequestBase.h: Added.
2035         (WebCore::):
2036         (WebCore::ResourceRequestBase::httpContentType):
2037         (WebCore::ResourceRequestBase::setHTTPContentType):
2038         (WebCore::ResourceRequestBase::httpReferrer):
2039         (WebCore::ResourceRequestBase::setHTTPReferrer):
2040         (WebCore::ResourceRequestBase::clearHTTPReferrer):
2041         (WebCore::ResourceRequestBase::httpUserAgent):
2042         (WebCore::ResourceRequestBase::setHTTPUserAgent):
2043         (WebCore::ResourceRequestBase::httpAccept):
2044         (WebCore::ResourceRequestBase::setHTTPAccept):
2045         (WebCore::ResourceRequestBase::ResourceRequestBase):
2046         (WebCore::operator!=):
2047         * platform/network/cf/ResourceRequest.h: Added.
2048         (WebCore::ResourceRequest::ResourceRequest):
2049         * platform/network/curl/ResourceRequest.h: Added.
2050         (WebCore::ResourceRequest::ResourceRequest):
2051         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2052         (WebCore::ResourceRequest::doUpdateResourceRequest):
2053         * platform/network/mac/ResourceRequest.h: Added.
2054         (WebCore::ResourceRequest::ResourceRequest):
2055         * platform/network/qt/ResourceRequest.h: Added.
2056         (WebCore::ResourceRequest::ResourceRequest):
2057         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2058         (WebCore::ResourceRequest::doUpdateResourceRequest):
2059
2060 2007-06-26  Adam Roben  <aroben@apple.com>
2061
2062         Add ChangeLog entries from the Windows merge.
2063
2064         Reviewed by Maciej.
2065
2066         * ChangeLog:
2067
2068 2007-06-26  Sam Weinig  <sam@webkit.org>
2069
2070         Reviewed by Maciej.
2071
2072         Make sure not to enumerate the toString() function.
2073         <rdar://problem/5297118>
2074
2075         * bindings/js/kjs_window.cpp:
2076         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
2077         * html/HTMLAnchorElement.idl:
2078
2079 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
2080
2081         Reviewed by Mitz, landed by Anders.
2082
2083         http://bugs.webkit.org/show_bug.cgi?id=14421
2084         Implement GraphicsContext::clearRect()
2085
2086         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2087         (WebCore::GraphicsContext::clearRect):
2088
2089 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
2090
2091         Reviewed and landed by Anders.
2092
2093         http://bugs.webkit.org/show_bug.cgi?id=14416
2094         Content does not render fully in some cases
2095
2096         Fix mismatched calls to cairo_save/restore due to an early method return.
2097
2098         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2099         (WebCore::GraphicsContext::drawLine):
2100
2101 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
2102
2103         Reviewed by John Sullivan.
2104
2105         Added two accessor functions for <rdar://problem/4119138>
2106
2107         * bindings/objc/DOMHTML.mm:
2108         (-[DOMHTMLInputElement _isEdited]):
2109         (-[DOMHTMLTextAreaElement _isEdited]):
2110         Added an accessor to the isEdited value of a DOM node's render object
2111
2112         * bindings/objc/DOMPrivate.h:
2113         Added header definitions for _isEdited
2114
2115 2007-06-26  Sam Weinig  <sam@webkit.org>
2116
2117         Fix Win32 build.
2118
2119         * WebCore.vcproj/WebCore.vcproj:
2120
2121 2007-06-26  Sam Weinig  <sam@webkit.org>
2122
2123         Fix Qt and Gdk builds.
2124
2125         * WebCore.pro:
2126
2127 2007-06-26  Sam Weinig  <sam@webkit.org>
2128
2129         Reviewed by Geoff.
2130
2131         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
2132         Autogenerate Event JS binding
2133
2134         - Moves the dataTransfer method into MouseEvent where it should be.
2135
2136         * WebCore.xcodeproj/project.pbxproj:
2137         * bindings/js/JSEventCustom.cpp: Added.
2138         (WebCore::JSEvent::clipboardData):
2139         (WebCore::toJS):
2140         * bindings/js/JSEventTargetNode.cpp:
2141         * bindings/js/JSXMLHttpRequest.cpp:
2142         * bindings/js/kjs_events.cpp:
2143         * bindings/js/kjs_events.h:
2144         * bindings/objc/DOMUtility.mm:
2145         (KJS::createDOMWrapper):
2146         * bindings/scripts/CodeGeneratorJS.pm:
2147         * dom/Event.h:
2148         (WebCore::Event::returnValue):
2149         (WebCore::Event::setReturnValue):
2150         (WebCore::Event::clipboardData):
2151         * dom/Event.idl:
2152         * dom/MouseEvent.h:
2153         (WebCore::MouseEvent::dataTransfer):
2154         * dom/MouseEvent.idl:
2155
2156 2007-06-26  Timothy Hatcher  <timothy@apple.com>
2157
2158         Reviewed by Mark Rowe.
2159
2160         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
2161         http://bugs.webkit.org/show_bug.cgi?id=14385
2162
2163         Correctly remember the "Show implicit properties" setting as you switch nodes.
2164
2165         * page/inspector/ResourcePanel.js:
2166
2167 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
2168
2169         Reviewed by John.
2170
2171         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
2172         
2173         Editing removed a node that was part of a search field's internal
2174         structure that should not be removed.
2175
2176         * editing/DeleteSelectionCommand.cpp:
2177         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
2178         selection to delete ends at [container, x], where x is the number
2179         of children in container, don't remove container.  Special case
2180         code elsewhere in this function will remove it if necessary.
2181
2182 2007-06-25  Sam Weinig  <sam@webkit.org>
2183
2184         Reviewed by Maciej.
2185
2186         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
2187         Mutating document.constructor.prototype mutates Object.prototype
2188
2189         Test: fast/js/constructor.html
2190
2191         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
2192         classes with constructors.  It is an non-enumeratable, non-deletable,
2193         readonly attribute.
2194
2195 2007-06-26  George Staikos  <staikos@kde.org>
2196
2197         Repair the OS X build.
2198
2199         * WebCore.exp:
2200
2201 2007-06-26  Adam Treat  <adam@staikos.net>
2202
2203         Reviewed by Adam Roben.
2204
2205         Make the SQLite icon database optional.
2206
2207         * loader/icon/IconDatabase.cpp:
2208         (WebCore::IconDatabase::isOpen):
2209         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
2210         (WebCore::IconDatabase::enabled):
2211         * loader/icon/IconDatabase.h:
2212
2213 2007-06-25  Sam Weinig  <sam@webkit.org>
2214
2215         Reviewed by Adam Roben.
2216
2217         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
2218         HTML syntax highlighting colors and DOM tree colors should be the same
2219
2220         * css/view-source.css:
2221         * page/inspector/ResourcePanel.js:
2222         * page/inspector/inspector.css:
2223         * page/inspector/inspector.js:
2224         * page/inspector/utilities.js:
2225
2226 2007-06-25  Adam Roben  <aroben@apple.com>
2227
2228         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
2229         http://bugs.webkit.org/show_bug.cgi?id=14402
2230
2231         The solution was to make KURL::lastPathComponent ignore trailing
2232         slashes, which is what -[NSURL lastPathComponent] does, too.
2233
2234         Reviewed by Oliver.
2235
2236         * platform/KURL.cpp:
2237         (WebCore::KURL::lastPathComponent):
2238
2239 2007-06-25  Sam Weinig  <sam@webkit.org>
2240
2241         Reviewed by Adam Roben.
2242
2243         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
2244         Web Inspector lists favicon.ico as "other" instead of "image"
2245
2246         * page/InspectorController.cpp:
2247         (WebCore::InspectorResource::type):
2248
2249 2007-06-25  Adele Peterson  <adele@apple.com>
2250
2251         Reviewed by Hyatt.
2252
2253         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
2254         http://bugs.webkit.org/show_bug.cgi?id=14297
2255
2256         Test: fast/overflow/hidden-scrollbar-resize.html
2257
2258         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
2259         Updated our shouldPaint check to consider visibility.
2260
2261 2007-06-25  Oliver Hunt  <oliver@apple.com>
2262
2263         Reviewed by Darin.
2264
2265         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
2266
2267         Fixing logic error in DragController
2268
2269         * manual-tests/drop-text-acquires-style.html: Added.
2270         * page/DragController.cpp:
2271         (WebCore::documentFragmentFromDragData):
2272
2273 2007-06-25  Sam Weinig  <sam@webkit.org>
2274
2275         Reviewed by Adam Roben.
2276
2277         Annotate prototypes by adding "Prototype" subtitle.
2278
2279         * page/inspector/ResourcePanel.js:
2280
2281 2007-06-25  George Staikos  <staikos@kde.org>
2282
2283         Reviewed by Zack.
2284
2285         Start to add proxy and SSL support to WebKitQt.  Proxying works.
2286
2287         * platform/network/ResourceHandleInternal.h:
2288         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2289         * platform/network/qt/ResourceHandleQt.cpp:
2290         (WebCore::ResourceHandle::start):
2291
2292 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
2293
2294         Reviewed by Adam Roben.
2295
2296         http://bugs.webkit.org/show_bug.cgi?id=14386
2297         Gdk build fix
2298
2299         * WebCore.pro: Fix gtk/gdk typo.
2300
2301 2007-06-25  Timothy Hatcher  <timothy@apple.com>
2302
2303         Reviewed by Anders.
2304
2305         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
2306         http://bugs.webkit.org/show_bug.cgi?id=14385
2307
2308         Add a toggle to show implict computed properties.
2309
2310         * page/inspector/ResourcePanel.js:
2311         * page/inspector/inspector.css:
2312         * page/inspector/inspector.js:
2313
2314 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
2315
2316         Reviewed by Mark.
2317
2318         http://bugs.webkit.org/show_bug.cgi?id=13975
2319         Use system-provided libjpeg and libpng
2320
2321         * WebCore.pro: Remove bundled libjpeg and libpng sources.
2322         * platform/image-decoders/jpeg: Remove sources.
2323         * platform/image-decoders/png: Remove sources.
2324
2325 2007-06-25  Mitz Pettel  <mitz@webkit.org>
2326
2327         Reviewed by Darin.
2328
2329         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
2330           Table caption renders too narrow sometimes
2331
2332         Test: fast/table/caption-relayout.html
2333
2334         * rendering/RenderTable.cpp:
2335         (WebCore::RenderTable::layout): Mark the caption for layout if the table
2336         width changed.
2337
2338 2007-06-25  Mitz Pettel  <mitz@webkit.org>
2339
2340         Reviewed by Darin.
2341
2342         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
2343           Underline painted under <br>, not repainted properly
2344
2345         Test: fast/inline/br-text-decoration.html
2346
2347         * platform/graphics/cg/GraphicsContextCG.cpp:
2348         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
2349         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
2350         than their thickness paint correctly.
2351
2352 2007-06-25  Mitz Pettel  <mitz@webkit.org>
2353
2354         Reviewed by Maciej.
2355
2356         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
2357           rules="none" ignored in certain cases
2358
2359         Covered by existing tests.
2360
2361         * html/HTMLTableElement.cpp:
2362         (WebCore::HTMLTableElement::getSharedCellDecl):
2363
2364 2007-06-24  Sam Weinig  <sam@webkit.org>
2365
2366         Reviewed by Mitz.
2367
2368         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
2369         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
2370
2371         * page/inspector/ResourcePanel.js: make sure not to call an overriden
2372         toString() by using Object.prototype.toString.call().
2373
2374 2007-06-24  Adam Roben  <aroben@apple.com>
2375
2376         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
2377         Bug 14374: Computed Style section should be expanded by default
2378
2379         Reviewed by Sam.
2380
2381         No regression test possible.
2382
2383         * page/inspector/ResourcePanel.js: Expand all style sections.
2384
2385 2007-06-24  Adam Roben  <aroben@apple.com>
2386
2387         Unify the style of enums in the Inspector JS
2388
2389         All our enums are now represented by an object with a property for
2390         each enum value.
2391
2392         Reviewed by Sam.
2393
2394         No regression test possible.
2395
2396         * page/inspector/ConsolePanel.js:
2397         * page/inspector/Resource.js:
2398         * page/inspector/ResourcePanel.js:
2399         * page/inspector/inspector.js:
2400
2401 2007-06-23  Sam Weinig  <sam@webkit.org>
2402
2403         Reviewed by Mitz.
2404
2405         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
2406         getComputedStyle(...).zIndex returns string "normal"
2407
2408         Test: fast/css/getComputedStyle-zIndex-auto.html
2409
2410         * css/CSSComputedStyleDeclaration.cpp:
2411         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
2412
2413 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
2414
2415         Reviewed by Tim Hatcher.
2416
2417         Bug 14265: Cannot resize columns in webinspector
2418         http://bugs.webkit.org/show_bug.cgi?id=14265
2419
2420         * page/inspector/inspector.css:
2421         * page/inspector/inspector.html:
2422         * page/inspector/inspector.js:
2423
2424 2007-06-23  Adam Roben  <aroben@apple.com>
2425
2426         Silence a build warning about not finding `num-cpus`
2427
2428         Reviewed by Mark Rowe.
2429
2430         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
2431         location.
2432
2433 2007-06-22  Anders Carlsson  <andersca@apple.com>
2434
2435         Reviewed by Darin.
2436
2437         * plugins/win/PluginStreamWin.cpp:
2438         (WebCore::PluginStreamWin::didFinishLoading):
2439         No need to fetch the size from resourceData.
2440
2441 2007-06-22  Anders Carlsson  <andersca@apple.com>
2442
2443         Reviewed by Darin.
2444
2445         <rdar://problem/5288617>
2446         Crash playing a very large QuickTime movie inside Safari.
2447
2448         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
2449         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
2450         
2451         * plugins/win/PluginStreamWin.cpp:
2452         (WebCore::PluginStreamWin::PluginStreamWin):
2453         (WebCore::PluginStreamWin::~PluginStreamWin):
2454         (WebCore::PluginStreamWin::didReceiveData):
2455         (WebCore::PluginStreamWin::didFinishLoading):
2456         * plugins/win/PluginStreamWin.h:
2457
2458 2007-06-22  Beth Dakin  <bdakin@apple.com>
2459
2460         Reviewed by Oliver and Darin.
2461
2462         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
2463         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
2464
2465         We already have code that tries to prevent allocating too-large 
2466         rowspans. The rowspan in this test, however, was small enough that 
2467         we thought it was okay in that code, even though clearly it was 
2468         still too large. I did a bunch of testing in Firefox, and it seems 
2469         that they set a hard limit on the maximum rowspan right in the DOM 
2470         -- 8k. So that is what this patch implements. 
2471
2472         * html/HTMLTableCellElement.cpp:
2473         (WebCore::HTMLTableCellElement::parseMappedAttribute):
2474
2475 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
2476
2477         Reviewed by Darin.
2478         
2479         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
2480         
2481         Deletion inserts a placeholder after it removes full paragraphs if
2482         one doesn't already exist.  The code that looked for a pre-existing
2483         placeholder didn't work because of a bug in enclosingNodeOfType.
2484
2485         * editing/htmlediting.cpp:
2486         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
2487         but don't go above an editing root.
2488
2489 2007-06-22  Anders Carlsson  <andersca@apple.com>
2490
2491         Reviewed by Maciej and Geoff.
2492
2493         <rdar://problem/5244734>
2494         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
2495         
2496         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
2497         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
2498         argument to a bunch of classes).
2499         
2500         * loader/Cache.cpp:
2501         (WebCore::createResource):
2502         (WebCore::Cache::requestResource):
2503         * loader/Cache.h:
2504         * loader/CachedCSSStyleSheet.cpp:
2505         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2506         * loader/CachedCSSStyleSheet.h:
2507         * loader/CachedResource.cpp:
2508         (WebCore::CachedResource::CachedResource):
2509         * loader/CachedResource.h:
2510         (WebCore::CachedResource::sendResourceLoadCallbacks):
2511         * loader/DocLoader.cpp:
2512         (WebCore::DocLoader::requestCSSStyleSheet):
2513         (WebCore::DocLoader::requestResource):
2514         (WebCore::DocLoader::checkCacheObjectStatus):
2515         * loader/DocLoader.h:
2516         * loader/MainResourceLoader.cpp:
2517         (WebCore::MainResourceLoader::MainResourceLoader):
2518         * loader/Request.cpp:
2519         (WebCore::Request::Request):
2520         * loader/Request.h:
2521         (WebCore::Request::sendResourceLoadCallbacks):
2522         * loader/ResourceLoader.cpp:
2523         (WebCore::ResourceLoader::ResourceLoader):
2524         (WebCore::ResourceLoader::willSendRequest):
2525         (WebCore::ResourceLoader::didReceiveResponse):
2526         (WebCore::ResourceLoader::didReceiveData):
2527         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2528         (WebCore::ResourceLoader::didFail):
2529         (WebCore::ResourceLoader::didCancel):
2530         * loader/ResourceLoader.h:
2531         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
2532         * loader/SubresourceLoader.cpp:
2533         (WebCore::SubresourceLoader::SubresourceLoader):
2534         (WebCore::SubresourceLoader::create):
2535         * loader/SubresourceLoader.h:
2536         * loader/loader.cpp:
2537         (WebCore::Loader::load):
2538         (WebCore::Loader::servePendingRequests):
2539         * loader/loader.h:
2540         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
2541         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
2542
2543 2007-06-21  Richard Connamacher  <rich@indieimage.com>
2544
2545         Reviewed by Tim Hatcher.
2546
2547         Bug 14305: Web Inspector marks local files with server-side compression tip
2548         http://bugs.webkit.org/show_bug.cgi?id=14305
2549
2550         * page/inspector/Resource.js:
2551         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
2552         from being given to local files
2553
2554 2007-06-21  Mark Rowe  <mrowe@apple.com>
2555
2556         Reviewed by Darin.
2557
2558         Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
2559
2560         * platform/StringImpl.cpp:
2561         (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
2562         a length of zero when the string is collapsed to empty by whitespace simplification.
2563
2564 2007-06-21  Dave Hyatt  <hyatt@apple.com>
2565
2566         Fix for <rdar://problem/5286978>, large font sizes crash Windows.
2567         
2568         Limit the maximum font size to 1,000,000 to avoid crashes and issues with platforms that
2569         start failing to do anything useful if the font size is too big.
2570         
2571         Reviewed by olliej
2572
2573         * css/cssstyleselector.cpp:
2574         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
2575         
2576 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
2577
2578         Reviewed by Timothy.
2579
2580         Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
2581
2582         * page/inspector/inspector.css: Set body margin to 0
2583
2584 2007-06-21  Adam Treat  <adam@staikos.net>
2585
2586         Reviewed by George Staikos.
2587
2588         Implement the default resources on Qt.
2589
2590         * platform/graphics/BitmapImage.h:
2591         * platform/graphics/Image.h:
2592         * platform/graphics/qt/ImageQt.cpp:
2593         (WebCore::Image::loadPlatformResource):
2594         (WebCore::BitmapImage::BitmapImage):
2595         (WebCore::BitmapImage::initPlatformData):
2596         (WebCore::BitmapImage::invalidatePlatformData):
2597         (WebCore::BitmapImage::getPixmap):
2598         * platform/qt/TemporaryLinkStubs.cpp:
2599
2600 2007-06-21  Oliver Hunt  <oliver@apple.com>
2601
2602         Reviewed by Darin.
2603
2604         Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
2605         and makes reference handling simpler in advance of IME refactoring.
2606
2607         * WebCore.xcodeproj/project.pbxproj:
2608         * page/mac/EventHandlerMac.mm:
2609         (WebCore::currentEvent):
2610         (WebCore::EventHandler::currentNSEvent):
2611         (WebCore::EventHandler::wheelEvent):
2612         (WebCore::EventHandler::keyEvent):
2613         (WebCore::lastEventIsMouseUp):
2614         (WebCore::EventHandler::passMouseDownEventToWidget):
2615         (WebCore::EventHandler::eventLoopHandleMouseDragged):
2616         (WebCore::EventHandler::eventLoopHandleMouseUp):
2617         (WebCore::EventHandler::passSubframeEventToSubframe):
2618         (WebCore::EventHandler::passWheelEventToWidget):
2619         (WebCore::EventHandler::mouseDown):
2620         (WebCore::EventHandler::mouseDragged):
2621         (WebCore::EventHandler::mouseUp):
2622         (WebCore::EventHandler::mouseMoved):
2623
2624 2007-06-21  George Staikos  <staikos@kde.org>
2625
2626         Reviewed by George & Marius.
2627
2628         Patch by me, revision by Marius, minor rev by me.  Adds rendered
2629         and stylable scrollbars.
2630
2631         * page/qt/EventHandlerQt.cpp:
2632         (WebCore::EventHandler::passMousePressEventToScrollbar):
2633         * platform/Widget.h:
2634         * platform/qt/PlatformScrollBar.h:
2635         (WebCore::PlatformScrollbar::isWidget):
2636         * platform/qt/PlatformScrollBarQt.cpp:
2637         (WebCore::PlatformScrollbar::PlatformScrollbar):
2638         (WebCore::PlatformScrollbar::~PlatformScrollbar):
2639         (WebCore::PlatformScrollbar::updateThumbPosition):
2640         (WebCore::PlatformScrollbar::updateThumbProportion):
2641         (WebCore::PlatformScrollbar::width):
2642         (WebCore::PlatformScrollbar::height):
2643         (WebCore::PlatformScrollbar::setRect):
2644         (WebCore::PlatformScrollbar::isEnabled):
2645         (WebCore::PlatformScrollbar::setEnabled):
2646         (WebCore::PlatformScrollbar::paint):
2647         (WebCore::PlatformScrollbar::thumbPosition):
2648         (WebCore::PlatformScrollbar::thumbLength):
2649         (WebCore::PlatformScrollbar::trackLength):
2650         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
2651         (WebCore::PlatformScrollbar::handleMouseOutEvent):
2652         (WebCore::PlatformScrollbar::handleMousePressEvent):
2653         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
2654         (WebCore::PlatformScrollbar::startTimerIfNeeded):
2655         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
2656         (WebCore::PlatformScrollbar::autoscrollPressedPart):
2657         (WebCore::PlatformScrollbar::autoscrollTimerFired):
2658         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
2659         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
2660         (WebCore::PlatformScrollbar::thumbUnderMouse):
2661         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
2662         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
2663         (WebCore::PlatformScrollbar::windowClipRect):
2664         * platform/qt/ScrollViewQt.cpp:
2665         (WebCore::ScrollView::addChild):
2666         (WebCore::ScrollView::removeChild):
2667         * platform/qt/WidgetQt.cpp:
2668         (WebCore::WidgetPrivate::WidgetPrivate):
2669         (WebCore::Widget::setQWidget):
2670         (WebCore::Widget::invalidate):
2671         (WebCore::Widget::invalidateRect):
2672         (WebCore::Widget::setParent):
2673         (WebCore::Widget::parent):
2674
2675 2007-06-21  Geoffrey Garen  <ggaren@apple.com>
2676
2677         Reviewed by Dave Hyatt.
2678         
2679         Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
2680         REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML 
2681         effects when clicking on its links (12646)
2682         
2683         I'm rolling our r7703 for these reasons:
2684
2685         1. It broke RapidWeaver.
2686         
2687         2. WebKit is now orders of magnitude faster when handling deep nesting
2688         (5 seconds vs 3 minutes on my MBP in this particular case).
2689
2690         3. Firefox, IE, and HTML5 all allow nested heading tags.
2691         
2692         4. Hyatt said so.
2693
2694         * html/HTMLParser.cpp:
2695         (WebCore::HTMLParser::parseToken):
2696
2697 2007-06-21  Sam Weinig  <sam@webkit.org>
2698
2699         Reviewed by Tim Hatcher.
2700
2701         http://bugs.webkit.org/show_bug.cgi?id=14260
2702         ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page
2703
2704         Remove assert for now as it is causing the back button to not
2705         work in debug builds.
2706
2707         * page/InspectorController.cpp:
2708         (WebCore::InspectorController::didCommitLoad):
2709
2710 2007-06-21  Lars Knoll <lars@trolltech.com>
2711
2712         Remove some debug output.
2713
2714         * platform/qt/FontQt.cpp:
2715         (WebCore::generateComponents):
2716         (WebCore::Font::width):
2717
2718 2007-06-21  George Staikos  <staikos@kde.org>
2719
2720         Repair Qt/Mac OS X build.
2721
2722         * WebCore.pro:
2723
2724 2007-06-21  Alexey Proskuryakov  <ap@webkit.org>
2725
2726         Reviewed by Anders.
2727
2728         http://bugs.webkit.org/show_bug.cgi?id=13905
2729         REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
2730
2731         Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
2732         (regardless of the actual response MIME type). This was corrected a while ago to match other 
2733         browsers and the draft XHR spec.
2734
2735         Now restoring this functionality for "text/html", with spec editor's blessing.
2736
2737         * xml/xmlhttprequest.cpp:
2738         (WebCore::XMLHttpRequest::responseMIMEType):
2739         (WebCore::XMLHttpRequest::responseIsXML):
2740         (WebCore::XMLHttpRequest::didReceiveData):
2741         * xml/xmlhttprequest.h:
2742
2743 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
2744
2745         Mac build fix.
2746
2747         * platform/Font.h:
2748
2749 2007-06-21  Lars Knoll  <lars@trolltech.com>
2750
2751         Reviewed by Simon.
2752
2753         another small fix for letter spacing
2754
2755         * platform/qt/FontQt.cpp:
2756         (WebCore::generateComponents):
2757
2758 2007-06-21  Lars Knoll  <lars@trolltech.com>
2759
2760         Reviewed by Simon.
2761
2762         fix word-spacing
2763
2764         * platform/qt/FontQt.cpp:
2765         (WebCore::generateComponents):
2766         (WebCore::Font::width):
2767
2768 2007-06-21  Lars Knoll  <lars@trolltech.com>
2769
2770         Reviewed by Simon.
2771
2772         fix letterspacing and small caps.
2773
2774         * platform/Font.h:
2775         * platform/graphics/qt/GraphicsContextQt.cpp:
2776         (WebCore::GraphicsContext::setPlatformFont):
2777         * platform/qt/FileChooserQt.cpp:
2778         * platform/qt/FontQt.cpp:
2779         (WebCore::TextRunComponent::TextRunComponent):
2780         (WebCore::Font::Font):
2781         (WebCore::Font::operator=):
2782         (WebCore::Font::update):
2783         (WebCore::generateComponents):
2784         (WebCore::Font::selectionRectForText):
2785         * platform/qt/RenderThemeQt.cpp:
2786
2787 2007-06-21  Lars Knoll  <lars@trolltech.com>
2788
2789         Reviewed by Simon.
2790
2791         store the metrics and space width in the Font object
2792
2793         * platform/Font.h:
2794         * platform/qt/FontQt.cpp:
2795         (WebCore::Font::Font):
2796         (WebCore::Font::drawText):
2797         (WebCore::Font::width):
2798         (WebCore::Font::isFixedPitch):
2799         (WebCore::Font::ascent):
2800         (WebCore::Font::descent):
2801         (WebCore::Font::lineSpacing):
2802
2803 2007-06-21  Lars Knoll  <lars@trolltech.com>
2804
2805         Reviewed by Simon.
2806
2807         simplify some codepaths
2808
2809         * platform/qt/FontQt.cpp:
2810         (WebCore::Font::drawText):
2811         (WebCore::Font::width):
2812
2813 2007-06-21  Lars Knoll  <lars@trolltech.com>
2814
2815         Reviewed by Simon.
2816
2817         fix copyright header
2818
2819         * platform/qt/FontQt.cpp:
2820
2821 2007-06-21  Lars Knoll  <lars@trolltech.com>
2822
2823         Reviewed by Simon.
2824
2825         correctly load fonts when a list of font families is given
2826
2827         * platform/qt/FontQt.cpp:
2828         (WebCore::Font::Font):
2829
2830 2007-06-21  Lars Knoll  <lars@trolltech.com>
2831
2832         Reviewed by Simon.
2833
2834         fix some more of the font support
2835
2836         * platform/qt/FontQt.cpp:
2837         (WebCore::Font::drawText):
2838         (WebCore::Font::width):
2839
2840 2007-06-21  Lars Knoll  <lars@trolltech.com>
2841
2842         Reviewed by Simon.
2843
2844         Compile fixes
2845
2846         * platform/Font.h:
2847         (WebCore::Font::isRoundingHackCharacter):
2848         * platform/qt/FontQt.cpp:
2849         (WebCore::Font::drawText):
2850
2851 2007-06-21  Lars Knoll  <lars@trolltech.com>
2852
2853         Reviewed by Simon.
2854
2855         Some more work on the implementation of FontQt.
2856
2857         * platform/qt/FontQt.cpp:
2858         (WebCore::Font::Font):
2859         (WebCore::Font::~Font):
2860         (WebCore::Font::operator=):
2861
2862 2007-06-21  Lars Knoll  <lars@trolltech.com>
2863
2864         Reviewed by Simon.
2865
2866         Started work on the new font infrastructure for the Qt port.
2867
2868         * WebCore.pro:
2869         * editing/Editor.cpp:
2870         (WebCore::Editor::fontForSelection):
2871         * platform/Font.h:
2872         (WebCore::Font::treatAsSpace):
2873         (WebCore::Font::treatAsZeroWidthSpace):
2874         (WebCore::Font::isRoundingHackCharacter):
2875         * platform/qt/FontQt.cpp:
2876         (WebCore::Font::operator QFont):
2877         * platform/qt/TemporaryLinkStubs.cpp:
2878
2879 2007-06-21  Adam Roben  <aroben@apple.com>
2880
2881         More Gdk build fixes.
2882
2883         * page/gdk/ContextMenuClientGdk.cpp:
2884         (WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
2885         * page/gdk/ContextMenuClientGdk.h:
2886         * platform/gdk/TemporaryLinkStubs.cpp:
2887
2888 2007-06-21  Adam Roben  <aroben@apple.com>
2889
2890         Speculative Gdk build fix.
2891
2892         * page/InspectorController.h: Only include the JS headers we really
2893         need to avoid pulling in ones like JSStringRefCF.h.
2894
2895 2007-06-20  Adam Roben  <aroben@apple.com>
2896
2897         Speculative Gdk build fix.
2898
2899         * WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
2900
2901 2007-06-20  Adam Roben  <aroben@apple.com>
2902
2903         Windows build fix.
2904
2905         * WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
2906         everything but $WebKitLibrariesDir so that we will pick up
2907         JavaScriptCore headers directly.
2908
2909 2007-06-15  George Staikos  <staikos@kde.org>
2910
2911         Add missing symbol.
2912
2913         * platform/qt/TemporaryLinkStubs.cpp:
2914         (WebCore::contextMenuItemTagInspectElement):
2915
2916 2007-06-20  Steve Falkenburg  <sfalken@apple.com>
2917
2918         Reviewed by Maciej, Anders.
2919         
2920         <rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/
2921
2922         Keep a reference to the Page (via the main frame) for the
2923         load deferred pages.
2924         
2925         Reference is held via the frame since Page isn't refcounted.
2926
2927         * page/Chrome.cpp:
2928         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2929         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2930
2931 2007-06-15  Adam Treat <adam@staikos.net>
2932
2933         Reviewed by George Staikos.
2934
2935         Add ICO support to the Qt build.
2936
2937         * WebCore.pro:
2938         * platform/graphics/qt/ImageDecoderQt.cpp:
2939         (Q_IMPORT_PLUGIN):
2940
2941 2007-06-15  George Staikos  <staikos@kde.org>
2942
2943         Fixing Qt build.
2944
2945         * ForwardingHeaders/JavaScriptCore/APICast.h: Added.
2946         * WebCore.pro:
2947         * page/InspectorController.h:
2948
2949 2007-06-20  Adam Roben  <aroben@apple.com>
2950
2951         More speculative Qt/Gdk build fixes.
2952
2953         * WebCore.pro: Add new files.
2954
2955 2007-06-20  Adam Roben  <aroben@apple.com>
2956
2957         Speculative Qt/Gdk build fix.
2958
2959         Added forwarding headers for JavaScriptCore. We may eventually move
2960         InspectorController off of the JSC API, but for now this is the
2961         quickest way to a working build.
2962
2963         * ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
2964         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
2965         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
2966         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
2967         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
2968         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
2969         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
2970
2971 2007-06-20  Sam Weinig  <sam@webkit.org>
2972
2973         Rubber stamped by Adam Roben.
2974
2975         Add licenses.
2976
2977         * page/inspector/ConsolePanel.js:
2978         * page/inspector/NetworkPanel.js:
2979         * page/inspector/Resource.js:
2980         * page/inspector/ResourceCategory.js:
2981         * page/inspector/ResourcePanel.js:
2982
2983 2007-06-20  Mark Rowe  <mrowe@apple.com>
2984
2985         Reviewed by Adam.
2986
2987         * WebCore.exp: Export InspectorController::inspect so WebKit can see it.
2988
2989 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
2990
2991         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
2992
2993         Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
2994         Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
2995         returning nil instead of "")
2996
2997         I'm basically rolling out the change for <rdar://problem/4782422> because
2998         my testing shows that it was backwards.
2999         
3000         * html/HTMLElement.cpp:
3001         (dumpInnerHTML): New debug-only function to work around gdb being 
3002         perpetually suck-tastic.
3003
3004         * page/mac/WebCoreFrameBridge.mm:
3005         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
3006         
3007         Return "", not nil. This function never used to return nil, so let's not
3008         start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
3009
3010 2007-06-20  Adam Roben  <aroben@apple.com>
3011
3012         Addressed some of Geoff's comments.
3013
3014         * page/ContextMenuController.cpp:
3015         (WebCore::ContextMenuController::handleContextMenuEvent): Added a
3016         FIXME.
3017         * platform/ContextMenu.cpp:
3018         (WebCore::ContextMenu::addInspectElementItem): Null-check
3019         frame->page().
3020
3021 2007-06-20  Adam Roben  <aroben@apple.com>
3022
3023         Fix crash in fast/dom/dir-no-body.html
3024
3025         Reviewed by Mark.
3026
3027         * html/HTMLDocument.cpp:
3028         (WebCore::HTMLDocument::createTokenizer): Don't assume we have a
3029         Frame, since we won't if someone creates an HTMLDocument from JS.
3030
3031 2007-06-20  Adam Roben  <aroben@apple.com>
3032
3033         Land the new Inspector.
3034
3035         Co-written with Tim Hatcher.
3036
3037         Reviewed by Anders, Adele, Hyatt, and Sam.
3038
3039         No regression tests possible.
3040
3041         Add a new InspectorController that is in charge of the Inspector. It
3042         has an InspectorClient that controls the Inspector's window and node
3043         highlight.
3044
3045         * page/InspectorClient.h: Added.
3046         (WebCore::InspectorClient::~InspectorClient):
3047         * page/InspectorController.cpp: Added.
3048         (WebCore::ConsoleMessage::ConsoleMessage):
3049         (WebCore::InspectorResource::): Represents a single resource that the
3050         Inspector knows about.
3051         (WebCore::InspectorResource::InspectorResource):
3052         (WebCore::InspectorResource::~InspectorResource):
3053         (WebCore::InspectorResource::type):
3054         (WebCore::InspectorResource::setScriptObject):
3055         (WebCore::addSourceToFrame): Callback available from JS.
3056         (WebCore::getResourceDocumentNode): Ditto.
3057         (WebCore::highlightDOMNode): Ditto.
3058         (WebCore::hideDOMNodeHighlight): Ditto.
3059         (WebCore::loaded): Ditto.
3060         (WebCore::unloading): Ditto.
3061         (WebCore::attach): Ditto.
3062         (WebCore::detach): Ditto.
3063         (WebCore::log): Ditto.
3064         (WebCore::search): Ditto.
3065         (WebCore::inspectedWindow): Ditto.
3066         (WebCore::InspectorController::InspectorController):
3067         (WebCore::InspectorController::~InspectorController):
3068         (WebCore::InspectorController::inspect): Called by
3069         ContextMenuController to inspect a node.
3070         (WebCore::InspectorController::focusNode):
3071         (WebCore::InspectorController::highlight):
3072         (WebCore::InspectorController::hideHighlight):
3073         (WebCore::InspectorController::windowVisible):
3074         (WebCore::InspectorController::setWindowVisible):
3075         (WebCore::InspectorController::addMessageToConsole):
3076         (WebCore::InspectorController::attachWindow):
3077         (WebCore::InspectorController::detachWindow):
3078         (WebCore::InspectorController::windowScriptObjectAvailable):
3079         (WebCore::InspectorController::scriptObjectReady):
3080         (WebCore::InspectorController::windowUnloading):
3081         (WebCore::addHeaders): Static helper function.
3082         (WebCore::objectForRequest): Ditto.
3083         (WebCore::objectForResponse): Ditto.
3084         (WebCore::InspectorController::addScriptResource):
3085         (WebCore::InspectorController::addAndUpdateScriptResource):
3086         (WebCore::InspectorController::removeScriptResource):
3087         (WebCore::InspectorController::updateScriptResource):
3088         (WebCore::InspectorController::populateScriptResources):
3089         (WebCore::InspectorController::addScriptConsoleMessage):
3090         (WebCore::callClearFunction): Static helper function.
3091         (WebCore::InspectorController::clearScriptResources):
3092         (WebCore::InspectorController::clearScriptConsoleMessages):
3093         (WebCore::InspectorController::clearNetworkTimeline):
3094         (WebCore::InspectorController::pruneResources):
3095         (WebCore::InspectorController::didCommitLoad): Callback from
3096         FrameLoader.
3097         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
3098         (WebCore::InspectorController::addResource): Ditto.
3099         (WebCore::InspectorController::removeResource): Ditto.
3100         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
3101         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
3102         (WebCore::InspectorController::willSendRequest): Ditto.
3103         (WebCore::InspectorController::didReceiveResponse): Ditto.
3104         (WebCore::InspectorController::didReceiveContentLength): Ditto.
3105         (WebCore::InspectorController::didFinishLoading): Ditto.
3106         (WebCore::InspectorController::didFailLoading): Ditto.
3107         * page/InspectorController.h: Added.
3108         (WebCore::InspectorController::inspectedPage):
3109         (WebCore::InspectorController::scriptContext):
3110         (WebCore::InspectorController::setScriptContext):
3111         (WebCore::InspectorController::resources):
3112         (WebCore::InspectorController::removeAllResources):
3113
3114         Add the JavaScript that defines most of the behavior of the Inspector.
3115         
3116         * page/inspector/ConsolePanel.js: Added.
3117         * page/inspector/NetworkPanel.js: Added.
3118         * page/inspector/Resource.js: Added.
3119         * page/inspector/ResourceCategory.js: Added.
3120         * page/inspector/ResourcePanel.js: Added.
3121         * page/inspector/inspector.js: Added.
3122         * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
3123         * page/inspector/utilities.js: Added.
3124
3125         Add the Inspector's CSS and HTML.
3126
3127         * page/inspector/inspector.css: Added.
3128         * page/inspector/inspector.html: Added.
3129
3130         Hang the InspectorController off of Page. We only create an
3131         InspectorController if an InspectorClient is given to the Page.
3132
3133         * page/Page.cpp:
3134         (WebCore::Page::Page):
3135         * page/Page.h:
3136         (WebCore::Page::inspectorController):
3137
3138         Use FrameLoader to notify the InspectorController of resource loads.
3139
3140         * loader/FrameLoader.cpp:
3141         (WebCore::FrameLoader::begin):
3142         (WebCore::FrameLoader::transitionToCommitted):
3143         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
3144         (WebCore::FrameLoader::detachFromParent):
3145         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
3146         (WebCore::FrameLoader::willSendRequest):
3147         (WebCore::FrameLoader::didReceiveResponse):
3148         (WebCore::FrameLoader::didReceiveData):
3149         (WebCore::FrameLoader::sendRemainingDelegateMessages):
3150         (WebCore::FrameLoader::requestFromDelegate):
3151         (WebCore::FrameLoader::didFinishLoad):
3152         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
3153         (WebCore::FrameLoader::dispatchDidCommitLoad):
3154         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
3155         (WebCore::FrameLoader::dispatchWillSendRequest):
3156         (WebCore::FrameLoader::dispatchDidReceiveResponse):
3157         (WebCore::FrameLoader::dispatchDidReceiveContentLength):
3158         (WebCore::FrameLoader::dispatchDidFinishLoading):
3159         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
3160         * loader/FrameLoader.h:
3161
3162         Send console messages to the InspectorController.
3163
3164         * page/Chrome.cpp:
3165         (WebCore::Chrome::addMessageToConsole): Send all console messages to
3166         the InspectorController.
3167         * page/Chrome.h: Add a new MessageLevel and MessageSource that are
3168         used in the Inspector JS.
3169
3170         Report HTML errors when the Inspector window is open.
3171         We don't report errors when the window is closed because we don't want
3172         to slow down the HTMLTokenizer.
3173
3174         * html/HTMLDocument.cpp:
3175         (WebCore::HTMLDocument::createTokenizer):
3176         * html/HTMLParser.cpp:
3177         (WebCore::HTMLParser::HTMLParser):
3178         * html/HTMLParser.h:
3179         * html/HTMLTokenizer.cpp:
3180         (WebCore::HTMLTokenizer::HTMLTokenizer):
3181         * html/HTMLTokenizer.h:
3182
3183         Append the "Inspect Element" context menu item after passing the
3184         context menu to the ContextMenuClient. This work used to be done in
3185         WebKit.
3186
3187         * page/ContextMenuClient.h:
3188         * page/ContextMenuController.cpp:
3189         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
3190         "Inspect Element" item.
3191         (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
3192         "Inspect Element" item.
3193         * platform/ContextMenu.cpp:
3194         (WebCore::ContextMenu::addInspectElementItem):
3195         (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
3196         Element" item.
3197         * platform/ContextMenu.h:
3198         * platform/ContextMenuItem.h:
3199         (WebCore::): Add ContextMenuItemTagInspectElement.
3200         * platform/graphics/svg/SVGImageEmptyClients.h:
3201         * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
3202         string.
3203         * platform/LocalizedStrings.h: Ditto.
3204         * platform/mac/LocalizedStringsMac.mm:
3205         (WebCore::contextMenuItemTagInspectElement): Ditto.
3206
3207         Miscellaneous changes:
3208
3209         * css/view-source.css: Add message bubble styles.
3210         * loader/DocumentLoader.h: Add a frame getter.
3211         * platform/win/ScrollViewWin.cpp:
3212         (WebCore::ScrollView::updateScrollbars): Respect
3213         Frame::prohibitsScrolling.
3214
3215         Add new images needed for the Inspector.
3216
3217         * page/inspector/Images/attachedShadow.png: Added.
3218         * page/inspector/Images/bottomShadow.png: Added.
3219         * page/inspector/Images/breadcrumbBackground.png: Added.
3220         * page/inspector/Images/checker.png: Added.
3221         * page/inspector/Images/console.png: Added.
3222         * page/inspector/Images/darkShadow.png: Added.
3223         * page/inspector/Images/disclosureDownPressed.png: Added.
3224         * page/inspector/Images/disclosureRightDown.png: Added.
3225         * page/inspector/Images/disclosureRightPressed.png: Added.
3226         * page/inspector/Images/document.png: Added.
3227         * page/inspector/Images/domViewButton.png: Added.
3228         * page/inspector/Images/domViewButtonSelected.png: Added.
3229         * page/inspector/Images/downTriangle.png: Added.
3230         * page/inspector/Images/errorIcon.png: Added.
3231         * page/inspector/Images/errorMediumIcon.png: Added.
3232         * page/inspector/Images/folder.png: Added.
3233         * page/inspector/Images/goArrow.png: Added.
3234         * page/inspector/Images/gradient.png: Added.
3235         * page/inspector/Images/gradientHighlight.png: Added.
3236         * page/inspector/Images/gradientHighlightBottom.png: Added.
3237         * page/inspector/Images/hideStatusWidget.png: Added.
3238         * page/inspector/Images/hideStatusWidgetPressed.png: Added.
3239         * page/inspector/Images/network.png: Added.
3240         * page/inspector/Images/paneBottomGrow.png: Added.
3241         * page/inspector/Images/paneBottomGrowActive.png: Added.
3242         * page/inspector/Images/paneGrowHandleLine.png: Added.
3243         * page/inspector/Images/paneHeader.png: Added.
3244         * page/inspector/Images/paneHeaderActive.png: Added.
3245         * page/inspector/Images/plainDocument.png: Added.
3246         * page/inspector/Images/popupArrows.png: Added.
3247         * page/inspector/Images/rightTriangle.png: Added.
3248         * page/inspector/Images/segment.png: Added.
3249         * page/inspector/Images/segmentEnd.png: Added.
3250         * page/inspector/Images/segmentHover.png: Added.
3251         * page/inspector/Images/segmentHoverEnd.png: Added.
3252         * page/inspector/Images/segmentSelected.png: Added.
3253         * page/inspector/Images/segmentSelectedEnd.png: Added.
3254         * page/inspector/Images/showStatusWidget.png: Added.
3255         * page/inspector/Images/showStatusWidgetPressed.png: Added.
3256         * page/inspector/Images/sidbarItemBackground.png: Added.
3257         * page/inspector/Images/sidebarActionWidget.png: Added.
3258         * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
3259         * page/inspector/Images/sidebarAttachWidget.png: Added.
3260         * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
3261         * page/inspector/Images/sidebarDetachWidget.png: Added.
3262         * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
3263         * page/inspector/Images/sidebarResizeWidget.png: Added.
3264         * page/inspector/Images/sidebarSelection.png: Added.
3265         * page/inspector/Images/sidebarSelectionBlurred.png: Added.
3266         * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
3267         * page/inspector/Images/sidebarSelectionGray.png: Added.
3268         * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
3269         * page/inspector/Images/sidebarSelectionTall.png: Added.
3270         * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
3271         * page/inspector/Images/sourceViewButton.png: Added.
3272         * page/inspector/Images/sourceViewButtonSelected.png: Added.
3273         * page/inspector/Images/splitviewDimple.png: Added.
3274         * page/inspector/Images/splitviewDividerBackground.png: Added.
3275         * page/inspector/Images/tab.png: Added.
3276         * page/inspector/Images/tabSelected.png: Added.
3277         * page/inspector/Images/timelinePillBlue.png: Added.
3278         * page/inspector/Images/timelinePillGray.png: Added.
3279         * page/inspector/Images/timelinePillGreen.png: Added.
3280         * page/inspector/Images/timelinePillOrange.png: Added.
3281         * page/inspector/Images/timelinePillPurple.png: Added.
3282         * page/inspector/Images/timelinePillRed.png: Added.
3283         * page/inspector/Images/timelinePillYellow.png: Added.
3284         * page/inspector/Images/tipBalloon.png: Added.
3285         * page/inspector/Images/tipBalloonBottom.png: Added.
3286         * page/inspector/Images/tipIcon.png: Added.
3287         * page/inspector/Images/tipIconPressed.png: Added.
3288         * page/inspector/Images/toggleDown.png: Added.
3289         * page/inspector/Images/toggleUp.png: Added.
3290         * page/inspector/Images/toolbarBackground.png: Added.
3291         * page/inspector/Images/toolbarBackgroundInactive.png: Added.
3292         * page/inspector/Images/toolbarButton.png: Added.
3293         * page/inspector/Images/toolbarButtonInactive.png: Added.
3294         * page/inspector/Images/toolbarButtonPressed.png: Added.
3295         * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
3296         * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
3297         * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
3298         * page/inspector/Images/treeDownTriangleBlack.png: Added.
3299         * page/inspector/Images/treeDownTriangleWhite.png: Added.
3300         * page/inspector/Images/treeLeftTriangleBlack.png: Added.
3301         * page/inspector/Images/treeRightTriangleBlack.png: Added.
3302         * page/inspector/Images/treeRightTriangleWhite.png: Added.
3303         * page/inspector/Images/warningIcon.png: Added.
3304         * page/inspector/Images/warningMediumIcon.png: Added.
3305         * page/inspector/Images/warningsErrors.png: Added.
3306
3307         Build-fu:
3308
3309         * WebCore.exp: Added new symbols.
3310         * WebCore.xcodeproj/project.pbxproj: Added new source files and
3311         resources.
3312         * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
3313         $WebKitOutputDir.
3314
3315         Windows build fixes:
3316
3317         * history/HistoryItem.h: ResourceRequest is a struct.
3318         * loader/FrameLoaderClient.h: Ditto.
3319
3320 2007-06-20  Mitz Pettel  <mitz@webkit.org>
3321
3322         Reviewed by Beth.
3323
3324         - fix http://bugs.webkit.org/show_bug.cgi?id=14056
3325           REGRESSION (r21113-21143): TR background not repainted via style class change
3326
3327         Test: fast/repaint/table-row.html
3328
3329         * rendering/RenderTableRow.cpp:
3330         (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
3331         table row also needs layout, so it doesn't get a repaint in setStyle().
3332
3333 2007-06-20  Mitz Pettel  <mitz@webkit.org>
3334
3335         Reviewed by Adele.
3336
3337         - fix http://bugs.webkit.org/show_bug.cgi?id=14040
3338           Top and bottom border images flipped when using -webkit-border-image when border end up tiled
3339
3340         Test: fast/borders/border-image-01.html
3341
3342         Correctly account for the fact that "pattern space" is flipped.
3343
3344         * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
3345         * platform/graphics/cg/ImageCG.cpp:
3346         (WebCore::Image::drawPatternCallback):
3347         (WebCore::Image::drawPattern):
3348
3349 2007-06-20  Anders Carlsson  <andersca@apple.com>
3350
3351         Reviewed by Darin.
3352
3353         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
3354         
3355         Check for either '\r' or '\n' in the header value.
3356         
3357         * xml/xmlhttprequest.cpp:
3358         (WebCore::isValidHeaderValue):
3359
3360 2007-06-20  Patti Hoa  <patti@apple.com>
3361
3362         Reviewed by Geoffrey Garen.
3363
3364         <rdar://problem/4882527> VO should speak URL of image links that lack tags
3365         Add additional change from review
3366         
3367         * bridge/mac/WebCoreAXObject.mm:
3368         (-[WebCoreAXObject accessibilityAttributeValue:]):
3369         Check if the element has imgTag before asking for its url
3370         
3371 2007-06-20  Patti Hoa  <patti@apple.com>
3372
3373         Reviewed by Tristan O'Tierney.
3374
3375         <rdar://problem/4882527> VO should speak URL of image links that lack tags
3376         
3377         * bridge/mac/WebCoreAXObject.mm:
3378         (-[WebCoreAXObject accessibilityAttributeNames]):
3379         (-[WebCoreAXObject accessibilityAttributeValue:]):
3380         Return the url of images.
3381
3382 2007-06-19  Anders Carlsson  <andersca@apple.com>
3383
3384         Reviewed by Kevin Decker.
3385
3386         <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
3387         
3388         Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
3389         
3390         * loader/DocumentLoader.cpp:
3391         (WebCore::DocumentLoader::DocumentLoader):
3392         * loader/DocumentLoader.h:
3393         (WebCore::DocumentLoader::deferMainResourceDataLoad):
3394         * loader/MainResourceLoader.cpp:
3395         (WebCore::MainResourceLoader::handleDataLoadSoon):
3396         (WebCore::MainResourceLoader::loadNow):
3397         (WebCore::MainResourceLoader::setDefersLoading):
3398
3399 2007-06-19  Patti Hoa <patti@apple.com>
3400
3401         Reviewed by Justin Garcia.
3402         
3403         <rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
3404         
3405         * editing/visible_units.cpp:
3406         (WebCore::startPositionForLine):
3407         (WebCore::startOfLine):
3408         (WebCore::endPositionForLine):
3409         (WebCore::endOfLine):
3410         Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
3411         An example would be when lineStart/lineEnd at different line than the input position.
3412         This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
3413         specifically a line without webkit-line-break:after-white-space style.
3414
3415 2007-06-19  Patti Hoa  <patti@apple.com>
3416
3417         Reviewed by Justin Garcia.
3418         
3419         <rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap
3420         
3421         * bridge/mac/WebCoreAXObject.mm:
3422         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
3423         Improve the accuracy of the bounds for a given range
3424         
3425 2007-06-19  Anders Carlsson  <andersca@apple.com>
3426
3427         Reviewed by Darin.
3428
3429         <rdar://problem/5130630>
3430         XPath fails LayoutTests on Windows
3431         
3432         * xml/XPathPredicate.cpp:
3433         Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
3434         
3435         * xml/XPathValue.cpp:
3436         (WebCore::XPath::Value::toNumber):
3437         Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
3438         
3439 2007-06-19  Geoffrey Garen  <ggaren@apple.com>
3440
3441         Reviewed by Darin Adler.
3442
3443         Fixed cross-frame access. <rdar://problem/5251309>. 
3444
3445         * bindings/js/kjs_window.cpp:
3446         (KJS::Window::getValueProperty):
3447         * bindings/scripts/CodeGeneratorJS.pm:
3448         * page/DOMWindow.idl:
3449
3450 2007-06-19  Anders Carlsson  <andersca@apple.com>
3451
3452         Build fix.
3453         
3454         * platform/win/PopupMenuWin.cpp:
3455
3456 2007-06-19  Lars Knoll <lars@trolltech.com>
3457
3458         Reviewed by Zack
3459
3460         Implement these methods correctly.
3461
3462         * platform/qt/PlatformScreenQt.cpp:
3463         (WebCore::screenRect):
3464         (WebCore::screenAvailableRect):
3465
3466 2007-06-19  Sam Weinig  <sam@webkit.org>
3467
3468         Reviewed by Geoff.
3469
3470         Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
3471         Move the History object out of the JS bindings
3472
3473         - Autogenerate JSHistory.
3474
3475         * DerivedSources.make:
3476         * WebCore.pro:
3477         * WebCore.vcproj/WebCore.vcproj:
3478         * WebCore.xcodeproj/project.pbxproj:
3479         * bindings/js/kjs_window.cpp:
3480         (KJS::WindowPrivate::WindowPrivate):
3481         (KJS::Window::mark):
3482         (KJS::Window::getValueProperty):
3483         (KJS::Window::clearHelperObjectProperties):
3484         (KJS::Window::disconnectFrame):
3485         * bindings/js/kjs_window.h:
3486         (KJS::Window::):
3487         * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
3488         * bridge/History.h: Removed.
3489         * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
3490         * bridge/mac/HistoryMac.mm: Removed.
3491         * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
3492         * bridge/win/HistoryWin.cpp: Removed.
3493         * css/cssstyleselector.cpp:
3494         * page/DOMWindow.cpp:
3495         (WebCore::DOMWindow::disconnectFrame):
3496         (WebCore::DOMWindow::history):
3497         * page/DOMWindow.h:
3498         * page/DOMWindow.idl:
3499         * page/History.cpp: Added.
3500         (WebCore::History::History):
3501         (WebCore::History::frame):
3502         (WebCore::History::disconnectFrame):
3503         (WebCore::History::length):
3504         (WebCore::History::back):
3505         (WebCore::History::forward):
3506         (WebCore::History::go):
3507         * page/History.h: Added.
3508         * page/History.idl: Added.
3509         * platform/gdk/TemporaryLinkStubs.cpp:
3510         * platform/qt/TemporaryLinkStubs.cpp:
3511         * platform/wx/TemporaryLinkStubs.cpp:
3512
3513 2007-06-18  Sam Weinig  <sam@webkit.org>
3514
3515         Qt build fix.
3516
3517         * platform/qt/PlatformScreenQt.cpp:
3518         (WebCore::screenDepth):
3519         (WebCore::screenDepthPerComponent):
3520         (WebCore::screenIsMonochrome):
3521         (WebCore::screenRect):
3522         (WebCore::screenAvailableRect):
3523
3524 2007-06-18  Sam Weinig  <sam@webkit.org>
3525
3526         Reviewed by Beth.
3527
3528         Fix build and update licenses. 
3529
3530         * WebCore.xcodeproj/project.pbxproj:
3531         * page/BarInfo.cpp:
3532         * page/BarInfo.h:
3533         * page/BarInfo.idl:
3534         * page/Screen.cpp:
3535         (WebCore::Screen::height):
3536         (WebCore::Screen::width):
3537         (WebCore::Screen::colorDepth):
3538         (WebCore::Screen::pixelDepth):
3539         (WebCore::Screen::availLeft):
3540         (WebCore::Screen::availTop):
3541         (WebCore::Screen::availHeight):
3542         (WebCore::Screen::availWidth):
3543         * page/Screen.h:
3544         * page/Screen.idl:
3545
3546 2007-06-18  Anders Carlsson  <andersca@apple.com>
3547
3548         Reviewed by John Sullivan.
3549
3550         <rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]
3551         
3552         Don't send any frame load callbacks if the document load hasn't been
3553         committed for real.
3554         
3555         * loader/FrameLoader.cpp:
3556         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3557
3558 2007-06-18  Sam Weinig  <sam@webkit.org>
3559
3560         Reviewed by Geoff.
3561
3562         Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
3563         Move the Screen object out of the JS bindings
3564
3565         - Renames Screen.h to PlatformScreen.h to accommodate new class.
3566         - Autogenerates JSScreen.
3567
3568         * DerivedSources.make:
3569         * WebCore.pro:
3570         * WebCore.vcproj/WebCore.vcproj:
3571         * WebCore.xcodeproj/project.pbxproj:
3572         * bindings/js/kjs_window.cpp:
3573         (KJS::WindowPrivate::WindowPrivate):
3574         (KJS::Window::mark):
3575         (KJS::Window::getValueProperty):
3576         (KJS::Window::clearHelperObjectProperties):
3577         * bindings/js/kjs_window.h:
3578         (KJS::Window::):
3579         * css/MediaQueryEvaluator.cpp:
3580         * page/DOMWindow.cpp:
3581         (WebCore::DOMWindow::DOMWindow):
3582         (WebCore::DOMWindow::~DOMWindow):
3583         (WebCore::DOMWindow::frame):
3584         (WebCore::DOMWindow::disconnectFrame):
3585         (WebCore::DOMWindow::screen):
3586         * page/DOMWindow.h:
3587         * page/DOMWindow.idl:
3588         * page/Screen.cpp: Added.
3589         (WebCore::Screen::Screen):
3590         (WebCore::Screen::disconnectFrame):
3591         (WebCore::Screen::height):
3592         (WebCore::Screen::width):
3593         (WebCore::Screen::colorDepth):
3594         (WebCore::Screen::pixelDepth):
3595         (WebCore::Screen::availLeft):
3596         (WebCore::Screen::availTop):
3597         (WebCore::Screen::availHeight):
3598         (WebCore::Screen::availWidth):
3599         * page/Screen.h: Added.
3600         * page/Screen.idl: Added.
3601         * page/mac/WebCoreFrameBridge.mm:
3602         * platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
3603         * platform/Screen.h: Removed.
3604         * platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
3605         * platform/gdk/ScreenGdk.cpp: Removed.
3606         * platform/mac/PlatformMouseEventMac.mm:
3607         * platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
3608         * platform/mac/ScreenMac.mm: Removed.
3609         * platform/qt/PlatformScreenQt.cpp: Added.
3610         (WebCore::WebCore::screenDepth):
3611         (WebCore::WebCore::screenDepthPerComponent):
3612         (WebCore::WebCore::screenIsMonochrome):
3613         (WebCore::WebCore::screenRect):
3614         (WebCore::WebCore::screenAvailableRect):
3615         * platform/qt/TemporaryLinkStubs.cpp:
3616         * platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
3617         * platform/win/ScreenWin.cpp: Removed.
3618         * rendering/RenderObject.cpp:
3619
3620 2007-06-18  Sam Weinig  <sam@webkit.org>
3621
3622         Reviewed by Geoff.
3623
3624         Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
3625         Move the BarInfo object out of the JS bindings
3626
3627         * DerivedSources.make:
3628         * WebCore.pro:
3629         * WebCore.vcproj/WebCore.vcproj:
3630         * WebCore.xcodeproj/project.pbxproj:
3631         * bindings/js/kjs_window.cpp:
3632         (KJS::WindowPrivate::WindowPrivate):
3633         (KJS::Window::mark):
3634         (KJS::Window::getValueProperty):
3635         (KJS::Window::clearHelperObjectProperties):
3636         (KJS::Window::disconnectFrame):
3637         * bindings/js/kjs_window.h:
3638         (KJS::Window::):
3639         * page/BarInfo.cpp: Added.
3640         (WebCore::BarInfo::BarInfo):
3641         (WebCore::BarInfo::disconnectFrame):
3642         (WebCore::BarInfo::visible):
3643         * page/BarInfo.h: Added.
3644         (WebCore::BarInfo::):
3645         * page/BarInfo.idl: Added.
3646         * page/DOMWindow.cpp:
3647         (WebCore::DOMWindow::~DOMWindow):
3648         (WebCore::DOMWindow::disconnectFrame):
3649         (WebCore::DOMWindow::locationbar):
3650         (WebCore::DOMWindow::menubar):
3651         (WebCore::DOMWindow::personalbar):
3652         (WebCore::DOMWindow::scrollbars):
3653         (WebCore::DOMWindow::statusbar):
3654         (WebCore::DOMWindow::toolbar):
3655         * page/DOMWindow.h:
3656         * page/DOMWindow.idl:
3657
3658 2007-06-18  Sam Weinig  <sam@webkit.org>
3659
3660         Reviewed by Darin.
3661
3662         Remove the FrameArray class and instead make window.frames another
3663         self-reference for window (like window.window, window.self, etc).
3664         This is what Firefox and what the HTML5 dictates.
3665
3666         * bindings/js/kjs_window.cpp:
3667         (KJS::WindowPrivate::WindowPrivate):
3668         (KJS::Window::mark):
3669         (KJS::Window::getValueProperty):
3670         (KJS::Window::clearHelperObjectProperties):
3671         (KJS::Window::disconnectFrame):
3672         * bindings/js/kjs_window.h:
3673
3674 2007-06-18  Mitz Pettel  <mitz@webkit.org>
3675
3676         Reviewed by Adele.
3677
3678         - fix http://bugs.webkit.org/show_bug.cgi?id=13413
3679           Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
3680
3681         Test: fast/forms/input-zero-height-focus.html
3682
3683         * rendering/RenderTextControl.cpp:
3684         (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
3685         selection in a zero-height text control.
3686
3687 2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>
3688
3689         Reviewed by Sam Weinig.
3690
3691         http://bugs.webkit.org/show_bug.cgi?id=14052
3692         Implement SoundGdk
3693
3694         * WebCore.pro:
3695         * platform/gdk/SoundGdk.cpp: Added.
3696         (WebCore::systemBeep):
3697         * platform/gdk/TemporaryLinkStubs.cpp:
3698         (WebCore::systemBeep):
3699
3700 2007-06-18  Dave Hyatt  <hyatt@apple.com>
3701
3702         Add support for horizontal mouse wheeling on Windows.
3703         
3704         Reviewed by aroben
3705
3706         * platform/PlatformWheelEvent.h:
3707         * platform/win/WheelEventWin.cpp:
3708         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3709
3710 2007-06-17  Sam Weinig  <sam@webkit.org>
3711
3712         Win32 build fix.
3713
3714         * WebCore.vcproj/WebCore.vcproj:
3715
3716 2007-06-15  David Hyatt  <hyatt@apple.com>
3717
3718         Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
3719         because of a botched 'round' support removal.  Also update for a change in
3720         the spec that has the second stretch/round/repeat keyword match the first
3721         if omitted.
3722         
3723         Reviewed by olliej
3724
3725         * css/cssparser.cpp:
3726         (WebCore::BorderImageParseContext::commitBorderImage):
3727         * platform/graphics/Image.cpp:
3728         (WebCore::Image::drawTiled):
3729         * platform/graphics/Image.h:
3730         (WebCore::Image::):
3731
3732 2007-06-15  Sam Weinig  <sam@webkit.org>
3733
3734         Reviewed by Darin.
3735
3736         Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
3737         Autogenerate JS binding for Rect
3738
3739         - Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList 
3740           and DOMRGBColor to JSRGBColor
3741         - Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
3742
3743         * DerivedSources.make:
3744         * WebCore.pro:
3745         * WebCore.xcodeproj/project.pbxproj:
3746         * bindings/js/kjs_css.cpp:
3747         (WebCore::):
3748         (WebCore::JSStyleSheetList::JSStyleSheetList):
3749         (WebCore::JSStyleSheetList::~JSStyleSheetList):
3750         (WebCore::JSStyleSheetList::getValueProperty):
3751         (WebCore::JSStyleSheetList::indexGetter):
3752         (WebCore::JSStyleSheetList::nameGetter):
3753         (WebCore::JSStyleSheetList::getOwnPropertySlot):
3754         (WebCore::toJS):
3755         (WebCore::JSStyleSheetListFunc::callAsFunction):
3756         (WebCore::JSRGBColor::JSRGBColor):
3757         (WebCore::JSRGBColor::~JSRGBColor):
3758         (WebCore::JSRGBColor::getOwnPropertySlot):
3759         (WebCore::JSRGBColor::getValueProperty):
3760         (WebCore::getJSRGBColor):
3761         * bindings/js/kjs_css.h:
3762         (WebCore::JSStyleSheetList::classInfo):
3763         (WebCore::JSStyleSheetList::):
3764         (WebCore::JSStyleSheetList::impl):
3765         (WebCore::JSRGBColor::classInfo):
3766         (WebCore::JSRGBColor::):
3767         (WebCore::JSRGBColor::impl):
3768         * bindings/objc/DOMUtility.mm:
3769         (KJS::createDOMWrapper):
3770         * bindings/scripts/CodeGeneratorJS.pm:
3771         * bindings/scripts/CodeGeneratorObjC.pm:
3772         * css/CSSBorderImageValue.cpp:
3773         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
3774         * css/CSSBorderImageValue.h:
3775         * css/CSSPrimitiveValue.cpp:
3776         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3777         (WebCore::CSSPrimitiveValue::cssText):
3778         * css/CSSPrimitiveValue.h:
3779         (WebCore::CSSPrimitiveValue::getRectValue):
3780         (WebCore::CSSPrimitiveValue::):
3781         * css/DashboardRegion.h:
3782         * css/Rect.h: Copied from css/RectImpl.h.
3783         (WebCore::Rect::~Rect):
3784         (WebCore::Rect::top):
3785         (WebCore::Rect::right):
3786         (WebCore::Rect::bottom):
3787         (WebCore::Rect::left):
3788         (WebCore::Rect::setTop):
3789         (WebCore::Rect::setRight):
3790         (WebCore::Rect::setBottom):
3791         (WebCore::Rect::setLeft):
3792         * css/Rect.idl:
3793         * css/RectImpl.h: Removed.
3794         * css/cssparser.cpp:
3795         (WebCore::CSSParser::parseShape):
3796         (WebCore::BorderImageParseContext::commitBorderImage):
3797         * css/cssstyleselector.cpp:
3798         (WebCore::CSSStyleSelector::applyProperty):
3799         * page/DOMWindow.idl:
3800
3801 2007-06-14  George Staikos  <staikos@kde.org>
3802
3803         Reviewed by Lars.
3804
3805         Implement missing tab support and a slight refactor.
3806
3807         * platform/qt/PlatformKeyboardEventQt.cpp:
3808         (WebCore::keyIdentifierForQtKeyCode):
3809         (WebCore::windowsKeyCodeForKeyEvent):
3810         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
3811
3812 2007-06-14  Dave Hyatt  <hyatt@apple.com>
3813
3814         Fix for Bugzilla bug 14806, missing text for bold/italic fonts in non-English Windows installs.
3815         
3816         This patch adds an additional step after the lookup by full name fails.  It will then look up
3817         a PostScript name in a (localized full name) -> (PostScript name) cache.  If the name is not
3818         found, then the font's name table is obtained and searched for a PostScript name (and the
3819         result is cached).
3820         
3821         If lookup on PostScript name fails too, then we now properly fall back to the next font in the
3822         list (so text should never be missing).
3823
3824         Reviewed by Darin (thoroughly reviewed, super reviewed even)
3825
3826         * platform/win/FontCacheWin.cpp:
3827         * platform/win/FontPlatformDataWin.cpp:
3828
3829 2007-06-14  Anders Carlsson  <andersca@apple.com>
3830
3831         Reviewed by Geoff.
3832
3833         Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
3834         for a given plug-in.
3835
3836         * WebCore.exp:
3837         * page/Frame.cpp:
3838         (WebCore::Frame::cleanupScriptObjectsForPlugin):
3839         * page/Frame.h:
3840
3841 2007-06-14  Anders Carlsson  <andersca@apple.com>
3842
3843         Reviewed by Geoff.
3844
3845         <rdar://problem/5211677>
3846         -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
3847         
3848         * loader/FrameLoader.cpp:
3849         (WebCore::FrameLoader::requestObject):
3850         If the object is a Java MIME type and Java is disabled, don't load the plug-in.
3851         
3852         * platform/MimeTypeRegistry.cpp:
3853         (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
3854         Clean this up and add another applet MIME type.
3855
3856 2007-06-14  George Staikos  <staikos@kde.org>
3857
3858         Reviewed by Lars.
3859
3860         Implement the file chooser for Qt.
3861
3862         * platform/qt/FileChooserQt.cpp:
3863         (WebCore::FileChooser::openFileChooser):
3864         (WebCore::FileChooser::basenameForWidth):
3865
3866 2007-06-14  George Staikos  <staikos@kde.org>
3867
3868         Reviewed by Lars.
3869
3870         Add missing initialization of pointer.
3871
3872         * platform/qt/ContextMenuQt.cpp:
3873         (WebCore::ContextMenu::ContextMenu):
3874
3875 2007-06-14  Anders Carlsson  <andersca@apple.com>
3876
3877         Reviewed by Mitz.
3878
3879         <rdar://problem/5244948>
3880         Safari keeps on complaining about slow script playing NBC TV video (14133)
3881
3882         http://bugs.webkit.org/show_bug.cgi?id=14133
3883         Runaway JavaScript timer fires when spinning around in Google Maps street view
3884
3885         Make sure to start and stop the timeout checker around calls to JS.
3886
3887         * bindings/objc/WebScriptObject.mm:
3888         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3889         (-[WebScriptObject evaluateWebScript:]):
3890
3891 2007-06-14  George Staikos  <staikos@kde.org>
3892
3893         Reviewed by Maciej.
3894
3895         Keypress causes typeahead crash on empty selects due to modulo 0.
3896
3897         * html/HTMLSelectElement.cpp:
3898         (WebCore::HTMLSelectElement::typeAheadFind):
3899
3900 2007-06-13  George Staikos  <staikos@kde.org>
3901
3902         Reviewed by Lars.
3903
3904         Compile without self-linking.
3905
3906         * WebCore.pro:
3907
3908 2007-06-13  Darin Adler  <darin@apple.com>
3909
3910         Reviewed by Kevin Decker.
3911
3912         - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
3913           +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
3914
3915         * platform/mac/WebFontCache.mm:
3916         (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
3917         Took out the auto-activation code.
3918         (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
3919         then calls NSFont to trigger activation if that returned nil, then calls
3920         internalFontWithFamily again.
3921
3922 2007-06-13  Anders Carlsson  <andersca@apple.com>
3923
3924         Reviewed by Geoff.
3925
3926         Pass the root object to methods that end up creating new ObjcInstance objects.
3927         
3928         * bindings/objc/WebScriptObject.mm:
3929         (listFromNSArray):
3930         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3931         (-[WebScriptObject evaluateWebScript:]):
3932         (-[WebScriptObject setValue:forKey:]):
3933         (-[WebScriptObject valueForKey:]):
3934         (-[WebScriptObject removeWebScriptKey:]):
3935         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
3936
3937 2007-06-13  Anders Carlsson  <andersca@apple.com>
3938
3939         Reviewed by Darin.
3940
3941         <rdar://problem/5267992>
3942         Make sure an alert doesn't allow loading to continue inside a script.
3943         
3944         Make sure to defer all loads where it's possible for a second main loop to be running.
3945         
3946         * page/Chrome.cpp:
3947         (WebCore::Chrome::runModal):
3948         (WebCore::Chrome::runBeforeUnloadConfirmPanel):
3949         (WebCore::Chrome::runJavaScriptAlert):
3950         (WebCore::Chrome::runJavaScriptConfirm):
3951         (WebCore::Chrome::runJavaScriptPrompt):
3952         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
3953         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
3954         
3955         * platform/network/cf/ResourceHandleCFNet.cpp:
3956         (WebCore::ResourceHandle::setDefersLoading):
3957         Implement this.
3958
3959 2007-06-13  Alp Toker  <alp.toker@collabora.co.uk>
3960
3961         Reviewed by Rob.
3962
3963         http://bugs.webkit.org/show_bug.cgi?id=14060
3964         Cairo SVG support
3965
3966         * WebCore.pro: Add new files to the build.
3967         * platform/graphics/svg/SVGPaintServerPattern.h:
3968         * platform/graphics/svg/SVGPaintServerSolid.h:
3969         * platform/graphics/svg/cairo: Added.
3970         * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
3971         (WebCore::RenderPath::strokeContains):
3972         (WebCore::RenderPath::strokeBBox):
3973         * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
3974         (WebCore::SVGPaintServer::draw):
3975         (WebCore::SVGPaintServer::teardown):
3976         (WebCore::SVGPaintServer::renderPath):
3977         * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
3978         (WebCore::SVGPaintServerGradient::setup):
3979         * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
3980         (WebCore::SVGPaintServerPattern::setup):
3981         * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
3982         (WebCore::SVGPaintServerSolid::setup):
3983         * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
3984         (WebCore::SVGResourceClipper::applyClip):
3985         * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
3986         (WebCore::SVGResourceMasker::applyMask):
3987
3988 2007-06-13  Simon Hausmann  <hausmann@kde.org>
3989
3990         Reviewed by Lars.
3991
3992         Added a make install target that installs the Qt port and renamed
3993         WebKitQt to QtWebKit
3994
3995         * WebCore.pro:
3996
3997 2007-06-13  Adam Roben  <aroben@apple.com>
3998
3999         Fix one more BITMAPINFO/BITMAPINFOHEADER typo.
4000
4001         Rubberstamped by Oliver.
4002
4003         * platform/win/DragImageWin.cpp:
4004         (WebCore::allocImage):
4005
4006 2007-06-12  Oliver Hunt  <oliver@apple.com>
4007
4008         Reviewed by Darin.
4009
4010         Use correct size for BITMAPINFOHEADER -- whoops.
4011
4012         * platform/win/CursorWin.cpp:
4013         (WebCore::Cursor::Cursor):
4014         * platform/win/PasteboardWin.cpp:
4015         (WebCore::Pasteboard::writeImage):
4016
4017 2007-06-12  Sam Weinig  <sam@webkit.org>
4018
4019         Reviewed by Oliver.
4020
4021         Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
4022         Cleanup JSEvent and JSClipboard in preperation for autogeneration
4023
4024         * bindings/js/kjs_events.cpp:
4025         (KJS::DOMEvent::DOMEvent):
4026         (KJS::DOMEvent::getValueProperty):
4027         (KJS::DOMEvent::put):
4028         (KJS::DOMEvent::putValueProperty):
4029         (KJS::DOMEventPrototypeFunction::callAsFunction):
4030         (KJS::toJS):
4031         (KJS::toEvent):
4032         (KJS::):
4033         (KJS::JSClipboard::JSClipboard):
4034         (KJS::JSClipboard::~JSClipboard):
4035         (KJS::JSClipboard::getOwnPropertySlot):
4036         (KJS::JSClipboard::getValueProperty):
4037         (KJS::JSClipboard::put):
4038         (KJS::JSClipboard::putValueProperty):
4039         (KJS::JSClipboardPrototypeFunction::callAsFunction):
4040         (KJS::toClipboard):
4041         * bindings/js/kjs_events.h:
4042         (KJS::DOMEvent::):
4043         (KJS::DOMEvent::impl):
4044         (KJS::JSClipboard::impl):
4045         * dom/ClipboardEvent.h:
4046         * dom/Event.h:
4047         (WebCore::Event::srcElement):
4048         (WebCore::Event::returnValue):
4049         (WebCore::Event::clipboardData):
4050         (WebCore::Event::dataTransfer):
4051         (WebCore::Event::clipboard):
4052         * dom/MouseEvent.h:
4053
4054 2007-06-13  Lars Knoll <lars@trolltech.com>
4055
4056         Reviewed by Niko.
4057
4058         Small cleanup
4059
4060         * platform/qt/PlugInInfoStoreQt.cpp:
4061         (WebCore::PlugInInfoStore::supportsMIMEType):
4062
4063 2007-06-13  Lars Knoll <lars@trolltech.com>
4064
4065         Reviewed by Niko
4066
4067         Implement the parts required for the JS bridge
4068         to know about the plugins.
4069
4070         * WebCore.pro:
4071         * platform/qt/PlugInInfoStoreQt.cpp: Added.
4072         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
4073         (WebCore::PlugInInfoStore::pluginCount):
4074         (WebCore::PlugInInfoStore::supportsMIMEType):
4075         (WebCore::refreshPlugins):
4076         * platform/qt/TemporaryLinkStubs.cpp:
4077
4078 === Merged the following changes from branches/WindowsMerge ===
4079
4080 2007-06-09  Sam Weinig  <sam@webkit.org>
4081
4082         Build fix.
4083
4084         * WebCore.vcproj/WebCore.vcproj:
4085
4086 2007-06-08  Anders Carlsson  <andersca@apple.com>
4087
4088         Reviewed by Adam.
4089
4090         If both the old and new WMP plugins are present, remove the old one
4091         so we won't end up choosing it.
4092         
4093         * plugins/win/PluginDatabaseWin.cpp:
4094         (WebCore::PluginDatabaseWin::getPluginsInPaths):
4095
4096 2007-06-08  David Hyatt  <hyatt@apple.com>
4097
4098         Update licenses/copyrights for WebCoreWin.
4099
4100         Reviewed by mccullough
4101
4102         * WebCorePrefix.cpp:
4103         * bridge/win/FrameWin.cpp:
4104         * bridge/win/FrameWin.h:
4105         * bridge/win/HistoryWin.cpp:
4106         * bridge/win/PageWin.cpp:
4107         * page/win/EventHandlerWin.cpp:
4108         * platform/graphics/cg/ColorCG.cpp:
4109         * platform/graphics/cg/GraphicsContextPlatformPrivate.h:
4110         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
4111         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
4112         * platform/graphics/win/IconWin.cpp:
4113         * platform/graphics/win/ImageWin.cpp:
4114         * platform/network/cf/FormDataStreamCFNet.cpp:
4115         * platform/network/cf/FormDataStreamCFNet.h:
4116         * platform/network/cf/ResourceHandleCFNet.cpp:
4117         * platform/network/cf/ResourceRequestCFNet.cpp:
4118         * platform/network/cf/ResourceResponseCFNet.cpp:
4119         * platform/network/win/CookieJarWin.cpp:
4120         * platform/network/win/ResourceHandleWin.cpp:
4121         * platform/network/win/ResourceHandleWin.h:
4122         * platform/win/BString.cpp:
4123         * platform/win/BString.h:
4124         * platform/win/ClipboardWin.h:
4125         * platform/win/ContextMenuWin.cpp:
4126         * platform/win/CursorWin.cpp:
4127         * platform/win/EditorWin.cpp:
4128         * platform/win/FontCacheWin.cpp:
4129         * platform/win/FontDataWin.cpp:
4130         * platform/win/FontPlatformData.h:
4131         * platform/win/FontPlatformDataWin.cpp:
4132         * platform/win/FontWin.cpp:
4133         * platform/win/GlyphPageTreeNodeWin.cpp:
4134         * platform/win/GraphicsContextWin.cpp:
4135         * platform/win/KeyEventWin.cpp:
4136         * platform/win/MimeTypeRegistryWin.cpp:
4137         * platform/win/NotImplemented.h:
4138         * platform/win/PlatformMouseEventWin.cpp:
4139         * platform/win/PlatformScrollBar.h:
4140         * platform/win/PlatformScrollBarWin.cpp:
4141         * platform/win/PopupMenuWin.cpp:
4142         * platform/win/ScreenWin.cpp:
4143         * platform/win/ScrollViewWin.cpp:
4144         * platform/win/SearchPopupMenuWin.cpp:
4145         * platform/win/SoundWin.cpp:
4146         * platform/win/TemporaryLinkStubs.cpp:
4147         * platform/win/TextBoundariesWin.cpp:
4148         * platform/win/WebCoreHistory.cpp:
4149         * platform/win/WebCoreHistory.h:
4150         * platform/win/WebCoreSystemInterface.cpp:
4151         * platform/win/WebCoreSystemInterface.h:
4152         * platform/win/WheelEventWin.cpp:
4153         * platform/win/WidgetWin.cpp:
4154         * plugins/win/PlugInInfoStoreWin.cpp:
4155         * plugins/win/PluginDatabaseWin.cpp:
4156         * plugins/win/PluginDatabaseWin.h:
4157         * plugins/win/PluginDebug.h:
4158         * plugins/win/PluginPackageWin.cpp:
4159         * plugins/win/PluginPackageWin.h:
4160         * plugins/win/PluginStreamWin.cpp:
4161         * plugins/win/PluginStreamWin.h:
4162         * plugins/win/PluginViewWin.cpp:
4163         * plugins/win/PluginViewWin.h:
4164         * plugins/win/npapi.cpp:
4165         * plugins/win/npfunctions.h:
4166         * rendering/RenderThemeSafari.cpp:
4167         * rendering/RenderThemeSafari.h:
4168         * rendering/RenderThemeWin.h:
4169
4170 2007-06-07  Sam Weinig  <sam@webkit.org>
4171
4172         Fix build.
4173
4174         * WebCore.vcproj/WebCore.vcproj:
4175
4176 2007-06-07  Anders Carlsson  <andersca@apple.com>
4177
4178         Reviewed by Steve.
4179
4180         <rdar://problem/5252902>
4181         Shockwave plug-in content crashes.
4182         
4183         Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
4184         and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
4185         a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave 
4186         does not use CallWndProc but instead treats the WNDPROC as a function.
4187         
4188         * plugins/win/PluginViewWin.cpp:
4189         (WebCore::PluginViewWndProc):
4190         (WebCore::PluginViewWin::determineQuirks):
4191         (WebCore::PluginViewWin::init):
4192         * plugins/win/PluginViewWin.h:
4193         (WebCore::):
4194         (WebCore::PluginViewWin::quirks):
4195
4196 2007-06-07  Sam Weinig  <sam@webkit.org>
4197
4198         Build fix for the build fix.
4199
4200         * WebCore.vcproj/WebCore.vcproj:
4201
4202 2007-06-07  Sam Weinig  <sam@webkit.org>
4203
4204         Build fix.
4205
4206         * WebCore.vcproj/WebCore.vcproj:
4207
4208 2007-06-06  Sam Weinig  <sam@webkit.org>
4209
4210         Build fix.
4211
4212         * WebCore.vcproj/WebCore.vcproj:
4213
4214 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
4215
4216         Reviewed by Oliver.
4217
4218         Update to last fix.
4219         Invalidate a list of rects rather than unioning them.
4220
4221         * plugins/win/PluginViewWin.cpp:
4222         (WebCore::PluginViewWin::invalidateTimerFired):
4223         (WebCore::PluginViewWin::invalidateRect):
4224         * plugins/win/PluginViewWin.h:
4225
4226 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
4227
4228         Reviewed by Oliver.
4229
4230         <rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com
4231         
4232         Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
4233         starving other HWNDs.
4234         
4235         This code defers the invalidate through a WebCore::Timer.  We could have used a Windows ::SetTimer
4236         to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
4237         performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.
4238
4239         * plugins/win/PluginViewWin.cpp:
4240         (WebCore::PluginViewWin::invalidateTimerFired): Added.
4241         (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash.
4242         (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
4243         * plugins/win/PluginViewWin.h:
4244
4245 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
4246
4247         Reviewed by Adam.
4248
4249         Update last fix to use startsWith instead of strcmpi.
4250
4251         * plugins/win/PluginStreamWin.cpp:
4252         (WebCore::PluginStreamWin::startStream):
4253         * plugins/win/PluginViewWin.cpp:
4254         (WebCore::scriptStringIfJavaScriptURL):
4255
4256 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
4257
4258         Reviewed by gramps.
4259
4260         Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
4261         Make "javascript" URL scheme string compare case insensitive.
4262
4263         * plugins/win/PluginStreamWin.cpp:
4264         (WebCore::PluginStreamWin::startStream): Use strcmpi.
4265         * plugins/win/PluginViewWin.cpp:
4266         (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.
4267
4268 2007-06-01  Anders Carlsson  <andersca@apple.com>
4269
4270         Reviewed by Steve.
4271
4272         If the value exists but is empty, return an empty String.
4273         
4274         * plugins/win/PluginPackageWin.cpp:
4275         (WebCore::getVersionInfo):
4276
4277 2007-06-01  Anders Carlsson  <andersca@apple.com>
4278
4279         Reviewed by Steve.
4280
4281         Add the default path for the new WMP Firefox plugin.
4282
4283         * plugins/win/PluginDatabaseWin.cpp:
4284         (WebCore::addWindowsMediaPlayerPluginPath):
4285
4286 2007-05-31  Sam Weinig  <sam@webkit.org>
4287
4288         Fixed build.
4289
4290         * WebCore.vcproj/WebCore.vcproj:
4291
4292 2007-05-31  Sam Weinig  <sam@webkit.org>
4293
4294         Fixed build.
4295
4296         * WebCore.vcproj/WebCore.vcproj:
4297
4298 2007-05-30  Ada Chan  <adachan@apple.com>
4299
4300         Reviewed by Adam.
4301
4302         Fixed build.
4303
4304         * platform/win/PopupMenuWin.cpp:
4305         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
4306
4307 2007-05-30  Sam Weinig  <sam@webkit.org>
4308
4309         Build Fix.
4310
4311         * WebCore.vcproj/WebCore.vcproj:
4312
4313 2007-05-29  Sam Weinig  <sam@webkit.org>
4314
4315         Fix the build.
4316
4317         * WebCore.vcproj/WebCore.vcproj:
4318
4319 2007-05-29  Anders Carlsson  <andersca@apple.com>
4320
4321         Reviewed by Adam.
4322
4323         <rdar://4782915> plugin is not in the right place at jumble.com/play.html
4324
4325         Pass the plugin window coordinates for windowed plugins too.
4326         
4327         * plugins/win/PluginViewWin.cpp:
4328         (WebCore::PluginViewWin::setNPWindowRect):
4329
4330 2007-05-29  Anders Carlsson  <andersca@apple.com>
4331
4332         Reviewed by Adam.
4333
4334         <rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
4335         <rdar://problem/5131528> play button on Flash in ESPN front page does not start movie
4336         
4337         Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
4338         the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a 
4339         quirk for that.
4340         
4341         * plugins/win/PluginViewWin.cpp:
4342         (WebCore::PluginViewWin::determineQuirks):
4343         (WebCore::PluginViewWin::init):
4344         * plugins/win/PluginViewWin.h:
4345         (WebCore::):