82f2ac872fb61559720f35bf5759d6657ee79233
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
2
3         Reviewed by Dan Bernstein.
4
5         Transformed reflected elements are clipped inside element with opacity
6         https://bugs.webkit.org/show_bug.cgi?id=30957
7         
8         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
9         each clip rect into painting space before taking the unions. This, however, did not work
10         correctly with combinations of reflections and transforms. Fixed by unioning the
11         clipRect and mapping through transforms along the way.
12         
13         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
14         where the transparency layers are.
15
16         Test: fast/reflections/opacity-reflection-transform.html
17
18         * rendering/RenderLayer.cpp:
19         (WebCore::expandClipRectForDescendantsAndReflection):
20         (WebCore::transparencyClipBox):
21         (WebCore::RenderLayer::beginTransparencyLayers):
22
23 2009-11-12  Adam Barth  <abarth@webkit.org>
24
25         Reviewed by Darin Fisher.
26
27         Improve SecurityOrigin::toString comment
28         https://bugs.webkit.org/show_bug.cgi?id=31041
29
30         * page/SecurityOrigin.h:
31
32 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
33
34         Reviewed by Darin Adler.
35
36         externalRepresentation should take Frame as the argument
37         https://bugs.webkit.org/show_bug.cgi?id=31393
38
39         No new tests as this is just a refactoring.
40
41         * WebCore.base.exp:
42         * rendering/RenderTreeAsText.cpp:
43         (WebCore::externalRepresentation):
44         * rendering/RenderTreeAsText.h:
45
46 2009-11-12  Ben Murdoch  <benm@google.com>
47
48         Reviewed by Dimitri Glazkov.
49
50         [Android] The Android specific files in page/Android are out of date.
51         https://bugs.webkit.org/show_bug.cgi?id=31437
52
53         No tests required.
54
55         * page/android/DragControllerAndroid.cpp:
56         (WebCore::DragController::dragOperation): Added.
57         (WebCore::DragController::cleanupAfterSystemDrag):
58         * page/android/EventHandlerAndroid.cpp:
59         (WebCore::EventHandler::accessKeyModifiers): Added.
60         * page/android/InspectorControllerAndroid.cpp: Removed.
61
62 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
63
64         Reviewed by Simon Fraser.
65
66         [CAIRO] shadow support for Canvas and SVG.
67         [https://bugs.webkit.org/show_bug.cgi?id=30960]
68
69         Implement Canvas/SVG shadow support for Cairo.  This patch
70         uses the filter code from SVG Filters.  That means that it is
71         necessary to activate filters to see the shadows.
72
73         Test: fast/canvas/canvas-shadow.html
74
75         * GNUmakefile.am:
76         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
77         * platform/graphics/GraphicsContext.h:
78         * platform/graphics/cairo/GraphicsContextCairo.cpp:
79         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
80         (WebCore::setPlatformFill):
81         (WebCore::setPlatformStroke):
82         (WebCore::copyContextProperties):
83         (WebCore::drawPathShadow):
84         (WebCore::GraphicsContext::fillPath):
85         (WebCore::GraphicsContext::strokePath):
86         (WebCore::GraphicsContext::drawPath):
87         (WebCore::GraphicsContext::setPlatformShadow):
88         (WebCore::GraphicsContext::createPlatformShadow):
89         * platform/graphics/cairo/ImageCairo.cpp:
90         (WebCore::BitmapImage::draw): Add filter effect.
91         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
92         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
93         * platform/graphics/filters/ImageBufferFilter.h: Added.
94         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
95         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
96
97 2009-11-12  Dmitry Titov  <dimich@chromium.org>
98
99         Reviewed by Alexey Proskuryakov.
100
101         Add postTaskToMainThread to ScriptExecutionContext.
102         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
103         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
104         contexts that live on the main thread.
105         https://bugs.webkit.org/show_bug.cgi?id=31427
106
107         No new tests - simply moving the code.
108
109         * dom/Document.cpp:
110         (WebCore::Document::postTask):
111         * dom/ScriptExecutionContext.cpp:
112         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
113         (WebCore::ScriptExecutionContextTaskTimer::fired):
114         (WebCore::PerformTaskData::PerformTaskData):
115         (WebCore::PerformTaskData::performTask):
116         (WebCore::ScriptExecutionContext::postTaskToMainThread):
117         * dom/ScriptExecutionContext.h:
118
119 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
120
121         Reviewed by Darin Adler.
122
123         Fix crash when removing compositing layers when GC is enabled
124         https://bugs.webkit.org/show_bug.cgi?id=31429
125
126         Workaround <rdar://problem/7390716> by special-casing the removal
127         of all sublayers when GC is enabled.
128
129         * platform/graphics/mac/GraphicsLayerCA.mm:
130         (WebCore::safeSetSublayers):
131         (WebCore::GraphicsLayerCA::updateSublayerList):
132         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
133
134 2009-11-12  Jens Alfke  <snej@chromium.org>
135
136         Reviewed by Dimitri Glazkov.
137
138         The last of the V8 binding optimizations.
139         - Replace string-valued element accessors with a shared getter/setter function.
140         - Change error handling flow of control to avoid extra branches and function calls.
141         https://bugs.webkit.org/show_bug.cgi?id=31443
142         
143         * bindings/scripts/CodeGeneratorV8.pm:
144         * bindings/v8/V8Binding.cpp:
145         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
146         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
147         * bindings/v8/V8Binding.h:
148
149 2009-11-12  Sam Weinig  <sam@webkit.org>
150
151         Reviewed by Oliver Hunt.
152
153         Fix for <rdar://problem/7267951>
154         Canvas methods should reject uses of NaN and Infinity.
155
156         Test: fast/canvas/canvas-with-illegal-args.html
157
158         * html/canvas/CanvasRenderingContext2D.cpp:
159         (WebCore::CanvasRenderingContext2D::scale):
160         (WebCore::CanvasRenderingContext2D::rotate):
161         (WebCore::CanvasRenderingContext2D::translate):
162         (WebCore::CanvasRenderingContext2D::transform):
163         (WebCore::CanvasRenderingContext2D::setTransform):
164
165 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
166
167         Reviewed by Timothy Hatcher.
168
169         Web Inspector: profile timeline panel, fix obvious problems.
170
171         https://bugs.webkit.org/show_bug.cgi?id=31432
172
173         * inspector/front-end/AbstractTimelinePanel.js:
174         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
175         * inspector/front-end/TimelinePanel.js:
176         (WebInspector.TimelinePanel.prototype._setWindowPosition):
177         (WebInspector.TimelineCalculator):
178         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
179         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
180         (WebInspector.TimelineCalculator.prototype.reset):
181         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
182         (WebInspector.TimelineCalculator.prototype.formatValue):
183         (WebInspector.TimelineGraph):
184         (WebInspector.TimelineGraph.prototype.refresh):
185         * inspector/front-end/utilities.js:
186         (Element.prototype.hasStyleClass):
187
188 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
189
190         Reviewed by Timothy Hatcher.
191
192         Web Inspector: preload status bar button glyphs
193         in order to prevent them from flickering.
194
195         https://bugs.webkit.org/show_bug.cgi?id=31439
196
197         * inspector/front-end/inspector.js:
198         (preloadImages):
199
200 2009-11-12  Adam Roben  <aroben@apple.com>
201
202         Replace worldIDs with world objects
203
204         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
205         user scripts/stylesheets and isolated worlds
206
207         Reviewed by Sam Weinig.
208
209         Covered by existing tests.
210
211         * WebCore.base.exp: Update exported symbols to match what now exists
212         and is needed by WebKit.
213
214         * bindings/js/ScheduledAction.cpp:
215         (WebCore::ScheduledAction::execute): Updated for function rename.
216
217         * bindings/js/ScriptController.cpp: Removed code that dealt with
218         worldIDs.
219         (WebCore::ScriptController::createWorld): Added. Returns a new world
220         suitable for use on the main thread.
221         (WebCore::ScriptController::executeScriptInWorld): Renamed from
222         executeScriptInIsolatedWorld, since this works just fine with a
223         "normal" world.
224
225         * bindings/js/ScriptController.h: Added createWorld, removed functions
226         that took worldIDs, renamed executeScriptInIsolatedWorld to
227         executeScriptInWorld.
228
229         * page/Frame.cpp:
230         (WebCore::Frame::injectUserScripts):
231         (WebCore::Frame::injectUserScriptsForWorld):
232         Updated for changes to UserScriptMap and ScriptController.
233
234         * page/Frame.h: Changed injectUserScriptsForWorld to take a
235         DOMWrapperWorld* instead of a worldID.
236
237         * page/PageGroup.cpp:
238         (WebCore::PageGroup::addUserScriptToWorld):
239         (WebCore::PageGroup::addUserStyleSheetToWorld):
240         (WebCore::PageGroup::removeUserScriptFromWorld):
241         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
242         (WebCore::PageGroup::removeUserScriptsFromWorld):
243         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
244         * page/PageGroup.h:
245         Changed these functions to take a DOMWrapperWorld* instead of a
246         worldID. Also updated for changes to UserScript and UserStyleSheet.
247
248         * page/UserScript.h:
249         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
250         never used.
251
252         * page/UserScriptTypes.h:
253         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
254         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
255         worldID as their key type.
256
257
258 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
259
260         Reviewed by Tim Hatcher.
261
262         Fixes <http://webkit.org/b/31260>.
263         Web Inspector: Main Resources Other than HTML are mis-detected.
264         
265         Even if the resource is a main resource, look at its CachedResource type, 
266         because it might be an image, stylesheet, or JavaScript file, and we
267         want to show them all correctly.
268
269         * inspector/InspectorResource.cpp:
270         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
271         (WebCore::InspectorResource::type): 
272         * inspector/InspectorResource.h:
273
274 2009-11-12  Jens Alfke  <snej@chromium.org>
275
276         Reviewed by Dimitri Glazkov.
277
278         Table-driven setup for V8 binding template callback functions. 100k in code savings.
279         https://bugs.webkit.org/show_bug.cgi?id=31420
280
281         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
282             to call configureTemplate().
283         * bindings/v8/V8Binding.cpp:
284         (WebCore::configureTemplate):  New function; does all the standard configuration work.
285         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
286         * bindings/v8/V8Binding.h:
287         * bindings/v8/V8Proxy.cpp:
288         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
289         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
290         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
291         * bindings/v8/V8Proxy.h:
292
293 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
294
295         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
296
297         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
298
299 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
300
301         Reviewed by Dan Bernstein.
302
303         <rdar://problem/7388969> Add DOM API for fullscreen video
304         
305         DOM API for fullscreen <video>.
306
307         Tests: media/media-fullscreen-inline.html
308                media/media-fullscreen-not-in-document.html
309
310         * dom/EventNames.h:
311             Add webkitbeginfullscreen and webkitendfullscreen.
312
313         * html/HTMLAttributeNames.in:
314             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
315
316         * html/HTMLMediaElement.cpp:
317         (WebCore::HTMLMediaElement::parseMappedAttribute):
318             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
319         (WebCore::HTMLMediaElement::enterFullscreen):
320             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
321             actually do enter fullscreen.
322         (WebCore::HTMLMediaElement::exitFullscreen):
323             Schedule webkitendfullscreenEvent event.
324         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
325         (WebCore::HTMLMediaElement::webkitExitFullScreen):
326         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
327         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
328             New, access to fullscreen properties and methods.
329
330         * html/HTMLMediaElement.h:
331         * html/HTMLMediaElement.idl:
332             Declare methods needed for fullscreen API.
333
334         * html/HTMLVideoElement.cpp:
335         (WebCore::HTMLVideoElement::supportsFullscreen):
336             Return false if a movie does not have video.
337
338         * page/DOMWindow.h:
339             Add webkitbeginfullscreen and webkitendfullscreen.
340
341 2009-11-12  Adam Barth  <abarth@webkit.org>
342
343         Reviewed by Dimitri Glazkov.
344
345         [Chromium] Sify compose button alerts error
346         https://bugs.webkit.org/show_bug.cgi?id=31394
347
348         Test: http/tests/security/calling-versus-current.html
349
350         We're supposed to use the calling context for security checks.  In JSC
351         land, this is the lexicalGlobalObject.
352
353         * bindings/v8/V8Proxy.cpp:
354         (WebCore::V8Proxy::canAccessPrivate):
355
356 2009-11-12  Daniel Bates  <dbates@webkit.org>
357
358         Reviewed by Darin Adler.
359
360         https://bugs.webkit.org/show_bug.cgi?id=30291
361
362         Fixes an issue where the returned drop effect is incorrect when
363         effectAllowed == "uninitialized".
364
365         According to section 7.9.2 of the HTML 5 spec.
366         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
367         when effectAllowed = "uninitialized" the resulting dropEffect should be the
368         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
369         other case.
370         
371         No test cases are included because we have an existing test case from
372         bug #24731.
373
374         * dom/Clipboard.cpp:
375         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
376
377 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
378
379         Reviewed by Timothy Hatcher.
380
381         Web Inspector: Do not highlight node on refresh.
382
383         https://bugs.webkit.org/show_bug.cgi?id=31419
384
385         * inspector/front-end/ElementsPanel.js:
386         (WebInspector.ElementsPanel.prototype.reset):
387
388 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
389
390         Reviewed by Timothy Hatcher.
391
392         Web Inspector: Minor timeline fixes.
393
394         https://bugs.webkit.org/show_bug.cgi?id=31417
395
396         * inspector/front-end/TimelinePanel.js:
397         (WebInspector.TimelinePanel.prototype._getRecordDetails):
398         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
399         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
400         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
401
402 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
403
404         SnowLeopard build fix.
405
406         Renamed initWithClient to initWithAuthenticationClient.
407
408         * platform/network/mac/AuthenticationMac.mm:
409         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
410         (WebCore::AuthenticationChallenge::setAuthenticationClient):
411
412 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
413
414         Reviewed by Darin Adler.
415
416         ARIA: add alert type roles
417         https://bugs.webkit.org/show_bug.cgi?id=31392
418
419         Test: platform/mac/accessibility/aria-alerts.html
420
421         * accessibility/AccessibilityObject.h:
422         * accessibility/AccessibilityRenderObject.cpp:
423         * accessibility/mac/AccessibilityObjectWrapper.mm:
424
425 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
426
427         Reviewed by Darin Adler.
428
429         https://bugs.webkit.org/show_bug.cgi?id=31386
430         Make Mac AuthenticationChallenge usable from cross-platform code
431
432         No change in behavior, so no tests.
433
434         * platform/network/ResourceHandle.cpp:
435         (WebCore::ResourceHandle::clearAuthentication):
436         * platform/network/ResourceHandleInternal.h:
437         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
438         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
439         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
440         is identical.
441
442         * platform/network/cf/AuthenticationChallenge.h:
443         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
444         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
445
446         * platform/network/cf/ResourceHandleCFNet.cpp:
447         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
448         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
449         be already set.
450
451         * platform/network/mac/AuthenticationChallenge.h:
452         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
453         best of my understanding.
454         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
455         confusion with "mac" and "web" challenges in ResourceHandleInternal.
456
457         * platform/network/mac/AuthenticationMac.mm:
458         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
459         making it possible to use the latter with NSURLAuthenticationChallenge.
460         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
461         m_nsChallenge renaming.
462         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
463         set it as sender (or unset, if client is null).
464
465         * platform/network/mac/ResourceHandleMac.mm:
466         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
467         authentication challenge sender.
468         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
469         authentication sheet.
470         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
471         using the new setAuthenticationClient() method.
472         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
473         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
474         the original Mac one, not the one we created for use with authentication sheet. I don't
475         know when a connection would cancel authentication in practice, so I haven't tested this.
476
477 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
478
479         Reviewed by Timothy Hatcher.
480
481         Web Inspector: breakpoint sidebar entries should allow click over entire list item
482         https://bugs.webkit.org/show_bug.cgi?id=31411
483
484         No new tests; no new functionality, small usability change. 
485
486         * inspector/front-end/BreakpointsSidebarPane.js:
487         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
488         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
489
490 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
491
492         Reviewed by Timothy Hatcher.
493
494         Web Inspector: breakpoints in named evals are not restored after a reload
495         https://bugs.webkit.org/show_bug.cgi?id=31375
496
497         Manual test added
498
499         * inspector/front-end/ScriptsPanel.js:
500         (WebInspector.ScriptsPanel.prototype.addScript):
501         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
502
503 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
504
505         Reviewed by Kenneth Rohde Christiansen.
506
507         Custom printing shrink factors
508         https://bugs.webkit.org/show_bug.cgi?id=29042
509
510         This reverts commit r49769. The public API for this needs to be reviewed
511         before its inclusion in Qt.
512
513         * page/PrintContext.cpp:
514         (WebCore::PrintContext::begin):
515         * page/Settings.cpp:
516         (WebCore::Settings::Settings):
517         * page/Settings.h:
518
519 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
520
521         Reviewed by Pavel Feldman.
522
523         Web Inspector: Resource errors/warnings not shown in the Resource tree.
524
525         Error/Warning bubbles are not displayed next to the resource in the 
526         Resources panel if those occur before the resource is attached to the tree.
527         https://bugs.webkit.org/show_bug.cgi?id=31404
528
529         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
530
531         * inspector/front-end/AbstractTimelinePanel.js:
532         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
533         * inspector/front-end/ResourcesPanel.js:
534         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
535
536 2009-11-12  Philippe Normand  <pnormand@igalia.com>
537
538         Reviewed by Jan Alonzo.
539
540         https://bugs.webkit.org/show_bug.cgi?id=31047
541         [GTK] Failing test media/video-played-ranges-1.html
542
543         Follow-up of r50726, don't block the UI thread when calling
544         gst_element_get_state(). Also fixed a compilation warning and some
545         static casts.
546
547         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
548         (WebCore::playbackPosition):
549         (WebCore::MediaPlayerPrivate::seek):
550         (WebCore::MediaPlayerPrivate::setRate):
551
552 2009-11-12  Philippe Normand  <pnormand@igalia.com>
553
554         Reviewed by Jan Alonzo.
555
556         https://bugs.webkit.org/show_bug.cgi?id=31047
557         [GTK] Failing test media/video-played-ranges-1.html
558
559         don't pause pipeline if already paused, same for play()
560
561         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
562         (WebCore::MediaPlayerPrivate::play):
563         (WebCore::MediaPlayerPrivate::pause):
564
565 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
566
567         Reviewed by David Levin.
568
569         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
570         Chromium too.
571         https://bugs.webkit.org/show_bug.cgi?id=31292
572
573         No new tests. (Corresponding test for Gtk+ is
574         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
575
576         * page/EventHandler.cpp:
577         * page/chromium/EventHandlerChromium.cpp:
578
579 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
580
581         Reviewed by Eric Seidel.
582
583         Prevent text inside a multi-column block from being split into columns.
584         
585         If the tentative height of a multi-column block was too small, we need to
586         expand the block height and try to layout again, in order to prevent text
587         from being split into different columns.
588
589         CSS Multicolumn text is split awkwardly
590         https://bugs.webkit.org/show_bug.cgi?id=22249
591
592         Test: fast/multicol/single-line.html
593
594         * rendering/RenderBlock.cpp:
595         (WebCore::RenderBlock::layoutColumns):
596         * rendering/RenderBlock.h:
597         * rendering/RenderLineBoxList.cpp:
598         (WebCore::RenderLineBoxList::paint):
599         * rendering/RenderView.h:
600         (WebCore::RenderView::setTruncatedAt):
601         (WebCore::RenderView::setMinimumColumnHeight):
602         (WebCore::RenderView::minimumColumnHeight):
603
604 2009-11-11  Kent Tamura  <tkent@chromium.org>
605
606         Reviewed by Darin Adler.
607
608         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
609         https://bugs.webkit.org/show_bug.cgi?id=31195
610
611         Test: fast/forms/input-file-re-render.html
612
613         * rendering/RenderFileUploadControl.cpp:
614         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
615
616 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
617
618         Reviewed by Dimitri Glazkov.
619
620         Fixing Chromium's POSIX VFS implementation, by adding the required
621         "used file descriptors" logic.
622
623         https://bugs.webkit.org/show_bug.cgi?id=31275
624
625         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
626
627 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
628
629         Reviewed by Oliver Hunt.
630
631         need to implement aria tree roles
632         https://bugs.webkit.org/show_bug.cgi?id=31284
633
634         Tests: platform/mac/accessibility/aria-multiselectable.html
635                platform/mac/accessibility/aria-tree.html
636
637         * accessibility/AccessibilityList.cpp:
638         (WebCore::AccessibilityList::accessibilityIsIgnored):
639         * accessibility/AccessibilityObject.cpp:
640         (WebCore::AccessibilityObject::ariaTreeRows):
641         (WebCore::AccessibilityObject::ariaTreeItemContent):
642         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
643         * accessibility/AccessibilityObject.h:
644         (WebCore::):
645         (WebCore::AccessibilityObject::isTree):
646         (WebCore::AccessibilityObject::isTreeItem):
647         (WebCore::AccessibilityObject::setIsExpanded):
648         (WebCore::AccessibilityObject::canSetExpandedAttribute):
649         (WebCore::AccessibilityObject::hierarchicalLevel):
650         (WebCore::AccessibilityObject::setSelectedRows):
651         (WebCore::AccessibilityObject::performDefaultAction):
652         * accessibility/AccessibilityRenderObject.cpp:
653         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
654         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
655         (WebCore::AccessibilityRenderObject::isExpanded):
656         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
657         (WebCore::AccessibilityRenderObject::elementAttributeValue):
658         (WebCore::AccessibilityRenderObject::setIsExpanded):
659         (WebCore::AccessibilityRenderObject::isSelected):
660         (WebCore::AccessibilityRenderObject::setSelected):
661         (WebCore::AccessibilityRenderObject::setSelectedRows):
662         (WebCore::createARIARoleMap):
663         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
664         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
665         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
666         (WebCore::AccessibilityRenderObject::selectedChildren):
667         * accessibility/AccessibilityRenderObject.h:
668         * accessibility/mac/AccessibilityObjectMac.mm:
669         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
670         * accessibility/mac/AccessibilityObjectWrapper.mm:
671         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
672         (RoleEntry::):
673         (-[AccessibilityObjectWrapper subrole]):
674         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
675         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
676         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
677         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
678         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
679         * html/HTMLAttributeNames.in:
680
681 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
682
683         Build fix after @r50760 with ENABLE_FILTERS.
684
685         * platform/graphics/filters/SourceAlpha.cpp:
686         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
687         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
688           to fillRect.
689
690 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
691
692         Reviewed by Alexey Proskuryakov.
693
694         Fix WebSocket frame parser of frame_type with high-order bit set.
695         https://bugs.webkit.org/show_bug.cgi?id=30668
696
697         If buffer is smaller than frame's length, it should break the loop
698         instead of reading next byte.
699
700         Tests: websocket/tests/frame-length-longer-than-buffer.html
701                websocket/tests/frame-length-skip.html
702
703         * websockets/WebSocketChannel.cpp:
704         (WebCore::WebSocketChannel::didReceiveData):
705
706 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
707
708         Reviewed by Adam Barth.
709
710         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
711         https://bugs.webkit.org/show_bug.cgi?id=31345
712
713         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
714
715         * platform/graphics/chromium/FontCustomPlatformData.cpp:
716         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
717         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
718         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
719
720 2009-11-11  Beth Dakin  <bdakin@apple.com>
721
722         Build fix. No review needed.
723
724         * platform/graphics/gtk/FontGtk.cpp:
725         (WebCore::Font::drawComplexText):
726
727 2009-11-11  Beth Dakin  <bdakin@apple.com>
728
729         Build fix. No review needed.
730
731         * platform/graphics/cairo/FontCairo.cpp:
732         (WebCore::Font::drawGlyphs):
733
734 2009-11-11  Beth Dakin  <bdakin@apple.com>
735
736         Windows build fix. No review needed. 
737
738         * platform/graphics/win/FontCGWin.cpp:
739         (WebCore::Font::drawGlyphs):
740
741 2009-11-11  Beth Dakin  <bdakin@apple.com>
742
743         Reviewed by Simon Fraser.
744
745         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
746         Make -webkit-color-correction work with shadows
747
748         From canvas, just send DeviceColorSpace to setShadow() for now. 
749         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
750         * html/canvas/CanvasRenderingContext2D.cpp:
751         (WebCore::CanvasRenderingContext2D::setShadow):
752         (WebCore::CanvasRenderingContext2D::applyShadow):
753
754         setShadow() and setPlatformShadow() now take a ColorSpace.
755         * platform/graphics/GraphicsContext.cpp:
756         (WebCore::GraphicsContext::setShadow):
757         * platform/graphics/GraphicsContext.h:
758         * platform/graphics/cg/GraphicsContextCG.cpp:
759         (WebCore::createCGColorWithColorSpace): New helper to create a 
760         color in a ColorSpace.
761         (WebCore::setCGFillColor): Call new helper.
762         (WebCore::setCGStrokeColor): Call new helper.
763         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
764         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
765         (WebCore::GraphicsContext::setPlatformShadow):
766
767         Send appropriate ColorSpace to setShadow().
768         * platform/graphics/mac/FontMac.mm:
769         (WebCore::Font::drawGlyphs):
770         * rendering/EllipsisBox.cpp:
771         (WebCore::EllipsisBox::paint):
772         * rendering/InlineFlowBox.cpp:
773         (WebCore::InlineFlowBox::paintTextDecorations):
774         * rendering/InlineTextBox.cpp:
775         (WebCore::paintTextWithShadows):
776         (WebCore::InlineTextBox::paintDecoration):
777         * rendering/RenderBoxModelObject.cpp:
778         (WebCore::RenderBoxModelObject::paintBoxShadow):
779         * rendering/SVGInlineTextBox.cpp:
780         (WebCore::SVGInlineTextBox::paintCharacters):
781         * rendering/SVGRenderSupport.cpp:
782         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
783
784         Attempt to keep ports building.
785         * platform/graphics/cairo/GraphicsContextCairo.cpp:
786         (WebCore::GraphicsContext::setPlatformShadow):
787         * platform/graphics/qt/GraphicsContextQt.cpp:
788         (WebCore::GraphicsContext::setPlatformShadow):
789         * platform/graphics/skia/GraphicsContextSkia.cpp:
790         (WebCore::GraphicsContext::setPlatformShadow):
791         * platform/graphics/wince/GraphicsContextWince.cpp:
792         (WebCore::GraphicsContext::setPlatformShadow):
793         * platform/graphics/wx/GraphicsContextWx.cpp:
794         (WebCore::GraphicsContext::setPlatformShadow):
795
796 2009-11-11  Kent Tamura  <tkent@chromium.org>
797
798         Reviewed by Darin Adler.
799
800         Print the file text of a file upload control in DumpRenderTree for ease of tests.
801         https://bugs.webkit.org/show_bug.cgi?id=31195
802
803         * rendering/RenderFileUploadControl.cpp:
804         (WebCore::RenderFileUploadControl::paintObject):
805         (WebCore::RenderFileUploadControl::fileTextValue):
806         * rendering/RenderFileUploadControl.h:
807         (WebCore::RenderFileUploadControl::isFileUploadControl):
808         (WebCore::toRenderFileUploadControl):
809         * rendering/RenderObject.h:
810         (WebCore::RenderObject::isFileUploadControl):
811         * rendering/RenderTreeAsText.cpp:
812         (WebCore::operator<<):
813
814 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
815
816         Reviewed by Sam Weinig.
817
818         DOM Wrappers for some nodes may not be marked.
819         https://bugs.webkit.org/show_bug.cgi?id=31380
820
821         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
822         the wrapper for the current world only.  This means that wrappers may be GC'ed
823         prematurely, and properties lost.
824
825         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
826
827         * bindings/js/JSAttrCustom.cpp:
828         (WebCore::JSAttr::markChildren):
829         * bindings/js/JSDOMBinding.cpp:
830         (WebCore::markDOMNodeWrapper):
831         * bindings/js/JSDOMBinding.h:
832         * bindings/js/JSNamedNodeMapCustom.cpp:
833         (WebCore::JSNamedNodeMap::markChildren):
834         * bindings/js/JSNodeCustom.cpp:
835         (WebCore::JSNode::markChildren):
836         * bindings/js/JSSVGElementInstanceCustom.cpp:
837         (WebCore::JSSVGElementInstance::markChildren):
838         * bindings/js/JSStyleSheetCustom.cpp:
839         (WebCore::JSStyleSheet::markChildren):
840
841 2009-11-11  Ben Murdoch  <benm@google.com>
842
843         Reviewed by Darin Adler.
844
845         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
846         https://bugs.webkit.org/show_bug.cgi?id=31384
847
848         No functionality change so no tests required.
849
850         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
851
852 2009-11-11  Jens Alfke  <snej@chromium.org>
853
854         Reviewed by Dimitri Glazkov.
855
856         The Big De-Inlining. 450k code size reduction (32-bit x86.)
857         - Various inline functions in V8Binding.h made non-inline.
858         - Some renaming for consistency.
859         - New function createRawTemplate().
860         https://bugs.webkit.org/show_bug.cgi?id=31383
861
862         * bindings/scripts/CodeGeneratorV8.pm:
863         * bindings/v8/V8Binding.cpp:
864         (WebCore::v8DOMWrapperToNative):
865         (WebCore::v8ValueToWebCoreString):
866         (WebCore::v8ValueToAtomicWebCoreString):
867         (WebCore::toInt32):
868         (WebCore::toWebCoreString):
869         (WebCore::toWebCoreStringWithNullCheck):
870         (WebCore::toAtomicWebCoreStringWithNullCheck):
871         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
872         (WebCore::isUndefinedOrNull):
873         (WebCore::v8Boolean):
874         (WebCore::v8UndetectableString):
875         (WebCore::v8StringOrNull):
876         (WebCore::v8StringOrUndefined):
877         (WebCore::v8StringOrFalse):
878         (WebCore::v8StringToWebCoreString):
879         (WebCore::v8ExternalString):
880         (WebCore::createRawTemplate):  New function.
881         * bindings/v8/V8Binding.h:
882         (WebCore::v8DOMWrapperTo):
883         (WebCore::v8DOMWrapperToNode):
884         (WebCore::v8StringToWebCoreString):
885         (WebCore::v8StringToAtomicWebCoreString):
886
887 2009-11-11  Jens Alfke  <snej@chromium.org>
888
889         Reviewed by Dimitri Glazkov.
890
891         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
892         event-listener setter into a new subroutine transferHiddenDependency().
893         https://bugs.webkit.org/show_bug.cgi?id=31377
894
895         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
896         * bindings/v8/V8Utilities.cpp:
897         (WebCore::transferHiddenDependency):  New.
898         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
899
900 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
901
902         Reviewed by Beth Dakin.
903
904         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
905         because there is a CG bug preventing this from working.
906
907         * platform/graphics/cg/GraphicsContextCG.cpp:
908         (WebCore::sRGBColorSpaceRef):
909
910 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
911
912         Reviewed by Timothy Hatcher.
913
914         Check that if Storage panel exists before calling its methods
915
916         https://bugs.webkit.org/show_bug.cgi?id=31343
917
918         * inspector/front-end/inspector.js:
919         (WebInspector.addDatabase):
920         (WebInspector.addCookieDomain):
921         (WebInspector.addDOMStorage):
922         (WebInspector.updateDOMStorage):
923
924 2009-11-11  Jens Alfke  <snej@chromium.org>
925
926         Reviewed by Dimitri Glazkov.
927
928         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
929         times in the generated V8 bindings.
930         https://bugs.webkit.org/show_bug.cgi?id=31368
931
932         * bindings/v8/V8DOMWrapper.cpp:
933         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
934         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
935
936 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
937
938         Reviewed by Timothy Hatcher.
939
940         Display the correct summary in the web inspector for the shorthands
941         border-color, border-width, border-style, margin, and padding.
942         https://bugs.webkit.org/show_bug.cgi?id=7987
943
944         Test: fast/css/shorthands-four-values.html
945
946         * css/CSSMutableStyleDeclaration.cpp:
947         (WebCore::CSSMutableStyleDeclaration::get4Values):
948         Display the summary information in the same way the shorthand would be
949         specified in a css rule.
950
951 2009-11-11  Jens Alfke  <snej@chromium.org>
952
953         Reviewed by Dimitri Glazkov.
954
955         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
956         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
957         https://bugs.webkit.org/show_bug.cgi?id=31367
958
959         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
960
961 2009-11-11  Jens Alfke  <snej@chromium.org>
962
963         Reviewed by Dimitri Glazkov.
964
965         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
966
967         * bindings/v8/DOMData.cpp:
968         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
969             so it can be inlined by its caller.
970         * bindings/v8/DOMData.h:
971         * bindings/v8/MainThreadDOMData.cpp:
972         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
973         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
974         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
975             and getStore, which inline both calls together.
976         * bindings/v8/MainThreadDOMData.h:
977         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
978         * bindings/v8/V8DOMMap.cpp:
979         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
980
981 2009-11-11  Nate Chapin  <japhet@chromium.org>
982
983         Reviewed by Dimitri Glazkov.
984
985         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
986
987         https://bugs.webkit.org/show_bug.cgi?id=31357
988
989         * platform/KURLGoogle.cpp:
990         (WebCore::isSchemeFirstChar):
991         (WebCore::isSchemeChar):
992         (WebCore::KURL::hasPort):
993         (WebCore::KURL::removePort):
994         (WebCore::protocolIsValid):
995
996 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
997
998         Build fix, no reviewed.
999
1000         Correct setPlatformFillColor and setPlatformStrokeColor calls
1001         to match new ColorSpace-supporting signatures.
1002
1003         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
1004           color space to the set[...]Color calls.
1005
1006 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1007
1008         Reviewed by Sam Weinig.
1009
1010         https://bugs.webkit.org/show_bug.cgi?id=31327
1011         Clean up SocketStreamHandleClient interface
1012
1013         No change in behavior.
1014
1015         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
1016         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
1017         the only client (WebSocketChannel), and it's not clear what this callback's semantics
1018         should be.
1019         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
1020         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
1021         For ResourceHandle, this method is called when the user cancels authentication sheet,
1022         not when something happens with the stream.
1023
1024         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
1025         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
1026
1027         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
1028         callbacks have no real implementation yet.
1029
1030 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
1031
1032         Reviewed by Eric Seidel.
1033
1034         Allow custom memory allocation control for the part of page directory in WebCore
1035         https://bugs.webkit.org/show_bug.cgi?id=31350
1036
1037         Inherits the following classes from Noncopyable because these are instantiated
1038         by 'new' and these are no need to be copyable:
1039
1040         class DragController         - instantiated at: WebCore/page/Page.cpp:107
1041         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
1042         class Settings               - instantiated at: WebCore/page/Page.cpp:116
1043         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
1044         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
1045         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
1046         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1047         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1048         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
1049
1050         Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
1051         PropertyWrapper is instantiated by 'new' in 
1052         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1053
1054         * page/DragController.h:
1055         * page/EventHandler.h:
1056         * page/FocusController.h:
1057         * page/FrameView.cpp:
1058         * page/PluginHalter.h:
1059         * page/Settings.h:
1060         * page/UserScript.h:
1061         * page/UserStyleSheet.h:
1062         * page/XSSAuditor.h:
1063         * page/animation/AnimationBase.cpp:
1064
1065 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1066
1067         Reviewed by Kenneth Rohde Christiansen.
1068
1069         https://bugs.webkit.org/show_bug.cgi?id=31323
1070         Fix a few compiler warnings
1071
1072         No new tests as there is no new functionality.
1073
1074         * editing/htmlediting.cpp:
1075         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1076         parentheses to silence gcc 4.4 -Wparentheses warnings
1077
1078 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1079
1080         Reviewed by Mark Rowe.
1081
1082         Set m_hasPendingGeometryChange to true by default, so that
1083         at least one call to NPP_SetWindow is executed, which is
1084         needed by the DRT plugin testing framework.
1085
1086         * plugins/PluginView.cpp:
1087         (WebCore::PluginView::PluginView):
1088
1089 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
1090
1091         Rubber-stamped by Kenneth Rohde Christiansen.
1092
1093         https://bugs.webkit.org/show_bug.cgi?id=31348
1094         [Qt] Remove unnecessary LUT creator from WebCore.pro
1095
1096         * WebCore.pro:
1097
1098 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1099
1100         Reviewed by Tor Arne Vestbø.
1101
1102         Introduce a function for querying the input method status
1103         in QWebPageClient.
1104
1105         * platform/qt/QWebPageClient.h:
1106
1107 2009-11-11  Benjamin Otte  <otte@gnome.org>
1108
1109         Reviewed by Jan Alonzo.
1110
1111         [GTK] Black artifacts in youtube.com/html5
1112
1113         Paint the video to the given size. It's the job of the callers to keep
1114         track of aspect ratio. RenderVideo.cpp does it for the <video>
1115         element.
1116         https://bugs.webkit.org/show_bug.cgi?id=30925
1117
1118         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1119         (WebCore::MediaPlayerPrivate::paint):
1120
1121 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1122
1123         Reviewed by Reviewed by Jan Alonzo.
1124
1125         https://bugs.webkit.org/show_bug.cgi?id=30901
1126         [Gtk] Need to de-lint the Atk a11y code
1127
1128         Cleaned up some missed capitalization style-guideline violations.
1129
1130         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1131
1132 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1133
1134         Reviewed by Eric Seidel.
1135
1136         [Qt] Make the default style background color valid.
1137         Currently the color is transparent but invalid, this causes
1138         list boxes in QtWebKit to be drawn with a black background
1139         since r49242.
1140         https://bugs.webkit.org/show_bug.cgi?id=31295
1141
1142         * rendering/style/RenderStyle.h:
1143         (WebCore::InheritedFlags::initialBackgroundColor):
1144         * rendering/style/StyleBackgroundData.cpp:
1145         (WebCore::StyleBackgroundData::StyleBackgroundData):
1146
1147 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1148
1149         Reviewed by Geoff Garen.
1150
1151         Simplify the ownership model for worlds - rather than having a pair of weak references
1152         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1153         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
1154         back forward cache.
1155
1156         * WebCore.base.exp:
1157         * bindings/js/JSDOMBinding.cpp:
1158         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1159         * bindings/js/JSDOMBinding.h:
1160         (WebCore::DOMWrapperWorld::forgetDocument):
1161         * bindings/js/ScriptCachedFrameData.cpp:
1162         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1163         (WebCore::ScriptCachedFrameData::restore):
1164         (WebCore::ScriptCachedFrameData::clear):
1165         * bindings/js/ScriptCachedFrameData.h:
1166         * bindings/js/ScriptController.cpp:
1167         (WebCore::ScriptController::~ScriptController):
1168         (WebCore::ScriptController::clearWindowShell):
1169         (WebCore::ScriptController::initScript):
1170         (WebCore::ScriptController::updateDocument):
1171         * bindings/js/ScriptController.h:
1172
1173 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
1174
1175         Reviewed by Darin Adler.
1176
1177         rename counter to makeCounterNode in RenderCounter.cpp
1178         https://bugs.webkit.org/show_bug.cgi?id=31289
1179
1180         No new test because this is just a small refactoring.
1181
1182         * rendering/RenderCounter.cpp:
1183         (WebCore::findPlaceForCounter):
1184         (WebCore::makeCounterNode):
1185         (WebCore::RenderCounter::originalText):
1186
1187 2009-11-10  Daniel Bates  <dbates@webkit.org>
1188
1189         Reviewed by Oliver Hunt.
1190
1191         https://bugs.webkit.org/show_bug.cgi?id=30754
1192
1193         Patch 2 of 2.
1194
1195         Removed method EventHandler::dragSourceMovedTo, since it is no longer
1196         needed. This method fired a drag event whenever the mouse moved, but
1197         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1198         model independent of when the mouse moves. See "Among other changes..."
1199         in the change log for patch 1 for more details.
1200
1201         * WebCore.DragSupport.exp:
1202         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1203         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1204         * page/EventHandler.h:
1205
1206 2009-11-10  Daniel Bates  <dbates@webkit.org>
1207
1208         Reviewed by Oliver Hunt.
1209
1210         https://bugs.webkit.org/show_bug.cgi?id=30754
1211
1212         Patch 1 of 2.
1213
1214         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1215         the drag event should always fire before the dragover event.
1216
1217         In fixing this bug, this patch also makes our drag processing model
1218         conform to the HTML 5 spec.
1219
1220         Among the changes, this patch ensures that the drag event isn't fired outside
1221         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1222         Currently, the drag event is fired whenever the mouse button is down and the OS
1223         detects the mouse moved. But, as per the spec, the drag event should
1224         fire approx. every 350ms so long as the mouse button is down.
1225
1226         Test: fast/events/drag-and-drop-fire-drag-dragover.html
1227
1228         * page/EventHandler.cpp:
1229         (WebCore::EventHandler::clear):
1230         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1231         Modified to determine when we are in the correct instance of EventHandler to service the drag
1232         and drop operation.
1233         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1234         into this method.
1235         (WebCore::EventHandler::cancelDragAndDrop):
1236         (WebCore::EventHandler::performDragAndDrop):
1237         (WebCore::EventHandler::clearDragState):
1238         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1239         we should fire both drag and dragover events or only the dragover event.
1240
1241 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
1242
1243         Reviewed by Dimitri Glazkov.
1244
1245         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1246         https://bugs.webkit.org/show_bug.cgi?id=31301
1247
1248         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1249
1250         Allowed passing V8Proxy for the calling JS context:
1251         * bindings/v8/V8DOMWrapper.h:
1252         (WebCore::V8DOMWrapper::getXPathNSResolver):
1253         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1254         (WebCore::V8CustomXPathNSResolver::create):
1255         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1256         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1257         * bindings/v8/custom/V8CustomXPathNSResolver.h:
1258         * bindings/v8/custom/V8DocumentCustom.cpp:
1259         (WebCore::CALLBACK_FUNC_DECL):
1260
1261 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
1262
1263         Reviewed by Timothy Hatcher.
1264
1265         Implement URL decomposition IDL attributes for HTMLAnchorElement.
1266         https://bugs.webkit.org/show_bug.cgi?id=29972.
1267
1268         Add methods for setting different parts of the URL in href attribute.
1269
1270         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1271                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1272                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1273                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1274                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1275                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1276                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1277
1278         * bindings/js/JSLocationCustom.cpp:
1279         (WebCore::JSLocation::setPort):
1280         * html/HTMLAnchorElement.cpp:
1281         (WebCore::parsePortFromStringPosition):
1282         (WebCore::HTMLAnchorElement::setHash):
1283         (WebCore::HTMLAnchorElement::setHost):
1284         (WebCore::HTMLAnchorElement::setHostname):
1285         (WebCore::HTMLAnchorElement::setPathname):
1286         (WebCore::HTMLAnchorElement::setPort):
1287         (WebCore::HTMLAnchorElement::setProtocol):
1288         (WebCore::HTMLAnchorElement::setSearch):
1289         * html/HTMLAnchorElement.h:
1290         * html/HTMLAnchorElement.idl:
1291         * loader/FrameLoader.cpp:
1292         (WebCore::FrameLoader::iconURL):
1293         * platform/KURL.cpp:
1294         (WebCore::KURL::removePort):
1295         (WebCore::KURL::setPort):
1296         (WebCore::KURL::prettyURL):
1297         (WebCore::protocolIsValid):
1298         * platform/KURL.h:
1299         (WebCore::KURL::canSetHostOrPort):
1300         (WebCore::KURL::canSetPathname):
1301         (WebCore::KURL::hasPort):
1302         * platform/network/soup/ResourceHandleSoup.cpp:
1303         (WebCore::):
1304
1305 2009-11-10  Nate Chapin  <japhet@chromium.org>
1306
1307         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1308
1309         * platform/chromium/PopupMenuChromium.cpp:
1310         (WebCore::PopupContainer::paintBorder):
1311         (WebCore::PopupListBox::paint):
1312         (WebCore::PopupListBox::paintRow):
1313         * platform/graphics/chromium/TransparencyWin.cpp:
1314         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1315         * platform/graphics/skia/GraphicsContextSkia.cpp:
1316         (WebCore::GraphicsContext::fillRect):
1317         (WebCore::GraphicsContext::fillRoundedRect):
1318         (WebCore::GraphicsContext::setPlatformFillColor):
1319         (WebCore::GraphicsContext::setPlatformStrokeColor):
1320         * rendering/RenderMediaControlsChromium.cpp:
1321         (WebCore::paintMediaSlider):
1322         (WebCore::paintMediaVolumeSlider):
1323         (WebCore::paintMediaTimelineContainer):
1324         * rendering/RenderThemeChromiumMac.mm:
1325         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1326
1327 2009-11-10  Brady Eidson  <beidson@apple.com>
1328
1329         Reviewed by Sam Weinig.
1330
1331         Repro crash saving pcmag.com article as a webarchive.
1332         <rdar://problem/7381219> and https://webkit.org/b/31322
1333
1334         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1335
1336         * css/CSSStyleSheet.cpp:
1337         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1338           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1339
1340 2009-11-10  Beth Dakin  <bdakin@apple.com>
1341
1342         Attempt 2 to fix Tiger build. No review needed.
1343
1344         * platform/graphics/cg/GraphicsContextCG.cpp:
1345         (WebCore::deviceRGBColorSpaceRef):
1346         (WebCore::sRGBColorSpaceRef):
1347
1348 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
1349
1350         wx build fix. Changes needed after r50760.
1351
1352         * platform/graphics/wx/GraphicsContextWx.cpp:
1353         (WebCore::GraphicsContext::GraphicsContext):
1354         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1355         (WebCore::drawTextWithSpacing):
1356
1357 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1358
1359         Qt build fix.
1360
1361         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1362         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1363
1364 2009-11-10  Beth Dakin  <bdakin@apple.com>
1365
1366         Tiger build fix. No review needed.
1367
1368         * platform/graphics/cg/GraphicsContextCG.cpp:
1369         (WebCore::sRGBColorSpaceRef):
1370
1371 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1372
1373         Reviewed by Dan Bernstein.
1374
1375         https://bugs.webkit.org/show_bug.cgi?id=31312
1376         Decouple authentication panel callbacks from ResourceHandle
1377
1378         No change in functionality.
1379
1380         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1381         ResourceHandle as delegate.
1382
1383         * WebCore.vcproj/WebCore.vcproj:
1384         * platform/network/AuthenticationClient.h: Added.
1385         Added a new interface for listening to authentication panel notifications.
1386
1387         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1388         it wants with the project file.
1389
1390         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1391         interface class.
1392         (WebCore::AuthenticationClient::deref): Ditto.
1393
1394         * platform/network/ResourceHandle.h:
1395         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1396         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1397
1398         * platform/network/cf/AuthenticationCF.cpp:
1399         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1400         (WebCore::AuthenticationChallenge::platformCompare):
1401         * platform/network/cf/AuthenticationChallenge.h:
1402         (WebCore::AuthenticationChallenge::authenticationClient):
1403         * platform/network/chromium/AuthenticationChallenge.h:
1404         (WebCore::AuthenticationChallenge::authenticationClient):
1405         * platform/network/curl/AuthenticationChallenge.h:
1406         (WebCore::AuthenticationChallenge::authenticationClient):
1407         Keeping a reference to AuthenticationClient, not to ResourceHandle.
1408
1409 2009-11-10  Beth Dakin  <bdakin@apple.com>
1410
1411        Second attempted gtk build fix. No review needed.
1412
1413         * html/canvas/CanvasStyle.cpp:
1414         (WebCore::CanvasStyle::applyStrokeColor):
1415
1416
1417 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1418
1419         Reviewed by Geoff Garen.
1420
1421         Fix back/forwards cache with JSC isolated worlds.
1422         https://bugs.webkit.org/show_bug.cgi?id=31310
1423         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1424
1425         Store the global object for all worlds, not just the normal world.
1426         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1427         so we can forget global objects if a world goes away.
1428
1429         * bindings/js/JSDOMBinding.cpp:
1430         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1431         * bindings/js/JSDOMBinding.h:
1432         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
1433         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
1434         * bindings/js/ScriptCachedFrameData.cpp:
1435         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1436         (WebCore::ScriptCachedFrameData::forgetWorld):
1437         (WebCore::ScriptCachedFrameData::domWindow):
1438         (WebCore::ScriptCachedFrameData::restore):
1439         (WebCore::ScriptCachedFrameData::clear):
1440         * bindings/js/ScriptCachedFrameData.h:
1441         * bindings/js/ScriptController.h:
1442
1443 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1444
1445         [Qt] Unreviewed buildfix after r50760.
1446
1447         * platform/graphics/qt/GraphicsContextQt.cpp:
1448         (WebCore::GraphicsContext::GraphicsContext):
1449
1450 2009-11-10  Beth Dakin  <bdakin@apple.com>
1451
1452         Attempted build fix. (No review needed.)
1453
1454         * GNUmakefile.am: Adding ColorSpace.h
1455
1456 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
1457
1458         Reviewed by NOBODY - Build Fix.
1459
1460         Updated function calls to take a ColorSpace argument, passing
1461         in DeviceColorSpace for now - this should be fixed. Also added
1462         ColorSpace.h to WebCore project.
1463
1464         * WebCore.vcproj/WebCore.vcproj:
1465         * platform/graphics/win/FontCGWin.cpp:
1466         (WebCore::Font::drawGlyphs):
1467         * platform/graphics/win/GraphicsContextCGWin.cpp:
1468         (WebCore::GraphicsContext::GraphicsContext):
1469         * platform/win/PopupMenuWin.cpp:
1470         (WebCore::PopupMenu::paint):
1471         * platform/win/WebCoreTextRenderer.cpp:
1472         (WebCore::doDrawTextAtPoint):
1473         * rendering/RenderThemeSafari.cpp:
1474         (WebCore::RenderThemeSafari::paintMenuListButton):
1475
1476 2009-11-10  Jens Alfke  <snej@chromium.org>
1477
1478         Reviewed by Darin Adler.
1479
1480         Optimizations to Element::getAttribute
1481         https://bugs.webkit.org/show_bug.cgi?id=30926
1482
1483         * dom/Element.cpp:
1484         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
1485         * dom/NamedAttrMap.cpp:
1486         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
1487         * platform/text/PlatformString.h:
1488         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
1489
1490 2009-11-10  Beth Dakin  <bdakin@apple.com>
1491
1492         Reviewed by Darin Adler.
1493
1494         Fix for <rdar://problem/7059710> 
1495         -and corresponding-
1496         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
1497         color-correction for CSS colors
1498
1499         New exported symbol for GraphicsContext::fillColor() which now 
1500         accepts a ColorSpace as an optional parameter.
1501         * WebCore.base.exp:
1502
1503         Added a new file, ColorSpace.h, to define the ColorSpace enum.
1504         * WebCore.xcodeproj/project.pbxproj:
1505
1506         Computed Style for -webkit-color-correction
1507         * css/CSSComputedStyleDeclaration.cpp:
1508         (WebCore::):
1509         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1510
1511         Parse -webkit-color-correction
1512         * css/CSSParser.cpp:
1513         (WebCore::CSSParser::parseValue):
1514
1515        Map CSS identifiers to the appropriate values of the ColorSpace enum
1516         * css/CSSPrimitiveValueMappings.h:
1517         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1518         (WebCore::CSSPrimitiveValue::operator ColorSpace):
1519
1520         New property -webkit-color-correction
1521         * css/CSSPropertyNames.in:
1522
1523         Map -webkit-color-correction into the RenderStyle.
1524         * css/CSSStyleSelector.cpp:
1525         (WebCore::CSSStyleSelector::applyProperty):
1526
1527         Add new value sRGB.
1528         * css/CSSValueKeywords.in:
1529
1530         Comment out the reference to sRGB since it will now be inherited as 
1531         a value from CSSValueKeywords.
1532         * css/SVGCSSValueKeywords.in:
1533
1534         Definition of the ColorSpace enum.
1535         * platform/graphics/ColorSpace.h: Added.
1536         (WebCore::):
1537
1538         These functions all now take a ColorSpace as a parameter.
1539         * platform/graphics/GraphicsContext.cpp:
1540         (WebCore::GraphicsContext::setStrokeColor):
1541         (WebCore::GraphicsContext::setFillColor):
1542         (WebCore::GraphicsContext::drawHighlightForText):
1543
1544         Return the appropriate ColorSpace.
1545         (WebCore::GraphicsContext::strokeColorSpace):
1546         (WebCore::GraphicsContext::fillColorSpace):
1547
1548         These functions all call other functions which require a ColorSpace 
1549         as a parameter.
1550         (WebCore::GraphicsContext::setStrokePattern):
1551         (WebCore::GraphicsContext::setFillPattern):
1552         (WebCore::GraphicsContext::setStrokeGradient):
1553         (WebCore::GraphicsContext::setFillGradient):
1554
1555         All of the GraphicsContext functions that take a Color should now 
1556         also take a ColorSpace.
1557         * platform/graphics/GraphicsContext.h:
1558
1559         Added new member variables stokeColorSpace and fillColorSpace.
1560         * platform/graphics/GraphicsContextPrivate.h:
1561         (WebCore::GraphicsContextState::GraphicsContextState):
1562
1563         Attempt to keep the Cairo port building with all of the massive 
1564         changes to GraphicsContext.        
1565         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1566         (WebCore::GraphicsContext::fillRect):
1567         (WebCore::GraphicsContext::setPlatformFillColor):
1568         (WebCore::GraphicsContext::setPlatformStrokeColor):
1569         (WebCore::GraphicsContext::fillRoundedRect):
1570
1571         
1572         * platform/graphics/cg/GraphicsContextCG.cpp:
1573         (WebCore::sRGBColorSpaceRef): New static function that returns a 
1574         CGColorSpaceRef for the sRGB color space.
1575         (WebCore::deviceRGBColorSpaceRef): New static function that returns 
1576         a CGColorSpaceRef for the device RGB color space.
1577
1578         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and 
1579         sets the fill color to the specified color in the given ColorSpace.
1580         (WebCore::setCGStrokeColor): Same, but for stroke.
1581
1582         (WebCore::setCGFillColorSpace): New static to set the 
1583         CGFillColorSpace to the given ColorSpace
1584         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
1585
1586         Send ColorSpaces when appropriate, set ColorSpaces when 
1587         appropriate, and check ColorSpaces when appropriate.
1588         (WebCore::GraphicsContext::GraphicsContext):
1589         (WebCore::GraphicsContext::drawRect):
1590         (WebCore::GraphicsContext::drawLine):
1591         (WebCore::GraphicsContext::fillPath):
1592         (WebCore::GraphicsContext::strokePath):
1593         (WebCore::GraphicsContext::fillRect):
1594         (WebCore::GraphicsContext::fillRoundedRect):
1595         (WebCore::GraphicsContext::strokeRect):
1596         (WebCore::GraphicsContext::drawLineForText):
1597         (WebCore::GraphicsContext::setPlatformStrokeColor):
1598         (WebCore::GraphicsContext::setPlatformFillColor):
1599
1600         Attempt to keep Haiku building.
1601         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1602         (WebCore::GraphicsContext::fillRect):
1603         (WebCore::GraphicsContext::fillRoundedRect):
1604         (WebCore::GraphicsContext::setPlatformStrokeColor):
1605         (WebCore::GraphicsContext::setPlatformFillColor):
1606
1607         Attempt to keep QT building.
1608         * platform/graphics/qt/GraphicsContextQt.cpp:
1609         (WebCore::GraphicsContext::fillRect):
1610         (WebCore::GraphicsContext::fillRoundedRect):
1611         (WebCore::GraphicsContext::setPlatformStrokeColor):
1612         (WebCore::GraphicsContext::setPlatformFillColor):
1613
1614         Attempt to keep Wince building.
1615         * platform/graphics/wince/GraphicsContextWince.cpp:
1616         (WebCore::GraphicsContext::fillRect):
1617         (WebCore::GraphicsContext::setPlatformFillColor):
1618         (WebCore::GraphicsContext::setPlatformStrokeColor):
1619         (WebCore::GraphicsContext::clearRect):
1620         (WebCore::GraphicsContext::fillRoundedRect):
1621         (WebCore::GraphicsContext::setPlatformShadow):
1622
1623         Attempt to keep WX building.
1624         * platform/graphics/wx/GraphicsContextWx.cpp:
1625         (WebCore::GraphicsContext::fillRect):
1626         (WebCore::GraphicsContext::fillRoundedRect):
1627         (WebCore::GraphicsContext::setPlatformStrokeColor):
1628         (WebCore::GraphicsContext::setPlatformFillColor):
1629
1630         Added functions colorSpace() and setColorSpace()
1631         * rendering/style/RenderStyle.h:
1632         (WebCore::InheritedFlags::colorSpace):
1633         (WebCore::InheritedFlags::setColorSpace):
1634
1635         The ColorSpace is stored here.
1636         * rendering/style/StyleRareInheritedData.cpp:
1637         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1638         (WebCore::StyleRareInheritedData::operator==):
1639         * rendering/style/StyleRareInheritedData.h:
1640
1641         All of these call sites call GraphicsContext functions which now 
1642         require ColorSpaces.
1643         * editing/SelectionController.cpp:
1644         (WebCore::SelectionController::paintCaret):
1645         * html/canvas/CanvasRenderingContext2D.cpp:
1646         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1647         * html/canvas/CanvasStyle.cpp:
1648         (WebCore::CanvasStyle::applyStrokeColor):
1649         (WebCore::CanvasStyle::applyFillColor):
1650         * inspector/InspectorController.cpp:
1651         (WebCore::drawOutlinedQuad):
1652         * page/FrameView.cpp:
1653         (WebCore::FrameView::paintContents):
1654         * platform/ScrollbarTheme.h:
1655         (WebCore::ScrollbarTheme::paintScrollCorner):
1656         * platform/ScrollbarThemeComposite.cpp:
1657         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
1658         * platform/graphics/Image.cpp:
1659         (WebCore::Image::fillWithSolidColor):
1660         * platform/graphics/mac/FontMac.mm:
1661         (WebCore::Font::drawGlyphs):
1662         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1663         (WebCore::MediaPlayerPrivate::paint):
1664         * rendering/EllipsisBox.cpp:
1665         (WebCore::EllipsisBox::paint):
1666         * rendering/InlineFlowBox.cpp:
1667         (WebCore::InlineFlowBox::paintTextDecorations):
1668         * rendering/InlineTextBox.cpp:
1669         (WebCore::updateGraphicsContext):
1670         (WebCore::paintTextWithShadows):
1671         (WebCore::InlineTextBox::paint):
1672         (WebCore::InlineTextBox::paintSelection):
1673         (WebCore::InlineTextBox::paintCompositionBackground):
1674         (WebCore::InlineTextBox::paintDecoration):
1675         (WebCore::InlineTextBox::paintTextMatchMarker):
1676         (WebCore::InlineTextBox::paintCompositionUnderline):
1677         * rendering/InlineTextBox.h:
1678         * rendering/RenderBlock.cpp:
1679         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1680         (WebCore::RenderBlock::fillVerticalSelectionGap):
1681         (WebCore::RenderBlock::fillLeftSelectionGap):
1682         (WebCore::RenderBlock::fillRightSelectionGap):
1683         * rendering/RenderBoxModelObject.cpp:
1684         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1685         (WebCore::RenderBoxModelObject::paintBoxShadow):
1686         * rendering/RenderFileUploadControl.cpp:
1687         (WebCore::RenderFileUploadControl::paintObject):
1688         * rendering/RenderFrameSet.cpp:
1689         (WebCore::RenderFrameSet::paintColumnBorder):
1690         (WebCore::RenderFrameSet::paintRowBorder):
1691         * rendering/RenderImage.cpp:
1692         (WebCore::RenderImage::paintReplaced):
1693         * rendering/RenderLayer.cpp:
1694         (WebCore::RenderLayer::paintScrollCorner):
1695         (WebCore::RenderLayer::paintResizer):
1696         * rendering/RenderListBox.cpp:
1697         (WebCore::RenderListBox::paintItemForeground):
1698         (WebCore::RenderListBox::paintItemBackground):
1699         * rendering/RenderListMarker.cpp:
1700         (WebCore::RenderListMarker::paint):
1701         * rendering/RenderObject.cpp:
1702         (WebCore::RenderObject::drawLineForBoxSide):
1703         (WebCore::RenderObject::drawArcForBoxSide):
1704         * rendering/RenderReplaced.cpp:
1705         (WebCore::RenderReplaced::paint):
1706         * rendering/RenderScrollbarTheme.cpp:
1707         (WebCore::RenderScrollbarTheme::paintScrollCorner):
1708         * rendering/RenderThemeMac.mm:
1709         (WebCore::RenderThemeMac::paintMenuListButton):
1710         * rendering/RenderView.cpp:
1711         (WebCore::RenderView::paintBoxDecorations):
1712         * rendering/RenderWidget.cpp:
1713         (WebCore::RenderWidget::paint):
1714         * rendering/SVGInlineTextBox.cpp:
1715         (WebCore::SVGInlineTextBox::paintSelection):
1716         * svg/graphics/SVGPaintServerGradient.cpp:
1717         (WebCore::SVGPaintServerGradient::setup):
1718         * svg/graphics/SVGPaintServerSolid.cpp:
1719         (WebCore::SVGPaintServerSolid::setup):
1720
1721 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
1722
1723         Reviewed by Timothy Hatcher.
1724
1725         Web Inspector: Speed up syntax highlighter
1726         https://bugs.webkit.org/show_bug.cgi?id=31291
1727
1728         * inspector/front-end/SourceFrame.js:
1729         (WebInspector.SourceFrame.prototype._loaded):
1730         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
1731         (WebInspector.SourceSyntaxHighlighter.prototype.process):
1732         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
1733         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
1734         (WebInspector.CSSSourceSyntaxHighlighter):
1735         (WebInspector.JavaScriptSourceSyntaxHighlighter):
1736
1737 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
1738
1739         Reviewed by Eric Seidel.
1740
1741         Remove session storage setting
1742         https://bugs.webkit.org/show_bug.cgi?id=31279
1743
1744         Remove session storage from Settings.  It was added temporarily so we could
1745         disable it by default at runtime in Chromium.  We now disable these things in a
1746         different way, so it's time to remove it.  Qt also depended on this setting for
1747         a short period of time, but after talking to them we agreed that it should be
1748         removed.
1749
1750         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
1751
1752         * page/DOMWindow.cpp:
1753         (WebCore::DOMWindow::sessionStorage):
1754         * page/Settings.cpp:
1755         (WebCore::Settings::Settings):
1756         * page/Settings.h:
1757
1758 2009-11-10  Dan Bernstein  <mitz@apple.com>
1759
1760         Reviewed by Eric Carlson and Darin Adler.
1761
1762         WebCore part of making full-screen video pause during scrubbing.
1763
1764         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
1765         and HTMLMediaElement::endScrubbing().
1766
1767 2009-11-10  Anton Muhin  <antonm@chromium.org>
1768
1769         Reviewed by Adam Barth.
1770
1771         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
1772         https://bugs.webkit.org/show_bug.cgi?id=31051
1773
1774         * bindings/v8/V8GCController.cpp:
1775         (WebCore::V8GCController::gcEpilogue):
1776         (WebCore::V8GCController::checkMemoryUsage):
1777         * bindings/v8/V8GCController.h:
1778         * bindings/v8/V8Proxy.cpp:
1779         (WebCore::V8Proxy::evaluate):
1780         (WebCore::V8Proxy::runScript):
1781         (WebCore::V8Proxy::callFunction):
1782
1783 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
1784
1785         Reviewed by Darin Adler.
1786
1787         Allow custom memory allocation control for the part of loader directory in WebCore
1788         https://bugs.webkit.org/show_bug.cgi?id=31161
1789
1790         Inherits the following classes from Noncopyable because these are instantiated
1791         by 'new' and these are no need to be copyable:
1792
1793         class Request - WebCore/loader/loader.cpp:100
1794         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
1795         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
1796         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
1797         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
1798         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
1799
1800         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
1801         MainThreadBridge is instantiated by 'new' in 
1802         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
1803
1804         ThreadableLoaderClient's inheriting has been changed to public.
1805
1806         * loader/ImageLoader.cpp:
1807         * loader/ProgressTracker.cpp:
1808         * loader/RedirectScheduler.cpp:
1809         * loader/Request.h:
1810         * loader/ThreadableLoaderClient.h:
1811         * loader/WorkerThreadableLoader.h:
1812         * loader/appcache/ApplicationCacheHost.h:
1813         * loader/appcache/ApplicationCacheStorage.h:
1814
1815 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1816
1817         Reviewed by Eric Seidel.
1818
1819         https://bugs.webkit.org/show_bug.cgi?id=31047
1820         [GTK] Failing test media/video-played-ranges-1.html
1821
1822         WebKit coding style fixes.
1823
1824         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1825         (WebCore::mediaPlayerPrivateMessageCallback):
1826         (WebCore::MediaPlayerPrivate::naturalSize):
1827         (WebCore::MediaPlayerPrivate::paint):
1828         (WebCore::mimeTypeCache):
1829
1830 2009-11-10  Oliver Hunt  <oliver@apple.com>
1831
1832         Remove build failure introduced by earlier build fix.
1833
1834         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1835
1836 2009-11-10  Oliver Hunt  <oliver@apple.com>
1837
1838         Is this the last build fix? grep tells me yes.
1839
1840         * bindings/v8/custom/V8DocumentCustom.cpp:
1841         (WebCore::CALLBACK_FUNC_DECL):
1842
1843 2009-11-10  Oliver Hunt  <oliver@apple.com>
1844
1845         Hopefully the last one.  Why aren't these autogenerated?
1846
1847         * bindings/v8/V8DOMWrapper.cpp:
1848         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
1849         (WebCore::V8DOMWrapper::getTemplate):
1850         (WebCore::V8DOMWrapper::convertToV8Object):
1851
1852 2009-11-10  Oliver Hunt  <oliver@apple.com>
1853
1854         Another chrome build fix.
1855
1856         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
1857         (WebCore::CALLBACK_FUNC_DECL):
1858
1859 2009-11-10  Oliver Hunt  <oliver@apple.com>
1860
1861         Yet another chrome buildfix
1862
1863         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
1864         (WebCore::CALLBACK_FUNC_DECL):
1865         * bindings/v8/custom/V8WebGLArrayCustom.h:
1866         (WebCore::constructCanvasArray):
1867         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
1868         (WebCore::CALLBACK_FUNC_DECL):
1869         (WebCore::INDEXED_PROPERTY_GETTER):
1870         (WebCore::INDEXED_PROPERTY_SETTER):
1871         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
1872         (WebCore::CALLBACK_FUNC_DECL):
1873         (WebCore::INDEXED_PROPERTY_GETTER):
1874         (WebCore::INDEXED_PROPERTY_SETTER):
1875         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1876         (WebCore::CALLBACK_FUNC_DECL):
1877         (WebCore::INDEXED_PROPERTY_GETTER):
1878         (WebCore::INDEXED_PROPERTY_SETTER):
1879         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
1880         (WebCore::CALLBACK_FUNC_DECL):
1881         (WebCore::vertexAttribAndUniformHelperf):
1882         (WebCore::uniformHelperi):
1883         (WebCore::uniformMatrixHelper):
1884         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
1885         (WebCore::CALLBACK_FUNC_DECL):
1886         (WebCore::INDEXED_PROPERTY_GETTER):
1887         (WebCore::INDEXED_PROPERTY_SETTER):
1888         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
1889         (WebCore::CALLBACK_FUNC_DECL):
1890         (WebCore::INDEXED_PROPERTY_GETTER):
1891         (WebCore::INDEXED_PROPERTY_SETTER):
1892         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
1893         (WebCore::CALLBACK_FUNC_DECL):
1894         (WebCore::INDEXED_PROPERTY_GETTER):
1895         (WebCore::INDEXED_PROPERTY_SETTER):
1896         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
1897         (WebCore::CALLBACK_FUNC_DECL):
1898         (WebCore::INDEXED_PROPERTY_GETTER):
1899         (WebCore::INDEXED_PROPERTY_SETTER):
1900
1901 2009-11-10  Oliver Hunt  <oliver@apple.com>
1902
1903         Chrome build fix.
1904
1905         * bindings/v8/V8Index.h:
1906
1907 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1908
1909         Reviewed by Reviewed by Jan Alonzo.
1910
1911         https://bugs.webkit.org/show_bug.cgi?id=30901
1912         [Gtk] Need to de-lint the Atk a11y code
1913
1914         Removal of various and sundry style-violating nits.
1915
1916         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1917
1918 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1919
1920         Reviewed by Jan Alonzo.
1921
1922         https://bugs.webkit.org/show_bug.cgi?id=31047
1923         [GTK] Failing test media/video-played-ranges-1.html
1924
1925         Fix playback rate setter by remembering the rate was changed. Also
1926         correctly handle reverse playback by doing a seek from end to
1927         beginning of the media.
1928
1929         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1930         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
1931         (WebCore::MediaPlayerPrivate::currentTime):
1932         (WebCore::MediaPlayerPrivate::seek):
1933         (WebCore::MediaPlayerPrivate::hasAudio):
1934         (WebCore::MediaPlayerPrivate::setVolume):
1935         (WebCore::MediaPlayerPrivate::setRate):
1936         (WebCore::MediaPlayerPrivate::updateStates):
1937         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
1938
1939 2009-11-10  Oliver Hunt  <oliver@apple.com>
1940
1941         Reviewed by Maciej Stachowiak.
1942
1943         Rename 3D Canvas related classes to use WebGL prefix
1944         https://bugs.webkit.org/show_bug.cgi?id=29095
1945
1946         Automatic rename of all WebGL related types from Canvas* to
1947         WebGL* per more recent version of the WebGL spec.
1948
1949         Due to the automatic rename I've removed the 600+ line change list.
1950
1951 2009-11-09  Dirk Schulze  <krit@webkit.org>
1952
1953         Reviewed by Oliver Hunt.
1954
1955         SVG feDisplacementMap is not implemented
1956         [https://bugs.webkit.org/show_bug.cgi?id=31255]
1957
1958         This is the implementation of the SVG filter effect
1959         feDisplacementMap. 
1960
1961         Test: svg/filters/feDisplacementMap.svg
1962
1963         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
1964         (WebCore::FEDisplacementMap::apply):
1965
1966 2009-11-09  Kent Tamura  <tkent@chromium.org>
1967
1968         Reviewed by Darin Adler.
1969
1970         Add a comment about null strings and hash functions.
1971         https://bugs.webkit.org/show_bug.cgi?id=29118
1972
1973         * platform/text/StringHash.h:
1974
1975 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1976
1977         Reviewed by Darin Adler.
1978
1979         Compiler warnings in InspectorResource.h
1980         https://bugs.webkit.org/show_bug.cgi?id=29231
1981
1982         Fix compilation warnings by removing addition operation on an enum type.
1983
1984         * inspector/InspectorResource.h:
1985         (WebCore::InspectorResource::):
1986         (WebCore::InspectorResource::Changes::hasChange):
1987         (WebCore::InspectorResource::Changes::set):
1988         (WebCore::InspectorResource::Changes::setAll):
1989
1990 2009-11-09  Anders Carlsson  <andersca@apple.com>
1991
1992         Reviewed by Darin Adler and Dan Bernstein.
1993
1994         <rdar://problem/7328395>
1995         https://bugs.webkit.org/show_bug.cgi?id=31277
1996
1997         When an object tag's style changes (for example when child nodes are added/removed),
1998         reuse its Frame (if it has one) instead of creating multiple Frames.
1999
2000         Test: fast/dom/HTMLObjectElement/children-changed.html
2001
2002         * loader/FrameLoader.cpp:
2003         (WebCore::FrameLoader::requestObject):
2004
2005 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
2006
2007         Reviewed by Kenneth Rohde Christiansen.
2008
2009         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
2010         since adjustment of RW-section base address will be needed for all new symbian
2011         tool chains, specifically for arm and gcc compilation targets.
2012         Also, change target address to 0xE00000 to be sufficient for all targets.
2013
2014         * WebCore.pro:
2015
2016 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
2017
2018         Reviewed by Timothy Hatcher.
2019
2020         Web Inspector: Crash when inspecting
2021         WebCore\manual-tests\inspector\dom-mutation.html
2022
2023         https://bugs.webkit.org/show_bug.cgi?id=31259
2024
2025         * inspector/InspectorDOMAgent.cpp:
2026         (WebCore::InspectorDOMAgent::handleEvent):
2027
2028 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2029
2030         Reviewed by Kenneth Rohde Christiansen.
2031
2032         [Qt] Few classes have virtual functions but non-virtual destructor
2033         https://bugs.webkit.org/show_bug.cgi?id=31269
2034
2035         No new tests as there is no functional change.
2036
2037         * platform/qt/QWebPageClient.h:
2038         (QWebPageClient::~QWebPageClient): Add virtual destructor.
2039
2040 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2041
2042         Reviewed by Kenneth Rohde Christiansen.
2043
2044         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2045         https://bugs.webkit.org/show_bug.cgi?id=31140
2046
2047         QtNetwork interprets null string as request to remove the header, not add it.
2048         Replace null values with empty values before passing them to QtNetwork.
2049
2050         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2051
2052         * platform/network/qt/ResourceRequestQt.cpp:
2053         (WebCore::ResourceRequest::toNetworkRequest):
2054
2055 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
2056
2057         Reviewed by Kevin Ollivier.
2058
2059         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2060         simply ignored before resulting in transparent areas being black in PNG
2061         images for example.
2062         
2063         https://bugs.webkit.org/show_bug.cgi?id=30823
2064
2065         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2066         (WebCore::RGBA32Buffer::asNewNativeImage):
2067
2068 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2069
2070         Reviewed by Kenneth Rohde Christiansen.
2071
2072         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2073         https://bugs.webkit.org/show_bug.cgi?id=31040
2074
2075         No new tests as there is no functional change.
2076
2077         * dom/Document.cpp:
2078         (WebCore::Document::recalcStyleSelector):
2079         * editing/TextIterator.cpp:
2080         (WebCore::pushFullyClippedState):
2081         * editing/VisibleSelection.cpp:
2082         (WebCore::VisibleSelection::appendTrailingWhitespace):
2083         * html/HTMLLinkElement.cpp:
2084         (WebCore::HTMLLinkElement::process):
2085         * loader/RedirectScheduler.cpp:
2086         (WebCore::RedirectScheduler::mustLockBackForwardList):
2087         * loader/appcache/ApplicationCacheGroup.cpp:
2088         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2089         * platform/graphics/qt/FontCacheQt.cpp:
2090         (WebCore::FontPlatformDataCacheKey::computeHash):
2091         * rendering/RenderBlock.cpp:
2092         (WebCore::RenderBlock::handleRunInChild):
2093         * rendering/RenderBox.cpp:
2094         (WebCore::RenderBox::calcHeight):
2095         * rendering/RenderTextControlMultiLine.cpp:
2096         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2097         * rendering/style/RenderStyle.cpp:
2098         (WebCore::RenderStyle::diff):
2099         * svg/SVGAnimateElement.cpp:
2100         (WebCore::parseNumberValueAndUnit):
2101         * svg/SVGAnimationElement.cpp:
2102         (WebCore::SVGAnimationElement::startedActiveInterval):
2103         * svg/SVGPreserveAspectRatio.cpp:
2104         (WebCore::SVGPreserveAspectRatio::getCTM):
2105
2106 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
2107
2108         Reviewed by Dimitri Glazkov.
2109
2110         Win chromium is slow to draw transparent texts
2111         https://bugs.webkit.org/show_bug.cgi?id=31258
2112
2113         Clip graphics context to reduce calculation.
2114
2115         No new tests because this change only affects performance.
2116
2117         * platform/graphics/chromium/FontChromiumWin.cpp:
2118         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2119         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2120
2121 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
2122
2123         Reviewed by Darin Adler.
2124
2125         showTree(CounterNode*) generates too little info and has too many spaces.
2126         https://bugs.webkit.org/show_bug.cgi?id=31212
2127
2128         No new tests as the change has no functional effect it is just for
2129         improved debugging.
2130
2131         * rendering/CounterNode.cpp:
2132         (WebCore::showTreeAndMark):
2133         Changed to also show addresses of parent, next and previous
2134         siblings.
2135
2136 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
2137
2138         Reviewed by Darin Adler.
2139
2140         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2141         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2142
2143         https://bugs.webkit.org/show_bug.cgi?id=31083
2144
2145         No new tests; implementation is unchanged.
2146
2147         * page/Frame.cpp:
2148         (WebCore::Frame::setUseSecureKeyboardEntry):
2149         * page/mac/FrameMac.mm:
2150
2151 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2152
2153         Reviewed by Jan Alonzo.
2154
2155         Make XP_UNIX tests consistent
2156         https://bugs.webkit.org/show_bug.cgi?id=31250
2157
2158         No new tests as there is no functional change.
2159
2160         * plugins/PluginView.cpp:
2161         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2162         instead of the value of the macro
2163
2164         * plugins/gtk/PluginViewGtk.cpp:
2165         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2166         defined instead of using the PLATFORM macro to be consistent
2167         (WebCore::PluginView::getValue): Ditto.
2168
2169 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
2170
2171         Reviewed by Darin Adler.
2172
2173         Thunk to the main thread from ~Database to deref Database's m_document.
2174
2175         If the Database was the Document's last referrer, then ~Document occurs on the
2176         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2177         ASSERT in debug builds.
2178
2179         * storage/Database.cpp:
2180         (WebCore::derefDocument):
2181         (WebCore::Database::~Database):
2182
2183 2009-11-09  Mark Mentovai  <mark@chromium.org>
2184
2185         Reviewed by Dan Bernstein.
2186
2187         Track "can have scrollbar" state within FrameView independently of the
2188         individual scrollbar states in ScrollView.
2189
2190         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2191         REGRESSION (r48064): mint.com loses scrollbars after coming out of
2192         edit mode.
2193
2194         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2195         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2196
2197         Test: fast/overflow/scrollbar-restored.html
2198
2199         * WebCore.base.exp:
2200         * page/FrameView.cpp:
2201         (WebCore::FrameView::FrameView):
2202         (WebCore::FrameView::resetScrollbars):
2203         (WebCore::FrameView::setCanHaveScrollbars):
2204         (WebCore::FrameView::updateCanHaveScrollbars):
2205         (WebCore::FrameView::layout):
2206         * page/FrameView.h:
2207         * platform/ScrollView.h:
2208
2209 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
2210
2211         Reviewed by Timothy Hatcher.
2212
2213         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2214         https://bugs.webkit.org/show_bug.cgi?id=31257
2215
2216         * inspector/front-end/SourceFrame.js:
2217
2218 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
2219
2220         Reviewed by Timothy Hatcher.
2221
2222         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2223         https://bugs.webkit.org/show_bug.cgi?id=31252
2224
2225         Route F1-F12 keypresses in the Console view to the current panel if there is one.
2226
2227         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2228
2229         * inspector/front-end/ConsoleView.js:
2230         (WebInspector.ConsoleView.prototype._promptKeyDown):
2231         * inspector/front-end/utilities.js:
2232         ():
2233         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2234
2235 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2236
2237         Reviewed by Kenneth Rohde Christiansen.
2238
2239         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2240         https://bugs.webkit.org/show_bug.cgi?id=31208
2241
2242         After r42483, the credentials are no longer passed to the network request
2243         in the URL of the request.
2244         Pass the credentials from XMLHTTPRequest to the network request, the same
2245         way that other ports do.
2246
2247         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2248
2249         * platform/network/qt/ResourceHandleQt.cpp:
2250         (WebCore::ResourceHandle::start):
2251         (WebCore::ResourceHandle::loadResourceSynchronously):
2252
2253 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2254
2255         Unreviewed.
2256
2257         https://bugs.webkit.org/show_bug.cgi?id=31161
2258
2259         Roll back r50657 because it breaks the MAC builds.
2260
2261         * loader/ImageLoader.cpp:
2262         * loader/ProgressTracker.cpp:
2263         * loader/RedirectScheduler.cpp:
2264         * loader/Request.h:
2265         * loader/ThreadableLoaderClient.h:
2266         * loader/WorkerThreadableLoader.h:
2267         * loader/appcache/ApplicationCacheHost.h:
2268         * loader/appcache/ApplicationCacheStorage.h:
2269         * loader/icon/IconDatabaseClient.h:
2270
2271 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2272
2273         Reviewed by Darin Adler.
2274
2275         Allow custom memory allocation control for the part of loader directory in WebCore
2276         https://bugs.webkit.org/show_bug.cgi?id=31161
2277
2278         Inherits the following classes from Noncopyable because these are instantiated
2279         by 'new' and these are no need to be copyable:
2280
2281         class Request - WebCore/loader/loader.cpp:100
2282         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2283         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2284         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2285         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2286         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2287         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2288
2289         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
2290         MainThreadBridge is instantiated by 'new' in 
2291         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2292
2293         ThreadableLoaderClient's inheriting has been changed to public.
2294
2295         * loader/ImageLoader.cpp:
2296         * loader/ProgressTracker.cpp:
2297         * loader/RedirectScheduler.cpp:
2298         * loader/Request.h:
2299         * loader/ThreadableLoaderClient.h:
2300         * loader/WorkerThreadableLoader.h:
2301         * loader/appcache/ApplicationCacheHost.h:
2302         * loader/appcache/ApplicationCacheStorage.h:
2303         * loader/icon/IconDatabaseClient.h:
2304
2305 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2306
2307         Reviewed by Darin Adler.
2308
2309         Allow custom memory allocation control for WebCore's DocLoader
2310         https://bugs.webkit.org/show_bug.cgi?id=31163
2311
2312         Inherits DocLoader class from Noncopyable because it is
2313         instantiated by 'new' in WebCore/dom/Document.cpp:370 and 
2314         it is no need to be copyable.
2315
2316         * loader/DocLoader.h:
2317
2318 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2319
2320         Reviewed by Darin Adler.
2321
2322         Allow custom memory allocation control for WebCore's Tokenizer
2323         https://bugs.webkit.org/show_bug.cgi?id=31162
2324
2325         Inherits Tokenizer class from Noncopyable because (its child class)
2326         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178 
2327         and it is no need to be copyable.
2328
2329         * dom/Tokenizer.h:
2330
2331 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2332
2333         Reviewed by Darin Adler.
2334
2335         Allow custom memory allocation control for WebCore's DeleteButtonController
2336         https://bugs.webkit.org/show_bug.cgi?id=31105
2337
2338         Inherits DeleteButtonController class from Noncopyable because it is 
2339         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2340         it is no need to be copyable.  
2341
2342         * editing/DeleteButtonController.h:
2343
2344 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2345
2346         Reviewed by Jan Alonzo.
2347
2348         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2349         https://bugs.webkit.org/show_bug.cgi?id=30482
2350
2351         Expose Page::tabKeyCyclesThroughElements as a property of
2352         WebKitWebView.
2353
2354         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2355
2356         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2357         (WebCore::singleCharacterString):
2358
2359 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2360
2361         Reviewed by Xan Lopez.
2362
2363         https://bugs.webkit.org/show_bug.cgi?id=25415
2364         [GTK][ATK] Please implement support for get_text_at_offset
2365
2366         Fix a crasher that occurred with text which included newline
2367         chars in the markup.
2368
2369         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2370         (convertUniCharToUTF8):
2371
2372 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
2373
2374         Reviewed by Holger Freyther.
2375
2376         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2377         https://bugs.webkit.org/show_bug.cgi?id=31144
2378
2379         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2380         documents that end prematurely but are not considered invalid by QXmlStream.
2381         This is to stay compatible with the libxml2 implementation.
2382         However, that code path would be also hit in situations when it should not,
2383         i.e. the error would have already been caught and handled. As a result, the
2384         same error would be reported twice.
2385
2386         No new tests, because the problem is already covered by
2387         fast/parser/xml-declaration-missing-ending-mark.html.
2388
2389         * dom/XMLTokenizerQt.cpp:
2390         (WebCore::XMLTokenizer::doEnd):
2391
2392 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
2393
2394         Reviewed by Pavel Feldman.
2395
2396         Web Inspector: Inspector should support copy() in the command line
2397         https://bugs.webkit.org/show_bug.cgi?id=31238
2398
2399         * inspector/InspectorBackend.cpp:
2400         (WebCore::InspectorBackend::copyText): Added.
2401         * inspector/InspectorBackend.h: Added copyText
2402         * inspector/InspectorBackend.idl: Added copyText
2403         * inspector/front-end/InjectedScript.js:
2404         (InjectedScript._copy): Added.
2405         (InjectedScript._ensureCommandLineAPIInstalled):
2406
2407 2009-11-08  Drew Wilson  <atwilson@chromium.org>
2408
2409         Reviewed by Dimitri Glazkov.
2410
2411         V8 WorkerContextExecutionProxy does not handle SharedWorkers
2412         https://bugs.webkit.org/show_bug.cgi?id=31226
2413
2414         Now checks to see what type of context is active and creates the
2415         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2416
2417         Added support for converting to SharedWorkers and SharedWorkerContexts.
2418
2419         Test: Existing layout tests cover this case (start passing in Chrome).
2420
2421         * bindings/v8/WorkerContextExecutionProxy.cpp:
2422         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2423         Now generates the right type of DOMWrapper for SharedWorkerContexts.
2424         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2425         Added support for SHAREDWORKERCONTEXT.
2426         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2427         Added support for SharedWorker and SharedWorkerContext.
2428
2429 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
2430
2431         Reviewed by Dimitri Glazkov.
2432
2433         https://bugs.webkit.org/show_bug.cgi?id=31224
2434         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
2435
2436         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
2437
2438         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2439         (WebCore::NAMED_PROPERTY_GETTER):
2440
2441 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2442
2443         Reviewed by Timothy Hatcher.
2444
2445         Web Inspector: "Search again" on scripts panel switches
2446         to the script this search started with.
2447
2448         https://bugs.webkit.org/show_bug.cgi?id=31243
2449
2450         * inspector/front-end/Panel.js:
2451         (WebInspector.Panel.prototype.jumpToNextSearchResult):
2452
2453 2009-11-08  Kent Tamura  <tkent@chromium.org>
2454
2455         Reviewed by Darin Adler.
2456
2457         Simplify Icon interface.
2458         https://bugs.webkit.org/show_bug.cgi?id=31154
2459
2460         - Remove Icon::createIconForFile().  createIconForFiles() covers
2461           createIconForFile()'s role.
2462         - Remove FileChooser::chooseIcon()
2463         - Change the parameter types of FileChooser constructor and the
2464           factory method, String -> const Vector<String>&, in order to
2465           support initialization with multiple files.
2466         - Remove the icon loading code in IconChromiumWin.cpp, which
2467           doesn't work because of the sandbox.
2468
2469         No tests because it's just a refactoring.
2470
2471         * platform/FileChooser.cpp:
2472         (WebCore::FileChooser::FileChooser):
2473         (WebCore::FileChooser::create):
2474         (WebCore::FileChooser::chooseFile):
2475         (WebCore::FileChooser::chooseFiles):
2476         * platform/FileChooser.h:
2477         * platform/graphics/Icon.h:
2478         * platform/graphics/chromium/IconChromiumLinux.cpp:
2479         * platform/graphics/chromium/IconChromiumMac.cpp:
2480         * platform/graphics/chromium/IconChromiumWin.cpp:
2481         (WebCore::Icon::createIconForFiles):
2482         * platform/graphics/gtk/IconGtk.cpp:
2483         (WebCore::Icon::createIconForFiles):
2484         * platform/graphics/haiku/IconHaiku.cpp:
2485         * platform/graphics/mac/IconMac.mm:
2486         (WebCore::Icon::createIconForFiles):
2487         * platform/graphics/qt/IconQt.cpp:
2488         (WebCore::Icon::createIconForFiles):
2489         * platform/graphics/win/IconWin.cpp:
2490         (WebCore::Icon::createIconForFiles):
2491         * platform/graphics/wx/IconWx.cpp:
2492         * rendering/RenderFileUploadControl.cpp:
2493         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2494
2495 2009-11-08  Daniel Bates  <dbates@webkit.org>
2496
2497         Reviewed by Adam Barth.
2498
2499         https://bugs.webkit.org/show_bug.cgi?id=31098
2500
2501         Allows same-origin plugin-based content to load.
2502
2503         Test: http/tests/security/xssAuditor/object-src-inject.html
2504
2505         * page/XSSAuditor.cpp:
2506         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
2507         (WebCore::XSSAuditor::canLoadObject): Ditto.
2508         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 
2509         (WebCore::XSSAuditor::isSameOriginResource): Added.
2510         * page/XSSAuditor.h:
2511
2512 2009-11-08  David Levin  <levin@chromium.org>
2513
2514         Reviewed by NOBODY (chromium build fix).
2515
2516         * platform/network/HTTPParsers.cpp:
2517         (WebCore::parseDate): Changed this to not
2518         use a date parser that needs ExecState passed.
2519         
2520 2009-11-08  David Levin  <levin@chromium.org>
2521
2522         Unreviewed build fix for chromium.
2523
2524         * platform/graphics/skia/GraphicsContextSkia.cpp:
2525         (WebCore::GraphicsContext::fillPath):
2526         (WebCore::GraphicsContext::fillRect):
2527         (WebCore::GraphicsContext::strokePath):
2528         (WebCore::GraphicsContext::strokeRect):
2529
2530 2009-11-08  David Levin  <levin@chromium.org>
2531
2532         Unreviewed build fix for chromium.
2533
2534         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
2535         Clean up GraphicsContext's current concept of ColorSpace
2536
2537         * platform/graphics/skia/GraphicsContextSkia.cpp:
2538         (WebCore::GraphicsContext::fillPath):
2539         (WebCore::GraphicsContext::fillRect):
2540         (WebCore::GraphicsContext::strokePath):
2541         (WebCore::GraphicsContext::strokeRect):
2542
2543 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2544
2545         Reviewed by Timothy Hatcher.
2546
2547         Web Inspector: [REGRESSION] committing style edit
2548         clears elements panel selection.
2549
2550         https://bugs.webkit.org/show_bug.cgi?id=31242
2551
2552         * inspector/front-end/ElementsTreeOutline.js:
2553         (WebInspector.ElementsTreeOutline.prototype.update):
2554         * inspector/front-end/StylesSidebarPane.js:
2555         (WebInspector.StylePropertyTreeElement.prototype.):
2556         (WebInspector.StylePropertyTreeElement.prototype):
2557
2558 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
2559
2560         Reviewed by Holger Freyther.
2561
2562         ResourceRequest to be class instead of struct
2563         https://bugs.webkit.org/show_bug.cgi?id=30670
2564
2565         Started as a compilation fix for Symbian where the compiler makes a distinction between
2566         class and struct in function argument signatures.
2567         Changed all forward declarations of ResourceRequest to have class in the forward
2568         declaration instead of struct and changed the definition of ResourceRequest to be class
2569         and added access qualifiers where missing. Additionally two references of friend
2570         struct ResourceRequestBase changed to class instead.
2571
2572         * history/HistoryItem.h:
2573         * inspector/InspectorController.h:
2574         * inspector/InspectorResource.h:
2575         * loader/DocumentThreadableLoader.h:
2576         * loader/FrameLoaderClient.h:
2577         * loader/MainResourceLoader.h:
2578         * loader/ResourceLoadNotifier.h:
2579         * loader/SubresourceLoader.h:
2580         * loader/SubresourceLoaderClient.h:
2581         * loader/ThreadableLoader.h:
2582         * loader/WorkerThreadableLoader.h:
2583         * loader/appcache/ApplicationCache.h:
2584         * loader/appcache/ApplicationCacheHost.h:
2585         * platform/CrossThreadCopier.h:
2586         * platform/network/ResourceHandle.h:
2587         * platform/network/ResourceHandleClient.h:
2588         * platform/network/ResourceRequestBase.h:
2589         * platform/network/cf/ResourceRequest.h:
2590         * platform/network/cf/ResourceRequestCFNet.h:
2591         * platform/network/chromium/ResourceRequest.h:
2592         * platform/network/curl/ResourceRequest.h:
2593         * platform/network/qt/ResourceRequest.h:
2594         * platform/network/soup/ResourceRequest.h:
2595         * xml/XMLHttpRequest.h:
2596
2597 2009-11-08  Dan Bernstein  <mitz@apple.com>
2598
2599         Reviewed by Simon Fraser.
2600
2601         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
2602         below FrameView::layout
2603         https://bugs.webkit.org/show_bug.cgi?id=31093
2604
2605         Test: fast/block/positioning/relative-positioned-inline-container.html
2606
2607         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
2608         to mark the object for layout, doing so without marking its ancestors.
2609         However, RenderBlock::skipLeadingWhitespace and
2610         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
2611         positioned inline container, causing it to be marked for layout without
2612         ever going back to give it layout, and thus layout could end with a
2613         dirty object still in the tree, leading to all sorts of badness.
2614
2615         The fix is to revert setStaticY() to not marking the object dirty, and
2616         instead do it in the call sites that require it, which are in
2617         RenderBlock and RenderFlexibleBox.
2618
2619         * rendering/RenderBlock.cpp:
2620         (WebCore::RenderBlock::adjustPositionedBlock):
2621         * rendering/RenderFlexibleBox.cpp:
2622         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2623         (WebCore::RenderFlexibleBox::layoutVerticalBox):
2624         * rendering/RenderLayer.cpp:
2625         * rendering/RenderLayer.h:
2626         (WebCore::RenderLayer::setStaticY):
2627
2628 2009-11-07  Daniel Bates  <dbates@webkit.org>
2629
2630         Reviewed by Darin Adler.
2631
2632         https://bugs.webkit.org/show_bug.cgi?id=20780
2633         
2634         Fixes an issue where the onchange event handler is not fired when the 
2635         input field is autocompleted.
2636         
2637         We cannot test this using DRT since DRT cannot emulate autocompletion.
2638         So, a manual-test is included.
2639
2640         Tests: manual-tests/autocompletion-fire-onchange.html
2641
2642         * manual-tests/autocompletion-fire-onchange.html: Added.
2643         * rendering/RenderTextControl.cpp:
2644         (WebCore::RenderTextControl::setInnerTextValue):
2645
2646 2009-11-07  Benjamin Otte  <otte@gnome.org>
2647
2648         Reviewed by Holger Freyther.
2649
2650         Mark redrawn areas on image surfaces as dirty.
2651
2652         This is required to conform to the Cairo API, but is currently only
2653         used by debugging tools like cairo-trace.
2654
2655         * platform/graphics/cairo/ImageBufferCairo.cpp:
2656         (WebCore::ImageBuffer::platformTransformColorSpace):
2657         (WebCore::putImageData):
2658
2659 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2660
2661         Reviewed by Xan Lopez.
2662
2663         https://bugs.webkit.org/show_bug.cgi?id=30878
2664         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
2665
2666         If the end_offset is -1, use the String length as the end_offset.
2667
2668         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2669         (webkit_accessible_text_get_text):
2670
2671 2009-11-06  Beth Dakin  <bdakin@apple.com>
2672
2673         Reviewed by Adele Peterson.
2674
2675         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up 
2676         GraphicsContext's current concept of ColorSpace
2677
2678         ColorSpace is now called ColorType. The variables on the state we 
2679         appropriately re-named as well. I removed strokeColorSpace() and 
2680         fillColorSpace() from GraphicsContext since they were never called. 
2681
2682         * platform/graphics/GraphicsContext.cpp:
2683         (WebCore::GraphicsContext::setStrokeColor):
2684         (WebCore::GraphicsContext::setFillColor):
2685         (WebCore::GraphicsContext::setStrokePattern):
2686         (WebCore::GraphicsContext::setFillPattern):
2687         (WebCore::GraphicsContext::setStrokeGradient):
2688         (WebCore::GraphicsContext::setFillGradient):
2689         * platform/graphics/GraphicsContext.h:
2690         (WebCore::):
2691         * platform/graphics/GraphicsContextPrivate.h:
2692         (WebCore::GraphicsContextState::GraphicsContextState):
2693         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2694         (WebCore::GraphicsContext::fillPath):
2695         (WebCore::GraphicsContext::strokePath):
2696         * platform/graphics/cg/GraphicsContextCG.cpp:
2697         (WebCore::calculateDrawingMode):
2698         (WebCore::GraphicsContext::drawPath):
2699         (WebCore::GraphicsContext::fillPath):
2700         (WebCore::GraphicsContext::strokePath):
2701         (WebCore::GraphicsContext::fillRect):
2702         (WebCore::GraphicsContext::strokeRect):
2703         * platform/graphics/qt/GraphicsContextQt.cpp:
2704         (WebCore::GraphicsContext::fillPath):
2705         (WebCore::GraphicsContext::strokePath):
2706         (WebCore::GraphicsContext::fillRect):
2707         * platform/graphics/wince/GraphicsContextWince.cpp:
2708         (WebCore::GraphicsContext::fillPath):
2709         (WebCore::GraphicsContext::fillRect):
2710
2711 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
2712
2713         Reviewed by Tim Hatcher.
2714
2715         Fixes <http://webkit.org/b/31177>.
2716         Web Inspector: Bind backspace to delete cookies and DOM Storage.
2717         
2718         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
2719         places in the inspector can use editing in DataGrid (added a FIXME for
2720         some stuff that needs to be generalized).
2721         
2722         Also added deleting functionality to DataGrid, and implemented it for
2723         Cookies and DOM Storage. The reason this patch is so big is because of
2724         the refactoring of editing code, which won't be used yet in a cross-datagrid
2725         way, but should be able to.
2726         
2727         Additionally, moved the callbacks members from DOMStorageDataGrid to
2728         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to 
2729         make the architecture of DOM Storage look a lot more like the Cookies view.
2730         
2731         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the 
2732         inspector from beeping at you when you delete an element.
2733
2734         * WebCore.gypi: Removed DOMStorageDataGrid.
2735         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
2736         * inspector/front-end/CookieItemsView.js:
2737         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
2738         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
2739         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2740         * inspector/front-end/DOMStorageDataGrid.js: Removed.
2741         * inspector/front-end/DOMStorageItemsView.js:
2742         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2743         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
2744         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
2745         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
2746         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
2747         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
2748         * inspector/front-end/DataGrid.js:
2749         (WebInspector.DataGrid):
2750         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
2751         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
2752         (WebInspector.DataGrid.prototype._startEditing): Ditto.
2753         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
2754         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
2755         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
2756         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
2757         * inspector/front-end/ElementsTreeOutline.js:
2758         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
2759         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
2760         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
2761
2762 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2763
2764         Qt build fix: added an ExecState parameter.
2765
2766         * bridge/qt/qt_runtime.cpp:
2767         (JSC::Bindings::convertValueToQVariant):
2768         (JSC::Bindings::convertQVariantToValue):
2769
2770 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2771
2772         https://bugs.webkit.org/show_bug.cgi?id=31197
2773         Implemented a timezone cache not based on Mac OS X's notify_check API.
2774
2775         Updated for JavaScriptCore internal API change.
2776
2777         * bridge/qt/qt_runtime.cpp:
2778         (JSC::Bindings::convertValueToQVariant):
2779         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
2780
2781         * platform/network/HTTPParsers.cpp:
2782         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
2783         (This function probably shouldn't be using a JavaScript date parser
2784         to begin with, but oh well.)
2785
2786 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2787
2788         Reviewed by Adam Barth.
2789
2790         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
2791         which affects Chromium only.
2792         
2793         Changes to V8HTMLDocumentCustom.cpp are as below:-
2794         1. The HTMLDocumentOpen function would cause a crash in Chromium if
2795            there was no calling javascript context. We now check for this case
2796            and pass in NULL to the HTMLDocument::open function which can handle
2797            a NULL document parameter.
2798         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
2799            had ASSERTS for a NULL caller frame, which was bogus as it would crash
2800            anyway. We now check for this case and return a failure.
2801            
2802         Changes to V8DOMWindowCustom.cpp are as below:-
2803         1. Instead of failing the window.open call made by NPAPI for lack of a
2804            calling javascript context, we now use the entered context as the calling
2805            context.
2806
2807         Tests: plugins/document-open.html
2808                plugins/window-open.html
2809
2810         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2811         (WebCore::CALLBACK_FUNC_DECL):
2812         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
2813         (WebCore::CALLBACK_FUNC_DECL):
2814
2815 2009-11-06  Steve Block  <steveblock@google.com>
2816
2817         Reviewed by Eric Seidel.
2818
2819         Geolocation error code UNKNOWN_ERROR is deprecated.
2820         https://bugs.webkit.org/show_bug.cgi?id=31184
2821
2822         Remove this error code from PositionError, both for use from C++ code and from the JS object.
2823
2824         Updated fast/dom/Geolocation/error.html to test this.
2825
2826         * page/PositionError.h: Modified.
2827         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
2828         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
2829         * page/Geolocation.cpp: Modified.
2830         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2831         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
2832         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2833
2834 2009-11-06  Dirk Schulze  <krit@webkit.org>
2835
2836         Reviewed by Nikolas Zimmermann.
2837
2838         feMorphology filter is not implemented
2839         [https://bugs.webkit.org/show_bug.cgi?id=5863]
2840
2841         The Implementation of feMorphology.
2842         
2843         Test: We have allready a test for feMorphology
2844               svg/W3C-SVG-1.1/filters-morph-01-f.svg
2845
2846         * svg/graphics/filters/SVGFEMorphology.cpp:
2847         (WebCore::FEMorphology::apply):
2848
2849 2009-11-06  Steve Block  <steveblock@google.com>
2850
2851         Reviewed by Eric Seidel.
2852
2853         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
2854         https://bugs.webkit.org/show_bug.cgi?id=31209
2855
2856         Build fix only. No new tests possible.
2857
2858         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
2859
2860 2009-11-06  Drew Wilson  <atwilson@chromium.org>
2861
2862         Reviewed by David Levin.
2863
2864         V8 bindings do not support SharedWorkers as event targets
2865         https://bugs.webkit.org/show_bug.cgi?id=31199
2866
2867         No new tests because existing layout tests suffice (they currently
2868         crash on Chromium)
2869
2870         * bindings/v8/V8DOMWrapper.cpp:
2871         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
2872         Added clause to create a DOM wrapper for SharedWorkers.
2873
2874 2009-11-06  Anton Muhin  <antonm@chromium.org>
2875
2876         Reviewed by Adam Barth.
2877
2878         Do not unnecessarly synchronzie in weak reference callbacks.
2879         https://bugs.webkit.org/show_bug.cgi?id=31191
2880
2881         * bindings/v8/DOMData.h:
2882         (WebCore::DOMData::handleWeakObject):
2883
2884 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
2885
2886         Reviewed by Pavel Feldman.
2887
2888         Fix resource content search.
2889         https://bugs.webkit.org/show_bug.cgi?id=31202
2890
2891         * inspector/front-end/AbstractTimelinePanel.js:
2892         (WebInspector.AbstractTimelinePanel.prototype.refresh):
2893         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
2894         * inspector/front-end/TimelinePanel.js:
2895         (WebInspector.TimelineGraph.prototype.refresh):
2896
2897 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
2898
2899         Reviewed by Eric Seidel.
2900
2901         Fix ASSERT(currentStyle = renderStyle()).
2902         https://bugs.webkit.org/show_bug.cgi?id=31152
2903
2904         * dom/Element.cpp:
2905         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
2906
2907 2009-11-05  Alpha Lam  <hclam@chromium.org>
2908
2909         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
2910
2911         * bindings/v8/V8GCController.cpp:
2912         (WebCore::V8GCController::gcEpilogue):
2913         * bindings/v8/V8GCController.h:
2914         * bindings/v8/V8Proxy.cpp:
2915         (WebCore::V8Proxy::evaluate):
2916         (WebCore::V8Proxy::runScript):
2917         (WebCore::V8Proxy::callFunction):
2918
2919 2009-11-05  Adam Barth  <abarth@webkit.org>
2920
2921         Reviewed by Sam Weinig.
2922
2923         Cross-domain access to stylesheet text should not be allowed
2924         https://bugs.webkit.org/show_bug.cgi?id=20527
2925
2926         Check whether whether the current document can read the cssRules from
2927         the style sheet.  Firefox throws a security error here, but we return
2928         null instead because that's what we usually do in these cases.
2929
2930         Test: http/tests/security/cannot-read-cssrules-redirect.html
2931               http/tests/security/cannot-read-cssrules.html
2932
2933         * css/CSSStyleSheet.cpp:
2934         (WebCore::CSSStyleSheet::cssRules):
2935
2936 2009-11-05  Steve Block  <steveblock@google.com>
2937
2938         Reviewed by Eric Seidel.
2939
2940         If the Geolocation service fails to start, invoke the error callback asynchronously.
2941         https://bugs.webkit.org/show_bug.cgi?id=28276
2942
2943         All Geolocation callbacks must be invoked asynchronously.
2944         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
2945
2946         No new tests possible with current LayoutTestController.
2947
2948         * page/Geolocation.cpp:
2949         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
2950         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
2951         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
2952
2953 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2954
2955         Reviewed by Eric Seidel.
2956
2957         Removed the "this is part of the KDE project" comments from 
2958         all *.h, *.cpp, *.idl, and *.pm files.
2959         
2960         https://bugs.webkit.org/show_bug.cgi?id=31167
2961         
2962         The maintenance and architecture page in the project wiki lists
2963         this as a task.
2964         
2965         This change includes no changes or additions to test cases 
2966         since the change affects only comments.
2967
2968         * bindings/scripts/CodeGeneratorV8.pm:
2969         * bindings/scripts/IDLParser.pm:
2970         * bindings/scripts/IDLStructure.pm:
2971         * css/CSSInheritedValue.cpp:
2972         * css/CSSInitialValue.cpp:
2973         * css/CSSMediaRule.cpp:
2974         * css/CSSNamespace.h:
2975         * css/CSSProperty.cpp:
2976         * css/CSSProperty.h:
2977         * css/CSSRuleList.cpp:
2978         * css/CSSRuleList.h:
2979         * css/CSSSelector.h:
2980         * css/CSSValueList.cpp:
2981         * css/FontValue.cpp:
2982         * css/MediaFeatureNames.cpp:
2983         * css/MediaFeatureNames.h:
2984         * css/Pair.h:
2985         * css/SVGCSSStyleSelector.cpp:
2986         * css/ShadowValue.cpp:
2987         * css/StyleSheet.cpp:
2988         * css/StyleSheetList.cpp:
2989         * css/maketokenizer:
2990         * dom/BeforeUnloadEvent.cpp:
2991         * dom/BeforeUnloadEvent.h:
2992         * dom/CSSMappedAttributeDeclaration.cpp:
2993         * dom/EventNames.cpp:
2994         * dom/EventTarget.cpp:
2995         * dom/MappedAttributeEntry.h:
2996         * dom/MouseRelatedEvent.h:
2997         * dom/RangeException.h:
2998         * dom/StyleElement.h:
2999         * dom/Tokenizer.h:
3000         * html/HTMLHeadElement.h:
3001         * html/HTMLHeadingElement.cpp:
3002         * html/HTMLHeadingElement.h:
3003         * html/HTMLHtmlElement.h:
3004         * html/HTMLImageLoader.h:
3005         * html/HTMLMetaElement.h:
3006         * html/HTMLModElement.cpp:
3007         * html/HTMLModElement.h:
3008         * html/HTMLOptionsCollection.cpp:
3009         * html/HTMLPlugInElement.cpp:
3010         * html/HTMLPreElement.cpp:
3011         * html/HTMLPreElement.h:
3012         * html/HTMLTableCellElement.cpp:
3013         * html/HTMLTableCellElement.h:
3014         * html/HTMLTableColElement.cpp:
3015         * html/HTMLTableColElement.h:
3016         * html/HTMLTablePartElement.cpp:
3017         * html/HTMLTablePartElement.h:
3018         * html/HTMLTitleElement.h:
3019         * page/MouseEventWithHitTestResults.h:
3020         * platform/StaticConstructors.h:
3021         * platform/text/AtomicStringImpl.h:
3022         * platform/text/qt/TextBreakIteratorQt.cpp:
3023         * rendering/AutoTableLayout.h:
3024         * rendering/CounterNode.cpp:
3025         * rendering/EllipsisBox.cpp:
3026         * rendering/EllipsisBox.h:
3027         * rendering/FixedTableLayout.cpp:
3028         * rendering/FixedTableLayout.h:
3029         * rendering/HitTestRequest.h:
3030         * rendering/HitTestResult.h:
3031         * rendering/InlineRunBox.h:
3032         * rendering/PointerEventsHitRules.cpp:
3033         * rendering/PointerEventsHitRules.h:
3034         * rendering/RenderBR.cpp:
3035         * rendering/RenderBR.h:
3036         * rendering/RenderButton.cpp:
3037         * rendering/RenderButton.h:
3038         * rendering/RenderFieldset.cpp:
3039         * rendering/RenderFrameSet.cpp:
3040         * rendering/RenderListItem.cpp:
3041         * rendering/RenderTableRow.cpp:
3042         * rendering/RenderView.h:
3043         * rendering/RootInlineBox.h:
3044         * rendering/SVGInlineTextBox.cpp:
3045         * rendering/SVGInlineTextBox.h:
3046         * rendering/TableLayout.h:
3047         * rendering/break_lines.h:
3048         * rendering/style/SVGRenderStyle.cpp:
3049         * rendering/style/SVGRenderStyle.h:
3050         * rendering/style/SVGRenderStyleDefs.cpp:
3051         * rendering/style/SVGRenderStyleDefs.h:
3052         * svg/GradientAttributes.h:
3053         * svg/LinearGradientAttributes.h:
3054         * svg/PatternAttributes.h:
3055         * svg/RadialGradientAttributes.h:
3056         * svg/SVGAElement.cpp:
3057         * svg/SVGAngle.idl:
3058         * svg/SVGAnimateColorElement.cpp:
3059         * svg/SVGAnimateColorElement.h:
3060         * svg/SVGAnimateElement.cpp:
3061         * svg/SVGAnimateElement.h:
3062         * svg/SVGAnimateTransformElement.h:
3063         * svg/SVGAnimatedPathData.cpp:
3064         * svg/SVGAnimatedPathData.h:
3065         * svg/SVGAnimatedPoints.cpp:
3066         * svg/SVGAnimatedPoints.h:
3067         * svg/SVGAnimationElement.cpp:
3068         * svg/SVGCircleElement.cpp:
3069         * svg/SVGClipPathElement.cpp:
3070         * svg/SVGColor.cpp:
3071         * svg/SVGColor.idl:
3072         * svg/SVGComponentTransferFunctionElement.cpp:
3073         * svg/SVGComponentTransferFunctionElement.h:
3074         * svg/SVGCursorElement.cpp:
3075         * svg/SVGDefsElement.cpp:
3076         * svg/SVGDescElement.cpp:
3077         * svg/SVGDescElement.h:
3078         * svg/SVGDocument.idl:
3079         * svg/SVGElement.idl:
3080         * svg/SVGElementInstanceList.cpp:
3081         * svg/SVGElementInstanceList.h:
3082         * svg/SVGEllipseElement.cpp:
3083         * svg/SVGExternalResourcesRequired.cpp:
3084         * svg/SVGFEBlendElement.cpp:
3085         * svg/SVGFEBlendElement.h:
3086         * svg/SVGFEColorMatrixElement.cpp:
3087         * svg/SVGFEColorMatrixElement.h:
3088         * svg/SVGFEComponentTransferElement.cpp:
3089         * svg/SVGFEComponentTransferElement.h:
3090         * svg/SVGFECompositeElement.cpp:
3091         * svg/SVGFECompositeElement.h:
3092         * svg/SVGFEFloodElement.cpp:
3093         * svg/SVGFEFloodElement.h:
3094         * svg/SVGFEFuncAElement.cpp:
3095         * svg/SVGFEFuncAElement.h:
3096         * svg/SVGFEFuncBElement.cpp:
3097         * svg/SVGFEFuncBElement.h:
3098         * svg/SVGFEFuncGElement.cpp:
3099         * svg/SVGFEFuncGElement.h:
3100         * svg/SVGFEFuncRElement.cpp:
3101         * svg/SVGFEFuncRElement.h:
3102         * svg/SVGFEGaussianBlurElement.cpp:
3103         * svg/SVGFEGaussianBlurElement.h:
3104         * svg/SVGFEImageElement.cpp:
3105         * svg/SVGFEMergeElement.cpp:
3106         * svg/SVGFEMergeElement.h:
3107         * svg/SVGFEMergeNodeElement.cpp:
3108         * svg/SVGFEOffsetElement.cpp:
3109         * svg/SVGFEOffsetElement.h:
3110         * svg/SVGFETileElement.cpp:
3111         * svg/SVGFETileElement.h:
3112         * svg/SVGFETurbulenceElement.cpp:
3113         * svg/SVGFETurbulenceElement.h:
3114         * svg/SVGFilterElement.cpp:
3115         * svg/SVGGElement.cpp:
3116         * svg/SVGGradientElement.cpp:
3117         * svg/SVGHKernElement.idl:
3118         * svg/SVGLangSpace.cpp:
3119         * svg/SVGLangSpace.h:
3120         * svg/SVGLength.cpp:
3121         * svg/SVGLength.h:
3122         * svg/SVGLength.idl:
3123         * svg/SVGLengthList.cpp:
3124         * svg/SVGLengthList.h:
3125         * svg/SVGLineElement.cpp:
3126         * svg/SVGLinearGradientElement.h:
3127         * svg/SVGList.h:
3128         * svg/SVGListTraits.h:
3129         * svg/SVGLocatable.h:
3130         * svg/SVGMaskElement.cpp:
3131         * svg/SVGMatrix.idl:
3132         * svg/SVGMetadataElement.cpp:
3133         * svg/SVGMetadataElement.h:
3134         * svg/SVGMetadataElement.idl:
3135         * svg/SVGNumber.idl:
3136         * svg/SVGNumberList.cpp:
3137         * svg/SVGNumberList.h:
3138         * svg/SVGPaint.cpp:
3139         * svg/SVGPathElement.cpp:
3140         * svg/SVGPathSeg.h:
3141         * svg/SVGPathSegArc.cpp:
3142         * svg/SVGPathSegArc.h:
3143         * svg/SVGPathSegClosePath.cpp:
3144         * svg/SVGPathSegClosePath.h:
3145         * svg/SVGPathSegCurvetoCubic.cpp:
3146         * svg/SVGPathSegCurvetoCubic.h:
3147         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
3148         * svg/SVGPathSegCurvetoCubicSmooth.h:
3149         * svg/SVGPathSegCurvetoQuadratic.cpp:
3150         * svg/SVGPathSegCurvetoQuadratic.h:
3151         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
3152         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
3153         * svg/SVGPathSegLineto.cpp:
3154         * svg/SVGPathSegLineto.h:
3155         * svg/SVGPathSegLinetoHorizontal.cpp:
3156         * svg/SVGPathSegLinetoHorizontal.h:
3157         * svg/SVGPathSegLinetoVertical.cpp:
3158         * svg/SVGPathSegLinetoVertical.h:
3159         * svg/SVGPathSegMoveto.cpp:
3160         * svg/SVGPathSegMoveto.h:
3161         * svg/SVGPatternElement.cpp:
3162         * svg/SVGPoint.idl:
3163         * svg/SVGPointList.cpp:
3164         * svg/SVGPointList.h:
3165         * svg/SVGPolyElement.cpp:
3166         * svg/SVGPolygonElement.cpp:
3167         * svg/SVGPolygonElement.h:
3168         * svg/SVGPolylineElement.cpp:
3169         * svg/SVGPolylineElement.h:
3170         * svg/SVGPreserveAspectRatio.cpp:
3171         * svg/SVGPreserveAspectRatio.h:
3172         * svg/SVGRadialGradientElement.h:
3173         * svg/SVGRect.idl:
3174         * svg/SVGRectElement.cpp:
3175         * svg/SVGRenderingIntent.h:
3176         * svg/SVGSVGElement.idl:
3177         * svg/SVGScriptElement.cpp:
3178         * svg/SVGSetElement.cpp:
3179         * svg/SVGSetElement.h:
3180         * svg/SVGStopElement.cpp:
3181         * svg/SVGStringList.cpp:
3182         * svg/SVGStringList.h:
3183         * svg/SVGStylable.cpp:
3184         * svg/SVGStylable.h:
3185         * svg/SVGStyleElement.cpp:
3186         * svg/SVGStyleElement.h:
3187         * svg/SVGStyledElement.h:
3188         * svg/SVGStyledLocatableElement.cpp:
3189         * svg/SVGStyledLocatableElement.h:
3190         * svg/SVGStyledTransformableElement.cpp:
3191         * svg/SVGStyledTransformableElement.h:
3192         * svg/SVGSwitchElement.cpp:
3193         * svg/SVGSymbolElement.cpp:
3194         * svg/SVGTRefElement.cpp:
3195         * svg/SVGTSpanElement.cpp:
3196         * svg/SVGTSpanElement.h:
3197         * svg/SVGTests.h:
3198         * svg/SVGTextElement.cpp:
3199         * svg/SVGTextElement.h:
3200         * svg/SVGTextPathElement.cpp:
3201         * svg/SVGTextPositioningElement.cpp:
3202         * svg/SVGTextPositioningElement.h:
3203         * svg/SVGTitleElement.cpp:
3204         * svg/SVGTitleElement.h:
3205         * svg/SVGTransform.cpp:
3206         * svg/SVGTransform.h:
3207         * svg/SVGTransform.idl:
3208         * svg/SVGTransformList.cpp:
3209         * svg/SVGTransformList.h:
3210         * svg/SVGTransformable.h:
3211         * svg/SVGURIReference.h:
3212         * svg/SVGUnitTypes.h:
3213         * svg/SVGUseElement.cpp:
3214         * svg/SVGViewElement.cpp:
3215         * svg/SVGZoomAndPan.cpp:
3216         * svg/SVGZoomAndPan.h:
3217         * svg/SVGZoomEvent.cpp:
3218
3219 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3220
3221         Reviewed by Dimitri Glazkov.
3222
3223         REGRESSION Clean up security origin usage in DOM Storage.
3224         https://bugs.webkit.org/show_bug.cgi?id=31188
3225
3226         Clean up security origin usage in DOM Storage.  This fixes a bug in my
3227         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
3228
3229         Instead of having StorageAreaSync's constructor (which is called in the
3230         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
3231         database identifier, simply have StorageAreaImpl pass the identifier into
3232         StorageAreaSync.
3233
3234         No test because there's no change in externally observable behavior.
3235
3236         * storage/StorageAreaImpl.cpp:
3237         (WebCore::StorageAreaImpl::StorageAreaImpl):
3238         * storage/StorageAreaImpl.h:
3239         * storage/StorageAreaSync.cpp:
3240         (WebCore::StorageAreaSync::create):
3241         (WebCore::StorageAreaSync::StorageAreaSync):
3242         * storage/StorageAreaSync.h:
3243
3244 2009-11-05  Scott Violet  <sky@google.com>
3245
3246         Reviewed by Dimitri Glazkov.
3247
3248         Need notification of scrolling frame
3249         https://bugs.webkit.org/show_bug.cgi?id=31145
3250
3251         Adds FrameLoaderClient::didChangeScrollOffset that is called when
3252         the frame scrolls. This will be used to know when history state
3253         needs to be updated.
3254
3255         * loader/FrameLoaderClient.h:
3256         (WebCore::FrameLoaderClient::didChangeScrollOffset):
3257         * page/FrameView.cpp:
3258         (WebCore::FrameView::valueChanged):
3259
3260 2009-11-05  Kenneth Russell  <kbr@google.com>
3261
3262         Reviewed by Dimitri Glazkov.
3263
3264         [V8] Update bindings to use new API for external arrays
3265         https://bugs.webkit.org/show_bug.cgi?id=31181
3266
3267         No new tests; covered by existing WebGL tests.
3268
3269         * bindings/v8/V8DOMWrapper.cpp:
3270         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
3271         (WebCore::V8DOMWrapper::getTemplate):
3272         (WebCore::V8DOMWrapper::convertToV8Object):
3273         * bindings/v8/V8DOMWrapper.h:
3274         * bindings/v8/custom/V8CanvasArrayCustom.h:
3275         (WebCore::constructCanvasArray):
3276
3277 2009-11-05  Alpha Lam  <hclam@chromium.org>
3278
3279         Not reviewed, Chromium build fix.
3280
3281         50561 introduces a custom method for SVGMatrix, we need to implement
3282         this in V8.
3283
3284         * bindings/v8/custom/V8CustomBinding.h:
3285         Adding definition for V8SVGMatrixMultiply.
3286         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
3287         (WebCore::CALLBACK_FUNC_DECL):
3288         Implement V8SVGMatrixMultiply according to the same method in JSC.
3289
3290 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3291
3292         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
3293
3294         * page/DOMWindow.cpp:
3295         (WebCore::DOMWindow::sessionStorage):
3296         * page/Settings.cpp:
3297         (WebCore::Settings::Settings):
3298         (WebCore::Settings::setSessionStorageEnabled):
3299         * page/Settings.h:
3300         (WebCore::Settings::sessionStorageEnabled):
3301
3302 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3303
3304         Reviewed by Timothy Hatcher.
3305
3306         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
3307
3308         https://bugs.webkit.org/show_bug.cgi?id=30884
3309
3310         Test: inspector/styles-iframe.html
3311
3312         * inspector/front-end/DOMAgent.js:
3313         (WebInspector.DOMNode):
3314         * inspector/front-end/InjectedScript.js:
3315         (InjectedScript.getStyles):
3316         (InjectedScript.getComputedStyle):
3317         (InjectedScript.addStyleSelector):
3318         * inspector/front-end/TestController.js:
3319         (WebInspector.TestController.prototype.notifyDone):
3320         (WebInspector.TestController.prototype.runAfterPendingDispatches):
3321         (WebInspector.evaluateForTestInFrontend.invokeMethod):
3322         (WebInspector.evaluateForTestInFrontend):
3323
3324 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
3325
3326         Reviewed by Geoffrey Garen and Dimitri Glazkov.
3327
3328         Rehashing of EventListenerMap leads to loss of EvenListenerList.
3329         https://bugs.webkit.org/show_bug.cgi?id=31027
3330
3331         Tested by new fast/events/event-listener-map-rehash-crash.html.
3332
3333         EventListenerMap modified to store pointers to listener vectors:
3334         * dom/EventTarget.cpp:
3335         (WebCore::EventTargetData::~EventTargetData):
3336         (WebCore::EventTarget::addEventListener):
3337         (WebCore::EventTarget::removeEventListener):
3338         (WebCore::EventTarget::fireEventListeners):
3339         (WebCore::EventTarget::getEventListeners):
3340         (WebCore::EventTarget::removeAllEventListeners):
3341         * dom/EventTarget.h:
3342
3343         Usages updated after interface changes:
3344         * inspector/InspectorDOMAgent.cpp:
3345         (WebCore::InspectorDOMAgent::getEventListenersForNode):
3346         * svg/SVGUseElement.cpp:
3347         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
3348
3349 2009-11-05  Dan Kegel  <dank@chromium.org>
3350
3351         Reviewed by Dmitri Titov.
3352
3353         Add missing initialization for m_createdByParser.
3354         https://bugs.webkit.org/show_bug.cgi?id=31089
3355
3356         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
3357
3358         * dom/ProcessingInstruction.cpp:
3359         (WebCore::ProcessingInstruction::ProcessingInstruction):
3360
3361 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3362
3363         Reviewed by Adam Barth.
3364
3365         DOM Storage runtime flag changes
3366         https://bugs.webkit.org/show_bug.cgi?id=30602
3367
3368         Part 2/2.
3369
3370         Revert my changes to Settings and instead implement DOM Storage enabling via
3371         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
3372
3373         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
3374         LayoutTest visible changes and thus no tests.
3375
3376         * bindings/v8/custom/V8CustomBinding.h:
3377         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3378         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3379         * page/DOMWindow.cpp:
3380         (WebCore::DOMWindow::sessionStorage):
3381         * page/DOMWindow.idl:
3382         * page/Settings.cpp:
3383         (WebCore::Settings::Settings):
3384         * page/Settings.h:
3385         * storage/Storage.cpp:
3386         (WebCore::Storage::setLocalStorageAvailable):
3387         (WebCore::Storage::localStorageAvailable):
3388         (WebCore::Storage::setSessionStorageAvailable):
3389         (WebCore::Storage::sessionStorageAvailable):
3390         * storage/Storage.h:
3391
3392 2009-11-05  Jian Li  <jianli@chromium.org>
3393
3394         Reviewed by Pavel Feldman.
3395
3396         Bug 31108 - [V8] REGRESSION: Pause on exception is broken
3397         https://bugs.webkit.org/show_bug.cgi?id=31108
3398
3399         * bindings/v8/V8AbstractEventListener.cpp:
3400         (WebCore::V8AbstractEventListener::invokeEventHandler):
3401         * bindings/v8/V8Utilities.cpp:
3402         (WebCore::reportException):
3403
3404 2009-11-05  Jian Li  <jianli@chromium.org>
3405
3406         Reviewed by Dmitri Titov.
3407
3408         We should not bubble up events if we drag something to an iframe that
3409         has an invalid source.
3410         https://bugs.webkit.org/show_bug.cgi?id=30469
3411
3412         Test: http/tests/misc/bubble-drag-events.html
3413
3414         * page/EventHandler.cpp:
3415         (WebCore::EventHandler::handleDragAndDropForTarget):
3416         (WebCore::EventHandler::updateDragAndDrop):
3417         (WebCore::EventHandler::cancelDragAndDrop):
3418         (WebCore::EventHandler::performDragAndDrop):
3419         * page/EventHandler.h:
3420         (WebCore::EventHandler::):
3421
3422 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3423
3424         Reviewed by Timothy Hatcher.
3425
3426         Web Inspector: speed up Timelines Clear by a factor of thousands.
3427
3428         https://bugs.webkit.org/show_bug.cgi?id=31160
3429
3430         * inspector/front-end/utilities.js:
3431         (Element.prototype.removeChildren):
3432
3433 2009-11-05  Anton Muhin  <antonm@chromium.org>
3434
3435         Reviewed by Adam Barth.
3436
3437         If high memory usage is detected, hint to V8 that it might be due
3438         to external objects retained by V8 objects.
3439         https://bugs.webkit.org/show_bug.cgi?id=31051
3440
3441         * bindings/v8/V8GCController.cpp:
3442         (WebCore::GetMemoryUsageInMB):
3443         (WebCore::V8GCController::gcEpilogue):
3444         (WebCore::V8GCController::checkMemoryUsage):
3445         * bindings/v8/V8GCController.h:
3446         * bindings/v8/V8Proxy.cpp:
3447         (WebCore::V8Proxy::evaluate):
3448         (WebCore::V8Proxy::runScript):
3449         (WebCore::V8Proxy::callFunction):
3450
3451 2009-11-05  Jeff Schiller  <codedread@gmail.com>
3452
3453         Reviewed by Simon Fraser.
3454
3455         Correct order of matrix multiplication for SVGMatrix.
3456         https://bugs.webkit.org/show_bug.cgi?id=16062
3457
3458         Test: svg/dom/SVGMatrix-interface.xhtml
3459
3460         * bindings/js/JSSVGMatrixCustom.cpp:
3461         (WebCore::JSSVGMatrix::multiply):
3462         * svg/SVGMatrix.idl:
3463
3464 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
3465
3466         Reviewed by Timothy Hatcher.
3467
3468         Web Inspector: Make resource-related records in timeline
3469         actually take some time.
3470
3471         https://bugs.webkit.org/show_bug.cgi?id=31139
3472
3473         * English.lproj/localizedStrings.js:
3474         * inspector/front-end/TimelinePanel.js:
3475         (WebInspector.TimelinePanel):
3476         (WebInspector.TimelinePanel.prototype._formatRecord):
3477         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3478         (WebInspector.TimelinePanel.prototype.reset):
3479
3480 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3481
3482         Reviewed by Darin Fisher.
3483
3484         Simplify LocalStorageThread
3485         https://bugs.webkit.org/show_bug.cgi?id=30935
3486
3487         This is a re-submit of 50519.  LocalStorageTask should have never been ref
3488         counted.  I've removed that and switched a PassRefPtr over to a PassOwnPtr.
3489
3490         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
3491         of the method names a bit more clear. Assert proper thread usage. Join rather
3492         than detaching the thread and doing an ad-hoc form of join. Avoid touching
3493         variables on the background thread when simple to do so.  Also create a generic
3494         scheduleTask function rather than one for each task.
3495
3496         No behavior should have changed.
3497
3498         * storage/LocalStorageTask.h:
3499         * storage/LocalStorageThread.cpp:
3500         (WebCore::LocalStorageThread::create):
3501         (WebCore::LocalStorageThread::LocalStorageThread):
3502         (WebCore::LocalStorageThread::~LocalStorageThread):
3503         (WebCore::LocalStorageThread::start):
3504         (WebCore::LocalStorageThread::threadEntryPointCallback):
3505         (WebCore::LocalStorageThread::threadEntryPoint):
3506         (WebCore::LocalStorageThread::scheduleTask):
3507         (WebCore::LocalStorageThread::terminate):
3508         (WebCore::LocalStorageThread::performTerminate):
3509         * storage/LocalStorageThread.h:
3510         * storage/StorageSyncManager.cpp:
3511         (WebCore::StorageSyncManager::StorageSyncManager):
3512         (WebCore::StorageSyncManager::~StorageSyncManager):
3513         (WebCore::StorageSyncManager::scheduleImport):
3514         (WebCore::StorageSyncManager::scheduleSync):
3515         * storage/StorageSyncManager.h:
3516
3517 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3518
3519         Reviewed by Darin Fisher.
3520
3521         Calling databaseIdentifier on LocalStorage's background thread is not safe.
3522         https://bugs.webkit.org/show_bug.cgi?id=31149
3523
3524         Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
3525         is not safe.  databaseIdentifier does a bunch of string concatenation which
3526         ref-counts StringImpls in some cases.  This was caught by valgrind thread
3527         sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645
3528
3529         There's no way to test for such racyness, unfortunately.
3530
3531         * storage/StorageAreaSync.cpp:
3532         (WebCore::StorageAreaSync::StorageAreaSync):
3533         (WebCore::StorageAreaSync::performImport):
3534         * storage/StorageAreaSync.h:
3535         * storage/StorageSyncManager.cpp:
3536         (WebCore::StorageSyncManager::fullDatabaseFilename):
3537         * storage/StorageSyncManager.h:
3538
3539 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
3540
3541         Reviewed by Darin Fisher.
3542
3543         Clean up StorageAreaSync
3544         https://bugs.webkit.org/show_bug.cgi?id=31100
3545
3546         Major fixes: Break the ref count cycle for StorageArea on the main
3547         thread, not the background thread since the latter is not safe.
3548         Length() needs to block on the import completing.
3549
3550         Small fixes: setItem needs to handle the copy on write case even if it
3551         has an exception.  setItem and removeItem should just bail from the
3552         the function if the value hasn't changed rather than wrapping the end
3553         in an if block.  Clear should only send an event if it wasn't already
3554         cleared.  StorageAreaSync should assert that the final sync was
3555         scheduled.
3556
3557         * storage/StorageAreaImpl.cpp:
3558         (WebCore::StorageAreaImpl::length):
3559           Forgot to block on the import.
3560         (WebCore::StorageAreaImpl::key):
3561         (WebCore::StorageAreaImpl::setItem):
3562           Handle the copy on write case even when there's an exception.
3563         (WebCore::StorageAreaImpl::removeItem):
3564         (WebCore::StorageAreaImpl::clear):
3565         * storage/StorageAreaSync.cpp:
3566         (WebCore::StorageAreaSync::~StorageAreaSync):
3567         (WebCore::StorageAreaSync::scheduleFinalSync):
3568         (WebCore::StorageAreaSync::performImport):
3569         (WebCore::StorageAreaSync::markImported):
3570         (WebCore::StorageAreaSync::blockUntilImportComplete):
3571         * storage/StorageAreaSync.h:
3572
3573 2009-11-05  Zoltan Horvath  <zoltan@webkit.org>
3574
3575         Reviewed by Eric Seidel.
3576
3577         Allow custom memory allocation control for WebCore's CachedResource
3578         https://bugs.webkit.org/show_bug.cgi?id=31114
3579
3580         Inherits CachedResource class from Noncopyable because its (its child
3581         class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75 
3582         and it is no need to be copyable.
3583
3584         * loader/CachedResource.h:
3585
3586 2009-11-04  Mark Mentovai  <mark@chromium.org>
3587
3588         Reviewed by Mark Rowe.
3589
3590         Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
3591         is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
3592         which is true when targeting 10.6 or later.
3593
3594         HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
3595         is present in the CGInterpolationQuality enum, and must be handled
3596         by a switch that has cases for each enumerated value.
3597
3598         USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
3599         on 10.6 or later, and that CoreGraphics will understand when
3600         InterpolationMedium is mapped to kCGInterpolationMedium at runtime.
3601
3602         * platform/graphics/cg/GraphicsContextCG.cpp:
3603         (WebCore::GraphicsContext::setImageInterpolationQuality):
3604         (WebCore::GraphicsContext::imageInterpolationQuality):
3605
3606 2009-11-04  Dan Kegel  <dank@chromium.org>
3607
3608         Reviewed by Alexey Proskuryakov.
3609
3610         Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
3611         https://bugs.webkit.org/show_bug.cgi?id=31138
3612
3613         Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind
3614
3615         * page/Page.cpp:
3616         (WebCore::Page::userStyleSheetLocationChanged):
3617
3618 2009-11-04  Timothy Hatcher  <timothy@apple.com>
3619
3620         Update the Web Inspector Timeline panel to better match the mock-up.
3621
3622         https://bugs.webkit.org/show_bug.cgi?id=31150
3623
3624         Reviewed by Pavel Feldman.
3625
3626         * inspector/front-end/TimelinePanel.js:
3627         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3628         (WebInspector.TimelinePanel.prototype._dragWindow):
3629         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
3630         (WebInspector.TimelinePanel.prototype._resizeWindowRight):
3631         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
3632         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3633         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
3634         (WebInspector.TimelineCategoryGraph):
3635         * inspector/front-end/inspector.css:
3636
3637 2009-11-05  Justin Garcia  <justin.garcia@apple.com>
3638
3639         Reviewed by Adele Peterson.
3640
3641         https://bugs.webkit.org/show_bug.cgi?id=25439
3642         Deleting when in front of a block image removes character from previous paragraph
3643
3644         Added editing/deleting/25439-{1,2,3}.html
3645
3646         * editing/DeleteSelectionCommand.cpp:
3647         (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot 
3648         be made inline with other content.  Instead of merging, just move the caret to just before 
3649         the selection we deleted.
3650         * editing/htmlediting.cpp:
3651         (WebCore::firstInSpecialElement): Added a FIXME.  This function begins iterating up from pos.node(), which 
3652         doesn't necessarily contain pos (suppose pos was [img, 0]).
3653         (WebCore::lastInSpecialElement): Ditto.
3654         (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp.  Added a check for non-inline images.
3655         * editing/htmlediting.h:
3656         * editing/visible_units.cpp:
3657         (WebCore::startOfParagraph): Use moved/renamed function.  Removed FIXME.  The problem causing 
3658         5027702 is now squarely in first/lastInSpecialElement
3659         (WebCore::endOfParagraph): Ditto.
3660         
3661 2009-11-04  Enrica Casucci  <enrica@apple.com>
3662
3663         Reviewed by Adele Peterson.
3664
3665         Hang in Mail on attempting to change indent level.
3666         <rdar://problem/7131805>
3667         https://bugs.webkit.org/show_bug.cgi?id=31127
3668
3669         The hang was caused by an infinite loop inside outdentRegion.
3670         The code did not account for the fact that, when a list item
3671         contains multiple paragraphs, outdent moves all paragraphs at
3672         once, invalidating some of the positions we keep track of in the loop.
3673         Some code refactoring has also been done to minimize duplicated code.
3674         
3675         Test: editing/execCommand/outdent-multiparagraph-list.html
3676
3677         * editing/IndentOutdentCommand.cpp:
3678         (WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
3679         outdentRegion to doApply.
3680         (WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
3681         (WebCore::IndentOutdentCommand::doApply): Some code refactoring.
3682         * editing/IndentOutdentCommand.h: Added VisiblePosition parameters to
3683         indentRegion and outdentRegion.
3684
3685 2009-11-04  Alpha Lam  <hclam@chromium.org>
3686
3687         Reviewed by Eric Carlson.
3688
3689         Volume slider doesn't have a thumb
3690         https://bugs.webkit.org/show_bug.cgi?id=31135
3691
3692         Fixed an incorrect if statement that prevents volume slider
3693         being updated.
3694
3695         The statement checks if the slider value equals to the current
3696         volume value of the media control to avoid updating the volume
3697         slider. Updating the volume slider control shouldn't be within
3698         this condition because we explicitly set them to be equals
3699         during creation of the controls and also when mouse events are
3700         received on the volume control.
3701
3702         No new tests because existing code breaks:
3703         LayoutTests/media/video-volume-slider.html
3704
3705         It should now start passing on Chromium.
3706
3707         * rendering/MediaControlElements.cpp:
3708         (WebCore::MediaControlVolumeSliderElement::update):
3709         Update the volume slider regardless of the current volume value
3710         of the media control.
3711
3712 2009-11-04  Jenn Braithwaite  <jennb@chromium.org>
3713
3714         Reviewed by David Levin.
3715
3716         Need to properly disable applicationCache at runtime
3717         https://bugs.webkit.org/show_bug.cgi?id=30417
3718
3719         Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.
3720
3721         No new exposed functionality, so no new tests.
3722
3723         * bindings/v8/RuntimeEnabledFeatures.cpp:
3724         * bindings/v8/RuntimeEnabledFeatures.h:
3725         (WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
3726         (WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
3727         * bindings/v8/custom/V8CustomBinding.h:
3728         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3729         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3730         * page/DOMWindow.idl:
3731
3732 2009-11-04  Alexey Proskuryakov  <ap@apple.com>
3733
3734         Reviewed by Dan Bernstein.
3735
3736         https://bugs.webkit.org/show_bug.cgi?id=31143
3737         Assertion failure in CredentialStorage::set() when proxy credentials are being set
3738
3739         No test, cannot test proxy behavior.
3740
3741         * platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the
3742         possibility of null url. Release mode changes are likely inconsequential - e.g. we used to
3743         add "://" to origin set, which is weird, but safe.
3744
3745 2009-11-04  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3746
3747         Reviewed by Timothy Hatcher.
3748
3749         Web Inspector: Leftover Breakpoints in the Sidebar Pane
3750         https://bugs.webkit.org/show_bug.cgi?id=30659
3751
3752         No new tests.
3753
3754         * inspector/front-end/ScriptsPanel.js:
3755         (WebInspector.ScriptsPanel.prototype.addScript):
3756
3757 2009-11-04  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3758
3759         Reviewed by Timothy Hatcher.
3760
3761         WebInspector: Use a different method to identify the webkit port in
3762         InspectorBackent::platform().
3763         This corrects the inspector expected behavior with Qt on Windows.
3764         https://bugs.webkit.org/show_bug.cgi?id=31116
3765
3766         * inspector/InspectorBackend.cpp:
3767         (WebCore::InspectorBackend::platform):
3768         (WebCore::InspectorBackend::port):
3769         * inspector/InspectorBackend.h:
3770         * inspector/InspectorBackend.idl:
3771         * inspector/front-end/InspectorControllerStub.js:
3772         (.WebInspector.InspectorControllerStub.prototype.port):
3773         * inspector/front-end/inspector.css:
3774         * inspector/front-end/inspector.js:
3775         (WebInspector.loaded):
3776         (WebInspector.toolbarDragStart):
3777
3778 2009-11-04  Benjamin Otte  <otte@gnome.org>
3779
3780         Reviewed by Gustavo Noronha.
3781
3782         Update Cairo requirement to 1.6.
3783
3784         Also remove all conditional code and workarounds for older versions of
3785         Cairo.
3786         In particular, gain image quality by removing the use of
3787         CAIRO_FILTER_NEAREST when rendering images and use the default
3788         bilinear filter instead.
3789         https://bugs.webkit.org/show_bug.cgi?id=19266
3790
3791         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3792         (WebCore::GraphicsContext::clipOut):
3793         * platform/graphics/cairo/ImageCairo.cpp:
3794         (WebCore::BitmapImage::draw):
3795         (WebCore::BitmapImage::drawPattern):
3796         * platform/graphics/cairo/PathCairo.cpp:
3797         (WebCore::Path::isEmpty):
3798         (WebCore::Path::boundingRect):
3799         * platform/gtk/RenderThemeGtk.cpp:
3800         (WebCore::paintMozWidget):
3801
3802 2009-11-04  Kevin Ollivier  <kevino@theolliviers.com>
3803
3804         wx build fix. Restore removed string conversion after cleanup.
3805
3806         * platform/graphics/wx/FontPlatformDataWx.cpp:
3807         (WebCore::FontPlatformData::computeHash):
3808
3809 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3810
3811         Reviewed by Beth Dakin.
3812
3813         Need to implement ARIA role="combobox"
3814         https://bugs.webkit.org/show_bug.cgi?id=31096
3815
3816         Test: accessibility/aria-combobox.html
3817
3818         * accessibility/AccessibilityObject.h:
3819         (WebCore::AccessibilityObject::isComboBox):
3820         (WebCore::AccessibilityObject::isExpanded):
3821         (WebCore::AccessibilityObject::expandObject):
3822         (WebCore::AccessibilityObject::increment):
3823         (WebCore::AccessibilityObject::decrement):
3824         * accessibility/AccessibilityRenderObject.cpp:
3825         (WebCore::AccessibilityRenderObject::expandObject):
3826         (WebCore::AccessibilityRenderObject::isExpanded):
3827         (WebCore::createARIARoleMap):
3828         * accessibility/AccessibilityRenderObject.h:
3829         * accessibility/mac/AccessibilityObjectWrapper.mm:
3830         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
3831         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
3832         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
3833         * html/HTMLAttributeNames.in:
3834
3835 2009-11-04  Kelly Norton  <knorton@google.com>
3836
3837         Reviewed by Pavel Feldman.
3838
3839         Fixes naming inconsistencies in TimelineRecordFactory.
3840         https://bugs.webkit.org/show_bug.cgi?id=31132
3841
3842         * inspector/InspectorTimelineAgent.cpp:
3843         (WebCore::InspectorTimelineAgent::willPaint):
3844         (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
3845         (WebCore::InspectorTimelineAgent::willLoadXHR):
3846         (WebCore::InspectorTimelineAgent::willEvaluateScript):
3847         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
3848         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
3849         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
3850         * inspector/TimelineRecordFactory.cpp:
3851         (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord):
3852         (WebCore::TimelineRecordFactory::createXHRLoadRecord):
3853         (WebCore::TimelineRecordFactory::createEvaluateScriptRecord):
3854         (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
3855         (WebCore::TimelineRecordFactory::createResourceSendRequestRecord):
3856         (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord):
3857         (WebCore::TimelineRecordFactory::createResourceFinishRecord):
3858         (WebCore::TimelineRecordFactory::createPaintRecord):
3859         * inspector/TimelineRecordFactory.h:
3860
3861 2009-11-04  Eric Z. Ayers  <zundel@google.com>
3862
3863         Reviewed by Pavel Feldman.
3864
3865         Followon to bug 31080, which protects Timeline
3866         instrumentation in the case where InspectorTimelineAgent
3867         is enabled or disabled during an event dispatch.
3868         
3869         https://bugs.webkit.org/show_bug.cgi?id=31121
3870
3871         * bindings/v8/V8Proxy.cpp:
3872         (WebCore::V8Proxy::evaluate):
3873         * dom/Document.cpp:
3874         (WebCore::Document::recalcStyle):
3875         * dom/Node.cpp:
3876         (WebCore::Node::dispatchGenericEvent):
3877         * html/HTMLTokenizer.cpp:
3878         (WebCore::HTMLTokenizer::write):
3879         * page/DOMWindow.cpp:
3880         (WebCore::DOMWindow::inspectorTimelineAgent):
3881         (WebCore::DOMWindow::dispatchEvent):
3882         * page/DOMWindow.h:
3883         * page/FrameView.cpp:
3884         (WebCore::FrameView::layout):
3885         (WebCore::FrameView::paintContents):
3886         * xml/XMLHttpRequest.cpp:
3887         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
3888
3889 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3890
3891         Revert 50519 while I work out what went wrong.
3892
3893         * storage/LocalStorageThread.cpp:
3894         (WebCore::LocalStorageThread::create):
3895         (WebCore::LocalStorageThread::LocalStorageThread):
3896         (WebCore::LocalStorageThread::start):
3897         (WebCore::LocalStorageThread::localStorageThreadStart):
3898         (WebCore::LocalStorageThread::localStorageThread):
3899         (WebCore::LocalStorageThread::scheduleImport):
3900         (WebCore::LocalStorageThread::scheduleSync):
3901         (WebCore::LocalStorageThread::terminate):
3902         (WebCore::LocalStorageThread::performTerminate):
3903         * storage/LocalStorageThread.h:
3904         * storage/StorageSyncManager.cpp:
3905         (WebCore::StorageSyncManager::StorageSyncManager):
3906         (WebCore::StorageSyncManager::~StorageSyncManager):
3907         (WebCore::StorageSyncManager::scheduleImport):
3908         (WebCore::StorageSyncManager::scheduleSync):
3909         * storage/StorageSyncManager.h:
3910
3911 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
3912
3913         Reviewed by Timothy Hatcher.
3914
3915         Web Inspector: Add basic support for resource events and marks.
3916         Couple of drive-by fixes. Enabling the panel!
3917
3918         https://bugs.webkit.org/show_bug.cgi?id=31130
3919
3920         * English.lproj/localizedStrings.js:
3921         * inspector/front-end/TimelinePanel.js:
3922         (WebInspector.TimelinePanel):
3923         (WebInspector.TimelinePanel.prototype._formatRecord):
3924         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3925         (WebInspector.TimelinePanel.prototype.reset):
3926         (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked):
3927         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3928         * inspector/front-end/inspector.js:
3929         (WebInspector._createPanels):
3930
3931 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
3932
3933         Reviewed by Darin Fisher.
3934
3935         Simplify LocalStorageThread
3936         https://bugs.webkit.org/show_bug.cgi?id=30935
3937
3938         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
3939         of the method names a bit more clear. Assert proper thread usage. Join rather
3940         than detaching the thread and doing an ad-hoc form of join. Avoid touching
3941         variables on the background thread when simple to do so.  Also create a generic
3942         scheduleTask function rather than one for each task.
3943
3944         No behavior should have changed.
3945
3946         * storage/LocalStorageThread.cpp:
3947         (WebCore::LocalStorageThread::create):
3948         (WebCore::LocalStorageThread::LocalStorageThread):
3949         (WebCore::LocalStorageThread::~LocalStorageThread):
3950         (WebCore::LocalStorageThread::start):
3951         (WebCore::LocalStorageThread::threadEntryPointCallback):
3952         (WebCore::LocalStorageThread::threadEntryPoint):
3953         (WebCore::LocalStorageThread::scheduleTask):
3954         (WebCore::LocalStorageThread::terminate):
3955         (WebCore::LocalStorageThread::performTerminate):
3956         * storage/LocalStorageThread.h:
3957         * storage/StorageSyncManager.cpp:
3958         (WebCore::StorageSyncManager::StorageSyncManager):
3959         (WebCore::StorageSyncManager::~StorageSyncManager):
3960         (WebCore::StorageSyncManager::scheduleImport):
3961         (WebCore::StorageSyncManager::scheduleSync):
3962         * storage/StorageSyncManager.h:
3963
3964 2009-11-04  Vadim Zeitlin  <vadim@wxwidgets.org>
3965
3966         Reviewed by Eric Seidel.
3967
3968         [wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.
3969
3970         * platform/graphics/wx/FontPlatformDataWx.cpp:
3971         (WebCore::FontPlatformData::computeHash):
3972
3973 2009-11-04  Kelly Norton  <knorton@google.com>
3974
3975         Reviewed by Pavel Feldman.
3976
3977         Adds lightweight network resources to InspectorTimelineAgent.
3978         https://bugs.webkit.org/show_bug.cgi?id=31065
3979
3980         * inspector/InspectorController.cpp:
3981         (WebCore::InspectorController::willSendRequest):
3982         (WebCore::InspectorController::didReceiveResponse):
3983         (WebCore::InspectorController::didFinishLoading):
3984         (WebCore::InspectorController::didFailLoading):
3985         * inspector/InspectorTimelineAgent.cpp:
3986         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
3987         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
3988         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
3989         * inspector/InspectorTimelineAgent.h:
3990         (WebCore::):
3991         * inspector/TimelineRecordFactory.cpp:
3992         (WebCore::TimelineRecordFactory::createResourceSendRequestTimelineRecord):
3993         (WebCore::TimelineRecordFactory::createResourceReceiveResponseTimelineRecord):
3994         (WebCore::TimelineRecordFactory::createResourceFinishTimelineRecord):
3995         * inspector/TimelineRecordFactory.h:
3996         * inspector/front-end/TimelineAgent.js:
3997
3998 2009-11-04  Yael Aharon  <yael.aharon@nokia.com>
3999
4000         Reviewed by Tor Arne Vestbø.
4001
4002         [Qt] ASSERT failure when receiving 401 HTTP Authentication response.
4003         https://bugs.webkit.org/show_bug.cgi?id=31077
4004
4005         Allow sending the response body under the same conditions that we
4006         allow it to finish without reporting an error.
4007
4008         * platform/network/qt/QNetworkReplyHandler.cpp:
4009         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
4010
4011 2009-11-04  Adam Roben  <aroben@apple.com>
4012
4013         Sort WebCore.base.exp
4014
4015         Rubber-stamped by Dan Bernstein.
4016
4017         * WebCore.base.exp: Sorted.
4018
4019 2009-11-04  Csaba Osztrogonác  <ossy@webkit.org>
4020
4021         Unreviewed rollout.
4022
4023         Revert r50496 because it broke all layout tests on QtBuildBot.
4024
4025         * WebCore.pro:
4026         * platform/graphics/qt/FontCacheQt.cpp:
4027         (WebCore::fontCache):
4028         (WebCore::FontCache::FontCache):
4029         (WebCore::FontCache::getTraitsInFamily):
4030         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
4031         (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
4032         (WebCore::FontPlatformDataCacheKey::):
4033         (WebCore::FontPlatformDataCacheKey::operator==):
4034         (WebCore::FontPlatformDataCacheKey::hash):
4035         (WebCore::FontPlatformDataCacheKey::computeHash):
4036         (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
4037         (WebCore::FontPlatformDataCacheKeyHash::hash):
4038         (WebCore::FontPlatformDataCacheKeyHash::equal):
4039         (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
4040         (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
4041         (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
4042         (WebCore::FontCache::getCachedFontPlatformData):
4043         (WebCore::FontCache::getCachedFontData):
4044         (WebCore::FontCache::getLastResortFallbackFont):
4045         (WebCore::FontCache::releaseFontData):
4046         (WebCore::FontCache::purgeInactiveFontData):
4047         (WebCore::FontCache::addClient):
4048         (WebCore::FontCache::removeClient):
4049         (WebCore::FontCache::invalidate):
4050         * platform/graphics/qt/FontFallbackListQt.cpp: Added.
4051         (WebCore::FontFallbackList::FontFallbackList):
4052         (WebCore::FontFallbackList::invalidate):
4053         (WebCore::FontFallbackList::releaseFontData):
4054         (WebCore::FontFallbackList::determinePitch):
4055         (WebCore::FontFallbackList::fontDataAt):
4056         (WebCore::FontFallbackList::fontDataForCharacters):
4057         (WebCore::FontFallbackList::setPlatformFont):
4058         * platform/graphics/qt/FontPlatformData.h:
4059         (WebCore::FontPlatformData::pixelSize):
4060         * platform/graphics/qt/FontPlatformDataQt.cpp:
4061         (WebCore::FontPlatformData::FontPlatformData):
4062
4063 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
4064
4065         Reviewed by Jan Alonzo.
4066
4067         https://bugs.webkit.org/show_bug.cgi?id=31044
4068         [Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view
4069
4070         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
4071         (atkParentOfWebView):
4072         (webkit_accessible_get_index_in_parent):
4073         (webkit_accessible_get_parent):
4074
4075 2009-11-04  Dominik Röttsches  <dominik.roettsches@access-company.com>
4076
4077         Reviewed by Eric Seidel.
4078
4079         https://bugs.webkit.org/show_bug.cgi?id=15914
4080         [GTK] Implement Unicode functionality using GLib
4081
4082         Initial version of this patch by Jürg Billeter and Naiem Shaik.
4083         Patch 2/4 - Moving TextCodecs to GLib
4084         
4085         Added probing for a hard-coded lists of text encodings.
4086         The basis of this list is taken from the encodings supported by iconv,
4087         then extended by e.g. tis-620, windows-1251, euc-kr, windows-1253 and
4088         a number of Chinese ones.
4089
4090         Probing is necessary with the current design of text codecs
4091         as iconv/GLib do not support enumerating available encodings.
4092
4093         * GNUmakefile.am:
4094         * platform/ThreadGlobalData.cpp:
4095         (WebCore::ThreadGlobalData::ThreadGlobalData):
4096         (WebCore::ThreadGlobalData::~ThreadGlobalData):
4097         * platform/text/TextEncoding.cpp:
4098         (WebCore::TextEncoding::encode):
4099         * platform/text/TextEncodingRegistry.cpp:
4100         (WebCore::buildBaseTextCodecMaps):
4101         (WebCore::extendTextCodecMaps):
4102         * platform/text/gtk/TextCodecGtk.cpp: Added.
4103         (WebCore::):
4104         (WebCore::newTextCodecGtk):
4105         (WebCore::TextCodecGtk::isEncodingAvailable):
4106         (WebCore::TextCodecGtk::registerEncodingNames):
4107         (WebCore::TextCodecGtk::registerCodecs):
4108         (WebCore::TextCodecGtk::registerBaseEncodingNames):
4109         (WebCore::TextCodecGtk::registerBaseCodecs):
4110         (WebCore::TextCodecGtk::registerExtendedEncodingNames):
4111         (WebCore::TextCodecGtk::registerExtendedCodecs):
4112         (WebCore::TextCodecGtk::TextCodecGtk):
4113         (WebCore::TextCodecGtk::~TextCodecGtk):
4114         (WebCore::TextCodecGtk::releaseIConv):
4115         (WebCore::TextCodecGtk::createIConvDecoder):
4116         (WebCore::TextCodecGtk::createIConvEncoder):
4117         (WebCore::TextCodecGtk::decode):
4118         (WebCore::TextCodecGtk::encode):
4119         * platform/text/gtk/TextCodecGtk.h: Added.
4120
4121 2009-11-04  Martin Robinson  <martin.james.robinson@gmail.com>
4122
4123         Reviewed by Jan Alonzo.
4124
4125         [GTK] Enable DOM clipboard and drag-and-drop access
4126         https://bugs.webkit.org/show_bug.cgi?id=30623
4127
4128         Unify redudant methods which will always return the same value.
4129
4130         * platform/gtk/PasteboardGtk.cpp:
4131         (WebCore::Pasteboard::writeSelection):
4132         * platform/gtk/PasteboardHelper.h:
4133
4134 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
4135
4136         Reviewed by Jan Alonzo.
4137
4138         https://bugs.webkit.org/show_bug.cgi?id=31035
4139         [GTK] some accessibility tests hitting assertion in debug builds
4140
4141         Removes the assertions in webkit_accessible_ref_child; adds sanity checks.
4142         Any app or AT can attempt to ref a child at a bogus index.
4143
4144         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
4145         (webkit_accessible_ref_child):
4146
4147 2009-11-04  Benjamin Otte  <otte@gnome.org>
4148
4149         Reviewed by Jan Alonzo.
4150
4151         [gtk] Use gst_element_class_set_details_simple()
4152
4153         Cosmetic change, just code simplification
4154
4155         * platform/graphics/gtk/VideoSinkGStreamer.cpp:
4156         (webkit_video_sink_base_init):
4157 2009-11-04  Kelly Norton  <knorton@google.com>
4158
4159         Reviewed by Timothy Hatcher.
4160
4161         Adds paint rectangle information to TimelineAgent's didPaint callback.
4162         https://bugs.webkit.org/show_bug.cgi?id=31087
4163
4164         * inspector/InspectorTimelineAgent.cpp:
4165         (WebCore::InspectorTimelineAgent::willPaint):
4166         * inspector/InspectorTimelineAgent.h:
4167         * inspector/TimelineRecordFactory.cpp:
4168         (WebCore::TimelineRecordFactory::createPaintTimelineRecord):
4169         * inspector/TimelineRecordFactory.h:
4170         * page/FrameView.cpp:
4171         (WebCore::FrameView::paintContents):
4172
4173 2009-11-04  Jaime Yap  <jaimeyap@google.com>
4174
4175         Reviewed by Timothy Hatcher.
4176
4177         This patch adds API to the console object for annotating the
4178         inspector timeline. This allows developers to mark logical
4179         checkpoints in their apps and have them overlaid in the event
4180         record tree.
4181
4182         tests updated: LayoutTests/fast/dom/Window/window-properties.html
4183         https://bugs.webkit.org/show_bug.cgi?id=31082
4184
4185
4186         * inspector/InspectorController.cpp:
4187         (WebCore::InspectorController::markTimeline):
4188         * inspector/InspectorController.h:
4189         * inspector/InspectorTimelineAgent.cpp:
4190         (WebCore::InspectorTimelineAgent::didMarkTimeline):
4191         * inspector/InspectorTimelineAgent.h:
4192         (WebCore::):
4193         * inspector/TimelineRecordFactory.cpp:
4194         (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
4195         * inspector/TimelineRecordFactory.h:
4196         * inspector/front-end/TimelineAgent.js:
4197         * page/Console.cpp:
4198         (WebCore::Console::markTimeline):
4199         * page/Console.h:
4200         * page/Console.idl:
4201
4202 2009-11-03  Simon Hausmann  <hausmann@webkit.org>
4203
4204         Unreviewed build fix for WebInspector with Qt build.
4205
4206         Simply re-generate the Qt resource file by running
4207         WebKitTools/Scripts/generate-qt-inspector-resource
4208
4209         * inspector/front-end/WebKit.qrc:
4210
4211 2009-11-02  Benjamin Poulain  <benjamin.poulain@nokia.com>
4212
4213         Reviewed by Simon Hausmann.
4214
4215         [Qt] Handle fonts like the other ports
4216
4217         Remove FontFallbackListQt and rely on the common FontFallbackList
4218         to handle the fonts. FontCache and FontPlatformData have been
4219         updated to work with the common FontFallbackList.
4220
4221         In the previous implementation, FontPlatformDataCacheKey
4222         was a clone of FontPlatformData with the hashing
4223         capabilities added in order to use it as a key in the cache's
4224         hashmap. FontPlatformData has been modified to handle the hashing
4225         function directly so the data are not copied twice in memory.
4226
4227         FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
4228         code from FontCache::getFontData() and FontFallbackList::fontDataAt().
4229         The behavior is similar except currFamily->family().length() was
4230         not tested and the fallback fonts selector were not used.
4231
4232         https://bugs.webkit.org/show_bug.cgi?id=29856
4233
4234         Test: svg/text/text-font-invalid.html
4235
4236         * WebCore.pro:
4237         * platform/graphics/qt/FontCacheQt.cpp:
4238         (WebCore::FontCache::platformInit):
4239         (WebCore::FontCache::getFontDataForCharacters):
4240         (WebCore::FontCache::getSimilarFontPlatformData):
4241         (WebCore::FontCache::getLastResortFallbackFont):
4242         (WebCore::FontCache::getTraitsInFamily):
4243         (WebCore::FontCache::createFontPlatformData):
4244         * platform/graphics/qt/FontFallbackListQt.cpp:
4245         Removed. We now use the implementation from FontFallbackList.cpp
4246         * platform/graphics/qt/FontPlatformData.h:
4247         Add hashing capabilities to be able to use the data with the FontCache.
4248         This was previously done in FontCacheQt.cpp
4249         (WebCore::FontPlatformData::FontPlatformData):
4250         Added a boolean to identify deleted value in the hash table.
4251         (WebCore::FontPlatformData::isHashTableDeletedValue):
4252         (WebCore::FontPlatformData::hash):
4253         (WebCore::FontPlatformData::operator==):
4254         * platform/graphics/qt/FontPlatformDataQt.cpp:
4255         (WebCore::FontPlatformData::FontPlatformData):
4256
4257 2009-11-03  Dan Bernstein  <mitz@apple.com>
4258
4259         Leopard build fix
4260
4261         * platform/network/mac/AuthenticationMac.mm:
4262         (WebCore::mac):
4263         (WebCore::core):
4264
4265 2009-11-03  Dan Bernstein  <mitz@apple.com>
4266
4267         Reviewed by Alexey Proskuryakov.
4268
4269         Fix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
4270         authentication in AuthenticationMac
4271
4272         * platform/network/mac/AuthenticationMac.mm:
4273
4274 2009-11-03  Eric Z. Ayers  <zundel@google.com>
4275
4276         Reviewed by Timothy Hatcher.
4277
4278         Fixes a problem where the timeline instrumentation crashes if
4279         timeline profiling is enabled or disabled in the middle of an
4280         event dispatch.
4281
4282         https://bugs.webkit.org/show_bug.cgi?id=31080
4283
4284         Test: inspector/timeline-trivial.html
4285
4286         * bindings/js/ScriptController.cpp:
4287         (WebCore::ScriptController::evaluateInWorld):
4288         (WebCore::ScriptController::processingUserGestureEvent):
4289         * inspector/InspectorTimelineAgent.cpp:
4290         (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
4291         * page/DOMTimer.cpp:
4292         (WebCore::DOMTimer::fired):
4293
4294 2009-11-03  Dan Bernstein  <mitz@apple.com>
4295
4296         Reviewed by Dave Hyatt.
4297
4298         Allow a frame to go back to copy-on-scroll when it ceases being overlapped
4299
4300         The